completing-read-multiple: Ignore empty strings in the list of return values
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8f2906f5
JD
12013-03-16 Jan Djärv <jan.h.d@swipnet.se>
2
960ce480 3 * nsterm.m (updateFrameSize:): Change resize increments if needed.
6615748a 4 (ns_select): Don't return with result uninitialized.
960ce480 5
8f2906f5
JD
6 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
7 and getDirectory.
8
9 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel): New
10 functions.
11 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
12 directories. If filename is nil, get directory name (Bug#13932).
13 Use getFilename and getDirectory.
14 (getFilename, getDirectory): New methods for EmacsSavePanel and
15 EmacsOpenPanel.
16 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
17
cded56c1
PE
182013-03-15 Paul Eggert <eggert@cs.ucla.edu>
19
20 * coding.c (decode_coding_gap): Fix typo caught by static checking.
21
8a44e6d1
KH
222013-03-15 handa <handa@gnu.org>
23
24 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
25 (adjust_after_replace): Make it back to static. Delete the third
26 arg text_at_gap_tail. Cancel the code for handling it.
27
28 * coding.h (struct coding_system): New member eol_seen.
29
30 * coding.c (detect_ascii): New function.
31 (detect_coding): Set coding->head_ascii and coding->eol_seen only
32 when the source bytes are actually scanned. On detecting for
33 coding_category_utf_8_auto, call detect_ascii instead of scanning
34 source bytes directly.
35 (produce_chars): Call insert_from_gap with the new arg 0.
36 (encode_coding): Likewise.
37 (decode_coding_gap): Control ASCII optimization by the variable
38 disable_ascii_optimization instead of #ifndef .. #endif.
39 Deccode EOL format according to coding->eol_seen.
40 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
41 variable.
42
43 * global.h (struct emacs_globals): New member
44 f_disable_ascii_optimization.
45 (disable_ascii_optimization): New macro.
46
47 * lisp.h (adjust_after_replace): Cancel externing it.
48 (insert_from_gap): Adjust prototype.
49
5f795e34
EZ
502013-03-15 Eli Zaretskii <eliz@gnu.org>
51
52 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
53 FULLSCREEN_MAXIMIZED. (Bug#13935)
54
f258b4be
DA
552013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
56
57 * region-cache.c (find_cache_boundary, move_cache_gap)
58 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
59 Simplify debugging check and convert to eassert. Adjust comment.
60 (pp_cache): Put under ENABLE_CHECKING.
61
a5cc4dde
EZ
622013-03-14 Eli Zaretskii <eliz@gnu.org>
63
64 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
65 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
66 and WM_ACTIVATEAPP.
67 (w32fullscreen_hook): If the frame is visible, reset
68 f->want_fullscreen flag after changing the frame size. If the
69 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
70 (Bug#13953)
71
3fc5e44a
DC
722013-03-13 Daniel Colascione <dancol@dancol.org>
73
74 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
75 too so that these builds can use Cygwin's file conversion
76 functions. (We've been building and linking cygw32.o all along
77 and just not using it.)
78
47d7532e
PE
792013-03-13 Paul Eggert <eggert@cs.ucla.edu>
80
81 File synchronization fixes (Bug#13944).
82 * Makefile.in (LIB_FDATASYNC): New macro.
83 (LIBES): Use it.
84 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
85 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
86 Don't worry about HAVE_FSYNC, since a substitute fsync is
87 available if the system lacks one.
88 (Fwrite_regin): Retry fsync if interrupted.
89
c7ffccaf
EZ
902013-03-13 Eli Zaretskii <eliz@gnu.org>
91
4e2df81d 92 * w32term.c (w32_read_socket): If the Emacs frame is being
c7ffccaf
EZ
93 activated, call w32fullscreen_hook, to make sure the new frame
94 dimensions are in effect. (Bug#13937)
95
8a7debc1
DA
962013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
97
98 * xdisp.c (init_iterator): Simplify because both character and byte
99 positions are either specified or -1. Add eassert. Adjust comment.
ffcd945e
DA
100 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
101 character and byte positions can be obtained from marker.
8a7debc1 102
7fd8c501
PE
1032013-03-13 Paul Eggert <eggert@cs.ucla.edu>
104
d9df6f40
PE
105 Static checking by Sun C 5.12.
106 * alloc.c (buffer_memory_full) [REL_ALLOC]:
107 * bytecode.c (exec_byte_code):
108 * dispnew.c (init_display):
109 * eval.c (error):
110 * fileio.c (Fsubstitute_in_file_name):
111 * keyboard.c (Fevent_convert_list):
112 * keymap.c (Fsingle_key_description):
113 * term.c (maybe_fatal, fatal):
114 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
115 * xsmfns.c (Fhandle_save_session):
116 Omit unreachable code.
117 * keymap.c (map_keymap_char_table_item): Cast void * to
118 a function pointer type; the C Standard requires this.
119
7fd8c501
PE
120 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
121 Include <sys/param.h> unconditionally, as that works elsewhere and
122 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
123 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
124 and FreeBSD now.
125
cb0290df
PE
1262013-03-11 Paul Eggert <eggert@cs.ucla.edu>
127
128 * insdel.c (adjust_after_replace): Use bool for boolean.
129
cbae07d5
SM
1302013-03-11 Stefan Monnier <monnier@iro.umontreal.ca>
131
132 * keyboard.c: Move keyboard decoding to read_key_sequence.
133 (decode_keyboard_code): Remove.
134 (tty_read_avail_input): Don't try to decode input.
135 (read_decoded_char): New function.
136 (read_key_sequence): Use it.
137
819e2da9
DC
1382013-03-10 Daniel Colascione <dancol@dancol.org>
139
140 * w32term.h (GUISTR, GUI_ENCODE_FILE, GUI_ENCODE_SYSTEM, GUI_FN)
141 (GUI_SDATA, guichar_t): Macros to abstract out differences between
142 NTGUI_UNICODE and !NTGUI_UNICODE builds, some moved out of
143 w32fns.c.
144
145 * w32term.c (construct_drag_n_drop): Use the above macros to make
146 drag-and-drop work for non-ASCII filenames in cygw32 builds.
147
148 * w32fns.c (x_set_name, x_set_title): Use the above macros to
149 properly display non-ASCII frame titles in cygw32 builds.
150
151 * w32fns.c (Fw32_shell_execute): Use the above macros to properly
152 call ShellExecute in cygw32 builds.
153
154 * w32fn.c (Fx_file_dialog): Use the above macros to simplify the
155 common file dialog code.
156
157 * w32fns.c (Ffile_system_info): Remove from cygw32 builds, which
158 can just use du like other systems.
159
160 * coding.c (from_unicode_buffer): Declare.
161 * coding.c (from_unicode_buffer): Implement.
162
99ec1647
SM
1632013-03-10 Stefan Monnier <monnier@iro.umontreal.ca>
164
d2e24f92
SM
165 * lread.c: Minor cleanup.
166 (FROM_FILE_P): New macro.
167 (skip_dyn_bytes, unreadchar, read1): Use it.
168 (read_list): Consolidate duplicated code.
169
99ec1647
SM
170 * bytecode.c (struct byte_stack): Remove `constants' when unused.
171
138c0ae8
EZ
1722013-03-10 Eli Zaretskii <eliz@gnu.org>
173
174 * xdisp.c (display_tool_bar_line, redisplay_tool_bar)
175 (redisplay_internal, set_cursor_from_row, try_window)
176 (try_window_id, dump_glyph_row, extend_face_to_end_of_line)
177 (display_line, notice_overwritten_cursor)
99ec1647
SM
178 (mouse_face_from_buffer_pos, note_mouse_highlight):
179 Use MATRIX_ROW_DISPLAYS_TEXT_P.
138c0ae8 180 (note_mouse_highlight): Use MATRIX_ROW_GLYPH_START.
99ec1647
SM
181 (mouse_face_from_string_pos, fast_find_string_pos):
182 Use MATRIX_ROW_VPOS.
138c0ae8
EZ
183
184 * xfns.c (Fx_show_tip): Use MATRIX_ROW_DISPLAYS_TEXT_P.
185
186 * w32fns.c (Fx_show_tip): Use MATRIX_ROW_DISPLAYS_TEXT_P.
187
188 * xdisp.c (try_cursor_movement): Use MATRIX_ROW and
189 MATRIX_MODE_LINE_ROW.
190
191 * dispnew.c (update_window): Use MATRIX_ROW and MATRIX_MODE_LINE_ROW.
192
c230dd7d
KH
1932013-03-10 handa <handa@gnu.org>
194
195 * lisp.h (adjust_after_replace): Extern it.
196
197 * coding.c (detect_coding): Cound the heading ASCII bytes in the
198 case of detection for coding_category_utf_8_auto.
99ec1647
SM
199 (decode_coding_gap) [not CODING_DISABLE_ASCII_OPTIMIZATION]:
200 Skip decoding if all bytes are ASCII.
c230dd7d
KH
201
202 * insdel.c (adjust_after_replace): Make it public. New arg
203 text_at_gap_tail.
204 (adjust_after_insert): Call adjust_after_replace with the new arg
205 value 0.
206
27a98a62
SM
2072013-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
208
209 * keyboard.h (EVENT_START, EVENT_END, POSN_WINDOW, POSN_POSN)
210 (POSN_WINDOW_POSN, POSN_TIMESTAMP): Be careful since events may come
211 from Elisp via unread-command-events.
212
213 * keyboard.c (access_keymap_keyremap): Accept nil return value from
214 functions to mean "no change".
215
457882c2
PE
2162013-03-08 Paul Eggert <eggert@cs.ucla.edu>
217
218 region-cache.c, scroll.c, search.c: Use bool for booleans.
219 * lisp.h (compile_pattern):
220 * scroll.c (do_scrolling, do_direct_scrolling):
221 * search.c (struct regexp_cache, compile_pattern_1)
222 (compile_pattern, string_match_1, search_command)
223 (trivial_regexp_p, search_buffer, Freplace_match, match_limit)
224 (search_regs_saved, Fregexp_quote):
225 Use bool for boolean.
226 * region-cache.c (region_cache_forward, region_cache_backward):
227 Fix comments to match code: these functions return int, not boolean.
228
b5426561
DA
2292013-03-08 Dmitry Antipov <dmantipov@yandex.ru>
230
231 * search.c (find_newline): Accept start and end byte positions
232 as arguments and allow -1 if not known.
233 (find_newline_no_quit): Likewise for start position.
234 * lisp.h (find_newline, find_newline_no_quit): Adjust prototype.
235 * bidi.c (bidi_find_paragraph_start): Pass byte position to
236 find_newline_no_quit, thus eliminating CHAR_TO_BYTE.
27a98a62
SM
237 * editfns.c (Fconstrain_to_field): Break long line.
238 Adjust call to find_newline.
b5426561
DA
239 * indent.c (vmotion): Adjust calls to find_newline_no_quit.
240 Use DEC_BOTH to start next search from the previous buffer
241 position, where appropriate.
242 * xdisp.c (back_to_previous_line_start, forward_to_next_line_start)
243 (get_visually_first_element, move_it_vertically_backward): Likewise.
244 Obtain byte position from the display iterator, where appropriate.
245
0bce5d9e
PE
2462013-03-08 Paul Eggert <eggert@cs.ucla.edu>
247
248 print.c, process.c: Use bool for booleans.
249 * lisp.h (wait_reading_process_output):
250 * print.c (print_output_debug_flag, PRINTDECLARE, printchar)
251 (strout, debug_output_compilation_hack, float_to_string, print)
252 (print_object):
253 * process.c (kbd_is_on_hold, inhibit_sentinels, process_output_skip)
254 (decode_status, status_message, create_process, create_pty)
255 (Fmake_network_process, Fnetwork_interface_info)
256 (wait_reading_process_output, read_process_output)
257 (write_queue_push, write_queue_pop, process_send_signal)
258 (handle_child_signal, keyboard_bit_set, kbd_on_hold_p):
259 * process.h (struct Lisp_Process, inhibit_sentinels, kbd_on_hold_p):
260 Use bool for booleans.
261 * process.c (Fnetwork_interface_list): Remove unused local.
262 (connect_counter): Now EMACS_INT, not int.
263
36075a19
DA
2642013-03-08 Dmitry Antipov <dmantipov@yandex.ru>
265
266 * bidi.c (bidi_fetch_char): Swap first and second arguments
267 to match other functions accepting character and byte positions.
268 Adjust comment.
269 (bidi_resolve_explicit_1, bidi_level_of_next_char): Adjust users.
270 (bidi_paragraph_init): Likewise. Use DEC_BOTH which is faster
271 when you need just to move to the previous buffer position.
272 * xdisp.c (Fcurrent_bidi_paragraph_direction): Use DEC_BOTH.
273
4aae1914
EZ
2742013-03-07 Eli Zaretskii <eliz@gnu.org>
275
276 * .gdbinit (prowlims): Display the enabled_p flag of the row.
277
c54aa166
DA
2782013-03-07 Dmitry Antipov <dmantipov@yandex.ru>
279
280 Avoid character to byte conversions in motion subroutines.
281 * indent.h (compute_motion, vmotion): Add byte position argument.
282 * indent.c (compute_motion): Use it and avoid CHAR_TO_BYTE.
283 Add eassert.
284 (Fcompute_motion): Break long line. Adjust call to compute_motion.
285 Use list5 for return value.
286 (vmotion): Use byte position argument and avoid call to CHAR_TO_BYTE.
287 Adjust comments, style and calls to compute_motion.
288 (Fvertical_motion): Adjust call to vmotion.
289 * window.c (Fdelete_other_windows_internal): Record window start
290 byte position and adjust call to vmotion.
291 (window_scroll_line_based): Likewise with call to compute_motion.
292 Use SET_PT_BOTH.
293 (Frecenter): Adjust calls to vmotion.
294
3de717bd
DA
2952013-03-07 Dmitry Antipov <dmantipov@yandex.ru>
296
297 * lisp.h (list2i, list3i): New functions.
298 (list4i): Move from window.c and make LISP_INLINE.
299 * editfns.c (make_lisp_time):
300 * fns.c (Flocale_info):
301 * keyboard.c (parse_modifiers):
302 * xterm.c (x_ewmh_activate_frame): Use list2i.
303 * instel.c (signal_after_change):
304 * nsfns.m (Fx_server_version, Fxw_color_values):
305 * w32fns.c (Fxw_color_values, Fx_server_version):
306 * xfns.c (Fxw_color_values, Fx_server_version): Use list3i.
307 * fileio.c (Fvisited_file_modtime):
308 * nsfns.m (Fns_display_usable_bounds):
309 * w32.c (ltime): Use list4i.
310
d26e478e
EZ
3112013-03-06 Eli Zaretskii <eliz@gnu.org>
312
a611149e
EZ
313 * search.c (find_newline_no_quit): Rename from find_next_newline.
314 Add commentary.
315
316 * lisp.h (find_newline_no_quit): Rename prototype.
317
318 * xdisp.c (back_to_previous_line_start)
319 (forward_to_next_line_start, get_visually_first_element)
320 (move_it_vertically_backward): Callers of find_newline_no_quit changed.
321 * indent.c (vmotion): Callers of find_newline_no_quit changed.
322 * bidi.c (bidi_find_paragraph_start): Callers of
323 find_newline_no_quit changed.
324
d26e478e
EZ
325 * msdos.c: Change encoding to cp850. (Bug#13879)
326 (fr_keyboard, it_keyboard, dk_keyboard): Update keyboard layouts.
327
1af1a51a
DA
3282013-03-06 Dmitry Antipov <dmantipov@yandex.ru>
329
330 Coding system support cleanup and minor refactoring.
331 * coding.h (enum coding_result_code): Remove
332 CODING_RESULT_INCONSISTENT_EOL and CODING_RESULT_INSUFFICIENT_MEM.
333 (toplevel): Remove unused CODING_MODE_INHIBIT_INCONSISTENT_EOL.
334 (CODING_MODE_LAST_BLOCK, CODING_MODE_SELECTIVE_DISPLAY)
335 (CODING_MODE_DIRECTION, CODING_MODE_FIXED_DESTINATION)
336 (CODING_MODE_SAFE_ENCODING): Rearrange bit values.
337 (decode_coding_region, encode_coding_region, decode_coding_string):
338 Remove unused compatibility macros.
339 * coding.c (Qinconsistent_eol, Qinsufficient_memory): Remove.
340 (record_conversion_result): Adjust user.
341 (syms_of_coding): Likewise.
342 (ALLOC_CONVERSION_WORK_AREA): Use SAFE_ALLOCA.
343 (decode_coding, encode_coding): Add USE_SAFE_ALLOCA and SAFE_FREE.
344 (decode_coding_object): Simplify since xrealloc never returns NULL.
345 Add eassert.
346
0bafabe7 3472013-03-06 Paul Eggert <eggert@cs.ucla.edu>
725eb027 348
9b1c3271 349 Fix a build failure on OpenBSD 4.x and MirBSD (Bug#13881).
0845a75c
PE
350 * sysdep.c (list_system_processes)
351 [BSD_SYSTEM && !DARWIN_OS && !__FreeBSD__]:
9b1c3271 352 Make it a stub in this case; otherwise the build might fail,
0845a75c 353 and this code hasn't been tested on such hosts anyway.
725eb027 354 Problem reported by Nelson H. F. Beebe in
9b1c3271
PE
355 <http://lists.gnu.org/archive/html/emacs-devel/2013-03/msg00021.html>
356 and analyzed by Jérémie Courrèges-Anglas in
357 <http://lists.gnu.org/archive/html/emacs-devel/2013-03/msg00062.html>.
725eb027 358
ffc65bee
DA
3592013-03-06 Dmitry Antipov <dmantipov@yandex.ru>
360
361 * lisp.h (find_next_newline_no_quit): Rename to find_next_newline.
362 * xdisp.c (back_to_previous_line_start, forward_to_next_line_start)
363 (get_visually_first_element, move_it_vertically_backward): Ajust users.
364 * bidi.c (bidi_find_paragraph_start): Likewise.
365 * indent.c (vmotion): Likewise.
366
70743157
PE
3672013-03-05 Paul Eggert <eggert@cs.ucla.edu>
368
369 FILE's lock is now always .#FILE and may be a regular file (Bug#13807).
370 * filelock.c: Include <c-ctype.h>.
371 (MAX_LFINFO): New top-level constant.
372 (lock_info_type): Remove members pid, boot_time. Add members at,
373 dot, colon. Change user member to be the entire buffer, not a
374 pointer. This allows us to handle the case where a foreign
375 pid or boot time exceeds the local range. All uses changed.
376 (LINKS_MIGHT_NOT_WORK): New constant.
377 (FREE_LOCK_INFO): Remove, as the pieces no longer need freeing.
378 (defined_WINDOWSNT): Remove.
379 (MAKE_LOCK_NAME, file_in_lock_file_name):
380 Always use .#FILE (not .#-FILE) for the file lock,
381 even if it is a regular file.
382 (rename_lock_file): New function.
383 (create_lock_file): Use it.
384 (create_lock_file, read_lock_data):
385 Prefer a symbolic link for the lock file, falling back on a
386 regular file if symlinks don't work. Do not try to create
387 symlinks on MS-Windows, due to security hassles. Stick with
388 POSIXish functions (open, read, write, close, fchmod, readlink, symlink,
389 link, rename, unlink, mkstemp) when creating locks, as a GNUish
390 host may be using a Windowsish file system, and cannot use
391 MS-Windows-only system calls. Fall back on mktemp if mkstemp
392 doesn't work. Don't fail merely because of a symlink-contents
393 length limit in the current file system; fall back on regular
394 files. Increase the symlink contents length limit to 8 KiB, this
395 should be big enough for any real use and doesn't crunch the
396 stack.
397 (create_lock_file, lock_file_1, read_lock_data):
398 Simplify allocation of lock file buffers now that they fit in 8 KiB.
399 (lock_file_1): Return error number, not bool. All callers changed.
400 (ELOOP): New macro, if not already defined.
401 (read_lock_data): Return size of lock file contents, not Lisp object.
402 All callers changed. Handle a race condition if some other process
403 replaces a regular-file lock with a symlink lock or vice versa,
404 while we're trying to read the lock.
405 (current_lock_owner): Parse contents more carefully, to help avoid
406 confusing a regular-file lock with some other application's use
407 of the file. Check for lock file contents being too long, or
408 not parsing correctly.
409 (current_lock_owner, lock_file):
410 Allow foreign pid and boot times that exceed the local range.
411 (current_lock_owner, lock_if_free, lock_file):
412 Simplify allocation of lock file contents.
413 * w32.c (sys_rename_replace): New function, containing most of
414 the contents of the old sys_rename.
415 (sys_rename): Use it.
416 (fchmod): New dummy function.
417 * w32.h (sys_rename_replace, fchmod): New decls.
418
05e193f1
EZ
4192013-03-05 Eli Zaretskii <eliz@gnu.org>
420
421 * bidi.c (bidi_resolve_explicit_1): Don't call CHAR_TO_BYTE or
422 bidi_count_bytes, as the callers now arrange for bidi_it->charpos
423 to be in sync with bidi_it->bytepos. Suggested by Dmitry Antipov
424 <dmantipov@yandex.ru>.
425
3bfc46eb
DA
4262013-03-05 Dmitry Antipov <dmantipov@yandex.ru>
427
428 * composite.c (get_composition_id, fill_gstring_header):
429 Use make_uninit_vector where appropriate.
430 * font.c (Ffont_get_glyphs, build_style_table): Likewise.
431 * xselect.c (clean_local_selection_data): Likewise.
432
84ac6f9d
PE
4332013-03-04 Paul Eggert <eggert@cs.ucla.edu>
434
435 Fix misuse of ImageMagick that caused core dump (Bug#13846).
436 * image.c (imagemagick_load_image): Calculate height and width
437 after flattening the image, not before.
438
42926ec8
DA
4392013-03-04 Dmitry Antipov <dmantipov@yandex.ru>
440
441 * font.c (Ffont_get_glyphs): Use convenient LGLYPH_NEW.
442 * ftfont.c (ftfont_shape_by_flt): Likewise.
443 * w32uniscribe.c (uniscribe_shape): Likewise.
444
b5029e23
PE
4452013-03-02 Paul Eggert <eggert@cs.ucla.edu>
446
447 The lock for FILE is now .#FILE or .#-FILE (Bug#13807).
448 The old approach, which fell back on DIR/.#FILE.0 through
449 DIR/.#FILE.9, had race conditions that could not be easily fixed.
450 If DIR/.#FILE is a non-symlink file, Emacs now does not create a
451 lock file for DIR/FILE; that is, DIR/FILE is no longer partly
452 protected by a lock if DIR/.#FILE is a non-symlink file ("partly"
453 because the locking mechanism was never reliable in that case).
454 This patch fixes this and other bugs discovered by a code
455 inspection that was prompted by
456 <http://lists.gnu.org/archive/html/emacs-devel/2013-02/msg00531.html>.
457 Also, this patch switches to .#-FILE (not .#FILE) on MS-Windows,
458 to avoid interoperability problems between the MS-Windows and
459 non-MS-Windows implementations. MS-Windows and non-MS-Windows
460 instances of Emacs now ignore each others' locks.
461 * filelock.c (defined_WINDOWSNT): New constant.
462 (MAKE_LOCK_NAME, fill_in_lock_file_name):
463 Don't create DIR/.#FILE.0 through DIR/.#FILE.9. Instead, create
464 DIR/.#FILE symlinks on non-MS-Windows hosts, and DIR/.#-FILE
465 regular files on MS-Windows hosts.
466 (MAKE_LOCK_NAME, unlock_file, Ffile_locked_p):
467 Use SAFE_ALLOCA to avoid problems with long file names.
468 (MAX_LFINFO): Now a local constant, not a global macro.
469 (IS_LOCK_FILE): Remove.
470 (lock_file_1): Don't inspect errno if symlink call succeeds;
471 that's not portable.
472 (lock_file): Document that this function can return if lock
473 creation fails.
2db41375 474 (lock_file): Don't access freed storage.
b5029e23 475
b270d116
AS
4762013-03-02 Andreas Schwab <schwab@linux-m68k.org>
477
478 * lisp.h (XPNTR) [!USE_LSB_TAG]: Remove extra paren. (Bug#13734)
479
81c23309
PE
4802013-03-02 Paul Eggert <eggert@cs.ucla.edu>
481
482 * textprop.c: Use bool for booleans.
483 (validate_interval_range, Fadd_text_properties)
484 (Fremove_text_properties): Prefer bool to int when either works.
485
18f2ac09
EZ
4862013-03-02 Eli Zaretskii <eliz@gnu.org>
487
27a98a62
SM
488 * textprop.c (Fadd_text_properties, Fremove_text_properties):
489 If the interval tree changes as a side effect of calling
18f2ac09
EZ
490 modify_region, re-do processing starting from the call to
491 validate_interval_range. (Bug#13743)
492
929aeac6 4932013-02-28 Eli Zaretskii <eliz@gnu.org>
c49e2256
EZ
494
495 * w32.c (sys_open): Don't reset the flags for FD in fd_info[].
496 (Bug#13546).
497
531e70ec
EZ
4982013-02-27 Eli Zaretskii <eliz@gnu.org>
499
500 * filelock.c (create_lock_file) [WINDOWSNT]: Use _sopen with
501 _SH_DENYRW flag, instead of emacs_open, to deny any other process
502 access to the lock file until it is written and closed.
503 (Bug#13807)
504
6e65b9cc
PE
5052013-02-27 Paul Eggert <eggert@cs.ucla.edu>
506
507 * callint.c (Qcall_interactively):
508 * macros.c (Qexecute_kbd_macro):
509 Now static.
510
3b166f09
BG
5112013-02-26 Bastien Guerry <bzg@gnu.org>
512
513 * window.c (Frecenter): Tiny docstring enhancement.
514
ecc0fdd4
PE
5152013-02-26 Paul Eggert <eggert@cs.ucla.edu>
516
517 Minor textprop integer cleanup.
518 * intervals.h, textprop.c (add_text_properties_from_list):
519 Return void, not int, since nobody uses the return value.
520 * textprop.c (validate_plist, add_properties, remove_properties)
521 (Fadd_text_properties):
522 Don't assume list length fits in int.
523 (interval_has_all_properties, interval_has_some_properties)
524 (interval_has_some_properties_list, add_properties, remove_properties)
525 (Fadd_text_properties, Fremove_text_properties)
526 (Fremove_list_of_text_properties, text_property_stickiness):
527 Use bool for booleans.
528 (Fadd_text_properties, Fremove_text_properties):
529 (Fremove_list_of_text_properties):
530 Reindent do-while as per GNU style.
531
0248b0d7
EZ
5322013-02-25 Eli Zaretskii <eliz@gnu.org>
533
343a2aef
EZ
534 Implement CLASH_DETECTION for MS-Windows.
535
536 * filelock.c [WINDOWSNT]: Include w32.h.
537 (MAKE_LOCK_NAME): Don't use 'lock', it clashes with MS runtime
538 function of that name. Up-case the macro arguments.
539 (IS_LOCK_FILE): New macro.
540 (fill_in_lock_file_name): Use IS_LOCK_FILE instead of S_ISLNK.
541 (create_lock_file): New function, with body extracted from
542 lock_file_1.
543 [WINDOWSNT]: Implement lock files by writing a regular file with
544 the lock information as its contents.
545 (read_lock_data): New function, on Posix platforms just calls
546 emacs_readlinkat.
547 [WINDOWSNT]: Read the lock info from the file.
548 (current_lock_owner): Call read_lock_data instead of calling
549 emacs_readlinkat directly.
550 (lock_file) [WINDOWSNT]: Run the file name through
551 dostounix_filename.
552
553 * w32proc.c (sys_kill): Support the case of SIG = 0, in which case
554 just check if the process by that PID exists.
555
556 * w32.c (sys_open): Don't reset the _O_CREAT flag if _O_EXCL is
557 also present, as doing so will fail to error out if the file
558 already exists.
559
560 * makefile.w32-in ($(BLD)/filelock.$(O)): Depend on src/w32.h.
561
0248b0d7
EZ
562 * textprop.c (Fadd_text_properties, Fremove_text_properties)
563 (Fremove_list_of_text_properties): Skip all of the intervals in
564 the region between START and END that already have resp. don't
27a98a62
SM
565 have the requested properties, not just the first one.
566 Add assertions that the loop afterwards always modifies the
0248b0d7
EZ
567 properties. (Bug#13743)
568
b5071fc7
SM
5692013-02-25 Stefan Monnier <monnier@iro.umontreal.ca>
570
571 * callint.c (Fcall_interactively): Use the right lexical environment
572 for `interactive' specs (bug#13811).
573 * eval.c (Feval): Accept a lexical environment.
574
1ddc2bd6
PE
5752013-02-25 Paul Eggert <eggert@cs.ucla.edu>
576
577 Simplify data_start configuration (Bug#13783).
578 This is a followon simplification to the fix for Bug#13650.
579 * Makefile.in (LD_FIRSTFLAG, LIB_GCC, CRT_DIR, LIB_STANDARD)
580 (START_FILES): Remove. All uses removed.
581 (otherobj): Remove $(VMLIMIT_OBJ), as it's now first.
582 (ALLOBJS): Move here from autodeps.mk, and with VMLIMITS_OBJ first.
583 (buildobj.h): Use it.
584 ($(ALLOBJS)): Depend on globals.h.
585 (temacs$(EXEEXT)): Use $(ALLOBJS).
586 * autodeps.mk (ALLOBJS): Move to Makefile.in.
587 * deps.mk (vm-limit.o):
588 * makefile.w32-in ($(BLD)/vm-limit.$(O)):
589 Do not depend on mem-limits.h.
590 * emacs.c (__do_global_ctors, __do_global_ctors_aux)
591 (__do_global_dtors, __CTOR_LIST__, __DTOR_LIST__)
592 [__GNUC__ && !ORDINARY_LINK]: Remove.
593 * mem-limits.h, pre-crt0.c: Remove.
594 * unexaix.c, unexcoff.c: Don't include mem-limits.h.
595 * unexcoff.c (etext): New decl.
596 (make_hdr): Use DATA_START instead of start_of_data.
597 * vm-limit.c: Move most of mem-limits.h's contents here.
598 (data_start): New decl. It's OK if this is approximate,
599 so simplify-away some unnecessary exactness.
600 (POINTER): Remove; all uses removed.
601 (data_space_start): Now char *, to avoid casts.
602 (exceeds_lisp_ptr): New function, replacing the old
603 EXCEEDS_LISP_PTR macro. All uses changed.
604 (check_memory_limits): Simplify and remove casts.
605 (start_of_data) [!CANNOT_DUMP || !SYSTEM_MALLOC]: Remove.
606 (memory_warnings): Use data_start instead of start_of_data.
607
51aa2a8b
AS
6082013-02-24 Andreas Schwab <schwab@linux-m68k.org>
609
610 * xdisp.c (set_message): Only check for debug-on-message if STRING
611 is a string. (Bug#13797)
612
1938d88c
PE
6132013-02-24 Paul Eggert <eggert@cs.ucla.edu>
614
615 Fix regression introduced by July 10 filelock.c patch.
616 * filelock.c (fill_in_lock_file_name): Fix crash caused by the
617 2012-07-10 patch to this file. Reported by Eli Zaretskii in
618 <http://lists.gnu.org/archive/html/emacs-devel/2013-02/msg00533.html>
619 and diagnosed by Andreas Schwab in
620 <http://lists.gnu.org/archive/html/emacs-devel/2013-02/msg00534.html>.
621
fcee5028
PE
6222013-02-22 Paul Eggert <eggert@cs.ucla.edu>
623
624 Assume C89 or better.
625 * ralloc.c (SIZE, POINTER, NIL):
626 * vm-limit.c (POINTER):
627 Remove, replacing all uses with C89 equivalents. These old
628 symbols were present only for porting to pre-C89 platforms.
629
d78cf5ed
CB
6302013-02-22 Claudio Bley <claudio.bley@gmail.com>
631
632 * w32.c (emacs_gnutls_pull): Don't call 'select', and don't loop.
633 This avoids warning messages reported as part of Bug#13546.
634
6bcd97a4
KB
6352013-02-21 Ken Brown <kbrown@cornell.edu>
636
637 * sheap.c (report_sheap_usage): Fix arguments of message1_no_log.
638
b6c2bfff
SM
6392013-02-20 Stefan Monnier <monnier@iro.umontreal.ca>
640
e11dacb5
SM
641 * sheap.c (report_sheap_usage): Prefer message1_nolog.
642
b6c2bfff
SM
643 * keyboard.c (Qcommand_execute): New var.
644 (command_loop_1, read_char): Use it.
645 (Fcommand_execute): Remove, replace by an Elisp implementation.
646 (syms_of_keyboard): Adjust accordingly.
647
d69f1120 6482013-02-19 Daniel Colascione <dancol@dancol.org>
b6c2bfff 649
d69f1120
DC
650 * sheap.c (report_sheap_usage): Use message, not message1, so
651 that we don't try to create a buffer while we're in the middle
652 of dumping Emacs. Explain why.
b6c2bfff 653
2a14a4f1 6542013-02-20 Dmitry Antipov <dmantipov@yandex.ru>
42926ec8 655
2a14a4f1
DA
656 * search.c (find_newline): Return byte position in bytepos.
657 Adjust comment.
b6c2bfff
SM
658 (find_next_newline_no_quit, find_before_next_newline):
659 Add bytepos argument.
2a14a4f1
DA
660 * lisp.h (find_newline, find_next_newline_no_quit)
661 (find_before_next_newline): Adjust prototypes.
662 * bidi.c (bidi_find_paragraph_start):
663 * editfns.c (Fconstrain_to_field, Fline_end_position):
664 * indent.c (compute_motion, vmotion):
665 * xdisp.c (back_to_previous_line_start, forward_to_next_line_start):
666 (get_visually_first_element, move_it_vertically_backward):
667 Adjust users and avoid calls to CHAR_TO_BYTE where appropriate.
668
872faefb 6692013-02-19 Eli Zaretskii <eliz@gnu.org>
17ddfd15
EZ
670
671 * w32proc.c (new_child): Avoid leaking handles if the subprocess
672 resources were not orderly released.
673
fd80c659
EZ
6742013-02-17 Eli Zaretskii <eliz@gnu.org>
675
676 * xdisp.c (x_draw_vertical_border): For a window that is neither
677 the leftmost nor the rightmost, redraw both the left and the right
678 vertical borders. (Bug#13723)
679
2f73da9c
SM
6802013-02-17 Stefan Monnier <monnier@iro.umontreal.ca>
681
682 * xml.c (init_libxml2_functions):
683 * sound.c (sound_warning):
684 * sheap.c (report_sheap_usage):
685 * process.c (wait_reading_process_output):
686 * msdos.c (XMenuActivate):
687 * macros.c (Fstart_kbd_macro, Fend_kbd_macro):
688 * keyboard.c (top_level_1):
689 * editfns.c (Fmessage, Fmessage_box):
690 * callint.c (Fcall_interactively):
691 * fns.c (Fyes_or_no_p): Prefer `message1' over `message'.
692
fd9547e8
JD
6932013-02-17 Jan Djärv <jan.h.d@swipnet.se>
694
695 * xterm.c (syms_of_xterm): Move scroll-bar-adjust-thumb-portion ...
fd9547e8
JD
696 * frame.c (syms_of_frame): ... to here.
697
f277993b
EZ
6982013-02-16 Eli Zaretskii <eliz@gnu.org>
699
c7939585
EZ
700 * w32.c (sys_chown): Remove unused function.
701
cd91fb4b
EZ
702 * w32term.c <input_signal_count>: Declare 'volatile'
703 unconditionally. (Bug#9066)
704
f277993b
EZ
705 * w32.c (set_errno): Reset h_errno and don't set it to any other
706 value. Set errno instead.
707 (check_errno): Reset h_errno.
708 (sys_socket, socket_to_fd, sys_bind, sys_connect)
709 (sys_gethostname, sys_getservbyname, sys_getpeername)
710 (sys_shutdown, sys_setsockopt, sys_listen, sys_getsockname)
711 (sys_accept, sys_recvfrom, sys_sendto, fcntl, sys_read): Don't set
712 h_errno.
713 (sys_gethostbyname): Set h_errno only errors detected.
714
e454145b
PE
7152013-02-15 Paul Eggert <eggert@cs.ucla.edu>
716
717 * process.c (h_errno) [!HAVE_H_ERRNO]: Remove unused decl.
718
bcf7fe2a
EZ
7192013-02-15 Eli Zaretskii <eliz@gnu.org>
720
ef9c57e2
EZ
721 * keyboard.c (read_char): Fix calculation of auto-save time out
722 when auto-save-timeout is less than 4. (Bug#13720)
723
ef862e20 724 * w32proc.c (new_child): Free up to 2 slots of dead processes at a
b2af991a 725 time. Improve diagnostics in DebPrint. (Bug#13546)
ef862e20 726
bcf7fe2a
EZ
727 * w32.c (sys_socket, sys_bind, sys_connect, sys_gethostname)
728 (sys_gethostbyname, sys_getservbyname, sys_getpeername)
729 (sys_shutdown, sys_setsockopt, sys_listen, sys_getsockname)
730 (sys_accept, sys_recvfrom, sys_sendto, fcntl): In case of failure,
731 make sure errno is set to an appropriate value. (Bug#13546)
732 (socket_to_fd): Add assertion against indexing fd_info[] with a
733 value that is out of bounds.
734 (sys_accept): If fd is negative, do not set up the child_process
735 structure for reading.
736
0063fdb1
DA
7372013-02-15 Dmitry Antipov <dmantipov@yandex.ru>
738
739 * composite.c (fill_gstring_header): Remove useless prototype.
740 Break long line.
741 * lisp.h (message_dolog, compile_pattern): Adjust prototype.
742 * print.c (PRINTDECLARE, print_object):
743 * search.c (compile_pattern, fast_looking_at, search_buffer):
744 (simple_search, boyer_moore, Freplace_match):
745 * xdisp.c (c_string_pos, number_of_chars, message_dolog):
746 (get_overlay_arrow_glyph_row, display_mode_element):
747 (decode_mode_spec_coding, message3):
748 * xfaces.c (face_at_string_position): Use bool for booleans.
749 Adjust comments.
750
648e5523 7512013-02-15 Paul Eggert <eggert@cs.ucla.edu>
974c7646 752
35b3a27e
PE
753 Fix AIX port (Bug#13650).
754 * lisp.h (XPNTR) [!USE_LSB_TAG && DATA_SEG_BITS]:
755 Fix bug introduced in 2012-07-27 change. DATA_SEG_BITS, if set,
756 was #undeffed earlier, so it cannot be used as a macro here.
757 Use the constant and not the macro.
35b3a27e 758
648e5523 7592013-02-15 Eli Zaretskii <eliz@gnu.org>
6e432f0c 760
0e4e7b74
EZ
761 * w32proc.c (new_child): If no vacant slots are found in
762 child_procs[], make another pass looking for slots whose process
763 has exited or died. (Bug#13546)
764
6e432f0c
EZ
765 * w32.c (sys_pipe): When failing due to file descriptors above
766 MAXDESC, set errno to EMFILE.
767 (_sys_read_ahead): Update cp->status when failing to read serial
768 communications input, so that the status doesn't stay at
769 STATUS_READ_IN_PROGRESS. (Bug#13546)
770
51b3a99c
JD
7712013-02-14 Jan Djärv <jan.h.d@swipnet.se>
772
773 * gtkutil.c (tb_size_cb): New function.
774 (xg_create_tool_bar): Connect size-allocate to tb_size_cb (Bug#13512).
775
e31560a7
SM
7762013-02-14 Stefan Monnier <monnier@iro.umontreal.ca>
777
778 * keyboard.c (active_maps): Fcurrent_active_maps expects a position, not
779 an event.
780
fe336261
SM
7812013-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
782
783 * keyboard.c (syms_of_keyboard): Further tweaks of docstring.
784
5a655b9f
DA
7852013-02-13 Dmitry Antipov <dmantipov@yandex.ru>
786
787 * font.c (font_range): Add pos_byte argument. Adjust comment
788 and break long line.
789 * font.h (font_range): Adjust prototype.
790 * composite.c (autocmp_chars): Pass byte position to font_range.
791 Break long line. Remove useless prototype and format comment.
792
1a359750
GM
7932013-02-13 Glenn Morris <rgm@gnu.org>
794
795 * keyboard.c (input-decode-map, key-translation-map): Doc fixes.
796
01fcc3a5 7972013-02-13 Paul Eggert <eggert@cs.ucla.edu>
4458c255 798
f53f992a
PE
799 Improve AIX port some more (Bug#13650).
800 With this, it should be as good as it was in 23.3, though it's
801 still pretty bad: the dumped emacs does not run. See Mark Fleishman in
802 http://lists.gnu.org/archive/html/help-gnu-emacs/2011-04/msg00287.html
803 * unexaix.c (start_of_text): Remove.
804 (_data, _text): Declare as char[], not int, as AIX manual suggests.
805 (bias, lnnoptr, text_scnptr, data_scnptr, load_scnptr)
806 (orig_load_scnptr, orig_data_scnptr):
807 Now off_t, not long, since they are file offsets.
808 (make_hdr): Use _data, not start_of_data ().
809 This is the key part of the fix.
810 (make_hdr, unrelocate_symbols): Use off_t for file offsets.
811 (unrelocate_symbols): Cast pointers to intptr_t, not to ulong.
812
4458c255
PE
813 * pre-crt0.c (data_start): Initialize to 1.
814 This ports to compilers that optimize the external declaration
815 'int x = 0;' as if it were 'int x;' to shrink the executable.
816
227be86d
PE
817 Improve AIX port (Bug#13650).
818 This doesn't fix the bug, but it makes progress: Emacs builds now.
819 * unexaix.c: Include inttypes.h, stdarg.h.
820 (report_error, report_error_1): Mark as _Noreturn.
821 (report_error): Don't report the wrong errno.
822 (report_error_1): Now varargs. All callers changed.
823 (make_hdr): Use uintptr_t, not unsigned, when converting pointers
824 to unsigned. Don't use ADDR_CORRECT, as it no longer exists.
825 (write_ptr): Use %p to print address rather than %lx and a cast
826 to unsigned long. Grow buffer a bit, to be safer.
827
01fcc3a5 8282013-02-13 Eli Zaretskii <eliz@gnu.org>
713bfeaa
EZ
829
830 * bidi.c (bidi_resolve_neutral): After finding the next
831 non-neutral character, accept NEUTRAL_ON type as well, because
832 directional control characters, such as LRE and RLE, have their
833 type converted to that by bidi_resolve_weak. This avoids aborts
834 when LRE/RLE follows a run of neutrals.
835 (bidi_move_to_visually_next): Assert that return value of
836 bidi_peek_at_next_level is non-negative. Negative values will
837 cause an infloop.
838
83be8524
PE
8392013-02-13 Paul Eggert <eggert@cs.ucla.edu>
840
841 Minor getenv-related fixes.
842 * callproc.c (Fcall_process_region) [!DOS_NT]:
843 Avoid unnecessary duplicate call to getenv.
844 * callproc.c (init_callproc):
845 * dispnew.c (init_display):
846 * sysdep.c (sys_subshell):
847 Omit unnecessary cast of getenv or egetenv.
848
45b2b768
JB
8492013-02-13 Juanma Barranquero <lekktu@gmail.com>
850
851 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/sysdep.$(O)):
852 Update dependencies.
853
33b49d71
EZ
8542013-02-12 Eli Zaretskii <eliz@gnu.org>
855
856 * xdisp.c (redisplay_internal): Don't set w->region_showing to the
857 marker's position.
858 (display_line): Set w->region_showing to the value of
859 it->region_beg_charpos, not to -1. This fixes redisplay
860 optimization when cursor is moved up after M->. (Bug#13623)
861 (Bug#13626)
c4131562
EZ
862 (try_scrolling): Scroll text up more if point is too close to ZV
863 and inside the scroll margin. This makes sure point is moved
864 outside the scroll margin in these cases.
33b49d71
EZ
865
866 * window.h (struct window): region_showing can no longer be
867 negative.
868
b09a4810
PE
8692013-02-11 Paul Eggert <eggert@cs.ucla.edu>
870
a84b7c53
PE
871 Tune by using memchr and memrchr.
872 * doc.c (Fsnarf_documentation):
873 * fileio.c (Fsubstitute_in_file_name):
874 * search.c (find_newline, scan_newline):
875 * xdisp.c (pos_visible_p, display_count_lines):
876 Use memchr and memrchr rather than scanning byte-by-byte.
877 * search.c (find_newline): Rename from scan_buffer.
878 Omit first arg TARGET, as it's always '\n'. All callers changed.
879
b09a4810
PE
880 Clean up read_key_sequence a tiny bit more.
881 * keyboard.c (read_char_x_menu_prompt) [HAVE_MENUS]:
882 (read_key_sequence): Remove unused locals.
883
99d0d6dc
SM
8842013-02-11 Stefan Monnier <monnier@iro.umontreal.ca>
885
886 Clean up read_key_sequence a bit; reread active keymaps after first event.
887 * keyboard.c (read_char, read_char_x_menu_prompt)
888 (read_char_minibuf_menu_prompt):
889 Replace nmaps+maps with a single `map' arg.
890 (follow_key): Operate on a single map.
891 (active_maps): New function.
892 (test_undefined): Also return true for nil bindings.
893 (read_key_sequence): Use active_maps to replace the arrays of keymaps with
894 a single (composed) keymap. Remember `first_event' to choose the right
895 set of active keymaps. Recompute the set of keymaps after receiving
896 the first event. Remove GOBBLE_FIRST_EVENT.
897 (syms_of_keyboard): Remove inhibit_local_menu_bar_menus.
898 * keyboard.h (read_char): Update declaration.
899 * lread.c (read_filtered_event): Adjust call to read_char.
900
f5e1b680
EZ
9012013-02-11 Eli Zaretskii <eliz@gnu.org>
902
99d0d6dc
SM
903 * xdisp.c (move_it_vertically_backward, move_it_by_lines):
904 Don't use the limitation on backwards movement when lines are truncated
f5e1b680
EZ
905 in the window. (Bug#13675)
906
f74de345
DA
9072013-02-11 Dmitry Antipov <dmantipov@yandex.ru>
908
909 * marker.c (set_marker_internal): If desired position is passed
910 as a marker, avoid call to buf_charpos_to_bytepos.
911 * window.c (Fset_window_point): Omit redundant type checking.
912 (Fset_window_start): Likewise. Format comment.
913 (window_scroll_pixel_based): Use set_marker_restricted_both
914 with character and byte positions obtained from an iterator.
915 (Fset_window_configuration): Use set_marker_restricted_both.
916 * xdisp.c (message_dolog): Likewise.
917
a4ba3963
EZ
9182013-02-10 Eli Zaretskii <eliz@gnu.org>
919
99d0d6dc
SM
920 * xdisp.c (move_it_vertically_backward, move_it_by_lines):
921 When text lines are longer than window's screen lines, don't move back
a4ba3963
EZ
922 too far. This speeds up some redisplay operations. (Bug#13675)
923
68643cde
DA
9242013-02-10 Dmitry Antipov <dmantipov@yandex.ru>
925
926 * syntax.c (scan_sexps_forward): Fix byte position calculation
927 Bug#13664 (a.k.a Bug#13667) introduced with 2013-02-08 change.
928
7ba11bee
PE
9292013-02-10 Paul Eggert <eggert@cs.ucla.edu>
930
931 * fileio.c (Fexpand_file_name): Omit confusing pointer comparison
932 that was not needed.
933
eff1c190
PE
9342013-02-09 Paul Eggert <eggert@cs.ucla.edu>
935
936 Minor hashing refactoring.
937 * fns.c (SXHASH_REDUCE): Move to lisp.h.
938 (sxhash_float): Return EMACS_UINT, for consistency with the other
939 hash functions.
940 * lisp.h (INTMASK): Now a macro, since SXHASH_REDUCE is now a
941 non-static inline function and therefore can't use static vars.
942 (SXHASH_REDUCE): Move here from fns.c, and make it inline.
943 * profiler.c (hashfn_profiler): Use SXHASH_REDUCE, to be consistent
944 with the other hash functions.
945
6b48c831
EZ
9462013-02-09 Eli Zaretskii <eliz@gnu.org>
947
4dde2087
EZ
948 * callproc.c (Fcall_process_region) [WINDOWSNT]: Make sure the
949 XXXXXX part of the temporary file pattern is not downcased even
950 when w32-downcase-file-names is non-nil. (Bug#13661)
74ba1583 951
8549f9e8
EZ
952 * xdisp.c (decode_mode_spec): Remove handling of %t.
953
6b48c831
EZ
954 * msdos.c (careadlinkatcwd): Remove.
955
75a65c7e
SM
9562013-02-08 Stefan Monnier <monnier@iro.umontreal.ca>
957
958 * lread.c (skip_dyn_bytes): New function (bug#12598).
959 (read1): Use it. Use getc instead of READCHAR to read bytes.
960 (load_each_byte): Remove. Update users.
961
8ca30920
DA
9622013-02-08 Dmitry Antipov <dmantipov@yandex.ru>
963
964 * search.c (scan_buffer): Calculate end byte position just once.
965 (scan_newline): Do not recalculate start_byte.
966 (search_command): Use eassert.
967 * syntax.c (struct lisp_parse_state): New member location_byte.
968 (scan_sexps_forward): Record from_byte and avoid redundant
969 character to byte position calculation ...
970 (Fparse_partial_sexp): ... here. Break too long line.
971
25721f5b
DA
9722013-02-08 Dmitry Antipov <dmantipov@yandex.ru>
973
974 * lisp.h (make_uninit_vector): New function.
975 * alloc.c (Fvector, Fmake_byte_code):
976 * ccl.c (Fregister_ccl_program):
977 * charset.c (Fdefine_charset_internal, define_charset_internal):
978 * coding.c (make_subsidiaries, Fdefine_coding_system_internal):
979 * composite.c (syms_of_composite):
980 * font.c (Fquery_font, Ffont_info, syms_of_font):
981 * fontset.c (FONT_DEF_NEW, Fset_fontset_font):
982 * ftfont.c (ftfont_shape_by_flt):
983 * indent.c (recompute_width_table):
984 * nsselect.m (clean_local_selection_data):
985 * syntax.c (init_syntax_once):
986 * w32unsubscribe.c (uniscribe_shape):
987 * window.c (Fcurrent_window_configuration):
988 * xfaces.c (Fx_family_fonts):
989 * xselect.c (selection_data_to_lisp_data): Use it.
990
9a9d91d9
DA
9912013-02-07 Dmitry Antipov <dmantipov@yandex.ru>
992
993 * coding.c (Fdefine_coding_system_internal): Use AREF where
994 argument is known to be a vector.
995 * fns.c (Flocale_info): Likewise for ASET.
996 * xselect.c (selection_data_to_lisp_data): Likewise for ASET.
997 * w32fns.c (w32_parse_hot_key): Likewise for ASIZE and AREF.
998
6871e574
JD
9992013-02-05 Jan Djärv <jan.h.d@swipnet.se>
1000
1001 * nsmenu.m (update_frame_tool_bar): Check for negative tool bar
1002 height.
1003
1004 * nsterm.h (HAVE_NATIVE_FS): Define if OSX => 10.7.
1005 (EmacsView): Add fs_is_native, fsIsNative, isFullscreen and
1006 updateCollectionBehaviour.
1007
1008 * nsterm.m (NEW_STYLE_FS): Remove.
1009 (ns_last_use_native_fullscreen): New variable.
1010 (x_make_frame_visible): Replace NEW_STYLE_FS with isFullscreen.
1011 (x_set_window_size): Do not take title bar and tool bar into account
1012 if isFullscreen returns YES.
1013 (ns_fullscreen_hook): Replace NEW_STYLE_FS with isFullscreen.
1014 (check_native_fs): New function.
1015 (ns_select, ns_read_socket): Call check_native_fs if HAVE_NATIVE_FS.
1016 (ns_term_init): Remove NEW_STYLE_FS.
1017 (updateFrameSize:, windowWillResize:toSize:): Only adjust for title bar
1018 and tool bar if isFullscreen returns NO.
1019 (windowDidResize:): Replace NEW_STYLE_FS with fsIsNative.
1020 (initFrameFromEmacs:): Initialize fs_is_native. Replace NEW_STYLE_FS
1021 with HAVE_NATIVE_FS.
1022 (window:willUseFullScreenPresentationOptions:): New method.
1023 (windowDidEnterFullScreen:): Replace NEW_STYLE_FS with fsIsNative.
1024 Hide toolbar if not enabled (Bug#13444).
1025 (windowDidExitFullScreen:): Call updateCollectionBehaviour.
1026 Restore tool bar if enabled, hide it otherwise (Bug#13444).
1027 (fsIsNative, isFullscreen, updateCollectionBehaviour): New methods.
1028 (toggleFullScreen:): If fs_is_native, call toggleFullScreen on
1029 window. Do no set FRAME_EXTERNAL_TOOL_BAR (f) to 0.
1030 Check FRAME_EXTERNAL_TOOL_BAR (f) before restoring
1031 FRAME_TOOLBAR_HEIGHT (f). Call updateFrameSize when going non-fs.
1032 (syms_of_nsterm): Add ns-use-native-fullscreen.
1033
3f011c7f
PE
10342013-02-04 Paul Eggert <eggert@cs.ucla.edu>
1035
1036 * fileio.c (Qchoose_write_coding_system): Now static.
1037
86f7c0fe
EZ
10382013-02-04 Eli Zaretskii <eliz@gnu.org>
1039
1040 * xdisp.c (window_buffer_changed): region_showing can be negative,
1041 which still means region is being displayed.
1042 (redisplay_internal): Resurrect code that forced redisplay of the
99d0d6dc
SM
1043 whole window when showing region and the mark has changed.
1044 Record the new mark position to allow redisplay optimizations.
86f7c0fe
EZ
1045 (display_line): If it->region_beg_charpos is non-zero, set the
1046 window's region_showing member to -1. (Bug#13623) (Bug#13626)
1047
1048 * window.h (struct window) <region_showing>: Declare ptrdiff_t,
1049 not bitfield of 1 bit.
1050
5257b701
DC
10512013-02-03 Daniel Colascione <dancol@dancol.org>
1052
1053 * emacs.c: Use execvp, not execv, when DAEMON_MUST_EXEC, so that
1054 daemon mode works on cygw32 when Emacs is installed and not just
1055 during development.
1056
8ea41ea9
PE
10572013-02-02 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 Avoid file time stamp bug on MS-Windows (Bug#13149).
1060 * fileio.c (Fwrite_region): Don't use the heuristic on empty files,
1061 as FAT32 doesn't update time stamps when truncating them.
1062 Also, check that a file time stamp is not a multiple of 100 ns;
1063 this should catch all instances of the problem on MS-Windows,
1064 as its native file system resolution is 100 ns or worse, and
1065 checking for a non-multiple of 100 ns should impose only a small
1066 overhead on systems with ns resolution.
1067
94fbc901 10682013-02-02 Eli Zaretskii <eliz@gnu.org>
18a80473 1069
e7ac588e
EZ
1070 Avoid encoding file names on MS-Windows when they need to be run
1071 through dostounix_filename.
1072 * w32.c (normalize_filename): Accept an additional argument
1073 MULTIBYTE; if non-zero, traverse the file name by bytes and don't
1074 downcase it even if w32-downcase-file-names is non-nil.
1075 (dostounix_filename): Accept an additional argument MULTIBYTE and
1076 pass it to normalize_filename.
1077 (emacs_root_dir): Adjust.
1078
1079 * msdos.h (dostounix_filename): Adjust prototype.
1080
1081 * w32.h (dostounix_filename): Adjust prototype.
1082
1083 * msdos.c (dostounix_filename): Accept an additional argument and
1084 ignore it.
1085 (init_environment): Adjust callers of dostounix_filename.
1086
1087 * fileio.c (Ffile_name_directory, file_name_as_directory)
1088 (directory_file_name, Fexpand_file_name)
1089 (Fsubstitute_in_file_name): [DOS_NT] Adjust call to
1090 dostounix_filename.
1091 [WINDOWSNT]: Downcase file names if w32-downcase-file-names is
1092 non-nil.
1093 (Fsubstitute_in_file_name): [DOS_NT] Don't downcase environment
1094 variables, as egetenv is case-insensitive for DOS_NT.
1095
1096 * dired.c (file_name_completion): Don't call Fdirectory_file_name
1097 with an encoded file name.
1098
99d0d6dc
SM
1099 * w32proc.c (Fw32_short_file_name, Fw32_long_file_name):
1100 Adjust calls to dostounix_filename.
e7ac588e
EZ
1101
1102 * w32fns.c (Fx_file_dialog): Adjust call to dostounix_filename.
1103
1104 * unexw32.c (unexec): Adjust call to dostounix_filename.
1105
1106 * termcap.c (tgetent) [MSDOS]: Adjust call to dostounix_filename.
1107
1108 * emacs.c (decode_env_path) [DOS_NT]: Adjust call to
1109 dostounix_filename.
1110
1111 * callproc.c (Fcall_process) [MSDOS]: Adjust call to
1112 dostounix_filename.
1113
e7c3fb06
EZ
1114 * callproc.c (Fcall_process): Make sure program name in PATH and
1115 new_argv[0] is encoded, if needed. Otherwise, un-encoded string
1116 is passed to exec/spawnve, which fails unless the file-name
1117 encoding is UTF-8.
1118
18a80473
EZ
1119 * w32proc.c (sys_spawnve): Make sure escape_char is initialized,
1120 even if w32-quote-process-args is nil.
1121
35e85499
PE
11222013-02-01 Paul Eggert <eggert@cs.ucla.edu>
1123
1124 Fix timestamp bug when write-region appends nothing (Bug#13149).
1125 * fileio.c (Fwrite_region): When neither O_EXCL nor O_TRUNC is used,
1126 the file's time stamp doesn't change if Emacs happens to write nothing
1127 to the file, and on a buggy file system this could cause Emacs to
1128 incorrectly infer that the file system doesn't have the bug.
1129 Avoid this problem by inhibiting the inference in this case.
1130
422ff52b
DA
11312013-02-01 Dmitry Antipov <dmantipov@yandex.ru>
1132
1133 * window.h (struct window): Convert base_line_number, base_line_pos
1134 and column_number_displayed members from Lisp_Object to ptrdiff_t.
1135 Convert region_showing member from Lisp_Object to bitfield.
1136 Remove sequence_number member. Adjust comments.
1137 * window.c (sequence_number): Remove.
1138 (make_window): Initialize column_number_displayed.
1139 * print.c (print_object): Follow the printed representation of
1140 frames and print window pointer to distinguish between windows.
1141 (adjust_window_count): Invalidate base_line_pos. Adjust comment.
1142 * xdisp.c (wset_base_line_number, wset_base_line_pos)
1143 (wset_column_number_displayed, wset_region_showing): Remove.
1144 (window_buffer_changed, mode_line_update_needed, redisplay_internal)
1145 (try_scrolling, try_cursor_movement, redisplay_window)
1146 (try_window_reusing_current_matrix, try_window_id, display_line)
1147 (display_mode_lines, decode_mode_spec): Adjust users.
1148 * .gdbinit (pwinx): Do not print sequence_number.
1149
8654f9d7
PE
11502013-02-01 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 Use fdopendir, fstatat and readlinkat, for efficiency (Bug#13539).
1153 * conf_post.h (GNULIB_SUPPORT_ONLY_AT_FDCWD): Remove.
1154 * dired.c: Include <fcntl.h>.
1155 (open_directory): New function, which uses open and fdopendir
1156 rather than opendir. DOS_NT platforms still use opendir, though.
1157 (directory_files_internal, file_name_completion): Use it.
1158 (file_attributes): New function, with most of the old Ffile_attributes.
1159 (directory_files_internal, Ffile_attributes): Use it.
1160 (file_attributes, file_name_completion_stat): First arg is now fd,
1161 not dir name. All uses changed. Use fstatat rather than lstat +
1162 stat.
1163 (file_attributes): Use emacs_readlinkat rather than Ffile_symlink_p.
1164 * fileio.c: Include <allocator.h>, <careadlinkat.h>.
1165 (emacs_readlinkat): New function, with much of the old
1166 Ffile_symlink_p, but with an fd argument for speed.
1167 It uses readlinkat rather than careadlinkatcwd, so that it
1168 need not assume the working directory.
1169 (Ffile_symlink_p): Use it.
1170 * filelock.c (current_lock_owner): Use emacs_readlinkat
1171 rather than emacs_readlink.
1172 * lisp.h (emacs_readlinkat): New decl.
1173 (READLINK_BUFSIZE, emacs_readlink): Remove.
1174 * sysdep.c: Do not include <allocator.h>, <careadlinkat.h>.
1175 (emacs_norealloc_allocator, emacs_readlink): Remove.
1176 This stuff is moved to fileio.c.
1177 * w32.c (fstatat, readlinkat): New functions.
1178 (careadlinkat): Don't check that fd == AT_FDCWD.
1179 (careadlinkatcwd): Remove; no longer needed.
1180
9dbda100
GM
11812013-01-31 Glenn Morris <rgm@gnu.org>
1182
1183 * fileio.c (choose_write_coding_system): Make it callable from Lisp.
20a8c477
GM
1184 (Fwrite_region): Update for new choose_write_coding_system args.
1185 Move the last piece of choose_write_coding_system here. (Bug#13522)
9dbda100
GM
1186 (syms_of_fileio): Add choose-write-coding-system.
1187
3f82a88a 11882013-01-30 Eli Zaretskii <eliz@gnu.org>
224f4ec1
EZ
1189
1190 * w32.c (sys_open): Zero out the flags for the new file descriptor.
1191 (sys_close): Zero out the flags for the file descriptor before
1192 closing it. (Bug#13546)
1193
806fed21 1194 * w32.c (parse_root, get_volume_info, readdir, read_unc_volume)
99d0d6dc
SM
1195 (logon_network_drive, stat_worker, symlink, chase_symlinks):
1196 Use CharNextExA and CharPrevExA to iterate over file names encoded in
806fed21
EZ
1197 DBCS. (Bug#13553)
1198
6ee4509a
EZ
1199 * w32.c (w32_get_long_filename, init_environment, readlink):
1200 Support file names encoded in DBCS codepages.
26854e9c
EZ
1201 (readlink): Use the current file-name-coding-system, not the ANSI
1202 codepage, to decode and handle targets of symlinks.
6ee4509a 1203
cf01a359
EZ
12042013-01-28 Eli Zaretskii <eliz@gnu.org>
1205
1206 * w32.c (opendir): Now accepts a 'const char *'.
1207
6fd326b7
DA
12082013-01-28 Dmitry Antipov <dmantipov@yandex.ru>
1209
1210 Remove obsolete redisplay code. See the discussion at
1211 http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00576.html.
1212 * dispnew.c (preemption_period, preemption_next_check): Remove.
1213 (Vredisplay_preemption_period): Likewise.
1214 (update_frame, update_single_window, update_window, update_frame_1):
1215 Adjust users. Always assume that PERIODIC_PREEMPTION_CHECKING is not
1216 used, following the 2012-06-22 change.
1217
d8cd7742
EZ
12182013-01-25 Eli Zaretskii <eliz@gnu.org>
1219
1220 * w32notify.c (Fw32notify_add_watch): Doc fix. (Bug#13540)
1221
266fee4f
DA
12222013-01-25 Dmitry Antipov <dmantipov@yandex.ru>
1223
1224 * font.c (num_fonts): Remove the leftover from old
1225 debugging code. Adjust comment style here and there.
59e624b3
DA
1226 * insdel.c (insert_1): Remove.
1227 * lisp.h (insert_1): Remove prototype.
1228 * xdisp.c (message_dolog): Adjust users to call insert_1_both.
266fee4f 1229
830e46e6 12302013-01-25 Eli Zaretskii <eliz@gnu.org>
6d2851de
EZ
1231
1232 * w32.c (max_filename_mbslen): New function.
1233 (normalize_filename, readdir): Use it to detect locales where ANSI
1234 encoding of file names uses a double-byte character set (DBCS).
1235 If a DBCS encoding is used, advance by characters using
99d0d6dc
SM
1236 CharNextExA, instead of incrementing a 'char *' pointer.
1237 Use _mbslwr instead of _strlwr. (Bug#13515)
6d2851de 1238
81abbb95
EZ
1239 * w32heap.c (allocate_heap) [!_WIN64]: Decrease the initial
1240 request of memory reservation to 1.7GB. (Bug#13065)
1241
830e46e6 12422013-01-25 Andreas Schwab <schwab@linux-m68k.org>
ba14c607
AS
1243
1244 * coding.c (detect_coding_iso_2022): Move back mis-reordered code
1245 at check_extra_latin label. (Bug#13505)
1246
fd3ceb09
DA
12472013-01-24 Dmitry Antipov <dmantipov@yandex.ru>
1248
1249 * nsfont.m (ns_escape_name, ns_unescape_name, ns_registry_to_script):
1250 Avoid redundant calls to strlen.
1251
edfa7fa0
DA
12522013-01-24 Dmitry Antipov <dmantipov@yandex.ru>
1253
1254 Drop async_visible and async_iconified fields of struct frame.
1255 This is possible because async input is gone; for details, see
1256 http://lists.gnu.org/archive/html/emacs-devel/2012-12/msg00734.html.
1257 * frame.h (struct frame): Remove async_visible and async_iconified
1258 members, convert garbaged to unsigned bitfield. Adjust comments.
1259 (FRAME_SAMPLE_VISIBILITY): Remove. Adjust all users.
1260 (SET_FRAME_VISIBLE, SET_FRAME_ICONIFIED): New macros.
1261 * frame.c, gtkutil.c, term.c, w32fns.c, window.c, xdisp.c:
1262 Consistently use SET_FRAME_VISIBLE, SET_FRAME_ICONIFIED,
1263 FRAME_VISIBLE_P and FRAME_ICONIFIED_P macros where appropriate.
1264 * w32term.c: Ditto.
1265 (w32_read_socket): Save iconified state to generate DEICONIFY_EVENT
1266 properly. Likewise for obscured.
1267 * xterm.c: Ditto.
266fee4f 1268 (handle_one_xevent): Save visible state to generate ICONIFY_EVENT
edfa7fa0
DA
1269 properly.
1270 * nsterm.m: Ditto.
1271 (windowDidDeminiaturize): Generate DEICONIFY_EVENT.
1272
5ad86e34
DA
12732013-01-24 Dmitry Antipov <dmantipov@yandex.ru>
1274
1275 * insdel.c (prepare_to_modify_buffer): Revert last change as suggested
1276 in http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00555.html.
1277
b09cca6a
SM
12782013-01-23 Stefan Monnier <monnier@iro.umontreal.ca>
1279
1280 * xdisp.c (message2, message2_nolog): Remove functions.
1281 (message3, message3_nolog): Extract nbytes and multibyteness directly
1282 from the string. Change all callers.
1283 (message3_nolog): Don't set message_enable_multibyte since set_message
1284 will reset it anyway.
1285 (message1, message1_nolog): Use message3.
1286 (vmessage): Use a stack allocated buffer rather than f->message_buf.
1287 (with_echo_area_buffer): Remove last two arguments. Update all callers.
1288 (set_message): Drop all but the second arg, which has to be a string.
1289 (set_message_1): Simplify now that we know that a1 is NULL and the
1290 second arg is a string.
1291 * frame.h (struct frame): Remove `message_buf' field.
1292 Use glyphs_initialized_p instead.
1293 (FRAME_MESSAGE_BUF): Remove macro.
1294 * w16select.c (Fw16_set_clipboard_data): Prefer message3 to message2.
1295 * lisp.h (message2, message2_nolog): Remove declarations.
1296 (message3, message3_nolog): Update declarations.
1297 * keyboard.c (read_char_minibuf_menu_text)
1298 (read_char_minibuf_menu_width): Remove vars.
1299 (read_char_minibuf_menu_prompt): Rewrite the menu's construction so as
1300 to correctly handle multibyte strings.
1301 * frame.c (delete_frame): Don't free message_buf any more.
1302 * editfns.c (message_text, message_length): Remove vars.
1303 (Fmessage_box): Don't copy the Lisp string's bytes any longer.
1304 * fileio.c (auto_save_error): Use message3 instead of message2.
1305 * dispnew.c (adjust_frame_message_buffer): Remove function.
1306
54ab1c5a
EZ
13072013-01-23 Eli Zaretskii <eliz@gnu.org>
1308
1309 * w32term.c (w32fullscreen_hook): Account correctly for the screen
1310 real estate used for the tool bar and the menu bar.
1311
6c27465b
DA
13122013-01-23 Dmitry Antipov <dmantipov@yandex.ru>
1313
1314 * insdel.c (prepare_to_modify_buffer): Force redisplay if
1315 hidden buffer is prepared to modification (Bug#13164).
1316
9d93ce29
DA
13172013-01-22 Dmitry Antipov <dmantipov@yandex.ru>
1318
1319 * window.h (struct window): Change window_end_valid member from
1320 Lisp_Object to a bitfield. Adjust comments.
1321 (wset_window_end_valid): Remove.
1322 * window.c (adjust_window_count): Clear window_end_valid.
1323 (Fwindow_end): Adjust user. Remove ancient #if 0 code.
1324 (Fwindow_line_height, set_window_buffer, Frecenter)
1325 (Fsplit_window_internal, Fdelete_other_windows_internal)
1326 (Fset_window_fringes, Fset_window_scroll_bars): Adjust users.
1327 * dispnew.c (adjust_glyph_matrix, clear_window_matrices): Likewise.
1328 * xdisp.c (check_window_end, reconsider_clip_changes)
1329 (redisplay_internal, mark_window_display_accurate_1, redisplay_window)
1330 (try_window, try_window_reusing_current_matrix, note_mouse_highlight)
1331 (find_first_unchanged_at_end_row, try_window_id): Likewise.
1332
1dcb8ea2
DA
13332013-01-22 Dmitry Antipov <dmantipov@yandex.ru>
1334
1335 * xdisp.c (mark_window_display_accurate): Simplify the loop
1336 assuming that the only one of vchild, hchild or buffer window
1337 slots is non-nil. Call mark_window_display_accurate_1 for
1338 the leaf windows only.
1339 (mark_window_display_accurate_1): Always assume leaf window.
1340 Adjust comment.
1341
b41b8a7e
PE
13422013-01-22 Paul Eggert <eggert@cs.ucla.edu>
1343
593a5f2e
PE
1344 * emacs.c (Qkill_emacs_hook): Now static.
1345
b41b8a7e
PE
1346 * fileio.c (Finsert_file_contents): Simplify.
1347 Remove unnecessary assignments and tests.
1348
84e5ed96
EZ
13492013-01-21 Eli Zaretskii <eliz@gnu.org>
1350
1351 * w32.c (acl_set_file): Don't test for errors unless
1352 set_file_security returns FALSE. Avoids spurious errors when
1353 saving files.
1354
2ef88fd4
DA
13552013-01-21 Dmitry Antipov <dmantipov@yandex.ru>
1356
1357 * fileio.c (Finsert_file_contents): Revert code introduced at
1358 2013-01-18 in favor of the simpler and generally better fix.
1359 Save stack space by removing 'buffer' and reusing 'read_buf'
1360 where appropriate.
1361
d7a0a7c9
PE
13622013-01-19 Paul Eggert <eggert@cs.ucla.edu>
1363
1364 * lisp.h (eabs): Define unconditionally (Bug#13419).
1365 The old "#if !defined (eabs)" was an unnecessary revenant of back
1366 when this macro was called "abs". Document 'eabs' better.
1367
795e7a5b 13682013-01-19 Glenn Morris <rgm@gnu.org>
085d34c4
GM
1369
1370 * fns.c (Frandom): Doc fix.
1371
59ac2d13
EZ
13722013-01-19 Eli Zaretskii <eliz@gnu.org>
1373
1374 * editfns.c (get_pos_property): Use SAFE_ALLOCA_LISP, to avoid
1375 segfault when there are lots of overlays.
1376
1377 * buffer.c (sort_overlays): Use SAFE_NALLOCA, to avoid segfault
99d0d6dc
SM
1378 when there are lots of overlays.
1379 See http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00421.html
59ac2d13
EZ
1380 for the details and a way to reproduce.
1381
b3fbb395
PE
13822013-01-19 Paul Eggert <eggert@cs.ucla.edu>
1383
3a955a1f
PE
1384 * fileio.c: Use O_APPEND to append.
1385 This corresponds better to the natural interpretation of "append",
1386 and avoids the need to open the output file twice, or to invoke
1387 lseek when APPEND is neither nil nor a number.
1388 This relies on POSIX 1003.1-1988 or later, which is OK nowadays.
1389 (Fwrite_region): Simplify. Use O_APPEND instead of opening the
1390 file possibly twice, and lseeking to its end; this avoids the
1391 need to lseek on non-regular files. Do not use O_EXCL and O_TRUNC
1392 at the same time: the combination is never needed and apparently
1393 it doesn't work with DOS_NT.
1394
21cd50b8
PE
1395 Fix size bug on DOS_NT introduced by CIFS workaround (Bug#13149).
1396 * fileio.c (Fwrite_region): Use O_BINARY in checking code, too.
1397
b3fbb395
PE
1398 Allow floating-point file offsets.
1399 Problem reported by Vitalie Spinu in
1400 <http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00411.html>.
1401 * fileio.c (emacs_lseek): Remove.
1402 (file_offset): New function.
1403 (Finsert_file_contents, Fwrite_region): Use it.
1404
73c14218
CY
14052013-01-19 Chong Yidong <cyd@gnu.org>
1406
1407 * emacs.c (Fkill_emacs): Set waiting_for_input to 0 to avoid
1408 aborting on Fsignal (Bug#13289).
1409
6a9465f3
EZ
14102013-01-19 Eli Zaretskii <eliz@gnu.org>
1411
1412 * w32.c (acl_set_file): Treat ERROR_ACCESS_DENIED from
1413 set_file_security as failure due to insufficient privileges.
1414 Reported by Fabrice Popineau <fabrice.popineau@supelec.fr>.
76e9f7b9 1415 (fstat): Return owner and group like 'stat' and 'lstat' do.
6a9465f3 1416
fa705c99
PE
14172013-01-19 Paul Eggert <eggert@cs.ucla.edu>
1418
9fe43ff6
PE
1419 Work around bug in CIFS and vboxsf file systems (Bug#13149).
1420 The bug was observed on Ubuntu operating inside a virtual machine,
1421 editing files mounted via CIFS or vboxsf from the MS Windows 7 host.
1422 The workaround introduces a race condition on non-buggy hosts,
1423 but it's an unlikely race and anyway there's a nearly identical
1424 nearby race that can't be fixed.
1425 * fileio.c (valid_timestamp_file_system, timestamp_file_system):
1426 New static vars.
1427 (Fwrite_region): Test for file system time stamp bug.
1428 (init_fileio): New function.
1429 * lisp.h (init_fileio): Declare it.
1430 * emacs.c (main): Call it.
1431
fa705c99
PE
1432 * fileio.c (Finsert_file_contents): Simplify new diagnostic
1433 and make it more consistent with other stat-failure diagnostics.
1434
e07469fa
DA
14352013-01-18 Dmitry Antipov <dmantipov@yandex.ru>
1436
99d0d6dc
SM
1437 Fix crash when inserting data from non-regular files.
1438 See http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00406.html
e07469fa
DA
1439 for the error description produced by valgrind.
1440 * fileio.c (read_non_regular): Rename to read_contents.
1441 Free Lisp_Save_Value object used to pass parameters.
1442 (read_non_regular_quit): Rename to read_contents_quit.
1443 (Finsert_file_contents): Redesign internal file reading loop to adjust
1444 gap and end positions after each read and so help make_gap to work
1445 properly. Do not signal an I/O error too early and so do not leave
1446 not yet decoded characters in a buffer, which was the reason of
1447 redisplay crash. Use list2 to build return value. Adjust comments.
1448
67722112
PE
14492013-01-17 Paul Eggert <eggert@cs.ucla.edu>
1450
1451 Close a race when statting and reading files (Bug#13149).
1452 * fileio.c (Finsert_file_contents): Use open+fstat, not stat+open.
1453 This avoids a race if the file is renamed between stat and open.
1454 This race is not the problem originally noted in Bug#13149;
1455 see <http://bugs.gnu.org/13149#73> and later messages in the thread.
1456
468afbac
DA
14572013-01-17 Dmitry Antipov <dmantipov@yandex.ru>
1458
1459 * lisp.h (toplevel): Add comment about using Lisp_Save_Value
1460 objects, related functions and macros.
1461 (make_save_value): Adjust prototype.
1462 (make_save_pointer): New prototype.
1463 (SAFE_NALLOCA): Fix indentation. Use make_save_pointer.
1464 (SAFE_ALLOCA_LISP): Adjust make_save_value usage.
1465 * alloc.c (format_save_value): Rename to make_save_value.
1466 (make_save_pointer): New function.
1467 (record_xmalloc): Use make_save_pointer.
1468 * dired.c, editfns.c, fileio.c, font.c, gtkutil.c, lread.c:
1469 * nsmenu.m, nsterm.m, xfns.c, xmenu.c, xselect.c, keymap.c:
1470 Change users of make_save_value to make_save_pointer.
1471 Likewise for format_save_value and make_save_value.
1472
0e70695a
DA
14732013-01-17 Dmitry Antipov <dmantipov@yandex.ru>
1474
1475 * buffer.h (NARROWED, BUF_NARROWED): Drop unused macros.
1476 (DECODE_POSITION, BUFFER_CHECK_INDIRECTION): Fix indentation.
1477 * buffer.c (toplevel, syms_of_buffer): Drop old commented-out
1478 debugging stubs.
1479
963ea40f
PE
14802013-01-15 Paul Eggert <eggert@cs.ucla.edu>
1481
1482 * alloc.c (free_save_value): Now static.
1483
3346c1d0
DA
14842013-01-15 Dmitry Antipov <dmantipov@yandex.ru>
1485
1486 * keymap.c (map_keymap_internal): Use format_save_value.
1487 (map_keymap_char_table_item): Adjust accordingly.
1488 * fileio.c (non_regular_fd, non_regular_inserted)
1489 (non_regular_nbytes): Remove.
99d0d6dc
SM
1490 (Finsert_file_contents): Convert trytry to ptrdiff_t.
1491 Use format_save_value to pass parameters to read_non_regular.
3346c1d0
DA
1492 (read_non_regular): Use XSAVE_ macros to extract parameters.
1493 Adjust comment.
1494 * xmenu.c (xmenu_show) [!USE_X_TOOLKIT && !USE_GTK]: Use
1495 format_save_value.
1496 (pop_down_menu) [!USE_X_TOOLKIT && !USE_GTK]: Adjust user.
1497
2b30549c
DA
14982013-01-15 Dmitry Antipov <dmantipov@yandex.ru>
1499
1500 * lisp.h (XSAVE_POINTER, XSAVE_INTEGER): Change to allow
1501 extraction from any Lisp_Save_Value slot. Add type checking.
1502 * alloc.c, dired.c, editfns.c, fileio.c, ftfont.c, gtkutil.c:
1503 * keymap.c, lread.c, nsterm.h, nsmenu.c, xfns.c, xmenu.c:
1504 * xselect.c: All users changed.
1505
1b971ac1
DA
15062013-01-15 Dmitry Antipov <dmantipov@yandex.ru>
1507
1508 Some convenient bits to deal with Lisp_Save_Values.
1509 * lisp.h (XSAVE_OBJECT): New macro to extract saved objects.
1510 (allocate_misc): Remove prototype.
1511 (format_save_value): New prototype.
1512 * alloc.c (allocate_misc): Revert back to static.
1513 (format_save_value): New function to build Lisp_Save_Value
1514 object with the specified internal structure.
1515 (make_save_value): Reimplement using format_save_value.
1516 * editfns.c (save_excursion_save): Use format_save_value.
1517 (save_excursion_restore): Use XSAVE_OBJECT.
1518
c50cf2ea
PE
15192013-01-14 Paul Eggert <eggert@cs.ucla.edu>
1520
1521 Avoid needless casts with XSAVE_POINTER.
1522 * alloc.c (mark_object) [GC_MARK_STACK]:
1523 * dired.c (directory_files_internal_unwind):
1524 * fileio.c (do_auto_save_unwind):
1525 * gtkutil.c (pop_down_dialog):
1526 * keymap.c (map_keymap_char_table_item):
1527 * lread.c (load_unwind):
1528 * nsmenu.m (pop_down_menu):
1529 * print.c (print_object) [GC_MARK_STACK]:
1530 * xfns.c (clean_up_file_dialog):
1531 * xmenu.c (cleanup_widget_value_tree):
1532 Omit casts between XSAVE_POINTER and a pointer type.
1533
9d5a1260
DA
15342013-01-14 Dmitry Antipov <dmantipov@yandex.ru>
1535
1536 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE.
1537 * eval.c (eval_sub): Protect `form' from being GCed before its
1538 car and cdr becomes protected with the backtrace entry.
1539
73ebd38f
DA
15402013-01-14 Dmitry Antipov <dmantipov@yandex.ru>
1541
1542 Make Lisp_Save_Value more versatile storage for up to four objects.
1543 * lisp.h (toplevel): Enumeration to describe types of saved objects.
1544 (struct Lisp_Save_Value): New layout. Adjust comments.
1545 (XSAVE_POINTER): New macro.
1546 (XSAVE_INTEGER): Likewise.
1547 (allocate_misc): Add prototype.
1548 (free_misc): Likewise.
1549 * alloc.c (allocate_misc): Now global.
1550 (free_misc): Likewise. Adjust comment.
1551 (make_save_value): Use new Lisp_Save_Value layout. Adjust comment.
1552 (free_save_value): Likewise.
1553 (mark_object): Likewise.
1554 * editfns.c (save_excursion_save): Pack everything within
1555 Lisp_Save_Value and so avoid xmalloc.
1556 (save_excursion_restore): Adjust to match new layout. Use free_misc
1557 because we do not allocate extra memory any more. Add eassert.
1558 * print.c (print_object): New code to print Lisp_Save_Value. Do not
1559 rely on valid_lisp_object_p if !GC_MARK_STACK. Adjust comments.
1560 * dired.c, fileio.c, font.c, ftfont.c, gtkutil.c, keymap.c,
1561 * lread.c, nsmenu.m, nsterm.h, xfns.c, xmenu.c, xselect.c:
1562 Use XSAVE_POINTER and XSAVE_INTEGER where appropriate.
1563
b826986f
JD
15642013-01-13 Jan Djärv <jan.h.d@swipnet.se>
1565
1566 * nsfont.m (LCD_SMOOTHING_MARGIN): New define.
1567 (nsfont_draw): Remove disabling of LCD smoothing.
1568 (ns_glyph_metrics): Add LCD_SMOOTHING_MARGIN to bearings to fix
2e7a1892 1569 Bug#11484 with LCD smoothing on.
b826986f 1570
c0511b57 15712013-01-13 Paul Eggert <eggert@cs.ucla.edu>
45b7bfdd 1572
b6f960a0
PE
1573 Fix SIGDANGER handlers, for AIX (Bug#13408).
1574 * sysdep.c.c (handle_danger_signal, deliver_danger_signal) [SIGDANGER]:
1575 Move handlers here from emacs.c; they were out of place.
1576
616763d5
JD
15772013-01-11 Jan Djärv <jan.h.d@swipnet.se>
1578
1579 * xterm.c (syms_of_xterm): Adjust documentation for
1580 scroll-bar-adjust-thumb-portion.
1581
0b59090b 15822012-12-31 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
ec782c5f
JD
1583
1584 * xterm.c (scroll-bar-adjust-thumb-portion): New variable to
1585 determine whether scroll bar thumb size should be adjusted or
1586 not. Use variable for MOTIF.
1587
1588 * gtkutil.c (scroll-bar-adjust-thumb-portion): Use variable for
1589 GTK.
1590
7bc916b4
JD
15912013-01-13 Jan Djärv <jan.h.d@swipnet.se>
1592
eac4d08f
JD
1593 * nsterm.m (keyDown:): Set processingCompose to NO if an emacs key
1594 event is generated.
1595 (doCommandBySelector:): Set processingCompose to NO.
1596
7bc916b4
JD
1597 * nsfont.m (ns_findfonts): Add block/unblock_input calls.
1598 Remove check for fkeys count > zero, block/unblock fixes the real bug.
1599 (nsfont_list_family): Add block/unblock_input calls.
1600 (nsfont_open): Move block_input earlier. Add unblock_input before early
1601 return.
1602 (nsfont_draw): Add block/unblock_input calls.
1603
bdc9b756
PE
16042013-01-12 Dmitry Antipov <dmantipov@yandex.ru>
1605
1606 * indent.c (Fvertical_motion): Remove now-incorrect GCPROs
1607 for old_charpos and old_bytepos.
1608
ee56a6dc
PE
16092013-01-12 Paul Eggert <eggert@cs.ucla.edu>
1610
1611 Fix bug with set-time-zone-rule and LOCALTIME_CACHE (Bug#13415).
1612 * editfns.c (set_time_zone_rule) [LOCALTIME_CACHE]:
1613 Clear tzvalbuf_in_environ if this workaround is in effect.
1614 Problem and fix reported by Kazuhiro Ito.
1615
9fc9a531
AH
16162013-01-11 Aaron S. Hawley <Aaron.Hawley@vtinfo.com>
1617
99d0d6dc
SM
1618 * insdel.c (Fcombine_after_change_execute, syms_of_insdel):
1619 Fix ambiguous doc string cross-reference(s).
9fc9a531
AH
1620
1621 * keyboard.c (Fcommand_execute, syms_of_keyboard): Fix ambiguous
1622 doc string cross-reference(s).
1623
1624 * window.c (Fwindow_point, syms_of_window): Fix ambiguous doc
1625 string cross-reference(s).
1626
6020559a
DA
16272013-01-11 Dmitry Antipov <dmantipov@yandex.ru>
1628
1629 Avoid unnecessary byte position calculation for the gap movement.
1630 Since all users of move_gap do CHAR_TO_BYTE for other purposes
1631 anyway, all of them should use move_gap_both instead.
1632 * lisp.h (move_gap): Remove prototype.
1633 * insdel.c (move_gap): Remove.
1634 (move_gap_both): Add eassert.
1635 * editfns.c (Ftranspose_regions): Tweak to use move_gap_both.
1636 * xml.c (parse_region): Likewise.
1637
b8956427
PE
16382013-01-11 Paul Eggert <eggert@cs.ucla.edu>
1639
1640 emacsclient -t should not suspend Emacs server (Bug#13387)
1641 * lisp.h, sysdep.c (block_tty_out_signal, unblock_tty_out_signal):
1642 New functions.
1643 * term.c (init_tty): Use them instead of rolling our own code.
1644 * sysdep.c (tcsetpgrp_without_stopping): Likewise. Here, this
1645 switches from 'signal' to 'pthread_sigmask', which is safer in
1646 multithreaded applications.
1647 * term.c (Fresume_tty): Don't bother dissociating if O_IGNORE_CTTY,
1648 which has already arranged for that.
1649 (dissociate_if_controlling_tty): If setsid fails, fall back on TIOCNOTTY.
1650 This is the main part of the bug fix.
1651
0b59090b 16522013-01-10 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> (tiny change)
48660ca5
JD
1653
1654 * gtkutil.c (xg_initialize): Add ifdef HAVE_FREETYPE around
1655 x_last_font_name (Bug#13403).
1656
58cc0a01
DA
16572013-01-10 Dmitry Antipov <dmantipov@yandex.ru>
1658
1659 Omit buffer_slot_type_mismatch and use generic predicates to enforce
1660 the type of per-buffer values where appropriate.
1661 * lisp.h (struct Lisp_Buffer_Objfwd): Rename slottype member to
1662 predicate, which is how it's really used now. Adjust comment.
1663 * buffer.h (buffer_slot_type_mismatch): Remove prototype.
1664 * buffer.c (buffer_slot_type_mismatch): Remove.
1665 (DEFVAR_PER_BUFFER, defvar_per_buffer): Rename type argument to
1666 predicate. Adjust comment.
1667 (syms_of_buffer): Use Qsymbolp for major-mode. Use Qintegerp for
1668 fill-column, left-margin, tab-width, buffer-saved-size,
1669 left-margin-width, right-margin-width, left-fringe-width,
1670 right-fringe-width, scroll-bar-width and buffer-display-count.
1671 Use Qstringp for default-directory, buffer-file-name,
1672 buffer-file-truename and buffer-auto-save-file-name. Use Qfloatp for
1673 scroll-up-aggressively and scroll-down-aggressively. Use Qnumberp for
1674 line-spacing.
1675 * data.c (store_symval_forwarding): Adjust to call the predicate.
1676
5104861e
JB
16772013-01-09 Juanma Barranquero <lekktu@gmail.com>
1678
1679 * w32.c (get_name_and_id, acl_set_file):
1680 * w32term.c (w32fullscreen_hook): Remove unused local variables.
1681
eefd7278
DA
16822013-01-09 Dmitry Antipov <dmantipov@yandex.ru>
1683
1684 * lisp.h (make_gap_1): New prototype.
1685 * buffer.h (GAP_BYTES_DFL, GAP_BYTES_MIN): New macros for the special
1686 gap size values.
1687 * editfns.c (Fbuffer_size): Rename from Fbufsize to fit the common
1688 naming convention.
1689 (syms_of_editfns): Adjust defsubr. Drop commented-out obsolete code.
2eae9ccc 1690 * insdel.c (make_gap_larger): Use GAP_BYTES_DFL. Adjust comment.
eefd7278
DA
1691 (make_gap_smaller): Use GAP_BYTES_MIN. Adjust comment.
1692 (make_gap_1): New function to adjust the gap of any buffer.
1693 * coding.c (coding_alloc_by_making_gap): Use it.
1694 * buffer.c (compact_buffer): Likewise. Use BUF_Z_BYTE, BUF_GAP_SIZE,
1695 GAP_BYTES_DFL and GAP_BYTES_MIN. Adjust comment.
1696
073ca75b
JL
16972013-01-08 Juri Linkov <juri@jurta.org>
1698
1699 * xfaces.c (tty_supports_face_attributes_p): Return 0 for the case
1700 of (supports :underline (:style wave)). (Bug#13000)
1701
3bace969
AH
17022013-01-08 Aaron S. Hawley <aaron.s.hawley@gmail.com>
1703
1704 * undo.c (Fprimitive_undo): Move to simple.el.
1705 (syms_of_undo): Remove declarations for Sprimitive_undo.
1706
63a63bd4
SM
17072013-01-08 Stefan Monnier <monnier@iro.umontreal.ca>
1708
1709 * keyboard.c (echo_add_key): Rename from echo_add_char.
1710
56ed110a
CY
17112013-01-06 Chong Yidong <cyd@gnu.org>
1712
1713 * keyboard.c (echo_add_char): New function, factored out from
1714 echo_char. Don't add a space if the previous echo string was
1715 empty (Bug#13255).
1716 (echo_char): Use it.
1717 (read_key_sequence): When echoing mock input, ensure that the
1718 trailing dash is properly added.
1719
b630991b
EZ
17202013-01-05 Eli Zaretskii <eliz@gnu.org>
1721
1722 * xdisp.c (dump_glyph): Align glyph data better. Use "pD" instead
1723 of a non-portable "t" to print ptrdiff_t values. Allow up to 9
63a63bd4
SM
1724 digits for buffer positions, before misalignment starts.
1725 Display "0" for integer "object" field.
b630991b
EZ
1726 (dump_glyph_row): Adapt the header line to changes in dump_glyph.
1727 Display the newline glyph more unambiguously.
1728
f032a318
YM
17292013-01-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1730
1731 * nsterm.m (ns_draw_underwave):
1732 * w32term.c (w32_draw_underwave):
1733 * xterm.c (x_draw_underwave): Make underwave look more triangular
1734 and also degrade gracefully for small fonts. (Bug#13000)
1735
4240dd3c
YM
1736 * nsterm.m (ns_draw_text_decoration):
1737 * w32term.c (x_draw_glyph_string):
1738 * xterm.c (x_draw_glyph_string): Don't use previous underline
1739 thickness and position if previous underline type is underwave.
1740
553081a5
SM
17412013-01-04 Stefan Monnier <monnier@iro.umontreal.ca>
1742
1743 * fileio.c (Ffile_acl): Undocument return format.
1744
9539d465 17452013-01-02 Glenn Morris <rgm@gnu.org>
08f59219
GM
1746
1747 * keymap.c (Fkey_description): Doc fix. (Bug#13323)
1748
71376d4b
PE
17492013-01-02 Paul Eggert <eggert@cs.ucla.edu>
1750
1751 Simplify via eabs.
1752 * dired.c (file_name_completion):
1753 * doc.c (get_doc_string):
1754 * floatfns.c (round2):
1755 * font.c (font_score, font_delete_unmatched):
1756 * fringe.c (compute_fringe_widths):
1757 * lread.c (read_list):
1758 * minibuf.c (Ftry_completion):
1759 * term.c (tty_ins_del_lines):
1760 * xterm.c (x_draw_image_foreground, x_draw_image_foreground_1):
1761 Use eabs (x) rather than open-coding it as (x < 0 ? -x : x).
1762
a7f11948
EZ
17632012-12-31 Eli Zaretskii <eliz@gnu.org>
1764
1765 * w32.c (unsetenv): Set up the string passed to _putenv
63a63bd4
SM
1766 correctly.
1767 See http://lists.gnu.org/archive/html/emacs-devel/2012-12/msg00863.html
a7f11948
EZ
1768 for the bug this caused.
1769
84cc1ab6
PE
17702012-12-30 Paul Eggert <eggert@cs.ucla.edu>
1771
1772 * coding.c (Qmac): Now static.
1773
5a1d858b
JD
17742012-12-30 Jan Djärv <jan.h.d@swipnet.se>
1775
1776 * gtkutil.c (TOOLBAR_TOP_WIDGET): New macro.
1777 (xg_pack_tool_bar): Use TOOLBAR_TOP_WIDGET, condition out use of
1778 handlebox_widget. Set toolbar_in_hbox to false/true, set
1779 toolbar_is_packed to true.
1780 (xg_update_tool_bar_sizes): Use widget returned by TOOLBAR_TOP_WIDGET.
1781 (update_frame_tool_bar): Check toolbar_is_packed for packing.
1782 Show all on TOOLBAR_TOP_WIDGET.
1783 (free_frame_tool_bar): Check toolbar_is_packed. Use widget returned
1784 by TOOLBAR_TOP_WIDGET.
1785 (xg_change_toolbar_position): Use widget returned by TOOLBAR_TOP_WIDGET.
1786 Check toolbar_is_packed.
8b745d92
JD
1787 (xg_have_tear_offs, tearoff_remove, tearoff_activate): Condition on
1788 HAVE_GTK_TEAROFF_MENU_ITEM_NEW.
1789 (xg_have_tear_offs): When ! HAVE_GTK_TEAROFF_MENU_ITEM_NEW, return
1790 false.
1791 (create_menus): Create tearoff only if HAVE_GTK_TEAROFF_MENU_ITEM_NEW.
1792 (xg_update_menubar): Update title only if
1793 HAVE_GTK_TEAROFF_MENU_ITEM_NEW.
1794 (xg_update_submenu): Skip tearoff only if
1795 HAVE_GTK_TEAROFF_MENU_ITEM_NEW.
1796 (xg_initialize): Initialize xg_detached_menus only if
1797 HAVE_GTK_TEAROFF_MENU_ITEM_NEW.
5a1d858b
JD
1798
1799 * xterm.h (struct x_output): Surround handlebox_widget with
1800 #ifdef HAVE_GTK_HANDLE_BOX_NEW. toolbar_is_packed is new,
1801 toolbar_in_hbox is bool.
1802
d5e5e7b4 18032012-12-30 Andreas Schwab <schwab@linux-m68k.org>
2550c6e4
AS
1804
1805 * src/Makefile.in (TEMACS_LDFLAGS2): Remove.
1806 (LIBS_GNUSTEP): Define.
1807 (LIBES): Add $(LIBS_GNUSTEP).
1808 (temacs$(EXEEXT)): Use $(LDFLAGS) instead of $(TEMACS_LDFLAGS2).
1809
d5e5e7b4 18102012-12-30 Eli Zaretskii <eliz@gnu.org>
7a3a7493
EZ
1811
1812 * xdisp.c (set_cursor_from_row): Don't confuse a truncation or
1813 continuation glyph on a TTY with an indication of an empty line.
1814 (Bug#13277)
1815
e7ae8039
EZ
18162012-12-29 Eli Zaretskii <eliz@gnu.org>
1817
ccad023b
EZ
1818 * fileio.c (Fset_file_selinux_context, Fset_file_acl): Return t if
1819 file's SELinux context or ACLs successfully set, nil otherwise.
1820 (Bug#13298)
8d23a331 1821 (Fcopy_file) [WINDOWSNT]: Improve diagnostics when CopyFile fails.
ccad023b 1822
e7ae8039
EZ
1823 * w32proc.c (reader_thread): Avoid passing NULL handles to
1824 SetEvent and WaitForSingleObject.
1825
7456e13f
PE
18262012-12-28 Paul Eggert <eggert@cs.ucla.edu>
1827
1828 Port EXTERNALLY_VISIBLE to Clang 3.2.
1829 * conf_post.h (__has_attribute): New macro.
1830 (EXTERNALLY_VISIBLE): Use it. This ports to Clang 3.2.
1831
1ab0c851
GM
18322012-12-27 Glenn Morris <rgm@gnu.org>
1833
1834 * cygw32.c (Fcygwin_convert_file_name_to_windows)
1835 (Fcygwin_convert_file_name_from_windows): Doc fixes.
1836
82e2a1f0 18372012-12-27 Eli Zaretskii <eliz@gnu.org>
f5c81c80 1838
63a63bd4
SM
1839 * fileio.c (file_name_as_directory, directory_file_name):
1840 Accept an additional argument MULTIBYTE to indicate whether the input C
f5c81c80
EZ
1841 came from a multibyte or a unibyte Lisp string; all callers
1842 adjusted. Don't assume the input string is always multibyte.
1843 (Bug#13262)
1844 (Ffile_name_directory) [DOS_NT]: Handle unibyte strings correctly:
1845 don't ENCODE_FILE them, and return a unibyte string if the input
1846 was unibyte.
1847 (Fexpand_file_name): Don't mix unibyte with multibyte strings, and
1848 don't assume the input strings will always be multibyte. If the
1849 input strings are multibyte, decode strings obtained from C
1850 library functions.
1851
8847a0de
DA
18522012-12-26 Dmitry Antipov <dmantipov@yandex.ru>
1853
1854 * lisp.h (toplevel): Add two notices to the comment about
1855 defining a new Lisp data type.
6cda572a
DA
1856 * print.c (print_object): If Lisp_Save_Value object's pointer
1857 is the address of a memory area containing Lisp_Objects, try
1858 to print them.
1859 * alloc.c (valid_lisp_object_p): Adjust comment.
8847a0de 1860
4b298d5a
DA
18612012-12-26 Dmitry Antipov <dmantipov@yandex.ru>
1862
1863 * keyboard.c (record_asynch_buffer_change): Initialize an event
1864 only if it's really needed.
1865 * frame.h (enum output_method): Remove output_mac member since
1866 it's a leftover from the deleted code.
1867 * frame.c (Fframep): Adjust user here ...
1868 * terminal.c (Fterminal_live_p): ... and here.
1869 * coding.c (Qmac): Now here because it's only used to denote
1870 end-of-line encoding type.
1871 (syms_of_coding): DEFSYM it.
1872 * frame.h (Qmac): Remove duplicated declaration.
1873
12384b01
PE
18742012-12-26 Paul Eggert <eggert@cs.ucla.edu>
1875
1876 * window.c (select_window_1): Now static, since it's used only here.
1877
f1665bdc
EZ
18782012-12-25 Eli Zaretskii <eliz@gnu.org>
1879
1880 * window.c (window_body_cols): Subtract display margins from the
1881 window body width on TTYs as well. See
1882 http://lists.gnu.org/archive/html/help-gnu-emacs/2012-12/msg00317.html
1883 for the original report.
1884
9a0d4f34
DA
18852012-12-25 Dmitry Antipov <dmantipov@yandex.ru>
1886
1887 * xdisp.c (redisplay_window): Remove inner local variable
1888 because the outer shadowed one has the same meaning.
cd78d9b1
DA
1889 * xterm.h (struct x_output): Remove toolbar_detached member since it's
1890 set but never used.
1891 * gtkutil.c (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
1892 (xg_create_tool_bar): Adjust users.
9a0d4f34 1893
f9e7c67e
DA
18942012-12-24 Dmitry Antipov <dmantipov@yandex.ru>
1895
1896 * buffer.h (BUF_COMPACT): New macro to follow the common style.
1897 * buffer.c (Fget_buffer_create): Use it to set compact field of
1898 struct buffer_text to avoid accessing an uninitialized value
1899 when compact_buffer is called for the first time.
1900 (compact_buffer): Use convenient BUF_COMPACT and BUF_MODIFF.
2944d406
DA
1901 (Fset_buffer_modified_p): Use buffer_window_count to check
1902 whether the buffer is displayed in some window.
1903 * xdisp.c (message_dolog): Likewise.
f9e7c67e 1904
299614f3
EZ
19052012-12-23 Eli Zaretskii <eliz@gnu.org>
1906
40ff07a5
EZ
1907 * w32.c (acl_set_file): If setting the file security descriptor
1908 fails, and the new DACL is identical to the existing one, silently
1909 return success. This fixes problems for users backing up their
1910 own files without having the necessary privileges for setting
1911 security descriptors.
1912
299614f3
EZ
1913 * w32proc.c (reader_thread): Do not index fd_info[] with negative
1914 values.
1915 (reader_thread): Exit when cp->status becomes STATUS_READ_ERROR
1916 after WaitForSingleObject returns normally. This expedites reader
1917 thread shutdown when delete_child triggers it.
1918 (reap_subprocess): More accurate commentary for why we call
1919 delete_child only when cp->fd is negative.
1920
1921 * w32.c (sys_close): Do not call delete_child on a subprocess
1922 whose handle is not yet closed. Instead, set its file descriptor
1923 to a negative value, so that reap_subprocess will call
63a63bd4
SM
1924 delete_child on that subprocess when its SIGCHLD arrives.
1925 This avoids closing handles used for communications between sys_select
299614f3
EZ
1926 and reader_thread, which doesn't give sys_select a chance to
1927 notice that the process exited and invoke the SIGCHLD handler for
1928 it.
1929
cf162aee
JD
19302012-12-23 Jan Djärv <jan.h.d@swipnet.se>
1931
1932 * nsfns.m (Fns_do_applescript): Run event loop until script has
1933 been executed (Bug#12969).
1934 (ns_run_ascript): Chech as_script for nil, set to nil after
1935 executing script.
1936
94900bfe
MR
19372012-12-22 Martin Rudalics <rudalics@gmx.at>
1938
1939 * window.c (Fselect_window): Reword doc-string (Bug#13248).
1940
b2faf49c
EZ
19412012-12-22 Eli Zaretskii <eliz@gnu.org>
1942
1943 * w32term.c (w32fullscreen_hook): New function.
1944 (w32_create_terminal): Plug it into the terminal's fullscreen_hook.
1945
7efa3fb3
EZ
19462012-12-21 Eli Zaretskii <eliz@gnu.org>
1947
bb085aed
EZ
1948 * fileio.c (Finsert_file_contents): Doc fix.
1949
7efa3fb3
EZ
1950 * w32proc.c (new_child, delete_child, find_child_pid): For a
1951 subprocess, consider its slot being in use as long as its process
1952 handle (procinfo.hProcess) is not NULL. This avoids reusing the
1953 slot when a new process is started immediately after killing
1954 another one, without waiting enough time for the first process to
1955 be reaped and resources allocated for it be orderly freed.
1956 (Bug#13086)
1957 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
1958
c1f02afa
CY
19592012-12-21 Chong Yidong <cyd@gnu.org>
1960
1961 * buffer.c (Fset_buffer_major_mode): Doc fix (Bug#13231).
1962
5bec25eb
CY
1963 * fns.c (Fcompare_strings): Doc fix (Bug#13081).
1964
a4b0cca1 19652012-12-21 Eli Zaretskii <eliz@gnu.org>
92340ec7
EZ
1966
1967 * w32.c (get_name_and_id): Always pass NULL as the first argument
1968 of lookup_account_sid. Avoids crashes with UNC file names that
1969 refer to DFS domains, not to specific machine names. (Bug#12621)
1970 Remove now unused argument FNAME; all callers changed.
1971 (get_file_owner_and_group): Remove now unused argument FNAME; all
1972 callers changed.
1973
34b4b7eb
CY
19742012-12-21 Chong Yidong <cyd@gnu.org>
1975
1976 * editfns.c (Finsert_char): Since read-char-by-name now signals an
1977 error for invalid chars, don't check for a nil return value.
1978
13002885
DA
19792012-12-20 Dmitry Antipov <dmantipov@yandex.ru>
1980
1981 Avoid calls to CHAR_TO_BYTE if byte position is known.
1982 * editfns.c (make_buffer_string_both): Use move_gap_both.
1983 (Fbuffer_string): Use make_buffer_string_both.
1984 * marker.c (buf_charpos_to_bytepos): Convert to eassert.
1985 Adjust comment.
1986 (buf_bytepos_to_charpos): Likewise.
1987 (charpos_to_bytepos): Remove.
1988 * fileio.c (Finsert_file_contents): Use move_gap_both.
1989 * search.c (Freplace_match): Likewise.
9a0d4f34 1990 * process.c (process_send_region): Likewise. Use convenient
13002885
DA
1991 names for byte positions.
1992 * lisp.h (charpos_to_bytepos): Remove prototype.
1993 * indent.c (scan_for_column): Use CHAR_TO_BYTE.
1994 * insdel.c (move_gap): Likewise.
1995
99e9311c
PE
19962012-12-20 Paul Eggert <eggert@cs.ucla.edu>
1997
1998 * xdisp.c (redisplay_internal): Remove now-unused local.
1999
e02230bf
SM
20002012-12-20 Stefan Monnier <monnier@iro.umontreal.ca>
2001
2002 * xdisp.c (select_frame_for_redisplay, ensure_selected_frame): Remove.
2003 (redisplay_internal): Don't bother selecting the frame to get the
4a74c818 2004 proper value of frame-local variables (bug#13225).
e02230bf 2005
1687fb14
DA
20062012-12-20 Dmitry Antipov <dmantipov@yandex.ru>
2007
2008 * textprop.c (set_text_properties_1): Do not allow NULL interval.
2009 Rename 4th argument since it may be buffer or string. Adjust comment.
2010 * intervals.c (graft_intervals_info_buffer): Find an interval here.
2011
a2f07cd2
DA
20122012-12-19 Dmitry Antipov <dmantipov@yandex.ru>
2013
2014 * coding.c (Fdetect_coding_region): Do not check start and end with
2015 CHECK_NUMBER_COERCE_MARKER since validate_region does that itself.
2016 (code_convert_region): Likewise.
2017
474d441e
EZ
20182012-12-18 Eli Zaretskii <eliz@gnu.org>
2019
2020 * w32.c (acl_get_file, acl_set_file): Run the file name through
2021 map_w32_filename, and resolve any symlinks in the file name, like
2022 Posix platforms do.
2023 (acl_set_file): Call revert_to_self, if any privileges were
2024 enabled.
2025
8725c076
JB
20262012-12-17 Juanma Barranquero <lekktu@gmail.com>
2027
2028 * makefile.w32-in ($(BLD)/editfns.$(O), $(BLD)/fileio.$(O))
2029 ($(BLD)/w32.$(O)): Update dependencies.
2030
1e101a4b
SM
20312012-12-17 Stefan Monnier <monnier@iro.umontreal.ca>
2032
2033 * xdisp.c (select_frame_for_redisplay): Use select_window_1 to
2034 propagate redisplay's scrolling (if any) to the right window.
2035 (redisplay_internal): Use ensure_selected_frame.
2036 (display_mode_lines): Complete last fix.
2037 * window.c (select_window_1): New func, extracted from select_window.
2038 (select_window): Use it.
2039 * window.h (select_window_1): Declare.
2040
66447e07
EZ
20412012-12-17 Eli Zaretskii <eliz@gnu.org>
2042
2043 Emulate Posix ACL APIs on MS-Windows.
2044 * w32.c: Include sddl.h and sys/acl.h.
2045 (SDDL_REVISION_1): Define if not already defined.
2046 (g_b_init_get_security_descriptor_dacl)
2047 (g_b_init_convert_sd_to_sddl, g_b_init_convert_sddl_to_sd)
2048 (g_b_init_is_valid_security_descriptor)
2049 (g_b_init_set_file_security): New static flags.
2050 (globals_of_w32): Initialize them to zero.
2051 (SetFileSecurity_Name): New string constant.
2052 (SetFileSecurity_Proc, GetSecurityDescriptorDacl_Proc)
2053 (ConvertStringSecurityDescriptorToSecurityDescriptor_Proc)
2054 (ConvertSecurityDescriptorToStringSecurityDescriptor_Proc)
2055 (IsValidSecurityDescriptor_Proc): New typedefs.
2056 (get_file_security, get_security_descriptor_owner)
2057 (get_security_descriptor_group): Set errno to ENOTSUP.
2058 (set_file_security, get_security_descriptor_dacl)
2059 (is_valid_security_descriptor, convert_sd_to_sddl)
2060 (convert_sddl_to_sd, acl_valid, acl_to_text, acl_from_text)
2061 (acl_free, acl_get_file, acl_set_file): New functions.
2062
2063 * fileio.c (Fcopy_file) [WINDOWSNT]: Support copying ACLs.
2064
207a7ef0
PE
20652012-12-17 Paul Eggert <eggert@cs.ucla.edu>
2066
2067 Don't reraise SIGCHLD, as that can now lose (Bug#13192).
2068 With the 2012-12-03 fix for Bug#12980 in place, an old workaround
2069 for some of that bug's symptoms can now cause Emacs to abort.
2070 Remove the workaround.
2071 * process.c (wait_reading_process_output): Don't reraise SIGCHLD.
2072 The bug that caused SIGCHLD to get lost has been fixed, and the
2073 workaround for it can now cause Emacs to abort.
2074
17fdfc15
PE
20752012-12-16 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 * sysdep.c (emacs_abort): Bump backtrace size to 40.
2078 Companion to the 2012-09-30 patch. Suggested by Eli Zaretskii in
2079 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00796.html>.
2080
7c3d167f
RF
20812012-12-16 Romain Francoise <romain@orebokech.com>
2082
2083 * fileio.c (Ffile_acl, Fset_file_acl): New functions.
2084 (Fcopy_file): Change last arg to `preserve_extended_attributes'
1e101a4b 2085 and copy ACL entries of file in addition to SELinux context if set.
7c3d167f
RF
2086 (syms_of_fileio): Add `file-acl' and `set-file-acl'.
2087
2088 * Makefile.in (LIBACL_LIBS): New macro.
2089 (LIBES): Use it.
2090
7d80ea23
PE
20912012-12-15 Paul Eggert <eggert@cs.ucla.edu>
2092
2093 * fileio.c (internal_delete_file): Use bool for boolean.
2094
b0728617
EZ
20952012-12-15 Eli Zaretskii <eliz@gnu.org>
2096
2097 Fix bug #13079 on MS-Windows with temp files not being deleted.
2098 * w32.h (_child_process): New members input_file and
2099 pending_deletion.
2100 (register_child): First argument is now pid_t.
2101 (record_infile, record_pending_deletion): New prototypes.
2102
2103 * w32proc.c (new_child): Initialize input_file and
2104 pending_deletion members of the child.
2105 (delete_child): Delete the child's temporary input file, if any,
2106 that is pending deletion.
2107 (register_child): First argument is now pid_t.
2108 (record_infile, record_pending_deletion): New functions.
2109 (reap_subprocess): Fix a typo in DebPrint string.
2110 (sys_spawnve, sys_kill): Use pid_t for PID arguments.
2111
2112 * fileio.c (internal_delete_file): Return an int again: non-zero
2113 if delete-file succeeds, zero otherwise.
2114
2115 * lisp.h (internal_delete_file): Adjust prototype.
2116
2117 * callproc.c (Fcall_process): Don't overwrite infile with result
2118 of DECODE_FILE.
2119 [WINDOWSNT] If BUFFER is an integer, i.e. we are launching an
2120 asynchronous subprocess, record the name of the input file name,
2121 if any.
2122 (delete_temp_file) [WINDOWSNT]: If internal_delete_file fails to
2123 delete the file, record it as pending deletion when the subprocess
2124 exits.
2125
7e90af26
EZ
21262012-12-14 Eli Zaretskii <eliz@gnu.org>
2127
2128 * editfns.c [HAVE_PWD_H]: Include grp.h.
2129
2130 * makefile.w32-in ($(BLD)/editfns.$(O)): Add $(NT_INC)/grp.h.
2131
97976f9f
PE
21322012-12-14 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 Fix permissions bugs with setgid directories etc. (Bug#13125)
2135 * dired.c (Ffile_attributes): Return t as the 9th attribute,
2136 to mark it as a placeholder. The old value was often wrong.
2137 The only user of this attribute has been changed to use
2138 file-ownership-preserved-p instead, with its new group arg.
2139 * editfns.c (Fgroup_gid, Fgroup_real_gid): New functions.
2140
26ec1f49
SM
21412012-12-14 Stefan Monnier <monnier@iro.umontreal.ca>
2142
ad966fe7
SM
2143 * xdisp.c (select_frame_for_redisplay, display_mode_lines):
2144 Keep selected_window and selected_frame in sync.
26ec1f49 2145
5c207910
EZ
21462012-12-14 Eli Zaretskii <eliz@gnu.org>
2147
2148 * w32.c (stat_worker): If w32_stat_get_owner_group is zero, do not
2149 try to get accurate owner and group information from NT file
2150 security APIs. This is to make most callers of 'stat' and
2151 'lstat', which don't need that information, much faster.
2152
26ec1f49
SM
2153 * dired.c (Ffile_attributes) [WINDOWSNT]:
2154 Set w32_stat_get_owner_group to a non-zero value, to request accurate
5c207910
EZ
2155 owner and group information from 'lstat'.
2156
893f52d8
PE
21572012-12-13 Paul Eggert <eggert@cs.ucla.edu>
2158
4c95c9a5
PE
2159 * fileio.c (Finsert_file_contents): Don't put tail into head area,
2160 as that confuses set-auto-coding, so insist on the head-read
2161 returning the full 1024 bytes. Let lseek compute the tail offset;
2162 less work for us. Do not ignore I/O errors when reading the tail.
2163
893f52d8
PE
2164 * xdisp.c: Minor style fixes.
2165 (init_iterator): Hoist assignment out of if-expression.
2166 (markpos_of_region): Callers now test for sign, not for -1.
2167
40d1e434
DA
21682012-12-13 Dmitry Antipov <dmantipov@yandex.ru>
2169
2170 Minor redisplay optimization when the region length is zero.
2171 * xdisp.c (markpos_of_region): New function.
2172 (init_iterator): Do not highlight the region of zero length.
2173 (redisplay_window): Check whether the region is of non-zero length.
2174 (try_cursor_movement): Allow if the region length is zero.
2175 (try_window_reusing_current_matrix, try_window_id): Likewise.
2176
727f9739 21772012-12-13 Eli Zaretskii <eliz@gnu.org>
e8c6e965
EZ
2178
2179 * search.c (search_buffer): Check the inverse translations of each
2180 character in pattern when the buffer being searched is unibyte.
2181 (Bug#13084)
2182
727f9739 21832012-12-13 Paul Eggert <eggert@cs.ucla.edu>
184246df
PE
2184
2185 * fileio.c (Fvisited_file_modtime): Return (-1 ...) for nonexistent
2186 files, fixing a regression from 24.2.
645c6a30 2187 (Fverify_visited_file_modtime): Don't read uninitialized st.st_size.
184246df 2188
d20704ef
PE
21892012-12-13 Paul Eggert <eggert@cs.ucla.edu>
2190
2191 * fileio.c (Fcopy_file): Make fstat failure as serious as open failure.
2192 fstat shouldn't fail, and if it does fail copy-file should not proceed.
2193 Remove unnecessary S_ISLNK test, as (contra the comments) this
2194 function can't copy symlinks. Improve quality of error message
2195 when attempting to copy files that are neither regular files nor
2196 directories.
2197
2dd61a9b
DA
21982012-12-12 Dmitry Antipov <dmantipov@yandex.ru>
2199
2200 * dispnew.c (set_window_cursor_after_update): Use clip_to_bounds.
2201 * gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
2202 * window.c (Frecenter):
2203 * xdisp.c (resize_mini_window, hscroll_window_tree, draw_glyphs):
2204 * xterm.c (x_set_toolkit_scroll_bar_thumb): Likewise.
2205
cc98b684
DC
22062012-12-12 Daniel Colascione <dancol@dancol.org>
2207
1e101a4b 2208 * unexcw.c (fixup_executable): Use posix_fallocate to ensure that
cc98b684
DC
2209 the dumped Emacs is not a sparse file, greatly improving Cygwin
2210 "make bootstrap" performance.
2211
38e791fd
MA
22122012-12-11 Michael Albinus <michael.albinus@gmx.de>
2213
2214 * inotify.c (inotify_callback): Generate an Emacs event for every
2215 incoming inotify event.
2216
f9d1448f
EZ
22172012-12-11 Eli Zaretskii <eliz@gnu.org>
2218
2219 * xdisp.c (handle_face_prop): Fix logic of computing
2220 it->start_of_box_run_p.
2221 (append_space_for_newline): If the glyph row is R2L, reset the
2222 iterator's end_of_box_run_p flag before prepending the space glyph.
2223 (extend_face_to_end_of_line): If the glyph row is R2L, reset the
2224 iterator's start_of_box_run_p flag before prepending the stretch.
2225 (append_glyph, produce_image_glyph, append_composite_glyph)
2226 (append_stretch_glyph, append_glyphless_glyph): Reverse the
2227 left_box_line_p and right_box_line_p flags of the glyph for R2L
2228 glyph rows. (Bug#13011)
2229
c6afe371
DA
22302012-12-11 Dmitry Antipov <dmantipov@yandex.ru>
2231
2232 * buffer.c (Fset_buffer_multibyte): Do not force redisplay
2233 if changed buffer is not shown in a window.
2234 * insdel.c (prepare_to_modify_buffer): Likewise.
2235 * window.c (replace_buffer_in_windows_safely): Do nothing
2236 if buffer is not shown in a window.
2237 (Fforce_window_update): Likewise if string or buffer argument
2238 is passed.
2239
1b47babd
EZ
22402012-12-11 Eli Zaretskii <eliz@gnu.org>
2241
2242 * inotify.c (Finotify_add_watch): Rename decoded_file_name to
2243 encoded_file_name, which is what it is.
2244
4c1acb95
DA
22452012-12-11 Dmitry Antipov <dmantipov@yandex.ru>
2246
2247 Consistently use marker_position and marker_byte_position.
2248 * fringe.c (Ffringe_bitmaps_at_pos):
2249 * indent.c (Fvertical_motion):
2250 * insdel.c (prepare_to_modify_buffer):
2251 * keyboard.c (make_lispy_position):
2252 * window.c (Fwindow_end, Fpos_visible_in_window_p, unshow_buffer)
2253 (window_scroll_pixel_based, displayed_window_lines)
2254 (Fset_window_configuration):
2255 * xdisp.c (message_dolog, with_echo_area_buffer_unwind_data)
2256 (mark_window_display_accurate_1, redisplay_window, decode_mode_spec):
2257 Replace direct access to marker fields with calls
2258 to marker_position and/or marker_byte_position.
2259
0eeb69fe
JB
22602012-12-11 Juanma Barranquero <lekktu@gmail.com>
2261
2262 * makefile.w32-in (SIG2STR_H): New macro.
2263 (SYSWAIT_H, $(BLD)/emacs.$(O), $(BLD)/process.$(O))
2264 ($(BLD)/w32notify.$(O)): Update dependencies.
2265
1cf1bbd5
DC
22662012-12-10 Daniel Colascione <dancol@dancol.org>
2267
8db4b52f
DC
2268 * w32term.c, keyboard.c: Fix build break in cygw32 by omitting
2269 Windows file notification functionality unless WINDOWSNT.
2270
1cf1bbd5
DC
2271 * w32gui.h (hprevinst, lpCmdLine, nCmdShow): Remove unused
2272 declarations.
2273
2274 * w32fns.c (cache_system_info): Initialize the global hinst
2275 variable here so various initialization calls DTRT.
2276
1e101a4b 2277 * unexw32.c (hprevinst, lpCmdLine, nCmdShow): Remove unused variables.
1cf1bbd5
DC
2278 (hinst): Remove unneeded extern declaration.
2279 (_start): Remove initialization of above variables; remove
2280 initialization of hinst, as cache_system_info now does that.
2281
2282 * emacs.c (main): Call cache_system_info early in startup; we
2283 previously weren't calling it in Cygwin builds.
2284
26ec1f49
SM
2285 * Makefile.in (ntsource, WINDRES, W32_RES, W#@_RES_LINK):
2286 Teach the autoconf build system how to compile a Windows resource file
1cf1bbd5
DC
2287 and link it to Emacs.
2288
98a07056
DA
22892012-12-10 Dmitry Antipov <dmantipov@yandex.ru>
2290
2291 Per-buffer window counters.
2292 * buffer.h (struct buffer): New member window_count.
2293 (buffer_window_count): New function.
2294 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2295 Initialize window_count.
2296 (Fkill_buffer): Verify window_count for the buffer being killed.
2297 (modify_overlay): Do not force redisplay if buffer is not shown
2298 in any window.
2299 (init_buffer_once): Initialize window_count for buffer_defaults
2300 and buffer_local_symbols.
2301 * window.h (buffer_shared): Remove declaration.
2302 (wset_buffer): Convert from inline ...
2303 * window.c (wset_buffer): ... to an ordinary function.
2304 (adjust_window_count): New function.
2305 (make_parent_window): Use it.
2306 * xdisp.c (buffer_shared): Remove.
2307 (redisplay_internal, redisplay_window): Adjust users.
2308 (buffer_shared_and_changed): Use per-buffer window counter.
2309
2b8c9064
EZ
23102012-12-10 Eli Zaretskii <eliz@gnu.org>
2311
2312 Support for filesystem notifications on MS-Windows.
2313 * w32proc.c (sys_select): If drain_message_queue returns non-zero,
2314 and this is a TTY frame, signal the caller that keyboard input is
2315 available.
2316
2317 * w32xfns.c (drain_message_queue): Now returns an int: an
2318 indication whether any WM_EMACS_FILENOTIFY messages were found in
2319 the queue.
2320
2321 * w32inevt.c (handle_file_notifications): New function.
2322 (w32_console_read_socket): Call it to process file notifications.
2323
2324 * w32console.c (initialize_w32_display): Record the main thread ID
2325 in dwMainThreadId.
2326
2327 * deps.mk (inotify.o): New dependency list.
2328
2329 * Makefile.in (SOME_MACHINE_OBJECTS): Add w32notify.o.
2330
2331 * w32term.h (WM_EMACS_FILENOTIFY): New custom message.
2332 (WM_EMACS_END): Bump value by 1.
2333 (notification_buffer_in_use, file_notifications)
2334 (notifications_size, notifications_desc): Declare.
2335 (w32_get_watch_object, lispy_file_action, globals_of_w32notify):
2336 Add prototypes.
2337
2338 * w32term.c (lispy_file_action, queue_notifications): New functions.
2339 (syms_of_w32term) <Qadded, Qremoved, Qmodified, Qrenamed_from>
2340 <Qrenamed_to>: New symbols.
2341 (w32_read_socket): Handle the WM_EMACS_FILENOTIFY message.
2342
2343 * w32notify.c: New file, implements file event notifications for
2344 MS-Windows.
2345
2346 * w32fns.c (w32_wnd_proc): Handle the WM_EMACS_FILENOTIFY message
2347 by posting it to the w32_read_socket queue.
2348
1e101a4b 2349 * termhooks.h (enum event_kind) [HAVE_NTGUI]: Support FILE_NOTIFY_EVENT.
2b8c9064
EZ
2350
2351 * makefile.w32-in (OBJ2): Add $(BLD)/w32notify.$(O).
2352 (GLOBAL_SOURCES): Add w32notify.c
2353 ($(BLD)/w32notify.$(O)): New set of dependencies.
2354
2355 * lisp.h (syms_of_w32notify) [WINDOWSNT]: Add prototype.
2356
1e101a4b
SM
2357 * keyboard.c (kbd_buffer_get_event) [WINDOWSNT]:
2358 Handle FILE_NOTIFY_EVENT.
2b8c9064
EZ
2359 (syms_of_keyboard) [HAVE_NTGUI] <Qfile_notify>: New symbol.
2360 (keys_of_keyboard) [WINDOWSNT]: Bind file-notify to
2361 w32notify-handle-event by default.
2362
2363 * emacs.c (main) [WINDOWSNT]: Call globals_of_w32notify and
2364 syms_of_w32notify.
2365
81606b10
RS
23662012-12-10 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
2367
2b8c9064 2368 Support for filesystem notifications on GNU/Linux via inotify.
1e101a4b 2369 * termhooks.h (enum event_kind) [HAVE_INOTIFY]: Add FILE_NOTIFY_EVENT.
81606b10
RS
2370
2371 * lisp.h (syms_of_inotify) [HAVE_INOTIFY]: Add prototype.
2372
2373 * keyboard.c (Qfile_inotify) [HAVE_INOTIFY]: New variable.
2374 (syms_of_keyboard): DEFSYM it.
2375 (kbd_buffer_get_event) [HAVE_INOTIFY]: Generate FILE_NOTIFY_EVENT.
2376 (make_lispy_event): Support FILE_NOTIFY_EVENT by generating
2377 Qfile_inotify events.
2378 (keys_of_keyboard) [HAVE_INOTIFY]: Bind file-inotify events in
2379 special-event-map to inotify-handle-event.
2380
2381 * emacs.c (main) [HAVE_INOTIFY]: Call syms_of_inotify.
2382
2383 * Makefile.in (base_obj): Add inotify.o.
2384
2385 * inotify.c: New file.
2386
265c2fbf 23872012-12-10 Jan Djärv <jan.h.d@swipnet.se>
a06ae17d
JD
2388
2389 * nsterm.m (fd_handler:): FD_ZERO fds (Bug#13103).
2390
265c2fbf 23912012-12-10 Fabrice Popineau <fabrice.popineau@gmail.com>
cb576b5c
FP
2392
2393 * w32fns.c (cache_system_info): Cast sysinfo_cache.dwPageSize to
2394 DWORD_PTR, for compatibility with 64-bit builds.
2395
a06ae17d 2396 * w32.c (_PROCESS_MEMORY_COUNTERS_EX):
cb576b5c
FP
2397 (GetProcessWorkingSetSize_Proc, get_process_working_set_size)
2398 (system_process_attributes): Use SIZE_T rather than DWORD, for
2399 compatibility with 64-bit builds.
2400
265c2fbf 24012012-12-10 Christopher Schmidt <christopher@ch.ristopher.com>
76b92fee
CS
2402
2403 * lread.c (Vload_source_file_function): Doc fix (Bug#11647).
2404
265c2fbf 24052012-12-10 Eli Zaretskii <eliz@gnu.org>
81d8cc53
EZ
2406
2407 * indent.c (Fvertical_motion): If a display string will be
2408 displayed on the left or the right margin, don't consider it as a
2409 factor in cursor positioning. (Bug#13108)
2410
265c2fbf 24112012-12-10 Martin Rudalics <rudalics@gmx.at>
2cec368c
MR
2412
2413 * editfns.c (Fcompare_buffer_substrings): Reword doc-string.
2414
5f460827
PE
24152012-12-10 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 * fileio.c (Fsubstitute_in_file_name): Use ptrdiff_t, not int,
2418 for string length.
2419
a16e75cd
EZ
24202012-12-08 Eli Zaretskii <eliz@gnu.org>
2421
2422 * w32.c (unsetenv): Return 0 if the input string is too long.
2423
5745a7df
PE
24242012-12-08 Paul Eggert <eggert@cs.ucla.edu>
2425
2426 Use putenv+unsetenv instead of modifying environ directly (Bug#13070).
2427 * alloc.c (xputenv): New function.
2428 * dbusbind.c (Fdbus_init_bus):
2429 * emacs.c (main):
2430 * xterm.c (x_term_init):
2431 Use xputenv instead of setenv or putenv, to detect memory exhaustion.
2432 * editfns.c (initial_tz): Move static var decl up.
2433 (tzvalbuf_in_environ): New static var.
2434 (init_editfns): Initialize these two static vars.
2435 (Fencode_time): Don't assume arbitrary limit on EMACS_INT width.
2436 Save old TZ value on stack, if it's small.
2437 (Fencode_time, set_time_zone_rule): Don't modify 'environ' directly;
2438 instead, use xputenv+unsetenv to set and restore TZ.
2439 (environbuf): Remove static var. All uses removed.
2440 (Fset_time_zone_rule): Do not save TZ and environ;
2441 no longer needed here.
2442 (set_time_zone_rule_tz1, set_time_zone_rule_tz2) [LOCALTIME_CACHE]:
2443 Move to inside set_time_zone_rule; they don't need file scope any more.
2444 (set_time_zone_rule): Maintain the TZ=value string separately.
2445 (syms_of_editfns): Don't initialize initial_tz;
2446 init_editfns now does it.
2447 * emacs.c (dump_tz) [HAVE_TZSET]: Now const.
2448 * lisp.h (xputenv): New decl.
2449
c56efa40
FP
24502012-12-08 Fabrice Popineau <fabrice.popineau@gmail.com>
2451
2452 * w32fns.c (emacs_abort): Don't do arithmetics on void pointers.
2453
75ceee05
EZ
24542012-12-08 Eli Zaretskii <eliz@gnu.org>
2455
2456 * w32.c (unsetenv, sys_putenv): New functions.
2457
1b6dbfeb
CY
24582012-12-08 Chong Yidong <cyd@gnu.org>
2459
2460 * editfns.c (Finsert_char): Make the error message more
2461 informative (Bug#12992).
2462
d983a10b
PE
24632012-12-08 Paul Eggert <eggert@cs.ucla.edu>
2464
7be78020
PE
2465 Simplify get_lim_data.
2466 * vm-limit.c (get_lim_data): Combine RLIMIT_AS and RLIMIT_DATA methods.
2467 Remove USG and vlimit methods; no longer used these days.
2468 Add #error catchall just in case.
2469
d983a10b
PE
2470 Assume POSIX 1003.1-1988 or later for signal.h (Bug#13026).
2471 Exceptions: do not assume SIGCONT, SIGSTOP, SIGTSTP, SIGTTIN,
2472 SIGTTOU, SIGUSR1, SIGUSR2, as Microsoft platforms lack these.
2473 * process.c [subprocesses]: Include <c-ctype.h>, <sig2str.h>.
2474 (deleted_pid_list, Fdelete_process, create_process)
2475 (record_child_status_change, handle_child_signal, deliver_child_signal)
2476 (init_process_emacs, syms_of_process):
2477 Assume SIGCHLD is defined.
2478 (parse_signal): Remove. All uses removed.
2479 (abbr_to_signal): New static function.
2480 (Fsignal_process): Use it to convert signal names to ints.
2481 * sysdep.c (sys_suspend) [!DOS_NT]: Use kill (0, ...) rather than
2482 kill (getpgrp (), ...).
2483 (emacs_sigaction_init): Assume SIGCHLD is defined.
2484 (init_signals): Assume SIGALRM, SIGCHLD, SIGHUP, SIGKILL,
2485 SIGPIPE, and SIGQUIT are defined. Do not worry about SIGCLD any more.
2486 * syssignal.h (EMACS_KILLPG): Remove.
2487 All uses replaced by 'kill' with a negative pid.
2488 (SIGCHLD): Remove definition, as we now assume SIGCHLD.
2489 * w32proc.c (sys_kill): Support negative pids compatibly with POSIX.
2490
9cdde1e2
PE
24912012-12-07 Paul Eggert <eggert@cs.ucla.edu>
2492
2493 * sysdep.c (get_child_status): Abort on internal error (Bug#13086).
2494 This will cause a production Emacs to dump core instead of
2495 infinite-looping.
2496
822995f8
DA
24972012-12-07 Dmitry Antipov <dmantipov@yandex.ru>
2498
2499 * frame.c (make_frame): Do not set window's buffer to t.
2500 * window.c (Fsplit_window_internal): Likewise. Previously it was
2501 used to indicate that the window is being set up. Now we use
2502 set_window_buffer for all new windows, so the condition in ...
2503 (Fset_window_buffer): ... is always true and can be removed.
2504
ed08365b
DA
25052012-12-07 Dmitry Antipov <dmantipov@yandex.ru>
2506
2507 Convenient macro to check whether the buffer is hidden.
2508 * buffer.h (BUFFER_HIDDEN_P): New macro.
2509 * frame.c (make_frame): Use it. Adjust comment.
2510 * buffer.c (candidate_buffer): New function.
2511 (Fother_buffer, other_buffer_safely): Use it.
2512
e86f5134
EZ
25132012-12-06 Eli Zaretskii <eliz@gnu.org>
2514
2515 * w32proc.c (waitpid): Avoid busy-waiting when called with WNOHANG
2516 if the child process is still running. Instead, exit the wait
2517 loop and return zero. (Bug#13086)
2518
1700db3c
DA
25192012-12-06 Dmitry Antipov <dmantipov@yandex.ru>
2520
2521 * frame.h (x_char_width, x_char_height): Remove prototypes.
2522 * w32term.h (x_char_width, x_char_height): Likewise.
2523 * xfns.c (x_char_width, x_char_height): Remove.
2524 * w32fns.c (x_char_width, x_char_height): Likewise.
2525 * nsfns.c (x_char_width, x_char_height): Likewise.
2526 * frame.c (Fframe_char_width): Use FRAME_COLUMN_WIDTH for
2527 all window frames.
2528 (Fframe_char_height): Likewise with FRAME_LINE_HEIGHT.
2529 * keyboard.c (command_loop_1): Remove prototype.
2530 (command_loop_2, top_level_1): Add static to match prototype.
2531
35fb8050
PE
25322012-12-06 Paul Eggert <eggert@cs.ucla.edu>
2533
2534 Fix a recently-introduced delete-process race condition.
2535 * callproc.c, process.h (record_kill_process):
2536 New function, containing part of the old call_process_kill.
2537 (call_process_kill): Use it.
2538 This does not change call_process_kill's behavior.
2539 * process.c (Fdelete_process): Use record_kill_process to fix a
2540 race condition that could cause Emacs to lose track of a child.
2541
565212e5
DA
25422012-12-06 Dmitry Antipov <dmantipov@yandex.ru>
2543
2544 Avoid code duplication between prev_frame and next_frame.
2545 * frame.c (candidate_frame): New function. Add comment.
2546 (prev_frame, next_frame): Use it. Adjust comment.
2547
d8ad4d3f 25482012-12-06 Eli Zaretskii <eliz@gnu.org>
d3cefd13
EZ
2549
2550 * callproc.c (Fcall_process_region) [!HAVE_MKSTEMP]: If mktemp
2551 fails, signal an error instead of continuing with an empty
2552 string. (Bug#13079)
7c2fcf9b
EZ
2553 Encode expanded temp file pattern before passing it to mkstemp or
2554 mktemp.
d3cefd13 2555
2e7cddd3
EZ
2556 * fileio.c (file_name_as_directory, directory_file_name) [DOS_NT]:
2557 Encode the file name before passing it to dostounix_filename, in
2558 case it will downcase it (under w32-downcase-file-names).
2559 (Bug#12933)
2560
644d3f0d
PE
25612012-12-05 Paul Eggert <eggert@cs.ucla.edu>
2562
2563 Minor call-process cleanups.
2564 * callproc.c (Fcall_process): Do record-unwind-protect on MSDOS
2565 at the same time as other platforms, to simplify analysis.
2566 No need for fd0_volatile since we have synch_process_fd.
2567 Avoid needless emacs_close; arg is always negative.
2568
396376f1
AS
25692012-12-04 Andreas Schwab <schwab@linux-m68k.org>
2570
2571 * callproc.c (Fcall_process): Fix specpdl nesting for asynchronous
2572 processes.
2573
350f51ad
DA
25742012-12-04 Dmitry Antipov <dmantipov@yandex.ru>
2575
2576 * lisp.h (Mouse_HLInfo): Remove set-but-unused mouse_face_image_state
2577 member. Adjust users. Convert mouse_face_past_end, mouse_face_defer
2578 and mouse_face_hidden members to a bitfields.
2579 * frame.h (struct frame): Remove set-but-not-used space_width member.
2580 (FRAME_SPACE_WIDTH): Remove.
2581 * nsterm.m, w32term.c, xterm.c: Adjust users.
2582 * termchar.h (struct tty_display_info): Remove set-but-unused se_is_so
2583 member. Adjust users. Convert term_initted, delete_in_insert_mode,
2584 costs_set, insert_mode, standout_mode, cursor_hidden and flow_control
2585 members to a bitfields.
2586
bc9dbce6
PE
25872012-12-03 Paul Eggert <eggert@cs.ucla.edu>
2588
bb5f74ee
PE
2589 Don't let call-process be a zombie factory (Bug#12980).
2590 Fixing this bug required some cleanup of the signal-handling code.
2591 As a side effect, this change also fixes a longstanding rare race
2592 condition whereby Emacs could mistakenly kill unrelated processes,
2593 and it fixes a bug where a second C-g does not kill a recalcitrant
2594 synchronous process in GNU/Linux and similar platforms.
2595 The patch should also fix the last vestiges of Bug#9488,
2596 a bug which has mostly been fixed on the trunk by other changes.
2597 * callproc.c, process.h (synch_process_alive, synch_process_death)
2598 (synch_process_termsig, sync_process_retcode):
2599 Remove. All uses removed, to simplify analysis and so that
2600 less consing is done inside critical sections.
2601 * callproc.c (call_process_exited): Remove. All uses replaced
2602 with !synch_process_pid.
2603 * callproc.c (synch_process_pid, synch_process_fd): New static vars.
2604 These take the role of what used to be in unwind-protect arg.
2605 All uses changed.
2606 (block_child_signal, unblock_child_signal):
2607 New functions, to avoid races that could kill innocent-victim processes.
2608 (call_process_kill, call_process_cleanup, Fcall_process): Use them.
2609 (call_process_kill): Record killed processes as deleted, so that
2610 zombies do not clutter up the system. Do this inside a critical
2611 section, to avoid a race that would allow the clutter.
2612 (call_process_cleanup): Fix code so that the second C-g works again
2613 on common platforms such as GNU/Linux.
2614 (Fcall_process): Create the child process in a critical section,
2615 to fix a race condition. If creating an asynchronous process,
2616 record it as deleted so that zombies do not clutter up the system.
2617 Do unwind-protect for WINDOWSNT too, as that's simpler in the
2618 light of these changes. Omit unnecessary call to emacs_close
2619 before failure, as the unwind-protect code does that.
2620 * callproc.c (call_process_cleanup):
2621 * w32proc.c (waitpid): Simplify now that synch_process_alive is gone.
2622 * process.c (record_deleted_pid): New function, containing
2623 code refactored out of Fdelete_process.
2624 (Fdelete_process): Use it.
2625 (process_status_retrieved): Remove. All callers changed to use
2626 child_status_change.
2627 (record_child_status_change): Remove, folding its contents into ...
2628 (handle_child_signal): ... this signal handler. Now, this
2629 function is purely a handler for SIGCHLD, and is not called after
2630 a synchronous waitpid returns; the synchronous code is moved to
2631 wait_for_termination. There is no need to worry about reaping
2632 more than one child now.
2633 * sysdep.c (get_child_status, child_status_changed): New functions.
2634 (wait_for_termination): Now takes int * status and bool
2635 interruptible arguments, too. Do not record child status change;
2636 that's now the caller's responsibility. All callers changed.
2637 Reimplement in terms of get_child_status.
2638 (wait_for_termination_1, interruptible_wait_for_termination):
2639 Remove. All callers changed to use wait_for_termination.
2640 * syswait.h: Include <stdbool.h>, for bool.
2641 (record_child_status_change, interruptible_wait_for_termination):
2642 Remove decls.
2643 (record_deleted_pid, child_status_changed): New decls.
2644 (wait_for_termination): Adjust to API changes noted above.
2645
bc9dbce6
PE
2646 * bytecode.c, lisp.h (Qbytecode): Remove.
2647 No longer needed after 2012-11-20 interactive-p changes.
2648
3cf3c607
EZ
26492012-12-03 Eli Zaretskii <eliz@gnu.org>
2650
2651 * xdisp.c (redisplay_window): If the cursor is visible, but inside
2652 the scroll margin, move point outside the margin. (Bug#13055)
2653
005c8d13
JD
26542012-12-03 Jan Djärv <jan.h.d@swipnet.se>
2655
2656 * gtkutil.c (my_log_handler): New function.
2657 (xg_set_geometry): Set log handler to my_log_handler (Bug#11177).
2658
20edc1c9
DA
26592012-12-03 Dmitry Antipov <dmantipov@yandex.ru>
2660
2661 * lisp.h (modify_region): Rename to...
2662 (modify_region_1): ...new prototype.
2663 * textprop.c (modify_region): Now static. Adjust users.
2664 * insdel.c (modify_region): Rename to...
2665 (modify_region_1): ...new function to work with current buffer.
2666 Adjust comment and users. Use true and false for booleans.
2667
62c2e5ed
DA
26682012-12-03 Dmitry Antipov <dmantipov@yandex.ru>
2669
2670 * alloc.c (free_save_value): New function.
2671 (safe_alloca_unwind): Use it.
2672 * lisp.h (free_save_value): New prototype.
2673 * editfns.c (save_excursion_save): Use Lisp_Misc_Save_Value.
2674 Add comment.
2675 (save_excursion_restore): Adjust to match saved data structure.
2676 Use free_save_value to offload some work from GC. Drop obsolete
2677 #if 0 code.
2678
c5bc2d1d 26792012-12-03 Chong Yidong <cyd@gnu.org>
a2458031
CY
2680
2681 * fileio.c (Vauto_save_list_file_name): Doc fix.
2682
c5bc2d1d 26832012-12-03 Fabrice Popineau <fabrice.popineau@gmail.com>
c7b36b95
FP
2684
2685 * w32fns.c: Remove prototype of atof.
1e101a4b 2686 (syspage_mask): Make it DWORD_PTR, for compatibility with 64-bit
c7b36b95 2687 builds.
1e101a4b 2688 (file_dialog_callback): Make it UINT_PTR.
c7b36b95
FP
2689
2690 * w32common.h (syspage_mask): Declare DWORD_PTR, for compatibility
2691 with 64-bit builds.
2692
2693 * w32.c (FILE_DEVICE_FILE_SYSTEM, METHOD_BUFFERED)
2694 (FILE_ANY_ACCESS, CTL_CODE) [_MSC_VER]: Define only if not already
2695 defined.
2696
c5bc2d1d 26972012-12-03 Glenn Morris <rgm@gnu.org>
14d27346 2698
a9de9f0c 2699 * data.c (Fboundp, Fsymbol_value): Doc fix re lexical-binding.
14d27346 2700
21e54a94
PE
27012012-12-02 Paul Eggert <eggert@cs.ucla.edu>
2702
2dd2e622
PE
2703 Fix xpalloc confusion after memory is exhausted.
2704 * alloc.c (xpalloc): Comment fix.
2705 * charset.c (Fdefine_charset_internal): If xpalloc exhausts memory
2706 and signals an error, do not clear charset_table_size, as
2707 charset_table is still valid.
2708 * doprnt.c (evxprintf): Clear *BUF after freeing it.
2709
21e54a94
PE
2710 Use execve to avoid need to munge environ (Bug#13054).
2711 * callproc.c (Fcall_process):
2712 * process.c (create_process):
2713 Don't save and restore environ; no longer needed.
2714 * callproc.c (child_setup):
2715 Use execve, not execvp, to preserve environ.
2716
3e5490f7
PE
27172012-12-01 Paul Eggert <eggert@cs.ucla.edu>
2718
2719 * xterm.c (x_draw_image_relief): Remove unused locals (Bug#10500).
2720
75b4f59c
YM
27212012-12-01 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2722
2723 * xterm.c (x_draw_relief_rect, x_draw_image_relief): Fix relief
2724 display for sliced images (Bug#10500).
2725
2726 * w32term.c (w32_draw_relief_rect, x_draw_image_relief): Likewise.
2727
f8aff4c6
JB
27282012-11-30 Juanma Barranquero <lekktu@gmail.com>
2729
2730 * doc.c (Fdocumentation): Re-add handling of function-documentation,
2731 accidentally removed in 2012-11-09T04:10:16Z!monnier@iro.umontreal.ca (bug#13034).
2732
3940b924
DA
27332012-11-29 Dmitry Antipov <dmantipov@yandex.ru>
2734
2735 * xdisp.c (window_outdated): Remove eassert since it hits
2736 some suspicious corner cases (see Bug#13007 and Bug#13012).
2737 (mode_line_update_needed): New function.
2738 (redisplay_internal, redisplay_window): Use it.
2739 (ensure_selected_frame): New function.
2740 (redisplay_internal, unwind_redisplay): Use it.
2741 (redisplay_internal): Move comment about buffer_shared...
2742 (buffer_shared_and_changed): ...near to its real use.
2743
4a9204fe
PE
27442012-11-29 Paul Eggert <eggert@cs.ucla.edu>
2745
2746 * callproc.c (Fcall_process): Don't misreport vfork failure.
2747
60aeceb8
PE
27482012-11-28 Paul Eggert <eggert@cs.ucla.edu>
2749
2750 * callproc.c (Fcall_process): Fix vfork portability problems.
2751 Do not assume that fd[0], count, filefd, and save_environ survive
2752 vfork. Fix bug whereby wrong errno value could be reported for
2753 pipe failure. Some minor cleanups, too, as follows. Move buf and
2754 bufsize to the context where they're needed. Change new_argv to
2755 be of type char **, as this is more convenient and avoids casts.
2756 (CALLPROC_BUFFER_SIZE_MIN, CALLPROC_BUFFER_SIZE_MAX):
2757 Now local constants, not macros.
2758
00dc3ead
KH
27592012-11-18 Kenichi Handa <handa@gnu.org>
2760
2761 * font.c (font_unparse_xlfd): Fix previous change. Keep "const"
2762 for the variable "f".
2763
e1bf05c1
KH
27642012-11-13 Kenichi Handa <handa@gnu.org>
2765
2766 * font.c (font_unparse_xlfd): Exclude special characters from the
2767 generating XLFD name.
2768
22626a85
PE
27692012-11-27 Paul Eggert <eggert@cs.ucla.edu>
2770
350e0088
PE
2771 Assume POSIX 1003.1-1988 or later for grp.h, pwd.h.
2772 * dired.c (stat_uname, stat_gname):
2773 * fileio.c (Fexpand_file_name): Remove no-longer-needed casts.
2774
22626a85
PE
2775 Assume POSIX 1003.1-1988 or later for errno.h (Bug#12968).
2776 * dired.c (directory_files_internal, file_name_completion):
2777 Assume EAGAIN and EINTR are defined.
350e0088 2778
22626a85
PE
2779 * fileio.c (Fcopy_file): Assume EISDIR is defined.
2780 * gmalloc.c (ENOMEM, EINVAL): Assume they're defined.
2781 * gnutls.c (emacs_gnutls_write): Assume EAGAIN is defined.
2782 * lread.c (readbyte_from_file): Assume EINTR is defined.
2783 * process.c (wait_reading_process_output, send_process) [subprocesses]:
2784 Assume EIO and EAGAIN are defined.
2785 * unexcoff.c (write_segment): Assume EFAULT is defined.
2786
5c9cf0a3 27872012-11-27 Eli Zaretskii <eliz@gnu.org>
3fa1e84d
EZ
2788
2789 * fontset.c (Finternal_char_font): Return nil on non-GUI frames.
2790 (Bug#11964)
2791
22294a56
EZ
2792 * xdisp.c (draw_glyphs): Don't draw in mouse face if mouse
2793 highlighting on the frame was cleared. Prevents assertion
2794 violations when repeatedly clicking on the "Top" link of the
2795 "bread-crumbs" in Info buffers.
2796
5fbab051
PE
27972012-11-25 Paul Eggert <eggert@cs.ucla.edu>
2798
2799 * sysdep.c (sys_subshell): Don't assume pid_t fits in int.
2800
bcd77a2b
KB
28012012-11-24 Ken Brown <kbrown@cornell.edu>
2802
2803 * keyboard.c (HAVE_MOUSE):
2804 * frame.c (HAVE_MOUSE): Remove, and rewrite code as if HAVE_MOUSE
2805 were always defined.
2806
d125ca15 28072012-11-24 Eli Zaretskii <eliz@gnu.org>
8654a41b 2808
24becea4
EZ
2809 * xdisp.c (set_cursor_from_row): Skip step 2 only if point is not
2810 between bpos_covered and bpos_max. This fixes cursor display when
2811 several display strings follow each other.
2812
8654a41b
EZ
2813 * .gdbinit (pgx): If the glyph's object is a string, display the
2814 pointer to string data, rather than the value of the string object
2815 itself (which barfs under CHECK_LISP_OBJECT_TYPE).
2816
cb5867b1
EZ
2817 * indent.c (Fvertical_motion): If the starting position is covered
2818 by a display string, return to one position before that, to avoid
2819 overshooting it inside move_it_to. (Bug#12930)
2820
f418b22e
DA
28212012-11-23 Dmitry Antipov <dmantipov@yandex.ru>
2822
2823 * frame.h (struct frame): Remove display_preempted member
2824 since all users are dead long ago.
2825 * nsterm.h (struct x_output): Use the only dummy member.
2826 * w32menu.c (pending_menu_activation): Remove since not
2827 really used.
2828 (set_frame_menubar): Adjust user.
2829 * w32term.h (struct x_output): Drop outdated #if 0 code.
2830 (struct w32_output): Use bitfields for explicit_parent,
26ec1f49
SM
2831 asked_for_visible and menubar_active members.
2832 Drop unused pending_menu_activation member.
f418b22e
DA
2833 * xterm.h (struct x_output): Drop outdated #if 0 code.
2834 Use bitfields for explicit_parent, asked_for_visible,
2835 has_been_visible and net_wm_state_hidden_seen members.
2836
a879f0ea
EZ
28372012-11-23 Eli Zaretskii <eliz@gnu.org>
2838
2839 * makefile.w32-in (globals.h, gl-stamp): Use $(SWITCHCHAR) instead
2840 of a literal "/". (Bug#12955)
2841 (gl-stamp): Invoke fc.exe directly, not through cmd.
2842
95ef7787
PE
28432012-11-23 Paul Eggert <eggert@cs.ucla.edu>
2844
2845 Assume POSIX 1003.1-1988 or later for dirent.h (Bug#12958).
2846 * dired.c: Assume HAVE_DIRENT_H.
2847 (NAMLEN): Remove, replacing with ...
2848 (dirent_namelen): New function. All uses changed. Use the GNU macro
2849 _D_EXACT_NAMELEN if available, as it's faster than strlen.
2850 (DIRENTRY): Remove, replacing all uses with 'struct dirent'.
2851 (DIRENTRY_NONEMPTY): Remove. All callers now assume it's nonzero.
2852 * makefile.w32-in (DIR_H): Remove. All uses replaced with
2853 $(NT_INC)/dirent.h.
2854 ($(BLD)/w32.$(O)): Do not depend on $(SRC)/ndir.h.
2855 * ndir.h: Rename to ../nt/inc/dirent.h.
2856 * sysdep.h (closedir) [!HAVE_CLOSEDIR]: Remove.
2857 Do not include <dirent.h>; no longer needed.
2858 * w32.c: Include <dirent.h> rather than "ndir.h".
2859
12645ae6
CY
28602012-11-23 Chong Yidong <cyd@gnu.org>
2861
2862 * xftfont.c (xftfont_open): Remove duplicate assignment.
2863
5c747675
DA
28642012-11-22 Dmitry Antipov <dmantipov@yandex.ru>
2865
2866 * alloc.c (Fgarbage_collect): Unblock input after clearing
2867 gc_in_progress to avoid note_mouse_highlight glitch with GC.
2868 * frame.h (FRAME_MOUSE_UPDATE): New macro.
2869 * msdos.c (IT_frame_up_to_date): Use it here...
2870 * w32term.c (w32_frame_up_to_date): ...here...
2871 * xterm.c (XTframe_up_to_date): ...and here...
2872 * nsterm.m (ns_frame_up_to_date): ...but not here.
2873 * lisp.h (Mouse_HLInfo): Remove mouse_face_deferred_gc member.
2874 Adjust users.
2875 * xdisp.c (message2_nolog, message3_nolog, note_mouse_highlight):
2876 Do not check whether GC is in progress.
2877
6ceeb5f1
DA
28782012-11-22 Dmitry Antipov <dmantipov@yandex.ru>
2879
2880 * xdisp.c (window_buffer_changed): New function.
2881 (update_menu_bar, update_tool_bar): Use it to
2882 simplify large 'if' statements.
2883 (redisplay_internal): Generalize commonly used
2884 'tail' and 'frame' local variables.
2885
ec84768f
EZ
28862012-11-22 Eli Zaretskii <eliz@gnu.org>
2887
2888 * w32.c (getcwd): Fix the 2nd argument type, to prevent conflicts
2889 with Windows system header.
2890
9239d970
PE
28912012-11-21 Paul Eggert <eggert@cs.ucla.edu>
2892
2893 Assume POSIX 1003.1-1988 or later for unistd.h (Bug#12945).
2894 * alloc.c: Assume unistd.h exists.
2895 * fileio.c (Fexpand_file_name) [DOS_NT]: Use getcwd, not getwd.
2896 * sysdep.c (get_current_dir_name): Assume getcwd exists.
2897 (getwd) [USG]: Remove; no longer needed.
2898 (sys_subshell) [DOS_NT]: Use getcwd, not getwd.
2899 * w32.c (getcwd): Rename from getwd, and switch to getcwd's API.
2900 * w32.h (getcwd): Remove decl.
2901
954bba56
SM
29022012-11-21 Stefan Monnier <monnier@iro.umontreal.ca>
2903
2904 * xdisp.c (fast_set_selected_frame): Rename from update_tool_bar_unwind.
2905 Make it set selected_window as well.
2906 (update_tool_bar): Use it.
2907
6ef2e5ef 29082012-11-21 Ken Brown <kbrown@cornell.edu>
4ffea447
KB
2909
2910 * emacs.c (main): Set the G_SLICE environment variable for all
2911 Cygwin builds, not just GTK builds. See
2912 https://lists.gnu.org/archive/html/emacs-devel/2012-11/msg00368.html.
2913
6ef2e5ef 29142012-11-21 Eli Zaretskii <eliz@gnu.org>
88c4a13c
EZ
2915
2916 * w32.c (FILE_DEVICE_FILE_SYSTEM, METHOD_BUFFERED)
2917 (FILE_ANY_ACCESS, CTL_CODE, FSCTL_GET_REPARSE_POINT) [_MSC_VER]:
2918 Define for the MSVC compiler.
2919
6ef2e5ef 2920 * w32term.h (EnumSystemLocalesW) [_MSC_VER]: Add a missing semi-colon.
273ac8d1
EZ
2921
2922 * fileio.c (Fsubstitute_in_file_name, Ffile_name_directory)
2923 (Fexpand_file_name) [DOS_NT]: Pass encoded file name to
2924 dostounix_filename. Prevents crashes down the road, because
26ec1f49
SM
2925 dostounix_filename assumes it gets a unibyte string.
2926 Reported by Michel de Ruiter <michel@sentient.nl>, see
273ac8d1
EZ
2927 http://lists.gnu.org/archive/html/help-emacs-windows/2012-11/msg00017.html
2928
eadf1faa
SM
29292012-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2930
2931 Conflate Qnil and Qunbound for `symbol-function'.
2932 * alloc.c (Fmake_symbol): Initialize `function' to Qnil.
2933 * lread.c (init_obarray): Set `function' fields to Qnil.
2934 * eval.c (Fcommandp): Ignore Qunbound.
2935 (Fautoload, eval_sub, Fapply, Ffuncall, Fmacroexpand):
2936 * data.c (Ffset, Ffboundp, indirect_function, Findirect_function):
2937 Test NILP rather than Qunbound.
2938 (Ffmakunbound): Set to Qnil.
2939 (Fsymbol_function): Never signal an error.
2940 (Finteractive_form): Ignore Qunbound.
2941
b83fdfa9
PE
29422012-11-20 Paul Eggert <eggert@cs.ucla.edu>
2943
2944 * eval.c (interactive_p): Remove no-longer-used decl.
2945
952580c5
DA
29462012-11-20 Dmitry Antipov <dmantipov@yandex.ru>
2947
2948 * xdisp.c (buffer_shared): Adjust comment.
2949 (buffer_shared_and_changed): New function.
2950 (prepare_menu_bars, redisplay_internal): Use it to
2951 decide whether all windows or frames should be updated.
ea6de9b1
DA
2952 (window_outdated): New function.
2953 (text_outside_line_unchanged_p, redisplay_window): Use it.
2954 (redisplay_internal): Likewise. Fix indentation.
952580c5 2955
23ba2705
SM
29562012-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2957
2958 * eval.c (Finteractive_p, Fcalled_interactively_p, interactive_p): Remove.
2959 (syms_of_eval): Remove corresponding defsubr.
2960 * bytecode.c (exec_byte_code): `interactive-p' is now a Lisp function.
2961
6e9f7997
DC
29622012-11-19 Daniel Colascione <dancol@dancol.org>
2963
2964 * w32fns.c (Fx_file_dialog):
2965 (Fx_file_dialog): Accomodate rename of cygwin_convert_path* to
2966 cygwin_convert_file_name*.
2967
2968 * cygw32.c (Fcygwin_convert_path_to_windows, syms_of_cygw32):
2969 Rename cygwin_convert_path* to cygwin_convert_file_name*.
2970
552a1590
PE
29712012-11-18 Paul Eggert <eggert@cs.ucla.edu>
2972
2973 * nsterm.m (ns_select): Send SIGIO only to self, not to process group.
2974
2ac9538d 29752012-11-18 Eli Zaretskii <eliz@gnu.org>
d8715cdf
EZ
2976
2977 * w32select.c: Include w32common.h before w32term.h, so that
2978 windows.h gets included before w32term.h uses some of its
2979 features, see below.
2980
23ba2705
SM
2981 * w32term.h (LOCALE_ENUMPROCA, LOCALE_ENUMPROCW) [_MSC_VER]:
2982 New typedefs.
2983 (EnumSystemLocalesA, EnumSystemLocalesW) [_MSC_VER]:
2984 New prototypes.
d8715cdf
EZ
2985 (EnumSystemLocales) [_MSC_VER]: Define if undefined. (Bug#12878)
2986
2ac9538d 29872012-11-18 Jan Djärv <jan.h.d@swipnet.se>
7436fc63
JD
2988
2989 * nsterm.m (hold_event): Set send_appdefined to YES (Bug#12834).
2990 (ns_select): Return at once if events are held (Bug#12834).
2991
2ac9538d 29922012-11-18 enami tsugutomo <tsugutomo.enami@jp.sony.com>
86dcf21c 2993
2994 * unexelf.c (ELFSIZE) [__NetBSD__ && _LP64]: Set to 64.
2995 Needed following 2012-10-20 change. (Bug#12902)
2996
c1f7ba3a
JB
29972012-11-18 Juanma Barranquero <lekktu@gmail.com>
2998
2999 * w32proc.c (waitpid): Remove unused label get_result.
3000
a75ce9d3
JB
30012012-11-17 Juanma Barranquero <lekktu@gmail.com>
3002
3003 * makefile.w32-in (SYSWAIT_H): New macro.
3004 ($(BLD)/callproc.$(O), $(BLD)/w32proc.$(O), $(BLD)/process.$(O))
3005 ($(BLD)/sysdep.$(O)): Update dependencies.
3006
49cdacda
PE
30072012-11-17 Paul Eggert <eggert@cs.ucla.edu>
3008
3009 Assume POSIX 1003.1-1988 or later for fcntl.h (Bug#12881).
3010 * callproc.c (relocate_fd): Assume F_DUPFD.
3011 * emacs.c, term.c (O_RDWR): Remove.
3012 * keyboard.c (tty_read_avail_input): Use O_NONBLOCK rather than
3013 O_NDELAY, since O_NONBLOCK is the standard name for this flag.
3014 * nsterm.m: Assume <fcntl.h> exists.
3015 * process.c (NON_BLOCKING_CONNECT, allocate_pty, create_process)
3016 (create_pty, Fmake_network_process, server_accept_connection)
3017 (wait_reading_process_output, init_process_emacs):
3018 Assume O_NONBLOCK.
3019 (wait_reading_process_output): Put in a special case for WINDOWSNT
3020 to mimick the older behavior where it had O_NDELAY but not O_NONBLOCK.
3021 It's not clear this is needed, but it's a more-conservative change.
3022 (create_process): Assume FD_CLOEXEC.
3023 (create_process, create_pty): Assume O_NOCTTY.
3024 * sysdep.c (init_sys_modes, reset_sys_modes): Assume F_SETFL.
3025 (reset_sys_modes): Use O_NONBLOCK rather than O_NDELAY.
3026 Omit if not DOS_NT, since F_GETFL is not defined there.
3027 (serial_open): Assume O_NONBLOCK and O_NOCTTY.
3028 * term.c: Include <fcntl.h>, for flags like O_NOCTTY.
3029 (O_NOCTTY): Remove.
3030 (init_tty): Assume O_IGNORE_CTTY is defined to 0 on platforms that
3031 lack it, since gnulib guarantees this.
3032 * w32.c (fcntl): Test for O_NONBLOCK rather than O_NDELAY.
3033
22bae83f
EZ
30342012-11-17 Eli Zaretskii <eliz@gnu.org>
3035
6ad30855
EZ
3036 * w32.c (faccessat): Pretend that directories have the execute bit
3037 set. Emacs expects that, e.g., in files.el:cd-absolute.
3038
22bae83f
EZ
3039 * w32proc.c (create_child): Don't clip the PID of the child
3040 process to fit into an Emacs integer, as this is no longer a
3041 restriction.
3042 (waitpid): Rename from sys_wait. Emulate a Posix 'waitpid' by
3043 reaping only the process specified by PID argument, if that is
3044 positive. Use PID instead of dead_child to know which process to
3045 reap. Wait for the child to die only if WNOHANG is not in
3046 OPTIONS.
3047 (sys_select): Don't set dead_child.
3048
3049 * sysdep.c (wait_for_termination_1): Remove the WINDOWSNT portion,
3050 as it is no longer needed.
3051
3052 * process.c (waitpid, WUNTRACED) [!WNOHANG]: Remove definitions,
3053 no longer needed.
3054 (record_child_status_change): Remove the setting of
3055 record_at_most_one_child for the !WNOHANG case.
3056
a631d0e0
PE
30572012-11-17 Paul Eggert <eggert@cs.ucla.edu>
3058
3059 Fix problems in ns port found by static checking.
3060 * nsterm.m: Include <pthread.h>, for pthread_mutex_lock etc.
3061 (hold_event, setPosition:portion:whole:): Send SIGIO only to self,
3062 not to process group.
3063 (ns_select): Use emacs_write, not write, as that's more robust
3064 in the presence of signals.
3065 (fd_handler:): Check for read errors.
3066
d56f2e49
GM
30672012-11-16 Glenn Morris <rgm@gnu.org>
3068
3069 * editfns.c (Fmessage): Mention message-log-max. (Bug#12849)
3070
96e05507 30712012-11-16 Stefan Monnier <monnier@iro.umontreal.ca>
5c2a7148
SM
3072
3073 * eval.c (Finteractive_p): Revert lexbind-merge mishap.
3074
96e05507 30752012-11-16 Eli Zaretskii <eliz@gnu.org>
730b2d8f
EZ
3076
3077 * w32proc.c (timer_loop): Make sure SuspendThread and ResumeThread
3078 use the same value of thread handle.
3079 (start_timer_thread): If the timer thread exited (due to error),
3080 clean up by closing the two handles it used. Duplicate the caller
3081 thread's handle here, so it gets duplicated only once, when
3082 launching the timer thread. Set priority of the timer thread, not
3083 the caller thread.
3084 (getitimer): Don't duplicate the caller thread's handle here.
3085 (Bug#12832)
3086
96e05507 30872012-11-16 Jan Djärv <jan.h.d@swipnet.se>
f99c65e5
JD
3088
3089 * nsterm.m (hold_event): Send SIGIO to make sure ns_read_socket is
3090 called (Bug#12834).
3091
3d082a26
PE
30922012-11-16 Paul Eggert <eggert@cs.ucla.edu>
3093
3094 Remove no-longer-used pty_max_bytes variable.
3095 * process.c (pty_max_bytes): Remove; unused.
3096 (send_process): Do not set it.
3097
b72c161c
JB
30982012-11-15 Juanma Barranquero <lekktu@gmail.com>
3099
3100 * makefile.w32-in ($(BLD)/dispnew.$(O), $(BLD)/emacs.$(O)):
3101 Update dependencies.
3102
bf20ea80
PE
31032012-11-15 Paul Eggert <eggert@cs.ucla.edu>
3104
3105 * eval.c (mark_backtrace) [BYTE_MARK_STACK]: Remove stray '*'.
3106 This follows up on the 2012-09-29 patch that removed indirection
3107 for the 'function' field. Reported by Sergey Vinokurov in
3108 <http://lists.gnu.org/archive/html/emacs-devel/2012-11/msg00263.html>.
3109
14f20728
EZ
31102012-11-14 Eli Zaretskii <eliz@gnu.org>
3111
3112 * w32.c (faccessat): Rename from sys_faccessat. (No need to use a
3113 different name, as the MS runtime does not have such a function,
3114 and probably never will.) All callers changed. Ignore DIRFD
3115 value if PATH is an absolute file name, to match Posix spec
3116 better. If AT_SYMLINK_NOFOLLOW is set in FLAGS, don't resolve
3117 symlinks.
3118
77731919
DA
31192012-11-14 Dmitry Antipov <dmantipov@yandex.ru>
3120
3121 * xdisp.c (echo_area_display, redisplay_internal):
3122 Omit redundant check whether frame_garbaged is set.
3123
73dcdb9f
PE
31242012-11-14 Paul Eggert <eggert@cs.ucla.edu>
3125
3126 Use faccessat, not access, when checking file permissions (Bug#12632).
3127 This fixes a bug that has been present in Emacs since its creation.
3128 It was reported by Chris Torek in 1983 even before GNU Emacs existed,
3129 which must set some sort of record. (Torek's bug report was against
3130 a predecessor of GNU Emacs, but GNU Emacs happened to have the
3131 same common flaw.) See Torek's Usenet posting
3132 "setuid/setgid programs & Emacs" Article-I.D.: sri-arpa.858
3133 Posted: Fri Apr 8 14:18:56 1983.
3134 * Makefile.in (LIB_EACCESS): New macro.
3135 (LIBES): Use it.
3136 * callproc.c (init_callproc):
3137 * charset.c (init_charset):
3138 * fileio.c (check_existing, check_executable, check_writable)
3139 (Ffile_readable_p):
3140 * lread.c (openp, load_path_check):
3141 * process.c (allocate_pty):
3142 * xrdb.c (file_p):
3143 Use effective UID when checking permissions, not real UID.
3144 * callproc.c (init_callproc):
3145 * charset.c (init_charset):
3146 * lread.c (load_path_check, init_lread):
3147 Test whether directories are accessible, not merely whether they exist.
3148 * conf_post.h (GNULIB_SUPPORT_ONLY_AT_FDCWD): New macro.
3149 * fileio.c (check_existing, check_executable, check_writable)
3150 (Ffile_readable_p):
3151 Use symbolic names instead of integers for the flags, as they're
3152 portable now.
3153 (check_writable): New arg AMODE. All uses changed.
3154 Set errno on failure.
3155 (Ffile_readable_p): Use faccessat, not stat + open + close.
3156 (Ffile_writable_p): No need to call check_existing + check_writable.
3157 Just call check_writable and then look at errno. This saves a syscall.
3158 dir should never be nil; replace an unnecessary runtime check
3159 with an eassert. When checking the parent directory of a nonexistent
3160 file, check that the directory is searchable as well as writable, as
3161 we can't create files in unsearchable directories.
3162 (file_directory_p): New function, which uses 'stat' on most platforms
3163 but faccessat with D_OK (for efficiency) if WINDOWSNT.
3164 (Ffile_directory_p, Fset_file_times): Use it.
3165 (file_accessible_directory_p): New function, which uses a single
3166 syscall for efficiency.
3167 (Ffile_accessible_directory_p): Use it.
3168 * xrdb.c (file_p): Use file_directory_p.
3169 * lisp.h (file_directory_p, file_accessible_directory_p): New decls.
3170 * lread.c (openp): When opening a file, use fstat rather than
3171 stat, as that avoids a permissions race. When not opening a file,
3172 use file_directory_p rather than stat.
3173 (dir_warning): First arg is now a usage string, not a format.
3174 Use errno. All uses changed.
3175 * nsterm.m (ns_term_init): Remove unnecessary call to file-readable
3176 that merely introduced a race.
3177 * process.c, sysdep.c, term.c: All uses of '#ifdef O_NONBLOCK'
3178 changed to '#if O_NONBLOCK', to accommodate gnulib O_* style,
3179 and similarly for the other O_* flags.
3180 * w32.c (sys_faccessat): Rename from sys_access and switch to
3181 faccessat's API. All uses changed.
3182 * xrdb.c: Do not include <sys/stat.h>; no longer needed.
3183 (magic_db): Rename from magic_file_p.
3184 (magic_db, search_magic_path): Return an XrmDatabase rather than a
3185 char *, so that we don't have to test for file existence
3186 separately from opening the file for reading. This removes a race
3187 fixes a permission-checking problem, and simplifies the code.
3188 All uses changed.
3189 (file_p): Remove; no longer needed.
3190
2a14f83b
DA
31912012-11-13 Dmitry Antipov <dmantipov@yandex.ru>
3192
3193 Omit glyphs initialization at startup.
3194 * dispnew.c (glyphs_initialized_initially_p): Remove.
3195 (adjust_frame_glyphs_initially): Likewise. Adjust users.
3196 (Fredraw_frame): Move actual code from here...
c7085245 3197 (redraw_frame): ...to here. Add eassert. Adjust comment.
2a14f83b
DA
3198 (Fredraw_display): Use redraw_frame.
3199 * xdisp.c (clear_garbaged_frames): Likewise.
3200
f78ee6af 32012012-11-13 Eli Zaretskii <eliz@gnu.org>
32520273
EZ
3202
3203 * xdisp.c (decode_mode_spec): Limit the value of WIDTH argument
3204 passed to pint2str and pint2hrstr to be at most the size of the
3205 frame's decode_mode_spec_buffer. This avoids crashes with very
3206 large values of FIELD_WIDTH argument to decode_mode_spec.
3207 (Bug#12867)
3208
b95a9c0c
PE
32092012-11-13 Paul Eggert <eggert@cs.ucla.edu>
3210
3211 Fix a race with verify-visited-file-modtime (Bug#12863).
3212 Since at least 1991 Emacs has ignored an mtime difference of no
3213 more than one second, but my guess is that this was to work around
3214 file system bugs that were fixed long ago. Since the race is
3215 causing problems now, let's remove that code.
3216 * fileio.c (Fverify_visited_file_modtime): Do not accept a file
3217 whose time stamp is off by no more than a second. Insist that the
3218 file time stamps match exactly.
3219
be49ba74
DA
32202012-11-12 Dmitry Antipov <dmantipov@yandex.ru>
3221
3222 * frame.h (struct frame): Convert external_tool_bar member to
3223 1-bit unsigned bitfield.
3224 * termhooks.h (struct terminal): Remove mouse_moved member since
3225 all users are long dead. Adjust comment on mouse_position_hook.
3226
5b04e9f9
DA
32272012-11-12 Dmitry Antipov <dmantipov@yandex.ru>
3228
3229 Simplify by using FOR_EACH_FRAME here and there.
3230 * frame.c (next_frame, prev_frame, other_visible_frames)
3231 (delete_frame, visible-frame-list): Use FOR_EACH_FRAME.
3232 * w32term.c (x_window_to_scroll_bar): Likewise.
3233 * window.c (window_list): Likewise.
3234 * xdisp.c (x_consider_frame_title): Likewise.
3235 * xfaces.c ( Fdisplay_supports_face_attributes_p): Likewise.
3236 * xfns.c (x_window_to_frame, x_any_window_to_frame)
3237 (x_menubar_window_to_frame, x_top_window_to_frame): Likewise.
3238 * xmenu.c (menubar_id_to_frame): Likewise.
3239 * xselect.c (frame_for_x_selection): Likewise.
3240 * xterm.c (x_frame_of_widget, x_window_to_scroll_bar)
3241 (x_window_to_menu_bar): Likewise.
3242 * w32fns.c (x_window_to_frame): Likewise. Adjust comment.
3243
76ae24d7
PE
32442012-11-12 Paul Eggert <eggert@cs.ucla.edu>
3245
12cc4337
PE
3246 * data.c (Qdefalias_fset_function): Now static.
3247
76ae24d7
PE
3248 Another tweak to vectorlike_header change.
3249 * alloc.c (struct Lisp_Vectorlike_Free, NEXT_IN_FREE_LIST):
3250 Remove, and replace all uses with ...
3251 (next_in_free_list, set_next_in_free_list):
3252 New functions, which respect C's aliasing rules better.
3253
1479c557
PE
32542012-11-11 Paul Eggert <eggert@cs.ucla.edu>
3255
3256 * window.c (list4i): Rename from 'quad'. All uses changed.
3257 Needed because <sys/types.h> defines 'quad' on Solaris 10.
3258
11235c03
JB
32592012-11-11 Juanma Barranquero <lekktu@gmail.com>
3260
3261 * xdisp.c (start_hourglass) [HAVE_NTGUI]: Add block to silence
3262 warning about mixing declarations and code in ISO C90.
3263
6baf66d5 32642012-11-10 Martin Rudalics <rudalics@gmx.at>
fdaf534a
MR
3265
3266 * window.c (Fsplit_window_internal): Set combination limit of
3267 new parent window to t iff Vwindow_combination_limit is t;
3268 fixing a regression introduced with the change from 2012-09-22.
6baf66d5 3269 (Fset_window_combination_limit): Fix doc-string.
fdaf534a 3270
6baf66d5 32712012-11-10 Eli Zaretskii <eliz@gnu.org>
acf93bcf
EZ
3272
3273 * xdisp.c (try_scrolling): Fix correction of aggressive-scroll
3274 amount when the scroll margins are too large. When scrolling
3275 backwards in the buffer, give up if cannot reach point or the
23ba2705
SM
3276 scroll margin within a reasonable number of screen lines.
3277 Fixes point position in window under scroll-up/down-aggressively when
acf93bcf
EZ
3278 point is positioned many lines beyond the window top/bottom.
3279 (Bug#12811)
3280
508f51f5
EZ
3281 * ralloc.c (relinquish): If real_morecore fails to return memory
3282 to the system, don't crash; instead, leave the last heap
3283 unchanged and return. (Bug#12774)
3284
32e5c58c
SM
32852012-11-09 Stefan Monnier <monnier@iro.umontreal.ca>
3286
3287 * lisp.h (AUTOLOADP): New macro.
3288 * eval.c (Fautoload): Don't attach to loadhist, call Fdefalias instead.
3289 * data.c (Ffset): Remove special ad-advice-info handling.
3290 (Fdefalias): Handle autoload definitions and new Qdefalias_fset_function.
3291 (Fsubr_arity): CSE.
3292 (Finteractive_form): Simplify.
3293 (Fquo): Don't insist on having at least 2 arguments.
3294 (Qdefalias_fset_function): New var.
3295
719b0aa5
JD
32962012-11-09 Jan Djärv <jan.h.d@swipnet.se>
3297
4ab15c3e
JD
3298 * image.c (xpm_make_color_table_h): Change to hashtest_equal.
3299
719b0aa5
JD
3300 * nsfont.m (Qcondensed, Qexpanded): New variables.
3301 (ns_descriptor_to_entity): Restore Qcondensed, Qexpanded setting.
3302 (syms_of_nsfont): Defsym Qcondensed, Qexpanded.
3303
535cc8e9
DA
33042012-11-09 Dmitry Antipov <dmantipov@yandex.ru>
3305
3306 Fix recently introduced crash on MS-Windows (Bug#12839).
3307 * w32term.h (struct scroll_bar): Use convenient header.
3308 (SCROLL_BAR_VEC_SIZE): Remove.
3309 * w32term.c (x_scroll_bar_create): Use VECSIZE.
3310
7d377c48
DA
33112012-11-09 Dmitry Antipov <dmantipov@yandex.ru>
3312
3313 Tweak last vectorlike_header change.
3314 * alloc.c (struct Lisp_Vectorlike_Free): Special type to represent
3315 vectorlike object on the free list. This is introduced to avoid
3316 some (but not all) pointer casting and aliasing problems, see
3317 http://lists.gnu.org/archive/html/emacs-devel/2012-11/msg00105.html.
3318 * .gdbinit (pvectype, pvecsize): New commands to examine vectorlike
3319 objects.
3320 (xvectype, xvecsize): Use them to examine Lisp_Object values.
3321
7ad27466
JD
33222012-11-09 Jan Djärv <jan.h.d@swipnet.se>
3323
32e5c58c 3324 * nsfont.m (ns_descriptor_to_entity): Qcondensed and Qexpanded has
7ad27466
JD
3325 been removed, so remove them here also.
3326
57618ecf
SM
33272012-11-09 Stefan Monnier <monnier@iro.umontreal.ca>
3328
3329 * doc.c (Fdocumentation): Handle new property
3330 dynamic-docstring-function to replace the old ad-advice-info.
3331
53371430
PE
33322012-11-09 Paul Eggert <eggert@cs.ucla.edu>
3333
3334 * fns.c (Qeql, hashtest_eq): Now static.
3335
61ddb1b9
SM
33362012-11-08 Stefan Monnier <monnier@iro.umontreal.ca>
3337
3338 * lisp.h (XHASH): Redefine to be imperfect and fit in a Lisp int.
3339 * fns.c (hashfn_eq, hashfn_eql, sxhash):
3340 * profiler.c (hashfn_profiler): Don't use XUINT on non-integers.
3341 * buffer.c (compare_overlays): Use XLI rather than XHASH.
3342
04a2d0d3
PE
33432012-11-08 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 Use same hash function for hashfn_profiler as for hash_string etc.
3346 * fns.c (SXHASH_COMBINE): Remove. All uses replaced by sxhash_combine.
3347 * lisp.h (sxhash_combine): New inline function, with the contents
3348 of the old SXHASH_COMBINE.
3349 * profiler.c (hashfn_profiler): Use it, instead of having a
3350 special hash function containing a comparison that always yields 1.
3351
de5ef41a
SM
33522012-11-08 Stefan Monnier <monnier@iro.umontreal.ca>
3353
3354 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic)
3355 (Qultra_condensed, Qextra_condensed, Qcondensed, Qsemi_condensed)
3356 (Qsemi_expanded, Qextra_expanded, Qexpanded, Qultra_expanded):
3357 Remove unused vars.
3358
a23c4171
JD
33592012-11-08 Jan Djärv <jan.h.d@swipnet.se>
3360
3361 * image.c (xpm_make_color_table_h): Fix compiler error because
3362 make_hash_table changed.
3363
0b59090b 33642012-11-08 Thomas Kappler <tkappler@gmail.com> (tiny change)
074d7bb0
JD
3365
3366 * nsfont.m (ns_findfonts): Handle empty matchingDescs (Bug#11541).
3367
b7432bb2
SM
33682012-11-08 Stefan Monnier <monnier@iro.umontreal.ca>
3369
3370 Use ad-hoc comparison function for the profiler's hash-tables.
3371 * profiler.c (Qprofiler_backtrace_equal, hashtest_profiler): New vars.
3372 (make_log): Use them.
3373 (handle_profiler_signal): Don't inhibit quit any longer since we don't
3374 call Fequal any more.
3375 (Ffunction_equal): New function.
3376 (cmpfn_profiler, hashfn_profiler): New functions.
3377 (syms_of_profiler): Initialize them.
3378 * lisp.h (struct hash_table_test): New struct.
3379 (struct Lisp_Hash_Table): Use it.
3380 * alloc.c (mark_object): Mark hash_table_test fields of hash tables.
3381 * fns.c (make_hash_table): Take a struct to describe the test.
3382 (cmpfn_eql, cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3383 (hashfn_equal, hashfn_user_defined): Adjust to new calling convention.
3384 (hash_lookup, hash_remove_from_table): Move assertion checking of
3385 hashfn result here. Check hash-equality before calling cmpfn.
3386 (Fmake_hash_table): Adjust call to make_hash_table.
3387 (hashtest_eq, hashtest_eql, hashtest_equal): New structs.
3388 (syms_of_fns): Initialize them.
3389 * emacs.c (main): Move syms_of_fns earlier.
3390 * xterm.c (syms_of_xterm):
3391 * category.c (hash_get_category_set): Adjust call to make_hash_table.
3392 * print.c (print_object): Adjust to new hash-table struct.
3393 * composite.c (composition_gstring_put_cache): Adjust to new hashfn.
3394
88002743
EZ
33952012-11-08 Eli Zaretskii <eliz@gnu.org>
3396
3397 * w32fns.c (modifier_set): Fix handling of Scroll Lock when the
3398 value of w32-scroll-lock-modifier is neither nil nor one of the
3399 known key modifiers. (Bug#12806)
3400
914adc42
DA
34012012-11-08 Dmitry Antipov <dmantipov@yandex.ru>
3402
3403 Shrink struct vectorlike_header to the only size field.
3404 * lisp.h (enum pvec_type): Avoid explicit enum member values.
3405 Adjust comment.
3406 (enum More_Lisp_Bits): Change PSEUDOVECTOR_SIZE_BITS and
3407 PVEC_TYPE_MASK to arrange new bitfield in the vector header.
3408 (PSEUDOVECTOR_REST_BITS, PSEUDOVECTOR_REST_MASK): New members.
3409 (PSEUDOVECTOR_AREA_BITS): New member used to extract subtype
3410 information from the vector header. Adjust comment.
3411 (XSETPVECTYPE, XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR)
3412 (PSEUDOVECTOR_TYPEP, DEFUN): Adjust to match new vector header
3413 layout.
3414 (XSETSUBR, SUBRP): Adjust to match new Lisp_Subr layout.
3415 (struct vectorlike_header): Remove next member. Adjust comment.
3416 (struct Lisp_Subr): Add convenient header. Adjust comment.
3417 (allocate_pseudovector): Adjust prototype.
3418 * alloc.c (mark_glyph_matrix, mark_face_cache, allocate_string)
3419 (sweep_string, lisp_malloc): Remove useless prototypes.
3420 (enum mem_type): Adjust comment.
3421 (NEXT_IN_FREE_LIST): New macro.
3422 (SETUP_ON_FREE_LIST): Adjust XSETPVECTYPESIZE usage.
3423 (Fmake_bool_vector): Likewise.
3424 (struct large_vector): New type to represent allocation unit for
3425 the vectors with the memory footprint more than VBLOOCK_BYTES_MAX.
3426 (large_vectors): Change type to struct large_vector.
3427 (allocate_vector_from_block): Simplify.
3428 (PSEUDOVECTOR_NBYTES): Replace with...
3429 (vector_nbytes): ...new function. Adjust users.
3430 (sweep_vectors): Adjust processing of large vectors.
3431 (allocate_vectorlike): Likewise.
3432 (allocate_pseudovector): Change type of 3rd arg to enum pvec_type.
3433 Add easserts. Adjust XSETPVECTYPESIZE usage.
3434 (allocate_buffer): Use BUFFER_PVEC_INIT.
3435 (live_vector_p): Adjust to match large vector.
3436 * buffer.c (init_buffer_once): Use BUFFER_PVEC_INIT.
3437 * buffer.h (struct buffer): Add next member.
3438 (BUFFER_LISP_SIZE, BUFFER_REST_SIZE, BUFFER_PVEC_INIT):
3439 New macros.
3440 (FOR_EACH_BUFFER): Adjust to match struct buffer change.
3441 * fns.c (internal_equal): Adjust to match enum pvec_type change.
3442 (copy_hash_table): Adjust to match vector header change.
3443 * lread.c (defsubr): Use XSETPVECTYPE.
3444 * .gdbinit (xpr, xbacktrace): Adjust to match vector header change.
3445 (xvectype): Likewise. Print PVEC_NORMAL_VECTOR for regular vectors.
3446 (xvecsize): New command.
3447
c66f21ea
DA
34482012-11-08 Dmitry Antipov <dmantipov@yandex.ru>
3449
3450 * keyboard.c (event_to_kboard): Do not dereference
3451 frame_or_window field of SELECTION_REQUEST_EVENT
3452 and SELECTION_CLEAR_EVENT events (Bug#12814).
3453 * xterm.h (struct selection_input_event): Adjust comment.
3454
eb147960
EZ
34552012-11-07 Eli Zaretskii <eliz@gnu.org>
3456
dab72075
EZ
3457 * w32fns.c (modifier_set): Don't report modifiers from toggle key,
3458 such as Scroll Lock, if the respective keys are treated as
3459 function keys, not as modifiers. This avoids destroying non-ASCII
6b064c16 3460 keyboard input when Scroll Lock is toggled ON. (Bug#12806)
eb147960 3461
5890e400
DA
34622012-11-07 Dmitry Antipov <dmantipov@yandex.ru>
3463
3464 * xfns.c (Fx_wm_set_size_hint): Use check_x_frame. Adjust docstring.
3465
b6b3b294
PE
34662012-11-06 Paul Eggert <eggert@cs.ucla.edu>
3467
3468 Restore some duplicate definitions (Bug#12814).
3469 This undoes part of the 2012-11-03 changes. Some people build
3470 with plain -g rather than with -g3, and they need the duplicate
3471 definitions for .gdbinit to work; see <http://bugs.gnu.org/12814#26>.
3472 * lisp.h (GCTYPEBITS, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK):
3473 Define as macros, as well as as enums or as constants.
3474
e770aad5
JD
34752012-11-06 Jan Djärv <jan.h.d@swipnet.se>
3476
3477 * nsterm.m (convert_ns_to_X_keysym, keyDown:): Add NSNumericPadKeyMask
3478 to keypad keys (Bug#12816).
3479
68f8f1c0
PE
34802012-11-06 Paul Eggert <eggert@cs.ucla.edu>
3481
3482 Minor adjustments of recently-changed frame functions.
3483 * buffer.c (Fbuffer_list): Omit CHECK_FRAME, since arg is already
3484 known to be a frame (we're in the FRAMEP branch).
3485 * lisp.h (Qframep): Remove decl. frame.h declares this.
3486 * window.c (quad): Args are of type EMACS_INT, not ptrdiff_t,
3487 since they're meant for Lisp fixnum values.
3488
72f94d4b
DA
34892012-11-06 Dmitry Antipov <dmantipov@yandex.ru>
3490
3491 * window.c (Fwindow_combination_limit): Revert to the only
3492 required argument and adjust docstring as suggested in
3493 http://lists.gnu.org/archive/html/emacs-diffs/2012-11/msg01082.html
3494 by Martin Rudalics <rudalics@gmx.at>.
3495
d9f07150
DA
34962012-11-06 Dmitry Antipov <dmantipov@yandex.ru>
3497
3498 Widely used frame validity and checking functions.
3499 * frame.h (decode_live_frame, decode_any_frame): Add prototypes.
3500 * frame.c (decode_live_frame, decode_any_frame): New functions.
3501 (delete_frame, Fredirect_frame_focus, Fframe_parameters)
3502 (Fframe_parameter, Fframe_char_height, Fframe_char_width)
3503 (Fframe_pixel_height, Fframe_pixel_width, Ftool_bar_pixel_width)
3504 (Fframe_pointer_visible_p): Use decode_any_frame.
3505 (Fmake_frame_visible, Fmake_frame_invisible, Ficonify_frame)
3506 (Fraise_frame, Flower_frame, Fmodify_frame_parameters)
3507 (Fset_frame_height, Fset_frame_width): Use decode_live_frame.
3508 (Fframe_focus): Likewise. Allow zero number of arguments.
3509 Adjust docstring.
3510 (frame_buffer_list, frame_buffer_predicate): Remove.
3511 * lisp.h (frame_buffer_predicate): Remove prototype.
3512 * buffer.c (Fother_buffer): Use decode_any_frame.
3513 * xdisp.c (Ftool_bar_lines_needed): Likewise.
3514 * xfaces.c (Fcolor_gray_p, Fcolor_supported_p): Likewise.
3515 * font.c (Ffont_face_attributes, Ffont_family_list, Fopen_font)
3516 (Fclose_font, Ffont_info): Use decode_live_frame.
3517 * fontset.c (check_fontset_name): Likewise.
3518 * terminal.c (Fframe_terminal): Likewise.
3519 * w32fns.c (check_x_frame): Likewise.
3520 * window.c (Fminibuffer_window, Fwindow_at)
3521 (Fcurrent_window_configuration): Likewise.
3522 (Frun_window_configuration_change_hook, Fwindow_resize_apply):
3523 Likewise. Allow zero number of arguments. Adjust docstring.
3524 * dispnew.c (Fredraw_frame): Likewise.
3525 * xfaces.c (frame_or_selected_frame): Remove.
3526 (Fx_list_fonts, Finternal_get_lisp_face_attribute, Fface_font)
3527 (Finternal_lisp_face_equal_p, Finternal_lisp_face_empty_p)
3528 (Fframe_face_alist): Use decode_live_frame.
3529 * xfns.c (check_x_frame): Likewise.
3530
89bc0592
DA
35312012-11-06 Dmitry Antipov <dmantipov@yandex.ru>
3532
3533 * window.c (quad): New function.
3534 (Fwindow_edges, Fwindow_pixel_edges, Fwindow_inside_edges)
3535 (Fwindow_absolute_pixel_edges, Fwindow_inside_absolute_pixel_edges)
3536 (Fwindow_inside_pixel_edges, Fpos_visible_in_window_p)
3537 (Fwindow_line_height): Use it.
3538 (Fwindow_fringes): Use list3.
3539 (Fwindow_scroll_bars): Use list4.
3540 (Fwindow_frame, Fwindow_top_child, Fwindow_left_child)
3541 (Fwindow_combination_limit): Allow zero number of arguments.
3542
c8e3a9c3
EZ
35432012-11-05 Eli Zaretskii <eliz@gnu.org>
3544
3545 * makefile.w32-in ($(BLD)/w32fns.$(O)): Depend on $(NT_INC)/unistd.h.
3546
8e2417bf 3547 * w32fns.c: Include unistd.h, to avoid compiler warnings on Cygwin.
c8e3a9c3 3548 (emacs_abort) [CYGWIN]: Don't call _open_osfhandle; instead, use
ae600a8e 3549 file descriptor 2 for standard error. (Bug#12805)
c8e3a9c3 3550
209c6a58
CY
35512012-11-05 Chong Yidong <cyd@gnu.org>
3552
3553 * process.c (wait_reading_process_output): Revert previous change.
3554
8148369c
PE
35552012-11-05 Paul Eggert <eggert@cs.ucla.edu>
3556
dd0333b6
PE
3557 Assume at least POSIX.1-1988 for getpgrp, setpgid, setsid (Bug#12800).
3558 This removes code that has been obsolete since around 1990.
3559 * callproc.c (Fcall_process):
3560 * emacs.c (main):
3561 * process.c (create_process):
3562 * term.c (dissociate_if_controlling_tty):
3563 Assume setsid exists.
3564 * callproc.c (child_setup): Assume setpgid exists and behaves as
3565 per POSIX.1-1988 or later.
3566 * conf_post.h (setpgid) [!HAVE_SETPGID]: Remove.
3567 * emacs.c (shut_down_emacs):
3568 * sysdep.c (sys_suspend, init_foreground_group):
3569 Assume getpgrp behaves as per POSIX.1-1998 or later.
3570 * msdos.c (setpgrp): Remove.
3571 (tcgetpgrp, setpgid, setsid): New functions.
3572 * systty.h (EMACS_GETPGRP): Remove. All callers now use getpgrp.
3573 * term.c (no_controlling_tty): Remove; unused.
3574 * w32proc.c (setpgrp): Remove.
3575 (setsid, tcgetpgrp): New functions.
3576
8148369c
PE
3577 Simplify by assuming __fpending.
3578 * dispnew.c: Include <fpending.h>, not <stdio_ext.h>.
3579 (update_frame_1): Use __fpending, not PENDING_OUTPUT_COUNT.
3580 Do not assume that __fpending's result fits in int.
3581
76abf5e5
PE
35822012-11-04 Paul Eggert <eggert@cs.ucla.edu>
3583
06b63c9b
PE
3584 Remove EMACS_OUTQSIZE+sleep hack.
3585 * dispnew.c (update_frame_1): Remove hack for terminals slower
de5ef41a
SM
3586 than 2400 bps, which throttled Emacs by having it sleep.
3587 This code hasn't worked since at least 2007, when the multi-tty stuff
06b63c9b
PE
3588 was added, and anyway those old terminals are long dead.
3589 * systty.h (EMACS_OUTQSIZE): Remove; unused. The macro isn't used even
3590 without the dispnew.c change, as dispnew.c doesn't include systty.h.
3591
76abf5e5
PE
3592 Fix data-loss with --version (Bug#9574).
3593 * emacs.c (close_output_streams): Use strerror, not emacs_strerror,
3594 as we can't assume that emacs_strerror is initialized, and strerror
3595 is good enough here.
3596 (main): Invoke atexit earlier, to catch earlier instances of
3597 sending data to stdout and exiting, e.g., "emacs --version >/dev/full".
3598
8f31e74b
MM
35992012-11-04 Michael Marchionna <tralfaz@pacbell.net>
3600
3601 * nsterm.m: Add NSClearLineFunctionKey and keypad keys (Bug#8680).
3602 (keyDown): Remap keypad keys to X11 virtual key codes.
3603
0d879dca
PE
36042012-11-03 Paul Eggert <eggert@cs.ucla.edu>
3605
7ccfb720
PE
3606 Fix data-loss with --batch (Bug#9574).
3607 * emacs.c: Include <close-stream.h>.
3608 (close_output_streams): New function.
3609 (main): Pass it to atexit, so that Emacs closes stdout and stderr
3610 and handles errors appropriately.
3611 (Fkill_emacs): Don't worry about flushing, as close_output_stream
3612 does that now.
3613
0b3d4a47
PE
3614 Fix a race condition that causes Emacs to mess up glib (Bug#8855).
3615 The symptom is a diagnostic "GLib-WARNING **: In call to
3616 g_spawn_sync(), exit status of a child process was requested but
3617 SIGCHLD action was set to SIG_IGN and ECHILD was received by
3618 waitpid(), so exit status can't be returned." The diagnostic
3619 is partly wrong, as the SIGCHLD action is not set to SIG_IGN.
3620 The real bug is a race condition between Emacs and glib: Emacs
3621 does a waitpid (-1, ...) and reaps glib's subprocess by mistake,
3622 so that glib can't find it. Work around the bug by invoking
3623 waitpid only on subprocesses that Emacs itself creates.
3624 * process.c (create_process, record_child_status_change):
3625 Don't use special value -1 in pid field, as the caller now must
de5ef41a
SM
3626 know the pid rather than having the callee infer it.
3627 The inference was sometimes incorrect anyway, due to another race.
0b3d4a47
PE
3628 (create_process): Set new 'alive' member if child is created.
3629 (process_status_retrieved): New function.
3630 (record_child_status_change): Use it.
3631 Accept negative 1st argument, which means to wait for the
3632 processes that Emacs already knows about. Move special-case code
3633 for DOS_NT (which lacks WNOHANG) here, from caller. Keep track of
3634 processes that have already been waited for, by testing and
3635 clearing new 'alive' member.
3636 (CAN_HANDLE_MULTIPLE_CHILDREN): Remove, as record_child_status_change
3637 now does this internally.
3638 (handle_child_signal): Let record_child_status_change do all
3639 the work, since we do not want to reap all exited child processes,
3640 only the child processes that Emacs itself created.
3641 * process.h (Lisp_Process): New boolean member 'alive'.
3642
0d879dca
PE
3643 Omit duplicate definitions no longer needed with gcc -g3.
3644 * lisp.h (GCTYPEBITS, GCALIGNMENT, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG)
3645 (VALMASK, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM):
3646 Define only as macros. There's no longer any need to also define
3647 these symbols as enums or as constants, since we now assume
3648 gcc -g3 when debugging.
3649
3478f4b5
EZ
36502012-11-03 Eli Zaretskii <eliz@gnu.org>
3651
3652 * lisp.mk: Adjust comments to the fact that term/internal is now
3653 loaded from loadup.el.
3654
3655 * msdos.c (msdos_abort): Rename from emacs_abort, and make static.
3656 (msdos_fatal_signal): New function.
3657 (XMenuActivate): Adjust the call to kbd_buffer_events_waiting to
3658 its argument list.
3659
3660 * conf_post.h (_GL_EXECINFO_INLINE) [MSDOS]: Define to "inline"
3661 for GCC versions before 4.
3662 (emacs_raise): Define to call msdos_fatal_signal.
3663
3664 * xdisp.c (init_from_display_pos): Fix initialization of the bidi
3665 iterator when starting in the middle of a display or overlay
3666 string. (Bug#12745)
3667
85fabcb7
CY
36682012-11-03 Chong Yidong <cyd@gnu.org>
3669
3670 * process.c (wait_reading_process_output): Clean up the last
3671 change.
3672
893cc455
CY
36732012-11-03 Jim Paris <jim@jtan.com> (tiny change)
3674
3675 * process.c (wait_reading_process_output): Avoid a race condition
3676 with SIGIO delivery (Bug#11536).
3677
0f7b074f
CY
36782012-11-03 Chong Yidong <cyd@gnu.org>
3679
3680 * buffer.c (cursor_type): Untabify docstring.
3681
3737fee7
DA
36822012-11-03 Dmitry Antipov <dmantipov@yandex.ru>
3683
3684 * frame.h (struct frame): Drop can_have_scroll_bars member
3685 which is meaningless for a long time. Adjust comments.
3686 (FRAME_CAN_HAVE_SCROLL_BARS): Remove.
3687 * frame.c, nsfns.m, term.c, w32fns.c, xfns.c: Adjust users.
3688
b6a9e8b1
DA
36892012-11-03 Dmitry Antipov <dmantipov@yandex.ru>
3690
3691 * window.c (decode_next_window_args): Update window arg after
3692 calling decode_live_window and so fix crash reported at
3693 http://lists.gnu.org/archive/html/emacs-devel/2012-11/msg00035.html
3694 by Juanma Barranquero <lekktu@gmail.com>.
3695 (Fwindow_body_width, Fwindow_body_height): Simplify a bit.
3696 * font.c (Ffont_at): Likewise.
3697
600d4768
JD
36982012-11-01 Jan Djärv <jan.h.d@swipnet.se>
3699
3700 * widget.c (resize_cb): New function.
3701 (EmacsFrameRealize): Add resize_cb as event handler (Bug#12733).
3702 (EmacsFrameResize): Check if all is up to date before changing frame
3703 size.
3704
1005b4b9
EZ
37052012-11-02 Eli Zaretskii <eliz@gnu.org>
3706
3707 Implement backtrace output for fatal errors on MS-Windows.
3708 * w32fns.c (CaptureStackBackTrace_proc): New typedef.
3709 (BACKTRACE_LIMIT_MAX): New macro.
3710 (w32_backtrace): New function.
3711 (emacs_abort): Use w32_backtrace when the user chooses not to
3712 attach a debugger. Update the text of the abort dialog.
3713
b9e9df47
DA
37142012-11-02 Dmitry Antipov <dmantipov@yandex.ru>
3715
3716 Window-related stuff cleanup here and there.
3717 * dispnew.c (Finternal_show_cursor, Finternal_show_cursor_p):
3718 Use decode_any_window.
3719 * fringe.c (Ffringe_bitmaps_at_pos): Likewise.
3720 * xdisp.c (Fformat_mode_line): Likewise.
3721 * font.c (Ffont_at): Use decode_live_window.
3722 * indent.c (Fcompute_motion, Fvertical_motion): Likewise.
3723 * window.c (decode_next_window_args): Likewise.
3724 (decode_any_window): Remove static.
3725 * window.h (decode_any_window): Add prototype.
3726 * lisp.h (CHECK_VALID_WINDOW, CHECK_LIVE_WINDOW): Move from here...
3727 * window.h: ...to here, redefine via WINDOW_VALID_P and WINDOW_LIVE_P,
3728 respectively.
3729
2b371ff7
DA
37302012-11-02 Dmitry Antipov <dmantipov@yandex.ru>
3731
3732 Remove pad from struct input_event.
3733 * termhooks.h (struct input_event): Remove padding field.
3734 Adjust comment.
3735 * keyboard.c (event_to_kboard): Simplify because frame_or_window
3736 member is never cons for a long time. Adjust comment.
3737 (mark_kboards): Adjust because SELECTION_REQUEST_EVENT and
3738 SELECTION_CLEAR_EVENT has no Lisp_Objects to mark. Add comment.
3739 * xterm.c (handle_one_xevent): Do not initialize frame_or_window
3740 field of SELECTION_REQUEST_EVENT and SELECTION_CLEAR_EVENT.
3741
7e8b50d9
EZ
37422012-11-01 Eli Zaretskii <eliz@gnu.org>
3743
3744 * w32proc.c (getpgrp, setpgid): New functions. (Bug#12776)
3745
322aea6d
PE
37462012-10-31 Paul Eggert <eggert@cs.ucla.edu>
3747
3748 Fix crash when using Emacs as commit editor for git (Bug#12697).
3749 * callproc.c (setpgrp): Remove macro, as we now use setpgid
3750 and it is configured in conf_post.h.
3751 (Fcall_process): Don't invoke both setsid and setpgid; the former
3752 is enough, if it exists.
3753 * callproc.c (Fcall_process, child_setup):
3754 * process.c (create_process): Use setpgid.
3755 * conf_post.h (setpgid) [!HAVE_SETPGID]: New macro, which substitutes
3756 for the real thing.
3757 * dispnew.c (init_display): Initialize the foreground group
3758 if we are running a tty display.
3759 * emacs.c (main): Do not worry about setpgrp; init_display does it now.
3760 * lisp.h (init_foreground_group): New decl.
3761 * sysdep.c (inherited_pgroup): New static var.
3762 (init_foreground_group, tcsetpgrp_without_stopping)
3763 (narrow_foreground_group, widen_foreground_group): New functions.
3764 (init_sys_modes): Narrow foreground group.
3765 (reset_sys_modes): Widen foreground group.
3766
220cb2bd
MA
37672012-10-31 Michael Albinus <michael.albinus@gmx.de>
3768
3769 * dbusbind.c: Fix cut'n'waste error. Use HAVE_DBUS_VALIDATE_INTERFACE.
3770
218e997a
MR
37712012-10-31 Martin Rudalics <rudalics@gmx.at>
3772
3773 * minibuf.c (read_minibuf): Restore current buffer since
3774 choose_minibuf_frame calling Fset_frame_selected_window may
3775 change it (Bug#12766).
3776
02615da0
JD
37772012-10-30 Jan Djärv <jan.h.d@swipnet.se>
3778
3779 * frame.c (Fframe_pixel_height): Fix documentation (Bug#12733).
3780
aee5b18e
KH
37812012-10-30 Kenichi Handa <handa@gnu.org>
3782
3783 * font.c (Ffont_at): If WINDOW is specified and it is not
3784 displaying the current buffer, signal an error.
3785
ba116008
DC
37862012-10-29 Daniel Colascione <dancol@dancol.org>
3787
de5ef41a
SM
3788 * cygw32.h, cygw32.c (Qutf_16le, from_unicode, to_unicode):
3789 In preparation for fixing bug#12739, move these functions from
ba116008
DC
3790 here...
3791
3792 * coding.h, coding.c: ... to here, and compile them only when
53372c27
DC
3793 WINDOWSNT or CYGWIN. Moving these functions out of cygw32 proper
3794 lets us write cygw32-agnostic code for the HAVE_NTGUI case.
ba116008 3795
640bf8ad
EZ
37962012-10-28 Eli Zaretskii <eliz@gnu.org>
3797
3798 * w32proc.c (TIMER_TICKS_PER_SEC): New macro.
3799 (timer_loop, getitimer, setitimer): Use it instead of
3800 CLOCKS_PER_SEC, which is no longer pertinent, since we don't use
3801 'clock'.
3802 (w32_get_timer_time): Use 10*TIMER_TICKS_PER_SEC instead of a
3803 literal 10000.
3804
64ccff5f
JD
38052012-10-28 Jan Djärv <jan.h.d@swipnet.se>
3806
3807 * nsterm.m (NO_APPDEFINED_DATA): New define.
3808 (last_appdefined_event_data): New variable
3809 (last_appdefined_event): Remove.
3810 (ns_select): Initialize t from last_appdefined_event_data instead
3811 of [last_appdefined_event data1].
3812 (sendEvent:): Save [theEvent data1] to last_appdefined_event_data,
3813 remove last_appdefined_event (Bug#12698).
3814
e483264c
SM
38152012-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3816
3817 * frame.c (x_set_font): Catch internal error.
3818
6c16c13e
EZ
38192012-10-27 Eli Zaretskii <eliz@gnu.org>
3820
e483264c
SM
3821 Avoid overflow in w32 implementation of interval timers.
3822 When possible, for ITIMER_PROF count only times the main thread
6c16c13e
EZ
3823 actually executes.
3824 * w32proc.c <struct itimer_data>: 'expire' and 'reload' are now
2e612797
EZ
3825 'volatile ULONGLONG' types. All the other data which was
3826 previously clock_t is now ULONGLONG. 'terminate' is 'volatile int'.
6c16c13e
EZ
3827 (GetThreadTimes_Proc): New typedef.
3828 (w32_get_timer_time): New function, returns a suitable time value
3829 for the timer.
3830 (timer_loop): Enter critical section when accessing ULONGLONG
3831 values of the itimer_data struct, as these accesses are no longer
e483264c
SM
3832 atomic. Call 'w32_get_timer_time' instead of 'clock'.
3833 Remove unused variable.
6c16c13e
EZ
3834 (init_timers): Initialize s_pfn_Get_Thread_Times.
3835 (start_timer_thread): Don't assign itimer->caller_thread here.
3836 (getitimer): Assign itimer->caller_thread here.
3837 (setitimer): Always call getitimer to get the value of ticks_now.
2f246cd3 3838 (sys_spawnve): Avoid compiler warning about format mismatch.
6c16c13e 3839
ccc83f50
EZ
38402012-10-26 Eli Zaretskii <eliz@gnu.org>
3841
3842 * w32fns.c (w32_wnd_proc) <WM_MOUSEMOVE>: Don't enable tracking of
3843 mouse movement events if the menu bar is active. This avoids
3844 producing a busy "hour-glass" cursor by Windows if the mouse
3845 pointer is positioned over a tooltip shown for some menu item.
3846
69deda53
PE
38472012-10-25 Paul Eggert <eggert@cs.ucla.edu>
3848
3849 Don't assume process IDs fit in int.
3850 * emacs.c (shut_down_emacs) [!DOS_NT]:
3851 * sysdep.c (sys_suspend) [SIGTSTP && !MSDOS]:
3852 * term.c (dissociate_if_controlling_tty) [!DOS_NT]:
3853 Use pid_t, not int, to store process IDs, as 'int'
3854 is not wide enough on a few platforms (e.g., AIX and IRIX).
3855
7e70a152
KH
38562012-10-23 Kenichi Handa <handa@gnu.org>
3857
3858 The following change is to make face-font-rescale-alist work
3859 correctly for non-ASCII fonts.
3860
3861 * font.c (font_open_entity): Don't handle Vface_font_rescale_alist.
3862 (font_open_for_lface): Handle Vface_font_rescale_alist.
3863
49238e7f
CY
38642012-10-23 Chong Yidong <cyd@gnu.org>
3865
3866 * xfaces.c (Vfont_list_limit): Move unused variable to faces.el.
3867
5ec86886
JD
38682012-10-21 Jan Djärv <jan.h.d@swipnet.se>
3869
ef446959
JD
3870 * nsfont.m (nsfont_open, ns_glyph_metrics): Force integer advancement
3871 for screen font.
3872 (nsfont_draw): Turn off LCD-smoothing (Bug#11484).
3873
5ec86886
JD
3874 * xterm.c (x_focus_changed): Check if daemonp when sending focus in
3875 event (Bug#12681).
3876
ee7a418d
GM
38772012-10-21 Glenn Morris <rgm@gnu.org>
3878
3879 * lisp.mk (lisp): Add cp51932.el and eucjp-ms.el.
3880
4973679b
PE
38812012-10-20 Paul Eggert <eggert@cs.ucla.edu>
3882
3883 Port to OpenBSD 5.1.
3884 * frame.c (Fmouse_position, Fmouse_pixel_position):
3885 * xdisp.c (produce_stretch_glyph):
3886 Declare local vars only when they're needed.
3887 This is clearer and avoids a warning on OpenBSD about unused vars.
3888 * frame.h (FRAME_WINDOW_P): Always evaluate its argument.
3889 This is safer, and avoids OpenBSD warnings about unused vars.
3890 * keyboard.c (record_menu_key): Remove unnecessary decl.
3891 (poll_timer): Define only if POLL_FOR_INPUT is defined.
3892 * unexelf.c (ELFSIZE) [!ElfW]: Do not define if already defined,
3893 as our definition clashes with OpenBSD's.
3894 * xfaces.c (load_face_colors, check_lface_attrs)
3895 (get_lface_attributes_no_remap, get_lface_attributes)
3896 (lface_fully_specified_p, x_supports_face_attributes_p)
3897 (tty_supports_face_attributes_p, face_fontset, realize_face)
3898 (realize_x_face, realize_tty_face):
3899 Declare parameters to be Lisp_Object[LFACE_VECTOR_SIZE], not
3900 merely Lisp_Object *. This is more informative and avoids
3901 a warning on OpenBSD about accessing beyond an object's size.
3902
c664f463
CY
39032012-10-20 Chong Yidong <cyd@gnu.org>
3904
3905 * lread.c (Fload): Doc fix (Bug#12592).
3906
6ec83f92 39072012-10-19 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
a0d7415f
KH
3908
3909 * font.c (Ffont_at): Fix previous change.
3910
d2824928
EZ
39112012-10-19 Eli Zaretskii <eliz@gnu.org>
3912
e483264c
SM
3913 * puresize.h (BASE_PURESIZE): Bump the base value to 1700000.
3914 See http://lists.gnu.org/archive/html/emacs-devel/2012-10/msg00593.html
c052c554
EZ
3915 for the reasons.
3916
d2824928
EZ
3917 * alloc.c (NSTATICS): Decrease to 0x800.
3918
f60d391f
SM
39192012-10-19 Stefan Monnier <monnier@iro.umontreal.ca>
3920
4a0e1924 3921 * fns.c (Fnreverse): Include the problem element when signaling an
f60d391f
SM
3922 error (bug#12677).
3923
1a9327d5
JD
39242012-10-18 Jan Djärv <jan.h.d@swipnet.se>
3925
3926 * nsterm.m (ns_select): Check writefds before call to
3927 FD_ISSET (Bug#12668).
3928
14145a1e
DC
39292012-10-18 Daniel Colascione <dancol@dancol.org>
3930
3931 * alloc.c (NSTATICS): Increase from 0x650 to 0x1000
3932 (staticpro): If we run out of staticpro slots, die with an
3933 informative error instead of just calling emacs_abort.
3934
1f76f6f5
MR
39352012-10-18 Martin Rudalics <rudalics@gmx.at>
3936
3937 Fix two flaws reported by Dmitry Antipov.
3938 * window.c (Ftemp_output_buffer_show): Remove.
3939 (Fwindow_vscroll, Fset_window_vscroll): Use decode_live_window.
3940 (syms_of_window): Remove defsubr for Stemp_output_buffer_show.
3941
fcf14875
EZ
39422012-10-17 Eli Zaretskii <eliz@gnu.org>
3943
1f76f6f5
MR
3944 * makefile.w32-in ($(BLD)/w32.$(O)):
3945 ($(BLD)/vm-limit.$(O)):
3946 ($(BLD)/term.$(O)):
3947 ($(BLD)/unexw32.$(O)):
3948 ($(BLD)/fileio.$(O)):
a68089e4
EZ
3949 ($(BLD)/dispnew.$(O)): Update dependencies.
3950
3951 * w32term.h (w32_initialize_display_info, initialize_w32_display):
3952 Add prototypes.
3953
3954 * w32proc.c: Include ctype.h.
3955
3956 * w32.h (init_environment, check_windows_init_file)
3957 (syms_of_ntproc, syms_of_ntterm, dostounix_filename)
3958 (unixtodos_filename, init_winsock, srandom, random, sys_pipe)
3959 (set_process_dir, sys_spawnve, register_child, sys_sleep, getwd)
3960 (sys_link): Add prototypes.
3961
3962 * w32.c: Include w32select.h.
3963 (sys_access, e_malloc, sys_select): Add prototypes.
3964 (emacs_gnutls_pull): 'timeout' is now EMACS_TIME, not struct timeval.
3965
3966 * vm-limit.c [WINDOWSNT]: Include w32heap.h.
3967
3968 * unexw32.c: Include lisp.h and w32.h.
3969
3970 * term.c [WINDOWSNT]: Include w32term.h.
3971
3972 * process.c [WINDOWSNT]: Add prototype of sys_select.
3973
3974 * fileio.c [WINDOWSNT]: Include w32.h.
3975
3976 * dispnew.c [WINDOWSNT]: Include w32.h.
3977
fcf14875
EZ
3978 * cygw32.c (Fcygwin_convert_path_to_windows)
3979 (Fcygwin_convert_path_from_windows): Use EQ to compare 2
3980 Lisp_Object values. (Bug#12661)
3981
3982 * w32fns.c (w32_msg_pump): Use XIL instead of casting an integer
3983 to Lisp_Object. (Bug#12661)
3984
fe0b1ec4
KH
39852012-10-17 Kenichi Handa <handa@gnu.org>
3986
3987 * xdisp.c (reseat_1): Make the information stored in it->cmp_it
3988 invalidate.
3989
d556ebf9
DA
39902012-10-17 Dmitry Antipov <dmantipov@yandex.ru>
3991
3992 * buffer.c (Fkill_buffer): When unchaining the marker,
1f9f395d 3993 reset its buffer pointer to NULL (Bug#12652).
d556ebf9 3994
f0863a54
DA
39952012-10-17 Dmitry Antipov <dmantipov@yandex.ru>
3996
3997 Do not verify indirection counters of killed buffers (Bug#12579).
3998 * buffer.h (BUFFER_CHECK_INDIRECTION): New macro.
3999 * buffer.c (compact_buffer, set_buffer_internal_1): Use it.
4000
12fbe755
DA
40012012-10-16 Dmitry Antipov <dmantipov@yandex.ru>
4002
4003 * alloc.c (Fmake_byte_code): Fix typo in comment.
4004 * print.c (print_interval): Define as static to match prototype.
4005 * indent.c (disptab_matches_widthtab, recompute_width_table):
4006 Convert to eassert.
4007
61655b89
DA
40082012-10-16 Dmitry Antipov <dmantipov@yandex.ru>
4009
4010 * editfns.c (get_system_name): Remove.
4011 * lisp.h (get_system_name): Remove prototype.
4012 * xrdb.c (getenv, getpwuid, getpwnam): Remove prototypes.
4013 (get_environ_db): Use Vsystem_name. Avoid call to strlen.
4014
9520f2f2
DC
40152012-10-15 Daniel Colascione <dancol@dancol.org>
4016
4017 * dbusbind.c: Add comment explaining reason for previous change.
4018
dca778d5
MR
40192012-10-15 Martin Rudalics <rudalics@gmx.at>
4020
4021 * window.c (Fwindow_end): Rewrite check whether cached position
4022 can be used (Bug#12600).
4023 (resize_frame_windows, grow_mini_window, shrink_mini_window):
4024 Set windows_or_buffers_changed.
4025
3e0341b0
DC
40262012-10-15 Daniel Colascione <dancol@dancol.org>
4027
4028 * dbusbind.c: Fix cygw32 build break when compiling with dbus
4029 enabled by undefining the symbol "interface", which the platform
4030 headers define to something incompatible.
4031
33d4113c
DC
40322012-10-14 Daniel Colascione <dancol@dancol.org>
4033
4034 * image.c (init_tiff_functions, init_imagemagick_functions)
4035 (init_svg_functions): Fix cygw32 build break by using these
4036 functions only when WINDOWSNT _and_ HAVE_NTGUI.
4037
a36fb15e
JD
40382012-10-14 Jan Djärv <jan.h.d@swipnet.se>
4039
4040 * nsterm.m (ns_select): Count fd:s in writefs also (Bug#12422).
4041
537f336d
JD
40422012-10-13 Jan Djärv <jan.h.d@swipnet.se>
4043
4044 * gtkutil.c (xg_set_widget_bg): Divide by 65535 (Bug#12612).
4045
0ba06a77
KH
40462012-10-13 HANATAKA, Shinya <bogytech@gmail.com> (tiny change)
4047
4048 * coding.c (detect_coding): Set coding->id before calling
4049 this->detector.
4050
ce2fe65a
AS
40512012-10-13 Andreas Schwab <schwab@linux-m68k.org>
4052
4053 * fileio.c: Formatting fixes.
4054
d6453ce4
PE
40552012-10-13 Paul Eggert <eggert@cs.ucla.edu>
4056
4057 Fix some stat-related races.
4058 * fileio.c (Fwrite_region): Avoid race condition if a file is
4059 removed or renamed by some other process immediately after Emacs
4060 writes it but before Emacs stats it. Do not assume that stat (or
4061 fstat) succeeds.
4062 * image.c (slurp_file): Resolve the file name with fopen + fstat
4063 rather than stat + fopen.
4064 (pbm_read_file) [0]: Remove unused code with stat race.
4065 * process.c (allocate_pty) [HAVE_PTYS && !PTY_ITERATION && !PTY_OPEN]:
4066 Remove ineffective code with stat race.
4067
06485aa8
SM
40682012-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4069
4070 * doc.c (get_doc_string): Don't signal an error if the file is missing.
4071
167e3640
JD
40722012-10-12 Jan Djärv <jan.h.d@swipnet.se>
4073
4074 * nsterm.m (hold_event_q): New static variable.
4075 (EV_TRAILER, sendScrollEventAtLoc:fromEvent:): Call hold_event if
4076 ! q_event_ptr.
4077 (hold_event): New function.
4078 (ns_read_socket): If hold_event_q have events, store them and
4079 return (Bug#12384).
4080 (setPosition:portion:whole:): Send SIGIO to ourselves if apploopnr
4081 is zero (Bug#12384).
4082
c40239df
JB
40832012-10-12 Juanma Barranquero <lekktu@gmail.com>
4084
4085 * makefile.w32-in ($(BLD)/w32select.$(O)): Update dependencies.
4086
bb385a92
EZ
40872012-10-12 Eli Zaretskii <eliz@gnu.org>
4088
2a9f1099
EZ
4089 * makefile.w32-in ($(BLD)/fileio.$(O)): Add sys/file.h.
4090
bb385a92
EZ
4091 * fileio.c (check_existing): New function.
4092 (make_temp_name, Ffile_exists_p, Ffile_writable_p): Call it
4093 instead of calling 'stat', when what's needed is to check whether
4094 a file exists. This avoids expensive system calls on MS-Windows.
4095 (Bug#12587)
4096
8599b23a 4097 * w32.c (init_environment): Call 'check_existing' instead of 'stat'.
bb385a92
EZ
4098
4099 * lread.c (openp) [WINDOWSNT]: Call 'access' instead of 'stat' to
4100 determine whether a file exists and is not a directory.
4101
4102 * lisp.h (check_existing): Add prototype.
4103
2b9c2e68
JD
41042012-10-12 Jan Djärv <jan.h.d@swipnet.se>
4105
4106 * nsfont.m (nsfont_open): Remove font cache, it is not GC correct.
4107
81749a23
GM
41082012-10-12 Glenn Morris <rgm@gnu.org>
4109
4110 * buffer.c (Fset_buffer): Doc fix. (Bug#12624)
4111
5253a5fd
SM
41122012-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4113
389a94a5
SM
4114 * buffer.c (Fkill_buffer): Null out the overlay list(s) as well.
4115
5253a5fd
SM
4116 * eval.c (Fautoload): Remember previous autoload status in load-history.
4117
7cded46f
PE
41182012-10-11 Paul Eggert <eggert@cs.ucla.edu>
4119
4120 lread.c, macros.c, marker.c, menu.c, minibuf.c: Use bool for booleans.
4121 * lread.c (load_each_byte, new_backquote_flag, readchar)
4122 (read_filtered_event, lisp_file_lexically_bound_p)
4123 (safe_to_load_version, Fload, complete_filename_p, openp)
4124 (build_load_history, readevalloop, read_escape, read1)
4125 (string_to_number, read_vector, read_list):
4126 * macros.c (Fstart_kbd_macro):
4127 * marker.c (CONSIDER):
4128 * menu.c (parse_single_submenu, digest_single_submenu)
4129 (find_and_return_menu_selection, Fx_popup_menu):
4130 * minibuf.c (read_minibuf_noninteractive, read_minibuf)
4131 (Ftry_completion):
4132 * nsmenu.m (ns_update_menubar, runMenuAt:forFrame:keymaps:):
4133 (ns_menu_show):
4134 * xmenu.c (set_frame_menubar, create_and_show_popup_menu)
4135 (xmenu_show, xdialog_show):
4136 Use bool for booleans.
4137 * lread.c (safe_to_load_version): Rename from safe_to_load_p,
4138 as it's not a predicate. All uses changed. Omit unnecessary
4139 buffer termination.
4140
549c3414
DA
41412012-10-11 Dmitry Antipov <dmantipov@yandex.ru>
4142
4143 * editfns.c (save_excursion_save): Use nil if mark points to nowhere.
4144 (save_excursion_restore): Do not restore mark if it was not saved.
4145
e85aafe7
PE
41462012-10-11 Paul Eggert <eggert@cs.ucla.edu>
4147
fd2f90cf
PE
4148 * marker.c (cached_modiff): EMACS_INT, not int.
4149
c1af190b
PE
4150 * w32select.c (waiting_for_input): Declare by including "keyboard.h"
4151 instead of having a wrong decl.
e85aafe7
PE
4152 * nsmenu.m (waiting_for_input): Remove wrong decl.
4153
e738ca56
PE
41542012-10-10 Paul Eggert <eggert@cs.ucla.edu>
4155
9fa1de30
PE
4156 keyboard.c, keymap.c: Use bool for booleans.
4157 * dispnew.c (sit_for): Distinguish between 3-way display_option
4158 and boolean do_display.
4159 * keyboard.c (single_kboard, this_command_key_count_reset)
4160 (waiting_for_input, echoing, immediate_quit, input_pending)
4161 (interrupt_input, interrupts_deferred, pop_kboard)
4162 (temporarily_switch_to_single_kboard, ignore_mouse_drag_p)
4163 (command_loop_1, adjust_point_for_property)
4164 (safe_run_hooks_error, input_polling_used, read_char):
4165 (help_char_p, readable_events, kbd_buffer_events_waiting)
4166 (kbd_buffer_get_event, timer_check_2, make_lispy_event)
4167 (lucid_event_type_list_p, get_input_pending):
4168 (gobble_input, menu_separator_name_p, menu_bar_item)
4169 (parse_menu_item, parse_tool_bar_item, read_char_x_menu_prompt)
4170 (read_char_minibuf_menu_prompt, access_keymap_keyremap)
4171 (keyremap_step, test_undefined, read_key_sequence)
4172 (detect_input_pending, detect_input_pending_ignore_squeezables)
4173 (detect_input_pending_run_timers, requeued_events_pending_p)
4174 (quit_throw_to_read_char, Fset_input_interrupt_mode):
4175 * keymap.c (get_keymap, keymap_parent, keymap_memberp)
4176 (access_keymap_1, access_keymap, map_keymap, get_keyelt)
4177 (Fdefine_key, Flookup_key, struct accessible_keymaps_data)
4178 (accessible_keymaps_1, Fkey_description, push_key_description):
4179 (shadow_lookup, struct where_is_internal_data)
4180 (where_is_internal, Fwhere_is_internal, where_is_internal_1)
4181 (Fdescribe_buffer_bindings, describe_map_tree, struct describe_map_elt)
4182 (describe_map, describe_vector):
4183 * menu.c (single_menu_item):
4184 * nsmenu.m (ns_update_menubar):
4185 * process.c (wait_reading_process_output):
4186 * search.c (scan_buffer, scan_newline):
4187 Use bool for boolean.
4188 * keyboard.c (timers_run, swallow_events)
4189 (detect_input_pending_run_timers):
4190 * process.c (wait_reading_process_output):
4191 Use unsigned for counter where wraparound-on-overflow is desired,
4192 since unsigned is guaranteed to have that behavior and signed is not.
4193 (read_char): Use ptrdiff_t for string length.
4194 (get_input_pending): Remove first argument, since it was always
4195 the same pointer-to-int (now pointer-to-boolean) &input_pending,
4196 and behave as if it had that value. Return new value of
4197 input_pending. All callers changed.
4198 * keyboard.h (struct kboard): Use unsigned : 1 for boolean member
4199 immediate_echo. Use ptrdiff_t for echo_after_prompt, since it's
4200 a string length.
4201 * keymap.c (push_key_description): Omit last arg, which was always 1.
4202 All callers changed.
4203
e738ca56
PE
4204 * regex.c (immediate_quit) [emacs]: Remove duplicate decl.
4205
29f21cdf
JB
42062012-10-10 Juanma Barranquero <lekktu@gmail.com>
4207
4208 * makefile.w32-in ($(BLD)/dispnew.$(O), $(BLD)/indent.$(O))
4209 ($(BLD)/term.$(O)): Update dependencies.
4210
6aea7528
DA
42112012-10-10 Dmitry Antipov <dmantipov@yandex.ru>
4212
4213 * alloc.c (mark_object): Use meaningful PVEC_NORMAL_VECTOR.
4214 * lisp.h (enum pvec_type): Adjust comments and omit explicit
4215 initializer for PVEC_NORMAL_VECTOR.
4216
5f3f57be
PE
42172012-10-10 Paul Eggert <eggert@cs.ucla.edu>
4218
4219 Clean out old termopts cruft.
4220 * termopts.h (flow_control, meta_key): Remove unused decls.
4221 * dispnew.c, indent.c, nsterm.m, term.c, xsettings.c, xsmfns.c:
4222 Don't include termopts.h.
4223
3e98c68e
DA
42242012-10-10 Dmitry Antipov <dmantipov@yandex.ru>
4225
4226 * alloc.c (gc_sweep): Use pointer-to-a-pointer loop for buffers.
4227
77e344e5
PE
42282012-10-10 Paul Eggert <eggert@cs.ucla.edu>
4229
4230 * commands.h (immediate_quit): Remove duplicate decl.
4231
5683d7cd
JD
42322012-10-09 Jan Djärv <jan.h.d@swipnet.se>
4233
4234 * nsfont.m (Vfonts_in_cache): Remove, not needed as font.c handles
4235 caching.
4236 (nsfont_open): Remove setting of Vfonts_in_cache.
1f9f395d 4237 (syms_of_nsfont): Remove initialization of Vfonts_in_cache.
5683d7cd 4238
cf5fc6db
EZ
42392012-10-09 Eli Zaretskii <eliz@gnu.org>
4240
b15736e6
EZ
4241 * w32fns.c (w32_last_error): Change the return value to DWORD, to
4242 match what GetLastError returns. Explain why the function is
4243 needed.
4244
cf5fc6db
EZ
4245 * frame.c (delete_frame): Rename local variable 'tooltip_frame' to
4246 'is_tooltip_frame', to avoid confusion with its global namesake.
4247
f99714ce
DC
42482012-10-08 Daniel Colascione <dancol@dancol.org>
4249
4250 * xdisp.c (start_hourglass): Call w32_note_current_window when
2b1f11ed
EZ
4251 HAVE_NTGUI, not just WINDOWSNT, resolving a problem in the cygw32
4252 build that caused Emacs to display the hourglass cursor forever.
f99714ce 4253
fd59cb29
GM
4254 * w32fns.c (Fx_display_color_cells): Instead of using NCOLORS,
4255 which is broken under remote desktop, calculate the number of
4256 colors available for a display based on the display's number of
4257 planes and number of bits per pixel per plane. (bug#10397).
4258
62c480c9 42592012-10-08 Jan Djärv <jan.h.d@swipnet.se>
fd59cb29 4260
62c480c9
JD
4261 * nsfont.m (Vfonts_in_cache): New variable.
4262 (nsfont_open): Use unsignedLongLongValue for cache in case wide ints
4263 are used. Add cached fonts to Vfonts_in_cache.
4264 (syms_of_nsfont): Initialize and staticpro Vfonts_in_cache.
4265
607446ba
JB
42662012-10-08 Juanma Barranquero <lekktu@gmail.com>
4267
fd5125ad
JB
4268 * makefile.w32-in (LOCAL_FLAGS): Don't define HAVE_NTGUI, it's now
4269 in nt/config.nt.
46979e0b
JB
4270 (FONT_H): Define after FRAME_H.
4271 ($(BLD)/emacs.$(O), $(BLD)/process.$(O), $(BLD)/w32heap.$(O)):
4272 Update dependencies.
fd5125ad 4273
607446ba
JB
4274 * w32term.c: Remove leftover declaration of keyboard_codepage.
4275
b6f4e300
EZ
42762012-10-08 Eli Zaretskii <eliz@gnu.org>
4277
c54ebba4
EZ
4278 * makefile.w32-in (FONT_H): Add $(FRAME_H).
4279 (W32TERM_H): Add $(ATIMER_H) and $(FRAME_H).
4280 ($(BLD)/emacs.$(O), $(BLD)/w32console.$(O)): Update dependencies.
4281 (GLOBAL_SOURCES): Add cygw32.c.
fd59cb29
GM
4282 ($(BLD)/unexw32.$(O)):
4283 ($(BLD)/w32.$(O)):
4284 ($(BLD)/w32console.$(O)):
4285 ($(BLD)/w32fns.$(O)):
4286 ($(BLD)/w32heap.$(O)):
4287 ($(BLD)/w32menu.$(O)):
15c720a3 4288 ($(BLD)/w32proc.$(O)): Add w32common.h.
c54ebba4 4289
b6f4e300
EZ
4290 * w32fns.c (w32_color_map_lookup, x_to_w32_color): Argument is now
4291 'const char *'.
4292 (x_to_w32_color): Don't modify the argument, modify a copy instead.
4293
501199a3
DC
42942012-10-08 Daniel Colascione <dancol@dancol.org>
4295
4296 * w32term.h (WM_EMACS_BRINGTOTOP, WM_EMACS_INPUT_READY)
4297 (WM_EMACS_END): Change WM_EMACS_BRINGTOTOP from 22 to 21 to close
4298 accidental message numbering hole. Change other messages to
4299 match.
4300
4301 * w32select.h (HAVE_W32SELECT): Remove.
4302
4303 * w32select.c, w32proc.c, w32menu.c, w32console.c, w32.c: Include
1f9f395d 4304 w32common.h instead of w32heap.h.
501199a3
DC
4305
4306 * w32heap.h (ROUND_UP, ROUND_DOWN, get_page_size)
4307 (get_allocation_unit, get_processor_type, get_w32_major_version)
4308 (get_w32_minor_version, sysinfo_cache, osinfo_cache)
4309 (w32_major_version, w32_minor_version, w32_build_number, OS_9X)
4310 (OS_NT, os_subtype, cache_system_info): Move declarations to
4311 w32common.
4312
4313 * w32heap.c: Include w32common.h.
4314 (sysinfo_cache, syspage_mask, osinfo_cache, w32_major_version)
8599b23a
SM
4315 (w32_minor_version, w32_build_number, w32_subtype):
4316 Remove duplicate definitions.
501199a3
DC
4317
4318 * w32fns.c: Include w32common.h; include w32heap.h only in
4319 WINDOWSNT.
4320
4321 (Fx_file_dialog): Clarify comment on GetOpenFileName structure.
4322 Use `report_file_error' instead of `error' in order to better
4323 inform users of what went wrong. Increase NTGUI_UNICODE file
4324 dialog box file name length to 32k, the maximum allowed by the NT
4325 kernel.
4326
4327 * w32common.h: New file.
4328 (ROUND_UP, ROUND_DOWN, get_page_size)
4329 (get_allocation_unit, get_processor_type, get_w32_major_version)
4330 (get_w32_minor_version, sysinfo_cache, osinfo_cache)
4331 (w32_major_version, w32_minor_version, w32_build_number, OS_9X)
4332 (OS_NT, os_subtype, cache_system_info): Move here.
4333
4334 * unexw32.c, unexcw.c: Include w32common.h.
4335
4336 * emacs.c (main): Use (defined (WINDOWSNT) || defined
4337 HAVE_NTGUI) instead of removed HAVE_W32SELECT to decide whether
4338 to call syms_of_w32select.
4339
4340 * cygw32.h: Remove obsolete EXFUN declarations.
4341
4342 * cygw32.c (Qutf_16_le): Rename to Qutf_16le.
4343
4344 * Makefile.in (SOME_MACHINE_OBJECTS): Reverse accidental removal
4345 of w32inevt.o from SOME_MACHINE_OBJECTS.
4346
93aa5c81
DC
43472012-10-08 Daniel Colascione <dancol@dancol.org>
4348
4349 * image.c: Permanent fix for JPEG compilation issue --- limit
4350 jpeglib `boolean' redefinition to Cygwin builds.
4351
d424f3d8
EZ
43522012-10-08 Eli Zaretskii <eliz@gnu.org>
4353
8ee4c6ce
EZ
4354 * image.c (CHECK_LIB_AVAILABLE): Remove, no longer used.
4355
d424f3d8
EZ
4356 * emacs.c (DAEMON_MUST_EXEC) [HAVE_NTGUI]: Define this only on
4357 Cygwin.
4358
e08348a0
DC
43592012-10-08 Daniel Colascione <dancol@dancol.org>
4360
4361 * xfaces.c, xdisp.c, window.c, w32xfns.c, w32term.h, w32term.c,
4362 w32select.h w32select.c, w32proc.c, w32menu.c, w32inevt.c,
4363 w32help.c, w32font.c, w32font.c, w32fns.c, w32console.c, w32.h,
4364 w32.c, unexw32.c, termhooks.h, process.c, menu.c, keyboard.h,
4365 keyboard.c, image.c, frame.h, frame.c, fontset.c, font.h, font.c,
4366 emacs.c, dispextern.h, cygw32.h, cygw32.c, conf_post.h,
4367 Makefile.in: use HAVE_NTGUI for W32 GUI and WINDOWSNT for the
4368 operating system. defined(HAVE_NTGUI) && !defined(WINDOWSNT) is
4369 now a supported configuration.
4370
4371 * Makefile.in: consolidate image variables into LIBIMAGE; add
8e2417bf 4372 W32_OBJ and W32_LIBS. Compile new files.
e08348a0
DC
4373
4374 * conf_post.h:
4375 (_DebPrint) declare tracing facility for W32 debugging. We need
4376 to unify tracing later.
4377
4378 (NTGUI_UNICODE) Define when compiling for Cygwin to allow the
4379 unconditional use of W32 Unicode functions. Cygwin runs only on
4380 100% Unicode operating systems.
4381
4382 * cygw32.c: New file. Define Cygwin-specific facilities.
4383 (Fcygwin_convert_path_to_windows)
4384 (Fcygwin_convert_path_from_windows): New user functions for
4385 accessing Cygwin path-munging routines.
4386
4387 * cygw32.h: New file.
4388 (WCSDATA, to_unicode, from_unicode): Define facilities for storing
4389 UTF-16LE strings temporarily inside non-Lisp-visible string
4390 objects.
4391
4392 (w32_strerror): Just what it says on the tin.
4393
4394 * emacs.c: Make the NS fork-then-exec code for daemon-launching
4395 also run for Cygwin; both systems have the same problem with using
4396 GUI facilities in a forked child. Also call syms_of_cygw32,
4397 syms_of_w32select in correct places.
4398
4399 (DAEMON_MUST_EXEC): new macro defined to signal that a platform
4400 needs fork-then-exec for daemon launching.
4401
4402 * font.h: Include frame.h.
4403
4404 * image.c: Use the image library cache machinery only when we're
4405 compiling for native WINDOWSNT; Cygwin can use shared libraries
4406 like any other Unixlike system.
4407
4408 * keyboard.c: Clarify a comment regarding the input loop.
4409
4410 * menu.c: When NTGUI_UNICODE is defined, use Unicode menu
4411 functions directly instead of trying to detect at runtime that our
4412 host operating system supports them. We make this change for two
4413 reasons: Cygwin lacks support for the multibyte character
4414 conversion functions used by the legacy menu code, and Cygwin
4415 never needs to rely on non-Unicode APIs.
4416
4417 * unexw32.c (hinst): Declare extern.
4418
4419 * w32.c: Change header order;
4420 (w32_strerror): Move to w32fns.c because we need it for
4421 non-WINDOWSNT builds.
4422
4423 * w32.h: Add #error macro to make sure we don't include w32.h for
4424 Cygwin builds. Remove w32select declarations.
4425
4426 * w32console.c (w32_sys_ring_bell, Fset_message_beep): Move to
1f9f395d 4427 w32fns.c. w32console.c is WINDOWSNT-only.
e08348a0
DC
4428
4429 * w32fns.c: Include cygw32.h or w32.h depending on CYGWIN; more
4430 NTGUI_UNICODE tweaks. (See above.) Change _snprintf to the more
4431 POSIXy alternative.
4432 (faked_key, sysinfo_cache, osinfo_cahce, syspage_mask)
4433 (w32_major_version, w32_minor_version, w32_build_number)
4434 (os_subtype, sound_type): Define here
4435 (w32_defined_color): Make color parameter const for consistency
4436 with other _defined_color functions.
4437 (w32_createwindow): Unconditionally call w32_init_class instead of
4438 doing so only when hprevinst is non-NULL. Plumbing hprevinst
4439 through the code is complex and unnecessary because class
4440 registration is practically free.
4441 (w32_name_of_message): New EMACSDEBUG-only function.
4442 (Fset_message_beep): Move here
4443 (Fx_open_connection): Require that the display name for Windows be
4444 "w32" for consistency, emacsclient disambiguation, and maybe, one
4445 day, multi-window-system support.
4446 (file_dialog_callback): NTGUI_UNICODE changes; encode and decode
4447 Cygwin files for W32 GUI facilities, since these clearly don't
4448 expect Cygwin names.
4449 (_DebPrint): Define.
4450 (w32_strerror, w32_console_toggle_lock_key, w32_kbd_mods_to_emacs)
4451 (w32_kbd_patch_key, w32_sys_ring_bell): Move here.
4452 (Ssystem_move_file_to_trash): Define only for native WINDOWSNT.
4453 (w32_last_error): Remove.
4454
4455 * w32font.c: Define _strlwr to strlwr for non-WINDOWSNT builds.
4456
4457 * w32heap.c (syspage_mask): Declare here.
4458 (cache_system_info): Remove.
4459
4460 * w32inevt.c (faked_key): Define globally, not statically.
4461 (w32_kbd_mods_to_emacs, w32_kbd_patch_key, faked_key)
4462 (w32_console_toggle_lock_key): Move to w32fns.c.
4463
4464 * w32menu.c: Include setjmp.h. NTGUI_UNICODE changes throughout.
4465
4466 * w32proc.c (_DebPrint): Move to w32fns.c.
4467 * w32select.c: Include string.h, stdio.h for Cygwin.
4468 * w32select.h: New File.
4469
4470 * w32term.c: Include io.h for non-CYGWIN builds; needed for
4471 get_osfhandle.
4472 (w32_message_fd): New variable. Under Cygwin, holds the file
4473 descriptor the system used to tell us about pending thread
4474 messages.
4475
4476 (w32_init_term): Remove incorrect calls to fcntl and init_sigio
4477 that prevented compilation under non-WINDOWSNT systems.
4478
4479 (w32_initialize): Open /dev/windows and assign it to
4480 w32_message_fd. Provide w32 feature.
4481
4482 * w32term.h: Include frame.h, atimer.h. Declare various frame functions.
4483 (WM_EMACS_INPUT_READY): add.
4484 (prepend_msg, w32_message_fd): Declare globally.
4485
4486 * w32xfns.c:
4487 (keyboard_handle): Use only when WINDOWSNT.
4488 (notify_msg_ready): New function. Posts a message to the main
4489 thread's message queue under CYGWIN, which wakes up the main
4490 thread from select(2) by making the /dev/windows file descriptor
4491 ready. Under WINDOWSNT, it sets an event the same way the old
4492 code did.
4493
4494 (post, prepend_msg): Actually call notify_msg_ready instead of
4495 setting the input event directly.
4496
98daa893
EZ
44972012-10-07 Eli Zaretskii <eliz@gnu.org>
4498
4499 * ralloc.c (relinquish): If a heap is ready to be relinquished,
4500 but it still has blocs in it, don't return it to the system,
4501 instead of aborting. (Bug#12402)
4502
3bc0a2f7
JD
45032012-10-07 Jan Djärv <jan.h.d@swipnet.se>
4504
8ad5b73b 4505 * nsterm.m (ns_dumpglyphs_image): Only draw slice of image (Bug#12506).
493b5b1c 4506
335f5ae4
JD
4507 * nsterm.m (ns_update_auto_hide_menu_bar): Remove defintion of
4508 MAC_OS_X_VERSION_10_6.
8ad5b73b
JD
4509 (syms_of_nsterm): Remove comment about Panther and above for
4510 ns-antialias-text.
335f5ae4
JD
4511 * nsterm.h (MAC_OS_X_VERSION_10_3, onTiger): Remove.
4512 (EmacsApp): Remove check for >= MAC_OS_X_VERSION_10_4.
4513 (struct nsfont_info): Remove check for >= MAC_OS_X_VERSION_10_3.
4514
4515 * nsselect.m (ns_string_from_pasteboard): Remove check for >=
4516 MAC_OS_X_VERSION_10_4.
4517
8ad5b73b
JD
4518 * nsmenu.m (fillWithWidgetValue:): Remove code for <
4519 MAC_OS_X_VERSION_10_2.
335f5ae4
JD
4520
4521 * nsimage.m (setPixmapData, getPixelAtX, setAlphaAtX): Remove onTiger.
4522
4523 * nsfns.m (Fns_list_services): Remove comment and check for OSX < 10.4.
4524 (ns_do_applescript): Remove check for >= MAC_OS_X_VERSION_10_4.
4525
3bc0a2f7
JD
4526 * nsterm.m (ns_in_resize): Remove (Bug#12479).
4527 (ns_resize_handle_rect, mouseDown, mouseUp, mouseDragged): Remove.
8599b23a
SM
4528 (ns_clear_frame, sendEvent, windowDidResize, drawRect:):
4529 Remove ns_in_resize check.
3bc0a2f7
JD
4530 (ns_clear_frame_area): Remove resize handle code.
4531
4532 * nsfns.m (ns_in_resize): Remove.
e483264c
SM
4533 (x_set_icon_name, ns_set_name, ns_set_name_as_filename):
4534 Remove ns_in_resize check.
3bc0a2f7 4535
c622b48f
PE
45362012-10-07 Paul Eggert <eggert@cs.ucla.edu>
4537
4538 Improve sys_siglist detection.
4539 * sysdep.c (sys_siglist, init_signals): Use _sys_siglist if it's
4540 defined as a macro, as is done in Solaris.
4541 (sys_siglist_entries): New macro.
4542 (save_strsignal): Use it.
4543 * syssignal.h (safe_strsignal): Now ATTRIBUTE_CONST, to pacify
4544 GCC 4.7.2 on Fedora 17 with the fixed sys_siglist detection.
4545
04fafa46
JD
45462012-10-06 Jan Djärv <jan.h.d@swipnet.se>
4547
4548 * nsfns.m (Fx_create_frame): Call x_default_parameter with
4549 fullscreen/Fullscreen.
4550
4551 * nsterm.h (EmacsView): Rename tbar_height to tibar_height.
4552 tobar_height is new.
4553
4554 * nsterm.m (x_make_frame_visible): Check for fullscreen.
4555 (ns_fullscreen_hook): Activate old style fullscreen with a timer.
4556 (ns_term_init): Set activateIgnoringOtherApps if old style fullscreen.
4557 (windowDidResize:): Check for correct window if old style fullscreen.
4558 Capitalize word in comment. Remove incorrect comment.
4559 (initFrameFromEmacs:): tbar_height renamed tibar_height.
4560 (windowDidEnterFullScreen:): Toggle toolbar for fullscreen to fix
4561 error in drawing background.
1f9f395d 4562 (toggleFullScreen:): Remove comment. Rearrange calls.
04fafa46
JD
4563 Set toolbar values to zero, save old height in tobar_height.
4564 Restore tool bar height when leaving fullscreen.
4565 (canBecomeMainWindow): New function.
4566
c6e21c03
PE
45672012-10-06 Paul Eggert <eggert@cs.ucla.edu>
4568
4569 * keyboard.c (read_char): Remove unnecessary 'volatile's and label.
4570
0d9f584b
EZ
45712012-10-05 Eli Zaretskii <eliz@gnu.org>
4572
a65fbb5f
EZ
4573 * w32proc.c (stop_timer_thread): Fix declaration of 'err'.
4574
0d9f584b 4575 * w32.c (utime): Open the file with FILE_FLAG_BACKUP_SEMANTICS, so
8599b23a
SM
4576 that time stamps of directories could also be changed.
4577 Don't request the too broad GENERIC_WRITE, only the more restrictive
0d9f584b
EZ
4578 FILE_WRITE_ATTRIBUTES access rights.
4579
4580 * fileio.c (Fset_file_times): Special-case ignoring errors for
4581 directories only on MSDOS, not on MS-Windows.
4582
e8757f09 45832012-10-05 Ikumi Keita <ikumi@ikumi.que.jp> (tiny change)
ca347e3d
IK
4584
4585 * minibuf.c (Fcompleting_read): Doc fix. (Bug#12555)
4586
7604f298
EZ
45872012-10-04 Eli Zaretskii <eliz@gnu.org>
4588
4589 * w32.c (utime): Test for INVALID_HANDLE_VALUE, not for NULL, to
4590 see whether CreateFile failed.
4591
88d69b7d
PE
45922012-10-04 Paul Eggert <eggert@cs.ucla.edu>
4593
4594 * profiler.c (handle_profiler_signal): Inhibit pending signals too,
4595 to avoid similar races.
4596 * keyboard.c (pending_signals): Now bool, not int.
4597
7509f454
PE
4598 Port timers to OpenBSD, plus check for timer failures.
4599 OpenBSD problem reported by Han Boetes.
4600 * profiler.c (setup_cpu_timer): Check for failure of timer_settime
4601 and/or setitimer.
4602 (Fprofiler_cpu_stop): Don't assume HAVE_SETITIMER.
4603 * syssignal.h (HAVE_ITIMERSPEC): New macro. This is for platforms
4604 like OpenBSD, which has timer_settime but does not declare it.
4605 OpenBSD does not define SIGEV_SIGNAL, so use that when deciding
4606 whether to use itimerspec-related primitives. All uses of
4607 HAVE_TIMER_SETTIME replaced with HAVE_ITIMERSPEC.
4608
a3c5c0c5
PE
46092012-10-02 Paul Eggert <eggert@cs.ucla.edu>
4610
4611 * profiler.c (handle_profiler_signal): Fix a malloc race
4612 that caused Emacs to hang on Fedora 17 when profiling Lisp.
4613
914e743b
JD
46142012-10-02 Jan Djärv <jan.h.d@swipnet.se>
4615
4616 * nsterm.m (windowDidEnterFullScreen): Remove fprintf.
4617
d8ab37a8
EZ
46182012-10-02 Eli Zaretskii <eliz@gnu.org>
4619
4620 * w32proc.c (sys_wait): Declare 'signame' 'const char *', to be
4621 consistent with the change in return value of 'safe_strsignal'.
4622
b3ecad33
PE
46232012-10-02 Paul Eggert <eggert@cs.ucla.edu>
4624
0a99eee1
PE
4625 Prefer plain 'static' to 'static inline' (Bug#12541).
4626 * bidi.c (bidi_get_type, bidi_check_type, bidi_get_category)
4627 (bidi_set_sor_type, bidi_push_embedding_level)
4628 (bidi_pop_embedding_level, bidi_remember_char, bidi_copy_it)
4629 (bidi_cache_reset, bidi_cache_shrink, bidi_cache_fetch_state)
4630 (bidi_cache_search, bidi_cache_ensure_space)
4631 (bidi_cache_iterator_state, bidi_cache_find)
4632 (bidi_peek_at_next_level, bidi_set_paragraph_end)
4633 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4634 (bidi_explicit_dir_char, bidi_resolve_neutral_1):
4635 Now 'static', not 'static inline'.
4636
b3ecad33
PE
4637 Count overruns when profiling; change units to ns.
4638 * profiler.c (handle_profiler_signal): Count sampling intervals, not ms.
4639 Give extra weight to samples after overruns, to attempt to count
4640 the time more accurately.
4641 (setup_cpu_timer): Change sampling interval units from ms to ns, since
4642 the underlying primitives nominally do ns.
4643 (Fprofiler_cpu_start): Document the change. Mention that
4644 the sampling intervals are only approximate.
4645
090cf9db
SM
46462012-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4647
4648 * frame.c (Fmake_terminal_frame): Prefer safer CONSP over !NILP.
4649
4650 * coding.h (ENCODE_FILE, DECODE_FILE, DECODE_SYSTEM): Remove special
4651 case for the special 0 coding-system.
4652
4653 * buffer.c (Fset_buffer_multibyte): Signal an error instead of widening.
4654 (Fmake_overlay): Remove redundant tests.
64edc777 4655 (fix_start_end_in_overlays): Remove redundant recentering.
090cf9db 4656
81550bf4
JB
46572012-10-02 Juanma Barranquero <lekktu@gmail.com>
4658
4659 * makefile.w32-in ($(BLD)/alloc.$(O), $(BLD)/gmalloc.$(O)):
4660 Update dependencies.
4661
aa1ba90e
PE
46622012-10-01 Paul Eggert <eggert@cs.ucla.edu>
4663
4664 Fix a malloc race condition involving strsignal.
4665 A signal can arrive in the middle of a malloc, and Emacs's signal
4666 handler can invoke strsignal, which can invoke malloc, which is
4667 not portable. This race condition bug makes Emacs hang on GNU/Linux.
4668 Fix it by altering the signal handler so that it does not invoke
4669 strsignal.
4670 * emacs.c (shut_down_emacs): Use safe_strsignal, not strsignal.
4671 * process.c (status_message): Use const pointer, in case strsignal
4672 is #defined to safe_strsignal.
4673 * sysdep.c (sys_siglist, init_signals): Always define and
4674 initialize a substitute sys_siglist if the system does not define
4675 one, even if HAVE_STRSIGNAL.
4676 (safe_strsignal): Rename from strsignal. Always define,
4677 using sys_siglist. Return a const pointer.
4678 * syssignal.h (safe_strsignal): New decl.
4679 (strsignal) [!HAVE_STRSIGNAL]: Define in terms of safe_strsignal.
4680
ace917bd
EZ
46812012-10-01 Eli Zaretskii <eliz@gnu.org>
4682
4683 * w32proc.c (timer_loop): Fix code that waits for timer
4684 expiration, to avoid high CPU usage.
4685
9eb71b9c
SM
46862012-10-01 Stefan Monnier <monnier@iro.umontreal.ca>
4687
4688 * fns.c (check_hash_table, get_key_arg, maybe_resize_hash_table)
4689 (sweep_weak_table): Remove redundant prototypes.
4690
b3317662
FP
46912012-10-01 Fabrice Popineau <fabrice.popineau@gmail.com>
4692
4693 * emacs.c: Move the inclusion of TERM_HEADER after including
4694 windows.h on WINDOWSNT. This avoids compilation problems with
4695 MSVC.
4696
f0e5f225
EZ
46972012-10-01 Eli Zaretskii <eliz@gnu.org>
4698
2d7d1608
EZ
4699 * unexw32.c (OFFSET_TO_RVA, RVA_TO_OFFSET)
4700 (RVA_TO_SECTION_OFFSET): Encode all macro arguments in parentheses.
4701 (RVA_TO_PTR): Cast the result of RVA_TO_OFFSET to 'unsigned char *',
4702 as the previous version used 'void *'.
4703
4704 * ralloc.c (ROUNDUP): Fix last change.
4705 (MEM_ROUNDUP): Don't cast MEM_ALIGN, it is already of type
4706 'size_t'.
4707
f0e5f225
EZ
4708 * w32proc.c <disable_itimers>: New static flag.
4709 (init_timers): Initialize it to zero, after creating the critical
4710 sections used by the timer threads.
4711 (term_timers): Set to 1 before deleting the critical sections.
4712 (getitimer, setitimer): If disable_itimers is non-zero, return an
4713 error indication without doing anything. Reported by Fabrice
4714 Popineau <fabrice.popineau@supelec.fr> as part of bug#12544.
4cdfbb89
EZ
4715 (alarm) [HAVE_SETITIMER]: Be more conformant to the expected
4716 return results.
4717 [!HAVE_SETITIMER]: Behave as the previous version that didn't
4718 support timers.
f0e5f225
EZ
4719
4720 * emacs.c (shut_down_emacs) [WINDOWSNT]: Move the call to
4721 term_ntproc after all the other bookkeeping, to get timers working
4722 as long as possible.
4723
82ef37c1
PE
47242012-10-01 Paul Eggert <eggert@cs.ucla.edu>
4725
b3a4c387
PE
4726 * xdisp.c (syms_of_xdisp): Default message-log-max to 1000, not 100.
4727 Suggested by Juri Linkov in
4728 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00821.html>.
4729
b0ab8123
PE
4730 Prefer plain 'static' to 'static inline' (Bug#12541).
4731 With static functions, modern compilers inline pretty well by
4732 themselves; advice from programmers often hurts as much as it helps.
4733 On my host (x86-64, Fedora 17, GCC 4.7.2, default 'configure'),
4734 this change shrinks the text size of the Emacs executable by 1.1%
4735 without affecting CPU significantly in my benchmark.
4736 * alloc.c (mem_find, live_string_p, live_cons_p, live_symbol_p)
4737 (live_float_p, live_misc_p, live_vector_p, live_buffer_p)
4738 (mark_maybe_object, mark_maybe_pointer, bounded_number):
4739 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
4740 (bset_auto_fill_function, bset_auto_save_file_format)
4741 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
4742 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
4743 (bset_cache_long_line_scans, bset_case_fold_search)
4744 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
4745 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
4746 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
4747 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
4748 (bset_header_line_format, bset_indicate_buffer_boundaries)
4749 (bset_indicate_empty_lines, bset_invisibility_spec)
4750 (bset_left_fringe_width, bset_major_mode, bset_mark)
4751 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
4752 (bset_name, bset_overwrite_mode, bset_pt_marker)
4753 (bset_right_fringe_width, bset_save_length)
4754 (bset_scroll_bar_width, bset_scroll_down_aggressively)
4755 (bset_scroll_up_aggressively, bset_selective_display)
4756 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
4757 (bset_word_wrap, bset_zv_marker, set_buffer_overlays_before)
4758 (set_buffer_overlays_after):
4759 * category.c (bset_category_table):
4760 * charset.c (read_hex):
4761 * coding.c (produce_composition, produce_charset)
4762 (handle_composition_annotation, handle_charset_annotation)
4763 (char_encodable_p):
4764 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers)
4765 (assign_row, set_frame_matrix_frame, make_current)
4766 (add_row_entry):
4767 * eval.c (set_specpdl_symbol, set_specpdl_old_value):
4768 * fns.c (maybe_resize_hash_table):
4769 * frame.c (fset_buffer_predicate, fset_minibuffer_window):
4770 * gmalloc.c (register_heapinfo):
4771 * image.c (lookup_image_type):
4772 * intervals.c (set_interval_object, set_interval_left)
4773 (set_interval_right, copy_interval_parent, rotate_right)
4774 (rotate_left, balance_possible_root_interval):
4775 * keyboard.c (kset_echo_string, kset_kbd_queue)
4776 (kset_keyboard_translate_table, kset_last_prefix_arg)
4777 (kset_last_repeatable_command, kset_local_function_key_map)
4778 (kset_overriding_terminal_local_map, kset_real_last_command)
4779 (kset_system_key_syms, clear_event, set_prop):
4780 * lread.c (digit_to_number):
4781 * marker.c (attach_marker, live_buffer, set_marker_internal):
4782 * nsterm.m (ns_compute_glyph_string_overhangs):
4783 * process.c (pset_buffer, pset_command)
4784 (pset_decode_coding_system, pset_decoding_buf)
4785 (pset_encode_coding_system, pset_encoding_buf, pset_filter)
4786 (pset_log, pset_mark, pset_name, pset_plist, pset_sentinel)
4787 (pset_status, pset_tty_name, pset_type, pset_write_queue):
4788 * syntax.c (bset_syntax_table, dec_bytepos):
4789 * terminal.c (tset_param_alist):
4790 * textprop.c (interval_has_some_properties)
4791 (interval_has_some_properties_list):
4792 * window.c (wset_combination_limit, wset_dedicated)
4793 (wset_display_table, wset_hchild, wset_left_fringe_width)
4794 (wset_left_margin_cols, wset_new_normal, wset_new_total)
4795 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
4796 (wset_right_fringe_width, wset_right_margin_cols)
4797 (wset_scroll_bar_width, wset_start, wset_temslot, wset_vchild)
4798 (wset_vertical_scroll_bar_type, wset_window_parameters):
4799 * xdisp.c (wset_base_line_number, wset_base_line_pos)
4800 (wset_column_number_displayed, wset_region_showing)
4801 (window_box_edges, run_window_scroll_functions)
4802 (append_glyph_string_lists, prepend_glyph_string_lists)
4803 (append_glyph_string, set_glyph_string_background_width)
4804 (append_glyph, append_composite_glyph)
4805 (take_vertical_position_into_account):
4806 * xfaces.c (x_create_gc, x_free_gc, merge_face_vectors)
4807 (face_attr_equal_p, lface_equal_p, hash_string_case_insensitive)
4808 (lface_hash, lface_same_font_attributes_p, lookup_face):
4809 * xml.c (libxml2_loaded_p):
4810 * xterm.c (x_set_mode_line_face_gc, x_set_glyph_string_gc)
4811 (x_set_glyph_string_clipping, x_clear_glyph_string_rect):
4812 Now 'static', not 'static inline'.
4813
05584c31
PE
4814 * bidi.c: Tune.
4815 (bidi_copy_it): Do the whole copy with a single memcpy.
4816 (bidi_char_at_pos): Merge the two STRING_CHAR calls into one.
4817
86ec63ba
PE
4818 Revert the FOLLOW-SYMLINKS change for file-attributes.
4819 Doing it right would require several changes to Tramp, and there's
4820 not enough time to get that tested before the freeze today.
4821 * dired.c (directory_files_internal, Ffile_attributes):
4822 Undo last change.
4823
82ef37c1
PE
4824 * frame.c (x_report_frame_params): Port better to wider ints.
4825 Do not assume that EMACS_UINT is the same width as uprintmax_t,
4826 or that pointers can be printed in 15 decimal digits.
4827 Avoid GCC warnings if EMACS_UINT is wider than a pointer.
4828
62aba0d4
FP
48292012-09-30 Fabrice Popineau <fabrice.popineau@supelec.fr>
4830
4831 Support x64 build on MS-Windows.
4832 * w32term.h (SCROLL_BAR_PACK, SCROLL_BAR_UNPACK): Define for x64.
4833 (SET_SCROLL_BAR_W32_WINDOW): Cast ID to intptr_t, for
4834 compatibility with x64.
5e4daaf3 4835 (x_get_focus_frame): Add prototype.
62aba0d4
FP
4836
4837 * w32term.c (w32_draw_underwave): Don't use GCC extensions for
4838 defining an XRectangle structure.
4839
4840 * w32proc.c (RVA_TO_PTR, w32_executable_type): Fix pointer
4841 arithmetics for compatibility with x64.
4842
4843 * w32menu.c (add_menu_item): Use UINT_PTR instead of UINT, for
4844 compatibility with x64.
4845
4846 * w32heap.h: Adjust prototypes and declarations.
4847
4848 * w32heap.c (RVA_TO_PTR, allocate_heap, sbrk, init_heap)
4849 (round_heap): Use DWORD_PTR, ptrdiff_t and size_t instead of
4850 DWORD, long, and unsigned long, for compatibility with x64.
4851 (allocate_heap) [_WIN64]: Reserve 32GB of memory.
4852 (sbrk): Argument is now of type ptrdiff_t.
4853
4854 * w32fns.c (HMONITOR): Condition declaration on _WIN32_WINNT being
4855 less than 0x0500.
4856 (w32_msg_pump): Use WPARAM type for 'result'.
4857
4858 * w32.c (init_environment, get_emacs_configuration): Support AMD64
4859 architecture.
4860 (init_ntproc): Cast arguments of _open_osfhandle to intptr_t, for
4861 compatibility with x64.
4862
4863 * vm-limit.c (lim_data): Now size_t.
4864 (check_memory_limits): Adjust prototypes of real_morecore and
4865 __morecore to receive argument of type ptrdiff_t. Use size_t for
4866 five_percent and data_size.
4867
4868 * unexw32.c: Use DWORD_PTR instead of DWORD for file-scope
4869 variables, for compatibility with x64.
4870 (rva_to_section, offset_to_section, relocate_offset)
4871 (OFFSET_TO_RVA, RVA_TO_OFFSET, RVA_TO_SECTION_OFFSET)
4872 (PTR_TO_RVA, RVA_TO_PTR, OFFSET_TO_PTR, get_section_info)
4873 (copy_executable_and_dump_data): Use DWORD_PTR instead of DWORD
4874 for compatibility with x64.
4875
4876 * sysdep.c (STDERR_FILENO): Define if not already defined.
4877
4878 * ralloc.c (real_morecore): Argument type is now ptrdiff_t.
4879 (__morecore): Argument type is now ptrdiff_t.
4880 (ROUNDUP, MEM_ROUNDUP): Use size_t instead of 'unsigned long'.
4881 (relinquish): Use ptrdiff_t type for 'excess'.
4882 (r_alloc_sbrk): Argument type is now ptrdiff_t.
4883
4884 * makefile.w32-in (HEAPSIZE): Get value from EMACS_HEAPSIZE.
4885 (bootstrap-temacs-CMD, bootstrap-temacs-SH): Use $(EMACS_PURESIZE)
4886 instead of a literal number.
4887
4888 * gmalloc.c [WINDOWSNT]: Include w32heap.h.
4889 (min): Define only if not already defined.
4890
4891 * frame.c (x_report_frame_params): Use EMACS_UINT for the return
4892 value of FRAME_X_WINDOW, to fit a 64-bit pointer on 64-bit Windows
4893 hosts.
4894
4895 * image.c (x_bitmap_pixmap): Return ptrdiff_t, not int, since
4896 'bitmaps' is a pointer.
4897
4898 * dispextern.h (x_bitmap_pixmap): Adjust prototype.
4899
4900 * alloc.c (gdb_make_enums_visible): Now conditional on __GNUC__.
4901
e7a2937b
PE
49022012-09-30 Paul Eggert <eggert@cs.ucla.edu>
4903
4904 file-attributes has a new optional arg FOLLOW-SYMLINKS.
4905 * dired.c (directory_files_internal, Ffile_attributes):
4906 New arg follow_symlinks. All uses changed.
4907
b43d62ae
SM
49082012-09-30 Stefan Monnier <monnier@iro.umontreal.ca>
4909
4910 * .gdbinit (xbacktrace): Adjust to recent "struct backtrace" change.
4911
c06c382a
EZ
49122012-09-30 Eli Zaretskii <eliz@gnu.org>
4913
4914 Support atimers and CPU profiler via profile.c on MS-Windows.
4915 * w32proc.c (sig_mask, crit_sig): New static variables.
4916 (sys_signal): Support SIGALRM and SIGPROF.
4917 (sigemptyset, sigaddset, sigfillset, sigprocmask)
b43d62ae 4918 (pthread_sigmask, setpgrp): Move here from w32.c. sigaddset,
c06c382a
EZ
4919 sigfillset, and sigprocmask are no longer no-ops.
4920 (sigismember): New function.
4921 (struct itimer_data): New definition.
4922 (ticks_now, real_itimer, prof_itimer, clocks_min, crit_real)
4923 (crit_prof): New static variables.
4924 (MAX_SINGLE_SLEEP): New definition.
4925 (timer_loop, stop_timer_thread, term_timers, init_timers)
4926 (start_timer_thread, getitimer, setitimer): New functions.
4927 (alarm): No longer a no-op, calls setitimer.
4928
4929 * w32.c (term_ntproc): Call term_timers.
4930 (init_ntproc): Make sure all signals are unblocked at startup, to
4931 erase any traces of dumping. Call init_timers.
4932
4933 * w32fns.c (hourglass_timer, HOURGLASS_ID): Remove.
4934 Windows-specific code to display the hourglass mouse pointer is no
4935 longer used.
4936 (w32_wnd_proc): Remove code that handled the WM_TIMER message due
4937 to hourglass timer expiration.
4938 (start_hourglass, cancel_hourglass, DEFAULT_HOURGLASS_DELAY):
4939 Remove, no longer used.
b43d62ae
SM
4940 (w32_note_current_window, show_hourglass, hide_hourglass):
4941 New functions, in support of hourglass cursor display similar to other
c06c382a
EZ
4942 window systems.
4943 (syms_of_w32fns): Don't initialize hourglass_timer.
4944
4945 * xdisp.c (start_hourglass, cancel_hourglass): Now used on
4946 WINDOWSNT as well.
4947 (start_hourglass) [WINDOWSNT]: Call w32_note_current_window.
4948
4949 * w32.h (init_timers, term_timers): Add prototypes.
4950
95402d5f
KH
49512012-09-30 Kenichi Handa <handa@gnu.org>
4952
4953 * coding.c (decode_coding_ccl, encode_coding_ccl): Pay attention
4954 to the buffer relocation which may be caused by ccl_driver.
4955
dd946752
JD
49562012-09-30 Jan Djärv <jan.h.d@swipnet.se>
4957
d7e642cc
JD
4958 * xfns.c (Fx_file_dialog): Update comment.
4959
4960 * w32fns.c (Fx_file_dialog): Update comment.
4961
4962 * nsfns.m (Fns_read_file_name): Add argument DIR_ONLY_P.
4963 Initialize panel name field if OSX >= 10.6.
4964
4965 * fileio.c (Fnext_read_file_uses_dialog_p): Add HAVE_NS.
4966
dd946752
JD
4967 * nsfns.m (ns_frame_parm_handlers): Add x_set_fullscreen.
4968
4969 * nsterm.m (NEW_STYLE_FS): New define.
4970 (ns_fullscreen_hook, windowWillEnterFullScreen)
4971 (windowDidEnterFullScreen, windowWillExitFullScreen)
4972 (windowDidExitFullScreen, toggleFullScreen, handleFS)
4973 (setFSValue): New functions.
4974 (EmacsFSWindow): New implementation.
4975 (canBecomeKeyWindow): New function for EmacsFSWindow.
4976 (ns_create_terminal): Set fullscreen_hook to ns_fullscreen_hook.
4977 (dealloc): Release nonfs_window if in fullscreen.
4978 (updateFrameSize:): Call windowDidMove to update top/left.
4979 (windowWillResize:toSize:): Check if frame is still maximized.
4980 (initFrameFromEmacs:): Initialize fs_state, fs_before_fs,
4981 next_maximized, maximized_width, maximized_height and nonfs_window.
4982 Call setCollectionBehavior if NEW_STYLE_FS. Initialize bwidth and
4983 tbar_height.
4984 (windowWillUseStandardFrame:defaultFrame:): Update frame parameter
1f9f395d 4985 fullscreen. Set maximized_width/height. Act on next_maximized.
dd946752
JD
4986
4987 * nsterm.h (MAC_OS_X_VERSION_10_7, MAC_OS_X_VERSION_10_8): New.
4988 (EmacsView): Add variables for fullscreen.
4989 (handleFS, setFSValue, toggleFullScreen): New in EmacsView.
4990 (EmacsFSWindow): New interface for fullscreen.
4991
427730eb
JB
49922012-09-30 Juanma Barranquero <lekktu@gmail.com>
4993
4994 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
4995
48de8b12
CY
49962012-09-30 Chong Yidong <cyd@gnu.org>
4997
4998 * fns.c (Frandom): Doc fix.
4999
5938d519
MR
50002012-09-30 Martin Rudalics <rudalics@gmx.at>
5001
5002 * window.c (Vwindow_combination_limit): New default value.
5003 (Qwindow_size): New symbol replacing Qtemp_buffer_resize.
5004
cb5b0266
PE
50052012-09-30 Paul Eggert <eggert@cs.ucla.edu>
5006
5007 * syssignal.h (PROFILER_CPU_SUPPORT): Don't define if PROFILING.
5008 Suggested by Eli Zaretskii in
5009 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00811.html>.
5010
84f72efd
EZ
50112012-09-30 Eli Zaretskii <eliz@gnu.org>
5012
5013 * profiler.c (Fprofiler_cpu_stop): Use timer_settime only if
5014 HAVE_TIMER_SETTIME is defined.
5015
9d4dcdc9
PE
50162012-09-30 Paul Eggert <eggert@cs.ucla.edu>
5017
d89460ed
PE
5018 Profiler improvements: more-accurate timers, overflow checks.
5019 * profiler.c: Don't include stdio.h, limits.h, sys/time.h,
5020 signal.h, setjmp.h. Include systime.h instead.
5021 (saturated_add): New function.
5022 (record_backtrace, current_sample_interval): Use EMACS_INT, not size_t.
5023 (record_backtrace, handle_profiler_signal): Saturate on fixnum overflow.
5024 (profiler_timer, profiler_timer_ok) [HAVE_TIMER_SETTIME]:
5025 New static vars.
84f72efd 5026 (enum profiler_cpu_running): New enum.
d89460ed
PE
5027 (profiler_cpu_running): Now of that enum type, not bool.
5028 All uses changed to store the new value.
5029 (handle_profiler_signal): Rename from sigprof_handler_1,
5030 for consistency with other handlers. Do not check whether
5031 cpu_log is a hash-table if garbage collecting, since it
5032 doesn't matter in that case.
5033 (deliver_profiler_signal): Rename from sigprof_handler,
5034 for consistency with other handlers.
5035 (setup_cpu_timer): New function, with much of what used to be in
5036 Fprofiler_cpu_start. Check for out-of-range argument.
5037 Prefer timer_settime if available, and prefer
5038 thread cputime clocks, then process cputime clocks, then
5039 monotonic clocks, to the old realtime clock. Use make_timeval
5040 to round more-correctly when falling back to setitimer.
5041 (Fprofiler_cpu_start): Use it.
5042 (Fprofiler_cpu_stop): Prefer timer_settime if available.
5043 Don't assume that passing NULL as the 2nd argument of setitimer
5044 is the same as passing a pointer to all-zero storage.
5045 Ignore SIGPROF afterwards.
5046 (malloc_probe): Saturate at MOST_POSITIVE_FIXNUM.
5047 * sysdep.c (emacs_sigaction_init): Also mask out SIGPROF in
5048 non-fatal signal handlers. Ignore SIGPROF on startup.
5049 * syssignal.h (PROFILER_CPU_SUPPORT): Define this macro here, not
5050 in profiler.c, since sysdep.c now uses it.
5051
9d4dcdc9
PE
5052 * sysdep.c (handle_fatal_signal): Bump backtrace size to 40.
5053 Suggested by Eli Zaretskii in
5054 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00796.html>.
5055
8e5691a0
JB
50562012-09-29 Juanma Barranquero <lekktu@gmail.com>
5057
5058 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
5059
e7c1b6ef
SM
50602012-09-29 Stefan Monnier <monnier@iro.umontreal.ca>
5061
5062 * lisp.h (struct backtrace): Remove indirection for `function' field.
5063 * xdisp.c (redisplay_internal):
5064 * profiler.c (record_backtrace, sigprof_handler_1):
5065 * alloc.c (Fgarbage_collect):
5066 * eval.c (interactive_p, Fsignal, eval_sub, Ffuncall, Fbacktrace)
5067 (Fbacktrace_frame): Adjust accordingly.
5068
e61d39cd 50692012-09-28 Glenn Morris <rgm@gnu.org>
d393cefb
GM
5070
5071 * eval.c (Frun_hook_with_args, Frun_hook_with_args_until_success)
5072 (Frun_hook_with_args_until_failure): Doc fixes.
5073
404043ea
EZ
50742012-09-28 Eli Zaretskii <eliz@gnu.org>
5075
5076 * xdisp.c (syms_of_xdisp) <Qredisplay_internal>: Rename from
5077 Qautomatic_redisplay and change the symbol name. All users changed.
5078
704d3f45
TM
50792012-09-28 Tomohiro Matsuyama <tomo@cx4a.org>
5080
5081 * profiler.c (sigprof_handler): Fix race condition.
5082
757140ff
GM
50832012-09-28 Glenn Morris <rgm@gnu.org>
5084
5085 * lread.c (lisp_file_lexically_bound_p): Handle #! lines. (Bug#12528)
5086
a615a3ae
PE
50872012-09-27 Paul Eggert <eggert@cs.ucla.edu>
5088
5089 Check more robustly for timer_settime.
89d17fd0
PE
5090 * Makefile.in (LIB_TIMER_TIME): New macro.
5091 (LIBES): Add it.
a615a3ae
PE
5092 * atimer.c (alarm_timer, alarm_timer_ok, set_alarm, init_atimer):
5093 Use HAVE_TIMER_SETTIME, not SIGEV_SIGNAL, to decide whether to
5094 call timer_settime.
5095
3670daf7
TM
50962012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
5097
5098 * profiler.c (Fprofiler_cpu_start): Remove unnecessary flag SA_SIGINFO.
5099
6a586b7f
JB
51002012-09-26 Juanma Barranquero <lekktu@gmail.com>
5101
5102 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
5103
41c8bfcf
PE
51042012-09-26 Paul Eggert <eggert@cs.ucla.edu>
5105
5106 * character.h (MAYBE_UNIFY_CHAR): Remove.
5107 * charset.c, charset.h (maybe_unify_char): Now static.
5108 * charset.c (decode_char): Use maybe_unify_char, not MAYBE_UNIFY_CHAR.
5109 Since this stuff is now private to charset.c, there's no need for
5110 a public macro and no need to inline by hand.
5111
3a880af4
SM
51122012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
5113 Stefan Monnier <monnier@iro.umontreal.ca>
5114 Juanma Barranquero <lekktu@gmail.com>
611b7507 5115
3a880af4
SM
5116 * profiler.c: New file.
5117 * Makefile.in (base_obj): Add profiler.o.
611b7507
JB
5118 * makefile.w32-in (OBJ2, GLOBAL_SOURCES): Add profiler.c.
5119 ($(BLD)/profiler.$(O)): New target.
3a880af4
SM
5120 * emacs.c (main): Call syms_of_profiler.
5121 * alloc.c (Qautomatic_gc): New constant.
5122 (MALLOC_PROBE): New macro.
5123 (xmalloc, xzalloc, xrealloc, lisp_malloc, lisp_align_malloc): Use it.
5124 (total_bytes_of_live_objects): New function.
5125 (Fgarbage_collect): Use it. Record itself in backtrace_list.
5126 Call malloc_probe for the memory profiler.
5127 (syms_of_alloc): Define Qautomatic_gc.
5128 * eval.c (eval_sub, Ffuncall): Reorder assignments to avoid
5129 race condition.
5130 (struct backtrace): Move definition...
5131 * lisp.h (struct backtrace): ..here.
5132 (Qautomatic_gc, profiler_memory_running): Declare vars.
5133 (malloc_probe, syms_of_profiler): Declare functions.
5134 * xdisp.c (Qautomatic_redisplay): New constant.
5135 (redisplay_internal): Record itself in backtrace_list.
5136 (syms_of_xdisp): Define Qautomatic_redisplay.
611b7507 5137
5938d519 51382012-09-25 Eli Zaretskii <eliz@gnu.org>
b67238c2
JB
51392012-09-25 Juanma Barranquero <lekktu@gmail.com>
5140
5141 * makefile.w32-in ($(BLD)/callproc.$(O)): Update dependencies.
5142
e26fd2e4
PE
51432012-09-25 Paul Eggert <eggert@cs.ucla.edu>
5144
5145 Prefer POSIX timers if available.
5146 They avoid a race if the timer is too close to the current time.
5147 * atimer.c (alarm_timer, alarm_timer_ok) [SIGEV_SIGNAL]: New static vars.
5148 (set_alarm) [SIGEV_SIGNAL]: Use POSIX timers if available.
9180598c 5149 (init_atimer) [SIGEV_SIGNAL]: Initialize them.
e26fd2e4 5150
eedec3ee
EZ
51512012-09-25 Eli Zaretskii <eliz@gnu.org>
5152
5153 * coding.c (CHAR_STRING_ADVANCE_NO_UNIFY): Make it an alias of
5154 CHAR_STRING_ADVANCE.
5155 (STRING_CHAR_ADVANCE_NO_UNIFY): Make it an alias of
5156 STRING_CHAR_ADVANCE.
5157
aa15c6bb
JB
51582012-09-25 Juanma Barranquero <lekktu@gmail.com>
5159
5160 Move Vlibrary_cache to emacs.c and reset before dumping.
5161
5162 * lisp.h (reset_image_types): Declare.
5163 [WINDOWSNT] (Vlibrary_cache): Declare.
5164
5165 * image.c (reset_image_types): New function.
5166
5167 * emacs.c [WINDOWSNT] (Vlibrary_cache): Move from w32.c.
5168 (syms_of_emacs) [WINDOWSNT] <Vlibrary_cache>: Initialize and staticpro.
5169 (Fdump_emacs): Reset Vlibrary_cache and image_types.
5170
5171 * w32.c (Vlibrary_cache): Do not define; moved to emacs.c
5172 (globals_of_w32) <Vlibrary_cache>: Do not initialize.
5173
5174 * w32.h (Vlibrary_cache): Do not declare.
5175
54d629be
EZ
51762012-09-25 Eli Zaretskii <eliz@gnu.org>
5177
16b22fef
EZ
5178 * w32proc.c (sys_signal): Handle all signals defined by the
5179 MS-Windows runtime, not just SIGCHLD. Actually install the signal
5180 handlers for signals supported by Windows. Don't override
5181 term_ntproc as the handler for SIGABRT.
5182 (sigaction): Rewrite to call sys_signal instead of duplicating its
5183 code.
5184 (sys_kill): Improve commentary.
5185
5186 * w32.c (term_ntproc): Accept (and ignore) one argument, for
5187 consistency with a signature of a signal handler. All callers
5188 changed.
5189 (init_ntproc): Accept an argument DUMPING. If dumping, don't
5190 install term_ntproc as a signal handler for SIGABRT, as that
5191 should be done by the dumped Emacs.
5192
5193 * w32.h (init_ntproc, term_ntproc): Adjust prototypes.
5194
5195 * w32select.c (term_w32select): Protect against repeated
5196 invocation by setting clipboard_owner to NULL after calling
5197 DestroyWindow.
5198
5199 * emacs.c (shut_down_emacs, main): Adapt the calls to init_ntproc
5200 and term_ntproc to their modified signatures.
5201
54d629be
EZ
5202 * character.c (char_string, string_char): Remove calls to
5203 MAYBE_UNIFY_CHAR. See the discussion starting at
5204 http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00433.html
5205 for the details.
5206
59f7af81
CY
52072012-09-25 Chong Yidong <cyd@gnu.org>
5208
5209 * xdisp.c (mode_line_inverse_video): Delete obsolete variable.
5210
22e8cf4a
SM
52112012-09-24 Stefan Monnier <monnier@iro.umontreal.ca>
5212
5213 * bytecode.c (exec_byte_code): Signal an error instead of aborting,
5214 when encountering an unknown bytecode.
5215
578098f3
PE
52162012-09-24 Paul Eggert <eggert@cs.ucla.edu>
5217
5218 image.c, indent.c: Use bool for booleans.
5219 * dispextern.h (struct image_type): Members valid_p, load, init
5220 now return bool, not int. All uses changed.
5221 * image.c: Omit unnecessary static decls.
5222 (x_create_bitmap_mask, x_build_heuristic_mask):
5223 Return void, not int, since callers don't care about the return value.
5224 (x_create_bitmap_mask, define_image_type, valid_image_p)
5225 (struct image_keyword, parse_image_spec, image_spec_value)
5226 (check_image_size, image_background)
5227 (image_background_transparent, x_clear_image_1)
5228 (postprocess_image, lookup_image, x_check_image_size)
5229 (x_create_x_image_and_pixmap, xbm_image_p)
5230 (Create_Pixmap_From_Bitmap_Data, xbm_read_bitmap_data)
5231 (xbm_load_image, xbm_file_p, xbm_load, xpm_lookup_color)
5232 (init_xpm_functions, xpm_valid_color_symbols_p, xpm_image_p)
5233 (xpm_load, xpm_load_image, lookup_rgb_color, lookup_pixel_color)
5234 (x_to_xcolors, x_build_heuristic_mask, pbm_image_p, pbm_load)
5235 (png_image_p, init_png_functions, png_load_body, png_load)
5236 (jpeg_image_p, init_jpeg_functions, jpeg_load_body, jpeg_load)
5237 (tiff_image_p, init_tiff_functions, tiff_load, gif_image_p)
5238 (init_gif_functions, gif_load, imagemagick_image_p)
5239 (imagemagick_load_image, imagemagick_load, svg_image_p)
5240 (init_svg_functions, svg_load, svg_load_image, gs_image_p)
5241 (gs_load):
5242 * nsimage.m (ns_load_image):
5243 * nsterm.m (ns_defined_color):
5244 * xfaces.c (tty_lookup_color, tty_defined_color, defined_color):
5245 * xfns.c (x_defined_color):
5246 * xterm.c (x_alloc_lighter_color_for_widget)
5247 (x_alloc_nearest_color_1, x_alloc_nearest_color)
5248 (x_alloc_lighter_color):
5249 * indent.c (disptab_matches_widthtab, current_column)
5250 (scan_for_column, string_display_width, indented_beyond_p)
5251 (compute_motion, vmotion, Fvertical_motion):
5252 Use bool for booleans.
5253
a5f2b6ec
CY
52542012-09-24 Chong Yidong <cyd@gnu.org>
5255
5256 * chartab.c (Fset_char_table_default): Obsolete function removed.
5257
18e27ea8
PE
52582012-09-23 Paul Eggert <eggert@cs.ucla.edu>
5259
afea8a8a
PE
5260 Move pid_t related decls out of lisp.h.
5261 * lisp.h, syswait.h (record_child_status_change, wait_for_termination)
5262 (interruptible_wait_for_termination):
5263 Move these decls from lisp.h to syswait.h, since they use pid_t.
5264 Needed on FreeBSD; see Herbert J. Skuhra in
5265 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00571.html>.
5266 * callproc.c: Include syswait.h.
5267
18e27ea8
PE
5268 gnutls.c, gtkutil.c: Use bool for boolean.
5269 * gnutls.c (gnutls_global_initialized, init_gnutls_functions)
5270 (emacs_gnutls_handle_error):
5271 * gtkutil.c (xg_check_special_colors, xg_prepare_tooltip)
5272 (xg_hide_tooltip, xg_create_frame_widgets)
5273 (create_dialog, xg_uses_old_file_dialog)
5274 (xg_get_file_with_chooser, xg_get_file_with_selection)
5275 (xg_get_file_name, xg_have_tear_offs, create_menus, xg_create_widget)
5276 (xg_item_label_same_p, xg_update_menubar)
5277 (xg_modify_menubar_widgets, xg_event_is_for_menubar)
5278 (xg_ignore_gtk_scrollbar, xg_set_toolkit_scroll_bar_thumb)
5279 (xg_event_is_for_scrollbar, xg_pack_tool_bar, xg_make_tool_item)
5280 (is_box_type, xg_tool_item_stale_p, xg_update_tool_bar_sizes)
5281 (update_frame_tool_bar, free_frame_tool_bar):
5282 * gtkutil.c, w32term.c, xterm.c (x_wm_set_size_hint):
5283 * nsmenu.m (ns_update_menubar):
5284 * nsmenu.m, w32menu.c, xmenu.c (set_frame_menubar):
5285 * xfns.c (Fx_show_tip) [USE_GTK]:
5286 Use bool for boolean.
5287 * gtkutil.c (xg_update_frame_menubar):
5288 * xmenu.c (update_frame_menubar):
5289 Return void, not int, since caller ignores return value.
5290 * gtkutil.c (xg_change_toolbar_position):
5291 Return void, not 1.
5292
af0e9f75
JB
52932012-09-23 Juanma Barranquero <lekktu@gmail.com>
5294
5295 * makefile.w32-in (BLOCKINPUT_H): Remove.
5296 (SYSSIGNAL_H): New macro.
5297 ($(BLD)/alloc.$(O), $(BLD)/atimer.$(O), $(BLD)/buffer.$(O))
5298 ($(BLD)/callproc.$(O), $(BLD)/data.$(O), $(BLD)/dired.$(O))
5299 ($(BLD)/dispnew.$(O), $(BLD)/editfns.$(O), $(BLD)/emacs.$(O))
5300 ($(BLD)/eval.$(O), $(BLD)/fileio.$(O), $(BLD)/floatfns.$(O))
5301 ($(BLD)/fns.$(O), $(BLD)/fontset.$(O), $(BLD)/frame.$(O))
5302 ($(BLD)/fringe.$(O), $(BLD)/image.$(O), $(BLD)/insdel.$(O))
5303 ($(BLD)/keyboard.$(O), $(BLD)/keymap.$(O), $(BLD)/lread.$(O))
5304 ($(BLD)/menu.$(O), $(BLD)/w32inevt.$(O), $(BLD)/w32proc.$(O))
5305 ($(BLD)/print.$(O), $(BLD)/process.$(O), $(BLD)/ralloc.$(O))
5306 ($(BLD)/search.$(O), $(BLD)/sound.$(O), $(BLD)/sysdep.$(O))
5307 ($(BLD)/term.$(O), $(BLD)/window.$(O), $(BLD)/xdisp.$(O))
5308 ($(BLD)/xfaces.$(O), $(BLD)/w32fns.$(O), $(BLD)/w32menu.$(O))
5309 ($(BLD)/w32term.$(O), $(BLD)/w32select.$(O), $(BLD)/w32reg.$(O))
5310 ($(BLD)/w32xfns.$(O)): Update dependencies.
5311
5101529e
EZ
53122012-09-23 Eli Zaretskii <eliz@gnu.org>
5313
5314 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
5315 fatal_error_backtrace.
5316
5317 * w32proc.c (sys_kill): Undo last change: don't do anything when
5318 invoked to deliver SIGABRT to our own process. This is now
5319 handled by emacs_raise.
5320
2c3ee0ad
JB
53212012-09-23 Juanma Barranquero <lekktu@gmail.com>
5322
5323 * w32term.c (w32_read_socket): Remove leftover reference to
5324 interrupt_input_pending.
5325
62a1d661
PE
53262012-09-23 Paul Eggert <eggert@cs.ucla.edu>
5327
5328 Do not use SA_NODEFER.
5329 Problem reported by Dani Moncayo in
5330 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00557.html>.
5331 * alloc.c (die):
5332 * sysdep.c (emacs_abort): Do not reset signal handler.
5333 * emacs.c (terminate_due_to_signal): Reset signal handler here.
5334 * sysdep.c (init_signals): Do not use SA_NODEFER. It wasn't
5335 wanted even on POSIXish hosts, and it doesn't work on Windows.
5336
a0942b9a
JD
53372012-09-23 Jan Djärv <jan.h.d@swipnet.se>
5338
5339 * xterm.c (x_term_init): Call fixup_locale before and after calling
5340 gtk_init (Bug#12392).
5341
d07ff9db
CY
53422012-09-23 Chong Yidong <cyd@gnu.org>
5343
5344 * w32.c (w32_delayed_load): Remove LIBRARIES argument; always use
5345 Vdynamic_library_alist.
5346
5347 * gnutls.c (init_gnutls_functions): Caller changed; remove arg.
5348 (Fgnutls_available_p): Caller changed.
5349
5350 * xml.c (init_libxml2_functions, Flibxml_parse_html_region)
5351 (Flibxml_parse_xml_region): Likewise.
5352
5353 * dispextern.h (struct image_type): Remove arg from init function.
5354
5355 * image.c (Finit_image_library, lookup_image_type)
5356 (define_image_type): Remove now-unneeded second arg.
5357 (init_xpm_functions, init_png_functions, init_jpeg_functions)
5358 (init_tiff_functions, init_gif_functions, init_svg_functions):
5359 Arglist and w32_delayed_load calling convention changed.
5360 (gs_type): Remove init_gs_functions; there is no such function.
641cfd14 5361 (valid_image_p, make_image): Fix caller to lookup_image_type.
d07ff9db 5362
4d7e6e51
PE
53632012-09-23 Paul Eggert <eggert@cs.ucla.edu>
5364
5365 Simplify and avoid signal-handling races (Bug#12471).
5366 * alloc.c (die):
5367 * sysdep.c (emacs_abort) [HAVE_NTGUI]:
5368 Avoid recursive loop if there's a fatal error in the function itself.
5369 * atimer.c (pending_atimers):
5370 * blockinput.h: Don't include "atimer.h"; no longer needed.
5371 (interrupt_input_pending): Remove. All uses removed.
5372 pending_signals now counts both atimers and ordinary interrupts.
5373 This is less racy than having three separate pending-signal flags.
5374 (block_input, unblock_input, totally_unblock_input, unblock_input_to)
5375 (input_blocked_p):
5376 Rename from their upper-case counterparts BLOCK_INPUT,
5377 UNBLOCK_INPUT, TOTALLY_UNBLOCK_INPUT, UNBLOCK_INPUT_TO,
5378 INPUT_BLOCKED_P, and turn into functions. All uses changed.
5379 This makes it easier to access volatile variables more accurately.
5380 (BLOCK_INPUT_RESIGNAL): Remove. All uses replaced by unblock_input ().
5381 (input_blocked_p): Prefer this to 'interrupt_input_blocked', as
5382 that's more reliable if the code is buggy and sets
5383 interrupt_input_blocked to a negative value. All uses changed.
5384 * atimer.c (deliver_alarm_signal):
5385 Remove. No need to deliver this to the parent; any thread can
5386 handle this signal now. All uses replaced by underlying handler.
5387 * atimer.c (turn_on_atimers):
5388 * dispnew.c (handle_window_change_signal):
5389 * emacs.c (handle_danger_signal):
5390 * keyboard.c (kbd_buffer_get_event):
5391 Don't reestablish signal handler; not needed with sigaction.
5392 * blockinput.h (UNBLOCK_INPUT_TO, TOTALLY_UNBLOCK_INPUT)
5393 (UNBLOCK_INPUT_TO):
5394 Rework to avoid unnecessary accesses to volatile variables.
5395 (UNBLOCK_INPUT_TO): Now a function.
5396 (totally_unblock_input, unblock_input): New decls.
5397 * data.c (handle_arith_signal, deliver_arith_signal): Move to sysdep.c
5398 (init_data): Remove. Necessary stuff now done in init_signal.
5399 * emacs.c, xdisp.c: Include "atimer.h", since we invoke atimer functions.
5400 * emacs.c (handle_fatal_signal, deliver_fatal_signal): Move to sysdep.c.
5401 (fatal_error_code): Remove; no longer needed.
5402 (terminate_due_to_signal): Rename from fatal_error_backtrace, since
5403 it doesn't always backtrace. All uses changed. No need to reset
5404 signal to default, since sigaction and/or die does that for us now.
5405 Use emacs_raise (FOO), not kill (getpid (), FOO).
5406 (main): Check more-accurately whether we're dumping.
5407 Move fatal-error setup to sysdep.c
5408 * floatfns.c: Do not include "syssignal.h"; no longer needed.
5409 * gtkutil.c (xg_get_file_name, xg_get_font):
5410 Remove no-longer-needed signal-mask manipulation.
5411 * keyboard.c, process.c (POLL_FOR_INPUT):
5412 Don't depend on USE_ASYNC_EVENTS, a symbol that is never defined.
5413 * keyboard.c (read_avail_input): Remove.
5414 All uses replaced by gobble_input.
5415 (Ftop_level): Use TOTALLY_UNBLOCK_INPUT rather than open code.
5416 (kbd_buffer_store_event_hold, gobble_input):
5417 (record_asynch_buffer_change) [USABLE_SIGIO]:
5418 (store_user_signal_events):
5419 No need to mess with signal mask.
5420 (gobble_input): If blocking input and there are terminals, simply
5421 set pending_signals to 1 and return. All hooks changed to not
5422 worry about whether input is blocked.
5423 (process_pending_signals): Clear pending_signals before processing
5424 them, in case a signal comes in while we're processing.
5425 By convention callers now test pending_signals before calling us.
5426 (UNBLOCK_INPUT_TO, unblock_input, totally_unblock_input):
5427 New functions, to support changes to blockinput.h.
5428 (handle_input_available_signal): Now extern.
5429 (reinvoke_input_signal): Remove. All uses replaced by
5430 handle_async_input.
5431 (quit_count): Now volatile, since a signal handler uses it.
3a880af4
SM
5432 (handle_interrupt): Now takes bool IN_SIGNAL_HANDLER as arg.
5433 All callers changed. Block SIGINT only if not already blocked.
4d7e6e51
PE
5434 Clear sigmask reliably, even if Fsignal returns, which it can.
5435 Omit unnecessary accesses to volatile var.
5436 (quit_throw_to_read_char): No need to restore sigmask.
5437 * keyboard.c (gobble_input, handle_user_signal):
5438 * process.c (wait_reading_process_output):
5439 Call signal-handling code rather than killing ourselves.
5440 * lisp.h: Include <float.h>, for...
5441 (IEEE_FLOATING_POINT): New macro, moved here to avoid duplication.
5442 (pending_signals): Now volatile.
5443 (syms_of_data): Now const if IEEE floating point.
5444 (handle_input_available_signal) [USABLE_SIGIO]:
5445 (terminate_due_to_signal, record_child_status_change): New decls.
5446 * process.c (create_process): Avoid disaster if memory is exhausted
5447 while we're processing a vfork, by tightening the critical section
5448 around the vfork.
5449 (send_process_frame, process_sent_to, handle_pipe_signal)
5450 (deliver_pipe_signal): Remove. No longer needed, as Emacs now
5451 ignores SIGPIPE.
5452 (send_process): No need for setjmp/longjmp any more, since the
5453 SIGPIPE stuff is now gone. Instead, report an error if errno
5454 is EPIPE.
5455 (record_child_status_change): Now extern. PID and W are now args.
5456 Return void, not bool. All callers changed.
5457 * sysdep.c (wait_debugging) [(BSD_SYSTEM || HPUX) && !defined (__GNU__)]:
5458 Remove. All uses removed. This bug should be fixed now in a
5459 different way.
5460 (wait_for_termination_1): Use waitpid rather than sigsuspend,
5461 and record the child status change directly. This avoids the
5462 need to futz with the signal mask.
5463 (process_fatal_action): Move here from emacs.c.
5464 (emacs_sigaction_flags): New function, containing
5465 much of what used to be in emacs_sigaction_init.
5466 (emacs_sigaction_init): Use it. Block nonfatal system signals that are
5467 caught by emacs, to make races less likely.
5468 (deliver_process_signal): Rename from handle_on_main_thread.
5469 All uses changed.
5470 (BACKTRACE_LIMIT_MAX): Now at top level.
5471 (thread_backtrace_buffer, threadback_backtrace_pointers):
5472 New static vars.
5473 (deliver_thread_signal, deliver_fatal_thread_signal):
5474 New functions, for more-accurate delivery of thread-specific signals.
5475 (handle_fatal_signal, deliver_fatal_signal): Move here from emacs.c.
5476 (deliver_arith_signal): Handle in this thread, not
5477 in the main thread, since it's triggered by this thread.
5478 (maybe_fatal_sig): New function.
5479 (init_signals): New arg DUMPING so that we can be more accurate
5480 about whether we're dumping. Caller changed.
5481 Treat thread-specific signals differently from process-general signals.
5482 Block all signals while handling fatal error; that's safer.
5483 xsignal from SIGFPE only on non-IEEE hosts, treating it as fatal
5484 on IEEE hosts.
5485 When batch, ignore SIGHUP, SIGINT, SIGTERM if they were already ignored.
5486 Ignore SIGPIPE unless batch.
5487 (emacs_backtrace): Output backtrace for the appropriate thread,
5488 which is not necessarily the main thread.
5489 * syssignal.h: Include <stdbool.h>.
5490 (emacs_raise): New macro.
5491 * xterm.c (x_connection_signal): Remove; no longer needed
5492 now that we use sigaction.
5493 (x_connection_closed): No need to mess with sigmask now.
5494 (x_initialize): No need to reset SIGPIPE handler here, since
5495 init_signals does this for us now.
5496
8f4635e9
JD
54972012-09-23 Jan Djärv <jan.h.d@swipnet.se>
5498
5499 * nsterm.m (ns_dumpglyphs_image): dr is a new rect to draw image into,
fb39b937 5500 background rect may be larger (Bug#12245).
8f4635e9 5501
3296976d
CY
55022012-09-23 Chong Yidong <cyd@gnu.org>
5503
5504 * keyboard.c (timer_check): Avoid quitting during Fcopy_sequence.
5505
d41e491e
PE
55062012-09-22 Paul Eggert <eggert@cs.ucla.edu>
5507
5508 * .gdbinit: Just stop at fatal_error_backtrace.
5509 See Stefan Monnier's request in
5510 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00549.html>.
5511 Remove no-longer-used query of system type.
5512
c88b867f
CY
55132012-09-22 Chong Yidong <cyd@gnu.org>
5514
5515 * search.c (Freplace_match): Doc fix (Bug#12325).
5516
5517 * minibuf.c (Finternal_complete_buffer): Doc fix (Bug#12391).
5518
5519 * editfns.c (Fline_beginning_position): Doc fix (Bug#12416).
5520 (Fline_end_position): Doc fix.
5521
5522 * cmds.c (Fforward_char, Fbackward_char): Doc fix (Bug#12414).
5523
bb4d86b4
CY
55242012-09-22 Chong Yidong <cyd@gnu.org>
5525
5526 * dispextern.h (struct image_type): Add new slot, storing a type
5527 initialization function.
5528
5529 * image.c (define_image_type): Call the image initializer function
5530 if it is defined. Arguments and return value changed.
5531 (valid_image_p, make_image): Callers changed.
5532 (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
3a880af4
SM
5533 (gif_type, imagemagick_type, svg_type, gs_type):
5534 Add initialization functions.
bb4d86b4
CY
5535 (Finit_image_library): Call lookup_image_type.
5536 (CHECK_LIB_AVAILABLE): Macro deleted.
5537 (lookup_image_type): Call define_image_type here, rather than via
5538 Finit_image_library, and without using CHECK_LIB_AVAILABLE.
5539 (syms_of_image): Move define_image_type calls for xbm_type and
5540 pbm_type to lookup_image_type.
5541
df9685f3
EZ
55422012-09-22 Eli Zaretskii <eliz@gnu.org>
5543
5544 * keyboard.c (timer_check_2): Move calculation of 'timers' and
5545 'idle_timers' from here ...
5546 (timer_check): ... to here. Use Fcopy_sequence to copy the timer
5547 lists, to avoid infloops when the timer does something stupid,
5548 like reinvoke itself with the same or smaller time-out.
5549 (Bug#12447)
5550
8e17c9ba
MR
55512012-09-22 Martin Rudalics <rudalics@gmx.at>
5552
5553 * window.c (Fsplit_window_internal): Handle only Qt value of
5554 Vwindow_combination_limit separately.
5555 (Qtemp_buffer_resize): New symbol.
3a880af4
SM
5556 (Vwindow_combination_limit): New default value.
5557 Rewrite doc-string.
8e17c9ba 5558
589bd69b
EZ
55592012-09-22 Eli Zaretskii <eliz@gnu.org>
5560
5561 * xdisp.c (next_overlay_string): Initialize it->end_charpos for
5562 the new overlay string. (Bug#10159)
5563
01108e3f
PE
55642012-09-22 Paul Eggert <eggert@cs.ucla.edu>
5565
5566 * emacs.c (shut_down_emacs): Don't assume stderr is buffered,
5567 or that fprintf is async-signal-safe. POSIX doesn't require
5568 either assumption.
5569
82f8cd94
CY
55702012-09-22 Chong Yidong <cyd@gnu.org>
5571
5572 * buffer.c (Fset_buffer_modified_p): Handle indirect buffers
5573 (Bug#8207).
5574
3cccbd87
KH
55752012-09-22 Kenichi Handa <handa@gnu.org>
5576
5577 * composite.c (composition_reseat_it): Handle the case that a
5578 grapheme cluster is not covered by a single font (Bug#12352).
5579
09c01941
CY
55802012-09-21 Chong Yidong <cyd@gnu.org>
5581
5582 * image.c (define_image_type): Avoid adding duplicate types to
5583 image_types (Bug#12463). Suggested by Jörg Walter.
5584
acfa068f 55852012-09-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
e25c1a30
YM
5586
5587 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
5588 (print_load_command_name): Add case LC_DATA_IN_CODE.
5589 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
5590
acfa068f 55912012-09-21 Glenn Morris <rgm@gnu.org>
1e9bbf47
GM
5592
5593 * eval.c (Frun_hook_with_args_until_success)
5594 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
5595
acfa068f 55962012-09-21 Andreas Schwab <schwab@linux-m68k.org>
c6ba4138
AS
5597
5598 * fileio.c (Ffile_selinux_context): Only call freecon when
5599 lgetfilecon succeeded.
5600 (Fset_file_selinux_context): Likewise. (Bug#12444)
5601
acfa068f 56022012-09-21 Eli Zaretskii <eliz@gnu.org>
aa36e4d2
EZ
5603
5604 * xdisp.c (try_window_reusing_current_matrix): Under bidi
5605 reordering, locate the cursor by calling set_cursor_from_row; if
5606 that fails, clear the desired glyph matrix before returning a
5607 failure indication to the caller. Fixes leaving garbled display
5608 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
5609 (compute_stop_pos_backwards): Fix a typo that caused crashes while
5610 scrolling through multibyte text.
aa36e4d2 5611
e99f70c8
SM
56122012-09-20 Stefan Monnier <monnier@iro.umontreal.ca>
5613
5614 * alloc.c (mark_object) <PVEC_WINDOW>: Mark prev/next_buffers *after*
5615 calling mark_vectorlike since that's the one that marks the window.
5616 (mark_discard_killed_buffers): Mark the final cdr.
5617 * window.h (struct window): Move prev/next_buffers to the
5618 non-standard fields.
5619 * window.c (make_window): Initialize prev/next_buffers manually.
5620
f75beb47
PE
56212012-09-20 Paul Eggert <eggert@cs.ucla.edu>
5622
5623 Omit unused arg EXPECTED from socket hooks.
5624 * keyboard.c (gobble_input, read_avail_input, tty_read_avail_input):
5625 * nsterm.m (ns_term_init):
5626 * termhooks.h (struct terminal.read_socket_hook):
5627 * w32inevt.c (w32_console_read_socket):
5628 * w32term.c (w32_read_socket):
5629 * xterm.c (XTread_socket):
5630 Omit unused arg EXPECTED. All callers changed.
5631 (store_user_signal_events): Return void, not int, since callers no
5632 longer care about the return value. All uses changed.
5633
b019b76a
JB
56342012-09-20 Juanma Barranquero <lekktu@gmail.com>
5635
5636 * w32gui.h (XParseGeometry): Do not declare.
5637
05642592
PE
56382012-09-19 Paul Eggert <eggert@cs.ucla.edu>
5639
e4bce92a 5640 * w32inevt.c (w32_console_read_socket): Return -1 on failure, not 0.
1f9f395d 5641 Ignore 'expected'. See Eli Zaretskii in
e4bce92a
PE
5642 <http://bugs.gnu.org/12471#8> (last line).
5643
05642592
PE
5644 * frame.c (read_integer): Remove. All uses replaced by strtol/strtoul.
5645 (XParseGeometry): Now static. Substitute extremal values for
5646 values that are out of range.
5647
e543ae91
JD
56482012-09-19 Jan Djärv <jan.h.d@swipnet.se>
5649
5650 * w32xfns.c (read_integer, XParseGeometry): Move to frame.c.
5651
5652 * nsfns.m (XParseGeometry): Remove.
5653 (Fx_create_frame): Call x_set_offset to correctly interpret
5654 top_pos in geometry.
5655
3a880af4 5656 * frame.c (read_integer, XParseGeometry): Move from w32xfns.c.
e543ae91
JD
5657 (Fx_parse_geometry): If there is a space in string, call
5658 Qns_parse_geometry, otherwise do as on other terms (Bug#12368).
5659
45ba16c7
EZ
56602012-09-17 Eli Zaretskii <eliz@gnu.org>
5661
c8b9f1bc
EZ
5662 * search.c (scan_buffer): Use character positions in calls to
5663 region_cache_forward and region_cache_backward, not byte
5664 positions. (Bug#12196)
5665
b4c932a2
EZ
5666 * w32term.c (w32_read_socket): Set pending_signals to 1, like
5667 xterm.c does. Reported by Daniel Colascione <dancol@dancol.org>.
5668
45ba16c7
EZ
5669 * ralloc.c (r_alloc_init) [!SYSTEM_MALLOC]: Initialize
5670 __malloc_extra_blocks to 32 instead of 64, like alloc.c did in
5671 emacs_blocked_malloc, now deleted.
5672
eeceac93
PE
56732012-09-17 Paul Eggert <eggert@cs.ucla.edu>
5674
5675 Remove no-longer-needed Solaris 2.4 vfork bug workaround.
5676 The workaround was for improving performance on Solaris 2.4, but
5677 is getting in the way now. Emacs will still work if someone is
5678 still running Solaris 2.4 in a museum somewhere; Sun dropped
5679 support for Solaris 2.4 in 2003.
5680 * callproc.c (Fcall_process) [HAVE_WORKING_VFORK]:
5681 * process.c (create_process) [HAVE_WORKING_VFORK]:
5682 Omit now-unnecessary workaround for the Solaris 2.4 vfork bug,
5683 since Emacs no longer uses vfork on that platform.
5684
78f83752
GM
56852012-09-17 Glenn Morris <rgm@gnu.org>
5686
5687 * emacs.c: Use COPYRIGHT.
5688
634b8cac
PE
56892012-09-16 Paul Eggert <eggert@cs.ucla.edu>
5690
0caaedb1
PE
5691 Remove configure's --without-sync-input option (Bug#12450).
5692 When auditing signal-handling in preparation for cleaning it up,
5693 I found that SYNC_INPUT has race conditions and would be a real
5694 pain to fix. Since it's an undocumented and deprecated
5695 configure-time option, now seems like a good time to remove it.
5696 Also see <http://bugs.gnu.org/11080#16>.
5697 * alloc.c (_bytes_used, __malloc_extra_blocks, _malloc_internal)
5698 (_free_internal) [!DOUG_LEA_MALLOC]: Remove decls.
5699 (alloc_mutex) [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
5700 (malloc_hysteresis):
5701 (check_depth) [XMALLOC_OVERRUN_CHECK]:
5702 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT):
5703 (__malloc_hook, __realloc_hook, __free_hook, BYTES_USED)
5704 (dont_register_blocks, bytes_used_when_reconsidered)
5705 (bytes_used_when_full, emacs_blocked_free, emacs_blocked_malloc)
5706 (emacs_blocked_realloc, reset_malloc_hooks, uninterrupt_malloc):
5707 [!SYSTEM_MALLOC && !SYNC_INPUT]:
1f9f395d 5708 Remove. All uses removed.
0caaedb1
PE
5709 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT): Use a different
5710 implementation, one that depends on whether the new macro
5711 XMALLOC_BLOCK_INPUT_CHECK is defined, not on whether SYNC_INPUT
5712 is defined.
5713 * atimer.c (run_timers, handle_alarm_signal):
5714 * keyboard.c (pending_signal, poll_for_input_1, poll_for_input)
5715 (handle_async_input, process_pending_signals)
5716 (handle_input_available_signal, init_keyboard):
5717 * nsterm.m (ns_read_socket):
5718 * process.c (wait_reading_process_output):
5719 * regex.c (immediate_quit, IMMEDIATE_QUIT_CHECK):
5720 * sysdep.c (emacs_sigaction_init) [SA_RESTART]:
5721 (emacs_write):
5722 * xterm.c (XTread_socket):
5723 Assume SYNC_INPUT.
5724 * conf_post.h (SA_RESTART) [IRIX6_5]: Do not #undef.
5725 * eval.c (handling_signal): Remove. All uses removed.
5726 * lisp.h (ELSE_PENDING_SIGNALS): Remove.
5727 All uses replaced with the SYNC_INPUT version.
5728 (reset_malloc_hooks, uninterrupt_malloc, handling_signal):
5729 Remove decls.
5730 * sysdep.c, syssignal.h (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
5731 Now static.
5732
634b8cac
PE
5733 * font.c (Ffont_shape_gstring): Remove unused local.
5734
83da1b55
GM
57352012-09-16 Glenn Morris <rgm@gnu.org>
5736
518650a5
GM
5737 * Makefile.in (clean): No longer run nextstep's clean.
5738
83da1b55
GM
5739 * Makefile.in (ns_appdir, ns_appbindir, ns_appsrc): Remove variables.
5740 (ns_frag): Remove.
5741 (ns-app): Move here from ns.mk, and simplify.
5742 (clean): Simplify nextstep entry.
5743 * ns.mk: Remove file.
5744
85a43e2e
KH
57452012-09-17 Kenichi Handa <handa@gnu.org>
5746
5747 * font.c (Ffont_shape_gstring): Fix previous change; GLYPHs may
5748 not covert the last few charactes.
5749
ba13e616 57502012-09-16 Kenichi Handa <handa@gnu.org>
ea964864
KH
5751
5752 * font.c (Ffont_shape_gstring): Don't adjust grapheme cluster
5753 here, but just check the validity of glyphs in the glyph-string.
5754
a8c729af
MR
57552012-09-16 Martin Rudalics <rudalics@gmx.at>
5756
3a880af4
SM
5757 * window.c (Fwindow_parameter, Fset_window_parameter):
5758 Accept any window as argument (Bug#12452).
a8c729af 5759
c077c059
JD
57602012-09-16 Jan Djärv <jan.h.d@swipnet.se>
5761
5762 * nsfns.m (Fx_open_connection): Move initialization of ns_*_types
5763 to ns_term_init to avoid memory leak.
5764
5765 * nsterm.m (ns_update_begin): Initialize bp after lcokFocus, use
5766 explicit retain/release.
5767 (ns_term_init): Only allow one display. Initialize outerpool and
5768 ns_*_types.
5769
39a57ad0
PE
57702012-09-15 Paul Eggert <eggert@cs.ucla.edu>
5771
5772 Port _setjmp fix to POSIXish hosts as well as Microsoft.
5773 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
5774 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
5775 the Microsoft problem in a different way, by altering ../nt/config.nt.
5776
7105c8cb
EZ
57772012-09-15 Eli Zaretskii <eliz@gnu.org>
5778
5779 * w32xfns.c:
5780 * w32uniscribe.c:
5781 * w32term.c:
5782 * w32select.c:
5783 * w32reg.c:
5784 * w32proc.c:
5785 * w32menu.c:
5786 * w32inevt.c:
5787 * w32heap.c:
5788 * w32font.c:
5789 * w32fns.c:
5790 * w32console.c:
5791 * w32.c:
5792 * w16select.c: Remove inclusion of setjmp.h, as it is now included
5793 by lisp.h. This completes removal of setjmp.h inclusion
5794 erroneously announced in the previous commit. (Bug#12446)
5795
5796 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
5797 more accurate.
5798
5799 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
5800 not defined as a macro. The latter happens on MS-Windows.
5801 (Bug#12446)
5802
0328b6de
PE
58032012-09-15 Paul Eggert <eggert@cs.ucla.edu>
5804
5805 Port better to POSIX hosts lacking _setjmp (Bug#12446).
5806 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 5807 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
5808 only reason for the instance was because "lisp.h" was included.
5809 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
5810 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
5811 and _longjmp with the new symbols. Emacs already uses _setjmp if
5812 available, so this change affects only POSIXish hosts that have
5813 sigsetjmp but not _setjmp, such as some versions of Solaris and
5814 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
5815 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
5816 (png_load_body) [HAVE_PNG]:
5817 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
5818 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
5819 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
5820 since PNG requires jmp_buf. This is the only exception to the
5821 general rule that we now use sys_setjmp and sys_longjmp.
5822 This exception is OK since this code does not change the signal
5823 mask or longjmp out of a signal handler.
5824
2af03429
PE
58252012-09-14 Paul Eggert <eggert@cs.ucla.edu>
5826
5827 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
5828 Include "syssignal.h", for 'main_thread'.
5829
2f294edf
DA
58302012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
5831
5832 Avoid out-of-range marker position (Bug#12426).
3a880af4
SM
5833 * insdel.c (replace_range, replace_range_2):
5834 Adjust markers before overlays, as suggested by comments.
2f294edf
DA
5835 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
5836 Remove redundant check before calling offset_intervals.
5837
6b533e9c
MR
58382012-09-14 Martin Rudalics <rudalics@gmx.at>
5839
5840 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
5841 current buffer (Bug#12387).
5842
2a7931e3
JB
58432012-09-14 Juanma Barranquero <lekktu@gmail.com>
5844
5845 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
5846
c18e885b
PE
58472012-09-13 Paul Eggert <eggert@cs.ucla.edu>
5848
5849 Use a more backwards-compatible timer format (Bug#12430).
5850 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
5851 vector element, not from the 4th, since PSECS is now at the end.
5852 (Fcurrent_idle_time): Doc fix.
5853
d59a1afb
DA
58542012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
5855
5856 Function to mark objects and remove killed buffers at once.
5857 * alloc.c (discard_killed_buffers): Rename to ...
5858 (mark_discard_killed buffers) ... new name. Add marking
5859 of remaining objects. Fix comment. Adjust users.
5860 (mark_object): Do not touch frame buffer lists here.
5861 * frame.c (delete_frame): Reset frame buffer lists here.
5862
5f0cb45a
PE
58632012-09-13 Paul Eggert <eggert@cs.ucla.edu>
5864
8ea47e3a
PE
5865 Better workaround for GNOME bug when --enable-gcc-warnings.
5866 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
5867 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
5868 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
5869
4a4bbad2
PE
5870 Simplify SIGIO usage (Bug#12408).
5871 The code that dealt with SIGIO was crufty and confusing, e.g., it
5872 played tricks like "#undef SIGIO" but these tricks were not used
5873 consistently. Simplify mostly by not #undeffing standard symbols,
5874 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
5875 or not as we please) rather than "defined SIGIO" (standard symbol
5876 that we probably shouldn't #undef).
5877 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
5878 Modules that need it can include it.
5879 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
5880 * dispextern.h (ignore_sigio): New decl.
5881 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
5882 unconditionally, since it's now a no-op if !USABLE_SIGIO.
5883 * emacs.c (shut_down_emacs):
5884 * keyboard.c (kbd_buffer_store_event_hold):
5885 Use ignore_sigio rather than invoking 'signal' directly.
5886 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
5887 for FIONREAD.
5888 (FIONREAD, SIGIO): Do not #undef.
5889 (tty_read_avail_input): Use #error rather than a syntax error.
5890 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
5891 for I_PIPE, used by SETUP_SLAVE_PTY.
5892 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
5893 * sysdep.c (croak): Remove; no longer needed. This bit of
5894 temporary code, with Fred N. Fish's comment that it's temporary,
5895 has been in Emacs since at least 1992!
5896 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
5897 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
5898 * syssignal.h (croak): Remove decl.
5899 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
5900 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
5901 now that we're termios-only.
5902 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
5903 * term.c (dissociate_if_controlling_tty): Use #error rather than
5904 a run-time error.
5905
5f0cb45a
PE
5906 Work around GCC and GNOME bugs when --enable-gcc-warnings.
5907 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
5908 to work around GNOME bug 683906.
5909 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
5910 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
5911 This works around GCC bug 54561.
5912
40bce90b
PE
59132012-09-12 Paul Eggert <eggert@cs.ucla.edu>
5914
5915 More fixes for 'volatile' and setjmp/longjmp.
5916 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
5917 * image.c (struct png_load_context) [HAVE_PNG]: New type.
5918 (png_load_body) [HAVE_PNG]:
5919 (jpeg_load_body) [HAVE_JPEG]:
5920 New function, with most of the old parent function's body.
5921 (png_load) [HAVE_PNG]:
5922 (jpeg_load) [HAVE_JPEG]:
5923 Invoke the new function, to avoid longjmp munging our locals.
5924 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
5925 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
5926 longjmp is passed 2, as the C standard doesn't guarantee this.
5927 Instead, store the failure code into mgr->failure_code.
5928
bfeae2cf
SM
59292012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5930
5931 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
5932 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
5933 (syms_of_keyboard): Remove support for unread-command-char.
5934
8099e36b
EZ
59352012-09-12 Eli Zaretskii <eliz@gnu.org>
5936
5937 * w32proc.c (sys_kill): If PID is our process ID and the signal is
5938 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
5939 violation. (Bug#12426)
5940
92547ff9
PE
59412012-09-12 Paul Eggert <eggert@cs.ucla.edu>
5942
5943 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
5944
45b82ad0
SM
59452012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5946
5947 * eval.c: Add `inhibit-debugger'.
5948 (Qinhibit_debugger): New symbol.
5949 (call_debugger): Bind it instead of Qdebug_on_error.
5950 (maybe_call_debugger): Test Vinhibit_debugger.
5951 (syms_of_eval): Define inhibit-debugger.
5952 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
5953 (syms_of_xdisp): Remove inhibit-debug-on-message.
5954
5779a1dc
PE
59552012-09-11 Paul Eggert <eggert@cs.ucla.edu>
5956
50f2e553
PE
5957 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
5958 If a nonvolatile local variable is written before a _longjmp to
5959 the frame containing the variable, and is read after the _longjmp,
5960 the value read is indeterminate. Some local variables of type
5961 'struct handler' and 'struct catchtag' are used in this way, so
5962 mark each of their slots as volatile if the slot can be set before
5963 _longjmp and read afterwards.
5964 * lisp.h (struct handler): var and chosen_clause are now volatile.
5965 (struct catchtag): val, next, and pdlcount are now volatile.
5966
ae1d87e2
PE
5967 * bidi.c (bidi_push_it, bidi_pop_it):
5968 * fns.c (copy_hash_table):
5969 * image.c (define_image_type):
5970 * keyboard.c (kbd_buffer_store_event_hold):
5971 * process.c (Fprocess_send_eof):
5972 * xfaces.c (x_create_gc) [HAVE_NS]:
5973 * xgselect.c (xg_select):
5974 Prefer assignment to memcpy when either will do.
5975
5779a1dc
PE
5976 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
5977 Use pointer-to-a-pointer to simplify and avoid a NILP check each
5978 time an item is removed. No need to mark this function 'inline';
5979 the compiler knows better than we do.
5980
c4c9756b
JD
59812012-09-11 Jan Djärv <jan.h.d@swipnet.se>
5982
5983 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
5984 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
5985 to change_frame_size (Bug#12388).
5986 (windowDidResize:): Pass YES to updateFrameSize.
5987
5988 * nsterm.h: Add delay parameter to updateFrameSize.
5989
d73e321c
DA
59902012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
5991
5992 Discard killed buffers from deleted window and frame objects.
5993 This reduces an amount of references to killed buffers and
5994 helps GC to reclaim them faster.
5995 * alloc.c (discard_killed_buffers): New function.
5996 (mark_object): Use it for deleted windows and frames.
5997 (mark_object): If symbol's value is set up for a killed buffer
1f9f395d 5998 or deleted frame, restore its global binding.
d73e321c
DA
5999 * data.c (swap_in_global_binding): Add GC notice.
6000 (swap_in_symval_forwarding): Use convenient set_blv_where.
6001 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
6002 * window.h: ... to here.
6003
e578f381
DA
60042012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
6005
6006 Convenient macro to check whether the buffer is live.
6007 * buffer.h (BUFFER_LIVE_P): New macro.
6008 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
6009 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
6010
3057e615
YM
60112012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6012
6013 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
6014 composition cases (Bug#12364).
6015
6016 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
6017 overhang of succeeding glyphs overlapping box cursor.
6018
6019 * w32term.c (x_draw_glyph_string): Likewise.
6020
6fda35f2
PE
60212012-09-11 Paul Eggert <eggert@cs.ucla.edu>
6022
c990426a
PE
6023 Simplify, document, and port floating-point (Bug#12381).
6024 The porting part of this patch fixes bugs on non-IEEE platforms
6025 with frexp, ldexp, logb.
6026 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
6027 Now static.
6028 * floatfns.c: Simplify discussion of functions that Emacs doesn't
6029 support, by removing commented-out code and briefly listing the
6030 C89 functions excluded. The commented-out stuff was confusing
6031 maintenance, e.g., we thought we needed cbrt but it was commented out.
6032 (logb): Remove decl; no longer needed.
6033 (isfinite): New macro, if not already supplied.
6034 (isnan): Don't replace any existing macro.
6035 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
6036 are present on all C89 platforms.
6037 (Ffrexp): Do not special-case zero, as frexp does the right thing
6038 for that case.
6039 (Flogb): Do not use logb, as it doesn't have the desired meaning
6040 on hosts that use non-base-2 floating point. Instead, stick with
6041 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
6042 frexp, to avoid getting an unspecified result.
6043
6fda35f2
PE
6044 * xdisp.c (Qinhibit_debug_on_message): Now static.
6045
16130a58
JD
60462012-09-10 Jan Djärv <jan.h.d@swipnet.se>
6047
6048 * nsterm.m (ns_update_begin): Set clip path to whole view by using
6049 NSBezierPath (Bug#12131).
6050
d105a573
CY
60512012-09-10 Chong Yidong <cyd@gnu.org>
6052
6053 * fns.c (Fdelq, Fdelete): Doc fix.
6054
ff55dfe8
PE
60552012-09-10 Paul Eggert <eggert@cs.ucla.edu>
6056
6057 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
6058 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
6059
e7032e7c
SM
60602012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
6061
6062 * lisp.h (make_lisp_ptr): New macro to replace XSET.
6063 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
6064 Use it.
6065
e9957956
EZ
60662012-09-09 Eli Zaretskii <eliz@gnu.org>
6067
aba05ce9
EZ
6068 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
6069 left fringe if the window has a left margin. This avoids leaving
6070 traces of the cursor because its leftmost pixel is not drawn over.
6071
e9957956
EZ
6072 * dispnew.c (update_window_line): When the left margin area of a
6073 screen line is updated, set the redraw_fringe_bitmaps_p flag of
6074 that screen line. (Bug#12277)
6075
f6196b87
PE
60762012-09-09 Paul Eggert <eggert@cs.ucla.edu>
6077
6078 Assume C89 or later for math functions (Bug#12381).
6079 This simplifies the code, and makes it a bit smaller and faster,
6080 and (most important) makes it easier to clean up signal handling
6081 since we can stop worring about floating-point exceptions in
6082 library code. That was a problem before C89, but the problem
6083 went away many years ago on all practical Emacs targets.
6084 * data.c, image.c, lread.c, print.c:
6085 Don't include <math.h>; no longer needed.
6086 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
6087 might be autoconfigured, as that never happens.
6088 * data.c (fmod):
6089 * doprnt.c (DBL_MAX_10_EXP):
6090 * print.c (DBL_DIG):
6091 Remove. C89 or later always defines these.
6092 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
6093 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
6094 (arith_error, domain_error, domain_error2):
6095 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
6096 no longer needed -- we simply return what C returns. All uses removed.
6097 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
6098 the wrapped code.
6099 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
6100 Remove. All uses expanded, as these macros are no longer used
6101 more than once and are now more trouble than they're worth.
6102 (Ftan): Use tan, not sin / cos.
6103 (Flogb): Assume C89 frexp.
6104 (fmod_float): Assume C89 fmod.
6105 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
6106 (init_floatfns): Remove. All uses removed.
6107
9d7f1863
JD
61082012-09-08 Jan Djärv <jan.h.d@swipnet.se>
6109
6110 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
6111 compositeToPoint for OSX < 10.6 (Bug#12390).
6112
eabf0404
PE
61132012-09-08 Paul Eggert <eggert@cs.ucla.edu>
6114
6115 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
6116 This produces more-accurate results.
6117
0b3b1d23
JD
61182012-09-08 Jan Djärv <jan.h.d@swipnet.se>
6119
6120 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
6121 changes (Bug#12088).
6122
6dcef6ec
CY
61232012-09-08 Chong Yidong <cyd@gnu.org>
6124
6125 * syntax.c (Fstring_to_syntax): Doc fix.
6126
aa7d57c5
JD
61272012-09-08 Jan Djärv <jan.h.d@swipnet.se>
6128
6129 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
6130 in the internal border.
6131 (x_set_window_size): Remove static variables and their usage.
6132 (ns_redraw_scroll_bars): Fix NSTRACE arg.
3a880af4
SM
6133 (ns_after_update_window_line, ns_draw_fringe_bitmap):
6134 Remove fringe/internal border adjustment (Bug#11052).
aa7d57c5
JD
6135 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
6136 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
6137 (ns_fix_rect_ibw): Remove.
6138 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
6139 (ns_dumpglyphs_box_or_relief): Ditto.
6140 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
6141 adjustment.
6142 (ns_dumpglyphs_image): Ditto.
fc0c31f8 6143 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
6144 border adjustment.
6145 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
6146 their usage. Add fringe_extended_p and its use as in other terms.
6147 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
6148 scroll bar was removed.
6149 (updateFrameSize): New function.
6150 (windowDidResize): Move code to updateFrameSize and call it.
6151
6152 * nsterm.h (EmacsView): Add updateFrameSize.
6153
1a5432bc
CY
61542012-09-07 Chong Yidong <cyd@gnu.org>
6155
b4f5313e
CY
6156 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
6157
1a5432bc
CY
6158 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
6159
1a4f1e9b
PE
61602012-09-07 Paul Eggert <eggert@cs.ucla.edu>
6161
6162 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
6163 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
6164 Problem introduced when merging patches. Noted by Eli Zaretskii in
6165 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
6166 * floatfns.c: Comment fix.
6167 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
6168 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
6169 and anyway the declaration is harmless even if SIGDANGER is not defined.
6170 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
6171 defined BROKEN_FIONREAD). systty.h formerly did this, but other
6172 source files not surprisingly expected syssignal.h to define, or
6173 not define, SIGIO, and it's cleaner to do it that way, for consistency.
6174 Include <sys/ioctl.h>, for FIONREAD.
6175 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
6176 This eliminates a problem whereby other files mysteriously had
6177 to include "syssignal.h" before including "systty.h" if they
6178 wanted to use "#ifdef SIGIO".
6179
bc8000ff
EZ
61802012-09-07 Eli Zaretskii <eliz@gnu.org>
6181
3e6d6928
EZ
6182 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
6183
6184 * w32.c (sigemptyset): Empty the set.
6185 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
6186
bc8000ff
EZ
6187 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
6188
b4fa72f2
DA
61892012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
6190
6191 * alloc.c (mark_buffer): Revert unsafe marking optimization.
6192 (mark_object): Likewise for frame objects.
6193
30730c93
PE
61942012-09-07 Paul Eggert <eggert@cs.ucla.edu>
6195
6196 * syssignal.h (handle_on_main_thread): Always declare,
6197 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
6198 This ports to platforms without HAVE_PTHREAD.
6199
2fe28299
PE
62002012-09-06 Paul Eggert <eggert@cs.ucla.edu>
6201
6202 Signal-handler cleanup (Bug#12327).
6203 Emacs's signal handlers were written in the old 4.2BSD style with
6204 sigblock and sigmask and so forth, and this led to some
6205 inefficiencies and confusion. Rewrite these to use
6206 pthread_sigmask etc. without copying signal sets around. Also,
6207 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
6208 'signal', and instead use functions that do not attempt to take
6209 over the system name space. This patch causes Emacs's text
6210 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
6211 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
6212 Do not include <signal.h> or "syssignal.h", as these
6213 modules do not use signals.
6214 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
6215 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
6216 Do not include <signal.h>, as "syssignal.h" does that for us now.
6217 * atimer.c (sigmask_atimers): New function.
6218 (block_atimers, unblock_atimers): New functions,
6219 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
6220 All uses replaced.
6221 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
6222 no longer needed here.
6223 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 6224 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
6225 * sysdep.c (struct save_signal): New member 'action', replacing
6226 old member 'handler'.
6227 (save_signal_handlers, restore_signal_handlers):
6228 Use sigaction instead of 'signal' to save and restore.
6229 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
6230 New function. All users of 'signal' modified to use set_sighandler
6231 if they're writeonly, and to use sys_signal if they're read+write.
6232 (emacs_sigaction_init, forwarded_signal): New functions.
6233 (sys_signal): Remove. All uses replaced by calls to sigaction
6234 and emacs_sigaction_init, or by direct calls to 'signal'.
6235 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
6236 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
6237 all uses replaced by pthread_sigmask etc. calls.
6238 * syssignal.h: Include <signal.h>.
6239 (emacs_sigaction_init, forwarded_signal): New decls.
6240 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
6241 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
6242 (sigmask, sys_sigmask): Remove; no longer needed.
6243 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
6244 (sigblock, sigunblock, sigfree):
6245 (sigsetmask) [!defined sigsetmask]:
6246 Remove. All uses replaced by pthread_sigmask.
6247 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
6248 no longer need to be replaced, and its typical old uses
6249 are now done via emacs_sigaction_init and sigaction.
6250 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
6251 (sys_sigdel): Remove; unused.
6252 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
6253
0216c128
EZ
62542012-09-06 Eli Zaretskii <eliz@gnu.org>
6255
6256 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
6257 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
6258
c752cfa9
DA
62592012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
6260
6261 Explicitly mark buffer_defaults and buffer_local_symbols.
6262 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
6263 mark_local_symbols here.
6264 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
6265 since special buffers aren't marked here any more.
6266 (allocate_buffer): Chain new buffer with all_buffers here...
6267 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
6268 not here.
6269 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
6270 (syms_of_buffer): Remove staticpro of the above.
6271 (init_buffer_once): Set names for buffer_defaults and
6272 buffer_local_symbols.
6273
a864ef14
PE
62742012-09-06 Paul Eggert <eggert@cs.ucla.edu>
6275
6276 Use bool for booleans in font-related modules.
6277 * font.c (font_intern_prop, font_style_to_value)
6278 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
6279 (generate_otf_features, font_check_otf_features, font_check_otf)
6280 (font_match_p, font_list_entities, font_at):
6281 * fontset.c (fontset_id_valid_p, reorder_font_vector
6282 (fontset_find_font, Fset_fontset_font)
6283 (face_suitable_for_char_p) [0]:
6284 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
6285 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
6286 (m17n_flt_initialized, ftfont_shape_by_flt):
6287 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
6288 * nsfont.m (nsfont_draw):
6289 * w32font.c (w32font_draw):
6290 * w32term.c (x_draw_glyphless_glyph_string_foreground):
6291 Use bool for booleans.
6292 * font.h: Adjust to above API changes.
6293 (struct font, struct font_driver, struct font_driver_list):
6294 Use bool for booleans.
6295 (struct font): Remove useless member encoding_type.
6296 All users removed.
6297 * fontset.c, xftfont.c: Omit unnecessary static decls.
6298
0699fc18
DA
62992012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
6300
6301 * alloc.c (mark_object): Revert window marking code
6302 since it's unsafe for the Fset_window_configuration.
6303
20ef56db
PE
63042012-09-05 Paul Eggert <eggert@cs.ucla.edu>
6305
2fe28299 6306 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
6307 Be more systematic about preserving errno whenever a signal
6308 handler returns, even if it's not in the main thread. Do this by
6309 renaming signal handlers to distinguish between signal delivery
6310 and signal handling. All uses changed.
6311 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
6312 * data.c (deliver_arith_signal): Rename from arith_error.
6313 * dispnew.c (deliver_window_change_signal): Rename from
6314 window_change_signal.
6315 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
6316 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
6317 * keyboard.c (deliver_input_available_signal): Rename from
6318 input_available_signal.
6319 (deliver_user_signal): Rename from handle_user_signal.
6320 (deliver_interrupt_signal): Rename from interrupt_signal.
6321 * process.c (deliver_pipe_signal): Rename from send_process_trap.
6322 (deliver_child_signal): Rename from sigchld_handler.
6323 * atimer.c (handle_alarm_signal):
6324 * data.c (handle_arith_signal):
6325 * dispnew.c (handle_window_change_signal):
6326 * emacs.c (handle_fatal_signal, handle_danger_signal):
6327 * keyboard.c (handle_input_available_signal):
6328 * keyboard.c (handle_user_signal, handle_interrupt_signal):
6329 * process.c (handle_pipe_signal, handle_child_signal):
6330 New functions, with the actual signal-handling code taken from the
6331 original respective signal handlers, sans the sporadic attempts to
6332 preserve errno, since that's now done by handle_on_main_thread.
6333 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
6334 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
6335 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
6336 Move to sysdep.c.
6337 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
6338 Move initialization of main_thread to sysdep.c's init_signals.
6339 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
6340 our usage, and simplifies the mainline code.
6341 (record_child_status_change): New static function, as a helper
6342 for handle_child_signal, and with most of the old child handler's
6343 contents.
6344 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
6345 (handle_child_signal): Use the above.
6346 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
6347 Moved here from emacs.c.
6348 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
6349 code moved here from emacs.c's main function.
6350 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
3a880af4
SM
6351 replacing the old SIGNAL_THREAD_CHECK. All uses changed.
6352 This lets callers save and restore errno properly.
20ef56db 6353
e3ccf108
DA
63542012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
6355
6356 Remove redundant or unused things here and there.
6357 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
6358 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
6359 * editfns.c (Fcompare_buffer_substrings): Likewise.
6360 * frame.h (struct terminal, struct font_driver_list):
6361 Remove redundant declarations.
6362 * window.h (Qleft, Qright): Likewise.
6363
697e1e39
DA
63642012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
6365
6366 Do not mark objects from deleted buffers, windows and frames.
6367 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
6368 (mark_object): Likewise for windows and frames.
6369
c1ca42ca
DA
63702012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
6371
6372 * alloc.c (valid_lisp_object_p): Treat killed buffers,
6373 buffer_defaults and buffer_local_symbols as valid objects.
6374 Return special value to denote them.
6375
014d93be
PE
63762012-09-05 Paul Eggert <eggert@cs.ucla.edu>
6377
f75d7a91
PE
6378 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
6379 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
6380 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
6381 (file_name_absolute_p, Fsubstitute_in_file_name):
6382 (check_executable, check_writable, Ffile_accessible_directory_p)
6383 (Fset_file_selinux_context, Fdefault_file_modes)
6384 (Finsert_file_contents, choose_write_coding_system)
6385 (Fwrite_region, build_annotations, a_write, e_write)
6386 (Fdo_auto_save):
6387 * filelock.c (boot_time_initialized, get_boot_time)
6388 (get_boot_time_1, lock_file_1, within_one_second):
6389 * floatfns.c (in_float):
6390 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
6391 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
6392 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
6393 * lisp.h (struct Lisp_Hash_Table.cmpfn):
6394 * window.c (compare_window_configurations):
6395 Use bool for booleans.
6396 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
6397 (Fdefault_file_modes): Now mode_t, not int, for modes.
6398 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
6399 (internal_delete_file): Now returns void, not a (boolean) int,
6400 since nobody was looking at the return value.
6401 * lisp.h, window.h: Adjust to above API changes.
6402
014d93be
PE
6403 * xdisp.c (set_message): Simplify and reindent last change.
6404
776f29e1
JB
64052012-09-05 Juanma Barranquero <lekktu@gmail.com>
6406
6407 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
6408
7f7e0167
LI
64092012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
6410
6411 * eval.c (call_debugger): Make the function non-static so that we
6412 can call it from set_message.
6413
6414 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
6415 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
6416
cf29dd84
PE
64172012-09-04 Paul Eggert <eggert@cs.ucla.edu>
6418
6419 Give more-useful info on a fatal error (Bug#12328).
6420 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
6421 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
6422 of doing the work ourselves.
6423 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
6424 do most of the work.
6425 (fatal_error_backtrace): New function, taken from the guts
6426 of the old fatal_error_signal, but with a new option to output
6427 a backtrace.
6428 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
6429 info about the signal than just its number.
6430 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
6431 * sysdep.c: Include <execinfo.h>
6432 (emacs_backtrace): New function, taken partly from the previous
6433 code of the 'die' function.
6434 (emacs_abort): Call fatal_error_backtrace rather than abort.
6435
972debf2
SM
64362012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
6437
6438 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
6439 eager (load-time) macro-expansion.
6440 * lisp.mk (lisp): Add macroexp.
6441
1088b922
PE
64422012-09-04 Paul Eggert <eggert@cs.ucla.edu>
6443
6444 Simplify redefinition of 'abort' (Bug#12316).
6445 Do not try to redefine the 'abort' function. Instead, redo
6446 the code so that it calls 'emacs_abort' rather than 'abort'.
6447 This removes the need for the NO_ABORT configure-time macro
6448 and makes it easier to change the abort code to do a backtrace.
6449 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
6450 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
6451 Remove; sysdep.c's emacs_abort now takes its place.
6452 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
6453 'abort' changed to use 'emacs_abort'.
6454 * msdos.c (dos_abort) [defined abort]: Remove; not used.
6455 (abort) [!defined abort]: Rename to ...
6456 (emacs_abort): ... new name.
6457 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
6458 the place of the old 'abort' in emacs.c.
6459 * w32.c, w32fns.c (abort): Do not #undef.
6460 * w32.c (emacs_abort): Rename from w32_abort.
6461
30934d33
EZ
64622012-09-04 Eli Zaretskii <eliz@gnu.org>
6463
6464 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
6465 offsets[j].dv, since the y axis of the screen coordinates points
6466 down, while the y axis of the font definition coordinates points
6467 up. This fixes display of Arabic diacritics such as KASRA and
6468 KASRATAN. (Bug#11860)
6469
af26b72c
PE
64702012-09-04 Paul Eggert <eggert@cs.ucla.edu>
6471
6472 Be more systematic about _setjmp vs setjmp.
6473 * alloc.c (test_setjmp, mark_stack):
6474 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
6475 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
6476 (png_load, my_error_exit, jpeg_load):
6477 * process.c (send_process_trap, send_process):
6478 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
6479 The underscored versions are up to 30x faster on some hosts.
6480 Formerly, the code used setjmp+longjmp sometimes and
6481 _setjmp+_longjmp at other times, with no particular reason to
6482 prefer setjmp+longjmp.
6483
26d4541d
PE
64842012-09-03 Paul Eggert <eggert@cs.ucla.edu>
6485
d42f4f0f 6486 Fix minor problem found by static checking.
26d4541d 6487 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 6488
c5e28e39
MR
64892012-09-03 Martin Rudalics <rudalics@gmx.at>
6490
6491 * buffer.c (Fdelete_all_overlays): New function.
6492
3eab3ca9
CY
64932012-09-03 Chong Yidong <cyd@gnu.org>
6494
6495 * gtkutil.c: Add extern decl for Qxft.
6496
c04889f8
PE
64972012-09-02 Paul Eggert <eggert@cs.ucla.edu>
6498
1882aa38
PE
6499 * emacs.c, eval.c: Use bool for boolean.
6500 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
6501 (malloc_using_checking) [DOUG_LEA_MALLOC]:
6502 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
6503 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
6504 (main, decode_env_path, Fdaemon_initialized):
6505 * eval.c (call_debugger, Finteractive_p, interactive_p):
6506 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
6507 (maybe_call_debugger, Fbacktrace):
6508 * process.c (read_process_output, exec_sentinel):
6509 Use bool for booleans.
6510 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
6511 All callers changed.
6512 * eval.c (interactive_p): Omit always-true boolean argument
6513 EXCLUDE_SUBRS_P. All callers changed.
6514 * dispextern.h, lisp.h: Reflect above API changes.
6515 * firstfile.c (dummy): Use the address of 'main', whose signature
6516 won't change, instead of the address of 'initialize', whose
6517 signature just changed from int to bool.
6518 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
6519 * msdos.c (fatal_error_in_progress): ... from here.
6520 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
6521 of incrementing it.
6522 (redisplay_internal, unwind_redisplay): Simply clear
6523 REDISPLAYING_P when unwinding, instead of saving its previous,
6524 always-false value and then restoring it.
6525
a411ac43
PE
6526 Clean up some extern decls.
6527 Mostly, this hoists extern decls out of .c files and into .h files.
6528 That way, we're more likely to catch errors if the interfaces change.
6529 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
6530 declare xg_mark_data.
6531 * dispextern.h (x_frame_parm_handlers):
6532 * font.h (Qxft):
6533 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
6534 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
6535 (Qultra_bold, Qoblique, Qitalic):
6536 Move extern decl here from .c file.
6537 * alloc.c (xg_mark_data) [USE_GTK]:
6538 * doc.c (Qclosure):
6539 * eval.c (Qlexical_binding):
6540 * fns.c (time) [!HAVE_UNISTD_H]:
6541 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
6542 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
6543 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
6544 * lread.c (Qinternal_interpreter_environment):
6545 * minibuf.c (Qbuffer):
6546 * process.c (QCfamily, QCfilter):
6547 * widget.c (free_frame_faces):
6548 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
6549 * xfont.c (x_clear_errors):
6550 * xterm.c (x_frame_parm_handlers):
6551 Remove now-redundant extern decls.
6552 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
6553 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
6554 Now static.
6555 * xfaces.c: Remove unnecessary static decls.
6556 * xterm.c (updating_frame): Remove decl of nonexistent object.
6557
c04889f8
PE
6558 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
6559 when building globals.h, as the objects that are not built on
6560 this host are not needed to compile C files on this host.
6561
8b339673
JD
65622012-09-02 Jan Djärv <jan.h.d@swipnet.se>
6563
6564 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
6565
6566 * frame.h: Add missing prototype for x_wm_set_size_hint.
6567
a08d4ba7
PE
65682012-09-02 Paul Eggert <eggert@cs.ucla.edu>
6569
6570 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
6571 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
6572 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
6573 (Fsubstitute_command_keys):
6574 * editfns.c (region_limit, find_field, Fconstrain_to_field)
6575 (save_excursion_save, save_excursion_restore)
6576 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
6577 (format_time_string, general_insert_function)
6578 (make_buffer_string, make_buffer_string_both)
6579 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
6580 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
6581 (copy_text, insert_1, insert_1_both, insert_from_string)
6582 (insert_from_string_before_markers, insert_from_string_1)
6583 (insert_from_buffer, insert_from_buffer_1, replace_range)
6584 (replace_range_2, del_range_1, del_range_byte, del_range_both)
6585 (del_range_2, modify_region):
6586 * intervals.c (intervals_equal, balance_possible_root_interval)
6587 (adjust_intervals_for_insertion, merge_properties_sticky)
6588 (graft_intervals_into_buffer, lookup_char_property)
6589 (adjust_for_invis_intang, set_point_both)
6590 (get_property_and_range, compare_string_intervals)
6591 (set_intervals_multibyte_1, set_intervals_multibyte):
6592 * keyboard.c (decode_timer):
6593 Use bool for boolean.
6594 * intervals.h, lisp.h, systime.h: Reflect above API changes.
6595 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
6596
48c948de
CY
65972012-09-02 Chong Yidong <cyd@gnu.org>
6598
6599 * keymap.c (push_key_description): Print M-TAB as C-M-i
6600 (Bug#11758).
6601
6c49a40b
JB
66022012-09-02 Juanma Barranquero <lekktu@gmail.com>
6603
6604 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
6605 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
6606 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
6607 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
6608 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
6609 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
6610 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
6611
4dfbd238
EZ
66122012-09-01 Eli Zaretskii <eliz@gnu.org>
6613
7e510e28
EZ
6614 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
6615 more than one grapheme cluster passed to the shaper: compute the
6616 offset adjustment values separately for each cluster. (Bug#11860)
6617
4dfbd238
EZ
6618 * image.c: Restore mistakenly removed inclusion of w32.h. Without
6619 it, GCC doesn't see prototypes of w32_delayed_load, and complains
6620 about implicit conversions from integer to pointer.
6621
86571ae0
DC
66222012-09-01 Daniel Colascione <dancol@dancol.org>
6623
6624 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
6625 system used too early.
6626
0e23ef9d
PE
66272012-09-01 Paul Eggert <eggert@cs.ucla.edu>
6628
6629 Better seed support for (random).
6630 * emacs.c (main): Call init_random.
6631 * fns.c (Frandom): Set the seed from a string argument, if given.
6632 Remove long-obsolete Gentzel cruft.
6633 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
6634 (init_random): New function.
6635
17a2cbbd
DC
66362012-09-01 Daniel Colascione <dancol@dancol.org>
6637
6638 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
6639 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
6640 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
6641 x_wm_set_size_hint, x_query_colors, x_real_positions,
6642 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
6643 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
6644 all of which have been moved to common code.
6645
6646 * xfaces.c: Include TERM_HEADER instead of listing all possible
6647 window-system headers.
6648
6649 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
6650 to match header.
6651
6652 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
6653 directly accessing frame internals.
6654
f18cbb28 6655 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
6656 globals_of_w32font.
6657
6658 * process.c: Include TERM_HEADER instead of listing all possible
6659 window-system headers.
6660
3a880af4
SM
6661 * nsterm.h: Remove declarations now in frame.h.
6662 Define FRAME_X_SCREEN, FRAME_X_VISUAL.
17a2cbbd
DC
6663
6664 * menu.c: Include TERM_HEADER instead of listing all possible
6665 window-system headers.
6666
6667 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
6668 window system.
6669
6670 * keyboard.c: Include TERM_HEADER instead of listing all possible
6671 window-system headers.
6672
6673 * image.c: Include TERM_HEADER instead of listing all possible
6674 window-system headers. Declare Vlibrary_cache when compiling for
6675 Windows.
6676
6677 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
6678 window system declarations.
6679
6680 * frame.h: Move common functions here: set_frame_menubar,
6681 x_set_window_size, x_sync, x_get_focus_frame,
6682 x_set_mouse_position, x_set_mouse_pixel_position,
6683 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
6684 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
6685 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
6686 x_activate_menubar, x_real_positions, x_bitmap_icon,
6687 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
6688 and x_query_colors.
6689
6690 * frame.c: Include TERM_HEADER instead of listing all possible
6691 window-system headers.
6692
6693 * font.c: Include TERM_HEADER instead of listing all possible
6694 window-system headers.
6695
6696 * emacs.c: Include TERM_HEADER.
6697
f18cbb28
EZ
6698 * dispnew.c: Include TERM_HEADER instead of listing all possible
6699 window-system headers.
17a2cbbd 6700
f18cbb28 6701 * ccl.h: Include character.h.
17a2cbbd
DC
6702
6703 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
6704 the current window system; include in list of objects to link into
6705 Emacs.
6706
c650a5de
DA
67072012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
6708
6709 Remove mark_ttys function and fix tty_display_info initialization.
6710 * lisp.h (mark_ttys): Remove prototype.
6711 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
6712 to mark_ttys because all possible values of 'top_frame' slot are
6713 the frames which are reachable from Vframe_list.
6714 * term.c (mark_ttys): Remove.
6715 (init_tty): Safely initialize 'top_frame' slot with Qnil.
6716
4e0f6479
DA
67172012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
6718
6719 Change struct frame bitfields from unsigned char to unsigned.
6720 * frame.h (struct frame): Change type of 'display_preempted',
6721 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
6722 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
6723 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
6724 bitfields from unsigned char to unsigned.
6725
8b96a52c
DA
67262012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
6727
6728 Remove unused member of struct x_output and struct w32_output.
6729 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
6730 * w32term.h (struct w32_output): Likewise.
6731
b4444c8a
JD
67322012-08-30 Jan Djärv <jan.h.d@swipnet.se>
6733
6734 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
6735 does not become zero (Bug#12234).
6736
b98521db
PE
67372012-08-30 Paul Eggert <eggert@cs.ucla.edu>
6738
6739 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
6740 for GCC 4.7.1 x86-64.
6741
31d02438
GM
67422012-08-30 Glenn Morris <rgm@gnu.org>
6743
6744 * lread.c (init_lread): For out-of-tree builds, only add the
6745 source directory's site-lisp dir to the load-path if it exists,
6746 consistent with in-tree builds. (Bug#12302)
6747
7f8941d8
JD
67482012-08-28 Jan Djärv <jan.h.d@swipnet.se>
6749
6750 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 6751 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
6752 (windowShouldClose:): Set window_closed.
6753 (dealloc): New member, free button_values.
fc0c31f8
JB
6754 (process_dialog:): Make member function. Remove window argument,
6755 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
6756 in button_values.
6757 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 6758 with tag. Remove return self, declare return value as void.
7f8941d8
JD
6759 (addString:row:): Remove return self, declare return value as void.
6760 (addSplit): Remove return self, declare return value as void.
6761 (clicked:): Remove return self, declare return value as void.
fc0c31f8 6762 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
6763 (initFromContents:isQuestion:): Adjust call to process_dialog.
6764 Code formatting change.
6765 (timeout_handler:): Set timer_fired to YES.
6766 (runDialogAt:): Set timer_fired to NO.
6767 Handle click on close button as quit.
6768
6769 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
6770 Add window_closed and button_values. Add void as return value for
6771 add(Button|String|Split). addButton takes int instead of Lisp_Object.
6772 Add process_dialog as new member.
6773
eada0861 67742012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 6775
eada0861
GM
6776 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
6777 is not one of the heaps we manage. (Bug#12242)
6778
67792012-08-28 Glenn Morris <rgm@gnu.org>
6780
6781 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
6782
457294dd
MR
67832012-08-28 Martin Rudalics <rudalics@gmx.at>
6784
6785 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
6786 auto-buffer-name window parameter. Install revision of reverted
6787 fix.
457294dd 6788
4f2daf31
DA
67892012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
6790
6791 Do not allow to set major mode for a dead buffer.
6792 * buffer.c (Fset_buffer_major_mode): Signal an error
6793 if the buffer is dead.
6794 (Fother_buffer, other_buffer_safely): Remove redundant
6795 nested declaration.
6796
66322887
DA
67972012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
6798
6799 Always use set_buffer_if_live to restore original buffer at unwind.
6800 * buffer.h (record_unwind_current_buffer): New function.
6801 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
6802 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
6803 * undo.c, window.c: Adjust users.
6804 * buffer.c (set_buffer_if_live): Fix comment.
6805
a3d794a1
DA
68062012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
6807
6808 Fix usage of set_buffer_internal.
6809 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
6810 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
6811 * coding.c (decode_coding): Omit redundant test.
6812 * fileio.c (decide_coding_unwind): Likewise.
6813 * fns.c (secure_hash): Likewise.
6814 * insdel.c (modify_region): Likewise.
6815 * keyboard.c (command_loop_1): Likewise.
6816 * print.c (PRINTFINISH): Likewise.
6817 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
6818
59ea14cd
PE
68192012-08-27 Paul Eggert <eggert@cs.ucla.edu>
6820
6821 * dispnew.c: Use bool for boolean.
6822 (frame_garbaged, display_completed, delayed_size_change)
6823 (fonts_changed_p, add_window_display_history)
6824 (add_frame_display_history, verify_row_hash)
6825 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
6826 (row_equal_p, realloc_glyph_pool)
6827 (allocate_matrices_for_frame_redisplay)
6828 (showing_window_margins_p)
6829 (adjust_frame_glyphs_for_frame_redisplay)
6830 (build_frame_matrix_from_leaf_window, make_current)
6831 (mirrored_line_dance, mirror_line_dance, update_frame)
6832 (update_window_tree, update_single_window)
6833 (check_current_matrix_flags, update_window, update_text_area)
6834 (update_window_line, set_window_update_flags, scrolling_window)
6835 (update_frame_1, scrolling, buffer_posn_from_coords)
6836 (do_pending_window_change, change_frame_size)
6837 (change_frame_size_1, sit_for):
6838 Use bool for boolean.
6839 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
6840 and remove last int (actually boolean) argument, which was always 0.
6841 All callers changed.
6842 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
6843 * dispextern.h (struct composition_it): Use bool for boolean.
6844 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
6845 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
6846 * dired.c (file_name_completion):
6847 Use bool for boolean. (This was missed in an earlier change.)
6848
95072a94
MR
68492012-08-27 Martin Rudalics <rudalics@gmx.at>
6850
6851 * window.c (Fset_window_configuration): Revert first part of
6852 last change.
6853
0f19feff
JD
68542012-08-27 Jan Djärv <jan.h.d@swipnet.se>
6855
6856 * nsterm.h (NSPanel): New class variable dialog_return.
6857
3a880af4
SM
6858 * nsmenu.m (initWithContentRect:styleMask:backing:defer:):
6859 Initialize dialog_return.
0f19feff
JD
6860 (windowShouldClose:): Use stop instead of stopModalWithCode.
6861 (clicked:): Ditto, and also set dialog_return (Bug#12258).
6862 (timeout_handler:): Use stop instead of abortModal. Send a dummy
6863 event.
6864 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
6865 modal loop returns.
6866
f10fe38f
PE
68672012-08-27 Paul Eggert <eggert@cs.ucla.edu>
6868
de1339b0
PE
6869 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
6870 * composite.c (find_composition, composition_gstring_p)
6871 (composition_reseat_it, find_automatic_composition):
6872 * data.c (let_shadows_buffer_binding_p)
6873 (let_shadows_global_binding_p, set_internal, make_blv)
6874 (Fmake_variable_buffer_local, Fmake_local_variable)
6875 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
6876 (cons_to_signed, arith_driver):
6877 * dbusbind.c (xd_in_read_queued_messages):
6878 * dired.c (directory_files_internal, file_name_completion):
6879 Use bool for booleans.
6880 * dired.c (file_name_completion):
6881 * process.h (fd_callback):
6882 Omit int (actually boolean) argument. It wasn't being used.
6883 All uses changed.
6884 * composite.h, lisp.h: Reflect above API changes.
6885
f10fe38f
PE
6886 * cmds.c, coding.c: Use bool for booleans.
6887 * cmds.c (move_point, Fself_insert_command):
6888 * coding.h (struct composition status, struct coding_system):
6889 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
6890 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
6891 (emacs_mule_char, decode_coding_emacs_mule)
6892 (encode_coding_emacs_mule, detect_coding_iso_2022)
6893 (decode_coding_iso_2022, encode_invocation_designation)
6894 (encode_designation_at_bol, encode_coding_iso_2022)
6895 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
6896 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
6897 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
6898 (encode_coding_raw_text, detect_coding_charset)
6899 (decode_coding_charset, encode_coding_charset, detect_eol)
6900 (detect_coding, get_translation_table, produce_chars)
6901 (consume_chars, reused_workbuf_in_use)
6902 (make_conversion_work_buffer, code_conversion_save)
6903 (decode_coding_object, encode_coding_object)
6904 (detect_coding_system, char_encodable_p)
6905 (Funencodable_char_position, code_convert_region)
6906 (code_convert_string, code_convert_string_norecord)
6907 (Fset_coding_system_priority):
6908 * fileio.c (Finsert_file_contents):
6909 Use bool for booleans.
6910 * coding.h, lisp.h: Reflect above API changes.
6911 * coding.c: Remove unnecessary static function decls.
6912 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
6913 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
6914 not a boolean 'int', since callers never look at the return value.
6915 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
6916 * coding.h (decoding_buffer_size, encoding_buffer_size)
6917 (emacs_mule_string_char): Remove unused extern decls.
6918 (struct iso_2022_spec, struct coding_system):
6919 Use 'unsigned int : 1' for boolean fields, since there's more than one.
6920 (struct emacs_mule_spec): Remove unused field 'full_support'.
6921 All initializations removed.
6922 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
6923
5474c384
DA
69242012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
6925
f10fe38f 6926 Fix spare memory change (Bug#12286).
5474c384
DA
6927 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
6928 (valid_lisp_object_p): Likewise.
6929
c4b6914d
MR
69302012-08-27 Martin Rudalics <rudalics@gmx.at>
6931
6932 * window.c (Fset_window_configuration): Record any window's old
6933 buffer if it's replaced (see Bug#8789). If the new current
6934 buffer doesn't appear in the selected window, go to its old
6935 point (Bug#12208).
6936
35aaa1ea
DA
69372012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
6938
6939 Special MEM_TYPE_SPARE to denote reserved memory.
6940 * alloc.c (enum mem_type): New memory type.
6941 (refill_memory_reserve): Use new type for spare memory.
6942 This prevents live_cons_p and live_string_p from incorrect
6943 detection of uninitialized objects from spare memory as live.
6944
6af64513
PE
69452012-08-26 Paul Eggert <eggert@cs.ucla.edu>
6946
8b2e00a3
PE
6947 Spelling fixes.
6948 * Makefile.in (.PHONY): versioclean -> versionclean.
6949
b52d6985
PE
6950 Remove unused external symbols.
6951 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
6952 * window.c (Qwindow_valid_p, decode_valid_window):
6953 Now static, not extern.
6954 * data.c (Qinterval): Remove; unused.
6955 (syms_of_data): Do not define 'interval'.
6956 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
6957 * window.h (decode_valid_window):
6958 Remove decls.
6959
d5172d4f
PE
6960 * character.c, charset.c, chartab.c: Use bool for booleans.
6961 * character.c (lisp_string_width, string_count_byte8)
6962 (string_escape_byte8):
6963 * charset.c (charset_map_loaded, load_charset_map, read_hex):
6964 (load_charset_map_from_file, map_charset_chars)
6965 (Fdefine_charset_internal, define_charset_internal)
6966 (Fdeclare_equiv_charset, find_charsets_in_text)
6967 (Ffind_charset_region, char_charset, Fiso_charset):
6968 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
6969 (sub_char_table_set, sub_char_table_set_range)
6970 (char_table_set_range, optimize_sub_char_table)
6971 (map_sub_char_table):
6972 Use bool for boolean.
6973 * character.c (str_to_unibyte): Omit last boolean argument; it was
6974 always 0. All callers changed.
6975 * character.h, charset.h: Adjust to match previous changes.
6976 * character.h (char_printable_p): Remove decl of nonexistent function.
6977 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
6978 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
6979 are all boolean, so make them single-bit bitfields.
6980
6af64513
PE
6981 * lisp.h (ASET): Remove attempt to detect side effects.
6982 It was meant to be temporary and it often doesn't work,
6983 because when IDX has side effects the behavior of IDX==IDX
6984 is undefined. See Stefan Monnier in
6985 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
6986
e1f29348
BR
69872012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
6988
6989 * lisp.h (functionp): New function (extracted from Ffunctionp).
6990 (FUNCTIONP): Use it.
6991 * eval.c (Ffunctionp): Use it.
6992
17c05d74
PE
69932012-08-25 Paul Eggert <eggert@cs.ucla.edu>
6994
0f46bc75
PE
6995 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
6996 as that's faster and simpler than static storage. Don't bother
6997 with the g_main_context_query overhead if g_main_context_pending
6998 says no events are pending.
6999 (gfds, gfds_size): Remove these static vars.
7000 (xgselect_initialize): Remove; no longer needed.
7001 All uses and decls removed.
7002
ee4c0f69
PE
7003 * emacs.c (fatal_error_signal_hook): Remove.
7004 All uses removed. This leftover from old code was always 0.
7005
17c05d74
PE
7006 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
7007 * casefiddle.c (casify_object, casify_region):
7008 * casetab.c (set_case_table):
7009 * category.c, category.h (word_boundary_p):
7010 * category.h (CHAR_HAS_CATEGORY):
7011 Use bool for booleans, instead of int.
7012
391ceac5
EZ
70132012-08-25 Eli Zaretskii <eliz@gnu.org>
7014
7015 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
7016
2f221583
PE
70172012-08-25 Paul Eggert <eggert@cs.ucla.edu>
7018
f4a681b0
PE
7019 On assertion failure, print backtrace if available.
7020 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
7021 (die) [ENABLE_CHECKING]: Print a backtrace if available.
7022 * Makefile.in (LIB_EXECINFO): New macro.
7023 (LIBES): Use it.
7024
2f221583
PE
7025 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
7026 * bytecode.c (exec_byte_code):
7027 * callint.c (check_mark, Fcall_interactively):
7028 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
7029 (getenv_internal, sync_process_alive, call_process_exited):
7030 * lisp.h (USE_SAFE_ALLOCA):
7031 Use bool for booleans, instead of int.
7032 * lisp.h, process.h: Adjust prototypes to match above changes.
7033 * callint.c (Fcall_interactively): Don't assume the mark's
7034 offset fits in 'int'.
7035
37ef52bb
PE
70362012-08-24 Paul Eggert <eggert@cs.ucla.edu>
7037
7038 * buffer.c, buffer.h: Use bool for boolean.
7039 * buffer.c (reset_buffer_local_variables)
7040 (buffer_lisp_local_variables, Fset_buffer_modified_p)
7041 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
7042 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
7043 (overlay_touches_p, overlay_strings, Foverlay_put)
7044 (report_overlay_modification, call_overlay_mod_hooks):
7045 (mmap_enlarge, mmap_set_vars):
7046 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
7047 Use bool for booleans, instead of int.
7048 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
7049 since the 1-or-0 return value is always ignored anyway.
7050 (mmap_initialized_p):
7051 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
7052 * buffer.h, lisp.h: Adjust prototypes to match above changes.
7053
2cc21167
PE
70542012-08-23 Paul Eggert <eggert@cs.ucla.edu>
7055
7056 * bidi.c: Use bool for boolean.
7057 This is a bit more readable, and makes the text segment of bidi.o
7058 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
7059 Presumably it's faster too.
7060 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
7061 Now bool.
7062 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7063 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
7064 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
7065 (bidi_explicit_dir_char, bidi_level_of_next_char)
7066 (bidi_find_other_level_edge, bidi_move_to_visually_next):
7067 Use bool for booleans, instead of int.
7068 * dispextern.h (bidi_init_it, bidi_paragraph_init)
7069 (bidi_unshelve_cache): Adjust decls to match code.
7070
7db4ddf4
MR
70712012-08-23 Martin Rudalics <rudalics@gmx.at>
7072
7073 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
7074 argument.
7075
b1bb8011
PE
70762012-08-23 Paul Eggert <eggert@cs.ucla.edu>
7077
7078 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
7079 * atimer.h: Include <stdbool.h>.
7080
ff687885
DN
70812012-08-22 Dan Nicolaescu <dann@gnu.org>
7082
7083 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
7084 compile time tests instead of run time tests on systems that do
7085 not use them.
7086 (FRAME_MAC_P): Remove leftover from deleted code.
7087 * frame.c (syms_of_frame): Remove leftover from deleted code.
7088
4ce7a138
JD
70892012-08-22 Jan Djärv <jan.h.d@swipnet.se>
7090
7091 * nsterm.m (insertText:): Don't clear modifiers if code is space.
7092
d733ec6d
PE
70932012-08-22 Paul Eggert <eggert@cs.ucla.edu>
7094
7095 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
7096 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 7097 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
7098 (fontset_add): Return void, for FONTSET_ADD.
7099
d0d2d26f
PE
71002012-08-21 Paul Eggert <eggert@cs.ucla.edu>
7101
fce31d69
PE
7102 * alloc.c: Use bool for booleans.
7103 (gc_in_progress, abort_on_gc)
7104 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
7105 (dont_register_blocks) [GC_MALLOC_CHECK]:
7106 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
7107 (check_string_bytes, make_specified_string, memory_full)
7108 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
7109 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
7110 (mark_stack, valid_pointer_p, make_pure_string)
7111 (Fgarbage_collect, survives_gc_p, gc_sweep):
7112 Use bool for booleans, instead of int.
7113 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
7114 Remove unused local.
7115 * alloc.c (PURE_POINTER_P):
7116 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
7117 * editfns.c (Fformat):
7118 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
7119 (Fdo_auto_save):
7120 * fns.c (sweep_weak_table):
7121 * lisp.h (suppress_checking, push_message, survives_gc_p)
7122 (make_pure_string, gc_in_progress, abort_on_gc):
7123 * lread.c (readchar, read1):
7124 * print.c (Fprin1_to_string):
7125 * xdisp.c (push_message):
7126 Use bool for booleans affected directly or indirectly by
7127 alloc.c's changes.
7128
d0d2d26f
PE
7129 Make recently-introduced setters macros.
7130 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
7131 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
7132 (set_fontset_default, set_fontset_fallback): Rename from their
7133 upper-case counterparts, and make them functions rather than macros.
7134 This is more consistent with the other recently-introduced setters.
7135 These don't need to be inline, since they're local.
7136
d18e2bb6
JD
71372012-08-21 Jan Djärv <jan.h.d@swipnet.se>
7138
7139 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
7140 the loop (Bug#12247).
7141
1b9d9d16
PE
71422012-08-21 Paul Eggert <eggert@cs.ucla.edu>
7143
7144 * lisp.h (vcopy): Use memcpy rather than our own loop.
7145 This fixes a performance regression introduced by the recent
7146 addition of vcopy. This means 'vcopy' will need to be modified
7147 for a copying collector, but that's OK. Also, tighten the
7148 checking in the assertion.
7149
b2f09701
EZ
71502012-08-21 Eli Zaretskii <eliz@gnu.org>
7151
7152 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
7153 components for RTL text (Bug#11860). Adjust X-OFFSET of each
7154 non-base glyph for the width of the base character, according to
e1f29348
BR
7155 what x_draw_composite_glyph_string_foreground expects.
7156 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
7157 expectations, to produce correct width of the composed character.
7158 Reverse the sign of the DU offset produced by ScriptPlace.
7159
9b994fed
PE
71602012-08-21 Paul Eggert <eggert@cs.ucla.edu>
7161
7162 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
7163
086ca913
DA
71642012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
7165
7166 Avoid direct writes to contents member of struct Lisp_Vector.
7167 * lisp.h (vcopy): New function to copy data into vector.
7168 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
7169 * fns.c (Ffillarray): Use ASET.
7170 * keyboard.c (timer_check_2): Use AREF and ASET.
7171 (append_tool_bar_item, Frecent_keys): Use vcopy.
7172 * lread.c (read_vector): Use ASET.
7173 * msdos.c (Frecent_doskeys): Use vcopy.
7174 * xface.c (Finternal_copy_lisp_face): Use vcopy.
7175 (Finternal_merge_in_global_face): Use ASET and vcopy.
7176 * xfont.c (xfont_list_pattern): Likewise.
7177
5481664a
MR
71782012-08-21 Martin Rudalics <rudalics@gmx.at>
7179
7180 * window.c (Fwindow_point): For the selected window always return
7181 the position of its buffer's point.
7182 (Fset_window_point): For the selected window always go in its
7183 buffer to the specified position.
7184
6d470bdd
DA
71852012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
7186
7187 Setter macros for fontsets.
7188 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
7189 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
7190 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
7191 Adjust users.
7192
24564fe1
GM
71932012-08-20 Glenn Morris <rgm@gnu.org>
7194
7195 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
7196 Don't assume that `ln -f' works.
7197
0a05a035
EZ
71982012-08-20 Eli Zaretskii <eliz@gnu.org>
7199
7200 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
7201 and later about non-assignments with no effect. See discussion at
7202 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
7203 details.
7204
e46f2325
DA
72052012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
7206
7207 Inline setter functions for Lisp_Objects slots of struct specbinding.
7208 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
7209 Adjust users.
7210
734fbd86
MR
72112012-08-20 Martin Rudalics <rudalics@gmx.at>
7212
7213 * window.c (select_window): Always make selected window's buffer
7214 current.
7215
f1a95992
DA
72162012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
7217
7218 Use AREF and ASET for docstrings of category tables.
7219 * category.h (CATEGORY_DOCSTRING): Use AREF.
7220 (SET_CATEGORY_DOCSTRING): Use ASET.
7221 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
7222
e83064be
DA
72232012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
7224
7225 Inline setter functions for hash table members.
7226 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
7227 (set_hash_hash, set_hash_index): Rename with _slot suffix.
7228 (set_hash_key_and_value, set_hash_index, set_hash_next)
7229 (set_hash_hash): New functions.
7230 * charset.c, fns.c: Adjust users.
7231
4ce60d2e
DA
72322012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
7233
7234 Inline getter and setter functions for per-buffer values.
7235 * buffer.h (per_buffer_default, set_per_buffer_default)
7236 (per_buffer_value, set_per_buffer_value): New functions.
7237 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
7238 * buffer.c, data.c: Adjust users.
7239
c06c9690
JB
72402012-08-20 Juanma Barranquero <lekktu@gmail.com>
7241
7242 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
7243
32bd4250
PE
72442012-08-19 Paul Eggert <eggert@cs.ucla.edu>
7245
bad03192 7246 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
7247 as gnulib does this if the system doesn't.
7248 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
7249 Remove declaration. MS-Windows declares it on stdlib.h which is
7250 included by conf_post.h.
b69a6d22
PE
7251 * emacs.c (environ) [DOUG_LEA_MALLOC]:
7252 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
7253 * vm-limit.c: Include <unistd.h>, for 'environ'.
7254
22d7feb2
PE
7255 * unexaix.c, unexcoff.c: Include "mem-limits.h".
7256 (start_of_data): Remove decl; mem-limits.h provides it.
7257
32bd4250
PE
7258 * xdisp.c (handle_invisible_prop): Make it a bit faster
7259 and avoid a gcc -Wmaybe-uninitialized diagnostic.
7260
450809af
CY
72612012-08-19 Chong Yidong <cyd@gnu.org>
7262
7263 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
7264 ends (Bug#3874).
7265
9e677988
AS
72662012-08-19 Andreas Schwab <schwab@linux-m68k.org>
7267
6b1319ce
AS
7268 * .gdbinit: Use call instead of set when calling a function in the
7269 inferior.
7270
9e677988
AS
7271 * data.c (set_internal): Don't use set_blv_found.
7272 (Fkill_local_variable): Likewise.
7273
d7191076
AA
72742012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
7275
7276 * nsfont.m (ns_ascii_average_width): Ensure the string
7277 ascii_printable is initialized with a null-terminated character
7278 array. Otherwise, it can contain undesired extra characters.
7279
e757f1c6
PE
72802012-08-18 Paul Eggert <eggert@cs.ucla.edu>
7281
7282 port new setting code to Sun C 5.8 2005/10/13
7283 * chartab.c, lisp.h (char_table_set, char_table_set_range):
7284 Return void, not Lisp_Object. Otherwise, the compiler
7285 complains about (A?B:C) where B is void and C is Lisp_Object
7286 when compiling CHAR_TABLE_SET, due to the recent change to
7287 the API of sub_char_table_set_contents.
7288
a999ce26
CY
72892012-08-18 Chong Yidong <cyd@gnu.org>
7290
7291 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
7292 for the string case (Bug#3874).
7293
3f22b86f
PE
72942012-08-18 Paul Eggert <eggert@cs.ucla.edu>
7295
39eb03f1
PE
7296 * buffer.h (BSET): Remove (Bug#12215).
7297 Replace all uses with calls to new setter functions.
7298 (bset_bidi_paragraph_direction, bset_case_canon_table)
7299 (bset_case_eqv_table, bset_directory, bset_display_count)
7300 (bset_display_time, bset_downcase_table)
7301 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
7302 (bset_last_selected_window, bset_local_var_alist)
7303 (bset_mark_active, bset_point_before_scroll, bset_read_only)
7304 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
7305 (bset_width_table):
7306 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
7307 (bset_auto_fill_function, bset_auto_save_file_format)
7308 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
7309 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
7310 (bset_cache_long_line_scans, bset_case_fold_search)
7311 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
7312 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
7313 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
7314 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
7315 (bset_header_line_format, bset_indicate_buffer_boundaries)
7316 (bset_indicate_empty_lines, bset_invisibility_spec)
7317 (bset_left_fringe_width, bset_major_mode, bset_mark)
7318 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
7319 (bset_name, bset_overwrite_mode, bset_pt_marker)
7320 (bset_right_fringe_width, bset_save_length)
7321 (bset_scroll_bar_width, bset_scroll_down_aggressively)
7322 (bset_scroll_up_aggressively, bset_selective_display)
7323 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
7324 (bset_word_wrap, bset_zv_marker):
7325 * category.c (bset_category_table):
7326 * syntax.c (bset_syntax_table):
7327 New setter functions.
7328
6a09a33b
PE
7329 * process.h (PSET): Remove (Bug#12215).
7330 Replace all uses with calls to new setter functions.
7331 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
7332 (PROCESS_INLINE): New macro.
7333 (pset_childp): New setter function.
7334 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
7335 * process.c (PROCESS_INLINE):
7336 Define to EXTERN_INLINE, so that the corresponding functions
7337 are compiled into code.
7338 (pset_buffer, pset_command, pset_decode_coding_system)
7339 (pset_decoding_buf, pset_encode_coding_system)
7340 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
7341 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
7342 (pset_type, pset_write_queue): New setter functions.
7343
e8c17b81
PE
7344 * window.h (WSET): Remove (Bug#12215).
7345 Replace all uses with calls to new setter functions.
7346 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
7347 (WINDOW_INLINE): New macro.
7348 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
7349 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
7350 (wset_total_lines, wset_vertical_scroll_bar)
7351 (wset_window_end_pos, wset_window_end_valid)
7352 (wset_window_end_vpos): New setter functions.
7353 * window.c (WINDOW_INLINE):
7354 Define to EXTERN_INLINE, so that the corresponding functions
7355 are compiled into code.
7356 (wset_combination_limit, wset_dedicated, wset_display_table)
7357 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
7358 (wset_new_normal, wset_new_total, wset_next_buffers)
7359 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
7360 (wset_prev_buffers, wset_right_fringe_width)
7361 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
7362 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
7363 (wset_window_parameters):
7364 * xdisp.c (wset_base_line_number, wset_base_line_pos)
7365 (wset_column_number_displayed, wset_region_showing):
7366 New setter functions.
7367
3f22b86f
PE
7368 * termhooks.h (TSET): Remove (Bug#12215).
7369 Replace all uses with calls to new setter functions.
7370 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
7371 (TERMHOOKS_INLINE): New macro.
7372 (tset_charset_list, tset_selection_alist): New setter functions.
7373 * terminal.c (TERMHOOKS_INLINE):
7374 Define to EXTERN_INLINE, so that the corresponding functions
7375 are compiled into code.
7376 (tset_param_alist): New setter function.
7377
742af32f
PE
73782012-08-17 Paul Eggert <eggert@cs.ucla.edu>
7379
15dbb4d6
PE
7380 * keyboard.h (KSET): Remove (Bug#12215).
7381 Replace all uses with calls to new setter functions.
7382 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
7383 (KEYBOARD_INLINE): New macro.
7384 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
7385 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
7386 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
7387 New setter functions.
7388 * keyboard.c (KEYBOARD_INLINE):
7389 Define to EXTERN_INLINE, so that the corresponding functions
7390 are compiled into code.
7391 (kset_echo_string, kset_kbd_queue)
7392 (kset_keyboard_translate_table, kset_last_prefix_arg)
7393 (kset_last_repeatable_command, kset_local_function_key_map)
7394 (kset_overriding_terminal_local_map, kset_real_last_command)
7395 (kset_system_key_syms): New setter functions.
7396
f00af5b1
PE
7397 * frame.h (FSET): Remove (Bug#12215).
7398 Replace all uses with calls to new setter functions.
7399 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
7400 (FRAME_INLINE): New macro.
7401 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
7402 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
7403 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
7404 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
7405 (fset_param_alist, fset_root_window, fset_scroll_bars)
7406 (fset_selected_window, fset_title, fset_tool_bar_items)
7407 (fset_tool_bar_position, fset_tool_bar_window): New functions.
7408 * frame.c (FRAME_INLINE):
7409 Define to EXTERN_INLINE, so that the corresponding functions
7410 are compiled into code.
7411 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
7412
0c94c8d6
PE
7413 A few more naming-convention fixes for getters and setters.
7414 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
7415 and rename from buffer_overlays_set_before.
7416 (set_buffer_overlays_after): Move here from buffer.h, and rename
7417 from buffer_overlays_set_after.
7418 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
7419 All uses changed.
7420 (set_buffer_intervals): Rename from buffer_set_intervals.
7421 * intervals.c (set_interval_object): Move here from intervals.h,
7422 and rename from interval_set_object.
7423 (set_interval_left): Move here from intervals.h, and rename from
7424 interval_set_left.
7425 (set_interval_right): Move here from intervals.h, and rename from
7426 interval_set_right.
7427 (copy_interval_parent): Move here from intervals.h, and rename from
7428 interval_copy_parent.
7429 * intervals.h (set_interval_parent): Rename from interval_set_parent.
7430 (set_interval_plist): Rename from interval_set_plist.
7431 Return void, not Lisp_Object, since no caller uses the result.
7432 * lisp.h (string_intervals): Rename from string_get_intervals.
7433 (set_string_intervals): Rename from string_set_intervals.
7434
34dabdb7
PE
7435 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
7436 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 7437 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
7438 All uses changed. See the end of
7439 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
7440
742af32f
PE
7441 * lisp.h (CSET): Remove (Bug#12215).
7442 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
7443 (set_char_table_purpose): New functions,
7444 replacing CSET. All uses changed. For example, replace
7445 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 7446 "set_char_table_parent (char_table, parent);".
742af32f
PE
7447 The old version was confusing because it used the same name
7448 'parent' for two different things.
7449
a04e2c62
DA
74502012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
7451
7452 Functions to get and set Lisp_Object fields of buffer-local variables.
7453 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
7454 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
7455 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
7456 * data.c, eval.c, frame.c: Adjust users.
7457
383dcbf9
CY
74582012-08-17 Chong Yidong <cyd@gnu.org>
7459
7460 * xfaces.c (merge_face_vectors): If the target font specfies a
7461 font spec, make the font's attributes take precedence over
7462 directly-specified attributes.
7463 (merge_face_ref): Recognize :font.
7464
44386687
DA
74652012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
7466
7467 Do not use memcpy for copying intervals.
7468 * intervals.c (reproduce_interval): New function.
7469 (reproduce_tree, reproduce_tree_obj): Use it.
7470 (reproduce_tree_obj): Remove prototype.
7471
927c7216
PE
74722012-08-17 Paul Eggert <eggert@cs.ucla.edu>
7473
7474 * lisp.h (duration_to_sec_usec): Remove unused decl.
7475
93044f7b
AA
74762012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
7477
7478 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
7479 to an allocated instance of NSString, not to the class itself.
7480
9851e4a5
JB
74812012-08-17 Juanma Barranquero <lekktu@gmail.com>
7482
7483 * makefile.w32-in (C_CTYPE_H): New macro.
7484 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
7485 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
7486 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
7487
620f13b0
PE
74882012-08-16 Paul Eggert <eggert@cs.ucla.edu>
7489
7490 Use ASCII tests for character types.
7491 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
7492 * xfns.c, xterm.c:
7493 Don't include <ctype.h>; was not needed.
7494 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
7495 * sysdep.c, xfaces.c:
7496 Include <c-ctype.h> instead of <ctype.h>.
7497 * nsterm.m: Include <c-ctype.h>.
7498 * charset.c (read_hex):
7499 * doc.c (Fsnarf_documentation):
7500 * fileio.c (IS_DRIVE) [WINDOWSNT]:
7501 (DRIVE_LETTER) [DOS_NT]:
7502 (Ffile_name_directory, Fexpand_file_name)
7503 (Fsubstitute_in_file_name):
7504 * font.c (font_parse_xlfd, font_parse_fcname):
7505 * frame.c (x_set_font_backend):
7506 * gtkutil.c (xg_get_font):
7507 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
7508 * nsimage.m (hexchar):
7509 * nsterm.m (ns_xlfd_to_fontname):
7510 * sysdep.c (system_process_attributes):
7511 * xfaces.c (hash_string_case_insensitive):
7512 Use C-locale tests instead of locale-specific tests for character
7513 types, since we want the ASCII interpretation here, not the
7514 interpretation suitable for whatever happens to be the current locale.
7515
52162052
MR
75162012-08-16 Martin Rudalics <rudalics@gmx.at>
7517
7518 Consistently check windows for validity/liveness
7519 (Bug#11984, Bug#12025, Bug#12026).
7520 * lisp.h (CHECK_VALID_WINDOW): New macro.
7521 * window.c (decode_window): Rename to decode_live_window.
7522 (decode_valid_window, Fwindow_valid_p): New functions.
7523 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
7524 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
7525 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
7526 (Fwindow_prev_sibling, Fwindow_combination_limit)
7527 (Fset_window_combination_limit, Fwindow_use_time)
7528 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
7529 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
7530 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
7531 (Fwindow_hscroll, Fset_window_hscroll)
7532 (Fwindow_redisplay_end_trigger)
7533 (Fset_window_redisplay_end_trigger, Fwindow_edges)
7534 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
7535 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7536 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
7537 (Fwindow_end, Fset_window_point, Fset_window_start)
7538 (Fpos_visible_in_window_p, Fwindow_line_height)
7539 (Fwindow_dedicated_p, Fset_window_dedicated_p)
7540 (Fwindow_prev_buffers, Fset_window_prev_buffers)
7541 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
7542 (Fset_window_parameter, Fwindow_display_table)
7543 (Fset_window_display_table, Fdelete_other_windows_internal)
7544 (Fset_window_buffer, Fset_window_new_total)
7545 (Fset_window_new_normal, Fdelete_window_internal)
7546 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
7547 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
7548 (Fwindow_scroll_bars): Check whether argument window is a valid or
7549 live window. Update doc-strings.
7550 (syms_of_window): New symbol Qwindow_valid_p.
7551 * keyboard.c (Fposn_at_x_y): Check whether argument
7552 frame_or_window denotes a valid window.
7553
2751c80f
DA
75542012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
7555
7556 Fix previous char table change.
7557 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
7558 * chartab.c (optimize_sub_char_table): Likewise.
7559
032a42c8
CY
75602012-08-16 Chong Yidong <cyd@gnu.org>
7561
a2d19368
CY
7562 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
7563
032a42c8
CY
7564 * xfont.c (xfont_open):
7565 * xftfont.c (xftfont_open): Set the font's max_width field.
7566
7567 * nsfont.m (nsfont_open): Similar to the Xft backend, set
7568 min_width to space_width and average_width to the average over
7569 printable ASCII characters.
7570 (ns_char_width): Code cleanup.
7571 (ns_ascii_average_width): New utility function.
7572
7573 * font.h (struct font): Update comments.
7574
a098c930
DA
75752012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
7576
032a42c8 7577 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
7578 * lisp.h (CSET): New macro.
7579 (char_table_set_extras, char_table_set_contents)
7580 (sub_char_table_set_contents): New function.
7581 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
7582 * syntax.c: Adjust users.
7583
8be3a09c
SM
75842012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
7585
7586 * eval.c (eval_sub): Bind lexical-binding.
7587 * lread.c (Qlexical_binding): Make non-static.
7588
ac4845a6
JD
75892012-08-15 Jan Djärv <jan.h.d@swipnet.se>
7590
ddee6515
JD
7591 * nsmenu.m (popupSession): Remove.
7592 (pop_down_menu): Remove endModalSession.
7593 (timeout_handler:): New method.
7594 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
7595 Call runModalForWindow. Check timer_fired when it returns.
7596 If not set, cancel timer and break out of loop.
7597 Otherwise loop again, with a new timeout.
7598
7599 * nsterm.m: Include fcntl.h if present.
7600 (fd_entry, t_readfds, inNsSelect): Remove.
7601 (select_writefds, select_valid, select_timeout, selfds)
7602 (select_mutex, apploopnr): Add.
7603 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
7604 Otherwise call kbd_buffer_store_event.
7605 (ns_send_appdefined): Remove release of fd_entry.
7606 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
7607 Increment and decrement apploopnr.
7608 (ns_select): If no file descriptors, just do a NSTimer.
7609 Otherwise copy read/write masks and start select thread (fd_handler).
7610 Start main loop and wait for application defined event.
7611 Inform select thread to stop selecting after main loop is exited.
7612 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 7613 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
7614 (fd_handler:): Loop forever, wait for info from the main thread
7615 to either start or stop selecting. When select returns, send
7616 and appdefined event.
7617 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
7618 If not call kbd_buffer_store_event.
7619
7620 * nsterm.h (EmacsApp): fd_handler takes id argument.
7621 (EmacsDialogPanel): Add timer_fired and timeout_handler.
7622
ac4845a6
JD
7623 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
7624
eb424fe3
EZ
76252012-08-15 Eli Zaretskii <eliz@gnu.org>
7626
7627 * region-cache.c (move_cache_gap): Update gap_len using the actual
7628 growth of the boundaries array. Do not change cache_len.
7629 (Bug#12196)
7630
4e6a86c6
DA
76312012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
7632
7633 Generalize and cleanup font subsystem checks.
7634 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
7635 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
7636 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 7637
5bf192ca
DA
76382012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
7639
7640 * gtkutil.c (xg_get_font): Use pango_units_to_double.
7641
f2045622
CY
76422012-08-15 Chong Yidong <cyd@gnu.org>
7643
8be3a09c
SM
7644 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
7645 When using the new font chooser, use gtk_font_chooser_get_font_desc to
7646 extract the font descriptor instead of just the font name.
7647 In that case, return a font spec instead of a string.
f2045622
CY
7648 (x_last_font_name): Move to this file from xfns.c.
7649
7650 * xfns.c (Fx_select_font): The return value can also be a font
7651 spec. Move x_last_font_name management to gtkutil.c.
7652
7653 * xfaces.c: Make font weight and style symbols non-static.
7654
7f6feb56
SM
76552012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
7656
7657 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
7658 (bug#12117).
7659
fecbd8ff
SM
76602012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
7661
7662 * alloc.c (Fgarbage_collect): Use plural form consistently.
7663
9b8d5165
EZ
76642012-08-14 Eli Zaretskii <eliz@gnu.org>
7665
7666 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
7667 iteration through the command loop. Fixes a problem whereby mouse
7668 movements are ignored until the first mouse click.
7669
f5d9e83a
PE
76702012-08-14 Paul Eggert <eggert@cs.ucla.edu>
7671
7672 Use bool, not int, for Lisp booleans.
7673 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
7674 makes Emacs a bit smaller and presumably a bit faster.
7675 * lisp.h: Include <stdbool.h>.
7676 (struct Lisp_Boolfwd, defvar_bool):
7677 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
7678 * regex.c [!emacs]: Include <stdbool.h>.
7679 (false, true): Remove; <stdbool.h> does this for us now.
7680
55802e4a
CY
76812012-08-14 Chong Yidong <cyd@gnu.org>
7682
4abcdac8
CY
7683 * character.c (Fcharacterp): Doc fix (Bug#12076).
7684
7685 * data.c (Findirect_variable): Doc fix (Bug#11040).
7686
55802e4a
CY
7687 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
7688
7689 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 7690 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 7691
8e99d072
BR
76922012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
7693
7694 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
7695 (bug#12022).
7696
08908aca
MR
76972012-08-14 Martin Rudalics <rudalics@gmx.at>
7698
7699 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
7700 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
7701 * minibuf.c (choose_minibuf_frame, read_minibuf):
7702 * w32fns.c (x_create_tip_frame):
7703 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
7704 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
7705
56120d6f
PE
77062012-08-14 Paul Eggert <eggert@cs.ucla.edu>
7707
7708 * intervals.c (offset_intervals): Remove obsolete comment.
7709
67b77c0b
AS
77102012-08-14 Andreas Schwab <schwab@linux-m68k.org>
7711
7712 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
7713
f48b82fd
GR
77142012-08-14 Gergely Risko <gergely@risko.hu>
7715
7716 * coding.c (decode_coding): Record buffer modification before
7717 disabling undo_list (Bug#11773).
7718
fd318b54
DA
77192012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
7720
7721 Revert and cleanup some recent overlay changes.
7722 * buffer.h (enum overlay_type): Remove.
7723 (buffer_get_overlays, buffer_set_overlays): Likewise.
7724 (buffer_set_overlays_before, buffer_set_overlays_after):
7725 New function. Adjust users.
7726 (unchain_both): Add eassert.
7727
41a62dd9
DA
77282012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
7729
7730 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
7731
5884c324
PE
77322012-08-14 Paul Eggert <eggert@cs.ucla.edu>
7733
7734 * gtkutil.c (xg_mark_data): Don't assume C99.
7735
ca06f160
JD
77362012-08-13 Jan Djärv <jan.h.d@swipnet.se>
7737
7738 * gtkutil.c (xg_frame_tb_info): New struct.
7739 (TB_INFO_KEY): New define.
7740 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
7741 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
7742 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
7743 if not present.
7744 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 7745 is up to date. Otherwise store new data.
ca06f160
JD
7746 (free_frame_tool_bar): Free xg_frame_tb_info if present.
7747
7864a3f7
DA
77482012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
7749
7750 Use KSET for write access to Lisp_Object members of struct kboard.
7751 * keyboard.h (KSET): New macro.
7752 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
7753 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
7754 * xterm.c: Adjust users.
7755
4c31be61
DA
77562012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
7757
7758 Use BSET for write access to Lisp_Object members of struct buffer.
7759 * buffer.h (BSET): New macro.
7760 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
7761 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
7762 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
7763 * window.c, xdisp.c, xfns.c: Adjust users.
7764
14ae4239
BT
77652012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
7766
7767 * lread.c (syms_of_lread): Initialize Vlexical_binding.
7768
32bcadb4
JD
77692012-08-11 Jan Djärv <jan.h.d@swipnet.se>
7770
3d29b2ce 7771 * nsterm.m (not_in_argv): New function.
fc0c31f8 7772 (application:openFile, application:openTempFile:):
3d29b2ce
JD
7773 (application:openFileWithoutUI:, application:openFiles:): Open file
7774 if not_in_argv returns non-zero (bug#12171).
7775
32bcadb4 7776 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
7777 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
7778 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
7779 (xg_get_font_name): Use those functions/macros here.
7780 Reported by Frans Oilinki <moilinki@gmail.com>.
7781
9ff9402d 77822012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
7783
7784 * unexmacosx.c (copy_data_segment): Copy initialized data in
7785 statically linked libraries from input file rather than memory.
7786
db74a5fc
YM
7787 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
7788 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
7789 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
7790
25e65510
GM
77912012-08-10 Glenn Morris <rgm@gnu.org>
7792
7793 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
7794 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
7795
7961135c
DA
77962012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
7797
7798 Fix last change to allow compilation with low optimization levels.
7799 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
7800 Reported by Jan Djärv <jan.h.d@swipnet.se>.
7801
42b3a444
DA
78022012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
7803
7804 Use common inline syntax in intervals.h.
7805 * intervals.h (INTERVALS_INLINE): New macro.
7806 Change all users from LISP_INLINE.
7807
9fb0c957
DA
78082012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
7809
7810 Define Qnone once for all platforms.
7811 * frame.c (Qnone): Define here.
7812 (syms_of_frame): DEFSYM it.
7813 * lisp.h (Qnone): New declaration.
7814 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
7815 * xfns.c: Remove duplication. Adjust users.
7816
65e8ee52
DA
78172012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
7818
7819 Remove unused macros from intervals.h.
7820 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
7821 * intervals.c: Adjust comment.
7822
9b855fd6
EZ
78232012-08-10 Eli Zaretskii <eliz@gnu.org>
7824
7825 * w32fns.c <w32_unicode_gui>: New static variable.
7826 (globals_of_w32fns): Initialize it according to os_subtype.
7827 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
7828 testing os_subtype.
7829
39cb9e56 78302012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
7831 Eli Zaretskii <eliz@gnu.org>
7832
7833 Fix bug #10299 with Unicode characters sent by customized
7834 keyboards created by MSKLC.
7835 * w32fns.c (INIT_WINDOW_CLASS): New macro.
7836 (w32_init_class): Use it to initialize the Emacs class with either
7837 ANSI or Unicode API calls.
7838 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
7839 later.
7840 (w32_wnd_proc): If the character code sent by WM_CHAR or
7841 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
7842 original message. Call DefWindowProcW on NT and later.
7843
9374581a
GM
78442012-08-10 Glenn Morris <rgm@gnu.org>
7845
4b94e8cf
GM
7846 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
7847
9374581a
GM
7848 * lisp.h (DIRECTORY_SEP): Let configure set it.
7849
a2752828
DA
78502012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
7851
7852 Use TSET for write access to Lisp_Object slots of struct terminal.
7853 * termhooks.h (TSET): New macro.
7854 * coding.c, terminal.c, xselect.c: Adjust users.
7855
cc92c454
SM
78562012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
7857
7858 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
7859 the failing expression, include them in the error message.
7860 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
7861 * lisp.h (internal_condition_case_n): Update declaration.
7862
4cb3e6b3
DA
78632012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
7864
7865 Inline functions to examine and change buffer overlays.
7866 * buffer.c (unchain_both): New function.
7867 * buffer.h (buffer_get_overlays, buffer_set_overlays):
7868 (buffer_has_overlays): New function.
7869 (enum overlay_type): New enum.
7870 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
7871 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
7872
8707c1e5
DA
78732012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
7874
7875 Inline functions to examine and change buffer intervals.
7876 * alloc.c (mark_interval_tree): Remove.
7877 (MARK_INTERVAL_TREE): Simplify.
7878 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
7879 * intervals.c (buffer_balance_intervals): New function.
7880 (graft_intervals_into_buffer): Adjust indentation.
7881 (set_intervals_multibyte): Simplify.
7882 * buffer.h (BUF_INTERVALS): Remove.
7883 (buffer_get_intervals, buffer_set_intervals): New function.
7884 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
7885 * intervals.c, textprop.c: Adjust users.
7886
ad8c997f
DA
78872012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
7888
7889 Inline functions to examine and change string intervals.
7890 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
7891 (string_get_intervals, string_set_intervals): New function.
7892 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
7893 * lread.c, print.c, textprop.c: Adjust users.
7894
32ac3a6b
GM
78952012-08-08 Glenn Morris <rgm@gnu.org>
7896
7897 * lisp.mk (lisp): Remove language/persian.elc.
7898
77c7bcb1
DA
78992012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
7900
7901 Cleanup intervals.
7902 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
7903 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
7904 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
7905 Adjust comment. Move under #if 0.
77c7bcb1
DA
7906 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
7907 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
7908
9c08a8d4
DA
79092012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
7910
7911 Check total length of intervals with eassert.
7912 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
7913 * intervals.c: Change all users to eassert.
7914
26d16b35
EZ
79152012-08-07 Eli Zaretskii <eliz@gnu.org>
7916
14ae4239
BT
7917 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
7918 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
7919 INTERNAL_FIELD in Lisp_Cons.
7920
c644523b
DA
79212012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
7922
7923 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
7924 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
7925 name since all xname users are fixed long time ago. Do not
7926 use INTERNAL_FIELD.
7927 (set_symbol_name, set_symbol_function, set_symbol_plist):
7928 (set_symbol_next, set_overlay_plist): New function.
7929 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
7930 (struct Lisp_Overlay): Likewise.
7931 (CVAR, MVAR, SVAR): Remove.
7932 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
7933 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
7934 * xterm.c: Adjust users.
7935 * .gdbinit: Change to use name field of struct Lisp_Symbol
7936 where appropriate.
7937
6a3d20cc
DA
79382012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
7939
7940 Basic functions to set Lisp_Object and pointer slots of intervals.
7941 * intervals.h (interval_set_parent, interval_set_object):
7942 (interval_set_left, interval_set_right, interval_set_plist):
7943 (interval_copy_parent): New function.
7944 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
7945 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
7946 Adjust indentation.
6a3d20cc
DA
7947 (INTERVAL_SIZE): Remove. Adjust users.
7948 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
7949
4d2b044c
DA
79502012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
7951
7952 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
7953 * process.h (PGET): Remove.
7954 (struct Lisp_Process): Do not use INTERNAL_FIELD.
7955 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
7956
d3d50620
DA
79572012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
7958
7959 Drop WGET and revert read access to Lisp_Objects slots of struct window.
7960 * window.h (WGET): Remove.
7961 (struct window): Do not use INTERNAL_FIELD.
7962 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
7963 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
7964 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
7965 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
7966 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
7967 Adjust users.
7968
d10a51dc
CY
79692012-08-07 Chong Yidong <cyd@gnu.org>
7970
7971 * window.c (Fwindow_edges, Fwindow_pixel_edges)
7972 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
7973 (Fdelete_window_internal): Signal an error if the window is not on
7974 a live frame (Bug#12025).
7975
e69b0960
DA
79762012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
7977
7978 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
7979 * frame.h (FGET): Remove.
7980 (struct frame): Do not use INTERNAL_FIELD.
7981 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
7982 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
7983 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
7984 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
7985
25a20a3a
JB
79862012-08-06 Juanma Barranquero <lekktu@gmail.com>
7987
7988 * w32.c: Silence compiler warnings.
7989 (map_w32_filename): Remove unused variable `is_fat'.
7990 (chase_symlinks): Add parentheses around expression.
7991
1c6f11f4
GM
79922012-08-06 Glenn Morris <rgm@gnu.org>
7993
1db4583a
GM
7994 * sysdep.c: Respect BROKEN_GETWD.
7995
1c6f11f4
GM
7996 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
7997 Let configure handle it.
7998 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
7999
2b90362b
DA
80002012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
8001
8002 Use GCALIGNMENT where appropriate.
8003 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
8004 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
8005 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
8006
5f50daf2
EZ
80072012-08-06 Eli Zaretskii <eliz@gnu.org>
8008
14ae4239
BT
8009 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
8010 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 8011
cbcc7007
SM
80122012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
8013
8014 * buffer.h (struct buffer): Revert `indirections' to a simple int;
8015 that should be sufficient for everyone.
8016
4d365fa4
JD
80172012-08-06 Jan Djärv <jan.h.d@swipnet.se>
8018
8019 * keyboard.c (timer_check_2): Add break so timer_check returns next
8020 timeout.
8021
dd86bd82
DA
80222012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
8023
8024 Fix Windows build errors introduced after converting to WGET and WSET.
8025 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
8026 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
8027
054e1668
JD
80282012-08-06 Jan Djärv <jan.h.d@swipnet.se>
8029
8030 * nsterm.m (ns_frame_rehighlight): Use FSET.
8031
8032 * nsmenu.m (ns_update_menubar): Use FSET.
8033
21238f11
DA
80342012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
8035
8036 Separate read and write access to Lisp_Object slots of Lisp_Process.
8037 * process.h (PGET, PSET): New macros similar to AREF and ASET.
8038 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
8039
077288cf
DA
80402012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
8041
8042 Separate read and write access to Lisp_Object slots of struct window.
8043 * window.h (WGET, WSET): New macros similar to AREF and ASET.
8044 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
8045 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
8046 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
8047 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
8048 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
8049 Adjust users.
8050
71688bd7
DA
80512012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
8052
8053 Fix Windows build errors introduced after converting to FGET and FSET.
8054 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
8055 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
8056 (w32_judge_scroll_bars): Change to use FSET.
8057 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
8058
f99bac93
DA
80592012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
8060
8061 Fix replacement typo.
8062 * window.c (replace_window): Set root_window instead of
8063 selected_window. This fixes a total window subsystem
8064 malfunction reported by Bastien Guerry <bzg@gnu.org>.
8065
8c2a0f2d
GM
80662012-08-06 Glenn Morris <rgm@gnu.org>
8067
8068 * lisp.mk (lisp): Add language/persian.elc.
8069
edd74c35
DA
80702012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
8071
8072 Separate read and write access to Lisp_Object slots of struct frame.
8073 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
8074 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
8075 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
8076 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
8077 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
8078
8671676c
AS
80792012-08-05 Andreas Schwab <schwab@linux-m68k.org>
8080
8081 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
8082
663e2b3f
DA
80832012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
8084
8085 Generalize common compile-time constants.
8086 * lisp.h (header_size, bool_header_size, word_size): Now here.
8087 (struct Lisp_Vector): Add comment.
8088 (struct Lisp_Bool_Vector): Move up to define handy constants.
8089 (VECSIZE, PSEUDOVECSIZE): Simplify.
8090 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
8091 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
8092 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
8093 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
8094 * xfont.c, xmenu.c: Use word_size where appropriate.
8095
d32e47af
LM
80962012-08-05 Lawrence Mitchell <wence@gmx.li>
8097
8098 * search.c (Freplace_match): Treat \? in the replacement text
8099 literally (Bug#8161).
8100
e5d9c0d1
CY
81012012-08-05 Chong Yidong <cyd@gnu.org>
8102
8103 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
8104 * frame.c (Vdelete_frame_functions):
8105 * emacs.c (Vkill_emacs_hook): Doc fix.
8106
8da0576b
EZ
81072012-08-04 Eli Zaretskii <eliz@gnu.org>
8108
8109 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
8110 --with-x-toolkit=no builds.
8111 Reported by Carsten Mattner <carstenmattner@gmail.com>.
8112
02676e5d
CY
81132012-08-04 Chong Yidong <cyd@gnu.org>
8114
8115 * syntax.c (Fmodify_syntax_entry): Doc fix.
8116
97147da9
EZ
81172012-08-04 Eli Zaretskii <eliz@gnu.org>
8118
76151e2c
EZ
8119 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
8120 * w32.c (init_environment): Change the default values of many
8121 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
8122 them into environment when they were not already defined.
8123 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 8124 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
8125 (check_windows_init_file): Now external, not static.
8126 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
8127 called when Vload_path is already set up.
8128
8129 * w32.h (check_windows_init_file): Add prototype.
8130
8131 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
8132 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
8133 compatibility with Posix platforms.
8134 (main): Move the call to check_windows_init_file to here from
8135 w32.c.
8136 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
8137 any, in the DEFALT argument into the root of the Emacs build or
8138 installation tree, as appropriate.
8139
8140 * callproc.c (init_callproc_1): Call decode_env_path instead of
8141 doing its equivalent by hand.
8142 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
8143 the code that sets Vexec_path run on MS-Windows.
8144
8145 * lread.c (init_lread): Add comments to #ifdef's.
8146
97147da9
EZ
8147 * msdos.c (dos_set_window_size, IT_update_begin)
8148 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
8149 instead of direct references.
8150
185ee146
PE
81512012-08-04 Paul Eggert <eggert@cs.ucla.edu>
8152
8153 Export DEFAULT_REHASH_* to GDB.
8154 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
8155 Now constants, not macros.
8156
8834c57a
PE
81572012-08-03 Paul Eggert <eggert@cs.ucla.edu>
8158
98c6f1e3
PE
8159 Remove unnecessary casts involving pointers.
8160 These casts are no longer needed now that we assume C89 or later,
8161 since they involve casting to or from void *.
8162 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
8163 (make_pure_float, make_pure_vector):
8164 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
8165 * macros.c (Fstart_kbd_macro):
8166 * menu.c (find_and_return_menu_selection):
8167 * minibuf.c (read_minibuf_noninteractive):
8168 * sysdep.c (closedir):
8169 * xdisp.c (x_produce_glyphs):
8170 * xfaces.c (compare_fonts_by_sort_order):
8171 * xfns.c (x_real_positions, select_visual):
8172 * xselect.c (x_stop_queuing_selection_requests)
8173 (x_get_window_property, x_get_window_property_as_lisp_data):
8174 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
8175 Remove unnecessary pointer casts.
8176 * alloc.c (record_xmalloc): New function.
8177 * lisp.h (record_xmalloc): New decl.
8178 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
8179 more like a function. This is because the pointer cast is not
8180 needed. All uses changed.
8181 * print.c (print_string, print_error_message): Avoid length recalc.
8182
8834c57a
PE
8183 Improve fix for macroexp crash with debugging (Bug#12118).
8184 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
8185 ARRAY_MARK_FLAG when checking subscripts, because ASET is
8186 not supposed to be invoked from the garbage collector.
8187 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
8188 (gc_aset): New function, which is like ASET but can be
8189 used in the garbage collector.
8190 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
8191 (set_hash_index): Use it instead of ASET.
8192
6dad7178
EZ
81932012-08-03 Eli Zaretskii <eliz@gnu.org>
8194
8195 Support symlinks on latest versions of MS-Windows.
8196 * w32.c: Include winioctl.h and aclapi.h.
8197 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
8198 (revert_to_self): Forward declarations of static functions.
8199 <static BOOL g_b_init_get_security_info>:
8200 <g_b_init_create_symbolic_link>: New static flags.
8201 (globals_of_w32): Initialize them to zero.
8202 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
8203 (map_w32_filename): Improve commentary. Simplify switch.
8204 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
8205 headers (most versions of MinGW w32api don't).
8206 (get_security_info, create_symbolic_link)
8207 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
8208 New functions.
8209 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
8210 in the argument file name.
8211 (sys_access): Call unc_volume_file_attributes only if
8212 GetFileAttributes fails with network-related error codes.
8213 (sys_rename): Diagnose renaming of a symlink when the user doesn't
8214 have the required privileges.
14ae4239 8215 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
8216 get_file_security_desc.
8217 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
8218 with addition of handling of symlinks and support for 'lstat'.
8219 If possible, get file's attributes and security information by
6dad7178
EZ
8220 handle, not by name. Produce S_IFLNK bit for symlinks, when
8221 called from 'lstat'.
8222 (stat, lstat): New functions, call 'stat_worker'.
8223 (symlink, readlink, careadlinkat): Rewritten to create and resolve
8224 symlinks when the underlying filesystem supports them.
8225
f162bcc3
PE
82262012-08-02 Paul Eggert <eggert@cs.ucla.edu>
8227
79ea6c20
PE
8228 Fix macroexp crash on Windows with debugging (Bug#12118).
8229 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
8230 checking subscripts; problem introduced with the recent
8231 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
8232 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
8233 since it's used in non-static inline functions now.
8234
c0ce93fd
PE
8235 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
8236 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 8237
f162bcc3
PE
8238 Use C99-style 'extern inline' if available.
8239 * buffer.h (BUFFER_INLINE):
8240 * category.h (CATEGORY_INLINE):
8241 * character.h (CHARACTER_INLINE):
8242 * charset.h (CHARSET_INLINE):
8243 * composite.h (COMPOSITE_INLINE):
8244 * dispextern.h (DISPEXTERN_INLINE):
8245 * lisp.h (LISP_INLINE):
8246 * systime.h (SYSTIME_INLINE):
8247 New macro, replacing 'static inline' in this header.
8248 * buffer.h, category.h, character.h, charset.h, composite.h:
8249 * dispextern.h, lisp.h, systime.h:
8250 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
8251 * alloc.c (LISP_INLINE):
8252 * buffer.c (BUFFER_INLINE):
8253 * category.c (CATEGORY_INLINE):
8254 * character.c (CHARACTER_INLINE):
8255 * charset.c (CHARSET_INLINE):
8256 * composite.c (COMPOSITE_INLINE):
8257 * dispnew.c (DISPEXTERN_INLINE):
8258 * sysdep.c (SYSTIME_INLINE):
8259 Define to EXTERN_INLINE, so that the corresponding functions
8260 are compiled into code.
8261 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
8262 (INLINE_HEADER_END): New macros.
8263 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
8264 since it's used in non-static inline functions now.
a8333d03 8265 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 8266
837b365b
GM
82672012-08-02 Glenn Morris <rgm@gnu.org>
8268
d66b744d
GM
8269 * s/: Remove empty directory.
8270
837b365b
GM
8271 * s/ms-w32.h: Move to ../nt/inc.
8272 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
8273 Update for new ms-w32.h location.
8274
13294f95
PE
82752012-08-02 Paul Eggert <eggert@cs.ucla.edu>
8276
8277 Port to Solaris 8.
8278 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
8279
90df0db3
GM
82802012-08-02 Glenn Morris <rgm@gnu.org>
8281
8282 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
8283 hard-coding the path separator.
8284
4939150c
PE
82852012-08-01 Paul Eggert <eggert@cs.ucla.edu>
8286
8287 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
8288 This how ASET and AREF are supposed to work, and makes
8289 it easier to think about future improvements. See
8290 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
8291 * charset.h (set_charset_attr): New function.
8292 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
8293 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
8294 (aref_addr): New function. All uses of &AREF(...) changed.
8295 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
8296 (set_hash_index): New functions. All lvalue-style uses of
8297 HASH_KEY etc. changed.
8298 * keyboard.c (set_prop): New function. All lvalue-style uses
8299 of PROP changed.
8300
947b2afd
AA
83012012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
8302
8303 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
8304 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
1f9f395d 8305 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
947b2afd
AA
8306 * nsfns.m (ns_set_name_as_filename): Likewise.
8307 * nsmenu.m (ns_update_menubar): Likewise.
8308 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
8309
4f5d0325
EZ
83102012-08-01 Eli Zaretskii <eliz@gnu.org>
8311
2008beae
EZ
8312 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
8313 Adapt to latest changes in field names of the corresponding Lisp
288479f6 8314 objects.
2008beae 8315
4f5d0325
EZ
8316 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
8317
fe3cc771
GM
83182012-08-01 Glenn Morris <rgm@gnu.org>
8319
8320 * s/msdos.h: Remove file.
8321 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
8322 * Makefile.in (S_FILE): Remove.
8323 (config_h): Remove S_FILE.
8324
c90acc54
JB
83252012-08-01 Juanma Barranquero <lekktu@gmail.com>
8326
8327 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
8328 Remove; moved to nt/config.nt.
8329
d8a05828
DA
83302012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
8331
8332 Use INTERNAL_FIELD for conses and overlays.
8333 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
8334 Remove obsolete comment.
8335 (MVAR): New macro.
8336 (struct Lisp_Overlay): Use INTERNAL_FIELD.
8337 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
8338
8271d590
DA
83392012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
8340
8341 Use INTERNAL_FIELD for symbols.
8342 * lisp.h (SVAR): New macro. Adjust users.
8343 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
8344 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
8345
3193acd2
DA
83462012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
8347
8348 Use INTERNAL_FIELD for processes.
8349 * process.h (PVAR): New macro. Adjust style.
8350 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
8351 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
8352
3a45383a
DA
83532012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
8354
8355 Use INTERNAL_FIELD for windows.
8356 * window.h (WVAR): New macro.
8357 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
8358 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
8359 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
8360 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
8361 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
8362 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
8363
c1dbc63c
PE
83642012-08-01 Paul Eggert <eggert@cs.ucla.edu>
8365
8366 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
8367
5c0c0e8a
GM
83682012-08-01 Glenn Morris <rgm@gnu.org>
8369
8370 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
8371 Move to configure.ac.
8372
552a99b4
JB
83732012-08-01 Juanma Barranquero <lekktu@gmail.com>
8374
8375 * makefile.w32-in (CONFIG_H): Update dependencies.
8376 (CONF_POST_H): New macro.
8377
8378 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
8379
8d8e2dfe
GM
83802012-07-31 Glenn Morris <rgm@gnu.org>
8381
bc96620a
GM
8382 * Makefile.in (S_FILE): No longer set by configure.
8383
476b1b2d
GM
8384 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
8385 is available.
8386 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
8387
b2c7a106
GM
8388 * process.h (NULL_DEVICE):
8389 * emacs.c (SEPCHAR):
8390 * editfns.c (USER_FULL_NAME): Let configure set them.
8391
d53d062a
GM
8392 * s/README, s/template.h: Remove files.
8393
4515017f
GM
8394 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
8395
8d8e2dfe
GM
8396 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
8397 Move to configure.ac.
8398
5b20b3cc
EZ
83992012-07-31 Eli Zaretskii <eliz@gnu.org>
8400
1e0afd9a
EZ
8401 * .gdbinit (xframe): Adapt to introduction of FVAR and the
8402 resulting renaming of 'struct frame' members.
8403
5b20b3cc
EZ
8404 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
8405
8406 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
8407 after introduction of FVAR.
8408
f1310128
JD
84092012-07-31 Jan Djärv <jan.h.d@swipnet.se>
8410
79e721e0
JD
8411 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
8412
8413 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
8414 instead of compositeToPoint.
8415 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
8416
8d7c7eed 8417 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 8418
e34f7f79
DA
84192012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
8420
8421 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
8422 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 8423 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
8424 (BVAR): Change to use INTERNAL_FIELD.
8425 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
8426 (KVAR): Change to use INTERNAL_FIELD.
8427 * frame.h (FVAR): New macro.
8428 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
8429 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
8430 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
8431 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
8432 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
8433
c09bfb2f
DA
84342012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
8435
8436 Miscellaneous fixes for non-default X toolkits.
8437 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
8438 * xterm.c (x_frame_of_widget): Remove redundant prototype.
8439 Move under #ifdef USE_LUCID.
8440 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
8441 definition and usage to avoid warnings.
8442
14c114ae
JD
84432012-07-31 Jan Djärv <jan.h.d@swipnet.se>
8444
8445 * nsterm.m (openFiles): Fix previous checkin.
8446
3bd21e82
PE
84472012-07-31 Paul Eggert <eggert@cs.ucla.edu>
8448
8449 * indent.c (compute_motion): Remove unused local.
8450
c1529ded
GM
84512012-07-31 Glenn Morris <rgm@gnu.org>
8452
400d5621
GM
8453 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
8454
268e2432
GM
8455 * conf_post.h [USG5_4]:
8456 Move remaining contents of s/usg5-4-common.h here.
8457 * s/usg5-4-common.h: Remove file.
8458
7552f3ee
GM
8459 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
8460 * s/irix6-5.h: Remove file.
8461
6a381852
GM
8462 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
8463 * s/darwin.h: Remove file.
8464
c1529ded
GM
8465 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
8466 * s/hpux10-20.h: Remove file, which is now empty.
8467
b429a4ee
GM
84682012-07-30 Glenn Morris <rgm@gnu.org>
8469
8470 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
8471 * Makefile.in (config_h): Add conf_post.h.
8472 * makefile.w32-in (CONFIG_H): Add conf_post.h.
8473
adff3182
JD
84742012-07-30 Jan Djärv <jan.h.d@swipnet.se>
8475
8476 * nsterm.m (ns_do_open_file): New variable.
b9031d69 8477 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
8478 (openFile, openTempFile, openFileWithoutUI, openFiles):
8479 Open files only if ns_do_open_file.
adff3182 8480
c32af1e4
PE
84812012-07-30 Paul Eggert <eggert@cs.ucla.edu>
8482
7393bcbb
PE
8483 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
8484 This no-op macro hasn't been needed for many years.
8485 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
8486
c32af1e4
PE
8487 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
8488 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
8489 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
8490 gdb_make_enums_visible.
8491 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
8492 (DIRECTORY_SEP): Now a constant, not a macro.
8493
302fc036
EZ
84942012-07-30 Eli Zaretskii <eliz@gnu.org>
8495
8496 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
8497 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
8498
8499 * w32term.c <w32_keyboard_codepage>: Renamed from
8500 keyboard_codepage and now external. All users changed.
8501
8502 * w32term.h: Add declaration of w32_keyboard_codepage.
8503
8504 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
8505 the codepage to translate keys to Unicode. If this argument is
8506 -1, use the value returned by GetConsoleCP. All callers changed.
8507
88fb40b4
PE
85082012-07-30 Paul Eggert <eggert@cs.ucla.edu>
8509
0aee6912
PE
8510 Update .PHONY listings in makefiles.
8511 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
8512 bootstrap-clean, distclean, maintainer-clean, versioclean,
8513 extraclean, frc.
8514
88fb40b4
PE
8515 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
8516 This is a bit clearer. Fix some commentary typos.
8517
0a763bd1
GM
85182012-07-30 Glenn Morris <rgm@gnu.org>
8519
32bac6d6
GM
8520 * s/netbsd.h: Let configure include signal.h if needed.
8521 Remove file, which is now empty.
8522
b65e7c46
GM
8523 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
8524 Let configure set them.
8525 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
8526 No more need to undefine.
0a763bd1 8527
169304bd
AS
85282012-07-30 Andreas Schwab <schwab@linux-m68k.org>
8529
8530 * keymap.c (Fkey_description): Don't remove 0x80 bit from
8531 non-single-byte char when adding meta modifier. (Bug#12090)
8532
6cd7a139
DA
85332012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
8534
8535 Convert safe_call to use variable number of arguments.
8536 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
8537 (safe_call2): Fix comment.
8538 * lisp.h (safe_call): Adjust prototype.
8539 * coding.c (encode_coding_object): Change to use safe_call2.
8540 * xfaces.c (merge_face_heights): Change to use safe_call1.
8541
d34d6ffc
GM
85422012-07-30 Glenn Morris <rgm@gnu.org>
8543
7b8a48e4 8544 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 8545 does that unconditionally. Remove file, which is now empty.
7b8a48e4 8546
d34d6ffc
GM
8547 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
8548 Remove empty files.
8549
03a660a6
PE
85502012-07-30 Paul Eggert <eggert@cs.ucla.edu>
8551
8552 Export to GDB most of lisp.h's remaining object-like macros.
8553 * lisp.h (min, max): Move earlier, because they're used earlier now.
8554 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
8555 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
8556 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
8557 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
8558 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
8559 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
8560 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
8561 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
8562 Now constants, for GDB. They need not be macros.
8563 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
8564 Now constants, for GDB, as well as macros, for static initializers.
8565 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
8566 Move to after the definition of struct Lisp_Char_Table,
8567 since the former now needs that type defined.
8568 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
8569 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
8570 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
8571 New enums, for gdb_make_enums_visible.
8572 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 8573 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
8574 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
8575 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
8576 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
8577 enum maxargs, enum MAX_ALLOCA.
8578 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
8579 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
8580 no longer needed, now that they are done in lisp.h.
8581
e499d0ee
DA
85822012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
8583
8584 Cleanup string bytes checking.
8585 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
8586 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
8587 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
8588 (check_sblock, compact_small_strings): Simplify.
8589
d5040d2d
PE
85902012-07-29 Paul Eggert <eggert@cs.ucla.edu>
8591
8592 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
8593 These macros are confusing and no longer need to be defined, as
8594 the enum values now suffice. All uses replaced with definiens.
8595 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
8596
7f259ae6
JB
85972012-07-29 Juanma Barranquero <lekktu@gmail.com>
8598
8599 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
8600 ($(BLD)/w32console.$(O)): Update dependencies.
8601
7e63e0c3
DA
86022012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
8603
8604 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
8605 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
8606 time. Adjust users.
8607 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
8608
ffd817eb
JD
86092012-07-29 Jan Djärv <jan.h.d@swipnet.se>
8610
8611 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
8612 setting sitelisp (Bug#12010).
8613
417a7a0e
EZ
86142012-07-29 Eli Zaretskii <eliz@gnu.org>
8615
14ae4239 8616 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
8617
8618 * w32heap.c (cache_system_info):
8619 * w32.c (sys_rename):
8620 * w32proc.c (find_child_console, sys_kill): All users changed.
8621
387d4d92
PE
86222012-07-29 Paul Eggert <eggert@cs.ucla.edu>
8623
8624 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
8625
55a6cca6
EZ
86262012-07-29 Eli Zaretskii <eliz@gnu.org>
8627
8628 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
8629
dbcf001c
DA
86302012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
8631
8632 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
8633 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
8634 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 8635
e2688e4a
DA
86362012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
8637
8638 Generalize marker debugging code under MARKER_DEBUG and use eassert.
8639 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
8640 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
8641 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
8642 (replace_range, replace_range_2, del_range_2): Change to eassert.
8643 * marker.c (byte_char_debug_check): Adjust style.
8644
b46a6a83
PE
86452012-07-29 Paul Eggert <eggert@cs.ucla.edu>
8646
8647 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
8648 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
8649 long-ago-commented-out code that talks about "WIN32".
8650 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
8651 All uses changed.
8652
e32a5799
PE
86532012-07-28 Paul Eggert <eggert@cs.ucla.edu>
8654
8655 Use Gnulib stdalign module (Bug#9772, Bug#9960).
8656 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
8657 Simplify by using alignof.
8658 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
8659 * lisp.h: Include <stdalign.h>.
8660 (GCALIGNMENT): New macro and constant.
8661 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
8662 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
8663 (stdalign): New macro, if not already defined.
8664
df81cd29
EZ
86652012-07-28 Eli Zaretskii <eliz@gnu.org>
8666
01bd1b0d
EZ
8667 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
8668 * w32inevt.c: Include w32inevt.h.
8669 (w32_read_console_input): New inline function, calls either
8670 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
8671 w32_console_unicode_input.
8672 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
8673 (w32_kbd_patch_key, key_event): Use the codepage returned by
8674 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
8675 (key_event): use uChar.UnicodeChar only if
8676 w32_console_unicode_input is non-zero.
8677
8678 * w32console.c: Include w32heap.h.
8679 <w32_console_unicode_input>: New global variable.
8680 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
8681 family of Windows, zero otherwise.
8682
8683 * w32inevt.h: Declare w32_console_unicode_input.
8684
df81cd29
EZ
8685 * xdisp.c (init_iterator): Don't reference tip_frame in a build
8686 --without-x. (Bug#11742)
8687
c20fdd9e
PE
86882012-07-27 Paul Eggert <eggert@cs.ucla.edu>
8689
8690 Adjust GDB to reflect pvec_type changes (Bug#12036).
8691 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
8692 2012-07-04 changes to pseudovector representation.
8693 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 8694
32770973 86952012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
8696
8697 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
8698 bus address.
8699 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
8700
3438fe21
EZ
87012012-07-27 Eli Zaretskii <eliz@gnu.org>
8702
bcfbc9de
EZ
8703 * alloc.c (listn): Fix the order the arguments are consed onto the
8704 list.
8705
3438fe21
EZ
8706 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
8707 enumeration constants, as PURE and HEAP are too general, and clash
8708 with other headers and sources, such as gmalloc.c and the
8709 MS-Windows system headers. All users changed.
8710
eeaea515
DA
87112012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
8712
8713 Revert last save_excursion_save and save_excursion_restore changes.
8714 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
8715 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
8716
073c88c2
DA
87172012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
8718
8719 Fix recently-introduced typos in Windows port.
8720 Reported by Martin Rudalics <rudalics@gmx.at>.
8721 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 8722 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 8723
4706125e
PE
87242012-07-27 Paul Eggert <eggert@cs.ucla.edu>
8725
8726 Improve GDB symbol export (Bug#12036).
8727 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
8728 arms of an 'if', not using conditional expressions; otherwise GDB
8729 complains about the types in the unevaluated arm when the argument
8730 is an integer literal.
8731 (xgetint): Simplify expression.
8732 * alloc.c (gdb_make_enums_visible): New constant. This ports to
8733 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
8734 Zaretskii in <http://bugs.gnu.org/12036#13>.
8735 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
8736 needed now that we have gdb_make_enums_visible.
8737 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
8738 (enum enum_USE_LSB_TAG):
8739 New enum types, packaging up enums that need to be exported to GDB.
8740
694b6c97
DA
87412012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
8742
8743 Utility function to make a list from specified amount of objects.
8744 * lisp.h (enum constype): New datatype.
8745 (listn): New prototype.
8746 * alloc.c (listn): New function.
8747 (Fmemory_use_count, syms_of_alloc): Use it.
8748 * buffer.c (syms_of_buffer): Likewise.
8749 * callint.c (syms_of_callint): Likewise.
8750 * charset.c (define_charset_internal): Likewise.
8751 * coding.c (syms_of_coding): Likewise.
8752 * keymap.c (syms_of_keymap): Likewise.
8753 * search.c (syms_of_search): Likewise.
8754 * syntax.c (syms_of_syntax): Likewise.
8755 * w32.c (init_environment): Likewise.
8756 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
8757 * xdisp.c (syms_of_xdisp): Likewise.
8758 * xfns.c (syms_of_xfns): Likewise.
8759
6195f384
DA
87602012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
8761
8762 Fast save_excursion_save and save_excursion_restore.
8763 * lisp.h (struct Lisp_Excursion): New data type.
8764 (PVEC_EXCURSION): New pseudovector type.
8765 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
8766 to deal with it. Adjust comments.
8767 (init_marker, attach_marker): New prototype.
8768 (unchain_marker): Adjust prototype.
8769 * marker.c (attach_marker): Change to global.
8770 (init_marker): New function.
8771 * alloc.c (Fmake_marker, build_marker): Use it.
8772 (build_marker): More easserts.
8773 (mark_object): Handle struct Lisp_Excursion.
8774 * editfns.c (save_excursion_save, save_excursion_restore):
8775 Reimplement to use struct Lisp_Excursion. Add comments.
8776
5eceb8fb
PE
87772012-07-26 Paul Eggert <eggert@cs.ucla.edu>
8778
8779 Fix export of symbols to GDB (Bug#12036).
8780 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
8781 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
8782 emacs.c, as this is a more-suitable home. Had this been done earlier
8783 the fix for 12036 would have avoided some of the problems noted in
8784 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
8785 would have been more obvious.
562157c8
PE
8786 * emacs.c: Do not include <verify.h>; no longer needed.
8787 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
8788 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
8789 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
8790 Remove; now done in lisp.h.
8791 * lisp.h (PUBLISH_TO_GDB): New macro.
8792 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
8793 (DATA_SEG_BITS): Use it.
8794 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
8795 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
8796 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
8797 not be usable in #if. This simplifies things.
8798
d6749401
JB
87992012-07-26 Juanma Barranquero <lekktu@gmail.com>
8800
8801 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
8802
1781b9e9
PE
88032012-07-26 Paul Eggert <eggert@cs.ucla.edu>
8804
d89518db 8805 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
8806 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
8807 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
8808 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
8809 Adjust to changes in lisp.h and emacs.c, by using
8810 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
8811 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
8812 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
8813 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
8814 instead of gdb_valbits.
8815 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
8816 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
8817 instead of gdb_array_mark_flag.
8818 (xboolvector): Get size from $->size, not $->header.size.
8819 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
8820 (xreload, hook-run, hookpost-run): Remove.
8821 * emacs.c: Include <verify.h>.
8822 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
8823 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
8824 Remove.
8825 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
8826 (gdb_USE_LSB_TAG): New enum constants.
8827 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
8828 Also define these as enum constants, so they're visible to GDB.
8829 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
8830 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
8831 as constants, so they're visible to GDB.
8832 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
8833 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
8834 Now enum constants, not macros, so they're visible to GDB.
8835 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
8836 more convenient now. All uses changed.
8837 (VALMASK) [USE_LSB_TAG]: Also define in this case.
8838 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
8839
3628596a
DA
88402012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
8841
8842 Explicitly free restriction data that are not needed anymore.
8843 * editfns.c (save_restriction_restore): Free restriction data.
8844
7abaf5cc
SM
88452012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
8846
8847 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
8848 add argument, tune behavior, and adjust all callers.
8849
71f88e00
PE
88502012-07-25 Paul Eggert <eggert@cs.ucla.edu>
8851
8852 Use typedef for EMACS_INT, EMACS_UINT.
8853 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
8854 than macros. This simplifies debugging in the usual case, since
8855 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
8856 and it allows expressions involving EMACS_INT casts.
8857 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
8858
57ec3034
JD
88592012-07-25 Jan Djärv <jan.h.d@swipnet.se>
8860
8861 * nsterm.m (ns_read_socket): Return early if there is a modal
8862 window (Bug#12043).
8863
8137e7b3
MR
88642012-07-25 Martin Rudalics <rudalics@gmx.at>
8865
8866 * frame.c (Fredirect_frame_focus): In doc-string don't mention
8867 that FOCUS-FRAME can be omitted.
8868
04e9897c
DA
88692012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
8870
8871 Adjust buffer text indirection counters at the end of Fkill_buffer.
8872 * buffer.c (Fkill_buffer): Adjust indirection counters when the
8873 buffer is definitely dead. This should really fix an issue reported
8874 by Christoph Scholtes again. (Bug#12007).
8875 (init_buffer_once): Initialize indirection counters of
8876 buffer_defaults and buffer_local_symbols (for sanity and safety).
8877
8a0484e1
EZ
88782012-07-24 Eli Zaretskii <eliz@gnu.org>
8879
8880 * xdisp.c (init_iterator): Don't compute dimensions of truncation
8881 and continuation glyphs on tooltip frames, leave them at zero.
8882 Avoids continued lines in tooltips. (Bug#11832)
8883
fa691a83
DA
88842012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
8885
8886 Simplify copy_overlay.
04e9897c 8887 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
8888 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
8889
436bc8e0
EZ
88902012-07-23 Eli Zaretskii <eliz@gnu.org>
8891
8892 * print.c (print_object): Don't crash when a frame's name is nil
8893 or invalid. (Bug#12025)
8894
8895 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
8896 it signals an error when a tooltip frame is being created.
8897
d7a7fda3
DA
88982012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
8899
8900 Cleanup miscellaneous objects allocation and initialization.
8901 * alloc.c (allocate_misc): Change to static. Add argument to
8902 specify the subtype. Adjust comment and users.
8903 (build_overlay): New function.
8904 * buffer.c (copy_overlays, Fmake_overlay): Use it.
8905 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
8906 (allocate_misc): Remove prototype.
8907 (build_overlay): Add prototype.
8908
89092012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
8910
8911 Swap buffer text indirection counters in Fbuffer_swap_text.
8912 * buffer.c (Fbuffer_swap_text): Swap indirections too.
8913 This avoids crash reported by Christoph Scholtes at
8914 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
8915
9d7fa573
JD
89162012-07-22 Jan Djärv <jan.h.d@swipnet.se>
8917
8918 * nsmenu.m (Popdown_data): New struct.
8919 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
8920 free Popdown_data.
8921 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
8922 (initWithContentRect): Make imgView and contentView non-static
8923 and autorelease them. Also autorelease img and matrix (Bug#12005).
8924 (dealloc): Remove (Bug#12005).
8925
0dd6d66d
DA
89262012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
8927
8928 Adjust consing_since_gc when objects are explicitly freed.
8929 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
8930 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
8931 (free_cons, free_misc): Subtract object size from consing_since_gc.
8932
d36d71df
DA
89332012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
8934
8935 Simplify and cleanup markers positioning code.
8936 * marker.c (attach_marker): More useful eassert.
8937 (live_buffer, set_marker_internal): New function.
8938 (Fset_marker, set_marker_restricted): Use set_marker_internal.
8939 (set_marker_both, set_marker_restricted_both): Use live_buffer.
8940
fb9ea40f
PE
89412012-07-22 Paul Eggert <eggert@cs.ucla.edu>
8942
8943 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
8944 as it's limited by the amount of memory, not by INT_MAX.
8945
2d5c5f7d
EZ
89462012-07-21 Eli Zaretskii <eliz@gnu.org>
8947
07fb592e
EZ
8948 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
8949 in special-event-map. See the discussion at
8950 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
8951 for the reasons.
8952
37a9eac8 8953 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
8954 info.dwItemData. Fixes crashes on 64-bit Windows.
8955 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 8956
c4328746
JD
89572012-07-21 Jan Djärv <jan.h.d@swipnet.se>
8958
fc0c31f8 8959 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 8960 (conversationIdentifier): Return value is NSInteger.
784051c4 8961 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 8962
6e5d1c12
CY
89632012-07-21 Chong Yidong <cyd@gnu.org>
8964
8965 * window.c (decode_any_window): Signal an error if the window is
8966 on a dead frame (Bug#11984).
8967
9928463d
DA
89682012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
8969
8970 Add indirection counting to speed up Fkill_buffer.
8971 * buffer.h (struct buffer): New member.
8972 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
8973 (Fmake_indirect_buffer): Set indirection counter to -1, increment
8974 base buffer indirection counter.
8975 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
8976 (Fkill_buffer): Adjust indirection counters as needed, don't walk
8977 through buffer list if indirection counter is 0.
8978
f8643a6b
DA
89792012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
8980
8981 Extend the value returned by Fgarbage_collect with heap statistics.
8982 * alloc.c (Qheap): New symbol.
8983 (syms_of_alloc): DEFSYM it.
8984 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
8985 (Fmemory_free): Remove.
8986 (syms_of_alloc): Don't defsubr it.
8987 * buffer.c (Fcompact_buffer): Remove.
8988 (syms_of_buffer): Don't defsubr it.
8989
dac616ff
DA
89902012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
8991
8992 Make maybe_gc inline.
8993 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
8994 * lisp.h (consing_since_gc, gc_relative_threshold)
8995 (memory_full_cons_threshold): Revert declaration.
8996 (maybe_gc): Remove prototype, define as inline.
8997 * alloc.c: Remove old commented-out code.
8998 (consing_since_gc, gc_relative_threshold)
8999 (memory_full_cons_threshold): Revert to global.
9000 (maybe_gc): Remove.
9001
d7ea76b4
DA
90022012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
9003
9004 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
9005 * lisp.h (build_unibyte_string): New function.
9006 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
9007 * sysdep.c, w32fns.c, xfns.c: Use it.
9008 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
9009 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
9010 Adjust users accordingly.
9011 * font.h (font_open_by_name): Adjust prototype.
9012
765e61e3
DA
90132012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
9014
9015 Cleanup calls to Fgarbage_collect.
9016 * lisp.h (maybe_gc): New prototype.
9017 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
9018 Remove declarations.
9019 * alloc.c (maybe_gc): New function.
9020 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
9021 Make them static.
9022 * bytecode.c (MAYBE_GC): Use maybe_gc.
9023 * eval.c (eval_sub, Ffuncall): Likewise.
9024 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
9025 to avoid dependency from auto-save feature.
9026
52b852c7
PE
90272012-07-19 Paul Eggert <eggert@cs.ucla.edu>
9028
9029 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
9030 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
9031 'for_each_per_buffer_object_at'.
9032 All uses changed. It's better to use upper-case for macros that
9033 cannot be implemented as functions, to give the reader a clue
9034 that they're special.
9035
5db81e33
SM
90362012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
9037
9038 * alloc.c (Fgarbage_collect): Tweak docstring.
9039
5b835e1d
DA
90402012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
9041
9042 Tweak the value returned from Fgarbage_collect again.
9043 * alloc.c (Fgarbage_collect): New return value, as confirmed in
9044 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
9045 Adjust documentation.
9046 (total_vector_bytes): Rename to total_vector_slots, adjust
9047 accounting.
9048 (total_free_vector_bytes): Rename to total_free_vector_slots,
9049 adjust accounting.
9050 (Qstring_bytes, Qvector_slots): New symbols.
9051 (syms_of_alloc): DEFSYM them.
9052
9cd47b72
DA
90532012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
9054
9055 Buffer compaction primitive which may be used from Lisp.
9056 * buffer.c (compact_buffer, Fcompact_buffer): New function.
9057 (syms_of_buffer): Register Fcompact_buffer.
9058 * alloc.c (Fgarbage_collect): Use compact_buffer.
9059 * buffer.h (compact_buffer): New prototype.
9060 (struct buffer_text): New member.
9061
d17337e5
DA
90622012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
9063
9064 New macro to iterate over all buffers, miscellaneous cleanups.
9065 * lisp.h (all_buffers): Remove declaration.
9066 * buffer.h (all_buffers): Add declaration, with comment.
9067 (for_each_buffer): New macro.
9068 * alloc.c (Fgarbage_collect, mark_object): Use it.
9069 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
9070 (init_buffer): Likewise.
9071 * data.c (Fset_default): Likewise.
9072 * coding.c (code_conversion_restore): Remove redundant check
9073 for dead buffer.
9074 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
9075
60cfd278
AS
90762012-07-18 Andreas Schwab <schwab@linux-m68k.org>
9077
9078 Fix bug that created negative-length intervals.
9079 * intervals.c (merge_interval_right, merge_interval_left):
9080 Do not zero out this interval if it is absorbed by its children,
9081 as this interval's total length doesn't change in that case. See
9082 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
9083
d06714cb
PE
90842012-07-18 Paul Eggert <eggert@cs.ucla.edu>
9085
83713154
PE
9086 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
9087 when invoking (make-bool-vector N t) and N is a positive
9088 multiple of 8 -- the last 8 bits were mistakenly cleared.
9089
d06714cb
PE
9090 Remove some struct layout assumptions in bool vectors.
9091 * alloc.c (bool_header_size): New constant.
9092 (header_size, word_size): Move earlier, as they're now used earlier.
9093 Use 'word_size' in a few more places, where it's appropriate.
9094 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
9095 padding before the data member of a bool vector.
9096 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
9097 than doing the check by hand with an abort ().
9098
464d5a5e
SM
90992012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9100
5fbc0409
SM
9101 * eval.c (Fdefvar): Don't check constants since we only set the var if
9102 it's not yet defined anyway (bug#11904).
9103
464d5a5e
SM
9104 * lisp.h (last_undo_boundary): Declare new var.
9105 * keyboard.c (command_loop_1): Set it.
9106 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
9107 were auto-added by the command loop (bug#11774).
9108
8dc2e44a
AS
91092012-07-18 Andreas Schwab <schwab@linux-m68k.org>
9110
9111 * w32font.c (Qsymbol): Remove local definition.
9112 (syms_of_w32font): Don't DEFSYM it.
9113
169925ec
DA
91142012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
9115
9116 Fix sweep_vectors to handle large bool vectors correctly.
9117 * alloc.c (sweep_vectors): Account total_vector_bytes for
9118 bool vectors larger than VBLOCK_BYTES_MAX.
9119
5fbfb018
CY
91202012-07-18 Chong Yidong <cyd@gnu.org>
9121
9122 * frame.c (x_set_frame_parameters): Revert bogus change introduced
9123 in 2012-05-25 commit by Paul Eggert (Bug#11738).
9124
3ab6e069
DA
91252012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
9126
9127 Return more descriptive data from Fgarbage_collect.
9128 Suggested by Stefan Monnier in
9129 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
9130 * alloc.c (bounded_number): New function.
9131 (total_buffers, total_vectors): New variable.
9132 (total_string_size): Rename to total_string_bytes, adjust users.
9133 (total_vector_size): Rename to total_vector_bytes, adjust users.
9134 (sweep_vectors): Account total_vectors and total_vector_bytes.
9135 (Fgarbage_collect): New return value. Adjust documentation.
9136 (gc_sweep): Account total_buffers.
9137 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
9138 (VECTOR_SIZE): Remove.
9139 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
9140 (Qinterval, Qmisc): New symbols.
9141 (syms_of_data): Initialize them.
9142 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
9143 (Qcons, Qbuffer): New declarations.
9144
6d02fe5b
PE
91452012-07-17 Paul Eggert <eggert@cs.ucla.edu>
9146
9147 * alloc.c (Fmemory_free): Account for memory-free's own storage.
9148 Round up, not down. Improve doc.
9149
b7ffe040
DA
91502012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
9151
9152 Restore old code in allocate_string_data to avoid Faset breakage.
9153 Reported by Julien Danjou <julien@danjou.info> in
9154 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
9155 * alloc.c (allocate_string_data): Restore old code with minor
9156 adjustments, fix comment to explain this subtle issue.
9157
4dc7c8d5
SM
91582012-07-17 Eli Zaretskii <eliz@gnu.org>
9159
9160 Remove FILE_SYSTEM_CASE.
9161 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
9162
9163 * fileio.c (FILE_SYSTEM_CASE): Don't define.
9164 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
9165 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
9166 call-process-region passes it through expand-file-name.
9167
9168 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
9169
91702012-07-17 Andreas Schwab <schwab@linux-m68k.org>
9171
9172 Fix crash when creating indirect buffer (Bug#11917)
9173 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
9174 Don't handle unbound variables specially if non-zero.
9175 (Fbuffer_local_variables): Pass zero.
9176 (clone_per_buffer_values): Pass non-zero.
9177
91782012-07-17 Andreas Schwab <schwab@linux-m68k.org>
9179
9180 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
9181 to make the loop interruptible.
9182
91832012-07-17 Andreas Schwab <schwab@linux-m68k.org>
9184
9185 * gnutls.c (emacs_gnutls_handshake): Only retry if
9186 GNUTLS_E_INTERRUPTED.
9187
cce7fefc
DA
91882012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
9189
9190 Cleanup and convert miscellaneous checks to eassert.
9191 * alloc.c (mark_interval): Fix comment, partially rephrase
9192 old comment from intervals.h (see below).
9193 * intervals.c (find_interval, adjust_intervals_for_insertion)
9194 (delete_interval, adjust_intervals_for_deletion)
9195 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
9196 Convert to eassert.
9197 (adjust_intervals_for_insertion, make_new_interval):
9198 Remove obsolete and unused code.
9199 * intervals.h (struct interval): Remove obsolete comment.
9200 * textprotp.c (erase_properties): Remove unused code.
9201 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
9202 (Fremove_list_of_text_properties): Convert to eassert.
9203
9ea10cc3
CY
92042012-07-17 Chong Yidong <cyd@gnu.org>
9205
9206 * editfns.c (Finsert_char): Doc fix.
9207
3900d5de
DA
92082012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
9209
9210 Fix previous change to make Fmemory_free always accurate.
9211 * alloc.c (make_interval): Update total_free_intervals.
9212 (make_float): Likewise for total_free_floats.
9213 (free_cons, Fcons): Likewise for total_free_conses.
9214 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
9215 Likewise for total_free_vector_bytes.
9216 (Fmake_symbol): Likewise for total_free_symbols.
9217 (bytes_free): Remove.
9218
7098646f
DA
92192012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
9220
9221 Simple free memory accounting feature.
9222 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
9223 (sweep_vectors): Accumulate size of free vectors.
9224 (Fgarbage_collect): Setup bytes_free.
9225 (Fmemory_free): New function.
9226 (syms_of_alloc): Register it.
9227
22657b40
DA
92282012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
9229
9230 Cleanup overlays checking.
9231 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
9232 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
9233 eassert and OVERLAYP.
9234 (sort_overlays): Change to use OVERLAYP.
9235
ddfc8813
RK
92362012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
9237
9238 * editfns.c (Finsert_char): Make it interactive, and make the
9239 second arg optional. Copy interactive spec and docstring from
9240 ucs-insert.
9241
7c26cf3c
PE
92422012-07-17 Paul Eggert <eggert@cs.ucla.edu>
9243
9244 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
9245 Unlike the other wrapped functions, fabs has an unspecified
9246 effect on errno.
9247
5d127af9
JD
92482012-07-16 Jan Djärv <jan.h.d@swipnet.se>
9249
9250 * nsterm.m (keyDown): Interpret flags without left/right bits
9251 as the left key (Bug#11670).
9252
6a0dd1d7
DA
92532012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
9254
9255 Remove empty and useless init functions.
9256 * lisp.h (init_character_once, init_fns, init_image)
9257 (init_filelock, init_sound): Remove prototype.
9258 * character.c (init_character_once): Remove.
9259 * filelock.c (init_filelock): Likewise.
9260 * fns.c (init_fns): Likewise.
9261 * image.c (init_image): Likewise.
9262 * sound.c (init_sound): Likewise.
9263 * emacs.c (main): Adjust accordingly.
9264
7a6136fd
DA
92652012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
9266
9267 * gtkutil.h: Tiny cleanups.
9268 (use_old_gtk_file_dialog): Remove useless declaration.
9269 (xg_uses_old_file_dialog): Add suggested const attribute.
9270
ce811ad9
EZ
92712012-07-15 Eli Zaretskii <eliz@gnu.org>
9272
9273 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
9274 (bidi_paragraph_init): Use it to limit search forward for a strong
9275 directional character in abnormally large paragraphs full of
9276 neutral or weak characters. (Bug#11943)
9277
c9adfeaa
SF
92782012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
9279
9280 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
9281 the toolbar (Bug#9451).
9282 (xg_make_tool_item): Give the widget event box a transparent
9283 background.
9284
fff62aa9
DA
92852012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
9286
9287 Cleanup basic allocation variables and functions.
9288 * alloc.c (ignore_warnings, init_intervals, init_float)
9289 (init_cons, init_symbol, init_marker): Remove.
9290 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
9291 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
9292 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
9293 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
9294 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
9295 (staticidx, init_alloc_once, init_strings, free_ablock):
9296 Remove redundant initialization.
9297 * fns.c (init_weak_hash_tables): Remove.
9298 * lisp.h (init_weak_hash_tables): Remove prototype.
9299
9730daca
DA
93002012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
9301
9302 Use zero_vector where appropriate.
9303 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
9304 accordingly.
9305 * lisp.h (zero_vector): New declaration.
9306 * font.c (null_vector): Remove.
9307 (syms_of_font): Remove initialization and staticpro.
9308 (font_list_entities, font_find_for_lface): Change to use zero_vector.
9309 * keymap.c (Faccessible_keymaps): Likewise.
9310
2e2d2a13
LL
93112012-07-15 Leo Liu <sdl.web@gmail.com>
9312
9313 * fringe.c: Fix typo in comments.
9314
cd276f6e
LL
93152012-07-14 Leo Liu <sdl.web@gmail.com>
9316
9317 * fringe.c: Add a new bitmap exclamation-mark.
9318
5a1131d9
EZ
93192012-07-14 Eli Zaretskii <eliz@gnu.org>
9320
9321 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
9322
9323 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
9324 (HAVE_MENUS): Don't define, defined by editing config.in with
9325 msdos/sed2v2.inp.
9326 (GMALLOC_INHIBIT_VALLOC): Don't define.
9327 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
9328
22e983b7
JB
93292012-07-14 Juanma Barranquero <lekktu@gmail.com>
9330
9331 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
9332
5b3f250f
GM
93332012-07-14 Glenn Morris <rgm@gnu.org>
9334
9335 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
9336 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
9337 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
9338
33d63ff4
GM
93392012-07-13 Glenn Morris <rgm@gnu.org>
9340
5b633342
GM
9341 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
9342
33d63ff4
GM
9343 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
9344 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
9345
b55b9f85
JD
93462012-07-13 Jan Djärv <jan.h.d@swipnet.se>
9347
0dc8cf50
JD
9348 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
9349 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
9350 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
9351 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
9352 where appropriate.
9353 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
9354 as boolean expression.
9355 (x_set_window_size): Remove unused variable toolbar.
9356 (ns_get_color_default, ns_mod_to_lisp): Remove.
9357 (ns_mouse_position): Remove unused variables xchar and ychar.
9358 (ns_compute_glyph_string_overhangs): Remove unused variable face.
9359 (ns_set_vertical_scroll_bar): Remove unused variable count.
9360 (ns_delete_terminal): Remove unused variable i.
9361 (ns_term_init): Remove unused variables r, g and b.
9362 (mouseDown): Remove unused variable window.
9363 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
9364 (initFrameFromEmacs): Remove unused variable vbextra.
9365 (mouseEntered): Remove unused variables p and dpyinfo.
9366 (mouseExited): Remove unused variables p and r.
9367 (ns_define_frame_cursor, ns_clear_frame_area)
9368 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
9369 (menuDown): Assign [sender tag] to variable and cast the variable.
9370
9371 * nsterm.h (menuDown): Add id as type to argument sender.
9372 (ns_display_info_for_name): Add Lisp_Object argument.
9373 (ns_term_init): Add Lisp_Object argument.
9374 (ns_map_event_to_object): Add void argument.
9375 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
9376 prototype with arguments and only declare if __OBJC__.
9377 (nxatoms_of_nsselect): Add void argument.
9378 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
9379 (ns_alloc_autorelease_pool): Add void argument.
9380 (ns_release_autorelease_pool): Add void* argument.
9381 (ns_get_defaults_value): Add const char* argument.
9382
9383 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
9384 (initFromContents): Use SSDATA where appropriate.
9385 (ns_update_menubar): Add braces to ambigous if-else.
9386 (initWithTitle): Put () around assignment in if statement.
9387 (ns_menu_show): Remove unused variables window and keymap.
9388 (update_frame_tool_bar): Remove unused variable selected_p.
9389 (initWithContentRect): Remove unused variable this_cmd_name.
9390
9391 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
9392 appropriate.
9393 (setXBMColor): Remove unused variable len.
9394 (setPixmapData): Put () around assignment in loop statement.
9395
9396 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
9397 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
9398 where appropriate.
9399 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
9400 around assignment in loop statement.
9401 (nsfont_open): Remove unused variable i.
9402 (nsfont_open): Remove unused variable len.
9403 (nsfont_draw): Remove unused variable cs.
9404
9405 * nsfns.m (x_set_icon_name, ns_set_name_internal)
9406 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
9407 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
9408 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
9409 (Fns_font_name, Fns_perform_service)
9410 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
9411 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
9412 (ns_set_name): Remove unused variable view.
9413 (x_set_menu_bar_lines): Remove unused variable olines.
9414 (x_set_tool_bar_lines): Remove unused variable root_window.
9415 (Fns_list_colors): Put () around assignment in while statement.
9416 (Fns_perform_service): Remove unused variable len.
9417 (Fns_display_usable_bounds): Remove unused variable top.
9418 (syms_of_nsfns): Remove unused variable i.
9419
b55b9f85
JD
9420 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
9421 memcpy (Bug#11907).
9422
ed9265fc 94232012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
9424
9425 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
9426 and free it with DestroyExceptionInfo (Bug#11558).
9427
ef099b57
JB
94282012-07-13 Juanma Barranquero <lekktu@gmail.com>
9429
9430 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
9431 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
9432 Set here, not in nt/config.nt.
9433
ea814a5d
EZ
94342012-07-13 Eli Zaretskii <eliz@gnu.org>
9435
9436 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
9437 cursor overflow into the last glyph on display line when the right
9438 fringe is off. (Bug#11832)
9439
1a952767
PE
94402012-07-13 Paul Eggert <eggert@cs.ucla.edu>
9441
9442 * xdisp.c (produce_special_glyphs): Now static.
9443 * dispextern.h (produce_special_glyphs): Remove decl.
9444
983188fd
GM
94452012-07-13 Glenn Morris <rgm@gnu.org>
9446
8d7c7eed 9447 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
9448 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
9449
983188fd
GM
9450 * s/usg5-4-common.h (USG, USG5):
9451 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
9452 * s/sol2-6.h (SOLARIS2):
9453 * s/irix6-5.h (IRIX6_5):
9454 * s/hpux10-20.h (USG, USG5, HPUX):
9455 * s/gnu-linux.h (USG, GNU_LINUX):
9456 * s/freebsd.h (BSD_SYSTEM):
9457 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
9458 * s/cygwin.h (CYGWIN):
9459 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
9460 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
9461
d1e68667 94622012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
9463
9464 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 9465
6de0e799
GM
94662012-07-13 Glenn Morris <rgm@gnu.org>
9467
739ae010
GM
9468 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
9469
dbee5793
GM
9470 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
9471
6de0e799
GM
9472 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
9473 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
9474
b82da769
GM
94752012-07-12 Glenn Morris <rgm@gnu.org>
9476
4fae5a7a 9477 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
9478
9479 * process.c (init_process_emacs): Rename from init_process.
9480 The old name is also the name of a Mach system call.
9481 * lisp.h, emacs.c: Update for this name change.
9482 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
9483 longer needed.
9484
5a979817
EZ
94852012-07-12 Eli Zaretskii <eliz@gnu.org>
9486
9487 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
9488 memmove call that removes glyphs covered by the left truncation
9489 glyph. Improve commentary.
9490 (display_line): Fix display of continuation glyphs on GUI frames
9491 when the right fringe is turned off and variable-size fonts are
9492 used in the window. Move the code that appends a stretch glyph to
9493 produce_special_glyphs, so that it could be used for truncation
9494 and continuation glyphs alike.
9495 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
9496 glyph of a suitably computed width, to align the special glyphs at
9497 the window margin. Code moved from display_line. (Bug#11832)
9498
3e91a053
GM
94992012-07-12 Glenn Morris <rgm@gnu.org>
9500
ba9e4b84
GM
9501 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
9502
9503 * s/gnu-linux.h, s/hpux10-20.h:
9504 Do not unconditionally define HAVE_XRMSETDATABASE.
9505
3e91a053
GM
9506 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
9507
b300b1f4
PE
95082012-07-12 Paul Eggert <eggert@cs.ucla.edu>
9509
9510 Fix typos that broke OS X build.
9511 Reported by Randal L. Schwartz in
9512 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
9513 * nsterm.m (ns_timeout): Add missing local decl.
9514 (ns_get_color): snprintf -> sprintf, to fix typo.
9515
6e777848
GM
95162012-07-12 Glenn Morris <rgm@gnu.org>
9517
3f922c37
GM
9518 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
9519 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
9520 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
9521 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
9522
0ab7b23a
GM
9523 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
9524 Move PTY_OPEN to configure.
9525
6e777848
GM
9526 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
9527 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
9528 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
9529
4a7edc24
DA
95302012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
9531
9532 Use empty_unibyte_string where applicable.
9533 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
9534 * lread.c (read1): Likewise.
9535 * xsettings.c (syms_of_xsettings): Likewise.
9536
308aab79
GM
95372012-07-12 Glenn Morris <rgm@gnu.org>
9538
42bd1719
GM
9539 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
9540 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
9541 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
9542 * s/hpux10-20.h (RUN_TIME_REMAP):
9543 * s/bsd-common.h (TABDLY): Move to configure.
9544
9545 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
9546
9547 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
9548
ea0bbd17 9549 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 9550 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
9551
9552 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 9553
308aab79
GM
9554 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
9555 * s/template.h: Move NARROWPROTO to configure.
9556
ee1cf5cf
GM
95572012-07-11 Glenn Morris <rgm@gnu.org>
9558
30fe9bf4
GM
9559 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
9560 unused since 2011-01-17 change to systty.h.
9561
ee1cf5cf
GM
9562 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
9563 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
9564 Move HAVE_PTYS and HAVE_SOCKETS to configure.
9565
63e47e07
PE
95662012-07-11 Paul Eggert <eggert@cs.ucla.edu>
9567
9568 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
9569
c43fb4c3
GM
95702012-07-11 Glenn Morris <rgm@gnu.org>
9571
9572 * s/darwin.h, s/gnu-linux.h, s/template.h:
9573 Move INTERRUPT_INPUT to configure.
9574
e8df9267
DA
95752012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
9576
9577 Minor adjustments to interning code.
9578 * lisp.h (intern, intern_c_string): Redefine as static inline
9579 wrappers for intern_1 and intern_c_string_1, respectively.
9580 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
9581 * lread.c (intern_1, intern_c_string_1, oblookup):
9582 Simplify Vobarray checking.
e8df9267
DA
9583 * font.c (font_intern_prop): Likewise. Adjust comment.
9584 * w32font.c (intern_font_name): Likewise.
9585
34348bd4
AS
95862012-07-11 Andreas Schwab <schwab@linux-m68k.org>
9587
d96a1e0c
AS
9588 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
9589
34348bd4
AS
9590 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
9591 of Fcar/Fcdr if possible.
9592 * font.c (check_otf_features): Likewise.
9593 * fontset.c (Fnew_fontset): Likewise.
9594 * gnutls.c (Fgnutls_boot): Likewise.
9595 * minibuf.c (read_minibuf): Likewise.
9596 * msdos.c (IT_set_frame_parameters): Likewise.
9597 * xmenu.c (Fx_popup_dialog): Likewise.
9598 * w32menu.c (Fx_popup_dialog): Likewise.
9599
c8add24e
GM
96002012-07-11 Glenn Morris <rgm@gnu.org>
9601
4b575b3c
GM
9602 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
9603 since nothing has defined it on these platforms.
9604
09f4e3b0
GM
9605 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
9606 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
9607
172bedef
GM
9608 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
9609 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
9610 Move CLASH_DETECTION to configure.
9611
249685df
GM
9612 * s/gnu.h: Remove file, which is now empty.
9613
c8add24e
GM
9614 * s/gnu.h, s/gnu-linux.h:
9615 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
9616
b41253a3
JW
96172012-07-11 John Wiegley <johnw@newartisans.com>
9618
9619 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
9620 function attribute, so we only use it if it exists in the
9621 compiler.
9622
d923b542
DA
96232012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
9624
9625 Avoid call to strlen in fast_c_string_match_ignore_case.
9626 * search.c (fast_c_string_match_ignore_case): Change to use
9627 length argument. Adjust users accordingly.
9628 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
9629
5ebbef1d
PE
96302012-07-11 Paul Eggert <eggert@cs.ucla.edu>
9631
bb352260
PE
9632 Assume mkdir, rmdir.
9633 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
9634 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
9635
57054ddd
PE
9636 Assume rename.
9637 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
9638
b747d3f7
PE
9639 Assume perror.
9640 * s/hpux10-20.h (HAVE_PERROR): Remove.
9641 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
9642 Remove dummy definition, as this problem was obsolete long ago.
9643
5ebbef1d
PE
9644 Assume strerror.
9645 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
9646
984e7f30
DA
96472012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
9648
9649 Avoid calls to strlen in font processing functions.
9650 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
9651 (font_open_by_name): Change to use length argument.
9652 Adjust users accordingly.
d923b542
DA
9653 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
9654 Adjust prototypes.
9655 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
9656 Change to return ptrdiff_t.
984e7f30
DA
9657 (xfont_list_pattern, xfont_match): Use length returned by
9658 xfont_decode_coding_xlfd.
9659 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
9660
20e94fdd
GM
96612012-07-11 Glenn Morris <rgm@gnu.org>
9662
9d596af3
GM
9663 * s/darwin.h, s/freebsd.h, s/netbsd.h:
9664 Move DONT_REOPEN_PTY to configure.
9665
20e94fdd
GM
9666 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
9667 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
9668
e99a530f
PE
96692012-07-10 Paul Eggert <eggert@cs.ucla.edu>
9670
22ffb973
PE
9671 Remove "#define unix" that is no longer needed (Bug#11905).
9672 * s/aix4-2.h (unix): Remove; no longer needed.
9673
e9a9ae03
PE
9674 EMACS_TIME simplification (Bug#11875).
9675 This replaces macros (which typically do not work in GDB)
9676 with functions, typedefs and enums, making the code easier to debug.
9677 The functional style also makes code easier to read and maintain.
9678 * systime.h: Include <sys/time.h> on all hosts, not just if
9679 WINDOWSNT, since 'struct timeval' is needed in general.
9680 (EMACS_TIME): Now a typedef, not a macro.
9681 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
9682 not macros.
9683 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
9684 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
9685 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
9686 (EMACS_TIME_LE): Now functions, not macros.
9687 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
9688 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
9689 which are not functions. All uses rewritten to use:
9690 (make_emacs_time): New function.
9691 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
9692 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
9693 not functions. All uses rewritten to use the following, respectively:
9694 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
9695 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 9696 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
9697 * fileio.c (Fcopy_file):
9698 * xterm.c (XTflash): Get the current time closer to when it's used.
9699 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
9700
ffacb126
PE
9701 * bytecode.c (targets): Suppress -Woverride-init warnings.
9702
e99a530f
PE
9703 Simplify by avoiding confusing use of strncpy etc.
9704 * doc.c (Fsnarf_documentation):
9705 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
9706 * frame.c (Fmake_terminal_frame):
9707 * gtkutil.c (get_utf8_string):
9708 * lread.c (openp):
9709 * nsmenu.m (ns_update_menubar):
9710 * regex.c (regerror):
9711 Prefer memcpy to strncpy and strncat when either will do.
9712 * fileio.c (Fsubstitute_in_file_name):
9713 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
9714 (menu_separator_name_p):
9715 * nsmenu.m (ns_update_menubar):
9716 Prefer memcmp to strncmp when either will do.
9717 * nsterm.m: Include <ftoastr.h>.
9718 (ns_get_color):
9719 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
9720 Prefer snprintf to strncpy.
9721 * nsterm.m (ns_term_init):
9722 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
9723 * nsterm.m (ns_term_init):
9724 Avoid the need for strncpy, by using build_string or
9725 make_unibyte_string directly. Use dtoastr, not snprintf.
9726 * process.c (Fmake_network_process): Diagnose service names that
9727 are too long, rather than silently truncating them or creating
9728 non-null-terminated names.
9729 (Fnetwork_interface_info): Likewise, for interface names.
9730 * sysdep.c (system_process_attributes) [GNU_LINUX]:
9731 Prefer sprintf to strncat.
9732 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
9733 Prefer vsnprintf to vsprintf + strncpy.
9734
c59592b3
GM
97352012-07-10 Glenn Morris <rgm@gnu.org>
9736
9737 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
9738 Clarify fallback case.
9739
7d7bbefd
DA
97402012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
9741
9742 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
9743 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
9744 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 9745 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
9746 where argument type is known to be a Lisp_Cons.
9747
3a4c8000
TT
97482012-07-10 Tom Tromey <tromey@redhat.com>
9749
9750 * bytecode.c (BYTE_CODE_THREADED): New macro.
9751 (BYTE_CODES): New macro. Replaces all old byte-code defines.
9752 (enum byte_code_op): New type.
9753 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
9754 (exec_byte_code): Use them. Use token threading when applicable.
9755
2a0213a6
DA
97562012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
9757
9758 Optimize pure C strings initialization.
9759 * lisp.h (make_pure_string): Fix prototype.
9760 (build_pure_c_string): New function, defined as static inline. This
9761 provides a better opportunity to optimize away calls to strlen when
9762 the function is called with compile-time constant argument.
9763 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
9764 argument, adjust users accordingly. Use build_pure_c_string where
9765 appropriate.
9766 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
9767 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
9768 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
9769
cb1caeaf
DA
97702012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
9771
9772 Avoid calls to strlen in miscellaneous functions.
9773 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
9774 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
9775 * lread.c (openp): Likewise.
9776
c293e30c
DA
97772012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
9778
9779 Avoid calls to strlen in path processing functions.
9780 * fileio.c (file_name_as_directory): Add comment. Change to add
9781 srclen argument and return the length of result. Adjust users
9782 accordingly.
9783 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
9784 swap 1st and 2nd arguments to obey the common convention.
9785 Adjust users accordingly.
c293e30c
DA
9786 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
9787
9e059e3f
GM
97882012-07-10 Glenn Morris <rgm@gnu.org>
9789
d02eb359
GM
9790 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
9791 Move PENDING_OUTPUT_COUNT definition to configure.
9792
882cf227
GM
9793 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
9794 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
9795 * s/gnu.h (DATA_START): Move definitions to configure.
9796
af6e839f
GM
9797 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
9798 We include usg5-4-common.h, which defines them both.
9799
40289a12
GM
9800 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
9801 O_RDONLY already includes it).
9802
9e059e3f
GM
9803 Stop ns builds setting the EMACSLOADPATH environment variable.
9804 * nsterm.m (ns_load_path): Rename from ns_init_paths.
9805 Now it does not set EMACSLOADPATH, just returns the load-path string.
9806 * nsterm.h: Update accordingly.
9807 * lread.c [HAVE_NS]: Include nsterm.h.
9808 (init_lread) [HAVE_NS]: Use ns_load_path.
9809 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
9810
7c4e8ec0
GM
98112012-07-09 Glenn Morris <rgm@gnu.org>
9812
d4f600ff
GM
9813 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
9814 since the included bsd-common.h does so.
9815
cbb31951
GM
9816 Stop ns builds setting the EMACSPATH environment variable.
9817 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
9818 (ns_init_paths): Do not set EMACSPATH.
9819 * nsterm.h (ns_exec_path): Add it.
9820 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
9821 Use ns_exec_path.
9822
7c4e8ec0
GM
9823 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
9824
26bccfae
PE
98252012-07-09 Paul Eggert <eggert@cs.ucla.edu>
9826
a0bee46f
PE
9827 * process.c (wait_reading_process_output): 'waitchannels' was unset
9828 when read_kbd || !NILP (wait_for_cell); fix this.
9829
5994c183
PE
9830 Add GCC-style 'const' attribute to functions that can use it.
9831 * character.h (char_resolve_modifier_mask):
9832 * keyboard.h (make_ctrl_char):
9833 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
9834 (init_character_once, next_almost_prime, init_fns, init_image)
9835 (flush_pending_output, init_sound):
9836 * mem-limits.h (start_of_data):
9837 * menu.h (finish_menu_items):
9838 Add ATTRIBUTE_CONST.
9839 * emacs.c (DEFINE_DUMMY_FUNCTION):
9840 Declare the dummy function with ATTRIBUTE_CONST.
9841 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
9842 Add decls with ATTRIBUTE_CONST.
9843
26bccfae
PE
9844 Minor improvements to make_formatted_string.
9845 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
9846 where int is good enough, as vsprintf returns an int.
9847 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
9848
a8290ec3
DA
98492012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
9850
9851 Use make_formatted_string to avoid double length calculation.
9852 * lisp.h (make_formatted_string): New prototype.
9853 * alloc.c (make_formatted_string): New function.
9854 * buffer.c (Fgenerate_new_buffer_name): Use it.
220cb2bd 9855 * dbusbind.c (syms_of_dbusbind): Likewise.
a8290ec3
DA
9856 * editfns.c (Fcurrent_time_zone): Likewise.
9857 * filelock.c (get_boot_time): Likewise.
9858 * frame.c (make_terminal_frame, set_term_frame_name)
9859 (x_report_frame_params): Likewise.
9860 * image.c (gs_load): Likewise.
9861 * minibuf.c (get_minibuffer): Likewise.
9862 * msdos.c (dos_set_window_size): Likewise.
9863 * process.c (make_process): Likewise.
9864 * xdisp.c (ensure_echo_area_buffers): Likewise.
9865 * xsettings.c (apply_xft_settings): Likewise.
9866
d01ba2f1
GM
98672012-07-09 Glenn Morris <rgm@gnu.org>
9868
9869 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
9870 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
9871 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
9872 * nsterm.h (ns_etc_directory): Add it.
9873 * callproc.c [HAVE_NS]: Include nsterm.h.
9874 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
9875
f1f924b6
DA
98762012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
9877
9878 Move marker debugging code under MARKER_DEBUG.
9879 * marker.c (MARKER_DEBUG): Move marker debugging code under
9880 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
9881 for bootstrap with --enable-checking (~3x slowdown reported
9882 by Juanma Barranquero <lekktu@gmail.com>).
9883 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
9884
ab531b66
PE
98852012-07-08 Paul Eggert <eggert@cs.ucla.edu>
9886
9887 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
9888 See <http://bugs.gnu.org/11825#29>.
9889
c4b3bc8a
EZ
98902012-07-08 Eli Zaretskii <eliz@gnu.org>
9891
9892 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
9893 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
9894 (display_line): Add commentary about displaying truncation glyphs
9895 on GUI frames.
9896 (produce_special_glyphs): Move here from term.c.
9897
9898 * term.c (produce_special_glyphs): Move to xdisp.c.
9899
9900 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
9901 section.
c4b3bc8a 9902
b676b881
AS
99032012-07-07 Andreas Schwab <schwab@linux-m68k.org>
9904
f17c5273
AS
9905 * xdisp.c (display_line): Avoid warning about implicit declaration
9906 of FRAME_FONT.
9907
298819b9
AS
9908 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
9909
b676b881
AS
9910 * lisp.h: Remove empty conditional.
9911
6045c4fd
PE
99122012-07-07 Paul Eggert <eggert@cs.ucla.edu>
9913
b3350bf9
PE
9914 * lread.c (load_path_check): Now static.
9915
6045c4fd
PE
9916 Fix some minor --with-ns problems found by static checking.
9917 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
9918 (x_set_font) [!HAVE_X_WINDOWS]:
9919 * image.c (xpm_load_image) [HAVE_NS]:
9920 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
9921 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
9922 Remove unused local.
9923 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
9924 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
9925 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
9926 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
9927 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
9928 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
9929 Fix pointer signedness problem.
9930 * xfaces.c (FRAME_X_FONT_TABLE):
9931 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
9932
929e7845
GM
99332012-07-07 Glenn Morris <rgm@gnu.org>
9934
9935 * lread.c (load_path_check): New function, split from init_lread.
9936 (init_lread): Reorganize. Motivation:
9937 If EMACSLOADPATH is set, check/warn about that rather than the
9938 defaults, which we are not going to use. Hence we can remove
9939 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
9940 Don't warn if site-lisp directories are missing.
9941 If not installed, start from a blank load-path, since
9942 PATH_LOADSEARCH refers to the eventual installation directories.
9943
58dd0aa4
EZ
99442012-07-07 Eli Zaretskii <eliz@gnu.org>
9945
9946 Support truncation and continuation glyphs on GUI frames, when
9947 fringes are disabled. (Bug#11832)
9948 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
9949 continuation glyphs even if on GUI frames.
9950 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
9951 or both, are absent.
9952 (start_display, move_it_in_display_line_to): Handle the case of a
9953 GUI frame without a fringe to display continuation or truncation
9954 glyphs.
9955 (insert_left_trunc_glyphs): Support GUI frames: make sure
9956 truncation glyphs overwrite enough glyphs from the current line to
9957 have sufficient space in pixels.
9958 (display_line): Support truncation and continuation glyphs on GUI
9959 frames. If some spare pixels are left on the line after inserting
9960 the truncation glyphs, fill that space with a stretch glyph of a
9961 suitably computed width.
9962
9963 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
9964 produce_glyphs, to support GUI sessions.
9965
31571fd7
PE
99662012-07-07 Paul Eggert <eggert@cs.ucla.edu>
9967
5a16b9bc
PE
9968 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
9969
f3047c75
PE
9970 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
9971
31571fd7
PE
9972 Do not require float-time's arg to fit in time_t (Bug#11825).
9973 This works better on hosts where time_t is unsigned, and where
9974 float-time is applied to the (negative) difference between two times.
9975 * editfns.c (decode_time_components): Last arg is now double *,
9976 not int *, and means to store all the result as a double, without
9977 worrying about whether the seconds part fits in time_t.
9978 All callers changed.
9979 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
9980 All callers changed.
9981 (Ffloat_time): Do not fail merely because the specified time falls
9982 outside of time_t range.
9983
4516fbef
GM
99842012-07-07 Glenn Morris <rgm@gnu.org>
9985
9986 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
9987 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
9988 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
9989
07adc2c6
JB
99902012-07-07 Juanma Barranquero <lekktu@gmail.com>
9991
9992 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
9993 Update dependencies.
9994
9995 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
9996
fd573f31
PE
99972012-07-06 Paul Eggert <eggert@cs.ucla.edu>
9998
fee5959d
PE
9999 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
10000 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
10001 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
10002 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
10003 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
10004 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
10005
fd573f31
PE
10006 * xfont.c (compare_font_names): Redo to omit the need for casts.
10007
ddadbc0e
AS
100082012-07-06 Andreas Schwab <schwab@linux-m68k.org>
10009
fca8d6b6
AS
10010 * xfns.c (Fx_change_window_property): Doc fix.
10011 * w32fns.c (Fx_change_window_property): Doc fix.
10012
ddadbc0e
AS
10013 * w32fns.c (Fx_window_property): Accept the same arguments as the
10014 X Windows version. Doc fix.
10015 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
10016
ed9265fc 100172012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
10018 Eli Zaretskii <eliz@gnu.org>
10019
10020 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
10021 Windows-specific code from nt/config.nt moved here.
10022 Obsolete settings removed.
10023
216ee680
PE
100242012-07-06 Paul Eggert <eggert@cs.ucla.edu>
10025
10026 * process.c: Avoid unnecessary calls to gettime.
10027 (wait_reading_process_output): Don't get the time of day
10028 when gobbling data immediately and not waiting, as there's no need
10029 for it in that case. This removes a FIXME.
10030
bdd091e4
JD
100312012-07-06 Jan Djärv <jan.h.d@swipnet.se>
10032
10033 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
10034 is defined (Bug#11768).
10035
9d44f8ce
DA
100362012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
10037
10038 Fix marker debugging code.
10039 * marker.c (byte_char_debug_check): Do not perform the check
10040 if buffer is not multibyte.
090bd7cb
JB
10041 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
10042 Call byte_char_debug_check with correct arguments.
9d44f8ce 10043
90fc4786
DA
100442012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
10045
10046 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
10047 * marker.c (byte_char_debug_check, count_markers):
10048 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
10049 (byte_debug_flag): Remove.
10050 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
10051 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
10052
7b7ae965
DA
100532012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
10054
4e57b342
DA
10055 Avoid code repetition in marker-related functions.
10056 * marker.c (attach_marker): New function.
10057 (Fset_marker, set_marker_restricted, set_marker_both)
10058 (set_marker_restricted_both): Use it.
10059 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
10060 Consistently rename charno to charpos.
10061 (marker_position): Add eassert.
10062 (marker_byte_position): Convert to eassert.
10063
100642012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
10065
10066 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 10067 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 10068 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 10069
657924ff
DA
100702012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
10071
10072 Introduce fast path for the widely used marker operation.
10073 * alloc.c (build_marker): New function.
10074 * lisp.h (build_marker): New prototype.
10075 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
10076 * composite.c (autocmp_chars): Likewise.
10077 * editfns.c (buildmark): Remove.
10078 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
10079 (save_restriction_save): Use build_marker.
10080 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
10081 * window.c (save_window_save): Likewise.
10082
041a49a6
DA
100832012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
10084
10085 Do not use Fdelete_overlay in delete_all_overlays
10086 to avoid redundant calls to unchain_overlay.
10087 * buffer.c (drop_overlay): New function.
10088 (delete_all_overlays, Fdelete_overlay): Use it.
10089 * minibuf.c (get_minibuffer): Fix comment.
10090
7dca65a4
PE
100912012-07-06 Paul Eggert <eggert@cs.ucla.edu>
10092
10093 Port to OpenBSD 5.1 amd64.
10094 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
10095 This is needed for OpenBSD, and should be harmless on all BSD systems.
10096 Also, include <sys/sysctl.h>, as it should be available on all
10097 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
10098 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
10099 use p_pid member, not kp_proc.pid.
10100
8eb876e2
GM
101012012-07-06 Glenn Morris <rgm@gnu.org>
10102
10103 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
10104
38182d90
PE
101052012-07-05 Paul Eggert <eggert@cs.ucla.edu>
10106
10107 More xmalloc and related cleanup.
10108 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
10109 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
10110 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
10111 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
10112 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
10113 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
10114 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
10115 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
10116 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
10117 * xterm.c:
10118 Omit needless casts involving void * pointers and allocation.
10119 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
10120 as the former is more robust if P's type is changed.
10121 Prefer xzalloc to xmalloc + memset 0.
10122 Simplify malloc-or-realloc to realloc.
10123 Don't worry about xmalloc returning a null pointer.
10124 Prefer xstrdup to xmalloc + strcpy.
10125 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
10126 growing it.
10127 * keyboard.c (apply_modifiers_uncached): Prefer local array to
10128 alloca of a constant.
10129
6dd5a677
EZ
101302012-07-05 Eli Zaretskii <eliz@gnu.org>
10131
10132 * xdisp.c (display_line): Fix horizontal pixel coordinates when
10133 hscroll is larger than the line width. Fixes long and futile
10134 looping inside extend_face_to_end_of_line (on a TTY) producing
10135 glyphs that are not needed and thrown away.
10136
6b312f0f
DA
101372012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
10138
10139 * marker.c (set_marker_restricted_both): Simplify by using
10140 clip_to_bounds.
10141
f520ef9b
PE
101422012-07-05 Paul Eggert <eggert@cs.ucla.edu>
10143
10144 * editfns.c (region_limit): Simplify by using clip_to_bounds.
10145
383b7c95
JD
101462012-07-05 Jan Djärv <jan.h.d@swipnet.se>
10147
10148 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
10149 not defined (Bug#11768).
10150 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
10151 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
10152 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
10153 followed by gtk_box_set_homogeneous (Bug#11768).
10154 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
10155 (update_theme_scrollbar_width, xg_create_scroll_bar):
10156 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
10157 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
10158 (is_box_type): New function (Bug#11768).
10159 (xg_tool_item_stale_p): Call is_box_type.
5293d758 10160 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
10161 with default display (Bug#11768).
10162
d6e7bf45
EZ
101632012-07-05 Eli Zaretskii <eliz@gnu.org>
10164
10165 * xdisp.c (window_hscroll_limited): New function.
10166 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
10167 coordinates when window's hscroll is set to insanely large
10168 values. (Bug#11857)
10169
431391ec
JB
101702012-07-05 Juanma Barranquero <lekktu@gmail.com>
10171
10172 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
10173 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
10174
23f86fce
DA
101752012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
10176
10177 Cleanup xmalloc.
10178 * lisp.h (xzalloc): New prototype. Omit needless casts.
10179 * alloc.c (xzalloc): New function. Omit needless casts.
10180 * charset.c: Omit needless casts. Convert all calls to
10181 xmalloc with following memset to xzalloc.
10182 * dispnew.c: Likewise.
10183 * fringe.c: Likewise.
10184 * image.c: Likewise.
10185 * sound.c: Likewise.
10186 * term.c: Likewise.
10187 * w32fns.c: Likewise.
10188 * w32font.c: Likewise.
10189 * w32term.c: Likewise.
10190 * xfaces.c: Likewise.
10191 * xfns.c: Likewise.
10192 * xterm.c: Likewise.
10193 * atimer.c: Omit needless casts.
10194 * buffer.c: Likewise.
10195 * callproc.c: Likewise.
10196 * ccl.c: Likewise.
10197 * coding.c: Likewise.
10198 * composite.c: Likewise.
10199 * doc.c: Likewise.
10200 * doprnt.c: Likewise.
10201 * editfns.c: Likewise.
10202 * emacs.c: Likewise.
10203 * eval.c: Likewise.
10204 * filelock.c: Likewise.
10205 * fns.c: Likewise.
10206 * gtkutil.c: Likewise.
10207 * keyboard.c: Likewise.
10208 * lisp.h: Likewise.
10209 * lread.c: Likewise.
10210 * minibuf.c: Likewise.
10211 * msdos.c: Likewise.
10212 * print.c: Likewise.
10213 * process.c: Likewise.
10214 * region-cache.c: Likewise.
10215 * search.c: Likewise.
10216 * sysdep.c: Likewise.
10217 * termcap.c: Likewise.
10218 * terminal.c: Likewise.
10219 * tparam.c: Likewise.
10220 * w16select.c: Likewise.
10221 * w32.c: Likewise.
10222 * w32reg.c: Likewise.
10223 * w32select.c: Likewise.
10224 * w32uniscribe.c: Likewise.
10225 * widget.c: Likewise.
10226 * xdisp.c: Likewise.
10227 * xmenu.c: Likewise.
10228 * xrdb.c: Likewise.
10229 * xselect.c: Likewise.
10230
0497dc44
PE
102312012-07-05 Paul Eggert <eggert@cs.ucla.edu>
10232
10233 * fileio.c (time_error_value): Check the right error number.
10234 Problem reported by Troels Nielsen in
10235 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
10236
356e7178
PE
102372012-07-04 Paul Eggert <eggert@cs.ucla.edu>
10238
4e71fd89
PE
10239 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
10240 This should be fixed in a better way; see Eli Zaretskii in
10241 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
10242 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
10243
f0941253
PE
10244 * fileio.c (time_error_value): Rename from special_mtime.
10245 The old name's problems were noted by Eli Zaretskii in
10246 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
10247
065c9eb4
PE
10248 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
10249 This variable's comment says Emacs needs at least one GDB-visible
10250 symbol of type enum pvec_type, to work around GDB problems.
10251 The symbol's value doesn't matter.
10252
356e7178
PE
10253 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
10254 that causes compilation to fail on pre-C99 compilers.
10255
ed9265fc 102562012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
10257
10258 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
10259 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
10260
3884d954
DA
102612012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
10262
d209e2fb 10263 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
10264 headers for buffer_defaults and buffer_local_symbols.
10265 Reported by Juanma Barranquero <lekktu@gmail.com>.
10266
ee28be33
SM
102672012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10268
10269 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
10270 * lisp.h (enum pvec_type): Use fewer bits.
10271 (PSEUDOVECTOR_SIZE_BITS): New constant.
10272 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
10273 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
10274 change in pvec_type.
10275 (PSEUDOVECTOR_TYPEP): New macro.
10276 (TYPED_PSEUDOVECTORP): Use it.
10277 * fns.c (internal_equal): Adapt code to extract pvectype.
10278 * emacs.c (gdb_pvec_type): Update type.
10279 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
10280 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
10281 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
10282 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
10283 (sweep_vectors): Use it. Use local var `total_bytes' instead of
10284 abusing vector->header.next.nbytes.
10285 (live_vector_p): Use PVEC_TYPE.
10286 (mark_object): Adapt code to extract pvectype. Use switch.
10287
c7f2cd7f
PE
102882012-07-04 Paul Eggert <eggert@cs.ucla.edu>
10289
10290 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
10291 Tighten new eassert a bit.
10292
8ce70ed2
DA
102932012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
10294
10295 Fix compilation with --enable-gcc-warnings and -O1
10296 optimization level.
10297 * doprnt.c (doprnt): Change type of tem to int, initialize
10298 to avoid compiler warning. Add eassert.
10299 * search.c (simple_search): Initialize match_byte to avoid
10300 compiler warning. Add eassert.
10301
dea7f1e5
PE
103022012-07-04 Paul Eggert <eggert@cs.ucla.edu>
10303
24a212eb
PE
10304 Avoid weird behavior with large horizontal scrolls.
10305 Without this change, for example, large hscroll values would
10306 mess up Emacs's display on Fedora 15 x86, presumably due to
10307 overflows in int calculations in the display code.
10308 Also, if buffers had long lines, Emacs would freeze.
10309 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
10310 (set_window_hscroll): New function, containing the old guts of
10311 Fset_window_hscroll. Return the clipped value.
10312 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
10313 This avoids the need to check against PTRDIFF_MAX.
10314
dea7f1e5
PE
10315 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
10316
76046526
DA
103172012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
10318
10319 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
10320
39adff0d
PE
103212012-07-04 Paul Eggert <eggert@cs.ucla.edu>
10322
63807d47
PE
10323 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
10324 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
10325 since GCC 4.4.6 issues a bogus warning for them.
10326
39adff0d
PE
10327 Fix bugs in file timestamp newness comparisons.
10328 * fileio.c (Ffile_newer_than_file_p):
10329 * lread.c (Fload): Use full timestamp resolution of files,
10330 not just the 1-second resolution, so that files that are only
10331 slightly newer still count as newer.
10332 * fileio.c (Ffile_newer_than_file_p): Don't assume file
10333 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
10334
dbeed9a6
PE
103352012-07-03 Paul Eggert <eggert@cs.ucla.edu>
10336
10337 * fileio.c: Improve handling of file time marker. (Bug#11852)
10338 (special_mtime): New function.
10339 (Finsert_file_contents, Fverify_visited_file_modtime):
10340 Use it to set special mtime values consistently.
10341
636334d6
AS
103422012-07-03 Andreas Schwab <schwab@linux-m68k.org>
10343
10344 * fileio.c (Finsert_file_contents): Properly handle st_mtime
10345 marker for non-existing file. (Bug#11852)
10346
e2017fe2
GM
103472012-07-03 Glenn Morris <rgm@gnu.org>
10348
10349 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
10350 and did not make it into globals.h).
10351
404dbd37
TT
103522012-07-03 Tom Tromey <tromey@redhat.com>
10353
10354 * window.c (Fset_window_margins, Fset_window_fringes)
10355 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
10356 * textprop.c (Fprevious_property_change): No longer static.
10357 * syntax.c (Fsyntax_table_p): No longer static.
10358 * process.c (Fget_process, Fprocess_datagram_address): No longer
10359 static.
10360 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
10361 * keyboard.c (Fcommand_execute): No longer static.
10362 Remove EXFUN.
10363 * insdel.c (Fcombine_after_change_execute): No longer static.
10364 * image.c (Finit_image_library): No longer static.
10365 * fileio.c (Fmake_symbolic_link): No longer static.
10366 * eval.c (Ffetch_bytecode): No longer static.
10367 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
10368 * doc.c (Fdocumentation_property, Fsnarf_documentation):
10369 No longer static.
404dbd37
TT
10370 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
10371 static.
10372 * dired.c (Ffile_attributes): No longer static.
10373 * composite.c (Fcomposition_get_gstring): No longer static.
10374 * callproc.c (Fgetenv_internal): No longer static.
10375
10376 * ccl.h: Remove EXFUNs.
10377 * buffer.h: Remove EXFUNs.
10378 * dispextern.h: Remove EXFUNs.
10379 * intervals.h: Remove EXFUNs.
10380 * fontset.h: Remove EXFUN.
10381 * font.h: Remove EXFUNs.
10382 * dosfns.c (system_process_attributes): Remove EXFUN.
10383 * keymap.h: Remove EXFUNs.
10384 * lisp.h: Remove EXFUNs.
10385 * w32term.h: Remove EXFUNs.
10386 * window.h: Remove EXFUNs.
10387 * xsettings.h: Remove EXFUN.
10388 * xterm.h: Remove EXFUN.
10389
8e4fd1e1
GM
103902012-07-03 Glenn Morris <rgm@gnu.org>
10391
10392 * lisp.h (Frandom): Make it visible to C.
10393 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
10394 buffer for invisible buffers. (Bug#1229)
10395
ca95b3eb
DA
103962012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
10397
10398 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
10399 values which aren't power of 2.
14ae4239 10400 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
1f9f395d 10401 Verify its value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
10402 accordingly.
10403
7555c33f
SM
104042012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
10405
10406 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
10407
10408 * alloc.c (mark_object): Revert part of last patch to use `switch'.
10409
d12e8f5a
DA
104102012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
10411
10412 * alloc.c (allocate_vector_block): Remove redundant
10413 calls to mallopt if DOUG_LEA_MALLOC is defined.
10414 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
10415 avoid calls to mallopt if zero_vector is returned.
10416
296094c3
DA
104172012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
10418
10419 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
10420 is enabled, avoid dereferencing NULL current_sblock if
10421 running undumped.
10422
36429c89
DA
104232012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
10424
10425 Cleanup basic buffer management.
10426 * buffer.h (struct buffer): Change layout to use generic vector
10427 marking code. Fix some comments. Change type of 'clip_changed'
10428 to bitfield. Remove unused #ifndef old.
10429 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
10430 (GET_OVERLAYS_AT): Fix indentation.
10431 (for_each_per_buffer_object_at): New macro.
10432 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
10433 (Fbuffer_local_variables): Use it.
10434 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
10435 * alloc.c (allocate_buffer): Adjust to match new layout of
10436 struct buffer. Fix comment.
10437 (mark_overlay): New function.
10438 (mark_buffer): Use it. Use mark_vectorlike to mark normal
10439 Lisp area of struct buffer.
10440 (mark_object): Use it. Adjust marking of misc objects
10441 and related comments.
10442
3b3e4cac
PE
104432012-07-02 Paul Eggert <eggert@cs.ucla.edu>
10444
10445 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
10446 wrapper that is not needed because the wrapped code is a no-op (zero
10447 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
10448 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
10449
cf5c0175
DA
104502012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
10451
10452 * alloc.c (mark_buffer): Simplify. Remove prototype.
10453 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 10454 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
10455 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
10456 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 10457
ca26824c
GM
104582012-06-30 Glenn Morris <rgm@gnu.org>
10459
2e4c5312
GM
10460 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
10461
ca26824c
GM
10462 * epaths.in (PATH_SITELOADSEARCH): New.
10463 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
10464 This is rather than relying on --enable-locallisppath elements
10465 having "site-lisp" in their names. (Bug#10208#25, 11658)
10466
0d23c240
EZ
104672012-06-30 Eli Zaretskii <eliz@gnu.org>
10468
c9240d7a
EZ
10469 * w32proc.c (sys_select): Accept and ignore one more argument.
10470
10471 * w32.c (emacs_gnutls_pull): Call select with one more argument.
10472
0d23c240 10473 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 10474 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
10475
10476 * sysdep.c: Don't include dos.h and dosfns.h.
10477
10478 * process.c (sys_select):
10479 * msdos.c (sys_select): Accept one more argument and ignore it.
10480
10481 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
10482 adapt data types and code to that.
10483
10484 * dosfns.c:
10485 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
10486 which clashes with the gnulib function of the same name.
10487
af5a5a98
AS
104882012-06-30 Andreas Schwab <schwab@linux-m68k.org>
10489
c5e4379c
AS
10490 * font.c (font_style_to_value, font_style_symbolic)
10491 (font_prop_validate_style): Add type checks for values in
10492 font_style_table.
10493
af5a5a98
AS
10494 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
10495 argument.
10496 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
10497 uses.
10498
8d38f461
EZ
104992012-06-29 Eli Zaretskii <eliz@gnu.org>
10500
2e5a6631
EZ
10501 * xdisp.c (try_window_id): Undo last change.
10502
8d38f461
EZ
10503 * w32.c (getwd): Adjust commentary about startup_dir.
10504 (init_environment): Always call sys_access, even in non-MSVC
10505 builds. Don't chdir to the directory of the Emacs executable.
10506 This undoes code from 1997 which was justified by the need to
10507 "avoid conflicts when removing and renaming directories". But its
10508 downside was that every relative file name was being interpreted
10509 relative to the directory of the Emacs executable, which can never
10510 be TRT. In particular, it broke sys_access when called with
10511 relative file names.
10512 (sys_access): Map GetLastError to errno.
10513
2af3565e
DA
105142012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
10515
10516 * window.h (struct window): Change type of 'fringes_outside_margins'
10517 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 10518 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
10519 Adjust comment.
10520 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
10521 to ptrdiff_t.
10522
c8d3a25c 105232012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 10524
c8d3a25c
GM
10525 * gnutls.c (emacs_gnutls_handshake):
10526 Add QUIT to make the loop interruptible.
57570cd3 10527
c8d3a25c 105282012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 10529
c8d3a25c
GM
10530 * charset.c (init_charset): Make lack of etc/charsets fatal.
10531
3e984ee8
DA
105322012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
10533
10534 * editfns.c (region_limit): Fix type mismatch.
10535
ef884f23
DA
105362012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
10537
10538 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
10539 undefined. Convert from xassert to eassert.
10540 * nsmenu.m: Convert from xassert to eassert.
10541 * nsterm.m: Likewise.
10542
7d7e0027
SM
105432012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
10544
10545 * editfns.c (region_limit): Clip to narrowing (bug#11770).
10546
aa754e6a
PE
105472012-06-28 Paul Eggert <eggert@cs.ucla.edu>
10548
10549 Avoid integer overflow on scroll-left and scroll-right.
10550 * window.c (HSCROLL_MAX): New macro.
10551 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
10552 overflow when requested scroll falls outside ptrdiff_t range.
10553
80b00b08
DA
105542012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
10555
10556 * window.h (struct window): Change type of 'hscroll',
10557 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
10558 'last_modified' and 'last_overlay_modified' to EMACS_INT.
10559 Adjust users accordingly.
10560 * xdisp.c (try_cursor_movement): Replace type check with eassert.
10561 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
10562 from EMACS_INT to ptrdiff_t.
10563 (make_window): Omit redundant initialization.
10564
62b2bcf6
JB
105652012-06-28 Juanma Barranquero <lekktu@gmail.com>
10566
10567 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
10568
45942c7d
DA
105692012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
10570
10571 * window.h (struct window): Change type of 'use_time' and
10572 'sequence_number' from Lisp_Object to int.
10573 * frame.c (make_frame): Adjust users accordingly.
10574 * print.c (print_object): Likewise.
10575 * window.c (select_window, Fwindow_use_time, make_parent_window)
10576 (make_window): Likewise.
10577
e509cfa6
DA
105782012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
10579
10580 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
10581 enabled with --enable-checking=[all,glyphs] configure option.
10582 Fix GLYPH_DEBUG usage assuming that it may be undefined,
10583 adjust comments accordingly.
10584 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
10585 undefined, adjust comments accordingly.
10586 * image.c: Likewise.
10587 * scroll.c: Likewise.
10588 * w32fns.c: Likewise.
10589 * w32term.c: Likewise.
10590 * xdisp.c: Likewise.
10591 * xfaces.c: Likewise.
10592 * xfns.c: Likewise.
10593 * xterm.c: Likewise.
10594
a54e2c05
DA
105952012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
10596
10597 Generalize run-time debugging checks.
10598 * dispextern.h (XASSERTS): Remove.
10599 * fontset.c (xassert): Remove.
10600 Convert from xassert to eassert.
10601 * alloc.c: Convert from xassert to eassert.
10602 * bidi.c: Likewise.
10603 * dispnew.c: Likewise.
10604 * fns.c: Likewise.
10605 * fringe.c: Likewise.
10606 * ftfont.c: Likewise.
10607 * gtkutil.c: Likewise.
10608 * image.c: Likewise.
10609 * keyboard.c: Likewise.
10610 * menu.c: Likewise.
10611 * process.c: Likewise.
10612 * scroll.c: Likewise.
10613 * sound.c: Likewise.
10614 * term.c: Likewise.
10615 * w32console.c: Likewise.
10616 * w32fns.c: Likewise.
10617 * w32term.c: Likewise.
10618 * window.c: Likewise.
10619 * xdisp.c: Likewise.
10620 * xfaces.c: Likewise.
10621 * xfns.c: Likewise.
10622 * xselect.c: Likewise.
10623 * xterm.c: Likewise.
10624
1ec4b7b2
SM
106252012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
10626
10627 * fns.c (maybe_resize_hash_table): Output message when growing the
10628 purify-hashtable.
10629
2014308a
DA
106302012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
10631
10632 * alloc.c (allocate_string_data): Remove dead code.
10633 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
10634 avoid GCC warning about unused macro.
10635
246155eb
DA
106362012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
10637
10638 * alloc.c (allocate_string): Omit intervals initialization.
10639 * alloc.c (make_uninit_multibyte_string): Initialize intervals
10640 as in make_pure_string and make_pure_c_string.
10641
43184b7b
DA
106422012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
10643
d209e2fb 10644 * alloc.c (allocate_string): Fix last change.
43184b7b 10645
3fe6dd74
DA
106462012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
10647
d209e2fb 10648 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
10649 to memset, add explicit initialization where appropriate.
10650
1ba6038a
GM
106512012-06-27 Glenn Morris <rgm@gnu.org>
10652
10653 * lisp.mk (lisp): Remove paths.elc.
10654
c89926a5
CY
106552012-06-27 Chong Yidong <cyd@gnu.org>
10656
10657 * doc.c (Fsubstitute_command_keys): Fix punctuation.
10658
ed6b3510
JW
106592012-06-26 John Wiegley <johnw@newartisans.com>
10660
1ec4b7b2 10661 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
10662 on Mac OS X Lion: __mod_init_func and __mod_term_func.
10663
ed6b3510
JW
10664 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
10665 when building with Clang.
10666
8edd4a2b
SM
106672012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
10668
10669 * eval.c (Fapply): Allow calling it with a single argument.
10670
f6f62d1b
EZ
106712012-06-26 Eli Zaretskii <eliz@gnu.org>
10672
10673 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
10674 _stricmp and _strnicmp.
10675 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
10676
62efea5e
DA
106772012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
10678
10679 * alloc.c (allocate_window): Zero out non-Lisp part of newly
10680 allocated window.
10681 (allocate_process): Likewise for new process.
8edd4a2b 10682 (allocate_terminal): Change to use offsetof.
62efea5e
DA
10683 (allocate_frame): Likewise.
10684 * frame.c (make_frame): Omit redundant initialization.
10685 * window.c (make_parent_window): Use memset.
10686 (make_window): Omit redundant initialization.
10687 * process.c (make_process): Omit redundant initialization.
10688 * terminal.c (create_terminal): Likewise.
10689
42997f4d
DA
106902012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
10691
10692 * term.c (delete_tty): Remove redundant call to memset.
10693
1130ecfc
DA
106942012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
10695
10696 * alloc.c: Remove build_string.
10697 * lisp.h: Define build_string as static inline. This provides
10698 a better opportunity to optimize away calls to strlen when the
10699 function is called with compile-time constant argument.
10700 * image.c (imagemagick_error): Convert to build_string.
10701 * w32proc.c (sys_spawnve): Likewise.
10702 * xterm.c (x_term_init): Likewise.
10703
cf38a720
PE
107042012-06-26 Paul Eggert <eggert@cs.ucla.edu>
10705
99027bdd
PE
10706 Use sprintf return value instead of invoking strlen on result.
10707 In the old days this wasn't portable, since some sprintf
10708 implementations returned char *. But they died out years ago and
10709 Emacs already assumes sprintf returns int.
10710 Similarly for float_to_string.
10711 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
10712 * ccl.c (ccl_driver):
10713 * character.c (string_escape_byte8):
10714 * data.c (Fnumber_to_string):
10715 * doprnt.c (doprnt):
10716 * print.c (print_object):
10717 * xdisp.c (message_dolog):
10718 * xfns.c (syms_of_xfns):
10719 Use sprintf or float_to_string result to avoid need to call strlen.
10720 * data.c (Fnumber_to_string):
10721 Use make_unibyte_string, since the string must be ASCII.
10722 * lisp.h, print.c (float_to_string): Now returns int length.
10723 * term.c (produce_glyphless_glyph):
10724 Use sprintf result rather than recomputing it.
10725
cf38a720
PE
10726 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
10727 * Makefile.in (ALL_CFLAGS):
10728 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
10729 * gmalloc.c, regex.c: Include <config.h> unconditionally.
10730
3511c784
DA
107312012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
10732
0a08eb21 10733 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
10734 strcasecmp if available.
10735 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
10736
fb7da12e
AS
107372012-06-25 Andreas Schwab <schwab@linux-m68k.org>
10738
10739 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
10740 Avoid comma operator.
10741 * menu.c (push_submenu_start, push_submenu_end)
10742 (push_left_right_boundary, push_menu_pane): Likewise.
10743 * msdos.c (dos_rawgetc): Likewise.
10744
afa2ffd8
DA
107452012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
10746
10747 * xfns.c (xic_create_fontsetname): Remove redundant calls
10748 to memset.
10749
b3b4476b
PE
107502012-06-25 Paul Eggert <eggert@cs.ucla.edu>
10751
4495ff38
PE
10752 * gtkutil.c (get_utf8_string): Remove redundant assignment.
10753 sprintf already null-terminates its output.
10754
b3b4476b
PE
10755 * xfns.c (x_window): Remove redundant cast.
10756
b00876c9
DA
107572012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
10758
10759 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
10760 `const char *' to `char *' to avoid compiler warning.
10761
d188e26b
PE
107622012-06-24 Paul Eggert <eggert@cs.ucla.edu>
10763
885d1d74
PE
10764 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
10765 instead of truncating it to 63 (admittedly a generous limit).
10766
d188e26b
PE
10767 * process.c: Fix spelling and caps in comments.
10768
e2f560b1
DN
107692012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
10770
e86db54b 10771 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
10772 * sysdep.c (setpgrp): Remove definition, not used in this file.
10773
7583a3a1
JB
107742012-06-24 Juanma Barranquero <lekktu@gmail.com>
10775
10776 * makefile.w32-in: Update dependencies.
10777
696056c2
EZ
107782012-06-24 Eli Zaretskii <eliz@gnu.org>
10779
10780 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
10781 (SYSTIME_H): Add nt/inc/sys/time.h.
10782
10783 * systime.h [WINDOWSNT]: Include sys/time.h.
10784
10785 * s/ms-w32.h (struct timespec): Definition moved from
10786 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
10787
845ca893
PE
107882012-06-24 Paul Eggert <eggert@cs.ucla.edu>
10789
10790 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
10791 * buffer.h (buffer_slot_type_mismatch):
10792 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
10793 * eval.c (unwind_to_catch):
10794 * image.c (my_png_error, my_error_exit):
10795 * keyboard.c (quit_throw_to_read_char, user_error)
10796 (Fexit_recursive_edit, Fabort_recursive_edit):
10797 * lisp.h (die, args_out_of_range, args_out_of_range_3)
10798 (wrong_type_argument, buffer_overflow, __executable_start)
10799 (memory_full, buffer_memory_full, string_overflow, Fthrow)
10800 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
10801 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
10802 (fatal):
10803 (child_setup) [!DOS_NT]:
10804 * lread.c (end_of_file_error, invalid_syntax):
10805 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
10806 * puresize.h (pure_write_error):
10807 * search.c (matcher_overflow):
10808 * sound.c (sound_perror, alsa_sound_perror):
10809 * sysdep.c, syssignal.h (croak):
10810 * term.c (maybe_fatal, vfatal):
10811 * textprop.c (text_read_only):
10812 * undo.c (user_error):
10813 * unexmacosx.c (unexec_error):
10814 * xterm.c (x_ins_del_lines, x_delete_glyphs):
10815 Use _Noreturn rather than NO_RETURN.
10816 No need for separate decl merely because of _Noreturn.
10817 * sound.c (sound_warning, parse_sound):
10818 Remove unnecessary forward decls.
10819
f1dd8073
PE
108202012-06-24 Paul Eggert <eggert@cs.ucla.edu>
10821
10822 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
10823 * lisp.h (WAIT_READING_MAX): New macro.
10824 * dispnew.c (Fsleep_for, sit_for):
10825 * keyboard.c (kbd_buffer_get_event):
10826 * process.c (Faccept_process_output):
10827 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
10828 This improves on the previous patch, which introduced a bug
10829 when time_t is unsigned and as wide as intmax_t.
10830 See <http://bugs.gnu.org/9000#51>.
10831
b82c1755
EZ
108322012-06-23 Eli Zaretskii <eliz@gnu.org>
10833
10834 * dispnew.c (sit_for, Fsleep_for):
10835 * keyboard.c (kbd_buffer_get_event):
10836 * process.c (Faccept_process_output): Avoid compiler warnings when
10837 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
10838
ca300656
JB
108392012-06-23 Juanma Barranquero <lekktu@gmail.com>
10840
049ec95b
JB
10841 * makefile.w32-in: Update dependencies.
10842
ca300656
JB
10843 * w32.c (ltime): Add return type and declare static.
10844 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
10845
db7b8d06
PE
108462012-06-23 Paul Eggert <eggert@cs.ucla.edu>
10847
10848 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
10849 Privately reported by Herbert J. Skuhra.
10850 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
10851 All uses changed.
10852 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
10853 not make_lisp_timeval, when the argument is of type EMACS_TIME.
10854
0bd8297f
EZ
108552012-06-23 Eli Zaretskii <eliz@gnu.org>
10856
96512555
EZ
10857 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
10858 last argument of make_unibyte_string.
10859
0bd8297f
EZ
10860 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
10861 language ID in the event parameters.
10862
10863 * w32term.c (w32_read_socket): Put the new keyboard codepage into
10864 event.code, not the obscure "character set ID".
10865
63def6b6
CY
108662012-06-23 Chong Yidong <cyd@gnu.org>
10867
10868 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
10869
e8a02204
EZ
108702012-06-23 Eli Zaretskii <eliz@gnu.org>
10871
388cdec0
EZ
10872 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
10873 * w32.c (fdutimens): New function.
10874
10875 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
10876
10877 * s/ms-w32.h (pselect): Redirect to sys_select.
10878
10879 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
10880
e8a02204
EZ
10881 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
10882 in the logic of incrementing and decrementing the value of
10883 use_relocatable_buffers.
10884
d054f3fb
PE
108852012-06-23 Paul Eggert <eggert@cs.ucla.edu>
10886
10887 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
10888 Privately reported by Herbert J. Skuhra.
10889 [__FreeBSD__]: Remove "*/" typo after "#include".
10890 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
10891 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
10892 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
10893 Don't assume EMACS_TIME and struct timeval are the same type.
10894
d35af63c
PE
108952012-06-22 Paul Eggert <eggert@cs.ucla.edu>
10896
10897 Support higher-resolution time stamps (Bug#9000).
10898 The time stamps are only nanosecond-resolution at the C level,
10899 since that's the best that any real-world system supports now.
10900 But they are picosecond-resolution at the Lisp level, as that's
10901 easy, and leaves room for future OS improvements.
10902
10903 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
10904 (LIBES): Use it.
10905
10906 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
10907 Don't get current time unless it's needed.
10908
10909 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
10910 now provides it if it's absent.
10911 (start_atimer): Port to higher-res time stamps.
10912 Check for time stamp overflow. Don't get current time more
10913 often than is needed.
10914
10915 * buffer.h (struct buffer): Buffer modtime now has high resolution.
10916 Include systime.h, not time.h.
10917 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
10918
10919 * dired.c: Include stat-time.h.
10920 (Ffile-attributes): File times now have higher resolution.
10921
10922 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
10923 (struct image): Timestamp now has higher resolution.
10924
10925 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
10926 has at least microseconds now. All uses removed.
10927 (update_frame, update_single_window, update_window, update_frame_1)
10928 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 10929 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
10930
10931 * editfns.c (time_overflow): Now extern.
10932 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
10933 (float-time, Fformat_time_string, Fcurrent_time_string)
10934 (Fcurrent_time_zone): Accept and generate higher-resolution
10935 time stamps.
10936 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
10937 (decode_time_components, lisp_seconds_argument): New functions.
10938 (make_time): Now static.
10939 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
10940 Report an error if the time is invalid, rather than having the caller
10941 do that.
10942
10943 * fileio.c: Include <stat-time.h>
10944 (Fcopy_file): Copy higher-resolution time stamps.
10945 Prefer to set the time stamp via a file descriptor if that works.
10946 (Fset_file_times, Finsert_file_contents, Fwrite_region)
10947 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
10948 (Fvisited_file_modtime, Fset_visited_file_modtime):
10949 Support higher-resolution time stamps.
10950
10951 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
10952
10953 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
10954
10955 * image.c (prepare_image_for_display, clear_image_cache)
10956 (lookup_image): Port to higer-resolution time stamps.
10957
10958 * keyboard.c (start_polling, bind_polling_period):
10959 Check for time stamp overflow.
10960 (read_char, kbd_buffer_get_event, timer_start_idle)
10961 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
10962 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
10963 Port to higher-resolution time stamps. Do not assume time_t is signed.
10964 (decode_timer): New function. Timers are now vectors of length 9,
10965 not 8, to accommodate the picosecond component.
10966 (timer_check_2): Use it.
10967
10968 * nsterm.m (select_timeout, timeval_subtract): Remove.
10969 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
10970 as they're a bit more accurate and handle overflow better.
10971 (ns_select): Change prototype to be compatible with pselect.
10972 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
10973 * nsterm.h (ns_select): Adjust prototype.
10974
10975 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
10976 us-resolution time stamps.
10977 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
10978
10979 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
10980
10981 * lisp.h (time_overflow): New decl.
10982 (wait_reading_process_output): First arg is now intmax_t, not int,
10983 to accommodate larger waits.
10984
10985 * process.h (struct Lisp_Process.read_output_delay):
10986 Now counts nanoseconds, not microseconds.
10987 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
10988 EMACS_HAS_USECS.
10989 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
10990 (wait_reading_process_output):
10991 Port to ns-resolution time stamps.
10992 (Faccept_process_output, wait_reading_process_output):
10993 Check for time stamp overflow. Do not assume time_t is signed.
10994 (select_wrapper): Remove; we now use pselect.
10995 (Fprocess_attributes): Now generates ns-resolution time stamps.
10996
10997 * sysdep.c: Include utimens.h. Don't include utime.h
10998 or worry about struct utimbuf; gnulib does that for us now.
10999 (gettimeofday): Remove; gnulib provides a substitute.
11000 (make_timeval): New function.
11001 (set_file_times): Now sets ns-resolution time stamps.
11002 New arg FD; all uses changed.
11003 (time_from_jiffies, ltime_from_jiffies, get_up_time)
11004 (system_process_attributes):
11005 Now returns ns-resolution time stamp. All uses changed.
11006 Check for time stamp overflow.
11007
11008 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
11009 provides a substitute now.
11010
11011 * systime.h: Include timespec.h rather than sys/time.h and time.h,
11012 since it guarantees struct timespec.
11013 (EMACS_TIME): Now struct timespec, so that we can support
11014 ns-resolution time stamps.
11015 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
11016 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
11017 (EMACS_USECS): Remove.
11018 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
11019 so multiply the arg by 1000 before storing it.
11020 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
11021 New macros.
11022 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
11023 Port to ns-resolution time stamps.
11024 (EMACS_TIME_NEG_P): Remove; replaced by....
11025 (EMACS_TIME_SIGN): New macro.
11026 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
11027 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
11028 (set_file_times, make_time, lisp_time_argument): Adjust signature.
11029 (make_timeval, make_lisp_time, decode_time_components): New decls.
11030 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
11031 that it mishandled time_t overflow. You can't compare by subtracting!
11032 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
11033 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
11034
11035 * term.c: Include <sys/time.h>.
11036 (timeval_to_Time): New function, for proper overflow wraparound.
11037 (term_mouse_position, term_mouse_click): Use it.
11038
11039 * undo.c (record_first_change): Support higher-resolution time stamps
11040 in the undo buffer.
11041 (Fprimitive_undo): Use them when restoring time stamps.
11042
11043 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
11044 (w32_get_internal_run_time):
11045 Port to higher-resolution Emacs time stamps.
11046 (ltime): Now accepts single 64-bit integer, as that's more convenient
11047 for callers.
11048
11049 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
11050
11051 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
11052 for compatibility with pselect. Support ns-resolution time stamps.
11053
11054 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
11055
11056 * xselect.c (wait_for_property_change, x_get_foreign_selection):
11057 Check for time stamp overflow, and support ns-resolution time stamps.
11058
11059 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
11060 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
11061 (timeval_subtract): Remove; no longer needed.
11062 (XTflash, XTring_bell, x_wait_for_event):
11063 Port to ns-resolution time stamps. Don't assume time_t is signed.
11064
b6a92dfe
CY
110652012-06-22 Chong Yidong <cyd@gnu.org>
11066
11067 * xdisp.c (x_consider_frame_title): Revert last change.
11068
d251c37c
EZ
110692012-06-22 Eli Zaretskii <eliz@gnu.org>
11070
11071 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
11072 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
11073 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
11074 staticidx goes up to 1597 out of 1600 = 0x640.)
11075
f10deafb
PE
110762012-06-20 Paul Eggert <eggert@cs.ucla.edu>
11077
11078 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
11079 Otherwise, the umask might be mistakenly 0 while handling input signals.
11080
ec6de1e2
SM
110812012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
11082
11083 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
11084
28be1ada
DA
110852012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
11086
11087 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
11088 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
11089 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
11090 access to `contents' member of Lisp_Vector objects with AREF and ASET
11091 where appropriate.
11092
c6bf3022
CY
110932012-06-19 Chong Yidong <cyd@gnu.org>
11094
11095 * frame.c (delete_frame): When selecting a frame on a different
11096 text terminal, do not alter the terminal's top-frame.
11097
11098 * xdisp.c (format_mode_line_unwind_data): Record the target
11099 frame's selected window and its terminal's top-frame.
11100 (unwind_format_mode_line): Restore them.
11101 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
11102 Callers changed.
11103 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
11104 since tty frames can be explicitly named.
11105 (prepare_menu_bars): Likewise.
11106
11107 * term.c (Ftty_top_frame): New function.
11108
defd4196
PE
111092012-06-18 Paul Eggert <eggert@cs.ucla.edu>
11110
11111 Port byte-code-meter to modern targets.
11112 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
11113 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 11114 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
11115 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
11116 (METER_1, METER_2): Simplify.
11117
1053a871
SM
111182012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
11119
11120 * data.c (Fdefalias): Return `symbol' (bug#11686).
11121
b7e8d081
MR
111222012-06-18 Martin Rudalics <rudalics@gmx.at>
11123
11124 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
11125 gets killed during executing of this function (Bug#11665).
11126 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
11127 (Vkill_buffer_query_functions): In doc-string say that functions
11128 run by this hook should not change the current buffer.
11129
7ea2b339
PE
111302012-06-18 Paul Eggert <eggert@cs.ucla.edu>
11131
11132 Fix recently-introduced process.c problems found by static checking.
11133 * process.c (write_queue_push, write_queue_pop, send_process):
11134 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
11135 (write_queue_pop): Fix pointer signedness problem.
11136 (send_process): Remove unused local.
11137
96a313a1
CY
111382012-06-17 Chong Yidong <cyd@gnu.org>
11139
11140 * xdisp.c (redisplay_internal): No need to redisplay terminal
11141 frames that are not on top.
11142
20ca2e94
TN
111432012-06-17 Troels Nielsen <bn.troels@gmail.com>
11144
11145 * process.c (make_process): Initialize write_queue.
11146 (write_queue_push, write_queue_pop): New functions.
11147 (send_process): Use them to maintain correct ordering of process
11148 writes (Bug#10815).
11149
9a900ca9
PE
111502012-06-17 Paul Eggert <eggert@cs.ucla.edu>
11151
310fbfa8
PE
11152 * lisp.h (eassert): Assume C89 or later.
11153 This removes the need for CHECK.
11154 (CHECK): Remove. Its comments about always evaluating its
11155 argument were confusing, as 'eassert' typically does not evaluate
11156 its argument.
11157
27bb1ca4
PE
11158 * coding.c (produce_chars): Use ptrdiff_t, not int.
11159
9a900ca9
PE
11160 * xterm.c (x_draw_underwave): Check for integer overflow.
11161 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
11162
41b7f8bc 111632012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
11164
11165 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
11166 referenced (Bug#11583).
11167
9b0e3eba
AA
111682012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
11169
11170 Implement wave-style variant of underlining.
11171 * dispextern.h (face_underline_type): New enum.
11172 (face): Add field for underline type.
11173 * nsterm.m (ns_draw_underwave): New function.
11174 (ns_draw_text_decoration): Use it.
11175 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
11176 New functions.
11177 (x_draw_glyph_string): Use them.
11178 * xfaces.c (Qline, Qwave): New Lisp objects.
11179 (check_lface_attrs, merge_face_ref)
1053a871
SM
11180 (Finternal_set_lisp_face_attribute, realize_x_face):
11181 Handle wave-style underline face attributes.
9b0e3eba
AA
11182 * xterm.c (x_draw_underwave): New function.
11183 (x_draw_glyph_string): Use it.
11184
0fb52f11
JB
111852012-06-16 Juanma Barranquero <lekktu@gmail.com>
11186
11187 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
11188 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
11189 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
11190 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
11191 ($(BLD)/w32select.$(O)): Update dependencies.
11192
e5560ff7
AS
111932012-06-16 Andreas Schwab <schwab@linux-m68k.org>
11194
11195 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
11196 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
11197 * character.c (_fetch_multibyte_char_p): Remove.
11198 * alloc.c: Include "character.h" before "buffer.h".
11199 * bidi.c: Likewise.
11200 * buffer.c: Likewise.
11201 * bytecode.c: Likewise.
11202 * callint.c: Likewise.
11203 * callproc.c: Likewise.
11204 * casefiddle.c: Likewise.
11205 * casetab.c: Likewise.
11206 * category.c: Likewise.
11207 * cmds.c: Likewise.
11208 * coding.c: Likewise.
11209 * composite.c: Likewise.
11210 * dired.c: Likewise.
11211 * dispnew.c: Likewise.
11212 * doc.c: Likewise.
11213 * dosfns.c: Likewise.
11214 * editfns.c: Likewise.
11215 * emacs.c: Likewise.
11216 * fileio.c: Likewise.
11217 * filelock.c: Likewise.
11218 * font.c: Likewise.
11219 * fontset.c: Likewise.
11220 * fringe.c: Likewise.
11221 * indent.c: Likewise.
11222 * insdel.c: Likewise.
11223 * intervals.c: Likewise.
11224 * keyboard.c: Likewise.
11225 * keymap.c: Likewise.
11226 * lread.c: Likewise.
11227 * macros.c: Likewise.
11228 * marker.c: Likewise.
11229 * minibuf.c: Likewise.
11230 * nsfns.m: Likewise.
11231 * nsmenu.m: Likewise.
11232 * print.c: Likewise.
11233 * process.c: Likewise.
11234 * regex.c: Likewise.
11235 * region-cache.c: Likewise.
11236 * search.c: Likewise.
11237 * syntax.c: Likewise.
11238 * term.c: Likewise.
11239 * textprop.c: Likewise.
11240 * undo.c: Likewise.
11241 * unexsol.c: Likewise.
11242 * w16select.c: Likewise.
11243 * w32fns.c: Likewise.
11244 * w32menu.c: Likewise.
11245 * window.c: Likewise.
11246 * xdisp.c: Likewise.
11247 * xfns.c: Likewise.
11248 * xmenu.c: Likewise.
11249 * xml.c: Likewise.
11250 * xselect.c: Likewise.
11251
2f07e6af
EZ
112522012-06-16 Eli Zaretskii <eliz@gnu.org>
11253
1053a871
SM
11254 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
11255 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 11256 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
11257 row.
11258 (handle_face_prop): Use chunk-relative overlay string index when
11259 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
11260 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
11261 the rightmost. (Bug#11720)
2f07e6af 11262
29b83cec
AS
112632012-06-16 Andreas Schwab <schwab@linux-m68k.org>
11264
11265 * category.h (CHAR_HAS_CATEGORY): Define as inline.
11266 (CATEGORY_MEMBER): Enforce 1/0 value.
11267 * category.c (_temp_category_set): Remove.
11268
4c5501e9
EZ
112692012-06-16 Eli Zaretskii <eliz@gnu.org>
11270
11271 * window.c (Fdelete_other_windows_internal)
11272 (Fdelete_window_internal): Don't access frame's mouse highlight
11273 info of the initial frame. (Bug#11677)
11274
2b570124
PE
112752012-06-14 Paul Eggert <eggert@cs.ucla.edu>
11276
e93864f9
PE
11277 * .gdbinit (xgetint): Fix recently-introduced paren typo.
11278 Assume USE_2_TAGS_FOR_INTS.
11279 (xreload): Adjust $tagmask width to match recent lisp.h change.
11280
2b570124
PE
11281 Simplify lisp.h in minor ways that should not affect code.
11282 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
11283 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
11284 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
11285 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
11286 (INTTYPEBITS): New macro, for clarity.
11287 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
11288 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
11289 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
11290 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
11291 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
11292
81755f69
JB
112932012-06-13 Juanma Barranquero <lekktu@gmail.com>
11294
11295 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
11296
16192a57
GM
112972012-06-13 Glenn Morris <rgm@gnu.org>
11298
11299 * s/bsd-common.h (BSD4_3):
11300 * s/usg5-4-common.h (USG5_4): No longer define; unused.
11301
646b5f55
AS
113022012-06-13 Andreas Schwab <schwab@linux-m68k.org>
11303
11304 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
11305 instead of union.
11306 (XLI, XIL): Define.
1053a871
SM
11307 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
11308 Use them.
11309 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 11310 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 11311 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
11312 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
11313 * frame.c (delete_frame): Remove outdated comment.
11314 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
11315 USE_LISP_UNION_TYPE.
11316 (Fw32_unregister_hot_key): Likewise.
11317 (Fw32_toggle_lock_key): Likewise.
11318 * w32menu.c (add_menu_item): Likewise.
11319 (w32_menu_display_help): Use XIL instead of checking
11320 USE_LISP_UNION_TYPE.
11321 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
11322 (init_heap): Likewise.
11323 * w32term.c (w32_read_socket): Update comment.
11324
1d3823c9
GM
113252012-06-13 Glenn Morris <rgm@gnu.org>
11326
c62ff706
GM
11327 * s/usg5-4-common.h, src/s/unixware.h:
11328 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
11329
1d3823c9
GM
11330 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
11331
bfe3e0a2
PE
113322012-06-13 Paul Eggert <eggert@cs.ucla.edu>
11333
11334 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
11335 * alloc.c (make_number) [!defined make_number]:
11336 Remove, as lisp.h always defines this now.
11337 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
11338 (roundup_size): Verify that it is a power of 2.
11339 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
11340 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
11341 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
11342 -DUSE_LSB_TAG=0, to override the automatically-selected default.
11343 USE_LSB_TAG now is always defined to be either 0 or 1.
11344 All uses changed.
11345 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
11346 code works fine either way, and efficiency is not a concern here,
11347 as the union type is for debugging, not for production.
11348 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
11349 Use an inline function on all platforms when using the union type,
11350 since this is simpler and 'static inline' can be used portably
11351 within Emacs now.
11352 (LISP_INITIALLY_ZERO): New macro.
11353 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
11354 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
11355
45fa9c0f
GM
113562012-06-12 Glenn Morris <rgm@gnu.org>
11357
b4492cba
GM
11358 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
11359
11360 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 11361
45fa9c0f
GM
11362 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
11363 Move BROKEN_SIGIO to configure.
11364
11365 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
11366 Move NO_TERMIO to configure.
11367
0e25d334
CY
113682012-06-12 Chong Yidong <cyd@gnu.org>
11369
11370 * image.c (imagemagick_load_image): Use MagickFlattenImage if
11371 MagickMergeImageLayers is undefined. Use pixel pusher loop if
11372 MagickExportImagePixels is undefined.
11373
43682bb6
PE
113742012-06-12 Paul Eggert <eggert@cs.ucla.edu>
11375
11376 * image.c (imagemagick_load_image): Remove unused label.
11377
a9be7d2b
GM
113782012-06-11 Glenn Morris <rgm@gnu.org>
11379
11380 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
11381 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
11382 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
11383 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
11384
3017f87f
SM
113852012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
11386
11387 * alloc.c (make_byte_code): New function.
11388 (Fmake_byte_code): Use it. Don't purify here.
11389 * lread.c (read1): Use it as well to avoid extra allocation.
11390
1b9b4cf4
CY
113912012-06-11 Chong Yidong <cyd@gnu.org>
11392
11393 * image.c (imagemagick_load_image): Implement transparency.
11394
95988fcf
AS
113952012-06-10 Andreas Schwab <schwab@linux-m68k.org>
11396
11397 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
11398 account for preceding backslashes. (Bug#11663)
11399
cd4eb164
CY
114002012-06-09 Chong Yidong <cyd@gnu.org>
11401
11402 * term.c: Support italics in capable terminals (Bug#9652).
11403 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
11404 (turn_on_face): Output using TS_enter_italic_mode if available.
11405 Don't handle unused blinking and alt-charset cases.
11406 (turn_off_face): Handle italic case; discard unused tty_blinking_p
11407 and tty_alt_charset_p cases.
11408 (tty_capable_p, init_tty): Support italics.
11409
11410 * termchar.h (struct tty_display_info): Add field for italics.
11411 Remove unused blink field.
11412
11413 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
11414 Handle slant.
11415
11416 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
11417 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
11418 tty_alt_charset_p. Add tty_italic_p.
11419
ff88beb8
MA
114202012-06-09 Michael Albinus <michael.albinus@gmx.de>
11421
11422 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
11423 dbus_type_is_basic if available.
11424 (xd_extract_signed, xd_extract_unsigned): Rename from
11425 extract_signed and extract_unsigned, respectively. Adapt callers.
11426
44286096
CY
114272012-06-09 Chong Yidong <cyd@gnu.org>
11428
1682701f
CY
11429 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
11430
44286096
CY
11431 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
11432 case (Bug#9752).
11433
d86feb17
PE
114342012-06-08 Paul Eggert <eggert@cs.ucla.edu>
11435
11436 * xdisp.c (vmessage): Treat frame message as multibyte.
11437 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
11438 would generate the diagnostic "Making \302\247 buffer-local while
11439 let-bound!".
11440
d5c20fe8
EZ
114412012-06-08 Eli Zaretskii <eliz@gnu.org>
11442
11443 * dispnew.c (showing_window_margins_p): Undo last change, which
11444 was done due to an inadvertent commit.
11445 (adjust_frame_glyphs_for_frame_redisplay): Do call
11446 showing_window_margins_p.
11447
513749ee
SM
114482012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
11449
11450 * eval.c (Fmake_var_non_special): New primitive.
11451 (syms_of_eval): Defsubr it.
11452 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
11453
d4a8f5c1
JB
114542012-06-08 Juanma Barranquero <lekktu@gmail.com>
11455
11456 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
11457 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
11458
8bbbc977
EZ
114592012-06-08 Eli Zaretskii <eliz@gnu.org>
11460
11461 * alloc.c (allocate_vectorlike): Fix last change.
11462
f3372c87
DA
114632012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
11464
11465 Block-based vector allocation of small vectors.
11466 * lisp.h (struct vectorlike_header): New field `nbytes',
11467 adjust comment accordingly.
11468 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 11469 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
11470 mark_maybe_pointer, valid_lisp_object_p) accordingly.
11471 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
11472 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
11473 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
11474 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
11475 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
11476 (roundup_size): New constant.
11477 (struct vector_block): New data type.
11478 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 11479 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
11480 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
11481 (sweep_vectors): New functions.
11482 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 11483 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
11484 or equal to VBLOCK_BYTES_MAX.
11485 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
11486 (init_alloc_once): Add call to init_vectors.
11487
4f18a4ed
SM
114882012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
11489
11490 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
11491
86f158bc
PE
114922012-06-07 Paul Eggert <eggert@cs.ucla.edu>
11493
11494 * doprnt.c (doprnt): Truncate multibyte char correctly.
11495 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
11496 would mishandle a string argument "Xc" if X was a multibyte
11497 character of length 2: it would truncate after X's first byte
11498 rather than including all of X.
11499
c5cfcbe0
CY
115002012-06-06 Chong Yidong <cyd@gnu.org>
11501
11502 * buffer.c (word_wrap): Doc fix.
11503
c05cf390
PE
115042012-06-04 Paul Eggert <eggert@cs.ucla.edu>
11505
11506 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
11507
0c3461de
GM
115082012-06-03 Glenn Morris <rgm@gnu.org>
11509
11510 * xdisp.c (tool-bar-style): Doc fix.
11511
c71232db
UM
115122012-06-03 Ulrich Müller <ulm@gentoo.org>
11513
11514 * Makefile.in (PAXCTL): Define.
11515 (temacs$(EXEEXT)): Disable memory randomization for the temacs
11516 binary via PaX flags if the paxctl utility is available.
11517 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
11518 Restore PaX flags to their default. (Bug#11398)
11519
383f7350
CY
115202012-06-03 Chong Yidong <cyd@gnu.org>
11521
11522 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
11523 buffer (Bug#11226).
11524
5f2c76c6
CY
115252012-06-03 Chong Yidong <cyd@gnu.org>
11526
11527 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
11528 (note_mode_line_or_margin_highlight): If there is no help echo,
11529 use mode-line-default-help-echo. Handle the case where the mouse
11530 position is past the end of the mode line string.
11531
11532 * buffer.c (buffer_local_value_1): New function, split from
11533 Fbuffer_local_value; can return Qunbound.
11534 (Fbuffer_local_value): Use it.
11535 (Vmode_line_format): Docstring tweaks.
11536
773d47f6
PE
115372012-06-02 Paul Eggert <eggert@cs.ucla.edu>
11538
11539 * sysdep.c (system_process_attributes): Improve comment.
11540
f2d6a3df
SM
115412012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
11542
11543 * keyboard.c: Export real-this-command to Elisp.
11544 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
11545 and DEFVAR it. Update all users.
11546
63810350
PE
115472012-06-02 Paul Eggert <eggert@cs.ucla.edu>
11548
7bd5c1f4
PE
11549 * minibuf.c (Fassoc_string): Remove duplicate declaration.
11550
63810350
PE
11551 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
11552 Convert pctcpu and pctmem to Lisp float properly.
11553 Let the compiler fold better, as 100.0/0x8000 is exact.
11554
a2821611
AS
115552012-06-02 Andreas Schwab <schwab@linux-m68k.org>
11556
11557 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
11558 cons_block.
11559
5fceba1d
PE
115602012-06-01 Paul Eggert <eggert@cs.ucla.edu>
11561
11562 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
11563
c98ff5dd
DA
115642012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
11565
11566 For a 'struct window', replace some Lisp_Object fields to
11567 bitfields where appropriate, remove unused fields.
11568 * window.h (struct window): Remove unused 'last_mark_x' and
11569 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1f9f395d 11570 change its type from Lisp_Object to bitfield.
c98ff5dd
DA
11571 Change type of 'force_start', 'optional_new_start',
11572 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 11573 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 11574
ca34e0be
PE
115752012-05-31 Paul Eggert <eggert@cs.ucla.edu>
11576
11577 Pacify gcc -Wdouble-precision when using Xaw.
11578 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
11579 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
11580 Use 'float' consistently, rather than 'float' in most places
11581 and 'double' in a couple of places.
11582
efc00ab1 115832012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
11584
11585 * xdisp.c (handle_stop): Detect whether we have overlay strings
11586 loaded by testing it->current.overlay_string_index to be
11587 non-negative, instead of checking whether n_overlay_strings is
11588 positive. (Bug#11587)
11589
efc00ab1 115902012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
11591
11592 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
11593
11594 * doc.c (Fsubstitute_command_keys): Doc fix.
11595
efc00ab1 115962012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
11597
11598 * search.c (search_buffer): Remove calls to
11599 r_alloc_inhibit_buffer_relocation, as it is now called by
11600 maybe_unify_char, which was the cause of relocation of buffer text
11601 in bug#11519.
11602
efc00ab1 116032012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
11604
11605 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
11606 for the duration of call to load_charset, to avoid problems with
11607 callers of maybe_unify_char that access buffer text through C
11608 pointers.
11609
11610 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
11611 decrement the inhibition flag, instead of just setting or
11612 resetting it.
11613
ba93a187
PE
116142012-05-31 Paul Eggert <eggert@cs.ucla.edu>
11615
11616 Remove obsolete '#define static' cruft.
11617 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
11618 This #undef was "temporary" in 2000; it is no longer needed
11619 now that '#define static' has gone away.
11620 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
11621 (gray_bitmap_bits): Remove; no longer needed.
11622 All uses replaced with definiens.
11623 * xterm.c: Include "bitmaps/gray.xbm".
11624
9e4bf381
PE
116252012-05-30 Paul Eggert <eggert@cs.ucla.edu>
11626
11627 Clean up __executable_start, monstartup when --enable-profiling.
11628 The following changes affect the code only when profiling.
11629 * dispnew.c (__executable_start): Rename from safe_bcopy.
11630 Define only on platforms that need it.
11631 * emacs.c: Include <sys/gmon.h> when profiling.
11632 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
11633 (__executable_start): Remove decl, since lisp.h does it now.
11634 (safe_bcopy): Remove decl; no longer has that name.
11635 (main): Coalesce #if into single bit of code, for simplicity.
11636 Cast pointers to uintptr_t, since standard libraries want integers
11637 and not pointers.
11638 * lisp.h (__executable_start): New decl.
11639
32d72c2f
GM
116402012-05-31 Glenn Morris <rgm@gnu.org>
11641
11642 * image.c (Fimagemagick_types): Doc fix.
11643
baac5bc7
JM
116442012-05-30 Jim Meyering <meyering@redhat.com>
11645
11646 * callproc.c (Fcall_process_region): Include directory component
11647 in mkstemp error message (Bug#11586).
11648
72cb32cf
PE
116492012-05-30 Paul Eggert <eggert@cs.ucla.edu>
11650
11651 * alloc.c, lisp.h (make_pure_vector): Now static.
11652
61b108cc
SM
116532012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
11654
11655 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
11656 Move to byte-run.el.
11657 (Fautoload): Do the hash-doc more carefully.
11658 * data.c (Fdefalias): Purify definition, except for keymaps.
11659 (Qdefun): Move from eval.c.
11660 * lisp.h (Qdefun): Remove.
11661 * lread.c (read1): Tiny simplification.
11662
471fe23d
TN
116632012-05-29 Troels Nielsen <bn.troels@gmail.com>
11664
934f3f58 11665 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
11666 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
11667 Bug#9642, but explicitly check that the buffer the overlay would
11668 be moved to is live and rearrange lines to make sure that errors
11669 will not put the overlay in an inconsistent state.
11670 (Fdelete_overlay): Cosmetics.
11671
85d0efd1
EZ
116722012-05-28 Eli Zaretskii <eliz@gnu.org>
11673
11674 * w32term.c (my_bring_window_to_top): New function.
11675 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
11676 could be different from the original one.
11677 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
11678 (Bug#11513)
11679
11680 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
11681 by calling BringWindowToTop.
11682
11683 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
11684 (WM_EMACS_END): Increase by one.
11685
da92a98c
PE
116862012-05-28 Paul Eggert <eggert@cs.ucla.edu>
11687
11688 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
11689 This avoids undefined behavior that might cause the eassert
11690 to not catch an out-of-range value.
11691
74d1f848
JB
116922012-05-28 Juanma Barranquero <lekktu@gmail.com>
11693
11694 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
11695 Update dependencies.
11696
9e1a06fc
EZ
116972012-05-27 Eli Zaretskii <eliz@gnu.org>
11698
11699 * bidi.c (bidi_mirror_char): Fix last change.
11700
f3dd7312
AS
117012012-05-27 Andreas Schwab <schwab@linux-m68k.org>
11702
11703 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
11704 when referring to sectname field in printf format.
11705
81899c91
PE
117062012-05-27 Paul Eggert <eggert@cs.ucla.edu>
11707
57b81a9f
PE
11708 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
11709 Only r_alloc_inhibit_buffer_relocation needed to be added;
11710 the others were already declared.
11711
81899c91
PE
11712 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
11713 before checking whether it's out of range. Put the check inside
11714 eassert. See
11715 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
11716
33017faf 117172012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
11718
11719 * callproc.c (Fcall_process): Restore a line that was accidentally
11720 commented out in the 2011-02-13 change (bug#11547).
11721
33017faf 117222012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
11723
11724 * lisp.h [REL_ALLOC]: Add prototypes for external functions
11725 defined on ralloc.c.
11726
11727 * buffer.c [REL_ALLOC]: Remove prototypes of
11728 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
11729 they are now on lisp.h.
11730
11731 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
11732
11733 * search.c (search_buffer): Use it to inhibit relocation of buffer
11734 text while re_search_2 is doing its job, because re_search_2 is
11735 passed C pointers to buffer text. (Bug#11519)
11736
23415acf
EZ
11737 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
11738 Update value to 24.
11739
44e27368
EZ
11740 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
11741 state after an additional call to move_it_in_display_line_to, keep
11742 the values of it->max_ascent and it->max_descent found for the
11743 entire line.
11744 (pos_visible_p): Revert the comparison against bottom_y to what it
11745 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
11746 (Bug#11464)
11747
c1892f11
PE
117482012-05-26 Paul Eggert <eggert@cs.ucla.edu>
11749
11750 Fix coding-related core dumps with gcc -ftrapv.
11751 The code was computing A - B, where A and B are pointers, and B is
11752 random garbage. This can lead to core dumps on platforms that
11753 have special pointer registers, and it also leads to core dumps on
11754 x86-64 when compiled with gcc -ftrapv. The fix is to compute
11755 A - B only when B is initialized properly.
11756 * coding.c (coding_set_source, coding_set_destination): Return void.
11757 (coding_change_source, coding_change_destinations): New functions,
11758 with the old behaviors of coding_set_source and coding_set_destination.
11759 All callers that need an offset changed to use these new functions.
11760
eb7afdad
GM
117612012-05-26 Glenn Morris <rgm@gnu.org>
11762
11763 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
11764
f12fdf02
EZ
117652012-05-26 Eli Zaretskii <eliz@gnu.org>
11766
53a63be6 11767 Extend mouse support on W32 text-mode console.
61b108cc
SM
11768 * xdisp.c (draw_row_with_mouse_face):
11769 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 11770
eb3f6f01 11771 * w32console.c: Include window.h.
61b108cc
SM
11772 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
11773 New functions.
eb3f6f01
EZ
11774 (initialize_w32_display): Initialize mouse-highlight data.
11775
53a63be6
EZ
11776 * w32inevt.c: Include termchar.h and window.h.
11777 (do_mouse_event): Support mouse-autoselect-window. When the mouse
11778 moves, call note_mouse_highlight. If help_echo changed, call
11779 gen_help_event to produce help-echo message in the echo area.
11780 Call clear_mouse_face if mouse_face_hidden is set in the mouse
11781 highlight info.
11782
4cfd81f6
PE
117832012-05-26 Paul Eggert <eggert@cs.ucla.edu>
11784
11785 * lread.c (read1): Simplify slightly to avoid an overflow warning
11786 with GCC 4.7.0 on x86-64.
11787
4446092a
EZ
117882012-05-26 Eli Zaretskii <eliz@gnu.org>
11789
11790 * bidi.c (bidi_mirror_char): Revert last change: an int is
11791 definitely wide enough here.
11792
42b2a986 117932012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 11794
42b2a986 11795 Fix integer width and related bugs (Bug#9874).
eb106a49 11796 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
11797 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
11798 (string_bytes, check_sblock, allocate_string_data):
11799 (compact_small_strings, Fmake_bool_vector, make_string)
11800 (make_unibyte_string, make_multibyte_string)
11801 (make_string_from_bytes, make_specified_string)
11802 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11803 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
11804 (mark_vectorlike):
11805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
11806 (allocate_pseudovector):
11807 Use int, not EMACS_INT, where int is wide enough.
11808 (inhibit_garbage_collection, Fgarbage_collect):
11809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
11810 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
11811 int might not be wide enough.
11812 (bidi_cache_search, bidi_cache_find, bidi_init_it)
11813 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
11814 (bidi_at_paragraph_end, bidi_find_paragraph_start)
11815 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
11816 (bidi_level_of_next_char, bidi_move_to_visually_next):
11817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
11818 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
11819 (Fkill_buffer, Fset_buffer_major_mode)
11820 (advance_to_char_boundary, Fbuffer_swap_text)
11821 (Fset_buffer_multibyte, overlays_at, overlays_in)
11822 (overlay_touches_p, struct sortvec, record_overlay_string)
11823 (overlay_strings, recenter_overlay_lists)
11824 (adjust_overlays_for_insert, adjust_overlays_for_delete)
11825 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
11826 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
11827 (Foverlay_recenter, last_overlay_modification_hooks_used)
11828 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
11829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
11830 (validate_region): Omit unnecessary test for b <= e,
11831 since that's guaranteed by the previous test.
d311d28c
PE
11832 (adjust_overlays_for_delete): Avoid pos + length overflow.
11833 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
11834 (report_overlay_modification):
11835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
11836 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
11837 Omit pointer cast, which isn't needed anyway, and doesn't work
11838 after the EMACS_INT -> ptrdiff_t change.
02481186 11839 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
11840 * buffer.h: Adjust decls to match defn changes elsewhere.
11841 (struct buffer_text, struct buffer):
11842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
11843 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
11844 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
11845 not int, to avoid needless 32-bit limit on 64-bit hosts.
11846 (exec_byte_code): Use tighter memory-full test, one that checks
11847 for alloca overflow. Don't compute the address of the object just
11848 before an array, as that's not portable. Use EMACS_INT, not
11849 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
11850 * callint.c (Fcall_interactively):
11851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
11852 * callproc.c (call_process_kill, Fcall_process):
11853 Don't assume pid_t fits into an Emacs fixnum.
11854 (call_process_cleanup, Fcall_process, child_setup):
11855 Don't assume pid_t fits into int.
11856 (call_process_cleanup, Fcall_process, delete_temp_file)
11857 (Fcall_process_region):
11858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
11859 (Fcall_process): Simplify handling of volatile integers.
11860 Use int, not EMACS_INT, where int will do.
11861 * casefiddle.c (casify_object, casify_region, operate_on_word)
11862 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
11863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
11864 (casify_object): Avoid integer overflow when overallocating buffer.
11865 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 11866 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
11867 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
11868 * category.h (CATEGORYP): Don't assume arg is nonnegative.
11869 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
11870 integers are now checked earlier. All uses replaced with XINT.
11871 (ccl_driver):
11872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
11873 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
11874 (ccl_driver, Fregister_code_conversion_map):
11875 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
11876 (resolve_symbol_ccl_program): Check that vector header is in range.
11877 Always copy the vector, so that we can check its contents reliably
11878 now rather than having to recheck each instruction as it's being
11879 executed. Check that vector words fit in 'int'.
11880 (ccl_get_compiled_code, Fregister_ccl_program)
11881 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
11882 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
11883 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
11884 contents are in range.
11885 (Fccl_execute_on_string): Check that status is in range.
11886 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
11887 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
11888 Accept and return EMACS_INT, not int, because callers can pass values
11889 out of 'int' range.
11890 (c_string_width, strwidth, lisp_string_width, chars_in_text)
11891 (multibyte_chars_in_text, parse_str_as_multibyte)
11892 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
11893 (str_as_unibyte, str_to_unibyte, string_count_byte8)
11894 (string_escape_byte8, Fget_byte):
11895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 11896 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
11897 avoid mishandling large integers.
11898 * character.h: Adjust decls to match defn changes elsewhere.
11899 * charset.c (load_charset_map_from_file, find_charsets_in_text)
11900 (Ffind_charset_region):
11901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
11902 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
11903 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 11904 Don't assume fixnum fits in int.
d311d28c
PE
11905 (load_charset_map_from_vector, Fmap_charset_chars):
11906 Remove now-unnecessary CHECK_NATNUMs.
11907 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
11908 Don't rely on undefined behavior with signed left shift overflow.
11909 Don't assume unsigned int fits into fixnum, or that fixnum fits
11910 into unsigned int. Don't require max_code to be a valid fixnum;
11911 that's not true for gb10830 4-byte on a 32-bit host. Allow
11912 invalid_code to be a cons, for the same reason. Require code_offset
11913 to be a character. Avoid int overflow if max_char is close
11914 to INT_MAX.
11915 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
11916 this is intended anyway and avoids some undefined behavior.
11917 (load_charset_map): Pass unsigned, not int, as 2nd arg of
11918 INDEX_TO_CODE_POINT, as that's what it expects.
11919 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
11920 * charset.h (DECODE_CHAR): Return int, not unsigned;
11921 this is what was intended anyway, and it avoids undefined behavior.
11922 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
11923 integer-overflow issues.
11924 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
11925 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
11926 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
11927 * chartab.c (Fmake_char_table, Fset_char_table_range)
11928 (uniprop_get_decoder, uniprop_get_encoder):
11929 Don't assume fixnum fits in int.
11930 * cmds.c (move_point): New function, that does the gist of
11931 Fforward_char and Fbackward_char, but does so while checking
11932 for integer overflow more accurately.
c96e5d6a 11933 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
11934 (Fforward_line, Fend_of_line, internal_self_insert)
11935 (internal_self_insert):
11936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
11937 Fix a FIXME, by checking for integer overflow when calculating
11938 target_clm and actual_clm.
11939 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 11940 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
11941 (ASSURE_DESTINATION, coding_alloc_by_realloc)
11942 (coding_alloc_by_making_gap, alloc_destination)
11943 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
11944 (encode_coding_utf_16, detect_coding_emacs_mule)
11945 (decode_coding_emacs_mule, encode_coding_emacs_mule)
11946 (detect_coding_iso_2022, decode_coding_iso_2022)
11947 (encode_invocation_designation, encode_designation_at_bol)
11948 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11949 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
11950 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
11951 (encode_coding_ccl, encode_coding_raw_text)
11952 (detect_coding_charset, decode_coding_charset)
11953 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
11954 (produce_composition, produce_charset, produce_annotation)
11955 (decode_coding, handle_composition_annotation)
11956 (handle_charset_annotation, consume_chars, decode_coding_gap)
11957 (decode_coding_object, encode_coding_object, detect_coding_system)
11958 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
11959 (code_convert_region, code_convert_string)
8f50130c
PE
11960 (Fdefine_coding_system_internal)
11961 (coding_set_source, coding_set_destination):
d311d28c
PE
11962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
11963 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
11964 (Fdefine_coding_system_internal):
11965 Don't assume fixnums fit in int.
11966 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 11967 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
11968 (Funencodable_char_position, Fcheck_coding_systems_region)
11969 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 11970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 11971 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 11972 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 11973 Don't access memory outside of the args array.
d311d28c 11974 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
11975 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
11976 result of ENCODE_CHAR.
d311d28c
PE
11977 * coding.h: Adjust decls to match defn changes elsewhere.
11978 (struct coding_system):
11979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
11980 * composite.c (get_composition_id, find_composition)
11981 (run_composition_function, update_compositions)
11982 (compose_text, composition_gstring_put_cache)
11983 (composition_gstring_p, composition_gstring_width)
11984 (fill_gstring_header, fill_gstring_body, autocmp_chars)
11985 (composition_compute_stop_pos, composition_reseat_it)
11986 (composition_update_it, struct position_record)
11987 (find_automatic_composition, composition_adjust_point)
11988 (Fcomposition_get_gstring, Ffind_composition_internal):
11989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
11990 (update_compositions):
11991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
11992 * composite.h: Adjust decls to match defn changes elsewhere.
11993 (struct composition):
11994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
11995 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
11996 Do not attempt to compute the address of the object just before a
11997 buffer; this is not portable.
11998 (Faref, Faset):
11999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12000 (Faset): Use int, not EMACS_INT, where int is wide enough.
12001 (Fstring_to_number): Don't assume fixnums fit in int.
12002 (Frem): Don't assume arg is nonnegative.
12003 * dbusbind.c (xd_append_arg): Check for integers out of range.
12004 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 12005 (extract_signed, extract_unsigned): New functions.
243e0530
PE
12006 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
12007 (xd_get_connection_references): Return ptrdiff_t, not int.
12008 All uses changed.
12009 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
12010 (xd_read_message_1):
12011 Use int, not unsigned, where the dbus API uses int.
12012 (Fdbus_message_internal): Don't overflow mtype.
12013 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
12014 * dired.c (directory_files_internal, file_name_completion, scmp)
12015 (file_name_completion_stat):
12016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12017 (file_name_completion): Don't overflow matchcount.
12018 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
12019 * dispextern.h: Adjust decls to match defn changes elsewhere.
12020 (struct text_pos, struct glyph, struct bidi_saved_info)
12021 (struct bidi_string_data, struct bidi_it, struct composition_it)
12022 (struct it):
12023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12024 (struct display_pos, struct composition_it, struct it):
12025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12026 * dispnew.c (increment_matrix_positions)
12027 (increment_row_positions, mode_line_string)
12028 (marginal_area_string):
12029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 12030 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
12031 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12032 (duration_to_sec_usec): New function, to check for overflow better.
12033 (Fsleep_for, sit_for): Use it.
12034 * doc.c (get_doc_string, store_function_docstring):
12035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12036 (get_doc_string, Fsnarf_documentation):
12037 Use int, not EMACS_INT, where int is wide enough.
12038 (get_doc_string):
12039 Use SAFE_ALLOCA, not alloca.
12040 Check for overflow when converting EMACS_INT to off_t.
12041 * doprnt.c (doprnt):
12042 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12043 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
12044 Don't assume uid_t fits into fixnum.
12045 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
12046 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
12047 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
12048 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
12049 (general_insert_function)
12050 (Finsert_char, make_buffer_string, make_buffer_string_both)
12051 (update_buffer_properties, Fbuffer_substring)
12052 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
12053 (Fsubst_char_in_region, check_translation)
12054 (Ftranslate_region_internal, save_restriction_restore, Fformat)
12055 (transpose_markers, Ftranspose_regions):
12056 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12057 (clip_to_bounds): Move to lisp.h as an inline function).
12058 (Fconstrain_to_field): Don't assume integers are nonnegative.
12059 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
12060 (Fsubst_char_in_region, Fsave_restriction):
12061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12062 (Femacs_pid): Don't assume pid_t fits into fixnum.
12063 (lo_time): Use int, not EMACS_INT, when int suffices.
12064 (lisp_time_argument): Check for usec out of range.
12065 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
12066 (Fuser_login_name, Fuser_full_name): Signal an error
12067 if a uid argument is out of range, rather than relying on
12068 undefined behavior.
c8d5c857
PE
12069 (Fformat_time_string): Remove now-unnecessary check.
12070 lisp_time_argument checks for out-of-range usec now.
243e0530 12071 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
12072 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
12073 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
12074 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
12075 (init_cmdargs, Fdump_emacs):
12076 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12077 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
12078 the bottom (typically) 32 bits of the fixnum.
12079 * eval.c (specpdl_size, call_debugger):
12080 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12081 (when_entered_debugger, Fbacktrace_debug):
12082 Don't assume fixnum can fit in int.
12083 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
12084 the object just before a buffer; this is not portable.
12085 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
12086 (grow_specpdl, unbind_to):
12087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12088 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
12089 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 12090 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
12091 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
12092 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
12093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12094 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
12095 (a_write, e_write):
12096 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12097 (Fcopy_file, non_regular_nbytes, read_non_regular)
12098 (Finsert_file_contents):
12099 Use int, not EMACS_INT, where int is wide enough.
12100 (READ_BUF_SIZE): Verify that it fits in int.
12101 (Finsert_file_contents): Check that counts are in proper range,
12102 rather than assuming fixnums fit into ptrdiff_t etc.
12103 Don't assume fixnums fit into int.
125b3835 12104 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
12105 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
12106 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
12107 (string_char_to_byte, string_byte_to_char)
12108 (string_make_multibyte, string_to_multibyte)
12109 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
12110 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
12111 (substring_both, Fdelete, internal_equal, Ffillarray)
12112 (Fclear_string, mapcar1)
12113 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
12114 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
12115 (larger_vector, make_hash_table, maybe_resize_hash_table)
12116 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
12117 (Fmaphash, secure_hash):
12118 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12119 (concat): Check for string index and length overflow.
12120 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
12121 (Frequire):
12122 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12123 (larger_vector): New API (vec, incr_min, size_max) replaces old
12124 one (vec, new_size, init). This catches size overflow.
12125 INIT was removed because it was always Qnil.
12126 All callers changed.
12127 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
12128 the upper bound on a hash table index size.
12129 (make_hash_table, maybe_resize_hash_table): Use it.
12130 (secure_hash): Computer start_byte and end_byte only after
12131 they're known to be in ptrdiff_t range.
12132 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
12133 (Ffont_get_glyphs, Ffont_at):
12134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12135 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
12136 (Flist_fonts, Fopen_font):
12137 Don't assume fixnum can fit in int.
12138 (check_gstring): Don't assume index can fit in int.
12139 (font_match_p): Check that fixnum is a character, not a nonnegative
12140 fixnum, since the later code needs to stuff it into an int.
12141 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
12142 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
12143 conversion overflow issues.
12144 (Fopen_font): Check for integer out of range.
12145 (Ffont_get_glyphs): Don't assume index can fit in int.
12146 * font.h: Adjust decls to match defn changes elsewhere.
12147 * fontset.c (reorder_font_vector): Redo score calculation to avoid
12148 integer overflow.
12149 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
12150 printmax_t, where ptrdiff_t is wide enough.
12151 (Finternal_char_font):
12152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12153 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
12154 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
12155 (Fset_frame_position, x_set_frame_parameters)
12156 (x_set_line_spacing, x_set_border_width)
12157 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
12158 Check that fixnums are in proper range for system types.
12159 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
12160 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12161 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
12162 Use SAFE_ALLOCA_LISP, not alloca.
12163 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
12164 intptr_t is wide enough.
12165 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
12166 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
12167 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
12168 Check for fixnum out of range.
12169 * ftfont.c (ftfont_list): Don't assume index fits in int.
12170 Check that fixnums are in proper range for system types.
12171 (ftfont_shape_by_flt):
12172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
12173 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12175 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
12176 Check that fixnums are in proper range for system types.
12177 * gnutls.h: Adjust decls to match defn changes elsewhere.
12178 * gtkutil.c (xg_dialog_run):
12179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12180 (update_frame_tool_bar):
12181 Check that fixnums are in proper range for system types.
12182 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 12183 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
12184 * indent.c (last_known_column, last_known_column_point):
12185 (current_column_bol_cache):
12186 (skip_invisible, current_column, check_display_width):
12187 (check_display_width, scan_for_column, current_column_1)
12188 (Findent_to, Fcurrent_indentation, position_indentation)
12189 (indented_beyond_p, Fmove_to_column, compute_motion):
12190 (Fcompute_motion, Fvertical_motion):
12191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12192 (last_known_column_modified): Use EMACS_INT, not int.
12193 (check_display_width):
12194 (Fcompute_motion):
12195 Check that fixnums and floats are in proper range for system types.
12196 (compute_motion): Don't assume index or fixnum fits in int.
12197 (compute_motion, Fcompute_motion):
12198 Use int, not EMACS_INT, when it is wide enough.
12199 (vmotion): Omit local var start_hpos that is always 0; that way
12200 we don't need to worry about overflow in expressions involving it.
12201 * indent.h: Adjust decls to match defn changes elsewhere.
12202 (struct position):
12203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12204 Use int, not EMACS_INT, where int is wide enough.
12205 Remove unused members ovstring_chars_done and tab_offset;
12206 all uses removed.
12207 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
12208 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
12209 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
12210 (make_gap, copy_text, insert, insert_and_inherit)
12211 (insert_before_markers, insert_before_markers_and_inherit)
12212 (insert_1, count_combining_before, count_combining_after)
12213 (insert_1_both, insert_from_string)
12214 (insert_from_string_before_markers, insert_from_string_1)
12215 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
12216 (adjust_after_replace, adjust_after_insert, replace_range)
12217 (replace_range_2, del_range, del_range_1, del_range_byte)
12218 (del_range_both, del_range_2, modify_region)
12219 (prepare_to_modify_buffer, signal_before_change)
12220 (signal_after_change, Fcombine_after_change_execute):
12221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12222 * intervals.c (traverse_intervals, rotate_right, rotate_left)
12223 (balance_an_interval, split_interval_right, split_interval_left)
12224 (find_interval, next_interval, update_interval)
12225 (adjust_intervals_for_insertion, delete_node, delete_interval)
12226 (interval_deletion_adjustment, adjust_intervals_for_deletion)
12227 (static_offset_intervals, offset_intervals)
12228 (merge_interval_right, merge_interval_left, make_new_interval)
12229 (graft_intervals_into_buffer, temp_set_point_both)
12230 (temp_set_point, set_point, adjust_for_invis_intang)
12231 (set_point_both, move_if_not_intangible, get_property_and_range)
12232 (get_local_map, copy_intervals, copy_intervals_to_string)
12233 (compare_string_intervals, set_intervals_multibyte_1):
12234 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12235 * intervals.h: Adjust decls to match defn changes elsewhere.
12236 (struct interval):
12237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12238 * keyboard.c (this_command_key_count, this_single_command_key_start)
12239 (before_command_key_count, before_command_echo_length, echo_now)
12240 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
12241 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
12242 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
12243 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
12244 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12245 (last_non_minibuf_size, last_point_position, echo_truncate)
12246 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
12247 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
12248 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
12249 (stuff_buffered_input):
12250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12251 (last_auto_save, command_loop_1, read_char):
12252 Use EMACS_INT, not int, to avoid integer overflow.
12253 (record_char): Avoid overflow in total_keys computation.
12254 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
12255 * keyboard.h: Adjust decls to match defn changes elsewhere.
12256 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
12257 (Fkey_description, Fdescribe_vector, Flookup_key):
12258 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12259 (click_position): New function, to check that positions are in range.
12260 (Fcurrent_active_maps):
12261 (describe_command):
12262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12263 (Faccessible_keymaps, Fkey_description):
12264 (preferred_sequence_p):
12265 Don't assume fixnum can fit into int.
12266 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
12267 Check for integer overflow in size calculations.
12268 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
12269 avoid mishandling large integers.
12270 * lisp.h: Adjust decls to match defn changes elsewhere.
12271 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
12272 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
12273 (struct Lisp_Marker):
12274 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12275 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
12276 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
12277 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
12278 All callers changed.
12279 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
12280 Assume the arg has valid form, since it always does.
12281 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
12282 unsigned integer system type.
12283 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
12284 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
12285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12286 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
12287 (duration_to_sec_usec): New decl.
12288 * lread.c (read_from_string_index, read_from_string_index_byte)
12289 (read_from_string_limit, readchar, unreadchar, openp)
12290 (read_internal_start, read1, oblookup):
12291 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12292 (Fload, readevalloop, Feval_buffer, Feval_region):
12293 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12294 (openp): Check for out-of-range argument to 'access'.
12295 (read1): Use int, not EMACS_INT, where int is wide enough.
12296 Don't assume fixnum fits into int.
6efdadfd 12297 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
12298 (read_filtered_event): Use duration_to_sec_usec
12299 to do proper overflow checking on durations.
d311d28c
PE
12300 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
12301 in size calculation.
12302 (Fexecute_kbd_macro):
12303 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12304 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
12305 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
12306 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
12307 (set_marker_both, set_marker_restricted_both, marker_position)
12308 (marker_byte_position, Fbuffer_has_markers_at):
12309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12310 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 12311 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
12312 It now merely ensures that the menu is large enough, without
12313 necessarily growing it, as this avoids some integer overflow issues.
12314 All callers changed.
12315 (keymap_panes, parse_single_submenu, Fx_popup_menu):
12316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12317 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
12318 Use SAFE_ALLOCA_LISP, not alloca.
12319 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
12320 to EMACS_INT. Check that fixnums are in proper range for system types.
12321 * minibuf.c (minibuf_prompt_width, string_to_object)
12322 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
12323 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
12324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12325 (get_minibuffer, read_minibuf_unwind):
12326 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12327 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
12328 this simplifies overflow checking. All callers changed.
12329 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
12330 (Ftest_completion):
12331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12332 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
12333 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
12334 Check that fixnums are in proper range for system types.
12335 (Fx_create_frame, Fx_show_tip):
12336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12337 * nsfont.m (ns_findfonts, nsfont_list_family):
12338 Don't assume fixnum fits in long.
12339 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
12340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12341 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
12342 wide enough.
17fdb222 12343 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
12344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12345 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
12346 (PRINTDECLARE, PRINTPREPARE):
12347 (strout, print_string):
12348 (print, print_preprocess, print_check_string_charset_prop)
12349 (print_object):
12350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12351 (PRINTDECLARE):
12352 (temp_output_buffer_setup, Fprin1_to_string, print_object):
12353 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12354 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 12355 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 12356 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
12357 (print_error_message): Use SAFE_ALLOCA, not alloca.
12358 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
12359 (print_depth, new_backquote_output, print_number_index):
12360 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
12361 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
12362 (Fset_process_window_size, Fformat_network_address)
12363 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 12364 (sigchld_handler):
d311d28c 12365 Check that fixnums are in proper range for system types.
d44287d4 12366 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
12367 Check for process-ids out of pid_t range rather than relying on
12368 undefined behavior.
e4d81efc 12369 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
12370 (Fformat_network_address, read_process_output, send_process)
12371 (Fprocess_send_region, status_notify):
12372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12373 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
12374 (wait_reading_process_output, read_process_output, exec_sentinel):
12375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12376 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
12377 (Faccept_process_output): Use duration_to_sec_usec to do proper
12378 overflow checking on durations.
dde14581
PE
12379 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
12380 Don't assume pid_t fits in int.
02481186
PE
12381 * process.h (struct Lisp_Process): Members tick and update_tick
12382 are now of type EMACS_INT, not int.
b62b53e8
PE
12383 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
12384 configured --with-wide-int.
d311d28c
PE
12385 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
12386 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
12387 * search.c (looking_at_1, string_match_1):
12388 (fast_string_match, fast_c_string_match_ignore_case)
12389 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
12390 (scan_newline, find_before_next_newline, search_command)
12391 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
12392 (set_search_regs, wordify):
12393 (Freplace_match):
12394 (Fmatch_data):
12395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12396 (string_match_1, search_buffer, set_search_regs):
12397 (Fmatch_data):
12398 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12399 (wordify): Check for overflow in size calculation.
12400 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
12401 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
12402 Check that fixnums are in proper range for system types.
12403 * sound.c (struct sound_device)
12404 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
12405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12406 (Fplay_sound_internal):
12407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 12408 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
12409 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
12410 (Fparse_partial_sexp):
12411 Don't assume fixnums can fit in int.
12412 (struct lisp_parse_state, find_start_pos, find_start_value)
12413 (find_start_value_byte, find_start_begv)
12414 (update_syntax_table, char_quoted, dec_bytepos)
12415 (find_defun_start, prev_char_comend_first, back_comment):
12416 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
12417 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
12418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12419 (Finternal_describe_syntax_value): Check that match_lisp is a
12420 character, not an integer, since the code stuffs it into int.
12421 (scan_words, scan_sexps_forward):
12422 Check that fixnums are in proper range for system types.
12423 (Fforward_word):
12424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12425 (scan_sexps_forward):
12426 Use CHARACTERP, not INTEGERP, since the value must fit into int.
12427 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
12428 * syntax.h: Adjust decls to match defn changes elsewhere.
12429 (struct gl_state_s):
12430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
12431 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
12432 MOST_POSITIVE_FIXNUM.
d311d28c
PE
12433 * sysdep.c (wait_for_termination_1, wait_for_termination)
12434 (interruptible_wait_for_termination, mkdir):
12435 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
12436 (emacs_read, emacs_write):
12437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
12438 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
12439 and double all fit in int.
d311d28c
PE
12440 * term.c (set_tty_color_mode):
12441 Check that fixnums are in proper range for system types.
12442 * termhooks.h (struct input_event):
12443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12444 * textprop.c (validate_interval_range, interval_of)
12445 (Fadd_text_properties, set_text_properties_1)
12446 (Fremove_text_properties, Fremove_list_of_text_properties)
12447 (Ftext_property_any, Ftext_property_not_all)
12448 (copy_text_properties, text_property_list, extend_property_ranges)
12449 (verify_interval_modification):
12450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12451 (Fnext_single_char_property_change)
12452 (Fprevious_single_char_property_change):
12453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
12454 (copy_text_properties):
12455 Check for integer overflow in index calculation.
d311d28c
PE
12456 * undo.c (last_boundary_position, record_point, record_insert)
12457 (record_delete, record_marker_adjustment, record_change)
12458 (record_property_change):
12459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12460 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
12461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12462 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
12463 (Fx_hide_tip, Fx_file_dialog):
12464 * w32menu.c (set_frame_menubar):
12465 Use ptrdiff_t, not int, for consistency with rest of code.
12466 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
12467 (select_window, Fdelete_other_windows_internal)
12468 (window_scroll_pixel_based, window_scroll_line_based)
12469 (Frecenter, Fset_window_configuration):
12470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12471 (Fset_window_hscroll, run_window_configuration_change_hook)
12472 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 12473 (Fscroll_other_window, Frecenter):
d311d28c
PE
12474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12475 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
12476 Don't assume fixnum fits in int.
12477 (Fset_window_scroll_bars):
12478 Check that fixnums are in proper range for system types.
12479 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
12480 (string_pos, c_string_pos, number_of_chars, init_iterator)
12481 (in_ellipses_for_invisible_text_p, init_from_display_pos)
12482 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
12483 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
12484 (face_before_or_after_it_pos, handle_invisible_prop)
12485 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
12486 (display_prop_intangible_p, string_buffer_position_lim)
12487 (string_buffer_position, handle_composition_prop, load_overlay_strings)
12488 (get_overlay_strings_1, get_overlay_strings)
12489 (iterate_out_of_display_property, forward_to_next_line_start)
12490 (back_to_previous_visible_line_start, reseat, reseat_to_string)
12491 (get_next_display_element, set_iterator_to_next)
12492 (get_visually_first_element, compute_stop_pos_backwards)
12493 (handle_stop_backwards, next_element_from_buffer)
12494 (move_it_in_display_line_to, move_it_in_display_line)
12495 (move_it_to, move_it_vertically_backward, move_it_by_lines)
12496 (add_to_log, message_dolog, message_log_check_duplicate)
12497 (message2, message2_nolog, message3, message3_nolog
12498 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
12499 (current_message_1, truncate_echo_area, truncate_message_1)
12500 (set_message, set_message_1, store_mode_line_noprop)
12501 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
12502 (text_outside_line_unchanged_p, check_point_in_composition)
12503 (reconsider_clip_changes)
12504 (redisplay_internal, set_cursor_from_row, try_scrolling)
12505 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
12506 (redisplay_window, find_last_unchanged_at_beg_row)
12507 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
12508 (trailing_whitespace_p, find_row_edges, display_line)
12509 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
12510 (display_mode_element, store_mode_line_string)
12511 (pint2str, pint2hrstr, decode_mode_spec)
12512 (display_count_lines, display_string, draw_glyphs)
12513 (x_produce_glyphs, x_insert_glyphs)
12514 (rows_from_pos_range, mouse_face_from_buffer_pos)
12515 (fast_find_string_pos, mouse_face_from_string_pos)
12516 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12518 (safe_call, init_from_display_pos, handle_fontified_prop)
12519 (handle_single_display_spec, load_overlay_strings)
12520 (with_echo_area_buffer, setup_echo_area_for_printing)
12521 (display_echo_area, echo_area_display)
12522 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
12523 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
12524 (redisplay_window, dump_glyph_row, display_mode_line)
12525 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 12526 (handle_display_spec, display_prop_string_p):
d311d28c
PE
12527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12528 (handle_single_display_spec, build_desired_tool_bar_string)
12529 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
12530 (get_specified_cursor_type):
12531 Check that fixnums are in proper range for system types.
12532 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
12533 (Flookup_image_map):
12534 Don't assume fixnums fit in int.
12535 (compare_overlay_entries):
12536 Avoid mishandling comparisons due to subtraction overflow.
12537 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
12538 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
12539 (handle_tool_bar_click):
12540 Use int, not unsigned, since we prefer signed and the signedness
12541 doesn't matter here.
12542 (get_next_display_element, next_element_from_display_vector):
12543 Use int, not EMACS_INT, when int is wide enough.
12544 (start_hourglass): Use duration_to_sec_usec to do proper
12545 overflow checking on durations.
12546 * xfaces.c (Fbitmap_spec_p):
12547 Check that fixnums are in proper range for system types.
12548 (compare_fonts_by_sort_order):
12549 Avoid mishandling comparisons due to subtraction overflow.
12550 (Fx_family_fonts, realize_basic_faces):
12551 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12552 (Fx_family_fonts):
12553 Don't assume fixnum fits in int.
12554 Use SAFE_ALLOCA_LISP, not alloca.
12555 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
12556 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
12557 (face_at_buffer_position, face_for_overlay_string)
12558 (face_at_string_position):
12559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12560 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
12561 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
12562 (Fx_show_tip):
12563 Check that fixnums are in proper range for system types.
12564 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
12565 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
12566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12567 (Fx_change_window_property): Don't assume fixnums fit in int.
12568 * xfont.c (xfont_chars_supported):
12569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12570 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
12571 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
12572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12573 * xml.c (parse_region):
12574 * xrdb.c (magic_file_p):
12575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
12576 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
12577 (x_get_local_selection, x_reply_selection_request)
12578 (x_handle_selection_request, wait_for_property_change):
12579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12580 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
12581 short is wide enough.
12582 (x_send_client_event): Don't assume fixnum fits in int.
12583 * xterm.c (x_x_to_emacs_modifiers):
12584 Don't assume EMACS_INT overflows nicely into int.
12585 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
12586 may come from Lisp.
12587 (handle_one_xevent): NATNUMP can eval its arg twice.
12588 (x_connection_closed):
12589 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
12590 * xterm.h: Adjust decls to match defn changes elsewhere.
12591 (struct scroll_bar): Use struct vectorlike_header
12592 rather than rolling our own approximation.
12593 (SCROLL_BAR_VEC_SIZE): Remove; not used.
12594
c6574eb5
GM
125952012-05-25 Glenn Morris <rgm@gnu.org>
12596
12597 * lisp.mk (lisp): Update for more files being compiled now.
12598
e8d32c7e
SM
125992012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
12600
48def666
SM
12601 * lread.c: Remove `read_pure' which makes no difference.
12602 (read_pure): Remove var.
12603 (unreadpure): Remove function.
12604 (readevalloop): Don't call read_list with -1 flag.
12605 (read1, read_vector): Don't test read_pure any more.
12606 (read_list): Simplify.
12607
e8d32c7e
SM
12608 * fileio.c, character.h: Minor style tweaks.
12609
4b2addb7
DA
126102012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
12611
12612 * window.h (clip_changed): Remove useless declaration.
12613
584461b2
JB
126142012-05-22 Juanma Barranquero <lekktu@gmail.com>
12615
12616 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
12617 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
12618
34374650
PE
126192012-05-22 Paul Eggert <eggert@cs.ucla.edu>
12620
12621 Remove src/m/*.
12622 This directory predates autoconf and is no longer needed nowadays.
12623 Move its few remaining bits of functionality to where they're needed.
12624 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
12625 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
12626 * m/template.h: Remove.
12627 * Makefile.in (M_FILE): Remove. All uses removed.
12628 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
12629 * lisp.h (USE_LSB_TAG):
12630 * mem-limits.h (EXCEEDS_LISP_PTR):
12631 Use VAL_MAX, not VALBITS, in #if.
12632 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
12633 (EMACS_UINT): Define unconditionally now.
12634 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
12635 (BITS_PER_EMACS_INT): New constants, replacing
12636 what used to be in config.h, but not useful in #if.
12637 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
12638 define them any more.
12639 (VAL_MAX): New macro.
12640 (VALMASK): Use it.
12641 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
12642 BITS_PER_EMACS_INT, in #if.
12643 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
12644 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
12645 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
12646 * s/ms-w32.h (DATA_START):
12647 Move here from removed file m/intel386.h.
12648 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
12649 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
12650
261cb4bb
PE
126512012-05-21 Paul Eggert <eggert@cs.ucla.edu>
12652
12653 Assume C89 or later.
12654 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
12655 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
12656 (xrealloc):
12657 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
12658 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
12659 * textprop.c, tparam.c (NULL): Remove.
12660 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
12661 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
12662 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
12663 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
12664 * xterm.c (input_signal_count): Assume volatile works.
12665
ff23cd9f
KB
126662012-05-21 Ken Brown <kbrown@cornell.edu>
12667
12668 * xgselect.c (xg_select): Fix first argument in call to 'select'
12669 (bug#11508).
12670
1b170bc6
KB
126712012-05-20 Ken Brown <kbrown@cornell.edu>
12672
12673 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 12674 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 12675
b2f4d39f
KB
126762012-05-19 Ken Brown <kbrown@cornell.edu>
12677
12678 * xfns.c (x_in_use): Remove `static' qualifier.
12679 * xterm.h (x_in_use): Declare.
12680 * xgselect.c: Include xterm.h.
12681 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
12682 and `display_arg' (bug#9754).
12683
003fdae2
PE
126842012-05-19 Paul Eggert <eggert@cs.ucla.edu>
12685
9232a6d9
PE
12686 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
12687
003fdae2
PE
12688 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
12689 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
12690
784b56e2
EZ
126912012-05-18 Eli Zaretskii <eliz@gnu.org>
12692
12693 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
12694
12695 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 12696 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
12697
12698 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
12699 reference to image_cache->refcount.
12700 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
12701
a0a79cde
JL
127022012-05-17 Juri Linkov <juri@jurta.org>
12703
12704 * search.c (Fword_search_regexp, Fword_search_backward)
12705 (Fword_search_forward, Fword_search_backward_lax)
12706 (Fword_search_forward_lax): Move functions to isearch.el
12707 (bug#10145, bug#11381).
12708
b0572523
PE
127092012-05-16 Paul Eggert <eggert@cs.ucla.edu>
12710
12711 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
12712
9660f5fc
SM
127132012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
12714
12715 * lread.c (init_obarray): Declare Qt and Qnil as special.
12716
4374de83
GM
127172012-05-14 Glenn Morris <rgm@gnu.org>
12718
12719 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 12720 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 12721
dc44c39a
PE
127222012-05-14 Paul Eggert <eggert@cs.ucla.edu>
12723
078c97cb
PE
12724 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
12725
dc44c39a
PE
12726 * unexaix.c: Port to more-recent AIX compilers.
12727 (report_error, report_error_1, make_hdr, copy_sym)
12728 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
12729 Make arguments const char *, not char *, to avoid violations of C
12730 standard and to fix some AIX warnings reported by Gilles Pion.
12731
e18afed7 127322012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
12733
12734 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
12735 already have overlays loaded.
12736 (handle_single_display_spec): Before returning without displaying
12737 fringe bitmap, synchronize the bidi iterator with the main display
12738 iterator, by calling iterate_out_of_display_property.
12739 (iterate_out_of_display_property): Detect buffer iteration by
12740 testing that it->string is a Lisp string.
12741 (get_next_display_element): When the current object is exhausted,
12742 and there's something on it->stack, call set_iterator_to_next to
12743 proceed with what's on the stack, instead of returning zero.
12744 (set_iterator_to_next): If called at the end of a Lisp string,
12745 proceed to consider_string_end without incrementing string
12746 position. Don't increment display vector index past the end of
12747 the display vector. (Bug#11417)
c8fb9dc6
EZ
12748 (pos_visible_p): Don't report a position visible when move_it_to
12749 stopped at the last line of window, which happens to be scanned
12750 backwards by the bidi iteration. (Bug#11464)
ac268e67 12751
e18afed7 127522012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
12753
12754 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
12755 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
12756 are on a TTY, and thus unable to display on the fringes.
12757 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
12758 so we need to signal to the caller that this is a "replacing"
12759 display spec. This fixes display when the spec is invalid or we
12760 are on a TTY.
12761
e18afed7 127622012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
12763
12764 * unexaix.c (make_hdr): Fix typo in prototype.
12765 This bug broke the build on AIX. Problem reported by Gilles Pion.
12766
9d0a235a
MA
127672012-05-14 Michael Albinus <michael.albinus@gmx.de>
12768
12769 * keyboard.c (kbd_buffer_get_event): Read special events also in
12770 batch mode. (Bug#11415)
12771
9e6b06ed
GM
127722012-05-12 Glenn Morris <rgm@gnu.org>
12773
12774 * ns.mk: Update for ns_appbindir no longer having trailing "/".
12775
c1a1d7a3
EZ
127762012-05-12 Eli Zaretskii <eliz@gnu.org>
12777
12778 * lisp.mk (lisp): Add newcomment.elc.
12779
3fe7cdc8
GM
127802012-05-12 Glenn Morris <rgm@gnu.org>
12781
12782 * Makefile.in (MKDIR_P): New, set by configure.
12783 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
12784
53f7d2c0
PE
127852012-05-11 Paul Eggert <eggert@cs.ucla.edu>
12786
12787 Remove unused function hourglass_started.
12788 * dispextern.h (hourglass_started):
12789 * w32fns.c (hourglass_started):
12790 * xdisp.c (hourglass_started): Remove.
12791
75aafb17
JB
127922012-05-10 Juanma Barranquero <lekktu@gmail.com>
12793
12794 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
12795 Update dependencies.
12796
12959e8e
PE
127972012-05-10 Paul Eggert <eggert@cs.ucla.edu>
12798
97107e2e
PE
12799 * xgselect.c (xg_select): Put maxfds+1 into a var.
12800 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
12801
12959e8e
PE
12802 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
12803
836d29b3
DA
128042012-05-10 Dave Abrahams <dave@boostpro.com>
12805
12806 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
12807 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
12808
5cb67954
MA
128092012-05-09 Michael Albinus <michael.albinus@gmx.de>
12810
12811 * dbusbind.c (xd_registered_buses): New internal Lisp object.
cccaebd2 12812 Rename all occurrences of Vdbus_registered_buses to xd_registered_buses.
5cb67954
MA
12813 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
12814 Initialize xd_registered_buses.
12815
3478ec45
PE
128162012-05-09 Paul Eggert <eggert@cs.ucla.edu>
12817
b263a6b0
PE
12818 Untag more efficiently if USE_LSB_TAG.
12819 This is based on a proposal by YAMAMOTO Mitsuharu in
12820 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
12821 For an admittedly artificial (nth 8000 longlist) benchmark on
12822 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
12823 Emacs's overall text size by 1%.
12824 * lisp.h (XUNTAG): New macro.
12825 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
12826 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
12827 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
12828 * eval.c (Fautoload):
12829 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
12830 * frame.h (XFRAME): Use XUNTAG.
12831
3478ec45
PE
12832 Port recent dbusbind.c changes to 32-bit --with-wide-int.
12833 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
12834 Remove unportable assumptions about print widths of types like
12835 dbus_uint32_t.
12836 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
12837 intptr_t when converting between pointer and integer, to avoid GCC
12838 warnings about wrong width.
12839
666b903b 128402012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
12841
12842 * w32proc.c (new_child): Force Windows to reserve only 64KB of
12843 stack for each reader_thread, instead of defaulting to 8MB
12844 determined by the linker. This avoids failures in creating
12845 subprocesses on Windows 7, see the discussion in this thread:
12846 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
12847
b120cc17
JC
128482012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
12849
12850 Fix up display of the *Minibuf-0* buffer in the mini window.
12851 * keyboard.c (read_char): Don't clear the echo area if there's no
12852 message to clear.
12853 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 12854 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 12855
9a4b36f8
MA
128562012-05-07 Michael Albinus <michael.albinus@gmx.de>
12857
12858 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
12859 batch mode.
12860
e5f9458f
CY
128612012-05-06 Chong Yidong <cyd@gnu.org>
12862
12863 * lisp.mk (lisp): Update.
12864
eceeb5fc 128652012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
12866
12867 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
12868
71873e2b
SM
128692012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
12870
12871 * data.c (PUT_ERROR): New macro.
12872 (syms_of_data): Use it. Add new error type `user-error'.
12873 * undo.c (user_error): New function.
12874 (Fprimitive_undo): Use it.
12875 * print.c (print_error_message): Adjust print style for `user-error'.
12876 * keyboard.c (user_error): New function.
12877 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
12878
ab0fa4e4
PE
128792012-05-03 Paul Eggert <eggert@cs.ucla.edu>
12880
12881 Do not limit current-time-string to years 1000..9999.
12882 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
12883 (Fcurrent_time_string): Support any year that is supported by the
12884 underlying localtime representation. Don't use asctime, as it
12885 has undefined behavior for years outside the range -999..9999.
12886
7ed806a7
PE
128872012-05-02 Paul Eggert <eggert@cs.ucla.edu>
12888
12889 Fix race conditions involving setenv, gmtime, localtime, asctime.
12890 Without this fix, interrupts could mess up code that uses these
12891 nonreentrant functions, since setting TZ invalidates existing
12892 tm_zone or tzname values, and since most of these functions return
12893 pointers to static storage.
12894 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
12895 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
12896 Grow the critical sections to include not just invoking
12897 localtime/gmtime, but also accessing these functions' results
12898 including their tm_zone values if any, and any related TZ setting.
12899 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
12900 so that the struct tm is saved in the critical section.
12901 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
12902 motivated by the fact that memory allocation needs to be outside
12903 the critical section.
12904
0c16dfed
DA
129052012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
12906
12907 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
12908 with RESET_INTERVAL.
12909
12910 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12911 Remove duplicated buffer name initialization.
12912
3f83ace8
JM
129132012-05-02 Jim Meyering <jim@meyering.net>
12914
12915 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
12916
c7b8541e
JM
12917 * xfns.c (x_window): Use xstrdup (Bug#11375).
12918
90207a15 129192012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
12920
12921 * xdisp.c (pos_visible_p): If already at a newline from the
12922 display string before the 'while' loop, don't walk back the glyphs
12923 from it3.glyph_row. Solves assertion violation when the display
12924 string begins with a newline (egg.el). (Bug#11367)
12925
b593d6a9
AH
129262012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
12927
12928 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
12929 Move to simple.el.
12930
4737362e
GM
129312012-05-01 Glenn Morris <rgm@gnu.org>
12932
99cf43f9
GM
12933 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
12934 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
12935 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
12936 All were removed before 23.1.
12937
9311dcff
GM
12938 * dispnew.c: Remove HAVE_LIBNCURSES test;
12939 it is always true on relevant platforms.
12940
4d5c6349
GM
12941 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
12942 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
12943
4737362e
GM
12944 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
12945
74dd3a6b
AS
129462012-04-30 Andreas Schwab <schwab@linux-m68k.org>
12947
12948 * .gdbinit (xpr): Remove checks for no longer existing misc types.
12949 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
12950 Remove.
12951
13c379ee
PE
129522012-04-28 Paul Eggert <eggert@cs.ucla.edu>
12953
12954 Do not avoid creating empty evaporating overlays (Bug#9642).
12955 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
12956 That is, do not delete an evaporating overlay if it becomes
12957 empty after its bounds are adjusted to fit within its buffer.
12958 This fix caused other problems, and I'm reverting it until we get
12959 to the bottom of them.
12960
a8e7d6d7 129612012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
12962
12963 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
12964
a8e7d6d7 129652012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
12966
12967 * xdisp.c (pos_visible_p): If the window start position is beyond
12968 ZV, start the display from buffer beginning. Prevents assertion
12969 violation in init_iterator when the minibuffer window is scrolled
12970 via the scroll bar.
12971
12972 * window.c (window_scroll_pixel_based): Likewise.
12973
a8e7d6d7 129742012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
12975
12976 * keymap.c (where_is_internal): Doc fix (Bug#10872).
12977
a8e7d6d7 129782012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
12979
12980 * fileio.c (Fcopy_file, Fset_file_selinux_context):
12981 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
12982
a8e7d6d7 129832012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 12984
b593d6a9
AH
12985 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
12986 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 12987
1c6900d9
EZ
129882012-04-26 Eli Zaretskii <eliz@gnu.org>
12989
4c3fa1d9
EZ
12990 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
12991 display element, check also the underlying string or buffer
12992 character. (Bug#11341)
12993
1c6900d9
EZ
12994 * w32menu.c: Include w32heap.h.
12995 (add_menu_item): If the call to AppendMenuW (via
12996 unicode_append_menu) fails, disable Unicode menus only if we are
12997 running on Windows 9X/Me.
12998
42bf8205
AS
129992012-04-24 Andreas Schwab <schwab@linux-m68k.org>
13000
13001 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
13002 (xgetint): Add missing shift for LSB tags.
13003
b1bac16e
MR
130042012-04-24 Martin Rudalics <rudalics@gmx.at>
13005
13006 * keyboard.c (read_char): Don't wipe echo area for select window
13007 events: These might get delayed via `mouse-autoselect-window'
13008 (Bug#11304).
13009
d69621cc
JB
130102012-04-24 Juanma Barranquero <lekktu@gmail.com>
13011
13012 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
13013 manipulation of :loaded-from data.
13014
02fd101b
JB
130152012-04-23 Juanma Barranquero <lekktu@gmail.com>
13016
13017 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
13018 now a cons (bug#11311).
13019
888bec30
PE
130202012-04-23 Paul Eggert <eggert@cs.ucla.edu>
13021
89a438bd
PE
13022 Do not create empty overlays with the evaporate property (Bug#9642).
13023 * buffer.c (Fmove_overlay): Delete an evaporating overlay
13024 if it becomes empty after its bounds are adjusted to fit within
13025 its buffer. Without this fix, in a nonempty buffer (let ((o
13026 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
13027 yields an empty overlay that has the evaporate property, which is
13028 not supposed to happen.
13029
1068fe4d
PE
13030 Fix minor GTK3 problems found by static checking.
13031 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
13032 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
13033 (struct _EmacsFixedClass, emacs_fixed_get_type):
13034 Move decls here from emacsgtkfixed.h, since they needn't be public.
13035 (emacs_fixed_get_type): Now static.
13036 (emacs_fixed_class_init): Omit unused local.
13037 (emacs_fixed_child_type): Remove; unused.
13038 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
13039 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
13040 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
13041 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
13042 (EMACS_FIXED_GET_CLASS): Remove; unused.
13043 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
13044
888bec30
PE
13045 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
13046 Problem reported by Juanma Barranquero for Windows -Wunused-function.
13047
de85e130
PE
130482012-04-22 Paul Eggert <eggert@cs.ucla.edu>
13049
d0baac98 13050 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 13051 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
13052 (__malloc_size_t, __malloc_ptrdiff_t):
13053 Remove. All uses removed, replaced by the definiens if needed,
13054 since we can assume C89 or better now.
13055 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
13056 (protect_malloc_state, align, get_contiguous_space)
13057 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
13058 (malloc_atfork_handler_child, malloc_enable_thread)
13059 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
13060 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
13061 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
13062 (special_realloc, _realloc_internal_nolock, _realloc_internal)
13063 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
13064 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
13065 Define using prototypes, not old style.
13066 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
13067 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
13068 (align): Don't assume that signed integer overflow wraps around.
13069 Omit unused local var.
13070 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
13071 (_free_internal_nolock, memalign, mallochook, reallochook):
13072 Omit no-longer-needed casts.
13073 (valloc): Use getpagesize, not __getpagesize.
13074 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
13075 (struct hdr): The 'magic' member is now size_t, not unsigned long.
13076
de85e130
PE
13077 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
13078
dcbf5805
MA
130792012-04-22 Michael Albinus <michael.albinus@gmx.de>
13080
13081 Move functions from C to Lisp. Make non-blocking method calls
13082 the default. Implement further D-Bus standard interfaces.
13083
13084 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
13085 (QCdbus_request_name_allow_replacement)
13086 (QCdbus_request_name_replace_existing)
13087 (QCdbus_request_name_do_not_queue)
13088 (QCdbus_request_name_reply_primary_owner)
13089 (QCdbus_request_name_reply_in_queue)
13090 (QCdbus_request_name_reply_exists)
13091 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
13092 (QCdbus_registered_serial, QCdbus_registered_method)
13093 (QCdbus_registered_signal): New Lisp objects.
13094 (XD_DEBUG_MESSAGE): Use sizeof.
13095 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
13096 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
13097 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
13098 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
13099 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
13100 (xd_signature, xd_append_arg): Allow float for integer types.
13101 (xd_get_connection_references): New function.
b593d6a9
AH
13102 (xd_get_connection_address): Rename from xd_initialize.
13103 Return cached address.
dcbf5805
MA
13104 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
13105 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
13106 level.
13107 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 13108 Return number of refcounts.
dcbf5805
MA
13109 (Fdbus_get_unique_name): Make stronger parameter check.
13110 (Fdbus_message_internal): New defun.
13111 (Fdbus_call_method, Fdbus_call_method_asynchronously)
13112 (Fdbus_method_return_internal, Fdbus_method_error_internal)
13113 (Fdbus_send_signal, Fdbus_register_service)
13114 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
13115 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
13116 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
13117 (Vdbus_compiled_version, Vdbus_runtime_version)
13118 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
13119 (Vdbus_message_type_method_return, Vdbus_message_type_error)
13120 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
13121 (Vdbus_registered_buses, Vdbus_registered_objects_table):
13122 Adapt docstring.
dcbf5805 13123
52828e02
PE
131242012-04-22 Paul Eggert <eggert@cs.ucla.edu>
13125
da05bc4c
PE
13126 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
13127 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
13128 Do not assume ptrdiff_t is the same width as 'int'.
13129
52828e02
PE
13130 * alloc.c: Handle unusual debugging option combinations.
13131 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
13132 since the two debugging options are incompatible.
13133 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
13134 is defined.
13135 (mem_init, mem_insert, mem_insert_fixup):
13136 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
13137 (NEED_MEM_INSERT): Remove; no longer needed.
13138
f01769f9
LL
131392012-04-22 Leo Liu <sdl.web@gmail.com>
13140
13141 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
13142
5790543d
PE
131432012-04-22 Paul Eggert <eggert@cs.ucla.edu>
13144
13145 * sysdep.c [__FreeBSD__]: Minor cleanups.
13146 (list_system_processes, system_process_attributes) [__FreeBSD__]:
13147 Use Emacs indenting style more consistently. Avoid some casts.
13148 Use 'double' consistently rather than mixing 'float' and 'double'.
13149
b91b7e4d
EW
131502012-04-21 Eduard Wiebe <usenet@pusto.de>
13151
b593d6a9
AH
13152 * sysdep.c (list_system_processes, system_process_attributes):
13153 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 13154
6114eb15
AS
131552012-04-21 Andreas Schwab <schwab@linux-m68k.org>
13156
13157 * lisp.mk (lisp): Update.
13158
2f38dff7
PE
131592012-04-20 Paul Eggert <eggert@cs.ucla.edu>
13160
13161 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
13162 It is never used otherwise.
13163
4ae29f89
SM
131642012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
13165
13166 * print.c (print_preprocess): Only check print_depth if print-circle
13167 is nil.
13168 (print_object): Check for cycles even when print-circle is nil and
13169 print-gensym is t, but only check print_depth if print-circle is nil.
13170
f30d612a
CY
131712012-04-20 Chong Yidong <cyd@gnu.org>
13172
13173 * process.c (wait_reading_process_output): If EIO occurs on a pty,
13174 set the status to "failed" and ensure that sentinel is run.
13175
c07a4c0b 131762012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
13177
13178 * process.c (Fset_process_inherit_coding_system_flag)
13179 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 13180 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 13181
c07a4c0b 131822012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
13183
13184 * xdisp.c (string_buffer_position_lim): Limit starting position to
13185 BEGV.
13186 (set_cursor_from_row): If called for a mode-line or header-line
13187 row, return zero immediately.
13188 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
13189 farther than the first row after the header line, if any.
13190 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
13191 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
13192
c07a4c0b 131932012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 13194
4ae29f89
SM
13195 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
13196 (bug#11238).
ad3a2b41 13197
c07a4c0b 131982012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 131992012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
13200
13201 configure: new option --enable-gcc-warnings (Bug#11207)
13202 * Makefile.in (C_WARNINGS_SWITCH): Remove.
13203 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
13204 (ALL_CFLAGS): Use new macros rather than old.
13205 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
13206 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
13207 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
13208 -Wunused-result, -Wunused-variable. This should go away once
13209 the Emacs and Gnulib regex code is merged.
13210 (xmalloc, xrealloc): Now static.
13211
aba027e8
PE
132122012-04-17 Paul Eggert <eggert@cs.ucla.edu>
13213
13214 * dired.c (Fsystem_groups): Remove unused local.
13215
e5a36063
GM
132162012-04-17 Glenn Morris <rgm@gnu.org>
13217
13218 * dired.c (Fsystem_users): Doc fix.
13219
316411f0
DA
132202012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
13221
13222 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
13223 (syms_of_dired): Add them.
13224
9426aba4
PE
132252012-04-16 Paul Eggert <eggert@cs.ucla.edu>
13226
b62a57be
PE
13227 Fix minor alloc.c problems found by static checking.
13228 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
13229 New extern decls, to avoid calling undeclared functions.
13230 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
13231 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
13232 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
13233 (NEED_MEM_INSERT): New macro.
13234 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 13235 Remove one incorrect comment and fix another.
b62a57be 13236
3539f31f
PE
13237 Fix minor ralloc.c problems found by static checking.
13238 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
13239 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
13240 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
13241 (r_alloc_sbrk): Now static.
13242
a041960a
PE
13243 Improve ralloc.c interface checking.
13244 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
13245 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
13246 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
13247 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
13248 [REL_ALLOC]: ... to here, to check interface.
13249 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
13250 Remove decls. This fixes an "It stinks!".
13251
9426aba4
PE
13252 * alloc.c (which_symbols): Fix alignment issue / type clash.
13253
d55c12ed
AS
132542012-04-15 Andreas Schwab <schwab@linux-m68k.org>
13255
13256 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
13257 (struct Lisp_Misc_Any): Likewise.
13258 (struct Lisp_Free): Likewise.
13259 * alloc.c (union aligned_Lisp_Symbol): Define.
13260 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
13261 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
13262 (union aligned_Lisp_Misc): Define.
13263 (MARKER_BLOCK_SIZE, struct marker_block): Use union
13264 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 13265 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 13266
b948ce8b
PE
132672012-04-14 Paul Eggert <eggert@cs.ucla.edu>
13268
13269 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
13270 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
13271 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
13272 * s/netbsd.h, s/sol2-6.h:
13273 Remove definition of GC_MARK_STACK, since the default now works.
13274 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
13275 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
13276 no longer the default.
13277 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
13278
35dc09a1 132792012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 13280
35dc09a1
GM
13281 * lread.c (lisp_file_lexically_bound_p):
13282 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 13283
35dc09a1
GM
132842012-04-14 Eli Zaretskii <eliz@gnu.org>
13285
13286 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
13287 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
13288
132892012-04-14 Jan Djärv <jan.h.d@swipnet.se>
13290
13291 * nsterm.m (constrainFrameRect): Always constrain when there is only
13292 one screen (Bug#10962).
13293
bcd86815
KB
132942012-04-13 Ken Brown <kbrown@cornell.edu>
13295
13296 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
13297
c25df26e
RT
132982012-04-13 Reuben Thomas <rrt@sc3d.org>
13299
13300 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
13301
0fc59f1e
DC
133022012-04-11 Daniel Colascione <dancol@dancol.org>
13303
13304 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
13305 against is gone. It's better to use vfork now so that when Cygwin
13306 gains a new, working vfork, we use it automatically (bug#10398).
13307
de8c03dc
SM
133082012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
13309
13310 * window.c (save_window_save): Obey window-point-insertion-type.
13311
2f097256
GM
133122012-04-11 Glenn Morris <rgm@gnu.org>
13313
13314 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
13315
453b951e
SM
133162012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
13317
13318 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
13319
75f1671a 133202012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
13321
13322 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
13323 (force_quit_count): New var.
13324 (handle_interrupt): Use it.
13325
2a8ce227
JB
133262012-04-10 Juanma Barranquero <lekktu@gmail.com>
13327
13328 * w32.c (w32_delayed_load): Record the full path of the library
13329 being loaded (bug#10424).
13330
935396c0
GM
133312012-04-09 Glenn Morris <rgm@gnu.org>
13332
05920a43
GM
13333 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
13334 not just in the obarray, before snarfing them. (Bug#11036)
13335
935396c0
GM
13336 * Makefile.in ($(leimdir)/leim-list.el):
13337 Pass EMACS rather than BUILT_EMACS.
13338
a18ecafa
TZ
133392012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
13340
13341 * process.c (make_process):
13342 * process.h: Add integer `gnutls_handshakes_tried' member to
13343 process struct.
13344
6bbef4e5
JC
13345 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
13346 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
13347
13348 * gnutls.c (gnutls_log_function2i): Convenience log function.
13349 (emacs_gnutls_read): Use new log functions,
13350 `gnutls_handshakes_tried' process member, and
13351 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
13352 attempts per process (connection).
13353
b4d3bc10
CY
133542012-04-09 Chong Yidong <cyd@gnu.org>
13355
13356 * eval.c (Fuser_variable_p, user_variable_p_eh)
13357 (lisp_indirect_variable): Functions deleted.
13358 (Fdefvar): Caller changed.
13359
13360 * callint.c (Finteractive, Fcall_interactively):
13361 * minibuf.c (Fread_variable): Callers changed.
13362
70f4d973
EZ
133632012-04-09 Eli Zaretskii <eliz@gnu.org>
13364
13365 * xdisp.c (set_cursor_from_row): If the display string appears in
13366 the buffer at position that is closer to point than the position
13367 after the display string, display the cursor on the first glyph of
13368 the display string. Fixes cursor display when a 'display' text
13369 property immediately follows invisible text. (Bug#11094)
13370
cb3c2e3e
PE
133712012-04-09 Paul Eggert <eggert@cs.ucla.edu>
13372
13373 composite.c: use 'double' consistently
13374 * composite.c (get_composition_id): Use 'double' consistently
13375 instead of converting 'float' to 'double' and vice versa; this is
13376 easier to understand and avoids a GCC warning.
13377
fd06db5d
GM
133782012-04-09 Glenn Morris <rgm@gnu.org>
13379
50fe702a
GM
13380 * Makefile.in: Generate leim-list with bootstrap-emacs, in
13381 preparation for dumping it with emacs. (Bug#4789)
13382 (leimdir): New variable.
13383 ($(leimdir)/leim-list.el): New rule.
13384 (emacs$(EXEEXT)): Depend on leim-list.el.
13385
fd06db5d
GM
13386 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
13387 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
13388 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
13389
55c131ee
AS
133902012-04-08 Andreas Schwab <schwab@linux-m68k.org>
13391
13392 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
13393 proper alignment.
13394
9209588f
JB
133952012-04-07 Juanma Barranquero <lekktu@gmail.com>
13396
13397 * xml.c (init_libxml2_functions) [WINDOWSNT]:
13398 Remove unused local variable.
13399
e3fb2efb
PE
134002012-04-07 Paul Eggert <eggert@cs.ucla.edu>
13401
13402 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
13403 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
13404 (mark_memory): Mark Lisp_Objects only if pointers might hide in
13405 objects, as mark_maybe_pointer will catch them otherwise.
13406 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
13407 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
13408
b5385551
PE
134092012-04-07 Paul Eggert <eggert@cs.ucla.edu>
13410
13411 Fix typo that broke non-Windows builds.
13412 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
13413
9078ead6
EZ
134142012-04-07 Eli Zaretskii <eliz@gnu.org>
13415
13416 Support building on MS-Windows with libxml2.
13417
13418 * makefile.w32-in (OBJ2): Add xml.$(O).
13419 (GLOBAL_SOURCES): Add xml.c.
13420 ($(BLD)/xml.$(O)): New dependency list.
13421
13422 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
13423 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
13424 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
13425 [!WINDOWSNT]: New macros.
13426 (init_libxml2_functions, libxml2_loaded_p): New functions.
13427 (parse_region): Call fn_xmlCheckVersion instead of using the macro
13428 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
13429 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
13430 Calls xmlCleanupParser only if libxml2 was loaded (or statically
13431 linked in).
6bbef4e5
JC
13432 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
13433 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
13434 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
13435
13436 * emacs.c: Don't include libxml/parser.h.
13437 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
13438 xmlCleanupParser directly.
13439
13440 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
13441
3811fdf3
EZ
134422012-04-07 Eli Zaretskii <eliz@gnu.org>
13443
13444 * indent.c (Fvertical_motion): If there is a display string at
13445 point, use it.vpos to compute how many lines to backtrack after
13446 move_it_to point. (Bug#11133)
13447
2f8e16b2
EZ
134482012-04-06 Eli Zaretskii <eliz@gnu.org>
13449
13450 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
13451 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
13452 about subtle differences between FETCH_CHAR* and STRING_CHAR*
13453 macros related to unification of CJK characters. For the details,
13454 see the discussion following the message here:
13455 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
13456
3d439cd1
CY
134572012-04-04 Chong Yidong <cyd@gnu.org>
13458
13459 * keyboard.c (Vdelayed_warnings_list): Doc fix.
13460
8bc53d00
EZ
134612012-04-01 Eli Zaretskii <eliz@gnu.org>
13462
13463 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
13464 instead of alloca. (Bug#11138)
13465
3b0512a3
AS
134662012-04-01 Andreas Schwab <schwab@linux-m68k.org>
13467
13468 * w32menu.c (is_simple_dialog): Properly check lisp types.
13469 (Bug#11141)
13470
8427ddd2
EZ
134712012-03-31 Eli Zaretskii <eliz@gnu.org>
13472
979022ef
EZ
13473 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
13474 position we get to after a call to move_it_to fails the
13475 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
13476 only if we wind up in a string from display property. (Bug#11063)
13477
a6b1c7cc
EZ
13478 * window.c (Fdelete_other_windows_internal): Invalidate the row
13479 and column information about mouse highlight, so that redisplay
13480 restores it after reallocating the glyph matrices. (Bug#7464)
13481
8427ddd2
EZ
13482 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
13483 string comes from a `display' text property, use the buffer
13484 position of that property as if we actually saw that position in
13485 the row's glyphs.
697ba24b
EZ
13486 (move_it_by_lines): Remove the assertion that
13487 "it->current_x == 0 && it->hpos == 0" which can be legitimately
13488 violated when there's a before-string at the beginning of a line.
13489 (Bug#11063)
8427ddd2 13490
65a0a738
EZ
134912012-03-30 Eli Zaretskii <eliz@gnu.org>
13492
13493 * xdisp.c (append_space_for_newline): If the default face was
13494 remapped, use the remapped face for the appended newline.
13495 (extend_face_to_end_of_line): Use the remapped default face for
13496 extending the face to the end of the line.
13497 (display_line): Call extend_face_to_end_of_line when the default
13498 face was remapped. (Bug#11068)
13499
581355cc
EZ
135002012-03-29 Eli Zaretskii <eliz@gnu.org>
13501
13502 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
13503
e8fc049f
SM
135042012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13505
13506 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
13507
4fb9a543
GM
135082012-03-27 Glenn Morris <rgm@gnu.org>
13509
13510 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
13511 Doc fixes.
13512
679910f1
KH
135132012-03-26 Kenichi Handa <handa@m17n.org>
13514
13515 * dispextern.h (struct glyph): Fix previous change. Change the
13516 bit length of glyphless.ch to 25 (Bug#11082).
13517
90d49b7f
CY
135182012-03-26 Chong Yidong <cyd@gnu.org>
13519
13520 * keyboard.c (Vselection_inhibit_update_commands): New variable.
13521 (command_loop_1): Use it; inhibit selection update for
13522 handle-select-window too (Bug#8996).
13523
f514f6f0
FP
135242012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
13525
e8fc049f 13526 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 13527
bf43fa51
KH
135282012-03-25 Kenichi Handa <handa@m17n.org>
13529
13530 * dispextern.h (struct glyph): Change the bit length of
13531 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
13532
8a0c01dd
EZ
135332012-03-24 Eli Zaretskii <eliz@gnu.org>
13534
13535 * s/ms-w32.h (tzname): Include time.h before redirecting to
13536 _tzname. Fixes the MSVC build. (Bug#9960)
13537
7d1c3a76
AS
135382012-03-24 Andreas Schwab <schwab@linux-m68k.org>
13539
8ed79523
AS
13540 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
13541 characters.
13542
7d1c3a76
AS
13543 * xterm.c (XTread_socket): Only modify handling_signal if
13544 !SYNC_INPUT. (Bug#11080)
13545
e99a9b8b
EZ
135462012-03-23 Eli Zaretskii <eliz@gnu.org>
13547
13548 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
13549 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
13550 when fetching a multibyte character consumes more bytes than
13551 CHAR_BYTES returns, due to unification of CJK characters in
13552 string_char. (Bug#11073)
13553
5063c0e1
TN
135542012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
13555
13556 * process.c (wait_reading_process_output): Handle pty disconnect
13557 by refraining from sending oneself a SIGCHLD (bug#10933).
13558
9f851fbd
CY
135592012-03-22 Chong Yidong <cyd@gnu.org>
13560
13561 * dispextern.h (struct it): New member string_from_prefix_prop_p.
13562
5063c0e1 13563 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
13564 Mark string as coming from a prefix property.
13565 (handle_face_prop): Use default face for prefix strings (Bug#4281).
13566 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
13567
fb5b8aca
CY
135682012-03-21 Chong Yidong <cyd@gnu.org>
13569
13570 * xfaces.c (Vface_remapping_alist): Doc fix.
13571
62356a1b
EZ
135722012-03-20 Eli Zaretskii <eliz@gnu.org>
13573
13574 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
13575 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
13576 Doc fixes.
62356a1b 13577
025de85b
CY
135782012-03-20 Chong Yidong <cyd@gnu.org>
13579
13580 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
13581 to reflect default non-nil value of redisplay-dont-pause.
13582
4827f94e
KH
135832012-03-19 Kenichi Handa <handa@m17n.org>
13584
13585 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
13586 it fit in a valid range (Bug#11003).
13587
e50a24a2
EZ
135882012-03-18 Eli Zaretskii <eliz@gnu.org>
13589
13590 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
13591 that is not from display property, accept the row as a "cursor
13592 row" if one of the string's character has a non-nil `cursor'
13593 property. Fixes cursor positioning when there are newlines in
13594 overlay strings, e.g. in icomplete.el. (Bug#11035)
13595
9af5ed87
PE
135962012-03-12 Paul Eggert <eggert@cs.ucla.edu>
13597
13598 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
13599
d1f55f16
CY
136002012-03-12 Chong Yidong <cyd@gnu.org>
13601
13602 * eval.c (inhibit_lisp_code): Rename from
13603 inhibit_window_configuration_change_hook; move from window.c.
13604
13605 * xfns.c (unwind_create_frame_1, Fx_create_frame):
13606 * window.c (run_window_configuration_change_hook)
13607 (syms_of_window): Callers changed.
13608
66c5eebd
CY
136092012-03-11 Chong Yidong <cyd@gnu.org>
13610
413df973
CY
13611 * keymap.c (Fkey_description): Doc fix (Bug#9700).
13612
66c5eebd
CY
13613 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
13614
1de11f56
CY
136152012-03-10 Chong Yidong <cyd@gnu.org>
13616
13617 * frame.c (other_visible_frames): Don't assume the selected frame
13618 is visible (Bug#10955).
13619
cae07000
SM
136202012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
13621
13622 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
13623
89c94350
JD
136242012-03-08 Jan Djärv <jan.h.d@swipnet.se>
13625
13626 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
13627 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
13628 zero (Bug#10954).
13629
999dd333
GM
136302012-03-03 Glenn Morris <rgm@gnu.org>
13631
01a6dcc8 13632 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 13633
de0100f2
EZ
136342012-03-02 Eli Zaretskii <eliz@gnu.org>
13635
13636 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
13637 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
13638 (redisplay_window, next_element_from_string): Fix typos in
13639 comments.
3e441275
EZ
13640 (redisplay_window): Pass to move_it_vertically the margin in
13641 pixels, not in screen lines.
de0100f2 13642
96a72ee9
GM
136432012-03-02 Glenn Morris <rgm@gnu.org>
13644
13645 * buffer.c (buffer-list-update-hook): Doc fix.
13646
312508d7
EZ
136472012-02-29 Eli Zaretskii <eliz@gnu.org>
13648
13649 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
13650 push_it before setting up the iterator for the first overlay
13651 string, even if we have an empty string loaded.
13652 (next_overlay_string): If there's an empty string on the iterator
13653 stack, pop the stack. (Bug#10903)
13654
27f3c637
PE
136552012-02-25 Paul Eggert <eggert@cs.ucla.edu>
13656
13657 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
13658 Suggested by Stefan Monnier in
13659 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
13660 * alloc.c (widen_to_Lisp_Object): New static function.
13661 (mark_memory): Also mark Lisp_Objects by fetching pointer words
13662 and widening them to Lisp_Objects. This would work even if
13663 USE_LSB_TAG is defined and wide integers are used, which might
13664 happen in a future version of Emacs.
13665
3c9dfce6
CY
136662012-02-25 Chong Yidong <cyd@gnu.org>
13667
fa74b241
CY
13668 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
13669 Doc fix.
13670
3c9dfce6
CY
13671 * xselect.c (Fx_selection_exists_p): Doc fix.
13672 (x_clipboard_manager_save_all): Print an informative message
13673 before saving to clipboard manager.
13674
9486df08
CY
136752012-02-24 Chong Yidong <cyd@gnu.org>
13676
13677 * keyboard.c (process_special_events): Handle all X selection
13678 requests in kbd_buffer, not just the next one (Bug#8869).
13679
f01d3321
CY
136802012-02-23 Chong Yidong <cyd@gnu.org>
13681
13682 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
13683 call when setting menu-bar-lines and tool-bar-lines parameters.
13684 (unwind_create_frame_1): New helper function.
13685
13686 * window.c (inhibit_window_configuration_change_hook): New var.
13687 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 13688 (syms_of_window): Initialize it.
f01d3321 13689
86b847b6
CY
136902012-02-22 Chong Yidong <cyd@gnu.org>
13691
13692 * xterm.c (x_draw_image_relief): Add missing type check for
13693 Vtool_bar_button_margin (Bug#10743).
13694
a59225b1
CY
136952012-02-21 Chong Yidong <cyd@gnu.org>
13696
13697 * fileio.c (Vfile_name_handler_alist): Doc fix.
13698
13699 * buffer.c (Fget_file_buffer): Protect against invalid file
13700 handler return value.
13701
310f5bd4
PE
137022012-02-20 Paul Eggert <eggert@cs.ucla.edu>
13703
cb3a28cc
PE
13704 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
13705 when computing $valmask.
13706
310f5bd4
PE
13707 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
13708 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
13709 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
13710 It's useless in that case, and it can cause problems on hosts
13711 that allocate halves of EMACS_INT values separately.
13712 Reported by Dan Horák. Diagnosed by Andreas Schwab in
13713 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
13714 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
13715 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
13716 it avoids undefined behavior on hosts where shifting right by more
13717 than the word width has undefined behavior.
13718
2375c96a
CY
137192012-02-19 Chong Yidong <cyd@gnu.org>
13720
13721 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
13722 (Funhandled_file_name_directory, Ffile_name_as_directory)
13723 (Fdirectory_file_name, Fexpand_file_name)
13724 (Fsubstitute_in_file_name): Protect against invalid file handler
13725 return values (Bug#10845).
13726
3eb49e71
EZ
137272012-02-18 Eli Zaretskii <eliz@gnu.org>
13728
13729 * .gdbinit (pitx): Fix incorrect references to fields of the
13730 iterator stack.
13731
7b926f3f
CY
137322012-02-17 Chong Yidong <cyd@gnu.org>
13733
13734 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
13735
11273115
PE
137362012-02-15 Paul Eggert <eggert@cs.ucla.edu>
13737
13738 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
13739 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
13740
c3a70e2b
CY
137412012-02-15 Chong Yidong <cyd@gnu.org>
13742
13743 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
13744 marked as special. Also, starting docstrings with * is obsolete.
13745
0ca43699
AS
137462012-02-13 Andreas Schwab <schwab@linux-m68k.org>
13747
13748 * gnutls.c (emacs_gnutls_write): Fix last change.
13749
2e8f3c56
LI
137502012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
13751
13752 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
13753 send_process.
13754
af70074f
SM
137552012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
13756
13757 * keymap.c (Fsingle_key_description): Handle char ranges.
13758
95986d52
CY
137592012-02-12 Chong Yidong <cyd@gnu.org>
13760
afd83bd1
CY
13761 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
13762 as that creates a dangerous corner case.
13763
95986d52
CY
13764 * window.c (Fdelete_window_internal): Invalidate the mouse
13765 highlight (Bug#9904).
13766
bd7da63e
GM
137672012-02-12 Glenn Morris <rgm@gnu.org>
13768
13769 * xselect.c (Fx_own_selection_internal)
13770 (Fx_get_selection_internal, Fx_disown_selection_internal)
13771 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
13772 * nsselect.m (Fx_own_selection_internal)
13773 (Fx_disown_selection_internal, Fx_selection_exists_p)
13774 (Fx_selection_owner_p, Fx_get_selection_internal):
13775 Sync docs and argument specs with the xselect.c versions.
13776
77abcbc2
LI
137772012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
13778
13779 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
13780
90b671e2
EZ
137812012-02-11 Eli Zaretskii <eliz@gnu.org>
13782
1c0ca0b7
EZ
13783 * w32select.c (Fx_selection_exists_p): Sync doc string and
13784 argument list with xselect.c. (Bug#10783)
13785
13786 * w16select.c (Fx_selection_exists_p): Sync doc string and
13787 argument list with xselect.c. (Bug#10783)
90b671e2 13788
49241268
GM
137892012-02-10 Glenn Morris <rgm@gnu.org>
13790
13791 * fns.c (Fsecure_hash): Doc fix.
13792
f998bbe7 137932012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
13794
13795 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
13796
0992bd9c
CY
137972012-02-07 Chong Yidong <cyd@gnu.org>
13798
13799 * buffer.c (Fbuffer_local_variables)
13800 (buffer_lisp_local_variables): Handle unbound vars correctly;
13801 don't let Qunbound leak into Lisp.
13802
af008560
GM
138032012-02-07 Glenn Morris <rgm@gnu.org>
13804
dd605cc4
GM
13805 * image.c (Fimagemagick_types): Doc fix.
13806
af008560
GM
13807 * image.c (imagemagick-render-type): Change it from a lisp object
13808 to an integer. Move the doc here from the lisp manual.
13809 Treat all values not equal to 0 the same.
13810
1449fa1d
CY
138112012-02-06 Chong Yidong <cyd@gnu.org>
13812
13813 * doc.c (store_function_docstring): Avoid applying docstring of
13814 alias to base function (Bug#2603).
13815
3723ec07
AS
138162012-02-04 Andreas Schwab <schwab@linux-m68k.org>
13817
13818 * .gdbinit (pp1, pv1): Remove redundant defines.
13819 (pr): Use pp.
13820
79c1cc1e
CY
138212012-02-04 Chong Yidong <cyd@gnu.org>
13822
13823 * nsterm.m: Declare a global (Bug#10694).
13824
d7f29f8e
EZ
138252012-02-04 Eli Zaretskii <eliz@gnu.org>
13826
cae07000
SM
13827 * w32.c (get_emacs_configuration_options):
13828 Include --enable-checking, if specified, in the return value.
d7f29f8e 13829
3b95a6f9
MR
138302012-02-04 Martin Rudalics <rudalics@gmx.at>
13831
13832 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
13833 after rounding frame sizes. (Bug#9723)
13834
d6fa96a6
EZ
138352012-02-04 Eli Zaretskii <eliz@gnu.org>
13836
13837 * keyboard.c (adjust_point_for_property): Don't position point
13838 before BEGV. (Bug#10696)
13839
df0b2940
PE
138402012-02-03 Paul Eggert <eggert@cs.ucla.edu>
13841
13842 Handle overflow when computing char display width (Bug#9496).
13843 * character.c (char_width): Return EMACS_INT, not int.
13844 (char_width, c_string_width): Check for overflow when
13845 computing the width; this is possible now that individual
13846 characters can have unbounded width. Problem introduced
13847 by merge from Emacs 23 on 2012-01-19.
13848
6bee44d6
MA
138492012-02-02 Michael Albinus <michael.albinus@gmx.de>
13850
13851 * dbusbind.c (Fdbus_register_method): Mention the return value
13852 :ignore in the docstring.
13853
44f92739
GM
138542012-02-02 Glenn Morris <rgm@gnu.org>
13855
1b9f60cc
GM
13856 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
13857
44f92739
GM
13858 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
13859 Unconditionally set to t. (Bug#10673)
13860 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
13861 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
13862 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
13863
c5d3843c
KH
138642012-02-02 Kenichi Handa <handa@m17n.org>
13865
13866 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
13867 0, do not call append_composite_glyph.
13868
159462d4 138692012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
13870
13871 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
13872 NULL (Bug#6988).
13873 (x_produce_glyphs): If the component of a composition is a null
13874 string, set it->pixel_width to 1 to avoid zero-width glyph.
13875
78cef877
EZ
138762012-02-01 Eli Zaretskii <eliz@gnu.org>
13877
13878 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
13879 first 2 arguments are identical. This makes inserting large
13880 output from a subprocess an order of magnitude faster on
13881 MS-Windows, where all sbrk'ed memory is always contiguous.
13882
97897668
GM
138832012-01-31 Glenn Morris <rgm@gnu.org>
13884
13885 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 13886 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
13887 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
13888
31fd3586
GM
138892012-01-29 Glenn Morris <rgm@gnu.org>
13890
13891 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
13892
0e24a8b2
CY
138932012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
13894
13895 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
13896
cc0adcb0
CY
138972012-01-28 Chong Yidong <cyd@gnu.org>
13898
13899 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
13900
acc28cb9
CY
139012012-01-26 Chong Yidong <cyd@gnu.org>
13902
9c69cfb7
CY
13903 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
13904
acc28cb9
CY
13905 * search.c (Fsearch_forward, Fsearch_backward): Document negative
13906 repeat counts (Bug#10507).
13907
48da7392
GM
139082012-01-26 Glenn Morris <rgm@gnu.org>
13909
13910 * lread.c (syms_of_lread): Doc fix.
13911
14af5f7f
CY
139122012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
13913
13914 * coding.c (encode_designation_at_bol): Change return value to
13915 EMACS_INT.
13916
0b21c100
CY
139172012-01-25 Chong Yidong <cyd@gnu.org>
13918
13919 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
13920
3c2907f7
CY
139212012-01-21 Chong Yidong <cyd@gnu.org>
13922
13923 * floatfns.c (Fcopysign): Make the second argument non-optional,
13924 since nil is not allowed anyway.
13925
959ad23f
AS
139262012-01-21 Andreas Schwab <schwab@linux-m68k.org>
13927
13928 * process.c (read_process_output): Use p instead of XPROCESS (proc).
13929 (send_process): Likewise.
13930
34a02f46
MR
139312012-01-19 Martin Rudalics <rudalics@gmx.at>
13932
13933 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
13934 (Vwindow_persistent_parameters): Do not use Qstate.
13935 Rewrite doc-strings.
34a02f46 13936
1259009a 139372012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
13938
13939 * character.c (char_width): New function.
70d4fdf6
GM
13940 (Fchar_width, c_string_width, lisp_string_width):
13941 Use char_width (Bug#9496).
25ed9e61 13942
6a6ee00d
MR
139432012-01-16 Martin Rudalics <rudalics@gmx.at>
13944
13945 * window.c (Vwindow_persistent_parameters): New variable.
13946 (Fset_window_configuration, save_window_save): Handle persistent
13947 window parameters.
13948
c85efaf7
EZ
139492012-01-14 Eli Zaretskii <eliz@gnu.org>
13950
13951 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
13952 thrashing the stack of the thread. (Bug#9087)
13953
5944709e
PE
139542012-01-12 Paul Eggert <eggert@cs.ucla.edu>
13955
13956 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
13957
e71f5d99
EZ
139582012-01-11 Eli Zaretskii <eliz@gnu.org>
13959
13960 * xdisp.c (rows_from_pos_range): Handle the case where the
13961 highlight ends on a newline. (Bug#10464)
13962 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
13963 he end column for display of highlight that ends on a newline
13964 before a R2L line.
13965
ce316182
GM
139662012-01-11 Glenn Morris <rgm@gnu.org>
13967
13968 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
13969 from load-path also when installation-directory is nil. (Bug#10208)
13970
5b43da69
GM
139712012-01-10 Glenn Morris <rgm@gnu.org>
13972
74cc8ff9
GM
13973 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
13974
7d8d6e4e
GM
13975 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
13976 Update template values to be closer to their typical values these days.
5b43da69 13977
a0db8d43
EZ
139782012-01-09 Eli Zaretskii <eliz@gnu.org>
13979
13980 * xdisp.c (rows_from_pos_range): Accept additional argument
13981 DISP_STRING, and accept any glyph in a row whose object is that
13982 string as eligible for mouse highlight. Fixes mouse highlight of
13983 display strings from overlays. (Bug#10464)
13984
9a0115ab 139852012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 13986
b9110d6a 13987 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
13988 * fileio.c (auto_saving_dir_umask): New static var.
13989 (Fmake_directory_internal): Use it.
13990 (do_auto_save_make_dir): Set it, instead of invoking chmod after
13991 creating the directory. The old code temporarily assigns
13992 too-generous permissions to the directory.
13993 (do_auto_save_eh): Clear it.
b9110d6a 13994 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
13995 that the var is always cleared.
13996
6c1bd3f3
EZ
139972012-01-07 Eli Zaretskii <eliz@gnu.org>
13998
13999 * search.c (scan_buffer): Pass character positions to
14000 know_region_cache, not byte positions. (Bug#6540)
14001
069d2b50
L
140022012-01-07 LynX <_LynX@bk.ru> (tiny change)
14003
14004 * w32.c (sys_rename): Report EXDEV when rename of a directory
14005 fails because the target is on another logical disk. (Bug#10284)
14006
75bf0d33
DB
140072012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
14008
14009 * xterm.c (x_embed_request_focus): New function.
14010
14011 * xterm.h: Add prototype.
14012
14013 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
14014
1c6e5a32
GM
140152012-01-05 Glenn Morris <rgm@gnu.org>
14016
14017 * emacs.c (emacs_copyright): Update short copyright year to 2012.
14018
651e947e
EZ
140192012-01-01 Eli Zaretskii <eliz@gnu.org>
14020
14021 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
14022 Load gnutls_transport_set_lowat only if GnuTLS version is below
14023 2.11.1.
14024 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
14025 GnuTLS versions below 2.11.1.
14026
3778cdd8
AL
140272011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
14028
14029 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
14030 to the doc string advising against its use for altering the way
14031 windows are scrolled.
14032
0e5317f7
KH
140332011-12-28 Kenichi Handa <handa@m17n.org>
14034
14035 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
14036 coding-system ASCII compatible only when it does not produce BOM
14037 on encoding (Bug#10383).
14038
93d5ca1f
JD
140392011-12-26 Jan Djärv <jan.h.d@swipnet.se>
14040
14041 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
14042 can scroll.
14043 (create_and_show_popup_menu): Always use menu_position_func for
14044 Gtk3 (Bug#10361).
14045
ca22b785
AS
140462011-12-24 Andreas Schwab <schwab@linux-m68k.org>
14047
14048 * callint.c (Fcall_interactively): Don't truncate prompt string.
14049
d048e1e6
EZ
140502011-12-23 Eli Zaretskii <eliz@gnu.org>
14051
14052 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
14053 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 14054 resumed from there (after widening). (Bug#10360)
d048e1e6 14055
5ccaba1f
JD
140562011-12-22 Jan Djärv <jan.h.d@swipnet.se>
14057
14058 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
14059
204ee57f
JD
140602011-12-21 Jan Djärv <jan.h.d@swipnet.se>
14061
b81d40f0
JB
14062 * nsterm.m (x_free_frame_resources):
14063 Release f->output_data.ns->miniimage.
204ee57f
JD
14064 (ns_index_color): Fix indentation. Do not retain
14065 color_table->colors[i].
14066
14067 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
14068 before returning.
14069
14070 * nsfns.m (x_set_background_color): Assign return value from
14071 ns_index_color to face-background instead of NSColor*.
14072 (ns_implicitly_set_icon_type): Fix indentation.
14073 Change assignment in for loop to comparison.
14074
14075 * emacs.c (ns_pool): New variable.
14076 (main): Assign ns_pool.
14077 (Fkill_emacs): Call ns_release_autorelease_pool.
14078
14079 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
14080 autorelease fdesc, release fdAttrs and tdict.
14081 (ns_get_covering_families): Release charset.
14082 (ns_findfonts): Release NSFontDescriptor created with new.
14083 (ns_uni_to_glyphs): Fix indentation.
14084 (setString): Release attrStr before assigning new value.
14085
c803b2b7
JD
140862011-12-18 Jan Djärv <jan.h.d@swipnet.se>
14087
678f4426
JD
14088 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
14089 and NS_IMPL_COCOA.
14090 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
14091 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
14092
cd394be1 140932011-12-18 David Reitter <reitter@cmu.edu>
678f4426 14094
5fecd5fc
JD
14095 * nsterm.m (ns_term_init): Subscribe for notifications
14096 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
14097 to method trackingNotification in EmacsMenu.
14098
14099 * nsmenu.m (trackingMenu): New variable.
3771cb17 14100 (trackingNotification): New method (from Aquamacs).
5fecd5fc 14101 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 14102 from Aquamacs (Bug#7030).
678f4426
JD
14103
141042011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 14105
c803b2b7
JD
14106 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
14107 (symbol_to_nsstring): Fix indentation.
14108 (ns_symbol_to_pb): New function.
cae07000
SM
14109 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
14110 (Fns_rotate_cut_buffers_internal): Remove.
14111 (Fns_store_selection_internal): Rename from
c803b2b7
JD
14112 Fns_store_cut_buffer_internal.
14113 (ns_get_foreign_selection, Fx_own_selection_internal)
14114 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
14115 (Fns_get_selection_internal, Fns_store_selection_internal):
14116 Use ns_symbol_to_pb and check if return value is nil.
14117 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
14118 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
14119 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
14120 renamed to Sns_store_selection_internal.
14121 (ns_handle_selection_request): Move code to Fx_own_selection_internal
14122 and remove this function.
14123 (ns_handle_selection_clear): Remove, never used.
14124 (Fx_own_selection_internal): Move code from ns_handle_selection_request
14125 here.
14126
e1b01a3a
KB
141272011-12-17 Ken Brown <kbrown@cornell.edu>
14128
14129 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
14130 GID is unknown (Bug#10257).
14131
2adb6e85
PE
141322011-12-17 Paul Eggert <eggert@cs.ucla.edu>
14133
14134 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
14135 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
14136 which caused a build failure on GNU/Linux IA-64. This problem was
14137 introduced by my 2011-10-07 patch.
14138
d1d7b339
JL
141392011-12-15 Juri Linkov <juri@jurta.org>
14140
14141 * image.c (imagemagick_error): New function. (Bug#10112)
14142 (imagemagick_load_image): Comment out `MagickSetResolution' call.
14143 Use `imagemagick_error' where ImageMagick functions return
14144 `MagickFalse'.
14145 (Fimagemagick_types): Add `Fnreverse' to return the list in the
14146 proper order.
14147
100d5755
KH
141482011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14149
14150 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
14151 fill background (Bug#8992).
14152
454592a6
MR
141532011-12-13 Martin Rudalics <rudalics@gmx.at>
14154
14155 * window.c (Vwindow_combination_resize)
14156 (Vwindow_combination_limit): Use t instead of non-nil in
14157 doc-strings.
61d4b438
MR
14158 (Vrecenter_redisplay): Add first sentence of doc-string on
14159 separate line.
53524d93 14160 (Frecenter): Fix doc-string typo.
454592a6 14161
3633e3aa
KH
141622011-12-11 Kenichi Handa <handa@m17n.org>
14163
14164 * coding.c (Funencodable_char_position): Pay attention to the
14165 buffer text relocation (Bug#9389).
14166
7b9d523a 141672011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 14168
7b9d523a
JD
14169 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
14170 gtk_init (Bug#10100).
14171
b73189c6
EZ
141722011-12-10 Eli Zaretskii <eliz@gnu.org>
14173
14174 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
14175 IT->string is nil. (Bug#10263)
14176
f7dfe5d6
JD
141772011-12-10 Jan Djärv <jan.h.d@swipnet.se>
14178
83faebb4
JD
14179 * nsterm.h (x_free_frame_resources): Declare.
14180
f7dfe5d6
JD
14181 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
14182 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
14183
14184 * nsterm.h (ns_get_defaults_value): Declare.
14185
14186 * nsterm.m (ns_default): Call ns_get_defaults_value.
14187
7cd4e72c
EZ
141882011-12-09 Eli Zaretskii <eliz@gnu.org>
14189
14190 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
14191 (Bug#10170)
14192
b34d7317
YM
141932011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14194
14195 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
14196 that where the value of an _OBJC_* symbol points to is in the .bss
14197 section (Bug#10240).
14198
76470ad1
KH
141992011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
14200
14201 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 14202 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 14203
745fff94
KH
142042011-12-08 Kenichi Handa <handa@m17n.org>
14205
14206 * ftfont.c (get_adstyle_property): Fix previous change
14207 (Bug#10233).
14208
6e44397c
JB
142092011-12-07 Juanma Barranquero <lekktu@gmail.com>
14210
14211 * w32.c (init_environment): If no_site_lisp, remove site-lisp
14212 dirs from the default value of EMACSLOADPATH (bug#10208).
14213
7efa6272
GM
142142011-12-07 Glenn Morris <rgm@gnu.org>
14215
14216 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
14217 installation and source directories as well. (Bug#10208)
14218
f6fc4d87
CY
142192011-12-06 Chong Yidong <cyd@gnu.org>
14220
14221 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
14222
2bf26180
GM
142232011-12-06 Glenn Morris <rgm@gnu.org>
14224
14225 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
14226 as an error, not just -1. (Bug#10217)
14227
3a6ad4f0
CY
142282011-12-05 Chong Yidong <cyd@gnu.org>
14229
14230 * keyboard.c (process_special_events): New function.
14231 (swallow_events, Finput_pending_p): Use it (Bug#10195).
14232
75a3b399
PE
142332011-12-05 Paul Eggert <eggert@cs.ucla.edu>
14234
14235 * coding.c (encode_designation_at_bol): Don't use uninitialized
14236 local variable (Bug#9318).
14237
c3c9e25e
KH
142382011-12-05 Kenichi Handa <handa@m17n.org>
14239
14240 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
14241 return Qnil (Bug#8046, Bug#10193).
14242
5eb05ea3
KH
142432011-12-05 Kenichi Handa <handa@m17n.org>
14244
14245 * coding.c (encode_designation_at_bol): New args charbuf_end and
14246 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
14247 (coding_set_source): Return how many bytes coding->source was
14248 relocated.
14249 (coding_set_destination): Return how many bytes
14250 coding->destination was relocated.
14251 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 14252 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
14253
142542011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
14255
14256 * coding.c (CODING_CHAR_CHARSET_P): New macro.
14257 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
14258 macro (Bug#9318).
14259
142602011-12-05 Andreas Schwab <schwab@linux-m68k.org>
14261
14262 The following changes are to fix Bug#9318.
14263
a79703f5 14264 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
14265 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
14266 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 14267 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 14268
7dbda6df
JB
142692011-12-05 Juanma Barranquero <lekktu@gmail.com>
14270
14271 * lisp.h (process_quit_flag): Fix external declaration.
14272
6d5eb5b0
SM
142732011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
14274
14275 Don't macro-inline non-performance-critical code.
14276 * eval.c (process_quit_flag): New function.
14277 * lisp.h (QUIT): Use it.
14278
a0c3fad0
JD
142792011-12-04 Jan Djärv <jan.h.d@swipnet.se>
14280
14281 * nsfns.m (get_geometry_from_preferences): New function.
14282 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
14283
6c07aac2
AS
142842011-12-04 Andreas Schwab <schwab@linux-m68k.org>
14285
14286 * emacs.c (Qkill_emacs): Define.
14287 (syms_of_emacs): Initialize it.
14288 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
14289 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
14290 (quit_throw_to_read_char): Add parameter `from_signal'.
14291 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
14292 * lisp.h (QUIT): Call Fkill_emacs if requested.
14293
c052ead4
JD
142942011-12-03 Jan Djärv <jan.h.d@swipnet.se>
14295
14296 * widget.c (update_wm_hints): Return if wmshell is null.
14297 (widget_update_wm_size_hints): New function.
14298
14299 * widget.h (widget_update_wm_size_hints): Declare.
14300
14301 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
14302 widget_update_wm_size_hints (Bug#10104).
14303
9e49252b
EZ
143042011-12-03 Eli Zaretskii <eliz@gnu.org>
14305
14306 * xdisp.c (handle_invisible_prop): If the invisible text ends just
14307 before a newline, prepare the bidi iterator for consuming the
14308 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 14309 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 14310
02b16839
JL
143112011-12-02 Juri Linkov <juri@jurta.org>
14312
14313 * search.c (Fword_search_regexp): New Lisp function created from
14314 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
14315 (Fword_search_backward, Fword_search_forward)
14316 (Fword_search_backward_lax, Fword_search_forward_lax):
14317 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
14318 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
14319
0068070e
SM
143202011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
14321
14322 * fileio.c (Finsert_file_contents): Move after-change-function call
14323 to before the "handled:" label, since all "goto handled" appear in
14324 cases where the *-change-functions have already been properly called
14325 (bug#10117).
14326
3360a3fc
AS
143272011-12-01 Andreas Schwab <schwab@linux-m68k.org>
14328
14329 * keyboard.c (interrupt_signal): Don't call kill-emacs when
14330 waiting for input. (Bug#10169)
14331
73d6c093
EZ
143322011-11-30 Eli Zaretskii <eliz@gnu.org>
14333
14334 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
14335 verifies glyph row's hash code--we have just reallocated the
14336 glyphs, so their contents can be complete garbage. (Bug#10164)
14337
febe6bea
JB
143382011-11-30 Juanma Barranquero <lekktu@gmail.com>
14339
14340 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
14341
801a4313
EZ
143422011-11-30 Eli Zaretskii <eliz@gnu.org>
14343
14344 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
14345 attributes are tested _before_ calling verify_row_hash, to protect
14346 against GCC re-ordering of the tests. (Bug#10164)
14347
2b56b87e
JD
143482011-11-29 Jan Djärv <jan.h.d@swipnet.se>
14349
14350 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
14351
14352 * xterm.c (handle_one_xevent): Only set async_visible and friends
14353 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 14354 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
14355 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
14356
dbf31225
PE
143572011-11-28 Paul Eggert <eggert@cs.ucla.edu>
14358
14359 Remove GCPRO-related macros that exist only to avoid shadowing locals.
14360 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
14361 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
14362 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
14363 All uses changed to use GCPRO1 etc.
14364 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
14365 Revert to old implementation (i.e., before 2011-03-11).
14366
1305621b
YM
143672011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14368
14369 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
14370 of scroll runs so as to avoid assigning disabled bogus rows and
14371 unnecessary graphics copy operations.
14372
8c9afb46
EZ
143732011-11-27 Eli Zaretskii <eliz@gnu.org>
14374
14375 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
14376 (snprintf) [_MSC_VER]: Redirect to _snprintf.
14377 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
14378 (malloc, free, realloc, calloc): Redirect to e_* only when
14379 compiling Emacs.
14380
14381 * lisp.h (GCTYPEBITS): Move before first use.
14382 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
14383 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
14384 this macro definition.
14385
14386 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
14387 _MSC_VER.
14388
54e9e3bf
JD
143892011-11-27 Jan Djärv <jan.h.d@swipnet.se>
14390
6d5eb5b0
SM
14391 * gtkutil.c (xg_create_frame_widgets):
14392 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
14393 present with Gtk+ 2.0.
14394
83aca1cb
PE
143952011-11-26 Paul Eggert <eggert@cs.ucla.edu>
14396
14397 * fileio.c (Finsert_file_contents): Undo previous change; see
14398 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
14399
5b76caa4
PE
144002011-11-26 Paul Eggert <eggert@cs.ucla.edu>
14401
14402 Rename locals to avoid shadowing.
14403 * fileio.c (Finsert_file_contents):
14404 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
14405 * process.c (wait_reading_process_output):
14406 Rename inner 'proc' to 'p' to avoid shadowing.
14407 Indent for consistency with usual Emacs style.
14408
8c535114
EZ
144092011-11-25 Eli Zaretskii <eliz@gnu.org>
14410
14411 * xdisp.c (redisplay_window): If cursor row is not fully visible
14412 after recentering, and scroll-conservatively is set to a large
14413 number, scroll window by a few more lines to make the cursor fully
14414 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
14415 (start_display): Don't move to the next line if the display should
14416 start at a newline that is part of a display vector or an overlay
14417 string. (Bug#10119)
8c535114 14418
fa4fdb5c
JL
144192011-11-24 Juri Linkov <juri@jurta.org>
14420
14421 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
14422 after the `MagickPingImage' call. (Bug#10112)
14423
90ec88df
CY
144242011-11-23 Chong Yidong <cyd@gnu.org>
14425
14426 * window.c (Fcoordinates_in_window_p): Accept only live windows.
14427
56e2e794
MR
144282011-11-23 Martin Rudalics <rudalics@gmx.at>
14429
14430 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
14431 making another buffer current. (Bug#10114)
14432
b6e64c41
GM
144332011-11-23 Glenn Morris <rgm@gnu.org>
14434
14435 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
14436
6b21de18
CY
144372011-11-23 Chong Yidong <cyd@gnu.org>
14438
14439 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
14440 using it (Bug#5984).
14441
b12cd789
EZ
144422011-11-22 Eli Zaretskii <eliz@gnu.org>
14443
14444 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
14445 and header-lines, as they don't have one computed for them.
14446 (Bug#10098)
14447
14448 * .gdbinit (prow): Make displayed values more self-explaining.
14449 Add row's hash code.
14450
261b6fd4
LMI
144512011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
14452
14453 * process.c (wait_reading_process_output): Fix asynchrounous
14454 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 14455 (wait_reading_process_output): Add comment and URL.
261b6fd4 14456
e7cfd277
JD
144572011-11-21 Jan Djärv <jan.h.d@swipnet.se>
14458
14459 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
14460
a9b9b7f5
CY
144612011-11-21 Chong Yidong <cyd@gnu.org>
14462
14463 * window.c (Fnext_window, Fprevious_window): Doc fix.
14464
b0d15b4f
SM
144652011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
14466
14467 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
14468
fe7a3057
JB
144692011-11-20 Juanma Barranquero <lekktu@gmail.com>
14470
14471 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
14472
d2999b1a
MR
144732011-11-20 Martin Rudalics <rudalics@gmx.at>
14474
14475 * window.c (Fset_window_combination_limit): Rename argument
14476 STATUS to LIMIT.
14477 (Vwindow_combination_limit): Remove "status" from doc-string.
14478
d5ff9cd0
AS
144792011-11-20 Andreas Schwab <schwab@linux-m68k.org>
14480
14481 * m/ibms390.h: Remove.
14482 * m/ibms390x.h: Don't include "ibms390.h".
14483
a5bb9bd3
SM
144842011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
14485
14486 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
14487 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
14488
cd1181db
JB
144892011-11-20 Juanma Barranquero <lekktu@gmail.com>
14490
14491 * casetab.c (Fset_case_table):
14492 * charset.c (Fcharset_after): Fix typos.
14493
615a3b8d 144942011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 14495
17e845af
PE
14496 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
14497 Otherwise, valgrind does not work on some platforms.
14498 Problem reported by Andreas Schwab in
6a0bf43d
PE
14499 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
14500 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
14501 is set, removing the need for VIRT_ADDRESS_VARIES.
14502 (PURE_P): Use a more-efficient implementation that needs just one
14503 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
14504 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
14505 to 4 (xorl, subq, cmpq, setbe).
14506 * alloc.c (pure): Always extern now, since that's the
14507 VIRT_ADDR_VARIES behavior.
14508 (PURE_POINTER_P): Use a single comparison, not two, for
14509 consistency with the new puresize.h.
14510 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
14511 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
14512 Remove VIRT_ADDR_VARIES no longer needed.
14513
f8fe6f96
EZ
145142011-11-19 Eli Zaretskii <eliz@gnu.org>
14515
14516 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
14517 (erase_phys_cursor, update_window_cursor, show_mouse_face)
14518 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
14519 behave as if the cursor position were at the window margin.
14520
14521 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
14522 and the cursor position is out of bounds, behave as if the cursor
14523 position were at the window margin. (Bug#10075)
14524
df05a53c
CY
145252011-11-18 Chong Yidong <cyd@gnu.org>
14526
14527 * window.c (Fwindow_combination_limit): Make first argument
14528 non-optional, since it is meaningless for live windows like the
14529 selected window.
61ccba97 14530
2071918e
DA
145312011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
14532
14533 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
14534
b50a28de
SM
145352011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
14536
14537 * intervals.c: Fix grafting over the whole buffer (bug#10071).
14538 (graft_intervals_into_buffer): Simplify.
14539
015137db
EZ
145402011-11-18 Eli Zaretskii <eliz@gnu.org>
14541
14542 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
14543 hash values of the two rows.
14544 (copy_row_except_pointers): Preserve the used[] arrays and the
14545 hash values of the two rows. (Bug#10035)
68c95424 14546 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
14547
14548 * xdisp.c (row_hash): New function, body extracted from
14549 compute_line_metrics.
14550 (compute_line_metrics): Call row_hash, instead of computing the
14551 hash code inline.
14552
14553 * dispnew.c (verify_row_hash): Call row_hash for computing the
14554 hash code of a row, instead of duplicating code from xdisp.c.
14555
14556 * dispextern.h (row_hash): Add prototype.
14557
a2addb04
TH
145582011-11-18 Tassilo Horn <tassilo@member.fsf.org>
14559
14560 * frame.c (delete_frame): Don't delete the terminal when the last
14561 X frame is closed if emacs is built with GTK toolkit.
14562
df85d315
JB
145632011-11-17 Juanma Barranquero <lekktu@gmail.com>
14564
14565 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
14566
a0c2d0ae
MR
145672011-11-17 Martin Rudalics <rudalics@gmx.at>
14568
14569 * window.c (Vwindow_splits): Rename to
14570 Vwindow_combination_resize. Suggested by Juri Linkov.
14571 (Fsplit_window_internal): Use Vwindow_combination_resize instead
14572 of Vwindow_splits.
14573
58179cce
JB
145742011-11-16 Juanma Barranquero <lekktu@gmail.com>
14575
7877f373
JB
14576 * nsfns.m (Fns_font_name):
14577 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 14578
b6f67890
MR
145792011-11-16 Martin Rudalics <rudalics@gmx.at>
14580
14581 * window.h (window): Rename slot "nest" to "combination_limit".
14582 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
14583 (Fset_window_nest): Rename to Fset_window_combination_limit.
14584 (Vwindow_nest): Rename to Vwindow_combination_limit.
14585 (recombine_windows, make_parent_window, make_window)
14586 (Fsplit_window_internal, saved_window)
14587 (Fset_window_configuration, save_window_save): Rename all
14588 occurrences of window_nest to window_combination_limit.
14589
c7015153
JB
145902011-11-15 Juanma Barranquero <lekktu@gmail.com>
14591
14592 * image.c (imagemagick_load_image): Fix typo.
14593
322ad6ec
EZ
145942011-11-14 Eli Zaretskii <eliz@gnu.org>
14595
14596 * xdisp.c (display_line): Move the call to
14597 highlight_trailing_whitespace before the call to
14598 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
14599 faces of all the glyphs to compute ROW's hash value.
14600 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 14601
f067b8ec
JB
146022011-11-14 Juanma Barranquero <lekktu@gmail.com>
14603
14604 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
14605 just return (bug#10044).
14606
1e5b2111
EZ
146072011-11-12 Eli Zaretskii <eliz@gnu.org>
14608
7ef3cbd5
EZ
14609 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
14610 with user-defined heap size. Bump the default size of the temacs
14611 heap to 27MB, to avoid memory warning when running temacs.
14612 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
14613
1e5b2111
EZ
14614 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
14615 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
14616 (verify_row_hash) [XASSERTS]: New function.
14617 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
14618 that the hash value of glyph rows is correct.
1e5b2111 14619
89d61221
MR
146202011-11-12 Martin Rudalics <rudalics@gmx.at>
14621
14622 * window.h (window): Remove splits slot.
14623 * window.c (Fwindow_splits, Fset_window_splits): Remove.
14624 (Fdelete_other_windows_internal, make_parent_window)
14625 (make_window, Fsplit_window_internal, Fdelete_window_internal)
14626 (Fset_window_configuration, save_window_save): Don't deal with
14627 split status of windows.
14628 (saved_window): Remove splits slot.
14629 (Vwindow_splits): Rewrite doc-string.
14630
97f18cc8
JD
146312011-11-11 Jan Djärv <jan.h.d@swipnet.se>
14632
14633 * xfns.c (unwind_create_frame):
14634 * nsfns.m (unwind_create_frame):
14635 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
14636 Vframe_list (Bug#9999).
14637
22a648b4
DA
146382011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
14639
0b381c7e 14640 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 14641
659afede
KH
146422011-11-11 Kenichi Handa <handa@m17n.org>
14643
14644 * callproc.c (Fcall_process): Set the member dst_multibyte of
14645 process_coding.
14646
9ac0394b
KH
146472011-11-11 Johan Bockgård <bojohan@gnu.org>
14648
14649 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
14650 avoid a crash (bug#9496).
14651
2fbdc249
CY
146522011-11-09 Chong Yidong <cyd@gnu.org>
14653
14654 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
14655 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
14656
ac6b1f81
PE
146572011-11-08 Paul Eggert <eggert@cs.ucla.edu>
14658
14659 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
14660
09db192c
PE
146612011-11-08 Paul Eggert <eggert@cs.ucla.edu>
14662
14663 Avoid some portability problems by eschewing 'extern inline' functions.
14664 The trivial performance wins aren't worth the portability hassles; see
14665 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
14666 et seq.
14667 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
14668 (window_box_width, window_box_left, window_box_left_offset)
14669 (window_box_right, window_box_right_offset): Undo previous change,
14670 by removing the "extern"s.
14671 * intervals.c (adjust_intervals_for_insertion)
14672 (adjust_intervals_for_deletion): Undo previous change,
14673 making these static again.
14674 (offset_intervals, temp_set_point_both, temp_set_point)
14675 (copy_intervals_to_string): No longer inline.
14676 * xdisp.c (window_text_bottom_y, window_box_width)
14677 (window_box_height, window_box_left_offset)
14678 (window_box_right_offset, window_box_left, window_box_right)
14679 (window_box): No longer inline.
14680
105216ed
CY
146812011-11-08 Chong Yidong <cyd@gnu.org>
14682
14683 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
14684 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
14685 Signal an error if not a live window.
105216ed
CY
14686 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
14687 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
14688
ae9e237f
JB
146892011-11-07 Juanma Barranquero <lekktu@gmail.com>
14690
14691 * lisp.h (syms_of_abbrev): Remove declaration.
14692 Reported by CHENG Gao <chenggao@royau.me>.
14693
c7aa8333
EZ
146942011-11-07 Eli Zaretskii <eliz@gnu.org>
14695
14696 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
14697 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
14698 of temacs in GUI mode.
14699
be7f5545
MR
147002011-11-07 Martin Rudalics <rudalics@gmx.at>
14701
14702 * window.h: Declare delete_all_child_windows instead of
14703 delete_all_subwindows.
14704 * window.c (Fwindow_nest, Fset_window_nest)
14705 (Fset_window_new_total, Fset_window_new_normal)
14706 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
14707 (delete_all_subwindows): Rename to delete_all_child_windows.
14708 (Fdelete_other_windows_internal, Fset_window_configuration):
14709 Call delete_all_child_windows instead of delete_all_subwindows.
14710 * frame.c (delete_frame): Call delete_all_child_windows instead
14711 of delete_all_subwindows.
14712
ca78dc43
PE
147132011-11-07 Paul Eggert <eggert@cs.ucla.edu>
14714
14715 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
14716 This is also needed for porting to any host where GC_MARK_STACK is
14717 not GC_MAKE_GCPROS_NOOPS.
14718 (which_symbols): Use it.
14719
a0241d01
KH
147202011-11-07 Kenichi Handa <handa@m17n.org>
14721
14722 * coding.c (coding_set_destination): Check coding->src_pos only
14723 when coding->src_object is a buffer (bug#9910).
14724
14725 * process.c (send_process): Set the member src_multibyte of coding
14726 to 0 (bug#9911) when sending a unibyte text.
14727
14728 * callproc.c (Fcall_process): Set the member src_multibyte of
14729 process_coding to 0 (bug#9912).
14730
a64bfdfa 147312011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
14732
14733 * xmenu.c (cleanup_widget_value_tree): New function.
14734 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
14735 calling free_menubar_widget_value_tree directly (Bug#9830).
14736
cb41b32a
PE
147372011-11-06 Paul Eggert <eggert@cs.ucla.edu>
14738
14739 Fix some portability problems with 'inline'.
14740 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
14741 (window_box_width, window_box_left, window_box_left_offset)
14742 (window_box_right, window_box_right_offset): Declare extern.
14743 Otherwise, these inline functions do not conform to C99 and
14744 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
14745 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
14746 * intervals.c (adjust_intervals_for_insertion)
14747 (adjust_intervals_for_deletion): Now extern, because otherwise the
14748 extern inline functions 'offset_intervals' couldn't refer to it.
14749 (static_offset_intervals): Remove.
14750 (offset_intervals): Rewrite using the old contents of
14751 static_offset_intervals. The old version didn't conform to C99
14752 because an extern inline function contained a reference to an
14753 identifier with static linkage.
14754
b7041366
AS
147552011-11-06 Andreas Schwab <schwab@linux-m68k.org>
14756
14757 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
14758 GC.
14759
88a37c4d
EZ
147602011-11-06 Eli Zaretskii <eliz@gnu.org>
14761
14762 * xdisp.c (init_iterator, reseat_to_string): Don't set the
14763 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
14764 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
14765 return Qleft_to_right.
14766
49745b39
CY
147672011-11-06 Chong Yidong <cyd@gnu.org>
14768
14769 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
14770 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
14771 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
14772 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
14773 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
14774 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
14775 (Fwindow_vscroll): Doc fix.
14776 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
14777 argument, since it makes no sense to pass a live window and for
14778 consistency with window-child.
14779
1f05cd82
CS
147802011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
14781
14782 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
14783 support MSVC.
14784
22610910
JR
147852011-11-05 Jason Rumney <jasonr@gnu.org>
14786
14787 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
14788 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
14789 fonts (Bug#6029).
14790 (add_font_entity_to_list): Fix logic errors in mixed boolean and
14791 bitwise arithmetic preventing use of unicode-sip and non-truetype
14792 opentype fonts.
14793
a06776b2
EZ
147942011-11-05 Eli Zaretskii <eliz@gnu.org>
14795
3ad924ba
EZ
14796 * s/ms-w32.h (fstat, stat, utime): Move redirections to
14797 "emacs"-only part.
14798
a06776b2
EZ
14799 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
14800 initialization code to keep similarity to xfns.c after changes
14801 from 2011-11-05.
14802
c9e7db78
JD
148032011-11-05 Jan Djärv <jan.h.d@swipnet.se>
14804
a97f8f3f
JD
14805 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
14806 (unwind_create_frame): New function (Bug#9943).
14807 (Fx_create_frame): Restructure code to be more similar to the one in
14808 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
14809 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
14810 Move terminal->reference_count++ just before making the frame official
14811 (Bug#9943).
14812
14813 * nsterm.m (x_free_frame_resources): New function.
14814 (x_destroy_window): Move code to x_free_frame_resources.
14815
c9e7db78 14816 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
14817 (Fx_create_frame, x_create_tip_frame):
14818 Move terminal->reference_count++ just before making the frame
75f1671a 14819 official. Move initialization of image_cache_refcount and
c9e7db78
JD
14820 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
14821
a6fc3b5c
EZ
148222011-11-05 Eli Zaretskii <eliz@gnu.org>
14823
14824 Support MSVC build with newer versions of Visual Studio.
14825 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
14826 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
14827 nt/gmake.defs.
14828
14829 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
14830 which are not supported by MSVC.
14831 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
14832 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
14833 bitfields.
14834 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
14835 types in bitfields.
14836 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
14837
14838 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
14839
58179cce 148402011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
14841
14842 Support MSVC build with newer versions of Visual Studio.
14843 * w32.c: Don't include w32api.h for MSVC.
14844 (init_environment) [_MSC_VER]: Call sys_access, not _access.
14845
14846 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
14847 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
14848 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
14849 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
14850 e_* cousins.
14851 (alloca) [_MSC_VER]: Define to _alloca.
14852
14853 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
14854
14855 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
14856
a58c13ed
EZ
148572011-11-04 Eli Zaretskii <eliz@gnu.org>
14858
14859 * xdisp.c (note_mouse_highlight): If either of
14860 previous/next-single-property-change returns nil, treat that as
14861 the beginning or the end of the buffer. (Bug#9955)
14862
fe0b6370
JD
148632011-11-04 Jan Djärv <jan.h.d@swipnet.se>
14864
a58c13ed 14865 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
14866 label is not null (Bug#9951).
14867 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
14868 may be NULL.
14869
89bd5ee1
EZ
148702011-11-04 Eli Zaretskii <eliz@gnu.org>
14871
14872 * window.c (Fwindow_body_size): Mention in the doc string that the
14873 return value is in frame's canonical units. (Bug#9949)
14874
84c3edb9
EZ
148752011-11-03 Eli Zaretskii <eliz@gnu.org>
14876
4e2fb5c7
EZ
14877 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
14878
84c3edb9 14879 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 14880 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 14881 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 14882
bc17a887
EZ
148832011-11-01 Eli Zaretskii <eliz@gnu.org>
14884
14885 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
14886 Don't stop backward scan on the continuation glyph, even though
14887 its CHARPOS is positive.
6d5eb5b0
SM
14888 (mouse_face_from_buffer_pos, note_mouse_highlight):
14889 Rename cover_string to disp_string.
bc17a887 14890
4ee88440
MR
148912011-11-01 Martin Rudalics <rudalics@gmx.at>
14892
14893 * window.c (temp_output_buffer_show): Don't use
14894 Vtemp_buffer_show_specifiers.
14895 (Vtemp_buffer_show_specifiers): Remove unused variable.
14896
c2ff3c02
EZ
148972011-10-30 Eli Zaretskii <eliz@gnu.org>
14898
14899 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
14900 past the beginning of the current glyph matrix.
14901
58179cce 149022011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
14903
14904 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
14905 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
14906 HAVE_GTK3 (Bug#9869).
b77a6a7f 14907
3b574623
JD
14908 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
14909 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
14910
b77a6a7f
JD
14911 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
14912
14913 * xterm.c: Declare x_handle_net_wm_state to return int.
14914 (handle_one_xevent): Check if we are iconified but don't have
14915 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
14916 (get_current_wm_state): Return non-zero if not hidden,
14917 check for _NET_WM_STATE_HIDDEN (Bug#9893).
14918 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
14919 (x_handle_net_wm_state): Return what get_current_wm_state returns.
14920 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
14921
196e41e4
PE
149222011-10-29 Paul Eggert <eggert@cs.ucla.edu>
14923
14924 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
14925 so that this new function doesn't get optimized away by a
14926 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
14927
021f2e1a
AS
149282011-10-29 Andreas Schwab <schwab@linux-m68k.org>
14929
14930 * frame.h (MOUSE_HL_INFO): Remove excess parens.
14931
8b058d44
EZ
149322011-10-29 Eli Zaretskii <eliz@gnu.org>
14933
14934 Fix the `xbytecode' command.
14935 * .gdbinit (xprintbytestr): New command.
b50a28de 14936 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
14937 (xbytecode): Print the byte-code string as well.
14938
4452fb80
EZ
149392011-10-29 Kim Storm <storm@cua.dk>
14940
8b058d44
EZ
14941 * alloc.c (which_symbols): New function.
14942
21b72067
AS
149432011-10-29 Andreas Schwab <schwab@linux-m68k.org>
14944
14945 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
14946 line. (Bug#9903)
14947
83ed7b5c
GM
149482011-10-29 Glenn Morris <rgm@gnu.org>
14949
14950 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
14951 Not clear what it was for, and it causes various bugs. (Bug#9839)
14952
5a7a728b
EZ
149532011-10-28 Eli Zaretskii <eliz@gnu.org>
14954
14955 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
14956 possible random value that matches one of those tested as
14957 condition to clear the mouse face.
14958
d3d0842f
CY
149592011-10-28 Chong Yidong <cyd@gnu.org>
14960
14961 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
14962
31b39d13
DN
149632011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
14964
14965 * window.c (make_window): Initialize phys_cursor_on_p.
14966
9aba6043
SM
149672011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
14968
14969 * lisp.h (struct Lisp_Symbol): Update comments.
14970
c20992f4
JB
149712011-10-28 Juanma Barranquero <lekktu@gmail.com>
14972
14973 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
14974
db4f02f2
EZ
149752011-10-28 Eli Zaretskii <eliz@gnu.org>
14976
14977 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
14978 <oslsachem@gmail.com> for helping to debug this.
14979
14980 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
14981 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
14982 (g_b_init_get_glyph_outline_w): New static variables.
14983 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
14984 (GetGlyphOutlineW_Proc): New typedefs.
14985 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
14986 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
14987 New functions.
14988 (w32font_open_internal, compute_metrics):
14989 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
14990 instead of calling the "wide" APIs directly.
14991
14992 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
14993
14994 * w32.h (syms_of_w32font): Add prototype.
14995
87e68db4
JB
149962011-10-27 Juanma Barranquero <lekktu@gmail.com>
14997
14998 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
14999 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
15000 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
15001 (Fmove_to_window_line): Doc fix.
15002
435c1d67
CY
150032011-10-27 Chong Yidong <cyd@gnu.org>
15004
15005 * process.c (make_process): Set gnutls_state to NULL.
15006
15007 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
15008 non-NULL, regardless of GNUTLS_INITSTAGE.
15009 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
15010 an error. Set process slots as soon as we allocate them.
15011
15012 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
15013
9c6c6f49
CY
150142011-10-27 Chong Yidong <cyd@gnu.org>
15015
9aba6043
SM
15016 * gnutls.c (emacs_gnutls_deinit): New function.
15017 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
15018 (Fgnutls_deinit, Fgnutls_boot): Use it.
15019
15020 * process.c (make_process): Initialize GnuTLS credentials to NULL.
15021 (deactivate_process): Call emacs_gnutls_deinit.
15022
657d08d3
JB
150232011-10-27 Juanma Barranquero <lekktu@gmail.com>
15024
15025 * image.c (x_create_x_image_and_pixmap):
15026 * w32.c (sys_rename, w32_delayed_load):
15027 * w32font.c (fill_in_logfont):
15028 * w32reg.c (x_get_string_resource): Silence compiler warnings.
15029
5430d399
JB
150302011-10-26 Juanma Barranquero <lekktu@gmail.com>
15031
15032 * w32fns.c (w32_default_color_map): New function,
15033 extracted from Fw32_default_color_map.
a7ef684b 15034 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 15035
fe0055fa
PE
150362011-10-25 Paul Eggert <eggert@cs.ucla.edu>
15037
15038 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
15039
e6346438
SM
150402011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
15041
15042 * keyboard.c (test_undefined): New function (bug#9751).
15043 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
15044
e112cc37
ET
150452011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
15046
15047 * sysdep.c (init_sys_modes): Fix the check for the controlling
15048 terminal (Bug#6649).
15049
7b5d6677
EZ
150502011-10-20 Eli Zaretskii <eliz@gnu.org>
15051
15052 * dispextern.h (struct bidi_it): New member next_en_type.
15053
15054 * bidi.c (bidi_line_init): Initialize the next_en_type member.
15055 (bidi_resolve_explicit_1): When next_en_pos is valid for the
15056 current character, check also for next_en_type being WEAK_EN.
15057 (bidi_resolve_weak): Don't enter the expensive loop if the current
15058 position is before next_en_pos. Record the bidi type of the first
15059 non-ET, non-BN character we find, in addition to its position.
15060 (bidi_level_of_next_char): Invalidate next_en_type when
15061 next_en_pos is over-stepped.
15062
7da0b018
PE
150632011-10-20 Paul Eggert <eggert@cs.ucla.edu>
15064
15065 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
15066 * editfns.c: Rewrite current-time-zone so that it invokes
15067 the equivalent of (format-time-string "%Z") to get the time zone name.
15068 This fixes a bug when the time zone name contains characters that
15069 need converting from the system time locale to Emacs internal format.
15070 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
15071 that patch fixed format-time-string to do the conversion, but
15072 I forgot to fix current-time-zone.
15073 (format_time_string): New function, containing most of
15074 what Fformat_time_string used to contain.
15075 (Fformat_time_string): Rewrite in terms of format_time_string.
15076 This doesn't change this function's behavior.
15077 (current-time-zone): Rewrite to use format_time_string.
15078 This fixes the bug reported by Michael Schierl in
15079 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
15080 Jason Rumney's 2007-06-07 change worked around this bug, but
15081 didn't fix it.
15082 * systime.h (tzname, timezone): Remove no-longer-used declarations.
15083
8547b010
EZ
150842011-10-19 Eli Zaretskii <eliz@gnu.org>
15085
15086 * xdisp.c (start_display): If the character at POS is displayed
15087 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
15088 (try_window_reusing_current_matrix): If a line ends in a display
15089 vector or the next line starts in a display vector, continue
15090 redrawing the window even though the character position of
15091 start_row was reached.
8547b010
EZ
15092 (Bug#9771, part 2)
15093
4e948d15
CY
150942011-10-18 Chong Yidong <cyd@gnu.org>
15095
15096 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
15097 with nobreak-char-display too.
15098
4787455f
EZ
150992011-10-18 Eli Zaretskii <eliz@gnu.org>
15100
15101 Fix part 3 of bug#9771.
15102 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
15103 (bidi_resolve_neutral): Don't enter the expensive loop looking for
15104 non-neutral characters if the current character is a paragraph
15105 separator (a.k.a. Newline). This avoids running the same
15106 expensive loop twice, once when we consume the preceding newline
15107 and the other time when the line actually needs to be displayed.
15108 Avoid the loop when we see neutrals on the base embedding level
15109 following a character whose directionality is the same as the
15110 paragraph's. This avoids running the expensive loop when a line
15111 ends in a long sequence of neutrals, like control characters.
15112 Add assertion against STRONG_AL type. Slightly rearrange code
15113 that determines the type of a neutral given the first non-neutral
15114 that follows it.
15115 (bidi_level_of_next_char): Set next_en_pos to zero when
15116 invalidating its info.
15117
2c91f553
EZ
151182011-10-17 Eli Zaretskii <eliz@gnu.org>
15119
15120 * xdisp.c (push_display_prop): Determine whether to record string
15121 or buffer position by IT->string, not by IT->method. Allow
15122 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
15123 (move_it_vertically_backward): Don't look for character position
15124 immediately after the newline when in a continuation line.
15125 (Bug#9771, part 1)
2c91f553 15126
c7b08b0d
MR
151272011-10-15 Martin Rudalics <rudalics@gmx.at>
15128
15129 * window.c (coordinates_in_window): Rewrite and delabelize
15130 vertical border check. (Bug#5357) (Bug#9618)
15131
6b02f655
SM
151322011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
15133
15134 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
15135 errors in XSetWindowBorder (bug#9310).
15136
81d40c92
DA
151372011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
15138
15139 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
15140 avoid crash when xmalloc overrun checking is enabled.
15141
d4172c3b
EZ
151422011-10-13 Eli Zaretskii <eliz@gnu.org>
15143
15144 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
15145 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
15146 cursor motion with <left> and <right> arrow keys.
15147
15148 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
15149 some callers set that themselves.
15150
b00eea75
EZ
151512011-10-12 Eli Zaretskii <eliz@gnu.org>
15152
15153 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
15154 display string and the previous row comes from the same string and
15155 is empty. (Bug#9739) (Bug#9738)
15156
8fe012c4
SM
151572011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
15158
15159 * doc.c (get_doc_string): Encode file name (bug#9735).
15160
0074aef2
EZ
151612011-10-12 Eli Zaretskii <eliz@gnu.org>
15162
79beb178
EZ
15163 * bidi.c (bidi_level_of_next_char):
15164 * xdisp.c (get_visually_first_element): Remove old incorrect
15165 comments regarding the Unicode Line Separator character.
15166
0074aef2
EZ
15167 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
15168
6e4b3fbe
DA
151692011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
15170
15171 * alloc.c (Fgc_status): Do not access beyond zombies array
15172 boundary if nzombies > MAX_ZOMBIES.
15173 * alloc.c (dump_zombies): Add missing format specifier.
15174
0324f3af
PE
151752011-10-12 Paul Eggert <eggert@cs.ucla.edu>
15176
b5525cac
PE
15177 * xdisp.c (set_cursor_from_row): Simplify conditionals,
15178 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
15179
0324f3af
PE
15180 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
15181 Some packages use them to denote characters with modifiers.
15182
e9b5f888
AS
151832011-10-11 Andreas Schwab <schwab@linux-m68k.org>
15184
15185 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
15186 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
15187 matching a pp-number. Rename parameter var to var1.
15188
127827c0
SM
151892011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
15190
15191 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
15192
c8fd3bd0
GM
151932011-10-08 Glenn Morris <rgm@gnu.org>
15194
15195 * callint.c (Fcall_interactively): Give a more explicit error for the
15196 'c' case with a non-character input. (Bug#8479)
15197
352ec8ff
EZ
151982011-10-08 Eli Zaretskii <eliz@gnu.org>
15199
03669ccb
EZ
15200 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
15201 lines.
7061c986
EZ
15202 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
15203 lines that are hscrolled on the left.
03669ccb 15204
352ec8ff
EZ
15205 * dispnew.c (buffer_posn_from_coords): Account for a possible
15206 presence of header-line. (Bug#4426)
15207
a66cfb1c
SM
152082011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
15209
6b02f655
SM
15210 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
15211 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 15212
7c5ee88e
PE
152132011-10-07 Paul Eggert <eggert@cs.ucla.edu>
15214
15215 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
15216 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
15217 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
15218 this makes Emacs dump core during garbage collection on rare
15219 occasions. sizeof is obviously inferior to offsetof here, so
15220 stick with offsetof.
15221 (GC_POINTER_ALIGNMENT): New macro.
15222 (mark_memory): Omit 3rd (offset) arg; caller changed.
15223 Don't assume EMACS_INT alignment is the same as pointer alignment.
15224
df1bbe5b
SM
152252011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
15226
15227 * keyboard.c (read_key_sequence_remapped): New var.
15228 (read_key_sequence): Compute remapping in the right buffer.
15229 (command_loop_1): Use read_key_sequence's remapping directly.
15230
51553db6
SM
152312011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
15232
32c1fffd
SM
15233 * dired.c (file_name_completion): Don't expand file name.
15234 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
15235 before checking file name handler.
15236
51553db6
SM
15237 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
15238 they've been requested explicitly (bug#9591).
15239
b6bd1599 152402011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
15241
15242 * keymap.c (Fsingle_key_description): Use make_specified_string
15243 instead of build_string to build string from push_key_description.
15244 (Bug#5193)
15245
f701dc2a
PE
152462011-09-30 Paul Eggert <eggert@cs.ucla.edu>
15247
4222c55d
PE
15248 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
15249 This fixes a Y2038 bug on 64-bit hosts.
15250 * buffer.c (reset_buffer):
15251 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
15252 (Fclear_buffer_auto_save_failure):
15253 Use 0, not -1, to represent an unset failure time, since time_t
15254 might not be signed.
15255
f701dc2a
PE
15256 Remove dependency on glibc malloc internals.
15257 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
15258 Move back here from lisp.h, but with their new implementations.
15259 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
15260 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
15261 * charset.c (charset_table_init): New static var.
15262 (syms_of_charset): Use it instead of xmalloc. This removes a
15263 dependency on glibc malloc internals. See Eli Zaretskii's comment in
15264 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
15265 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
15266 Move back to alloc.c.
15267 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
15268 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
15269
9ceebf39
JD
152702011-09-30 Jan Djärv <jan.h.d@swipnet.se>
15271
15272 * nsterm.m (windowDidResize): Call x_set_window_size only when
15273 ns_in_resize is true. Otherwise set pixelwidth/height and
15274 call change_frame_size (Bug#9628).
15275
cb993c58
PE
152762011-09-30 Paul Eggert <eggert@cs.ucla.edu>
15277
3930c88b
PE
15278 Port --enable-checking=all to Fedora 14 x86-64.
15279 * charset.c (syms_of_charset): Also account for glibc malloc's
15280 internal overhead when calculating the initial malloc maximum.
15281
cb993c58
PE
15282 Port --enable-checking=all to Fedora 14 x86.
15283 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
15284 Move to lisp.h.
15285 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
15286 (overrun_check_realloc, overrun_check_free):
15287 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
15288 That way, xmalloc returns a properly-aligned pointer even if
15289 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
15290 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
15291 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
15292 into account when calculating the initial malloc maximum.
15293 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
15294 Move here from alloc.c, so that charset.c can use it too.
15295 Properly align; the old code wasn't right for common 32-bit hosts
15296 when configured with --enable-checking=all.
15297 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
15298 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
15299
31bed486
EZ
153002011-09-29 Eli Zaretskii <eliz@gnu.org>
15301
04c70788 15302 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
15303 use EDOM.
15304
fbcaa2f3
EZ
153052011-09-28 Eli Zaretskii <eliz@gnu.org>
15306
15307 * xdisp.c (compute_display_string_end): If there's no display
15308 string at CHARPOS, return -1.
15309
15310 * bidi.c (bidi_fetch_char): When compute_display_string_end
15311 returns a negative value, treat the character as a normal
15312 character not covered by a display string. (Bug#9624)
15313
a239d4e9
JB
153142011-09-28 Juanma Barranquero <lekktu@gmail.com>
15315
15316 * lread.c (Fread_from_string): Fix typo in docstring.
15317
88652fd5
EZ
153182011-09-27 Eli Zaretskii <eliz@gnu.org>
15319
15320 * xdisp.c (handle_invisible_prop): If invisible text ends on a
15321 newline, reseat the iterator instead of bidi-iterating there one
15322 character at a time. (Bug#9610)
32c1fffd
SM
15323 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
15324 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 15325
ed497dd4
AS
153262011-09-27 Andreas Schwab <schwab@linux-m68k.org>
15327
15328 * lread.c (readevalloop): Use correct code for NBSP.
15329 (read1): Likewise. (Bug#9608)
15330
b2bf61aa
MA
153312011-09-25 Michael Albinus <michael.albinus@gmx.de>
15332
15333 * dbusbind.c (Fdbus_register_signal): When service is not
15334 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
15335
32bbb17c
GM
153362011-09-25 Glenn Morris <rgm@gnu.org>
15337
15338 * buffer.c (truncate-lines): Doc fix.
15339
94e0933e
CY
153402011-09-24 Chong Yidong <cyd@stupidchicken.com>
15341
15342 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
15343 (Fset_window_next_buffers): Doc fix.
15344
cddde921
GM
153452011-09-24 Glenn Morris <rgm@gnu.org>
15346
15347 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
15348
1260aef1
PE
153492011-09-24 Paul Eggert <eggert@cs.ucla.edu>
15350
25b4bfa0
PE
15351 Fix minor problems found by static checking.
15352 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
15353 * indent.c (Fvertical_motion): Fix == vs = typo.
15354
e3cbd34b
EZ
153552011-09-24 Eli Zaretskii <eliz@gnu.org>
15356
a66cfb1c
SM
15357 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
15358 Default value is now t. Doc fix.
6bf7006f 15359
e3cbd34b 15360 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 15361 logic when moving up, not only when moving down. Fix the
e3cbd34b 15362 confusing name and values of the it_overshoot_expected variable;
32c1fffd 15363 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
15364
15365 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
15366 CHARPOS is covered by a display string which includes newlines.
15367 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
15368 is covered by a display string with embedded newlines.
15369
a3de0cbd
MA
153702011-09-24 Michael Albinus <michael.albinus@gmx.de>
15371
15372 * dbusbind.c (Fdbus_register_signal): Add match rule to
15373 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
15374 (Fdbus_register_method, Vdbus_registered_objects_table):
15375 Fix docstring.
a3de0cbd 15376
b260039d
JM
153772011-09-24 Jim Meyering <meyering@redhat.com>
15378
32c1fffd 15379 do not ignore write error for any output size
b260039d
JM
15380 The previous change was incomplete.
15381 While it makes emacs --batch detect the vast majority of stdout
15382 write failures, errors were still ignored whenever the output size is
15383 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
15384 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
15385 && echo FAIL: ignored write error
15386 FAIL: ignored write error
15387 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
15388 && echo FAIL: ignored write error
15389 FAIL: ignored write error
15390 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
15391
8eca8a7c
AS
153922011-09-23 Andreas Schwab <schwab@linux-m68k.org>
15393
15394 * emacs.c (Fkill_emacs): In noninteractive mode exit
15395 non-successfully if a write error occurred on stdout. (Bug#9574)
15396
3341db62
EZ
153972011-09-21 Eli Zaretskii <eliz@gnu.org>
15398
15399 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
15400 the xassert test.
15401
15402 * dispextern.h (struct it): Update the comment documenting what
15403 can it->OBJECT be.
15404
8c203dbf
EZ
154052011-09-20 Eli Zaretskii <eliz@gnu.org>
15406
15407 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
15408 a display string, extend search for cursor position to end of row.
15409 (find_row_edges): If the row ends in a newline from a display
15410 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
15411 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
15412 (Fcurrent_bidi_paragraph_direction): Fix search for previous
15413 non-empty line. Fixes confusing cursor motion with arrow keys at
15414 the beginning of a line that starts with whitespace.
8c203dbf 15415
a4824228
LMI
154162011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
15417
15418 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
15419 (bug#9493).
15420
33ed493b
CY
154212011-09-18 Chong Yidong <cyd@stupidchicken.com>
15422
15423 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
15424 boolean (Bug#9154).
15425
56cd55c8
EZ
154262011-09-18 Eli Zaretskii <eliz@gnu.org>
15427
15428 * xdisp.c (display_line): Record maximum and minimum buffer
15429 positions even if no glyphs were produced (e.g., by a zero-width
15430 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
15431 buffer positions that will be removed from the glyph row because
15432 they don't fit.
c02dcedf
EZ
15433 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
15434 column is beyond frame width: don't subtract 1 "pixel" when
15435 computing width of the stretch.
3e62b7e0
EZ
15436 (reseat_at_next_visible_line_start): Undo the change made on
15437 2011-09-17 that saved paragraph information and restored it after
15438 the call to `reseat'. (Bug#9545)
56cd55c8 15439
5ed99d36 154402011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
15441
15442 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
15443 and turn window cursor on if cleared (Bug#9415).
15444
5ed99d36 154452011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
15446
15447 * search.c (boyer_moore): Take unibyte characters from pattern
15448 literally. (Bug#9458)
15449
9bade7b2
EZ
154502011-09-18 Eli Zaretskii <eliz@gnu.org>
15451
15452 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
15453
e5e9d610
PE
154542011-09-18 Paul Eggert <eggert@cs.ucla.edu>
15455
87e4427a
PE
15456 Fix minor problem found by static checking.
15457 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
15458 initialized, to pacify gcc -Wuninitialized.
15459
e5e9d610
PE
15460 * fileio.c: Report proper errno when syscall falls.
15461 (Finsert_file_contents): Save and restore errno,
15462 so that report_file_error outputs the correct diagnostic.
15463 (Fwrite_region) [CLASH_DETECTION]: Likewise.
15464
a1674f0b
EZ
154652011-09-18 Eli Zaretskii <eliz@gnu.org>
15466
15467 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
15468
fbfb6dd4
EZ
154692011-09-17 Eli Zaretskii <eliz@gnu.org>
15470
15471 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
15472 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
15473
bb187662
EZ
154742011-09-17 Eli Zaretskii <eliz@gnu.org>
15475
1137e8b8 15476 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 15477 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
15478
15479 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
15480 (bidi_find_paragraph_start): Search back for paragraph beginning
15481 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
15482 (bidi_move_to_visually_next): Only trigger paragraph-related
15483 computations when the last character is a newline or at EOB, not
15484 just any NEUTRAL_B. (Bug#9470)
15485
bb187662
EZ
15486 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
15487 truncated lines if point is covered by a display string. (Bug#9524)
15488
2e621251
PE
154892011-09-16 Paul Eggert <eggert@cs.ucla.edu>
15490
15491 * xselect.c: Relax test for outgoing X longs (Bug#9498).
15492 (cons_to_x_long): New function.
15493 (lisp_data_to_selection_data): Use it. Correct the test for
15494 short-versus-long data; it was negated. Break out of vector
15495 loop, for efficiency, when a long datum is discovered.
15496
91a15bc6
SM
154972011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
15498
15499 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
15500
b41c3a35
EZ
155012011-09-16 Eli Zaretskii <eliz@gnu.org>
15502
15503 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
15504 GCC PR/17406) by declaring this function with external scope.
15505
7812ba2d
PE
155062011-09-15 Paul Eggert <eggert@cs.ucla.edu>
15507
15508 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
15509 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
15510
cf7edc2a
AS
155112011-09-15 Andreas Schwab <schwab@linux-m68k.org>
15512
15513 * editfns.c (Fformat): Correctly handle text properties on "%%".
15514
bd01620e
EZ
155152011-09-15 Eli Zaretskii <eliz@gnu.org>
15516
15517 * xterm.c (x_draw_composite_glyph_string_foreground):
15518 * w32term.c (x_draw_composite_glyph_string_foreground):
15519 * term.c (encode_terminal_code):
15520 * composite.c (composition_update_it, get_composition_id):
15521 * xdisp.c (get_next_display_element)
15522 (fill_composite_glyph_string): Add comments about special meaning
15523 of TAB characters in a composition.
15524
a02719a3
PE
155252011-09-15 Paul Eggert <eggert@cs.ucla.edu>
15526
15527 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
15528 This occurs when processing a multibyte format.
15529 Problem reported by Wolfgang Jenker.
a02719a3 15530
72589a3c
JB
155312011-09-15 Johan Bockgård <bojohan@gnu.org>
15532
15533 * xdisp.c (try_cursor_movement): Only check for exact match if
15534 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
15535
1c14176c
PE
155362011-09-14 Paul Eggert <eggert@cs.ucla.edu>
15537
15538 Remove unused external symbols.
15539 * dispextern.h (calc_pixel_width_or_height): Remove decl.
15540 * xdisp.c (calc_pixel_width_or_height): Now static.
15541 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
15542 * indent.c (check_display_width):
15543 * w32term.c: Fix comment to match code.
15544 * xterm.c, xterm.h (x_catching_errors): Remove.
15545
d2eea5b5
PE
155462011-09-14 Paul Eggert <eggert@cs.ucla.edu>
15547
15548 * xselect.c: Use signed conversions more consistently (Bug#9498).
15549 (selection_data_to_lisp_data): Assume incoming selection data are
15550 signed integers, not unsigned. This is to be consistent with
15551 outgoing selection data, which was modified to use signed integers
15552 in as part of the fix to Bug#9196 in response to Jan D.'s comment
15553 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
15554 expects long, not unsigned long.
15555
46888499
EZ
155562011-09-14 Eli Zaretskii <eliz@gnu.org>
15557
15558 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
15559 computation of loop end. Reported by Johan Bockgård
15560 <bojohan@gnu.org>.
15561
ef8ef9fb
CY
155622011-09-13 Chong Yidong <cyd@stupidchicken.com>
15563
15564 * frame.c (Fother_visible_frames_p): Function deleted.
15565
fa819fed
EZ
155662011-09-12 Eli Zaretskii <eliz@gnu.org>
15567
15568 * indent.c (compute_motion): Process display vector front to back
15569 rather than the other way around. (Bug#2496)
15570
2ba8e008
SM
155712011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
15572
15573 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
15574
20f53c69
CY
155752011-09-11 Chong Yidong <cyd@stupidchicken.com>
15576
15577 * minibuf.c (Fread_from_minibuffer): Doc fix.
15578
d562d7a4
EZ
155792011-09-11 Eli Zaretskii <eliz@gnu.org>
15580
15581 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
15582 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
15583
1c4d7f3d
LMI
155842011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
15585
15586 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
15587 value for non-existent files.
15588
b885bf36
EZ
155892011-09-11 Eli Zaretskii <eliz@gnu.org>
15590
15591 * fileio.c (Finsert_file_contents): If the file cannot be opened,
15592 set its "size" to -1. This will set the modtime_size field of
15593 the corresponding buffer to -1, which is what
15594 verify-visited-file-modtime expects for files that do not exist.
15595 (Bug#9139)
15596
6612f0bf
PE
155972011-09-11 Paul Eggert <eggert@cs.ucla.edu>
15598
15599 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
15600 here ...
15601 * lisp.h: ... from here. push_key_description is no longer
15602 defined in keyboard.c, so its declaration should not be in
15603 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
15604 logically belongs with push_key_description.
15605
dfb3f755
PE
156062011-09-10 Paul Eggert <eggert@cs.ucla.edu>
15607
15608 * buffer.h: Include <sys/types.h> instead of <time.h>.
15609 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
15610 Problem reported by Herbert J. Skuhra.
15611
3134906c
LMI
156122011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
15613
15614 * xml.c (parse_region): Make the parsing work for
15615 non-comment-starting XML files again (bug#9144).
15616
8d903f4e
AS
156172011-09-10 Andreas Schwab <schwab@linux-m68k.org>
15618
15619 * image.c (gif_load): Fix calculation of bottom and right corner.
15620 (Bug#9468)
15621
80ad64f4
EZ
156222011-09-10 Eli Zaretskii <eliz@gnu.org>
15623
15624 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
15625 redisplay in small windows.
15626
208a048d
EZ
156272011-09-09 Eli Zaretskii <eliz@gnu.org>
15628
15629 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
15630
9b1c252e
MR
156312011-09-08 Martin Rudalics <rudalics@gmx.at>
15632
15633 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
15634 Operate on live windows only.
15635
2949f33b
JB
156362011-09-08 Juanma Barranquero <lekktu@gmail.com>
15637
15638 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
15639
e08dcafd
EZ
156402011-09-07 Eli Zaretskii <eliz@gnu.org>
15641
15642 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
15643 only under bidi iteration.
15644
115b96bd
JD
156452011-09-07 Jan Djärv <jan.h.d@swipnet.se>
15646
15647 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
15648
c8199d0f
PE
156492011-09-06 Paul Eggert <eggert@cs.ucla.edu>
15650
15651 isnan: Fix porting problem to Solaris 10 with bundled gcc.
15652 Without this fix, the command to link temacs failed due to an
15653 undefined symbol __builtin_isnan. This is because
15654 /usr/include/iso/math_c99.h #defines isnan(x) to
15655 __builtin_isnan(x), but the bundled gcc, which identifies itself
15656 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
15657 a __builtin_isnan.
15658 * floatfns.c (isnan): #undef, and then #define to a clone of
15659 what's in data.c.
15660 (Fisnan): Always define, since it's always available now.
15661 (syms_of_floatfns): Always define isnan at the Lisp level.
15662
e39b275c 156632011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
15664
15665 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
15666
b2db44d9 156672011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 15668
f4af5137 15669 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
15670 The previous code assumed that file offsets (off_t values) fit in
15671 EMACS_INT variables, which is not true on typical 32-bit hosts.
15672 The code messed up by falsely reporting buffer overflow in cases
15673 such as (insert-file-contents "big" nil 1 2) into an empty buffer
15674 when "big" contains more than 2**29 bytes, even though this
15675 inserts just one byte and does not overflow the buffer.
15676 (Finsert_file_contents): Store file offsets as off_t
15677 values, not as EMACS_INT values. Check for overflow when
15678 converting between EMACS_INT and off_t. When checking for
15679 buffer overflow or for overlap, take the offsets into account.
15680 Don't use EMACS_INT for small values where int suffices.
15681 When checking for overlap, fix a typo: ZV was used where
15682 ZV_BYTE was intended.
15683 (Fwrite_region): Don't assume off_t fits into 'long'.
15684 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
15685
ecfc0a49
MA
156862011-09-05 Michael Albinus <michael.albinus@gmx.de>
15687
15688 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
15689
6511acf2 156902011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 15691
0999621a 15692 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
15693
15694 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 15695 (esprintf, exprintf, evxprintf): New functions.
62f19c19 15696 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 15697 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
15698 (modify_event_symbol): Do not assume that the length of
15699 name_alist_or_stem is safe to alloca and fits in int.
15700 (Fexecute_extended_command): Likewise for function name and binding.
15701 (Frecursion_depth): Wrap around reliably on integer overflow.
15702 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
15703 since some callers pass EMACS_INT values.
15704 (Fsingle_key_description): Don't crash if symbol name contains more
15705 than MAX_ALLOCA bytes.
15706 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
15707 (get_minibuffer): Arg is now EMACS_INT, not int.
15708 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 15709 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
15710 * window.h (command_loop_level, minibuf_level): Reflect API changes.
15711
2be7d702
PE
15712 * dbusbind.c (signature_cat): New function.
15713 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
15714 Do not overrun buffer; instead, report string overflow.
15715
9d1df220
PE
15716 * dispnew.c (add_window_display_history): Don't overrun buffer.
15717 Truncate instead; this is OK since it's just a log.
15718
33ef5c64
PE
15719 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
15720 even if the time zone offset is outlandishly large.
15721 Don't mishandle offset == INT_MIN.
15722
66c6fdd5
PE
15723 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
15724 when creating daemon; the previous buffer-overflow check was incorrect.
15725
d749b01b
PE
15726 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
15727 which has the guts of the old verror function.
15728
b5cd1905
PE
15729 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
15730 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
15731
6e1a67fb
PE
15732 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
15733 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 15734 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 15735 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
15736 length of string rather than counting it via multiple sprintfs;
15737 that's simpler and more reliable.
c21721cc
PE
15738 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
15739 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
15740 sprintf, in case result does not fit in int.
15741
c57b67fc
PE
15742 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
15743 (fontset_from_font): Print it.
15744
8a401434
PE
15745 * frame.c (tty_frame_count): Now printmax_t, not int.
15746 (make_terminal_frame, set_term_frame_name): Print it.
15747 (x_report_frame_params): In X, window IDs are unsigned long,
15748 not signed long, so print them as unsigned.
15749 (validate_x_resource_name): Check for implausibly long names,
15750 and don't assume name length fits in 'int'.
15751 (x_get_resource_string): Don't blindly alloca invocation name;
15752 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
15753 not fit in int.
15754
6e1a67fb
PE
15755 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
15756 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
15757 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
15758
0df02bf3
PE
15759 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
15760 Use esprintf, not sprintf, in case result does not fit in int.
15761
48e30793
PE
15762 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
15763 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
15764 it as a large positive number.
15765 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
15766 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
15767
a66ff6d8
PE
15768 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
15769 in case result does not fit in int.
15770
aca216ff
PE
15771 * print.c (float_to_string): Detect width overflow more reliably.
15772 (print_object): Make sprintf buffer a bit bigger, to avoid potential
15773 buffer overrun. Don't assume list length fits in 'int'. Treat
15774 print length of 0 as 0, not as infinity; to be consistent with other
15775 uses of print length in this function. Don't overflow print length
15776 index. Don't assume hash table size fits in 'long', or that
15777 vectorlike size fits in 'unsigned long'.
15778
31c286f7
PE
15779 * process.c (make_process): Use printmax_t, not int, to format
15780 process-name gensyms.
15781
55e5faa1
PE
15782 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
15783
80f2e268
PE
15784 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
15785 to avoid potential buffer overrun.
15786
670741ab
PE
15787 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
15788 if X resource line is longer than 512 bytes.
15789
b7163a50
PE
15790 * xfns.c (x_window): Make sprintf buffer a bit bigger
15791 to avoid potential buffer overrun.
15792
ae58ff1f
PE
15793 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
15794
c43c8a6a
PE
15795 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
15796
3f8236f4
PE
157972011-09-04 Paul Eggert <eggert@cs.ucla.edu>
15798
53e9fe90 15799 Integer overflow fixes for scrolling, etc.
6511acf2
PE
15800 Without these, Emacs silently mishandles large integers sometimes.
15801 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
15802 it were "C-u 1 M-x recenter" on a typical 64-bit host.
15803
6511acf2
PE
15804 * xdisp.c (try_window_id): Check Emacs fixnum range before
15805 converting to 'int'.
806add1d 15806
6511acf2 15807 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
15808 Check that an Emacs fixnum is in range before assigning it to 'int'.
15809 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
15810 values converted from Emacs fixnums.
15811 (Frecenter): Don't wrap around a line count if it is out of 'int'
15812 range; instead, treat it as an extreme value.
15813 (Fset_window_configuration, compare_window_configurations):
15814 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
15815
6511acf2
PE
15816 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
15817 that can exceed INT_MAX. Check that EMACS_INT value is in range
15818 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
15819 (match_limit): Don't assume that a fixnum can fit in 'int'.
15820
6511acf2 15821 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
15822 exceed INT_MAX.
15823
6511acf2 15824 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
15825 (Fvertical_motion): Don't wrap around LINES values that don't fit
15826 in 'int'. Instead, treat them as extreme values. This is good
15827 enough for windows, which can't have more than INT_MAX lines anyway.
15828
fcb901a7
LMI
158292011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
15830
0f2f6b6d
LMI
15831 * Require libxml/parser.h to avoid compilation warning.
15832
fcb901a7
LMI
15833 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
15834
15835 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
15836 since this reportedly can destroy thread storage.
15837
6e20a0d4
CY
158382011-08-30 Chong Yidong <cyd@stupidchicken.com>
15839
15840 * syntax.c (find_defun_start): Update all cache variables if
15841 exiting early (Bug#9401).
15842
148ae00e
EZ
158432011-08-30 Eli Zaretskii <eliz@gnu.org>
15844
f6cfbd8f
EZ
15845 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
15846
148ae00e
EZ
15847 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
15848 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
15849 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
15850
15851 * term.c (tty_append_glyph): New function.
15852 (produce_stretch_glyph): Static function and its prototype deleted.
15853
a66cfb1c
SM
15854 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
15855 Add prototypes.
148ae00e 15856
c4a07a4c
PE
158572011-08-29 Paul Eggert <eggert@cs.ucla.edu>
15858
15859 * image.c (parse_image_spec): Check for nonnegative, not for positive,
15860 when checking :margin (Bug#9390).
15861 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 15862 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
15863 so that the name doesn't mislead. All uses changed.
15864
6bc8cd65
JB
158652011-08-28 Johan Bockgård <bojohan@gnu.org>
15866
15867 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
15868 set_tty_hooks.
15869
dca4927e
EZ
158702011-08-27 Eli Zaretskii <eliz@gnu.org>
15871
15872 * xdisp.c (move_it_to): Don't bail out early when reaching
15873 position beyond to_charpos, if we are scanning backwards.
15874 (move_it_vertically_backward): When DY == 0, make sure we get to
15875 the first character in the line after the newline.
15876
f2cad773
PE
158772011-08-27 Paul Eggert <eggert@cs.ucla.edu>
15878
15879 * ccl.c: Improve and simplify overflow checking (Bug#9196).
15880 (ccl_driver): Do not generate an out-of-range pointer.
15881 (Fccl_execute_on_string): Remove unnecessary check for
15882 integer overflow, noted by Stefan Monnier in
15883 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
15884 Remove a FIXME that didn't need fixing.
15885 Simplify the newly-introduced buffer reallocation code.
15886
0cae2cdb
JB
158872011-08-27 Juanma Barranquero <lekktu@gmail.com>
15888
15889 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
15890
5fc295a4 158912011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 15892
70c60eb2 15893 Integer and memory overflow issues (Bug#9196).
726e0ab1 15894
d31850da
PE
15895 * doc.c (get_doc_string): Rework so that
15896 get_doc_string_buffer_size is the actual buffer size, rather than
15897 being 1 less than the actual buffer size; this makes xpalloc more
15898 convenient.
15899
a69fbedb
PE
15900 * image.c (x_allocate_bitmap_record, cache_image):
15901 * xselect.c (Fx_register_dnd_atom):
15902 Simplify previous changes by using xpalloc.
15903
fe5c5d37
PE
15904 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
15905 since either will do and ptrdiff_t is convenient with xpalloc.
15906
0065d054
PE
15907 * charset.c (charset_table_size)
15908 (struct charset_sort_data.priority): Now ptrdiff_t.
15909 (charset_compare): Don't overflow if priorities differ greatly.
15910 (Fsort_charsets): Don't assume list length fits in int.
15911 Check for size-calculation overflow when allocating sort data.
15912 (syms_of_charset): Allocate an initial charset table that is
15913 just under 64 KiB, to avoid problems with glibc malloc and mmap.
15914
15915 * cmds.c (internal_self_insert): Check for size-calculation overflow.
15916
15917 * composite.h (struct composition.glyph_len): Now int, not unsigned.
15918 The actual value is always <= INT_MAX, and leaving it unsigned made
15919 overflow checking harder.
15920
15921 * dispextern.h (struct glyph_matrix.rows_allocated)
15922 (struct face_cache.size): Now ptrdiff_t, for convenience in use
15923 with xpalloc. The values are still always <= INT_MAX.
15924
15925 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
15926
15927 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
15928 (SAFE_NALLOCA): New macro.
15929
15930 * region-cache.c (struct boundary.pos, find_cache_boundary)
15931 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
15932 (set_cache_region, invalidate_region_cache)
15933 (revalidate_region_cache, know_region_cache, region_cache_forward)
15934 (region_cache_backward, pp_cache):
15935 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
15936 so that ptrdiff_t * can be passed to xpalloc.
15937 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
15938 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
15939 (pp_cache): Don't assume cache_len fits in int.
15940 * region-cache.h: Adjust extern decls to match.
15941
15942 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
15943 EMACS_INT, since either will do, for xpalloc.
15944
15945 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
15946 (xnmalloc, xnrealloc, xpalloc): New functions.
15947
726e0ab1
PE
15948 * bidi.c (bidi_shelve_header_size): New constant.
15949 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
15950 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
15951
51f30bc5 15952 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
15953 * buffer.c (overlays_at, overlays_in, record_overlay_string)
15954 (overlay_strings):
15955 Don't update size of array until after memory allocation succeeds,
15956 because xmalloc/xrealloc may not return.
0065d054
PE
15957 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
15958 now that we have proper integer overflow checking.
15959 (record_overlay_string, overlay_strings): Catch overflows when
15960 calculating size of overlay_str_buf.
726e0ab1 15961
0065d054
PE
15962 * callproc.c (Fcall_process): Check for size overflow when
15963 calculating size of args2.
15964 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
15965 Normally we prefer signed values, but sticking with ptrdiff_t would
15966 require adding more-complicated checks.
726e0ab1
PE
15967
15968 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
15969 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
15970 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 15971 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
15972
15973 * character.c (Fstring): Check for size-calculation overflow.
15974
15975 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
15976 unnecessary integer overflow. Check for size overflow.
15977 (encode_coding_object): Don't update size until xmalloc succeeds.
15978
15979 * composite.c (get_composition_id): Check for overflow in glyph
15980 length calculations.
15981
15982 Integer and memory overflow fixes for display code.
15983 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
15984 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
15985 (scrolling_window): Check for overflow in size calculations.
15986 (line_draw_cost, realloc_glyph_pool, add_row_entry):
15987 Don't assume glyph table len fits in int.
15988 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
15989 (row_table_size): Now ptrdiff_t, not int.
15990 (scrolling_window): Avoid overflow in size calculations.
15991 Don't update size until allocation succeeds.
15992 * fns.c (concat): Check for overflow in size calculations.
15993 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
15994 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
15995 (NEXT_ALMOST_PRIME_LIMIT): New constant.
15996
15997 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
15998 (get_doc_string): Check for size calculation overflow.
15999 Don't update size until allocation succeeds.
16000 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
16001 EMACS_INT, where ptrdiff_t will do.
16002 (Fsubstitute_command_keys): Check for string overflow.
16003
16004 * editfns.c (set_time_zone_rule): Don't assume environment length
16005 fits in int.
16006 (message_length): Now ptrdiff_t, not int.
16007 (Fmessage_box): Don't update size until allocation succeeds.
16008 Don't assume message length fits in int.
16009 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
16010
0065d054
PE
16011 * emacs.c (main): Do not reallocate argv, since there is a null at
16012 the end that can be overwritten, and this way there's no need to
16013 worry about size-calculation overflow.
16014 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
16015
16016 * eval.c (init_eval_once, grow_specpdl): Don't update size until
16017 alloc succeeds.
16018 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
16019
16020 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
16021 (x_set_scroll_bar_width, x_figure_window_size):
16022 Check for integer overflow.
16023 (x_set_alpha): Do not assume XINT fits in int.
16024
16025 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
16026 This is for the members text_lines, text_cols, total_lines, total_cols,
16027 where the system imposes an 'int' limit.
16028
16029 * fringe.c (Fdefine_fringe_bitmap):
16030 Don't update size until alloc works.
16031
16032 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
16033 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
16034
16035 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
16036 Check for size-calculation overflow.
16037 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
16038 do, as we prefer signed integers.
16039 (id_to_widget.max_size, id_to_widget.used)
16040 (xg_store_widget_in_map, xg_remove_widget_from_map)
16041 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
16042 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
16043 Use and return ptrdiff_t, not int.
16044 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
16045 * gtkutil.h: Change prototypes to match the above.
16046
16047 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
16048 are duplicate now that they've been promoted to lisp.h.
16049 (x_allocate_bitmap_record, x_alloc_image_color)
16050 (make_image_cache, cache_image, xpm_load):
16051 Don't update size until alloc is done.
16052 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
16053 (x_detect_edges):
3256efce 16054 Check for size calculation overflow.
726e0ab1
PE
16055 (ct_colors_allocated_max): New constant.
16056 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
16057 overflow.
3256efce 16058
726e0ab1
PE
16059 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
16060 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
16061 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
16062 Use ptrdiff_t, not int, to count maps.
16063 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
16064 calculations. Don't update size until allocation succeeds.
16065 Redo calculations to avoid overflow.
726e0ab1
PE
16066 * keyboard.h: Change prototypes to match the above.
16067
16068 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
16069 to count maps.
16070 (current_minor_maps): Check for size calculation overflow.
16071 * keymap.h: Change prototypes to match the above.
16072
16073 * lread.c (read1, init_obarray): Don't update size until alloc done.
16074
16075 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
16076 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
16077
726e0ab1
PE
16078 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
16079 Now ptrdiff_t, not int.
16080 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
16081 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
16082
16083 * process.c (Fnetwork_interface_list): Check for overflow
16084 in size calculation.
16085
16086 * region-cache.c (move_cache_gap): Check for size calculation overflow.
16087
16088 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
16089 overflow. Don't bother calling xmalloc when xrealloc will do.
16090
16091 * search.c (Freplace_match): Check for size calculation overflow.
16092 (Fset_match_data): Don't assume list lengths fit in 'int'.
16093
16094 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
16095 for command line length. Do not attempt to address one before the
16096 beginning of an array, as that's not portable.
16097
16098 * term.c (max_frame_lines): Remove; unused.
16099 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
16100 not int.
16101 (encode_terminal_code, calculate_costs): Check for size
16102 calculation overflow.
16103 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
16104 table lengths and related sizes. Don't update size until alloc
16105 done. Redo calculations to avoid overflow.
16106 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
16107
16108 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
16109 subtracting pointers.
16110 (gobble_line): Check for overflow more carefully. Don't update size
16111 until alloc done.
16112
16113 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
16114 Don't update size until alloc done.
16115 Redo size calculations to avoid overflow.
16116 Check for size calculation overflow.
0065d054 16117 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
16118
16119 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
16120 Use ptrdiff_t, not int, for sizes.
16121 (store_mode_line_noprop_char): Don't update size until alloc done.
16122
0065d054
PE
16123 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
16124 Use ptrdiff_t, not int, for sizes.
16125 (Finternal_make_lisp_face, cache_face):
16126 Check for size calculation overflow.
16127 (cache_face): Treat size calculation overflows as if they were
16128 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
16129
16130 * xfns.c (x_encode_text, x_set_name_internal)
16131 (Fx_change_window_property): Use ptrdiff_t, not int, to count
16132 sizes, since they can exceed INT_MAX in size. Check for size
16133 calculation overflow.
16134
0065d054
PE
16135 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
16136 (xg_select): Check for size calculation overflow.
726e0ab1
PE
16137 Don't update size until alloc done.
16138
0065d054 16139 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 16140 as sprintf is limited to int lengths.
1d526e2f 16141
252c5ee1
PE
16142 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
16143 (X_LONG_MIN): New macros.
864d7ce7
PE
16144 Use them to make the following changes clearer.
16145 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
16146 This change doesn't affect the value now, but it may help remind
16147 future maintainers not to raise the value too much later.
16148 (SELECTION_QUANTUM): Remove, replacing with ...
16149 (selection_quantum): ... new function, which avoids overflow.
16150 All uses changed.
16151 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
16152 assumption that selection length fits in 'int'.
16153 (x_reply_selection_request, x_handle_selection_request)
16154 (x_get_window_property, receive_incremental_selection)
16155 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
16156 (lisp_data_to_selection_data, clean_local_selection_data):
16157 Use ptrdiff_t, not int, to record length of selection.
16158 (x_reply_selection_request, x_get_window_property)
16159 (receive_incremental_selection, x_property_data_to_lisp):
16160 Redo calculations to avoid overflow.
16161 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 16162 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
16163 something.
16164 (x_get_window_property, receive_incremental_selection)
16165 (lisp_data_to_selection_data, x_property_data_to_lisp):
16166 Check for size-calculation overflow.
16167 (x_get_window_property, receive_incremental_selection)
16168 (lisp_data_to_selection_data, Fx_register_dnd_atom):
16169 Don't store size until memory allocation succeeds.
16170 (x_get_window_property): Plug memory leak on memory exhaustion.
16171 Don't double-block input; malloc is safe here. Don't assume 2**34
16172 - 4 fits in unsigned long. Add an xassert to check
16173 XGetWindowProperty overflow. Be more careful about overflow
16174 calculations, and distinguish size from memory overflow better.
16175 (receive_incremental_selection): When tracing, don't assume
16176 unsigned int is less than INT_MAX.
16177 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
16178 harmful) conversions of unsigned short to int.
16179 (lisp_data_to_selection_data): Don't assume that integers
16180 in the range -65535 through -1 fit in an X unsigned short.
16181 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
16182 result parameters unless successful. Rely on cons_to_unsigned
16183 to report problems with elements; the old code wasn't right anyway.
16184 (x_check_property_data): Check for int overflow; we cannot use
16185 a wider type due to X limits.
16186 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
16187
726e0ab1 16188 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 16189
0065d054
PE
16190 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
16191 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
16192 (x_color_cells): Don't store size until memory allocation succeeds.
16193 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 16194 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
16195 (x_term_init): Don't assume length fits in int (sprintf is limited
16196 to int size).
bc18e09d 16197
ebfa62c0
PE
16198 Use ptrdiff_t for composition IDs.
16199 * character.c (lisp_string_width):
16200 * composite.c (composition_table_size, n_compositions)
16201 (get_composition_id, composition_gstring_from_id):
16202 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
16203 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
16204 * window.c (Frecenter):
16205 Use ptrdiff_t, not int, for composition IDs.
16206 * composite.c (get_composition_id): Check for integer overflow.
16207 * composite.h: Adjust prototypes to match the above changes.
16208
d3411f89
PE
16209 Use ptrdiff_t for hash table indexes.
16210 * category.c (hash_get_category_set):
16211 * ccl.c (ccl_driver):
16212 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
16213 * coding.c (coding_system_charset_list, detect_coding_system):
16214 * coding.h (struct coding_system.id):
16215 * composite.c (get_composition_id, gstring_lookup_cache):
16216 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
16217 * image.c (xpm_get_color_table_h):
16218 * lisp.h (hash_lookup, hash_put):
16219 * minibuf.c (Ftest_completion):
16220 Use ptrdiff_t for hash table indexes, not int (which is too
16221 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
16222 32-bit --with-wide-int hosts).
16223
e097a6fa
PE
16224 * charset.c (Fdefine_charset_internal): Check for integer overflow.
16225 Add a FIXME comment about memory leaks.
16226 (syms_of_charset): Don't assume xmalloc returns.
16227
5637687f
PE
16228 Don't assume that stated character widths fit in int.
16229 * character.c (Fchar_width, c_string_width, lisp_string_width):
16230 * character.h (CHAR_WIDTH):
16231 * indent.c (MULTIBYTE_BYTES_WIDTH):
16232 Use sanitize_char_width to avoid undefined and/or bad behavior
16233 with outlandish widths.
a66cfb1c 16234 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
16235 now that we have two such functions. All uses changed.
16236 (sanitize_char_width): New inline function.
16237
a2271ba2
PE
16238 Don't assume that tab-width fits in int.
16239 * character.h (sanitize_width): New inline function.
16240 (SANE_TAB_WIDTH): New macro.
16241 (ASCII_CHAR_WIDTH): Use it.
16242 * indent.c (sane_tab_width): Remove. All uses replaced by
16243 SANE_TAB_WIDTH (current_buffer).
16244 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
16245
18c52557
PE
16246 * fileio.c: Integer overflow issues with file modes.
16247 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
16248
caeeedc1
PE
16249 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
16250 Remove unreachable code.
16251 (read_hex, load_charset_map_from_file): Check for integer overflow.
16252
6df6ae42 16253 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
16254 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
16255 (x_send_scroll_bar_event): Likewise. Check that the size does not
16256 exceed limits imposed by XClientMessageEvent, as well as the usual
16257 ptrdiff_t and size_t limits.
16258
b13995db
PE
16259 * keyboard.c: Overflow, signedness and related fixes.
16260 (make_lispy_movement): Use same integer type in forward decl
16261 that is used in the definition.
16262 (read_key_sequence, keyremap_step):
16263 Change bufsize argument back to int, undoing my 2011-03-30 change.
16264 We prefer signed types, and int is wide enough here.
16265 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
16266 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
16267 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
16268 length, not size_t. Use ptrdiff_t for index, not int.
16269 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
16270 possibility of integer overflow.
16271
13464394
PE
16272 Overflow, signedness and related fixes for images.
16273
16274 * dispextern.h (struct it.stack[0].u.image.image_id)
16275 (struct_it.image_id, struct image.id, struct image_cache.size)
16276 (struct image_cache.used, struct image_cache.ref_count):
16277 * gtkutil.c (update_frame_tool_bar):
16278 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
16279 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
16280 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
16281 * nsmenu.m (update_frame_tool_bar):
16282 * xdisp.c (calc_pixel_width_or_height):
16283 * xfns.c (image_cache_refcount):
16284 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
16285 on typical 64-bit hosts.
16286
16287 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
16288 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
16289 Omit unnecessary casts to int.
16290 (parse_image_spec): Check that integers fall into 'int' range
16291 when the callers expect that.
16292 (image_ascent): Redo ascent calculation to avoid int overflow.
16293 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
16294 (lookup_image): Remove unnecessary tests.
16295 (xbm_image_p): Locals are now of int, not EMACS_INT,
16296 since parse_image_check makes sure they fit into int.
16297 (png_load, gif_load, svg_load_image):
16298 Prefer int to unsigned where either will do.
16299 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
16300 old tiff_error_handler and tiff_warning_handler.
16301 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
16302 stack buffer overflows. It uses only the features of vsnprintf
16303 that are common to both POSIX and native Microsoft.
16304 (tiff_error_handler, tiff_warning_handler): Use it.
16305 (tiff_load, gif_load, imagemagick_load_image):
16306 Don't assume :index value fits in 'int'.
16307 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
16308 (imagemagick_load_image): Check that crop parameters fit into
16309 the integer types that MagickCropImage accepts. Don't assume
16310 Vimagemagick_render_type has a nonnegative value. Don't assume
16311 size_t fits in 'long'.
16312 (gs_load): Use printmax_t to print the widest integers possible.
16313 Check for integer overflow when computing image height and width.
16314
c11821d4
EZ
163152011-08-26 Eli Zaretskii <eliz@gnu.org>
16316
16317 * xdisp.c (redisplay_window): Don't force window start if point
16318 will be invisible in the resulting window. (Bug#9324)
16319
0c95fcf7
EZ
163202011-08-25 Eli Zaretskii <eliz@gnu.org>
16321
16322 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
16323 the display spec is of the form `(space ...)'.
16324 (handle_display_spec): Return the value returned by
16325 handle_single_display_spec, not just 1 or zero.
16326 (handle_single_display_spec): If the display spec is of the form
16327 `(space ...)', and specifies display in the text area, return 2
16328 rather than 1.
fee65a97 16329 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
16330 accurately, and prefer exact match for point under bidi.
16331 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
16332
16333 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
16334 into disp_prop; all users changed.
16335
16336 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
16337 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
16338 for the text covered by the display property.
16339
e4ed06f1
CY
163402011-08-25 Chong Yidong <cyd@stupidchicken.com>
16341
16342 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
16343 Change return value to nil.
16344 (Frecord_buffer): Delete unused function.
16345
f67cdd7f
EZ
163462011-08-24 Eli Zaretskii <eliz@gnu.org>
16347
5980d4c6
EZ
16348 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
16349 buffers, return left-to-right.
8610fe8b
EZ
16350 (set_cursor_from_row): Consider candidate row a win if its glyph
16351 represents a newline and point is on that newline. Fixes cursor
16352 positioning on the newline at EOL of R2L text within L2R
16353 paragraph, and vice versa.
16354 (try_cursor_movement): Check continued rows, in addition to
16355 continuation rows. Fixes unwarranted scroll when point enters a
16356 continued line of R2L text within an L2R paragraph, or vice versa.
16357 (cursor_row_p): Consider the case of point being equal to
16358 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
16359 from the end of a short line to the beginning of a continued line
16360 of R2L text within L2R paragraph.
16361 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
16362 composed characters.
5980d4c6 16363
f67cdd7f
EZ
16364 * bidi.c (bidi_check_type): Use xassert.
16365 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
16366 members.
16367
bca633fb
EZ
163682011-08-23 Eli Zaretskii <eliz@gnu.org>
16369
16370 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
16371 a character.
16372
4a5885a7
CY
163732011-08-23 Chong Yidong <cyd@stupidchicken.com>
16374
16375 * nsfont.m (ns_otf_to_script): Fix typo.
16376
0902a04e
KH
163772011-08-22 Kenichi Handa <handa@m17n.org>
16378
16379 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
16380 extra slot even if the purpose is char-code-property-table.
16381
1a2e6670
EZ
163822011-08-23 Eli Zaretskii <eliz@gnu.org>
16383
8ddde651
EZ
16384 * xdisp.c (redisplay_window): When computing centering_position,
16385 account for the height of the header line. (Bug#8874)
16386
425cc014
EZ
16387 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
16388 instead of CHAR_TO_BYTE. Fixes a crash when a completion
16389 candidate is selected by the mouse, and that candidate has a
16390 composed character under the mouse.
16391
1a2e6670
EZ
16392 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
16393 coordinates reported by pos-visible-in-window-p for a composed
16394 character in column zero.
16395
8b76d6f8
SM
163962011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
16397
16398 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
16399
dac347dd
EZ
164002011-08-22 Eli Zaretskii <eliz@gnu.org>
16401
16402 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
16403 consider it a hit if to_charpos is anywhere in the range of the
16404 composed buffer positions.
16405
e013fb34
CY
164062011-08-22 Chong Yidong <cyd@stupidchicken.com>
16407
16408 * image.c (gif_load): Don't assume that each subimage has the same
16409 dimensions as the base image. Handle disposal method that is
16410 "undefined" by the gif spec (Bug#9335).
16411
bd1ba3e8
CY
164122011-08-20 Chong Yidong <cyd@stupidchicken.com>
16413
16414 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 16415 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 16416
54a1215b
EZ
164172011-08-19 Eli Zaretskii <eliz@gnu.org>
16418
823564e5
EZ
16419 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
16420 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
16421 from an Org mode buffer to a Speedbar frame.
16422
54a1215b
EZ
16423 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
16424 a composition, take its buffer position from IT->cmp_it.charpos.
16425 Fixes cursor positioning at the beginning of a line that begins
16426 with a composed character.
16427
9778ebcc
EZ
164282011-08-18 Eli Zaretskii <eliz@gnu.org>
16429
0be6ee06
EZ
16430 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
16431 character bidirectional type, use STRONG_L instead. Fixes crashes
16432 in a buffer produced by `describe-categories'.
16433
9778ebcc
EZ
16434 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
16435 members before the level stack, so they would be saved and
16436 restored when copying iterator state. Fixes incorrect reordering
16437 around TABs covered by display properties.
16438
156bffbe
AS
164392011-08-18 Andreas Schwab <schwab@linux-m68k.org>
16440
6b02f655 16441 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 16442
72ad093b
CY
164432011-08-17 Chong Yidong <cyd@stupidchicken.com>
16444
16445 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
16446 (internal_condition_case_2, internal_condition_case_n):
16447 Remove unnecessary aborts (Bug#9081).
72ad093b 16448
35774242
EZ
164492011-08-17 Eli Zaretskii <eliz@gnu.org>
16450
16451 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
16452 has no `load' handler, try opening the file locally. (Bug#9311)
16453
db76dd85
KB
164542011-08-16 Ken Brown <kbrown@cornell.edu>
16455
16456 * gmalloc.c: Expand comment.
16457
b215eee5
EZ
164582011-08-16 Eli Zaretskii <eliz@gnu.org>
16459
16460 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
16461 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
16462
a4579d33
KB
164632011-08-16 Ken Brown <kbrown@cornell.edu>
16464
16465 Fix memory allocation problems in Cygwin build (Bug#9273).
16466
16467 * unexcw.c ( __malloc_initialized): Declare external variable.
16468 (fixup_executable): Force the dumped emacs to reinitialize malloc.
16469
8b76d6f8
SM
16470 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
16471 New variables.
a4579d33
KB
16472 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
16473 dumped emacs.
16474 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
16475 in the static heap.
16476 [CYGWIN] (special_realloc): New function.
16477 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
16478 requests to realloc storage in the static heap.
16479
3ebec551
PE
164802011-08-15 Paul Eggert <eggert@cs.ucla.edu>
16481
16482 * bidi.c (bidi_initialize): Remove unused local.
16483
9fd8be00
EZ
164842011-08-15 Eli Zaretskii <eliz@gnu.org>
16485
6b02f655
SM
16486 * bidimirror.h:
16487 * biditype.h: Remove file.
16488 * makefile.w32-in ($(BLD)/bidi.$(O)):
16489 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
16490
16491 * dispextern.h: Fix a typo in the comment to bidi_type_t.
16492
16493 * chartab.c: Improve commentary for the uniprop_table API.
16494
32413314
EZ
16495 * bidi.c (bidi_paragraph_init): Support zero value of
16496 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
16497 (bidi_initialize): Use uniprop_table instead of including
16498 biditype.h and bidimirror.h.
32413314 16499
9fd8be00
EZ
16500 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
16501 coordinates of the iterator when restoring from ppos_it.
16502 (Bug#9296)
16503
5cf2b69b
KH
165042011-08-14 Kenichi Handa <handa@m17n.org>
16505
16506 * process.c (create_process): Call setup_process_coding_systems
72ad093b 16507 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 16508
daf17d00
EZ
165092011-08-14 Eli Zaretskii <eliz@gnu.org>
16510
16511 * xdisp.c (move_it_in_display_line_to): Don't invoke
16512 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
16513 ppos_it. Fixes vertical cursor motion when line beginning is
16514 covered by an image. (Bug#9296)
16515
08e3161a
JD
165162011-08-14 Jan Djärv <jan.h.d@swipnet.se>
16517
16518 * nsterm.h (ns_run_ascript): Declare.
16519 (NSAPP_DATA2_RUNASSCRIPT): Define.
16520
16521 * nsfns.m (as_script, as_result, as_status): New static variables.
16522 (ns_run_ascript): New function.
5e617bc2 16523 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
16524 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
16525 the event loop. Get status from as_status (Bug#7276).
16526
16527 * nsterm.m (sendEvent): If event is NSApplicationDefined and
16528 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
16529 the event loop (Bug#7276).
16530
a3720aa2
AS
165312011-08-14 Andreas Schwab <schwab@linux-m68k.org>
16532
16533 * gnutls.c (QCgnutls_bootprop_priority)
16534 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
16535 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
16536 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
16537 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
16538 (QCgnutls_bootprop_verify_hostname_error)
16539 (QCgnutls_bootprop_callbacks_verify): Rename from
16540 Qgnutls_bootprop_..., all uses changed.
16541
16542 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
16543 uses changed.
16544
0a0d27fb
PE
165452011-08-14 Paul Eggert <eggert@cs.ucla.edu>
16546
19d5c50c
PE
16547 * xfaces.c (Qframe_set_background_mode): Now static.
16548 * dispextern.h (Qframe_set_background_mode): Remove decl.
16549
0a0d27fb
PE
16550 * process.c (Fnetwork_interface_info): Declare local only if needed.
16551
377538cb
JD
165522011-08-13 Jan Djärv <jan.h.d@swipnet.se>
16553
16554 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
16555 (Fnetwork_interface_list): Allocate in increments of bytes instead
16556 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
16557 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
16558 sockaddr.
16559 (struct ifflag_def): notrailers is smart on OSX.
16560 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
16561 Get hardware address with getifaddrs if available.
16562
08fff70c
EZ
165632011-08-12 Eli Zaretskii <eliz@gnu.org>
16564
16565 * xdisp.c (iterate_out_of_display_property): xassert that
16566 IT->position is set to within IT->object's boundaries. Break from
16567 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
16568 when IT->position is set up wrongly due to some bug.
16569 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
16570 (push_display_prop): Allow GET_FROM_STRING as IT->method on
16571 entry. Force push_it to save on the stack the current
16572 buffer/string position, to be restored by pop_it. Fix flags in
16573 the iterator structure wrt the object coming from a display
16574 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
16575 properties. (Bug#9284)
16576
7be1c708 165772011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 16578
7be1c708
CY
16579 * fontset.c (fontset_get_font_group): Add proper type checks.
16580 (Bug#9172)
aac0c6e3 16581
7be1c708 165822011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 16583
7be1c708
CY
16584 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
16585 and LC_VERSION_MIN_MACOSX.
16586 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
16587 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 16588
97bb72a6
EZ
165892011-08-08 Eli Zaretskii <eliz@gnu.org>
16590
16591 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
16592 no-display-properties-and-no-overlays under bidi display.
16593 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 16594 properties and overlays.
97bb72a6 16595
d5617611
CY
165962011-08-08 Chong Yidong <cyd@stupidchicken.com>
16597
37e11a63
CY
16598 * editfns.c (Fset_time_zone_rule): Document relationship with the
16599 setenv function.
16600
d5617611
CY
16601 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
16602 the font entity extracted from the cache (Bug#8109).
16603
58872834
CY
166042011-08-07 Chong Yidong <cyd@stupidchicken.com>
16605
16606 * composite.c (autocmp_chars): Don't reset point. That is done by
16607 restore_point_unwind (Bug#5984).
16608
75bfc667
JL
166092011-08-07 Juri Linkov <juri@jurta.org>
16610
16611 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
16612 to show the arg `TIME' instead of `TIMEVAL'.
16613
d1410150
EZ
166142011-08-06 Eli Zaretskii <eliz@gnu.org>
16615
16616 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
16617 display property strides EOL and includes a newline, as in
16618 longlines-mode. (Bug#9254)
75b771e4
EZ
16619 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
16620 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
16621
16622 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
16623 is non-zero, even if the data buffer is NULL. Fixes a crash in
16624 vertical-motion with longlines-mode. (Bug#9254)
16625
35928349
EZ
166262011-08-05 Eli Zaretskii <eliz@gnu.org>
16627
ec7cc85b
EZ
16628 * bidi.c <bidi_cache_total_alloc>: Now static.
16629 (bidi_initialize): Initialize bidi_cache_total_alloc.
16630
8b76d6f8 16631 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
16632 cache. (Bug#9221)
16633
16634 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
16635 amount allocated this far in `bidi_cache_total_alloc'.
16636 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
16637 non-zero, only free the data buffer without restoring the cache
16638 contents. All callers changed.
16639
16640 * dispextern.h (bidi_unshelve_cache): Update prototype.
16641
16642 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
16643 (move_it_in_display_line, move_it_to)
16644 (move_it_vertically_backward, move_it_by_lines): Replace the call
16645 to xfree to an equivalent call to bidi_unshelve_cache.
16646 (move_it_in_display_line_to): Fix logic of returning
412b6358 16647 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 16648
e2e2423b
EZ
166492011-08-05 Eli Zaretskii <eliz@gnu.org>
16650
16651 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
16652 came from a string character with a `cursor' property. (Bug#9229)
16653
ae9e757a
JD
166542011-08-04 Jan Djärv <jan.h.d@swipnet.se>
16655
16656 * Makefile.in (LIB_PTHREAD): New variable.
16657 (LIBES): Add LIB_PTHREAD (Bug#9216).
16658
16659 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
16660 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
16661
213bd7f2
AS
166622011-08-04 Andreas Schwab <schwab@linux-m68k.org>
16663
6b02f655 16664 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 16665
99aaf75f
JD
166662011-08-04 Jan Djärv <jan.h.d@swipnet.se>
16667
16668 * xterm.c (x_find_topmost_parent): New function.
16669 (x_set_frame_alpha): Find topmost parent window with
16670 x_find_topmost_parent and set the property there also (bug#9181).
16671 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
16672
c74e9d86
PE
166732011-08-04 Paul Eggert <eggert@cs.ucla.edu>
16674
16675 * callproc.c (Fcall_process): Avoid vfork clobbering
16676 the local vars buffer, coding_systems, current_dir.
16677
640c8776
SM
166782011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
16679
16680 * keymap.c (Fmake_composed_keymap): Move to subr.el.
16681
f26d0e4c
PE
166822011-08-03 Paul Eggert <eggert@cs.ucla.edu>
16683
8a10d76c
PE
16684 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
16685 so that it is not optimized away.
16686
f26d0e4c
PE
16687 * xdisp.c (compute_display_string_pos): Remove unused local.
16688
55439c61
EZ
166892011-08-02 Eli Zaretskii <eliz@gnu.org>
16690
16691 Fix slow cursor motion and scrolling in large buffers with
16692 selective display, like Org Mode buffers. (Bug#9218)
16693
16694 * dispextern.h (struct bidi_it): New member disp_prop_p.
16695
16696 * xdisp.c: Remove one-slot cache of display string positions.
16697 (compute_display_string_pos): Accept an additional argument
5e617bc2 16698 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
16699 for a display string or property. If found, set DISP_PROP_P
16700 non-zero.
16701
16702 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
16703 DISP_PROP_P, and pass it to compute_display_string_pos.
16704 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
16705 non-zero. All callers of bidi_fetch_char changed.
16706
fb33fa43
SM
167072011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
16708
16709 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
16710
b099e063
DM
167112010-12-03 Don March <don@ohspite.net>
16712
16713 * keymap.c (Fdefine_key): Fix non-prefix key error message when
16714 last character M-[char] is translated to ESC [char] (bug#7541).
16715
5cc7f7af
KH
167162011-08-02 Kenichi Handa <handa@m17n.org>
16717
d0fffa3f 16718 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
16719
16720 * chartab.c (uniprop_table): Make it non-static.
16721
525d5e6e
EZ
167222011-08-01 Eli Zaretskii <eliz@gnu.org>
16723
16724 * xdisp.c (forward_to_next_line_start): Accept additional argument
16725 BIDI_IT_PREV, and store into it the state of the bidi iterator had
16726 on the newline.
16727 (reseat_at_next_visible_line_start): Use the bidi iterator state
16728 returned by forward_to_next_line_start to restore the state of
16729 it->bidi_it after backing up to previous newline. (Bug#9212)
16730
31011111
AS
167312011-07-30 Andreas Schwab <schwab@linux-m68k.org>
16732
16733 * regex.c (re_comp): Protoize.
16734 (re_exec): Fix return type.
16735 (regexec): Fix type of `ret'. (Bug#9203)
16736
476371c4
PE
167372011-07-28 Paul Eggert <eggert@cs.ucla.edu>
16738
e5d76069
PE
16739 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
16740 This is needed if max-image-size is a floating-point number.
16741
9a79b20c
AS
167422011-07-28 Andreas Schwab <schwab@linux-m68k.org>
16743
16744 * print.c (print_object): Print empty symbol as ##.
16745
16746 * lread.c (read1): Read ## as empty symbol.
16747
d8c2fa78
AA
167482011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
16749
16750 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
16751 setting frame foreground color (Bug#9175).
16752 (x_set_background_color): Likewise.
16753
ffe57a7a
AA
16754 * nsmenu.m (-setText): Size tooltip dimensions precisely to
16755 contents (Bug#9176).
16756 (EmacsTooltip -init): Remove bezels and add shadows to
16757 tooltip windows.
16758
bf3492a5
AA
16759 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
16760 or scroll bar (Bug#8470).
16761
d55e9c53
AA
16762 * nsfont.m (nsfont_open): Remove assignment to voffset and
16763 unnecessary vars hshink, expand, hd, full_height, min_height.
16764 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
16765
16766 * nsterm.h (nsfont_info): Remove voffset field.
16767
d8c2fa78 167682011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
16769
16770 Implement strike-through and overline on NextStep (Bug#8863).
16771
16772 * nsfont.m (nsfont_open): Use underline position provided by font,
16773 instead of hard-coded value of 2.
16774 (nsfont_draw): Call ns_draw_text_decoration instead.
16775
16776 * nsterm.h: Add declaration for ns_draw_text_decoration.
16777
16778 * nsterm.m (ns_draw_text_decoration): New function for drawing
16779 underline, overline, and strike-through.
16780 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
16781 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 16782 accommodate underlining, etc.
4843aac3 16783
4cc60b9b
EZ
167842011-07-28 Eli Zaretskii <eliz@gnu.org>
16785
bc7ece87
EZ
16786 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
16787 default.
4cc60b9b 16788
476371c4
PE
167892011-07-28 Paul Eggert <eggert@cs.ucla.edu>
16790
66606eea
PE
16791 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
16792 Without this fix, if a signal arrives just after memory fills up,
16793 'malloc' might be invoked reentrantly.
16794
476371c4
PE
16795 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
16796 In other words, assume that every image size is allowed, on non-X
16797 hosts. This assumption is probably wrong, but it lets Emacs compile.
16798
f3fcc40d
AS
167992011-07-28 Andreas Schwab <schwab@linux-m68k.org>
16800
16801 * regex.c (re_iswctype): Convert return values to boolean.
16802
350c992f
EZ
168032011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
16804
16805 * xdisp.c (compute_display_string_pos): Don't use cached display
16806 string position if the buffer had its restriction changed.
16807 (Bug#9184)
16808
5266b4bb
PE
168092011-07-28 Paul Eggert <eggert@cs.ucla.edu>
16810
16811 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
16812
2573a837 168132011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 16814
41f55ccd 16815 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 16816
39e378da
PE
16817 * bidi.c: Integer size and overflow fixes.
16818 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
16819 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
16820 (bidi_cache_find_level_change, bidi_cache_ensure_space)
16821 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
16822 (bidi_find_other_level_edge):
16823 Use ptrdiff_t instead of EMACS_INT where either will do.
16824 This works better on 32-bit hosts configured --with-wide-int.
16825 (bidi_cache_ensure_space): Check for size-calculation overflow.
16826 Use % rather than repeated addition, for better worst-case speed.
16827 Don't set bidi_cache_size until after xrealloc returns, because it
16828 might not return.
16829 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
16830 (bidi_cache_ensure_space): Also check that the bidi cache size
16831 does not exceed that of the largest Lisp string or buffer. See Eli
16832 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 16833
5e927815
PE
16834 * alloc.c (__malloc_size_t): Remove.
16835 All uses replaced by size_t. See Andreas Schwab's note
16836 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
16837
ca4aa935
PE
16838 * image.c: Improve checking for integer overflow.
16839 (check_image_size): Assume that f is nonnull, since
16840 it is always nonnull in practice. This is one less thing to
16841 worry about when checking for integer overflow later.
16842 (x_check_image_size): New function, which checks for integer
16843 overflow issues inside X.
16844 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
16845 This removes the need for a memory_full check.
16846 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
16847 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
16848 (xbm_read_bitmap_data): Change locals back to 'int', since
16849 their values must fit in 'int'.
16850 (xpm_load_image, png_load, tiff_load):
16851 Invoke x_create_x_image_and_pixmap earlier,
16852 to avoid much needless work if the image is too large.
16853 (tiff_load): Treat overly large images as if
16854 x_create_x_image_and_pixmap failed, not as malloc failures.
16855 (gs_load): Use x_check_image_size.
16856
5f8f9cc2
PE
16857 * gtkutil.c: Omit integer casts.
16858 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
16859 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
16860
5adf60bc
PE
16861 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
16862
c8907a93
PE
16863 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
16864 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
16865 would wrongly return t on a 64-bit host.
16866
e3c25c68
PE
16867 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
16868 The plain *_OVERFLOW macros run afoul of GCC bug 49705
16869 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
16870 and therefore cause GCC to emit a bogus diagnostic in some cases.
16871
3f791afe
PE
16872 * image.c: Integer signedness and overflow and related fixes.
16873 This is not an exhaustive set of fixes, but it's time to
16874 record what I've got.
16875 (lookup_pixel_color, check_image_size): Remove redundant decls.
16876 (check_image_size): Don't assume that arbitrary EMACS_INT values
16877 fit in 'int', or that arbitrary 'double' values fit in 'int'.
16878 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
16879 (tiff_load, imagemagick_load_image):
16880 Check for overflow in size calculations.
16881 (x_create_x_image_and_pixmap): Remove unnecessary test for
16882 xmalloc returning NULL; that can't happen.
16883 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
16884 (xpm_color_bucket): Use better integer hashing function.
16885 (xpm_cache_color): Don't possibly over-allocate memory.
16886 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
16887 (gif_memory_source):
16888 Use ptrdiff_t, not int or size_t, to record sizes.
16889 (png_load): Don't assume values greater than 2**31 fit in 'int'.
16890 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
16891 either works, as we prefer signed integers.
16892 (tiff_read_from_memory, tiff_write_from_memory):
16893 Return tsize_t, not size_t, since that's what the TIFF API wants.
16894 (tiff_read_from_memory): Don't fail simply because the read would
16895 go past EOF; instead, return a short read.
16896 (tiff_load): Omit no-longer-needed casts.
16897 (Fimagemagick_types): Don't assume size fits into 'int'.
16898
3cc5a532
PE
16899 Improve hashing quality when configured --with-wide-int.
16900 * fns.c (hash_string): New function, taken from sxhash_string.
16901 Do not discard information about ASCII character case; this
16902 discarding is no longer needed.
16903 (sxhash-string): Use it. Change sig to match it. Caller changed.
16904 * lisp.h: Declare it.
16905 * lread.c (hash_string): Remove, since we now use fns.c's version.
16906 The fns.c version returns a wider integer if --with-wide-int is
16907 specified, so this should help the quality of the hashing a bit.
16908
b312a492
PE
16909 * emacs.c: Integer overflow minor fix.
16910 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
16911 Define only if GNU_LINUX.
16912 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
16913
dfd153ae
PE
16914 * dispnew.c: Integer signedness and overflow fixes.
16915 Remove unnecessary forward decls, that were a maintenance hassle.
16916 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
16917 All uses changed.
16918 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
16919 (scrolling_window): Use ptrdiff_t, not int, for byte count.
16920 (prepare_desired_row, line_draw_cost):
16921 Use int, not unsigned, where either works.
16922 (save_current_matrix, restore_current_matrix):
16923 Use ptrdiff_t, not size_t, where either works.
16924 (init_display): Check for overflow more accurately, and without
16925 relying on undefined behavior.
16926
a81d11a3
PE
16927 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
16928 Remove, replacing with the new symbols in lisp.h. All uses changed.
16929 * fileio.c (make_temp_name):
16930 * filelock.c (lock_file_1, lock_file):
16931 * xdisp.c (message_dolog):
16932 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
16933 Use pMd etc. instead.
16934 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
16935 replacing the pWIDE etc. symbols removed from editfns.c.
16936
3300e6fd
PE
16937 * keyboard.h (num_input_events): Now uintmax_t.
16938 This is (very slightly) less likely to mess up due to wraparound.
16939 All uses changed.
16940
fd05c7e9
PE
16941 * buffer.c: Integer signedness fixes.
16942 (alloc_buffer_text, enlarge_buffer_text):
16943 Use ptrdiff_t rather than size_t when either will do, as we prefer
16944 signed integers.
16945
903fe15d
PE
16946 * alloc.c: Integer signedness and overflow fixes.
16947 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
16948 (__malloc_size_t): Default to size_t, not to int.
16949 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
16950 (Fgarbage_collect, mark_object_loop_halt, mark_object):
16951 Prefer ptrdiff_t to size_t when either would do, as we prefer
16952 signed integers.
16953 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
16954 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
16955 Now const. Initialize with values that are in range even if char
16956 is signed.
16957 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
16958 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
16959 These functions do the right thing with sizes > 2**32.
16960 (check_depth): Now ptrdiff_t, not int.
16961 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
16962 Adjust to new way of storing sizes. Check for size overflow bugs
16963 in rest of code.
16964 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
16965 slightly wrong anyway, as it missed one instance of
16966 XMALLOC_OVERRUN_CHECK_OVERHEAD.
16967 (refill_memory_reserve): Omit needless cast to size_t.
16968 (mark_object_loop_halt): Mark as externally visible.
16969
ac82cc6a
PE
16970 * xselect.c: Integer signedness and overflow fixes.
16971 (Fx_register_dnd_atom, x_handle_dnd_message):
16972 Use ptrdiff_t, not size_t, since we prefer signed.
16973 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
16974 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
16975 x_dnd_atoms_size and x_dnd_atoms_length.
16976
c2d1e36d
PE
16977 * doprnt.c: Prefer signed to unsigned when either works.
16978 * eval.c (verror):
16979 * doprnt.c (doprnt):
16980 * lisp.h (doprnt):
16981 * xdisp.c (vmessage):
16982 Use ptrdiff_t, not size_t, when using or implementing doprnt,
16983 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
16984 prefer signed arithmetic to avoid comparison confusion.
16985 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
16986 but is a bit tricky.
16987
0e926e56
PE
16988 Assume freestanding C89 headers, string.h, stdlib.h.
16989 * data.c, doprnt.c, floatfns.c, print.c:
16990 Include float.h unconditionally.
16991 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
16992 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
16993 * regex.c: Likewise for stddef.h, string.h.
16994 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
16995 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
16996 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
16997 (STDC_HEADERS): Remove obsolete defines.
16998 * sysdep.c: Include limits.h unconditionally.
16999
9cfdb3ec
PE
17000 Assume support for memcmp, memcpy, memmove, memset.
17001 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
17002 * regex.c (memcmp, memcpy):
17003 Remove; we assume C89 now.
17004
17005 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
17006 (__malloc_safe_bcopy): Remove; no longer needed.
17007
cf950e6b 17008 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
17009 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
17010 well either way, and we prefer signed to unsigned.
17011
dbf38e02
LMI
170122011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
17013
17014 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
17015 closes the connection while we're reading (bug#9182).
17016
d6f0886c 170172011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 17018
d6f0886c
JD
17019 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
17020 are specified (Bug#9168).
24e0f6b1 17021
2eb1f9e6
PE
170222011-07-25 Paul Eggert <eggert@cs.ucla.edu>
17023
17024 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
17025 Found by GCC static checking and --with-wide-int on a 32-bit host.
17026
22381272 170272011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
17028
17029 * xdisp.c (compute_display_string_pos): Fix logic of caching
17030 previous display string position. Initialize cached_prev_pos to
17031 -1. Fixes slow-down at the beginning of a buffer.
17032
f25e39b4
EZ
170332011-07-24 Eli Zaretskii <eliz@gnu.org>
17034
17035 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
17036 for attrs[LFACE_FONTSET_INDEX].
17037
04c4b52e
PE
170382011-07-23 Paul Eggert <eggert@cs.ucla.edu>
17039
17040 * xml.c (parse_region): Remove unused local
17041 that was recently introduced.
17042
c1734fbd
EZ
170432011-07-23 Eli Zaretskii <eliz@gnu.org>
17044
be18c5a5
EZ
17045 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
17046 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
17047
c1734fbd
EZ
17048 * xdisp.c (move_it_in_display_line_to): Record the best matching
17049 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
17050 exit if none of the characters scanned was an exact match.
17051 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
17052 when exact match is impossible due to invisible text, and the
17053 lines are truncated.
17054
a258d627
JD
170552011-07-23 Jan Djärv <jan.h.d@swipnet.se>
17056
17057 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
17058 for OSX >= 10.7.
17059
b6d5a689
EZ
170602011-07-22 Eli Zaretskii <eliz@gnu.org>
17061
0f74f785
EZ
17062 Fix a significant slow-down of cursor motion with C-n, C-p,
17063 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
17064 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 17065 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
17066 (next_element_from_buffer): Call compute_stop_pos_backwards to
17067 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
17068 base_level_stop.
17069 (reseat): Don't look for prev_stop, as that could mean a very long
17070 run.
17071 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
17072 <cached_disp_overlay_modiff>: Cache for last found display string
17073 position.
551918c1 17074 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
17075 about the same buffer in the same area of character positions, and
17076 the buffer wasn't changed since the time the display string
17077 position was cached.
551918c1 17078
b2d0c91a
EZ
170792011-07-22 Eli Zaretskii <eliz@gnu.org>
17080
17081 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
17082 is an integer, which is important for empty lines. (Bug#9149)
17083
043604ee
CY
170842011-07-22 Chong Yidong <cyd@stupidchicken.com>
17085
17086 * frame.c (Fmodify_frame_parameters): In tty case, update the
17087 default face if necessary (Bug#4238).
17088
da4adb04
CY
170892011-07-21 Chong Yidong <cyd@stupidchicken.com>
17090
17091 * editfns.c (Fstring_to_char): No need to explain what a character
17092 is in the docstring (Bug#6576).
17093
9abd0532
LMI
170942011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
17095
17096 * xml.c (parse_region): Make sure we always return a tree.
17097
36881d16
HK
170982011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
17099
17100 * xml.c (parse_region): If a document contains only comments,
17101 return that, too.
17102
1e98674d
LMI
171032011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
17104
17105 * xml.c (make_dom): Return comments, too.
17106
590bd467
PE
171072011-07-19 Paul Eggert <eggert@cs.ucla.edu>
17108
17109 Port to OpenBSD.
17110 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
17111 and the surrounding thread.
17112 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
17113 rather than fgets, and retry after EINTR. Otherwise, 'emacs
17114 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
17115 timer goes off.
17116 * s/openbsd.h (BROKEN_SIGIO): Define.
17117 * unexelf.c (unexec) [__OpenBSD__]:
17118 Don't update the .mdebug section of the Alpha COFF symbol table.
17119
f41628b2
LMI
171202011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
17121
17122 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
17123 (bug#8460).
17124
b59b67c5
PE
171252011-07-18 Paul Eggert <eggert@cs.ucla.edu>
17126
15e3a074
PE
17127 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
17128 This fixes some race conditions on the permissions of any newly
17129 created file.
17130
41bed37d
PE
17131 * alloc.c (valid_pointer_p): Use pipe, not open.
17132 This fixes some permissions issues when debugging.
17133
b59b67c5
PE
17134 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
17135 If fchown fails to set both uid and gid, try to set just gid,
17136 as that is sometimes allowed. Adjust the file's mode to eliminate
17137 setuid or setgid bits that are inappropriate if fchown fails.
17138
925a6be7
SM
171392011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
17140
17141 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
17142 to compare Lisp_Objects.
17143 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
17144 global_gnutls_log_level, don't mistake it for a Lisp_Object.
17145 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
17146
52968808
AS
171472011-07-17 Andreas Schwab <schwab@linux-m68k.org>
17148
0a6a104b
AS
17149 * lread.c (read_integer): Unread even EOF character.
17150 (read1): Likewise. Properly record start position of symbol.
17151
52968808
AS
17152 * lread.c (read1): Read `#:' as empty uninterned symbol if no
17153 symbol character follows.
17154
9e381cdd
PE
171552011-07-17 Paul Eggert <eggert@cs.ucla.edu>
17156
17157 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
17158 This works around a problem with the previous change to Fcopy_file.
17159 Recent glibc declares fchown with __attribute__((warn_unused_result)),
17160 and without this change, GCC might complain about discarding
17161 fchown's return value.
17162
b5641435
JB
171632011-07-16 Juanma Barranquero <lekktu@gmail.com>
17164
17165 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
17166
a8031457
PE
171672011-07-16 Paul Eggert <eggert@cs.ucla.edu>
17168
17169 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
17170
dd889327
LMI
171712011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
17172
750c33f7
LMI
17173 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
17174 it's used from the C level.
17175
dd889327
LMI
17176 * process.c: Use the same condition for POLL_FOR_INPUT in both
17177 keyboard.c and process.c (bug#1858).
17178
87e86684
LM
171792011-07-09 Lawrence Mitchell <wence@gmx.li>
17180
17181 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
17182 (Fgnutls_boot): Use it.
17183
64348f40
AS
171842011-07-15 Andreas Schwab <schwab@linux-m68k.org>
17185
17186 * doc.c (Fsubstitute_command_keys): Revert last change.
17187
1d698799
LMI
171882011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
17189
f863868c
LMI
17190 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
17191 quotes the next character, and doesn't affect other longer
17192 sequences (bug#8935).
17193
1d698799
LMI
17194 * lread.c (syms_of_lread): Clarify that is isn't only
17195 `eval-buffer' and `eval-defun' that's affected by
17196 `lexical-binding' (bug#8460).
17197
aa4b6df6
EZ
171982011-07-15 Eli Zaretskii <eliz@gnu.org>
17199
17200 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 17201 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 17202
5d856da6
PE
172032011-07-14 Paul Eggert <eggert@cs.ucla.edu>
17204
ad6042bb
PE
17205 Fix minor problems found by static checking.
17206 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
17207 (elsz): Now a signed constant, not a size_t var. We prefer signed
17208 types to unsigned, to avoid integer comparison confusion. Without
17209 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
17210 "cannot optimize loop, the loop counter may overflow", a symptom
17211 of the confusion.
f00bbb22 17212 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
17213 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
17214
6468f31c
LMI
172152011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
17216
49080b10
LMI
17217 * search.c (Fre_search_backward): Mention `case-fold-search' in
17218 all the re_search_* functions (bug#8138).
17219
6468f31c
LMI
17220 * keyboard.c (Fopen_dribble_file): Document when the file is
17221 closed (bug#8056).
17222
c965adc5
EZ
172232011-07-14 Eli Zaretskii <eliz@gnu.org>
17224
df9733bf
EZ
17225 * bidi.c (bidi_dump_cached_states): Fix format of displaying
17226 bidi_cache_idx.
17227
0bb23927
EZ
17228 Support bidi reordering of display and overlay strings.
17229 * xdisp.c (compute_display_string_pos)
17230 (compute_display_string_end): Accept additional argument STRING.
17231 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
17232 (reseat_to_string): Initialize bidi_it->string.s and
17233 bidi_it->string.schars.
17234 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
17235 NULL (avoids a crash in bidi_paragraph_init).
17236 Initialize itb.string.lstring.
0bb23927
EZ
17237 (init_iterator): Call bidi_init_it only of a valid
17238 buffer position was specified. Initialize paragraph_embedding to
17239 L2R.
17240 (reseat_to_string): Initialize the bidi iterator.
17241 (display_string): If we need to ignore text properties of
17242 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
17243 original value of -1 will not work with bidi.)
17244 (compute_display_string_pos): First arg is now struct
17245 `text_pos *'; all callers changed. Support display properties on
17246 Lisp strings.
17247 (compute_display_string_end): Support display properties on Lisp
17248 strings.
17249 (init_iterator, reseat_1, reseat_to_string): Initialize the
17250 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
17251 when iterating on a string not from display properties).
640c8776
SM
17252 (compute_display_string_pos, compute_display_string_end):
17253 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
17254 arrow keys.
17255 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
17256 base_level_stop; instead, set base_level_stop to BEGV.
17257 Fixes crashes in vertical-motion.
0bb23927
EZ
17258 (next_element_from_buffer): Improve commentary for when
17259 the iterator is before prev_stop.
17260 (init_iterator): Initialize bidi_p from the default value of
17261 bidi-display-reordering, not from buffer-local value. Use the
17262 buffer-local value only if initializing for buffer iteration.
17263 (handle_invisible_prop): Support invisible properties on strings
17264 that are being bidi-reordered.
17265 (set_iterator_to_next): Support bidi reordering of C strings and
17266 Lisp strings.
17267 (next_element_from_string): Support bidi reordering of Lisp
17268 strings.
17269 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
17270 (display_string): Support display of R2L glyph rows.
17271 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
17272 (init_iterator): Don't initialize it->bidi_p for strings
17273 here.
17274 (reseat_to_string): Initialize it->bidi_p for strings here.
17275 (next_element_from_string, next_element_from_c_string)
17276 (next_element_from_buffer): Add xassert's for correspondence
17277 between IT's object being iterated and it->bidi_it.string
17278 structure.
17279 (face_before_or_after_it_pos): Support bidi iteration.
17280 (next_element_from_c_string): Handle the case of the first string
17281 character that is not the first one in the visual order.
17282 (get_visually_first_element): New function, refactored from common
17283 parts of next_element_from_buffer, next_element_from_string, and
17284 next_element_from_c_string.
17285 (tool_bar_lines_needed, redisplay_tool_bar)
17286 (display_menu_bar): Force left-to-right direction. Add a FIXME
17287 comment for making that be controlled by a user option.
17288 (push_it, pop_it): Save and restore the state of the
17289 bidi iterator. Save and restore the bidi_p flag.
17290 (pop_it): Iterate out of display property for string iteration as
17291 well.
17292 (iterate_out_of_display_property): Support iteration over strings.
17293 (handle_single_display_spec): Set up it->bidi_it for iteration
17294 over a display string, and call bidi_init_it.
17295 (handle_single_display_spec, next_overlay_string)
17296 (get_overlay_strings_1, push_display_prop): Set up the bidi
17297 iterator for displaying display or overlay strings.
17298 (forward_to_next_line_start): Don't use the shortcut if
17299 bidi-iterating.
17300 (back_to_previous_visible_line_start): If handle_display_prop
17301 pushed the iterator stack, restore the internal state of the bidi
17302 iterator by calling bidi_pop_it same number of times.
17303 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
17304 and we are bidi-iterating, don't decrement the iterator position;
17305 instead, set the first_elt flag in the bidi iterator, to produce
17306 the same effect.
17307 (reseat_1): Remove redundant setting of string_from_display_prop_p.
17308 (push_display_prop): xassert that we are iterating a buffer.
17309 (push_it, pop_it): Save and restore paragraph_embedding member.
17310 (handle_single_display_spec, next_overlay_string)
17311 (get_overlay_strings_1, reseat_1, reseat_to_string)
17312 (push_display_prop): Set up the `unibyte' member of bidi_it.string
17313 correctly. Don't assume unibyte strings are not bidi-reordered.
17314 (compute_display_string_pos)
17315 (compute_display_string_end): Fix handling the case of C string.
17316 (push_it, pop_it): Save and restore from_disp_prop_p.
17317 (handle_single_display_spec, push_display_prop): Set the
17318 from_disp_prop_p flag.
17319 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
17320 (pop_it): Call iterate_out_of_display_property only if we are
17321 popping after iteration over a string that came from a display
17322 property. Fix a typo in popping stretch info. Add an assertion
17323 for verifying that the iterator position is in sync with the bidi
17324 iterator.
17325 (handle_single_display_spec, get_overlay_strings_1)
17326 (push_display_prop): Fix initialization of paragraph direction for
17327 string when that of the parent object is not yet determined.
17328 (reseat_1): Call bidi_init_it to resync the bidi
17329 iterator with IT's position. (Bug#7616)
17330 (find_row_edges): If ROW->start.pos gives position
17331 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
17332 (handle_stop, back_to_previous_visible_line_start, reseat_1):
17333 Reset the from_disp_prop_p flag.
17334 (SAVE_IT, RESTORE_IT): New macros.
17335 (pos_visible_p, face_before_or_after_it_pos)
17336 (back_to_previous_visible_line_start)
17337 (move_it_in_display_line_to, move_it_in_display_line)
17338 (move_it_to, move_it_vertically_backward, move_it_by_lines)
17339 (try_scrolling, redisplay_window, display_line): Use them when
17340 saving a temporary copy of the iterator and restoring it back.
17341 (back_to_previous_visible_line_start, reseat_1)
17342 (init_iterator): Empty the bidi cache "stack".
17343 (move_it_in_display_line_to): If iterator ended up at
17344 EOL, but we never saw any buffer positions smaller than
17345 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
17346 motion in bidi-reordered lines.
17347 (move_it_in_display_line_to): Record prev_method and prev_pos
17348 immediately before the call to set_iterator_to_next. Fixes cursor
17349 motion in bidi-reordered lines with stretch glyphs and strings
17350 displayed in margins. (Bug#8133) (Bug#8867)
17351 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
17352 TO_CHARPOS.
640c8776
SM
17353 (pos_visible_p): Support positions in bidi-reordered lines.
17354 Save and restore bidi cache.
0bb23927
EZ
17355
17356 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
17357 (bidi_paragraph_info): Delete unused struct.
17358 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
17359 (bidi_cache_start): New variable.
17360 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
17361 to zero.
17362 (bidi_cache_fetch_state, bidi_cache_search)
17363 (bidi_cache_find_level_change, bidi_cache_iterator_state)
17364 (bidi_cache_find, bidi_peek_at_next_level)
17365 (bidi_level_of_next_char, bidi_find_other_level_edge)
17366 (bidi_move_to_visually_next): Compare cache index with
17367 bidi_cache_start rather than with zero.
17368 (bidi_fetch_char): Accept new argument STRING; all callers
17369 changed. Support iteration over a string. Support strings with
17370 display properties. Support unibyte strings. Fix the type of
17371 `len' according to what STRING_CHAR_AND_LENGTH expects.
17372 (bidi_paragraph_init, bidi_resolve_explicit_1)
17373 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
17374 (bidi_level_of_next_char, bidi_move_to_visually_next):
17375 Support iteration over a string.
0bb23927
EZ
17376 (bidi_set_sor_type, bidi_resolve_explicit_1)
17377 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
17378 can now be zero (for strings); special values 0 and -1 were
17379 changed to -1 and -2, respectively.
17380 (bidi_char_at_pos): New function.
17381 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
17382 Call it instead of FETCH_MULTIBYTE_CHAR.
17383 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
17384 initialized to valid values.
17385 (bidi_init_it): Don't initialize charpos and bytepos with invalid
17386 values.
17387 (bidi_level_of_next_char): Allow the sentinel "position" to pass
17388 the test for valid cached positions. Fix the logic for looking up
17389 the sentinel state in the cache. GCPRO the Lisp string we are
17390 iterating.
17391 (bidi_push_it, bidi_pop_it): New functions.
17392 (bidi_initialize): Initialize the bidi cache start stack pointer.
17393 (bidi_cache_ensure_space): New function, refactored from part of
17394 bidi_cache_iterator_state. Don't assume the required size is just
17395 one BIDI_CACHE_CHUNK away.
17396 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
17397 (bidi_count_bytes, bidi_char_at_pos): New functions.
17398 (bidi_cache_search): Don't assume bidi_cache_last_idx is
17399 always valid if bidi_cache_idx is valid.
17400 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
17401 is valid if it's going to be used.
17402 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
17403 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
17404 (bidi_cache_find_level_change, bidi_cache_ensure_space)
17405 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
17406 (bidi_find_other_level_edge, bidi_cache_start_stack):
17407 All variables related to cache indices are now EMACS_INT.
c965adc5 17408
0bb23927
EZ
17409 * dispextern.h (struct bidi_string_data): New structure.
17410 (struct bidi_it): New member `string'. Make flag members be 1-bit
17411 fields, and put them last in the struct.
640c8776
SM
17412 (compute_display_string_pos, compute_display_string_end):
17413 Update prototypes.
0bb23927
EZ
17414 (bidi_push_it, bidi_pop_it): Add prototypes.
17415 (struct iterator_stack_entry): New members bidi_p,
17416 paragraph_embedding, and from_disp_prop_p.
17417 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
17418 (bidi_shelve_cache, bidi_unshelve_cache):
17419 Declare prototypes.
0bb23927
EZ
17420
17421 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
17422 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
17423 and vector-like objects.
17424
17425 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
17426 cache around display iteration.
17427
17428 * window.c (Fwindow_end, window_scroll_pixel_based)
17429 (displayed_window_lines, Frecenter): Save and restore the bidi
17430 cache around display iteration.
17431
3bbd2265
LMI
174322011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
17433
17434 * editfns.c (Fdelete_region): Clarify the use of the named
17435 parameters (bug#6788).
17436
adc47434
MR
174372011-07-14 Martin Rudalics <rudalics@gmx.at>
17438
17439 * indent.c (Fvertical_motion): Set and restore w->pointm when
17440 saving and restoring the window's buffer (Bug#9006).
17441
837c31f8
LMI
174422011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
17443
17444 * editfns.c (Fstring_to_char): Clarify just what is returned
17445 (bug#6576). Text by Eli Zaretskii.
17446
ac389d0c
JB
174472011-07-13 Juanma Barranquero <lekktu@gmail.com>
17448
17449 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
17450
0be0ce47
EZ
174512011-07-13 Eli Zaretskii <eliz@gnu.org>
17452
17453 * buffer.c (mmap_find): Fix a typo.
17454
cd18e7e3
JB
174552011-07-13 Johan Bockgård <bojohan@gnu.org>
17456
17457 Fix execution of x selection hooks.
17458 * xselect.c (Qx_lost_selection_functions)
17459 (Qx_sent_selection_functions): New vars.
17460 (syms_of_xselect): DEFSYM them.
17461 (x_handle_selection_request): Pass Qx_sent_selection_functions
17462 rather than Vx_sent_selection_functions to Frun_hook_with_args.
17463 (x_handle_selection_clear,x_clear_frame_selections):
17464 Pass Qx_lost_selection_functions rather than
17465 Vx_lost_selection_functions to Frun_hook_with_args.
17466
47ea7f44
PE
174672011-07-13 Paul Eggert <eggert@cs.ucla.edu>
17468
ac389d0c 17469 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
17470 The old code sometimes used this field without initializing it.
17471
47ea7f44
PE
17472 * alloc.c (gc_sweep): Don't read past end of array.
17473 In theory, the old code could also have corrupted Emacs internals,
17474 though it'd be very unlikely.
17475
bc985c87
AS
174762011-07-12 Andreas Schwab <schwab@linux-m68k.org>
17477
17478 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 17479 argument. (Bug#4026)
bc985c87 17480
0cf34688
LMI
174812011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
17482
b3dadd76
LMI
17483 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
17484 key" (bug#4257).
17485
0cf34688
LMI
17486 * window.c (Fset_window_start): Doc fix (bug#4199).
17487 (Fset_window_hscroll): Ditto.
17488
270768cd
PE
174892011-07-12 Paul Eggert <eggert@cs.ucla.edu>
17490
077e3dda 17491 Fix minor new problems caught by GCC 4.6.1.
270768cd 17492 * term.c (init_tty): Remove unused local.
490011a6 17493 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 17494 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 17495 not used otherwise.
270768cd 17496
b1f58454
CY
174972011-07-12 Chong Yidong <cyd@stupidchicken.com>
17498
17499 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
17500
22b9578d
LMI
175012011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
17502
6e70ab07
LMI
17503 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
17504 are the mini-buffer and the echo area (bug#3320).
17505
22b9578d
LMI
17506 * term.c (init_tty): Remove support for supdup, c10 and perq
17507 terminals, which are no longer supported (bug#1482).
17508
8974cc9f
JB
175092011-07-10 Johan Bockgård <bojohan@gnu.org>
17510
17511 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
17512
a560d974
JD
175132011-07-10 Jan Djärv <jan.h.d@swipnet.se>
17514
17515 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
17516 for non-popups (Bug#3642).
17517
1dae0f0a
AS
175182011-07-10 Andreas Schwab <schwab@linux-m68k.org>
17519
268c2c36 17520 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 17521 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
17522 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
17523 * cm.c (losecursor): Likewise.
1dae0f0a
AS
17524 * data.c (fmod): Likewise.
17525 * dispnew.c (swap_glyphs_in_rows): Likewise.
17526 * emacs.c (memory_warning_signal): Likewise.
17527 * floatfns.c (float_error): Likewise.
17528 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
17529 (otf_open, font_otf_capability, generate_otf_features)
17530 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
17531 Likewise.
17532 * image.c (pbm_read_file): Likewise.
17533 * indent.c (string_display_width): Likewise.
17534 * intervals.c (check_for_interval, search_for_interval)
17535 (inc_interval_count, count_intervals, root_interval)
17536 (adjust_intervals_for_insertion, make_new_interval): Likewise.
17537 * lread.c (defalias): Likewise.
268c2c36 17538 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
17539 * regex.c (set_image_of_range_1, set_image_of_range)
17540 (regex_grow_registers): Likewise.
17541 * sysdep.c (strerror): Likewise.
17542 * termcap.c (valid_filename_p, tprint, main): Likewise.
17543 * tparam.c (main): Likewise.
17544 * unexhp9k800.c (run_time_remap, save_data_space)
17545 (update_file_ptrs, read_header, write_header, calculate_checksum)
17546 (copy_file, copy_rest, display_header): Likewise.
17547 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
17548 Likewise.
17549 * xdisp.c (check_it): Likewise.
17550 * xfaces.c (register_color, unregister_color, unregister_colors):
17551 Likewise.
17552 * xfns.c (print_fontset_result): Likewise.
17553 * xrdb.c (member, fatal, main): Likewise.
17554
99033785
PE
175552011-07-10 Paul Eggert <eggert@cs.ucla.edu>
17556
17557 Fix minor problems found by static checking (Bug#9031).
17558 * chartab.c (char_table_set_range, map_sub_char_table):
17559 Remove unused locals.
17560 (uniprop_table): Now static.
17561 * composite.c (_work_char): Remove unused static var.
17562
9cb2ac56
JB
175632011-07-09 Juanma Barranquero <lekktu@gmail.com>
17564
17565 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
17566
f25661f0
JD
175672011-07-09 Jan Djärv <jan.h.d@swipnet.se>
17568
17569 * gtkutil.c (qttip_cb): Remove code without function.
17570
8278c4fe
EZ
175712011-07-09 Eli Zaretskii <eliz@gnu.org>
17572
17573 * w32.c (pthread_sigmask): New stub.
17574
1692ae2d 175752011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 17576
8a6ebd58 17577 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
17578 sigprocmask is portable only for single-threaded applications, and
17579 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
17580 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
17581 (LIBES): Use it.
17582 * callproc.c (Fcall_process):
17583 * process.c (create_process):
17584 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
17585 Use pthread_sigmask, not sigprocmask.
123403e4 17586
1b854618
JD
175872011-07-08 Jan Djärv <jan.h.d@swipnet.se>
17588
17589 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
17590 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
17591 wrong (Bug#8591).
17592
3fe4b549
JD
175932011-07-08 Jan Djärv <jan.h.d@swipnet.se>
17594
0ce7e563
JD
17595 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
17596 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
17597 (xg_hide_tooltip): Fix comment.
17598
3fe4b549
JD
17599 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
17600 in registerServicesMenuSendTypes.
17601 (validRequestorForSendType): Don't check ns_return_types.
17602
17603 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
17604 ns_return_type.
17605
5df75e47
JR
176062011-07-08 Jason Rumney <jasonr@gnu.org>
17607
22610910
JR
17608 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
17609 SH_SHOW for hidden windows (Bug#5482).
17610
5df75e47
JR
17611 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
17612 frame struct members of non-existent frames (Bug#6284).
17613
699c10bd
JD
176142011-07-08 Jan Djärv <jan.h.d@swipnet.se>
17615
4393663b
JD
17616 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
17617 variable firstTime not needed on OSX >= 10.6.
17618 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
17619 >= 10.5. Use setKnobProportion, setDoubleValue.
17620
17621 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
17622 (MAC_OS_X_VERSION_10_5): Define if not defined.
17623 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
17624 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
17625 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
17626
17627 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 17628 cString and lossyCString on OSX >= 10.4.
4393663b 17629
58179cce 17630 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
17631 sizeToFit on OSX >= 10.2.
17632
17633 * nsimage.m (allocInitFromFile): Don't use deprecated method
17634 bestRepresentationForDevice on OSX >= 10.6.
17635
17636 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
17637 to avoid warning.
17638
17639 * emacs.c: Declare unexec_init_emacs_zone.
17640
a63e0781
JD
17641 * nsgui.h: Fix compiler warning about gnulib redefining verify.
17642
699c10bd
JD
17643 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
17644
17645 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
17646 on svcsMenu (Bug#8842).
17647
17648 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
17649 ns_return_types.
17650 (Fns_list_services): Just return Qnil on 10.6, code not working there.
17651
17652 * nsterm.m (QUTF8_STRING): Declare.
17653 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
17654 (validRequestorForSendType): Return type is (id).
17655 Change indexOfObjectIdenticalTo to indexOfObject.
17656 Check if we have local selection before returning self (Bug#8842).
17657 (writeSelectionToPasteboard): Put local selection into paste board
17658 if we have a local selection (Bug#8842).
17659 (syms_of_nsterm): DEFSYM QUTF8_STRING.
17660
17661 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
17662 (ns_get_local_selection): Declare.
17663
54e10184
LMI
176642011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
17665
9888ff71
LMI
17666 * keymap.c (describe_map_tree): Don't insert a double newline at
17667 the end of the buffer (bug#1169) and return whether we inserted
17668 something.
17669
54e10184
LMI
17670 * callint.c (Fcall_interactively): Change "reading args" to
17671 "providing args" to try to clarify what it does (bug#1010).
17672
15fa4783
KH
176732011-07-07 Kenichi Handa <handa@m17n.org>
17674
17675 * composite.c (composition_compute_stop_pos): Ignore a static
17676 composition starting before CHARPOS (Bug#8915).
17677
17678 * xdisp.c (handle_composition_prop): Likewise.
17679
a8815b00
EZ
176802011-07-07 Eli Zaretskii <eliz@gnu.org>
17681
17682 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
17683 (Bug#9015)
17684
ef7b981d 176852011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
17686
17687 * character.h (unicode_category_t): New enum type.
17688
17689 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
17690 (Qchar_code_property_table): New variable.
17691 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
17692 (UNIPROP_COMPRESSED_FORM_P): New macros.
17693 (char_table_ascii): Uncompress the compressed values.
17694 (sub_char_table_ref): New arg is_uniprop. Callers changed.
17695 Uncompress the compressed values.
ac389d0c 17696 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
17697 (char_table_ref_and_range): Uncompress the compressed values.
17698 (sub_char_table_set): New arg is_uniprop. Callers changed.
17699 Uncompress the compressed values.
17700 (sub_char_table_set_range): Args changed. Callers changed.
17701 (char_table_set_range): Adjuted for the above change.
17702 (map_sub_char_table): Delete args default_val and parent. Add arg
17703 top. Give decoded values to a Lisp function.
640c8776 17704 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
17705 values to a Lisp function. Gcpro more variables.
17706 (uniprop_table_uncompress)
17707 (uniprop_decode_value_run_length): New functions.
17708 (uniprop_decoder, uniprop_decoder_count): New variables.
17709 (uniprop_get_decoder, uniprop_encode_value_character)
17710 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
17711 New functions.
17712 (uniprop_encoder, uniprop_encoder_count): New variables.
17713 (uniprop_get_encoder, uniprop_table)
17714 (Funicode_property_table_internal, Fget_unicode_property_internal)
17715 (Fput_unicode_property_internal): New functions.
17716 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
17717 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 17718 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
17719 char-code-property-alist.
17720
640c8776 17721 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
17722 Vunicode_category_table.
17723
640c8776 17724 * font.c (font_range): Adjust for the change of
c805dec0
KH
17725 Vunicode_category_table.
17726
76b397fb
DN
177272011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
17728
17729 * m/iris4d.h: Remove file, move contents ...
17730 * s/irix6-5.h: ... here.
17731
22b4128e
PE
177322011-07-06 Paul Eggert <eggert@cs.ucla.edu>
17733
17734 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
17735 * alloc.c (mark_buffer):
17736 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
17737 (clone_per_buffer_values): Don't assume that
22b4128e
PE
17738 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
17739 This isn't true in general, and it's particularly not true
17740 if Emacs is configured with --with-wide-int.
17741 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
17742 New macros, used in the buffer.c change.
17743
869795d6
JD
177442011-07-05 Jan Djärv <jan.h.d@swipnet.se>
17745
17746 * xsettings.c: Use both GConf and GSettings if both are available.
17747 (store_config_changed_event): Add comment.
17748 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
17749 (store_tool_bar_style_changed): New functions.
5e617bc2 17750 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
17751 (struct xsettings): Move font inside HAVE_XFT.
17752 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 17753 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 17754 Move inside HAVE_XFT.
640c8776 17755 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
17756 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
17757 also.
17758 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 17759 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 17760 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
17761 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
17762 (parse_settings): Move check for font inside HAVE_XFT.
17763 (read_settings, apply_xft_settings): Add comment.
17764 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
17765 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
17766 call store_font_name_changed.
17767 (xft_settings_event): Add comment.
17768 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
17769 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
17770 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
17771 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
17772 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
17773 (xsettings_get_system_font, xsettings_get_system_normal_font):
17774 Add comment.
869795d6 17775
d8ed26bd
PE
177762011-07-05 Paul Eggert <eggert@cs.ucla.edu>
17777
17778 Random fixes. E.g., (random) never returned negative values.
17779 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
17780 subseconds part to the entropy, as that's a bit more random.
17781 Prefer signed to unsigned, since the signedness doesn't matter and
17782 in general we prefer signed. When given a limit, use a
17783 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
17784 latter isn't right if USE_2_TAGS_FOR_INTS.
17785 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
17786 not 0..VALMASK. Don't discard "excess" bits that random () returns.
17787
cabf1cac
SM
177882011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
17789
17790 * textprop.c (text_property_stickiness):
17791 Obey Vtext_property_default_nonsticky.
17792 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
17793 * w32fns.c (syms_of_w32fns):
17794 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
17795
6e9b2be9
PE
177962011-07-04 Paul Eggert <eggert@cs.ucla.edu>
17797
17798 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
17799 This is more efficient than Ffile_directory_p and avoids a minor race.
17800
90186c68
LMI
178012011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
17802
7c301272
LMI
17803 * buffer.c (Foverlay_put): Say what the return value is
17804 (bug#7835).
17805
c4f2d8d4
LMI
17806 * fileio.c (barf_or_query_if_file_exists): Check first if the file
17807 is a directory before asking whether to use the file name
17808 (bug#7564).
ad637907
LMI
17809 (barf_or_query_if_file_exists): Make the "File is a directory"
17810 error be more correct.
c4f2d8d4 17811
90186c68
LMI
17812 * fns.c (Frequire): Remove the mention of the .gz files, since
17813 that's installation-specific, but keep the mention of
17814 `get-load-suffixes'.
17815
da64016e
PE
178162011-07-04 Paul Eggert <eggert@cs.ucla.edu>
17817
17818 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
17819 Report string overflow if the output is too long.
17820
7d47b580
JB
178212011-07-04 Juanma Barranquero <lekktu@gmail.com>
17822
a555cb87
JB
17823 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
17824 (syms_of_gnutls): Remove duplicate DEFSYM for
17825 Qgnutls_bootprop_verify_hostname_error, an error for
17826 Qgnutls_bootprop_verify_error (which is no longer used).
17827
7d47b580
JB
17828 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
17829 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
17830 Also (re)move comments that are misplaced or no longer relevant.
17831
1e49bfab
LMI
178322011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
17833
17834 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
17835
1485f4c0
CY
178362011-07-03 Chong Yidong <cyd@stupidchicken.com>
17837
17838 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
17839 and background color parameters if they have been changed.
17840
a9ab721e
LMI
178412011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
17842
17843 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
17844
cf7cff57
PE
178452011-07-03 Paul Eggert <eggert@cs.ucla.edu>
17846
2e13213d
PE
17847 * xsettings.c (SYSTEM_FONT): Define only when used.
17848 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
17849
cf7cff57
PE
17850 * keymap.c (access_keymap_1): Now static.
17851
7a8e04f7
CY
178522011-07-02 Chong Yidong <cyd@stupidchicken.com>
17853
17854 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
17855 leave any prefix arg for the up event (Bug#1586).
17856
61352f62
LMI
178572011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
17858
69bb1ef7
LMI
17859 * lread.c (syms_of_lread): Mention single symbols defined by
17860 `defvar' or `defconst' (bug#7154).
17861
61352f62 17862 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 17863 (Frequire): Mention get-load-suffixes.
61352f62 17864
28545e04
MR
178652011-07-02 Martin Rudalics <rudalics@gmx.at>
17866
17867 * window.h (window): Remove clone_number slot.
17868 * window.c (Fwindow_clone_number, Fset_window_clone_number):
17869 Remove.
17870 (make_parent_window, make_window, saved_window)
17871 (Fset_window_configuration, save_window_save): Don't deal with
17872 clone numbers.
17873 * buffer.c (Qclone_number): Remove declaration.
17874 (sort_overlays, overlay_strings): Don't deal with clone numbers.
17875
3349e122
SM
178762011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
17877
17878 Add multiple inheritance to keymaps.
17879 * keymap.c (Fmake_composed_keymap): New function.
17880 (Fset_keymap_parent): Simplify.
17881 (fix_submap_inheritance): Remove.
17882 (access_keymap_1): New function extracted from access_keymap to handle
17883 embedded parents and handle lists of maps.
17884 (access_keymap): Use it.
17885 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
17886 (Fcopy_keymap): Handle embedded parents.
17887 (Fcommand_remapping, define_as_prefix): Simplify.
17888 (Fkey_binding): Simplify.
17889 (syms_of_keymap): Move minibuffer-local-completion-map,
17890 minibuffer-local-filename-completion-map,
17891 minibuffer-local-must-match-map, and
17892 minibuffer-local-filename-must-match-map to Elisp.
17893 (syms_of_keymap): Defsubr make-composed-keymap.
17894 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
17895 (parse_menu_item): Trivial simplification.
17896
3279eb87
GM
178972011-07-01 Glenn Morris <rgm@gnu.org>
17898
17899 * Makefile.in (SETTINGS_LIBS): Fix typo.
17900
39cb9e56 179012011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
17902
17903 * coding.c (Fencode_coding_string): Record the last coding system
17904 used, as the function doc string says (bug#8738).
17905
0949d2b6
JD
179062011-07-01 Jan Djärv <jan.h.d@swipnet.se>
17907
17908 * xsettings.c (store_monospaced_changed): Take new font as arg and
17909 check for change against current_mono_font.
17910 (EMACS_TYPE_SETTINGS): Remove this and related defines.
17911 (emacs_settings_constructor, emacs_settings_get_property)
17912 (emacs_settings_set_property, emacs_settings_class_init)
17913 (emacs_settings_init, gsettings_obj): Remove.
17914 (something_changedCB): New function for HAVE_GSETTINGS.
17915 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
17916 with value as argument.
17917 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
17918 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 17919 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
17920 "changed".
17921
17922 * xgselect.c: Add defined (HAVE_GSETTINGS).
17923 (xgselect_initialize): Ditto.
17924
17925 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
17926 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
17927 xg_select.
17928
bbc6b304
PE
179292011-07-01 Paul Eggert <eggert@cs.ucla.edu>
17930
17931 * eval.c (struct backtrace): Simplify and port the data structure.
17932 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
17933 signed bit field, as this assumption is not portable and it makes
17934 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
17935 "char debug_on_exit : 1" as this is not portable either; instead,
17936 use the portable "unsigned int debug_on_exit : 1". Remove unused
17937 member evalargs. Remove obsolete comments about cc bombing out.
17938
9851bfc5
JD
179392011-06-30 Jan Djärv <jan.h.d@swipnet.se>
17940
51bb811f 17941 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
17942 Let HAVE_GSETTINGS override HAVE_GCONF.
17943 (store_monospaced_changed): New function.
17944 (EMACS_SETTINGS): A new type derived from GObject to handle
17945 GSettings notifications.
17946 (emacs_settings_constructor, emacs_settings_get_property)
17947 (emacs_settings_set_property, emacs_settings_class_init):
17948 New functions.
17949 (gsettings_client, gsettings_obj): New variables.
17950 (GSETTINGS_SCHEMA): New define.
17951 (something_changedCB): Call store_monospaced_changed.
17952 (init_gsettings): New function.
17953 (xsettings_initialize): Call init_gsettings.
17954 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
17955 to NULL.
17956
640c8776 17957 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
17958 GCONF_CFLAGS/LIBS.
17959
5386012d
MR
179602011-06-29 Martin Rudalics <rudalics@gmx.at>
17961
17962 * window.c (resize_root_window, grow_mini_window)
17963 (shrink_mini_window): Rename Qresize_root_window to
17964 Qwindow_resize_root_window and Qresize_root_window_vertically to
17965 Qwindow_resize_root_window_vertically.
17966
f13e0b08
PE
179672011-06-28 Paul Eggert <eggert@cs.ucla.edu>
17968
17969 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
17970
94515237
JB
179712011-06-27 Juanma Barranquero <lekktu@gmail.com>
17972
17973 * makefile.w32-in: Redesign dependencies so they reflect more
17974 clearly which files are directly included by each source file,
17975 and not through other includes.
17976
e43b6e43
MR
179772011-06-27 Martin Rudalics <rudalics@gmx.at>
17978
17979 * buffer.c (Qclone_number): Declare static and DEFSYM it.
17980 (sort_overlays, overlay_strings): When an overlay's clone number
17981 matches the window's clone number process the overlay even if
17982 the overlay's window property doesn't match the current window.
17983
d68443dc
MR
17984 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
17985 (Fwindow_hchild): Rename to Fwindow_left_child.
17986 (Fwindow_next): Rename to Fwindow_next_sibling.
17987 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
17988 (resize_window_check): Rename to window_resize_check.
17989 (resize_window_apply): Rename to window_resize_apply.
17990 (Fresize_window_apply): Rename to Fwindow_resize_apply.
17991 (Fdelete_other_windows_internal, resize_frame_windows)
17992 (Fsplit_window_internal, Fdelete_window_internal)
17993 (grow_mini_window, shrink_mini_window)
17994 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 17995
c7e73be5
JD
179962011-06-26 Jan Djärv <jan.h.d@swipnet.se>
17997
17998 * emacsgtkfixed.h: State that this is only used with Gtk+3.
17999 (emacs_fixed_set_min_size): Remove.
18000 (emacs_fixed_new): Take frame as argument.
18001
18002 * emacsgtkfixed.c: State that this is only used with Gtk+3.
18003 (_EmacsFixedPrivate): Remove minwidth/height.
18004 Add struct frame *f.
18005 (emacs_fixed_init): Initialize priv->f.
18006 (get_parent_class, emacs_fixed_set_min_size): Remove.
18007 (emacs_fixed_new): Set priv->f to argument.
18008 (emacs_fixed_get_preferred_width)
18009 (emacs_fixed_get_preferred_height): Use min_width/height from
18010 frames size_hint to set minimum and natural (Bug#8919).
18011 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
18012 and use min_width/height from frames size_hint to set
18013 min_width/height (Bug#8919).
18014
18015 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
18016 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
18017 Fix indentation.
c7e73be5 18018
cf99dcf8
EZ
180192011-06-26 Eli Zaretskii <eliz@gnu.org>
18020
18021 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
18022 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
18023 called at ZV.
18024
029529ac
CY
180252011-06-26 Chong Yidong <cyd@stupidchicken.com>
18026
18027 * process.c (wait_reading_process_output): Bypass select if
18028 waiting for a cell while ignoring keyboard input, and input is
18029 pending. Suggested by Jan Djärv (Bug#8869).
18030
7a7ef429
PE
180312011-06-25 Paul Eggert <eggert@cs.ucla.edu>
18032
18033 Use gnulib's dup2 module instead of rolling our own.
18034 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
18035
11fdef7d 180362011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
18037
18038 * dispnew.c (scrolling_window): Before scrolling, turn off a
18039 mouse-highlight in the window being scrolled.
18040
cd3520a4
JB
180412011-06-24 Juanma Barranquero <lekktu@gmail.com>
18042
18043 Move DEFSYM to lisp.h and use everywhere.
18044
18045 * character.h (DEFSYM): Move declaration...
18046 * lisp.h (DEFSYM): ...here.
18047
18048 * gnutls.c:
18049 * minibuf.c:
18050 * w32menu.c:
18051 * w32proc.c:
18052 * w32select.c: Don't include character.h.
18053
18054 * alloc.c (syms_of_alloc):
18055 * buffer.c (syms_of_buffer):
18056 * bytecode.c (syms_of_bytecode):
18057 * callint.c (syms_of_callint):
18058 * casefiddle.c (syms_of_casefiddle):
18059 * casetab.c (init_casetab_once):
18060 * category.c (init_category_once, syms_of_category):
18061 * ccl.c (syms_of_ccl):
18062 * cmds.c (syms_of_cmds):
18063 * composite.c (syms_of_composite):
18064 * dbusbind.c (syms_of_dbusbind):
18065 * dired.c (syms_of_dired):
18066 * dispnew.c (syms_of_display):
18067 * doc.c (syms_of_doc):
18068 * editfns.c (syms_of_editfns):
18069 * emacs.c (syms_of_emacs):
18070 * eval.c (syms_of_eval):
18071 * fileio.c (syms_of_fileio):
18072 * fns.c (syms_of_fns):
18073 * frame.c (syms_of_frame):
18074 * fringe.c (syms_of_fringe):
18075 * insdel.c (syms_of_insdel):
18076 * keymap.c (syms_of_keymap):
18077 * lread.c (init_obarray, syms_of_lread):
18078 * macros.c (syms_of_macros):
18079 * msdos.c (syms_of_msdos):
18080 * print.c (syms_of_print):
18081 * process.c (syms_of_process):
18082 * search.c (syms_of_search):
18083 * sound.c (syms_of_sound):
18084 * syntax.c (init_syntax_once, syms_of_syntax):
18085 * terminal.c (syms_of_terminal):
18086 * textprop.c (syms_of_textprop):
18087 * undo.c (syms_of_undo):
18088 * w32.c (globals_of_w32):
18089 * window.c (syms_of_window):
18090 * xdisp.c (syms_of_xdisp):
18091 * xfaces.c (syms_of_xfaces):
18092 * xfns.c (syms_of_xfns):
18093 * xmenu.c (syms_of_xmenu):
18094 * xsettings.c (syms_of_xsettings):
18095 * xterm.c (syms_of_xterm): Use DEFSYM.
18096
4228cf16
TZ
180972011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
18098
cd3520a4 18099 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 18100
7fcccf1e
PE
181012011-06-23 Paul Eggert <eggert@cs.ucla.edu>
18102
7efb4e0e
PE
18103 Integer and buffer overflow fixes (Bug#8873).
18104
ff5844ad
PE
18105 * print.c (printchar, strout): Check for string overflow.
18106 (PRINTPREPARE, printchar, strout):
18107 Don't set size unless allocation succeeds.
18108
90532f02
PE
18109 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
18110 for sizes. Check for string overflow more accurately.
18111 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
18112
6d84508d
PE
18113 * macros.c: Integer and buffer overflow fixes.
18114 * keyboard.h (struct keyboard.kbd_macro_bufsize):
18115 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
18116 Use ptrdiff_t, not int, for sizes.
18117 Don't increment bufsize until after realloc succeeds.
18118 Check for size-calculation overflow.
18119 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
18120
437b2cb4
PE
18121 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
18122
8b9ac8b4
PE
18123 * lread.c: Integer overflow fixes.
18124 (read_integer): Radix is now EMACS_INT, not int,
18125 to improve quality of diagnostics for out-of-range radices.
18126 Calculate buffer size correctly for out-of-range radices.
18127 (read1): Check for integer overflow in radices, and in
18128 read-circle numbers.
82cb60d3
PE
18129 (read_escape): Avoid int overflow.
18130 (Fload, openp, read_buffer_size, read1)
18131 (substitute_object_recurse, read_vector, read_list, map_obarray):
18132 Use ptrdiff_t, not int, for sizes.
18133 (read1): Use EMACS_INT, not int, for sizes.
20270765 18134 Check for size overflow.
8b9ac8b4 18135
7fcccf1e
PE
18136 * image.c (cache_image): Check for size arithmetic overflow.
18137
bfbbd7e7
PE
18138 * lread.c: Integer overflow issues.
18139 (saved_doc_string_size, saved_doc_string_length)
18140 (prev_saved_doc_string_size, prev_saved_doc_string_length):
18141 Now ptrdiff_t, not int.
18142 (read1): Don't assume doc string length fits in int. Check for
18143 out-of-range doc string lengths.
18144 (read_list): Don't assume file position fits in int.
39019e54 18145 (read_escape): Check for hex character overflow.
bfbbd7e7 18146
4e323265
LL
181472011-06-22 Leo Liu <sdl.web@gmail.com>
18148
18149 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
18150 Move to minibuffer.el.
18151
85fece3e
PE
181522011-06-22 Paul Eggert <eggert@cs.ucla.edu>
18153
20b84ce9 18154 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
18155 The following patches are for when GLYPH_DEBUG && !XASSERT.
18156 * dispextern.h (trace_redisplay_p, dump_glyph_string):
18157 * dispnew.c (flush_stdout):
18158 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
18159 Mark as externally visible.
18160 * dispnew.c (check_window_matrix_pointers): Now static.
18161 * dispnew.c (window_to_frame_vpos):
18162 * xfns.c (unwind_create_frame):
18163 * xterm.c (x_check_font): Remove unused local.
18164 * scroll.c (CHECK_BOUNDS):
18165 * xfaces.c (cache_fache): Rename local to avoid shadowing.
18166 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
18167 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
18168 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
18169 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
18170 Now static.
18171 (debug_method_add): Use va_list and vsprintf rather than relying
18172 on undefined behavior with wrong number of arguments.
18173 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
18174 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
18175 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
18176 since we're not interested in debugging glyphs with old libraries.
18177 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
18178 GCC 4.6.0's static checking.
18179
0766b489
PE
181802011-06-22 Paul Eggert <eggert@cs.ucla.edu>
18181
31fd4b32
PE
18182 Integer overflow and signedness fixes (Bug#8873).
18183 A few related buffer overrun fixes, too.
18184
b79e8648
PE
18185 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
18186
0766b489
PE
18187 * dispextern.h (struct face.stipple):
18188 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
18189 (x_bitmap_mask, x_allocate_bitmap_record)
18190 (x_create_bitmap_from_data, x_create_bitmap_from_file)
18191 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
18192 (x_create_bitmap_from_xpm_data):
18193 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
18194 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
18195 (.bitmaps_last):
18196 * xfaces.c (load_pixmap):
18197 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
18198 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
18199 (.bitmaps_last, struct x_output.icon_bitmap):
18200 Use ptrdiff_t, not int, for bitmap indexes.
18201 (x_allocate_bitmap_record): Check for size overflow.
18202 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
18203
b081724f
PE
18204 Use ptrdiff_t, not int, for overlay counts.
18205 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
18206 * editfns.c (overlays_around, get_pos_property):
18207 * textprop.c (get_char_property_and_overlay):
18208 * xdisp.c (next_overlay_change, note_mouse_highlight):
18209 * xfaces.c (face_at_buffer_position):
21514da7
PE
18210 * buffer.c (OVERLAY_COUNT_MAX): New macro.
18211 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
18212 (Fnext_overlay_change, Fprevious_overlay_change)
18213 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 18214 Use ptrdiff_t, not int, for sizes.
21514da7 18215 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 18216
3de73e5e
PE
18217 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
18218
2606c57b
PE
18219 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
18220 (x_session_initialize): Do not assume string length fits in int.
18221
aaafe47a
PE
18222 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
18223 This is unlikely, but can occur if DPI is outlandish.
18224
2674ddc8 18225 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
18226 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
18227
28154962
PE
18228 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
18229 * xrdb.c (magic_file_p, search_magic_path):
18230 Omit last arg SUFFIX; it was always 0. All callers changed.
18231 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
18232
7de51af5
PE
18233 * xfont.c (xfont_match): Avoid need for strlen.
18234
25ed6cc3
PE
18235 * xfns.c: Don't assume strlen fits in int.
18236 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
18237
4eab31dd
PE
18238 * xdisp.c (message_log_check_duplicate): Return intmax_t,
18239 not unsigned long, as we prefer signed integers. All callers changed.
18240 Detect integer overflow in repeat count.
18241 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 18242 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 18243
171e2a58
PE
18244 * termcap.c: Don't assume sizes fit in int and never overflow.
18245 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
18246 (gobble_line): Check for size-calculation overflow.
18247
ad39faca 18248 * minibuf.c (Fread_buffer):
6e5bb2dc 18249 * lread.c (intern, intern_c_string):
74ca2eb3
PE
18250 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
18251 Don't assume string length fits in int.
18252
52c61c22 18253 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
18254 * gtkutil.c (style_changed_cb): Avoid need for strlen.
18255
b5b8c9e5
PE
18256 * font.c: Don't assume string length fits in int.
18257 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
18258 Use ptrdiff_t, not int.
ccd6111c
PE
18259 (font_intern_prop): Don't assume string length fits in int.
18260 Don't assume integer property fits in fixnum.
18261 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 18262
882f0d81 18263 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 18264 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
18265 Reformulate so as not to need the command string.
18266 Invoke gzip -cd rather than gunzip, as it's more portable.
18267 (lock_info_type, lock_file_1, lock_file):
18268 Don't assume pid_t and time_t fit in unsigned long.
18269 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
18270 (current_lock_owner): Prefer signed type for sizes.
18271 Use memcpy, not strncpy, where memcpy is what is really wanted.
18272 Don't assume (via atoi) that time_t and pid_t fit in int.
18273 Check for time_t and/or pid_t out of range, e.g., via a network share.
18274 Don't alloca where an auto var works fine.
18275
93f4cf88
PE
18276 * fileio.c: Fix some integer overflow issues.
18277 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
18278 Don't assume string length fits in int.
18279 (directory_file_name): Don't assume string length fits in long.
18280 (make_temp_name): Don't assume pid fits in int, or that its print
18281 length is less than 20.
18282
f3e92b69
PE
18283 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
18284
1bfdaf10
PE
18285 * coding.c (make_subsidiaries): Don't assume string length fits in int.
18286
35016e9a
PE
18287 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
18288
3d1e65a1
PE
18289 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
18290 We prefer signed integers, even for size calculations.
18291
0b963a93
PE
18292 * emacs.c: Don't assume string length fits in 'int'.
18293 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
18294 (main): Don't invoke strlen when not needed.
18295
573f4b54
PE
18296 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
18297 (XD_DEBUG_MESSAGE): Don't waste a byte.
18298
989f33ba
PE
18299 * callproc.c (getenv_internal_1, getenv_internal)
18300 (Fgetenv_internal):
965d34eb
PE
18301 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
18302
e4d29b33
PE
18303 * lread.c (invalid_syntax): Omit length argument.
18304 All uses changed. This doesn't fix a bug, but it simplifies the
18305 code away from its former Hollerith-constant appearance, and it's
18306 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 18307 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 18308
eb49b136
PE
18309 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
18310 This didn't break anything, but it didn't help either.
18311 It's confusing to put a bogus integer in a place where the actual
18312 value does not matter.
9f62aeb1 18313 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 18314 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 18315
15375a22
PE
18316 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
18317 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
18318 implementation.
b61cc01c
PE
18319 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
18320 We prefer signed types, and the value cannot exceed the EMACS_INT
18321 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
18322 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
18323 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
18324 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 18325
53b2623d
PE
18326 * indent.c (sane_tab_width): New function.
18327 (current_column, scan_for_column, Findent_to, position_indentation)
18328 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 18329 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 18330
51cab52b 18331 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 18332
f2ed8a70
PE
18333 * lisp.h (lint_assume): New macro.
18334 * composite.c (composition_gstring_put_cache):
18335 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
18336
abe80cc6
PE
18337 * editfns.c, insdel.c:
18338 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 18339
b02c740e
PE
18340 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
18341
ebc96716
PE
18342 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
18343
b4e50fa0 18344 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 18345 Use much-faster test for byte-length change.
311d5d7c 18346 Don't assume string byte-length fits in 'int'.
a4cf38e4 18347 Check that character arg fits in 'int'.
85461888 18348 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 18349
c0c1ee9f
PE
18350 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
18351
a498d7f4
PE
18352 * fns.c (concat): Catch string overflow earlier.
18353 Do not rely on integer wraparound.
18354
51cab52b
PE
18355 * dispextern.h (struct it.overlay_strings_charpos)
18356 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
18357 * xdisp.c (forward_to_next_line_start)
18358 (back_to_previous_visible_line_start)
18359 (reseat_at_next_visible_line_start, next_element_from_buffer):
18360 Don't arbitrarily truncate the value of 'selective' to int.
18361
76031fad
PE
18362 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
18363
5eb55db9
PE
18364 * composite.c: Don't truncate sizes to 'int'.
18365 (composition_gstring_p, composition_reseat_it)
18366 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
18367 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
18368 not EMACS_UINT, for indexes.
5eb55db9 18369
0703a717
PE
18370 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
18371
d6202519
PE
18372 * buffer.c: Include <verify.h>.
18373 (struct sortvec.priority, struct sortstr.priority):
8961a454 18374 Now EMACS_INT, not int.
c20998a7 18375 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
18376 (struct sortstr.size, record_overlay_string)
18377 (struct sortstrlist.size, struct sortlist.used):
18378 Don't truncate size to int.
18379 (record_overlay_string): Check for size-calculation overflow.
d6202519 18380 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 18381
d5a19415
JM
183822011-06-22 Jim Meyering <meyering@redhat.com>
18383
029529ac 18384 Don't leak an XBM-image-sized buffer
d5a19415
JM
18385 * image.c (xbm_load): Free the image buffer after using it.
18386
a9041e6c
PE
183872011-06-21 Paul Eggert <eggert@cs.ucla.edu>
18388
18389 Port to Sun C.
18390 * composite.c (find_automatic_composition): Omit needless 'return 0;'
18391 that Sun C diagnosed.
18392 * fns.c (secure_hash): Fix pointer signedness issue.
18393 * intervals.c (static_offset_intervals): New function.
18394 (offset_intervals): Use it.
18395
7f3f739f
LL
183962011-06-21 Leo Liu <sdl.web@gmail.com>
18397
18398 * deps.mk (fns.o):
18399 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
18400 sha512.h.
18401
18402 * fns.c (secure_hash): Rename from crypto_hash_function and change
18403 the first arg to accept symbols.
5b66d427 18404 (Fsecure_hash): New primitive.
7f3f739f
LL
18405 (syms_of_fns): New symbols.
18406
76147d94
DD
184072011-06-20 Deniz Dogan <deniz@dogan.se>
18408
18409 * process.c (Fset_process_buffer): Clarify return value in
18410 docstring.
18411
7d7d0045
CY
184122011-06-18 Chong Yidong <cyd@stupidchicken.com>
18413
18414 * dispnew.c (add_window_display_history): Use BVAR.
18415
18416 * xdisp.c (debug_method_add): Use BVAR.
18417 (check_window_end, dump_glyph_matrix, dump_glyph)
18418 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
18419
18420 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
18421 Likewise.
18422
18423 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
18424 check till after the cache is created in init_frame_faces.
18425
ff2bc410
SM
184262011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
18427
18428 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
18429
28177add
PE
184302011-06-16 Paul Eggert <eggert@cs.ucla.edu>
18431
dd3482fe
PE
18432 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
18433 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
18434 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
18435
393d71f3 18436 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
18437 * fileio.c (Finsert_file_contents):
18438 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
18439 Remove the old (too-loose) buffer overflow checks.
18440 They weren't needed, since make_gap checks for buffer overflow.
18441 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
18442 The old code merely checked for Emacs fixnum overflow, and relied
18443 on undefined (wraparound) behavior. The new code avoids undefined
18444 behavior, and also checks for ptrdiff_t and/or size_t overflow.
18445
2e6813b0 18446 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
18447 Tune. Don't use wider integers than needed. Don't use alloca.
18448 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 18449
599a9e4f
PE
18450 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
18451
99561444
PE
18452 * insdel.c, lisp.h (buffer_overflow): New function.
18453 (insert_from_buffer_1, replace_range, replace_range_2):
18454 * insdel.c (make_gap_larger):
18455 * editfns.c (Finsert_char):
18456 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
18457
28177add
PE
18458 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
18459
e69dafad
PE
184602011-06-15 Paul Eggert <eggert@cs.ucla.edu>
18461
4baa020d 18462 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 18463
b1c46f02
PE
18464 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
18465 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
18466
e69dafad
PE
18467 * fileio.c: Don't assume EMACS_INT fits in off_t.
18468 (emacs_lseek): New static function.
18469 (Finsert_file_contents, Fwrite_region): Use it.
18470 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
18471
566684ea
PE
18472 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
18473
e6966cd6
PE
18474 * fns.c: Don't overflow int when computing a list length.
18475 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
18476 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
18477 truncation on 64-bit hosts. Check for QUIT every
18478 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
18479 faster and is responsive enough.
18480 (Flength): Report an error instead of overflowing an integer.
18481 (Fsafe_length): Return a float if the value is not representable
18482 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 18483 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 18484 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 18485
dd0b0efb
PE
18486 * alloc.c: Check that resized vectors' lengths fit in fixnums.
18487 (header_size, word_size): New constants.
18488 (allocate_vectorlike): Don't check size overflow here.
18489 (allocate_vector): Check it here instead, since this is the only
18490 caller of allocate_vectorlike that could cause overflow.
18491 Check that the new vector's length is representable as a fixnum.
18492
86fe5cfe
PE
18493 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
18494 The previous code was bogus. For example, next_almost_prime (32)
18495 returned 39, which is undesirable as it is a multiple of 3; and
18496 next_almost_prime (24) returned 25, which is a multiple of 5 so
18497 why was the code bothering to check for multiples of 7?
18498
80e88859
PE
18499 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
18500
4a2f0ad6
PE
18501 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
18502
f66c7cf8
PE
18503 Variadic C functions now count arguments with ptrdiff_t.
18504 This partly undoes my 2011-03-30 change, which replaced int with size_t.
18505 Back then I didn't know that the Emacs coding style prefers signed int.
18506 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
18507 were being counted with int, which may truncate counts on 64-bit
18508 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
18509 * lisp.h (struct Lisp_Subr.function.aMANY)
18510 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
18511 Arg counts are now ptrdiff_t, not size_t.
18512 All variadic functions and their callers changed accordingly.
18513 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
18514 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
18515 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
18516 * callint.c (Fcall_interactively): Check arg count for overflow,
18517 to avoid potential buffer overrun. Use signed char, not 'int',
18518 for 'varies' array, so that we needn't bother to check its size
18519 calculation for overflow.
18520 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
18521 * eval.c (apply_lambda):
18522 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
18523 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
18524 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
18525
a1759b76
PE
18526 * callint.c (Fcall_interactively): Don't use index var as event count.
18527
d96be9fc
PE
18528 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
18529 * mem-limits.h (SIZE): Remove; no longer used.
18530
a690a978 18531 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 18532
578c21e6
PE
18533 Remove unnecessary casts.
18534 * xterm.c (x_term_init):
18535 * xfns.c (x_set_border_pixel):
18536 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
18537 These aren't needed now that we assume ANSI C.
18538
96f53c6c
PE
18539 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
18540 It's more likely to cause problems (due to unsigned overflow)
18541 than to cure them.
18542
83c77d31
PE
18543 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
18544
ee2079f1
PE
18545 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
18546
6da65536
PE
18547 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
18548
7147c4a4
PE
18549 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
18550
193e32d9
PE
18551 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
18552
e5533da6
PE
18553 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
18554
9910e595
PE
18555 GLYPH_CODE_FACE returns EMACS_INT, not int.
18556 * dispextern.h (merge_faces):
18557 * xfaces.c (merge_faces):
01103c44
PE
18558 * xdisp.c (get_next_display_element, next_element_from_display_vector):
18559 Don't assume EMACS_INT fits in int.
9910e595 18560
2638320e
PE
18561 * character.h (CHAR_VALID_P): Remove unused parameter.
18562 * fontset.c, lisp.h, xdisp.c: All uses changed.
18563
045eb8d9
PE
18564 * editfns.c (Ftranslate_region_internal): Omit redundant test.
18565
c1f134b5
PE
18566 * fns.c (concat): Minor tuning based on overflow analysis.
18567 This doesn't fix any bugs. Use int to hold character, instead
18568 of constantly refetching from Emacs object. Use XFASTINT, not
18569 XINT, for value known to be a character. Don't bother comparing
18570 a single byte to 0400, as it's always less.
18571
395fcb93 18572 * floatfns.c (Fexpt):
327eeec8
PE
18573 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
18574
abbd3d23
PE
18575 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
18576 for characters.
18577
684a03ef
PE
18578 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
18579
0fed43f3
PE
18580 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
18581 Without this fix, on a 64-bit host (aset S 0 4294967386) would
18582 incorrectly succeed when S was a string, because 4294967386 was
18583 truncated before it was used.
18584
8fd02eb7
PE
18585 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
18586 Otherwise, an out-of-range integer could cause undefined behavior
18587 on a 64-bit host.
18588
f8c86b69
PE
18589 * composite.c: Use int, not EMACS_INT, for characters.
18590 (fill_gstring_body, composition_compute_stop_pos): Use int, not
18591 EMACS_INT, for values that are known to be in character range.
18592 This doesn't fix any bugs but is the usual style inside Emacs and
18593 may generate better code on 32-bit machines.
18594
34206dd2
PE
18595 Make sure a 64-bit char is never passed to ENCODE_CHAR.
18596 This is for reasons similar to the recent CHAR_STRING fix.
18597 * charset.c (Fencode_char): Check that character arg is actually
18598 a character. Pass an int to ENCODE_CHAR.
18599 * charset.h (ENCODE_CHAR): Verify that the character argument is no
18600 wider than 'int', as a compile-time check to prevent future regressions
18601 in this area.
18602
c5958d4c 18603 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
18604
18605 Make sure a 64-bit char is never passed to CHAR_STRING.
18606 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
18607 by silently ignoring the top 32 bits, allowing some values
18608 that were far too large to be valid characters.
18609 * character.h: Include <verify.h>.
18610 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
18611 arguments are no wider than unsigned, as a compile-time check
18612 to prevent future regressions in this area.
18613 * data.c (Faset):
01103c44 18614 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
18615 (Fsubst_char_in_region):
18616 * fns.c (concat):
18617 * xdisp.c (decode_mode_spec_coding):
18618 Adjust to CHAR_STRING's new requirement.
18619 * editfns.c (Finsert_char, Fsubst_char_in_region):
18620 * fns.c (concat): Check that character args are actually
18621 characters. Without this test, these functions did the wrong
18622 thing with wildly out-of-range values on 64-bit hosts.
18623
d37ca623
PE
18624 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
18625 These casts should not be needed on 32-bit hosts, either.
18626 * keyboard.c (read_char):
18627 * lread.c (Fload): Remove casts to unsigned.
18628
ea204efb
PE
18629 * lisp.h (UNSIGNED_CMP): New macro.
18630 This fixes comparison bugs on 64-bit hosts.
18631 (ASCII_CHAR_P): Use it.
18632 * casefiddle.c (casify_object):
01103c44 18633 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
18634 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
18635 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
18636 * dispextern.h (FACE_FROM_ID):
18637 * keyboard.c (read_char): Use UNSIGNED_CMP.
18638
41cb286c
PE
18639 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
18640 not to EMACS_INT, to avoid GCC warning.
18641
4a1b9832
PE
18642 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
18643
55daad71
PE
18644 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
18645 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
18646 isn't needed on 32-bit machines.
8f95c75c 18647
01103c44
PE
18648 * buffer.c (Fgenerate_new_buffer_name):
18649 Use EMACS_INT for count, not int.
0ceccced 18650 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
18651
18652 * data.c (Qcompiled_function): Now static.
18653
c6f072e7
PE
18654 * window.c (window_body_lines): Now static.
18655
20ce5912
PE
18656 * image.c (gif_load): Rename local to avoid shadowing.
18657
9c4c5f81
PE
18658 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
18659 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
18660 * alloc.c (make_save_value): Integer argument is now of type
18661 ptrdiff_t, not int.
18662 (mark_object): Use ptrdiff_t, not int.
18663 * lisp.h (pD): New macro.
18664 * print.c (print_object): Use it.
18665
c0c5c8ae
PE
18666 * alloc.c: Use EMACS_INT, not int, to count objects.
18667 (total_conses, total_markers, total_symbols, total_vector_size)
18668 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
18669 (total_free_floats, total_floats, total_free_intervals)
18670 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
18671 Now EMACS_INT, not int. All uses changed.
18672 (Fgarbage_collect): Compute overall total using a double, so that
18673 integer overflow is less likely to be a problem. Check for overflow
18674 when converting back to an integer.
5a25e253
PE
18675 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
18676 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
18677 These were 'int' variables that could overflow on 64-bit hosts;
18678 they were never used, so remove them instead of repairing them.
211a0b2a 18679 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
18680 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
18681 Previously, this ceilinged at INT_MAX, but that doesn't work on
18682 64-bit machines.
e46bb31a 18683 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 18684
c78baabf 18685 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 18686 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
18687 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
18688 when a (possibly-narrower) signed value would do just as well.
18689 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 18690
c9d624c6
PE
18691 * alloc.c: Catch some string size overflows that we were missing.
18692 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
18693 for convenience in STRING_BYTES_MAX.
18694 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
18695 The definition here is exact; the one in lisp.h was approximate.
18696 (allocate_string_data): Check for string overflow. This catches
18697 some instances we weren't catching before. Also, it catches
18698 size_t overflow on (unusual) hosts where SIZE_MAX <= min
18699 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
18700 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 18701
c9d624c6
PE
18702 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
18703 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 18704 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 18705
353032ce
PE
18706 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
18707
2bccce07
PE
18708 * alloc.c (Fmake_string): Check for out-of-range init.
18709
0ac30604
SM
187102011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
18711
18712 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
18713
c195f2de
JD
187142011-06-14 Jan Djärv <jan.h.d@swipnet.se>
18715
18716 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
18717 xg_get_default_scrollbar_width.
18718
18719 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
18720 (int_gtk_range_get_value): Move to the scroll bar part of the file.
18721 (style_changed_cb): Call update_theme_scrollbar_width and call
18722 x_set_scroll_bar_default_width and xg_frame_set_char_size for
18723 all frames (Bug#8505).
18724 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
18725 Call gtk_window_set_resizable if HAVE_GTK3.
18726 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
18727 and height if HAVE_GTK3 (Bug#8505).
18728 (scroll_bar_width_for_theme): New variable.
18729 (update_theme_scrollbar_width): New function.
18730 (xg_get_default_scrollbar_width): Move code to
18731 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
18732 (xg_initialize): Call update_theme_scrollbar_width.
18733
18734 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
18735
18736 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
18737
e10ac9f1
MR
187382011-06-12 Martin Rudalics <rudalics@gmx.at>
18739
18740 * frame.c (make_frame): Call other_buffer_safely instead of
18741 other_buffer.
18742
18743 * window.c (temp_output_buffer_show): Call display_buffer with
18744 second argument Vtemp_buffer_show_specifiers and reset latter
18745 immediately after the call.
18746 (Vtemp_buffer_show_specifiers): New variable.
18747 (auto_window_vscroll_p, next_screen_context_lines)
18748 (Vscroll_preserve_screen_position): Remove leading asterisks from
18749 doc-strings.
18750
2d3c217e 187512011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 18752
7b7f97e8 18753 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
18754 * buffer.c (Qclone_number): Remove for now, as it's unused.
18755 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
18756 (record_buffer): Remove unused local.
18757 * frame.c (other_visible_frames, frame_buffer_list): Now static.
18758 (set_frame_buffer_list): Remove; unused.
18759 * frame.h (other_visible_frames): Remove decl.
18760 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
18761 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
18762 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
18763 if HAVE_GPM.
18764 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
18765 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
18766 Define only if HAVE_GPM.
18767 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
18768 (update_hints_inhibit): Remove; never set. All uses removed.
18769 * widgetprv.h (emacsFrameClassRec): Remove decl.
18770 * window.c (delete_deletable_window): Now returns void, since it
18771 wasn't returning anything.
18772 (compare_window_configurations): Remove unused locals.
18773 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
18774 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
18775 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
18776 the same widths as pointers. This follows up on the 2011-05-06 patch.
18777 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
18778 * xterm.h: Likewise.
18779 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
18780
1384b89e
JB
187812011-06-12 Juanma Barranquero <lekktu@gmail.com>
18782
18783 * makefile.w32-in: Update dependencies.
18784 (LISP_H): Add lib/intprops.h.
18785
1100a63c
CY
187862011-06-11 Chong Yidong <cyd@stupidchicken.com>
18787
18788 * image.c (gif_load): Add animation frame delay to the metadata.
18789 (syms_of_image): Use DEFSYM. New symbol `delay'.
18790
6198ccd0
MR
187912011-06-11 Martin Rudalics <rudalics@gmx.at>
18792
18793 * window.c (delete_deletable_window): Re-add.
18794 (Fset_window_configuration): Rewrite to handle dead buffers and
18795 consequently deletable windows.
18796 (window_tree, Fwindow_tree): Remove. Supply functionality in
18797 window.el.
18798 (compare_window_configurations): Simplify code.
18799
b6e3633c
AS
188002011-06-11 Andreas Schwab <schwab@linux-m68k.org>
18801
1ab0dee5
AS
18802 * image.c (imagemagick_load_image): Fix type mismatch.
18803 (Fimagemagick_types): Likewise.
18804
b6e3633c
AS
18805 * window.h (replace_buffer_in_windows): Declare.
18806
9397e56f
MR
188072011-06-11 Martin Rudalics <rudalics@gmx.at>
18808
18809 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
18810 Qclone_number. Remove external declaration of Qdelete_window.
18811 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
18812 code.
640c8776
SM
18813 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
18814 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
18815 (Fother_buffer): Rewrite doc-string. Major rewrite for new
18816 buffer list implementation.
18817 (other_buffer_safely): New function.
18818 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
18819 calls to replace_buffer_in_windows and
18820 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
18821 if allowed.
18822 (record_buffer): Inhibit quitting and rewrite using quittable
18823 functions. Run Qbuffer_list_update_hook if allowed.
18824 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
18825 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
18826 Move switch-to-buffer to window.el.
9397e56f
MR
18827 (bury-buffer): Move to window.el.
18828 (Vbuffer_list_update_hook): New variable.
18829
18830 * lisp.h (other_buffer_safely): Add prototype in buffer.c
18831 section.
18832
18833 * window.h (resize_frame_windows): Move up in code.
18834 (Fwindow_frame): Remove EXFUN.
18835 (replace_buffer_in_all_windows): Remove prototype.
18836 (replace_buffer_in_windows_safely): Add prototype.
18837
18838 * window.c: Declare Qdelete_window static again. Move down
18839 declaration of select_count.
18840 (Fnext_window, Fprevious_window): Rewrite doc-strings.
18841 (Fother_window): Move to window.el.
18842 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
18843 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
18844 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
18845 window.el.
18846 (replace_buffer_in_windows): Implement by calling
18847 Qreplace_buffer_in_windows.
18848 (replace_buffer_in_all_windows): Remove with some functionality
18849 moved into replace_buffer_in_windows_safely.
18850 (replace_buffer_in_windows_safely): New function.
18851 (select_window_norecord, select_frame_norecord): Move in front
18852 of run_window_configuration_change_hook. Remove now obsolete
18853 declarations.
640c8776
SM
18854 (Fset_window_buffer): Rewrite doc-string.
18855 Call Qrecord_window_buffer.
9397e56f
MR
18856 (keys_of_window): Move binding for other-window to window.el.
18857
b50691aa
CY
188582011-06-11 Chong Yidong <cyd@stupidchicken.com>
18859
18860 * dispextern.h (struct image): Replace data member, whose int_val
18861 and ptr_val fields were not used by anything, with a single
18862 lisp_val object.
18863
18864 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
18865 (gif_clear_image, gif_load, imagemagick_load_image)
18866 (gs_clear_image, gs_load): Callers changed.
18867
3f754b86
PE
188682011-06-10 Paul Eggert <eggert@cs.ucla.edu>
18869
cca69397
PE
18870 * buffer.h: Include <time.h>, for time_t.
18871 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
18872
109e28d0
PE
18873 Fix minor problems found by static checking.
18874
60737f02
PE
18875 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
18876
4b66faf3
PE
18877 Make identifiers static if they are not used in other modules.
18878 * data.c (Qcompiled_function, Qframe, Qvector):
18879 * image.c (QimageMagick, Qsvg):
18880 * minibuf.c (Qmetadata):
18881 * window.c (resize_window_check, resize_root_window): Now static.
18882 * window.h (resize_window_check, resize_root_window): Remove decls.
18883
109e28d0
PE
18884 * window.c (window_deletion_count, delete_deletable_window):
18885 Remove; unused.
46a4ce9e
PE
18886 (window_body_lines): Now static.
18887 (Fdelete_other_windows_internal): Mark vars as initialized.
18888 Make sure 'resize_failed' is initialized.
18889 (run_window_configuration_change_hook): Rename local to avoid shadowing.
18890 (resize_window_apply): Remove unused local.
18891 * window.h (delete_deletable_window): Remove decl.
18892
109e28d0 18893 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
18894 (imagemagick_load_image): Fix pointer signedness problem by changing
18895 last arg from unsigned char * to char *. All uses changed.
18896 Also, fix a local for similar reasons.
18897 Remove unused locals. Remove locals to avoid shadowing.
18898 (fn_rsvg_handle_free): Remove; unused.
18899 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 18900 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 18901
3f754b86
PE
18902 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
18903
2547adb1
CY
189042011-06-10 Chong Yidong <cyd@stupidchicken.com>
18905
18906 * image.c (gif_load): Fix omitted cast error introduced by
18907 2011-06-06 change.
18908
2c8e37d4
MR
189092011-06-10 Martin Rudalics <rudalics@gmx.at>
18910
18911 * window.h (resize_proportionally, orig_total_lines)
18912 (orig_top_line): Remove from window structure.
18913 (set_window_height, set_window_width, change_window_heights)
18914 (Fdelete_window): Remove prototypes.
18915 (resize_frame_windows): Remove duplicate declaration.
18916
440a42e3
EZ
189172011-06-10 Eli Zaretskii <eliz@gnu.org>
18918
18919 * window.h (resize_frame_windows, resize_window_check)
18920 (delete_deletable_window, resize_root_window)
18921 (resize_frame_windows): Declare prototypes.
18922
18923 * window.c (resize_window_apply): Make definition be "static" to
18924 match the prototype.
18925
562dd5e9
MR
189262011-06-10 Martin Rudalics <rudalics@gmx.at>
18927
18928 * window.c: Remove declarations of Qwindow_size_fixed,
18929 window_min_size_1, window_min_size_2, window_min_size,
18930 size_window, window_fixed_size_p, enlarge_window, delete_window.
18931 Remove static from declaration of Qdelete_window, it's
18932 temporarily needed by Fbury_buffer.
18933 (replace_window): Don't assign orig_top_line and
18934 orig_total_lines.
18935 (Fdelete_window, delete_window): Remove. Window deletion is
18936 handled by window.el.
640c8776
SM
18937 (window_loop): Remove DELETE_OTHER_WINDOWS case.
18938 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
18939 (Fdelete_other_windows): Remove. Deleting other windows is
18940 handled by window.el.
18941 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
18942 handled in window.el.
18943 (window_min_size_2, window_min_size_1, window_min_size): Remove.
18944 Window minimum sizes are handled in window.el.
18945 (shrink_windows, size_window, set_window_height)
18946 (set_window_width, change_window_heights, window_height)
18947 (window_width, CURBEG, CURSIZE, enlarge_window)
18948 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
18949 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
18950 handled in window.el.
18951 (make_dummy_parent): Rename to make_parent_window and give it a
18952 second argument horflag.
18953 (make_window): Don't set resize_proportionally any more.
18954 (Fsplit_window): Remove. Windows are split in window.el.
18955 (save_restore_action, save_restore_orig_size)
18956 (shrink_window_lowest_first, save_restore_orig_size): Remove.
18957 Resize mini windows in window.el.
18958 (grow_mini_window, shrink_mini_window): Implement by calling
18959 Qresize_root_window_vertically, resize_window_check and
18960 resize_window_apply.
640c8776
SM
18961 (saved_window, Fset_window_configuration, save_window_save):
18962 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
18963 resize_proportionally.
18964 (window_min_height, window_min_width): Move to window.el.
18965 (keys_of_window): Move bindings for delete-other-windows,
18966 split-window, delete-window and enlarge-window to window.el.
18967
18968 * buffer.c: Temporarily extern Qdelete_window.
18969 (Fbury_buffer): Temporarily call Qdelete_window instead of
18970 Fdelete_window (Fbury_buffer will move to window.el soon).
18971
18972 * frame.c (set_menu_bar_lines_1): Remove code handling
18973 orig_top_line and orig_total_lines.
18974
18975 * dispnew.c (adjust_frame_glyphs_initially): Don't use
18976 set_window_height but set heights directly.
18977 (change_frame_size_1): Use resize_frame_windows.
18978
18979 * xdisp.c (init_xdisp): Don't use set_window_height but set
18980 heights directly.
18981
640c8776
SM
18982 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
18983 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
18984 run_window_configuration_change_hook.
18985
18986 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
18987 instead of change_window_heights and run
18988 run_window_configuration_change_hook.
18989
1a13852e
MR
189902011-06-09 Martin Rudalics <rudalics@gmx.at>
18991
18992 * window.c (replace_window): Rename second argument REPLACEMENT to
18993 NEW. New third argument SETFLAG. Rewrite.
18994 (delete_window, make_dummy_parent): Call replace_window with
18995 third argument 1.
18996 (window_list_1): Move down in code.
18997 (run_window_configuration_change_hook): Move set_buffer part
18998 before select_frame_norecord part in order to unwind correctly.
18999 Rename count1 to count.
19000 (recombine_windows, delete_deletable_window, resize_root_window)
19001 (Fdelete_other_windows_internal)
19002 (Frun_window_configuration_change_hook, make_parent_window)
19003 (resize_window_check, resize_window_apply, Fresize_window_apply)
19004 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
19005 (Fdelete_window_internal, Fresize_mini_window_internal):
19006 New functions.
1a13852e
MR
19007 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
19008
f3d1777e
MR
190092011-06-08 Martin Rudalics <rudalics@gmx.at>
19010
496e208e
MR
19011 * window.h (window): Add some new members to window structure -
19012 normal_lines, normal_cols, new_total, new_normal, clone_number,
19013 splits, nest, prev_buffers, next_buffers.
19014 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 19015 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 19016
f3d1777e
MR
19017 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
19018 Remove.
496e208e
MR
19019 (make_dummy_parent): Set new members of windows structure.
19020 (make_window): Move down in code. Handle new members of window
19021 structure.
19022 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
19023 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
19024 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
19025 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
19026 (Fset_window_next_buffers, Fset_window_clone_number):
19027 New functions.
496e208e
MR
19028 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
19029 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
19030 Doc-string fixes.
19031 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
19032 Argument WINDOW can be now internal window too.
19033 (Fwindow_use_time): Move up in code.
19034 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
19035 Rewrite doc-string.
19036 (Fset_window_configuration, saved_window)
19037 (Fcurrent_window_configuration, save_window_save): Handle new
19038 members of window structure.
b9e809c2
MR
19039 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
19040 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
19041 (syms_of_window): New Lisp objects Qrecord_window_buffer,
19042 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
19043 Qget_mru_window, Qresize_root_window,
19044 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
19045 Qauto_buffer_name; staticpro them.
f3d1777e 19046
abde8f8c
MR
190472011-06-07 Martin Rudalics <rudalics@gmx.at>
19048
19049 * window.c (Fwindow_total_size, Fwindow_left_column)
19050 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
19051 (Fwindow_list_1): New functions.
19052 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
19053 (Fwindow_width, Fscroll_left, Fscroll_right):
19054 Use window_body_cols instead of window_box_text_cols.
19055 (delete_window, Fset_window_configuration):
19056 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
19057 (delete_all_subwindows): Take a window as argument and not a
19058 structure. Rewrite.
190b47e6
MR
19059 (window_loop): Remove handling of GET_LRU_WINDOW and
19060 GET_LARGEST_WINDOW.
19061 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
19062
19063 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
19064 window_box_text_cols. delete_all_subwindows now takes a
19065 Lisp_Object as argument.
abde8f8c 19066
640c8776
SM
19067 * indent.c (compute_motion, Fcompute_motion):
19068 Use window_body_cols instead of window_box_text_cols.
abde8f8c 19069
fa8a67e6
MR
19070 * frame.c (delete_frame): Call delete_all_subwindows with root
19071 window as argument.
19072
a54e3482
DC
190732011-06-07 Daniel Colascione <dan.colascione@gmail.com>
19074
19075 * fns.c (Fputhash): Document return value.
19076
60002bf5
CY
190772011-06-06 Chong Yidong <cyd@stupidchicken.com>
19078
19079 * image.c (gif_load): Implement gif89a spec "no disposal" method.
19080
0c671da6 190812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 19082
b862a52a 19083 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 19084
be44ca6c
PE
19085 Check for overflow when converting integer to cons and back.
19086 * charset.c (Fdefine_charset_internal, Fdecode_char):
19087 Use cons_to_unsigned to catch overflow.
19088 (Fencode_char): Use INTEGER_TO_CONS.
19089 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
19090 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
19091 * data.c (long_to_cons, cons_to_long): Remove.
19092 (cons_to_unsigned, cons_to_signed): New functions.
19093 These signal an error for invalid or out-of-range values.
19094 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
19095 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
19096 * font.c (Ffont_variation_glyphs):
19097 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
19098 * lisp.h: Include <intprops.h>.
19099 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
19100 (cons_to_signed, cons_to_unsigned): New decls.
19101 (long_to_cons, cons_to_long): Remove decls.
19102 * undo.c (record_first_change): Use INTEGER_TO_CONS.
19103 (Fprimitive_undo): Use CONS_TO_INTEGER.
19104 * xfns.c (Fx_window_property): Likewise.
19105 * xselect.c: Include <limits.h>.
19106 (x_own_selection, selection_data_to_lisp_data):
19107 Use INTEGER_TO_CONS.
19108 (x_handle_selection_request, x_handle_selection_clear)
19109 (x_get_foreign_selection, Fx_disown_selection_internal)
19110 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
19111 (lisp_data_to_selection_data): Use cons_to_unsigned.
19112 (x_fill_property_data): Use cons_to_signed.
19113 Report values out of range.
19114
d1f3d2af
PE
19115 Check for buffer and string overflow more precisely.
19116 * buffer.h (BUF_BYTES_MAX): New macro.
19117 * lisp.h (STRING_BYTES_MAX): New macro.
19118 * alloc.c (Fmake_string):
19119 * character.c (string_escape_byte8):
19120 * coding.c (coding_alloc_by_realloc):
19121 * doprnt.c (doprnt):
19122 * editfns.c (Fformat):
19123 * eval.c (verror):
19124 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
19125 since they may not be the same number.
19126 * editfns.c (Finsert_char):
19127 * fileio.c (Finsert_file_contents):
19128 Likewise for BUF_BYTES_MAX.
19129
dd52fcea
PE
19130 * image.c: Use ptrdiff_t, not int, for sizes.
19131 (slurp_file): Switch from int to ptrdiff_t.
19132 All uses changed.
19133 (slurp_file): Check that file size fits in both size_t (for
19134 malloc) and ptrdiff_t (for sanity and safety).
19135
7f9bbdbb
PE
19136 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
19137 if b->modtime has its maximal value.
19138
dfe18f82
PE
19139 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
19140
84acfcf0
PE
19141 Don't assume time_t can fit into int.
19142 * buffer.h (struct buffer.modtime): Now time_t, not int.
19143 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
19144 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
19145
ccd9a01a
PE
19146 Minor fixes for signed vs unsigned integers.
19147 * character.h (MAYBE_UNIFY_CHAR):
19148 * charset.c (maybe_unify_char):
19149 * keyboard.c (read_char, reorder_modifiers):
19150 XINT -> XFASTINT, since the integer must be nonnegative.
19151 * ftfont.c (ftfont_spec_pattern):
19152 * keymap.c (access_keymap, silly_event_symbol_error):
19153 XUINT -> XFASTINT, since the integer must be nonnegative.
19154 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
19155 since it makes no difference and we prefer signed.
19156 * keyboard.c (record_char): Use XUINT when all the neighbors do.
19157 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
19158 nonnegative.
19159
d6d100dd
SM
191602011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
19161
19162 * window.h (Fwindow_frame): Declare.
19163
2b6148e4
PE
191642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
19165
19166 * alloc.c: Simplify handling of large-request failures (Bug#8800).
19167 (SPARE_MEMORY): Always define.
19168 (LARGE_REQUEST): Remove.
19169 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
19170
f230ecc9
MR
191712011-06-06 Martin Rudalics <rudalics@gmx.at>
19172
727e958e
MR
19173 * lisp.h: Move EXFUNS for Fframe_root_window,
19174 Fframe_first_window and Fset_frame_selected_window to window.h.
19175
19176 * window.h: Move EXFUNS for Fframe_root_window,
19177 Fframe_first_window and Fset_frame_selected_window here from
19178 lisp.h.
19179
19180 * frame.c (Fwindow_frame, Fframe_first_window)
19181 (Fframe_root_window, Fframe_selected_window)
19182 (Fset_frame_selected_window): Move to window.c.
19183 (Factive_minibuffer_window): Move to minibuf.c.
19184 (Fother_visible_frames_p): New function.
19185
19186 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
19187
f230ecc9
MR
19188 * window.c (decode_window, decode_any_window): Move up in code.
19189 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
19190 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
19191 (Fwindow_buffer): Move up and rewrite doc-string.
19192 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
19193 (Fwindow_prev): New functions.
727e958e
MR
19194 (Fwindow_frame): Move here from frame.c. Accept any window as
19195 argument.
19196 (Fframe_root_window, Fframe_first_window)
19197 (Fframe_selected_window): Move here from frame.c. Accept frame
19198 or arbitrary window as argument. Update doc-strings.
19199 (Fminibuffer_window): Move up in code.
19200 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
19201 (Fset_frame_selected_window): Move here from frame.c.
19202 Marginal rewrite.
727e958e
MR
19203 (Fselected_window, select_window, Fselect_window): Move up in
19204 code. Minor doc-string fixes.
f230ecc9 19205
4d09bcf6
PE
192062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
19207
19208 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
19209 Do not assume that spare memory exists; that assumption is valid
19210 only if SYSTEM_MALLOC.
19211 (LARGE_REQUEST): New macro, so that the issue of large requests
19212 is separated from the issue of spare memory.
19213
810928a2
AS
192142011-06-05 Andreas Schwab <schwab@linux-m68k.org>
19215
172418ad
AS
19216 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
19217 format. (Bug#8806)
19218
43f862f7
AS
19219 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
19220
810928a2
AS
19221 * xfns.c (x_set_scroll_bar_default_width): Move declarations
19222 before statements.
19223
a059fe24
JD
192242011-06-05 Jan Djärv <jan.h.d@swipnet.se>
19225
19226 * gtkutil.c (xg_get_default_scrollbar_width): New function.
19227
19228 * gtkutil.h: Declare xg_get_default_scrollbar_width.
19229
19230 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
19231 min width by calling x_set_scroll_bar_default_width (Bug#8505).
19232
989bf368
JB
192332011-06-05 Juanma Barranquero <lekktu@gmail.com>
19234
19235 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
19236
4b80f674
CY
192372011-06-04 Chong Yidong <cyd@stupidchicken.com>
19238
19239 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
19240 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
19241 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
19242 New error handlers.
4b80f674
CY
19243 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
19244 Obey Vx_select_enable_clipboard_manager. Catch errors in
19245 x_clipboard_manager_save (Bug#8779).
19246 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 19247 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 19248
99a33b77 192492011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
19250
19251 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
19252
99a33b77 192532011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
19254
19255 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
19256 in the current matrix if keep_current_p is non-zero.
19257
8264569d
EZ
192582011-06-04 Eli Zaretskii <eliz@gnu.org>
19259
19260 * bidi.c (bidi_level_of_next_char): Fix last change.
19261
57f97249
EZ
192622011-06-03 Eli Zaretskii <eliz@gnu.org>
19263
fec2107c 19264 Support bidi reordering of text covered by display properties.
57f97249 19265
fec2107c
EZ
19266 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
19267 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
19268 (bidi_cache_search, bidi_cache_iterator_state)
19269 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
19270 (bidi_level_of_next_char, bidi_move_to_visually_next):
19271 Support character positions inside a run of characters covered by a
fec2107c
EZ
19272 display string.
19273 (bidi_paragraph_init, bidi_resolve_explicit_1)
19274 (bidi_level_of_next_char): Call bidi_fetch_char and
19275 bidi_fetch_char_advance instead of FETCH_CHAR and
19276 FETCH_CHAR_ADVANCE.
19277 (bidi_init_it): Initialize new members.
19278 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
19279 definitions.
19280 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
19281 instead of using explicit *_CHAR codes.
d6d100dd
SM
19282 (bidi_resolve_explicit, bidi_resolve_weak):
19283 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
19284 bidirectional text is supported only in multibyte buffers.
19285 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
19286 it to initialize the frame_window_p member of struct bidi_it.
19287 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
19288 (bidi_resolve_explicit, bidi_resolve_weak)
19289 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
19290 bidi_it->nchars is non-positive.
19291 (bidi_level_of_next_char): Don't try to lookup the cache for the
19292 next/previous character if nothing is cached there yet, or if we
19293 were just reseat()'ed to a new position.
c40e2fb2 19294
0e14fe90
EZ
19295 * xdisp.c (set_cursor_from_row): Set start and stop points
19296 according to the row's direction when priming the loop that looks
19297 for the glyph on which to display cursor.
19298 (single_display_spec_intangible_p): Function deleted.
19299 (display_prop_intangible_p): Reimplement to call
19300 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
19301 Accept 3 additional arguments needed by handle_display_spec.
19302 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
19303 values: lists, `(when COND...)' forms, etc.
19304 (single_display_spec_string_p): Support property values that are
19305 lists with the argument STRING its top-level element.
19306 (display_prop_string_p): Fix the condition for processing a
19307 property that is a list to be consistent with handle_display_spec.
fec2107c 19308 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
19309 last portion of handle_display_prop.
19310 (compute_display_string_pos): Accept additional argument
19311 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
19312 value of a `display' property is a "replacing spec".
19313 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
19314 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
19315 the display property, but just return a value indicating whether
19316 the display property will replace the characters it covers.
19317 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
19318 frame_window_p members of struct bidi_it.
d6d100dd
SM
19319 (compute_display_string_pos, compute_display_string_end):
19320 New functions.
fec2107c
EZ
19321 (push_it): Accept second argument POSITION, where pop_it should
19322 jump to continue iteration.
19323 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 19324
fec2107c
EZ
19325 * keyboard.c (adjust_point_for_property): Adjust the call to
19326 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
19327
19328 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
19329 (bidi_init_it): Update prototypes.
19330 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
19331 (compute_display_string_pos, compute_display_string_end):
19332 Declare prototypes.
fec2107c
EZ
19333 (struct bidi_it): New members nchars and disp_pos. ch_len is now
19334 EMACS_INT.
fc6f18ce 19335
40087514 193362011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 19337
57f53182
PE
19338 Malloc failure behavior now depends on size of allocation.
19339 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
19340 * lisp.h: Change signatures accordingly.
19341 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
19342 All callers changed. (Bug#8762)
19343
19344 * gnutls.c: Use Emacs's memory allocators.
19345 Without this change, the gnutls library would invoke malloc etc.
19346 directly, which causes problems on non-SYNC_INPUT hosts, and which
19347 runs afoul of improving memory_full behavior. (Bug#8761)
19348 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
19349 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
19350 xfree instead of the default malloc, realloc, free.
19351 (Fgnutls_boot): No need to check for memory allocation failure,
19352 since xmalloc does that for us.
19353
ac32cd99 19354 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
19355 * category.c (hash_get_category_set):
19356 * ccl.c (ccl_driver):
19357 * charset.c (Fdefine_charset_internal):
19358 * charset.h (struct charset.hash_index):
19359 * composite.c (get_composition_id, gstring_lookup_cache)
19360 (composition_gstring_put_cache):
19361 * composite.h (struct composition.hash_index):
19362 * dispextern.h (struct image.hash):
19363 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
19364 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
19365 (hashfn_equal, hashfn_user_defined, make_hash_table)
19366 (maybe_resize_hash_table, hash_lookup, hash_put)
19367 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
19368 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
19369 (Fsxhash, Fgethash, Fputhash, Fmaphash):
19370 * image.c (make_image, search_image_cache, lookup_image)
19371 (xpm_put_color_table_h):
19372 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 19373 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 19374 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 19375 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
19376 * alloc.c (allocate_vectorlike):
19377 Check for overflow in vector size calculations.
19378 * ccl.c (ccl_driver):
19379 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
19380 * fns.c, image.c: Remove unnecessary static decls that would otherwise
19381 need to be updated by these changes.
40087514
PE
19382 * fns.c (make_hash_table, maybe_resize_hash_table):
19383 Check for integer overflow with large hash tables.
0de4bb68
PE
19384 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
19385 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
19386 (SXHASH_REDUCE): New macro.
19387 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
19388 Use it instead of discarding useful hash info with large hash values.
19389 (sxhash_float): New function.
19390 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
19391 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
19392 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
19393 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
19394 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
19395 Adjust signatures to match updated version of code.
19396 (consing_since_gc): Now EMACS_INT, since a single hash table can
19397 use more than INT_MAX bytes.
19398
698d32e2
DN
193992011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
19400
19401 Make it possible to build with GCC-4.6+ -O2 -flto.
19402
19403 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
19404
fd6fa53f
SM
194052011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
19406
19407 * minibuf.c (get_minibuffer, read_minibuf_unwind):
19408 Call minibuffer-inactive-mode.
19409
864db017
JB
194102011-05-31 Juanma Barranquero <lekktu@gmail.com>
19411
19412 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
19413 Update dependencies.
19414
2ad0baf4
DN
194152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
19416
19417 * data.c (init_data): Remove code for UTS, this system is not
19418 supported anymore.
19419
4fcc2638
DN
194202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
19421
19422 Don't force ./temacs to start in terminal mode.
19423
19424 * frame.c (make_initial_frame): Initialize faces in all cases, not
19425 only when CANNOT_DUMP is defined.
19426 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
19427
c56e0fd5
DN
194282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
19429
19430 * dispnew.c (add_window_display_history): Use const for the string
19431 pointer. Remove declaration, not needed.
19432
333d54da 194332011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 19434
55d4c1b2 19435 Use 'inline', not 'INLINE'.
333d54da 19436 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
19437 * alloc.c, fontset.c (INLINE): Remove.
19438 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
19439 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
19440 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
19441 * gmalloc.c (register_heapinfo): Use inline unconditionally.
19442 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
19443
738db178
DN
194442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
19445
19446 Make it possible to run ./temacs.
19447
19448 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
19449 syms_of_callproc does the same thing. Remove test for
19450 "initialized", do it in the caller.
19451 * emacs.c (main): Avoid calling set_initial_environment when dumping.
19452
620c53a6
SM
194532011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
19454
19455 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
19456 (read_minibuf): Use get_minibuffer.
19457 (syms_of_minibuf): Use DEFSYM.
19458 (Qmetadata): New var.
19459 * data.c (Qbuffer): Don't make it static.
19460 (syms_of_data): Use DEFSYM.
19461
e003a292
PE
194622011-05-31 Paul Eggert <eggert@cs.ucla.edu>
19463
19464 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
19465 (CCL_CODE_MIN): New macro.
19466
ed008a6d
PE
194672011-05-30 Paul Eggert <eggert@cs.ucla.edu>
19468
3687c2ef
PE
19469 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
19470
ed008a6d
PE
19471 * eval.c (Qdebug): Now static.
19472 * lisp.h (Qdebug): Remove decl. This reverts a part of the
19473 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
19474 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
19475
d66c4c7c
CY
194762011-05-29 Chong Yidong <cyd@stupidchicken.com>
19477
19478 * image.c: Various fixes to ImageMagick code comments.
19479 (Fimagemagick_types): Doc fix.
19480
5fbc2025
PE
194812011-05-29 Paul Eggert <eggert@cs.ucla.edu>
19482
0196f88a
PE
19483 Minor fixes prompted by GCC 4.6.0 warnings.
19484
19485 * xselect.c (converted_selections, conversion_fail_tag): Now static.
19486
5fbc2025
PE
19487 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
19488 (x_clipboard_manager_save_all): Move extern decl to ...
19489 * xterm.h: ... here, so that it can be checked for consistency.
19490
1dd3c2d9
CY
194912011-05-29 Chong Yidong <cyd@stupidchicken.com>
19492
19493 * xselect.c (x_clipboard_manager_save_frame)
19494 (x_clipboard_manager_save_all): New functions.
19495 (Fx_clipboard_manager_save): Lisp function deleted.
19496
19497 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
19498 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
19499
19500 * xterm.h: Update prototype.
19501
5ba6571d
WX
195022011-05-28 William Xu <william.xwl@gmail.com>
19503
19504 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
19505 exiting (Bug#8239).
19506
3eaff834
JM
195072011-05-28 Jim Meyering <meyering@redhat.com>
19508
e1900994 19509 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
19510 * fns.c (to_uchar): Define.
19511 (crypto_hash_function): Use it to convert some newly-signed
19512 variables to unsigned, to avoid sign-extension bugs. For example,
19513 without this change, (md5 "truc") would evaluate to
19514 45723a2aff78ff4fff7fff1114760e62 rather than the expected
19515 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 19516 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 19517
0f6990a7
PE
195182011-05-27 Paul Eggert <eggert@cs.ucla.edu>
19519
19520 Integer overflow fixes.
c8a9ca5a 19521
08686060
PE
19522 * dbusbind.c: Serial number integer overflow fixes.
19523 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
19524 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
19525 to hold a serial number that is too large for a fixnum.
19526 (Fdbus_method_return_internal, Fdbus_method_error_internal):
19527 Check for serial numbers out of range. Decode any serial number
59568bf0 19528 that was so large that it became a float. (Bug#8722)
08686060 19529
2d1fc3c7
PE
19530 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
19531 (Fdbus_call_method, Fdbus_call_method_asynchronously):
19532 Use XFASTINT rather than XUINT when numbers are nonnegative.
19533 (xd_append_arg, Fdbus_method_return_internal):
19534 (Fdbus_method_error_internal): Likewise. Also, for unsigned
19535 arguments, check that Lisp number is nonnegative, rather than
59568bf0 19536 silently wrapping negative numbers around. (Bug#8722)
30217ff0 19537 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 19538 (Bug#8722)
2d1fc3c7 19539
c8a9ca5a
PE
19540 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
19541
519e1d69
PE
19542 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
19543
6df6ae42 19544 ccl: Add integer overflow checks.
30569699
PE
19545 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
19546 (IN_INT_RANGE): New macros.
19547 (ccl_driver): Use them to check for integer overflow when
19548 decoding a CCL program. Many of the new checks are whether XINT (x)
19549 fits in int; it doesn't always, on 64-bit hosts. The new version
19550 doesn't catch all possible integer overflows, but it's an
847044ea 19551 improvement. (Bug#8719)
30569699 19552
c11285dc
PE
19553 * alloc.c (make_event_array): Use XINT, not XUINT.
19554 There's no need for unsigned here.
19555
fdccd48e
PE
19556 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
19557 This follows up to the 2011-05-06 change that substituted uintptr_t
19558 for EMACS_INT. This case wasn't caught back then.
19559
37910ab2
PE
19560 Rework Fformat to avoid integer overflow issues.
19561 * editfns.c: Include <float.h> unconditionally, as it's everywhere
19562 now (part of C89). Include <verify.h>.
19563 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
19564 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
19565 (Fformat): Avoid the prepass trying to compute sizes; it was only
19566 approximate and thus did not catch overflow reliably. Instead, walk
19567 through the format just once, formatting and computing sizes as we go,
19568 checking for integer overflow at every step, and allocating a larger
19569 buffer as needed. Keep track separately whether the format is
19570 multibyte. Keep only the most-recently calculated precision, rather
19571 than them all. Record whether each argument has been converted to
19572 string. Use EMACS_INT, not int, for byte and char and arg counts.
19573 Support field widths and precisions larger than INT_MAX. Avoid
19574 sprintf's undefined behavior with conversion specifications such as %#d
19575 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
19576 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
19577 formatting out-of-range floating point numbers with int
9173deec 19578 formats. (Bug#8668)
37910ab2 19579
2e6578fb
PE
19580 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
19581
0ae6bdee
PE
19582 * data.c: Avoid integer truncation in expressions involving floats.
19583 * data.c: Include <intprops.h>.
19584 (arith_driver): When there's an integer overflow in an expression
19585 involving floating point, convert the integers to floating point
19586 so that the resulting value does not suffer from catastrophic
19587 integer truncation. For example, on a 64-bit host (* 4
19588 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
19589 Do not rely on undefined behavior after integer overflow.
19590
de883a70
PE
19591 merge count_size_as_multibyte, parse_str_to_multibyte
19592 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 19593 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
19594 Check for integer overflow.
19595 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
19596 since it's now a duplicate of the other. This is more of
19597 a character than a buffer op, so better that it's in character.c.
19598 * fns.c, print.c: Adjust to above changes.
19599
2ff916cb
PE
196002011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
19601
19602 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
19603
f1b54466
PE
196042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
19605
fb1ac845
PE
19606 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
19607 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
19608 (x_clipboard_manager_save): Now static.
19609 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
19610
f1b54466
PE
19611 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
19612 (crypto_hash_function): Now static.
19613 Fix pointer signedness problems. Avoid unnecessary initializations.
19614
a9f737ee
CY
196152011-05-27 Chong Yidong <cyd@stupidchicken.com>
19616
19617 * termhooks.h (Vselection_alist): Make it terminal-local.
19618
19619 * terminal.c (create_terminal): Initialize it.
19620
19621 * xselect.c: Support for clipboard managers.
19622 (Vselection_alist): Move to termhooks.h as terminal-local var.
19623 (LOCAL_SELECTION): New macro.
19624 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
19625 (symbol_to_x_atom): Remove gratuitous arg.
19626 (x_handle_selection_request, lisp_data_to_selection_data)
19627 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
19628 (x_own_selection, x_get_local_selection, x_convert_selection):
19629 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
19630 (some_frame_on_display): Delete unused function.
19631 (Fx_own_selection_internal, Fx_get_selection_internal)
19632 (Fx_disown_selection_internal, Fx_selection_owner_p)
19633 (Fx_selection_exists_p): New optional frame arg.
19634 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
19635 (x_handle_selection_clear): Don't treat other terminals with the
19636 same keyboard specially. Use the terminal-local Vselection_alist.
19637 (x_clear_frame_selections): Use Frun_hook_with_args.
19638
19639 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
19640
19641 * xterm.h: Add support for those atoms.
19642
e067f0c1
CY
196432011-05-26 Chong Yidong <cyd@stupidchicken.com>
19644
19645 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
19646 (converted_selections, conversion_fail_tag): New global variables.
19647 (x_selection_request_lisp_error): Free the above.
19648 (x_get_local_selection): Remove unnecessary code.
19649 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
19650 of converted selections stored in converted_selections.
19651 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
19652 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
19653 (x_convert_selection): New function.
19654 (x_handle_selection_event): Simplify.
19655 (x_get_foreign_selection): Don't ignore incoming requests while
19656 waiting for an answer; this will fail when we implement
19657 SAVE_TARGETS, and seems unnecessary anyway.
19658 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
19659 (Vx_sent_selection_functions): Doc fix.
19660
0f4aebc0
LL
196612011-05-26 Leo Liu <sdl.web@gmail.com>
19662
19663 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
19664
e61124cd
YM
196652011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
19666
19667 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
19668
19669 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
19670 for fringe update if it has periodic bitmap.
ac389d0c 19671 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
19672 and fringe_bitmap_periodic_p.
19673
19674 * fringe.c (get_fringe_bitmap_data): New function.
19675 (draw_fringe_bitmap_1, update_window_fringes): Use it.
19676 (update_window_fringes): Record periodicity of fringe bitmap in glyph
19677 row. Mark glyph row for fringe update if periodicity changed.
19678
19679 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
19680 for fringe update unless it has periodic bitmap.
19681
f16d9837
KH
196822011-05-25 Kenichi Handa <handa@m17n.org>
19683
19684 * xdisp.c (get_next_display_element): Set correct it->face_id for
19685 a static composition.
19686
e1b90ef6
LL
196872011-05-24 Leo Liu <sdl.web@gmail.com>
19688
19689 * deps.mk (fns.o):
19690 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
19691
19692 * fns.c (crypto_hash_function, Fsha1): New function.
19693 (Fmd5): Use crypto_hash_function.
19694 (syms_of_fns): Add Ssha1.
19695
7400048f
PE
196962011-05-22 Paul Eggert <eggert@cs.ucla.edu>
19697
19698 * gnutls.c: Remove unused macros.
19699 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
19700 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
19701 Remove macros that are defined and never used.
19702 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
19703
abb71cf4
CY
197042011-05-22 Chong Yidong <cyd@stupidchicken.com>
19705
19706 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
19707 (Fx_get_selection_internal): Minor cleanup.
19708 (Fx_own_selection_internal): Rename arguments for consistency with
19709 select.el.
19710
6307db39
PE
197112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
19712
19713 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
19714
f3d4e0a4
CY
197152011-05-22 Chong Yidong <cyd@stupidchicken.com>
19716
19717 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
19718
4d8ade89
YM
197192011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
19720
19721 * dispnew.c (scrolling_window): Don't exclude the case that the
19722 last enabled row in the desired matrix touches the bottom boundary.
19723
32078c8d
GM
197242011-05-21 Glenn Morris <rgm@gnu.org>
19725
19726 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
19727 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
19728 and add some more files.
32078c8d 19729
7285dc67
EZ
197302011-05-20 Eli Zaretskii <eliz@gnu.org>
19731
19732 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
19733 report_file_error introduced by the change from 2011-05-07.
19734
89d1bd22
PE
197352011-05-20 Paul Eggert <eggert@cs.ucla.edu>
19736
19737 * systime.h (Time): Define only if emacs is defined.
19738 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
19739 where the include path doesn't have X11/X.h by default. See
19740 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
19741
cd394be1 197422011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
19743
19744 * composite.c (find_automatic_composition): Fix previous change.
19745
b9704ad9
GM
197462011-05-20 Glenn Morris <rgm@gnu.org>
19747
19748 * lisp.mk: New file, split from Makefile.in.
19749 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
19750 (shortlisp): Remove.
19751 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
19752
4a720484
GM
197532011-05-19 Glenn Morris <rgm@gnu.org>
19754
19755 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
19756 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
19757 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
19758 (lisp): Set the order to that of loadup.el.
19759 (shortlisp): Make it a copy of $lisp.
19760 (SOME_MACHINE_LISP): Remove.
19761 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
19762 Use just $shortlisp, not $SOME_MACHINE_LISP too.
19763
a28d4396
KH
197642011-05-18 Kenichi Handa <handa@m17n.org>
19765
19766 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
19767 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
19768 (find_automatic_composition): Mostly rewrite for efficiency.
19769
a2b1fa8e
JB
197702011-05-18 Juanma Barranquero <lekktu@gmail.com>
19771
19772 * makefile.w32-in: Update dependencies.
19773
8e1f5610
CS
197742011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
19775
19776 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 19777 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 19778
7025ee00 197792011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 19780
cdfa6eab
PE
19781 Fix some integer overflow issues, such as string length overflow.
19782
06d6db33
PE
19783 * insdel.c (count_size_as_multibyte): Check for string overflow.
19784
2b4560a8
PE
19785 * character.c (lisp_string_width): Check for string overflow.
19786 Use EMACS_INT, not int, for string indexes and lengths; in
19787 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
19788 the resulting string length overflows an EMACS_INT; instead,
19789 report a string overflow if no precision given. When checking for
19790 precision exhaustion, use a check that cannot possibly have
19791 integer overflow. (Bug#8675)
19792 * character.h (lisp_string_width): Adjust to new signature.
19793
cb93f9be
PE
19794 * alloc.c (string_overflow): New function.
19795 (Fmake_string): Use it. This doesn't change behavior, but saves
19796 a few bytes and will simplify future changes.
19797 * character.c (string_escape_byte8): Likewise.
19798 * lisp.h (string_overflow): New decl.
19799
1a1f3366
PE
19800 Fixups, following up to the user-interface timestamp change.
19801 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
19802 for UI timestamps, instead of unsigned long.
9fbd6841
PE
19803 * msdos.c (mouse_get_pos): Likewise.
19804 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
19805 * w32gui.h (Time): Define by including "systime.h" rather than by
19806 declaring it ourselves. (Bug#8664)
19807
d4e3e4d3
PE
19808 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
19809 * image.c (clear_image_cache): Likewise.
19810
f6a24d19
PE
19811 * term.c (term_mouse_position): Don't assume time_t wraparound.
19812
08dc5ae6
PE
19813 Be more systematic about user-interface timestamps.
19814 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
19815 and sometimes 'EMACS_UINT', to represent these timestamps.
19816 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
19817 This makes the code easier to follow, and makes it easier to catch
19818 integer overflow bugs such as Bug#8664.
19819 * frame.c (Fmouse_position, Fmouse_pixel_position):
19820 Use Time, not unsigned long, for user-interface timestamps.
19821 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
19822 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
19823 * keyboard.h (last_event_timestamp): Likewise.
19824 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
19825 * menu.h (xmenu_show): Likewise.
19826 * term.c (term_mouse_position): Likewise.
19827 * termhooks.h (struct input_event.timestamp): Likewise.
19828 (struct terminal.mouse_position_hook): Likewise.
19829 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
19830 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
19831 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
19832 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
19833 what it was before.
19834 * menu.h, termhooks.h: Include "systime.h", for Time.
19835
8e55734a
PE
19836 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
19837 Don't assume that the difference between two unsigned long values
19838 can fit into an integer. At this point, we know button_down_time
19839 <= event->timestamp, so the difference must be nonnegative, so
19840 there's no need to cast the result if double-click-time is
19841 nonnegative, as it should be; check that it's nonnegative, just in
19842 case. This bug is triggered when events are more than 2**31 ms
86db42d2 19843 apart (about 25 days). (Bug#8664)
8e55734a 19844
841f1b75 19845 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 19846 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 19847
3e26f69c
PE
19848 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
19849 that always fit in int. Use a sentinel instead of a counter, to
19850 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
19851 * frame.h (struct frame): Use int for menu_bar_items_used
19852 instead of EMACS_INT, since it always fits in int.
3e26f69c 19853
5cc152c0
PE
19854 * menu.c (grow_menu_items): Check for int overflow.
19855
d89eb65e
PE
19856 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
19857
5235bd3e
PE
19858 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
19859 Before, the code was not consistent. These values cannot exceed
19860 2**31 - 1 so there's no need to make them unsigned.
19861 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
19862 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
19863 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
19864 as modifiers.
19865 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
19866
bc827e23
PE
19867 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
19868 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
19869 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
19870 presumably because the widths might not match.
19871
78eb494e
PE
19872 * window.c (size_window): Avoid needless test at loop start.
19873
04f2d78b
CB
198742011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
19875
19876 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
19877
d2fc7e3d 198782011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
19879
19880 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
19881
d2fc7e3d 198822011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
19883
19884 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
19885 `width' to `bar_area_x' and `bar_area_width', respectively.
19886 (x_scroll_run): Take account of fringe background extension.
19887
04f2d78b
CB
19888 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
19889 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
19890 `bar_area_width', respectively.
19891 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
19892 background extension.
19893
79b70037
GM
198942011-05-10 Jim Meyering <meyering@redhat.com>
19895
19896 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
19897
2f142cc5
JB
198982011-05-10 Juanma Barranquero <lekktu@gmail.com>
19899
19900 * image.c (Finit_image_library): Return t for built-in image types,
19901 like pbm and xbm. (Bug#8640)
19902
57679c86
AS
199032011-05-09 Andreas Schwab <schwab@linux-m68k.org>
19904
19905 * w32menu.c (set_frame_menubar): Fix submenu allocation.
19906
888c9e86
EZ
199072011-05-07 Eli Zaretskii <eliz@gnu.org>
19908
b0512a1d
EZ
19909 * w32console.c (Fset_screen_color): Doc fix.
19910 (Fget_screen_color): New function.
19911 (syms_of_ntterm): Defsubr it.
19912
7285dc67
EZ
19913 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
19914 unlink the temporary file if Fcall_process didn't create it in the
19915 first place.
19916 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
19917 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
19918 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
19919 cue to call_process_cleanup not to close that handle.
19920
4d3fcc8e
BK
199212011-05-07 Ben Key <bkey76@gmail.com>
19922
19923 * makefile.w32-in: The bootstrap-temacs rule now makes use of
19924 one of two shell specific rules, either bootstrap-temacs-CMD or
19925 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
19926 to the previous implementation of the bootstrap-temacs rule.
19927 The bootstrap-temacs-CMD rule is similar to the previous
19928 implementation of the bootstrap-temacs rule except that it
19929 makes use of the ESC_CFLAGS variable instead of the CFLAGS
19930 variable.
19931
19932 These changes, along with some changes to nt/configure.bat,
19933 nt/gmake.defs, and nt/nmake.defs, are required to extend my
19934 earlier fix to add support for --cflags and --ldflags options
19935 that include quotes so that it works whether make uses cmd or
19936 sh as the shell.
19937
b4289b64
MA
199382011-05-06 Michael Albinus <michael.albinus@gmx.de>
19939
19940 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
19941 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
19942 is a constant.
19943 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
19944 a string. Handle both cases.
19945 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
19946 (Fdbus_register_method): Use Qinvalid_function.
19947
af4c0e28
JB
199482011-05-06 Juanma Barranquero <lekktu@gmail.com>
19949
19950 * makefile.w32-in: Update dependencies.
19951 (LISP_H): Add inttypes.h and stdin.h.
19952 (PROCESS_H): Add unistd.h.
19953
c51453d9
EZ
199542011-05-06 Eli Zaretskii <eliz@gnu.org>
19955
19956 * lread.c: Include limits.h (fixes the MS-Windows build broken by
19957 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
19958
8ff0ac3c 199592011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 19960
4c4b566b
PE
19961 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
19962
aab2b9b5
PE
19963 * term.c (vfatal): Remove stray call to va_end.
19964 It's not needed and the C Standard doesn't allow it here anyway.
19965
c378da0b
PE
19966 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
19967 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
19968
288b08c7
PE
19969 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
19970 bytes.
19971
e3601888
PE
19972 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
19973
db6c0e74
PE
19974 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
19975
dd5963ea
PE
19976 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
19977
88c9450f
PE
19978 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
19979
2f9442b8
PE
19980 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
19981
c032b5f8
PE
19982 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
19983 * charset.c (Fdefine_charset_internal): Don't initialize
19984 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 19985 32-bit int (Bug#8600).
a108c10b
PE
19986
19987 * lread.c (read_integer): Be more consistent with string-to-number.
19988 Use string_to_number to do the actual conversion; this avoids
19989 rounding errors and fixes some other screwups. Without this fix,
19990 for example, #x1fffffffffffffff was misread as -2305843009213693952.
19991 (digit_to_number): Move earlier, for benefit of read_integer.
19992 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 19993 not a digit in any supported base. (Bug#8602)
a108c10b 19994
ad5f9eea
PE
19995 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
19996
aec1708a
PE
19997 * dispnew.c (scrolling_window): Return 1 if we scrolled,
19998 to match comment at start of function. This also removes a
19999 GCC warning about overflow in a 32+64-bit port.
20000
47be4ab5
PE
20001 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
20002
371cac43
PE
20003 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
20004 Reported by Stefan Monnier in
20005 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
20006 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
20007 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 20008
d01a7826
PE
20009 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
20010 (EMACS_UINTPTR): Likewise, with uintptr_t.
20011
7fd47d5c
PE
20012 * lisp.h: Prefer 64-bit EMACS_INT if available.
20013 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
20014 on 32-bit hosts that have 64-bit int, so that they can access
20015 large files.
122b0c86
PE
20016 However, temporarily disable this change unless the temporary
20017 symbol WIDE_EMACS_INT is defined.
7fd47d5c 20018
8727937b
PE
20019 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
20020
8ac068ac
PE
20021 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
20022 This removes an assumption that EMACS_INT and long are the same
20023 width as pointers. The assumption is true for Emacs porting targets
20024 now, but we want to make other targets possible.
20025 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
20026 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
20027 In the rest of the code, change types of integers that hold casted
20028 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
20029 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
20030 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
20031 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
20032 No need to cast type when ORing.
20033 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
20034 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
20035 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
20036 assume EMACS_INT is the same width as char *.
20037 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
20038 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
20039 Remove no-longer-needed casts.
20040 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
20041 (xg_tool_bar_help_callback, xg_make_tool_item):
20042 Use EMACS_INTPTR to hold an integer
20043 that will be cast to void *; this can avoid a GCC warning
20044 if EMACS_INT is not the same width as void *.
20045 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
20046 * xdisp.c (display_echo_area_1, resize_mini_window_1):
20047 (current_message_1, set_message_1):
20048 Use a local to convert to proper width without a cast.
20049 * xmenu.c (dialog_selection_callback): Likewise.
20050
ede49d71
PE
20051 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
20052 Also, don't assume VALBITS / RAND_BITS is less than 5,
20053 and don't rely on undefined behavior when shifting a 1 left into
20054 the sign bit.
20055 * lisp.h (get_random): Change signature to match.
20056
2f30ecd0
PE
20057 * lread.c (hash_string): Use size_t, not int, for hash computation.
20058 Normally we prefer signed values; but hashing is special, because
20059 it's better to use unsigned division on hash table sizes so that
20060 the remainder is nonnegative. Also, size_t is the natural width
20061 for hashing into memory. The previous code used 'int', which doesn't
20062 retain enough info to hash well into very large tables.
20063 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
20064
2a866e7b
PE
20065 * dbusbind.c: Don't possibly lose pointer info when converting.
20066 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
20067 Use XPNTR rather than XHASH, so that the high-order bits of
20068 the pointer aren't lost when converting through void *.
20069
51639eac
PE
20070 * eval.c (Fautoload): Don't double-shift a pointer.
20071
92394119
PE
20072 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
20073
dbdb9a7c
JB
200742011-05-06 Juanma Barranquero <lekktu@gmail.com>
20075
20076 * gnutls.c (DEF_GNUTLS_FN):
20077 * image.c (DEF_IMGLIB_FN): Make function pointers static.
20078
db7a0b4f
AS
200792011-05-05 Andreas Schwab <schwab@linux-m68k.org>
20080
20081 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
20082 marker. (Bug#8610)
20083
cd394be1 200842011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
20085
20086 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
20087 New version that can reserve upto 2GB of heap space.
20088
f7ff1b0f 200892011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
20090
20091 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
20092
639c109b
TZ
200932011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
20094
20095 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
20096 `gnutls_certificate_set_x509_key_file'.
20097
d2127135
JB
200982011-05-05 Juanma Barranquero <lekktu@gmail.com>
20099
20100 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
20101 Update dependencies.
20102
e968f4f3
JB
201032011-05-04 Juanma Barranquero <lekktu@gmail.com>
20104
20105 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
20106 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
20107 Remove unused parameter `fildes'.
20108 * process.c (read_process_output, send_process): Don't pass it.
20109
84d358f0
JB
201102011-05-04 Juanma Barranquero <lekktu@gmail.com>
20111
20112 Fix previous change: the library cache is defined in w32.c.
20113 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
20114 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
20115
0898ca10
JB
201162011-05-04 Juanma Barranquero <lekktu@gmail.com>
20117
20118 Implement dynamic loading of GnuTLS on Windows.
20119
20120 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
20121 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
20122 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
20123 Declare.
20124
20125 * gnutls.c (Qgnutls_dll): Define.
20126 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
20127 (gnutls_*): Declare function pointers.
20128 (init_gnutls_functions): New function to initialize function pointers.
20129 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
20130 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
20131 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
20132 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
20133 (emacs_gnutls_write, emacs_gnutls_read)
20134 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
20135 (Fgnutls_available_p): New function.
20136 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
20137 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
20138 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
20139
20140 * image.c: Include w32.h.
20141 (Vimage_type_cache): Delete.
20142 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
20143 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
20144 (w32_delayed_load): Move to w32.c.
20145
20146 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
20147
20148 * w32.c (QCloaded_from, Vlibrary_cache): Define.
20149 (w32_delayed_load): Move from image.c. When loading a library, record
20150 its filename in the :loaded-from property of the library id.
20151 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
20152 Initialize and staticpro them.
20153 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
20154
20155 * process.c: Include lisp.h before w32.h, not after.
20156 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
20157 instead of gnutls_record_check_pending.
20158
20159 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
20160
ff4de4aa
TZ
201612011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
20162
20163 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
20164 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
20165 as passed in.
20166
abe95abb
JD
201672011-05-03 Jan Djärv <jan.h.d@swipnet.se>
20168
20169 * xterm.c (x_set_frame_alpha): Do not set property on anything
20170 else than FRAME_X_OUTER_WINDOW (Bug#8608).
20171
e16e55d4
JB
201722011-05-02 Juanma Barranquero <lekktu@gmail.com>
20173
20174 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
20175
bafcf6a5
JB
201762011-05-02 Juanma Barranquero <lekktu@gmail.com>
20177
20178 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
20179 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
20180 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
20181 (gnutls_global_initialized, Qgnutls_bootprop_priority)
20182 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
20183 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
20184 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
20185 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
20186 (Qgnutls_bootprop_callbacks_verify): Make static.
20187
e7a6747f
AS
201882011-05-01 Andreas Schwab <schwab@linux-m68k.org>
20189
19ed11ba
AS
20190 * callproc.c: Indentation fixup.
20191
e7a6747f 20192 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
20193 (wait_for_termination, interruptible_wait_for_termination):
20194 Move after wait_for_termination_1.
e7a6747f 20195
1ef14cb4
LMI
201962011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
20197
20198 * sysdep.c (interruptible_wait_for_termination): New function
20199 which is like wait_for_termination, but allows keyboard
20200 interruptions.
20201
20202 * callproc.c (Fcall_process): Add (:file "file") as an option for
20203 the STDOUT buffer.
20204 (Fcall_process_region): Ditto.
20205
330d880c
EZ
202062011-04-30 Eli Zaretskii <eliz@gnu.org>
20207
8db90b73
EZ
20208 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
20209 rather than `XVECTOR (FOO)->size'.
20210
330d880c
EZ
20211 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
20212 inttypes.h, as a gnulib replacement is used if it not available in
20213 system headers.
20214
15cbd324
EZ
202152011-04-21 Eli Zaretskii <eliz@gnu.org>
20216
20217 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
20218 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
20219 of MOST_POSITIVE_FIXNUM. (Bug#8528)
20220
20221 * coding.c (coding_alloc_by_realloc): Error out if destination
20222 will grow beyond MOST_POSITIVE_FIXNUM.
20223 (decode_coding_emacs_mule): Abort if there isn't enough place in
20224 charbuf for the composition carryover bytes. Reserve an extra
20225 space for up to 2 characters produced in a loop.
20226 (decode_coding_iso_2022): Abort if there isn't enough place in
20227 charbuf for the composition carryover bytes.
20228
202292011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 20230
ae940cca
EZ
20231 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
20232 aborting when %lld or %lll format is passed.
20233 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
20234 %llo or %llx format is passed. (Bug#8545)
20235
03ab8921
EZ
20236 * window.c (window_scroll_line_based): Use a marker instead of
20237 simple variables to record original value of point. (Bug#7952)
20238
afda1437
EZ
20239 * doprnt.c (doprnt): Fix the case where a multibyte sequence
20240 produced by %s or %c overflows available buffer space. (Bug#8545)
20241
f76dee0c
PE
202422011-04-28 Paul Eggert <eggert@cs.ucla.edu>
20243
20244 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 20245 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 20246
fdc5744d
JB
202472011-04-28 Juanma Barranquero <lekktu@gmail.com>
20248
20249 * w32.c (init_environment): Warn about defaulting HOME to C:\.
20250
638f053a
JB
202512011-04-28 Juanma Barranquero <lekktu@gmail.com>
20252
20253 * keyboard.c (Qdelayed_warnings_hook): Define.
20254 (command_loop_1): Run `delayed-warnings-hook'
20255 if Vdelayed_warnings_list is non-nil.
20256 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
20257 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
20258
d178f871
EZ
202592011-04-28 Eli Zaretskii <eliz@gnu.org>
20260
20261 * doprnt.c (doprnt): Don't return value smaller than the buffer
20262 size if the message was truncated. (Bug#8545).
20263
b124fd93
JB
202642011-04-28 Juanma Barranquero <lekktu@gmail.com>
20265
20266 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
20267 (Fx_window_property): #if-0 the whole functions, not just the bodies.
20268
e810457d
PE
202692011-04-27 Paul Eggert <eggert@cs.ucla.edu>
20270
20271 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
20272
ea51cceb
JB
202732011-04-27 Juanma Barranquero <lekktu@gmail.com>
20274
20275 * makefile.w32-in: Update dependencies.
20276
94dcfacf
EZ
202772011-04-27 Eli Zaretskii <eliz@gnu.org>
20278
20279 Improve `doprnt' and its usage. (Bug#8545)
20280 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
20281 `format_end'. Remove support for %l as a conversion specifier.
20282 Don't use xrealloc. Improve diagnostics when the %l size modifier
20283 is used. Update the commentary.
20284
20285 * eval.c (verror): Simplify calculation of size_t.
20286
20287 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
20288 messages.
20289
f61f41d7
PE
202902011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
20291
20292 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
20293 change.
20294
96fb4434
PE
202952011-04-27 Paul Eggert <eggert@cs.ucla.edu>
20296
20297 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
20298 This makes this file independent of the recent pseudovector change.
20299
671875da 203002011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 20301
69e9b5a3
PE
20302 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
20303
b5f869a7 20304 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 20305 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 20306 Remove unused local.
c8926152 20307 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 20308
841a1577 20309 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
20310 GCC 4.6.0 optimizes based on type-based alias analysis.
20311 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
20312 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
20313 != &v->size, and therefore "v->size = 1; b->size = 2; return
20314 v->size;" must therefore return 1. This assumption is incorrect
20315 for Emacs, since it type-puns struct Lisp_Vector * with many other
20316 types. To fix this problem, this patch adds a new type struct
f904488f 20317 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
20318 and pseudovectors, and helps optimizing compilers not get fooled
20319 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
20320 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
20321 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
20322 the size member.
eab3844f
PE
20323 (XSETPVECTYPE): Rewrite in terms of new macro.
20324 (XSETPVECTYPESIZE): New macro, specifying both type and size.
20325 This is a bit clearer, and further avoids the possibility of
20326 undesirable aliasing.
20327 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 20328 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
20329 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
20330 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
20331 (ASIZE): Now uses header.size rather than size.
20332 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
20333 to avoid the hassle of writing XVECTOR (foo)->header.size.
20334 (struct vectorlike_header): New type.
eab3844f
PE
20335 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
20336 object, to help avoid aliasing.
20337 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
20338 (SUBRP): Likewise, since Lisp_Subr is a special case.
20339 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
20340 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
20341 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 20342 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
20343 changed to be "header.size" and "header.next".
20344 * buffer.h (struct buffer): Likewise.
20345 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
20346 * frame.h (struct frame): Likewise.
20347 * process.h (struct Lisp_Process): Likewise.
20348 * termhooks.h (struct terminal): Likewise.
20349 * window.c (struct save_window_data, struct saved_window): Likewise.
20350 * window.h (struct window): Likewise.
20351 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
20352 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
20353 * buffer.c (init_buffer_once): Likewise.
20354 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
20355 special case.
20356 * process.c (Fformat_network_address): Use local var for size,
20357 for brevity.
20358
0df1eac5
PE
20359 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
20360
847ab9d1 20361 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
20362 * data.c (atof): Remove decl; no longer used or needed.
20363 (digit_to_number): Move to lread.c.
20364 (Fstring_to_number): Use new string_to_number function, to be
20365 consistent with how the Lisp reader treats infinities and NaNs.
20366 Do not assume that floating-point numbers represent EMACS_INT
20367 without losing information; this is not true on most 64-bit hosts.
20368 Avoid double-rounding errors, by insisting on integers when
20369 parsing non-base-10 numbers, as the documentation specifies.
20370 * lisp.h (string_to_number): New decl, replacing ...
20371 (isfloat_string): Remove.
bc0a5c13 20372 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 20373 (read1): Do not accept +. and -. as integers; this
452f4150
PE
20374 appears to have been a coding error. Similarly, do not accept
20375 strings like +-1e0 as floating point numbers. Do not report
20376 overflow for integer overflows unless the base is not 10 which
20377 means we have no simple and reliable way to continue.
20378 Break out the floating-point parsing into a new
20379 function string_to_number, so that Fstring_to_number parses
20380 floating point numbers consistently with the Lisp reader.
04f2d78b 20381 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
20382 (E_CHAR, EXP_INT): Remove, replacing with ...
20383 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
20384 (string_to_number): New function, replacing isfloat_string.
20385 This function checks for valid syntax and produces the resulting
20386 Lisp float number too. Rework it so that string-to-number
bc0a5c13 20387 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
20388 so that overflow for non-base-10 numbers is reported only when
20389 there's no portable and simple way to convert to floating point.
452f4150 20390
67769ffc
PE
20391 * textprop.c (set_text_properties_1): Rewrite for clarity,
20392 and to avoid GCC warning about integer overflow.
20393
c20db43f
PE
20394 * intervals.h (struct interval): Use EMACS_INT for members
20395 where EMACS_UINT might cause problems. See
20396 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
20397 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
20398 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
20399 All uses changed.
37aa2f85
PE
20400 (offset_intervals): Tell GCC not to worry about length overflow
20401 when negating a negative length.
c20db43f 20402
2538aa2f
PE
20403 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
20404 (overrun_check_free): Likewise.
20405
f2d3008d
PE
20406 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
20407 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
20408 word size.
20409
ec8df744
PE
20410 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
20411 (gnutls_make_error): Rename local to avoid shadowing.
20412 (gnutls_emacs_global_deinit): ifdef out; not used.
20413 (Fgnutls_boot): Use const for pointer to readonly storage.
20414 Comment out unused local. Fix pointer signedness problems.
20415
640ee02d
PE
20416 * lread.c (openp): Don't stuff size_t into an 'int'.
20417 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
20418 about possible signed overflow.
20419
6048fb2a
PE
20420 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
20421 (GDK_KEY_g): Don't define if already defined.
20422 (xg_prepare_tooltip): Avoid pointer signedness problem.
20423 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
20424
fa3c87e1
PE
20425 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
20426 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
20427
2172544b
PE
20428 * xfns.c (Fx_window_property): Simplify a bit,
20429 to make a bit faster and to avoid GCC 4.6.0 warning.
20430 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
20431
9b821a21
PE
20432 * fns.c (internal_equal): Don't assume size_t fits in int.
20433
3c616cfa
PE
20434 * alloc.c (compact_small_strings): Tighten assertion a little.
20435
c2982e87
PE
20436 Replace pEd with more-general pI, and fix some printf arg casts.
20437 * lisp.h (pI): New macro, generalizing old pEd macro to other
20438 conversion specifiers. For example, use "...%"pI"d..." rather
20439 than "...%"pEd"...".
20440 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 20441 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
20442 * alloc.c (check_pure_size): Don't overflow by converting size to int.
20443 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
20444 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
20445 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
20446 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
20447 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
20448 64-bit hosts.
20449 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
20450 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
20451 * print.c (safe_debug_print, print_object): Likewise.
20452 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
20453 to int.
6f04d126
PE
20454 Use pI instead of if-then-else-abort. Use %p to avoid casts,
20455 avoiding the 0 flag, which is not portable.
c2982e87
PE
20456 * process.c (Fmake_network_process): Use pI to avoid cast.
20457 * region-cache.c (pp_cache): Likewise.
20458 * xdisp.c (decode_mode_spec): Likewise.
20459 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
20460 behavior on 64-bit hosts with printf arg.
6f04d126 20461 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
20462 (x_stop_queuing_selection_requests): Likewise.
20463 (x_get_window_property): Don't truncate byte count to an 'int'
20464 when tracing.
0b432f21 20465
5e073ec7
PE
20466 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
20467 here, since it parses constructs like leading '-' and spaces,
20468 which are not wanted; and it overflows with large numbers.
20469 Instead, simply match F[0-9]+, which is what is wanted anyway.
20470
36372bf9
PE
20471 * alloc.c: Remove unportable assumptions about struct layout.
20472 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
20473 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
20474 (allocate_vectorlike, make_pure_vector): Use the new macros,
20475 plus offsetof, to remove unportable assumptions about struct layout.
20476 These assumptions hold on all porting targets that I know of, but
20477 they are not guaranteed, they're easy to remove, and removing them
20478 makes further changes easier.
20479
0b432f21
PE
20480 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
20481 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
20482 (string_overrun_cookie): Now const. Use initializers that
20483 don't formally overflow signed char, to avoid warnings.
000098c1
PE
20484 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
20485 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
20486 (allocate_buffer): Don't assume sizeof (struct buffer) is a
20487 multiple of sizeof (EMACS_INT); it need not be, if
20488 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 20489 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 20490
895009e1
JB
204912011-04-26 Juanma Barranquero <lekktu@gmail.com>
20492
20493 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
20494
6a7a1b0b
TZ
204952011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
20496
20497 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 20498 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
20499 Reported by Paul Eggert <eggert@cs.ucla.edu>.
20500
841a1577 205012011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
20502
20503 * lisp.h (Qdebug): List symbol.
895009e1 20504 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
20505 * keyboard.c (debug-on-event): New variable.
20506 (handle_user_signal): Break into debugger when debug-on-event
20507 matches the current signal symbol.
20508
f2d3ba6f
DN
205092011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
20510
20511 * alloc.c (check_sblock, check_string_bytes)
20512 (check_string_free_list): Convert to standard C.
20513
42ce4c63
TZ
205142011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
20515
20516 * w32.c (emacs_gnutls_push): Fix typo.
20517
825cd63c
EZ
205182011-04-25 Eli Zaretskii <eliz@gnu.org>
20519
fb11d64d
EZ
20520 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
20521 "cast to pointer from integer of different size".
20522
825cd63c
EZ
20523 Improve doprnt and its use in verror. (Bug#8545)
20524 * doprnt.c (doprnt): Document the set of format control sequences
20525 supported by the function. Use SAFE_ALLOCA instead of always
20526 using `alloca'.
20527
20528 * eval.c (verror): Don't limit the buffer size at size_max-1, that
20529 is one byte too soon. Don't use xrealloc; instead xfree and
20530 xmalloc anew.
20531
e061a11b
TZ
205322011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
20533
20534 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
20535 callbacks stage.
20536
20537 * gnutls.c: Renamed global_initialized to
20538 gnutls_global_initialized. Added internals for the
20539 :verify-hostname-error, :verify-error, and :verify-flags
20540 parameters of `gnutls-boot' and documented those parameters in the
20541 docstring. Start callback support.
9173deec
JB
20542 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
20543 unless a fatal error occurred. Call gnutls_alert_send_appropriate
20544 on error. Return error code.
e061a11b
TZ
20545 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
20546 (emacs_gnutls_read): Likewise.
20547 (Fgnutls_boot): Return handshake error code.
20548 (emacs_gnutls_handle_error): New function.
20549 (wsaerror_to_errno): Likewise.
20550
20551 * w32.h (emacs_gnutls_pull): Add prototype.
20552 (emacs_gnutls_push): Likewise.
20553
20554 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
20555 (emacs_gnutls_push): Likewise.
20556
205572011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
20558
20559 * process.c (wait_reading_process_output): Check if GnuTLS
20560 buffered some data internally if no FDs are set for TLS
20561 connections.
20562
20563 * makefile.w32-in (OBJ2): Add gnutls.$(O).
20564 (LIBS): Link to USER_LIBS.
20565 ($(BLD)/gnutls.$(0)): New target.
20566
fa6996bc
EZ
205672011-04-24 Eli Zaretskii <eliz@gnu.org>
20568
eb35682e
EZ
20569 * xdisp.c (handle_single_display_spec): Rename the
20570 display_replaced_before_p argument into display_replaced_p, to
20571 make it consistent with the commentary. Fix typos in the
20572 commentary.
20573
e2ad650c
EZ
20574 * textprop.c (syms_of_textprop): Remove dead code.
20575 (copy_text_properties): Delete obsolete commentary about an
20576 interface that was deleted long ago. Fix typos in the description
20577 of arguments.
20578
1b2de274
EZ
20579 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
20580 to changes in oldXMenu/XMenu.h from 2011-04-16.
20581 <menu_help_message, prev_menu_help_message>: Constify.
20582 (IT_menu_make_room): menu->help_text is now `const char **';
20583 adjust.
20584
20585 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
20586 to changes in oldXMenu/XMenu.h from 2011-04-16.
20587 (struct XMenu): Declare `help_text' `const char **'.
20588
20589 * xfaces.c <Qunspecified>: Make extern again.
20590
20591 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 20592 required by POSIX.
1b2de274 20593
762b15be
EZ
20594 * doc.c (get_doc_string): Improve the format passed to `error'.
20595
20596 * doprnt.c (doprnt): Improve commentary.
20597
20598 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
20599
20600 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
20601 them with etags.
20602
f1052e5d
EZ
20603 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
20604 changes in globals.h immediately force recompilation.
762b15be
EZ
20605 (TAGS): Depend on $(CURDIR)/m/intel386.h and
20606 $(CURDIR)/s/ms-w32.h.
20607 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 20608
fa6996bc
EZ
20609 * character.c (Fchar_direction): Function deleted.
20610 (syms_of_character): Don't defsubr it.
20611 <char-direction-table>: Deleted.
20612
e6c3da20
EZ
206132011-04-23 Eli Zaretskii <eliz@gnu.org>
20614
20615 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
20616 * doprnt.c: Include limits.h.
20617 (SIZE_MAX): New macro.
04f2d78b
CB
20618 (doprnt): Return a size_t value. 2nd arg is now size_t.
20619 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
20620 Improve overflow protection. Support `l' modifier for integer
20621 conversions. Support %l conversion. Don't assume an EMACS_INT
20622 argument for integer conversions and for %c.
20623
20624 * lisp.h (doprnt): Restore prototype.
20625
20626 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
20627 $(SRC)/character.h.
20628
20629 * Makefile.in (base_obj): Add back doprnt.o.
20630
20631 * deps.mk (doprnt.o): Add back prerequisites.
20632 (callint.o): Depend on character.h.
20633
20634 * eval.c (internal_lisp_condition_case): Include the handler
20635 representation in the error message.
20636 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
20637 when breaking from the loop.
20638
20639 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
20640
20641 * callint.c (Fcall_interactively): When displaying error message
20642 about invalid control letter, pass the character's codepoint, not
20643 a pointer to its multibyte form. Improve display of the character
20644 in octal and display also its hex code.
20645
20646 * character.c (char_string): Use %x to display the (unsigned)
20647 codepoint of an invalid character, to avoid displaying a bogus
20648 negative value.
20649
20650 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
20651 `error', not SYMBOL_NAME itself.
20652
20653 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
20654 character arguments to `error'.
20655
20656 * charset.c (check_iso_charset_parameter): Fix incorrect argument
20657 to `error' in error message about FINAL_CHAR argument. Make sure
20658 FINAL_CHAR is a character, and use %c when it is passed as
20659 argument to `error'.
20660
4ffd0d6b 206612011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
20662
20663 * s/ms-w32.h (localtime): Redirect to sys_localtime.
20664
20665 * w32.c: Include <time.h>.
20666 (sys_localtime): New function.
20667
4ffd0d6b 206682011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
20669
20670 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
20671
4ffd0d6b 20672 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 20673
4ffd0d6b 206742011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 20675
4ffd0d6b
GM
20676 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
20677 zombies (Bug#8467).
aac0c6e3 20678
04c56954
EZ
206792011-04-19 Eli Zaretskii <eliz@gnu.org>
20680
20681 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
20682 gl_state.e_property when gl_state.object is Qt.
20683
20684 * insdel.c (make_gap_larger): Remove limitation of buffer size
20685 to <= INT_MAX.
20686
16a43933
CY
206872011-04-18 Chong Yidong <cyd@stupidchicken.com>
20688
20689 * xdisp.c (lookup_glyphless_char_display)
20690 (produce_glyphless_glyph): Handle cons cell entry in
20691 glyphless-char-display.
20692 (Vglyphless_char_display): Document it.
20693
20694 * term.c (produce_glyphless_glyph): Handle cons cell entry in
20695 glyphless-char-display.
20696
4581706e
CY
206972011-04-17 Chong Yidong <cyd@stupidchicken.com>
20698
20699 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
20700
20701 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
20702
20703 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
20704 definition for no-X builds.
20705
4887c6e2 207062011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 20707
fd35b6f9
PE
20708 Static checks with GCC 4.6.0 and non-default toolkits.
20709
5c1ccb01
PE
20710 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
20711
006c5daa
PE
20712 * process.c (keyboard_bit_set): Define only if SIGIO.
20713 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
20714 (send_process): Repair possible setjmp clobbering.
20715
efc736d3
PE
20716 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
20717
4e2fe2e6
PE
20718 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
20719
f97334a2
PE
20720 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
20721
4e75f29d
PE
20722 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
20723 Define only if needed.
20724
90efadd1
PE
20725 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
20726 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 20727 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 20728
3c647824
PE
20729 * dispextern.h (struct redisplay_interface): Rename param
20730 to avoid shadowing.
e264f262 20731 * termhooks.h (struct terminal): Likewise.
761383f4 20732 * xterm.c (xembed_send_message): Likewise.
3c647824 20733
b58c5c4a
PE
20734 * insdel.c (make_gap_smaller): Define only if
20735 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
20736
cad59032
PE
20737 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
20738 it.
20739
c339dc2e
PE
20740 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
20741 so that we aren't warned about unused symbols.
20742
91a3e27b
PE
20743 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
20744
399c71d3 20745 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 20746
8ffc96f5
PE
20747 * xfns.c (x_real_positions): Mark locals as initialized.
20748
eef9bc79
PE
20749 * xmenu.c (xmenu_show): Don't use uninitialized vars.
20750
098db9dd
PE
20751 * xterm.c: Fix problems found by static analysis with other toolkits.
20752 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
20753 (x_dispatch_event): Declare static if USE_GTK, and
20754 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 20755 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 20756 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
20757 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
20758 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 20759
eb18f6cc
PE
20760 * xmenu.c (menu_help_callback): Pointer type fixes.
20761 Use const pointers when pointing at readonly data. Avoid pointer
20762 signedness clashes.
20763 (FALSE): Remove unused macro.
20764 (update_frame_menubar): Remove unused decl.
20765
1fe72bf8
PE
20766 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
20767
60d9e1db
PE
20768 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
20769 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
20770 (single_menu_item): Rename local to avoid shadowing.
20771
39261c26
PE
20772 * keyboard.c (make_lispy_event): Remove unused local var.
20773
018c5e19
PE
20774 * frame.c, frame.h (x_get_resource_string): Bring this back, but
20775 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
20776
63d2b86e
PE
20777 * bitmaps: Change bitmaps from unsigned char back to the X11
20778 compatible char. Avoid the old compiler warnings about
20779 out-of-range initializers by using, for example, '\xab' rather
20780 than 0xab.
20781
aefd87e1
PE
20782 * xgselect.c (xgselect_initialize): Check vs interface
20783 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
20784
bf501fb9
PE
20785 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
20786
e9829fdf
PE
20787 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
20788 to read-only memory.
20789
1086c095
PE
20790 * fns.c (vector): Remove; this old hack is no longer needed.
20791
2baccd04 20792 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 20793 Remove unused var.
dde42981 20794 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 20795
72391843 20796 * xrdb.c (x_load_resources): Omit unused local.
3565b346 20797
436c16df 20798 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 20799 (x_window): Rename locals to avoid shadowing.
dc5ddd85 20800 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 20801
92bb796d 20802 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 20803 (x_term_init): Remove local to avoid shadowing.
92bb796d 20804
764430a3 20805 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
20806
20807 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
20808 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
20809
d1dfb56c
EZ
208102011-04-16 Eli Zaretskii <eliz@gnu.org>
20811
c4354cb4
EZ
20812 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
20813
d1dfb56c
EZ
20814 Fix regex.c, syntax.c and friends for buffers > 2GB.
20815 * syntax.h (struct gl_state_s): Declare character position members
20816 EMACS_INT.
20817
20818 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
20819
04f2d78b
CB
20820 * textprop.c (verify_interval_modification, interval_of):
20821 Declare arguments EMACS_INT.
d1dfb56c
EZ
20822
20823 * intervals.c (adjust_intervals_for_insertion): Declare arguments
20824 EMACS_INT.
20825
20826 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
20827
20828 * indent.c (Fvertical_motion): Local variable it_start is now
20829 EMACS_INT.
20830
20831 * regex.c (re_match, re_match_2, re_match_2_internal)
20832 (bcmp_translate, regcomp, regexec, print_double_string)
20833 (group_in_compile_stack, re_search, re_search_2, regex_compile)
20834 (re_compile_pattern, re_exec): Declare arguments and local
20835 variables `size_t' and `ssize_t' and return values `regoff_t', as
20836 appropriate.
20837 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
20838 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
20839 <compile_stack_type>: `size' and `avail' are now `size_t'.
20840
20841 * regex.h <regoff_t>: Use ssize_t, not int.
20842 (re_search, re_search_2, re_match, re_match_2): Arguments that
20843 specify buffer/string position and length are now ssize_t and
20844 size_t. Return type is regoff_t.
20845
613052cd
BK
208462011-04-16 Ben Key <bkey76@gmail.com>
20847
20848 * nsfont.m: Fixed bugs in ns_get_family and
20849 ns_descriptor_to_entity that were caused by using free to
20850 deallocate memory blocks that were allocated by xmalloc (via
20851 xstrdup). This caused Emacs to crash when compiled with
20852 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
20853 --enable-checking=xmallocoverrun). xfree is now used to
20854 deallocate these memory blocks.
20855
4170f62f 208562011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 20857
71b41406
PE
20858 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
20859
9587a89d
PE
20860 emacs_write: Accept and return EMACS_INT for sizes.
20861 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
20862 et seq.
20863 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
20864 Accept and return EMACS_INT.
20865 (emacs_gnutls_write): Return the number of bytes written on
20866 partial writes.
20867 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
20868 (emacs_read, emacs_write): Remove check for negative size, as the
20869 Emacs source code has been audited now.
9587a89d
PE
20870 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
20871 (emacs_read, emacs_write): Use it.
273a5f82
PE
20872 * process.c (send_process): Adjust to the new signatures of
20873 emacs_write and emacs_gnutls_write. Do not attempt to store
20874 a byte offset into an 'int'; it might overflow.
9587a89d 20875 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 20876
3e047f51
PE
20877 * sound.c: Don't assume sizes fit in 'int'.
20878 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 20879 Return EMACS_INT, not int.
3e047f51 20880 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
20881 Accept EMACS_INT, not int.
20882 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
20883 record read return values.
20884
cc39a9db
BK
208852011-04-15 Ben Key <bkey76@gmail.com>
20886
c9d0ec6d
JB
20887 * keyboard.c (Qundefined): Don't declare static since it is used
20888 in nsfns.m.
20889 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
20890 static since they are used in nsfont.m.
cc39a9db 20891
6c60eb9f
SM
208922011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
20893
20894 * process.c (Qprocessp): Don't declare static.
20895 * lisp.h (Qprocessp): Declare again.
20896
7990b61a
JB
208972011-04-15 Juanma Barranquero <lekktu@gmail.com>
20898
20899 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
20900
5d4cb038
PE
209012011-04-14 Paul Eggert <eggert@cs.ucla.edu>
20902
8bd7b830 20903 Improve C-level modularity by making more things 'static'.
cd64ea1d 20904
e3b27b31
PE
20905 Don't publish debugger-only interfaces to other modules.
20906 * lisp.h (safe_debug_print, debug_output_compilation_hack):
20907 (verify_bytepos, count_markers): Move decls to the only modules
20908 that need them.
20909 * region-cache.h (pp_cache): Likewise.
20910 * window.h (check_all_windows): Likewise.
20911 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
20912
5d4cb038
PE
20913 * sysdep.c (croak): Now static, if
20914 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
20915 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
20916
20917 * alloc.c (refill_memory_reserve): Now static if
20918 !defined REL_ALLOC || defined SYSTEM_MALLOC.
20919 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 20920
e87b6180
PE
20921 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
20922 Define only if USE_LUCID.
20923
ac64929e
PE
20924 * xrdb.c (x_customization_string, x_rm_string): Now static.
20925
6f37259d
PE
20926 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
20927 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
20928
1683e3ab
PE
20929 * xdisp.c (draw_row_with_mouse_face): Now static.
20930 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
20931
de9c2632
PE
20932 * window.h (check_all_windows): Mark externally visible.
20933
2b96acb7
PE
20934 * window.c (window_deletion_count): Now static.
20935
20936 * undo.c: Make symbols static if they're not exported.
20937 (last_undo_buffer, last_boundary_position, pending_boundary):
20938 Now static.
20939
50436f33
PE
20940 * textprop.c (interval_insert_behind_hooks): Now static.
20941 (interval_insert_in_front_hooks): Likewise.
20942
64520e5c
PE
20943 * term.c: Make symbols static if they're not exported.
20944 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
20945 (max_frame_lines, tty_set_terminal_modes):
20946 (tty_reset_terminal_modes, tty_turn_off_highlight):
20947 (get_tty_terminal): Now static.
20948 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
20949 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 20950 HAVE_WINDOW_SYSTEM.
64520e5c
PE
20951 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
20952 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
20953
1fa53021
PE
20954 * sysdep.c: Make symbols static if they're not exported.
20955 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
20956 Now static.
20957 (sigprocmask_set, full_mask): Remove; unused.
20958 (wait_debugging): Mark as visible.
20959 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
20960 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
20961
d4b43b22
PE
20962 * syntax.c (syntax_temp): Define only if !__GNUC__.
20963
b7c513d0
PE
20964 * sound.c (current_sound_device, current_sound): Now static.
20965
989b29ad
PE
20966 * search.c (searchbufs, searchbuf_head): Now static.
20967
13a55a78
PE
20968 * scroll.c (scroll_cost): Remove; unused.
20969 * dispextern.h (scroll_cost): Remove decl.
20970
de68a1fc
PE
20971 * region-cache.h (pp_cache): Mark as externally visible.
20972
40ccffa6
PE
20973 * process.c: Make symbols static if they're not exported.
20974 (process_tick, update_tick, create_process, chan_process):
20975 (Vprocess_alist, proc_buffered_char, datagram_access):
20976 (fd_callback_data, send_process_frame, process_sent_to): Now static.
20977 (deactivate_process): Mark defn as static, as well as decl.
20978 * lisp.h (create_process): Remove decl.
20979 * process.h (chan_process, Vprocess_alist): Remove decls.
20980
ad64fc97
PE
20981 * print.c: Make symbols static if they're not exported.
20982 (print_depth, new_backquote_output, being_printed, print_buffer):
20983 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
20984 (print_interval, print_number_index, initial_stderr_stream):
20985 Now static.
20986 * lisp.h (Fprinc): Remove decl.
20987 (debug_output_compilation_hack): Mark as externally visible.
20988
adddb265
PE
20989 * sysdep.c (croak): Move decl from here to syssignal.h.
20990 * syssignal.h (croak): Put it here, so the API can be checked when
20991 'croak' is called from dissociate_if_controlling_tty.
20992
1717ede2
PE
20993 * minibuf.c: Make symbols static if they're not exported.
20994 (minibuf_save_list, choose_minibuf_frame): Now static.
20995 * lisp.h (choose_minibuf_frame): Remove decl.
20996
fa5fb2bc
PE
20997 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
20998
1e3890d1
PE
20999 * lread.c: Make symbols static if they're not exported.
21000 (read_objects, initial_obarray, oblookup_last_bucket_number):
21001 Now static.
21002 (make_symbol): Remove; unused.
21003 * lisp.h (initial_obarray, make_symbol): Remove decls.
21004
8a1414fa
PE
21005 * keyboard.c: Make symbols static if they're not exported.
21006 (single_kboard, recent_keys_index, total_keys, recent_keys):
21007 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
21008 (this_single_command_key_start, echoing, last_auto_save):
21009 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
21010 (command_loop, echo_now, keyboard_init_hook, help_char_p):
21011 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
21012 (Vlispy_mouse_stem, double_click_count):
21013 Now static.
21014 (force_auto_save_soon): Define only if SIGDANGER.
21015 (ignore_mouse_drag_p): Now static if
21016 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
21017 (print_help): Remove; unused.
21018 (stop_character, last_timer_event): Mark as externally visible.
21019 * keyboard.h (ignore_mouse_drag_p): Declare only if
21020 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
21021 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
21022 * lisp.h (echoing): Remove decl.
21023 (force_auto_save_soon): Declare only if SIGDANGER.
21024 * xdisp.c (redisplay_window): Simplify code, to make it more
21025 obvious that ignore_mouse_drag_p is not accessed if !defined
21026 USE_GTK && !defined HAVE_NS.
21027
93ea6e8f
PE
21028 * intervals.c: Make symbols static if they're not exported.
21029 (merge_properties_sticky, merge_interval_right, delete_interval):
21030 Now static.
21031 * intervals.h (merge_interval_right, delete_interval): Remove decls.
21032
77382fcc
PE
21033 * insdel.c: Make symbols static if they're not exported.
21034 However, leave prepare_to_modify_buffer alone. It's never
21035 called from outside this function, but that appears to be a bug.
21036 (combine_after_change_list, combine_after_change_buffer):
4889fc82 21037 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
21038 (adjust_after_replace_noundo): Remove; unused.
21039 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 21040 (signal_before_change): Remove decls.
77382fcc 21041
9306c32e
PE
21042 * indent.c (val_compute_motion, val_vmotion): Now static.
21043
cd44d2eb
PE
21044 * image.c: Make symbols static if they're not exported.
21045 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
21046 if USE_GTK.
21047 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
21048 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
21049
ad9a7a06
PE
21050 * fringe.c (standard_bitmaps): Now static.
21051 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
21052
81626931
PE
21053 * frame.c: Make symbols static if they're not exported.
21054 (x_report_frame_params, make_terminal_frame): Now static.
21055 (get_frame_param): Now static, unless HAVE_NS.
21056 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
21057 (x_get_resource_string): Remove; not used.
21058 * frame.h (make_terminal_frame, x_report_frame_params):
21059 (x_get_resource_string); Remove decls.
21060 (x_fullscreen_adjust): Declare only if WINDOWSNT.
21061 * lisp.h (get_frame_param): Declare only if HAVE_NS.
21062
239f9db9
PE
21063 * font.c, fontset.c: Make symbols static if they're not exported.
21064 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
21065 (FACE_SUITABLE_FOR_CHAR_P): Use it.
21066 * font.c (font_close_object): Now static.
21067 * font.h (font_close_object): Remove.
21068 * fontset.c (FONTSET_OBJLIST): Remove.
21069 (free_realized_fontset) #if-0 the body, which does nothing.
21070 (face_suitable_for_char_p): #if-0, as it's never called.
21071 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
21072 * xfaces.c (face_at_string_position):
21073 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
21074 since 0 is always ASCII.
21075
dfcf3579
PE
21076 * fns.c (weak_hash_tables): Now static.
21077
5045092b
PE
21078 * fileio.c: Make symbols static if they're not exported.
21079 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
21080 (Vwrite_region_annotation_buffers): Now static.
21081
57a96f5c
PE
21082 * eval.c: Make symbols static if they're not exported.
21083 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
21084 * lisp.h (backtrace_list): Remove decl.
21085
35f08c38
PE
21086 * emacs.c: Make symbols static if they're not exported.
21087 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
21088 (fatal_error_code, fatal_error_signal_hook, standard_args):
21089 Now static.
21090 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
21091 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
21092 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
21093 * lisp.h (fatal_error_signal_hook): Remove decl.
21094 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
21095
f44bd759
PE
21096 * editfns.c: Move a (normally-unused) function to its only use.
21097 * editfns.c, lisp.h (get_operating_system_release): Remove.
21098 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
21099 worth the hassle of breaking this out.
21100
b532497d
PE
21101 * xterm.c: Make symbols static if they're not exported.
21102 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
21103 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
21104 (x_destroy_window, x_delete_display):
21105 Now static.
21106 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
21107 (x_mouse_leave): Remove; unused.
21108 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
21109 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
21110 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
21111 Remove decls.
21112 (x_mouse_leave): Declare only if WINDOWSNT.
21113 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
21114 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
21115 USE_X_TOOLKIT.
21116
1675728f
PE
21117 * ftxfont.c: Make symbols static if they're not exported.
21118 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
21119 HAVE_FREETYPE.
21120 * font.h (ftxfont_driver): Likewise.
21121
e4cebfca
PE
21122 * xfns.c: Make symbols static if they're not exported.
21123 (x_last_font_name, x_display_info_for_name):
21124 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
21125 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
21126 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
21127 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
21128 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
21129 (last_show_tip_args): Now static.
21130 (xic_defaut_fontset, xic_create_fontsetname): Define only if
21131 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
21132 (x_screen_planes): Remove; unused.
21133 * dispextern.h (x_screen_planes): Remove decl.
21134
5bf46f05
PE
21135 * dispnew.c: Make symbols static if they're not exported.
21136 * dispextern.h (redraw_garbaged_frames, scrolling):
21137 (increment_row_positions): Remove.
21138 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
21139 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
21140 Now static.
21141 (redraw_garbaged_frames): Remove; unused.
21142
435f4c28
PE
21143 * xfaces.c: Make symbols static if they're not exported.
21144 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
21145 Remove decls.
21146 * xterm.h (defined_color): Remove decls.
21147 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
21148 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
21149 (menu_face_changed_default, defined_color, free_realized_face):
21150 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
21151 (ascii_face_of_lisp_face): Remove; unused.
21152
8524aef3
PE
21153 * xdisp.c: Make symbols static if they're not exported.
21154 * dispextern.h (scratch_glyph_row, window_box_edges):
21155 (glyph_to_pixel_coords, set_cursor_from_row):
21156 (get_next_display_element, set_iterator_to_next):
21157 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
21158 (show_mouse_face): Remove decls
21159 * frame.h (message_buf_print): Likewise.
21160 * lisp.h (pop_message, set_message, check_point_in_composition):
21161 Likewise.
21162 * xterm.h (set_vertical_scroll_bar): Likewise.
21163 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
21164 (message_buf_print, scratch_glyph_row, displayed_buffer):
21165 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
21166 (get_next_display_element, show_mouse_face, window_box_edges):
21167 (frame_to_window_pixel_xy, check_point_in_composition):
21168 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
21169 (glyph_to_pixel_coords): Remove; unused.
21170
16390cd2
PE
21171 * dired.c (file_name_completion): Now static.
21172
21173 * dbusbind.c (xd_in_read_queued_messages): Now static.
21174
a25f4dfa
PE
21175 * lisp.h (circular_list_error, FOREACH): Remove; unused.
21176 * data.c (circular_list_error): Remove.
21177
14a9c8df
PE
21178 * commands.h (last_point_position, last_point_position_buffer):
21179 (last_point_position_window): Remove decls.
21180 * keyboard.c: Make these variables static.
21181
04f2d78b
CB
21182 * coding.h (coding, code_convert_region, encode_coding_gap):
21183 Remove decls.
74ab6df5
PE
21184 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
21185 (iso_code_class, detect_coding, code_convert_region): Now static.
21186 (encode_coding_gap): Remove; unused.
21187
38dfbee1
PE
21188 * chartab.c (chartab_chars, chartab_bits): Now static.
21189
a2cb4e63
PE
21190 * charset.h (charset_iso_8859_1): Remove decl.
21191 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
21192 Now static.
21193
127198fd
PE
21194 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
21195 * ccl.c (Vccl_program_table): Now static.
21196 (check_ccl_update): Remove; unused.
21197
d85b608f
PE
21198 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
21199 * category.h: ... from here.
21200 * category.c (check_category_table, set_category_set): Now static.
21201
31cd66f3
PE
21202 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
21203 * lisp.h: Remove these decls.
21204
c358e587
PE
21205 * buffer.c (buffer_count): Remove unused var.
21206
e78aecca
PE
21207 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
21208 so that it's not optimized away.
21209 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
21210 * dispextern.h (bidi_dump_cached_states): Remove, since it's
21211 exported only to the debugger.
21212
e192d7d3 21213 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 21214 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 21215
92470028
PE
21216 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
21217 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
21218 was inaccessible from Lisp.
21219 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
21220 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
21221
244ed907
PE
21222 alloc.c: Import and export fewer symbols, and remove unused items.
21223 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
21224 is defined.
21225 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
21226 it's not optimized away by whole-program optimization.
21227 (message_enable_multibyte, free_misc): Remove.
21228 (catchlist, handlerlist, mark_backtrace):
21229 Declare only if BYTE_MARK_STACK.
21230 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
21231 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
21232 (message_enable_multibyte): Remove decl.
21233 (free_misc, interval_free_list, float_block, float_block_index):
21234 (n_float_blocks, float_free_list, cons_block, cons_block_index):
21235 (cons_free_list, last_marked_index):
21236 Now static.
21237 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
21238 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
21239 (mark_backtrace): Define only if BYTE_MARK_STACK.
21240 * xdisp.c (message_enable_multibyte): Now static.
21241
61c2b50e 21242 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
21243 This makes it easier for human readers (and static analyzers)
21244 to see whether these variables are used from other modules.
21245 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
21246 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
21247 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
21248 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
21249 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
21250 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
21251 * xmenu.c, xselect.c:
21252 Declare Q* vars static if they are not used in other modules.
21253 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
21254 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
21255 Remove decls of unexported vars.
21256 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
21257
95c82688
PE
21258 * lisp.h (DEFINE_FUNC): Make sname 'static'.
21259
16a97296
PE
21260 Make Emacs functions such as Fatom 'static' by default.
21261 This makes it easier for human readers (and static analyzers)
21262 to see whether these functions can be called from other modules.
21263 DEFUN now defines a static function. To make the function external
21264 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
21265 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
21266 (Finit_image_library):
16a97296
PE
21267 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
21268 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
21269 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
21270 Remove decls, since these functions are now static.
21271 (Funintern, Fget_internal_run_time): New decls, since these functions
21272 were already external.
95c82688 21273
16a97296
PE
21274 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
21275 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
21276 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
21277 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
21278 * keyboard.c, keymap.c, lread.c:
21279 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
21280 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
21281 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
21282 Mark functions with DEFUE instead of DEFUN,
21283 if they are used in other modules.
21284 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
21285 decls for now-static functions.
21286 * buffer.h (Fdelete_overlay): Remove decl.
21287 * callproc.c (Fgetenv_internal): Mark as internal.
21288 * composite.c (Fremove_list_of_text_properties): Remove decl.
21289 (Fcomposition_get_gstring): New forward static decl.
21290 * composite.h (Fcomposite_get_gstring): Remove decl.
21291 * dired.c (Ffile_attributes): New forward static decl.
21292 * doc.c (Fdocumntation_property): New forward static decl.
21293 * eval.c (Ffetch_bytecode): New forward static decl.
21294 (Funintern): Remove extern decl; now in .h file where it belongs.
21295 * fileio.c (Fmake_symbolic_link): New forward static decl.
21296 * image.c (Finit_image_library): New forward static decl.
21297 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
21298 * intervals.h (Fprevious_property_change):
21299 (Fremove_list_of_text_properties): Remove decls.
21300 * keyboard.c (Fthis_command_keys): Remove decl.
21301 (Fcommand_execute): New forward static decl.
21302 * keymap.c (Flookup_key): New forward static decl.
21303 (Fcopy_keymap): Now static.
21304 * keymap.h (Flookup_key): Remove decl.
21305 * process.c (Fget_process): New forward static decl.
21306 (Fprocess_datagram_address): Mark as internal.
21307 * syntax.c (Fsyntax_table_p): New forward static decl.
21308 (skip_chars): Remove duplicate decl.
21309 * textprop.c (Fprevious_property_change): New forward static decl.
21310 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
21311 Now internal.
21312 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
21313 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
21314
785bbd42
PE
21315 * editfns.c (Fformat): Remove unreachable code.
21316
8b913b57
AS
213172011-04-14 Andreas Schwab <schwab@linux-m68k.org>
21318
21319 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
21320 change. (Bug#8496)
21321
a6744a35
EZ
213222011-04-13 Eli Zaretskii <eliz@gnu.org>
21323
21324 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
21325 when at ZV. (Bug#8487)
21326
e7974947
AS
213272011-04-12 Andreas Schwab <schwab@linux-m68k.org>
21328
baad03f0
AS
21329 * charset.c (Fclear_charset_maps): Use xfree instead of free.
21330 (Bug#8437)
21331 * keyboard.c (parse_tool_bar_item): Likewise.
21332 * sound.c (sound_cleanup, alsa_close): Likewise.
21333 * termcap.c (tgetent): Likewise.
21334 * xfns.c (x_default_font_parameter): Likewise.
21335 * xsettings.c (read_and_apply_settings): Likewise.
21336
e7974947
AS
21337 * alloc.c (overrun_check_malloc, overrun_check_realloc)
21338 (overrun_check_free): Protoize.
21339
28272684
PE
213402011-04-12 Paul Eggert <eggert@cs.ucla.edu>
21341
21342 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
21343 since callers should never pass a negative size.
21344 Change the signature to match that of plain 'read' and 'write'; see
21345 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
21346 * lisp.h: Update prototypes of emacs_write and emacs_read.
21347
11997c76
EZ
213482011-04-11 Eli Zaretskii <eliz@gnu.org>
21349
21350 * xdisp.c (redisplay_window): Don't try to determine the character
21351 position of the scroll margin if the window start point w->startp
e896f03c 21352 is outside the buffer's accessible region. (Bug#8468)
11997c76 21353
8a2cbd72
EZ
213542011-04-10 Eli Zaretskii <eliz@gnu.org>
21355
21356 Fix write-region and its subroutines for buffers > 2GB.
21357 * fileio.c (a_write, e_write): Modify declaration of arguments and
21358 local variables to support buffers larger than 2GB.
21359 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
21360
21361 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
21362 argument, local variables, and return value.
21363
21364 * lisp.h: Update prototypes of emacs_write and emacs_read.
21365
21366 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
21367
4073e537 213682011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 21369
1ebfdcb6
PE
21370 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
21371
b2ded58d
PE
21372 Fix more problems found by GCC 4.6.0's static checks.
21373
7d66342c
PE
21374 * xdisp.c (vmessage): Use a better test for character truncation.
21375
bbf47d44
PE
21376 * charset.c (load_charset_map): <, not <=, for optimization,
21377 and to avoid potential problems with integer overflow.
9248994d 21378 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 21379 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 21380 * editfns.c (Fformat): Likewise.
1e69125e 21381 * syntax.c (skip_chars): Likewise.
3befa583 21382
e3019616
PE
21383 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
21384 This also lets GCC 4.6.0 generate slightly better loop code.
21385
becfa255
PE
21386 * callint.c (Fcall_interactively): <, not <=, for optimization.
21387 (Fcall_interactively): Count the number of arguments produced,
21388 not the number of arguments given. This is simpler and lets GCC
21389 4.6.0 generate slightly better code.
21390
dae0cd48
PE
21391 * ftfont.c: Distingish more carefully between FcChar8 and char.
21392 The previous code passed unsigned char * to a functions like
21393 strlen and xstrcasecmp that expect char *, which does not
21394 conform to the C standard.
21395 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
21396 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
21397 char * when the C standard requires it.
21398
76032d70
PE
21399 * keyboard.c (read_char): Remove unused var.
21400
eb3f1cc8
PE
21401 * eval.c: Port to Windows vsnprintf (Bug#8435).
21402 Include <limits.h>.
21403 (SIZE_MAX): Define if the headers do not.
21404 (verror): Do not give up if vsnprintf returns a negative count.
21405 Instead, grow the buffer. This ports to Windows vsnprintf, which
21406 does not conform to C99. Problem reported by Eli Zaretskii.
21407 Also, simplify the allocation scheme, by avoiding the need for
21408 calling realloc, and removing the ALLOCATED variable.
21409
70476b54
PE
21410 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
21411
12020a9e
PE
21412 Remove invocations of doprnt, as Emacs now uses vsnprintf.
21413 But keep the doprint source code for now, as we might revamp it
21414 and use it again (Bug#8435).
ea6c7ae6
PE
21415 * lisp.h (doprnt): Remove.
21416 * Makefile.in (base_obj): Remove doprnt.o.
21417 * deps.mk (doprnt.o): Remove.
21418
5fdb398c
PE
21419 error: Print 32- and 64-bit integers portably (Bug#8435).
21420 Without this change, on typical 64-bit hosts error ("...%d...", N)
21421 was used to print both 32- and 64-bit integers N, which relied on
21422 undefined behavior.
61bdb816 21423 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
21424 * lisp.h (error, verror): Mark as printf-like functions.
21425 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
21426 Report overflow in size calculations when allocating printf buffer.
21427 Do not truncate output string at its first null byte.
21428 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
21429 Truncate the output at a character boundary, since vsnprintf does not
21430 do that.
21431 * charset.c (check_iso_charset_parameter): Convert internal
21432 character to string before calling 'error', since %c now has the
21433 printf meaning.
21434 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
21435 overflow when computing char to be passed to 'error'. Do not
21436 pass Lisp_Object to 'error'; pass the integer instead.
21437 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
21438 formatted with plain %d.
21439
b189fa66
PE
21440 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
21441
bff87ef0
PE
21442 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
21443
7e2cac20
PE
21444 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
21445
ce4d90b5
PE
21446 * xterm.c (x_catch_errors): Remove duplicate declaration.
21447
266c9547
PE
21448 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
21449
79c49ad2
PE
21450 * xdisp.c, lisp.h (message_nolog): Remove; unused.
21451
368f4090
JM
214522011-04-10 Jim Meyering <meyering@redhat.com>
21453
21454 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
21455 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
21456 return ssize_t not "int", and use size_t as the buffer length.
21457 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
21458 * gnutls.h: Update declarations.
21459 * process.c (read_process_output): Use ssize_t, to match.
21460 (send_process): Likewise.
21461
a32d4040
CY
214622011-04-09 Chong Yidong <cyd@stupidchicken.com>
21463
21464 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
21465
8546720e 214662011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 21467
04f2d78b
CB
21468 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
21469 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 21470
8546720e
GM
21471 * xterm.c (handle_one_xevent):
21472 * xmenu.c (create_and_show_popup_menu):
21473 * xselect.c (x_decline_selection_request)
21474 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 21475
0a2f5c1a 214762011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
21477
21478 Fix some uses of `int' instead of EMACS_INT.
21479 * search.c (string_match_1, fast_string_match)
21480 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
21481 (scan_buffer, find_next_newline_no_quit)
21482 (find_before_next_newline, search_command, Freplace_match)
21483 (Fmatch_data): Make some `int' variables be EMACS_INT.
21484
21485 * xdisp.c (display_count_lines): 3rd argument and return value now
21486 EMACS_INT. All callers changed.
21487 (pint2hrstr): Last argument is now EMACS_INT.
21488
21489 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
21490 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
21491 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
21492 (decode_coding_utf_16, decode_coding_emacs_mule)
21493 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
21494 (decode_coding_ccl, decode_coding_charset)
21495 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
21496 (decode_coding_iso_2022, decode_coding_emacs_mule)
21497 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
21498 <char_offset, last_offset>: Declare EMACS_INT.
21499 (encode_coding_utf_8, encode_coding_utf_16)
21500 (encode_coding_emacs_mule, encode_invocation_designation)
21501 (encode_designation_at_bol, encode_coding_iso_2022)
21502 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
21503 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
21504 Declare EMACS_INT.
21505 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
21506 (encode_invocation_designation): Last argument P_NCHARS is now
21507 EMACS_INT.
21508 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
21509 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
21510
21511 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
21512 All users changed.
21513
21514 * ccl.c (Fccl_execute_on_string): Declare some variables
21515 EMACS_INT.
21516
8546720e 215172011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
21518
21519 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
21520
4e19a977
CS
215212011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
21522
21523 * process.c (Fformat_network_address): Doc fix.
21524
87302331
R
215252011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
21526
ee7683eb 21527 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 21528
cbb59342
CY
215292011-04-08 Chong Yidong <cyd@stupidchicken.com>
21530
21531 * keyboard.c (read_char): Call Lisp function help-form-show,
21532 instead of using internal_with_output_to_temp_buffer.
21533 (Qhelp_form_show): New var.
e0d38eeb 21534 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
21535
21536 * print.c (internal_with_output_to_temp_buffer): Function deleted.
21537
21538 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
21539
e67a13ab
CY
215402011-04-06 Chong Yidong <cyd@stupidchicken.com>
21541
04f2d78b
CB
21542 * process.c (Flist_processes): Remove to Lisp.
21543 (list_processes_1): Delete.
e67a13ab 21544
973f782d
EZ
215452011-04-06 Eli Zaretskii <eliz@gnu.org>
21546
7c106b1e
EZ
21547 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
21548
973f782d
EZ
21549 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
21550
41cf7d1a 215512011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 21552
ca23cc88
PE
21553 Fix more problems found by GCC 4.6.0's static checks.
21554
f390e2d5
PE
21555 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
21556
42eea0d0
PE
21557 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
21558
b69769da 21559 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 21560
f9541e84
PE
21561 * xdisp.c (vmessage): Mark as a printf-like function.
21562
13841b55
PE
21563 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
21564
c136c10f
PE
21565 * sound.c (sound_warning): Don't crash if arg contains a printf format.
21566
5e2d4a30
PE
21567 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
21568 printf-like functions.
21569 (tiff_load): Add casts to remove these marks before passing them
21570 to system-supplied API.
21571
583f48b9
PE
21572 * eval.c (Fsignal): Remove excess argument to 'fatal'.
21573
b25d760e
PE
21574 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
21575 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
21576 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
21577 directly, rather than having caller test rule sign. This avoids
21578 some unnecessary tests.
21579 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
21580 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
21581 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 21582
bc7b6697 21583 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 21584 (xfont_open): Avoid unnecessary tests.
bc7b6697 21585
27ccc379
PE
21586 * composite.c (composition_gstring_put_cache): Use unsigned integer.
21587
dcd5c89a
PE
21588 * composite.h, composite.c (composition_gstring_put_cache):
21589 Use EMACS_INT, not int, for length.
21590
b13a45c6
PE
21591 * composite.h (COMPOSITION_DECODE_REFS): New macro,
21592 breaking out part of COMPOSITION_DECODE_RULE.
21593 (COMPOSITION_DECODE_RULE): Use it.
21594 * composite.c (get_composition_id): Remove unused local vars,
21595 by using the new macro.
21596
1e792e4d
PE
21597 * textprop.c (set_text_properties_1): Change while to do-while,
21598 since the condition is always true at first.
21599
dc6c6455 21600 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
21601 (interval_deletion_adjustment): Return unsigned value.
21602 All uses changed.
dc6c6455 21603
aba7731a
PE
21604 * process.c (list_processes_1, create_pty, read_process_output):
21605 (exec_sentinel): Remove vars that were set but not used.
afd4052b 21606 (create_pty): Remove unnecessary "volatile"s.
bc57d757 21607 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 21608 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 21609 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 21610
fdfc4bf3
PE
21611 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
21612
fca8fe46 21613 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 21614 (update_syntax_table): Use unsigned instead of int.
fca8fe46 21615
06a0259a 21616 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 21617 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 21618 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 21619
e7b9e80f
PE
21620 * print.c (print_error_message): Avoid int overflow.
21621
56201685
PE
21622 * font.c (font_list_entities): Redo for clarity,
21623 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
21624
78834453 21625 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 21626 (font_score): Avoid potential overflow in diff calculation.
78834453 21627
0bc0b309 21628 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 21629 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 21630
e610eaca
PE
21631 * eval.c (funcall_lambda): Rename local to avoid shadowing.
21632
b895abce
PE
21633 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
21634 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
21635 can always succeed if overflow has undefined behavior.
21636
1f1d9321 21637 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 21638 (wordify): Omit three unnecessary tests.
1f1d9321 21639
c59478bc
PE
21640 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
21641 All callers changed. This avoids the need for an unused var.
21642
79b73827
PE
21643 * casefiddle.c (casify_region): Remove var that is set but not used.
21644
a4db5dfe
PE
21645 * dired.c (file_name_completion): Remove var that is set but not used.
21646
43aae36e
PE
21647 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
21648
2a47c44d 21649 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 21650 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 21651
a37c69bf
PE
21652 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
21653 Check for integer overflow on size calculations.
21654
328ab8e7
PE
21655 * buffer.c (Fprevious_overlay_change): Remove var that is set
21656 but not used.
21657
e5a2a5cb
PE
21658 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
21659 Remove vars that are set but not used.
8d84a6eb 21660 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 21661 (timer_check_2): Mark vars as initialized.
e5a2a5cb 21662
a60e5f68
PE
21663 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
21664
f661cb61 21665 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 21666 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 21667
f0397f5a
PE
21668 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
21669 that are set but not used.
21670
8664db06 21671 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 21672 if XCreateBitmapFromData fails (Bug#8410).
8664db06 21673
6abdaa4a
PE
21674 * xselect.c (x_get_local_selection, x_handle_property_notify):
21675 Remove vars that are set but not used.
21676
0ce7538d 21677 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 21678 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 21679
9ae848fc
PE
21680 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
21681 Remove var that is set but not used.
0b918413
PE
21682 (scroll_bar_windows_size): Now size_t, not int.
21683 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
21684 Check for overflow.
9ae848fc 21685
a5a62657
PE
21686 * xfaces.c (realize_named_face): Remove vars that are set but not used.
21687 (map_tty_color) [!defined MSDOS]: Likewise.
21688
5c5cdd39
PE
21689 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
21690
66ebf983
PE
21691 * coding.c: Remove vars that are set but not used.
21692 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
21693 All callers changed.
21694 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
21695 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
21696 (decode_coding_charset): Remove vars that are set but not used.
21697
1be4d761
PE
21698 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
21699 that is set but not used.
21700
47553fa8
PE
21701 * print.c (print_object): Remove var that is set but not used.
21702
1f7196bf 21703 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
21704 The gnulib version avoids calling malloc in the usual case,
21705 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
21706 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
21707 * filelock.c (current_lock_owner): Likewise.
21708 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
21709 * sysdep.c: Include allocator.h, careadlinkat.h.
21710 (emacs_no_realloc_allocator): New static constant.
21711 (emacs_readlink): New function.
fdb61804
PE
21712 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
21713 ../lib/careadlinkat.h.
d1fdcab7 21714
f84c17c7
SM
217152011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
21716
21717 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
21718 first non-nil return value).
21719
ef3862ad
JD
217202011-04-03 Jan Djärv <jan.h.d@swipnet.se>
21721
21722 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
21723 if not defined (Bug#8403).
21724
376a7006
JB
217252011-04-02 Juanma Barranquero <lekktu@gmail.com>
21726
21727 * xdisp.c (display_count_lines): Remove parameter `start',
21728 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
21729 (get_char_face_and_encoding): Remove parameter `multibyte_p',
21730 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
21731 (fill_stretch_glyph_string): Remove parameters `row' and `area',
21732 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
21733 and thereabouts. All callers changed.
21734 (get_per_char_metric): Remove parameter `f', unused since
21735 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
21736
6ca3801d
JM
217372011-04-02 Jim Meyering <meyering@redhat.com>
21738
21739 do not dereference NULL upon failed strdup
21740 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
21741 (ns_get_family): Likewise.
21742
d8e2b5ba
JB
217432011-04-02 Juanma Barranquero <lekktu@gmail.com>
21744
21745 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
21746
8c74fcbd
JD
217472011-04-02 Jan Djärv <jan.h.d@swipnet.se>
21748
21749 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
21750 later (Bug#8403).
21751
7200d79c
SM
217522011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
21753
03408648 21754 Add lexical binding.
7200d79c 21755
03408648
SM
21756 * window.c (Ftemp_output_buffer_show): New fun.
21757 (Fsave_window_excursion):
21758 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
21759
21760 * lread.c (lisp_file_lexically_bound_p): New function.
21761 (Fload): Bind Qlexical_binding.
21762 (readevalloop): Remove `evalfun' arg.
21763 Bind Qinternal_interpreter_environment.
21764 (Feval_buffer): Bind Qlexical_binding.
21765 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
21766 Mark as dynamic.
21767 (syms_of_lread): Declare `lexical-binding'.
21768
21769 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
21770
21771 * keyboard.c (eval_dyn): New fun.
21772 (menu_item_eval_property): Use it.
ca105506
SM
21773
21774 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 21775
03408648
SM
21776 * fns.c (concat, mapcar1): Accept byte-code-functions.
21777
21778 * eval.c (Fsetq): Handle lexical vars.
21779 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
21780 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
21781 (FletX, Flet): Obey lexical binding.
21782 (Fcommandp): Handle closures.
21783 (Feval): New `lexical' arg.
21784 (eval_sub): New function extracted from Feval. Use it almost
21785 everywhere where Feval was used. Look up vars in lexical env.
21786 Handle closures.
21787 (Ffunctionp): Move from subr.el.
21788 (Ffuncall): Handle closures.
21789 (apply_lambda): Remove `eval_flags'.
21790 (funcall_lambda): Handle closures and new byte-code-functions.
21791 (Fspecial_variable_p): New function.
21792 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
21793 but without exporting it to Lisp.
23aba0ea 21794
23aba0ea 21795 * doc.c (Fdocumentation, store_function_docstring):
03408648 21796 * data.c (Finteractive_form): Handle closures.
23aba0ea 21797
03408648
SM
21798 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
21799 interactive spec.
ba83908c 21800
04f2d78b
CB
21801 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
21802 New byte-codes.
03408648
SM
21803 (exec_byte_code): New function extracted from Fbyte_code to handle new
21804 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 21805
03408648 21806 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 21807
03408648 21808 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 21809
e2abce01
JB
218102011-03-31 Juanma Barranquero <lekktu@gmail.com>
21811
21812 * xdisp.c (redisplay_internal): Fix prototype.
21813
63696a73 218142011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 21815
63696a73 21816 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
21817 (try_scrolling): Use it when setting scroll_limit.
21818 Limit scrolling to 100 screen lines.
63696a73
EZ
21819 (redisplay_window): Even when falling back on "recentering",
21820 position point in the window according to scroll-conservatively,
21821 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
21822
21823 (try_scrolling): When point is above the window, allow searching
21824 as far as scroll_max, or one screenful, to compute vertical
21825 distance from PT to the scroll margin position. This prevents
21826 try_scrolling from unnecessarily failing when
21827 scroll-conservatively is set to a value slightly larger than the
21828 window height. Clean up the case of PT below the margin at bottom
21829 of window: scroll_max can no longer be INT_MAX. When aggressive
21830 scrolling is in use, don't let point enter the opposite scroll
21831 margin as result of the scroll.
21832 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
21833 threshold of 100 lines for never-recentering scrolling.
21834
e4cc2dfc
JB
218352011-03-31 Juanma Barranquero <lekktu@gmail.com>
21836
21837 * dispextern.h (move_it_by_lines):
21838 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
21839 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
21840 (message_log_check_duplicate): Remove parameters `prev_bol' and
21841 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
21842 (redisplay_internal): Remove parameter `preserve_echo_area',
21843 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
21844
21845 * indent.c (Fvertical_motion):
21846 * window.c (window_scroll_pixel_based, Frecenter):
21847 Don't pass `need_y_p' to `move_it_by_lines'.
21848
1c470562
SM
218492011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
21850
44f230aa
SM
21851 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
21852 steal a few bits to be more compact.
21853 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
21854 Remove unneeded casts.
21855
1c470562
SM
21856 * bytecode.c (Fbyte_code): CAR and CDR can GC.
21857
888adce9
ZK
218582011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
21859
21860 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
21861 binding" message (bug#7967).
21862
f838ed7b
PE
218632011-03-30 Paul Eggert <eggert@cs.ucla.edu>
21864
77861b95
PE
21865 Fix more problems found by GCC 4.6.0's static checks.
21866
de6dbc14
PE
21867 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
21868 Remove unused local var.
21869
f838ed7b
PE
21870 * editfns.c (Fmessage_box): Remove unused local var.
21871
792c7b2b
PE
21872 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
21873 (note_mode_line_or_margin_highlight, note_mouse_highlight):
21874 Omit unused local vars.
c499e557 21875 * window.c (shrink_windows): Omit unused local var.
b01a1c29 21876 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
21877 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
21878 Omit unused local var.
21879
ba0165e1
PE
21880 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
21881 Don't assume string length fits in int.
32ad8845 21882 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 21883 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 21884
3c59b4c9
PE
21885 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
21886 instead of alloca (Bug#8344).
21887
a3eed478 21888 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 21889 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 21890
eb4d412d
PE
21891 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
21892
1658b401
PE
21893 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
21894 concerns.
21895
21896 * term.c (produce_glyphless_glyph): Remove unnecessary test.
21897
21898 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 21899
9a2c6e05
PE
21900 * keyboard.c (syms_of_keyboard): Use the same style as later
21901 in this function when indexing through an array. This also
21902 works around GCC bug 48267.
21903
03d0a109
PE
21904 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
21905
44f730c8
PE
21906 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
21907
fe75f926
PE
21908 * chartab.c (sub_char_table_ref_and_range): Redo for slight
21909 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
21910
ffa8c828
PE
21911 * keyboard.c, keyboard.h (num_input_events): Now size_t.
21912 This avoids undefined behavior on integer overflow, and is a bit
21913 more convenient anyway since it is compared to a size_t variable.
21914
c5101a77
PE
21915 Variadic C functions now count arguments with size_t, not int.
21916 This avoids an unnecessary limitation on 64-bit machines, which
21917 caused (substring ...) to crash on large vectors (Bug#8344).
21918 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
21919 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 21920 All variadic functions and their callers changed accordingly.
c5101a77
PE
21921 (struct gcpro.nvars): Now size_t, not int. All uses changed.
21922 * data.c (arith_driver, float_arith_driver): Likewise.
21923 * editfns.c (general_insert_function): Likewise.
21924 * eval.c (struct backtrace.nargs, interactive_p)
21925 (internal_condition_case_n, run_hook_with_args, apply_lambda)
21926 (funcall_lambda, mark_backtrace): Likewise.
21927 * fns.c (concat): Likewise.
21928 * frame.c (x_set_frame_parameters): Likewise.
21929 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
21930 0 if not found, not -1. All callers changed.
21931
dd3f25f7
PE
21932 * alloc.c (garbage_collect): Don't assume stack size fits in int.
21933 (stack_copy_size): Now size_t, not int.
21934 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
21935
461c2ab9
JB
219362011-03-28 Juanma Barranquero <lekktu@gmail.com>
21937
21938 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
21939 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
21940 All callers changed.
21941
21942 * lisp.h (multibyte_char_to_unibyte):
21943 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
21944 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
21945 * character.h (CHAR_TO_BYTE8):
21946 * cmds.c (internal_self_insert):
21947 * editfns.c (general_insert_function):
21948 * keymap.c (push_key_description):
21949 * search.c (Freplace_match):
21950 * xdisp.c (message_dolog, set_message_1): All callers changed.
21951
f6d62986
SM
219522011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
21953
21954 * keyboard.c (safe_run_hook_funcall): New function.
21955 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
21956 don't set the hook to nil, but remove the offending function instead.
21957 (Qcommand_hook_internal): Remove, unused.
21958 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
21959 Vcommand_hook_internal.
21960
21961 * eval.c (enum run_hooks_condition): Remove.
21962 (funcall_nil, funcall_not): New functions.
21963 (run_hook_with_args): Call each function through a `funcall' argument.
21964 Remove `cond' argument, now redundant.
21965 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
21966 (Frun_hook_with_args_until_failure): Adjust accordingly.
21967 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
21968
1db5b1ad
JB
219692011-03-28 Juanma Barranquero <lekktu@gmail.com>
21970
21971 * dispextern.h (string_buffer_position): Remove declaration.
21972
21973 * print.c (strout): Remove parameter `multibyte', unused since
21974 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
21975
21976 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
21977 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
21978 All callers changed.
21979
21980 * w32.c (_wsa_errlist): Use braces for struct initializers.
21981
21982 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
21983 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
21984 All callers changed.
21985 (string_buffer_position): Likewise. Also, make static (it's never
21986 used outside xdisp.c).
21987 (cursor_row_p): Remove parameter `w', unused since
21988 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
21989 (decode_mode_spec): Remove parameter `precision', introduced during
21990 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
21991 All callers changed.
21992
5ffb62aa
JD
219932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
21994
21995 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
21996
461c2ab9 219972011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
21998
21999 * nsterm.m (ns_menu_bar_is_hidden): New variable.
22000 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
22001 (ns_update_auto_hide_menu_bar): New functions.
22002 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
22003 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
22004 ns_constrain_all_frames.
22005 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
22006 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
22007
5c380ffb
JD
220082011-03-27 Jan Djärv <jan.h.d@swipnet.se>
22009
22010 * nsmenu.m (runDialogAt): Remove argument to timer_check.
22011
9af30bdf
GM
220122011-03-27 Glenn Morris <rgm@gnu.org>
22013
22014 * syssignal.h: Replace RETSIGTYPE with void.
22015 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
22016 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
22017 Replace SIGTYPE with void everywhere.
22018 * s/usg5-4-common.h (SIGTYPE): Remove definition.
22019 * s/template.h (SIGTYPE): Remove commented out definition.
22020
e2abce01
JB
220212011-03-26 Eli Zaretskii <eliz@gnu.org>
22022
22023 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
22024 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
22025
f868cd8a
JB
220262011-03-26 Juanma Barranquero <lekktu@gmail.com>
22027
59eb0929
JB
22028 * w32.c (read_unc_volume): Use parameter `henum', instead of
22029 global variable `wget_enum_handle'.
22030
22031 * keymap.c (describe_vector): Remove parameters `indices' and
22032 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
22033 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
22034
f868cd8a
JB
22035 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
22036
22037 * keyboard.c (timer_check): Remove parameter `do_it_now',
22038 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
22039 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
22040 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
22041
22042 * keyboard.c (read_char):
22043 * w32menu.c (w32_menu_display_help):
22044 * xmenu.c (show_help_event, menu_help_callback):
22045 Adjust calls to `show_help_echo'.
22046
22047 * gtkutil.c (xg_maybe_add_timer):
22048 * keyboard.c (readable_events):
22049 * process.c (wait_reading_process_output):
22050 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
22051
22052 * insdel.c (adjust_markers_gap_motion):
22053 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
22054 (gap_left, gap_right): Don't call it.
22055
2ecf6fdb
CY
220562011-03-25 Chong Yidong <cyd@stupidchicken.com>
22057
22058 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
22059 incurred during fontification.
22060
6b1f9ba4
JB
220612011-03-25 Juanma Barranquero <lekktu@gmail.com>
22062
22063 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
22064 (DEFVAR_PER_BUFFER): Don't pass it.
22065
22066 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
22067 (scrolling_window): Don't pass it.
22068
0f4a96b5
JB
220692011-03-25 Juanma Barranquero <lekktu@gmail.com>
22070
22071 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
22072
22073 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
22074 and `suffix'.
22075 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
22076 of variables specific to SELinux and computation of `encoded_absname'.
22077
22078 * image.c (XPutPixel): Remove unused variable `height'.
22079
22080 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
22081
22082 * unexw32.c (get_section_info): Remove unused variable `section'.
22083
22084 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
22085 (system_process_attributes): Remove unused variable `sess'.
22086 (sys_read): Remove unused variable `err'.
22087
22088 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
22089 (w32_wnd_proc): Remove unused variable `isdead'.
22090 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
22091 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
22092 (x_create_tip_frame): Remove unused variable `tem'.
22093
22094 * w32inevt.c (w32_console_read_socket):
22095 Remove unused variable `no_events'.
22096
22097 * w32term.c (x_draw_composite_glyph_string_foreground):
22098 Remove unused variable `width'.
22099
1149507c
JB
221002011-03-24 Juanma Barranquero <lekktu@gmail.com>
22101
22102 * w32term.c (x_set_glyph_string_clipping):
22103 Don't pass uninitialized region to CombineRgn.
22104
9c88f339
JB
221052011-03-23 Juanma Barranquero <lekktu@gmail.com>
22106
22107 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
22108 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
22109 (Fx_close_connection): Remove unused variable `i'.
22110
22111 * w32font.c (w32font_draw): Return number of glyphs.
22112 (w32font_open_internal): Remove unused variable `i'.
22113 (w32font_driver): Add missing initializer.
22114
22115 * w32menu.c (utf8to16): Remove unused variable `utf16'.
22116 (fill_in_menu): Remove unused variable `items_added'.
22117
22118 * w32term.c (last_mouse_press_frame): Remove static global variable.
22119 (w32_clip_to_row): Remove unused variable `f'.
22120 (x_delete_terminal): Remove unused variable `i'.
22121
22122 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
22123 (NOTHING): Remove unused static global variable.
22124 (uniscribe_check_otf): Remove unused variable `table'.
22125 (uniscribe_font_driver): Add missing initializers.
22126
dee091a3
JD
221272011-03-23 Julien Danjou <julien@danjou.info>
22128
22129 * term.c (Fsuspend_tty, Fresume_tty):
22130 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
22131 * window.c (temp_output_buffer_show):
22132 * insdel.c (signal_before_change):
22133 * frame.c (Fhandle_switch_frame):
22134 * fileio.c (Fdo_auto_save):
22135 * emacs.c (Fkill_emacs):
22136 * editfns.c (save_excursion_restore):
22137 * cmds.c (internal_self_insert):
22138 * callint.c (Fcall_interactively):
22139 * buffer.c (Fkill_all_local_variables):
22140 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
22141 Use Frun_hooks.
0f4a96b5 22142 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 22143 unconditionally since it does the check itself.
dee091a3 22144
2c520ab5 221452011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 22146
c9c49752
PE
22147 Fix more problems found by GCC 4.5.2's static checks.
22148
8abc3f12
PE
22149 * coding.c (encode_coding_raw_text): Avoid unnecessary test
22150 the first time through the loop, since we know p0 < p1 then.
22151 This also avoids a gcc -Wstrict-overflow warning.
22152
a2d26660
PE
22153 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
22154 leading to a memory leak, possible in functions like
22155 load_charset_map_from_file that can allocate an unbounded number
b12ef411 22156 of objects (Bug#8318).
a2d26660 22157
916c72e9
PE
22158 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
22159 that could (at least in theory) be that large.
22160
19ab8a18
PE
22161 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
22162 This is less likely to overflow, and avoids undefined behavior if
22163 overflow does occur. All callers changed. Use strtoul to scan
22164 for the unsigned long integer.
b7cbbd6f
PE
22165 (pint2hrstr): Simplify and tune code slightly.
22166 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 22167
f0641eff
PE
22168 * scroll.c (do_scrolling): Work around GCC bug 48228.
22169 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
22170
7f650bb9
PE
22171 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
22172 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
22173 (validate_x_resource_name): Simplify count usage.
22174 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 22175
37dd57d1
PE
22176 * fileio.c (Fcopy_file): Report error if fchown or fchmod
22177 fail (Bug#8306).
81e56e61 22178
699979fc 22179 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 22180
401bf9b4
PE
22181 * process.c (Fmake_network_process): Use socklen_t, not int,
22182 where POSIX says socklen_t is required in portable programs.
22183 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 22184 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
22185 (Fmake_network_process, server_accept_connection):
22186 (wait_reading_process_output, read_process_output):
22187 Likewise.
22188
b93aacde
PE
22189 * process.c: Rename or move locals to avoid shadowing.
22190 (list_processes_1, Fmake_network_process):
22191 (read_process_output_error_handler, exec_sentinel_error_handler):
22192 Rename or move locals.
4dc343ee 22193 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 22194 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 22195 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 22196 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 22197 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 22198
af8a867c 22199 Make tparam.h and terminfo.c consistent.
44f230aa
SM
22200 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
22201 Include tparam.h instead, since it declares them.
af8a867c
PE
22202 * cm.h (PC): Remove extern decl; tparam.h now does this.
22203 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
22204 * terminfo.c: Include tparam.h, to check interfaces.
22205 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
22206 (tparam): Adjust signature to match interface in tparam.h;
22207 this removes some undefined behavior. Check that outstring and len
22208 are zero, which they always are with Emacs.
22209 * tparam.h (PC, BC, UP): New extern decls.
22210
0248044d 22211 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 22212 (xftfont_open): Rename locals to avoid shadowing.
0248044d 22213
8ff096c1 22214 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
22215 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
22216 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 22217 (ftfont_list): Remove unused local.
49eaafba
PE
22218 (get_adstyle_property, ftfont_pattern_entity):
22219 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
22220 Rename locals to avoid shadowing.
8ff096c1 22221
e2be39f6
PE
22222 * xfont.c (xfont_list_family): Mark var as initialized.
22223
c9735e30
PE
22224 * xml.c (make_dom): Now static.
22225
8f5201ae
PE
22226 * composite.c (composition_compute_stop_pos): Rename local to
22227 avoid shadowing.
b246f932
PE
22228 (composition_reseat_it): Remove unused locals.
22229 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 22230 (composition_update_it): Mark var as initialized.
11b61122
PE
22231 (find_automatic_composition): Mark vars as initialized,
22232 with a FIXME (Bug#8290).
8f5201ae 22233
760fbc2c
PE
22234 character.h: Rename locals to avoid shadowing.
22235 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
22236 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
22237 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
22238 (BUF_DEC_POS): Be more systematic about renaming local temporaries
22239 to avoid shadowing.
22240
ff08eb85
PE
22241 * textprop.c (property_change_between_p): Remove; unused.
22242
fc7bf025
PE
22243 * intervals.c (interval_start_pos): Now static.
22244
235d7abc
PE
22245 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
22246
44f230aa
SM
22247 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
22248 Rename locals to avoid shadowing.
3e7d6594 22249
50060332
PE
22250 * sound.c (wav_play, au_play, Fplay_sound_internal):
22251 Fix pointer signedness.
d01f234b 22252 (alsa_choose_format): Remove unused local var.
c83b8872
PE
22253 (wav_play): Initialize a variable to 0, to prevent undefined
22254 behavior (Bug#8278).
50060332 22255
c4fc4e30
PE
22256 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
22257
918436ed
PE
22258 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
22259
c939f91b
PE
22260 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
22261 clobbering (Bug#8298).
b9c7f648
PE
22262 * sysdep.c (sys_subshell): Likewise.
22263 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 22264
6bd8c144
PE
22265 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
22266 This should get cleaned up, so that child_setup has the
22267 same signature on all platforms.
22268
7710357c 22269 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 22270 (relocate_fd): Rename locals to avoid shadowing.
7710357c 22271
c59da222
CY
222722011-03-22 Chong Yidong <cyd@stupidchicken.com>
22273
22274 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
22275 not to be necessary, and produces flickering.
22276
66b87493
GM
222772011-03-20 Glenn Morris <rgm@gnu.org>
22278
22279 * config.in: Remove file.
22280
45b6f6d5
JB
222812011-03-20 Juanma Barranquero <lekktu@gmail.com>
22282
22283 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
22284 are now in src/globals.h.
22285 (syms_of_minibuf): Remove spurious & from previous change.
22286
cd394be1 222872011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
22288
22289 * minibuf.c (completing-read-function): New variable.
22290 (completing-read-default): Rename from completing-read.
22291 (completing-read): Call completing-read-function.
22292
b14e3e21
CY
222932011-03-19 Juanma Barranquero <lekktu@gmail.com>
22294
22295 * xfaces.c (Fx_load_color_file):
22296 Read color file from absolute filename (bug#8250).
22297
f2b726e6
JB
222982011-03-19 Juanma Barranquero <lekktu@gmail.com>
22299
22300 * makefile.w32-in: Update dependencies.
22301
09f6ff02
EZ
223022011-03-17 Eli Zaretskii <eliz@gnu.org>
22303
22304 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
22305
29a6015a
PE
223062011-03-17 Paul Eggert <eggert@cs.ucla.edu>
22307
a3a6c54e
PE
22308 Fix more problems found by GCC 4.5.2's static checks.
22309
b766f867
PE
22310 * process.c (make_serial_process_unwind, send_process_trap):
22311 (sigchld_handler): Now static.
22312
be02381c
PE
22313 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
22314 That way, the code declares only the vars that it needs.
22315 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
22316 * s/cygwin.h (PTY_ITERATION): Likewise.
22317 * s/darwin.h (PTY_ITERATION): Likewise.
22318 * s/gnu-linux.h (PTY_ITERATION): Likewise.
22319
57048744
PE
22320 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
22321 * process.c (allocate_pty): Don't declare stb unless it's needed.
22322
7914961c 22323 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
22324 (CONSTANTLIM): Remove; unused.
22325 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
22326 Define only if needed.
7914961c 22327
b3967b18
PE
22328 * unexelf.c (unexec): Name an expression,
22329 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
22330 Use a different way to cause a compilation error if anyone uses
22331 n rather than nn, a way that does not involve shadowing.
73366a00 22332 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 22333
29a6015a
PE
22334 * deps.mk (unexalpha.o): Remove; unused.
22335
43cfc33e 22336 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 22337 * unexec.h: New file.
ce701a33
PE
22338 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
22339 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
22340 Depend on unexec.h.
22341 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
22342 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
22343 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 22344 Change as necessary to match prototype in unexec.h.
ce701a33 22345
01f44d5a
PE
22346 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
22347 shadowing.
4f63c6bb 22348 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 22349
a6670b0b
PE
22350 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
22351 Rename locals to avoid shadowing.
22352
cef2010d 22353 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 22354 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 22355
d4d7173a
PE
22356 * print.c (Fredirect_debugging_output): Fix pointer signedess.
22357
f08b802a
PE
22358 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
22359 warning when compiling print.c.
22360
3ddb0639
PE
22361 * font.c (font_unparse_fcname): Abort in an "impossible" situation
22362 instead of using an uninitialized var.
5ad03b97 22363 (font_sort_entities): Mark var as initialized.
3ddb0639 22364
170a2692
PE
22365 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
22366
e663c700
PE
22367 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
22368 pointers to constants.
89bc529a 22369 (font_parse_fcname): Remove unused vars.
7b81e2d0 22370 (font_delete_unmatched): Now static.
ea838e10 22371 (font_get_spec): Remove; unused.
13a547c6
PE
22372 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
22373 (font_update_drivers, Ffont_get_glyphs, font_add_log):
22374 Rename or move locals to avoid shadowing.
e663c700 22375
2a80c887 22376 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 22377 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 22378
1384fa33 22379 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 22380 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 22381
8b2c52e9
PE
22382 * alloc.c (mark_backtrace): Move decl from here ...
22383 * lisp.h: ... to here, so that it can be checked.
22384
475545b5 22385 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 22386 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
22387 (lisp_indirect_variable): Name an expression,
22388 to avoid gcc -Wbad-function-cast warning.
1faed8ae 22389 (Fdefvar): Rename locals to avoid shadowing.
475545b5 22390
b1349114 22391 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 22392 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 22393 Use const pointer when appropriate.
b1349114 22394
a2928364
PE
22395 * lisp.h (get_system_name, get_operating_system_release):
22396 Move decls here, to check interfaces.
22397 * process.c (get_operating_system_release): Move decl to lisp.h.
22398 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
22399 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
22400 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
22401 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
22402 (Fformat_time_string, Fencode_time, Finsert_char):
22403 (Ftranslate_region_internal, Fformat):
22404 Rename or remove local vars to avoid shadowing.
9710023e 22405 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 22406
a415e694
PE
22407 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
22408 avoid shadowing.
22409
8ef4622d
PE
22410 * lisp.h (eassert): Check that the argument compiles, even if
22411 ENABLE_CHECKING is not defined.
22412
946f9a5b
PE
22413 * data.c (Findirect_variable): Name an expression, to avoid
22414 gcc -Wbad-function-cast warning.
112396d6 22415 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 22416 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
22417 (Fmake_variable_buffer_local, Fmake_local_variable):
22418 Mark variables as initialized.
52746918 22419 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 22420
e5aab7e7 22421 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
22422 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
22423 Rename locals to avoid shadowing.
dff45157
PE
22424 (mark_stack): Move local variables into the #ifdef region where
22425 they're used.
7bc26fdb
PE
22426 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
22427 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
22428 needed otherwise.
22429 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
22430 (GC_STRING_CHARS): Remove; not used.
d40d4be1 22431 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 22432
e5aab7e7
PE
22433 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
22434 avoids undefined behavior in theory.
22435
4da60324
PE
22436 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
22437
88043301
PE
22438 Use functions, not macros, for up- and down-casing (Bug#8254).
22439 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
22440 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
22441 to use the following functions instead of these macros.
22442 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
22443 EMACS_INT, since callers assume the returned value fits in int.
22444 (upcase1): Likewise, for UPCASE_TABLE.
22445 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 22446 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 22447 the race-condition problem in the old DOWNCASE.
88043301 22448
19ed5445
PE
22449 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
22450 Rename locals to avoid shadowing.
22451 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
22452 (regex_compile, re_search_2, re_match_2_internal):
22453 Remove unused local vars.
952db0d7
PE
22454 (FREE_VAR): Rewrite so as not to use empty "else",
22455 which gcc can warn about.
da053e48 22456 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
22457 (RETALLOC_IF): Define only if needed.
22458 (WORDCHAR_P): Likewise. This one is never needed, but is used
22459 only in a comment talking about a compiler bug, so put inside
22460 the #if 0 of that comment.
22461 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
22462 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
22463 Remove; unused.
19ed5445 22464
1f3561e4 22465 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
22466 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
22467 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 22468
ded6f8f7
PE
22469 * search.c (simple_search): Remove unused var.
22470
dbd37a95
PE
22471 * dired.c (compile_pattern): Move decl from here ...
22472 * lisp.h: ... to here, so that it can be checked.
22473 (struct re_registers): New forward decl.
22474
7e47afad
PE
22475 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
22476
85f24f61
PE
22477 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
22478 All uses changed.
22479 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
22480 Rename locals to avoid shadowing.
5671df8f 22481 (Fvertical_motion): Mark locals as initialized.
85f24f61 22482
181aa2be 22483 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 22484 (casify_region): Mark local as initialized.
181aa2be 22485
930d429c
PE
22486 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
22487
7082eac6
PE
22488 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
22489 New macros, so that the caller can use some names other than
22490 gcpro1, gcpro2, etc.
22491 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
22492 of the new macros.
22493 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
22494 argument, for consistency with GCPRO2_VAR, etc: it is now the
22495 prefix of the variable, not the variable itself. All uses
22496 changed.
38b2c076
PE
22497 * dired.c (directory_files_internal, file_name_completion):
22498 Rename locals to avoid shadowing.
22499
15206ed9
PE
22500 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
22501 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
22502 dired.c's scmp function, had undefined behavior.
22503 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
22504 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
22505 * buffer.h: ... to here, because these macros use current_buffer,
22506 and the new implementation with inline functions needs to have
22507 current_buffer in scope now, rather than later when the macros
22508 are used.
22509 (downcase, upcase1): New static inline functions.
22510 (DOWNCASE, UPCASE1): Reimplement using these functions.
22511 This avoids undefined behavior in expressions like
22512 DOWNCASE (x) == DOWNCASE (y), which previously suffered
22513 from race conditions in accessing the global variables
22514 case_temp1 and case_temp2.
22515 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
22516 * lisp.h (case_temp1, case_temp2): Remove their decls.
22517 * character.h (ASCII_CHAR_P): Move from here ...
22518 * lisp.h: ... to here, so that the inline functions mentioned
22519 above can use them.
22520
4a6bea26
PE
22521 * dired.c (directory_files_internal_unwind): Now static.
22522
f14b7e14
PE
22523 * fileio.c (file_name_as_directory, directory_file_name):
22524 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
22525 Now static.
2893f146
PE
22526 (file_name_as_directory): Use const pointers when appropriate.
22527 (Fexpand_file_name): Likewise. In particular, newdir might
22528 point at constant storage, so make it a const pointer.
fd4ead52 22529 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
22530 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
22531 signedness issues.
f839df0c
PE
22532 (Fset_file_times, Finsert_file_contents, auto_save_error):
22533 Rename locals to avoid shadowing.
f14b7e14 22534
5716756e 22535 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
22536 (Ftry_completion, Fall_completions): Rename or remove locals
22537 to avoid shadowing.
5716756e 22538
b4c3046a
PE
22539 * marker.c (bytepos_to_charpos): Remove; unused.
22540
b45db522
PE
22541 * lisp.h (verify_bytepos, count_markers): New decls,
22542 so that gcc does not warn that these functions aren't declared.
22543
85876d07
PE
22544 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
22545 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 22546 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 22547 (copy_text): Remove unused local var.
85876d07 22548
03d78a21 22549 * filelock.c (within_one_second): Now static.
b3dd38ab 22550 (lock_file_1): Rename local to avoid shadowing.
03d78a21 22551
5df8f01b
PE
22552 * buffer.c (fix_overlays_before): Mark locals as initialized.
22553 (fix_start_end_in_overlays): Likewise. This function should be
22554 simplified by using pointers-to-pointers, but that's a different
22555 matter.
b1d876f1 22556 (switch_to_buffer_1): Now static.
8f54f30a
PE
22557 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
22558 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 22559
a70072c9 22560 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 22561 Fix pointer signedness issue.
edced198
PE
22562 (sys_subshell): Mark local as volatile if checking for lint,
22563 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 22564 (MAXPATHLEN): Define only if needed.
a70072c9 22565
a0977c44
PE
22566 * process.c (serial_open, serial_configure): Move decls from here ...
22567 * systty.h: ... to here, so that they can be checked.
22568
a884fdcc
PE
22569 * fns.c (get_random, seed_random): Move extern decls from here ...
22570 * lisp.h: ... to here, so that they can be checked.
22571
604efe86 22572 * sysdep.c (reset_io): Now static.
b8950c94 22573 (wait_for_termination_signal): Remove; unused.
604efe86 22574
38fc62d9
PE
22575 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
22576 (copy_keymap_item, append_key, push_text_char_description):
22577 Now static.
1004a21a 22578 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 22579 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
22580 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
22581 (describe_map_tree):
22582 Rename locals to avoid shadowing.
38fc62d9 22583
2f2650da
PE
22584 * keyboard.c: Declare functions static if they are not used elsewhere.
22585 (echo_char, echo_dash, cmd_error, top_level_2):
22586 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
22587 (read_char, kbd_buffer_get_event, make_lispy_position):
22588 (make_lispy_event, make_lispy_movement, apply_modifiers):
22589 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
22590 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
22591 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 22592 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 22593 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 22594
a053e86c 22595 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
22596 (mark_kboards): Move decl here ...
22597 * alloc.c (mark_kboards): ... from here.
a053e86c 22598
4752793e
PE
22599 * lisp.h (force_auto_save_soon): New decl.
22600
74f10ca7 22601 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
22602 (DEFINE_DUMMY_FUNCTION): New macro.
22603 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
22604 Use it.
c03cd23f
PE
22605 (main): Add casts to avoid warnings
22606 if GCC considers string literals to be constants.
74f10ca7 22607
022e70d4
PE
22608 * lisp.h (fatal_error_signal): Add decl, since it's exported.
22609
59d6fe83
PE
22610 * dbusbind.c: Pointer signedness fixes.
22611 (xd_signature, xd_append_arg, xd_initialize):
22612 (Fdbus_call_method, Fdbus_call_method_asynchronously):
22613 (Fdbus_method_return_internal, Fdbus_method_error_internal):
22614 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
22615 (Fdbus_register_signal): Use SSDATA when the context wants char *.
22616
78320123
PE
22617 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
22618 if GCC considers string literals to be constants.
49cebcca 22619 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 22620
35ac2a97
SM
226212011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
22622
fb103ca9
SM
22623 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
22624 (print_preprocess, print_object): New macro to fix last change.
22625
35ac2a97
SM
22626 * print.c (print_preprocess): Don't forget font objects.
22627
62973b41
JB
226282011-03-16 Juanma Barranquero <lekktu@gmail.com>
22629
22630 * emacs.c (USAGE3): Doc fixes.
22631
0e48bb22
AS
226322011-03-15 Andreas Schwab <schwab@linux-m68k.org>
22633
22634 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
22635 structure.
22636
7684e57b
JB
226372011-03-14 Juanma Barranquero <lekktu@gmail.com>
22638
22639 * lisp.h (VWindow_system, Qfile_name_history):
22640 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
22641 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
22642 (w32_system_caret_x, w32_system_caret_y): Declare extern.
22643
22644 * w32select.c: Don't #include "keyboard.h".
c96bbc66 22645 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
22646
22647 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
22648 * w32console.c (detect_input_pending, read_input_pending)
22649 (encode_terminal_code):
22650 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
22651 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
22652 (w32_system_caret_y, Qfile_name_history):
22653 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
22654 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
22655 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
22656 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
22657 * w32proc.c (Qlocal, report_file_error):
22658 * w32term.c (Vwindow_system, updating_frame):
22659 * w32uniscribe.c (initialized, uniscribe_font_driver):
22660 Remove unneeded extern declarations.
22661
2aa46d6c
CY
226622011-03-14 Chong Yidong <cyd@stupidchicken.com>
22663
c96bbc66 22664 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 22665
cffc6f3b
CY
226662011-03-13 Chong Yidong <cyd@stupidchicken.com>
22667
22668 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
22669 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
22670 These macros can no longer be used for assignment.
22671
44f230aa
SM
22672 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
22673 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
22674 (record_buffer_markers, fetch_buffer_markers): New functions for
22675 recording and fetching special buffer markers.
22676 (set_buffer_internal_1, set_buffer_temp): Use them.
22677
22678 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
22679
22680 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
22681
22682 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
22683 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
22684
22685 * xdisp.c (hscroll_window_tree):
22686 (reconsider_clip_changes): Use PT instead of BUF_PT.
22687
d251f04b
EZ
226882011-03-13 Eli Zaretskii <eliz@gnu.org>
22689
22690 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
22691 $(EMACS_ROOT)/lib/intprops.h.
22692
f0c77cd1
PE
226932011-03-13 Paul Eggert <eggert@cs.ucla.edu>
22694
3eca4629
PE
22695 Fix more problems found by GCC 4.5.2's static checks.
22696
7c86ee98
PE
22697 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
22698 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
22699 (xg_free_frame_widgets): Make it clear that a local variable is
22700 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
22701 (gdk_window_get_screen): Make it clear that this macro is needed
22702 only if USE_GTK_TOOLTIP.
1e5524e7
PE
22703 (int_gtk_range_get_value): New function, which avoids a diagnostic
22704 from gcc -Wbad-function-cast.
22705 (xg_set_toolkit_scroll_bar_thumb): Use it.
22706 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
22707 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
22708 (get_utf8_string, xg_get_file_with_chooser):
22709 Rename locals to avoid shadowing.
22710 (create_dialog): Move locals to avoid shadowing.
7c86ee98 22711
41729b81
PE
22712 * xgselect.c (xg_select): Remove unused var.
22713
f0c77cd1
PE
22714 * image.c (four_corners_best): Mark locals as initialized.
22715 (gif_load): Initialize transparent_p to zero (Bug#8238).
22716 Mark another local as initialized.
ec6cf4c6 22717 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 22718
ce0ad53d 22719 * image.c (clear_image_cache): Now static.
d5d5a617 22720 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 22721 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
22722 (x_edge_detection): Remove unnecessary cast that
22723 gcc -Wbad-function-cast diagnoses.
2037898d 22724 (gif_load): Fix pointer signedness.
6ae141d6
PE
22725 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
22726 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 22727
33383987 227282011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 22729
d32df629
PE
22730 Improve quality of tests for time stamp overflow.
22731 For example, without this patch (encode-time 0 0 0 1 1
22732 1152921504606846976) returns the obviously-bogus value (-948597
22733 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
22734 reports time overflow. See
22735 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
22736 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
22737 * editfns.c: Include limits.h and intprops.h.
22738 (TIME_T_MIN, TIME_T_MAX): New macros.
22739 (time_overflow): Move earlier, to before first use.
22740 (hi_time, lo_time): New functions, for an accurate test for
22741 out-of-range times.
22742 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
22743 (Fget_internal_run_time): Don't assume time_t fits in int.
22744 (make_time): Use list2 instead of Fcons twice.
22745 (Fdecode_time): More accurate test for out-of-range times.
22746 (check_tm_member): New function.
22747 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
22748 (lisp_time_argument): Don't rely on undefined left-shift and
22749 right-shift behavior when checking for time stamp overflow.
8be6f318 22750
fe31d94c
PE
22751 * editfns.c (time_overflow): New function, refactoring common code.
22752 (Fformat_time_string, Fdecode_time, Fencode_time):
22753 (Fcurrent_time_string): Use it.
22754
8be6f318
PE
22755 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
22756 * dired.c (make_time): Move to ...
22757 * editfns.c (make_time): ... here.
22758 * systime.h: Note the move.
22759
09d9db2c 227602011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 22761
126bc0dc
YM
22762 * fringe.c (update_window_fringes): Remove unused variables.
22763
c47cbdfd
YM
22764 * unexmacosx.c (copy_data_segment): Also copy __got section.
22765 (Bug#8223)
22766
7ac80be9
EZ
227672011-03-12 Eli Zaretskii <eliz@gnu.org>
22768
c96bbc66 22769 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
22770 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
22771 Constify `char *' arguments and their references according to
22772 prototypes in tparam.h.
22773
ecb0f94d 22774 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 22775
7ac80be9
EZ
22776 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
22777 Adapt all references accordingly.
22778
22779 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
22780
ef1fd07e
TT
227812011-03-11 Tom Tromey <tromey@redhat.com>
22782
22783 * buffer.c (syms_of_buffer): Remove obsolete comment.
22784
7ef4b50c
EZ
227852011-03-11 Eli Zaretskii <eliz@gnu.org>
22786
22787 * termhooks.h (encode_terminal_code): Declare prototype.
22788
22789 * msdos.c (encode_terminal_code): Don't declare prototype.
22790
22791 * term.c (encode_terminal_code): Now external again, used by
22792 w32console.c and msdos.c.
22793
44f230aa
SM
22794 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
22795 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 22796
4b1ec863 227972011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 22798
1714f52b 22799 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 22800
4b1ec863
PE
22801 * fringe.c (update_window_fringes): Mark locals as initialized
22802 (Bug#8227).
22803 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 22804
524c7aa6
PE
22805 * alloc.c (mark_fringe_data): Move decl from here ...
22806 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
22807 to check its interface.
22808 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
22809
a5c0af81 22810 * fontset.c (free_realized_fontset): Now static.
7519b8cd 22811 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 22812 (fontset_font): Mark local as initialized.
a9a06e0b 22813 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 22814
b4716021
PE
22815 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
22816
811e9bac 22817 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 22818 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
22819 (x_own_selection, Fx_disown_selection_internal): Rename locals
22820 to avoid shadowing.
22821 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 22822
7e3ab302
PE
22823 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
22824 so that the caller can use some name other than gcpro1.
22825 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
22826 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
22827 (Fx_backspace_delete_keys_p):
22828 Use them to avoid shadowing, and rename vars to avoid shadowing.
22829 (x_decode_color, x_set_name, x_window): Now static.
6b437900 22830 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 22831 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
22832 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
22833 Remove unused locals.
7e3ab302
PE
22834 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
22835 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
22836 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
22837 macros.
f78faa98 22838
e2b13473
PE
22839 * xterm.h (x_mouse_leave): New decl.
22840
77f23912
PE
22841 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
22842 Remove unused functions.
cdf4ba58
PE
22843 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
22844 (x_calc_absolute_position): Now static.
7411c686 22845 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 22846 Don't declare local "event" unless it's used.
ed7bf3a5
PE
22847 (x_iconify_frame, x_free_frame_resources): Don't declare locals
22848 unless they are used.
38d0b34a
PE
22849 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
22850 (x_fatal_error_signal): Remove; not used.
a6067996
PE
22851 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
22852 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
22853 (x_error_catcher, x_connection_closed, x_error_handler):
22854 (x_error_quitter, xembed_send_message, x_iconify_frame):
22855 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 22856 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 22857 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 22858
44f230aa
SM
22859 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
22860 Rename or move locals to avoid shadowing.
6b463e58 22861 (tty_defined_color, merge_face_heights): Now static.
5967d051 22862 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
22863 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
22864 does not deduce is never used uninitialized.
73719eba
PE
22865 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
22866 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 22867
426994c3 22868 * terminal.c (store_terminal_param): Now static.
5489860b 22869
032f1620 22870 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 22871 (set_frame_menubar): Remove unused local.
d4323972 22872 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
22873 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
22874 since they might point to immutable storage.
281585b0
PE
22875 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
22876 since it's unused otherwise.
032f1620 22877
367c19e5 22878 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 22879 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
22880 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
22881 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 22882 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
22883 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
22884 does not deduce are never used uninitialized.
70739cbe 22885
07b48fa9
PE
22886 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
22887
8868a238 22888 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
22889 * window.c (window_loop, size_window):
22890 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 22891
7e5cf297 22892 * window.c (display_buffer): Now static.
d6550a9f
PE
22893 (size_window): Mark variables that gcc -Wuninitialized
22894 does not deduce are never used uninitialized.
a586633d
PE
22895 * window.h (check_all_windows): New decl, to forestall
22896 gcc -Wmissing-prototypes diagnostic.
5b555da1 22897 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 22898
f6095868
PE
22899 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
22900 shadowing.
22901 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
22902 Include <limits.h>.
22903 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
22904 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
22905 (load_charset_map): Mark variables that gcc -Wuninitialized
22906 does not deduce are never used uninitialized.
53df7c11 22907 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 22908
f38b440c
PE
22909 * coding.c (coding_set_source, coding_set_destination):
22910 Use "else { /* comment */ }" rather than "else /* comment */;"
22911 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
22912 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
22913 a block, when the outer 'i' will do.
22914 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
22915 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
22916 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
22917 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
22918 (Fdecode_sjis_char, Fdefine_coding_system_internal):
22919 Rename locals to avoid shadowing.
22920 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
22921 * coding.c (emacs_mule_char, encode_invocation_designation):
22922 Now static, since they're not used elsewhere.
413bb2db 22923 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 22924 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
22925 (decode_coding_emacs_mule): Mark variables that gcc
22926 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
22927 (detect_coding_iso_2022): Initialize a local variable that might
22928 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 22929 this initialization is needed. (Bug#8211)
5f58e762
PE
22930 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
22931 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
22932 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
22933 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
22934 Remove unused macros.
f38b440c 22935
232b38b9 22936 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 22937 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 22938 * character.c (string_count_byte8): Likewise.
232b38b9 22939
fb90da1b
PE
22940 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
22941 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
22942
fb93dbc2
PE
22943 * chartab.c (copy_sub_char_table): Now static, since it's not used
22944 elsewhere.
5c156ace
PE
22945 (sub_char_table_ref_and_range, char_table_ref_and_range):
22946 Rename locals to avoid shadowing.
bbcd0949 22947 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 22948
7d3b3862 22949 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 22950 (BIDI_BOB): Remove unused macro.
7d3b3862 22951
6be7d3da
PE
22952 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
22953 deduce are never used uninitialized.
c2ed9c8b 22954 * term.c (encode_terminal_code): Likewise.
6be7d3da 22955
75f8807f 22956 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 22957
50938595
PE
22958 * tparam.h: New file.
22959 * term.c, tparam.h: Include it.
22960 * deps.mk (term.o, tparam.o): Depend on tparam.h.
22961 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
22962 Move these decls to tparam.h, and make them agree with what
22963 is actually in tparam.c. The previous trick of using incompatible
22964 decls in different modules does not conform to the C standard.
22965 All callers of tparam changed to use tparam's actual API.
22966 * tparam.c (tparam1, tparam, tgoto):
22967 Use const pointers where appropriate.
22968
fbceeba2
PE
22969 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
22970 * cm.h (struct cm): Likewise.
22971 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
22972 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
22973 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
22974 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
22975 (turn_on_face, init_tty): Likewise.
22976 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 22977
7f3f1250
PE
22978 * term.c (term_mouse_position): Rename local to avoid shadowing.
22979
e6ca6543
PE
22980 * alloc.c (mark_ttys): Move decl from here ...
22981 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
22982
c40f8d15
AS
229832011-03-11 Andreas Schwab <schwab@linux-m68k.org>
22984
22985 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
22986
cfe0661d
JB
229872011-03-09 Juanma Barranquero <lekktu@gmail.com>
22988
22989 * search.c (compile_pattern_1): Remove argument regp, unused since
22990 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
22991 (compile_pattern): Don't pass it.
22992
0afb4571
J
229932011-03-08 Jan Djärv <jan.h.d@swipnet.se>
22994
22995 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
22996 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
22997 for ! HAVE_GTK3.
22998 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
22999
23000 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
23001
23002 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
23003 gdk_window_get_screen, gdk_window_get_geometry,
23004 gdk_x11_window_lookup_for_display and GDK_KEY_g.
23005 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
23006 (xg_get_pixbuf_from_pixmap): New function.
23007 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
23008 to Pixmap, take frame as parameter, remove GdkColormap parameter.
23009 Call xg_get_pixbuf_from_pixmap instead of
23010 gdk_pixbuf_get_from_drawable.
23011 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
23012 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
23013 (xg_check_special_colors): Use GtkStyleContext and its functions
23014 for HAVE_GTK3.
23015 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
23016 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
23017 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
23018 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
23019 Call gtk_widget_get_preferred_size.
0afb4571
J
23020 (xg_frame_resized): gdk_window_get_geometry only takes 5
23021 parameters.
44f230aa
SM
23022 (xg_win_to_widget, xg_event_is_for_menubar):
23023 Call gdk_x11_window_lookup_for_display.
0afb4571
J
23024 (xg_set_widget_bg): New function.
23025 (delete_cb): New function.
895009e1 23026 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 23027 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
23028 (xg_set_background_color): Call xg_set_widget_bg.
23029 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
23030 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
23031 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
23032 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
23033 if ! HAVE_GTK3.
23034 (update_frame_tool_bar): Call gtk_widget_hide.
23035 (xg_initialize): Use GDK_KEY_g.
23036
23037 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
23038 if ! HAVE_GTK3
23039 (x_session_initialize): Call gdk_x11_set_sm_client_id.
23040
23041 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
23042 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
23043 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
23044
1c2cc4ef
JB
230452011-03-08 Juanma Barranquero <lekktu@gmail.com>
23046
23047 * w32xfns.c (select_palette): Check success of RealizePalette against
23048 GDI_ERROR, not zero.
23049
33383987 23050See ChangeLog.11 for earlier changes.
aac0c6e3
MR
23051
23052;; Local Variables:
23053;; coding: utf-8
aac0c6e3
MR
23054;; End:
23055
ab422c4d 23056 Copyright (C) 2011-2013 Free Software Foundation, Inc.
aac0c6e3
MR
23057
23058 This file is part of GNU Emacs.
23059
23060 GNU Emacs is free software: you can redistribute it and/or modify
23061 it under the terms of the GNU General Public License as published by
23062 the Free Software Foundation, either version 3 of the License, or
23063 (at your option) any later version.
23064
23065 GNU Emacs is distributed in the hope that it will be useful,
23066 but WITHOUT ANY WARRANTY; without even the implied warranty of
23067 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
23068 GNU General Public License for more details.
23069
23070 You should have received a copy of the GNU General Public License
23071 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.