* Makefile.in (ALL_CFLAGS): Add -I../lib -I${srcdir}/../lib.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3511c784
DA
12012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2
0a08eb21 3 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
4 strcasecmp if available.
5 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
6
fb7da12e
AS
72012-06-25 Andreas Schwab <schwab@linux-m68k.org>
8
9 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
10 Avoid comma operator.
11 * menu.c (push_submenu_start, push_submenu_end)
12 (push_left_right_boundary, push_menu_pane): Likewise.
13 * msdos.c (dos_rawgetc): Likewise.
14
afa2ffd8
DA
152012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
16
17 * xfns.c (xic_create_fontsetname): Remove redundant calls
18 to memset.
19
b3b4476b
PE
202012-06-25 Paul Eggert <eggert@cs.ucla.edu>
21
4495ff38
PE
22 * gtkutil.c (get_utf8_string): Remove redundant assignment.
23 sprintf already null-terminates its output.
24
b3b4476b
PE
25 * xfns.c (x_window): Remove redundant cast.
26
b00876c9
DA
272012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
28
29 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
30 `const char *' to `char *' to avoid compiler warning.
31
d188e26b
PE
322012-06-24 Paul Eggert <eggert@cs.ucla.edu>
33
885d1d74
PE
34 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
35 instead of truncating it to 63 (admittedly a generous limit).
36
d188e26b
PE
37 * process.c: Fix spelling and caps in comments.
38
e2f560b1
DN
392012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
40
e86db54b 41 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
42 * sysdep.c (setpgrp): Remove definition, not used in this file.
43
7583a3a1
JB
442012-06-24 Juanma Barranquero <lekktu@gmail.com>
45
46 * makefile.w32-in: Update dependencies.
47
696056c2
EZ
482012-06-24 Eli Zaretskii <eliz@gnu.org>
49
50 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
51 (SYSTIME_H): Add nt/inc/sys/time.h.
52
53 * systime.h [WINDOWSNT]: Include sys/time.h.
54
55 * s/ms-w32.h (struct timespec): Definition moved from
56 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
57
845ca893
PE
582012-06-24 Paul Eggert <eggert@cs.ucla.edu>
59
60 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
61 * buffer.h (buffer_slot_type_mismatch):
62 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
63 * eval.c (unwind_to_catch):
64 * image.c (my_png_error, my_error_exit):
65 * keyboard.c (quit_throw_to_read_char, user_error)
66 (Fexit_recursive_edit, Fabort_recursive_edit):
67 * lisp.h (die, args_out_of_range, args_out_of_range_3)
68 (wrong_type_argument, buffer_overflow, __executable_start)
69 (memory_full, buffer_memory_full, string_overflow, Fthrow)
70 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
71 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
72 (fatal):
73 (child_setup) [!DOS_NT]:
74 * lread.c (end_of_file_error, invalid_syntax):
75 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
76 * puresize.h (pure_write_error):
77 * search.c (matcher_overflow):
78 * sound.c (sound_perror, alsa_sound_perror):
79 * sysdep.c, syssignal.h (croak):
80 * term.c (maybe_fatal, vfatal):
81 * textprop.c (text_read_only):
82 * undo.c (user_error):
83 * unexmacosx.c (unexec_error):
84 * xterm.c (x_ins_del_lines, x_delete_glyphs):
85 Use _Noreturn rather than NO_RETURN.
86 No need for separate decl merely because of _Noreturn.
87 * sound.c (sound_warning, parse_sound):
88 Remove unnecessary forward decls.
89
f1dd8073
PE
902012-06-24 Paul Eggert <eggert@cs.ucla.edu>
91
92 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
93 * lisp.h (WAIT_READING_MAX): New macro.
94 * dispnew.c (Fsleep_for, sit_for):
95 * keyboard.c (kbd_buffer_get_event):
96 * process.c (Faccept_process_output):
97 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
98 This improves on the previous patch, which introduced a bug
99 when time_t is unsigned and as wide as intmax_t.
100 See <http://bugs.gnu.org/9000#51>.
101
b82c1755
EZ
1022012-06-23 Eli Zaretskii <eliz@gnu.org>
103
104 * dispnew.c (sit_for, Fsleep_for):
105 * keyboard.c (kbd_buffer_get_event):
106 * process.c (Faccept_process_output): Avoid compiler warnings when
107 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
108
ca300656
JB
1092012-06-23 Juanma Barranquero <lekktu@gmail.com>
110
049ec95b
JB
111 * makefile.w32-in: Update dependencies.
112
ca300656
JB
113 * w32.c (ltime): Add return type and declare static.
114 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
115
db7b8d06
PE
1162012-06-23 Paul Eggert <eggert@cs.ucla.edu>
117
118 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
119 Privately reported by Herbert J. Skuhra.
120 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
121 All uses changed.
122 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
123 not make_lisp_timeval, when the argument is of type EMACS_TIME.
124
0bd8297f
EZ
1252012-06-23 Eli Zaretskii <eliz@gnu.org>
126
96512555
EZ
127 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
128 last argument of make_unibyte_string.
129
0bd8297f
EZ
130 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
131 language ID in the event parameters.
132
133 * w32term.c (w32_read_socket): Put the new keyboard codepage into
134 event.code, not the obscure "character set ID".
135
63def6b6
CY
1362012-06-23 Chong Yidong <cyd@gnu.org>
137
138 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
139
e8a02204
EZ
1402012-06-23 Eli Zaretskii <eliz@gnu.org>
141
388cdec0
EZ
142 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
143 * w32.c (fdutimens): New function.
144
145 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
146
147 * s/ms-w32.h (pselect): Redirect to sys_select.
148
149 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
150
e8a02204
EZ
151 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
152 in the logic of incrementing and decrementing the value of
153 use_relocatable_buffers.
154
d054f3fb
PE
1552012-06-23 Paul Eggert <eggert@cs.ucla.edu>
156
157 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
158 Privately reported by Herbert J. Skuhra.
159 [__FreeBSD__]: Remove "*/" typo after "#include".
160 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
161 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
162 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
163 Don't assume EMACS_TIME and struct timeval are the same type.
164
d35af63c
PE
1652012-06-22 Paul Eggert <eggert@cs.ucla.edu>
166
167 Support higher-resolution time stamps (Bug#9000).
168 The time stamps are only nanosecond-resolution at the C level,
169 since that's the best that any real-world system supports now.
170 But they are picosecond-resolution at the Lisp level, as that's
171 easy, and leaves room for future OS improvements.
172
173 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
174 (LIBES): Use it.
175
176 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
177 Don't get current time unless it's needed.
178
179 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
180 now provides it if it's absent.
181 (start_atimer): Port to higher-res time stamps.
182 Check for time stamp overflow. Don't get current time more
183 often than is needed.
184
185 * buffer.h (struct buffer): Buffer modtime now has high resolution.
186 Include systime.h, not time.h.
187 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
188
189 * dired.c: Include stat-time.h.
190 (Ffile-attributes): File times now have higher resolution.
191
192 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
193 (struct image): Timestamp now has higher resolution.
194
195 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
196 has at least microseconds now. All uses removed.
197 (update_frame, update_single_window, update_window, update_frame_1)
198 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
199
200 * editfns.c (time_overflow): Now extern.
201 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
202 (float-time, Fformat_time_string, Fcurrent_time_string)
203 (Fcurrent_time_zone): Accept and generate higher-resolution
204 time stamps.
205 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
206 (decode_time_components, lisp_seconds_argument): New functions.
207 (make_time): Now static.
208 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
209 Report an error if the time is invalid, rather than having the caller
210 do that.
211
212 * fileio.c: Include <stat-time.h>
213 (Fcopy_file): Copy higher-resolution time stamps.
214 Prefer to set the time stamp via a file descriptor if that works.
215 (Fset_file_times, Finsert_file_contents, Fwrite_region)
216 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
217 (Fvisited_file_modtime, Fset_visited_file_modtime):
218 Support higher-resolution time stamps.
219
220 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
221
222 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
223
224 * image.c (prepare_image_for_display, clear_image_cache)
225 (lookup_image): Port to higer-resolution time stamps.
226
227 * keyboard.c (start_polling, bind_polling_period):
228 Check for time stamp overflow.
229 (read_char, kbd_buffer_get_event, timer_start_idle)
230 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
231 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
232 Port to higher-resolution time stamps. Do not assume time_t is signed.
233 (decode_timer): New function. Timers are now vectors of length 9,
234 not 8, to accommodate the picosecond component.
235 (timer_check_2): Use it.
236
237 * nsterm.m (select_timeout, timeval_subtract): Remove.
238 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
239 as they're a bit more accurate and handle overflow better.
240 (ns_select): Change prototype to be compatible with pselect.
241 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
242 * nsterm.h (ns_select): Adjust prototype.
243
244 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
245 us-resolution time stamps.
246 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
247
248 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
249
250 * lisp.h (time_overflow): New decl.
251 (wait_reading_process_output): First arg is now intmax_t, not int,
252 to accommodate larger waits.
253
254 * process.h (struct Lisp_Process.read_output_delay):
255 Now counts nanoseconds, not microseconds.
256 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
257 EMACS_HAS_USECS.
258 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
259 (wait_reading_process_output):
260 Port to ns-resolution time stamps.
261 (Faccept_process_output, wait_reading_process_output):
262 Check for time stamp overflow. Do not assume time_t is signed.
263 (select_wrapper): Remove; we now use pselect.
264 (Fprocess_attributes): Now generates ns-resolution time stamps.
265
266 * sysdep.c: Include utimens.h. Don't include utime.h
267 or worry about struct utimbuf; gnulib does that for us now.
268 (gettimeofday): Remove; gnulib provides a substitute.
269 (make_timeval): New function.
270 (set_file_times): Now sets ns-resolution time stamps.
271 New arg FD; all uses changed.
272 (time_from_jiffies, ltime_from_jiffies, get_up_time)
273 (system_process_attributes):
274 Now returns ns-resolution time stamp. All uses changed.
275 Check for time stamp overflow.
276
277 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
278 provides a substitute now.
279
280 * systime.h: Include timespec.h rather than sys/time.h and time.h,
281 since it guarantees struct timespec.
282 (EMACS_TIME): Now struct timespec, so that we can support
283 ns-resolution time stamps.
284 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
285 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
286 (EMACS_USECS): Remove.
287 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
288 so multiply the arg by 1000 before storing it.
289 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
290 New macros.
291 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
292 Port to ns-resolution time stamps.
293 (EMACS_TIME_NEG_P): Remove; replaced by....
294 (EMACS_TIME_SIGN): New macro.
295 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
296 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
297 (set_file_times, make_time, lisp_time_argument): Adjust signature.
298 (make_timeval, make_lisp_time, decode_time_components): New decls.
299 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
300 that it mishandled time_t overflow. You can't compare by subtracting!
301 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
302 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
303
304 * term.c: Include <sys/time.h>.
305 (timeval_to_Time): New function, for proper overflow wraparound.
306 (term_mouse_position, term_mouse_click): Use it.
307
308 * undo.c (record_first_change): Support higher-resolution time stamps
309 in the undo buffer.
310 (Fprimitive_undo): Use them when restoring time stamps.
311
312 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
313 (w32_get_internal_run_time):
314 Port to higher-resolution Emacs time stamps.
315 (ltime): Now accepts single 64-bit integer, as that's more convenient
316 for callers.
317
318 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
319
320 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
321 for compatibility with pselect. Support ns-resolution time stamps.
322
323 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
324
325 * xselect.c (wait_for_property_change, x_get_foreign_selection):
326 Check for time stamp overflow, and support ns-resolution time stamps.
327
328 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
329 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
330 (timeval_subtract): Remove; no longer needed.
331 (XTflash, XTring_bell, x_wait_for_event):
332 Port to ns-resolution time stamps. Don't assume time_t is signed.
333
b6a92dfe
CY
3342012-06-22 Chong Yidong <cyd@gnu.org>
335
336 * xdisp.c (x_consider_frame_title): Revert last change.
337
d251c37c
EZ
3382012-06-22 Eli Zaretskii <eliz@gnu.org>
339
340 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
341 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
342 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
343 staticidx goes up to 1597 out of 1600 = 0x640.)
344
f10deafb
PE
3452012-06-20 Paul Eggert <eggert@cs.ucla.edu>
346
347 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
348 Otherwise, the umask might be mistakenly 0 while handling input signals.
349
ec6de1e2
SM
3502012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
351
352 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
353
28be1ada
DA
3542012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
355
356 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
357 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
358 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
359 access to `contents' member of Lisp_Vector objects with AREF and ASET
360 where appropriate.
361
c6bf3022
CY
3622012-06-19 Chong Yidong <cyd@gnu.org>
363
364 * frame.c (delete_frame): When selecting a frame on a different
365 text terminal, do not alter the terminal's top-frame.
366
367 * xdisp.c (format_mode_line_unwind_data): Record the target
368 frame's selected window and its terminal's top-frame.
369 (unwind_format_mode_line): Restore them.
370 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
371 Callers changed.
372 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
373 since tty frames can be explicitly named.
374 (prepare_menu_bars): Likewise.
375
376 * term.c (Ftty_top_frame): New function.
377
defd4196
PE
3782012-06-18 Paul Eggert <eggert@cs.ucla.edu>
379
380 Port byte-code-meter to modern targets.
381 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
382 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 383 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
384 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
385 (METER_1, METER_2): Simplify.
386
1053a871
SM
3872012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
388
389 * data.c (Fdefalias): Return `symbol' (bug#11686).
390
b7e8d081
MR
3912012-06-18 Martin Rudalics <rudalics@gmx.at>
392
393 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
394 gets killed during executing of this function (Bug#11665).
395 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
396 (Vkill_buffer_query_functions): In doc-string say that functions
397 run by this hook should not change the current buffer.
398
7ea2b339
PE
3992012-06-18 Paul Eggert <eggert@cs.ucla.edu>
400
401 Fix recently-introduced process.c problems found by static checking.
402 * process.c (write_queue_push, write_queue_pop, send_process):
403 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
404 (write_queue_pop): Fix pointer signedness problem.
405 (send_process): Remove unused local.
406
96a313a1
CY
4072012-06-17 Chong Yidong <cyd@gnu.org>
408
409 * xdisp.c (redisplay_internal): No need to redisplay terminal
410 frames that are not on top.
411
20ca2e94
TN
4122012-06-17 Troels Nielsen <bn.troels@gmail.com>
413
414 * process.c (make_process): Initialize write_queue.
415 (write_queue_push, write_queue_pop): New functions.
416 (send_process): Use them to maintain correct ordering of process
417 writes (Bug#10815).
418
9a900ca9
PE
4192012-06-17 Paul Eggert <eggert@cs.ucla.edu>
420
310fbfa8
PE
421 * lisp.h (eassert): Assume C89 or later.
422 This removes the need for CHECK.
423 (CHECK): Remove. Its comments about always evaluating its
424 argument were confusing, as 'eassert' typically does not evaluate
425 its argument.
426
27bb1ca4
PE
427 * coding.c (produce_chars): Use ptrdiff_t, not int.
428
9a900ca9
PE
429 * xterm.c (x_draw_underwave): Check for integer overflow.
430 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
431
41b7f8bc 4322012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
433
434 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
435 referenced (Bug#11583).
436
9b0e3eba
AA
4372012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
438
439 Implement wave-style variant of underlining.
440 * dispextern.h (face_underline_type): New enum.
441 (face): Add field for underline type.
442 * nsterm.m (ns_draw_underwave): New function.
443 (ns_draw_text_decoration): Use it.
444 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
445 New functions.
446 (x_draw_glyph_string): Use them.
447 * xfaces.c (Qline, Qwave): New Lisp objects.
448 (check_lface_attrs, merge_face_ref)
1053a871
SM
449 (Finternal_set_lisp_face_attribute, realize_x_face):
450 Handle wave-style underline face attributes.
9b0e3eba
AA
451 * xterm.c (x_draw_underwave): New function.
452 (x_draw_glyph_string): Use it.
453
0fb52f11
JB
4542012-06-16 Juanma Barranquero <lekktu@gmail.com>
455
456 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
457 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
458 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
459 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
460 ($(BLD)/w32select.$(O)): Update dependencies.
461
e5560ff7
AS
4622012-06-16 Andreas Schwab <schwab@linux-m68k.org>
463
464 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
465 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
466 * character.c (_fetch_multibyte_char_p): Remove.
467 * alloc.c: Include "character.h" before "buffer.h".
468 * bidi.c: Likewise.
469 * buffer.c: Likewise.
470 * bytecode.c: Likewise.
471 * callint.c: Likewise.
472 * callproc.c: Likewise.
473 * casefiddle.c: Likewise.
474 * casetab.c: Likewise.
475 * category.c: Likewise.
476 * cmds.c: Likewise.
477 * coding.c: Likewise.
478 * composite.c: Likewise.
479 * dired.c: Likewise.
480 * dispnew.c: Likewise.
481 * doc.c: Likewise.
482 * dosfns.c: Likewise.
483 * editfns.c: Likewise.
484 * emacs.c: Likewise.
485 * fileio.c: Likewise.
486 * filelock.c: Likewise.
487 * font.c: Likewise.
488 * fontset.c: Likewise.
489 * fringe.c: Likewise.
490 * indent.c: Likewise.
491 * insdel.c: Likewise.
492 * intervals.c: Likewise.
493 * keyboard.c: Likewise.
494 * keymap.c: Likewise.
495 * lread.c: Likewise.
496 * macros.c: Likewise.
497 * marker.c: Likewise.
498 * minibuf.c: Likewise.
499 * nsfns.m: Likewise.
500 * nsmenu.m: Likewise.
501 * print.c: Likewise.
502 * process.c: Likewise.
503 * regex.c: Likewise.
504 * region-cache.c: Likewise.
505 * search.c: Likewise.
506 * syntax.c: Likewise.
507 * term.c: Likewise.
508 * textprop.c: Likewise.
509 * undo.c: Likewise.
510 * unexsol.c: Likewise.
511 * w16select.c: Likewise.
512 * w32fns.c: Likewise.
513 * w32menu.c: Likewise.
514 * window.c: Likewise.
515 * xdisp.c: Likewise.
516 * xfns.c: Likewise.
517 * xmenu.c: Likewise.
518 * xml.c: Likewise.
519 * xselect.c: Likewise.
520
2f07e6af
EZ
5212012-06-16 Eli Zaretskii <eliz@gnu.org>
522
1053a871
SM
523 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
524 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 525 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
526 row.
527 (handle_face_prop): Use chunk-relative overlay string index when
528 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
529 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
530 the rightmost. (Bug#11720)
2f07e6af 531
29b83cec
AS
5322012-06-16 Andreas Schwab <schwab@linux-m68k.org>
533
534 * category.h (CHAR_HAS_CATEGORY): Define as inline.
535 (CATEGORY_MEMBER): Enforce 1/0 value.
536 * category.c (_temp_category_set): Remove.
537
4c5501e9
EZ
5382012-06-16 Eli Zaretskii <eliz@gnu.org>
539
540 * window.c (Fdelete_other_windows_internal)
541 (Fdelete_window_internal): Don't access frame's mouse highlight
542 info of the initial frame. (Bug#11677)
543
2b570124
PE
5442012-06-14 Paul Eggert <eggert@cs.ucla.edu>
545
e93864f9
PE
546 * .gdbinit (xgetint): Fix recently-introduced paren typo.
547 Assume USE_2_TAGS_FOR_INTS.
548 (xreload): Adjust $tagmask width to match recent lisp.h change.
549
2b570124
PE
550 Simplify lisp.h in minor ways that should not affect code.
551 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
552 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
553 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
554 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
555 (INTTYPEBITS): New macro, for clarity.
556 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
557 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
558 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
559 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
560 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
561
81755f69
JB
5622012-06-13 Juanma Barranquero <lekktu@gmail.com>
563
564 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
565
16192a57
GM
5662012-06-13 Glenn Morris <rgm@gnu.org>
567
568 * s/bsd-common.h (BSD4_3):
569 * s/usg5-4-common.h (USG5_4): No longer define; unused.
570
646b5f55
AS
5712012-06-13 Andreas Schwab <schwab@linux-m68k.org>
572
573 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
574 instead of union.
575 (XLI, XIL): Define.
1053a871
SM
576 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
577 Use them.
578 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 579 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 580 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
581 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
582 * frame.c (delete_frame): Remove outdated comment.
583 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
584 USE_LISP_UNION_TYPE.
585 (Fw32_unregister_hot_key): Likewise.
586 (Fw32_toggle_lock_key): Likewise.
587 * w32menu.c (add_menu_item): Likewise.
588 (w32_menu_display_help): Use XIL instead of checking
589 USE_LISP_UNION_TYPE.
590 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
591 (init_heap): Likewise.
592 * w32term.c (w32_read_socket): Update comment.
593
1d3823c9
GM
5942012-06-13 Glenn Morris <rgm@gnu.org>
595
c62ff706
GM
596 * s/usg5-4-common.h, src/s/unixware.h:
597 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
598
1d3823c9
GM
599 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
600
bfe3e0a2
PE
6012012-06-13 Paul Eggert <eggert@cs.ucla.edu>
602
603 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
604 * alloc.c (make_number) [!defined make_number]:
605 Remove, as lisp.h always defines this now.
606 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
607 (roundup_size): Verify that it is a power of 2.
608 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
609 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
610 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
611 -DUSE_LSB_TAG=0, to override the automatically-selected default.
612 USE_LSB_TAG now is always defined to be either 0 or 1.
613 All uses changed.
614 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
615 code works fine either way, and efficiency is not a concern here,
616 as the union type is for debugging, not for production.
617 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
618 Use an inline function on all platforms when using the union type,
619 since this is simpler and 'static inline' can be used portably
620 within Emacs now.
621 (LISP_INITIALLY_ZERO): New macro.
622 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
623 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
624
45fa9c0f
GM
6252012-06-12 Glenn Morris <rgm@gnu.org>
626
b4492cba
GM
627 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
628
629 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 630
45fa9c0f
GM
631 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
632 Move BROKEN_SIGIO to configure.
633
634 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
635 Move NO_TERMIO to configure.
636
0e25d334
CY
6372012-06-12 Chong Yidong <cyd@gnu.org>
638
639 * image.c (imagemagick_load_image): Use MagickFlattenImage if
640 MagickMergeImageLayers is undefined. Use pixel pusher loop if
641 MagickExportImagePixels is undefined.
642
43682bb6
PE
6432012-06-12 Paul Eggert <eggert@cs.ucla.edu>
644
645 * image.c (imagemagick_load_image): Remove unused label.
646
a9be7d2b
GM
6472012-06-11 Glenn Morris <rgm@gnu.org>
648
649 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
650 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
651 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
652 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
653
3017f87f
SM
6542012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
655
656 * alloc.c (make_byte_code): New function.
657 (Fmake_byte_code): Use it. Don't purify here.
658 * lread.c (read1): Use it as well to avoid extra allocation.
659
1b9b4cf4
CY
6602012-06-11 Chong Yidong <cyd@gnu.org>
661
662 * image.c (imagemagick_load_image): Implement transparency.
663
95988fcf
AS
6642012-06-10 Andreas Schwab <schwab@linux-m68k.org>
665
666 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
667 account for preceding backslashes. (Bug#11663)
668
cd4eb164
CY
6692012-06-09 Chong Yidong <cyd@gnu.org>
670
671 * term.c: Support italics in capable terminals (Bug#9652).
672 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
673 (turn_on_face): Output using TS_enter_italic_mode if available.
674 Don't handle unused blinking and alt-charset cases.
675 (turn_off_face): Handle italic case; discard unused tty_blinking_p
676 and tty_alt_charset_p cases.
677 (tty_capable_p, init_tty): Support italics.
678
679 * termchar.h (struct tty_display_info): Add field for italics.
680 Remove unused blink field.
681
682 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
683 Handle slant.
684
685 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
686 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
687 tty_alt_charset_p. Add tty_italic_p.
688
ff88beb8
MA
6892012-06-09 Michael Albinus <michael.albinus@gmx.de>
690
691 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
692 dbus_type_is_basic if available.
693 (xd_extract_signed, xd_extract_unsigned): Rename from
694 extract_signed and extract_unsigned, respectively. Adapt callers.
695
44286096
CY
6962012-06-09 Chong Yidong <cyd@gnu.org>
697
1682701f
CY
698 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
699
44286096
CY
700 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
701 case (Bug#9752).
702
d86feb17
PE
7032012-06-08 Paul Eggert <eggert@cs.ucla.edu>
704
705 * xdisp.c (vmessage): Treat frame message as multibyte.
706 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
707 would generate the diagnostic "Making \302\247 buffer-local while
708 let-bound!".
709
d5c20fe8
EZ
7102012-06-08 Eli Zaretskii <eliz@gnu.org>
711
712 * dispnew.c (showing_window_margins_p): Undo last change, which
713 was done due to an inadvertent commit.
714 (adjust_frame_glyphs_for_frame_redisplay): Do call
715 showing_window_margins_p.
716
513749ee
SM
7172012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
718
719 * eval.c (Fmake_var_non_special): New primitive.
720 (syms_of_eval): Defsubr it.
721 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
722
d4a8f5c1
JB
7232012-06-08 Juanma Barranquero <lekktu@gmail.com>
724
725 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
726 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
727
8bbbc977
EZ
7282012-06-08 Eli Zaretskii <eliz@gnu.org>
729
730 * alloc.c (allocate_vectorlike): Fix last change.
731
f3372c87
DA
7322012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
733
734 Block-based vector allocation of small vectors.
735 * lisp.h (struct vectorlike_header): New field `nbytes',
736 adjust comment accordingly.
737 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
738 to denote vector blocks. Adjust users (live_vector_p,
739 mark_maybe_pointer, valid_lisp_object_p) accordingly.
740 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
741 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
742 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
743 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
744 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
745 (roundup_size): New constant.
746 (struct vector_block): New data type.
747 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 748 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
749 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
750 (sweep_vectors): New functions.
751 (allocate_vectorlike): Return `zero_vector' as the only vector of
752 0 items. Allocate new vector from block if vector size is less than
753 or equal to VBLOCK_BYTES_MAX.
754 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
755 (init_alloc_once): Add call to init_vectors.
756
4f18a4ed
SM
7572012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
758
759 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
760
86f158bc
PE
7612012-06-07 Paul Eggert <eggert@cs.ucla.edu>
762
763 * doprnt.c (doprnt): Truncate multibyte char correctly.
764 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
765 would mishandle a string argument "Xc" if X was a multibyte
766 character of length 2: it would truncate after X's first byte
767 rather than including all of X.
768
c5cfcbe0
CY
7692012-06-06 Chong Yidong <cyd@gnu.org>
770
771 * buffer.c (word_wrap): Doc fix.
772
c05cf390
PE
7732012-06-04 Paul Eggert <eggert@cs.ucla.edu>
774
775 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
776
0c3461de
GM
7772012-06-03 Glenn Morris <rgm@gnu.org>
778
779 * xdisp.c (tool-bar-style): Doc fix.
780
c71232db
UM
7812012-06-03 Ulrich Müller <ulm@gentoo.org>
782
783 * Makefile.in (PAXCTL): Define.
784 (temacs$(EXEEXT)): Disable memory randomization for the temacs
785 binary via PaX flags if the paxctl utility is available.
786 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
787 Restore PaX flags to their default. (Bug#11398)
788
383f7350
CY
7892012-06-03 Chong Yidong <cyd@gnu.org>
790
791 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
792 buffer (Bug#11226).
793
5f2c76c6
CY
7942012-06-03 Chong Yidong <cyd@gnu.org>
795
796 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
797 (note_mode_line_or_margin_highlight): If there is no help echo,
798 use mode-line-default-help-echo. Handle the case where the mouse
799 position is past the end of the mode line string.
800
801 * buffer.c (buffer_local_value_1): New function, split from
802 Fbuffer_local_value; can return Qunbound.
803 (Fbuffer_local_value): Use it.
804 (Vmode_line_format): Docstring tweaks.
805
773d47f6
PE
8062012-06-02 Paul Eggert <eggert@cs.ucla.edu>
807
808 * sysdep.c (system_process_attributes): Improve comment.
809
f2d6a3df
SM
8102012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
811
812 * keyboard.c: Export real-this-command to Elisp.
813 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
814 and DEFVAR it. Update all users.
815
63810350
PE
8162012-06-02 Paul Eggert <eggert@cs.ucla.edu>
817
7bd5c1f4
PE
818 * minibuf.c (Fassoc_string): Remove duplicate declaration.
819
63810350
PE
820 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
821 Convert pctcpu and pctmem to Lisp float properly.
822 Let the compiler fold better, as 100.0/0x8000 is exact.
823
a2821611
AS
8242012-06-02 Andreas Schwab <schwab@linux-m68k.org>
825
826 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
827 cons_block.
828
5fceba1d
PE
8292012-06-01 Paul Eggert <eggert@cs.ucla.edu>
830
831 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
832
c98ff5dd
DA
8332012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
834
835 For a 'struct window', replace some Lisp_Object fields to
836 bitfields where appropriate, remove unused fields.
837 * window.h (struct window): Remove unused 'last_mark_x' and
838 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
839 change it's type from Lisp_Object to bitfield.
840 Change type of 'force_start', 'optional_new_start',
841 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
842 fields from Lisp_Object to bitfield. Adjust users accordingly.
843
ca34e0be
PE
8442012-05-31 Paul Eggert <eggert@cs.ucla.edu>
845
846 Pacify gcc -Wdouble-precision when using Xaw.
847 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
848 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
849 Use 'float' consistently, rather than 'float' in most places
850 and 'double' in a couple of places.
851
efc00ab1 8522012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
853
854 * xdisp.c (handle_stop): Detect whether we have overlay strings
855 loaded by testing it->current.overlay_string_index to be
856 non-negative, instead of checking whether n_overlay_strings is
857 positive. (Bug#11587)
858
efc00ab1 8592012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
860
861 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
862
863 * doc.c (Fsubstitute_command_keys): Doc fix.
864
efc00ab1 8652012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
866
867 * search.c (search_buffer): Remove calls to
868 r_alloc_inhibit_buffer_relocation, as it is now called by
869 maybe_unify_char, which was the cause of relocation of buffer text
870 in bug#11519.
871
efc00ab1 8722012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
873
874 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
875 for the duration of call to load_charset, to avoid problems with
876 callers of maybe_unify_char that access buffer text through C
877 pointers.
878
879 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
880 decrement the inhibition flag, instead of just setting or
881 resetting it.
882
ba93a187
PE
8832012-05-31 Paul Eggert <eggert@cs.ucla.edu>
884
885 Remove obsolete '#define static' cruft.
886 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
887 This #undef was "temporary" in 2000; it is no longer needed
888 now that '#define static' has gone away.
889 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
890 (gray_bitmap_bits): Remove; no longer needed.
891 All uses replaced with definiens.
892 * xterm.c: Include "bitmaps/gray.xbm".
893
9e4bf381
PE
8942012-05-30 Paul Eggert <eggert@cs.ucla.edu>
895
896 Clean up __executable_start, monstartup when --enable-profiling.
897 The following changes affect the code only when profiling.
898 * dispnew.c (__executable_start): Rename from safe_bcopy.
899 Define only on platforms that need it.
900 * emacs.c: Include <sys/gmon.h> when profiling.
901 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
902 (__executable_start): Remove decl, since lisp.h does it now.
903 (safe_bcopy): Remove decl; no longer has that name.
904 (main): Coalesce #if into single bit of code, for simplicity.
905 Cast pointers to uintptr_t, since standard libraries want integers
906 and not pointers.
907 * lisp.h (__executable_start): New decl.
908
32d72c2f
GM
9092012-05-31 Glenn Morris <rgm@gnu.org>
910
911 * image.c (Fimagemagick_types): Doc fix.
912
baac5bc7
JM
9132012-05-30 Jim Meyering <meyering@redhat.com>
914
915 * callproc.c (Fcall_process_region): Include directory component
916 in mkstemp error message (Bug#11586).
917
72cb32cf
PE
9182012-05-30 Paul Eggert <eggert@cs.ucla.edu>
919
920 * alloc.c, lisp.h (make_pure_vector): Now static.
921
61b108cc
SM
9222012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
923
924 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
925 Move to byte-run.el.
926 (Fautoload): Do the hash-doc more carefully.
927 * data.c (Fdefalias): Purify definition, except for keymaps.
928 (Qdefun): Move from eval.c.
929 * lisp.h (Qdefun): Remove.
930 * lread.c (read1): Tiny simplification.
931
471fe23d
TN
9322012-05-29 Troels Nielsen <bn.troels@gmail.com>
933
934f3f58 934 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
935 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
936 Bug#9642, but explicitly check that the buffer the overlay would
937 be moved to is live and rearrange lines to make sure that errors
938 will not put the overlay in an inconsistent state.
939 (Fdelete_overlay): Cosmetics.
940
85d0efd1
EZ
9412012-05-28 Eli Zaretskii <eliz@gnu.org>
942
943 * w32term.c (my_bring_window_to_top): New function.
944 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
945 could be different from the original one.
946 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
947 (Bug#11513)
948
949 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
950 by calling BringWindowToTop.
951
952 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
953 (WM_EMACS_END): Increase by one.
954
da92a98c
PE
9552012-05-28 Paul Eggert <eggert@cs.ucla.edu>
956
957 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
958 This avoids undefined behavior that might cause the eassert
959 to not catch an out-of-range value.
960
74d1f848
JB
9612012-05-28 Juanma Barranquero <lekktu@gmail.com>
962
963 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
964 Update dependencies.
965
9e1a06fc
EZ
9662012-05-27 Eli Zaretskii <eliz@gnu.org>
967
968 * bidi.c (bidi_mirror_char): Fix last change.
969
f3dd7312
AS
9702012-05-27 Andreas Schwab <schwab@linux-m68k.org>
971
972 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
973 when referring to sectname field in printf format.
974
81899c91
PE
9752012-05-27 Paul Eggert <eggert@cs.ucla.edu>
976
57b81a9f
PE
977 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
978 Only r_alloc_inhibit_buffer_relocation needed to be added;
979 the others were already declared.
980
81899c91
PE
981 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
982 before checking whether it's out of range. Put the check inside
983 eassert. See
984 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
985
33017faf 9862012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
987
988 * callproc.c (Fcall_process): Restore a line that was accidentally
989 commented out in the 2011-02-13 change (bug#11547).
990
33017faf 9912012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
992
993 * lisp.h [REL_ALLOC]: Add prototypes for external functions
994 defined on ralloc.c.
995
996 * buffer.c [REL_ALLOC]: Remove prototypes of
997 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
998 they are now on lisp.h.
999
1000 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1001
1002 * search.c (search_buffer): Use it to inhibit relocation of buffer
1003 text while re_search_2 is doing its job, because re_search_2 is
1004 passed C pointers to buffer text. (Bug#11519)
1005
23415acf
EZ
1006 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1007 Update value to 24.
1008
44e27368
EZ
1009 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1010 state after an additional call to move_it_in_display_line_to, keep
1011 the values of it->max_ascent and it->max_descent found for the
1012 entire line.
1013 (pos_visible_p): Revert the comparison against bottom_y to what it
1014 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1015 (Bug#11464)
1016
c1892f11
PE
10172012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1018
1019 Fix coding-related core dumps with gcc -ftrapv.
1020 The code was computing A - B, where A and B are pointers, and B is
1021 random garbage. This can lead to core dumps on platforms that
1022 have special pointer registers, and it also leads to core dumps on
1023 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1024 A - B only when B is initialized properly.
1025 * coding.c (coding_set_source, coding_set_destination): Return void.
1026 (coding_change_source, coding_change_destinations): New functions,
1027 with the old behaviors of coding_set_source and coding_set_destination.
1028 All callers that need an offset changed to use these new functions.
1029
eb7afdad
GM
10302012-05-26 Glenn Morris <rgm@gnu.org>
1031
1032 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1033
f12fdf02
EZ
10342012-05-26 Eli Zaretskii <eliz@gnu.org>
1035
53a63be6 1036 Extend mouse support on W32 text-mode console.
61b108cc
SM
1037 * xdisp.c (draw_row_with_mouse_face):
1038 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1039
eb3f6f01 1040 * w32console.c: Include window.h.
61b108cc
SM
1041 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1042 New functions.
eb3f6f01
EZ
1043 (initialize_w32_display): Initialize mouse-highlight data.
1044
53a63be6
EZ
1045 * w32inevt.c: Include termchar.h and window.h.
1046 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1047 moves, call note_mouse_highlight. If help_echo changed, call
1048 gen_help_event to produce help-echo message in the echo area.
1049 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1050 highlight info.
1051
4cfd81f6
PE
10522012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1053
1054 * lread.c (read1): Simplify slightly to avoid an overflow warning
1055 with GCC 4.7.0 on x86-64.
1056
4446092a
EZ
10572012-05-26 Eli Zaretskii <eliz@gnu.org>
1058
1059 * bidi.c (bidi_mirror_char): Revert last change: an int is
1060 definitely wide enough here.
1061
42b2a986 10622012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1063
42b2a986 1064 Fix integer width and related bugs (Bug#9874).
eb106a49 1065 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1066 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1067 (string_bytes, check_sblock, allocate_string_data):
1068 (compact_small_strings, Fmake_bool_vector, make_string)
1069 (make_unibyte_string, make_multibyte_string)
1070 (make_string_from_bytes, make_specified_string)
1071 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1072 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1073 (mark_vectorlike):
1074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1075 (allocate_pseudovector):
1076 Use int, not EMACS_INT, where int is wide enough.
1077 (inhibit_garbage_collection, Fgarbage_collect):
1078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1079 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1080 int might not be wide enough.
1081 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1082 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1083 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1084 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1085 (bidi_level_of_next_char, bidi_move_to_visually_next):
1086 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1087 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1088 (Fkill_buffer, Fset_buffer_major_mode)
1089 (advance_to_char_boundary, Fbuffer_swap_text)
1090 (Fset_buffer_multibyte, overlays_at, overlays_in)
1091 (overlay_touches_p, struct sortvec, record_overlay_string)
1092 (overlay_strings, recenter_overlay_lists)
1093 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1094 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1095 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1096 (Foverlay_recenter, last_overlay_modification_hooks_used)
1097 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1098 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1099 (validate_region): Omit unnecessary test for b <= e,
1100 since that's guaranteed by the previous test.
d311d28c
PE
1101 (adjust_overlays_for_delete): Avoid pos + length overflow.
1102 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1103 (report_overlay_modification):
1104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1105 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1106 Omit pointer cast, which isn't needed anyway, and doesn't work
1107 after the EMACS_INT -> ptrdiff_t change.
02481186 1108 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1109 * buffer.h: Adjust decls to match defn changes elsewhere.
1110 (struct buffer_text, struct buffer):
1111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1112 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1113 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1114 not int, to avoid needless 32-bit limit on 64-bit hosts.
1115 (exec_byte_code): Use tighter memory-full test, one that checks
1116 for alloca overflow. Don't compute the address of the object just
1117 before an array, as that's not portable. Use EMACS_INT, not
1118 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1119 * callint.c (Fcall_interactively):
1120 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1121 * callproc.c (call_process_kill, Fcall_process):
1122 Don't assume pid_t fits into an Emacs fixnum.
1123 (call_process_cleanup, Fcall_process, child_setup):
1124 Don't assume pid_t fits into int.
1125 (call_process_cleanup, Fcall_process, delete_temp_file)
1126 (Fcall_process_region):
1127 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1128 (Fcall_process): Simplify handling of volatile integers.
1129 Use int, not EMACS_INT, where int will do.
1130 * casefiddle.c (casify_object, casify_region, operate_on_word)
1131 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1133 (casify_object): Avoid integer overflow when overallocating buffer.
1134 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1135 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1136 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1137 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1138 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1139 integers are now checked earlier. All uses replaced with XINT.
1140 (ccl_driver):
1141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1142 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1143 (ccl_driver, Fregister_code_conversion_map):
1144 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1145 (resolve_symbol_ccl_program): Check that vector header is in range.
1146 Always copy the vector, so that we can check its contents reliably
1147 now rather than having to recheck each instruction as it's being
1148 executed. Check that vector words fit in 'int'.
1149 (ccl_get_compiled_code, Fregister_ccl_program)
1150 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1151 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1152 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1153 contents are in range.
1154 (Fccl_execute_on_string): Check that status is in range.
1155 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1156 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1157 Accept and return EMACS_INT, not int, because callers can pass values
1158 out of 'int' range.
1159 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1160 (multibyte_chars_in_text, parse_str_as_multibyte)
1161 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1162 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1163 (string_escape_byte8, Fget_byte):
1164 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1165 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1166 avoid mishandling large integers.
1167 * character.h: Adjust decls to match defn changes elsewhere.
1168 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1169 (Ffind_charset_region):
1170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1171 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1172 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1173 Don't assume fixnum fits in int.
d311d28c
PE
1174 (load_charset_map_from_vector, Fmap_charset_chars):
1175 Remove now-unnecessary CHECK_NATNUMs.
1176 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1177 Don't rely on undefined behavior with signed left shift overflow.
1178 Don't assume unsigned int fits into fixnum, or that fixnum fits
1179 into unsigned int. Don't require max_code to be a valid fixnum;
1180 that's not true for gb10830 4-byte on a 32-bit host. Allow
1181 invalid_code to be a cons, for the same reason. Require code_offset
1182 to be a character. Avoid int overflow if max_char is close
1183 to INT_MAX.
1184 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1185 this is intended anyway and avoids some undefined behavior.
1186 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1187 INDEX_TO_CODE_POINT, as that's what it expects.
1188 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1189 * charset.h (DECODE_CHAR): Return int, not unsigned;
1190 this is what was intended anyway, and it avoids undefined behavior.
1191 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1192 integer-overflow issues.
1193 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1194 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1195 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1196 * chartab.c (Fmake_char_table, Fset_char_table_range)
1197 (uniprop_get_decoder, uniprop_get_encoder):
1198 Don't assume fixnum fits in int.
1199 * cmds.c (move_point): New function, that does the gist of
1200 Fforward_char and Fbackward_char, but does so while checking
1201 for integer overflow more accurately.
c96e5d6a 1202 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1203 (Fforward_line, Fend_of_line, internal_self_insert)
1204 (internal_self_insert):
1205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1206 Fix a FIXME, by checking for integer overflow when calculating
1207 target_clm and actual_clm.
1208 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1209 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1210 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1211 (coding_alloc_by_making_gap, alloc_destination)
1212 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1213 (encode_coding_utf_16, detect_coding_emacs_mule)
1214 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1215 (detect_coding_iso_2022, decode_coding_iso_2022)
1216 (encode_invocation_designation, encode_designation_at_bol)
1217 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1218 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1219 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1220 (encode_coding_ccl, encode_coding_raw_text)
1221 (detect_coding_charset, decode_coding_charset)
1222 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1223 (produce_composition, produce_charset, produce_annotation)
1224 (decode_coding, handle_composition_annotation)
1225 (handle_charset_annotation, consume_chars, decode_coding_gap)
1226 (decode_coding_object, encode_coding_object, detect_coding_system)
1227 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1228 (code_convert_region, code_convert_string)
8f50130c
PE
1229 (Fdefine_coding_system_internal)
1230 (coding_set_source, coding_set_destination):
d311d28c
PE
1231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1232 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1233 (Fdefine_coding_system_internal):
1234 Don't assume fixnums fit in int.
1235 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1236 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1237 (Funencodable_char_position, Fcheck_coding_systems_region)
1238 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1239 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1240 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1241 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1242 Don't access memory outside of the args array.
d311d28c 1243 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1244 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1245 result of ENCODE_CHAR.
d311d28c
PE
1246 * coding.h: Adjust decls to match defn changes elsewhere.
1247 (struct coding_system):
1248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1249 * composite.c (get_composition_id, find_composition)
1250 (run_composition_function, update_compositions)
1251 (compose_text, composition_gstring_put_cache)
1252 (composition_gstring_p, composition_gstring_width)
1253 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1254 (composition_compute_stop_pos, composition_reseat_it)
1255 (composition_update_it, struct position_record)
1256 (find_automatic_composition, composition_adjust_point)
1257 (Fcomposition_get_gstring, Ffind_composition_internal):
1258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1259 (update_compositions):
1260 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1261 * composite.h: Adjust decls to match defn changes elsewhere.
1262 (struct composition):
1263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1264 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1265 Do not attempt to compute the address of the object just before a
1266 buffer; this is not portable.
1267 (Faref, Faset):
1268 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1269 (Faset): Use int, not EMACS_INT, where int is wide enough.
1270 (Fstring_to_number): Don't assume fixnums fit in int.
1271 (Frem): Don't assume arg is nonnegative.
1272 * dbusbind.c (xd_append_arg): Check for integers out of range.
1273 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1274 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1275 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1276 (xd_get_connection_references): Return ptrdiff_t, not int.
1277 All uses changed.
1278 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1279 (xd_read_message_1):
1280 Use int, not unsigned, where the dbus API uses int.
1281 (Fdbus_message_internal): Don't overflow mtype.
1282 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1283 * dired.c (directory_files_internal, file_name_completion, scmp)
1284 (file_name_completion_stat):
1285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1286 (file_name_completion): Don't overflow matchcount.
1287 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1288 * dispextern.h: Adjust decls to match defn changes elsewhere.
1289 (struct text_pos, struct glyph, struct bidi_saved_info)
1290 (struct bidi_string_data, struct bidi_it, struct composition_it)
1291 (struct it):
1292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1293 (struct display_pos, struct composition_it, struct it):
1294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1295 * dispnew.c (increment_matrix_positions)
1296 (increment_row_positions, mode_line_string)
1297 (marginal_area_string):
1298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1299 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1301 (duration_to_sec_usec): New function, to check for overflow better.
1302 (Fsleep_for, sit_for): Use it.
1303 * doc.c (get_doc_string, store_function_docstring):
1304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1305 (get_doc_string, Fsnarf_documentation):
1306 Use int, not EMACS_INT, where int is wide enough.
1307 (get_doc_string):
1308 Use SAFE_ALLOCA, not alloca.
1309 Check for overflow when converting EMACS_INT to off_t.
1310 * doprnt.c (doprnt):
1311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1312 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1313 Don't assume uid_t fits into fixnum.
1314 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1315 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1316 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1317 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1318 (general_insert_function)
1319 (Finsert_char, make_buffer_string, make_buffer_string_both)
1320 (update_buffer_properties, Fbuffer_substring)
1321 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1322 (Fsubst_char_in_region, check_translation)
1323 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1324 (transpose_markers, Ftranspose_regions):
1325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1326 (clip_to_bounds): Move to lisp.h as an inline function).
1327 (Fconstrain_to_field): Don't assume integers are nonnegative.
1328 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1329 (Fsubst_char_in_region, Fsave_restriction):
1330 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1331 (Femacs_pid): Don't assume pid_t fits into fixnum.
1332 (lo_time): Use int, not EMACS_INT, when int suffices.
1333 (lisp_time_argument): Check for usec out of range.
1334 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1335 (Fuser_login_name, Fuser_full_name): Signal an error
1336 if a uid argument is out of range, rather than relying on
1337 undefined behavior.
c8d5c857
PE
1338 (Fformat_time_string): Remove now-unnecessary check.
1339 lisp_time_argument checks for out-of-range usec now.
243e0530 1340 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1341 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1342 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1343 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1344 (init_cmdargs, Fdump_emacs):
1345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1346 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1347 the bottom (typically) 32 bits of the fixnum.
1348 * eval.c (specpdl_size, call_debugger):
1349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1350 (when_entered_debugger, Fbacktrace_debug):
1351 Don't assume fixnum can fit in int.
1352 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1353 the object just before a buffer; this is not portable.
1354 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1355 (grow_specpdl, unbind_to):
1356 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1357 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1358 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1359 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1360 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1361 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1363 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1364 (a_write, e_write):
1365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1366 (Fcopy_file, non_regular_nbytes, read_non_regular)
1367 (Finsert_file_contents):
1368 Use int, not EMACS_INT, where int is wide enough.
1369 (READ_BUF_SIZE): Verify that it fits in int.
1370 (Finsert_file_contents): Check that counts are in proper range,
1371 rather than assuming fixnums fit into ptrdiff_t etc.
1372 Don't assume fixnums fit into int.
125b3835 1373 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1374 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1375 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1376 (string_char_to_byte, string_byte_to_char)
1377 (string_make_multibyte, string_to_multibyte)
1378 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1379 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1380 (substring_both, Fdelete, internal_equal, Ffillarray)
1381 (Fclear_string, mapcar1)
1382 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1383 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1384 (larger_vector, make_hash_table, maybe_resize_hash_table)
1385 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1386 (Fmaphash, secure_hash):
1387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1388 (concat): Check for string index and length overflow.
1389 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1390 (Frequire):
1391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1392 (larger_vector): New API (vec, incr_min, size_max) replaces old
1393 one (vec, new_size, init). This catches size overflow.
1394 INIT was removed because it was always Qnil.
1395 All callers changed.
1396 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1397 the upper bound on a hash table index size.
1398 (make_hash_table, maybe_resize_hash_table): Use it.
1399 (secure_hash): Computer start_byte and end_byte only after
1400 they're known to be in ptrdiff_t range.
1401 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1402 (Ffont_get_glyphs, Ffont_at):
1403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1404 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1405 (Flist_fonts, Fopen_font):
1406 Don't assume fixnum can fit in int.
1407 (check_gstring): Don't assume index can fit in int.
1408 (font_match_p): Check that fixnum is a character, not a nonnegative
1409 fixnum, since the later code needs to stuff it into an int.
1410 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1411 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1412 conversion overflow issues.
1413 (Fopen_font): Check for integer out of range.
1414 (Ffont_get_glyphs): Don't assume index can fit in int.
1415 * font.h: Adjust decls to match defn changes elsewhere.
1416 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1417 integer overflow.
1418 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1419 printmax_t, where ptrdiff_t is wide enough.
1420 (Finternal_char_font):
1421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1422 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1423 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1424 (Fset_frame_position, x_set_frame_parameters)
1425 (x_set_line_spacing, x_set_border_width)
1426 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1427 Check that fixnums are in proper range for system types.
1428 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1430 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1431 Use SAFE_ALLOCA_LISP, not alloca.
1432 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1433 intptr_t is wide enough.
1434 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1435 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1436 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1437 Check for fixnum out of range.
1438 * ftfont.c (ftfont_list): Don't assume index fits in int.
1439 Check that fixnums are in proper range for system types.
1440 (ftfont_shape_by_flt):
1441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1442 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1444 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1445 Check that fixnums are in proper range for system types.
1446 * gnutls.h: Adjust decls to match defn changes elsewhere.
1447 * gtkutil.c (xg_dialog_run):
1448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1449 (update_frame_tool_bar):
1450 Check that fixnums are in proper range for system types.
1451 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1452 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1453 * indent.c (last_known_column, last_known_column_point):
1454 (current_column_bol_cache):
1455 (skip_invisible, current_column, check_display_width):
1456 (check_display_width, scan_for_column, current_column_1)
1457 (Findent_to, Fcurrent_indentation, position_indentation)
1458 (indented_beyond_p, Fmove_to_column, compute_motion):
1459 (Fcompute_motion, Fvertical_motion):
1460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1461 (last_known_column_modified): Use EMACS_INT, not int.
1462 (check_display_width):
1463 (Fcompute_motion):
1464 Check that fixnums and floats are in proper range for system types.
1465 (compute_motion): Don't assume index or fixnum fits in int.
1466 (compute_motion, Fcompute_motion):
1467 Use int, not EMACS_INT, when it is wide enough.
1468 (vmotion): Omit local var start_hpos that is always 0; that way
1469 we don't need to worry about overflow in expressions involving it.
1470 * indent.h: Adjust decls to match defn changes elsewhere.
1471 (struct position):
1472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1473 Use int, not EMACS_INT, where int is wide enough.
1474 Remove unused members ovstring_chars_done and tab_offset;
1475 all uses removed.
1476 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1477 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1478 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1479 (make_gap, copy_text, insert, insert_and_inherit)
1480 (insert_before_markers, insert_before_markers_and_inherit)
1481 (insert_1, count_combining_before, count_combining_after)
1482 (insert_1_both, insert_from_string)
1483 (insert_from_string_before_markers, insert_from_string_1)
1484 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1485 (adjust_after_replace, adjust_after_insert, replace_range)
1486 (replace_range_2, del_range, del_range_1, del_range_byte)
1487 (del_range_both, del_range_2, modify_region)
1488 (prepare_to_modify_buffer, signal_before_change)
1489 (signal_after_change, Fcombine_after_change_execute):
1490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1491 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1492 (balance_an_interval, split_interval_right, split_interval_left)
1493 (find_interval, next_interval, update_interval)
1494 (adjust_intervals_for_insertion, delete_node, delete_interval)
1495 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1496 (static_offset_intervals, offset_intervals)
1497 (merge_interval_right, merge_interval_left, make_new_interval)
1498 (graft_intervals_into_buffer, temp_set_point_both)
1499 (temp_set_point, set_point, adjust_for_invis_intang)
1500 (set_point_both, move_if_not_intangible, get_property_and_range)
1501 (get_local_map, copy_intervals, copy_intervals_to_string)
1502 (compare_string_intervals, set_intervals_multibyte_1):
1503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1504 * intervals.h: Adjust decls to match defn changes elsewhere.
1505 (struct interval):
1506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1507 * keyboard.c (this_command_key_count, this_single_command_key_start)
1508 (before_command_key_count, before_command_echo_length, echo_now)
1509 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1510 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1511 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1512 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1514 (last_non_minibuf_size, last_point_position, echo_truncate)
1515 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1516 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1517 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1518 (stuff_buffered_input):
1519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1520 (last_auto_save, command_loop_1, read_char):
1521 Use EMACS_INT, not int, to avoid integer overflow.
1522 (record_char): Avoid overflow in total_keys computation.
1523 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1524 * keyboard.h: Adjust decls to match defn changes elsewhere.
1525 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1526 (Fkey_description, Fdescribe_vector, Flookup_key):
1527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1528 (click_position): New function, to check that positions are in range.
1529 (Fcurrent_active_maps):
1530 (describe_command):
1531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1532 (Faccessible_keymaps, Fkey_description):
1533 (preferred_sequence_p):
1534 Don't assume fixnum can fit into int.
1535 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1536 Check for integer overflow in size calculations.
1537 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1538 avoid mishandling large integers.
1539 * lisp.h: Adjust decls to match defn changes elsewhere.
1540 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1541 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1542 (struct Lisp_Marker):
1543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1544 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1545 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1546 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1547 All callers changed.
1548 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1549 Assume the arg has valid form, since it always does.
1550 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1551 unsigned integer system type.
1552 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1553 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1555 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1556 (duration_to_sec_usec): New decl.
1557 * lread.c (read_from_string_index, read_from_string_index_byte)
1558 (read_from_string_limit, readchar, unreadchar, openp)
1559 (read_internal_start, read1, oblookup):
1560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1561 (Fload, readevalloop, Feval_buffer, Feval_region):
1562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1563 (openp): Check for out-of-range argument to 'access'.
1564 (read1): Use int, not EMACS_INT, where int is wide enough.
1565 Don't assume fixnum fits into int.
6efdadfd 1566 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1567 (read_filtered_event): Use duration_to_sec_usec
1568 to do proper overflow checking on durations.
d311d28c
PE
1569 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1570 in size calculation.
1571 (Fexecute_kbd_macro):
1572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1573 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1574 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1575 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1576 (set_marker_both, set_marker_restricted_both, marker_position)
1577 (marker_byte_position, Fbuffer_has_markers_at):
1578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1579 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1580 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1581 It now merely ensures that the menu is large enough, without
1582 necessarily growing it, as this avoids some integer overflow issues.
1583 All callers changed.
1584 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1585 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1586 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1587 Use SAFE_ALLOCA_LISP, not alloca.
1588 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1589 to EMACS_INT. Check that fixnums are in proper range for system types.
1590 * minibuf.c (minibuf_prompt_width, string_to_object)
1591 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1592 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1594 (get_minibuffer, read_minibuf_unwind):
1595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1596 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1597 this simplifies overflow checking. All callers changed.
1598 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1599 (Ftest_completion):
1600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1601 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1602 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1603 Check that fixnums are in proper range for system types.
1604 (Fx_create_frame, Fx_show_tip):
1605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1606 * nsfont.m (ns_findfonts, nsfont_list_family):
1607 Don't assume fixnum fits in long.
1608 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1610 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1611 wide enough.
17fdb222 1612 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1614 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1615 (PRINTDECLARE, PRINTPREPARE):
1616 (strout, print_string):
1617 (print, print_preprocess, print_check_string_charset_prop)
1618 (print_object):
1619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1620 (PRINTDECLARE):
1621 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1623 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1624 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1625 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1626 (print_error_message): Use SAFE_ALLOCA, not alloca.
1627 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1628 (print_depth, new_backquote_output, print_number_index):
1629 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1630 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1631 (Fset_process_window_size, Fformat_network_address)
1632 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1633 (sigchld_handler):
d311d28c 1634 Check that fixnums are in proper range for system types.
d44287d4 1635 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1636 Check for process-ids out of pid_t range rather than relying on
1637 undefined behavior.
e4d81efc 1638 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1639 (Fformat_network_address, read_process_output, send_process)
1640 (Fprocess_send_region, status_notify):
1641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1642 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1643 (wait_reading_process_output, read_process_output, exec_sentinel):
1644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1645 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1646 (Faccept_process_output): Use duration_to_sec_usec to do proper
1647 overflow checking on durations.
dde14581
PE
1648 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1649 Don't assume pid_t fits in int.
02481186
PE
1650 * process.h (struct Lisp_Process): Members tick and update_tick
1651 are now of type EMACS_INT, not int.
b62b53e8
PE
1652 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1653 configured --with-wide-int.
d311d28c
PE
1654 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1655 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1656 * search.c (looking_at_1, string_match_1):
1657 (fast_string_match, fast_c_string_match_ignore_case)
1658 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1659 (scan_newline, find_before_next_newline, search_command)
1660 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1661 (set_search_regs, wordify):
1662 (Freplace_match):
1663 (Fmatch_data):
1664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1665 (string_match_1, search_buffer, set_search_regs):
1666 (Fmatch_data):
1667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1668 (wordify): Check for overflow in size calculation.
1669 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1670 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1671 Check that fixnums are in proper range for system types.
1672 * sound.c (struct sound_device)
1673 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1675 (Fplay_sound_internal):
1676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1677 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1678 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1679 (Fparse_partial_sexp):
1680 Don't assume fixnums can fit in int.
1681 (struct lisp_parse_state, find_start_pos, find_start_value)
1682 (find_start_value_byte, find_start_begv)
1683 (update_syntax_table, char_quoted, dec_bytepos)
1684 (find_defun_start, prev_char_comend_first, back_comment):
1685 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1686 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1688 (Finternal_describe_syntax_value): Check that match_lisp is a
1689 character, not an integer, since the code stuffs it into int.
1690 (scan_words, scan_sexps_forward):
1691 Check that fixnums are in proper range for system types.
1692 (Fforward_word):
1693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1694 (scan_sexps_forward):
1695 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1696 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1697 * syntax.h: Adjust decls to match defn changes elsewhere.
1698 (struct gl_state_s):
1699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1700 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1701 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1702 * sysdep.c (wait_for_termination_1, wait_for_termination)
1703 (interruptible_wait_for_termination, mkdir):
1704 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1705 (emacs_read, emacs_write):
1706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1707 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1708 and double all fit in int.
d311d28c
PE
1709 * term.c (set_tty_color_mode):
1710 Check that fixnums are in proper range for system types.
1711 * termhooks.h (struct input_event):
1712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1713 * textprop.c (validate_interval_range, interval_of)
1714 (Fadd_text_properties, set_text_properties_1)
1715 (Fremove_text_properties, Fremove_list_of_text_properties)
1716 (Ftext_property_any, Ftext_property_not_all)
1717 (copy_text_properties, text_property_list, extend_property_ranges)
1718 (verify_interval_modification):
1719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1720 (Fnext_single_char_property_change)
1721 (Fprevious_single_char_property_change):
1722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1723 (copy_text_properties):
1724 Check for integer overflow in index calculation.
d311d28c
PE
1725 * undo.c (last_boundary_position, record_point, record_insert)
1726 (record_delete, record_marker_adjustment, record_change)
1727 (record_property_change):
1728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1729 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1731 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1732 (Fx_hide_tip, Fx_file_dialog):
1733 * w32menu.c (set_frame_menubar):
1734 Use ptrdiff_t, not int, for consistency with rest of code.
1735 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1736 (select_window, Fdelete_other_windows_internal)
1737 (window_scroll_pixel_based, window_scroll_line_based)
1738 (Frecenter, Fset_window_configuration):
1739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1740 (Fset_window_hscroll, run_window_configuration_change_hook)
1741 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1742 (Fscroll_other_window, Frecenter):
d311d28c
PE
1743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1744 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1745 Don't assume fixnum fits in int.
1746 (Fset_window_scroll_bars):
1747 Check that fixnums are in proper range for system types.
1748 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1749 (string_pos, c_string_pos, number_of_chars, init_iterator)
1750 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1751 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1752 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1753 (face_before_or_after_it_pos, handle_invisible_prop)
1754 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1755 (display_prop_intangible_p, string_buffer_position_lim)
1756 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1757 (get_overlay_strings_1, get_overlay_strings)
1758 (iterate_out_of_display_property, forward_to_next_line_start)
1759 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1760 (get_next_display_element, set_iterator_to_next)
1761 (get_visually_first_element, compute_stop_pos_backwards)
1762 (handle_stop_backwards, next_element_from_buffer)
1763 (move_it_in_display_line_to, move_it_in_display_line)
1764 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1765 (add_to_log, message_dolog, message_log_check_duplicate)
1766 (message2, message2_nolog, message3, message3_nolog
1767 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1768 (current_message_1, truncate_echo_area, truncate_message_1)
1769 (set_message, set_message_1, store_mode_line_noprop)
1770 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1771 (text_outside_line_unchanged_p, check_point_in_composition)
1772 (reconsider_clip_changes)
1773 (redisplay_internal, set_cursor_from_row, try_scrolling)
1774 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1775 (redisplay_window, find_last_unchanged_at_beg_row)
1776 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1777 (trailing_whitespace_p, find_row_edges, display_line)
1778 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1779 (display_mode_element, store_mode_line_string)
1780 (pint2str, pint2hrstr, decode_mode_spec)
1781 (display_count_lines, display_string, draw_glyphs)
1782 (x_produce_glyphs, x_insert_glyphs)
1783 (rows_from_pos_range, mouse_face_from_buffer_pos)
1784 (fast_find_string_pos, mouse_face_from_string_pos)
1785 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1787 (safe_call, init_from_display_pos, handle_fontified_prop)
1788 (handle_single_display_spec, load_overlay_strings)
1789 (with_echo_area_buffer, setup_echo_area_for_printing)
1790 (display_echo_area, echo_area_display)
1791 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1792 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1793 (redisplay_window, dump_glyph_row, display_mode_line)
1794 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1795 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1797 (handle_single_display_spec, build_desired_tool_bar_string)
1798 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1799 (get_specified_cursor_type):
1800 Check that fixnums are in proper range for system types.
1801 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1802 (Flookup_image_map):
1803 Don't assume fixnums fit in int.
1804 (compare_overlay_entries):
1805 Avoid mishandling comparisons due to subtraction overflow.
1806 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1807 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1808 (handle_tool_bar_click):
1809 Use int, not unsigned, since we prefer signed and the signedness
1810 doesn't matter here.
1811 (get_next_display_element, next_element_from_display_vector):
1812 Use int, not EMACS_INT, when int is wide enough.
1813 (start_hourglass): Use duration_to_sec_usec to do proper
1814 overflow checking on durations.
1815 * xfaces.c (Fbitmap_spec_p):
1816 Check that fixnums are in proper range for system types.
1817 (compare_fonts_by_sort_order):
1818 Avoid mishandling comparisons due to subtraction overflow.
1819 (Fx_family_fonts, realize_basic_faces):
1820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1821 (Fx_family_fonts):
1822 Don't assume fixnum fits in int.
1823 Use SAFE_ALLOCA_LISP, not alloca.
1824 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1825 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1826 (face_at_buffer_position, face_for_overlay_string)
1827 (face_at_string_position):
1828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1829 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1830 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1831 (Fx_show_tip):
1832 Check that fixnums are in proper range for system types.
1833 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1834 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1836 (Fx_change_window_property): Don't assume fixnums fit in int.
1837 * xfont.c (xfont_chars_supported):
1838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1839 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1840 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1842 * xml.c (parse_region):
1843 * xrdb.c (magic_file_p):
1844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1845 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1846 (x_get_local_selection, x_reply_selection_request)
1847 (x_handle_selection_request, wait_for_property_change):
1848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1849 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1850 short is wide enough.
1851 (x_send_client_event): Don't assume fixnum fits in int.
1852 * xterm.c (x_x_to_emacs_modifiers):
1853 Don't assume EMACS_INT overflows nicely into int.
1854 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1855 may come from Lisp.
1856 (handle_one_xevent): NATNUMP can eval its arg twice.
1857 (x_connection_closed):
1858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1859 * xterm.h: Adjust decls to match defn changes elsewhere.
1860 (struct scroll_bar): Use struct vectorlike_header
1861 rather than rolling our own approximation.
1862 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1863
c6574eb5
GM
18642012-05-25 Glenn Morris <rgm@gnu.org>
1865
1866 * lisp.mk (lisp): Update for more files being compiled now.
1867
e8d32c7e
SM
18682012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1869
48def666
SM
1870 * lread.c: Remove `read_pure' which makes no difference.
1871 (read_pure): Remove var.
1872 (unreadpure): Remove function.
1873 (readevalloop): Don't call read_list with -1 flag.
1874 (read1, read_vector): Don't test read_pure any more.
1875 (read_list): Simplify.
1876
e8d32c7e
SM
1877 * fileio.c, character.h: Minor style tweaks.
1878
4b2addb7
DA
18792012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1880
1881 * window.h (clip_changed): Remove useless declaration.
1882
584461b2
JB
18832012-05-22 Juanma Barranquero <lekktu@gmail.com>
1884
1885 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1886 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1887
34374650
PE
18882012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 Remove src/m/*.
1891 This directory predates autoconf and is no longer needed nowadays.
1892 Move its few remaining bits of functionality to where they're needed.
1893 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1894 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1895 * m/template.h: Remove.
1896 * Makefile.in (M_FILE): Remove. All uses removed.
1897 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1898 * lisp.h (USE_LSB_TAG):
1899 * mem-limits.h (EXCEEDS_LISP_PTR):
1900 Use VAL_MAX, not VALBITS, in #if.
1901 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1902 (EMACS_UINT): Define unconditionally now.
1903 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1904 (BITS_PER_EMACS_INT): New constants, replacing
1905 what used to be in config.h, but not useful in #if.
1906 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1907 define them any more.
1908 (VAL_MAX): New macro.
1909 (VALMASK): Use it.
1910 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1911 BITS_PER_EMACS_INT, in #if.
1912 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1913 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1914 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1915 * s/ms-w32.h (DATA_START):
1916 Move here from removed file m/intel386.h.
1917 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1918 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1919
261cb4bb
PE
19202012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1921
1922 Assume C89 or later.
1923 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1924 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1925 (xrealloc):
1926 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1927 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1928 * textprop.c, tparam.c (NULL): Remove.
1929 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1930 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1931 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1932 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1933 * xterm.c (input_signal_count): Assume volatile works.
1934
ff23cd9f
KB
19352012-05-21 Ken Brown <kbrown@cornell.edu>
1936
1937 * xgselect.c (xg_select): Fix first argument in call to 'select'
1938 (bug#11508).
1939
1b170bc6
KB
19402012-05-20 Ken Brown <kbrown@cornell.edu>
1941
1942 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1943 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1944
b2f4d39f
KB
19452012-05-19 Ken Brown <kbrown@cornell.edu>
1946
1947 * xfns.c (x_in_use): Remove `static' qualifier.
1948 * xterm.h (x_in_use): Declare.
1949 * xgselect.c: Include xterm.h.
1950 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1951 and `display_arg' (bug#9754).
1952
003fdae2
PE
19532012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1954
9232a6d9
PE
1955 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1956
003fdae2
PE
1957 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1958 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1959
784b56e2
EZ
19602012-05-18 Eli Zaretskii <eliz@gnu.org>
1961
1962 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1963
1964 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1965 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1966
1967 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1968 reference to image_cache->refcount.
1969 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1970
a0a79cde
JL
19712012-05-17 Juri Linkov <juri@jurta.org>
1972
1973 * search.c (Fword_search_regexp, Fword_search_backward)
1974 (Fword_search_forward, Fword_search_backward_lax)
1975 (Fword_search_forward_lax): Move functions to isearch.el
1976 (bug#10145, bug#11381).
1977
b0572523
PE
19782012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1979
1980 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1981
9660f5fc
SM
19822012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1983
1984 * lread.c (init_obarray): Declare Qt and Qnil as special.
1985
4374de83
GM
19862012-05-14 Glenn Morris <rgm@gnu.org>
1987
1988 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1989 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1990
dc44c39a
PE
19912012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1992
078c97cb
PE
1993 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1994
dc44c39a
PE
1995 * unexaix.c: Port to more-recent AIX compilers.
1996 (report_error, report_error_1, make_hdr, copy_sym)
1997 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1998 Make arguments const char *, not char *, to avoid violations of C
1999 standard and to fix some AIX warnings reported by Gilles Pion.
2000
e18afed7 20012012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2002
2003 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2004 already have overlays loaded.
2005 (handle_single_display_spec): Before returning without displaying
2006 fringe bitmap, synchronize the bidi iterator with the main display
2007 iterator, by calling iterate_out_of_display_property.
2008 (iterate_out_of_display_property): Detect buffer iteration by
2009 testing that it->string is a Lisp string.
2010 (get_next_display_element): When the current object is exhausted,
2011 and there's something on it->stack, call set_iterator_to_next to
2012 proceed with what's on the stack, instead of returning zero.
2013 (set_iterator_to_next): If called at the end of a Lisp string,
2014 proceed to consider_string_end without incrementing string
2015 position. Don't increment display vector index past the end of
2016 the display vector. (Bug#11417)
c8fb9dc6
EZ
2017 (pos_visible_p): Don't report a position visible when move_it_to
2018 stopped at the last line of window, which happens to be scanned
2019 backwards by the bidi iteration. (Bug#11464)
ac268e67 2020
e18afed7 20212012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2022
2023 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2024 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2025 are on a TTY, and thus unable to display on the fringes.
2026 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2027 so we need to signal to the caller that this is a "replacing"
2028 display spec. This fixes display when the spec is invalid or we
2029 are on a TTY.
2030
e18afed7 20312012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2032
2033 * unexaix.c (make_hdr): Fix typo in prototype.
2034 This bug broke the build on AIX. Problem reported by Gilles Pion.
2035
9d0a235a
MA
20362012-05-14 Michael Albinus <michael.albinus@gmx.de>
2037
2038 * keyboard.c (kbd_buffer_get_event): Read special events also in
2039 batch mode. (Bug#11415)
2040
9e6b06ed
GM
20412012-05-12 Glenn Morris <rgm@gnu.org>
2042
2043 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2044
c1a1d7a3
EZ
20452012-05-12 Eli Zaretskii <eliz@gnu.org>
2046
2047 * lisp.mk (lisp): Add newcomment.elc.
2048
3fe7cdc8
GM
20492012-05-12 Glenn Morris <rgm@gnu.org>
2050
2051 * Makefile.in (MKDIR_P): New, set by configure.
2052 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2053
53f7d2c0
PE
20542012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 Remove unused function hourglass_started.
2057 * dispextern.h (hourglass_started):
2058 * w32fns.c (hourglass_started):
2059 * xdisp.c (hourglass_started): Remove.
2060
75aafb17
JB
20612012-05-10 Juanma Barranquero <lekktu@gmail.com>
2062
2063 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2064 Update dependencies.
2065
12959e8e
PE
20662012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2067
97107e2e
PE
2068 * xgselect.c (xg_select): Put maxfds+1 into a var.
2069 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2070
12959e8e
PE
2071 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2072
836d29b3
DA
20732012-05-10 Dave Abrahams <dave@boostpro.com>
2074
2075 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2076 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2077
5cb67954
MA
20782012-05-09 Michael Albinus <michael.albinus@gmx.de>
2079
2080 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2081 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2082 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2083 Initialize xd_registered_buses.
2084
3478ec45
PE
20852012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2086
b263a6b0
PE
2087 Untag more efficiently if USE_LSB_TAG.
2088 This is based on a proposal by YAMAMOTO Mitsuharu in
2089 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2090 For an admittedly artificial (nth 8000 longlist) benchmark on
2091 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2092 Emacs's overall text size by 1%.
2093 * lisp.h (XUNTAG): New macro.
2094 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2095 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2096 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2097 * eval.c (Fautoload):
2098 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2099 * frame.h (XFRAME): Use XUNTAG.
2100
3478ec45
PE
2101 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2102 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2103 Remove unportable assumptions about print widths of types like
2104 dbus_uint32_t.
2105 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2106 intptr_t when converting between pointer and integer, to avoid GCC
2107 warnings about wrong width.
2108
666b903b 21092012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2110
2111 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2112 stack for each reader_thread, instead of defaulting to 8MB
2113 determined by the linker. This avoids failures in creating
2114 subprocesses on Windows 7, see the discussion in this thread:
2115 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2116
b120cc17
JC
21172012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2118
2119 Fix up display of the *Minibuf-0* buffer in the mini window.
2120 * keyboard.c (read_char): Don't clear the echo area if there's no
2121 message to clear.
2122 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2123 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2124
9a4b36f8
MA
21252012-05-07 Michael Albinus <michael.albinus@gmx.de>
2126
2127 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2128 batch mode.
2129
e5f9458f
CY
21302012-05-06 Chong Yidong <cyd@gnu.org>
2131
2132 * lisp.mk (lisp): Update.
2133
eceeb5fc 21342012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2135
2136 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2137
71873e2b
SM
21382012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2139
2140 * data.c (PUT_ERROR): New macro.
2141 (syms_of_data): Use it. Add new error type `user-error'.
2142 * undo.c (user_error): New function.
2143 (Fprimitive_undo): Use it.
2144 * print.c (print_error_message): Adjust print style for `user-error'.
2145 * keyboard.c (user_error): New function.
2146 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2147
ab0fa4e4
PE
21482012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2149
2150 Do not limit current-time-string to years 1000..9999.
2151 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2152 (Fcurrent_time_string): Support any year that is supported by the
2153 underlying localtime representation. Don't use asctime, as it
2154 has undefined behavior for years outside the range -999..9999.
2155
7ed806a7
PE
21562012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 Fix race conditions involving setenv, gmtime, localtime, asctime.
2159 Without this fix, interrupts could mess up code that uses these
2160 nonreentrant functions, since setting TZ invalidates existing
2161 tm_zone or tzname values, and since most of these functions return
2162 pointers to static storage.
2163 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2164 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2165 Grow the critical sections to include not just invoking
2166 localtime/gmtime, but also accessing these functions' results
2167 including their tm_zone values if any, and any related TZ setting.
2168 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2169 so that the struct tm is saved in the critical section.
2170 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2171 motivated by the fact that memory allocation needs to be outside
2172 the critical section.
2173
0c16dfed
DA
21742012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2175
2176 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2177 with RESET_INTERVAL.
2178
2179 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2180 Remove duplicated buffer name initialization.
2181
3f83ace8
JM
21822012-05-02 Jim Meyering <jim@meyering.net>
2183
2184 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2185
c7b8541e
JM
2186 * xfns.c (x_window): Use xstrdup (Bug#11375).
2187
90207a15 21882012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2189
2190 * xdisp.c (pos_visible_p): If already at a newline from the
2191 display string before the 'while' loop, don't walk back the glyphs
2192 from it3.glyph_row. Solves assertion violation when the display
2193 string begins with a newline (egg.el). (Bug#11367)
2194
b593d6a9
AH
21952012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2196
2197 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2198 Move to simple.el.
2199
4737362e
GM
22002012-05-01 Glenn Morris <rgm@gnu.org>
2201
99cf43f9
GM
2202 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2203 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2204 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2205 All were removed before 23.1.
2206
9311dcff
GM
2207 * dispnew.c: Remove HAVE_LIBNCURSES test;
2208 it is always true on relevant platforms.
2209
4d5c6349
GM
2210 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2211 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2212
4737362e
GM
2213 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2214
74dd3a6b
AS
22152012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2216
2217 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2218 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2219 Remove.
2220
13c379ee
PE
22212012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2222
2223 Do not avoid creating empty evaporating overlays (Bug#9642).
2224 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2225 That is, do not delete an evaporating overlay if it becomes
2226 empty after its bounds are adjusted to fit within its buffer.
2227 This fix caused other problems, and I'm reverting it until we get
2228 to the bottom of them.
2229
a8e7d6d7 22302012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2231
2232 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2233
a8e7d6d7 22342012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2235
2236 * xdisp.c (pos_visible_p): If the window start position is beyond
2237 ZV, start the display from buffer beginning. Prevents assertion
2238 violation in init_iterator when the minibuffer window is scrolled
2239 via the scroll bar.
2240
2241 * window.c (window_scroll_pixel_based): Likewise.
2242
a8e7d6d7 22432012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2244
2245 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2246
a8e7d6d7 22472012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2248
2249 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2250 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2251
a8e7d6d7 22522012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2253
b593d6a9
AH
2254 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2255 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2256
1c6900d9
EZ
22572012-04-26 Eli Zaretskii <eliz@gnu.org>
2258
4c3fa1d9
EZ
2259 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2260 display element, check also the underlying string or buffer
2261 character. (Bug#11341)
2262
1c6900d9
EZ
2263 * w32menu.c: Include w32heap.h.
2264 (add_menu_item): If the call to AppendMenuW (via
2265 unicode_append_menu) fails, disable Unicode menus only if we are
2266 running on Windows 9X/Me.
2267
42bf8205
AS
22682012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2269
2270 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2271 (xgetint): Add missing shift for LSB tags.
2272
b1bac16e
MR
22732012-04-24 Martin Rudalics <rudalics@gmx.at>
2274
2275 * keyboard.c (read_char): Don't wipe echo area for select window
2276 events: These might get delayed via `mouse-autoselect-window'
2277 (Bug#11304).
2278
d69621cc
JB
22792012-04-24 Juanma Barranquero <lekktu@gmail.com>
2280
2281 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2282 manipulation of :loaded-from data.
2283
02fd101b
JB
22842012-04-23 Juanma Barranquero <lekktu@gmail.com>
2285
2286 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2287 now a cons (bug#11311).
2288
888bec30
PE
22892012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2290
89a438bd
PE
2291 Do not create empty overlays with the evaporate property (Bug#9642).
2292 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2293 if it becomes empty after its bounds are adjusted to fit within
2294 its buffer. Without this fix, in a nonempty buffer (let ((o
2295 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2296 yields an empty overlay that has the evaporate property, which is
2297 not supposed to happen.
2298
1068fe4d
PE
2299 Fix minor GTK3 problems found by static checking.
2300 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2301 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2302 (struct _EmacsFixedClass, emacs_fixed_get_type):
2303 Move decls here from emacsgtkfixed.h, since they needn't be public.
2304 (emacs_fixed_get_type): Now static.
2305 (emacs_fixed_class_init): Omit unused local.
2306 (emacs_fixed_child_type): Remove; unused.
2307 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2308 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2309 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2310 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2311 (EMACS_FIXED_GET_CLASS): Remove; unused.
2312 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2313
888bec30
PE
2314 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2315 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2316
de85e130
PE
23172012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2318
d0baac98 2319 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2320 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2321 (__malloc_size_t, __malloc_ptrdiff_t):
2322 Remove. All uses removed, replaced by the definiens if needed,
2323 since we can assume C89 or better now.
2324 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2325 (protect_malloc_state, align, get_contiguous_space)
2326 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2327 (malloc_atfork_handler_child, malloc_enable_thread)
2328 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2329 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2330 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2331 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2332 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2333 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2334 Define using prototypes, not old style.
2335 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2336 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2337 (align): Don't assume that signed integer overflow wraps around.
2338 Omit unused local var.
2339 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2340 (_free_internal_nolock, memalign, mallochook, reallochook):
2341 Omit no-longer-needed casts.
2342 (valloc): Use getpagesize, not __getpagesize.
2343 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2344 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2345
de85e130
PE
2346 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2347
dcbf5805
MA
23482012-04-22 Michael Albinus <michael.albinus@gmx.de>
2349
2350 Move functions from C to Lisp. Make non-blocking method calls
2351 the default. Implement further D-Bus standard interfaces.
2352
2353 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2354 (QCdbus_request_name_allow_replacement)
2355 (QCdbus_request_name_replace_existing)
2356 (QCdbus_request_name_do_not_queue)
2357 (QCdbus_request_name_reply_primary_owner)
2358 (QCdbus_request_name_reply_in_queue)
2359 (QCdbus_request_name_reply_exists)
2360 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2361 (QCdbus_registered_serial, QCdbus_registered_method)
2362 (QCdbus_registered_signal): New Lisp objects.
2363 (XD_DEBUG_MESSAGE): Use sizeof.
2364 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2365 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2366 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2367 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2368 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2369 (xd_signature, xd_append_arg): Allow float for integer types.
2370 (xd_get_connection_references): New function.
b593d6a9
AH
2371 (xd_get_connection_address): Rename from xd_initialize.
2372 Return cached address.
dcbf5805
MA
2373 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2374 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2375 level.
2376 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2377 Return number of refcounts.
dcbf5805
MA
2378 (Fdbus_get_unique_name): Make stronger parameter check.
2379 (Fdbus_message_internal): New defun.
2380 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2381 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2382 (Fdbus_send_signal, Fdbus_register_service)
2383 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2384 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2385 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2386 (Vdbus_compiled_version, Vdbus_runtime_version)
2387 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2388 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2389 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2390 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2391 Adapt docstring.
dcbf5805 2392
52828e02
PE
23932012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2394
da05bc4c
PE
2395 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2396 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2397 Do not assume ptrdiff_t is the same width as 'int'.
2398
52828e02
PE
2399 * alloc.c: Handle unusual debugging option combinations.
2400 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2401 since the two debugging options are incompatible.
2402 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2403 is defined.
2404 (mem_init, mem_insert, mem_insert_fixup):
2405 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2406 (NEED_MEM_INSERT): Remove; no longer needed.
2407
f01769f9
LL
24082012-04-22 Leo Liu <sdl.web@gmail.com>
2409
2410 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2411
5790543d
PE
24122012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2413
2414 * sysdep.c [__FreeBSD__]: Minor cleanups.
2415 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2416 Use Emacs indenting style more consistently. Avoid some casts.
2417 Use 'double' consistently rather than mixing 'float' and 'double'.
2418
b91b7e4d
EW
24192012-04-21 Eduard Wiebe <usenet@pusto.de>
2420
b593d6a9
AH
2421 * sysdep.c (list_system_processes, system_process_attributes):
2422 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2423
6114eb15
AS
24242012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2425
2426 * lisp.mk (lisp): Update.
2427
2f38dff7
PE
24282012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2429
2430 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2431 It is never used otherwise.
2432
4ae29f89
SM
24332012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2434
2435 * print.c (print_preprocess): Only check print_depth if print-circle
2436 is nil.
2437 (print_object): Check for cycles even when print-circle is nil and
2438 print-gensym is t, but only check print_depth if print-circle is nil.
2439
f30d612a
CY
24402012-04-20 Chong Yidong <cyd@gnu.org>
2441
2442 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2443 set the status to "failed" and ensure that sentinel is run.
2444
c07a4c0b 24452012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2446
2447 * process.c (Fset_process_inherit_coding_system_flag)
2448 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2449 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2450
c07a4c0b 24512012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2452
2453 * xdisp.c (string_buffer_position_lim): Limit starting position to
2454 BEGV.
2455 (set_cursor_from_row): If called for a mode-line or header-line
2456 row, return zero immediately.
2457 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2458 farther than the first row after the header line, if any.
2459 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2460 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2461
c07a4c0b 24622012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2463
4ae29f89
SM
2464 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2465 (bug#11238).
ad3a2b41 2466
c07a4c0b 24672012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 24682012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2469
2470 configure: new option --enable-gcc-warnings (Bug#11207)
2471 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2472 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2473 (ALL_CFLAGS): Use new macros rather than old.
2474 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2475 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2476 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2477 -Wunused-result, -Wunused-variable. This should go away once
2478 the Emacs and Gnulib regex code is merged.
2479 (xmalloc, xrealloc): Now static.
2480
aba027e8
PE
24812012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2482
2483 * dired.c (Fsystem_groups): Remove unused local.
2484
e5a36063
GM
24852012-04-17 Glenn Morris <rgm@gnu.org>
2486
2487 * dired.c (Fsystem_users): Doc fix.
2488
316411f0
DA
24892012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2490
2491 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2492 (syms_of_dired): Add them.
2493
9426aba4
PE
24942012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2495
b62a57be
PE
2496 Fix minor alloc.c problems found by static checking.
2497 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2498 New extern decls, to avoid calling undeclared functions.
2499 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2500 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2501 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2502 (NEED_MEM_INSERT): New macro.
2503 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2504 Remove one incorrect comment and fix another.
b62a57be 2505
3539f31f
PE
2506 Fix minor ralloc.c problems found by static checking.
2507 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2508 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2509 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2510 (r_alloc_sbrk): Now static.
2511
a041960a
PE
2512 Improve ralloc.c interface checking.
2513 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2514 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2515 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2516 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2517 [REL_ALLOC]: ... to here, to check interface.
2518 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2519 Remove decls. This fixes an "It stinks!".
2520
9426aba4
PE
2521 * alloc.c (which_symbols): Fix alignment issue / type clash.
2522
d55c12ed
AS
25232012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2524
2525 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2526 (struct Lisp_Misc_Any): Likewise.
2527 (struct Lisp_Free): Likewise.
2528 * alloc.c (union aligned_Lisp_Symbol): Define.
2529 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2530 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2531 (union aligned_Lisp_Misc): Define.
2532 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2533 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2534 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2535
b948ce8b
PE
25362012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2537
2538 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2539 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2540 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2541 * s/netbsd.h, s/sol2-6.h:
2542 Remove definition of GC_MARK_STACK, since the default now works.
2543 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2544 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2545 no longer the default.
2546 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2547
35dc09a1 25482012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2549
35dc09a1
GM
2550 * lread.c (lisp_file_lexically_bound_p):
2551 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2552
35dc09a1
GM
25532012-04-14 Eli Zaretskii <eliz@gnu.org>
2554
2555 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2556 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2557
25582012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2559
2560 * nsterm.m (constrainFrameRect): Always constrain when there is only
2561 one screen (Bug#10962).
2562
bcd86815
KB
25632012-04-13 Ken Brown <kbrown@cornell.edu>
2564
2565 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2566
c25df26e
RT
25672012-04-13 Reuben Thomas <rrt@sc3d.org>
2568
2569 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2570
0fc59f1e
DC
25712012-04-11 Daniel Colascione <dancol@dancol.org>
2572
2573 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2574 against is gone. It's better to use vfork now so that when Cygwin
2575 gains a new, working vfork, we use it automatically (bug#10398).
2576
de8c03dc
SM
25772012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2578
2579 * window.c (save_window_save): Obey window-point-insertion-type.
2580
2f097256
GM
25812012-04-11 Glenn Morris <rgm@gnu.org>
2582
2583 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2584
453b951e
SM
25852012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2586
2587 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2588
75f1671a 25892012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2590
2591 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2592 (force_quit_count): New var.
2593 (handle_interrupt): Use it.
2594
2a8ce227
JB
25952012-04-10 Juanma Barranquero <lekktu@gmail.com>
2596
2597 * w32.c (w32_delayed_load): Record the full path of the library
2598 being loaded (bug#10424).
2599
935396c0
GM
26002012-04-09 Glenn Morris <rgm@gnu.org>
2601
05920a43
GM
2602 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2603 not just in the obarray, before snarfing them. (Bug#11036)
2604
935396c0
GM
2605 * Makefile.in ($(leimdir)/leim-list.el):
2606 Pass EMACS rather than BUILT_EMACS.
2607
a18ecafa
TZ
26082012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2609
2610 * process.c (make_process):
2611 * process.h: Add integer `gnutls_handshakes_tried' member to
2612 process struct.
2613
6bbef4e5
JC
2614 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2615 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2616
2617 * gnutls.c (gnutls_log_function2i): Convenience log function.
2618 (emacs_gnutls_read): Use new log functions,
2619 `gnutls_handshakes_tried' process member, and
2620 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2621 attempts per process (connection).
2622
b4d3bc10
CY
26232012-04-09 Chong Yidong <cyd@gnu.org>
2624
2625 * eval.c (Fuser_variable_p, user_variable_p_eh)
2626 (lisp_indirect_variable): Functions deleted.
2627 (Fdefvar): Caller changed.
2628
2629 * callint.c (Finteractive, Fcall_interactively):
2630 * minibuf.c (Fread_variable): Callers changed.
2631
70f4d973
EZ
26322012-04-09 Eli Zaretskii <eliz@gnu.org>
2633
2634 * xdisp.c (set_cursor_from_row): If the display string appears in
2635 the buffer at position that is closer to point than the position
2636 after the display string, display the cursor on the first glyph of
2637 the display string. Fixes cursor display when a 'display' text
2638 property immediately follows invisible text. (Bug#11094)
2639
cb3c2e3e
PE
26402012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2641
2642 composite.c: use 'double' consistently
2643 * composite.c (get_composition_id): Use 'double' consistently
2644 instead of converting 'float' to 'double' and vice versa; this is
2645 easier to understand and avoids a GCC warning.
2646
fd06db5d
GM
26472012-04-09 Glenn Morris <rgm@gnu.org>
2648
50fe702a
GM
2649 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2650 preparation for dumping it with emacs. (Bug#4789)
2651 (leimdir): New variable.
2652 ($(leimdir)/leim-list.el): New rule.
2653 (emacs$(EXEEXT)): Depend on leim-list.el.
2654
fd06db5d
GM
2655 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2656 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2657 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2658
55c131ee
AS
26592012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2660
2661 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2662 proper alignment.
2663
9209588f
JB
26642012-04-07 Juanma Barranquero <lekktu@gmail.com>
2665
2666 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2667 Remove unused local variable.
2668
e3fb2efb
PE
26692012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2670
2671 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2672 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2673 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2674 objects, as mark_maybe_pointer will catch them otherwise.
2675 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2676 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2677
b5385551
PE
26782012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2679
2680 Fix typo that broke non-Windows builds.
2681 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2682
9078ead6
EZ
26832012-04-07 Eli Zaretskii <eliz@gnu.org>
2684
2685 Support building on MS-Windows with libxml2.
2686
2687 * makefile.w32-in (OBJ2): Add xml.$(O).
2688 (GLOBAL_SOURCES): Add xml.c.
2689 ($(BLD)/xml.$(O)): New dependency list.
2690
2691 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2692 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2693 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2694 [!WINDOWSNT]: New macros.
2695 (init_libxml2_functions, libxml2_loaded_p): New functions.
2696 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2697 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2698 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2699 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2700 linked in).
6bbef4e5
JC
2701 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2702 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2703 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2704
2705 * emacs.c: Don't include libxml/parser.h.
2706 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2707 xmlCleanupParser directly.
2708
2709 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2710
3811fdf3
EZ
27112012-04-07 Eli Zaretskii <eliz@gnu.org>
2712
2713 * indent.c (Fvertical_motion): If there is a display string at
2714 point, use it.vpos to compute how many lines to backtrack after
2715 move_it_to point. (Bug#11133)
2716
2f8e16b2
EZ
27172012-04-06 Eli Zaretskii <eliz@gnu.org>
2718
2719 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2720 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2721 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2722 macros related to unification of CJK characters. For the details,
2723 see the discussion following the message here:
2724 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2725
3d439cd1
CY
27262012-04-04 Chong Yidong <cyd@gnu.org>
2727
2728 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2729
8bc53d00
EZ
27302012-04-01 Eli Zaretskii <eliz@gnu.org>
2731
2732 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2733 instead of alloca. (Bug#11138)
2734
3b0512a3
AS
27352012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2736
2737 * w32menu.c (is_simple_dialog): Properly check lisp types.
2738 (Bug#11141)
2739
8427ddd2
EZ
27402012-03-31 Eli Zaretskii <eliz@gnu.org>
2741
979022ef
EZ
2742 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2743 position we get to after a call to move_it_to fails the
2744 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2745 only if we wind up in a string from display property. (Bug#11063)
2746
a6b1c7cc
EZ
2747 * window.c (Fdelete_other_windows_internal): Invalidate the row
2748 and column information about mouse highlight, so that redisplay
2749 restores it after reallocating the glyph matrices. (Bug#7464)
2750
8427ddd2
EZ
2751 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2752 string comes from a `display' text property, use the buffer
2753 position of that property as if we actually saw that position in
2754 the row's glyphs.
697ba24b
EZ
2755 (move_it_by_lines): Remove the assertion that
2756 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2757 violated when there's a before-string at the beginning of a line.
2758 (Bug#11063)
8427ddd2 2759
65a0a738
EZ
27602012-03-30 Eli Zaretskii <eliz@gnu.org>
2761
2762 * xdisp.c (append_space_for_newline): If the default face was
2763 remapped, use the remapped face for the appended newline.
2764 (extend_face_to_end_of_line): Use the remapped default face for
2765 extending the face to the end of the line.
2766 (display_line): Call extend_face_to_end_of_line when the default
2767 face was remapped. (Bug#11068)
2768
581355cc
EZ
27692012-03-29 Eli Zaretskii <eliz@gnu.org>
2770
2771 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2772
e8fc049f
SM
27732012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2774
2775 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2776
4fb9a543
GM
27772012-03-27 Glenn Morris <rgm@gnu.org>
2778
2779 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2780 Doc fixes.
2781
679910f1
KH
27822012-03-26 Kenichi Handa <handa@m17n.org>
2783
2784 * dispextern.h (struct glyph): Fix previous change. Change the
2785 bit length of glyphless.ch to 25 (Bug#11082).
2786
90d49b7f
CY
27872012-03-26 Chong Yidong <cyd@gnu.org>
2788
2789 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2790 (command_loop_1): Use it; inhibit selection update for
2791 handle-select-window too (Bug#8996).
2792
f514f6f0
FP
27932012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2794
e8fc049f 2795 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2796
bf43fa51
KH
27972012-03-25 Kenichi Handa <handa@m17n.org>
2798
2799 * dispextern.h (struct glyph): Change the bit length of
2800 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2801
8a0c01dd
EZ
28022012-03-24 Eli Zaretskii <eliz@gnu.org>
2803
2804 * s/ms-w32.h (tzname): Include time.h before redirecting to
2805 _tzname. Fixes the MSVC build. (Bug#9960)
2806
7d1c3a76
AS
28072012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2808
8ed79523
AS
2809 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2810 characters.
2811
7d1c3a76
AS
2812 * xterm.c (XTread_socket): Only modify handling_signal if
2813 !SYNC_INPUT. (Bug#11080)
2814
e99a9b8b
EZ
28152012-03-23 Eli Zaretskii <eliz@gnu.org>
2816
2817 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2818 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2819 when fetching a multibyte character consumes more bytes than
2820 CHAR_BYTES returns, due to unification of CJK characters in
2821 string_char. (Bug#11073)
2822
5063c0e1
TN
28232012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2824
2825 * process.c (wait_reading_process_output): Handle pty disconnect
2826 by refraining from sending oneself a SIGCHLD (bug#10933).
2827
9f851fbd
CY
28282012-03-22 Chong Yidong <cyd@gnu.org>
2829
2830 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2831
5063c0e1 2832 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2833 Mark string as coming from a prefix property.
2834 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2835 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2836
fb5b8aca
CY
28372012-03-21 Chong Yidong <cyd@gnu.org>
2838
2839 * xfaces.c (Vface_remapping_alist): Doc fix.
2840
62356a1b
EZ
28412012-03-20 Eli Zaretskii <eliz@gnu.org>
2842
2843 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2844 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2845 Doc fixes.
62356a1b 2846
025de85b
CY
28472012-03-20 Chong Yidong <cyd@gnu.org>
2848
2849 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2850 to reflect default non-nil value of redisplay-dont-pause.
2851
4827f94e
KH
28522012-03-19 Kenichi Handa <handa@m17n.org>
2853
2854 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2855 it fit in a valid range (Bug#11003).
2856
e50a24a2
EZ
28572012-03-18 Eli Zaretskii <eliz@gnu.org>
2858
2859 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2860 that is not from display property, accept the row as a "cursor
2861 row" if one of the string's character has a non-nil `cursor'
2862 property. Fixes cursor positioning when there are newlines in
2863 overlay strings, e.g. in icomplete.el. (Bug#11035)
2864
9af5ed87
PE
28652012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2866
2867 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2868
d1f55f16
CY
28692012-03-12 Chong Yidong <cyd@gnu.org>
2870
2871 * eval.c (inhibit_lisp_code): Rename from
2872 inhibit_window_configuration_change_hook; move from window.c.
2873
2874 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2875 * window.c (run_window_configuration_change_hook)
2876 (syms_of_window): Callers changed.
2877
66c5eebd
CY
28782012-03-11 Chong Yidong <cyd@gnu.org>
2879
413df973
CY
2880 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2881
66c5eebd
CY
2882 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2883
1de11f56
CY
28842012-03-10 Chong Yidong <cyd@gnu.org>
2885
2886 * frame.c (other_visible_frames): Don't assume the selected frame
2887 is visible (Bug#10955).
2888
cae07000
SM
28892012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2890
2891 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2892
89c94350
JD
28932012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2894
2895 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2896 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2897 zero (Bug#10954).
2898
999dd333
GM
28992012-03-03 Glenn Morris <rgm@gnu.org>
2900
01a6dcc8 2901 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2902
de0100f2
EZ
29032012-03-02 Eli Zaretskii <eliz@gnu.org>
2904
2905 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2906 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2907 (redisplay_window, next_element_from_string): Fix typos in
2908 comments.
3e441275
EZ
2909 (redisplay_window): Pass to move_it_vertically the margin in
2910 pixels, not in screen lines.
de0100f2 2911
96a72ee9
GM
29122012-03-02 Glenn Morris <rgm@gnu.org>
2913
2914 * buffer.c (buffer-list-update-hook): Doc fix.
2915
312508d7
EZ
29162012-02-29 Eli Zaretskii <eliz@gnu.org>
2917
2918 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2919 push_it before setting up the iterator for the first overlay
2920 string, even if we have an empty string loaded.
2921 (next_overlay_string): If there's an empty string on the iterator
2922 stack, pop the stack. (Bug#10903)
2923
27f3c637
PE
29242012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2925
2926 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2927 Suggested by Stefan Monnier in
2928 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2929 * alloc.c (widen_to_Lisp_Object): New static function.
2930 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2931 and widening them to Lisp_Objects. This would work even if
2932 USE_LSB_TAG is defined and wide integers are used, which might
2933 happen in a future version of Emacs.
2934
3c9dfce6
CY
29352012-02-25 Chong Yidong <cyd@gnu.org>
2936
fa74b241
CY
2937 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2938 Doc fix.
2939
3c9dfce6
CY
2940 * xselect.c (Fx_selection_exists_p): Doc fix.
2941 (x_clipboard_manager_save_all): Print an informative message
2942 before saving to clipboard manager.
2943
9486df08
CY
29442012-02-24 Chong Yidong <cyd@gnu.org>
2945
2946 * keyboard.c (process_special_events): Handle all X selection
2947 requests in kbd_buffer, not just the next one (Bug#8869).
2948
f01d3321
CY
29492012-02-23 Chong Yidong <cyd@gnu.org>
2950
2951 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2952 call when setting menu-bar-lines and tool-bar-lines parameters.
2953 (unwind_create_frame_1): New helper function.
2954
2955 * window.c (inhibit_window_configuration_change_hook): New var.
2956 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2957 (syms_of_window): Initialize it.
f01d3321 2958
86b847b6
CY
29592012-02-22 Chong Yidong <cyd@gnu.org>
2960
2961 * xterm.c (x_draw_image_relief): Add missing type check for
2962 Vtool_bar_button_margin (Bug#10743).
2963
a59225b1
CY
29642012-02-21 Chong Yidong <cyd@gnu.org>
2965
2966 * fileio.c (Vfile_name_handler_alist): Doc fix.
2967
2968 * buffer.c (Fget_file_buffer): Protect against invalid file
2969 handler return value.
2970
310f5bd4
PE
29712012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2972
cb3a28cc
PE
2973 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2974 when computing $valmask.
2975
310f5bd4
PE
2976 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2977 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2978 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2979 It's useless in that case, and it can cause problems on hosts
2980 that allocate halves of EMACS_INT values separately.
2981 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2982 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2983 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2984 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2985 it avoids undefined behavior on hosts where shifting right by more
2986 than the word width has undefined behavior.
2987
2375c96a
CY
29882012-02-19 Chong Yidong <cyd@gnu.org>
2989
2990 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2991 (Funhandled_file_name_directory, Ffile_name_as_directory)
2992 (Fdirectory_file_name, Fexpand_file_name)
2993 (Fsubstitute_in_file_name): Protect against invalid file handler
2994 return values (Bug#10845).
2995
3eb49e71
EZ
29962012-02-18 Eli Zaretskii <eliz@gnu.org>
2997
2998 * .gdbinit (pitx): Fix incorrect references to fields of the
2999 iterator stack.
3000
7b926f3f
CY
30012012-02-17 Chong Yidong <cyd@gnu.org>
3002
3003 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3004
11273115
PE
30052012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3006
3007 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3008 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3009
c3a70e2b
CY
30102012-02-15 Chong Yidong <cyd@gnu.org>
3011
3012 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3013 marked as special. Also, starting docstrings with * is obsolete.
3014
0ca43699
AS
30152012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3016
3017 * gnutls.c (emacs_gnutls_write): Fix last change.
3018
2e8f3c56
LI
30192012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3020
3021 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3022 send_process.
3023
af70074f
SM
30242012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3025
3026 * keymap.c (Fsingle_key_description): Handle char ranges.
3027
95986d52
CY
30282012-02-12 Chong Yidong <cyd@gnu.org>
3029
afd83bd1
CY
3030 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3031 as that creates a dangerous corner case.
3032
95986d52
CY
3033 * window.c (Fdelete_window_internal): Invalidate the mouse
3034 highlight (Bug#9904).
3035
bd7da63e
GM
30362012-02-12 Glenn Morris <rgm@gnu.org>
3037
3038 * xselect.c (Fx_own_selection_internal)
3039 (Fx_get_selection_internal, Fx_disown_selection_internal)
3040 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3041 * nsselect.m (Fx_own_selection_internal)
3042 (Fx_disown_selection_internal, Fx_selection_exists_p)
3043 (Fx_selection_owner_p, Fx_get_selection_internal):
3044 Sync docs and argument specs with the xselect.c versions.
3045
77abcbc2
LI
30462012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3047
3048 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3049
90b671e2
EZ
30502012-02-11 Eli Zaretskii <eliz@gnu.org>
3051
1c0ca0b7
EZ
3052 * w32select.c (Fx_selection_exists_p): Sync doc string and
3053 argument list with xselect.c. (Bug#10783)
3054
3055 * w16select.c (Fx_selection_exists_p): Sync doc string and
3056 argument list with xselect.c. (Bug#10783)
90b671e2 3057
49241268
GM
30582012-02-10 Glenn Morris <rgm@gnu.org>
3059
3060 * fns.c (Fsecure_hash): Doc fix.
3061
f998bbe7 30622012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3063
3064 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3065
0992bd9c
CY
30662012-02-07 Chong Yidong <cyd@gnu.org>
3067
3068 * buffer.c (Fbuffer_local_variables)
3069 (buffer_lisp_local_variables): Handle unbound vars correctly;
3070 don't let Qunbound leak into Lisp.
3071
af008560
GM
30722012-02-07 Glenn Morris <rgm@gnu.org>
3073
dd605cc4
GM
3074 * image.c (Fimagemagick_types): Doc fix.
3075
af008560
GM
3076 * image.c (imagemagick-render-type): Change it from a lisp object
3077 to an integer. Move the doc here from the lisp manual.
3078 Treat all values not equal to 0 the same.
3079
1449fa1d
CY
30802012-02-06 Chong Yidong <cyd@gnu.org>
3081
3082 * doc.c (store_function_docstring): Avoid applying docstring of
3083 alias to base function (Bug#2603).
3084
3723ec07
AS
30852012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3086
3087 * .gdbinit (pp1, pv1): Remove redundant defines.
3088 (pr): Use pp.
3089
79c1cc1e
CY
30902012-02-04 Chong Yidong <cyd@gnu.org>
3091
3092 * nsterm.m: Declare a global (Bug#10694).
3093
d7f29f8e
EZ
30942012-02-04 Eli Zaretskii <eliz@gnu.org>
3095
cae07000
SM
3096 * w32.c (get_emacs_configuration_options):
3097 Include --enable-checking, if specified, in the return value.
d7f29f8e 3098
3b95a6f9
MR
30992012-02-04 Martin Rudalics <rudalics@gmx.at>
3100
3101 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3102 after rounding frame sizes. (Bug#9723)
3103
d6fa96a6
EZ
31042012-02-04 Eli Zaretskii <eliz@gnu.org>
3105
3106 * keyboard.c (adjust_point_for_property): Don't position point
3107 before BEGV. (Bug#10696)
3108
df0b2940
PE
31092012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3110
3111 Handle overflow when computing char display width (Bug#9496).
3112 * character.c (char_width): Return EMACS_INT, not int.
3113 (char_width, c_string_width): Check for overflow when
3114 computing the width; this is possible now that individual
3115 characters can have unbounded width. Problem introduced
3116 by merge from Emacs 23 on 2012-01-19.
3117
6bee44d6
MA
31182012-02-02 Michael Albinus <michael.albinus@gmx.de>
3119
3120 * dbusbind.c (Fdbus_register_method): Mention the return value
3121 :ignore in the docstring.
3122
44f92739
GM
31232012-02-02 Glenn Morris <rgm@gnu.org>
3124
1b9f60cc
GM
3125 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3126
44f92739
GM
3127 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3128 Unconditionally set to t. (Bug#10673)
3129 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3130 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3131 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3132
c5d3843c
KH
31332012-02-02 Kenichi Handa <handa@m17n.org>
3134
3135 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3136 0, do not call append_composite_glyph.
3137
159462d4 31382012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3139
3140 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3141 NULL (Bug#6988).
3142 (x_produce_glyphs): If the component of a composition is a null
3143 string, set it->pixel_width to 1 to avoid zero-width glyph.
3144
78cef877
EZ
31452012-02-01 Eli Zaretskii <eliz@gnu.org>
3146
3147 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3148 first 2 arguments are identical. This makes inserting large
3149 output from a subprocess an order of magnitude faster on
3150 MS-Windows, where all sbrk'ed memory is always contiguous.
3151
97897668
GM
31522012-01-31 Glenn Morris <rgm@gnu.org>
3153
3154 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3155 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3156 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3157
31fd3586
GM
31582012-01-29 Glenn Morris <rgm@gnu.org>
3159
3160 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3161
0e24a8b2
CY
31622012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3163
3164 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3165
cc0adcb0
CY
31662012-01-28 Chong Yidong <cyd@gnu.org>
3167
3168 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3169
acc28cb9
CY
31702012-01-26 Chong Yidong <cyd@gnu.org>
3171
9c69cfb7
CY
3172 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3173
acc28cb9
CY
3174 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3175 repeat counts (Bug#10507).
3176
48da7392
GM
31772012-01-26 Glenn Morris <rgm@gnu.org>
3178
3179 * lread.c (syms_of_lread): Doc fix.
3180
14af5f7f
CY
31812012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3182
3183 * coding.c (encode_designation_at_bol): Change return value to
3184 EMACS_INT.
3185
0b21c100
CY
31862012-01-25 Chong Yidong <cyd@gnu.org>
3187
3188 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3189
3c2907f7
CY
31902012-01-21 Chong Yidong <cyd@gnu.org>
3191
3192 * floatfns.c (Fcopysign): Make the second argument non-optional,
3193 since nil is not allowed anyway.
3194
959ad23f
AS
31952012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3196
3197 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3198 (send_process): Likewise.
3199
34a02f46
MR
32002012-01-19 Martin Rudalics <rudalics@gmx.at>
3201
3202 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3203 (Vwindow_persistent_parameters): Do not use Qstate.
3204 Rewrite doc-strings.
34a02f46 3205
1259009a 32062012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3207
3208 * character.c (char_width): New function.
70d4fdf6
GM
3209 (Fchar_width, c_string_width, lisp_string_width):
3210 Use char_width (Bug#9496).
25ed9e61 3211
6a6ee00d
MR
32122012-01-16 Martin Rudalics <rudalics@gmx.at>
3213
3214 * window.c (Vwindow_persistent_parameters): New variable.
3215 (Fset_window_configuration, save_window_save): Handle persistent
3216 window parameters.
3217
c85efaf7
EZ
32182012-01-14 Eli Zaretskii <eliz@gnu.org>
3219
3220 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3221 thrashing the stack of the thread. (Bug#9087)
3222
5944709e
PE
32232012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3224
3225 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3226
e71f5d99
EZ
32272012-01-11 Eli Zaretskii <eliz@gnu.org>
3228
3229 * xdisp.c (rows_from_pos_range): Handle the case where the
3230 highlight ends on a newline. (Bug#10464)
3231 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3232 he end column for display of highlight that ends on a newline
3233 before a R2L line.
3234
ce316182
GM
32352012-01-11 Glenn Morris <rgm@gnu.org>
3236
3237 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3238 from load-path also when installation-directory is nil. (Bug#10208)
3239
5b43da69
GM
32402012-01-10 Glenn Morris <rgm@gnu.org>
3241
74cc8ff9
GM
3242 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3243
7d8d6e4e
GM
3244 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3245 Update template values to be closer to their typical values these days.
5b43da69 3246
a0db8d43
EZ
32472012-01-09 Eli Zaretskii <eliz@gnu.org>
3248
3249 * xdisp.c (rows_from_pos_range): Accept additional argument
3250 DISP_STRING, and accept any glyph in a row whose object is that
3251 string as eligible for mouse highlight. Fixes mouse highlight of
3252 display strings from overlays. (Bug#10464)
3253
9a0115ab 32542012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3255
b9110d6a 3256 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3257 * fileio.c (auto_saving_dir_umask): New static var.
3258 (Fmake_directory_internal): Use it.
3259 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3260 creating the directory. The old code temporarily assigns
3261 too-generous permissions to the directory.
3262 (do_auto_save_eh): Clear it.
b9110d6a 3263 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3264 that the var is always cleared.
3265
6c1bd3f3
EZ
32662012-01-07 Eli Zaretskii <eliz@gnu.org>
3267
3268 * search.c (scan_buffer): Pass character positions to
3269 know_region_cache, not byte positions. (Bug#6540)
3270
069d2b50
L
32712012-01-07 LynX <_LynX@bk.ru> (tiny change)
3272
3273 * w32.c (sys_rename): Report EXDEV when rename of a directory
3274 fails because the target is on another logical disk. (Bug#10284)
3275
75bf0d33
DB
32762012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3277
3278 * xterm.c (x_embed_request_focus): New function.
3279
3280 * xterm.h: Add prototype.
3281
3282 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3283
1c6e5a32
GM
32842012-01-05 Glenn Morris <rgm@gnu.org>
3285
3286 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3287
651e947e
EZ
32882012-01-01 Eli Zaretskii <eliz@gnu.org>
3289
3290 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3291 Load gnutls_transport_set_lowat only if GnuTLS version is below
3292 2.11.1.
3293 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3294 GnuTLS versions below 2.11.1.
3295
3778cdd8
AL
32962011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3297
3298 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3299 to the doc string advising against its use for altering the way
3300 windows are scrolled.
3301
0e5317f7
KH
33022011-12-28 Kenichi Handa <handa@m17n.org>
3303
3304 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3305 coding-system ASCII compatible only when it does not produce BOM
3306 on encoding (Bug#10383).
3307
93d5ca1f
JD
33082011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3309
3310 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3311 can scroll.
3312 (create_and_show_popup_menu): Always use menu_position_func for
3313 Gtk3 (Bug#10361).
3314
ca22b785
AS
33152011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3316
3317 * callint.c (Fcall_interactively): Don't truncate prompt string.
3318
d048e1e6
EZ
33192011-12-23 Eli Zaretskii <eliz@gnu.org>
3320
3321 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3322 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3323 resumed from there (after widening). (Bug#10360)
d048e1e6 3324
5ccaba1f
JD
33252011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3326
3327 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3328
204ee57f
JD
33292011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3330
b81d40f0
JB
3331 * nsterm.m (x_free_frame_resources):
3332 Release f->output_data.ns->miniimage.
204ee57f
JD
3333 (ns_index_color): Fix indentation. Do not retain
3334 color_table->colors[i].
3335
3336 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3337 before returning.
3338
3339 * nsfns.m (x_set_background_color): Assign return value from
3340 ns_index_color to face-background instead of NSColor*.
3341 (ns_implicitly_set_icon_type): Fix indentation.
3342 Change assignment in for loop to comparison.
3343
3344 * emacs.c (ns_pool): New variable.
3345 (main): Assign ns_pool.
3346 (Fkill_emacs): Call ns_release_autorelease_pool.
3347
3348 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3349 autorelease fdesc, release fdAttrs and tdict.
3350 (ns_get_covering_families): Release charset.
3351 (ns_findfonts): Release NSFontDescriptor created with new.
3352 (ns_uni_to_glyphs): Fix indentation.
3353 (setString): Release attrStr before assigning new value.
3354
c803b2b7
JD
33552011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3356
678f4426
JD
3357 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3358 and NS_IMPL_COCOA.
3359 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3360 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3361
cd394be1 33622011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3363
5fecd5fc
JD
3364 * nsterm.m (ns_term_init): Subscribe for notifications
3365 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3366 to method trackingNotification in EmacsMenu.
3367
3368 * nsmenu.m (trackingMenu): New variable.
3771cb17 3369 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3370 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3371 from Aquamacs (Bug#7030).
678f4426
JD
3372
33732011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3374
c803b2b7
JD
3375 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3376 (symbol_to_nsstring): Fix indentation.
3377 (ns_symbol_to_pb): New function.
cae07000
SM
3378 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3379 (Fns_rotate_cut_buffers_internal): Remove.
3380 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3381 Fns_store_cut_buffer_internal.
3382 (ns_get_foreign_selection, Fx_own_selection_internal)
3383 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3384 (Fns_get_selection_internal, Fns_store_selection_internal):
3385 Use ns_symbol_to_pb and check if return value is nil.
3386 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3387 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3388 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3389 renamed to Sns_store_selection_internal.
3390 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3391 and remove this function.
3392 (ns_handle_selection_clear): Remove, never used.
3393 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3394 here.
3395
e1b01a3a
KB
33962011-12-17 Ken Brown <kbrown@cornell.edu>
3397
3398 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3399 GID is unknown (Bug#10257).
3400
2adb6e85
PE
34012011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3404 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3405 which caused a build failure on GNU/Linux IA-64. This problem was
3406 introduced by my 2011-10-07 patch.
3407
d1d7b339
JL
34082011-12-15 Juri Linkov <juri@jurta.org>
3409
3410 * image.c (imagemagick_error): New function. (Bug#10112)
3411 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3412 Use `imagemagick_error' where ImageMagick functions return
3413 `MagickFalse'.
3414 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3415 proper order.
3416
100d5755
KH
34172011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3418
3419 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3420 fill background (Bug#8992).
3421
454592a6
MR
34222011-12-13 Martin Rudalics <rudalics@gmx.at>
3423
3424 * window.c (Vwindow_combination_resize)
3425 (Vwindow_combination_limit): Use t instead of non-nil in
3426 doc-strings.
61d4b438
MR
3427 (Vrecenter_redisplay): Add first sentence of doc-string on
3428 separate line.
53524d93 3429 (Frecenter): Fix doc-string typo.
454592a6 3430
3633e3aa
KH
34312011-12-11 Kenichi Handa <handa@m17n.org>
3432
3433 * coding.c (Funencodable_char_position): Pay attention to the
3434 buffer text relocation (Bug#9389).
3435
7b9d523a 34362011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3437
7b9d523a
JD
3438 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3439 gtk_init (Bug#10100).
3440
b73189c6
EZ
34412011-12-10 Eli Zaretskii <eliz@gnu.org>
3442
3443 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3444 IT->string is nil. (Bug#10263)
3445
f7dfe5d6
JD
34462011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3447
83faebb4
JD
3448 * nsterm.h (x_free_frame_resources): Declare.
3449
f7dfe5d6
JD
3450 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3451 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3452
3453 * nsterm.h (ns_get_defaults_value): Declare.
3454
3455 * nsterm.m (ns_default): Call ns_get_defaults_value.
3456
7cd4e72c
EZ
34572011-12-09 Eli Zaretskii <eliz@gnu.org>
3458
3459 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3460 (Bug#10170)
3461
b34d7317
YM
34622011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3463
3464 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3465 that where the value of an _OBJC_* symbol points to is in the .bss
3466 section (Bug#10240).
3467
76470ad1
KH
34682011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3469
3470 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3471 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3472
745fff94
KH
34732011-12-08 Kenichi Handa <handa@m17n.org>
3474
3475 * ftfont.c (get_adstyle_property): Fix previous change
3476 (Bug#10233).
3477
6e44397c
JB
34782011-12-07 Juanma Barranquero <lekktu@gmail.com>
3479
3480 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3481 dirs from the default value of EMACSLOADPATH (bug#10208).
3482
7efa6272
GM
34832011-12-07 Glenn Morris <rgm@gnu.org>
3484
3485 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3486 installation and source directories as well. (Bug#10208)
3487
f6fc4d87
CY
34882011-12-06 Chong Yidong <cyd@gnu.org>
3489
3490 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3491
2bf26180
GM
34922011-12-06 Glenn Morris <rgm@gnu.org>
3493
3494 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3495 as an error, not just -1. (Bug#10217)
3496
3a6ad4f0
CY
34972011-12-05 Chong Yidong <cyd@gnu.org>
3498
3499 * keyboard.c (process_special_events): New function.
3500 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3501
75a3b399
PE
35022011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3503
3504 * coding.c (encode_designation_at_bol): Don't use uninitialized
3505 local variable (Bug#9318).
3506
c3c9e25e
KH
35072011-12-05 Kenichi Handa <handa@m17n.org>
3508
3509 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3510 return Qnil (Bug#8046, Bug#10193).
3511
5eb05ea3
KH
35122011-12-05 Kenichi Handa <handa@m17n.org>
3513
3514 * coding.c (encode_designation_at_bol): New args charbuf_end and
3515 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3516 (coding_set_source): Return how many bytes coding->source was
3517 relocated.
3518 (coding_set_destination): Return how many bytes
3519 coding->destination was relocated.
3520 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3521 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3522
35232011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3524
3525 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3526 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3527 macro (Bug#9318).
3528
35292011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3530
3531 The following changes are to fix Bug#9318.
3532
a79703f5 3533 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3534 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3535 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3536 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3537
7dbda6df
JB
35382011-12-05 Juanma Barranquero <lekktu@gmail.com>
3539
3540 * lisp.h (process_quit_flag): Fix external declaration.
3541
6d5eb5b0
SM
35422011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3543
3544 Don't macro-inline non-performance-critical code.
3545 * eval.c (process_quit_flag): New function.
3546 * lisp.h (QUIT): Use it.
3547
a0c3fad0
JD
35482011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3549
3550 * nsfns.m (get_geometry_from_preferences): New function.
3551 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3552
6c07aac2
AS
35532011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3554
3555 * emacs.c (Qkill_emacs): Define.
3556 (syms_of_emacs): Initialize it.
3557 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3558 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3559 (quit_throw_to_read_char): Add parameter `from_signal'.
3560 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3561 * lisp.h (QUIT): Call Fkill_emacs if requested.
3562
c052ead4
JD
35632011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3564
3565 * widget.c (update_wm_hints): Return if wmshell is null.
3566 (widget_update_wm_size_hints): New function.
3567
3568 * widget.h (widget_update_wm_size_hints): Declare.
3569
3570 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3571 widget_update_wm_size_hints (Bug#10104).
3572
9e49252b
EZ
35732011-12-03 Eli Zaretskii <eliz@gnu.org>
3574
3575 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3576 before a newline, prepare the bidi iterator for consuming the
3577 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3578 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3579
02b16839
JL
35802011-12-02 Juri Linkov <juri@jurta.org>
3581
3582 * search.c (Fword_search_regexp): New Lisp function created from
3583 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3584 (Fword_search_backward, Fword_search_forward)
3585 (Fword_search_backward_lax, Fword_search_forward_lax):
3586 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3587 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3588
0068070e
SM
35892011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3590
3591 * fileio.c (Finsert_file_contents): Move after-change-function call
3592 to before the "handled:" label, since all "goto handled" appear in
3593 cases where the *-change-functions have already been properly called
3594 (bug#10117).
3595
3360a3fc
AS
35962011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3597
3598 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3599 waiting for input. (Bug#10169)
3600
73d6c093
EZ
36012011-11-30 Eli Zaretskii <eliz@gnu.org>
3602
3603 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3604 verifies glyph row's hash code--we have just reallocated the
3605 glyphs, so their contents can be complete garbage. (Bug#10164)
3606
febe6bea
JB
36072011-11-30 Juanma Barranquero <lekktu@gmail.com>
3608
3609 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3610
801a4313
EZ
36112011-11-30 Eli Zaretskii <eliz@gnu.org>
3612
3613 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3614 attributes are tested _before_ calling verify_row_hash, to protect
3615 against GCC re-ordering of the tests. (Bug#10164)
3616
2b56b87e
JD
36172011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3618
3619 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3620
3621 * xterm.c (handle_one_xevent): Only set async_visible and friends
3622 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3623 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3624 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3625
dbf31225
PE
36262011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3627
3628 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3629 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3630 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3631 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3632 All uses changed to use GCPRO1 etc.
3633 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3634 Revert to old implementation (i.e., before 2011-03-11).
3635
1305621b
YM
36362011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3637
3638 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3639 of scroll runs so as to avoid assigning disabled bogus rows and
3640 unnecessary graphics copy operations.
3641
8c9afb46
EZ
36422011-11-27 Eli Zaretskii <eliz@gnu.org>
3643
3644 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3645 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3646 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3647 (malloc, free, realloc, calloc): Redirect to e_* only when
3648 compiling Emacs.
3649
3650 * lisp.h (GCTYPEBITS): Move before first use.
3651 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3652 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3653 this macro definition.
3654
3655 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3656 _MSC_VER.
3657
54e9e3bf
JD
36582011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3659
6d5eb5b0
SM
3660 * gtkutil.c (xg_create_frame_widgets):
3661 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3662 present with Gtk+ 2.0.
3663
83aca1cb
PE
36642011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3665
3666 * fileio.c (Finsert_file_contents): Undo previous change; see
3667 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3668
5b76caa4
PE
36692011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3670
3671 Rename locals to avoid shadowing.
3672 * fileio.c (Finsert_file_contents):
3673 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3674 * process.c (wait_reading_process_output):
3675 Rename inner 'proc' to 'p' to avoid shadowing.
3676 Indent for consistency with usual Emacs style.
3677
8c535114
EZ
36782011-11-25 Eli Zaretskii <eliz@gnu.org>
3679
3680 * xdisp.c (redisplay_window): If cursor row is not fully visible
3681 after recentering, and scroll-conservatively is set to a large
3682 number, scroll window by a few more lines to make the cursor fully
3683 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3684 (start_display): Don't move to the next line if the display should
3685 start at a newline that is part of a display vector or an overlay
3686 string. (Bug#10119)
8c535114 3687
fa4fdb5c
JL
36882011-11-24 Juri Linkov <juri@jurta.org>
3689
3690 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3691 after the `MagickPingImage' call. (Bug#10112)
3692
90ec88df
CY
36932011-11-23 Chong Yidong <cyd@gnu.org>
3694
3695 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3696
56e2e794
MR
36972011-11-23 Martin Rudalics <rudalics@gmx.at>
3698
3699 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3700 making another buffer current. (Bug#10114)
3701
b6e64c41
GM
37022011-11-23 Glenn Morris <rgm@gnu.org>
3703
3704 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3705
6b21de18
CY
37062011-11-23 Chong Yidong <cyd@gnu.org>
3707
3708 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3709 using it (Bug#5984).
3710
b12cd789
EZ
37112011-11-22 Eli Zaretskii <eliz@gnu.org>
3712
3713 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3714 and header-lines, as they don't have one computed for them.
3715 (Bug#10098)
3716
3717 * .gdbinit (prow): Make displayed values more self-explaining.
3718 Add row's hash code.
3719
261b6fd4
LMI
37202011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3721
3722 * process.c (wait_reading_process_output): Fix asynchrounous
3723 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3724 (wait_reading_process_output): Add comment and URL.
261b6fd4 3725
e7cfd277
JD
37262011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3727
3728 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3729
a9b9b7f5
CY
37302011-11-21 Chong Yidong <cyd@gnu.org>
3731
3732 * window.c (Fnext_window, Fprevious_window): Doc fix.
3733
b0d15b4f
SM
37342011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3735
3736 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3737
fe7a3057
JB
37382011-11-20 Juanma Barranquero <lekktu@gmail.com>
3739
3740 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3741
d2999b1a
MR
37422011-11-20 Martin Rudalics <rudalics@gmx.at>
3743
3744 * window.c (Fset_window_combination_limit): Rename argument
3745 STATUS to LIMIT.
3746 (Vwindow_combination_limit): Remove "status" from doc-string.
3747
d5ff9cd0
AS
37482011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3749
3750 * m/ibms390.h: Remove.
3751 * m/ibms390x.h: Don't include "ibms390.h".
3752
a5bb9bd3
SM
37532011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3754
3755 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3756 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3757
cd1181db
JB
37582011-11-20 Juanma Barranquero <lekktu@gmail.com>
3759
3760 * casetab.c (Fset_case_table):
3761 * charset.c (Fcharset_after): Fix typos.
3762
615a3b8d 37632011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3764
17e845af
PE
3765 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3766 Otherwise, valgrind does not work on some platforms.
3767 Problem reported by Andreas Schwab in
6a0bf43d
PE
3768 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3769 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3770 is set, removing the need for VIRT_ADDRESS_VARIES.
3771 (PURE_P): Use a more-efficient implementation that needs just one
3772 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3773 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3774 to 4 (xorl, subq, cmpq, setbe).
3775 * alloc.c (pure): Always extern now, since that's the
3776 VIRT_ADDR_VARIES behavior.
3777 (PURE_POINTER_P): Use a single comparison, not two, for
3778 consistency with the new puresize.h.
3779 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3780 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3781 Remove VIRT_ADDR_VARIES no longer needed.
3782
f8fe6f96
EZ
37832011-11-19 Eli Zaretskii <eliz@gnu.org>
3784
3785 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3786 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3787 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3788 behave as if the cursor position were at the window margin.
3789
3790 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3791 and the cursor position is out of bounds, behave as if the cursor
3792 position were at the window margin. (Bug#10075)
3793
df05a53c
CY
37942011-11-18 Chong Yidong <cyd@gnu.org>
3795
3796 * window.c (Fwindow_combination_limit): Make first argument
3797 non-optional, since it is meaningless for live windows like the
3798 selected window.
61ccba97 3799
2071918e
DA
38002011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3801
3802 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3803
b50a28de
SM
38042011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3805
3806 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3807 (graft_intervals_into_buffer): Simplify.
3808
015137db
EZ
38092011-11-18 Eli Zaretskii <eliz@gnu.org>
3810
3811 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3812 hash values of the two rows.
3813 (copy_row_except_pointers): Preserve the used[] arrays and the
3814 hash values of the two rows. (Bug#10035)
68c95424 3815 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3816
3817 * xdisp.c (row_hash): New function, body extracted from
3818 compute_line_metrics.
3819 (compute_line_metrics): Call row_hash, instead of computing the
3820 hash code inline.
3821
3822 * dispnew.c (verify_row_hash): Call row_hash for computing the
3823 hash code of a row, instead of duplicating code from xdisp.c.
3824
3825 * dispextern.h (row_hash): Add prototype.
3826
a2addb04
TH
38272011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3828
3829 * frame.c (delete_frame): Don't delete the terminal when the last
3830 X frame is closed if emacs is built with GTK toolkit.
3831
df85d315
JB
38322011-11-17 Juanma Barranquero <lekktu@gmail.com>
3833
3834 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3835
a0c2d0ae
MR
38362011-11-17 Martin Rudalics <rudalics@gmx.at>
3837
3838 * window.c (Vwindow_splits): Rename to
3839 Vwindow_combination_resize. Suggested by Juri Linkov.
3840 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3841 of Vwindow_splits.
3842
58179cce
JB
38432011-11-16 Juanma Barranquero <lekktu@gmail.com>
3844
7877f373
JB
3845 * nsfns.m (Fns_font_name):
3846 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3847
b6f67890
MR
38482011-11-16 Martin Rudalics <rudalics@gmx.at>
3849
3850 * window.h (window): Rename slot "nest" to "combination_limit".
3851 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3852 (Fset_window_nest): Rename to Fset_window_combination_limit.
3853 (Vwindow_nest): Rename to Vwindow_combination_limit.
3854 (recombine_windows, make_parent_window, make_window)
3855 (Fsplit_window_internal, saved_window)
3856 (Fset_window_configuration, save_window_save): Rename all
3857 occurrences of window_nest to window_combination_limit.
3858
c7015153
JB
38592011-11-15 Juanma Barranquero <lekktu@gmail.com>
3860
3861 * image.c (imagemagick_load_image): Fix typo.
3862
322ad6ec
EZ
38632011-11-14 Eli Zaretskii <eliz@gnu.org>
3864
3865 * xdisp.c (display_line): Move the call to
3866 highlight_trailing_whitespace before the call to
3867 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3868 faces of all the glyphs to compute ROW's hash value.
3869 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3870
f067b8ec
JB
38712011-11-14 Juanma Barranquero <lekktu@gmail.com>
3872
3873 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3874 just return (bug#10044).
3875
1e5b2111
EZ
38762011-11-12 Eli Zaretskii <eliz@gnu.org>
3877
7ef3cbd5
EZ
3878 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3879 with user-defined heap size. Bump the default size of the temacs
3880 heap to 27MB, to avoid memory warning when running temacs.
3881 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3882
1e5b2111
EZ
3883 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3884 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3885 (verify_row_hash) [XASSERTS]: New function.
3886 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3887 that the hash value of glyph rows is correct.
1e5b2111 3888
89d61221
MR
38892011-11-12 Martin Rudalics <rudalics@gmx.at>
3890
3891 * window.h (window): Remove splits slot.
3892 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3893 (Fdelete_other_windows_internal, make_parent_window)
3894 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3895 (Fset_window_configuration, save_window_save): Don't deal with
3896 split status of windows.
3897 (saved_window): Remove splits slot.
3898 (Vwindow_splits): Rewrite doc-string.
3899
97f18cc8
JD
39002011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3901
3902 * xfns.c (unwind_create_frame):
3903 * nsfns.m (unwind_create_frame):
3904 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3905 Vframe_list (Bug#9999).
3906
22a648b4
DA
39072011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3908
0b381c7e 3909 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3910
659afede
KH
39112011-11-11 Kenichi Handa <handa@m17n.org>
3912
3913 * callproc.c (Fcall_process): Set the member dst_multibyte of
3914 process_coding.
3915
9ac0394b
KH
39162011-11-11 Johan Bockgård <bojohan@gnu.org>
3917
3918 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3919 avoid a crash (bug#9496).
3920
2fbdc249
CY
39212011-11-09 Chong Yidong <cyd@gnu.org>
3922
3923 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3924 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3925
ac6b1f81
PE
39262011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3927
3928 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3929
09db192c
PE
39302011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3931
3932 Avoid some portability problems by eschewing 'extern inline' functions.
3933 The trivial performance wins aren't worth the portability hassles; see
3934 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3935 et seq.
3936 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3937 (window_box_width, window_box_left, window_box_left_offset)
3938 (window_box_right, window_box_right_offset): Undo previous change,
3939 by removing the "extern"s.
3940 * intervals.c (adjust_intervals_for_insertion)
3941 (adjust_intervals_for_deletion): Undo previous change,
3942 making these static again.
3943 (offset_intervals, temp_set_point_both, temp_set_point)
3944 (copy_intervals_to_string): No longer inline.
3945 * xdisp.c (window_text_bottom_y, window_box_width)
3946 (window_box_height, window_box_left_offset)
3947 (window_box_right_offset, window_box_left, window_box_right)
3948 (window_box): No longer inline.
3949
105216ed
CY
39502011-11-08 Chong Yidong <cyd@gnu.org>
3951
3952 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3953 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3954 Signal an error if not a live window.
105216ed
CY
3955 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3956 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3957
ae9e237f
JB
39582011-11-07 Juanma Barranquero <lekktu@gmail.com>
3959
3960 * lisp.h (syms_of_abbrev): Remove declaration.
3961 Reported by CHENG Gao <chenggao@royau.me>.
3962
c7aa8333
EZ
39632011-11-07 Eli Zaretskii <eliz@gnu.org>
3964
3965 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3966 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3967 of temacs in GUI mode.
3968
be7f5545
MR
39692011-11-07 Martin Rudalics <rudalics@gmx.at>
3970
3971 * window.h: Declare delete_all_child_windows instead of
3972 delete_all_subwindows.
3973 * window.c (Fwindow_nest, Fset_window_nest)
3974 (Fset_window_new_total, Fset_window_new_normal)
3975 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3976 (delete_all_subwindows): Rename to delete_all_child_windows.
3977 (Fdelete_other_windows_internal, Fset_window_configuration):
3978 Call delete_all_child_windows instead of delete_all_subwindows.
3979 * frame.c (delete_frame): Call delete_all_child_windows instead
3980 of delete_all_subwindows.
3981
ca78dc43
PE
39822011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3983
3984 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3985 This is also needed for porting to any host where GC_MARK_STACK is
3986 not GC_MAKE_GCPROS_NOOPS.
3987 (which_symbols): Use it.
3988
a0241d01
KH
39892011-11-07 Kenichi Handa <handa@m17n.org>
3990
3991 * coding.c (coding_set_destination): Check coding->src_pos only
3992 when coding->src_object is a buffer (bug#9910).
3993
3994 * process.c (send_process): Set the member src_multibyte of coding
3995 to 0 (bug#9911) when sending a unibyte text.
3996
3997 * callproc.c (Fcall_process): Set the member src_multibyte of
3998 process_coding to 0 (bug#9912).
3999
a64bfdfa 40002011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4001
4002 * xmenu.c (cleanup_widget_value_tree): New function.
4003 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4004 calling free_menubar_widget_value_tree directly (Bug#9830).
4005
cb41b32a
PE
40062011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4007
4008 Fix some portability problems with 'inline'.
4009 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4010 (window_box_width, window_box_left, window_box_left_offset)
4011 (window_box_right, window_box_right_offset): Declare extern.
4012 Otherwise, these inline functions do not conform to C99 and
4013 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4014 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4015 * intervals.c (adjust_intervals_for_insertion)
4016 (adjust_intervals_for_deletion): Now extern, because otherwise the
4017 extern inline functions 'offset_intervals' couldn't refer to it.
4018 (static_offset_intervals): Remove.
4019 (offset_intervals): Rewrite using the old contents of
4020 static_offset_intervals. The old version didn't conform to C99
4021 because an extern inline function contained a reference to an
4022 identifier with static linkage.
4023
b7041366
AS
40242011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4025
4026 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4027 GC.
4028
88a37c4d
EZ
40292011-11-06 Eli Zaretskii <eliz@gnu.org>
4030
4031 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4032 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4033 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4034 return Qleft_to_right.
4035
49745b39
CY
40362011-11-06 Chong Yidong <cyd@gnu.org>
4037
4038 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4039 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4040 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4041 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4042 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4043 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4044 (Fwindow_vscroll): Doc fix.
4045 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4046 argument, since it makes no sense to pass a live window and for
4047 consistency with window-child.
4048
1f05cd82
CS
40492011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4050
4051 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4052 support MSVC.
4053
22610910
JR
40542011-11-05 Jason Rumney <jasonr@gnu.org>
4055
4056 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4057 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4058 fonts (Bug#6029).
4059 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4060 bitwise arithmetic preventing use of unicode-sip and non-truetype
4061 opentype fonts.
4062
a06776b2
EZ
40632011-11-05 Eli Zaretskii <eliz@gnu.org>
4064
3ad924ba
EZ
4065 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4066 "emacs"-only part.
4067
a06776b2
EZ
4068 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4069 initialization code to keep similarity to xfns.c after changes
4070 from 2011-11-05.
4071
c9e7db78
JD
40722011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4073
a97f8f3f
JD
4074 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4075 (unwind_create_frame): New function (Bug#9943).
4076 (Fx_create_frame): Restructure code to be more similar to the one in
4077 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4078 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4079 Move terminal->reference_count++ just before making the frame official
4080 (Bug#9943).
4081
4082 * nsterm.m (x_free_frame_resources): New function.
4083 (x_destroy_window): Move code to x_free_frame_resources.
4084
c9e7db78 4085 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4086 (Fx_create_frame, x_create_tip_frame):
4087 Move terminal->reference_count++ just before making the frame
75f1671a 4088 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4089 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4090
a6fc3b5c
EZ
40912011-11-05 Eli Zaretskii <eliz@gnu.org>
4092
4093 Support MSVC build with newer versions of Visual Studio.
4094 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4095 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4096 nt/gmake.defs.
4097
4098 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4099 which are not supported by MSVC.
4100 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4101 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4102 bitfields.
4103 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4104 types in bitfields.
4105 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4106
4107 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4108
58179cce 41092011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4110
4111 Support MSVC build with newer versions of Visual Studio.
4112 * w32.c: Don't include w32api.h for MSVC.
4113 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4114
4115 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4116 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4117 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4118 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4119 e_* cousins.
4120 (alloca) [_MSC_VER]: Define to _alloca.
4121
4122 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4123
4124 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4125
a58c13ed
EZ
41262011-11-04 Eli Zaretskii <eliz@gnu.org>
4127
4128 * xdisp.c (note_mouse_highlight): If either of
4129 previous/next-single-property-change returns nil, treat that as
4130 the beginning or the end of the buffer. (Bug#9955)
4131
fe0b6370
JD
41322011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4133
a58c13ed 4134 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4135 label is not null (Bug#9951).
4136 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4137 may be NULL.
4138
89bd5ee1
EZ
41392011-11-04 Eli Zaretskii <eliz@gnu.org>
4140
4141 * window.c (Fwindow_body_size): Mention in the doc string that the
4142 return value is in frame's canonical units. (Bug#9949)
4143
84c3edb9
EZ
41442011-11-03 Eli Zaretskii <eliz@gnu.org>
4145
4e2fb5c7
EZ
4146 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4147
84c3edb9 4148 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4149 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4150 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4151
bc17a887
EZ
41522011-11-01 Eli Zaretskii <eliz@gnu.org>
4153
4154 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4155 Don't stop backward scan on the continuation glyph, even though
4156 its CHARPOS is positive.
6d5eb5b0
SM
4157 (mouse_face_from_buffer_pos, note_mouse_highlight):
4158 Rename cover_string to disp_string.
bc17a887 4159
4ee88440
MR
41602011-11-01 Martin Rudalics <rudalics@gmx.at>
4161
4162 * window.c (temp_output_buffer_show): Don't use
4163 Vtemp_buffer_show_specifiers.
4164 (Vtemp_buffer_show_specifiers): Remove unused variable.
4165
c2ff3c02
EZ
41662011-10-30 Eli Zaretskii <eliz@gnu.org>
4167
4168 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4169 past the beginning of the current glyph matrix.
4170
58179cce 41712011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4172
4173 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4174 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4175 HAVE_GTK3 (Bug#9869).
b77a6a7f 4176
3b574623
JD
4177 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4178 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4179
b77a6a7f
JD
4180 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4181
4182 * xterm.c: Declare x_handle_net_wm_state to return int.
4183 (handle_one_xevent): Check if we are iconified but don't have
4184 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4185 (get_current_wm_state): Return non-zero if not hidden,
4186 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4187 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4188 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4189 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4190
196e41e4
PE
41912011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4192
4193 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4194 so that this new function doesn't get optimized away by a
4195 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4196
021f2e1a
AS
41972011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4198
4199 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4200
8b058d44
EZ
42012011-10-29 Eli Zaretskii <eliz@gnu.org>
4202
4203 Fix the `xbytecode' command.
4204 * .gdbinit (xprintbytestr): New command.
b50a28de 4205 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4206 (xbytecode): Print the byte-code string as well.
4207
4452fb80
EZ
42082011-10-29 Kim Storm <storm@cua.dk>
4209
8b058d44
EZ
4210 * alloc.c (which_symbols): New function.
4211
21b72067
AS
42122011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4213
4214 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4215 line. (Bug#9903)
4216
83ed7b5c
GM
42172011-10-29 Glenn Morris <rgm@gnu.org>
4218
4219 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4220 Not clear what it was for, and it causes various bugs. (Bug#9839)
4221
5a7a728b
EZ
42222011-10-28 Eli Zaretskii <eliz@gnu.org>
4223
4224 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4225 possible random value that matches one of those tested as
4226 condition to clear the mouse face.
4227
d3d0842f
CY
42282011-10-28 Chong Yidong <cyd@gnu.org>
4229
4230 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4231
31b39d13
DN
42322011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4233
4234 * window.c (make_window): Initialize phys_cursor_on_p.
4235
9aba6043
SM
42362011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4237
4238 * lisp.h (struct Lisp_Symbol): Update comments.
4239
c20992f4
JB
42402011-10-28 Juanma Barranquero <lekktu@gmail.com>
4241
4242 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4243
db4f02f2
EZ
42442011-10-28 Eli Zaretskii <eliz@gnu.org>
4245
4246 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4247 <oslsachem@gmail.com> for helping to debug this.
4248
4249 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4250 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4251 (g_b_init_get_glyph_outline_w): New static variables.
4252 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4253 (GetGlyphOutlineW_Proc): New typedefs.
4254 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4255 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4256 New functions.
4257 (w32font_open_internal, compute_metrics):
4258 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4259 instead of calling the "wide" APIs directly.
4260
4261 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4262
4263 * w32.h (syms_of_w32font): Add prototype.
4264
87e68db4
JB
42652011-10-27 Juanma Barranquero <lekktu@gmail.com>
4266
4267 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4268 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4269 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4270 (Fmove_to_window_line): Doc fix.
4271
435c1d67
CY
42722011-10-27 Chong Yidong <cyd@gnu.org>
4273
4274 * process.c (make_process): Set gnutls_state to NULL.
4275
4276 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4277 non-NULL, regardless of GNUTLS_INITSTAGE.
4278 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4279 an error. Set process slots as soon as we allocate them.
4280
4281 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4282
9c6c6f49
CY
42832011-10-27 Chong Yidong <cyd@gnu.org>
4284
9aba6043
SM
4285 * gnutls.c (emacs_gnutls_deinit): New function.
4286 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4287 (Fgnutls_deinit, Fgnutls_boot): Use it.
4288
4289 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4290 (deactivate_process): Call emacs_gnutls_deinit.
4291
657d08d3
JB
42922011-10-27 Juanma Barranquero <lekktu@gmail.com>
4293
4294 * image.c (x_create_x_image_and_pixmap):
4295 * w32.c (sys_rename, w32_delayed_load):
4296 * w32font.c (fill_in_logfont):
4297 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4298
5430d399
JB
42992011-10-26 Juanma Barranquero <lekktu@gmail.com>
4300
4301 * w32fns.c (w32_default_color_map): New function,
4302 extracted from Fw32_default_color_map.
a7ef684b 4303 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4304
fe0055fa
PE
43052011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4306
4307 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4308
e6346438
SM
43092011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4310
4311 * keyboard.c (test_undefined): New function (bug#9751).
4312 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4313
e112cc37
ET
43142011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4315
4316 * sysdep.c (init_sys_modes): Fix the check for the controlling
4317 terminal (Bug#6649).
4318
7b5d6677
EZ
43192011-10-20 Eli Zaretskii <eliz@gnu.org>
4320
4321 * dispextern.h (struct bidi_it): New member next_en_type.
4322
4323 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4324 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4325 current character, check also for next_en_type being WEAK_EN.
4326 (bidi_resolve_weak): Don't enter the expensive loop if the current
4327 position is before next_en_pos. Record the bidi type of the first
4328 non-ET, non-BN character we find, in addition to its position.
4329 (bidi_level_of_next_char): Invalidate next_en_type when
4330 next_en_pos is over-stepped.
4331
7da0b018
PE
43322011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4333
4334 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4335 * editfns.c: Rewrite current-time-zone so that it invokes
4336 the equivalent of (format-time-string "%Z") to get the time zone name.
4337 This fixes a bug when the time zone name contains characters that
4338 need converting from the system time locale to Emacs internal format.
4339 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4340 that patch fixed format-time-string to do the conversion, but
4341 I forgot to fix current-time-zone.
4342 (format_time_string): New function, containing most of
4343 what Fformat_time_string used to contain.
4344 (Fformat_time_string): Rewrite in terms of format_time_string.
4345 This doesn't change this function's behavior.
4346 (current-time-zone): Rewrite to use format_time_string.
4347 This fixes the bug reported by Michael Schierl in
4348 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4349 Jason Rumney's 2007-06-07 change worked around this bug, but
4350 didn't fix it.
4351 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4352
8547b010
EZ
43532011-10-19 Eli Zaretskii <eliz@gnu.org>
4354
4355 * xdisp.c (start_display): If the character at POS is displayed
4356 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4357 (try_window_reusing_current_matrix): If a line ends in a display
4358 vector or the next line starts in a display vector, continue
4359 redrawing the window even though the character position of
4360 start_row was reached.
8547b010
EZ
4361 (Bug#9771, part 2)
4362
4e948d15
CY
43632011-10-18 Chong Yidong <cyd@gnu.org>
4364
4365 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4366 with nobreak-char-display too.
4367
4787455f
EZ
43682011-10-18 Eli Zaretskii <eliz@gnu.org>
4369
4370 Fix part 3 of bug#9771.
4371 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4372 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4373 non-neutral characters if the current character is a paragraph
4374 separator (a.k.a. Newline). This avoids running the same
4375 expensive loop twice, once when we consume the preceding newline
4376 and the other time when the line actually needs to be displayed.
4377 Avoid the loop when we see neutrals on the base embedding level
4378 following a character whose directionality is the same as the
4379 paragraph's. This avoids running the expensive loop when a line
4380 ends in a long sequence of neutrals, like control characters.
4381 Add assertion against STRONG_AL type. Slightly rearrange code
4382 that determines the type of a neutral given the first non-neutral
4383 that follows it.
4384 (bidi_level_of_next_char): Set next_en_pos to zero when
4385 invalidating its info.
4386
2c91f553
EZ
43872011-10-17 Eli Zaretskii <eliz@gnu.org>
4388
4389 * xdisp.c (push_display_prop): Determine whether to record string
4390 or buffer position by IT->string, not by IT->method. Allow
4391 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4392 (move_it_vertically_backward): Don't look for character position
4393 immediately after the newline when in a continuation line.
4394 (Bug#9771, part 1)
2c91f553 4395
c7b08b0d
MR
43962011-10-15 Martin Rudalics <rudalics@gmx.at>
4397
4398 * window.c (coordinates_in_window): Rewrite and delabelize
4399 vertical border check. (Bug#5357) (Bug#9618)
4400
6b02f655
SM
44012011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4402
4403 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4404 errors in XSetWindowBorder (bug#9310).
4405
81d40c92
DA
44062011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4407
4408 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4409 avoid crash when xmalloc overrun checking is enabled.
4410
d4172c3b
EZ
44112011-10-13 Eli Zaretskii <eliz@gnu.org>
4412
4413 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4414 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4415 cursor motion with <left> and <right> arrow keys.
4416
4417 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4418 some callers set that themselves.
4419
b00eea75
EZ
44202011-10-12 Eli Zaretskii <eliz@gnu.org>
4421
4422 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4423 display string and the previous row comes from the same string and
4424 is empty. (Bug#9739) (Bug#9738)
4425
8fe012c4
SM
44262011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4427
4428 * doc.c (get_doc_string): Encode file name (bug#9735).
4429
0074aef2
EZ
44302011-10-12 Eli Zaretskii <eliz@gnu.org>
4431
79beb178
EZ
4432 * bidi.c (bidi_level_of_next_char):
4433 * xdisp.c (get_visually_first_element): Remove old incorrect
4434 comments regarding the Unicode Line Separator character.
4435
0074aef2
EZ
4436 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4437
6e4b3fbe
DA
44382011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4439
4440 * alloc.c (Fgc_status): Do not access beyond zombies array
4441 boundary if nzombies > MAX_ZOMBIES.
4442 * alloc.c (dump_zombies): Add missing format specifier.
4443
0324f3af
PE
44442011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4445
b5525cac
PE
4446 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4447 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4448
0324f3af
PE
4449 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4450 Some packages use them to denote characters with modifiers.
4451
e9b5f888
AS
44522011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4453
4454 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4455 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4456 matching a pp-number. Rename parameter var to var1.
4457
127827c0
SM
44582011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4459
4460 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4461
c8fd3bd0
GM
44622011-10-08 Glenn Morris <rgm@gnu.org>
4463
4464 * callint.c (Fcall_interactively): Give a more explicit error for the
4465 'c' case with a non-character input. (Bug#8479)
4466
352ec8ff
EZ
44672011-10-08 Eli Zaretskii <eliz@gnu.org>
4468
03669ccb
EZ
4469 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4470 lines.
7061c986
EZ
4471 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4472 lines that are hscrolled on the left.
03669ccb 4473
352ec8ff
EZ
4474 * dispnew.c (buffer_posn_from_coords): Account for a possible
4475 presence of header-line. (Bug#4426)
4476
a66cfb1c
SM
44772011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4478
6b02f655
SM
4479 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4480 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4481
7c5ee88e
PE
44822011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4483
4484 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4485 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4486 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4487 this makes Emacs dump core during garbage collection on rare
4488 occasions. sizeof is obviously inferior to offsetof here, so
4489 stick with offsetof.
4490 (GC_POINTER_ALIGNMENT): New macro.
4491 (mark_memory): Omit 3rd (offset) arg; caller changed.
4492 Don't assume EMACS_INT alignment is the same as pointer alignment.
4493
df1bbe5b
SM
44942011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4495
4496 * keyboard.c (read_key_sequence_remapped): New var.
4497 (read_key_sequence): Compute remapping in the right buffer.
4498 (command_loop_1): Use read_key_sequence's remapping directly.
4499
51553db6
SM
45002011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4501
32c1fffd
SM
4502 * dired.c (file_name_completion): Don't expand file name.
4503 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4504 before checking file name handler.
4505
51553db6
SM
4506 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4507 they've been requested explicitly (bug#9591).
4508
b6bd1599 45092011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4510
4511 * keymap.c (Fsingle_key_description): Use make_specified_string
4512 instead of build_string to build string from push_key_description.
4513 (Bug#5193)
4514
f701dc2a
PE
45152011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4516
4222c55d
PE
4517 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4518 This fixes a Y2038 bug on 64-bit hosts.
4519 * buffer.c (reset_buffer):
4520 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4521 (Fclear_buffer_auto_save_failure):
4522 Use 0, not -1, to represent an unset failure time, since time_t
4523 might not be signed.
4524
f701dc2a
PE
4525 Remove dependency on glibc malloc internals.
4526 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4527 Move back here from lisp.h, but with their new implementations.
4528 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4529 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4530 * charset.c (charset_table_init): New static var.
4531 (syms_of_charset): Use it instead of xmalloc. This removes a
4532 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4533 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4534 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4535 Move back to alloc.c.
4536 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4537 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4538
9ceebf39
JD
45392011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4540
4541 * nsterm.m (windowDidResize): Call x_set_window_size only when
4542 ns_in_resize is true. Otherwise set pixelwidth/height and
4543 call change_frame_size (Bug#9628).
4544
cb993c58
PE
45452011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4546
3930c88b
PE
4547 Port --enable-checking=all to Fedora 14 x86-64.
4548 * charset.c (syms_of_charset): Also account for glibc malloc's
4549 internal overhead when calculating the initial malloc maximum.
4550
cb993c58
PE
4551 Port --enable-checking=all to Fedora 14 x86.
4552 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4553 Move to lisp.h.
4554 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4555 (overrun_check_realloc, overrun_check_free):
4556 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4557 That way, xmalloc returns a properly-aligned pointer even if
4558 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4559 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4560 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4561 into account when calculating the initial malloc maximum.
4562 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4563 Move here from alloc.c, so that charset.c can use it too.
4564 Properly align; the old code wasn't right for common 32-bit hosts
4565 when configured with --enable-checking=all.
4566 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4567 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4568
31bed486
EZ
45692011-09-29 Eli Zaretskii <eliz@gnu.org>
4570
04c70788 4571 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4572 use EDOM.
4573
fbcaa2f3
EZ
45742011-09-28 Eli Zaretskii <eliz@gnu.org>
4575
4576 * xdisp.c (compute_display_string_end): If there's no display
4577 string at CHARPOS, return -1.
4578
4579 * bidi.c (bidi_fetch_char): When compute_display_string_end
4580 returns a negative value, treat the character as a normal
4581 character not covered by a display string. (Bug#9624)
4582
a239d4e9
JB
45832011-09-28 Juanma Barranquero <lekktu@gmail.com>
4584
4585 * lread.c (Fread_from_string): Fix typo in docstring.
4586
88652fd5
EZ
45872011-09-27 Eli Zaretskii <eliz@gnu.org>
4588
4589 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4590 newline, reseat the iterator instead of bidi-iterating there one
4591 character at a time. (Bug#9610)
32c1fffd
SM
4592 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4593 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4594
ed497dd4
AS
45952011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4596
4597 * lread.c (readevalloop): Use correct code for NBSP.
4598 (read1): Likewise. (Bug#9608)
4599
b2bf61aa
MA
46002011-09-25 Michael Albinus <michael.albinus@gmx.de>
4601
4602 * dbusbind.c (Fdbus_register_signal): When service is not
4603 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4604
32bbb17c
GM
46052011-09-25 Glenn Morris <rgm@gnu.org>
4606
4607 * buffer.c (truncate-lines): Doc fix.
4608
94e0933e
CY
46092011-09-24 Chong Yidong <cyd@stupidchicken.com>
4610
4611 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4612 (Fset_window_next_buffers): Doc fix.
4613
cddde921
GM
46142011-09-24 Glenn Morris <rgm@gnu.org>
4615
4616 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4617
1260aef1
PE
46182011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4619
25b4bfa0
PE
4620 Fix minor problems found by static checking.
4621 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4622 * indent.c (Fvertical_motion): Fix == vs = typo.
4623
e3cbd34b
EZ
46242011-09-24 Eli Zaretskii <eliz@gnu.org>
4625
a66cfb1c
SM
4626 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4627 Default value is now t. Doc fix.
6bf7006f 4628
e3cbd34b 4629 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4630 logic when moving up, not only when moving down. Fix the
e3cbd34b 4631 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4632 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4633
4634 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4635 CHARPOS is covered by a display string which includes newlines.
4636 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4637 is covered by a display string with embedded newlines.
4638
a3de0cbd
MA
46392011-09-24 Michael Albinus <michael.albinus@gmx.de>
4640
4641 * dbusbind.c (Fdbus_register_signal): Add match rule to
4642 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4643 (Fdbus_register_method, Vdbus_registered_objects_table):
4644 Fix docstring.
a3de0cbd 4645
b260039d
JM
46462011-09-24 Jim Meyering <meyering@redhat.com>
4647
32c1fffd 4648 do not ignore write error for any output size
b260039d
JM
4649 The previous change was incomplete.
4650 While it makes emacs --batch detect the vast majority of stdout
4651 write failures, errors were still ignored whenever the output size is
4652 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4653 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4654 && echo FAIL: ignored write error
4655 FAIL: ignored write error
4656 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4657 && echo FAIL: ignored write error
4658 FAIL: ignored write error
4659 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4660
8eca8a7c
AS
46612011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4662
4663 * emacs.c (Fkill_emacs): In noninteractive mode exit
4664 non-successfully if a write error occurred on stdout. (Bug#9574)
4665
3341db62
EZ
46662011-09-21 Eli Zaretskii <eliz@gnu.org>
4667
4668 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4669 the xassert test.
4670
4671 * dispextern.h (struct it): Update the comment documenting what
4672 can it->OBJECT be.
4673
8c203dbf
EZ
46742011-09-20 Eli Zaretskii <eliz@gnu.org>
4675
4676 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4677 a display string, extend search for cursor position to end of row.
4678 (find_row_edges): If the row ends in a newline from a display
4679 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4680 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4681 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4682 non-empty line. Fixes confusing cursor motion with arrow keys at
4683 the beginning of a line that starts with whitespace.
8c203dbf 4684
a4824228
LMI
46852011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4686
4687 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4688 (bug#9493).
4689
33ed493b
CY
46902011-09-18 Chong Yidong <cyd@stupidchicken.com>
4691
4692 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4693 boolean (Bug#9154).
4694
56cd55c8
EZ
46952011-09-18 Eli Zaretskii <eliz@gnu.org>
4696
4697 * xdisp.c (display_line): Record maximum and minimum buffer
4698 positions even if no glyphs were produced (e.g., by a zero-width
4699 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4700 buffer positions that will be removed from the glyph row because
4701 they don't fit.
c02dcedf
EZ
4702 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4703 column is beyond frame width: don't subtract 1 "pixel" when
4704 computing width of the stretch.
3e62b7e0
EZ
4705 (reseat_at_next_visible_line_start): Undo the change made on
4706 2011-09-17 that saved paragraph information and restored it after
4707 the call to `reseat'. (Bug#9545)
56cd55c8 4708
5ed99d36 47092011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4710
4711 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4712 and turn window cursor on if cleared (Bug#9415).
4713
5ed99d36 47142011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4715
4716 * search.c (boyer_moore): Take unibyte characters from pattern
4717 literally. (Bug#9458)
4718
9bade7b2
EZ
47192011-09-18 Eli Zaretskii <eliz@gnu.org>
4720
4721 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4722
e5e9d610
PE
47232011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4724
87e4427a
PE
4725 Fix minor problem found by static checking.
4726 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4727 initialized, to pacify gcc -Wuninitialized.
4728
e5e9d610
PE
4729 * fileio.c: Report proper errno when syscall falls.
4730 (Finsert_file_contents): Save and restore errno,
4731 so that report_file_error outputs the correct diagnostic.
4732 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4733
a1674f0b
EZ
47342011-09-18 Eli Zaretskii <eliz@gnu.org>
4735
4736 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4737
fbfb6dd4
EZ
47382011-09-17 Eli Zaretskii <eliz@gnu.org>
4739
4740 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4741 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4742
bb187662
EZ
47432011-09-17 Eli Zaretskii <eliz@gnu.org>
4744
1137e8b8 4745 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4746 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4747
4748 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4749 (bidi_find_paragraph_start): Search back for paragraph beginning
4750 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4751 (bidi_move_to_visually_next): Only trigger paragraph-related
4752 computations when the last character is a newline or at EOB, not
4753 just any NEUTRAL_B. (Bug#9470)
4754
bb187662
EZ
4755 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4756 truncated lines if point is covered by a display string. (Bug#9524)
4757
2e621251
PE
47582011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4759
4760 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4761 (cons_to_x_long): New function.
4762 (lisp_data_to_selection_data): Use it. Correct the test for
4763 short-versus-long data; it was negated. Break out of vector
4764 loop, for efficiency, when a long datum is discovered.
4765
91a15bc6
SM
47662011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4767
4768 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4769
b41c3a35
EZ
47702011-09-16 Eli Zaretskii <eliz@gnu.org>
4771
4772 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4773 GCC PR/17406) by declaring this function with external scope.
4774
7812ba2d
PE
47752011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4776
4777 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4778 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4779
cf7edc2a
AS
47802011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4781
4782 * editfns.c (Fformat): Correctly handle text properties on "%%".
4783
bd01620e
EZ
47842011-09-15 Eli Zaretskii <eliz@gnu.org>
4785
4786 * xterm.c (x_draw_composite_glyph_string_foreground):
4787 * w32term.c (x_draw_composite_glyph_string_foreground):
4788 * term.c (encode_terminal_code):
4789 * composite.c (composition_update_it, get_composition_id):
4790 * xdisp.c (get_next_display_element)
4791 (fill_composite_glyph_string): Add comments about special meaning
4792 of TAB characters in a composition.
4793
a02719a3
PE
47942011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4795
4796 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4797 This occurs when processing a multibyte format.
4798 Problem reported by Wolfgang Jenker.
a02719a3 4799
72589a3c
JB
48002011-09-15 Johan Bockgård <bojohan@gnu.org>
4801
4802 * xdisp.c (try_cursor_movement): Only check for exact match if
4803 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4804
1c14176c
PE
48052011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4806
4807 Remove unused external symbols.
4808 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4809 * xdisp.c (calc_pixel_width_or_height): Now static.
4810 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4811 * indent.c (check_display_width):
4812 * w32term.c: Fix comment to match code.
4813 * xterm.c, xterm.h (x_catching_errors): Remove.
4814
d2eea5b5
PE
48152011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4816
4817 * xselect.c: Use signed conversions more consistently (Bug#9498).
4818 (selection_data_to_lisp_data): Assume incoming selection data are
4819 signed integers, not unsigned. This is to be consistent with
4820 outgoing selection data, which was modified to use signed integers
4821 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4822 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4823 expects long, not unsigned long.
4824
46888499
EZ
48252011-09-14 Eli Zaretskii <eliz@gnu.org>
4826
4827 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4828 computation of loop end. Reported by Johan Bockgård
4829 <bojohan@gnu.org>.
4830
ef8ef9fb
CY
48312011-09-13 Chong Yidong <cyd@stupidchicken.com>
4832
4833 * frame.c (Fother_visible_frames_p): Function deleted.
4834
fa819fed
EZ
48352011-09-12 Eli Zaretskii <eliz@gnu.org>
4836
4837 * indent.c (compute_motion): Process display vector front to back
4838 rather than the other way around. (Bug#2496)
4839
2ba8e008
SM
48402011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4841
4842 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4843
20f53c69
CY
48442011-09-11 Chong Yidong <cyd@stupidchicken.com>
4845
4846 * minibuf.c (Fread_from_minibuffer): Doc fix.
4847
d562d7a4
EZ
48482011-09-11 Eli Zaretskii <eliz@gnu.org>
4849
4850 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4851 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4852
1c4d7f3d
LMI
48532011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4854
4855 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4856 value for non-existent files.
4857
b885bf36
EZ
48582011-09-11 Eli Zaretskii <eliz@gnu.org>
4859
4860 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4861 set its "size" to -1. This will set the modtime_size field of
4862 the corresponding buffer to -1, which is what
4863 verify-visited-file-modtime expects for files that do not exist.
4864 (Bug#9139)
4865
6612f0bf
PE
48662011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4867
4868 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4869 here ...
4870 * lisp.h: ... from here. push_key_description is no longer
4871 defined in keyboard.c, so its declaration should not be in
4872 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4873 logically belongs with push_key_description.
4874
dfb3f755
PE
48752011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4876
4877 * buffer.h: Include <sys/types.h> instead of <time.h>.
4878 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4879 Problem reported by Herbert J. Skuhra.
4880
3134906c
LMI
48812011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4882
4883 * xml.c (parse_region): Make the parsing work for
4884 non-comment-starting XML files again (bug#9144).
4885
8d903f4e
AS
48862011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4887
4888 * image.c (gif_load): Fix calculation of bottom and right corner.
4889 (Bug#9468)
4890
80ad64f4
EZ
48912011-09-10 Eli Zaretskii <eliz@gnu.org>
4892
4893 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4894 redisplay in small windows.
4895
208a048d
EZ
48962011-09-09 Eli Zaretskii <eliz@gnu.org>
4897
4898 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4899
9b1c252e
MR
49002011-09-08 Martin Rudalics <rudalics@gmx.at>
4901
4902 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4903 Operate on live windows only.
4904
2949f33b
JB
49052011-09-08 Juanma Barranquero <lekktu@gmail.com>
4906
4907 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4908
e08dcafd
EZ
49092011-09-07 Eli Zaretskii <eliz@gnu.org>
4910
4911 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4912 only under bidi iteration.
4913
115b96bd
JD
49142011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4915
4916 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4917
c8199d0f
PE
49182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4919
4920 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4921 Without this fix, the command to link temacs failed due to an
4922 undefined symbol __builtin_isnan. This is because
4923 /usr/include/iso/math_c99.h #defines isnan(x) to
4924 __builtin_isnan(x), but the bundled gcc, which identifies itself
4925 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4926 a __builtin_isnan.
4927 * floatfns.c (isnan): #undef, and then #define to a clone of
4928 what's in data.c.
4929 (Fisnan): Always define, since it's always available now.
4930 (syms_of_floatfns): Always define isnan at the Lisp level.
4931
e39b275c 49322011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4933
4934 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4935
b2db44d9 49362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4937
f4af5137 4938 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4939 The previous code assumed that file offsets (off_t values) fit in
4940 EMACS_INT variables, which is not true on typical 32-bit hosts.
4941 The code messed up by falsely reporting buffer overflow in cases
4942 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4943 when "big" contains more than 2**29 bytes, even though this
4944 inserts just one byte and does not overflow the buffer.
4945 (Finsert_file_contents): Store file offsets as off_t
4946 values, not as EMACS_INT values. Check for overflow when
4947 converting between EMACS_INT and off_t. When checking for
4948 buffer overflow or for overlap, take the offsets into account.
4949 Don't use EMACS_INT for small values where int suffices.
4950 When checking for overlap, fix a typo: ZV was used where
4951 ZV_BYTE was intended.
4952 (Fwrite_region): Don't assume off_t fits into 'long'.
4953 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4954
ecfc0a49
MA
49552011-09-05 Michael Albinus <michael.albinus@gmx.de>
4956
4957 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4958
6511acf2 49592011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4960
0999621a 4961 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4962
4963 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4964 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4965 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4966 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4967 (modify_event_symbol): Do not assume that the length of
4968 name_alist_or_stem is safe to alloca and fits in int.
4969 (Fexecute_extended_command): Likewise for function name and binding.
4970 (Frecursion_depth): Wrap around reliably on integer overflow.
4971 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4972 since some callers pass EMACS_INT values.
4973 (Fsingle_key_description): Don't crash if symbol name contains more
4974 than MAX_ALLOCA bytes.
4975 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4976 (get_minibuffer): Arg is now EMACS_INT, not int.
4977 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4978 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4979 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4980
2be7d702
PE
4981 * dbusbind.c (signature_cat): New function.
4982 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4983 Do not overrun buffer; instead, report string overflow.
4984
9d1df220
PE
4985 * dispnew.c (add_window_display_history): Don't overrun buffer.
4986 Truncate instead; this is OK since it's just a log.
4987
33ef5c64
PE
4988 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4989 even if the time zone offset is outlandishly large.
4990 Don't mishandle offset == INT_MIN.
4991
66c6fdd5
PE
4992 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4993 when creating daemon; the previous buffer-overflow check was incorrect.
4994
d749b01b
PE
4995 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4996 which has the guts of the old verror function.
4997
b5cd1905
PE
4998 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4999 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5000
6e1a67fb
PE
5001 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5002 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5003 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5004 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5005 length of string rather than counting it via multiple sprintfs;
5006 that's simpler and more reliable.
c21721cc
PE
5007 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5008 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5009 sprintf, in case result does not fit in int.
5010
c57b67fc
PE
5011 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5012 (fontset_from_font): Print it.
5013
8a401434
PE
5014 * frame.c (tty_frame_count): Now printmax_t, not int.
5015 (make_terminal_frame, set_term_frame_name): Print it.
5016 (x_report_frame_params): In X, window IDs are unsigned long,
5017 not signed long, so print them as unsigned.
5018 (validate_x_resource_name): Check for implausibly long names,
5019 and don't assume name length fits in 'int'.
5020 (x_get_resource_string): Don't blindly alloca invocation name;
5021 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5022 not fit in int.
5023
6e1a67fb
PE
5024 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5025 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5026 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5027
0df02bf3
PE
5028 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5029 Use esprintf, not sprintf, in case result does not fit in int.
5030
48e30793
PE
5031 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5032 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5033 it as a large positive number.
5034 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5035 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5036
a66ff6d8
PE
5037 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5038 in case result does not fit in int.
5039
aca216ff
PE
5040 * print.c (float_to_string): Detect width overflow more reliably.
5041 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5042 buffer overrun. Don't assume list length fits in 'int'. Treat
5043 print length of 0 as 0, not as infinity; to be consistent with other
5044 uses of print length in this function. Don't overflow print length
5045 index. Don't assume hash table size fits in 'long', or that
5046 vectorlike size fits in 'unsigned long'.
5047
31c286f7
PE
5048 * process.c (make_process): Use printmax_t, not int, to format
5049 process-name gensyms.
5050
55e5faa1
PE
5051 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5052
80f2e268
PE
5053 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5054 to avoid potential buffer overrun.
5055
670741ab
PE
5056 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5057 if X resource line is longer than 512 bytes.
5058
b7163a50
PE
5059 * xfns.c (x_window): Make sprintf buffer a bit bigger
5060 to avoid potential buffer overrun.
5061
ae58ff1f
PE
5062 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5063
c43c8a6a
PE
5064 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5065
3f8236f4
PE
50662011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5067
53e9fe90 5068 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5069 Without these, Emacs silently mishandles large integers sometimes.
5070 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5071 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5072
6511acf2
PE
5073 * xdisp.c (try_window_id): Check Emacs fixnum range before
5074 converting to 'int'.
806add1d 5075
6511acf2 5076 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5077 Check that an Emacs fixnum is in range before assigning it to 'int'.
5078 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5079 values converted from Emacs fixnums.
5080 (Frecenter): Don't wrap around a line count if it is out of 'int'
5081 range; instead, treat it as an extreme value.
5082 (Fset_window_configuration, compare_window_configurations):
5083 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5084
6511acf2
PE
5085 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5086 that can exceed INT_MAX. Check that EMACS_INT value is in range
5087 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5088 (match_limit): Don't assume that a fixnum can fit in 'int'.
5089
6511acf2 5090 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5091 exceed INT_MAX.
5092
6511acf2 5093 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5094 (Fvertical_motion): Don't wrap around LINES values that don't fit
5095 in 'int'. Instead, treat them as extreme values. This is good
5096 enough for windows, which can't have more than INT_MAX lines anyway.
5097
fcb901a7
LMI
50982011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5099
0f2f6b6d
LMI
5100 * Require libxml/parser.h to avoid compilation warning.
5101
fcb901a7
LMI
5102 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5103
5104 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5105 since this reportedly can destroy thread storage.
5106
6e20a0d4
CY
51072011-08-30 Chong Yidong <cyd@stupidchicken.com>
5108
5109 * syntax.c (find_defun_start): Update all cache variables if
5110 exiting early (Bug#9401).
5111
148ae00e
EZ
51122011-08-30 Eli Zaretskii <eliz@gnu.org>
5113
f6cfbd8f
EZ
5114 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5115
148ae00e
EZ
5116 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5117 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5118 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5119
5120 * term.c (tty_append_glyph): New function.
5121 (produce_stretch_glyph): Static function and its prototype deleted.
5122
a66cfb1c
SM
5123 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5124 Add prototypes.
148ae00e 5125
c4a07a4c
PE
51262011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5127
5128 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5129 when checking :margin (Bug#9390).
5130 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5131 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5132 so that the name doesn't mislead. All uses changed.
5133
6bc8cd65
JB
51342011-08-28 Johan Bockgård <bojohan@gnu.org>
5135
5136 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5137 set_tty_hooks.
5138
dca4927e
EZ
51392011-08-27 Eli Zaretskii <eliz@gnu.org>
5140
5141 * xdisp.c (move_it_to): Don't bail out early when reaching
5142 position beyond to_charpos, if we are scanning backwards.
5143 (move_it_vertically_backward): When DY == 0, make sure we get to
5144 the first character in the line after the newline.
5145
f2cad773
PE
51462011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5147
5148 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5149 (ccl_driver): Do not generate an out-of-range pointer.
5150 (Fccl_execute_on_string): Remove unnecessary check for
5151 integer overflow, noted by Stefan Monnier in
5152 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5153 Remove a FIXME that didn't need fixing.
5154 Simplify the newly-introduced buffer reallocation code.
5155
0cae2cdb
JB
51562011-08-27 Juanma Barranquero <lekktu@gmail.com>
5157
5158 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5159
5fc295a4 51602011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5161
70c60eb2 5162 Integer and memory overflow issues (Bug#9196).
726e0ab1 5163
d31850da
PE
5164 * doc.c (get_doc_string): Rework so that
5165 get_doc_string_buffer_size is the actual buffer size, rather than
5166 being 1 less than the actual buffer size; this makes xpalloc more
5167 convenient.
5168
a69fbedb
PE
5169 * image.c (x_allocate_bitmap_record, cache_image):
5170 * xselect.c (Fx_register_dnd_atom):
5171 Simplify previous changes by using xpalloc.
5172
fe5c5d37
PE
5173 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5174 since either will do and ptrdiff_t is convenient with xpalloc.
5175
0065d054
PE
5176 * charset.c (charset_table_size)
5177 (struct charset_sort_data.priority): Now ptrdiff_t.
5178 (charset_compare): Don't overflow if priorities differ greatly.
5179 (Fsort_charsets): Don't assume list length fits in int.
5180 Check for size-calculation overflow when allocating sort data.
5181 (syms_of_charset): Allocate an initial charset table that is
5182 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5183
5184 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5185
5186 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5187 The actual value is always <= INT_MAX, and leaving it unsigned made
5188 overflow checking harder.
5189
5190 * dispextern.h (struct glyph_matrix.rows_allocated)
5191 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5192 with xpalloc. The values are still always <= INT_MAX.
5193
5194 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5195
5196 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5197 (SAFE_NALLOCA): New macro.
5198
5199 * region-cache.c (struct boundary.pos, find_cache_boundary)
5200 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5201 (set_cache_region, invalidate_region_cache)
5202 (revalidate_region_cache, know_region_cache, region_cache_forward)
5203 (region_cache_backward, pp_cache):
5204 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5205 so that ptrdiff_t * can be passed to xpalloc.
5206 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5207 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5208 (pp_cache): Don't assume cache_len fits in int.
5209 * region-cache.h: Adjust extern decls to match.
5210
5211 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5212 EMACS_INT, since either will do, for xpalloc.
5213
5214 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5215 (xnmalloc, xnrealloc, xpalloc): New functions.
5216
726e0ab1
PE
5217 * bidi.c (bidi_shelve_header_size): New constant.
5218 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5219 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5220
51f30bc5 5221 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5222 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5223 (overlay_strings):
5224 Don't update size of array until after memory allocation succeeds,
5225 because xmalloc/xrealloc may not return.
0065d054
PE
5226 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5227 now that we have proper integer overflow checking.
5228 (record_overlay_string, overlay_strings): Catch overflows when
5229 calculating size of overlay_str_buf.
726e0ab1 5230
0065d054
PE
5231 * callproc.c (Fcall_process): Check for size overflow when
5232 calculating size of args2.
5233 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5234 Normally we prefer signed values, but sticking with ptrdiff_t would
5235 require adding more-complicated checks.
726e0ab1
PE
5236
5237 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5238 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5239 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5240 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5241
5242 * character.c (Fstring): Check for size-calculation overflow.
5243
5244 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5245 unnecessary integer overflow. Check for size overflow.
5246 (encode_coding_object): Don't update size until xmalloc succeeds.
5247
5248 * composite.c (get_composition_id): Check for overflow in glyph
5249 length calculations.
5250
5251 Integer and memory overflow fixes for display code.
5252 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5253 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5254 (scrolling_window): Check for overflow in size calculations.
5255 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5256 Don't assume glyph table len fits in int.
5257 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5258 (row_table_size): Now ptrdiff_t, not int.
5259 (scrolling_window): Avoid overflow in size calculations.
5260 Don't update size until allocation succeeds.
5261 * fns.c (concat): Check for overflow in size calculations.
5262 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5263 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5264 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5265
5266 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5267 (get_doc_string): Check for size calculation overflow.
5268 Don't update size until allocation succeeds.
5269 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5270 EMACS_INT, where ptrdiff_t will do.
5271 (Fsubstitute_command_keys): Check for string overflow.
5272
5273 * editfns.c (set_time_zone_rule): Don't assume environment length
5274 fits in int.
5275 (message_length): Now ptrdiff_t, not int.
5276 (Fmessage_box): Don't update size until allocation succeeds.
5277 Don't assume message length fits in int.
5278 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5279
0065d054
PE
5280 * emacs.c (main): Do not reallocate argv, since there is a null at
5281 the end that can be overwritten, and this way there's no need to
5282 worry about size-calculation overflow.
5283 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5284
5285 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5286 alloc succeeds.
5287 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5288
5289 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5290 (x_set_scroll_bar_width, x_figure_window_size):
5291 Check for integer overflow.
5292 (x_set_alpha): Do not assume XINT fits in int.
5293
5294 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5295 This is for the members text_lines, text_cols, total_lines, total_cols,
5296 where the system imposes an 'int' limit.
5297
5298 * fringe.c (Fdefine_fringe_bitmap):
5299 Don't update size until alloc works.
5300
5301 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5302 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5303
5304 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5305 Check for size-calculation overflow.
5306 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5307 do, as we prefer signed integers.
5308 (id_to_widget.max_size, id_to_widget.used)
5309 (xg_store_widget_in_map, xg_remove_widget_from_map)
5310 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5311 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5312 Use and return ptrdiff_t, not int.
5313 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5314 * gtkutil.h: Change prototypes to match the above.
5315
5316 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5317 are duplicate now that they've been promoted to lisp.h.
5318 (x_allocate_bitmap_record, x_alloc_image_color)
5319 (make_image_cache, cache_image, xpm_load):
5320 Don't update size until alloc is done.
5321 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5322 (x_detect_edges):
3256efce 5323 Check for size calculation overflow.
726e0ab1
PE
5324 (ct_colors_allocated_max): New constant.
5325 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5326 overflow.
3256efce 5327
726e0ab1
PE
5328 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5329 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5330 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5331 Use ptrdiff_t, not int, to count maps.
5332 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5333 calculations. Don't update size until allocation succeeds.
5334 Redo calculations to avoid overflow.
726e0ab1
PE
5335 * keyboard.h: Change prototypes to match the above.
5336
5337 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5338 to count maps.
5339 (current_minor_maps): Check for size calculation overflow.
5340 * keymap.h: Change prototypes to match the above.
5341
5342 * lread.c (read1, init_obarray): Don't update size until alloc done.
5343
5344 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5345 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5346
726e0ab1
PE
5347 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5348 Now ptrdiff_t, not int.
5349 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5350 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5351
5352 * process.c (Fnetwork_interface_list): Check for overflow
5353 in size calculation.
5354
5355 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5356
5357 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5358 overflow. Don't bother calling xmalloc when xrealloc will do.
5359
5360 * search.c (Freplace_match): Check for size calculation overflow.
5361 (Fset_match_data): Don't assume list lengths fit in 'int'.
5362
5363 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5364 for command line length. Do not attempt to address one before the
5365 beginning of an array, as that's not portable.
5366
5367 * term.c (max_frame_lines): Remove; unused.
5368 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5369 not int.
5370 (encode_terminal_code, calculate_costs): Check for size
5371 calculation overflow.
5372 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5373 table lengths and related sizes. Don't update size until alloc
5374 done. Redo calculations to avoid overflow.
5375 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5376
5377 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5378 subtracting pointers.
5379 (gobble_line): Check for overflow more carefully. Don't update size
5380 until alloc done.
5381
5382 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5383 Don't update size until alloc done.
5384 Redo size calculations to avoid overflow.
5385 Check for size calculation overflow.
0065d054 5386 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5387
5388 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5389 Use ptrdiff_t, not int, for sizes.
5390 (store_mode_line_noprop_char): Don't update size until alloc done.
5391
0065d054
PE
5392 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5393 Use ptrdiff_t, not int, for sizes.
5394 (Finternal_make_lisp_face, cache_face):
5395 Check for size calculation overflow.
5396 (cache_face): Treat size calculation overflows as if they were
5397 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5398
5399 * xfns.c (x_encode_text, x_set_name_internal)
5400 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5401 sizes, since they can exceed INT_MAX in size. Check for size
5402 calculation overflow.
5403
0065d054
PE
5404 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5405 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5406 Don't update size until alloc done.
5407
0065d054 5408 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5409 as sprintf is limited to int lengths.
1d526e2f 5410
252c5ee1
PE
5411 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5412 (X_LONG_MIN): New macros.
864d7ce7
PE
5413 Use them to make the following changes clearer.
5414 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5415 This change doesn't affect the value now, but it may help remind
5416 future maintainers not to raise the value too much later.
5417 (SELECTION_QUANTUM): Remove, replacing with ...
5418 (selection_quantum): ... new function, which avoids overflow.
5419 All uses changed.
5420 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5421 assumption that selection length fits in 'int'.
5422 (x_reply_selection_request, x_handle_selection_request)
5423 (x_get_window_property, receive_incremental_selection)
5424 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5425 (lisp_data_to_selection_data, clean_local_selection_data):
5426 Use ptrdiff_t, not int, to record length of selection.
5427 (x_reply_selection_request, x_get_window_property)
5428 (receive_incremental_selection, x_property_data_to_lisp):
5429 Redo calculations to avoid overflow.
5430 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5431 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5432 something.
5433 (x_get_window_property, receive_incremental_selection)
5434 (lisp_data_to_selection_data, x_property_data_to_lisp):
5435 Check for size-calculation overflow.
5436 (x_get_window_property, receive_incremental_selection)
5437 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5438 Don't store size until memory allocation succeeds.
5439 (x_get_window_property): Plug memory leak on memory exhaustion.
5440 Don't double-block input; malloc is safe here. Don't assume 2**34
5441 - 4 fits in unsigned long. Add an xassert to check
5442 XGetWindowProperty overflow. Be more careful about overflow
5443 calculations, and distinguish size from memory overflow better.
5444 (receive_incremental_selection): When tracing, don't assume
5445 unsigned int is less than INT_MAX.
5446 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5447 harmful) conversions of unsigned short to int.
5448 (lisp_data_to_selection_data): Don't assume that integers
5449 in the range -65535 through -1 fit in an X unsigned short.
5450 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5451 result parameters unless successful. Rely on cons_to_unsigned
5452 to report problems with elements; the old code wasn't right anyway.
5453 (x_check_property_data): Check for int overflow; we cannot use
5454 a wider type due to X limits.
5455 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5456
726e0ab1 5457 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5458
0065d054
PE
5459 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5460 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5461 (x_color_cells): Don't store size until memory allocation succeeds.
5462 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5463 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5464 (x_term_init): Don't assume length fits in int (sprintf is limited
5465 to int size).
bc18e09d 5466
ebfa62c0
PE
5467 Use ptrdiff_t for composition IDs.
5468 * character.c (lisp_string_width):
5469 * composite.c (composition_table_size, n_compositions)
5470 (get_composition_id, composition_gstring_from_id):
5471 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5472 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5473 * window.c (Frecenter):
5474 Use ptrdiff_t, not int, for composition IDs.
5475 * composite.c (get_composition_id): Check for integer overflow.
5476 * composite.h: Adjust prototypes to match the above changes.
5477
d3411f89
PE
5478 Use ptrdiff_t for hash table indexes.
5479 * category.c (hash_get_category_set):
5480 * ccl.c (ccl_driver):
5481 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5482 * coding.c (coding_system_charset_list, detect_coding_system):
5483 * coding.h (struct coding_system.id):
5484 * composite.c (get_composition_id, gstring_lookup_cache):
5485 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5486 * image.c (xpm_get_color_table_h):
5487 * lisp.h (hash_lookup, hash_put):
5488 * minibuf.c (Ftest_completion):
5489 Use ptrdiff_t for hash table indexes, not int (which is too
5490 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5491 32-bit --with-wide-int hosts).
5492
e097a6fa
PE
5493 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5494 Add a FIXME comment about memory leaks.
5495 (syms_of_charset): Don't assume xmalloc returns.
5496
5637687f
PE
5497 Don't assume that stated character widths fit in int.
5498 * character.c (Fchar_width, c_string_width, lisp_string_width):
5499 * character.h (CHAR_WIDTH):
5500 * indent.c (MULTIBYTE_BYTES_WIDTH):
5501 Use sanitize_char_width to avoid undefined and/or bad behavior
5502 with outlandish widths.
a66cfb1c 5503 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5504 now that we have two such functions. All uses changed.
5505 (sanitize_char_width): New inline function.
5506
a2271ba2
PE
5507 Don't assume that tab-width fits in int.
5508 * character.h (sanitize_width): New inline function.
5509 (SANE_TAB_WIDTH): New macro.
5510 (ASCII_CHAR_WIDTH): Use it.
5511 * indent.c (sane_tab_width): Remove. All uses replaced by
5512 SANE_TAB_WIDTH (current_buffer).
5513 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5514
18c52557
PE
5515 * fileio.c: Integer overflow issues with file modes.
5516 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5517
caeeedc1
PE
5518 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5519 Remove unreachable code.
5520 (read_hex, load_charset_map_from_file): Check for integer overflow.
5521
6df6ae42 5522 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5523 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5524 (x_send_scroll_bar_event): Likewise. Check that the size does not
5525 exceed limits imposed by XClientMessageEvent, as well as the usual
5526 ptrdiff_t and size_t limits.
5527
b13995db
PE
5528 * keyboard.c: Overflow, signedness and related fixes.
5529 (make_lispy_movement): Use same integer type in forward decl
5530 that is used in the definition.
5531 (read_key_sequence, keyremap_step):
5532 Change bufsize argument back to int, undoing my 2011-03-30 change.
5533 We prefer signed types, and int is wide enough here.
5534 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5535 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5536 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5537 length, not size_t. Use ptrdiff_t for index, not int.
5538 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5539 possibility of integer overflow.
5540
13464394
PE
5541 Overflow, signedness and related fixes for images.
5542
5543 * dispextern.h (struct it.stack[0].u.image.image_id)
5544 (struct_it.image_id, struct image.id, struct image_cache.size)
5545 (struct image_cache.used, struct image_cache.ref_count):
5546 * gtkutil.c (update_frame_tool_bar):
5547 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5548 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5549 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5550 * nsmenu.m (update_frame_tool_bar):
5551 * xdisp.c (calc_pixel_width_or_height):
5552 * xfns.c (image_cache_refcount):
5553 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5554 on typical 64-bit hosts.
5555
5556 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5557 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5558 Omit unnecessary casts to int.
5559 (parse_image_spec): Check that integers fall into 'int' range
5560 when the callers expect that.
5561 (image_ascent): Redo ascent calculation to avoid int overflow.
5562 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5563 (lookup_image): Remove unnecessary tests.
5564 (xbm_image_p): Locals are now of int, not EMACS_INT,
5565 since parse_image_check makes sure they fit into int.
5566 (png_load, gif_load, svg_load_image):
5567 Prefer int to unsigned where either will do.
5568 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5569 old tiff_error_handler and tiff_warning_handler.
5570 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5571 stack buffer overflows. It uses only the features of vsnprintf
5572 that are common to both POSIX and native Microsoft.
5573 (tiff_error_handler, tiff_warning_handler): Use it.
5574 (tiff_load, gif_load, imagemagick_load_image):
5575 Don't assume :index value fits in 'int'.
5576 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5577 (imagemagick_load_image): Check that crop parameters fit into
5578 the integer types that MagickCropImage accepts. Don't assume
5579 Vimagemagick_render_type has a nonnegative value. Don't assume
5580 size_t fits in 'long'.
5581 (gs_load): Use printmax_t to print the widest integers possible.
5582 Check for integer overflow when computing image height and width.
5583
c11821d4
EZ
55842011-08-26 Eli Zaretskii <eliz@gnu.org>
5585
5586 * xdisp.c (redisplay_window): Don't force window start if point
5587 will be invisible in the resulting window. (Bug#9324)
5588
0c95fcf7
EZ
55892011-08-25 Eli Zaretskii <eliz@gnu.org>
5590
5591 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5592 the display spec is of the form `(space ...)'.
5593 (handle_display_spec): Return the value returned by
5594 handle_single_display_spec, not just 1 or zero.
5595 (handle_single_display_spec): If the display spec is of the form
5596 `(space ...)', and specifies display in the text area, return 2
5597 rather than 1.
fee65a97 5598 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5599 accurately, and prefer exact match for point under bidi.
5600 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5601
5602 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5603 into disp_prop; all users changed.
5604
5605 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5606 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5607 for the text covered by the display property.
5608
e4ed06f1
CY
56092011-08-25 Chong Yidong <cyd@stupidchicken.com>
5610
5611 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5612 Change return value to nil.
5613 (Frecord_buffer): Delete unused function.
5614
f67cdd7f
EZ
56152011-08-24 Eli Zaretskii <eliz@gnu.org>
5616
5980d4c6
EZ
5617 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5618 buffers, return left-to-right.
8610fe8b
EZ
5619 (set_cursor_from_row): Consider candidate row a win if its glyph
5620 represents a newline and point is on that newline. Fixes cursor
5621 positioning on the newline at EOL of R2L text within L2R
5622 paragraph, and vice versa.
5623 (try_cursor_movement): Check continued rows, in addition to
5624 continuation rows. Fixes unwarranted scroll when point enters a
5625 continued line of R2L text within an L2R paragraph, or vice versa.
5626 (cursor_row_p): Consider the case of point being equal to
5627 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5628 from the end of a short line to the beginning of a continued line
5629 of R2L text within L2R paragraph.
5630 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5631 composed characters.
5980d4c6 5632
f67cdd7f
EZ
5633 * bidi.c (bidi_check_type): Use xassert.
5634 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5635 members.
5636
bca633fb
EZ
56372011-08-23 Eli Zaretskii <eliz@gnu.org>
5638
5639 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5640 a character.
5641
4a5885a7
CY
56422011-08-23 Chong Yidong <cyd@stupidchicken.com>
5643
5644 * nsfont.m (ns_otf_to_script): Fix typo.
5645
0902a04e
KH
56462011-08-22 Kenichi Handa <handa@m17n.org>
5647
5648 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5649 extra slot even if the purpose is char-code-property-table.
5650
1a2e6670
EZ
56512011-08-23 Eli Zaretskii <eliz@gnu.org>
5652
8ddde651
EZ
5653 * xdisp.c (redisplay_window): When computing centering_position,
5654 account for the height of the header line. (Bug#8874)
5655
425cc014
EZ
5656 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5657 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5658 candidate is selected by the mouse, and that candidate has a
5659 composed character under the mouse.
5660
1a2e6670
EZ
5661 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5662 coordinates reported by pos-visible-in-window-p for a composed
5663 character in column zero.
5664
8b76d6f8
SM
56652011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5666
5667 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5668
dac347dd
EZ
56692011-08-22 Eli Zaretskii <eliz@gnu.org>
5670
5671 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5672 consider it a hit if to_charpos is anywhere in the range of the
5673 composed buffer positions.
5674
e013fb34
CY
56752011-08-22 Chong Yidong <cyd@stupidchicken.com>
5676
5677 * image.c (gif_load): Don't assume that each subimage has the same
5678 dimensions as the base image. Handle disposal method that is
5679 "undefined" by the gif spec (Bug#9335).
5680
bd1ba3e8
CY
56812011-08-20 Chong Yidong <cyd@stupidchicken.com>
5682
5683 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5684 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5685
54a1215b
EZ
56862011-08-19 Eli Zaretskii <eliz@gnu.org>
5687
823564e5
EZ
5688 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5689 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5690 from an Org mode buffer to a Speedbar frame.
5691
54a1215b
EZ
5692 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5693 a composition, take its buffer position from IT->cmp_it.charpos.
5694 Fixes cursor positioning at the beginning of a line that begins
5695 with a composed character.
5696
9778ebcc
EZ
56972011-08-18 Eli Zaretskii <eliz@gnu.org>
5698
0be6ee06
EZ
5699 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5700 character bidirectional type, use STRONG_L instead. Fixes crashes
5701 in a buffer produced by `describe-categories'.
5702
9778ebcc
EZ
5703 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5704 members before the level stack, so they would be saved and
5705 restored when copying iterator state. Fixes incorrect reordering
5706 around TABs covered by display properties.
5707
156bffbe
AS
57082011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5709
6b02f655 5710 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5711
72ad093b
CY
57122011-08-17 Chong Yidong <cyd@stupidchicken.com>
5713
5714 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5715 (internal_condition_case_2, internal_condition_case_n):
5716 Remove unnecessary aborts (Bug#9081).
72ad093b 5717
35774242
EZ
57182011-08-17 Eli Zaretskii <eliz@gnu.org>
5719
5720 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5721 has no `load' handler, try opening the file locally. (Bug#9311)
5722
db76dd85
KB
57232011-08-16 Ken Brown <kbrown@cornell.edu>
5724
5725 * gmalloc.c: Expand comment.
5726
b215eee5
EZ
57272011-08-16 Eli Zaretskii <eliz@gnu.org>
5728
5729 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5730 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5731
a4579d33
KB
57322011-08-16 Ken Brown <kbrown@cornell.edu>
5733
5734 Fix memory allocation problems in Cygwin build (Bug#9273).
5735
5736 * unexcw.c ( __malloc_initialized): Declare external variable.
5737 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5738
8b76d6f8
SM
5739 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5740 New variables.
a4579d33
KB
5741 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5742 dumped emacs.
5743 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5744 in the static heap.
5745 [CYGWIN] (special_realloc): New function.
5746 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5747 requests to realloc storage in the static heap.
5748
3ebec551
PE
57492011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5750
5751 * bidi.c (bidi_initialize): Remove unused local.
5752
9fd8be00
EZ
57532011-08-15 Eli Zaretskii <eliz@gnu.org>
5754
6b02f655
SM
5755 * bidimirror.h:
5756 * biditype.h: Remove file.
5757 * makefile.w32-in ($(BLD)/bidi.$(O)):
5758 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5759
5760 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5761
5762 * chartab.c: Improve commentary for the uniprop_table API.
5763
32413314
EZ
5764 * bidi.c (bidi_paragraph_init): Support zero value of
5765 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5766 (bidi_initialize): Use uniprop_table instead of including
5767 biditype.h and bidimirror.h.
32413314 5768
9fd8be00
EZ
5769 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5770 coordinates of the iterator when restoring from ppos_it.
5771 (Bug#9296)
5772
5cf2b69b
KH
57732011-08-14 Kenichi Handa <handa@m17n.org>
5774
5775 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5776 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5777
daf17d00
EZ
57782011-08-14 Eli Zaretskii <eliz@gnu.org>
5779
5780 * xdisp.c (move_it_in_display_line_to): Don't invoke
5781 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5782 ppos_it. Fixes vertical cursor motion when line beginning is
5783 covered by an image. (Bug#9296)
5784
08e3161a
JD
57852011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5786
5787 * nsterm.h (ns_run_ascript): Declare.
5788 (NSAPP_DATA2_RUNASSCRIPT): Define.
5789
5790 * nsfns.m (as_script, as_result, as_status): New static variables.
5791 (ns_run_ascript): New function.
5e617bc2 5792 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5793 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5794 the event loop. Get status from as_status (Bug#7276).
5795
5796 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5797 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5798 the event loop (Bug#7276).
5799
a3720aa2
AS
58002011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5801
5802 * gnutls.c (QCgnutls_bootprop_priority)
5803 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5804 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5805 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5806 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5807 (QCgnutls_bootprop_verify_hostname_error)
5808 (QCgnutls_bootprop_callbacks_verify): Rename from
5809 Qgnutls_bootprop_..., all uses changed.
5810
5811 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5812 uses changed.
5813
0a0d27fb
PE
58142011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5815
19d5c50c
PE
5816 * xfaces.c (Qframe_set_background_mode): Now static.
5817 * dispextern.h (Qframe_set_background_mode): Remove decl.
5818
0a0d27fb
PE
5819 * process.c (Fnetwork_interface_info): Declare local only if needed.
5820
377538cb
JD
58212011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5822
5823 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5824 (Fnetwork_interface_list): Allocate in increments of bytes instead
5825 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5826 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5827 sockaddr.
5828 (struct ifflag_def): notrailers is smart on OSX.
5829 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5830 Get hardware address with getifaddrs if available.
5831
08fff70c
EZ
58322011-08-12 Eli Zaretskii <eliz@gnu.org>
5833
5834 * xdisp.c (iterate_out_of_display_property): xassert that
5835 IT->position is set to within IT->object's boundaries. Break from
5836 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5837 when IT->position is set up wrongly due to some bug.
5838 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5839 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5840 entry. Force push_it to save on the stack the current
5841 buffer/string position, to be restored by pop_it. Fix flags in
5842 the iterator structure wrt the object coming from a display
5843 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5844 properties. (Bug#9284)
5845
7be1c708 58462011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5847
7be1c708
CY
5848 * fontset.c (fontset_get_font_group): Add proper type checks.
5849 (Bug#9172)
aac0c6e3 5850
7be1c708 58512011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5852
7be1c708
CY
5853 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5854 and LC_VERSION_MIN_MACOSX.
5855 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5856 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5857
97bb72a6
EZ
58582011-08-08 Eli Zaretskii <eliz@gnu.org>
5859
5860 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5861 no-display-properties-and-no-overlays under bidi display.
5862 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5863 properties and overlays.
97bb72a6 5864
d5617611
CY
58652011-08-08 Chong Yidong <cyd@stupidchicken.com>
5866
37e11a63
CY
5867 * editfns.c (Fset_time_zone_rule): Document relationship with the
5868 setenv function.
5869
d5617611
CY
5870 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5871 the font entity extracted from the cache (Bug#8109).
5872
58872834
CY
58732011-08-07 Chong Yidong <cyd@stupidchicken.com>
5874
5875 * composite.c (autocmp_chars): Don't reset point. That is done by
5876 restore_point_unwind (Bug#5984).
5877
75bfc667
JL
58782011-08-07 Juri Linkov <juri@jurta.org>
5879
5880 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5881 to show the arg `TIME' instead of `TIMEVAL'.
5882
d1410150
EZ
58832011-08-06 Eli Zaretskii <eliz@gnu.org>
5884
5885 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5886 display property strides EOL and includes a newline, as in
5887 longlines-mode. (Bug#9254)
75b771e4
EZ
5888 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5889 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5890
5891 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5892 is non-zero, even if the data buffer is NULL. Fixes a crash in
5893 vertical-motion with longlines-mode. (Bug#9254)
5894
35928349
EZ
58952011-08-05 Eli Zaretskii <eliz@gnu.org>
5896
ec7cc85b
EZ
5897 * bidi.c <bidi_cache_total_alloc>: Now static.
5898 (bidi_initialize): Initialize bidi_cache_total_alloc.
5899
8b76d6f8 5900 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5901 cache. (Bug#9221)
5902
5903 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5904 amount allocated this far in `bidi_cache_total_alloc'.
5905 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5906 non-zero, only free the data buffer without restoring the cache
5907 contents. All callers changed.
5908
5909 * dispextern.h (bidi_unshelve_cache): Update prototype.
5910
5911 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5912 (move_it_in_display_line, move_it_to)
5913 (move_it_vertically_backward, move_it_by_lines): Replace the call
5914 to xfree to an equivalent call to bidi_unshelve_cache.
5915 (move_it_in_display_line_to): Fix logic of returning
412b6358 5916 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5917
e2e2423b
EZ
59182011-08-05 Eli Zaretskii <eliz@gnu.org>
5919
5920 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5921 came from a string character with a `cursor' property. (Bug#9229)
5922
ae9e757a
JD
59232011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5924
5925 * Makefile.in (LIB_PTHREAD): New variable.
5926 (LIBES): Add LIB_PTHREAD (Bug#9216).
5927
5928 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5929 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5930
213bd7f2
AS
59312011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5932
6b02f655 5933 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5934
99aaf75f
JD
59352011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5936
5937 * xterm.c (x_find_topmost_parent): New function.
5938 (x_set_frame_alpha): Find topmost parent window with
5939 x_find_topmost_parent and set the property there also (bug#9181).
5940 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5941
c74e9d86
PE
59422011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5943
5944 * callproc.c (Fcall_process): Avoid vfork clobbering
5945 the local vars buffer, coding_systems, current_dir.
5946
640c8776
SM
59472011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5948
5949 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5950
f26d0e4c
PE
59512011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5952
8a10d76c
PE
5953 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5954 so that it is not optimized away.
5955
f26d0e4c
PE
5956 * xdisp.c (compute_display_string_pos): Remove unused local.
5957
55439c61
EZ
59582011-08-02 Eli Zaretskii <eliz@gnu.org>
5959
5960 Fix slow cursor motion and scrolling in large buffers with
5961 selective display, like Org Mode buffers. (Bug#9218)
5962
5963 * dispextern.h (struct bidi_it): New member disp_prop_p.
5964
5965 * xdisp.c: Remove one-slot cache of display string positions.
5966 (compute_display_string_pos): Accept an additional argument
5e617bc2 5967 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5968 for a display string or property. If found, set DISP_PROP_P
5969 non-zero.
5970
5971 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5972 DISP_PROP_P, and pass it to compute_display_string_pos.
5973 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5974 non-zero. All callers of bidi_fetch_char changed.
5975
fb33fa43
SM
59762011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5977
5978 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5979
b099e063
DM
59802010-12-03 Don March <don@ohspite.net>
5981
5982 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5983 last character M-[char] is translated to ESC [char] (bug#7541).
5984
5cc7f7af
KH
59852011-08-02 Kenichi Handa <handa@m17n.org>
5986
d0fffa3f 5987 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5988
5989 * chartab.c (uniprop_table): Make it non-static.
5990
525d5e6e
EZ
59912011-08-01 Eli Zaretskii <eliz@gnu.org>
5992
5993 * xdisp.c (forward_to_next_line_start): Accept additional argument
5994 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5995 on the newline.
5996 (reseat_at_next_visible_line_start): Use the bidi iterator state
5997 returned by forward_to_next_line_start to restore the state of
5998 it->bidi_it after backing up to previous newline. (Bug#9212)
5999
31011111
AS
60002011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6001
6002 * regex.c (re_comp): Protoize.
6003 (re_exec): Fix return type.
6004 (regexec): Fix type of `ret'. (Bug#9203)
6005
476371c4
PE
60062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6007
e5d76069
PE
6008 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6009 This is needed if max-image-size is a floating-point number.
6010
9a79b20c
AS
60112011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6012
6013 * print.c (print_object): Print empty symbol as ##.
6014
6015 * lread.c (read1): Read ## as empty symbol.
6016
d8c2fa78
AA
60172011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6018
6019 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6020 setting frame foreground color (Bug#9175).
6021 (x_set_background_color): Likewise.
6022
ffe57a7a
AA
6023 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6024 contents (Bug#9176).
6025 (EmacsTooltip -init): Remove bezels and add shadows to
6026 tooltip windows.
6027
bf3492a5
AA
6028 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6029 or scroll bar (Bug#8470).
6030
d55e9c53
AA
6031 * nsfont.m (nsfont_open): Remove assignment to voffset and
6032 unnecessary vars hshink, expand, hd, full_height, min_height.
6033 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6034
6035 * nsterm.h (nsfont_info): Remove voffset field.
6036
d8c2fa78 60372011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6038
6039 Implement strike-through and overline on NextStep (Bug#8863).
6040
6041 * nsfont.m (nsfont_open): Use underline position provided by font,
6042 instead of hard-coded value of 2.
6043 (nsfont_draw): Call ns_draw_text_decoration instead.
6044
6045 * nsterm.h: Add declaration for ns_draw_text_decoration.
6046
6047 * nsterm.m (ns_draw_text_decoration): New function for drawing
6048 underline, overline, and strike-through.
6049 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6050 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6051 accommodate underlining, etc.
4843aac3 6052
4cc60b9b
EZ
60532011-07-28 Eli Zaretskii <eliz@gnu.org>
6054
bc7ece87
EZ
6055 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6056 default.
4cc60b9b 6057
476371c4
PE
60582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6059
66606eea
PE
6060 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6061 Without this fix, if a signal arrives just after memory fills up,
6062 'malloc' might be invoked reentrantly.
6063
476371c4
PE
6064 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6065 In other words, assume that every image size is allowed, on non-X
6066 hosts. This assumption is probably wrong, but it lets Emacs compile.
6067
f3fcc40d
AS
60682011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6069
6070 * regex.c (re_iswctype): Convert return values to boolean.
6071
350c992f
EZ
60722011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6073
6074 * xdisp.c (compute_display_string_pos): Don't use cached display
6075 string position if the buffer had its restriction changed.
6076 (Bug#9184)
6077
5266b4bb
PE
60782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6079
6080 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6081
2573a837 60822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6083
41f55ccd 6084 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6085
39e378da
PE
6086 * bidi.c: Integer size and overflow fixes.
6087 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6088 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6089 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6090 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6091 (bidi_find_other_level_edge):
6092 Use ptrdiff_t instead of EMACS_INT where either will do.
6093 This works better on 32-bit hosts configured --with-wide-int.
6094 (bidi_cache_ensure_space): Check for size-calculation overflow.
6095 Use % rather than repeated addition, for better worst-case speed.
6096 Don't set bidi_cache_size until after xrealloc returns, because it
6097 might not return.
6098 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6099 (bidi_cache_ensure_space): Also check that the bidi cache size
6100 does not exceed that of the largest Lisp string or buffer. See Eli
6101 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6102
5e927815
PE
6103 * alloc.c (__malloc_size_t): Remove.
6104 All uses replaced by size_t. See Andreas Schwab's note
6105 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6106
ca4aa935
PE
6107 * image.c: Improve checking for integer overflow.
6108 (check_image_size): Assume that f is nonnull, since
6109 it is always nonnull in practice. This is one less thing to
6110 worry about when checking for integer overflow later.
6111 (x_check_image_size): New function, which checks for integer
6112 overflow issues inside X.
6113 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6114 This removes the need for a memory_full check.
6115 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6116 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6117 (xbm_read_bitmap_data): Change locals back to 'int', since
6118 their values must fit in 'int'.
6119 (xpm_load_image, png_load, tiff_load):
6120 Invoke x_create_x_image_and_pixmap earlier,
6121 to avoid much needless work if the image is too large.
6122 (tiff_load): Treat overly large images as if
6123 x_create_x_image_and_pixmap failed, not as malloc failures.
6124 (gs_load): Use x_check_image_size.
6125
5f8f9cc2
PE
6126 * gtkutil.c: Omit integer casts.
6127 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6128 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6129
5adf60bc
PE
6130 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6131
c8907a93
PE
6132 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6133 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6134 would wrongly return t on a 64-bit host.
6135
e3c25c68
PE
6136 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6137 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6138 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6139 and therefore cause GCC to emit a bogus diagnostic in some cases.
6140
3f791afe
PE
6141 * image.c: Integer signedness and overflow and related fixes.
6142 This is not an exhaustive set of fixes, but it's time to
6143 record what I've got.
6144 (lookup_pixel_color, check_image_size): Remove redundant decls.
6145 (check_image_size): Don't assume that arbitrary EMACS_INT values
6146 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6147 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6148 (tiff_load, imagemagick_load_image):
6149 Check for overflow in size calculations.
6150 (x_create_x_image_and_pixmap): Remove unnecessary test for
6151 xmalloc returning NULL; that can't happen.
6152 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6153 (xpm_color_bucket): Use better integer hashing function.
6154 (xpm_cache_color): Don't possibly over-allocate memory.
6155 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6156 (gif_memory_source):
6157 Use ptrdiff_t, not int or size_t, to record sizes.
6158 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6159 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6160 either works, as we prefer signed integers.
6161 (tiff_read_from_memory, tiff_write_from_memory):
6162 Return tsize_t, not size_t, since that's what the TIFF API wants.
6163 (tiff_read_from_memory): Don't fail simply because the read would
6164 go past EOF; instead, return a short read.
6165 (tiff_load): Omit no-longer-needed casts.
6166 (Fimagemagick_types): Don't assume size fits into 'int'.
6167
3cc5a532
PE
6168 Improve hashing quality when configured --with-wide-int.
6169 * fns.c (hash_string): New function, taken from sxhash_string.
6170 Do not discard information about ASCII character case; this
6171 discarding is no longer needed.
6172 (sxhash-string): Use it. Change sig to match it. Caller changed.
6173 * lisp.h: Declare it.
6174 * lread.c (hash_string): Remove, since we now use fns.c's version.
6175 The fns.c version returns a wider integer if --with-wide-int is
6176 specified, so this should help the quality of the hashing a bit.
6177
b312a492
PE
6178 * emacs.c: Integer overflow minor fix.
6179 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6180 Define only if GNU_LINUX.
6181 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6182
dfd153ae
PE
6183 * dispnew.c: Integer signedness and overflow fixes.
6184 Remove unnecessary forward decls, that were a maintenance hassle.
6185 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6186 All uses changed.
6187 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6188 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6189 (prepare_desired_row, line_draw_cost):
6190 Use int, not unsigned, where either works.
6191 (save_current_matrix, restore_current_matrix):
6192 Use ptrdiff_t, not size_t, where either works.
6193 (init_display): Check for overflow more accurately, and without
6194 relying on undefined behavior.
6195
a81d11a3
PE
6196 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6197 Remove, replacing with the new symbols in lisp.h. All uses changed.
6198 * fileio.c (make_temp_name):
6199 * filelock.c (lock_file_1, lock_file):
6200 * xdisp.c (message_dolog):
6201 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6202 Use pMd etc. instead.
6203 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6204 replacing the pWIDE etc. symbols removed from editfns.c.
6205
3300e6fd
PE
6206 * keyboard.h (num_input_events): Now uintmax_t.
6207 This is (very slightly) less likely to mess up due to wraparound.
6208 All uses changed.
6209
fd05c7e9
PE
6210 * buffer.c: Integer signedness fixes.
6211 (alloc_buffer_text, enlarge_buffer_text):
6212 Use ptrdiff_t rather than size_t when either will do, as we prefer
6213 signed integers.
6214
903fe15d
PE
6215 * alloc.c: Integer signedness and overflow fixes.
6216 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6217 (__malloc_size_t): Default to size_t, not to int.
6218 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6219 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6220 Prefer ptrdiff_t to size_t when either would do, as we prefer
6221 signed integers.
6222 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6223 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6224 Now const. Initialize with values that are in range even if char
6225 is signed.
6226 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6227 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6228 These functions do the right thing with sizes > 2**32.
6229 (check_depth): Now ptrdiff_t, not int.
6230 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6231 Adjust to new way of storing sizes. Check for size overflow bugs
6232 in rest of code.
6233 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6234 slightly wrong anyway, as it missed one instance of
6235 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6236 (refill_memory_reserve): Omit needless cast to size_t.
6237 (mark_object_loop_halt): Mark as externally visible.
6238
ac82cc6a
PE
6239 * xselect.c: Integer signedness and overflow fixes.
6240 (Fx_register_dnd_atom, x_handle_dnd_message):
6241 Use ptrdiff_t, not size_t, since we prefer signed.
6242 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6243 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6244 x_dnd_atoms_size and x_dnd_atoms_length.
6245
c2d1e36d
PE
6246 * doprnt.c: Prefer signed to unsigned when either works.
6247 * eval.c (verror):
6248 * doprnt.c (doprnt):
6249 * lisp.h (doprnt):
6250 * xdisp.c (vmessage):
6251 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6252 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6253 prefer signed arithmetic to avoid comparison confusion.
6254 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6255 but is a bit tricky.
6256
0e926e56
PE
6257 Assume freestanding C89 headers, string.h, stdlib.h.
6258 * data.c, doprnt.c, floatfns.c, print.c:
6259 Include float.h unconditionally.
6260 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6261 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6262 * regex.c: Likewise for stddef.h, string.h.
6263 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6264 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6265 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6266 (STDC_HEADERS): Remove obsolete defines.
6267 * sysdep.c: Include limits.h unconditionally.
6268
9cfdb3ec
PE
6269 Assume support for memcmp, memcpy, memmove, memset.
6270 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6271 * regex.c (memcmp, memcpy):
6272 Remove; we assume C89 now.
6273
6274 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6275 (__malloc_safe_bcopy): Remove; no longer needed.
6276
cf950e6b 6277 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6278 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6279 well either way, and we prefer signed to unsigned.
6280
dbf38e02
LMI
62812011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6282
6283 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6284 closes the connection while we're reading (bug#9182).
6285
d6f0886c 62862011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6287
d6f0886c
JD
6288 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6289 are specified (Bug#9168).
24e0f6b1 6290
2eb1f9e6
PE
62912011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6292
6293 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6294 Found by GCC static checking and --with-wide-int on a 32-bit host.
6295
22381272 62962011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6297
6298 * xdisp.c (compute_display_string_pos): Fix logic of caching
6299 previous display string position. Initialize cached_prev_pos to
6300 -1. Fixes slow-down at the beginning of a buffer.
6301
f25e39b4
EZ
63022011-07-24 Eli Zaretskii <eliz@gnu.org>
6303
6304 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6305 for attrs[LFACE_FONTSET_INDEX].
6306
04c4b52e
PE
63072011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6308
6309 * xml.c (parse_region): Remove unused local
6310 that was recently introduced.
6311
c1734fbd
EZ
63122011-07-23 Eli Zaretskii <eliz@gnu.org>
6313
be18c5a5
EZ
6314 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6315 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6316
c1734fbd
EZ
6317 * xdisp.c (move_it_in_display_line_to): Record the best matching
6318 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6319 exit if none of the characters scanned was an exact match.
6320 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6321 when exact match is impossible due to invisible text, and the
6322 lines are truncated.
6323
a258d627
JD
63242011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6325
6326 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6327 for OSX >= 10.7.
6328
b6d5a689
EZ
63292011-07-22 Eli Zaretskii <eliz@gnu.org>
6330
0f74f785
EZ
6331 Fix a significant slow-down of cursor motion with C-n, C-p,
6332 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6333 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6334 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6335 (next_element_from_buffer): Call compute_stop_pos_backwards to
6336 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6337 base_level_stop.
6338 (reseat): Don't look for prev_stop, as that could mean a very long
6339 run.
6340 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6341 <cached_disp_overlay_modiff>: Cache for last found display string
6342 position.
551918c1 6343 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6344 about the same buffer in the same area of character positions, and
6345 the buffer wasn't changed since the time the display string
6346 position was cached.
551918c1 6347
b2d0c91a
EZ
63482011-07-22 Eli Zaretskii <eliz@gnu.org>
6349
6350 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6351 is an integer, which is important for empty lines. (Bug#9149)
6352
043604ee
CY
63532011-07-22 Chong Yidong <cyd@stupidchicken.com>
6354
6355 * frame.c (Fmodify_frame_parameters): In tty case, update the
6356 default face if necessary (Bug#4238).
6357
da4adb04
CY
63582011-07-21 Chong Yidong <cyd@stupidchicken.com>
6359
6360 * editfns.c (Fstring_to_char): No need to explain what a character
6361 is in the docstring (Bug#6576).
6362
9abd0532
LMI
63632011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6364
6365 * xml.c (parse_region): Make sure we always return a tree.
6366
36881d16
HK
63672011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6368
6369 * xml.c (parse_region): If a document contains only comments,
6370 return that, too.
6371
1e98674d
LMI
63722011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6373
6374 * xml.c (make_dom): Return comments, too.
6375
590bd467
PE
63762011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6377
6378 Port to OpenBSD.
6379 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6380 and the surrounding thread.
6381 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6382 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6383 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6384 timer goes off.
6385 * s/openbsd.h (BROKEN_SIGIO): Define.
6386 * unexelf.c (unexec) [__OpenBSD__]:
6387 Don't update the .mdebug section of the Alpha COFF symbol table.
6388
f41628b2
LMI
63892011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6390
6391 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6392 (bug#8460).
6393
b59b67c5
PE
63942011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6395
15e3a074
PE
6396 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6397 This fixes some race conditions on the permissions of any newly
6398 created file.
6399
41bed37d
PE
6400 * alloc.c (valid_pointer_p): Use pipe, not open.
6401 This fixes some permissions issues when debugging.
6402
b59b67c5
PE
6403 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6404 If fchown fails to set both uid and gid, try to set just gid,
6405 as that is sometimes allowed. Adjust the file's mode to eliminate
6406 setuid or setgid bits that are inappropriate if fchown fails.
6407
925a6be7
SM
64082011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6409
6410 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6411 to compare Lisp_Objects.
6412 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6413 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6414 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6415
52968808
AS
64162011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6417
0a6a104b
AS
6418 * lread.c (read_integer): Unread even EOF character.
6419 (read1): Likewise. Properly record start position of symbol.
6420
52968808
AS
6421 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6422 symbol character follows.
6423
9e381cdd
PE
64242011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6425
6426 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6427 This works around a problem with the previous change to Fcopy_file.
6428 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6429 and without this change, GCC might complain about discarding
6430 fchown's return value.
6431
b5641435
JB
64322011-07-16 Juanma Barranquero <lekktu@gmail.com>
6433
6434 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6435
a8031457
PE
64362011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6437
6438 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6439
dd889327
LMI
64402011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6441
750c33f7
LMI
6442 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6443 it's used from the C level.
6444
dd889327
LMI
6445 * process.c: Use the same condition for POLL_FOR_INPUT in both
6446 keyboard.c and process.c (bug#1858).
6447
87e86684
LM
64482011-07-09 Lawrence Mitchell <wence@gmx.li>
6449
6450 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6451 (Fgnutls_boot): Use it.
6452
64348f40
AS
64532011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6454
6455 * doc.c (Fsubstitute_command_keys): Revert last change.
6456
1d698799
LMI
64572011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6458
f863868c
LMI
6459 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6460 quotes the next character, and doesn't affect other longer
6461 sequences (bug#8935).
6462
1d698799
LMI
6463 * lread.c (syms_of_lread): Clarify that is isn't only
6464 `eval-buffer' and `eval-defun' that's affected by
6465 `lexical-binding' (bug#8460).
6466
aa4b6df6
EZ
64672011-07-15 Eli Zaretskii <eliz@gnu.org>
6468
6469 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6470 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6471
5d856da6
PE
64722011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6473
ad6042bb
PE
6474 Fix minor problems found by static checking.
6475 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6476 (elsz): Now a signed constant, not a size_t var. We prefer signed
6477 types to unsigned, to avoid integer comparison confusion. Without
6478 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6479 "cannot optimize loop, the loop counter may overflow", a symptom
6480 of the confusion.
f00bbb22 6481 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6482 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6483
6468f31c
LMI
64842011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6485
49080b10
LMI
6486 * search.c (Fre_search_backward): Mention `case-fold-search' in
6487 all the re_search_* functions (bug#8138).
6488
6468f31c
LMI
6489 * keyboard.c (Fopen_dribble_file): Document when the file is
6490 closed (bug#8056).
6491
c965adc5
EZ
64922011-07-14 Eli Zaretskii <eliz@gnu.org>
6493
df9733bf
EZ
6494 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6495 bidi_cache_idx.
6496
0bb23927
EZ
6497 Support bidi reordering of display and overlay strings.
6498 * xdisp.c (compute_display_string_pos)
6499 (compute_display_string_end): Accept additional argument STRING.
6500 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6501 (reseat_to_string): Initialize bidi_it->string.s and
6502 bidi_it->string.schars.
6503 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6504 NULL (avoids a crash in bidi_paragraph_init).
6505 Initialize itb.string.lstring.
0bb23927
EZ
6506 (init_iterator): Call bidi_init_it only of a valid
6507 buffer position was specified. Initialize paragraph_embedding to
6508 L2R.
6509 (reseat_to_string): Initialize the bidi iterator.
6510 (display_string): If we need to ignore text properties of
6511 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6512 original value of -1 will not work with bidi.)
6513 (compute_display_string_pos): First arg is now struct
6514 `text_pos *'; all callers changed. Support display properties on
6515 Lisp strings.
6516 (compute_display_string_end): Support display properties on Lisp
6517 strings.
6518 (init_iterator, reseat_1, reseat_to_string): Initialize the
6519 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6520 when iterating on a string not from display properties).
640c8776
SM
6521 (compute_display_string_pos, compute_display_string_end):
6522 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6523 arrow keys.
6524 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6525 base_level_stop; instead, set base_level_stop to BEGV.
6526 Fixes crashes in vertical-motion.
0bb23927
EZ
6527 (next_element_from_buffer): Improve commentary for when
6528 the iterator is before prev_stop.
6529 (init_iterator): Initialize bidi_p from the default value of
6530 bidi-display-reordering, not from buffer-local value. Use the
6531 buffer-local value only if initializing for buffer iteration.
6532 (handle_invisible_prop): Support invisible properties on strings
6533 that are being bidi-reordered.
6534 (set_iterator_to_next): Support bidi reordering of C strings and
6535 Lisp strings.
6536 (next_element_from_string): Support bidi reordering of Lisp
6537 strings.
6538 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6539 (display_string): Support display of R2L glyph rows.
6540 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6541 (init_iterator): Don't initialize it->bidi_p for strings
6542 here.
6543 (reseat_to_string): Initialize it->bidi_p for strings here.
6544 (next_element_from_string, next_element_from_c_string)
6545 (next_element_from_buffer): Add xassert's for correspondence
6546 between IT's object being iterated and it->bidi_it.string
6547 structure.
6548 (face_before_or_after_it_pos): Support bidi iteration.
6549 (next_element_from_c_string): Handle the case of the first string
6550 character that is not the first one in the visual order.
6551 (get_visually_first_element): New function, refactored from common
6552 parts of next_element_from_buffer, next_element_from_string, and
6553 next_element_from_c_string.
6554 (tool_bar_lines_needed, redisplay_tool_bar)
6555 (display_menu_bar): Force left-to-right direction. Add a FIXME
6556 comment for making that be controlled by a user option.
6557 (push_it, pop_it): Save and restore the state of the
6558 bidi iterator. Save and restore the bidi_p flag.
6559 (pop_it): Iterate out of display property for string iteration as
6560 well.
6561 (iterate_out_of_display_property): Support iteration over strings.
6562 (handle_single_display_spec): Set up it->bidi_it for iteration
6563 over a display string, and call bidi_init_it.
6564 (handle_single_display_spec, next_overlay_string)
6565 (get_overlay_strings_1, push_display_prop): Set up the bidi
6566 iterator for displaying display or overlay strings.
6567 (forward_to_next_line_start): Don't use the shortcut if
6568 bidi-iterating.
6569 (back_to_previous_visible_line_start): If handle_display_prop
6570 pushed the iterator stack, restore the internal state of the bidi
6571 iterator by calling bidi_pop_it same number of times.
6572 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6573 and we are bidi-iterating, don't decrement the iterator position;
6574 instead, set the first_elt flag in the bidi iterator, to produce
6575 the same effect.
6576 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6577 (push_display_prop): xassert that we are iterating a buffer.
6578 (push_it, pop_it): Save and restore paragraph_embedding member.
6579 (handle_single_display_spec, next_overlay_string)
6580 (get_overlay_strings_1, reseat_1, reseat_to_string)
6581 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6582 correctly. Don't assume unibyte strings are not bidi-reordered.
6583 (compute_display_string_pos)
6584 (compute_display_string_end): Fix handling the case of C string.
6585 (push_it, pop_it): Save and restore from_disp_prop_p.
6586 (handle_single_display_spec, push_display_prop): Set the
6587 from_disp_prop_p flag.
6588 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6589 (pop_it): Call iterate_out_of_display_property only if we are
6590 popping after iteration over a string that came from a display
6591 property. Fix a typo in popping stretch info. Add an assertion
6592 for verifying that the iterator position is in sync with the bidi
6593 iterator.
6594 (handle_single_display_spec, get_overlay_strings_1)
6595 (push_display_prop): Fix initialization of paragraph direction for
6596 string when that of the parent object is not yet determined.
6597 (reseat_1): Call bidi_init_it to resync the bidi
6598 iterator with IT's position. (Bug#7616)
6599 (find_row_edges): If ROW->start.pos gives position
6600 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6601 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6602 Reset the from_disp_prop_p flag.
6603 (SAVE_IT, RESTORE_IT): New macros.
6604 (pos_visible_p, face_before_or_after_it_pos)
6605 (back_to_previous_visible_line_start)
6606 (move_it_in_display_line_to, move_it_in_display_line)
6607 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6608 (try_scrolling, redisplay_window, display_line): Use them when
6609 saving a temporary copy of the iterator and restoring it back.
6610 (back_to_previous_visible_line_start, reseat_1)
6611 (init_iterator): Empty the bidi cache "stack".
6612 (move_it_in_display_line_to): If iterator ended up at
6613 EOL, but we never saw any buffer positions smaller than
6614 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6615 motion in bidi-reordered lines.
6616 (move_it_in_display_line_to): Record prev_method and prev_pos
6617 immediately before the call to set_iterator_to_next. Fixes cursor
6618 motion in bidi-reordered lines with stretch glyphs and strings
6619 displayed in margins. (Bug#8133) (Bug#8867)
6620 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6621 TO_CHARPOS.
640c8776
SM
6622 (pos_visible_p): Support positions in bidi-reordered lines.
6623 Save and restore bidi cache.
0bb23927
EZ
6624
6625 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6626 (bidi_paragraph_info): Delete unused struct.
6627 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6628 (bidi_cache_start): New variable.
6629 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6630 to zero.
6631 (bidi_cache_fetch_state, bidi_cache_search)
6632 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6633 (bidi_cache_find, bidi_peek_at_next_level)
6634 (bidi_level_of_next_char, bidi_find_other_level_edge)
6635 (bidi_move_to_visually_next): Compare cache index with
6636 bidi_cache_start rather than with zero.
6637 (bidi_fetch_char): Accept new argument STRING; all callers
6638 changed. Support iteration over a string. Support strings with
6639 display properties. Support unibyte strings. Fix the type of
6640 `len' according to what STRING_CHAR_AND_LENGTH expects.
6641 (bidi_paragraph_init, bidi_resolve_explicit_1)
6642 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6643 (bidi_level_of_next_char, bidi_move_to_visually_next):
6644 Support iteration over a string.
0bb23927
EZ
6645 (bidi_set_sor_type, bidi_resolve_explicit_1)
6646 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6647 can now be zero (for strings); special values 0 and -1 were
6648 changed to -1 and -2, respectively.
6649 (bidi_char_at_pos): New function.
6650 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6651 Call it instead of FETCH_MULTIBYTE_CHAR.
6652 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6653 initialized to valid values.
6654 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6655 values.
6656 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6657 the test for valid cached positions. Fix the logic for looking up
6658 the sentinel state in the cache. GCPRO the Lisp string we are
6659 iterating.
6660 (bidi_push_it, bidi_pop_it): New functions.
6661 (bidi_initialize): Initialize the bidi cache start stack pointer.
6662 (bidi_cache_ensure_space): New function, refactored from part of
6663 bidi_cache_iterator_state. Don't assume the required size is just
6664 one BIDI_CACHE_CHUNK away.
6665 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6666 (bidi_count_bytes, bidi_char_at_pos): New functions.
6667 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6668 always valid if bidi_cache_idx is valid.
6669 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6670 is valid if it's going to be used.
6671 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6672 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6673 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6674 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6675 (bidi_find_other_level_edge, bidi_cache_start_stack):
6676 All variables related to cache indices are now EMACS_INT.
c965adc5 6677
0bb23927
EZ
6678 * dispextern.h (struct bidi_string_data): New structure.
6679 (struct bidi_it): New member `string'. Make flag members be 1-bit
6680 fields, and put them last in the struct.
640c8776
SM
6681 (compute_display_string_pos, compute_display_string_end):
6682 Update prototypes.
0bb23927
EZ
6683 (bidi_push_it, bidi_pop_it): Add prototypes.
6684 (struct iterator_stack_entry): New members bidi_p,
6685 paragraph_embedding, and from_disp_prop_p.
6686 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6687 (bidi_shelve_cache, bidi_unshelve_cache):
6688 Declare prototypes.
0bb23927
EZ
6689
6690 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6691 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6692 and vector-like objects.
6693
6694 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6695 cache around display iteration.
6696
6697 * window.c (Fwindow_end, window_scroll_pixel_based)
6698 (displayed_window_lines, Frecenter): Save and restore the bidi
6699 cache around display iteration.
6700
3bbd2265
LMI
67012011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6702
6703 * editfns.c (Fdelete_region): Clarify the use of the named
6704 parameters (bug#6788).
6705
adc47434
MR
67062011-07-14 Martin Rudalics <rudalics@gmx.at>
6707
6708 * indent.c (Fvertical_motion): Set and restore w->pointm when
6709 saving and restoring the window's buffer (Bug#9006).
6710
837c31f8
LMI
67112011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6712
6713 * editfns.c (Fstring_to_char): Clarify just what is returned
6714 (bug#6576). Text by Eli Zaretskii.
6715
ac389d0c
JB
67162011-07-13 Juanma Barranquero <lekktu@gmail.com>
6717
6718 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6719
0be0ce47
EZ
67202011-07-13 Eli Zaretskii <eliz@gnu.org>
6721
6722 * buffer.c (mmap_find): Fix a typo.
6723
cd18e7e3
JB
67242011-07-13 Johan Bockgård <bojohan@gnu.org>
6725
6726 Fix execution of x selection hooks.
6727 * xselect.c (Qx_lost_selection_functions)
6728 (Qx_sent_selection_functions): New vars.
6729 (syms_of_xselect): DEFSYM them.
6730 (x_handle_selection_request): Pass Qx_sent_selection_functions
6731 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6732 (x_handle_selection_clear,x_clear_frame_selections):
6733 Pass Qx_lost_selection_functions rather than
6734 Vx_lost_selection_functions to Frun_hook_with_args.
6735
47ea7f44
PE
67362011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6737
ac389d0c 6738 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6739 The old code sometimes used this field without initializing it.
6740
47ea7f44
PE
6741 * alloc.c (gc_sweep): Don't read past end of array.
6742 In theory, the old code could also have corrupted Emacs internals,
6743 though it'd be very unlikely.
6744
bc985c87
AS
67452011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6746
6747 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6748 argument. (Bug#4026)
bc985c87 6749
0cf34688
LMI
67502011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6751
b3dadd76
LMI
6752 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6753 key" (bug#4257).
6754
0cf34688
LMI
6755 * window.c (Fset_window_start): Doc fix (bug#4199).
6756 (Fset_window_hscroll): Ditto.
6757
270768cd
PE
67582011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6759
077e3dda 6760 Fix minor new problems caught by GCC 4.6.1.
270768cd 6761 * term.c (init_tty): Remove unused local.
490011a6 6762 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6763 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6764 not used otherwise.
270768cd 6765
b1f58454
CY
67662011-07-12 Chong Yidong <cyd@stupidchicken.com>
6767
6768 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6769
22b9578d
LMI
67702011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6771
6e70ab07
LMI
6772 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6773 are the mini-buffer and the echo area (bug#3320).
6774
22b9578d
LMI
6775 * term.c (init_tty): Remove support for supdup, c10 and perq
6776 terminals, which are no longer supported (bug#1482).
6777
8974cc9f
JB
67782011-07-10 Johan Bockgård <bojohan@gnu.org>
6779
6780 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6781
a560d974
JD
67822011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6783
6784 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6785 for non-popups (Bug#3642).
6786
1dae0f0a
AS
67872011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6788
268c2c36 6789 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6790 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6791 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6792 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6793 * data.c (fmod): Likewise.
6794 * dispnew.c (swap_glyphs_in_rows): Likewise.
6795 * emacs.c (memory_warning_signal): Likewise.
6796 * floatfns.c (float_error): Likewise.
6797 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6798 (otf_open, font_otf_capability, generate_otf_features)
6799 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6800 Likewise.
6801 * image.c (pbm_read_file): Likewise.
6802 * indent.c (string_display_width): Likewise.
6803 * intervals.c (check_for_interval, search_for_interval)
6804 (inc_interval_count, count_intervals, root_interval)
6805 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6806 * lread.c (defalias): Likewise.
268c2c36 6807 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6808 * regex.c (set_image_of_range_1, set_image_of_range)
6809 (regex_grow_registers): Likewise.
6810 * sysdep.c (strerror): Likewise.
6811 * termcap.c (valid_filename_p, tprint, main): Likewise.
6812 * tparam.c (main): Likewise.
6813 * unexhp9k800.c (run_time_remap, save_data_space)
6814 (update_file_ptrs, read_header, write_header, calculate_checksum)
6815 (copy_file, copy_rest, display_header): Likewise.
6816 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6817 Likewise.
6818 * xdisp.c (check_it): Likewise.
6819 * xfaces.c (register_color, unregister_color, unregister_colors):
6820 Likewise.
6821 * xfns.c (print_fontset_result): Likewise.
6822 * xrdb.c (member, fatal, main): Likewise.
6823
99033785
PE
68242011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6825
6826 Fix minor problems found by static checking (Bug#9031).
6827 * chartab.c (char_table_set_range, map_sub_char_table):
6828 Remove unused locals.
6829 (uniprop_table): Now static.
6830 * composite.c (_work_char): Remove unused static var.
6831
9cb2ac56
JB
68322011-07-09 Juanma Barranquero <lekktu@gmail.com>
6833
6834 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6835
f25661f0
JD
68362011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6837
6838 * gtkutil.c (qttip_cb): Remove code without function.
6839
8278c4fe
EZ
68402011-07-09 Eli Zaretskii <eliz@gnu.org>
6841
6842 * w32.c (pthread_sigmask): New stub.
6843
1692ae2d 68442011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6845
8a6ebd58 6846 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6847 sigprocmask is portable only for single-threaded applications, and
6848 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6849 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6850 (LIBES): Use it.
6851 * callproc.c (Fcall_process):
6852 * process.c (create_process):
6853 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6854 Use pthread_sigmask, not sigprocmask.
123403e4 6855
1b854618
JD
68562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6857
6858 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6859 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6860 wrong (Bug#8591).
6861
3fe4b549
JD
68622011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6863
0ce7e563
JD
6864 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6865 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6866 (xg_hide_tooltip): Fix comment.
6867
3fe4b549
JD
6868 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6869 in registerServicesMenuSendTypes.
6870 (validRequestorForSendType): Don't check ns_return_types.
6871
6872 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6873 ns_return_type.
6874
5df75e47
JR
68752011-07-08 Jason Rumney <jasonr@gnu.org>
6876
22610910
JR
6877 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6878 SH_SHOW for hidden windows (Bug#5482).
6879
5df75e47
JR
6880 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6881 frame struct members of non-existent frames (Bug#6284).
6882
699c10bd
JD
68832011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6884
4393663b
JD
6885 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6886 variable firstTime not needed on OSX >= 10.6.
6887 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6888 >= 10.5. Use setKnobProportion, setDoubleValue.
6889
6890 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6891 (MAC_OS_X_VERSION_10_5): Define if not defined.
6892 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6893 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6894 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6895
6896 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6897 cString and lossyCString on OSX >= 10.4
6898
58179cce 6899 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6900 sizeToFit on OSX >= 10.2.
6901
6902 * nsimage.m (allocInitFromFile): Don't use deprecated method
6903 bestRepresentationForDevice on OSX >= 10.6.
6904
6905 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6906 to avoid warning.
6907
6908 * emacs.c: Declare unexec_init_emacs_zone.
6909
a63e0781
JD
6910 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6911
699c10bd
JD
6912 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6913
6914 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6915 on svcsMenu (Bug#8842).
6916
6917 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6918 ns_return_types.
6919 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6920
6921 * nsterm.m (QUTF8_STRING): Declare.
6922 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6923 (validRequestorForSendType): Return type is (id).
6924 Change indexOfObjectIdenticalTo to indexOfObject.
6925 Check if we have local selection before returning self (Bug#8842).
6926 (writeSelectionToPasteboard): Put local selection into paste board
6927 if we have a local selection (Bug#8842).
6928 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6929
6930 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6931 (ns_get_local_selection): Declare.
6932
54e10184
LMI
69332011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6934
9888ff71
LMI
6935 * keymap.c (describe_map_tree): Don't insert a double newline at
6936 the end of the buffer (bug#1169) and return whether we inserted
6937 something.
6938
54e10184
LMI
6939 * callint.c (Fcall_interactively): Change "reading args" to
6940 "providing args" to try to clarify what it does (bug#1010).
6941
15fa4783
KH
69422011-07-07 Kenichi Handa <handa@m17n.org>
6943
6944 * composite.c (composition_compute_stop_pos): Ignore a static
6945 composition starting before CHARPOS (Bug#8915).
6946
6947 * xdisp.c (handle_composition_prop): Likewise.
6948
a8815b00
EZ
69492011-07-07 Eli Zaretskii <eliz@gnu.org>
6950
6951 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6952 (Bug#9015)
6953
ef7b981d 69542011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6955
6956 * character.h (unicode_category_t): New enum type.
6957
6958 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6959 (Qchar_code_property_table): New variable.
6960 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6961 (UNIPROP_COMPRESSED_FORM_P): New macros.
6962 (char_table_ascii): Uncompress the compressed values.
6963 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6964 Uncompress the compressed values.
ac389d0c 6965 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6966 (char_table_ref_and_range): Uncompress the compressed values.
6967 (sub_char_table_set): New arg is_uniprop. Callers changed.
6968 Uncompress the compressed values.
6969 (sub_char_table_set_range): Args changed. Callers changed.
6970 (char_table_set_range): Adjuted for the above change.
6971 (map_sub_char_table): Delete args default_val and parent. Add arg
6972 top. Give decoded values to a Lisp function.
640c8776 6973 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6974 values to a Lisp function. Gcpro more variables.
6975 (uniprop_table_uncompress)
6976 (uniprop_decode_value_run_length): New functions.
6977 (uniprop_decoder, uniprop_decoder_count): New variables.
6978 (uniprop_get_decoder, uniprop_encode_value_character)
6979 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6980 New functions.
6981 (uniprop_encoder, uniprop_encoder_count): New variables.
6982 (uniprop_get_encoder, uniprop_table)
6983 (Funicode_property_table_internal, Fget_unicode_property_internal)
6984 (Fput_unicode_property_internal): New functions.
6985 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6986 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6987 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6988 char-code-property-alist.
6989
640c8776 6990 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6991 Vunicode_category_table.
6992
640c8776 6993 * font.c (font_range): Adjust for the change of
c805dec0
KH
6994 Vunicode_category_table.
6995
76b397fb
DN
69962011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6997
6998 * m/iris4d.h: Remove file, move contents ...
6999 * s/irix6-5.h: ... here.
7000
22b4128e
PE
70012011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7002
7003 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7004 * alloc.c (mark_buffer):
7005 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7006 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7007 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7008 This isn't true in general, and it's particularly not true
7009 if Emacs is configured with --with-wide-int.
7010 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7011 New macros, used in the buffer.c change.
7012
869795d6
JD
70132011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7014
7015 * xsettings.c: Use both GConf and GSettings if both are available.
7016 (store_config_changed_event): Add comment.
7017 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7018 (store_tool_bar_style_changed): New functions.
5e617bc2 7019 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7020 (struct xsettings): Move font inside HAVE_XFT.
7021 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7022 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7023 Move inside HAVE_XFT.
640c8776 7024 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7025 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7026 also.
7027 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7028 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7029 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7030 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7031 (parse_settings): Move check for font inside HAVE_XFT.
7032 (read_settings, apply_xft_settings): Add comment.
7033 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7034 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7035 call store_font_name_changed.
7036 (xft_settings_event): Add comment.
7037 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7038 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7039 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7040 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7041 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7042 (xsettings_get_system_font, xsettings_get_system_normal_font):
7043 Add comment.
869795d6 7044
d8ed26bd
PE
70452011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7046
7047 Random fixes. E.g., (random) never returned negative values.
7048 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7049 subseconds part to the entropy, as that's a bit more random.
7050 Prefer signed to unsigned, since the signedness doesn't matter and
7051 in general we prefer signed. When given a limit, use a
7052 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7053 latter isn't right if USE_2_TAGS_FOR_INTS.
7054 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7055 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7056
cabf1cac
SM
70572011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7058
7059 * textprop.c (text_property_stickiness):
7060 Obey Vtext_property_default_nonsticky.
7061 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7062 * w32fns.c (syms_of_w32fns):
7063 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7064
6e9b2be9
PE
70652011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7066
7067 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7068 This is more efficient than Ffile_directory_p and avoids a minor race.
7069
90186c68
LMI
70702011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7071
7c301272
LMI
7072 * buffer.c (Foverlay_put): Say what the return value is
7073 (bug#7835).
7074
c4f2d8d4
LMI
7075 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7076 is a directory before asking whether to use the file name
7077 (bug#7564).
ad637907
LMI
7078 (barf_or_query_if_file_exists): Make the "File is a directory"
7079 error be more correct.
c4f2d8d4 7080
90186c68
LMI
7081 * fns.c (Frequire): Remove the mention of the .gz files, since
7082 that's installation-specific, but keep the mention of
7083 `get-load-suffixes'.
7084
da64016e
PE
70852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7086
7087 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7088 Report string overflow if the output is too long.
7089
7d47b580
JB
70902011-07-04 Juanma Barranquero <lekktu@gmail.com>
7091
a555cb87
JB
7092 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7093 (syms_of_gnutls): Remove duplicate DEFSYM for
7094 Qgnutls_bootprop_verify_hostname_error, an error for
7095 Qgnutls_bootprop_verify_error (which is no longer used).
7096
7d47b580
JB
7097 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7098 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7099 Also (re)move comments that are misplaced or no longer relevant.
7100
1e49bfab
LMI
71012011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7102
7103 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7104
1485f4c0
CY
71052011-07-03 Chong Yidong <cyd@stupidchicken.com>
7106
7107 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7108 and background color parameters if they have been changed.
7109
a9ab721e
LMI
71102011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7111
7112 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7113
cf7cff57
PE
71142011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7115
2e13213d
PE
7116 * xsettings.c (SYSTEM_FONT): Define only when used.
7117 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7118
cf7cff57
PE
7119 * keymap.c (access_keymap_1): Now static.
7120
7a8e04f7
CY
71212011-07-02 Chong Yidong <cyd@stupidchicken.com>
7122
7123 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7124 leave any prefix arg for the up event (Bug#1586).
7125
61352f62
LMI
71262011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7127
69bb1ef7
LMI
7128 * lread.c (syms_of_lread): Mention single symbols defined by
7129 `defvar' or `defconst' (bug#7154).
7130
61352f62 7131 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7132 (Frequire): Mention get-load-suffixes.
61352f62 7133
28545e04
MR
71342011-07-02 Martin Rudalics <rudalics@gmx.at>
7135
7136 * window.h (window): Remove clone_number slot.
7137 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7138 Remove.
7139 (make_parent_window, make_window, saved_window)
7140 (Fset_window_configuration, save_window_save): Don't deal with
7141 clone numbers.
7142 * buffer.c (Qclone_number): Remove declaration.
7143 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7144
3349e122
SM
71452011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7146
7147 Add multiple inheritance to keymaps.
7148 * keymap.c (Fmake_composed_keymap): New function.
7149 (Fset_keymap_parent): Simplify.
7150 (fix_submap_inheritance): Remove.
7151 (access_keymap_1): New function extracted from access_keymap to handle
7152 embedded parents and handle lists of maps.
7153 (access_keymap): Use it.
7154 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7155 (Fcopy_keymap): Handle embedded parents.
7156 (Fcommand_remapping, define_as_prefix): Simplify.
7157 (Fkey_binding): Simplify.
7158 (syms_of_keymap): Move minibuffer-local-completion-map,
7159 minibuffer-local-filename-completion-map,
7160 minibuffer-local-must-match-map, and
7161 minibuffer-local-filename-must-match-map to Elisp.
7162 (syms_of_keymap): Defsubr make-composed-keymap.
7163 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7164 (parse_menu_item): Trivial simplification.
7165
3279eb87
GM
71662011-07-01 Glenn Morris <rgm@gnu.org>
7167
7168 * Makefile.in (SETTINGS_LIBS): Fix typo.
7169
4550efdf
KI
71702011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7171
7172 * coding.c (Fencode_coding_string): Record the last coding system
7173 used, as the function doc string says (bug#8738).
7174
0949d2b6
JD
71752011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7176
7177 * xsettings.c (store_monospaced_changed): Take new font as arg and
7178 check for change against current_mono_font.
7179 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7180 (emacs_settings_constructor, emacs_settings_get_property)
7181 (emacs_settings_set_property, emacs_settings_class_init)
7182 (emacs_settings_init, gsettings_obj): Remove.
7183 (something_changedCB): New function for HAVE_GSETTINGS.
7184 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7185 with value as argument.
7186 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7187 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7188 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7189 "changed".
7190
7191 * xgselect.c: Add defined (HAVE_GSETTINGS).
7192 (xgselect_initialize): Ditto.
7193
7194 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7195 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7196 xg_select.
7197
bbc6b304
PE
71982011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7199
7200 * eval.c (struct backtrace): Simplify and port the data structure.
7201 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7202 signed bit field, as this assumption is not portable and it makes
7203 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7204 "char debug_on_exit : 1" as this is not portable either; instead,
7205 use the portable "unsigned int debug_on_exit : 1". Remove unused
7206 member evalargs. Remove obsolete comments about cc bombing out.
7207
9851bfc5
JD
72082011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7209
51bb811f 7210 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7211 Let HAVE_GSETTINGS override HAVE_GCONF.
7212 (store_monospaced_changed): New function.
7213 (EMACS_SETTINGS): A new type derived from GObject to handle
7214 GSettings notifications.
7215 (emacs_settings_constructor, emacs_settings_get_property)
7216 (emacs_settings_set_property, emacs_settings_class_init):
7217 New functions.
7218 (gsettings_client, gsettings_obj): New variables.
7219 (GSETTINGS_SCHEMA): New define.
7220 (something_changedCB): Call store_monospaced_changed.
7221 (init_gsettings): New function.
7222 (xsettings_initialize): Call init_gsettings.
7223 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7224 to NULL.
7225
640c8776 7226 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7227 GCONF_CFLAGS/LIBS.
7228
5386012d
MR
72292011-06-29 Martin Rudalics <rudalics@gmx.at>
7230
7231 * window.c (resize_root_window, grow_mini_window)
7232 (shrink_mini_window): Rename Qresize_root_window to
7233 Qwindow_resize_root_window and Qresize_root_window_vertically to
7234 Qwindow_resize_root_window_vertically.
7235
f13e0b08
PE
72362011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7237
7238 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7239
94515237
JB
72402011-06-27 Juanma Barranquero <lekktu@gmail.com>
7241
7242 * makefile.w32-in: Redesign dependencies so they reflect more
7243 clearly which files are directly included by each source file,
7244 and not through other includes.
7245
e43b6e43
MR
72462011-06-27 Martin Rudalics <rudalics@gmx.at>
7247
7248 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7249 (sort_overlays, overlay_strings): When an overlay's clone number
7250 matches the window's clone number process the overlay even if
7251 the overlay's window property doesn't match the current window.
7252
d68443dc
MR
7253 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7254 (Fwindow_hchild): Rename to Fwindow_left_child.
7255 (Fwindow_next): Rename to Fwindow_next_sibling.
7256 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7257 (resize_window_check): Rename to window_resize_check.
7258 (resize_window_apply): Rename to window_resize_apply.
7259 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7260 (Fdelete_other_windows_internal, resize_frame_windows)
7261 (Fsplit_window_internal, Fdelete_window_internal)
7262 (grow_mini_window, shrink_mini_window)
7263 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7264
c7e73be5
JD
72652011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7266
7267 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7268 (emacs_fixed_set_min_size): Remove.
7269 (emacs_fixed_new): Take frame as argument.
7270
7271 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7272 (_EmacsFixedPrivate): Remove minwidth/height.
7273 Add struct frame *f.
7274 (emacs_fixed_init): Initialize priv->f.
7275 (get_parent_class, emacs_fixed_set_min_size): Remove.
7276 (emacs_fixed_new): Set priv->f to argument.
7277 (emacs_fixed_get_preferred_width)
7278 (emacs_fixed_get_preferred_height): Use min_width/height from
7279 frames size_hint to set minimum and natural (Bug#8919).
7280 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7281 and use min_width/height from frames size_hint to set
7282 min_width/height (Bug#8919).
7283
7284 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7285 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7286 Fix indentation.
c7e73be5 7287
cf99dcf8
EZ
72882011-06-26 Eli Zaretskii <eliz@gnu.org>
7289
7290 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7291 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7292 called at ZV.
7293
029529ac
CY
72942011-06-26 Chong Yidong <cyd@stupidchicken.com>
7295
7296 * process.c (wait_reading_process_output): Bypass select if
7297 waiting for a cell while ignoring keyboard input, and input is
7298 pending. Suggested by Jan Djärv (Bug#8869).
7299
7a7ef429
PE
73002011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7301
7302 Use gnulib's dup2 module instead of rolling our own.
7303 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7304
11fdef7d 73052011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7306
7307 * dispnew.c (scrolling_window): Before scrolling, turn off a
7308 mouse-highlight in the window being scrolled.
7309
cd3520a4
JB
73102011-06-24 Juanma Barranquero <lekktu@gmail.com>
7311
7312 Move DEFSYM to lisp.h and use everywhere.
7313
7314 * character.h (DEFSYM): Move declaration...
7315 * lisp.h (DEFSYM): ...here.
7316
7317 * gnutls.c:
7318 * minibuf.c:
7319 * w32menu.c:
7320 * w32proc.c:
7321 * w32select.c: Don't include character.h.
7322
7323 * alloc.c (syms_of_alloc):
7324 * buffer.c (syms_of_buffer):
7325 * bytecode.c (syms_of_bytecode):
7326 * callint.c (syms_of_callint):
7327 * casefiddle.c (syms_of_casefiddle):
7328 * casetab.c (init_casetab_once):
7329 * category.c (init_category_once, syms_of_category):
7330 * ccl.c (syms_of_ccl):
7331 * cmds.c (syms_of_cmds):
7332 * composite.c (syms_of_composite):
7333 * dbusbind.c (syms_of_dbusbind):
7334 * dired.c (syms_of_dired):
7335 * dispnew.c (syms_of_display):
7336 * doc.c (syms_of_doc):
7337 * editfns.c (syms_of_editfns):
7338 * emacs.c (syms_of_emacs):
7339 * eval.c (syms_of_eval):
7340 * fileio.c (syms_of_fileio):
7341 * fns.c (syms_of_fns):
7342 * frame.c (syms_of_frame):
7343 * fringe.c (syms_of_fringe):
7344 * insdel.c (syms_of_insdel):
7345 * keymap.c (syms_of_keymap):
7346 * lread.c (init_obarray, syms_of_lread):
7347 * macros.c (syms_of_macros):
7348 * msdos.c (syms_of_msdos):
7349 * print.c (syms_of_print):
7350 * process.c (syms_of_process):
7351 * search.c (syms_of_search):
7352 * sound.c (syms_of_sound):
7353 * syntax.c (init_syntax_once, syms_of_syntax):
7354 * terminal.c (syms_of_terminal):
7355 * textprop.c (syms_of_textprop):
7356 * undo.c (syms_of_undo):
7357 * w32.c (globals_of_w32):
7358 * window.c (syms_of_window):
7359 * xdisp.c (syms_of_xdisp):
7360 * xfaces.c (syms_of_xfaces):
7361 * xfns.c (syms_of_xfns):
7362 * xmenu.c (syms_of_xmenu):
7363 * xsettings.c (syms_of_xsettings):
7364 * xterm.c (syms_of_xterm): Use DEFSYM.
7365
4228cf16
TZ
73662011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7367
cd3520a4 7368 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7369
7fcccf1e
PE
73702011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7371
7efb4e0e
PE
7372 Integer and buffer overflow fixes (Bug#8873).
7373
ff5844ad
PE
7374 * print.c (printchar, strout): Check for string overflow.
7375 (PRINTPREPARE, printchar, strout):
7376 Don't set size unless allocation succeeds.
7377
90532f02
PE
7378 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7379 for sizes. Check for string overflow more accurately.
7380 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7381
6d84508d
PE
7382 * macros.c: Integer and buffer overflow fixes.
7383 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7384 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7385 Use ptrdiff_t, not int, for sizes.
7386 Don't increment bufsize until after realloc succeeds.
7387 Check for size-calculation overflow.
7388 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7389
437b2cb4
PE
7390 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7391
8b9ac8b4
PE
7392 * lread.c: Integer overflow fixes.
7393 (read_integer): Radix is now EMACS_INT, not int,
7394 to improve quality of diagnostics for out-of-range radices.
7395 Calculate buffer size correctly for out-of-range radices.
7396 (read1): Check for integer overflow in radices, and in
7397 read-circle numbers.
82cb60d3
PE
7398 (read_escape): Avoid int overflow.
7399 (Fload, openp, read_buffer_size, read1)
7400 (substitute_object_recurse, read_vector, read_list, map_obarray):
7401 Use ptrdiff_t, not int, for sizes.
7402 (read1): Use EMACS_INT, not int, for sizes.
20270765 7403 Check for size overflow.
8b9ac8b4 7404
7fcccf1e
PE
7405 * image.c (cache_image): Check for size arithmetic overflow.
7406
bfbbd7e7
PE
7407 * lread.c: Integer overflow issues.
7408 (saved_doc_string_size, saved_doc_string_length)
7409 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7410 Now ptrdiff_t, not int.
7411 (read1): Don't assume doc string length fits in int. Check for
7412 out-of-range doc string lengths.
7413 (read_list): Don't assume file position fits in int.
39019e54 7414 (read_escape): Check for hex character overflow.
bfbbd7e7 7415
4e323265
LL
74162011-06-22 Leo Liu <sdl.web@gmail.com>
7417
7418 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7419 Move to minibuffer.el.
7420
85fece3e
PE
74212011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7422
20b84ce9 7423 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7424 The following patches are for when GLYPH_DEBUG && !XASSERT.
7425 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7426 * dispnew.c (flush_stdout):
7427 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7428 Mark as externally visible.
7429 * dispnew.c (check_window_matrix_pointers): Now static.
7430 * dispnew.c (window_to_frame_vpos):
7431 * xfns.c (unwind_create_frame):
7432 * xterm.c (x_check_font): Remove unused local.
7433 * scroll.c (CHECK_BOUNDS):
7434 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7435 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7436 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7437 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7438 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7439 Now static.
7440 (debug_method_add): Use va_list and vsprintf rather than relying
7441 on undefined behavior with wrong number of arguments.
7442 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7443 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7444 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7445 since we're not interested in debugging glyphs with old libraries.
7446 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7447 GCC 4.6.0's static checking.
7448
0766b489
PE
74492011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7450
31fd4b32
PE
7451 Integer overflow and signedness fixes (Bug#8873).
7452 A few related buffer overrun fixes, too.
7453
b79e8648
PE
7454 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7455
0766b489
PE
7456 * dispextern.h (struct face.stipple):
7457 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7458 (x_bitmap_mask, x_allocate_bitmap_record)
7459 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7460 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7461 (x_create_bitmap_from_xpm_data):
7462 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7463 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7464 (.bitmaps_last):
7465 * xfaces.c (load_pixmap):
7466 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7467 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7468 (.bitmaps_last, struct x_output.icon_bitmap):
7469 Use ptrdiff_t, not int, for bitmap indexes.
7470 (x_allocate_bitmap_record): Check for size overflow.
7471 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7472
b081724f
PE
7473 Use ptrdiff_t, not int, for overlay counts.
7474 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7475 * editfns.c (overlays_around, get_pos_property):
7476 * textprop.c (get_char_property_and_overlay):
7477 * xdisp.c (next_overlay_change, note_mouse_highlight):
7478 * xfaces.c (face_at_buffer_position):
21514da7
PE
7479 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7480 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7481 (Fnext_overlay_change, Fprevious_overlay_change)
7482 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7483 Use ptrdiff_t, not int, for sizes.
21514da7 7484 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7485
3de73e5e
PE
7486 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7487
2606c57b
PE
7488 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7489 (x_session_initialize): Do not assume string length fits in int.
7490
aaafe47a
PE
7491 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7492 This is unlikely, but can occur if DPI is outlandish.
7493
2674ddc8 7494 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7495 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7496
28154962
PE
7497 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7498 * xrdb.c (magic_file_p, search_magic_path):
7499 Omit last arg SUFFIX; it was always 0. All callers changed.
7500 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7501
7de51af5
PE
7502 * xfont.c (xfont_match): Avoid need for strlen.
7503
25ed6cc3
PE
7504 * xfns.c: Don't assume strlen fits in int.
7505 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7506
4eab31dd
PE
7507 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7508 not unsigned long, as we prefer signed integers. All callers changed.
7509 Detect integer overflow in repeat count.
7510 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7511 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7512
171e2a58
PE
7513 * termcap.c: Don't assume sizes fit in int and never overflow.
7514 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7515 (gobble_line): Check for size-calculation overflow.
7516
ad39faca 7517 * minibuf.c (Fread_buffer):
6e5bb2dc 7518 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7519 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7520 Don't assume string length fits in int.
7521
52c61c22 7522 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7523 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7524
b5b8c9e5
PE
7525 * font.c: Don't assume string length fits in int.
7526 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7527 Use ptrdiff_t, not int.
ccd6111c
PE
7528 (font_intern_prop): Don't assume string length fits in int.
7529 Don't assume integer property fits in fixnum.
7530 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7531
882f0d81 7532 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7533 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7534 Reformulate so as not to need the command string.
7535 Invoke gzip -cd rather than gunzip, as it's more portable.
7536 (lock_info_type, lock_file_1, lock_file):
7537 Don't assume pid_t and time_t fit in unsigned long.
7538 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7539 (current_lock_owner): Prefer signed type for sizes.
7540 Use memcpy, not strncpy, where memcpy is what is really wanted.
7541 Don't assume (via atoi) that time_t and pid_t fit in int.
7542 Check for time_t and/or pid_t out of range, e.g., via a network share.
7543 Don't alloca where an auto var works fine.
7544
93f4cf88
PE
7545 * fileio.c: Fix some integer overflow issues.
7546 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7547 Don't assume string length fits in int.
7548 (directory_file_name): Don't assume string length fits in long.
7549 (make_temp_name): Don't assume pid fits in int, or that its print
7550 length is less than 20.
7551
f3e92b69
PE
7552 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7553
1bfdaf10
PE
7554 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7555
35016e9a
PE
7556 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7557
3d1e65a1
PE
7558 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7559 We prefer signed integers, even for size calculations.
7560
0b963a93
PE
7561 * emacs.c: Don't assume string length fits in 'int'.
7562 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7563 (main): Don't invoke strlen when not needed.
7564
573f4b54
PE
7565 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7566 (XD_DEBUG_MESSAGE): Don't waste a byte.
7567
989f33ba
PE
7568 * callproc.c (getenv_internal_1, getenv_internal)
7569 (Fgetenv_internal):
965d34eb
PE
7570 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7571
e4d29b33
PE
7572 * lread.c (invalid_syntax): Omit length argument.
7573 All uses changed. This doesn't fix a bug, but it simplifies the
7574 code away from its former Hollerith-constant appearance, and it's
7575 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7576 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7577
eb49b136
PE
7578 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7579 This didn't break anything, but it didn't help either.
7580 It's confusing to put a bogus integer in a place where the actual
7581 value does not matter.
9f62aeb1 7582 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7583 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7584
15375a22
PE
7585 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7586 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7587 implementation.
b61cc01c
PE
7588 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7589 We prefer signed types, and the value cannot exceed the EMACS_INT
7590 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7591 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7592 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7593 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7594
53b2623d
PE
7595 * indent.c (sane_tab_width): New function.
7596 (current_column, scan_for_column, Findent_to, position_indentation)
7597 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7598 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7599
51cab52b 7600 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7601
f2ed8a70
PE
7602 * lisp.h (lint_assume): New macro.
7603 * composite.c (composition_gstring_put_cache):
7604 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7605
abe80cc6
PE
7606 * editfns.c, insdel.c:
7607 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7608
b02c740e
PE
7609 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7610
ebc96716
PE
7611 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7612
b4e50fa0 7613 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7614 Use much-faster test for byte-length change.
311d5d7c 7615 Don't assume string byte-length fits in 'int'.
a4cf38e4 7616 Check that character arg fits in 'int'.
85461888 7617 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7618
c0c1ee9f
PE
7619 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7620
a498d7f4
PE
7621 * fns.c (concat): Catch string overflow earlier.
7622 Do not rely on integer wraparound.
7623
51cab52b
PE
7624 * dispextern.h (struct it.overlay_strings_charpos)
7625 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7626 * xdisp.c (forward_to_next_line_start)
7627 (back_to_previous_visible_line_start)
7628 (reseat_at_next_visible_line_start, next_element_from_buffer):
7629 Don't arbitrarily truncate the value of 'selective' to int.
7630
76031fad
PE
7631 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7632
5eb55db9
PE
7633 * composite.c: Don't truncate sizes to 'int'.
7634 (composition_gstring_p, composition_reseat_it)
7635 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7636 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7637 not EMACS_UINT, for indexes.
5eb55db9 7638
0703a717
PE
7639 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7640
d6202519
PE
7641 * buffer.c: Include <verify.h>.
7642 (struct sortvec.priority, struct sortstr.priority):
8961a454 7643 Now EMACS_INT, not int.
c20998a7 7644 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7645 (struct sortstr.size, record_overlay_string)
7646 (struct sortstrlist.size, struct sortlist.used):
7647 Don't truncate size to int.
7648 (record_overlay_string): Check for size-calculation overflow.
d6202519 7649 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7650
d5a19415
JM
76512011-06-22 Jim Meyering <meyering@redhat.com>
7652
029529ac 7653 Don't leak an XBM-image-sized buffer
d5a19415
JM
7654 * image.c (xbm_load): Free the image buffer after using it.
7655
a9041e6c
PE
76562011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7657
7658 Port to Sun C.
7659 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7660 that Sun C diagnosed.
7661 * fns.c (secure_hash): Fix pointer signedness issue.
7662 * intervals.c (static_offset_intervals): New function.
7663 (offset_intervals): Use it.
7664
7f3f739f
LL
76652011-06-21 Leo Liu <sdl.web@gmail.com>
7666
7667 * deps.mk (fns.o):
7668 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7669 sha512.h.
7670
7671 * fns.c (secure_hash): Rename from crypto_hash_function and change
7672 the first arg to accept symbols.
5b66d427 7673 (Fsecure_hash): New primitive.
7f3f739f
LL
7674 (syms_of_fns): New symbols.
7675
76147d94
DD
76762011-06-20 Deniz Dogan <deniz@dogan.se>
7677
7678 * process.c (Fset_process_buffer): Clarify return value in
7679 docstring.
7680
7d7d0045
CY
76812011-06-18 Chong Yidong <cyd@stupidchicken.com>
7682
7683 * dispnew.c (add_window_display_history): Use BVAR.
7684
7685 * xdisp.c (debug_method_add): Use BVAR.
7686 (check_window_end, dump_glyph_matrix, dump_glyph)
7687 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7688
7689 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7690 Likewise.
7691
7692 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7693 check till after the cache is created in init_frame_faces.
7694
ff2bc410
SM
76952011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7696
7697 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7698
28177add
PE
76992011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7700
dd3482fe
PE
7701 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7702 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7703 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7704
393d71f3 7705 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7706 * fileio.c (Finsert_file_contents):
7707 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7708 Remove the old (too-loose) buffer overflow checks.
7709 They weren't needed, since make_gap checks for buffer overflow.
7710 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7711 The old code merely checked for Emacs fixnum overflow, and relied
7712 on undefined (wraparound) behavior. The new code avoids undefined
7713 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7714
2e6813b0 7715 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7716 Tune. Don't use wider integers than needed. Don't use alloca.
7717 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7718
599a9e4f
PE
7719 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7720
99561444
PE
7721 * insdel.c, lisp.h (buffer_overflow): New function.
7722 (insert_from_buffer_1, replace_range, replace_range_2):
7723 * insdel.c (make_gap_larger):
7724 * editfns.c (Finsert_char):
7725 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7726
28177add
PE
7727 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7728
e69dafad
PE
77292011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7730
4baa020d 7731 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7732
b1c46f02
PE
7733 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7734 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7735
e69dafad
PE
7736 * fileio.c: Don't assume EMACS_INT fits in off_t.
7737 (emacs_lseek): New static function.
7738 (Finsert_file_contents, Fwrite_region): Use it.
7739 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7740
566684ea
PE
7741 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7742
e6966cd6
PE
7743 * fns.c: Don't overflow int when computing a list length.
7744 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7745 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7746 truncation on 64-bit hosts. Check for QUIT every
7747 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7748 faster and is responsive enough.
7749 (Flength): Report an error instead of overflowing an integer.
7750 (Fsafe_length): Return a float if the value is not representable
7751 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7752 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7753 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7754
dd0b0efb
PE
7755 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7756 (header_size, word_size): New constants.
7757 (allocate_vectorlike): Don't check size overflow here.
7758 (allocate_vector): Check it here instead, since this is the only
7759 caller of allocate_vectorlike that could cause overflow.
7760 Check that the new vector's length is representable as a fixnum.
7761
86fe5cfe
PE
7762 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7763 The previous code was bogus. For example, next_almost_prime (32)
7764 returned 39, which is undesirable as it is a multiple of 3; and
7765 next_almost_prime (24) returned 25, which is a multiple of 5 so
7766 why was the code bothering to check for multiples of 7?
7767
80e88859
PE
7768 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7769
4a2f0ad6
PE
7770 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7771
f66c7cf8
PE
7772 Variadic C functions now count arguments with ptrdiff_t.
7773 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7774 Back then I didn't know that the Emacs coding style prefers signed int.
7775 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7776 were being counted with int, which may truncate counts on 64-bit
7777 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7778 * lisp.h (struct Lisp_Subr.function.aMANY)
7779 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7780 Arg counts are now ptrdiff_t, not size_t.
7781 All variadic functions and their callers changed accordingly.
7782 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7783 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7784 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7785 * callint.c (Fcall_interactively): Check arg count for overflow,
7786 to avoid potential buffer overrun. Use signed char, not 'int',
7787 for 'varies' array, so that we needn't bother to check its size
7788 calculation for overflow.
7789 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7790 * eval.c (apply_lambda):
7791 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7792 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7793 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7794
a1759b76
PE
7795 * callint.c (Fcall_interactively): Don't use index var as event count.
7796
d96be9fc
PE
7797 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7798 * mem-limits.h (SIZE): Remove; no longer used.
7799
a690a978 7800 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7801
578c21e6
PE
7802 Remove unnecessary casts.
7803 * xterm.c (x_term_init):
7804 * xfns.c (x_set_border_pixel):
7805 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7806 These aren't needed now that we assume ANSI C.
7807
96f53c6c
PE
7808 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7809 It's more likely to cause problems (due to unsigned overflow)
7810 than to cure them.
7811
83c77d31
PE
7812 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7813
ee2079f1
PE
7814 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7815
6da65536
PE
7816 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7817
7147c4a4
PE
7818 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7819
193e32d9
PE
7820 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7821
e5533da6
PE
7822 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7823
9910e595
PE
7824 GLYPH_CODE_FACE returns EMACS_INT, not int.
7825 * dispextern.h (merge_faces):
7826 * xfaces.c (merge_faces):
01103c44
PE
7827 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7828 Don't assume EMACS_INT fits in int.
9910e595 7829
2638320e
PE
7830 * character.h (CHAR_VALID_P): Remove unused parameter.
7831 * fontset.c, lisp.h, xdisp.c: All uses changed.
7832
045eb8d9
PE
7833 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7834
c1f134b5
PE
7835 * fns.c (concat): Minor tuning based on overflow analysis.
7836 This doesn't fix any bugs. Use int to hold character, instead
7837 of constantly refetching from Emacs object. Use XFASTINT, not
7838 XINT, for value known to be a character. Don't bother comparing
7839 a single byte to 0400, as it's always less.
7840
395fcb93 7841 * floatfns.c (Fexpt):
327eeec8
PE
7842 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7843
abbd3d23
PE
7844 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7845 for characters.
7846
684a03ef
PE
7847 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7848
0fed43f3
PE
7849 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7850 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7851 incorrectly succeed when S was a string, because 4294967386 was
7852 truncated before it was used.
7853
8fd02eb7
PE
7854 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7855 Otherwise, an out-of-range integer could cause undefined behavior
7856 on a 64-bit host.
7857
f8c86b69
PE
7858 * composite.c: Use int, not EMACS_INT, for characters.
7859 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7860 EMACS_INT, for values that are known to be in character range.
7861 This doesn't fix any bugs but is the usual style inside Emacs and
7862 may generate better code on 32-bit machines.
7863
34206dd2
PE
7864 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7865 This is for reasons similar to the recent CHAR_STRING fix.
7866 * charset.c (Fencode_char): Check that character arg is actually
7867 a character. Pass an int to ENCODE_CHAR.
7868 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7869 wider than 'int', as a compile-time check to prevent future regressions
7870 in this area.
7871
c5958d4c 7872 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7873
7874 Make sure a 64-bit char is never passed to CHAR_STRING.
7875 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7876 by silently ignoring the top 32 bits, allowing some values
7877 that were far too large to be valid characters.
7878 * character.h: Include <verify.h>.
7879 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7880 arguments are no wider than unsigned, as a compile-time check
7881 to prevent future regressions in this area.
7882 * data.c (Faset):
01103c44 7883 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7884 (Fsubst_char_in_region):
7885 * fns.c (concat):
7886 * xdisp.c (decode_mode_spec_coding):
7887 Adjust to CHAR_STRING's new requirement.
7888 * editfns.c (Finsert_char, Fsubst_char_in_region):
7889 * fns.c (concat): Check that character args are actually
7890 characters. Without this test, these functions did the wrong
7891 thing with wildly out-of-range values on 64-bit hosts.
7892
d37ca623
PE
7893 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7894 These casts should not be needed on 32-bit hosts, either.
7895 * keyboard.c (read_char):
7896 * lread.c (Fload): Remove casts to unsigned.
7897
ea204efb
PE
7898 * lisp.h (UNSIGNED_CMP): New macro.
7899 This fixes comparison bugs on 64-bit hosts.
7900 (ASCII_CHAR_P): Use it.
7901 * casefiddle.c (casify_object):
01103c44 7902 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7903 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7904 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7905 * dispextern.h (FACE_FROM_ID):
7906 * keyboard.c (read_char): Use UNSIGNED_CMP.
7907
41cb286c
PE
7908 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7909 not to EMACS_INT, to avoid GCC warning.
7910
4a1b9832
PE
7911 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7912
55daad71
PE
7913 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7914 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7915 isn't needed on 32-bit machines.
8f95c75c 7916
01103c44
PE
7917 * buffer.c (Fgenerate_new_buffer_name):
7918 Use EMACS_INT for count, not int.
0ceccced 7919 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7920
7921 * data.c (Qcompiled_function): Now static.
7922
c6f072e7
PE
7923 * window.c (window_body_lines): Now static.
7924
20ce5912
PE
7925 * image.c (gif_load): Rename local to avoid shadowing.
7926
9c4c5f81
PE
7927 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7928 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7929 * alloc.c (make_save_value): Integer argument is now of type
7930 ptrdiff_t, not int.
7931 (mark_object): Use ptrdiff_t, not int.
7932 * lisp.h (pD): New macro.
7933 * print.c (print_object): Use it.
7934
c0c5c8ae
PE
7935 * alloc.c: Use EMACS_INT, not int, to count objects.
7936 (total_conses, total_markers, total_symbols, total_vector_size)
7937 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7938 (total_free_floats, total_floats, total_free_intervals)
7939 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7940 Now EMACS_INT, not int. All uses changed.
7941 (Fgarbage_collect): Compute overall total using a double, so that
7942 integer overflow is less likely to be a problem. Check for overflow
7943 when converting back to an integer.
5a25e253
PE
7944 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7945 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7946 These were 'int' variables that could overflow on 64-bit hosts;
7947 they were never used, so remove them instead of repairing them.
211a0b2a 7948 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7949 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7950 Previously, this ceilinged at INT_MAX, but that doesn't work on
7951 64-bit machines.
e46bb31a 7952 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7953
c78baabf 7954 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7955 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7956 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7957 when a (possibly-narrower) signed value would do just as well.
7958 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7959
c9d624c6
PE
7960 * alloc.c: Catch some string size overflows that we were missing.
7961 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7962 for convenience in STRING_BYTES_MAX.
7963 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7964 The definition here is exact; the one in lisp.h was approximate.
7965 (allocate_string_data): Check for string overflow. This catches
7966 some instances we weren't catching before. Also, it catches
7967 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7968 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7969 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7970
c9d624c6
PE
7971 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7972 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7973 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7974
353032ce
PE
7975 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7976
2bccce07
PE
7977 * alloc.c (Fmake_string): Check for out-of-range init.
7978
0ac30604
SM
79792011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7980
7981 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7982
c195f2de
JD
79832011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7984
7985 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7986 xg_get_default_scrollbar_width.
7987
7988 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7989 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7990 (style_changed_cb): Call update_theme_scrollbar_width and call
7991 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7992 all frames (Bug#8505).
7993 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7994 Call gtk_window_set_resizable if HAVE_GTK3.
7995 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7996 and height if HAVE_GTK3 (Bug#8505).
7997 (scroll_bar_width_for_theme): New variable.
7998 (update_theme_scrollbar_width): New function.
7999 (xg_get_default_scrollbar_width): Move code to
8000 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8001 (xg_initialize): Call update_theme_scrollbar_width.
8002
8003 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8004
8005 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8006
e10ac9f1
MR
80072011-06-12 Martin Rudalics <rudalics@gmx.at>
8008
8009 * frame.c (make_frame): Call other_buffer_safely instead of
8010 other_buffer.
8011
8012 * window.c (temp_output_buffer_show): Call display_buffer with
8013 second argument Vtemp_buffer_show_specifiers and reset latter
8014 immediately after the call.
8015 (Vtemp_buffer_show_specifiers): New variable.
8016 (auto_window_vscroll_p, next_screen_context_lines)
8017 (Vscroll_preserve_screen_position): Remove leading asterisks from
8018 doc-strings.
8019
2d3c217e 80202011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8021
7b7f97e8 8022 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8023 * buffer.c (Qclone_number): Remove for now, as it's unused.
8024 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8025 (record_buffer): Remove unused local.
8026 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8027 (set_frame_buffer_list): Remove; unused.
8028 * frame.h (other_visible_frames): Remove decl.
8029 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8030 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8031 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8032 if HAVE_GPM.
8033 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8034 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8035 Define only if HAVE_GPM.
8036 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8037 (update_hints_inhibit): Remove; never set. All uses removed.
8038 * widgetprv.h (emacsFrameClassRec): Remove decl.
8039 * window.c (delete_deletable_window): Now returns void, since it
8040 wasn't returning anything.
8041 (compare_window_configurations): Remove unused locals.
8042 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8043 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8044 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8045 the same widths as pointers. This follows up on the 2011-05-06 patch.
8046 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8047 * xterm.h: Likewise.
8048 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8049
1384b89e
JB
80502011-06-12 Juanma Barranquero <lekktu@gmail.com>
8051
8052 * makefile.w32-in: Update dependencies.
8053 (LISP_H): Add lib/intprops.h.
8054
1100a63c
CY
80552011-06-11 Chong Yidong <cyd@stupidchicken.com>
8056
8057 * image.c (gif_load): Add animation frame delay to the metadata.
8058 (syms_of_image): Use DEFSYM. New symbol `delay'.
8059
6198ccd0
MR
80602011-06-11 Martin Rudalics <rudalics@gmx.at>
8061
8062 * window.c (delete_deletable_window): Re-add.
8063 (Fset_window_configuration): Rewrite to handle dead buffers and
8064 consequently deletable windows.
8065 (window_tree, Fwindow_tree): Remove. Supply functionality in
8066 window.el.
8067 (compare_window_configurations): Simplify code.
8068
b6e3633c
AS
80692011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8070
1ab0dee5
AS
8071 * image.c (imagemagick_load_image): Fix type mismatch.
8072 (Fimagemagick_types): Likewise.
8073
b6e3633c
AS
8074 * window.h (replace_buffer_in_windows): Declare.
8075
9397e56f
MR
80762011-06-11 Martin Rudalics <rudalics@gmx.at>
8077
8078 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8079 Qclone_number. Remove external declaration of Qdelete_window.
8080 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8081 code.
640c8776
SM
8082 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8083 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8084 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8085 buffer list implementation.
8086 (other_buffer_safely): New function.
8087 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8088 calls to replace_buffer_in_windows and
8089 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8090 if allowed.
8091 (record_buffer): Inhibit quitting and rewrite using quittable
8092 functions. Run Qbuffer_list_update_hook if allowed.
8093 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8094 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8095 Move switch-to-buffer to window.el.
9397e56f
MR
8096 (bury-buffer): Move to window.el.
8097 (Vbuffer_list_update_hook): New variable.
8098
8099 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8100 section.
8101
8102 * window.h (resize_frame_windows): Move up in code.
8103 (Fwindow_frame): Remove EXFUN.
8104 (replace_buffer_in_all_windows): Remove prototype.
8105 (replace_buffer_in_windows_safely): Add prototype.
8106
8107 * window.c: Declare Qdelete_window static again. Move down
8108 declaration of select_count.
8109 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8110 (Fother_window): Move to window.el.
8111 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8112 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8113 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8114 window.el.
8115 (replace_buffer_in_windows): Implement by calling
8116 Qreplace_buffer_in_windows.
8117 (replace_buffer_in_all_windows): Remove with some functionality
8118 moved into replace_buffer_in_windows_safely.
8119 (replace_buffer_in_windows_safely): New function.
8120 (select_window_norecord, select_frame_norecord): Move in front
8121 of run_window_configuration_change_hook. Remove now obsolete
8122 declarations.
640c8776
SM
8123 (Fset_window_buffer): Rewrite doc-string.
8124 Call Qrecord_window_buffer.
9397e56f
MR
8125 (keys_of_window): Move binding for other-window to window.el.
8126
b50691aa
CY
81272011-06-11 Chong Yidong <cyd@stupidchicken.com>
8128
8129 * dispextern.h (struct image): Replace data member, whose int_val
8130 and ptr_val fields were not used by anything, with a single
8131 lisp_val object.
8132
8133 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8134 (gif_clear_image, gif_load, imagemagick_load_image)
8135 (gs_clear_image, gs_load): Callers changed.
8136
3f754b86
PE
81372011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8138
cca69397
PE
8139 * buffer.h: Include <time.h>, for time_t.
8140 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8141
109e28d0
PE
8142 Fix minor problems found by static checking.
8143
60737f02
PE
8144 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8145
4b66faf3
PE
8146 Make identifiers static if they are not used in other modules.
8147 * data.c (Qcompiled_function, Qframe, Qvector):
8148 * image.c (QimageMagick, Qsvg):
8149 * minibuf.c (Qmetadata):
8150 * window.c (resize_window_check, resize_root_window): Now static.
8151 * window.h (resize_window_check, resize_root_window): Remove decls.
8152
109e28d0
PE
8153 * window.c (window_deletion_count, delete_deletable_window):
8154 Remove; unused.
46a4ce9e
PE
8155 (window_body_lines): Now static.
8156 (Fdelete_other_windows_internal): Mark vars as initialized.
8157 Make sure 'resize_failed' is initialized.
8158 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8159 (resize_window_apply): Remove unused local.
8160 * window.h (delete_deletable_window): Remove decl.
8161
109e28d0 8162 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8163 (imagemagick_load_image): Fix pointer signedness problem by changing
8164 last arg from unsigned char * to char *. All uses changed.
8165 Also, fix a local for similar reasons.
8166 Remove unused locals. Remove locals to avoid shadowing.
8167 (fn_rsvg_handle_free): Remove; unused.
8168 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8169 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8170
3f754b86
PE
8171 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8172
2547adb1
CY
81732011-06-10 Chong Yidong <cyd@stupidchicken.com>
8174
8175 * image.c (gif_load): Fix omitted cast error introduced by
8176 2011-06-06 change.
8177
2c8e37d4
MR
81782011-06-10 Martin Rudalics <rudalics@gmx.at>
8179
8180 * window.h (resize_proportionally, orig_total_lines)
8181 (orig_top_line): Remove from window structure.
8182 (set_window_height, set_window_width, change_window_heights)
8183 (Fdelete_window): Remove prototypes.
8184 (resize_frame_windows): Remove duplicate declaration.
8185
440a42e3
EZ
81862011-06-10 Eli Zaretskii <eliz@gnu.org>
8187
8188 * window.h (resize_frame_windows, resize_window_check)
8189 (delete_deletable_window, resize_root_window)
8190 (resize_frame_windows): Declare prototypes.
8191
8192 * window.c (resize_window_apply): Make definition be "static" to
8193 match the prototype.
8194
562dd5e9
MR
81952011-06-10 Martin Rudalics <rudalics@gmx.at>
8196
8197 * window.c: Remove declarations of Qwindow_size_fixed,
8198 window_min_size_1, window_min_size_2, window_min_size,
8199 size_window, window_fixed_size_p, enlarge_window, delete_window.
8200 Remove static from declaration of Qdelete_window, it's
8201 temporarily needed by Fbury_buffer.
8202 (replace_window): Don't assign orig_top_line and
8203 orig_total_lines.
8204 (Fdelete_window, delete_window): Remove. Window deletion is
8205 handled by window.el.
640c8776
SM
8206 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8207 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8208 (Fdelete_other_windows): Remove. Deleting other windows is
8209 handled by window.el.
8210 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8211 handled in window.el.
8212 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8213 Window minimum sizes are handled in window.el.
8214 (shrink_windows, size_window, set_window_height)
8215 (set_window_width, change_window_heights, window_height)
8216 (window_width, CURBEG, CURSIZE, enlarge_window)
8217 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8218 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8219 handled in window.el.
8220 (make_dummy_parent): Rename to make_parent_window and give it a
8221 second argument horflag.
8222 (make_window): Don't set resize_proportionally any more.
8223 (Fsplit_window): Remove. Windows are split in window.el.
8224 (save_restore_action, save_restore_orig_size)
8225 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8226 Resize mini windows in window.el.
8227 (grow_mini_window, shrink_mini_window): Implement by calling
8228 Qresize_root_window_vertically, resize_window_check and
8229 resize_window_apply.
640c8776
SM
8230 (saved_window, Fset_window_configuration, save_window_save):
8231 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8232 resize_proportionally.
8233 (window_min_height, window_min_width): Move to window.el.
8234 (keys_of_window): Move bindings for delete-other-windows,
8235 split-window, delete-window and enlarge-window to window.el.
8236
8237 * buffer.c: Temporarily extern Qdelete_window.
8238 (Fbury_buffer): Temporarily call Qdelete_window instead of
8239 Fdelete_window (Fbury_buffer will move to window.el soon).
8240
8241 * frame.c (set_menu_bar_lines_1): Remove code handling
8242 orig_top_line and orig_total_lines.
8243
8244 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8245 set_window_height but set heights directly.
8246 (change_frame_size_1): Use resize_frame_windows.
8247
8248 * xdisp.c (init_xdisp): Don't use set_window_height but set
8249 heights directly.
8250
640c8776
SM
8251 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8252 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8253 run_window_configuration_change_hook.
8254
8255 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8256 instead of change_window_heights and run
8257 run_window_configuration_change_hook.
8258
1a13852e
MR
82592011-06-09 Martin Rudalics <rudalics@gmx.at>
8260
8261 * window.c (replace_window): Rename second argument REPLACEMENT to
8262 NEW. New third argument SETFLAG. Rewrite.
8263 (delete_window, make_dummy_parent): Call replace_window with
8264 third argument 1.
8265 (window_list_1): Move down in code.
8266 (run_window_configuration_change_hook): Move set_buffer part
8267 before select_frame_norecord part in order to unwind correctly.
8268 Rename count1 to count.
8269 (recombine_windows, delete_deletable_window, resize_root_window)
8270 (Fdelete_other_windows_internal)
8271 (Frun_window_configuration_change_hook, make_parent_window)
8272 (resize_window_check, resize_window_apply, Fresize_window_apply)
8273 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8274 (Fdelete_window_internal, Fresize_mini_window_internal):
8275 New functions.
1a13852e
MR
8276 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8277
f3d1777e
MR
82782011-06-08 Martin Rudalics <rudalics@gmx.at>
8279
496e208e
MR
8280 * window.h (window): Add some new members to window structure -
8281 normal_lines, normal_cols, new_total, new_normal, clone_number,
8282 splits, nest, prev_buffers, next_buffers.
8283 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8284 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8285
f3d1777e
MR
8286 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8287 Remove.
496e208e
MR
8288 (make_dummy_parent): Set new members of windows structure.
8289 (make_window): Move down in code. Handle new members of window
8290 structure.
8291 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8292 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8293 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8294 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8295 (Fset_window_next_buffers, Fset_window_clone_number):
8296 New functions.
496e208e
MR
8297 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8298 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8299 Doc-string fixes.
8300 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8301 Argument WINDOW can be now internal window too.
8302 (Fwindow_use_time): Move up in code.
8303 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8304 Rewrite doc-string.
8305 (Fset_window_configuration, saved_window)
8306 (Fcurrent_window_configuration, save_window_save): Handle new
8307 members of window structure.
b9e809c2
MR
8308 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8309 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8310 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8311 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8312 Qget_mru_window, Qresize_root_window,
8313 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8314 Qauto_buffer_name; staticpro them.
f3d1777e 8315
abde8f8c
MR
83162011-06-07 Martin Rudalics <rudalics@gmx.at>
8317
8318 * window.c (Fwindow_total_size, Fwindow_left_column)
8319 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8320 (Fwindow_list_1): New functions.
8321 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8322 (Fwindow_width, Fscroll_left, Fscroll_right):
8323 Use window_body_cols instead of window_box_text_cols.
8324 (delete_window, Fset_window_configuration):
8325 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8326 (delete_all_subwindows): Take a window as argument and not a
8327 structure. Rewrite.
190b47e6
MR
8328 (window_loop): Remove handling of GET_LRU_WINDOW and
8329 GET_LARGEST_WINDOW.
8330 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8331
8332 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8333 window_box_text_cols. delete_all_subwindows now takes a
8334 Lisp_Object as argument.
abde8f8c 8335
640c8776
SM
8336 * indent.c (compute_motion, Fcompute_motion):
8337 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8338
fa8a67e6
MR
8339 * frame.c (delete_frame): Call delete_all_subwindows with root
8340 window as argument.
8341
a54e3482
DC
83422011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8343
8344 * fns.c (Fputhash): Document return value.
8345
60002bf5
CY
83462011-06-06 Chong Yidong <cyd@stupidchicken.com>
8347
8348 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8349
0c671da6 83502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8351
b862a52a 8352 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8353
be44ca6c
PE
8354 Check for overflow when converting integer to cons and back.
8355 * charset.c (Fdefine_charset_internal, Fdecode_char):
8356 Use cons_to_unsigned to catch overflow.
8357 (Fencode_char): Use INTEGER_TO_CONS.
8358 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8359 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8360 * data.c (long_to_cons, cons_to_long): Remove.
8361 (cons_to_unsigned, cons_to_signed): New functions.
8362 These signal an error for invalid or out-of-range values.
8363 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8364 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8365 * font.c (Ffont_variation_glyphs):
8366 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8367 * lisp.h: Include <intprops.h>.
8368 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8369 (cons_to_signed, cons_to_unsigned): New decls.
8370 (long_to_cons, cons_to_long): Remove decls.
8371 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8372 (Fprimitive_undo): Use CONS_TO_INTEGER.
8373 * xfns.c (Fx_window_property): Likewise.
8374 * xselect.c: Include <limits.h>.
8375 (x_own_selection, selection_data_to_lisp_data):
8376 Use INTEGER_TO_CONS.
8377 (x_handle_selection_request, x_handle_selection_clear)
8378 (x_get_foreign_selection, Fx_disown_selection_internal)
8379 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8380 (lisp_data_to_selection_data): Use cons_to_unsigned.
8381 (x_fill_property_data): Use cons_to_signed.
8382 Report values out of range.
8383
d1f3d2af
PE
8384 Check for buffer and string overflow more precisely.
8385 * buffer.h (BUF_BYTES_MAX): New macro.
8386 * lisp.h (STRING_BYTES_MAX): New macro.
8387 * alloc.c (Fmake_string):
8388 * character.c (string_escape_byte8):
8389 * coding.c (coding_alloc_by_realloc):
8390 * doprnt.c (doprnt):
8391 * editfns.c (Fformat):
8392 * eval.c (verror):
8393 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8394 since they may not be the same number.
8395 * editfns.c (Finsert_char):
8396 * fileio.c (Finsert_file_contents):
8397 Likewise for BUF_BYTES_MAX.
8398
dd52fcea
PE
8399 * image.c: Use ptrdiff_t, not int, for sizes.
8400 (slurp_file): Switch from int to ptrdiff_t.
8401 All uses changed.
8402 (slurp_file): Check that file size fits in both size_t (for
8403 malloc) and ptrdiff_t (for sanity and safety).
8404
7f9bbdbb
PE
8405 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8406 if b->modtime has its maximal value.
8407
dfe18f82
PE
8408 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8409
84acfcf0
PE
8410 Don't assume time_t can fit into int.
8411 * buffer.h (struct buffer.modtime): Now time_t, not int.
8412 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8413 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8414
ccd9a01a
PE
8415 Minor fixes for signed vs unsigned integers.
8416 * character.h (MAYBE_UNIFY_CHAR):
8417 * charset.c (maybe_unify_char):
8418 * keyboard.c (read_char, reorder_modifiers):
8419 XINT -> XFASTINT, since the integer must be nonnegative.
8420 * ftfont.c (ftfont_spec_pattern):
8421 * keymap.c (access_keymap, silly_event_symbol_error):
8422 XUINT -> XFASTINT, since the integer must be nonnegative.
8423 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8424 since it makes no difference and we prefer signed.
8425 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8426 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8427 nonnegative.
8428
d6d100dd
SM
84292011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8430
8431 * window.h (Fwindow_frame): Declare.
8432
2b6148e4
PE
84332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8434
8435 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8436 (SPARE_MEMORY): Always define.
8437 (LARGE_REQUEST): Remove.
8438 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8439
f230ecc9
MR
84402011-06-06 Martin Rudalics <rudalics@gmx.at>
8441
727e958e
MR
8442 * lisp.h: Move EXFUNS for Fframe_root_window,
8443 Fframe_first_window and Fset_frame_selected_window to window.h.
8444
8445 * window.h: Move EXFUNS for Fframe_root_window,
8446 Fframe_first_window and Fset_frame_selected_window here from
8447 lisp.h.
8448
8449 * frame.c (Fwindow_frame, Fframe_first_window)
8450 (Fframe_root_window, Fframe_selected_window)
8451 (Fset_frame_selected_window): Move to window.c.
8452 (Factive_minibuffer_window): Move to minibuf.c.
8453 (Fother_visible_frames_p): New function.
8454
8455 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8456
f230ecc9
MR
8457 * window.c (decode_window, decode_any_window): Move up in code.
8458 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8459 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8460 (Fwindow_buffer): Move up and rewrite doc-string.
8461 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8462 (Fwindow_prev): New functions.
727e958e
MR
8463 (Fwindow_frame): Move here from frame.c. Accept any window as
8464 argument.
8465 (Fframe_root_window, Fframe_first_window)
8466 (Fframe_selected_window): Move here from frame.c. Accept frame
8467 or arbitrary window as argument. Update doc-strings.
8468 (Fminibuffer_window): Move up in code.
8469 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8470 (Fset_frame_selected_window): Move here from frame.c.
8471 Marginal rewrite.
727e958e
MR
8472 (Fselected_window, select_window, Fselect_window): Move up in
8473 code. Minor doc-string fixes.
f230ecc9 8474
4d09bcf6
PE
84752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8476
8477 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8478 Do not assume that spare memory exists; that assumption is valid
8479 only if SYSTEM_MALLOC.
8480 (LARGE_REQUEST): New macro, so that the issue of large requests
8481 is separated from the issue of spare memory.
8482
810928a2
AS
84832011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8484
172418ad
AS
8485 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8486 format. (Bug#8806)
8487
43f862f7
AS
8488 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8489
810928a2
AS
8490 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8491 before statements.
8492
a059fe24
JD
84932011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8494
8495 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8496
8497 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8498
8499 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8500 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8501
989bf368
JB
85022011-06-05 Juanma Barranquero <lekktu@gmail.com>
8503
8504 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8505
4b80f674
CY
85062011-06-04 Chong Yidong <cyd@stupidchicken.com>
8507
8508 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8509 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8510 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8511 New error handlers.
4b80f674
CY
8512 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8513 Obey Vx_select_enable_clipboard_manager. Catch errors in
8514 x_clipboard_manager_save (Bug#8779).
8515 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8516 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8517
99a33b77 85182011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8519
8520 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8521
99a33b77 85222011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8523
8524 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8525 in the current matrix if keep_current_p is non-zero.
8526
8264569d
EZ
85272011-06-04 Eli Zaretskii <eliz@gnu.org>
8528
8529 * bidi.c (bidi_level_of_next_char): Fix last change.
8530
57f97249
EZ
85312011-06-03 Eli Zaretskii <eliz@gnu.org>
8532
fec2107c 8533 Support bidi reordering of text covered by display properties.
57f97249 8534
fec2107c
EZ
8535 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8536 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8537 (bidi_cache_search, bidi_cache_iterator_state)
8538 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8539 (bidi_level_of_next_char, bidi_move_to_visually_next):
8540 Support character positions inside a run of characters covered by a
fec2107c
EZ
8541 display string.
8542 (bidi_paragraph_init, bidi_resolve_explicit_1)
8543 (bidi_level_of_next_char): Call bidi_fetch_char and
8544 bidi_fetch_char_advance instead of FETCH_CHAR and
8545 FETCH_CHAR_ADVANCE.
8546 (bidi_init_it): Initialize new members.
8547 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8548 definitions.
8549 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8550 instead of using explicit *_CHAR codes.
d6d100dd
SM
8551 (bidi_resolve_explicit, bidi_resolve_weak):
8552 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8553 bidirectional text is supported only in multibyte buffers.
8554 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8555 it to initialize the frame_window_p member of struct bidi_it.
8556 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8557 (bidi_resolve_explicit, bidi_resolve_weak)
8558 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8559 bidi_it->nchars is non-positive.
8560 (bidi_level_of_next_char): Don't try to lookup the cache for the
8561 next/previous character if nothing is cached there yet, or if we
8562 were just reseat()'ed to a new position.
c40e2fb2 8563
0e14fe90
EZ
8564 * xdisp.c (set_cursor_from_row): Set start and stop points
8565 according to the row's direction when priming the loop that looks
8566 for the glyph on which to display cursor.
8567 (single_display_spec_intangible_p): Function deleted.
8568 (display_prop_intangible_p): Reimplement to call
8569 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8570 Accept 3 additional arguments needed by handle_display_spec.
8571 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8572 values: lists, `(when COND...)' forms, etc.
8573 (single_display_spec_string_p): Support property values that are
8574 lists with the argument STRING its top-level element.
8575 (display_prop_string_p): Fix the condition for processing a
8576 property that is a list to be consistent with handle_display_spec.
fec2107c 8577 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8578 last portion of handle_display_prop.
8579 (compute_display_string_pos): Accept additional argument
8580 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8581 value of a `display' property is a "replacing spec".
8582 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8583 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8584 the display property, but just return a value indicating whether
8585 the display property will replace the characters it covers.
8586 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8587 frame_window_p members of struct bidi_it.
d6d100dd
SM
8588 (compute_display_string_pos, compute_display_string_end):
8589 New functions.
fec2107c
EZ
8590 (push_it): Accept second argument POSITION, where pop_it should
8591 jump to continue iteration.
8592 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8593
fec2107c
EZ
8594 * keyboard.c (adjust_point_for_property): Adjust the call to
8595 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8596
8597 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8598 (bidi_init_it): Update prototypes.
8599 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8600 (compute_display_string_pos, compute_display_string_end):
8601 Declare prototypes.
fec2107c
EZ
8602 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8603 EMACS_INT.
fc6f18ce 8604
40087514 86052011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8606
57f53182
PE
8607 Malloc failure behavior now depends on size of allocation.
8608 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8609 * lisp.h: Change signatures accordingly.
8610 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8611 All callers changed. (Bug#8762)
8612
8613 * gnutls.c: Use Emacs's memory allocators.
8614 Without this change, the gnutls library would invoke malloc etc.
8615 directly, which causes problems on non-SYNC_INPUT hosts, and which
8616 runs afoul of improving memory_full behavior. (Bug#8761)
8617 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8618 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8619 xfree instead of the default malloc, realloc, free.
8620 (Fgnutls_boot): No need to check for memory allocation failure,
8621 since xmalloc does that for us.
8622
ac32cd99 8623 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8624 * category.c (hash_get_category_set):
8625 * ccl.c (ccl_driver):
8626 * charset.c (Fdefine_charset_internal):
8627 * charset.h (struct charset.hash_index):
8628 * composite.c (get_composition_id, gstring_lookup_cache)
8629 (composition_gstring_put_cache):
8630 * composite.h (struct composition.hash_index):
8631 * dispextern.h (struct image.hash):
8632 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8633 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8634 (hashfn_equal, hashfn_user_defined, make_hash_table)
8635 (maybe_resize_hash_table, hash_lookup, hash_put)
8636 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8637 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8638 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8639 * image.c (make_image, search_image_cache, lookup_image)
8640 (xpm_put_color_table_h):
8641 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8642 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8643 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8644 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8645 * alloc.c (allocate_vectorlike):
8646 Check for overflow in vector size calculations.
8647 * ccl.c (ccl_driver):
8648 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8649 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8650 need to be updated by these changes.
40087514
PE
8651 * fns.c (make_hash_table, maybe_resize_hash_table):
8652 Check for integer overflow with large hash tables.
0de4bb68
PE
8653 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8654 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8655 (SXHASH_REDUCE): New macro.
8656 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8657 Use it instead of discarding useful hash info with large hash values.
8658 (sxhash_float): New function.
8659 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8660 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8661 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8662 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8663 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8664 Adjust signatures to match updated version of code.
8665 (consing_since_gc): Now EMACS_INT, since a single hash table can
8666 use more than INT_MAX bytes.
8667
698d32e2
DN
86682011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8669
8670 Make it possible to build with GCC-4.6+ -O2 -flto.
8671
8672 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8673
fd6fa53f
SM
86742011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8675
8676 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8677 Call minibuffer-inactive-mode.
8678
864db017
JB
86792011-05-31 Juanma Barranquero <lekktu@gmail.com>
8680
8681 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8682 Update dependencies.
8683
2ad0baf4
DN
86842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8685
8686 * data.c (init_data): Remove code for UTS, this system is not
8687 supported anymore.
8688
4fcc2638
DN
86892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8690
8691 Don't force ./temacs to start in terminal mode.
8692
8693 * frame.c (make_initial_frame): Initialize faces in all cases, not
8694 only when CANNOT_DUMP is defined.
8695 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8696
c56e0fd5
DN
86972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8698
8699 * dispnew.c (add_window_display_history): Use const for the string
8700 pointer. Remove declaration, not needed.
8701
333d54da 87022011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8703
55d4c1b2 8704 Use 'inline', not 'INLINE'.
333d54da 8705 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8706 * alloc.c, fontset.c (INLINE): Remove.
8707 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8708 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8709 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8710 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8711 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8712
738db178
DN
87132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8714
8715 Make it possible to run ./temacs.
8716
8717 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8718 syms_of_callproc does the same thing. Remove test for
8719 "initialized", do it in the caller.
8720 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8721
620c53a6
SM
87222011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8723
8724 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8725 (read_minibuf): Use get_minibuffer.
8726 (syms_of_minibuf): Use DEFSYM.
8727 (Qmetadata): New var.
8728 * data.c (Qbuffer): Don't make it static.
8729 (syms_of_data): Use DEFSYM.
8730
e003a292
PE
87312011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8732
8733 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8734 (CCL_CODE_MIN): New macro.
8735
ed008a6d
PE
87362011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8737
3687c2ef
PE
8738 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8739
ed008a6d
PE
8740 * eval.c (Qdebug): Now static.
8741 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8742 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8743 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8744
d66c4c7c
CY
87452011-05-29 Chong Yidong <cyd@stupidchicken.com>
8746
8747 * image.c: Various fixes to ImageMagick code comments.
8748 (Fimagemagick_types): Doc fix.
8749
5fbc2025
PE
87502011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8751
0196f88a
PE
8752 Minor fixes prompted by GCC 4.6.0 warnings.
8753
8754 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8755
5fbc2025
PE
8756 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8757 (x_clipboard_manager_save_all): Move extern decl to ...
8758 * xterm.h: ... here, so that it can be checked for consistency.
8759
1dd3c2d9
CY
87602011-05-29 Chong Yidong <cyd@stupidchicken.com>
8761
8762 * xselect.c (x_clipboard_manager_save_frame)
8763 (x_clipboard_manager_save_all): New functions.
8764 (Fx_clipboard_manager_save): Lisp function deleted.
8765
8766 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8767 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8768
8769 * xterm.h: Update prototype.
8770
5ba6571d
WX
87712011-05-28 William Xu <william.xwl@gmail.com>
8772
8773 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8774 exiting (Bug#8239).
8775
3eaff834
JM
87762011-05-28 Jim Meyering <meyering@redhat.com>
8777
e1900994 8778 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8779 * fns.c (to_uchar): Define.
8780 (crypto_hash_function): Use it to convert some newly-signed
8781 variables to unsigned, to avoid sign-extension bugs. For example,
8782 without this change, (md5 "truc") would evaluate to
8783 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8784 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8785 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8786
0f6990a7
PE
87872011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8788
8789 Integer overflow fixes.
c8a9ca5a 8790
08686060
PE
8791 * dbusbind.c: Serial number integer overflow fixes.
8792 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8793 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8794 to hold a serial number that is too large for a fixnum.
8795 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8796 Check for serial numbers out of range. Decode any serial number
59568bf0 8797 that was so large that it became a float. (Bug#8722)
08686060 8798
2d1fc3c7
PE
8799 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8800 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8801 Use XFASTINT rather than XUINT when numbers are nonnegative.
8802 (xd_append_arg, Fdbus_method_return_internal):
8803 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8804 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8805 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8806 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8807 (Bug#8722)
2d1fc3c7 8808
c8a9ca5a
PE
8809 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8810
519e1d69
PE
8811 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8812
6df6ae42 8813 ccl: Add integer overflow checks.
30569699
PE
8814 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8815 (IN_INT_RANGE): New macros.
8816 (ccl_driver): Use them to check for integer overflow when
8817 decoding a CCL program. Many of the new checks are whether XINT (x)
8818 fits in int; it doesn't always, on 64-bit hosts. The new version
8819 doesn't catch all possible integer overflows, but it's an
847044ea 8820 improvement. (Bug#8719)
30569699 8821
c11285dc
PE
8822 * alloc.c (make_event_array): Use XINT, not XUINT.
8823 There's no need for unsigned here.
8824
fdccd48e
PE
8825 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8826 This follows up to the 2011-05-06 change that substituted uintptr_t
8827 for EMACS_INT. This case wasn't caught back then.
8828
37910ab2
PE
8829 Rework Fformat to avoid integer overflow issues.
8830 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8831 now (part of C89). Include <verify.h>.
8832 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8833 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8834 (Fformat): Avoid the prepass trying to compute sizes; it was only
8835 approximate and thus did not catch overflow reliably. Instead, walk
8836 through the format just once, formatting and computing sizes as we go,
8837 checking for integer overflow at every step, and allocating a larger
8838 buffer as needed. Keep track separately whether the format is
8839 multibyte. Keep only the most-recently calculated precision, rather
8840 than them all. Record whether each argument has been converted to
8841 string. Use EMACS_INT, not int, for byte and char and arg counts.
8842 Support field widths and precisions larger than INT_MAX. Avoid
8843 sprintf's undefined behavior with conversion specifications such as %#d
8844 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8845 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8846 formatting out-of-range floating point numbers with int
9173deec 8847 formats. (Bug#8668)
37910ab2 8848
2e6578fb
PE
8849 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8850
0ae6bdee
PE
8851 * data.c: Avoid integer truncation in expressions involving floats.
8852 * data.c: Include <intprops.h>.
8853 (arith_driver): When there's an integer overflow in an expression
8854 involving floating point, convert the integers to floating point
8855 so that the resulting value does not suffer from catastrophic
8856 integer truncation. For example, on a 64-bit host (* 4
8857 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8858 Do not rely on undefined behavior after integer overflow.
8859
de883a70
PE
8860 merge count_size_as_multibyte, parse_str_to_multibyte
8861 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8862 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8863 Check for integer overflow.
8864 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8865 since it's now a duplicate of the other. This is more of
8866 a character than a buffer op, so better that it's in character.c.
8867 * fns.c, print.c: Adjust to above changes.
8868
2ff916cb
PE
88692011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8870
8871 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8872
f1b54466
PE
88732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8874
fb1ac845
PE
8875 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8876 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8877 (x_clipboard_manager_save): Now static.
8878 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8879
f1b54466
PE
8880 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8881 (crypto_hash_function): Now static.
8882 Fix pointer signedness problems. Avoid unnecessary initializations.
8883
a9f737ee
CY
88842011-05-27 Chong Yidong <cyd@stupidchicken.com>
8885
8886 * termhooks.h (Vselection_alist): Make it terminal-local.
8887
8888 * terminal.c (create_terminal): Initialize it.
8889
8890 * xselect.c: Support for clipboard managers.
8891 (Vselection_alist): Move to termhooks.h as terminal-local var.
8892 (LOCAL_SELECTION): New macro.
8893 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8894 (symbol_to_x_atom): Remove gratuitous arg.
8895 (x_handle_selection_request, lisp_data_to_selection_data)
8896 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8897 (x_own_selection, x_get_local_selection, x_convert_selection):
8898 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8899 (some_frame_on_display): Delete unused function.
8900 (Fx_own_selection_internal, Fx_get_selection_internal)
8901 (Fx_disown_selection_internal, Fx_selection_owner_p)
8902 (Fx_selection_exists_p): New optional frame arg.
8903 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8904 (x_handle_selection_clear): Don't treat other terminals with the
8905 same keyboard specially. Use the terminal-local Vselection_alist.
8906 (x_clear_frame_selections): Use Frun_hook_with_args.
8907
8908 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8909
8910 * xterm.h: Add support for those atoms.
8911
e067f0c1
CY
89122011-05-26 Chong Yidong <cyd@stupidchicken.com>
8913
8914 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8915 (converted_selections, conversion_fail_tag): New global variables.
8916 (x_selection_request_lisp_error): Free the above.
8917 (x_get_local_selection): Remove unnecessary code.
8918 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8919 of converted selections stored in converted_selections.
8920 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8921 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8922 (x_convert_selection): New function.
8923 (x_handle_selection_event): Simplify.
8924 (x_get_foreign_selection): Don't ignore incoming requests while
8925 waiting for an answer; this will fail when we implement
8926 SAVE_TARGETS, and seems unnecessary anyway.
8927 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8928 (Vx_sent_selection_functions): Doc fix.
8929
0f4aebc0
LL
89302011-05-26 Leo Liu <sdl.web@gmail.com>
8931
8932 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8933
e61124cd
YM
89342011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8935
8936 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8937
8938 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8939 for fringe update if it has periodic bitmap.
ac389d0c 8940 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8941 and fringe_bitmap_periodic_p.
8942
8943 * fringe.c (get_fringe_bitmap_data): New function.
8944 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8945 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8946 row. Mark glyph row for fringe update if periodicity changed.
8947
8948 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8949 for fringe update unless it has periodic bitmap.
8950
f16d9837
KH
89512011-05-25 Kenichi Handa <handa@m17n.org>
8952
8953 * xdisp.c (get_next_display_element): Set correct it->face_id for
8954 a static composition.
8955
e1b90ef6
LL
89562011-05-24 Leo Liu <sdl.web@gmail.com>
8957
8958 * deps.mk (fns.o):
8959 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8960
8961 * fns.c (crypto_hash_function, Fsha1): New function.
8962 (Fmd5): Use crypto_hash_function.
8963 (syms_of_fns): Add Ssha1.
8964
7400048f
PE
89652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8966
8967 * gnutls.c: Remove unused macros.
8968 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8969 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8970 Remove macros that are defined and never used.
8971 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8972
abb71cf4
CY
89732011-05-22 Chong Yidong <cyd@stupidchicken.com>
8974
8975 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8976 (Fx_get_selection_internal): Minor cleanup.
8977 (Fx_own_selection_internal): Rename arguments for consistency with
8978 select.el.
8979
6307db39
PE
89802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8981
8982 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8983
f3d4e0a4
CY
89842011-05-22 Chong Yidong <cyd@stupidchicken.com>
8985
8986 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8987
4d8ade89
YM
89882011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8989
8990 * dispnew.c (scrolling_window): Don't exclude the case that the
8991 last enabled row in the desired matrix touches the bottom boundary.
8992
32078c8d
GM
89932011-05-21 Glenn Morris <rgm@gnu.org>
8994
8995 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8996 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8997 and add some more files.
32078c8d 8998
7285dc67
EZ
89992011-05-20 Eli Zaretskii <eliz@gnu.org>
9000
9001 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9002 report_file_error introduced by the change from 2011-05-07.
9003
89d1bd22
PE
90042011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9005
9006 * systime.h (Time): Define only if emacs is defined.
9007 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9008 where the include path doesn't have X11/X.h by default. See
9009 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9010
cd394be1 90112011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9012
9013 * composite.c (find_automatic_composition): Fix previous change.
9014
b9704ad9
GM
90152011-05-20 Glenn Morris <rgm@gnu.org>
9016
9017 * lisp.mk: New file, split from Makefile.in.
9018 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9019 (shortlisp): Remove.
9020 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9021
4a720484
GM
90222011-05-19 Glenn Morris <rgm@gnu.org>
9023
9024 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9025 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9026 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9027 (lisp): Set the order to that of loadup.el.
9028 (shortlisp): Make it a copy of $lisp.
9029 (SOME_MACHINE_LISP): Remove.
9030 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9031 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9032
a28d4396
KH
90332011-05-18 Kenichi Handa <handa@m17n.org>
9034
9035 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9036 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9037 (find_automatic_composition): Mostly rewrite for efficiency.
9038
a2b1fa8e
JB
90392011-05-18 Juanma Barranquero <lekktu@gmail.com>
9040
9041 * makefile.w32-in: Update dependencies.
9042
8e1f5610
CS
90432011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9044
9045 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9046 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9047
7025ee00 90482011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9049
cdfa6eab
PE
9050 Fix some integer overflow issues, such as string length overflow.
9051
06d6db33
PE
9052 * insdel.c (count_size_as_multibyte): Check for string overflow.
9053
2b4560a8
PE
9054 * character.c (lisp_string_width): Check for string overflow.
9055 Use EMACS_INT, not int, for string indexes and lengths; in
9056 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9057 the resulting string length overflows an EMACS_INT; instead,
9058 report a string overflow if no precision given. When checking for
9059 precision exhaustion, use a check that cannot possibly have
9060 integer overflow. (Bug#8675)
9061 * character.h (lisp_string_width): Adjust to new signature.
9062
cb93f9be
PE
9063 * alloc.c (string_overflow): New function.
9064 (Fmake_string): Use it. This doesn't change behavior, but saves
9065 a few bytes and will simplify future changes.
9066 * character.c (string_escape_byte8): Likewise.
9067 * lisp.h (string_overflow): New decl.
9068
1a1f3366
PE
9069 Fixups, following up to the user-interface timestamp change.
9070 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9071 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9072 * msdos.c (mouse_get_pos): Likewise.
9073 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9074 * w32gui.h (Time): Define by including "systime.h" rather than by
9075 declaring it ourselves. (Bug#8664)
9076
d4e3e4d3
PE
9077 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9078 * image.c (clear_image_cache): Likewise.
9079
f6a24d19
PE
9080 * term.c (term_mouse_position): Don't assume time_t wraparound.
9081
08dc5ae6
PE
9082 Be more systematic about user-interface timestamps.
9083 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9084 and sometimes 'EMACS_UINT', to represent these timestamps.
9085 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9086 This makes the code easier to follow, and makes it easier to catch
9087 integer overflow bugs such as Bug#8664.
9088 * frame.c (Fmouse_position, Fmouse_pixel_position):
9089 Use Time, not unsigned long, for user-interface timestamps.
9090 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9091 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9092 * keyboard.h (last_event_timestamp): Likewise.
9093 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9094 * menu.h (xmenu_show): Likewise.
9095 * term.c (term_mouse_position): Likewise.
9096 * termhooks.h (struct input_event.timestamp): Likewise.
9097 (struct terminal.mouse_position_hook): Likewise.
9098 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9099 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9100 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9101 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9102 what it was before.
9103 * menu.h, termhooks.h: Include "systime.h", for Time.
9104
8e55734a
PE
9105 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9106 Don't assume that the difference between two unsigned long values
9107 can fit into an integer. At this point, we know button_down_time
9108 <= event->timestamp, so the difference must be nonnegative, so
9109 there's no need to cast the result if double-click-time is
9110 nonnegative, as it should be; check that it's nonnegative, just in
9111 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9112 apart (about 25 days). (Bug#8664)
8e55734a 9113
841f1b75 9114 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9115 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9116
3e26f69c
PE
9117 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9118 that always fit in int. Use a sentinel instead of a counter, to
9119 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9120 * frame.h (struct frame): Use int for menu_bar_items_used
9121 instead of EMACS_INT, since it always fits in int.
3e26f69c 9122
5cc152c0
PE
9123 * menu.c (grow_menu_items): Check for int overflow.
9124
d89eb65e
PE
9125 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9126
5235bd3e
PE
9127 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9128 Before, the code was not consistent. These values cannot exceed
9129 2**31 - 1 so there's no need to make them unsigned.
9130 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9131 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9132 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9133 as modifiers.
9134 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9135
bc827e23
PE
9136 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9137 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9138 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9139 presumably because the widths might not match.
9140
78eb494e
PE
9141 * window.c (size_window): Avoid needless test at loop start.
9142
04f2d78b
CB
91432011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9144
9145 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9146
d2fc7e3d 91472011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9148
9149 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9150
d2fc7e3d 91512011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9152
9153 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9154 `width' to `bar_area_x' and `bar_area_width', respectively.
9155 (x_scroll_run): Take account of fringe background extension.
9156
04f2d78b
CB
9157 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9158 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9159 `bar_area_width', respectively.
9160 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9161 background extension.
9162
79b70037
GM
91632011-05-10 Jim Meyering <meyering@redhat.com>
9164
9165 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9166
2f142cc5
JB
91672011-05-10 Juanma Barranquero <lekktu@gmail.com>
9168
9169 * image.c (Finit_image_library): Return t for built-in image types,
9170 like pbm and xbm. (Bug#8640)
9171
57679c86
AS
91722011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9173
9174 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9175
888c9e86
EZ
91762011-05-07 Eli Zaretskii <eliz@gnu.org>
9177
b0512a1d
EZ
9178 * w32console.c (Fset_screen_color): Doc fix.
9179 (Fget_screen_color): New function.
9180 (syms_of_ntterm): Defsubr it.
9181
7285dc67
EZ
9182 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9183 unlink the temporary file if Fcall_process didn't create it in the
9184 first place.
9185 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9186 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9187 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9188 cue to call_process_cleanup not to close that handle.
9189
4d3fcc8e
BK
91902011-05-07 Ben Key <bkey76@gmail.com>
9191
9192 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9193 one of two shell specific rules, either bootstrap-temacs-CMD or
9194 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9195 to the previous implementation of the bootstrap-temacs rule.
9196 The bootstrap-temacs-CMD rule is similar to the previous
9197 implementation of the bootstrap-temacs rule except that it
9198 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9199 variable.
9200
9201 These changes, along with some changes to nt/configure.bat,
9202 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9203 earlier fix to add support for --cflags and --ldflags options
9204 that include quotes so that it works whether make uses cmd or
9205 sh as the shell.
9206
b4289b64
MA
92072011-05-06 Michael Albinus <michael.albinus@gmx.de>
9208
9209 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9210 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9211 is a constant.
9212 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9213 a string. Handle both cases.
9214 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9215 (Fdbus_register_method): Use Qinvalid_function.
9216
af4c0e28
JB
92172011-05-06 Juanma Barranquero <lekktu@gmail.com>
9218
9219 * makefile.w32-in: Update dependencies.
9220 (LISP_H): Add inttypes.h and stdin.h.
9221 (PROCESS_H): Add unistd.h.
9222
c51453d9
EZ
92232011-05-06 Eli Zaretskii <eliz@gnu.org>
9224
9225 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9226 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9227
8ff0ac3c 92282011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9229
4c4b566b
PE
9230 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9231
aab2b9b5
PE
9232 * term.c (vfatal): Remove stray call to va_end.
9233 It's not needed and the C Standard doesn't allow it here anyway.
9234
c378da0b
PE
9235 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9236 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9237
288b08c7
PE
9238 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9239 bytes.
9240
e3601888
PE
9241 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9242
db6c0e74
PE
9243 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9244
dd5963ea
PE
9245 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9246
88c9450f
PE
9247 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9248
2f9442b8
PE
9249 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9250
c032b5f8
PE
9251 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9252 * charset.c (Fdefine_charset_internal): Don't initialize
9253 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9254 32-bit int (Bug#8600).
a108c10b
PE
9255
9256 * lread.c (read_integer): Be more consistent with string-to-number.
9257 Use string_to_number to do the actual conversion; this avoids
9258 rounding errors and fixes some other screwups. Without this fix,
9259 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9260 (digit_to_number): Move earlier, for benefit of read_integer.
9261 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9262 not a digit in any supported base. (Bug#8602)
a108c10b 9263
ad5f9eea
PE
9264 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9265
aec1708a
PE
9266 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9267 to match comment at start of function. This also removes a
9268 GCC warning about overflow in a 32+64-bit port.
9269
47be4ab5
PE
9270 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9271
371cac43
PE
9272 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9273 Reported by Stefan Monnier in
9274 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9275 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9276 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9277
d01a7826
PE
9278 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9279 (EMACS_UINTPTR): Likewise, with uintptr_t.
9280
7fd47d5c
PE
9281 * lisp.h: Prefer 64-bit EMACS_INT if available.
9282 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9283 on 32-bit hosts that have 64-bit int, so that they can access
9284 large files.
122b0c86
PE
9285 However, temporarily disable this change unless the temporary
9286 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9287
8727937b
PE
9288 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9289
8ac068ac
PE
9290 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9291 This removes an assumption that EMACS_INT and long are the same
9292 width as pointers. The assumption is true for Emacs porting targets
9293 now, but we want to make other targets possible.
9294 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9295 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9296 In the rest of the code, change types of integers that hold casted
9297 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9298 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9299 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9300 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9301 No need to cast type when ORing.
9302 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9303 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9304 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9305 assume EMACS_INT is the same width as char *.
9306 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9307 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9308 Remove no-longer-needed casts.
9309 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9310 (xg_tool_bar_help_callback, xg_make_tool_item):
9311 Use EMACS_INTPTR to hold an integer
9312 that will be cast to void *; this can avoid a GCC warning
9313 if EMACS_INT is not the same width as void *.
9314 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9315 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9316 (current_message_1, set_message_1):
9317 Use a local to convert to proper width without a cast.
9318 * xmenu.c (dialog_selection_callback): Likewise.
9319
ede49d71
PE
9320 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9321 Also, don't assume VALBITS / RAND_BITS is less than 5,
9322 and don't rely on undefined behavior when shifting a 1 left into
9323 the sign bit.
9324 * lisp.h (get_random): Change signature to match.
9325
2f30ecd0
PE
9326 * lread.c (hash_string): Use size_t, not int, for hash computation.
9327 Normally we prefer signed values; but hashing is special, because
9328 it's better to use unsigned division on hash table sizes so that
9329 the remainder is nonnegative. Also, size_t is the natural width
9330 for hashing into memory. The previous code used 'int', which doesn't
9331 retain enough info to hash well into very large tables.
9332 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9333
2a866e7b
PE
9334 * dbusbind.c: Don't possibly lose pointer info when converting.
9335 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9336 Use XPNTR rather than XHASH, so that the high-order bits of
9337 the pointer aren't lost when converting through void *.
9338
51639eac
PE
9339 * eval.c (Fautoload): Don't double-shift a pointer.
9340
92394119
PE
9341 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9342
dbdb9a7c
JB
93432011-05-06 Juanma Barranquero <lekktu@gmail.com>
9344
9345 * gnutls.c (DEF_GNUTLS_FN):
9346 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9347
db7a0b4f
AS
93482011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9349
9350 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9351 marker. (Bug#8610)
9352
cd394be1 93532011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9354
9355 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9356 New version that can reserve upto 2GB of heap space.
9357
f7ff1b0f 93582011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9359
9360 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9361
639c109b
TZ
93622011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9363
9364 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9365 `gnutls_certificate_set_x509_key_file'.
9366
d2127135
JB
93672011-05-05 Juanma Barranquero <lekktu@gmail.com>
9368
9369 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9370 Update dependencies.
9371
e968f4f3
JB
93722011-05-04 Juanma Barranquero <lekktu@gmail.com>
9373
9374 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9375 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9376 Remove unused parameter `fildes'.
9377 * process.c (read_process_output, send_process): Don't pass it.
9378
84d358f0
JB
93792011-05-04 Juanma Barranquero <lekktu@gmail.com>
9380
9381 Fix previous change: the library cache is defined in w32.c.
9382 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9383 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9384
0898ca10
JB
93852011-05-04 Juanma Barranquero <lekktu@gmail.com>
9386
9387 Implement dynamic loading of GnuTLS on Windows.
9388
9389 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9390 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9391 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9392 Declare.
9393
9394 * gnutls.c (Qgnutls_dll): Define.
9395 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9396 (gnutls_*): Declare function pointers.
9397 (init_gnutls_functions): New function to initialize function pointers.
9398 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9399 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9400 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9401 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9402 (emacs_gnutls_write, emacs_gnutls_read)
9403 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9404 (Fgnutls_available_p): New function.
9405 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9406 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9407 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9408
9409 * image.c: Include w32.h.
9410 (Vimage_type_cache): Delete.
9411 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9412 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9413 (w32_delayed_load): Move to w32.c.
9414
9415 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9416
9417 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9418 (w32_delayed_load): Move from image.c. When loading a library, record
9419 its filename in the :loaded-from property of the library id.
9420 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9421 Initialize and staticpro them.
9422 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9423
9424 * process.c: Include lisp.h before w32.h, not after.
9425 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9426 instead of gnutls_record_check_pending.
9427
9428 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9429
ff4de4aa
TZ
94302011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9431
9432 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9433 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9434 as passed in.
9435
abe95abb
JD
94362011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9437
9438 * xterm.c (x_set_frame_alpha): Do not set property on anything
9439 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9440
e16e55d4
JB
94412011-05-02 Juanma Barranquero <lekktu@gmail.com>
9442
9443 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9444
bafcf6a5
JB
94452011-05-02 Juanma Barranquero <lekktu@gmail.com>
9446
9447 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9448 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9449 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9450 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9451 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9452 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9453 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9454 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9455 (Qgnutls_bootprop_callbacks_verify): Make static.
9456
e7a6747f
AS
94572011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9458
19ed11ba
AS
9459 * callproc.c: Indentation fixup.
9460
e7a6747f 9461 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9462 (wait_for_termination, interruptible_wait_for_termination):
9463 Move after wait_for_termination_1.
e7a6747f 9464
1ef14cb4
LMI
94652011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9466
9467 * sysdep.c (interruptible_wait_for_termination): New function
9468 which is like wait_for_termination, but allows keyboard
9469 interruptions.
9470
9471 * callproc.c (Fcall_process): Add (:file "file") as an option for
9472 the STDOUT buffer.
9473 (Fcall_process_region): Ditto.
9474
330d880c
EZ
94752011-04-30 Eli Zaretskii <eliz@gnu.org>
9476
8db90b73
EZ
9477 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9478 rather than `XVECTOR (FOO)->size'.
9479
330d880c
EZ
9480 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9481 inttypes.h, as a gnulib replacement is used if it not available in
9482 system headers.
9483
15cbd324
EZ
94842011-04-21 Eli Zaretskii <eliz@gnu.org>
9485
9486 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9487 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9488 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9489
9490 * coding.c (coding_alloc_by_realloc): Error out if destination
9491 will grow beyond MOST_POSITIVE_FIXNUM.
9492 (decode_coding_emacs_mule): Abort if there isn't enough place in
9493 charbuf for the composition carryover bytes. Reserve an extra
9494 space for up to 2 characters produced in a loop.
9495 (decode_coding_iso_2022): Abort if there isn't enough place in
9496 charbuf for the composition carryover bytes.
9497
94982011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9499
ae940cca
EZ
9500 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9501 aborting when %lld or %lll format is passed.
9502 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9503 %llo or %llx format is passed. (Bug#8545)
9504
03ab8921
EZ
9505 * window.c (window_scroll_line_based): Use a marker instead of
9506 simple variables to record original value of point. (Bug#7952)
9507
afda1437
EZ
9508 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9509 produced by %s or %c overflows available buffer space. (Bug#8545)
9510
f76dee0c
PE
95112011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9512
9513 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9514 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9515
fdc5744d
JB
95162011-04-28 Juanma Barranquero <lekktu@gmail.com>
9517
9518 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9519
638f053a
JB
95202011-04-28 Juanma Barranquero <lekktu@gmail.com>
9521
9522 * keyboard.c (Qdelayed_warnings_hook): Define.
9523 (command_loop_1): Run `delayed-warnings-hook'
9524 if Vdelayed_warnings_list is non-nil.
9525 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9526 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9527
d178f871
EZ
95282011-04-28 Eli Zaretskii <eliz@gnu.org>
9529
9530 * doprnt.c (doprnt): Don't return value smaller than the buffer
9531 size if the message was truncated. (Bug#8545).
9532
b124fd93
JB
95332011-04-28 Juanma Barranquero <lekktu@gmail.com>
9534
9535 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9536 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9537
e810457d
PE
95382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9539
9540 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9541
ea51cceb
JB
95422011-04-27 Juanma Barranquero <lekktu@gmail.com>
9543
9544 * makefile.w32-in: Update dependencies.
9545
94dcfacf
EZ
95462011-04-27 Eli Zaretskii <eliz@gnu.org>
9547
9548 Improve `doprnt' and its usage. (Bug#8545)
9549 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9550 `format_end'. Remove support for %l as a conversion specifier.
9551 Don't use xrealloc. Improve diagnostics when the %l size modifier
9552 is used. Update the commentary.
9553
9554 * eval.c (verror): Simplify calculation of size_t.
9555
9556 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9557 messages.
9558
f61f41d7
PE
95592011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9560
9561 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9562 change.
9563
96fb4434
PE
95642011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9565
9566 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9567 This makes this file independent of the recent pseudovector change.
9568
671875da 95692011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9570
69e9b5a3
PE
9571 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9572
b5f869a7 9573 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9574 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9575 Remove unused local.
c8926152 9576 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9577
841a1577 9578 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9579 GCC 4.6.0 optimizes based on type-based alias analysis.
9580 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9581 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9582 != &v->size, and therefore "v->size = 1; b->size = 2; return
9583 v->size;" must therefore return 1. This assumption is incorrect
9584 for Emacs, since it type-puns struct Lisp_Vector * with many other
9585 types. To fix this problem, this patch adds a new type struct
f904488f 9586 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9587 and pseudovectors, and helps optimizing compilers not get fooled
9588 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9589 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9590 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9591 the size member.
eab3844f
PE
9592 (XSETPVECTYPE): Rewrite in terms of new macro.
9593 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9594 This is a bit clearer, and further avoids the possibility of
9595 undesirable aliasing.
9596 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9597 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9598 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9599 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9600 (ASIZE): Now uses header.size rather than size.
9601 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9602 to avoid the hassle of writing XVECTOR (foo)->header.size.
9603 (struct vectorlike_header): New type.
eab3844f
PE
9604 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9605 object, to help avoid aliasing.
9606 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9607 (SUBRP): Likewise, since Lisp_Subr is a special case.
9608 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9609 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9610 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9611 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9612 changed to be "header.size" and "header.next".
9613 * buffer.h (struct buffer): Likewise.
9614 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9615 * frame.h (struct frame): Likewise.
9616 * process.h (struct Lisp_Process): Likewise.
9617 * termhooks.h (struct terminal): Likewise.
9618 * window.c (struct save_window_data, struct saved_window): Likewise.
9619 * window.h (struct window): Likewise.
9620 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9621 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9622 * buffer.c (init_buffer_once): Likewise.
9623 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9624 special case.
9625 * process.c (Fformat_network_address): Use local var for size,
9626 for brevity.
9627
0df1eac5
PE
9628 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9629
847ab9d1 9630 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9631 * data.c (atof): Remove decl; no longer used or needed.
9632 (digit_to_number): Move to lread.c.
9633 (Fstring_to_number): Use new string_to_number function, to be
9634 consistent with how the Lisp reader treats infinities and NaNs.
9635 Do not assume that floating-point numbers represent EMACS_INT
9636 without losing information; this is not true on most 64-bit hosts.
9637 Avoid double-rounding errors, by insisting on integers when
9638 parsing non-base-10 numbers, as the documentation specifies.
9639 * lisp.h (string_to_number): New decl, replacing ...
9640 (isfloat_string): Remove.
bc0a5c13 9641 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9642 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9643 appears to have been a coding error. Similarly, do not accept
9644 strings like +-1e0 as floating point numbers. Do not report
9645 overflow for integer overflows unless the base is not 10 which
9646 means we have no simple and reliable way to continue.
9647 Break out the floating-point parsing into a new
9648 function string_to_number, so that Fstring_to_number parses
9649 floating point numbers consistently with the Lisp reader.
04f2d78b 9650 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9651 (E_CHAR, EXP_INT): Remove, replacing with ...
9652 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9653 (string_to_number): New function, replacing isfloat_string.
9654 This function checks for valid syntax and produces the resulting
9655 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9656 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9657 so that overflow for non-base-10 numbers is reported only when
9658 there's no portable and simple way to convert to floating point.
452f4150 9659
67769ffc
PE
9660 * textprop.c (set_text_properties_1): Rewrite for clarity,
9661 and to avoid GCC warning about integer overflow.
9662
c20db43f
PE
9663 * intervals.h (struct interval): Use EMACS_INT for members
9664 where EMACS_UINT might cause problems. See
9665 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9666 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9667 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9668 All uses changed.
37aa2f85
PE
9669 (offset_intervals): Tell GCC not to worry about length overflow
9670 when negating a negative length.
c20db43f 9671
2538aa2f
PE
9672 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9673 (overrun_check_free): Likewise.
9674
f2d3008d
PE
9675 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9676 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9677 word size.
9678
ec8df744
PE
9679 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9680 (gnutls_make_error): Rename local to avoid shadowing.
9681 (gnutls_emacs_global_deinit): ifdef out; not used.
9682 (Fgnutls_boot): Use const for pointer to readonly storage.
9683 Comment out unused local. Fix pointer signedness problems.
9684
640ee02d
PE
9685 * lread.c (openp): Don't stuff size_t into an 'int'.
9686 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9687 about possible signed overflow.
9688
6048fb2a
PE
9689 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9690 (GDK_KEY_g): Don't define if already defined.
9691 (xg_prepare_tooltip): Avoid pointer signedness problem.
9692 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9693
fa3c87e1
PE
9694 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9695 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9696
2172544b
PE
9697 * xfns.c (Fx_window_property): Simplify a bit,
9698 to make a bit faster and to avoid GCC 4.6.0 warning.
9699 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9700
9b821a21
PE
9701 * fns.c (internal_equal): Don't assume size_t fits in int.
9702
3c616cfa
PE
9703 * alloc.c (compact_small_strings): Tighten assertion a little.
9704
c2982e87
PE
9705 Replace pEd with more-general pI, and fix some printf arg casts.
9706 * lisp.h (pI): New macro, generalizing old pEd macro to other
9707 conversion specifiers. For example, use "...%"pI"d..." rather
9708 than "...%"pEd"...".
9709 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9710 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9711 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9712 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9713 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9714 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9715 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9716 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9717 64-bit hosts.
9718 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9719 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9720 * print.c (safe_debug_print, print_object): Likewise.
9721 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9722 to int.
6f04d126
PE
9723 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9724 avoiding the 0 flag, which is not portable.
c2982e87
PE
9725 * process.c (Fmake_network_process): Use pI to avoid cast.
9726 * region-cache.c (pp_cache): Likewise.
9727 * xdisp.c (decode_mode_spec): Likewise.
9728 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9729 behavior on 64-bit hosts with printf arg.
6f04d126 9730 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9731 (x_stop_queuing_selection_requests): Likewise.
9732 (x_get_window_property): Don't truncate byte count to an 'int'
9733 when tracing.
0b432f21 9734
5e073ec7
PE
9735 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9736 here, since it parses constructs like leading '-' and spaces,
9737 which are not wanted; and it overflows with large numbers.
9738 Instead, simply match F[0-9]+, which is what is wanted anyway.
9739
36372bf9
PE
9740 * alloc.c: Remove unportable assumptions about struct layout.
9741 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9742 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9743 (allocate_vectorlike, make_pure_vector): Use the new macros,
9744 plus offsetof, to remove unportable assumptions about struct layout.
9745 These assumptions hold on all porting targets that I know of, but
9746 they are not guaranteed, they're easy to remove, and removing them
9747 makes further changes easier.
9748
0b432f21
PE
9749 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9750 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9751 (string_overrun_cookie): Now const. Use initializers that
9752 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9753 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9754 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9755 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9756 multiple of sizeof (EMACS_INT); it need not be, if
9757 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9758 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9759
895009e1
JB
97602011-04-26 Juanma Barranquero <lekktu@gmail.com>
9761
9762 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9763
6a7a1b0b
TZ
97642011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9765
9766 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9767 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9768 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9769
841a1577 97702011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9771
9772 * lisp.h (Qdebug): List symbol.
895009e1 9773 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9774 * keyboard.c (debug-on-event): New variable.
9775 (handle_user_signal): Break into debugger when debug-on-event
9776 matches the current signal symbol.
9777
f2d3ba6f
DN
97782011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9779
9780 * alloc.c (check_sblock, check_string_bytes)
9781 (check_string_free_list): Convert to standard C.
9782
42ce4c63
TZ
97832011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9784
9785 * w32.c (emacs_gnutls_push): Fix typo.
9786
825cd63c
EZ
97872011-04-25 Eli Zaretskii <eliz@gnu.org>
9788
fb11d64d
EZ
9789 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9790 "cast to pointer from integer of different size".
9791
825cd63c
EZ
9792 Improve doprnt and its use in verror. (Bug#8545)
9793 * doprnt.c (doprnt): Document the set of format control sequences
9794 supported by the function. Use SAFE_ALLOCA instead of always
9795 using `alloca'.
9796
9797 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9798 is one byte too soon. Don't use xrealloc; instead xfree and
9799 xmalloc anew.
9800
e061a11b
TZ
98012011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9802
9803 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9804 callbacks stage.
9805
9806 * gnutls.c: Renamed global_initialized to
9807 gnutls_global_initialized. Added internals for the
9808 :verify-hostname-error, :verify-error, and :verify-flags
9809 parameters of `gnutls-boot' and documented those parameters in the
9810 docstring. Start callback support.
9173deec
JB
9811 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9812 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9813 on error. Return error code.
e061a11b
TZ
9814 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9815 (emacs_gnutls_read): Likewise.
9816 (Fgnutls_boot): Return handshake error code.
9817 (emacs_gnutls_handle_error): New function.
9818 (wsaerror_to_errno): Likewise.
9819
9820 * w32.h (emacs_gnutls_pull): Add prototype.
9821 (emacs_gnutls_push): Likewise.
9822
9823 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9824 (emacs_gnutls_push): Likewise.
9825
98262011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9827
9828 * process.c (wait_reading_process_output): Check if GnuTLS
9829 buffered some data internally if no FDs are set for TLS
9830 connections.
9831
9832 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9833 (LIBS): Link to USER_LIBS.
9834 ($(BLD)/gnutls.$(0)): New target.
9835
fa6996bc
EZ
98362011-04-24 Eli Zaretskii <eliz@gnu.org>
9837
eb35682e
EZ
9838 * xdisp.c (handle_single_display_spec): Rename the
9839 display_replaced_before_p argument into display_replaced_p, to
9840 make it consistent with the commentary. Fix typos in the
9841 commentary.
9842
e2ad650c
EZ
9843 * textprop.c (syms_of_textprop): Remove dead code.
9844 (copy_text_properties): Delete obsolete commentary about an
9845 interface that was deleted long ago. Fix typos in the description
9846 of arguments.
9847
1b2de274
EZ
9848 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9849 to changes in oldXMenu/XMenu.h from 2011-04-16.
9850 <menu_help_message, prev_menu_help_message>: Constify.
9851 (IT_menu_make_room): menu->help_text is now `const char **';
9852 adjust.
9853
9854 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9855 to changes in oldXMenu/XMenu.h from 2011-04-16.
9856 (struct XMenu): Declare `help_text' `const char **'.
9857
9858 * xfaces.c <Qunspecified>: Make extern again.
9859
9860 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9861 required by POSIX.
1b2de274 9862
762b15be
EZ
9863 * doc.c (get_doc_string): Improve the format passed to `error'.
9864
9865 * doprnt.c (doprnt): Improve commentary.
9866
9867 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9868
9869 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9870 them with etags.
9871
f1052e5d
EZ
9872 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9873 changes in globals.h immediately force recompilation.
762b15be
EZ
9874 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9875 $(CURDIR)/s/ms-w32.h.
9876 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9877
fa6996bc
EZ
9878 * character.c (Fchar_direction): Function deleted.
9879 (syms_of_character): Don't defsubr it.
9880 <char-direction-table>: Deleted.
9881
e6c3da20
EZ
98822011-04-23 Eli Zaretskii <eliz@gnu.org>
9883
9884 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9885 * doprnt.c: Include limits.h.
9886 (SIZE_MAX): New macro.
04f2d78b
CB
9887 (doprnt): Return a size_t value. 2nd arg is now size_t.
9888 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9889 Improve overflow protection. Support `l' modifier for integer
9890 conversions. Support %l conversion. Don't assume an EMACS_INT
9891 argument for integer conversions and for %c.
9892
9893 * lisp.h (doprnt): Restore prototype.
9894
9895 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9896 $(SRC)/character.h.
9897
9898 * Makefile.in (base_obj): Add back doprnt.o.
9899
9900 * deps.mk (doprnt.o): Add back prerequisites.
9901 (callint.o): Depend on character.h.
9902
9903 * eval.c (internal_lisp_condition_case): Include the handler
9904 representation in the error message.
9905 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9906 when breaking from the loop.
9907
9908 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9909
9910 * callint.c (Fcall_interactively): When displaying error message
9911 about invalid control letter, pass the character's codepoint, not
9912 a pointer to its multibyte form. Improve display of the character
9913 in octal and display also its hex code.
9914
9915 * character.c (char_string): Use %x to display the (unsigned)
9916 codepoint of an invalid character, to avoid displaying a bogus
9917 negative value.
9918
9919 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9920 `error', not SYMBOL_NAME itself.
9921
9922 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9923 character arguments to `error'.
9924
9925 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9926 to `error' in error message about FINAL_CHAR argument. Make sure
9927 FINAL_CHAR is a character, and use %c when it is passed as
9928 argument to `error'.
9929
4ffd0d6b 99302011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9931
9932 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9933
9934 * w32.c: Include <time.h>.
9935 (sys_localtime): New function.
9936
4ffd0d6b 99372011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9938
9939 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9940
4ffd0d6b 9941 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9942
4ffd0d6b 99432011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9944
4ffd0d6b
GM
9945 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9946 zombies (Bug#8467).
aac0c6e3 9947
04c56954
EZ
99482011-04-19 Eli Zaretskii <eliz@gnu.org>
9949
9950 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9951 gl_state.e_property when gl_state.object is Qt.
9952
9953 * insdel.c (make_gap_larger): Remove limitation of buffer size
9954 to <= INT_MAX.
9955
16a43933
CY
99562011-04-18 Chong Yidong <cyd@stupidchicken.com>
9957
9958 * xdisp.c (lookup_glyphless_char_display)
9959 (produce_glyphless_glyph): Handle cons cell entry in
9960 glyphless-char-display.
9961 (Vglyphless_char_display): Document it.
9962
9963 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9964 glyphless-char-display.
9965
4581706e
CY
99662011-04-17 Chong Yidong <cyd@stupidchicken.com>
9967
9968 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9969
9970 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9971
9972 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9973 definition for no-X builds.
9974
4887c6e2 99752011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9976
fd35b6f9
PE
9977 Static checks with GCC 4.6.0 and non-default toolkits.
9978
5c1ccb01
PE
9979 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9980
006c5daa
PE
9981 * process.c (keyboard_bit_set): Define only if SIGIO.
9982 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9983 (send_process): Repair possible setjmp clobbering.
9984
efc736d3
PE
9985 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9986
4e2fe2e6
PE
9987 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9988
f97334a2
PE
9989 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9990
4e75f29d
PE
9991 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9992 Define only if needed.
9993
90efadd1
PE
9994 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9995 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9996 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9997
3c647824
PE
9998 * dispextern.h (struct redisplay_interface): Rename param
9999 to avoid shadowing.
e264f262 10000 * termhooks.h (struct terminal): Likewise.
761383f4 10001 * xterm.c (xembed_send_message): Likewise.
3c647824 10002
b58c5c4a
PE
10003 * insdel.c (make_gap_smaller): Define only if
10004 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10005
cad59032
PE
10006 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10007 it.
10008
c339dc2e
PE
10009 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10010 so that we aren't warned about unused symbols.
10011
91a3e27b
PE
10012 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10013
399c71d3 10014 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10015
8ffc96f5
PE
10016 * xfns.c (x_real_positions): Mark locals as initialized.
10017
eef9bc79
PE
10018 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10019
098db9dd
PE
10020 * xterm.c: Fix problems found by static analysis with other toolkits.
10021 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10022 (x_dispatch_event): Declare static if USE_GTK, and
10023 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10024 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10025 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10026 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10027 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10028
eb18f6cc
PE
10029 * xmenu.c (menu_help_callback): Pointer type fixes.
10030 Use const pointers when pointing at readonly data. Avoid pointer
10031 signedness clashes.
10032 (FALSE): Remove unused macro.
10033 (update_frame_menubar): Remove unused decl.
10034
1fe72bf8
PE
10035 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10036
60d9e1db
PE
10037 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10038 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10039 (single_menu_item): Rename local to avoid shadowing.
10040
39261c26
PE
10041 * keyboard.c (make_lispy_event): Remove unused local var.
10042
018c5e19
PE
10043 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10044 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10045
63d2b86e
PE
10046 * bitmaps: Change bitmaps from unsigned char back to the X11
10047 compatible char. Avoid the old compiler warnings about
10048 out-of-range initializers by using, for example, '\xab' rather
10049 than 0xab.
10050
aefd87e1
PE
10051 * xgselect.c (xgselect_initialize): Check vs interface
10052 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10053
bf501fb9
PE
10054 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10055
e9829fdf
PE
10056 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10057 to read-only memory.
10058
1086c095
PE
10059 * fns.c (vector): Remove; this old hack is no longer needed.
10060
2baccd04 10061 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10062 Remove unused var.
dde42981 10063 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10064
72391843 10065 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10066
436c16df 10067 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10068 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10069 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10070
92bb796d 10071 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10072 (x_term_init): Remove local to avoid shadowing.
92bb796d 10073
764430a3 10074 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10075
10076 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10077 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10078
d1dfb56c
EZ
100792011-04-16 Eli Zaretskii <eliz@gnu.org>
10080
c4354cb4
EZ
10081 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10082
d1dfb56c
EZ
10083 Fix regex.c, syntax.c and friends for buffers > 2GB.
10084 * syntax.h (struct gl_state_s): Declare character position members
10085 EMACS_INT.
10086
10087 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10088
04f2d78b
CB
10089 * textprop.c (verify_interval_modification, interval_of):
10090 Declare arguments EMACS_INT.
d1dfb56c
EZ
10091
10092 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10093 EMACS_INT.
10094
10095 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10096
10097 * indent.c (Fvertical_motion): Local variable it_start is now
10098 EMACS_INT.
10099
10100 * regex.c (re_match, re_match_2, re_match_2_internal)
10101 (bcmp_translate, regcomp, regexec, print_double_string)
10102 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10103 (re_compile_pattern, re_exec): Declare arguments and local
10104 variables `size_t' and `ssize_t' and return values `regoff_t', as
10105 appropriate.
10106 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10107 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10108 <compile_stack_type>: `size' and `avail' are now `size_t'.
10109
10110 * regex.h <regoff_t>: Use ssize_t, not int.
10111 (re_search, re_search_2, re_match, re_match_2): Arguments that
10112 specify buffer/string position and length are now ssize_t and
10113 size_t. Return type is regoff_t.
10114
613052cd
BK
101152011-04-16 Ben Key <bkey76@gmail.com>
10116
10117 * nsfont.m: Fixed bugs in ns_get_family and
10118 ns_descriptor_to_entity that were caused by using free to
10119 deallocate memory blocks that were allocated by xmalloc (via
10120 xstrdup). This caused Emacs to crash when compiled with
10121 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10122 --enable-checking=xmallocoverrun). xfree is now used to
10123 deallocate these memory blocks.
10124
4170f62f 101252011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10126
71b41406
PE
10127 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10128
9587a89d
PE
10129 emacs_write: Accept and return EMACS_INT for sizes.
10130 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10131 et seq.
10132 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10133 Accept and return EMACS_INT.
10134 (emacs_gnutls_write): Return the number of bytes written on
10135 partial writes.
10136 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10137 (emacs_read, emacs_write): Remove check for negative size, as the
10138 Emacs source code has been audited now.
9587a89d
PE
10139 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10140 (emacs_read, emacs_write): Use it.
273a5f82
PE
10141 * process.c (send_process): Adjust to the new signatures of
10142 emacs_write and emacs_gnutls_write. Do not attempt to store
10143 a byte offset into an 'int'; it might overflow.
9587a89d 10144 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10145
3e047f51
PE
10146 * sound.c: Don't assume sizes fit in 'int'.
10147 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10148 Return EMACS_INT, not int.
3e047f51 10149 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10150 Accept EMACS_INT, not int.
10151 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10152 record read return values.
10153
cc39a9db
BK
101542011-04-15 Ben Key <bkey76@gmail.com>
10155
c9d0ec6d
JB
10156 * keyboard.c (Qundefined): Don't declare static since it is used
10157 in nsfns.m.
10158 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10159 static since they are used in nsfont.m.
cc39a9db 10160
6c60eb9f
SM
101612011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10162
10163 * process.c (Qprocessp): Don't declare static.
10164 * lisp.h (Qprocessp): Declare again.
10165
7990b61a
JB
101662011-04-15 Juanma Barranquero <lekktu@gmail.com>
10167
10168 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10169
5d4cb038
PE
101702011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10171
8bd7b830 10172 Improve C-level modularity by making more things 'static'.
cd64ea1d 10173
e3b27b31
PE
10174 Don't publish debugger-only interfaces to other modules.
10175 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10176 (verify_bytepos, count_markers): Move decls to the only modules
10177 that need them.
10178 * region-cache.h (pp_cache): Likewise.
10179 * window.h (check_all_windows): Likewise.
10180 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10181
5d4cb038
PE
10182 * sysdep.c (croak): Now static, if
10183 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10184 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10185
10186 * alloc.c (refill_memory_reserve): Now static if
10187 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10188 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10189
e87b6180
PE
10190 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10191 Define only if USE_LUCID.
10192
ac64929e
PE
10193 * xrdb.c (x_customization_string, x_rm_string): Now static.
10194
6f37259d
PE
10195 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10196 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10197
1683e3ab
PE
10198 * xdisp.c (draw_row_with_mouse_face): Now static.
10199 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10200
de9c2632
PE
10201 * window.h (check_all_windows): Mark externally visible.
10202
2b96acb7
PE
10203 * window.c (window_deletion_count): Now static.
10204
10205 * undo.c: Make symbols static if they're not exported.
10206 (last_undo_buffer, last_boundary_position, pending_boundary):
10207 Now static.
10208
50436f33
PE
10209 * textprop.c (interval_insert_behind_hooks): Now static.
10210 (interval_insert_in_front_hooks): Likewise.
10211
64520e5c
PE
10212 * term.c: Make symbols static if they're not exported.
10213 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10214 (max_frame_lines, tty_set_terminal_modes):
10215 (tty_reset_terminal_modes, tty_turn_off_highlight):
10216 (get_tty_terminal): Now static.
10217 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10218 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10219 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10220 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10221 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10222
1fa53021
PE
10223 * sysdep.c: Make symbols static if they're not exported.
10224 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10225 Now static.
10226 (sigprocmask_set, full_mask): Remove; unused.
10227 (wait_debugging): Mark as visible.
10228 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10229 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10230
d4b43b22
PE
10231 * syntax.c (syntax_temp): Define only if !__GNUC__.
10232
b7c513d0
PE
10233 * sound.c (current_sound_device, current_sound): Now static.
10234
989b29ad
PE
10235 * search.c (searchbufs, searchbuf_head): Now static.
10236
13a55a78
PE
10237 * scroll.c (scroll_cost): Remove; unused.
10238 * dispextern.h (scroll_cost): Remove decl.
10239
de68a1fc
PE
10240 * region-cache.h (pp_cache): Mark as externally visible.
10241
40ccffa6
PE
10242 * process.c: Make symbols static if they're not exported.
10243 (process_tick, update_tick, create_process, chan_process):
10244 (Vprocess_alist, proc_buffered_char, datagram_access):
10245 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10246 (deactivate_process): Mark defn as static, as well as decl.
10247 * lisp.h (create_process): Remove decl.
10248 * process.h (chan_process, Vprocess_alist): Remove decls.
10249
ad64fc97
PE
10250 * print.c: Make symbols static if they're not exported.
10251 (print_depth, new_backquote_output, being_printed, print_buffer):
10252 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10253 (print_interval, print_number_index, initial_stderr_stream):
10254 Now static.
10255 * lisp.h (Fprinc): Remove decl.
10256 (debug_output_compilation_hack): Mark as externally visible.
10257
adddb265
PE
10258 * sysdep.c (croak): Move decl from here to syssignal.h.
10259 * syssignal.h (croak): Put it here, so the API can be checked when
10260 'croak' is called from dissociate_if_controlling_tty.
10261
1717ede2
PE
10262 * minibuf.c: Make symbols static if they're not exported.
10263 (minibuf_save_list, choose_minibuf_frame): Now static.
10264 * lisp.h (choose_minibuf_frame): Remove decl.
10265
fa5fb2bc
PE
10266 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10267
1e3890d1
PE
10268 * lread.c: Make symbols static if they're not exported.
10269 (read_objects, initial_obarray, oblookup_last_bucket_number):
10270 Now static.
10271 (make_symbol): Remove; unused.
10272 * lisp.h (initial_obarray, make_symbol): Remove decls.
10273
8a1414fa
PE
10274 * keyboard.c: Make symbols static if they're not exported.
10275 (single_kboard, recent_keys_index, total_keys, recent_keys):
10276 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10277 (this_single_command_key_start, echoing, last_auto_save):
10278 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10279 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10280 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10281 (Vlispy_mouse_stem, double_click_count):
10282 Now static.
10283 (force_auto_save_soon): Define only if SIGDANGER.
10284 (ignore_mouse_drag_p): Now static if
10285 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10286 (print_help): Remove; unused.
10287 (stop_character, last_timer_event): Mark as externally visible.
10288 * keyboard.h (ignore_mouse_drag_p): Declare only if
10289 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10290 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10291 * lisp.h (echoing): Remove decl.
10292 (force_auto_save_soon): Declare only if SIGDANGER.
10293 * xdisp.c (redisplay_window): Simplify code, to make it more
10294 obvious that ignore_mouse_drag_p is not accessed if !defined
10295 USE_GTK && !defined HAVE_NS.
10296
93ea6e8f
PE
10297 * intervals.c: Make symbols static if they're not exported.
10298 (merge_properties_sticky, merge_interval_right, delete_interval):
10299 Now static.
10300 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10301
77382fcc
PE
10302 * insdel.c: Make symbols static if they're not exported.
10303 However, leave prepare_to_modify_buffer alone. It's never
10304 called from outside this function, but that appears to be a bug.
10305 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10306 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10307 (adjust_after_replace_noundo): Remove; unused.
10308 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10309 (signal_before_change): Remove decls.
77382fcc 10310
9306c32e
PE
10311 * indent.c (val_compute_motion, val_vmotion): Now static.
10312
cd44d2eb
PE
10313 * image.c: Make symbols static if they're not exported.
10314 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10315 if USE_GTK.
10316 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10317 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10318
ad9a7a06
PE
10319 * fringe.c (standard_bitmaps): Now static.
10320 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10321
81626931
PE
10322 * frame.c: Make symbols static if they're not exported.
10323 (x_report_frame_params, make_terminal_frame): Now static.
10324 (get_frame_param): Now static, unless HAVE_NS.
10325 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10326 (x_get_resource_string): Remove; not used.
10327 * frame.h (make_terminal_frame, x_report_frame_params):
10328 (x_get_resource_string); Remove decls.
10329 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10330 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10331
239f9db9
PE
10332 * font.c, fontset.c: Make symbols static if they're not exported.
10333 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10334 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10335 * font.c (font_close_object): Now static.
10336 * font.h (font_close_object): Remove.
10337 * fontset.c (FONTSET_OBJLIST): Remove.
10338 (free_realized_fontset) #if-0 the body, which does nothing.
10339 (face_suitable_for_char_p): #if-0, as it's never called.
10340 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10341 * xfaces.c (face_at_string_position):
10342 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10343 since 0 is always ASCII.
10344
dfcf3579
PE
10345 * fns.c (weak_hash_tables): Now static.
10346
5045092b
PE
10347 * fileio.c: Make symbols static if they're not exported.
10348 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10349 (Vwrite_region_annotation_buffers): Now static.
10350
57a96f5c
PE
10351 * eval.c: Make symbols static if they're not exported.
10352 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10353 * lisp.h (backtrace_list): Remove decl.
10354
35f08c38
PE
10355 * emacs.c: Make symbols static if they're not exported.
10356 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10357 (fatal_error_code, fatal_error_signal_hook, standard_args):
10358 Now static.
10359 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10360 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10361 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10362 * lisp.h (fatal_error_signal_hook): Remove decl.
10363 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10364
f44bd759
PE
10365 * editfns.c: Move a (normally-unused) function to its only use.
10366 * editfns.c, lisp.h (get_operating_system_release): Remove.
10367 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10368 worth the hassle of breaking this out.
10369
b532497d
PE
10370 * xterm.c: Make symbols static if they're not exported.
10371 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10372 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10373 (x_destroy_window, x_delete_display):
10374 Now static.
10375 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10376 (x_mouse_leave): Remove; unused.
10377 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10378 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10379 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10380 Remove decls.
10381 (x_mouse_leave): Declare only if WINDOWSNT.
10382 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10383 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10384 USE_X_TOOLKIT.
10385
1675728f
PE
10386 * ftxfont.c: Make symbols static if they're not exported.
10387 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10388 HAVE_FREETYPE.
10389 * font.h (ftxfont_driver): Likewise.
10390
e4cebfca
PE
10391 * xfns.c: Make symbols static if they're not exported.
10392 (x_last_font_name, x_display_info_for_name):
10393 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10394 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10395 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10396 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10397 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10398 (last_show_tip_args): Now static.
10399 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10400 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10401 (x_screen_planes): Remove; unused.
10402 * dispextern.h (x_screen_planes): Remove decl.
10403
5bf46f05
PE
10404 * dispnew.c: Make symbols static if they're not exported.
10405 * dispextern.h (redraw_garbaged_frames, scrolling):
10406 (increment_row_positions): Remove.
10407 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10408 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10409 Now static.
10410 (redraw_garbaged_frames): Remove; unused.
10411
435f4c28
PE
10412 * xfaces.c: Make symbols static if they're not exported.
10413 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10414 Remove decls.
10415 * xterm.h (defined_color): Remove decls.
10416 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10417 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10418 (menu_face_changed_default, defined_color, free_realized_face):
10419 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10420 (ascii_face_of_lisp_face): Remove; unused.
10421
8524aef3
PE
10422 * xdisp.c: Make symbols static if they're not exported.
10423 * dispextern.h (scratch_glyph_row, window_box_edges):
10424 (glyph_to_pixel_coords, set_cursor_from_row):
10425 (get_next_display_element, set_iterator_to_next):
10426 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10427 (show_mouse_face): Remove decls
10428 * frame.h (message_buf_print): Likewise.
10429 * lisp.h (pop_message, set_message, check_point_in_composition):
10430 Likewise.
10431 * xterm.h (set_vertical_scroll_bar): Likewise.
10432 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10433 (message_buf_print, scratch_glyph_row, displayed_buffer):
10434 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10435 (get_next_display_element, show_mouse_face, window_box_edges):
10436 (frame_to_window_pixel_xy, check_point_in_composition):
10437 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10438 (glyph_to_pixel_coords): Remove; unused.
10439
16390cd2
PE
10440 * dired.c (file_name_completion): Now static.
10441
10442 * dbusbind.c (xd_in_read_queued_messages): Now static.
10443
a25f4dfa
PE
10444 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10445 * data.c (circular_list_error): Remove.
10446
14a9c8df
PE
10447 * commands.h (last_point_position, last_point_position_buffer):
10448 (last_point_position_window): Remove decls.
10449 * keyboard.c: Make these variables static.
10450
04f2d78b
CB
10451 * coding.h (coding, code_convert_region, encode_coding_gap):
10452 Remove decls.
74ab6df5
PE
10453 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10454 (iso_code_class, detect_coding, code_convert_region): Now static.
10455 (encode_coding_gap): Remove; unused.
10456
38dfbee1
PE
10457 * chartab.c (chartab_chars, chartab_bits): Now static.
10458
a2cb4e63
PE
10459 * charset.h (charset_iso_8859_1): Remove decl.
10460 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10461 Now static.
10462
127198fd
PE
10463 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10464 * ccl.c (Vccl_program_table): Now static.
10465 (check_ccl_update): Remove; unused.
10466
d85b608f
PE
10467 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10468 * category.h: ... from here.
10469 * category.c (check_category_table, set_category_set): Now static.
10470
31cd66f3
PE
10471 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10472 * lisp.h: Remove these decls.
10473
c358e587
PE
10474 * buffer.c (buffer_count): Remove unused var.
10475
e78aecca
PE
10476 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10477 so that it's not optimized away.
10478 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10479 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10480 exported only to the debugger.
10481
e192d7d3 10482 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10483 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10484
92470028
PE
10485 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10486 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10487 was inaccessible from Lisp.
10488 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10489 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10490
244ed907
PE
10491 alloc.c: Import and export fewer symbols, and remove unused items.
10492 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10493 is defined.
10494 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10495 it's not optimized away by whole-program optimization.
10496 (message_enable_multibyte, free_misc): Remove.
10497 (catchlist, handlerlist, mark_backtrace):
10498 Declare only if BYTE_MARK_STACK.
10499 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10500 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10501 (message_enable_multibyte): Remove decl.
10502 (free_misc, interval_free_list, float_block, float_block_index):
10503 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10504 (cons_free_list, last_marked_index):
10505 Now static.
10506 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10507 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10508 (mark_backtrace): Define only if BYTE_MARK_STACK.
10509 * xdisp.c (message_enable_multibyte): Now static.
10510
61c2b50e 10511 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10512 This makes it easier for human readers (and static analyzers)
10513 to see whether these variables are used from other modules.
10514 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10515 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10516 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10517 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10518 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10519 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10520 * xmenu.c, xselect.c:
10521 Declare Q* vars static if they are not used in other modules.
10522 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10523 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10524 Remove decls of unexported vars.
10525 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10526
95c82688
PE
10527 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10528
16a97296
PE
10529 Make Emacs functions such as Fatom 'static' by default.
10530 This makes it easier for human readers (and static analyzers)
10531 to see whether these functions can be called from other modules.
10532 DEFUN now defines a static function. To make the function external
10533 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10534 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10535 (Finit_image_library):
16a97296
PE
10536 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10537 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10538 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10539 Remove decls, since these functions are now static.
10540 (Funintern, Fget_internal_run_time): New decls, since these functions
10541 were already external.
95c82688 10542
16a97296
PE
10543 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10544 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10545 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10546 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10547 * keyboard.c, keymap.c, lread.c:
10548 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10549 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10550 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10551 Mark functions with DEFUE instead of DEFUN,
10552 if they are used in other modules.
10553 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10554 decls for now-static functions.
10555 * buffer.h (Fdelete_overlay): Remove decl.
10556 * callproc.c (Fgetenv_internal): Mark as internal.
10557 * composite.c (Fremove_list_of_text_properties): Remove decl.
10558 (Fcomposition_get_gstring): New forward static decl.
10559 * composite.h (Fcomposite_get_gstring): Remove decl.
10560 * dired.c (Ffile_attributes): New forward static decl.
10561 * doc.c (Fdocumntation_property): New forward static decl.
10562 * eval.c (Ffetch_bytecode): New forward static decl.
10563 (Funintern): Remove extern decl; now in .h file where it belongs.
10564 * fileio.c (Fmake_symbolic_link): New forward static decl.
10565 * image.c (Finit_image_library): New forward static decl.
10566 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10567 * intervals.h (Fprevious_property_change):
10568 (Fremove_list_of_text_properties): Remove decls.
10569 * keyboard.c (Fthis_command_keys): Remove decl.
10570 (Fcommand_execute): New forward static decl.
10571 * keymap.c (Flookup_key): New forward static decl.
10572 (Fcopy_keymap): Now static.
10573 * keymap.h (Flookup_key): Remove decl.
10574 * process.c (Fget_process): New forward static decl.
10575 (Fprocess_datagram_address): Mark as internal.
10576 * syntax.c (Fsyntax_table_p): New forward static decl.
10577 (skip_chars): Remove duplicate decl.
10578 * textprop.c (Fprevious_property_change): New forward static decl.
10579 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10580 Now internal.
10581 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10582 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10583
785bbd42
PE
10584 * editfns.c (Fformat): Remove unreachable code.
10585
8b913b57
AS
105862011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10587
10588 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10589 change. (Bug#8496)
10590
a6744a35
EZ
105912011-04-13 Eli Zaretskii <eliz@gnu.org>
10592
10593 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10594 when at ZV. (Bug#8487)
10595
e7974947
AS
105962011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10597
baad03f0
AS
10598 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10599 (Bug#8437)
10600 * keyboard.c (parse_tool_bar_item): Likewise.
10601 * sound.c (sound_cleanup, alsa_close): Likewise.
10602 * termcap.c (tgetent): Likewise.
10603 * xfns.c (x_default_font_parameter): Likewise.
10604 * xsettings.c (read_and_apply_settings): Likewise.
10605
e7974947
AS
10606 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10607 (overrun_check_free): Protoize.
10608
28272684
PE
106092011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10610
10611 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10612 since callers should never pass a negative size.
10613 Change the signature to match that of plain 'read' and 'write'; see
10614 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10615 * lisp.h: Update prototypes of emacs_write and emacs_read.
10616
11997c76
EZ
106172011-04-11 Eli Zaretskii <eliz@gnu.org>
10618
10619 * xdisp.c (redisplay_window): Don't try to determine the character
10620 position of the scroll margin if the window start point w->startp
e896f03c 10621 is outside the buffer's accessible region. (Bug#8468)
11997c76 10622
8a2cbd72
EZ
106232011-04-10 Eli Zaretskii <eliz@gnu.org>
10624
10625 Fix write-region and its subroutines for buffers > 2GB.
10626 * fileio.c (a_write, e_write): Modify declaration of arguments and
10627 local variables to support buffers larger than 2GB.
10628 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10629
10630 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10631 argument, local variables, and return value.
10632
10633 * lisp.h: Update prototypes of emacs_write and emacs_read.
10634
10635 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10636
4073e537 106372011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10638
1ebfdcb6
PE
10639 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10640
b2ded58d
PE
10641 Fix more problems found by GCC 4.6.0's static checks.
10642
7d66342c
PE
10643 * xdisp.c (vmessage): Use a better test for character truncation.
10644
bbf47d44
PE
10645 * charset.c (load_charset_map): <, not <=, for optimization,
10646 and to avoid potential problems with integer overflow.
9248994d 10647 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10648 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10649 * editfns.c (Fformat): Likewise.
1e69125e 10650 * syntax.c (skip_chars): Likewise.
3befa583 10651
e3019616
PE
10652 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10653 This also lets GCC 4.6.0 generate slightly better loop code.
10654
becfa255
PE
10655 * callint.c (Fcall_interactively): <, not <=, for optimization.
10656 (Fcall_interactively): Count the number of arguments produced,
10657 not the number of arguments given. This is simpler and lets GCC
10658 4.6.0 generate slightly better code.
10659
dae0cd48
PE
10660 * ftfont.c: Distingish more carefully between FcChar8 and char.
10661 The previous code passed unsigned char * to a functions like
10662 strlen and xstrcasecmp that expect char *, which does not
10663 conform to the C standard.
10664 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10665 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10666 char * when the C standard requires it.
10667
76032d70
PE
10668 * keyboard.c (read_char): Remove unused var.
10669
eb3f1cc8
PE
10670 * eval.c: Port to Windows vsnprintf (Bug#8435).
10671 Include <limits.h>.
10672 (SIZE_MAX): Define if the headers do not.
10673 (verror): Do not give up if vsnprintf returns a negative count.
10674 Instead, grow the buffer. This ports to Windows vsnprintf, which
10675 does not conform to C99. Problem reported by Eli Zaretskii.
10676 Also, simplify the allocation scheme, by avoiding the need for
10677 calling realloc, and removing the ALLOCATED variable.
10678
70476b54
PE
10679 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10680
12020a9e
PE
10681 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10682 But keep the doprint source code for now, as we might revamp it
10683 and use it again (Bug#8435).
ea6c7ae6
PE
10684 * lisp.h (doprnt): Remove.
10685 * Makefile.in (base_obj): Remove doprnt.o.
10686 * deps.mk (doprnt.o): Remove.
10687
5fdb398c
PE
10688 error: Print 32- and 64-bit integers portably (Bug#8435).
10689 Without this change, on typical 64-bit hosts error ("...%d...", N)
10690 was used to print both 32- and 64-bit integers N, which relied on
10691 undefined behavior.
61bdb816 10692 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10693 * lisp.h (error, verror): Mark as printf-like functions.
10694 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10695 Report overflow in size calculations when allocating printf buffer.
10696 Do not truncate output string at its first null byte.
10697 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10698 Truncate the output at a character boundary, since vsnprintf does not
10699 do that.
10700 * charset.c (check_iso_charset_parameter): Convert internal
10701 character to string before calling 'error', since %c now has the
10702 printf meaning.
10703 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10704 overflow when computing char to be passed to 'error'. Do not
10705 pass Lisp_Object to 'error'; pass the integer instead.
10706 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10707 formatted with plain %d.
10708
b189fa66
PE
10709 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10710
bff87ef0
PE
10711 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10712
7e2cac20
PE
10713 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10714
ce4d90b5
PE
10715 * xterm.c (x_catch_errors): Remove duplicate declaration.
10716
266c9547
PE
10717 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10718
79c49ad2
PE
10719 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10720
368f4090
JM
107212011-04-10 Jim Meyering <meyering@redhat.com>
10722
10723 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10724 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10725 return ssize_t not "int", and use size_t as the buffer length.
10726 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10727 * gnutls.h: Update declarations.
10728 * process.c (read_process_output): Use ssize_t, to match.
10729 (send_process): Likewise.
10730
a32d4040
CY
107312011-04-09 Chong Yidong <cyd@stupidchicken.com>
10732
10733 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10734
8546720e 107352011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10736
04f2d78b
CB
10737 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10738 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10739
8546720e
GM
10740 * xterm.c (handle_one_xevent):
10741 * xmenu.c (create_and_show_popup_menu):
10742 * xselect.c (x_decline_selection_request)
10743 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10744
0a2f5c1a 107452011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10746
10747 Fix some uses of `int' instead of EMACS_INT.
10748 * search.c (string_match_1, fast_string_match)
10749 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10750 (scan_buffer, find_next_newline_no_quit)
10751 (find_before_next_newline, search_command, Freplace_match)
10752 (Fmatch_data): Make some `int' variables be EMACS_INT.
10753
10754 * xdisp.c (display_count_lines): 3rd argument and return value now
10755 EMACS_INT. All callers changed.
10756 (pint2hrstr): Last argument is now EMACS_INT.
10757
10758 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10759 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10760 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10761 (decode_coding_utf_16, decode_coding_emacs_mule)
10762 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10763 (decode_coding_ccl, decode_coding_charset)
10764 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10765 (decode_coding_iso_2022, decode_coding_emacs_mule)
10766 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10767 <char_offset, last_offset>: Declare EMACS_INT.
10768 (encode_coding_utf_8, encode_coding_utf_16)
10769 (encode_coding_emacs_mule, encode_invocation_designation)
10770 (encode_designation_at_bol, encode_coding_iso_2022)
10771 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10772 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10773 Declare EMACS_INT.
10774 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10775 (encode_invocation_designation): Last argument P_NCHARS is now
10776 EMACS_INT.
10777 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10778 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10779
10780 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10781 All users changed.
10782
10783 * ccl.c (Fccl_execute_on_string): Declare some variables
10784 EMACS_INT.
10785
8546720e 107862011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10787
10788 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10789
4e19a977
CS
107902011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10791
10792 * process.c (Fformat_network_address): Doc fix.
10793
87302331
R
107942011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10795
ee7683eb 10796 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10797
cbb59342
CY
107982011-04-08 Chong Yidong <cyd@stupidchicken.com>
10799
10800 * keyboard.c (read_char): Call Lisp function help-form-show,
10801 instead of using internal_with_output_to_temp_buffer.
10802 (Qhelp_form_show): New var.
e0d38eeb 10803 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10804
10805 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10806
10807 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10808
e67a13ab
CY
108092011-04-06 Chong Yidong <cyd@stupidchicken.com>
10810
04f2d78b
CB
10811 * process.c (Flist_processes): Remove to Lisp.
10812 (list_processes_1): Delete.
e67a13ab 10813
973f782d
EZ
108142011-04-06 Eli Zaretskii <eliz@gnu.org>
10815
7c106b1e
EZ
10816 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10817
973f782d
EZ
10818 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10819
41cf7d1a 108202011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10821
ca23cc88
PE
10822 Fix more problems found by GCC 4.6.0's static checks.
10823
f390e2d5
PE
10824 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10825
42eea0d0
PE
10826 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10827
b69769da 10828 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10829
f9541e84
PE
10830 * xdisp.c (vmessage): Mark as a printf-like function.
10831
13841b55
PE
10832 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10833
c136c10f
PE
10834 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10835
5e2d4a30
PE
10836 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10837 printf-like functions.
10838 (tiff_load): Add casts to remove these marks before passing them
10839 to system-supplied API.
10840
583f48b9
PE
10841 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10842
b25d760e
PE
10843 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10844 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10845 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10846 directly, rather than having caller test rule sign. This avoids
10847 some unnecessary tests.
10848 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10849 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10850 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10851
bc7b6697 10852 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10853 (xfont_open): Avoid unnecessary tests.
bc7b6697 10854
27ccc379
PE
10855 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10856
dcd5c89a
PE
10857 * composite.h, composite.c (composition_gstring_put_cache):
10858 Use EMACS_INT, not int, for length.
10859
b13a45c6
PE
10860 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10861 breaking out part of COMPOSITION_DECODE_RULE.
10862 (COMPOSITION_DECODE_RULE): Use it.
10863 * composite.c (get_composition_id): Remove unused local vars,
10864 by using the new macro.
10865
1e792e4d
PE
10866 * textprop.c (set_text_properties_1): Change while to do-while,
10867 since the condition is always true at first.
10868
dc6c6455 10869 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10870 (interval_deletion_adjustment): Return unsigned value.
10871 All uses changed.
dc6c6455 10872
aba7731a
PE
10873 * process.c (list_processes_1, create_pty, read_process_output):
10874 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10875 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10876 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10877 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10878 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10879
fdfc4bf3
PE
10880 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10881
fca8fe46 10882 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10883 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10884
06a0259a 10885 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10886 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10887 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10888
e7b9e80f
PE
10889 * print.c (print_error_message): Avoid int overflow.
10890
56201685
PE
10891 * font.c (font_list_entities): Redo for clarity,
10892 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10893
78834453 10894 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10895 (font_score): Avoid potential overflow in diff calculation.
78834453 10896
0bc0b309 10897 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10898 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10899
e610eaca
PE
10900 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10901
b895abce
PE
10902 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10903 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10904 can always succeed if overflow has undefined behavior.
10905
1f1d9321 10906 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10907 (wordify): Omit three unnecessary tests.
1f1d9321 10908
c59478bc
PE
10909 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10910 All callers changed. This avoids the need for an unused var.
10911
79b73827
PE
10912 * casefiddle.c (casify_region): Remove var that is set but not used.
10913
a4db5dfe
PE
10914 * dired.c (file_name_completion): Remove var that is set but not used.
10915
43aae36e
PE
10916 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10917
2a47c44d 10918 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10919 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10920
a37c69bf
PE
10921 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10922 Check for integer overflow on size calculations.
10923
328ab8e7
PE
10924 * buffer.c (Fprevious_overlay_change): Remove var that is set
10925 but not used.
10926
e5a2a5cb
PE
10927 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10928 Remove vars that are set but not used.
8d84a6eb 10929 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10930 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10931
a60e5f68
PE
10932 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10933
f661cb61 10934 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10935 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10936
f0397f5a
PE
10937 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10938 that are set but not used.
10939
8664db06 10940 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10941 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10942
6abdaa4a
PE
10943 * xselect.c (x_get_local_selection, x_handle_property_notify):
10944 Remove vars that are set but not used.
10945
0ce7538d 10946 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10947 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10948
9ae848fc
PE
10949 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10950 Remove var that is set but not used.
0b918413
PE
10951 (scroll_bar_windows_size): Now size_t, not int.
10952 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10953 Check for overflow.
9ae848fc 10954
a5a62657
PE
10955 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10956 (map_tty_color) [!defined MSDOS]: Likewise.
10957
5c5cdd39
PE
10958 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10959
66ebf983
PE
10960 * coding.c: Remove vars that are set but not used.
10961 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10962 All callers changed.
10963 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10964 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10965 (decode_coding_charset): Remove vars that are set but not used.
10966
1be4d761
PE
10967 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10968 that is set but not used.
10969
47553fa8
PE
10970 * print.c (print_object): Remove var that is set but not used.
10971
1f7196bf 10972 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10973 The gnulib version avoids calling malloc in the usual case,
10974 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10975 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10976 * filelock.c (current_lock_owner): Likewise.
10977 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10978 * sysdep.c: Include allocator.h, careadlinkat.h.
10979 (emacs_no_realloc_allocator): New static constant.
10980 (emacs_readlink): New function.
fdb61804
PE
10981 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10982 ../lib/careadlinkat.h.
d1fdcab7 10983
f84c17c7
SM
109842011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10985
10986 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10987 first non-nil return value).
10988
ef3862ad
JD
109892011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10990
10991 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10992 if not defined (Bug#8403).
10993
376a7006
JB
109942011-04-02 Juanma Barranquero <lekktu@gmail.com>
10995
10996 * xdisp.c (display_count_lines): Remove parameter `start',
10997 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10998 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10999 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11000 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11001 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11002 and thereabouts. All callers changed.
11003 (get_per_char_metric): Remove parameter `f', unused since
11004 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11005
6ca3801d
JM
110062011-04-02 Jim Meyering <meyering@redhat.com>
11007
11008 do not dereference NULL upon failed strdup
11009 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11010 (ns_get_family): Likewise.
11011
d8e2b5ba
JB
110122011-04-02 Juanma Barranquero <lekktu@gmail.com>
11013
11014 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11015
8c74fcbd
JD
110162011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11017
11018 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11019 later (Bug#8403).
11020
7200d79c
SM
110212011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11022
03408648 11023 Add lexical binding.
7200d79c 11024
03408648
SM
11025 * window.c (Ftemp_output_buffer_show): New fun.
11026 (Fsave_window_excursion):
11027 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11028
11029 * lread.c (lisp_file_lexically_bound_p): New function.
11030 (Fload): Bind Qlexical_binding.
11031 (readevalloop): Remove `evalfun' arg.
11032 Bind Qinternal_interpreter_environment.
11033 (Feval_buffer): Bind Qlexical_binding.
11034 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11035 Mark as dynamic.
11036 (syms_of_lread): Declare `lexical-binding'.
11037
11038 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11039
11040 * keyboard.c (eval_dyn): New fun.
11041 (menu_item_eval_property): Use it.
ca105506
SM
11042
11043 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11044
03408648
SM
11045 * fns.c (concat, mapcar1): Accept byte-code-functions.
11046
11047 * eval.c (Fsetq): Handle lexical vars.
11048 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11049 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11050 (FletX, Flet): Obey lexical binding.
11051 (Fcommandp): Handle closures.
11052 (Feval): New `lexical' arg.
11053 (eval_sub): New function extracted from Feval. Use it almost
11054 everywhere where Feval was used. Look up vars in lexical env.
11055 Handle closures.
11056 (Ffunctionp): Move from subr.el.
11057 (Ffuncall): Handle closures.
11058 (apply_lambda): Remove `eval_flags'.
11059 (funcall_lambda): Handle closures and new byte-code-functions.
11060 (Fspecial_variable_p): New function.
11061 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11062 but without exporting it to Lisp.
23aba0ea 11063
23aba0ea 11064 * doc.c (Fdocumentation, store_function_docstring):
03408648 11065 * data.c (Finteractive_form): Handle closures.
23aba0ea 11066
03408648
SM
11067 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11068 interactive spec.
ba83908c 11069
04f2d78b
CB
11070 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11071 New byte-codes.
03408648
SM
11072 (exec_byte_code): New function extracted from Fbyte_code to handle new
11073 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11074
03408648 11075 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11076
03408648 11077 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11078
e2abce01
JB
110792011-03-31 Juanma Barranquero <lekktu@gmail.com>
11080
11081 * xdisp.c (redisplay_internal): Fix prototype.
11082
63696a73 110832011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11084
63696a73 11085 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11086 (try_scrolling): Use it when setting scroll_limit.
11087 Limit scrolling to 100 screen lines.
63696a73
EZ
11088 (redisplay_window): Even when falling back on "recentering",
11089 position point in the window according to scroll-conservatively,
11090 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11091
11092 (try_scrolling): When point is above the window, allow searching
11093 as far as scroll_max, or one screenful, to compute vertical
11094 distance from PT to the scroll margin position. This prevents
11095 try_scrolling from unnecessarily failing when
11096 scroll-conservatively is set to a value slightly larger than the
11097 window height. Clean up the case of PT below the margin at bottom
11098 of window: scroll_max can no longer be INT_MAX. When aggressive
11099 scrolling is in use, don't let point enter the opposite scroll
11100 margin as result of the scroll.
11101 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11102 threshold of 100 lines for never-recentering scrolling.
11103
e4cc2dfc
JB
111042011-03-31 Juanma Barranquero <lekktu@gmail.com>
11105
11106 * dispextern.h (move_it_by_lines):
11107 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11108 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11109 (message_log_check_duplicate): Remove parameters `prev_bol' and
11110 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11111 (redisplay_internal): Remove parameter `preserve_echo_area',
11112 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11113
11114 * indent.c (Fvertical_motion):
11115 * window.c (window_scroll_pixel_based, Frecenter):
11116 Don't pass `need_y_p' to `move_it_by_lines'.
11117
1c470562
SM
111182011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11119
44f230aa
SM
11120 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11121 steal a few bits to be more compact.
11122 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11123 Remove unneeded casts.
11124
1c470562
SM
11125 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11126
888adce9
ZK
111272011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11128
11129 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11130 binding" message (bug#7967).
11131
f838ed7b
PE
111322011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11133
77861b95
PE
11134 Fix more problems found by GCC 4.6.0's static checks.
11135
de6dbc14
PE
11136 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11137 Remove unused local var.
11138
f838ed7b
PE
11139 * editfns.c (Fmessage_box): Remove unused local var.
11140
792c7b2b
PE
11141 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11142 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11143 Omit unused local vars.
c499e557 11144 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11145 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11146 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11147 Omit unused local var.
11148
ba0165e1
PE
11149 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11150 Don't assume string length fits in int.
32ad8845 11151 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11152 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11153
3c59b4c9
PE
11154 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11155 instead of alloca (Bug#8344).
11156
a3eed478 11157 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11158 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11159
eb4d412d
PE
11160 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11161
1658b401
PE
11162 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11163 concerns.
11164
11165 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11166
11167 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11168
9a2c6e05
PE
11169 * keyboard.c (syms_of_keyboard): Use the same style as later
11170 in this function when indexing through an array. This also
11171 works around GCC bug 48267.
11172
03d0a109
PE
11173 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11174
44f730c8
PE
11175 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11176
fe75f926
PE
11177 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11178 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11179
ffa8c828
PE
11180 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11181 This avoids undefined behavior on integer overflow, and is a bit
11182 more convenient anyway since it is compared to a size_t variable.
11183
c5101a77
PE
11184 Variadic C functions now count arguments with size_t, not int.
11185 This avoids an unnecessary limitation on 64-bit machines, which
11186 caused (substring ...) to crash on large vectors (Bug#8344).
11187 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11188 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11189 All variadic functions and their callers changed accordingly.
c5101a77
PE
11190 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11191 * data.c (arith_driver, float_arith_driver): Likewise.
11192 * editfns.c (general_insert_function): Likewise.
11193 * eval.c (struct backtrace.nargs, interactive_p)
11194 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11195 (funcall_lambda, mark_backtrace): Likewise.
11196 * fns.c (concat): Likewise.
11197 * frame.c (x_set_frame_parameters): Likewise.
11198 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11199 0 if not found, not -1. All callers changed.
11200
dd3f25f7
PE
11201 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11202 (stack_copy_size): Now size_t, not int.
11203 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11204
461c2ab9
JB
112052011-03-28 Juanma Barranquero <lekktu@gmail.com>
11206
11207 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11208 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11209 All callers changed.
11210
11211 * lisp.h (multibyte_char_to_unibyte):
11212 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11213 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11214 * character.h (CHAR_TO_BYTE8):
11215 * cmds.c (internal_self_insert):
11216 * editfns.c (general_insert_function):
11217 * keymap.c (push_key_description):
11218 * search.c (Freplace_match):
11219 * xdisp.c (message_dolog, set_message_1): All callers changed.
11220
f6d62986
SM
112212011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11222
11223 * keyboard.c (safe_run_hook_funcall): New function.
11224 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11225 don't set the hook to nil, but remove the offending function instead.
11226 (Qcommand_hook_internal): Remove, unused.
11227 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11228 Vcommand_hook_internal.
11229
11230 * eval.c (enum run_hooks_condition): Remove.
11231 (funcall_nil, funcall_not): New functions.
11232 (run_hook_with_args): Call each function through a `funcall' argument.
11233 Remove `cond' argument, now redundant.
11234 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11235 (Frun_hook_with_args_until_failure): Adjust accordingly.
11236 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11237
1db5b1ad
JB
112382011-03-28 Juanma Barranquero <lekktu@gmail.com>
11239
11240 * dispextern.h (string_buffer_position): Remove declaration.
11241
11242 * print.c (strout): Remove parameter `multibyte', unused since
11243 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11244
11245 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11246 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11247 All callers changed.
11248
11249 * w32.c (_wsa_errlist): Use braces for struct initializers.
11250
11251 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11252 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11253 All callers changed.
11254 (string_buffer_position): Likewise. Also, make static (it's never
11255 used outside xdisp.c).
11256 (cursor_row_p): Remove parameter `w', unused since
11257 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11258 (decode_mode_spec): Remove parameter `precision', introduced during
11259 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11260 All callers changed.
11261
5ffb62aa
JD
112622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11263
11264 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11265
461c2ab9 112662011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11267
11268 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11269 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11270 (ns_update_auto_hide_menu_bar): New functions.
11271 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11272 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11273 ns_constrain_all_frames.
11274 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11275 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11276
5c380ffb
JD
112772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11278
11279 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11280
9af30bdf
GM
112812011-03-27 Glenn Morris <rgm@gnu.org>
11282
11283 * syssignal.h: Replace RETSIGTYPE with void.
11284 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11285 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11286 Replace SIGTYPE with void everywhere.
11287 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11288 * s/template.h (SIGTYPE): Remove commented out definition.
11289
e2abce01
JB
112902011-03-26 Eli Zaretskii <eliz@gnu.org>
11291
11292 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11293 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11294
f868cd8a
JB
112952011-03-26 Juanma Barranquero <lekktu@gmail.com>
11296
59eb0929
JB
11297 * w32.c (read_unc_volume): Use parameter `henum', instead of
11298 global variable `wget_enum_handle'.
11299
11300 * keymap.c (describe_vector): Remove parameters `indices' and
11301 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11302 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11303
f868cd8a
JB
11304 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11305
11306 * keyboard.c (timer_check): Remove parameter `do_it_now',
11307 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11308 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11309 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11310
11311 * keyboard.c (read_char):
11312 * w32menu.c (w32_menu_display_help):
11313 * xmenu.c (show_help_event, menu_help_callback):
11314 Adjust calls to `show_help_echo'.
11315
11316 * gtkutil.c (xg_maybe_add_timer):
11317 * keyboard.c (readable_events):
11318 * process.c (wait_reading_process_output):
11319 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11320
11321 * insdel.c (adjust_markers_gap_motion):
11322 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11323 (gap_left, gap_right): Don't call it.
11324
2ecf6fdb
CY
113252011-03-25 Chong Yidong <cyd@stupidchicken.com>
11326
11327 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11328 incurred during fontification.
11329
6b1f9ba4
JB
113302011-03-25 Juanma Barranquero <lekktu@gmail.com>
11331
11332 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11333 (DEFVAR_PER_BUFFER): Don't pass it.
11334
11335 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11336 (scrolling_window): Don't pass it.
11337
0f4a96b5
JB
113382011-03-25 Juanma Barranquero <lekktu@gmail.com>
11339
11340 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11341
11342 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11343 and `suffix'.
11344 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11345 of variables specific to SELinux and computation of `encoded_absname'.
11346
11347 * image.c (XPutPixel): Remove unused variable `height'.
11348
11349 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11350
11351 * unexw32.c (get_section_info): Remove unused variable `section'.
11352
11353 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11354 (system_process_attributes): Remove unused variable `sess'.
11355 (sys_read): Remove unused variable `err'.
11356
11357 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11358 (w32_wnd_proc): Remove unused variable `isdead'.
11359 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11360 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11361 (x_create_tip_frame): Remove unused variable `tem'.
11362
11363 * w32inevt.c (w32_console_read_socket):
11364 Remove unused variable `no_events'.
11365
11366 * w32term.c (x_draw_composite_glyph_string_foreground):
11367 Remove unused variable `width'.
11368
1149507c
JB
113692011-03-24 Juanma Barranquero <lekktu@gmail.com>
11370
11371 * w32term.c (x_set_glyph_string_clipping):
11372 Don't pass uninitialized region to CombineRgn.
11373
9c88f339
JB
113742011-03-23 Juanma Barranquero <lekktu@gmail.com>
11375
11376 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11377 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11378 (Fx_close_connection): Remove unused variable `i'.
11379
11380 * w32font.c (w32font_draw): Return number of glyphs.
11381 (w32font_open_internal): Remove unused variable `i'.
11382 (w32font_driver): Add missing initializer.
11383
11384 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11385 (fill_in_menu): Remove unused variable `items_added'.
11386
11387 * w32term.c (last_mouse_press_frame): Remove static global variable.
11388 (w32_clip_to_row): Remove unused variable `f'.
11389 (x_delete_terminal): Remove unused variable `i'.
11390
11391 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11392 (NOTHING): Remove unused static global variable.
11393 (uniscribe_check_otf): Remove unused variable `table'.
11394 (uniscribe_font_driver): Add missing initializers.
11395
dee091a3
JD
113962011-03-23 Julien Danjou <julien@danjou.info>
11397
11398 * term.c (Fsuspend_tty, Fresume_tty):
11399 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11400 * window.c (temp_output_buffer_show):
11401 * insdel.c (signal_before_change):
11402 * frame.c (Fhandle_switch_frame):
11403 * fileio.c (Fdo_auto_save):
11404 * emacs.c (Fkill_emacs):
11405 * editfns.c (save_excursion_restore):
11406 * cmds.c (internal_self_insert):
11407 * callint.c (Fcall_interactively):
11408 * buffer.c (Fkill_all_local_variables):
11409 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11410 Use Frun_hooks.
0f4a96b5 11411 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11412 unconditionally since it does the check itself.
dee091a3 11413
2c520ab5 114142011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11415
c9c49752
PE
11416 Fix more problems found by GCC 4.5.2's static checks.
11417
8abc3f12
PE
11418 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11419 the first time through the loop, since we know p0 < p1 then.
11420 This also avoids a gcc -Wstrict-overflow warning.
11421
a2d26660
PE
11422 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11423 leading to a memory leak, possible in functions like
11424 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11425 of objects (Bug#8318).
a2d26660 11426
916c72e9
PE
11427 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11428 that could (at least in theory) be that large.
11429
19ab8a18
PE
11430 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11431 This is less likely to overflow, and avoids undefined behavior if
11432 overflow does occur. All callers changed. Use strtoul to scan
11433 for the unsigned long integer.
b7cbbd6f
PE
11434 (pint2hrstr): Simplify and tune code slightly.
11435 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11436
f0641eff
PE
11437 * scroll.c (do_scrolling): Work around GCC bug 48228.
11438 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11439
7f650bb9
PE
11440 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11441 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11442 (validate_x_resource_name): Simplify count usage.
11443 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11444
37dd57d1
PE
11445 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11446 fail (Bug#8306).
81e56e61 11447
699979fc 11448 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11449
401bf9b4
PE
11450 * process.c (Fmake_network_process): Use socklen_t, not int,
11451 where POSIX says socklen_t is required in portable programs.
11452 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11453 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11454 (Fmake_network_process, server_accept_connection):
11455 (wait_reading_process_output, read_process_output):
11456 Likewise.
11457
b93aacde
PE
11458 * process.c: Rename or move locals to avoid shadowing.
11459 (list_processes_1, Fmake_network_process):
11460 (read_process_output_error_handler, exec_sentinel_error_handler):
11461 Rename or move locals.
4dc343ee 11462 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11463 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11464 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11465 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11466 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11467
af8a867c 11468 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11469 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11470 Include tparam.h instead, since it declares them.
af8a867c
PE
11471 * cm.h (PC): Remove extern decl; tparam.h now does this.
11472 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11473 * terminfo.c: Include tparam.h, to check interfaces.
11474 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11475 (tparam): Adjust signature to match interface in tparam.h;
11476 this removes some undefined behavior. Check that outstring and len
11477 are zero, which they always are with Emacs.
11478 * tparam.h (PC, BC, UP): New extern decls.
11479
0248044d 11480 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11481 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11482
8ff096c1 11483 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11484 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11485 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11486 (ftfont_list): Remove unused local.
49eaafba
PE
11487 (get_adstyle_property, ftfont_pattern_entity):
11488 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11489 Rename locals to avoid shadowing.
8ff096c1 11490
e2be39f6
PE
11491 * xfont.c (xfont_list_family): Mark var as initialized.
11492
c9735e30
PE
11493 * xml.c (make_dom): Now static.
11494
8f5201ae
PE
11495 * composite.c (composition_compute_stop_pos): Rename local to
11496 avoid shadowing.
b246f932
PE
11497 (composition_reseat_it): Remove unused locals.
11498 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11499 (composition_update_it): Mark var as initialized.
11b61122
PE
11500 (find_automatic_composition): Mark vars as initialized,
11501 with a FIXME (Bug#8290).
8f5201ae 11502
760fbc2c
PE
11503 character.h: Rename locals to avoid shadowing.
11504 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11505 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11506 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11507 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11508 to avoid shadowing.
11509
ff08eb85
PE
11510 * textprop.c (property_change_between_p): Remove; unused.
11511
fc7bf025
PE
11512 * intervals.c (interval_start_pos): Now static.
11513
235d7abc
PE
11514 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11515
44f230aa
SM
11516 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11517 Rename locals to avoid shadowing.
3e7d6594 11518
50060332
PE
11519 * sound.c (wav_play, au_play, Fplay_sound_internal):
11520 Fix pointer signedness.
d01f234b 11521 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11522 (wav_play): Initialize a variable to 0, to prevent undefined
11523 behavior (Bug#8278).
50060332 11524
c4fc4e30
PE
11525 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11526
918436ed
PE
11527 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11528
c939f91b
PE
11529 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11530 clobbering (Bug#8298).
b9c7f648
PE
11531 * sysdep.c (sys_subshell): Likewise.
11532 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11533
6bd8c144
PE
11534 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11535 This should get cleaned up, so that child_setup has the
11536 same signature on all platforms.
11537
7710357c 11538 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11539 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11540
c59da222
CY
115412011-03-22 Chong Yidong <cyd@stupidchicken.com>
11542
11543 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11544 not to be necessary, and produces flickering.
11545
66b87493
GM
115462011-03-20 Glenn Morris <rgm@gnu.org>
11547
11548 * config.in: Remove file.
11549
45b6f6d5
JB
115502011-03-20 Juanma Barranquero <lekktu@gmail.com>
11551
11552 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11553 are now in src/globals.h.
11554 (syms_of_minibuf): Remove spurious & from previous change.
11555
cd394be1 115562011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11557
11558 * minibuf.c (completing-read-function): New variable.
11559 (completing-read-default): Rename from completing-read.
11560 (completing-read): Call completing-read-function.
11561
b14e3e21
CY
115622011-03-19 Juanma Barranquero <lekktu@gmail.com>
11563
11564 * xfaces.c (Fx_load_color_file):
11565 Read color file from absolute filename (bug#8250).
11566
f2b726e6
JB
115672011-03-19 Juanma Barranquero <lekktu@gmail.com>
11568
11569 * makefile.w32-in: Update dependencies.
11570
09f6ff02
EZ
115712011-03-17 Eli Zaretskii <eliz@gnu.org>
11572
11573 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11574
29a6015a
PE
115752011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11576
a3a6c54e
PE
11577 Fix more problems found by GCC 4.5.2's static checks.
11578
b766f867
PE
11579 * process.c (make_serial_process_unwind, send_process_trap):
11580 (sigchld_handler): Now static.
11581
be02381c
PE
11582 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11583 That way, the code declares only the vars that it needs.
11584 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11585 * s/cygwin.h (PTY_ITERATION): Likewise.
11586 * s/darwin.h (PTY_ITERATION): Likewise.
11587 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11588
57048744
PE
11589 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11590 * process.c (allocate_pty): Don't declare stb unless it's needed.
11591
7914961c 11592 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11593 (CONSTANTLIM): Remove; unused.
11594 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11595 Define only if needed.
7914961c 11596
b3967b18
PE
11597 * unexelf.c (unexec): Name an expression,
11598 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11599 Use a different way to cause a compilation error if anyone uses
11600 n rather than nn, a way that does not involve shadowing.
73366a00 11601 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11602
29a6015a
PE
11603 * deps.mk (unexalpha.o): Remove; unused.
11604
43cfc33e 11605 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11606 * unexec.h: New file.
ce701a33
PE
11607 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11608 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11609 Depend on unexec.h.
11610 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11611 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11612 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11613 Change as necessary to match prototype in unexec.h.
ce701a33 11614
01f44d5a
PE
11615 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11616 shadowing.
4f63c6bb 11617 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11618
a6670b0b
PE
11619 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11620 Rename locals to avoid shadowing.
11621
cef2010d 11622 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11623 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11624
d4d7173a
PE
11625 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11626
f08b802a
PE
11627 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11628 warning when compiling print.c.
11629
3ddb0639
PE
11630 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11631 instead of using an uninitialized var.
5ad03b97 11632 (font_sort_entities): Mark var as initialized.
3ddb0639 11633
170a2692
PE
11634 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11635
e663c700
PE
11636 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11637 pointers to constants.
89bc529a 11638 (font_parse_fcname): Remove unused vars.
7b81e2d0 11639 (font_delete_unmatched): Now static.
ea838e10 11640 (font_get_spec): Remove; unused.
13a547c6
PE
11641 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11642 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11643 Rename or move locals to avoid shadowing.
e663c700 11644
2a80c887 11645 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11646 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11647
1384fa33 11648 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11649 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11650
8b2c52e9
PE
11651 * alloc.c (mark_backtrace): Move decl from here ...
11652 * lisp.h: ... to here, so that it can be checked.
11653
475545b5 11654 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11655 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11656 (lisp_indirect_variable): Name an expression,
11657 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11658 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11659
b1349114 11660 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11661 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11662 Use const pointer when appropriate.
b1349114 11663
a2928364
PE
11664 * lisp.h (get_system_name, get_operating_system_release):
11665 Move decls here, to check interfaces.
11666 * process.c (get_operating_system_release): Move decl to lisp.h.
11667 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11668 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11669 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11670 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11671 (Fformat_time_string, Fencode_time, Finsert_char):
11672 (Ftranslate_region_internal, Fformat):
11673 Rename or remove local vars to avoid shadowing.
9710023e 11674 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11675
a415e694
PE
11676 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11677 avoid shadowing.
11678
8ef4622d
PE
11679 * lisp.h (eassert): Check that the argument compiles, even if
11680 ENABLE_CHECKING is not defined.
11681
946f9a5b
PE
11682 * data.c (Findirect_variable): Name an expression, to avoid
11683 gcc -Wbad-function-cast warning.
112396d6 11684 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11685 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11686 (Fmake_variable_buffer_local, Fmake_local_variable):
11687 Mark variables as initialized.
52746918 11688 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11689
e5aab7e7 11690 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11691 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11692 Rename locals to avoid shadowing.
dff45157
PE
11693 (mark_stack): Move local variables into the #ifdef region where
11694 they're used.
7bc26fdb
PE
11695 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11696 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11697 needed otherwise.
11698 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11699 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11700 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11701
e5aab7e7
PE
11702 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11703 avoids undefined behavior in theory.
11704
4da60324
PE
11705 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11706
88043301
PE
11707 Use functions, not macros, for up- and down-casing (Bug#8254).
11708 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11709 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11710 to use the following functions instead of these macros.
11711 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11712 EMACS_INT, since callers assume the returned value fits in int.
11713 (upcase1): Likewise, for UPCASE_TABLE.
11714 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11715 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11716 the race-condition problem in the old DOWNCASE.
88043301 11717
19ed5445
PE
11718 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11719 Rename locals to avoid shadowing.
11720 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11721 (regex_compile, re_search_2, re_match_2_internal):
11722 Remove unused local vars.
952db0d7
PE
11723 (FREE_VAR): Rewrite so as not to use empty "else",
11724 which gcc can warn about.
da053e48 11725 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11726 (RETALLOC_IF): Define only if needed.
11727 (WORDCHAR_P): Likewise. This one is never needed, but is used
11728 only in a comment talking about a compiler bug, so put inside
11729 the #if 0 of that comment.
11730 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11731 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11732 Remove; unused.
19ed5445 11733
1f3561e4 11734 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11735 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11736 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11737
ded6f8f7
PE
11738 * search.c (simple_search): Remove unused var.
11739
dbd37a95
PE
11740 * dired.c (compile_pattern): Move decl from here ...
11741 * lisp.h: ... to here, so that it can be checked.
11742 (struct re_registers): New forward decl.
11743
7e47afad
PE
11744 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11745
85f24f61
PE
11746 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11747 All uses changed.
11748 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11749 Rename locals to avoid shadowing.
5671df8f 11750 (Fvertical_motion): Mark locals as initialized.
85f24f61 11751
181aa2be 11752 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11753 (casify_region): Mark local as initialized.
181aa2be 11754
930d429c
PE
11755 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11756
7082eac6
PE
11757 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11758 New macros, so that the caller can use some names other than
11759 gcpro1, gcpro2, etc.
11760 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11761 of the new macros.
11762 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11763 argument, for consistency with GCPRO2_VAR, etc: it is now the
11764 prefix of the variable, not the variable itself. All uses
11765 changed.
38b2c076
PE
11766 * dired.c (directory_files_internal, file_name_completion):
11767 Rename locals to avoid shadowing.
11768
15206ed9
PE
11769 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11770 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11771 dired.c's scmp function, had undefined behavior.
11772 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11773 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11774 * buffer.h: ... to here, because these macros use current_buffer,
11775 and the new implementation with inline functions needs to have
11776 current_buffer in scope now, rather than later when the macros
11777 are used.
11778 (downcase, upcase1): New static inline functions.
11779 (DOWNCASE, UPCASE1): Reimplement using these functions.
11780 This avoids undefined behavior in expressions like
11781 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11782 from race conditions in accessing the global variables
11783 case_temp1 and case_temp2.
11784 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11785 * lisp.h (case_temp1, case_temp2): Remove their decls.
11786 * character.h (ASCII_CHAR_P): Move from here ...
11787 * lisp.h: ... to here, so that the inline functions mentioned
11788 above can use them.
11789
4a6bea26
PE
11790 * dired.c (directory_files_internal_unwind): Now static.
11791
f14b7e14
PE
11792 * fileio.c (file_name_as_directory, directory_file_name):
11793 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11794 Now static.
2893f146
PE
11795 (file_name_as_directory): Use const pointers when appropriate.
11796 (Fexpand_file_name): Likewise. In particular, newdir might
11797 point at constant storage, so make it a const pointer.
fd4ead52 11798 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11799 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11800 signedness issues.
f839df0c
PE
11801 (Fset_file_times, Finsert_file_contents, auto_save_error):
11802 Rename locals to avoid shadowing.
f14b7e14 11803
5716756e 11804 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11805 (Ftry_completion, Fall_completions): Rename or remove locals
11806 to avoid shadowing.
5716756e 11807
b4c3046a
PE
11808 * marker.c (bytepos_to_charpos): Remove; unused.
11809
b45db522
PE
11810 * lisp.h (verify_bytepos, count_markers): New decls,
11811 so that gcc does not warn that these functions aren't declared.
11812
85876d07
PE
11813 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11814 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11815 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11816 (copy_text): Remove unused local var.
85876d07 11817
03d78a21 11818 * filelock.c (within_one_second): Now static.
b3dd38ab 11819 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11820
5df8f01b
PE
11821 * buffer.c (fix_overlays_before): Mark locals as initialized.
11822 (fix_start_end_in_overlays): Likewise. This function should be
11823 simplified by using pointers-to-pointers, but that's a different
11824 matter.
b1d876f1 11825 (switch_to_buffer_1): Now static.
8f54f30a
PE
11826 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11827 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11828
a70072c9 11829 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11830 Fix pointer signedness issue.
edced198
PE
11831 (sys_subshell): Mark local as volatile if checking for lint,
11832 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11833 (MAXPATHLEN): Define only if needed.
a70072c9 11834
a0977c44
PE
11835 * process.c (serial_open, serial_configure): Move decls from here ...
11836 * systty.h: ... to here, so that they can be checked.
11837
a884fdcc
PE
11838 * fns.c (get_random, seed_random): Move extern decls from here ...
11839 * lisp.h: ... to here, so that they can be checked.
11840
604efe86 11841 * sysdep.c (reset_io): Now static.
b8950c94 11842 (wait_for_termination_signal): Remove; unused.
604efe86 11843
38fc62d9
PE
11844 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11845 (copy_keymap_item, append_key, push_text_char_description):
11846 Now static.
1004a21a 11847 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11848 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11849 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11850 (describe_map_tree):
11851 Rename locals to avoid shadowing.
38fc62d9 11852
2f2650da
PE
11853 * keyboard.c: Declare functions static if they are not used elsewhere.
11854 (echo_char, echo_dash, cmd_error, top_level_2):
11855 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11856 (read_char, kbd_buffer_get_event, make_lispy_position):
11857 (make_lispy_event, make_lispy_movement, apply_modifiers):
11858 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11859 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11860 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11861 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11862 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11863
a053e86c 11864 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11865 (mark_kboards): Move decl here ...
11866 * alloc.c (mark_kboards): ... from here.
a053e86c 11867
4752793e
PE
11868 * lisp.h (force_auto_save_soon): New decl.
11869
74f10ca7 11870 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11871 (DEFINE_DUMMY_FUNCTION): New macro.
11872 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11873 Use it.
c03cd23f
PE
11874 (main): Add casts to avoid warnings
11875 if GCC considers string literals to be constants.
74f10ca7 11876
022e70d4
PE
11877 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11878
59d6fe83
PE
11879 * dbusbind.c: Pointer signedness fixes.
11880 (xd_signature, xd_append_arg, xd_initialize):
11881 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11882 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11883 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11884 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11885
78320123
PE
11886 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11887 if GCC considers string literals to be constants.
49cebcca 11888 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11889
35ac2a97
SM
118902011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11891
fb103ca9
SM
11892 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11893 (print_preprocess, print_object): New macro to fix last change.
11894
35ac2a97
SM
11895 * print.c (print_preprocess): Don't forget font objects.
11896
62973b41
JB
118972011-03-16 Juanma Barranquero <lekktu@gmail.com>
11898
11899 * emacs.c (USAGE3): Doc fixes.
11900
0e48bb22
AS
119012011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11902
11903 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11904 structure.
11905
7684e57b
JB
119062011-03-14 Juanma Barranquero <lekktu@gmail.com>
11907
11908 * lisp.h (VWindow_system, Qfile_name_history):
11909 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11910 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11911 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11912
11913 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11914 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11915
11916 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11917 * w32console.c (detect_input_pending, read_input_pending)
11918 (encode_terminal_code):
11919 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11920 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11921 (w32_system_caret_y, Qfile_name_history):
11922 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11923 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11924 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11925 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11926 * w32proc.c (Qlocal, report_file_error):
11927 * w32term.c (Vwindow_system, updating_frame):
11928 * w32uniscribe.c (initialized, uniscribe_font_driver):
11929 Remove unneeded extern declarations.
11930
2aa46d6c
CY
119312011-03-14 Chong Yidong <cyd@stupidchicken.com>
11932
c96bbc66 11933 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11934
cffc6f3b
CY
119352011-03-13 Chong Yidong <cyd@stupidchicken.com>
11936
11937 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11938 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11939 These macros can no longer be used for assignment.
11940
44f230aa
SM
11941 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11942 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11943 (record_buffer_markers, fetch_buffer_markers): New functions for
11944 recording and fetching special buffer markers.
11945 (set_buffer_internal_1, set_buffer_temp): Use them.
11946
11947 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11948
11949 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11950
11951 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11952 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11953
11954 * xdisp.c (hscroll_window_tree):
11955 (reconsider_clip_changes): Use PT instead of BUF_PT.
11956
d251f04b
EZ
119572011-03-13 Eli Zaretskii <eliz@gnu.org>
11958
11959 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11960 $(EMACS_ROOT)/lib/intprops.h.
11961
f0c77cd1
PE
119622011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11963
3eca4629
PE
11964 Fix more problems found by GCC 4.5.2's static checks.
11965
7c86ee98
PE
11966 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11967 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11968 (xg_free_frame_widgets): Make it clear that a local variable is
11969 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11970 (gdk_window_get_screen): Make it clear that this macro is needed
11971 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11972 (int_gtk_range_get_value): New function, which avoids a diagnostic
11973 from gcc -Wbad-function-cast.
11974 (xg_set_toolkit_scroll_bar_thumb): Use it.
11975 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11976 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11977 (get_utf8_string, xg_get_file_with_chooser):
11978 Rename locals to avoid shadowing.
11979 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11980
41729b81
PE
11981 * xgselect.c (xg_select): Remove unused var.
11982
f0c77cd1
PE
11983 * image.c (four_corners_best): Mark locals as initialized.
11984 (gif_load): Initialize transparent_p to zero (Bug#8238).
11985 Mark another local as initialized.
ec6cf4c6 11986 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11987
ce0ad53d 11988 * image.c (clear_image_cache): Now static.
d5d5a617 11989 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11990 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11991 (x_edge_detection): Remove unnecessary cast that
11992 gcc -Wbad-function-cast diagnoses.
2037898d 11993 (gif_load): Fix pointer signedness.
6ae141d6
PE
11994 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11995 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11996
33383987 119972011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11998
d32df629
PE
11999 Improve quality of tests for time stamp overflow.
12000 For example, without this patch (encode-time 0 0 0 1 1
12001 1152921504606846976) returns the obviously-bogus value (-948597
12002 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12003 reports time overflow. See
12004 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12005 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12006 * editfns.c: Include limits.h and intprops.h.
12007 (TIME_T_MIN, TIME_T_MAX): New macros.
12008 (time_overflow): Move earlier, to before first use.
12009 (hi_time, lo_time): New functions, for an accurate test for
12010 out-of-range times.
12011 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12012 (Fget_internal_run_time): Don't assume time_t fits in int.
12013 (make_time): Use list2 instead of Fcons twice.
12014 (Fdecode_time): More accurate test for out-of-range times.
12015 (check_tm_member): New function.
12016 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12017 (lisp_time_argument): Don't rely on undefined left-shift and
12018 right-shift behavior when checking for time stamp overflow.
8be6f318 12019
fe31d94c
PE
12020 * editfns.c (time_overflow): New function, refactoring common code.
12021 (Fformat_time_string, Fdecode_time, Fencode_time):
12022 (Fcurrent_time_string): Use it.
12023
8be6f318
PE
12024 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12025 * dired.c (make_time): Move to ...
12026 * editfns.c (make_time): ... here.
12027 * systime.h: Note the move.
12028
09d9db2c 120292011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12030
126bc0dc
YM
12031 * fringe.c (update_window_fringes): Remove unused variables.
12032
c47cbdfd
YM
12033 * unexmacosx.c (copy_data_segment): Also copy __got section.
12034 (Bug#8223)
12035
7ac80be9
EZ
120362011-03-12 Eli Zaretskii <eliz@gnu.org>
12037
c96bbc66 12038 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12039 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12040 Constify `char *' arguments and their references according to
12041 prototypes in tparam.h.
12042
ecb0f94d 12043 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12044
7ac80be9
EZ
12045 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12046 Adapt all references accordingly.
12047
12048 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12049
ef1fd07e
TT
120502011-03-11 Tom Tromey <tromey@redhat.com>
12051
12052 * buffer.c (syms_of_buffer): Remove obsolete comment.
12053
7ef4b50c
EZ
120542011-03-11 Eli Zaretskii <eliz@gnu.org>
12055
12056 * termhooks.h (encode_terminal_code): Declare prototype.
12057
12058 * msdos.c (encode_terminal_code): Don't declare prototype.
12059
12060 * term.c (encode_terminal_code): Now external again, used by
12061 w32console.c and msdos.c.
12062
44f230aa
SM
12063 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12064 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12065
4b1ec863 120662011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12067
1714f52b 12068 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12069
4b1ec863
PE
12070 * fringe.c (update_window_fringes): Mark locals as initialized
12071 (Bug#8227).
12072 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12073
524c7aa6
PE
12074 * alloc.c (mark_fringe_data): Move decl from here ...
12075 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12076 to check its interface.
12077 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12078
a5c0af81 12079 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12080 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12081 (fontset_font): Mark local as initialized.
a9a06e0b 12082 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12083
b4716021
PE
12084 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12085
811e9bac 12086 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12087 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12088 (x_own_selection, Fx_disown_selection_internal): Rename locals
12089 to avoid shadowing.
12090 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12091
7e3ab302
PE
12092 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12093 so that the caller can use some name other than gcpro1.
12094 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12095 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12096 (Fx_backspace_delete_keys_p):
12097 Use them to avoid shadowing, and rename vars to avoid shadowing.
12098 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12099 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12100 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12101 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12102 Remove unused locals.
7e3ab302
PE
12103 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12104 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12105 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12106 macros.
f78faa98 12107
e2b13473
PE
12108 * xterm.h (x_mouse_leave): New decl.
12109
77f23912
PE
12110 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12111 Remove unused functions.
cdf4ba58
PE
12112 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12113 (x_calc_absolute_position): Now static.
7411c686 12114 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12115 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12116 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12117 unless they are used.
38d0b34a
PE
12118 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12119 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12120 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12121 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12122 (x_error_catcher, x_connection_closed, x_error_handler):
12123 (x_error_quitter, xembed_send_message, x_iconify_frame):
12124 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12125 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12126 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12127
44f230aa
SM
12128 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12129 Rename or move locals to avoid shadowing.
6b463e58 12130 (tty_defined_color, merge_face_heights): Now static.
5967d051 12131 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12132 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12133 does not deduce is never used uninitialized.
73719eba
PE
12134 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12135 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12136
426994c3 12137 * terminal.c (store_terminal_param): Now static.
5489860b 12138
032f1620 12139 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12140 (set_frame_menubar): Remove unused local.
d4323972 12141 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12142 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12143 since they might point to immutable storage.
281585b0
PE
12144 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12145 since it's unused otherwise.
032f1620 12146
367c19e5 12147 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12148 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12149 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12150 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12151 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12152 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12153 does not deduce are never used uninitialized.
70739cbe 12154
07b48fa9
PE
12155 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12156
8868a238 12157 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12158 * window.c (window_loop, size_window):
12159 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12160
7e5cf297 12161 * window.c (display_buffer): Now static.
d6550a9f
PE
12162 (size_window): Mark variables that gcc -Wuninitialized
12163 does not deduce are never used uninitialized.
a586633d
PE
12164 * window.h (check_all_windows): New decl, to forestall
12165 gcc -Wmissing-prototypes diagnostic.
5b555da1 12166 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12167
f6095868
PE
12168 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12169 shadowing.
12170 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12171 Include <limits.h>.
12172 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12173 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12174 (load_charset_map): Mark variables that gcc -Wuninitialized
12175 does not deduce are never used uninitialized.
53df7c11 12176 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12177
f38b440c
PE
12178 * coding.c (coding_set_source, coding_set_destination):
12179 Use "else { /* comment */ }" rather than "else /* comment */;"
12180 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12181 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12182 a block, when the outer 'i' will do.
12183 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12184 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12185 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12186 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12187 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12188 Rename locals to avoid shadowing.
12189 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12190 * coding.c (emacs_mule_char, encode_invocation_designation):
12191 Now static, since they're not used elsewhere.
413bb2db 12192 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12193 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12194 (decode_coding_emacs_mule): Mark variables that gcc
12195 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12196 (detect_coding_iso_2022): Initialize a local variable that might
12197 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12198 this initialization is needed. (Bug#8211)
5f58e762
PE
12199 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12200 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12201 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12202 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12203 Remove unused macros.
f38b440c 12204
232b38b9 12205 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12206 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12207 * character.c (string_count_byte8): Likewise.
232b38b9 12208
fb90da1b
PE
12209 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12210 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12211
fb93dbc2
PE
12212 * chartab.c (copy_sub_char_table): Now static, since it's not used
12213 elsewhere.
5c156ace
PE
12214 (sub_char_table_ref_and_range, char_table_ref_and_range):
12215 Rename locals to avoid shadowing.
bbcd0949 12216 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12217
7d3b3862 12218 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12219 (BIDI_BOB): Remove unused macro.
7d3b3862 12220
6be7d3da
PE
12221 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12222 deduce are never used uninitialized.
c2ed9c8b 12223 * term.c (encode_terminal_code): Likewise.
6be7d3da 12224
75f8807f 12225 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12226
50938595
PE
12227 * tparam.h: New file.
12228 * term.c, tparam.h: Include it.
12229 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12230 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12231 Move these decls to tparam.h, and make them agree with what
12232 is actually in tparam.c. The previous trick of using incompatible
12233 decls in different modules does not conform to the C standard.
12234 All callers of tparam changed to use tparam's actual API.
12235 * tparam.c (tparam1, tparam, tgoto):
12236 Use const pointers where appropriate.
12237
fbceeba2
PE
12238 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12239 * cm.h (struct cm): Likewise.
12240 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12241 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12242 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12243 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12244 (turn_on_face, init_tty): Likewise.
12245 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12246
7f3f1250
PE
12247 * term.c (term_mouse_position): Rename local to avoid shadowing.
12248
e6ca6543
PE
12249 * alloc.c (mark_ttys): Move decl from here ...
12250 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12251
c40f8d15
AS
122522011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12253
12254 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12255
cfe0661d
JB
122562011-03-09 Juanma Barranquero <lekktu@gmail.com>
12257
12258 * search.c (compile_pattern_1): Remove argument regp, unused since
12259 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12260 (compile_pattern): Don't pass it.
12261
0afb4571
J
122622011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12263
12264 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12265 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12266 for ! HAVE_GTK3.
12267 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12268
12269 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12270
12271 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12272 gdk_window_get_screen, gdk_window_get_geometry,
12273 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12274 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12275 (xg_get_pixbuf_from_pixmap): New function.
12276 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12277 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12278 Call xg_get_pixbuf_from_pixmap instead of
12279 gdk_pixbuf_get_from_drawable.
12280 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12281 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12282 (xg_check_special_colors): Use GtkStyleContext and its functions
12283 for HAVE_GTK3.
12284 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12285 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12286 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12287 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12288 Call gtk_widget_get_preferred_size.
0afb4571
J
12289 (xg_frame_resized): gdk_window_get_geometry only takes 5
12290 parameters.
44f230aa
SM
12291 (xg_win_to_widget, xg_event_is_for_menubar):
12292 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12293 (xg_set_widget_bg): New function.
12294 (delete_cb): New function.
895009e1 12295 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12296 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12297 (xg_set_background_color): Call xg_set_widget_bg.
12298 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12299 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12300 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12301 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12302 if ! HAVE_GTK3.
12303 (update_frame_tool_bar): Call gtk_widget_hide.
12304 (xg_initialize): Use GDK_KEY_g.
12305
12306 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12307 if ! HAVE_GTK3
12308 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12309
12310 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12311 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12312 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12313
1c2cc4ef
JB
123142011-03-08 Juanma Barranquero <lekktu@gmail.com>
12315
12316 * w32xfns.c (select_palette): Check success of RealizePalette against
12317 GDI_ERROR, not zero.
12318
33383987 12319See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12320
12321;; Local Variables:
12322;; coding: utf-8
aac0c6e3
MR
12323;; End:
12324
2f097256 12325 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12326
12327 This file is part of GNU Emacs.
12328
12329 GNU Emacs is free software: you can redistribute it and/or modify
12330 it under the terms of the GNU General Public License as published by
12331 the Free Software Foundation, either version 3 of the License, or
12332 (at your option) any later version.
12333
12334 GNU Emacs is distributed in the hope that it will be useful,
12335 but WITHOUT ANY WARRANTY; without even the implied warranty of
12336 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12337 GNU General Public License for more details.
12338
12339 You should have received a copy of the GNU General Public License
12340 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.