* lisp/color.el (color-xyz-to-lab, color-lab-to-xyz, color-cie-de2000):
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7864a3f7
DA
12012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Use KSET for write access to Lisp_Object members of struct kboard.
4 * keyboard.h (KSET): New macro.
5 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
6 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
7 * xterm.c: Adjust users.
8
4c31be61
DA
92012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
10
11 Use BSET for write access to Lisp_Object members of struct buffer.
12 * buffer.h (BSET): New macro.
13 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
14 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
15 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
16 * window.c, xdisp.c, xfns.c: Adjust users.
17
14ae4239
BT
182012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
19
20 * lread.c (syms_of_lread): Initialize Vlexical_binding.
21
32bcadb4
JD
222012-08-11 Jan Djärv <jan.h.d@swipnet.se>
23
3d29b2ce
JD
24 * nsterm.m (not_in_argv): New function.
25 (application:openFile, application:openTempFile:):
26 (application:openFileWithoutUI:, application:openFiles:): Open file
27 if not_in_argv returns non-zero (bug#12171).
28
32bcadb4 29 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
30 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
31 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
32 (xg_get_font_name): Use those functions/macros here.
33 Reported by Frans Oilinki <moilinki@gmail.com>.
34
9ff9402d 352012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
36
37 * unexmacosx.c (copy_data_segment): Copy initialized data in
38 statically linked libraries from input file rather than memory.
39
db74a5fc
YM
40 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
41 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
42 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
43
25e65510
GM
442012-08-10 Glenn Morris <rgm@gnu.org>
45
46 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
47 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
48
7961135c
DA
492012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
50
51 Fix last change to allow compilation with low optimization levels.
52 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
53 Reported by Jan Djärv <jan.h.d@swipnet.se>.
54
42b3a444
DA
552012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
56
57 Use common inline syntax in intervals.h.
58 * intervals.h (INTERVALS_INLINE): New macro.
59 Change all users from LISP_INLINE.
60
9fb0c957
DA
612012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
62
63 Define Qnone once for all platforms.
64 * frame.c (Qnone): Define here.
65 (syms_of_frame): DEFSYM it.
66 * lisp.h (Qnone): New declaration.
67 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
68 * xfns.c: Remove duplication. Adjust users.
69
65e8ee52
DA
702012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
71
72 Remove unused macros from intervals.h.
73 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
74 * intervals.c: Adjust comment.
75
9b855fd6
EZ
762012-08-10 Eli Zaretskii <eliz@gnu.org>
77
78 * w32fns.c <w32_unicode_gui>: New static variable.
79 (globals_of_w32fns): Initialize it according to os_subtype.
80 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
81 testing os_subtype.
82
39cb9e56 832012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
84 Eli Zaretskii <eliz@gnu.org>
85
86 Fix bug #10299 with Unicode characters sent by customized
87 keyboards created by MSKLC.
88 * w32fns.c (INIT_WINDOW_CLASS): New macro.
89 (w32_init_class): Use it to initialize the Emacs class with either
90 ANSI or Unicode API calls.
91 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
92 later.
93 (w32_wnd_proc): If the character code sent by WM_CHAR or
94 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
95 original message. Call DefWindowProcW on NT and later.
96
9374581a
GM
972012-08-10 Glenn Morris <rgm@gnu.org>
98
4b94e8cf
GM
99 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
100
9374581a
GM
101 * lisp.h (DIRECTORY_SEP): Let configure set it.
102
a2752828
DA
1032012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
104
105 Use TSET for write access to Lisp_Object slots of struct terminal.
106 * termhooks.h (TSET): New macro.
107 * coding.c, terminal.c, xselect.c: Adjust users.
108
cc92c454
SM
1092012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
110
111 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
112 the failing expression, include them in the error message.
113 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
114 * lisp.h (internal_condition_case_n): Update declaration.
115
4cb3e6b3
DA
1162012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
117
118 Inline functions to examine and change buffer overlays.
119 * buffer.c (unchain_both): New function.
120 * buffer.h (buffer_get_overlays, buffer_set_overlays):
121 (buffer_has_overlays): New function.
122 (enum overlay_type): New enum.
123 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
124 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
125
8707c1e5
DA
1262012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
127
128 Inline functions to examine and change buffer intervals.
129 * alloc.c (mark_interval_tree): Remove.
130 (MARK_INTERVAL_TREE): Simplify.
131 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
132 * intervals.c (buffer_balance_intervals): New function.
133 (graft_intervals_into_buffer): Adjust indentation.
134 (set_intervals_multibyte): Simplify.
135 * buffer.h (BUF_INTERVALS): Remove.
136 (buffer_get_intervals, buffer_set_intervals): New function.
137 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
138 * intervals.c, textprop.c: Adjust users.
139
ad8c997f
DA
1402012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
141
142 Inline functions to examine and change string intervals.
143 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
144 (string_get_intervals, string_set_intervals): New function.
145 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
146 * lread.c, print.c, textprop.c: Adjust users.
147
32ac3a6b
GM
1482012-08-08 Glenn Morris <rgm@gnu.org>
149
150 * lisp.mk (lisp): Remove language/persian.elc.
151
77c7bcb1
DA
1522012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
153
154 Cleanup intervals.
155 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
156 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
157 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
158 Adjust comment. Move under #if 0.
77c7bcb1
DA
159 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
160 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
161
9c08a8d4
DA
1622012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
163
164 Check total length of intervals with eassert.
165 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
166 * intervals.c: Change all users to eassert.
167
26d16b35
EZ
1682012-08-07 Eli Zaretskii <eliz@gnu.org>
169
14ae4239
BT
170 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
171 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
172 INTERNAL_FIELD in Lisp_Cons.
173
c644523b
DA
1742012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
175
176 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
177 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
178 name since all xname users are fixed long time ago. Do not
179 use INTERNAL_FIELD.
180 (set_symbol_name, set_symbol_function, set_symbol_plist):
181 (set_symbol_next, set_overlay_plist): New function.
182 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
183 (struct Lisp_Overlay): Likewise.
184 (CVAR, MVAR, SVAR): Remove.
185 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
186 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
187 * xterm.c: Adjust users.
188 * .gdbinit: Change to use name field of struct Lisp_Symbol
189 where appropriate.
190
6a3d20cc
DA
1912012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
192
193 Basic functions to set Lisp_Object and pointer slots of intervals.
194 * intervals.h (interval_set_parent, interval_set_object):
195 (interval_set_left, interval_set_right, interval_set_plist):
196 (interval_copy_parent): New function.
197 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
198 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
199 Adjust indentation.
6a3d20cc
DA
200 (INTERVAL_SIZE): Remove. Adjust users.
201 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
202
4d2b044c
DA
2032012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
204
205 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
206 * process.h (PGET): Remove.
207 (struct Lisp_Process): Do not use INTERNAL_FIELD.
208 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
209
d3d50620
DA
2102012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
211
212 Drop WGET and revert read access to Lisp_Objects slots of struct window.
213 * window.h (WGET): Remove.
214 (struct window): Do not use INTERNAL_FIELD.
215 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
216 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
217 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
218 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
219 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
220 Adjust users.
221
d10a51dc
CY
2222012-08-07 Chong Yidong <cyd@gnu.org>
223
224 * window.c (Fwindow_edges, Fwindow_pixel_edges)
225 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
226 (Fdelete_window_internal): Signal an error if the window is not on
227 a live frame (Bug#12025).
228
e69b0960
DA
2292012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
230
231 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
232 * frame.h (FGET): Remove.
233 (struct frame): Do not use INTERNAL_FIELD.
234 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
235 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
236 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
237 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
238
25a20a3a
JB
2392012-08-06 Juanma Barranquero <lekktu@gmail.com>
240
241 * w32.c: Silence compiler warnings.
242 (map_w32_filename): Remove unused variable `is_fat'.
243 (chase_symlinks): Add parentheses around expression.
244
1c6f11f4
GM
2452012-08-06 Glenn Morris <rgm@gnu.org>
246
1db4583a
GM
247 * sysdep.c: Respect BROKEN_GETWD.
248
1c6f11f4
GM
249 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
250 Let configure handle it.
251 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
252
2b90362b
DA
2532012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
254
255 Use GCALIGNMENT where appropriate.
256 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
257 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
258 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
259
5f50daf2
EZ
2602012-08-06 Eli Zaretskii <eliz@gnu.org>
261
14ae4239
BT
262 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
263 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 264
cbcc7007
SM
2652012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
266
267 * buffer.h (struct buffer): Revert `indirections' to a simple int;
268 that should be sufficient for everyone.
269
4d365fa4
JD
2702012-08-06 Jan Djärv <jan.h.d@swipnet.se>
271
272 * keyboard.c (timer_check_2): Add break so timer_check returns next
273 timeout.
274
dd86bd82
DA
2752012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
276
277 Fix Windows build errors introduced after converting to WGET and WSET.
278 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
279 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
280
054e1668
JD
2812012-08-06 Jan Djärv <jan.h.d@swipnet.se>
282
283 * nsterm.m (ns_frame_rehighlight): Use FSET.
284
285 * nsmenu.m (ns_update_menubar): Use FSET.
286
21238f11
DA
2872012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
288
289 Separate read and write access to Lisp_Object slots of Lisp_Process.
290 * process.h (PGET, PSET): New macros similar to AREF and ASET.
291 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
292
077288cf
DA
2932012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
294
295 Separate read and write access to Lisp_Object slots of struct window.
296 * window.h (WGET, WSET): New macros similar to AREF and ASET.
297 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
298 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
299 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
300 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
301 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
302 Adjust users.
303
71688bd7
DA
3042012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
305
306 Fix Windows build errors introduced after converting to FGET and FSET.
307 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
308 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
309 (w32_judge_scroll_bars): Change to use FSET.
310 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
311
f99bac93
DA
3122012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
313
314 Fix replacement typo.
315 * window.c (replace_window): Set root_window instead of
316 selected_window. This fixes a total window subsystem
317 malfunction reported by Bastien Guerry <bzg@gnu.org>.
318
8c2a0f2d
GM
3192012-08-06 Glenn Morris <rgm@gnu.org>
320
321 * lisp.mk (lisp): Add language/persian.elc.
322
edd74c35
DA
3232012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
324
325 Separate read and write access to Lisp_Object slots of struct frame.
326 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
327 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
328 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
329 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
330 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
331
8671676c
AS
3322012-08-05 Andreas Schwab <schwab@linux-m68k.org>
333
334 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
335
663e2b3f
DA
3362012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
337
338 Generalize common compile-time constants.
339 * lisp.h (header_size, bool_header_size, word_size): Now here.
340 (struct Lisp_Vector): Add comment.
341 (struct Lisp_Bool_Vector): Move up to define handy constants.
342 (VECSIZE, PSEUDOVECSIZE): Simplify.
343 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
344 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
345 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
346 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
347 * xfont.c, xmenu.c: Use word_size where appropriate.
348
d32e47af
LM
3492012-08-05 Lawrence Mitchell <wence@gmx.li>
350
351 * search.c (Freplace_match): Treat \? in the replacement text
352 literally (Bug#8161).
353
e5d9c0d1
CY
3542012-08-05 Chong Yidong <cyd@gnu.org>
355
356 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
357 * frame.c (Vdelete_frame_functions):
358 * emacs.c (Vkill_emacs_hook): Doc fix.
359
8da0576b
EZ
3602012-08-04 Eli Zaretskii <eliz@gnu.org>
361
362 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
363 --with-x-toolkit=no builds.
364 Reported by Carsten Mattner <carstenmattner@gmail.com>.
365
02676e5d
CY
3662012-08-04 Chong Yidong <cyd@gnu.org>
367
368 * syntax.c (Fmodify_syntax_entry): Doc fix.
369
97147da9
EZ
3702012-08-04 Eli Zaretskii <eliz@gnu.org>
371
76151e2c
EZ
372 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
373 * w32.c (init_environment): Change the default values of many
374 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
375 them into environment when they were not already defined.
376 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 377 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
378 (check_windows_init_file): Now external, not static.
379 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
380 called when Vload_path is already set up.
381
382 * w32.h (check_windows_init_file): Add prototype.
383
384 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
385 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
386 compatibility with Posix platforms.
387 (main): Move the call to check_windows_init_file to here from
388 w32.c.
389 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
390 any, in the DEFALT argument into the root of the Emacs build or
391 installation tree, as appropriate.
392
393 * callproc.c (init_callproc_1): Call decode_env_path instead of
394 doing its equivalent by hand.
395 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
396 the code that sets Vexec_path run on MS-Windows.
397
398 * lread.c (init_lread): Add comments to #ifdef's.
399
97147da9
EZ
400 * msdos.c (dos_set_window_size, IT_update_begin)
401 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
402 instead of direct references.
403
185ee146
PE
4042012-08-04 Paul Eggert <eggert@cs.ucla.edu>
405
406 Export DEFAULT_REHASH_* to GDB.
407 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
408 Now constants, not macros.
409
8834c57a
PE
4102012-08-03 Paul Eggert <eggert@cs.ucla.edu>
411
98c6f1e3
PE
412 Remove unnecessary casts involving pointers.
413 These casts are no longer needed now that we assume C89 or later,
414 since they involve casting to or from void *.
415 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
416 (make_pure_float, make_pure_vector):
417 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
418 * macros.c (Fstart_kbd_macro):
419 * menu.c (find_and_return_menu_selection):
420 * minibuf.c (read_minibuf_noninteractive):
421 * sysdep.c (closedir):
422 * xdisp.c (x_produce_glyphs):
423 * xfaces.c (compare_fonts_by_sort_order):
424 * xfns.c (x_real_positions, select_visual):
425 * xselect.c (x_stop_queuing_selection_requests)
426 (x_get_window_property, x_get_window_property_as_lisp_data):
427 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
428 Remove unnecessary pointer casts.
429 * alloc.c (record_xmalloc): New function.
430 * lisp.h (record_xmalloc): New decl.
431 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
432 more like a function. This is because the pointer cast is not
433 needed. All uses changed.
434 * print.c (print_string, print_error_message): Avoid length recalc.
435
8834c57a
PE
436 Improve fix for macroexp crash with debugging (Bug#12118).
437 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
438 ARRAY_MARK_FLAG when checking subscripts, because ASET is
439 not supposed to be invoked from the garbage collector.
440 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
441 (gc_aset): New function, which is like ASET but can be
442 used in the garbage collector.
443 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
444 (set_hash_index): Use it instead of ASET.
445
6dad7178
EZ
4462012-08-03 Eli Zaretskii <eliz@gnu.org>
447
448 Support symlinks on latest versions of MS-Windows.
449 * w32.c: Include winioctl.h and aclapi.h.
450 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
451 (revert_to_self): Forward declarations of static functions.
452 <static BOOL g_b_init_get_security_info>:
453 <g_b_init_create_symbolic_link>: New static flags.
454 (globals_of_w32): Initialize them to zero.
455 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
456 (map_w32_filename): Improve commentary. Simplify switch.
457 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
458 headers (most versions of MinGW w32api don't).
459 (get_security_info, create_symbolic_link)
460 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
461 New functions.
462 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
463 in the argument file name.
464 (sys_access): Call unc_volume_file_attributes only if
465 GetFileAttributes fails with network-related error codes.
466 (sys_rename): Diagnose renaming of a symlink when the user doesn't
467 have the required privileges.
14ae4239 468 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
469 get_file_security_desc.
470 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
471 with addition of handling of symlinks and support for 'lstat'.
472 If possible, get file's attributes and security information by
6dad7178
EZ
473 handle, not by name. Produce S_IFLNK bit for symlinks, when
474 called from 'lstat'.
475 (stat, lstat): New functions, call 'stat_worker'.
476 (symlink, readlink, careadlinkat): Rewritten to create and resolve
477 symlinks when the underlying filesystem supports them.
478
f162bcc3
PE
4792012-08-02 Paul Eggert <eggert@cs.ucla.edu>
480
79ea6c20
PE
481 Fix macroexp crash on Windows with debugging (Bug#12118).
482 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
483 checking subscripts; problem introduced with the recent
484 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
485 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
486 since it's used in non-static inline functions now.
487
c0ce93fd
PE
488 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
489 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 490
f162bcc3
PE
491 Use C99-style 'extern inline' if available.
492 * buffer.h (BUFFER_INLINE):
493 * category.h (CATEGORY_INLINE):
494 * character.h (CHARACTER_INLINE):
495 * charset.h (CHARSET_INLINE):
496 * composite.h (COMPOSITE_INLINE):
497 * dispextern.h (DISPEXTERN_INLINE):
498 * lisp.h (LISP_INLINE):
499 * systime.h (SYSTIME_INLINE):
500 New macro, replacing 'static inline' in this header.
501 * buffer.h, category.h, character.h, charset.h, composite.h:
502 * dispextern.h, lisp.h, systime.h:
503 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
504 * alloc.c (LISP_INLINE):
505 * buffer.c (BUFFER_INLINE):
506 * category.c (CATEGORY_INLINE):
507 * character.c (CHARACTER_INLINE):
508 * charset.c (CHARSET_INLINE):
509 * composite.c (COMPOSITE_INLINE):
510 * dispnew.c (DISPEXTERN_INLINE):
511 * sysdep.c (SYSTIME_INLINE):
512 Define to EXTERN_INLINE, so that the corresponding functions
513 are compiled into code.
514 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
515 (INLINE_HEADER_END): New macros.
516 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
517 since it's used in non-static inline functions now.
a8333d03 518 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 519
837b365b
GM
5202012-08-02 Glenn Morris <rgm@gnu.org>
521
d66b744d
GM
522 * s/: Remove empty directory.
523
837b365b
GM
524 * s/ms-w32.h: Move to ../nt/inc.
525 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
526 Update for new ms-w32.h location.
527
13294f95
PE
5282012-08-02 Paul Eggert <eggert@cs.ucla.edu>
529
530 Port to Solaris 8.
531 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
532
90df0db3
GM
5332012-08-02 Glenn Morris <rgm@gnu.org>
534
535 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
536 hard-coding the path separator.
537
4939150c
PE
5382012-08-01 Paul Eggert <eggert@cs.ucla.edu>
539
540 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
541 This how ASET and AREF are supposed to work, and makes
542 it easier to think about future improvements. See
543 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
544 * charset.h (set_charset_attr): New function.
545 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
546 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
547 (aref_addr): New function. All uses of &AREF(...) changed.
548 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
549 (set_hash_index): New functions. All lvalue-style uses of
550 HASH_KEY etc. changed.
551 * keyboard.c (set_prop): New function. All lvalue-style uses
552 of PROP changed.
553
947b2afd
AA
5542012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
555
556 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
557 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
558 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
559 * nsfns.m (ns_set_name_as_filename): Likewise.
560 * nsmenu.m (ns_update_menubar): Likewise.
561 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
562
4f5d0325
EZ
5632012-08-01 Eli Zaretskii <eliz@gnu.org>
564
2008beae
EZ
565 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
566 Adapt to latest changes in field names of the corresponding Lisp
288479f6 567 objects.
2008beae 568
4f5d0325
EZ
569 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
570
fe3cc771
GM
5712012-08-01 Glenn Morris <rgm@gnu.org>
572
573 * s/msdos.h: Remove file.
574 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
575 * Makefile.in (S_FILE): Remove.
576 (config_h): Remove S_FILE.
577
c90acc54
JB
5782012-08-01 Juanma Barranquero <lekktu@gmail.com>
579
580 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
581 Remove; moved to nt/config.nt.
582
d8a05828
DA
5832012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
584
585 Use INTERNAL_FIELD for conses and overlays.
586 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
587 Remove obsolete comment.
588 (MVAR): New macro.
589 (struct Lisp_Overlay): Use INTERNAL_FIELD.
590 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
591
8271d590
DA
5922012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
593
594 Use INTERNAL_FIELD for symbols.
595 * lisp.h (SVAR): New macro. Adjust users.
596 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
597 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
598
3193acd2
DA
5992012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
600
601 Use INTERNAL_FIELD for processes.
602 * process.h (PVAR): New macro. Adjust style.
603 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
604 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
605
3a45383a
DA
6062012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
607
608 Use INTERNAL_FIELD for windows.
609 * window.h (WVAR): New macro.
610 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
611 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
612 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
613 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
614 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
615 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
616
c1dbc63c
PE
6172012-08-01 Paul Eggert <eggert@cs.ucla.edu>
618
619 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
620
5c0c0e8a
GM
6212012-08-01 Glenn Morris <rgm@gnu.org>
622
623 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
624 Move to configure.ac.
625
552a99b4
JB
6262012-08-01 Juanma Barranquero <lekktu@gmail.com>
627
628 * makefile.w32-in (CONFIG_H): Update dependencies.
629 (CONF_POST_H): New macro.
630
631 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
632
8d8e2dfe
GM
6332012-07-31 Glenn Morris <rgm@gnu.org>
634
bc96620a
GM
635 * Makefile.in (S_FILE): No longer set by configure.
636
476b1b2d
GM
637 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
638 is available.
639 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
640
b2c7a106
GM
641 * process.h (NULL_DEVICE):
642 * emacs.c (SEPCHAR):
643 * editfns.c (USER_FULL_NAME): Let configure set them.
644
d53d062a
GM
645 * s/README, s/template.h: Remove files.
646
4515017f
GM
647 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
648
8d8e2dfe
GM
649 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
650 Move to configure.ac.
651
5b20b3cc
EZ
6522012-07-31 Eli Zaretskii <eliz@gnu.org>
653
1e0afd9a
EZ
654 * .gdbinit (xframe): Adapt to introduction of FVAR and the
655 resulting renaming of 'struct frame' members.
656
5b20b3cc
EZ
657 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
658
659 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
660 after introduction of FVAR.
661
f1310128
JD
6622012-07-31 Jan Djärv <jan.h.d@swipnet.se>
663
79e721e0
JD
664 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
665
666 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
667 instead of compositeToPoint.
668 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
669
8d7c7eed 670 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 671
e34f7f79
DA
6722012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
673
674 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
675 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 676 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
677 (BVAR): Change to use INTERNAL_FIELD.
678 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
679 (KVAR): Change to use INTERNAL_FIELD.
680 * frame.h (FVAR): New macro.
681 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
682 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
683 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
684 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
685 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
686
c09bfb2f
DA
6872012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
688
689 Miscellaneous fixes for non-default X toolkits.
690 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
691 * xterm.c (x_frame_of_widget): Remove redundant prototype.
692 Move under #ifdef USE_LUCID.
693 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
694 definition and usage to avoid warnings.
695
14c114ae
JD
6962012-07-31 Jan Djärv <jan.h.d@swipnet.se>
697
698 * nsterm.m (openFiles): Fix previous checkin.
699
3bd21e82
PE
7002012-07-31 Paul Eggert <eggert@cs.ucla.edu>
701
702 * indent.c (compute_motion): Remove unused local.
703
c1529ded
GM
7042012-07-31 Glenn Morris <rgm@gnu.org>
705
400d5621
GM
706 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
707
268e2432
GM
708 * conf_post.h [USG5_4]:
709 Move remaining contents of s/usg5-4-common.h here.
710 * s/usg5-4-common.h: Remove file.
711
7552f3ee
GM
712 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
713 * s/irix6-5.h: Remove file.
714
6a381852
GM
715 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
716 * s/darwin.h: Remove file.
717
c1529ded
GM
718 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
719 * s/hpux10-20.h: Remove file, which is now empty.
720
b429a4ee
GM
7212012-07-30 Glenn Morris <rgm@gnu.org>
722
723 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
724 * Makefile.in (config_h): Add conf_post.h.
725 * makefile.w32-in (CONFIG_H): Add conf_post.h.
726
adff3182
JD
7272012-07-30 Jan Djärv <jan.h.d@swipnet.se>
728
729 * nsterm.m (ns_do_open_file): New variable.
b9031d69 730 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
731 (openFile, openTempFile, openFileWithoutUI, openFiles):
732 Open files only if ns_do_open_file.
adff3182 733
c32af1e4
PE
7342012-07-30 Paul Eggert <eggert@cs.ucla.edu>
735
7393bcbb
PE
736 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
737 This no-op macro hasn't been needed for many years.
738 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
739
c32af1e4
PE
740 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
741 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
742 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
743 gdb_make_enums_visible.
744 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
745 (DIRECTORY_SEP): Now a constant, not a macro.
746
302fc036
EZ
7472012-07-30 Eli Zaretskii <eliz@gnu.org>
748
749 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
750 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
751
752 * w32term.c <w32_keyboard_codepage>: Renamed from
753 keyboard_codepage and now external. All users changed.
754
755 * w32term.h: Add declaration of w32_keyboard_codepage.
756
757 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
758 the codepage to translate keys to Unicode. If this argument is
759 -1, use the value returned by GetConsoleCP. All callers changed.
760
88fb40b4
PE
7612012-07-30 Paul Eggert <eggert@cs.ucla.edu>
762
0aee6912
PE
763 Update .PHONY listings in makefiles.
764 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
765 bootstrap-clean, distclean, maintainer-clean, versioclean,
766 extraclean, frc.
767
88fb40b4
PE
768 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
769 This is a bit clearer. Fix some commentary typos.
770
0a763bd1
GM
7712012-07-30 Glenn Morris <rgm@gnu.org>
772
32bac6d6
GM
773 * s/netbsd.h: Let configure include signal.h if needed.
774 Remove file, which is now empty.
775
b65e7c46
GM
776 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
777 Let configure set them.
778 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
779 No more need to undefine.
0a763bd1 780
169304bd
AS
7812012-07-30 Andreas Schwab <schwab@linux-m68k.org>
782
783 * keymap.c (Fkey_description): Don't remove 0x80 bit from
784 non-single-byte char when adding meta modifier. (Bug#12090)
785
6cd7a139
DA
7862012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
787
788 Convert safe_call to use variable number of arguments.
789 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
790 (safe_call2): Fix comment.
791 * lisp.h (safe_call): Adjust prototype.
792 * coding.c (encode_coding_object): Change to use safe_call2.
793 * xfaces.c (merge_face_heights): Change to use safe_call1.
794
d34d6ffc
GM
7952012-07-30 Glenn Morris <rgm@gnu.org>
796
7b8a48e4 797 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 798 does that unconditionally. Remove file, which is now empty.
7b8a48e4 799
d34d6ffc
GM
800 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
801 Remove empty files.
802
03a660a6
PE
8032012-07-30 Paul Eggert <eggert@cs.ucla.edu>
804
805 Export to GDB most of lisp.h's remaining object-like macros.
806 * lisp.h (min, max): Move earlier, because they're used earlier now.
807 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
808 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
809 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
810 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
811 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
812 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
813 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
814 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
815 Now constants, for GDB. They need not be macros.
816 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
817 Now constants, for GDB, as well as macros, for static initializers.
818 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
819 Move to after the definition of struct Lisp_Char_Table,
820 since the former now needs that type defined.
821 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
822 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
823 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
824 New enums, for gdb_make_enums_visible.
825 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 826 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
827 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
828 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
829 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
830 enum maxargs, enum MAX_ALLOCA.
831 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
832 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
833 no longer needed, now that they are done in lisp.h.
834
e499d0ee
DA
8352012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
836
837 Cleanup string bytes checking.
838 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
839 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
840 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
841 (check_sblock, compact_small_strings): Simplify.
842
d5040d2d
PE
8432012-07-29 Paul Eggert <eggert@cs.ucla.edu>
844
845 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
846 These macros are confusing and no longer need to be defined, as
847 the enum values now suffice. All uses replaced with definiens.
848 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
849
7f259ae6
JB
8502012-07-29 Juanma Barranquero <lekktu@gmail.com>
851
852 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
853 ($(BLD)/w32console.$(O)): Update dependencies.
854
7e63e0c3
DA
8552012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
856
857 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
858 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
859 time. Adjust users.
860 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
861
ffd817eb
JD
8622012-07-29 Jan Djärv <jan.h.d@swipnet.se>
863
864 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
865 setting sitelisp (Bug#12010).
866
417a7a0e
EZ
8672012-07-29 Eli Zaretskii <eliz@gnu.org>
868
14ae4239 869 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
870
871 * w32heap.c (cache_system_info):
872 * w32.c (sys_rename):
873 * w32proc.c (find_child_console, sys_kill): All users changed.
874
387d4d92
PE
8752012-07-29 Paul Eggert <eggert@cs.ucla.edu>
876
877 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
878
55a6cca6
EZ
8792012-07-29 Eli Zaretskii <eliz@gnu.org>
880
881 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
882
dbcf001c
DA
8832012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
884
885 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
886 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
887 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 888
e2688e4a
DA
8892012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
890
891 Generalize marker debugging code under MARKER_DEBUG and use eassert.
892 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
893 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
894 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
895 (replace_range, replace_range_2, del_range_2): Change to eassert.
896 * marker.c (byte_char_debug_check): Adjust style.
897
b46a6a83
PE
8982012-07-29 Paul Eggert <eggert@cs.ucla.edu>
899
900 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
901 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
902 long-ago-commented-out code that talks about "WIN32".
903 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
904 All uses changed.
905
e32a5799
PE
9062012-07-28 Paul Eggert <eggert@cs.ucla.edu>
907
908 Use Gnulib stdalign module (Bug#9772, Bug#9960).
909 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
910 Simplify by using alignof.
911 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
912 * lisp.h: Include <stdalign.h>.
913 (GCALIGNMENT): New macro and constant.
914 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
915 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
916 (stdalign): New macro, if not already defined.
917
df81cd29
EZ
9182012-07-28 Eli Zaretskii <eliz@gnu.org>
919
01bd1b0d
EZ
920 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
921 * w32inevt.c: Include w32inevt.h.
922 (w32_read_console_input): New inline function, calls either
923 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
924 w32_console_unicode_input.
925 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
926 (w32_kbd_patch_key, key_event): Use the codepage returned by
927 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
928 (key_event): use uChar.UnicodeChar only if
929 w32_console_unicode_input is non-zero.
930
931 * w32console.c: Include w32heap.h.
932 <w32_console_unicode_input>: New global variable.
933 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
934 family of Windows, zero otherwise.
935
936 * w32inevt.h: Declare w32_console_unicode_input.
937
df81cd29
EZ
938 * xdisp.c (init_iterator): Don't reference tip_frame in a build
939 --without-x. (Bug#11742)
940
c20fdd9e
PE
9412012-07-27 Paul Eggert <eggert@cs.ucla.edu>
942
943 Adjust GDB to reflect pvec_type changes (Bug#12036).
944 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
945 2012-07-04 changes to pseudovector representation.
946 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 947
32770973 9482012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
949
950 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
951 bus address.
952 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
953
3438fe21
EZ
9542012-07-27 Eli Zaretskii <eliz@gnu.org>
955
bcfbc9de
EZ
956 * alloc.c (listn): Fix the order the arguments are consed onto the
957 list.
958
3438fe21
EZ
959 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
960 enumeration constants, as PURE and HEAP are too general, and clash
961 with other headers and sources, such as gmalloc.c and the
962 MS-Windows system headers. All users changed.
963
eeaea515
DA
9642012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
965
966 Revert last save_excursion_save and save_excursion_restore changes.
967 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
968 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
969
073c88c2
DA
9702012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
971
972 Fix recently-introduced typos in Windows port.
973 Reported by Martin Rudalics <rudalics@gmx.at>.
974 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 975 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 976
4706125e
PE
9772012-07-27 Paul Eggert <eggert@cs.ucla.edu>
978
979 Improve GDB symbol export (Bug#12036).
980 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
981 arms of an 'if', not using conditional expressions; otherwise GDB
982 complains about the types in the unevaluated arm when the argument
983 is an integer literal.
984 (xgetint): Simplify expression.
985 * alloc.c (gdb_make_enums_visible): New constant. This ports to
986 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
987 Zaretskii in <http://bugs.gnu.org/12036#13>.
988 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
989 needed now that we have gdb_make_enums_visible.
990 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
991 (enum enum_USE_LSB_TAG):
992 New enum types, packaging up enums that need to be exported to GDB.
993
694b6c97
DA
9942012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
995
996 Utility function to make a list from specified amount of objects.
997 * lisp.h (enum constype): New datatype.
998 (listn): New prototype.
999 * alloc.c (listn): New function.
1000 (Fmemory_use_count, syms_of_alloc): Use it.
1001 * buffer.c (syms_of_buffer): Likewise.
1002 * callint.c (syms_of_callint): Likewise.
1003 * charset.c (define_charset_internal): Likewise.
1004 * coding.c (syms_of_coding): Likewise.
1005 * keymap.c (syms_of_keymap): Likewise.
1006 * search.c (syms_of_search): Likewise.
1007 * syntax.c (syms_of_syntax): Likewise.
1008 * w32.c (init_environment): Likewise.
1009 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1010 * xdisp.c (syms_of_xdisp): Likewise.
1011 * xfns.c (syms_of_xfns): Likewise.
1012
6195f384
DA
10132012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1014
1015 Fast save_excursion_save and save_excursion_restore.
1016 * lisp.h (struct Lisp_Excursion): New data type.
1017 (PVEC_EXCURSION): New pseudovector type.
1018 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1019 to deal with it. Adjust comments.
1020 (init_marker, attach_marker): New prototype.
1021 (unchain_marker): Adjust prototype.
1022 * marker.c (attach_marker): Change to global.
1023 (init_marker): New function.
1024 * alloc.c (Fmake_marker, build_marker): Use it.
1025 (build_marker): More easserts.
1026 (mark_object): Handle struct Lisp_Excursion.
1027 * editfns.c (save_excursion_save, save_excursion_restore):
1028 Reimplement to use struct Lisp_Excursion. Add comments.
1029
5eceb8fb
PE
10302012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1031
1032 Fix export of symbols to GDB (Bug#12036).
1033 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1034 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1035 emacs.c, as this is a more-suitable home. Had this been done earlier
1036 the fix for 12036 would have avoided some of the problems noted in
1037 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1038 would have been more obvious.
562157c8
PE
1039 * emacs.c: Do not include <verify.h>; no longer needed.
1040 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1041 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1042 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1043 Remove; now done in lisp.h.
1044 * lisp.h (PUBLISH_TO_GDB): New macro.
1045 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1046 (DATA_SEG_BITS): Use it.
1047 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1048 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1049 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1050 not be usable in #if. This simplifies things.
1051
d6749401
JB
10522012-07-26 Juanma Barranquero <lekktu@gmail.com>
1053
1054 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1055
1781b9e9
PE
10562012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1057
d89518db 1058 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1059 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1060 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1061 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1062 Adjust to changes in lisp.h and emacs.c, by using
1063 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1064 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1065 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1066 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1067 instead of gdb_valbits.
1068 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1069 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1070 instead of gdb_array_mark_flag.
1071 (xboolvector): Get size from $->size, not $->header.size.
1072 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1073 (xreload, hook-run, hookpost-run): Remove.
1074 * emacs.c: Include <verify.h>.
1075 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1076 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1077 Remove.
1078 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1079 (gdb_USE_LSB_TAG): New enum constants.
1080 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1081 Also define these as enum constants, so they're visible to GDB.
1082 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1083 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1084 as constants, so they're visible to GDB.
1085 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1086 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1087 Now enum constants, not macros, so they're visible to GDB.
1088 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1089 more convenient now. All uses changed.
1090 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1091 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1092
3628596a
DA
10932012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1094
1095 Explicitly free restriction data that are not needed anymore.
1096 * editfns.c (save_restriction_restore): Free restriction data.
1097
7abaf5cc
SM
10982012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1099
1100 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1101 add argument, tune behavior, and adjust all callers.
1102
71f88e00
PE
11032012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1104
1105 Use typedef for EMACS_INT, EMACS_UINT.
1106 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1107 than macros. This simplifies debugging in the usual case, since
1108 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1109 and it allows expressions involving EMACS_INT casts.
1110 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1111
57ec3034
JD
11122012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1113
1114 * nsterm.m (ns_read_socket): Return early if there is a modal
1115 window (Bug#12043).
1116
8137e7b3
MR
11172012-07-25 Martin Rudalics <rudalics@gmx.at>
1118
1119 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1120 that FOCUS-FRAME can be omitted.
1121
04e9897c
DA
11222012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1123
1124 Adjust buffer text indirection counters at the end of Fkill_buffer.
1125 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1126 buffer is definitely dead. This should really fix an issue reported
1127 by Christoph Scholtes again. (Bug#12007).
1128 (init_buffer_once): Initialize indirection counters of
1129 buffer_defaults and buffer_local_symbols (for sanity and safety).
1130
8a0484e1
EZ
11312012-07-24 Eli Zaretskii <eliz@gnu.org>
1132
1133 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1134 and continuation glyphs on tooltip frames, leave them at zero.
1135 Avoids continued lines in tooltips. (Bug#11832)
1136
fa691a83
DA
11372012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1138
1139 Simplify copy_overlay.
04e9897c 1140 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1141 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1142
436bc8e0
EZ
11432012-07-23 Eli Zaretskii <eliz@gnu.org>
1144
1145 * print.c (print_object): Don't crash when a frame's name is nil
1146 or invalid. (Bug#12025)
1147
1148 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1149 it signals an error when a tooltip frame is being created.
1150
d7a7fda3
DA
11512012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1152
1153 Cleanup miscellaneous objects allocation and initialization.
1154 * alloc.c (allocate_misc): Change to static. Add argument to
1155 specify the subtype. Adjust comment and users.
1156 (build_overlay): New function.
1157 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1158 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1159 (allocate_misc): Remove prototype.
1160 (build_overlay): Add prototype.
1161
11622012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1163
1164 Swap buffer text indirection counters in Fbuffer_swap_text.
1165 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1166 This avoids crash reported by Christoph Scholtes at
1167 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1168
9d7fa573
JD
11692012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1170
1171 * nsmenu.m (Popdown_data): New struct.
1172 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1173 free Popdown_data.
1174 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1175 (initWithContentRect): Make imgView and contentView non-static
1176 and autorelease them. Also autorelease img and matrix (Bug#12005).
1177 (dealloc): Remove (Bug#12005).
1178
0dd6d66d
DA
11792012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1180
1181 Adjust consing_since_gc when objects are explicitly freed.
1182 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1183 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1184 (free_cons, free_misc): Subtract object size from consing_since_gc.
1185
d36d71df
DA
11862012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1187
1188 Simplify and cleanup markers positioning code.
1189 * marker.c (attach_marker): More useful eassert.
1190 (live_buffer, set_marker_internal): New function.
1191 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1192 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1193
fb9ea40f
PE
11942012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1195
1196 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1197 as it's limited by the amount of memory, not by INT_MAX.
1198
2d5c5f7d
EZ
11992012-07-21 Eli Zaretskii <eliz@gnu.org>
1200
07fb592e
EZ
1201 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1202 in special-event-map. See the discussion at
1203 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1204 for the reasons.
1205
37a9eac8 1206 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1207 info.dwItemData. Fixes crashes on 64-bit Windows.
1208 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1209
c4328746
JD
12102012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1211
1212 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1213 (conversationIdentifier): Return value is NSInteger.
784051c4 1214 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1215
6e5d1c12
CY
12162012-07-21 Chong Yidong <cyd@gnu.org>
1217
1218 * window.c (decode_any_window): Signal an error if the window is
1219 on a dead frame (Bug#11984).
1220
9928463d
DA
12212012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1222
1223 Add indirection counting to speed up Fkill_buffer.
1224 * buffer.h (struct buffer): New member.
1225 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1226 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1227 base buffer indirection counter.
1228 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1229 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1230 through buffer list if indirection counter is 0.
1231
f8643a6b
DA
12322012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1233
1234 Extend the value returned by Fgarbage_collect with heap statistics.
1235 * alloc.c (Qheap): New symbol.
1236 (syms_of_alloc): DEFSYM it.
1237 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1238 (Fmemory_free): Remove.
1239 (syms_of_alloc): Don't defsubr it.
1240 * buffer.c (Fcompact_buffer): Remove.
1241 (syms_of_buffer): Don't defsubr it.
1242
dac616ff
DA
12432012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1244
1245 Make maybe_gc inline.
1246 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1247 * lisp.h (consing_since_gc, gc_relative_threshold)
1248 (memory_full_cons_threshold): Revert declaration.
1249 (maybe_gc): Remove prototype, define as inline.
1250 * alloc.c: Remove old commented-out code.
1251 (consing_since_gc, gc_relative_threshold)
1252 (memory_full_cons_threshold): Revert to global.
1253 (maybe_gc): Remove.
1254
d7ea76b4
DA
12552012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1256
1257 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1258 * lisp.h (build_unibyte_string): New function.
1259 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1260 * sysdep.c, w32fns.c, xfns.c: Use it.
1261 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1262 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1263 Adjust users accordingly.
1264 * font.h (font_open_by_name): Adjust prototype.
1265
765e61e3
DA
12662012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1267
1268 Cleanup calls to Fgarbage_collect.
1269 * lisp.h (maybe_gc): New prototype.
1270 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1271 Remove declarations.
1272 * alloc.c (maybe_gc): New function.
1273 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1274 Make them static.
1275 * bytecode.c (MAYBE_GC): Use maybe_gc.
1276 * eval.c (eval_sub, Ffuncall): Likewise.
1277 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1278 to avoid dependency from auto-save feature.
1279
52b852c7
PE
12802012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1281
1282 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1283 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1284 'for_each_per_buffer_object_at'.
1285 All uses changed. It's better to use upper-case for macros that
1286 cannot be implemented as functions, to give the reader a clue
1287 that they're special.
1288
5db81e33
SM
12892012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1290
1291 * alloc.c (Fgarbage_collect): Tweak docstring.
1292
5b835e1d
DA
12932012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1294
1295 Tweak the value returned from Fgarbage_collect again.
1296 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1297 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1298 Adjust documentation.
1299 (total_vector_bytes): Rename to total_vector_slots, adjust
1300 accounting.
1301 (total_free_vector_bytes): Rename to total_free_vector_slots,
1302 adjust accounting.
1303 (Qstring_bytes, Qvector_slots): New symbols.
1304 (syms_of_alloc): DEFSYM them.
1305
9cd47b72
DA
13062012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1307
1308 Buffer compaction primitive which may be used from Lisp.
1309 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1310 (syms_of_buffer): Register Fcompact_buffer.
1311 * alloc.c (Fgarbage_collect): Use compact_buffer.
1312 * buffer.h (compact_buffer): New prototype.
1313 (struct buffer_text): New member.
1314
d17337e5
DA
13152012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1316
1317 New macro to iterate over all buffers, miscellaneous cleanups.
1318 * lisp.h (all_buffers): Remove declaration.
1319 * buffer.h (all_buffers): Add declaration, with comment.
1320 (for_each_buffer): New macro.
1321 * alloc.c (Fgarbage_collect, mark_object): Use it.
1322 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1323 (init_buffer): Likewise.
1324 * data.c (Fset_default): Likewise.
1325 * coding.c (code_conversion_restore): Remove redundant check
1326 for dead buffer.
1327 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1328
60cfd278
AS
13292012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1330
1331 Fix bug that created negative-length intervals.
1332 * intervals.c (merge_interval_right, merge_interval_left):
1333 Do not zero out this interval if it is absorbed by its children,
1334 as this interval's total length doesn't change in that case. See
1335 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1336
d06714cb
PE
13372012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1338
83713154
PE
1339 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1340 when invoking (make-bool-vector N t) and N is a positive
1341 multiple of 8 -- the last 8 bits were mistakenly cleared.
1342
d06714cb
PE
1343 Remove some struct layout assumptions in bool vectors.
1344 * alloc.c (bool_header_size): New constant.
1345 (header_size, word_size): Move earlier, as they're now used earlier.
1346 Use 'word_size' in a few more places, where it's appropriate.
1347 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1348 padding before the data member of a bool vector.
1349 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1350 than doing the check by hand with an abort ().
1351
464d5a5e
SM
13522012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1353
5fbc0409
SM
1354 * eval.c (Fdefvar): Don't check constants since we only set the var if
1355 it's not yet defined anyway (bug#11904).
1356
464d5a5e
SM
1357 * lisp.h (last_undo_boundary): Declare new var.
1358 * keyboard.c (command_loop_1): Set it.
1359 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1360 were auto-added by the command loop (bug#11774).
1361
8dc2e44a
AS
13622012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1363
1364 * w32font.c (Qsymbol): Remove local definition.
1365 (syms_of_w32font): Don't DEFSYM it.
1366
169925ec
DA
13672012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1368
1369 Fix sweep_vectors to handle large bool vectors correctly.
1370 * alloc.c (sweep_vectors): Account total_vector_bytes for
1371 bool vectors larger than VBLOCK_BYTES_MAX.
1372
5fbfb018
CY
13732012-07-18 Chong Yidong <cyd@gnu.org>
1374
1375 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1376 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1377
3ab6e069
DA
13782012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1379
1380 Return more descriptive data from Fgarbage_collect.
1381 Suggested by Stefan Monnier in
1382 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1383 * alloc.c (bounded_number): New function.
1384 (total_buffers, total_vectors): New variable.
1385 (total_string_size): Rename to total_string_bytes, adjust users.
1386 (total_vector_size): Rename to total_vector_bytes, adjust users.
1387 (sweep_vectors): Account total_vectors and total_vector_bytes.
1388 (Fgarbage_collect): New return value. Adjust documentation.
1389 (gc_sweep): Account total_buffers.
1390 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1391 (VECTOR_SIZE): Remove.
1392 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1393 (Qinterval, Qmisc): New symbols.
1394 (syms_of_data): Initialize them.
1395 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1396 (Qcons, Qbuffer): New declarations.
1397
6d02fe5b
PE
13982012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1399
1400 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1401 Round up, not down. Improve doc.
1402
b7ffe040
DA
14032012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1404
1405 Restore old code in allocate_string_data to avoid Faset breakage.
1406 Reported by Julien Danjou <julien@danjou.info> in
1407 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1408 * alloc.c (allocate_string_data): Restore old code with minor
1409 adjustments, fix comment to explain this subtle issue.
1410
4dc7c8d5
SM
14112012-07-17 Eli Zaretskii <eliz@gnu.org>
1412
1413 Remove FILE_SYSTEM_CASE.
1414 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1415
1416 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1417 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1418 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1419 call-process-region passes it through expand-file-name.
1420
1421 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1422
14232012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1424
1425 Fix crash when creating indirect buffer (Bug#11917)
1426 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1427 Don't handle unbound variables specially if non-zero.
1428 (Fbuffer_local_variables): Pass zero.
1429 (clone_per_buffer_values): Pass non-zero.
1430
14312012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1432
1433 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1434 to make the loop interruptible.
1435
14362012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1437
1438 * gnutls.c (emacs_gnutls_handshake): Only retry if
1439 GNUTLS_E_INTERRUPTED.
1440
cce7fefc
DA
14412012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1442
1443 Cleanup and convert miscellaneous checks to eassert.
1444 * alloc.c (mark_interval): Fix comment, partially rephrase
1445 old comment from intervals.h (see below).
1446 * intervals.c (find_interval, adjust_intervals_for_insertion)
1447 (delete_interval, adjust_intervals_for_deletion)
1448 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1449 Convert to eassert.
1450 (adjust_intervals_for_insertion, make_new_interval):
1451 Remove obsolete and unused code.
1452 * intervals.h (struct interval): Remove obsolete comment.
1453 * textprotp.c (erase_properties): Remove unused code.
1454 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1455 (Fremove_list_of_text_properties): Convert to eassert.
1456
9ea10cc3
CY
14572012-07-17 Chong Yidong <cyd@gnu.org>
1458
1459 * editfns.c (Finsert_char): Doc fix.
1460
3900d5de
DA
14612012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1462
1463 Fix previous change to make Fmemory_free always accurate.
1464 * alloc.c (make_interval): Update total_free_intervals.
1465 (make_float): Likewise for total_free_floats.
1466 (free_cons, Fcons): Likewise for total_free_conses.
1467 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1468 Likewise for total_free_vector_bytes.
1469 (Fmake_symbol): Likewise for total_free_symbols.
1470 (bytes_free): Remove.
1471
7098646f
DA
14722012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1473
1474 Simple free memory accounting feature.
1475 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1476 (sweep_vectors): Accumulate size of free vectors.
1477 (Fgarbage_collect): Setup bytes_free.
1478 (Fmemory_free): New function.
1479 (syms_of_alloc): Register it.
1480
22657b40
DA
14812012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1482
1483 Cleanup overlays checking.
1484 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1485 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1486 eassert and OVERLAYP.
1487 (sort_overlays): Change to use OVERLAYP.
1488
ddfc8813
RK
14892012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1490
1491 * editfns.c (Finsert_char): Make it interactive, and make the
1492 second arg optional. Copy interactive spec and docstring from
1493 ucs-insert.
1494
7c26cf3c
PE
14952012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1496
1497 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1498 Unlike the other wrapped functions, fabs has an unspecified
1499 effect on errno.
1500
5d127af9
JD
15012012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1502
1503 * nsterm.m (keyDown): Interpret flags without left/right bits
1504 as the left key (Bug#11670).
1505
6a0dd1d7
DA
15062012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1507
1508 Remove empty and useless init functions.
1509 * lisp.h (init_character_once, init_fns, init_image)
1510 (init_filelock, init_sound): Remove prototype.
1511 * character.c (init_character_once): Remove.
1512 * filelock.c (init_filelock): Likewise.
1513 * fns.c (init_fns): Likewise.
1514 * image.c (init_image): Likewise.
1515 * sound.c (init_sound): Likewise.
1516 * emacs.c (main): Adjust accordingly.
1517
7a6136fd
DA
15182012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1519
1520 * gtkutil.h: Tiny cleanups.
1521 (use_old_gtk_file_dialog): Remove useless declaration.
1522 (xg_uses_old_file_dialog): Add suggested const attribute.
1523
ce811ad9
EZ
15242012-07-15 Eli Zaretskii <eliz@gnu.org>
1525
1526 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1527 (bidi_paragraph_init): Use it to limit search forward for a strong
1528 directional character in abnormally large paragraphs full of
1529 neutral or weak characters. (Bug#11943)
1530
c9adfeaa
SF
15312012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1532
1533 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1534 the toolbar (Bug#9451).
1535 (xg_make_tool_item): Give the widget event box a transparent
1536 background.
1537
fff62aa9
DA
15382012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1539
1540 Cleanup basic allocation variables and functions.
1541 * alloc.c (ignore_warnings, init_intervals, init_float)
1542 (init_cons, init_symbol, init_marker): Remove.
1543 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1544 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1545 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1546 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1547 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1548 (staticidx, init_alloc_once, init_strings, free_ablock):
1549 Remove redundant initialization.
1550 * fns.c (init_weak_hash_tables): Remove.
1551 * lisp.h (init_weak_hash_tables): Remove prototype.
1552
9730daca
DA
15532012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1554
1555 Use zero_vector where appropriate.
1556 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1557 accordingly.
1558 * lisp.h (zero_vector): New declaration.
1559 * font.c (null_vector): Remove.
1560 (syms_of_font): Remove initialization and staticpro.
1561 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1562 * keymap.c (Faccessible_keymaps): Likewise.
1563
2e2d2a13
LL
15642012-07-15 Leo Liu <sdl.web@gmail.com>
1565
1566 * fringe.c: Fix typo in comments.
1567
cd276f6e
LL
15682012-07-14 Leo Liu <sdl.web@gmail.com>
1569
1570 * fringe.c: Add a new bitmap exclamation-mark.
1571
5a1131d9
EZ
15722012-07-14 Eli Zaretskii <eliz@gnu.org>
1573
1574 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1575
1576 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1577 (HAVE_MENUS): Don't define, defined by editing config.in with
1578 msdos/sed2v2.inp.
1579 (GMALLOC_INHIBIT_VALLOC): Don't define.
1580 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1581
22e983b7
JB
15822012-07-14 Juanma Barranquero <lekktu@gmail.com>
1583
1584 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1585
5b3f250f
GM
15862012-07-14 Glenn Morris <rgm@gnu.org>
1587
1588 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1589 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1590 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1591
33d63ff4
GM
15922012-07-13 Glenn Morris <rgm@gnu.org>
1593
5b633342
GM
1594 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1595
33d63ff4
GM
1596 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1597 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1598
b55b9f85
JD
15992012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1600
0dc8cf50
JD
1601 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1602 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1603 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1604 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1605 where appropriate.
1606 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1607 as boolean expression.
1608 (x_set_window_size): Remove unused variable toolbar.
1609 (ns_get_color_default, ns_mod_to_lisp): Remove.
1610 (ns_mouse_position): Remove unused variables xchar and ychar.
1611 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1612 (ns_set_vertical_scroll_bar): Remove unused variable count.
1613 (ns_delete_terminal): Remove unused variable i.
1614 (ns_term_init): Remove unused variables r, g and b.
1615 (mouseDown): Remove unused variable window.
1616 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1617 (initFrameFromEmacs): Remove unused variable vbextra.
1618 (mouseEntered): Remove unused variables p and dpyinfo.
1619 (mouseExited): Remove unused variables p and r.
1620 (ns_define_frame_cursor, ns_clear_frame_area)
1621 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1622 (menuDown): Assign [sender tag] to variable and cast the variable.
1623
1624 * nsterm.h (menuDown): Add id as type to argument sender.
1625 (ns_display_info_for_name): Add Lisp_Object argument.
1626 (ns_term_init): Add Lisp_Object argument.
1627 (ns_map_event_to_object): Add void argument.
1628 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1629 prototype with arguments and only declare if __OBJC__.
1630 (nxatoms_of_nsselect): Add void argument.
1631 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1632 (ns_alloc_autorelease_pool): Add void argument.
1633 (ns_release_autorelease_pool): Add void* argument.
1634 (ns_get_defaults_value): Add const char* argument.
1635
1636 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1637 (initFromContents): Use SSDATA where appropriate.
1638 (ns_update_menubar): Add braces to ambigous if-else.
1639 (initWithTitle): Put () around assignment in if statement.
1640 (ns_menu_show): Remove unused variables window and keymap.
1641 (update_frame_tool_bar): Remove unused variable selected_p.
1642 (initWithContentRect): Remove unused variable this_cmd_name.
1643
1644 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1645 appropriate.
1646 (setXBMColor): Remove unused variable len.
1647 (setPixmapData): Put () around assignment in loop statement.
1648
1649 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1650 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1651 where appropriate.
1652 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1653 around assignment in loop statement.
1654 (nsfont_open): Remove unused variable i.
1655 (nsfont_open): Remove unused variable len.
1656 (nsfont_draw): Remove unused variable cs.
1657
1658 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1659 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1660 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1661 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1662 (Fns_font_name, Fns_perform_service)
1663 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1664 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1665 (ns_set_name): Remove unused variable view.
1666 (x_set_menu_bar_lines): Remove unused variable olines.
1667 (x_set_tool_bar_lines): Remove unused variable root_window.
1668 (Fns_list_colors): Put () around assignment in while statement.
1669 (Fns_perform_service): Remove unused variable len.
1670 (Fns_display_usable_bounds): Remove unused variable top.
1671 (syms_of_nsfns): Remove unused variable i.
1672
b55b9f85
JD
1673 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1674 memcpy (Bug#11907).
1675
ed9265fc 16762012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1677
1678 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1679 and free it with DestroyExceptionInfo (Bug#11558).
1680
ef099b57
JB
16812012-07-13 Juanma Barranquero <lekktu@gmail.com>
1682
1683 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1684 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1685 Set here, not in nt/config.nt.
1686
ea814a5d
EZ
16872012-07-13 Eli Zaretskii <eliz@gnu.org>
1688
1689 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1690 cursor overflow into the last glyph on display line when the right
1691 fringe is off. (Bug#11832)
1692
1a952767
PE
16932012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1694
1695 * xdisp.c (produce_special_glyphs): Now static.
1696 * dispextern.h (produce_special_glyphs): Remove decl.
1697
983188fd
GM
16982012-07-13 Glenn Morris <rgm@gnu.org>
1699
8d7c7eed 1700 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1701 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1702
983188fd
GM
1703 * s/usg5-4-common.h (USG, USG5):
1704 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1705 * s/sol2-6.h (SOLARIS2):
1706 * s/irix6-5.h (IRIX6_5):
1707 * s/hpux10-20.h (USG, USG5, HPUX):
1708 * s/gnu-linux.h (USG, GNU_LINUX):
1709 * s/freebsd.h (BSD_SYSTEM):
1710 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1711 * s/cygwin.h (CYGWIN):
1712 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1713 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1714
d1e68667 17152012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1716
1717 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1718
6de0e799
GM
17192012-07-13 Glenn Morris <rgm@gnu.org>
1720
739ae010
GM
1721 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1722
dbee5793
GM
1723 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1724
6de0e799
GM
1725 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1726 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1727
b82da769
GM
17282012-07-12 Glenn Morris <rgm@gnu.org>
1729
4fae5a7a 1730 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1731
1732 * process.c (init_process_emacs): Rename from init_process.
1733 The old name is also the name of a Mach system call.
1734 * lisp.h, emacs.c: Update for this name change.
1735 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1736 longer needed.
1737
5a979817
EZ
17382012-07-12 Eli Zaretskii <eliz@gnu.org>
1739
1740 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1741 memmove call that removes glyphs covered by the left truncation
1742 glyph. Improve commentary.
1743 (display_line): Fix display of continuation glyphs on GUI frames
1744 when the right fringe is turned off and variable-size fonts are
1745 used in the window. Move the code that appends a stretch glyph to
1746 produce_special_glyphs, so that it could be used for truncation
1747 and continuation glyphs alike.
1748 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1749 glyph of a suitably computed width, to align the special glyphs at
1750 the window margin. Code moved from display_line. (Bug#11832)
1751
3e91a053
GM
17522012-07-12 Glenn Morris <rgm@gnu.org>
1753
ba9e4b84
GM
1754 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1755
1756 * s/gnu-linux.h, s/hpux10-20.h:
1757 Do not unconditionally define HAVE_XRMSETDATABASE.
1758
3e91a053
GM
1759 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1760
b300b1f4
PE
17612012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 Fix typos that broke OS X build.
1764 Reported by Randal L. Schwartz in
1765 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1766 * nsterm.m (ns_timeout): Add missing local decl.
1767 (ns_get_color): snprintf -> sprintf, to fix typo.
1768
6e777848
GM
17692012-07-12 Glenn Morris <rgm@gnu.org>
1770
3f922c37
GM
1771 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1772 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1773 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1774 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1775
0ab7b23a
GM
1776 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1777 Move PTY_OPEN to configure.
1778
6e777848
GM
1779 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1780 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1781 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1782
4a7edc24
DA
17832012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1784
1785 Use empty_unibyte_string where applicable.
1786 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1787 * lread.c (read1): Likewise.
1788 * xsettings.c (syms_of_xsettings): Likewise.
1789
308aab79
GM
17902012-07-12 Glenn Morris <rgm@gnu.org>
1791
42bd1719
GM
1792 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1793 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1794 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1795 * s/hpux10-20.h (RUN_TIME_REMAP):
1796 * s/bsd-common.h (TABDLY): Move to configure.
1797
1798 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1799
1800 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1801
ea0bbd17 1802 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1803 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1804
1805 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1806
308aab79
GM
1807 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1808 * s/template.h: Move NARROWPROTO to configure.
1809
ee1cf5cf
GM
18102012-07-11 Glenn Morris <rgm@gnu.org>
1811
30fe9bf4
GM
1812 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1813 unused since 2011-01-17 change to systty.h.
1814
ee1cf5cf
GM
1815 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1816 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1817 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1818
63e47e07
PE
18192012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1820
1821 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1822
c43fb4c3
GM
18232012-07-11 Glenn Morris <rgm@gnu.org>
1824
1825 * s/darwin.h, s/gnu-linux.h, s/template.h:
1826 Move INTERRUPT_INPUT to configure.
1827
e8df9267
DA
18282012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1829
1830 Minor adjustments to interning code.
1831 * lisp.h (intern, intern_c_string): Redefine as static inline
1832 wrappers for intern_1 and intern_c_string_1, respectively.
1833 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
1834 * lread.c (intern_1, intern_c_string_1, oblookup):
1835 Simplify Vobarray checking.
e8df9267
DA
1836 * font.c (font_intern_prop): Likewise. Adjust comment.
1837 * w32font.c (intern_font_name): Likewise.
1838
34348bd4
AS
18392012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1840
d96a1e0c
AS
1841 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1842
34348bd4
AS
1843 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1844 of Fcar/Fcdr if possible.
1845 * font.c (check_otf_features): Likewise.
1846 * fontset.c (Fnew_fontset): Likewise.
1847 * gnutls.c (Fgnutls_boot): Likewise.
1848 * minibuf.c (read_minibuf): Likewise.
1849 * msdos.c (IT_set_frame_parameters): Likewise.
1850 * xmenu.c (Fx_popup_dialog): Likewise.
1851 * w32menu.c (Fx_popup_dialog): Likewise.
1852
c8add24e
GM
18532012-07-11 Glenn Morris <rgm@gnu.org>
1854
4b575b3c
GM
1855 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1856 since nothing has defined it on these platforms.
1857
09f4e3b0
GM
1858 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1859 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1860
172bedef
GM
1861 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1862 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1863 Move CLASH_DETECTION to configure.
1864
249685df
GM
1865 * s/gnu.h: Remove file, which is now empty.
1866
c8add24e
GM
1867 * s/gnu.h, s/gnu-linux.h:
1868 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1869
b41253a3
JW
18702012-07-11 John Wiegley <johnw@newartisans.com>
1871
1872 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1873 function attribute, so we only use it if it exists in the
1874 compiler.
1875
d923b542
DA
18762012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1877
1878 Avoid call to strlen in fast_c_string_match_ignore_case.
1879 * search.c (fast_c_string_match_ignore_case): Change to use
1880 length argument. Adjust users accordingly.
1881 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1882
5ebbef1d
PE
18832012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1884
bb352260
PE
1885 Assume mkdir, rmdir.
1886 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1887 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1888
57054ddd
PE
1889 Assume rename.
1890 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1891
b747d3f7
PE
1892 Assume perror.
1893 * s/hpux10-20.h (HAVE_PERROR): Remove.
1894 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1895 Remove dummy definition, as this problem was obsolete long ago.
1896
5ebbef1d
PE
1897 Assume strerror.
1898 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1899
984e7f30
DA
19002012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1901
1902 Avoid calls to strlen in font processing functions.
1903 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
1904 (font_open_by_name): Change to use length argument.
1905 Adjust users accordingly.
d923b542
DA
1906 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1907 Adjust prototypes.
1908 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1909 Change to return ptrdiff_t.
984e7f30
DA
1910 (xfont_list_pattern, xfont_match): Use length returned by
1911 xfont_decode_coding_xlfd.
1912 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1913
20e94fdd
GM
19142012-07-11 Glenn Morris <rgm@gnu.org>
1915
9d596af3
GM
1916 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1917 Move DONT_REOPEN_PTY to configure.
1918
20e94fdd
GM
1919 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1920 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1921
e99a530f
PE
19222012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1923
22ffb973
PE
1924 Remove "#define unix" that is no longer needed (Bug#11905).
1925 * s/aix4-2.h (unix): Remove; no longer needed.
1926
e9a9ae03
PE
1927 EMACS_TIME simplification (Bug#11875).
1928 This replaces macros (which typically do not work in GDB)
1929 with functions, typedefs and enums, making the code easier to debug.
1930 The functional style also makes code easier to read and maintain.
1931 * systime.h: Include <sys/time.h> on all hosts, not just if
1932 WINDOWSNT, since 'struct timeval' is needed in general.
1933 (EMACS_TIME): Now a typedef, not a macro.
1934 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1935 not macros.
1936 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1937 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1938 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1939 (EMACS_TIME_LE): Now functions, not macros.
1940 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1941 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1942 which are not functions. All uses rewritten to use:
1943 (make_emacs_time): New function.
1944 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1945 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1946 not functions. All uses rewritten to use the following, respectively:
1947 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1948 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1949 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1950 * fileio.c (Fcopy_file):
1951 * xterm.c (XTflash): Get the current time closer to when it's used.
1952 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1953
ffacb126
PE
1954 * bytecode.c (targets): Suppress -Woverride-init warnings.
1955
e99a530f
PE
1956 Simplify by avoiding confusing use of strncpy etc.
1957 * doc.c (Fsnarf_documentation):
1958 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1959 * frame.c (Fmake_terminal_frame):
1960 * gtkutil.c (get_utf8_string):
1961 * lread.c (openp):
1962 * nsmenu.m (ns_update_menubar):
1963 * regex.c (regerror):
1964 Prefer memcpy to strncpy and strncat when either will do.
1965 * fileio.c (Fsubstitute_in_file_name):
1966 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1967 (menu_separator_name_p):
1968 * nsmenu.m (ns_update_menubar):
1969 Prefer memcmp to strncmp when either will do.
1970 * nsterm.m: Include <ftoastr.h>.
1971 (ns_get_color):
1972 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1973 Prefer snprintf to strncpy.
1974 * nsterm.m (ns_term_init):
1975 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1976 * nsterm.m (ns_term_init):
1977 Avoid the need for strncpy, by using build_string or
1978 make_unibyte_string directly. Use dtoastr, not snprintf.
1979 * process.c (Fmake_network_process): Diagnose service names that
1980 are too long, rather than silently truncating them or creating
1981 non-null-terminated names.
1982 (Fnetwork_interface_info): Likewise, for interface names.
1983 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1984 Prefer sprintf to strncat.
1985 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1986 Prefer vsnprintf to vsprintf + strncpy.
1987
c59592b3
GM
19882012-07-10 Glenn Morris <rgm@gnu.org>
1989
1990 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1991 Clarify fallback case.
1992
7d7bbefd
DA
19932012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1994
1995 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1996 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1997 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1998 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1999 where argument type is known to be a Lisp_Cons.
2000
3a4c8000
TT
20012012-07-10 Tom Tromey <tromey@redhat.com>
2002
2003 * bytecode.c (BYTE_CODE_THREADED): New macro.
2004 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2005 (enum byte_code_op): New type.
2006 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2007 (exec_byte_code): Use them. Use token threading when applicable.
2008
2a0213a6
DA
20092012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2010
2011 Optimize pure C strings initialization.
2012 * lisp.h (make_pure_string): Fix prototype.
2013 (build_pure_c_string): New function, defined as static inline. This
2014 provides a better opportunity to optimize away calls to strlen when
2015 the function is called with compile-time constant argument.
2016 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2017 argument, adjust users accordingly. Use build_pure_c_string where
2018 appropriate.
2019 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2020 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2021 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2022
cb1caeaf
DA
20232012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2024
2025 Avoid calls to strlen in miscellaneous functions.
2026 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2027 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2028 * lread.c (openp): Likewise.
2029
c293e30c
DA
20302012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2031
2032 Avoid calls to strlen in path processing functions.
2033 * fileio.c (file_name_as_directory): Add comment. Change to add
2034 srclen argument and return the length of result. Adjust users
2035 accordingly.
2036 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2037 swap 1st and 2nd arguments to obey the common convention.
2038 Adjust users accordingly.
c293e30c
DA
2039 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2040
9e059e3f
GM
20412012-07-10 Glenn Morris <rgm@gnu.org>
2042
d02eb359
GM
2043 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2044 Move PENDING_OUTPUT_COUNT definition to configure.
2045
882cf227
GM
2046 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2047 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2048 * s/gnu.h (DATA_START): Move definitions to configure.
2049
af6e839f
GM
2050 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2051 We include usg5-4-common.h, which defines them both.
2052
40289a12
GM
2053 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2054 O_RDONLY already includes it).
2055
9e059e3f
GM
2056 Stop ns builds setting the EMACSLOADPATH environment variable.
2057 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2058 Now it does not set EMACSLOADPATH, just returns the load-path string.
2059 * nsterm.h: Update accordingly.
2060 * lread.c [HAVE_NS]: Include nsterm.h.
2061 (init_lread) [HAVE_NS]: Use ns_load_path.
2062 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2063
7c4e8ec0
GM
20642012-07-09 Glenn Morris <rgm@gnu.org>
2065
d4f600ff
GM
2066 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2067 since the included bsd-common.h does so.
2068
cbb31951
GM
2069 Stop ns builds setting the EMACSPATH environment variable.
2070 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2071 (ns_init_paths): Do not set EMACSPATH.
2072 * nsterm.h (ns_exec_path): Add it.
2073 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2074 Use ns_exec_path.
2075
7c4e8ec0
GM
2076 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2077
26bccfae
PE
20782012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2079
a0bee46f
PE
2080 * process.c (wait_reading_process_output): 'waitchannels' was unset
2081 when read_kbd || !NILP (wait_for_cell); fix this.
2082
5994c183
PE
2083 Add GCC-style 'const' attribute to functions that can use it.
2084 * character.h (char_resolve_modifier_mask):
2085 * keyboard.h (make_ctrl_char):
2086 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2087 (init_character_once, next_almost_prime, init_fns, init_image)
2088 (flush_pending_output, init_sound):
2089 * mem-limits.h (start_of_data):
2090 * menu.h (finish_menu_items):
2091 Add ATTRIBUTE_CONST.
2092 * emacs.c (DEFINE_DUMMY_FUNCTION):
2093 Declare the dummy function with ATTRIBUTE_CONST.
2094 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2095 Add decls with ATTRIBUTE_CONST.
2096
26bccfae
PE
2097 Minor improvements to make_formatted_string.
2098 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2099 where int is good enough, as vsprintf returns an int.
2100 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2101
a8290ec3
DA
21022012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2103
2104 Use make_formatted_string to avoid double length calculation.
2105 * lisp.h (make_formatted_string): New prototype.
2106 * alloc.c (make_formatted_string): New function.
2107 * buffer.c (Fgenerate_new_buffer_name): Use it.
2108 * dbus.c (syms_of_dbusbind): Likewise.
2109 * editfns.c (Fcurrent_time_zone): Likewise.
2110 * filelock.c (get_boot_time): Likewise.
2111 * frame.c (make_terminal_frame, set_term_frame_name)
2112 (x_report_frame_params): Likewise.
2113 * image.c (gs_load): Likewise.
2114 * minibuf.c (get_minibuffer): Likewise.
2115 * msdos.c (dos_set_window_size): Likewise.
2116 * process.c (make_process): Likewise.
2117 * xdisp.c (ensure_echo_area_buffers): Likewise.
2118 * xsettings.c (apply_xft_settings): Likewise.
2119
d01ba2f1
GM
21202012-07-09 Glenn Morris <rgm@gnu.org>
2121
2122 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2123 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2124 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2125 * nsterm.h (ns_etc_directory): Add it.
2126 * callproc.c [HAVE_NS]: Include nsterm.h.
2127 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2128
f1f924b6
DA
21292012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2130
2131 Move marker debugging code under MARKER_DEBUG.
2132 * marker.c (MARKER_DEBUG): Move marker debugging code under
2133 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2134 for bootstrap with --enable-checking (~3x slowdown reported
2135 by Juanma Barranquero <lekktu@gmail.com>).
2136 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2137
ab531b66
PE
21382012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2141 See <http://bugs.gnu.org/11825#29>.
2142
c4b3bc8a
EZ
21432012-07-08 Eli Zaretskii <eliz@gnu.org>
2144
2145 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2146 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2147 (display_line): Add commentary about displaying truncation glyphs
2148 on GUI frames.
2149 (produce_special_glyphs): Move here from term.c.
2150
2151 * term.c (produce_special_glyphs): Move to xdisp.c.
2152
2153 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2154 section.
c4b3bc8a 2155
b676b881
AS
21562012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2157
f17c5273
AS
2158 * xdisp.c (display_line): Avoid warning about implicit declaration
2159 of FRAME_FONT.
2160
298819b9
AS
2161 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2162
b676b881
AS
2163 * lisp.h: Remove empty conditional.
2164
6045c4fd
PE
21652012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2166
b3350bf9
PE
2167 * lread.c (load_path_check): Now static.
2168
6045c4fd
PE
2169 Fix some minor --with-ns problems found by static checking.
2170 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2171 (x_set_font) [!HAVE_X_WINDOWS]:
2172 * image.c (xpm_load_image) [HAVE_NS]:
2173 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2174 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2175 Remove unused local.
2176 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2177 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2178 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2179 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2180 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2181 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2182 Fix pointer signedness problem.
2183 * xfaces.c (FRAME_X_FONT_TABLE):
2184 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2185
929e7845
GM
21862012-07-07 Glenn Morris <rgm@gnu.org>
2187
2188 * lread.c (load_path_check): New function, split from init_lread.
2189 (init_lread): Reorganize. Motivation:
2190 If EMACSLOADPATH is set, check/warn about that rather than the
2191 defaults, which we are not going to use. Hence we can remove
2192 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2193 Don't warn if site-lisp directories are missing.
2194 If not installed, start from a blank load-path, since
2195 PATH_LOADSEARCH refers to the eventual installation directories.
2196
58dd0aa4
EZ
21972012-07-07 Eli Zaretskii <eliz@gnu.org>
2198
2199 Support truncation and continuation glyphs on GUI frames, when
2200 fringes are disabled. (Bug#11832)
2201 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2202 continuation glyphs even if on GUI frames.
2203 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2204 or both, are absent.
2205 (start_display, move_it_in_display_line_to): Handle the case of a
2206 GUI frame without a fringe to display continuation or truncation
2207 glyphs.
2208 (insert_left_trunc_glyphs): Support GUI frames: make sure
2209 truncation glyphs overwrite enough glyphs from the current line to
2210 have sufficient space in pixels.
2211 (display_line): Support truncation and continuation glyphs on GUI
2212 frames. If some spare pixels are left on the line after inserting
2213 the truncation glyphs, fill that space with a stretch glyph of a
2214 suitably computed width.
2215
2216 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2217 produce_glyphs, to support GUI sessions.
2218
31571fd7
PE
22192012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2220
5a16b9bc
PE
2221 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2222
f3047c75
PE
2223 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2224
31571fd7
PE
2225 Do not require float-time's arg to fit in time_t (Bug#11825).
2226 This works better on hosts where time_t is unsigned, and where
2227 float-time is applied to the (negative) difference between two times.
2228 * editfns.c (decode_time_components): Last arg is now double *,
2229 not int *, and means to store all the result as a double, without
2230 worrying about whether the seconds part fits in time_t.
2231 All callers changed.
2232 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2233 All callers changed.
2234 (Ffloat_time): Do not fail merely because the specified time falls
2235 outside of time_t range.
2236
4516fbef
GM
22372012-07-07 Glenn Morris <rgm@gnu.org>
2238
2239 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2240 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2241 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2242
07adc2c6
JB
22432012-07-07 Juanma Barranquero <lekktu@gmail.com>
2244
2245 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2246 Update dependencies.
2247
2248 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2249
fd573f31
PE
22502012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2251
fee5959d
PE
2252 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2253 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2254 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2255 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2256 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2257 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2258
fd573f31
PE
2259 * xfont.c (compare_font_names): Redo to omit the need for casts.
2260
ddadbc0e
AS
22612012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2262
fca8d6b6
AS
2263 * xfns.c (Fx_change_window_property): Doc fix.
2264 * w32fns.c (Fx_change_window_property): Doc fix.
2265
ddadbc0e
AS
2266 * w32fns.c (Fx_window_property): Accept the same arguments as the
2267 X Windows version. Doc fix.
2268 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2269
ed9265fc 22702012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2271 Eli Zaretskii <eliz@gnu.org>
2272
2273 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2274 Windows-specific code from nt/config.nt moved here.
2275 Obsolete settings removed.
2276
216ee680
PE
22772012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 * process.c: Avoid unnecessary calls to gettime.
2280 (wait_reading_process_output): Don't get the time of day
2281 when gobbling data immediately and not waiting, as there's no need
2282 for it in that case. This removes a FIXME.
2283
bdd091e4
JD
22842012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2285
2286 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2287 is defined (Bug#11768).
2288
9d44f8ce
DA
22892012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2290
2291 Fix marker debugging code.
2292 * marker.c (byte_char_debug_check): Do not perform the check
2293 if buffer is not multibyte.
090bd7cb
JB
2294 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2295 Call byte_char_debug_check with correct arguments.
9d44f8ce 2296
90fc4786
DA
22972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2298
2299 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2300 * marker.c (byte_char_debug_check, count_markers):
2301 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2302 (byte_debug_flag): Remove.
2303 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2304 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2305
7b7ae965
DA
23062012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2307
4e57b342
DA
2308 Avoid code repetition in marker-related functions.
2309 * marker.c (attach_marker): New function.
2310 (Fset_marker, set_marker_restricted, set_marker_both)
2311 (set_marker_restricted_both): Use it.
2312 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2313 Consistently rename charno to charpos.
2314 (marker_position): Add eassert.
2315 (marker_byte_position): Convert to eassert.
2316
23172012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2318
2319 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2320 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2321 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2322
657924ff
DA
23232012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2324
2325 Introduce fast path for the widely used marker operation.
2326 * alloc.c (build_marker): New function.
2327 * lisp.h (build_marker): New prototype.
2328 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2329 * composite.c (autocmp_chars): Likewise.
2330 * editfns.c (buildmark): Remove.
2331 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2332 (save_restriction_save): Use build_marker.
2333 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2334 * window.c (save_window_save): Likewise.
2335
041a49a6
DA
23362012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2337
2338 Do not use Fdelete_overlay in delete_all_overlays
2339 to avoid redundant calls to unchain_overlay.
2340 * buffer.c (drop_overlay): New function.
2341 (delete_all_overlays, Fdelete_overlay): Use it.
2342 * minibuf.c (get_minibuffer): Fix comment.
2343
7dca65a4
PE
23442012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2345
2346 Port to OpenBSD 5.1 amd64.
2347 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2348 This is needed for OpenBSD, and should be harmless on all BSD systems.
2349 Also, include <sys/sysctl.h>, as it should be available on all
2350 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2351 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2352 use p_pid member, not kp_proc.pid.
2353
8eb876e2
GM
23542012-07-06 Glenn Morris <rgm@gnu.org>
2355
2356 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2357
38182d90
PE
23582012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2359
2360 More xmalloc and related cleanup.
2361 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2362 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2363 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2364 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2365 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2366 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2367 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2368 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2369 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2370 * xterm.c:
2371 Omit needless casts involving void * pointers and allocation.
2372 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2373 as the former is more robust if P's type is changed.
2374 Prefer xzalloc to xmalloc + memset 0.
2375 Simplify malloc-or-realloc to realloc.
2376 Don't worry about xmalloc returning a null pointer.
2377 Prefer xstrdup to xmalloc + strcpy.
2378 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2379 growing it.
2380 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2381 alloca of a constant.
2382
6dd5a677
EZ
23832012-07-05 Eli Zaretskii <eliz@gnu.org>
2384
2385 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2386 hscroll is larger than the line width. Fixes long and futile
2387 looping inside extend_face_to_end_of_line (on a TTY) producing
2388 glyphs that are not needed and thrown away.
2389
6b312f0f
DA
23902012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2391
2392 * marker.c (set_marker_restricted_both): Simplify by using
2393 clip_to_bounds.
2394
f520ef9b
PE
23952012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2396
2397 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2398
383b7c95
JD
23992012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2400
2401 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2402 not defined (Bug#11768).
2403 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2404 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2405 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2406 followed by gtk_box_set_homogeneous (Bug#11768).
2407 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2408 (update_theme_scrollbar_width, xg_create_scroll_bar):
2409 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2410 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2411 (is_box_type): New function (Bug#11768).
2412 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2413 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2414 with default display (Bug#11768).
2415
d6e7bf45
EZ
24162012-07-05 Eli Zaretskii <eliz@gnu.org>
2417
2418 * xdisp.c (window_hscroll_limited): New function.
2419 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2420 coordinates when window's hscroll is set to insanely large
2421 values. (Bug#11857)
2422
431391ec
JB
24232012-07-05 Juanma Barranquero <lekktu@gmail.com>
2424
2425 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2426 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2427
23f86fce
DA
24282012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2429
2430 Cleanup xmalloc.
2431 * lisp.h (xzalloc): New prototype. Omit needless casts.
2432 * alloc.c (xzalloc): New function. Omit needless casts.
2433 * charset.c: Omit needless casts. Convert all calls to
2434 xmalloc with following memset to xzalloc.
2435 * dispnew.c: Likewise.
2436 * fringe.c: Likewise.
2437 * image.c: Likewise.
2438 * sound.c: Likewise.
2439 * term.c: Likewise.
2440 * w32fns.c: Likewise.
2441 * w32font.c: Likewise.
2442 * w32term.c: Likewise.
2443 * xfaces.c: Likewise.
2444 * xfns.c: Likewise.
2445 * xterm.c: Likewise.
2446 * atimer.c: Omit needless casts.
2447 * buffer.c: Likewise.
2448 * callproc.c: Likewise.
2449 * ccl.c: Likewise.
2450 * coding.c: Likewise.
2451 * composite.c: Likewise.
2452 * doc.c: Likewise.
2453 * doprnt.c: Likewise.
2454 * editfns.c: Likewise.
2455 * emacs.c: Likewise.
2456 * eval.c: Likewise.
2457 * filelock.c: Likewise.
2458 * fns.c: Likewise.
2459 * gtkutil.c: Likewise.
2460 * keyboard.c: Likewise.
2461 * lisp.h: Likewise.
2462 * lread.c: Likewise.
2463 * minibuf.c: Likewise.
2464 * msdos.c: Likewise.
2465 * print.c: Likewise.
2466 * process.c: Likewise.
2467 * region-cache.c: Likewise.
2468 * search.c: Likewise.
2469 * sysdep.c: Likewise.
2470 * termcap.c: Likewise.
2471 * terminal.c: Likewise.
2472 * tparam.c: Likewise.
2473 * w16select.c: Likewise.
2474 * w32.c: Likewise.
2475 * w32reg.c: Likewise.
2476 * w32select.c: Likewise.
2477 * w32uniscribe.c: Likewise.
2478 * widget.c: Likewise.
2479 * xdisp.c: Likewise.
2480 * xmenu.c: Likewise.
2481 * xrdb.c: Likewise.
2482 * xselect.c: Likewise.
2483
0497dc44
PE
24842012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2485
2486 * fileio.c (time_error_value): Check the right error number.
2487 Problem reported by Troels Nielsen in
2488 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2489
356e7178
PE
24902012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2491
4e71fd89
PE
2492 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2493 This should be fixed in a better way; see Eli Zaretskii in
2494 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2495 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2496
f0941253
PE
2497 * fileio.c (time_error_value): Rename from special_mtime.
2498 The old name's problems were noted by Eli Zaretskii in
2499 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2500
065c9eb4
PE
2501 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2502 This variable's comment says Emacs needs at least one GDB-visible
2503 symbol of type enum pvec_type, to work around GDB problems.
2504 The symbol's value doesn't matter.
2505
356e7178
PE
2506 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2507 that causes compilation to fail on pre-C99 compilers.
2508
ed9265fc 25092012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2510
2511 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2512 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2513
3884d954
DA
25142012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2515
d209e2fb 2516 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2517 headers for buffer_defaults and buffer_local_symbols.
2518 Reported by Juanma Barranquero <lekktu@gmail.com>.
2519
ee28be33
SM
25202012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2521
2522 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2523 * lisp.h (enum pvec_type): Use fewer bits.
2524 (PSEUDOVECTOR_SIZE_BITS): New constant.
2525 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2526 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2527 change in pvec_type.
2528 (PSEUDOVECTOR_TYPEP): New macro.
2529 (TYPED_PSEUDOVECTORP): Use it.
2530 * fns.c (internal_equal): Adapt code to extract pvectype.
2531 * emacs.c (gdb_pvec_type): Update type.
2532 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2533 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2534 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2535 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2536 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2537 abusing vector->header.next.nbytes.
2538 (live_vector_p): Use PVEC_TYPE.
2539 (mark_object): Adapt code to extract pvectype. Use switch.
2540
c7f2cd7f
PE
25412012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2542
2543 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2544 Tighten new eassert a bit.
2545
8ce70ed2
DA
25462012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2547
2548 Fix compilation with --enable-gcc-warnings and -O1
2549 optimization level.
2550 * doprnt.c (doprnt): Change type of tem to int, initialize
2551 to avoid compiler warning. Add eassert.
2552 * search.c (simple_search): Initialize match_byte to avoid
2553 compiler warning. Add eassert.
2554
dea7f1e5
PE
25552012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2556
24a212eb
PE
2557 Avoid weird behavior with large horizontal scrolls.
2558 Without this change, for example, large hscroll values would
2559 mess up Emacs's display on Fedora 15 x86, presumably due to
2560 overflows in int calculations in the display code.
2561 Also, if buffers had long lines, Emacs would freeze.
2562 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2563 (set_window_hscroll): New function, containing the old guts of
2564 Fset_window_hscroll. Return the clipped value.
2565 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2566 This avoids the need to check against PTRDIFF_MAX.
2567
dea7f1e5
PE
2568 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2569
76046526
DA
25702012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2571
2572 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2573
39adff0d
PE
25742012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2575
63807d47
PE
2576 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2577 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2578 since GCC 4.4.6 issues a bogus warning for them.
2579
39adff0d
PE
2580 Fix bugs in file timestamp newness comparisons.
2581 * fileio.c (Ffile_newer_than_file_p):
2582 * lread.c (Fload): Use full timestamp resolution of files,
2583 not just the 1-second resolution, so that files that are only
2584 slightly newer still count as newer.
2585 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2586 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2587
dbeed9a6
PE
25882012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2589
2590 * fileio.c: Improve handling of file time marker. (Bug#11852)
2591 (special_mtime): New function.
2592 (Finsert_file_contents, Fverify_visited_file_modtime):
2593 Use it to set special mtime values consistently.
2594
636334d6
AS
25952012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2596
2597 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2598 marker for non-existing file. (Bug#11852)
2599
e2017fe2
GM
26002012-07-03 Glenn Morris <rgm@gnu.org>
2601
2602 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2603 and did not make it into globals.h).
2604
404dbd37
TT
26052012-07-03 Tom Tromey <tromey@redhat.com>
2606
2607 * window.c (Fset_window_margins, Fset_window_fringes)
2608 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2609 * textprop.c (Fprevious_property_change): No longer static.
2610 * syntax.c (Fsyntax_table_p): No longer static.
2611 * process.c (Fget_process, Fprocess_datagram_address): No longer
2612 static.
2613 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2614 * keyboard.c (Fcommand_execute): No longer static.
2615 Remove EXFUN.
2616 * insdel.c (Fcombine_after_change_execute): No longer static.
2617 * image.c (Finit_image_library): No longer static.
2618 * fileio.c (Fmake_symbolic_link): No longer static.
2619 * eval.c (Ffetch_bytecode): No longer static.
2620 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2621 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2622 No longer static.
404dbd37
TT
2623 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2624 static.
2625 * dired.c (Ffile_attributes): No longer static.
2626 * composite.c (Fcomposition_get_gstring): No longer static.
2627 * callproc.c (Fgetenv_internal): No longer static.
2628
2629 * ccl.h: Remove EXFUNs.
2630 * buffer.h: Remove EXFUNs.
2631 * dispextern.h: Remove EXFUNs.
2632 * intervals.h: Remove EXFUNs.
2633 * fontset.h: Remove EXFUN.
2634 * font.h: Remove EXFUNs.
2635 * dosfns.c (system_process_attributes): Remove EXFUN.
2636 * keymap.h: Remove EXFUNs.
2637 * lisp.h: Remove EXFUNs.
2638 * w32term.h: Remove EXFUNs.
2639 * window.h: Remove EXFUNs.
2640 * xsettings.h: Remove EXFUN.
2641 * xterm.h: Remove EXFUN.
2642
8e4fd1e1
GM
26432012-07-03 Glenn Morris <rgm@gnu.org>
2644
2645 * lisp.h (Frandom): Make it visible to C.
2646 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2647 buffer for invisible buffers. (Bug#1229)
2648
ca95b3eb
DA
26492012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2650
2651 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2652 values which aren't power of 2.
14ae4239
BT
2653 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2654 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2655 accordingly.
2656
7555c33f
SM
26572012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2658
2659 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2660
2661 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2662
d12e8f5a
DA
26632012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2664
2665 * alloc.c (allocate_vector_block): Remove redundant
2666 calls to mallopt if DOUG_LEA_MALLOC is defined.
2667 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2668 avoid calls to mallopt if zero_vector is returned.
2669
296094c3
DA
26702012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2671
2672 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2673 is enabled, avoid dereferencing NULL current_sblock if
2674 running undumped.
2675
36429c89
DA
26762012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2677
2678 Cleanup basic buffer management.
2679 * buffer.h (struct buffer): Change layout to use generic vector
2680 marking code. Fix some comments. Change type of 'clip_changed'
2681 to bitfield. Remove unused #ifndef old.
2682 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2683 (GET_OVERLAYS_AT): Fix indentation.
2684 (for_each_per_buffer_object_at): New macro.
2685 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2686 (Fbuffer_local_variables): Use it.
2687 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2688 * alloc.c (allocate_buffer): Adjust to match new layout of
2689 struct buffer. Fix comment.
2690 (mark_overlay): New function.
2691 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2692 Lisp area of struct buffer.
2693 (mark_object): Use it. Adjust marking of misc objects
2694 and related comments.
2695
3b3e4cac
PE
26962012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2699 wrapper that is not needed because the wrapped code is a no-op (zero
2700 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2701 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2702
cf5c0175
DA
27032012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2704
2705 * alloc.c (mark_buffer): Simplify. Remove prototype.
2706 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2707 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2708 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2709 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2710
ca26824c
GM
27112012-06-30 Glenn Morris <rgm@gnu.org>
2712
2e4c5312
GM
2713 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2714
ca26824c
GM
2715 * epaths.in (PATH_SITELOADSEARCH): New.
2716 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2717 This is rather than relying on --enable-locallisppath elements
2718 having "site-lisp" in their names. (Bug#10208#25, 11658)
2719
0d23c240
EZ
27202012-06-30 Eli Zaretskii <eliz@gnu.org>
2721
c9240d7a
EZ
2722 * w32proc.c (sys_select): Accept and ignore one more argument.
2723
2724 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2725
0d23c240 2726 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2727 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2728
2729 * sysdep.c: Don't include dos.h and dosfns.h.
2730
2731 * process.c (sys_select):
2732 * msdos.c (sys_select): Accept one more argument and ignore it.
2733
2734 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2735 adapt data types and code to that.
2736
2737 * dosfns.c:
2738 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2739 which clashes with the gnulib function of the same name.
2740
af5a5a98
AS
27412012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2742
c5e4379c
AS
2743 * font.c (font_style_to_value, font_style_symbolic)
2744 (font_prop_validate_style): Add type checks for values in
2745 font_style_table.
2746
af5a5a98
AS
2747 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2748 argument.
2749 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2750 uses.
2751
8d38f461
EZ
27522012-06-29 Eli Zaretskii <eliz@gnu.org>
2753
2e5a6631
EZ
2754 * xdisp.c (try_window_id): Undo last change.
2755
8d38f461
EZ
2756 * w32.c (getwd): Adjust commentary about startup_dir.
2757 (init_environment): Always call sys_access, even in non-MSVC
2758 builds. Don't chdir to the directory of the Emacs executable.
2759 This undoes code from 1997 which was justified by the need to
2760 "avoid conflicts when removing and renaming directories". But its
2761 downside was that every relative file name was being interpreted
2762 relative to the directory of the Emacs executable, which can never
2763 be TRT. In particular, it broke sys_access when called with
2764 relative file names.
2765 (sys_access): Map GetLastError to errno.
2766
2af3565e
DA
27672012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2768
2769 * window.h (struct window): Change type of 'fringes_outside_margins'
2770 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2771 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2772 Adjust comment.
2773 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2774 to ptrdiff_t.
2775
c8d3a25c 27762012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2777
c8d3a25c
GM
2778 * gnutls.c (emacs_gnutls_handshake):
2779 Add QUIT to make the loop interruptible.
57570cd3 2780
c8d3a25c 27812012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2782
c8d3a25c
GM
2783 * charset.c (init_charset): Make lack of etc/charsets fatal.
2784
3e984ee8
DA
27852012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2786
2787 * editfns.c (region_limit): Fix type mismatch.
2788
ef884f23
DA
27892012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2790
2791 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2792 undefined. Convert from xassert to eassert.
2793 * nsmenu.m: Convert from xassert to eassert.
2794 * nsterm.m: Likewise.
2795
7d7e0027
SM
27962012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2797
2798 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2799
aa754e6a
PE
28002012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2801
2802 Avoid integer overflow on scroll-left and scroll-right.
2803 * window.c (HSCROLL_MAX): New macro.
2804 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2805 overflow when requested scroll falls outside ptrdiff_t range.
2806
80b00b08
DA
28072012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2808
2809 * window.h (struct window): Change type of 'hscroll',
2810 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2811 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2812 Adjust users accordingly.
2813 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2814 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2815 from EMACS_INT to ptrdiff_t.
2816 (make_window): Omit redundant initialization.
2817
62b2bcf6
JB
28182012-06-28 Juanma Barranquero <lekktu@gmail.com>
2819
2820 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2821
45942c7d
DA
28222012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2823
2824 * window.h (struct window): Change type of 'use_time' and
2825 'sequence_number' from Lisp_Object to int.
2826 * frame.c (make_frame): Adjust users accordingly.
2827 * print.c (print_object): Likewise.
2828 * window.c (select_window, Fwindow_use_time, make_parent_window)
2829 (make_window): Likewise.
2830
e509cfa6
DA
28312012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2832
2833 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2834 enabled with --enable-checking=[all,glyphs] configure option.
2835 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2836 adjust comments accordingly.
2837 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2838 undefined, adjust comments accordingly.
2839 * image.c: Likewise.
2840 * scroll.c: Likewise.
2841 * w32fns.c: Likewise.
2842 * w32term.c: Likewise.
2843 * xdisp.c: Likewise.
2844 * xfaces.c: Likewise.
2845 * xfns.c: Likewise.
2846 * xterm.c: Likewise.
2847
a54e2c05
DA
28482012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2849
2850 Generalize run-time debugging checks.
2851 * dispextern.h (XASSERTS): Remove.
2852 * fontset.c (xassert): Remove.
2853 Convert from xassert to eassert.
2854 * alloc.c: Convert from xassert to eassert.
2855 * bidi.c: Likewise.
2856 * dispnew.c: Likewise.
2857 * fns.c: Likewise.
2858 * fringe.c: Likewise.
2859 * ftfont.c: Likewise.
2860 * gtkutil.c: Likewise.
2861 * image.c: Likewise.
2862 * keyboard.c: Likewise.
2863 * menu.c: Likewise.
2864 * process.c: Likewise.
2865 * scroll.c: Likewise.
2866 * sound.c: Likewise.
2867 * term.c: Likewise.
2868 * w32console.c: Likewise.
2869 * w32fns.c: Likewise.
2870 * w32term.c: Likewise.
2871 * window.c: Likewise.
2872 * xdisp.c: Likewise.
2873 * xfaces.c: Likewise.
2874 * xfns.c: Likewise.
2875 * xselect.c: Likewise.
2876 * xterm.c: Likewise.
2877
1ec4b7b2
SM
28782012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2879
2880 * fns.c (maybe_resize_hash_table): Output message when growing the
2881 purify-hashtable.
2882
2014308a
DA
28832012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2884
2885 * alloc.c (allocate_string_data): Remove dead code.
2886 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2887 avoid GCC warning about unused macro.
2888
246155eb
DA
28892012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2890
2891 * alloc.c (allocate_string): Omit intervals initialization.
2892 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2893 as in make_pure_string and make_pure_c_string.
2894
43184b7b
DA
28952012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2896
d209e2fb 2897 * alloc.c (allocate_string): Fix last change.
43184b7b 2898
3fe6dd74
DA
28992012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2900
d209e2fb 2901 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2902 to memset, add explicit initialization where appropriate.
2903
1ba6038a
GM
29042012-06-27 Glenn Morris <rgm@gnu.org>
2905
2906 * lisp.mk (lisp): Remove paths.elc.
2907
c89926a5
CY
29082012-06-27 Chong Yidong <cyd@gnu.org>
2909
2910 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2911
ed6b3510
JW
29122012-06-26 John Wiegley <johnw@newartisans.com>
2913
1ec4b7b2 2914 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2915 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2916
ed6b3510
JW
2917 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2918 when building with Clang.
2919
8edd4a2b
SM
29202012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2921
2922 * eval.c (Fapply): Allow calling it with a single argument.
2923
f6f62d1b
EZ
29242012-06-26 Eli Zaretskii <eliz@gnu.org>
2925
2926 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2927 _stricmp and _strnicmp.
2928 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2929
62efea5e
DA
29302012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2931
2932 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2933 allocated window.
2934 (allocate_process): Likewise for new process.
8edd4a2b 2935 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2936 (allocate_frame): Likewise.
2937 * frame.c (make_frame): Omit redundant initialization.
2938 * window.c (make_parent_window): Use memset.
2939 (make_window): Omit redundant initialization.
2940 * process.c (make_process): Omit redundant initialization.
2941 * terminal.c (create_terminal): Likewise.
2942
42997f4d
DA
29432012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2944
2945 * term.c (delete_tty): Remove redundant call to memset.
2946
1130ecfc
DA
29472012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2948
2949 * alloc.c: Remove build_string.
2950 * lisp.h: Define build_string as static inline. This provides
2951 a better opportunity to optimize away calls to strlen when the
2952 function is called with compile-time constant argument.
2953 * image.c (imagemagick_error): Convert to build_string.
2954 * w32proc.c (sys_spawnve): Likewise.
2955 * xterm.c (x_term_init): Likewise.
2956
cf38a720
PE
29572012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2958
99027bdd
PE
2959 Use sprintf return value instead of invoking strlen on result.
2960 In the old days this wasn't portable, since some sprintf
2961 implementations returned char *. But they died out years ago and
2962 Emacs already assumes sprintf returns int.
2963 Similarly for float_to_string.
2964 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2965 * ccl.c (ccl_driver):
2966 * character.c (string_escape_byte8):
2967 * data.c (Fnumber_to_string):
2968 * doprnt.c (doprnt):
2969 * print.c (print_object):
2970 * xdisp.c (message_dolog):
2971 * xfns.c (syms_of_xfns):
2972 Use sprintf or float_to_string result to avoid need to call strlen.
2973 * data.c (Fnumber_to_string):
2974 Use make_unibyte_string, since the string must be ASCII.
2975 * lisp.h, print.c (float_to_string): Now returns int length.
2976 * term.c (produce_glyphless_glyph):
2977 Use sprintf result rather than recomputing it.
2978
cf38a720
PE
2979 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2980 * Makefile.in (ALL_CFLAGS):
2981 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2982 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2983
3511c784
DA
29842012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2985
0a08eb21 2986 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2987 strcasecmp if available.
2988 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2989
fb7da12e
AS
29902012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2991
2992 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2993 Avoid comma operator.
2994 * menu.c (push_submenu_start, push_submenu_end)
2995 (push_left_right_boundary, push_menu_pane): Likewise.
2996 * msdos.c (dos_rawgetc): Likewise.
2997
afa2ffd8
DA
29982012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2999
3000 * xfns.c (xic_create_fontsetname): Remove redundant calls
3001 to memset.
3002
b3b4476b
PE
30032012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3004
4495ff38
PE
3005 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3006 sprintf already null-terminates its output.
3007
b3b4476b
PE
3008 * xfns.c (x_window): Remove redundant cast.
3009
b00876c9
DA
30102012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3011
3012 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3013 `const char *' to `char *' to avoid compiler warning.
3014
d188e26b
PE
30152012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3016
885d1d74
PE
3017 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3018 instead of truncating it to 63 (admittedly a generous limit).
3019
d188e26b
PE
3020 * process.c: Fix spelling and caps in comments.
3021
e2f560b1
DN
30222012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3023
e86db54b 3024 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3025 * sysdep.c (setpgrp): Remove definition, not used in this file.
3026
7583a3a1
JB
30272012-06-24 Juanma Barranquero <lekktu@gmail.com>
3028
3029 * makefile.w32-in: Update dependencies.
3030
696056c2
EZ
30312012-06-24 Eli Zaretskii <eliz@gnu.org>
3032
3033 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3034 (SYSTIME_H): Add nt/inc/sys/time.h.
3035
3036 * systime.h [WINDOWSNT]: Include sys/time.h.
3037
3038 * s/ms-w32.h (struct timespec): Definition moved from
3039 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3040
845ca893
PE
30412012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3042
3043 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3044 * buffer.h (buffer_slot_type_mismatch):
3045 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3046 * eval.c (unwind_to_catch):
3047 * image.c (my_png_error, my_error_exit):
3048 * keyboard.c (quit_throw_to_read_char, user_error)
3049 (Fexit_recursive_edit, Fabort_recursive_edit):
3050 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3051 (wrong_type_argument, buffer_overflow, __executable_start)
3052 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3053 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3054 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3055 (fatal):
3056 (child_setup) [!DOS_NT]:
3057 * lread.c (end_of_file_error, invalid_syntax):
3058 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3059 * puresize.h (pure_write_error):
3060 * search.c (matcher_overflow):
3061 * sound.c (sound_perror, alsa_sound_perror):
3062 * sysdep.c, syssignal.h (croak):
3063 * term.c (maybe_fatal, vfatal):
3064 * textprop.c (text_read_only):
3065 * undo.c (user_error):
3066 * unexmacosx.c (unexec_error):
3067 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3068 Use _Noreturn rather than NO_RETURN.
3069 No need for separate decl merely because of _Noreturn.
3070 * sound.c (sound_warning, parse_sound):
3071 Remove unnecessary forward decls.
3072
f1dd8073
PE
30732012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3076 * lisp.h (WAIT_READING_MAX): New macro.
3077 * dispnew.c (Fsleep_for, sit_for):
3078 * keyboard.c (kbd_buffer_get_event):
3079 * process.c (Faccept_process_output):
3080 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3081 This improves on the previous patch, which introduced a bug
3082 when time_t is unsigned and as wide as intmax_t.
3083 See <http://bugs.gnu.org/9000#51>.
3084
b82c1755
EZ
30852012-06-23 Eli Zaretskii <eliz@gnu.org>
3086
3087 * dispnew.c (sit_for, Fsleep_for):
3088 * keyboard.c (kbd_buffer_get_event):
3089 * process.c (Faccept_process_output): Avoid compiler warnings when
3090 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3091
ca300656
JB
30922012-06-23 Juanma Barranquero <lekktu@gmail.com>
3093
049ec95b
JB
3094 * makefile.w32-in: Update dependencies.
3095
ca300656
JB
3096 * w32.c (ltime): Add return type and declare static.
3097 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3098
db7b8d06
PE
30992012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3100
3101 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3102 Privately reported by Herbert J. Skuhra.
3103 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3104 All uses changed.
3105 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3106 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3107
0bd8297f
EZ
31082012-06-23 Eli Zaretskii <eliz@gnu.org>
3109
96512555
EZ
3110 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3111 last argument of make_unibyte_string.
3112
0bd8297f
EZ
3113 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3114 language ID in the event parameters.
3115
3116 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3117 event.code, not the obscure "character set ID".
3118
63def6b6
CY
31192012-06-23 Chong Yidong <cyd@gnu.org>
3120
3121 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3122
e8a02204
EZ
31232012-06-23 Eli Zaretskii <eliz@gnu.org>
3124
388cdec0
EZ
3125 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3126 * w32.c (fdutimens): New function.
3127
3128 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3129
3130 * s/ms-w32.h (pselect): Redirect to sys_select.
3131
3132 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3133
e8a02204
EZ
3134 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3135 in the logic of incrementing and decrementing the value of
3136 use_relocatable_buffers.
3137
d054f3fb
PE
31382012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3139
3140 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3141 Privately reported by Herbert J. Skuhra.
3142 [__FreeBSD__]: Remove "*/" typo after "#include".
3143 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3144 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3145 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3146 Don't assume EMACS_TIME and struct timeval are the same type.
3147
d35af63c
PE
31482012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3149
3150 Support higher-resolution time stamps (Bug#9000).
3151 The time stamps are only nanosecond-resolution at the C level,
3152 since that's the best that any real-world system supports now.
3153 But they are picosecond-resolution at the Lisp level, as that's
3154 easy, and leaves room for future OS improvements.
3155
3156 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3157 (LIBES): Use it.
3158
3159 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3160 Don't get current time unless it's needed.
3161
3162 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3163 now provides it if it's absent.
3164 (start_atimer): Port to higher-res time stamps.
3165 Check for time stamp overflow. Don't get current time more
3166 often than is needed.
3167
3168 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3169 Include systime.h, not time.h.
3170 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3171
3172 * dired.c: Include stat-time.h.
3173 (Ffile-attributes): File times now have higher resolution.
3174
3175 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3176 (struct image): Timestamp now has higher resolution.
3177
3178 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3179 has at least microseconds now. All uses removed.
3180 (update_frame, update_single_window, update_window, update_frame_1)
3181 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3182
3183 * editfns.c (time_overflow): Now extern.
3184 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3185 (float-time, Fformat_time_string, Fcurrent_time_string)
3186 (Fcurrent_time_zone): Accept and generate higher-resolution
3187 time stamps.
3188 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3189 (decode_time_components, lisp_seconds_argument): New functions.
3190 (make_time): Now static.
3191 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3192 Report an error if the time is invalid, rather than having the caller
3193 do that.
3194
3195 * fileio.c: Include <stat-time.h>
3196 (Fcopy_file): Copy higher-resolution time stamps.
3197 Prefer to set the time stamp via a file descriptor if that works.
3198 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3199 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3200 (Fvisited_file_modtime, Fset_visited_file_modtime):
3201 Support higher-resolution time stamps.
3202
3203 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3204
3205 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3206
3207 * image.c (prepare_image_for_display, clear_image_cache)
3208 (lookup_image): Port to higer-resolution time stamps.
3209
3210 * keyboard.c (start_polling, bind_polling_period):
3211 Check for time stamp overflow.
3212 (read_char, kbd_buffer_get_event, timer_start_idle)
3213 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3214 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3215 Port to higher-resolution time stamps. Do not assume time_t is signed.
3216 (decode_timer): New function. Timers are now vectors of length 9,
3217 not 8, to accommodate the picosecond component.
3218 (timer_check_2): Use it.
3219
3220 * nsterm.m (select_timeout, timeval_subtract): Remove.
3221 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3222 as they're a bit more accurate and handle overflow better.
3223 (ns_select): Change prototype to be compatible with pselect.
3224 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3225 * nsterm.h (ns_select): Adjust prototype.
3226
3227 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3228 us-resolution time stamps.
3229 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3230
3231 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3232
3233 * lisp.h (time_overflow): New decl.
3234 (wait_reading_process_output): First arg is now intmax_t, not int,
3235 to accommodate larger waits.
3236
3237 * process.h (struct Lisp_Process.read_output_delay):
3238 Now counts nanoseconds, not microseconds.
3239 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3240 EMACS_HAS_USECS.
3241 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3242 (wait_reading_process_output):
3243 Port to ns-resolution time stamps.
3244 (Faccept_process_output, wait_reading_process_output):
3245 Check for time stamp overflow. Do not assume time_t is signed.
3246 (select_wrapper): Remove; we now use pselect.
3247 (Fprocess_attributes): Now generates ns-resolution time stamps.
3248
3249 * sysdep.c: Include utimens.h. Don't include utime.h
3250 or worry about struct utimbuf; gnulib does that for us now.
3251 (gettimeofday): Remove; gnulib provides a substitute.
3252 (make_timeval): New function.
3253 (set_file_times): Now sets ns-resolution time stamps.
3254 New arg FD; all uses changed.
3255 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3256 (system_process_attributes):
3257 Now returns ns-resolution time stamp. All uses changed.
3258 Check for time stamp overflow.
3259
3260 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3261 provides a substitute now.
3262
3263 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3264 since it guarantees struct timespec.
3265 (EMACS_TIME): Now struct timespec, so that we can support
3266 ns-resolution time stamps.
3267 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3268 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3269 (EMACS_USECS): Remove.
3270 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3271 so multiply the arg by 1000 before storing it.
3272 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3273 New macros.
3274 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3275 Port to ns-resolution time stamps.
3276 (EMACS_TIME_NEG_P): Remove; replaced by....
3277 (EMACS_TIME_SIGN): New macro.
3278 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3279 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3280 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3281 (make_timeval, make_lisp_time, decode_time_components): New decls.
3282 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3283 that it mishandled time_t overflow. You can't compare by subtracting!
3284 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3285 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3286
3287 * term.c: Include <sys/time.h>.
3288 (timeval_to_Time): New function, for proper overflow wraparound.
3289 (term_mouse_position, term_mouse_click): Use it.
3290
3291 * undo.c (record_first_change): Support higher-resolution time stamps
3292 in the undo buffer.
3293 (Fprimitive_undo): Use them when restoring time stamps.
3294
3295 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3296 (w32_get_internal_run_time):
3297 Port to higher-resolution Emacs time stamps.
3298 (ltime): Now accepts single 64-bit integer, as that's more convenient
3299 for callers.
3300
3301 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3302
3303 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3304 for compatibility with pselect. Support ns-resolution time stamps.
3305
3306 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3307
3308 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3309 Check for time stamp overflow, and support ns-resolution time stamps.
3310
3311 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3312 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3313 (timeval_subtract): Remove; no longer needed.
3314 (XTflash, XTring_bell, x_wait_for_event):
3315 Port to ns-resolution time stamps. Don't assume time_t is signed.
3316
b6a92dfe
CY
33172012-06-22 Chong Yidong <cyd@gnu.org>
3318
3319 * xdisp.c (x_consider_frame_title): Revert last change.
3320
d251c37c
EZ
33212012-06-22 Eli Zaretskii <eliz@gnu.org>
3322
3323 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3324 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3325 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3326 staticidx goes up to 1597 out of 1600 = 0x640.)
3327
f10deafb
PE
33282012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3329
3330 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3331 Otherwise, the umask might be mistakenly 0 while handling input signals.
3332
ec6de1e2
SM
33332012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3334
3335 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3336
28be1ada
DA
33372012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3338
3339 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3340 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3341 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3342 access to `contents' member of Lisp_Vector objects with AREF and ASET
3343 where appropriate.
3344
c6bf3022
CY
33452012-06-19 Chong Yidong <cyd@gnu.org>
3346
3347 * frame.c (delete_frame): When selecting a frame on a different
3348 text terminal, do not alter the terminal's top-frame.
3349
3350 * xdisp.c (format_mode_line_unwind_data): Record the target
3351 frame's selected window and its terminal's top-frame.
3352 (unwind_format_mode_line): Restore them.
3353 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3354 Callers changed.
3355 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3356 since tty frames can be explicitly named.
3357 (prepare_menu_bars): Likewise.
3358
3359 * term.c (Ftty_top_frame): New function.
3360
defd4196
PE
33612012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3362
3363 Port byte-code-meter to modern targets.
3364 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3365 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3366 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3367 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3368 (METER_1, METER_2): Simplify.
3369
1053a871
SM
33702012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3371
3372 * data.c (Fdefalias): Return `symbol' (bug#11686).
3373
b7e8d081
MR
33742012-06-18 Martin Rudalics <rudalics@gmx.at>
3375
3376 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3377 gets killed during executing of this function (Bug#11665).
3378 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3379 (Vkill_buffer_query_functions): In doc-string say that functions
3380 run by this hook should not change the current buffer.
3381
7ea2b339
PE
33822012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 Fix recently-introduced process.c problems found by static checking.
3385 * process.c (write_queue_push, write_queue_pop, send_process):
3386 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3387 (write_queue_pop): Fix pointer signedness problem.
3388 (send_process): Remove unused local.
3389
96a313a1
CY
33902012-06-17 Chong Yidong <cyd@gnu.org>
3391
3392 * xdisp.c (redisplay_internal): No need to redisplay terminal
3393 frames that are not on top.
3394
20ca2e94
TN
33952012-06-17 Troels Nielsen <bn.troels@gmail.com>
3396
3397 * process.c (make_process): Initialize write_queue.
3398 (write_queue_push, write_queue_pop): New functions.
3399 (send_process): Use them to maintain correct ordering of process
3400 writes (Bug#10815).
3401
9a900ca9
PE
34022012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3403
310fbfa8
PE
3404 * lisp.h (eassert): Assume C89 or later.
3405 This removes the need for CHECK.
3406 (CHECK): Remove. Its comments about always evaluating its
3407 argument were confusing, as 'eassert' typically does not evaluate
3408 its argument.
3409
27bb1ca4
PE
3410 * coding.c (produce_chars): Use ptrdiff_t, not int.
3411
9a900ca9
PE
3412 * xterm.c (x_draw_underwave): Check for integer overflow.
3413 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3414
41b7f8bc 34152012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3416
3417 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3418 referenced (Bug#11583).
3419
9b0e3eba
AA
34202012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3421
3422 Implement wave-style variant of underlining.
3423 * dispextern.h (face_underline_type): New enum.
3424 (face): Add field for underline type.
3425 * nsterm.m (ns_draw_underwave): New function.
3426 (ns_draw_text_decoration): Use it.
3427 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3428 New functions.
3429 (x_draw_glyph_string): Use them.
3430 * xfaces.c (Qline, Qwave): New Lisp objects.
3431 (check_lface_attrs, merge_face_ref)
1053a871
SM
3432 (Finternal_set_lisp_face_attribute, realize_x_face):
3433 Handle wave-style underline face attributes.
9b0e3eba
AA
3434 * xterm.c (x_draw_underwave): New function.
3435 (x_draw_glyph_string): Use it.
3436
0fb52f11
JB
34372012-06-16 Juanma Barranquero <lekktu@gmail.com>
3438
3439 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3440 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3441 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3442 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3443 ($(BLD)/w32select.$(O)): Update dependencies.
3444
e5560ff7
AS
34452012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3446
3447 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3448 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3449 * character.c (_fetch_multibyte_char_p): Remove.
3450 * alloc.c: Include "character.h" before "buffer.h".
3451 * bidi.c: Likewise.
3452 * buffer.c: Likewise.
3453 * bytecode.c: Likewise.
3454 * callint.c: Likewise.
3455 * callproc.c: Likewise.
3456 * casefiddle.c: Likewise.
3457 * casetab.c: Likewise.
3458 * category.c: Likewise.
3459 * cmds.c: Likewise.
3460 * coding.c: Likewise.
3461 * composite.c: Likewise.
3462 * dired.c: Likewise.
3463 * dispnew.c: Likewise.
3464 * doc.c: Likewise.
3465 * dosfns.c: Likewise.
3466 * editfns.c: Likewise.
3467 * emacs.c: Likewise.
3468 * fileio.c: Likewise.
3469 * filelock.c: Likewise.
3470 * font.c: Likewise.
3471 * fontset.c: Likewise.
3472 * fringe.c: Likewise.
3473 * indent.c: Likewise.
3474 * insdel.c: Likewise.
3475 * intervals.c: Likewise.
3476 * keyboard.c: Likewise.
3477 * keymap.c: Likewise.
3478 * lread.c: Likewise.
3479 * macros.c: Likewise.
3480 * marker.c: Likewise.
3481 * minibuf.c: Likewise.
3482 * nsfns.m: Likewise.
3483 * nsmenu.m: Likewise.
3484 * print.c: Likewise.
3485 * process.c: Likewise.
3486 * regex.c: Likewise.
3487 * region-cache.c: Likewise.
3488 * search.c: Likewise.
3489 * syntax.c: Likewise.
3490 * term.c: Likewise.
3491 * textprop.c: Likewise.
3492 * undo.c: Likewise.
3493 * unexsol.c: Likewise.
3494 * w16select.c: Likewise.
3495 * w32fns.c: Likewise.
3496 * w32menu.c: Likewise.
3497 * window.c: Likewise.
3498 * xdisp.c: Likewise.
3499 * xfns.c: Likewise.
3500 * xmenu.c: Likewise.
3501 * xml.c: Likewise.
3502 * xselect.c: Likewise.
3503
2f07e6af
EZ
35042012-06-16 Eli Zaretskii <eliz@gnu.org>
3505
1053a871
SM
3506 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3507 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3508 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3509 row.
3510 (handle_face_prop): Use chunk-relative overlay string index when
3511 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3512 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3513 the rightmost. (Bug#11720)
2f07e6af 3514
29b83cec
AS
35152012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3516
3517 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3518 (CATEGORY_MEMBER): Enforce 1/0 value.
3519 * category.c (_temp_category_set): Remove.
3520
4c5501e9
EZ
35212012-06-16 Eli Zaretskii <eliz@gnu.org>
3522
3523 * window.c (Fdelete_other_windows_internal)
3524 (Fdelete_window_internal): Don't access frame's mouse highlight
3525 info of the initial frame. (Bug#11677)
3526
2b570124
PE
35272012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3528
e93864f9
PE
3529 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3530 Assume USE_2_TAGS_FOR_INTS.
3531 (xreload): Adjust $tagmask width to match recent lisp.h change.
3532
2b570124
PE
3533 Simplify lisp.h in minor ways that should not affect code.
3534 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3535 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3536 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3537 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3538 (INTTYPEBITS): New macro, for clarity.
3539 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3540 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3541 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3542 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3543 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3544
81755f69
JB
35452012-06-13 Juanma Barranquero <lekktu@gmail.com>
3546
3547 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3548
16192a57
GM
35492012-06-13 Glenn Morris <rgm@gnu.org>
3550
3551 * s/bsd-common.h (BSD4_3):
3552 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3553
646b5f55
AS
35542012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3555
3556 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3557 instead of union.
3558 (XLI, XIL): Define.
1053a871
SM
3559 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3560 Use them.
3561 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3562 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3563 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3564 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3565 * frame.c (delete_frame): Remove outdated comment.
3566 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3567 USE_LISP_UNION_TYPE.
3568 (Fw32_unregister_hot_key): Likewise.
3569 (Fw32_toggle_lock_key): Likewise.
3570 * w32menu.c (add_menu_item): Likewise.
3571 (w32_menu_display_help): Use XIL instead of checking
3572 USE_LISP_UNION_TYPE.
3573 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3574 (init_heap): Likewise.
3575 * w32term.c (w32_read_socket): Update comment.
3576
1d3823c9
GM
35772012-06-13 Glenn Morris <rgm@gnu.org>
3578
c62ff706
GM
3579 * s/usg5-4-common.h, src/s/unixware.h:
3580 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3581
1d3823c9
GM
3582 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3583
bfe3e0a2
PE
35842012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3585
3586 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3587 * alloc.c (make_number) [!defined make_number]:
3588 Remove, as lisp.h always defines this now.
3589 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3590 (roundup_size): Verify that it is a power of 2.
3591 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3592 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3593 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3594 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3595 USE_LSB_TAG now is always defined to be either 0 or 1.
3596 All uses changed.
3597 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3598 code works fine either way, and efficiency is not a concern here,
3599 as the union type is for debugging, not for production.
3600 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3601 Use an inline function on all platforms when using the union type,
3602 since this is simpler and 'static inline' can be used portably
3603 within Emacs now.
3604 (LISP_INITIALLY_ZERO): New macro.
3605 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3606 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3607
45fa9c0f
GM
36082012-06-12 Glenn Morris <rgm@gnu.org>
3609
b4492cba
GM
3610 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3611
3612 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3613
45fa9c0f
GM
3614 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3615 Move BROKEN_SIGIO to configure.
3616
3617 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3618 Move NO_TERMIO to configure.
3619
0e25d334
CY
36202012-06-12 Chong Yidong <cyd@gnu.org>
3621
3622 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3623 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3624 MagickExportImagePixels is undefined.
3625
43682bb6
PE
36262012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3627
3628 * image.c (imagemagick_load_image): Remove unused label.
3629
a9be7d2b
GM
36302012-06-11 Glenn Morris <rgm@gnu.org>
3631
3632 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3633 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3634 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3635 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3636
3017f87f
SM
36372012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3638
3639 * alloc.c (make_byte_code): New function.
3640 (Fmake_byte_code): Use it. Don't purify here.
3641 * lread.c (read1): Use it as well to avoid extra allocation.
3642
1b9b4cf4
CY
36432012-06-11 Chong Yidong <cyd@gnu.org>
3644
3645 * image.c (imagemagick_load_image): Implement transparency.
3646
95988fcf
AS
36472012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3648
3649 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3650 account for preceding backslashes. (Bug#11663)
3651
cd4eb164
CY
36522012-06-09 Chong Yidong <cyd@gnu.org>
3653
3654 * term.c: Support italics in capable terminals (Bug#9652).
3655 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3656 (turn_on_face): Output using TS_enter_italic_mode if available.
3657 Don't handle unused blinking and alt-charset cases.
3658 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3659 and tty_alt_charset_p cases.
3660 (tty_capable_p, init_tty): Support italics.
3661
3662 * termchar.h (struct tty_display_info): Add field for italics.
3663 Remove unused blink field.
3664
3665 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3666 Handle slant.
3667
3668 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3669 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3670 tty_alt_charset_p. Add tty_italic_p.
3671
ff88beb8
MA
36722012-06-09 Michael Albinus <michael.albinus@gmx.de>
3673
3674 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3675 dbus_type_is_basic if available.
3676 (xd_extract_signed, xd_extract_unsigned): Rename from
3677 extract_signed and extract_unsigned, respectively. Adapt callers.
3678
44286096
CY
36792012-06-09 Chong Yidong <cyd@gnu.org>
3680
1682701f
CY
3681 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3682
44286096
CY
3683 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3684 case (Bug#9752).
3685
d86feb17
PE
36862012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3687
3688 * xdisp.c (vmessage): Treat frame message as multibyte.
3689 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3690 would generate the diagnostic "Making \302\247 buffer-local while
3691 let-bound!".
3692
d5c20fe8
EZ
36932012-06-08 Eli Zaretskii <eliz@gnu.org>
3694
3695 * dispnew.c (showing_window_margins_p): Undo last change, which
3696 was done due to an inadvertent commit.
3697 (adjust_frame_glyphs_for_frame_redisplay): Do call
3698 showing_window_margins_p.
3699
513749ee
SM
37002012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3701
3702 * eval.c (Fmake_var_non_special): New primitive.
3703 (syms_of_eval): Defsubr it.
3704 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3705
d4a8f5c1
JB
37062012-06-08 Juanma Barranquero <lekktu@gmail.com>
3707
3708 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3709 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3710
8bbbc977
EZ
37112012-06-08 Eli Zaretskii <eliz@gnu.org>
3712
3713 * alloc.c (allocate_vectorlike): Fix last change.
3714
f3372c87
DA
37152012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3716
3717 Block-based vector allocation of small vectors.
3718 * lisp.h (struct vectorlike_header): New field `nbytes',
3719 adjust comment accordingly.
3720 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3721 to denote vector blocks. Adjust users (live_vector_p,
3722 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3723 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3724 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3725 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3726 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3727 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3728 (roundup_size): New constant.
3729 (struct vector_block): New data type.
3730 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3731 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3732 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3733 (sweep_vectors): New functions.
3734 (allocate_vectorlike): Return `zero_vector' as the only vector of
3735 0 items. Allocate new vector from block if vector size is less than
3736 or equal to VBLOCK_BYTES_MAX.
3737 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3738 (init_alloc_once): Add call to init_vectors.
3739
4f18a4ed
SM
37402012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3741
3742 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3743
86f158bc
PE
37442012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3745
3746 * doprnt.c (doprnt): Truncate multibyte char correctly.
3747 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3748 would mishandle a string argument "Xc" if X was a multibyte
3749 character of length 2: it would truncate after X's first byte
3750 rather than including all of X.
3751
c5cfcbe0
CY
37522012-06-06 Chong Yidong <cyd@gnu.org>
3753
3754 * buffer.c (word_wrap): Doc fix.
3755
c05cf390
PE
37562012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3757
3758 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3759
0c3461de
GM
37602012-06-03 Glenn Morris <rgm@gnu.org>
3761
3762 * xdisp.c (tool-bar-style): Doc fix.
3763
c71232db
UM
37642012-06-03 Ulrich Müller <ulm@gentoo.org>
3765
3766 * Makefile.in (PAXCTL): Define.
3767 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3768 binary via PaX flags if the paxctl utility is available.
3769 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3770 Restore PaX flags to their default. (Bug#11398)
3771
383f7350
CY
37722012-06-03 Chong Yidong <cyd@gnu.org>
3773
3774 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3775 buffer (Bug#11226).
3776
5f2c76c6
CY
37772012-06-03 Chong Yidong <cyd@gnu.org>
3778
3779 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3780 (note_mode_line_or_margin_highlight): If there is no help echo,
3781 use mode-line-default-help-echo. Handle the case where the mouse
3782 position is past the end of the mode line string.
3783
3784 * buffer.c (buffer_local_value_1): New function, split from
3785 Fbuffer_local_value; can return Qunbound.
3786 (Fbuffer_local_value): Use it.
3787 (Vmode_line_format): Docstring tweaks.
3788
773d47f6
PE
37892012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3790
3791 * sysdep.c (system_process_attributes): Improve comment.
3792
f2d6a3df
SM
37932012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3794
3795 * keyboard.c: Export real-this-command to Elisp.
3796 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3797 and DEFVAR it. Update all users.
3798
63810350
PE
37992012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3800
7bd5c1f4
PE
3801 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3802
63810350
PE
3803 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3804 Convert pctcpu and pctmem to Lisp float properly.
3805 Let the compiler fold better, as 100.0/0x8000 is exact.
3806
a2821611
AS
38072012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3808
3809 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3810 cons_block.
3811
5fceba1d
PE
38122012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3813
3814 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3815
c98ff5dd
DA
38162012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3817
3818 For a 'struct window', replace some Lisp_Object fields to
3819 bitfields where appropriate, remove unused fields.
3820 * window.h (struct window): Remove unused 'last_mark_x' and
3821 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3822 change it's type from Lisp_Object to bitfield.
3823 Change type of 'force_start', 'optional_new_start',
3824 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3825 fields from Lisp_Object to bitfield. Adjust users accordingly.
3826
ca34e0be
PE
38272012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3828
3829 Pacify gcc -Wdouble-precision when using Xaw.
3830 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3831 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3832 Use 'float' consistently, rather than 'float' in most places
3833 and 'double' in a couple of places.
3834
efc00ab1 38352012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3836
3837 * xdisp.c (handle_stop): Detect whether we have overlay strings
3838 loaded by testing it->current.overlay_string_index to be
3839 non-negative, instead of checking whether n_overlay_strings is
3840 positive. (Bug#11587)
3841
efc00ab1 38422012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3843
3844 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3845
3846 * doc.c (Fsubstitute_command_keys): Doc fix.
3847
efc00ab1 38482012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3849
3850 * search.c (search_buffer): Remove calls to
3851 r_alloc_inhibit_buffer_relocation, as it is now called by
3852 maybe_unify_char, which was the cause of relocation of buffer text
3853 in bug#11519.
3854
efc00ab1 38552012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3856
3857 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3858 for the duration of call to load_charset, to avoid problems with
3859 callers of maybe_unify_char that access buffer text through C
3860 pointers.
3861
3862 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3863 decrement the inhibition flag, instead of just setting or
3864 resetting it.
3865
ba93a187
PE
38662012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3867
3868 Remove obsolete '#define static' cruft.
3869 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3870 This #undef was "temporary" in 2000; it is no longer needed
3871 now that '#define static' has gone away.
3872 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3873 (gray_bitmap_bits): Remove; no longer needed.
3874 All uses replaced with definiens.
3875 * xterm.c: Include "bitmaps/gray.xbm".
3876
9e4bf381
PE
38772012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3878
3879 Clean up __executable_start, monstartup when --enable-profiling.
3880 The following changes affect the code only when profiling.
3881 * dispnew.c (__executable_start): Rename from safe_bcopy.
3882 Define only on platforms that need it.
3883 * emacs.c: Include <sys/gmon.h> when profiling.
3884 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3885 (__executable_start): Remove decl, since lisp.h does it now.
3886 (safe_bcopy): Remove decl; no longer has that name.
3887 (main): Coalesce #if into single bit of code, for simplicity.
3888 Cast pointers to uintptr_t, since standard libraries want integers
3889 and not pointers.
3890 * lisp.h (__executable_start): New decl.
3891
32d72c2f
GM
38922012-05-31 Glenn Morris <rgm@gnu.org>
3893
3894 * image.c (Fimagemagick_types): Doc fix.
3895
baac5bc7
JM
38962012-05-30 Jim Meyering <meyering@redhat.com>
3897
3898 * callproc.c (Fcall_process_region): Include directory component
3899 in mkstemp error message (Bug#11586).
3900
72cb32cf
PE
39012012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3902
3903 * alloc.c, lisp.h (make_pure_vector): Now static.
3904
61b108cc
SM
39052012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3906
3907 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3908 Move to byte-run.el.
3909 (Fautoload): Do the hash-doc more carefully.
3910 * data.c (Fdefalias): Purify definition, except for keymaps.
3911 (Qdefun): Move from eval.c.
3912 * lisp.h (Qdefun): Remove.
3913 * lread.c (read1): Tiny simplification.
3914
471fe23d
TN
39152012-05-29 Troels Nielsen <bn.troels@gmail.com>
3916
934f3f58 3917 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3918 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3919 Bug#9642, but explicitly check that the buffer the overlay would
3920 be moved to is live and rearrange lines to make sure that errors
3921 will not put the overlay in an inconsistent state.
3922 (Fdelete_overlay): Cosmetics.
3923
85d0efd1
EZ
39242012-05-28 Eli Zaretskii <eliz@gnu.org>
3925
3926 * w32term.c (my_bring_window_to_top): New function.
3927 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3928 could be different from the original one.
3929 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3930 (Bug#11513)
3931
3932 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3933 by calling BringWindowToTop.
3934
3935 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3936 (WM_EMACS_END): Increase by one.
3937
da92a98c
PE
39382012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3939
3940 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3941 This avoids undefined behavior that might cause the eassert
3942 to not catch an out-of-range value.
3943
74d1f848
JB
39442012-05-28 Juanma Barranquero <lekktu@gmail.com>
3945
3946 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3947 Update dependencies.
3948
9e1a06fc
EZ
39492012-05-27 Eli Zaretskii <eliz@gnu.org>
3950
3951 * bidi.c (bidi_mirror_char): Fix last change.
3952
f3dd7312
AS
39532012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3954
3955 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3956 when referring to sectname field in printf format.
3957
81899c91
PE
39582012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3959
57b81a9f
PE
3960 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3961 Only r_alloc_inhibit_buffer_relocation needed to be added;
3962 the others were already declared.
3963
81899c91
PE
3964 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3965 before checking whether it's out of range. Put the check inside
3966 eassert. See
3967 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3968
33017faf 39692012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3970
3971 * callproc.c (Fcall_process): Restore a line that was accidentally
3972 commented out in the 2011-02-13 change (bug#11547).
3973
33017faf 39742012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3975
3976 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3977 defined on ralloc.c.
3978
3979 * buffer.c [REL_ALLOC]: Remove prototypes of
3980 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3981 they are now on lisp.h.
3982
3983 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3984
3985 * search.c (search_buffer): Use it to inhibit relocation of buffer
3986 text while re_search_2 is doing its job, because re_search_2 is
3987 passed C pointers to buffer text. (Bug#11519)
3988
23415acf
EZ
3989 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3990 Update value to 24.
3991
44e27368
EZ
3992 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3993 state after an additional call to move_it_in_display_line_to, keep
3994 the values of it->max_ascent and it->max_descent found for the
3995 entire line.
3996 (pos_visible_p): Revert the comparison against bottom_y to what it
3997 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3998 (Bug#11464)
3999
c1892f11
PE
40002012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4001
4002 Fix coding-related core dumps with gcc -ftrapv.
4003 The code was computing A - B, where A and B are pointers, and B is
4004 random garbage. This can lead to core dumps on platforms that
4005 have special pointer registers, and it also leads to core dumps on
4006 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4007 A - B only when B is initialized properly.
4008 * coding.c (coding_set_source, coding_set_destination): Return void.
4009 (coding_change_source, coding_change_destinations): New functions,
4010 with the old behaviors of coding_set_source and coding_set_destination.
4011 All callers that need an offset changed to use these new functions.
4012
eb7afdad
GM
40132012-05-26 Glenn Morris <rgm@gnu.org>
4014
4015 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4016
f12fdf02
EZ
40172012-05-26 Eli Zaretskii <eliz@gnu.org>
4018
53a63be6 4019 Extend mouse support on W32 text-mode console.
61b108cc
SM
4020 * xdisp.c (draw_row_with_mouse_face):
4021 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4022
eb3f6f01 4023 * w32console.c: Include window.h.
61b108cc
SM
4024 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4025 New functions.
eb3f6f01
EZ
4026 (initialize_w32_display): Initialize mouse-highlight data.
4027
53a63be6
EZ
4028 * w32inevt.c: Include termchar.h and window.h.
4029 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4030 moves, call note_mouse_highlight. If help_echo changed, call
4031 gen_help_event to produce help-echo message in the echo area.
4032 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4033 highlight info.
4034
4cfd81f6
PE
40352012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4036
4037 * lread.c (read1): Simplify slightly to avoid an overflow warning
4038 with GCC 4.7.0 on x86-64.
4039
4446092a
EZ
40402012-05-26 Eli Zaretskii <eliz@gnu.org>
4041
4042 * bidi.c (bidi_mirror_char): Revert last change: an int is
4043 definitely wide enough here.
4044
42b2a986 40452012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4046
42b2a986 4047 Fix integer width and related bugs (Bug#9874).
eb106a49 4048 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4049 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4050 (string_bytes, check_sblock, allocate_string_data):
4051 (compact_small_strings, Fmake_bool_vector, make_string)
4052 (make_unibyte_string, make_multibyte_string)
4053 (make_string_from_bytes, make_specified_string)
4054 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4055 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4056 (mark_vectorlike):
4057 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4058 (allocate_pseudovector):
4059 Use int, not EMACS_INT, where int is wide enough.
4060 (inhibit_garbage_collection, Fgarbage_collect):
4061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4062 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4063 int might not be wide enough.
4064 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4065 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4066 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4067 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4068 (bidi_level_of_next_char, bidi_move_to_visually_next):
4069 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4070 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4071 (Fkill_buffer, Fset_buffer_major_mode)
4072 (advance_to_char_boundary, Fbuffer_swap_text)
4073 (Fset_buffer_multibyte, overlays_at, overlays_in)
4074 (overlay_touches_p, struct sortvec, record_overlay_string)
4075 (overlay_strings, recenter_overlay_lists)
4076 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4077 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4078 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4079 (Foverlay_recenter, last_overlay_modification_hooks_used)
4080 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4082 (validate_region): Omit unnecessary test for b <= e,
4083 since that's guaranteed by the previous test.
d311d28c
PE
4084 (adjust_overlays_for_delete): Avoid pos + length overflow.
4085 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4086 (report_overlay_modification):
4087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4088 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4089 Omit pointer cast, which isn't needed anyway, and doesn't work
4090 after the EMACS_INT -> ptrdiff_t change.
02481186 4091 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4092 * buffer.h: Adjust decls to match defn changes elsewhere.
4093 (struct buffer_text, struct buffer):
4094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4095 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4096 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4097 not int, to avoid needless 32-bit limit on 64-bit hosts.
4098 (exec_byte_code): Use tighter memory-full test, one that checks
4099 for alloca overflow. Don't compute the address of the object just
4100 before an array, as that's not portable. Use EMACS_INT, not
4101 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4102 * callint.c (Fcall_interactively):
4103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4104 * callproc.c (call_process_kill, Fcall_process):
4105 Don't assume pid_t fits into an Emacs fixnum.
4106 (call_process_cleanup, Fcall_process, child_setup):
4107 Don't assume pid_t fits into int.
4108 (call_process_cleanup, Fcall_process, delete_temp_file)
4109 (Fcall_process_region):
4110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4111 (Fcall_process): Simplify handling of volatile integers.
4112 Use int, not EMACS_INT, where int will do.
4113 * casefiddle.c (casify_object, casify_region, operate_on_word)
4114 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4116 (casify_object): Avoid integer overflow when overallocating buffer.
4117 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4118 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4119 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4120 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4121 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4122 integers are now checked earlier. All uses replaced with XINT.
4123 (ccl_driver):
4124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4125 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4126 (ccl_driver, Fregister_code_conversion_map):
4127 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4128 (resolve_symbol_ccl_program): Check that vector header is in range.
4129 Always copy the vector, so that we can check its contents reliably
4130 now rather than having to recheck each instruction as it's being
4131 executed. Check that vector words fit in 'int'.
4132 (ccl_get_compiled_code, Fregister_ccl_program)
4133 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4134 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4135 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4136 contents are in range.
4137 (Fccl_execute_on_string): Check that status is in range.
4138 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4139 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4140 Accept and return EMACS_INT, not int, because callers can pass values
4141 out of 'int' range.
4142 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4143 (multibyte_chars_in_text, parse_str_as_multibyte)
4144 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4145 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4146 (string_escape_byte8, Fget_byte):
4147 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4148 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4149 avoid mishandling large integers.
4150 * character.h: Adjust decls to match defn changes elsewhere.
4151 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4152 (Ffind_charset_region):
4153 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4154 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4155 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4156 Don't assume fixnum fits in int.
d311d28c
PE
4157 (load_charset_map_from_vector, Fmap_charset_chars):
4158 Remove now-unnecessary CHECK_NATNUMs.
4159 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4160 Don't rely on undefined behavior with signed left shift overflow.
4161 Don't assume unsigned int fits into fixnum, or that fixnum fits
4162 into unsigned int. Don't require max_code to be a valid fixnum;
4163 that's not true for gb10830 4-byte on a 32-bit host. Allow
4164 invalid_code to be a cons, for the same reason. Require code_offset
4165 to be a character. Avoid int overflow if max_char is close
4166 to INT_MAX.
4167 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4168 this is intended anyway and avoids some undefined behavior.
4169 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4170 INDEX_TO_CODE_POINT, as that's what it expects.
4171 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4172 * charset.h (DECODE_CHAR): Return int, not unsigned;
4173 this is what was intended anyway, and it avoids undefined behavior.
4174 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4175 integer-overflow issues.
4176 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4177 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4178 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4179 * chartab.c (Fmake_char_table, Fset_char_table_range)
4180 (uniprop_get_decoder, uniprop_get_encoder):
4181 Don't assume fixnum fits in int.
4182 * cmds.c (move_point): New function, that does the gist of
4183 Fforward_char and Fbackward_char, but does so while checking
4184 for integer overflow more accurately.
c96e5d6a 4185 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4186 (Fforward_line, Fend_of_line, internal_self_insert)
4187 (internal_self_insert):
4188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4189 Fix a FIXME, by checking for integer overflow when calculating
4190 target_clm and actual_clm.
4191 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4192 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4193 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4194 (coding_alloc_by_making_gap, alloc_destination)
4195 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4196 (encode_coding_utf_16, detect_coding_emacs_mule)
4197 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4198 (detect_coding_iso_2022, decode_coding_iso_2022)
4199 (encode_invocation_designation, encode_designation_at_bol)
4200 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4201 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4202 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4203 (encode_coding_ccl, encode_coding_raw_text)
4204 (detect_coding_charset, decode_coding_charset)
4205 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4206 (produce_composition, produce_charset, produce_annotation)
4207 (decode_coding, handle_composition_annotation)
4208 (handle_charset_annotation, consume_chars, decode_coding_gap)
4209 (decode_coding_object, encode_coding_object, detect_coding_system)
4210 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4211 (code_convert_region, code_convert_string)
8f50130c
PE
4212 (Fdefine_coding_system_internal)
4213 (coding_set_source, coding_set_destination):
d311d28c
PE
4214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4215 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4216 (Fdefine_coding_system_internal):
4217 Don't assume fixnums fit in int.
4218 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4219 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4220 (Funencodable_char_position, Fcheck_coding_systems_region)
4221 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4222 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4223 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4224 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4225 Don't access memory outside of the args array.
d311d28c 4226 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4227 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4228 result of ENCODE_CHAR.
d311d28c
PE
4229 * coding.h: Adjust decls to match defn changes elsewhere.
4230 (struct coding_system):
4231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4232 * composite.c (get_composition_id, find_composition)
4233 (run_composition_function, update_compositions)
4234 (compose_text, composition_gstring_put_cache)
4235 (composition_gstring_p, composition_gstring_width)
4236 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4237 (composition_compute_stop_pos, composition_reseat_it)
4238 (composition_update_it, struct position_record)
4239 (find_automatic_composition, composition_adjust_point)
4240 (Fcomposition_get_gstring, Ffind_composition_internal):
4241 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4242 (update_compositions):
4243 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4244 * composite.h: Adjust decls to match defn changes elsewhere.
4245 (struct composition):
4246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4247 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4248 Do not attempt to compute the address of the object just before a
4249 buffer; this is not portable.
4250 (Faref, Faset):
4251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4252 (Faset): Use int, not EMACS_INT, where int is wide enough.
4253 (Fstring_to_number): Don't assume fixnums fit in int.
4254 (Frem): Don't assume arg is nonnegative.
4255 * dbusbind.c (xd_append_arg): Check for integers out of range.
4256 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4257 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4258 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4259 (xd_get_connection_references): Return ptrdiff_t, not int.
4260 All uses changed.
4261 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4262 (xd_read_message_1):
4263 Use int, not unsigned, where the dbus API uses int.
4264 (Fdbus_message_internal): Don't overflow mtype.
4265 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4266 * dired.c (directory_files_internal, file_name_completion, scmp)
4267 (file_name_completion_stat):
4268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4269 (file_name_completion): Don't overflow matchcount.
4270 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4271 * dispextern.h: Adjust decls to match defn changes elsewhere.
4272 (struct text_pos, struct glyph, struct bidi_saved_info)
4273 (struct bidi_string_data, struct bidi_it, struct composition_it)
4274 (struct it):
4275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4276 (struct display_pos, struct composition_it, struct it):
4277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4278 * dispnew.c (increment_matrix_positions)
4279 (increment_row_positions, mode_line_string)
4280 (marginal_area_string):
4281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4282 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4283 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4284 (duration_to_sec_usec): New function, to check for overflow better.
4285 (Fsleep_for, sit_for): Use it.
4286 * doc.c (get_doc_string, store_function_docstring):
4287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4288 (get_doc_string, Fsnarf_documentation):
4289 Use int, not EMACS_INT, where int is wide enough.
4290 (get_doc_string):
4291 Use SAFE_ALLOCA, not alloca.
4292 Check for overflow when converting EMACS_INT to off_t.
4293 * doprnt.c (doprnt):
4294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4295 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4296 Don't assume uid_t fits into fixnum.
4297 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4298 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4299 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4300 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4301 (general_insert_function)
4302 (Finsert_char, make_buffer_string, make_buffer_string_both)
4303 (update_buffer_properties, Fbuffer_substring)
4304 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4305 (Fsubst_char_in_region, check_translation)
4306 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4307 (transpose_markers, Ftranspose_regions):
4308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4309 (clip_to_bounds): Move to lisp.h as an inline function).
4310 (Fconstrain_to_field): Don't assume integers are nonnegative.
4311 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4312 (Fsubst_char_in_region, Fsave_restriction):
4313 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4314 (Femacs_pid): Don't assume pid_t fits into fixnum.
4315 (lo_time): Use int, not EMACS_INT, when int suffices.
4316 (lisp_time_argument): Check for usec out of range.
4317 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4318 (Fuser_login_name, Fuser_full_name): Signal an error
4319 if a uid argument is out of range, rather than relying on
4320 undefined behavior.
c8d5c857
PE
4321 (Fformat_time_string): Remove now-unnecessary check.
4322 lisp_time_argument checks for out-of-range usec now.
243e0530 4323 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4324 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4325 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4326 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4327 (init_cmdargs, Fdump_emacs):
4328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4329 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4330 the bottom (typically) 32 bits of the fixnum.
4331 * eval.c (specpdl_size, call_debugger):
4332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4333 (when_entered_debugger, Fbacktrace_debug):
4334 Don't assume fixnum can fit in int.
4335 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4336 the object just before a buffer; this is not portable.
4337 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4338 (grow_specpdl, unbind_to):
4339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4340 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4341 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4342 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4343 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4344 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4346 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4347 (a_write, e_write):
4348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4349 (Fcopy_file, non_regular_nbytes, read_non_regular)
4350 (Finsert_file_contents):
4351 Use int, not EMACS_INT, where int is wide enough.
4352 (READ_BUF_SIZE): Verify that it fits in int.
4353 (Finsert_file_contents): Check that counts are in proper range,
4354 rather than assuming fixnums fit into ptrdiff_t etc.
4355 Don't assume fixnums fit into int.
125b3835 4356 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4357 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4358 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4359 (string_char_to_byte, string_byte_to_char)
4360 (string_make_multibyte, string_to_multibyte)
4361 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4362 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4363 (substring_both, Fdelete, internal_equal, Ffillarray)
4364 (Fclear_string, mapcar1)
4365 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4366 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4367 (larger_vector, make_hash_table, maybe_resize_hash_table)
4368 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4369 (Fmaphash, secure_hash):
4370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4371 (concat): Check for string index and length overflow.
4372 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4373 (Frequire):
4374 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4375 (larger_vector): New API (vec, incr_min, size_max) replaces old
4376 one (vec, new_size, init). This catches size overflow.
4377 INIT was removed because it was always Qnil.
4378 All callers changed.
4379 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4380 the upper bound on a hash table index size.
4381 (make_hash_table, maybe_resize_hash_table): Use it.
4382 (secure_hash): Computer start_byte and end_byte only after
4383 they're known to be in ptrdiff_t range.
4384 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4385 (Ffont_get_glyphs, Ffont_at):
4386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4387 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4388 (Flist_fonts, Fopen_font):
4389 Don't assume fixnum can fit in int.
4390 (check_gstring): Don't assume index can fit in int.
4391 (font_match_p): Check that fixnum is a character, not a nonnegative
4392 fixnum, since the later code needs to stuff it into an int.
4393 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4394 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4395 conversion overflow issues.
4396 (Fopen_font): Check for integer out of range.
4397 (Ffont_get_glyphs): Don't assume index can fit in int.
4398 * font.h: Adjust decls to match defn changes elsewhere.
4399 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4400 integer overflow.
4401 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4402 printmax_t, where ptrdiff_t is wide enough.
4403 (Finternal_char_font):
4404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4405 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4406 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4407 (Fset_frame_position, x_set_frame_parameters)
4408 (x_set_line_spacing, x_set_border_width)
4409 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4410 Check that fixnums are in proper range for system types.
4411 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4413 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4414 Use SAFE_ALLOCA_LISP, not alloca.
4415 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4416 intptr_t is wide enough.
4417 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4418 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4419 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4420 Check for fixnum out of range.
4421 * ftfont.c (ftfont_list): Don't assume index fits in int.
4422 Check that fixnums are in proper range for system types.
4423 (ftfont_shape_by_flt):
4424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4425 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4427 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4428 Check that fixnums are in proper range for system types.
4429 * gnutls.h: Adjust decls to match defn changes elsewhere.
4430 * gtkutil.c (xg_dialog_run):
4431 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4432 (update_frame_tool_bar):
4433 Check that fixnums are in proper range for system types.
4434 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4435 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4436 * indent.c (last_known_column, last_known_column_point):
4437 (current_column_bol_cache):
4438 (skip_invisible, current_column, check_display_width):
4439 (check_display_width, scan_for_column, current_column_1)
4440 (Findent_to, Fcurrent_indentation, position_indentation)
4441 (indented_beyond_p, Fmove_to_column, compute_motion):
4442 (Fcompute_motion, Fvertical_motion):
4443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4444 (last_known_column_modified): Use EMACS_INT, not int.
4445 (check_display_width):
4446 (Fcompute_motion):
4447 Check that fixnums and floats are in proper range for system types.
4448 (compute_motion): Don't assume index or fixnum fits in int.
4449 (compute_motion, Fcompute_motion):
4450 Use int, not EMACS_INT, when it is wide enough.
4451 (vmotion): Omit local var start_hpos that is always 0; that way
4452 we don't need to worry about overflow in expressions involving it.
4453 * indent.h: Adjust decls to match defn changes elsewhere.
4454 (struct position):
4455 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4456 Use int, not EMACS_INT, where int is wide enough.
4457 Remove unused members ovstring_chars_done and tab_offset;
4458 all uses removed.
4459 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4460 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4461 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4462 (make_gap, copy_text, insert, insert_and_inherit)
4463 (insert_before_markers, insert_before_markers_and_inherit)
4464 (insert_1, count_combining_before, count_combining_after)
4465 (insert_1_both, insert_from_string)
4466 (insert_from_string_before_markers, insert_from_string_1)
4467 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4468 (adjust_after_replace, adjust_after_insert, replace_range)
4469 (replace_range_2, del_range, del_range_1, del_range_byte)
4470 (del_range_both, del_range_2, modify_region)
4471 (prepare_to_modify_buffer, signal_before_change)
4472 (signal_after_change, Fcombine_after_change_execute):
4473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4474 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4475 (balance_an_interval, split_interval_right, split_interval_left)
4476 (find_interval, next_interval, update_interval)
4477 (adjust_intervals_for_insertion, delete_node, delete_interval)
4478 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4479 (static_offset_intervals, offset_intervals)
4480 (merge_interval_right, merge_interval_left, make_new_interval)
4481 (graft_intervals_into_buffer, temp_set_point_both)
4482 (temp_set_point, set_point, adjust_for_invis_intang)
4483 (set_point_both, move_if_not_intangible, get_property_and_range)
4484 (get_local_map, copy_intervals, copy_intervals_to_string)
4485 (compare_string_intervals, set_intervals_multibyte_1):
4486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4487 * intervals.h: Adjust decls to match defn changes elsewhere.
4488 (struct interval):
4489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4490 * keyboard.c (this_command_key_count, this_single_command_key_start)
4491 (before_command_key_count, before_command_echo_length, echo_now)
4492 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4493 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4494 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4495 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4497 (last_non_minibuf_size, last_point_position, echo_truncate)
4498 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4499 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4500 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4501 (stuff_buffered_input):
4502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4503 (last_auto_save, command_loop_1, read_char):
4504 Use EMACS_INT, not int, to avoid integer overflow.
4505 (record_char): Avoid overflow in total_keys computation.
4506 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4507 * keyboard.h: Adjust decls to match defn changes elsewhere.
4508 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4509 (Fkey_description, Fdescribe_vector, Flookup_key):
4510 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4511 (click_position): New function, to check that positions are in range.
4512 (Fcurrent_active_maps):
4513 (describe_command):
4514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4515 (Faccessible_keymaps, Fkey_description):
4516 (preferred_sequence_p):
4517 Don't assume fixnum can fit into int.
4518 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4519 Check for integer overflow in size calculations.
4520 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4521 avoid mishandling large integers.
4522 * lisp.h: Adjust decls to match defn changes elsewhere.
4523 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4524 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4525 (struct Lisp_Marker):
4526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4527 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4528 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4529 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4530 All callers changed.
4531 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4532 Assume the arg has valid form, since it always does.
4533 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4534 unsigned integer system type.
4535 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4536 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4538 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4539 (duration_to_sec_usec): New decl.
4540 * lread.c (read_from_string_index, read_from_string_index_byte)
4541 (read_from_string_limit, readchar, unreadchar, openp)
4542 (read_internal_start, read1, oblookup):
4543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4544 (Fload, readevalloop, Feval_buffer, Feval_region):
4545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4546 (openp): Check for out-of-range argument to 'access'.
4547 (read1): Use int, not EMACS_INT, where int is wide enough.
4548 Don't assume fixnum fits into int.
6efdadfd 4549 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4550 (read_filtered_event): Use duration_to_sec_usec
4551 to do proper overflow checking on durations.
d311d28c
PE
4552 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4553 in size calculation.
4554 (Fexecute_kbd_macro):
4555 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4556 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4557 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4558 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4559 (set_marker_both, set_marker_restricted_both, marker_position)
4560 (marker_byte_position, Fbuffer_has_markers_at):
4561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4562 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4563 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4564 It now merely ensures that the menu is large enough, without
4565 necessarily growing it, as this avoids some integer overflow issues.
4566 All callers changed.
4567 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4568 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4569 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4570 Use SAFE_ALLOCA_LISP, not alloca.
4571 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4572 to EMACS_INT. Check that fixnums are in proper range for system types.
4573 * minibuf.c (minibuf_prompt_width, string_to_object)
4574 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4575 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4577 (get_minibuffer, read_minibuf_unwind):
4578 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4579 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4580 this simplifies overflow checking. All callers changed.
4581 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4582 (Ftest_completion):
4583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4584 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4585 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4586 Check that fixnums are in proper range for system types.
4587 (Fx_create_frame, Fx_show_tip):
4588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4589 * nsfont.m (ns_findfonts, nsfont_list_family):
4590 Don't assume fixnum fits in long.
4591 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4593 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4594 wide enough.
17fdb222 4595 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4597 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4598 (PRINTDECLARE, PRINTPREPARE):
4599 (strout, print_string):
4600 (print, print_preprocess, print_check_string_charset_prop)
4601 (print_object):
4602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4603 (PRINTDECLARE):
4604 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4606 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4607 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4608 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4609 (print_error_message): Use SAFE_ALLOCA, not alloca.
4610 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4611 (print_depth, new_backquote_output, print_number_index):
4612 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4613 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4614 (Fset_process_window_size, Fformat_network_address)
4615 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4616 (sigchld_handler):
d311d28c 4617 Check that fixnums are in proper range for system types.
d44287d4 4618 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4619 Check for process-ids out of pid_t range rather than relying on
4620 undefined behavior.
e4d81efc 4621 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4622 (Fformat_network_address, read_process_output, send_process)
4623 (Fprocess_send_region, status_notify):
4624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4625 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4626 (wait_reading_process_output, read_process_output, exec_sentinel):
4627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4628 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4629 (Faccept_process_output): Use duration_to_sec_usec to do proper
4630 overflow checking on durations.
dde14581
PE
4631 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4632 Don't assume pid_t fits in int.
02481186
PE
4633 * process.h (struct Lisp_Process): Members tick and update_tick
4634 are now of type EMACS_INT, not int.
b62b53e8
PE
4635 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4636 configured --with-wide-int.
d311d28c
PE
4637 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4638 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4639 * search.c (looking_at_1, string_match_1):
4640 (fast_string_match, fast_c_string_match_ignore_case)
4641 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4642 (scan_newline, find_before_next_newline, search_command)
4643 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4644 (set_search_regs, wordify):
4645 (Freplace_match):
4646 (Fmatch_data):
4647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4648 (string_match_1, search_buffer, set_search_regs):
4649 (Fmatch_data):
4650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4651 (wordify): Check for overflow in size calculation.
4652 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4653 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4654 Check that fixnums are in proper range for system types.
4655 * sound.c (struct sound_device)
4656 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4658 (Fplay_sound_internal):
4659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4660 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4661 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4662 (Fparse_partial_sexp):
4663 Don't assume fixnums can fit in int.
4664 (struct lisp_parse_state, find_start_pos, find_start_value)
4665 (find_start_value_byte, find_start_begv)
4666 (update_syntax_table, char_quoted, dec_bytepos)
4667 (find_defun_start, prev_char_comend_first, back_comment):
4668 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4669 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4671 (Finternal_describe_syntax_value): Check that match_lisp is a
4672 character, not an integer, since the code stuffs it into int.
4673 (scan_words, scan_sexps_forward):
4674 Check that fixnums are in proper range for system types.
4675 (Fforward_word):
4676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4677 (scan_sexps_forward):
4678 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4679 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4680 * syntax.h: Adjust decls to match defn changes elsewhere.
4681 (struct gl_state_s):
4682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4683 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4684 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4685 * sysdep.c (wait_for_termination_1, wait_for_termination)
4686 (interruptible_wait_for_termination, mkdir):
4687 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4688 (emacs_read, emacs_write):
4689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4690 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4691 and double all fit in int.
d311d28c
PE
4692 * term.c (set_tty_color_mode):
4693 Check that fixnums are in proper range for system types.
4694 * termhooks.h (struct input_event):
4695 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4696 * textprop.c (validate_interval_range, interval_of)
4697 (Fadd_text_properties, set_text_properties_1)
4698 (Fremove_text_properties, Fremove_list_of_text_properties)
4699 (Ftext_property_any, Ftext_property_not_all)
4700 (copy_text_properties, text_property_list, extend_property_ranges)
4701 (verify_interval_modification):
4702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4703 (Fnext_single_char_property_change)
4704 (Fprevious_single_char_property_change):
4705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4706 (copy_text_properties):
4707 Check for integer overflow in index calculation.
d311d28c
PE
4708 * undo.c (last_boundary_position, record_point, record_insert)
4709 (record_delete, record_marker_adjustment, record_change)
4710 (record_property_change):
4711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4712 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4714 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4715 (Fx_hide_tip, Fx_file_dialog):
4716 * w32menu.c (set_frame_menubar):
4717 Use ptrdiff_t, not int, for consistency with rest of code.
4718 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4719 (select_window, Fdelete_other_windows_internal)
4720 (window_scroll_pixel_based, window_scroll_line_based)
4721 (Frecenter, Fset_window_configuration):
4722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4723 (Fset_window_hscroll, run_window_configuration_change_hook)
4724 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4725 (Fscroll_other_window, Frecenter):
d311d28c
PE
4726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4727 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4728 Don't assume fixnum fits in int.
4729 (Fset_window_scroll_bars):
4730 Check that fixnums are in proper range for system types.
4731 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4732 (string_pos, c_string_pos, number_of_chars, init_iterator)
4733 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4734 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4735 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4736 (face_before_or_after_it_pos, handle_invisible_prop)
4737 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4738 (display_prop_intangible_p, string_buffer_position_lim)
4739 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4740 (get_overlay_strings_1, get_overlay_strings)
4741 (iterate_out_of_display_property, forward_to_next_line_start)
4742 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4743 (get_next_display_element, set_iterator_to_next)
4744 (get_visually_first_element, compute_stop_pos_backwards)
4745 (handle_stop_backwards, next_element_from_buffer)
4746 (move_it_in_display_line_to, move_it_in_display_line)
4747 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4748 (add_to_log, message_dolog, message_log_check_duplicate)
4749 (message2, message2_nolog, message3, message3_nolog
4750 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4751 (current_message_1, truncate_echo_area, truncate_message_1)
4752 (set_message, set_message_1, store_mode_line_noprop)
4753 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4754 (text_outside_line_unchanged_p, check_point_in_composition)
4755 (reconsider_clip_changes)
4756 (redisplay_internal, set_cursor_from_row, try_scrolling)
4757 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4758 (redisplay_window, find_last_unchanged_at_beg_row)
4759 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4760 (trailing_whitespace_p, find_row_edges, display_line)
4761 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4762 (display_mode_element, store_mode_line_string)
4763 (pint2str, pint2hrstr, decode_mode_spec)
4764 (display_count_lines, display_string, draw_glyphs)
4765 (x_produce_glyphs, x_insert_glyphs)
4766 (rows_from_pos_range, mouse_face_from_buffer_pos)
4767 (fast_find_string_pos, mouse_face_from_string_pos)
4768 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4770 (safe_call, init_from_display_pos, handle_fontified_prop)
4771 (handle_single_display_spec, load_overlay_strings)
4772 (with_echo_area_buffer, setup_echo_area_for_printing)
4773 (display_echo_area, echo_area_display)
4774 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4775 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4776 (redisplay_window, dump_glyph_row, display_mode_line)
4777 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4778 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4779 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4780 (handle_single_display_spec, build_desired_tool_bar_string)
4781 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4782 (get_specified_cursor_type):
4783 Check that fixnums are in proper range for system types.
4784 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4785 (Flookup_image_map):
4786 Don't assume fixnums fit in int.
4787 (compare_overlay_entries):
4788 Avoid mishandling comparisons due to subtraction overflow.
4789 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4790 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4791 (handle_tool_bar_click):
4792 Use int, not unsigned, since we prefer signed and the signedness
4793 doesn't matter here.
4794 (get_next_display_element, next_element_from_display_vector):
4795 Use int, not EMACS_INT, when int is wide enough.
4796 (start_hourglass): Use duration_to_sec_usec to do proper
4797 overflow checking on durations.
4798 * xfaces.c (Fbitmap_spec_p):
4799 Check that fixnums are in proper range for system types.
4800 (compare_fonts_by_sort_order):
4801 Avoid mishandling comparisons due to subtraction overflow.
4802 (Fx_family_fonts, realize_basic_faces):
4803 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4804 (Fx_family_fonts):
4805 Don't assume fixnum fits in int.
4806 Use SAFE_ALLOCA_LISP, not alloca.
4807 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4808 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4809 (face_at_buffer_position, face_for_overlay_string)
4810 (face_at_string_position):
4811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4812 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4813 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4814 (Fx_show_tip):
4815 Check that fixnums are in proper range for system types.
4816 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4817 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4819 (Fx_change_window_property): Don't assume fixnums fit in int.
4820 * xfont.c (xfont_chars_supported):
4821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4822 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4823 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4825 * xml.c (parse_region):
4826 * xrdb.c (magic_file_p):
4827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4828 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4829 (x_get_local_selection, x_reply_selection_request)
4830 (x_handle_selection_request, wait_for_property_change):
4831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4832 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4833 short is wide enough.
4834 (x_send_client_event): Don't assume fixnum fits in int.
4835 * xterm.c (x_x_to_emacs_modifiers):
4836 Don't assume EMACS_INT overflows nicely into int.
4837 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4838 may come from Lisp.
4839 (handle_one_xevent): NATNUMP can eval its arg twice.
4840 (x_connection_closed):
4841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4842 * xterm.h: Adjust decls to match defn changes elsewhere.
4843 (struct scroll_bar): Use struct vectorlike_header
4844 rather than rolling our own approximation.
4845 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4846
c6574eb5
GM
48472012-05-25 Glenn Morris <rgm@gnu.org>
4848
4849 * lisp.mk (lisp): Update for more files being compiled now.
4850
e8d32c7e
SM
48512012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4852
48def666
SM
4853 * lread.c: Remove `read_pure' which makes no difference.
4854 (read_pure): Remove var.
4855 (unreadpure): Remove function.
4856 (readevalloop): Don't call read_list with -1 flag.
4857 (read1, read_vector): Don't test read_pure any more.
4858 (read_list): Simplify.
4859
e8d32c7e
SM
4860 * fileio.c, character.h: Minor style tweaks.
4861
4b2addb7
DA
48622012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4863
4864 * window.h (clip_changed): Remove useless declaration.
4865
584461b2
JB
48662012-05-22 Juanma Barranquero <lekktu@gmail.com>
4867
4868 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4869 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4870
34374650
PE
48712012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4872
4873 Remove src/m/*.
4874 This directory predates autoconf and is no longer needed nowadays.
4875 Move its few remaining bits of functionality to where they're needed.
4876 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4877 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4878 * m/template.h: Remove.
4879 * Makefile.in (M_FILE): Remove. All uses removed.
4880 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4881 * lisp.h (USE_LSB_TAG):
4882 * mem-limits.h (EXCEEDS_LISP_PTR):
4883 Use VAL_MAX, not VALBITS, in #if.
4884 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4885 (EMACS_UINT): Define unconditionally now.
4886 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4887 (BITS_PER_EMACS_INT): New constants, replacing
4888 what used to be in config.h, but not useful in #if.
4889 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4890 define them any more.
4891 (VAL_MAX): New macro.
4892 (VALMASK): Use it.
4893 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4894 BITS_PER_EMACS_INT, in #if.
4895 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4896 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4897 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4898 * s/ms-w32.h (DATA_START):
4899 Move here from removed file m/intel386.h.
4900 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4901 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4902
261cb4bb
PE
49032012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4904
4905 Assume C89 or later.
4906 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4907 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4908 (xrealloc):
4909 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4910 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4911 * textprop.c, tparam.c (NULL): Remove.
4912 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4913 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4914 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4915 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4916 * xterm.c (input_signal_count): Assume volatile works.
4917
ff23cd9f
KB
49182012-05-21 Ken Brown <kbrown@cornell.edu>
4919
4920 * xgselect.c (xg_select): Fix first argument in call to 'select'
4921 (bug#11508).
4922
1b170bc6
KB
49232012-05-20 Ken Brown <kbrown@cornell.edu>
4924
4925 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4926 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4927
b2f4d39f
KB
49282012-05-19 Ken Brown <kbrown@cornell.edu>
4929
4930 * xfns.c (x_in_use): Remove `static' qualifier.
4931 * xterm.h (x_in_use): Declare.
4932 * xgselect.c: Include xterm.h.
4933 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4934 and `display_arg' (bug#9754).
4935
003fdae2
PE
49362012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4937
9232a6d9
PE
4938 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4939
003fdae2
PE
4940 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4941 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4942
784b56e2
EZ
49432012-05-18 Eli Zaretskii <eliz@gnu.org>
4944
4945 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4946
4947 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4948 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4949
4950 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4951 reference to image_cache->refcount.
4952 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4953
a0a79cde
JL
49542012-05-17 Juri Linkov <juri@jurta.org>
4955
4956 * search.c (Fword_search_regexp, Fword_search_backward)
4957 (Fword_search_forward, Fword_search_backward_lax)
4958 (Fword_search_forward_lax): Move functions to isearch.el
4959 (bug#10145, bug#11381).
4960
b0572523
PE
49612012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4962
4963 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4964
9660f5fc
SM
49652012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4966
4967 * lread.c (init_obarray): Declare Qt and Qnil as special.
4968
4374de83
GM
49692012-05-14 Glenn Morris <rgm@gnu.org>
4970
4971 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4972 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4973
dc44c39a
PE
49742012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4975
078c97cb
PE
4976 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4977
dc44c39a
PE
4978 * unexaix.c: Port to more-recent AIX compilers.
4979 (report_error, report_error_1, make_hdr, copy_sym)
4980 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4981 Make arguments const char *, not char *, to avoid violations of C
4982 standard and to fix some AIX warnings reported by Gilles Pion.
4983
e18afed7 49842012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4985
4986 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4987 already have overlays loaded.
4988 (handle_single_display_spec): Before returning without displaying
4989 fringe bitmap, synchronize the bidi iterator with the main display
4990 iterator, by calling iterate_out_of_display_property.
4991 (iterate_out_of_display_property): Detect buffer iteration by
4992 testing that it->string is a Lisp string.
4993 (get_next_display_element): When the current object is exhausted,
4994 and there's something on it->stack, call set_iterator_to_next to
4995 proceed with what's on the stack, instead of returning zero.
4996 (set_iterator_to_next): If called at the end of a Lisp string,
4997 proceed to consider_string_end without incrementing string
4998 position. Don't increment display vector index past the end of
4999 the display vector. (Bug#11417)
c8fb9dc6
EZ
5000 (pos_visible_p): Don't report a position visible when move_it_to
5001 stopped at the last line of window, which happens to be scanned
5002 backwards by the bidi iteration. (Bug#11464)
ac268e67 5003
e18afed7 50042012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5005
5006 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5007 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5008 are on a TTY, and thus unable to display on the fringes.
5009 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5010 so we need to signal to the caller that this is a "replacing"
5011 display spec. This fixes display when the spec is invalid or we
5012 are on a TTY.
5013
e18afed7 50142012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5015
5016 * unexaix.c (make_hdr): Fix typo in prototype.
5017 This bug broke the build on AIX. Problem reported by Gilles Pion.
5018
9d0a235a
MA
50192012-05-14 Michael Albinus <michael.albinus@gmx.de>
5020
5021 * keyboard.c (kbd_buffer_get_event): Read special events also in
5022 batch mode. (Bug#11415)
5023
9e6b06ed
GM
50242012-05-12 Glenn Morris <rgm@gnu.org>
5025
5026 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5027
c1a1d7a3
EZ
50282012-05-12 Eli Zaretskii <eliz@gnu.org>
5029
5030 * lisp.mk (lisp): Add newcomment.elc.
5031
3fe7cdc8
GM
50322012-05-12 Glenn Morris <rgm@gnu.org>
5033
5034 * Makefile.in (MKDIR_P): New, set by configure.
5035 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5036
53f7d2c0
PE
50372012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5038
5039 Remove unused function hourglass_started.
5040 * dispextern.h (hourglass_started):
5041 * w32fns.c (hourglass_started):
5042 * xdisp.c (hourglass_started): Remove.
5043
75aafb17
JB
50442012-05-10 Juanma Barranquero <lekktu@gmail.com>
5045
5046 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5047 Update dependencies.
5048
12959e8e
PE
50492012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5050
97107e2e
PE
5051 * xgselect.c (xg_select): Put maxfds+1 into a var.
5052 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5053
12959e8e
PE
5054 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5055
836d29b3
DA
50562012-05-10 Dave Abrahams <dave@boostpro.com>
5057
5058 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5059 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5060
5cb67954
MA
50612012-05-09 Michael Albinus <michael.albinus@gmx.de>
5062
5063 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5064 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5065 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5066 Initialize xd_registered_buses.
5067
3478ec45
PE
50682012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5069
b263a6b0
PE
5070 Untag more efficiently if USE_LSB_TAG.
5071 This is based on a proposal by YAMAMOTO Mitsuharu in
5072 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5073 For an admittedly artificial (nth 8000 longlist) benchmark on
5074 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5075 Emacs's overall text size by 1%.
5076 * lisp.h (XUNTAG): New macro.
5077 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5078 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5079 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5080 * eval.c (Fautoload):
5081 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5082 * frame.h (XFRAME): Use XUNTAG.
5083
3478ec45
PE
5084 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5085 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5086 Remove unportable assumptions about print widths of types like
5087 dbus_uint32_t.
5088 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5089 intptr_t when converting between pointer and integer, to avoid GCC
5090 warnings about wrong width.
5091
666b903b 50922012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5093
5094 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5095 stack for each reader_thread, instead of defaulting to 8MB
5096 determined by the linker. This avoids failures in creating
5097 subprocesses on Windows 7, see the discussion in this thread:
5098 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5099
b120cc17
JC
51002012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5101
5102 Fix up display of the *Minibuf-0* buffer in the mini window.
5103 * keyboard.c (read_char): Don't clear the echo area if there's no
5104 message to clear.
5105 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5106 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5107
9a4b36f8
MA
51082012-05-07 Michael Albinus <michael.albinus@gmx.de>
5109
5110 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5111 batch mode.
5112
e5f9458f
CY
51132012-05-06 Chong Yidong <cyd@gnu.org>
5114
5115 * lisp.mk (lisp): Update.
5116
eceeb5fc 51172012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5118
5119 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5120
71873e2b
SM
51212012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5122
5123 * data.c (PUT_ERROR): New macro.
5124 (syms_of_data): Use it. Add new error type `user-error'.
5125 * undo.c (user_error): New function.
5126 (Fprimitive_undo): Use it.
5127 * print.c (print_error_message): Adjust print style for `user-error'.
5128 * keyboard.c (user_error): New function.
5129 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5130
ab0fa4e4
PE
51312012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5132
5133 Do not limit current-time-string to years 1000..9999.
5134 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5135 (Fcurrent_time_string): Support any year that is supported by the
5136 underlying localtime representation. Don't use asctime, as it
5137 has undefined behavior for years outside the range -999..9999.
5138
7ed806a7
PE
51392012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5140
5141 Fix race conditions involving setenv, gmtime, localtime, asctime.
5142 Without this fix, interrupts could mess up code that uses these
5143 nonreentrant functions, since setting TZ invalidates existing
5144 tm_zone or tzname values, and since most of these functions return
5145 pointers to static storage.
5146 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5147 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5148 Grow the critical sections to include not just invoking
5149 localtime/gmtime, but also accessing these functions' results
5150 including their tm_zone values if any, and any related TZ setting.
5151 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5152 so that the struct tm is saved in the critical section.
5153 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5154 motivated by the fact that memory allocation needs to be outside
5155 the critical section.
5156
0c16dfed
DA
51572012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5158
5159 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5160 with RESET_INTERVAL.
5161
5162 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5163 Remove duplicated buffer name initialization.
5164
3f83ace8
JM
51652012-05-02 Jim Meyering <jim@meyering.net>
5166
5167 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5168
c7b8541e
JM
5169 * xfns.c (x_window): Use xstrdup (Bug#11375).
5170
90207a15 51712012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5172
5173 * xdisp.c (pos_visible_p): If already at a newline from the
5174 display string before the 'while' loop, don't walk back the glyphs
5175 from it3.glyph_row. Solves assertion violation when the display
5176 string begins with a newline (egg.el). (Bug#11367)
5177
b593d6a9
AH
51782012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5179
5180 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5181 Move to simple.el.
5182
4737362e
GM
51832012-05-01 Glenn Morris <rgm@gnu.org>
5184
99cf43f9
GM
5185 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5186 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5187 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5188 All were removed before 23.1.
5189
9311dcff
GM
5190 * dispnew.c: Remove HAVE_LIBNCURSES test;
5191 it is always true on relevant platforms.
5192
4d5c6349
GM
5193 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5194 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5195
4737362e
GM
5196 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5197
74dd3a6b
AS
51982012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5199
5200 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5201 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5202 Remove.
5203
13c379ee
PE
52042012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5205
5206 Do not avoid creating empty evaporating overlays (Bug#9642).
5207 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5208 That is, do not delete an evaporating overlay if it becomes
5209 empty after its bounds are adjusted to fit within its buffer.
5210 This fix caused other problems, and I'm reverting it until we get
5211 to the bottom of them.
5212
a8e7d6d7 52132012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5214
5215 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5216
a8e7d6d7 52172012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5218
5219 * xdisp.c (pos_visible_p): If the window start position is beyond
5220 ZV, start the display from buffer beginning. Prevents assertion
5221 violation in init_iterator when the minibuffer window is scrolled
5222 via the scroll bar.
5223
5224 * window.c (window_scroll_pixel_based): Likewise.
5225
a8e7d6d7 52262012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5227
5228 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5229
a8e7d6d7 52302012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5231
5232 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5233 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5234
a8e7d6d7 52352012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5236
b593d6a9
AH
5237 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5238 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5239
1c6900d9
EZ
52402012-04-26 Eli Zaretskii <eliz@gnu.org>
5241
4c3fa1d9
EZ
5242 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5243 display element, check also the underlying string or buffer
5244 character. (Bug#11341)
5245
1c6900d9
EZ
5246 * w32menu.c: Include w32heap.h.
5247 (add_menu_item): If the call to AppendMenuW (via
5248 unicode_append_menu) fails, disable Unicode menus only if we are
5249 running on Windows 9X/Me.
5250
42bf8205
AS
52512012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5252
5253 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5254 (xgetint): Add missing shift for LSB tags.
5255
b1bac16e
MR
52562012-04-24 Martin Rudalics <rudalics@gmx.at>
5257
5258 * keyboard.c (read_char): Don't wipe echo area for select window
5259 events: These might get delayed via `mouse-autoselect-window'
5260 (Bug#11304).
5261
d69621cc
JB
52622012-04-24 Juanma Barranquero <lekktu@gmail.com>
5263
5264 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5265 manipulation of :loaded-from data.
5266
02fd101b
JB
52672012-04-23 Juanma Barranquero <lekktu@gmail.com>
5268
5269 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5270 now a cons (bug#11311).
5271
888bec30
PE
52722012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5273
89a438bd
PE
5274 Do not create empty overlays with the evaporate property (Bug#9642).
5275 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5276 if it becomes empty after its bounds are adjusted to fit within
5277 its buffer. Without this fix, in a nonempty buffer (let ((o
5278 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5279 yields an empty overlay that has the evaporate property, which is
5280 not supposed to happen.
5281
1068fe4d
PE
5282 Fix minor GTK3 problems found by static checking.
5283 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5284 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5285 (struct _EmacsFixedClass, emacs_fixed_get_type):
5286 Move decls here from emacsgtkfixed.h, since they needn't be public.
5287 (emacs_fixed_get_type): Now static.
5288 (emacs_fixed_class_init): Omit unused local.
5289 (emacs_fixed_child_type): Remove; unused.
5290 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5291 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5292 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5293 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5294 (EMACS_FIXED_GET_CLASS): Remove; unused.
5295 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5296
888bec30
PE
5297 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5298 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5299
de85e130
PE
53002012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5301
d0baac98 5302 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5303 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5304 (__malloc_size_t, __malloc_ptrdiff_t):
5305 Remove. All uses removed, replaced by the definiens if needed,
5306 since we can assume C89 or better now.
5307 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5308 (protect_malloc_state, align, get_contiguous_space)
5309 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5310 (malloc_atfork_handler_child, malloc_enable_thread)
5311 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5312 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5313 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5314 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5315 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5316 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5317 Define using prototypes, not old style.
5318 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5319 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5320 (align): Don't assume that signed integer overflow wraps around.
5321 Omit unused local var.
5322 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5323 (_free_internal_nolock, memalign, mallochook, reallochook):
5324 Omit no-longer-needed casts.
5325 (valloc): Use getpagesize, not __getpagesize.
5326 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5327 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5328
de85e130
PE
5329 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5330
dcbf5805
MA
53312012-04-22 Michael Albinus <michael.albinus@gmx.de>
5332
5333 Move functions from C to Lisp. Make non-blocking method calls
5334 the default. Implement further D-Bus standard interfaces.
5335
5336 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5337 (QCdbus_request_name_allow_replacement)
5338 (QCdbus_request_name_replace_existing)
5339 (QCdbus_request_name_do_not_queue)
5340 (QCdbus_request_name_reply_primary_owner)
5341 (QCdbus_request_name_reply_in_queue)
5342 (QCdbus_request_name_reply_exists)
5343 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5344 (QCdbus_registered_serial, QCdbus_registered_method)
5345 (QCdbus_registered_signal): New Lisp objects.
5346 (XD_DEBUG_MESSAGE): Use sizeof.
5347 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5348 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5349 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5350 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5351 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5352 (xd_signature, xd_append_arg): Allow float for integer types.
5353 (xd_get_connection_references): New function.
b593d6a9
AH
5354 (xd_get_connection_address): Rename from xd_initialize.
5355 Return cached address.
dcbf5805
MA
5356 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5357 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5358 level.
5359 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5360 Return number of refcounts.
dcbf5805
MA
5361 (Fdbus_get_unique_name): Make stronger parameter check.
5362 (Fdbus_message_internal): New defun.
5363 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5364 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5365 (Fdbus_send_signal, Fdbus_register_service)
5366 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5367 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5368 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5369 (Vdbus_compiled_version, Vdbus_runtime_version)
5370 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5371 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5372 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5373 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5374 Adapt docstring.
dcbf5805 5375
52828e02
PE
53762012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5377
da05bc4c
PE
5378 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5379 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5380 Do not assume ptrdiff_t is the same width as 'int'.
5381
52828e02
PE
5382 * alloc.c: Handle unusual debugging option combinations.
5383 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5384 since the two debugging options are incompatible.
5385 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5386 is defined.
5387 (mem_init, mem_insert, mem_insert_fixup):
5388 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5389 (NEED_MEM_INSERT): Remove; no longer needed.
5390
f01769f9
LL
53912012-04-22 Leo Liu <sdl.web@gmail.com>
5392
5393 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5394
5790543d
PE
53952012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5396
5397 * sysdep.c [__FreeBSD__]: Minor cleanups.
5398 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5399 Use Emacs indenting style more consistently. Avoid some casts.
5400 Use 'double' consistently rather than mixing 'float' and 'double'.
5401
b91b7e4d
EW
54022012-04-21 Eduard Wiebe <usenet@pusto.de>
5403
b593d6a9
AH
5404 * sysdep.c (list_system_processes, system_process_attributes):
5405 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5406
6114eb15
AS
54072012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5408
5409 * lisp.mk (lisp): Update.
5410
2f38dff7
PE
54112012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5412
5413 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5414 It is never used otherwise.
5415
4ae29f89
SM
54162012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5417
5418 * print.c (print_preprocess): Only check print_depth if print-circle
5419 is nil.
5420 (print_object): Check for cycles even when print-circle is nil and
5421 print-gensym is t, but only check print_depth if print-circle is nil.
5422
f30d612a
CY
54232012-04-20 Chong Yidong <cyd@gnu.org>
5424
5425 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5426 set the status to "failed" and ensure that sentinel is run.
5427
c07a4c0b 54282012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5429
5430 * process.c (Fset_process_inherit_coding_system_flag)
5431 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5432 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5433
c07a4c0b 54342012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5435
5436 * xdisp.c (string_buffer_position_lim): Limit starting position to
5437 BEGV.
5438 (set_cursor_from_row): If called for a mode-line or header-line
5439 row, return zero immediately.
5440 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5441 farther than the first row after the header line, if any.
5442 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5443 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5444
c07a4c0b 54452012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5446
4ae29f89
SM
5447 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5448 (bug#11238).
ad3a2b41 5449
c07a4c0b 54502012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 54512012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5452
5453 configure: new option --enable-gcc-warnings (Bug#11207)
5454 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5455 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5456 (ALL_CFLAGS): Use new macros rather than old.
5457 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5458 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5459 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5460 -Wunused-result, -Wunused-variable. This should go away once
5461 the Emacs and Gnulib regex code is merged.
5462 (xmalloc, xrealloc): Now static.
5463
aba027e8
PE
54642012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5465
5466 * dired.c (Fsystem_groups): Remove unused local.
5467
e5a36063
GM
54682012-04-17 Glenn Morris <rgm@gnu.org>
5469
5470 * dired.c (Fsystem_users): Doc fix.
5471
316411f0
DA
54722012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5473
5474 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5475 (syms_of_dired): Add them.
5476
9426aba4
PE
54772012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5478
b62a57be
PE
5479 Fix minor alloc.c problems found by static checking.
5480 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5481 New extern decls, to avoid calling undeclared functions.
5482 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5483 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5484 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5485 (NEED_MEM_INSERT): New macro.
5486 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5487 Remove one incorrect comment and fix another.
b62a57be 5488
3539f31f
PE
5489 Fix minor ralloc.c problems found by static checking.
5490 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5491 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5492 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5493 (r_alloc_sbrk): Now static.
5494
a041960a
PE
5495 Improve ralloc.c interface checking.
5496 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5497 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5498 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5499 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5500 [REL_ALLOC]: ... to here, to check interface.
5501 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5502 Remove decls. This fixes an "It stinks!".
5503
9426aba4
PE
5504 * alloc.c (which_symbols): Fix alignment issue / type clash.
5505
d55c12ed
AS
55062012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5507
5508 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5509 (struct Lisp_Misc_Any): Likewise.
5510 (struct Lisp_Free): Likewise.
5511 * alloc.c (union aligned_Lisp_Symbol): Define.
5512 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5513 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5514 (union aligned_Lisp_Misc): Define.
5515 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5516 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5517 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5518
b948ce8b
PE
55192012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5520
5521 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5522 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5523 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5524 * s/netbsd.h, s/sol2-6.h:
5525 Remove definition of GC_MARK_STACK, since the default now works.
5526 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5527 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5528 no longer the default.
5529 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5530
35dc09a1 55312012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5532
35dc09a1
GM
5533 * lread.c (lisp_file_lexically_bound_p):
5534 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5535
35dc09a1
GM
55362012-04-14 Eli Zaretskii <eliz@gnu.org>
5537
5538 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5539 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5540
55412012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5542
5543 * nsterm.m (constrainFrameRect): Always constrain when there is only
5544 one screen (Bug#10962).
5545
bcd86815
KB
55462012-04-13 Ken Brown <kbrown@cornell.edu>
5547
5548 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5549
c25df26e
RT
55502012-04-13 Reuben Thomas <rrt@sc3d.org>
5551
5552 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5553
0fc59f1e
DC
55542012-04-11 Daniel Colascione <dancol@dancol.org>
5555
5556 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5557 against is gone. It's better to use vfork now so that when Cygwin
5558 gains a new, working vfork, we use it automatically (bug#10398).
5559
de8c03dc
SM
55602012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5561
5562 * window.c (save_window_save): Obey window-point-insertion-type.
5563
2f097256
GM
55642012-04-11 Glenn Morris <rgm@gnu.org>
5565
5566 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5567
453b951e
SM
55682012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5569
5570 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5571
75f1671a 55722012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5573
5574 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5575 (force_quit_count): New var.
5576 (handle_interrupt): Use it.
5577
2a8ce227
JB
55782012-04-10 Juanma Barranquero <lekktu@gmail.com>
5579
5580 * w32.c (w32_delayed_load): Record the full path of the library
5581 being loaded (bug#10424).
5582
935396c0
GM
55832012-04-09 Glenn Morris <rgm@gnu.org>
5584
05920a43
GM
5585 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5586 not just in the obarray, before snarfing them. (Bug#11036)
5587
935396c0
GM
5588 * Makefile.in ($(leimdir)/leim-list.el):
5589 Pass EMACS rather than BUILT_EMACS.
5590
a18ecafa
TZ
55912012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5592
5593 * process.c (make_process):
5594 * process.h: Add integer `gnutls_handshakes_tried' member to
5595 process struct.
5596
6bbef4e5
JC
5597 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5598 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5599
5600 * gnutls.c (gnutls_log_function2i): Convenience log function.
5601 (emacs_gnutls_read): Use new log functions,
5602 `gnutls_handshakes_tried' process member, and
5603 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5604 attempts per process (connection).
5605
b4d3bc10
CY
56062012-04-09 Chong Yidong <cyd@gnu.org>
5607
5608 * eval.c (Fuser_variable_p, user_variable_p_eh)
5609 (lisp_indirect_variable): Functions deleted.
5610 (Fdefvar): Caller changed.
5611
5612 * callint.c (Finteractive, Fcall_interactively):
5613 * minibuf.c (Fread_variable): Callers changed.
5614
70f4d973
EZ
56152012-04-09 Eli Zaretskii <eliz@gnu.org>
5616
5617 * xdisp.c (set_cursor_from_row): If the display string appears in
5618 the buffer at position that is closer to point than the position
5619 after the display string, display the cursor on the first glyph of
5620 the display string. Fixes cursor display when a 'display' text
5621 property immediately follows invisible text. (Bug#11094)
5622
cb3c2e3e
PE
56232012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5624
5625 composite.c: use 'double' consistently
5626 * composite.c (get_composition_id): Use 'double' consistently
5627 instead of converting 'float' to 'double' and vice versa; this is
5628 easier to understand and avoids a GCC warning.
5629
fd06db5d
GM
56302012-04-09 Glenn Morris <rgm@gnu.org>
5631
50fe702a
GM
5632 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5633 preparation for dumping it with emacs. (Bug#4789)
5634 (leimdir): New variable.
5635 ($(leimdir)/leim-list.el): New rule.
5636 (emacs$(EXEEXT)): Depend on leim-list.el.
5637
fd06db5d
GM
5638 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5639 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5640 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5641
55c131ee
AS
56422012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5643
5644 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5645 proper alignment.
5646
9209588f
JB
56472012-04-07 Juanma Barranquero <lekktu@gmail.com>
5648
5649 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5650 Remove unused local variable.
5651
e3fb2efb
PE
56522012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5653
5654 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5655 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5656 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5657 objects, as mark_maybe_pointer will catch them otherwise.
5658 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5659 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5660
b5385551
PE
56612012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5662
5663 Fix typo that broke non-Windows builds.
5664 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5665
9078ead6
EZ
56662012-04-07 Eli Zaretskii <eliz@gnu.org>
5667
5668 Support building on MS-Windows with libxml2.
5669
5670 * makefile.w32-in (OBJ2): Add xml.$(O).
5671 (GLOBAL_SOURCES): Add xml.c.
5672 ($(BLD)/xml.$(O)): New dependency list.
5673
5674 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5675 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5676 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5677 [!WINDOWSNT]: New macros.
5678 (init_libxml2_functions, libxml2_loaded_p): New functions.
5679 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5680 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5681 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5682 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5683 linked in).
6bbef4e5
JC
5684 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5685 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5686 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5687
5688 * emacs.c: Don't include libxml/parser.h.
5689 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5690 xmlCleanupParser directly.
5691
5692 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5693
3811fdf3
EZ
56942012-04-07 Eli Zaretskii <eliz@gnu.org>
5695
5696 * indent.c (Fvertical_motion): If there is a display string at
5697 point, use it.vpos to compute how many lines to backtrack after
5698 move_it_to point. (Bug#11133)
5699
2f8e16b2
EZ
57002012-04-06 Eli Zaretskii <eliz@gnu.org>
5701
5702 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5703 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5704 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5705 macros related to unification of CJK characters. For the details,
5706 see the discussion following the message here:
5707 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5708
3d439cd1
CY
57092012-04-04 Chong Yidong <cyd@gnu.org>
5710
5711 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5712
8bc53d00
EZ
57132012-04-01 Eli Zaretskii <eliz@gnu.org>
5714
5715 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5716 instead of alloca. (Bug#11138)
5717
3b0512a3
AS
57182012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5719
5720 * w32menu.c (is_simple_dialog): Properly check lisp types.
5721 (Bug#11141)
5722
8427ddd2
EZ
57232012-03-31 Eli Zaretskii <eliz@gnu.org>
5724
979022ef
EZ
5725 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5726 position we get to after a call to move_it_to fails the
5727 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5728 only if we wind up in a string from display property. (Bug#11063)
5729
a6b1c7cc
EZ
5730 * window.c (Fdelete_other_windows_internal): Invalidate the row
5731 and column information about mouse highlight, so that redisplay
5732 restores it after reallocating the glyph matrices. (Bug#7464)
5733
8427ddd2
EZ
5734 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5735 string comes from a `display' text property, use the buffer
5736 position of that property as if we actually saw that position in
5737 the row's glyphs.
697ba24b
EZ
5738 (move_it_by_lines): Remove the assertion that
5739 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5740 violated when there's a before-string at the beginning of a line.
5741 (Bug#11063)
8427ddd2 5742
65a0a738
EZ
57432012-03-30 Eli Zaretskii <eliz@gnu.org>
5744
5745 * xdisp.c (append_space_for_newline): If the default face was
5746 remapped, use the remapped face for the appended newline.
5747 (extend_face_to_end_of_line): Use the remapped default face for
5748 extending the face to the end of the line.
5749 (display_line): Call extend_face_to_end_of_line when the default
5750 face was remapped. (Bug#11068)
5751
581355cc
EZ
57522012-03-29 Eli Zaretskii <eliz@gnu.org>
5753
5754 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5755
e8fc049f
SM
57562012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5757
5758 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5759
4fb9a543
GM
57602012-03-27 Glenn Morris <rgm@gnu.org>
5761
5762 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5763 Doc fixes.
5764
679910f1
KH
57652012-03-26 Kenichi Handa <handa@m17n.org>
5766
5767 * dispextern.h (struct glyph): Fix previous change. Change the
5768 bit length of glyphless.ch to 25 (Bug#11082).
5769
90d49b7f
CY
57702012-03-26 Chong Yidong <cyd@gnu.org>
5771
5772 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5773 (command_loop_1): Use it; inhibit selection update for
5774 handle-select-window too (Bug#8996).
5775
f514f6f0
FP
57762012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5777
e8fc049f 5778 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5779
bf43fa51
KH
57802012-03-25 Kenichi Handa <handa@m17n.org>
5781
5782 * dispextern.h (struct glyph): Change the bit length of
5783 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5784
8a0c01dd
EZ
57852012-03-24 Eli Zaretskii <eliz@gnu.org>
5786
5787 * s/ms-w32.h (tzname): Include time.h before redirecting to
5788 _tzname. Fixes the MSVC build. (Bug#9960)
5789
7d1c3a76
AS
57902012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5791
8ed79523
AS
5792 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5793 characters.
5794
7d1c3a76
AS
5795 * xterm.c (XTread_socket): Only modify handling_signal if
5796 !SYNC_INPUT. (Bug#11080)
5797
e99a9b8b
EZ
57982012-03-23 Eli Zaretskii <eliz@gnu.org>
5799
5800 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5801 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5802 when fetching a multibyte character consumes more bytes than
5803 CHAR_BYTES returns, due to unification of CJK characters in
5804 string_char. (Bug#11073)
5805
5063c0e1
TN
58062012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5807
5808 * process.c (wait_reading_process_output): Handle pty disconnect
5809 by refraining from sending oneself a SIGCHLD (bug#10933).
5810
9f851fbd
CY
58112012-03-22 Chong Yidong <cyd@gnu.org>
5812
5813 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5814
5063c0e1 5815 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5816 Mark string as coming from a prefix property.
5817 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5818 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5819
fb5b8aca
CY
58202012-03-21 Chong Yidong <cyd@gnu.org>
5821
5822 * xfaces.c (Vface_remapping_alist): Doc fix.
5823
62356a1b
EZ
58242012-03-20 Eli Zaretskii <eliz@gnu.org>
5825
5826 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5827 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5828 Doc fixes.
62356a1b 5829
025de85b
CY
58302012-03-20 Chong Yidong <cyd@gnu.org>
5831
5832 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5833 to reflect default non-nil value of redisplay-dont-pause.
5834
4827f94e
KH
58352012-03-19 Kenichi Handa <handa@m17n.org>
5836
5837 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5838 it fit in a valid range (Bug#11003).
5839
e50a24a2
EZ
58402012-03-18 Eli Zaretskii <eliz@gnu.org>
5841
5842 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5843 that is not from display property, accept the row as a "cursor
5844 row" if one of the string's character has a non-nil `cursor'
5845 property. Fixes cursor positioning when there are newlines in
5846 overlay strings, e.g. in icomplete.el. (Bug#11035)
5847
9af5ed87
PE
58482012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5849
5850 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5851
d1f55f16
CY
58522012-03-12 Chong Yidong <cyd@gnu.org>
5853
5854 * eval.c (inhibit_lisp_code): Rename from
5855 inhibit_window_configuration_change_hook; move from window.c.
5856
5857 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5858 * window.c (run_window_configuration_change_hook)
5859 (syms_of_window): Callers changed.
5860
66c5eebd
CY
58612012-03-11 Chong Yidong <cyd@gnu.org>
5862
413df973
CY
5863 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5864
66c5eebd
CY
5865 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5866
1de11f56
CY
58672012-03-10 Chong Yidong <cyd@gnu.org>
5868
5869 * frame.c (other_visible_frames): Don't assume the selected frame
5870 is visible (Bug#10955).
5871
cae07000
SM
58722012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5873
5874 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5875
89c94350
JD
58762012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5877
5878 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5879 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5880 zero (Bug#10954).
5881
999dd333
GM
58822012-03-03 Glenn Morris <rgm@gnu.org>
5883
01a6dcc8 5884 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5885
de0100f2
EZ
58862012-03-02 Eli Zaretskii <eliz@gnu.org>
5887
5888 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5889 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5890 (redisplay_window, next_element_from_string): Fix typos in
5891 comments.
3e441275
EZ
5892 (redisplay_window): Pass to move_it_vertically the margin in
5893 pixels, not in screen lines.
de0100f2 5894
96a72ee9
GM
58952012-03-02 Glenn Morris <rgm@gnu.org>
5896
5897 * buffer.c (buffer-list-update-hook): Doc fix.
5898
312508d7
EZ
58992012-02-29 Eli Zaretskii <eliz@gnu.org>
5900
5901 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5902 push_it before setting up the iterator for the first overlay
5903 string, even if we have an empty string loaded.
5904 (next_overlay_string): If there's an empty string on the iterator
5905 stack, pop the stack. (Bug#10903)
5906
27f3c637
PE
59072012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5908
5909 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5910 Suggested by Stefan Monnier in
5911 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5912 * alloc.c (widen_to_Lisp_Object): New static function.
5913 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5914 and widening them to Lisp_Objects. This would work even if
5915 USE_LSB_TAG is defined and wide integers are used, which might
5916 happen in a future version of Emacs.
5917
3c9dfce6
CY
59182012-02-25 Chong Yidong <cyd@gnu.org>
5919
fa74b241
CY
5920 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5921 Doc fix.
5922
3c9dfce6
CY
5923 * xselect.c (Fx_selection_exists_p): Doc fix.
5924 (x_clipboard_manager_save_all): Print an informative message
5925 before saving to clipboard manager.
5926
9486df08
CY
59272012-02-24 Chong Yidong <cyd@gnu.org>
5928
5929 * keyboard.c (process_special_events): Handle all X selection
5930 requests in kbd_buffer, not just the next one (Bug#8869).
5931
f01d3321
CY
59322012-02-23 Chong Yidong <cyd@gnu.org>
5933
5934 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5935 call when setting menu-bar-lines and tool-bar-lines parameters.
5936 (unwind_create_frame_1): New helper function.
5937
5938 * window.c (inhibit_window_configuration_change_hook): New var.
5939 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5940 (syms_of_window): Initialize it.
f01d3321 5941
86b847b6
CY
59422012-02-22 Chong Yidong <cyd@gnu.org>
5943
5944 * xterm.c (x_draw_image_relief): Add missing type check for
5945 Vtool_bar_button_margin (Bug#10743).
5946
a59225b1
CY
59472012-02-21 Chong Yidong <cyd@gnu.org>
5948
5949 * fileio.c (Vfile_name_handler_alist): Doc fix.
5950
5951 * buffer.c (Fget_file_buffer): Protect against invalid file
5952 handler return value.
5953
310f5bd4
PE
59542012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5955
cb3a28cc
PE
5956 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5957 when computing $valmask.
5958
310f5bd4
PE
5959 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5960 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5961 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5962 It's useless in that case, and it can cause problems on hosts
5963 that allocate halves of EMACS_INT values separately.
5964 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5965 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5966 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5967 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5968 it avoids undefined behavior on hosts where shifting right by more
5969 than the word width has undefined behavior.
5970
2375c96a
CY
59712012-02-19 Chong Yidong <cyd@gnu.org>
5972
5973 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5974 (Funhandled_file_name_directory, Ffile_name_as_directory)
5975 (Fdirectory_file_name, Fexpand_file_name)
5976 (Fsubstitute_in_file_name): Protect against invalid file handler
5977 return values (Bug#10845).
5978
3eb49e71
EZ
59792012-02-18 Eli Zaretskii <eliz@gnu.org>
5980
5981 * .gdbinit (pitx): Fix incorrect references to fields of the
5982 iterator stack.
5983
7b926f3f
CY
59842012-02-17 Chong Yidong <cyd@gnu.org>
5985
5986 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5987
11273115
PE
59882012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5989
5990 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5991 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5992
c3a70e2b
CY
59932012-02-15 Chong Yidong <cyd@gnu.org>
5994
5995 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5996 marked as special. Also, starting docstrings with * is obsolete.
5997
0ca43699
AS
59982012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5999
6000 * gnutls.c (emacs_gnutls_write): Fix last change.
6001
2e8f3c56
LI
60022012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6003
6004 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6005 send_process.
6006
af70074f
SM
60072012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6008
6009 * keymap.c (Fsingle_key_description): Handle char ranges.
6010
95986d52
CY
60112012-02-12 Chong Yidong <cyd@gnu.org>
6012
afd83bd1
CY
6013 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6014 as that creates a dangerous corner case.
6015
95986d52
CY
6016 * window.c (Fdelete_window_internal): Invalidate the mouse
6017 highlight (Bug#9904).
6018
bd7da63e
GM
60192012-02-12 Glenn Morris <rgm@gnu.org>
6020
6021 * xselect.c (Fx_own_selection_internal)
6022 (Fx_get_selection_internal, Fx_disown_selection_internal)
6023 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6024 * nsselect.m (Fx_own_selection_internal)
6025 (Fx_disown_selection_internal, Fx_selection_exists_p)
6026 (Fx_selection_owner_p, Fx_get_selection_internal):
6027 Sync docs and argument specs with the xselect.c versions.
6028
77abcbc2
LI
60292012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6030
6031 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6032
90b671e2
EZ
60332012-02-11 Eli Zaretskii <eliz@gnu.org>
6034
1c0ca0b7
EZ
6035 * w32select.c (Fx_selection_exists_p): Sync doc string and
6036 argument list with xselect.c. (Bug#10783)
6037
6038 * w16select.c (Fx_selection_exists_p): Sync doc string and
6039 argument list with xselect.c. (Bug#10783)
90b671e2 6040
49241268
GM
60412012-02-10 Glenn Morris <rgm@gnu.org>
6042
6043 * fns.c (Fsecure_hash): Doc fix.
6044
f998bbe7 60452012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6046
6047 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6048
0992bd9c
CY
60492012-02-07 Chong Yidong <cyd@gnu.org>
6050
6051 * buffer.c (Fbuffer_local_variables)
6052 (buffer_lisp_local_variables): Handle unbound vars correctly;
6053 don't let Qunbound leak into Lisp.
6054
af008560
GM
60552012-02-07 Glenn Morris <rgm@gnu.org>
6056
dd605cc4
GM
6057 * image.c (Fimagemagick_types): Doc fix.
6058
af008560
GM
6059 * image.c (imagemagick-render-type): Change it from a lisp object
6060 to an integer. Move the doc here from the lisp manual.
6061 Treat all values not equal to 0 the same.
6062
1449fa1d
CY
60632012-02-06 Chong Yidong <cyd@gnu.org>
6064
6065 * doc.c (store_function_docstring): Avoid applying docstring of
6066 alias to base function (Bug#2603).
6067
3723ec07
AS
60682012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6069
6070 * .gdbinit (pp1, pv1): Remove redundant defines.
6071 (pr): Use pp.
6072
79c1cc1e
CY
60732012-02-04 Chong Yidong <cyd@gnu.org>
6074
6075 * nsterm.m: Declare a global (Bug#10694).
6076
d7f29f8e
EZ
60772012-02-04 Eli Zaretskii <eliz@gnu.org>
6078
cae07000
SM
6079 * w32.c (get_emacs_configuration_options):
6080 Include --enable-checking, if specified, in the return value.
d7f29f8e 6081
3b95a6f9
MR
60822012-02-04 Martin Rudalics <rudalics@gmx.at>
6083
6084 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6085 after rounding frame sizes. (Bug#9723)
6086
d6fa96a6
EZ
60872012-02-04 Eli Zaretskii <eliz@gnu.org>
6088
6089 * keyboard.c (adjust_point_for_property): Don't position point
6090 before BEGV. (Bug#10696)
6091
df0b2940
PE
60922012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6093
6094 Handle overflow when computing char display width (Bug#9496).
6095 * character.c (char_width): Return EMACS_INT, not int.
6096 (char_width, c_string_width): Check for overflow when
6097 computing the width; this is possible now that individual
6098 characters can have unbounded width. Problem introduced
6099 by merge from Emacs 23 on 2012-01-19.
6100
6bee44d6
MA
61012012-02-02 Michael Albinus <michael.albinus@gmx.de>
6102
6103 * dbusbind.c (Fdbus_register_method): Mention the return value
6104 :ignore in the docstring.
6105
44f92739
GM
61062012-02-02 Glenn Morris <rgm@gnu.org>
6107
1b9f60cc
GM
6108 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6109
44f92739
GM
6110 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6111 Unconditionally set to t. (Bug#10673)
6112 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6113 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6114 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6115
c5d3843c
KH
61162012-02-02 Kenichi Handa <handa@m17n.org>
6117
6118 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6119 0, do not call append_composite_glyph.
6120
159462d4 61212012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6122
6123 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6124 NULL (Bug#6988).
6125 (x_produce_glyphs): If the component of a composition is a null
6126 string, set it->pixel_width to 1 to avoid zero-width glyph.
6127
78cef877
EZ
61282012-02-01 Eli Zaretskii <eliz@gnu.org>
6129
6130 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6131 first 2 arguments are identical. This makes inserting large
6132 output from a subprocess an order of magnitude faster on
6133 MS-Windows, where all sbrk'ed memory is always contiguous.
6134
97897668
GM
61352012-01-31 Glenn Morris <rgm@gnu.org>
6136
6137 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6138 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6139 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6140
31fd3586
GM
61412012-01-29 Glenn Morris <rgm@gnu.org>
6142
6143 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6144
0e24a8b2
CY
61452012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6146
6147 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6148
cc0adcb0
CY
61492012-01-28 Chong Yidong <cyd@gnu.org>
6150
6151 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6152
acc28cb9
CY
61532012-01-26 Chong Yidong <cyd@gnu.org>
6154
9c69cfb7
CY
6155 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6156
acc28cb9
CY
6157 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6158 repeat counts (Bug#10507).
6159
48da7392
GM
61602012-01-26 Glenn Morris <rgm@gnu.org>
6161
6162 * lread.c (syms_of_lread): Doc fix.
6163
14af5f7f
CY
61642012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6165
6166 * coding.c (encode_designation_at_bol): Change return value to
6167 EMACS_INT.
6168
0b21c100
CY
61692012-01-25 Chong Yidong <cyd@gnu.org>
6170
6171 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6172
3c2907f7
CY
61732012-01-21 Chong Yidong <cyd@gnu.org>
6174
6175 * floatfns.c (Fcopysign): Make the second argument non-optional,
6176 since nil is not allowed anyway.
6177
959ad23f
AS
61782012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6179
6180 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6181 (send_process): Likewise.
6182
34a02f46
MR
61832012-01-19 Martin Rudalics <rudalics@gmx.at>
6184
6185 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6186 (Vwindow_persistent_parameters): Do not use Qstate.
6187 Rewrite doc-strings.
34a02f46 6188
1259009a 61892012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6190
6191 * character.c (char_width): New function.
70d4fdf6
GM
6192 (Fchar_width, c_string_width, lisp_string_width):
6193 Use char_width (Bug#9496).
25ed9e61 6194
6a6ee00d
MR
61952012-01-16 Martin Rudalics <rudalics@gmx.at>
6196
6197 * window.c (Vwindow_persistent_parameters): New variable.
6198 (Fset_window_configuration, save_window_save): Handle persistent
6199 window parameters.
6200
c85efaf7
EZ
62012012-01-14 Eli Zaretskii <eliz@gnu.org>
6202
6203 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6204 thrashing the stack of the thread. (Bug#9087)
6205
5944709e
PE
62062012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6207
6208 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6209
e71f5d99
EZ
62102012-01-11 Eli Zaretskii <eliz@gnu.org>
6211
6212 * xdisp.c (rows_from_pos_range): Handle the case where the
6213 highlight ends on a newline. (Bug#10464)
6214 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6215 he end column for display of highlight that ends on a newline
6216 before a R2L line.
6217
ce316182
GM
62182012-01-11 Glenn Morris <rgm@gnu.org>
6219
6220 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6221 from load-path also when installation-directory is nil. (Bug#10208)
6222
5b43da69
GM
62232012-01-10 Glenn Morris <rgm@gnu.org>
6224
74cc8ff9
GM
6225 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6226
7d8d6e4e
GM
6227 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6228 Update template values to be closer to their typical values these days.
5b43da69 6229
a0db8d43
EZ
62302012-01-09 Eli Zaretskii <eliz@gnu.org>
6231
6232 * xdisp.c (rows_from_pos_range): Accept additional argument
6233 DISP_STRING, and accept any glyph in a row whose object is that
6234 string as eligible for mouse highlight. Fixes mouse highlight of
6235 display strings from overlays. (Bug#10464)
6236
9a0115ab 62372012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6238
b9110d6a 6239 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6240 * fileio.c (auto_saving_dir_umask): New static var.
6241 (Fmake_directory_internal): Use it.
6242 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6243 creating the directory. The old code temporarily assigns
6244 too-generous permissions to the directory.
6245 (do_auto_save_eh): Clear it.
b9110d6a 6246 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6247 that the var is always cleared.
6248
6c1bd3f3
EZ
62492012-01-07 Eli Zaretskii <eliz@gnu.org>
6250
6251 * search.c (scan_buffer): Pass character positions to
6252 know_region_cache, not byte positions. (Bug#6540)
6253
069d2b50
L
62542012-01-07 LynX <_LynX@bk.ru> (tiny change)
6255
6256 * w32.c (sys_rename): Report EXDEV when rename of a directory
6257 fails because the target is on another logical disk. (Bug#10284)
6258
75bf0d33
DB
62592012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6260
6261 * xterm.c (x_embed_request_focus): New function.
6262
6263 * xterm.h: Add prototype.
6264
6265 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6266
1c6e5a32
GM
62672012-01-05 Glenn Morris <rgm@gnu.org>
6268
6269 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6270
651e947e
EZ
62712012-01-01 Eli Zaretskii <eliz@gnu.org>
6272
6273 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6274 Load gnutls_transport_set_lowat only if GnuTLS version is below
6275 2.11.1.
6276 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6277 GnuTLS versions below 2.11.1.
6278
3778cdd8
AL
62792011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6280
6281 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6282 to the doc string advising against its use for altering the way
6283 windows are scrolled.
6284
0e5317f7
KH
62852011-12-28 Kenichi Handa <handa@m17n.org>
6286
6287 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6288 coding-system ASCII compatible only when it does not produce BOM
6289 on encoding (Bug#10383).
6290
93d5ca1f
JD
62912011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6292
6293 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6294 can scroll.
6295 (create_and_show_popup_menu): Always use menu_position_func for
6296 Gtk3 (Bug#10361).
6297
ca22b785
AS
62982011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6299
6300 * callint.c (Fcall_interactively): Don't truncate prompt string.
6301
d048e1e6
EZ
63022011-12-23 Eli Zaretskii <eliz@gnu.org>
6303
6304 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6305 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6306 resumed from there (after widening). (Bug#10360)
d048e1e6 6307
5ccaba1f
JD
63082011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6309
6310 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6311
204ee57f
JD
63122011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6313
b81d40f0
JB
6314 * nsterm.m (x_free_frame_resources):
6315 Release f->output_data.ns->miniimage.
204ee57f
JD
6316 (ns_index_color): Fix indentation. Do not retain
6317 color_table->colors[i].
6318
6319 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6320 before returning.
6321
6322 * nsfns.m (x_set_background_color): Assign return value from
6323 ns_index_color to face-background instead of NSColor*.
6324 (ns_implicitly_set_icon_type): Fix indentation.
6325 Change assignment in for loop to comparison.
6326
6327 * emacs.c (ns_pool): New variable.
6328 (main): Assign ns_pool.
6329 (Fkill_emacs): Call ns_release_autorelease_pool.
6330
6331 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6332 autorelease fdesc, release fdAttrs and tdict.
6333 (ns_get_covering_families): Release charset.
6334 (ns_findfonts): Release NSFontDescriptor created with new.
6335 (ns_uni_to_glyphs): Fix indentation.
6336 (setString): Release attrStr before assigning new value.
6337
c803b2b7
JD
63382011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6339
678f4426
JD
6340 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6341 and NS_IMPL_COCOA.
6342 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6343 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6344
cd394be1 63452011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6346
5fecd5fc
JD
6347 * nsterm.m (ns_term_init): Subscribe for notifications
6348 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6349 to method trackingNotification in EmacsMenu.
6350
6351 * nsmenu.m (trackingMenu): New variable.
3771cb17 6352 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6353 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6354 from Aquamacs (Bug#7030).
678f4426
JD
6355
63562011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6357
c803b2b7
JD
6358 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6359 (symbol_to_nsstring): Fix indentation.
6360 (ns_symbol_to_pb): New function.
cae07000
SM
6361 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6362 (Fns_rotate_cut_buffers_internal): Remove.
6363 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6364 Fns_store_cut_buffer_internal.
6365 (ns_get_foreign_selection, Fx_own_selection_internal)
6366 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6367 (Fns_get_selection_internal, Fns_store_selection_internal):
6368 Use ns_symbol_to_pb and check if return value is nil.
6369 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6370 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6371 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6372 renamed to Sns_store_selection_internal.
6373 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6374 and remove this function.
6375 (ns_handle_selection_clear): Remove, never used.
6376 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6377 here.
6378
e1b01a3a
KB
63792011-12-17 Ken Brown <kbrown@cornell.edu>
6380
6381 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6382 GID is unknown (Bug#10257).
6383
2adb6e85
PE
63842011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6385
6386 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6387 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6388 which caused a build failure on GNU/Linux IA-64. This problem was
6389 introduced by my 2011-10-07 patch.
6390
d1d7b339
JL
63912011-12-15 Juri Linkov <juri@jurta.org>
6392
6393 * image.c (imagemagick_error): New function. (Bug#10112)
6394 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6395 Use `imagemagick_error' where ImageMagick functions return
6396 `MagickFalse'.
6397 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6398 proper order.
6399
100d5755
KH
64002011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6401
6402 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6403 fill background (Bug#8992).
6404
454592a6
MR
64052011-12-13 Martin Rudalics <rudalics@gmx.at>
6406
6407 * window.c (Vwindow_combination_resize)
6408 (Vwindow_combination_limit): Use t instead of non-nil in
6409 doc-strings.
61d4b438
MR
6410 (Vrecenter_redisplay): Add first sentence of doc-string on
6411 separate line.
53524d93 6412 (Frecenter): Fix doc-string typo.
454592a6 6413
3633e3aa
KH
64142011-12-11 Kenichi Handa <handa@m17n.org>
6415
6416 * coding.c (Funencodable_char_position): Pay attention to the
6417 buffer text relocation (Bug#9389).
6418
7b9d523a 64192011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6420
7b9d523a
JD
6421 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6422 gtk_init (Bug#10100).
6423
b73189c6
EZ
64242011-12-10 Eli Zaretskii <eliz@gnu.org>
6425
6426 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6427 IT->string is nil. (Bug#10263)
6428
f7dfe5d6
JD
64292011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6430
83faebb4
JD
6431 * nsterm.h (x_free_frame_resources): Declare.
6432
f7dfe5d6
JD
6433 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6434 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6435
6436 * nsterm.h (ns_get_defaults_value): Declare.
6437
6438 * nsterm.m (ns_default): Call ns_get_defaults_value.
6439
7cd4e72c
EZ
64402011-12-09 Eli Zaretskii <eliz@gnu.org>
6441
6442 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6443 (Bug#10170)
6444
b34d7317
YM
64452011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6446
6447 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6448 that where the value of an _OBJC_* symbol points to is in the .bss
6449 section (Bug#10240).
6450
76470ad1
KH
64512011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6452
6453 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6454 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6455
745fff94
KH
64562011-12-08 Kenichi Handa <handa@m17n.org>
6457
6458 * ftfont.c (get_adstyle_property): Fix previous change
6459 (Bug#10233).
6460
6e44397c
JB
64612011-12-07 Juanma Barranquero <lekktu@gmail.com>
6462
6463 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6464 dirs from the default value of EMACSLOADPATH (bug#10208).
6465
7efa6272
GM
64662011-12-07 Glenn Morris <rgm@gnu.org>
6467
6468 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6469 installation and source directories as well. (Bug#10208)
6470
f6fc4d87
CY
64712011-12-06 Chong Yidong <cyd@gnu.org>
6472
6473 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6474
2bf26180
GM
64752011-12-06 Glenn Morris <rgm@gnu.org>
6476
6477 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6478 as an error, not just -1. (Bug#10217)
6479
3a6ad4f0
CY
64802011-12-05 Chong Yidong <cyd@gnu.org>
6481
6482 * keyboard.c (process_special_events): New function.
6483 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6484
75a3b399
PE
64852011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6486
6487 * coding.c (encode_designation_at_bol): Don't use uninitialized
6488 local variable (Bug#9318).
6489
c3c9e25e
KH
64902011-12-05 Kenichi Handa <handa@m17n.org>
6491
6492 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6493 return Qnil (Bug#8046, Bug#10193).
6494
5eb05ea3
KH
64952011-12-05 Kenichi Handa <handa@m17n.org>
6496
6497 * coding.c (encode_designation_at_bol): New args charbuf_end and
6498 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6499 (coding_set_source): Return how many bytes coding->source was
6500 relocated.
6501 (coding_set_destination): Return how many bytes
6502 coding->destination was relocated.
6503 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6504 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6505
65062011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6507
6508 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6509 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6510 macro (Bug#9318).
6511
65122011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6513
6514 The following changes are to fix Bug#9318.
6515
a79703f5 6516 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6517 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6518 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6519 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6520
7dbda6df
JB
65212011-12-05 Juanma Barranquero <lekktu@gmail.com>
6522
6523 * lisp.h (process_quit_flag): Fix external declaration.
6524
6d5eb5b0
SM
65252011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6526
6527 Don't macro-inline non-performance-critical code.
6528 * eval.c (process_quit_flag): New function.
6529 * lisp.h (QUIT): Use it.
6530
a0c3fad0
JD
65312011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6532
6533 * nsfns.m (get_geometry_from_preferences): New function.
6534 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6535
6c07aac2
AS
65362011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6537
6538 * emacs.c (Qkill_emacs): Define.
6539 (syms_of_emacs): Initialize it.
6540 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6541 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6542 (quit_throw_to_read_char): Add parameter `from_signal'.
6543 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6544 * lisp.h (QUIT): Call Fkill_emacs if requested.
6545
c052ead4
JD
65462011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6547
6548 * widget.c (update_wm_hints): Return if wmshell is null.
6549 (widget_update_wm_size_hints): New function.
6550
6551 * widget.h (widget_update_wm_size_hints): Declare.
6552
6553 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6554 widget_update_wm_size_hints (Bug#10104).
6555
9e49252b
EZ
65562011-12-03 Eli Zaretskii <eliz@gnu.org>
6557
6558 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6559 before a newline, prepare the bidi iterator for consuming the
6560 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6561 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6562
02b16839
JL
65632011-12-02 Juri Linkov <juri@jurta.org>
6564
6565 * search.c (Fword_search_regexp): New Lisp function created from
6566 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6567 (Fword_search_backward, Fword_search_forward)
6568 (Fword_search_backward_lax, Fword_search_forward_lax):
6569 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6570 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6571
0068070e
SM
65722011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6573
6574 * fileio.c (Finsert_file_contents): Move after-change-function call
6575 to before the "handled:" label, since all "goto handled" appear in
6576 cases where the *-change-functions have already been properly called
6577 (bug#10117).
6578
3360a3fc
AS
65792011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6580
6581 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6582 waiting for input. (Bug#10169)
6583
73d6c093
EZ
65842011-11-30 Eli Zaretskii <eliz@gnu.org>
6585
6586 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6587 verifies glyph row's hash code--we have just reallocated the
6588 glyphs, so their contents can be complete garbage. (Bug#10164)
6589
febe6bea
JB
65902011-11-30 Juanma Barranquero <lekktu@gmail.com>
6591
6592 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6593
801a4313
EZ
65942011-11-30 Eli Zaretskii <eliz@gnu.org>
6595
6596 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6597 attributes are tested _before_ calling verify_row_hash, to protect
6598 against GCC re-ordering of the tests. (Bug#10164)
6599
2b56b87e
JD
66002011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6601
6602 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6603
6604 * xterm.c (handle_one_xevent): Only set async_visible and friends
6605 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6606 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6607 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6608
dbf31225
PE
66092011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6610
6611 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6612 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6613 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6614 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6615 All uses changed to use GCPRO1 etc.
6616 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6617 Revert to old implementation (i.e., before 2011-03-11).
6618
1305621b
YM
66192011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6620
6621 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6622 of scroll runs so as to avoid assigning disabled bogus rows and
6623 unnecessary graphics copy operations.
6624
8c9afb46
EZ
66252011-11-27 Eli Zaretskii <eliz@gnu.org>
6626
6627 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6628 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6629 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6630 (malloc, free, realloc, calloc): Redirect to e_* only when
6631 compiling Emacs.
6632
6633 * lisp.h (GCTYPEBITS): Move before first use.
6634 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6635 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6636 this macro definition.
6637
6638 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6639 _MSC_VER.
6640
54e9e3bf
JD
66412011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6642
6d5eb5b0
SM
6643 * gtkutil.c (xg_create_frame_widgets):
6644 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6645 present with Gtk+ 2.0.
6646
83aca1cb
PE
66472011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6648
6649 * fileio.c (Finsert_file_contents): Undo previous change; see
6650 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6651
5b76caa4
PE
66522011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6653
6654 Rename locals to avoid shadowing.
6655 * fileio.c (Finsert_file_contents):
6656 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6657 * process.c (wait_reading_process_output):
6658 Rename inner 'proc' to 'p' to avoid shadowing.
6659 Indent for consistency with usual Emacs style.
6660
8c535114
EZ
66612011-11-25 Eli Zaretskii <eliz@gnu.org>
6662
6663 * xdisp.c (redisplay_window): If cursor row is not fully visible
6664 after recentering, and scroll-conservatively is set to a large
6665 number, scroll window by a few more lines to make the cursor fully
6666 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6667 (start_display): Don't move to the next line if the display should
6668 start at a newline that is part of a display vector or an overlay
6669 string. (Bug#10119)
8c535114 6670
fa4fdb5c
JL
66712011-11-24 Juri Linkov <juri@jurta.org>
6672
6673 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6674 after the `MagickPingImage' call. (Bug#10112)
6675
90ec88df
CY
66762011-11-23 Chong Yidong <cyd@gnu.org>
6677
6678 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6679
56e2e794
MR
66802011-11-23 Martin Rudalics <rudalics@gmx.at>
6681
6682 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6683 making another buffer current. (Bug#10114)
6684
b6e64c41
GM
66852011-11-23 Glenn Morris <rgm@gnu.org>
6686
6687 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6688
6b21de18
CY
66892011-11-23 Chong Yidong <cyd@gnu.org>
6690
6691 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6692 using it (Bug#5984).
6693
b12cd789
EZ
66942011-11-22 Eli Zaretskii <eliz@gnu.org>
6695
6696 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6697 and header-lines, as they don't have one computed for them.
6698 (Bug#10098)
6699
6700 * .gdbinit (prow): Make displayed values more self-explaining.
6701 Add row's hash code.
6702
261b6fd4
LMI
67032011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6704
6705 * process.c (wait_reading_process_output): Fix asynchrounous
6706 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6707 (wait_reading_process_output): Add comment and URL.
261b6fd4 6708
e7cfd277
JD
67092011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6710
6711 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6712
a9b9b7f5
CY
67132011-11-21 Chong Yidong <cyd@gnu.org>
6714
6715 * window.c (Fnext_window, Fprevious_window): Doc fix.
6716
b0d15b4f
SM
67172011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6718
6719 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6720
fe7a3057
JB
67212011-11-20 Juanma Barranquero <lekktu@gmail.com>
6722
6723 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6724
d2999b1a
MR
67252011-11-20 Martin Rudalics <rudalics@gmx.at>
6726
6727 * window.c (Fset_window_combination_limit): Rename argument
6728 STATUS to LIMIT.
6729 (Vwindow_combination_limit): Remove "status" from doc-string.
6730
d5ff9cd0
AS
67312011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6732
6733 * m/ibms390.h: Remove.
6734 * m/ibms390x.h: Don't include "ibms390.h".
6735
a5bb9bd3
SM
67362011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6737
6738 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6739 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6740
cd1181db
JB
67412011-11-20 Juanma Barranquero <lekktu@gmail.com>
6742
6743 * casetab.c (Fset_case_table):
6744 * charset.c (Fcharset_after): Fix typos.
6745
615a3b8d 67462011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6747
17e845af
PE
6748 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6749 Otherwise, valgrind does not work on some platforms.
6750 Problem reported by Andreas Schwab in
6a0bf43d
PE
6751 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6752 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6753 is set, removing the need for VIRT_ADDRESS_VARIES.
6754 (PURE_P): Use a more-efficient implementation that needs just one
6755 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6756 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6757 to 4 (xorl, subq, cmpq, setbe).
6758 * alloc.c (pure): Always extern now, since that's the
6759 VIRT_ADDR_VARIES behavior.
6760 (PURE_POINTER_P): Use a single comparison, not two, for
6761 consistency with the new puresize.h.
6762 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6763 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6764 Remove VIRT_ADDR_VARIES no longer needed.
6765
f8fe6f96
EZ
67662011-11-19 Eli Zaretskii <eliz@gnu.org>
6767
6768 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6769 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6770 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6771 behave as if the cursor position were at the window margin.
6772
6773 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6774 and the cursor position is out of bounds, behave as if the cursor
6775 position were at the window margin. (Bug#10075)
6776
df05a53c
CY
67772011-11-18 Chong Yidong <cyd@gnu.org>
6778
6779 * window.c (Fwindow_combination_limit): Make first argument
6780 non-optional, since it is meaningless for live windows like the
6781 selected window.
61ccba97 6782
2071918e
DA
67832011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6784
6785 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6786
b50a28de
SM
67872011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6788
6789 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6790 (graft_intervals_into_buffer): Simplify.
6791
015137db
EZ
67922011-11-18 Eli Zaretskii <eliz@gnu.org>
6793
6794 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6795 hash values of the two rows.
6796 (copy_row_except_pointers): Preserve the used[] arrays and the
6797 hash values of the two rows. (Bug#10035)
68c95424 6798 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6799
6800 * xdisp.c (row_hash): New function, body extracted from
6801 compute_line_metrics.
6802 (compute_line_metrics): Call row_hash, instead of computing the
6803 hash code inline.
6804
6805 * dispnew.c (verify_row_hash): Call row_hash for computing the
6806 hash code of a row, instead of duplicating code from xdisp.c.
6807
6808 * dispextern.h (row_hash): Add prototype.
6809
a2addb04
TH
68102011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6811
6812 * frame.c (delete_frame): Don't delete the terminal when the last
6813 X frame is closed if emacs is built with GTK toolkit.
6814
df85d315
JB
68152011-11-17 Juanma Barranquero <lekktu@gmail.com>
6816
6817 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6818
a0c2d0ae
MR
68192011-11-17 Martin Rudalics <rudalics@gmx.at>
6820
6821 * window.c (Vwindow_splits): Rename to
6822 Vwindow_combination_resize. Suggested by Juri Linkov.
6823 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6824 of Vwindow_splits.
6825
58179cce
JB
68262011-11-16 Juanma Barranquero <lekktu@gmail.com>
6827
7877f373
JB
6828 * nsfns.m (Fns_font_name):
6829 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6830
b6f67890
MR
68312011-11-16 Martin Rudalics <rudalics@gmx.at>
6832
6833 * window.h (window): Rename slot "nest" to "combination_limit".
6834 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6835 (Fset_window_nest): Rename to Fset_window_combination_limit.
6836 (Vwindow_nest): Rename to Vwindow_combination_limit.
6837 (recombine_windows, make_parent_window, make_window)
6838 (Fsplit_window_internal, saved_window)
6839 (Fset_window_configuration, save_window_save): Rename all
6840 occurrences of window_nest to window_combination_limit.
6841
c7015153
JB
68422011-11-15 Juanma Barranquero <lekktu@gmail.com>
6843
6844 * image.c (imagemagick_load_image): Fix typo.
6845
322ad6ec
EZ
68462011-11-14 Eli Zaretskii <eliz@gnu.org>
6847
6848 * xdisp.c (display_line): Move the call to
6849 highlight_trailing_whitespace before the call to
6850 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6851 faces of all the glyphs to compute ROW's hash value.
6852 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6853
f067b8ec
JB
68542011-11-14 Juanma Barranquero <lekktu@gmail.com>
6855
6856 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6857 just return (bug#10044).
6858
1e5b2111
EZ
68592011-11-12 Eli Zaretskii <eliz@gnu.org>
6860
7ef3cbd5
EZ
6861 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6862 with user-defined heap size. Bump the default size of the temacs
6863 heap to 27MB, to avoid memory warning when running temacs.
6864 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6865
1e5b2111
EZ
6866 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6867 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6868 (verify_row_hash) [XASSERTS]: New function.
6869 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6870 that the hash value of glyph rows is correct.
1e5b2111 6871
89d61221
MR
68722011-11-12 Martin Rudalics <rudalics@gmx.at>
6873
6874 * window.h (window): Remove splits slot.
6875 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6876 (Fdelete_other_windows_internal, make_parent_window)
6877 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6878 (Fset_window_configuration, save_window_save): Don't deal with
6879 split status of windows.
6880 (saved_window): Remove splits slot.
6881 (Vwindow_splits): Rewrite doc-string.
6882
97f18cc8
JD
68832011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6884
6885 * xfns.c (unwind_create_frame):
6886 * nsfns.m (unwind_create_frame):
6887 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6888 Vframe_list (Bug#9999).
6889
22a648b4
DA
68902011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6891
0b381c7e 6892 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6893
659afede
KH
68942011-11-11 Kenichi Handa <handa@m17n.org>
6895
6896 * callproc.c (Fcall_process): Set the member dst_multibyte of
6897 process_coding.
6898
9ac0394b
KH
68992011-11-11 Johan Bockgård <bojohan@gnu.org>
6900
6901 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6902 avoid a crash (bug#9496).
6903
2fbdc249
CY
69042011-11-09 Chong Yidong <cyd@gnu.org>
6905
6906 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6907 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6908
ac6b1f81
PE
69092011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6910
6911 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6912
09db192c
PE
69132011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6914
6915 Avoid some portability problems by eschewing 'extern inline' functions.
6916 The trivial performance wins aren't worth the portability hassles; see
6917 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6918 et seq.
6919 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6920 (window_box_width, window_box_left, window_box_left_offset)
6921 (window_box_right, window_box_right_offset): Undo previous change,
6922 by removing the "extern"s.
6923 * intervals.c (adjust_intervals_for_insertion)
6924 (adjust_intervals_for_deletion): Undo previous change,
6925 making these static again.
6926 (offset_intervals, temp_set_point_both, temp_set_point)
6927 (copy_intervals_to_string): No longer inline.
6928 * xdisp.c (window_text_bottom_y, window_box_width)
6929 (window_box_height, window_box_left_offset)
6930 (window_box_right_offset, window_box_left, window_box_right)
6931 (window_box): No longer inline.
6932
105216ed
CY
69332011-11-08 Chong Yidong <cyd@gnu.org>
6934
6935 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6936 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6937 Signal an error if not a live window.
105216ed
CY
6938 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6939 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6940
ae9e237f
JB
69412011-11-07 Juanma Barranquero <lekktu@gmail.com>
6942
6943 * lisp.h (syms_of_abbrev): Remove declaration.
6944 Reported by CHENG Gao <chenggao@royau.me>.
6945
c7aa8333
EZ
69462011-11-07 Eli Zaretskii <eliz@gnu.org>
6947
6948 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6949 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6950 of temacs in GUI mode.
6951
be7f5545
MR
69522011-11-07 Martin Rudalics <rudalics@gmx.at>
6953
6954 * window.h: Declare delete_all_child_windows instead of
6955 delete_all_subwindows.
6956 * window.c (Fwindow_nest, Fset_window_nest)
6957 (Fset_window_new_total, Fset_window_new_normal)
6958 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6959 (delete_all_subwindows): Rename to delete_all_child_windows.
6960 (Fdelete_other_windows_internal, Fset_window_configuration):
6961 Call delete_all_child_windows instead of delete_all_subwindows.
6962 * frame.c (delete_frame): Call delete_all_child_windows instead
6963 of delete_all_subwindows.
6964
ca78dc43
PE
69652011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6966
6967 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6968 This is also needed for porting to any host where GC_MARK_STACK is
6969 not GC_MAKE_GCPROS_NOOPS.
6970 (which_symbols): Use it.
6971
a0241d01
KH
69722011-11-07 Kenichi Handa <handa@m17n.org>
6973
6974 * coding.c (coding_set_destination): Check coding->src_pos only
6975 when coding->src_object is a buffer (bug#9910).
6976
6977 * process.c (send_process): Set the member src_multibyte of coding
6978 to 0 (bug#9911) when sending a unibyte text.
6979
6980 * callproc.c (Fcall_process): Set the member src_multibyte of
6981 process_coding to 0 (bug#9912).
6982
a64bfdfa 69832011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6984
6985 * xmenu.c (cleanup_widget_value_tree): New function.
6986 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6987 calling free_menubar_widget_value_tree directly (Bug#9830).
6988
cb41b32a
PE
69892011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6990
6991 Fix some portability problems with 'inline'.
6992 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6993 (window_box_width, window_box_left, window_box_left_offset)
6994 (window_box_right, window_box_right_offset): Declare extern.
6995 Otherwise, these inline functions do not conform to C99 and
6996 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6997 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6998 * intervals.c (adjust_intervals_for_insertion)
6999 (adjust_intervals_for_deletion): Now extern, because otherwise the
7000 extern inline functions 'offset_intervals' couldn't refer to it.
7001 (static_offset_intervals): Remove.
7002 (offset_intervals): Rewrite using the old contents of
7003 static_offset_intervals. The old version didn't conform to C99
7004 because an extern inline function contained a reference to an
7005 identifier with static linkage.
7006
b7041366
AS
70072011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7008
7009 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7010 GC.
7011
88a37c4d
EZ
70122011-11-06 Eli Zaretskii <eliz@gnu.org>
7013
7014 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7015 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7016 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7017 return Qleft_to_right.
7018
49745b39
CY
70192011-11-06 Chong Yidong <cyd@gnu.org>
7020
7021 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7022 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7023 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7024 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7025 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7026 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7027 (Fwindow_vscroll): Doc fix.
7028 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7029 argument, since it makes no sense to pass a live window and for
7030 consistency with window-child.
7031
1f05cd82
CS
70322011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7033
7034 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7035 support MSVC.
7036
22610910
JR
70372011-11-05 Jason Rumney <jasonr@gnu.org>
7038
7039 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7040 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7041 fonts (Bug#6029).
7042 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7043 bitwise arithmetic preventing use of unicode-sip and non-truetype
7044 opentype fonts.
7045
a06776b2
EZ
70462011-11-05 Eli Zaretskii <eliz@gnu.org>
7047
3ad924ba
EZ
7048 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7049 "emacs"-only part.
7050
a06776b2
EZ
7051 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7052 initialization code to keep similarity to xfns.c after changes
7053 from 2011-11-05.
7054
c9e7db78
JD
70552011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7056
a97f8f3f
JD
7057 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7058 (unwind_create_frame): New function (Bug#9943).
7059 (Fx_create_frame): Restructure code to be more similar to the one in
7060 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7061 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7062 Move terminal->reference_count++ just before making the frame official
7063 (Bug#9943).
7064
7065 * nsterm.m (x_free_frame_resources): New function.
7066 (x_destroy_window): Move code to x_free_frame_resources.
7067
c9e7db78 7068 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7069 (Fx_create_frame, x_create_tip_frame):
7070 Move terminal->reference_count++ just before making the frame
75f1671a 7071 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7072 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7073
a6fc3b5c
EZ
70742011-11-05 Eli Zaretskii <eliz@gnu.org>
7075
7076 Support MSVC build with newer versions of Visual Studio.
7077 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7078 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7079 nt/gmake.defs.
7080
7081 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7082 which are not supported by MSVC.
7083 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7084 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7085 bitfields.
7086 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7087 types in bitfields.
7088 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7089
7090 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7091
58179cce 70922011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7093
7094 Support MSVC build with newer versions of Visual Studio.
7095 * w32.c: Don't include w32api.h for MSVC.
7096 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7097
7098 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7099 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7100 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7101 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7102 e_* cousins.
7103 (alloca) [_MSC_VER]: Define to _alloca.
7104
7105 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7106
7107 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7108
a58c13ed
EZ
71092011-11-04 Eli Zaretskii <eliz@gnu.org>
7110
7111 * xdisp.c (note_mouse_highlight): If either of
7112 previous/next-single-property-change returns nil, treat that as
7113 the beginning or the end of the buffer. (Bug#9955)
7114
fe0b6370
JD
71152011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7116
a58c13ed 7117 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7118 label is not null (Bug#9951).
7119 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7120 may be NULL.
7121
89bd5ee1
EZ
71222011-11-04 Eli Zaretskii <eliz@gnu.org>
7123
7124 * window.c (Fwindow_body_size): Mention in the doc string that the
7125 return value is in frame's canonical units. (Bug#9949)
7126
84c3edb9
EZ
71272011-11-03 Eli Zaretskii <eliz@gnu.org>
7128
4e2fb5c7
EZ
7129 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7130
84c3edb9 7131 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7132 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7133 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7134
bc17a887
EZ
71352011-11-01 Eli Zaretskii <eliz@gnu.org>
7136
7137 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7138 Don't stop backward scan on the continuation glyph, even though
7139 its CHARPOS is positive.
6d5eb5b0
SM
7140 (mouse_face_from_buffer_pos, note_mouse_highlight):
7141 Rename cover_string to disp_string.
bc17a887 7142
4ee88440
MR
71432011-11-01 Martin Rudalics <rudalics@gmx.at>
7144
7145 * window.c (temp_output_buffer_show): Don't use
7146 Vtemp_buffer_show_specifiers.
7147 (Vtemp_buffer_show_specifiers): Remove unused variable.
7148
c2ff3c02
EZ
71492011-10-30 Eli Zaretskii <eliz@gnu.org>
7150
7151 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7152 past the beginning of the current glyph matrix.
7153
58179cce 71542011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7155
7156 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7157 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7158 HAVE_GTK3 (Bug#9869).
b77a6a7f 7159
3b574623
JD
7160 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7161 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7162
b77a6a7f
JD
7163 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7164
7165 * xterm.c: Declare x_handle_net_wm_state to return int.
7166 (handle_one_xevent): Check if we are iconified but don't have
7167 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7168 (get_current_wm_state): Return non-zero if not hidden,
7169 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7170 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7171 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7172 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7173
196e41e4
PE
71742011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7175
7176 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7177 so that this new function doesn't get optimized away by a
7178 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7179
021f2e1a
AS
71802011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7181
7182 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7183
8b058d44
EZ
71842011-10-29 Eli Zaretskii <eliz@gnu.org>
7185
7186 Fix the `xbytecode' command.
7187 * .gdbinit (xprintbytestr): New command.
b50a28de 7188 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7189 (xbytecode): Print the byte-code string as well.
7190
4452fb80
EZ
71912011-10-29 Kim Storm <storm@cua.dk>
7192
8b058d44
EZ
7193 * alloc.c (which_symbols): New function.
7194
21b72067
AS
71952011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7196
7197 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7198 line. (Bug#9903)
7199
83ed7b5c
GM
72002011-10-29 Glenn Morris <rgm@gnu.org>
7201
7202 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7203 Not clear what it was for, and it causes various bugs. (Bug#9839)
7204
5a7a728b
EZ
72052011-10-28 Eli Zaretskii <eliz@gnu.org>
7206
7207 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7208 possible random value that matches one of those tested as
7209 condition to clear the mouse face.
7210
d3d0842f
CY
72112011-10-28 Chong Yidong <cyd@gnu.org>
7212
7213 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7214
31b39d13
DN
72152011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7216
7217 * window.c (make_window): Initialize phys_cursor_on_p.
7218
9aba6043
SM
72192011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7220
7221 * lisp.h (struct Lisp_Symbol): Update comments.
7222
c20992f4
JB
72232011-10-28 Juanma Barranquero <lekktu@gmail.com>
7224
7225 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7226
db4f02f2
EZ
72272011-10-28 Eli Zaretskii <eliz@gnu.org>
7228
7229 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7230 <oslsachem@gmail.com> for helping to debug this.
7231
7232 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7233 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7234 (g_b_init_get_glyph_outline_w): New static variables.
7235 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7236 (GetGlyphOutlineW_Proc): New typedefs.
7237 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7238 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7239 New functions.
7240 (w32font_open_internal, compute_metrics):
7241 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7242 instead of calling the "wide" APIs directly.
7243
7244 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7245
7246 * w32.h (syms_of_w32font): Add prototype.
7247
87e68db4
JB
72482011-10-27 Juanma Barranquero <lekktu@gmail.com>
7249
7250 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7251 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7252 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7253 (Fmove_to_window_line): Doc fix.
7254
435c1d67
CY
72552011-10-27 Chong Yidong <cyd@gnu.org>
7256
7257 * process.c (make_process): Set gnutls_state to NULL.
7258
7259 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7260 non-NULL, regardless of GNUTLS_INITSTAGE.
7261 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7262 an error. Set process slots as soon as we allocate them.
7263
7264 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7265
9c6c6f49
CY
72662011-10-27 Chong Yidong <cyd@gnu.org>
7267
9aba6043
SM
7268 * gnutls.c (emacs_gnutls_deinit): New function.
7269 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7270 (Fgnutls_deinit, Fgnutls_boot): Use it.
7271
7272 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7273 (deactivate_process): Call emacs_gnutls_deinit.
7274
657d08d3
JB
72752011-10-27 Juanma Barranquero <lekktu@gmail.com>
7276
7277 * image.c (x_create_x_image_and_pixmap):
7278 * w32.c (sys_rename, w32_delayed_load):
7279 * w32font.c (fill_in_logfont):
7280 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7281
5430d399
JB
72822011-10-26 Juanma Barranquero <lekktu@gmail.com>
7283
7284 * w32fns.c (w32_default_color_map): New function,
7285 extracted from Fw32_default_color_map.
a7ef684b 7286 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7287
fe0055fa
PE
72882011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7289
7290 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7291
e6346438
SM
72922011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7293
7294 * keyboard.c (test_undefined): New function (bug#9751).
7295 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7296
e112cc37
ET
72972011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7298
7299 * sysdep.c (init_sys_modes): Fix the check for the controlling
7300 terminal (Bug#6649).
7301
7b5d6677
EZ
73022011-10-20 Eli Zaretskii <eliz@gnu.org>
7303
7304 * dispextern.h (struct bidi_it): New member next_en_type.
7305
7306 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7307 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7308 current character, check also for next_en_type being WEAK_EN.
7309 (bidi_resolve_weak): Don't enter the expensive loop if the current
7310 position is before next_en_pos. Record the bidi type of the first
7311 non-ET, non-BN character we find, in addition to its position.
7312 (bidi_level_of_next_char): Invalidate next_en_type when
7313 next_en_pos is over-stepped.
7314
7da0b018
PE
73152011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7316
7317 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7318 * editfns.c: Rewrite current-time-zone so that it invokes
7319 the equivalent of (format-time-string "%Z") to get the time zone name.
7320 This fixes a bug when the time zone name contains characters that
7321 need converting from the system time locale to Emacs internal format.
7322 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7323 that patch fixed format-time-string to do the conversion, but
7324 I forgot to fix current-time-zone.
7325 (format_time_string): New function, containing most of
7326 what Fformat_time_string used to contain.
7327 (Fformat_time_string): Rewrite in terms of format_time_string.
7328 This doesn't change this function's behavior.
7329 (current-time-zone): Rewrite to use format_time_string.
7330 This fixes the bug reported by Michael Schierl in
7331 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7332 Jason Rumney's 2007-06-07 change worked around this bug, but
7333 didn't fix it.
7334 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7335
8547b010
EZ
73362011-10-19 Eli Zaretskii <eliz@gnu.org>
7337
7338 * xdisp.c (start_display): If the character at POS is displayed
7339 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7340 (try_window_reusing_current_matrix): If a line ends in a display
7341 vector or the next line starts in a display vector, continue
7342 redrawing the window even though the character position of
7343 start_row was reached.
8547b010
EZ
7344 (Bug#9771, part 2)
7345
4e948d15
CY
73462011-10-18 Chong Yidong <cyd@gnu.org>
7347
7348 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7349 with nobreak-char-display too.
7350
4787455f
EZ
73512011-10-18 Eli Zaretskii <eliz@gnu.org>
7352
7353 Fix part 3 of bug#9771.
7354 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7355 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7356 non-neutral characters if the current character is a paragraph
7357 separator (a.k.a. Newline). This avoids running the same
7358 expensive loop twice, once when we consume the preceding newline
7359 and the other time when the line actually needs to be displayed.
7360 Avoid the loop when we see neutrals on the base embedding level
7361 following a character whose directionality is the same as the
7362 paragraph's. This avoids running the expensive loop when a line
7363 ends in a long sequence of neutrals, like control characters.
7364 Add assertion against STRONG_AL type. Slightly rearrange code
7365 that determines the type of a neutral given the first non-neutral
7366 that follows it.
7367 (bidi_level_of_next_char): Set next_en_pos to zero when
7368 invalidating its info.
7369
2c91f553
EZ
73702011-10-17 Eli Zaretskii <eliz@gnu.org>
7371
7372 * xdisp.c (push_display_prop): Determine whether to record string
7373 or buffer position by IT->string, not by IT->method. Allow
7374 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7375 (move_it_vertically_backward): Don't look for character position
7376 immediately after the newline when in a continuation line.
7377 (Bug#9771, part 1)
2c91f553 7378
c7b08b0d
MR
73792011-10-15 Martin Rudalics <rudalics@gmx.at>
7380
7381 * window.c (coordinates_in_window): Rewrite and delabelize
7382 vertical border check. (Bug#5357) (Bug#9618)
7383
6b02f655
SM
73842011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7385
7386 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7387 errors in XSetWindowBorder (bug#9310).
7388
81d40c92
DA
73892011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7390
7391 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7392 avoid crash when xmalloc overrun checking is enabled.
7393
d4172c3b
EZ
73942011-10-13 Eli Zaretskii <eliz@gnu.org>
7395
7396 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7397 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7398 cursor motion with <left> and <right> arrow keys.
7399
7400 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7401 some callers set that themselves.
7402
b00eea75
EZ
74032011-10-12 Eli Zaretskii <eliz@gnu.org>
7404
7405 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7406 display string and the previous row comes from the same string and
7407 is empty. (Bug#9739) (Bug#9738)
7408
8fe012c4
SM
74092011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7410
7411 * doc.c (get_doc_string): Encode file name (bug#9735).
7412
0074aef2
EZ
74132011-10-12 Eli Zaretskii <eliz@gnu.org>
7414
79beb178
EZ
7415 * bidi.c (bidi_level_of_next_char):
7416 * xdisp.c (get_visually_first_element): Remove old incorrect
7417 comments regarding the Unicode Line Separator character.
7418
0074aef2
EZ
7419 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7420
6e4b3fbe
DA
74212011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7422
7423 * alloc.c (Fgc_status): Do not access beyond zombies array
7424 boundary if nzombies > MAX_ZOMBIES.
7425 * alloc.c (dump_zombies): Add missing format specifier.
7426
0324f3af
PE
74272011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7428
b5525cac
PE
7429 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7430 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7431
0324f3af
PE
7432 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7433 Some packages use them to denote characters with modifiers.
7434
e9b5f888
AS
74352011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7436
7437 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7438 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7439 matching a pp-number. Rename parameter var to var1.
7440
127827c0
SM
74412011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7442
7443 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7444
c8fd3bd0
GM
74452011-10-08 Glenn Morris <rgm@gnu.org>
7446
7447 * callint.c (Fcall_interactively): Give a more explicit error for the
7448 'c' case with a non-character input. (Bug#8479)
7449
352ec8ff
EZ
74502011-10-08 Eli Zaretskii <eliz@gnu.org>
7451
03669ccb
EZ
7452 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7453 lines.
7061c986
EZ
7454 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7455 lines that are hscrolled on the left.
03669ccb 7456
352ec8ff
EZ
7457 * dispnew.c (buffer_posn_from_coords): Account for a possible
7458 presence of header-line. (Bug#4426)
7459
a66cfb1c
SM
74602011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7461
6b02f655
SM
7462 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7463 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7464
7c5ee88e
PE
74652011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7466
7467 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7468 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7469 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7470 this makes Emacs dump core during garbage collection on rare
7471 occasions. sizeof is obviously inferior to offsetof here, so
7472 stick with offsetof.
7473 (GC_POINTER_ALIGNMENT): New macro.
7474 (mark_memory): Omit 3rd (offset) arg; caller changed.
7475 Don't assume EMACS_INT alignment is the same as pointer alignment.
7476
df1bbe5b
SM
74772011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7478
7479 * keyboard.c (read_key_sequence_remapped): New var.
7480 (read_key_sequence): Compute remapping in the right buffer.
7481 (command_loop_1): Use read_key_sequence's remapping directly.
7482
51553db6
SM
74832011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7484
32c1fffd
SM
7485 * dired.c (file_name_completion): Don't expand file name.
7486 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7487 before checking file name handler.
7488
51553db6
SM
7489 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7490 they've been requested explicitly (bug#9591).
7491
b6bd1599 74922011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7493
7494 * keymap.c (Fsingle_key_description): Use make_specified_string
7495 instead of build_string to build string from push_key_description.
7496 (Bug#5193)
7497
f701dc2a
PE
74982011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7499
4222c55d
PE
7500 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7501 This fixes a Y2038 bug on 64-bit hosts.
7502 * buffer.c (reset_buffer):
7503 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7504 (Fclear_buffer_auto_save_failure):
7505 Use 0, not -1, to represent an unset failure time, since time_t
7506 might not be signed.
7507
f701dc2a
PE
7508 Remove dependency on glibc malloc internals.
7509 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7510 Move back here from lisp.h, but with their new implementations.
7511 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7512 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7513 * charset.c (charset_table_init): New static var.
7514 (syms_of_charset): Use it instead of xmalloc. This removes a
7515 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7516 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7517 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7518 Move back to alloc.c.
7519 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7520 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7521
9ceebf39
JD
75222011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7523
7524 * nsterm.m (windowDidResize): Call x_set_window_size only when
7525 ns_in_resize is true. Otherwise set pixelwidth/height and
7526 call change_frame_size (Bug#9628).
7527
cb993c58
PE
75282011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7529
3930c88b
PE
7530 Port --enable-checking=all to Fedora 14 x86-64.
7531 * charset.c (syms_of_charset): Also account for glibc malloc's
7532 internal overhead when calculating the initial malloc maximum.
7533
cb993c58
PE
7534 Port --enable-checking=all to Fedora 14 x86.
7535 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7536 Move to lisp.h.
7537 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7538 (overrun_check_realloc, overrun_check_free):
7539 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7540 That way, xmalloc returns a properly-aligned pointer even if
7541 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7542 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7543 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7544 into account when calculating the initial malloc maximum.
7545 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7546 Move here from alloc.c, so that charset.c can use it too.
7547 Properly align; the old code wasn't right for common 32-bit hosts
7548 when configured with --enable-checking=all.
7549 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7550 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7551
31bed486
EZ
75522011-09-29 Eli Zaretskii <eliz@gnu.org>
7553
04c70788 7554 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7555 use EDOM.
7556
fbcaa2f3
EZ
75572011-09-28 Eli Zaretskii <eliz@gnu.org>
7558
7559 * xdisp.c (compute_display_string_end): If there's no display
7560 string at CHARPOS, return -1.
7561
7562 * bidi.c (bidi_fetch_char): When compute_display_string_end
7563 returns a negative value, treat the character as a normal
7564 character not covered by a display string. (Bug#9624)
7565
a239d4e9
JB
75662011-09-28 Juanma Barranquero <lekktu@gmail.com>
7567
7568 * lread.c (Fread_from_string): Fix typo in docstring.
7569
88652fd5
EZ
75702011-09-27 Eli Zaretskii <eliz@gnu.org>
7571
7572 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7573 newline, reseat the iterator instead of bidi-iterating there one
7574 character at a time. (Bug#9610)
32c1fffd
SM
7575 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7576 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7577
ed497dd4
AS
75782011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7579
7580 * lread.c (readevalloop): Use correct code for NBSP.
7581 (read1): Likewise. (Bug#9608)
7582
b2bf61aa
MA
75832011-09-25 Michael Albinus <michael.albinus@gmx.de>
7584
7585 * dbusbind.c (Fdbus_register_signal): When service is not
7586 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7587
32bbb17c
GM
75882011-09-25 Glenn Morris <rgm@gnu.org>
7589
7590 * buffer.c (truncate-lines): Doc fix.
7591
94e0933e
CY
75922011-09-24 Chong Yidong <cyd@stupidchicken.com>
7593
7594 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7595 (Fset_window_next_buffers): Doc fix.
7596
cddde921
GM
75972011-09-24 Glenn Morris <rgm@gnu.org>
7598
7599 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7600
1260aef1
PE
76012011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7602
25b4bfa0
PE
7603 Fix minor problems found by static checking.
7604 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7605 * indent.c (Fvertical_motion): Fix == vs = typo.
7606
e3cbd34b
EZ
76072011-09-24 Eli Zaretskii <eliz@gnu.org>
7608
a66cfb1c
SM
7609 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7610 Default value is now t. Doc fix.
6bf7006f 7611
e3cbd34b 7612 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7613 logic when moving up, not only when moving down. Fix the
e3cbd34b 7614 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7615 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7616
7617 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7618 CHARPOS is covered by a display string which includes newlines.
7619 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7620 is covered by a display string with embedded newlines.
7621
a3de0cbd
MA
76222011-09-24 Michael Albinus <michael.albinus@gmx.de>
7623
7624 * dbusbind.c (Fdbus_register_signal): Add match rule to
7625 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7626 (Fdbus_register_method, Vdbus_registered_objects_table):
7627 Fix docstring.
a3de0cbd 7628
b260039d
JM
76292011-09-24 Jim Meyering <meyering@redhat.com>
7630
32c1fffd 7631 do not ignore write error for any output size
b260039d
JM
7632 The previous change was incomplete.
7633 While it makes emacs --batch detect the vast majority of stdout
7634 write failures, errors were still ignored whenever the output size is
7635 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7636 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7637 && echo FAIL: ignored write error
7638 FAIL: ignored write error
7639 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7640 && echo FAIL: ignored write error
7641 FAIL: ignored write error
7642 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7643
8eca8a7c
AS
76442011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7645
7646 * emacs.c (Fkill_emacs): In noninteractive mode exit
7647 non-successfully if a write error occurred on stdout. (Bug#9574)
7648
3341db62
EZ
76492011-09-21 Eli Zaretskii <eliz@gnu.org>
7650
7651 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7652 the xassert test.
7653
7654 * dispextern.h (struct it): Update the comment documenting what
7655 can it->OBJECT be.
7656
8c203dbf
EZ
76572011-09-20 Eli Zaretskii <eliz@gnu.org>
7658
7659 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7660 a display string, extend search for cursor position to end of row.
7661 (find_row_edges): If the row ends in a newline from a display
7662 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7663 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7664 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7665 non-empty line. Fixes confusing cursor motion with arrow keys at
7666 the beginning of a line that starts with whitespace.
8c203dbf 7667
a4824228
LMI
76682011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7669
7670 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7671 (bug#9493).
7672
33ed493b
CY
76732011-09-18 Chong Yidong <cyd@stupidchicken.com>
7674
7675 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7676 boolean (Bug#9154).
7677
56cd55c8
EZ
76782011-09-18 Eli Zaretskii <eliz@gnu.org>
7679
7680 * xdisp.c (display_line): Record maximum and minimum buffer
7681 positions even if no glyphs were produced (e.g., by a zero-width
7682 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7683 buffer positions that will be removed from the glyph row because
7684 they don't fit.
c02dcedf
EZ
7685 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7686 column is beyond frame width: don't subtract 1 "pixel" when
7687 computing width of the stretch.
3e62b7e0
EZ
7688 (reseat_at_next_visible_line_start): Undo the change made on
7689 2011-09-17 that saved paragraph information and restored it after
7690 the call to `reseat'. (Bug#9545)
56cd55c8 7691
5ed99d36 76922011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7693
7694 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7695 and turn window cursor on if cleared (Bug#9415).
7696
5ed99d36 76972011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7698
7699 * search.c (boyer_moore): Take unibyte characters from pattern
7700 literally. (Bug#9458)
7701
9bade7b2
EZ
77022011-09-18 Eli Zaretskii <eliz@gnu.org>
7703
7704 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7705
e5e9d610
PE
77062011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7707
87e4427a
PE
7708 Fix minor problem found by static checking.
7709 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7710 initialized, to pacify gcc -Wuninitialized.
7711
e5e9d610
PE
7712 * fileio.c: Report proper errno when syscall falls.
7713 (Finsert_file_contents): Save and restore errno,
7714 so that report_file_error outputs the correct diagnostic.
7715 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7716
a1674f0b
EZ
77172011-09-18 Eli Zaretskii <eliz@gnu.org>
7718
7719 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7720
fbfb6dd4
EZ
77212011-09-17 Eli Zaretskii <eliz@gnu.org>
7722
7723 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7724 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7725
bb187662
EZ
77262011-09-17 Eli Zaretskii <eliz@gnu.org>
7727
1137e8b8 7728 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7729 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7730
7731 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7732 (bidi_find_paragraph_start): Search back for paragraph beginning
7733 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7734 (bidi_move_to_visually_next): Only trigger paragraph-related
7735 computations when the last character is a newline or at EOB, not
7736 just any NEUTRAL_B. (Bug#9470)
7737
bb187662
EZ
7738 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7739 truncated lines if point is covered by a display string. (Bug#9524)
7740
2e621251
PE
77412011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7742
7743 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7744 (cons_to_x_long): New function.
7745 (lisp_data_to_selection_data): Use it. Correct the test for
7746 short-versus-long data; it was negated. Break out of vector
7747 loop, for efficiency, when a long datum is discovered.
7748
91a15bc6
SM
77492011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7750
7751 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7752
b41c3a35
EZ
77532011-09-16 Eli Zaretskii <eliz@gnu.org>
7754
7755 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7756 GCC PR/17406) by declaring this function with external scope.
7757
7812ba2d
PE
77582011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7759
7760 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7761 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7762
cf7edc2a
AS
77632011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7764
7765 * editfns.c (Fformat): Correctly handle text properties on "%%".
7766
bd01620e
EZ
77672011-09-15 Eli Zaretskii <eliz@gnu.org>
7768
7769 * xterm.c (x_draw_composite_glyph_string_foreground):
7770 * w32term.c (x_draw_composite_glyph_string_foreground):
7771 * term.c (encode_terminal_code):
7772 * composite.c (composition_update_it, get_composition_id):
7773 * xdisp.c (get_next_display_element)
7774 (fill_composite_glyph_string): Add comments about special meaning
7775 of TAB characters in a composition.
7776
a02719a3
PE
77772011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7778
7779 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7780 This occurs when processing a multibyte format.
7781 Problem reported by Wolfgang Jenker.
a02719a3 7782
72589a3c
JB
77832011-09-15 Johan Bockgård <bojohan@gnu.org>
7784
7785 * xdisp.c (try_cursor_movement): Only check for exact match if
7786 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7787
1c14176c
PE
77882011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7789
7790 Remove unused external symbols.
7791 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7792 * xdisp.c (calc_pixel_width_or_height): Now static.
7793 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7794 * indent.c (check_display_width):
7795 * w32term.c: Fix comment to match code.
7796 * xterm.c, xterm.h (x_catching_errors): Remove.
7797
d2eea5b5
PE
77982011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7799
7800 * xselect.c: Use signed conversions more consistently (Bug#9498).
7801 (selection_data_to_lisp_data): Assume incoming selection data are
7802 signed integers, not unsigned. This is to be consistent with
7803 outgoing selection data, which was modified to use signed integers
7804 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7805 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7806 expects long, not unsigned long.
7807
46888499
EZ
78082011-09-14 Eli Zaretskii <eliz@gnu.org>
7809
7810 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7811 computation of loop end. Reported by Johan Bockgård
7812 <bojohan@gnu.org>.
7813
ef8ef9fb
CY
78142011-09-13 Chong Yidong <cyd@stupidchicken.com>
7815
7816 * frame.c (Fother_visible_frames_p): Function deleted.
7817
fa819fed
EZ
78182011-09-12 Eli Zaretskii <eliz@gnu.org>
7819
7820 * indent.c (compute_motion): Process display vector front to back
7821 rather than the other way around. (Bug#2496)
7822
2ba8e008
SM
78232011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7824
7825 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7826
20f53c69
CY
78272011-09-11 Chong Yidong <cyd@stupidchicken.com>
7828
7829 * minibuf.c (Fread_from_minibuffer): Doc fix.
7830
d562d7a4
EZ
78312011-09-11 Eli Zaretskii <eliz@gnu.org>
7832
7833 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7834 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7835
1c4d7f3d
LMI
78362011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7837
7838 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7839 value for non-existent files.
7840
b885bf36
EZ
78412011-09-11 Eli Zaretskii <eliz@gnu.org>
7842
7843 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7844 set its "size" to -1. This will set the modtime_size field of
7845 the corresponding buffer to -1, which is what
7846 verify-visited-file-modtime expects for files that do not exist.
7847 (Bug#9139)
7848
6612f0bf
PE
78492011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7850
7851 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7852 here ...
7853 * lisp.h: ... from here. push_key_description is no longer
7854 defined in keyboard.c, so its declaration should not be in
7855 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7856 logically belongs with push_key_description.
7857
dfb3f755
PE
78582011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7859
7860 * buffer.h: Include <sys/types.h> instead of <time.h>.
7861 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7862 Problem reported by Herbert J. Skuhra.
7863
3134906c
LMI
78642011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7865
7866 * xml.c (parse_region): Make the parsing work for
7867 non-comment-starting XML files again (bug#9144).
7868
8d903f4e
AS
78692011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7870
7871 * image.c (gif_load): Fix calculation of bottom and right corner.
7872 (Bug#9468)
7873
80ad64f4
EZ
78742011-09-10 Eli Zaretskii <eliz@gnu.org>
7875
7876 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7877 redisplay in small windows.
7878
208a048d
EZ
78792011-09-09 Eli Zaretskii <eliz@gnu.org>
7880
7881 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7882
9b1c252e
MR
78832011-09-08 Martin Rudalics <rudalics@gmx.at>
7884
7885 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7886 Operate on live windows only.
7887
2949f33b
JB
78882011-09-08 Juanma Barranquero <lekktu@gmail.com>
7889
7890 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7891
e08dcafd
EZ
78922011-09-07 Eli Zaretskii <eliz@gnu.org>
7893
7894 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7895 only under bidi iteration.
7896
115b96bd
JD
78972011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7898
7899 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7900
c8199d0f
PE
79012011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7902
7903 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7904 Without this fix, the command to link temacs failed due to an
7905 undefined symbol __builtin_isnan. This is because
7906 /usr/include/iso/math_c99.h #defines isnan(x) to
7907 __builtin_isnan(x), but the bundled gcc, which identifies itself
7908 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7909 a __builtin_isnan.
7910 * floatfns.c (isnan): #undef, and then #define to a clone of
7911 what's in data.c.
7912 (Fisnan): Always define, since it's always available now.
7913 (syms_of_floatfns): Always define isnan at the Lisp level.
7914
e39b275c 79152011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7916
7917 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7918
b2db44d9 79192011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7920
f4af5137 7921 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7922 The previous code assumed that file offsets (off_t values) fit in
7923 EMACS_INT variables, which is not true on typical 32-bit hosts.
7924 The code messed up by falsely reporting buffer overflow in cases
7925 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7926 when "big" contains more than 2**29 bytes, even though this
7927 inserts just one byte and does not overflow the buffer.
7928 (Finsert_file_contents): Store file offsets as off_t
7929 values, not as EMACS_INT values. Check for overflow when
7930 converting between EMACS_INT and off_t. When checking for
7931 buffer overflow or for overlap, take the offsets into account.
7932 Don't use EMACS_INT for small values where int suffices.
7933 When checking for overlap, fix a typo: ZV was used where
7934 ZV_BYTE was intended.
7935 (Fwrite_region): Don't assume off_t fits into 'long'.
7936 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7937
ecfc0a49
MA
79382011-09-05 Michael Albinus <michael.albinus@gmx.de>
7939
7940 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7941
6511acf2 79422011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7943
0999621a 7944 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7945
7946 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7947 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7948 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7949 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7950 (modify_event_symbol): Do not assume that the length of
7951 name_alist_or_stem is safe to alloca and fits in int.
7952 (Fexecute_extended_command): Likewise for function name and binding.
7953 (Frecursion_depth): Wrap around reliably on integer overflow.
7954 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7955 since some callers pass EMACS_INT values.
7956 (Fsingle_key_description): Don't crash if symbol name contains more
7957 than MAX_ALLOCA bytes.
7958 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7959 (get_minibuffer): Arg is now EMACS_INT, not int.
7960 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7961 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7962 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7963
2be7d702
PE
7964 * dbusbind.c (signature_cat): New function.
7965 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7966 Do not overrun buffer; instead, report string overflow.
7967
9d1df220
PE
7968 * dispnew.c (add_window_display_history): Don't overrun buffer.
7969 Truncate instead; this is OK since it's just a log.
7970
33ef5c64
PE
7971 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7972 even if the time zone offset is outlandishly large.
7973 Don't mishandle offset == INT_MIN.
7974
66c6fdd5
PE
7975 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7976 when creating daemon; the previous buffer-overflow check was incorrect.
7977
d749b01b
PE
7978 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7979 which has the guts of the old verror function.
7980
b5cd1905
PE
7981 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7982 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7983
6e1a67fb
PE
7984 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7985 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7986 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7987 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7988 length of string rather than counting it via multiple sprintfs;
7989 that's simpler and more reliable.
c21721cc
PE
7990 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7991 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7992 sprintf, in case result does not fit in int.
7993
c57b67fc
PE
7994 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7995 (fontset_from_font): Print it.
7996
8a401434
PE
7997 * frame.c (tty_frame_count): Now printmax_t, not int.
7998 (make_terminal_frame, set_term_frame_name): Print it.
7999 (x_report_frame_params): In X, window IDs are unsigned long,
8000 not signed long, so print them as unsigned.
8001 (validate_x_resource_name): Check for implausibly long names,
8002 and don't assume name length fits in 'int'.
8003 (x_get_resource_string): Don't blindly alloca invocation name;
8004 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8005 not fit in int.
8006
6e1a67fb
PE
8007 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8008 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8009 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8010
0df02bf3
PE
8011 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8012 Use esprintf, not sprintf, in case result does not fit in int.
8013
48e30793
PE
8014 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8015 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8016 it as a large positive number.
8017 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8018 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8019
a66ff6d8
PE
8020 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8021 in case result does not fit in int.
8022
aca216ff
PE
8023 * print.c (float_to_string): Detect width overflow more reliably.
8024 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8025 buffer overrun. Don't assume list length fits in 'int'. Treat
8026 print length of 0 as 0, not as infinity; to be consistent with other
8027 uses of print length in this function. Don't overflow print length
8028 index. Don't assume hash table size fits in 'long', or that
8029 vectorlike size fits in 'unsigned long'.
8030
31c286f7
PE
8031 * process.c (make_process): Use printmax_t, not int, to format
8032 process-name gensyms.
8033
55e5faa1
PE
8034 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8035
80f2e268
PE
8036 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8037 to avoid potential buffer overrun.
8038
670741ab
PE
8039 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8040 if X resource line is longer than 512 bytes.
8041
b7163a50
PE
8042 * xfns.c (x_window): Make sprintf buffer a bit bigger
8043 to avoid potential buffer overrun.
8044
ae58ff1f
PE
8045 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8046
c43c8a6a
PE
8047 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8048
3f8236f4
PE
80492011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8050
53e9fe90 8051 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8052 Without these, Emacs silently mishandles large integers sometimes.
8053 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8054 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8055
6511acf2
PE
8056 * xdisp.c (try_window_id): Check Emacs fixnum range before
8057 converting to 'int'.
806add1d 8058
6511acf2 8059 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8060 Check that an Emacs fixnum is in range before assigning it to 'int'.
8061 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8062 values converted from Emacs fixnums.
8063 (Frecenter): Don't wrap around a line count if it is out of 'int'
8064 range; instead, treat it as an extreme value.
8065 (Fset_window_configuration, compare_window_configurations):
8066 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8067
6511acf2
PE
8068 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8069 that can exceed INT_MAX. Check that EMACS_INT value is in range
8070 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8071 (match_limit): Don't assume that a fixnum can fit in 'int'.
8072
6511acf2 8073 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8074 exceed INT_MAX.
8075
6511acf2 8076 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8077 (Fvertical_motion): Don't wrap around LINES values that don't fit
8078 in 'int'. Instead, treat them as extreme values. This is good
8079 enough for windows, which can't have more than INT_MAX lines anyway.
8080
fcb901a7
LMI
80812011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8082
0f2f6b6d
LMI
8083 * Require libxml/parser.h to avoid compilation warning.
8084
fcb901a7
LMI
8085 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8086
8087 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8088 since this reportedly can destroy thread storage.
8089
6e20a0d4
CY
80902011-08-30 Chong Yidong <cyd@stupidchicken.com>
8091
8092 * syntax.c (find_defun_start): Update all cache variables if
8093 exiting early (Bug#9401).
8094
148ae00e
EZ
80952011-08-30 Eli Zaretskii <eliz@gnu.org>
8096
f6cfbd8f
EZ
8097 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8098
148ae00e
EZ
8099 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8100 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8101 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8102
8103 * term.c (tty_append_glyph): New function.
8104 (produce_stretch_glyph): Static function and its prototype deleted.
8105
a66cfb1c
SM
8106 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8107 Add prototypes.
148ae00e 8108
c4a07a4c
PE
81092011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8110
8111 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8112 when checking :margin (Bug#9390).
8113 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8114 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8115 so that the name doesn't mislead. All uses changed.
8116
6bc8cd65
JB
81172011-08-28 Johan Bockgård <bojohan@gnu.org>
8118
8119 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8120 set_tty_hooks.
8121
dca4927e
EZ
81222011-08-27 Eli Zaretskii <eliz@gnu.org>
8123
8124 * xdisp.c (move_it_to): Don't bail out early when reaching
8125 position beyond to_charpos, if we are scanning backwards.
8126 (move_it_vertically_backward): When DY == 0, make sure we get to
8127 the first character in the line after the newline.
8128
f2cad773
PE
81292011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8130
8131 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8132 (ccl_driver): Do not generate an out-of-range pointer.
8133 (Fccl_execute_on_string): Remove unnecessary check for
8134 integer overflow, noted by Stefan Monnier in
8135 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8136 Remove a FIXME that didn't need fixing.
8137 Simplify the newly-introduced buffer reallocation code.
8138
0cae2cdb
JB
81392011-08-27 Juanma Barranquero <lekktu@gmail.com>
8140
8141 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8142
5fc295a4 81432011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8144
70c60eb2 8145 Integer and memory overflow issues (Bug#9196).
726e0ab1 8146
d31850da
PE
8147 * doc.c (get_doc_string): Rework so that
8148 get_doc_string_buffer_size is the actual buffer size, rather than
8149 being 1 less than the actual buffer size; this makes xpalloc more
8150 convenient.
8151
a69fbedb
PE
8152 * image.c (x_allocate_bitmap_record, cache_image):
8153 * xselect.c (Fx_register_dnd_atom):
8154 Simplify previous changes by using xpalloc.
8155
fe5c5d37
PE
8156 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8157 since either will do and ptrdiff_t is convenient with xpalloc.
8158
0065d054
PE
8159 * charset.c (charset_table_size)
8160 (struct charset_sort_data.priority): Now ptrdiff_t.
8161 (charset_compare): Don't overflow if priorities differ greatly.
8162 (Fsort_charsets): Don't assume list length fits in int.
8163 Check for size-calculation overflow when allocating sort data.
8164 (syms_of_charset): Allocate an initial charset table that is
8165 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8166
8167 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8168
8169 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8170 The actual value is always <= INT_MAX, and leaving it unsigned made
8171 overflow checking harder.
8172
8173 * dispextern.h (struct glyph_matrix.rows_allocated)
8174 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8175 with xpalloc. The values are still always <= INT_MAX.
8176
8177 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8178
8179 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8180 (SAFE_NALLOCA): New macro.
8181
8182 * region-cache.c (struct boundary.pos, find_cache_boundary)
8183 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8184 (set_cache_region, invalidate_region_cache)
8185 (revalidate_region_cache, know_region_cache, region_cache_forward)
8186 (region_cache_backward, pp_cache):
8187 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8188 so that ptrdiff_t * can be passed to xpalloc.
8189 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8190 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8191 (pp_cache): Don't assume cache_len fits in int.
8192 * region-cache.h: Adjust extern decls to match.
8193
8194 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8195 EMACS_INT, since either will do, for xpalloc.
8196
8197 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8198 (xnmalloc, xnrealloc, xpalloc): New functions.
8199
726e0ab1
PE
8200 * bidi.c (bidi_shelve_header_size): New constant.
8201 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8202 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8203
51f30bc5 8204 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8205 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8206 (overlay_strings):
8207 Don't update size of array until after memory allocation succeeds,
8208 because xmalloc/xrealloc may not return.
0065d054
PE
8209 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8210 now that we have proper integer overflow checking.
8211 (record_overlay_string, overlay_strings): Catch overflows when
8212 calculating size of overlay_str_buf.
726e0ab1 8213
0065d054
PE
8214 * callproc.c (Fcall_process): Check for size overflow when
8215 calculating size of args2.
8216 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8217 Normally we prefer signed values, but sticking with ptrdiff_t would
8218 require adding more-complicated checks.
726e0ab1
PE
8219
8220 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8221 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8222 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8223 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8224
8225 * character.c (Fstring): Check for size-calculation overflow.
8226
8227 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8228 unnecessary integer overflow. Check for size overflow.
8229 (encode_coding_object): Don't update size until xmalloc succeeds.
8230
8231 * composite.c (get_composition_id): Check for overflow in glyph
8232 length calculations.
8233
8234 Integer and memory overflow fixes for display code.
8235 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8236 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8237 (scrolling_window): Check for overflow in size calculations.
8238 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8239 Don't assume glyph table len fits in int.
8240 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8241 (row_table_size): Now ptrdiff_t, not int.
8242 (scrolling_window): Avoid overflow in size calculations.
8243 Don't update size until allocation succeeds.
8244 * fns.c (concat): Check for overflow in size calculations.
8245 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8246 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8247 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8248
8249 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8250 (get_doc_string): Check for size calculation overflow.
8251 Don't update size until allocation succeeds.
8252 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8253 EMACS_INT, where ptrdiff_t will do.
8254 (Fsubstitute_command_keys): Check for string overflow.
8255
8256 * editfns.c (set_time_zone_rule): Don't assume environment length
8257 fits in int.
8258 (message_length): Now ptrdiff_t, not int.
8259 (Fmessage_box): Don't update size until allocation succeeds.
8260 Don't assume message length fits in int.
8261 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8262
0065d054
PE
8263 * emacs.c (main): Do not reallocate argv, since there is a null at
8264 the end that can be overwritten, and this way there's no need to
8265 worry about size-calculation overflow.
8266 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8267
8268 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8269 alloc succeeds.
8270 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8271
8272 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8273 (x_set_scroll_bar_width, x_figure_window_size):
8274 Check for integer overflow.
8275 (x_set_alpha): Do not assume XINT fits in int.
8276
8277 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8278 This is for the members text_lines, text_cols, total_lines, total_cols,
8279 where the system imposes an 'int' limit.
8280
8281 * fringe.c (Fdefine_fringe_bitmap):
8282 Don't update size until alloc works.
8283
8284 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8285 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8286
8287 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8288 Check for size-calculation overflow.
8289 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8290 do, as we prefer signed integers.
8291 (id_to_widget.max_size, id_to_widget.used)
8292 (xg_store_widget_in_map, xg_remove_widget_from_map)
8293 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8294 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8295 Use and return ptrdiff_t, not int.
8296 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8297 * gtkutil.h: Change prototypes to match the above.
8298
8299 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8300 are duplicate now that they've been promoted to lisp.h.
8301 (x_allocate_bitmap_record, x_alloc_image_color)
8302 (make_image_cache, cache_image, xpm_load):
8303 Don't update size until alloc is done.
8304 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8305 (x_detect_edges):
3256efce 8306 Check for size calculation overflow.
726e0ab1
PE
8307 (ct_colors_allocated_max): New constant.
8308 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8309 overflow.
3256efce 8310
726e0ab1
PE
8311 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8312 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8313 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8314 Use ptrdiff_t, not int, to count maps.
8315 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8316 calculations. Don't update size until allocation succeeds.
8317 Redo calculations to avoid overflow.
726e0ab1
PE
8318 * keyboard.h: Change prototypes to match the above.
8319
8320 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8321 to count maps.
8322 (current_minor_maps): Check for size calculation overflow.
8323 * keymap.h: Change prototypes to match the above.
8324
8325 * lread.c (read1, init_obarray): Don't update size until alloc done.
8326
8327 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8328 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8329
726e0ab1
PE
8330 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8331 Now ptrdiff_t, not int.
8332 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8333 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8334
8335 * process.c (Fnetwork_interface_list): Check for overflow
8336 in size calculation.
8337
8338 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8339
8340 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8341 overflow. Don't bother calling xmalloc when xrealloc will do.
8342
8343 * search.c (Freplace_match): Check for size calculation overflow.
8344 (Fset_match_data): Don't assume list lengths fit in 'int'.
8345
8346 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8347 for command line length. Do not attempt to address one before the
8348 beginning of an array, as that's not portable.
8349
8350 * term.c (max_frame_lines): Remove; unused.
8351 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8352 not int.
8353 (encode_terminal_code, calculate_costs): Check for size
8354 calculation overflow.
8355 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8356 table lengths and related sizes. Don't update size until alloc
8357 done. Redo calculations to avoid overflow.
8358 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8359
8360 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8361 subtracting pointers.
8362 (gobble_line): Check for overflow more carefully. Don't update size
8363 until alloc done.
8364
8365 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8366 Don't update size until alloc done.
8367 Redo size calculations to avoid overflow.
8368 Check for size calculation overflow.
0065d054 8369 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8370
8371 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8372 Use ptrdiff_t, not int, for sizes.
8373 (store_mode_line_noprop_char): Don't update size until alloc done.
8374
0065d054
PE
8375 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8376 Use ptrdiff_t, not int, for sizes.
8377 (Finternal_make_lisp_face, cache_face):
8378 Check for size calculation overflow.
8379 (cache_face): Treat size calculation overflows as if they were
8380 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8381
8382 * xfns.c (x_encode_text, x_set_name_internal)
8383 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8384 sizes, since they can exceed INT_MAX in size. Check for size
8385 calculation overflow.
8386
0065d054
PE
8387 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8388 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8389 Don't update size until alloc done.
8390
0065d054 8391 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8392 as sprintf is limited to int lengths.
1d526e2f 8393
252c5ee1
PE
8394 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8395 (X_LONG_MIN): New macros.
864d7ce7
PE
8396 Use them to make the following changes clearer.
8397 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8398 This change doesn't affect the value now, but it may help remind
8399 future maintainers not to raise the value too much later.
8400 (SELECTION_QUANTUM): Remove, replacing with ...
8401 (selection_quantum): ... new function, which avoids overflow.
8402 All uses changed.
8403 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8404 assumption that selection length fits in 'int'.
8405 (x_reply_selection_request, x_handle_selection_request)
8406 (x_get_window_property, receive_incremental_selection)
8407 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8408 (lisp_data_to_selection_data, clean_local_selection_data):
8409 Use ptrdiff_t, not int, to record length of selection.
8410 (x_reply_selection_request, x_get_window_property)
8411 (receive_incremental_selection, x_property_data_to_lisp):
8412 Redo calculations to avoid overflow.
8413 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8414 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8415 something.
8416 (x_get_window_property, receive_incremental_selection)
8417 (lisp_data_to_selection_data, x_property_data_to_lisp):
8418 Check for size-calculation overflow.
8419 (x_get_window_property, receive_incremental_selection)
8420 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8421 Don't store size until memory allocation succeeds.
8422 (x_get_window_property): Plug memory leak on memory exhaustion.
8423 Don't double-block input; malloc is safe here. Don't assume 2**34
8424 - 4 fits in unsigned long. Add an xassert to check
8425 XGetWindowProperty overflow. Be more careful about overflow
8426 calculations, and distinguish size from memory overflow better.
8427 (receive_incremental_selection): When tracing, don't assume
8428 unsigned int is less than INT_MAX.
8429 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8430 harmful) conversions of unsigned short to int.
8431 (lisp_data_to_selection_data): Don't assume that integers
8432 in the range -65535 through -1 fit in an X unsigned short.
8433 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8434 result parameters unless successful. Rely on cons_to_unsigned
8435 to report problems with elements; the old code wasn't right anyway.
8436 (x_check_property_data): Check for int overflow; we cannot use
8437 a wider type due to X limits.
8438 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8439
726e0ab1 8440 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8441
0065d054
PE
8442 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8443 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8444 (x_color_cells): Don't store size until memory allocation succeeds.
8445 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8446 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8447 (x_term_init): Don't assume length fits in int (sprintf is limited
8448 to int size).
bc18e09d 8449
ebfa62c0
PE
8450 Use ptrdiff_t for composition IDs.
8451 * character.c (lisp_string_width):
8452 * composite.c (composition_table_size, n_compositions)
8453 (get_composition_id, composition_gstring_from_id):
8454 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8455 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8456 * window.c (Frecenter):
8457 Use ptrdiff_t, not int, for composition IDs.
8458 * composite.c (get_composition_id): Check for integer overflow.
8459 * composite.h: Adjust prototypes to match the above changes.
8460
d3411f89
PE
8461 Use ptrdiff_t for hash table indexes.
8462 * category.c (hash_get_category_set):
8463 * ccl.c (ccl_driver):
8464 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8465 * coding.c (coding_system_charset_list, detect_coding_system):
8466 * coding.h (struct coding_system.id):
8467 * composite.c (get_composition_id, gstring_lookup_cache):
8468 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8469 * image.c (xpm_get_color_table_h):
8470 * lisp.h (hash_lookup, hash_put):
8471 * minibuf.c (Ftest_completion):
8472 Use ptrdiff_t for hash table indexes, not int (which is too
8473 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8474 32-bit --with-wide-int hosts).
8475
e097a6fa
PE
8476 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8477 Add a FIXME comment about memory leaks.
8478 (syms_of_charset): Don't assume xmalloc returns.
8479
5637687f
PE
8480 Don't assume that stated character widths fit in int.
8481 * character.c (Fchar_width, c_string_width, lisp_string_width):
8482 * character.h (CHAR_WIDTH):
8483 * indent.c (MULTIBYTE_BYTES_WIDTH):
8484 Use sanitize_char_width to avoid undefined and/or bad behavior
8485 with outlandish widths.
a66cfb1c 8486 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8487 now that we have two such functions. All uses changed.
8488 (sanitize_char_width): New inline function.
8489
a2271ba2
PE
8490 Don't assume that tab-width fits in int.
8491 * character.h (sanitize_width): New inline function.
8492 (SANE_TAB_WIDTH): New macro.
8493 (ASCII_CHAR_WIDTH): Use it.
8494 * indent.c (sane_tab_width): Remove. All uses replaced by
8495 SANE_TAB_WIDTH (current_buffer).
8496 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8497
18c52557
PE
8498 * fileio.c: Integer overflow issues with file modes.
8499 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8500
caeeedc1
PE
8501 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8502 Remove unreachable code.
8503 (read_hex, load_charset_map_from_file): Check for integer overflow.
8504
6df6ae42 8505 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8506 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8507 (x_send_scroll_bar_event): Likewise. Check that the size does not
8508 exceed limits imposed by XClientMessageEvent, as well as the usual
8509 ptrdiff_t and size_t limits.
8510
b13995db
PE
8511 * keyboard.c: Overflow, signedness and related fixes.
8512 (make_lispy_movement): Use same integer type in forward decl
8513 that is used in the definition.
8514 (read_key_sequence, keyremap_step):
8515 Change bufsize argument back to int, undoing my 2011-03-30 change.
8516 We prefer signed types, and int is wide enough here.
8517 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8518 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8519 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8520 length, not size_t. Use ptrdiff_t for index, not int.
8521 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8522 possibility of integer overflow.
8523
13464394
PE
8524 Overflow, signedness and related fixes for images.
8525
8526 * dispextern.h (struct it.stack[0].u.image.image_id)
8527 (struct_it.image_id, struct image.id, struct image_cache.size)
8528 (struct image_cache.used, struct image_cache.ref_count):
8529 * gtkutil.c (update_frame_tool_bar):
8530 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8531 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8532 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8533 * nsmenu.m (update_frame_tool_bar):
8534 * xdisp.c (calc_pixel_width_or_height):
8535 * xfns.c (image_cache_refcount):
8536 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8537 on typical 64-bit hosts.
8538
8539 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8540 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8541 Omit unnecessary casts to int.
8542 (parse_image_spec): Check that integers fall into 'int' range
8543 when the callers expect that.
8544 (image_ascent): Redo ascent calculation to avoid int overflow.
8545 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8546 (lookup_image): Remove unnecessary tests.
8547 (xbm_image_p): Locals are now of int, not EMACS_INT,
8548 since parse_image_check makes sure they fit into int.
8549 (png_load, gif_load, svg_load_image):
8550 Prefer int to unsigned where either will do.
8551 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8552 old tiff_error_handler and tiff_warning_handler.
8553 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8554 stack buffer overflows. It uses only the features of vsnprintf
8555 that are common to both POSIX and native Microsoft.
8556 (tiff_error_handler, tiff_warning_handler): Use it.
8557 (tiff_load, gif_load, imagemagick_load_image):
8558 Don't assume :index value fits in 'int'.
8559 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8560 (imagemagick_load_image): Check that crop parameters fit into
8561 the integer types that MagickCropImage accepts. Don't assume
8562 Vimagemagick_render_type has a nonnegative value. Don't assume
8563 size_t fits in 'long'.
8564 (gs_load): Use printmax_t to print the widest integers possible.
8565 Check for integer overflow when computing image height and width.
8566
c11821d4
EZ
85672011-08-26 Eli Zaretskii <eliz@gnu.org>
8568
8569 * xdisp.c (redisplay_window): Don't force window start if point
8570 will be invisible in the resulting window. (Bug#9324)
8571
0c95fcf7
EZ
85722011-08-25 Eli Zaretskii <eliz@gnu.org>
8573
8574 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8575 the display spec is of the form `(space ...)'.
8576 (handle_display_spec): Return the value returned by
8577 handle_single_display_spec, not just 1 or zero.
8578 (handle_single_display_spec): If the display spec is of the form
8579 `(space ...)', and specifies display in the text area, return 2
8580 rather than 1.
fee65a97 8581 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8582 accurately, and prefer exact match for point under bidi.
8583 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8584
8585 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8586 into disp_prop; all users changed.
8587
8588 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8589 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8590 for the text covered by the display property.
8591
e4ed06f1
CY
85922011-08-25 Chong Yidong <cyd@stupidchicken.com>
8593
8594 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8595 Change return value to nil.
8596 (Frecord_buffer): Delete unused function.
8597
f67cdd7f
EZ
85982011-08-24 Eli Zaretskii <eliz@gnu.org>
8599
5980d4c6
EZ
8600 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8601 buffers, return left-to-right.
8610fe8b
EZ
8602 (set_cursor_from_row): Consider candidate row a win if its glyph
8603 represents a newline and point is on that newline. Fixes cursor
8604 positioning on the newline at EOL of R2L text within L2R
8605 paragraph, and vice versa.
8606 (try_cursor_movement): Check continued rows, in addition to
8607 continuation rows. Fixes unwarranted scroll when point enters a
8608 continued line of R2L text within an L2R paragraph, or vice versa.
8609 (cursor_row_p): Consider the case of point being equal to
8610 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8611 from the end of a short line to the beginning of a continued line
8612 of R2L text within L2R paragraph.
8613 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8614 composed characters.
5980d4c6 8615
f67cdd7f
EZ
8616 * bidi.c (bidi_check_type): Use xassert.
8617 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8618 members.
8619
bca633fb
EZ
86202011-08-23 Eli Zaretskii <eliz@gnu.org>
8621
8622 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8623 a character.
8624
4a5885a7
CY
86252011-08-23 Chong Yidong <cyd@stupidchicken.com>
8626
8627 * nsfont.m (ns_otf_to_script): Fix typo.
8628
0902a04e
KH
86292011-08-22 Kenichi Handa <handa@m17n.org>
8630
8631 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8632 extra slot even if the purpose is char-code-property-table.
8633
1a2e6670
EZ
86342011-08-23 Eli Zaretskii <eliz@gnu.org>
8635
8ddde651
EZ
8636 * xdisp.c (redisplay_window): When computing centering_position,
8637 account for the height of the header line. (Bug#8874)
8638
425cc014
EZ
8639 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8640 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8641 candidate is selected by the mouse, and that candidate has a
8642 composed character under the mouse.
8643
1a2e6670
EZ
8644 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8645 coordinates reported by pos-visible-in-window-p for a composed
8646 character in column zero.
8647
8b76d6f8
SM
86482011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8649
8650 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8651
dac347dd
EZ
86522011-08-22 Eli Zaretskii <eliz@gnu.org>
8653
8654 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8655 consider it a hit if to_charpos is anywhere in the range of the
8656 composed buffer positions.
8657
e013fb34
CY
86582011-08-22 Chong Yidong <cyd@stupidchicken.com>
8659
8660 * image.c (gif_load): Don't assume that each subimage has the same
8661 dimensions as the base image. Handle disposal method that is
8662 "undefined" by the gif spec (Bug#9335).
8663
bd1ba3e8
CY
86642011-08-20 Chong Yidong <cyd@stupidchicken.com>
8665
8666 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8667 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8668
54a1215b
EZ
86692011-08-19 Eli Zaretskii <eliz@gnu.org>
8670
823564e5
EZ
8671 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8672 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8673 from an Org mode buffer to a Speedbar frame.
8674
54a1215b
EZ
8675 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8676 a composition, take its buffer position from IT->cmp_it.charpos.
8677 Fixes cursor positioning at the beginning of a line that begins
8678 with a composed character.
8679
9778ebcc
EZ
86802011-08-18 Eli Zaretskii <eliz@gnu.org>
8681
0be6ee06
EZ
8682 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8683 character bidirectional type, use STRONG_L instead. Fixes crashes
8684 in a buffer produced by `describe-categories'.
8685
9778ebcc
EZ
8686 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8687 members before the level stack, so they would be saved and
8688 restored when copying iterator state. Fixes incorrect reordering
8689 around TABs covered by display properties.
8690
156bffbe
AS
86912011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8692
6b02f655 8693 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8694
72ad093b
CY
86952011-08-17 Chong Yidong <cyd@stupidchicken.com>
8696
8697 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8698 (internal_condition_case_2, internal_condition_case_n):
8699 Remove unnecessary aborts (Bug#9081).
72ad093b 8700
35774242
EZ
87012011-08-17 Eli Zaretskii <eliz@gnu.org>
8702
8703 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8704 has no `load' handler, try opening the file locally. (Bug#9311)
8705
db76dd85
KB
87062011-08-16 Ken Brown <kbrown@cornell.edu>
8707
8708 * gmalloc.c: Expand comment.
8709
b215eee5
EZ
87102011-08-16 Eli Zaretskii <eliz@gnu.org>
8711
8712 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8713 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8714
a4579d33
KB
87152011-08-16 Ken Brown <kbrown@cornell.edu>
8716
8717 Fix memory allocation problems in Cygwin build (Bug#9273).
8718
8719 * unexcw.c ( __malloc_initialized): Declare external variable.
8720 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8721
8b76d6f8
SM
8722 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8723 New variables.
a4579d33
KB
8724 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8725 dumped emacs.
8726 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8727 in the static heap.
8728 [CYGWIN] (special_realloc): New function.
8729 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8730 requests to realloc storage in the static heap.
8731
3ebec551
PE
87322011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8733
8734 * bidi.c (bidi_initialize): Remove unused local.
8735
9fd8be00
EZ
87362011-08-15 Eli Zaretskii <eliz@gnu.org>
8737
6b02f655
SM
8738 * bidimirror.h:
8739 * biditype.h: Remove file.
8740 * makefile.w32-in ($(BLD)/bidi.$(O)):
8741 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8742
8743 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8744
8745 * chartab.c: Improve commentary for the uniprop_table API.
8746
32413314
EZ
8747 * bidi.c (bidi_paragraph_init): Support zero value of
8748 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8749 (bidi_initialize): Use uniprop_table instead of including
8750 biditype.h and bidimirror.h.
32413314 8751
9fd8be00
EZ
8752 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8753 coordinates of the iterator when restoring from ppos_it.
8754 (Bug#9296)
8755
5cf2b69b
KH
87562011-08-14 Kenichi Handa <handa@m17n.org>
8757
8758 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8759 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8760
daf17d00
EZ
87612011-08-14 Eli Zaretskii <eliz@gnu.org>
8762
8763 * xdisp.c (move_it_in_display_line_to): Don't invoke
8764 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8765 ppos_it. Fixes vertical cursor motion when line beginning is
8766 covered by an image. (Bug#9296)
8767
08e3161a
JD
87682011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8769
8770 * nsterm.h (ns_run_ascript): Declare.
8771 (NSAPP_DATA2_RUNASSCRIPT): Define.
8772
8773 * nsfns.m (as_script, as_result, as_status): New static variables.
8774 (ns_run_ascript): New function.
5e617bc2 8775 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8776 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8777 the event loop. Get status from as_status (Bug#7276).
8778
8779 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8780 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8781 the event loop (Bug#7276).
8782
a3720aa2
AS
87832011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8784
8785 * gnutls.c (QCgnutls_bootprop_priority)
8786 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8787 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8788 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8789 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8790 (QCgnutls_bootprop_verify_hostname_error)
8791 (QCgnutls_bootprop_callbacks_verify): Rename from
8792 Qgnutls_bootprop_..., all uses changed.
8793
8794 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8795 uses changed.
8796
0a0d27fb
PE
87972011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8798
19d5c50c
PE
8799 * xfaces.c (Qframe_set_background_mode): Now static.
8800 * dispextern.h (Qframe_set_background_mode): Remove decl.
8801
0a0d27fb
PE
8802 * process.c (Fnetwork_interface_info): Declare local only if needed.
8803
377538cb
JD
88042011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8805
8806 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8807 (Fnetwork_interface_list): Allocate in increments of bytes instead
8808 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8809 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8810 sockaddr.
8811 (struct ifflag_def): notrailers is smart on OSX.
8812 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8813 Get hardware address with getifaddrs if available.
8814
08fff70c
EZ
88152011-08-12 Eli Zaretskii <eliz@gnu.org>
8816
8817 * xdisp.c (iterate_out_of_display_property): xassert that
8818 IT->position is set to within IT->object's boundaries. Break from
8819 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8820 when IT->position is set up wrongly due to some bug.
8821 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8822 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8823 entry. Force push_it to save on the stack the current
8824 buffer/string position, to be restored by pop_it. Fix flags in
8825 the iterator structure wrt the object coming from a display
8826 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8827 properties. (Bug#9284)
8828
7be1c708 88292011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8830
7be1c708
CY
8831 * fontset.c (fontset_get_font_group): Add proper type checks.
8832 (Bug#9172)
aac0c6e3 8833
7be1c708 88342011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8835
7be1c708
CY
8836 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8837 and LC_VERSION_MIN_MACOSX.
8838 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8839 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8840
97bb72a6
EZ
88412011-08-08 Eli Zaretskii <eliz@gnu.org>
8842
8843 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8844 no-display-properties-and-no-overlays under bidi display.
8845 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8846 properties and overlays.
97bb72a6 8847
d5617611
CY
88482011-08-08 Chong Yidong <cyd@stupidchicken.com>
8849
37e11a63
CY
8850 * editfns.c (Fset_time_zone_rule): Document relationship with the
8851 setenv function.
8852
d5617611
CY
8853 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8854 the font entity extracted from the cache (Bug#8109).
8855
58872834
CY
88562011-08-07 Chong Yidong <cyd@stupidchicken.com>
8857
8858 * composite.c (autocmp_chars): Don't reset point. That is done by
8859 restore_point_unwind (Bug#5984).
8860
75bfc667
JL
88612011-08-07 Juri Linkov <juri@jurta.org>
8862
8863 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8864 to show the arg `TIME' instead of `TIMEVAL'.
8865
d1410150
EZ
88662011-08-06 Eli Zaretskii <eliz@gnu.org>
8867
8868 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8869 display property strides EOL and includes a newline, as in
8870 longlines-mode. (Bug#9254)
75b771e4
EZ
8871 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8872 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8873
8874 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8875 is non-zero, even if the data buffer is NULL. Fixes a crash in
8876 vertical-motion with longlines-mode. (Bug#9254)
8877
35928349
EZ
88782011-08-05 Eli Zaretskii <eliz@gnu.org>
8879
ec7cc85b
EZ
8880 * bidi.c <bidi_cache_total_alloc>: Now static.
8881 (bidi_initialize): Initialize bidi_cache_total_alloc.
8882
8b76d6f8 8883 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8884 cache. (Bug#9221)
8885
8886 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8887 amount allocated this far in `bidi_cache_total_alloc'.
8888 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8889 non-zero, only free the data buffer without restoring the cache
8890 contents. All callers changed.
8891
8892 * dispextern.h (bidi_unshelve_cache): Update prototype.
8893
8894 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8895 (move_it_in_display_line, move_it_to)
8896 (move_it_vertically_backward, move_it_by_lines): Replace the call
8897 to xfree to an equivalent call to bidi_unshelve_cache.
8898 (move_it_in_display_line_to): Fix logic of returning
412b6358 8899 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8900
e2e2423b
EZ
89012011-08-05 Eli Zaretskii <eliz@gnu.org>
8902
8903 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8904 came from a string character with a `cursor' property. (Bug#9229)
8905
ae9e757a
JD
89062011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8907
8908 * Makefile.in (LIB_PTHREAD): New variable.
8909 (LIBES): Add LIB_PTHREAD (Bug#9216).
8910
8911 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8912 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8913
213bd7f2
AS
89142011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8915
6b02f655 8916 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8917
99aaf75f
JD
89182011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8919
8920 * xterm.c (x_find_topmost_parent): New function.
8921 (x_set_frame_alpha): Find topmost parent window with
8922 x_find_topmost_parent and set the property there also (bug#9181).
8923 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8924
c74e9d86
PE
89252011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8926
8927 * callproc.c (Fcall_process): Avoid vfork clobbering
8928 the local vars buffer, coding_systems, current_dir.
8929
640c8776
SM
89302011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8931
8932 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8933
f26d0e4c
PE
89342011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8935
8a10d76c
PE
8936 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8937 so that it is not optimized away.
8938
f26d0e4c
PE
8939 * xdisp.c (compute_display_string_pos): Remove unused local.
8940
55439c61
EZ
89412011-08-02 Eli Zaretskii <eliz@gnu.org>
8942
8943 Fix slow cursor motion and scrolling in large buffers with
8944 selective display, like Org Mode buffers. (Bug#9218)
8945
8946 * dispextern.h (struct bidi_it): New member disp_prop_p.
8947
8948 * xdisp.c: Remove one-slot cache of display string positions.
8949 (compute_display_string_pos): Accept an additional argument
5e617bc2 8950 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8951 for a display string or property. If found, set DISP_PROP_P
8952 non-zero.
8953
8954 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8955 DISP_PROP_P, and pass it to compute_display_string_pos.
8956 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8957 non-zero. All callers of bidi_fetch_char changed.
8958
fb33fa43
SM
89592011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8960
8961 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8962
b099e063
DM
89632010-12-03 Don March <don@ohspite.net>
8964
8965 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8966 last character M-[char] is translated to ESC [char] (bug#7541).
8967
5cc7f7af
KH
89682011-08-02 Kenichi Handa <handa@m17n.org>
8969
d0fffa3f 8970 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8971
8972 * chartab.c (uniprop_table): Make it non-static.
8973
525d5e6e
EZ
89742011-08-01 Eli Zaretskii <eliz@gnu.org>
8975
8976 * xdisp.c (forward_to_next_line_start): Accept additional argument
8977 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8978 on the newline.
8979 (reseat_at_next_visible_line_start): Use the bidi iterator state
8980 returned by forward_to_next_line_start to restore the state of
8981 it->bidi_it after backing up to previous newline. (Bug#9212)
8982
31011111
AS
89832011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8984
8985 * regex.c (re_comp): Protoize.
8986 (re_exec): Fix return type.
8987 (regexec): Fix type of `ret'. (Bug#9203)
8988
476371c4
PE
89892011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8990
e5d76069
PE
8991 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8992 This is needed if max-image-size is a floating-point number.
8993
9a79b20c
AS
89942011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8995
8996 * print.c (print_object): Print empty symbol as ##.
8997
8998 * lread.c (read1): Read ## as empty symbol.
8999
d8c2fa78
AA
90002011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9001
9002 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9003 setting frame foreground color (Bug#9175).
9004 (x_set_background_color): Likewise.
9005
ffe57a7a
AA
9006 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9007 contents (Bug#9176).
9008 (EmacsTooltip -init): Remove bezels and add shadows to
9009 tooltip windows.
9010
bf3492a5
AA
9011 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9012 or scroll bar (Bug#8470).
9013
d55e9c53
AA
9014 * nsfont.m (nsfont_open): Remove assignment to voffset and
9015 unnecessary vars hshink, expand, hd, full_height, min_height.
9016 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9017
9018 * nsterm.h (nsfont_info): Remove voffset field.
9019
d8c2fa78 90202011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9021
9022 Implement strike-through and overline on NextStep (Bug#8863).
9023
9024 * nsfont.m (nsfont_open): Use underline position provided by font,
9025 instead of hard-coded value of 2.
9026 (nsfont_draw): Call ns_draw_text_decoration instead.
9027
9028 * nsterm.h: Add declaration for ns_draw_text_decoration.
9029
9030 * nsterm.m (ns_draw_text_decoration): New function for drawing
9031 underline, overline, and strike-through.
9032 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9033 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9034 accommodate underlining, etc.
4843aac3 9035
4cc60b9b
EZ
90362011-07-28 Eli Zaretskii <eliz@gnu.org>
9037
bc7ece87
EZ
9038 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9039 default.
4cc60b9b 9040
476371c4
PE
90412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9042
66606eea
PE
9043 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9044 Without this fix, if a signal arrives just after memory fills up,
9045 'malloc' might be invoked reentrantly.
9046
476371c4
PE
9047 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9048 In other words, assume that every image size is allowed, on non-X
9049 hosts. This assumption is probably wrong, but it lets Emacs compile.
9050
f3fcc40d
AS
90512011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9052
9053 * regex.c (re_iswctype): Convert return values to boolean.
9054
350c992f
EZ
90552011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9056
9057 * xdisp.c (compute_display_string_pos): Don't use cached display
9058 string position if the buffer had its restriction changed.
9059 (Bug#9184)
9060
5266b4bb
PE
90612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9062
9063 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9064
2573a837 90652011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9066
41f55ccd 9067 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9068
39e378da
PE
9069 * bidi.c: Integer size and overflow fixes.
9070 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9071 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9072 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9073 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9074 (bidi_find_other_level_edge):
9075 Use ptrdiff_t instead of EMACS_INT where either will do.
9076 This works better on 32-bit hosts configured --with-wide-int.
9077 (bidi_cache_ensure_space): Check for size-calculation overflow.
9078 Use % rather than repeated addition, for better worst-case speed.
9079 Don't set bidi_cache_size until after xrealloc returns, because it
9080 might not return.
9081 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9082 (bidi_cache_ensure_space): Also check that the bidi cache size
9083 does not exceed that of the largest Lisp string or buffer. See Eli
9084 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9085
5e927815
PE
9086 * alloc.c (__malloc_size_t): Remove.
9087 All uses replaced by size_t. See Andreas Schwab's note
9088 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9089
ca4aa935
PE
9090 * image.c: Improve checking for integer overflow.
9091 (check_image_size): Assume that f is nonnull, since
9092 it is always nonnull in practice. This is one less thing to
9093 worry about when checking for integer overflow later.
9094 (x_check_image_size): New function, which checks for integer
9095 overflow issues inside X.
9096 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9097 This removes the need for a memory_full check.
9098 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9099 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9100 (xbm_read_bitmap_data): Change locals back to 'int', since
9101 their values must fit in 'int'.
9102 (xpm_load_image, png_load, tiff_load):
9103 Invoke x_create_x_image_and_pixmap earlier,
9104 to avoid much needless work if the image is too large.
9105 (tiff_load): Treat overly large images as if
9106 x_create_x_image_and_pixmap failed, not as malloc failures.
9107 (gs_load): Use x_check_image_size.
9108
5f8f9cc2
PE
9109 * gtkutil.c: Omit integer casts.
9110 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9111 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9112
5adf60bc
PE
9113 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9114
c8907a93
PE
9115 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9116 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9117 would wrongly return t on a 64-bit host.
9118
e3c25c68
PE
9119 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9120 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9121 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9122 and therefore cause GCC to emit a bogus diagnostic in some cases.
9123
3f791afe
PE
9124 * image.c: Integer signedness and overflow and related fixes.
9125 This is not an exhaustive set of fixes, but it's time to
9126 record what I've got.
9127 (lookup_pixel_color, check_image_size): Remove redundant decls.
9128 (check_image_size): Don't assume that arbitrary EMACS_INT values
9129 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9130 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9131 (tiff_load, imagemagick_load_image):
9132 Check for overflow in size calculations.
9133 (x_create_x_image_and_pixmap): Remove unnecessary test for
9134 xmalloc returning NULL; that can't happen.
9135 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9136 (xpm_color_bucket): Use better integer hashing function.
9137 (xpm_cache_color): Don't possibly over-allocate memory.
9138 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9139 (gif_memory_source):
9140 Use ptrdiff_t, not int or size_t, to record sizes.
9141 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9142 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9143 either works, as we prefer signed integers.
9144 (tiff_read_from_memory, tiff_write_from_memory):
9145 Return tsize_t, not size_t, since that's what the TIFF API wants.
9146 (tiff_read_from_memory): Don't fail simply because the read would
9147 go past EOF; instead, return a short read.
9148 (tiff_load): Omit no-longer-needed casts.
9149 (Fimagemagick_types): Don't assume size fits into 'int'.
9150
3cc5a532
PE
9151 Improve hashing quality when configured --with-wide-int.
9152 * fns.c (hash_string): New function, taken from sxhash_string.
9153 Do not discard information about ASCII character case; this
9154 discarding is no longer needed.
9155 (sxhash-string): Use it. Change sig to match it. Caller changed.
9156 * lisp.h: Declare it.
9157 * lread.c (hash_string): Remove, since we now use fns.c's version.
9158 The fns.c version returns a wider integer if --with-wide-int is
9159 specified, so this should help the quality of the hashing a bit.
9160
b312a492
PE
9161 * emacs.c: Integer overflow minor fix.
9162 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9163 Define only if GNU_LINUX.
9164 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9165
dfd153ae
PE
9166 * dispnew.c: Integer signedness and overflow fixes.
9167 Remove unnecessary forward decls, that were a maintenance hassle.
9168 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9169 All uses changed.
9170 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9171 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9172 (prepare_desired_row, line_draw_cost):
9173 Use int, not unsigned, where either works.
9174 (save_current_matrix, restore_current_matrix):
9175 Use ptrdiff_t, not size_t, where either works.
9176 (init_display): Check for overflow more accurately, and without
9177 relying on undefined behavior.
9178
a81d11a3
PE
9179 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9180 Remove, replacing with the new symbols in lisp.h. All uses changed.
9181 * fileio.c (make_temp_name):
9182 * filelock.c (lock_file_1, lock_file):
9183 * xdisp.c (message_dolog):
9184 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9185 Use pMd etc. instead.
9186 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9187 replacing the pWIDE etc. symbols removed from editfns.c.
9188
3300e6fd
PE
9189 * keyboard.h (num_input_events): Now uintmax_t.
9190 This is (very slightly) less likely to mess up due to wraparound.
9191 All uses changed.
9192
fd05c7e9
PE
9193 * buffer.c: Integer signedness fixes.
9194 (alloc_buffer_text, enlarge_buffer_text):
9195 Use ptrdiff_t rather than size_t when either will do, as we prefer
9196 signed integers.
9197
903fe15d
PE
9198 * alloc.c: Integer signedness and overflow fixes.
9199 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9200 (__malloc_size_t): Default to size_t, not to int.
9201 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9202 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9203 Prefer ptrdiff_t to size_t when either would do, as we prefer
9204 signed integers.
9205 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9206 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9207 Now const. Initialize with values that are in range even if char
9208 is signed.
9209 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9210 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9211 These functions do the right thing with sizes > 2**32.
9212 (check_depth): Now ptrdiff_t, not int.
9213 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9214 Adjust to new way of storing sizes. Check for size overflow bugs
9215 in rest of code.
9216 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9217 slightly wrong anyway, as it missed one instance of
9218 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9219 (refill_memory_reserve): Omit needless cast to size_t.
9220 (mark_object_loop_halt): Mark as externally visible.
9221
ac82cc6a
PE
9222 * xselect.c: Integer signedness and overflow fixes.
9223 (Fx_register_dnd_atom, x_handle_dnd_message):
9224 Use ptrdiff_t, not size_t, since we prefer signed.
9225 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9226 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9227 x_dnd_atoms_size and x_dnd_atoms_length.
9228
c2d1e36d
PE
9229 * doprnt.c: Prefer signed to unsigned when either works.
9230 * eval.c (verror):
9231 * doprnt.c (doprnt):
9232 * lisp.h (doprnt):
9233 * xdisp.c (vmessage):
9234 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9235 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9236 prefer signed arithmetic to avoid comparison confusion.
9237 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9238 but is a bit tricky.
9239
0e926e56
PE
9240 Assume freestanding C89 headers, string.h, stdlib.h.
9241 * data.c, doprnt.c, floatfns.c, print.c:
9242 Include float.h unconditionally.
9243 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9244 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9245 * regex.c: Likewise for stddef.h, string.h.
9246 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9247 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9248 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9249 (STDC_HEADERS): Remove obsolete defines.
9250 * sysdep.c: Include limits.h unconditionally.
9251
9cfdb3ec
PE
9252 Assume support for memcmp, memcpy, memmove, memset.
9253 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9254 * regex.c (memcmp, memcpy):
9255 Remove; we assume C89 now.
9256
9257 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9258 (__malloc_safe_bcopy): Remove; no longer needed.
9259
cf950e6b 9260 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9261 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9262 well either way, and we prefer signed to unsigned.
9263
dbf38e02
LMI
92642011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9265
9266 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9267 closes the connection while we're reading (bug#9182).
9268
d6f0886c 92692011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9270
d6f0886c
JD
9271 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9272 are specified (Bug#9168).
24e0f6b1 9273
2eb1f9e6
PE
92742011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9275
9276 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9277 Found by GCC static checking and --with-wide-int on a 32-bit host.
9278
22381272 92792011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9280
9281 * xdisp.c (compute_display_string_pos): Fix logic of caching
9282 previous display string position. Initialize cached_prev_pos to
9283 -1. Fixes slow-down at the beginning of a buffer.
9284
f25e39b4
EZ
92852011-07-24 Eli Zaretskii <eliz@gnu.org>
9286
9287 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9288 for attrs[LFACE_FONTSET_INDEX].
9289
04c4b52e
PE
92902011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9291
9292 * xml.c (parse_region): Remove unused local
9293 that was recently introduced.
9294
c1734fbd
EZ
92952011-07-23 Eli Zaretskii <eliz@gnu.org>
9296
be18c5a5
EZ
9297 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9298 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9299
c1734fbd
EZ
9300 * xdisp.c (move_it_in_display_line_to): Record the best matching
9301 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9302 exit if none of the characters scanned was an exact match.
9303 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9304 when exact match is impossible due to invisible text, and the
9305 lines are truncated.
9306
a258d627
JD
93072011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9308
9309 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9310 for OSX >= 10.7.
9311
b6d5a689
EZ
93122011-07-22 Eli Zaretskii <eliz@gnu.org>
9313
0f74f785
EZ
9314 Fix a significant slow-down of cursor motion with C-n, C-p,
9315 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9316 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9317 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9318 (next_element_from_buffer): Call compute_stop_pos_backwards to
9319 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9320 base_level_stop.
9321 (reseat): Don't look for prev_stop, as that could mean a very long
9322 run.
9323 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9324 <cached_disp_overlay_modiff>: Cache for last found display string
9325 position.
551918c1 9326 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9327 about the same buffer in the same area of character positions, and
9328 the buffer wasn't changed since the time the display string
9329 position was cached.
551918c1 9330
b2d0c91a
EZ
93312011-07-22 Eli Zaretskii <eliz@gnu.org>
9332
9333 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9334 is an integer, which is important for empty lines. (Bug#9149)
9335
043604ee
CY
93362011-07-22 Chong Yidong <cyd@stupidchicken.com>
9337
9338 * frame.c (Fmodify_frame_parameters): In tty case, update the
9339 default face if necessary (Bug#4238).
9340
da4adb04
CY
93412011-07-21 Chong Yidong <cyd@stupidchicken.com>
9342
9343 * editfns.c (Fstring_to_char): No need to explain what a character
9344 is in the docstring (Bug#6576).
9345
9abd0532
LMI
93462011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9347
9348 * xml.c (parse_region): Make sure we always return a tree.
9349
36881d16
HK
93502011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9351
9352 * xml.c (parse_region): If a document contains only comments,
9353 return that, too.
9354
1e98674d
LMI
93552011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9356
9357 * xml.c (make_dom): Return comments, too.
9358
590bd467
PE
93592011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9360
9361 Port to OpenBSD.
9362 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9363 and the surrounding thread.
9364 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9365 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9366 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9367 timer goes off.
9368 * s/openbsd.h (BROKEN_SIGIO): Define.
9369 * unexelf.c (unexec) [__OpenBSD__]:
9370 Don't update the .mdebug section of the Alpha COFF symbol table.
9371
f41628b2
LMI
93722011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9373
9374 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9375 (bug#8460).
9376
b59b67c5
PE
93772011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9378
15e3a074
PE
9379 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9380 This fixes some race conditions on the permissions of any newly
9381 created file.
9382
41bed37d
PE
9383 * alloc.c (valid_pointer_p): Use pipe, not open.
9384 This fixes some permissions issues when debugging.
9385
b59b67c5
PE
9386 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9387 If fchown fails to set both uid and gid, try to set just gid,
9388 as that is sometimes allowed. Adjust the file's mode to eliminate
9389 setuid or setgid bits that are inappropriate if fchown fails.
9390
925a6be7
SM
93912011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9392
9393 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9394 to compare Lisp_Objects.
9395 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9396 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9397 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9398
52968808
AS
93992011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9400
0a6a104b
AS
9401 * lread.c (read_integer): Unread even EOF character.
9402 (read1): Likewise. Properly record start position of symbol.
9403
52968808
AS
9404 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9405 symbol character follows.
9406
9e381cdd
PE
94072011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9408
9409 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9410 This works around a problem with the previous change to Fcopy_file.
9411 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9412 and without this change, GCC might complain about discarding
9413 fchown's return value.
9414
b5641435
JB
94152011-07-16 Juanma Barranquero <lekktu@gmail.com>
9416
9417 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9418
a8031457
PE
94192011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9420
9421 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9422
dd889327
LMI
94232011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9424
750c33f7
LMI
9425 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9426 it's used from the C level.
9427
dd889327
LMI
9428 * process.c: Use the same condition for POLL_FOR_INPUT in both
9429 keyboard.c and process.c (bug#1858).
9430
87e86684
LM
94312011-07-09 Lawrence Mitchell <wence@gmx.li>
9432
9433 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9434 (Fgnutls_boot): Use it.
9435
64348f40
AS
94362011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9437
9438 * doc.c (Fsubstitute_command_keys): Revert last change.
9439
1d698799
LMI
94402011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9441
f863868c
LMI
9442 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9443 quotes the next character, and doesn't affect other longer
9444 sequences (bug#8935).
9445
1d698799
LMI
9446 * lread.c (syms_of_lread): Clarify that is isn't only
9447 `eval-buffer' and `eval-defun' that's affected by
9448 `lexical-binding' (bug#8460).
9449
aa4b6df6
EZ
94502011-07-15 Eli Zaretskii <eliz@gnu.org>
9451
9452 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9453 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9454
5d856da6
PE
94552011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9456
ad6042bb
PE
9457 Fix minor problems found by static checking.
9458 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9459 (elsz): Now a signed constant, not a size_t var. We prefer signed
9460 types to unsigned, to avoid integer comparison confusion. Without
9461 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9462 "cannot optimize loop, the loop counter may overflow", a symptom
9463 of the confusion.
f00bbb22 9464 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9465 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9466
6468f31c
LMI
94672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9468
49080b10
LMI
9469 * search.c (Fre_search_backward): Mention `case-fold-search' in
9470 all the re_search_* functions (bug#8138).
9471
6468f31c
LMI
9472 * keyboard.c (Fopen_dribble_file): Document when the file is
9473 closed (bug#8056).
9474
c965adc5
EZ
94752011-07-14 Eli Zaretskii <eliz@gnu.org>
9476
df9733bf
EZ
9477 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9478 bidi_cache_idx.
9479
0bb23927
EZ
9480 Support bidi reordering of display and overlay strings.
9481 * xdisp.c (compute_display_string_pos)
9482 (compute_display_string_end): Accept additional argument STRING.
9483 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9484 (reseat_to_string): Initialize bidi_it->string.s and
9485 bidi_it->string.schars.
9486 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9487 NULL (avoids a crash in bidi_paragraph_init).
9488 Initialize itb.string.lstring.
0bb23927
EZ
9489 (init_iterator): Call bidi_init_it only of a valid
9490 buffer position was specified. Initialize paragraph_embedding to
9491 L2R.
9492 (reseat_to_string): Initialize the bidi iterator.
9493 (display_string): If we need to ignore text properties of
9494 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9495 original value of -1 will not work with bidi.)
9496 (compute_display_string_pos): First arg is now struct
9497 `text_pos *'; all callers changed. Support display properties on
9498 Lisp strings.
9499 (compute_display_string_end): Support display properties on Lisp
9500 strings.
9501 (init_iterator, reseat_1, reseat_to_string): Initialize the
9502 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9503 when iterating on a string not from display properties).
640c8776
SM
9504 (compute_display_string_pos, compute_display_string_end):
9505 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9506 arrow keys.
9507 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9508 base_level_stop; instead, set base_level_stop to BEGV.
9509 Fixes crashes in vertical-motion.
0bb23927
EZ
9510 (next_element_from_buffer): Improve commentary for when
9511 the iterator is before prev_stop.
9512 (init_iterator): Initialize bidi_p from the default value of
9513 bidi-display-reordering, not from buffer-local value. Use the
9514 buffer-local value only if initializing for buffer iteration.
9515 (handle_invisible_prop): Support invisible properties on strings
9516 that are being bidi-reordered.
9517 (set_iterator_to_next): Support bidi reordering of C strings and
9518 Lisp strings.
9519 (next_element_from_string): Support bidi reordering of Lisp
9520 strings.
9521 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9522 (display_string): Support display of R2L glyph rows.
9523 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9524 (init_iterator): Don't initialize it->bidi_p for strings
9525 here.
9526 (reseat_to_string): Initialize it->bidi_p for strings here.
9527 (next_element_from_string, next_element_from_c_string)
9528 (next_element_from_buffer): Add xassert's for correspondence
9529 between IT's object being iterated and it->bidi_it.string
9530 structure.
9531 (face_before_or_after_it_pos): Support bidi iteration.
9532 (next_element_from_c_string): Handle the case of the first string
9533 character that is not the first one in the visual order.
9534 (get_visually_first_element): New function, refactored from common
9535 parts of next_element_from_buffer, next_element_from_string, and
9536 next_element_from_c_string.
9537 (tool_bar_lines_needed, redisplay_tool_bar)
9538 (display_menu_bar): Force left-to-right direction. Add a FIXME
9539 comment for making that be controlled by a user option.
9540 (push_it, pop_it): Save and restore the state of the
9541 bidi iterator. Save and restore the bidi_p flag.
9542 (pop_it): Iterate out of display property for string iteration as
9543 well.
9544 (iterate_out_of_display_property): Support iteration over strings.
9545 (handle_single_display_spec): Set up it->bidi_it for iteration
9546 over a display string, and call bidi_init_it.
9547 (handle_single_display_spec, next_overlay_string)
9548 (get_overlay_strings_1, push_display_prop): Set up the bidi
9549 iterator for displaying display or overlay strings.
9550 (forward_to_next_line_start): Don't use the shortcut if
9551 bidi-iterating.
9552 (back_to_previous_visible_line_start): If handle_display_prop
9553 pushed the iterator stack, restore the internal state of the bidi
9554 iterator by calling bidi_pop_it same number of times.
9555 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9556 and we are bidi-iterating, don't decrement the iterator position;
9557 instead, set the first_elt flag in the bidi iterator, to produce
9558 the same effect.
9559 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9560 (push_display_prop): xassert that we are iterating a buffer.
9561 (push_it, pop_it): Save and restore paragraph_embedding member.
9562 (handle_single_display_spec, next_overlay_string)
9563 (get_overlay_strings_1, reseat_1, reseat_to_string)
9564 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9565 correctly. Don't assume unibyte strings are not bidi-reordered.
9566 (compute_display_string_pos)
9567 (compute_display_string_end): Fix handling the case of C string.
9568 (push_it, pop_it): Save and restore from_disp_prop_p.
9569 (handle_single_display_spec, push_display_prop): Set the
9570 from_disp_prop_p flag.
9571 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9572 (pop_it): Call iterate_out_of_display_property only if we are
9573 popping after iteration over a string that came from a display
9574 property. Fix a typo in popping stretch info. Add an assertion
9575 for verifying that the iterator position is in sync with the bidi
9576 iterator.
9577 (handle_single_display_spec, get_overlay_strings_1)
9578 (push_display_prop): Fix initialization of paragraph direction for
9579 string when that of the parent object is not yet determined.
9580 (reseat_1): Call bidi_init_it to resync the bidi
9581 iterator with IT's position. (Bug#7616)
9582 (find_row_edges): If ROW->start.pos gives position
9583 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9584 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9585 Reset the from_disp_prop_p flag.
9586 (SAVE_IT, RESTORE_IT): New macros.
9587 (pos_visible_p, face_before_or_after_it_pos)
9588 (back_to_previous_visible_line_start)
9589 (move_it_in_display_line_to, move_it_in_display_line)
9590 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9591 (try_scrolling, redisplay_window, display_line): Use them when
9592 saving a temporary copy of the iterator and restoring it back.
9593 (back_to_previous_visible_line_start, reseat_1)
9594 (init_iterator): Empty the bidi cache "stack".
9595 (move_it_in_display_line_to): If iterator ended up at
9596 EOL, but we never saw any buffer positions smaller than
9597 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9598 motion in bidi-reordered lines.
9599 (move_it_in_display_line_to): Record prev_method and prev_pos
9600 immediately before the call to set_iterator_to_next. Fixes cursor
9601 motion in bidi-reordered lines with stretch glyphs and strings
9602 displayed in margins. (Bug#8133) (Bug#8867)
9603 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9604 TO_CHARPOS.
640c8776
SM
9605 (pos_visible_p): Support positions in bidi-reordered lines.
9606 Save and restore bidi cache.
0bb23927
EZ
9607
9608 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9609 (bidi_paragraph_info): Delete unused struct.
9610 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9611 (bidi_cache_start): New variable.
9612 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9613 to zero.
9614 (bidi_cache_fetch_state, bidi_cache_search)
9615 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9616 (bidi_cache_find, bidi_peek_at_next_level)
9617 (bidi_level_of_next_char, bidi_find_other_level_edge)
9618 (bidi_move_to_visually_next): Compare cache index with
9619 bidi_cache_start rather than with zero.
9620 (bidi_fetch_char): Accept new argument STRING; all callers
9621 changed. Support iteration over a string. Support strings with
9622 display properties. Support unibyte strings. Fix the type of
9623 `len' according to what STRING_CHAR_AND_LENGTH expects.
9624 (bidi_paragraph_init, bidi_resolve_explicit_1)
9625 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9626 (bidi_level_of_next_char, bidi_move_to_visually_next):
9627 Support iteration over a string.
0bb23927
EZ
9628 (bidi_set_sor_type, bidi_resolve_explicit_1)
9629 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9630 can now be zero (for strings); special values 0 and -1 were
9631 changed to -1 and -2, respectively.
9632 (bidi_char_at_pos): New function.
9633 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9634 Call it instead of FETCH_MULTIBYTE_CHAR.
9635 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9636 initialized to valid values.
9637 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9638 values.
9639 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9640 the test for valid cached positions. Fix the logic for looking up
9641 the sentinel state in the cache. GCPRO the Lisp string we are
9642 iterating.
9643 (bidi_push_it, bidi_pop_it): New functions.
9644 (bidi_initialize): Initialize the bidi cache start stack pointer.
9645 (bidi_cache_ensure_space): New function, refactored from part of
9646 bidi_cache_iterator_state. Don't assume the required size is just
9647 one BIDI_CACHE_CHUNK away.
9648 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9649 (bidi_count_bytes, bidi_char_at_pos): New functions.
9650 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9651 always valid if bidi_cache_idx is valid.
9652 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9653 is valid if it's going to be used.
9654 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9655 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9656 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9657 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9658 (bidi_find_other_level_edge, bidi_cache_start_stack):
9659 All variables related to cache indices are now EMACS_INT.
c965adc5 9660
0bb23927
EZ
9661 * dispextern.h (struct bidi_string_data): New structure.
9662 (struct bidi_it): New member `string'. Make flag members be 1-bit
9663 fields, and put them last in the struct.
640c8776
SM
9664 (compute_display_string_pos, compute_display_string_end):
9665 Update prototypes.
0bb23927
EZ
9666 (bidi_push_it, bidi_pop_it): Add prototypes.
9667 (struct iterator_stack_entry): New members bidi_p,
9668 paragraph_embedding, and from_disp_prop_p.
9669 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9670 (bidi_shelve_cache, bidi_unshelve_cache):
9671 Declare prototypes.
0bb23927
EZ
9672
9673 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9674 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9675 and vector-like objects.
9676
9677 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9678 cache around display iteration.
9679
9680 * window.c (Fwindow_end, window_scroll_pixel_based)
9681 (displayed_window_lines, Frecenter): Save and restore the bidi
9682 cache around display iteration.
9683
3bbd2265
LMI
96842011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9685
9686 * editfns.c (Fdelete_region): Clarify the use of the named
9687 parameters (bug#6788).
9688
adc47434
MR
96892011-07-14 Martin Rudalics <rudalics@gmx.at>
9690
9691 * indent.c (Fvertical_motion): Set and restore w->pointm when
9692 saving and restoring the window's buffer (Bug#9006).
9693
837c31f8
LMI
96942011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9695
9696 * editfns.c (Fstring_to_char): Clarify just what is returned
9697 (bug#6576). Text by Eli Zaretskii.
9698
ac389d0c
JB
96992011-07-13 Juanma Barranquero <lekktu@gmail.com>
9700
9701 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9702
0be0ce47
EZ
97032011-07-13 Eli Zaretskii <eliz@gnu.org>
9704
9705 * buffer.c (mmap_find): Fix a typo.
9706
cd18e7e3
JB
97072011-07-13 Johan Bockgård <bojohan@gnu.org>
9708
9709 Fix execution of x selection hooks.
9710 * xselect.c (Qx_lost_selection_functions)
9711 (Qx_sent_selection_functions): New vars.
9712 (syms_of_xselect): DEFSYM them.
9713 (x_handle_selection_request): Pass Qx_sent_selection_functions
9714 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9715 (x_handle_selection_clear,x_clear_frame_selections):
9716 Pass Qx_lost_selection_functions rather than
9717 Vx_lost_selection_functions to Frun_hook_with_args.
9718
47ea7f44
PE
97192011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9720
ac389d0c 9721 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9722 The old code sometimes used this field without initializing it.
9723
47ea7f44
PE
9724 * alloc.c (gc_sweep): Don't read past end of array.
9725 In theory, the old code could also have corrupted Emacs internals,
9726 though it'd be very unlikely.
9727
bc985c87
AS
97282011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9729
9730 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9731 argument. (Bug#4026)
bc985c87 9732
0cf34688
LMI
97332011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9734
b3dadd76
LMI
9735 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9736 key" (bug#4257).
9737
0cf34688
LMI
9738 * window.c (Fset_window_start): Doc fix (bug#4199).
9739 (Fset_window_hscroll): Ditto.
9740
270768cd
PE
97412011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9742
077e3dda 9743 Fix minor new problems caught by GCC 4.6.1.
270768cd 9744 * term.c (init_tty): Remove unused local.
490011a6 9745 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9746 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9747 not used otherwise.
270768cd 9748
b1f58454
CY
97492011-07-12 Chong Yidong <cyd@stupidchicken.com>
9750
9751 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9752
22b9578d
LMI
97532011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9754
6e70ab07
LMI
9755 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9756 are the mini-buffer and the echo area (bug#3320).
9757
22b9578d
LMI
9758 * term.c (init_tty): Remove support for supdup, c10 and perq
9759 terminals, which are no longer supported (bug#1482).
9760
8974cc9f
JB
97612011-07-10 Johan Bockgård <bojohan@gnu.org>
9762
9763 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9764
a560d974
JD
97652011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9766
9767 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9768 for non-popups (Bug#3642).
9769
1dae0f0a
AS
97702011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9771
268c2c36 9772 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9773 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9774 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9775 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9776 * data.c (fmod): Likewise.
9777 * dispnew.c (swap_glyphs_in_rows): Likewise.
9778 * emacs.c (memory_warning_signal): Likewise.
9779 * floatfns.c (float_error): Likewise.
9780 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9781 (otf_open, font_otf_capability, generate_otf_features)
9782 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9783 Likewise.
9784 * image.c (pbm_read_file): Likewise.
9785 * indent.c (string_display_width): Likewise.
9786 * intervals.c (check_for_interval, search_for_interval)
9787 (inc_interval_count, count_intervals, root_interval)
9788 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9789 * lread.c (defalias): Likewise.
268c2c36 9790 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9791 * regex.c (set_image_of_range_1, set_image_of_range)
9792 (regex_grow_registers): Likewise.
9793 * sysdep.c (strerror): Likewise.
9794 * termcap.c (valid_filename_p, tprint, main): Likewise.
9795 * tparam.c (main): Likewise.
9796 * unexhp9k800.c (run_time_remap, save_data_space)
9797 (update_file_ptrs, read_header, write_header, calculate_checksum)
9798 (copy_file, copy_rest, display_header): Likewise.
9799 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9800 Likewise.
9801 * xdisp.c (check_it): Likewise.
9802 * xfaces.c (register_color, unregister_color, unregister_colors):
9803 Likewise.
9804 * xfns.c (print_fontset_result): Likewise.
9805 * xrdb.c (member, fatal, main): Likewise.
9806
99033785
PE
98072011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9808
9809 Fix minor problems found by static checking (Bug#9031).
9810 * chartab.c (char_table_set_range, map_sub_char_table):
9811 Remove unused locals.
9812 (uniprop_table): Now static.
9813 * composite.c (_work_char): Remove unused static var.
9814
9cb2ac56
JB
98152011-07-09 Juanma Barranquero <lekktu@gmail.com>
9816
9817 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9818
f25661f0
JD
98192011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9820
9821 * gtkutil.c (qttip_cb): Remove code without function.
9822
8278c4fe
EZ
98232011-07-09 Eli Zaretskii <eliz@gnu.org>
9824
9825 * w32.c (pthread_sigmask): New stub.
9826
1692ae2d 98272011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9828
8a6ebd58 9829 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9830 sigprocmask is portable only for single-threaded applications, and
9831 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9832 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9833 (LIBES): Use it.
9834 * callproc.c (Fcall_process):
9835 * process.c (create_process):
9836 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9837 Use pthread_sigmask, not sigprocmask.
123403e4 9838
1b854618
JD
98392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9840
9841 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9842 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9843 wrong (Bug#8591).
9844
3fe4b549
JD
98452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9846
0ce7e563
JD
9847 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9848 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9849 (xg_hide_tooltip): Fix comment.
9850
3fe4b549
JD
9851 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9852 in registerServicesMenuSendTypes.
9853 (validRequestorForSendType): Don't check ns_return_types.
9854
9855 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9856 ns_return_type.
9857
5df75e47
JR
98582011-07-08 Jason Rumney <jasonr@gnu.org>
9859
22610910
JR
9860 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9861 SH_SHOW for hidden windows (Bug#5482).
9862
5df75e47
JR
9863 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9864 frame struct members of non-existent frames (Bug#6284).
9865
699c10bd
JD
98662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9867
4393663b
JD
9868 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9869 variable firstTime not needed on OSX >= 10.6.
9870 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9871 >= 10.5. Use setKnobProportion, setDoubleValue.
9872
9873 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9874 (MAC_OS_X_VERSION_10_5): Define if not defined.
9875 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9876 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9877 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9878
9879 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9880 cString and lossyCString on OSX >= 10.4.
4393663b 9881
58179cce 9882 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9883 sizeToFit on OSX >= 10.2.
9884
9885 * nsimage.m (allocInitFromFile): Don't use deprecated method
9886 bestRepresentationForDevice on OSX >= 10.6.
9887
9888 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9889 to avoid warning.
9890
9891 * emacs.c: Declare unexec_init_emacs_zone.
9892
a63e0781
JD
9893 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9894
699c10bd
JD
9895 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9896
9897 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9898 on svcsMenu (Bug#8842).
9899
9900 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9901 ns_return_types.
9902 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9903
9904 * nsterm.m (QUTF8_STRING): Declare.
9905 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9906 (validRequestorForSendType): Return type is (id).
9907 Change indexOfObjectIdenticalTo to indexOfObject.
9908 Check if we have local selection before returning self (Bug#8842).
9909 (writeSelectionToPasteboard): Put local selection into paste board
9910 if we have a local selection (Bug#8842).
9911 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9912
9913 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9914 (ns_get_local_selection): Declare.
9915
54e10184
LMI
99162011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9917
9888ff71
LMI
9918 * keymap.c (describe_map_tree): Don't insert a double newline at
9919 the end of the buffer (bug#1169) and return whether we inserted
9920 something.
9921
54e10184
LMI
9922 * callint.c (Fcall_interactively): Change "reading args" to
9923 "providing args" to try to clarify what it does (bug#1010).
9924
15fa4783
KH
99252011-07-07 Kenichi Handa <handa@m17n.org>
9926
9927 * composite.c (composition_compute_stop_pos): Ignore a static
9928 composition starting before CHARPOS (Bug#8915).
9929
9930 * xdisp.c (handle_composition_prop): Likewise.
9931
a8815b00
EZ
99322011-07-07 Eli Zaretskii <eliz@gnu.org>
9933
9934 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9935 (Bug#9015)
9936
ef7b981d 99372011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9938
9939 * character.h (unicode_category_t): New enum type.
9940
9941 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9942 (Qchar_code_property_table): New variable.
9943 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9944 (UNIPROP_COMPRESSED_FORM_P): New macros.
9945 (char_table_ascii): Uncompress the compressed values.
9946 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9947 Uncompress the compressed values.
ac389d0c 9948 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9949 (char_table_ref_and_range): Uncompress the compressed values.
9950 (sub_char_table_set): New arg is_uniprop. Callers changed.
9951 Uncompress the compressed values.
9952 (sub_char_table_set_range): Args changed. Callers changed.
9953 (char_table_set_range): Adjuted for the above change.
9954 (map_sub_char_table): Delete args default_val and parent. Add arg
9955 top. Give decoded values to a Lisp function.
640c8776 9956 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9957 values to a Lisp function. Gcpro more variables.
9958 (uniprop_table_uncompress)
9959 (uniprop_decode_value_run_length): New functions.
9960 (uniprop_decoder, uniprop_decoder_count): New variables.
9961 (uniprop_get_decoder, uniprop_encode_value_character)
9962 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9963 New functions.
9964 (uniprop_encoder, uniprop_encoder_count): New variables.
9965 (uniprop_get_encoder, uniprop_table)
9966 (Funicode_property_table_internal, Fget_unicode_property_internal)
9967 (Fput_unicode_property_internal): New functions.
9968 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9969 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9970 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9971 char-code-property-alist.
9972
640c8776 9973 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9974 Vunicode_category_table.
9975
640c8776 9976 * font.c (font_range): Adjust for the change of
c805dec0
KH
9977 Vunicode_category_table.
9978
76b397fb
DN
99792011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9980
9981 * m/iris4d.h: Remove file, move contents ...
9982 * s/irix6-5.h: ... here.
9983
22b4128e
PE
99842011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9985
9986 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9987 * alloc.c (mark_buffer):
9988 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9989 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9990 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9991 This isn't true in general, and it's particularly not true
9992 if Emacs is configured with --with-wide-int.
9993 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9994 New macros, used in the buffer.c change.
9995
869795d6
JD
99962011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9997
9998 * xsettings.c: Use both GConf and GSettings if both are available.
9999 (store_config_changed_event): Add comment.
10000 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10001 (store_tool_bar_style_changed): New functions.
5e617bc2 10002 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10003 (struct xsettings): Move font inside HAVE_XFT.
10004 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10005 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10006 Move inside HAVE_XFT.
640c8776 10007 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10008 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10009 also.
10010 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10011 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10012 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10013 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10014 (parse_settings): Move check for font inside HAVE_XFT.
10015 (read_settings, apply_xft_settings): Add comment.
10016 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10017 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10018 call store_font_name_changed.
10019 (xft_settings_event): Add comment.
10020 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10021 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10022 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10023 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10024 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10025 (xsettings_get_system_font, xsettings_get_system_normal_font):
10026 Add comment.
869795d6 10027
d8ed26bd
PE
100282011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10029
10030 Random fixes. E.g., (random) never returned negative values.
10031 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10032 subseconds part to the entropy, as that's a bit more random.
10033 Prefer signed to unsigned, since the signedness doesn't matter and
10034 in general we prefer signed. When given a limit, use a
10035 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10036 latter isn't right if USE_2_TAGS_FOR_INTS.
10037 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10038 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10039
cabf1cac
SM
100402011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10041
10042 * textprop.c (text_property_stickiness):
10043 Obey Vtext_property_default_nonsticky.
10044 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10045 * w32fns.c (syms_of_w32fns):
10046 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10047
6e9b2be9
PE
100482011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10049
10050 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10051 This is more efficient than Ffile_directory_p and avoids a minor race.
10052
90186c68
LMI
100532011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10054
7c301272
LMI
10055 * buffer.c (Foverlay_put): Say what the return value is
10056 (bug#7835).
10057
c4f2d8d4
LMI
10058 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10059 is a directory before asking whether to use the file name
10060 (bug#7564).
ad637907
LMI
10061 (barf_or_query_if_file_exists): Make the "File is a directory"
10062 error be more correct.
c4f2d8d4 10063
90186c68
LMI
10064 * fns.c (Frequire): Remove the mention of the .gz files, since
10065 that's installation-specific, but keep the mention of
10066 `get-load-suffixes'.
10067
da64016e
PE
100682011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10069
10070 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10071 Report string overflow if the output is too long.
10072
7d47b580
JB
100732011-07-04 Juanma Barranquero <lekktu@gmail.com>
10074
a555cb87
JB
10075 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10076 (syms_of_gnutls): Remove duplicate DEFSYM for
10077 Qgnutls_bootprop_verify_hostname_error, an error for
10078 Qgnutls_bootprop_verify_error (which is no longer used).
10079
7d47b580
JB
10080 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10081 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10082 Also (re)move comments that are misplaced or no longer relevant.
10083
1e49bfab
LMI
100842011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10085
10086 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10087
1485f4c0
CY
100882011-07-03 Chong Yidong <cyd@stupidchicken.com>
10089
10090 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10091 and background color parameters if they have been changed.
10092
a9ab721e
LMI
100932011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10094
10095 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10096
cf7cff57
PE
100972011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10098
2e13213d
PE
10099 * xsettings.c (SYSTEM_FONT): Define only when used.
10100 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10101
cf7cff57
PE
10102 * keymap.c (access_keymap_1): Now static.
10103
7a8e04f7
CY
101042011-07-02 Chong Yidong <cyd@stupidchicken.com>
10105
10106 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10107 leave any prefix arg for the up event (Bug#1586).
10108
61352f62
LMI
101092011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10110
69bb1ef7
LMI
10111 * lread.c (syms_of_lread): Mention single symbols defined by
10112 `defvar' or `defconst' (bug#7154).
10113
61352f62 10114 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10115 (Frequire): Mention get-load-suffixes.
61352f62 10116
28545e04
MR
101172011-07-02 Martin Rudalics <rudalics@gmx.at>
10118
10119 * window.h (window): Remove clone_number slot.
10120 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10121 Remove.
10122 (make_parent_window, make_window, saved_window)
10123 (Fset_window_configuration, save_window_save): Don't deal with
10124 clone numbers.
10125 * buffer.c (Qclone_number): Remove declaration.
10126 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10127
3349e122
SM
101282011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10129
10130 Add multiple inheritance to keymaps.
10131 * keymap.c (Fmake_composed_keymap): New function.
10132 (Fset_keymap_parent): Simplify.
10133 (fix_submap_inheritance): Remove.
10134 (access_keymap_1): New function extracted from access_keymap to handle
10135 embedded parents and handle lists of maps.
10136 (access_keymap): Use it.
10137 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10138 (Fcopy_keymap): Handle embedded parents.
10139 (Fcommand_remapping, define_as_prefix): Simplify.
10140 (Fkey_binding): Simplify.
10141 (syms_of_keymap): Move minibuffer-local-completion-map,
10142 minibuffer-local-filename-completion-map,
10143 minibuffer-local-must-match-map, and
10144 minibuffer-local-filename-must-match-map to Elisp.
10145 (syms_of_keymap): Defsubr make-composed-keymap.
10146 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10147 (parse_menu_item): Trivial simplification.
10148
3279eb87
GM
101492011-07-01 Glenn Morris <rgm@gnu.org>
10150
10151 * Makefile.in (SETTINGS_LIBS): Fix typo.
10152
39cb9e56 101532011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10154
10155 * coding.c (Fencode_coding_string): Record the last coding system
10156 used, as the function doc string says (bug#8738).
10157
0949d2b6
JD
101582011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10159
10160 * xsettings.c (store_monospaced_changed): Take new font as arg and
10161 check for change against current_mono_font.
10162 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10163 (emacs_settings_constructor, emacs_settings_get_property)
10164 (emacs_settings_set_property, emacs_settings_class_init)
10165 (emacs_settings_init, gsettings_obj): Remove.
10166 (something_changedCB): New function for HAVE_GSETTINGS.
10167 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10168 with value as argument.
10169 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10170 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10171 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10172 "changed".
10173
10174 * xgselect.c: Add defined (HAVE_GSETTINGS).
10175 (xgselect_initialize): Ditto.
10176
10177 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10178 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10179 xg_select.
10180
bbc6b304
PE
101812011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10182
10183 * eval.c (struct backtrace): Simplify and port the data structure.
10184 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10185 signed bit field, as this assumption is not portable and it makes
10186 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10187 "char debug_on_exit : 1" as this is not portable either; instead,
10188 use the portable "unsigned int debug_on_exit : 1". Remove unused
10189 member evalargs. Remove obsolete comments about cc bombing out.
10190
9851bfc5
JD
101912011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10192
51bb811f 10193 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10194 Let HAVE_GSETTINGS override HAVE_GCONF.
10195 (store_monospaced_changed): New function.
10196 (EMACS_SETTINGS): A new type derived from GObject to handle
10197 GSettings notifications.
10198 (emacs_settings_constructor, emacs_settings_get_property)
10199 (emacs_settings_set_property, emacs_settings_class_init):
10200 New functions.
10201 (gsettings_client, gsettings_obj): New variables.
10202 (GSETTINGS_SCHEMA): New define.
10203 (something_changedCB): Call store_monospaced_changed.
10204 (init_gsettings): New function.
10205 (xsettings_initialize): Call init_gsettings.
10206 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10207 to NULL.
10208
640c8776 10209 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10210 GCONF_CFLAGS/LIBS.
10211
5386012d
MR
102122011-06-29 Martin Rudalics <rudalics@gmx.at>
10213
10214 * window.c (resize_root_window, grow_mini_window)
10215 (shrink_mini_window): Rename Qresize_root_window to
10216 Qwindow_resize_root_window and Qresize_root_window_vertically to
10217 Qwindow_resize_root_window_vertically.
10218
f13e0b08
PE
102192011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10220
10221 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10222
94515237
JB
102232011-06-27 Juanma Barranquero <lekktu@gmail.com>
10224
10225 * makefile.w32-in: Redesign dependencies so they reflect more
10226 clearly which files are directly included by each source file,
10227 and not through other includes.
10228
e43b6e43
MR
102292011-06-27 Martin Rudalics <rudalics@gmx.at>
10230
10231 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10232 (sort_overlays, overlay_strings): When an overlay's clone number
10233 matches the window's clone number process the overlay even if
10234 the overlay's window property doesn't match the current window.
10235
d68443dc
MR
10236 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10237 (Fwindow_hchild): Rename to Fwindow_left_child.
10238 (Fwindow_next): Rename to Fwindow_next_sibling.
10239 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10240 (resize_window_check): Rename to window_resize_check.
10241 (resize_window_apply): Rename to window_resize_apply.
10242 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10243 (Fdelete_other_windows_internal, resize_frame_windows)
10244 (Fsplit_window_internal, Fdelete_window_internal)
10245 (grow_mini_window, shrink_mini_window)
10246 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10247
c7e73be5
JD
102482011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10249
10250 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10251 (emacs_fixed_set_min_size): Remove.
10252 (emacs_fixed_new): Take frame as argument.
10253
10254 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10255 (_EmacsFixedPrivate): Remove minwidth/height.
10256 Add struct frame *f.
10257 (emacs_fixed_init): Initialize priv->f.
10258 (get_parent_class, emacs_fixed_set_min_size): Remove.
10259 (emacs_fixed_new): Set priv->f to argument.
10260 (emacs_fixed_get_preferred_width)
10261 (emacs_fixed_get_preferred_height): Use min_width/height from
10262 frames size_hint to set minimum and natural (Bug#8919).
10263 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10264 and use min_width/height from frames size_hint to set
10265 min_width/height (Bug#8919).
10266
10267 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10268 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10269 Fix indentation.
c7e73be5 10270
cf99dcf8
EZ
102712011-06-26 Eli Zaretskii <eliz@gnu.org>
10272
10273 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10274 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10275 called at ZV.
10276
029529ac
CY
102772011-06-26 Chong Yidong <cyd@stupidchicken.com>
10278
10279 * process.c (wait_reading_process_output): Bypass select if
10280 waiting for a cell while ignoring keyboard input, and input is
10281 pending. Suggested by Jan Djärv (Bug#8869).
10282
7a7ef429
PE
102832011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10284
10285 Use gnulib's dup2 module instead of rolling our own.
10286 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10287
11fdef7d 102882011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10289
10290 * dispnew.c (scrolling_window): Before scrolling, turn off a
10291 mouse-highlight in the window being scrolled.
10292
cd3520a4
JB
102932011-06-24 Juanma Barranquero <lekktu@gmail.com>
10294
10295 Move DEFSYM to lisp.h and use everywhere.
10296
10297 * character.h (DEFSYM): Move declaration...
10298 * lisp.h (DEFSYM): ...here.
10299
10300 * gnutls.c:
10301 * minibuf.c:
10302 * w32menu.c:
10303 * w32proc.c:
10304 * w32select.c: Don't include character.h.
10305
10306 * alloc.c (syms_of_alloc):
10307 * buffer.c (syms_of_buffer):
10308 * bytecode.c (syms_of_bytecode):
10309 * callint.c (syms_of_callint):
10310 * casefiddle.c (syms_of_casefiddle):
10311 * casetab.c (init_casetab_once):
10312 * category.c (init_category_once, syms_of_category):
10313 * ccl.c (syms_of_ccl):
10314 * cmds.c (syms_of_cmds):
10315 * composite.c (syms_of_composite):
10316 * dbusbind.c (syms_of_dbusbind):
10317 * dired.c (syms_of_dired):
10318 * dispnew.c (syms_of_display):
10319 * doc.c (syms_of_doc):
10320 * editfns.c (syms_of_editfns):
10321 * emacs.c (syms_of_emacs):
10322 * eval.c (syms_of_eval):
10323 * fileio.c (syms_of_fileio):
10324 * fns.c (syms_of_fns):
10325 * frame.c (syms_of_frame):
10326 * fringe.c (syms_of_fringe):
10327 * insdel.c (syms_of_insdel):
10328 * keymap.c (syms_of_keymap):
10329 * lread.c (init_obarray, syms_of_lread):
10330 * macros.c (syms_of_macros):
10331 * msdos.c (syms_of_msdos):
10332 * print.c (syms_of_print):
10333 * process.c (syms_of_process):
10334 * search.c (syms_of_search):
10335 * sound.c (syms_of_sound):
10336 * syntax.c (init_syntax_once, syms_of_syntax):
10337 * terminal.c (syms_of_terminal):
10338 * textprop.c (syms_of_textprop):
10339 * undo.c (syms_of_undo):
10340 * w32.c (globals_of_w32):
10341 * window.c (syms_of_window):
10342 * xdisp.c (syms_of_xdisp):
10343 * xfaces.c (syms_of_xfaces):
10344 * xfns.c (syms_of_xfns):
10345 * xmenu.c (syms_of_xmenu):
10346 * xsettings.c (syms_of_xsettings):
10347 * xterm.c (syms_of_xterm): Use DEFSYM.
10348
4228cf16
TZ
103492011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10350
cd3520a4 10351 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10352
7fcccf1e
PE
103532011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10354
7efb4e0e
PE
10355 Integer and buffer overflow fixes (Bug#8873).
10356
ff5844ad
PE
10357 * print.c (printchar, strout): Check for string overflow.
10358 (PRINTPREPARE, printchar, strout):
10359 Don't set size unless allocation succeeds.
10360
90532f02
PE
10361 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10362 for sizes. Check for string overflow more accurately.
10363 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10364
6d84508d
PE
10365 * macros.c: Integer and buffer overflow fixes.
10366 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10367 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10368 Use ptrdiff_t, not int, for sizes.
10369 Don't increment bufsize until after realloc succeeds.
10370 Check for size-calculation overflow.
10371 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10372
437b2cb4
PE
10373 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10374
8b9ac8b4
PE
10375 * lread.c: Integer overflow fixes.
10376 (read_integer): Radix is now EMACS_INT, not int,
10377 to improve quality of diagnostics for out-of-range radices.
10378 Calculate buffer size correctly for out-of-range radices.
10379 (read1): Check for integer overflow in radices, and in
10380 read-circle numbers.
82cb60d3
PE
10381 (read_escape): Avoid int overflow.
10382 (Fload, openp, read_buffer_size, read1)
10383 (substitute_object_recurse, read_vector, read_list, map_obarray):
10384 Use ptrdiff_t, not int, for sizes.
10385 (read1): Use EMACS_INT, not int, for sizes.
20270765 10386 Check for size overflow.
8b9ac8b4 10387
7fcccf1e
PE
10388 * image.c (cache_image): Check for size arithmetic overflow.
10389
bfbbd7e7
PE
10390 * lread.c: Integer overflow issues.
10391 (saved_doc_string_size, saved_doc_string_length)
10392 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10393 Now ptrdiff_t, not int.
10394 (read1): Don't assume doc string length fits in int. Check for
10395 out-of-range doc string lengths.
10396 (read_list): Don't assume file position fits in int.
39019e54 10397 (read_escape): Check for hex character overflow.
bfbbd7e7 10398
4e323265
LL
103992011-06-22 Leo Liu <sdl.web@gmail.com>
10400
10401 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10402 Move to minibuffer.el.
10403
85fece3e
PE
104042011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10405
20b84ce9 10406 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10407 The following patches are for when GLYPH_DEBUG && !XASSERT.
10408 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10409 * dispnew.c (flush_stdout):
10410 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10411 Mark as externally visible.
10412 * dispnew.c (check_window_matrix_pointers): Now static.
10413 * dispnew.c (window_to_frame_vpos):
10414 * xfns.c (unwind_create_frame):
10415 * xterm.c (x_check_font): Remove unused local.
10416 * scroll.c (CHECK_BOUNDS):
10417 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10418 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10419 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10420 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10421 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10422 Now static.
10423 (debug_method_add): Use va_list and vsprintf rather than relying
10424 on undefined behavior with wrong number of arguments.
10425 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10426 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10427 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10428 since we're not interested in debugging glyphs with old libraries.
10429 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10430 GCC 4.6.0's static checking.
10431
0766b489
PE
104322011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10433
31fd4b32
PE
10434 Integer overflow and signedness fixes (Bug#8873).
10435 A few related buffer overrun fixes, too.
10436
b79e8648
PE
10437 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10438
0766b489
PE
10439 * dispextern.h (struct face.stipple):
10440 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10441 (x_bitmap_mask, x_allocate_bitmap_record)
10442 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10443 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10444 (x_create_bitmap_from_xpm_data):
10445 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10446 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10447 (.bitmaps_last):
10448 * xfaces.c (load_pixmap):
10449 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10450 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10451 (.bitmaps_last, struct x_output.icon_bitmap):
10452 Use ptrdiff_t, not int, for bitmap indexes.
10453 (x_allocate_bitmap_record): Check for size overflow.
10454 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10455
b081724f
PE
10456 Use ptrdiff_t, not int, for overlay counts.
10457 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10458 * editfns.c (overlays_around, get_pos_property):
10459 * textprop.c (get_char_property_and_overlay):
10460 * xdisp.c (next_overlay_change, note_mouse_highlight):
10461 * xfaces.c (face_at_buffer_position):
21514da7
PE
10462 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10463 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10464 (Fnext_overlay_change, Fprevious_overlay_change)
10465 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10466 Use ptrdiff_t, not int, for sizes.
21514da7 10467 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10468
3de73e5e
PE
10469 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10470
2606c57b
PE
10471 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10472 (x_session_initialize): Do not assume string length fits in int.
10473
aaafe47a
PE
10474 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10475 This is unlikely, but can occur if DPI is outlandish.
10476
2674ddc8 10477 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10478 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10479
28154962
PE
10480 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10481 * xrdb.c (magic_file_p, search_magic_path):
10482 Omit last arg SUFFIX; it was always 0. All callers changed.
10483 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10484
7de51af5
PE
10485 * xfont.c (xfont_match): Avoid need for strlen.
10486
25ed6cc3
PE
10487 * xfns.c: Don't assume strlen fits in int.
10488 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10489
4eab31dd
PE
10490 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10491 not unsigned long, as we prefer signed integers. All callers changed.
10492 Detect integer overflow in repeat count.
10493 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10494 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10495
171e2a58
PE
10496 * termcap.c: Don't assume sizes fit in int and never overflow.
10497 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10498 (gobble_line): Check for size-calculation overflow.
10499
ad39faca 10500 * minibuf.c (Fread_buffer):
6e5bb2dc 10501 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10502 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10503 Don't assume string length fits in int.
10504
52c61c22 10505 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10506 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10507
b5b8c9e5
PE
10508 * font.c: Don't assume string length fits in int.
10509 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10510 Use ptrdiff_t, not int.
ccd6111c
PE
10511 (font_intern_prop): Don't assume string length fits in int.
10512 Don't assume integer property fits in fixnum.
10513 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10514
882f0d81 10515 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10516 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10517 Reformulate so as not to need the command string.
10518 Invoke gzip -cd rather than gunzip, as it's more portable.
10519 (lock_info_type, lock_file_1, lock_file):
10520 Don't assume pid_t and time_t fit in unsigned long.
10521 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10522 (current_lock_owner): Prefer signed type for sizes.
10523 Use memcpy, not strncpy, where memcpy is what is really wanted.
10524 Don't assume (via atoi) that time_t and pid_t fit in int.
10525 Check for time_t and/or pid_t out of range, e.g., via a network share.
10526 Don't alloca where an auto var works fine.
10527
93f4cf88
PE
10528 * fileio.c: Fix some integer overflow issues.
10529 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10530 Don't assume string length fits in int.
10531 (directory_file_name): Don't assume string length fits in long.
10532 (make_temp_name): Don't assume pid fits in int, or that its print
10533 length is less than 20.
10534
f3e92b69
PE
10535 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10536
1bfdaf10
PE
10537 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10538
35016e9a
PE
10539 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10540
3d1e65a1
PE
10541 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10542 We prefer signed integers, even for size calculations.
10543
0b963a93
PE
10544 * emacs.c: Don't assume string length fits in 'int'.
10545 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10546 (main): Don't invoke strlen when not needed.
10547
573f4b54
PE
10548 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10549 (XD_DEBUG_MESSAGE): Don't waste a byte.
10550
989f33ba
PE
10551 * callproc.c (getenv_internal_1, getenv_internal)
10552 (Fgetenv_internal):
965d34eb
PE
10553 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10554
e4d29b33
PE
10555 * lread.c (invalid_syntax): Omit length argument.
10556 All uses changed. This doesn't fix a bug, but it simplifies the
10557 code away from its former Hollerith-constant appearance, and it's
10558 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10559 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10560
eb49b136
PE
10561 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10562 This didn't break anything, but it didn't help either.
10563 It's confusing to put a bogus integer in a place where the actual
10564 value does not matter.
9f62aeb1 10565 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10566 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10567
15375a22
PE
10568 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10569 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10570 implementation.
b61cc01c
PE
10571 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10572 We prefer signed types, and the value cannot exceed the EMACS_INT
10573 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10574 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10575 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10576 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10577
53b2623d
PE
10578 * indent.c (sane_tab_width): New function.
10579 (current_column, scan_for_column, Findent_to, position_indentation)
10580 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10581 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10582
51cab52b 10583 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10584
f2ed8a70
PE
10585 * lisp.h (lint_assume): New macro.
10586 * composite.c (composition_gstring_put_cache):
10587 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10588
abe80cc6
PE
10589 * editfns.c, insdel.c:
10590 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10591
b02c740e
PE
10592 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10593
ebc96716
PE
10594 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10595
b4e50fa0 10596 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10597 Use much-faster test for byte-length change.
311d5d7c 10598 Don't assume string byte-length fits in 'int'.
a4cf38e4 10599 Check that character arg fits in 'int'.
85461888 10600 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10601
c0c1ee9f
PE
10602 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10603
a498d7f4
PE
10604 * fns.c (concat): Catch string overflow earlier.
10605 Do not rely on integer wraparound.
10606
51cab52b
PE
10607 * dispextern.h (struct it.overlay_strings_charpos)
10608 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10609 * xdisp.c (forward_to_next_line_start)
10610 (back_to_previous_visible_line_start)
10611 (reseat_at_next_visible_line_start, next_element_from_buffer):
10612 Don't arbitrarily truncate the value of 'selective' to int.
10613
76031fad
PE
10614 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10615
5eb55db9
PE
10616 * composite.c: Don't truncate sizes to 'int'.
10617 (composition_gstring_p, composition_reseat_it)
10618 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10619 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10620 not EMACS_UINT, for indexes.
5eb55db9 10621
0703a717
PE
10622 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10623
d6202519
PE
10624 * buffer.c: Include <verify.h>.
10625 (struct sortvec.priority, struct sortstr.priority):
8961a454 10626 Now EMACS_INT, not int.
c20998a7 10627 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10628 (struct sortstr.size, record_overlay_string)
10629 (struct sortstrlist.size, struct sortlist.used):
10630 Don't truncate size to int.
10631 (record_overlay_string): Check for size-calculation overflow.
d6202519 10632 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10633
d5a19415
JM
106342011-06-22 Jim Meyering <meyering@redhat.com>
10635
029529ac 10636 Don't leak an XBM-image-sized buffer
d5a19415
JM
10637 * image.c (xbm_load): Free the image buffer after using it.
10638
a9041e6c
PE
106392011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10640
10641 Port to Sun C.
10642 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10643 that Sun C diagnosed.
10644 * fns.c (secure_hash): Fix pointer signedness issue.
10645 * intervals.c (static_offset_intervals): New function.
10646 (offset_intervals): Use it.
10647
7f3f739f
LL
106482011-06-21 Leo Liu <sdl.web@gmail.com>
10649
10650 * deps.mk (fns.o):
10651 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10652 sha512.h.
10653
10654 * fns.c (secure_hash): Rename from crypto_hash_function and change
10655 the first arg to accept symbols.
5b66d427 10656 (Fsecure_hash): New primitive.
7f3f739f
LL
10657 (syms_of_fns): New symbols.
10658
76147d94
DD
106592011-06-20 Deniz Dogan <deniz@dogan.se>
10660
10661 * process.c (Fset_process_buffer): Clarify return value in
10662 docstring.
10663
7d7d0045
CY
106642011-06-18 Chong Yidong <cyd@stupidchicken.com>
10665
10666 * dispnew.c (add_window_display_history): Use BVAR.
10667
10668 * xdisp.c (debug_method_add): Use BVAR.
10669 (check_window_end, dump_glyph_matrix, dump_glyph)
10670 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10671
10672 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10673 Likewise.
10674
10675 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10676 check till after the cache is created in init_frame_faces.
10677
ff2bc410
SM
106782011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10679
10680 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10681
28177add
PE
106822011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10683
dd3482fe
PE
10684 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10685 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10686 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10687
393d71f3 10688 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10689 * fileio.c (Finsert_file_contents):
10690 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10691 Remove the old (too-loose) buffer overflow checks.
10692 They weren't needed, since make_gap checks for buffer overflow.
10693 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10694 The old code merely checked for Emacs fixnum overflow, and relied
10695 on undefined (wraparound) behavior. The new code avoids undefined
10696 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10697
2e6813b0 10698 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10699 Tune. Don't use wider integers than needed. Don't use alloca.
10700 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10701
599a9e4f
PE
10702 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10703
99561444
PE
10704 * insdel.c, lisp.h (buffer_overflow): New function.
10705 (insert_from_buffer_1, replace_range, replace_range_2):
10706 * insdel.c (make_gap_larger):
10707 * editfns.c (Finsert_char):
10708 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10709
28177add
PE
10710 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10711
e69dafad
PE
107122011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10713
4baa020d 10714 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10715
b1c46f02
PE
10716 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10717 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10718
e69dafad
PE
10719 * fileio.c: Don't assume EMACS_INT fits in off_t.
10720 (emacs_lseek): New static function.
10721 (Finsert_file_contents, Fwrite_region): Use it.
10722 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10723
566684ea
PE
10724 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10725
e6966cd6
PE
10726 * fns.c: Don't overflow int when computing a list length.
10727 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10728 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10729 truncation on 64-bit hosts. Check for QUIT every
10730 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10731 faster and is responsive enough.
10732 (Flength): Report an error instead of overflowing an integer.
10733 (Fsafe_length): Return a float if the value is not representable
10734 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10735 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10736 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10737
dd0b0efb
PE
10738 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10739 (header_size, word_size): New constants.
10740 (allocate_vectorlike): Don't check size overflow here.
10741 (allocate_vector): Check it here instead, since this is the only
10742 caller of allocate_vectorlike that could cause overflow.
10743 Check that the new vector's length is representable as a fixnum.
10744
86fe5cfe
PE
10745 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10746 The previous code was bogus. For example, next_almost_prime (32)
10747 returned 39, which is undesirable as it is a multiple of 3; and
10748 next_almost_prime (24) returned 25, which is a multiple of 5 so
10749 why was the code bothering to check for multiples of 7?
10750
80e88859
PE
10751 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10752
4a2f0ad6
PE
10753 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10754
f66c7cf8
PE
10755 Variadic C functions now count arguments with ptrdiff_t.
10756 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10757 Back then I didn't know that the Emacs coding style prefers signed int.
10758 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10759 were being counted with int, which may truncate counts on 64-bit
10760 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10761 * lisp.h (struct Lisp_Subr.function.aMANY)
10762 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10763 Arg counts are now ptrdiff_t, not size_t.
10764 All variadic functions and their callers changed accordingly.
10765 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10766 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10767 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10768 * callint.c (Fcall_interactively): Check arg count for overflow,
10769 to avoid potential buffer overrun. Use signed char, not 'int',
10770 for 'varies' array, so that we needn't bother to check its size
10771 calculation for overflow.
10772 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10773 * eval.c (apply_lambda):
10774 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10775 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10776 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10777
a1759b76
PE
10778 * callint.c (Fcall_interactively): Don't use index var as event count.
10779
d96be9fc
PE
10780 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10781 * mem-limits.h (SIZE): Remove; no longer used.
10782
a690a978 10783 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10784
578c21e6
PE
10785 Remove unnecessary casts.
10786 * xterm.c (x_term_init):
10787 * xfns.c (x_set_border_pixel):
10788 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10789 These aren't needed now that we assume ANSI C.
10790
96f53c6c
PE
10791 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10792 It's more likely to cause problems (due to unsigned overflow)
10793 than to cure them.
10794
83c77d31
PE
10795 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10796
ee2079f1
PE
10797 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10798
6da65536
PE
10799 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10800
7147c4a4
PE
10801 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10802
193e32d9
PE
10803 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10804
e5533da6
PE
10805 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10806
9910e595
PE
10807 GLYPH_CODE_FACE returns EMACS_INT, not int.
10808 * dispextern.h (merge_faces):
10809 * xfaces.c (merge_faces):
01103c44
PE
10810 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10811 Don't assume EMACS_INT fits in int.
9910e595 10812
2638320e
PE
10813 * character.h (CHAR_VALID_P): Remove unused parameter.
10814 * fontset.c, lisp.h, xdisp.c: All uses changed.
10815
045eb8d9
PE
10816 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10817
c1f134b5
PE
10818 * fns.c (concat): Minor tuning based on overflow analysis.
10819 This doesn't fix any bugs. Use int to hold character, instead
10820 of constantly refetching from Emacs object. Use XFASTINT, not
10821 XINT, for value known to be a character. Don't bother comparing
10822 a single byte to 0400, as it's always less.
10823
395fcb93 10824 * floatfns.c (Fexpt):
327eeec8
PE
10825 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10826
abbd3d23
PE
10827 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10828 for characters.
10829
684a03ef
PE
10830 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10831
0fed43f3
PE
10832 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10833 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10834 incorrectly succeed when S was a string, because 4294967386 was
10835 truncated before it was used.
10836
8fd02eb7
PE
10837 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10838 Otherwise, an out-of-range integer could cause undefined behavior
10839 on a 64-bit host.
10840
f8c86b69
PE
10841 * composite.c: Use int, not EMACS_INT, for characters.
10842 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10843 EMACS_INT, for values that are known to be in character range.
10844 This doesn't fix any bugs but is the usual style inside Emacs and
10845 may generate better code on 32-bit machines.
10846
34206dd2
PE
10847 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10848 This is for reasons similar to the recent CHAR_STRING fix.
10849 * charset.c (Fencode_char): Check that character arg is actually
10850 a character. Pass an int to ENCODE_CHAR.
10851 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10852 wider than 'int', as a compile-time check to prevent future regressions
10853 in this area.
10854
c5958d4c 10855 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10856
10857 Make sure a 64-bit char is never passed to CHAR_STRING.
10858 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10859 by silently ignoring the top 32 bits, allowing some values
10860 that were far too large to be valid characters.
10861 * character.h: Include <verify.h>.
10862 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10863 arguments are no wider than unsigned, as a compile-time check
10864 to prevent future regressions in this area.
10865 * data.c (Faset):
01103c44 10866 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10867 (Fsubst_char_in_region):
10868 * fns.c (concat):
10869 * xdisp.c (decode_mode_spec_coding):
10870 Adjust to CHAR_STRING's new requirement.
10871 * editfns.c (Finsert_char, Fsubst_char_in_region):
10872 * fns.c (concat): Check that character args are actually
10873 characters. Without this test, these functions did the wrong
10874 thing with wildly out-of-range values on 64-bit hosts.
10875
d37ca623
PE
10876 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10877 These casts should not be needed on 32-bit hosts, either.
10878 * keyboard.c (read_char):
10879 * lread.c (Fload): Remove casts to unsigned.
10880
ea204efb
PE
10881 * lisp.h (UNSIGNED_CMP): New macro.
10882 This fixes comparison bugs on 64-bit hosts.
10883 (ASCII_CHAR_P): Use it.
10884 * casefiddle.c (casify_object):
01103c44 10885 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10886 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10887 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10888 * dispextern.h (FACE_FROM_ID):
10889 * keyboard.c (read_char): Use UNSIGNED_CMP.
10890
41cb286c
PE
10891 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10892 not to EMACS_INT, to avoid GCC warning.
10893
4a1b9832
PE
10894 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10895
55daad71
PE
10896 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10897 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10898 isn't needed on 32-bit machines.
8f95c75c 10899
01103c44
PE
10900 * buffer.c (Fgenerate_new_buffer_name):
10901 Use EMACS_INT for count, not int.
0ceccced 10902 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10903
10904 * data.c (Qcompiled_function): Now static.
10905
c6f072e7
PE
10906 * window.c (window_body_lines): Now static.
10907
20ce5912
PE
10908 * image.c (gif_load): Rename local to avoid shadowing.
10909
9c4c5f81
PE
10910 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10911 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10912 * alloc.c (make_save_value): Integer argument is now of type
10913 ptrdiff_t, not int.
10914 (mark_object): Use ptrdiff_t, not int.
10915 * lisp.h (pD): New macro.
10916 * print.c (print_object): Use it.
10917
c0c5c8ae
PE
10918 * alloc.c: Use EMACS_INT, not int, to count objects.
10919 (total_conses, total_markers, total_symbols, total_vector_size)
10920 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10921 (total_free_floats, total_floats, total_free_intervals)
10922 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10923 Now EMACS_INT, not int. All uses changed.
10924 (Fgarbage_collect): Compute overall total using a double, so that
10925 integer overflow is less likely to be a problem. Check for overflow
10926 when converting back to an integer.
5a25e253
PE
10927 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10928 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10929 These were 'int' variables that could overflow on 64-bit hosts;
10930 they were never used, so remove them instead of repairing them.
211a0b2a 10931 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10932 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10933 Previously, this ceilinged at INT_MAX, but that doesn't work on
10934 64-bit machines.
e46bb31a 10935 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10936
c78baabf 10937 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10938 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10939 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10940 when a (possibly-narrower) signed value would do just as well.
10941 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10942
c9d624c6
PE
10943 * alloc.c: Catch some string size overflows that we were missing.
10944 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10945 for convenience in STRING_BYTES_MAX.
10946 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10947 The definition here is exact; the one in lisp.h was approximate.
10948 (allocate_string_data): Check for string overflow. This catches
10949 some instances we weren't catching before. Also, it catches
10950 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10951 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10952 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10953
c9d624c6
PE
10954 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10955 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10956 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10957
353032ce
PE
10958 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10959
2bccce07
PE
10960 * alloc.c (Fmake_string): Check for out-of-range init.
10961
0ac30604
SM
109622011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10963
10964 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10965
c195f2de
JD
109662011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10967
10968 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10969 xg_get_default_scrollbar_width.
10970
10971 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10972 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10973 (style_changed_cb): Call update_theme_scrollbar_width and call
10974 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10975 all frames (Bug#8505).
10976 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10977 Call gtk_window_set_resizable if HAVE_GTK3.
10978 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10979 and height if HAVE_GTK3 (Bug#8505).
10980 (scroll_bar_width_for_theme): New variable.
10981 (update_theme_scrollbar_width): New function.
10982 (xg_get_default_scrollbar_width): Move code to
10983 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10984 (xg_initialize): Call update_theme_scrollbar_width.
10985
10986 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10987
10988 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10989
e10ac9f1
MR
109902011-06-12 Martin Rudalics <rudalics@gmx.at>
10991
10992 * frame.c (make_frame): Call other_buffer_safely instead of
10993 other_buffer.
10994
10995 * window.c (temp_output_buffer_show): Call display_buffer with
10996 second argument Vtemp_buffer_show_specifiers and reset latter
10997 immediately after the call.
10998 (Vtemp_buffer_show_specifiers): New variable.
10999 (auto_window_vscroll_p, next_screen_context_lines)
11000 (Vscroll_preserve_screen_position): Remove leading asterisks from
11001 doc-strings.
11002
2d3c217e 110032011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11004
7b7f97e8 11005 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11006 * buffer.c (Qclone_number): Remove for now, as it's unused.
11007 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11008 (record_buffer): Remove unused local.
11009 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11010 (set_frame_buffer_list): Remove; unused.
11011 * frame.h (other_visible_frames): Remove decl.
11012 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11013 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11014 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11015 if HAVE_GPM.
11016 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11017 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11018 Define only if HAVE_GPM.
11019 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11020 (update_hints_inhibit): Remove; never set. All uses removed.
11021 * widgetprv.h (emacsFrameClassRec): Remove decl.
11022 * window.c (delete_deletable_window): Now returns void, since it
11023 wasn't returning anything.
11024 (compare_window_configurations): Remove unused locals.
11025 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11026 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11027 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11028 the same widths as pointers. This follows up on the 2011-05-06 patch.
11029 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11030 * xterm.h: Likewise.
11031 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11032
1384b89e
JB
110332011-06-12 Juanma Barranquero <lekktu@gmail.com>
11034
11035 * makefile.w32-in: Update dependencies.
11036 (LISP_H): Add lib/intprops.h.
11037
1100a63c
CY
110382011-06-11 Chong Yidong <cyd@stupidchicken.com>
11039
11040 * image.c (gif_load): Add animation frame delay to the metadata.
11041 (syms_of_image): Use DEFSYM. New symbol `delay'.
11042
6198ccd0
MR
110432011-06-11 Martin Rudalics <rudalics@gmx.at>
11044
11045 * window.c (delete_deletable_window): Re-add.
11046 (Fset_window_configuration): Rewrite to handle dead buffers and
11047 consequently deletable windows.
11048 (window_tree, Fwindow_tree): Remove. Supply functionality in
11049 window.el.
11050 (compare_window_configurations): Simplify code.
11051
b6e3633c
AS
110522011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11053
1ab0dee5
AS
11054 * image.c (imagemagick_load_image): Fix type mismatch.
11055 (Fimagemagick_types): Likewise.
11056
b6e3633c
AS
11057 * window.h (replace_buffer_in_windows): Declare.
11058
9397e56f
MR
110592011-06-11 Martin Rudalics <rudalics@gmx.at>
11060
11061 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11062 Qclone_number. Remove external declaration of Qdelete_window.
11063 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11064 code.
640c8776
SM
11065 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11066 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11067 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11068 buffer list implementation.
11069 (other_buffer_safely): New function.
11070 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11071 calls to replace_buffer_in_windows and
11072 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11073 if allowed.
11074 (record_buffer): Inhibit quitting and rewrite using quittable
11075 functions. Run Qbuffer_list_update_hook if allowed.
11076 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11077 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11078 Move switch-to-buffer to window.el.
9397e56f
MR
11079 (bury-buffer): Move to window.el.
11080 (Vbuffer_list_update_hook): New variable.
11081
11082 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11083 section.
11084
11085 * window.h (resize_frame_windows): Move up in code.
11086 (Fwindow_frame): Remove EXFUN.
11087 (replace_buffer_in_all_windows): Remove prototype.
11088 (replace_buffer_in_windows_safely): Add prototype.
11089
11090 * window.c: Declare Qdelete_window static again. Move down
11091 declaration of select_count.
11092 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11093 (Fother_window): Move to window.el.
11094 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11095 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11096 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11097 window.el.
11098 (replace_buffer_in_windows): Implement by calling
11099 Qreplace_buffer_in_windows.
11100 (replace_buffer_in_all_windows): Remove with some functionality
11101 moved into replace_buffer_in_windows_safely.
11102 (replace_buffer_in_windows_safely): New function.
11103 (select_window_norecord, select_frame_norecord): Move in front
11104 of run_window_configuration_change_hook. Remove now obsolete
11105 declarations.
640c8776
SM
11106 (Fset_window_buffer): Rewrite doc-string.
11107 Call Qrecord_window_buffer.
9397e56f
MR
11108 (keys_of_window): Move binding for other-window to window.el.
11109
b50691aa
CY
111102011-06-11 Chong Yidong <cyd@stupidchicken.com>
11111
11112 * dispextern.h (struct image): Replace data member, whose int_val
11113 and ptr_val fields were not used by anything, with a single
11114 lisp_val object.
11115
11116 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11117 (gif_clear_image, gif_load, imagemagick_load_image)
11118 (gs_clear_image, gs_load): Callers changed.
11119
3f754b86
PE
111202011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11121
cca69397
PE
11122 * buffer.h: Include <time.h>, for time_t.
11123 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11124
109e28d0
PE
11125 Fix minor problems found by static checking.
11126
60737f02
PE
11127 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11128
4b66faf3
PE
11129 Make identifiers static if they are not used in other modules.
11130 * data.c (Qcompiled_function, Qframe, Qvector):
11131 * image.c (QimageMagick, Qsvg):
11132 * minibuf.c (Qmetadata):
11133 * window.c (resize_window_check, resize_root_window): Now static.
11134 * window.h (resize_window_check, resize_root_window): Remove decls.
11135
109e28d0
PE
11136 * window.c (window_deletion_count, delete_deletable_window):
11137 Remove; unused.
46a4ce9e
PE
11138 (window_body_lines): Now static.
11139 (Fdelete_other_windows_internal): Mark vars as initialized.
11140 Make sure 'resize_failed' is initialized.
11141 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11142 (resize_window_apply): Remove unused local.
11143 * window.h (delete_deletable_window): Remove decl.
11144
109e28d0 11145 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11146 (imagemagick_load_image): Fix pointer signedness problem by changing
11147 last arg from unsigned char * to char *. All uses changed.
11148 Also, fix a local for similar reasons.
11149 Remove unused locals. Remove locals to avoid shadowing.
11150 (fn_rsvg_handle_free): Remove; unused.
11151 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11152 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11153
3f754b86
PE
11154 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11155
2547adb1
CY
111562011-06-10 Chong Yidong <cyd@stupidchicken.com>
11157
11158 * image.c (gif_load): Fix omitted cast error introduced by
11159 2011-06-06 change.
11160
2c8e37d4
MR
111612011-06-10 Martin Rudalics <rudalics@gmx.at>
11162
11163 * window.h (resize_proportionally, orig_total_lines)
11164 (orig_top_line): Remove from window structure.
11165 (set_window_height, set_window_width, change_window_heights)
11166 (Fdelete_window): Remove prototypes.
11167 (resize_frame_windows): Remove duplicate declaration.
11168
440a42e3
EZ
111692011-06-10 Eli Zaretskii <eliz@gnu.org>
11170
11171 * window.h (resize_frame_windows, resize_window_check)
11172 (delete_deletable_window, resize_root_window)
11173 (resize_frame_windows): Declare prototypes.
11174
11175 * window.c (resize_window_apply): Make definition be "static" to
11176 match the prototype.
11177
562dd5e9
MR
111782011-06-10 Martin Rudalics <rudalics@gmx.at>
11179
11180 * window.c: Remove declarations of Qwindow_size_fixed,
11181 window_min_size_1, window_min_size_2, window_min_size,
11182 size_window, window_fixed_size_p, enlarge_window, delete_window.
11183 Remove static from declaration of Qdelete_window, it's
11184 temporarily needed by Fbury_buffer.
11185 (replace_window): Don't assign orig_top_line and
11186 orig_total_lines.
11187 (Fdelete_window, delete_window): Remove. Window deletion is
11188 handled by window.el.
640c8776
SM
11189 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11190 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11191 (Fdelete_other_windows): Remove. Deleting other windows is
11192 handled by window.el.
11193 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11194 handled in window.el.
11195 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11196 Window minimum sizes are handled in window.el.
11197 (shrink_windows, size_window, set_window_height)
11198 (set_window_width, change_window_heights, window_height)
11199 (window_width, CURBEG, CURSIZE, enlarge_window)
11200 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11201 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11202 handled in window.el.
11203 (make_dummy_parent): Rename to make_parent_window and give it a
11204 second argument horflag.
11205 (make_window): Don't set resize_proportionally any more.
11206 (Fsplit_window): Remove. Windows are split in window.el.
11207 (save_restore_action, save_restore_orig_size)
11208 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11209 Resize mini windows in window.el.
11210 (grow_mini_window, shrink_mini_window): Implement by calling
11211 Qresize_root_window_vertically, resize_window_check and
11212 resize_window_apply.
640c8776
SM
11213 (saved_window, Fset_window_configuration, save_window_save):
11214 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11215 resize_proportionally.
11216 (window_min_height, window_min_width): Move to window.el.
11217 (keys_of_window): Move bindings for delete-other-windows,
11218 split-window, delete-window and enlarge-window to window.el.
11219
11220 * buffer.c: Temporarily extern Qdelete_window.
11221 (Fbury_buffer): Temporarily call Qdelete_window instead of
11222 Fdelete_window (Fbury_buffer will move to window.el soon).
11223
11224 * frame.c (set_menu_bar_lines_1): Remove code handling
11225 orig_top_line and orig_total_lines.
11226
11227 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11228 set_window_height but set heights directly.
11229 (change_frame_size_1): Use resize_frame_windows.
11230
11231 * xdisp.c (init_xdisp): Don't use set_window_height but set
11232 heights directly.
11233
640c8776
SM
11234 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11235 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11236 run_window_configuration_change_hook.
11237
11238 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11239 instead of change_window_heights and run
11240 run_window_configuration_change_hook.
11241
1a13852e
MR
112422011-06-09 Martin Rudalics <rudalics@gmx.at>
11243
11244 * window.c (replace_window): Rename second argument REPLACEMENT to
11245 NEW. New third argument SETFLAG. Rewrite.
11246 (delete_window, make_dummy_parent): Call replace_window with
11247 third argument 1.
11248 (window_list_1): Move down in code.
11249 (run_window_configuration_change_hook): Move set_buffer part
11250 before select_frame_norecord part in order to unwind correctly.
11251 Rename count1 to count.
11252 (recombine_windows, delete_deletable_window, resize_root_window)
11253 (Fdelete_other_windows_internal)
11254 (Frun_window_configuration_change_hook, make_parent_window)
11255 (resize_window_check, resize_window_apply, Fresize_window_apply)
11256 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11257 (Fdelete_window_internal, Fresize_mini_window_internal):
11258 New functions.
1a13852e
MR
11259 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11260
f3d1777e
MR
112612011-06-08 Martin Rudalics <rudalics@gmx.at>
11262
496e208e
MR
11263 * window.h (window): Add some new members to window structure -
11264 normal_lines, normal_cols, new_total, new_normal, clone_number,
11265 splits, nest, prev_buffers, next_buffers.
11266 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11267 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11268
f3d1777e
MR
11269 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11270 Remove.
496e208e
MR
11271 (make_dummy_parent): Set new members of windows structure.
11272 (make_window): Move down in code. Handle new members of window
11273 structure.
11274 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11275 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11276 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11277 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11278 (Fset_window_next_buffers, Fset_window_clone_number):
11279 New functions.
496e208e
MR
11280 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11281 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11282 Doc-string fixes.
11283 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11284 Argument WINDOW can be now internal window too.
11285 (Fwindow_use_time): Move up in code.
11286 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11287 Rewrite doc-string.
11288 (Fset_window_configuration, saved_window)
11289 (Fcurrent_window_configuration, save_window_save): Handle new
11290 members of window structure.
b9e809c2
MR
11291 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11292 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11293 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11294 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11295 Qget_mru_window, Qresize_root_window,
11296 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11297 Qauto_buffer_name; staticpro them.
f3d1777e 11298
abde8f8c
MR
112992011-06-07 Martin Rudalics <rudalics@gmx.at>
11300
11301 * window.c (Fwindow_total_size, Fwindow_left_column)
11302 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11303 (Fwindow_list_1): New functions.
11304 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11305 (Fwindow_width, Fscroll_left, Fscroll_right):
11306 Use window_body_cols instead of window_box_text_cols.
11307 (delete_window, Fset_window_configuration):
11308 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11309 (delete_all_subwindows): Take a window as argument and not a
11310 structure. Rewrite.
190b47e6
MR
11311 (window_loop): Remove handling of GET_LRU_WINDOW and
11312 GET_LARGEST_WINDOW.
11313 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11314
11315 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11316 window_box_text_cols. delete_all_subwindows now takes a
11317 Lisp_Object as argument.
abde8f8c 11318
640c8776
SM
11319 * indent.c (compute_motion, Fcompute_motion):
11320 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11321
fa8a67e6
MR
11322 * frame.c (delete_frame): Call delete_all_subwindows with root
11323 window as argument.
11324
a54e3482
DC
113252011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11326
11327 * fns.c (Fputhash): Document return value.
11328
60002bf5
CY
113292011-06-06 Chong Yidong <cyd@stupidchicken.com>
11330
11331 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11332
0c671da6 113332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11334
b862a52a 11335 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11336
be44ca6c
PE
11337 Check for overflow when converting integer to cons and back.
11338 * charset.c (Fdefine_charset_internal, Fdecode_char):
11339 Use cons_to_unsigned to catch overflow.
11340 (Fencode_char): Use INTEGER_TO_CONS.
11341 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11342 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11343 * data.c (long_to_cons, cons_to_long): Remove.
11344 (cons_to_unsigned, cons_to_signed): New functions.
11345 These signal an error for invalid or out-of-range values.
11346 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11347 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11348 * font.c (Ffont_variation_glyphs):
11349 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11350 * lisp.h: Include <intprops.h>.
11351 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11352 (cons_to_signed, cons_to_unsigned): New decls.
11353 (long_to_cons, cons_to_long): Remove decls.
11354 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11355 (Fprimitive_undo): Use CONS_TO_INTEGER.
11356 * xfns.c (Fx_window_property): Likewise.
11357 * xselect.c: Include <limits.h>.
11358 (x_own_selection, selection_data_to_lisp_data):
11359 Use INTEGER_TO_CONS.
11360 (x_handle_selection_request, x_handle_selection_clear)
11361 (x_get_foreign_selection, Fx_disown_selection_internal)
11362 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11363 (lisp_data_to_selection_data): Use cons_to_unsigned.
11364 (x_fill_property_data): Use cons_to_signed.
11365 Report values out of range.
11366
d1f3d2af
PE
11367 Check for buffer and string overflow more precisely.
11368 * buffer.h (BUF_BYTES_MAX): New macro.
11369 * lisp.h (STRING_BYTES_MAX): New macro.
11370 * alloc.c (Fmake_string):
11371 * character.c (string_escape_byte8):
11372 * coding.c (coding_alloc_by_realloc):
11373 * doprnt.c (doprnt):
11374 * editfns.c (Fformat):
11375 * eval.c (verror):
11376 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11377 since they may not be the same number.
11378 * editfns.c (Finsert_char):
11379 * fileio.c (Finsert_file_contents):
11380 Likewise for BUF_BYTES_MAX.
11381
dd52fcea
PE
11382 * image.c: Use ptrdiff_t, not int, for sizes.
11383 (slurp_file): Switch from int to ptrdiff_t.
11384 All uses changed.
11385 (slurp_file): Check that file size fits in both size_t (for
11386 malloc) and ptrdiff_t (for sanity and safety).
11387
7f9bbdbb
PE
11388 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11389 if b->modtime has its maximal value.
11390
dfe18f82
PE
11391 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11392
84acfcf0
PE
11393 Don't assume time_t can fit into int.
11394 * buffer.h (struct buffer.modtime): Now time_t, not int.
11395 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11396 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11397
ccd9a01a
PE
11398 Minor fixes for signed vs unsigned integers.
11399 * character.h (MAYBE_UNIFY_CHAR):
11400 * charset.c (maybe_unify_char):
11401 * keyboard.c (read_char, reorder_modifiers):
11402 XINT -> XFASTINT, since the integer must be nonnegative.
11403 * ftfont.c (ftfont_spec_pattern):
11404 * keymap.c (access_keymap, silly_event_symbol_error):
11405 XUINT -> XFASTINT, since the integer must be nonnegative.
11406 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11407 since it makes no difference and we prefer signed.
11408 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11409 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11410 nonnegative.
11411
d6d100dd
SM
114122011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11413
11414 * window.h (Fwindow_frame): Declare.
11415
2b6148e4
PE
114162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11417
11418 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11419 (SPARE_MEMORY): Always define.
11420 (LARGE_REQUEST): Remove.
11421 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11422
f230ecc9
MR
114232011-06-06 Martin Rudalics <rudalics@gmx.at>
11424
727e958e
MR
11425 * lisp.h: Move EXFUNS for Fframe_root_window,
11426 Fframe_first_window and Fset_frame_selected_window to window.h.
11427
11428 * window.h: Move EXFUNS for Fframe_root_window,
11429 Fframe_first_window and Fset_frame_selected_window here from
11430 lisp.h.
11431
11432 * frame.c (Fwindow_frame, Fframe_first_window)
11433 (Fframe_root_window, Fframe_selected_window)
11434 (Fset_frame_selected_window): Move to window.c.
11435 (Factive_minibuffer_window): Move to minibuf.c.
11436 (Fother_visible_frames_p): New function.
11437
11438 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11439
f230ecc9
MR
11440 * window.c (decode_window, decode_any_window): Move up in code.
11441 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11442 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11443 (Fwindow_buffer): Move up and rewrite doc-string.
11444 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11445 (Fwindow_prev): New functions.
727e958e
MR
11446 (Fwindow_frame): Move here from frame.c. Accept any window as
11447 argument.
11448 (Fframe_root_window, Fframe_first_window)
11449 (Fframe_selected_window): Move here from frame.c. Accept frame
11450 or arbitrary window as argument. Update doc-strings.
11451 (Fminibuffer_window): Move up in code.
11452 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11453 (Fset_frame_selected_window): Move here from frame.c.
11454 Marginal rewrite.
727e958e
MR
11455 (Fselected_window, select_window, Fselect_window): Move up in
11456 code. Minor doc-string fixes.
f230ecc9 11457
4d09bcf6
PE
114582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11459
11460 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11461 Do not assume that spare memory exists; that assumption is valid
11462 only if SYSTEM_MALLOC.
11463 (LARGE_REQUEST): New macro, so that the issue of large requests
11464 is separated from the issue of spare memory.
11465
810928a2
AS
114662011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11467
172418ad
AS
11468 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11469 format. (Bug#8806)
11470
43f862f7
AS
11471 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11472
810928a2
AS
11473 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11474 before statements.
11475
a059fe24
JD
114762011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11477
11478 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11479
11480 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11481
11482 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11483 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11484
989bf368
JB
114852011-06-05 Juanma Barranquero <lekktu@gmail.com>
11486
11487 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11488
4b80f674
CY
114892011-06-04 Chong Yidong <cyd@stupidchicken.com>
11490
11491 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11492 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11493 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11494 New error handlers.
4b80f674
CY
11495 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11496 Obey Vx_select_enable_clipboard_manager. Catch errors in
11497 x_clipboard_manager_save (Bug#8779).
11498 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11499 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11500
99a33b77 115012011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11502
11503 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11504
99a33b77 115052011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11506
11507 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11508 in the current matrix if keep_current_p is non-zero.
11509
8264569d
EZ
115102011-06-04 Eli Zaretskii <eliz@gnu.org>
11511
11512 * bidi.c (bidi_level_of_next_char): Fix last change.
11513
57f97249
EZ
115142011-06-03 Eli Zaretskii <eliz@gnu.org>
11515
fec2107c 11516 Support bidi reordering of text covered by display properties.
57f97249 11517
fec2107c
EZ
11518 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11519 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11520 (bidi_cache_search, bidi_cache_iterator_state)
11521 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11522 (bidi_level_of_next_char, bidi_move_to_visually_next):
11523 Support character positions inside a run of characters covered by a
fec2107c
EZ
11524 display string.
11525 (bidi_paragraph_init, bidi_resolve_explicit_1)
11526 (bidi_level_of_next_char): Call bidi_fetch_char and
11527 bidi_fetch_char_advance instead of FETCH_CHAR and
11528 FETCH_CHAR_ADVANCE.
11529 (bidi_init_it): Initialize new members.
11530 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11531 definitions.
11532 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11533 instead of using explicit *_CHAR codes.
d6d100dd
SM
11534 (bidi_resolve_explicit, bidi_resolve_weak):
11535 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11536 bidirectional text is supported only in multibyte buffers.
11537 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11538 it to initialize the frame_window_p member of struct bidi_it.
11539 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11540 (bidi_resolve_explicit, bidi_resolve_weak)
11541 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11542 bidi_it->nchars is non-positive.
11543 (bidi_level_of_next_char): Don't try to lookup the cache for the
11544 next/previous character if nothing is cached there yet, or if we
11545 were just reseat()'ed to a new position.
c40e2fb2 11546
0e14fe90
EZ
11547 * xdisp.c (set_cursor_from_row): Set start and stop points
11548 according to the row's direction when priming the loop that looks
11549 for the glyph on which to display cursor.
11550 (single_display_spec_intangible_p): Function deleted.
11551 (display_prop_intangible_p): Reimplement to call
11552 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11553 Accept 3 additional arguments needed by handle_display_spec.
11554 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11555 values: lists, `(when COND...)' forms, etc.
11556 (single_display_spec_string_p): Support property values that are
11557 lists with the argument STRING its top-level element.
11558 (display_prop_string_p): Fix the condition for processing a
11559 property that is a list to be consistent with handle_display_spec.
fec2107c 11560 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11561 last portion of handle_display_prop.
11562 (compute_display_string_pos): Accept additional argument
11563 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11564 value of a `display' property is a "replacing spec".
11565 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11566 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11567 the display property, but just return a value indicating whether
11568 the display property will replace the characters it covers.
11569 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11570 frame_window_p members of struct bidi_it.
d6d100dd
SM
11571 (compute_display_string_pos, compute_display_string_end):
11572 New functions.
fec2107c
EZ
11573 (push_it): Accept second argument POSITION, where pop_it should
11574 jump to continue iteration.
11575 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11576
fec2107c
EZ
11577 * keyboard.c (adjust_point_for_property): Adjust the call to
11578 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11579
11580 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11581 (bidi_init_it): Update prototypes.
11582 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11583 (compute_display_string_pos, compute_display_string_end):
11584 Declare prototypes.
fec2107c
EZ
11585 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11586 EMACS_INT.
fc6f18ce 11587
40087514 115882011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11589
57f53182
PE
11590 Malloc failure behavior now depends on size of allocation.
11591 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11592 * lisp.h: Change signatures accordingly.
11593 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11594 All callers changed. (Bug#8762)
11595
11596 * gnutls.c: Use Emacs's memory allocators.
11597 Without this change, the gnutls library would invoke malloc etc.
11598 directly, which causes problems on non-SYNC_INPUT hosts, and which
11599 runs afoul of improving memory_full behavior. (Bug#8761)
11600 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11601 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11602 xfree instead of the default malloc, realloc, free.
11603 (Fgnutls_boot): No need to check for memory allocation failure,
11604 since xmalloc does that for us.
11605
ac32cd99 11606 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11607 * category.c (hash_get_category_set):
11608 * ccl.c (ccl_driver):
11609 * charset.c (Fdefine_charset_internal):
11610 * charset.h (struct charset.hash_index):
11611 * composite.c (get_composition_id, gstring_lookup_cache)
11612 (composition_gstring_put_cache):
11613 * composite.h (struct composition.hash_index):
11614 * dispextern.h (struct image.hash):
11615 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11616 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11617 (hashfn_equal, hashfn_user_defined, make_hash_table)
11618 (maybe_resize_hash_table, hash_lookup, hash_put)
11619 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11620 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11621 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11622 * image.c (make_image, search_image_cache, lookup_image)
11623 (xpm_put_color_table_h):
11624 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11625 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11626 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11627 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11628 * alloc.c (allocate_vectorlike):
11629 Check for overflow in vector size calculations.
11630 * ccl.c (ccl_driver):
11631 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11632 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11633 need to be updated by these changes.
40087514
PE
11634 * fns.c (make_hash_table, maybe_resize_hash_table):
11635 Check for integer overflow with large hash tables.
0de4bb68
PE
11636 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11637 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11638 (SXHASH_REDUCE): New macro.
11639 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11640 Use it instead of discarding useful hash info with large hash values.
11641 (sxhash_float): New function.
11642 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11643 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11644 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11645 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11646 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11647 Adjust signatures to match updated version of code.
11648 (consing_since_gc): Now EMACS_INT, since a single hash table can
11649 use more than INT_MAX bytes.
11650
698d32e2
DN
116512011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11652
11653 Make it possible to build with GCC-4.6+ -O2 -flto.
11654
11655 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11656
fd6fa53f
SM
116572011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11658
11659 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11660 Call minibuffer-inactive-mode.
11661
864db017
JB
116622011-05-31 Juanma Barranquero <lekktu@gmail.com>
11663
11664 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11665 Update dependencies.
11666
2ad0baf4
DN
116672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11668
11669 * data.c (init_data): Remove code for UTS, this system is not
11670 supported anymore.
11671
4fcc2638
DN
116722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11673
11674 Don't force ./temacs to start in terminal mode.
11675
11676 * frame.c (make_initial_frame): Initialize faces in all cases, not
11677 only when CANNOT_DUMP is defined.
11678 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11679
c56e0fd5
DN
116802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11681
11682 * dispnew.c (add_window_display_history): Use const for the string
11683 pointer. Remove declaration, not needed.
11684
333d54da 116852011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11686
55d4c1b2 11687 Use 'inline', not 'INLINE'.
333d54da 11688 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11689 * alloc.c, fontset.c (INLINE): Remove.
11690 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11691 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11692 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11693 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11694 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11695
738db178
DN
116962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11697
11698 Make it possible to run ./temacs.
11699
11700 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11701 syms_of_callproc does the same thing. Remove test for
11702 "initialized", do it in the caller.
11703 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11704
620c53a6
SM
117052011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11706
11707 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11708 (read_minibuf): Use get_minibuffer.
11709 (syms_of_minibuf): Use DEFSYM.
11710 (Qmetadata): New var.
11711 * data.c (Qbuffer): Don't make it static.
11712 (syms_of_data): Use DEFSYM.
11713
e003a292
PE
117142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11715
11716 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11717 (CCL_CODE_MIN): New macro.
11718
ed008a6d
PE
117192011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11720
3687c2ef
PE
11721 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11722
ed008a6d
PE
11723 * eval.c (Qdebug): Now static.
11724 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11725 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11726 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11727
d66c4c7c
CY
117282011-05-29 Chong Yidong <cyd@stupidchicken.com>
11729
11730 * image.c: Various fixes to ImageMagick code comments.
11731 (Fimagemagick_types): Doc fix.
11732
5fbc2025
PE
117332011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11734
0196f88a
PE
11735 Minor fixes prompted by GCC 4.6.0 warnings.
11736
11737 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11738
5fbc2025
PE
11739 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11740 (x_clipboard_manager_save_all): Move extern decl to ...
11741 * xterm.h: ... here, so that it can be checked for consistency.
11742
1dd3c2d9
CY
117432011-05-29 Chong Yidong <cyd@stupidchicken.com>
11744
11745 * xselect.c (x_clipboard_manager_save_frame)
11746 (x_clipboard_manager_save_all): New functions.
11747 (Fx_clipboard_manager_save): Lisp function deleted.
11748
11749 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11750 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11751
11752 * xterm.h: Update prototype.
11753
5ba6571d
WX
117542011-05-28 William Xu <william.xwl@gmail.com>
11755
11756 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11757 exiting (Bug#8239).
11758
3eaff834
JM
117592011-05-28 Jim Meyering <meyering@redhat.com>
11760
e1900994 11761 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11762 * fns.c (to_uchar): Define.
11763 (crypto_hash_function): Use it to convert some newly-signed
11764 variables to unsigned, to avoid sign-extension bugs. For example,
11765 without this change, (md5 "truc") would evaluate to
11766 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11767 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11768 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11769
0f6990a7
PE
117702011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11771
11772 Integer overflow fixes.
c8a9ca5a 11773
08686060
PE
11774 * dbusbind.c: Serial number integer overflow fixes.
11775 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11776 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11777 to hold a serial number that is too large for a fixnum.
11778 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11779 Check for serial numbers out of range. Decode any serial number
59568bf0 11780 that was so large that it became a float. (Bug#8722)
08686060 11781
2d1fc3c7
PE
11782 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11783 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11784 Use XFASTINT rather than XUINT when numbers are nonnegative.
11785 (xd_append_arg, Fdbus_method_return_internal):
11786 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11787 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11788 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11789 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11790 (Bug#8722)
2d1fc3c7 11791
c8a9ca5a
PE
11792 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11793
519e1d69
PE
11794 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11795
6df6ae42 11796 ccl: Add integer overflow checks.
30569699
PE
11797 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11798 (IN_INT_RANGE): New macros.
11799 (ccl_driver): Use them to check for integer overflow when
11800 decoding a CCL program. Many of the new checks are whether XINT (x)
11801 fits in int; it doesn't always, on 64-bit hosts. The new version
11802 doesn't catch all possible integer overflows, but it's an
847044ea 11803 improvement. (Bug#8719)
30569699 11804
c11285dc
PE
11805 * alloc.c (make_event_array): Use XINT, not XUINT.
11806 There's no need for unsigned here.
11807
fdccd48e
PE
11808 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11809 This follows up to the 2011-05-06 change that substituted uintptr_t
11810 for EMACS_INT. This case wasn't caught back then.
11811
37910ab2
PE
11812 Rework Fformat to avoid integer overflow issues.
11813 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11814 now (part of C89). Include <verify.h>.
11815 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11816 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11817 (Fformat): Avoid the prepass trying to compute sizes; it was only
11818 approximate and thus did not catch overflow reliably. Instead, walk
11819 through the format just once, formatting and computing sizes as we go,
11820 checking for integer overflow at every step, and allocating a larger
11821 buffer as needed. Keep track separately whether the format is
11822 multibyte. Keep only the most-recently calculated precision, rather
11823 than them all. Record whether each argument has been converted to
11824 string. Use EMACS_INT, not int, for byte and char and arg counts.
11825 Support field widths and precisions larger than INT_MAX. Avoid
11826 sprintf's undefined behavior with conversion specifications such as %#d
11827 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11828 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11829 formatting out-of-range floating point numbers with int
9173deec 11830 formats. (Bug#8668)
37910ab2 11831
2e6578fb
PE
11832 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11833
0ae6bdee
PE
11834 * data.c: Avoid integer truncation in expressions involving floats.
11835 * data.c: Include <intprops.h>.
11836 (arith_driver): When there's an integer overflow in an expression
11837 involving floating point, convert the integers to floating point
11838 so that the resulting value does not suffer from catastrophic
11839 integer truncation. For example, on a 64-bit host (* 4
11840 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11841 Do not rely on undefined behavior after integer overflow.
11842
de883a70
PE
11843 merge count_size_as_multibyte, parse_str_to_multibyte
11844 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11845 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11846 Check for integer overflow.
11847 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11848 since it's now a duplicate of the other. This is more of
11849 a character than a buffer op, so better that it's in character.c.
11850 * fns.c, print.c: Adjust to above changes.
11851
2ff916cb
PE
118522011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11853
11854 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11855
f1b54466
PE
118562011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11857
fb1ac845
PE
11858 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11859 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11860 (x_clipboard_manager_save): Now static.
11861 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11862
f1b54466
PE
11863 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11864 (crypto_hash_function): Now static.
11865 Fix pointer signedness problems. Avoid unnecessary initializations.
11866
a9f737ee
CY
118672011-05-27 Chong Yidong <cyd@stupidchicken.com>
11868
11869 * termhooks.h (Vselection_alist): Make it terminal-local.
11870
11871 * terminal.c (create_terminal): Initialize it.
11872
11873 * xselect.c: Support for clipboard managers.
11874 (Vselection_alist): Move to termhooks.h as terminal-local var.
11875 (LOCAL_SELECTION): New macro.
11876 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11877 (symbol_to_x_atom): Remove gratuitous arg.
11878 (x_handle_selection_request, lisp_data_to_selection_data)
11879 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11880 (x_own_selection, x_get_local_selection, x_convert_selection):
11881 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11882 (some_frame_on_display): Delete unused function.
11883 (Fx_own_selection_internal, Fx_get_selection_internal)
11884 (Fx_disown_selection_internal, Fx_selection_owner_p)
11885 (Fx_selection_exists_p): New optional frame arg.
11886 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11887 (x_handle_selection_clear): Don't treat other terminals with the
11888 same keyboard specially. Use the terminal-local Vselection_alist.
11889 (x_clear_frame_selections): Use Frun_hook_with_args.
11890
11891 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11892
11893 * xterm.h: Add support for those atoms.
11894
e067f0c1
CY
118952011-05-26 Chong Yidong <cyd@stupidchicken.com>
11896
11897 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11898 (converted_selections, conversion_fail_tag): New global variables.
11899 (x_selection_request_lisp_error): Free the above.
11900 (x_get_local_selection): Remove unnecessary code.
11901 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11902 of converted selections stored in converted_selections.
11903 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11904 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11905 (x_convert_selection): New function.
11906 (x_handle_selection_event): Simplify.
11907 (x_get_foreign_selection): Don't ignore incoming requests while
11908 waiting for an answer; this will fail when we implement
11909 SAVE_TARGETS, and seems unnecessary anyway.
11910 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11911 (Vx_sent_selection_functions): Doc fix.
11912
0f4aebc0
LL
119132011-05-26 Leo Liu <sdl.web@gmail.com>
11914
11915 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11916
e61124cd
YM
119172011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11918
11919 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11920
11921 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11922 for fringe update if it has periodic bitmap.
ac389d0c 11923 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11924 and fringe_bitmap_periodic_p.
11925
11926 * fringe.c (get_fringe_bitmap_data): New function.
11927 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11928 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11929 row. Mark glyph row for fringe update if periodicity changed.
11930
11931 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11932 for fringe update unless it has periodic bitmap.
11933
f16d9837
KH
119342011-05-25 Kenichi Handa <handa@m17n.org>
11935
11936 * xdisp.c (get_next_display_element): Set correct it->face_id for
11937 a static composition.
11938
e1b90ef6
LL
119392011-05-24 Leo Liu <sdl.web@gmail.com>
11940
11941 * deps.mk (fns.o):
11942 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11943
11944 * fns.c (crypto_hash_function, Fsha1): New function.
11945 (Fmd5): Use crypto_hash_function.
11946 (syms_of_fns): Add Ssha1.
11947
7400048f
PE
119482011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11949
11950 * gnutls.c: Remove unused macros.
11951 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11952 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11953 Remove macros that are defined and never used.
11954 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11955
abb71cf4
CY
119562011-05-22 Chong Yidong <cyd@stupidchicken.com>
11957
11958 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11959 (Fx_get_selection_internal): Minor cleanup.
11960 (Fx_own_selection_internal): Rename arguments for consistency with
11961 select.el.
11962
6307db39
PE
119632011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11964
11965 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11966
f3d4e0a4
CY
119672011-05-22 Chong Yidong <cyd@stupidchicken.com>
11968
11969 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11970
4d8ade89
YM
119712011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11972
11973 * dispnew.c (scrolling_window): Don't exclude the case that the
11974 last enabled row in the desired matrix touches the bottom boundary.
11975
32078c8d
GM
119762011-05-21 Glenn Morris <rgm@gnu.org>
11977
11978 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11979 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11980 and add some more files.
32078c8d 11981
7285dc67
EZ
119822011-05-20 Eli Zaretskii <eliz@gnu.org>
11983
11984 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11985 report_file_error introduced by the change from 2011-05-07.
11986
89d1bd22
PE
119872011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11988
11989 * systime.h (Time): Define only if emacs is defined.
11990 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11991 where the include path doesn't have X11/X.h by default. See
11992 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11993
cd394be1 119942011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11995
11996 * composite.c (find_automatic_composition): Fix previous change.
11997
b9704ad9
GM
119982011-05-20 Glenn Morris <rgm@gnu.org>
11999
12000 * lisp.mk: New file, split from Makefile.in.
12001 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12002 (shortlisp): Remove.
12003 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12004
4a720484
GM
120052011-05-19 Glenn Morris <rgm@gnu.org>
12006
12007 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12008 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12009 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12010 (lisp): Set the order to that of loadup.el.
12011 (shortlisp): Make it a copy of $lisp.
12012 (SOME_MACHINE_LISP): Remove.
12013 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12014 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12015
a28d4396
KH
120162011-05-18 Kenichi Handa <handa@m17n.org>
12017
12018 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12019 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12020 (find_automatic_composition): Mostly rewrite for efficiency.
12021
a2b1fa8e
JB
120222011-05-18 Juanma Barranquero <lekktu@gmail.com>
12023
12024 * makefile.w32-in: Update dependencies.
12025
8e1f5610
CS
120262011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12027
12028 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12029 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12030
7025ee00 120312011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12032
cdfa6eab
PE
12033 Fix some integer overflow issues, such as string length overflow.
12034
06d6db33
PE
12035 * insdel.c (count_size_as_multibyte): Check for string overflow.
12036
2b4560a8
PE
12037 * character.c (lisp_string_width): Check for string overflow.
12038 Use EMACS_INT, not int, for string indexes and lengths; in
12039 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12040 the resulting string length overflows an EMACS_INT; instead,
12041 report a string overflow if no precision given. When checking for
12042 precision exhaustion, use a check that cannot possibly have
12043 integer overflow. (Bug#8675)
12044 * character.h (lisp_string_width): Adjust to new signature.
12045
cb93f9be
PE
12046 * alloc.c (string_overflow): New function.
12047 (Fmake_string): Use it. This doesn't change behavior, but saves
12048 a few bytes and will simplify future changes.
12049 * character.c (string_escape_byte8): Likewise.
12050 * lisp.h (string_overflow): New decl.
12051
1a1f3366
PE
12052 Fixups, following up to the user-interface timestamp change.
12053 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12054 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12055 * msdos.c (mouse_get_pos): Likewise.
12056 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12057 * w32gui.h (Time): Define by including "systime.h" rather than by
12058 declaring it ourselves. (Bug#8664)
12059
d4e3e4d3
PE
12060 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12061 * image.c (clear_image_cache): Likewise.
12062
f6a24d19
PE
12063 * term.c (term_mouse_position): Don't assume time_t wraparound.
12064
08dc5ae6
PE
12065 Be more systematic about user-interface timestamps.
12066 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12067 and sometimes 'EMACS_UINT', to represent these timestamps.
12068 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12069 This makes the code easier to follow, and makes it easier to catch
12070 integer overflow bugs such as Bug#8664.
12071 * frame.c (Fmouse_position, Fmouse_pixel_position):
12072 Use Time, not unsigned long, for user-interface timestamps.
12073 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12074 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12075 * keyboard.h (last_event_timestamp): Likewise.
12076 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12077 * menu.h (xmenu_show): Likewise.
12078 * term.c (term_mouse_position): Likewise.
12079 * termhooks.h (struct input_event.timestamp): Likewise.
12080 (struct terminal.mouse_position_hook): Likewise.
12081 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12082 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12083 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12084 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12085 what it was before.
12086 * menu.h, termhooks.h: Include "systime.h", for Time.
12087
8e55734a
PE
12088 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12089 Don't assume that the difference between two unsigned long values
12090 can fit into an integer. At this point, we know button_down_time
12091 <= event->timestamp, so the difference must be nonnegative, so
12092 there's no need to cast the result if double-click-time is
12093 nonnegative, as it should be; check that it's nonnegative, just in
12094 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12095 apart (about 25 days). (Bug#8664)
8e55734a 12096
841f1b75 12097 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12098 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12099
3e26f69c
PE
12100 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12101 that always fit in int. Use a sentinel instead of a counter, to
12102 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12103 * frame.h (struct frame): Use int for menu_bar_items_used
12104 instead of EMACS_INT, since it always fits in int.
3e26f69c 12105
5cc152c0
PE
12106 * menu.c (grow_menu_items): Check for int overflow.
12107
d89eb65e
PE
12108 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12109
5235bd3e
PE
12110 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12111 Before, the code was not consistent. These values cannot exceed
12112 2**31 - 1 so there's no need to make them unsigned.
12113 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12114 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12115 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12116 as modifiers.
12117 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12118
bc827e23
PE
12119 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12120 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12121 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12122 presumably because the widths might not match.
12123
78eb494e
PE
12124 * window.c (size_window): Avoid needless test at loop start.
12125
04f2d78b
CB
121262011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12127
12128 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12129
d2fc7e3d 121302011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12131
12132 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12133
d2fc7e3d 121342011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12135
12136 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12137 `width' to `bar_area_x' and `bar_area_width', respectively.
12138 (x_scroll_run): Take account of fringe background extension.
12139
04f2d78b
CB
12140 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12141 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12142 `bar_area_width', respectively.
12143 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12144 background extension.
12145
79b70037
GM
121462011-05-10 Jim Meyering <meyering@redhat.com>
12147
12148 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12149
2f142cc5
JB
121502011-05-10 Juanma Barranquero <lekktu@gmail.com>
12151
12152 * image.c (Finit_image_library): Return t for built-in image types,
12153 like pbm and xbm. (Bug#8640)
12154
57679c86
AS
121552011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12156
12157 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12158
888c9e86
EZ
121592011-05-07 Eli Zaretskii <eliz@gnu.org>
12160
b0512a1d
EZ
12161 * w32console.c (Fset_screen_color): Doc fix.
12162 (Fget_screen_color): New function.
12163 (syms_of_ntterm): Defsubr it.
12164
7285dc67
EZ
12165 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12166 unlink the temporary file if Fcall_process didn't create it in the
12167 first place.
12168 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12169 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12170 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12171 cue to call_process_cleanup not to close that handle.
12172
4d3fcc8e
BK
121732011-05-07 Ben Key <bkey76@gmail.com>
12174
12175 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12176 one of two shell specific rules, either bootstrap-temacs-CMD or
12177 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12178 to the previous implementation of the bootstrap-temacs rule.
12179 The bootstrap-temacs-CMD rule is similar to the previous
12180 implementation of the bootstrap-temacs rule except that it
12181 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12182 variable.
12183
12184 These changes, along with some changes to nt/configure.bat,
12185 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12186 earlier fix to add support for --cflags and --ldflags options
12187 that include quotes so that it works whether make uses cmd or
12188 sh as the shell.
12189
b4289b64
MA
121902011-05-06 Michael Albinus <michael.albinus@gmx.de>
12191
12192 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12193 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12194 is a constant.
12195 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12196 a string. Handle both cases.
12197 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12198 (Fdbus_register_method): Use Qinvalid_function.
12199
af4c0e28
JB
122002011-05-06 Juanma Barranquero <lekktu@gmail.com>
12201
12202 * makefile.w32-in: Update dependencies.
12203 (LISP_H): Add inttypes.h and stdin.h.
12204 (PROCESS_H): Add unistd.h.
12205
c51453d9
EZ
122062011-05-06 Eli Zaretskii <eliz@gnu.org>
12207
12208 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12209 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12210
8ff0ac3c 122112011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12212
4c4b566b
PE
12213 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12214
aab2b9b5
PE
12215 * term.c (vfatal): Remove stray call to va_end.
12216 It's not needed and the C Standard doesn't allow it here anyway.
12217
c378da0b
PE
12218 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12219 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12220
288b08c7
PE
12221 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12222 bytes.
12223
e3601888
PE
12224 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12225
db6c0e74
PE
12226 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12227
dd5963ea
PE
12228 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12229
88c9450f
PE
12230 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12231
2f9442b8
PE
12232 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12233
c032b5f8
PE
12234 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12235 * charset.c (Fdefine_charset_internal): Don't initialize
12236 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12237 32-bit int (Bug#8600).
a108c10b
PE
12238
12239 * lread.c (read_integer): Be more consistent with string-to-number.
12240 Use string_to_number to do the actual conversion; this avoids
12241 rounding errors and fixes some other screwups. Without this fix,
12242 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12243 (digit_to_number): Move earlier, for benefit of read_integer.
12244 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12245 not a digit in any supported base. (Bug#8602)
a108c10b 12246
ad5f9eea
PE
12247 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12248
aec1708a
PE
12249 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12250 to match comment at start of function. This also removes a
12251 GCC warning about overflow in a 32+64-bit port.
12252
47be4ab5
PE
12253 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12254
371cac43
PE
12255 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12256 Reported by Stefan Monnier in
12257 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12258 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12259 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12260
d01a7826
PE
12261 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12262 (EMACS_UINTPTR): Likewise, with uintptr_t.
12263
7fd47d5c
PE
12264 * lisp.h: Prefer 64-bit EMACS_INT if available.
12265 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12266 on 32-bit hosts that have 64-bit int, so that they can access
12267 large files.
122b0c86
PE
12268 However, temporarily disable this change unless the temporary
12269 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12270
8727937b
PE
12271 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12272
8ac068ac
PE
12273 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12274 This removes an assumption that EMACS_INT and long are the same
12275 width as pointers. The assumption is true for Emacs porting targets
12276 now, but we want to make other targets possible.
12277 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12278 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12279 In the rest of the code, change types of integers that hold casted
12280 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12281 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12282 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12283 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12284 No need to cast type when ORing.
12285 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12286 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12287 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12288 assume EMACS_INT is the same width as char *.
12289 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12290 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12291 Remove no-longer-needed casts.
12292 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12293 (xg_tool_bar_help_callback, xg_make_tool_item):
12294 Use EMACS_INTPTR to hold an integer
12295 that will be cast to void *; this can avoid a GCC warning
12296 if EMACS_INT is not the same width as void *.
12297 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12298 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12299 (current_message_1, set_message_1):
12300 Use a local to convert to proper width without a cast.
12301 * xmenu.c (dialog_selection_callback): Likewise.
12302
ede49d71
PE
12303 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12304 Also, don't assume VALBITS / RAND_BITS is less than 5,
12305 and don't rely on undefined behavior when shifting a 1 left into
12306 the sign bit.
12307 * lisp.h (get_random): Change signature to match.
12308
2f30ecd0
PE
12309 * lread.c (hash_string): Use size_t, not int, for hash computation.
12310 Normally we prefer signed values; but hashing is special, because
12311 it's better to use unsigned division on hash table sizes so that
12312 the remainder is nonnegative. Also, size_t is the natural width
12313 for hashing into memory. The previous code used 'int', which doesn't
12314 retain enough info to hash well into very large tables.
12315 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12316
2a866e7b
PE
12317 * dbusbind.c: Don't possibly lose pointer info when converting.
12318 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12319 Use XPNTR rather than XHASH, so that the high-order bits of
12320 the pointer aren't lost when converting through void *.
12321
51639eac
PE
12322 * eval.c (Fautoload): Don't double-shift a pointer.
12323
92394119
PE
12324 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12325
dbdb9a7c
JB
123262011-05-06 Juanma Barranquero <lekktu@gmail.com>
12327
12328 * gnutls.c (DEF_GNUTLS_FN):
12329 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12330
db7a0b4f
AS
123312011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12332
12333 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12334 marker. (Bug#8610)
12335
cd394be1 123362011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12337
12338 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12339 New version that can reserve upto 2GB of heap space.
12340
f7ff1b0f 123412011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12342
12343 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12344
639c109b
TZ
123452011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12346
12347 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12348 `gnutls_certificate_set_x509_key_file'.
12349
d2127135
JB
123502011-05-05 Juanma Barranquero <lekktu@gmail.com>
12351
12352 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12353 Update dependencies.
12354
e968f4f3
JB
123552011-05-04 Juanma Barranquero <lekktu@gmail.com>
12356
12357 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12358 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12359 Remove unused parameter `fildes'.
12360 * process.c (read_process_output, send_process): Don't pass it.
12361
84d358f0
JB
123622011-05-04 Juanma Barranquero <lekktu@gmail.com>
12363
12364 Fix previous change: the library cache is defined in w32.c.
12365 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12366 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12367
0898ca10
JB
123682011-05-04 Juanma Barranquero <lekktu@gmail.com>
12369
12370 Implement dynamic loading of GnuTLS on Windows.
12371
12372 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12373 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12374 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12375 Declare.
12376
12377 * gnutls.c (Qgnutls_dll): Define.
12378 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12379 (gnutls_*): Declare function pointers.
12380 (init_gnutls_functions): New function to initialize function pointers.
12381 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12382 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12383 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12384 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12385 (emacs_gnutls_write, emacs_gnutls_read)
12386 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12387 (Fgnutls_available_p): New function.
12388 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12389 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12390 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12391
12392 * image.c: Include w32.h.
12393 (Vimage_type_cache): Delete.
12394 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12395 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12396 (w32_delayed_load): Move to w32.c.
12397
12398 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12399
12400 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12401 (w32_delayed_load): Move from image.c. When loading a library, record
12402 its filename in the :loaded-from property of the library id.
12403 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12404 Initialize and staticpro them.
12405 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12406
12407 * process.c: Include lisp.h before w32.h, not after.
12408 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12409 instead of gnutls_record_check_pending.
12410
12411 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12412
ff4de4aa
TZ
124132011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12414
12415 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12416 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12417 as passed in.
12418
abe95abb
JD
124192011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12420
12421 * xterm.c (x_set_frame_alpha): Do not set property on anything
12422 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12423
e16e55d4
JB
124242011-05-02 Juanma Barranquero <lekktu@gmail.com>
12425
12426 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12427
bafcf6a5
JB
124282011-05-02 Juanma Barranquero <lekktu@gmail.com>
12429
12430 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12431 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12432 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12433 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12434 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12435 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12436 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12437 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12438 (Qgnutls_bootprop_callbacks_verify): Make static.
12439
e7a6747f
AS
124402011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12441
19ed11ba
AS
12442 * callproc.c: Indentation fixup.
12443
e7a6747f 12444 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12445 (wait_for_termination, interruptible_wait_for_termination):
12446 Move after wait_for_termination_1.
e7a6747f 12447
1ef14cb4
LMI
124482011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12449
12450 * sysdep.c (interruptible_wait_for_termination): New function
12451 which is like wait_for_termination, but allows keyboard
12452 interruptions.
12453
12454 * callproc.c (Fcall_process): Add (:file "file") as an option for
12455 the STDOUT buffer.
12456 (Fcall_process_region): Ditto.
12457
330d880c
EZ
124582011-04-30 Eli Zaretskii <eliz@gnu.org>
12459
8db90b73
EZ
12460 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12461 rather than `XVECTOR (FOO)->size'.
12462
330d880c
EZ
12463 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12464 inttypes.h, as a gnulib replacement is used if it not available in
12465 system headers.
12466
15cbd324
EZ
124672011-04-21 Eli Zaretskii <eliz@gnu.org>
12468
12469 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12470 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12471 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12472
12473 * coding.c (coding_alloc_by_realloc): Error out if destination
12474 will grow beyond MOST_POSITIVE_FIXNUM.
12475 (decode_coding_emacs_mule): Abort if there isn't enough place in
12476 charbuf for the composition carryover bytes. Reserve an extra
12477 space for up to 2 characters produced in a loop.
12478 (decode_coding_iso_2022): Abort if there isn't enough place in
12479 charbuf for the composition carryover bytes.
12480
124812011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12482
ae940cca
EZ
12483 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12484 aborting when %lld or %lll format is passed.
12485 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12486 %llo or %llx format is passed. (Bug#8545)
12487
03ab8921
EZ
12488 * window.c (window_scroll_line_based): Use a marker instead of
12489 simple variables to record original value of point. (Bug#7952)
12490
afda1437
EZ
12491 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12492 produced by %s or %c overflows available buffer space. (Bug#8545)
12493
f76dee0c
PE
124942011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12495
12496 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12497 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12498
fdc5744d
JB
124992011-04-28 Juanma Barranquero <lekktu@gmail.com>
12500
12501 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12502
638f053a
JB
125032011-04-28 Juanma Barranquero <lekktu@gmail.com>
12504
12505 * keyboard.c (Qdelayed_warnings_hook): Define.
12506 (command_loop_1): Run `delayed-warnings-hook'
12507 if Vdelayed_warnings_list is non-nil.
12508 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12509 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12510
d178f871
EZ
125112011-04-28 Eli Zaretskii <eliz@gnu.org>
12512
12513 * doprnt.c (doprnt): Don't return value smaller than the buffer
12514 size if the message was truncated. (Bug#8545).
12515
b124fd93
JB
125162011-04-28 Juanma Barranquero <lekktu@gmail.com>
12517
12518 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12519 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12520
e810457d
PE
125212011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12522
12523 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12524
ea51cceb
JB
125252011-04-27 Juanma Barranquero <lekktu@gmail.com>
12526
12527 * makefile.w32-in: Update dependencies.
12528
94dcfacf
EZ
125292011-04-27 Eli Zaretskii <eliz@gnu.org>
12530
12531 Improve `doprnt' and its usage. (Bug#8545)
12532 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12533 `format_end'. Remove support for %l as a conversion specifier.
12534 Don't use xrealloc. Improve diagnostics when the %l size modifier
12535 is used. Update the commentary.
12536
12537 * eval.c (verror): Simplify calculation of size_t.
12538
12539 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12540 messages.
12541
f61f41d7
PE
125422011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12543
12544 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12545 change.
12546
96fb4434
PE
125472011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12548
12549 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12550 This makes this file independent of the recent pseudovector change.
12551
671875da 125522011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12553
69e9b5a3
PE
12554 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12555
b5f869a7 12556 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12557 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12558 Remove unused local.
c8926152 12559 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12560
841a1577 12561 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12562 GCC 4.6.0 optimizes based on type-based alias analysis.
12563 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12564 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12565 != &v->size, and therefore "v->size = 1; b->size = 2; return
12566 v->size;" must therefore return 1. This assumption is incorrect
12567 for Emacs, since it type-puns struct Lisp_Vector * with many other
12568 types. To fix this problem, this patch adds a new type struct
f904488f 12569 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12570 and pseudovectors, and helps optimizing compilers not get fooled
12571 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12572 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12573 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12574 the size member.
eab3844f
PE
12575 (XSETPVECTYPE): Rewrite in terms of new macro.
12576 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12577 This is a bit clearer, and further avoids the possibility of
12578 undesirable aliasing.
12579 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12580 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12581 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12582 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12583 (ASIZE): Now uses header.size rather than size.
12584 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12585 to avoid the hassle of writing XVECTOR (foo)->header.size.
12586 (struct vectorlike_header): New type.
eab3844f
PE
12587 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12588 object, to help avoid aliasing.
12589 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12590 (SUBRP): Likewise, since Lisp_Subr is a special case.
12591 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12592 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12593 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12594 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12595 changed to be "header.size" and "header.next".
12596 * buffer.h (struct buffer): Likewise.
12597 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12598 * frame.h (struct frame): Likewise.
12599 * process.h (struct Lisp_Process): Likewise.
12600 * termhooks.h (struct terminal): Likewise.
12601 * window.c (struct save_window_data, struct saved_window): Likewise.
12602 * window.h (struct window): Likewise.
12603 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12604 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12605 * buffer.c (init_buffer_once): Likewise.
12606 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12607 special case.
12608 * process.c (Fformat_network_address): Use local var for size,
12609 for brevity.
12610
0df1eac5
PE
12611 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12612
847ab9d1 12613 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12614 * data.c (atof): Remove decl; no longer used or needed.
12615 (digit_to_number): Move to lread.c.
12616 (Fstring_to_number): Use new string_to_number function, to be
12617 consistent with how the Lisp reader treats infinities and NaNs.
12618 Do not assume that floating-point numbers represent EMACS_INT
12619 without losing information; this is not true on most 64-bit hosts.
12620 Avoid double-rounding errors, by insisting on integers when
12621 parsing non-base-10 numbers, as the documentation specifies.
12622 * lisp.h (string_to_number): New decl, replacing ...
12623 (isfloat_string): Remove.
bc0a5c13 12624 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12625 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12626 appears to have been a coding error. Similarly, do not accept
12627 strings like +-1e0 as floating point numbers. Do not report
12628 overflow for integer overflows unless the base is not 10 which
12629 means we have no simple and reliable way to continue.
12630 Break out the floating-point parsing into a new
12631 function string_to_number, so that Fstring_to_number parses
12632 floating point numbers consistently with the Lisp reader.
04f2d78b 12633 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12634 (E_CHAR, EXP_INT): Remove, replacing with ...
12635 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12636 (string_to_number): New function, replacing isfloat_string.
12637 This function checks for valid syntax and produces the resulting
12638 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12639 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12640 so that overflow for non-base-10 numbers is reported only when
12641 there's no portable and simple way to convert to floating point.
452f4150 12642
67769ffc
PE
12643 * textprop.c (set_text_properties_1): Rewrite for clarity,
12644 and to avoid GCC warning about integer overflow.
12645
c20db43f
PE
12646 * intervals.h (struct interval): Use EMACS_INT for members
12647 where EMACS_UINT might cause problems. See
12648 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12649 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12650 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12651 All uses changed.
37aa2f85
PE
12652 (offset_intervals): Tell GCC not to worry about length overflow
12653 when negating a negative length.
c20db43f 12654
2538aa2f
PE
12655 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12656 (overrun_check_free): Likewise.
12657
f2d3008d
PE
12658 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12659 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12660 word size.
12661
ec8df744
PE
12662 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12663 (gnutls_make_error): Rename local to avoid shadowing.
12664 (gnutls_emacs_global_deinit): ifdef out; not used.
12665 (Fgnutls_boot): Use const for pointer to readonly storage.
12666 Comment out unused local. Fix pointer signedness problems.
12667
640ee02d
PE
12668 * lread.c (openp): Don't stuff size_t into an 'int'.
12669 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12670 about possible signed overflow.
12671
6048fb2a
PE
12672 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12673 (GDK_KEY_g): Don't define if already defined.
12674 (xg_prepare_tooltip): Avoid pointer signedness problem.
12675 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12676
fa3c87e1
PE
12677 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12678 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12679
2172544b
PE
12680 * xfns.c (Fx_window_property): Simplify a bit,
12681 to make a bit faster and to avoid GCC 4.6.0 warning.
12682 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12683
9b821a21
PE
12684 * fns.c (internal_equal): Don't assume size_t fits in int.
12685
3c616cfa
PE
12686 * alloc.c (compact_small_strings): Tighten assertion a little.
12687
c2982e87
PE
12688 Replace pEd with more-general pI, and fix some printf arg casts.
12689 * lisp.h (pI): New macro, generalizing old pEd macro to other
12690 conversion specifiers. For example, use "...%"pI"d..." rather
12691 than "...%"pEd"...".
12692 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12693 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12694 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12695 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12696 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12697 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12698 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12699 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12700 64-bit hosts.
12701 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12702 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12703 * print.c (safe_debug_print, print_object): Likewise.
12704 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12705 to int.
6f04d126
PE
12706 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12707 avoiding the 0 flag, which is not portable.
c2982e87
PE
12708 * process.c (Fmake_network_process): Use pI to avoid cast.
12709 * region-cache.c (pp_cache): Likewise.
12710 * xdisp.c (decode_mode_spec): Likewise.
12711 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12712 behavior on 64-bit hosts with printf arg.
6f04d126 12713 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12714 (x_stop_queuing_selection_requests): Likewise.
12715 (x_get_window_property): Don't truncate byte count to an 'int'
12716 when tracing.
0b432f21 12717
5e073ec7
PE
12718 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12719 here, since it parses constructs like leading '-' and spaces,
12720 which are not wanted; and it overflows with large numbers.
12721 Instead, simply match F[0-9]+, which is what is wanted anyway.
12722
36372bf9
PE
12723 * alloc.c: Remove unportable assumptions about struct layout.
12724 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12725 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12726 (allocate_vectorlike, make_pure_vector): Use the new macros,
12727 plus offsetof, to remove unportable assumptions about struct layout.
12728 These assumptions hold on all porting targets that I know of, but
12729 they are not guaranteed, they're easy to remove, and removing them
12730 makes further changes easier.
12731
0b432f21
PE
12732 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12733 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12734 (string_overrun_cookie): Now const. Use initializers that
12735 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12736 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12737 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12738 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12739 multiple of sizeof (EMACS_INT); it need not be, if
12740 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12741 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12742
895009e1
JB
127432011-04-26 Juanma Barranquero <lekktu@gmail.com>
12744
12745 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12746
6a7a1b0b
TZ
127472011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12748
12749 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12750 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12751 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12752
841a1577 127532011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12754
12755 * lisp.h (Qdebug): List symbol.
895009e1 12756 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12757 * keyboard.c (debug-on-event): New variable.
12758 (handle_user_signal): Break into debugger when debug-on-event
12759 matches the current signal symbol.
12760
f2d3ba6f
DN
127612011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12762
12763 * alloc.c (check_sblock, check_string_bytes)
12764 (check_string_free_list): Convert to standard C.
12765
42ce4c63
TZ
127662011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12767
12768 * w32.c (emacs_gnutls_push): Fix typo.
12769
825cd63c
EZ
127702011-04-25 Eli Zaretskii <eliz@gnu.org>
12771
fb11d64d
EZ
12772 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12773 "cast to pointer from integer of different size".
12774
825cd63c
EZ
12775 Improve doprnt and its use in verror. (Bug#8545)
12776 * doprnt.c (doprnt): Document the set of format control sequences
12777 supported by the function. Use SAFE_ALLOCA instead of always
12778 using `alloca'.
12779
12780 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12781 is one byte too soon. Don't use xrealloc; instead xfree and
12782 xmalloc anew.
12783
e061a11b
TZ
127842011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12785
12786 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12787 callbacks stage.
12788
12789 * gnutls.c: Renamed global_initialized to
12790 gnutls_global_initialized. Added internals for the
12791 :verify-hostname-error, :verify-error, and :verify-flags
12792 parameters of `gnutls-boot' and documented those parameters in the
12793 docstring. Start callback support.
9173deec
JB
12794 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12795 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12796 on error. Return error code.
e061a11b
TZ
12797 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12798 (emacs_gnutls_read): Likewise.
12799 (Fgnutls_boot): Return handshake error code.
12800 (emacs_gnutls_handle_error): New function.
12801 (wsaerror_to_errno): Likewise.
12802
12803 * w32.h (emacs_gnutls_pull): Add prototype.
12804 (emacs_gnutls_push): Likewise.
12805
12806 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12807 (emacs_gnutls_push): Likewise.
12808
128092011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12810
12811 * process.c (wait_reading_process_output): Check if GnuTLS
12812 buffered some data internally if no FDs are set for TLS
12813 connections.
12814
12815 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12816 (LIBS): Link to USER_LIBS.
12817 ($(BLD)/gnutls.$(0)): New target.
12818
fa6996bc
EZ
128192011-04-24 Eli Zaretskii <eliz@gnu.org>
12820
eb35682e
EZ
12821 * xdisp.c (handle_single_display_spec): Rename the
12822 display_replaced_before_p argument into display_replaced_p, to
12823 make it consistent with the commentary. Fix typos in the
12824 commentary.
12825
e2ad650c
EZ
12826 * textprop.c (syms_of_textprop): Remove dead code.
12827 (copy_text_properties): Delete obsolete commentary about an
12828 interface that was deleted long ago. Fix typos in the description
12829 of arguments.
12830
1b2de274
EZ
12831 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12832 to changes in oldXMenu/XMenu.h from 2011-04-16.
12833 <menu_help_message, prev_menu_help_message>: Constify.
12834 (IT_menu_make_room): menu->help_text is now `const char **';
12835 adjust.
12836
12837 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12838 to changes in oldXMenu/XMenu.h from 2011-04-16.
12839 (struct XMenu): Declare `help_text' `const char **'.
12840
12841 * xfaces.c <Qunspecified>: Make extern again.
12842
12843 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12844 required by POSIX.
1b2de274 12845
762b15be
EZ
12846 * doc.c (get_doc_string): Improve the format passed to `error'.
12847
12848 * doprnt.c (doprnt): Improve commentary.
12849
12850 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12851
12852 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12853 them with etags.
12854
f1052e5d
EZ
12855 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12856 changes in globals.h immediately force recompilation.
762b15be
EZ
12857 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12858 $(CURDIR)/s/ms-w32.h.
12859 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12860
fa6996bc
EZ
12861 * character.c (Fchar_direction): Function deleted.
12862 (syms_of_character): Don't defsubr it.
12863 <char-direction-table>: Deleted.
12864
e6c3da20
EZ
128652011-04-23 Eli Zaretskii <eliz@gnu.org>
12866
12867 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12868 * doprnt.c: Include limits.h.
12869 (SIZE_MAX): New macro.
04f2d78b
CB
12870 (doprnt): Return a size_t value. 2nd arg is now size_t.
12871 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12872 Improve overflow protection. Support `l' modifier for integer
12873 conversions. Support %l conversion. Don't assume an EMACS_INT
12874 argument for integer conversions and for %c.
12875
12876 * lisp.h (doprnt): Restore prototype.
12877
12878 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12879 $(SRC)/character.h.
12880
12881 * Makefile.in (base_obj): Add back doprnt.o.
12882
12883 * deps.mk (doprnt.o): Add back prerequisites.
12884 (callint.o): Depend on character.h.
12885
12886 * eval.c (internal_lisp_condition_case): Include the handler
12887 representation in the error message.
12888 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12889 when breaking from the loop.
12890
12891 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12892
12893 * callint.c (Fcall_interactively): When displaying error message
12894 about invalid control letter, pass the character's codepoint, not
12895 a pointer to its multibyte form. Improve display of the character
12896 in octal and display also its hex code.
12897
12898 * character.c (char_string): Use %x to display the (unsigned)
12899 codepoint of an invalid character, to avoid displaying a bogus
12900 negative value.
12901
12902 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12903 `error', not SYMBOL_NAME itself.
12904
12905 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12906 character arguments to `error'.
12907
12908 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12909 to `error' in error message about FINAL_CHAR argument. Make sure
12910 FINAL_CHAR is a character, and use %c when it is passed as
12911 argument to `error'.
12912
4ffd0d6b 129132011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12914
12915 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12916
12917 * w32.c: Include <time.h>.
12918 (sys_localtime): New function.
12919
4ffd0d6b 129202011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12921
12922 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12923
4ffd0d6b 12924 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12925
4ffd0d6b 129262011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12927
4ffd0d6b
GM
12928 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12929 zombies (Bug#8467).
aac0c6e3 12930
04c56954
EZ
129312011-04-19 Eli Zaretskii <eliz@gnu.org>
12932
12933 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12934 gl_state.e_property when gl_state.object is Qt.
12935
12936 * insdel.c (make_gap_larger): Remove limitation of buffer size
12937 to <= INT_MAX.
12938
16a43933
CY
129392011-04-18 Chong Yidong <cyd@stupidchicken.com>
12940
12941 * xdisp.c (lookup_glyphless_char_display)
12942 (produce_glyphless_glyph): Handle cons cell entry in
12943 glyphless-char-display.
12944 (Vglyphless_char_display): Document it.
12945
12946 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12947 glyphless-char-display.
12948
4581706e
CY
129492011-04-17 Chong Yidong <cyd@stupidchicken.com>
12950
12951 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12952
12953 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12954
12955 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12956 definition for no-X builds.
12957
4887c6e2 129582011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12959
fd35b6f9
PE
12960 Static checks with GCC 4.6.0 and non-default toolkits.
12961
5c1ccb01
PE
12962 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12963
006c5daa
PE
12964 * process.c (keyboard_bit_set): Define only if SIGIO.
12965 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12966 (send_process): Repair possible setjmp clobbering.
12967
efc736d3
PE
12968 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12969
4e2fe2e6
PE
12970 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12971
f97334a2
PE
12972 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12973
4e75f29d
PE
12974 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12975 Define only if needed.
12976
90efadd1
PE
12977 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12978 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12979 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12980
3c647824
PE
12981 * dispextern.h (struct redisplay_interface): Rename param
12982 to avoid shadowing.
e264f262 12983 * termhooks.h (struct terminal): Likewise.
761383f4 12984 * xterm.c (xembed_send_message): Likewise.
3c647824 12985
b58c5c4a
PE
12986 * insdel.c (make_gap_smaller): Define only if
12987 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12988
cad59032
PE
12989 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12990 it.
12991
c339dc2e
PE
12992 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12993 so that we aren't warned about unused symbols.
12994
91a3e27b
PE
12995 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12996
399c71d3 12997 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12998
8ffc96f5
PE
12999 * xfns.c (x_real_positions): Mark locals as initialized.
13000
eef9bc79
PE
13001 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13002
098db9dd
PE
13003 * xterm.c: Fix problems found by static analysis with other toolkits.
13004 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13005 (x_dispatch_event): Declare static if USE_GTK, and
13006 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13007 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13008 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13009 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13010 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13011
eb18f6cc
PE
13012 * xmenu.c (menu_help_callback): Pointer type fixes.
13013 Use const pointers when pointing at readonly data. Avoid pointer
13014 signedness clashes.
13015 (FALSE): Remove unused macro.
13016 (update_frame_menubar): Remove unused decl.
13017
1fe72bf8
PE
13018 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13019
60d9e1db
PE
13020 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13021 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13022 (single_menu_item): Rename local to avoid shadowing.
13023
39261c26
PE
13024 * keyboard.c (make_lispy_event): Remove unused local var.
13025
018c5e19
PE
13026 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13027 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13028
63d2b86e
PE
13029 * bitmaps: Change bitmaps from unsigned char back to the X11
13030 compatible char. Avoid the old compiler warnings about
13031 out-of-range initializers by using, for example, '\xab' rather
13032 than 0xab.
13033
aefd87e1
PE
13034 * xgselect.c (xgselect_initialize): Check vs interface
13035 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13036
bf501fb9
PE
13037 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13038
e9829fdf
PE
13039 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13040 to read-only memory.
13041
1086c095
PE
13042 * fns.c (vector): Remove; this old hack is no longer needed.
13043
2baccd04 13044 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13045 Remove unused var.
dde42981 13046 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13047
72391843 13048 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13049
436c16df 13050 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13051 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13052 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13053
92bb796d 13054 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13055 (x_term_init): Remove local to avoid shadowing.
92bb796d 13056
764430a3 13057 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13058
13059 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13060 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13061
d1dfb56c
EZ
130622011-04-16 Eli Zaretskii <eliz@gnu.org>
13063
c4354cb4
EZ
13064 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13065
d1dfb56c
EZ
13066 Fix regex.c, syntax.c and friends for buffers > 2GB.
13067 * syntax.h (struct gl_state_s): Declare character position members
13068 EMACS_INT.
13069
13070 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13071
04f2d78b
CB
13072 * textprop.c (verify_interval_modification, interval_of):
13073 Declare arguments EMACS_INT.
d1dfb56c
EZ
13074
13075 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13076 EMACS_INT.
13077
13078 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13079
13080 * indent.c (Fvertical_motion): Local variable it_start is now
13081 EMACS_INT.
13082
13083 * regex.c (re_match, re_match_2, re_match_2_internal)
13084 (bcmp_translate, regcomp, regexec, print_double_string)
13085 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13086 (re_compile_pattern, re_exec): Declare arguments and local
13087 variables `size_t' and `ssize_t' and return values `regoff_t', as
13088 appropriate.
13089 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13090 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13091 <compile_stack_type>: `size' and `avail' are now `size_t'.
13092
13093 * regex.h <regoff_t>: Use ssize_t, not int.
13094 (re_search, re_search_2, re_match, re_match_2): Arguments that
13095 specify buffer/string position and length are now ssize_t and
13096 size_t. Return type is regoff_t.
13097
613052cd
BK
130982011-04-16 Ben Key <bkey76@gmail.com>
13099
13100 * nsfont.m: Fixed bugs in ns_get_family and
13101 ns_descriptor_to_entity that were caused by using free to
13102 deallocate memory blocks that were allocated by xmalloc (via
13103 xstrdup). This caused Emacs to crash when compiled with
13104 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13105 --enable-checking=xmallocoverrun). xfree is now used to
13106 deallocate these memory blocks.
13107
4170f62f 131082011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13109
71b41406
PE
13110 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13111
9587a89d
PE
13112 emacs_write: Accept and return EMACS_INT for sizes.
13113 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13114 et seq.
13115 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13116 Accept and return EMACS_INT.
13117 (emacs_gnutls_write): Return the number of bytes written on
13118 partial writes.
13119 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13120 (emacs_read, emacs_write): Remove check for negative size, as the
13121 Emacs source code has been audited now.
9587a89d
PE
13122 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13123 (emacs_read, emacs_write): Use it.
273a5f82
PE
13124 * process.c (send_process): Adjust to the new signatures of
13125 emacs_write and emacs_gnutls_write. Do not attempt to store
13126 a byte offset into an 'int'; it might overflow.
9587a89d 13127 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13128
3e047f51
PE
13129 * sound.c: Don't assume sizes fit in 'int'.
13130 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13131 Return EMACS_INT, not int.
3e047f51 13132 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13133 Accept EMACS_INT, not int.
13134 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13135 record read return values.
13136
cc39a9db
BK
131372011-04-15 Ben Key <bkey76@gmail.com>
13138
c9d0ec6d
JB
13139 * keyboard.c (Qundefined): Don't declare static since it is used
13140 in nsfns.m.
13141 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13142 static since they are used in nsfont.m.
cc39a9db 13143
6c60eb9f
SM
131442011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13145
13146 * process.c (Qprocessp): Don't declare static.
13147 * lisp.h (Qprocessp): Declare again.
13148
7990b61a
JB
131492011-04-15 Juanma Barranquero <lekktu@gmail.com>
13150
13151 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13152
5d4cb038
PE
131532011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13154
8bd7b830 13155 Improve C-level modularity by making more things 'static'.
cd64ea1d 13156
e3b27b31
PE
13157 Don't publish debugger-only interfaces to other modules.
13158 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13159 (verify_bytepos, count_markers): Move decls to the only modules
13160 that need them.
13161 * region-cache.h (pp_cache): Likewise.
13162 * window.h (check_all_windows): Likewise.
13163 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13164
5d4cb038
PE
13165 * sysdep.c (croak): Now static, if
13166 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13167 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13168
13169 * alloc.c (refill_memory_reserve): Now static if
13170 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13171 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13172
e87b6180
PE
13173 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13174 Define only if USE_LUCID.
13175
ac64929e
PE
13176 * xrdb.c (x_customization_string, x_rm_string): Now static.
13177
6f37259d
PE
13178 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13179 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13180
1683e3ab
PE
13181 * xdisp.c (draw_row_with_mouse_face): Now static.
13182 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13183
de9c2632
PE
13184 * window.h (check_all_windows): Mark externally visible.
13185
2b96acb7
PE
13186 * window.c (window_deletion_count): Now static.
13187
13188 * undo.c: Make symbols static if they're not exported.
13189 (last_undo_buffer, last_boundary_position, pending_boundary):
13190 Now static.
13191
50436f33
PE
13192 * textprop.c (interval_insert_behind_hooks): Now static.
13193 (interval_insert_in_front_hooks): Likewise.
13194
64520e5c
PE
13195 * term.c: Make symbols static if they're not exported.
13196 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13197 (max_frame_lines, tty_set_terminal_modes):
13198 (tty_reset_terminal_modes, tty_turn_off_highlight):
13199 (get_tty_terminal): Now static.
13200 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13201 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13202 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13203 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13204 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13205
1fa53021
PE
13206 * sysdep.c: Make symbols static if they're not exported.
13207 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13208 Now static.
13209 (sigprocmask_set, full_mask): Remove; unused.
13210 (wait_debugging): Mark as visible.
13211 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13212 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13213
d4b43b22
PE
13214 * syntax.c (syntax_temp): Define only if !__GNUC__.
13215
b7c513d0
PE
13216 * sound.c (current_sound_device, current_sound): Now static.
13217
989b29ad
PE
13218 * search.c (searchbufs, searchbuf_head): Now static.
13219
13a55a78
PE
13220 * scroll.c (scroll_cost): Remove; unused.
13221 * dispextern.h (scroll_cost): Remove decl.
13222
de68a1fc
PE
13223 * region-cache.h (pp_cache): Mark as externally visible.
13224
40ccffa6
PE
13225 * process.c: Make symbols static if they're not exported.
13226 (process_tick, update_tick, create_process, chan_process):
13227 (Vprocess_alist, proc_buffered_char, datagram_access):
13228 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13229 (deactivate_process): Mark defn as static, as well as decl.
13230 * lisp.h (create_process): Remove decl.
13231 * process.h (chan_process, Vprocess_alist): Remove decls.
13232
ad64fc97
PE
13233 * print.c: Make symbols static if they're not exported.
13234 (print_depth, new_backquote_output, being_printed, print_buffer):
13235 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13236 (print_interval, print_number_index, initial_stderr_stream):
13237 Now static.
13238 * lisp.h (Fprinc): Remove decl.
13239 (debug_output_compilation_hack): Mark as externally visible.
13240
adddb265
PE
13241 * sysdep.c (croak): Move decl from here to syssignal.h.
13242 * syssignal.h (croak): Put it here, so the API can be checked when
13243 'croak' is called from dissociate_if_controlling_tty.
13244
1717ede2
PE
13245 * minibuf.c: Make symbols static if they're not exported.
13246 (minibuf_save_list, choose_minibuf_frame): Now static.
13247 * lisp.h (choose_minibuf_frame): Remove decl.
13248
fa5fb2bc
PE
13249 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13250
1e3890d1
PE
13251 * lread.c: Make symbols static if they're not exported.
13252 (read_objects, initial_obarray, oblookup_last_bucket_number):
13253 Now static.
13254 (make_symbol): Remove; unused.
13255 * lisp.h (initial_obarray, make_symbol): Remove decls.
13256
8a1414fa
PE
13257 * keyboard.c: Make symbols static if they're not exported.
13258 (single_kboard, recent_keys_index, total_keys, recent_keys):
13259 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13260 (this_single_command_key_start, echoing, last_auto_save):
13261 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13262 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13263 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13264 (Vlispy_mouse_stem, double_click_count):
13265 Now static.
13266 (force_auto_save_soon): Define only if SIGDANGER.
13267 (ignore_mouse_drag_p): Now static if
13268 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13269 (print_help): Remove; unused.
13270 (stop_character, last_timer_event): Mark as externally visible.
13271 * keyboard.h (ignore_mouse_drag_p): Declare only if
13272 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13273 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13274 * lisp.h (echoing): Remove decl.
13275 (force_auto_save_soon): Declare only if SIGDANGER.
13276 * xdisp.c (redisplay_window): Simplify code, to make it more
13277 obvious that ignore_mouse_drag_p is not accessed if !defined
13278 USE_GTK && !defined HAVE_NS.
13279
93ea6e8f
PE
13280 * intervals.c: Make symbols static if they're not exported.
13281 (merge_properties_sticky, merge_interval_right, delete_interval):
13282 Now static.
13283 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13284
77382fcc
PE
13285 * insdel.c: Make symbols static if they're not exported.
13286 However, leave prepare_to_modify_buffer alone. It's never
13287 called from outside this function, but that appears to be a bug.
13288 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13289 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13290 (adjust_after_replace_noundo): Remove; unused.
13291 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13292 (signal_before_change): Remove decls.
77382fcc 13293
9306c32e
PE
13294 * indent.c (val_compute_motion, val_vmotion): Now static.
13295
cd44d2eb
PE
13296 * image.c: Make symbols static if they're not exported.
13297 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13298 if USE_GTK.
13299 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13300 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13301
ad9a7a06
PE
13302 * fringe.c (standard_bitmaps): Now static.
13303 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13304
81626931
PE
13305 * frame.c: Make symbols static if they're not exported.
13306 (x_report_frame_params, make_terminal_frame): Now static.
13307 (get_frame_param): Now static, unless HAVE_NS.
13308 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13309 (x_get_resource_string): Remove; not used.
13310 * frame.h (make_terminal_frame, x_report_frame_params):
13311 (x_get_resource_string); Remove decls.
13312 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13313 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13314
239f9db9
PE
13315 * font.c, fontset.c: Make symbols static if they're not exported.
13316 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13317 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13318 * font.c (font_close_object): Now static.
13319 * font.h (font_close_object): Remove.
13320 * fontset.c (FONTSET_OBJLIST): Remove.
13321 (free_realized_fontset) #if-0 the body, which does nothing.
13322 (face_suitable_for_char_p): #if-0, as it's never called.
13323 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13324 * xfaces.c (face_at_string_position):
13325 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13326 since 0 is always ASCII.
13327
dfcf3579
PE
13328 * fns.c (weak_hash_tables): Now static.
13329
5045092b
PE
13330 * fileio.c: Make symbols static if they're not exported.
13331 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13332 (Vwrite_region_annotation_buffers): Now static.
13333
57a96f5c
PE
13334 * eval.c: Make symbols static if they're not exported.
13335 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13336 * lisp.h (backtrace_list): Remove decl.
13337
35f08c38
PE
13338 * emacs.c: Make symbols static if they're not exported.
13339 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13340 (fatal_error_code, fatal_error_signal_hook, standard_args):
13341 Now static.
13342 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13343 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13344 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13345 * lisp.h (fatal_error_signal_hook): Remove decl.
13346 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13347
f44bd759
PE
13348 * editfns.c: Move a (normally-unused) function to its only use.
13349 * editfns.c, lisp.h (get_operating_system_release): Remove.
13350 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13351 worth the hassle of breaking this out.
13352
b532497d
PE
13353 * xterm.c: Make symbols static if they're not exported.
13354 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13355 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13356 (x_destroy_window, x_delete_display):
13357 Now static.
13358 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13359 (x_mouse_leave): Remove; unused.
13360 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13361 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13362 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13363 Remove decls.
13364 (x_mouse_leave): Declare only if WINDOWSNT.
13365 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13366 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13367 USE_X_TOOLKIT.
13368
1675728f
PE
13369 * ftxfont.c: Make symbols static if they're not exported.
13370 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13371 HAVE_FREETYPE.
13372 * font.h (ftxfont_driver): Likewise.
13373
e4cebfca
PE
13374 * xfns.c: Make symbols static if they're not exported.
13375 (x_last_font_name, x_display_info_for_name):
13376 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13377 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13378 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13379 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13380 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13381 (last_show_tip_args): Now static.
13382 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13383 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13384 (x_screen_planes): Remove; unused.
13385 * dispextern.h (x_screen_planes): Remove decl.
13386
5bf46f05
PE
13387 * dispnew.c: Make symbols static if they're not exported.
13388 * dispextern.h (redraw_garbaged_frames, scrolling):
13389 (increment_row_positions): Remove.
13390 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13391 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13392 Now static.
13393 (redraw_garbaged_frames): Remove; unused.
13394
435f4c28
PE
13395 * xfaces.c: Make symbols static if they're not exported.
13396 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13397 Remove decls.
13398 * xterm.h (defined_color): Remove decls.
13399 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13400 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13401 (menu_face_changed_default, defined_color, free_realized_face):
13402 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13403 (ascii_face_of_lisp_face): Remove; unused.
13404
8524aef3
PE
13405 * xdisp.c: Make symbols static if they're not exported.
13406 * dispextern.h (scratch_glyph_row, window_box_edges):
13407 (glyph_to_pixel_coords, set_cursor_from_row):
13408 (get_next_display_element, set_iterator_to_next):
13409 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13410 (show_mouse_face): Remove decls
13411 * frame.h (message_buf_print): Likewise.
13412 * lisp.h (pop_message, set_message, check_point_in_composition):
13413 Likewise.
13414 * xterm.h (set_vertical_scroll_bar): Likewise.
13415 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13416 (message_buf_print, scratch_glyph_row, displayed_buffer):
13417 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13418 (get_next_display_element, show_mouse_face, window_box_edges):
13419 (frame_to_window_pixel_xy, check_point_in_composition):
13420 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13421 (glyph_to_pixel_coords): Remove; unused.
13422
16390cd2
PE
13423 * dired.c (file_name_completion): Now static.
13424
13425 * dbusbind.c (xd_in_read_queued_messages): Now static.
13426
a25f4dfa
PE
13427 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13428 * data.c (circular_list_error): Remove.
13429
14a9c8df
PE
13430 * commands.h (last_point_position, last_point_position_buffer):
13431 (last_point_position_window): Remove decls.
13432 * keyboard.c: Make these variables static.
13433
04f2d78b
CB
13434 * coding.h (coding, code_convert_region, encode_coding_gap):
13435 Remove decls.
74ab6df5
PE
13436 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13437 (iso_code_class, detect_coding, code_convert_region): Now static.
13438 (encode_coding_gap): Remove; unused.
13439
38dfbee1
PE
13440 * chartab.c (chartab_chars, chartab_bits): Now static.
13441
a2cb4e63
PE
13442 * charset.h (charset_iso_8859_1): Remove decl.
13443 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13444 Now static.
13445
127198fd
PE
13446 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13447 * ccl.c (Vccl_program_table): Now static.
13448 (check_ccl_update): Remove; unused.
13449
d85b608f
PE
13450 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13451 * category.h: ... from here.
13452 * category.c (check_category_table, set_category_set): Now static.
13453
31cd66f3
PE
13454 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13455 * lisp.h: Remove these decls.
13456
c358e587
PE
13457 * buffer.c (buffer_count): Remove unused var.
13458
e78aecca
PE
13459 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13460 so that it's not optimized away.
13461 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13462 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13463 exported only to the debugger.
13464
e192d7d3 13465 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13466 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13467
92470028
PE
13468 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13469 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13470 was inaccessible from Lisp.
13471 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13472 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13473
244ed907
PE
13474 alloc.c: Import and export fewer symbols, and remove unused items.
13475 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13476 is defined.
13477 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13478 it's not optimized away by whole-program optimization.
13479 (message_enable_multibyte, free_misc): Remove.
13480 (catchlist, handlerlist, mark_backtrace):
13481 Declare only if BYTE_MARK_STACK.
13482 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13483 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13484 (message_enable_multibyte): Remove decl.
13485 (free_misc, interval_free_list, float_block, float_block_index):
13486 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13487 (cons_free_list, last_marked_index):
13488 Now static.
13489 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13490 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13491 (mark_backtrace): Define only if BYTE_MARK_STACK.
13492 * xdisp.c (message_enable_multibyte): Now static.
13493
61c2b50e 13494 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13495 This makes it easier for human readers (and static analyzers)
13496 to see whether these variables are used from other modules.
13497 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13498 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13499 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13500 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13501 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13502 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13503 * xmenu.c, xselect.c:
13504 Declare Q* vars static if they are not used in other modules.
13505 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13506 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13507 Remove decls of unexported vars.
13508 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13509
95c82688
PE
13510 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13511
16a97296
PE
13512 Make Emacs functions such as Fatom 'static' by default.
13513 This makes it easier for human readers (and static analyzers)
13514 to see whether these functions can be called from other modules.
13515 DEFUN now defines a static function. To make the function external
13516 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13517 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13518 (Finit_image_library):
16a97296
PE
13519 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13520 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13521 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13522 Remove decls, since these functions are now static.
13523 (Funintern, Fget_internal_run_time): New decls, since these functions
13524 were already external.
95c82688 13525
16a97296
PE
13526 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13527 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13528 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13529 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13530 * keyboard.c, keymap.c, lread.c:
13531 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13532 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13533 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13534 Mark functions with DEFUE instead of DEFUN,
13535 if they are used in other modules.
13536 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13537 decls for now-static functions.
13538 * buffer.h (Fdelete_overlay): Remove decl.
13539 * callproc.c (Fgetenv_internal): Mark as internal.
13540 * composite.c (Fremove_list_of_text_properties): Remove decl.
13541 (Fcomposition_get_gstring): New forward static decl.
13542 * composite.h (Fcomposite_get_gstring): Remove decl.
13543 * dired.c (Ffile_attributes): New forward static decl.
13544 * doc.c (Fdocumntation_property): New forward static decl.
13545 * eval.c (Ffetch_bytecode): New forward static decl.
13546 (Funintern): Remove extern decl; now in .h file where it belongs.
13547 * fileio.c (Fmake_symbolic_link): New forward static decl.
13548 * image.c (Finit_image_library): New forward static decl.
13549 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13550 * intervals.h (Fprevious_property_change):
13551 (Fremove_list_of_text_properties): Remove decls.
13552 * keyboard.c (Fthis_command_keys): Remove decl.
13553 (Fcommand_execute): New forward static decl.
13554 * keymap.c (Flookup_key): New forward static decl.
13555 (Fcopy_keymap): Now static.
13556 * keymap.h (Flookup_key): Remove decl.
13557 * process.c (Fget_process): New forward static decl.
13558 (Fprocess_datagram_address): Mark as internal.
13559 * syntax.c (Fsyntax_table_p): New forward static decl.
13560 (skip_chars): Remove duplicate decl.
13561 * textprop.c (Fprevious_property_change): New forward static decl.
13562 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13563 Now internal.
13564 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13565 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13566
785bbd42
PE
13567 * editfns.c (Fformat): Remove unreachable code.
13568
8b913b57
AS
135692011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13570
13571 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13572 change. (Bug#8496)
13573
a6744a35
EZ
135742011-04-13 Eli Zaretskii <eliz@gnu.org>
13575
13576 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13577 when at ZV. (Bug#8487)
13578
e7974947
AS
135792011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13580
baad03f0
AS
13581 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13582 (Bug#8437)
13583 * keyboard.c (parse_tool_bar_item): Likewise.
13584 * sound.c (sound_cleanup, alsa_close): Likewise.
13585 * termcap.c (tgetent): Likewise.
13586 * xfns.c (x_default_font_parameter): Likewise.
13587 * xsettings.c (read_and_apply_settings): Likewise.
13588
e7974947
AS
13589 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13590 (overrun_check_free): Protoize.
13591
28272684
PE
135922011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13593
13594 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13595 since callers should never pass a negative size.
13596 Change the signature to match that of plain 'read' and 'write'; see
13597 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13598 * lisp.h: Update prototypes of emacs_write and emacs_read.
13599
11997c76
EZ
136002011-04-11 Eli Zaretskii <eliz@gnu.org>
13601
13602 * xdisp.c (redisplay_window): Don't try to determine the character
13603 position of the scroll margin if the window start point w->startp
e896f03c 13604 is outside the buffer's accessible region. (Bug#8468)
11997c76 13605
8a2cbd72
EZ
136062011-04-10 Eli Zaretskii <eliz@gnu.org>
13607
13608 Fix write-region and its subroutines for buffers > 2GB.
13609 * fileio.c (a_write, e_write): Modify declaration of arguments and
13610 local variables to support buffers larger than 2GB.
13611 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13612
13613 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13614 argument, local variables, and return value.
13615
13616 * lisp.h: Update prototypes of emacs_write and emacs_read.
13617
13618 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13619
4073e537 136202011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13621
1ebfdcb6
PE
13622 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13623
b2ded58d
PE
13624 Fix more problems found by GCC 4.6.0's static checks.
13625
7d66342c
PE
13626 * xdisp.c (vmessage): Use a better test for character truncation.
13627
bbf47d44
PE
13628 * charset.c (load_charset_map): <, not <=, for optimization,
13629 and to avoid potential problems with integer overflow.
9248994d 13630 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13631 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13632 * editfns.c (Fformat): Likewise.
1e69125e 13633 * syntax.c (skip_chars): Likewise.
3befa583 13634
e3019616
PE
13635 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13636 This also lets GCC 4.6.0 generate slightly better loop code.
13637
becfa255
PE
13638 * callint.c (Fcall_interactively): <, not <=, for optimization.
13639 (Fcall_interactively): Count the number of arguments produced,
13640 not the number of arguments given. This is simpler and lets GCC
13641 4.6.0 generate slightly better code.
13642
dae0cd48
PE
13643 * ftfont.c: Distingish more carefully between FcChar8 and char.
13644 The previous code passed unsigned char * to a functions like
13645 strlen and xstrcasecmp that expect char *, which does not
13646 conform to the C standard.
13647 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13648 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13649 char * when the C standard requires it.
13650
76032d70
PE
13651 * keyboard.c (read_char): Remove unused var.
13652
eb3f1cc8
PE
13653 * eval.c: Port to Windows vsnprintf (Bug#8435).
13654 Include <limits.h>.
13655 (SIZE_MAX): Define if the headers do not.
13656 (verror): Do not give up if vsnprintf returns a negative count.
13657 Instead, grow the buffer. This ports to Windows vsnprintf, which
13658 does not conform to C99. Problem reported by Eli Zaretskii.
13659 Also, simplify the allocation scheme, by avoiding the need for
13660 calling realloc, and removing the ALLOCATED variable.
13661
70476b54
PE
13662 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13663
12020a9e
PE
13664 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13665 But keep the doprint source code for now, as we might revamp it
13666 and use it again (Bug#8435).
ea6c7ae6
PE
13667 * lisp.h (doprnt): Remove.
13668 * Makefile.in (base_obj): Remove doprnt.o.
13669 * deps.mk (doprnt.o): Remove.
13670
5fdb398c
PE
13671 error: Print 32- and 64-bit integers portably (Bug#8435).
13672 Without this change, on typical 64-bit hosts error ("...%d...", N)
13673 was used to print both 32- and 64-bit integers N, which relied on
13674 undefined behavior.
61bdb816 13675 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13676 * lisp.h (error, verror): Mark as printf-like functions.
13677 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13678 Report overflow in size calculations when allocating printf buffer.
13679 Do not truncate output string at its first null byte.
13680 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13681 Truncate the output at a character boundary, since vsnprintf does not
13682 do that.
13683 * charset.c (check_iso_charset_parameter): Convert internal
13684 character to string before calling 'error', since %c now has the
13685 printf meaning.
13686 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13687 overflow when computing char to be passed to 'error'. Do not
13688 pass Lisp_Object to 'error'; pass the integer instead.
13689 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13690 formatted with plain %d.
13691
b189fa66
PE
13692 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13693
bff87ef0
PE
13694 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13695
7e2cac20
PE
13696 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13697
ce4d90b5
PE
13698 * xterm.c (x_catch_errors): Remove duplicate declaration.
13699
266c9547
PE
13700 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13701
79c49ad2
PE
13702 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13703
368f4090
JM
137042011-04-10 Jim Meyering <meyering@redhat.com>
13705
13706 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13707 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13708 return ssize_t not "int", and use size_t as the buffer length.
13709 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13710 * gnutls.h: Update declarations.
13711 * process.c (read_process_output): Use ssize_t, to match.
13712 (send_process): Likewise.
13713
a32d4040
CY
137142011-04-09 Chong Yidong <cyd@stupidchicken.com>
13715
13716 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13717
8546720e 137182011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13719
04f2d78b
CB
13720 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13721 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13722
8546720e
GM
13723 * xterm.c (handle_one_xevent):
13724 * xmenu.c (create_and_show_popup_menu):
13725 * xselect.c (x_decline_selection_request)
13726 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13727
0a2f5c1a 137282011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13729
13730 Fix some uses of `int' instead of EMACS_INT.
13731 * search.c (string_match_1, fast_string_match)
13732 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13733 (scan_buffer, find_next_newline_no_quit)
13734 (find_before_next_newline, search_command, Freplace_match)
13735 (Fmatch_data): Make some `int' variables be EMACS_INT.
13736
13737 * xdisp.c (display_count_lines): 3rd argument and return value now
13738 EMACS_INT. All callers changed.
13739 (pint2hrstr): Last argument is now EMACS_INT.
13740
13741 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13742 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13743 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13744 (decode_coding_utf_16, decode_coding_emacs_mule)
13745 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13746 (decode_coding_ccl, decode_coding_charset)
13747 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13748 (decode_coding_iso_2022, decode_coding_emacs_mule)
13749 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13750 <char_offset, last_offset>: Declare EMACS_INT.
13751 (encode_coding_utf_8, encode_coding_utf_16)
13752 (encode_coding_emacs_mule, encode_invocation_designation)
13753 (encode_designation_at_bol, encode_coding_iso_2022)
13754 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13755 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13756 Declare EMACS_INT.
13757 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13758 (encode_invocation_designation): Last argument P_NCHARS is now
13759 EMACS_INT.
13760 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13761 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13762
13763 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13764 All users changed.
13765
13766 * ccl.c (Fccl_execute_on_string): Declare some variables
13767 EMACS_INT.
13768
8546720e 137692011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13770
13771 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13772
4e19a977
CS
137732011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13774
13775 * process.c (Fformat_network_address): Doc fix.
13776
87302331
R
137772011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13778
ee7683eb 13779 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13780
cbb59342
CY
137812011-04-08 Chong Yidong <cyd@stupidchicken.com>
13782
13783 * keyboard.c (read_char): Call Lisp function help-form-show,
13784 instead of using internal_with_output_to_temp_buffer.
13785 (Qhelp_form_show): New var.
e0d38eeb 13786 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13787
13788 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13789
13790 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13791
e67a13ab
CY
137922011-04-06 Chong Yidong <cyd@stupidchicken.com>
13793
04f2d78b
CB
13794 * process.c (Flist_processes): Remove to Lisp.
13795 (list_processes_1): Delete.
e67a13ab 13796
973f782d
EZ
137972011-04-06 Eli Zaretskii <eliz@gnu.org>
13798
7c106b1e
EZ
13799 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13800
973f782d
EZ
13801 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13802
41cf7d1a 138032011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13804
ca23cc88
PE
13805 Fix more problems found by GCC 4.6.0's static checks.
13806
f390e2d5
PE
13807 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13808
42eea0d0
PE
13809 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13810
b69769da 13811 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13812
f9541e84
PE
13813 * xdisp.c (vmessage): Mark as a printf-like function.
13814
13841b55
PE
13815 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13816
c136c10f
PE
13817 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13818
5e2d4a30
PE
13819 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13820 printf-like functions.
13821 (tiff_load): Add casts to remove these marks before passing them
13822 to system-supplied API.
13823
583f48b9
PE
13824 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13825
b25d760e
PE
13826 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13827 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13828 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13829 directly, rather than having caller test rule sign. This avoids
13830 some unnecessary tests.
13831 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13832 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13833 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13834
bc7b6697 13835 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13836 (xfont_open): Avoid unnecessary tests.
bc7b6697 13837
27ccc379
PE
13838 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13839
dcd5c89a
PE
13840 * composite.h, composite.c (composition_gstring_put_cache):
13841 Use EMACS_INT, not int, for length.
13842
b13a45c6
PE
13843 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13844 breaking out part of COMPOSITION_DECODE_RULE.
13845 (COMPOSITION_DECODE_RULE): Use it.
13846 * composite.c (get_composition_id): Remove unused local vars,
13847 by using the new macro.
13848
1e792e4d
PE
13849 * textprop.c (set_text_properties_1): Change while to do-while,
13850 since the condition is always true at first.
13851
dc6c6455 13852 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13853 (interval_deletion_adjustment): Return unsigned value.
13854 All uses changed.
dc6c6455 13855
aba7731a
PE
13856 * process.c (list_processes_1, create_pty, read_process_output):
13857 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13858 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13859 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13860 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13861 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13862
fdfc4bf3
PE
13863 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13864
fca8fe46 13865 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13866 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13867
06a0259a 13868 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13869 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13870 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13871
e7b9e80f
PE
13872 * print.c (print_error_message): Avoid int overflow.
13873
56201685
PE
13874 * font.c (font_list_entities): Redo for clarity,
13875 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13876
78834453 13877 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13878 (font_score): Avoid potential overflow in diff calculation.
78834453 13879
0bc0b309 13880 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13881 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13882
e610eaca
PE
13883 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13884
b895abce
PE
13885 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13886 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13887 can always succeed if overflow has undefined behavior.
13888
1f1d9321 13889 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13890 (wordify): Omit three unnecessary tests.
1f1d9321 13891
c59478bc
PE
13892 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13893 All callers changed. This avoids the need for an unused var.
13894
79b73827
PE
13895 * casefiddle.c (casify_region): Remove var that is set but not used.
13896
a4db5dfe
PE
13897 * dired.c (file_name_completion): Remove var that is set but not used.
13898
43aae36e
PE
13899 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13900
2a47c44d 13901 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13902 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13903
a37c69bf
PE
13904 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13905 Check for integer overflow on size calculations.
13906
328ab8e7
PE
13907 * buffer.c (Fprevious_overlay_change): Remove var that is set
13908 but not used.
13909
e5a2a5cb
PE
13910 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13911 Remove vars that are set but not used.
8d84a6eb 13912 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13913 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13914
a60e5f68
PE
13915 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13916
f661cb61 13917 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13918 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13919
f0397f5a
PE
13920 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13921 that are set but not used.
13922
8664db06 13923 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13924 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13925
6abdaa4a
PE
13926 * xselect.c (x_get_local_selection, x_handle_property_notify):
13927 Remove vars that are set but not used.
13928
0ce7538d 13929 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13930 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13931
9ae848fc
PE
13932 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13933 Remove var that is set but not used.
0b918413
PE
13934 (scroll_bar_windows_size): Now size_t, not int.
13935 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13936 Check for overflow.
9ae848fc 13937
a5a62657
PE
13938 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13939 (map_tty_color) [!defined MSDOS]: Likewise.
13940
5c5cdd39
PE
13941 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13942
66ebf983
PE
13943 * coding.c: Remove vars that are set but not used.
13944 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13945 All callers changed.
13946 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13947 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13948 (decode_coding_charset): Remove vars that are set but not used.
13949
1be4d761
PE
13950 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13951 that is set but not used.
13952
47553fa8
PE
13953 * print.c (print_object): Remove var that is set but not used.
13954
1f7196bf 13955 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13956 The gnulib version avoids calling malloc in the usual case,
13957 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13958 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13959 * filelock.c (current_lock_owner): Likewise.
13960 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13961 * sysdep.c: Include allocator.h, careadlinkat.h.
13962 (emacs_no_realloc_allocator): New static constant.
13963 (emacs_readlink): New function.
fdb61804
PE
13964 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13965 ../lib/careadlinkat.h.
d1fdcab7 13966
f84c17c7
SM
139672011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13968
13969 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13970 first non-nil return value).
13971
ef3862ad
JD
139722011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13973
13974 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13975 if not defined (Bug#8403).
13976
376a7006
JB
139772011-04-02 Juanma Barranquero <lekktu@gmail.com>
13978
13979 * xdisp.c (display_count_lines): Remove parameter `start',
13980 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13981 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13982 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13983 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13984 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13985 and thereabouts. All callers changed.
13986 (get_per_char_metric): Remove parameter `f', unused since
13987 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13988
6ca3801d
JM
139892011-04-02 Jim Meyering <meyering@redhat.com>
13990
13991 do not dereference NULL upon failed strdup
13992 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13993 (ns_get_family): Likewise.
13994
d8e2b5ba
JB
139952011-04-02 Juanma Barranquero <lekktu@gmail.com>
13996
13997 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13998
8c74fcbd
JD
139992011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14000
14001 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14002 later (Bug#8403).
14003
7200d79c
SM
140042011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14005
03408648 14006 Add lexical binding.
7200d79c 14007
03408648
SM
14008 * window.c (Ftemp_output_buffer_show): New fun.
14009 (Fsave_window_excursion):
14010 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14011
14012 * lread.c (lisp_file_lexically_bound_p): New function.
14013 (Fload): Bind Qlexical_binding.
14014 (readevalloop): Remove `evalfun' arg.
14015 Bind Qinternal_interpreter_environment.
14016 (Feval_buffer): Bind Qlexical_binding.
14017 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14018 Mark as dynamic.
14019 (syms_of_lread): Declare `lexical-binding'.
14020
14021 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14022
14023 * keyboard.c (eval_dyn): New fun.
14024 (menu_item_eval_property): Use it.
ca105506
SM
14025
14026 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14027
03408648
SM
14028 * fns.c (concat, mapcar1): Accept byte-code-functions.
14029
14030 * eval.c (Fsetq): Handle lexical vars.
14031 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14032 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14033 (FletX, Flet): Obey lexical binding.
14034 (Fcommandp): Handle closures.
14035 (Feval): New `lexical' arg.
14036 (eval_sub): New function extracted from Feval. Use it almost
14037 everywhere where Feval was used. Look up vars in lexical env.
14038 Handle closures.
14039 (Ffunctionp): Move from subr.el.
14040 (Ffuncall): Handle closures.
14041 (apply_lambda): Remove `eval_flags'.
14042 (funcall_lambda): Handle closures and new byte-code-functions.
14043 (Fspecial_variable_p): New function.
14044 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14045 but without exporting it to Lisp.
23aba0ea 14046
23aba0ea 14047 * doc.c (Fdocumentation, store_function_docstring):
03408648 14048 * data.c (Finteractive_form): Handle closures.
23aba0ea 14049
03408648
SM
14050 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14051 interactive spec.
ba83908c 14052
04f2d78b
CB
14053 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14054 New byte-codes.
03408648
SM
14055 (exec_byte_code): New function extracted from Fbyte_code to handle new
14056 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14057
03408648 14058 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14059
03408648 14060 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14061
e2abce01
JB
140622011-03-31 Juanma Barranquero <lekktu@gmail.com>
14063
14064 * xdisp.c (redisplay_internal): Fix prototype.
14065
63696a73 140662011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14067
63696a73 14068 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14069 (try_scrolling): Use it when setting scroll_limit.
14070 Limit scrolling to 100 screen lines.
63696a73
EZ
14071 (redisplay_window): Even when falling back on "recentering",
14072 position point in the window according to scroll-conservatively,
14073 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14074
14075 (try_scrolling): When point is above the window, allow searching
14076 as far as scroll_max, or one screenful, to compute vertical
14077 distance from PT to the scroll margin position. This prevents
14078 try_scrolling from unnecessarily failing when
14079 scroll-conservatively is set to a value slightly larger than the
14080 window height. Clean up the case of PT below the margin at bottom
14081 of window: scroll_max can no longer be INT_MAX. When aggressive
14082 scrolling is in use, don't let point enter the opposite scroll
14083 margin as result of the scroll.
14084 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14085 threshold of 100 lines for never-recentering scrolling.
14086
e4cc2dfc
JB
140872011-03-31 Juanma Barranquero <lekktu@gmail.com>
14088
14089 * dispextern.h (move_it_by_lines):
14090 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14091 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14092 (message_log_check_duplicate): Remove parameters `prev_bol' and
14093 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14094 (redisplay_internal): Remove parameter `preserve_echo_area',
14095 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14096
14097 * indent.c (Fvertical_motion):
14098 * window.c (window_scroll_pixel_based, Frecenter):
14099 Don't pass `need_y_p' to `move_it_by_lines'.
14100
1c470562
SM
141012011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14102
44f230aa
SM
14103 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14104 steal a few bits to be more compact.
14105 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14106 Remove unneeded casts.
14107
1c470562
SM
14108 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14109
888adce9
ZK
141102011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14111
14112 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14113 binding" message (bug#7967).
14114
f838ed7b
PE
141152011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14116
77861b95
PE
14117 Fix more problems found by GCC 4.6.0's static checks.
14118
de6dbc14
PE
14119 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14120 Remove unused local var.
14121
f838ed7b
PE
14122 * editfns.c (Fmessage_box): Remove unused local var.
14123
792c7b2b
PE
14124 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14125 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14126 Omit unused local vars.
c499e557 14127 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14128 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14129 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14130 Omit unused local var.
14131
ba0165e1
PE
14132 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14133 Don't assume string length fits in int.
32ad8845 14134 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14135 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14136
3c59b4c9
PE
14137 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14138 instead of alloca (Bug#8344).
14139
a3eed478 14140 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14141 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14142
eb4d412d
PE
14143 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14144
1658b401
PE
14145 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14146 concerns.
14147
14148 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14149
14150 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14151
9a2c6e05
PE
14152 * keyboard.c (syms_of_keyboard): Use the same style as later
14153 in this function when indexing through an array. This also
14154 works around GCC bug 48267.
14155
03d0a109
PE
14156 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14157
44f730c8
PE
14158 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14159
fe75f926
PE
14160 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14161 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14162
ffa8c828
PE
14163 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14164 This avoids undefined behavior on integer overflow, and is a bit
14165 more convenient anyway since it is compared to a size_t variable.
14166
c5101a77
PE
14167 Variadic C functions now count arguments with size_t, not int.
14168 This avoids an unnecessary limitation on 64-bit machines, which
14169 caused (substring ...) to crash on large vectors (Bug#8344).
14170 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14171 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14172 All variadic functions and their callers changed accordingly.
c5101a77
PE
14173 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14174 * data.c (arith_driver, float_arith_driver): Likewise.
14175 * editfns.c (general_insert_function): Likewise.
14176 * eval.c (struct backtrace.nargs, interactive_p)
14177 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14178 (funcall_lambda, mark_backtrace): Likewise.
14179 * fns.c (concat): Likewise.
14180 * frame.c (x_set_frame_parameters): Likewise.
14181 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14182 0 if not found, not -1. All callers changed.
14183
dd3f25f7
PE
14184 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14185 (stack_copy_size): Now size_t, not int.
14186 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14187
461c2ab9
JB
141882011-03-28 Juanma Barranquero <lekktu@gmail.com>
14189
14190 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14191 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14192 All callers changed.
14193
14194 * lisp.h (multibyte_char_to_unibyte):
14195 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14196 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14197 * character.h (CHAR_TO_BYTE8):
14198 * cmds.c (internal_self_insert):
14199 * editfns.c (general_insert_function):
14200 * keymap.c (push_key_description):
14201 * search.c (Freplace_match):
14202 * xdisp.c (message_dolog, set_message_1): All callers changed.
14203
f6d62986
SM
142042011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14205
14206 * keyboard.c (safe_run_hook_funcall): New function.
14207 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14208 don't set the hook to nil, but remove the offending function instead.
14209 (Qcommand_hook_internal): Remove, unused.
14210 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14211 Vcommand_hook_internal.
14212
14213 * eval.c (enum run_hooks_condition): Remove.
14214 (funcall_nil, funcall_not): New functions.
14215 (run_hook_with_args): Call each function through a `funcall' argument.
14216 Remove `cond' argument, now redundant.
14217 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14218 (Frun_hook_with_args_until_failure): Adjust accordingly.
14219 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14220
1db5b1ad
JB
142212011-03-28 Juanma Barranquero <lekktu@gmail.com>
14222
14223 * dispextern.h (string_buffer_position): Remove declaration.
14224
14225 * print.c (strout): Remove parameter `multibyte', unused since
14226 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14227
14228 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14229 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14230 All callers changed.
14231
14232 * w32.c (_wsa_errlist): Use braces for struct initializers.
14233
14234 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14235 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14236 All callers changed.
14237 (string_buffer_position): Likewise. Also, make static (it's never
14238 used outside xdisp.c).
14239 (cursor_row_p): Remove parameter `w', unused since
14240 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14241 (decode_mode_spec): Remove parameter `precision', introduced during
14242 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14243 All callers changed.
14244
5ffb62aa
JD
142452011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14246
14247 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14248
461c2ab9 142492011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14250
14251 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14252 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14253 (ns_update_auto_hide_menu_bar): New functions.
14254 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14255 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14256 ns_constrain_all_frames.
14257 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14258 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14259
5c380ffb
JD
142602011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14261
14262 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14263
9af30bdf
GM
142642011-03-27 Glenn Morris <rgm@gnu.org>
14265
14266 * syssignal.h: Replace RETSIGTYPE with void.
14267 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14268 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14269 Replace SIGTYPE with void everywhere.
14270 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14271 * s/template.h (SIGTYPE): Remove commented out definition.
14272
e2abce01
JB
142732011-03-26 Eli Zaretskii <eliz@gnu.org>
14274
14275 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14276 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14277
f868cd8a
JB
142782011-03-26 Juanma Barranquero <lekktu@gmail.com>
14279
59eb0929
JB
14280 * w32.c (read_unc_volume): Use parameter `henum', instead of
14281 global variable `wget_enum_handle'.
14282
14283 * keymap.c (describe_vector): Remove parameters `indices' and
14284 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14285 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14286
f868cd8a
JB
14287 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14288
14289 * keyboard.c (timer_check): Remove parameter `do_it_now',
14290 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14291 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14292 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14293
14294 * keyboard.c (read_char):
14295 * w32menu.c (w32_menu_display_help):
14296 * xmenu.c (show_help_event, menu_help_callback):
14297 Adjust calls to `show_help_echo'.
14298
14299 * gtkutil.c (xg_maybe_add_timer):
14300 * keyboard.c (readable_events):
14301 * process.c (wait_reading_process_output):
14302 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14303
14304 * insdel.c (adjust_markers_gap_motion):
14305 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14306 (gap_left, gap_right): Don't call it.
14307
2ecf6fdb
CY
143082011-03-25 Chong Yidong <cyd@stupidchicken.com>
14309
14310 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14311 incurred during fontification.
14312
6b1f9ba4
JB
143132011-03-25 Juanma Barranquero <lekktu@gmail.com>
14314
14315 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14316 (DEFVAR_PER_BUFFER): Don't pass it.
14317
14318 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14319 (scrolling_window): Don't pass it.
14320
0f4a96b5
JB
143212011-03-25 Juanma Barranquero <lekktu@gmail.com>
14322
14323 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14324
14325 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14326 and `suffix'.
14327 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14328 of variables specific to SELinux and computation of `encoded_absname'.
14329
14330 * image.c (XPutPixel): Remove unused variable `height'.
14331
14332 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14333
14334 * unexw32.c (get_section_info): Remove unused variable `section'.
14335
14336 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14337 (system_process_attributes): Remove unused variable `sess'.
14338 (sys_read): Remove unused variable `err'.
14339
14340 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14341 (w32_wnd_proc): Remove unused variable `isdead'.
14342 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14343 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14344 (x_create_tip_frame): Remove unused variable `tem'.
14345
14346 * w32inevt.c (w32_console_read_socket):
14347 Remove unused variable `no_events'.
14348
14349 * w32term.c (x_draw_composite_glyph_string_foreground):
14350 Remove unused variable `width'.
14351
1149507c
JB
143522011-03-24 Juanma Barranquero <lekktu@gmail.com>
14353
14354 * w32term.c (x_set_glyph_string_clipping):
14355 Don't pass uninitialized region to CombineRgn.
14356
9c88f339
JB
143572011-03-23 Juanma Barranquero <lekktu@gmail.com>
14358
14359 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14360 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14361 (Fx_close_connection): Remove unused variable `i'.
14362
14363 * w32font.c (w32font_draw): Return number of glyphs.
14364 (w32font_open_internal): Remove unused variable `i'.
14365 (w32font_driver): Add missing initializer.
14366
14367 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14368 (fill_in_menu): Remove unused variable `items_added'.
14369
14370 * w32term.c (last_mouse_press_frame): Remove static global variable.
14371 (w32_clip_to_row): Remove unused variable `f'.
14372 (x_delete_terminal): Remove unused variable `i'.
14373
14374 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14375 (NOTHING): Remove unused static global variable.
14376 (uniscribe_check_otf): Remove unused variable `table'.
14377 (uniscribe_font_driver): Add missing initializers.
14378
dee091a3
JD
143792011-03-23 Julien Danjou <julien@danjou.info>
14380
14381 * term.c (Fsuspend_tty, Fresume_tty):
14382 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14383 * window.c (temp_output_buffer_show):
14384 * insdel.c (signal_before_change):
14385 * frame.c (Fhandle_switch_frame):
14386 * fileio.c (Fdo_auto_save):
14387 * emacs.c (Fkill_emacs):
14388 * editfns.c (save_excursion_restore):
14389 * cmds.c (internal_self_insert):
14390 * callint.c (Fcall_interactively):
14391 * buffer.c (Fkill_all_local_variables):
14392 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14393 Use Frun_hooks.
0f4a96b5 14394 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14395 unconditionally since it does the check itself.
dee091a3 14396
2c520ab5 143972011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14398
c9c49752
PE
14399 Fix more problems found by GCC 4.5.2's static checks.
14400
8abc3f12
PE
14401 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14402 the first time through the loop, since we know p0 < p1 then.
14403 This also avoids a gcc -Wstrict-overflow warning.
14404
a2d26660
PE
14405 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14406 leading to a memory leak, possible in functions like
14407 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14408 of objects (Bug#8318).
a2d26660 14409
916c72e9
PE
14410 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14411 that could (at least in theory) be that large.
14412
19ab8a18
PE
14413 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14414 This is less likely to overflow, and avoids undefined behavior if
14415 overflow does occur. All callers changed. Use strtoul to scan
14416 for the unsigned long integer.
b7cbbd6f
PE
14417 (pint2hrstr): Simplify and tune code slightly.
14418 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14419
f0641eff
PE
14420 * scroll.c (do_scrolling): Work around GCC bug 48228.
14421 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14422
7f650bb9
PE
14423 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14424 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14425 (validate_x_resource_name): Simplify count usage.
14426 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14427
37dd57d1
PE
14428 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14429 fail (Bug#8306).
81e56e61 14430
699979fc 14431 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14432
401bf9b4
PE
14433 * process.c (Fmake_network_process): Use socklen_t, not int,
14434 where POSIX says socklen_t is required in portable programs.
14435 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14436 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14437 (Fmake_network_process, server_accept_connection):
14438 (wait_reading_process_output, read_process_output):
14439 Likewise.
14440
b93aacde
PE
14441 * process.c: Rename or move locals to avoid shadowing.
14442 (list_processes_1, Fmake_network_process):
14443 (read_process_output_error_handler, exec_sentinel_error_handler):
14444 Rename or move locals.
4dc343ee 14445 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14446 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14447 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14448 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14449 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14450
af8a867c 14451 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14452 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14453 Include tparam.h instead, since it declares them.
af8a867c
PE
14454 * cm.h (PC): Remove extern decl; tparam.h now does this.
14455 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14456 * terminfo.c: Include tparam.h, to check interfaces.
14457 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14458 (tparam): Adjust signature to match interface in tparam.h;
14459 this removes some undefined behavior. Check that outstring and len
14460 are zero, which they always are with Emacs.
14461 * tparam.h (PC, BC, UP): New extern decls.
14462
0248044d 14463 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14464 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14465
8ff096c1 14466 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14467 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14468 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14469 (ftfont_list): Remove unused local.
49eaafba
PE
14470 (get_adstyle_property, ftfont_pattern_entity):
14471 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14472 Rename locals to avoid shadowing.
8ff096c1 14473
e2be39f6
PE
14474 * xfont.c (xfont_list_family): Mark var as initialized.
14475
c9735e30
PE
14476 * xml.c (make_dom): Now static.
14477
8f5201ae
PE
14478 * composite.c (composition_compute_stop_pos): Rename local to
14479 avoid shadowing.
b246f932
PE
14480 (composition_reseat_it): Remove unused locals.
14481 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14482 (composition_update_it): Mark var as initialized.
11b61122
PE
14483 (find_automatic_composition): Mark vars as initialized,
14484 with a FIXME (Bug#8290).
8f5201ae 14485
760fbc2c
PE
14486 character.h: Rename locals to avoid shadowing.
14487 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14488 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14489 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14490 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14491 to avoid shadowing.
14492
ff08eb85
PE
14493 * textprop.c (property_change_between_p): Remove; unused.
14494
fc7bf025
PE
14495 * intervals.c (interval_start_pos): Now static.
14496
235d7abc
PE
14497 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14498
44f230aa
SM
14499 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14500 Rename locals to avoid shadowing.
3e7d6594 14501
50060332
PE
14502 * sound.c (wav_play, au_play, Fplay_sound_internal):
14503 Fix pointer signedness.
d01f234b 14504 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14505 (wav_play): Initialize a variable to 0, to prevent undefined
14506 behavior (Bug#8278).
50060332 14507
c4fc4e30
PE
14508 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14509
918436ed
PE
14510 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14511
c939f91b
PE
14512 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14513 clobbering (Bug#8298).
b9c7f648
PE
14514 * sysdep.c (sys_subshell): Likewise.
14515 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14516
6bd8c144
PE
14517 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14518 This should get cleaned up, so that child_setup has the
14519 same signature on all platforms.
14520
7710357c 14521 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14522 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14523
c59da222
CY
145242011-03-22 Chong Yidong <cyd@stupidchicken.com>
14525
14526 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14527 not to be necessary, and produces flickering.
14528
66b87493
GM
145292011-03-20 Glenn Morris <rgm@gnu.org>
14530
14531 * config.in: Remove file.
14532
45b6f6d5
JB
145332011-03-20 Juanma Barranquero <lekktu@gmail.com>
14534
14535 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14536 are now in src/globals.h.
14537 (syms_of_minibuf): Remove spurious & from previous change.
14538
cd394be1 145392011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14540
14541 * minibuf.c (completing-read-function): New variable.
14542 (completing-read-default): Rename from completing-read.
14543 (completing-read): Call completing-read-function.
14544
b14e3e21
CY
145452011-03-19 Juanma Barranquero <lekktu@gmail.com>
14546
14547 * xfaces.c (Fx_load_color_file):
14548 Read color file from absolute filename (bug#8250).
14549
f2b726e6
JB
145502011-03-19 Juanma Barranquero <lekktu@gmail.com>
14551
14552 * makefile.w32-in: Update dependencies.
14553
09f6ff02
EZ
145542011-03-17 Eli Zaretskii <eliz@gnu.org>
14555
14556 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14557
29a6015a
PE
145582011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14559
a3a6c54e
PE
14560 Fix more problems found by GCC 4.5.2's static checks.
14561
b766f867
PE
14562 * process.c (make_serial_process_unwind, send_process_trap):
14563 (sigchld_handler): Now static.
14564
be02381c
PE
14565 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14566 That way, the code declares only the vars that it needs.
14567 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14568 * s/cygwin.h (PTY_ITERATION): Likewise.
14569 * s/darwin.h (PTY_ITERATION): Likewise.
14570 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14571
57048744
PE
14572 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14573 * process.c (allocate_pty): Don't declare stb unless it's needed.
14574
7914961c 14575 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14576 (CONSTANTLIM): Remove; unused.
14577 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14578 Define only if needed.
7914961c 14579
b3967b18
PE
14580 * unexelf.c (unexec): Name an expression,
14581 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14582 Use a different way to cause a compilation error if anyone uses
14583 n rather than nn, a way that does not involve shadowing.
73366a00 14584 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14585
29a6015a
PE
14586 * deps.mk (unexalpha.o): Remove; unused.
14587
43cfc33e 14588 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14589 * unexec.h: New file.
ce701a33
PE
14590 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14591 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14592 Depend on unexec.h.
14593 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14594 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14595 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14596 Change as necessary to match prototype in unexec.h.
ce701a33 14597
01f44d5a
PE
14598 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14599 shadowing.
4f63c6bb 14600 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14601
a6670b0b
PE
14602 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14603 Rename locals to avoid shadowing.
14604
cef2010d 14605 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14606 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14607
d4d7173a
PE
14608 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14609
f08b802a
PE
14610 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14611 warning when compiling print.c.
14612
3ddb0639
PE
14613 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14614 instead of using an uninitialized var.
5ad03b97 14615 (font_sort_entities): Mark var as initialized.
3ddb0639 14616
170a2692
PE
14617 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14618
e663c700
PE
14619 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14620 pointers to constants.
89bc529a 14621 (font_parse_fcname): Remove unused vars.
7b81e2d0 14622 (font_delete_unmatched): Now static.
ea838e10 14623 (font_get_spec): Remove; unused.
13a547c6
PE
14624 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14625 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14626 Rename or move locals to avoid shadowing.
e663c700 14627
2a80c887 14628 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14629 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14630
1384fa33 14631 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14632 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14633
8b2c52e9
PE
14634 * alloc.c (mark_backtrace): Move decl from here ...
14635 * lisp.h: ... to here, so that it can be checked.
14636
475545b5 14637 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14638 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14639 (lisp_indirect_variable): Name an expression,
14640 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14641 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14642
b1349114 14643 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14644 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14645 Use const pointer when appropriate.
b1349114 14646
a2928364
PE
14647 * lisp.h (get_system_name, get_operating_system_release):
14648 Move decls here, to check interfaces.
14649 * process.c (get_operating_system_release): Move decl to lisp.h.
14650 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14651 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14652 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14653 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14654 (Fformat_time_string, Fencode_time, Finsert_char):
14655 (Ftranslate_region_internal, Fformat):
14656 Rename or remove local vars to avoid shadowing.
9710023e 14657 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14658
a415e694
PE
14659 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14660 avoid shadowing.
14661
8ef4622d
PE
14662 * lisp.h (eassert): Check that the argument compiles, even if
14663 ENABLE_CHECKING is not defined.
14664
946f9a5b
PE
14665 * data.c (Findirect_variable): Name an expression, to avoid
14666 gcc -Wbad-function-cast warning.
112396d6 14667 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14668 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14669 (Fmake_variable_buffer_local, Fmake_local_variable):
14670 Mark variables as initialized.
52746918 14671 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14672
e5aab7e7 14673 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14674 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14675 Rename locals to avoid shadowing.
dff45157
PE
14676 (mark_stack): Move local variables into the #ifdef region where
14677 they're used.
7bc26fdb
PE
14678 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14679 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14680 needed otherwise.
14681 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14682 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14683 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14684
e5aab7e7
PE
14685 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14686 avoids undefined behavior in theory.
14687
4da60324
PE
14688 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14689
88043301
PE
14690 Use functions, not macros, for up- and down-casing (Bug#8254).
14691 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14692 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14693 to use the following functions instead of these macros.
14694 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14695 EMACS_INT, since callers assume the returned value fits in int.
14696 (upcase1): Likewise, for UPCASE_TABLE.
14697 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14698 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14699 the race-condition problem in the old DOWNCASE.
88043301 14700
19ed5445
PE
14701 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14702 Rename locals to avoid shadowing.
14703 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14704 (regex_compile, re_search_2, re_match_2_internal):
14705 Remove unused local vars.
952db0d7
PE
14706 (FREE_VAR): Rewrite so as not to use empty "else",
14707 which gcc can warn about.
da053e48 14708 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14709 (RETALLOC_IF): Define only if needed.
14710 (WORDCHAR_P): Likewise. This one is never needed, but is used
14711 only in a comment talking about a compiler bug, so put inside
14712 the #if 0 of that comment.
14713 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14714 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14715 Remove; unused.
19ed5445 14716
1f3561e4 14717 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14718 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14719 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14720
ded6f8f7
PE
14721 * search.c (simple_search): Remove unused var.
14722
dbd37a95
PE
14723 * dired.c (compile_pattern): Move decl from here ...
14724 * lisp.h: ... to here, so that it can be checked.
14725 (struct re_registers): New forward decl.
14726
7e47afad
PE
14727 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14728
85f24f61
PE
14729 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14730 All uses changed.
14731 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14732 Rename locals to avoid shadowing.
5671df8f 14733 (Fvertical_motion): Mark locals as initialized.
85f24f61 14734
181aa2be 14735 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14736 (casify_region): Mark local as initialized.
181aa2be 14737
930d429c
PE
14738 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14739
7082eac6
PE
14740 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14741 New macros, so that the caller can use some names other than
14742 gcpro1, gcpro2, etc.
14743 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14744 of the new macros.
14745 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14746 argument, for consistency with GCPRO2_VAR, etc: it is now the
14747 prefix of the variable, not the variable itself. All uses
14748 changed.
38b2c076
PE
14749 * dired.c (directory_files_internal, file_name_completion):
14750 Rename locals to avoid shadowing.
14751
15206ed9
PE
14752 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14753 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14754 dired.c's scmp function, had undefined behavior.
14755 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14756 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14757 * buffer.h: ... to here, because these macros use current_buffer,
14758 and the new implementation with inline functions needs to have
14759 current_buffer in scope now, rather than later when the macros
14760 are used.
14761 (downcase, upcase1): New static inline functions.
14762 (DOWNCASE, UPCASE1): Reimplement using these functions.
14763 This avoids undefined behavior in expressions like
14764 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14765 from race conditions in accessing the global variables
14766 case_temp1 and case_temp2.
14767 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14768 * lisp.h (case_temp1, case_temp2): Remove their decls.
14769 * character.h (ASCII_CHAR_P): Move from here ...
14770 * lisp.h: ... to here, so that the inline functions mentioned
14771 above can use them.
14772
4a6bea26
PE
14773 * dired.c (directory_files_internal_unwind): Now static.
14774
f14b7e14
PE
14775 * fileio.c (file_name_as_directory, directory_file_name):
14776 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14777 Now static.
2893f146
PE
14778 (file_name_as_directory): Use const pointers when appropriate.
14779 (Fexpand_file_name): Likewise. In particular, newdir might
14780 point at constant storage, so make it a const pointer.
fd4ead52 14781 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14782 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14783 signedness issues.
f839df0c
PE
14784 (Fset_file_times, Finsert_file_contents, auto_save_error):
14785 Rename locals to avoid shadowing.
f14b7e14 14786
5716756e 14787 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14788 (Ftry_completion, Fall_completions): Rename or remove locals
14789 to avoid shadowing.
5716756e 14790
b4c3046a
PE
14791 * marker.c (bytepos_to_charpos): Remove; unused.
14792
b45db522
PE
14793 * lisp.h (verify_bytepos, count_markers): New decls,
14794 so that gcc does not warn that these functions aren't declared.
14795
85876d07
PE
14796 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14797 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14798 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14799 (copy_text): Remove unused local var.
85876d07 14800
03d78a21 14801 * filelock.c (within_one_second): Now static.
b3dd38ab 14802 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14803
5df8f01b
PE
14804 * buffer.c (fix_overlays_before): Mark locals as initialized.
14805 (fix_start_end_in_overlays): Likewise. This function should be
14806 simplified by using pointers-to-pointers, but that's a different
14807 matter.
b1d876f1 14808 (switch_to_buffer_1): Now static.
8f54f30a
PE
14809 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14810 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14811
a70072c9 14812 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14813 Fix pointer signedness issue.
edced198
PE
14814 (sys_subshell): Mark local as volatile if checking for lint,
14815 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14816 (MAXPATHLEN): Define only if needed.
a70072c9 14817
a0977c44
PE
14818 * process.c (serial_open, serial_configure): Move decls from here ...
14819 * systty.h: ... to here, so that they can be checked.
14820
a884fdcc
PE
14821 * fns.c (get_random, seed_random): Move extern decls from here ...
14822 * lisp.h: ... to here, so that they can be checked.
14823
604efe86 14824 * sysdep.c (reset_io): Now static.
b8950c94 14825 (wait_for_termination_signal): Remove; unused.
604efe86 14826
38fc62d9
PE
14827 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14828 (copy_keymap_item, append_key, push_text_char_description):
14829 Now static.
1004a21a 14830 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14831 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14832 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14833 (describe_map_tree):
14834 Rename locals to avoid shadowing.
38fc62d9 14835
2f2650da
PE
14836 * keyboard.c: Declare functions static if they are not used elsewhere.
14837 (echo_char, echo_dash, cmd_error, top_level_2):
14838 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14839 (read_char, kbd_buffer_get_event, make_lispy_position):
14840 (make_lispy_event, make_lispy_movement, apply_modifiers):
14841 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14842 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14843 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14844 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14845 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14846
a053e86c 14847 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14848 (mark_kboards): Move decl here ...
14849 * alloc.c (mark_kboards): ... from here.
a053e86c 14850
4752793e
PE
14851 * lisp.h (force_auto_save_soon): New decl.
14852
74f10ca7 14853 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14854 (DEFINE_DUMMY_FUNCTION): New macro.
14855 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14856 Use it.
c03cd23f
PE
14857 (main): Add casts to avoid warnings
14858 if GCC considers string literals to be constants.
74f10ca7 14859
022e70d4
PE
14860 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14861
59d6fe83
PE
14862 * dbusbind.c: Pointer signedness fixes.
14863 (xd_signature, xd_append_arg, xd_initialize):
14864 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14865 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14866 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14867 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14868
78320123
PE
14869 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14870 if GCC considers string literals to be constants.
49cebcca 14871 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14872
35ac2a97
SM
148732011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14874
fb103ca9
SM
14875 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14876 (print_preprocess, print_object): New macro to fix last change.
14877
35ac2a97
SM
14878 * print.c (print_preprocess): Don't forget font objects.
14879
62973b41
JB
148802011-03-16 Juanma Barranquero <lekktu@gmail.com>
14881
14882 * emacs.c (USAGE3): Doc fixes.
14883
0e48bb22
AS
148842011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14885
14886 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14887 structure.
14888
7684e57b
JB
148892011-03-14 Juanma Barranquero <lekktu@gmail.com>
14890
14891 * lisp.h (VWindow_system, Qfile_name_history):
14892 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14893 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14894 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14895
14896 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14897 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14898
14899 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14900 * w32console.c (detect_input_pending, read_input_pending)
14901 (encode_terminal_code):
14902 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14903 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14904 (w32_system_caret_y, Qfile_name_history):
14905 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14906 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14907 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14908 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14909 * w32proc.c (Qlocal, report_file_error):
14910 * w32term.c (Vwindow_system, updating_frame):
14911 * w32uniscribe.c (initialized, uniscribe_font_driver):
14912 Remove unneeded extern declarations.
14913
2aa46d6c
CY
149142011-03-14 Chong Yidong <cyd@stupidchicken.com>
14915
c96bbc66 14916 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14917
cffc6f3b
CY
149182011-03-13 Chong Yidong <cyd@stupidchicken.com>
14919
14920 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14921 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14922 These macros can no longer be used for assignment.
14923
44f230aa
SM
14924 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14925 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14926 (record_buffer_markers, fetch_buffer_markers): New functions for
14927 recording and fetching special buffer markers.
14928 (set_buffer_internal_1, set_buffer_temp): Use them.
14929
14930 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14931
14932 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14933
14934 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14935 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14936
14937 * xdisp.c (hscroll_window_tree):
14938 (reconsider_clip_changes): Use PT instead of BUF_PT.
14939
d251f04b
EZ
149402011-03-13 Eli Zaretskii <eliz@gnu.org>
14941
14942 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14943 $(EMACS_ROOT)/lib/intprops.h.
14944
f0c77cd1
PE
149452011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14946
3eca4629
PE
14947 Fix more problems found by GCC 4.5.2's static checks.
14948
7c86ee98
PE
14949 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14950 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14951 (xg_free_frame_widgets): Make it clear that a local variable is
14952 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14953 (gdk_window_get_screen): Make it clear that this macro is needed
14954 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14955 (int_gtk_range_get_value): New function, which avoids a diagnostic
14956 from gcc -Wbad-function-cast.
14957 (xg_set_toolkit_scroll_bar_thumb): Use it.
14958 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14959 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14960 (get_utf8_string, xg_get_file_with_chooser):
14961 Rename locals to avoid shadowing.
14962 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14963
41729b81
PE
14964 * xgselect.c (xg_select): Remove unused var.
14965
f0c77cd1
PE
14966 * image.c (four_corners_best): Mark locals as initialized.
14967 (gif_load): Initialize transparent_p to zero (Bug#8238).
14968 Mark another local as initialized.
ec6cf4c6 14969 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14970
ce0ad53d 14971 * image.c (clear_image_cache): Now static.
d5d5a617 14972 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14973 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14974 (x_edge_detection): Remove unnecessary cast that
14975 gcc -Wbad-function-cast diagnoses.
2037898d 14976 (gif_load): Fix pointer signedness.
6ae141d6
PE
14977 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14978 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14979
33383987 149802011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14981
d32df629
PE
14982 Improve quality of tests for time stamp overflow.
14983 For example, without this patch (encode-time 0 0 0 1 1
14984 1152921504606846976) returns the obviously-bogus value (-948597
14985 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14986 reports time overflow. See
14987 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14988 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14989 * editfns.c: Include limits.h and intprops.h.
14990 (TIME_T_MIN, TIME_T_MAX): New macros.
14991 (time_overflow): Move earlier, to before first use.
14992 (hi_time, lo_time): New functions, for an accurate test for
14993 out-of-range times.
14994 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14995 (Fget_internal_run_time): Don't assume time_t fits in int.
14996 (make_time): Use list2 instead of Fcons twice.
14997 (Fdecode_time): More accurate test for out-of-range times.
14998 (check_tm_member): New function.
14999 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15000 (lisp_time_argument): Don't rely on undefined left-shift and
15001 right-shift behavior when checking for time stamp overflow.
8be6f318 15002
fe31d94c
PE
15003 * editfns.c (time_overflow): New function, refactoring common code.
15004 (Fformat_time_string, Fdecode_time, Fencode_time):
15005 (Fcurrent_time_string): Use it.
15006
8be6f318
PE
15007 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15008 * dired.c (make_time): Move to ...
15009 * editfns.c (make_time): ... here.
15010 * systime.h: Note the move.
15011
09d9db2c 150122011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15013
126bc0dc
YM
15014 * fringe.c (update_window_fringes): Remove unused variables.
15015
c47cbdfd
YM
15016 * unexmacosx.c (copy_data_segment): Also copy __got section.
15017 (Bug#8223)
15018
7ac80be9
EZ
150192011-03-12 Eli Zaretskii <eliz@gnu.org>
15020
c96bbc66 15021 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15022 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15023 Constify `char *' arguments and their references according to
15024 prototypes in tparam.h.
15025
ecb0f94d 15026 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15027
7ac80be9
EZ
15028 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15029 Adapt all references accordingly.
15030
15031 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15032
ef1fd07e
TT
150332011-03-11 Tom Tromey <tromey@redhat.com>
15034
15035 * buffer.c (syms_of_buffer): Remove obsolete comment.
15036
7ef4b50c
EZ
150372011-03-11 Eli Zaretskii <eliz@gnu.org>
15038
15039 * termhooks.h (encode_terminal_code): Declare prototype.
15040
15041 * msdos.c (encode_terminal_code): Don't declare prototype.
15042
15043 * term.c (encode_terminal_code): Now external again, used by
15044 w32console.c and msdos.c.
15045
44f230aa
SM
15046 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15047 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15048
4b1ec863 150492011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15050
1714f52b 15051 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15052
4b1ec863
PE
15053 * fringe.c (update_window_fringes): Mark locals as initialized
15054 (Bug#8227).
15055 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15056
524c7aa6
PE
15057 * alloc.c (mark_fringe_data): Move decl from here ...
15058 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15059 to check its interface.
15060 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15061
a5c0af81 15062 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15063 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15064 (fontset_font): Mark local as initialized.
a9a06e0b 15065 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15066
b4716021
PE
15067 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15068
811e9bac 15069 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15070 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15071 (x_own_selection, Fx_disown_selection_internal): Rename locals
15072 to avoid shadowing.
15073 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15074
7e3ab302
PE
15075 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15076 so that the caller can use some name other than gcpro1.
15077 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15078 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15079 (Fx_backspace_delete_keys_p):
15080 Use them to avoid shadowing, and rename vars to avoid shadowing.
15081 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15082 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15083 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15084 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15085 Remove unused locals.
7e3ab302
PE
15086 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15087 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15088 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15089 macros.
f78faa98 15090
e2b13473
PE
15091 * xterm.h (x_mouse_leave): New decl.
15092
77f23912
PE
15093 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15094 Remove unused functions.
cdf4ba58
PE
15095 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15096 (x_calc_absolute_position): Now static.
7411c686 15097 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15098 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15099 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15100 unless they are used.
38d0b34a
PE
15101 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15102 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15103 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15104 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15105 (x_error_catcher, x_connection_closed, x_error_handler):
15106 (x_error_quitter, xembed_send_message, x_iconify_frame):
15107 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15108 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15109 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15110
44f230aa
SM
15111 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15112 Rename or move locals to avoid shadowing.
6b463e58 15113 (tty_defined_color, merge_face_heights): Now static.
5967d051 15114 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15115 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15116 does not deduce is never used uninitialized.
73719eba
PE
15117 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15118 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15119
426994c3 15120 * terminal.c (store_terminal_param): Now static.
5489860b 15121
032f1620 15122 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15123 (set_frame_menubar): Remove unused local.
d4323972 15124 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15125 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15126 since they might point to immutable storage.
281585b0
PE
15127 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15128 since it's unused otherwise.
032f1620 15129
367c19e5 15130 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15131 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15132 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15133 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15134 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15135 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15136 does not deduce are never used uninitialized.
70739cbe 15137
07b48fa9
PE
15138 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15139
8868a238 15140 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15141 * window.c (window_loop, size_window):
15142 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15143
7e5cf297 15144 * window.c (display_buffer): Now static.
d6550a9f
PE
15145 (size_window): Mark variables that gcc -Wuninitialized
15146 does not deduce are never used uninitialized.
a586633d
PE
15147 * window.h (check_all_windows): New decl, to forestall
15148 gcc -Wmissing-prototypes diagnostic.
5b555da1 15149 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15150
f6095868
PE
15151 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15152 shadowing.
15153 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15154 Include <limits.h>.
15155 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15156 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15157 (load_charset_map): Mark variables that gcc -Wuninitialized
15158 does not deduce are never used uninitialized.
53df7c11 15159 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15160
f38b440c
PE
15161 * coding.c (coding_set_source, coding_set_destination):
15162 Use "else { /* comment */ }" rather than "else /* comment */;"
15163 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15164 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15165 a block, when the outer 'i' will do.
15166 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15167 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15168 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15169 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15170 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15171 Rename locals to avoid shadowing.
15172 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15173 * coding.c (emacs_mule_char, encode_invocation_designation):
15174 Now static, since they're not used elsewhere.
413bb2db 15175 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15176 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15177 (decode_coding_emacs_mule): Mark variables that gcc
15178 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15179 (detect_coding_iso_2022): Initialize a local variable that might
15180 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15181 this initialization is needed. (Bug#8211)
5f58e762
PE
15182 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15183 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15184 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15185 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15186 Remove unused macros.
f38b440c 15187
232b38b9 15188 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15189 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15190 * character.c (string_count_byte8): Likewise.
232b38b9 15191
fb90da1b
PE
15192 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15193 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15194
fb93dbc2
PE
15195 * chartab.c (copy_sub_char_table): Now static, since it's not used
15196 elsewhere.
5c156ace
PE
15197 (sub_char_table_ref_and_range, char_table_ref_and_range):
15198 Rename locals to avoid shadowing.
bbcd0949 15199 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15200
7d3b3862 15201 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15202 (BIDI_BOB): Remove unused macro.
7d3b3862 15203
6be7d3da
PE
15204 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15205 deduce are never used uninitialized.
c2ed9c8b 15206 * term.c (encode_terminal_code): Likewise.
6be7d3da 15207
75f8807f 15208 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15209
50938595
PE
15210 * tparam.h: New file.
15211 * term.c, tparam.h: Include it.
15212 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15213 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15214 Move these decls to tparam.h, and make them agree with what
15215 is actually in tparam.c. The previous trick of using incompatible
15216 decls in different modules does not conform to the C standard.
15217 All callers of tparam changed to use tparam's actual API.
15218 * tparam.c (tparam1, tparam, tgoto):
15219 Use const pointers where appropriate.
15220
fbceeba2
PE
15221 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15222 * cm.h (struct cm): Likewise.
15223 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15224 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15225 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15226 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15227 (turn_on_face, init_tty): Likewise.
15228 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15229
7f3f1250
PE
15230 * term.c (term_mouse_position): Rename local to avoid shadowing.
15231
e6ca6543
PE
15232 * alloc.c (mark_ttys): Move decl from here ...
15233 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15234
c40f8d15
AS
152352011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15236
15237 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15238
cfe0661d
JB
152392011-03-09 Juanma Barranquero <lekktu@gmail.com>
15240
15241 * search.c (compile_pattern_1): Remove argument regp, unused since
15242 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15243 (compile_pattern): Don't pass it.
15244
0afb4571
J
152452011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15246
15247 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15248 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15249 for ! HAVE_GTK3.
15250 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15251
15252 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15253
15254 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15255 gdk_window_get_screen, gdk_window_get_geometry,
15256 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15257 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15258 (xg_get_pixbuf_from_pixmap): New function.
15259 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15260 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15261 Call xg_get_pixbuf_from_pixmap instead of
15262 gdk_pixbuf_get_from_drawable.
15263 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15264 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15265 (xg_check_special_colors): Use GtkStyleContext and its functions
15266 for HAVE_GTK3.
15267 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15268 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15269 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15270 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15271 Call gtk_widget_get_preferred_size.
0afb4571
J
15272 (xg_frame_resized): gdk_window_get_geometry only takes 5
15273 parameters.
44f230aa
SM
15274 (xg_win_to_widget, xg_event_is_for_menubar):
15275 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15276 (xg_set_widget_bg): New function.
15277 (delete_cb): New function.
895009e1 15278 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15279 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15280 (xg_set_background_color): Call xg_set_widget_bg.
15281 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15282 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15283 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15284 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15285 if ! HAVE_GTK3.
15286 (update_frame_tool_bar): Call gtk_widget_hide.
15287 (xg_initialize): Use GDK_KEY_g.
15288
15289 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15290 if ! HAVE_GTK3
15291 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15292
15293 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15294 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15295 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15296
1c2cc4ef
JB
152972011-03-08 Juanma Barranquero <lekktu@gmail.com>
15298
15299 * w32xfns.c (select_palette): Check success of RealizePalette against
15300 GDI_ERROR, not zero.
15301
33383987 15302See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15303
15304;; Local Variables:
15305;; coding: utf-8
aac0c6e3
MR
15306;; End:
15307
2f097256 15308 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15309
15310 This file is part of GNU Emacs.
15311
15312 GNU Emacs is free software: you can redistribute it and/or modify
15313 it under the terms of the GNU General Public License as published by
15314 the Free Software Foundation, either version 3 of the License, or
15315 (at your option) any later version.
15316
15317 GNU Emacs is distributed in the hope that it will be useful,
15318 but WITHOUT ANY WARRANTY; without even the implied warranty of
15319 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15320 GNU General Public License for more details.
15321
15322 You should have received a copy of the GNU General Public License
15323 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.