Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
96fb4434
PE
12011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2
3 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4 This makes this file independent of the recent pseudovector change.
5
671875da 62011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7
69e9b5a3
PE
8 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9
b5f869a7 10 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12 Remove unused local.
c8926152 13 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 14
847ab9d1 15 lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
16 GCC 4.6.0 optimizes based on type-based alias analysis. For
17 example, if b is of type struct buffer * and v of type struct
18 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
19 != &v->size, and therefore "v->size = 1; b->size = 2; return
20 v->size;" must therefore return 1. This assumption is incorrect
21 for Emacs, since it type-puns struct Lisp_Vector * with many other
22 types. To fix this problem, this patch adds a new type struct
f904488f 23 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
24 and pseudovectors, and helps optimizing compilers not get fooled
25 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
26 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
27 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
28 the size member.
eab3844f
PE
29 (XSETPVECTYPE): Rewrite in terms of new macro.
30 (XSETPVECTYPESIZE): New macro, specifying both type and size.
31 This is a bit clearer, and further avoids the possibility of
32 undesirable aliasing.
33 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 34 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
35 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
36 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
37 (ASIZE): Now uses header.size rather than size. All
38 previous uses of XVECTOR (foo)->size replaced to use this macro,
39 to avoid the hassle of writing XVECTOR (foo)->header.size.
40 (struct vectorlike_header): New type.
eab3844f
PE
41 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
42 object, to help avoid aliasing.
43 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
44 (SUBRP): Likewise, since Lisp_Subr is a special case.
45 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
46 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
47 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 48 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
49 changed to be "header.size" and "header.next".
50 * buffer.h (struct buffer): Likewise.
51 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
52 * frame.h (struct frame): Likewise.
53 * process.h (struct Lisp_Process): Likewise.
54 * termhooks.h (struct terminal): Likewise.
55 * window.c (struct save_window_data, struct saved_window): Likewise.
56 * window.h (struct window): Likewise.
57 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
58 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
59 * buffer.c (init_buffer_once): Likewise.
60 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
61 special case.
62 * process.c (Fformat_network_address): Use local var for size,
63 for brevity.
64
0df1eac5
PE
65 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
66
847ab9d1 67 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
68 * data.c (atof): Remove decl; no longer used or needed.
69 (digit_to_number): Move to lread.c.
70 (Fstring_to_number): Use new string_to_number function, to be
71 consistent with how the Lisp reader treats infinities and NaNs.
72 Do not assume that floating-point numbers represent EMACS_INT
73 without losing information; this is not true on most 64-bit hosts.
74 Avoid double-rounding errors, by insisting on integers when
75 parsing non-base-10 numbers, as the documentation specifies.
76 * lisp.h (string_to_number): New decl, replacing ...
77 (isfloat_string): Remove.
bc0a5c13 78 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 79 (read1): Do not accept +. and -. as integers; this
452f4150
PE
80 appears to have been a coding error. Similarly, do not accept
81 strings like +-1e0 as floating point numbers. Do not report
82 overflow for integer overflows unless the base is not 10 which
83 means we have no simple and reliable way to continue.
84 Break out the floating-point parsing into a new
85 function string_to_number, so that Fstring_to_number parses
86 floating point numbers consistently with the Lisp reader.
87 (digit_to_number): Moved here from data.c. Make it static inline.
88 (E_CHAR, EXP_INT): Remove, replacing with ...
89 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
90 (string_to_number): New function, replacing isfloat_string.
91 This function checks for valid syntax and produces the resulting
92 Lisp float number too. Rework it so that string-to-number
bc0a5c13 93 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
94 so that overflow for non-base-10 numbers is reported only when
95 there's no portable and simple way to convert to floating point.
452f4150 96
67769ffc
PE
97 * textprop.c (set_text_properties_1): Rewrite for clarity,
98 and to avoid GCC warning about integer overflow.
99
c20db43f
PE
100 * intervals.h (struct interval): Use EMACS_INT for members
101 where EMACS_UINT might cause problems. See
102 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
103 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
104 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
105 All uses changed.
37aa2f85
PE
106 (offset_intervals): Tell GCC not to worry about length overflow
107 when negating a negative length.
c20db43f 108
2538aa2f
PE
109 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
110 (overrun_check_free): Likewise.
111
f2d3008d
PE
112 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
113 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
114 word size.
115
ec8df744
PE
116 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
117 (gnutls_make_error): Rename local to avoid shadowing.
118 (gnutls_emacs_global_deinit): ifdef out; not used.
119 (Fgnutls_boot): Use const for pointer to readonly storage.
120 Comment out unused local. Fix pointer signedness problems.
121
640ee02d
PE
122 * lread.c (openp): Don't stuff size_t into an 'int'.
123 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
124 about possible signed overflow.
125
6048fb2a
PE
126 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
127 (GDK_KEY_g): Don't define if already defined.
128 (xg_prepare_tooltip): Avoid pointer signedness problem.
129 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
130
fa3c87e1
PE
131 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
132 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
133
2172544b
PE
134 * xfns.c (Fx_window_property): Simplify a bit,
135 to make a bit faster and to avoid GCC 4.6.0 warning.
136 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
137
9b821a21
PE
138 * fns.c (internal_equal): Don't assume size_t fits in int.
139
3c616cfa
PE
140 * alloc.c (compact_small_strings): Tighten assertion a little.
141
c2982e87
PE
142 Replace pEd with more-general pI, and fix some printf arg casts.
143 * lisp.h (pI): New macro, generalizing old pEd macro to other
144 conversion specifiers. For example, use "...%"pI"d..." rather
145 than "...%"pEd"...".
146 (pEd): Remove. All uses replaced with similar uses of pI.
147 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
148 * alloc.c (check_pure_size): Don't overflow by converting size to int.
149 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
150 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
151 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
152 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
153 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
154 64-bit hosts.
155 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
156 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
157 * print.c (safe_debug_print, print_object): Likewise.
158 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
159 to int.
6f04d126
PE
160 Use pI instead of if-then-else-abort. Use %p to avoid casts,
161 avoiding the 0 flag, which is not portable.
c2982e87
PE
162 * process.c (Fmake_network_process): Use pI to avoid cast.
163 * region-cache.c (pp_cache): Likewise.
164 * xdisp.c (decode_mode_spec): Likewise.
165 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
166 behavior on 64-bit hosts with printf arg.
6f04d126 167 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
168 (x_stop_queuing_selection_requests): Likewise.
169 (x_get_window_property): Don't truncate byte count to an 'int'
170 when tracing.
0b432f21 171
5e073ec7
PE
172 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
173 here, since it parses constructs like leading '-' and spaces,
174 which are not wanted; and it overflows with large numbers.
175 Instead, simply match F[0-9]+, which is what is wanted anyway.
176
36372bf9
PE
177 * alloc.c: Remove unportable assumptions about struct layout.
178 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
179 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
180 (allocate_vectorlike, make_pure_vector): Use the new macros,
181 plus offsetof, to remove unportable assumptions about struct layout.
182 These assumptions hold on all porting targets that I know of, but
183 they are not guaranteed, they're easy to remove, and removing them
184 makes further changes easier.
185
0b432f21
PE
186 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
187 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
188 (string_overrun_cookie): Now const. Use initializers that
189 don't formally overflow signed char, to avoid warnings.
000098c1
PE
190 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
191 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
192 (allocate_buffer): Don't assume sizeof (struct buffer) is a
193 multiple of sizeof (EMACS_INT); it need not be, if
194 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 195 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 196
895009e1
JB
1972011-04-26 Juanma Barranquero <lekktu@gmail.com>
198
199 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
200
6a7a1b0b
TZ
2012011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
202
203 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 204 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
205 Reported by Paul Eggert <eggert@cs.ucla.edu>.
206
0438ce91
DC
2072011-04-26 Daniel Colascione <dan.colascione@gmail.com>
208
209 * lisp.h (Qdebug): List symbol.
895009e1 210 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
211 * keyboard.c (debug-on-event): New variable.
212 (handle_user_signal): Break into debugger when debug-on-event
213 matches the current signal symbol.
214
f2d3ba6f
DN
2152011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
216
217 * alloc.c (check_sblock, check_string_bytes)
218 (check_string_free_list): Convert to standard C.
219
42ce4c63
TZ
2202011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
221
222 * w32.c (emacs_gnutls_push): Fix typo.
223
825cd63c
EZ
2242011-04-25 Eli Zaretskii <eliz@gnu.org>
225
fb11d64d
EZ
226 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
227 "cast to pointer from integer of different size".
228
825cd63c
EZ
229 Improve doprnt and its use in verror. (Bug#8545)
230 * doprnt.c (doprnt): Document the set of format control sequences
231 supported by the function. Use SAFE_ALLOCA instead of always
232 using `alloca'.
233
234 * eval.c (verror): Don't limit the buffer size at size_max-1, that
235 is one byte too soon. Don't use xrealloc; instead xfree and
236 xmalloc anew.
237
e061a11b
TZ
2382011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
239
240 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
241 callbacks stage.
242
243 * gnutls.c: Renamed global_initialized to
244 gnutls_global_initialized. Added internals for the
245 :verify-hostname-error, :verify-error, and :verify-flags
246 parameters of `gnutls-boot' and documented those parameters in the
247 docstring. Start callback support.
248 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
249 unless a fatal error occured. Call gnutls_alert_send_appropriate
250 on error. Return error code.
251 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
252 (emacs_gnutls_read): Likewise.
253 (Fgnutls_boot): Return handshake error code.
254 (emacs_gnutls_handle_error): New function.
255 (wsaerror_to_errno): Likewise.
256
257 * w32.h (emacs_gnutls_pull): Add prototype.
258 (emacs_gnutls_push): Likewise.
259
260 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
261 (emacs_gnutls_push): Likewise.
262
2632011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
264
265 * process.c (wait_reading_process_output): Check if GnuTLS
266 buffered some data internally if no FDs are set for TLS
267 connections.
268
269 * makefile.w32-in (OBJ2): Add gnutls.$(O).
270 (LIBS): Link to USER_LIBS.
271 ($(BLD)/gnutls.$(0)): New target.
272
fa6996bc
EZ
2732011-04-24 Eli Zaretskii <eliz@gnu.org>
274
eb35682e
EZ
275 * xdisp.c (handle_single_display_spec): Rename the
276 display_replaced_before_p argument into display_replaced_p, to
277 make it consistent with the commentary. Fix typos in the
278 commentary.
279
e2ad650c
EZ
280 * textprop.c (syms_of_textprop): Remove dead code.
281 (copy_text_properties): Delete obsolete commentary about an
282 interface that was deleted long ago. Fix typos in the description
283 of arguments.
284
1b2de274
EZ
285 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
286 to changes in oldXMenu/XMenu.h from 2011-04-16.
287 <menu_help_message, prev_menu_help_message>: Constify.
288 (IT_menu_make_room): menu->help_text is now `const char **';
289 adjust.
290
291 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
292 to changes in oldXMenu/XMenu.h from 2011-04-16.
293 (struct XMenu): Declare `help_text' `const char **'.
294
295 * xfaces.c <Qunspecified>: Make extern again.
296
297 * syntax.c: Include sys/types.h before including regex.h, as
298 required by Posix.
299
762b15be
EZ
300 * doc.c (get_doc_string): Improve the format passed to `error'.
301
302 * doprnt.c (doprnt): Improve commentary.
303
304 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
305
306 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
307 them with etags.
308
f1052e5d
EZ
309 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
310 changes in globals.h immediately force recompilation.
762b15be
EZ
311 (TAGS): Depend on $(CURDIR)/m/intel386.h and
312 $(CURDIR)/s/ms-w32.h.
313 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 314
fa6996bc
EZ
315 * character.c (Fchar_direction): Function deleted.
316 (syms_of_character): Don't defsubr it.
317 <char-direction-table>: Deleted.
318
e6c3da20
EZ
3192011-04-23 Eli Zaretskii <eliz@gnu.org>
320
321 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
322 * doprnt.c: Include limits.h.
323 (SIZE_MAX): New macro.
324 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
325 local variables are now size_t instead of int or unsigned.
326 Improve overflow protection. Support `l' modifier for integer
327 conversions. Support %l conversion. Don't assume an EMACS_INT
328 argument for integer conversions and for %c.
329
330 * lisp.h (doprnt): Restore prototype.
331
332 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
333 $(SRC)/character.h.
334
335 * Makefile.in (base_obj): Add back doprnt.o.
336
337 * deps.mk (doprnt.o): Add back prerequisites.
338 (callint.o): Depend on character.h.
339
340 * eval.c (internal_lisp_condition_case): Include the handler
341 representation in the error message.
342 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
343 when breaking from the loop.
344
345 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
346
347 * callint.c (Fcall_interactively): When displaying error message
348 about invalid control letter, pass the character's codepoint, not
349 a pointer to its multibyte form. Improve display of the character
350 in octal and display also its hex code.
351
352 * character.c (char_string): Use %x to display the (unsigned)
353 codepoint of an invalid character, to avoid displaying a bogus
354 negative value.
355
356 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
357 `error', not SYMBOL_NAME itself.
358
359 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
360 character arguments to `error'.
361
362 * charset.c (check_iso_charset_parameter): Fix incorrect argument
363 to `error' in error message about FINAL_CHAR argument. Make sure
364 FINAL_CHAR is a character, and use %c when it is passed as
365 argument to `error'.
366
4ffd0d6b 3672011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
368
369 * s/ms-w32.h (localtime): Redirect to sys_localtime.
370
371 * w32.c: Include <time.h>.
372 (sys_localtime): New function.
373
4ffd0d6b 3742011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
375
376 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
377
4ffd0d6b 378 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 379
4ffd0d6b 3802011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 381
4ffd0d6b
GM
382 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
383 zombies (Bug#8467).
aac0c6e3 384
04c56954
EZ
3852011-04-19 Eli Zaretskii <eliz@gnu.org>
386
387 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
388 gl_state.e_property when gl_state.object is Qt.
389
390 * insdel.c (make_gap_larger): Remove limitation of buffer size
391 to <= INT_MAX.
392
16a43933
CY
3932011-04-18 Chong Yidong <cyd@stupidchicken.com>
394
395 * xdisp.c (lookup_glyphless_char_display)
396 (produce_glyphless_glyph): Handle cons cell entry in
397 glyphless-char-display.
398 (Vglyphless_char_display): Document it.
399
400 * term.c (produce_glyphless_glyph): Handle cons cell entry in
401 glyphless-char-display.
402
4581706e
CY
4032011-04-17 Chong Yidong <cyd@stupidchicken.com>
404
405 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
406
407 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
408
409 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
410 definition for no-X builds.
411
4887c6e2 4122011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 413
fd35b6f9
PE
414 Static checks with GCC 4.6.0 and non-default toolkits.
415
5c1ccb01
PE
416 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
417
006c5daa
PE
418 * process.c (keyboard_bit_set): Define only if SIGIO.
419 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
420 (send_process): Repair possible setjmp clobbering.
421
efc736d3
PE
422 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
423
4e2fe2e6
PE
424 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
425
f97334a2
PE
426 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
427
4e75f29d
PE
428 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
429 Define only if needed.
430
90efadd1
PE
431 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
432 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 433 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 434
3c647824
PE
435 * dispextern.h (struct redisplay_interface): Rename param
436 to avoid shadowing.
e264f262 437 * termhooks.h (struct terminal): Likewise.
761383f4 438 * xterm.c (xembed_send_message): Likewise.
3c647824 439
b58c5c4a
PE
440 * insdel.c (make_gap_smaller): Define only if
441 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
442
cad59032
PE
443 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
444 it.
445
c339dc2e
PE
446 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
447 so that we aren't warned about unused symbols.
448
91a3e27b
PE
449 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
450
399c71d3 451 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 452
8ffc96f5
PE
453 * xfns.c (x_real_positions): Mark locals as initialized.
454
eef9bc79
PE
455 * xmenu.c (xmenu_show): Don't use uninitialized vars.
456
098db9dd
PE
457 * xterm.c: Fix problems found by static analysis with other toolkits.
458 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
459 (x_dispatch_event): Declare static if USE_GTK, and
460 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 461 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 462 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
463 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
464 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
465
eb18f6cc
PE
466 * xmenu.c (menu_help_callback): Pointer type fixes.
467 Use const pointers when pointing at readonly data. Avoid pointer
468 signedness clashes.
469 (FALSE): Remove unused macro.
470 (update_frame_menubar): Remove unused decl.
471
1fe72bf8
PE
472 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
473
60d9e1db
PE
474 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
475 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
476 (single_menu_item): Rename local to avoid shadowing.
477
39261c26
PE
478 * keyboard.c (make_lispy_event): Remove unused local var.
479
018c5e19
PE
480 * frame.c, frame.h (x_get_resource_string): Bring this back, but
481 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
482
63d2b86e
PE
483 * bitmaps: Change bitmaps from unsigned char back to the X11
484 compatible char. Avoid the old compiler warnings about
485 out-of-range initializers by using, for example, '\xab' rather
486 than 0xab.
487
aefd87e1
PE
488 * xgselect.c (xgselect_initialize): Check vs interface
489 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
490
bf501fb9
PE
491 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
492
e9829fdf
PE
493 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
494 to read-only memory.
495
1086c095
PE
496 * fns.c (vector): Remove; this old hack is no longer needed.
497
2baccd04 498 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 499 Remove unused var.
dde42981 500 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 501
72391843 502 * xrdb.c (x_load_resources): Omit unused local.
3565b346 503
436c16df 504 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 505 (x_window): Rename locals to avoid shadowing.
dc5ddd85 506 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 507
92bb796d 508 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 509 (x_term_init): Remove local to avoid shadowing.
92bb796d 510
764430a3 511 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
512
513 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
514 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
515
d1dfb56c
EZ
5162011-04-16 Eli Zaretskii <eliz@gnu.org>
517
c4354cb4
EZ
518 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
519
d1dfb56c
EZ
520 Fix regex.c, syntax.c and friends for buffers > 2GB.
521 * syntax.h (struct gl_state_s): Declare character position members
522 EMACS_INT.
523
524 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
525
526 * textprop.c (verify_interval_modification, interval_of): Declare
527 arguments EMACS_INT.
528
529 * intervals.c (adjust_intervals_for_insertion): Declare arguments
530 EMACS_INT.
531
532 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
533
534 * indent.c (Fvertical_motion): Local variable it_start is now
535 EMACS_INT.
536
537 * regex.c (re_match, re_match_2, re_match_2_internal)
538 (bcmp_translate, regcomp, regexec, print_double_string)
539 (group_in_compile_stack, re_search, re_search_2, regex_compile)
540 (re_compile_pattern, re_exec): Declare arguments and local
541 variables `size_t' and `ssize_t' and return values `regoff_t', as
542 appropriate.
543 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
544 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
545 <compile_stack_type>: `size' and `avail' are now `size_t'.
546
547 * regex.h <regoff_t>: Use ssize_t, not int.
548 (re_search, re_search_2, re_match, re_match_2): Arguments that
549 specify buffer/string position and length are now ssize_t and
550 size_t. Return type is regoff_t.
551
613052cd
BK
5522011-04-16 Ben Key <bkey76@gmail.com>
553
554 * nsfont.m: Fixed bugs in ns_get_family and
555 ns_descriptor_to_entity that were caused by using free to
556 deallocate memory blocks that were allocated by xmalloc (via
557 xstrdup). This caused Emacs to crash when compiled with
558 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
559 --enable-checking=xmallocoverrun). xfree is now used to
560 deallocate these memory blocks.
561
4170f62f 5622011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 563
71b41406
PE
564 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
565
9587a89d
PE
566 emacs_write: Accept and return EMACS_INT for sizes.
567 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
568 et seq.
569 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
570 Accept and return EMACS_INT.
571 (emacs_gnutls_write): Return the number of bytes written on
572 partial writes.
573 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
574 (emacs_read, emacs_write): Remove check for negative size, as the
575 Emacs source code has been audited now.
9587a89d
PE
576 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
577 (emacs_read, emacs_write): Use it.
273a5f82
PE
578 * process.c (send_process): Adjust to the new signatures of
579 emacs_write and emacs_gnutls_write. Do not attempt to store
580 a byte offset into an 'int'; it might overflow.
9587a89d 581 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 582
3e047f51
PE
583 * sound.c: Don't assume sizes fit in 'int'.
584 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 585 Return EMACS_INT, not int.
3e047f51 586 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
587 Accept EMACS_INT, not int.
588 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
589 record read return values.
590
cc39a9db
BK
5912011-04-15 Ben Key <bkey76@gmail.com>
592
c9d0ec6d
JB
593 * keyboard.c (Qundefined): Don't declare static since it is used
594 in nsfns.m.
595 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
596 static since they are used in nsfont.m.
cc39a9db 597
6c60eb9f
SM
5982011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
599
600 * process.c (Qprocessp): Don't declare static.
601 * lisp.h (Qprocessp): Declare again.
602
7990b61a
JB
6032011-04-15 Juanma Barranquero <lekktu@gmail.com>
604
605 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
606
5d4cb038
PE
6072011-04-14 Paul Eggert <eggert@cs.ucla.edu>
608
8bd7b830 609 Improve C-level modularity by making more things 'static'.
cd64ea1d 610
e3b27b31
PE
611 Don't publish debugger-only interfaces to other modules.
612 * lisp.h (safe_debug_print, debug_output_compilation_hack):
613 (verify_bytepos, count_markers): Move decls to the only modules
614 that need them.
615 * region-cache.h (pp_cache): Likewise.
616 * window.h (check_all_windows): Likewise.
617 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
618
5d4cb038
PE
619 * sysdep.c (croak): Now static, if
620 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
621 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
622
623 * alloc.c (refill_memory_reserve): Now static if
624 !defined REL_ALLOC || defined SYSTEM_MALLOC.
625 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 626
e87b6180
PE
627 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
628 Define only if USE_LUCID.
629
ac64929e
PE
630 * xrdb.c (x_customization_string, x_rm_string): Now static.
631
6f37259d
PE
632 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
633 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
634
1683e3ab
PE
635 * xdisp.c (draw_row_with_mouse_face): Now static.
636 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
637
de9c2632
PE
638 * window.h (check_all_windows): Mark externally visible.
639
2b96acb7
PE
640 * window.c (window_deletion_count): Now static.
641
642 * undo.c: Make symbols static if they're not exported.
643 (last_undo_buffer, last_boundary_position, pending_boundary):
644 Now static.
645
50436f33
PE
646 * textprop.c (interval_insert_behind_hooks): Now static.
647 (interval_insert_in_front_hooks): Likewise.
648
64520e5c
PE
649 * term.c: Make symbols static if they're not exported.
650 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
651 (max_frame_lines, tty_set_terminal_modes):
652 (tty_reset_terminal_modes, tty_turn_off_highlight):
653 (get_tty_terminal): Now static.
654 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
655 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 656 HAVE_WINDOW_SYSTEM.
64520e5c
PE
657 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
658 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
659
1fa53021
PE
660 * sysdep.c: Make symbols static if they're not exported.
661 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
662 Now static.
663 (sigprocmask_set, full_mask): Remove; unused.
664 (wait_debugging): Mark as visible.
665 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
666 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
667
d4b43b22
PE
668 * syntax.c (syntax_temp): Define only if !__GNUC__.
669
b7c513d0
PE
670 * sound.c (current_sound_device, current_sound): Now static.
671
989b29ad
PE
672 * search.c (searchbufs, searchbuf_head): Now static.
673
13a55a78
PE
674 * scroll.c (scroll_cost): Remove; unused.
675 * dispextern.h (scroll_cost): Remove decl.
676
de68a1fc
PE
677 * region-cache.h (pp_cache): Mark as externally visible.
678
40ccffa6
PE
679 * process.c: Make symbols static if they're not exported.
680 (process_tick, update_tick, create_process, chan_process):
681 (Vprocess_alist, proc_buffered_char, datagram_access):
682 (fd_callback_data, send_process_frame, process_sent_to): Now static.
683 (deactivate_process): Mark defn as static, as well as decl.
684 * lisp.h (create_process): Remove decl.
685 * process.h (chan_process, Vprocess_alist): Remove decls.
686
ad64fc97
PE
687 * print.c: Make symbols static if they're not exported.
688 (print_depth, new_backquote_output, being_printed, print_buffer):
689 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
690 (print_interval, print_number_index, initial_stderr_stream):
691 Now static.
692 * lisp.h (Fprinc): Remove decl.
693 (debug_output_compilation_hack): Mark as externally visible.
694
adddb265
PE
695 * sysdep.c (croak): Move decl from here to syssignal.h.
696 * syssignal.h (croak): Put it here, so the API can be checked when
697 'croak' is called from dissociate_if_controlling_tty.
698
1717ede2
PE
699 * minibuf.c: Make symbols static if they're not exported.
700 (minibuf_save_list, choose_minibuf_frame): Now static.
701 * lisp.h (choose_minibuf_frame): Remove decl.
702
fa5fb2bc
PE
703 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
704
1e3890d1
PE
705 * lread.c: Make symbols static if they're not exported.
706 (read_objects, initial_obarray, oblookup_last_bucket_number):
707 Now static.
708 (make_symbol): Remove; unused.
709 * lisp.h (initial_obarray, make_symbol): Remove decls.
710
8a1414fa
PE
711 * keyboard.c: Make symbols static if they're not exported.
712 (single_kboard, recent_keys_index, total_keys, recent_keys):
713 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
714 (this_single_command_key_start, echoing, last_auto_save):
715 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
716 (command_loop, echo_now, keyboard_init_hook, help_char_p):
717 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
718 (Vlispy_mouse_stem, double_click_count):
719 Now static.
720 (force_auto_save_soon): Define only if SIGDANGER.
721 (ignore_mouse_drag_p): Now static if
722 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
723 (print_help): Remove; unused.
724 (stop_character, last_timer_event): Mark as externally visible.
725 * keyboard.h (ignore_mouse_drag_p): Declare only if
726 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
727 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
728 * lisp.h (echoing): Remove decl.
729 (force_auto_save_soon): Declare only if SIGDANGER.
730 * xdisp.c (redisplay_window): Simplify code, to make it more
731 obvious that ignore_mouse_drag_p is not accessed if !defined
732 USE_GTK && !defined HAVE_NS.
733
93ea6e8f
PE
734 * intervals.c: Make symbols static if they're not exported.
735 (merge_properties_sticky, merge_interval_right, delete_interval):
736 Now static.
737 * intervals.h (merge_interval_right, delete_interval): Remove decls.
738
77382fcc
PE
739 * insdel.c: Make symbols static if they're not exported.
740 However, leave prepare_to_modify_buffer alone. It's never
741 called from outside this function, but that appears to be a bug.
742 (combine_after_change_list, combine_after_change_buffer):
4889fc82 743 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
744 (adjust_after_replace_noundo): Remove; unused.
745 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 746 (signal_before_change): Remove decls.
77382fcc 747
9306c32e
PE
748 * indent.c (val_compute_motion, val_vmotion): Now static.
749
cd44d2eb
PE
750 * image.c: Make symbols static if they're not exported.
751 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
752 if USE_GTK.
753 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
754 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
755
ad9a7a06
PE
756 * fringe.c (standard_bitmaps): Now static.
757 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
758
81626931
PE
759 * frame.c: Make symbols static if they're not exported.
760 (x_report_frame_params, make_terminal_frame): Now static.
761 (get_frame_param): Now static, unless HAVE_NS.
762 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
763 (x_get_resource_string): Remove; not used.
764 * frame.h (make_terminal_frame, x_report_frame_params):
765 (x_get_resource_string); Remove decls.
766 (x_fullscreen_adjust): Declare only if WINDOWSNT.
767 * lisp.h (get_frame_param): Declare only if HAVE_NS.
768
239f9db9
PE
769 * font.c, fontset.c: Make symbols static if they're not exported.
770 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
771 (FACE_SUITABLE_FOR_CHAR_P): Use it.
772 * font.c (font_close_object): Now static.
773 * font.h (font_close_object): Remove.
774 * fontset.c (FONTSET_OBJLIST): Remove.
775 (free_realized_fontset) #if-0 the body, which does nothing.
776 (face_suitable_for_char_p): #if-0, as it's never called.
777 * fontset.h (face_suitable_for_char_p): Remove decl.
778 * xfaces.c (face_at_string_position): Use
779 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
780 since 0 is always ASCII.
781
dfcf3579
PE
782 * fns.c (weak_hash_tables): Now static.
783
5045092b
PE
784 * fileio.c: Make symbols static if they're not exported.
785 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
786 (Vwrite_region_annotation_buffers): Now static.
787
57a96f5c
PE
788 * eval.c: Make symbols static if they're not exported.
789 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
790 * lisp.h (backtrace_list): Remove decl.
791
35f08c38
PE
792 * emacs.c: Make symbols static if they're not exported.
793 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
794 (fatal_error_code, fatal_error_signal_hook, standard_args):
795 Now static.
796 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
797 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
798 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
799 * lisp.h (fatal_error_signal_hook): Remove decl.
800 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
801
f44bd759
PE
802 * editfns.c: Move a (normally-unused) function to its only use.
803 * editfns.c, lisp.h (get_operating_system_release): Remove.
804 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
805 worth the hassle of breaking this out.
806
b532497d
PE
807 * xterm.c: Make symbols static if they're not exported.
808 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
809 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
810 (x_destroy_window, x_delete_display):
811 Now static.
812 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
813 (x_mouse_leave): Remove; unused.
814 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
815 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
816 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
817 Remove decls.
818 (x_mouse_leave): Declare only if WINDOWSNT.
819 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
820 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
821 USE_X_TOOLKIT.
822
1675728f
PE
823 * ftxfont.c: Make symbols static if they're not exported.
824 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
825 HAVE_FREETYPE.
826 * font.h (ftxfont_driver): Likewise.
827
e4cebfca
PE
828 * xfns.c: Make symbols static if they're not exported.
829 (x_last_font_name, x_display_info_for_name):
830 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
831 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
832 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
833 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
834 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
835 (last_show_tip_args): Now static.
836 (xic_defaut_fontset, xic_create_fontsetname): Define only if
837 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
838 (x_screen_planes): Remove; unused.
839 * dispextern.h (x_screen_planes): Remove decl.
840
5bf46f05
PE
841 * dispnew.c: Make symbols static if they're not exported.
842 * dispextern.h (redraw_garbaged_frames, scrolling):
843 (increment_row_positions): Remove.
844 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
845 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
846 Now static.
847 (redraw_garbaged_frames): Remove; unused.
848
435f4c28
PE
849 * xfaces.c: Make symbols static if they're not exported.
850 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
851 Remove decls.
852 * xterm.h (defined_color): Remove decls.
853 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
854 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
855 (menu_face_changed_default, defined_color, free_realized_face):
856 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
857 (ascii_face_of_lisp_face): Remove; unused.
858
8524aef3
PE
859 * xdisp.c: Make symbols static if they're not exported.
860 * dispextern.h (scratch_glyph_row, window_box_edges):
861 (glyph_to_pixel_coords, set_cursor_from_row):
862 (get_next_display_element, set_iterator_to_next):
863 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
864 (show_mouse_face): Remove decls
865 * frame.h (message_buf_print): Likewise.
866 * lisp.h (pop_message, set_message, check_point_in_composition):
867 Likewise.
868 * xterm.h (set_vertical_scroll_bar): Likewise.
869 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
870 (message_buf_print, scratch_glyph_row, displayed_buffer):
871 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
872 (get_next_display_element, show_mouse_face, window_box_edges):
873 (frame_to_window_pixel_xy, check_point_in_composition):
874 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
875 (glyph_to_pixel_coords): Remove; unused.
876
16390cd2
PE
877 * dired.c (file_name_completion): Now static.
878
879 * dbusbind.c (xd_in_read_queued_messages): Now static.
880
a25f4dfa
PE
881 * lisp.h (circular_list_error, FOREACH): Remove; unused.
882 * data.c (circular_list_error): Remove.
883
14a9c8df
PE
884 * commands.h (last_point_position, last_point_position_buffer):
885 (last_point_position_window): Remove decls.
886 * keyboard.c: Make these variables static.
887
74ab6df5
PE
888 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
889 decls.
890 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
891 (iso_code_class, detect_coding, code_convert_region): Now static.
892 (encode_coding_gap): Remove; unused.
893
38dfbee1
PE
894 * chartab.c (chartab_chars, chartab_bits): Now static.
895
a2cb4e63
PE
896 * charset.h (charset_iso_8859_1): Remove decl.
897 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
898 Now static.
899
127198fd
PE
900 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
901 * ccl.c (Vccl_program_table): Now static.
902 (check_ccl_update): Remove; unused.
903
d85b608f
PE
904 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
905 * category.h: ... from here.
906 * category.c (check_category_table, set_category_set): Now static.
907
31cd66f3
PE
908 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
909 * lisp.h: Remove these decls.
910
c358e587
PE
911 * buffer.c (buffer_count): Remove unused var.
912
e78aecca
PE
913 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
914 so that it's not optimized away.
915 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
916 * dispextern.h (bidi_dump_cached_states): Remove, since it's
917 exported only to the debugger.
918
e192d7d3
PE
919 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
920 * atimer.h (run_all_atimers): Removed; not exported.
921
92470028
PE
922 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
923 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
924 was inaccessible from Lisp.
925 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
926 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
927
244ed907
PE
928 alloc.c: Import and export fewer symbols, and remove unused items.
929 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
930 is defined.
931 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
932 it's not optimized away by whole-program optimization.
933 (message_enable_multibyte, free_misc): Remove.
934 (catchlist, handlerlist, mark_backtrace):
935 Declare only if BYTE_MARK_STACK.
936 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
937 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
938 (message_enable_multibyte): Remove decl.
939 (free_misc, interval_free_list, float_block, float_block_index):
940 (n_float_blocks, float_free_list, cons_block, cons_block_index):
941 (cons_free_list, last_marked_index):
942 Now static.
943 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
944 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
945 (mark_backtrace): Define only if BYTE_MARK_STACK.
946 * xdisp.c (message_enable_multibyte): Now static.
947
61c2b50e 948 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
949 This makes it easier for human readers (and static analyzers)
950 to see whether these variables are used from other modules.
951 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
952 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
953 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
954 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
955 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
956 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
957 * xmenu.c, xselect.c:
958 Declare Q* vars static if they are not used in other modules.
959 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
960 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
961 Remove decls of unexported vars.
962 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
963
95c82688
PE
964 * lisp.h (DEFINE_FUNC): Make sname 'static'.
965
16a97296
PE
966 Make Emacs functions such as Fatom 'static' by default.
967 This makes it easier for human readers (and static analyzers)
968 to see whether these functions can be called from other modules.
969 DEFUN now defines a static function. To make the function external
970 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
971 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
972 (Finit_image_library):
16a97296
PE
973 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
974 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
975 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
976 Remove decls, since these functions are now static.
977 (Funintern, Fget_internal_run_time): New decls, since these functions
978 were already external.
95c82688 979
16a97296
PE
980 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
981 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
982 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
983 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
984 * keyboard.c, keymap.c, lread.c:
985 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
986 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
987 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
988 Mark functions with DEFUE instead of DEFUN,
989 if they are used in other modules.
990 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
991 decls for now-static functions.
992 * buffer.h (Fdelete_overlay): Remove decl.
993 * callproc.c (Fgetenv_internal): Mark as internal.
994 * composite.c (Fremove_list_of_text_properties): Remove decl.
995 (Fcomposition_get_gstring): New forward static decl.
996 * composite.h (Fcomposite_get_gstring): Remove decl.
997 * dired.c (Ffile_attributes): New forward static decl.
998 * doc.c (Fdocumntation_property): New forward static decl.
999 * eval.c (Ffetch_bytecode): New forward static decl.
1000 (Funintern): Remove extern decl; now in .h file where it belongs.
1001 * fileio.c (Fmake_symbolic_link): New forward static decl.
1002 * image.c (Finit_image_library): New forward static decl.
1003 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1004 * intervals.h (Fprevious_property_change):
1005 (Fremove_list_of_text_properties): Remove decls.
1006 * keyboard.c (Fthis_command_keys): Remove decl.
1007 (Fcommand_execute): New forward static decl.
1008 * keymap.c (Flookup_key): New forward static decl.
1009 (Fcopy_keymap): Now static.
1010 * keymap.h (Flookup_key): Remove decl.
1011 * process.c (Fget_process): New forward static decl.
1012 (Fprocess_datagram_address): Mark as internal.
1013 * syntax.c (Fsyntax_table_p): New forward static decl.
1014 (skip_chars): Remove duplicate decl.
1015 * textprop.c (Fprevious_property_change): New forward static decl.
1016 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1017 Now internal.
1018 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1019 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1020
785bbd42
PE
1021 * editfns.c (Fformat): Remove unreachable code.
1022
8b913b57
AS
10232011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1024
1025 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1026 change. (Bug#8496)
1027
a6744a35
EZ
10282011-04-13 Eli Zaretskii <eliz@gnu.org>
1029
1030 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1031 when at ZV. (Bug#8487)
1032
e7974947
AS
10332011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1034
baad03f0
AS
1035 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1036 (Bug#8437)
1037 * keyboard.c (parse_tool_bar_item): Likewise.
1038 * sound.c (sound_cleanup, alsa_close): Likewise.
1039 * termcap.c (tgetent): Likewise.
1040 * xfns.c (x_default_font_parameter): Likewise.
1041 * xsettings.c (read_and_apply_settings): Likewise.
1042
e7974947
AS
1043 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1044 (overrun_check_free): Protoize.
1045
28272684
PE
10462011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1047
1048 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1049 since callers should never pass a negative size.
1050 Change the signature to match that of plain 'read' and 'write'; see
1051 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1052 * lisp.h: Update prototypes of emacs_write and emacs_read.
1053
11997c76
EZ
10542011-04-11 Eli Zaretskii <eliz@gnu.org>
1055
1056 * xdisp.c (redisplay_window): Don't try to determine the character
1057 position of the scroll margin if the window start point w->startp
e896f03c 1058 is outside the buffer's accessible region. (Bug#8468)
11997c76 1059
8a2cbd72
EZ
10602011-04-10 Eli Zaretskii <eliz@gnu.org>
1061
1062 Fix write-region and its subroutines for buffers > 2GB.
1063 * fileio.c (a_write, e_write): Modify declaration of arguments and
1064 local variables to support buffers larger than 2GB.
1065 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1066
1067 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1068 argument, local variables, and return value.
1069
1070 * lisp.h: Update prototypes of emacs_write and emacs_read.
1071
1072 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1073
4073e537 10742011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1075
1ebfdcb6
PE
1076 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1077
b2ded58d
PE
1078 Fix more problems found by GCC 4.6.0's static checks.
1079
7d66342c
PE
1080 * xdisp.c (vmessage): Use a better test for character truncation.
1081
bbf47d44
PE
1082 * charset.c (load_charset_map): <, not <=, for optimization,
1083 and to avoid potential problems with integer overflow.
9248994d 1084 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1085 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1086 * editfns.c (Fformat): Likewise.
1e69125e 1087 * syntax.c (skip_chars): Likewise.
3befa583 1088
e3019616
PE
1089 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1090 This also lets GCC 4.6.0 generate slightly better loop code.
1091
becfa255
PE
1092 * callint.c (Fcall_interactively): <, not <=, for optimization.
1093 (Fcall_interactively): Count the number of arguments produced,
1094 not the number of arguments given. This is simpler and lets GCC
1095 4.6.0 generate slightly better code.
1096
dae0cd48
PE
1097 * ftfont.c: Distingish more carefully between FcChar8 and char.
1098 The previous code passed unsigned char * to a functions like
1099 strlen and xstrcasecmp that expect char *, which does not
1100 conform to the C standard.
1101 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1102 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1103 char * when the C standard requires it.
1104
76032d70
PE
1105 * keyboard.c (read_char): Remove unused var.
1106
eb3f1cc8
PE
1107 * eval.c: Port to Windows vsnprintf (Bug#8435).
1108 Include <limits.h>.
1109 (SIZE_MAX): Define if the headers do not.
1110 (verror): Do not give up if vsnprintf returns a negative count.
1111 Instead, grow the buffer. This ports to Windows vsnprintf, which
1112 does not conform to C99. Problem reported by Eli Zaretskii.
1113 Also, simplify the allocation scheme, by avoiding the need for
1114 calling realloc, and removing the ALLOCATED variable.
1115
70476b54
PE
1116 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1117
12020a9e
PE
1118 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1119 But keep the doprint source code for now, as we might revamp it
1120 and use it again (Bug#8435).
ea6c7ae6
PE
1121 * lisp.h (doprnt): Remove.
1122 * Makefile.in (base_obj): Remove doprnt.o.
1123 * deps.mk (doprnt.o): Remove.
1124
5fdb398c
PE
1125 error: Print 32- and 64-bit integers portably (Bug#8435).
1126 Without this change, on typical 64-bit hosts error ("...%d...", N)
1127 was used to print both 32- and 64-bit integers N, which relied on
1128 undefined behavior.
1129 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1130 New macro.
1131 * lisp.h (error, verror): Mark as printf-like functions.
1132 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1133 Report overflow in size calculations when allocating printf buffer.
1134 Do not truncate output string at its first null byte.
1135 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1136 Truncate the output at a character boundary, since vsnprintf does not
1137 do that.
1138 * charset.c (check_iso_charset_parameter): Convert internal
1139 character to string before calling 'error', since %c now has the
1140 printf meaning.
1141 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1142 overflow when computing char to be passed to 'error'. Do not
1143 pass Lisp_Object to 'error'; pass the integer instead.
1144 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1145 formatted with plain %d.
1146
b189fa66
PE
1147 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1148
bff87ef0
PE
1149 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1150
7e2cac20
PE
1151 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1152
ce4d90b5
PE
1153 * xterm.c (x_catch_errors): Remove duplicate declaration.
1154
266c9547
PE
1155 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1156
79c49ad2
PE
1157 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1158
368f4090
JM
11592011-04-10 Jim Meyering <meyering@redhat.com>
1160
1161 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1162 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1163 return ssize_t not "int", and use size_t as the buffer length.
1164 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1165 * gnutls.h: Update declarations.
1166 * process.c (read_process_output): Use ssize_t, to match.
1167 (send_process): Likewise.
1168
a32d4040
CY
11692011-04-09 Chong Yidong <cyd@stupidchicken.com>
1170
1171 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1172
8546720e 11732011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1174
8546720e
GM
1175 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1176 unsigned char, to match FcChar8 type definition.
aac0c6e3 1177
8546720e
GM
1178 * xterm.c (handle_one_xevent):
1179 * xmenu.c (create_and_show_popup_menu):
1180 * xselect.c (x_decline_selection_request)
1181 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1182
0a2f5c1a 11832011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1184
1185 Fix some uses of `int' instead of EMACS_INT.
1186 * search.c (string_match_1, fast_string_match)
1187 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1188 (scan_buffer, find_next_newline_no_quit)
1189 (find_before_next_newline, search_command, Freplace_match)
1190 (Fmatch_data): Make some `int' variables be EMACS_INT.
1191
1192 * xdisp.c (display_count_lines): 3rd argument and return value now
1193 EMACS_INT. All callers changed.
1194 (pint2hrstr): Last argument is now EMACS_INT.
1195
1196 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1197 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1198 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1199 (decode_coding_utf_16, decode_coding_emacs_mule)
1200 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1201 (decode_coding_ccl, decode_coding_charset)
1202 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1203 (decode_coding_iso_2022, decode_coding_emacs_mule)
1204 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1205 <char_offset, last_offset>: Declare EMACS_INT.
1206 (encode_coding_utf_8, encode_coding_utf_16)
1207 (encode_coding_emacs_mule, encode_invocation_designation)
1208 (encode_designation_at_bol, encode_coding_iso_2022)
1209 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1210 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1211 Declare EMACS_INT.
1212 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1213 (encode_invocation_designation): Last argument P_NCHARS is now
1214 EMACS_INT.
1215 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1216 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1217
1218 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1219 All users changed.
1220
1221 * ccl.c (Fccl_execute_on_string): Declare some variables
1222 EMACS_INT.
1223
8546720e 12242011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1225
1226 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1227
4e19a977
CS
12282011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1229
1230 * process.c (Fformat_network_address): Doc fix.
1231
87302331
R
12322011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1233
1234 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1235
cbb59342
CY
12362011-04-08 Chong Yidong <cyd@stupidchicken.com>
1237
1238 * keyboard.c (read_char): Call Lisp function help-form-show,
1239 instead of using internal_with_output_to_temp_buffer.
1240 (Qhelp_form_show): New var.
e0d38eeb 1241 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1242
1243 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1244
1245 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1246
e67a13ab
CY
12472011-04-06 Chong Yidong <cyd@stupidchicken.com>
1248
1249 * process.c (Flist_processes): Removed to Lisp.
1250 (list_processes_1): Deleted.
1251
973f782d
EZ
12522011-04-06 Eli Zaretskii <eliz@gnu.org>
1253
7c106b1e
EZ
1254 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1255
973f782d
EZ
1256 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1257
41cf7d1a 12582011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1259
ca23cc88
PE
1260 Fix more problems found by GCC 4.6.0's static checks.
1261
f390e2d5
PE
1262 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1263
42eea0d0
PE
1264 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1265
b69769da 1266 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1267
f9541e84
PE
1268 * xdisp.c (vmessage): Mark as a printf-like function.
1269
13841b55
PE
1270 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1271
c136c10f
PE
1272 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1273
5e2d4a30
PE
1274 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1275 printf-like functions.
1276 (tiff_load): Add casts to remove these marks before passing them
1277 to system-supplied API.
1278
583f48b9
PE
1279 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1280
b25d760e
PE
1281 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1282 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1283 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1284 directly, rather than having caller test rule sign. This avoids
1285 some unnecessary tests.
1286 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1287 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1288 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1289
bc7b6697 1290 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1291 (xfont_open): Avoid unnecessary tests.
bc7b6697 1292
27ccc379
PE
1293 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1294
dcd5c89a
PE
1295 * composite.h, composite.c (composition_gstring_put_cache):
1296 Use EMACS_INT, not int, for length.
1297
b13a45c6
PE
1298 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1299 breaking out part of COMPOSITION_DECODE_RULE.
1300 (COMPOSITION_DECODE_RULE): Use it.
1301 * composite.c (get_composition_id): Remove unused local vars,
1302 by using the new macro.
1303
1e792e4d
PE
1304 * textprop.c (set_text_properties_1): Change while to do-while,
1305 since the condition is always true at first.
1306
dc6c6455 1307 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1308 (interval_deletion_adjustment): Return unsigned value.
1309 All uses changed.
dc6c6455 1310
aba7731a
PE
1311 * process.c (list_processes_1, create_pty, read_process_output):
1312 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1313 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1314 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1315 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1316 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1317
fdfc4bf3
PE
1318 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1319
fca8fe46 1320 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1321 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1322
06a0259a 1323 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1324 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1325 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1326
e7b9e80f
PE
1327 * print.c (print_error_message): Avoid int overflow.
1328
56201685
PE
1329 * font.c (font_list_entities): Redo for clarity,
1330 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1331
78834453 1332 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1333 (font_score): Avoid potential overflow in diff calculation.
78834453 1334
0bc0b309 1335 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1336 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1337
e610eaca
PE
1338 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1339
b895abce
PE
1340 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1341 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1342 can always succeed if overflow has undefined behavior.
1343
1f1d9321 1344 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1345 (wordify): Omit three unnecessary tests.
1f1d9321 1346
c59478bc
PE
1347 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1348 All callers changed. This avoids the need for an unused var.
1349
79b73827
PE
1350 * casefiddle.c (casify_region): Remove var that is set but not used.
1351
a4db5dfe
PE
1352 * dired.c (file_name_completion): Remove var that is set but not used.
1353
43aae36e
PE
1354 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1355
2a47c44d 1356 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1357 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1358
a37c69bf
PE
1359 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1360 Check for integer overflow on size calculations.
1361
328ab8e7
PE
1362 * buffer.c (Fprevious_overlay_change): Remove var that is set
1363 but not used.
1364
e5a2a5cb
PE
1365 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1366 Remove vars that are set but not used.
8d84a6eb 1367 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1368 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1369
a60e5f68
PE
1370 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1371
f661cb61 1372 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1373 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1374
f0397f5a
PE
1375 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1376 that are set but not used.
1377
8664db06 1378 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1379 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1380
6abdaa4a
PE
1381 * xselect.c (x_get_local_selection, x_handle_property_notify):
1382 Remove vars that are set but not used.
1383
0ce7538d 1384 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1385 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1386
9ae848fc
PE
1387 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1388 Remove var that is set but not used.
0b918413
PE
1389 (scroll_bar_windows_size): Now size_t, not int.
1390 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1391 Check for overflow.
9ae848fc 1392
a5a62657
PE
1393 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1394 (map_tty_color) [!defined MSDOS]: Likewise.
1395
5c5cdd39
PE
1396 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1397
66ebf983
PE
1398 * coding.c: Remove vars that are set but not used.
1399 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1400 All callers changed.
1401 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1402 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1403 (decode_coding_charset): Remove vars that are set but not used.
1404
1be4d761
PE
1405 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1406 that is set but not used.
1407
47553fa8
PE
1408 * print.c (print_object): Remove var that is set but not used.
1409
1f7196bf 1410 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1411 The gnulib version avoids calling malloc in the usual case,
1412 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1413 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1414 * filelock.c (current_lock_owner): Likewise.
1415 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1416 * sysdep.c: Include allocator.h, careadlinkat.h.
1417 (emacs_no_realloc_allocator): New static constant.
1418 (emacs_readlink): New function.
fdb61804
PE
1419 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1420 ../lib/careadlinkat.h.
d1fdcab7 1421
f84c17c7
SM
14222011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1423
1424 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1425 first non-nil return value).
1426
ef3862ad
JD
14272011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1428
1429 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1430 if not defined (Bug#8403).
1431
376a7006
JB
14322011-04-02 Juanma Barranquero <lekktu@gmail.com>
1433
1434 * xdisp.c (display_count_lines): Remove parameter `start',
1435 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1436 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1437 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1438 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1439 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1440 and thereabouts. All callers changed.
1441 (get_per_char_metric): Remove parameter `f', unused since
1442 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1443
6ca3801d
JM
14442011-04-02 Jim Meyering <meyering@redhat.com>
1445
1446 do not dereference NULL upon failed strdup
1447 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1448 (ns_get_family): Likewise.
1449
d8e2b5ba
JB
14502011-04-02 Juanma Barranquero <lekktu@gmail.com>
1451
1452 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1453
8c74fcbd
JD
14542011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1455
1456 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1457 later (Bug#8403).
1458
7200d79c
SM
14592011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1460
03408648 1461 Add lexical binding.
7200d79c 1462
03408648
SM
1463 * window.c (Ftemp_output_buffer_show): New fun.
1464 (Fsave_window_excursion):
1465 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1466
1467 * lread.c (lisp_file_lexically_bound_p): New function.
1468 (Fload): Bind Qlexical_binding.
1469 (readevalloop): Remove `evalfun' arg.
1470 Bind Qinternal_interpreter_environment.
1471 (Feval_buffer): Bind Qlexical_binding.
1472 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1473 Mark as dynamic.
1474 (syms_of_lread): Declare `lexical-binding'.
1475
1476 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1477
1478 * keyboard.c (eval_dyn): New fun.
1479 (menu_item_eval_property): Use it.
ca105506
SM
1480
1481 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1482
03408648
SM
1483 * fns.c (concat, mapcar1): Accept byte-code-functions.
1484
1485 * eval.c (Fsetq): Handle lexical vars.
1486 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1487 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1488 (FletX, Flet): Obey lexical binding.
1489 (Fcommandp): Handle closures.
1490 (Feval): New `lexical' arg.
1491 (eval_sub): New function extracted from Feval. Use it almost
1492 everywhere where Feval was used. Look up vars in lexical env.
1493 Handle closures.
1494 (Ffunctionp): Move from subr.el.
1495 (Ffuncall): Handle closures.
1496 (apply_lambda): Remove `eval_flags'.
1497 (funcall_lambda): Handle closures and new byte-code-functions.
1498 (Fspecial_variable_p): New function.
1499 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1500 but without exporting it to Lisp.
23aba0ea 1501
23aba0ea 1502 * doc.c (Fdocumentation, store_function_docstring):
03408648 1503 * data.c (Finteractive_form): Handle closures.
23aba0ea 1504
03408648
SM
1505 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1506 interactive spec.
ba83908c 1507
03408648
SM
1508 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1509 byte-codes.
1510 (exec_byte_code): New function extracted from Fbyte_code to handle new
1511 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1512
03408648 1513 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1514
03408648 1515 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1516
e2abce01
JB
15172011-03-31 Juanma Barranquero <lekktu@gmail.com>
1518
1519 * xdisp.c (redisplay_internal): Fix prototype.
1520
63696a73 15212011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1522
63696a73
EZ
1523 * xdisp.c (SCROLL_LIMIT): New macro.
1524 (try_scrolling): Use it when setting scroll_limit. Limit
1525 scrolling to 100 screen lines.
1526 (redisplay_window): Even when falling back on "recentering",
1527 position point in the window according to scroll-conservatively,
1528 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1529
1530 (try_scrolling): When point is above the window, allow searching
1531 as far as scroll_max, or one screenful, to compute vertical
1532 distance from PT to the scroll margin position. This prevents
1533 try_scrolling from unnecessarily failing when
1534 scroll-conservatively is set to a value slightly larger than the
1535 window height. Clean up the case of PT below the margin at bottom
1536 of window: scroll_max can no longer be INT_MAX. When aggressive
1537 scrolling is in use, don't let point enter the opposite scroll
1538 margin as result of the scroll.
1539 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1540 threshold of 100 lines for never-recentering scrolling.
1541
e4cc2dfc
JB
15422011-03-31 Juanma Barranquero <lekktu@gmail.com>
1543
1544 * dispextern.h (move_it_by_lines):
1545 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1546 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1547 (message_log_check_duplicate): Remove parameters `prev_bol' and
1548 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1549 (redisplay_internal): Remove parameter `preserve_echo_area',
1550 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1551
1552 * indent.c (Fvertical_motion):
1553 * window.c (window_scroll_pixel_based, Frecenter):
1554 Don't pass `need_y_p' to `move_it_by_lines'.
1555
1c470562
SM
15562011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1557
44f230aa
SM
1558 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1559 steal a few bits to be more compact.
1560 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1561 Remove unneeded casts.
1562
1c470562
SM
1563 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1564
888adce9
ZK
15652011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1566
1567 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1568 binding" message (bug#7967).
1569
f838ed7b
PE
15702011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1571
77861b95
PE
1572 Fix more problems found by GCC 4.6.0's static checks.
1573
de6dbc14
PE
1574 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1575 Remove unused local var.
1576
f838ed7b
PE
1577 * editfns.c (Fmessage_box): Remove unused local var.
1578
792c7b2b
PE
1579 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1580 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1581 Omit unused local vars.
c499e557 1582 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1583 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1584 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1585 Omit unused local var.
1586
ba0165e1
PE
1587 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1588 Don't assume string length fits in int.
32ad8845 1589 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1590 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1591
3c59b4c9
PE
1592 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1593 instead of alloca (Bug#8344).
1594
a3eed478 1595 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1596 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1597
eb4d412d
PE
1598 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1599
1658b401
PE
1600 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1601 concerns.
1602
1603 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1604
1605 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1606
9a2c6e05
PE
1607 * keyboard.c (syms_of_keyboard): Use the same style as later
1608 in this function when indexing through an array. This also
1609 works around GCC bug 48267.
1610
03d0a109
PE
1611 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1612
44f730c8
PE
1613 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1614
fe75f926
PE
1615 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1616 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1617
ffa8c828
PE
1618 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1619 This avoids undefined behavior on integer overflow, and is a bit
1620 more convenient anyway since it is compared to a size_t variable.
1621
c5101a77
PE
1622 Variadic C functions now count arguments with size_t, not int.
1623 This avoids an unnecessary limitation on 64-bit machines, which
1624 caused (substring ...) to crash on large vectors (Bug#8344).
1625 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1626 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1627 All variadic functions and their callers changed accordingly.
c5101a77
PE
1628 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1629 * data.c (arith_driver, float_arith_driver): Likewise.
1630 * editfns.c (general_insert_function): Likewise.
1631 * eval.c (struct backtrace.nargs, interactive_p)
1632 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1633 (funcall_lambda, mark_backtrace): Likewise.
1634 * fns.c (concat): Likewise.
1635 * frame.c (x_set_frame_parameters): Likewise.
1636 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1637 0 if not found, not -1. All callers changed.
1638
dd3f25f7
PE
1639 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1640 (stack_copy_size): Now size_t, not int.
1641 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1642
461c2ab9
JB
16432011-03-28 Juanma Barranquero <lekktu@gmail.com>
1644
1645 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1646 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1647 All callers changed.
1648
1649 * lisp.h (multibyte_char_to_unibyte):
1650 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1651 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1652 * character.h (CHAR_TO_BYTE8):
1653 * cmds.c (internal_self_insert):
1654 * editfns.c (general_insert_function):
1655 * keymap.c (push_key_description):
1656 * search.c (Freplace_match):
1657 * xdisp.c (message_dolog, set_message_1): All callers changed.
1658
f6d62986
SM
16592011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1660
1661 * keyboard.c (safe_run_hook_funcall): New function.
1662 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1663 don't set the hook to nil, but remove the offending function instead.
1664 (Qcommand_hook_internal): Remove, unused.
1665 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1666 Vcommand_hook_internal.
1667
1668 * eval.c (enum run_hooks_condition): Remove.
1669 (funcall_nil, funcall_not): New functions.
1670 (run_hook_with_args): Call each function through a `funcall' argument.
1671 Remove `cond' argument, now redundant.
1672 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1673 (Frun_hook_with_args_until_failure): Adjust accordingly.
1674 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1675
1db5b1ad
JB
16762011-03-28 Juanma Barranquero <lekktu@gmail.com>
1677
1678 * dispextern.h (string_buffer_position): Remove declaration.
1679
1680 * print.c (strout): Remove parameter `multibyte', unused since
1681 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1682
1683 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1684 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1685 All callers changed.
1686
1687 * w32.c (_wsa_errlist): Use braces for struct initializers.
1688
1689 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1690 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1691 All callers changed.
1692 (string_buffer_position): Likewise. Also, make static (it's never
1693 used outside xdisp.c).
1694 (cursor_row_p): Remove parameter `w', unused since
1695 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1696 (decode_mode_spec): Remove parameter `precision', introduced during
1697 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1698 All callers changed.
1699
5ffb62aa
JD
17002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1701
1702 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1703
461c2ab9 17042011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1705
1706 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1707 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1708 (ns_update_auto_hide_menu_bar): New functions.
1709 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1710 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1711 ns_constrain_all_frames.
1712 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1713 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1714
5c380ffb
JD
17152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1716
1717 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1718
9af30bdf
GM
17192011-03-27 Glenn Morris <rgm@gnu.org>
1720
1721 * syssignal.h: Replace RETSIGTYPE with void.
1722 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1723 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1724 Replace SIGTYPE with void everywhere.
1725 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1726 * s/template.h (SIGTYPE): Remove commented out definition.
1727
e2abce01
JB
17282011-03-26 Eli Zaretskii <eliz@gnu.org>
1729
1730 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1731 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1732
f868cd8a
JB
17332011-03-26 Juanma Barranquero <lekktu@gmail.com>
1734
59eb0929
JB
1735 * w32.c (read_unc_volume): Use parameter `henum', instead of
1736 global variable `wget_enum_handle'.
1737
1738 * keymap.c (describe_vector): Remove parameters `indices' and
1739 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1740 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1741
f868cd8a
JB
1742 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1743
1744 * keyboard.c (timer_check): Remove parameter `do_it_now',
1745 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1746 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1747 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1748
1749 * keyboard.c (read_char):
1750 * w32menu.c (w32_menu_display_help):
1751 * xmenu.c (show_help_event, menu_help_callback):
1752 Adjust calls to `show_help_echo'.
1753
1754 * gtkutil.c (xg_maybe_add_timer):
1755 * keyboard.c (readable_events):
1756 * process.c (wait_reading_process_output):
1757 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1758
1759 * insdel.c (adjust_markers_gap_motion):
1760 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1761 (gap_left, gap_right): Don't call it.
1762
2ecf6fdb
CY
17632011-03-25 Chong Yidong <cyd@stupidchicken.com>
1764
1765 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1766 incurred during fontification.
1767
6b1f9ba4
JB
17682011-03-25 Juanma Barranquero <lekktu@gmail.com>
1769
1770 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1771 (DEFVAR_PER_BUFFER): Don't pass it.
1772
1773 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1774 (scrolling_window): Don't pass it.
1775
0f4a96b5
JB
17762011-03-25 Juanma Barranquero <lekktu@gmail.com>
1777
1778 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1779
1780 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1781 and `suffix'.
1782 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1783 of variables specific to SELinux and computation of `encoded_absname'.
1784
1785 * image.c (XPutPixel): Remove unused variable `height'.
1786
1787 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1788
1789 * unexw32.c (get_section_info): Remove unused variable `section'.
1790
1791 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1792 (system_process_attributes): Remove unused variable `sess'.
1793 (sys_read): Remove unused variable `err'.
1794
1795 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1796 (w32_wnd_proc): Remove unused variable `isdead'.
1797 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1798 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1799 (x_create_tip_frame): Remove unused variable `tem'.
1800
1801 * w32inevt.c (w32_console_read_socket):
1802 Remove unused variable `no_events'.
1803
1804 * w32term.c (x_draw_composite_glyph_string_foreground):
1805 Remove unused variable `width'.
1806
1149507c
JB
18072011-03-24 Juanma Barranquero <lekktu@gmail.com>
1808
1809 * w32term.c (x_set_glyph_string_clipping):
1810 Don't pass uninitialized region to CombineRgn.
1811
9c88f339
JB
18122011-03-23 Juanma Barranquero <lekktu@gmail.com>
1813
1814 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1815 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1816 (Fx_close_connection): Remove unused variable `i'.
1817
1818 * w32font.c (w32font_draw): Return number of glyphs.
1819 (w32font_open_internal): Remove unused variable `i'.
1820 (w32font_driver): Add missing initializer.
1821
1822 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1823 (fill_in_menu): Remove unused variable `items_added'.
1824
1825 * w32term.c (last_mouse_press_frame): Remove static global variable.
1826 (w32_clip_to_row): Remove unused variable `f'.
1827 (x_delete_terminal): Remove unused variable `i'.
1828
1829 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1830 (NOTHING): Remove unused static global variable.
1831 (uniscribe_check_otf): Remove unused variable `table'.
1832 (uniscribe_font_driver): Add missing initializers.
1833
dee091a3
JD
18342011-03-23 Julien Danjou <julien@danjou.info>
1835
1836 * term.c (Fsuspend_tty, Fresume_tty):
1837 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1838 * window.c (temp_output_buffer_show):
1839 * insdel.c (signal_before_change):
1840 * frame.c (Fhandle_switch_frame):
1841 * fileio.c (Fdo_auto_save):
1842 * emacs.c (Fkill_emacs):
1843 * editfns.c (save_excursion_restore):
1844 * cmds.c (internal_self_insert):
1845 * callint.c (Fcall_interactively):
1846 * buffer.c (Fkill_all_local_variables):
1847 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1848 Use Frun_hooks.
0f4a96b5 1849 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1850 unconditionnaly since it does the check itself.
1851
2c520ab5 18522011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1853
c9c49752
PE
1854 Fix more problems found by GCC 4.5.2's static checks.
1855
8abc3f12
PE
1856 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1857 the first time through the loop, since we know p0 < p1 then.
1858 This also avoids a gcc -Wstrict-overflow warning.
1859
a2d26660
PE
1860 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1861 leading to a memory leak, possible in functions like
1862 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1863 of objects (Bug#8318).
a2d26660 1864
916c72e9
PE
1865 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1866 that could (at least in theory) be that large.
1867
19ab8a18
PE
1868 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1869 This is less likely to overflow, and avoids undefined behavior if
1870 overflow does occur. All callers changed. Use strtoul to scan
1871 for the unsigned long integer.
b7cbbd6f
PE
1872 (pint2hrstr): Simplify and tune code slightly.
1873 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1874
f0641eff
PE
1875 * scroll.c (do_scrolling): Work around GCC bug 48228.
1876 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1877
7f650bb9
PE
1878 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1879 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1880 (validate_x_resource_name): Simplify count usage.
1881 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1882
37dd57d1
PE
1883 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1884 fail (Bug#8306).
81e56e61 1885
699979fc 1886 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1887
401bf9b4
PE
1888 * process.c (Fmake_network_process): Use socklen_t, not int,
1889 where POSIX says socklen_t is required in portable programs.
1890 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1891 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1892 (Fmake_network_process, server_accept_connection):
1893 (wait_reading_process_output, read_process_output):
1894 Likewise.
1895
b93aacde
PE
1896 * process.c: Rename or move locals to avoid shadowing.
1897 (list_processes_1, Fmake_network_process):
1898 (read_process_output_error_handler, exec_sentinel_error_handler):
1899 Rename or move locals.
4dc343ee 1900 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1901 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1902 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1903 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1904 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1905
af8a867c 1906 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1907 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1908 Include tparam.h instead, since it declares them.
af8a867c
PE
1909 * cm.h (PC): Remove extern decl; tparam.h now does this.
1910 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1911 * terminfo.c: Include tparam.h, to check interfaces.
1912 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1913 (tparam): Adjust signature to match interface in tparam.h;
1914 this removes some undefined behavior. Check that outstring and len
1915 are zero, which they always are with Emacs.
1916 * tparam.h (PC, BC, UP): New extern decls.
1917
0248044d 1918 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1919 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1920
8ff096c1 1921 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1922 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1923 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1924 (ftfont_list): Remove unused local.
49eaafba
PE
1925 (get_adstyle_property, ftfont_pattern_entity):
1926 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1927 Rename locals to avoid shadowing.
8ff096c1 1928
e2be39f6
PE
1929 * xfont.c (xfont_list_family): Mark var as initialized.
1930
c9735e30
PE
1931 * xml.c (make_dom): Now static.
1932
8f5201ae
PE
1933 * composite.c (composition_compute_stop_pos): Rename local to
1934 avoid shadowing.
b246f932
PE
1935 (composition_reseat_it): Remove unused locals.
1936 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1937 (composition_update_it): Mark var as initialized.
11b61122
PE
1938 (find_automatic_composition): Mark vars as initialized,
1939 with a FIXME (Bug#8290).
8f5201ae 1940
760fbc2c
PE
1941 character.h: Rename locals to avoid shadowing.
1942 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1943 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1944 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1945 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1946 to avoid shadowing.
1947
ff08eb85
PE
1948 * textprop.c (property_change_between_p): Remove; unused.
1949
fc7bf025
PE
1950 * intervals.c (interval_start_pos): Now static.
1951
235d7abc
PE
1952 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1953
44f230aa
SM
1954 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1955 Rename locals to avoid shadowing.
3e7d6594 1956
50060332
PE
1957 * sound.c (wav_play, au_play, Fplay_sound_internal):
1958 Fix pointer signedness.
d01f234b 1959 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1960 (wav_play): Initialize a variable to 0, to prevent undefined
1961 behavior (Bug#8278).
50060332 1962
c4fc4e30
PE
1963 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1964
918436ed
PE
1965 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1966
c939f91b
PE
1967 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1968 clobbering (Bug#8298).
b9c7f648
PE
1969 * sysdep.c (sys_subshell): Likewise.
1970 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1971
6bd8c144
PE
1972 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1973 This should get cleaned up, so that child_setup has the
1974 same signature on all platforms.
1975
7710357c 1976 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1977 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1978
c59da222
CY
19792011-03-22 Chong Yidong <cyd@stupidchicken.com>
1980
1981 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1982 not to be necessary, and produces flickering.
1983
66b87493
GM
19842011-03-20 Glenn Morris <rgm@gnu.org>
1985
1986 * config.in: Remove file.
1987
45b6f6d5
JB
19882011-03-20 Juanma Barranquero <lekktu@gmail.com>
1989
1990 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1991 are now in src/globals.h.
1992 (syms_of_minibuf): Remove spurious & from previous change.
1993
3ec03f7e
LL
19942011-03-20 Leo <sdl.web@gmail.com>
1995
1996 * minibuf.c (completing-read-function): New variable.
1997 (completing-read-default): Rename from completing-read.
1998 (completing-read): Call completing-read-function.
1999
b14e3e21
CY
20002011-03-19 Juanma Barranquero <lekktu@gmail.com>
2001
2002 * xfaces.c (Fx_load_color_file):
2003 Read color file from absolute filename (bug#8250).
2004
f2b726e6
JB
20052011-03-19 Juanma Barranquero <lekktu@gmail.com>
2006
2007 * makefile.w32-in: Update dependencies.
2008
09f6ff02
EZ
20092011-03-17 Eli Zaretskii <eliz@gnu.org>
2010
2011 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2012
29a6015a
PE
20132011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2014
a3a6c54e
PE
2015 Fix more problems found by GCC 4.5.2's static checks.
2016
b766f867
PE
2017 * process.c (make_serial_process_unwind, send_process_trap):
2018 (sigchld_handler): Now static.
2019
be02381c
PE
2020 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2021 That way, the code declares only the vars that it needs.
2022 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2023 * s/cygwin.h (PTY_ITERATION): Likewise.
2024 * s/darwin.h (PTY_ITERATION): Likewise.
2025 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2026
57048744
PE
2027 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2028 * process.c (allocate_pty): Don't declare stb unless it's needed.
2029
7914961c 2030 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2031 (CONSTANTLIM): Remove; unused.
2032 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2033 Define only if needed.
7914961c 2034
b3967b18
PE
2035 * unexelf.c (unexec): Name an expression,
2036 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2037 Use a different way to cause a compilation error if anyone uses
2038 n rather than nn, a way that does not involve shadowing.
73366a00 2039 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2040
29a6015a
PE
2041 * deps.mk (unexalpha.o): Remove; unused.
2042
43cfc33e 2043 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2044 * unexec.h: New file.
ce701a33
PE
2045 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2046 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2047 Depend on unexec.h.
2048 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2049 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2050 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2051 Change as necessary to match prototype in unexec.h.
ce701a33 2052
01f44d5a
PE
2053 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2054 shadowing.
4f63c6bb 2055 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2056
a6670b0b
PE
2057 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2058 Rename locals to avoid shadowing.
2059
cef2010d 2060 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2061 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2062
d4d7173a
PE
2063 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2064
f08b802a
PE
2065 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2066 warning when compiling print.c.
2067
3ddb0639
PE
2068 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2069 instead of using an uninitialized var.
5ad03b97 2070 (font_sort_entities): Mark var as initialized.
3ddb0639 2071
170a2692
PE
2072 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2073
e663c700
PE
2074 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2075 pointers to constants.
89bc529a 2076 (font_parse_fcname): Remove unused vars.
7b81e2d0 2077 (font_delete_unmatched): Now static.
ea838e10 2078 (font_get_spec): Remove; unused.
13a547c6
PE
2079 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2080 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2081 Rename or move locals to avoid shadowing.
e663c700 2082
2a80c887 2083 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2084 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2085
1384fa33 2086 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2087 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2088
8b2c52e9
PE
2089 * alloc.c (mark_backtrace): Move decl from here ...
2090 * lisp.h: ... to here, so that it can be checked.
2091
475545b5 2092 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2093 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2094 (lisp_indirect_variable): Name an expression,
2095 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2096 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2097
b1349114 2098 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2099 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2100 Use const pointer when appropriate.
b1349114 2101
a2928364
PE
2102 * lisp.h (get_system_name, get_operating_system_release):
2103 Move decls here, to check interfaces.
2104 * process.c (get_operating_system_release): Move decl to lisp.h.
2105 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2106 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2107 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2108 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2109 (Fformat_time_string, Fencode_time, Finsert_char):
2110 (Ftranslate_region_internal, Fformat):
2111 Rename or remove local vars to avoid shadowing.
9710023e 2112 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2113
a415e694
PE
2114 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2115 avoid shadowing.
2116
8ef4622d
PE
2117 * lisp.h (eassert): Check that the argument compiles, even if
2118 ENABLE_CHECKING is not defined.
2119
946f9a5b
PE
2120 * data.c (Findirect_variable): Name an expression, to avoid
2121 gcc -Wbad-function-cast warning.
112396d6 2122 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2123 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2124 (Fmake_variable_buffer_local, Fmake_local_variable):
2125 Mark variables as initialized.
52746918 2126 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2127
e5aab7e7 2128 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2129 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2130 Rename locals to avoid shadowing.
dff45157
PE
2131 (mark_stack): Move local variables into the #ifdef region where
2132 they're used.
7bc26fdb
PE
2133 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2134 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2135 needed otherwise.
2136 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2137 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2138 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2139
e5aab7e7
PE
2140 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2141 avoids undefined behavior in theory.
2142
4da60324
PE
2143 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2144
88043301
PE
2145 Use functions, not macros, for up- and down-casing (Bug#8254).
2146 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2147 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2148 to use the following functions instead of these macros.
2149 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2150 EMACS_INT, since callers assume the returned value fits in int.
2151 (upcase1): Likewise, for UPCASE_TABLE.
2152 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2153 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2154 the race-condition problem in the old DOWNCASE.
88043301 2155
19ed5445
PE
2156 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2157 Rename locals to avoid shadowing.
2158 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2159 (regex_compile, re_search_2, re_match_2_internal):
2160 Remove unused local vars.
952db0d7
PE
2161 (FREE_VAR): Rewrite so as not to use empty "else",
2162 which gcc can warn about.
da053e48 2163 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2164 (RETALLOC_IF): Define only if needed.
2165 (WORDCHAR_P): Likewise. This one is never needed, but is used
2166 only in a comment talking about a compiler bug, so put inside
2167 the #if 0 of that comment.
2168 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2169 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2170 Remove; unused.
19ed5445 2171
1f3561e4 2172 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2173 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2174 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2175
ded6f8f7
PE
2176 * search.c (simple_search): Remove unused var.
2177
dbd37a95
PE
2178 * dired.c (compile_pattern): Move decl from here ...
2179 * lisp.h: ... to here, so that it can be checked.
2180 (struct re_registers): New forward decl.
2181
7e47afad
PE
2182 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2183
85f24f61
PE
2184 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2185 All uses changed.
2186 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2187 Rename locals to avoid shadowing.
5671df8f 2188 (Fvertical_motion): Mark locals as initialized.
85f24f61 2189
181aa2be 2190 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2191 (casify_region): Mark local as initialized.
181aa2be 2192
930d429c
PE
2193 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2194
7082eac6
PE
2195 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2196 New macros, so that the caller can use some names other than
2197 gcpro1, gcpro2, etc.
2198 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2199 of the new macros.
2200 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2201 argument, for consistency with GCPRO2_VAR, etc: it is now the
2202 prefix of the variable, not the variable itself. All uses
2203 changed.
38b2c076
PE
2204 * dired.c (directory_files_internal, file_name_completion):
2205 Rename locals to avoid shadowing.
2206
15206ed9
PE
2207 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2208 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2209 dired.c's scmp function, had undefined behavior.
2210 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2211 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2212 * buffer.h: ... to here, because these macros use current_buffer,
2213 and the new implementation with inline functions needs to have
2214 current_buffer in scope now, rather than later when the macros
2215 are used.
2216 (downcase, upcase1): New static inline functions.
2217 (DOWNCASE, UPCASE1): Reimplement using these functions.
2218 This avoids undefined behavior in expressions like
2219 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2220 from race conditions in accessing the global variables
2221 case_temp1 and case_temp2.
2222 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2223 * lisp.h (case_temp1, case_temp2): Remove their decls.
2224 * character.h (ASCII_CHAR_P): Move from here ...
2225 * lisp.h: ... to here, so that the inline functions mentioned
2226 above can use them.
2227
4a6bea26
PE
2228 * dired.c (directory_files_internal_unwind): Now static.
2229
f14b7e14
PE
2230 * fileio.c (file_name_as_directory, directory_file_name):
2231 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2232 Now static.
2893f146
PE
2233 (file_name_as_directory): Use const pointers when appropriate.
2234 (Fexpand_file_name): Likewise. In particular, newdir might
2235 point at constant storage, so make it a const pointer.
fd4ead52 2236 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2237 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2238 signedness issues.
f839df0c
PE
2239 (Fset_file_times, Finsert_file_contents, auto_save_error):
2240 Rename locals to avoid shadowing.
f14b7e14 2241
5716756e 2242 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2243 (Ftry_completion, Fall_completions): Rename or remove locals
2244 to avoid shadowing.
5716756e 2245
b4c3046a
PE
2246 * marker.c (bytepos_to_charpos): Remove; unused.
2247
b45db522
PE
2248 * lisp.h (verify_bytepos, count_markers): New decls,
2249 so that gcc does not warn that these functions aren't declared.
2250
85876d07
PE
2251 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2252 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2253 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2254 (copy_text): Remove unused local var.
85876d07 2255
03d78a21 2256 * filelock.c (within_one_second): Now static.
b3dd38ab 2257 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2258
5df8f01b
PE
2259 * buffer.c (fix_overlays_before): Mark locals as initialized.
2260 (fix_start_end_in_overlays): Likewise. This function should be
2261 simplified by using pointers-to-pointers, but that's a different
2262 matter.
b1d876f1 2263 (switch_to_buffer_1): Now static.
8f54f30a
PE
2264 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2265 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2266
a70072c9 2267 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2268 Fix pointer signedness issue.
edced198
PE
2269 (sys_subshell): Mark local as volatile if checking for lint,
2270 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2271 (MAXPATHLEN): Define only if needed.
a70072c9 2272
a0977c44
PE
2273 * process.c (serial_open, serial_configure): Move decls from here ...
2274 * systty.h: ... to here, so that they can be checked.
2275
a884fdcc
PE
2276 * fns.c (get_random, seed_random): Move extern decls from here ...
2277 * lisp.h: ... to here, so that they can be checked.
2278
604efe86 2279 * sysdep.c (reset_io): Now static.
b8950c94 2280 (wait_for_termination_signal): Remove; unused.
604efe86 2281
38fc62d9
PE
2282 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2283 (copy_keymap_item, append_key, push_text_char_description):
2284 Now static.
1004a21a 2285 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2286 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2287 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2288 (describe_map_tree):
2289 Rename locals to avoid shadowing.
38fc62d9 2290
2f2650da
PE
2291 * keyboard.c: Declare functions static if they are not used elsewhere.
2292 (echo_char, echo_dash, cmd_error, top_level_2):
2293 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2294 (read_char, kbd_buffer_get_event, make_lispy_position):
2295 (make_lispy_event, make_lispy_movement, apply_modifiers):
2296 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2297 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2298 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2299 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2300 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2301
a053e86c 2302 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2303 (mark_kboards): Move decl here ...
2304 * alloc.c (mark_kboards): ... from here.
a053e86c 2305
4752793e
PE
2306 * lisp.h (force_auto_save_soon): New decl.
2307
74f10ca7 2308 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2309 (DEFINE_DUMMY_FUNCTION): New macro.
2310 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2311 Use it.
c03cd23f
PE
2312 (main): Add casts to avoid warnings
2313 if GCC considers string literals to be constants.
74f10ca7 2314
022e70d4
PE
2315 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2316
59d6fe83
PE
2317 * dbusbind.c: Pointer signedness fixes.
2318 (xd_signature, xd_append_arg, xd_initialize):
2319 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2320 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2321 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2322 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2323
78320123
PE
2324 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2325 if GCC considers string literals to be constants.
49cebcca 2326 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2327
35ac2a97
SM
23282011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2329
fb103ca9
SM
2330 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2331 (print_preprocess, print_object): New macro to fix last change.
2332
35ac2a97
SM
2333 * print.c (print_preprocess): Don't forget font objects.
2334
62973b41
JB
23352011-03-16 Juanma Barranquero <lekktu@gmail.com>
2336
2337 * emacs.c (USAGE3): Doc fixes.
2338
0e48bb22
AS
23392011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2340
2341 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2342 structure.
2343
7684e57b
JB
23442011-03-14 Juanma Barranquero <lekktu@gmail.com>
2345
2346 * lisp.h (VWindow_system, Qfile_name_history):
2347 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2348 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2349 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2350
2351 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2352 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2353
2354 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2355 * w32console.c (detect_input_pending, read_input_pending)
2356 (encode_terminal_code):
2357 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2358 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2359 (w32_system_caret_y, Qfile_name_history):
2360 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2361 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2362 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2363 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2364 * w32proc.c (Qlocal, report_file_error):
2365 * w32term.c (Vwindow_system, updating_frame):
2366 * w32uniscribe.c (initialized, uniscribe_font_driver):
2367 Remove unneeded extern declarations.
2368
2aa46d6c
CY
23692011-03-14 Chong Yidong <cyd@stupidchicken.com>
2370
c96bbc66 2371 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2372
cffc6f3b
CY
23732011-03-13 Chong Yidong <cyd@stupidchicken.com>
2374
2375 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2376 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2377 These macros can no longer be used for assignment.
2378
44f230aa
SM
2379 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2380 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2381 (record_buffer_markers, fetch_buffer_markers): New functions for
2382 recording and fetching special buffer markers.
2383 (set_buffer_internal_1, set_buffer_temp): Use them.
2384
2385 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2386
2387 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2388
2389 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2390 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2391
2392 * xdisp.c (hscroll_window_tree):
2393 (reconsider_clip_changes): Use PT instead of BUF_PT.
2394
d251f04b
EZ
23952011-03-13 Eli Zaretskii <eliz@gnu.org>
2396
2397 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2398 $(EMACS_ROOT)/lib/intprops.h.
2399
f0c77cd1
PE
24002011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2401
3eca4629
PE
2402 Fix more problems found by GCC 4.5.2's static checks.
2403
7c86ee98
PE
2404 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2405 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2406 (xg_free_frame_widgets): Make it clear that a local variable is
2407 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2408 (gdk_window_get_screen): Make it clear that this macro is needed
2409 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2410 (int_gtk_range_get_value): New function, which avoids a diagnostic
2411 from gcc -Wbad-function-cast.
2412 (xg_set_toolkit_scroll_bar_thumb): Use it.
2413 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2414 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2415 (get_utf8_string, xg_get_file_with_chooser):
2416 Rename locals to avoid shadowing.
2417 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2418
41729b81
PE
2419 * xgselect.c (xg_select): Remove unused var.
2420
f0c77cd1
PE
2421 * image.c (four_corners_best): Mark locals as initialized.
2422 (gif_load): Initialize transparent_p to zero (Bug#8238).
2423 Mark another local as initialized.
ec6cf4c6 2424 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2425
ce0ad53d 2426 * image.c (clear_image_cache): Now static.
d5d5a617 2427 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2428 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2429 (x_edge_detection): Remove unnecessary cast that
2430 gcc -Wbad-function-cast diagnoses.
2037898d 2431 (gif_load): Fix pointer signedness.
6ae141d6
PE
2432 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2433 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2434
33383987 24352011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2436
d32df629
PE
2437 Improve quality of tests for time stamp overflow.
2438 For example, without this patch (encode-time 0 0 0 1 1
2439 1152921504606846976) returns the obviously-bogus value (-948597
2440 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2441 reports time overflow. See
2442 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2443 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2444 * editfns.c: Include limits.h and intprops.h.
2445 (TIME_T_MIN, TIME_T_MAX): New macros.
2446 (time_overflow): Move earlier, to before first use.
2447 (hi_time, lo_time): New functions, for an accurate test for
2448 out-of-range times.
2449 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2450 (Fget_internal_run_time): Don't assume time_t fits in int.
2451 (make_time): Use list2 instead of Fcons twice.
2452 (Fdecode_time): More accurate test for out-of-range times.
2453 (check_tm_member): New function.
2454 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2455 (lisp_time_argument): Don't rely on undefined left-shift and
2456 right-shift behavior when checking for time stamp overflow.
8be6f318 2457
fe31d94c
PE
2458 * editfns.c (time_overflow): New function, refactoring common code.
2459 (Fformat_time_string, Fdecode_time, Fencode_time):
2460 (Fcurrent_time_string): Use it.
2461
8be6f318
PE
2462 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2463 * dired.c (make_time): Move to ...
2464 * editfns.c (make_time): ... here.
2465 * systime.h: Note the move.
2466
09d9db2c 24672011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2468
126bc0dc
YM
2469 * fringe.c (update_window_fringes): Remove unused variables.
2470
c47cbdfd
YM
2471 * unexmacosx.c (copy_data_segment): Also copy __got section.
2472 (Bug#8223)
2473
7ac80be9
EZ
24742011-03-12 Eli Zaretskii <eliz@gnu.org>
2475
c96bbc66 2476 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2477 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2478 Constify `char *' arguments and their references according to
2479 prototypes in tparam.h.
2480
ecb0f94d 2481 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2482
7ac80be9
EZ
2483 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2484 Adapt all references accordingly.
2485
2486 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2487
ef1fd07e
TT
24882011-03-11 Tom Tromey <tromey@redhat.com>
2489
2490 * buffer.c (syms_of_buffer): Remove obsolete comment.
2491
7ef4b50c
EZ
24922011-03-11 Eli Zaretskii <eliz@gnu.org>
2493
2494 * termhooks.h (encode_terminal_code): Declare prototype.
2495
2496 * msdos.c (encode_terminal_code): Don't declare prototype.
2497
2498 * term.c (encode_terminal_code): Now external again, used by
2499 w32console.c and msdos.c.
2500
44f230aa
SM
2501 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2502 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2503
4b1ec863 25042011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2505
1714f52b 2506 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2507
4b1ec863
PE
2508 * fringe.c (update_window_fringes): Mark locals as initialized
2509 (Bug#8227).
2510 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2511
524c7aa6
PE
2512 * alloc.c (mark_fringe_data): Move decl from here ...
2513 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2514 to check its interface.
2515 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2516
a5c0af81 2517 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2518 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2519 (fontset_font): Mark local as initialized.
a9a06e0b 2520 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2521
b4716021
PE
2522 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2523
811e9bac 2524 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2525 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2526 (x_own_selection, Fx_disown_selection_internal): Rename locals
2527 to avoid shadowing.
2528 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2529
7e3ab302
PE
2530 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2531 so that the caller can use some name other than gcpro1.
2532 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2533 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2534 (Fx_backspace_delete_keys_p):
2535 Use them to avoid shadowing, and rename vars to avoid shadowing.
2536 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2537 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2538 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2539 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2540 Remove unused locals.
7e3ab302
PE
2541 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2542 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2543 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2544 macros.
f78faa98 2545
e2b13473
PE
2546 * xterm.h (x_mouse_leave): New decl.
2547
77f23912
PE
2548 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2549 Remove unused functions.
cdf4ba58
PE
2550 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2551 (x_calc_absolute_position): Now static.
7411c686 2552 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2553 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2554 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2555 unless they are used.
38d0b34a
PE
2556 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2557 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2558 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2559 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2560 (x_error_catcher, x_connection_closed, x_error_handler):
2561 (x_error_quitter, xembed_send_message, x_iconify_frame):
2562 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2563 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2564 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2565
44f230aa
SM
2566 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2567 Rename or move locals to avoid shadowing.
6b463e58 2568 (tty_defined_color, merge_face_heights): Now static.
5967d051 2569 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2570 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2571 does not deduce is never used uninitialized.
73719eba
PE
2572 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2573 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2574
426994c3 2575 * terminal.c (store_terminal_param): Now static.
5489860b 2576
032f1620 2577 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2578 (set_frame_menubar): Remove unused local.
d4323972 2579 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2580 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2581 since they might point to immutable storage.
281585b0
PE
2582 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2583 since it's unused otherwise.
032f1620 2584
367c19e5 2585 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2586 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2587 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2588 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2589 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2590 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2591 does not deduce are never used uninitialized.
70739cbe 2592
07b48fa9
PE
2593 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2594
8868a238 2595 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2596 * window.c (window_loop, size_window):
2597 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2598
7e5cf297 2599 * window.c (display_buffer): Now static.
d6550a9f
PE
2600 (size_window): Mark variables that gcc -Wuninitialized
2601 does not deduce are never used uninitialized.
a586633d
PE
2602 * window.h (check_all_windows): New decl, to forestall
2603 gcc -Wmissing-prototypes diagnostic.
5b555da1 2604 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2605
f6095868
PE
2606 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2607 shadowing.
2608 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2609 Include <limits.h>.
2610 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2611 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2612 (load_charset_map): Mark variables that gcc -Wuninitialized
2613 does not deduce are never used uninitialized.
53df7c11 2614 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2615
f38b440c
PE
2616 * coding.c (coding_set_source, coding_set_destination):
2617 Use "else { /* comment */ }" rather than "else /* comment */;"
2618 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2619 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2620 a block, when the outer 'i' will do.
2621 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2622 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2623 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2624 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2625 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2626 Rename locals to avoid shadowing.
2627 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2628 * coding.c (emacs_mule_char, encode_invocation_designation):
2629 Now static, since they're not used elsewhere.
413bb2db 2630 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2631 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2632 (decode_coding_emacs_mule): Mark variables that gcc
2633 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2634 (detect_coding_iso_2022): Initialize a local variable that might
2635 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2636 this initialization is needed. (Bug#8211)
5f58e762
PE
2637 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2638 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2639 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2640 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2641 Remove unused macros.
f38b440c 2642
232b38b9 2643 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2644 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2645 * character.c (string_count_byte8): Likewise.
232b38b9 2646
fb90da1b
PE
2647 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2648 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2649
fb93dbc2
PE
2650 * chartab.c (copy_sub_char_table): Now static, since it's not used
2651 elsewhere.
5c156ace
PE
2652 (sub_char_table_ref_and_range, char_table_ref_and_range):
2653 Rename locals to avoid shadowing.
bbcd0949 2654 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2655
7d3b3862 2656 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2657 (BIDI_BOB): Remove unused macro.
7d3b3862 2658
6be7d3da
PE
2659 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2660 deduce are never used uninitialized.
c2ed9c8b 2661 * term.c (encode_terminal_code): Likewise.
6be7d3da 2662
75f8807f 2663 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2664
50938595
PE
2665 * tparam.h: New file.
2666 * term.c, tparam.h: Include it.
2667 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2668 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2669 Move these decls to tparam.h, and make them agree with what
2670 is actually in tparam.c. The previous trick of using incompatible
2671 decls in different modules does not conform to the C standard.
2672 All callers of tparam changed to use tparam's actual API.
2673 * tparam.c (tparam1, tparam, tgoto):
2674 Use const pointers where appropriate.
2675
fbceeba2
PE
2676 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2677 * cm.h (struct cm): Likewise.
2678 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2679 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2680 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2681 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2682 (turn_on_face, init_tty): Likewise.
2683 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2684
7f3f1250
PE
2685 * term.c (term_mouse_position): Rename local to avoid shadowing.
2686
e6ca6543
PE
2687 * alloc.c (mark_ttys): Move decl from here ...
2688 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2689
c40f8d15
AS
26902011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2691
2692 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2693
cfe0661d
JB
26942011-03-09 Juanma Barranquero <lekktu@gmail.com>
2695
2696 * search.c (compile_pattern_1): Remove argument regp, unused since
2697 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2698 (compile_pattern): Don't pass it.
2699
0afb4571
J
27002011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2701
2702 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2703 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2704 for ! HAVE_GTK3.
2705 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2706
2707 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2708
2709 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2710 gdk_window_get_screen, gdk_window_get_geometry,
2711 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2712 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2713 (xg_get_pixbuf_from_pixmap): New function.
2714 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2715 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2716 Call xg_get_pixbuf_from_pixmap instead of
2717 gdk_pixbuf_get_from_drawable.
2718 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2719 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2720 (xg_check_special_colors): Use GtkStyleContext and its functions
2721 for HAVE_GTK3.
2722 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2723 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2724 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2725 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2726 Call gtk_widget_get_preferred_size.
0afb4571
J
2727 (xg_frame_resized): gdk_window_get_geometry only takes 5
2728 parameters.
44f230aa
SM
2729 (xg_win_to_widget, xg_event_is_for_menubar):
2730 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2731 (xg_set_widget_bg): New function.
2732 (delete_cb): New function.
895009e1 2733 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
2734 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2735 (xg_set_background_color): Call xg_set_widget_bg.
2736 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2737 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2738 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2739 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2740 if ! HAVE_GTK3.
2741 (update_frame_tool_bar): Call gtk_widget_hide.
2742 (xg_initialize): Use GDK_KEY_g.
2743
2744 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2745 if ! HAVE_GTK3
2746 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2747
2748 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2749 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2750 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2751
1c2cc4ef
JB
27522011-03-08 Juanma Barranquero <lekktu@gmail.com>
2753
2754 * w32xfns.c (select_palette): Check success of RealizePalette against
2755 GDI_ERROR, not zero.
2756
33383987 2757See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2758
2759;; Local Variables:
2760;; coding: utf-8
aac0c6e3
MR
2761;; End:
2762
33383987 2763 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2764
2765 This file is part of GNU Emacs.
2766
2767 GNU Emacs is free software: you can redistribute it and/or modify
2768 it under the terms of the GNU General Public License as published by
2769 the Free Software Foundation, either version 3 of the License, or
2770 (at your option) any later version.
2771
2772 GNU Emacs is distributed in the hope that it will be useful,
2773 but WITHOUT ANY WARRANTY; without even the implied warranty of
2774 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2775 GNU General Public License for more details.
2776
2777 You should have received a copy of the GNU General Public License
2778 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.