* dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0c671da6 12011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2
dfe18f82
PE
3 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4
84acfcf0
PE
5 Don't assume time_t can fit into int.
6 * buffer.h (struct buffer.modtime): Now time_t, not int.
7 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9
ccd9a01a
PE
10 Minor fixes for signed vs unsigned integers.
11 * character.h (MAYBE_UNIFY_CHAR):
12 * charset.c (maybe_unify_char):
13 * keyboard.c (read_char, reorder_modifiers):
14 XINT -> XFASTINT, since the integer must be nonnegative.
15 * ftfont.c (ftfont_spec_pattern):
16 * keymap.c (access_keymap, silly_event_symbol_error):
17 XUINT -> XFASTINT, since the integer must be nonnegative.
18 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
19 since it makes no difference and we prefer signed.
20 * keyboard.c (record_char): Use XUINT when all the neighbors do.
21 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
22 nonnegative.
23
4d09bcf6
PE
242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
25
26 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
27 Do not assume that spare memory exists; that assumption is valid
28 only if SYSTEM_MALLOC.
29 (LARGE_REQUEST): New macro, so that the issue of large requests
30 is separated from the issue of spare memory.
31
810928a2
AS
322011-06-05 Andreas Schwab <schwab@linux-m68k.org>
33
172418ad
AS
34 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
35 format. (Bug#8806)
36
43f862f7
AS
37 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
38
810928a2
AS
39 * xfns.c (x_set_scroll_bar_default_width): Move declarations
40 before statements.
41
a059fe24
JD
422011-06-05 Jan Djärv <jan.h.d@swipnet.se>
43
44 * gtkutil.c (xg_get_default_scrollbar_width): New function.
45
46 * gtkutil.h: Declare xg_get_default_scrollbar_width.
47
48 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
49 min width by calling x_set_scroll_bar_default_width (Bug#8505).
50
989bf368
JB
512011-06-05 Juanma Barranquero <lekktu@gmail.com>
52
53 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
54
4b80f674
CY
552011-06-04 Chong Yidong <cyd@stupidchicken.com>
56
57 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
58 (x_clipboard_manager_save): Add return value.
59 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
60 error handlers.
61 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
62 Obey Vx_select_enable_clipboard_manager. Catch errors in
63 x_clipboard_manager_save (Bug#8779).
64 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 65 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 66
99a33b77 672011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
68
69 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
70
99a33b77 712011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
72
73 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
74 in the current matrix if keep_current_p is non-zero.
75
8264569d
EZ
762011-06-04 Eli Zaretskii <eliz@gnu.org>
77
78 * bidi.c (bidi_level_of_next_char): Fix last change.
79
57f97249
EZ
802011-06-03 Eli Zaretskii <eliz@gnu.org>
81
fec2107c 82 Support bidi reordering of text covered by display properties.
57f97249 83
fec2107c
EZ
84 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
85 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
86 (bidi_cache_search, bidi_cache_iterator_state)
87 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
88 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
89 character positions inside a run of characters covered by a
90 display string.
91 (bidi_paragraph_init, bidi_resolve_explicit_1)
92 (bidi_level_of_next_char): Call bidi_fetch_char and
93 bidi_fetch_char_advance instead of FETCH_CHAR and
94 FETCH_CHAR_ADVANCE.
95 (bidi_init_it): Initialize new members.
96 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
97 definitions.
98 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
99 instead of using explicit *_CHAR codes.
100 (bidi_resolve_explicit, bidi_resolve_weak): Use
101 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
102 bidirectional text is supported only in multibyte buffers.
103 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
104 it to initialize the frame_window_p member of struct bidi_it.
105 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
106 (bidi_resolve_explicit, bidi_resolve_weak)
107 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
108 bidi_it->nchars is non-positive.
109 (bidi_level_of_next_char): Don't try to lookup the cache for the
110 next/previous character if nothing is cached there yet, or if we
111 were just reseat()'ed to a new position.
c40e2fb2 112
0e14fe90
EZ
113 * xdisp.c (set_cursor_from_row): Set start and stop points
114 according to the row's direction when priming the loop that looks
115 for the glyph on which to display cursor.
116 (single_display_spec_intangible_p): Function deleted.
117 (display_prop_intangible_p): Reimplement to call
118 handle_display_spec instead of single_display_spec_intangible_p.
119 Accept 3 additional arguments needed by handle_display_spec. This
120 fixes incorrect cursor motion across display property with complex
121 values: lists, `(when COND...)' forms, etc.
122 (single_display_spec_string_p): Support property values that are
123 lists with the argument STRING its top-level element.
124 (display_prop_string_p): Fix the condition for processing a
125 property that is a list to be consistent with handle_display_spec.
fec2107c 126 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
127 last portion of handle_display_prop.
128 (compute_display_string_pos): Accept additional argument
129 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
130 value of a `display' property is a "replacing spec".
131 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
132 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
133 the display property, but just return a value indicating whether
134 the display property will replace the characters it covers.
135 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
136 frame_window_p members of struct bidi_it.
fec2107c
EZ
137 (compute_display_string_pos, compute_display_string_end): New
138 functions.
139 (push_it): Accept second argument POSITION, where pop_it should
140 jump to continue iteration.
141 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 142
fec2107c
EZ
143 * keyboard.c (adjust_point_for_property): Adjust the call to
144 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
145
146 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
147 (bidi_init_it): Update prototypes.
148 (display_prop_intangible_p): Update prototype.
149 (compute_display_string_pos, compute_display_string_end): Declare
150 prototypes.
151 (struct bidi_it): New members nchars and disp_pos. ch_len is now
152 EMACS_INT.
fc6f18ce 153
40087514 1542011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 155
57f53182
PE
156 Malloc failure behavior now depends on size of allocation.
157 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
158 * lisp.h: Change signatures accordingly.
159 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
160 All callers changed. (Bug#8762)
161
162 * gnutls.c: Use Emacs's memory allocators.
163 Without this change, the gnutls library would invoke malloc etc.
164 directly, which causes problems on non-SYNC_INPUT hosts, and which
165 runs afoul of improving memory_full behavior. (Bug#8761)
166 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
167 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
168 xfree instead of the default malloc, realloc, free.
169 (Fgnutls_boot): No need to check for memory allocation failure,
170 since xmalloc does that for us.
171
ac32cd99 172 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
173 * category.c (hash_get_category_set):
174 * ccl.c (ccl_driver):
175 * charset.c (Fdefine_charset_internal):
176 * charset.h (struct charset.hash_index):
177 * composite.c (get_composition_id, gstring_lookup_cache)
178 (composition_gstring_put_cache):
179 * composite.h (struct composition.hash_index):
180 * dispextern.h (struct image.hash):
181 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
182 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
183 (hashfn_equal, hashfn_user_defined, make_hash_table)
184 (maybe_resize_hash_table, hash_lookup, hash_put)
185 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
186 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
187 (Fsxhash, Fgethash, Fputhash, Fmaphash):
188 * image.c (make_image, search_image_cache, lookup_image)
189 (xpm_put_color_table_h):
190 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 191 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
192 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
193 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
194 * alloc.c (allocate_vectorlike):
195 Check for overflow in vector size calculations.
196 * ccl.c (ccl_driver):
197 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
198 * fns.c, image.c: Remove unnecessary static decls that would otherwise
199 need to be updated by these changes.
40087514
PE
200 * fns.c (make_hash_table, maybe_resize_hash_table):
201 Check for integer overflow with large hash tables.
0de4bb68
PE
202 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
203 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
204 (SXHASH_REDUCE): New macro.
205 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
206 Use it instead of discarding useful hash info with large hash values.
207 (sxhash_float): New function.
208 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
209 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
210 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
211 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
212 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
213 Adjust signatures to match updated version of code.
214 (consing_since_gc): Now EMACS_INT, since a single hash table can
215 use more than INT_MAX bytes.
216
698d32e2
DN
2172011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
218
219 Make it possible to build with GCC-4.6+ -O2 -flto.
220
221 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
222
fd6fa53f
SM
2232011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
224
225 * minibuf.c (get_minibuffer, read_minibuf_unwind):
226 Call minibuffer-inactive-mode.
227
864db017
JB
2282011-05-31 Juanma Barranquero <lekktu@gmail.com>
229
230 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
231 Update dependencies.
232
2ad0baf4
DN
2332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
234
235 * data.c (init_data): Remove code for UTS, this system is not
236 supported anymore.
237
4fcc2638
DN
2382011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
239
240 Don't force ./temacs to start in terminal mode.
241
242 * frame.c (make_initial_frame): Initialize faces in all cases, not
243 only when CANNOT_DUMP is defined.
244 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
245
c56e0fd5
DN
2462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
247
248 * dispnew.c (add_window_display_history): Use const for the string
249 pointer. Remove declaration, not needed.
250
333d54da 2512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 252
55d4c1b2 253 Use 'inline', not 'INLINE'.
333d54da 254 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
255 * alloc.c, fontset.c (INLINE): Remove.
256 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
257 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
258 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
259 * gmalloc.c (register_heapinfo): Use inline unconditionally.
260 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
261
738db178
DN
2622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
263
264 Make it possible to run ./temacs.
265
266 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
267 syms_of_callproc does the same thing. Remove test for
268 "initialized", do it in the caller.
269 * emacs.c (main): Avoid calling set_initial_environment when dumping.
270
620c53a6
SM
2712011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
272
273 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
274 (read_minibuf): Use get_minibuffer.
275 (syms_of_minibuf): Use DEFSYM.
276 (Qmetadata): New var.
277 * data.c (Qbuffer): Don't make it static.
278 (syms_of_data): Use DEFSYM.
279
e003a292
PE
2802011-05-31 Paul Eggert <eggert@cs.ucla.edu>
281
282 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
283 (CCL_CODE_MIN): New macro.
284
ed008a6d
PE
2852011-05-30 Paul Eggert <eggert@cs.ucla.edu>
286
3687c2ef
PE
287 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
288
ed008a6d
PE
289 * eval.c (Qdebug): Now static.
290 * lisp.h (Qdebug): Remove decl. This reverts a part of the
291 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
292 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
293
d66c4c7c
CY
2942011-05-29 Chong Yidong <cyd@stupidchicken.com>
295
296 * image.c: Various fixes to ImageMagick code comments.
297 (Fimagemagick_types): Doc fix.
298
5fbc2025
PE
2992011-05-29 Paul Eggert <eggert@cs.ucla.edu>
300
0196f88a
PE
301 Minor fixes prompted by GCC 4.6.0 warnings.
302
303 * xselect.c (converted_selections, conversion_fail_tag): Now static.
304
5fbc2025
PE
305 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
306 (x_clipboard_manager_save_all): Move extern decl to ...
307 * xterm.h: ... here, so that it can be checked for consistency.
308
1dd3c2d9
CY
3092011-05-29 Chong Yidong <cyd@stupidchicken.com>
310
311 * xselect.c (x_clipboard_manager_save_frame)
312 (x_clipboard_manager_save_all): New functions.
313 (Fx_clipboard_manager_save): Lisp function deleted.
314
315 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
316 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
317
318 * xterm.h: Update prototype.
319
5ba6571d
WX
3202011-05-28 William Xu <william.xwl@gmail.com>
321
322 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
323 exiting (Bug#8239).
324
3eaff834
JM
3252011-05-28 Jim Meyering <meyering@redhat.com>
326
e1900994 327 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
328 * fns.c (to_uchar): Define.
329 (crypto_hash_function): Use it to convert some newly-signed
330 variables to unsigned, to avoid sign-extension bugs. For example,
331 without this change, (md5 "truc") would evaluate to
332 45723a2aff78ff4fff7fff1114760e62 rather than the expected
333 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 334 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 335
0f6990a7
PE
3362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
337
338 Integer overflow fixes.
c8a9ca5a 339
08686060
PE
340 * dbusbind.c: Serial number integer overflow fixes.
341 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
342 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
343 to hold a serial number that is too large for a fixnum.
344 (Fdbus_method_return_internal, Fdbus_method_error_internal):
345 Check for serial numbers out of range. Decode any serial number
59568bf0 346 that was so large that it became a float. (Bug#8722)
08686060 347
2d1fc3c7
PE
348 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
349 (Fdbus_call_method, Fdbus_call_method_asynchronously):
350 Use XFASTINT rather than XUINT when numbers are nonnegative.
351 (xd_append_arg, Fdbus_method_return_internal):
352 (Fdbus_method_error_internal): Likewise. Also, for unsigned
353 arguments, check that Lisp number is nonnegative, rather than
59568bf0 354 silently wrapping negative numbers around. (Bug#8722)
30217ff0 355 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 356 (Bug#8722)
2d1fc3c7 357
c8a9ca5a
PE
358 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
359
519e1d69
PE
360 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
361
30569699
PE
362 ccl: add integer overflow checks
363 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
364 (IN_INT_RANGE): New macros.
365 (ccl_driver): Use them to check for integer overflow when
366 decoding a CCL program. Many of the new checks are whether XINT (x)
367 fits in int; it doesn't always, on 64-bit hosts. The new version
368 doesn't catch all possible integer overflows, but it's an
847044ea 369 improvement. (Bug#8719)
30569699 370
c11285dc
PE
371 * alloc.c (make_event_array): Use XINT, not XUINT.
372 There's no need for unsigned here.
373
fdccd48e
PE
374 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
375 This follows up to the 2011-05-06 change that substituted uintptr_t
376 for EMACS_INT. This case wasn't caught back then.
377
37910ab2
PE
378 Rework Fformat to avoid integer overflow issues.
379 * editfns.c: Include <float.h> unconditionally, as it's everywhere
380 now (part of C89). Include <verify.h>.
381 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
382 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
383 (Fformat): Avoid the prepass trying to compute sizes; it was only
384 approximate and thus did not catch overflow reliably. Instead, walk
385 through the format just once, formatting and computing sizes as we go,
386 checking for integer overflow at every step, and allocating a larger
387 buffer as needed. Keep track separately whether the format is
388 multibyte. Keep only the most-recently calculated precision, rather
389 than them all. Record whether each argument has been converted to
390 string. Use EMACS_INT, not int, for byte and char and arg counts.
391 Support field widths and precisions larger than INT_MAX. Avoid
392 sprintf's undefined behavior with conversion specifications such as %#d
393 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
394 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
395 formatting out-of-range floating point numbers with int
396 formats. (Bug#8668)
397
2e6578fb
PE
398 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
399
0ae6bdee
PE
400 * data.c: Avoid integer truncation in expressions involving floats.
401 * data.c: Include <intprops.h>.
402 (arith_driver): When there's an integer overflow in an expression
403 involving floating point, convert the integers to floating point
404 so that the resulting value does not suffer from catastrophic
405 integer truncation. For example, on a 64-bit host (* 4
406 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
407 Do not rely on undefined behavior after integer overflow.
408
de883a70
PE
409 merge count_size_as_multibyte, parse_str_to_multibyte
410 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 411 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
412 Check for integer overflow.
413 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
414 since it's now a duplicate of the other. This is more of
415 a character than a buffer op, so better that it's in character.c.
416 * fns.c, print.c: Adjust to above changes.
417
2ff916cb
PE
4182011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
419
420 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
421
f1b54466
PE
4222011-05-27 Paul Eggert <eggert@cs.ucla.edu>
423
fb1ac845
PE
424 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
425 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
426 (x_clipboard_manager_save): Now static.
427 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
428
f1b54466
PE
429 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
430 (crypto_hash_function): Now static.
431 Fix pointer signedness problems. Avoid unnecessary initializations.
432
a9f737ee
CY
4332011-05-27 Chong Yidong <cyd@stupidchicken.com>
434
435 * termhooks.h (Vselection_alist): Make it terminal-local.
436
437 * terminal.c (create_terminal): Initialize it.
438
439 * xselect.c: Support for clipboard managers.
440 (Vselection_alist): Move to termhooks.h as terminal-local var.
441 (LOCAL_SELECTION): New macro.
442 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
443 (symbol_to_x_atom): Remove gratuitous arg.
444 (x_handle_selection_request, lisp_data_to_selection_data)
445 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
446 (x_own_selection, x_get_local_selection, x_convert_selection):
447 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
448 (some_frame_on_display): Delete unused function.
449 (Fx_own_selection_internal, Fx_get_selection_internal)
450 (Fx_disown_selection_internal, Fx_selection_owner_p)
451 (Fx_selection_exists_p): New optional frame arg.
452 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
453 (x_handle_selection_clear): Don't treat other terminals with the
454 same keyboard specially. Use the terminal-local Vselection_alist.
455 (x_clear_frame_selections): Use Frun_hook_with_args.
456
457 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
458
459 * xterm.h: Add support for those atoms.
460
e067f0c1
CY
4612011-05-26 Chong Yidong <cyd@stupidchicken.com>
462
463 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
464 (converted_selections, conversion_fail_tag): New global variables.
465 (x_selection_request_lisp_error): Free the above.
466 (x_get_local_selection): Remove unnecessary code.
467 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
468 of converted selections stored in converted_selections.
469 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
470 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
471 (x_convert_selection): New function.
472 (x_handle_selection_event): Simplify.
473 (x_get_foreign_selection): Don't ignore incoming requests while
474 waiting for an answer; this will fail when we implement
475 SAVE_TARGETS, and seems unnecessary anyway.
476 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
477 (Vx_sent_selection_functions): Doc fix.
478
0f4aebc0
LL
4792011-05-26 Leo Liu <sdl.web@gmail.com>
480
481 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
482
e61124cd
YM
4832011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
484
485 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
486
487 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
488 for fringe update if it has periodic bitmap.
489 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
490 and fringe_bitmap_periodic_p.
491
492 * fringe.c (get_fringe_bitmap_data): New function.
493 (draw_fringe_bitmap_1, update_window_fringes): Use it.
494 (update_window_fringes): Record periodicity of fringe bitmap in glyph
495 row. Mark glyph row for fringe update if periodicity changed.
496
497 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
498 for fringe update unless it has periodic bitmap.
499
f16d9837
KH
5002011-05-25 Kenichi Handa <handa@m17n.org>
501
502 * xdisp.c (get_next_display_element): Set correct it->face_id for
503 a static composition.
504
e1b90ef6
LL
5052011-05-24 Leo Liu <sdl.web@gmail.com>
506
507 * deps.mk (fns.o):
508 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
509
510 * fns.c (crypto_hash_function, Fsha1): New function.
511 (Fmd5): Use crypto_hash_function.
512 (syms_of_fns): Add Ssha1.
513
7400048f
PE
5142011-05-22 Paul Eggert <eggert@cs.ucla.edu>
515
516 * gnutls.c: Remove unused macros.
517 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
518 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
519 Remove macros that are defined and never used.
520 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
521
abb71cf4
CY
5222011-05-22 Chong Yidong <cyd@stupidchicken.com>
523
524 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
525 (Fx_get_selection_internal): Minor cleanup.
526 (Fx_own_selection_internal): Rename arguments for consistency with
527 select.el.
528
6307db39
PE
5292011-05-22 Paul Eggert <eggert@cs.ucla.edu>
530
531 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
532
f3d4e0a4
CY
5332011-05-22 Chong Yidong <cyd@stupidchicken.com>
534
535 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
536
4d8ade89
YM
5372011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
538
539 * dispnew.c (scrolling_window): Don't exclude the case that the
540 last enabled row in the desired matrix touches the bottom boundary.
541
32078c8d
GM
5422011-05-21 Glenn Morris <rgm@gnu.org>
543
544 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
545 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
546 and add some more files.
32078c8d 547
7285dc67
EZ
5482011-05-20 Eli Zaretskii <eliz@gnu.org>
549
550 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
551 report_file_error introduced by the change from 2011-05-07.
552
89d1bd22
PE
5532011-05-20 Paul Eggert <eggert@cs.ucla.edu>
554
555 * systime.h (Time): Define only if emacs is defined.
556 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
557 where the include path doesn't have X11/X.h by default. See
558 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
559
e23640bb 5602011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
561
562 * composite.c (find_automatic_composition): Fix previous change.
563
b9704ad9
GM
5642011-05-20 Glenn Morris <rgm@gnu.org>
565
566 * lisp.mk: New file, split from Makefile.in.
567 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
568 (shortlisp): Remove.
569 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
570
4a720484
GM
5712011-05-19 Glenn Morris <rgm@gnu.org>
572
573 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
574 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
575 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
576 (lisp): Set the order to that of loadup.el.
577 (shortlisp): Make it a copy of $lisp.
578 (SOME_MACHINE_LISP): Remove.
579 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
580 Use just $shortlisp, not $SOME_MACHINE_LISP too.
581
a28d4396
KH
5822011-05-18 Kenichi Handa <handa@m17n.org>
583
584 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
585 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
586 (find_automatic_composition): Mostly rewrite for efficiency.
587
a2b1fa8e
JB
5882011-05-18 Juanma Barranquero <lekktu@gmail.com>
589
590 * makefile.w32-in: Update dependencies.
591
8e1f5610
CS
5922011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
593
594 * menu.c: Include limits.h (fixes the MS-Windows build broken by
595 revision 104625).
596
7025ee00 5972011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 598
cdfa6eab
PE
599 Fix some integer overflow issues, such as string length overflow.
600
06d6db33
PE
601 * insdel.c (count_size_as_multibyte): Check for string overflow.
602
2b4560a8
PE
603 * character.c (lisp_string_width): Check for string overflow.
604 Use EMACS_INT, not int, for string indexes and lengths; in
605 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
606 the resulting string length overflows an EMACS_INT; instead,
607 report a string overflow if no precision given. When checking for
608 precision exhaustion, use a check that cannot possibly have
609 integer overflow. (Bug#8675)
610 * character.h (lisp_string_width): Adjust to new signature.
611
cb93f9be
PE
612 * alloc.c (string_overflow): New function.
613 (Fmake_string): Use it. This doesn't change behavior, but saves
614 a few bytes and will simplify future changes.
615 * character.c (string_escape_byte8): Likewise.
616 * lisp.h (string_overflow): New decl.
617
1a1f3366
PE
618 Fixups, following up to the user-interface timestamp change.
619 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
620 for UI timestamps, instead of unsigned long.
9fbd6841
PE
621 * msdos.c (mouse_get_pos): Likewise.
622 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
623 * w32gui.h (Time): Define by including "systime.h" rather than by
624 declaring it ourselves. (Bug#8664)
625
d4e3e4d3
PE
626 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
627 * image.c (clear_image_cache): Likewise.
628
f6a24d19
PE
629 * term.c (term_mouse_position): Don't assume time_t wraparound.
630
08dc5ae6
PE
631 Be more systematic about user-interface timestamps.
632 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
633 and sometimes 'EMACS_UINT', to represent these timestamps.
634 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
635 This makes the code easier to follow, and makes it easier to catch
636 integer overflow bugs such as Bug#8664.
637 * frame.c (Fmouse_position, Fmouse_pixel_position):
638 Use Time, not unsigned long, for user-interface timestamps.
639 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
640 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
641 * keyboard.h (last_event_timestamp): Likewise.
642 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
643 * menu.h (xmenu_show): Likewise.
644 * term.c (term_mouse_position): Likewise.
645 * termhooks.h (struct input_event.timestamp): Likewise.
646 (struct terminal.mouse_position_hook): Likewise.
647 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
648 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
649 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
650 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
651 what it was before.
652 * menu.h, termhooks.h: Include "systime.h", for Time.
653
8e55734a
PE
654 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
655 Don't assume that the difference between two unsigned long values
656 can fit into an integer. At this point, we know button_down_time
657 <= event->timestamp, so the difference must be nonnegative, so
658 there's no need to cast the result if double-click-time is
659 nonnegative, as it should be; check that it's nonnegative, just in
660 case. This bug is triggered when events are more than 2**31 ms
86db42d2 661 apart (about 25 days). (Bug#8664)
8e55734a 662
841f1b75 663 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 664 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 665
3e26f69c
PE
666 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
667 that always fit in int. Use a sentinel instead of a counter, to
668 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
669 * frame.h (struct frame): Use int for menu_bar_items_used
670 instead of EMACS_INT, since it always fits in int.
3e26f69c 671
5cc152c0
PE
672 * menu.c (grow_menu_items): Check for int overflow.
673
d89eb65e
PE
674 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
675
5235bd3e
PE
676 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
677 Before, the code was not consistent. These values cannot exceed
678 2**31 - 1 so there's no need to make them unsigned.
679 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
680 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
681 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
682 as modifiers.
683 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
684
bc827e23
PE
685 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
686 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
687 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
688 presumably because the widths might not match.
689
78eb494e
PE
690 * window.c (size_window): Avoid needless test at loop start.
691
04f2d78b
CB
6922011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
693
694 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
695
d2fc7e3d 6962011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
697
698 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
699
d2fc7e3d 7002011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
701
702 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
703 `width' to `bar_area_x' and `bar_area_width', respectively.
704 (x_scroll_run): Take account of fringe background extension.
705
04f2d78b
CB
706 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
707 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
708 `bar_area_width', respectively.
709 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
710 background extension.
711
79b70037
GM
7122011-05-10 Jim Meyering <meyering@redhat.com>
713
714 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
715
2f142cc5
JB
7162011-05-10 Juanma Barranquero <lekktu@gmail.com>
717
718 * image.c (Finit_image_library): Return t for built-in image types,
719 like pbm and xbm. (Bug#8640)
720
57679c86
AS
7212011-05-09 Andreas Schwab <schwab@linux-m68k.org>
722
723 * w32menu.c (set_frame_menubar): Fix submenu allocation.
724
888c9e86
EZ
7252011-05-07 Eli Zaretskii <eliz@gnu.org>
726
b0512a1d
EZ
727 * w32console.c (Fset_screen_color): Doc fix.
728 (Fget_screen_color): New function.
729 (syms_of_ntterm): Defsubr it.
730
7285dc67
EZ
731 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
732 unlink the temporary file if Fcall_process didn't create it in the
733 first place.
734 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
735 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
736 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
737 cue to call_process_cleanup not to close that handle.
738
4d3fcc8e
BK
7392011-05-07 Ben Key <bkey76@gmail.com>
740
741 * makefile.w32-in: The bootstrap-temacs rule now makes use of
742 one of two shell specific rules, either bootstrap-temacs-CMD or
743 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
744 to the previous implementation of the bootstrap-temacs rule.
745 The bootstrap-temacs-CMD rule is similar to the previous
746 implementation of the bootstrap-temacs rule except that it
747 makes use of the ESC_CFLAGS variable instead of the CFLAGS
748 variable.
749
750 These changes, along with some changes to nt/configure.bat,
751 nt/gmake.defs, and nt/nmake.defs, are required to extend my
752 earlier fix to add support for --cflags and --ldflags options
753 that include quotes so that it works whether make uses cmd or
754 sh as the shell.
755
b4289b64
MA
7562011-05-06 Michael Albinus <michael.albinus@gmx.de>
757
758 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
759 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
760 is a constant.
761 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
762 a string. Handle both cases.
763 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
764 (Fdbus_register_method): Use Qinvalid_function.
765
af4c0e28
JB
7662011-05-06 Juanma Barranquero <lekktu@gmail.com>
767
768 * makefile.w32-in: Update dependencies.
769 (LISP_H): Add inttypes.h and stdin.h.
770 (PROCESS_H): Add unistd.h.
771
c51453d9
EZ
7722011-05-06 Eli Zaretskii <eliz@gnu.org>
773
774 * lread.c: Include limits.h (fixes the MS-Windows build broken by
775 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
776
8ff0ac3c 7772011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 778
4c4b566b
PE
779 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
780
aab2b9b5
PE
781 * term.c (vfatal): Remove stray call to va_end.
782 It's not needed and the C Standard doesn't allow it here anyway.
783
c378da0b
PE
784 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
785 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
786
288b08c7
PE
787 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
788 bytes.
789
e3601888
PE
790 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
791
db6c0e74
PE
792 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
793
dd5963ea
PE
794 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
795
88c9450f
PE
796 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
797
2f9442b8
PE
798 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
799
c032b5f8
PE
800 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
801 * charset.c (Fdefine_charset_internal): Don't initialize
802 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 803 32-bit int (Bug#8600).
a108c10b
PE
804
805 * lread.c (read_integer): Be more consistent with string-to-number.
806 Use string_to_number to do the actual conversion; this avoids
807 rounding errors and fixes some other screwups. Without this fix,
808 for example, #x1fffffffffffffff was misread as -2305843009213693952.
809 (digit_to_number): Move earlier, for benefit of read_integer.
810 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 811 not a digit in any supported base. (Bug#8602)
a108c10b 812
ad5f9eea
PE
813 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
814
aec1708a
PE
815 * dispnew.c (scrolling_window): Return 1 if we scrolled,
816 to match comment at start of function. This also removes a
817 GCC warning about overflow in a 32+64-bit port.
818
47be4ab5
PE
819 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
820
371cac43
PE
821 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
822 Reported by Stefan Monnier in
823 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
824 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
825 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 826
d01a7826
PE
827 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
828 (EMACS_UINTPTR): Likewise, with uintptr_t.
829
7fd47d5c
PE
830 * lisp.h: Prefer 64-bit EMACS_INT if available.
831 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
832 on 32-bit hosts that have 64-bit int, so that they can access
833 large files.
122b0c86
PE
834 However, temporarily disable this change unless the temporary
835 symbol WIDE_EMACS_INT is defined.
7fd47d5c 836
8727937b
PE
837 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
838
8ac068ac
PE
839 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
840 This removes an assumption that EMACS_INT and long are the same
841 width as pointers. The assumption is true for Emacs porting targets
842 now, but we want to make other targets possible.
843 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
844 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
845 In the rest of the code, change types of integers that hold casted
846 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
847 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
848 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
849 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
850 No need to cast type when ORing.
851 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
852 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
853 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
854 assume EMACS_INT is the same width as char *.
855 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
856 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
857 Remove no-longer-needed casts.
858 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
859 (xg_tool_bar_help_callback, xg_make_tool_item):
860 Use EMACS_INTPTR to hold an integer
861 that will be cast to void *; this can avoid a GCC warning
862 if EMACS_INT is not the same width as void *.
863 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
864 * xdisp.c (display_echo_area_1, resize_mini_window_1):
865 (current_message_1, set_message_1):
866 Use a local to convert to proper width without a cast.
867 * xmenu.c (dialog_selection_callback): Likewise.
868
ede49d71
PE
869 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
870 Also, don't assume VALBITS / RAND_BITS is less than 5,
871 and don't rely on undefined behavior when shifting a 1 left into
872 the sign bit.
873 * lisp.h (get_random): Change signature to match.
874
2f30ecd0
PE
875 * lread.c (hash_string): Use size_t, not int, for hash computation.
876 Normally we prefer signed values; but hashing is special, because
877 it's better to use unsigned division on hash table sizes so that
878 the remainder is nonnegative. Also, size_t is the natural width
879 for hashing into memory. The previous code used 'int', which doesn't
880 retain enough info to hash well into very large tables.
881 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
882
2a866e7b
PE
883 * dbusbind.c: Don't possibly lose pointer info when converting.
884 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
885 Use XPNTR rather than XHASH, so that the high-order bits of
886 the pointer aren't lost when converting through void *.
887
51639eac
PE
888 * eval.c (Fautoload): Don't double-shift a pointer.
889
92394119
PE
890 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
891
dbdb9a7c
JB
8922011-05-06 Juanma Barranquero <lekktu@gmail.com>
893
894 * gnutls.c (DEF_GNUTLS_FN):
895 * image.c (DEF_IMGLIB_FN): Make function pointers static.
896
db7a0b4f
AS
8972011-05-05 Andreas Schwab <schwab@linux-m68k.org>
898
899 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
900 marker. (Bug#8610)
901
f7ff1b0f 9022011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
903
904 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
905 New version that can reserve upto 2GB of heap space.
906
f7ff1b0f 9072011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
908
909 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
910
639c109b
TZ
9112011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
912
913 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
914 `gnutls_certificate_set_x509_key_file'.
915
d2127135
JB
9162011-05-05 Juanma Barranquero <lekktu@gmail.com>
917
918 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
919 Update dependencies.
920
e968f4f3
JB
9212011-05-04 Juanma Barranquero <lekktu@gmail.com>
922
923 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
924 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
925 Remove unused parameter `fildes'.
926 * process.c (read_process_output, send_process): Don't pass it.
927
84d358f0
JB
9282011-05-04 Juanma Barranquero <lekktu@gmail.com>
929
930 Fix previous change: the library cache is defined in w32.c.
931 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
932 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
933
0898ca10
JB
9342011-05-04 Juanma Barranquero <lekktu@gmail.com>
935
936 Implement dynamic loading of GnuTLS on Windows.
937
938 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
939 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
940 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
941 Declare.
942
943 * gnutls.c (Qgnutls_dll): Define.
944 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
945 (gnutls_*): Declare function pointers.
946 (init_gnutls_functions): New function to initialize function pointers.
947 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
948 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
949 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
950 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
951 (emacs_gnutls_write, emacs_gnutls_read)
952 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
953 (Fgnutls_available_p): New function.
954 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
955 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
956 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
957
958 * image.c: Include w32.h.
959 (Vimage_type_cache): Delete.
960 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
961 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
962 (w32_delayed_load): Move to w32.c.
963
964 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
965
966 * w32.c (QCloaded_from, Vlibrary_cache): Define.
967 (w32_delayed_load): Move from image.c. When loading a library, record
968 its filename in the :loaded-from property of the library id.
969 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
970 Initialize and staticpro them.
971 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
972
973 * process.c: Include lisp.h before w32.h, not after.
974 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
975 instead of gnutls_record_check_pending.
976
977 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
978
ff4de4aa
TZ
9792011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
980
981 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
982 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
983 as passed in.
984
abe95abb
JD
9852011-05-03 Jan Djärv <jan.h.d@swipnet.se>
986
987 * xterm.c (x_set_frame_alpha): Do not set property on anything
988 else than FRAME_X_OUTER_WINDOW (Bug#8608).
989
e16e55d4
JB
9902011-05-02 Juanma Barranquero <lekktu@gmail.com>
991
992 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
993
bafcf6a5
JB
9942011-05-02 Juanma Barranquero <lekktu@gmail.com>
995
996 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
997 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
998 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
999 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1000 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1001 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1002 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1003 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1004 (Qgnutls_bootprop_callbacks_verify): Make static.
1005
e7a6747f
AS
10062011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1007
19ed11ba
AS
1008 * callproc.c: Indentation fixup.
1009
e7a6747f 1010 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1011 (wait_for_termination, interruptible_wait_for_termination):
1012 Move after wait_for_termination_1.
e7a6747f 1013
1ef14cb4
LMI
10142011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1015
1016 * sysdep.c (interruptible_wait_for_termination): New function
1017 which is like wait_for_termination, but allows keyboard
1018 interruptions.
1019
1020 * callproc.c (Fcall_process): Add (:file "file") as an option for
1021 the STDOUT buffer.
1022 (Fcall_process_region): Ditto.
1023
330d880c
EZ
10242011-04-30 Eli Zaretskii <eliz@gnu.org>
1025
8db90b73
EZ
1026 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1027 rather than `XVECTOR (FOO)->size'.
1028
330d880c
EZ
1029 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1030 inttypes.h, as a gnulib replacement is used if it not available in
1031 system headers.
1032
15cbd324
EZ
10332011-04-21 Eli Zaretskii <eliz@gnu.org>
1034
1035 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1036 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1037 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1038
1039 * coding.c (coding_alloc_by_realloc): Error out if destination
1040 will grow beyond MOST_POSITIVE_FIXNUM.
1041 (decode_coding_emacs_mule): Abort if there isn't enough place in
1042 charbuf for the composition carryover bytes. Reserve an extra
1043 space for up to 2 characters produced in a loop.
1044 (decode_coding_iso_2022): Abort if there isn't enough place in
1045 charbuf for the composition carryover bytes.
1046
10472011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1048
ae940cca
EZ
1049 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1050 aborting when %lld or %lll format is passed.
1051 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1052 %llo or %llx format is passed. (Bug#8545)
1053
03ab8921
EZ
1054 * window.c (window_scroll_line_based): Use a marker instead of
1055 simple variables to record original value of point. (Bug#7952)
1056
afda1437
EZ
1057 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1058 produced by %s or %c overflows available buffer space. (Bug#8545)
1059
f76dee0c
PE
10602011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1061
1062 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1063 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1064
fdc5744d
JB
10652011-04-28 Juanma Barranquero <lekktu@gmail.com>
1066
1067 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1068
638f053a
JB
10692011-04-28 Juanma Barranquero <lekktu@gmail.com>
1070
1071 * keyboard.c (Qdelayed_warnings_hook): Define.
1072 (command_loop_1): Run `delayed-warnings-hook'
1073 if Vdelayed_warnings_list is non-nil.
1074 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1075 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1076
d178f871
EZ
10772011-04-28 Eli Zaretskii <eliz@gnu.org>
1078
1079 * doprnt.c (doprnt): Don't return value smaller than the buffer
1080 size if the message was truncated. (Bug#8545).
1081
b124fd93
JB
10822011-04-28 Juanma Barranquero <lekktu@gmail.com>
1083
1084 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1085 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1086
e810457d
PE
10872011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1088
1089 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1090
ea51cceb
JB
10912011-04-27 Juanma Barranquero <lekktu@gmail.com>
1092
1093 * makefile.w32-in: Update dependencies.
1094
94dcfacf
EZ
10952011-04-27 Eli Zaretskii <eliz@gnu.org>
1096
1097 Improve `doprnt' and its usage. (Bug#8545)
1098 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1099 `format_end'. Remove support for %l as a conversion specifier.
1100 Don't use xrealloc. Improve diagnostics when the %l size modifier
1101 is used. Update the commentary.
1102
1103 * eval.c (verror): Simplify calculation of size_t.
1104
1105 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1106 messages.
1107
f61f41d7
PE
11082011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1109
1110 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1111 change.
1112
96fb4434
PE
11132011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1114
1115 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1116 This makes this file independent of the recent pseudovector change.
1117
671875da 11182011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1119
69e9b5a3
PE
1120 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1121
b5f869a7 1122 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1123 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1124 Remove unused local.
c8926152 1125 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1126
841a1577 1127 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1128 GCC 4.6.0 optimizes based on type-based alias analysis.
1129 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1130 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1131 != &v->size, and therefore "v->size = 1; b->size = 2; return
1132 v->size;" must therefore return 1. This assumption is incorrect
1133 for Emacs, since it type-puns struct Lisp_Vector * with many other
1134 types. To fix this problem, this patch adds a new type struct
f904488f 1135 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1136 and pseudovectors, and helps optimizing compilers not get fooled
1137 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1138 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1139 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1140 the size member.
eab3844f
PE
1141 (XSETPVECTYPE): Rewrite in terms of new macro.
1142 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1143 This is a bit clearer, and further avoids the possibility of
1144 undesirable aliasing.
1145 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1146 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1147 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1148 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1149 (ASIZE): Now uses header.size rather than size.
1150 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1151 to avoid the hassle of writing XVECTOR (foo)->header.size.
1152 (struct vectorlike_header): New type.
eab3844f
PE
1153 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1154 object, to help avoid aliasing.
1155 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1156 (SUBRP): Likewise, since Lisp_Subr is a special case.
1157 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1158 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1159 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1160 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1161 changed to be "header.size" and "header.next".
1162 * buffer.h (struct buffer): Likewise.
1163 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1164 * frame.h (struct frame): Likewise.
1165 * process.h (struct Lisp_Process): Likewise.
1166 * termhooks.h (struct terminal): Likewise.
1167 * window.c (struct save_window_data, struct saved_window): Likewise.
1168 * window.h (struct window): Likewise.
1169 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1170 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1171 * buffer.c (init_buffer_once): Likewise.
1172 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1173 special case.
1174 * process.c (Fformat_network_address): Use local var for size,
1175 for brevity.
1176
0df1eac5
PE
1177 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1178
847ab9d1 1179 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1180 * data.c (atof): Remove decl; no longer used or needed.
1181 (digit_to_number): Move to lread.c.
1182 (Fstring_to_number): Use new string_to_number function, to be
1183 consistent with how the Lisp reader treats infinities and NaNs.
1184 Do not assume that floating-point numbers represent EMACS_INT
1185 without losing information; this is not true on most 64-bit hosts.
1186 Avoid double-rounding errors, by insisting on integers when
1187 parsing non-base-10 numbers, as the documentation specifies.
1188 * lisp.h (string_to_number): New decl, replacing ...
1189 (isfloat_string): Remove.
bc0a5c13 1190 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1191 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1192 appears to have been a coding error. Similarly, do not accept
1193 strings like +-1e0 as floating point numbers. Do not report
1194 overflow for integer overflows unless the base is not 10 which
1195 means we have no simple and reliable way to continue.
1196 Break out the floating-point parsing into a new
1197 function string_to_number, so that Fstring_to_number parses
1198 floating point numbers consistently with the Lisp reader.
04f2d78b 1199 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1200 (E_CHAR, EXP_INT): Remove, replacing with ...
1201 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1202 (string_to_number): New function, replacing isfloat_string.
1203 This function checks for valid syntax and produces the resulting
1204 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1205 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1206 so that overflow for non-base-10 numbers is reported only when
1207 there's no portable and simple way to convert to floating point.
452f4150 1208
67769ffc
PE
1209 * textprop.c (set_text_properties_1): Rewrite for clarity,
1210 and to avoid GCC warning about integer overflow.
1211
c20db43f
PE
1212 * intervals.h (struct interval): Use EMACS_INT for members
1213 where EMACS_UINT might cause problems. See
1214 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1215 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1216 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1217 All uses changed.
37aa2f85
PE
1218 (offset_intervals): Tell GCC not to worry about length overflow
1219 when negating a negative length.
c20db43f 1220
2538aa2f
PE
1221 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1222 (overrun_check_free): Likewise.
1223
f2d3008d
PE
1224 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1225 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1226 word size.
1227
ec8df744
PE
1228 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1229 (gnutls_make_error): Rename local to avoid shadowing.
1230 (gnutls_emacs_global_deinit): ifdef out; not used.
1231 (Fgnutls_boot): Use const for pointer to readonly storage.
1232 Comment out unused local. Fix pointer signedness problems.
1233
640ee02d
PE
1234 * lread.c (openp): Don't stuff size_t into an 'int'.
1235 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1236 about possible signed overflow.
1237
6048fb2a
PE
1238 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1239 (GDK_KEY_g): Don't define if already defined.
1240 (xg_prepare_tooltip): Avoid pointer signedness problem.
1241 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1242
fa3c87e1
PE
1243 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1244 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1245
2172544b
PE
1246 * xfns.c (Fx_window_property): Simplify a bit,
1247 to make a bit faster and to avoid GCC 4.6.0 warning.
1248 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1249
9b821a21
PE
1250 * fns.c (internal_equal): Don't assume size_t fits in int.
1251
3c616cfa
PE
1252 * alloc.c (compact_small_strings): Tighten assertion a little.
1253
c2982e87
PE
1254 Replace pEd with more-general pI, and fix some printf arg casts.
1255 * lisp.h (pI): New macro, generalizing old pEd macro to other
1256 conversion specifiers. For example, use "...%"pI"d..." rather
1257 than "...%"pEd"...".
1258 (pEd): Remove. All uses replaced with similar uses of pI.
1259 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1260 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1261 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1262 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1263 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1264 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1265 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1266 64-bit hosts.
1267 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1268 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1269 * print.c (safe_debug_print, print_object): Likewise.
1270 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1271 to int.
6f04d126
PE
1272 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1273 avoiding the 0 flag, which is not portable.
c2982e87
PE
1274 * process.c (Fmake_network_process): Use pI to avoid cast.
1275 * region-cache.c (pp_cache): Likewise.
1276 * xdisp.c (decode_mode_spec): Likewise.
1277 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1278 behavior on 64-bit hosts with printf arg.
6f04d126 1279 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1280 (x_stop_queuing_selection_requests): Likewise.
1281 (x_get_window_property): Don't truncate byte count to an 'int'
1282 when tracing.
0b432f21 1283
5e073ec7
PE
1284 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1285 here, since it parses constructs like leading '-' and spaces,
1286 which are not wanted; and it overflows with large numbers.
1287 Instead, simply match F[0-9]+, which is what is wanted anyway.
1288
36372bf9
PE
1289 * alloc.c: Remove unportable assumptions about struct layout.
1290 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1291 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1292 (allocate_vectorlike, make_pure_vector): Use the new macros,
1293 plus offsetof, to remove unportable assumptions about struct layout.
1294 These assumptions hold on all porting targets that I know of, but
1295 they are not guaranteed, they're easy to remove, and removing them
1296 makes further changes easier.
1297
0b432f21
PE
1298 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1299 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1300 (string_overrun_cookie): Now const. Use initializers that
1301 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1302 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1303 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1304 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1305 multiple of sizeof (EMACS_INT); it need not be, if
1306 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1307 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1308
895009e1
JB
13092011-04-26 Juanma Barranquero <lekktu@gmail.com>
1310
1311 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1312
6a7a1b0b
TZ
13132011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1314
1315 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1316 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1317 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1318
841a1577 13192011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1320
1321 * lisp.h (Qdebug): List symbol.
895009e1 1322 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1323 * keyboard.c (debug-on-event): New variable.
1324 (handle_user_signal): Break into debugger when debug-on-event
1325 matches the current signal symbol.
1326
f2d3ba6f
DN
13272011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1328
1329 * alloc.c (check_sblock, check_string_bytes)
1330 (check_string_free_list): Convert to standard C.
1331
42ce4c63
TZ
13322011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1333
1334 * w32.c (emacs_gnutls_push): Fix typo.
1335
825cd63c
EZ
13362011-04-25 Eli Zaretskii <eliz@gnu.org>
1337
fb11d64d
EZ
1338 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1339 "cast to pointer from integer of different size".
1340
825cd63c
EZ
1341 Improve doprnt and its use in verror. (Bug#8545)
1342 * doprnt.c (doprnt): Document the set of format control sequences
1343 supported by the function. Use SAFE_ALLOCA instead of always
1344 using `alloca'.
1345
1346 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1347 is one byte too soon. Don't use xrealloc; instead xfree and
1348 xmalloc anew.
1349
e061a11b
TZ
13502011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1351
1352 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1353 callbacks stage.
1354
1355 * gnutls.c: Renamed global_initialized to
1356 gnutls_global_initialized. Added internals for the
1357 :verify-hostname-error, :verify-error, and :verify-flags
1358 parameters of `gnutls-boot' and documented those parameters in the
1359 docstring. Start callback support.
1360 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1361 unless a fatal error occured. Call gnutls_alert_send_appropriate
1362 on error. Return error code.
1363 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1364 (emacs_gnutls_read): Likewise.
1365 (Fgnutls_boot): Return handshake error code.
1366 (emacs_gnutls_handle_error): New function.
1367 (wsaerror_to_errno): Likewise.
1368
1369 * w32.h (emacs_gnutls_pull): Add prototype.
1370 (emacs_gnutls_push): Likewise.
1371
1372 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1373 (emacs_gnutls_push): Likewise.
1374
13752011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1376
1377 * process.c (wait_reading_process_output): Check if GnuTLS
1378 buffered some data internally if no FDs are set for TLS
1379 connections.
1380
1381 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1382 (LIBS): Link to USER_LIBS.
1383 ($(BLD)/gnutls.$(0)): New target.
1384
fa6996bc
EZ
13852011-04-24 Eli Zaretskii <eliz@gnu.org>
1386
eb35682e
EZ
1387 * xdisp.c (handle_single_display_spec): Rename the
1388 display_replaced_before_p argument into display_replaced_p, to
1389 make it consistent with the commentary. Fix typos in the
1390 commentary.
1391
e2ad650c
EZ
1392 * textprop.c (syms_of_textprop): Remove dead code.
1393 (copy_text_properties): Delete obsolete commentary about an
1394 interface that was deleted long ago. Fix typos in the description
1395 of arguments.
1396
1b2de274
EZ
1397 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1398 to changes in oldXMenu/XMenu.h from 2011-04-16.
1399 <menu_help_message, prev_menu_help_message>: Constify.
1400 (IT_menu_make_room): menu->help_text is now `const char **';
1401 adjust.
1402
1403 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1404 to changes in oldXMenu/XMenu.h from 2011-04-16.
1405 (struct XMenu): Declare `help_text' `const char **'.
1406
1407 * xfaces.c <Qunspecified>: Make extern again.
1408
1409 * syntax.c: Include sys/types.h before including regex.h, as
1410 required by Posix.
1411
762b15be
EZ
1412 * doc.c (get_doc_string): Improve the format passed to `error'.
1413
1414 * doprnt.c (doprnt): Improve commentary.
1415
1416 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1417
1418 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1419 them with etags.
1420
f1052e5d
EZ
1421 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1422 changes in globals.h immediately force recompilation.
762b15be
EZ
1423 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1424 $(CURDIR)/s/ms-w32.h.
1425 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1426
fa6996bc
EZ
1427 * character.c (Fchar_direction): Function deleted.
1428 (syms_of_character): Don't defsubr it.
1429 <char-direction-table>: Deleted.
1430
e6c3da20
EZ
14312011-04-23 Eli Zaretskii <eliz@gnu.org>
1432
1433 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1434 * doprnt.c: Include limits.h.
1435 (SIZE_MAX): New macro.
04f2d78b
CB
1436 (doprnt): Return a size_t value. 2nd arg is now size_t.
1437 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1438 Improve overflow protection. Support `l' modifier for integer
1439 conversions. Support %l conversion. Don't assume an EMACS_INT
1440 argument for integer conversions and for %c.
1441
1442 * lisp.h (doprnt): Restore prototype.
1443
1444 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1445 $(SRC)/character.h.
1446
1447 * Makefile.in (base_obj): Add back doprnt.o.
1448
1449 * deps.mk (doprnt.o): Add back prerequisites.
1450 (callint.o): Depend on character.h.
1451
1452 * eval.c (internal_lisp_condition_case): Include the handler
1453 representation in the error message.
1454 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1455 when breaking from the loop.
1456
1457 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1458
1459 * callint.c (Fcall_interactively): When displaying error message
1460 about invalid control letter, pass the character's codepoint, not
1461 a pointer to its multibyte form. Improve display of the character
1462 in octal and display also its hex code.
1463
1464 * character.c (char_string): Use %x to display the (unsigned)
1465 codepoint of an invalid character, to avoid displaying a bogus
1466 negative value.
1467
1468 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1469 `error', not SYMBOL_NAME itself.
1470
1471 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1472 character arguments to `error'.
1473
1474 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1475 to `error' in error message about FINAL_CHAR argument. Make sure
1476 FINAL_CHAR is a character, and use %c when it is passed as
1477 argument to `error'.
1478
4ffd0d6b 14792011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1480
1481 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1482
1483 * w32.c: Include <time.h>.
1484 (sys_localtime): New function.
1485
4ffd0d6b 14862011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1487
1488 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1489
4ffd0d6b 1490 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1491
4ffd0d6b 14922011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1493
4ffd0d6b
GM
1494 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1495 zombies (Bug#8467).
aac0c6e3 1496
04c56954
EZ
14972011-04-19 Eli Zaretskii <eliz@gnu.org>
1498
1499 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1500 gl_state.e_property when gl_state.object is Qt.
1501
1502 * insdel.c (make_gap_larger): Remove limitation of buffer size
1503 to <= INT_MAX.
1504
16a43933
CY
15052011-04-18 Chong Yidong <cyd@stupidchicken.com>
1506
1507 * xdisp.c (lookup_glyphless_char_display)
1508 (produce_glyphless_glyph): Handle cons cell entry in
1509 glyphless-char-display.
1510 (Vglyphless_char_display): Document it.
1511
1512 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1513 glyphless-char-display.
1514
4581706e
CY
15152011-04-17 Chong Yidong <cyd@stupidchicken.com>
1516
1517 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1518
1519 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1520
1521 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1522 definition for no-X builds.
1523
4887c6e2 15242011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1525
fd35b6f9
PE
1526 Static checks with GCC 4.6.0 and non-default toolkits.
1527
5c1ccb01
PE
1528 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1529
006c5daa
PE
1530 * process.c (keyboard_bit_set): Define only if SIGIO.
1531 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1532 (send_process): Repair possible setjmp clobbering.
1533
efc736d3
PE
1534 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1535
4e2fe2e6
PE
1536 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1537
f97334a2
PE
1538 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1539
4e75f29d
PE
1540 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1541 Define only if needed.
1542
90efadd1
PE
1543 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1544 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1545 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1546
3c647824
PE
1547 * dispextern.h (struct redisplay_interface): Rename param
1548 to avoid shadowing.
e264f262 1549 * termhooks.h (struct terminal): Likewise.
761383f4 1550 * xterm.c (xembed_send_message): Likewise.
3c647824 1551
b58c5c4a
PE
1552 * insdel.c (make_gap_smaller): Define only if
1553 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1554
cad59032
PE
1555 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1556 it.
1557
c339dc2e
PE
1558 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1559 so that we aren't warned about unused symbols.
1560
91a3e27b
PE
1561 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1562
399c71d3 1563 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1564
8ffc96f5
PE
1565 * xfns.c (x_real_positions): Mark locals as initialized.
1566
eef9bc79
PE
1567 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1568
098db9dd
PE
1569 * xterm.c: Fix problems found by static analysis with other toolkits.
1570 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1571 (x_dispatch_event): Declare static if USE_GTK, and
1572 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1573 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1574 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1575 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1576 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1577
eb18f6cc
PE
1578 * xmenu.c (menu_help_callback): Pointer type fixes.
1579 Use const pointers when pointing at readonly data. Avoid pointer
1580 signedness clashes.
1581 (FALSE): Remove unused macro.
1582 (update_frame_menubar): Remove unused decl.
1583
1fe72bf8
PE
1584 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1585
60d9e1db
PE
1586 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1587 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1588 (single_menu_item): Rename local to avoid shadowing.
1589
39261c26
PE
1590 * keyboard.c (make_lispy_event): Remove unused local var.
1591
018c5e19
PE
1592 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1593 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1594
63d2b86e
PE
1595 * bitmaps: Change bitmaps from unsigned char back to the X11
1596 compatible char. Avoid the old compiler warnings about
1597 out-of-range initializers by using, for example, '\xab' rather
1598 than 0xab.
1599
aefd87e1
PE
1600 * xgselect.c (xgselect_initialize): Check vs interface
1601 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1602
bf501fb9
PE
1603 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1604
e9829fdf
PE
1605 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1606 to read-only memory.
1607
1086c095
PE
1608 * fns.c (vector): Remove; this old hack is no longer needed.
1609
2baccd04 1610 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1611 Remove unused var.
dde42981 1612 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1613
72391843 1614 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1615
436c16df 1616 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1617 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1618 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1619
92bb796d 1620 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1621 (x_term_init): Remove local to avoid shadowing.
92bb796d 1622
764430a3 1623 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1624
1625 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1626 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1627
d1dfb56c
EZ
16282011-04-16 Eli Zaretskii <eliz@gnu.org>
1629
c4354cb4
EZ
1630 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1631
d1dfb56c
EZ
1632 Fix regex.c, syntax.c and friends for buffers > 2GB.
1633 * syntax.h (struct gl_state_s): Declare character position members
1634 EMACS_INT.
1635
1636 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1637
04f2d78b
CB
1638 * textprop.c (verify_interval_modification, interval_of):
1639 Declare arguments EMACS_INT.
d1dfb56c
EZ
1640
1641 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1642 EMACS_INT.
1643
1644 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1645
1646 * indent.c (Fvertical_motion): Local variable it_start is now
1647 EMACS_INT.
1648
1649 * regex.c (re_match, re_match_2, re_match_2_internal)
1650 (bcmp_translate, regcomp, regexec, print_double_string)
1651 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1652 (re_compile_pattern, re_exec): Declare arguments and local
1653 variables `size_t' and `ssize_t' and return values `regoff_t', as
1654 appropriate.
1655 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1656 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1657 <compile_stack_type>: `size' and `avail' are now `size_t'.
1658
1659 * regex.h <regoff_t>: Use ssize_t, not int.
1660 (re_search, re_search_2, re_match, re_match_2): Arguments that
1661 specify buffer/string position and length are now ssize_t and
1662 size_t. Return type is regoff_t.
1663
613052cd
BK
16642011-04-16 Ben Key <bkey76@gmail.com>
1665
1666 * nsfont.m: Fixed bugs in ns_get_family and
1667 ns_descriptor_to_entity that were caused by using free to
1668 deallocate memory blocks that were allocated by xmalloc (via
1669 xstrdup). This caused Emacs to crash when compiled with
1670 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1671 --enable-checking=xmallocoverrun). xfree is now used to
1672 deallocate these memory blocks.
1673
4170f62f 16742011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1675
71b41406
PE
1676 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1677
9587a89d
PE
1678 emacs_write: Accept and return EMACS_INT for sizes.
1679 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1680 et seq.
1681 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1682 Accept and return EMACS_INT.
1683 (emacs_gnutls_write): Return the number of bytes written on
1684 partial writes.
1685 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1686 (emacs_read, emacs_write): Remove check for negative size, as the
1687 Emacs source code has been audited now.
9587a89d
PE
1688 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1689 (emacs_read, emacs_write): Use it.
273a5f82
PE
1690 * process.c (send_process): Adjust to the new signatures of
1691 emacs_write and emacs_gnutls_write. Do not attempt to store
1692 a byte offset into an 'int'; it might overflow.
9587a89d 1693 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1694
3e047f51
PE
1695 * sound.c: Don't assume sizes fit in 'int'.
1696 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1697 Return EMACS_INT, not int.
3e047f51 1698 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1699 Accept EMACS_INT, not int.
1700 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1701 record read return values.
1702
cc39a9db
BK
17032011-04-15 Ben Key <bkey76@gmail.com>
1704
c9d0ec6d
JB
1705 * keyboard.c (Qundefined): Don't declare static since it is used
1706 in nsfns.m.
1707 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1708 static since they are used in nsfont.m.
cc39a9db 1709
6c60eb9f
SM
17102011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1711
1712 * process.c (Qprocessp): Don't declare static.
1713 * lisp.h (Qprocessp): Declare again.
1714
7990b61a
JB
17152011-04-15 Juanma Barranquero <lekktu@gmail.com>
1716
1717 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1718
5d4cb038
PE
17192011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1720
8bd7b830 1721 Improve C-level modularity by making more things 'static'.
cd64ea1d 1722
e3b27b31
PE
1723 Don't publish debugger-only interfaces to other modules.
1724 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1725 (verify_bytepos, count_markers): Move decls to the only modules
1726 that need them.
1727 * region-cache.h (pp_cache): Likewise.
1728 * window.h (check_all_windows): Likewise.
1729 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1730
5d4cb038
PE
1731 * sysdep.c (croak): Now static, if
1732 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1733 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1734
1735 * alloc.c (refill_memory_reserve): Now static if
1736 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1737 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1738
e87b6180
PE
1739 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1740 Define only if USE_LUCID.
1741
ac64929e
PE
1742 * xrdb.c (x_customization_string, x_rm_string): Now static.
1743
6f37259d
PE
1744 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1745 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1746
1683e3ab
PE
1747 * xdisp.c (draw_row_with_mouse_face): Now static.
1748 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1749
de9c2632
PE
1750 * window.h (check_all_windows): Mark externally visible.
1751
2b96acb7
PE
1752 * window.c (window_deletion_count): Now static.
1753
1754 * undo.c: Make symbols static if they're not exported.
1755 (last_undo_buffer, last_boundary_position, pending_boundary):
1756 Now static.
1757
50436f33
PE
1758 * textprop.c (interval_insert_behind_hooks): Now static.
1759 (interval_insert_in_front_hooks): Likewise.
1760
64520e5c
PE
1761 * term.c: Make symbols static if they're not exported.
1762 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1763 (max_frame_lines, tty_set_terminal_modes):
1764 (tty_reset_terminal_modes, tty_turn_off_highlight):
1765 (get_tty_terminal): Now static.
1766 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1767 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1768 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1769 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1770 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1771
1fa53021
PE
1772 * sysdep.c: Make symbols static if they're not exported.
1773 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1774 Now static.
1775 (sigprocmask_set, full_mask): Remove; unused.
1776 (wait_debugging): Mark as visible.
1777 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1778 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1779
d4b43b22
PE
1780 * syntax.c (syntax_temp): Define only if !__GNUC__.
1781
b7c513d0
PE
1782 * sound.c (current_sound_device, current_sound): Now static.
1783
989b29ad
PE
1784 * search.c (searchbufs, searchbuf_head): Now static.
1785
13a55a78
PE
1786 * scroll.c (scroll_cost): Remove; unused.
1787 * dispextern.h (scroll_cost): Remove decl.
1788
de68a1fc
PE
1789 * region-cache.h (pp_cache): Mark as externally visible.
1790
40ccffa6
PE
1791 * process.c: Make symbols static if they're not exported.
1792 (process_tick, update_tick, create_process, chan_process):
1793 (Vprocess_alist, proc_buffered_char, datagram_access):
1794 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1795 (deactivate_process): Mark defn as static, as well as decl.
1796 * lisp.h (create_process): Remove decl.
1797 * process.h (chan_process, Vprocess_alist): Remove decls.
1798
ad64fc97
PE
1799 * print.c: Make symbols static if they're not exported.
1800 (print_depth, new_backquote_output, being_printed, print_buffer):
1801 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1802 (print_interval, print_number_index, initial_stderr_stream):
1803 Now static.
1804 * lisp.h (Fprinc): Remove decl.
1805 (debug_output_compilation_hack): Mark as externally visible.
1806
adddb265
PE
1807 * sysdep.c (croak): Move decl from here to syssignal.h.
1808 * syssignal.h (croak): Put it here, so the API can be checked when
1809 'croak' is called from dissociate_if_controlling_tty.
1810
1717ede2
PE
1811 * minibuf.c: Make symbols static if they're not exported.
1812 (minibuf_save_list, choose_minibuf_frame): Now static.
1813 * lisp.h (choose_minibuf_frame): Remove decl.
1814
fa5fb2bc
PE
1815 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1816
1e3890d1
PE
1817 * lread.c: Make symbols static if they're not exported.
1818 (read_objects, initial_obarray, oblookup_last_bucket_number):
1819 Now static.
1820 (make_symbol): Remove; unused.
1821 * lisp.h (initial_obarray, make_symbol): Remove decls.
1822
8a1414fa
PE
1823 * keyboard.c: Make symbols static if they're not exported.
1824 (single_kboard, recent_keys_index, total_keys, recent_keys):
1825 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1826 (this_single_command_key_start, echoing, last_auto_save):
1827 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1828 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1829 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1830 (Vlispy_mouse_stem, double_click_count):
1831 Now static.
1832 (force_auto_save_soon): Define only if SIGDANGER.
1833 (ignore_mouse_drag_p): Now static if
1834 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1835 (print_help): Remove; unused.
1836 (stop_character, last_timer_event): Mark as externally visible.
1837 * keyboard.h (ignore_mouse_drag_p): Declare only if
1838 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1839 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1840 * lisp.h (echoing): Remove decl.
1841 (force_auto_save_soon): Declare only if SIGDANGER.
1842 * xdisp.c (redisplay_window): Simplify code, to make it more
1843 obvious that ignore_mouse_drag_p is not accessed if !defined
1844 USE_GTK && !defined HAVE_NS.
1845
93ea6e8f
PE
1846 * intervals.c: Make symbols static if they're not exported.
1847 (merge_properties_sticky, merge_interval_right, delete_interval):
1848 Now static.
1849 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1850
77382fcc
PE
1851 * insdel.c: Make symbols static if they're not exported.
1852 However, leave prepare_to_modify_buffer alone. It's never
1853 called from outside this function, but that appears to be a bug.
1854 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1855 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1856 (adjust_after_replace_noundo): Remove; unused.
1857 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1858 (signal_before_change): Remove decls.
77382fcc 1859
9306c32e
PE
1860 * indent.c (val_compute_motion, val_vmotion): Now static.
1861
cd44d2eb
PE
1862 * image.c: Make symbols static if they're not exported.
1863 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1864 if USE_GTK.
1865 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1866 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1867
ad9a7a06
PE
1868 * fringe.c (standard_bitmaps): Now static.
1869 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1870
81626931
PE
1871 * frame.c: Make symbols static if they're not exported.
1872 (x_report_frame_params, make_terminal_frame): Now static.
1873 (get_frame_param): Now static, unless HAVE_NS.
1874 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1875 (x_get_resource_string): Remove; not used.
1876 * frame.h (make_terminal_frame, x_report_frame_params):
1877 (x_get_resource_string); Remove decls.
1878 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1879 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1880
239f9db9
PE
1881 * font.c, fontset.c: Make symbols static if they're not exported.
1882 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1883 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1884 * font.c (font_close_object): Now static.
1885 * font.h (font_close_object): Remove.
1886 * fontset.c (FONTSET_OBJLIST): Remove.
1887 (free_realized_fontset) #if-0 the body, which does nothing.
1888 (face_suitable_for_char_p): #if-0, as it's never called.
1889 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1890 * xfaces.c (face_at_string_position):
1891 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1892 since 0 is always ASCII.
1893
dfcf3579
PE
1894 * fns.c (weak_hash_tables): Now static.
1895
5045092b
PE
1896 * fileio.c: Make symbols static if they're not exported.
1897 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1898 (Vwrite_region_annotation_buffers): Now static.
1899
57a96f5c
PE
1900 * eval.c: Make symbols static if they're not exported.
1901 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1902 * lisp.h (backtrace_list): Remove decl.
1903
35f08c38
PE
1904 * emacs.c: Make symbols static if they're not exported.
1905 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1906 (fatal_error_code, fatal_error_signal_hook, standard_args):
1907 Now static.
1908 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1909 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1910 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1911 * lisp.h (fatal_error_signal_hook): Remove decl.
1912 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1913
f44bd759
PE
1914 * editfns.c: Move a (normally-unused) function to its only use.
1915 * editfns.c, lisp.h (get_operating_system_release): Remove.
1916 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1917 worth the hassle of breaking this out.
1918
b532497d
PE
1919 * xterm.c: Make symbols static if they're not exported.
1920 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1921 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1922 (x_destroy_window, x_delete_display):
1923 Now static.
1924 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1925 (x_mouse_leave): Remove; unused.
1926 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1927 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1928 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1929 Remove decls.
1930 (x_mouse_leave): Declare only if WINDOWSNT.
1931 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1932 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1933 USE_X_TOOLKIT.
1934
1675728f
PE
1935 * ftxfont.c: Make symbols static if they're not exported.
1936 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1937 HAVE_FREETYPE.
1938 * font.h (ftxfont_driver): Likewise.
1939
e4cebfca
PE
1940 * xfns.c: Make symbols static if they're not exported.
1941 (x_last_font_name, x_display_info_for_name):
1942 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1943 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1944 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1945 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1946 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1947 (last_show_tip_args): Now static.
1948 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1949 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1950 (x_screen_planes): Remove; unused.
1951 * dispextern.h (x_screen_planes): Remove decl.
1952
5bf46f05
PE
1953 * dispnew.c: Make symbols static if they're not exported.
1954 * dispextern.h (redraw_garbaged_frames, scrolling):
1955 (increment_row_positions): Remove.
1956 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1957 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1958 Now static.
1959 (redraw_garbaged_frames): Remove; unused.
1960
435f4c28
PE
1961 * xfaces.c: Make symbols static if they're not exported.
1962 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1963 Remove decls.
1964 * xterm.h (defined_color): Remove decls.
1965 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1966 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1967 (menu_face_changed_default, defined_color, free_realized_face):
1968 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1969 (ascii_face_of_lisp_face): Remove; unused.
1970
8524aef3
PE
1971 * xdisp.c: Make symbols static if they're not exported.
1972 * dispextern.h (scratch_glyph_row, window_box_edges):
1973 (glyph_to_pixel_coords, set_cursor_from_row):
1974 (get_next_display_element, set_iterator_to_next):
1975 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1976 (show_mouse_face): Remove decls
1977 * frame.h (message_buf_print): Likewise.
1978 * lisp.h (pop_message, set_message, check_point_in_composition):
1979 Likewise.
1980 * xterm.h (set_vertical_scroll_bar): Likewise.
1981 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1982 (message_buf_print, scratch_glyph_row, displayed_buffer):
1983 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1984 (get_next_display_element, show_mouse_face, window_box_edges):
1985 (frame_to_window_pixel_xy, check_point_in_composition):
1986 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1987 (glyph_to_pixel_coords): Remove; unused.
1988
16390cd2
PE
1989 * dired.c (file_name_completion): Now static.
1990
1991 * dbusbind.c (xd_in_read_queued_messages): Now static.
1992
a25f4dfa
PE
1993 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1994 * data.c (circular_list_error): Remove.
1995
14a9c8df
PE
1996 * commands.h (last_point_position, last_point_position_buffer):
1997 (last_point_position_window): Remove decls.
1998 * keyboard.c: Make these variables static.
1999
04f2d78b
CB
2000 * coding.h (coding, code_convert_region, encode_coding_gap):
2001 Remove decls.
74ab6df5
PE
2002 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2003 (iso_code_class, detect_coding, code_convert_region): Now static.
2004 (encode_coding_gap): Remove; unused.
2005
38dfbee1
PE
2006 * chartab.c (chartab_chars, chartab_bits): Now static.
2007
a2cb4e63
PE
2008 * charset.h (charset_iso_8859_1): Remove decl.
2009 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2010 Now static.
2011
127198fd
PE
2012 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2013 * ccl.c (Vccl_program_table): Now static.
2014 (check_ccl_update): Remove; unused.
2015
d85b608f
PE
2016 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2017 * category.h: ... from here.
2018 * category.c (check_category_table, set_category_set): Now static.
2019
31cd66f3
PE
2020 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2021 * lisp.h: Remove these decls.
2022
c358e587
PE
2023 * buffer.c (buffer_count): Remove unused var.
2024
e78aecca
PE
2025 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2026 so that it's not optimized away.
2027 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2028 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2029 exported only to the debugger.
2030
e192d7d3 2031 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2032 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2033
92470028
PE
2034 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2035 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2036 was inaccessible from Lisp.
2037 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2038 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2039
244ed907
PE
2040 alloc.c: Import and export fewer symbols, and remove unused items.
2041 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2042 is defined.
2043 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2044 it's not optimized away by whole-program optimization.
2045 (message_enable_multibyte, free_misc): Remove.
2046 (catchlist, handlerlist, mark_backtrace):
2047 Declare only if BYTE_MARK_STACK.
2048 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2049 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2050 (message_enable_multibyte): Remove decl.
2051 (free_misc, interval_free_list, float_block, float_block_index):
2052 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2053 (cons_free_list, last_marked_index):
2054 Now static.
2055 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2056 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2057 (mark_backtrace): Define only if BYTE_MARK_STACK.
2058 * xdisp.c (message_enable_multibyte): Now static.
2059
61c2b50e 2060 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2061 This makes it easier for human readers (and static analyzers)
2062 to see whether these variables are used from other modules.
2063 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2064 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2065 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2066 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2067 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2068 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2069 * xmenu.c, xselect.c:
2070 Declare Q* vars static if they are not used in other modules.
2071 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2072 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2073 Remove decls of unexported vars.
2074 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2075
95c82688
PE
2076 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2077
16a97296
PE
2078 Make Emacs functions such as Fatom 'static' by default.
2079 This makes it easier for human readers (and static analyzers)
2080 to see whether these functions can be called from other modules.
2081 DEFUN now defines a static function. To make the function external
2082 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2083 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2084 (Finit_image_library):
16a97296
PE
2085 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2086 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2087 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2088 Remove decls, since these functions are now static.
2089 (Funintern, Fget_internal_run_time): New decls, since these functions
2090 were already external.
95c82688 2091
16a97296
PE
2092 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2093 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2094 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2095 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2096 * keyboard.c, keymap.c, lread.c:
2097 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2098 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2099 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2100 Mark functions with DEFUE instead of DEFUN,
2101 if they are used in other modules.
2102 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2103 decls for now-static functions.
2104 * buffer.h (Fdelete_overlay): Remove decl.
2105 * callproc.c (Fgetenv_internal): Mark as internal.
2106 * composite.c (Fremove_list_of_text_properties): Remove decl.
2107 (Fcomposition_get_gstring): New forward static decl.
2108 * composite.h (Fcomposite_get_gstring): Remove decl.
2109 * dired.c (Ffile_attributes): New forward static decl.
2110 * doc.c (Fdocumntation_property): New forward static decl.
2111 * eval.c (Ffetch_bytecode): New forward static decl.
2112 (Funintern): Remove extern decl; now in .h file where it belongs.
2113 * fileio.c (Fmake_symbolic_link): New forward static decl.
2114 * image.c (Finit_image_library): New forward static decl.
2115 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2116 * intervals.h (Fprevious_property_change):
2117 (Fremove_list_of_text_properties): Remove decls.
2118 * keyboard.c (Fthis_command_keys): Remove decl.
2119 (Fcommand_execute): New forward static decl.
2120 * keymap.c (Flookup_key): New forward static decl.
2121 (Fcopy_keymap): Now static.
2122 * keymap.h (Flookup_key): Remove decl.
2123 * process.c (Fget_process): New forward static decl.
2124 (Fprocess_datagram_address): Mark as internal.
2125 * syntax.c (Fsyntax_table_p): New forward static decl.
2126 (skip_chars): Remove duplicate decl.
2127 * textprop.c (Fprevious_property_change): New forward static decl.
2128 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2129 Now internal.
2130 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2131 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2132
785bbd42
PE
2133 * editfns.c (Fformat): Remove unreachable code.
2134
8b913b57
AS
21352011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2136
2137 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2138 change. (Bug#8496)
2139
a6744a35
EZ
21402011-04-13 Eli Zaretskii <eliz@gnu.org>
2141
2142 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2143 when at ZV. (Bug#8487)
2144
e7974947
AS
21452011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2146
baad03f0
AS
2147 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2148 (Bug#8437)
2149 * keyboard.c (parse_tool_bar_item): Likewise.
2150 * sound.c (sound_cleanup, alsa_close): Likewise.
2151 * termcap.c (tgetent): Likewise.
2152 * xfns.c (x_default_font_parameter): Likewise.
2153 * xsettings.c (read_and_apply_settings): Likewise.
2154
e7974947
AS
2155 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2156 (overrun_check_free): Protoize.
2157
28272684
PE
21582011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2159
2160 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2161 since callers should never pass a negative size.
2162 Change the signature to match that of plain 'read' and 'write'; see
2163 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2164 * lisp.h: Update prototypes of emacs_write and emacs_read.
2165
11997c76
EZ
21662011-04-11 Eli Zaretskii <eliz@gnu.org>
2167
2168 * xdisp.c (redisplay_window): Don't try to determine the character
2169 position of the scroll margin if the window start point w->startp
e896f03c 2170 is outside the buffer's accessible region. (Bug#8468)
11997c76 2171
8a2cbd72
EZ
21722011-04-10 Eli Zaretskii <eliz@gnu.org>
2173
2174 Fix write-region and its subroutines for buffers > 2GB.
2175 * fileio.c (a_write, e_write): Modify declaration of arguments and
2176 local variables to support buffers larger than 2GB.
2177 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2178
2179 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2180 argument, local variables, and return value.
2181
2182 * lisp.h: Update prototypes of emacs_write and emacs_read.
2183
2184 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2185
4073e537 21862011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2187
1ebfdcb6
PE
2188 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2189
b2ded58d
PE
2190 Fix more problems found by GCC 4.6.0's static checks.
2191
7d66342c
PE
2192 * xdisp.c (vmessage): Use a better test for character truncation.
2193
bbf47d44
PE
2194 * charset.c (load_charset_map): <, not <=, for optimization,
2195 and to avoid potential problems with integer overflow.
9248994d 2196 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2197 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2198 * editfns.c (Fformat): Likewise.
1e69125e 2199 * syntax.c (skip_chars): Likewise.
3befa583 2200
e3019616
PE
2201 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2202 This also lets GCC 4.6.0 generate slightly better loop code.
2203
becfa255
PE
2204 * callint.c (Fcall_interactively): <, not <=, for optimization.
2205 (Fcall_interactively): Count the number of arguments produced,
2206 not the number of arguments given. This is simpler and lets GCC
2207 4.6.0 generate slightly better code.
2208
dae0cd48
PE
2209 * ftfont.c: Distingish more carefully between FcChar8 and char.
2210 The previous code passed unsigned char * to a functions like
2211 strlen and xstrcasecmp that expect char *, which does not
2212 conform to the C standard.
2213 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2214 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2215 char * when the C standard requires it.
2216
76032d70
PE
2217 * keyboard.c (read_char): Remove unused var.
2218
eb3f1cc8
PE
2219 * eval.c: Port to Windows vsnprintf (Bug#8435).
2220 Include <limits.h>.
2221 (SIZE_MAX): Define if the headers do not.
2222 (verror): Do not give up if vsnprintf returns a negative count.
2223 Instead, grow the buffer. This ports to Windows vsnprintf, which
2224 does not conform to C99. Problem reported by Eli Zaretskii.
2225 Also, simplify the allocation scheme, by avoiding the need for
2226 calling realloc, and removing the ALLOCATED variable.
2227
70476b54
PE
2228 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2229
12020a9e
PE
2230 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2231 But keep the doprint source code for now, as we might revamp it
2232 and use it again (Bug#8435).
ea6c7ae6
PE
2233 * lisp.h (doprnt): Remove.
2234 * Makefile.in (base_obj): Remove doprnt.o.
2235 * deps.mk (doprnt.o): Remove.
2236
5fdb398c
PE
2237 error: Print 32- and 64-bit integers portably (Bug#8435).
2238 Without this change, on typical 64-bit hosts error ("...%d...", N)
2239 was used to print both 32- and 64-bit integers N, which relied on
2240 undefined behavior.
2241 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2242 New macro.
2243 * lisp.h (error, verror): Mark as printf-like functions.
2244 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2245 Report overflow in size calculations when allocating printf buffer.
2246 Do not truncate output string at its first null byte.
2247 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2248 Truncate the output at a character boundary, since vsnprintf does not
2249 do that.
2250 * charset.c (check_iso_charset_parameter): Convert internal
2251 character to string before calling 'error', since %c now has the
2252 printf meaning.
2253 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2254 overflow when computing char to be passed to 'error'. Do not
2255 pass Lisp_Object to 'error'; pass the integer instead.
2256 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2257 formatted with plain %d.
2258
b189fa66
PE
2259 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2260
bff87ef0
PE
2261 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2262
7e2cac20
PE
2263 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2264
ce4d90b5
PE
2265 * xterm.c (x_catch_errors): Remove duplicate declaration.
2266
266c9547
PE
2267 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2268
79c49ad2
PE
2269 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2270
368f4090
JM
22712011-04-10 Jim Meyering <meyering@redhat.com>
2272
2273 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2274 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2275 return ssize_t not "int", and use size_t as the buffer length.
2276 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2277 * gnutls.h: Update declarations.
2278 * process.c (read_process_output): Use ssize_t, to match.
2279 (send_process): Likewise.
2280
a32d4040
CY
22812011-04-09 Chong Yidong <cyd@stupidchicken.com>
2282
2283 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2284
8546720e 22852011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2286
04f2d78b
CB
2287 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2288 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2289
8546720e
GM
2290 * xterm.c (handle_one_xevent):
2291 * xmenu.c (create_and_show_popup_menu):
2292 * xselect.c (x_decline_selection_request)
2293 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2294
0a2f5c1a 22952011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2296
2297 Fix some uses of `int' instead of EMACS_INT.
2298 * search.c (string_match_1, fast_string_match)
2299 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2300 (scan_buffer, find_next_newline_no_quit)
2301 (find_before_next_newline, search_command, Freplace_match)
2302 (Fmatch_data): Make some `int' variables be EMACS_INT.
2303
2304 * xdisp.c (display_count_lines): 3rd argument and return value now
2305 EMACS_INT. All callers changed.
2306 (pint2hrstr): Last argument is now EMACS_INT.
2307
2308 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2309 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2310 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2311 (decode_coding_utf_16, decode_coding_emacs_mule)
2312 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2313 (decode_coding_ccl, decode_coding_charset)
2314 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2315 (decode_coding_iso_2022, decode_coding_emacs_mule)
2316 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2317 <char_offset, last_offset>: Declare EMACS_INT.
2318 (encode_coding_utf_8, encode_coding_utf_16)
2319 (encode_coding_emacs_mule, encode_invocation_designation)
2320 (encode_designation_at_bol, encode_coding_iso_2022)
2321 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2322 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2323 Declare EMACS_INT.
2324 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2325 (encode_invocation_designation): Last argument P_NCHARS is now
2326 EMACS_INT.
2327 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2328 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2329
2330 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2331 All users changed.
2332
2333 * ccl.c (Fccl_execute_on_string): Declare some variables
2334 EMACS_INT.
2335
8546720e 23362011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2337
2338 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2339
4e19a977
CS
23402011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2341
2342 * process.c (Fformat_network_address): Doc fix.
2343
87302331
R
23442011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2345
2346 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2347
cbb59342
CY
23482011-04-08 Chong Yidong <cyd@stupidchicken.com>
2349
2350 * keyboard.c (read_char): Call Lisp function help-form-show,
2351 instead of using internal_with_output_to_temp_buffer.
2352 (Qhelp_form_show): New var.
e0d38eeb 2353 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2354
2355 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2356
2357 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2358
e67a13ab
CY
23592011-04-06 Chong Yidong <cyd@stupidchicken.com>
2360
04f2d78b
CB
2361 * process.c (Flist_processes): Remove to Lisp.
2362 (list_processes_1): Delete.
e67a13ab 2363
973f782d
EZ
23642011-04-06 Eli Zaretskii <eliz@gnu.org>
2365
7c106b1e
EZ
2366 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2367
973f782d
EZ
2368 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2369
41cf7d1a 23702011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2371
ca23cc88
PE
2372 Fix more problems found by GCC 4.6.0's static checks.
2373
f390e2d5
PE
2374 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2375
42eea0d0
PE
2376 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2377
b69769da 2378 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2379
f9541e84
PE
2380 * xdisp.c (vmessage): Mark as a printf-like function.
2381
13841b55
PE
2382 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2383
c136c10f
PE
2384 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2385
5e2d4a30
PE
2386 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2387 printf-like functions.
2388 (tiff_load): Add casts to remove these marks before passing them
2389 to system-supplied API.
2390
583f48b9
PE
2391 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2392
b25d760e
PE
2393 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2394 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2395 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2396 directly, rather than having caller test rule sign. This avoids
2397 some unnecessary tests.
2398 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2399 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2400 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2401
bc7b6697 2402 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2403 (xfont_open): Avoid unnecessary tests.
bc7b6697 2404
27ccc379
PE
2405 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2406
dcd5c89a
PE
2407 * composite.h, composite.c (composition_gstring_put_cache):
2408 Use EMACS_INT, not int, for length.
2409
b13a45c6
PE
2410 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2411 breaking out part of COMPOSITION_DECODE_RULE.
2412 (COMPOSITION_DECODE_RULE): Use it.
2413 * composite.c (get_composition_id): Remove unused local vars,
2414 by using the new macro.
2415
1e792e4d
PE
2416 * textprop.c (set_text_properties_1): Change while to do-while,
2417 since the condition is always true at first.
2418
dc6c6455 2419 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2420 (interval_deletion_adjustment): Return unsigned value.
2421 All uses changed.
dc6c6455 2422
aba7731a
PE
2423 * process.c (list_processes_1, create_pty, read_process_output):
2424 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2425 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2426 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2427 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2428 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2429
fdfc4bf3
PE
2430 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2431
fca8fe46 2432 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2433 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2434
06a0259a 2435 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2436 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2437 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2438
e7b9e80f
PE
2439 * print.c (print_error_message): Avoid int overflow.
2440
56201685
PE
2441 * font.c (font_list_entities): Redo for clarity,
2442 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2443
78834453 2444 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2445 (font_score): Avoid potential overflow in diff calculation.
78834453 2446
0bc0b309 2447 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2448 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2449
e610eaca
PE
2450 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2451
b895abce
PE
2452 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2453 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2454 can always succeed if overflow has undefined behavior.
2455
1f1d9321 2456 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2457 (wordify): Omit three unnecessary tests.
1f1d9321 2458
c59478bc
PE
2459 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2460 All callers changed. This avoids the need for an unused var.
2461
79b73827
PE
2462 * casefiddle.c (casify_region): Remove var that is set but not used.
2463
a4db5dfe
PE
2464 * dired.c (file_name_completion): Remove var that is set but not used.
2465
43aae36e
PE
2466 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2467
2a47c44d 2468 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2469 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2470
a37c69bf
PE
2471 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2472 Check for integer overflow on size calculations.
2473
328ab8e7
PE
2474 * buffer.c (Fprevious_overlay_change): Remove var that is set
2475 but not used.
2476
e5a2a5cb
PE
2477 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2478 Remove vars that are set but not used.
8d84a6eb 2479 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2480 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2481
a60e5f68
PE
2482 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2483
f661cb61 2484 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2485 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2486
f0397f5a
PE
2487 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2488 that are set but not used.
2489
8664db06 2490 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2491 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2492
6abdaa4a
PE
2493 * xselect.c (x_get_local_selection, x_handle_property_notify):
2494 Remove vars that are set but not used.
2495
0ce7538d 2496 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2497 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2498
9ae848fc
PE
2499 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2500 Remove var that is set but not used.
0b918413
PE
2501 (scroll_bar_windows_size): Now size_t, not int.
2502 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2503 Check for overflow.
9ae848fc 2504
a5a62657
PE
2505 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2506 (map_tty_color) [!defined MSDOS]: Likewise.
2507
5c5cdd39
PE
2508 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2509
66ebf983
PE
2510 * coding.c: Remove vars that are set but not used.
2511 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2512 All callers changed.
2513 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2514 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2515 (decode_coding_charset): Remove vars that are set but not used.
2516
1be4d761
PE
2517 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2518 that is set but not used.
2519
47553fa8
PE
2520 * print.c (print_object): Remove var that is set but not used.
2521
1f7196bf 2522 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2523 The gnulib version avoids calling malloc in the usual case,
2524 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2525 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2526 * filelock.c (current_lock_owner): Likewise.
2527 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2528 * sysdep.c: Include allocator.h, careadlinkat.h.
2529 (emacs_no_realloc_allocator): New static constant.
2530 (emacs_readlink): New function.
fdb61804
PE
2531 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2532 ../lib/careadlinkat.h.
d1fdcab7 2533
f84c17c7
SM
25342011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2535
2536 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2537 first non-nil return value).
2538
ef3862ad
JD
25392011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2540
2541 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2542 if not defined (Bug#8403).
2543
376a7006
JB
25442011-04-02 Juanma Barranquero <lekktu@gmail.com>
2545
2546 * xdisp.c (display_count_lines): Remove parameter `start',
2547 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2548 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2549 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2550 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2551 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2552 and thereabouts. All callers changed.
2553 (get_per_char_metric): Remove parameter `f', unused since
2554 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2555
6ca3801d
JM
25562011-04-02 Jim Meyering <meyering@redhat.com>
2557
2558 do not dereference NULL upon failed strdup
2559 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2560 (ns_get_family): Likewise.
2561
d8e2b5ba
JB
25622011-04-02 Juanma Barranquero <lekktu@gmail.com>
2563
2564 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2565
8c74fcbd
JD
25662011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2567
2568 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2569 later (Bug#8403).
2570
7200d79c
SM
25712011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2572
03408648 2573 Add lexical binding.
7200d79c 2574
03408648
SM
2575 * window.c (Ftemp_output_buffer_show): New fun.
2576 (Fsave_window_excursion):
2577 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2578
2579 * lread.c (lisp_file_lexically_bound_p): New function.
2580 (Fload): Bind Qlexical_binding.
2581 (readevalloop): Remove `evalfun' arg.
2582 Bind Qinternal_interpreter_environment.
2583 (Feval_buffer): Bind Qlexical_binding.
2584 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2585 Mark as dynamic.
2586 (syms_of_lread): Declare `lexical-binding'.
2587
2588 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2589
2590 * keyboard.c (eval_dyn): New fun.
2591 (menu_item_eval_property): Use it.
ca105506
SM
2592
2593 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2594
03408648
SM
2595 * fns.c (concat, mapcar1): Accept byte-code-functions.
2596
2597 * eval.c (Fsetq): Handle lexical vars.
2598 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2599 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2600 (FletX, Flet): Obey lexical binding.
2601 (Fcommandp): Handle closures.
2602 (Feval): New `lexical' arg.
2603 (eval_sub): New function extracted from Feval. Use it almost
2604 everywhere where Feval was used. Look up vars in lexical env.
2605 Handle closures.
2606 (Ffunctionp): Move from subr.el.
2607 (Ffuncall): Handle closures.
2608 (apply_lambda): Remove `eval_flags'.
2609 (funcall_lambda): Handle closures and new byte-code-functions.
2610 (Fspecial_variable_p): New function.
2611 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2612 but without exporting it to Lisp.
23aba0ea 2613
23aba0ea 2614 * doc.c (Fdocumentation, store_function_docstring):
03408648 2615 * data.c (Finteractive_form): Handle closures.
23aba0ea 2616
03408648
SM
2617 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2618 interactive spec.
ba83908c 2619
04f2d78b
CB
2620 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2621 New byte-codes.
03408648
SM
2622 (exec_byte_code): New function extracted from Fbyte_code to handle new
2623 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2624
03408648 2625 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2626
03408648 2627 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2628
e2abce01
JB
26292011-03-31 Juanma Barranquero <lekktu@gmail.com>
2630
2631 * xdisp.c (redisplay_internal): Fix prototype.
2632
63696a73 26332011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2634
63696a73 2635 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2636 (try_scrolling): Use it when setting scroll_limit.
2637 Limit scrolling to 100 screen lines.
63696a73
EZ
2638 (redisplay_window): Even when falling back on "recentering",
2639 position point in the window according to scroll-conservatively,
2640 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2641
2642 (try_scrolling): When point is above the window, allow searching
2643 as far as scroll_max, or one screenful, to compute vertical
2644 distance from PT to the scroll margin position. This prevents
2645 try_scrolling from unnecessarily failing when
2646 scroll-conservatively is set to a value slightly larger than the
2647 window height. Clean up the case of PT below the margin at bottom
2648 of window: scroll_max can no longer be INT_MAX. When aggressive
2649 scrolling is in use, don't let point enter the opposite scroll
2650 margin as result of the scroll.
2651 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2652 threshold of 100 lines for never-recentering scrolling.
2653
e4cc2dfc
JB
26542011-03-31 Juanma Barranquero <lekktu@gmail.com>
2655
2656 * dispextern.h (move_it_by_lines):
2657 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2658 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2659 (message_log_check_duplicate): Remove parameters `prev_bol' and
2660 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2661 (redisplay_internal): Remove parameter `preserve_echo_area',
2662 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2663
2664 * indent.c (Fvertical_motion):
2665 * window.c (window_scroll_pixel_based, Frecenter):
2666 Don't pass `need_y_p' to `move_it_by_lines'.
2667
1c470562
SM
26682011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2669
44f230aa
SM
2670 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2671 steal a few bits to be more compact.
2672 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2673 Remove unneeded casts.
2674
1c470562
SM
2675 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2676
888adce9
ZK
26772011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2678
2679 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2680 binding" message (bug#7967).
2681
f838ed7b
PE
26822011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2683
77861b95
PE
2684 Fix more problems found by GCC 4.6.0's static checks.
2685
de6dbc14
PE
2686 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2687 Remove unused local var.
2688
f838ed7b
PE
2689 * editfns.c (Fmessage_box): Remove unused local var.
2690
792c7b2b
PE
2691 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2692 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2693 Omit unused local vars.
c499e557 2694 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2695 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2696 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2697 Omit unused local var.
2698
ba0165e1
PE
2699 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2700 Don't assume string length fits in int.
32ad8845 2701 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2702 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2703
3c59b4c9
PE
2704 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2705 instead of alloca (Bug#8344).
2706
a3eed478 2707 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2708 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2709
eb4d412d
PE
2710 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2711
1658b401
PE
2712 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2713 concerns.
2714
2715 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2716
2717 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2718
9a2c6e05
PE
2719 * keyboard.c (syms_of_keyboard): Use the same style as later
2720 in this function when indexing through an array. This also
2721 works around GCC bug 48267.
2722
03d0a109
PE
2723 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2724
44f730c8
PE
2725 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2726
fe75f926
PE
2727 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2728 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2729
ffa8c828
PE
2730 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2731 This avoids undefined behavior on integer overflow, and is a bit
2732 more convenient anyway since it is compared to a size_t variable.
2733
c5101a77
PE
2734 Variadic C functions now count arguments with size_t, not int.
2735 This avoids an unnecessary limitation on 64-bit machines, which
2736 caused (substring ...) to crash on large vectors (Bug#8344).
2737 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2738 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2739 All variadic functions and their callers changed accordingly.
c5101a77
PE
2740 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2741 * data.c (arith_driver, float_arith_driver): Likewise.
2742 * editfns.c (general_insert_function): Likewise.
2743 * eval.c (struct backtrace.nargs, interactive_p)
2744 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2745 (funcall_lambda, mark_backtrace): Likewise.
2746 * fns.c (concat): Likewise.
2747 * frame.c (x_set_frame_parameters): Likewise.
2748 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2749 0 if not found, not -1. All callers changed.
2750
dd3f25f7
PE
2751 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2752 (stack_copy_size): Now size_t, not int.
2753 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2754
461c2ab9
JB
27552011-03-28 Juanma Barranquero <lekktu@gmail.com>
2756
2757 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2758 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2759 All callers changed.
2760
2761 * lisp.h (multibyte_char_to_unibyte):
2762 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2763 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2764 * character.h (CHAR_TO_BYTE8):
2765 * cmds.c (internal_self_insert):
2766 * editfns.c (general_insert_function):
2767 * keymap.c (push_key_description):
2768 * search.c (Freplace_match):
2769 * xdisp.c (message_dolog, set_message_1): All callers changed.
2770
f6d62986
SM
27712011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2772
2773 * keyboard.c (safe_run_hook_funcall): New function.
2774 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2775 don't set the hook to nil, but remove the offending function instead.
2776 (Qcommand_hook_internal): Remove, unused.
2777 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2778 Vcommand_hook_internal.
2779
2780 * eval.c (enum run_hooks_condition): Remove.
2781 (funcall_nil, funcall_not): New functions.
2782 (run_hook_with_args): Call each function through a `funcall' argument.
2783 Remove `cond' argument, now redundant.
2784 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2785 (Frun_hook_with_args_until_failure): Adjust accordingly.
2786 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2787
1db5b1ad
JB
27882011-03-28 Juanma Barranquero <lekktu@gmail.com>
2789
2790 * dispextern.h (string_buffer_position): Remove declaration.
2791
2792 * print.c (strout): Remove parameter `multibyte', unused since
2793 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2794
2795 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2796 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2797 All callers changed.
2798
2799 * w32.c (_wsa_errlist): Use braces for struct initializers.
2800
2801 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2802 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2803 All callers changed.
2804 (string_buffer_position): Likewise. Also, make static (it's never
2805 used outside xdisp.c).
2806 (cursor_row_p): Remove parameter `w', unused since
2807 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2808 (decode_mode_spec): Remove parameter `precision', introduced during
2809 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2810 All callers changed.
2811
5ffb62aa
JD
28122011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2813
2814 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2815
461c2ab9 28162011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2817
2818 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2819 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2820 (ns_update_auto_hide_menu_bar): New functions.
2821 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2822 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2823 ns_constrain_all_frames.
2824 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2825 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2826
5c380ffb
JD
28272011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2828
2829 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2830
9af30bdf
GM
28312011-03-27 Glenn Morris <rgm@gnu.org>
2832
2833 * syssignal.h: Replace RETSIGTYPE with void.
2834 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2835 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2836 Replace SIGTYPE with void everywhere.
2837 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2838 * s/template.h (SIGTYPE): Remove commented out definition.
2839
e2abce01
JB
28402011-03-26 Eli Zaretskii <eliz@gnu.org>
2841
2842 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2843 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2844
f868cd8a
JB
28452011-03-26 Juanma Barranquero <lekktu@gmail.com>
2846
59eb0929
JB
2847 * w32.c (read_unc_volume): Use parameter `henum', instead of
2848 global variable `wget_enum_handle'.
2849
2850 * keymap.c (describe_vector): Remove parameters `indices' and
2851 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2852 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2853
f868cd8a
JB
2854 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2855
2856 * keyboard.c (timer_check): Remove parameter `do_it_now',
2857 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2858 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2859 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2860
2861 * keyboard.c (read_char):
2862 * w32menu.c (w32_menu_display_help):
2863 * xmenu.c (show_help_event, menu_help_callback):
2864 Adjust calls to `show_help_echo'.
2865
2866 * gtkutil.c (xg_maybe_add_timer):
2867 * keyboard.c (readable_events):
2868 * process.c (wait_reading_process_output):
2869 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2870
2871 * insdel.c (adjust_markers_gap_motion):
2872 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2873 (gap_left, gap_right): Don't call it.
2874
2ecf6fdb
CY
28752011-03-25 Chong Yidong <cyd@stupidchicken.com>
2876
2877 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2878 incurred during fontification.
2879
6b1f9ba4
JB
28802011-03-25 Juanma Barranquero <lekktu@gmail.com>
2881
2882 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2883 (DEFVAR_PER_BUFFER): Don't pass it.
2884
2885 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2886 (scrolling_window): Don't pass it.
2887
0f4a96b5
JB
28882011-03-25 Juanma Barranquero <lekktu@gmail.com>
2889
2890 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2891
2892 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2893 and `suffix'.
2894 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2895 of variables specific to SELinux and computation of `encoded_absname'.
2896
2897 * image.c (XPutPixel): Remove unused variable `height'.
2898
2899 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2900
2901 * unexw32.c (get_section_info): Remove unused variable `section'.
2902
2903 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2904 (system_process_attributes): Remove unused variable `sess'.
2905 (sys_read): Remove unused variable `err'.
2906
2907 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2908 (w32_wnd_proc): Remove unused variable `isdead'.
2909 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2910 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2911 (x_create_tip_frame): Remove unused variable `tem'.
2912
2913 * w32inevt.c (w32_console_read_socket):
2914 Remove unused variable `no_events'.
2915
2916 * w32term.c (x_draw_composite_glyph_string_foreground):
2917 Remove unused variable `width'.
2918
1149507c
JB
29192011-03-24 Juanma Barranquero <lekktu@gmail.com>
2920
2921 * w32term.c (x_set_glyph_string_clipping):
2922 Don't pass uninitialized region to CombineRgn.
2923
9c88f339
JB
29242011-03-23 Juanma Barranquero <lekktu@gmail.com>
2925
2926 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2927 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2928 (Fx_close_connection): Remove unused variable `i'.
2929
2930 * w32font.c (w32font_draw): Return number of glyphs.
2931 (w32font_open_internal): Remove unused variable `i'.
2932 (w32font_driver): Add missing initializer.
2933
2934 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2935 (fill_in_menu): Remove unused variable `items_added'.
2936
2937 * w32term.c (last_mouse_press_frame): Remove static global variable.
2938 (w32_clip_to_row): Remove unused variable `f'.
2939 (x_delete_terminal): Remove unused variable `i'.
2940
2941 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2942 (NOTHING): Remove unused static global variable.
2943 (uniscribe_check_otf): Remove unused variable `table'.
2944 (uniscribe_font_driver): Add missing initializers.
2945
dee091a3
JD
29462011-03-23 Julien Danjou <julien@danjou.info>
2947
2948 * term.c (Fsuspend_tty, Fresume_tty):
2949 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2950 * window.c (temp_output_buffer_show):
2951 * insdel.c (signal_before_change):
2952 * frame.c (Fhandle_switch_frame):
2953 * fileio.c (Fdo_auto_save):
2954 * emacs.c (Fkill_emacs):
2955 * editfns.c (save_excursion_restore):
2956 * cmds.c (internal_self_insert):
2957 * callint.c (Fcall_interactively):
2958 * buffer.c (Fkill_all_local_variables):
2959 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2960 Use Frun_hooks.
0f4a96b5 2961 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2962 unconditionnaly since it does the check itself.
2963
2c520ab5 29642011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2965
c9c49752
PE
2966 Fix more problems found by GCC 4.5.2's static checks.
2967
8abc3f12
PE
2968 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2969 the first time through the loop, since we know p0 < p1 then.
2970 This also avoids a gcc -Wstrict-overflow warning.
2971
a2d26660
PE
2972 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2973 leading to a memory leak, possible in functions like
2974 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2975 of objects (Bug#8318).
a2d26660 2976
916c72e9
PE
2977 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2978 that could (at least in theory) be that large.
2979
19ab8a18
PE
2980 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2981 This is less likely to overflow, and avoids undefined behavior if
2982 overflow does occur. All callers changed. Use strtoul to scan
2983 for the unsigned long integer.
b7cbbd6f
PE
2984 (pint2hrstr): Simplify and tune code slightly.
2985 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2986
f0641eff
PE
2987 * scroll.c (do_scrolling): Work around GCC bug 48228.
2988 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2989
7f650bb9
PE
2990 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2991 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2992 (validate_x_resource_name): Simplify count usage.
2993 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2994
37dd57d1
PE
2995 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2996 fail (Bug#8306).
81e56e61 2997
699979fc 2998 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2999
401bf9b4
PE
3000 * process.c (Fmake_network_process): Use socklen_t, not int,
3001 where POSIX says socklen_t is required in portable programs.
3002 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3003 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3004 (Fmake_network_process, server_accept_connection):
3005 (wait_reading_process_output, read_process_output):
3006 Likewise.
3007
b93aacde
PE
3008 * process.c: Rename or move locals to avoid shadowing.
3009 (list_processes_1, Fmake_network_process):
3010 (read_process_output_error_handler, exec_sentinel_error_handler):
3011 Rename or move locals.
4dc343ee 3012 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3013 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3014 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3015 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3016 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3017
af8a867c 3018 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3019 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3020 Include tparam.h instead, since it declares them.
af8a867c
PE
3021 * cm.h (PC): Remove extern decl; tparam.h now does this.
3022 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3023 * terminfo.c: Include tparam.h, to check interfaces.
3024 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3025 (tparam): Adjust signature to match interface in tparam.h;
3026 this removes some undefined behavior. Check that outstring and len
3027 are zero, which they always are with Emacs.
3028 * tparam.h (PC, BC, UP): New extern decls.
3029
0248044d 3030 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3031 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3032
8ff096c1 3033 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3034 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3035 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3036 (ftfont_list): Remove unused local.
49eaafba
PE
3037 (get_adstyle_property, ftfont_pattern_entity):
3038 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3039 Rename locals to avoid shadowing.
8ff096c1 3040
e2be39f6
PE
3041 * xfont.c (xfont_list_family): Mark var as initialized.
3042
c9735e30
PE
3043 * xml.c (make_dom): Now static.
3044
8f5201ae
PE
3045 * composite.c (composition_compute_stop_pos): Rename local to
3046 avoid shadowing.
b246f932
PE
3047 (composition_reseat_it): Remove unused locals.
3048 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3049 (composition_update_it): Mark var as initialized.
11b61122
PE
3050 (find_automatic_composition): Mark vars as initialized,
3051 with a FIXME (Bug#8290).
8f5201ae 3052
760fbc2c
PE
3053 character.h: Rename locals to avoid shadowing.
3054 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3055 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3056 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3057 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3058 to avoid shadowing.
3059
ff08eb85
PE
3060 * textprop.c (property_change_between_p): Remove; unused.
3061
fc7bf025
PE
3062 * intervals.c (interval_start_pos): Now static.
3063
235d7abc
PE
3064 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3065
44f230aa
SM
3066 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3067 Rename locals to avoid shadowing.
3e7d6594 3068
50060332
PE
3069 * sound.c (wav_play, au_play, Fplay_sound_internal):
3070 Fix pointer signedness.
d01f234b 3071 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3072 (wav_play): Initialize a variable to 0, to prevent undefined
3073 behavior (Bug#8278).
50060332 3074
c4fc4e30
PE
3075 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3076
918436ed
PE
3077 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3078
c939f91b
PE
3079 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3080 clobbering (Bug#8298).
b9c7f648
PE
3081 * sysdep.c (sys_subshell): Likewise.
3082 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3083
6bd8c144
PE
3084 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3085 This should get cleaned up, so that child_setup has the
3086 same signature on all platforms.
3087
7710357c 3088 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3089 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3090
c59da222
CY
30912011-03-22 Chong Yidong <cyd@stupidchicken.com>
3092
3093 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3094 not to be necessary, and produces flickering.
3095
66b87493
GM
30962011-03-20 Glenn Morris <rgm@gnu.org>
3097
3098 * config.in: Remove file.
3099
45b6f6d5
JB
31002011-03-20 Juanma Barranquero <lekktu@gmail.com>
3101
3102 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3103 are now in src/globals.h.
3104 (syms_of_minibuf): Remove spurious & from previous change.
3105
3ec03f7e
LL
31062011-03-20 Leo <sdl.web@gmail.com>
3107
3108 * minibuf.c (completing-read-function): New variable.
3109 (completing-read-default): Rename from completing-read.
3110 (completing-read): Call completing-read-function.
3111
b14e3e21
CY
31122011-03-19 Juanma Barranquero <lekktu@gmail.com>
3113
3114 * xfaces.c (Fx_load_color_file):
3115 Read color file from absolute filename (bug#8250).
3116
f2b726e6
JB
31172011-03-19 Juanma Barranquero <lekktu@gmail.com>
3118
3119 * makefile.w32-in: Update dependencies.
3120
09f6ff02
EZ
31212011-03-17 Eli Zaretskii <eliz@gnu.org>
3122
3123 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3124
29a6015a
PE
31252011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3126
a3a6c54e
PE
3127 Fix more problems found by GCC 4.5.2's static checks.
3128
b766f867
PE
3129 * process.c (make_serial_process_unwind, send_process_trap):
3130 (sigchld_handler): Now static.
3131
be02381c
PE
3132 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3133 That way, the code declares only the vars that it needs.
3134 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3135 * s/cygwin.h (PTY_ITERATION): Likewise.
3136 * s/darwin.h (PTY_ITERATION): Likewise.
3137 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3138
57048744
PE
3139 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3140 * process.c (allocate_pty): Don't declare stb unless it's needed.
3141
7914961c 3142 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3143 (CONSTANTLIM): Remove; unused.
3144 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3145 Define only if needed.
7914961c 3146
b3967b18
PE
3147 * unexelf.c (unexec): Name an expression,
3148 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3149 Use a different way to cause a compilation error if anyone uses
3150 n rather than nn, a way that does not involve shadowing.
73366a00 3151 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3152
29a6015a
PE
3153 * deps.mk (unexalpha.o): Remove; unused.
3154
43cfc33e 3155 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3156 * unexec.h: New file.
ce701a33
PE
3157 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3158 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3159 Depend on unexec.h.
3160 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3161 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3162 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3163 Change as necessary to match prototype in unexec.h.
ce701a33 3164
01f44d5a
PE
3165 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3166 shadowing.
4f63c6bb 3167 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3168
a6670b0b
PE
3169 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3170 Rename locals to avoid shadowing.
3171
cef2010d 3172 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3173 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3174
d4d7173a
PE
3175 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3176
f08b802a
PE
3177 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3178 warning when compiling print.c.
3179
3ddb0639
PE
3180 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3181 instead of using an uninitialized var.
5ad03b97 3182 (font_sort_entities): Mark var as initialized.
3ddb0639 3183
170a2692
PE
3184 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3185
e663c700
PE
3186 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3187 pointers to constants.
89bc529a 3188 (font_parse_fcname): Remove unused vars.
7b81e2d0 3189 (font_delete_unmatched): Now static.
ea838e10 3190 (font_get_spec): Remove; unused.
13a547c6
PE
3191 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3192 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3193 Rename or move locals to avoid shadowing.
e663c700 3194
2a80c887 3195 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3196 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3197
1384fa33 3198 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3199 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3200
8b2c52e9
PE
3201 * alloc.c (mark_backtrace): Move decl from here ...
3202 * lisp.h: ... to here, so that it can be checked.
3203
475545b5 3204 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3205 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3206 (lisp_indirect_variable): Name an expression,
3207 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3208 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3209
b1349114 3210 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3211 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3212 Use const pointer when appropriate.
b1349114 3213
a2928364
PE
3214 * lisp.h (get_system_name, get_operating_system_release):
3215 Move decls here, to check interfaces.
3216 * process.c (get_operating_system_release): Move decl to lisp.h.
3217 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3218 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3219 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3220 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3221 (Fformat_time_string, Fencode_time, Finsert_char):
3222 (Ftranslate_region_internal, Fformat):
3223 Rename or remove local vars to avoid shadowing.
9710023e 3224 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3225
a415e694
PE
3226 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3227 avoid shadowing.
3228
8ef4622d
PE
3229 * lisp.h (eassert): Check that the argument compiles, even if
3230 ENABLE_CHECKING is not defined.
3231
946f9a5b
PE
3232 * data.c (Findirect_variable): Name an expression, to avoid
3233 gcc -Wbad-function-cast warning.
112396d6 3234 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3235 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3236 (Fmake_variable_buffer_local, Fmake_local_variable):
3237 Mark variables as initialized.
52746918 3238 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3239
e5aab7e7 3240 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3241 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3242 Rename locals to avoid shadowing.
dff45157
PE
3243 (mark_stack): Move local variables into the #ifdef region where
3244 they're used.
7bc26fdb
PE
3245 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3246 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3247 needed otherwise.
3248 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3249 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3250 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3251
e5aab7e7
PE
3252 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3253 avoids undefined behavior in theory.
3254
4da60324
PE
3255 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3256
88043301
PE
3257 Use functions, not macros, for up- and down-casing (Bug#8254).
3258 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3259 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3260 to use the following functions instead of these macros.
3261 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3262 EMACS_INT, since callers assume the returned value fits in int.
3263 (upcase1): Likewise, for UPCASE_TABLE.
3264 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3265 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3266 the race-condition problem in the old DOWNCASE.
88043301 3267
19ed5445
PE
3268 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3269 Rename locals to avoid shadowing.
3270 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3271 (regex_compile, re_search_2, re_match_2_internal):
3272 Remove unused local vars.
952db0d7
PE
3273 (FREE_VAR): Rewrite so as not to use empty "else",
3274 which gcc can warn about.
da053e48 3275 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3276 (RETALLOC_IF): Define only if needed.
3277 (WORDCHAR_P): Likewise. This one is never needed, but is used
3278 only in a comment talking about a compiler bug, so put inside
3279 the #if 0 of that comment.
3280 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3281 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3282 Remove; unused.
19ed5445 3283
1f3561e4 3284 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3285 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3286 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3287
ded6f8f7
PE
3288 * search.c (simple_search): Remove unused var.
3289
dbd37a95
PE
3290 * dired.c (compile_pattern): Move decl from here ...
3291 * lisp.h: ... to here, so that it can be checked.
3292 (struct re_registers): New forward decl.
3293
7e47afad
PE
3294 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3295
85f24f61
PE
3296 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3297 All uses changed.
3298 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3299 Rename locals to avoid shadowing.
5671df8f 3300 (Fvertical_motion): Mark locals as initialized.
85f24f61 3301
181aa2be 3302 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3303 (casify_region): Mark local as initialized.
181aa2be 3304
930d429c
PE
3305 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3306
7082eac6
PE
3307 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3308 New macros, so that the caller can use some names other than
3309 gcpro1, gcpro2, etc.
3310 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3311 of the new macros.
3312 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3313 argument, for consistency with GCPRO2_VAR, etc: it is now the
3314 prefix of the variable, not the variable itself. All uses
3315 changed.
38b2c076
PE
3316 * dired.c (directory_files_internal, file_name_completion):
3317 Rename locals to avoid shadowing.
3318
15206ed9
PE
3319 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3320 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3321 dired.c's scmp function, had undefined behavior.
3322 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3323 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3324 * buffer.h: ... to here, because these macros use current_buffer,
3325 and the new implementation with inline functions needs to have
3326 current_buffer in scope now, rather than later when the macros
3327 are used.
3328 (downcase, upcase1): New static inline functions.
3329 (DOWNCASE, UPCASE1): Reimplement using these functions.
3330 This avoids undefined behavior in expressions like
3331 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3332 from race conditions in accessing the global variables
3333 case_temp1 and case_temp2.
3334 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3335 * lisp.h (case_temp1, case_temp2): Remove their decls.
3336 * character.h (ASCII_CHAR_P): Move from here ...
3337 * lisp.h: ... to here, so that the inline functions mentioned
3338 above can use them.
3339
4a6bea26
PE
3340 * dired.c (directory_files_internal_unwind): Now static.
3341
f14b7e14
PE
3342 * fileio.c (file_name_as_directory, directory_file_name):
3343 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3344 Now static.
2893f146
PE
3345 (file_name_as_directory): Use const pointers when appropriate.
3346 (Fexpand_file_name): Likewise. In particular, newdir might
3347 point at constant storage, so make it a const pointer.
fd4ead52 3348 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3349 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3350 signedness issues.
f839df0c
PE
3351 (Fset_file_times, Finsert_file_contents, auto_save_error):
3352 Rename locals to avoid shadowing.
f14b7e14 3353
5716756e 3354 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3355 (Ftry_completion, Fall_completions): Rename or remove locals
3356 to avoid shadowing.
5716756e 3357
b4c3046a
PE
3358 * marker.c (bytepos_to_charpos): Remove; unused.
3359
b45db522
PE
3360 * lisp.h (verify_bytepos, count_markers): New decls,
3361 so that gcc does not warn that these functions aren't declared.
3362
85876d07
PE
3363 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3364 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3365 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3366 (copy_text): Remove unused local var.
85876d07 3367
03d78a21 3368 * filelock.c (within_one_second): Now static.
b3dd38ab 3369 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3370
5df8f01b
PE
3371 * buffer.c (fix_overlays_before): Mark locals as initialized.
3372 (fix_start_end_in_overlays): Likewise. This function should be
3373 simplified by using pointers-to-pointers, but that's a different
3374 matter.
b1d876f1 3375 (switch_to_buffer_1): Now static.
8f54f30a
PE
3376 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3377 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3378
a70072c9 3379 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3380 Fix pointer signedness issue.
edced198
PE
3381 (sys_subshell): Mark local as volatile if checking for lint,
3382 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3383 (MAXPATHLEN): Define only if needed.
a70072c9 3384
a0977c44
PE
3385 * process.c (serial_open, serial_configure): Move decls from here ...
3386 * systty.h: ... to here, so that they can be checked.
3387
a884fdcc
PE
3388 * fns.c (get_random, seed_random): Move extern decls from here ...
3389 * lisp.h: ... to here, so that they can be checked.
3390
604efe86 3391 * sysdep.c (reset_io): Now static.
b8950c94 3392 (wait_for_termination_signal): Remove; unused.
604efe86 3393
38fc62d9
PE
3394 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3395 (copy_keymap_item, append_key, push_text_char_description):
3396 Now static.
1004a21a 3397 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3398 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3399 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3400 (describe_map_tree):
3401 Rename locals to avoid shadowing.
38fc62d9 3402
2f2650da
PE
3403 * keyboard.c: Declare functions static if they are not used elsewhere.
3404 (echo_char, echo_dash, cmd_error, top_level_2):
3405 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3406 (read_char, kbd_buffer_get_event, make_lispy_position):
3407 (make_lispy_event, make_lispy_movement, apply_modifiers):
3408 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3409 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3410 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3411 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3412 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3413
a053e86c 3414 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3415 (mark_kboards): Move decl here ...
3416 * alloc.c (mark_kboards): ... from here.
a053e86c 3417
4752793e
PE
3418 * lisp.h (force_auto_save_soon): New decl.
3419
74f10ca7 3420 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3421 (DEFINE_DUMMY_FUNCTION): New macro.
3422 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3423 Use it.
c03cd23f
PE
3424 (main): Add casts to avoid warnings
3425 if GCC considers string literals to be constants.
74f10ca7 3426
022e70d4
PE
3427 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3428
59d6fe83
PE
3429 * dbusbind.c: Pointer signedness fixes.
3430 (xd_signature, xd_append_arg, xd_initialize):
3431 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3432 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3433 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3434 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3435
78320123
PE
3436 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3437 if GCC considers string literals to be constants.
49cebcca 3438 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3439
35ac2a97
SM
34402011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3441
fb103ca9
SM
3442 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3443 (print_preprocess, print_object): New macro to fix last change.
3444
35ac2a97
SM
3445 * print.c (print_preprocess): Don't forget font objects.
3446
62973b41
JB
34472011-03-16 Juanma Barranquero <lekktu@gmail.com>
3448
3449 * emacs.c (USAGE3): Doc fixes.
3450
0e48bb22
AS
34512011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3452
3453 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3454 structure.
3455
7684e57b
JB
34562011-03-14 Juanma Barranquero <lekktu@gmail.com>
3457
3458 * lisp.h (VWindow_system, Qfile_name_history):
3459 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3460 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3461 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3462
3463 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3464 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3465
3466 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3467 * w32console.c (detect_input_pending, read_input_pending)
3468 (encode_terminal_code):
3469 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3470 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3471 (w32_system_caret_y, Qfile_name_history):
3472 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3473 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3474 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3475 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3476 * w32proc.c (Qlocal, report_file_error):
3477 * w32term.c (Vwindow_system, updating_frame):
3478 * w32uniscribe.c (initialized, uniscribe_font_driver):
3479 Remove unneeded extern declarations.
3480
2aa46d6c
CY
34812011-03-14 Chong Yidong <cyd@stupidchicken.com>
3482
c96bbc66 3483 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3484
cffc6f3b
CY
34852011-03-13 Chong Yidong <cyd@stupidchicken.com>
3486
3487 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3488 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3489 These macros can no longer be used for assignment.
3490
44f230aa
SM
3491 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3492 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3493 (record_buffer_markers, fetch_buffer_markers): New functions for
3494 recording and fetching special buffer markers.
3495 (set_buffer_internal_1, set_buffer_temp): Use them.
3496
3497 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3498
3499 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3500
3501 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3502 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3503
3504 * xdisp.c (hscroll_window_tree):
3505 (reconsider_clip_changes): Use PT instead of BUF_PT.
3506
d251f04b
EZ
35072011-03-13 Eli Zaretskii <eliz@gnu.org>
3508
3509 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3510 $(EMACS_ROOT)/lib/intprops.h.
3511
f0c77cd1
PE
35122011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3513
3eca4629
PE
3514 Fix more problems found by GCC 4.5.2's static checks.
3515
7c86ee98
PE
3516 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3517 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3518 (xg_free_frame_widgets): Make it clear that a local variable is
3519 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3520 (gdk_window_get_screen): Make it clear that this macro is needed
3521 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3522 (int_gtk_range_get_value): New function, which avoids a diagnostic
3523 from gcc -Wbad-function-cast.
3524 (xg_set_toolkit_scroll_bar_thumb): Use it.
3525 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3526 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3527 (get_utf8_string, xg_get_file_with_chooser):
3528 Rename locals to avoid shadowing.
3529 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3530
41729b81
PE
3531 * xgselect.c (xg_select): Remove unused var.
3532
f0c77cd1
PE
3533 * image.c (four_corners_best): Mark locals as initialized.
3534 (gif_load): Initialize transparent_p to zero (Bug#8238).
3535 Mark another local as initialized.
ec6cf4c6 3536 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3537
ce0ad53d 3538 * image.c (clear_image_cache): Now static.
d5d5a617 3539 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3540 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3541 (x_edge_detection): Remove unnecessary cast that
3542 gcc -Wbad-function-cast diagnoses.
2037898d 3543 (gif_load): Fix pointer signedness.
6ae141d6
PE
3544 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3545 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3546
33383987 35472011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3548
d32df629
PE
3549 Improve quality of tests for time stamp overflow.
3550 For example, without this patch (encode-time 0 0 0 1 1
3551 1152921504606846976) returns the obviously-bogus value (-948597
3552 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3553 reports time overflow. See
3554 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3555 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3556 * editfns.c: Include limits.h and intprops.h.
3557 (TIME_T_MIN, TIME_T_MAX): New macros.
3558 (time_overflow): Move earlier, to before first use.
3559 (hi_time, lo_time): New functions, for an accurate test for
3560 out-of-range times.
3561 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3562 (Fget_internal_run_time): Don't assume time_t fits in int.
3563 (make_time): Use list2 instead of Fcons twice.
3564 (Fdecode_time): More accurate test for out-of-range times.
3565 (check_tm_member): New function.
3566 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3567 (lisp_time_argument): Don't rely on undefined left-shift and
3568 right-shift behavior when checking for time stamp overflow.
8be6f318 3569
fe31d94c
PE
3570 * editfns.c (time_overflow): New function, refactoring common code.
3571 (Fformat_time_string, Fdecode_time, Fencode_time):
3572 (Fcurrent_time_string): Use it.
3573
8be6f318
PE
3574 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3575 * dired.c (make_time): Move to ...
3576 * editfns.c (make_time): ... here.
3577 * systime.h: Note the move.
3578
09d9db2c 35792011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3580
126bc0dc
YM
3581 * fringe.c (update_window_fringes): Remove unused variables.
3582
c47cbdfd
YM
3583 * unexmacosx.c (copy_data_segment): Also copy __got section.
3584 (Bug#8223)
3585
7ac80be9
EZ
35862011-03-12 Eli Zaretskii <eliz@gnu.org>
3587
c96bbc66 3588 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3589 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3590 Constify `char *' arguments and their references according to
3591 prototypes in tparam.h.
3592
ecb0f94d 3593 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3594
7ac80be9
EZ
3595 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3596 Adapt all references accordingly.
3597
3598 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3599
ef1fd07e
TT
36002011-03-11 Tom Tromey <tromey@redhat.com>
3601
3602 * buffer.c (syms_of_buffer): Remove obsolete comment.
3603
7ef4b50c
EZ
36042011-03-11 Eli Zaretskii <eliz@gnu.org>
3605
3606 * termhooks.h (encode_terminal_code): Declare prototype.
3607
3608 * msdos.c (encode_terminal_code): Don't declare prototype.
3609
3610 * term.c (encode_terminal_code): Now external again, used by
3611 w32console.c and msdos.c.
3612
44f230aa
SM
3613 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3614 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3615
4b1ec863 36162011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3617
1714f52b 3618 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3619
4b1ec863
PE
3620 * fringe.c (update_window_fringes): Mark locals as initialized
3621 (Bug#8227).
3622 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3623
524c7aa6
PE
3624 * alloc.c (mark_fringe_data): Move decl from here ...
3625 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3626 to check its interface.
3627 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3628
a5c0af81 3629 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3630 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3631 (fontset_font): Mark local as initialized.
a9a06e0b 3632 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3633
b4716021
PE
3634 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3635
811e9bac 3636 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3637 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3638 (x_own_selection, Fx_disown_selection_internal): Rename locals
3639 to avoid shadowing.
3640 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3641
7e3ab302
PE
3642 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3643 so that the caller can use some name other than gcpro1.
3644 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3645 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3646 (Fx_backspace_delete_keys_p):
3647 Use them to avoid shadowing, and rename vars to avoid shadowing.
3648 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3649 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3650 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3651 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3652 Remove unused locals.
7e3ab302
PE
3653 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3654 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3655 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3656 macros.
f78faa98 3657
e2b13473
PE
3658 * xterm.h (x_mouse_leave): New decl.
3659
77f23912
PE
3660 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3661 Remove unused functions.
cdf4ba58
PE
3662 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3663 (x_calc_absolute_position): Now static.
7411c686 3664 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3665 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3666 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3667 unless they are used.
38d0b34a
PE
3668 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3669 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3670 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3671 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3672 (x_error_catcher, x_connection_closed, x_error_handler):
3673 (x_error_quitter, xembed_send_message, x_iconify_frame):
3674 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3675 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3676 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3677
44f230aa
SM
3678 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3679 Rename or move locals to avoid shadowing.
6b463e58 3680 (tty_defined_color, merge_face_heights): Now static.
5967d051 3681 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3682 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3683 does not deduce is never used uninitialized.
73719eba
PE
3684 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3685 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3686
426994c3 3687 * terminal.c (store_terminal_param): Now static.
5489860b 3688
032f1620 3689 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3690 (set_frame_menubar): Remove unused local.
d4323972 3691 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3692 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3693 since they might point to immutable storage.
281585b0
PE
3694 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3695 since it's unused otherwise.
032f1620 3696
367c19e5 3697 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3698 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3699 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3700 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3701 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3702 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3703 does not deduce are never used uninitialized.
70739cbe 3704
07b48fa9
PE
3705 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3706
8868a238 3707 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3708 * window.c (window_loop, size_window):
3709 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3710
7e5cf297 3711 * window.c (display_buffer): Now static.
d6550a9f
PE
3712 (size_window): Mark variables that gcc -Wuninitialized
3713 does not deduce are never used uninitialized.
a586633d
PE
3714 * window.h (check_all_windows): New decl, to forestall
3715 gcc -Wmissing-prototypes diagnostic.
5b555da1 3716 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3717
f6095868
PE
3718 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3719 shadowing.
3720 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3721 Include <limits.h>.
3722 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3723 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3724 (load_charset_map): Mark variables that gcc -Wuninitialized
3725 does not deduce are never used uninitialized.
53df7c11 3726 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3727
f38b440c
PE
3728 * coding.c (coding_set_source, coding_set_destination):
3729 Use "else { /* comment */ }" rather than "else /* comment */;"
3730 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3731 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3732 a block, when the outer 'i' will do.
3733 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3734 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3735 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3736 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3737 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3738 Rename locals to avoid shadowing.
3739 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3740 * coding.c (emacs_mule_char, encode_invocation_designation):
3741 Now static, since they're not used elsewhere.
413bb2db 3742 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3743 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3744 (decode_coding_emacs_mule): Mark variables that gcc
3745 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3746 (detect_coding_iso_2022): Initialize a local variable that might
3747 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3748 this initialization is needed. (Bug#8211)
5f58e762
PE
3749 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3750 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3751 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3752 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3753 Remove unused macros.
f38b440c 3754
232b38b9 3755 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3756 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3757 * character.c (string_count_byte8): Likewise.
232b38b9 3758
fb90da1b
PE
3759 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3760 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3761
fb93dbc2
PE
3762 * chartab.c (copy_sub_char_table): Now static, since it's not used
3763 elsewhere.
5c156ace
PE
3764 (sub_char_table_ref_and_range, char_table_ref_and_range):
3765 Rename locals to avoid shadowing.
bbcd0949 3766 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3767
7d3b3862 3768 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3769 (BIDI_BOB): Remove unused macro.
7d3b3862 3770
6be7d3da
PE
3771 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3772 deduce are never used uninitialized.
c2ed9c8b 3773 * term.c (encode_terminal_code): Likewise.
6be7d3da 3774
75f8807f 3775 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3776
50938595
PE
3777 * tparam.h: New file.
3778 * term.c, tparam.h: Include it.
3779 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3780 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3781 Move these decls to tparam.h, and make them agree with what
3782 is actually in tparam.c. The previous trick of using incompatible
3783 decls in different modules does not conform to the C standard.
3784 All callers of tparam changed to use tparam's actual API.
3785 * tparam.c (tparam1, tparam, tgoto):
3786 Use const pointers where appropriate.
3787
fbceeba2
PE
3788 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3789 * cm.h (struct cm): Likewise.
3790 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3791 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3792 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3793 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3794 (turn_on_face, init_tty): Likewise.
3795 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3796
7f3f1250
PE
3797 * term.c (term_mouse_position): Rename local to avoid shadowing.
3798
e6ca6543
PE
3799 * alloc.c (mark_ttys): Move decl from here ...
3800 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3801
c40f8d15
AS
38022011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3803
3804 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3805
cfe0661d
JB
38062011-03-09 Juanma Barranquero <lekktu@gmail.com>
3807
3808 * search.c (compile_pattern_1): Remove argument regp, unused since
3809 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3810 (compile_pattern): Don't pass it.
3811
0afb4571
J
38122011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3813
3814 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3815 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3816 for ! HAVE_GTK3.
3817 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3818
3819 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3820
3821 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3822 gdk_window_get_screen, gdk_window_get_geometry,
3823 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3824 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3825 (xg_get_pixbuf_from_pixmap): New function.
3826 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3827 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3828 Call xg_get_pixbuf_from_pixmap instead of
3829 gdk_pixbuf_get_from_drawable.
3830 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3831 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3832 (xg_check_special_colors): Use GtkStyleContext and its functions
3833 for HAVE_GTK3.
3834 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3835 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3836 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3837 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3838 Call gtk_widget_get_preferred_size.
0afb4571
J
3839 (xg_frame_resized): gdk_window_get_geometry only takes 5
3840 parameters.
44f230aa
SM
3841 (xg_win_to_widget, xg_event_is_for_menubar):
3842 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3843 (xg_set_widget_bg): New function.
3844 (delete_cb): New function.
895009e1 3845 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3846 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3847 (xg_set_background_color): Call xg_set_widget_bg.
3848 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3849 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3850 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3851 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3852 if ! HAVE_GTK3.
3853 (update_frame_tool_bar): Call gtk_widget_hide.
3854 (xg_initialize): Use GDK_KEY_g.
3855
3856 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3857 if ! HAVE_GTK3
3858 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3859
3860 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3861 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3862 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3863
1c2cc4ef
JB
38642011-03-08 Juanma Barranquero <lekktu@gmail.com>
3865
3866 * w32xfns.c (select_palette): Check success of RealizePalette against
3867 GDI_ERROR, not zero.
3868
33383987 3869See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3870
3871;; Local Variables:
3872;; coding: utf-8
aac0c6e3
MR
3873;; End:
3874
33383987 3875 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3876
3877 This file is part of GNU Emacs.
3878
3879 GNU Emacs is free software: you can redistribute it and/or modify
3880 it under the terms of the GNU General Public License as published by
3881 the Free Software Foundation, either version 3 of the License, or
3882 (at your option) any later version.
3883
3884 GNU Emacs is distributed in the hope that it will be useful,
3885 but WITHOUT ANY WARRANTY; without even the implied warranty of
3886 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3887 GNU General Public License for more details.
3888
3889 You should have received a copy of the GNU General Public License
3890 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.