Add window-tree based, atomic and side window functions to window.el.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f230ecc9
MR
12011-06-06 Martin Rudalics <rudalics@gmx.at>
2
727e958e
MR
3 * lisp.h: Move EXFUNS for Fframe_root_window,
4 Fframe_first_window and Fset_frame_selected_window to window.h.
5
6 * window.h: Move EXFUNS for Fframe_root_window,
7 Fframe_first_window and Fset_frame_selected_window here from
8 lisp.h.
9
10 * frame.c (Fwindow_frame, Fframe_first_window)
11 (Fframe_root_window, Fframe_selected_window)
12 (Fset_frame_selected_window): Move to window.c.
13 (Factive_minibuffer_window): Move to minibuf.c.
14 (Fother_visible_frames_p): New function.
15
16 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
17
f230ecc9
MR
18 * window.c (decode_window, decode_any_window): Move up in code.
19 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
20 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
21 (Fwindow_buffer): Move up and rewrite doc-string.
22 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
23 (Fwindow_prev): New functions.
727e958e
MR
24 (Fwindow_frame): Move here from frame.c. Accept any window as
25 argument.
26 (Fframe_root_window, Fframe_first_window)
27 (Fframe_selected_window): Move here from frame.c. Accept frame
28 or arbitrary window as argument. Update doc-strings.
29 (Fminibuffer_window): Move up in code.
30 (Fwindow_minibuffer_p): Move up in code and simplify.
31 (Fset_frame_selected_window): Move here from frame.c. Marginal
32 rewrite.
33 (Fselected_window, select_window, Fselect_window): Move up in
34 code. Minor doc-string fixes.
f230ecc9 35
4d09bcf6
PE
362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
37
38 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
39 Do not assume that spare memory exists; that assumption is valid
40 only if SYSTEM_MALLOC.
41 (LARGE_REQUEST): New macro, so that the issue of large requests
42 is separated from the issue of spare memory.
43
810928a2
AS
442011-06-05 Andreas Schwab <schwab@linux-m68k.org>
45
172418ad
AS
46 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
47 format. (Bug#8806)
48
43f862f7
AS
49 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
50
810928a2
AS
51 * xfns.c (x_set_scroll_bar_default_width): Move declarations
52 before statements.
53
a059fe24
JD
542011-06-05 Jan Djärv <jan.h.d@swipnet.se>
55
56 * gtkutil.c (xg_get_default_scrollbar_width): New function.
57
58 * gtkutil.h: Declare xg_get_default_scrollbar_width.
59
60 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
61 min width by calling x_set_scroll_bar_default_width (Bug#8505).
62
989bf368
JB
632011-06-05 Juanma Barranquero <lekktu@gmail.com>
64
65 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
66
4b80f674
CY
672011-06-04 Chong Yidong <cyd@stupidchicken.com>
68
69 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
70 (x_clipboard_manager_save): Add return value.
71 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
72 error handlers.
73 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
74 Obey Vx_select_enable_clipboard_manager. Catch errors in
75 x_clipboard_manager_save (Bug#8779).
76 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 77 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 78
99a33b77 792011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
80
81 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
82
99a33b77 832011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
84
85 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
86 in the current matrix if keep_current_p is non-zero.
87
8264569d
EZ
882011-06-04 Eli Zaretskii <eliz@gnu.org>
89
90 * bidi.c (bidi_level_of_next_char): Fix last change.
91
57f97249
EZ
922011-06-03 Eli Zaretskii <eliz@gnu.org>
93
fec2107c 94 Support bidi reordering of text covered by display properties.
57f97249 95
fec2107c
EZ
96 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
97 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
98 (bidi_cache_search, bidi_cache_iterator_state)
99 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
100 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
101 character positions inside a run of characters covered by a
102 display string.
103 (bidi_paragraph_init, bidi_resolve_explicit_1)
104 (bidi_level_of_next_char): Call bidi_fetch_char and
105 bidi_fetch_char_advance instead of FETCH_CHAR and
106 FETCH_CHAR_ADVANCE.
107 (bidi_init_it): Initialize new members.
108 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
109 definitions.
110 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
111 instead of using explicit *_CHAR codes.
112 (bidi_resolve_explicit, bidi_resolve_weak): Use
113 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
114 bidirectional text is supported only in multibyte buffers.
115 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
116 it to initialize the frame_window_p member of struct bidi_it.
117 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
118 (bidi_resolve_explicit, bidi_resolve_weak)
119 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
120 bidi_it->nchars is non-positive.
121 (bidi_level_of_next_char): Don't try to lookup the cache for the
122 next/previous character if nothing is cached there yet, or if we
123 were just reseat()'ed to a new position.
c40e2fb2 124
0e14fe90
EZ
125 * xdisp.c (set_cursor_from_row): Set start and stop points
126 according to the row's direction when priming the loop that looks
127 for the glyph on which to display cursor.
128 (single_display_spec_intangible_p): Function deleted.
129 (display_prop_intangible_p): Reimplement to call
130 handle_display_spec instead of single_display_spec_intangible_p.
131 Accept 3 additional arguments needed by handle_display_spec. This
132 fixes incorrect cursor motion across display property with complex
133 values: lists, `(when COND...)' forms, etc.
134 (single_display_spec_string_p): Support property values that are
135 lists with the argument STRING its top-level element.
136 (display_prop_string_p): Fix the condition for processing a
137 property that is a list to be consistent with handle_display_spec.
fec2107c 138 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
139 last portion of handle_display_prop.
140 (compute_display_string_pos): Accept additional argument
141 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
142 value of a `display' property is a "replacing spec".
143 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
144 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
145 the display property, but just return a value indicating whether
146 the display property will replace the characters it covers.
147 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
148 frame_window_p members of struct bidi_it.
fec2107c
EZ
149 (compute_display_string_pos, compute_display_string_end): New
150 functions.
151 (push_it): Accept second argument POSITION, where pop_it should
152 jump to continue iteration.
153 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 154
fec2107c
EZ
155 * keyboard.c (adjust_point_for_property): Adjust the call to
156 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
157
158 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
159 (bidi_init_it): Update prototypes.
160 (display_prop_intangible_p): Update prototype.
161 (compute_display_string_pos, compute_display_string_end): Declare
162 prototypes.
163 (struct bidi_it): New members nchars and disp_pos. ch_len is now
164 EMACS_INT.
fc6f18ce 165
40087514 1662011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 167
57f53182
PE
168 Malloc failure behavior now depends on size of allocation.
169 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
170 * lisp.h: Change signatures accordingly.
171 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
172 All callers changed. (Bug#8762)
173
174 * gnutls.c: Use Emacs's memory allocators.
175 Without this change, the gnutls library would invoke malloc etc.
176 directly, which causes problems on non-SYNC_INPUT hosts, and which
177 runs afoul of improving memory_full behavior. (Bug#8761)
178 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
179 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
180 xfree instead of the default malloc, realloc, free.
181 (Fgnutls_boot): No need to check for memory allocation failure,
182 since xmalloc does that for us.
183
ac32cd99 184 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
185 * category.c (hash_get_category_set):
186 * ccl.c (ccl_driver):
187 * charset.c (Fdefine_charset_internal):
188 * charset.h (struct charset.hash_index):
189 * composite.c (get_composition_id, gstring_lookup_cache)
190 (composition_gstring_put_cache):
191 * composite.h (struct composition.hash_index):
192 * dispextern.h (struct image.hash):
193 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
194 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
195 (hashfn_equal, hashfn_user_defined, make_hash_table)
196 (maybe_resize_hash_table, hash_lookup, hash_put)
197 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
198 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
199 (Fsxhash, Fgethash, Fputhash, Fmaphash):
200 * image.c (make_image, search_image_cache, lookup_image)
201 (xpm_put_color_table_h):
202 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 203 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
204 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
205 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
206 * alloc.c (allocate_vectorlike):
207 Check for overflow in vector size calculations.
208 * ccl.c (ccl_driver):
209 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
210 * fns.c, image.c: Remove unnecessary static decls that would otherwise
211 need to be updated by these changes.
40087514
PE
212 * fns.c (make_hash_table, maybe_resize_hash_table):
213 Check for integer overflow with large hash tables.
0de4bb68
PE
214 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
215 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
216 (SXHASH_REDUCE): New macro.
217 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
218 Use it instead of discarding useful hash info with large hash values.
219 (sxhash_float): New function.
220 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
221 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
222 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
223 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
224 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
225 Adjust signatures to match updated version of code.
226 (consing_since_gc): Now EMACS_INT, since a single hash table can
227 use more than INT_MAX bytes.
228
698d32e2
DN
2292011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
230
231 Make it possible to build with GCC-4.6+ -O2 -flto.
232
233 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
234
fd6fa53f
SM
2352011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
236
237 * minibuf.c (get_minibuffer, read_minibuf_unwind):
238 Call minibuffer-inactive-mode.
239
864db017
JB
2402011-05-31 Juanma Barranquero <lekktu@gmail.com>
241
242 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
243 Update dependencies.
244
2ad0baf4
DN
2452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
246
247 * data.c (init_data): Remove code for UTS, this system is not
248 supported anymore.
249
4fcc2638
DN
2502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
251
252 Don't force ./temacs to start in terminal mode.
253
254 * frame.c (make_initial_frame): Initialize faces in all cases, not
255 only when CANNOT_DUMP is defined.
256 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
257
c56e0fd5
DN
2582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
259
260 * dispnew.c (add_window_display_history): Use const for the string
261 pointer. Remove declaration, not needed.
262
333d54da 2632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 264
55d4c1b2 265 Use 'inline', not 'INLINE'.
333d54da 266 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
267 * alloc.c, fontset.c (INLINE): Remove.
268 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
269 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
270 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
271 * gmalloc.c (register_heapinfo): Use inline unconditionally.
272 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
273
738db178
DN
2742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
275
276 Make it possible to run ./temacs.
277
278 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
279 syms_of_callproc does the same thing. Remove test for
280 "initialized", do it in the caller.
281 * emacs.c (main): Avoid calling set_initial_environment when dumping.
282
620c53a6
SM
2832011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
284
285 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
286 (read_minibuf): Use get_minibuffer.
287 (syms_of_minibuf): Use DEFSYM.
288 (Qmetadata): New var.
289 * data.c (Qbuffer): Don't make it static.
290 (syms_of_data): Use DEFSYM.
291
e003a292
PE
2922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
293
294 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
295 (CCL_CODE_MIN): New macro.
296
ed008a6d
PE
2972011-05-30 Paul Eggert <eggert@cs.ucla.edu>
298
3687c2ef
PE
299 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
300
ed008a6d
PE
301 * eval.c (Qdebug): Now static.
302 * lisp.h (Qdebug): Remove decl. This reverts a part of the
303 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
304 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
305
d66c4c7c
CY
3062011-05-29 Chong Yidong <cyd@stupidchicken.com>
307
308 * image.c: Various fixes to ImageMagick code comments.
309 (Fimagemagick_types): Doc fix.
310
5fbc2025
PE
3112011-05-29 Paul Eggert <eggert@cs.ucla.edu>
312
0196f88a
PE
313 Minor fixes prompted by GCC 4.6.0 warnings.
314
315 * xselect.c (converted_selections, conversion_fail_tag): Now static.
316
5fbc2025
PE
317 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
318 (x_clipboard_manager_save_all): Move extern decl to ...
319 * xterm.h: ... here, so that it can be checked for consistency.
320
1dd3c2d9
CY
3212011-05-29 Chong Yidong <cyd@stupidchicken.com>
322
323 * xselect.c (x_clipboard_manager_save_frame)
324 (x_clipboard_manager_save_all): New functions.
325 (Fx_clipboard_manager_save): Lisp function deleted.
326
327 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
328 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
329
330 * xterm.h: Update prototype.
331
5ba6571d
WX
3322011-05-28 William Xu <william.xwl@gmail.com>
333
334 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
335 exiting (Bug#8239).
336
3eaff834
JM
3372011-05-28 Jim Meyering <meyering@redhat.com>
338
e1900994 339 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
340 * fns.c (to_uchar): Define.
341 (crypto_hash_function): Use it to convert some newly-signed
342 variables to unsigned, to avoid sign-extension bugs. For example,
343 without this change, (md5 "truc") would evaluate to
344 45723a2aff78ff4fff7fff1114760e62 rather than the expected
345 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 346 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 347
0f6990a7
PE
3482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
349
350 Integer overflow fixes.
c8a9ca5a 351
08686060
PE
352 * dbusbind.c: Serial number integer overflow fixes.
353 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
354 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
355 to hold a serial number that is too large for a fixnum.
356 (Fdbus_method_return_internal, Fdbus_method_error_internal):
357 Check for serial numbers out of range. Decode any serial number
59568bf0 358 that was so large that it became a float. (Bug#8722)
08686060 359
2d1fc3c7
PE
360 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
361 (Fdbus_call_method, Fdbus_call_method_asynchronously):
362 Use XFASTINT rather than XUINT when numbers are nonnegative.
363 (xd_append_arg, Fdbus_method_return_internal):
364 (Fdbus_method_error_internal): Likewise. Also, for unsigned
365 arguments, check that Lisp number is nonnegative, rather than
59568bf0 366 silently wrapping negative numbers around. (Bug#8722)
30217ff0 367 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 368 (Bug#8722)
2d1fc3c7 369
c8a9ca5a
PE
370 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
371
519e1d69
PE
372 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
373
30569699
PE
374 ccl: add integer overflow checks
375 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
376 (IN_INT_RANGE): New macros.
377 (ccl_driver): Use them to check for integer overflow when
378 decoding a CCL program. Many of the new checks are whether XINT (x)
379 fits in int; it doesn't always, on 64-bit hosts. The new version
380 doesn't catch all possible integer overflows, but it's an
847044ea 381 improvement. (Bug#8719)
30569699 382
c11285dc
PE
383 * alloc.c (make_event_array): Use XINT, not XUINT.
384 There's no need for unsigned here.
385
fdccd48e
PE
386 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
387 This follows up to the 2011-05-06 change that substituted uintptr_t
388 for EMACS_INT. This case wasn't caught back then.
389
37910ab2
PE
390 Rework Fformat to avoid integer overflow issues.
391 * editfns.c: Include <float.h> unconditionally, as it's everywhere
392 now (part of C89). Include <verify.h>.
393 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
394 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
395 (Fformat): Avoid the prepass trying to compute sizes; it was only
396 approximate and thus did not catch overflow reliably. Instead, walk
397 through the format just once, formatting and computing sizes as we go,
398 checking for integer overflow at every step, and allocating a larger
399 buffer as needed. Keep track separately whether the format is
400 multibyte. Keep only the most-recently calculated precision, rather
401 than them all. Record whether each argument has been converted to
402 string. Use EMACS_INT, not int, for byte and char and arg counts.
403 Support field widths and precisions larger than INT_MAX. Avoid
404 sprintf's undefined behavior with conversion specifications such as %#d
405 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
406 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
407 formatting out-of-range floating point numbers with int
408 formats. (Bug#8668)
409
2e6578fb
PE
410 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
411
0ae6bdee
PE
412 * data.c: Avoid integer truncation in expressions involving floats.
413 * data.c: Include <intprops.h>.
414 (arith_driver): When there's an integer overflow in an expression
415 involving floating point, convert the integers to floating point
416 so that the resulting value does not suffer from catastrophic
417 integer truncation. For example, on a 64-bit host (* 4
418 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
419 Do not rely on undefined behavior after integer overflow.
420
de883a70
PE
421 merge count_size_as_multibyte, parse_str_to_multibyte
422 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 423 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
424 Check for integer overflow.
425 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
426 since it's now a duplicate of the other. This is more of
427 a character than a buffer op, so better that it's in character.c.
428 * fns.c, print.c: Adjust to above changes.
429
2ff916cb
PE
4302011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
431
432 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
433
f1b54466
PE
4342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
435
fb1ac845
PE
436 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
437 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
438 (x_clipboard_manager_save): Now static.
439 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
440
f1b54466
PE
441 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
442 (crypto_hash_function): Now static.
443 Fix pointer signedness problems. Avoid unnecessary initializations.
444
a9f737ee
CY
4452011-05-27 Chong Yidong <cyd@stupidchicken.com>
446
447 * termhooks.h (Vselection_alist): Make it terminal-local.
448
449 * terminal.c (create_terminal): Initialize it.
450
451 * xselect.c: Support for clipboard managers.
452 (Vselection_alist): Move to termhooks.h as terminal-local var.
453 (LOCAL_SELECTION): New macro.
454 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
455 (symbol_to_x_atom): Remove gratuitous arg.
456 (x_handle_selection_request, lisp_data_to_selection_data)
457 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
458 (x_own_selection, x_get_local_selection, x_convert_selection):
459 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
460 (some_frame_on_display): Delete unused function.
461 (Fx_own_selection_internal, Fx_get_selection_internal)
462 (Fx_disown_selection_internal, Fx_selection_owner_p)
463 (Fx_selection_exists_p): New optional frame arg.
464 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
465 (x_handle_selection_clear): Don't treat other terminals with the
466 same keyboard specially. Use the terminal-local Vselection_alist.
467 (x_clear_frame_selections): Use Frun_hook_with_args.
468
469 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
470
471 * xterm.h: Add support for those atoms.
472
e067f0c1
CY
4732011-05-26 Chong Yidong <cyd@stupidchicken.com>
474
475 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
476 (converted_selections, conversion_fail_tag): New global variables.
477 (x_selection_request_lisp_error): Free the above.
478 (x_get_local_selection): Remove unnecessary code.
479 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
480 of converted selections stored in converted_selections.
481 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
482 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
483 (x_convert_selection): New function.
484 (x_handle_selection_event): Simplify.
485 (x_get_foreign_selection): Don't ignore incoming requests while
486 waiting for an answer; this will fail when we implement
487 SAVE_TARGETS, and seems unnecessary anyway.
488 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
489 (Vx_sent_selection_functions): Doc fix.
490
0f4aebc0
LL
4912011-05-26 Leo Liu <sdl.web@gmail.com>
492
493 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
494
e61124cd
YM
4952011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
496
497 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
498
499 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
500 for fringe update if it has periodic bitmap.
501 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
502 and fringe_bitmap_periodic_p.
503
504 * fringe.c (get_fringe_bitmap_data): New function.
505 (draw_fringe_bitmap_1, update_window_fringes): Use it.
506 (update_window_fringes): Record periodicity of fringe bitmap in glyph
507 row. Mark glyph row for fringe update if periodicity changed.
508
509 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
510 for fringe update unless it has periodic bitmap.
511
f16d9837
KH
5122011-05-25 Kenichi Handa <handa@m17n.org>
513
514 * xdisp.c (get_next_display_element): Set correct it->face_id for
515 a static composition.
516
e1b90ef6
LL
5172011-05-24 Leo Liu <sdl.web@gmail.com>
518
519 * deps.mk (fns.o):
520 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
521
522 * fns.c (crypto_hash_function, Fsha1): New function.
523 (Fmd5): Use crypto_hash_function.
524 (syms_of_fns): Add Ssha1.
525
7400048f
PE
5262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
527
528 * gnutls.c: Remove unused macros.
529 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
530 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
531 Remove macros that are defined and never used.
532 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
533
abb71cf4
CY
5342011-05-22 Chong Yidong <cyd@stupidchicken.com>
535
536 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
537 (Fx_get_selection_internal): Minor cleanup.
538 (Fx_own_selection_internal): Rename arguments for consistency with
539 select.el.
540
6307db39
PE
5412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
542
543 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
544
f3d4e0a4
CY
5452011-05-22 Chong Yidong <cyd@stupidchicken.com>
546
547 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
548
4d8ade89
YM
5492011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
550
551 * dispnew.c (scrolling_window): Don't exclude the case that the
552 last enabled row in the desired matrix touches the bottom boundary.
553
32078c8d
GM
5542011-05-21 Glenn Morris <rgm@gnu.org>
555
556 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
557 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
558 and add some more files.
32078c8d 559
7285dc67
EZ
5602011-05-20 Eli Zaretskii <eliz@gnu.org>
561
562 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
563 report_file_error introduced by the change from 2011-05-07.
564
89d1bd22
PE
5652011-05-20 Paul Eggert <eggert@cs.ucla.edu>
566
567 * systime.h (Time): Define only if emacs is defined.
568 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
569 where the include path doesn't have X11/X.h by default. See
570 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
571
e23640bb 5722011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
573
574 * composite.c (find_automatic_composition): Fix previous change.
575
b9704ad9
GM
5762011-05-20 Glenn Morris <rgm@gnu.org>
577
578 * lisp.mk: New file, split from Makefile.in.
579 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
580 (shortlisp): Remove.
581 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
582
4a720484
GM
5832011-05-19 Glenn Morris <rgm@gnu.org>
584
585 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
586 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
587 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
588 (lisp): Set the order to that of loadup.el.
589 (shortlisp): Make it a copy of $lisp.
590 (SOME_MACHINE_LISP): Remove.
591 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
592 Use just $shortlisp, not $SOME_MACHINE_LISP too.
593
a28d4396
KH
5942011-05-18 Kenichi Handa <handa@m17n.org>
595
596 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
597 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
598 (find_automatic_composition): Mostly rewrite for efficiency.
599
a2b1fa8e
JB
6002011-05-18 Juanma Barranquero <lekktu@gmail.com>
601
602 * makefile.w32-in: Update dependencies.
603
8e1f5610
CS
6042011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
605
606 * menu.c: Include limits.h (fixes the MS-Windows build broken by
607 revision 104625).
608
7025ee00 6092011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 610
cdfa6eab
PE
611 Fix some integer overflow issues, such as string length overflow.
612
06d6db33
PE
613 * insdel.c (count_size_as_multibyte): Check for string overflow.
614
2b4560a8
PE
615 * character.c (lisp_string_width): Check for string overflow.
616 Use EMACS_INT, not int, for string indexes and lengths; in
617 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
618 the resulting string length overflows an EMACS_INT; instead,
619 report a string overflow if no precision given. When checking for
620 precision exhaustion, use a check that cannot possibly have
621 integer overflow. (Bug#8675)
622 * character.h (lisp_string_width): Adjust to new signature.
623
cb93f9be
PE
624 * alloc.c (string_overflow): New function.
625 (Fmake_string): Use it. This doesn't change behavior, but saves
626 a few bytes and will simplify future changes.
627 * character.c (string_escape_byte8): Likewise.
628 * lisp.h (string_overflow): New decl.
629
1a1f3366
PE
630 Fixups, following up to the user-interface timestamp change.
631 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
632 for UI timestamps, instead of unsigned long.
9fbd6841
PE
633 * msdos.c (mouse_get_pos): Likewise.
634 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
635 * w32gui.h (Time): Define by including "systime.h" rather than by
636 declaring it ourselves. (Bug#8664)
637
d4e3e4d3
PE
638 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
639 * image.c (clear_image_cache): Likewise.
640
f6a24d19
PE
641 * term.c (term_mouse_position): Don't assume time_t wraparound.
642
08dc5ae6
PE
643 Be more systematic about user-interface timestamps.
644 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
645 and sometimes 'EMACS_UINT', to represent these timestamps.
646 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
647 This makes the code easier to follow, and makes it easier to catch
648 integer overflow bugs such as Bug#8664.
649 * frame.c (Fmouse_position, Fmouse_pixel_position):
650 Use Time, not unsigned long, for user-interface timestamps.
651 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
652 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
653 * keyboard.h (last_event_timestamp): Likewise.
654 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
655 * menu.h (xmenu_show): Likewise.
656 * term.c (term_mouse_position): Likewise.
657 * termhooks.h (struct input_event.timestamp): Likewise.
658 (struct terminal.mouse_position_hook): Likewise.
659 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
660 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
661 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
662 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
663 what it was before.
664 * menu.h, termhooks.h: Include "systime.h", for Time.
665
8e55734a
PE
666 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
667 Don't assume that the difference between two unsigned long values
668 can fit into an integer. At this point, we know button_down_time
669 <= event->timestamp, so the difference must be nonnegative, so
670 there's no need to cast the result if double-click-time is
671 nonnegative, as it should be; check that it's nonnegative, just in
672 case. This bug is triggered when events are more than 2**31 ms
86db42d2 673 apart (about 25 days). (Bug#8664)
8e55734a 674
841f1b75 675 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 676 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 677
3e26f69c
PE
678 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
679 that always fit in int. Use a sentinel instead of a counter, to
680 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
681 * frame.h (struct frame): Use int for menu_bar_items_used
682 instead of EMACS_INT, since it always fits in int.
3e26f69c 683
5cc152c0
PE
684 * menu.c (grow_menu_items): Check for int overflow.
685
d89eb65e
PE
686 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
687
5235bd3e
PE
688 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
689 Before, the code was not consistent. These values cannot exceed
690 2**31 - 1 so there's no need to make them unsigned.
691 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
692 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
693 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
694 as modifiers.
695 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
696
bc827e23
PE
697 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
698 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
699 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
700 presumably because the widths might not match.
701
78eb494e
PE
702 * window.c (size_window): Avoid needless test at loop start.
703
04f2d78b
CB
7042011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
705
706 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
707
d2fc7e3d 7082011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
709
710 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
711
d2fc7e3d 7122011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
713
714 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
715 `width' to `bar_area_x' and `bar_area_width', respectively.
716 (x_scroll_run): Take account of fringe background extension.
717
04f2d78b
CB
718 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
719 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
720 `bar_area_width', respectively.
721 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
722 background extension.
723
79b70037
GM
7242011-05-10 Jim Meyering <meyering@redhat.com>
725
726 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
727
2f142cc5
JB
7282011-05-10 Juanma Barranquero <lekktu@gmail.com>
729
730 * image.c (Finit_image_library): Return t for built-in image types,
731 like pbm and xbm. (Bug#8640)
732
57679c86
AS
7332011-05-09 Andreas Schwab <schwab@linux-m68k.org>
734
735 * w32menu.c (set_frame_menubar): Fix submenu allocation.
736
888c9e86
EZ
7372011-05-07 Eli Zaretskii <eliz@gnu.org>
738
b0512a1d
EZ
739 * w32console.c (Fset_screen_color): Doc fix.
740 (Fget_screen_color): New function.
741 (syms_of_ntterm): Defsubr it.
742
7285dc67
EZ
743 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
744 unlink the temporary file if Fcall_process didn't create it in the
745 first place.
746 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
747 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
748 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
749 cue to call_process_cleanup not to close that handle.
750
4d3fcc8e
BK
7512011-05-07 Ben Key <bkey76@gmail.com>
752
753 * makefile.w32-in: The bootstrap-temacs rule now makes use of
754 one of two shell specific rules, either bootstrap-temacs-CMD or
755 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
756 to the previous implementation of the bootstrap-temacs rule.
757 The bootstrap-temacs-CMD rule is similar to the previous
758 implementation of the bootstrap-temacs rule except that it
759 makes use of the ESC_CFLAGS variable instead of the CFLAGS
760 variable.
761
762 These changes, along with some changes to nt/configure.bat,
763 nt/gmake.defs, and nt/nmake.defs, are required to extend my
764 earlier fix to add support for --cflags and --ldflags options
765 that include quotes so that it works whether make uses cmd or
766 sh as the shell.
767
b4289b64
MA
7682011-05-06 Michael Albinus <michael.albinus@gmx.de>
769
770 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
771 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
772 is a constant.
773 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
774 a string. Handle both cases.
775 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
776 (Fdbus_register_method): Use Qinvalid_function.
777
af4c0e28
JB
7782011-05-06 Juanma Barranquero <lekktu@gmail.com>
779
780 * makefile.w32-in: Update dependencies.
781 (LISP_H): Add inttypes.h and stdin.h.
782 (PROCESS_H): Add unistd.h.
783
c51453d9
EZ
7842011-05-06 Eli Zaretskii <eliz@gnu.org>
785
786 * lread.c: Include limits.h (fixes the MS-Windows build broken by
787 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
788
8ff0ac3c 7892011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 790
4c4b566b
PE
791 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
792
aab2b9b5
PE
793 * term.c (vfatal): Remove stray call to va_end.
794 It's not needed and the C Standard doesn't allow it here anyway.
795
c378da0b
PE
796 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
797 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
798
288b08c7
PE
799 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
800 bytes.
801
e3601888
PE
802 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
803
db6c0e74
PE
804 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
805
dd5963ea
PE
806 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
807
88c9450f
PE
808 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
809
2f9442b8
PE
810 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
811
c032b5f8
PE
812 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
813 * charset.c (Fdefine_charset_internal): Don't initialize
814 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 815 32-bit int (Bug#8600).
a108c10b
PE
816
817 * lread.c (read_integer): Be more consistent with string-to-number.
818 Use string_to_number to do the actual conversion; this avoids
819 rounding errors and fixes some other screwups. Without this fix,
820 for example, #x1fffffffffffffff was misread as -2305843009213693952.
821 (digit_to_number): Move earlier, for benefit of read_integer.
822 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 823 not a digit in any supported base. (Bug#8602)
a108c10b 824
ad5f9eea
PE
825 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
826
aec1708a
PE
827 * dispnew.c (scrolling_window): Return 1 if we scrolled,
828 to match comment at start of function. This also removes a
829 GCC warning about overflow in a 32+64-bit port.
830
47be4ab5
PE
831 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
832
371cac43
PE
833 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
834 Reported by Stefan Monnier in
835 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
836 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
837 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 838
d01a7826
PE
839 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
840 (EMACS_UINTPTR): Likewise, with uintptr_t.
841
7fd47d5c
PE
842 * lisp.h: Prefer 64-bit EMACS_INT if available.
843 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
844 on 32-bit hosts that have 64-bit int, so that they can access
845 large files.
122b0c86
PE
846 However, temporarily disable this change unless the temporary
847 symbol WIDE_EMACS_INT is defined.
7fd47d5c 848
8727937b
PE
849 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
850
8ac068ac
PE
851 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
852 This removes an assumption that EMACS_INT and long are the same
853 width as pointers. The assumption is true for Emacs porting targets
854 now, but we want to make other targets possible.
855 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
856 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
857 In the rest of the code, change types of integers that hold casted
858 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
859 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
860 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
861 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
862 No need to cast type when ORing.
863 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
864 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
865 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
866 assume EMACS_INT is the same width as char *.
867 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
868 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
869 Remove no-longer-needed casts.
870 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
871 (xg_tool_bar_help_callback, xg_make_tool_item):
872 Use EMACS_INTPTR to hold an integer
873 that will be cast to void *; this can avoid a GCC warning
874 if EMACS_INT is not the same width as void *.
875 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
876 * xdisp.c (display_echo_area_1, resize_mini_window_1):
877 (current_message_1, set_message_1):
878 Use a local to convert to proper width without a cast.
879 * xmenu.c (dialog_selection_callback): Likewise.
880
ede49d71
PE
881 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
882 Also, don't assume VALBITS / RAND_BITS is less than 5,
883 and don't rely on undefined behavior when shifting a 1 left into
884 the sign bit.
885 * lisp.h (get_random): Change signature to match.
886
2f30ecd0
PE
887 * lread.c (hash_string): Use size_t, not int, for hash computation.
888 Normally we prefer signed values; but hashing is special, because
889 it's better to use unsigned division on hash table sizes so that
890 the remainder is nonnegative. Also, size_t is the natural width
891 for hashing into memory. The previous code used 'int', which doesn't
892 retain enough info to hash well into very large tables.
893 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
894
2a866e7b
PE
895 * dbusbind.c: Don't possibly lose pointer info when converting.
896 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
897 Use XPNTR rather than XHASH, so that the high-order bits of
898 the pointer aren't lost when converting through void *.
899
51639eac
PE
900 * eval.c (Fautoload): Don't double-shift a pointer.
901
92394119
PE
902 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
903
dbdb9a7c
JB
9042011-05-06 Juanma Barranquero <lekktu@gmail.com>
905
906 * gnutls.c (DEF_GNUTLS_FN):
907 * image.c (DEF_IMGLIB_FN): Make function pointers static.
908
db7a0b4f
AS
9092011-05-05 Andreas Schwab <schwab@linux-m68k.org>
910
911 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
912 marker. (Bug#8610)
913
f7ff1b0f 9142011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
915
916 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
917 New version that can reserve upto 2GB of heap space.
918
f7ff1b0f 9192011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
920
921 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
922
639c109b
TZ
9232011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
924
925 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
926 `gnutls_certificate_set_x509_key_file'.
927
d2127135
JB
9282011-05-05 Juanma Barranquero <lekktu@gmail.com>
929
930 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
931 Update dependencies.
932
e968f4f3
JB
9332011-05-04 Juanma Barranquero <lekktu@gmail.com>
934
935 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
936 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
937 Remove unused parameter `fildes'.
938 * process.c (read_process_output, send_process): Don't pass it.
939
84d358f0
JB
9402011-05-04 Juanma Barranquero <lekktu@gmail.com>
941
942 Fix previous change: the library cache is defined in w32.c.
943 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
944 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
945
0898ca10
JB
9462011-05-04 Juanma Barranquero <lekktu@gmail.com>
947
948 Implement dynamic loading of GnuTLS on Windows.
949
950 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
951 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
952 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
953 Declare.
954
955 * gnutls.c (Qgnutls_dll): Define.
956 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
957 (gnutls_*): Declare function pointers.
958 (init_gnutls_functions): New function to initialize function pointers.
959 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
960 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
961 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
962 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
963 (emacs_gnutls_write, emacs_gnutls_read)
964 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
965 (Fgnutls_available_p): New function.
966 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
967 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
968 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
969
970 * image.c: Include w32.h.
971 (Vimage_type_cache): Delete.
972 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
973 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
974 (w32_delayed_load): Move to w32.c.
975
976 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
977
978 * w32.c (QCloaded_from, Vlibrary_cache): Define.
979 (w32_delayed_load): Move from image.c. When loading a library, record
980 its filename in the :loaded-from property of the library id.
981 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
982 Initialize and staticpro them.
983 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
984
985 * process.c: Include lisp.h before w32.h, not after.
986 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
987 instead of gnutls_record_check_pending.
988
989 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
990
ff4de4aa
TZ
9912011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
992
993 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
994 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
995 as passed in.
996
abe95abb
JD
9972011-05-03 Jan Djärv <jan.h.d@swipnet.se>
998
999 * xterm.c (x_set_frame_alpha): Do not set property on anything
1000 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1001
e16e55d4
JB
10022011-05-02 Juanma Barranquero <lekktu@gmail.com>
1003
1004 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1005
bafcf6a5
JB
10062011-05-02 Juanma Barranquero <lekktu@gmail.com>
1007
1008 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1009 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1010 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1011 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1012 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1013 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1014 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1015 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1016 (Qgnutls_bootprop_callbacks_verify): Make static.
1017
e7a6747f
AS
10182011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1019
19ed11ba
AS
1020 * callproc.c: Indentation fixup.
1021
e7a6747f 1022 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1023 (wait_for_termination, interruptible_wait_for_termination):
1024 Move after wait_for_termination_1.
e7a6747f 1025
1ef14cb4
LMI
10262011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1027
1028 * sysdep.c (interruptible_wait_for_termination): New function
1029 which is like wait_for_termination, but allows keyboard
1030 interruptions.
1031
1032 * callproc.c (Fcall_process): Add (:file "file") as an option for
1033 the STDOUT buffer.
1034 (Fcall_process_region): Ditto.
1035
330d880c
EZ
10362011-04-30 Eli Zaretskii <eliz@gnu.org>
1037
8db90b73
EZ
1038 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1039 rather than `XVECTOR (FOO)->size'.
1040
330d880c
EZ
1041 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1042 inttypes.h, as a gnulib replacement is used if it not available in
1043 system headers.
1044
15cbd324
EZ
10452011-04-21 Eli Zaretskii <eliz@gnu.org>
1046
1047 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1048 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1049 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1050
1051 * coding.c (coding_alloc_by_realloc): Error out if destination
1052 will grow beyond MOST_POSITIVE_FIXNUM.
1053 (decode_coding_emacs_mule): Abort if there isn't enough place in
1054 charbuf for the composition carryover bytes. Reserve an extra
1055 space for up to 2 characters produced in a loop.
1056 (decode_coding_iso_2022): Abort if there isn't enough place in
1057 charbuf for the composition carryover bytes.
1058
10592011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1060
ae940cca
EZ
1061 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1062 aborting when %lld or %lll format is passed.
1063 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1064 %llo or %llx format is passed. (Bug#8545)
1065
03ab8921
EZ
1066 * window.c (window_scroll_line_based): Use a marker instead of
1067 simple variables to record original value of point. (Bug#7952)
1068
afda1437
EZ
1069 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1070 produced by %s or %c overflows available buffer space. (Bug#8545)
1071
f76dee0c
PE
10722011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1073
1074 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1075 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1076
fdc5744d
JB
10772011-04-28 Juanma Barranquero <lekktu@gmail.com>
1078
1079 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1080
638f053a
JB
10812011-04-28 Juanma Barranquero <lekktu@gmail.com>
1082
1083 * keyboard.c (Qdelayed_warnings_hook): Define.
1084 (command_loop_1): Run `delayed-warnings-hook'
1085 if Vdelayed_warnings_list is non-nil.
1086 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1087 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1088
d178f871
EZ
10892011-04-28 Eli Zaretskii <eliz@gnu.org>
1090
1091 * doprnt.c (doprnt): Don't return value smaller than the buffer
1092 size if the message was truncated. (Bug#8545).
1093
b124fd93
JB
10942011-04-28 Juanma Barranquero <lekktu@gmail.com>
1095
1096 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1097 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1098
e810457d
PE
10992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1102
ea51cceb
JB
11032011-04-27 Juanma Barranquero <lekktu@gmail.com>
1104
1105 * makefile.w32-in: Update dependencies.
1106
94dcfacf
EZ
11072011-04-27 Eli Zaretskii <eliz@gnu.org>
1108
1109 Improve `doprnt' and its usage. (Bug#8545)
1110 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1111 `format_end'. Remove support for %l as a conversion specifier.
1112 Don't use xrealloc. Improve diagnostics when the %l size modifier
1113 is used. Update the commentary.
1114
1115 * eval.c (verror): Simplify calculation of size_t.
1116
1117 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1118 messages.
1119
f61f41d7
PE
11202011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1121
1122 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1123 change.
1124
96fb4434
PE
11252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1126
1127 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1128 This makes this file independent of the recent pseudovector change.
1129
671875da 11302011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1131
69e9b5a3
PE
1132 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1133
b5f869a7 1134 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1135 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1136 Remove unused local.
c8926152 1137 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1138
841a1577 1139 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1140 GCC 4.6.0 optimizes based on type-based alias analysis.
1141 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1142 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1143 != &v->size, and therefore "v->size = 1; b->size = 2; return
1144 v->size;" must therefore return 1. This assumption is incorrect
1145 for Emacs, since it type-puns struct Lisp_Vector * with many other
1146 types. To fix this problem, this patch adds a new type struct
f904488f 1147 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1148 and pseudovectors, and helps optimizing compilers not get fooled
1149 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1150 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1151 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1152 the size member.
eab3844f
PE
1153 (XSETPVECTYPE): Rewrite in terms of new macro.
1154 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1155 This is a bit clearer, and further avoids the possibility of
1156 undesirable aliasing.
1157 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1158 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1159 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1160 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1161 (ASIZE): Now uses header.size rather than size.
1162 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1163 to avoid the hassle of writing XVECTOR (foo)->header.size.
1164 (struct vectorlike_header): New type.
eab3844f
PE
1165 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1166 object, to help avoid aliasing.
1167 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1168 (SUBRP): Likewise, since Lisp_Subr is a special case.
1169 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1170 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1171 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1172 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1173 changed to be "header.size" and "header.next".
1174 * buffer.h (struct buffer): Likewise.
1175 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1176 * frame.h (struct frame): Likewise.
1177 * process.h (struct Lisp_Process): Likewise.
1178 * termhooks.h (struct terminal): Likewise.
1179 * window.c (struct save_window_data, struct saved_window): Likewise.
1180 * window.h (struct window): Likewise.
1181 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1182 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1183 * buffer.c (init_buffer_once): Likewise.
1184 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1185 special case.
1186 * process.c (Fformat_network_address): Use local var for size,
1187 for brevity.
1188
0df1eac5
PE
1189 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1190
847ab9d1 1191 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1192 * data.c (atof): Remove decl; no longer used or needed.
1193 (digit_to_number): Move to lread.c.
1194 (Fstring_to_number): Use new string_to_number function, to be
1195 consistent with how the Lisp reader treats infinities and NaNs.
1196 Do not assume that floating-point numbers represent EMACS_INT
1197 without losing information; this is not true on most 64-bit hosts.
1198 Avoid double-rounding errors, by insisting on integers when
1199 parsing non-base-10 numbers, as the documentation specifies.
1200 * lisp.h (string_to_number): New decl, replacing ...
1201 (isfloat_string): Remove.
bc0a5c13 1202 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1203 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1204 appears to have been a coding error. Similarly, do not accept
1205 strings like +-1e0 as floating point numbers. Do not report
1206 overflow for integer overflows unless the base is not 10 which
1207 means we have no simple and reliable way to continue.
1208 Break out the floating-point parsing into a new
1209 function string_to_number, so that Fstring_to_number parses
1210 floating point numbers consistently with the Lisp reader.
04f2d78b 1211 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1212 (E_CHAR, EXP_INT): Remove, replacing with ...
1213 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1214 (string_to_number): New function, replacing isfloat_string.
1215 This function checks for valid syntax and produces the resulting
1216 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1217 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1218 so that overflow for non-base-10 numbers is reported only when
1219 there's no portable and simple way to convert to floating point.
452f4150 1220
67769ffc
PE
1221 * textprop.c (set_text_properties_1): Rewrite for clarity,
1222 and to avoid GCC warning about integer overflow.
1223
c20db43f
PE
1224 * intervals.h (struct interval): Use EMACS_INT for members
1225 where EMACS_UINT might cause problems. See
1226 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1227 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1228 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1229 All uses changed.
37aa2f85
PE
1230 (offset_intervals): Tell GCC not to worry about length overflow
1231 when negating a negative length.
c20db43f 1232
2538aa2f
PE
1233 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1234 (overrun_check_free): Likewise.
1235
f2d3008d
PE
1236 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1237 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1238 word size.
1239
ec8df744
PE
1240 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1241 (gnutls_make_error): Rename local to avoid shadowing.
1242 (gnutls_emacs_global_deinit): ifdef out; not used.
1243 (Fgnutls_boot): Use const for pointer to readonly storage.
1244 Comment out unused local. Fix pointer signedness problems.
1245
640ee02d
PE
1246 * lread.c (openp): Don't stuff size_t into an 'int'.
1247 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1248 about possible signed overflow.
1249
6048fb2a
PE
1250 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1251 (GDK_KEY_g): Don't define if already defined.
1252 (xg_prepare_tooltip): Avoid pointer signedness problem.
1253 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1254
fa3c87e1
PE
1255 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1256 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1257
2172544b
PE
1258 * xfns.c (Fx_window_property): Simplify a bit,
1259 to make a bit faster and to avoid GCC 4.6.0 warning.
1260 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1261
9b821a21
PE
1262 * fns.c (internal_equal): Don't assume size_t fits in int.
1263
3c616cfa
PE
1264 * alloc.c (compact_small_strings): Tighten assertion a little.
1265
c2982e87
PE
1266 Replace pEd with more-general pI, and fix some printf arg casts.
1267 * lisp.h (pI): New macro, generalizing old pEd macro to other
1268 conversion specifiers. For example, use "...%"pI"d..." rather
1269 than "...%"pEd"...".
1270 (pEd): Remove. All uses replaced with similar uses of pI.
1271 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1272 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1273 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1274 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1275 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1276 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1277 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1278 64-bit hosts.
1279 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1280 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1281 * print.c (safe_debug_print, print_object): Likewise.
1282 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1283 to int.
6f04d126
PE
1284 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1285 avoiding the 0 flag, which is not portable.
c2982e87
PE
1286 * process.c (Fmake_network_process): Use pI to avoid cast.
1287 * region-cache.c (pp_cache): Likewise.
1288 * xdisp.c (decode_mode_spec): Likewise.
1289 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1290 behavior on 64-bit hosts with printf arg.
6f04d126 1291 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1292 (x_stop_queuing_selection_requests): Likewise.
1293 (x_get_window_property): Don't truncate byte count to an 'int'
1294 when tracing.
0b432f21 1295
5e073ec7
PE
1296 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1297 here, since it parses constructs like leading '-' and spaces,
1298 which are not wanted; and it overflows with large numbers.
1299 Instead, simply match F[0-9]+, which is what is wanted anyway.
1300
36372bf9
PE
1301 * alloc.c: Remove unportable assumptions about struct layout.
1302 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1303 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1304 (allocate_vectorlike, make_pure_vector): Use the new macros,
1305 plus offsetof, to remove unportable assumptions about struct layout.
1306 These assumptions hold on all porting targets that I know of, but
1307 they are not guaranteed, they're easy to remove, and removing them
1308 makes further changes easier.
1309
0b432f21
PE
1310 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1311 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1312 (string_overrun_cookie): Now const. Use initializers that
1313 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1314 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1315 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1316 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1317 multiple of sizeof (EMACS_INT); it need not be, if
1318 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1319 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1320
895009e1
JB
13212011-04-26 Juanma Barranquero <lekktu@gmail.com>
1322
1323 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1324
6a7a1b0b
TZ
13252011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1326
1327 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1328 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1329 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1330
841a1577 13312011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1332
1333 * lisp.h (Qdebug): List symbol.
895009e1 1334 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1335 * keyboard.c (debug-on-event): New variable.
1336 (handle_user_signal): Break into debugger when debug-on-event
1337 matches the current signal symbol.
1338
f2d3ba6f
DN
13392011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1340
1341 * alloc.c (check_sblock, check_string_bytes)
1342 (check_string_free_list): Convert to standard C.
1343
42ce4c63
TZ
13442011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1345
1346 * w32.c (emacs_gnutls_push): Fix typo.
1347
825cd63c
EZ
13482011-04-25 Eli Zaretskii <eliz@gnu.org>
1349
fb11d64d
EZ
1350 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1351 "cast to pointer from integer of different size".
1352
825cd63c
EZ
1353 Improve doprnt and its use in verror. (Bug#8545)
1354 * doprnt.c (doprnt): Document the set of format control sequences
1355 supported by the function. Use SAFE_ALLOCA instead of always
1356 using `alloca'.
1357
1358 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1359 is one byte too soon. Don't use xrealloc; instead xfree and
1360 xmalloc anew.
1361
e061a11b
TZ
13622011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1363
1364 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1365 callbacks stage.
1366
1367 * gnutls.c: Renamed global_initialized to
1368 gnutls_global_initialized. Added internals for the
1369 :verify-hostname-error, :verify-error, and :verify-flags
1370 parameters of `gnutls-boot' and documented those parameters in the
1371 docstring. Start callback support.
1372 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1373 unless a fatal error occured. Call gnutls_alert_send_appropriate
1374 on error. Return error code.
1375 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1376 (emacs_gnutls_read): Likewise.
1377 (Fgnutls_boot): Return handshake error code.
1378 (emacs_gnutls_handle_error): New function.
1379 (wsaerror_to_errno): Likewise.
1380
1381 * w32.h (emacs_gnutls_pull): Add prototype.
1382 (emacs_gnutls_push): Likewise.
1383
1384 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1385 (emacs_gnutls_push): Likewise.
1386
13872011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1388
1389 * process.c (wait_reading_process_output): Check if GnuTLS
1390 buffered some data internally if no FDs are set for TLS
1391 connections.
1392
1393 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1394 (LIBS): Link to USER_LIBS.
1395 ($(BLD)/gnutls.$(0)): New target.
1396
fa6996bc
EZ
13972011-04-24 Eli Zaretskii <eliz@gnu.org>
1398
eb35682e
EZ
1399 * xdisp.c (handle_single_display_spec): Rename the
1400 display_replaced_before_p argument into display_replaced_p, to
1401 make it consistent with the commentary. Fix typos in the
1402 commentary.
1403
e2ad650c
EZ
1404 * textprop.c (syms_of_textprop): Remove dead code.
1405 (copy_text_properties): Delete obsolete commentary about an
1406 interface that was deleted long ago. Fix typos in the description
1407 of arguments.
1408
1b2de274
EZ
1409 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1410 to changes in oldXMenu/XMenu.h from 2011-04-16.
1411 <menu_help_message, prev_menu_help_message>: Constify.
1412 (IT_menu_make_room): menu->help_text is now `const char **';
1413 adjust.
1414
1415 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1416 to changes in oldXMenu/XMenu.h from 2011-04-16.
1417 (struct XMenu): Declare `help_text' `const char **'.
1418
1419 * xfaces.c <Qunspecified>: Make extern again.
1420
1421 * syntax.c: Include sys/types.h before including regex.h, as
1422 required by Posix.
1423
762b15be
EZ
1424 * doc.c (get_doc_string): Improve the format passed to `error'.
1425
1426 * doprnt.c (doprnt): Improve commentary.
1427
1428 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1429
1430 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1431 them with etags.
1432
f1052e5d
EZ
1433 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1434 changes in globals.h immediately force recompilation.
762b15be
EZ
1435 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1436 $(CURDIR)/s/ms-w32.h.
1437 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1438
fa6996bc
EZ
1439 * character.c (Fchar_direction): Function deleted.
1440 (syms_of_character): Don't defsubr it.
1441 <char-direction-table>: Deleted.
1442
e6c3da20
EZ
14432011-04-23 Eli Zaretskii <eliz@gnu.org>
1444
1445 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1446 * doprnt.c: Include limits.h.
1447 (SIZE_MAX): New macro.
04f2d78b
CB
1448 (doprnt): Return a size_t value. 2nd arg is now size_t.
1449 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1450 Improve overflow protection. Support `l' modifier for integer
1451 conversions. Support %l conversion. Don't assume an EMACS_INT
1452 argument for integer conversions and for %c.
1453
1454 * lisp.h (doprnt): Restore prototype.
1455
1456 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1457 $(SRC)/character.h.
1458
1459 * Makefile.in (base_obj): Add back doprnt.o.
1460
1461 * deps.mk (doprnt.o): Add back prerequisites.
1462 (callint.o): Depend on character.h.
1463
1464 * eval.c (internal_lisp_condition_case): Include the handler
1465 representation in the error message.
1466 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1467 when breaking from the loop.
1468
1469 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1470
1471 * callint.c (Fcall_interactively): When displaying error message
1472 about invalid control letter, pass the character's codepoint, not
1473 a pointer to its multibyte form. Improve display of the character
1474 in octal and display also its hex code.
1475
1476 * character.c (char_string): Use %x to display the (unsigned)
1477 codepoint of an invalid character, to avoid displaying a bogus
1478 negative value.
1479
1480 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1481 `error', not SYMBOL_NAME itself.
1482
1483 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1484 character arguments to `error'.
1485
1486 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1487 to `error' in error message about FINAL_CHAR argument. Make sure
1488 FINAL_CHAR is a character, and use %c when it is passed as
1489 argument to `error'.
1490
4ffd0d6b 14912011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1492
1493 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1494
1495 * w32.c: Include <time.h>.
1496 (sys_localtime): New function.
1497
4ffd0d6b 14982011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1499
1500 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1501
4ffd0d6b 1502 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1503
4ffd0d6b 15042011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1505
4ffd0d6b
GM
1506 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1507 zombies (Bug#8467).
aac0c6e3 1508
04c56954
EZ
15092011-04-19 Eli Zaretskii <eliz@gnu.org>
1510
1511 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1512 gl_state.e_property when gl_state.object is Qt.
1513
1514 * insdel.c (make_gap_larger): Remove limitation of buffer size
1515 to <= INT_MAX.
1516
16a43933
CY
15172011-04-18 Chong Yidong <cyd@stupidchicken.com>
1518
1519 * xdisp.c (lookup_glyphless_char_display)
1520 (produce_glyphless_glyph): Handle cons cell entry in
1521 glyphless-char-display.
1522 (Vglyphless_char_display): Document it.
1523
1524 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1525 glyphless-char-display.
1526
4581706e
CY
15272011-04-17 Chong Yidong <cyd@stupidchicken.com>
1528
1529 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1530
1531 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1532
1533 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1534 definition for no-X builds.
1535
4887c6e2 15362011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1537
fd35b6f9
PE
1538 Static checks with GCC 4.6.0 and non-default toolkits.
1539
5c1ccb01
PE
1540 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1541
006c5daa
PE
1542 * process.c (keyboard_bit_set): Define only if SIGIO.
1543 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1544 (send_process): Repair possible setjmp clobbering.
1545
efc736d3
PE
1546 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1547
4e2fe2e6
PE
1548 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1549
f97334a2
PE
1550 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1551
4e75f29d
PE
1552 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1553 Define only if needed.
1554
90efadd1
PE
1555 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1556 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1557 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1558
3c647824
PE
1559 * dispextern.h (struct redisplay_interface): Rename param
1560 to avoid shadowing.
e264f262 1561 * termhooks.h (struct terminal): Likewise.
761383f4 1562 * xterm.c (xembed_send_message): Likewise.
3c647824 1563
b58c5c4a
PE
1564 * insdel.c (make_gap_smaller): Define only if
1565 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1566
cad59032
PE
1567 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1568 it.
1569
c339dc2e
PE
1570 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1571 so that we aren't warned about unused symbols.
1572
91a3e27b
PE
1573 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1574
399c71d3 1575 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1576
8ffc96f5
PE
1577 * xfns.c (x_real_positions): Mark locals as initialized.
1578
eef9bc79
PE
1579 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1580
098db9dd
PE
1581 * xterm.c: Fix problems found by static analysis with other toolkits.
1582 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1583 (x_dispatch_event): Declare static if USE_GTK, and
1584 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1585 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1586 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1587 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1588 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1589
eb18f6cc
PE
1590 * xmenu.c (menu_help_callback): Pointer type fixes.
1591 Use const pointers when pointing at readonly data. Avoid pointer
1592 signedness clashes.
1593 (FALSE): Remove unused macro.
1594 (update_frame_menubar): Remove unused decl.
1595
1fe72bf8
PE
1596 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1597
60d9e1db
PE
1598 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1599 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1600 (single_menu_item): Rename local to avoid shadowing.
1601
39261c26
PE
1602 * keyboard.c (make_lispy_event): Remove unused local var.
1603
018c5e19
PE
1604 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1605 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1606
63d2b86e
PE
1607 * bitmaps: Change bitmaps from unsigned char back to the X11
1608 compatible char. Avoid the old compiler warnings about
1609 out-of-range initializers by using, for example, '\xab' rather
1610 than 0xab.
1611
aefd87e1
PE
1612 * xgselect.c (xgselect_initialize): Check vs interface
1613 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1614
bf501fb9
PE
1615 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1616
e9829fdf
PE
1617 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1618 to read-only memory.
1619
1086c095
PE
1620 * fns.c (vector): Remove; this old hack is no longer needed.
1621
2baccd04 1622 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1623 Remove unused var.
dde42981 1624 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1625
72391843 1626 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1627
436c16df 1628 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1629 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1630 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1631
92bb796d 1632 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1633 (x_term_init): Remove local to avoid shadowing.
92bb796d 1634
764430a3 1635 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1636
1637 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1638 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1639
d1dfb56c
EZ
16402011-04-16 Eli Zaretskii <eliz@gnu.org>
1641
c4354cb4
EZ
1642 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1643
d1dfb56c
EZ
1644 Fix regex.c, syntax.c and friends for buffers > 2GB.
1645 * syntax.h (struct gl_state_s): Declare character position members
1646 EMACS_INT.
1647
1648 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1649
04f2d78b
CB
1650 * textprop.c (verify_interval_modification, interval_of):
1651 Declare arguments EMACS_INT.
d1dfb56c
EZ
1652
1653 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1654 EMACS_INT.
1655
1656 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1657
1658 * indent.c (Fvertical_motion): Local variable it_start is now
1659 EMACS_INT.
1660
1661 * regex.c (re_match, re_match_2, re_match_2_internal)
1662 (bcmp_translate, regcomp, regexec, print_double_string)
1663 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1664 (re_compile_pattern, re_exec): Declare arguments and local
1665 variables `size_t' and `ssize_t' and return values `regoff_t', as
1666 appropriate.
1667 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1668 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1669 <compile_stack_type>: `size' and `avail' are now `size_t'.
1670
1671 * regex.h <regoff_t>: Use ssize_t, not int.
1672 (re_search, re_search_2, re_match, re_match_2): Arguments that
1673 specify buffer/string position and length are now ssize_t and
1674 size_t. Return type is regoff_t.
1675
613052cd
BK
16762011-04-16 Ben Key <bkey76@gmail.com>
1677
1678 * nsfont.m: Fixed bugs in ns_get_family and
1679 ns_descriptor_to_entity that were caused by using free to
1680 deallocate memory blocks that were allocated by xmalloc (via
1681 xstrdup). This caused Emacs to crash when compiled with
1682 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1683 --enable-checking=xmallocoverrun). xfree is now used to
1684 deallocate these memory blocks.
1685
4170f62f 16862011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1687
71b41406
PE
1688 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1689
9587a89d
PE
1690 emacs_write: Accept and return EMACS_INT for sizes.
1691 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1692 et seq.
1693 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1694 Accept and return EMACS_INT.
1695 (emacs_gnutls_write): Return the number of bytes written on
1696 partial writes.
1697 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1698 (emacs_read, emacs_write): Remove check for negative size, as the
1699 Emacs source code has been audited now.
9587a89d
PE
1700 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1701 (emacs_read, emacs_write): Use it.
273a5f82
PE
1702 * process.c (send_process): Adjust to the new signatures of
1703 emacs_write and emacs_gnutls_write. Do not attempt to store
1704 a byte offset into an 'int'; it might overflow.
9587a89d 1705 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1706
3e047f51
PE
1707 * sound.c: Don't assume sizes fit in 'int'.
1708 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1709 Return EMACS_INT, not int.
3e047f51 1710 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1711 Accept EMACS_INT, not int.
1712 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1713 record read return values.
1714
cc39a9db
BK
17152011-04-15 Ben Key <bkey76@gmail.com>
1716
c9d0ec6d
JB
1717 * keyboard.c (Qundefined): Don't declare static since it is used
1718 in nsfns.m.
1719 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1720 static since they are used in nsfont.m.
cc39a9db 1721
6c60eb9f
SM
17222011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1723
1724 * process.c (Qprocessp): Don't declare static.
1725 * lisp.h (Qprocessp): Declare again.
1726
7990b61a
JB
17272011-04-15 Juanma Barranquero <lekktu@gmail.com>
1728
1729 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1730
5d4cb038
PE
17312011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1732
8bd7b830 1733 Improve C-level modularity by making more things 'static'.
cd64ea1d 1734
e3b27b31
PE
1735 Don't publish debugger-only interfaces to other modules.
1736 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1737 (verify_bytepos, count_markers): Move decls to the only modules
1738 that need them.
1739 * region-cache.h (pp_cache): Likewise.
1740 * window.h (check_all_windows): Likewise.
1741 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1742
5d4cb038
PE
1743 * sysdep.c (croak): Now static, if
1744 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1745 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1746
1747 * alloc.c (refill_memory_reserve): Now static if
1748 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1749 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1750
e87b6180
PE
1751 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1752 Define only if USE_LUCID.
1753
ac64929e
PE
1754 * xrdb.c (x_customization_string, x_rm_string): Now static.
1755
6f37259d
PE
1756 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1757 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1758
1683e3ab
PE
1759 * xdisp.c (draw_row_with_mouse_face): Now static.
1760 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1761
de9c2632
PE
1762 * window.h (check_all_windows): Mark externally visible.
1763
2b96acb7
PE
1764 * window.c (window_deletion_count): Now static.
1765
1766 * undo.c: Make symbols static if they're not exported.
1767 (last_undo_buffer, last_boundary_position, pending_boundary):
1768 Now static.
1769
50436f33
PE
1770 * textprop.c (interval_insert_behind_hooks): Now static.
1771 (interval_insert_in_front_hooks): Likewise.
1772
64520e5c
PE
1773 * term.c: Make symbols static if they're not exported.
1774 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1775 (max_frame_lines, tty_set_terminal_modes):
1776 (tty_reset_terminal_modes, tty_turn_off_highlight):
1777 (get_tty_terminal): Now static.
1778 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1779 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1780 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1781 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1782 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1783
1fa53021
PE
1784 * sysdep.c: Make symbols static if they're not exported.
1785 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1786 Now static.
1787 (sigprocmask_set, full_mask): Remove; unused.
1788 (wait_debugging): Mark as visible.
1789 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1790 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1791
d4b43b22
PE
1792 * syntax.c (syntax_temp): Define only if !__GNUC__.
1793
b7c513d0
PE
1794 * sound.c (current_sound_device, current_sound): Now static.
1795
989b29ad
PE
1796 * search.c (searchbufs, searchbuf_head): Now static.
1797
13a55a78
PE
1798 * scroll.c (scroll_cost): Remove; unused.
1799 * dispextern.h (scroll_cost): Remove decl.
1800
de68a1fc
PE
1801 * region-cache.h (pp_cache): Mark as externally visible.
1802
40ccffa6
PE
1803 * process.c: Make symbols static if they're not exported.
1804 (process_tick, update_tick, create_process, chan_process):
1805 (Vprocess_alist, proc_buffered_char, datagram_access):
1806 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1807 (deactivate_process): Mark defn as static, as well as decl.
1808 * lisp.h (create_process): Remove decl.
1809 * process.h (chan_process, Vprocess_alist): Remove decls.
1810
ad64fc97
PE
1811 * print.c: Make symbols static if they're not exported.
1812 (print_depth, new_backquote_output, being_printed, print_buffer):
1813 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1814 (print_interval, print_number_index, initial_stderr_stream):
1815 Now static.
1816 * lisp.h (Fprinc): Remove decl.
1817 (debug_output_compilation_hack): Mark as externally visible.
1818
adddb265
PE
1819 * sysdep.c (croak): Move decl from here to syssignal.h.
1820 * syssignal.h (croak): Put it here, so the API can be checked when
1821 'croak' is called from dissociate_if_controlling_tty.
1822
1717ede2
PE
1823 * minibuf.c: Make symbols static if they're not exported.
1824 (minibuf_save_list, choose_minibuf_frame): Now static.
1825 * lisp.h (choose_minibuf_frame): Remove decl.
1826
fa5fb2bc
PE
1827 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1828
1e3890d1
PE
1829 * lread.c: Make symbols static if they're not exported.
1830 (read_objects, initial_obarray, oblookup_last_bucket_number):
1831 Now static.
1832 (make_symbol): Remove; unused.
1833 * lisp.h (initial_obarray, make_symbol): Remove decls.
1834
8a1414fa
PE
1835 * keyboard.c: Make symbols static if they're not exported.
1836 (single_kboard, recent_keys_index, total_keys, recent_keys):
1837 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1838 (this_single_command_key_start, echoing, last_auto_save):
1839 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1840 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1841 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1842 (Vlispy_mouse_stem, double_click_count):
1843 Now static.
1844 (force_auto_save_soon): Define only if SIGDANGER.
1845 (ignore_mouse_drag_p): Now static if
1846 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1847 (print_help): Remove; unused.
1848 (stop_character, last_timer_event): Mark as externally visible.
1849 * keyboard.h (ignore_mouse_drag_p): Declare only if
1850 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1851 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1852 * lisp.h (echoing): Remove decl.
1853 (force_auto_save_soon): Declare only if SIGDANGER.
1854 * xdisp.c (redisplay_window): Simplify code, to make it more
1855 obvious that ignore_mouse_drag_p is not accessed if !defined
1856 USE_GTK && !defined HAVE_NS.
1857
93ea6e8f
PE
1858 * intervals.c: Make symbols static if they're not exported.
1859 (merge_properties_sticky, merge_interval_right, delete_interval):
1860 Now static.
1861 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1862
77382fcc
PE
1863 * insdel.c: Make symbols static if they're not exported.
1864 However, leave prepare_to_modify_buffer alone. It's never
1865 called from outside this function, but that appears to be a bug.
1866 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1867 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1868 (adjust_after_replace_noundo): Remove; unused.
1869 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1870 (signal_before_change): Remove decls.
77382fcc 1871
9306c32e
PE
1872 * indent.c (val_compute_motion, val_vmotion): Now static.
1873
cd44d2eb
PE
1874 * image.c: Make symbols static if they're not exported.
1875 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1876 if USE_GTK.
1877 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1878 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1879
ad9a7a06
PE
1880 * fringe.c (standard_bitmaps): Now static.
1881 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1882
81626931
PE
1883 * frame.c: Make symbols static if they're not exported.
1884 (x_report_frame_params, make_terminal_frame): Now static.
1885 (get_frame_param): Now static, unless HAVE_NS.
1886 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1887 (x_get_resource_string): Remove; not used.
1888 * frame.h (make_terminal_frame, x_report_frame_params):
1889 (x_get_resource_string); Remove decls.
1890 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1891 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1892
239f9db9
PE
1893 * font.c, fontset.c: Make symbols static if they're not exported.
1894 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1895 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1896 * font.c (font_close_object): Now static.
1897 * font.h (font_close_object): Remove.
1898 * fontset.c (FONTSET_OBJLIST): Remove.
1899 (free_realized_fontset) #if-0 the body, which does nothing.
1900 (face_suitable_for_char_p): #if-0, as it's never called.
1901 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1902 * xfaces.c (face_at_string_position):
1903 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1904 since 0 is always ASCII.
1905
dfcf3579
PE
1906 * fns.c (weak_hash_tables): Now static.
1907
5045092b
PE
1908 * fileio.c: Make symbols static if they're not exported.
1909 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1910 (Vwrite_region_annotation_buffers): Now static.
1911
57a96f5c
PE
1912 * eval.c: Make symbols static if they're not exported.
1913 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1914 * lisp.h (backtrace_list): Remove decl.
1915
35f08c38
PE
1916 * emacs.c: Make symbols static if they're not exported.
1917 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1918 (fatal_error_code, fatal_error_signal_hook, standard_args):
1919 Now static.
1920 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1921 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1922 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1923 * lisp.h (fatal_error_signal_hook): Remove decl.
1924 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1925
f44bd759
PE
1926 * editfns.c: Move a (normally-unused) function to its only use.
1927 * editfns.c, lisp.h (get_operating_system_release): Remove.
1928 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1929 worth the hassle of breaking this out.
1930
b532497d
PE
1931 * xterm.c: Make symbols static if they're not exported.
1932 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1933 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1934 (x_destroy_window, x_delete_display):
1935 Now static.
1936 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1937 (x_mouse_leave): Remove; unused.
1938 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1939 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1940 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1941 Remove decls.
1942 (x_mouse_leave): Declare only if WINDOWSNT.
1943 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1944 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1945 USE_X_TOOLKIT.
1946
1675728f
PE
1947 * ftxfont.c: Make symbols static if they're not exported.
1948 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1949 HAVE_FREETYPE.
1950 * font.h (ftxfont_driver): Likewise.
1951
e4cebfca
PE
1952 * xfns.c: Make symbols static if they're not exported.
1953 (x_last_font_name, x_display_info_for_name):
1954 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1955 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1956 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1957 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1958 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1959 (last_show_tip_args): Now static.
1960 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1961 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1962 (x_screen_planes): Remove; unused.
1963 * dispextern.h (x_screen_planes): Remove decl.
1964
5bf46f05
PE
1965 * dispnew.c: Make symbols static if they're not exported.
1966 * dispextern.h (redraw_garbaged_frames, scrolling):
1967 (increment_row_positions): Remove.
1968 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1969 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1970 Now static.
1971 (redraw_garbaged_frames): Remove; unused.
1972
435f4c28
PE
1973 * xfaces.c: Make symbols static if they're not exported.
1974 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1975 Remove decls.
1976 * xterm.h (defined_color): Remove decls.
1977 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1978 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1979 (menu_face_changed_default, defined_color, free_realized_face):
1980 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1981 (ascii_face_of_lisp_face): Remove; unused.
1982
8524aef3
PE
1983 * xdisp.c: Make symbols static if they're not exported.
1984 * dispextern.h (scratch_glyph_row, window_box_edges):
1985 (glyph_to_pixel_coords, set_cursor_from_row):
1986 (get_next_display_element, set_iterator_to_next):
1987 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1988 (show_mouse_face): Remove decls
1989 * frame.h (message_buf_print): Likewise.
1990 * lisp.h (pop_message, set_message, check_point_in_composition):
1991 Likewise.
1992 * xterm.h (set_vertical_scroll_bar): Likewise.
1993 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1994 (message_buf_print, scratch_glyph_row, displayed_buffer):
1995 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1996 (get_next_display_element, show_mouse_face, window_box_edges):
1997 (frame_to_window_pixel_xy, check_point_in_composition):
1998 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1999 (glyph_to_pixel_coords): Remove; unused.
2000
16390cd2
PE
2001 * dired.c (file_name_completion): Now static.
2002
2003 * dbusbind.c (xd_in_read_queued_messages): Now static.
2004
a25f4dfa
PE
2005 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2006 * data.c (circular_list_error): Remove.
2007
14a9c8df
PE
2008 * commands.h (last_point_position, last_point_position_buffer):
2009 (last_point_position_window): Remove decls.
2010 * keyboard.c: Make these variables static.
2011
04f2d78b
CB
2012 * coding.h (coding, code_convert_region, encode_coding_gap):
2013 Remove decls.
74ab6df5
PE
2014 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2015 (iso_code_class, detect_coding, code_convert_region): Now static.
2016 (encode_coding_gap): Remove; unused.
2017
38dfbee1
PE
2018 * chartab.c (chartab_chars, chartab_bits): Now static.
2019
a2cb4e63
PE
2020 * charset.h (charset_iso_8859_1): Remove decl.
2021 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2022 Now static.
2023
127198fd
PE
2024 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2025 * ccl.c (Vccl_program_table): Now static.
2026 (check_ccl_update): Remove; unused.
2027
d85b608f
PE
2028 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2029 * category.h: ... from here.
2030 * category.c (check_category_table, set_category_set): Now static.
2031
31cd66f3
PE
2032 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2033 * lisp.h: Remove these decls.
2034
c358e587
PE
2035 * buffer.c (buffer_count): Remove unused var.
2036
e78aecca
PE
2037 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2038 so that it's not optimized away.
2039 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2040 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2041 exported only to the debugger.
2042
e192d7d3 2043 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2044 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2045
92470028
PE
2046 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2047 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2048 was inaccessible from Lisp.
2049 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2050 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2051
244ed907
PE
2052 alloc.c: Import and export fewer symbols, and remove unused items.
2053 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2054 is defined.
2055 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2056 it's not optimized away by whole-program optimization.
2057 (message_enable_multibyte, free_misc): Remove.
2058 (catchlist, handlerlist, mark_backtrace):
2059 Declare only if BYTE_MARK_STACK.
2060 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2061 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2062 (message_enable_multibyte): Remove decl.
2063 (free_misc, interval_free_list, float_block, float_block_index):
2064 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2065 (cons_free_list, last_marked_index):
2066 Now static.
2067 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2068 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2069 (mark_backtrace): Define only if BYTE_MARK_STACK.
2070 * xdisp.c (message_enable_multibyte): Now static.
2071
61c2b50e 2072 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2073 This makes it easier for human readers (and static analyzers)
2074 to see whether these variables are used from other modules.
2075 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2076 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2077 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2078 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2079 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2080 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2081 * xmenu.c, xselect.c:
2082 Declare Q* vars static if they are not used in other modules.
2083 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2084 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2085 Remove decls of unexported vars.
2086 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2087
95c82688
PE
2088 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2089
16a97296
PE
2090 Make Emacs functions such as Fatom 'static' by default.
2091 This makes it easier for human readers (and static analyzers)
2092 to see whether these functions can be called from other modules.
2093 DEFUN now defines a static function. To make the function external
2094 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2095 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2096 (Finit_image_library):
16a97296
PE
2097 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2098 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2099 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2100 Remove decls, since these functions are now static.
2101 (Funintern, Fget_internal_run_time): New decls, since these functions
2102 were already external.
95c82688 2103
16a97296
PE
2104 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2105 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2106 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2107 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2108 * keyboard.c, keymap.c, lread.c:
2109 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2110 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2111 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2112 Mark functions with DEFUE instead of DEFUN,
2113 if they are used in other modules.
2114 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2115 decls for now-static functions.
2116 * buffer.h (Fdelete_overlay): Remove decl.
2117 * callproc.c (Fgetenv_internal): Mark as internal.
2118 * composite.c (Fremove_list_of_text_properties): Remove decl.
2119 (Fcomposition_get_gstring): New forward static decl.
2120 * composite.h (Fcomposite_get_gstring): Remove decl.
2121 * dired.c (Ffile_attributes): New forward static decl.
2122 * doc.c (Fdocumntation_property): New forward static decl.
2123 * eval.c (Ffetch_bytecode): New forward static decl.
2124 (Funintern): Remove extern decl; now in .h file where it belongs.
2125 * fileio.c (Fmake_symbolic_link): New forward static decl.
2126 * image.c (Finit_image_library): New forward static decl.
2127 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2128 * intervals.h (Fprevious_property_change):
2129 (Fremove_list_of_text_properties): Remove decls.
2130 * keyboard.c (Fthis_command_keys): Remove decl.
2131 (Fcommand_execute): New forward static decl.
2132 * keymap.c (Flookup_key): New forward static decl.
2133 (Fcopy_keymap): Now static.
2134 * keymap.h (Flookup_key): Remove decl.
2135 * process.c (Fget_process): New forward static decl.
2136 (Fprocess_datagram_address): Mark as internal.
2137 * syntax.c (Fsyntax_table_p): New forward static decl.
2138 (skip_chars): Remove duplicate decl.
2139 * textprop.c (Fprevious_property_change): New forward static decl.
2140 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2141 Now internal.
2142 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2143 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2144
785bbd42
PE
2145 * editfns.c (Fformat): Remove unreachable code.
2146
8b913b57
AS
21472011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2148
2149 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2150 change. (Bug#8496)
2151
a6744a35
EZ
21522011-04-13 Eli Zaretskii <eliz@gnu.org>
2153
2154 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2155 when at ZV. (Bug#8487)
2156
e7974947
AS
21572011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2158
baad03f0
AS
2159 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2160 (Bug#8437)
2161 * keyboard.c (parse_tool_bar_item): Likewise.
2162 * sound.c (sound_cleanup, alsa_close): Likewise.
2163 * termcap.c (tgetent): Likewise.
2164 * xfns.c (x_default_font_parameter): Likewise.
2165 * xsettings.c (read_and_apply_settings): Likewise.
2166
e7974947
AS
2167 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2168 (overrun_check_free): Protoize.
2169
28272684
PE
21702011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2171
2172 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2173 since callers should never pass a negative size.
2174 Change the signature to match that of plain 'read' and 'write'; see
2175 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2176 * lisp.h: Update prototypes of emacs_write and emacs_read.
2177
11997c76
EZ
21782011-04-11 Eli Zaretskii <eliz@gnu.org>
2179
2180 * xdisp.c (redisplay_window): Don't try to determine the character
2181 position of the scroll margin if the window start point w->startp
e896f03c 2182 is outside the buffer's accessible region. (Bug#8468)
11997c76 2183
8a2cbd72
EZ
21842011-04-10 Eli Zaretskii <eliz@gnu.org>
2185
2186 Fix write-region and its subroutines for buffers > 2GB.
2187 * fileio.c (a_write, e_write): Modify declaration of arguments and
2188 local variables to support buffers larger than 2GB.
2189 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2190
2191 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2192 argument, local variables, and return value.
2193
2194 * lisp.h: Update prototypes of emacs_write and emacs_read.
2195
2196 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2197
4073e537 21982011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2199
1ebfdcb6
PE
2200 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2201
b2ded58d
PE
2202 Fix more problems found by GCC 4.6.0's static checks.
2203
7d66342c
PE
2204 * xdisp.c (vmessage): Use a better test for character truncation.
2205
bbf47d44
PE
2206 * charset.c (load_charset_map): <, not <=, for optimization,
2207 and to avoid potential problems with integer overflow.
9248994d 2208 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2209 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2210 * editfns.c (Fformat): Likewise.
1e69125e 2211 * syntax.c (skip_chars): Likewise.
3befa583 2212
e3019616
PE
2213 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2214 This also lets GCC 4.6.0 generate slightly better loop code.
2215
becfa255
PE
2216 * callint.c (Fcall_interactively): <, not <=, for optimization.
2217 (Fcall_interactively): Count the number of arguments produced,
2218 not the number of arguments given. This is simpler and lets GCC
2219 4.6.0 generate slightly better code.
2220
dae0cd48
PE
2221 * ftfont.c: Distingish more carefully between FcChar8 and char.
2222 The previous code passed unsigned char * to a functions like
2223 strlen and xstrcasecmp that expect char *, which does not
2224 conform to the C standard.
2225 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2226 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2227 char * when the C standard requires it.
2228
76032d70
PE
2229 * keyboard.c (read_char): Remove unused var.
2230
eb3f1cc8
PE
2231 * eval.c: Port to Windows vsnprintf (Bug#8435).
2232 Include <limits.h>.
2233 (SIZE_MAX): Define if the headers do not.
2234 (verror): Do not give up if vsnprintf returns a negative count.
2235 Instead, grow the buffer. This ports to Windows vsnprintf, which
2236 does not conform to C99. Problem reported by Eli Zaretskii.
2237 Also, simplify the allocation scheme, by avoiding the need for
2238 calling realloc, and removing the ALLOCATED variable.
2239
70476b54
PE
2240 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2241
12020a9e
PE
2242 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2243 But keep the doprint source code for now, as we might revamp it
2244 and use it again (Bug#8435).
ea6c7ae6
PE
2245 * lisp.h (doprnt): Remove.
2246 * Makefile.in (base_obj): Remove doprnt.o.
2247 * deps.mk (doprnt.o): Remove.
2248
5fdb398c
PE
2249 error: Print 32- and 64-bit integers portably (Bug#8435).
2250 Without this change, on typical 64-bit hosts error ("...%d...", N)
2251 was used to print both 32- and 64-bit integers N, which relied on
2252 undefined behavior.
2253 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2254 New macro.
2255 * lisp.h (error, verror): Mark as printf-like functions.
2256 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2257 Report overflow in size calculations when allocating printf buffer.
2258 Do not truncate output string at its first null byte.
2259 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2260 Truncate the output at a character boundary, since vsnprintf does not
2261 do that.
2262 * charset.c (check_iso_charset_parameter): Convert internal
2263 character to string before calling 'error', since %c now has the
2264 printf meaning.
2265 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2266 overflow when computing char to be passed to 'error'. Do not
2267 pass Lisp_Object to 'error'; pass the integer instead.
2268 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2269 formatted with plain %d.
2270
b189fa66
PE
2271 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2272
bff87ef0
PE
2273 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2274
7e2cac20
PE
2275 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2276
ce4d90b5
PE
2277 * xterm.c (x_catch_errors): Remove duplicate declaration.
2278
266c9547
PE
2279 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2280
79c49ad2
PE
2281 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2282
368f4090
JM
22832011-04-10 Jim Meyering <meyering@redhat.com>
2284
2285 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2286 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2287 return ssize_t not "int", and use size_t as the buffer length.
2288 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2289 * gnutls.h: Update declarations.
2290 * process.c (read_process_output): Use ssize_t, to match.
2291 (send_process): Likewise.
2292
a32d4040
CY
22932011-04-09 Chong Yidong <cyd@stupidchicken.com>
2294
2295 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2296
8546720e 22972011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2298
04f2d78b
CB
2299 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2300 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2301
8546720e
GM
2302 * xterm.c (handle_one_xevent):
2303 * xmenu.c (create_and_show_popup_menu):
2304 * xselect.c (x_decline_selection_request)
2305 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2306
0a2f5c1a 23072011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2308
2309 Fix some uses of `int' instead of EMACS_INT.
2310 * search.c (string_match_1, fast_string_match)
2311 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2312 (scan_buffer, find_next_newline_no_quit)
2313 (find_before_next_newline, search_command, Freplace_match)
2314 (Fmatch_data): Make some `int' variables be EMACS_INT.
2315
2316 * xdisp.c (display_count_lines): 3rd argument and return value now
2317 EMACS_INT. All callers changed.
2318 (pint2hrstr): Last argument is now EMACS_INT.
2319
2320 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2321 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2322 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2323 (decode_coding_utf_16, decode_coding_emacs_mule)
2324 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2325 (decode_coding_ccl, decode_coding_charset)
2326 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2327 (decode_coding_iso_2022, decode_coding_emacs_mule)
2328 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2329 <char_offset, last_offset>: Declare EMACS_INT.
2330 (encode_coding_utf_8, encode_coding_utf_16)
2331 (encode_coding_emacs_mule, encode_invocation_designation)
2332 (encode_designation_at_bol, encode_coding_iso_2022)
2333 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2334 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2335 Declare EMACS_INT.
2336 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2337 (encode_invocation_designation): Last argument P_NCHARS is now
2338 EMACS_INT.
2339 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2340 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2341
2342 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2343 All users changed.
2344
2345 * ccl.c (Fccl_execute_on_string): Declare some variables
2346 EMACS_INT.
2347
8546720e 23482011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2349
2350 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2351
4e19a977
CS
23522011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2353
2354 * process.c (Fformat_network_address): Doc fix.
2355
87302331
R
23562011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2357
2358 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2359
cbb59342
CY
23602011-04-08 Chong Yidong <cyd@stupidchicken.com>
2361
2362 * keyboard.c (read_char): Call Lisp function help-form-show,
2363 instead of using internal_with_output_to_temp_buffer.
2364 (Qhelp_form_show): New var.
e0d38eeb 2365 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2366
2367 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2368
2369 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2370
e67a13ab
CY
23712011-04-06 Chong Yidong <cyd@stupidchicken.com>
2372
04f2d78b
CB
2373 * process.c (Flist_processes): Remove to Lisp.
2374 (list_processes_1): Delete.
e67a13ab 2375
973f782d
EZ
23762011-04-06 Eli Zaretskii <eliz@gnu.org>
2377
7c106b1e
EZ
2378 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2379
973f782d
EZ
2380 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2381
41cf7d1a 23822011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2383
ca23cc88
PE
2384 Fix more problems found by GCC 4.6.0's static checks.
2385
f390e2d5
PE
2386 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2387
42eea0d0
PE
2388 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2389
b69769da 2390 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2391
f9541e84
PE
2392 * xdisp.c (vmessage): Mark as a printf-like function.
2393
13841b55
PE
2394 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2395
c136c10f
PE
2396 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2397
5e2d4a30
PE
2398 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2399 printf-like functions.
2400 (tiff_load): Add casts to remove these marks before passing them
2401 to system-supplied API.
2402
583f48b9
PE
2403 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2404
b25d760e
PE
2405 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2406 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2407 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2408 directly, rather than having caller test rule sign. This avoids
2409 some unnecessary tests.
2410 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2411 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2412 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2413
bc7b6697 2414 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2415 (xfont_open): Avoid unnecessary tests.
bc7b6697 2416
27ccc379
PE
2417 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2418
dcd5c89a
PE
2419 * composite.h, composite.c (composition_gstring_put_cache):
2420 Use EMACS_INT, not int, for length.
2421
b13a45c6
PE
2422 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2423 breaking out part of COMPOSITION_DECODE_RULE.
2424 (COMPOSITION_DECODE_RULE): Use it.
2425 * composite.c (get_composition_id): Remove unused local vars,
2426 by using the new macro.
2427
1e792e4d
PE
2428 * textprop.c (set_text_properties_1): Change while to do-while,
2429 since the condition is always true at first.
2430
dc6c6455 2431 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2432 (interval_deletion_adjustment): Return unsigned value.
2433 All uses changed.
dc6c6455 2434
aba7731a
PE
2435 * process.c (list_processes_1, create_pty, read_process_output):
2436 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2437 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2438 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2439 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2440 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2441
fdfc4bf3
PE
2442 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2443
fca8fe46 2444 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2445 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2446
06a0259a 2447 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2448 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2449 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2450
e7b9e80f
PE
2451 * print.c (print_error_message): Avoid int overflow.
2452
56201685
PE
2453 * font.c (font_list_entities): Redo for clarity,
2454 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2455
78834453 2456 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2457 (font_score): Avoid potential overflow in diff calculation.
78834453 2458
0bc0b309 2459 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2460 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2461
e610eaca
PE
2462 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2463
b895abce
PE
2464 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2465 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2466 can always succeed if overflow has undefined behavior.
2467
1f1d9321 2468 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2469 (wordify): Omit three unnecessary tests.
1f1d9321 2470
c59478bc
PE
2471 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2472 All callers changed. This avoids the need for an unused var.
2473
79b73827
PE
2474 * casefiddle.c (casify_region): Remove var that is set but not used.
2475
a4db5dfe
PE
2476 * dired.c (file_name_completion): Remove var that is set but not used.
2477
43aae36e
PE
2478 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2479
2a47c44d 2480 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2481 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2482
a37c69bf
PE
2483 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2484 Check for integer overflow on size calculations.
2485
328ab8e7
PE
2486 * buffer.c (Fprevious_overlay_change): Remove var that is set
2487 but not used.
2488
e5a2a5cb
PE
2489 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2490 Remove vars that are set but not used.
8d84a6eb 2491 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2492 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2493
a60e5f68
PE
2494 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2495
f661cb61 2496 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2497 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2498
f0397f5a
PE
2499 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2500 that are set but not used.
2501
8664db06 2502 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2503 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2504
6abdaa4a
PE
2505 * xselect.c (x_get_local_selection, x_handle_property_notify):
2506 Remove vars that are set but not used.
2507
0ce7538d 2508 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2509 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2510
9ae848fc
PE
2511 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2512 Remove var that is set but not used.
0b918413
PE
2513 (scroll_bar_windows_size): Now size_t, not int.
2514 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2515 Check for overflow.
9ae848fc 2516
a5a62657
PE
2517 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2518 (map_tty_color) [!defined MSDOS]: Likewise.
2519
5c5cdd39
PE
2520 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2521
66ebf983
PE
2522 * coding.c: Remove vars that are set but not used.
2523 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2524 All callers changed.
2525 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2526 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2527 (decode_coding_charset): Remove vars that are set but not used.
2528
1be4d761
PE
2529 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2530 that is set but not used.
2531
47553fa8
PE
2532 * print.c (print_object): Remove var that is set but not used.
2533
1f7196bf 2534 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2535 The gnulib version avoids calling malloc in the usual case,
2536 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2537 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2538 * filelock.c (current_lock_owner): Likewise.
2539 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2540 * sysdep.c: Include allocator.h, careadlinkat.h.
2541 (emacs_no_realloc_allocator): New static constant.
2542 (emacs_readlink): New function.
fdb61804
PE
2543 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2544 ../lib/careadlinkat.h.
d1fdcab7 2545
f84c17c7
SM
25462011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2547
2548 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2549 first non-nil return value).
2550
ef3862ad
JD
25512011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2552
2553 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2554 if not defined (Bug#8403).
2555
376a7006
JB
25562011-04-02 Juanma Barranquero <lekktu@gmail.com>
2557
2558 * xdisp.c (display_count_lines): Remove parameter `start',
2559 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2560 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2561 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2562 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2563 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2564 and thereabouts. All callers changed.
2565 (get_per_char_metric): Remove parameter `f', unused since
2566 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2567
6ca3801d
JM
25682011-04-02 Jim Meyering <meyering@redhat.com>
2569
2570 do not dereference NULL upon failed strdup
2571 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2572 (ns_get_family): Likewise.
2573
d8e2b5ba
JB
25742011-04-02 Juanma Barranquero <lekktu@gmail.com>
2575
2576 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2577
8c74fcbd
JD
25782011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2579
2580 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2581 later (Bug#8403).
2582
7200d79c
SM
25832011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2584
03408648 2585 Add lexical binding.
7200d79c 2586
03408648
SM
2587 * window.c (Ftemp_output_buffer_show): New fun.
2588 (Fsave_window_excursion):
2589 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2590
2591 * lread.c (lisp_file_lexically_bound_p): New function.
2592 (Fload): Bind Qlexical_binding.
2593 (readevalloop): Remove `evalfun' arg.
2594 Bind Qinternal_interpreter_environment.
2595 (Feval_buffer): Bind Qlexical_binding.
2596 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2597 Mark as dynamic.
2598 (syms_of_lread): Declare `lexical-binding'.
2599
2600 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2601
2602 * keyboard.c (eval_dyn): New fun.
2603 (menu_item_eval_property): Use it.
ca105506
SM
2604
2605 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2606
03408648
SM
2607 * fns.c (concat, mapcar1): Accept byte-code-functions.
2608
2609 * eval.c (Fsetq): Handle lexical vars.
2610 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2611 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2612 (FletX, Flet): Obey lexical binding.
2613 (Fcommandp): Handle closures.
2614 (Feval): New `lexical' arg.
2615 (eval_sub): New function extracted from Feval. Use it almost
2616 everywhere where Feval was used. Look up vars in lexical env.
2617 Handle closures.
2618 (Ffunctionp): Move from subr.el.
2619 (Ffuncall): Handle closures.
2620 (apply_lambda): Remove `eval_flags'.
2621 (funcall_lambda): Handle closures and new byte-code-functions.
2622 (Fspecial_variable_p): New function.
2623 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2624 but without exporting it to Lisp.
23aba0ea 2625
23aba0ea 2626 * doc.c (Fdocumentation, store_function_docstring):
03408648 2627 * data.c (Finteractive_form): Handle closures.
23aba0ea 2628
03408648
SM
2629 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2630 interactive spec.
ba83908c 2631
04f2d78b
CB
2632 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2633 New byte-codes.
03408648
SM
2634 (exec_byte_code): New function extracted from Fbyte_code to handle new
2635 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2636
03408648 2637 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2638
03408648 2639 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2640
e2abce01
JB
26412011-03-31 Juanma Barranquero <lekktu@gmail.com>
2642
2643 * xdisp.c (redisplay_internal): Fix prototype.
2644
63696a73 26452011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2646
63696a73 2647 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2648 (try_scrolling): Use it when setting scroll_limit.
2649 Limit scrolling to 100 screen lines.
63696a73
EZ
2650 (redisplay_window): Even when falling back on "recentering",
2651 position point in the window according to scroll-conservatively,
2652 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2653
2654 (try_scrolling): When point is above the window, allow searching
2655 as far as scroll_max, or one screenful, to compute vertical
2656 distance from PT to the scroll margin position. This prevents
2657 try_scrolling from unnecessarily failing when
2658 scroll-conservatively is set to a value slightly larger than the
2659 window height. Clean up the case of PT below the margin at bottom
2660 of window: scroll_max can no longer be INT_MAX. When aggressive
2661 scrolling is in use, don't let point enter the opposite scroll
2662 margin as result of the scroll.
2663 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2664 threshold of 100 lines for never-recentering scrolling.
2665
e4cc2dfc
JB
26662011-03-31 Juanma Barranquero <lekktu@gmail.com>
2667
2668 * dispextern.h (move_it_by_lines):
2669 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2670 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2671 (message_log_check_duplicate): Remove parameters `prev_bol' and
2672 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2673 (redisplay_internal): Remove parameter `preserve_echo_area',
2674 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2675
2676 * indent.c (Fvertical_motion):
2677 * window.c (window_scroll_pixel_based, Frecenter):
2678 Don't pass `need_y_p' to `move_it_by_lines'.
2679
1c470562
SM
26802011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2681
44f230aa
SM
2682 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2683 steal a few bits to be more compact.
2684 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2685 Remove unneeded casts.
2686
1c470562
SM
2687 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2688
888adce9
ZK
26892011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2690
2691 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2692 binding" message (bug#7967).
2693
f838ed7b
PE
26942011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2695
77861b95
PE
2696 Fix more problems found by GCC 4.6.0's static checks.
2697
de6dbc14
PE
2698 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2699 Remove unused local var.
2700
f838ed7b
PE
2701 * editfns.c (Fmessage_box): Remove unused local var.
2702
792c7b2b
PE
2703 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2704 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2705 Omit unused local vars.
c499e557 2706 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2707 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2708 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2709 Omit unused local var.
2710
ba0165e1
PE
2711 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2712 Don't assume string length fits in int.
32ad8845 2713 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2714 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2715
3c59b4c9
PE
2716 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2717 instead of alloca (Bug#8344).
2718
a3eed478 2719 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2720 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2721
eb4d412d
PE
2722 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2723
1658b401
PE
2724 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2725 concerns.
2726
2727 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2728
2729 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2730
9a2c6e05
PE
2731 * keyboard.c (syms_of_keyboard): Use the same style as later
2732 in this function when indexing through an array. This also
2733 works around GCC bug 48267.
2734
03d0a109
PE
2735 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2736
44f730c8
PE
2737 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2738
fe75f926
PE
2739 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2740 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2741
ffa8c828
PE
2742 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2743 This avoids undefined behavior on integer overflow, and is a bit
2744 more convenient anyway since it is compared to a size_t variable.
2745
c5101a77
PE
2746 Variadic C functions now count arguments with size_t, not int.
2747 This avoids an unnecessary limitation on 64-bit machines, which
2748 caused (substring ...) to crash on large vectors (Bug#8344).
2749 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2750 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2751 All variadic functions and their callers changed accordingly.
c5101a77
PE
2752 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2753 * data.c (arith_driver, float_arith_driver): Likewise.
2754 * editfns.c (general_insert_function): Likewise.
2755 * eval.c (struct backtrace.nargs, interactive_p)
2756 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2757 (funcall_lambda, mark_backtrace): Likewise.
2758 * fns.c (concat): Likewise.
2759 * frame.c (x_set_frame_parameters): Likewise.
2760 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2761 0 if not found, not -1. All callers changed.
2762
dd3f25f7
PE
2763 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2764 (stack_copy_size): Now size_t, not int.
2765 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2766
461c2ab9
JB
27672011-03-28 Juanma Barranquero <lekktu@gmail.com>
2768
2769 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2770 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2771 All callers changed.
2772
2773 * lisp.h (multibyte_char_to_unibyte):
2774 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2775 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2776 * character.h (CHAR_TO_BYTE8):
2777 * cmds.c (internal_self_insert):
2778 * editfns.c (general_insert_function):
2779 * keymap.c (push_key_description):
2780 * search.c (Freplace_match):
2781 * xdisp.c (message_dolog, set_message_1): All callers changed.
2782
f6d62986
SM
27832011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2784
2785 * keyboard.c (safe_run_hook_funcall): New function.
2786 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2787 don't set the hook to nil, but remove the offending function instead.
2788 (Qcommand_hook_internal): Remove, unused.
2789 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2790 Vcommand_hook_internal.
2791
2792 * eval.c (enum run_hooks_condition): Remove.
2793 (funcall_nil, funcall_not): New functions.
2794 (run_hook_with_args): Call each function through a `funcall' argument.
2795 Remove `cond' argument, now redundant.
2796 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2797 (Frun_hook_with_args_until_failure): Adjust accordingly.
2798 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2799
1db5b1ad
JB
28002011-03-28 Juanma Barranquero <lekktu@gmail.com>
2801
2802 * dispextern.h (string_buffer_position): Remove declaration.
2803
2804 * print.c (strout): Remove parameter `multibyte', unused since
2805 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2806
2807 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2808 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2809 All callers changed.
2810
2811 * w32.c (_wsa_errlist): Use braces for struct initializers.
2812
2813 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2814 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2815 All callers changed.
2816 (string_buffer_position): Likewise. Also, make static (it's never
2817 used outside xdisp.c).
2818 (cursor_row_p): Remove parameter `w', unused since
2819 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2820 (decode_mode_spec): Remove parameter `precision', introduced during
2821 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2822 All callers changed.
2823
5ffb62aa
JD
28242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2825
2826 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2827
461c2ab9 28282011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2829
2830 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2831 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2832 (ns_update_auto_hide_menu_bar): New functions.
2833 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2834 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2835 ns_constrain_all_frames.
2836 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2837 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2838
5c380ffb
JD
28392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2840
2841 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2842
9af30bdf
GM
28432011-03-27 Glenn Morris <rgm@gnu.org>
2844
2845 * syssignal.h: Replace RETSIGTYPE with void.
2846 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2847 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2848 Replace SIGTYPE with void everywhere.
2849 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2850 * s/template.h (SIGTYPE): Remove commented out definition.
2851
e2abce01
JB
28522011-03-26 Eli Zaretskii <eliz@gnu.org>
2853
2854 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2855 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2856
f868cd8a
JB
28572011-03-26 Juanma Barranquero <lekktu@gmail.com>
2858
59eb0929
JB
2859 * w32.c (read_unc_volume): Use parameter `henum', instead of
2860 global variable `wget_enum_handle'.
2861
2862 * keymap.c (describe_vector): Remove parameters `indices' and
2863 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2864 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2865
f868cd8a
JB
2866 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2867
2868 * keyboard.c (timer_check): Remove parameter `do_it_now',
2869 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2870 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2871 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2872
2873 * keyboard.c (read_char):
2874 * w32menu.c (w32_menu_display_help):
2875 * xmenu.c (show_help_event, menu_help_callback):
2876 Adjust calls to `show_help_echo'.
2877
2878 * gtkutil.c (xg_maybe_add_timer):
2879 * keyboard.c (readable_events):
2880 * process.c (wait_reading_process_output):
2881 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2882
2883 * insdel.c (adjust_markers_gap_motion):
2884 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2885 (gap_left, gap_right): Don't call it.
2886
2ecf6fdb
CY
28872011-03-25 Chong Yidong <cyd@stupidchicken.com>
2888
2889 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2890 incurred during fontification.
2891
6b1f9ba4
JB
28922011-03-25 Juanma Barranquero <lekktu@gmail.com>
2893
2894 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2895 (DEFVAR_PER_BUFFER): Don't pass it.
2896
2897 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2898 (scrolling_window): Don't pass it.
2899
0f4a96b5
JB
29002011-03-25 Juanma Barranquero <lekktu@gmail.com>
2901
2902 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2903
2904 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2905 and `suffix'.
2906 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2907 of variables specific to SELinux and computation of `encoded_absname'.
2908
2909 * image.c (XPutPixel): Remove unused variable `height'.
2910
2911 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2912
2913 * unexw32.c (get_section_info): Remove unused variable `section'.
2914
2915 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2916 (system_process_attributes): Remove unused variable `sess'.
2917 (sys_read): Remove unused variable `err'.
2918
2919 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2920 (w32_wnd_proc): Remove unused variable `isdead'.
2921 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2922 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2923 (x_create_tip_frame): Remove unused variable `tem'.
2924
2925 * w32inevt.c (w32_console_read_socket):
2926 Remove unused variable `no_events'.
2927
2928 * w32term.c (x_draw_composite_glyph_string_foreground):
2929 Remove unused variable `width'.
2930
1149507c
JB
29312011-03-24 Juanma Barranquero <lekktu@gmail.com>
2932
2933 * w32term.c (x_set_glyph_string_clipping):
2934 Don't pass uninitialized region to CombineRgn.
2935
9c88f339
JB
29362011-03-23 Juanma Barranquero <lekktu@gmail.com>
2937
2938 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2939 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2940 (Fx_close_connection): Remove unused variable `i'.
2941
2942 * w32font.c (w32font_draw): Return number of glyphs.
2943 (w32font_open_internal): Remove unused variable `i'.
2944 (w32font_driver): Add missing initializer.
2945
2946 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2947 (fill_in_menu): Remove unused variable `items_added'.
2948
2949 * w32term.c (last_mouse_press_frame): Remove static global variable.
2950 (w32_clip_to_row): Remove unused variable `f'.
2951 (x_delete_terminal): Remove unused variable `i'.
2952
2953 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2954 (NOTHING): Remove unused static global variable.
2955 (uniscribe_check_otf): Remove unused variable `table'.
2956 (uniscribe_font_driver): Add missing initializers.
2957
dee091a3
JD
29582011-03-23 Julien Danjou <julien@danjou.info>
2959
2960 * term.c (Fsuspend_tty, Fresume_tty):
2961 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2962 * window.c (temp_output_buffer_show):
2963 * insdel.c (signal_before_change):
2964 * frame.c (Fhandle_switch_frame):
2965 * fileio.c (Fdo_auto_save):
2966 * emacs.c (Fkill_emacs):
2967 * editfns.c (save_excursion_restore):
2968 * cmds.c (internal_self_insert):
2969 * callint.c (Fcall_interactively):
2970 * buffer.c (Fkill_all_local_variables):
2971 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2972 Use Frun_hooks.
0f4a96b5 2973 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2974 unconditionnaly since it does the check itself.
2975
2c520ab5 29762011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2977
c9c49752
PE
2978 Fix more problems found by GCC 4.5.2's static checks.
2979
8abc3f12
PE
2980 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2981 the first time through the loop, since we know p0 < p1 then.
2982 This also avoids a gcc -Wstrict-overflow warning.
2983
a2d26660
PE
2984 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2985 leading to a memory leak, possible in functions like
2986 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2987 of objects (Bug#8318).
a2d26660 2988
916c72e9
PE
2989 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2990 that could (at least in theory) be that large.
2991
19ab8a18
PE
2992 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2993 This is less likely to overflow, and avoids undefined behavior if
2994 overflow does occur. All callers changed. Use strtoul to scan
2995 for the unsigned long integer.
b7cbbd6f
PE
2996 (pint2hrstr): Simplify and tune code slightly.
2997 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2998
f0641eff
PE
2999 * scroll.c (do_scrolling): Work around GCC bug 48228.
3000 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3001
7f650bb9
PE
3002 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3003 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3004 (validate_x_resource_name): Simplify count usage.
3005 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3006
37dd57d1
PE
3007 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3008 fail (Bug#8306).
81e56e61 3009
699979fc 3010 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3011
401bf9b4
PE
3012 * process.c (Fmake_network_process): Use socklen_t, not int,
3013 where POSIX says socklen_t is required in portable programs.
3014 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3015 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3016 (Fmake_network_process, server_accept_connection):
3017 (wait_reading_process_output, read_process_output):
3018 Likewise.
3019
b93aacde
PE
3020 * process.c: Rename or move locals to avoid shadowing.
3021 (list_processes_1, Fmake_network_process):
3022 (read_process_output_error_handler, exec_sentinel_error_handler):
3023 Rename or move locals.
4dc343ee 3024 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3025 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3026 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3027 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3028 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3029
af8a867c 3030 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3031 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3032 Include tparam.h instead, since it declares them.
af8a867c
PE
3033 * cm.h (PC): Remove extern decl; tparam.h now does this.
3034 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3035 * terminfo.c: Include tparam.h, to check interfaces.
3036 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3037 (tparam): Adjust signature to match interface in tparam.h;
3038 this removes some undefined behavior. Check that outstring and len
3039 are zero, which they always are with Emacs.
3040 * tparam.h (PC, BC, UP): New extern decls.
3041
0248044d 3042 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3043 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3044
8ff096c1 3045 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3046 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3047 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3048 (ftfont_list): Remove unused local.
49eaafba
PE
3049 (get_adstyle_property, ftfont_pattern_entity):
3050 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3051 Rename locals to avoid shadowing.
8ff096c1 3052
e2be39f6
PE
3053 * xfont.c (xfont_list_family): Mark var as initialized.
3054
c9735e30
PE
3055 * xml.c (make_dom): Now static.
3056
8f5201ae
PE
3057 * composite.c (composition_compute_stop_pos): Rename local to
3058 avoid shadowing.
b246f932
PE
3059 (composition_reseat_it): Remove unused locals.
3060 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3061 (composition_update_it): Mark var as initialized.
11b61122
PE
3062 (find_automatic_composition): Mark vars as initialized,
3063 with a FIXME (Bug#8290).
8f5201ae 3064
760fbc2c
PE
3065 character.h: Rename locals to avoid shadowing.
3066 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3067 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3068 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3069 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3070 to avoid shadowing.
3071
ff08eb85
PE
3072 * textprop.c (property_change_between_p): Remove; unused.
3073
fc7bf025
PE
3074 * intervals.c (interval_start_pos): Now static.
3075
235d7abc
PE
3076 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3077
44f230aa
SM
3078 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3079 Rename locals to avoid shadowing.
3e7d6594 3080
50060332
PE
3081 * sound.c (wav_play, au_play, Fplay_sound_internal):
3082 Fix pointer signedness.
d01f234b 3083 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3084 (wav_play): Initialize a variable to 0, to prevent undefined
3085 behavior (Bug#8278).
50060332 3086
c4fc4e30
PE
3087 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3088
918436ed
PE
3089 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3090
c939f91b
PE
3091 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3092 clobbering (Bug#8298).
b9c7f648
PE
3093 * sysdep.c (sys_subshell): Likewise.
3094 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3095
6bd8c144
PE
3096 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3097 This should get cleaned up, so that child_setup has the
3098 same signature on all platforms.
3099
7710357c 3100 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3101 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3102
c59da222
CY
31032011-03-22 Chong Yidong <cyd@stupidchicken.com>
3104
3105 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3106 not to be necessary, and produces flickering.
3107
66b87493
GM
31082011-03-20 Glenn Morris <rgm@gnu.org>
3109
3110 * config.in: Remove file.
3111
45b6f6d5
JB
31122011-03-20 Juanma Barranquero <lekktu@gmail.com>
3113
3114 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3115 are now in src/globals.h.
3116 (syms_of_minibuf): Remove spurious & from previous change.
3117
3ec03f7e
LL
31182011-03-20 Leo <sdl.web@gmail.com>
3119
3120 * minibuf.c (completing-read-function): New variable.
3121 (completing-read-default): Rename from completing-read.
3122 (completing-read): Call completing-read-function.
3123
b14e3e21
CY
31242011-03-19 Juanma Barranquero <lekktu@gmail.com>
3125
3126 * xfaces.c (Fx_load_color_file):
3127 Read color file from absolute filename (bug#8250).
3128
f2b726e6
JB
31292011-03-19 Juanma Barranquero <lekktu@gmail.com>
3130
3131 * makefile.w32-in: Update dependencies.
3132
09f6ff02
EZ
31332011-03-17 Eli Zaretskii <eliz@gnu.org>
3134
3135 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3136
29a6015a
PE
31372011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3138
a3a6c54e
PE
3139 Fix more problems found by GCC 4.5.2's static checks.
3140
b766f867
PE
3141 * process.c (make_serial_process_unwind, send_process_trap):
3142 (sigchld_handler): Now static.
3143
be02381c
PE
3144 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3145 That way, the code declares only the vars that it needs.
3146 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3147 * s/cygwin.h (PTY_ITERATION): Likewise.
3148 * s/darwin.h (PTY_ITERATION): Likewise.
3149 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3150
57048744
PE
3151 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3152 * process.c (allocate_pty): Don't declare stb unless it's needed.
3153
7914961c 3154 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3155 (CONSTANTLIM): Remove; unused.
3156 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3157 Define only if needed.
7914961c 3158
b3967b18
PE
3159 * unexelf.c (unexec): Name an expression,
3160 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3161 Use a different way to cause a compilation error if anyone uses
3162 n rather than nn, a way that does not involve shadowing.
73366a00 3163 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3164
29a6015a
PE
3165 * deps.mk (unexalpha.o): Remove; unused.
3166
43cfc33e 3167 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3168 * unexec.h: New file.
ce701a33
PE
3169 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3170 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3171 Depend on unexec.h.
3172 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3173 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3174 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3175 Change as necessary to match prototype in unexec.h.
ce701a33 3176
01f44d5a
PE
3177 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3178 shadowing.
4f63c6bb 3179 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3180
a6670b0b
PE
3181 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3182 Rename locals to avoid shadowing.
3183
cef2010d 3184 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3185 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3186
d4d7173a
PE
3187 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3188
f08b802a
PE
3189 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3190 warning when compiling print.c.
3191
3ddb0639
PE
3192 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3193 instead of using an uninitialized var.
5ad03b97 3194 (font_sort_entities): Mark var as initialized.
3ddb0639 3195
170a2692
PE
3196 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3197
e663c700
PE
3198 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3199 pointers to constants.
89bc529a 3200 (font_parse_fcname): Remove unused vars.
7b81e2d0 3201 (font_delete_unmatched): Now static.
ea838e10 3202 (font_get_spec): Remove; unused.
13a547c6
PE
3203 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3204 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3205 Rename or move locals to avoid shadowing.
e663c700 3206
2a80c887 3207 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3208 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3209
1384fa33 3210 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3211 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3212
8b2c52e9
PE
3213 * alloc.c (mark_backtrace): Move decl from here ...
3214 * lisp.h: ... to here, so that it can be checked.
3215
475545b5 3216 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3217 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3218 (lisp_indirect_variable): Name an expression,
3219 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3220 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3221
b1349114 3222 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3223 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3224 Use const pointer when appropriate.
b1349114 3225
a2928364
PE
3226 * lisp.h (get_system_name, get_operating_system_release):
3227 Move decls here, to check interfaces.
3228 * process.c (get_operating_system_release): Move decl to lisp.h.
3229 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3230 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3231 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3232 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3233 (Fformat_time_string, Fencode_time, Finsert_char):
3234 (Ftranslate_region_internal, Fformat):
3235 Rename or remove local vars to avoid shadowing.
9710023e 3236 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3237
a415e694
PE
3238 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3239 avoid shadowing.
3240
8ef4622d
PE
3241 * lisp.h (eassert): Check that the argument compiles, even if
3242 ENABLE_CHECKING is not defined.
3243
946f9a5b
PE
3244 * data.c (Findirect_variable): Name an expression, to avoid
3245 gcc -Wbad-function-cast warning.
112396d6 3246 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3247 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3248 (Fmake_variable_buffer_local, Fmake_local_variable):
3249 Mark variables as initialized.
52746918 3250 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3251
e5aab7e7 3252 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3253 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3254 Rename locals to avoid shadowing.
dff45157
PE
3255 (mark_stack): Move local variables into the #ifdef region where
3256 they're used.
7bc26fdb
PE
3257 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3258 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3259 needed otherwise.
3260 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3261 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3262 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3263
e5aab7e7
PE
3264 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3265 avoids undefined behavior in theory.
3266
4da60324
PE
3267 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3268
88043301
PE
3269 Use functions, not macros, for up- and down-casing (Bug#8254).
3270 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3271 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3272 to use the following functions instead of these macros.
3273 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3274 EMACS_INT, since callers assume the returned value fits in int.
3275 (upcase1): Likewise, for UPCASE_TABLE.
3276 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3277 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3278 the race-condition problem in the old DOWNCASE.
88043301 3279
19ed5445
PE
3280 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3281 Rename locals to avoid shadowing.
3282 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3283 (regex_compile, re_search_2, re_match_2_internal):
3284 Remove unused local vars.
952db0d7
PE
3285 (FREE_VAR): Rewrite so as not to use empty "else",
3286 which gcc can warn about.
da053e48 3287 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3288 (RETALLOC_IF): Define only if needed.
3289 (WORDCHAR_P): Likewise. This one is never needed, but is used
3290 only in a comment talking about a compiler bug, so put inside
3291 the #if 0 of that comment.
3292 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3293 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3294 Remove; unused.
19ed5445 3295
1f3561e4 3296 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3297 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3298 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3299
ded6f8f7
PE
3300 * search.c (simple_search): Remove unused var.
3301
dbd37a95
PE
3302 * dired.c (compile_pattern): Move decl from here ...
3303 * lisp.h: ... to here, so that it can be checked.
3304 (struct re_registers): New forward decl.
3305
7e47afad
PE
3306 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3307
85f24f61
PE
3308 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3309 All uses changed.
3310 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3311 Rename locals to avoid shadowing.
5671df8f 3312 (Fvertical_motion): Mark locals as initialized.
85f24f61 3313
181aa2be 3314 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3315 (casify_region): Mark local as initialized.
181aa2be 3316
930d429c
PE
3317 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3318
7082eac6
PE
3319 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3320 New macros, so that the caller can use some names other than
3321 gcpro1, gcpro2, etc.
3322 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3323 of the new macros.
3324 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3325 argument, for consistency with GCPRO2_VAR, etc: it is now the
3326 prefix of the variable, not the variable itself. All uses
3327 changed.
38b2c076
PE
3328 * dired.c (directory_files_internal, file_name_completion):
3329 Rename locals to avoid shadowing.
3330
15206ed9
PE
3331 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3332 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3333 dired.c's scmp function, had undefined behavior.
3334 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3335 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3336 * buffer.h: ... to here, because these macros use current_buffer,
3337 and the new implementation with inline functions needs to have
3338 current_buffer in scope now, rather than later when the macros
3339 are used.
3340 (downcase, upcase1): New static inline functions.
3341 (DOWNCASE, UPCASE1): Reimplement using these functions.
3342 This avoids undefined behavior in expressions like
3343 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3344 from race conditions in accessing the global variables
3345 case_temp1 and case_temp2.
3346 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3347 * lisp.h (case_temp1, case_temp2): Remove their decls.
3348 * character.h (ASCII_CHAR_P): Move from here ...
3349 * lisp.h: ... to here, so that the inline functions mentioned
3350 above can use them.
3351
4a6bea26
PE
3352 * dired.c (directory_files_internal_unwind): Now static.
3353
f14b7e14
PE
3354 * fileio.c (file_name_as_directory, directory_file_name):
3355 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3356 Now static.
2893f146
PE
3357 (file_name_as_directory): Use const pointers when appropriate.
3358 (Fexpand_file_name): Likewise. In particular, newdir might
3359 point at constant storage, so make it a const pointer.
fd4ead52 3360 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3361 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3362 signedness issues.
f839df0c
PE
3363 (Fset_file_times, Finsert_file_contents, auto_save_error):
3364 Rename locals to avoid shadowing.
f14b7e14 3365
5716756e 3366 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3367 (Ftry_completion, Fall_completions): Rename or remove locals
3368 to avoid shadowing.
5716756e 3369
b4c3046a
PE
3370 * marker.c (bytepos_to_charpos): Remove; unused.
3371
b45db522
PE
3372 * lisp.h (verify_bytepos, count_markers): New decls,
3373 so that gcc does not warn that these functions aren't declared.
3374
85876d07
PE
3375 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3376 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3377 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3378 (copy_text): Remove unused local var.
85876d07 3379
03d78a21 3380 * filelock.c (within_one_second): Now static.
b3dd38ab 3381 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3382
5df8f01b
PE
3383 * buffer.c (fix_overlays_before): Mark locals as initialized.
3384 (fix_start_end_in_overlays): Likewise. This function should be
3385 simplified by using pointers-to-pointers, but that's a different
3386 matter.
b1d876f1 3387 (switch_to_buffer_1): Now static.
8f54f30a
PE
3388 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3389 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3390
a70072c9 3391 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3392 Fix pointer signedness issue.
edced198
PE
3393 (sys_subshell): Mark local as volatile if checking for lint,
3394 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3395 (MAXPATHLEN): Define only if needed.
a70072c9 3396
a0977c44
PE
3397 * process.c (serial_open, serial_configure): Move decls from here ...
3398 * systty.h: ... to here, so that they can be checked.
3399
a884fdcc
PE
3400 * fns.c (get_random, seed_random): Move extern decls from here ...
3401 * lisp.h: ... to here, so that they can be checked.
3402
604efe86 3403 * sysdep.c (reset_io): Now static.
b8950c94 3404 (wait_for_termination_signal): Remove; unused.
604efe86 3405
38fc62d9
PE
3406 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3407 (copy_keymap_item, append_key, push_text_char_description):
3408 Now static.
1004a21a 3409 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3410 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3411 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3412 (describe_map_tree):
3413 Rename locals to avoid shadowing.
38fc62d9 3414
2f2650da
PE
3415 * keyboard.c: Declare functions static if they are not used elsewhere.
3416 (echo_char, echo_dash, cmd_error, top_level_2):
3417 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3418 (read_char, kbd_buffer_get_event, make_lispy_position):
3419 (make_lispy_event, make_lispy_movement, apply_modifiers):
3420 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3421 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3422 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3423 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3424 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3425
a053e86c 3426 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3427 (mark_kboards): Move decl here ...
3428 * alloc.c (mark_kboards): ... from here.
a053e86c 3429
4752793e
PE
3430 * lisp.h (force_auto_save_soon): New decl.
3431
74f10ca7 3432 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3433 (DEFINE_DUMMY_FUNCTION): New macro.
3434 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3435 Use it.
c03cd23f
PE
3436 (main): Add casts to avoid warnings
3437 if GCC considers string literals to be constants.
74f10ca7 3438
022e70d4
PE
3439 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3440
59d6fe83
PE
3441 * dbusbind.c: Pointer signedness fixes.
3442 (xd_signature, xd_append_arg, xd_initialize):
3443 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3444 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3445 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3446 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3447
78320123
PE
3448 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3449 if GCC considers string literals to be constants.
49cebcca 3450 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3451
35ac2a97
SM
34522011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3453
fb103ca9
SM
3454 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3455 (print_preprocess, print_object): New macro to fix last change.
3456
35ac2a97
SM
3457 * print.c (print_preprocess): Don't forget font objects.
3458
62973b41
JB
34592011-03-16 Juanma Barranquero <lekktu@gmail.com>
3460
3461 * emacs.c (USAGE3): Doc fixes.
3462
0e48bb22
AS
34632011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3464
3465 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3466 structure.
3467
7684e57b
JB
34682011-03-14 Juanma Barranquero <lekktu@gmail.com>
3469
3470 * lisp.h (VWindow_system, Qfile_name_history):
3471 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3472 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3473 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3474
3475 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3476 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3477
3478 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3479 * w32console.c (detect_input_pending, read_input_pending)
3480 (encode_terminal_code):
3481 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3482 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3483 (w32_system_caret_y, Qfile_name_history):
3484 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3485 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3486 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3487 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3488 * w32proc.c (Qlocal, report_file_error):
3489 * w32term.c (Vwindow_system, updating_frame):
3490 * w32uniscribe.c (initialized, uniscribe_font_driver):
3491 Remove unneeded extern declarations.
3492
2aa46d6c
CY
34932011-03-14 Chong Yidong <cyd@stupidchicken.com>
3494
c96bbc66 3495 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3496
cffc6f3b
CY
34972011-03-13 Chong Yidong <cyd@stupidchicken.com>
3498
3499 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3500 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3501 These macros can no longer be used for assignment.
3502
44f230aa
SM
3503 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3504 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3505 (record_buffer_markers, fetch_buffer_markers): New functions for
3506 recording and fetching special buffer markers.
3507 (set_buffer_internal_1, set_buffer_temp): Use them.
3508
3509 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3510
3511 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3512
3513 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3514 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3515
3516 * xdisp.c (hscroll_window_tree):
3517 (reconsider_clip_changes): Use PT instead of BUF_PT.
3518
d251f04b
EZ
35192011-03-13 Eli Zaretskii <eliz@gnu.org>
3520
3521 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3522 $(EMACS_ROOT)/lib/intprops.h.
3523
f0c77cd1
PE
35242011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3525
3eca4629
PE
3526 Fix more problems found by GCC 4.5.2's static checks.
3527
7c86ee98
PE
3528 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3529 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3530 (xg_free_frame_widgets): Make it clear that a local variable is
3531 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3532 (gdk_window_get_screen): Make it clear that this macro is needed
3533 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3534 (int_gtk_range_get_value): New function, which avoids a diagnostic
3535 from gcc -Wbad-function-cast.
3536 (xg_set_toolkit_scroll_bar_thumb): Use it.
3537 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3538 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3539 (get_utf8_string, xg_get_file_with_chooser):
3540 Rename locals to avoid shadowing.
3541 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3542
41729b81
PE
3543 * xgselect.c (xg_select): Remove unused var.
3544
f0c77cd1
PE
3545 * image.c (four_corners_best): Mark locals as initialized.
3546 (gif_load): Initialize transparent_p to zero (Bug#8238).
3547 Mark another local as initialized.
ec6cf4c6 3548 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3549
ce0ad53d 3550 * image.c (clear_image_cache): Now static.
d5d5a617 3551 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3552 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3553 (x_edge_detection): Remove unnecessary cast that
3554 gcc -Wbad-function-cast diagnoses.
2037898d 3555 (gif_load): Fix pointer signedness.
6ae141d6
PE
3556 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3557 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3558
33383987 35592011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3560
d32df629
PE
3561 Improve quality of tests for time stamp overflow.
3562 For example, without this patch (encode-time 0 0 0 1 1
3563 1152921504606846976) returns the obviously-bogus value (-948597
3564 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3565 reports time overflow. See
3566 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3567 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3568 * editfns.c: Include limits.h and intprops.h.
3569 (TIME_T_MIN, TIME_T_MAX): New macros.
3570 (time_overflow): Move earlier, to before first use.
3571 (hi_time, lo_time): New functions, for an accurate test for
3572 out-of-range times.
3573 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3574 (Fget_internal_run_time): Don't assume time_t fits in int.
3575 (make_time): Use list2 instead of Fcons twice.
3576 (Fdecode_time): More accurate test for out-of-range times.
3577 (check_tm_member): New function.
3578 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3579 (lisp_time_argument): Don't rely on undefined left-shift and
3580 right-shift behavior when checking for time stamp overflow.
8be6f318 3581
fe31d94c
PE
3582 * editfns.c (time_overflow): New function, refactoring common code.
3583 (Fformat_time_string, Fdecode_time, Fencode_time):
3584 (Fcurrent_time_string): Use it.
3585
8be6f318
PE
3586 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3587 * dired.c (make_time): Move to ...
3588 * editfns.c (make_time): ... here.
3589 * systime.h: Note the move.
3590
09d9db2c 35912011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3592
126bc0dc
YM
3593 * fringe.c (update_window_fringes): Remove unused variables.
3594
c47cbdfd
YM
3595 * unexmacosx.c (copy_data_segment): Also copy __got section.
3596 (Bug#8223)
3597
7ac80be9
EZ
35982011-03-12 Eli Zaretskii <eliz@gnu.org>
3599
c96bbc66 3600 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3601 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3602 Constify `char *' arguments and their references according to
3603 prototypes in tparam.h.
3604
ecb0f94d 3605 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3606
7ac80be9
EZ
3607 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3608 Adapt all references accordingly.
3609
3610 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3611
ef1fd07e
TT
36122011-03-11 Tom Tromey <tromey@redhat.com>
3613
3614 * buffer.c (syms_of_buffer): Remove obsolete comment.
3615
7ef4b50c
EZ
36162011-03-11 Eli Zaretskii <eliz@gnu.org>
3617
3618 * termhooks.h (encode_terminal_code): Declare prototype.
3619
3620 * msdos.c (encode_terminal_code): Don't declare prototype.
3621
3622 * term.c (encode_terminal_code): Now external again, used by
3623 w32console.c and msdos.c.
3624
44f230aa
SM
3625 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3626 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3627
4b1ec863 36282011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3629
1714f52b 3630 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3631
4b1ec863
PE
3632 * fringe.c (update_window_fringes): Mark locals as initialized
3633 (Bug#8227).
3634 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3635
524c7aa6
PE
3636 * alloc.c (mark_fringe_data): Move decl from here ...
3637 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3638 to check its interface.
3639 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3640
a5c0af81 3641 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3642 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3643 (fontset_font): Mark local as initialized.
a9a06e0b 3644 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3645
b4716021
PE
3646 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3647
811e9bac 3648 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3649 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3650 (x_own_selection, Fx_disown_selection_internal): Rename locals
3651 to avoid shadowing.
3652 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3653
7e3ab302
PE
3654 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3655 so that the caller can use some name other than gcpro1.
3656 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3657 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3658 (Fx_backspace_delete_keys_p):
3659 Use them to avoid shadowing, and rename vars to avoid shadowing.
3660 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3661 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3662 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3663 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3664 Remove unused locals.
7e3ab302
PE
3665 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3666 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3667 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3668 macros.
f78faa98 3669
e2b13473
PE
3670 * xterm.h (x_mouse_leave): New decl.
3671
77f23912
PE
3672 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3673 Remove unused functions.
cdf4ba58
PE
3674 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3675 (x_calc_absolute_position): Now static.
7411c686 3676 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3677 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3678 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3679 unless they are used.
38d0b34a
PE
3680 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3681 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3682 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3683 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3684 (x_error_catcher, x_connection_closed, x_error_handler):
3685 (x_error_quitter, xembed_send_message, x_iconify_frame):
3686 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3687 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3688 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3689
44f230aa
SM
3690 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3691 Rename or move locals to avoid shadowing.
6b463e58 3692 (tty_defined_color, merge_face_heights): Now static.
5967d051 3693 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3694 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3695 does not deduce is never used uninitialized.
73719eba
PE
3696 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3697 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3698
426994c3 3699 * terminal.c (store_terminal_param): Now static.
5489860b 3700
032f1620 3701 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3702 (set_frame_menubar): Remove unused local.
d4323972 3703 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3704 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3705 since they might point to immutable storage.
281585b0
PE
3706 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3707 since it's unused otherwise.
032f1620 3708
367c19e5 3709 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3710 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3711 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3712 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3713 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3714 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3715 does not deduce are never used uninitialized.
70739cbe 3716
07b48fa9
PE
3717 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3718
8868a238 3719 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3720 * window.c (window_loop, size_window):
3721 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3722
7e5cf297 3723 * window.c (display_buffer): Now static.
d6550a9f
PE
3724 (size_window): Mark variables that gcc -Wuninitialized
3725 does not deduce are never used uninitialized.
a586633d
PE
3726 * window.h (check_all_windows): New decl, to forestall
3727 gcc -Wmissing-prototypes diagnostic.
5b555da1 3728 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3729
f6095868
PE
3730 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3731 shadowing.
3732 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3733 Include <limits.h>.
3734 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3735 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3736 (load_charset_map): Mark variables that gcc -Wuninitialized
3737 does not deduce are never used uninitialized.
53df7c11 3738 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3739
f38b440c
PE
3740 * coding.c (coding_set_source, coding_set_destination):
3741 Use "else { /* comment */ }" rather than "else /* comment */;"
3742 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3743 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3744 a block, when the outer 'i' will do.
3745 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3746 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3747 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3748 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3749 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3750 Rename locals to avoid shadowing.
3751 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3752 * coding.c (emacs_mule_char, encode_invocation_designation):
3753 Now static, since they're not used elsewhere.
413bb2db 3754 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3755 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3756 (decode_coding_emacs_mule): Mark variables that gcc
3757 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3758 (detect_coding_iso_2022): Initialize a local variable that might
3759 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3760 this initialization is needed. (Bug#8211)
5f58e762
PE
3761 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3762 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3763 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3764 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3765 Remove unused macros.
f38b440c 3766
232b38b9 3767 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3768 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3769 * character.c (string_count_byte8): Likewise.
232b38b9 3770
fb90da1b
PE
3771 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3772 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3773
fb93dbc2
PE
3774 * chartab.c (copy_sub_char_table): Now static, since it's not used
3775 elsewhere.
5c156ace
PE
3776 (sub_char_table_ref_and_range, char_table_ref_and_range):
3777 Rename locals to avoid shadowing.
bbcd0949 3778 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3779
7d3b3862 3780 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3781 (BIDI_BOB): Remove unused macro.
7d3b3862 3782
6be7d3da
PE
3783 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3784 deduce are never used uninitialized.
c2ed9c8b 3785 * term.c (encode_terminal_code): Likewise.
6be7d3da 3786
75f8807f 3787 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3788
50938595
PE
3789 * tparam.h: New file.
3790 * term.c, tparam.h: Include it.
3791 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3792 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3793 Move these decls to tparam.h, and make them agree with what
3794 is actually in tparam.c. The previous trick of using incompatible
3795 decls in different modules does not conform to the C standard.
3796 All callers of tparam changed to use tparam's actual API.
3797 * tparam.c (tparam1, tparam, tgoto):
3798 Use const pointers where appropriate.
3799
fbceeba2
PE
3800 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3801 * cm.h (struct cm): Likewise.
3802 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3803 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3804 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3805 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3806 (turn_on_face, init_tty): Likewise.
3807 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3808
7f3f1250
PE
3809 * term.c (term_mouse_position): Rename local to avoid shadowing.
3810
e6ca6543
PE
3811 * alloc.c (mark_ttys): Move decl from here ...
3812 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3813
c40f8d15
AS
38142011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3815
3816 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3817
cfe0661d
JB
38182011-03-09 Juanma Barranquero <lekktu@gmail.com>
3819
3820 * search.c (compile_pattern_1): Remove argument regp, unused since
3821 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3822 (compile_pattern): Don't pass it.
3823
0afb4571
J
38242011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3825
3826 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3827 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3828 for ! HAVE_GTK3.
3829 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3830
3831 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3832
3833 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3834 gdk_window_get_screen, gdk_window_get_geometry,
3835 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3836 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3837 (xg_get_pixbuf_from_pixmap): New function.
3838 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3839 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3840 Call xg_get_pixbuf_from_pixmap instead of
3841 gdk_pixbuf_get_from_drawable.
3842 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3843 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3844 (xg_check_special_colors): Use GtkStyleContext and its functions
3845 for HAVE_GTK3.
3846 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3847 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3848 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3849 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3850 Call gtk_widget_get_preferred_size.
0afb4571
J
3851 (xg_frame_resized): gdk_window_get_geometry only takes 5
3852 parameters.
44f230aa
SM
3853 (xg_win_to_widget, xg_event_is_for_menubar):
3854 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3855 (xg_set_widget_bg): New function.
3856 (delete_cb): New function.
895009e1 3857 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3858 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3859 (xg_set_background_color): Call xg_set_widget_bg.
3860 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3861 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3862 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3863 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3864 if ! HAVE_GTK3.
3865 (update_frame_tool_bar): Call gtk_widget_hide.
3866 (xg_initialize): Use GDK_KEY_g.
3867
3868 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3869 if ! HAVE_GTK3
3870 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3871
3872 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3873 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3874 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3875
1c2cc4ef
JB
38762011-03-08 Juanma Barranquero <lekktu@gmail.com>
3877
3878 * w32xfns.c (select_palette): Check success of RealizePalette against
3879 GDI_ERROR, not zero.
3880
33383987 3881See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3882
3883;; Local Variables:
3884;; coding: utf-8
aac0c6e3
MR
3885;; End:
3886
33383987 3887 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3888
3889 This file is part of GNU Emacs.
3890
3891 GNU Emacs is free software: you can redistribute it and/or modify
3892 it under the terms of the GNU General Public License as published by
3893 the Free Software Foundation, either version 3 of the License, or
3894 (at your option) any later version.
3895
3896 GNU Emacs is distributed in the hope that it will be useful,
3897 but WITHOUT ANY WARRANTY; without even the implied warranty of
3898 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3899 GNU General Public License for more details.
3900
3901 You should have received a copy of the GNU General Public License
3902 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.