* xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
51cab52b 12011-06-21 Paul Eggert <eggert@cs.ucla.edu>
882f0d81 2
3de73e5e
PE
3 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4
2606c57b
PE
5 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6 (x_session_initialize): Do not assume string length fits in int.
7
aaafe47a
PE
8 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9 This is unlikely, but can occur if DPI is outlandish.
10
2674ddc8 11 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
12 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
13
28154962
PE
14 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
15 * xrdb.c (magic_file_p, search_magic_path):
16 Omit last arg SUFFIX; it was always 0. All callers changed.
17 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
18
7de51af5
PE
19 * xfont.c (xfont_match): Avoid need for strlen.
20
25ed6cc3
PE
21 * xfns.c: Don't assume strlen fits in int.
22 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
23
4eab31dd
PE
24 * xdisp.c (message_log_check_duplicate): Return intmax_t,
25 not unsigned long, as we prefer signed integers. All callers changed.
26 Detect integer overflow in repeat count.
27 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 28 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 29
171e2a58
PE
30 * termcap.c: Don't assume sizes fit in int and never overflow.
31 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
32 (gobble_line): Check for size-calculation overflow.
33
ad39faca 34 * minibuf.c (Fread_buffer):
6e5bb2dc 35 * lread.c (intern, intern_c_string):
74ca2eb3
PE
36 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
37 Don't assume string length fits in int.
38
52c61c22 39 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
40 * gtkutil.c (style_changed_cb): Avoid need for strlen.
41
b5b8c9e5
PE
42 * font.c: Don't assume string length fits in int.
43 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
44 Use ptrdiff_t, not int.
ccd6111c
PE
45 (font_intern_prop): Don't assume string length fits in int.
46 Don't assume integer property fits in fixnum.
47 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 48
882f0d81 49 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 50 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
51 Reformulate so as not to need the command string.
52 Invoke gzip -cd rather than gunzip, as it's more portable.
53 (lock_info_type, lock_file_1, lock_file):
54 Don't assume pid_t and time_t fit in unsigned long.
55 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
56 (current_lock_owner): Prefer signed type for sizes.
57 Use memcpy, not strncpy, where memcpy is what is really wanted.
58 Don't assume (via atoi) that time_t and pid_t fit in int.
59 Check for time_t and/or pid_t out of range, e.g., via a network share.
60 Don't alloca where an auto var works fine.
61
93f4cf88
PE
62 * fileio.c: Fix some integer overflow issues.
63 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
64 Don't assume string length fits in int.
65 (directory_file_name): Don't assume string length fits in long.
66 (make_temp_name): Don't assume pid fits in int, or that its print
67 length is less than 20.
68
f3e92b69
PE
69 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
70
1bfdaf10
PE
71 * coding.c (make_subsidiaries): Don't assume string length fits in int.
72
35016e9a
PE
73 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
74
3d1e65a1
PE
75 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
76 We prefer signed integers, even for size calculations.
77
0b963a93
PE
78 * emacs.c: Don't assume string length fits in 'int'.
79 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
80 (main): Don't invoke strlen when not needed.
81
573f4b54
PE
82 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
83 (XD_DEBUG_MESSAGE): Don't waste a byte.
84
989f33ba
PE
85 * callproc.c (getenv_internal_1, getenv_internal)
86 (Fgetenv_internal):
965d34eb
PE
87 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
88
e4d29b33
PE
89 * lread.c (invalid_syntax): Omit length argument.
90 All uses changed. This doesn't fix a bug, but it simplifies the
91 code away from its former Hollerith-constant appearance, and it's
92 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 93 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 94
eb49b136
PE
95 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
96 This didn't break anything, but it didn't help either.
97 It's confusing to put a bogus integer in a place where the actual
98 value does not matter.
9f62aeb1 99 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 100 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 101
15375a22
PE
102 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
103 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
104 implementation.
b61cc01c
PE
105 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
106 We prefer signed types, and the value cannot exceed the EMACS_INT
107 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
108 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
109 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
110 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 111
53b2623d
PE
112 * indent.c (sane_tab_width): New function.
113 (current_column, scan_for_column, Findent_to, position_indentation)
114 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 115 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 116
51cab52b 117 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 118
f2ed8a70
PE
119 * lisp.h (lint_assume): New macro.
120 * composite.c (composition_gstring_put_cache):
121 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
122
abe80cc6
PE
123 * editfns.c, insdel.c:
124 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 125
b02c740e
PE
126 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
127
ebc96716
PE
128 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
129
b4e50fa0 130 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 131 Use much-faster test for byte-length change.
311d5d7c 132 Don't assume string byte-length fits in 'int'.
a4cf38e4 133 Check that character arg fits in 'int'.
85461888 134 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 135
c0c1ee9f
PE
136 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
137
a498d7f4
PE
138 * fns.c (concat): Catch string overflow earlier.
139 Do not rely on integer wraparound.
140
51cab52b
PE
141 * dispextern.h (struct it.overlay_strings_charpos)
142 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
143 * xdisp.c (forward_to_next_line_start)
144 (back_to_previous_visible_line_start)
145 (reseat_at_next_visible_line_start, next_element_from_buffer):
146 Don't arbitrarily truncate the value of 'selective' to int.
147
76031fad
PE
148 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
149
5eb55db9
PE
150 * composite.c: Don't truncate sizes to 'int'.
151 (composition_gstring_p, composition_reseat_it)
152 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
153 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
154 not EMACS_UINT, for indexes.
5eb55db9 155
0703a717
PE
156 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
157
d6202519
PE
158 * buffer.c: Include <verify.h>.
159 (struct sortvec.priority, struct sortstr.priority):
8961a454 160 Now EMACS_INT, not int.
c20998a7 161 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
162 (struct sortstr.size, record_overlay_string)
163 (struct sortstrlist.size, struct sortlist.used):
164 Don't truncate size to int.
165 (record_overlay_string): Check for size-calculation overflow.
d6202519 166 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 167
76147d94
DD
1682011-06-20 Deniz Dogan <deniz@dogan.se>
169
170 * process.c (Fset_process_buffer): Clarify return value in
171 docstring.
172
7d7d0045
CY
1732011-06-18 Chong Yidong <cyd@stupidchicken.com>
174
175 * dispnew.c (add_window_display_history): Use BVAR.
176
177 * xdisp.c (debug_method_add): Use BVAR.
178 (check_window_end, dump_glyph_matrix, dump_glyph)
179 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
180
181 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
182 Likewise.
183
184 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
185 check till after the cache is created in init_frame_faces.
186
ff2bc410
SM
1872011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
188
189 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
190
28177add
PE
1912011-06-16 Paul Eggert <eggert@cs.ucla.edu>
192
dd3482fe
PE
193 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
194 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
195 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
196
393d71f3 197 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
198 * fileio.c (Finsert_file_contents):
199 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
200 Remove the old (too-loose) buffer overflow checks.
201 They weren't needed, since make_gap checks for buffer overflow.
202 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
203 The old code merely checked for Emacs fixnum overflow, and relied
204 on undefined (wraparound) behavior. The new code avoids undefined
205 behavior, and also checks for ptrdiff_t and/or size_t overflow.
206
2e6813b0 207 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
208 Tune. Don't use wider integers than needed. Don't use alloca.
209 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 210
599a9e4f
PE
211 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
212
99561444
PE
213 * insdel.c, lisp.h (buffer_overflow): New function.
214 (insert_from_buffer_1, replace_range, replace_range_2):
215 * insdel.c (make_gap_larger):
216 * editfns.c (Finsert_char):
217 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
218
28177add
PE
219 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
220
e69dafad
PE
2212011-06-15 Paul Eggert <eggert@cs.ucla.edu>
222
a7af7fde 223 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 224
b1c46f02
PE
225 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
226 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
227
e69dafad
PE
228 * fileio.c: Don't assume EMACS_INT fits in off_t.
229 (emacs_lseek): New static function.
230 (Finsert_file_contents, Fwrite_region): Use it.
231 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
232
566684ea
PE
233 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
234
e6966cd6
PE
235 * fns.c: Don't overflow int when computing a list length.
236 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
237 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
238 truncation on 64-bit hosts. Check for QUIT every
239 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
240 faster and is responsive enough.
241 (Flength): Report an error instead of overflowing an integer.
242 (Fsafe_length): Return a float if the value is not representable
243 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 244 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 245 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 246
dd0b0efb
PE
247 * alloc.c: Check that resized vectors' lengths fit in fixnums.
248 (header_size, word_size): New constants.
249 (allocate_vectorlike): Don't check size overflow here.
250 (allocate_vector): Check it here instead, since this is the only
251 caller of allocate_vectorlike that could cause overflow.
252 Check that the new vector's length is representable as a fixnum.
253
86fe5cfe
PE
254 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
255 The previous code was bogus. For example, next_almost_prime (32)
256 returned 39, which is undesirable as it is a multiple of 3; and
257 next_almost_prime (24) returned 25, which is a multiple of 5 so
258 why was the code bothering to check for multiples of 7?
259
80e88859
PE
260 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
261
4a2f0ad6
PE
262 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
263
f66c7cf8
PE
264 Variadic C functions now count arguments with ptrdiff_t.
265 This partly undoes my 2011-03-30 change, which replaced int with size_t.
266 Back then I didn't know that the Emacs coding style prefers signed int.
267 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
268 were being counted with int, which may truncate counts on 64-bit
269 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
270 * lisp.h (struct Lisp_Subr.function.aMANY)
271 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
272 Arg counts are now ptrdiff_t, not size_t.
273 All variadic functions and their callers changed accordingly.
274 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
275 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
276 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
277 * callint.c (Fcall_interactively): Check arg count for overflow,
278 to avoid potential buffer overrun. Use signed char, not 'int',
279 for 'varies' array, so that we needn't bother to check its size
280 calculation for overflow.
281 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
282 * eval.c (apply_lambda):
283 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
284 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
285 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
286
a1759b76
PE
287 * callint.c (Fcall_interactively): Don't use index var as event count.
288
d96be9fc
PE
289 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
290 * mem-limits.h (SIZE): Remove; no longer used.
291
a690a978 292 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 293
578c21e6
PE
294 Remove unnecessary casts.
295 * xterm.c (x_term_init):
296 * xfns.c (x_set_border_pixel):
297 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
298 These aren't needed now that we assume ANSI C.
299
96f53c6c
PE
300 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
301 It's more likely to cause problems (due to unsigned overflow)
302 than to cure them.
303
83c77d31
PE
304 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
305
ee2079f1
PE
306 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
307
6da65536
PE
308 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
309
7147c4a4
PE
310 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
311
193e32d9
PE
312 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
313
e5533da6
PE
314 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
315
9910e595
PE
316 GLYPH_CODE_FACE returns EMACS_INT, not int.
317 * dispextern.h (merge_faces):
318 * xfaces.c (merge_faces):
01103c44
PE
319 * xdisp.c (get_next_display_element, next_element_from_display_vector):
320 Don't assume EMACS_INT fits in int.
9910e595 321
2638320e
PE
322 * character.h (CHAR_VALID_P): Remove unused parameter.
323 * fontset.c, lisp.h, xdisp.c: All uses changed.
324
045eb8d9
PE
325 * editfns.c (Ftranslate_region_internal): Omit redundant test.
326
c1f134b5
PE
327 * fns.c (concat): Minor tuning based on overflow analysis.
328 This doesn't fix any bugs. Use int to hold character, instead
329 of constantly refetching from Emacs object. Use XFASTINT, not
330 XINT, for value known to be a character. Don't bother comparing
331 a single byte to 0400, as it's always less.
332
395fcb93 333 * floatfns.c (Fexpt):
327eeec8
PE
334 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
335
abbd3d23
PE
336 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
337 for characters.
338
684a03ef
PE
339 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
340
0fed43f3
PE
341 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
342 Without this fix, on a 64-bit host (aset S 0 4294967386) would
343 incorrectly succeed when S was a string, because 4294967386 was
344 truncated before it was used.
345
8fd02eb7
PE
346 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
347 Otherwise, an out-of-range integer could cause undefined behavior
348 on a 64-bit host.
349
f8c86b69
PE
350 * composite.c: Use int, not EMACS_INT, for characters.
351 (fill_gstring_body, composition_compute_stop_pos): Use int, not
352 EMACS_INT, for values that are known to be in character range.
353 This doesn't fix any bugs but is the usual style inside Emacs and
354 may generate better code on 32-bit machines.
355
34206dd2
PE
356 Make sure a 64-bit char is never passed to ENCODE_CHAR.
357 This is for reasons similar to the recent CHAR_STRING fix.
358 * charset.c (Fencode_char): Check that character arg is actually
359 a character. Pass an int to ENCODE_CHAR.
360 * charset.h (ENCODE_CHAR): Verify that the character argument is no
361 wider than 'int', as a compile-time check to prevent future regressions
362 in this area.
363
c5958d4c 364 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
365
366 Make sure a 64-bit char is never passed to CHAR_STRING.
367 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
368 by silently ignoring the top 32 bits, allowing some values
369 that were far too large to be valid characters.
370 * character.h: Include <verify.h>.
371 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
372 arguments are no wider than unsigned, as a compile-time check
373 to prevent future regressions in this area.
374 * data.c (Faset):
01103c44 375 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
376 (Fsubst_char_in_region):
377 * fns.c (concat):
378 * xdisp.c (decode_mode_spec_coding):
379 Adjust to CHAR_STRING's new requirement.
380 * editfns.c (Finsert_char, Fsubst_char_in_region):
381 * fns.c (concat): Check that character args are actually
382 characters. Without this test, these functions did the wrong
383 thing with wildly out-of-range values on 64-bit hosts.
384
d37ca623
PE
385 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
386 These casts should not be needed on 32-bit hosts, either.
387 * keyboard.c (read_char):
388 * lread.c (Fload): Remove casts to unsigned.
389
ea204efb
PE
390 * lisp.h (UNSIGNED_CMP): New macro.
391 This fixes comparison bugs on 64-bit hosts.
392 (ASCII_CHAR_P): Use it.
393 * casefiddle.c (casify_object):
01103c44 394 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
395 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
396 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
397 * dispextern.h (FACE_FROM_ID):
398 * keyboard.c (read_char): Use UNSIGNED_CMP.
399
41cb286c
PE
400 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
401 not to EMACS_INT, to avoid GCC warning.
402
4a1b9832
PE
403 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
404
55daad71
PE
405 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
406 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
407 isn't needed on 32-bit machines.
8f95c75c 408
01103c44
PE
409 * buffer.c (Fgenerate_new_buffer_name):
410 Use EMACS_INT for count, not int.
0ceccced 411 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
412
413 * data.c (Qcompiled_function): Now static.
414
c6f072e7
PE
415 * window.c (window_body_lines): Now static.
416
20ce5912
PE
417 * image.c (gif_load): Rename local to avoid shadowing.
418
9c4c5f81
PE
419 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
420 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
421 * alloc.c (make_save_value): Integer argument is now of type
422 ptrdiff_t, not int.
423 (mark_object): Use ptrdiff_t, not int.
424 * lisp.h (pD): New macro.
425 * print.c (print_object): Use it.
426
c0c5c8ae
PE
427 * alloc.c: Use EMACS_INT, not int, to count objects.
428 (total_conses, total_markers, total_symbols, total_vector_size)
429 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
430 (total_free_floats, total_floats, total_free_intervals)
431 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
432 Now EMACS_INT, not int. All uses changed.
433 (Fgarbage_collect): Compute overall total using a double, so that
434 integer overflow is less likely to be a problem. Check for overflow
435 when converting back to an integer.
5a25e253
PE
436 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
437 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
438 These were 'int' variables that could overflow on 64-bit hosts;
439 they were never used, so remove them instead of repairing them.
211a0b2a 440 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
441 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
442 Previously, this ceilinged at INT_MAX, but that doesn't work on
443 64-bit machines.
e46bb31a 444 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 445
c78baabf 446 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 447 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
448 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
449 when a (possibly-narrower) signed value would do just as well.
450 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 451
c9d624c6
PE
452 * alloc.c: Catch some string size overflows that we were missing.
453 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
454 for convenience in STRING_BYTES_MAX.
455 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
456 The definition here is exact; the one in lisp.h was approximate.
457 (allocate_string_data): Check for string overflow. This catches
458 some instances we weren't catching before. Also, it catches
459 size_t overflow on (unusual) hosts where SIZE_MAX <= min
460 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
461 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 462
c9d624c6
PE
463 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
464 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
465 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
466
353032ce
PE
467 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
468
2bccce07
PE
469 * alloc.c (Fmake_string): Check for out-of-range init.
470
0ac30604
SM
4712011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
472
473 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
474
c195f2de
JD
4752011-06-14 Jan Djärv <jan.h.d@swipnet.se>
476
477 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
478 xg_get_default_scrollbar_width.
479
480 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
481 (int_gtk_range_get_value): Move to the scroll bar part of the file.
482 (style_changed_cb): Call update_theme_scrollbar_width and call
483 x_set_scroll_bar_default_width and xg_frame_set_char_size for
484 all frames (Bug#8505).
485 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
486 Call gtk_window_set_resizable if HAVE_GTK3.
487 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
488 and height if HAVE_GTK3 (Bug#8505).
489 (scroll_bar_width_for_theme): New variable.
490 (update_theme_scrollbar_width): New function.
491 (xg_get_default_scrollbar_width): Move code to
492 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
493 (xg_initialize): Call update_theme_scrollbar_width.
494
495 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
496
497 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
498
e10ac9f1
MR
4992011-06-12 Martin Rudalics <rudalics@gmx.at>
500
501 * frame.c (make_frame): Call other_buffer_safely instead of
502 other_buffer.
503
504 * window.c (temp_output_buffer_show): Call display_buffer with
505 second argument Vtemp_buffer_show_specifiers and reset latter
506 immediately after the call.
507 (Vtemp_buffer_show_specifiers): New variable.
508 (auto_window_vscroll_p, next_screen_context_lines)
509 (Vscroll_preserve_screen_position): Remove leading asterisks from
510 doc-strings.
511
2d3c217e 5122011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 513
7b7f97e8 514 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
515 * buffer.c (Qclone_number): Remove for now, as it's unused.
516 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
517 (record_buffer): Remove unused local.
518 * frame.c (other_visible_frames, frame_buffer_list): Now static.
519 (set_frame_buffer_list): Remove; unused.
520 * frame.h (other_visible_frames): Remove decl.
521 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
522 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
523 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
524 if HAVE_GPM.
525 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
526 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
527 Define only if HAVE_GPM.
528 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
529 (update_hints_inhibit): Remove; never set. All uses removed.
530 * widgetprv.h (emacsFrameClassRec): Remove decl.
531 * window.c (delete_deletable_window): Now returns void, since it
532 wasn't returning anything.
533 (compare_window_configurations): Remove unused locals.
534 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
535 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
536 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
537 the same widths as pointers. This follows up on the 2011-05-06 patch.
538 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
539 * xterm.h: Likewise.
540 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
541
1384b89e
JB
5422011-06-12 Juanma Barranquero <lekktu@gmail.com>
543
544 * makefile.w32-in: Update dependencies.
545 (LISP_H): Add lib/intprops.h.
546
1100a63c
CY
5472011-06-11 Chong Yidong <cyd@stupidchicken.com>
548
549 * image.c (gif_load): Add animation frame delay to the metadata.
550 (syms_of_image): Use DEFSYM. New symbol `delay'.
551
6198ccd0
MR
5522011-06-11 Martin Rudalics <rudalics@gmx.at>
553
554 * window.c (delete_deletable_window): Re-add.
555 (Fset_window_configuration): Rewrite to handle dead buffers and
556 consequently deletable windows.
557 (window_tree, Fwindow_tree): Remove. Supply functionality in
558 window.el.
559 (compare_window_configurations): Simplify code.
560
b6e3633c
AS
5612011-06-11 Andreas Schwab <schwab@linux-m68k.org>
562
1ab0dee5
AS
563 * image.c (imagemagick_load_image): Fix type mismatch.
564 (Fimagemagick_types): Likewise.
565
b6e3633c
AS
566 * window.h (replace_buffer_in_windows): Declare.
567
9397e56f
MR
5682011-06-11 Martin Rudalics <rudalics@gmx.at>
569
570 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
571 Qclone_number. Remove external declaration of Qdelete_window.
572 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
573 code.
574 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
575 Qbuffer_list_update_hook if allowed.
576 (Fother_buffer): Rewrite doc-string. Major rewrite for new
577 buffer list implementation.
578 (other_buffer_safely): New function.
579 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
580 calls to replace_buffer_in_windows and
581 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
582 if allowed.
583 (record_buffer): Inhibit quitting and rewrite using quittable
584 functions. Run Qbuffer_list_update_hook if allowed.
585 (Frecord_buffer, Funrecord_buffer): New functions.
586 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
587 switch-to-buffer to window.el.
588 (bury-buffer): Move to window.el.
589 (Vbuffer_list_update_hook): New variable.
590
591 * lisp.h (other_buffer_safely): Add prototype in buffer.c
592 section.
593
594 * window.h (resize_frame_windows): Move up in code.
595 (Fwindow_frame): Remove EXFUN.
596 (replace_buffer_in_all_windows): Remove prototype.
597 (replace_buffer_in_windows_safely): Add prototype.
598
599 * window.c: Declare Qdelete_window static again. Move down
600 declaration of select_count.
601 (Fnext_window, Fprevious_window): Rewrite doc-strings.
602 (Fother_window): Move to window.el.
603 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
604 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
605 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
606 window.el.
607 (replace_buffer_in_windows): Implement by calling
608 Qreplace_buffer_in_windows.
609 (replace_buffer_in_all_windows): Remove with some functionality
610 moved into replace_buffer_in_windows_safely.
611 (replace_buffer_in_windows_safely): New function.
612 (select_window_norecord, select_frame_norecord): Move in front
613 of run_window_configuration_change_hook. Remove now obsolete
614 declarations.
615 (Fset_window_buffer): Rewrite doc-string. Call
616 Qrecord_window_buffer.
617 (keys_of_window): Move binding for other-window to window.el.
618
b50691aa
CY
6192011-06-11 Chong Yidong <cyd@stupidchicken.com>
620
621 * dispextern.h (struct image): Replace data member, whose int_val
622 and ptr_val fields were not used by anything, with a single
623 lisp_val object.
624
625 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
626 (gif_clear_image, gif_load, imagemagick_load_image)
627 (gs_clear_image, gs_load): Callers changed.
628
3f754b86
PE
6292011-06-10 Paul Eggert <eggert@cs.ucla.edu>
630
cca69397
PE
631 * buffer.h: Include <time.h>, for time_t.
632 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
633
109e28d0
PE
634 Fix minor problems found by static checking.
635
60737f02
PE
636 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
637
4b66faf3
PE
638 Make identifiers static if they are not used in other modules.
639 * data.c (Qcompiled_function, Qframe, Qvector):
640 * image.c (QimageMagick, Qsvg):
641 * minibuf.c (Qmetadata):
642 * window.c (resize_window_check, resize_root_window): Now static.
643 * window.h (resize_window_check, resize_root_window): Remove decls.
644
109e28d0
PE
645 * window.c (window_deletion_count, delete_deletable_window):
646 Remove; unused.
46a4ce9e
PE
647 (window_body_lines): Now static.
648 (Fdelete_other_windows_internal): Mark vars as initialized.
649 Make sure 'resize_failed' is initialized.
650 (run_window_configuration_change_hook): Rename local to avoid shadowing.
651 (resize_window_apply): Remove unused local.
652 * window.h (delete_deletable_window): Remove decl.
653
109e28d0 654 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
655 (imagemagick_load_image): Fix pointer signedness problem by changing
656 last arg from unsigned char * to char *. All uses changed.
657 Also, fix a local for similar reasons.
658 Remove unused locals. Remove locals to avoid shadowing.
659 (fn_rsvg_handle_free): Remove; unused.
660 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 661 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 662
3f754b86
PE
663 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
664
2547adb1
CY
6652011-06-10 Chong Yidong <cyd@stupidchicken.com>
666
667 * image.c (gif_load): Fix omitted cast error introduced by
668 2011-06-06 change.
669
2c8e37d4
MR
6702011-06-10 Martin Rudalics <rudalics@gmx.at>
671
672 * window.h (resize_proportionally, orig_total_lines)
673 (orig_top_line): Remove from window structure.
674 (set_window_height, set_window_width, change_window_heights)
675 (Fdelete_window): Remove prototypes.
676 (resize_frame_windows): Remove duplicate declaration.
677
440a42e3
EZ
6782011-06-10 Eli Zaretskii <eliz@gnu.org>
679
680 * window.h (resize_frame_windows, resize_window_check)
681 (delete_deletable_window, resize_root_window)
682 (resize_frame_windows): Declare prototypes.
683
684 * window.c (resize_window_apply): Make definition be "static" to
685 match the prototype.
686
562dd5e9
MR
6872011-06-10 Martin Rudalics <rudalics@gmx.at>
688
689 * window.c: Remove declarations of Qwindow_size_fixed,
690 window_min_size_1, window_min_size_2, window_min_size,
691 size_window, window_fixed_size_p, enlarge_window, delete_window.
692 Remove static from declaration of Qdelete_window, it's
693 temporarily needed by Fbury_buffer.
694 (replace_window): Don't assign orig_top_line and
695 orig_total_lines.
696 (Fdelete_window, delete_window): Remove. Window deletion is
697 handled by window.el.
698 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
699 Fdelete_window calls with calls to Qdelete_window.
700 (Fdelete_other_windows): Remove. Deleting other windows is
701 handled by window.el.
702 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
703 handled in window.el.
704 (window_min_size_2, window_min_size_1, window_min_size): Remove.
705 Window minimum sizes are handled in window.el.
706 (shrink_windows, size_window, set_window_height)
707 (set_window_width, change_window_heights, window_height)
708 (window_width, CURBEG, CURSIZE, enlarge_window)
709 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
710 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
711 handled in window.el.
712 (make_dummy_parent): Rename to make_parent_window and give it a
713 second argument horflag.
714 (make_window): Don't set resize_proportionally any more.
715 (Fsplit_window): Remove. Windows are split in window.el.
716 (save_restore_action, save_restore_orig_size)
717 (shrink_window_lowest_first, save_restore_orig_size): Remove.
718 Resize mini windows in window.el.
719 (grow_mini_window, shrink_mini_window): Implement by calling
720 Qresize_root_window_vertically, resize_window_check and
721 resize_window_apply.
722 (saved_window, Fset_window_configuration, save_window_save): Do
723 not handle orig_top_line, orig_total_lines, and
724 resize_proportionally.
725 (window_min_height, window_min_width): Move to window.el.
726 (keys_of_window): Move bindings for delete-other-windows,
727 split-window, delete-window and enlarge-window to window.el.
728
729 * buffer.c: Temporarily extern Qdelete_window.
730 (Fbury_buffer): Temporarily call Qdelete_window instead of
731 Fdelete_window (Fbury_buffer will move to window.el soon).
732
733 * frame.c (set_menu_bar_lines_1): Remove code handling
734 orig_top_line and orig_total_lines.
735
736 * dispnew.c (adjust_frame_glyphs_initially): Don't use
737 set_window_height but set heights directly.
738 (change_frame_size_1): Use resize_frame_windows.
739
740 * xdisp.c (init_xdisp): Don't use set_window_height but set
741 heights directly.
742
743 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
744 resize_frame_windows instead of change_window_heights and run
745 run_window_configuration_change_hook.
746
747 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
748 instead of change_window_heights and run
749 run_window_configuration_change_hook.
750
1a13852e
MR
7512011-06-09 Martin Rudalics <rudalics@gmx.at>
752
753 * window.c (replace_window): Rename second argument REPLACEMENT to
754 NEW. New third argument SETFLAG. Rewrite.
755 (delete_window, make_dummy_parent): Call replace_window with
756 third argument 1.
757 (window_list_1): Move down in code.
758 (run_window_configuration_change_hook): Move set_buffer part
759 before select_frame_norecord part in order to unwind correctly.
760 Rename count1 to count.
761 (recombine_windows, delete_deletable_window, resize_root_window)
762 (Fdelete_other_windows_internal)
763 (Frun_window_configuration_change_hook, make_parent_window)
764 (resize_window_check, resize_window_apply, Fresize_window_apply)
765 (resize_frame_windows, Fsplit_window_internal)
766 (Fdelete_window_internal, Fresize_mini_window_internal): New
767 functions.
768 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
769
f3d1777e
MR
7702011-06-08 Martin Rudalics <rudalics@gmx.at>
771
496e208e
MR
772 * window.h (window): Add some new members to window structure -
773 normal_lines, normal_cols, new_total, new_normal, clone_number,
774 splits, nest, prev_buffers, next_buffers.
775 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 776 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 777
f3d1777e
MR
778 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
779 Remove.
496e208e
MR
780 (make_dummy_parent): Set new members of windows structure.
781 (make_window): Move down in code. Handle new members of window
782 structure.
783 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
784 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
785 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
786 (Fset_window_prev_buffers, Fwindow_next_buffers)
787 (Fset_window_next_buffers, Fset_window_clone_number): New
788 functions.
789 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
790 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
791 Doc-string fixes.
792 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
793 Argument WINDOW can be now internal window too.
794 (Fwindow_use_time): Move up in code.
795 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
796 Rewrite doc-string.
797 (Fset_window_configuration, saved_window)
798 (Fcurrent_window_configuration, save_window_save): Handle new
799 members of window structure.
b9e809c2
MR
800 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
801 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
802 (syms_of_window): New Lisp objects Qrecord_window_buffer,
803 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
804 Qget_mru_window, Qresize_root_window,
805 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
806 Qauto_buffer_name; staticpro them.
f3d1777e 807
abde8f8c
MR
8082011-06-07 Martin Rudalics <rudalics@gmx.at>
809
810 * window.c (Fwindow_total_size, Fwindow_left_column)
811 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
812 (Fwindow_list_1): New functions.
813 (window_box_text_cols): Replace with window_body_cols.
814 (Fwindow_width, Fscroll_left, Fscroll_right): Use
815 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
816 (delete_window, Fset_window_configuration): Call
817 delete_all_subwindows with window as argument.
818 (delete_all_subwindows): Take a window as argument and not a
819 structure. Rewrite.
190b47e6
MR
820 (window_loop): Remove handling of GET_LRU_WINDOW and
821 GET_LARGEST_WINDOW.
822 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
823
824 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
825 window_box_text_cols. delete_all_subwindows now takes a
826 Lisp_Object as argument.
abde8f8c
MR
827
828 * indent.c (compute_motion, Fcompute_motion): Use
829 window_body_cols instead of window_box_text_cols.
830
fa8a67e6
MR
831 * frame.c (delete_frame): Call delete_all_subwindows with root
832 window as argument.
833
a54e3482
DC
8342011-06-07 Daniel Colascione <dan.colascione@gmail.com>
835
836 * fns.c (Fputhash): Document return value.
837
60002bf5
CY
8382011-06-06 Chong Yidong <cyd@stupidchicken.com>
839
840 * image.c (gif_load): Implement gif89a spec "no disposal" method.
841
0c671da6 8422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 843
b862a52a 844 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 845
be44ca6c
PE
846 Check for overflow when converting integer to cons and back.
847 * charset.c (Fdefine_charset_internal, Fdecode_char):
848 Use cons_to_unsigned to catch overflow.
849 (Fencode_char): Use INTEGER_TO_CONS.
850 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
851 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
852 * data.c (long_to_cons, cons_to_long): Remove.
853 (cons_to_unsigned, cons_to_signed): New functions.
854 These signal an error for invalid or out-of-range values.
855 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
856 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
857 * font.c (Ffont_variation_glyphs):
858 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
859 * lisp.h: Include <intprops.h>.
860 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
861 (cons_to_signed, cons_to_unsigned): New decls.
862 (long_to_cons, cons_to_long): Remove decls.
863 * undo.c (record_first_change): Use INTEGER_TO_CONS.
864 (Fprimitive_undo): Use CONS_TO_INTEGER.
865 * xfns.c (Fx_window_property): Likewise.
866 * xselect.c: Include <limits.h>.
867 (x_own_selection, selection_data_to_lisp_data):
868 Use INTEGER_TO_CONS.
869 (x_handle_selection_request, x_handle_selection_clear)
870 (x_get_foreign_selection, Fx_disown_selection_internal)
871 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
872 (lisp_data_to_selection_data): Use cons_to_unsigned.
873 (x_fill_property_data): Use cons_to_signed.
874 Report values out of range.
875
d1f3d2af
PE
876 Check for buffer and string overflow more precisely.
877 * buffer.h (BUF_BYTES_MAX): New macro.
878 * lisp.h (STRING_BYTES_MAX): New macro.
879 * alloc.c (Fmake_string):
880 * character.c (string_escape_byte8):
881 * coding.c (coding_alloc_by_realloc):
882 * doprnt.c (doprnt):
883 * editfns.c (Fformat):
884 * eval.c (verror):
885 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
886 since they may not be the same number.
887 * editfns.c (Finsert_char):
888 * fileio.c (Finsert_file_contents):
889 Likewise for BUF_BYTES_MAX.
890
dd52fcea
PE
891 * image.c: Use ptrdiff_t, not int, for sizes.
892 (slurp_file): Switch from int to ptrdiff_t.
893 All uses changed.
894 (slurp_file): Check that file size fits in both size_t (for
895 malloc) and ptrdiff_t (for sanity and safety).
896
7f9bbdbb
PE
897 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
898 if b->modtime has its maximal value.
899
dfe18f82
PE
900 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
901
84acfcf0
PE
902 Don't assume time_t can fit into int.
903 * buffer.h (struct buffer.modtime): Now time_t, not int.
904 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
905 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
906
ccd9a01a
PE
907 Minor fixes for signed vs unsigned integers.
908 * character.h (MAYBE_UNIFY_CHAR):
909 * charset.c (maybe_unify_char):
910 * keyboard.c (read_char, reorder_modifiers):
911 XINT -> XFASTINT, since the integer must be nonnegative.
912 * ftfont.c (ftfont_spec_pattern):
913 * keymap.c (access_keymap, silly_event_symbol_error):
914 XUINT -> XFASTINT, since the integer must be nonnegative.
915 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
916 since it makes no difference and we prefer signed.
917 * keyboard.c (record_char): Use XUINT when all the neighbors do.
918 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
919 nonnegative.
920
d6d100dd
SM
9212011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
922
923 * window.h (Fwindow_frame): Declare.
924
2b6148e4
PE
9252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
926
927 * alloc.c: Simplify handling of large-request failures (Bug#8800).
928 (SPARE_MEMORY): Always define.
929 (LARGE_REQUEST): Remove.
930 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
931
f230ecc9
MR
9322011-06-06 Martin Rudalics <rudalics@gmx.at>
933
727e958e
MR
934 * lisp.h: Move EXFUNS for Fframe_root_window,
935 Fframe_first_window and Fset_frame_selected_window to window.h.
936
937 * window.h: Move EXFUNS for Fframe_root_window,
938 Fframe_first_window and Fset_frame_selected_window here from
939 lisp.h.
940
941 * frame.c (Fwindow_frame, Fframe_first_window)
942 (Fframe_root_window, Fframe_selected_window)
943 (Fset_frame_selected_window): Move to window.c.
944 (Factive_minibuffer_window): Move to minibuf.c.
945 (Fother_visible_frames_p): New function.
946
947 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
948
f230ecc9
MR
949 * window.c (decode_window, decode_any_window): Move up in code.
950 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
951 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
952 (Fwindow_buffer): Move up and rewrite doc-string.
953 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
954 (Fwindow_prev): New functions.
727e958e
MR
955 (Fwindow_frame): Move here from frame.c. Accept any window as
956 argument.
957 (Fframe_root_window, Fframe_first_window)
958 (Fframe_selected_window): Move here from frame.c. Accept frame
959 or arbitrary window as argument. Update doc-strings.
960 (Fminibuffer_window): Move up in code.
961 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
962 (Fset_frame_selected_window): Move here from frame.c.
963 Marginal rewrite.
727e958e
MR
964 (Fselected_window, select_window, Fselect_window): Move up in
965 code. Minor doc-string fixes.
f230ecc9 966
4d09bcf6
PE
9672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
968
969 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
970 Do not assume that spare memory exists; that assumption is valid
971 only if SYSTEM_MALLOC.
972 (LARGE_REQUEST): New macro, so that the issue of large requests
973 is separated from the issue of spare memory.
974
810928a2
AS
9752011-06-05 Andreas Schwab <schwab@linux-m68k.org>
976
172418ad
AS
977 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
978 format. (Bug#8806)
979
43f862f7
AS
980 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
981
810928a2
AS
982 * xfns.c (x_set_scroll_bar_default_width): Move declarations
983 before statements.
984
a059fe24
JD
9852011-06-05 Jan Djärv <jan.h.d@swipnet.se>
986
987 * gtkutil.c (xg_get_default_scrollbar_width): New function.
988
989 * gtkutil.h: Declare xg_get_default_scrollbar_width.
990
991 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
992 min width by calling x_set_scroll_bar_default_width (Bug#8505).
993
989bf368
JB
9942011-06-05 Juanma Barranquero <lekktu@gmail.com>
995
996 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
997
4b80f674
CY
9982011-06-04 Chong Yidong <cyd@stupidchicken.com>
999
1000 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1001 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1002 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1003 New error handlers.
4b80f674
CY
1004 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1005 Obey Vx_select_enable_clipboard_manager. Catch errors in
1006 x_clipboard_manager_save (Bug#8779).
1007 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1008 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1009
99a33b77 10102011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1011
1012 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1013
99a33b77 10142011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1015
1016 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1017 in the current matrix if keep_current_p is non-zero.
1018
8264569d
EZ
10192011-06-04 Eli Zaretskii <eliz@gnu.org>
1020
1021 * bidi.c (bidi_level_of_next_char): Fix last change.
1022
57f97249
EZ
10232011-06-03 Eli Zaretskii <eliz@gnu.org>
1024
fec2107c 1025 Support bidi reordering of text covered by display properties.
57f97249 1026
fec2107c
EZ
1027 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1028 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1029 (bidi_cache_search, bidi_cache_iterator_state)
1030 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1031 (bidi_level_of_next_char, bidi_move_to_visually_next):
1032 Support character positions inside a run of characters covered by a
fec2107c
EZ
1033 display string.
1034 (bidi_paragraph_init, bidi_resolve_explicit_1)
1035 (bidi_level_of_next_char): Call bidi_fetch_char and
1036 bidi_fetch_char_advance instead of FETCH_CHAR and
1037 FETCH_CHAR_ADVANCE.
1038 (bidi_init_it): Initialize new members.
1039 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1040 definitions.
1041 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1042 instead of using explicit *_CHAR codes.
d6d100dd
SM
1043 (bidi_resolve_explicit, bidi_resolve_weak):
1044 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1045 bidirectional text is supported only in multibyte buffers.
1046 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1047 it to initialize the frame_window_p member of struct bidi_it.
1048 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1049 (bidi_resolve_explicit, bidi_resolve_weak)
1050 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1051 bidi_it->nchars is non-positive.
1052 (bidi_level_of_next_char): Don't try to lookup the cache for the
1053 next/previous character if nothing is cached there yet, or if we
1054 were just reseat()'ed to a new position.
c40e2fb2 1055
0e14fe90
EZ
1056 * xdisp.c (set_cursor_from_row): Set start and stop points
1057 according to the row's direction when priming the loop that looks
1058 for the glyph on which to display cursor.
1059 (single_display_spec_intangible_p): Function deleted.
1060 (display_prop_intangible_p): Reimplement to call
1061 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1062 Accept 3 additional arguments needed by handle_display_spec.
1063 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1064 values: lists, `(when COND...)' forms, etc.
1065 (single_display_spec_string_p): Support property values that are
1066 lists with the argument STRING its top-level element.
1067 (display_prop_string_p): Fix the condition for processing a
1068 property that is a list to be consistent with handle_display_spec.
fec2107c 1069 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1070 last portion of handle_display_prop.
1071 (compute_display_string_pos): Accept additional argument
1072 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1073 value of a `display' property is a "replacing spec".
1074 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1075 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1076 the display property, but just return a value indicating whether
1077 the display property will replace the characters it covers.
1078 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1079 frame_window_p members of struct bidi_it.
d6d100dd
SM
1080 (compute_display_string_pos, compute_display_string_end):
1081 New functions.
fec2107c
EZ
1082 (push_it): Accept second argument POSITION, where pop_it should
1083 jump to continue iteration.
1084 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1085
fec2107c
EZ
1086 * keyboard.c (adjust_point_for_property): Adjust the call to
1087 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1088
1089 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1090 (bidi_init_it): Update prototypes.
1091 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1092 (compute_display_string_pos, compute_display_string_end):
1093 Declare prototypes.
fec2107c
EZ
1094 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1095 EMACS_INT.
fc6f18ce 1096
40087514 10972011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1098
57f53182
PE
1099 Malloc failure behavior now depends on size of allocation.
1100 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1101 * lisp.h: Change signatures accordingly.
1102 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1103 All callers changed. (Bug#8762)
1104
1105 * gnutls.c: Use Emacs's memory allocators.
1106 Without this change, the gnutls library would invoke malloc etc.
1107 directly, which causes problems on non-SYNC_INPUT hosts, and which
1108 runs afoul of improving memory_full behavior. (Bug#8761)
1109 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1110 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1111 xfree instead of the default malloc, realloc, free.
1112 (Fgnutls_boot): No need to check for memory allocation failure,
1113 since xmalloc does that for us.
1114
ac32cd99 1115 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1116 * category.c (hash_get_category_set):
1117 * ccl.c (ccl_driver):
1118 * charset.c (Fdefine_charset_internal):
1119 * charset.h (struct charset.hash_index):
1120 * composite.c (get_composition_id, gstring_lookup_cache)
1121 (composition_gstring_put_cache):
1122 * composite.h (struct composition.hash_index):
1123 * dispextern.h (struct image.hash):
1124 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1125 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1126 (hashfn_equal, hashfn_user_defined, make_hash_table)
1127 (maybe_resize_hash_table, hash_lookup, hash_put)
1128 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1129 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1130 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1131 * image.c (make_image, search_image_cache, lookup_image)
1132 (xpm_put_color_table_h):
1133 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1134 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1135 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1136 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1137 * alloc.c (allocate_vectorlike):
1138 Check for overflow in vector size calculations.
1139 * ccl.c (ccl_driver):
1140 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1141 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1142 need to be updated by these changes.
40087514
PE
1143 * fns.c (make_hash_table, maybe_resize_hash_table):
1144 Check for integer overflow with large hash tables.
0de4bb68
PE
1145 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1146 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1147 (SXHASH_REDUCE): New macro.
1148 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1149 Use it instead of discarding useful hash info with large hash values.
1150 (sxhash_float): New function.
1151 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1152 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1153 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1154 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1155 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1156 Adjust signatures to match updated version of code.
1157 (consing_since_gc): Now EMACS_INT, since a single hash table can
1158 use more than INT_MAX bytes.
1159
698d32e2
DN
11602011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1161
1162 Make it possible to build with GCC-4.6+ -O2 -flto.
1163
1164 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1165
fd6fa53f
SM
11662011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1167
1168 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1169 Call minibuffer-inactive-mode.
1170
864db017
JB
11712011-05-31 Juanma Barranquero <lekktu@gmail.com>
1172
1173 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1174 Update dependencies.
1175
2ad0baf4
DN
11762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1177
1178 * data.c (init_data): Remove code for UTS, this system is not
1179 supported anymore.
1180
4fcc2638
DN
11812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1182
1183 Don't force ./temacs to start in terminal mode.
1184
1185 * frame.c (make_initial_frame): Initialize faces in all cases, not
1186 only when CANNOT_DUMP is defined.
1187 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1188
c56e0fd5
DN
11892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1190
1191 * dispnew.c (add_window_display_history): Use const for the string
1192 pointer. Remove declaration, not needed.
1193
333d54da 11942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1195
55d4c1b2 1196 Use 'inline', not 'INLINE'.
333d54da 1197 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1198 * alloc.c, fontset.c (INLINE): Remove.
1199 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1200 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1201 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1202 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1203 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1204
738db178
DN
12052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1206
1207 Make it possible to run ./temacs.
1208
1209 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1210 syms_of_callproc does the same thing. Remove test for
1211 "initialized", do it in the caller.
1212 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1213
620c53a6
SM
12142011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1215
1216 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1217 (read_minibuf): Use get_minibuffer.
1218 (syms_of_minibuf): Use DEFSYM.
1219 (Qmetadata): New var.
1220 * data.c (Qbuffer): Don't make it static.
1221 (syms_of_data): Use DEFSYM.
1222
e003a292
PE
12232011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1224
1225 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1226 (CCL_CODE_MIN): New macro.
1227
ed008a6d
PE
12282011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1229
3687c2ef
PE
1230 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1231
ed008a6d
PE
1232 * eval.c (Qdebug): Now static.
1233 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1234 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1235 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1236
d66c4c7c
CY
12372011-05-29 Chong Yidong <cyd@stupidchicken.com>
1238
1239 * image.c: Various fixes to ImageMagick code comments.
1240 (Fimagemagick_types): Doc fix.
1241
5fbc2025
PE
12422011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1243
0196f88a
PE
1244 Minor fixes prompted by GCC 4.6.0 warnings.
1245
1246 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1247
5fbc2025
PE
1248 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1249 (x_clipboard_manager_save_all): Move extern decl to ...
1250 * xterm.h: ... here, so that it can be checked for consistency.
1251
1dd3c2d9
CY
12522011-05-29 Chong Yidong <cyd@stupidchicken.com>
1253
1254 * xselect.c (x_clipboard_manager_save_frame)
1255 (x_clipboard_manager_save_all): New functions.
1256 (Fx_clipboard_manager_save): Lisp function deleted.
1257
1258 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1259 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1260
1261 * xterm.h: Update prototype.
1262
5ba6571d
WX
12632011-05-28 William Xu <william.xwl@gmail.com>
1264
1265 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1266 exiting (Bug#8239).
1267
3eaff834
JM
12682011-05-28 Jim Meyering <meyering@redhat.com>
1269
e1900994 1270 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1271 * fns.c (to_uchar): Define.
1272 (crypto_hash_function): Use it to convert some newly-signed
1273 variables to unsigned, to avoid sign-extension bugs. For example,
1274 without this change, (md5 "truc") would evaluate to
1275 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1276 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1277 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1278
0f6990a7
PE
12792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1280
1281 Integer overflow fixes.
c8a9ca5a 1282
08686060
PE
1283 * dbusbind.c: Serial number integer overflow fixes.
1284 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1285 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1286 to hold a serial number that is too large for a fixnum.
1287 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1288 Check for serial numbers out of range. Decode any serial number
59568bf0 1289 that was so large that it became a float. (Bug#8722)
08686060 1290
2d1fc3c7
PE
1291 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1292 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1293 Use XFASTINT rather than XUINT when numbers are nonnegative.
1294 (xd_append_arg, Fdbus_method_return_internal):
1295 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1296 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1297 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1298 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1299 (Bug#8722)
2d1fc3c7 1300
c8a9ca5a
PE
1301 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1302
519e1d69
PE
1303 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1304
30569699
PE
1305 ccl: add integer overflow checks
1306 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1307 (IN_INT_RANGE): New macros.
1308 (ccl_driver): Use them to check for integer overflow when
1309 decoding a CCL program. Many of the new checks are whether XINT (x)
1310 fits in int; it doesn't always, on 64-bit hosts. The new version
1311 doesn't catch all possible integer overflows, but it's an
847044ea 1312 improvement. (Bug#8719)
30569699 1313
c11285dc
PE
1314 * alloc.c (make_event_array): Use XINT, not XUINT.
1315 There's no need for unsigned here.
1316
fdccd48e
PE
1317 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1318 This follows up to the 2011-05-06 change that substituted uintptr_t
1319 for EMACS_INT. This case wasn't caught back then.
1320
37910ab2
PE
1321 Rework Fformat to avoid integer overflow issues.
1322 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1323 now (part of C89). Include <verify.h>.
1324 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1325 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1326 (Fformat): Avoid the prepass trying to compute sizes; it was only
1327 approximate and thus did not catch overflow reliably. Instead, walk
1328 through the format just once, formatting and computing sizes as we go,
1329 checking for integer overflow at every step, and allocating a larger
1330 buffer as needed. Keep track separately whether the format is
1331 multibyte. Keep only the most-recently calculated precision, rather
1332 than them all. Record whether each argument has been converted to
1333 string. Use EMACS_INT, not int, for byte and char and arg counts.
1334 Support field widths and precisions larger than INT_MAX. Avoid
1335 sprintf's undefined behavior with conversion specifications such as %#d
1336 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1337 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1338 formatting out-of-range floating point numbers with int
1339 formats. (Bug#8668)
1340
2e6578fb
PE
1341 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1342
0ae6bdee
PE
1343 * data.c: Avoid integer truncation in expressions involving floats.
1344 * data.c: Include <intprops.h>.
1345 (arith_driver): When there's an integer overflow in an expression
1346 involving floating point, convert the integers to floating point
1347 so that the resulting value does not suffer from catastrophic
1348 integer truncation. For example, on a 64-bit host (* 4
1349 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1350 Do not rely on undefined behavior after integer overflow.
1351
de883a70
PE
1352 merge count_size_as_multibyte, parse_str_to_multibyte
1353 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1354 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1355 Check for integer overflow.
1356 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1357 since it's now a duplicate of the other. This is more of
1358 a character than a buffer op, so better that it's in character.c.
1359 * fns.c, print.c: Adjust to above changes.
1360
2ff916cb
PE
13612011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1362
1363 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1364
f1b54466
PE
13652011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1366
fb1ac845
PE
1367 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1368 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1369 (x_clipboard_manager_save): Now static.
1370 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1371
f1b54466
PE
1372 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1373 (crypto_hash_function): Now static.
1374 Fix pointer signedness problems. Avoid unnecessary initializations.
1375
a9f737ee
CY
13762011-05-27 Chong Yidong <cyd@stupidchicken.com>
1377
1378 * termhooks.h (Vselection_alist): Make it terminal-local.
1379
1380 * terminal.c (create_terminal): Initialize it.
1381
1382 * xselect.c: Support for clipboard managers.
1383 (Vselection_alist): Move to termhooks.h as terminal-local var.
1384 (LOCAL_SELECTION): New macro.
1385 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1386 (symbol_to_x_atom): Remove gratuitous arg.
1387 (x_handle_selection_request, lisp_data_to_selection_data)
1388 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1389 (x_own_selection, x_get_local_selection, x_convert_selection):
1390 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1391 (some_frame_on_display): Delete unused function.
1392 (Fx_own_selection_internal, Fx_get_selection_internal)
1393 (Fx_disown_selection_internal, Fx_selection_owner_p)
1394 (Fx_selection_exists_p): New optional frame arg.
1395 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1396 (x_handle_selection_clear): Don't treat other terminals with the
1397 same keyboard specially. Use the terminal-local Vselection_alist.
1398 (x_clear_frame_selections): Use Frun_hook_with_args.
1399
1400 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1401
1402 * xterm.h: Add support for those atoms.
1403
e067f0c1
CY
14042011-05-26 Chong Yidong <cyd@stupidchicken.com>
1405
1406 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1407 (converted_selections, conversion_fail_tag): New global variables.
1408 (x_selection_request_lisp_error): Free the above.
1409 (x_get_local_selection): Remove unnecessary code.
1410 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1411 of converted selections stored in converted_selections.
1412 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1413 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1414 (x_convert_selection): New function.
1415 (x_handle_selection_event): Simplify.
1416 (x_get_foreign_selection): Don't ignore incoming requests while
1417 waiting for an answer; this will fail when we implement
1418 SAVE_TARGETS, and seems unnecessary anyway.
1419 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1420 (Vx_sent_selection_functions): Doc fix.
1421
0f4aebc0
LL
14222011-05-26 Leo Liu <sdl.web@gmail.com>
1423
1424 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1425
e61124cd
YM
14262011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1427
1428 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1429
1430 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1431 for fringe update if it has periodic bitmap.
1432 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1433 and fringe_bitmap_periodic_p.
1434
1435 * fringe.c (get_fringe_bitmap_data): New function.
1436 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1437 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1438 row. Mark glyph row for fringe update if periodicity changed.
1439
1440 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1441 for fringe update unless it has periodic bitmap.
1442
f16d9837
KH
14432011-05-25 Kenichi Handa <handa@m17n.org>
1444
1445 * xdisp.c (get_next_display_element): Set correct it->face_id for
1446 a static composition.
1447
e1b90ef6
LL
14482011-05-24 Leo Liu <sdl.web@gmail.com>
1449
1450 * deps.mk (fns.o):
1451 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1452
1453 * fns.c (crypto_hash_function, Fsha1): New function.
1454 (Fmd5): Use crypto_hash_function.
1455 (syms_of_fns): Add Ssha1.
1456
7400048f
PE
14572011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1458
1459 * gnutls.c: Remove unused macros.
1460 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1461 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1462 Remove macros that are defined and never used.
1463 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1464
abb71cf4
CY
14652011-05-22 Chong Yidong <cyd@stupidchicken.com>
1466
1467 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1468 (Fx_get_selection_internal): Minor cleanup.
1469 (Fx_own_selection_internal): Rename arguments for consistency with
1470 select.el.
1471
6307db39
PE
14722011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1473
1474 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1475
f3d4e0a4
CY
14762011-05-22 Chong Yidong <cyd@stupidchicken.com>
1477
1478 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1479
4d8ade89
YM
14802011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1481
1482 * dispnew.c (scrolling_window): Don't exclude the case that the
1483 last enabled row in the desired matrix touches the bottom boundary.
1484
32078c8d
GM
14852011-05-21 Glenn Morris <rgm@gnu.org>
1486
1487 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1488 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1489 and add some more files.
32078c8d 1490
7285dc67
EZ
14912011-05-20 Eli Zaretskii <eliz@gnu.org>
1492
1493 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1494 report_file_error introduced by the change from 2011-05-07.
1495
89d1bd22
PE
14962011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 * systime.h (Time): Define only if emacs is defined.
1499 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1500 where the include path doesn't have X11/X.h by default. See
1501 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1502
e23640bb 15032011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1504
1505 * composite.c (find_automatic_composition): Fix previous change.
1506
b9704ad9
GM
15072011-05-20 Glenn Morris <rgm@gnu.org>
1508
1509 * lisp.mk: New file, split from Makefile.in.
1510 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1511 (shortlisp): Remove.
1512 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1513
4a720484
GM
15142011-05-19 Glenn Morris <rgm@gnu.org>
1515
1516 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1517 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1518 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1519 (lisp): Set the order to that of loadup.el.
1520 (shortlisp): Make it a copy of $lisp.
1521 (SOME_MACHINE_LISP): Remove.
1522 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1523 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1524
a28d4396
KH
15252011-05-18 Kenichi Handa <handa@m17n.org>
1526
1527 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1528 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1529 (find_automatic_composition): Mostly rewrite for efficiency.
1530
a2b1fa8e
JB
15312011-05-18 Juanma Barranquero <lekktu@gmail.com>
1532
1533 * makefile.w32-in: Update dependencies.
1534
8e1f5610
CS
15352011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1536
1537 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1538 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1539
7025ee00 15402011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1541
cdfa6eab
PE
1542 Fix some integer overflow issues, such as string length overflow.
1543
06d6db33
PE
1544 * insdel.c (count_size_as_multibyte): Check for string overflow.
1545
2b4560a8
PE
1546 * character.c (lisp_string_width): Check for string overflow.
1547 Use EMACS_INT, not int, for string indexes and lengths; in
1548 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1549 the resulting string length overflows an EMACS_INT; instead,
1550 report a string overflow if no precision given. When checking for
1551 precision exhaustion, use a check that cannot possibly have
1552 integer overflow. (Bug#8675)
1553 * character.h (lisp_string_width): Adjust to new signature.
1554
cb93f9be
PE
1555 * alloc.c (string_overflow): New function.
1556 (Fmake_string): Use it. This doesn't change behavior, but saves
1557 a few bytes and will simplify future changes.
1558 * character.c (string_escape_byte8): Likewise.
1559 * lisp.h (string_overflow): New decl.
1560
1a1f3366
PE
1561 Fixups, following up to the user-interface timestamp change.
1562 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1563 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1564 * msdos.c (mouse_get_pos): Likewise.
1565 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1566 * w32gui.h (Time): Define by including "systime.h" rather than by
1567 declaring it ourselves. (Bug#8664)
1568
d4e3e4d3
PE
1569 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1570 * image.c (clear_image_cache): Likewise.
1571
f6a24d19
PE
1572 * term.c (term_mouse_position): Don't assume time_t wraparound.
1573
08dc5ae6
PE
1574 Be more systematic about user-interface timestamps.
1575 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1576 and sometimes 'EMACS_UINT', to represent these timestamps.
1577 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1578 This makes the code easier to follow, and makes it easier to catch
1579 integer overflow bugs such as Bug#8664.
1580 * frame.c (Fmouse_position, Fmouse_pixel_position):
1581 Use Time, not unsigned long, for user-interface timestamps.
1582 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1583 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1584 * keyboard.h (last_event_timestamp): Likewise.
1585 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1586 * menu.h (xmenu_show): Likewise.
1587 * term.c (term_mouse_position): Likewise.
1588 * termhooks.h (struct input_event.timestamp): Likewise.
1589 (struct terminal.mouse_position_hook): Likewise.
1590 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1591 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1592 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1593 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1594 what it was before.
1595 * menu.h, termhooks.h: Include "systime.h", for Time.
1596
8e55734a
PE
1597 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1598 Don't assume that the difference between two unsigned long values
1599 can fit into an integer. At this point, we know button_down_time
1600 <= event->timestamp, so the difference must be nonnegative, so
1601 there's no need to cast the result if double-click-time is
1602 nonnegative, as it should be; check that it's nonnegative, just in
1603 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1604 apart (about 25 days). (Bug#8664)
8e55734a 1605
841f1b75 1606 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1607 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1608
3e26f69c
PE
1609 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1610 that always fit in int. Use a sentinel instead of a counter, to
1611 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1612 * frame.h (struct frame): Use int for menu_bar_items_used
1613 instead of EMACS_INT, since it always fits in int.
3e26f69c 1614
5cc152c0
PE
1615 * menu.c (grow_menu_items): Check for int overflow.
1616
d89eb65e
PE
1617 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1618
5235bd3e
PE
1619 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1620 Before, the code was not consistent. These values cannot exceed
1621 2**31 - 1 so there's no need to make them unsigned.
1622 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1623 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1624 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1625 as modifiers.
1626 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1627
bc827e23
PE
1628 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1629 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1630 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1631 presumably because the widths might not match.
1632
78eb494e
PE
1633 * window.c (size_window): Avoid needless test at loop start.
1634
04f2d78b
CB
16352011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1636
1637 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1638
d2fc7e3d 16392011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1640
1641 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1642
d2fc7e3d 16432011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1644
1645 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1646 `width' to `bar_area_x' and `bar_area_width', respectively.
1647 (x_scroll_run): Take account of fringe background extension.
1648
04f2d78b
CB
1649 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1650 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1651 `bar_area_width', respectively.
1652 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1653 background extension.
1654
79b70037
GM
16552011-05-10 Jim Meyering <meyering@redhat.com>
1656
1657 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1658
2f142cc5
JB
16592011-05-10 Juanma Barranquero <lekktu@gmail.com>
1660
1661 * image.c (Finit_image_library): Return t for built-in image types,
1662 like pbm and xbm. (Bug#8640)
1663
57679c86
AS
16642011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1665
1666 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1667
888c9e86
EZ
16682011-05-07 Eli Zaretskii <eliz@gnu.org>
1669
b0512a1d
EZ
1670 * w32console.c (Fset_screen_color): Doc fix.
1671 (Fget_screen_color): New function.
1672 (syms_of_ntterm): Defsubr it.
1673
7285dc67
EZ
1674 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1675 unlink the temporary file if Fcall_process didn't create it in the
1676 first place.
1677 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1678 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1679 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1680 cue to call_process_cleanup not to close that handle.
1681
4d3fcc8e
BK
16822011-05-07 Ben Key <bkey76@gmail.com>
1683
1684 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1685 one of two shell specific rules, either bootstrap-temacs-CMD or
1686 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1687 to the previous implementation of the bootstrap-temacs rule.
1688 The bootstrap-temacs-CMD rule is similar to the previous
1689 implementation of the bootstrap-temacs rule except that it
1690 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1691 variable.
1692
1693 These changes, along with some changes to nt/configure.bat,
1694 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1695 earlier fix to add support for --cflags and --ldflags options
1696 that include quotes so that it works whether make uses cmd or
1697 sh as the shell.
1698
b4289b64
MA
16992011-05-06 Michael Albinus <michael.albinus@gmx.de>
1700
1701 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1702 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1703 is a constant.
1704 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1705 a string. Handle both cases.
1706 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1707 (Fdbus_register_method): Use Qinvalid_function.
1708
af4c0e28
JB
17092011-05-06 Juanma Barranquero <lekktu@gmail.com>
1710
1711 * makefile.w32-in: Update dependencies.
1712 (LISP_H): Add inttypes.h and stdin.h.
1713 (PROCESS_H): Add unistd.h.
1714
c51453d9
EZ
17152011-05-06 Eli Zaretskii <eliz@gnu.org>
1716
1717 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1718 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1719
8ff0ac3c 17202011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1721
4c4b566b
PE
1722 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1723
aab2b9b5
PE
1724 * term.c (vfatal): Remove stray call to va_end.
1725 It's not needed and the C Standard doesn't allow it here anyway.
1726
c378da0b
PE
1727 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1728 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1729
288b08c7
PE
1730 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1731 bytes.
1732
e3601888
PE
1733 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1734
db6c0e74
PE
1735 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1736
dd5963ea
PE
1737 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1738
88c9450f
PE
1739 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1740
2f9442b8
PE
1741 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1742
c032b5f8
PE
1743 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1744 * charset.c (Fdefine_charset_internal): Don't initialize
1745 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1746 32-bit int (Bug#8600).
a108c10b
PE
1747
1748 * lread.c (read_integer): Be more consistent with string-to-number.
1749 Use string_to_number to do the actual conversion; this avoids
1750 rounding errors and fixes some other screwups. Without this fix,
1751 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1752 (digit_to_number): Move earlier, for benefit of read_integer.
1753 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1754 not a digit in any supported base. (Bug#8602)
a108c10b 1755
ad5f9eea
PE
1756 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1757
aec1708a
PE
1758 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1759 to match comment at start of function. This also removes a
1760 GCC warning about overflow in a 32+64-bit port.
1761
47be4ab5
PE
1762 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1763
371cac43
PE
1764 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1765 Reported by Stefan Monnier in
1766 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1767 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1768 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1769
d01a7826
PE
1770 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1771 (EMACS_UINTPTR): Likewise, with uintptr_t.
1772
7fd47d5c
PE
1773 * lisp.h: Prefer 64-bit EMACS_INT if available.
1774 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1775 on 32-bit hosts that have 64-bit int, so that they can access
1776 large files.
122b0c86
PE
1777 However, temporarily disable this change unless the temporary
1778 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1779
8727937b
PE
1780 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1781
8ac068ac
PE
1782 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1783 This removes an assumption that EMACS_INT and long are the same
1784 width as pointers. The assumption is true for Emacs porting targets
1785 now, but we want to make other targets possible.
1786 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1787 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1788 In the rest of the code, change types of integers that hold casted
1789 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1790 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1791 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1792 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1793 No need to cast type when ORing.
1794 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1795 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1796 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1797 assume EMACS_INT is the same width as char *.
1798 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1799 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1800 Remove no-longer-needed casts.
1801 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1802 (xg_tool_bar_help_callback, xg_make_tool_item):
1803 Use EMACS_INTPTR to hold an integer
1804 that will be cast to void *; this can avoid a GCC warning
1805 if EMACS_INT is not the same width as void *.
1806 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1807 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1808 (current_message_1, set_message_1):
1809 Use a local to convert to proper width without a cast.
1810 * xmenu.c (dialog_selection_callback): Likewise.
1811
ede49d71
PE
1812 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1813 Also, don't assume VALBITS / RAND_BITS is less than 5,
1814 and don't rely on undefined behavior when shifting a 1 left into
1815 the sign bit.
1816 * lisp.h (get_random): Change signature to match.
1817
2f30ecd0
PE
1818 * lread.c (hash_string): Use size_t, not int, for hash computation.
1819 Normally we prefer signed values; but hashing is special, because
1820 it's better to use unsigned division on hash table sizes so that
1821 the remainder is nonnegative. Also, size_t is the natural width
1822 for hashing into memory. The previous code used 'int', which doesn't
1823 retain enough info to hash well into very large tables.
1824 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1825
2a866e7b
PE
1826 * dbusbind.c: Don't possibly lose pointer info when converting.
1827 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1828 Use XPNTR rather than XHASH, so that the high-order bits of
1829 the pointer aren't lost when converting through void *.
1830
51639eac
PE
1831 * eval.c (Fautoload): Don't double-shift a pointer.
1832
92394119
PE
1833 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1834
dbdb9a7c
JB
18352011-05-06 Juanma Barranquero <lekktu@gmail.com>
1836
1837 * gnutls.c (DEF_GNUTLS_FN):
1838 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1839
db7a0b4f
AS
18402011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1841
1842 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1843 marker. (Bug#8610)
1844
f7ff1b0f 18452011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1846
1847 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1848 New version that can reserve upto 2GB of heap space.
1849
f7ff1b0f 18502011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1851
1852 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1853
639c109b
TZ
18542011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1855
1856 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1857 `gnutls_certificate_set_x509_key_file'.
1858
d2127135
JB
18592011-05-05 Juanma Barranquero <lekktu@gmail.com>
1860
1861 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1862 Update dependencies.
1863
e968f4f3
JB
18642011-05-04 Juanma Barranquero <lekktu@gmail.com>
1865
1866 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1867 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1868 Remove unused parameter `fildes'.
1869 * process.c (read_process_output, send_process): Don't pass it.
1870
84d358f0
JB
18712011-05-04 Juanma Barranquero <lekktu@gmail.com>
1872
1873 Fix previous change: the library cache is defined in w32.c.
1874 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1875 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1876
0898ca10
JB
18772011-05-04 Juanma Barranquero <lekktu@gmail.com>
1878
1879 Implement dynamic loading of GnuTLS on Windows.
1880
1881 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1882 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1883 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1884 Declare.
1885
1886 * gnutls.c (Qgnutls_dll): Define.
1887 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1888 (gnutls_*): Declare function pointers.
1889 (init_gnutls_functions): New function to initialize function pointers.
1890 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1891 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1892 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1893 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1894 (emacs_gnutls_write, emacs_gnutls_read)
1895 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1896 (Fgnutls_available_p): New function.
1897 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1898 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1899 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1900
1901 * image.c: Include w32.h.
1902 (Vimage_type_cache): Delete.
1903 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1904 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1905 (w32_delayed_load): Move to w32.c.
1906
1907 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1908
1909 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1910 (w32_delayed_load): Move from image.c. When loading a library, record
1911 its filename in the :loaded-from property of the library id.
1912 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1913 Initialize and staticpro them.
1914 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1915
1916 * process.c: Include lisp.h before w32.h, not after.
1917 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1918 instead of gnutls_record_check_pending.
1919
1920 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1921
ff4de4aa
TZ
19222011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1923
1924 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1925 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1926 as passed in.
1927
abe95abb
JD
19282011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1929
1930 * xterm.c (x_set_frame_alpha): Do not set property on anything
1931 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1932
e16e55d4
JB
19332011-05-02 Juanma Barranquero <lekktu@gmail.com>
1934
1935 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1936
bafcf6a5
JB
19372011-05-02 Juanma Barranquero <lekktu@gmail.com>
1938
1939 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1940 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1941 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1942 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1943 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1944 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1945 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1946 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1947 (Qgnutls_bootprop_callbacks_verify): Make static.
1948
e7a6747f
AS
19492011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1950
19ed11ba
AS
1951 * callproc.c: Indentation fixup.
1952
e7a6747f 1953 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1954 (wait_for_termination, interruptible_wait_for_termination):
1955 Move after wait_for_termination_1.
e7a6747f 1956
1ef14cb4
LMI
19572011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1958
1959 * sysdep.c (interruptible_wait_for_termination): New function
1960 which is like wait_for_termination, but allows keyboard
1961 interruptions.
1962
1963 * callproc.c (Fcall_process): Add (:file "file") as an option for
1964 the STDOUT buffer.
1965 (Fcall_process_region): Ditto.
1966
330d880c
EZ
19672011-04-30 Eli Zaretskii <eliz@gnu.org>
1968
8db90b73
EZ
1969 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1970 rather than `XVECTOR (FOO)->size'.
1971
330d880c
EZ
1972 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1973 inttypes.h, as a gnulib replacement is used if it not available in
1974 system headers.
1975
15cbd324
EZ
19762011-04-21 Eli Zaretskii <eliz@gnu.org>
1977
1978 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1979 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1980 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1981
1982 * coding.c (coding_alloc_by_realloc): Error out if destination
1983 will grow beyond MOST_POSITIVE_FIXNUM.
1984 (decode_coding_emacs_mule): Abort if there isn't enough place in
1985 charbuf for the composition carryover bytes. Reserve an extra
1986 space for up to 2 characters produced in a loop.
1987 (decode_coding_iso_2022): Abort if there isn't enough place in
1988 charbuf for the composition carryover bytes.
1989
19902011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1991
ae940cca
EZ
1992 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1993 aborting when %lld or %lll format is passed.
1994 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1995 %llo or %llx format is passed. (Bug#8545)
1996
03ab8921
EZ
1997 * window.c (window_scroll_line_based): Use a marker instead of
1998 simple variables to record original value of point. (Bug#7952)
1999
afda1437
EZ
2000 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2001 produced by %s or %c overflows available buffer space. (Bug#8545)
2002
f76dee0c
PE
20032011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2006 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2007
fdc5744d
JB
20082011-04-28 Juanma Barranquero <lekktu@gmail.com>
2009
2010 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2011
638f053a
JB
20122011-04-28 Juanma Barranquero <lekktu@gmail.com>
2013
2014 * keyboard.c (Qdelayed_warnings_hook): Define.
2015 (command_loop_1): Run `delayed-warnings-hook'
2016 if Vdelayed_warnings_list is non-nil.
2017 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2018 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2019
d178f871
EZ
20202011-04-28 Eli Zaretskii <eliz@gnu.org>
2021
2022 * doprnt.c (doprnt): Don't return value smaller than the buffer
2023 size if the message was truncated. (Bug#8545).
2024
b124fd93
JB
20252011-04-28 Juanma Barranquero <lekktu@gmail.com>
2026
2027 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2028 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2029
e810457d
PE
20302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2031
2032 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2033
ea51cceb
JB
20342011-04-27 Juanma Barranquero <lekktu@gmail.com>
2035
2036 * makefile.w32-in: Update dependencies.
2037
94dcfacf
EZ
20382011-04-27 Eli Zaretskii <eliz@gnu.org>
2039
2040 Improve `doprnt' and its usage. (Bug#8545)
2041 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2042 `format_end'. Remove support for %l as a conversion specifier.
2043 Don't use xrealloc. Improve diagnostics when the %l size modifier
2044 is used. Update the commentary.
2045
2046 * eval.c (verror): Simplify calculation of size_t.
2047
2048 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2049 messages.
2050
f61f41d7
PE
20512011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2052
2053 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2054 change.
2055
96fb4434
PE
20562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2057
2058 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2059 This makes this file independent of the recent pseudovector change.
2060
671875da 20612011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2062
69e9b5a3
PE
2063 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2064
b5f869a7 2065 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2066 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2067 Remove unused local.
c8926152 2068 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2069
841a1577 2070 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2071 GCC 4.6.0 optimizes based on type-based alias analysis.
2072 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2073 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2074 != &v->size, and therefore "v->size = 1; b->size = 2; return
2075 v->size;" must therefore return 1. This assumption is incorrect
2076 for Emacs, since it type-puns struct Lisp_Vector * with many other
2077 types. To fix this problem, this patch adds a new type struct
f904488f 2078 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2079 and pseudovectors, and helps optimizing compilers not get fooled
2080 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2081 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2082 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2083 the size member.
eab3844f
PE
2084 (XSETPVECTYPE): Rewrite in terms of new macro.
2085 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2086 This is a bit clearer, and further avoids the possibility of
2087 undesirable aliasing.
2088 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2089 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2090 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2091 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2092 (ASIZE): Now uses header.size rather than size.
2093 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2094 to avoid the hassle of writing XVECTOR (foo)->header.size.
2095 (struct vectorlike_header): New type.
eab3844f
PE
2096 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2097 object, to help avoid aliasing.
2098 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2099 (SUBRP): Likewise, since Lisp_Subr is a special case.
2100 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2101 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2102 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2103 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2104 changed to be "header.size" and "header.next".
2105 * buffer.h (struct buffer): Likewise.
2106 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2107 * frame.h (struct frame): Likewise.
2108 * process.h (struct Lisp_Process): Likewise.
2109 * termhooks.h (struct terminal): Likewise.
2110 * window.c (struct save_window_data, struct saved_window): Likewise.
2111 * window.h (struct window): Likewise.
2112 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2113 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2114 * buffer.c (init_buffer_once): Likewise.
2115 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2116 special case.
2117 * process.c (Fformat_network_address): Use local var for size,
2118 for brevity.
2119
0df1eac5
PE
2120 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2121
847ab9d1 2122 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2123 * data.c (atof): Remove decl; no longer used or needed.
2124 (digit_to_number): Move to lread.c.
2125 (Fstring_to_number): Use new string_to_number function, to be
2126 consistent with how the Lisp reader treats infinities and NaNs.
2127 Do not assume that floating-point numbers represent EMACS_INT
2128 without losing information; this is not true on most 64-bit hosts.
2129 Avoid double-rounding errors, by insisting on integers when
2130 parsing non-base-10 numbers, as the documentation specifies.
2131 * lisp.h (string_to_number): New decl, replacing ...
2132 (isfloat_string): Remove.
bc0a5c13 2133 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2134 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2135 appears to have been a coding error. Similarly, do not accept
2136 strings like +-1e0 as floating point numbers. Do not report
2137 overflow for integer overflows unless the base is not 10 which
2138 means we have no simple and reliable way to continue.
2139 Break out the floating-point parsing into a new
2140 function string_to_number, so that Fstring_to_number parses
2141 floating point numbers consistently with the Lisp reader.
04f2d78b 2142 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2143 (E_CHAR, EXP_INT): Remove, replacing with ...
2144 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2145 (string_to_number): New function, replacing isfloat_string.
2146 This function checks for valid syntax and produces the resulting
2147 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2148 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2149 so that overflow for non-base-10 numbers is reported only when
2150 there's no portable and simple way to convert to floating point.
452f4150 2151
67769ffc
PE
2152 * textprop.c (set_text_properties_1): Rewrite for clarity,
2153 and to avoid GCC warning about integer overflow.
2154
c20db43f
PE
2155 * intervals.h (struct interval): Use EMACS_INT for members
2156 where EMACS_UINT might cause problems. See
2157 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2158 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2159 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2160 All uses changed.
37aa2f85
PE
2161 (offset_intervals): Tell GCC not to worry about length overflow
2162 when negating a negative length.
c20db43f 2163
2538aa2f
PE
2164 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2165 (overrun_check_free): Likewise.
2166
f2d3008d
PE
2167 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2168 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2169 word size.
2170
ec8df744
PE
2171 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2172 (gnutls_make_error): Rename local to avoid shadowing.
2173 (gnutls_emacs_global_deinit): ifdef out; not used.
2174 (Fgnutls_boot): Use const for pointer to readonly storage.
2175 Comment out unused local. Fix pointer signedness problems.
2176
640ee02d
PE
2177 * lread.c (openp): Don't stuff size_t into an 'int'.
2178 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2179 about possible signed overflow.
2180
6048fb2a
PE
2181 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2182 (GDK_KEY_g): Don't define if already defined.
2183 (xg_prepare_tooltip): Avoid pointer signedness problem.
2184 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2185
fa3c87e1
PE
2186 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2187 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2188
2172544b
PE
2189 * xfns.c (Fx_window_property): Simplify a bit,
2190 to make a bit faster and to avoid GCC 4.6.0 warning.
2191 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2192
9b821a21
PE
2193 * fns.c (internal_equal): Don't assume size_t fits in int.
2194
3c616cfa
PE
2195 * alloc.c (compact_small_strings): Tighten assertion a little.
2196
c2982e87
PE
2197 Replace pEd with more-general pI, and fix some printf arg casts.
2198 * lisp.h (pI): New macro, generalizing old pEd macro to other
2199 conversion specifiers. For example, use "...%"pI"d..." rather
2200 than "...%"pEd"...".
2201 (pEd): Remove. All uses replaced with similar uses of pI.
2202 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2203 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2204 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2205 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2206 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2207 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2208 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2209 64-bit hosts.
2210 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2211 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2212 * print.c (safe_debug_print, print_object): Likewise.
2213 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2214 to int.
6f04d126
PE
2215 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2216 avoiding the 0 flag, which is not portable.
c2982e87
PE
2217 * process.c (Fmake_network_process): Use pI to avoid cast.
2218 * region-cache.c (pp_cache): Likewise.
2219 * xdisp.c (decode_mode_spec): Likewise.
2220 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2221 behavior on 64-bit hosts with printf arg.
6f04d126 2222 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2223 (x_stop_queuing_selection_requests): Likewise.
2224 (x_get_window_property): Don't truncate byte count to an 'int'
2225 when tracing.
0b432f21 2226
5e073ec7
PE
2227 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2228 here, since it parses constructs like leading '-' and spaces,
2229 which are not wanted; and it overflows with large numbers.
2230 Instead, simply match F[0-9]+, which is what is wanted anyway.
2231
36372bf9
PE
2232 * alloc.c: Remove unportable assumptions about struct layout.
2233 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2234 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2235 (allocate_vectorlike, make_pure_vector): Use the new macros,
2236 plus offsetof, to remove unportable assumptions about struct layout.
2237 These assumptions hold on all porting targets that I know of, but
2238 they are not guaranteed, they're easy to remove, and removing them
2239 makes further changes easier.
2240
0b432f21
PE
2241 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2242 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2243 (string_overrun_cookie): Now const. Use initializers that
2244 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2245 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2246 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2247 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2248 multiple of sizeof (EMACS_INT); it need not be, if
2249 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2250 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2251
895009e1
JB
22522011-04-26 Juanma Barranquero <lekktu@gmail.com>
2253
2254 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2255
6a7a1b0b
TZ
22562011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2257
2258 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2259 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2260 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2261
841a1577 22622011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2263
2264 * lisp.h (Qdebug): List symbol.
895009e1 2265 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2266 * keyboard.c (debug-on-event): New variable.
2267 (handle_user_signal): Break into debugger when debug-on-event
2268 matches the current signal symbol.
2269
f2d3ba6f
DN
22702011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2271
2272 * alloc.c (check_sblock, check_string_bytes)
2273 (check_string_free_list): Convert to standard C.
2274
42ce4c63
TZ
22752011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2276
2277 * w32.c (emacs_gnutls_push): Fix typo.
2278
825cd63c
EZ
22792011-04-25 Eli Zaretskii <eliz@gnu.org>
2280
fb11d64d
EZ
2281 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2282 "cast to pointer from integer of different size".
2283
825cd63c
EZ
2284 Improve doprnt and its use in verror. (Bug#8545)
2285 * doprnt.c (doprnt): Document the set of format control sequences
2286 supported by the function. Use SAFE_ALLOCA instead of always
2287 using `alloca'.
2288
2289 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2290 is one byte too soon. Don't use xrealloc; instead xfree and
2291 xmalloc anew.
2292
e061a11b
TZ
22932011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2294
2295 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2296 callbacks stage.
2297
2298 * gnutls.c: Renamed global_initialized to
2299 gnutls_global_initialized. Added internals for the
2300 :verify-hostname-error, :verify-error, and :verify-flags
2301 parameters of `gnutls-boot' and documented those parameters in the
2302 docstring. Start callback support.
2303 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2304 unless a fatal error occured. Call gnutls_alert_send_appropriate
2305 on error. Return error code.
2306 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2307 (emacs_gnutls_read): Likewise.
2308 (Fgnutls_boot): Return handshake error code.
2309 (emacs_gnutls_handle_error): New function.
2310 (wsaerror_to_errno): Likewise.
2311
2312 * w32.h (emacs_gnutls_pull): Add prototype.
2313 (emacs_gnutls_push): Likewise.
2314
2315 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2316 (emacs_gnutls_push): Likewise.
2317
23182011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2319
2320 * process.c (wait_reading_process_output): Check if GnuTLS
2321 buffered some data internally if no FDs are set for TLS
2322 connections.
2323
2324 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2325 (LIBS): Link to USER_LIBS.
2326 ($(BLD)/gnutls.$(0)): New target.
2327
fa6996bc
EZ
23282011-04-24 Eli Zaretskii <eliz@gnu.org>
2329
eb35682e
EZ
2330 * xdisp.c (handle_single_display_spec): Rename the
2331 display_replaced_before_p argument into display_replaced_p, to
2332 make it consistent with the commentary. Fix typos in the
2333 commentary.
2334
e2ad650c
EZ
2335 * textprop.c (syms_of_textprop): Remove dead code.
2336 (copy_text_properties): Delete obsolete commentary about an
2337 interface that was deleted long ago. Fix typos in the description
2338 of arguments.
2339
1b2de274
EZ
2340 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2341 to changes in oldXMenu/XMenu.h from 2011-04-16.
2342 <menu_help_message, prev_menu_help_message>: Constify.
2343 (IT_menu_make_room): menu->help_text is now `const char **';
2344 adjust.
2345
2346 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2347 to changes in oldXMenu/XMenu.h from 2011-04-16.
2348 (struct XMenu): Declare `help_text' `const char **'.
2349
2350 * xfaces.c <Qunspecified>: Make extern again.
2351
2352 * syntax.c: Include sys/types.h before including regex.h, as
2353 required by Posix.
2354
762b15be
EZ
2355 * doc.c (get_doc_string): Improve the format passed to `error'.
2356
2357 * doprnt.c (doprnt): Improve commentary.
2358
2359 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2360
2361 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2362 them with etags.
2363
f1052e5d
EZ
2364 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2365 changes in globals.h immediately force recompilation.
762b15be
EZ
2366 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2367 $(CURDIR)/s/ms-w32.h.
2368 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2369
fa6996bc
EZ
2370 * character.c (Fchar_direction): Function deleted.
2371 (syms_of_character): Don't defsubr it.
2372 <char-direction-table>: Deleted.
2373
e6c3da20
EZ
23742011-04-23 Eli Zaretskii <eliz@gnu.org>
2375
2376 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2377 * doprnt.c: Include limits.h.
2378 (SIZE_MAX): New macro.
04f2d78b
CB
2379 (doprnt): Return a size_t value. 2nd arg is now size_t.
2380 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2381 Improve overflow protection. Support `l' modifier for integer
2382 conversions. Support %l conversion. Don't assume an EMACS_INT
2383 argument for integer conversions and for %c.
2384
2385 * lisp.h (doprnt): Restore prototype.
2386
2387 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2388 $(SRC)/character.h.
2389
2390 * Makefile.in (base_obj): Add back doprnt.o.
2391
2392 * deps.mk (doprnt.o): Add back prerequisites.
2393 (callint.o): Depend on character.h.
2394
2395 * eval.c (internal_lisp_condition_case): Include the handler
2396 representation in the error message.
2397 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2398 when breaking from the loop.
2399
2400 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2401
2402 * callint.c (Fcall_interactively): When displaying error message
2403 about invalid control letter, pass the character's codepoint, not
2404 a pointer to its multibyte form. Improve display of the character
2405 in octal and display also its hex code.
2406
2407 * character.c (char_string): Use %x to display the (unsigned)
2408 codepoint of an invalid character, to avoid displaying a bogus
2409 negative value.
2410
2411 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2412 `error', not SYMBOL_NAME itself.
2413
2414 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2415 character arguments to `error'.
2416
2417 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2418 to `error' in error message about FINAL_CHAR argument. Make sure
2419 FINAL_CHAR is a character, and use %c when it is passed as
2420 argument to `error'.
2421
4ffd0d6b 24222011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2423
2424 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2425
2426 * w32.c: Include <time.h>.
2427 (sys_localtime): New function.
2428
4ffd0d6b 24292011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2430
2431 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2432
4ffd0d6b 2433 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2434
4ffd0d6b 24352011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2436
4ffd0d6b
GM
2437 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2438 zombies (Bug#8467).
aac0c6e3 2439
04c56954
EZ
24402011-04-19 Eli Zaretskii <eliz@gnu.org>
2441
2442 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2443 gl_state.e_property when gl_state.object is Qt.
2444
2445 * insdel.c (make_gap_larger): Remove limitation of buffer size
2446 to <= INT_MAX.
2447
16a43933
CY
24482011-04-18 Chong Yidong <cyd@stupidchicken.com>
2449
2450 * xdisp.c (lookup_glyphless_char_display)
2451 (produce_glyphless_glyph): Handle cons cell entry in
2452 glyphless-char-display.
2453 (Vglyphless_char_display): Document it.
2454
2455 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2456 glyphless-char-display.
2457
4581706e
CY
24582011-04-17 Chong Yidong <cyd@stupidchicken.com>
2459
2460 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2461
2462 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2463
2464 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2465 definition for no-X builds.
2466
4887c6e2 24672011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2468
fd35b6f9
PE
2469 Static checks with GCC 4.6.0 and non-default toolkits.
2470
5c1ccb01
PE
2471 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2472
006c5daa
PE
2473 * process.c (keyboard_bit_set): Define only if SIGIO.
2474 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2475 (send_process): Repair possible setjmp clobbering.
2476
efc736d3
PE
2477 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2478
4e2fe2e6
PE
2479 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2480
f97334a2
PE
2481 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2482
4e75f29d
PE
2483 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2484 Define only if needed.
2485
90efadd1
PE
2486 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2487 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2488 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2489
3c647824
PE
2490 * dispextern.h (struct redisplay_interface): Rename param
2491 to avoid shadowing.
e264f262 2492 * termhooks.h (struct terminal): Likewise.
761383f4 2493 * xterm.c (xembed_send_message): Likewise.
3c647824 2494
b58c5c4a
PE
2495 * insdel.c (make_gap_smaller): Define only if
2496 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2497
cad59032
PE
2498 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2499 it.
2500
c339dc2e
PE
2501 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2502 so that we aren't warned about unused symbols.
2503
91a3e27b
PE
2504 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2505
399c71d3 2506 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2507
8ffc96f5
PE
2508 * xfns.c (x_real_positions): Mark locals as initialized.
2509
eef9bc79
PE
2510 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2511
098db9dd
PE
2512 * xterm.c: Fix problems found by static analysis with other toolkits.
2513 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2514 (x_dispatch_event): Declare static if USE_GTK, and
2515 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2516 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2517 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2518 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2519 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2520
eb18f6cc
PE
2521 * xmenu.c (menu_help_callback): Pointer type fixes.
2522 Use const pointers when pointing at readonly data. Avoid pointer
2523 signedness clashes.
2524 (FALSE): Remove unused macro.
2525 (update_frame_menubar): Remove unused decl.
2526
1fe72bf8
PE
2527 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2528
60d9e1db
PE
2529 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2530 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2531 (single_menu_item): Rename local to avoid shadowing.
2532
39261c26
PE
2533 * keyboard.c (make_lispy_event): Remove unused local var.
2534
018c5e19
PE
2535 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2536 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2537
63d2b86e
PE
2538 * bitmaps: Change bitmaps from unsigned char back to the X11
2539 compatible char. Avoid the old compiler warnings about
2540 out-of-range initializers by using, for example, '\xab' rather
2541 than 0xab.
2542
aefd87e1
PE
2543 * xgselect.c (xgselect_initialize): Check vs interface
2544 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2545
bf501fb9
PE
2546 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2547
e9829fdf
PE
2548 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2549 to read-only memory.
2550
1086c095
PE
2551 * fns.c (vector): Remove; this old hack is no longer needed.
2552
2baccd04 2553 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2554 Remove unused var.
dde42981 2555 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2556
72391843 2557 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2558
436c16df 2559 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2560 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2561 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2562
92bb796d 2563 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2564 (x_term_init): Remove local to avoid shadowing.
92bb796d 2565
764430a3 2566 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2567
2568 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2569 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2570
d1dfb56c
EZ
25712011-04-16 Eli Zaretskii <eliz@gnu.org>
2572
c4354cb4
EZ
2573 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2574
d1dfb56c
EZ
2575 Fix regex.c, syntax.c and friends for buffers > 2GB.
2576 * syntax.h (struct gl_state_s): Declare character position members
2577 EMACS_INT.
2578
2579 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2580
04f2d78b
CB
2581 * textprop.c (verify_interval_modification, interval_of):
2582 Declare arguments EMACS_INT.
d1dfb56c
EZ
2583
2584 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2585 EMACS_INT.
2586
2587 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2588
2589 * indent.c (Fvertical_motion): Local variable it_start is now
2590 EMACS_INT.
2591
2592 * regex.c (re_match, re_match_2, re_match_2_internal)
2593 (bcmp_translate, regcomp, regexec, print_double_string)
2594 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2595 (re_compile_pattern, re_exec): Declare arguments and local
2596 variables `size_t' and `ssize_t' and return values `regoff_t', as
2597 appropriate.
2598 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2599 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2600 <compile_stack_type>: `size' and `avail' are now `size_t'.
2601
2602 * regex.h <regoff_t>: Use ssize_t, not int.
2603 (re_search, re_search_2, re_match, re_match_2): Arguments that
2604 specify buffer/string position and length are now ssize_t and
2605 size_t. Return type is regoff_t.
2606
613052cd
BK
26072011-04-16 Ben Key <bkey76@gmail.com>
2608
2609 * nsfont.m: Fixed bugs in ns_get_family and
2610 ns_descriptor_to_entity that were caused by using free to
2611 deallocate memory blocks that were allocated by xmalloc (via
2612 xstrdup). This caused Emacs to crash when compiled with
2613 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2614 --enable-checking=xmallocoverrun). xfree is now used to
2615 deallocate these memory blocks.
2616
4170f62f 26172011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2618
71b41406
PE
2619 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2620
9587a89d
PE
2621 emacs_write: Accept and return EMACS_INT for sizes.
2622 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2623 et seq.
2624 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2625 Accept and return EMACS_INT.
2626 (emacs_gnutls_write): Return the number of bytes written on
2627 partial writes.
2628 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2629 (emacs_read, emacs_write): Remove check for negative size, as the
2630 Emacs source code has been audited now.
9587a89d
PE
2631 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2632 (emacs_read, emacs_write): Use it.
273a5f82
PE
2633 * process.c (send_process): Adjust to the new signatures of
2634 emacs_write and emacs_gnutls_write. Do not attempt to store
2635 a byte offset into an 'int'; it might overflow.
9587a89d 2636 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2637
3e047f51
PE
2638 * sound.c: Don't assume sizes fit in 'int'.
2639 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2640 Return EMACS_INT, not int.
3e047f51 2641 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2642 Accept EMACS_INT, not int.
2643 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2644 record read return values.
2645
cc39a9db
BK
26462011-04-15 Ben Key <bkey76@gmail.com>
2647
c9d0ec6d
JB
2648 * keyboard.c (Qundefined): Don't declare static since it is used
2649 in nsfns.m.
2650 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2651 static since they are used in nsfont.m.
cc39a9db 2652
6c60eb9f
SM
26532011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2654
2655 * process.c (Qprocessp): Don't declare static.
2656 * lisp.h (Qprocessp): Declare again.
2657
7990b61a
JB
26582011-04-15 Juanma Barranquero <lekktu@gmail.com>
2659
2660 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2661
5d4cb038
PE
26622011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2663
8bd7b830 2664 Improve C-level modularity by making more things 'static'.
cd64ea1d 2665
e3b27b31
PE
2666 Don't publish debugger-only interfaces to other modules.
2667 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2668 (verify_bytepos, count_markers): Move decls to the only modules
2669 that need them.
2670 * region-cache.h (pp_cache): Likewise.
2671 * window.h (check_all_windows): Likewise.
2672 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2673
5d4cb038
PE
2674 * sysdep.c (croak): Now static, if
2675 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2676 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2677
2678 * alloc.c (refill_memory_reserve): Now static if
2679 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2680 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2681
e87b6180
PE
2682 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2683 Define only if USE_LUCID.
2684
ac64929e
PE
2685 * xrdb.c (x_customization_string, x_rm_string): Now static.
2686
6f37259d
PE
2687 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2688 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2689
1683e3ab
PE
2690 * xdisp.c (draw_row_with_mouse_face): Now static.
2691 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2692
de9c2632
PE
2693 * window.h (check_all_windows): Mark externally visible.
2694
2b96acb7
PE
2695 * window.c (window_deletion_count): Now static.
2696
2697 * undo.c: Make symbols static if they're not exported.
2698 (last_undo_buffer, last_boundary_position, pending_boundary):
2699 Now static.
2700
50436f33
PE
2701 * textprop.c (interval_insert_behind_hooks): Now static.
2702 (interval_insert_in_front_hooks): Likewise.
2703
64520e5c
PE
2704 * term.c: Make symbols static if they're not exported.
2705 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2706 (max_frame_lines, tty_set_terminal_modes):
2707 (tty_reset_terminal_modes, tty_turn_off_highlight):
2708 (get_tty_terminal): Now static.
2709 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2710 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2711 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2712 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2713 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2714
1fa53021
PE
2715 * sysdep.c: Make symbols static if they're not exported.
2716 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2717 Now static.
2718 (sigprocmask_set, full_mask): Remove; unused.
2719 (wait_debugging): Mark as visible.
2720 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2721 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2722
d4b43b22
PE
2723 * syntax.c (syntax_temp): Define only if !__GNUC__.
2724
b7c513d0
PE
2725 * sound.c (current_sound_device, current_sound): Now static.
2726
989b29ad
PE
2727 * search.c (searchbufs, searchbuf_head): Now static.
2728
13a55a78
PE
2729 * scroll.c (scroll_cost): Remove; unused.
2730 * dispextern.h (scroll_cost): Remove decl.
2731
de68a1fc
PE
2732 * region-cache.h (pp_cache): Mark as externally visible.
2733
40ccffa6
PE
2734 * process.c: Make symbols static if they're not exported.
2735 (process_tick, update_tick, create_process, chan_process):
2736 (Vprocess_alist, proc_buffered_char, datagram_access):
2737 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2738 (deactivate_process): Mark defn as static, as well as decl.
2739 * lisp.h (create_process): Remove decl.
2740 * process.h (chan_process, Vprocess_alist): Remove decls.
2741
ad64fc97
PE
2742 * print.c: Make symbols static if they're not exported.
2743 (print_depth, new_backquote_output, being_printed, print_buffer):
2744 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2745 (print_interval, print_number_index, initial_stderr_stream):
2746 Now static.
2747 * lisp.h (Fprinc): Remove decl.
2748 (debug_output_compilation_hack): Mark as externally visible.
2749
adddb265
PE
2750 * sysdep.c (croak): Move decl from here to syssignal.h.
2751 * syssignal.h (croak): Put it here, so the API can be checked when
2752 'croak' is called from dissociate_if_controlling_tty.
2753
1717ede2
PE
2754 * minibuf.c: Make symbols static if they're not exported.
2755 (minibuf_save_list, choose_minibuf_frame): Now static.
2756 * lisp.h (choose_minibuf_frame): Remove decl.
2757
fa5fb2bc
PE
2758 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2759
1e3890d1
PE
2760 * lread.c: Make symbols static if they're not exported.
2761 (read_objects, initial_obarray, oblookup_last_bucket_number):
2762 Now static.
2763 (make_symbol): Remove; unused.
2764 * lisp.h (initial_obarray, make_symbol): Remove decls.
2765
8a1414fa
PE
2766 * keyboard.c: Make symbols static if they're not exported.
2767 (single_kboard, recent_keys_index, total_keys, recent_keys):
2768 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2769 (this_single_command_key_start, echoing, last_auto_save):
2770 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2771 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2772 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2773 (Vlispy_mouse_stem, double_click_count):
2774 Now static.
2775 (force_auto_save_soon): Define only if SIGDANGER.
2776 (ignore_mouse_drag_p): Now static if
2777 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2778 (print_help): Remove; unused.
2779 (stop_character, last_timer_event): Mark as externally visible.
2780 * keyboard.h (ignore_mouse_drag_p): Declare only if
2781 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2782 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2783 * lisp.h (echoing): Remove decl.
2784 (force_auto_save_soon): Declare only if SIGDANGER.
2785 * xdisp.c (redisplay_window): Simplify code, to make it more
2786 obvious that ignore_mouse_drag_p is not accessed if !defined
2787 USE_GTK && !defined HAVE_NS.
2788
93ea6e8f
PE
2789 * intervals.c: Make symbols static if they're not exported.
2790 (merge_properties_sticky, merge_interval_right, delete_interval):
2791 Now static.
2792 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2793
77382fcc
PE
2794 * insdel.c: Make symbols static if they're not exported.
2795 However, leave prepare_to_modify_buffer alone. It's never
2796 called from outside this function, but that appears to be a bug.
2797 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2798 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2799 (adjust_after_replace_noundo): Remove; unused.
2800 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2801 (signal_before_change): Remove decls.
77382fcc 2802
9306c32e
PE
2803 * indent.c (val_compute_motion, val_vmotion): Now static.
2804
cd44d2eb
PE
2805 * image.c: Make symbols static if they're not exported.
2806 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2807 if USE_GTK.
2808 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2809 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2810
ad9a7a06
PE
2811 * fringe.c (standard_bitmaps): Now static.
2812 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2813
81626931
PE
2814 * frame.c: Make symbols static if they're not exported.
2815 (x_report_frame_params, make_terminal_frame): Now static.
2816 (get_frame_param): Now static, unless HAVE_NS.
2817 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2818 (x_get_resource_string): Remove; not used.
2819 * frame.h (make_terminal_frame, x_report_frame_params):
2820 (x_get_resource_string); Remove decls.
2821 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2822 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2823
239f9db9
PE
2824 * font.c, fontset.c: Make symbols static if they're not exported.
2825 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2826 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2827 * font.c (font_close_object): Now static.
2828 * font.h (font_close_object): Remove.
2829 * fontset.c (FONTSET_OBJLIST): Remove.
2830 (free_realized_fontset) #if-0 the body, which does nothing.
2831 (face_suitable_for_char_p): #if-0, as it's never called.
2832 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2833 * xfaces.c (face_at_string_position):
2834 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2835 since 0 is always ASCII.
2836
dfcf3579
PE
2837 * fns.c (weak_hash_tables): Now static.
2838
5045092b
PE
2839 * fileio.c: Make symbols static if they're not exported.
2840 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2841 (Vwrite_region_annotation_buffers): Now static.
2842
57a96f5c
PE
2843 * eval.c: Make symbols static if they're not exported.
2844 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2845 * lisp.h (backtrace_list): Remove decl.
2846
35f08c38
PE
2847 * emacs.c: Make symbols static if they're not exported.
2848 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2849 (fatal_error_code, fatal_error_signal_hook, standard_args):
2850 Now static.
2851 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2852 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2853 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2854 * lisp.h (fatal_error_signal_hook): Remove decl.
2855 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2856
f44bd759
PE
2857 * editfns.c: Move a (normally-unused) function to its only use.
2858 * editfns.c, lisp.h (get_operating_system_release): Remove.
2859 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2860 worth the hassle of breaking this out.
2861
b532497d
PE
2862 * xterm.c: Make symbols static if they're not exported.
2863 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2864 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2865 (x_destroy_window, x_delete_display):
2866 Now static.
2867 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2868 (x_mouse_leave): Remove; unused.
2869 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2870 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2871 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2872 Remove decls.
2873 (x_mouse_leave): Declare only if WINDOWSNT.
2874 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2875 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2876 USE_X_TOOLKIT.
2877
1675728f
PE
2878 * ftxfont.c: Make symbols static if they're not exported.
2879 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2880 HAVE_FREETYPE.
2881 * font.h (ftxfont_driver): Likewise.
2882
e4cebfca
PE
2883 * xfns.c: Make symbols static if they're not exported.
2884 (x_last_font_name, x_display_info_for_name):
2885 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2886 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2887 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2888 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2889 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2890 (last_show_tip_args): Now static.
2891 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2892 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2893 (x_screen_planes): Remove; unused.
2894 * dispextern.h (x_screen_planes): Remove decl.
2895
5bf46f05
PE
2896 * dispnew.c: Make symbols static if they're not exported.
2897 * dispextern.h (redraw_garbaged_frames, scrolling):
2898 (increment_row_positions): Remove.
2899 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2900 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2901 Now static.
2902 (redraw_garbaged_frames): Remove; unused.
2903
435f4c28
PE
2904 * xfaces.c: Make symbols static if they're not exported.
2905 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2906 Remove decls.
2907 * xterm.h (defined_color): Remove decls.
2908 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2909 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2910 (menu_face_changed_default, defined_color, free_realized_face):
2911 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2912 (ascii_face_of_lisp_face): Remove; unused.
2913
8524aef3
PE
2914 * xdisp.c: Make symbols static if they're not exported.
2915 * dispextern.h (scratch_glyph_row, window_box_edges):
2916 (glyph_to_pixel_coords, set_cursor_from_row):
2917 (get_next_display_element, set_iterator_to_next):
2918 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2919 (show_mouse_face): Remove decls
2920 * frame.h (message_buf_print): Likewise.
2921 * lisp.h (pop_message, set_message, check_point_in_composition):
2922 Likewise.
2923 * xterm.h (set_vertical_scroll_bar): Likewise.
2924 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2925 (message_buf_print, scratch_glyph_row, displayed_buffer):
2926 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2927 (get_next_display_element, show_mouse_face, window_box_edges):
2928 (frame_to_window_pixel_xy, check_point_in_composition):
2929 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2930 (glyph_to_pixel_coords): Remove; unused.
2931
16390cd2
PE
2932 * dired.c (file_name_completion): Now static.
2933
2934 * dbusbind.c (xd_in_read_queued_messages): Now static.
2935
a25f4dfa
PE
2936 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2937 * data.c (circular_list_error): Remove.
2938
14a9c8df
PE
2939 * commands.h (last_point_position, last_point_position_buffer):
2940 (last_point_position_window): Remove decls.
2941 * keyboard.c: Make these variables static.
2942
04f2d78b
CB
2943 * coding.h (coding, code_convert_region, encode_coding_gap):
2944 Remove decls.
74ab6df5
PE
2945 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2946 (iso_code_class, detect_coding, code_convert_region): Now static.
2947 (encode_coding_gap): Remove; unused.
2948
38dfbee1
PE
2949 * chartab.c (chartab_chars, chartab_bits): Now static.
2950
a2cb4e63
PE
2951 * charset.h (charset_iso_8859_1): Remove decl.
2952 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2953 Now static.
2954
127198fd
PE
2955 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2956 * ccl.c (Vccl_program_table): Now static.
2957 (check_ccl_update): Remove; unused.
2958
d85b608f
PE
2959 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2960 * category.h: ... from here.
2961 * category.c (check_category_table, set_category_set): Now static.
2962
31cd66f3
PE
2963 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2964 * lisp.h: Remove these decls.
2965
c358e587
PE
2966 * buffer.c (buffer_count): Remove unused var.
2967
e78aecca
PE
2968 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2969 so that it's not optimized away.
2970 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2971 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2972 exported only to the debugger.
2973
e192d7d3 2974 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2975 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2976
92470028
PE
2977 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2978 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2979 was inaccessible from Lisp.
2980 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2981 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2982
244ed907
PE
2983 alloc.c: Import and export fewer symbols, and remove unused items.
2984 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2985 is defined.
2986 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2987 it's not optimized away by whole-program optimization.
2988 (message_enable_multibyte, free_misc): Remove.
2989 (catchlist, handlerlist, mark_backtrace):
2990 Declare only if BYTE_MARK_STACK.
2991 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2992 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2993 (message_enable_multibyte): Remove decl.
2994 (free_misc, interval_free_list, float_block, float_block_index):
2995 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2996 (cons_free_list, last_marked_index):
2997 Now static.
2998 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2999 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3000 (mark_backtrace): Define only if BYTE_MARK_STACK.
3001 * xdisp.c (message_enable_multibyte): Now static.
3002
61c2b50e 3003 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3004 This makes it easier for human readers (and static analyzers)
3005 to see whether these variables are used from other modules.
3006 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3007 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3008 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3009 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3010 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3011 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3012 * xmenu.c, xselect.c:
3013 Declare Q* vars static if they are not used in other modules.
3014 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3015 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3016 Remove decls of unexported vars.
3017 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3018
95c82688
PE
3019 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3020
16a97296
PE
3021 Make Emacs functions such as Fatom 'static' by default.
3022 This makes it easier for human readers (and static analyzers)
3023 to see whether these functions can be called from other modules.
3024 DEFUN now defines a static function. To make the function external
3025 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3026 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3027 (Finit_image_library):
16a97296
PE
3028 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3029 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3030 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3031 Remove decls, since these functions are now static.
3032 (Funintern, Fget_internal_run_time): New decls, since these functions
3033 were already external.
95c82688 3034
16a97296
PE
3035 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3036 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3037 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3038 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3039 * keyboard.c, keymap.c, lread.c:
3040 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3041 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3042 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3043 Mark functions with DEFUE instead of DEFUN,
3044 if they are used in other modules.
3045 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3046 decls for now-static functions.
3047 * buffer.h (Fdelete_overlay): Remove decl.
3048 * callproc.c (Fgetenv_internal): Mark as internal.
3049 * composite.c (Fremove_list_of_text_properties): Remove decl.
3050 (Fcomposition_get_gstring): New forward static decl.
3051 * composite.h (Fcomposite_get_gstring): Remove decl.
3052 * dired.c (Ffile_attributes): New forward static decl.
3053 * doc.c (Fdocumntation_property): New forward static decl.
3054 * eval.c (Ffetch_bytecode): New forward static decl.
3055 (Funintern): Remove extern decl; now in .h file where it belongs.
3056 * fileio.c (Fmake_symbolic_link): New forward static decl.
3057 * image.c (Finit_image_library): New forward static decl.
3058 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3059 * intervals.h (Fprevious_property_change):
3060 (Fremove_list_of_text_properties): Remove decls.
3061 * keyboard.c (Fthis_command_keys): Remove decl.
3062 (Fcommand_execute): New forward static decl.
3063 * keymap.c (Flookup_key): New forward static decl.
3064 (Fcopy_keymap): Now static.
3065 * keymap.h (Flookup_key): Remove decl.
3066 * process.c (Fget_process): New forward static decl.
3067 (Fprocess_datagram_address): Mark as internal.
3068 * syntax.c (Fsyntax_table_p): New forward static decl.
3069 (skip_chars): Remove duplicate decl.
3070 * textprop.c (Fprevious_property_change): New forward static decl.
3071 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3072 Now internal.
3073 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3074 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3075
785bbd42
PE
3076 * editfns.c (Fformat): Remove unreachable code.
3077
8b913b57
AS
30782011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3079
3080 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3081 change. (Bug#8496)
3082
a6744a35
EZ
30832011-04-13 Eli Zaretskii <eliz@gnu.org>
3084
3085 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3086 when at ZV. (Bug#8487)
3087
e7974947
AS
30882011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3089
baad03f0
AS
3090 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3091 (Bug#8437)
3092 * keyboard.c (parse_tool_bar_item): Likewise.
3093 * sound.c (sound_cleanup, alsa_close): Likewise.
3094 * termcap.c (tgetent): Likewise.
3095 * xfns.c (x_default_font_parameter): Likewise.
3096 * xsettings.c (read_and_apply_settings): Likewise.
3097
e7974947
AS
3098 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3099 (overrun_check_free): Protoize.
3100
28272684
PE
31012011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3102
3103 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3104 since callers should never pass a negative size.
3105 Change the signature to match that of plain 'read' and 'write'; see
3106 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3107 * lisp.h: Update prototypes of emacs_write and emacs_read.
3108
11997c76
EZ
31092011-04-11 Eli Zaretskii <eliz@gnu.org>
3110
3111 * xdisp.c (redisplay_window): Don't try to determine the character
3112 position of the scroll margin if the window start point w->startp
e896f03c 3113 is outside the buffer's accessible region. (Bug#8468)
11997c76 3114
8a2cbd72
EZ
31152011-04-10 Eli Zaretskii <eliz@gnu.org>
3116
3117 Fix write-region and its subroutines for buffers > 2GB.
3118 * fileio.c (a_write, e_write): Modify declaration of arguments and
3119 local variables to support buffers larger than 2GB.
3120 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3121
3122 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3123 argument, local variables, and return value.
3124
3125 * lisp.h: Update prototypes of emacs_write and emacs_read.
3126
3127 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3128
4073e537 31292011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3130
1ebfdcb6
PE
3131 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3132
b2ded58d
PE
3133 Fix more problems found by GCC 4.6.0's static checks.
3134
7d66342c
PE
3135 * xdisp.c (vmessage): Use a better test for character truncation.
3136
bbf47d44
PE
3137 * charset.c (load_charset_map): <, not <=, for optimization,
3138 and to avoid potential problems with integer overflow.
9248994d 3139 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3140 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3141 * editfns.c (Fformat): Likewise.
1e69125e 3142 * syntax.c (skip_chars): Likewise.
3befa583 3143
e3019616
PE
3144 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3145 This also lets GCC 4.6.0 generate slightly better loop code.
3146
becfa255
PE
3147 * callint.c (Fcall_interactively): <, not <=, for optimization.
3148 (Fcall_interactively): Count the number of arguments produced,
3149 not the number of arguments given. This is simpler and lets GCC
3150 4.6.0 generate slightly better code.
3151
dae0cd48
PE
3152 * ftfont.c: Distingish more carefully between FcChar8 and char.
3153 The previous code passed unsigned char * to a functions like
3154 strlen and xstrcasecmp that expect char *, which does not
3155 conform to the C standard.
3156 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3157 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3158 char * when the C standard requires it.
3159
76032d70
PE
3160 * keyboard.c (read_char): Remove unused var.
3161
eb3f1cc8
PE
3162 * eval.c: Port to Windows vsnprintf (Bug#8435).
3163 Include <limits.h>.
3164 (SIZE_MAX): Define if the headers do not.
3165 (verror): Do not give up if vsnprintf returns a negative count.
3166 Instead, grow the buffer. This ports to Windows vsnprintf, which
3167 does not conform to C99. Problem reported by Eli Zaretskii.
3168 Also, simplify the allocation scheme, by avoiding the need for
3169 calling realloc, and removing the ALLOCATED variable.
3170
70476b54
PE
3171 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3172
12020a9e
PE
3173 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3174 But keep the doprint source code for now, as we might revamp it
3175 and use it again (Bug#8435).
ea6c7ae6
PE
3176 * lisp.h (doprnt): Remove.
3177 * Makefile.in (base_obj): Remove doprnt.o.
3178 * deps.mk (doprnt.o): Remove.
3179
5fdb398c
PE
3180 error: Print 32- and 64-bit integers portably (Bug#8435).
3181 Without this change, on typical 64-bit hosts error ("...%d...", N)
3182 was used to print both 32- and 64-bit integers N, which relied on
3183 undefined behavior.
3184 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3185 New macro.
3186 * lisp.h (error, verror): Mark as printf-like functions.
3187 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3188 Report overflow in size calculations when allocating printf buffer.
3189 Do not truncate output string at its first null byte.
3190 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3191 Truncate the output at a character boundary, since vsnprintf does not
3192 do that.
3193 * charset.c (check_iso_charset_parameter): Convert internal
3194 character to string before calling 'error', since %c now has the
3195 printf meaning.
3196 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3197 overflow when computing char to be passed to 'error'. Do not
3198 pass Lisp_Object to 'error'; pass the integer instead.
3199 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3200 formatted with plain %d.
3201
b189fa66
PE
3202 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3203
bff87ef0
PE
3204 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3205
7e2cac20
PE
3206 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3207
ce4d90b5
PE
3208 * xterm.c (x_catch_errors): Remove duplicate declaration.
3209
266c9547
PE
3210 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3211
79c49ad2
PE
3212 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3213
368f4090
JM
32142011-04-10 Jim Meyering <meyering@redhat.com>
3215
3216 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3217 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3218 return ssize_t not "int", and use size_t as the buffer length.
3219 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3220 * gnutls.h: Update declarations.
3221 * process.c (read_process_output): Use ssize_t, to match.
3222 (send_process): Likewise.
3223
a32d4040
CY
32242011-04-09 Chong Yidong <cyd@stupidchicken.com>
3225
3226 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3227
8546720e 32282011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3229
04f2d78b
CB
3230 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3231 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3232
8546720e
GM
3233 * xterm.c (handle_one_xevent):
3234 * xmenu.c (create_and_show_popup_menu):
3235 * xselect.c (x_decline_selection_request)
3236 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3237
0a2f5c1a 32382011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3239
3240 Fix some uses of `int' instead of EMACS_INT.
3241 * search.c (string_match_1, fast_string_match)
3242 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3243 (scan_buffer, find_next_newline_no_quit)
3244 (find_before_next_newline, search_command, Freplace_match)
3245 (Fmatch_data): Make some `int' variables be EMACS_INT.
3246
3247 * xdisp.c (display_count_lines): 3rd argument and return value now
3248 EMACS_INT. All callers changed.
3249 (pint2hrstr): Last argument is now EMACS_INT.
3250
3251 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3252 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3253 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3254 (decode_coding_utf_16, decode_coding_emacs_mule)
3255 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3256 (decode_coding_ccl, decode_coding_charset)
3257 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3258 (decode_coding_iso_2022, decode_coding_emacs_mule)
3259 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3260 <char_offset, last_offset>: Declare EMACS_INT.
3261 (encode_coding_utf_8, encode_coding_utf_16)
3262 (encode_coding_emacs_mule, encode_invocation_designation)
3263 (encode_designation_at_bol, encode_coding_iso_2022)
3264 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3265 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3266 Declare EMACS_INT.
3267 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3268 (encode_invocation_designation): Last argument P_NCHARS is now
3269 EMACS_INT.
3270 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3271 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3272
3273 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3274 All users changed.
3275
3276 * ccl.c (Fccl_execute_on_string): Declare some variables
3277 EMACS_INT.
3278
8546720e 32792011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3280
3281 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3282
4e19a977
CS
32832011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3284
3285 * process.c (Fformat_network_address): Doc fix.
3286
87302331
R
32872011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3288
3289 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3290
cbb59342
CY
32912011-04-08 Chong Yidong <cyd@stupidchicken.com>
3292
3293 * keyboard.c (read_char): Call Lisp function help-form-show,
3294 instead of using internal_with_output_to_temp_buffer.
3295 (Qhelp_form_show): New var.
e0d38eeb 3296 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3297
3298 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3299
3300 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3301
e67a13ab
CY
33022011-04-06 Chong Yidong <cyd@stupidchicken.com>
3303
04f2d78b
CB
3304 * process.c (Flist_processes): Remove to Lisp.
3305 (list_processes_1): Delete.
e67a13ab 3306
973f782d
EZ
33072011-04-06 Eli Zaretskii <eliz@gnu.org>
3308
7c106b1e
EZ
3309 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3310
973f782d
EZ
3311 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3312
41cf7d1a 33132011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3314
ca23cc88
PE
3315 Fix more problems found by GCC 4.6.0's static checks.
3316
f390e2d5
PE
3317 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3318
42eea0d0
PE
3319 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3320
b69769da 3321 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3322
f9541e84
PE
3323 * xdisp.c (vmessage): Mark as a printf-like function.
3324
13841b55
PE
3325 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3326
c136c10f
PE
3327 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3328
5e2d4a30
PE
3329 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3330 printf-like functions.
3331 (tiff_load): Add casts to remove these marks before passing them
3332 to system-supplied API.
3333
583f48b9
PE
3334 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3335
b25d760e
PE
3336 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3337 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3338 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3339 directly, rather than having caller test rule sign. This avoids
3340 some unnecessary tests.
3341 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3342 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3343 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3344
bc7b6697 3345 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3346 (xfont_open): Avoid unnecessary tests.
bc7b6697 3347
27ccc379
PE
3348 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3349
dcd5c89a
PE
3350 * composite.h, composite.c (composition_gstring_put_cache):
3351 Use EMACS_INT, not int, for length.
3352
b13a45c6
PE
3353 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3354 breaking out part of COMPOSITION_DECODE_RULE.
3355 (COMPOSITION_DECODE_RULE): Use it.
3356 * composite.c (get_composition_id): Remove unused local vars,
3357 by using the new macro.
3358
1e792e4d
PE
3359 * textprop.c (set_text_properties_1): Change while to do-while,
3360 since the condition is always true at first.
3361
dc6c6455 3362 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3363 (interval_deletion_adjustment): Return unsigned value.
3364 All uses changed.
dc6c6455 3365
aba7731a
PE
3366 * process.c (list_processes_1, create_pty, read_process_output):
3367 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3368 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3369 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3370 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3371 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3372
fdfc4bf3
PE
3373 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3374
fca8fe46 3375 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3376 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3377
06a0259a 3378 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3379 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3380 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3381
e7b9e80f
PE
3382 * print.c (print_error_message): Avoid int overflow.
3383
56201685
PE
3384 * font.c (font_list_entities): Redo for clarity,
3385 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3386
78834453 3387 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3388 (font_score): Avoid potential overflow in diff calculation.
78834453 3389
0bc0b309 3390 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3391 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3392
e610eaca
PE
3393 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3394
b895abce
PE
3395 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3396 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3397 can always succeed if overflow has undefined behavior.
3398
1f1d9321 3399 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3400 (wordify): Omit three unnecessary tests.
1f1d9321 3401
c59478bc
PE
3402 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3403 All callers changed. This avoids the need for an unused var.
3404
79b73827
PE
3405 * casefiddle.c (casify_region): Remove var that is set but not used.
3406
a4db5dfe
PE
3407 * dired.c (file_name_completion): Remove var that is set but not used.
3408
43aae36e
PE
3409 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3410
2a47c44d 3411 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3412 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3413
a37c69bf
PE
3414 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3415 Check for integer overflow on size calculations.
3416
328ab8e7
PE
3417 * buffer.c (Fprevious_overlay_change): Remove var that is set
3418 but not used.
3419
e5a2a5cb
PE
3420 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3421 Remove vars that are set but not used.
8d84a6eb 3422 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3423 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3424
a60e5f68
PE
3425 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3426
f661cb61 3427 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3428 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3429
f0397f5a
PE
3430 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3431 that are set but not used.
3432
8664db06 3433 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3434 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3435
6abdaa4a
PE
3436 * xselect.c (x_get_local_selection, x_handle_property_notify):
3437 Remove vars that are set but not used.
3438
0ce7538d 3439 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3440 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3441
9ae848fc
PE
3442 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3443 Remove var that is set but not used.
0b918413
PE
3444 (scroll_bar_windows_size): Now size_t, not int.
3445 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3446 Check for overflow.
9ae848fc 3447
a5a62657
PE
3448 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3449 (map_tty_color) [!defined MSDOS]: Likewise.
3450
5c5cdd39
PE
3451 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3452
66ebf983
PE
3453 * coding.c: Remove vars that are set but not used.
3454 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3455 All callers changed.
3456 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3457 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3458 (decode_coding_charset): Remove vars that are set but not used.
3459
1be4d761
PE
3460 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3461 that is set but not used.
3462
47553fa8
PE
3463 * print.c (print_object): Remove var that is set but not used.
3464
1f7196bf 3465 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3466 The gnulib version avoids calling malloc in the usual case,
3467 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3468 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3469 * filelock.c (current_lock_owner): Likewise.
3470 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3471 * sysdep.c: Include allocator.h, careadlinkat.h.
3472 (emacs_no_realloc_allocator): New static constant.
3473 (emacs_readlink): New function.
fdb61804
PE
3474 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3475 ../lib/careadlinkat.h.
d1fdcab7 3476
f84c17c7
SM
34772011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3478
3479 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3480 first non-nil return value).
3481
ef3862ad
JD
34822011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3483
3484 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3485 if not defined (Bug#8403).
3486
376a7006
JB
34872011-04-02 Juanma Barranquero <lekktu@gmail.com>
3488
3489 * xdisp.c (display_count_lines): Remove parameter `start',
3490 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3491 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3492 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3493 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3494 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3495 and thereabouts. All callers changed.
3496 (get_per_char_metric): Remove parameter `f', unused since
3497 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3498
6ca3801d
JM
34992011-04-02 Jim Meyering <meyering@redhat.com>
3500
3501 do not dereference NULL upon failed strdup
3502 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3503 (ns_get_family): Likewise.
3504
d8e2b5ba
JB
35052011-04-02 Juanma Barranquero <lekktu@gmail.com>
3506
3507 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3508
8c74fcbd
JD
35092011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3510
3511 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3512 later (Bug#8403).
3513
7200d79c
SM
35142011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3515
03408648 3516 Add lexical binding.
7200d79c 3517
03408648
SM
3518 * window.c (Ftemp_output_buffer_show): New fun.
3519 (Fsave_window_excursion):
3520 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3521
3522 * lread.c (lisp_file_lexically_bound_p): New function.
3523 (Fload): Bind Qlexical_binding.
3524 (readevalloop): Remove `evalfun' arg.
3525 Bind Qinternal_interpreter_environment.
3526 (Feval_buffer): Bind Qlexical_binding.
3527 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3528 Mark as dynamic.
3529 (syms_of_lread): Declare `lexical-binding'.
3530
3531 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3532
3533 * keyboard.c (eval_dyn): New fun.
3534 (menu_item_eval_property): Use it.
ca105506
SM
3535
3536 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3537
03408648
SM
3538 * fns.c (concat, mapcar1): Accept byte-code-functions.
3539
3540 * eval.c (Fsetq): Handle lexical vars.
3541 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3542 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3543 (FletX, Flet): Obey lexical binding.
3544 (Fcommandp): Handle closures.
3545 (Feval): New `lexical' arg.
3546 (eval_sub): New function extracted from Feval. Use it almost
3547 everywhere where Feval was used. Look up vars in lexical env.
3548 Handle closures.
3549 (Ffunctionp): Move from subr.el.
3550 (Ffuncall): Handle closures.
3551 (apply_lambda): Remove `eval_flags'.
3552 (funcall_lambda): Handle closures and new byte-code-functions.
3553 (Fspecial_variable_p): New function.
3554 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3555 but without exporting it to Lisp.
23aba0ea 3556
23aba0ea 3557 * doc.c (Fdocumentation, store_function_docstring):
03408648 3558 * data.c (Finteractive_form): Handle closures.
23aba0ea 3559
03408648
SM
3560 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3561 interactive spec.
ba83908c 3562
04f2d78b
CB
3563 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3564 New byte-codes.
03408648
SM
3565 (exec_byte_code): New function extracted from Fbyte_code to handle new
3566 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3567
03408648 3568 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3569
03408648 3570 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3571
e2abce01
JB
35722011-03-31 Juanma Barranquero <lekktu@gmail.com>
3573
3574 * xdisp.c (redisplay_internal): Fix prototype.
3575
63696a73 35762011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3577
63696a73 3578 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3579 (try_scrolling): Use it when setting scroll_limit.
3580 Limit scrolling to 100 screen lines.
63696a73
EZ
3581 (redisplay_window): Even when falling back on "recentering",
3582 position point in the window according to scroll-conservatively,
3583 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3584
3585 (try_scrolling): When point is above the window, allow searching
3586 as far as scroll_max, or one screenful, to compute vertical
3587 distance from PT to the scroll margin position. This prevents
3588 try_scrolling from unnecessarily failing when
3589 scroll-conservatively is set to a value slightly larger than the
3590 window height. Clean up the case of PT below the margin at bottom
3591 of window: scroll_max can no longer be INT_MAX. When aggressive
3592 scrolling is in use, don't let point enter the opposite scroll
3593 margin as result of the scroll.
3594 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3595 threshold of 100 lines for never-recentering scrolling.
3596
e4cc2dfc
JB
35972011-03-31 Juanma Barranquero <lekktu@gmail.com>
3598
3599 * dispextern.h (move_it_by_lines):
3600 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3601 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3602 (message_log_check_duplicate): Remove parameters `prev_bol' and
3603 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3604 (redisplay_internal): Remove parameter `preserve_echo_area',
3605 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3606
3607 * indent.c (Fvertical_motion):
3608 * window.c (window_scroll_pixel_based, Frecenter):
3609 Don't pass `need_y_p' to `move_it_by_lines'.
3610
1c470562
SM
36112011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3612
44f230aa
SM
3613 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3614 steal a few bits to be more compact.
3615 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3616 Remove unneeded casts.
3617
1c470562
SM
3618 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3619
888adce9
ZK
36202011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3621
3622 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3623 binding" message (bug#7967).
3624
f838ed7b
PE
36252011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3626
77861b95
PE
3627 Fix more problems found by GCC 4.6.0's static checks.
3628
de6dbc14
PE
3629 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3630 Remove unused local var.
3631
f838ed7b
PE
3632 * editfns.c (Fmessage_box): Remove unused local var.
3633
792c7b2b
PE
3634 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3635 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3636 Omit unused local vars.
c499e557 3637 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3638 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3639 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3640 Omit unused local var.
3641
ba0165e1
PE
3642 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3643 Don't assume string length fits in int.
32ad8845 3644 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3645 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3646
3c59b4c9
PE
3647 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3648 instead of alloca (Bug#8344).
3649
a3eed478 3650 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3651 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3652
eb4d412d
PE
3653 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3654
1658b401
PE
3655 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3656 concerns.
3657
3658 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3659
3660 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3661
9a2c6e05
PE
3662 * keyboard.c (syms_of_keyboard): Use the same style as later
3663 in this function when indexing through an array. This also
3664 works around GCC bug 48267.
3665
03d0a109
PE
3666 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3667
44f730c8
PE
3668 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3669
fe75f926
PE
3670 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3671 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3672
ffa8c828
PE
3673 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3674 This avoids undefined behavior on integer overflow, and is a bit
3675 more convenient anyway since it is compared to a size_t variable.
3676
c5101a77
PE
3677 Variadic C functions now count arguments with size_t, not int.
3678 This avoids an unnecessary limitation on 64-bit machines, which
3679 caused (substring ...) to crash on large vectors (Bug#8344).
3680 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3681 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3682 All variadic functions and their callers changed accordingly.
c5101a77
PE
3683 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3684 * data.c (arith_driver, float_arith_driver): Likewise.
3685 * editfns.c (general_insert_function): Likewise.
3686 * eval.c (struct backtrace.nargs, interactive_p)
3687 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3688 (funcall_lambda, mark_backtrace): Likewise.
3689 * fns.c (concat): Likewise.
3690 * frame.c (x_set_frame_parameters): Likewise.
3691 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3692 0 if not found, not -1. All callers changed.
3693
dd3f25f7
PE
3694 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3695 (stack_copy_size): Now size_t, not int.
3696 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3697
461c2ab9
JB
36982011-03-28 Juanma Barranquero <lekktu@gmail.com>
3699
3700 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3701 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3702 All callers changed.
3703
3704 * lisp.h (multibyte_char_to_unibyte):
3705 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3706 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3707 * character.h (CHAR_TO_BYTE8):
3708 * cmds.c (internal_self_insert):
3709 * editfns.c (general_insert_function):
3710 * keymap.c (push_key_description):
3711 * search.c (Freplace_match):
3712 * xdisp.c (message_dolog, set_message_1): All callers changed.
3713
f6d62986
SM
37142011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3715
3716 * keyboard.c (safe_run_hook_funcall): New function.
3717 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3718 don't set the hook to nil, but remove the offending function instead.
3719 (Qcommand_hook_internal): Remove, unused.
3720 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3721 Vcommand_hook_internal.
3722
3723 * eval.c (enum run_hooks_condition): Remove.
3724 (funcall_nil, funcall_not): New functions.
3725 (run_hook_with_args): Call each function through a `funcall' argument.
3726 Remove `cond' argument, now redundant.
3727 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3728 (Frun_hook_with_args_until_failure): Adjust accordingly.
3729 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3730
1db5b1ad
JB
37312011-03-28 Juanma Barranquero <lekktu@gmail.com>
3732
3733 * dispextern.h (string_buffer_position): Remove declaration.
3734
3735 * print.c (strout): Remove parameter `multibyte', unused since
3736 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3737
3738 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3739 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3740 All callers changed.
3741
3742 * w32.c (_wsa_errlist): Use braces for struct initializers.
3743
3744 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3745 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3746 All callers changed.
3747 (string_buffer_position): Likewise. Also, make static (it's never
3748 used outside xdisp.c).
3749 (cursor_row_p): Remove parameter `w', unused since
3750 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3751 (decode_mode_spec): Remove parameter `precision', introduced during
3752 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3753 All callers changed.
3754
5ffb62aa
JD
37552011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3756
3757 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3758
461c2ab9 37592011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3760
3761 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3762 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3763 (ns_update_auto_hide_menu_bar): New functions.
3764 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3765 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3766 ns_constrain_all_frames.
3767 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3768 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3769
5c380ffb
JD
37702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3771
3772 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3773
9af30bdf
GM
37742011-03-27 Glenn Morris <rgm@gnu.org>
3775
3776 * syssignal.h: Replace RETSIGTYPE with void.
3777 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3778 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3779 Replace SIGTYPE with void everywhere.
3780 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3781 * s/template.h (SIGTYPE): Remove commented out definition.
3782
e2abce01
JB
37832011-03-26 Eli Zaretskii <eliz@gnu.org>
3784
3785 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3786 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3787
f868cd8a
JB
37882011-03-26 Juanma Barranquero <lekktu@gmail.com>
3789
59eb0929
JB
3790 * w32.c (read_unc_volume): Use parameter `henum', instead of
3791 global variable `wget_enum_handle'.
3792
3793 * keymap.c (describe_vector): Remove parameters `indices' and
3794 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3795 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3796
f868cd8a
JB
3797 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3798
3799 * keyboard.c (timer_check): Remove parameter `do_it_now',
3800 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3801 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3802 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3803
3804 * keyboard.c (read_char):
3805 * w32menu.c (w32_menu_display_help):
3806 * xmenu.c (show_help_event, menu_help_callback):
3807 Adjust calls to `show_help_echo'.
3808
3809 * gtkutil.c (xg_maybe_add_timer):
3810 * keyboard.c (readable_events):
3811 * process.c (wait_reading_process_output):
3812 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3813
3814 * insdel.c (adjust_markers_gap_motion):
3815 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3816 (gap_left, gap_right): Don't call it.
3817
2ecf6fdb
CY
38182011-03-25 Chong Yidong <cyd@stupidchicken.com>
3819
3820 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3821 incurred during fontification.
3822
6b1f9ba4
JB
38232011-03-25 Juanma Barranquero <lekktu@gmail.com>
3824
3825 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3826 (DEFVAR_PER_BUFFER): Don't pass it.
3827
3828 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3829 (scrolling_window): Don't pass it.
3830
0f4a96b5
JB
38312011-03-25 Juanma Barranquero <lekktu@gmail.com>
3832
3833 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3834
3835 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3836 and `suffix'.
3837 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3838 of variables specific to SELinux and computation of `encoded_absname'.
3839
3840 * image.c (XPutPixel): Remove unused variable `height'.
3841
3842 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3843
3844 * unexw32.c (get_section_info): Remove unused variable `section'.
3845
3846 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3847 (system_process_attributes): Remove unused variable `sess'.
3848 (sys_read): Remove unused variable `err'.
3849
3850 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3851 (w32_wnd_proc): Remove unused variable `isdead'.
3852 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3853 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3854 (x_create_tip_frame): Remove unused variable `tem'.
3855
3856 * w32inevt.c (w32_console_read_socket):
3857 Remove unused variable `no_events'.
3858
3859 * w32term.c (x_draw_composite_glyph_string_foreground):
3860 Remove unused variable `width'.
3861
1149507c
JB
38622011-03-24 Juanma Barranquero <lekktu@gmail.com>
3863
3864 * w32term.c (x_set_glyph_string_clipping):
3865 Don't pass uninitialized region to CombineRgn.
3866
9c88f339
JB
38672011-03-23 Juanma Barranquero <lekktu@gmail.com>
3868
3869 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3870 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3871 (Fx_close_connection): Remove unused variable `i'.
3872
3873 * w32font.c (w32font_draw): Return number of glyphs.
3874 (w32font_open_internal): Remove unused variable `i'.
3875 (w32font_driver): Add missing initializer.
3876
3877 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3878 (fill_in_menu): Remove unused variable `items_added'.
3879
3880 * w32term.c (last_mouse_press_frame): Remove static global variable.
3881 (w32_clip_to_row): Remove unused variable `f'.
3882 (x_delete_terminal): Remove unused variable `i'.
3883
3884 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3885 (NOTHING): Remove unused static global variable.
3886 (uniscribe_check_otf): Remove unused variable `table'.
3887 (uniscribe_font_driver): Add missing initializers.
3888
dee091a3
JD
38892011-03-23 Julien Danjou <julien@danjou.info>
3890
3891 * term.c (Fsuspend_tty, Fresume_tty):
3892 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3893 * window.c (temp_output_buffer_show):
3894 * insdel.c (signal_before_change):
3895 * frame.c (Fhandle_switch_frame):
3896 * fileio.c (Fdo_auto_save):
3897 * emacs.c (Fkill_emacs):
3898 * editfns.c (save_excursion_restore):
3899 * cmds.c (internal_self_insert):
3900 * callint.c (Fcall_interactively):
3901 * buffer.c (Fkill_all_local_variables):
3902 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3903 Use Frun_hooks.
0f4a96b5 3904 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3905 unconditionnaly since it does the check itself.
3906
2c520ab5 39072011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3908
c9c49752
PE
3909 Fix more problems found by GCC 4.5.2's static checks.
3910
8abc3f12
PE
3911 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3912 the first time through the loop, since we know p0 < p1 then.
3913 This also avoids a gcc -Wstrict-overflow warning.
3914
a2d26660
PE
3915 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3916 leading to a memory leak, possible in functions like
3917 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3918 of objects (Bug#8318).
a2d26660 3919
916c72e9
PE
3920 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3921 that could (at least in theory) be that large.
3922
19ab8a18
PE
3923 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3924 This is less likely to overflow, and avoids undefined behavior if
3925 overflow does occur. All callers changed. Use strtoul to scan
3926 for the unsigned long integer.
b7cbbd6f
PE
3927 (pint2hrstr): Simplify and tune code slightly.
3928 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3929
f0641eff
PE
3930 * scroll.c (do_scrolling): Work around GCC bug 48228.
3931 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3932
7f650bb9
PE
3933 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3934 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3935 (validate_x_resource_name): Simplify count usage.
3936 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3937
37dd57d1
PE
3938 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3939 fail (Bug#8306).
81e56e61 3940
699979fc 3941 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3942
401bf9b4
PE
3943 * process.c (Fmake_network_process): Use socklen_t, not int,
3944 where POSIX says socklen_t is required in portable programs.
3945 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3946 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3947 (Fmake_network_process, server_accept_connection):
3948 (wait_reading_process_output, read_process_output):
3949 Likewise.
3950
b93aacde
PE
3951 * process.c: Rename or move locals to avoid shadowing.
3952 (list_processes_1, Fmake_network_process):
3953 (read_process_output_error_handler, exec_sentinel_error_handler):
3954 Rename or move locals.
4dc343ee 3955 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3956 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3957 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3958 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3959 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3960
af8a867c 3961 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3962 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3963 Include tparam.h instead, since it declares them.
af8a867c
PE
3964 * cm.h (PC): Remove extern decl; tparam.h now does this.
3965 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3966 * terminfo.c: Include tparam.h, to check interfaces.
3967 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3968 (tparam): Adjust signature to match interface in tparam.h;
3969 this removes some undefined behavior. Check that outstring and len
3970 are zero, which they always are with Emacs.
3971 * tparam.h (PC, BC, UP): New extern decls.
3972
0248044d 3973 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3974 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3975
8ff096c1 3976 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3977 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3978 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3979 (ftfont_list): Remove unused local.
49eaafba
PE
3980 (get_adstyle_property, ftfont_pattern_entity):
3981 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3982 Rename locals to avoid shadowing.
8ff096c1 3983
e2be39f6
PE
3984 * xfont.c (xfont_list_family): Mark var as initialized.
3985
c9735e30
PE
3986 * xml.c (make_dom): Now static.
3987
8f5201ae
PE
3988 * composite.c (composition_compute_stop_pos): Rename local to
3989 avoid shadowing.
b246f932
PE
3990 (composition_reseat_it): Remove unused locals.
3991 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3992 (composition_update_it): Mark var as initialized.
11b61122
PE
3993 (find_automatic_composition): Mark vars as initialized,
3994 with a FIXME (Bug#8290).
8f5201ae 3995
760fbc2c
PE
3996 character.h: Rename locals to avoid shadowing.
3997 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3998 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3999 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4000 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4001 to avoid shadowing.
4002
ff08eb85
PE
4003 * textprop.c (property_change_between_p): Remove; unused.
4004
fc7bf025
PE
4005 * intervals.c (interval_start_pos): Now static.
4006
235d7abc
PE
4007 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4008
44f230aa
SM
4009 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4010 Rename locals to avoid shadowing.
3e7d6594 4011
50060332
PE
4012 * sound.c (wav_play, au_play, Fplay_sound_internal):
4013 Fix pointer signedness.
d01f234b 4014 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4015 (wav_play): Initialize a variable to 0, to prevent undefined
4016 behavior (Bug#8278).
50060332 4017
c4fc4e30
PE
4018 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4019
918436ed
PE
4020 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4021
c939f91b
PE
4022 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4023 clobbering (Bug#8298).
b9c7f648
PE
4024 * sysdep.c (sys_subshell): Likewise.
4025 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4026
6bd8c144
PE
4027 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4028 This should get cleaned up, so that child_setup has the
4029 same signature on all platforms.
4030
7710357c 4031 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4032 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4033
c59da222
CY
40342011-03-22 Chong Yidong <cyd@stupidchicken.com>
4035
4036 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4037 not to be necessary, and produces flickering.
4038
66b87493
GM
40392011-03-20 Glenn Morris <rgm@gnu.org>
4040
4041 * config.in: Remove file.
4042
45b6f6d5
JB
40432011-03-20 Juanma Barranquero <lekktu@gmail.com>
4044
4045 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4046 are now in src/globals.h.
4047 (syms_of_minibuf): Remove spurious & from previous change.
4048
3ec03f7e
LL
40492011-03-20 Leo <sdl.web@gmail.com>
4050
4051 * minibuf.c (completing-read-function): New variable.
4052 (completing-read-default): Rename from completing-read.
4053 (completing-read): Call completing-read-function.
4054
b14e3e21
CY
40552011-03-19 Juanma Barranquero <lekktu@gmail.com>
4056
4057 * xfaces.c (Fx_load_color_file):
4058 Read color file from absolute filename (bug#8250).
4059
f2b726e6
JB
40602011-03-19 Juanma Barranquero <lekktu@gmail.com>
4061
4062 * makefile.w32-in: Update dependencies.
4063
09f6ff02
EZ
40642011-03-17 Eli Zaretskii <eliz@gnu.org>
4065
4066 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4067
29a6015a
PE
40682011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4069
a3a6c54e
PE
4070 Fix more problems found by GCC 4.5.2's static checks.
4071
b766f867
PE
4072 * process.c (make_serial_process_unwind, send_process_trap):
4073 (sigchld_handler): Now static.
4074
be02381c
PE
4075 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4076 That way, the code declares only the vars that it needs.
4077 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4078 * s/cygwin.h (PTY_ITERATION): Likewise.
4079 * s/darwin.h (PTY_ITERATION): Likewise.
4080 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4081
57048744
PE
4082 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4083 * process.c (allocate_pty): Don't declare stb unless it's needed.
4084
7914961c 4085 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4086 (CONSTANTLIM): Remove; unused.
4087 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4088 Define only if needed.
7914961c 4089
b3967b18
PE
4090 * unexelf.c (unexec): Name an expression,
4091 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4092 Use a different way to cause a compilation error if anyone uses
4093 n rather than nn, a way that does not involve shadowing.
73366a00 4094 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4095
29a6015a
PE
4096 * deps.mk (unexalpha.o): Remove; unused.
4097
43cfc33e 4098 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4099 * unexec.h: New file.
ce701a33
PE
4100 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4101 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4102 Depend on unexec.h.
4103 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4104 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4105 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4106 Change as necessary to match prototype in unexec.h.
ce701a33 4107
01f44d5a
PE
4108 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4109 shadowing.
4f63c6bb 4110 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4111
a6670b0b
PE
4112 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4113 Rename locals to avoid shadowing.
4114
cef2010d 4115 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4116 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4117
d4d7173a
PE
4118 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4119
f08b802a
PE
4120 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4121 warning when compiling print.c.
4122
3ddb0639
PE
4123 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4124 instead of using an uninitialized var.
5ad03b97 4125 (font_sort_entities): Mark var as initialized.
3ddb0639 4126
170a2692
PE
4127 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4128
e663c700
PE
4129 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4130 pointers to constants.
89bc529a 4131 (font_parse_fcname): Remove unused vars.
7b81e2d0 4132 (font_delete_unmatched): Now static.
ea838e10 4133 (font_get_spec): Remove; unused.
13a547c6
PE
4134 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4135 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4136 Rename or move locals to avoid shadowing.
e663c700 4137
2a80c887 4138 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4139 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4140
1384fa33 4141 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4142 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4143
8b2c52e9
PE
4144 * alloc.c (mark_backtrace): Move decl from here ...
4145 * lisp.h: ... to here, so that it can be checked.
4146
475545b5 4147 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4148 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4149 (lisp_indirect_variable): Name an expression,
4150 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4151 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4152
b1349114 4153 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4154 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4155 Use const pointer when appropriate.
b1349114 4156
a2928364
PE
4157 * lisp.h (get_system_name, get_operating_system_release):
4158 Move decls here, to check interfaces.
4159 * process.c (get_operating_system_release): Move decl to lisp.h.
4160 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4161 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4162 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4163 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4164 (Fformat_time_string, Fencode_time, Finsert_char):
4165 (Ftranslate_region_internal, Fformat):
4166 Rename or remove local vars to avoid shadowing.
9710023e 4167 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4168
a415e694
PE
4169 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4170 avoid shadowing.
4171
8ef4622d
PE
4172 * lisp.h (eassert): Check that the argument compiles, even if
4173 ENABLE_CHECKING is not defined.
4174
946f9a5b
PE
4175 * data.c (Findirect_variable): Name an expression, to avoid
4176 gcc -Wbad-function-cast warning.
112396d6 4177 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4178 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4179 (Fmake_variable_buffer_local, Fmake_local_variable):
4180 Mark variables as initialized.
52746918 4181 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4182
e5aab7e7 4183 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4184 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4185 Rename locals to avoid shadowing.
dff45157
PE
4186 (mark_stack): Move local variables into the #ifdef region where
4187 they're used.
7bc26fdb
PE
4188 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4189 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4190 needed otherwise.
4191 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4192 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4193 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4194
e5aab7e7
PE
4195 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4196 avoids undefined behavior in theory.
4197
4da60324
PE
4198 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4199
88043301
PE
4200 Use functions, not macros, for up- and down-casing (Bug#8254).
4201 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4202 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4203 to use the following functions instead of these macros.
4204 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4205 EMACS_INT, since callers assume the returned value fits in int.
4206 (upcase1): Likewise, for UPCASE_TABLE.
4207 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4208 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4209 the race-condition problem in the old DOWNCASE.
88043301 4210
19ed5445
PE
4211 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4212 Rename locals to avoid shadowing.
4213 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4214 (regex_compile, re_search_2, re_match_2_internal):
4215 Remove unused local vars.
952db0d7
PE
4216 (FREE_VAR): Rewrite so as not to use empty "else",
4217 which gcc can warn about.
da053e48 4218 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4219 (RETALLOC_IF): Define only if needed.
4220 (WORDCHAR_P): Likewise. This one is never needed, but is used
4221 only in a comment talking about a compiler bug, so put inside
4222 the #if 0 of that comment.
4223 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4224 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4225 Remove; unused.
19ed5445 4226
1f3561e4 4227 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4228 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4229 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4230
ded6f8f7
PE
4231 * search.c (simple_search): Remove unused var.
4232
dbd37a95
PE
4233 * dired.c (compile_pattern): Move decl from here ...
4234 * lisp.h: ... to here, so that it can be checked.
4235 (struct re_registers): New forward decl.
4236
7e47afad
PE
4237 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4238
85f24f61
PE
4239 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4240 All uses changed.
4241 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4242 Rename locals to avoid shadowing.
5671df8f 4243 (Fvertical_motion): Mark locals as initialized.
85f24f61 4244
181aa2be 4245 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4246 (casify_region): Mark local as initialized.
181aa2be 4247
930d429c
PE
4248 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4249
7082eac6
PE
4250 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4251 New macros, so that the caller can use some names other than
4252 gcpro1, gcpro2, etc.
4253 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4254 of the new macros.
4255 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4256 argument, for consistency with GCPRO2_VAR, etc: it is now the
4257 prefix of the variable, not the variable itself. All uses
4258 changed.
38b2c076
PE
4259 * dired.c (directory_files_internal, file_name_completion):
4260 Rename locals to avoid shadowing.
4261
15206ed9
PE
4262 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4263 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4264 dired.c's scmp function, had undefined behavior.
4265 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4266 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4267 * buffer.h: ... to here, because these macros use current_buffer,
4268 and the new implementation with inline functions needs to have
4269 current_buffer in scope now, rather than later when the macros
4270 are used.
4271 (downcase, upcase1): New static inline functions.
4272 (DOWNCASE, UPCASE1): Reimplement using these functions.
4273 This avoids undefined behavior in expressions like
4274 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4275 from race conditions in accessing the global variables
4276 case_temp1 and case_temp2.
4277 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4278 * lisp.h (case_temp1, case_temp2): Remove their decls.
4279 * character.h (ASCII_CHAR_P): Move from here ...
4280 * lisp.h: ... to here, so that the inline functions mentioned
4281 above can use them.
4282
4a6bea26
PE
4283 * dired.c (directory_files_internal_unwind): Now static.
4284
f14b7e14
PE
4285 * fileio.c (file_name_as_directory, directory_file_name):
4286 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4287 Now static.
2893f146
PE
4288 (file_name_as_directory): Use const pointers when appropriate.
4289 (Fexpand_file_name): Likewise. In particular, newdir might
4290 point at constant storage, so make it a const pointer.
fd4ead52 4291 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4292 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4293 signedness issues.
f839df0c
PE
4294 (Fset_file_times, Finsert_file_contents, auto_save_error):
4295 Rename locals to avoid shadowing.
f14b7e14 4296
5716756e 4297 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4298 (Ftry_completion, Fall_completions): Rename or remove locals
4299 to avoid shadowing.
5716756e 4300
b4c3046a
PE
4301 * marker.c (bytepos_to_charpos): Remove; unused.
4302
b45db522
PE
4303 * lisp.h (verify_bytepos, count_markers): New decls,
4304 so that gcc does not warn that these functions aren't declared.
4305
85876d07
PE
4306 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4307 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4308 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4309 (copy_text): Remove unused local var.
85876d07 4310
03d78a21 4311 * filelock.c (within_one_second): Now static.
b3dd38ab 4312 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4313
5df8f01b
PE
4314 * buffer.c (fix_overlays_before): Mark locals as initialized.
4315 (fix_start_end_in_overlays): Likewise. This function should be
4316 simplified by using pointers-to-pointers, but that's a different
4317 matter.
b1d876f1 4318 (switch_to_buffer_1): Now static.
8f54f30a
PE
4319 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4320 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4321
a70072c9 4322 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4323 Fix pointer signedness issue.
edced198
PE
4324 (sys_subshell): Mark local as volatile if checking for lint,
4325 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4326 (MAXPATHLEN): Define only if needed.
a70072c9 4327
a0977c44
PE
4328 * process.c (serial_open, serial_configure): Move decls from here ...
4329 * systty.h: ... to here, so that they can be checked.
4330
a884fdcc
PE
4331 * fns.c (get_random, seed_random): Move extern decls from here ...
4332 * lisp.h: ... to here, so that they can be checked.
4333
604efe86 4334 * sysdep.c (reset_io): Now static.
b8950c94 4335 (wait_for_termination_signal): Remove; unused.
604efe86 4336
38fc62d9
PE
4337 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4338 (copy_keymap_item, append_key, push_text_char_description):
4339 Now static.
1004a21a 4340 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4341 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4342 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4343 (describe_map_tree):
4344 Rename locals to avoid shadowing.
38fc62d9 4345
2f2650da
PE
4346 * keyboard.c: Declare functions static if they are not used elsewhere.
4347 (echo_char, echo_dash, cmd_error, top_level_2):
4348 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4349 (read_char, kbd_buffer_get_event, make_lispy_position):
4350 (make_lispy_event, make_lispy_movement, apply_modifiers):
4351 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4352 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4353 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4354 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4355 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4356
a053e86c 4357 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4358 (mark_kboards): Move decl here ...
4359 * alloc.c (mark_kboards): ... from here.
a053e86c 4360
4752793e
PE
4361 * lisp.h (force_auto_save_soon): New decl.
4362
74f10ca7 4363 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4364 (DEFINE_DUMMY_FUNCTION): New macro.
4365 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4366 Use it.
c03cd23f
PE
4367 (main): Add casts to avoid warnings
4368 if GCC considers string literals to be constants.
74f10ca7 4369
022e70d4
PE
4370 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4371
59d6fe83
PE
4372 * dbusbind.c: Pointer signedness fixes.
4373 (xd_signature, xd_append_arg, xd_initialize):
4374 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4375 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4376 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4377 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4378
78320123
PE
4379 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4380 if GCC considers string literals to be constants.
49cebcca 4381 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4382
35ac2a97
SM
43832011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4384
fb103ca9
SM
4385 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4386 (print_preprocess, print_object): New macro to fix last change.
4387
35ac2a97
SM
4388 * print.c (print_preprocess): Don't forget font objects.
4389
62973b41
JB
43902011-03-16 Juanma Barranquero <lekktu@gmail.com>
4391
4392 * emacs.c (USAGE3): Doc fixes.
4393
0e48bb22
AS
43942011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4395
4396 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4397 structure.
4398
7684e57b
JB
43992011-03-14 Juanma Barranquero <lekktu@gmail.com>
4400
4401 * lisp.h (VWindow_system, Qfile_name_history):
4402 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4403 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4404 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4405
4406 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4407 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4408
4409 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4410 * w32console.c (detect_input_pending, read_input_pending)
4411 (encode_terminal_code):
4412 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4413 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4414 (w32_system_caret_y, Qfile_name_history):
4415 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4416 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4417 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4418 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4419 * w32proc.c (Qlocal, report_file_error):
4420 * w32term.c (Vwindow_system, updating_frame):
4421 * w32uniscribe.c (initialized, uniscribe_font_driver):
4422 Remove unneeded extern declarations.
4423
2aa46d6c
CY
44242011-03-14 Chong Yidong <cyd@stupidchicken.com>
4425
c96bbc66 4426 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4427
cffc6f3b
CY
44282011-03-13 Chong Yidong <cyd@stupidchicken.com>
4429
4430 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4431 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4432 These macros can no longer be used for assignment.
4433
44f230aa
SM
4434 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4435 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4436 (record_buffer_markers, fetch_buffer_markers): New functions for
4437 recording and fetching special buffer markers.
4438 (set_buffer_internal_1, set_buffer_temp): Use them.
4439
4440 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4441
4442 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4443
4444 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4445 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4446
4447 * xdisp.c (hscroll_window_tree):
4448 (reconsider_clip_changes): Use PT instead of BUF_PT.
4449
d251f04b
EZ
44502011-03-13 Eli Zaretskii <eliz@gnu.org>
4451
4452 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4453 $(EMACS_ROOT)/lib/intprops.h.
4454
f0c77cd1
PE
44552011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4456
3eca4629
PE
4457 Fix more problems found by GCC 4.5.2's static checks.
4458
7c86ee98
PE
4459 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4460 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4461 (xg_free_frame_widgets): Make it clear that a local variable is
4462 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4463 (gdk_window_get_screen): Make it clear that this macro is needed
4464 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4465 (int_gtk_range_get_value): New function, which avoids a diagnostic
4466 from gcc -Wbad-function-cast.
4467 (xg_set_toolkit_scroll_bar_thumb): Use it.
4468 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4469 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4470 (get_utf8_string, xg_get_file_with_chooser):
4471 Rename locals to avoid shadowing.
4472 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4473
41729b81
PE
4474 * xgselect.c (xg_select): Remove unused var.
4475
f0c77cd1
PE
4476 * image.c (four_corners_best): Mark locals as initialized.
4477 (gif_load): Initialize transparent_p to zero (Bug#8238).
4478 Mark another local as initialized.
ec6cf4c6 4479 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4480
ce0ad53d 4481 * image.c (clear_image_cache): Now static.
d5d5a617 4482 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4483 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4484 (x_edge_detection): Remove unnecessary cast that
4485 gcc -Wbad-function-cast diagnoses.
2037898d 4486 (gif_load): Fix pointer signedness.
6ae141d6
PE
4487 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4488 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4489
33383987 44902011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4491
d32df629
PE
4492 Improve quality of tests for time stamp overflow.
4493 For example, without this patch (encode-time 0 0 0 1 1
4494 1152921504606846976) returns the obviously-bogus value (-948597
4495 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4496 reports time overflow. See
4497 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4498 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4499 * editfns.c: Include limits.h and intprops.h.
4500 (TIME_T_MIN, TIME_T_MAX): New macros.
4501 (time_overflow): Move earlier, to before first use.
4502 (hi_time, lo_time): New functions, for an accurate test for
4503 out-of-range times.
4504 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4505 (Fget_internal_run_time): Don't assume time_t fits in int.
4506 (make_time): Use list2 instead of Fcons twice.
4507 (Fdecode_time): More accurate test for out-of-range times.
4508 (check_tm_member): New function.
4509 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4510 (lisp_time_argument): Don't rely on undefined left-shift and
4511 right-shift behavior when checking for time stamp overflow.
8be6f318 4512
fe31d94c
PE
4513 * editfns.c (time_overflow): New function, refactoring common code.
4514 (Fformat_time_string, Fdecode_time, Fencode_time):
4515 (Fcurrent_time_string): Use it.
4516
8be6f318
PE
4517 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4518 * dired.c (make_time): Move to ...
4519 * editfns.c (make_time): ... here.
4520 * systime.h: Note the move.
4521
09d9db2c 45222011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4523
126bc0dc
YM
4524 * fringe.c (update_window_fringes): Remove unused variables.
4525
c47cbdfd
YM
4526 * unexmacosx.c (copy_data_segment): Also copy __got section.
4527 (Bug#8223)
4528
7ac80be9
EZ
45292011-03-12 Eli Zaretskii <eliz@gnu.org>
4530
c96bbc66 4531 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4532 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4533 Constify `char *' arguments and their references according to
4534 prototypes in tparam.h.
4535
ecb0f94d 4536 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4537
7ac80be9
EZ
4538 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4539 Adapt all references accordingly.
4540
4541 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4542
ef1fd07e
TT
45432011-03-11 Tom Tromey <tromey@redhat.com>
4544
4545 * buffer.c (syms_of_buffer): Remove obsolete comment.
4546
7ef4b50c
EZ
45472011-03-11 Eli Zaretskii <eliz@gnu.org>
4548
4549 * termhooks.h (encode_terminal_code): Declare prototype.
4550
4551 * msdos.c (encode_terminal_code): Don't declare prototype.
4552
4553 * term.c (encode_terminal_code): Now external again, used by
4554 w32console.c and msdos.c.
4555
44f230aa
SM
4556 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4557 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4558
4b1ec863 45592011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4560
1714f52b 4561 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4562
4b1ec863
PE
4563 * fringe.c (update_window_fringes): Mark locals as initialized
4564 (Bug#8227).
4565 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4566
524c7aa6
PE
4567 * alloc.c (mark_fringe_data): Move decl from here ...
4568 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4569 to check its interface.
4570 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4571
a5c0af81 4572 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4573 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4574 (fontset_font): Mark local as initialized.
a9a06e0b 4575 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4576
b4716021
PE
4577 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4578
811e9bac 4579 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4580 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4581 (x_own_selection, Fx_disown_selection_internal): Rename locals
4582 to avoid shadowing.
4583 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4584
7e3ab302
PE
4585 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4586 so that the caller can use some name other than gcpro1.
4587 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4588 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4589 (Fx_backspace_delete_keys_p):
4590 Use them to avoid shadowing, and rename vars to avoid shadowing.
4591 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4592 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4593 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4594 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4595 Remove unused locals.
7e3ab302
PE
4596 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4597 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4598 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4599 macros.
f78faa98 4600
e2b13473
PE
4601 * xterm.h (x_mouse_leave): New decl.
4602
77f23912
PE
4603 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4604 Remove unused functions.
cdf4ba58
PE
4605 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4606 (x_calc_absolute_position): Now static.
7411c686 4607 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4608 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4609 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4610 unless they are used.
38d0b34a
PE
4611 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4612 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4613 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4614 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4615 (x_error_catcher, x_connection_closed, x_error_handler):
4616 (x_error_quitter, xembed_send_message, x_iconify_frame):
4617 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4618 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4619 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4620
44f230aa
SM
4621 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4622 Rename or move locals to avoid shadowing.
6b463e58 4623 (tty_defined_color, merge_face_heights): Now static.
5967d051 4624 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4625 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4626 does not deduce is never used uninitialized.
73719eba
PE
4627 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4628 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4629
426994c3 4630 * terminal.c (store_terminal_param): Now static.
5489860b 4631
032f1620 4632 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4633 (set_frame_menubar): Remove unused local.
d4323972 4634 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4635 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4636 since they might point to immutable storage.
281585b0
PE
4637 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4638 since it's unused otherwise.
032f1620 4639
367c19e5 4640 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4641 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4642 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4643 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4644 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4645 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4646 does not deduce are never used uninitialized.
70739cbe 4647
07b48fa9
PE
4648 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4649
8868a238 4650 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4651 * window.c (window_loop, size_window):
4652 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4653
7e5cf297 4654 * window.c (display_buffer): Now static.
d6550a9f
PE
4655 (size_window): Mark variables that gcc -Wuninitialized
4656 does not deduce are never used uninitialized.
a586633d
PE
4657 * window.h (check_all_windows): New decl, to forestall
4658 gcc -Wmissing-prototypes diagnostic.
5b555da1 4659 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4660
f6095868
PE
4661 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4662 shadowing.
4663 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4664 Include <limits.h>.
4665 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4666 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4667 (load_charset_map): Mark variables that gcc -Wuninitialized
4668 does not deduce are never used uninitialized.
53df7c11 4669 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4670
f38b440c
PE
4671 * coding.c (coding_set_source, coding_set_destination):
4672 Use "else { /* comment */ }" rather than "else /* comment */;"
4673 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4674 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4675 a block, when the outer 'i' will do.
4676 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4677 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4678 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4679 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4680 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4681 Rename locals to avoid shadowing.
4682 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4683 * coding.c (emacs_mule_char, encode_invocation_designation):
4684 Now static, since they're not used elsewhere.
413bb2db 4685 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4686 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4687 (decode_coding_emacs_mule): Mark variables that gcc
4688 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4689 (detect_coding_iso_2022): Initialize a local variable that might
4690 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4691 this initialization is needed. (Bug#8211)
5f58e762
PE
4692 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4693 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4694 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4695 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4696 Remove unused macros.
f38b440c 4697
232b38b9 4698 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4699 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4700 * character.c (string_count_byte8): Likewise.
232b38b9 4701
fb90da1b
PE
4702 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4703 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4704
fb93dbc2
PE
4705 * chartab.c (copy_sub_char_table): Now static, since it's not used
4706 elsewhere.
5c156ace
PE
4707 (sub_char_table_ref_and_range, char_table_ref_and_range):
4708 Rename locals to avoid shadowing.
bbcd0949 4709 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4710
7d3b3862 4711 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4712 (BIDI_BOB): Remove unused macro.
7d3b3862 4713
6be7d3da
PE
4714 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4715 deduce are never used uninitialized.
c2ed9c8b 4716 * term.c (encode_terminal_code): Likewise.
6be7d3da 4717
75f8807f 4718 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4719
50938595
PE
4720 * tparam.h: New file.
4721 * term.c, tparam.h: Include it.
4722 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4723 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4724 Move these decls to tparam.h, and make them agree with what
4725 is actually in tparam.c. The previous trick of using incompatible
4726 decls in different modules does not conform to the C standard.
4727 All callers of tparam changed to use tparam's actual API.
4728 * tparam.c (tparam1, tparam, tgoto):
4729 Use const pointers where appropriate.
4730
fbceeba2
PE
4731 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4732 * cm.h (struct cm): Likewise.
4733 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4734 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4735 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4736 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4737 (turn_on_face, init_tty): Likewise.
4738 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4739
7f3f1250
PE
4740 * term.c (term_mouse_position): Rename local to avoid shadowing.
4741
e6ca6543
PE
4742 * alloc.c (mark_ttys): Move decl from here ...
4743 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4744
c40f8d15
AS
47452011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4746
4747 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4748
cfe0661d
JB
47492011-03-09 Juanma Barranquero <lekktu@gmail.com>
4750
4751 * search.c (compile_pattern_1): Remove argument regp, unused since
4752 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4753 (compile_pattern): Don't pass it.
4754
0afb4571
J
47552011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4756
4757 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4758 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4759 for ! HAVE_GTK3.
4760 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4761
4762 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4763
4764 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4765 gdk_window_get_screen, gdk_window_get_geometry,
4766 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4767 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4768 (xg_get_pixbuf_from_pixmap): New function.
4769 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4770 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4771 Call xg_get_pixbuf_from_pixmap instead of
4772 gdk_pixbuf_get_from_drawable.
4773 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4774 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4775 (xg_check_special_colors): Use GtkStyleContext and its functions
4776 for HAVE_GTK3.
4777 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4778 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4779 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4780 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4781 Call gtk_widget_get_preferred_size.
0afb4571
J
4782 (xg_frame_resized): gdk_window_get_geometry only takes 5
4783 parameters.
44f230aa
SM
4784 (xg_win_to_widget, xg_event_is_for_menubar):
4785 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4786 (xg_set_widget_bg): New function.
4787 (delete_cb): New function.
895009e1 4788 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4789 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4790 (xg_set_background_color): Call xg_set_widget_bg.
4791 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4792 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4793 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4794 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4795 if ! HAVE_GTK3.
4796 (update_frame_tool_bar): Call gtk_widget_hide.
4797 (xg_initialize): Use GDK_KEY_g.
4798
4799 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4800 if ! HAVE_GTK3
4801 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4802
4803 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4804 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4805 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4806
1c2cc4ef
JB
48072011-03-08 Juanma Barranquero <lekktu@gmail.com>
4808
4809 * w32xfns.c (select_palette): Check success of RealizePalette against
4810 GDI_ERROR, not zero.
4811
33383987 4812See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4813
4814;; Local Variables:
4815;; coding: utf-8
aac0c6e3
MR
4816;; End:
4817
33383987 4818 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4819
4820 This file is part of GNU Emacs.
4821
4822 GNU Emacs is free software: you can redistribute it and/or modify
4823 it under the terms of the GNU General Public License as published by
4824 the Free Software Foundation, either version 3 of the License, or
4825 (at your option) any later version.
4826
4827 GNU Emacs is distributed in the hope that it will be useful,
4828 but WITHOUT ANY WARRANTY; without even the implied warranty of
4829 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4830 GNU General Public License for more details.
4831
4832 You should have received a copy of the GNU General Public License
4833 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.