Fix bug #9549 with longlines-show-hard-newlines.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8c203dbf
EZ
12011-09-20 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4 a display string, extend search for cursor position to end of row.
5 (find_row_edges): If the row ends in a newline from a display
6 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7 Handle the case of a display string with multiple newlines.
8
a4824228
LMI
92011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10
11 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
12 (bug#9493).
13
33ed493b
CY
142011-09-18 Chong Yidong <cyd@stupidchicken.com>
15
16 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
17 boolean (Bug#9154).
18
56cd55c8
EZ
192011-09-18 Eli Zaretskii <eliz@gnu.org>
20
21 * xdisp.c (display_line): Record maximum and minimum buffer
22 positions even if no glyphs were produced (e.g., by a zero-width
23 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
24 buffer positions that will be removed from the glyph row because
25 they don't fit.
c02dcedf
EZ
26 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
27 column is beyond frame width: don't subtract 1 "pixel" when
28 computing width of the stretch.
3e62b7e0
EZ
29 (reseat_at_next_visible_line_start): Undo the change made on
30 2011-09-17 that saved paragraph information and restored it after
31 the call to `reseat'. (Bug#9545)
56cd55c8 32
5ed99d36 332011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
34
35 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
36 and turn window cursor on if cleared (Bug#9415).
37
5ed99d36 382011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
39
40 * search.c (boyer_moore): Take unibyte characters from pattern
41 literally. (Bug#9458)
42
9bade7b2
EZ
432011-09-18 Eli Zaretskii <eliz@gnu.org>
44
45 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
46
e5e9d610
PE
472011-09-18 Paul Eggert <eggert@cs.ucla.edu>
48
87e4427a
PE
49 Fix minor problem found by static checking.
50 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
51 initialized, to pacify gcc -Wuninitialized.
52
e5e9d610
PE
53 * fileio.c: Report proper errno when syscall falls.
54 (Finsert_file_contents): Save and restore errno,
55 so that report_file_error outputs the correct diagnostic.
56 (Fwrite_region) [CLASH_DETECTION]: Likewise.
57
a1674f0b
EZ
582011-09-18 Eli Zaretskii <eliz@gnu.org>
59
60 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
61
fbfb6dd4
EZ
622011-09-17 Eli Zaretskii <eliz@gnu.org>
63
64 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
65 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
66
bb187662
EZ
672011-09-17 Eli Zaretskii <eliz@gnu.org>
68
1137e8b8
EZ
69 * xdisp.c (reseat_at_next_visible_line_start): Keep information
70 about the current paragraph and restore it after the call to
71 reseat.
72
73 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
74 (bidi_find_paragraph_start): Search back for paragraph beginning
75 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
76 (bidi_move_to_visually_next): Only trigger paragraph-related
77 computations when the last character is a newline or at EOB, not
78 just any NEUTRAL_B. (Bug#9470)
79
bb187662
EZ
80 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
81 truncated lines if point is covered by a display string. (Bug#9524)
82
2e621251
PE
832011-09-16 Paul Eggert <eggert@cs.ucla.edu>
84
85 * xselect.c: Relax test for outgoing X longs (Bug#9498).
86 (cons_to_x_long): New function.
87 (lisp_data_to_selection_data): Use it. Correct the test for
88 short-versus-long data; it was negated. Break out of vector
89 loop, for efficiency, when a long datum is discovered.
90
91a15bc6
SM
912011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
92
93 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
94
b41c3a35
EZ
952011-09-16 Eli Zaretskii <eliz@gnu.org>
96
97 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
98 GCC PR/17406) by declaring this function with external scope.
99
7812ba2d
PE
1002011-09-15 Paul Eggert <eggert@cs.ucla.edu>
101
102 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
103 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
104
cf7edc2a
AS
1052011-09-15 Andreas Schwab <schwab@linux-m68k.org>
106
107 * editfns.c (Fformat): Correctly handle text properties on "%%".
108
bd01620e
EZ
1092011-09-15 Eli Zaretskii <eliz@gnu.org>
110
111 * xterm.c (x_draw_composite_glyph_string_foreground):
112 * w32term.c (x_draw_composite_glyph_string_foreground):
113 * term.c (encode_terminal_code):
114 * composite.c (composition_update_it, get_composition_id):
115 * xdisp.c (get_next_display_element)
116 (fill_composite_glyph_string): Add comments about special meaning
117 of TAB characters in a composition.
118
a02719a3
PE
1192011-09-15 Paul Eggert <eggert@cs.ucla.edu>
120
121 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
122 This occurs when processing a multibyte format.
123 Problem reported by Wolfgang Jenker.
a02719a3 124
72589a3c
JB
1252011-09-15 Johan Bockgård <bojohan@gnu.org>
126
127 * xdisp.c (try_cursor_movement): Only check for exact match if
128 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
129
1c14176c
PE
1302011-09-14 Paul Eggert <eggert@cs.ucla.edu>
131
132 Remove unused external symbols.
133 * dispextern.h (calc_pixel_width_or_height): Remove decl.
134 * xdisp.c (calc_pixel_width_or_height): Now static.
135 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
136 * indent.c (check_display_width):
137 * w32term.c: Fix comment to match code.
138 * xterm.c, xterm.h (x_catching_errors): Remove.
139
d2eea5b5
PE
1402011-09-14 Paul Eggert <eggert@cs.ucla.edu>
141
142 * xselect.c: Use signed conversions more consistently (Bug#9498).
143 (selection_data_to_lisp_data): Assume incoming selection data are
144 signed integers, not unsigned. This is to be consistent with
145 outgoing selection data, which was modified to use signed integers
146 in as part of the fix to Bug#9196 in response to Jan D.'s comment
147 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
148 expects long, not unsigned long.
149
46888499
EZ
1502011-09-14 Eli Zaretskii <eliz@gnu.org>
151
152 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
153 computation of loop end. Reported by Johan Bockgård
154 <bojohan@gnu.org>.
155
ef8ef9fb
CY
1562011-09-13 Chong Yidong <cyd@stupidchicken.com>
157
158 * frame.c (Fother_visible_frames_p): Function deleted.
159
fa819fed
EZ
1602011-09-12 Eli Zaretskii <eliz@gnu.org>
161
162 * indent.c (compute_motion): Process display vector front to back
163 rather than the other way around. (Bug#2496)
164
2ba8e008
SM
1652011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
166
167 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
168
20f53c69
CY
1692011-09-11 Chong Yidong <cyd@stupidchicken.com>
170
171 * minibuf.c (Fread_from_minibuffer): Doc fix.
172
d562d7a4
EZ
1732011-09-11 Eli Zaretskii <eliz@gnu.org>
174
175 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
176 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
177
1c4d7f3d
LMI
1782011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
179
180 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
181 value for non-existent files.
182
b885bf36
EZ
1832011-09-11 Eli Zaretskii <eliz@gnu.org>
184
185 * fileio.c (Finsert_file_contents): If the file cannot be opened,
186 set its "size" to -1. This will set the modtime_size field of
187 the corresponding buffer to -1, which is what
188 verify-visited-file-modtime expects for files that do not exist.
189 (Bug#9139)
190
6612f0bf
PE
1912011-09-11 Paul Eggert <eggert@cs.ucla.edu>
192
193 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
194 here ...
195 * lisp.h: ... from here. push_key_description is no longer
196 defined in keyboard.c, so its declaration should not be in
197 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
198 logically belongs with push_key_description.
199
dfb3f755
PE
2002011-09-10 Paul Eggert <eggert@cs.ucla.edu>
201
202 * buffer.h: Include <sys/types.h> instead of <time.h>.
203 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
204 Problem reported by Herbert J. Skuhra.
205
3134906c
LMI
2062011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
207
208 * xml.c (parse_region): Make the parsing work for
209 non-comment-starting XML files again (bug#9144).
210
8d903f4e
AS
2112011-09-10 Andreas Schwab <schwab@linux-m68k.org>
212
213 * image.c (gif_load): Fix calculation of bottom and right corner.
214 (Bug#9468)
215
80ad64f4
EZ
2162011-09-10 Eli Zaretskii <eliz@gnu.org>
217
218 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
219 redisplay in small windows.
220
208a048d
EZ
2212011-09-09 Eli Zaretskii <eliz@gnu.org>
222
223 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
224
9b1c252e
MR
2252011-09-08 Martin Rudalics <rudalics@gmx.at>
226
227 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
228 Operate on live windows only.
229
2949f33b
JB
2302011-09-08 Juanma Barranquero <lekktu@gmail.com>
231
232 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
233
e08dcafd
EZ
2342011-09-07 Eli Zaretskii <eliz@gnu.org>
235
236 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
237 only under bidi iteration.
238
115b96bd
JD
2392011-09-07 Jan Djärv <jan.h.d@swipnet.se>
240
241 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
242
c8199d0f
PE
2432011-09-06 Paul Eggert <eggert@cs.ucla.edu>
244
245 isnan: Fix porting problem to Solaris 10 with bundled gcc.
246 Without this fix, the command to link temacs failed due to an
247 undefined symbol __builtin_isnan. This is because
248 /usr/include/iso/math_c99.h #defines isnan(x) to
249 __builtin_isnan(x), but the bundled gcc, which identifies itself
250 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
251 a __builtin_isnan.
252 * floatfns.c (isnan): #undef, and then #define to a clone of
253 what's in data.c.
254 (Fisnan): Always define, since it's always available now.
255 (syms_of_floatfns): Always define isnan at the Lisp level.
256
e39b275c 2572011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
258
259 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
260
b2db44d9 2612011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 262
f4af5137 263 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
264 The previous code assumed that file offsets (off_t values) fit in
265 EMACS_INT variables, which is not true on typical 32-bit hosts.
266 The code messed up by falsely reporting buffer overflow in cases
267 such as (insert-file-contents "big" nil 1 2) into an empty buffer
268 when "big" contains more than 2**29 bytes, even though this
269 inserts just one byte and does not overflow the buffer.
270 (Finsert_file_contents): Store file offsets as off_t
271 values, not as EMACS_INT values. Check for overflow when
272 converting between EMACS_INT and off_t. When checking for
273 buffer overflow or for overlap, take the offsets into account.
274 Don't use EMACS_INT for small values where int suffices.
275 When checking for overlap, fix a typo: ZV was used where
276 ZV_BYTE was intended.
277 (Fwrite_region): Don't assume off_t fits into 'long'.
278 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
279
ecfc0a49
MA
2802011-09-05 Michael Albinus <michael.albinus@gmx.de>
281
282 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
283
6511acf2 2842011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 285
0999621a 286 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
287
288 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 289 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
290 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
291 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
292 (modify_event_symbol): Do not assume that the length of
293 name_alist_or_stem is safe to alloca and fits in int.
294 (Fexecute_extended_command): Likewise for function name and binding.
295 (Frecursion_depth): Wrap around reliably on integer overflow.
296 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
297 since some callers pass EMACS_INT values.
298 (Fsingle_key_description): Don't crash if symbol name contains more
299 than MAX_ALLOCA bytes.
300 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
301 (get_minibuffer): Arg is now EMACS_INT, not int.
302 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 303 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
304 * window.h (command_loop_level, minibuf_level): Reflect API changes.
305
2be7d702
PE
306 * dbusbind.c (signature_cat): New function.
307 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
308 Do not overrun buffer; instead, report string overflow.
309
9d1df220
PE
310 * dispnew.c (add_window_display_history): Don't overrun buffer.
311 Truncate instead; this is OK since it's just a log.
312
33ef5c64
PE
313 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
314 even if the time zone offset is outlandishly large.
315 Don't mishandle offset == INT_MIN.
316
66c6fdd5
PE
317 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
318 when creating daemon; the previous buffer-overflow check was incorrect.
319
d749b01b
PE
320 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
321 which has the guts of the old verror function.
322
b5cd1905
PE
323 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
324 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
325
6e1a67fb
PE
326 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
327 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 328 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 329 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
330 length of string rather than counting it via multiple sprintfs;
331 that's simpler and more reliable.
c21721cc
PE
332 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
333 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
334 sprintf, in case result does not fit in int.
335
c57b67fc
PE
336 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
337 (fontset_from_font): Print it.
338
8a401434
PE
339 * frame.c (tty_frame_count): Now printmax_t, not int.
340 (make_terminal_frame, set_term_frame_name): Print it.
341 (x_report_frame_params): In X, window IDs are unsigned long,
342 not signed long, so print them as unsigned.
343 (validate_x_resource_name): Check for implausibly long names,
344 and don't assume name length fits in 'int'.
345 (x_get_resource_string): Don't blindly alloca invocation name;
346 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
347 not fit in int.
348
6e1a67fb
PE
349 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
350 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
351 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
352
0df02bf3
PE
353 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
354 Use esprintf, not sprintf, in case result does not fit in int.
355
48e30793
PE
356 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
357 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
358 it as a large positive number.
359 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
360 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
361
a66ff6d8
PE
362 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
363 in case result does not fit in int.
364
aca216ff
PE
365 * print.c (float_to_string): Detect width overflow more reliably.
366 (print_object): Make sprintf buffer a bit bigger, to avoid potential
367 buffer overrun. Don't assume list length fits in 'int'. Treat
368 print length of 0 as 0, not as infinity; to be consistent with other
369 uses of print length in this function. Don't overflow print length
370 index. Don't assume hash table size fits in 'long', or that
371 vectorlike size fits in 'unsigned long'.
372
31c286f7
PE
373 * process.c (make_process): Use printmax_t, not int, to format
374 process-name gensyms.
375
55e5faa1
PE
376 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
377
80f2e268
PE
378 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
379 to avoid potential buffer overrun.
380
670741ab
PE
381 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
382 if X resource line is longer than 512 bytes.
383
b7163a50
PE
384 * xfns.c (x_window): Make sprintf buffer a bit bigger
385 to avoid potential buffer overrun.
386
ae58ff1f
PE
387 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
388
c43c8a6a
PE
389 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
390
3f8236f4
PE
3912011-09-04 Paul Eggert <eggert@cs.ucla.edu>
392
53e9fe90 393 Integer overflow fixes for scrolling, etc.
6511acf2
PE
394 Without these, Emacs silently mishandles large integers sometimes.
395 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
396 it were "C-u 1 M-x recenter" on a typical 64-bit host.
397
6511acf2
PE
398 * xdisp.c (try_window_id): Check Emacs fixnum range before
399 converting to 'int'.
806add1d 400
6511acf2 401 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
402 Check that an Emacs fixnum is in range before assigning it to 'int'.
403 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
404 values converted from Emacs fixnums.
405 (Frecenter): Don't wrap around a line count if it is out of 'int'
406 range; instead, treat it as an extreme value.
407 (Fset_window_configuration, compare_window_configurations):
408 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
409
6511acf2
PE
410 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
411 that can exceed INT_MAX. Check that EMACS_INT value is in range
412 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
413 (match_limit): Don't assume that a fixnum can fit in 'int'.
414
6511acf2 415 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
416 exceed INT_MAX.
417
6511acf2 418 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
419 (Fvertical_motion): Don't wrap around LINES values that don't fit
420 in 'int'. Instead, treat them as extreme values. This is good
421 enough for windows, which can't have more than INT_MAX lines anyway.
422
fcb901a7
LMI
4232011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
424
0f2f6b6d
LMI
425 * Require libxml/parser.h to avoid compilation warning.
426
fcb901a7
LMI
427 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
428
429 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
430 since this reportedly can destroy thread storage.
431
6e20a0d4
CY
4322011-08-30 Chong Yidong <cyd@stupidchicken.com>
433
434 * syntax.c (find_defun_start): Update all cache variables if
435 exiting early (Bug#9401).
436
148ae00e
EZ
4372011-08-30 Eli Zaretskii <eliz@gnu.org>
438
f6cfbd8f
EZ
439 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
440
148ae00e
EZ
441 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
442 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
443 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
444
445 * term.c (tty_append_glyph): New function.
446 (produce_stretch_glyph): Static function and its prototype deleted.
447
448 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
449 prototypes.
450
c4a07a4c
PE
4512011-08-29 Paul Eggert <eggert@cs.ucla.edu>
452
453 * image.c (parse_image_spec): Check for nonnegative, not for positive,
454 when checking :margin (Bug#9390).
455 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
456 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
457 so that the name doesn't mislead. All uses changed.
458
6bc8cd65
JB
4592011-08-28 Johan Bockgård <bojohan@gnu.org>
460
461 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
462 set_tty_hooks.
463
dca4927e
EZ
4642011-08-27 Eli Zaretskii <eliz@gnu.org>
465
466 * xdisp.c (move_it_to): Don't bail out early when reaching
467 position beyond to_charpos, if we are scanning backwards.
468 (move_it_vertically_backward): When DY == 0, make sure we get to
469 the first character in the line after the newline.
470
f2cad773
PE
4712011-08-27 Paul Eggert <eggert@cs.ucla.edu>
472
473 * ccl.c: Improve and simplify overflow checking (Bug#9196).
474 (ccl_driver): Do not generate an out-of-range pointer.
475 (Fccl_execute_on_string): Remove unnecessary check for
476 integer overflow, noted by Stefan Monnier in
477 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
478 Remove a FIXME that didn't need fixing.
479 Simplify the newly-introduced buffer reallocation code.
480
0cae2cdb
JB
4812011-08-27 Juanma Barranquero <lekktu@gmail.com>
482
483 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
484
5fc295a4 4852011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 486
70c60eb2 487 Integer and memory overflow issues (Bug#9196).
726e0ab1 488
d31850da
PE
489 * doc.c (get_doc_string): Rework so that
490 get_doc_string_buffer_size is the actual buffer size, rather than
491 being 1 less than the actual buffer size; this makes xpalloc more
492 convenient.
493
a69fbedb
PE
494 * image.c (x_allocate_bitmap_record, cache_image):
495 * xselect.c (Fx_register_dnd_atom):
496 Simplify previous changes by using xpalloc.
497
fe5c5d37
PE
498 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
499 since either will do and ptrdiff_t is convenient with xpalloc.
500
0065d054
PE
501 * charset.c (charset_table_size)
502 (struct charset_sort_data.priority): Now ptrdiff_t.
503 (charset_compare): Don't overflow if priorities differ greatly.
504 (Fsort_charsets): Don't assume list length fits in int.
505 Check for size-calculation overflow when allocating sort data.
506 (syms_of_charset): Allocate an initial charset table that is
507 just under 64 KiB, to avoid problems with glibc malloc and mmap.
508
509 * cmds.c (internal_self_insert): Check for size-calculation overflow.
510
511 * composite.h (struct composition.glyph_len): Now int, not unsigned.
512 The actual value is always <= INT_MAX, and leaving it unsigned made
513 overflow checking harder.
514
515 * dispextern.h (struct glyph_matrix.rows_allocated)
516 (struct face_cache.size): Now ptrdiff_t, for convenience in use
517 with xpalloc. The values are still always <= INT_MAX.
518
519 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
520
521 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
522 (SAFE_NALLOCA): New macro.
523
524 * region-cache.c (struct boundary.pos, find_cache_boundary)
525 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
526 (set_cache_region, invalidate_region_cache)
527 (revalidate_region_cache, know_region_cache, region_cache_forward)
528 (region_cache_backward, pp_cache):
529 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
530 so that ptrdiff_t * can be passed to xpalloc.
531 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
532 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
533 (pp_cache): Don't assume cache_len fits in int.
534 * region-cache.h: Adjust extern decls to match.
535
536 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
537 EMACS_INT, since either will do, for xpalloc.
538
539 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
540 (xnmalloc, xnrealloc, xpalloc): New functions.
541
726e0ab1
PE
542 * bidi.c (bidi_shelve_header_size): New constant.
543 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
544 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
545
51f30bc5 546 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
547 * buffer.c (overlays_at, overlays_in, record_overlay_string)
548 (overlay_strings):
549 Don't update size of array until after memory allocation succeeds,
550 because xmalloc/xrealloc may not return.
0065d054
PE
551 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
552 now that we have proper integer overflow checking.
553 (record_overlay_string, overlay_strings): Catch overflows when
554 calculating size of overlay_str_buf.
726e0ab1 555
0065d054
PE
556 * callproc.c (Fcall_process): Check for size overflow when
557 calculating size of args2.
558 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
559 Normally we prefer signed values, but sticking with ptrdiff_t would
560 require adding more-complicated checks.
726e0ab1
PE
561
562 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
563 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
564 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 565 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
566
567 * character.c (Fstring): Check for size-calculation overflow.
568
569 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
570 unnecessary integer overflow. Check for size overflow.
571 (encode_coding_object): Don't update size until xmalloc succeeds.
572
573 * composite.c (get_composition_id): Check for overflow in glyph
574 length calculations.
575
576 Integer and memory overflow fixes for display code.
577 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
578 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
579 (scrolling_window): Check for overflow in size calculations.
580 (line_draw_cost, realloc_glyph_pool, add_row_entry):
581 Don't assume glyph table len fits in int.
582 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
583 (row_table_size): Now ptrdiff_t, not int.
584 (scrolling_window): Avoid overflow in size calculations.
585 Don't update size until allocation succeeds.
586 * fns.c (concat): Check for overflow in size calculations.
587 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
588 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
589 (NEXT_ALMOST_PRIME_LIMIT): New constant.
590
591 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
592 (get_doc_string): Check for size calculation overflow.
593 Don't update size until allocation succeeds.
594 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
595 EMACS_INT, where ptrdiff_t will do.
596 (Fsubstitute_command_keys): Check for string overflow.
597
598 * editfns.c (set_time_zone_rule): Don't assume environment length
599 fits in int.
600 (message_length): Now ptrdiff_t, not int.
601 (Fmessage_box): Don't update size until allocation succeeds.
602 Don't assume message length fits in int.
603 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
604
0065d054
PE
605 * emacs.c (main): Do not reallocate argv, since there is a null at
606 the end that can be overwritten, and this way there's no need to
607 worry about size-calculation overflow.
608 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
609
610 * eval.c (init_eval_once, grow_specpdl): Don't update size until
611 alloc succeeds.
612 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
613
614 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
615 (x_set_scroll_bar_width, x_figure_window_size):
616 Check for integer overflow.
617 (x_set_alpha): Do not assume XINT fits in int.
618
619 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
620 This is for the members text_lines, text_cols, total_lines, total_cols,
621 where the system imposes an 'int' limit.
622
623 * fringe.c (Fdefine_fringe_bitmap):
624 Don't update size until alloc works.
625
626 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
627 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
628
629 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
630 Check for size-calculation overflow.
631 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
632 do, as we prefer signed integers.
633 (id_to_widget.max_size, id_to_widget.used)
634 (xg_store_widget_in_map, xg_remove_widget_from_map)
635 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
636 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
637 Use and return ptrdiff_t, not int.
638 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
639 * gtkutil.h: Change prototypes to match the above.
640
641 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
642 are duplicate now that they've been promoted to lisp.h.
643 (x_allocate_bitmap_record, x_alloc_image_color)
644 (make_image_cache, cache_image, xpm_load):
645 Don't update size until alloc is done.
646 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
647 (x_detect_edges):
3256efce 648 Check for size calculation overflow.
726e0ab1
PE
649 (ct_colors_allocated_max): New constant.
650 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
651 overflow.
3256efce 652
726e0ab1
PE
653 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
654 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
655 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
656 Use ptrdiff_t, not int, to count maps.
657 (read_char_minibuf_menu_prompt): Check for overflow in size
658 calculations. Don't update size until allocation succeeds. Redo
659 calculations to avoid overflow.
660 * keyboard.h: Change prototypes to match the above.
661
662 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
663 to count maps.
664 (current_minor_maps): Check for size calculation overflow.
665 * keymap.h: Change prototypes to match the above.
666
667 * lread.c (read1, init_obarray): Don't update size until alloc done.
668
669 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
670 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
671
726e0ab1
PE
672 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
673 Now ptrdiff_t, not int.
674 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
675 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
676
677 * process.c (Fnetwork_interface_list): Check for overflow
678 in size calculation.
679
680 * region-cache.c (move_cache_gap): Check for size calculation overflow.
681
682 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
683 overflow. Don't bother calling xmalloc when xrealloc will do.
684
685 * search.c (Freplace_match): Check for size calculation overflow.
686 (Fset_match_data): Don't assume list lengths fit in 'int'.
687
688 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
689 for command line length. Do not attempt to address one before the
690 beginning of an array, as that's not portable.
691
692 * term.c (max_frame_lines): Remove; unused.
693 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
694 not int.
695 (encode_terminal_code, calculate_costs): Check for size
696 calculation overflow.
697 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
698 table lengths and related sizes. Don't update size until alloc
699 done. Redo calculations to avoid overflow.
700 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
701
702 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
703 subtracting pointers.
704 (gobble_line): Check for overflow more carefully. Don't update size
705 until alloc done.
706
707 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
708 Don't update size until alloc done.
709 Redo size calculations to avoid overflow.
710 Check for size calculation overflow.
0065d054 711 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
712
713 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
714 Use ptrdiff_t, not int, for sizes.
715 (store_mode_line_noprop_char): Don't update size until alloc done.
716
0065d054
PE
717 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
718 Use ptrdiff_t, not int, for sizes.
719 (Finternal_make_lisp_face, cache_face):
720 Check for size calculation overflow.
721 (cache_face): Treat size calculation overflows as if they were
722 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
723
724 * xfns.c (x_encode_text, x_set_name_internal)
725 (Fx_change_window_property): Use ptrdiff_t, not int, to count
726 sizes, since they can exceed INT_MAX in size. Check for size
727 calculation overflow.
728
0065d054
PE
729 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
730 (xg_select): Check for size calculation overflow.
726e0ab1
PE
731 Don't update size until alloc done.
732
0065d054 733 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 734 as sprintf is limited to int lengths.
1d526e2f 735
252c5ee1
PE
736 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
737 (X_LONG_MIN): New macros.
864d7ce7
PE
738 Use them to make the following changes clearer.
739 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
740 This change doesn't affect the value now, but it may help remind
741 future maintainers not to raise the value too much later.
742 (SELECTION_QUANTUM): Remove, replacing with ...
743 (selection_quantum): ... new function, which avoids overflow.
744 All uses changed.
745 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
746 assumption that selection length fits in 'int'.
747 (x_reply_selection_request, x_handle_selection_request)
748 (x_get_window_property, receive_incremental_selection)
749 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
750 (lisp_data_to_selection_data, clean_local_selection_data):
751 Use ptrdiff_t, not int, to record length of selection.
752 (x_reply_selection_request, x_get_window_property)
753 (receive_incremental_selection, x_property_data_to_lisp):
754 Redo calculations to avoid overflow.
755 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 756 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
757 something.
758 (x_get_window_property, receive_incremental_selection)
759 (lisp_data_to_selection_data, x_property_data_to_lisp):
760 Check for size-calculation overflow.
761 (x_get_window_property, receive_incremental_selection)
762 (lisp_data_to_selection_data, Fx_register_dnd_atom):
763 Don't store size until memory allocation succeeds.
764 (x_get_window_property): Plug memory leak on memory exhaustion.
765 Don't double-block input; malloc is safe here. Don't assume 2**34
766 - 4 fits in unsigned long. Add an xassert to check
767 XGetWindowProperty overflow. Be more careful about overflow
768 calculations, and distinguish size from memory overflow better.
769 (receive_incremental_selection): When tracing, don't assume
770 unsigned int is less than INT_MAX.
771 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
772 harmful) conversions of unsigned short to int.
773 (lisp_data_to_selection_data): Don't assume that integers
774 in the range -65535 through -1 fit in an X unsigned short.
775 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
776 result parameters unless successful. Rely on cons_to_unsigned
777 to report problems with elements; the old code wasn't right anyway.
778 (x_check_property_data): Check for int overflow; we cannot use
779 a wider type due to X limits.
780 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
781
726e0ab1 782 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 783
0065d054
PE
784 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
785 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
786 (x_color_cells): Don't store size until memory allocation succeeds.
787 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 788 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
789 (x_term_init): Don't assume length fits in int (sprintf is limited
790 to int size).
bc18e09d 791
ebfa62c0
PE
792 Use ptrdiff_t for composition IDs.
793 * character.c (lisp_string_width):
794 * composite.c (composition_table_size, n_compositions)
795 (get_composition_id, composition_gstring_from_id):
796 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
797 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
798 * window.c (Frecenter):
799 Use ptrdiff_t, not int, for composition IDs.
800 * composite.c (get_composition_id): Check for integer overflow.
801 * composite.h: Adjust prototypes to match the above changes.
802
d3411f89
PE
803 Use ptrdiff_t for hash table indexes.
804 * category.c (hash_get_category_set):
805 * ccl.c (ccl_driver):
806 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
807 * coding.c (coding_system_charset_list, detect_coding_system):
808 * coding.h (struct coding_system.id):
809 * composite.c (get_composition_id, gstring_lookup_cache):
810 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
811 * image.c (xpm_get_color_table_h):
812 * lisp.h (hash_lookup, hash_put):
813 * minibuf.c (Ftest_completion):
814 Use ptrdiff_t for hash table indexes, not int (which is too
815 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
816 32-bit --with-wide-int hosts).
817
e097a6fa
PE
818 * charset.c (Fdefine_charset_internal): Check for integer overflow.
819 Add a FIXME comment about memory leaks.
820 (syms_of_charset): Don't assume xmalloc returns.
821
5637687f
PE
822 Don't assume that stated character widths fit in int.
823 * character.c (Fchar_width, c_string_width, lisp_string_width):
824 * character.h (CHAR_WIDTH):
825 * indent.c (MULTIBYTE_BYTES_WIDTH):
826 Use sanitize_char_width to avoid undefined and/or bad behavior
827 with outlandish widths.
828 * character.h (sanitize_tab_width): Renamed from sanitize_width,
829 now that we have two such functions. All uses changed.
830 (sanitize_char_width): New inline function.
831
a2271ba2
PE
832 Don't assume that tab-width fits in int.
833 * character.h (sanitize_width): New inline function.
834 (SANE_TAB_WIDTH): New macro.
835 (ASCII_CHAR_WIDTH): Use it.
836 * indent.c (sane_tab_width): Remove. All uses replaced by
837 SANE_TAB_WIDTH (current_buffer).
838 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
839
18c52557
PE
840 * fileio.c: Integer overflow issues with file modes.
841 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
842
caeeedc1
PE
843 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
844 Remove unreachable code.
845 (read_hex, load_charset_map_from_file): Check for integer overflow.
846
50849c52
PE
847 * xterm.c: don't go over XClientMessageEvent limit
848 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
849 (x_send_scroll_bar_event): Likewise. Check that the size does not
850 exceed limits imposed by XClientMessageEvent, as well as the usual
851 ptrdiff_t and size_t limits.
852
b13995db
PE
853 * keyboard.c: Overflow, signedness and related fixes.
854 (make_lispy_movement): Use same integer type in forward decl
855 that is used in the definition.
856 (read_key_sequence, keyremap_step):
857 Change bufsize argument back to int, undoing my 2011-03-30 change.
858 We prefer signed types, and int is wide enough here.
859 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
860 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
861 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
862 length, not size_t. Use ptrdiff_t for index, not int.
863 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
864 possibility of integer overflow.
865
13464394
PE
866 Overflow, signedness and related fixes for images.
867
868 * dispextern.h (struct it.stack[0].u.image.image_id)
869 (struct_it.image_id, struct image.id, struct image_cache.size)
870 (struct image_cache.used, struct image_cache.ref_count):
871 * gtkutil.c (update_frame_tool_bar):
872 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
873 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
874 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
875 * nsmenu.m (update_frame_tool_bar):
876 * xdisp.c (calc_pixel_width_or_height):
877 * xfns.c (image_cache_refcount):
878 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
879 on typical 64-bit hosts.
880
881 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
882 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
883 Omit unnecessary casts to int.
884 (parse_image_spec): Check that integers fall into 'int' range
885 when the callers expect that.
886 (image_ascent): Redo ascent calculation to avoid int overflow.
887 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
888 (lookup_image): Remove unnecessary tests.
889 (xbm_image_p): Locals are now of int, not EMACS_INT,
890 since parse_image_check makes sure they fit into int.
891 (png_load, gif_load, svg_load_image):
892 Prefer int to unsigned where either will do.
893 (tiff_handler): New function, combining the cores of the
894 old tiff_error_handler and tiff_warning_handler. This
895 function is rewritten to use vsnprintf and thereby avoid
896 stack buffer overflows. It uses only the features of vsnprintf
897 that are common to both POSIX and native Microsoft.
898 (tiff_error_handler, tiff_warning_handler): Use it.
899 (tiff_load, gif_load, imagemagick_load_image):
900 Don't assume :index value fits in 'int'.
901 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
902 (imagemagick_load_image): Check that crop parameters fit into
903 the integer types that MagickCropImage accepts. Don't assume
904 Vimagemagick_render_type has a nonnegative value. Don't assume
905 size_t fits in 'long'.
906 (gs_load): Use printmax_t to print the widest integers possible.
907 Check for integer overflow when computing image height and width.
908
c11821d4
EZ
9092011-08-26 Eli Zaretskii <eliz@gnu.org>
910
911 * xdisp.c (redisplay_window): Don't force window start if point
912 will be invisible in the resulting window. (Bug#9324)
913
0c95fcf7
EZ
9142011-08-25 Eli Zaretskii <eliz@gnu.org>
915
916 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
917 the display spec is of the form `(space ...)'.
918 (handle_display_spec): Return the value returned by
919 handle_single_display_spec, not just 1 or zero.
920 (handle_single_display_spec): If the display spec is of the form
921 `(space ...)', and specifies display in the text area, return 2
922 rather than 1.
fee65a97 923 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
924 accurately, and prefer exact match for point under bidi. Don't
925 advance `row' beyond the last row of the window.
0c95fcf7
EZ
926
927 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
928 into disp_prop; all users changed.
929
930 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
931 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
932 for the text covered by the display property.
933
e4ed06f1
CY
9342011-08-25 Chong Yidong <cyd@stupidchicken.com>
935
936 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
937 Change return value to nil.
938 (Frecord_buffer): Delete unused function.
939
f67cdd7f
EZ
9402011-08-24 Eli Zaretskii <eliz@gnu.org>
941
5980d4c6
EZ
942 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
943 buffers, return left-to-right.
8610fe8b
EZ
944 (set_cursor_from_row): Consider candidate row a win if its glyph
945 represents a newline and point is on that newline. Fixes cursor
946 positioning on the newline at EOL of R2L text within L2R
947 paragraph, and vice versa.
948 (try_cursor_movement): Check continued rows, in addition to
949 continuation rows. Fixes unwarranted scroll when point enters a
950 continued line of R2L text within an L2R paragraph, or vice versa.
951 (cursor_row_p): Consider the case of point being equal to
952 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
953 from the end of a short line to the beginning of a continued line
954 of R2L text within L2R paragraph.
955 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
956 composed characters.
5980d4c6 957
f67cdd7f
EZ
958 * bidi.c (bidi_check_type): Use xassert.
959 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
960 members.
961
bca633fb
EZ
9622011-08-23 Eli Zaretskii <eliz@gnu.org>
963
964 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
965 a character.
966
4a5885a7
CY
9672011-08-23 Chong Yidong <cyd@stupidchicken.com>
968
969 * nsfont.m (ns_otf_to_script): Fix typo.
970
0902a04e
KH
9712011-08-22 Kenichi Handa <handa@m17n.org>
972
973 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
974 extra slot even if the purpose is char-code-property-table.
975
1a2e6670
EZ
9762011-08-23 Eli Zaretskii <eliz@gnu.org>
977
8ddde651
EZ
978 * xdisp.c (redisplay_window): When computing centering_position,
979 account for the height of the header line. (Bug#8874)
980
425cc014
EZ
981 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
982 instead of CHAR_TO_BYTE. Fixes a crash when a completion
983 candidate is selected by the mouse, and that candidate has a
984 composed character under the mouse.
985
1a2e6670
EZ
986 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
987 coordinates reported by pos-visible-in-window-p for a composed
988 character in column zero.
989
8b76d6f8
SM
9902011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
991
992 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
993
dac347dd
EZ
9942011-08-22 Eli Zaretskii <eliz@gnu.org>
995
996 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
997 consider it a hit if to_charpos is anywhere in the range of the
998 composed buffer positions.
999
e013fb34
CY
10002011-08-22 Chong Yidong <cyd@stupidchicken.com>
1001
1002 * image.c (gif_load): Don't assume that each subimage has the same
1003 dimensions as the base image. Handle disposal method that is
1004 "undefined" by the gif spec (Bug#9335).
1005
bd1ba3e8
CY
10062011-08-20 Chong Yidong <cyd@stupidchicken.com>
1007
1008 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1009 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1010
54a1215b
EZ
10112011-08-19 Eli Zaretskii <eliz@gnu.org>
1012
823564e5
EZ
1013 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1014 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1015 from an Org mode buffer to a Speedbar frame.
1016
54a1215b
EZ
1017 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1018 a composition, take its buffer position from IT->cmp_it.charpos.
1019 Fixes cursor positioning at the beginning of a line that begins
1020 with a composed character.
1021
9778ebcc
EZ
10222011-08-18 Eli Zaretskii <eliz@gnu.org>
1023
0be6ee06
EZ
1024 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1025 character bidirectional type, use STRONG_L instead. Fixes crashes
1026 in a buffer produced by `describe-categories'.
1027
9778ebcc
EZ
1028 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1029 members before the level stack, so they would be saved and
1030 restored when copying iterator state. Fixes incorrect reordering
1031 around TABs covered by display properties.
1032
156bffbe
AS
10332011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1034
1035 * process.c (Fnetwork_interface_list): Correctly determine buffer
1036 size.
1037
72ad093b
CY
10382011-08-17 Chong Yidong <cyd@stupidchicken.com>
1039
1040 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1041 (internal_condition_case_2, internal_condition_case_n):
1042 Remove unnecessary aborts (Bug#9081).
72ad093b 1043
35774242
EZ
10442011-08-17 Eli Zaretskii <eliz@gnu.org>
1045
1046 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1047 has no `load' handler, try opening the file locally. (Bug#9311)
1048
db76dd85
KB
10492011-08-16 Ken Brown <kbrown@cornell.edu>
1050
1051 * gmalloc.c: Expand comment.
1052
b215eee5
EZ
10532011-08-16 Eli Zaretskii <eliz@gnu.org>
1054
1055 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1056 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1057
a4579d33
KB
10582011-08-16 Ken Brown <kbrown@cornell.edu>
1059
1060 Fix memory allocation problems in Cygwin build (Bug#9273).
1061
1062 * unexcw.c ( __malloc_initialized): Declare external variable.
1063 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1064
8b76d6f8
SM
1065 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1066 New variables.
a4579d33
KB
1067 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1068 dumped emacs.
1069 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1070 in the static heap.
1071 [CYGWIN] (special_realloc): New function.
1072 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1073 requests to realloc storage in the static heap.
1074
3ebec551
PE
10752011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 * bidi.c (bidi_initialize): Remove unused local.
1078
9fd8be00
EZ
10792011-08-15 Eli Zaretskii <eliz@gnu.org>
1080
474a8465
EZ
1081 * biditype.h: File removed.
1082
1083 * bidimirror.h: File removed.
1084
1085 * deps.mk (bidi.o): Remove biditype.h and
1086 bidimirror.h.
1087
1088 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1089 bidimirror.h.
1090
1091 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1092
1093 * chartab.c: Improve commentary for the uniprop_table API.
1094
32413314
EZ
1095 * bidi.c (bidi_paragraph_init): Support zero value of
1096 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1097 (bidi_initialize): Use uniprop_table instead of including
1098 biditype.h and bidimirror.h.
32413314 1099
9fd8be00
EZ
1100 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1101 coordinates of the iterator when restoring from ppos_it.
1102 (Bug#9296)
1103
5cf2b69b
KH
11042011-08-14 Kenichi Handa <handa@m17n.org>
1105
1106 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1107 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1108
daf17d00
EZ
11092011-08-14 Eli Zaretskii <eliz@gnu.org>
1110
1111 * xdisp.c (move_it_in_display_line_to): Don't invoke
1112 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1113 ppos_it. Fixes vertical cursor motion when line beginning is
1114 covered by an image. (Bug#9296)
1115
08e3161a
JD
11162011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1117
1118 * nsterm.h (ns_run_ascript): Declare.
1119 (NSAPP_DATA2_RUNASSCRIPT): Define.
1120
1121 * nsfns.m (as_script, as_result, as_status): New static variables.
1122 (ns_run_ascript): New function.
5e617bc2 1123 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1124 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1125 the event loop. Get status from as_status (Bug#7276).
1126
1127 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1128 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1129 the event loop (Bug#7276).
1130
a3720aa2
AS
11312011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1132
1133 * gnutls.c (QCgnutls_bootprop_priority)
1134 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1135 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1136 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1137 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1138 (QCgnutls_bootprop_verify_hostname_error)
1139 (QCgnutls_bootprop_callbacks_verify): Rename from
1140 Qgnutls_bootprop_..., all uses changed.
1141
1142 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1143 uses changed.
1144
0a0d27fb
PE
11452011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1146
19d5c50c
PE
1147 * xfaces.c (Qframe_set_background_mode): Now static.
1148 * dispextern.h (Qframe_set_background_mode): Remove decl.
1149
0a0d27fb
PE
1150 * process.c (Fnetwork_interface_info): Declare local only if needed.
1151
377538cb
JD
11522011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1153
1154 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1155 (Fnetwork_interface_list): Allocate in increments of bytes instead
1156 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1157 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1158 sockaddr.
1159 (struct ifflag_def): notrailers is smart on OSX.
1160 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1161 Get hardware address with getifaddrs if available.
1162
08fff70c
EZ
11632011-08-12 Eli Zaretskii <eliz@gnu.org>
1164
1165 * xdisp.c (iterate_out_of_display_property): xassert that
1166 IT->position is set to within IT->object's boundaries. Break from
1167 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1168 when IT->position is set up wrongly due to some bug.
1169 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1170 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1171 entry. Force push_it to save on the stack the current
1172 buffer/string position, to be restored by pop_it. Fix flags in
1173 the iterator structure wrt the object coming from a display
1174 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1175 properties. (Bug#9284)
1176
7be1c708 11772011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1178
7be1c708
CY
1179 * fontset.c (fontset_get_font_group): Add proper type checks.
1180 (Bug#9172)
aac0c6e3 1181
7be1c708 11822011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1183
7be1c708
CY
1184 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1185 and LC_VERSION_MIN_MACOSX.
1186 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1187 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1188
97bb72a6
EZ
11892011-08-08 Eli Zaretskii <eliz@gnu.org>
1190
1191 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1192 no-display-properties-and-no-overlays under bidi display.
1193 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1194 properties and overlays.
97bb72a6 1195
d5617611
CY
11962011-08-08 Chong Yidong <cyd@stupidchicken.com>
1197
37e11a63
CY
1198 * editfns.c (Fset_time_zone_rule): Document relationship with the
1199 setenv function.
1200
d5617611
CY
1201 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1202 the font entity extracted from the cache (Bug#8109).
1203
58872834
CY
12042011-08-07 Chong Yidong <cyd@stupidchicken.com>
1205
1206 * composite.c (autocmp_chars): Don't reset point. That is done by
1207 restore_point_unwind (Bug#5984).
1208
75bfc667
JL
12092011-08-07 Juri Linkov <juri@jurta.org>
1210
1211 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1212 to show the arg `TIME' instead of `TIMEVAL'.
1213
d1410150
EZ
12142011-08-06 Eli Zaretskii <eliz@gnu.org>
1215
1216 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1217 display property strides EOL and includes a newline, as in
1218 longlines-mode. (Bug#9254)
75b771e4
EZ
1219 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1220 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1221
1222 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1223 is non-zero, even if the data buffer is NULL. Fixes a crash in
1224 vertical-motion with longlines-mode. (Bug#9254)
1225
35928349
EZ
12262011-08-05 Eli Zaretskii <eliz@gnu.org>
1227
ec7cc85b
EZ
1228 * bidi.c <bidi_cache_total_alloc>: Now static.
1229 (bidi_initialize): Initialize bidi_cache_total_alloc.
1230
8b76d6f8 1231 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1232 cache. (Bug#9221)
1233
1234 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1235 amount allocated this far in `bidi_cache_total_alloc'.
1236 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1237 non-zero, only free the data buffer without restoring the cache
1238 contents. All callers changed.
1239
1240 * dispextern.h (bidi_unshelve_cache): Update prototype.
1241
1242 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1243 (move_it_in_display_line, move_it_to)
1244 (move_it_vertically_backward, move_it_by_lines): Replace the call
1245 to xfree to an equivalent call to bidi_unshelve_cache.
1246 (move_it_in_display_line_to): Fix logic of returning
412b6358 1247 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1248
e2e2423b
EZ
12492011-08-05 Eli Zaretskii <eliz@gnu.org>
1250
1251 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1252 came from a string character with a `cursor' property. (Bug#9229)
1253
ae9e757a
JD
12542011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1255
1256 * Makefile.in (LIB_PTHREAD): New variable.
1257 (LIBES): Add LIB_PTHREAD (Bug#9216).
1258
1259 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1260 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1261
213bd7f2
AS
12622011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1263
1264 * regex.c (re_iswctype): Remove some redundant boolean
1265 conversions.
1266
99aaf75f
JD
12672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1268
1269 * xterm.c (x_find_topmost_parent): New function.
1270 (x_set_frame_alpha): Find topmost parent window with
1271 x_find_topmost_parent and set the property there also (bug#9181).
1272 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1273
c74e9d86
PE
12742011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1275
1276 * callproc.c (Fcall_process): Avoid vfork clobbering
1277 the local vars buffer, coding_systems, current_dir.
1278
640c8776
SM
12792011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1280
1281 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1282
f26d0e4c
PE
12832011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1284
8a10d76c
PE
1285 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1286 so that it is not optimized away.
1287
f26d0e4c
PE
1288 * xdisp.c (compute_display_string_pos): Remove unused local.
1289
55439c61
EZ
12902011-08-02 Eli Zaretskii <eliz@gnu.org>
1291
1292 Fix slow cursor motion and scrolling in large buffers with
1293 selective display, like Org Mode buffers. (Bug#9218)
1294
1295 * dispextern.h (struct bidi_it): New member disp_prop_p.
1296
1297 * xdisp.c: Remove one-slot cache of display string positions.
1298 (compute_display_string_pos): Accept an additional argument
5e617bc2 1299 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1300 for a display string or property. If found, set DISP_PROP_P
1301 non-zero.
1302
1303 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1304 DISP_PROP_P, and pass it to compute_display_string_pos.
1305 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1306 non-zero. All callers of bidi_fetch_char changed.
1307
fb33fa43
SM
13082011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1309
1310 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1311
b099e063
DM
13122010-12-03 Don March <don@ohspite.net>
1313
1314 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1315 last character M-[char] is translated to ESC [char] (bug#7541).
1316
5cc7f7af
KH
13172011-08-02 Kenichi Handa <handa@m17n.org>
1318
d0fffa3f 1319 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1320
1321 * chartab.c (uniprop_table): Make it non-static.
1322
525d5e6e
EZ
13232011-08-01 Eli Zaretskii <eliz@gnu.org>
1324
1325 * xdisp.c (forward_to_next_line_start): Accept additional argument
1326 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1327 on the newline.
1328 (reseat_at_next_visible_line_start): Use the bidi iterator state
1329 returned by forward_to_next_line_start to restore the state of
1330 it->bidi_it after backing up to previous newline. (Bug#9212)
1331
31011111
AS
13322011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1333
1334 * regex.c (re_comp): Protoize.
1335 (re_exec): Fix return type.
1336 (regexec): Fix type of `ret'. (Bug#9203)
1337
476371c4
PE
13382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1339
e5d76069
PE
1340 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1341 This is needed if max-image-size is a floating-point number.
1342
9a79b20c
AS
13432011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1344
1345 * print.c (print_object): Print empty symbol as ##.
1346
1347 * lread.c (read1): Read ## as empty symbol.
1348
d8c2fa78
AA
13492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1350
1351 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1352 setting frame foreground color (Bug#9175).
1353 (x_set_background_color): Likewise.
1354
ffe57a7a
AA
1355 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1356 contents (Bug#9176).
1357 (EmacsTooltip -init): Remove bezels and add shadows to
1358 tooltip windows.
1359
bf3492a5
AA
1360 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1361 or scroll bar (Bug#8470).
1362
d55e9c53
AA
1363 * nsfont.m (nsfont_open): Remove assignment to voffset and
1364 unnecessary vars hshink, expand, hd, full_height, min_height.
1365 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1366
1367 * nsterm.h (nsfont_info): Remove voffset field.
1368
d8c2fa78 13692011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1370
1371 Implement strike-through and overline on NextStep (Bug#8863).
1372
1373 * nsfont.m (nsfont_open): Use underline position provided by font,
1374 instead of hard-coded value of 2.
1375 (nsfont_draw): Call ns_draw_text_decoration instead.
1376
1377 * nsterm.h: Add declaration for ns_draw_text_decoration.
1378
1379 * nsterm.m (ns_draw_text_decoration): New function for drawing
1380 underline, overline, and strike-through.
1381 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1382 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1383 accommodate underlining, etc.
4843aac3 1384
4cc60b9b
EZ
13852011-07-28 Eli Zaretskii <eliz@gnu.org>
1386
bc7ece87
EZ
1387 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1388 default.
4cc60b9b 1389
476371c4
PE
13902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1391
66606eea
PE
1392 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1393 Without this fix, if a signal arrives just after memory fills up,
1394 'malloc' might be invoked reentrantly.
1395
476371c4
PE
1396 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1397 In other words, assume that every image size is allowed, on non-X
1398 hosts. This assumption is probably wrong, but it lets Emacs compile.
1399
f3fcc40d
AS
14002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1401
1402 * regex.c (re_iswctype): Convert return values to boolean.
1403
350c992f
EZ
14042011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1405
1406 * xdisp.c (compute_display_string_pos): Don't use cached display
1407 string position if the buffer had its restriction changed.
1408 (Bug#9184)
1409
5266b4bb
PE
14102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1411
1412 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1413
2573a837 14142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1415
41f55ccd 1416 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1417
39e378da
PE
1418 * bidi.c: Integer size and overflow fixes.
1419 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1420 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1421 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1422 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1423 (bidi_find_other_level_edge):
1424 Use ptrdiff_t instead of EMACS_INT where either will do.
1425 This works better on 32-bit hosts configured --with-wide-int.
1426 (bidi_cache_ensure_space): Check for size-calculation overflow.
1427 Use % rather than repeated addition, for better worst-case speed.
1428 Don't set bidi_cache_size until after xrealloc returns, because it
1429 might not return.
1430 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1431 (bidi_cache_ensure_space): Also check that the bidi cache size
1432 does not exceed that of the largest Lisp string or buffer. See Eli
1433 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1434
5e927815
PE
1435 * alloc.c (__malloc_size_t): Remove.
1436 All uses replaced by size_t. See Andreas Schwab's note
1437 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1438
ca4aa935
PE
1439 * image.c: Improve checking for integer overflow.
1440 (check_image_size): Assume that f is nonnull, since
1441 it is always nonnull in practice. This is one less thing to
1442 worry about when checking for integer overflow later.
1443 (x_check_image_size): New function, which checks for integer
1444 overflow issues inside X.
1445 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1446 This removes the need for a memory_full check.
1447 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1448 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1449 (xbm_read_bitmap_data): Change locals back to 'int', since
1450 their values must fit in 'int'.
1451 (xpm_load_image, png_load, tiff_load):
1452 Invoke x_create_x_image_and_pixmap earlier,
1453 to avoid much needless work if the image is too large.
1454 (tiff_load): Treat overly large images as if
1455 x_create_x_image_and_pixmap failed, not as malloc failures.
1456 (gs_load): Use x_check_image_size.
1457
5f8f9cc2
PE
1458 * gtkutil.c: Omit integer casts.
1459 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1460 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1461
5adf60bc
PE
1462 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1463
c8907a93
PE
1464 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1465 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1466 would wrongly return t on a 64-bit host.
1467
e3c25c68
PE
1468 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1469 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1470 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1471 and therefore cause GCC to emit a bogus diagnostic in some cases.
1472
3f791afe
PE
1473 * image.c: Integer signedness and overflow and related fixes.
1474 This is not an exhaustive set of fixes, but it's time to
1475 record what I've got.
1476 (lookup_pixel_color, check_image_size): Remove redundant decls.
1477 (check_image_size): Don't assume that arbitrary EMACS_INT values
1478 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1479 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1480 (tiff_load, imagemagick_load_image):
1481 Check for overflow in size calculations.
1482 (x_create_x_image_and_pixmap): Remove unnecessary test for
1483 xmalloc returning NULL; that can't happen.
1484 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1485 (xpm_color_bucket): Use better integer hashing function.
1486 (xpm_cache_color): Don't possibly over-allocate memory.
1487 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1488 (gif_memory_source):
1489 Use ptrdiff_t, not int or size_t, to record sizes.
1490 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1491 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1492 either works, as we prefer signed integers.
1493 (tiff_read_from_memory, tiff_write_from_memory):
1494 Return tsize_t, not size_t, since that's what the TIFF API wants.
1495 (tiff_read_from_memory): Don't fail simply because the read would
1496 go past EOF; instead, return a short read.
1497 (tiff_load): Omit no-longer-needed casts.
1498 (Fimagemagick_types): Don't assume size fits into 'int'.
1499
3cc5a532
PE
1500 Improve hashing quality when configured --with-wide-int.
1501 * fns.c (hash_string): New function, taken from sxhash_string.
1502 Do not discard information about ASCII character case; this
1503 discarding is no longer needed.
1504 (sxhash-string): Use it. Change sig to match it. Caller changed.
1505 * lisp.h: Declare it.
1506 * lread.c (hash_string): Remove, since we now use fns.c's version.
1507 The fns.c version returns a wider integer if --with-wide-int is
1508 specified, so this should help the quality of the hashing a bit.
1509
b312a492
PE
1510 * emacs.c: Integer overflow minor fix.
1511 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1512 Define only if GNU_LINUX.
1513 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1514
dfd153ae
PE
1515 * dispnew.c: Integer signedness and overflow fixes.
1516 Remove unnecessary forward decls, that were a maintenance hassle.
1517 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1518 All uses changed.
1519 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1520 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1521 (prepare_desired_row, line_draw_cost):
1522 Use int, not unsigned, where either works.
1523 (save_current_matrix, restore_current_matrix):
1524 Use ptrdiff_t, not size_t, where either works.
1525 (init_display): Check for overflow more accurately, and without
1526 relying on undefined behavior.
1527
a81d11a3
PE
1528 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1529 Remove, replacing with the new symbols in lisp.h. All uses changed.
1530 * fileio.c (make_temp_name):
1531 * filelock.c (lock_file_1, lock_file):
1532 * xdisp.c (message_dolog):
1533 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1534 Use pMd etc. instead.
1535 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1536 replacing the pWIDE etc. symbols removed from editfns.c.
1537
3300e6fd
PE
1538 * keyboard.h (num_input_events): Now uintmax_t.
1539 This is (very slightly) less likely to mess up due to wraparound.
1540 All uses changed.
1541
fd05c7e9
PE
1542 * buffer.c: Integer signedness fixes.
1543 (alloc_buffer_text, enlarge_buffer_text):
1544 Use ptrdiff_t rather than size_t when either will do, as we prefer
1545 signed integers.
1546
903fe15d
PE
1547 * alloc.c: Integer signedness and overflow fixes.
1548 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1549 (__malloc_size_t): Default to size_t, not to int.
1550 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1551 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1552 Prefer ptrdiff_t to size_t when either would do, as we prefer
1553 signed integers.
1554 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1555 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1556 Now const. Initialize with values that are in range even if char
1557 is signed.
1558 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1559 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1560 These functions do the right thing with sizes > 2**32.
1561 (check_depth): Now ptrdiff_t, not int.
1562 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1563 Adjust to new way of storing sizes. Check for size overflow bugs
1564 in rest of code.
1565 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1566 slightly wrong anyway, as it missed one instance of
1567 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1568 (refill_memory_reserve): Omit needless cast to size_t.
1569 (mark_object_loop_halt): Mark as externally visible.
1570
ac82cc6a
PE
1571 * xselect.c: Integer signedness and overflow fixes.
1572 (Fx_register_dnd_atom, x_handle_dnd_message):
1573 Use ptrdiff_t, not size_t, since we prefer signed.
1574 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1575 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1576 x_dnd_atoms_size and x_dnd_atoms_length.
1577
c2d1e36d
PE
1578 * doprnt.c: Prefer signed to unsigned when either works.
1579 * eval.c (verror):
1580 * doprnt.c (doprnt):
1581 * lisp.h (doprnt):
1582 * xdisp.c (vmessage):
1583 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1584 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1585 prefer signed arithmetic to avoid comparison confusion.
1586 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1587 but is a bit tricky.
1588
0e926e56
PE
1589 Assume freestanding C89 headers, string.h, stdlib.h.
1590 * data.c, doprnt.c, floatfns.c, print.c:
1591 Include float.h unconditionally.
1592 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1593 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1594 * regex.c: Likewise for stddef.h, string.h.
1595 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1596 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1597 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1598 (STDC_HEADERS): Remove obsolete defines.
1599 * sysdep.c: Include limits.h unconditionally.
1600
9cfdb3ec
PE
1601 Assume support for memcmp, memcpy, memmove, memset.
1602 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1603 * regex.c (memcmp, memcpy):
1604 Remove; we assume C89 now.
1605
1606 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1607 (__malloc_safe_bcopy): Remove; no longer needed.
1608
cf950e6b 1609 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1610 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1611 well either way, and we prefer signed to unsigned.
1612
dbf38e02
LMI
16132011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1614
1615 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1616 closes the connection while we're reading (bug#9182).
1617
d6f0886c 16182011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1619
d6f0886c
JD
1620 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1621 are specified (Bug#9168).
24e0f6b1 1622
2eb1f9e6
PE
16232011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1624
1625 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1626 Found by GCC static checking and --with-wide-int on a 32-bit host.
1627
22381272 16282011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1629
1630 * xdisp.c (compute_display_string_pos): Fix logic of caching
1631 previous display string position. Initialize cached_prev_pos to
1632 -1. Fixes slow-down at the beginning of a buffer.
1633
f25e39b4
EZ
16342011-07-24 Eli Zaretskii <eliz@gnu.org>
1635
1636 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1637 for attrs[LFACE_FONTSET_INDEX].
1638
04c4b52e
PE
16392011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1640
1641 * xml.c (parse_region): Remove unused local
1642 that was recently introduced.
1643
c1734fbd
EZ
16442011-07-23 Eli Zaretskii <eliz@gnu.org>
1645
be18c5a5
EZ
1646 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1647 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1648
c1734fbd
EZ
1649 * xdisp.c (move_it_in_display_line_to): Record the best matching
1650 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1651 exit if none of the characters scanned was an exact match.
1652 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1653 when exact match is impossible due to invisible text, and the
1654 lines are truncated.
1655
a258d627
JD
16562011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1657
1658 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1659 for OSX >= 10.7.
1660
b6d5a689
EZ
16612011-07-22 Eli Zaretskii <eliz@gnu.org>
1662
0f74f785
EZ
1663 Fix a significant slow-down of cursor motion with C-n, C-p,
1664 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1665 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1666 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1667 (next_element_from_buffer): Call compute_stop_pos_backwards to
1668 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1669 base_level_stop.
1670 (reseat): Don't look for prev_stop, as that could mean a very long
1671 run.
1672 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1673 <cached_disp_overlay_modiff>: Cache for last found display string
1674 position.
551918c1 1675 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1676 about the same buffer in the same area of character positions, and
1677 the buffer wasn't changed since the time the display string
1678 position was cached.
551918c1 1679
b2d0c91a
EZ
16802011-07-22 Eli Zaretskii <eliz@gnu.org>
1681
1682 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1683 is an integer, which is important for empty lines. (Bug#9149)
1684
043604ee
CY
16852011-07-22 Chong Yidong <cyd@stupidchicken.com>
1686
1687 * frame.c (Fmodify_frame_parameters): In tty case, update the
1688 default face if necessary (Bug#4238).
1689
da4adb04
CY
16902011-07-21 Chong Yidong <cyd@stupidchicken.com>
1691
1692 * editfns.c (Fstring_to_char): No need to explain what a character
1693 is in the docstring (Bug#6576).
1694
9abd0532
LMI
16952011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1696
1697 * xml.c (parse_region): Make sure we always return a tree.
1698
36881d16
HK
16992011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1700
1701 * xml.c (parse_region): If a document contains only comments,
1702 return that, too.
1703
1e98674d
LMI
17042011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1705
1706 * xml.c (make_dom): Return comments, too.
1707
590bd467
PE
17082011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1709
1710 Port to OpenBSD.
1711 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1712 and the surrounding thread.
1713 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1714 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1715 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1716 timer goes off.
1717 * s/openbsd.h (BROKEN_SIGIO): Define.
1718 * unexelf.c (unexec) [__OpenBSD__]:
1719 Don't update the .mdebug section of the Alpha COFF symbol table.
1720
f41628b2
LMI
17212011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1722
1723 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1724 (bug#8460).
1725
b59b67c5
PE
17262011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1727
15e3a074
PE
1728 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1729 This fixes some race conditions on the permissions of any newly
1730 created file.
1731
41bed37d
PE
1732 * alloc.c (valid_pointer_p): Use pipe, not open.
1733 This fixes some permissions issues when debugging.
1734
b59b67c5
PE
1735 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1736 If fchown fails to set both uid and gid, try to set just gid,
1737 as that is sometimes allowed. Adjust the file's mode to eliminate
1738 setuid or setgid bits that are inappropriate if fchown fails.
1739
925a6be7
SM
17402011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1741
1742 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1743 to compare Lisp_Objects.
1744 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1745 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1746 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1747
52968808
AS
17482011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1749
0a6a104b
AS
1750 * lread.c (read_integer): Unread even EOF character.
1751 (read1): Likewise. Properly record start position of symbol.
1752
52968808
AS
1753 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1754 symbol character follows.
1755
9e381cdd
PE
17562011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1757
1758 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1759 This works around a problem with the previous change to Fcopy_file.
1760 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1761 and without this change, GCC might complain about discarding
1762 fchown's return value.
1763
b5641435
JB
17642011-07-16 Juanma Barranquero <lekktu@gmail.com>
1765
1766 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1767
a8031457
PE
17682011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1769
1770 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1771
dd889327
LMI
17722011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1773
750c33f7
LMI
1774 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1775 it's used from the C level.
1776
dd889327
LMI
1777 * process.c: Use the same condition for POLL_FOR_INPUT in both
1778 keyboard.c and process.c (bug#1858).
1779
87e86684
LM
17802011-07-09 Lawrence Mitchell <wence@gmx.li>
1781
1782 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1783 (Fgnutls_boot): Use it.
1784
64348f40
AS
17852011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1786
1787 * doc.c (Fsubstitute_command_keys): Revert last change.
1788
1d698799
LMI
17892011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1790
f863868c
LMI
1791 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1792 quotes the next character, and doesn't affect other longer
1793 sequences (bug#8935).
1794
1d698799
LMI
1795 * lread.c (syms_of_lread): Clarify that is isn't only
1796 `eval-buffer' and `eval-defun' that's affected by
1797 `lexical-binding' (bug#8460).
1798
aa4b6df6
EZ
17992011-07-15 Eli Zaretskii <eliz@gnu.org>
1800
1801 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1802 bidi redisplay when a line includes both an image and is
1803 truncated.
1804
5d856da6
PE
18052011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1806
ad6042bb
PE
1807 Fix minor problems found by static checking.
1808 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1809 (elsz): Now a signed constant, not a size_t var. We prefer signed
1810 types to unsigned, to avoid integer comparison confusion. Without
1811 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1812 "cannot optimize loop, the loop counter may overflow", a symptom
1813 of the confusion.
f00bbb22 1814 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1815 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1816
6468f31c
LMI
18172011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1818
49080b10
LMI
1819 * search.c (Fre_search_backward): Mention `case-fold-search' in
1820 all the re_search_* functions (bug#8138).
1821
6468f31c
LMI
1822 * keyboard.c (Fopen_dribble_file): Document when the file is
1823 closed (bug#8056).
1824
c965adc5
EZ
18252011-07-14 Eli Zaretskii <eliz@gnu.org>
1826
df9733bf
EZ
1827 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1828 bidi_cache_idx.
1829
0bb23927
EZ
1830 Support bidi reordering of display and overlay strings.
1831 * xdisp.c (compute_display_string_pos)
1832 (compute_display_string_end): Accept additional argument STRING.
1833 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1834 (reseat_to_string): Initialize bidi_it->string.s and
1835 bidi_it->string.schars.
1836 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1837 NULL (avoids a crash in bidi_paragraph_init).
1838 Initialize itb.string.lstring.
0bb23927
EZ
1839 (init_iterator): Call bidi_init_it only of a valid
1840 buffer position was specified. Initialize paragraph_embedding to
1841 L2R.
1842 (reseat_to_string): Initialize the bidi iterator.
1843 (display_string): If we need to ignore text properties of
1844 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1845 original value of -1 will not work with bidi.)
1846 (compute_display_string_pos): First arg is now struct
1847 `text_pos *'; all callers changed. Support display properties on
1848 Lisp strings.
1849 (compute_display_string_end): Support display properties on Lisp
1850 strings.
1851 (init_iterator, reseat_1, reseat_to_string): Initialize the
1852 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1853 when iterating on a string not from display properties).
640c8776
SM
1854 (compute_display_string_pos, compute_display_string_end):
1855 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1856 arrow keys.
1857 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1858 base_level_stop; instead, set base_level_stop to BEGV.
1859 Fixes crashes in vertical-motion.
0bb23927
EZ
1860 (next_element_from_buffer): Improve commentary for when
1861 the iterator is before prev_stop.
1862 (init_iterator): Initialize bidi_p from the default value of
1863 bidi-display-reordering, not from buffer-local value. Use the
1864 buffer-local value only if initializing for buffer iteration.
1865 (handle_invisible_prop): Support invisible properties on strings
1866 that are being bidi-reordered.
1867 (set_iterator_to_next): Support bidi reordering of C strings and
1868 Lisp strings.
1869 (next_element_from_string): Support bidi reordering of Lisp
1870 strings.
1871 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1872 (display_string): Support display of R2L glyph rows.
1873 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1874 (init_iterator): Don't initialize it->bidi_p for strings
1875 here.
1876 (reseat_to_string): Initialize it->bidi_p for strings here.
1877 (next_element_from_string, next_element_from_c_string)
1878 (next_element_from_buffer): Add xassert's for correspondence
1879 between IT's object being iterated and it->bidi_it.string
1880 structure.
1881 (face_before_or_after_it_pos): Support bidi iteration.
1882 (next_element_from_c_string): Handle the case of the first string
1883 character that is not the first one in the visual order.
1884 (get_visually_first_element): New function, refactored from common
1885 parts of next_element_from_buffer, next_element_from_string, and
1886 next_element_from_c_string.
1887 (tool_bar_lines_needed, redisplay_tool_bar)
1888 (display_menu_bar): Force left-to-right direction. Add a FIXME
1889 comment for making that be controlled by a user option.
1890 (push_it, pop_it): Save and restore the state of the
1891 bidi iterator. Save and restore the bidi_p flag.
1892 (pop_it): Iterate out of display property for string iteration as
1893 well.
1894 (iterate_out_of_display_property): Support iteration over strings.
1895 (handle_single_display_spec): Set up it->bidi_it for iteration
1896 over a display string, and call bidi_init_it.
1897 (handle_single_display_spec, next_overlay_string)
1898 (get_overlay_strings_1, push_display_prop): Set up the bidi
1899 iterator for displaying display or overlay strings.
1900 (forward_to_next_line_start): Don't use the shortcut if
1901 bidi-iterating.
1902 (back_to_previous_visible_line_start): If handle_display_prop
1903 pushed the iterator stack, restore the internal state of the bidi
1904 iterator by calling bidi_pop_it same number of times.
1905 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1906 and we are bidi-iterating, don't decrement the iterator position;
1907 instead, set the first_elt flag in the bidi iterator, to produce
1908 the same effect.
1909 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1910 (push_display_prop): xassert that we are iterating a buffer.
1911 (push_it, pop_it): Save and restore paragraph_embedding member.
1912 (handle_single_display_spec, next_overlay_string)
1913 (get_overlay_strings_1, reseat_1, reseat_to_string)
1914 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1915 correctly. Don't assume unibyte strings are not bidi-reordered.
1916 (compute_display_string_pos)
1917 (compute_display_string_end): Fix handling the case of C string.
1918 (push_it, pop_it): Save and restore from_disp_prop_p.
1919 (handle_single_display_spec, push_display_prop): Set the
1920 from_disp_prop_p flag.
1921 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1922 (pop_it): Call iterate_out_of_display_property only if we are
1923 popping after iteration over a string that came from a display
1924 property. Fix a typo in popping stretch info. Add an assertion
1925 for verifying that the iterator position is in sync with the bidi
1926 iterator.
1927 (handle_single_display_spec, get_overlay_strings_1)
1928 (push_display_prop): Fix initialization of paragraph direction for
1929 string when that of the parent object is not yet determined.
1930 (reseat_1): Call bidi_init_it to resync the bidi
1931 iterator with IT's position. (Bug#7616)
1932 (find_row_edges): If ROW->start.pos gives position
1933 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1934 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1935 Reset the from_disp_prop_p flag.
1936 (SAVE_IT, RESTORE_IT): New macros.
1937 (pos_visible_p, face_before_or_after_it_pos)
1938 (back_to_previous_visible_line_start)
1939 (move_it_in_display_line_to, move_it_in_display_line)
1940 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1941 (try_scrolling, redisplay_window, display_line): Use them when
1942 saving a temporary copy of the iterator and restoring it back.
1943 (back_to_previous_visible_line_start, reseat_1)
1944 (init_iterator): Empty the bidi cache "stack".
1945 (move_it_in_display_line_to): If iterator ended up at
1946 EOL, but we never saw any buffer positions smaller than
1947 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1948 motion in bidi-reordered lines.
1949 (move_it_in_display_line_to): Record prev_method and prev_pos
1950 immediately before the call to set_iterator_to_next. Fixes cursor
1951 motion in bidi-reordered lines with stretch glyphs and strings
1952 displayed in margins. (Bug#8133) (Bug#8867)
1953 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1954 TO_CHARPOS.
640c8776
SM
1955 (pos_visible_p): Support positions in bidi-reordered lines.
1956 Save and restore bidi cache.
0bb23927
EZ
1957
1958 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1959 (bidi_paragraph_info): Delete unused struct.
1960 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1961 (bidi_cache_start): New variable.
1962 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1963 to zero.
1964 (bidi_cache_fetch_state, bidi_cache_search)
1965 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1966 (bidi_cache_find, bidi_peek_at_next_level)
1967 (bidi_level_of_next_char, bidi_find_other_level_edge)
1968 (bidi_move_to_visually_next): Compare cache index with
1969 bidi_cache_start rather than with zero.
1970 (bidi_fetch_char): Accept new argument STRING; all callers
1971 changed. Support iteration over a string. Support strings with
1972 display properties. Support unibyte strings. Fix the type of
1973 `len' according to what STRING_CHAR_AND_LENGTH expects.
1974 (bidi_paragraph_init, bidi_resolve_explicit_1)
1975 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1976 (bidi_level_of_next_char, bidi_move_to_visually_next):
1977 Support iteration over a string.
0bb23927
EZ
1978 (bidi_set_sor_type, bidi_resolve_explicit_1)
1979 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1980 can now be zero (for strings); special values 0 and -1 were
1981 changed to -1 and -2, respectively.
1982 (bidi_char_at_pos): New function.
1983 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1984 Call it instead of FETCH_MULTIBYTE_CHAR.
1985 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1986 initialized to valid values.
1987 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1988 values.
1989 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1990 the test for valid cached positions. Fix the logic for looking up
1991 the sentinel state in the cache. GCPRO the Lisp string we are
1992 iterating.
1993 (bidi_push_it, bidi_pop_it): New functions.
1994 (bidi_initialize): Initialize the bidi cache start stack pointer.
1995 (bidi_cache_ensure_space): New function, refactored from part of
1996 bidi_cache_iterator_state. Don't assume the required size is just
1997 one BIDI_CACHE_CHUNK away.
1998 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1999 (bidi_count_bytes, bidi_char_at_pos): New functions.
2000 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2001 always valid if bidi_cache_idx is valid.
2002 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2003 is valid if it's going to be used.
2004 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2005 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2006 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2007 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2008 (bidi_find_other_level_edge, bidi_cache_start_stack):
2009 All variables related to cache indices are now EMACS_INT.
c965adc5 2010
0bb23927
EZ
2011 * dispextern.h (struct bidi_string_data): New structure.
2012 (struct bidi_it): New member `string'. Make flag members be 1-bit
2013 fields, and put them last in the struct.
640c8776
SM
2014 (compute_display_string_pos, compute_display_string_end):
2015 Update prototypes.
0bb23927
EZ
2016 (bidi_push_it, bidi_pop_it): Add prototypes.
2017 (struct iterator_stack_entry): New members bidi_p,
2018 paragraph_embedding, and from_disp_prop_p.
2019 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2020 (bidi_shelve_cache, bidi_unshelve_cache):
2021 Declare prototypes.
0bb23927
EZ
2022
2023 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2024 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2025 and vector-like objects.
2026
2027 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2028 cache around display iteration.
2029
2030 * window.c (Fwindow_end, window_scroll_pixel_based)
2031 (displayed_window_lines, Frecenter): Save and restore the bidi
2032 cache around display iteration.
2033
3bbd2265
LMI
20342011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2035
2036 * editfns.c (Fdelete_region): Clarify the use of the named
2037 parameters (bug#6788).
2038
adc47434
MR
20392011-07-14 Martin Rudalics <rudalics@gmx.at>
2040
2041 * indent.c (Fvertical_motion): Set and restore w->pointm when
2042 saving and restoring the window's buffer (Bug#9006).
2043
837c31f8
LMI
20442011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2045
2046 * editfns.c (Fstring_to_char): Clarify just what is returned
2047 (bug#6576). Text by Eli Zaretskii.
2048
ac389d0c
JB
20492011-07-13 Juanma Barranquero <lekktu@gmail.com>
2050
2051 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2052
0be0ce47
EZ
20532011-07-13 Eli Zaretskii <eliz@gnu.org>
2054
2055 * buffer.c (mmap_find): Fix a typo.
2056
cd18e7e3
JB
20572011-07-13 Johan Bockgård <bojohan@gnu.org>
2058
2059 Fix execution of x selection hooks.
2060 * xselect.c (Qx_lost_selection_functions)
2061 (Qx_sent_selection_functions): New vars.
2062 (syms_of_xselect): DEFSYM them.
2063 (x_handle_selection_request): Pass Qx_sent_selection_functions
2064 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2065 (x_handle_selection_clear,x_clear_frame_selections):
2066 Pass Qx_lost_selection_functions rather than
2067 Vx_lost_selection_functions to Frun_hook_with_args.
2068
47ea7f44
PE
20692011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2070
ac389d0c 2071 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2072 The old code sometimes used this field without initializing it.
2073
47ea7f44
PE
2074 * alloc.c (gc_sweep): Don't read past end of array.
2075 In theory, the old code could also have corrupted Emacs internals,
2076 though it'd be very unlikely.
2077
bc985c87
AS
20782011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2079
2080 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2081 argument. (Bug#4026)
bc985c87 2082
0cf34688
LMI
20832011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2084
b3dadd76
LMI
2085 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2086 key" (bug#4257).
2087
0cf34688
LMI
2088 * window.c (Fset_window_start): Doc fix (bug#4199).
2089 (Fset_window_hscroll): Ditto.
2090
270768cd
PE
20912011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2092
077e3dda 2093 Fix minor new problems caught by GCC 4.6.1.
270768cd 2094 * term.c (init_tty): Remove unused local.
490011a6 2095 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2096 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2097 not used otherwise.
270768cd 2098
b1f58454
CY
20992011-07-12 Chong Yidong <cyd@stupidchicken.com>
2100
2101 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2102
22b9578d
LMI
21032011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2104
6e70ab07
LMI
2105 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2106 are the mini-buffer and the echo area (bug#3320).
2107
22b9578d
LMI
2108 * term.c (init_tty): Remove support for supdup, c10 and perq
2109 terminals, which are no longer supported (bug#1482).
2110
8974cc9f
JB
21112011-07-10 Johan Bockgård <bojohan@gnu.org>
2112
2113 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2114
a560d974
JD
21152011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2116
2117 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2118 for non-popups (Bug#3642).
2119
1dae0f0a
AS
21202011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2121
268c2c36 2122 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2123 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2124 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2125 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2126 * data.c (fmod): Likewise.
2127 * dispnew.c (swap_glyphs_in_rows): Likewise.
2128 * emacs.c (memory_warning_signal): Likewise.
2129 * floatfns.c (float_error): Likewise.
2130 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2131 (otf_open, font_otf_capability, generate_otf_features)
2132 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2133 Likewise.
2134 * image.c (pbm_read_file): Likewise.
2135 * indent.c (string_display_width): Likewise.
2136 * intervals.c (check_for_interval, search_for_interval)
2137 (inc_interval_count, count_intervals, root_interval)
2138 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2139 * lread.c (defalias): Likewise.
268c2c36 2140 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2141 * regex.c (set_image_of_range_1, set_image_of_range)
2142 (regex_grow_registers): Likewise.
2143 * sysdep.c (strerror): Likewise.
2144 * termcap.c (valid_filename_p, tprint, main): Likewise.
2145 * tparam.c (main): Likewise.
2146 * unexhp9k800.c (run_time_remap, save_data_space)
2147 (update_file_ptrs, read_header, write_header, calculate_checksum)
2148 (copy_file, copy_rest, display_header): Likewise.
2149 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2150 Likewise.
2151 * xdisp.c (check_it): Likewise.
2152 * xfaces.c (register_color, unregister_color, unregister_colors):
2153 Likewise.
2154 * xfns.c (print_fontset_result): Likewise.
2155 * xrdb.c (member, fatal, main): Likewise.
2156
99033785
PE
21572011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2158
2159 Fix minor problems found by static checking (Bug#9031).
2160 * chartab.c (char_table_set_range, map_sub_char_table):
2161 Remove unused locals.
2162 (uniprop_table): Now static.
2163 * composite.c (_work_char): Remove unused static var.
2164
9cb2ac56
JB
21652011-07-09 Juanma Barranquero <lekktu@gmail.com>
2166
2167 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2168
f25661f0
JD
21692011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2170
2171 * gtkutil.c (qttip_cb): Remove code without function.
2172
8278c4fe
EZ
21732011-07-09 Eli Zaretskii <eliz@gnu.org>
2174
2175 * w32.c (pthread_sigmask): New stub.
2176
1692ae2d 21772011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2178
8a6ebd58 2179 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2180 sigprocmask is portable only for single-threaded applications, and
2181 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2182 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2183 (LIBES): Use it.
2184 * callproc.c (Fcall_process):
2185 * process.c (create_process):
2186 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2187 Use pthread_sigmask, not sigprocmask.
123403e4 2188
1b854618
JD
21892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2190
2191 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2192 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2193 wrong (Bug#8591).
2194
3fe4b549
JD
21952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2196
0ce7e563
JD
2197 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2198 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2199 (xg_hide_tooltip): Fix comment.
2200
3fe4b549
JD
2201 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2202 in registerServicesMenuSendTypes.
2203 (validRequestorForSendType): Don't check ns_return_types.
2204
2205 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2206 ns_return_type.
2207
5df75e47
JR
22082011-07-08 Jason Rumney <jasonr@gnu.org>
2209
2210 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2211 frame struct members of non-existent frames (Bug#6284).
2212
699c10bd
JD
22132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2214
4393663b
JD
2215 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2216 variable firstTime not needed on OSX >= 10.6.
2217 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2218 >= 10.5. Use setKnobProportion, setDoubleValue.
2219
2220 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2221 (MAC_OS_X_VERSION_10_5): Define if not defined.
2222 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2223 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2224 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2225
2226 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2227 cString and lossyCString on OSX >= 10.4
2228
2229 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2230 sizeToFit on OSX >= 10.2.
2231
2232 * nsimage.m (allocInitFromFile): Don't use deprecated method
2233 bestRepresentationForDevice on OSX >= 10.6.
2234
2235 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2236 to avoid warning.
2237
2238 * emacs.c: Declare unexec_init_emacs_zone.
2239
a63e0781
JD
2240 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2241
699c10bd
JD
2242 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2243
2244 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2245 on svcsMenu (Bug#8842).
2246
2247 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2248 ns_return_types.
2249 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2250
2251 * nsterm.m (QUTF8_STRING): Declare.
2252 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2253 (validRequestorForSendType): Return type is (id).
2254 Change indexOfObjectIdenticalTo to indexOfObject.
2255 Check if we have local selection before returning self (Bug#8842).
2256 (writeSelectionToPasteboard): Put local selection into paste board
2257 if we have a local selection (Bug#8842).
2258 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2259
2260 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2261 (ns_get_local_selection): Declare.
2262
54e10184
LMI
22632011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2264
9888ff71
LMI
2265 * keymap.c (describe_map_tree): Don't insert a double newline at
2266 the end of the buffer (bug#1169) and return whether we inserted
2267 something.
2268
54e10184
LMI
2269 * callint.c (Fcall_interactively): Change "reading args" to
2270 "providing args" to try to clarify what it does (bug#1010).
2271
15fa4783
KH
22722011-07-07 Kenichi Handa <handa@m17n.org>
2273
2274 * composite.c (composition_compute_stop_pos): Ignore a static
2275 composition starting before CHARPOS (Bug#8915).
2276
2277 * xdisp.c (handle_composition_prop): Likewise.
2278
a8815b00
EZ
22792011-07-07 Eli Zaretskii <eliz@gnu.org>
2280
2281 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2282 (Bug#9015)
2283
ef7b981d 22842011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2285
2286 * character.h (unicode_category_t): New enum type.
2287
2288 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2289 (Qchar_code_property_table): New variable.
2290 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2291 (UNIPROP_COMPRESSED_FORM_P): New macros.
2292 (char_table_ascii): Uncompress the compressed values.
2293 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2294 Uncompress the compressed values.
ac389d0c 2295 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2296 (char_table_ref_and_range): Uncompress the compressed values.
2297 (sub_char_table_set): New arg is_uniprop. Callers changed.
2298 Uncompress the compressed values.
2299 (sub_char_table_set_range): Args changed. Callers changed.
2300 (char_table_set_range): Adjuted for the above change.
2301 (map_sub_char_table): Delete args default_val and parent. Add arg
2302 top. Give decoded values to a Lisp function.
640c8776 2303 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2304 values to a Lisp function. Gcpro more variables.
2305 (uniprop_table_uncompress)
2306 (uniprop_decode_value_run_length): New functions.
2307 (uniprop_decoder, uniprop_decoder_count): New variables.
2308 (uniprop_get_decoder, uniprop_encode_value_character)
2309 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2310 New functions.
2311 (uniprop_encoder, uniprop_encoder_count): New variables.
2312 (uniprop_get_encoder, uniprop_table)
2313 (Funicode_property_table_internal, Fget_unicode_property_internal)
2314 (Fput_unicode_property_internal): New functions.
2315 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2316 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2317 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2318 char-code-property-alist.
2319
640c8776 2320 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2321 Vunicode_category_table.
2322
640c8776 2323 * font.c (font_range): Adjust for the change of
c805dec0
KH
2324 Vunicode_category_table.
2325
76b397fb
DN
23262011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2327
2328 * m/iris4d.h: Remove file, move contents ...
2329 * s/irix6-5.h: ... here.
2330
22b4128e
PE
23312011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2332
2333 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2334 * alloc.c (mark_buffer):
2335 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2336 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2337 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2338 This isn't true in general, and it's particularly not true
2339 if Emacs is configured with --with-wide-int.
2340 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2341 New macros, used in the buffer.c change.
2342
869795d6
JD
23432011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2344
2345 * xsettings.c: Use both GConf and GSettings if both are available.
2346 (store_config_changed_event): Add comment.
2347 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2348 (store_tool_bar_style_changed): New functions.
5e617bc2 2349 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2350 (struct xsettings): Move font inside HAVE_XFT.
2351 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2352 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2353 Move inside HAVE_XFT.
640c8776 2354 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2355 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2356 also.
2357 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2358 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2359 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2360 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2361 (parse_settings): Move check for font inside HAVE_XFT.
2362 (read_settings, apply_xft_settings): Add comment.
2363 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2364 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2365 call store_font_name_changed.
2366 (xft_settings_event): Add comment.
2367 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2368 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2369 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2370 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2371 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2372 (xsettings_get_system_font, xsettings_get_system_normal_font):
2373 Add comment.
869795d6 2374
d8ed26bd
PE
23752011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2376
2377 Random fixes. E.g., (random) never returned negative values.
2378 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2379 subseconds part to the entropy, as that's a bit more random.
2380 Prefer signed to unsigned, since the signedness doesn't matter and
2381 in general we prefer signed. When given a limit, use a
2382 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2383 latter isn't right if USE_2_TAGS_FOR_INTS.
2384 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2385 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2386
cabf1cac
SM
23872011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2388
2389 * textprop.c (text_property_stickiness):
2390 Obey Vtext_property_default_nonsticky.
2391 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2392 * w32fns.c (syms_of_w32fns):
2393 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2394
6e9b2be9
PE
23952011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2396
2397 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2398 This is more efficient than Ffile_directory_p and avoids a minor race.
2399
90186c68
LMI
24002011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2401
7c301272
LMI
2402 * buffer.c (Foverlay_put): Say what the return value is
2403 (bug#7835).
2404
c4f2d8d4
LMI
2405 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2406 is a directory before asking whether to use the file name
2407 (bug#7564).
ad637907
LMI
2408 (barf_or_query_if_file_exists): Make the "File is a directory"
2409 error be more correct.
c4f2d8d4 2410
90186c68
LMI
2411 * fns.c (Frequire): Remove the mention of the .gz files, since
2412 that's installation-specific, but keep the mention of
2413 `get-load-suffixes'.
2414
da64016e
PE
24152011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2418 Report string overflow if the output is too long.
2419
7d47b580
JB
24202011-07-04 Juanma Barranquero <lekktu@gmail.com>
2421
a555cb87
JB
2422 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2423 (syms_of_gnutls): Remove duplicate DEFSYM for
2424 Qgnutls_bootprop_verify_hostname_error, an error for
2425 Qgnutls_bootprop_verify_error (which is no longer used).
2426
7d47b580
JB
2427 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2428 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2429 Also (re)move comments that are misplaced or no longer relevant.
2430
1e49bfab
LMI
24312011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2432
2433 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2434
1485f4c0
CY
24352011-07-03 Chong Yidong <cyd@stupidchicken.com>
2436
2437 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2438 and background color parameters if they have been changed.
2439
a9ab721e
LMI
24402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2441
2442 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2443
cf7cff57
PE
24442011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2445
2e13213d
PE
2446 * xsettings.c (SYSTEM_FONT): Define only when used.
2447 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2448
cf7cff57
PE
2449 * keymap.c (access_keymap_1): Now static.
2450
7a8e04f7
CY
24512011-07-02 Chong Yidong <cyd@stupidchicken.com>
2452
2453 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2454 leave any prefix arg for the up event (Bug#1586).
2455
61352f62
LMI
24562011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2457
69bb1ef7
LMI
2458 * lread.c (syms_of_lread): Mention single symbols defined by
2459 `defvar' or `defconst' (bug#7154).
2460
61352f62 2461 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2462 (Frequire): Mention get-load-suffixes.
61352f62 2463
28545e04
MR
24642011-07-02 Martin Rudalics <rudalics@gmx.at>
2465
2466 * window.h (window): Remove clone_number slot.
2467 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2468 Remove.
2469 (make_parent_window, make_window, saved_window)
2470 (Fset_window_configuration, save_window_save): Don't deal with
2471 clone numbers.
2472 * buffer.c (Qclone_number): Remove declaration.
2473 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2474
3349e122
SM
24752011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2476
2477 Add multiple inheritance to keymaps.
2478 * keymap.c (Fmake_composed_keymap): New function.
2479 (Fset_keymap_parent): Simplify.
2480 (fix_submap_inheritance): Remove.
2481 (access_keymap_1): New function extracted from access_keymap to handle
2482 embedded parents and handle lists of maps.
2483 (access_keymap): Use it.
2484 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2485 (Fcopy_keymap): Handle embedded parents.
2486 (Fcommand_remapping, define_as_prefix): Simplify.
2487 (Fkey_binding): Simplify.
2488 (syms_of_keymap): Move minibuffer-local-completion-map,
2489 minibuffer-local-filename-completion-map,
2490 minibuffer-local-must-match-map, and
2491 minibuffer-local-filename-must-match-map to Elisp.
2492 (syms_of_keymap): Defsubr make-composed-keymap.
2493 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2494 (parse_menu_item): Trivial simplification.
2495
3279eb87
GM
24962011-07-01 Glenn Morris <rgm@gnu.org>
2497
2498 * Makefile.in (SETTINGS_LIBS): Fix typo.
2499
4550efdf
KI
25002011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2501
2502 * coding.c (Fencode_coding_string): Record the last coding system
2503 used, as the function doc string says (bug#8738).
2504
0949d2b6
JD
25052011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2506
2507 * xsettings.c (store_monospaced_changed): Take new font as arg and
2508 check for change against current_mono_font.
2509 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2510 (emacs_settings_constructor, emacs_settings_get_property)
2511 (emacs_settings_set_property, emacs_settings_class_init)
2512 (emacs_settings_init, gsettings_obj): Remove.
2513 (something_changedCB): New function for HAVE_GSETTINGS.
2514 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2515 with value as argument.
2516 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2517 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2518 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2519 "changed".
2520
2521 * xgselect.c: Add defined (HAVE_GSETTINGS).
2522 (xgselect_initialize): Ditto.
2523
2524 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2525 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2526 xg_select.
2527
bbc6b304
PE
25282011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2529
2530 * eval.c (struct backtrace): Simplify and port the data structure.
2531 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2532 signed bit field, as this assumption is not portable and it makes
2533 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2534 "char debug_on_exit : 1" as this is not portable either; instead,
2535 use the portable "unsigned int debug_on_exit : 1". Remove unused
2536 member evalargs. Remove obsolete comments about cc bombing out.
2537
9851bfc5
JD
25382011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2539
51bb811f 2540 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2541 Let HAVE_GSETTINGS override HAVE_GCONF.
2542 (store_monospaced_changed): New function.
2543 (EMACS_SETTINGS): A new type derived from GObject to handle
2544 GSettings notifications.
2545 (emacs_settings_constructor, emacs_settings_get_property)
2546 (emacs_settings_set_property, emacs_settings_class_init):
2547 New functions.
2548 (gsettings_client, gsettings_obj): New variables.
2549 (GSETTINGS_SCHEMA): New define.
2550 (something_changedCB): Call store_monospaced_changed.
2551 (init_gsettings): New function.
2552 (xsettings_initialize): Call init_gsettings.
2553 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2554 to NULL.
2555
640c8776 2556 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2557 GCONF_CFLAGS/LIBS.
2558
5386012d
MR
25592011-06-29 Martin Rudalics <rudalics@gmx.at>
2560
2561 * window.c (resize_root_window, grow_mini_window)
2562 (shrink_mini_window): Rename Qresize_root_window to
2563 Qwindow_resize_root_window and Qresize_root_window_vertically to
2564 Qwindow_resize_root_window_vertically.
2565
f13e0b08
PE
25662011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2567
2568 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2569
94515237
JB
25702011-06-27 Juanma Barranquero <lekktu@gmail.com>
2571
2572 * makefile.w32-in: Redesign dependencies so they reflect more
2573 clearly which files are directly included by each source file,
2574 and not through other includes.
2575
e43b6e43
MR
25762011-06-27 Martin Rudalics <rudalics@gmx.at>
2577
2578 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2579 (sort_overlays, overlay_strings): When an overlay's clone number
2580 matches the window's clone number process the overlay even if
2581 the overlay's window property doesn't match the current window.
2582
d68443dc
MR
2583 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2584 (Fwindow_hchild): Rename to Fwindow_left_child.
2585 (Fwindow_next): Rename to Fwindow_next_sibling.
2586 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2587 (resize_window_check): Rename to window_resize_check.
2588 (resize_window_apply): Rename to window_resize_apply.
2589 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2590 (Fdelete_other_windows_internal, resize_frame_windows)
2591 (Fsplit_window_internal, Fdelete_window_internal)
2592 (grow_mini_window, shrink_mini_window)
2593 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2594
c7e73be5
JD
25952011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2596
2597 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2598 (emacs_fixed_set_min_size): Remove.
2599 (emacs_fixed_new): Take frame as argument.
2600
2601 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2602 (_EmacsFixedPrivate): Remove minwidth/height.
2603 Add struct frame *f.
2604 (emacs_fixed_init): Initialize priv->f.
2605 (get_parent_class, emacs_fixed_set_min_size): Remove.
2606 (emacs_fixed_new): Set priv->f to argument.
2607 (emacs_fixed_get_preferred_width)
2608 (emacs_fixed_get_preferred_height): Use min_width/height from
2609 frames size_hint to set minimum and natural (Bug#8919).
2610 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2611 and use min_width/height from frames size_hint to set
2612 min_width/height (Bug#8919).
2613
2614 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2615 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2616 Fix indentation.
c7e73be5 2617
cf99dcf8
EZ
26182011-06-26 Eli Zaretskii <eliz@gnu.org>
2619
2620 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2621 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2622 called at ZV.
2623
029529ac
CY
26242011-06-26 Chong Yidong <cyd@stupidchicken.com>
2625
2626 * process.c (wait_reading_process_output): Bypass select if
2627 waiting for a cell while ignoring keyboard input, and input is
2628 pending. Suggested by Jan Djärv (Bug#8869).
2629
7a7ef429
PE
26302011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2631
2632 Use gnulib's dup2 module instead of rolling our own.
2633 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2634
11fdef7d 26352011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2636
2637 * dispnew.c (scrolling_window): Before scrolling, turn off a
2638 mouse-highlight in the window being scrolled.
2639
cd3520a4
JB
26402011-06-24 Juanma Barranquero <lekktu@gmail.com>
2641
2642 Move DEFSYM to lisp.h and use everywhere.
2643
2644 * character.h (DEFSYM): Move declaration...
2645 * lisp.h (DEFSYM): ...here.
2646
2647 * gnutls.c:
2648 * minibuf.c:
2649 * w32menu.c:
2650 * w32proc.c:
2651 * w32select.c: Don't include character.h.
2652
2653 * alloc.c (syms_of_alloc):
2654 * buffer.c (syms_of_buffer):
2655 * bytecode.c (syms_of_bytecode):
2656 * callint.c (syms_of_callint):
2657 * casefiddle.c (syms_of_casefiddle):
2658 * casetab.c (init_casetab_once):
2659 * category.c (init_category_once, syms_of_category):
2660 * ccl.c (syms_of_ccl):
2661 * cmds.c (syms_of_cmds):
2662 * composite.c (syms_of_composite):
2663 * dbusbind.c (syms_of_dbusbind):
2664 * dired.c (syms_of_dired):
2665 * dispnew.c (syms_of_display):
2666 * doc.c (syms_of_doc):
2667 * editfns.c (syms_of_editfns):
2668 * emacs.c (syms_of_emacs):
2669 * eval.c (syms_of_eval):
2670 * fileio.c (syms_of_fileio):
2671 * fns.c (syms_of_fns):
2672 * frame.c (syms_of_frame):
2673 * fringe.c (syms_of_fringe):
2674 * insdel.c (syms_of_insdel):
2675 * keymap.c (syms_of_keymap):
2676 * lread.c (init_obarray, syms_of_lread):
2677 * macros.c (syms_of_macros):
2678 * msdos.c (syms_of_msdos):
2679 * print.c (syms_of_print):
2680 * process.c (syms_of_process):
2681 * search.c (syms_of_search):
2682 * sound.c (syms_of_sound):
2683 * syntax.c (init_syntax_once, syms_of_syntax):
2684 * terminal.c (syms_of_terminal):
2685 * textprop.c (syms_of_textprop):
2686 * undo.c (syms_of_undo):
2687 * w32.c (globals_of_w32):
2688 * window.c (syms_of_window):
2689 * xdisp.c (syms_of_xdisp):
2690 * xfaces.c (syms_of_xfaces):
2691 * xfns.c (syms_of_xfns):
2692 * xmenu.c (syms_of_xmenu):
2693 * xsettings.c (syms_of_xsettings):
2694 * xterm.c (syms_of_xterm): Use DEFSYM.
2695
4228cf16
TZ
26962011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2697
cd3520a4 2698 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2699
7fcccf1e
PE
27002011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2701
7efb4e0e
PE
2702 Integer and buffer overflow fixes (Bug#8873).
2703
ff5844ad
PE
2704 * print.c (printchar, strout): Check for string overflow.
2705 (PRINTPREPARE, printchar, strout):
2706 Don't set size unless allocation succeeds.
2707
90532f02
PE
2708 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2709 for sizes. Check for string overflow more accurately.
2710 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2711
6d84508d
PE
2712 * macros.c: Integer and buffer overflow fixes.
2713 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2714 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2715 Use ptrdiff_t, not int, for sizes.
2716 Don't increment bufsize until after realloc succeeds.
2717 Check for size-calculation overflow.
2718 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2719
437b2cb4
PE
2720 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2721
8b9ac8b4
PE
2722 * lread.c: Integer overflow fixes.
2723 (read_integer): Radix is now EMACS_INT, not int,
2724 to improve quality of diagnostics for out-of-range radices.
2725 Calculate buffer size correctly for out-of-range radices.
2726 (read1): Check for integer overflow in radices, and in
2727 read-circle numbers.
82cb60d3
PE
2728 (read_escape): Avoid int overflow.
2729 (Fload, openp, read_buffer_size, read1)
2730 (substitute_object_recurse, read_vector, read_list, map_obarray):
2731 Use ptrdiff_t, not int, for sizes.
2732 (read1): Use EMACS_INT, not int, for sizes.
20270765 2733 Check for size overflow.
8b9ac8b4 2734
7fcccf1e
PE
2735 * image.c (cache_image): Check for size arithmetic overflow.
2736
bfbbd7e7
PE
2737 * lread.c: Integer overflow issues.
2738 (saved_doc_string_size, saved_doc_string_length)
2739 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2740 Now ptrdiff_t, not int.
2741 (read1): Don't assume doc string length fits in int. Check for
2742 out-of-range doc string lengths.
2743 (read_list): Don't assume file position fits in int.
39019e54 2744 (read_escape): Check for hex character overflow.
bfbbd7e7 2745
4e323265
LL
27462011-06-22 Leo Liu <sdl.web@gmail.com>
2747
2748 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2749 Move to minibuffer.el.
2750
85fece3e
PE
27512011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2752
20b84ce9 2753 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2754 The following patches are for when GLYPH_DEBUG && !XASSERT.
2755 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2756 * dispnew.c (flush_stdout):
2757 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2758 Mark as externally visible.
2759 * dispnew.c (check_window_matrix_pointers): Now static.
2760 * dispnew.c (window_to_frame_vpos):
2761 * xfns.c (unwind_create_frame):
2762 * xterm.c (x_check_font): Remove unused local.
2763 * scroll.c (CHECK_BOUNDS):
2764 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2765 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2766 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2767 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2768 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2769 Now static.
2770 (debug_method_add): Use va_list and vsprintf rather than relying
2771 on undefined behavior with wrong number of arguments.
2772 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2773 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2774 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2775 since we're not interested in debugging glyphs with old libraries.
2776 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2777 GCC 4.6.0's static checking.
2778
0766b489
PE
27792011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2780
31fd4b32
PE
2781 Integer overflow and signedness fixes (Bug#8873).
2782 A few related buffer overrun fixes, too.
2783
b79e8648
PE
2784 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2785
0766b489
PE
2786 * dispextern.h (struct face.stipple):
2787 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2788 (x_bitmap_mask, x_allocate_bitmap_record)
2789 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2790 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2791 (x_create_bitmap_from_xpm_data):
2792 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2793 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2794 (.bitmaps_last):
2795 * xfaces.c (load_pixmap):
2796 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2797 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2798 (.bitmaps_last, struct x_output.icon_bitmap):
2799 Use ptrdiff_t, not int, for bitmap indexes.
2800 (x_allocate_bitmap_record): Check for size overflow.
2801 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2802
b081724f
PE
2803 Use ptrdiff_t, not int, for overlay counts.
2804 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2805 * editfns.c (overlays_around, get_pos_property):
2806 * textprop.c (get_char_property_and_overlay):
2807 * xdisp.c (next_overlay_change, note_mouse_highlight):
2808 * xfaces.c (face_at_buffer_position):
21514da7
PE
2809 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2810 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2811 (Fnext_overlay_change, Fprevious_overlay_change)
2812 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2813 Use ptrdiff_t, not int, for sizes.
21514da7 2814 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2815
3de73e5e
PE
2816 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2817
2606c57b
PE
2818 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2819 (x_session_initialize): Do not assume string length fits in int.
2820
aaafe47a
PE
2821 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2822 This is unlikely, but can occur if DPI is outlandish.
2823
2674ddc8 2824 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2825 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2826
28154962
PE
2827 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2828 * xrdb.c (magic_file_p, search_magic_path):
2829 Omit last arg SUFFIX; it was always 0. All callers changed.
2830 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2831
7de51af5
PE
2832 * xfont.c (xfont_match): Avoid need for strlen.
2833
25ed6cc3
PE
2834 * xfns.c: Don't assume strlen fits in int.
2835 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2836
4eab31dd
PE
2837 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2838 not unsigned long, as we prefer signed integers. All callers changed.
2839 Detect integer overflow in repeat count.
2840 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2841 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2842
171e2a58
PE
2843 * termcap.c: Don't assume sizes fit in int and never overflow.
2844 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2845 (gobble_line): Check for size-calculation overflow.
2846
ad39faca 2847 * minibuf.c (Fread_buffer):
6e5bb2dc 2848 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2849 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2850 Don't assume string length fits in int.
2851
52c61c22 2852 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2853 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2854
b5b8c9e5
PE
2855 * font.c: Don't assume string length fits in int.
2856 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2857 Use ptrdiff_t, not int.
ccd6111c
PE
2858 (font_intern_prop): Don't assume string length fits in int.
2859 Don't assume integer property fits in fixnum.
2860 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2861
882f0d81 2862 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2863 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2864 Reformulate so as not to need the command string.
2865 Invoke gzip -cd rather than gunzip, as it's more portable.
2866 (lock_info_type, lock_file_1, lock_file):
2867 Don't assume pid_t and time_t fit in unsigned long.
2868 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2869 (current_lock_owner): Prefer signed type for sizes.
2870 Use memcpy, not strncpy, where memcpy is what is really wanted.
2871 Don't assume (via atoi) that time_t and pid_t fit in int.
2872 Check for time_t and/or pid_t out of range, e.g., via a network share.
2873 Don't alloca where an auto var works fine.
2874
93f4cf88
PE
2875 * fileio.c: Fix some integer overflow issues.
2876 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2877 Don't assume string length fits in int.
2878 (directory_file_name): Don't assume string length fits in long.
2879 (make_temp_name): Don't assume pid fits in int, or that its print
2880 length is less than 20.
2881
f3e92b69
PE
2882 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2883
1bfdaf10
PE
2884 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2885
35016e9a
PE
2886 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2887
3d1e65a1
PE
2888 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2889 We prefer signed integers, even for size calculations.
2890
0b963a93
PE
2891 * emacs.c: Don't assume string length fits in 'int'.
2892 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2893 (main): Don't invoke strlen when not needed.
2894
573f4b54
PE
2895 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2896 (XD_DEBUG_MESSAGE): Don't waste a byte.
2897
989f33ba
PE
2898 * callproc.c (getenv_internal_1, getenv_internal)
2899 (Fgetenv_internal):
965d34eb
PE
2900 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2901
e4d29b33
PE
2902 * lread.c (invalid_syntax): Omit length argument.
2903 All uses changed. This doesn't fix a bug, but it simplifies the
2904 code away from its former Hollerith-constant appearance, and it's
2905 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2906 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2907
eb49b136
PE
2908 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2909 This didn't break anything, but it didn't help either.
2910 It's confusing to put a bogus integer in a place where the actual
2911 value does not matter.
9f62aeb1 2912 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2913 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2914
15375a22
PE
2915 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2916 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2917 implementation.
b61cc01c
PE
2918 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2919 We prefer signed types, and the value cannot exceed the EMACS_INT
2920 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2921 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2922 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2923 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2924
53b2623d
PE
2925 * indent.c (sane_tab_width): New function.
2926 (current_column, scan_for_column, Findent_to, position_indentation)
2927 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2928 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2929
51cab52b 2930 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2931
f2ed8a70
PE
2932 * lisp.h (lint_assume): New macro.
2933 * composite.c (composition_gstring_put_cache):
2934 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2935
abe80cc6
PE
2936 * editfns.c, insdel.c:
2937 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2938
b02c740e
PE
2939 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2940
ebc96716
PE
2941 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2942
b4e50fa0 2943 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2944 Use much-faster test for byte-length change.
311d5d7c 2945 Don't assume string byte-length fits in 'int'.
a4cf38e4 2946 Check that character arg fits in 'int'.
85461888 2947 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2948
c0c1ee9f
PE
2949 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2950
a498d7f4
PE
2951 * fns.c (concat): Catch string overflow earlier.
2952 Do not rely on integer wraparound.
2953
51cab52b
PE
2954 * dispextern.h (struct it.overlay_strings_charpos)
2955 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2956 * xdisp.c (forward_to_next_line_start)
2957 (back_to_previous_visible_line_start)
2958 (reseat_at_next_visible_line_start, next_element_from_buffer):
2959 Don't arbitrarily truncate the value of 'selective' to int.
2960
76031fad
PE
2961 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2962
5eb55db9
PE
2963 * composite.c: Don't truncate sizes to 'int'.
2964 (composition_gstring_p, composition_reseat_it)
2965 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2966 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2967 not EMACS_UINT, for indexes.
5eb55db9 2968
0703a717
PE
2969 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2970
d6202519
PE
2971 * buffer.c: Include <verify.h>.
2972 (struct sortvec.priority, struct sortstr.priority):
8961a454 2973 Now EMACS_INT, not int.
c20998a7 2974 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2975 (struct sortstr.size, record_overlay_string)
2976 (struct sortstrlist.size, struct sortlist.used):
2977 Don't truncate size to int.
2978 (record_overlay_string): Check for size-calculation overflow.
d6202519 2979 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2980
d5a19415
JM
29812011-06-22 Jim Meyering <meyering@redhat.com>
2982
029529ac 2983 Don't leak an XBM-image-sized buffer
d5a19415
JM
2984 * image.c (xbm_load): Free the image buffer after using it.
2985
a9041e6c
PE
29862011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2987
2988 Port to Sun C.
2989 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2990 that Sun C diagnosed.
2991 * fns.c (secure_hash): Fix pointer signedness issue.
2992 * intervals.c (static_offset_intervals): New function.
2993 (offset_intervals): Use it.
2994
7f3f739f
LL
29952011-06-21 Leo Liu <sdl.web@gmail.com>
2996
2997 * deps.mk (fns.o):
2998 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2999 sha512.h.
3000
3001 * fns.c (secure_hash): Rename from crypto_hash_function and change
3002 the first arg to accept symbols.
5b66d427 3003 (Fsecure_hash): New primitive.
7f3f739f
LL
3004 (syms_of_fns): New symbols.
3005
76147d94
DD
30062011-06-20 Deniz Dogan <deniz@dogan.se>
3007
3008 * process.c (Fset_process_buffer): Clarify return value in
3009 docstring.
3010
7d7d0045
CY
30112011-06-18 Chong Yidong <cyd@stupidchicken.com>
3012
3013 * dispnew.c (add_window_display_history): Use BVAR.
3014
3015 * xdisp.c (debug_method_add): Use BVAR.
3016 (check_window_end, dump_glyph_matrix, dump_glyph)
3017 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3018
3019 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3020 Likewise.
3021
3022 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3023 check till after the cache is created in init_frame_faces.
3024
ff2bc410
SM
30252011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3026
3027 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3028
28177add
PE
30292011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3030
dd3482fe
PE
3031 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3032 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3033 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3034
393d71f3 3035 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3036 * fileio.c (Finsert_file_contents):
3037 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3038 Remove the old (too-loose) buffer overflow checks.
3039 They weren't needed, since make_gap checks for buffer overflow.
3040 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3041 The old code merely checked for Emacs fixnum overflow, and relied
3042 on undefined (wraparound) behavior. The new code avoids undefined
3043 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3044
2e6813b0 3045 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3046 Tune. Don't use wider integers than needed. Don't use alloca.
3047 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3048
599a9e4f
PE
3049 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3050
99561444
PE
3051 * insdel.c, lisp.h (buffer_overflow): New function.
3052 (insert_from_buffer_1, replace_range, replace_range_2):
3053 * insdel.c (make_gap_larger):
3054 * editfns.c (Finsert_char):
3055 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3056
28177add
PE
3057 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3058
e69dafad
PE
30592011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3060
a7af7fde 3061 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3062
b1c46f02
PE
3063 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3064 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3065
e69dafad
PE
3066 * fileio.c: Don't assume EMACS_INT fits in off_t.
3067 (emacs_lseek): New static function.
3068 (Finsert_file_contents, Fwrite_region): Use it.
3069 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3070
566684ea
PE
3071 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3072
e6966cd6
PE
3073 * fns.c: Don't overflow int when computing a list length.
3074 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3075 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3076 truncation on 64-bit hosts. Check for QUIT every
3077 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3078 faster and is responsive enough.
3079 (Flength): Report an error instead of overflowing an integer.
3080 (Fsafe_length): Return a float if the value is not representable
3081 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3082 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3083 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3084
dd0b0efb
PE
3085 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3086 (header_size, word_size): New constants.
3087 (allocate_vectorlike): Don't check size overflow here.
3088 (allocate_vector): Check it here instead, since this is the only
3089 caller of allocate_vectorlike that could cause overflow.
3090 Check that the new vector's length is representable as a fixnum.
3091
86fe5cfe
PE
3092 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3093 The previous code was bogus. For example, next_almost_prime (32)
3094 returned 39, which is undesirable as it is a multiple of 3; and
3095 next_almost_prime (24) returned 25, which is a multiple of 5 so
3096 why was the code bothering to check for multiples of 7?
3097
80e88859
PE
3098 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3099
4a2f0ad6
PE
3100 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3101
f66c7cf8
PE
3102 Variadic C functions now count arguments with ptrdiff_t.
3103 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3104 Back then I didn't know that the Emacs coding style prefers signed int.
3105 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3106 were being counted with int, which may truncate counts on 64-bit
3107 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3108 * lisp.h (struct Lisp_Subr.function.aMANY)
3109 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3110 Arg counts are now ptrdiff_t, not size_t.
3111 All variadic functions and their callers changed accordingly.
3112 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3113 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3114 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3115 * callint.c (Fcall_interactively): Check arg count for overflow,
3116 to avoid potential buffer overrun. Use signed char, not 'int',
3117 for 'varies' array, so that we needn't bother to check its size
3118 calculation for overflow.
3119 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3120 * eval.c (apply_lambda):
3121 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3122 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3123 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3124
a1759b76
PE
3125 * callint.c (Fcall_interactively): Don't use index var as event count.
3126
d96be9fc
PE
3127 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3128 * mem-limits.h (SIZE): Remove; no longer used.
3129
a690a978 3130 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3131
578c21e6
PE
3132 Remove unnecessary casts.
3133 * xterm.c (x_term_init):
3134 * xfns.c (x_set_border_pixel):
3135 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3136 These aren't needed now that we assume ANSI C.
3137
96f53c6c
PE
3138 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3139 It's more likely to cause problems (due to unsigned overflow)
3140 than to cure them.
3141
83c77d31
PE
3142 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3143
ee2079f1
PE
3144 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3145
6da65536
PE
3146 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3147
7147c4a4
PE
3148 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3149
193e32d9
PE
3150 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3151
e5533da6
PE
3152 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3153
9910e595
PE
3154 GLYPH_CODE_FACE returns EMACS_INT, not int.
3155 * dispextern.h (merge_faces):
3156 * xfaces.c (merge_faces):
01103c44
PE
3157 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3158 Don't assume EMACS_INT fits in int.
9910e595 3159
2638320e
PE
3160 * character.h (CHAR_VALID_P): Remove unused parameter.
3161 * fontset.c, lisp.h, xdisp.c: All uses changed.
3162
045eb8d9
PE
3163 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3164
c1f134b5
PE
3165 * fns.c (concat): Minor tuning based on overflow analysis.
3166 This doesn't fix any bugs. Use int to hold character, instead
3167 of constantly refetching from Emacs object. Use XFASTINT, not
3168 XINT, for value known to be a character. Don't bother comparing
3169 a single byte to 0400, as it's always less.
3170
395fcb93 3171 * floatfns.c (Fexpt):
327eeec8
PE
3172 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3173
abbd3d23
PE
3174 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3175 for characters.
3176
684a03ef
PE
3177 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3178
0fed43f3
PE
3179 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3180 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3181 incorrectly succeed when S was a string, because 4294967386 was
3182 truncated before it was used.
3183
8fd02eb7
PE
3184 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3185 Otherwise, an out-of-range integer could cause undefined behavior
3186 on a 64-bit host.
3187
f8c86b69
PE
3188 * composite.c: Use int, not EMACS_INT, for characters.
3189 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3190 EMACS_INT, for values that are known to be in character range.
3191 This doesn't fix any bugs but is the usual style inside Emacs and
3192 may generate better code on 32-bit machines.
3193
34206dd2
PE
3194 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3195 This is for reasons similar to the recent CHAR_STRING fix.
3196 * charset.c (Fencode_char): Check that character arg is actually
3197 a character. Pass an int to ENCODE_CHAR.
3198 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3199 wider than 'int', as a compile-time check to prevent future regressions
3200 in this area.
3201
c5958d4c 3202 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3203
3204 Make sure a 64-bit char is never passed to CHAR_STRING.
3205 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3206 by silently ignoring the top 32 bits, allowing some values
3207 that were far too large to be valid characters.
3208 * character.h: Include <verify.h>.
3209 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3210 arguments are no wider than unsigned, as a compile-time check
3211 to prevent future regressions in this area.
3212 * data.c (Faset):
01103c44 3213 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3214 (Fsubst_char_in_region):
3215 * fns.c (concat):
3216 * xdisp.c (decode_mode_spec_coding):
3217 Adjust to CHAR_STRING's new requirement.
3218 * editfns.c (Finsert_char, Fsubst_char_in_region):
3219 * fns.c (concat): Check that character args are actually
3220 characters. Without this test, these functions did the wrong
3221 thing with wildly out-of-range values on 64-bit hosts.
3222
d37ca623
PE
3223 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3224 These casts should not be needed on 32-bit hosts, either.
3225 * keyboard.c (read_char):
3226 * lread.c (Fload): Remove casts to unsigned.
3227
ea204efb
PE
3228 * lisp.h (UNSIGNED_CMP): New macro.
3229 This fixes comparison bugs on 64-bit hosts.
3230 (ASCII_CHAR_P): Use it.
3231 * casefiddle.c (casify_object):
01103c44 3232 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3233 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3234 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3235 * dispextern.h (FACE_FROM_ID):
3236 * keyboard.c (read_char): Use UNSIGNED_CMP.
3237
41cb286c
PE
3238 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3239 not to EMACS_INT, to avoid GCC warning.
3240
4a1b9832
PE
3241 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3242
55daad71
PE
3243 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3244 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3245 isn't needed on 32-bit machines.
8f95c75c 3246
01103c44
PE
3247 * buffer.c (Fgenerate_new_buffer_name):
3248 Use EMACS_INT for count, not int.
0ceccced 3249 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3250
3251 * data.c (Qcompiled_function): Now static.
3252
c6f072e7
PE
3253 * window.c (window_body_lines): Now static.
3254
20ce5912
PE
3255 * image.c (gif_load): Rename local to avoid shadowing.
3256
9c4c5f81
PE
3257 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3258 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3259 * alloc.c (make_save_value): Integer argument is now of type
3260 ptrdiff_t, not int.
3261 (mark_object): Use ptrdiff_t, not int.
3262 * lisp.h (pD): New macro.
3263 * print.c (print_object): Use it.
3264
c0c5c8ae
PE
3265 * alloc.c: Use EMACS_INT, not int, to count objects.
3266 (total_conses, total_markers, total_symbols, total_vector_size)
3267 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3268 (total_free_floats, total_floats, total_free_intervals)
3269 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3270 Now EMACS_INT, not int. All uses changed.
3271 (Fgarbage_collect): Compute overall total using a double, so that
3272 integer overflow is less likely to be a problem. Check for overflow
3273 when converting back to an integer.
5a25e253
PE
3274 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3275 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3276 These were 'int' variables that could overflow on 64-bit hosts;
3277 they were never used, so remove them instead of repairing them.
211a0b2a 3278 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3279 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3280 Previously, this ceilinged at INT_MAX, but that doesn't work on
3281 64-bit machines.
e46bb31a 3282 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3283
c78baabf 3284 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3285 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3286 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3287 when a (possibly-narrower) signed value would do just as well.
3288 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3289
c9d624c6
PE
3290 * alloc.c: Catch some string size overflows that we were missing.
3291 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3292 for convenience in STRING_BYTES_MAX.
3293 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3294 The definition here is exact; the one in lisp.h was approximate.
3295 (allocate_string_data): Check for string overflow. This catches
3296 some instances we weren't catching before. Also, it catches
3297 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3298 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3299 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3300
c9d624c6
PE
3301 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3302 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3303 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3304
353032ce
PE
3305 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3306
2bccce07
PE
3307 * alloc.c (Fmake_string): Check for out-of-range init.
3308
0ac30604
SM
33092011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3310
3311 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3312
c195f2de
JD
33132011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3314
3315 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3316 xg_get_default_scrollbar_width.
3317
3318 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3319 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3320 (style_changed_cb): Call update_theme_scrollbar_width and call
3321 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3322 all frames (Bug#8505).
3323 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3324 Call gtk_window_set_resizable if HAVE_GTK3.
3325 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3326 and height if HAVE_GTK3 (Bug#8505).
3327 (scroll_bar_width_for_theme): New variable.
3328 (update_theme_scrollbar_width): New function.
3329 (xg_get_default_scrollbar_width): Move code to
3330 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3331 (xg_initialize): Call update_theme_scrollbar_width.
3332
3333 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3334
3335 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3336
e10ac9f1
MR
33372011-06-12 Martin Rudalics <rudalics@gmx.at>
3338
3339 * frame.c (make_frame): Call other_buffer_safely instead of
3340 other_buffer.
3341
3342 * window.c (temp_output_buffer_show): Call display_buffer with
3343 second argument Vtemp_buffer_show_specifiers and reset latter
3344 immediately after the call.
3345 (Vtemp_buffer_show_specifiers): New variable.
3346 (auto_window_vscroll_p, next_screen_context_lines)
3347 (Vscroll_preserve_screen_position): Remove leading asterisks from
3348 doc-strings.
3349
2d3c217e 33502011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3351
7b7f97e8 3352 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3353 * buffer.c (Qclone_number): Remove for now, as it's unused.
3354 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3355 (record_buffer): Remove unused local.
3356 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3357 (set_frame_buffer_list): Remove; unused.
3358 * frame.h (other_visible_frames): Remove decl.
3359 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3360 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3361 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3362 if HAVE_GPM.
3363 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3364 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3365 Define only if HAVE_GPM.
3366 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3367 (update_hints_inhibit): Remove; never set. All uses removed.
3368 * widgetprv.h (emacsFrameClassRec): Remove decl.
3369 * window.c (delete_deletable_window): Now returns void, since it
3370 wasn't returning anything.
3371 (compare_window_configurations): Remove unused locals.
3372 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3373 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3374 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3375 the same widths as pointers. This follows up on the 2011-05-06 patch.
3376 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3377 * xterm.h: Likewise.
3378 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3379
1384b89e
JB
33802011-06-12 Juanma Barranquero <lekktu@gmail.com>
3381
3382 * makefile.w32-in: Update dependencies.
3383 (LISP_H): Add lib/intprops.h.
3384
1100a63c
CY
33852011-06-11 Chong Yidong <cyd@stupidchicken.com>
3386
3387 * image.c (gif_load): Add animation frame delay to the metadata.
3388 (syms_of_image): Use DEFSYM. New symbol `delay'.
3389
6198ccd0
MR
33902011-06-11 Martin Rudalics <rudalics@gmx.at>
3391
3392 * window.c (delete_deletable_window): Re-add.
3393 (Fset_window_configuration): Rewrite to handle dead buffers and
3394 consequently deletable windows.
3395 (window_tree, Fwindow_tree): Remove. Supply functionality in
3396 window.el.
3397 (compare_window_configurations): Simplify code.
3398
b6e3633c
AS
33992011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3400
1ab0dee5
AS
3401 * image.c (imagemagick_load_image): Fix type mismatch.
3402 (Fimagemagick_types): Likewise.
3403
b6e3633c
AS
3404 * window.h (replace_buffer_in_windows): Declare.
3405
9397e56f
MR
34062011-06-11 Martin Rudalics <rudalics@gmx.at>
3407
3408 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3409 Qclone_number. Remove external declaration of Qdelete_window.
3410 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3411 code.
640c8776
SM
3412 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3413 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3414 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3415 buffer list implementation.
3416 (other_buffer_safely): New function.
3417 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3418 calls to replace_buffer_in_windows and
3419 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3420 if allowed.
3421 (record_buffer): Inhibit quitting and rewrite using quittable
3422 functions. Run Qbuffer_list_update_hook if allowed.
3423 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3424 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3425 Move switch-to-buffer to window.el.
9397e56f
MR
3426 (bury-buffer): Move to window.el.
3427 (Vbuffer_list_update_hook): New variable.
3428
3429 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3430 section.
3431
3432 * window.h (resize_frame_windows): Move up in code.
3433 (Fwindow_frame): Remove EXFUN.
3434 (replace_buffer_in_all_windows): Remove prototype.
3435 (replace_buffer_in_windows_safely): Add prototype.
3436
3437 * window.c: Declare Qdelete_window static again. Move down
3438 declaration of select_count.
3439 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3440 (Fother_window): Move to window.el.
3441 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3442 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3443 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3444 window.el.
3445 (replace_buffer_in_windows): Implement by calling
3446 Qreplace_buffer_in_windows.
3447 (replace_buffer_in_all_windows): Remove with some functionality
3448 moved into replace_buffer_in_windows_safely.
3449 (replace_buffer_in_windows_safely): New function.
3450 (select_window_norecord, select_frame_norecord): Move in front
3451 of run_window_configuration_change_hook. Remove now obsolete
3452 declarations.
640c8776
SM
3453 (Fset_window_buffer): Rewrite doc-string.
3454 Call Qrecord_window_buffer.
9397e56f
MR
3455 (keys_of_window): Move binding for other-window to window.el.
3456
b50691aa
CY
34572011-06-11 Chong Yidong <cyd@stupidchicken.com>
3458
3459 * dispextern.h (struct image): Replace data member, whose int_val
3460 and ptr_val fields were not used by anything, with a single
3461 lisp_val object.
3462
3463 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3464 (gif_clear_image, gif_load, imagemagick_load_image)
3465 (gs_clear_image, gs_load): Callers changed.
3466
3f754b86
PE
34672011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3468
cca69397
PE
3469 * buffer.h: Include <time.h>, for time_t.
3470 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3471
109e28d0
PE
3472 Fix minor problems found by static checking.
3473
60737f02
PE
3474 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3475
4b66faf3
PE
3476 Make identifiers static if they are not used in other modules.
3477 * data.c (Qcompiled_function, Qframe, Qvector):
3478 * image.c (QimageMagick, Qsvg):
3479 * minibuf.c (Qmetadata):
3480 * window.c (resize_window_check, resize_root_window): Now static.
3481 * window.h (resize_window_check, resize_root_window): Remove decls.
3482
109e28d0
PE
3483 * window.c (window_deletion_count, delete_deletable_window):
3484 Remove; unused.
46a4ce9e
PE
3485 (window_body_lines): Now static.
3486 (Fdelete_other_windows_internal): Mark vars as initialized.
3487 Make sure 'resize_failed' is initialized.
3488 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3489 (resize_window_apply): Remove unused local.
3490 * window.h (delete_deletable_window): Remove decl.
3491
109e28d0 3492 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3493 (imagemagick_load_image): Fix pointer signedness problem by changing
3494 last arg from unsigned char * to char *. All uses changed.
3495 Also, fix a local for similar reasons.
3496 Remove unused locals. Remove locals to avoid shadowing.
3497 (fn_rsvg_handle_free): Remove; unused.
3498 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3499 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3500
3f754b86
PE
3501 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3502
2547adb1
CY
35032011-06-10 Chong Yidong <cyd@stupidchicken.com>
3504
3505 * image.c (gif_load): Fix omitted cast error introduced by
3506 2011-06-06 change.
3507
2c8e37d4
MR
35082011-06-10 Martin Rudalics <rudalics@gmx.at>
3509
3510 * window.h (resize_proportionally, orig_total_lines)
3511 (orig_top_line): Remove from window structure.
3512 (set_window_height, set_window_width, change_window_heights)
3513 (Fdelete_window): Remove prototypes.
3514 (resize_frame_windows): Remove duplicate declaration.
3515
440a42e3
EZ
35162011-06-10 Eli Zaretskii <eliz@gnu.org>
3517
3518 * window.h (resize_frame_windows, resize_window_check)
3519 (delete_deletable_window, resize_root_window)
3520 (resize_frame_windows): Declare prototypes.
3521
3522 * window.c (resize_window_apply): Make definition be "static" to
3523 match the prototype.
3524
562dd5e9
MR
35252011-06-10 Martin Rudalics <rudalics@gmx.at>
3526
3527 * window.c: Remove declarations of Qwindow_size_fixed,
3528 window_min_size_1, window_min_size_2, window_min_size,
3529 size_window, window_fixed_size_p, enlarge_window, delete_window.
3530 Remove static from declaration of Qdelete_window, it's
3531 temporarily needed by Fbury_buffer.
3532 (replace_window): Don't assign orig_top_line and
3533 orig_total_lines.
3534 (Fdelete_window, delete_window): Remove. Window deletion is
3535 handled by window.el.
640c8776
SM
3536 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3537 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3538 (Fdelete_other_windows): Remove. Deleting other windows is
3539 handled by window.el.
3540 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3541 handled in window.el.
3542 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3543 Window minimum sizes are handled in window.el.
3544 (shrink_windows, size_window, set_window_height)
3545 (set_window_width, change_window_heights, window_height)
3546 (window_width, CURBEG, CURSIZE, enlarge_window)
3547 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3548 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3549 handled in window.el.
3550 (make_dummy_parent): Rename to make_parent_window and give it a
3551 second argument horflag.
3552 (make_window): Don't set resize_proportionally any more.
3553 (Fsplit_window): Remove. Windows are split in window.el.
3554 (save_restore_action, save_restore_orig_size)
3555 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3556 Resize mini windows in window.el.
3557 (grow_mini_window, shrink_mini_window): Implement by calling
3558 Qresize_root_window_vertically, resize_window_check and
3559 resize_window_apply.
640c8776
SM
3560 (saved_window, Fset_window_configuration, save_window_save):
3561 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3562 resize_proportionally.
3563 (window_min_height, window_min_width): Move to window.el.
3564 (keys_of_window): Move bindings for delete-other-windows,
3565 split-window, delete-window and enlarge-window to window.el.
3566
3567 * buffer.c: Temporarily extern Qdelete_window.
3568 (Fbury_buffer): Temporarily call Qdelete_window instead of
3569 Fdelete_window (Fbury_buffer will move to window.el soon).
3570
3571 * frame.c (set_menu_bar_lines_1): Remove code handling
3572 orig_top_line and orig_total_lines.
3573
3574 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3575 set_window_height but set heights directly.
3576 (change_frame_size_1): Use resize_frame_windows.
3577
3578 * xdisp.c (init_xdisp): Don't use set_window_height but set
3579 heights directly.
3580
640c8776
SM
3581 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3582 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3583 run_window_configuration_change_hook.
3584
3585 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3586 instead of change_window_heights and run
3587 run_window_configuration_change_hook.
3588
1a13852e
MR
35892011-06-09 Martin Rudalics <rudalics@gmx.at>
3590
3591 * window.c (replace_window): Rename second argument REPLACEMENT to
3592 NEW. New third argument SETFLAG. Rewrite.
3593 (delete_window, make_dummy_parent): Call replace_window with
3594 third argument 1.
3595 (window_list_1): Move down in code.
3596 (run_window_configuration_change_hook): Move set_buffer part
3597 before select_frame_norecord part in order to unwind correctly.
3598 Rename count1 to count.
3599 (recombine_windows, delete_deletable_window, resize_root_window)
3600 (Fdelete_other_windows_internal)
3601 (Frun_window_configuration_change_hook, make_parent_window)
3602 (resize_window_check, resize_window_apply, Fresize_window_apply)
3603 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3604 (Fdelete_window_internal, Fresize_mini_window_internal):
3605 New functions.
1a13852e
MR
3606 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3607
f3d1777e
MR
36082011-06-08 Martin Rudalics <rudalics@gmx.at>
3609
496e208e
MR
3610 * window.h (window): Add some new members to window structure -
3611 normal_lines, normal_cols, new_total, new_normal, clone_number,
3612 splits, nest, prev_buffers, next_buffers.
3613 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3614 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3615
f3d1777e
MR
3616 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3617 Remove.
496e208e
MR
3618 (make_dummy_parent): Set new members of windows structure.
3619 (make_window): Move down in code. Handle new members of window
3620 structure.
3621 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3622 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3623 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3624 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3625 (Fset_window_next_buffers, Fset_window_clone_number):
3626 New functions.
496e208e
MR
3627 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3628 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3629 Doc-string fixes.
3630 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3631 Argument WINDOW can be now internal window too.
3632 (Fwindow_use_time): Move up in code.
3633 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3634 Rewrite doc-string.
3635 (Fset_window_configuration, saved_window)
3636 (Fcurrent_window_configuration, save_window_save): Handle new
3637 members of window structure.
b9e809c2
MR
3638 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3639 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3640 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3641 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3642 Qget_mru_window, Qresize_root_window,
3643 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3644 Qauto_buffer_name; staticpro them.
f3d1777e 3645
abde8f8c
MR
36462011-06-07 Martin Rudalics <rudalics@gmx.at>
3647
3648 * window.c (Fwindow_total_size, Fwindow_left_column)
3649 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3650 (Fwindow_list_1): New functions.
3651 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3652 (Fwindow_width, Fscroll_left, Fscroll_right):
3653 Use window_body_cols instead of window_box_text_cols.
3654 (delete_window, Fset_window_configuration):
3655 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3656 (delete_all_subwindows): Take a window as argument and not a
3657 structure. Rewrite.
190b47e6
MR
3658 (window_loop): Remove handling of GET_LRU_WINDOW and
3659 GET_LARGEST_WINDOW.
3660 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3661
3662 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3663 window_box_text_cols. delete_all_subwindows now takes a
3664 Lisp_Object as argument.
abde8f8c 3665
640c8776
SM
3666 * indent.c (compute_motion, Fcompute_motion):
3667 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3668
fa8a67e6
MR
3669 * frame.c (delete_frame): Call delete_all_subwindows with root
3670 window as argument.
3671
a54e3482
DC
36722011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3673
3674 * fns.c (Fputhash): Document return value.
3675
60002bf5
CY
36762011-06-06 Chong Yidong <cyd@stupidchicken.com>
3677
3678 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3679
0c671da6 36802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3681
b862a52a 3682 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3683
be44ca6c
PE
3684 Check for overflow when converting integer to cons and back.
3685 * charset.c (Fdefine_charset_internal, Fdecode_char):
3686 Use cons_to_unsigned to catch overflow.
3687 (Fencode_char): Use INTEGER_TO_CONS.
3688 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3689 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3690 * data.c (long_to_cons, cons_to_long): Remove.
3691 (cons_to_unsigned, cons_to_signed): New functions.
3692 These signal an error for invalid or out-of-range values.
3693 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3694 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3695 * font.c (Ffont_variation_glyphs):
3696 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3697 * lisp.h: Include <intprops.h>.
3698 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3699 (cons_to_signed, cons_to_unsigned): New decls.
3700 (long_to_cons, cons_to_long): Remove decls.
3701 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3702 (Fprimitive_undo): Use CONS_TO_INTEGER.
3703 * xfns.c (Fx_window_property): Likewise.
3704 * xselect.c: Include <limits.h>.
3705 (x_own_selection, selection_data_to_lisp_data):
3706 Use INTEGER_TO_CONS.
3707 (x_handle_selection_request, x_handle_selection_clear)
3708 (x_get_foreign_selection, Fx_disown_selection_internal)
3709 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3710 (lisp_data_to_selection_data): Use cons_to_unsigned.
3711 (x_fill_property_data): Use cons_to_signed.
3712 Report values out of range.
3713
d1f3d2af
PE
3714 Check for buffer and string overflow more precisely.
3715 * buffer.h (BUF_BYTES_MAX): New macro.
3716 * lisp.h (STRING_BYTES_MAX): New macro.
3717 * alloc.c (Fmake_string):
3718 * character.c (string_escape_byte8):
3719 * coding.c (coding_alloc_by_realloc):
3720 * doprnt.c (doprnt):
3721 * editfns.c (Fformat):
3722 * eval.c (verror):
3723 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3724 since they may not be the same number.
3725 * editfns.c (Finsert_char):
3726 * fileio.c (Finsert_file_contents):
3727 Likewise for BUF_BYTES_MAX.
3728
dd52fcea
PE
3729 * image.c: Use ptrdiff_t, not int, for sizes.
3730 (slurp_file): Switch from int to ptrdiff_t.
3731 All uses changed.
3732 (slurp_file): Check that file size fits in both size_t (for
3733 malloc) and ptrdiff_t (for sanity and safety).
3734
7f9bbdbb
PE
3735 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3736 if b->modtime has its maximal value.
3737
dfe18f82
PE
3738 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3739
84acfcf0
PE
3740 Don't assume time_t can fit into int.
3741 * buffer.h (struct buffer.modtime): Now time_t, not int.
3742 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3743 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3744
ccd9a01a
PE
3745 Minor fixes for signed vs unsigned integers.
3746 * character.h (MAYBE_UNIFY_CHAR):
3747 * charset.c (maybe_unify_char):
3748 * keyboard.c (read_char, reorder_modifiers):
3749 XINT -> XFASTINT, since the integer must be nonnegative.
3750 * ftfont.c (ftfont_spec_pattern):
3751 * keymap.c (access_keymap, silly_event_symbol_error):
3752 XUINT -> XFASTINT, since the integer must be nonnegative.
3753 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3754 since it makes no difference and we prefer signed.
3755 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3756 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3757 nonnegative.
3758
d6d100dd
SM
37592011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3760
3761 * window.h (Fwindow_frame): Declare.
3762
2b6148e4
PE
37632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3764
3765 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3766 (SPARE_MEMORY): Always define.
3767 (LARGE_REQUEST): Remove.
3768 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3769
f230ecc9
MR
37702011-06-06 Martin Rudalics <rudalics@gmx.at>
3771
727e958e
MR
3772 * lisp.h: Move EXFUNS for Fframe_root_window,
3773 Fframe_first_window and Fset_frame_selected_window to window.h.
3774
3775 * window.h: Move EXFUNS for Fframe_root_window,
3776 Fframe_first_window and Fset_frame_selected_window here from
3777 lisp.h.
3778
3779 * frame.c (Fwindow_frame, Fframe_first_window)
3780 (Fframe_root_window, Fframe_selected_window)
3781 (Fset_frame_selected_window): Move to window.c.
3782 (Factive_minibuffer_window): Move to minibuf.c.
3783 (Fother_visible_frames_p): New function.
3784
3785 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3786
f230ecc9
MR
3787 * window.c (decode_window, decode_any_window): Move up in code.
3788 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3789 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3790 (Fwindow_buffer): Move up and rewrite doc-string.
3791 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3792 (Fwindow_prev): New functions.
727e958e
MR
3793 (Fwindow_frame): Move here from frame.c. Accept any window as
3794 argument.
3795 (Fframe_root_window, Fframe_first_window)
3796 (Fframe_selected_window): Move here from frame.c. Accept frame
3797 or arbitrary window as argument. Update doc-strings.
3798 (Fminibuffer_window): Move up in code.
3799 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3800 (Fset_frame_selected_window): Move here from frame.c.
3801 Marginal rewrite.
727e958e
MR
3802 (Fselected_window, select_window, Fselect_window): Move up in
3803 code. Minor doc-string fixes.
f230ecc9 3804
4d09bcf6
PE
38052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3806
3807 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3808 Do not assume that spare memory exists; that assumption is valid
3809 only if SYSTEM_MALLOC.
3810 (LARGE_REQUEST): New macro, so that the issue of large requests
3811 is separated from the issue of spare memory.
3812
810928a2
AS
38132011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3814
172418ad
AS
3815 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3816 format. (Bug#8806)
3817
43f862f7
AS
3818 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3819
810928a2
AS
3820 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3821 before statements.
3822
a059fe24
JD
38232011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3824
3825 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3826
3827 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3828
3829 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3830 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3831
989bf368
JB
38322011-06-05 Juanma Barranquero <lekktu@gmail.com>
3833
3834 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3835
4b80f674
CY
38362011-06-04 Chong Yidong <cyd@stupidchicken.com>
3837
3838 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3839 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3840 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3841 New error handlers.
4b80f674
CY
3842 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3843 Obey Vx_select_enable_clipboard_manager. Catch errors in
3844 x_clipboard_manager_save (Bug#8779).
3845 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3846 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3847
99a33b77 38482011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3849
3850 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3851
99a33b77 38522011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3853
3854 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3855 in the current matrix if keep_current_p is non-zero.
3856
8264569d
EZ
38572011-06-04 Eli Zaretskii <eliz@gnu.org>
3858
3859 * bidi.c (bidi_level_of_next_char): Fix last change.
3860
57f97249
EZ
38612011-06-03 Eli Zaretskii <eliz@gnu.org>
3862
fec2107c 3863 Support bidi reordering of text covered by display properties.
57f97249 3864
fec2107c
EZ
3865 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3866 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3867 (bidi_cache_search, bidi_cache_iterator_state)
3868 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3869 (bidi_level_of_next_char, bidi_move_to_visually_next):
3870 Support character positions inside a run of characters covered by a
fec2107c
EZ
3871 display string.
3872 (bidi_paragraph_init, bidi_resolve_explicit_1)
3873 (bidi_level_of_next_char): Call bidi_fetch_char and
3874 bidi_fetch_char_advance instead of FETCH_CHAR and
3875 FETCH_CHAR_ADVANCE.
3876 (bidi_init_it): Initialize new members.
3877 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3878 definitions.
3879 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3880 instead of using explicit *_CHAR codes.
d6d100dd
SM
3881 (bidi_resolve_explicit, bidi_resolve_weak):
3882 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3883 bidirectional text is supported only in multibyte buffers.
3884 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3885 it to initialize the frame_window_p member of struct bidi_it.
3886 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3887 (bidi_resolve_explicit, bidi_resolve_weak)
3888 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3889 bidi_it->nchars is non-positive.
3890 (bidi_level_of_next_char): Don't try to lookup the cache for the
3891 next/previous character if nothing is cached there yet, or if we
3892 were just reseat()'ed to a new position.
c40e2fb2 3893
0e14fe90
EZ
3894 * xdisp.c (set_cursor_from_row): Set start and stop points
3895 according to the row's direction when priming the loop that looks
3896 for the glyph on which to display cursor.
3897 (single_display_spec_intangible_p): Function deleted.
3898 (display_prop_intangible_p): Reimplement to call
3899 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3900 Accept 3 additional arguments needed by handle_display_spec.
3901 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3902 values: lists, `(when COND...)' forms, etc.
3903 (single_display_spec_string_p): Support property values that are
3904 lists with the argument STRING its top-level element.
3905 (display_prop_string_p): Fix the condition for processing a
3906 property that is a list to be consistent with handle_display_spec.
fec2107c 3907 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3908 last portion of handle_display_prop.
3909 (compute_display_string_pos): Accept additional argument
3910 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3911 value of a `display' property is a "replacing spec".
3912 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3913 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3914 the display property, but just return a value indicating whether
3915 the display property will replace the characters it covers.
3916 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3917 frame_window_p members of struct bidi_it.
d6d100dd
SM
3918 (compute_display_string_pos, compute_display_string_end):
3919 New functions.
fec2107c
EZ
3920 (push_it): Accept second argument POSITION, where pop_it should
3921 jump to continue iteration.
3922 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3923
fec2107c
EZ
3924 * keyboard.c (adjust_point_for_property): Adjust the call to
3925 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3926
3927 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3928 (bidi_init_it): Update prototypes.
3929 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3930 (compute_display_string_pos, compute_display_string_end):
3931 Declare prototypes.
fec2107c
EZ
3932 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3933 EMACS_INT.
fc6f18ce 3934
40087514 39352011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3936
57f53182
PE
3937 Malloc failure behavior now depends on size of allocation.
3938 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3939 * lisp.h: Change signatures accordingly.
3940 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3941 All callers changed. (Bug#8762)
3942
3943 * gnutls.c: Use Emacs's memory allocators.
3944 Without this change, the gnutls library would invoke malloc etc.
3945 directly, which causes problems on non-SYNC_INPUT hosts, and which
3946 runs afoul of improving memory_full behavior. (Bug#8761)
3947 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3948 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3949 xfree instead of the default malloc, realloc, free.
3950 (Fgnutls_boot): No need to check for memory allocation failure,
3951 since xmalloc does that for us.
3952
ac32cd99 3953 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3954 * category.c (hash_get_category_set):
3955 * ccl.c (ccl_driver):
3956 * charset.c (Fdefine_charset_internal):
3957 * charset.h (struct charset.hash_index):
3958 * composite.c (get_composition_id, gstring_lookup_cache)
3959 (composition_gstring_put_cache):
3960 * composite.h (struct composition.hash_index):
3961 * dispextern.h (struct image.hash):
3962 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3963 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3964 (hashfn_equal, hashfn_user_defined, make_hash_table)
3965 (maybe_resize_hash_table, hash_lookup, hash_put)
3966 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3967 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3968 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3969 * image.c (make_image, search_image_cache, lookup_image)
3970 (xpm_put_color_table_h):
3971 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3972 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3973 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3974 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3975 * alloc.c (allocate_vectorlike):
3976 Check for overflow in vector size calculations.
3977 * ccl.c (ccl_driver):
3978 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3979 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3980 need to be updated by these changes.
40087514
PE
3981 * fns.c (make_hash_table, maybe_resize_hash_table):
3982 Check for integer overflow with large hash tables.
0de4bb68
PE
3983 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3984 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3985 (SXHASH_REDUCE): New macro.
3986 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3987 Use it instead of discarding useful hash info with large hash values.
3988 (sxhash_float): New function.
3989 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3990 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3991 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3992 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3993 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3994 Adjust signatures to match updated version of code.
3995 (consing_since_gc): Now EMACS_INT, since a single hash table can
3996 use more than INT_MAX bytes.
3997
698d32e2
DN
39982011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3999
4000 Make it possible to build with GCC-4.6+ -O2 -flto.
4001
4002 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4003
fd6fa53f
SM
40042011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4005
4006 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4007 Call minibuffer-inactive-mode.
4008
864db017
JB
40092011-05-31 Juanma Barranquero <lekktu@gmail.com>
4010
4011 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4012 Update dependencies.
4013
2ad0baf4
DN
40142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4015
4016 * data.c (init_data): Remove code for UTS, this system is not
4017 supported anymore.
4018
4fcc2638
DN
40192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4020
4021 Don't force ./temacs to start in terminal mode.
4022
4023 * frame.c (make_initial_frame): Initialize faces in all cases, not
4024 only when CANNOT_DUMP is defined.
4025 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4026
c56e0fd5
DN
40272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4028
4029 * dispnew.c (add_window_display_history): Use const for the string
4030 pointer. Remove declaration, not needed.
4031
333d54da 40322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4033
55d4c1b2 4034 Use 'inline', not 'INLINE'.
333d54da 4035 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4036 * alloc.c, fontset.c (INLINE): Remove.
4037 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4038 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4039 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4040 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4041 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4042
738db178
DN
40432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4044
4045 Make it possible to run ./temacs.
4046
4047 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4048 syms_of_callproc does the same thing. Remove test for
4049 "initialized", do it in the caller.
4050 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4051
620c53a6
SM
40522011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4053
4054 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4055 (read_minibuf): Use get_minibuffer.
4056 (syms_of_minibuf): Use DEFSYM.
4057 (Qmetadata): New var.
4058 * data.c (Qbuffer): Don't make it static.
4059 (syms_of_data): Use DEFSYM.
4060
e003a292
PE
40612011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4062
4063 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4064 (CCL_CODE_MIN): New macro.
4065
ed008a6d
PE
40662011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4067
3687c2ef
PE
4068 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4069
ed008a6d
PE
4070 * eval.c (Qdebug): Now static.
4071 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4072 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4073 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4074
d66c4c7c
CY
40752011-05-29 Chong Yidong <cyd@stupidchicken.com>
4076
4077 * image.c: Various fixes to ImageMagick code comments.
4078 (Fimagemagick_types): Doc fix.
4079
5fbc2025
PE
40802011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4081
0196f88a
PE
4082 Minor fixes prompted by GCC 4.6.0 warnings.
4083
4084 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4085
5fbc2025
PE
4086 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4087 (x_clipboard_manager_save_all): Move extern decl to ...
4088 * xterm.h: ... here, so that it can be checked for consistency.
4089
1dd3c2d9
CY
40902011-05-29 Chong Yidong <cyd@stupidchicken.com>
4091
4092 * xselect.c (x_clipboard_manager_save_frame)
4093 (x_clipboard_manager_save_all): New functions.
4094 (Fx_clipboard_manager_save): Lisp function deleted.
4095
4096 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4097 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4098
4099 * xterm.h: Update prototype.
4100
5ba6571d
WX
41012011-05-28 William Xu <william.xwl@gmail.com>
4102
4103 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4104 exiting (Bug#8239).
4105
3eaff834
JM
41062011-05-28 Jim Meyering <meyering@redhat.com>
4107
e1900994 4108 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4109 * fns.c (to_uchar): Define.
4110 (crypto_hash_function): Use it to convert some newly-signed
4111 variables to unsigned, to avoid sign-extension bugs. For example,
4112 without this change, (md5 "truc") would evaluate to
4113 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4114 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4115 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4116
0f6990a7
PE
41172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4118
4119 Integer overflow fixes.
c8a9ca5a 4120
08686060
PE
4121 * dbusbind.c: Serial number integer overflow fixes.
4122 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4123 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4124 to hold a serial number that is too large for a fixnum.
4125 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4126 Check for serial numbers out of range. Decode any serial number
59568bf0 4127 that was so large that it became a float. (Bug#8722)
08686060 4128
2d1fc3c7
PE
4129 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4130 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4131 Use XFASTINT rather than XUINT when numbers are nonnegative.
4132 (xd_append_arg, Fdbus_method_return_internal):
4133 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4134 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4135 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4136 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4137 (Bug#8722)
2d1fc3c7 4138
c8a9ca5a
PE
4139 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4140
519e1d69
PE
4141 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4142
30569699
PE
4143 ccl: add integer overflow checks
4144 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4145 (IN_INT_RANGE): New macros.
4146 (ccl_driver): Use them to check for integer overflow when
4147 decoding a CCL program. Many of the new checks are whether XINT (x)
4148 fits in int; it doesn't always, on 64-bit hosts. The new version
4149 doesn't catch all possible integer overflows, but it's an
847044ea 4150 improvement. (Bug#8719)
30569699 4151
c11285dc
PE
4152 * alloc.c (make_event_array): Use XINT, not XUINT.
4153 There's no need for unsigned here.
4154
fdccd48e
PE
4155 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4156 This follows up to the 2011-05-06 change that substituted uintptr_t
4157 for EMACS_INT. This case wasn't caught back then.
4158
37910ab2
PE
4159 Rework Fformat to avoid integer overflow issues.
4160 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4161 now (part of C89). Include <verify.h>.
4162 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4163 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4164 (Fformat): Avoid the prepass trying to compute sizes; it was only
4165 approximate and thus did not catch overflow reliably. Instead, walk
4166 through the format just once, formatting and computing sizes as we go,
4167 checking for integer overflow at every step, and allocating a larger
4168 buffer as needed. Keep track separately whether the format is
4169 multibyte. Keep only the most-recently calculated precision, rather
4170 than them all. Record whether each argument has been converted to
4171 string. Use EMACS_INT, not int, for byte and char and arg counts.
4172 Support field widths and precisions larger than INT_MAX. Avoid
4173 sprintf's undefined behavior with conversion specifications such as %#d
4174 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4175 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4176 formatting out-of-range floating point numbers with int
9173deec 4177 formats. (Bug#8668)
37910ab2 4178
2e6578fb
PE
4179 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4180
0ae6bdee
PE
4181 * data.c: Avoid integer truncation in expressions involving floats.
4182 * data.c: Include <intprops.h>.
4183 (arith_driver): When there's an integer overflow in an expression
4184 involving floating point, convert the integers to floating point
4185 so that the resulting value does not suffer from catastrophic
4186 integer truncation. For example, on a 64-bit host (* 4
4187 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4188 Do not rely on undefined behavior after integer overflow.
4189
de883a70
PE
4190 merge count_size_as_multibyte, parse_str_to_multibyte
4191 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4192 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4193 Check for integer overflow.
4194 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4195 since it's now a duplicate of the other. This is more of
4196 a character than a buffer op, so better that it's in character.c.
4197 * fns.c, print.c: Adjust to above changes.
4198
2ff916cb
PE
41992011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4200
4201 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4202
f1b54466
PE
42032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4204
fb1ac845
PE
4205 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4206 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4207 (x_clipboard_manager_save): Now static.
4208 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4209
f1b54466
PE
4210 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4211 (crypto_hash_function): Now static.
4212 Fix pointer signedness problems. Avoid unnecessary initializations.
4213
a9f737ee
CY
42142011-05-27 Chong Yidong <cyd@stupidchicken.com>
4215
4216 * termhooks.h (Vselection_alist): Make it terminal-local.
4217
4218 * terminal.c (create_terminal): Initialize it.
4219
4220 * xselect.c: Support for clipboard managers.
4221 (Vselection_alist): Move to termhooks.h as terminal-local var.
4222 (LOCAL_SELECTION): New macro.
4223 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4224 (symbol_to_x_atom): Remove gratuitous arg.
4225 (x_handle_selection_request, lisp_data_to_selection_data)
4226 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4227 (x_own_selection, x_get_local_selection, x_convert_selection):
4228 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4229 (some_frame_on_display): Delete unused function.
4230 (Fx_own_selection_internal, Fx_get_selection_internal)
4231 (Fx_disown_selection_internal, Fx_selection_owner_p)
4232 (Fx_selection_exists_p): New optional frame arg.
4233 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4234 (x_handle_selection_clear): Don't treat other terminals with the
4235 same keyboard specially. Use the terminal-local Vselection_alist.
4236 (x_clear_frame_selections): Use Frun_hook_with_args.
4237
4238 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4239
4240 * xterm.h: Add support for those atoms.
4241
e067f0c1
CY
42422011-05-26 Chong Yidong <cyd@stupidchicken.com>
4243
4244 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4245 (converted_selections, conversion_fail_tag): New global variables.
4246 (x_selection_request_lisp_error): Free the above.
4247 (x_get_local_selection): Remove unnecessary code.
4248 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4249 of converted selections stored in converted_selections.
4250 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4251 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4252 (x_convert_selection): New function.
4253 (x_handle_selection_event): Simplify.
4254 (x_get_foreign_selection): Don't ignore incoming requests while
4255 waiting for an answer; this will fail when we implement
4256 SAVE_TARGETS, and seems unnecessary anyway.
4257 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4258 (Vx_sent_selection_functions): Doc fix.
4259
0f4aebc0
LL
42602011-05-26 Leo Liu <sdl.web@gmail.com>
4261
4262 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4263
e61124cd
YM
42642011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4265
4266 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4267
4268 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4269 for fringe update if it has periodic bitmap.
ac389d0c 4270 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4271 and fringe_bitmap_periodic_p.
4272
4273 * fringe.c (get_fringe_bitmap_data): New function.
4274 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4275 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4276 row. Mark glyph row for fringe update if periodicity changed.
4277
4278 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4279 for fringe update unless it has periodic bitmap.
4280
f16d9837
KH
42812011-05-25 Kenichi Handa <handa@m17n.org>
4282
4283 * xdisp.c (get_next_display_element): Set correct it->face_id for
4284 a static composition.
4285
e1b90ef6
LL
42862011-05-24 Leo Liu <sdl.web@gmail.com>
4287
4288 * deps.mk (fns.o):
4289 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4290
4291 * fns.c (crypto_hash_function, Fsha1): New function.
4292 (Fmd5): Use crypto_hash_function.
4293 (syms_of_fns): Add Ssha1.
4294
7400048f
PE
42952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4296
4297 * gnutls.c: Remove unused macros.
4298 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4299 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4300 Remove macros that are defined and never used.
4301 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4302
abb71cf4
CY
43032011-05-22 Chong Yidong <cyd@stupidchicken.com>
4304
4305 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4306 (Fx_get_selection_internal): Minor cleanup.
4307 (Fx_own_selection_internal): Rename arguments for consistency with
4308 select.el.
4309
6307db39
PE
43102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4311
4312 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4313
f3d4e0a4
CY
43142011-05-22 Chong Yidong <cyd@stupidchicken.com>
4315
4316 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4317
4d8ade89
YM
43182011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4319
4320 * dispnew.c (scrolling_window): Don't exclude the case that the
4321 last enabled row in the desired matrix touches the bottom boundary.
4322
32078c8d
GM
43232011-05-21 Glenn Morris <rgm@gnu.org>
4324
4325 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4326 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4327 and add some more files.
32078c8d 4328
7285dc67
EZ
43292011-05-20 Eli Zaretskii <eliz@gnu.org>
4330
4331 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4332 report_file_error introduced by the change from 2011-05-07.
4333
89d1bd22
PE
43342011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4335
4336 * systime.h (Time): Define only if emacs is defined.
4337 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4338 where the include path doesn't have X11/X.h by default. See
4339 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4340
e23640bb 43412011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4342
4343 * composite.c (find_automatic_composition): Fix previous change.
4344
b9704ad9
GM
43452011-05-20 Glenn Morris <rgm@gnu.org>
4346
4347 * lisp.mk: New file, split from Makefile.in.
4348 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4349 (shortlisp): Remove.
4350 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4351
4a720484
GM
43522011-05-19 Glenn Morris <rgm@gnu.org>
4353
4354 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4355 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4356 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4357 (lisp): Set the order to that of loadup.el.
4358 (shortlisp): Make it a copy of $lisp.
4359 (SOME_MACHINE_LISP): Remove.
4360 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4361 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4362
a28d4396
KH
43632011-05-18 Kenichi Handa <handa@m17n.org>
4364
4365 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4366 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4367 (find_automatic_composition): Mostly rewrite for efficiency.
4368
a2b1fa8e
JB
43692011-05-18 Juanma Barranquero <lekktu@gmail.com>
4370
4371 * makefile.w32-in: Update dependencies.
4372
8e1f5610
CS
43732011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4374
4375 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4376 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4377
7025ee00 43782011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4379
cdfa6eab
PE
4380 Fix some integer overflow issues, such as string length overflow.
4381
06d6db33
PE
4382 * insdel.c (count_size_as_multibyte): Check for string overflow.
4383
2b4560a8
PE
4384 * character.c (lisp_string_width): Check for string overflow.
4385 Use EMACS_INT, not int, for string indexes and lengths; in
4386 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4387 the resulting string length overflows an EMACS_INT; instead,
4388 report a string overflow if no precision given. When checking for
4389 precision exhaustion, use a check that cannot possibly have
4390 integer overflow. (Bug#8675)
4391 * character.h (lisp_string_width): Adjust to new signature.
4392
cb93f9be
PE
4393 * alloc.c (string_overflow): New function.
4394 (Fmake_string): Use it. This doesn't change behavior, but saves
4395 a few bytes and will simplify future changes.
4396 * character.c (string_escape_byte8): Likewise.
4397 * lisp.h (string_overflow): New decl.
4398
1a1f3366
PE
4399 Fixups, following up to the user-interface timestamp change.
4400 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4401 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4402 * msdos.c (mouse_get_pos): Likewise.
4403 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4404 * w32gui.h (Time): Define by including "systime.h" rather than by
4405 declaring it ourselves. (Bug#8664)
4406
d4e3e4d3
PE
4407 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4408 * image.c (clear_image_cache): Likewise.
4409
f6a24d19
PE
4410 * term.c (term_mouse_position): Don't assume time_t wraparound.
4411
08dc5ae6
PE
4412 Be more systematic about user-interface timestamps.
4413 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4414 and sometimes 'EMACS_UINT', to represent these timestamps.
4415 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4416 This makes the code easier to follow, and makes it easier to catch
4417 integer overflow bugs such as Bug#8664.
4418 * frame.c (Fmouse_position, Fmouse_pixel_position):
4419 Use Time, not unsigned long, for user-interface timestamps.
4420 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4421 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4422 * keyboard.h (last_event_timestamp): Likewise.
4423 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4424 * menu.h (xmenu_show): Likewise.
4425 * term.c (term_mouse_position): Likewise.
4426 * termhooks.h (struct input_event.timestamp): Likewise.
4427 (struct terminal.mouse_position_hook): Likewise.
4428 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4429 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4430 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4431 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4432 what it was before.
4433 * menu.h, termhooks.h: Include "systime.h", for Time.
4434
8e55734a
PE
4435 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4436 Don't assume that the difference between two unsigned long values
4437 can fit into an integer. At this point, we know button_down_time
4438 <= event->timestamp, so the difference must be nonnegative, so
4439 there's no need to cast the result if double-click-time is
4440 nonnegative, as it should be; check that it's nonnegative, just in
4441 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4442 apart (about 25 days). (Bug#8664)
8e55734a 4443
841f1b75 4444 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4445 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4446
3e26f69c
PE
4447 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4448 that always fit in int. Use a sentinel instead of a counter, to
4449 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4450 * frame.h (struct frame): Use int for menu_bar_items_used
4451 instead of EMACS_INT, since it always fits in int.
3e26f69c 4452
5cc152c0
PE
4453 * menu.c (grow_menu_items): Check for int overflow.
4454
d89eb65e
PE
4455 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4456
5235bd3e
PE
4457 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4458 Before, the code was not consistent. These values cannot exceed
4459 2**31 - 1 so there's no need to make them unsigned.
4460 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4461 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4462 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4463 as modifiers.
4464 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4465
bc827e23
PE
4466 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4467 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4468 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4469 presumably because the widths might not match.
4470
78eb494e
PE
4471 * window.c (size_window): Avoid needless test at loop start.
4472
04f2d78b
CB
44732011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4474
4475 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4476
d2fc7e3d 44772011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4478
4479 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4480
d2fc7e3d 44812011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4482
4483 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4484 `width' to `bar_area_x' and `bar_area_width', respectively.
4485 (x_scroll_run): Take account of fringe background extension.
4486
04f2d78b
CB
4487 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4488 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4489 `bar_area_width', respectively.
4490 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4491 background extension.
4492
79b70037
GM
44932011-05-10 Jim Meyering <meyering@redhat.com>
4494
4495 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4496
2f142cc5
JB
44972011-05-10 Juanma Barranquero <lekktu@gmail.com>
4498
4499 * image.c (Finit_image_library): Return t for built-in image types,
4500 like pbm and xbm. (Bug#8640)
4501
57679c86
AS
45022011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4503
4504 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4505
888c9e86
EZ
45062011-05-07 Eli Zaretskii <eliz@gnu.org>
4507
b0512a1d
EZ
4508 * w32console.c (Fset_screen_color): Doc fix.
4509 (Fget_screen_color): New function.
4510 (syms_of_ntterm): Defsubr it.
4511
7285dc67
EZ
4512 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4513 unlink the temporary file if Fcall_process didn't create it in the
4514 first place.
4515 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4516 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4517 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4518 cue to call_process_cleanup not to close that handle.
4519
4d3fcc8e
BK
45202011-05-07 Ben Key <bkey76@gmail.com>
4521
4522 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4523 one of two shell specific rules, either bootstrap-temacs-CMD or
4524 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4525 to the previous implementation of the bootstrap-temacs rule.
4526 The bootstrap-temacs-CMD rule is similar to the previous
4527 implementation of the bootstrap-temacs rule except that it
4528 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4529 variable.
4530
4531 These changes, along with some changes to nt/configure.bat,
4532 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4533 earlier fix to add support for --cflags and --ldflags options
4534 that include quotes so that it works whether make uses cmd or
4535 sh as the shell.
4536
b4289b64
MA
45372011-05-06 Michael Albinus <michael.albinus@gmx.de>
4538
4539 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4540 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4541 is a constant.
4542 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4543 a string. Handle both cases.
4544 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4545 (Fdbus_register_method): Use Qinvalid_function.
4546
af4c0e28
JB
45472011-05-06 Juanma Barranquero <lekktu@gmail.com>
4548
4549 * makefile.w32-in: Update dependencies.
4550 (LISP_H): Add inttypes.h and stdin.h.
4551 (PROCESS_H): Add unistd.h.
4552
c51453d9
EZ
45532011-05-06 Eli Zaretskii <eliz@gnu.org>
4554
4555 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4556 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4557
8ff0ac3c 45582011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4559
4c4b566b
PE
4560 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4561
aab2b9b5
PE
4562 * term.c (vfatal): Remove stray call to va_end.
4563 It's not needed and the C Standard doesn't allow it here anyway.
4564
c378da0b
PE
4565 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4566 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4567
288b08c7
PE
4568 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4569 bytes.
4570
e3601888
PE
4571 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4572
db6c0e74
PE
4573 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4574
dd5963ea
PE
4575 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4576
88c9450f
PE
4577 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4578
2f9442b8
PE
4579 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4580
c032b5f8
PE
4581 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4582 * charset.c (Fdefine_charset_internal): Don't initialize
4583 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4584 32-bit int (Bug#8600).
a108c10b
PE
4585
4586 * lread.c (read_integer): Be more consistent with string-to-number.
4587 Use string_to_number to do the actual conversion; this avoids
4588 rounding errors and fixes some other screwups. Without this fix,
4589 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4590 (digit_to_number): Move earlier, for benefit of read_integer.
4591 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4592 not a digit in any supported base. (Bug#8602)
a108c10b 4593
ad5f9eea
PE
4594 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4595
aec1708a
PE
4596 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4597 to match comment at start of function. This also removes a
4598 GCC warning about overflow in a 32+64-bit port.
4599
47be4ab5
PE
4600 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4601
371cac43
PE
4602 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4603 Reported by Stefan Monnier in
4604 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4605 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4606 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4607
d01a7826
PE
4608 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4609 (EMACS_UINTPTR): Likewise, with uintptr_t.
4610
7fd47d5c
PE
4611 * lisp.h: Prefer 64-bit EMACS_INT if available.
4612 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4613 on 32-bit hosts that have 64-bit int, so that they can access
4614 large files.
122b0c86
PE
4615 However, temporarily disable this change unless the temporary
4616 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4617
8727937b
PE
4618 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4619
8ac068ac
PE
4620 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4621 This removes an assumption that EMACS_INT and long are the same
4622 width as pointers. The assumption is true for Emacs porting targets
4623 now, but we want to make other targets possible.
4624 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4625 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4626 In the rest of the code, change types of integers that hold casted
4627 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4628 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4629 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4630 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4631 No need to cast type when ORing.
4632 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4633 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4634 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4635 assume EMACS_INT is the same width as char *.
4636 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4637 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4638 Remove no-longer-needed casts.
4639 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4640 (xg_tool_bar_help_callback, xg_make_tool_item):
4641 Use EMACS_INTPTR to hold an integer
4642 that will be cast to void *; this can avoid a GCC warning
4643 if EMACS_INT is not the same width as void *.
4644 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4645 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4646 (current_message_1, set_message_1):
4647 Use a local to convert to proper width without a cast.
4648 * xmenu.c (dialog_selection_callback): Likewise.
4649
ede49d71
PE
4650 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4651 Also, don't assume VALBITS / RAND_BITS is less than 5,
4652 and don't rely on undefined behavior when shifting a 1 left into
4653 the sign bit.
4654 * lisp.h (get_random): Change signature to match.
4655
2f30ecd0
PE
4656 * lread.c (hash_string): Use size_t, not int, for hash computation.
4657 Normally we prefer signed values; but hashing is special, because
4658 it's better to use unsigned division on hash table sizes so that
4659 the remainder is nonnegative. Also, size_t is the natural width
4660 for hashing into memory. The previous code used 'int', which doesn't
4661 retain enough info to hash well into very large tables.
4662 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4663
2a866e7b
PE
4664 * dbusbind.c: Don't possibly lose pointer info when converting.
4665 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4666 Use XPNTR rather than XHASH, so that the high-order bits of
4667 the pointer aren't lost when converting through void *.
4668
51639eac
PE
4669 * eval.c (Fautoload): Don't double-shift a pointer.
4670
92394119
PE
4671 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4672
dbdb9a7c
JB
46732011-05-06 Juanma Barranquero <lekktu@gmail.com>
4674
4675 * gnutls.c (DEF_GNUTLS_FN):
4676 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4677
db7a0b4f
AS
46782011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4679
4680 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4681 marker. (Bug#8610)
4682
f7ff1b0f 46832011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4684
4685 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4686 New version that can reserve upto 2GB of heap space.
4687
f7ff1b0f 46882011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4689
4690 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4691
639c109b
TZ
46922011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4693
4694 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4695 `gnutls_certificate_set_x509_key_file'.
4696
d2127135
JB
46972011-05-05 Juanma Barranquero <lekktu@gmail.com>
4698
4699 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4700 Update dependencies.
4701
e968f4f3
JB
47022011-05-04 Juanma Barranquero <lekktu@gmail.com>
4703
4704 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4705 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4706 Remove unused parameter `fildes'.
4707 * process.c (read_process_output, send_process): Don't pass it.
4708
84d358f0
JB
47092011-05-04 Juanma Barranquero <lekktu@gmail.com>
4710
4711 Fix previous change: the library cache is defined in w32.c.
4712 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4713 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4714
0898ca10
JB
47152011-05-04 Juanma Barranquero <lekktu@gmail.com>
4716
4717 Implement dynamic loading of GnuTLS on Windows.
4718
4719 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4720 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4721 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4722 Declare.
4723
4724 * gnutls.c (Qgnutls_dll): Define.
4725 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4726 (gnutls_*): Declare function pointers.
4727 (init_gnutls_functions): New function to initialize function pointers.
4728 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4729 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4730 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4731 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4732 (emacs_gnutls_write, emacs_gnutls_read)
4733 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4734 (Fgnutls_available_p): New function.
4735 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4736 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4737 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4738
4739 * image.c: Include w32.h.
4740 (Vimage_type_cache): Delete.
4741 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4742 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4743 (w32_delayed_load): Move to w32.c.
4744
4745 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4746
4747 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4748 (w32_delayed_load): Move from image.c. When loading a library, record
4749 its filename in the :loaded-from property of the library id.
4750 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4751 Initialize and staticpro them.
4752 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4753
4754 * process.c: Include lisp.h before w32.h, not after.
4755 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4756 instead of gnutls_record_check_pending.
4757
4758 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4759
ff4de4aa
TZ
47602011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4761
4762 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4763 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4764 as passed in.
4765
abe95abb
JD
47662011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4767
4768 * xterm.c (x_set_frame_alpha): Do not set property on anything
4769 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4770
e16e55d4
JB
47712011-05-02 Juanma Barranquero <lekktu@gmail.com>
4772
4773 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4774
bafcf6a5
JB
47752011-05-02 Juanma Barranquero <lekktu@gmail.com>
4776
4777 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4778 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4779 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4780 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4781 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4782 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4783 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4784 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4785 (Qgnutls_bootprop_callbacks_verify): Make static.
4786
e7a6747f
AS
47872011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4788
19ed11ba
AS
4789 * callproc.c: Indentation fixup.
4790
e7a6747f 4791 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4792 (wait_for_termination, interruptible_wait_for_termination):
4793 Move after wait_for_termination_1.
e7a6747f 4794
1ef14cb4
LMI
47952011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4796
4797 * sysdep.c (interruptible_wait_for_termination): New function
4798 which is like wait_for_termination, but allows keyboard
4799 interruptions.
4800
4801 * callproc.c (Fcall_process): Add (:file "file") as an option for
4802 the STDOUT buffer.
4803 (Fcall_process_region): Ditto.
4804
330d880c
EZ
48052011-04-30 Eli Zaretskii <eliz@gnu.org>
4806
8db90b73
EZ
4807 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4808 rather than `XVECTOR (FOO)->size'.
4809
330d880c
EZ
4810 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4811 inttypes.h, as a gnulib replacement is used if it not available in
4812 system headers.
4813
15cbd324
EZ
48142011-04-21 Eli Zaretskii <eliz@gnu.org>
4815
4816 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4817 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4818 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4819
4820 * coding.c (coding_alloc_by_realloc): Error out if destination
4821 will grow beyond MOST_POSITIVE_FIXNUM.
4822 (decode_coding_emacs_mule): Abort if there isn't enough place in
4823 charbuf for the composition carryover bytes. Reserve an extra
4824 space for up to 2 characters produced in a loop.
4825 (decode_coding_iso_2022): Abort if there isn't enough place in
4826 charbuf for the composition carryover bytes.
4827
48282011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4829
ae940cca
EZ
4830 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4831 aborting when %lld or %lll format is passed.
4832 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4833 %llo or %llx format is passed. (Bug#8545)
4834
03ab8921
EZ
4835 * window.c (window_scroll_line_based): Use a marker instead of
4836 simple variables to record original value of point. (Bug#7952)
4837
afda1437
EZ
4838 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4839 produced by %s or %c overflows available buffer space. (Bug#8545)
4840
f76dee0c
PE
48412011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4842
4843 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4844 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4845
fdc5744d
JB
48462011-04-28 Juanma Barranquero <lekktu@gmail.com>
4847
4848 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4849
638f053a
JB
48502011-04-28 Juanma Barranquero <lekktu@gmail.com>
4851
4852 * keyboard.c (Qdelayed_warnings_hook): Define.
4853 (command_loop_1): Run `delayed-warnings-hook'
4854 if Vdelayed_warnings_list is non-nil.
4855 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4856 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4857
d178f871
EZ
48582011-04-28 Eli Zaretskii <eliz@gnu.org>
4859
4860 * doprnt.c (doprnt): Don't return value smaller than the buffer
4861 size if the message was truncated. (Bug#8545).
4862
b124fd93
JB
48632011-04-28 Juanma Barranquero <lekktu@gmail.com>
4864
4865 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4866 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4867
e810457d
PE
48682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4869
4870 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4871
ea51cceb
JB
48722011-04-27 Juanma Barranquero <lekktu@gmail.com>
4873
4874 * makefile.w32-in: Update dependencies.
4875
94dcfacf
EZ
48762011-04-27 Eli Zaretskii <eliz@gnu.org>
4877
4878 Improve `doprnt' and its usage. (Bug#8545)
4879 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4880 `format_end'. Remove support for %l as a conversion specifier.
4881 Don't use xrealloc. Improve diagnostics when the %l size modifier
4882 is used. Update the commentary.
4883
4884 * eval.c (verror): Simplify calculation of size_t.
4885
4886 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4887 messages.
4888
f61f41d7
PE
48892011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4890
4891 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4892 change.
4893
96fb4434
PE
48942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4895
4896 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4897 This makes this file independent of the recent pseudovector change.
4898
671875da 48992011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4900
69e9b5a3
PE
4901 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4902
b5f869a7 4903 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4904 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4905 Remove unused local.
c8926152 4906 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4907
841a1577 4908 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4909 GCC 4.6.0 optimizes based on type-based alias analysis.
4910 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4911 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4912 != &v->size, and therefore "v->size = 1; b->size = 2; return
4913 v->size;" must therefore return 1. This assumption is incorrect
4914 for Emacs, since it type-puns struct Lisp_Vector * with many other
4915 types. To fix this problem, this patch adds a new type struct
f904488f 4916 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4917 and pseudovectors, and helps optimizing compilers not get fooled
4918 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4919 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4920 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4921 the size member.
eab3844f
PE
4922 (XSETPVECTYPE): Rewrite in terms of new macro.
4923 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4924 This is a bit clearer, and further avoids the possibility of
4925 undesirable aliasing.
4926 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4927 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4928 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4929 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4930 (ASIZE): Now uses header.size rather than size.
4931 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4932 to avoid the hassle of writing XVECTOR (foo)->header.size.
4933 (struct vectorlike_header): New type.
eab3844f
PE
4934 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4935 object, to help avoid aliasing.
4936 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4937 (SUBRP): Likewise, since Lisp_Subr is a special case.
4938 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4939 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4940 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4941 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4942 changed to be "header.size" and "header.next".
4943 * buffer.h (struct buffer): Likewise.
4944 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4945 * frame.h (struct frame): Likewise.
4946 * process.h (struct Lisp_Process): Likewise.
4947 * termhooks.h (struct terminal): Likewise.
4948 * window.c (struct save_window_data, struct saved_window): Likewise.
4949 * window.h (struct window): Likewise.
4950 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4951 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4952 * buffer.c (init_buffer_once): Likewise.
4953 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4954 special case.
4955 * process.c (Fformat_network_address): Use local var for size,
4956 for brevity.
4957
0df1eac5
PE
4958 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4959
847ab9d1 4960 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4961 * data.c (atof): Remove decl; no longer used or needed.
4962 (digit_to_number): Move to lread.c.
4963 (Fstring_to_number): Use new string_to_number function, to be
4964 consistent with how the Lisp reader treats infinities and NaNs.
4965 Do not assume that floating-point numbers represent EMACS_INT
4966 without losing information; this is not true on most 64-bit hosts.
4967 Avoid double-rounding errors, by insisting on integers when
4968 parsing non-base-10 numbers, as the documentation specifies.
4969 * lisp.h (string_to_number): New decl, replacing ...
4970 (isfloat_string): Remove.
bc0a5c13 4971 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4972 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4973 appears to have been a coding error. Similarly, do not accept
4974 strings like +-1e0 as floating point numbers. Do not report
4975 overflow for integer overflows unless the base is not 10 which
4976 means we have no simple and reliable way to continue.
4977 Break out the floating-point parsing into a new
4978 function string_to_number, so that Fstring_to_number parses
4979 floating point numbers consistently with the Lisp reader.
04f2d78b 4980 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4981 (E_CHAR, EXP_INT): Remove, replacing with ...
4982 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4983 (string_to_number): New function, replacing isfloat_string.
4984 This function checks for valid syntax and produces the resulting
4985 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4986 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4987 so that overflow for non-base-10 numbers is reported only when
4988 there's no portable and simple way to convert to floating point.
452f4150 4989
67769ffc
PE
4990 * textprop.c (set_text_properties_1): Rewrite for clarity,
4991 and to avoid GCC warning about integer overflow.
4992
c20db43f
PE
4993 * intervals.h (struct interval): Use EMACS_INT for members
4994 where EMACS_UINT might cause problems. See
4995 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4996 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4997 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4998 All uses changed.
37aa2f85
PE
4999 (offset_intervals): Tell GCC not to worry about length overflow
5000 when negating a negative length.
c20db43f 5001
2538aa2f
PE
5002 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5003 (overrun_check_free): Likewise.
5004
f2d3008d
PE
5005 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5006 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5007 word size.
5008
ec8df744
PE
5009 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5010 (gnutls_make_error): Rename local to avoid shadowing.
5011 (gnutls_emacs_global_deinit): ifdef out; not used.
5012 (Fgnutls_boot): Use const for pointer to readonly storage.
5013 Comment out unused local. Fix pointer signedness problems.
5014
640ee02d
PE
5015 * lread.c (openp): Don't stuff size_t into an 'int'.
5016 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5017 about possible signed overflow.
5018
6048fb2a
PE
5019 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5020 (GDK_KEY_g): Don't define if already defined.
5021 (xg_prepare_tooltip): Avoid pointer signedness problem.
5022 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5023
fa3c87e1
PE
5024 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5025 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5026
2172544b
PE
5027 * xfns.c (Fx_window_property): Simplify a bit,
5028 to make a bit faster and to avoid GCC 4.6.0 warning.
5029 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5030
9b821a21
PE
5031 * fns.c (internal_equal): Don't assume size_t fits in int.
5032
3c616cfa
PE
5033 * alloc.c (compact_small_strings): Tighten assertion a little.
5034
c2982e87
PE
5035 Replace pEd with more-general pI, and fix some printf arg casts.
5036 * lisp.h (pI): New macro, generalizing old pEd macro to other
5037 conversion specifiers. For example, use "...%"pI"d..." rather
5038 than "...%"pEd"...".
5039 (pEd): Remove. All uses replaced with similar uses of pI.
5040 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5041 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5042 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5043 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5044 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5045 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5046 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5047 64-bit hosts.
5048 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5049 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5050 * print.c (safe_debug_print, print_object): Likewise.
5051 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5052 to int.
6f04d126
PE
5053 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5054 avoiding the 0 flag, which is not portable.
c2982e87
PE
5055 * process.c (Fmake_network_process): Use pI to avoid cast.
5056 * region-cache.c (pp_cache): Likewise.
5057 * xdisp.c (decode_mode_spec): Likewise.
5058 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5059 behavior on 64-bit hosts with printf arg.
6f04d126 5060 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5061 (x_stop_queuing_selection_requests): Likewise.
5062 (x_get_window_property): Don't truncate byte count to an 'int'
5063 when tracing.
0b432f21 5064
5e073ec7
PE
5065 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5066 here, since it parses constructs like leading '-' and spaces,
5067 which are not wanted; and it overflows with large numbers.
5068 Instead, simply match F[0-9]+, which is what is wanted anyway.
5069
36372bf9
PE
5070 * alloc.c: Remove unportable assumptions about struct layout.
5071 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5072 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5073 (allocate_vectorlike, make_pure_vector): Use the new macros,
5074 plus offsetof, to remove unportable assumptions about struct layout.
5075 These assumptions hold on all porting targets that I know of, but
5076 they are not guaranteed, they're easy to remove, and removing them
5077 makes further changes easier.
5078
0b432f21
PE
5079 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5080 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5081 (string_overrun_cookie): Now const. Use initializers that
5082 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5083 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5084 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5085 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5086 multiple of sizeof (EMACS_INT); it need not be, if
5087 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5088 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5089
895009e1
JB
50902011-04-26 Juanma Barranquero <lekktu@gmail.com>
5091
5092 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5093
6a7a1b0b
TZ
50942011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5095
5096 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5097 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5098 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5099
841a1577 51002011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5101
5102 * lisp.h (Qdebug): List symbol.
895009e1 5103 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5104 * keyboard.c (debug-on-event): New variable.
5105 (handle_user_signal): Break into debugger when debug-on-event
5106 matches the current signal symbol.
5107
f2d3ba6f
DN
51082011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5109
5110 * alloc.c (check_sblock, check_string_bytes)
5111 (check_string_free_list): Convert to standard C.
5112
42ce4c63
TZ
51132011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5114
5115 * w32.c (emacs_gnutls_push): Fix typo.
5116
825cd63c
EZ
51172011-04-25 Eli Zaretskii <eliz@gnu.org>
5118
fb11d64d
EZ
5119 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5120 "cast to pointer from integer of different size".
5121
825cd63c
EZ
5122 Improve doprnt and its use in verror. (Bug#8545)
5123 * doprnt.c (doprnt): Document the set of format control sequences
5124 supported by the function. Use SAFE_ALLOCA instead of always
5125 using `alloca'.
5126
5127 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5128 is one byte too soon. Don't use xrealloc; instead xfree and
5129 xmalloc anew.
5130
e061a11b
TZ
51312011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5132
5133 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5134 callbacks stage.
5135
5136 * gnutls.c: Renamed global_initialized to
5137 gnutls_global_initialized. Added internals for the
5138 :verify-hostname-error, :verify-error, and :verify-flags
5139 parameters of `gnutls-boot' and documented those parameters in the
5140 docstring. Start callback support.
9173deec
JB
5141 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5142 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5143 on error. Return error code.
e061a11b
TZ
5144 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5145 (emacs_gnutls_read): Likewise.
5146 (Fgnutls_boot): Return handshake error code.
5147 (emacs_gnutls_handle_error): New function.
5148 (wsaerror_to_errno): Likewise.
5149
5150 * w32.h (emacs_gnutls_pull): Add prototype.
5151 (emacs_gnutls_push): Likewise.
5152
5153 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5154 (emacs_gnutls_push): Likewise.
5155
51562011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5157
5158 * process.c (wait_reading_process_output): Check if GnuTLS
5159 buffered some data internally if no FDs are set for TLS
5160 connections.
5161
5162 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5163 (LIBS): Link to USER_LIBS.
5164 ($(BLD)/gnutls.$(0)): New target.
5165
fa6996bc
EZ
51662011-04-24 Eli Zaretskii <eliz@gnu.org>
5167
eb35682e
EZ
5168 * xdisp.c (handle_single_display_spec): Rename the
5169 display_replaced_before_p argument into display_replaced_p, to
5170 make it consistent with the commentary. Fix typos in the
5171 commentary.
5172
e2ad650c
EZ
5173 * textprop.c (syms_of_textprop): Remove dead code.
5174 (copy_text_properties): Delete obsolete commentary about an
5175 interface that was deleted long ago. Fix typos in the description
5176 of arguments.
5177
1b2de274
EZ
5178 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5179 to changes in oldXMenu/XMenu.h from 2011-04-16.
5180 <menu_help_message, prev_menu_help_message>: Constify.
5181 (IT_menu_make_room): menu->help_text is now `const char **';
5182 adjust.
5183
5184 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5185 to changes in oldXMenu/XMenu.h from 2011-04-16.
5186 (struct XMenu): Declare `help_text' `const char **'.
5187
5188 * xfaces.c <Qunspecified>: Make extern again.
5189
5190 * syntax.c: Include sys/types.h before including regex.h, as
5191 required by Posix.
5192
762b15be
EZ
5193 * doc.c (get_doc_string): Improve the format passed to `error'.
5194
5195 * doprnt.c (doprnt): Improve commentary.
5196
5197 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5198
5199 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5200 them with etags.
5201
f1052e5d
EZ
5202 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5203 changes in globals.h immediately force recompilation.
762b15be
EZ
5204 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5205 $(CURDIR)/s/ms-w32.h.
5206 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5207
fa6996bc
EZ
5208 * character.c (Fchar_direction): Function deleted.
5209 (syms_of_character): Don't defsubr it.
5210 <char-direction-table>: Deleted.
5211
e6c3da20
EZ
52122011-04-23 Eli Zaretskii <eliz@gnu.org>
5213
5214 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5215 * doprnt.c: Include limits.h.
5216 (SIZE_MAX): New macro.
04f2d78b
CB
5217 (doprnt): Return a size_t value. 2nd arg is now size_t.
5218 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5219 Improve overflow protection. Support `l' modifier for integer
5220 conversions. Support %l conversion. Don't assume an EMACS_INT
5221 argument for integer conversions and for %c.
5222
5223 * lisp.h (doprnt): Restore prototype.
5224
5225 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5226 $(SRC)/character.h.
5227
5228 * Makefile.in (base_obj): Add back doprnt.o.
5229
5230 * deps.mk (doprnt.o): Add back prerequisites.
5231 (callint.o): Depend on character.h.
5232
5233 * eval.c (internal_lisp_condition_case): Include the handler
5234 representation in the error message.
5235 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5236 when breaking from the loop.
5237
5238 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5239
5240 * callint.c (Fcall_interactively): When displaying error message
5241 about invalid control letter, pass the character's codepoint, not
5242 a pointer to its multibyte form. Improve display of the character
5243 in octal and display also its hex code.
5244
5245 * character.c (char_string): Use %x to display the (unsigned)
5246 codepoint of an invalid character, to avoid displaying a bogus
5247 negative value.
5248
5249 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5250 `error', not SYMBOL_NAME itself.
5251
5252 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5253 character arguments to `error'.
5254
5255 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5256 to `error' in error message about FINAL_CHAR argument. Make sure
5257 FINAL_CHAR is a character, and use %c when it is passed as
5258 argument to `error'.
5259
4ffd0d6b 52602011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5261
5262 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5263
5264 * w32.c: Include <time.h>.
5265 (sys_localtime): New function.
5266
4ffd0d6b 52672011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5268
5269 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5270
4ffd0d6b 5271 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5272
4ffd0d6b 52732011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5274
4ffd0d6b
GM
5275 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5276 zombies (Bug#8467).
aac0c6e3 5277
04c56954
EZ
52782011-04-19 Eli Zaretskii <eliz@gnu.org>
5279
5280 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5281 gl_state.e_property when gl_state.object is Qt.
5282
5283 * insdel.c (make_gap_larger): Remove limitation of buffer size
5284 to <= INT_MAX.
5285
16a43933
CY
52862011-04-18 Chong Yidong <cyd@stupidchicken.com>
5287
5288 * xdisp.c (lookup_glyphless_char_display)
5289 (produce_glyphless_glyph): Handle cons cell entry in
5290 glyphless-char-display.
5291 (Vglyphless_char_display): Document it.
5292
5293 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5294 glyphless-char-display.
5295
4581706e
CY
52962011-04-17 Chong Yidong <cyd@stupidchicken.com>
5297
5298 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5299
5300 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5301
5302 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5303 definition for no-X builds.
5304
4887c6e2 53052011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5306
fd35b6f9
PE
5307 Static checks with GCC 4.6.0 and non-default toolkits.
5308
5c1ccb01
PE
5309 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5310
006c5daa
PE
5311 * process.c (keyboard_bit_set): Define only if SIGIO.
5312 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5313 (send_process): Repair possible setjmp clobbering.
5314
efc736d3
PE
5315 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5316
4e2fe2e6
PE
5317 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5318
f97334a2
PE
5319 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5320
4e75f29d
PE
5321 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5322 Define only if needed.
5323
90efadd1
PE
5324 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5325 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5326 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5327
3c647824
PE
5328 * dispextern.h (struct redisplay_interface): Rename param
5329 to avoid shadowing.
e264f262 5330 * termhooks.h (struct terminal): Likewise.
761383f4 5331 * xterm.c (xembed_send_message): Likewise.
3c647824 5332
b58c5c4a
PE
5333 * insdel.c (make_gap_smaller): Define only if
5334 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5335
cad59032
PE
5336 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5337 it.
5338
c339dc2e
PE
5339 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5340 so that we aren't warned about unused symbols.
5341
91a3e27b
PE
5342 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5343
399c71d3 5344 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5345
8ffc96f5
PE
5346 * xfns.c (x_real_positions): Mark locals as initialized.
5347
eef9bc79
PE
5348 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5349
098db9dd
PE
5350 * xterm.c: Fix problems found by static analysis with other toolkits.
5351 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5352 (x_dispatch_event): Declare static if USE_GTK, and
5353 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5354 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5355 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5356 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5357 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5358
eb18f6cc
PE
5359 * xmenu.c (menu_help_callback): Pointer type fixes.
5360 Use const pointers when pointing at readonly data. Avoid pointer
5361 signedness clashes.
5362 (FALSE): Remove unused macro.
5363 (update_frame_menubar): Remove unused decl.
5364
1fe72bf8
PE
5365 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5366
60d9e1db
PE
5367 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5368 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5369 (single_menu_item): Rename local to avoid shadowing.
5370
39261c26
PE
5371 * keyboard.c (make_lispy_event): Remove unused local var.
5372
018c5e19
PE
5373 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5374 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5375
63d2b86e
PE
5376 * bitmaps: Change bitmaps from unsigned char back to the X11
5377 compatible char. Avoid the old compiler warnings about
5378 out-of-range initializers by using, for example, '\xab' rather
5379 than 0xab.
5380
aefd87e1
PE
5381 * xgselect.c (xgselect_initialize): Check vs interface
5382 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5383
bf501fb9
PE
5384 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5385
e9829fdf
PE
5386 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5387 to read-only memory.
5388
1086c095
PE
5389 * fns.c (vector): Remove; this old hack is no longer needed.
5390
2baccd04 5391 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5392 Remove unused var.
dde42981 5393 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5394
72391843 5395 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5396
436c16df 5397 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5398 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5399 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5400
92bb796d 5401 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5402 (x_term_init): Remove local to avoid shadowing.
92bb796d 5403
764430a3 5404 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5405
5406 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5407 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5408
d1dfb56c
EZ
54092011-04-16 Eli Zaretskii <eliz@gnu.org>
5410
c4354cb4
EZ
5411 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5412
d1dfb56c
EZ
5413 Fix regex.c, syntax.c and friends for buffers > 2GB.
5414 * syntax.h (struct gl_state_s): Declare character position members
5415 EMACS_INT.
5416
5417 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5418
04f2d78b
CB
5419 * textprop.c (verify_interval_modification, interval_of):
5420 Declare arguments EMACS_INT.
d1dfb56c
EZ
5421
5422 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5423 EMACS_INT.
5424
5425 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5426
5427 * indent.c (Fvertical_motion): Local variable it_start is now
5428 EMACS_INT.
5429
5430 * regex.c (re_match, re_match_2, re_match_2_internal)
5431 (bcmp_translate, regcomp, regexec, print_double_string)
5432 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5433 (re_compile_pattern, re_exec): Declare arguments and local
5434 variables `size_t' and `ssize_t' and return values `regoff_t', as
5435 appropriate.
5436 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5437 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5438 <compile_stack_type>: `size' and `avail' are now `size_t'.
5439
5440 * regex.h <regoff_t>: Use ssize_t, not int.
5441 (re_search, re_search_2, re_match, re_match_2): Arguments that
5442 specify buffer/string position and length are now ssize_t and
5443 size_t. Return type is regoff_t.
5444
613052cd
BK
54452011-04-16 Ben Key <bkey76@gmail.com>
5446
5447 * nsfont.m: Fixed bugs in ns_get_family and
5448 ns_descriptor_to_entity that were caused by using free to
5449 deallocate memory blocks that were allocated by xmalloc (via
5450 xstrdup). This caused Emacs to crash when compiled with
5451 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5452 --enable-checking=xmallocoverrun). xfree is now used to
5453 deallocate these memory blocks.
5454
4170f62f 54552011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5456
71b41406
PE
5457 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5458
9587a89d
PE
5459 emacs_write: Accept and return EMACS_INT for sizes.
5460 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5461 et seq.
5462 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5463 Accept and return EMACS_INT.
5464 (emacs_gnutls_write): Return the number of bytes written on
5465 partial writes.
5466 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5467 (emacs_read, emacs_write): Remove check for negative size, as the
5468 Emacs source code has been audited now.
9587a89d
PE
5469 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5470 (emacs_read, emacs_write): Use it.
273a5f82
PE
5471 * process.c (send_process): Adjust to the new signatures of
5472 emacs_write and emacs_gnutls_write. Do not attempt to store
5473 a byte offset into an 'int'; it might overflow.
9587a89d 5474 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5475
3e047f51
PE
5476 * sound.c: Don't assume sizes fit in 'int'.
5477 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5478 Return EMACS_INT, not int.
3e047f51 5479 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5480 Accept EMACS_INT, not int.
5481 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5482 record read return values.
5483
cc39a9db
BK
54842011-04-15 Ben Key <bkey76@gmail.com>
5485
c9d0ec6d
JB
5486 * keyboard.c (Qundefined): Don't declare static since it is used
5487 in nsfns.m.
5488 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5489 static since they are used in nsfont.m.
cc39a9db 5490
6c60eb9f
SM
54912011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5492
5493 * process.c (Qprocessp): Don't declare static.
5494 * lisp.h (Qprocessp): Declare again.
5495
7990b61a
JB
54962011-04-15 Juanma Barranquero <lekktu@gmail.com>
5497
5498 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5499
5d4cb038
PE
55002011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5501
8bd7b830 5502 Improve C-level modularity by making more things 'static'.
cd64ea1d 5503
e3b27b31
PE
5504 Don't publish debugger-only interfaces to other modules.
5505 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5506 (verify_bytepos, count_markers): Move decls to the only modules
5507 that need them.
5508 * region-cache.h (pp_cache): Likewise.
5509 * window.h (check_all_windows): Likewise.
5510 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5511
5d4cb038
PE
5512 * sysdep.c (croak): Now static, if
5513 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5514 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5515
5516 * alloc.c (refill_memory_reserve): Now static if
5517 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5518 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5519
e87b6180
PE
5520 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5521 Define only if USE_LUCID.
5522
ac64929e
PE
5523 * xrdb.c (x_customization_string, x_rm_string): Now static.
5524
6f37259d
PE
5525 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5526 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5527
1683e3ab
PE
5528 * xdisp.c (draw_row_with_mouse_face): Now static.
5529 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5530
de9c2632
PE
5531 * window.h (check_all_windows): Mark externally visible.
5532
2b96acb7
PE
5533 * window.c (window_deletion_count): Now static.
5534
5535 * undo.c: Make symbols static if they're not exported.
5536 (last_undo_buffer, last_boundary_position, pending_boundary):
5537 Now static.
5538
50436f33
PE
5539 * textprop.c (interval_insert_behind_hooks): Now static.
5540 (interval_insert_in_front_hooks): Likewise.
5541
64520e5c
PE
5542 * term.c: Make symbols static if they're not exported.
5543 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5544 (max_frame_lines, tty_set_terminal_modes):
5545 (tty_reset_terminal_modes, tty_turn_off_highlight):
5546 (get_tty_terminal): Now static.
5547 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5548 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5549 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5550 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5551 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5552
1fa53021
PE
5553 * sysdep.c: Make symbols static if they're not exported.
5554 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5555 Now static.
5556 (sigprocmask_set, full_mask): Remove; unused.
5557 (wait_debugging): Mark as visible.
5558 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5559 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5560
d4b43b22
PE
5561 * syntax.c (syntax_temp): Define only if !__GNUC__.
5562
b7c513d0
PE
5563 * sound.c (current_sound_device, current_sound): Now static.
5564
989b29ad
PE
5565 * search.c (searchbufs, searchbuf_head): Now static.
5566
13a55a78
PE
5567 * scroll.c (scroll_cost): Remove; unused.
5568 * dispextern.h (scroll_cost): Remove decl.
5569
de68a1fc
PE
5570 * region-cache.h (pp_cache): Mark as externally visible.
5571
40ccffa6
PE
5572 * process.c: Make symbols static if they're not exported.
5573 (process_tick, update_tick, create_process, chan_process):
5574 (Vprocess_alist, proc_buffered_char, datagram_access):
5575 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5576 (deactivate_process): Mark defn as static, as well as decl.
5577 * lisp.h (create_process): Remove decl.
5578 * process.h (chan_process, Vprocess_alist): Remove decls.
5579
ad64fc97
PE
5580 * print.c: Make symbols static if they're not exported.
5581 (print_depth, new_backquote_output, being_printed, print_buffer):
5582 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5583 (print_interval, print_number_index, initial_stderr_stream):
5584 Now static.
5585 * lisp.h (Fprinc): Remove decl.
5586 (debug_output_compilation_hack): Mark as externally visible.
5587
adddb265
PE
5588 * sysdep.c (croak): Move decl from here to syssignal.h.
5589 * syssignal.h (croak): Put it here, so the API can be checked when
5590 'croak' is called from dissociate_if_controlling_tty.
5591
1717ede2
PE
5592 * minibuf.c: Make symbols static if they're not exported.
5593 (minibuf_save_list, choose_minibuf_frame): Now static.
5594 * lisp.h (choose_minibuf_frame): Remove decl.
5595
fa5fb2bc
PE
5596 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5597
1e3890d1
PE
5598 * lread.c: Make symbols static if they're not exported.
5599 (read_objects, initial_obarray, oblookup_last_bucket_number):
5600 Now static.
5601 (make_symbol): Remove; unused.
5602 * lisp.h (initial_obarray, make_symbol): Remove decls.
5603
8a1414fa
PE
5604 * keyboard.c: Make symbols static if they're not exported.
5605 (single_kboard, recent_keys_index, total_keys, recent_keys):
5606 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5607 (this_single_command_key_start, echoing, last_auto_save):
5608 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5609 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5610 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5611 (Vlispy_mouse_stem, double_click_count):
5612 Now static.
5613 (force_auto_save_soon): Define only if SIGDANGER.
5614 (ignore_mouse_drag_p): Now static if
5615 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5616 (print_help): Remove; unused.
5617 (stop_character, last_timer_event): Mark as externally visible.
5618 * keyboard.h (ignore_mouse_drag_p): Declare only if
5619 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5620 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5621 * lisp.h (echoing): Remove decl.
5622 (force_auto_save_soon): Declare only if SIGDANGER.
5623 * xdisp.c (redisplay_window): Simplify code, to make it more
5624 obvious that ignore_mouse_drag_p is not accessed if !defined
5625 USE_GTK && !defined HAVE_NS.
5626
93ea6e8f
PE
5627 * intervals.c: Make symbols static if they're not exported.
5628 (merge_properties_sticky, merge_interval_right, delete_interval):
5629 Now static.
5630 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5631
77382fcc
PE
5632 * insdel.c: Make symbols static if they're not exported.
5633 However, leave prepare_to_modify_buffer alone. It's never
5634 called from outside this function, but that appears to be a bug.
5635 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5636 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5637 (adjust_after_replace_noundo): Remove; unused.
5638 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5639 (signal_before_change): Remove decls.
77382fcc 5640
9306c32e
PE
5641 * indent.c (val_compute_motion, val_vmotion): Now static.
5642
cd44d2eb
PE
5643 * image.c: Make symbols static if they're not exported.
5644 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5645 if USE_GTK.
5646 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5647 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5648
ad9a7a06
PE
5649 * fringe.c (standard_bitmaps): Now static.
5650 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5651
81626931
PE
5652 * frame.c: Make symbols static if they're not exported.
5653 (x_report_frame_params, make_terminal_frame): Now static.
5654 (get_frame_param): Now static, unless HAVE_NS.
5655 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5656 (x_get_resource_string): Remove; not used.
5657 * frame.h (make_terminal_frame, x_report_frame_params):
5658 (x_get_resource_string); Remove decls.
5659 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5660 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5661
239f9db9
PE
5662 * font.c, fontset.c: Make symbols static if they're not exported.
5663 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5664 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5665 * font.c (font_close_object): Now static.
5666 * font.h (font_close_object): Remove.
5667 * fontset.c (FONTSET_OBJLIST): Remove.
5668 (free_realized_fontset) #if-0 the body, which does nothing.
5669 (face_suitable_for_char_p): #if-0, as it's never called.
5670 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5671 * xfaces.c (face_at_string_position):
5672 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5673 since 0 is always ASCII.
5674
dfcf3579
PE
5675 * fns.c (weak_hash_tables): Now static.
5676
5045092b
PE
5677 * fileio.c: Make symbols static if they're not exported.
5678 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5679 (Vwrite_region_annotation_buffers): Now static.
5680
57a96f5c
PE
5681 * eval.c: Make symbols static if they're not exported.
5682 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5683 * lisp.h (backtrace_list): Remove decl.
5684
35f08c38
PE
5685 * emacs.c: Make symbols static if they're not exported.
5686 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5687 (fatal_error_code, fatal_error_signal_hook, standard_args):
5688 Now static.
5689 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5690 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5691 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5692 * lisp.h (fatal_error_signal_hook): Remove decl.
5693 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5694
f44bd759
PE
5695 * editfns.c: Move a (normally-unused) function to its only use.
5696 * editfns.c, lisp.h (get_operating_system_release): Remove.
5697 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5698 worth the hassle of breaking this out.
5699
b532497d
PE
5700 * xterm.c: Make symbols static if they're not exported.
5701 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5702 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5703 (x_destroy_window, x_delete_display):
5704 Now static.
5705 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5706 (x_mouse_leave): Remove; unused.
5707 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5708 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5709 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5710 Remove decls.
5711 (x_mouse_leave): Declare only if WINDOWSNT.
5712 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5713 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5714 USE_X_TOOLKIT.
5715
1675728f
PE
5716 * ftxfont.c: Make symbols static if they're not exported.
5717 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5718 HAVE_FREETYPE.
5719 * font.h (ftxfont_driver): Likewise.
5720
e4cebfca
PE
5721 * xfns.c: Make symbols static if they're not exported.
5722 (x_last_font_name, x_display_info_for_name):
5723 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5724 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5725 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5726 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5727 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5728 (last_show_tip_args): Now static.
5729 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5730 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5731 (x_screen_planes): Remove; unused.
5732 * dispextern.h (x_screen_planes): Remove decl.
5733
5bf46f05
PE
5734 * dispnew.c: Make symbols static if they're not exported.
5735 * dispextern.h (redraw_garbaged_frames, scrolling):
5736 (increment_row_positions): Remove.
5737 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5738 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5739 Now static.
5740 (redraw_garbaged_frames): Remove; unused.
5741
435f4c28
PE
5742 * xfaces.c: Make symbols static if they're not exported.
5743 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5744 Remove decls.
5745 * xterm.h (defined_color): Remove decls.
5746 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5747 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5748 (menu_face_changed_default, defined_color, free_realized_face):
5749 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5750 (ascii_face_of_lisp_face): Remove; unused.
5751
8524aef3
PE
5752 * xdisp.c: Make symbols static if they're not exported.
5753 * dispextern.h (scratch_glyph_row, window_box_edges):
5754 (glyph_to_pixel_coords, set_cursor_from_row):
5755 (get_next_display_element, set_iterator_to_next):
5756 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5757 (show_mouse_face): Remove decls
5758 * frame.h (message_buf_print): Likewise.
5759 * lisp.h (pop_message, set_message, check_point_in_composition):
5760 Likewise.
5761 * xterm.h (set_vertical_scroll_bar): Likewise.
5762 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5763 (message_buf_print, scratch_glyph_row, displayed_buffer):
5764 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5765 (get_next_display_element, show_mouse_face, window_box_edges):
5766 (frame_to_window_pixel_xy, check_point_in_composition):
5767 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5768 (glyph_to_pixel_coords): Remove; unused.
5769
16390cd2
PE
5770 * dired.c (file_name_completion): Now static.
5771
5772 * dbusbind.c (xd_in_read_queued_messages): Now static.
5773
a25f4dfa
PE
5774 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5775 * data.c (circular_list_error): Remove.
5776
14a9c8df
PE
5777 * commands.h (last_point_position, last_point_position_buffer):
5778 (last_point_position_window): Remove decls.
5779 * keyboard.c: Make these variables static.
5780
04f2d78b
CB
5781 * coding.h (coding, code_convert_region, encode_coding_gap):
5782 Remove decls.
74ab6df5
PE
5783 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5784 (iso_code_class, detect_coding, code_convert_region): Now static.
5785 (encode_coding_gap): Remove; unused.
5786
38dfbee1
PE
5787 * chartab.c (chartab_chars, chartab_bits): Now static.
5788
a2cb4e63
PE
5789 * charset.h (charset_iso_8859_1): Remove decl.
5790 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5791 Now static.
5792
127198fd
PE
5793 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5794 * ccl.c (Vccl_program_table): Now static.
5795 (check_ccl_update): Remove; unused.
5796
d85b608f
PE
5797 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5798 * category.h: ... from here.
5799 * category.c (check_category_table, set_category_set): Now static.
5800
31cd66f3
PE
5801 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5802 * lisp.h: Remove these decls.
5803
c358e587
PE
5804 * buffer.c (buffer_count): Remove unused var.
5805
e78aecca
PE
5806 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5807 so that it's not optimized away.
5808 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5809 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5810 exported only to the debugger.
5811
e192d7d3 5812 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5813 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5814
92470028
PE
5815 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5816 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5817 was inaccessible from Lisp.
5818 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5819 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5820
244ed907
PE
5821 alloc.c: Import and export fewer symbols, and remove unused items.
5822 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5823 is defined.
5824 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5825 it's not optimized away by whole-program optimization.
5826 (message_enable_multibyte, free_misc): Remove.
5827 (catchlist, handlerlist, mark_backtrace):
5828 Declare only if BYTE_MARK_STACK.
5829 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5830 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5831 (message_enable_multibyte): Remove decl.
5832 (free_misc, interval_free_list, float_block, float_block_index):
5833 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5834 (cons_free_list, last_marked_index):
5835 Now static.
5836 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5837 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5838 (mark_backtrace): Define only if BYTE_MARK_STACK.
5839 * xdisp.c (message_enable_multibyte): Now static.
5840
61c2b50e 5841 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5842 This makes it easier for human readers (and static analyzers)
5843 to see whether these variables are used from other modules.
5844 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5845 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5846 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5847 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5848 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5849 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5850 * xmenu.c, xselect.c:
5851 Declare Q* vars static if they are not used in other modules.
5852 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5853 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5854 Remove decls of unexported vars.
5855 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5856
95c82688
PE
5857 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5858
16a97296
PE
5859 Make Emacs functions such as Fatom 'static' by default.
5860 This makes it easier for human readers (and static analyzers)
5861 to see whether these functions can be called from other modules.
5862 DEFUN now defines a static function. To make the function external
5863 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5864 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5865 (Finit_image_library):
16a97296
PE
5866 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5867 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5868 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5869 Remove decls, since these functions are now static.
5870 (Funintern, Fget_internal_run_time): New decls, since these functions
5871 were already external.
95c82688 5872
16a97296
PE
5873 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5874 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5875 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5876 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5877 * keyboard.c, keymap.c, lread.c:
5878 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5879 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5880 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5881 Mark functions with DEFUE instead of DEFUN,
5882 if they are used in other modules.
5883 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5884 decls for now-static functions.
5885 * buffer.h (Fdelete_overlay): Remove decl.
5886 * callproc.c (Fgetenv_internal): Mark as internal.
5887 * composite.c (Fremove_list_of_text_properties): Remove decl.
5888 (Fcomposition_get_gstring): New forward static decl.
5889 * composite.h (Fcomposite_get_gstring): Remove decl.
5890 * dired.c (Ffile_attributes): New forward static decl.
5891 * doc.c (Fdocumntation_property): New forward static decl.
5892 * eval.c (Ffetch_bytecode): New forward static decl.
5893 (Funintern): Remove extern decl; now in .h file where it belongs.
5894 * fileio.c (Fmake_symbolic_link): New forward static decl.
5895 * image.c (Finit_image_library): New forward static decl.
5896 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5897 * intervals.h (Fprevious_property_change):
5898 (Fremove_list_of_text_properties): Remove decls.
5899 * keyboard.c (Fthis_command_keys): Remove decl.
5900 (Fcommand_execute): New forward static decl.
5901 * keymap.c (Flookup_key): New forward static decl.
5902 (Fcopy_keymap): Now static.
5903 * keymap.h (Flookup_key): Remove decl.
5904 * process.c (Fget_process): New forward static decl.
5905 (Fprocess_datagram_address): Mark as internal.
5906 * syntax.c (Fsyntax_table_p): New forward static decl.
5907 (skip_chars): Remove duplicate decl.
5908 * textprop.c (Fprevious_property_change): New forward static decl.
5909 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5910 Now internal.
5911 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5912 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5913
785bbd42
PE
5914 * editfns.c (Fformat): Remove unreachable code.
5915
8b913b57
AS
59162011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5917
5918 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5919 change. (Bug#8496)
5920
a6744a35
EZ
59212011-04-13 Eli Zaretskii <eliz@gnu.org>
5922
5923 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5924 when at ZV. (Bug#8487)
5925
e7974947
AS
59262011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5927
baad03f0
AS
5928 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5929 (Bug#8437)
5930 * keyboard.c (parse_tool_bar_item): Likewise.
5931 * sound.c (sound_cleanup, alsa_close): Likewise.
5932 * termcap.c (tgetent): Likewise.
5933 * xfns.c (x_default_font_parameter): Likewise.
5934 * xsettings.c (read_and_apply_settings): Likewise.
5935
e7974947
AS
5936 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5937 (overrun_check_free): Protoize.
5938
28272684
PE
59392011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5940
5941 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5942 since callers should never pass a negative size.
5943 Change the signature to match that of plain 'read' and 'write'; see
5944 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5945 * lisp.h: Update prototypes of emacs_write and emacs_read.
5946
11997c76
EZ
59472011-04-11 Eli Zaretskii <eliz@gnu.org>
5948
5949 * xdisp.c (redisplay_window): Don't try to determine the character
5950 position of the scroll margin if the window start point w->startp
e896f03c 5951 is outside the buffer's accessible region. (Bug#8468)
11997c76 5952
8a2cbd72
EZ
59532011-04-10 Eli Zaretskii <eliz@gnu.org>
5954
5955 Fix write-region and its subroutines for buffers > 2GB.
5956 * fileio.c (a_write, e_write): Modify declaration of arguments and
5957 local variables to support buffers larger than 2GB.
5958 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5959
5960 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5961 argument, local variables, and return value.
5962
5963 * lisp.h: Update prototypes of emacs_write and emacs_read.
5964
5965 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5966
4073e537 59672011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5968
1ebfdcb6
PE
5969 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5970
b2ded58d
PE
5971 Fix more problems found by GCC 4.6.0's static checks.
5972
7d66342c
PE
5973 * xdisp.c (vmessage): Use a better test for character truncation.
5974
bbf47d44
PE
5975 * charset.c (load_charset_map): <, not <=, for optimization,
5976 and to avoid potential problems with integer overflow.
9248994d 5977 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5978 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5979 * editfns.c (Fformat): Likewise.
1e69125e 5980 * syntax.c (skip_chars): Likewise.
3befa583 5981
e3019616
PE
5982 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5983 This also lets GCC 4.6.0 generate slightly better loop code.
5984
becfa255
PE
5985 * callint.c (Fcall_interactively): <, not <=, for optimization.
5986 (Fcall_interactively): Count the number of arguments produced,
5987 not the number of arguments given. This is simpler and lets GCC
5988 4.6.0 generate slightly better code.
5989
dae0cd48
PE
5990 * ftfont.c: Distingish more carefully between FcChar8 and char.
5991 The previous code passed unsigned char * to a functions like
5992 strlen and xstrcasecmp that expect char *, which does not
5993 conform to the C standard.
5994 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5995 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5996 char * when the C standard requires it.
5997
76032d70
PE
5998 * keyboard.c (read_char): Remove unused var.
5999
eb3f1cc8
PE
6000 * eval.c: Port to Windows vsnprintf (Bug#8435).
6001 Include <limits.h>.
6002 (SIZE_MAX): Define if the headers do not.
6003 (verror): Do not give up if vsnprintf returns a negative count.
6004 Instead, grow the buffer. This ports to Windows vsnprintf, which
6005 does not conform to C99. Problem reported by Eli Zaretskii.
6006 Also, simplify the allocation scheme, by avoiding the need for
6007 calling realloc, and removing the ALLOCATED variable.
6008
70476b54
PE
6009 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6010
12020a9e
PE
6011 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6012 But keep the doprint source code for now, as we might revamp it
6013 and use it again (Bug#8435).
ea6c7ae6
PE
6014 * lisp.h (doprnt): Remove.
6015 * Makefile.in (base_obj): Remove doprnt.o.
6016 * deps.mk (doprnt.o): Remove.
6017
5fdb398c
PE
6018 error: Print 32- and 64-bit integers portably (Bug#8435).
6019 Without this change, on typical 64-bit hosts error ("...%d...", N)
6020 was used to print both 32- and 64-bit integers N, which relied on
6021 undefined behavior.
6022 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6023 New macro.
6024 * lisp.h (error, verror): Mark as printf-like functions.
6025 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6026 Report overflow in size calculations when allocating printf buffer.
6027 Do not truncate output string at its first null byte.
6028 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6029 Truncate the output at a character boundary, since vsnprintf does not
6030 do that.
6031 * charset.c (check_iso_charset_parameter): Convert internal
6032 character to string before calling 'error', since %c now has the
6033 printf meaning.
6034 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6035 overflow when computing char to be passed to 'error'. Do not
6036 pass Lisp_Object to 'error'; pass the integer instead.
6037 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6038 formatted with plain %d.
6039
b189fa66
PE
6040 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6041
bff87ef0
PE
6042 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6043
7e2cac20
PE
6044 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6045
ce4d90b5
PE
6046 * xterm.c (x_catch_errors): Remove duplicate declaration.
6047
266c9547
PE
6048 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6049
79c49ad2
PE
6050 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6051
368f4090
JM
60522011-04-10 Jim Meyering <meyering@redhat.com>
6053
6054 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6055 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6056 return ssize_t not "int", and use size_t as the buffer length.
6057 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6058 * gnutls.h: Update declarations.
6059 * process.c (read_process_output): Use ssize_t, to match.
6060 (send_process): Likewise.
6061
a32d4040
CY
60622011-04-09 Chong Yidong <cyd@stupidchicken.com>
6063
6064 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6065
8546720e 60662011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6067
04f2d78b
CB
6068 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6069 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6070
8546720e
GM
6071 * xterm.c (handle_one_xevent):
6072 * xmenu.c (create_and_show_popup_menu):
6073 * xselect.c (x_decline_selection_request)
6074 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6075
0a2f5c1a 60762011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6077
6078 Fix some uses of `int' instead of EMACS_INT.
6079 * search.c (string_match_1, fast_string_match)
6080 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6081 (scan_buffer, find_next_newline_no_quit)
6082 (find_before_next_newline, search_command, Freplace_match)
6083 (Fmatch_data): Make some `int' variables be EMACS_INT.
6084
6085 * xdisp.c (display_count_lines): 3rd argument and return value now
6086 EMACS_INT. All callers changed.
6087 (pint2hrstr): Last argument is now EMACS_INT.
6088
6089 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6090 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6091 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6092 (decode_coding_utf_16, decode_coding_emacs_mule)
6093 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6094 (decode_coding_ccl, decode_coding_charset)
6095 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6096 (decode_coding_iso_2022, decode_coding_emacs_mule)
6097 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6098 <char_offset, last_offset>: Declare EMACS_INT.
6099 (encode_coding_utf_8, encode_coding_utf_16)
6100 (encode_coding_emacs_mule, encode_invocation_designation)
6101 (encode_designation_at_bol, encode_coding_iso_2022)
6102 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6103 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6104 Declare EMACS_INT.
6105 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6106 (encode_invocation_designation): Last argument P_NCHARS is now
6107 EMACS_INT.
6108 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6109 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6110
6111 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6112 All users changed.
6113
6114 * ccl.c (Fccl_execute_on_string): Declare some variables
6115 EMACS_INT.
6116
8546720e 61172011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6118
6119 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6120
4e19a977
CS
61212011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6122
6123 * process.c (Fformat_network_address): Doc fix.
6124
87302331
R
61252011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6126
6127 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6128
cbb59342
CY
61292011-04-08 Chong Yidong <cyd@stupidchicken.com>
6130
6131 * keyboard.c (read_char): Call Lisp function help-form-show,
6132 instead of using internal_with_output_to_temp_buffer.
6133 (Qhelp_form_show): New var.
e0d38eeb 6134 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6135
6136 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6137
6138 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6139
e67a13ab
CY
61402011-04-06 Chong Yidong <cyd@stupidchicken.com>
6141
04f2d78b
CB
6142 * process.c (Flist_processes): Remove to Lisp.
6143 (list_processes_1): Delete.
e67a13ab 6144
973f782d
EZ
61452011-04-06 Eli Zaretskii <eliz@gnu.org>
6146
7c106b1e
EZ
6147 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6148
973f782d
EZ
6149 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6150
41cf7d1a 61512011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6152
ca23cc88
PE
6153 Fix more problems found by GCC 4.6.0's static checks.
6154
f390e2d5
PE
6155 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6156
42eea0d0
PE
6157 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6158
b69769da 6159 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6160
f9541e84
PE
6161 * xdisp.c (vmessage): Mark as a printf-like function.
6162
13841b55
PE
6163 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6164
c136c10f
PE
6165 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6166
5e2d4a30
PE
6167 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6168 printf-like functions.
6169 (tiff_load): Add casts to remove these marks before passing them
6170 to system-supplied API.
6171
583f48b9
PE
6172 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6173
b25d760e
PE
6174 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6175 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6176 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6177 directly, rather than having caller test rule sign. This avoids
6178 some unnecessary tests.
6179 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6180 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6181 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6182
bc7b6697 6183 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6184 (xfont_open): Avoid unnecessary tests.
bc7b6697 6185
27ccc379
PE
6186 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6187
dcd5c89a
PE
6188 * composite.h, composite.c (composition_gstring_put_cache):
6189 Use EMACS_INT, not int, for length.
6190
b13a45c6
PE
6191 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6192 breaking out part of COMPOSITION_DECODE_RULE.
6193 (COMPOSITION_DECODE_RULE): Use it.
6194 * composite.c (get_composition_id): Remove unused local vars,
6195 by using the new macro.
6196
1e792e4d
PE
6197 * textprop.c (set_text_properties_1): Change while to do-while,
6198 since the condition is always true at first.
6199
dc6c6455 6200 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6201 (interval_deletion_adjustment): Return unsigned value.
6202 All uses changed.
dc6c6455 6203
aba7731a
PE
6204 * process.c (list_processes_1, create_pty, read_process_output):
6205 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6206 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6207 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6208 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6209 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6210
fdfc4bf3
PE
6211 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6212
fca8fe46 6213 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6214 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6215
06a0259a 6216 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6217 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6218 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6219
e7b9e80f
PE
6220 * print.c (print_error_message): Avoid int overflow.
6221
56201685
PE
6222 * font.c (font_list_entities): Redo for clarity,
6223 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6224
78834453 6225 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6226 (font_score): Avoid potential overflow in diff calculation.
78834453 6227
0bc0b309 6228 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6229 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6230
e610eaca
PE
6231 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6232
b895abce
PE
6233 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6234 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6235 can always succeed if overflow has undefined behavior.
6236
1f1d9321 6237 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6238 (wordify): Omit three unnecessary tests.
1f1d9321 6239
c59478bc
PE
6240 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6241 All callers changed. This avoids the need for an unused var.
6242
79b73827
PE
6243 * casefiddle.c (casify_region): Remove var that is set but not used.
6244
a4db5dfe
PE
6245 * dired.c (file_name_completion): Remove var that is set but not used.
6246
43aae36e
PE
6247 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6248
2a47c44d 6249 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6250 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6251
a37c69bf
PE
6252 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6253 Check for integer overflow on size calculations.
6254
328ab8e7
PE
6255 * buffer.c (Fprevious_overlay_change): Remove var that is set
6256 but not used.
6257
e5a2a5cb
PE
6258 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6259 Remove vars that are set but not used.
8d84a6eb 6260 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6261 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6262
a60e5f68
PE
6263 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6264
f661cb61 6265 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6266 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6267
f0397f5a
PE
6268 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6269 that are set but not used.
6270
8664db06 6271 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6272 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6273
6abdaa4a
PE
6274 * xselect.c (x_get_local_selection, x_handle_property_notify):
6275 Remove vars that are set but not used.
6276
0ce7538d 6277 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6278 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6279
9ae848fc
PE
6280 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6281 Remove var that is set but not used.
0b918413
PE
6282 (scroll_bar_windows_size): Now size_t, not int.
6283 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6284 Check for overflow.
9ae848fc 6285
a5a62657
PE
6286 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6287 (map_tty_color) [!defined MSDOS]: Likewise.
6288
5c5cdd39
PE
6289 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6290
66ebf983
PE
6291 * coding.c: Remove vars that are set but not used.
6292 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6293 All callers changed.
6294 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6295 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6296 (decode_coding_charset): Remove vars that are set but not used.
6297
1be4d761
PE
6298 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6299 that is set but not used.
6300
47553fa8
PE
6301 * print.c (print_object): Remove var that is set but not used.
6302
1f7196bf 6303 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6304 The gnulib version avoids calling malloc in the usual case,
6305 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6306 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6307 * filelock.c (current_lock_owner): Likewise.
6308 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6309 * sysdep.c: Include allocator.h, careadlinkat.h.
6310 (emacs_no_realloc_allocator): New static constant.
6311 (emacs_readlink): New function.
fdb61804
PE
6312 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6313 ../lib/careadlinkat.h.
d1fdcab7 6314
f84c17c7
SM
63152011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6316
6317 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6318 first non-nil return value).
6319
ef3862ad
JD
63202011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6321
6322 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6323 if not defined (Bug#8403).
6324
376a7006
JB
63252011-04-02 Juanma Barranquero <lekktu@gmail.com>
6326
6327 * xdisp.c (display_count_lines): Remove parameter `start',
6328 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6329 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6330 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6331 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6332 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6333 and thereabouts. All callers changed.
6334 (get_per_char_metric): Remove parameter `f', unused since
6335 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6336
6ca3801d
JM
63372011-04-02 Jim Meyering <meyering@redhat.com>
6338
6339 do not dereference NULL upon failed strdup
6340 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6341 (ns_get_family): Likewise.
6342
d8e2b5ba
JB
63432011-04-02 Juanma Barranquero <lekktu@gmail.com>
6344
6345 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6346
8c74fcbd
JD
63472011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6348
6349 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6350 later (Bug#8403).
6351
7200d79c
SM
63522011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6353
03408648 6354 Add lexical binding.
7200d79c 6355
03408648
SM
6356 * window.c (Ftemp_output_buffer_show): New fun.
6357 (Fsave_window_excursion):
6358 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6359
6360 * lread.c (lisp_file_lexically_bound_p): New function.
6361 (Fload): Bind Qlexical_binding.
6362 (readevalloop): Remove `evalfun' arg.
6363 Bind Qinternal_interpreter_environment.
6364 (Feval_buffer): Bind Qlexical_binding.
6365 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6366 Mark as dynamic.
6367 (syms_of_lread): Declare `lexical-binding'.
6368
6369 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6370
6371 * keyboard.c (eval_dyn): New fun.
6372 (menu_item_eval_property): Use it.
ca105506
SM
6373
6374 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6375
03408648
SM
6376 * fns.c (concat, mapcar1): Accept byte-code-functions.
6377
6378 * eval.c (Fsetq): Handle lexical vars.
6379 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6380 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6381 (FletX, Flet): Obey lexical binding.
6382 (Fcommandp): Handle closures.
6383 (Feval): New `lexical' arg.
6384 (eval_sub): New function extracted from Feval. Use it almost
6385 everywhere where Feval was used. Look up vars in lexical env.
6386 Handle closures.
6387 (Ffunctionp): Move from subr.el.
6388 (Ffuncall): Handle closures.
6389 (apply_lambda): Remove `eval_flags'.
6390 (funcall_lambda): Handle closures and new byte-code-functions.
6391 (Fspecial_variable_p): New function.
6392 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6393 but without exporting it to Lisp.
23aba0ea 6394
23aba0ea 6395 * doc.c (Fdocumentation, store_function_docstring):
03408648 6396 * data.c (Finteractive_form): Handle closures.
23aba0ea 6397
03408648
SM
6398 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6399 interactive spec.
ba83908c 6400
04f2d78b
CB
6401 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6402 New byte-codes.
03408648
SM
6403 (exec_byte_code): New function extracted from Fbyte_code to handle new
6404 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6405
03408648 6406 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6407
03408648 6408 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6409
e2abce01
JB
64102011-03-31 Juanma Barranquero <lekktu@gmail.com>
6411
6412 * xdisp.c (redisplay_internal): Fix prototype.
6413
63696a73 64142011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6415
63696a73 6416 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6417 (try_scrolling): Use it when setting scroll_limit.
6418 Limit scrolling to 100 screen lines.
63696a73
EZ
6419 (redisplay_window): Even when falling back on "recentering",
6420 position point in the window according to scroll-conservatively,
6421 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6422
6423 (try_scrolling): When point is above the window, allow searching
6424 as far as scroll_max, or one screenful, to compute vertical
6425 distance from PT to the scroll margin position. This prevents
6426 try_scrolling from unnecessarily failing when
6427 scroll-conservatively is set to a value slightly larger than the
6428 window height. Clean up the case of PT below the margin at bottom
6429 of window: scroll_max can no longer be INT_MAX. When aggressive
6430 scrolling is in use, don't let point enter the opposite scroll
6431 margin as result of the scroll.
6432 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6433 threshold of 100 lines for never-recentering scrolling.
6434
e4cc2dfc
JB
64352011-03-31 Juanma Barranquero <lekktu@gmail.com>
6436
6437 * dispextern.h (move_it_by_lines):
6438 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6439 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6440 (message_log_check_duplicate): Remove parameters `prev_bol' and
6441 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6442 (redisplay_internal): Remove parameter `preserve_echo_area',
6443 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6444
6445 * indent.c (Fvertical_motion):
6446 * window.c (window_scroll_pixel_based, Frecenter):
6447 Don't pass `need_y_p' to `move_it_by_lines'.
6448
1c470562
SM
64492011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6450
44f230aa
SM
6451 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6452 steal a few bits to be more compact.
6453 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6454 Remove unneeded casts.
6455
1c470562
SM
6456 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6457
888adce9
ZK
64582011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6459
6460 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6461 binding" message (bug#7967).
6462
f838ed7b
PE
64632011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6464
77861b95
PE
6465 Fix more problems found by GCC 4.6.0's static checks.
6466
de6dbc14
PE
6467 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6468 Remove unused local var.
6469
f838ed7b
PE
6470 * editfns.c (Fmessage_box): Remove unused local var.
6471
792c7b2b
PE
6472 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6473 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6474 Omit unused local vars.
c499e557 6475 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6476 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6477 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6478 Omit unused local var.
6479
ba0165e1
PE
6480 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6481 Don't assume string length fits in int.
32ad8845 6482 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6483 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6484
3c59b4c9
PE
6485 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6486 instead of alloca (Bug#8344).
6487
a3eed478 6488 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6489 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6490
eb4d412d
PE
6491 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6492
1658b401
PE
6493 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6494 concerns.
6495
6496 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6497
6498 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6499
9a2c6e05
PE
6500 * keyboard.c (syms_of_keyboard): Use the same style as later
6501 in this function when indexing through an array. This also
6502 works around GCC bug 48267.
6503
03d0a109
PE
6504 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6505
44f730c8
PE
6506 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6507
fe75f926
PE
6508 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6509 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6510
ffa8c828
PE
6511 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6512 This avoids undefined behavior on integer overflow, and is a bit
6513 more convenient anyway since it is compared to a size_t variable.
6514
c5101a77
PE
6515 Variadic C functions now count arguments with size_t, not int.
6516 This avoids an unnecessary limitation on 64-bit machines, which
6517 caused (substring ...) to crash on large vectors (Bug#8344).
6518 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6519 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6520 All variadic functions and their callers changed accordingly.
c5101a77
PE
6521 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6522 * data.c (arith_driver, float_arith_driver): Likewise.
6523 * editfns.c (general_insert_function): Likewise.
6524 * eval.c (struct backtrace.nargs, interactive_p)
6525 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6526 (funcall_lambda, mark_backtrace): Likewise.
6527 * fns.c (concat): Likewise.
6528 * frame.c (x_set_frame_parameters): Likewise.
6529 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6530 0 if not found, not -1. All callers changed.
6531
dd3f25f7
PE
6532 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6533 (stack_copy_size): Now size_t, not int.
6534 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6535
461c2ab9
JB
65362011-03-28 Juanma Barranquero <lekktu@gmail.com>
6537
6538 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6539 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6540 All callers changed.
6541
6542 * lisp.h (multibyte_char_to_unibyte):
6543 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6544 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6545 * character.h (CHAR_TO_BYTE8):
6546 * cmds.c (internal_self_insert):
6547 * editfns.c (general_insert_function):
6548 * keymap.c (push_key_description):
6549 * search.c (Freplace_match):
6550 * xdisp.c (message_dolog, set_message_1): All callers changed.
6551
f6d62986
SM
65522011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6553
6554 * keyboard.c (safe_run_hook_funcall): New function.
6555 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6556 don't set the hook to nil, but remove the offending function instead.
6557 (Qcommand_hook_internal): Remove, unused.
6558 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6559 Vcommand_hook_internal.
6560
6561 * eval.c (enum run_hooks_condition): Remove.
6562 (funcall_nil, funcall_not): New functions.
6563 (run_hook_with_args): Call each function through a `funcall' argument.
6564 Remove `cond' argument, now redundant.
6565 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6566 (Frun_hook_with_args_until_failure): Adjust accordingly.
6567 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6568
1db5b1ad
JB
65692011-03-28 Juanma Barranquero <lekktu@gmail.com>
6570
6571 * dispextern.h (string_buffer_position): Remove declaration.
6572
6573 * print.c (strout): Remove parameter `multibyte', unused since
6574 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6575
6576 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6577 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6578 All callers changed.
6579
6580 * w32.c (_wsa_errlist): Use braces for struct initializers.
6581
6582 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6583 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6584 All callers changed.
6585 (string_buffer_position): Likewise. Also, make static (it's never
6586 used outside xdisp.c).
6587 (cursor_row_p): Remove parameter `w', unused since
6588 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6589 (decode_mode_spec): Remove parameter `precision', introduced during
6590 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6591 All callers changed.
6592
5ffb62aa
JD
65932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6594
6595 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6596
461c2ab9 65972011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6598
6599 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6600 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6601 (ns_update_auto_hide_menu_bar): New functions.
6602 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6603 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6604 ns_constrain_all_frames.
6605 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6606 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6607
5c380ffb
JD
66082011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6609
6610 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6611
9af30bdf
GM
66122011-03-27 Glenn Morris <rgm@gnu.org>
6613
6614 * syssignal.h: Replace RETSIGTYPE with void.
6615 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6616 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6617 Replace SIGTYPE with void everywhere.
6618 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6619 * s/template.h (SIGTYPE): Remove commented out definition.
6620
e2abce01
JB
66212011-03-26 Eli Zaretskii <eliz@gnu.org>
6622
6623 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6624 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6625
f868cd8a
JB
66262011-03-26 Juanma Barranquero <lekktu@gmail.com>
6627
59eb0929
JB
6628 * w32.c (read_unc_volume): Use parameter `henum', instead of
6629 global variable `wget_enum_handle'.
6630
6631 * keymap.c (describe_vector): Remove parameters `indices' and
6632 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6633 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6634
f868cd8a
JB
6635 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6636
6637 * keyboard.c (timer_check): Remove parameter `do_it_now',
6638 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6639 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6640 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6641
6642 * keyboard.c (read_char):
6643 * w32menu.c (w32_menu_display_help):
6644 * xmenu.c (show_help_event, menu_help_callback):
6645 Adjust calls to `show_help_echo'.
6646
6647 * gtkutil.c (xg_maybe_add_timer):
6648 * keyboard.c (readable_events):
6649 * process.c (wait_reading_process_output):
6650 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6651
6652 * insdel.c (adjust_markers_gap_motion):
6653 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6654 (gap_left, gap_right): Don't call it.
6655
2ecf6fdb
CY
66562011-03-25 Chong Yidong <cyd@stupidchicken.com>
6657
6658 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6659 incurred during fontification.
6660
6b1f9ba4
JB
66612011-03-25 Juanma Barranquero <lekktu@gmail.com>
6662
6663 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6664 (DEFVAR_PER_BUFFER): Don't pass it.
6665
6666 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6667 (scrolling_window): Don't pass it.
6668
0f4a96b5
JB
66692011-03-25 Juanma Barranquero <lekktu@gmail.com>
6670
6671 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6672
6673 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6674 and `suffix'.
6675 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6676 of variables specific to SELinux and computation of `encoded_absname'.
6677
6678 * image.c (XPutPixel): Remove unused variable `height'.
6679
6680 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6681
6682 * unexw32.c (get_section_info): Remove unused variable `section'.
6683
6684 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6685 (system_process_attributes): Remove unused variable `sess'.
6686 (sys_read): Remove unused variable `err'.
6687
6688 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6689 (w32_wnd_proc): Remove unused variable `isdead'.
6690 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6691 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6692 (x_create_tip_frame): Remove unused variable `tem'.
6693
6694 * w32inevt.c (w32_console_read_socket):
6695 Remove unused variable `no_events'.
6696
6697 * w32term.c (x_draw_composite_glyph_string_foreground):
6698 Remove unused variable `width'.
6699
1149507c
JB
67002011-03-24 Juanma Barranquero <lekktu@gmail.com>
6701
6702 * w32term.c (x_set_glyph_string_clipping):
6703 Don't pass uninitialized region to CombineRgn.
6704
9c88f339
JB
67052011-03-23 Juanma Barranquero <lekktu@gmail.com>
6706
6707 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6708 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6709 (Fx_close_connection): Remove unused variable `i'.
6710
6711 * w32font.c (w32font_draw): Return number of glyphs.
6712 (w32font_open_internal): Remove unused variable `i'.
6713 (w32font_driver): Add missing initializer.
6714
6715 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6716 (fill_in_menu): Remove unused variable `items_added'.
6717
6718 * w32term.c (last_mouse_press_frame): Remove static global variable.
6719 (w32_clip_to_row): Remove unused variable `f'.
6720 (x_delete_terminal): Remove unused variable `i'.
6721
6722 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6723 (NOTHING): Remove unused static global variable.
6724 (uniscribe_check_otf): Remove unused variable `table'.
6725 (uniscribe_font_driver): Add missing initializers.
6726
dee091a3
JD
67272011-03-23 Julien Danjou <julien@danjou.info>
6728
6729 * term.c (Fsuspend_tty, Fresume_tty):
6730 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6731 * window.c (temp_output_buffer_show):
6732 * insdel.c (signal_before_change):
6733 * frame.c (Fhandle_switch_frame):
6734 * fileio.c (Fdo_auto_save):
6735 * emacs.c (Fkill_emacs):
6736 * editfns.c (save_excursion_restore):
6737 * cmds.c (internal_self_insert):
6738 * callint.c (Fcall_interactively):
6739 * buffer.c (Fkill_all_local_variables):
6740 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6741 Use Frun_hooks.
0f4a96b5 6742 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6743 unconditionnaly since it does the check itself.
6744
2c520ab5 67452011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6746
c9c49752
PE
6747 Fix more problems found by GCC 4.5.2's static checks.
6748
8abc3f12
PE
6749 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6750 the first time through the loop, since we know p0 < p1 then.
6751 This also avoids a gcc -Wstrict-overflow warning.
6752
a2d26660
PE
6753 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6754 leading to a memory leak, possible in functions like
6755 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6756 of objects (Bug#8318).
a2d26660 6757
916c72e9
PE
6758 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6759 that could (at least in theory) be that large.
6760
19ab8a18
PE
6761 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6762 This is less likely to overflow, and avoids undefined behavior if
6763 overflow does occur. All callers changed. Use strtoul to scan
6764 for the unsigned long integer.
b7cbbd6f
PE
6765 (pint2hrstr): Simplify and tune code slightly.
6766 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6767
f0641eff
PE
6768 * scroll.c (do_scrolling): Work around GCC bug 48228.
6769 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6770
7f650bb9
PE
6771 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6772 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6773 (validate_x_resource_name): Simplify count usage.
6774 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6775
37dd57d1
PE
6776 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6777 fail (Bug#8306).
81e56e61 6778
699979fc 6779 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6780
401bf9b4
PE
6781 * process.c (Fmake_network_process): Use socklen_t, not int,
6782 where POSIX says socklen_t is required in portable programs.
6783 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6784 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6785 (Fmake_network_process, server_accept_connection):
6786 (wait_reading_process_output, read_process_output):
6787 Likewise.
6788
b93aacde
PE
6789 * process.c: Rename or move locals to avoid shadowing.
6790 (list_processes_1, Fmake_network_process):
6791 (read_process_output_error_handler, exec_sentinel_error_handler):
6792 Rename or move locals.
4dc343ee 6793 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6794 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6795 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6796 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6797 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6798
af8a867c 6799 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6800 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6801 Include tparam.h instead, since it declares them.
af8a867c
PE
6802 * cm.h (PC): Remove extern decl; tparam.h now does this.
6803 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6804 * terminfo.c: Include tparam.h, to check interfaces.
6805 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6806 (tparam): Adjust signature to match interface in tparam.h;
6807 this removes some undefined behavior. Check that outstring and len
6808 are zero, which they always are with Emacs.
6809 * tparam.h (PC, BC, UP): New extern decls.
6810
0248044d 6811 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6812 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6813
8ff096c1 6814 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6815 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6816 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6817 (ftfont_list): Remove unused local.
49eaafba
PE
6818 (get_adstyle_property, ftfont_pattern_entity):
6819 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6820 Rename locals to avoid shadowing.
8ff096c1 6821
e2be39f6
PE
6822 * xfont.c (xfont_list_family): Mark var as initialized.
6823
c9735e30
PE
6824 * xml.c (make_dom): Now static.
6825
8f5201ae
PE
6826 * composite.c (composition_compute_stop_pos): Rename local to
6827 avoid shadowing.
b246f932
PE
6828 (composition_reseat_it): Remove unused locals.
6829 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6830 (composition_update_it): Mark var as initialized.
11b61122
PE
6831 (find_automatic_composition): Mark vars as initialized,
6832 with a FIXME (Bug#8290).
8f5201ae 6833
760fbc2c
PE
6834 character.h: Rename locals to avoid shadowing.
6835 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6836 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6837 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6838 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6839 to avoid shadowing.
6840
ff08eb85
PE
6841 * textprop.c (property_change_between_p): Remove; unused.
6842
fc7bf025
PE
6843 * intervals.c (interval_start_pos): Now static.
6844
235d7abc
PE
6845 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6846
44f230aa
SM
6847 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6848 Rename locals to avoid shadowing.
3e7d6594 6849
50060332
PE
6850 * sound.c (wav_play, au_play, Fplay_sound_internal):
6851 Fix pointer signedness.
d01f234b 6852 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6853 (wav_play): Initialize a variable to 0, to prevent undefined
6854 behavior (Bug#8278).
50060332 6855
c4fc4e30
PE
6856 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6857
918436ed
PE
6858 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6859
c939f91b
PE
6860 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6861 clobbering (Bug#8298).
b9c7f648
PE
6862 * sysdep.c (sys_subshell): Likewise.
6863 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6864
6bd8c144
PE
6865 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6866 This should get cleaned up, so that child_setup has the
6867 same signature on all platforms.
6868
7710357c 6869 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6870 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6871
c59da222
CY
68722011-03-22 Chong Yidong <cyd@stupidchicken.com>
6873
6874 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6875 not to be necessary, and produces flickering.
6876
66b87493
GM
68772011-03-20 Glenn Morris <rgm@gnu.org>
6878
6879 * config.in: Remove file.
6880
45b6f6d5
JB
68812011-03-20 Juanma Barranquero <lekktu@gmail.com>
6882
6883 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6884 are now in src/globals.h.
6885 (syms_of_minibuf): Remove spurious & from previous change.
6886
3ec03f7e
LL
68872011-03-20 Leo <sdl.web@gmail.com>
6888
6889 * minibuf.c (completing-read-function): New variable.
6890 (completing-read-default): Rename from completing-read.
6891 (completing-read): Call completing-read-function.
6892
b14e3e21
CY
68932011-03-19 Juanma Barranquero <lekktu@gmail.com>
6894
6895 * xfaces.c (Fx_load_color_file):
6896 Read color file from absolute filename (bug#8250).
6897
f2b726e6
JB
68982011-03-19 Juanma Barranquero <lekktu@gmail.com>
6899
6900 * makefile.w32-in: Update dependencies.
6901
09f6ff02
EZ
69022011-03-17 Eli Zaretskii <eliz@gnu.org>
6903
6904 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6905
29a6015a
PE
69062011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6907
a3a6c54e
PE
6908 Fix more problems found by GCC 4.5.2's static checks.
6909
b766f867
PE
6910 * process.c (make_serial_process_unwind, send_process_trap):
6911 (sigchld_handler): Now static.
6912
be02381c
PE
6913 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6914 That way, the code declares only the vars that it needs.
6915 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6916 * s/cygwin.h (PTY_ITERATION): Likewise.
6917 * s/darwin.h (PTY_ITERATION): Likewise.
6918 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6919
57048744
PE
6920 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6921 * process.c (allocate_pty): Don't declare stb unless it's needed.
6922
7914961c 6923 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6924 (CONSTANTLIM): Remove; unused.
6925 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6926 Define only if needed.
7914961c 6927
b3967b18
PE
6928 * unexelf.c (unexec): Name an expression,
6929 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6930 Use a different way to cause a compilation error if anyone uses
6931 n rather than nn, a way that does not involve shadowing.
73366a00 6932 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6933
29a6015a
PE
6934 * deps.mk (unexalpha.o): Remove; unused.
6935
43cfc33e 6936 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6937 * unexec.h: New file.
ce701a33
PE
6938 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6939 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6940 Depend on unexec.h.
6941 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6942 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6943 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6944 Change as necessary to match prototype in unexec.h.
ce701a33 6945
01f44d5a
PE
6946 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6947 shadowing.
4f63c6bb 6948 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6949
a6670b0b
PE
6950 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6951 Rename locals to avoid shadowing.
6952
cef2010d 6953 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6954 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6955
d4d7173a
PE
6956 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6957
f08b802a
PE
6958 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6959 warning when compiling print.c.
6960
3ddb0639
PE
6961 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6962 instead of using an uninitialized var.
5ad03b97 6963 (font_sort_entities): Mark var as initialized.
3ddb0639 6964
170a2692
PE
6965 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6966
e663c700
PE
6967 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6968 pointers to constants.
89bc529a 6969 (font_parse_fcname): Remove unused vars.
7b81e2d0 6970 (font_delete_unmatched): Now static.
ea838e10 6971 (font_get_spec): Remove; unused.
13a547c6
PE
6972 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6973 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6974 Rename or move locals to avoid shadowing.
e663c700 6975
2a80c887 6976 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6977 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6978
1384fa33 6979 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6980 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6981
8b2c52e9
PE
6982 * alloc.c (mark_backtrace): Move decl from here ...
6983 * lisp.h: ... to here, so that it can be checked.
6984
475545b5 6985 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6986 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6987 (lisp_indirect_variable): Name an expression,
6988 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6989 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6990
b1349114 6991 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6992 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6993 Use const pointer when appropriate.
b1349114 6994
a2928364
PE
6995 * lisp.h (get_system_name, get_operating_system_release):
6996 Move decls here, to check interfaces.
6997 * process.c (get_operating_system_release): Move decl to lisp.h.
6998 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6999 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7000 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7001 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7002 (Fformat_time_string, Fencode_time, Finsert_char):
7003 (Ftranslate_region_internal, Fformat):
7004 Rename or remove local vars to avoid shadowing.
9710023e 7005 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7006
a415e694
PE
7007 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7008 avoid shadowing.
7009
8ef4622d
PE
7010 * lisp.h (eassert): Check that the argument compiles, even if
7011 ENABLE_CHECKING is not defined.
7012
946f9a5b
PE
7013 * data.c (Findirect_variable): Name an expression, to avoid
7014 gcc -Wbad-function-cast warning.
112396d6 7015 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7016 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7017 (Fmake_variable_buffer_local, Fmake_local_variable):
7018 Mark variables as initialized.
52746918 7019 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7020
e5aab7e7 7021 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7022 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7023 Rename locals to avoid shadowing.
dff45157
PE
7024 (mark_stack): Move local variables into the #ifdef region where
7025 they're used.
7bc26fdb
PE
7026 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7027 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7028 needed otherwise.
7029 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7030 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7031 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7032
e5aab7e7
PE
7033 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7034 avoids undefined behavior in theory.
7035
4da60324
PE
7036 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7037
88043301
PE
7038 Use functions, not macros, for up- and down-casing (Bug#8254).
7039 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7040 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7041 to use the following functions instead of these macros.
7042 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7043 EMACS_INT, since callers assume the returned value fits in int.
7044 (upcase1): Likewise, for UPCASE_TABLE.
7045 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7046 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7047 the race-condition problem in the old DOWNCASE.
88043301 7048
19ed5445
PE
7049 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7050 Rename locals to avoid shadowing.
7051 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7052 (regex_compile, re_search_2, re_match_2_internal):
7053 Remove unused local vars.
952db0d7
PE
7054 (FREE_VAR): Rewrite so as not to use empty "else",
7055 which gcc can warn about.
da053e48 7056 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7057 (RETALLOC_IF): Define only if needed.
7058 (WORDCHAR_P): Likewise. This one is never needed, but is used
7059 only in a comment talking about a compiler bug, so put inside
7060 the #if 0 of that comment.
7061 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7062 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7063 Remove; unused.
19ed5445 7064
1f3561e4 7065 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7066 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7067 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7068
ded6f8f7
PE
7069 * search.c (simple_search): Remove unused var.
7070
dbd37a95
PE
7071 * dired.c (compile_pattern): Move decl from here ...
7072 * lisp.h: ... to here, so that it can be checked.
7073 (struct re_registers): New forward decl.
7074
7e47afad
PE
7075 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7076
85f24f61
PE
7077 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7078 All uses changed.
7079 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7080 Rename locals to avoid shadowing.
5671df8f 7081 (Fvertical_motion): Mark locals as initialized.
85f24f61 7082
181aa2be 7083 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7084 (casify_region): Mark local as initialized.
181aa2be 7085
930d429c
PE
7086 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7087
7082eac6
PE
7088 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7089 New macros, so that the caller can use some names other than
7090 gcpro1, gcpro2, etc.
7091 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7092 of the new macros.
7093 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7094 argument, for consistency with GCPRO2_VAR, etc: it is now the
7095 prefix of the variable, not the variable itself. All uses
7096 changed.
38b2c076
PE
7097 * dired.c (directory_files_internal, file_name_completion):
7098 Rename locals to avoid shadowing.
7099
15206ed9
PE
7100 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7101 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7102 dired.c's scmp function, had undefined behavior.
7103 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7104 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7105 * buffer.h: ... to here, because these macros use current_buffer,
7106 and the new implementation with inline functions needs to have
7107 current_buffer in scope now, rather than later when the macros
7108 are used.
7109 (downcase, upcase1): New static inline functions.
7110 (DOWNCASE, UPCASE1): Reimplement using these functions.
7111 This avoids undefined behavior in expressions like
7112 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7113 from race conditions in accessing the global variables
7114 case_temp1 and case_temp2.
7115 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7116 * lisp.h (case_temp1, case_temp2): Remove their decls.
7117 * character.h (ASCII_CHAR_P): Move from here ...
7118 * lisp.h: ... to here, so that the inline functions mentioned
7119 above can use them.
7120
4a6bea26
PE
7121 * dired.c (directory_files_internal_unwind): Now static.
7122
f14b7e14
PE
7123 * fileio.c (file_name_as_directory, directory_file_name):
7124 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7125 Now static.
2893f146
PE
7126 (file_name_as_directory): Use const pointers when appropriate.
7127 (Fexpand_file_name): Likewise. In particular, newdir might
7128 point at constant storage, so make it a const pointer.
fd4ead52 7129 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7130 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7131 signedness issues.
f839df0c
PE
7132 (Fset_file_times, Finsert_file_contents, auto_save_error):
7133 Rename locals to avoid shadowing.
f14b7e14 7134
5716756e 7135 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7136 (Ftry_completion, Fall_completions): Rename or remove locals
7137 to avoid shadowing.
5716756e 7138
b4c3046a
PE
7139 * marker.c (bytepos_to_charpos): Remove; unused.
7140
b45db522
PE
7141 * lisp.h (verify_bytepos, count_markers): New decls,
7142 so that gcc does not warn that these functions aren't declared.
7143
85876d07
PE
7144 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7145 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7146 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7147 (copy_text): Remove unused local var.
85876d07 7148
03d78a21 7149 * filelock.c (within_one_second): Now static.
b3dd38ab 7150 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7151
5df8f01b
PE
7152 * buffer.c (fix_overlays_before): Mark locals as initialized.
7153 (fix_start_end_in_overlays): Likewise. This function should be
7154 simplified by using pointers-to-pointers, but that's a different
7155 matter.
b1d876f1 7156 (switch_to_buffer_1): Now static.
8f54f30a
PE
7157 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7158 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7159
a70072c9 7160 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7161 Fix pointer signedness issue.
edced198
PE
7162 (sys_subshell): Mark local as volatile if checking for lint,
7163 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7164 (MAXPATHLEN): Define only if needed.
a70072c9 7165
a0977c44
PE
7166 * process.c (serial_open, serial_configure): Move decls from here ...
7167 * systty.h: ... to here, so that they can be checked.
7168
a884fdcc
PE
7169 * fns.c (get_random, seed_random): Move extern decls from here ...
7170 * lisp.h: ... to here, so that they can be checked.
7171
604efe86 7172 * sysdep.c (reset_io): Now static.
b8950c94 7173 (wait_for_termination_signal): Remove; unused.
604efe86 7174
38fc62d9
PE
7175 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7176 (copy_keymap_item, append_key, push_text_char_description):
7177 Now static.
1004a21a 7178 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7179 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7180 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7181 (describe_map_tree):
7182 Rename locals to avoid shadowing.
38fc62d9 7183
2f2650da
PE
7184 * keyboard.c: Declare functions static if they are not used elsewhere.
7185 (echo_char, echo_dash, cmd_error, top_level_2):
7186 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7187 (read_char, kbd_buffer_get_event, make_lispy_position):
7188 (make_lispy_event, make_lispy_movement, apply_modifiers):
7189 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7190 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7191 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7192 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7193 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7194
a053e86c 7195 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7196 (mark_kboards): Move decl here ...
7197 * alloc.c (mark_kboards): ... from here.
a053e86c 7198
4752793e
PE
7199 * lisp.h (force_auto_save_soon): New decl.
7200
74f10ca7 7201 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7202 (DEFINE_DUMMY_FUNCTION): New macro.
7203 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7204 Use it.
c03cd23f
PE
7205 (main): Add casts to avoid warnings
7206 if GCC considers string literals to be constants.
74f10ca7 7207
022e70d4
PE
7208 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7209
59d6fe83
PE
7210 * dbusbind.c: Pointer signedness fixes.
7211 (xd_signature, xd_append_arg, xd_initialize):
7212 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7213 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7214 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7215 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7216
78320123
PE
7217 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7218 if GCC considers string literals to be constants.
49cebcca 7219 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7220
35ac2a97
SM
72212011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7222
fb103ca9
SM
7223 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7224 (print_preprocess, print_object): New macro to fix last change.
7225
35ac2a97
SM
7226 * print.c (print_preprocess): Don't forget font objects.
7227
62973b41
JB
72282011-03-16 Juanma Barranquero <lekktu@gmail.com>
7229
7230 * emacs.c (USAGE3): Doc fixes.
7231
0e48bb22
AS
72322011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7233
7234 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7235 structure.
7236
7684e57b
JB
72372011-03-14 Juanma Barranquero <lekktu@gmail.com>
7238
7239 * lisp.h (VWindow_system, Qfile_name_history):
7240 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7241 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7242 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7243
7244 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7245 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7246
7247 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7248 * w32console.c (detect_input_pending, read_input_pending)
7249 (encode_terminal_code):
7250 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7251 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7252 (w32_system_caret_y, Qfile_name_history):
7253 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7254 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7255 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7256 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7257 * w32proc.c (Qlocal, report_file_error):
7258 * w32term.c (Vwindow_system, updating_frame):
7259 * w32uniscribe.c (initialized, uniscribe_font_driver):
7260 Remove unneeded extern declarations.
7261
2aa46d6c
CY
72622011-03-14 Chong Yidong <cyd@stupidchicken.com>
7263
c96bbc66 7264 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7265
cffc6f3b
CY
72662011-03-13 Chong Yidong <cyd@stupidchicken.com>
7267
7268 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7269 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7270 These macros can no longer be used for assignment.
7271
44f230aa
SM
7272 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7273 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7274 (record_buffer_markers, fetch_buffer_markers): New functions for
7275 recording and fetching special buffer markers.
7276 (set_buffer_internal_1, set_buffer_temp): Use them.
7277
7278 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7279
7280 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7281
7282 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7283 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7284
7285 * xdisp.c (hscroll_window_tree):
7286 (reconsider_clip_changes): Use PT instead of BUF_PT.
7287
d251f04b
EZ
72882011-03-13 Eli Zaretskii <eliz@gnu.org>
7289
7290 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7291 $(EMACS_ROOT)/lib/intprops.h.
7292
f0c77cd1
PE
72932011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7294
3eca4629
PE
7295 Fix more problems found by GCC 4.5.2's static checks.
7296
7c86ee98
PE
7297 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7298 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7299 (xg_free_frame_widgets): Make it clear that a local variable is
7300 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7301 (gdk_window_get_screen): Make it clear that this macro is needed
7302 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7303 (int_gtk_range_get_value): New function, which avoids a diagnostic
7304 from gcc -Wbad-function-cast.
7305 (xg_set_toolkit_scroll_bar_thumb): Use it.
7306 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7307 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7308 (get_utf8_string, xg_get_file_with_chooser):
7309 Rename locals to avoid shadowing.
7310 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7311
41729b81
PE
7312 * xgselect.c (xg_select): Remove unused var.
7313
f0c77cd1
PE
7314 * image.c (four_corners_best): Mark locals as initialized.
7315 (gif_load): Initialize transparent_p to zero (Bug#8238).
7316 Mark another local as initialized.
ec6cf4c6 7317 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7318
ce0ad53d 7319 * image.c (clear_image_cache): Now static.
d5d5a617 7320 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7321 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7322 (x_edge_detection): Remove unnecessary cast that
7323 gcc -Wbad-function-cast diagnoses.
2037898d 7324 (gif_load): Fix pointer signedness.
6ae141d6
PE
7325 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7326 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7327
33383987 73282011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7329
d32df629
PE
7330 Improve quality of tests for time stamp overflow.
7331 For example, without this patch (encode-time 0 0 0 1 1
7332 1152921504606846976) returns the obviously-bogus value (-948597
7333 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7334 reports time overflow. See
7335 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7336 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7337 * editfns.c: Include limits.h and intprops.h.
7338 (TIME_T_MIN, TIME_T_MAX): New macros.
7339 (time_overflow): Move earlier, to before first use.
7340 (hi_time, lo_time): New functions, for an accurate test for
7341 out-of-range times.
7342 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7343 (Fget_internal_run_time): Don't assume time_t fits in int.
7344 (make_time): Use list2 instead of Fcons twice.
7345 (Fdecode_time): More accurate test for out-of-range times.
7346 (check_tm_member): New function.
7347 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7348 (lisp_time_argument): Don't rely on undefined left-shift and
7349 right-shift behavior when checking for time stamp overflow.
8be6f318 7350
fe31d94c
PE
7351 * editfns.c (time_overflow): New function, refactoring common code.
7352 (Fformat_time_string, Fdecode_time, Fencode_time):
7353 (Fcurrent_time_string): Use it.
7354
8be6f318
PE
7355 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7356 * dired.c (make_time): Move to ...
7357 * editfns.c (make_time): ... here.
7358 * systime.h: Note the move.
7359
09d9db2c 73602011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7361
126bc0dc
YM
7362 * fringe.c (update_window_fringes): Remove unused variables.
7363
c47cbdfd
YM
7364 * unexmacosx.c (copy_data_segment): Also copy __got section.
7365 (Bug#8223)
7366
7ac80be9
EZ
73672011-03-12 Eli Zaretskii <eliz@gnu.org>
7368
c96bbc66 7369 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7370 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7371 Constify `char *' arguments and their references according to
7372 prototypes in tparam.h.
7373
ecb0f94d 7374 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7375
7ac80be9
EZ
7376 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7377 Adapt all references accordingly.
7378
7379 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7380
ef1fd07e
TT
73812011-03-11 Tom Tromey <tromey@redhat.com>
7382
7383 * buffer.c (syms_of_buffer): Remove obsolete comment.
7384
7ef4b50c
EZ
73852011-03-11 Eli Zaretskii <eliz@gnu.org>
7386
7387 * termhooks.h (encode_terminal_code): Declare prototype.
7388
7389 * msdos.c (encode_terminal_code): Don't declare prototype.
7390
7391 * term.c (encode_terminal_code): Now external again, used by
7392 w32console.c and msdos.c.
7393
44f230aa
SM
7394 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7395 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7396
4b1ec863 73972011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7398
1714f52b 7399 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7400
4b1ec863
PE
7401 * fringe.c (update_window_fringes): Mark locals as initialized
7402 (Bug#8227).
7403 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7404
524c7aa6
PE
7405 * alloc.c (mark_fringe_data): Move decl from here ...
7406 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7407 to check its interface.
7408 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7409
a5c0af81 7410 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7411 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7412 (fontset_font): Mark local as initialized.
a9a06e0b 7413 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7414
b4716021
PE
7415 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7416
811e9bac 7417 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7418 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7419 (x_own_selection, Fx_disown_selection_internal): Rename locals
7420 to avoid shadowing.
7421 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7422
7e3ab302
PE
7423 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7424 so that the caller can use some name other than gcpro1.
7425 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7426 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7427 (Fx_backspace_delete_keys_p):
7428 Use them to avoid shadowing, and rename vars to avoid shadowing.
7429 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7430 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7431 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7432 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7433 Remove unused locals.
7e3ab302
PE
7434 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7435 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7436 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7437 macros.
f78faa98 7438
e2b13473
PE
7439 * xterm.h (x_mouse_leave): New decl.
7440
77f23912
PE
7441 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7442 Remove unused functions.
cdf4ba58
PE
7443 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7444 (x_calc_absolute_position): Now static.
7411c686 7445 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7446 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7447 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7448 unless they are used.
38d0b34a
PE
7449 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7450 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7451 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7452 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7453 (x_error_catcher, x_connection_closed, x_error_handler):
7454 (x_error_quitter, xembed_send_message, x_iconify_frame):
7455 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7456 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7457 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7458
44f230aa
SM
7459 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7460 Rename or move locals to avoid shadowing.
6b463e58 7461 (tty_defined_color, merge_face_heights): Now static.
5967d051 7462 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7463 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7464 does not deduce is never used uninitialized.
73719eba
PE
7465 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7466 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7467
426994c3 7468 * terminal.c (store_terminal_param): Now static.
5489860b 7469
032f1620 7470 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7471 (set_frame_menubar): Remove unused local.
d4323972 7472 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7473 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7474 since they might point to immutable storage.
281585b0
PE
7475 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7476 since it's unused otherwise.
032f1620 7477
367c19e5 7478 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7479 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7480 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7481 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7482 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7483 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7484 does not deduce are never used uninitialized.
70739cbe 7485
07b48fa9
PE
7486 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7487
8868a238 7488 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7489 * window.c (window_loop, size_window):
7490 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7491
7e5cf297 7492 * window.c (display_buffer): Now static.
d6550a9f
PE
7493 (size_window): Mark variables that gcc -Wuninitialized
7494 does not deduce are never used uninitialized.
a586633d
PE
7495 * window.h (check_all_windows): New decl, to forestall
7496 gcc -Wmissing-prototypes diagnostic.
5b555da1 7497 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7498
f6095868
PE
7499 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7500 shadowing.
7501 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7502 Include <limits.h>.
7503 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7504 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7505 (load_charset_map): Mark variables that gcc -Wuninitialized
7506 does not deduce are never used uninitialized.
53df7c11 7507 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7508
f38b440c
PE
7509 * coding.c (coding_set_source, coding_set_destination):
7510 Use "else { /* comment */ }" rather than "else /* comment */;"
7511 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7512 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7513 a block, when the outer 'i' will do.
7514 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7515 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7516 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7517 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7518 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7519 Rename locals to avoid shadowing.
7520 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7521 * coding.c (emacs_mule_char, encode_invocation_designation):
7522 Now static, since they're not used elsewhere.
413bb2db 7523 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7524 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7525 (decode_coding_emacs_mule): Mark variables that gcc
7526 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7527 (detect_coding_iso_2022): Initialize a local variable that might
7528 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7529 this initialization is needed. (Bug#8211)
5f58e762
PE
7530 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7531 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7532 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7533 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7534 Remove unused macros.
f38b440c 7535
232b38b9 7536 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7537 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7538 * character.c (string_count_byte8): Likewise.
232b38b9 7539
fb90da1b
PE
7540 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7541 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7542
fb93dbc2
PE
7543 * chartab.c (copy_sub_char_table): Now static, since it's not used
7544 elsewhere.
5c156ace
PE
7545 (sub_char_table_ref_and_range, char_table_ref_and_range):
7546 Rename locals to avoid shadowing.
bbcd0949 7547 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7548
7d3b3862 7549 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7550 (BIDI_BOB): Remove unused macro.
7d3b3862 7551
6be7d3da
PE
7552 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7553 deduce are never used uninitialized.
c2ed9c8b 7554 * term.c (encode_terminal_code): Likewise.
6be7d3da 7555
75f8807f 7556 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7557
50938595
PE
7558 * tparam.h: New file.
7559 * term.c, tparam.h: Include it.
7560 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7561 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7562 Move these decls to tparam.h, and make them agree with what
7563 is actually in tparam.c. The previous trick of using incompatible
7564 decls in different modules does not conform to the C standard.
7565 All callers of tparam changed to use tparam's actual API.
7566 * tparam.c (tparam1, tparam, tgoto):
7567 Use const pointers where appropriate.
7568
fbceeba2
PE
7569 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7570 * cm.h (struct cm): Likewise.
7571 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7572 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7573 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7574 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7575 (turn_on_face, init_tty): Likewise.
7576 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7577
7f3f1250
PE
7578 * term.c (term_mouse_position): Rename local to avoid shadowing.
7579
e6ca6543
PE
7580 * alloc.c (mark_ttys): Move decl from here ...
7581 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7582
c40f8d15
AS
75832011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7584
7585 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7586
cfe0661d
JB
75872011-03-09 Juanma Barranquero <lekktu@gmail.com>
7588
7589 * search.c (compile_pattern_1): Remove argument regp, unused since
7590 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7591 (compile_pattern): Don't pass it.
7592
0afb4571
J
75932011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7594
7595 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7596 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7597 for ! HAVE_GTK3.
7598 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7599
7600 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7601
7602 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7603 gdk_window_get_screen, gdk_window_get_geometry,
7604 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7605 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7606 (xg_get_pixbuf_from_pixmap): New function.
7607 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7608 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7609 Call xg_get_pixbuf_from_pixmap instead of
7610 gdk_pixbuf_get_from_drawable.
7611 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7612 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7613 (xg_check_special_colors): Use GtkStyleContext and its functions
7614 for HAVE_GTK3.
7615 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7616 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7617 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7618 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7619 Call gtk_widget_get_preferred_size.
0afb4571
J
7620 (xg_frame_resized): gdk_window_get_geometry only takes 5
7621 parameters.
44f230aa
SM
7622 (xg_win_to_widget, xg_event_is_for_menubar):
7623 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7624 (xg_set_widget_bg): New function.
7625 (delete_cb): New function.
895009e1 7626 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7627 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7628 (xg_set_background_color): Call xg_set_widget_bg.
7629 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7630 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7631 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7632 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7633 if ! HAVE_GTK3.
7634 (update_frame_tool_bar): Call gtk_widget_hide.
7635 (xg_initialize): Use GDK_KEY_g.
7636
7637 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7638 if ! HAVE_GTK3
7639 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7640
7641 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7642 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7643 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7644
1c2cc4ef
JB
76452011-03-08 Juanma Barranquero <lekktu@gmail.com>
7646
7647 * w32xfns.c (select_palette): Check success of RealizePalette against
7648 GDI_ERROR, not zero.
7649
33383987 7650See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7651
7652;; Local Variables:
7653;; coding: utf-8
aac0c6e3
MR
7654;; End:
7655
33383987 7656 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7657
7658 This file is part of GNU Emacs.
7659
7660 GNU Emacs is free software: you can redistribute it and/or modify
7661 it under the terms of the GNU General Public License as published by
7662 the Free Software Foundation, either version 3 of the License, or
7663 (at your option) any later version.
7664
7665 GNU Emacs is distributed in the hope that it will be useful,
7666 but WITHOUT ANY WARRANTY; without even the implied warranty of
7667 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7668 GNU General Public License for more details.
7669
7670 You should have received a copy of the GNU General Public License
7671 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.