* buffer.c (buffer_count): Remove unused var.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
16a97296
PE
12011-04-11 Paul Eggert <eggert@cs.ucla.edu>
2
c358e587
PE
3 * buffer.c (buffer_count): Remove unused var.
4
e78aecca
PE
5 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6 so that it's not optimized away.
7 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9 exported only to the debugger.
10
e192d7d3
PE
11 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12 * atimer.h (run_all_atimers): Removed; not exported.
13
92470028
PE
14 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
15 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
16 was inaccessible from Lisp.
17 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
18 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
19
244ed907
PE
20 alloc.c: Import and export fewer symbols, and remove unused items.
21 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
22 is defined.
23 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
24 it's not optimized away by whole-program optimization.
25 (message_enable_multibyte, free_misc): Remove.
26 (catchlist, handlerlist, mark_backtrace):
27 Declare only if BYTE_MARK_STACK.
28 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
29 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
30 (message_enable_multibyte): Remove decl.
31 (free_misc, interval_free_list, float_block, float_block_index):
32 (n_float_blocks, float_free_list, cons_block, cons_block_index):
33 (cons_free_list, last_marked_index):
34 Now static.
35 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
36 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
37 (mark_backtrace): Define only if BYTE_MARK_STACK.
38 * xdisp.c (message_enable_multibyte): Now static.
39
955cbe7b
PE
40 Declare Lisp_Object Q* variables to be 'static' if not exproted.
41 This makes it easier for human readers (and static analyzers)
42 to see whether these variables are used from other modules.
43 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
44 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
45 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
46 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
47 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
48 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
49 * xmenu.c, xselect.c:
50 Declare Q* vars static if they are not used in other modules.
51 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
52 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
53 Remove decls of unexported vars.
54 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
55
95c82688
PE
56 * lisp.h (DEFINE_FUNC): Make sname 'static'.
57
16a97296
PE
58 Make Emacs functions such as Fatom 'static' by default.
59 This makes it easier for human readers (and static analyzers)
60 to see whether these functions can be called from other modules.
61 DEFUN now defines a static function. To make the function external
62 so that it can be used in other C modules, use the new macro DEFUE.
63 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
64 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
65 static function definition. Use DEFUE if you want an extern one.
66 (DEFUE, INFUN): New macros.
67 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
68 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
69 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
70 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
71 Remove decls, since these functions are now static.
72 (Funintern, Fget_internal_run_time): New decls, since these functions
73 were already external.
95c82688 74
16a97296
PE
75 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
76 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
77 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
78 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
79 * keyboard.c, keymap.c, lread.c:
80 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
81 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
82 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
83 Mark functions with DEFUE instead of DEFUN,
84 if they are used in other modules.
85 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
86 decls for now-static functions.
87 * buffer.h (Fdelete_overlay): Remove decl.
88 * callproc.c (Fgetenv_internal): Mark as internal.
89 * composite.c (Fremove_list_of_text_properties): Remove decl.
90 (Fcomposition_get_gstring): New forward static decl.
91 * composite.h (Fcomposite_get_gstring): Remove decl.
92 * dired.c (Ffile_attributes): New forward static decl.
93 * doc.c (Fdocumntation_property): New forward static decl.
94 * eval.c (Ffetch_bytecode): New forward static decl.
95 (Funintern): Remove extern decl; now in .h file where it belongs.
96 * fileio.c (Fmake_symbolic_link): New forward static decl.
97 * image.c (Finit_image_library): New forward static decl.
98 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
99 * intervals.h (Fprevious_property_change):
100 (Fremove_list_of_text_properties): Remove decls.
101 * keyboard.c (Fthis_command_keys): Remove decl.
102 (Fcommand_execute): New forward static decl.
103 * keymap.c (Flookup_key): New forward static decl.
104 (Fcopy_keymap): Now static.
105 * keymap.h (Flookup_key): Remove decl.
106 * process.c (Fget_process): New forward static decl.
107 (Fprocess_datagram_address): Mark as internal.
108 * syntax.c (Fsyntax_table_p): New forward static decl.
109 (skip_chars): Remove duplicate decl.
110 * textprop.c (Fprevious_property_change): New forward static decl.
111 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
112 Now internal.
113 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
114 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
115
785bbd42
PE
1162011-04-10 Paul Eggert <eggert@cs.ucla.edu>
117
118 * editfns.c (Fformat): Remove unreachable code.
119
4073e537 1202011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 121
b2ded58d
PE
122 Fix more problems found by GCC 4.6.0's static checks.
123
7d66342c
PE
124 * xdisp.c (vmessage): Use a better test for character truncation.
125
bbf47d44
PE
126 * charset.c (load_charset_map): <, not <=, for optimization,
127 and to avoid potential problems with integer overflow.
9248994d 128 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 129 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 130 * editfns.c (Fformat): Likewise.
1e69125e 131 * syntax.c (skip_chars): Likewise.
3befa583 132
e3019616
PE
133 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
134 This also lets GCC 4.6.0 generate slightly better loop code.
135
becfa255
PE
136 * callint.c (Fcall_interactively): <, not <=, for optimization.
137 (Fcall_interactively): Count the number of arguments produced,
138 not the number of arguments given. This is simpler and lets GCC
139 4.6.0 generate slightly better code.
140
dae0cd48
PE
141 * ftfont.c: Distingish more carefully between FcChar8 and char.
142 The previous code passed unsigned char * to a functions like
143 strlen and xstrcasecmp that expect char *, which does not
144 conform to the C standard.
145 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
146 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
147 char * when the C standard requires it.
148
76032d70
PE
149 * keyboard.c (read_char): Remove unused var.
150
eb3f1cc8
PE
151 * eval.c: Port to Windows vsnprintf (Bug#8435).
152 Include <limits.h>.
153 (SIZE_MAX): Define if the headers do not.
154 (verror): Do not give up if vsnprintf returns a negative count.
155 Instead, grow the buffer. This ports to Windows vsnprintf, which
156 does not conform to C99. Problem reported by Eli Zaretskii.
157 Also, simplify the allocation scheme, by avoiding the need for
158 calling realloc, and removing the ALLOCATED variable.
159
70476b54
PE
160 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
161
12020a9e
PE
162 Remove invocations of doprnt, as Emacs now uses vsnprintf.
163 But keep the doprint source code for now, as we might revamp it
164 and use it again (Bug#8435).
ea6c7ae6
PE
165 * lisp.h (doprnt): Remove.
166 * Makefile.in (base_obj): Remove doprnt.o.
167 * deps.mk (doprnt.o): Remove.
168
5fdb398c
PE
169 error: Print 32- and 64-bit integers portably (Bug#8435).
170 Without this change, on typical 64-bit hosts error ("...%d...", N)
171 was used to print both 32- and 64-bit integers N, which relied on
172 undefined behavior.
173 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
174 New macro.
175 * lisp.h (error, verror): Mark as printf-like functions.
176 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
177 Report overflow in size calculations when allocating printf buffer.
178 Do not truncate output string at its first null byte.
179 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
180 Truncate the output at a character boundary, since vsnprintf does not
181 do that.
182 * charset.c (check_iso_charset_parameter): Convert internal
183 character to string before calling 'error', since %c now has the
184 printf meaning.
185 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
186 overflow when computing char to be passed to 'error'. Do not
187 pass Lisp_Object to 'error'; pass the integer instead.
188 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
189 formatted with plain %d.
190
b189fa66
PE
191 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
192
bff87ef0
PE
193 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
194
7e2cac20
PE
195 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
196
ce4d90b5
PE
197 * xterm.c (x_catch_errors): Remove duplicate declaration.
198
266c9547
PE
199 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
200
79c49ad2
PE
201 * xdisp.c, lisp.h (message_nolog): Remove; unused.
202
368f4090
JM
2032011-04-10 Jim Meyering <meyering@redhat.com>
204
205 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
206 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
207 return ssize_t not "int", and use size_t as the buffer length.
208 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
209 * gnutls.h: Update declarations.
210 * process.c (read_process_output): Use ssize_t, to match.
211 (send_process): Likewise.
212
a32d4040
CY
2132011-04-09 Chong Yidong <cyd@stupidchicken.com>
214
215 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
216
8546720e 2172011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 218
8546720e
GM
219 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
220 unsigned char, to match FcChar8 type definition.
aac0c6e3 221
8546720e
GM
222 * xterm.c (handle_one_xevent):
223 * xmenu.c (create_and_show_popup_menu):
224 * xselect.c (x_decline_selection_request)
225 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 226
a53e2e89
EZ
2272011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
228
229 Fix some uses of `int' instead of EMACS_INT.
230 * search.c (string_match_1, fast_string_match)
231 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
232 (scan_buffer, find_next_newline_no_quit)
233 (find_before_next_newline, search_command, Freplace_match)
234 (Fmatch_data): Make some `int' variables be EMACS_INT.
235
236 * xdisp.c (display_count_lines): 3rd argument and return value now
237 EMACS_INT. All callers changed.
238 (pint2hrstr): Last argument is now EMACS_INT.
239
240 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
241 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
242 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
243 (decode_coding_utf_16, decode_coding_emacs_mule)
244 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
245 (decode_coding_ccl, decode_coding_charset)
246 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
247 (decode_coding_iso_2022, decode_coding_emacs_mule)
248 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
249 <char_offset, last_offset>: Declare EMACS_INT.
250 (encode_coding_utf_8, encode_coding_utf_16)
251 (encode_coding_emacs_mule, encode_invocation_designation)
252 (encode_designation_at_bol, encode_coding_iso_2022)
253 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
254 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
255 Declare EMACS_INT.
256 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
257 (encode_invocation_designation): Last argument P_NCHARS is now
258 EMACS_INT.
259 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
260 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
261
262 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
263 All users changed.
264
265 * ccl.c (Fccl_execute_on_string): Declare some variables
266 EMACS_INT.
267
8546720e 2682011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
269
270 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
271
4e19a977
CS
2722011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
273
274 * process.c (Fformat_network_address): Doc fix.
275
87302331
R
2762011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
277
278 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
279
cbb59342
CY
2802011-04-08 Chong Yidong <cyd@stupidchicken.com>
281
282 * keyboard.c (read_char): Call Lisp function help-form-show,
283 instead of using internal_with_output_to_temp_buffer.
284 (Qhelp_form_show): New var.
e0d38eeb 285 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
286
287 * print.c (internal_with_output_to_temp_buffer): Function deleted.
288
289 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
290
e67a13ab
CY
2912011-04-06 Chong Yidong <cyd@stupidchicken.com>
292
293 * process.c (Flist_processes): Removed to Lisp.
294 (list_processes_1): Deleted.
295
973f782d
EZ
2962011-04-06 Eli Zaretskii <eliz@gnu.org>
297
7c106b1e
EZ
298 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
299
973f782d
EZ
300 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
301
41cf7d1a 3022011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 303
ca23cc88
PE
304 Fix more problems found by GCC 4.6.0's static checks.
305
f390e2d5
PE
306 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
307
42eea0d0
PE
308 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
309
b69769da 310 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 311
f9541e84
PE
312 * xdisp.c (vmessage): Mark as a printf-like function.
313
13841b55
PE
314 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
315
c136c10f
PE
316 * sound.c (sound_warning): Don't crash if arg contains a printf format.
317
5e2d4a30
PE
318 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
319 printf-like functions.
320 (tiff_load): Add casts to remove these marks before passing them
321 to system-supplied API.
322
583f48b9
PE
323 * eval.c (Fsignal): Remove excess argument to 'fatal'.
324
b25d760e
PE
325 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
326 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
327 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
328 directly, rather than having caller test rule sign. This avoids
329 some unnecessary tests.
330 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
331 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
332 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 333
bc7b6697 334 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 335 (xfont_open): Avoid unnecessary tests.
bc7b6697 336
27ccc379
PE
337 * composite.c (composition_gstring_put_cache): Use unsigned integer.
338
dcd5c89a
PE
339 * composite.h, composite.c (composition_gstring_put_cache):
340 Use EMACS_INT, not int, for length.
341
b13a45c6
PE
342 * composite.h (COMPOSITION_DECODE_REFS): New macro,
343 breaking out part of COMPOSITION_DECODE_RULE.
344 (COMPOSITION_DECODE_RULE): Use it.
345 * composite.c (get_composition_id): Remove unused local vars,
346 by using the new macro.
347
1e792e4d
PE
348 * textprop.c (set_text_properties_1): Change while to do-while,
349 since the condition is always true at first.
350
dc6c6455 351 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
352 (interval_deletion_adjustment): Return unsigned value.
353 All uses changed.
dc6c6455 354
aba7731a
PE
355 * process.c (list_processes_1, create_pty, read_process_output):
356 (exec_sentinel): Remove vars that were set but not used.
afd4052b 357 (create_pty): Remove unnecessary "volatile"s.
bc57d757 358 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 359 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 360 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 361
fdfc4bf3
PE
362 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
363
fca8fe46 364 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 365 (update_syntax_table): Use unsigned instead of int.
fca8fe46 366
06a0259a 367 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 368 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 369 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 370
e7b9e80f
PE
371 * print.c (print_error_message): Avoid int overflow.
372
56201685
PE
373 * font.c (font_list_entities): Redo for clarity,
374 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
375
78834453 376 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 377 (font_score): Avoid potential overflow in diff calculation.
78834453 378
0bc0b309 379 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 380 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 381
e610eaca
PE
382 * eval.c (funcall_lambda): Rename local to avoid shadowing.
383
b895abce
PE
384 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
385 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
386 can always succeed if overflow has undefined behavior.
387
1f1d9321 388 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 389 (wordify): Omit three unnecessary tests.
1f1d9321 390
c59478bc
PE
391 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
392 All callers changed. This avoids the need for an unused var.
393
79b73827
PE
394 * casefiddle.c (casify_region): Remove var that is set but not used.
395
a4db5dfe
PE
396 * dired.c (file_name_completion): Remove var that is set but not used.
397
43aae36e
PE
398 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
399
2a47c44d 400 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 401 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 402
a37c69bf
PE
403 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
404 Check for integer overflow on size calculations.
405
328ab8e7
PE
406 * buffer.c (Fprevious_overlay_change): Remove var that is set
407 but not used.
408
e5a2a5cb
PE
409 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
410 Remove vars that are set but not used.
8d84a6eb 411 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 412 (timer_check_2): Mark vars as initialized.
e5a2a5cb 413
a60e5f68
PE
414 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
415
f661cb61 416 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 417 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 418
f0397f5a
PE
419 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
420 that are set but not used.
421
8664db06 422 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 423 if XCreateBitmapFromData fails (Bug#8410).
8664db06 424
6abdaa4a
PE
425 * xselect.c (x_get_local_selection, x_handle_property_notify):
426 Remove vars that are set but not used.
427
0ce7538d 428 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 429 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 430
9ae848fc
PE
431 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
432 Remove var that is set but not used.
0b918413
PE
433 (scroll_bar_windows_size): Now size_t, not int.
434 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
435 Check for overflow.
9ae848fc 436
a5a62657
PE
437 * xfaces.c (realize_named_face): Remove vars that are set but not used.
438 (map_tty_color) [!defined MSDOS]: Likewise.
439
5c5cdd39
PE
440 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
441
66ebf983
PE
442 * coding.c: Remove vars that are set but not used.
443 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
444 All callers changed.
445 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
446 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
447 (decode_coding_charset): Remove vars that are set but not used.
448
1be4d761
PE
449 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
450 that is set but not used.
451
47553fa8
PE
452 * print.c (print_object): Remove var that is set but not used.
453
1f7196bf 454 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
455 The gnulib version avoids calling malloc in the usual case,
456 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
457 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
458 * filelock.c (current_lock_owner): Likewise.
459 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
460 * sysdep.c: Include allocator.h, careadlinkat.h.
461 (emacs_no_realloc_allocator): New static constant.
462 (emacs_readlink): New function.
fdb61804
PE
463 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
464 ../lib/careadlinkat.h.
d1fdcab7 465
f84c17c7
SM
4662011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
467
468 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
469 first non-nil return value).
470
ef3862ad
JD
4712011-04-03 Jan Djärv <jan.h.d@swipnet.se>
472
473 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
474 if not defined (Bug#8403).
475
376a7006
JB
4762011-04-02 Juanma Barranquero <lekktu@gmail.com>
477
478 * xdisp.c (display_count_lines): Remove parameter `start',
479 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
480 (get_char_face_and_encoding): Remove parameter `multibyte_p',
481 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
482 (fill_stretch_glyph_string): Remove parameters `row' and `area',
483 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
484 and thereabouts. All callers changed.
485 (get_per_char_metric): Remove parameter `f', unused since
486 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
487
6ca3801d
JM
4882011-04-02 Jim Meyering <meyering@redhat.com>
489
490 do not dereference NULL upon failed strdup
491 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
492 (ns_get_family): Likewise.
493
d8e2b5ba
JB
4942011-04-02 Juanma Barranquero <lekktu@gmail.com>
495
496 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
497
8c74fcbd
JD
4982011-04-02 Jan Djärv <jan.h.d@swipnet.se>
499
500 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
501 later (Bug#8403).
502
7200d79c
SM
5032011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
504
03408648 505 Add lexical binding.
7200d79c 506
03408648
SM
507 * window.c (Ftemp_output_buffer_show): New fun.
508 (Fsave_window_excursion):
509 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
510
511 * lread.c (lisp_file_lexically_bound_p): New function.
512 (Fload): Bind Qlexical_binding.
513 (readevalloop): Remove `evalfun' arg.
514 Bind Qinternal_interpreter_environment.
515 (Feval_buffer): Bind Qlexical_binding.
516 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
517 Mark as dynamic.
518 (syms_of_lread): Declare `lexical-binding'.
519
520 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
521
522 * keyboard.c (eval_dyn): New fun.
523 (menu_item_eval_property): Use it.
ca105506
SM
524
525 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 526
03408648
SM
527 * fns.c (concat, mapcar1): Accept byte-code-functions.
528
529 * eval.c (Fsetq): Handle lexical vars.
530 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
531 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
532 (FletX, Flet): Obey lexical binding.
533 (Fcommandp): Handle closures.
534 (Feval): New `lexical' arg.
535 (eval_sub): New function extracted from Feval. Use it almost
536 everywhere where Feval was used. Look up vars in lexical env.
537 Handle closures.
538 (Ffunctionp): Move from subr.el.
539 (Ffuncall): Handle closures.
540 (apply_lambda): Remove `eval_flags'.
541 (funcall_lambda): Handle closures and new byte-code-functions.
542 (Fspecial_variable_p): New function.
543 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
544 but without exporting it to Lisp.
23aba0ea 545
23aba0ea 546 * doc.c (Fdocumentation, store_function_docstring):
03408648 547 * data.c (Finteractive_form): Handle closures.
23aba0ea 548
03408648
SM
549 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
550 interactive spec.
ba83908c 551
03408648
SM
552 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
553 byte-codes.
554 (exec_byte_code): New function extracted from Fbyte_code to handle new
555 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 556
03408648 557 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 558
03408648 559 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 560
e2abce01
JB
5612011-03-31 Juanma Barranquero <lekktu@gmail.com>
562
563 * xdisp.c (redisplay_internal): Fix prototype.
564
63696a73 5652011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 566
63696a73
EZ
567 * xdisp.c (SCROLL_LIMIT): New macro.
568 (try_scrolling): Use it when setting scroll_limit. Limit
569 scrolling to 100 screen lines.
570 (redisplay_window): Even when falling back on "recentering",
571 position point in the window according to scroll-conservatively,
572 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
573
574 (try_scrolling): When point is above the window, allow searching
575 as far as scroll_max, or one screenful, to compute vertical
576 distance from PT to the scroll margin position. This prevents
577 try_scrolling from unnecessarily failing when
578 scroll-conservatively is set to a value slightly larger than the
579 window height. Clean up the case of PT below the margin at bottom
580 of window: scroll_max can no longer be INT_MAX. When aggressive
581 scrolling is in use, don't let point enter the opposite scroll
582 margin as result of the scroll.
583 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
584 threshold of 100 lines for never-recentering scrolling.
585
e4cc2dfc
JB
5862011-03-31 Juanma Barranquero <lekktu@gmail.com>
587
588 * dispextern.h (move_it_by_lines):
589 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
590 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
591 (message_log_check_duplicate): Remove parameters `prev_bol' and
592 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
593 (redisplay_internal): Remove parameter `preserve_echo_area',
594 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
595
596 * indent.c (Fvertical_motion):
597 * window.c (window_scroll_pixel_based, Frecenter):
598 Don't pass `need_y_p' to `move_it_by_lines'.
599
1c470562
SM
6002011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
601
44f230aa
SM
602 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
603 steal a few bits to be more compact.
604 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
605 Remove unneeded casts.
606
1c470562
SM
607 * bytecode.c (Fbyte_code): CAR and CDR can GC.
608
888adce9
ZK
6092011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
610
611 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
612 binding" message (bug#7967).
613
f838ed7b
PE
6142011-03-30 Paul Eggert <eggert@cs.ucla.edu>
615
77861b95
PE
616 Fix more problems found by GCC 4.6.0's static checks.
617
de6dbc14
PE
618 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
619 Remove unused local var.
620
f838ed7b
PE
621 * editfns.c (Fmessage_box): Remove unused local var.
622
792c7b2b
PE
623 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
624 (note_mode_line_or_margin_highlight, note_mouse_highlight):
625 Omit unused local vars.
c499e557 626 * window.c (shrink_windows): Omit unused local var.
b01a1c29 627 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
628 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
629 Omit unused local var.
630
ba0165e1
PE
631 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
632 Don't assume string length fits in int.
32ad8845 633 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 634 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 635
3c59b4c9
PE
636 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
637 instead of alloca (Bug#8344).
638
a3eed478 639 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 640 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 641
eb4d412d
PE
642 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
643
1658b401
PE
644 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
645 concerns.
646
647 * term.c (produce_glyphless_glyph): Remove unnecessary test.
648
649 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 650
9a2c6e05
PE
651 * keyboard.c (syms_of_keyboard): Use the same style as later
652 in this function when indexing through an array. This also
653 works around GCC bug 48267.
654
03d0a109
PE
655 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
656
44f730c8
PE
657 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
658
fe75f926
PE
659 * chartab.c (sub_char_table_ref_and_range): Redo for slight
660 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
661
ffa8c828
PE
662 * keyboard.c, keyboard.h (num_input_events): Now size_t.
663 This avoids undefined behavior on integer overflow, and is a bit
664 more convenient anyway since it is compared to a size_t variable.
665
c5101a77
PE
666 Variadic C functions now count arguments with size_t, not int.
667 This avoids an unnecessary limitation on 64-bit machines, which
668 caused (substring ...) to crash on large vectors (Bug#8344).
669 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
670 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 671 All variadic functions and their callers changed accordingly.
c5101a77
PE
672 (struct gcpro.nvars): Now size_t, not int. All uses changed.
673 * data.c (arith_driver, float_arith_driver): Likewise.
674 * editfns.c (general_insert_function): Likewise.
675 * eval.c (struct backtrace.nargs, interactive_p)
676 (internal_condition_case_n, run_hook_with_args, apply_lambda)
677 (funcall_lambda, mark_backtrace): Likewise.
678 * fns.c (concat): Likewise.
679 * frame.c (x_set_frame_parameters): Likewise.
680 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
681 0 if not found, not -1. All callers changed.
682
dd3f25f7
PE
683 * alloc.c (garbage_collect): Don't assume stack size fits in int.
684 (stack_copy_size): Now size_t, not int.
685 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
686
461c2ab9
JB
6872011-03-28 Juanma Barranquero <lekktu@gmail.com>
688
689 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
690 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
691 All callers changed.
692
693 * lisp.h (multibyte_char_to_unibyte):
694 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
695 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
696 * character.h (CHAR_TO_BYTE8):
697 * cmds.c (internal_self_insert):
698 * editfns.c (general_insert_function):
699 * keymap.c (push_key_description):
700 * search.c (Freplace_match):
701 * xdisp.c (message_dolog, set_message_1): All callers changed.
702
f6d62986
SM
7032011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
704
705 * keyboard.c (safe_run_hook_funcall): New function.
706 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
707 don't set the hook to nil, but remove the offending function instead.
708 (Qcommand_hook_internal): Remove, unused.
709 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
710 Vcommand_hook_internal.
711
712 * eval.c (enum run_hooks_condition): Remove.
713 (funcall_nil, funcall_not): New functions.
714 (run_hook_with_args): Call each function through a `funcall' argument.
715 Remove `cond' argument, now redundant.
716 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
717 (Frun_hook_with_args_until_failure): Adjust accordingly.
718 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
719
1db5b1ad
JB
7202011-03-28 Juanma Barranquero <lekktu@gmail.com>
721
722 * dispextern.h (string_buffer_position): Remove declaration.
723
724 * print.c (strout): Remove parameter `multibyte', unused since
725 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
726
727 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
728 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
729 All callers changed.
730
731 * w32.c (_wsa_errlist): Use braces for struct initializers.
732
733 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
734 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
735 All callers changed.
736 (string_buffer_position): Likewise. Also, make static (it's never
737 used outside xdisp.c).
738 (cursor_row_p): Remove parameter `w', unused since
739 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
740 (decode_mode_spec): Remove parameter `precision', introduced during
741 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
742 All callers changed.
743
5ffb62aa
JD
7442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
745
746 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
747
461c2ab9 7482011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
749
750 * nsterm.m (ns_menu_bar_is_hidden): New variable.
751 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
752 (ns_update_auto_hide_menu_bar): New functions.
753 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
754 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
755 ns_constrain_all_frames.
756 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
757 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
758
5c380ffb
JD
7592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
760
761 * nsmenu.m (runDialogAt): Remove argument to timer_check.
762
9af30bdf
GM
7632011-03-27 Glenn Morris <rgm@gnu.org>
764
765 * syssignal.h: Replace RETSIGTYPE with void.
766 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
767 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
768 Replace SIGTYPE with void everywhere.
769 * s/usg5-4-common.h (SIGTYPE): Remove definition.
770 * s/template.h (SIGTYPE): Remove commented out definition.
771
e2abce01
JB
7722011-03-26 Eli Zaretskii <eliz@gnu.org>
773
774 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
775 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
776
f868cd8a
JB
7772011-03-26 Juanma Barranquero <lekktu@gmail.com>
778
59eb0929
JB
779 * w32.c (read_unc_volume): Use parameter `henum', instead of
780 global variable `wget_enum_handle'.
781
782 * keymap.c (describe_vector): Remove parameters `indices' and
783 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
784 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
785
f868cd8a
JB
786 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
787
788 * keyboard.c (timer_check): Remove parameter `do_it_now',
789 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
790 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
791 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
792
793 * keyboard.c (read_char):
794 * w32menu.c (w32_menu_display_help):
795 * xmenu.c (show_help_event, menu_help_callback):
796 Adjust calls to `show_help_echo'.
797
798 * gtkutil.c (xg_maybe_add_timer):
799 * keyboard.c (readable_events):
800 * process.c (wait_reading_process_output):
801 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
802
803 * insdel.c (adjust_markers_gap_motion):
804 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
805 (gap_left, gap_right): Don't call it.
806
2ecf6fdb
CY
8072011-03-25 Chong Yidong <cyd@stupidchicken.com>
808
809 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
810 incurred during fontification.
811
6b1f9ba4
JB
8122011-03-25 Juanma Barranquero <lekktu@gmail.com>
813
814 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
815 (DEFVAR_PER_BUFFER): Don't pass it.
816
817 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
818 (scrolling_window): Don't pass it.
819
0f4a96b5
JB
8202011-03-25 Juanma Barranquero <lekktu@gmail.com>
821
822 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
823
824 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
825 and `suffix'.
826 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
827 of variables specific to SELinux and computation of `encoded_absname'.
828
829 * image.c (XPutPixel): Remove unused variable `height'.
830
831 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
832
833 * unexw32.c (get_section_info): Remove unused variable `section'.
834
835 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
836 (system_process_attributes): Remove unused variable `sess'.
837 (sys_read): Remove unused variable `err'.
838
839 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
840 (w32_wnd_proc): Remove unused variable `isdead'.
841 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
842 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
843 (x_create_tip_frame): Remove unused variable `tem'.
844
845 * w32inevt.c (w32_console_read_socket):
846 Remove unused variable `no_events'.
847
848 * w32term.c (x_draw_composite_glyph_string_foreground):
849 Remove unused variable `width'.
850
1149507c
JB
8512011-03-24 Juanma Barranquero <lekktu@gmail.com>
852
853 * w32term.c (x_set_glyph_string_clipping):
854 Don't pass uninitialized region to CombineRgn.
855
9c88f339
JB
8562011-03-23 Juanma Barranquero <lekktu@gmail.com>
857
858 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
859 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
860 (Fx_close_connection): Remove unused variable `i'.
861
862 * w32font.c (w32font_draw): Return number of glyphs.
863 (w32font_open_internal): Remove unused variable `i'.
864 (w32font_driver): Add missing initializer.
865
866 * w32menu.c (utf8to16): Remove unused variable `utf16'.
867 (fill_in_menu): Remove unused variable `items_added'.
868
869 * w32term.c (last_mouse_press_frame): Remove static global variable.
870 (w32_clip_to_row): Remove unused variable `f'.
871 (x_delete_terminal): Remove unused variable `i'.
872
873 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
874 (NOTHING): Remove unused static global variable.
875 (uniscribe_check_otf): Remove unused variable `table'.
876 (uniscribe_font_driver): Add missing initializers.
877
dee091a3
JD
8782011-03-23 Julien Danjou <julien@danjou.info>
879
880 * term.c (Fsuspend_tty, Fresume_tty):
881 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
882 * window.c (temp_output_buffer_show):
883 * insdel.c (signal_before_change):
884 * frame.c (Fhandle_switch_frame):
885 * fileio.c (Fdo_auto_save):
886 * emacs.c (Fkill_emacs):
887 * editfns.c (save_excursion_restore):
888 * cmds.c (internal_self_insert):
889 * callint.c (Fcall_interactively):
890 * buffer.c (Fkill_all_local_variables):
891 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
892 Use Frun_hooks.
0f4a96b5 893 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
894 unconditionnaly since it does the check itself.
895
2c520ab5 8962011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 897
c9c49752
PE
898 Fix more problems found by GCC 4.5.2's static checks.
899
8abc3f12
PE
900 * coding.c (encode_coding_raw_text): Avoid unnecessary test
901 the first time through the loop, since we know p0 < p1 then.
902 This also avoids a gcc -Wstrict-overflow warning.
903
a2d26660
PE
904 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
905 leading to a memory leak, possible in functions like
906 load_charset_map_from_file that can allocate an unbounded number
b12ef411 907 of objects (Bug#8318).
a2d26660 908
916c72e9
PE
909 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
910 that could (at least in theory) be that large.
911
19ab8a18
PE
912 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
913 This is less likely to overflow, and avoids undefined behavior if
914 overflow does occur. All callers changed. Use strtoul to scan
915 for the unsigned long integer.
b7cbbd6f
PE
916 (pint2hrstr): Simplify and tune code slightly.
917 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 918
f0641eff
PE
919 * scroll.c (do_scrolling): Work around GCC bug 48228.
920 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
921
7f650bb9
PE
922 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
923 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
924 (validate_x_resource_name): Simplify count usage.
925 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 926
37dd57d1
PE
927 * fileio.c (Fcopy_file): Report error if fchown or fchmod
928 fail (Bug#8306).
81e56e61 929
699979fc 930 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 931
401bf9b4
PE
932 * process.c (Fmake_network_process): Use socklen_t, not int,
933 where POSIX says socklen_t is required in portable programs.
934 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 935 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
936 (Fmake_network_process, server_accept_connection):
937 (wait_reading_process_output, read_process_output):
938 Likewise.
939
b93aacde
PE
940 * process.c: Rename or move locals to avoid shadowing.
941 (list_processes_1, Fmake_network_process):
942 (read_process_output_error_handler, exec_sentinel_error_handler):
943 Rename or move locals.
4dc343ee 944 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 945 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 946 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 947 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 948 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 949
af8a867c 950 Make tparam.h and terminfo.c consistent.
44f230aa
SM
951 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
952 Include tparam.h instead, since it declares them.
af8a867c
PE
953 * cm.h (PC): Remove extern decl; tparam.h now does this.
954 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
955 * terminfo.c: Include tparam.h, to check interfaces.
956 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
957 (tparam): Adjust signature to match interface in tparam.h;
958 this removes some undefined behavior. Check that outstring and len
959 are zero, which they always are with Emacs.
960 * tparam.h (PC, BC, UP): New extern decls.
961
0248044d 962 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 963 (xftfont_open): Rename locals to avoid shadowing.
0248044d 964
8ff096c1 965 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
966 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
967 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 968 (ftfont_list): Remove unused local.
49eaafba
PE
969 (get_adstyle_property, ftfont_pattern_entity):
970 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
971 Rename locals to avoid shadowing.
8ff096c1 972
e2be39f6
PE
973 * xfont.c (xfont_list_family): Mark var as initialized.
974
c9735e30
PE
975 * xml.c (make_dom): Now static.
976
8f5201ae
PE
977 * composite.c (composition_compute_stop_pos): Rename local to
978 avoid shadowing.
b246f932
PE
979 (composition_reseat_it): Remove unused locals.
980 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 981 (composition_update_it): Mark var as initialized.
11b61122
PE
982 (find_automatic_composition): Mark vars as initialized,
983 with a FIXME (Bug#8290).
8f5201ae 984
760fbc2c
PE
985 character.h: Rename locals to avoid shadowing.
986 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
987 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
988 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
989 (BUF_DEC_POS): Be more systematic about renaming local temporaries
990 to avoid shadowing.
991
ff08eb85
PE
992 * textprop.c (property_change_between_p): Remove; unused.
993
fc7bf025
PE
994 * intervals.c (interval_start_pos): Now static.
995
235d7abc
PE
996 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
997
44f230aa
SM
998 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
999 Rename locals to avoid shadowing.
3e7d6594 1000
50060332
PE
1001 * sound.c (wav_play, au_play, Fplay_sound_internal):
1002 Fix pointer signedness.
d01f234b 1003 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1004 (wav_play): Initialize a variable to 0, to prevent undefined
1005 behavior (Bug#8278).
50060332 1006
c4fc4e30
PE
1007 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1008
918436ed
PE
1009 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1010
c939f91b
PE
1011 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1012 clobbering (Bug#8298).
b9c7f648
PE
1013 * sysdep.c (sys_subshell): Likewise.
1014 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1015
6bd8c144
PE
1016 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1017 This should get cleaned up, so that child_setup has the
1018 same signature on all platforms.
1019
7710357c 1020 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1021 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1022
c59da222
CY
10232011-03-22 Chong Yidong <cyd@stupidchicken.com>
1024
1025 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1026 not to be necessary, and produces flickering.
1027
66b87493
GM
10282011-03-20 Glenn Morris <rgm@gnu.org>
1029
1030 * config.in: Remove file.
1031
45b6f6d5
JB
10322011-03-20 Juanma Barranquero <lekktu@gmail.com>
1033
1034 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1035 are now in src/globals.h.
1036 (syms_of_minibuf): Remove spurious & from previous change.
1037
3ec03f7e
LL
10382011-03-20 Leo <sdl.web@gmail.com>
1039
1040 * minibuf.c (completing-read-function): New variable.
1041 (completing-read-default): Rename from completing-read.
1042 (completing-read): Call completing-read-function.
1043
b14e3e21
CY
10442011-03-19 Juanma Barranquero <lekktu@gmail.com>
1045
1046 * xfaces.c (Fx_load_color_file):
1047 Read color file from absolute filename (bug#8250).
1048
f2b726e6
JB
10492011-03-19 Juanma Barranquero <lekktu@gmail.com>
1050
1051 * makefile.w32-in: Update dependencies.
1052
09f6ff02
EZ
10532011-03-17 Eli Zaretskii <eliz@gnu.org>
1054
1055 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1056
29a6015a
PE
10572011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1058
a3a6c54e
PE
1059 Fix more problems found by GCC 4.5.2's static checks.
1060
b766f867
PE
1061 * process.c (make_serial_process_unwind, send_process_trap):
1062 (sigchld_handler): Now static.
1063
be02381c
PE
1064 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1065 That way, the code declares only the vars that it needs.
1066 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1067 * s/cygwin.h (PTY_ITERATION): Likewise.
1068 * s/darwin.h (PTY_ITERATION): Likewise.
1069 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1070
57048744
PE
1071 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1072 * process.c (allocate_pty): Don't declare stb unless it's needed.
1073
7914961c 1074 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1075 (CONSTANTLIM): Remove; unused.
1076 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1077 Define only if needed.
7914961c 1078
b3967b18
PE
1079 * unexelf.c (unexec): Name an expression,
1080 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1081 Use a different way to cause a compilation error if anyone uses
1082 n rather than nn, a way that does not involve shadowing.
73366a00 1083 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1084
29a6015a
PE
1085 * deps.mk (unexalpha.o): Remove; unused.
1086
43cfc33e 1087 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1088 * unexec.h: New file.
ce701a33
PE
1089 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1090 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1091 Depend on unexec.h.
1092 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1093 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1094 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1095 Change as necessary to match prototype in unexec.h.
ce701a33 1096
01f44d5a
PE
1097 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1098 shadowing.
4f63c6bb 1099 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1100
a6670b0b
PE
1101 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1102 Rename locals to avoid shadowing.
1103
cef2010d 1104 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1105 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1106
d4d7173a
PE
1107 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1108
f08b802a
PE
1109 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1110 warning when compiling print.c.
1111
3ddb0639
PE
1112 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1113 instead of using an uninitialized var.
5ad03b97 1114 (font_sort_entities): Mark var as initialized.
3ddb0639 1115
170a2692
PE
1116 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1117
e663c700
PE
1118 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1119 pointers to constants.
89bc529a 1120 (font_parse_fcname): Remove unused vars.
7b81e2d0 1121 (font_delete_unmatched): Now static.
ea838e10 1122 (font_get_spec): Remove; unused.
13a547c6
PE
1123 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1124 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1125 Rename or move locals to avoid shadowing.
e663c700 1126
2a80c887 1127 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1128 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1129
1384fa33 1130 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1131 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1132
8b2c52e9
PE
1133 * alloc.c (mark_backtrace): Move decl from here ...
1134 * lisp.h: ... to here, so that it can be checked.
1135
475545b5 1136 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1137 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1138 (lisp_indirect_variable): Name an expression,
1139 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1140 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1141
b1349114 1142 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1143 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1144 Use const pointer when appropriate.
b1349114 1145
a2928364
PE
1146 * lisp.h (get_system_name, get_operating_system_release):
1147 Move decls here, to check interfaces.
1148 * process.c (get_operating_system_release): Move decl to lisp.h.
1149 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1150 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1151 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1152 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1153 (Fformat_time_string, Fencode_time, Finsert_char):
1154 (Ftranslate_region_internal, Fformat):
1155 Rename or remove local vars to avoid shadowing.
9710023e 1156 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1157
a415e694
PE
1158 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1159 avoid shadowing.
1160
8ef4622d
PE
1161 * lisp.h (eassert): Check that the argument compiles, even if
1162 ENABLE_CHECKING is not defined.
1163
946f9a5b
PE
1164 * data.c (Findirect_variable): Name an expression, to avoid
1165 gcc -Wbad-function-cast warning.
112396d6 1166 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1167 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1168 (Fmake_variable_buffer_local, Fmake_local_variable):
1169 Mark variables as initialized.
52746918 1170 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1171
e5aab7e7 1172 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1173 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1174 Rename locals to avoid shadowing.
dff45157
PE
1175 (mark_stack): Move local variables into the #ifdef region where
1176 they're used.
7bc26fdb
PE
1177 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1178 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1179 needed otherwise.
1180 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1181 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1182 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1183
e5aab7e7
PE
1184 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1185 avoids undefined behavior in theory.
1186
4da60324
PE
1187 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1188
88043301
PE
1189 Use functions, not macros, for up- and down-casing (Bug#8254).
1190 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1191 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1192 to use the following functions instead of these macros.
1193 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1194 EMACS_INT, since callers assume the returned value fits in int.
1195 (upcase1): Likewise, for UPCASE_TABLE.
1196 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1197 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1198 the race-condition problem in the old DOWNCASE.
88043301 1199
19ed5445
PE
1200 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1201 Rename locals to avoid shadowing.
1202 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1203 (regex_compile, re_search_2, re_match_2_internal):
1204 Remove unused local vars.
952db0d7
PE
1205 (FREE_VAR): Rewrite so as not to use empty "else",
1206 which gcc can warn about.
da053e48 1207 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1208 (RETALLOC_IF): Define only if needed.
1209 (WORDCHAR_P): Likewise. This one is never needed, but is used
1210 only in a comment talking about a compiler bug, so put inside
1211 the #if 0 of that comment.
1212 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1213 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1214 Remove; unused.
19ed5445 1215
1f3561e4 1216 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1217 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1218 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1219
ded6f8f7
PE
1220 * search.c (simple_search): Remove unused var.
1221
dbd37a95
PE
1222 * dired.c (compile_pattern): Move decl from here ...
1223 * lisp.h: ... to here, so that it can be checked.
1224 (struct re_registers): New forward decl.
1225
7e47afad
PE
1226 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1227
85f24f61
PE
1228 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1229 All uses changed.
1230 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1231 Rename locals to avoid shadowing.
5671df8f 1232 (Fvertical_motion): Mark locals as initialized.
85f24f61 1233
181aa2be 1234 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1235 (casify_region): Mark local as initialized.
181aa2be 1236
930d429c
PE
1237 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1238
7082eac6
PE
1239 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1240 New macros, so that the caller can use some names other than
1241 gcpro1, gcpro2, etc.
1242 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1243 of the new macros.
1244 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1245 argument, for consistency with GCPRO2_VAR, etc: it is now the
1246 prefix of the variable, not the variable itself. All uses
1247 changed.
38b2c076
PE
1248 * dired.c (directory_files_internal, file_name_completion):
1249 Rename locals to avoid shadowing.
1250
15206ed9
PE
1251 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1252 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1253 dired.c's scmp function, had undefined behavior.
1254 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1255 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1256 * buffer.h: ... to here, because these macros use current_buffer,
1257 and the new implementation with inline functions needs to have
1258 current_buffer in scope now, rather than later when the macros
1259 are used.
1260 (downcase, upcase1): New static inline functions.
1261 (DOWNCASE, UPCASE1): Reimplement using these functions.
1262 This avoids undefined behavior in expressions like
1263 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1264 from race conditions in accessing the global variables
1265 case_temp1 and case_temp2.
1266 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1267 * lisp.h (case_temp1, case_temp2): Remove their decls.
1268 * character.h (ASCII_CHAR_P): Move from here ...
1269 * lisp.h: ... to here, so that the inline functions mentioned
1270 above can use them.
1271
4a6bea26
PE
1272 * dired.c (directory_files_internal_unwind): Now static.
1273
f14b7e14
PE
1274 * fileio.c (file_name_as_directory, directory_file_name):
1275 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1276 Now static.
2893f146
PE
1277 (file_name_as_directory): Use const pointers when appropriate.
1278 (Fexpand_file_name): Likewise. In particular, newdir might
1279 point at constant storage, so make it a const pointer.
fd4ead52 1280 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1281 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1282 signedness issues.
f839df0c
PE
1283 (Fset_file_times, Finsert_file_contents, auto_save_error):
1284 Rename locals to avoid shadowing.
f14b7e14 1285
5716756e 1286 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1287 (Ftry_completion, Fall_completions): Rename or remove locals
1288 to avoid shadowing.
5716756e 1289
b4c3046a
PE
1290 * marker.c (bytepos_to_charpos): Remove; unused.
1291
b45db522
PE
1292 * lisp.h (verify_bytepos, count_markers): New decls,
1293 so that gcc does not warn that these functions aren't declared.
1294
85876d07
PE
1295 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1296 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1297 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1298 (copy_text): Remove unused local var.
85876d07 1299
03d78a21 1300 * filelock.c (within_one_second): Now static.
b3dd38ab 1301 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1302
5df8f01b
PE
1303 * buffer.c (fix_overlays_before): Mark locals as initialized.
1304 (fix_start_end_in_overlays): Likewise. This function should be
1305 simplified by using pointers-to-pointers, but that's a different
1306 matter.
b1d876f1 1307 (switch_to_buffer_1): Now static.
8f54f30a
PE
1308 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1309 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1310
a70072c9 1311 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1312 Fix pointer signedness issue.
edced198
PE
1313 (sys_subshell): Mark local as volatile if checking for lint,
1314 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1315 (MAXPATHLEN): Define only if needed.
a70072c9 1316
a0977c44
PE
1317 * process.c (serial_open, serial_configure): Move decls from here ...
1318 * systty.h: ... to here, so that they can be checked.
1319
a884fdcc
PE
1320 * fns.c (get_random, seed_random): Move extern decls from here ...
1321 * lisp.h: ... to here, so that they can be checked.
1322
604efe86 1323 * sysdep.c (reset_io): Now static.
b8950c94 1324 (wait_for_termination_signal): Remove; unused.
604efe86 1325
38fc62d9
PE
1326 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1327 (copy_keymap_item, append_key, push_text_char_description):
1328 Now static.
1004a21a 1329 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1330 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1331 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1332 (describe_map_tree):
1333 Rename locals to avoid shadowing.
38fc62d9 1334
2f2650da
PE
1335 * keyboard.c: Declare functions static if they are not used elsewhere.
1336 (echo_char, echo_dash, cmd_error, top_level_2):
1337 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1338 (read_char, kbd_buffer_get_event, make_lispy_position):
1339 (make_lispy_event, make_lispy_movement, apply_modifiers):
1340 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1341 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1342 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1343 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1344 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1345
a053e86c 1346 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1347 (mark_kboards): Move decl here ...
1348 * alloc.c (mark_kboards): ... from here.
a053e86c 1349
4752793e
PE
1350 * lisp.h (force_auto_save_soon): New decl.
1351
74f10ca7 1352 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1353 (DEFINE_DUMMY_FUNCTION): New macro.
1354 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1355 Use it.
c03cd23f
PE
1356 (main): Add casts to avoid warnings
1357 if GCC considers string literals to be constants.
74f10ca7 1358
022e70d4
PE
1359 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1360
59d6fe83
PE
1361 * dbusbind.c: Pointer signedness fixes.
1362 (xd_signature, xd_append_arg, xd_initialize):
1363 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1364 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1365 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1366 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1367
78320123
PE
1368 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1369 if GCC considers string literals to be constants.
49cebcca 1370 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1371
35ac2a97
SM
13722011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1373
fb103ca9
SM
1374 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1375 (print_preprocess, print_object): New macro to fix last change.
1376
35ac2a97
SM
1377 * print.c (print_preprocess): Don't forget font objects.
1378
62973b41
JB
13792011-03-16 Juanma Barranquero <lekktu@gmail.com>
1380
1381 * emacs.c (USAGE3): Doc fixes.
1382
0e48bb22
AS
13832011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1384
1385 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1386 structure.
1387
7684e57b
JB
13882011-03-14 Juanma Barranquero <lekktu@gmail.com>
1389
1390 * lisp.h (VWindow_system, Qfile_name_history):
1391 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1392 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1393 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1394
1395 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1396 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1397
1398 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1399 * w32console.c (detect_input_pending, read_input_pending)
1400 (encode_terminal_code):
1401 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1402 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1403 (w32_system_caret_y, Qfile_name_history):
1404 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1405 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1406 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1407 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1408 * w32proc.c (Qlocal, report_file_error):
1409 * w32term.c (Vwindow_system, updating_frame):
1410 * w32uniscribe.c (initialized, uniscribe_font_driver):
1411 Remove unneeded extern declarations.
1412
2aa46d6c
CY
14132011-03-14 Chong Yidong <cyd@stupidchicken.com>
1414
c96bbc66 1415 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1416
cffc6f3b
CY
14172011-03-13 Chong Yidong <cyd@stupidchicken.com>
1418
1419 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1420 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1421 These macros can no longer be used for assignment.
1422
44f230aa
SM
1423 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1424 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1425 (record_buffer_markers, fetch_buffer_markers): New functions for
1426 recording and fetching special buffer markers.
1427 (set_buffer_internal_1, set_buffer_temp): Use them.
1428
1429 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1430
1431 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1432
1433 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1434 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1435
1436 * xdisp.c (hscroll_window_tree):
1437 (reconsider_clip_changes): Use PT instead of BUF_PT.
1438
d251f04b
EZ
14392011-03-13 Eli Zaretskii <eliz@gnu.org>
1440
1441 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1442 $(EMACS_ROOT)/lib/intprops.h.
1443
f0c77cd1
PE
14442011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1445
3eca4629
PE
1446 Fix more problems found by GCC 4.5.2's static checks.
1447
7c86ee98
PE
1448 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1449 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1450 (xg_free_frame_widgets): Make it clear that a local variable is
1451 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1452 (gdk_window_get_screen): Make it clear that this macro is needed
1453 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1454 (int_gtk_range_get_value): New function, which avoids a diagnostic
1455 from gcc -Wbad-function-cast.
1456 (xg_set_toolkit_scroll_bar_thumb): Use it.
1457 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1458 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1459 (get_utf8_string, xg_get_file_with_chooser):
1460 Rename locals to avoid shadowing.
1461 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1462
41729b81
PE
1463 * xgselect.c (xg_select): Remove unused var.
1464
f0c77cd1
PE
1465 * image.c (four_corners_best): Mark locals as initialized.
1466 (gif_load): Initialize transparent_p to zero (Bug#8238).
1467 Mark another local as initialized.
ec6cf4c6 1468 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1469
ce0ad53d 1470 * image.c (clear_image_cache): Now static.
d5d5a617 1471 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1472 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1473 (x_edge_detection): Remove unnecessary cast that
1474 gcc -Wbad-function-cast diagnoses.
2037898d 1475 (gif_load): Fix pointer signedness.
6ae141d6
PE
1476 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1477 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1478
33383987 14792011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1480
d32df629
PE
1481 Improve quality of tests for time stamp overflow.
1482 For example, without this patch (encode-time 0 0 0 1 1
1483 1152921504606846976) returns the obviously-bogus value (-948597
1484 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1485 reports time overflow. See
1486 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1487 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1488 * editfns.c: Include limits.h and intprops.h.
1489 (TIME_T_MIN, TIME_T_MAX): New macros.
1490 (time_overflow): Move earlier, to before first use.
1491 (hi_time, lo_time): New functions, for an accurate test for
1492 out-of-range times.
1493 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1494 (Fget_internal_run_time): Don't assume time_t fits in int.
1495 (make_time): Use list2 instead of Fcons twice.
1496 (Fdecode_time): More accurate test for out-of-range times.
1497 (check_tm_member): New function.
1498 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1499 (lisp_time_argument): Don't rely on undefined left-shift and
1500 right-shift behavior when checking for time stamp overflow.
8be6f318 1501
fe31d94c
PE
1502 * editfns.c (time_overflow): New function, refactoring common code.
1503 (Fformat_time_string, Fdecode_time, Fencode_time):
1504 (Fcurrent_time_string): Use it.
1505
8be6f318
PE
1506 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1507 * dired.c (make_time): Move to ...
1508 * editfns.c (make_time): ... here.
1509 * systime.h: Note the move.
1510
09d9db2c 15112011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1512
126bc0dc
YM
1513 * fringe.c (update_window_fringes): Remove unused variables.
1514
c47cbdfd
YM
1515 * unexmacosx.c (copy_data_segment): Also copy __got section.
1516 (Bug#8223)
1517
7ac80be9
EZ
15182011-03-12 Eli Zaretskii <eliz@gnu.org>
1519
c96bbc66 1520 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1521 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1522 Constify `char *' arguments and their references according to
1523 prototypes in tparam.h.
1524
ecb0f94d 1525 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1526
7ac80be9
EZ
1527 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1528 Adapt all references accordingly.
1529
1530 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1531
ef1fd07e
TT
15322011-03-11 Tom Tromey <tromey@redhat.com>
1533
1534 * buffer.c (syms_of_buffer): Remove obsolete comment.
1535
7ef4b50c
EZ
15362011-03-11 Eli Zaretskii <eliz@gnu.org>
1537
1538 * termhooks.h (encode_terminal_code): Declare prototype.
1539
1540 * msdos.c (encode_terminal_code): Don't declare prototype.
1541
1542 * term.c (encode_terminal_code): Now external again, used by
1543 w32console.c and msdos.c.
1544
44f230aa
SM
1545 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1546 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1547
4b1ec863 15482011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1549
1714f52b 1550 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1551
4b1ec863
PE
1552 * fringe.c (update_window_fringes): Mark locals as initialized
1553 (Bug#8227).
1554 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1555
524c7aa6
PE
1556 * alloc.c (mark_fringe_data): Move decl from here ...
1557 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1558 to check its interface.
1559 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1560
a5c0af81 1561 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1562 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1563 (fontset_font): Mark local as initialized.
a9a06e0b 1564 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1565
b4716021
PE
1566 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1567
811e9bac 1568 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1569 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1570 (x_own_selection, Fx_disown_selection_internal): Rename locals
1571 to avoid shadowing.
1572 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1573
7e3ab302
PE
1574 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1575 so that the caller can use some name other than gcpro1.
1576 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1577 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1578 (Fx_backspace_delete_keys_p):
1579 Use them to avoid shadowing, and rename vars to avoid shadowing.
1580 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1581 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1582 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1583 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1584 Remove unused locals.
7e3ab302
PE
1585 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1586 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1587 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1588 macros.
f78faa98 1589
e2b13473
PE
1590 * xterm.h (x_mouse_leave): New decl.
1591
77f23912
PE
1592 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1593 Remove unused functions.
cdf4ba58
PE
1594 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1595 (x_calc_absolute_position): Now static.
7411c686 1596 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1597 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1598 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1599 unless they are used.
38d0b34a
PE
1600 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1601 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1602 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1603 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1604 (x_error_catcher, x_connection_closed, x_error_handler):
1605 (x_error_quitter, xembed_send_message, x_iconify_frame):
1606 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1607 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1608 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1609
44f230aa
SM
1610 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1611 Rename or move locals to avoid shadowing.
6b463e58 1612 (tty_defined_color, merge_face_heights): Now static.
5967d051 1613 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1614 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1615 does not deduce is never used uninitialized.
73719eba
PE
1616 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1617 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1618
426994c3 1619 * terminal.c (store_terminal_param): Now static.
5489860b 1620
032f1620 1621 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1622 (set_frame_menubar): Remove unused local.
d4323972 1623 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1624 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1625 since they might point to immutable storage.
281585b0
PE
1626 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1627 since it's unused otherwise.
032f1620 1628
367c19e5 1629 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1630 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1631 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1632 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1633 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1634 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1635 does not deduce are never used uninitialized.
70739cbe 1636
07b48fa9
PE
1637 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1638
8868a238 1639 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1640 * window.c (window_loop, size_window):
1641 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1642
7e5cf297 1643 * window.c (display_buffer): Now static.
d6550a9f
PE
1644 (size_window): Mark variables that gcc -Wuninitialized
1645 does not deduce are never used uninitialized.
a586633d
PE
1646 * window.h (check_all_windows): New decl, to forestall
1647 gcc -Wmissing-prototypes diagnostic.
5b555da1 1648 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1649
f6095868
PE
1650 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1651 shadowing.
1652 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1653 Include <limits.h>.
1654 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1655 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1656 (load_charset_map): Mark variables that gcc -Wuninitialized
1657 does not deduce are never used uninitialized.
53df7c11 1658 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1659
f38b440c
PE
1660 * coding.c (coding_set_source, coding_set_destination):
1661 Use "else { /* comment */ }" rather than "else /* comment */;"
1662 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1663 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1664 a block, when the outer 'i' will do.
1665 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1666 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1667 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1668 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1669 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1670 Rename locals to avoid shadowing.
1671 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1672 * coding.c (emacs_mule_char, encode_invocation_designation):
1673 Now static, since they're not used elsewhere.
413bb2db 1674 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1675 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1676 (decode_coding_emacs_mule): Mark variables that gcc
1677 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1678 (detect_coding_iso_2022): Initialize a local variable that might
1679 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1680 this initialization is needed. (Bug#8211)
5f58e762
PE
1681 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1682 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1683 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1684 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1685 Remove unused macros.
f38b440c 1686
232b38b9 1687 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1688 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1689 * character.c (string_count_byte8): Likewise.
232b38b9 1690
fb90da1b
PE
1691 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1692 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1693
fb93dbc2
PE
1694 * chartab.c (copy_sub_char_table): Now static, since it's not used
1695 elsewhere.
5c156ace
PE
1696 (sub_char_table_ref_and_range, char_table_ref_and_range):
1697 Rename locals to avoid shadowing.
bbcd0949 1698 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1699
7d3b3862 1700 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1701 (BIDI_BOB): Remove unused macro.
7d3b3862 1702
6be7d3da
PE
1703 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1704 deduce are never used uninitialized.
c2ed9c8b 1705 * term.c (encode_terminal_code): Likewise.
6be7d3da 1706
75f8807f 1707 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1708
50938595
PE
1709 * tparam.h: New file.
1710 * term.c, tparam.h: Include it.
1711 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1712 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1713 Move these decls to tparam.h, and make them agree with what
1714 is actually in tparam.c. The previous trick of using incompatible
1715 decls in different modules does not conform to the C standard.
1716 All callers of tparam changed to use tparam's actual API.
1717 * tparam.c (tparam1, tparam, tgoto):
1718 Use const pointers where appropriate.
1719
fbceeba2
PE
1720 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1721 * cm.h (struct cm): Likewise.
1722 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1723 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1724 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1725 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1726 (turn_on_face, init_tty): Likewise.
1727 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1728
7f3f1250
PE
1729 * term.c (term_mouse_position): Rename local to avoid shadowing.
1730
e6ca6543
PE
1731 * alloc.c (mark_ttys): Move decl from here ...
1732 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1733
c40f8d15
AS
17342011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1735
1736 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1737
cfe0661d
JB
17382011-03-09 Juanma Barranquero <lekktu@gmail.com>
1739
1740 * search.c (compile_pattern_1): Remove argument regp, unused since
1741 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1742 (compile_pattern): Don't pass it.
1743
0afb4571
J
17442011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1745
1746 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1747 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1748 for ! HAVE_GTK3.
1749 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1750
1751 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1752
1753 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1754 gdk_window_get_screen, gdk_window_get_geometry,
1755 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1756 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1757 (xg_get_pixbuf_from_pixmap): New function.
1758 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1759 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1760 Call xg_get_pixbuf_from_pixmap instead of
1761 gdk_pixbuf_get_from_drawable.
1762 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1763 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1764 (xg_check_special_colors): Use GtkStyleContext and its functions
1765 for HAVE_GTK3.
1766 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1767 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1768 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1769 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1770 Call gtk_widget_get_preferred_size.
0afb4571
J
1771 (xg_frame_resized): gdk_window_get_geometry only takes 5
1772 parameters.
44f230aa
SM
1773 (xg_win_to_widget, xg_event_is_for_menubar):
1774 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1775 (xg_set_widget_bg): New function.
1776 (delete_cb): New function.
1777 (xg_create_frame_widgets): connect delete-event to delete_cb.
1778 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1779 (xg_set_background_color): Call xg_set_widget_bg.
1780 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1781 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1782 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1783 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1784 if ! HAVE_GTK3.
1785 (update_frame_tool_bar): Call gtk_widget_hide.
1786 (xg_initialize): Use GDK_KEY_g.
1787
1788 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1789 if ! HAVE_GTK3
1790 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1791
1792 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1793 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1794 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1795
1c2cc4ef
JB
17962011-03-08 Juanma Barranquero <lekktu@gmail.com>
1797
1798 * w32xfns.c (select_palette): Check success of RealizePalette against
1799 GDI_ERROR, not zero.
1800
33383987 1801See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1802
1803;; Local Variables:
1804;; coding: utf-8
aac0c6e3
MR
1805;; End:
1806
33383987 1807 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1808
1809 This file is part of GNU Emacs.
1810
1811 GNU Emacs is free software: you can redistribute it and/or modify
1812 it under the terms of the GNU General Public License as published by
1813 the Free Software Foundation, either version 3 of the License, or
1814 (at your option) any later version.
1815
1816 GNU Emacs is distributed in the hope that it will be useful,
1817 but WITHOUT ANY WARRANTY; without even the implied warranty of
1818 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1819 GNU General Public License for more details.
1820
1821 You should have received a copy of the GNU General Public License
1822 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.