Turn on bidi-display-reordering by default.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4cc60b9b
EZ
12011-07-28 Eli Zaretskii <eliz@gnu.org>
2
3 * buffer.c (init_buffer_once, syms_of_buffer): Set
4 bidi-display-reordering to t by default.
5
476371c4
PE
62011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7
66606eea
PE
8 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9 Without this fix, if a signal arrives just after memory fills up,
10 'malloc' might be invoked reentrantly.
11
476371c4
PE
12 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
13 In other words, assume that every image size is allowed, on non-X
14 hosts. This assumption is probably wrong, but it lets Emacs compile.
15
f3fcc40d
AS
162011-07-28 Andreas Schwab <schwab@linux-m68k.org>
17
18 * regex.c (re_iswctype): Convert return values to boolean.
19
350c992f
EZ
202011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
21
22 * xdisp.c (compute_display_string_pos): Don't use cached display
23 string position if the buffer had its restriction changed.
24 (Bug#9184)
25
5266b4bb
PE
262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
27
28 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
29
2573a837 302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 31
41f55ccd 32 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 33
39e378da
PE
34 * bidi.c: Integer size and overflow fixes.
35 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
36 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
37 (bidi_cache_find_level_change, bidi_cache_ensure_space)
38 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
39 (bidi_find_other_level_edge):
40 Use ptrdiff_t instead of EMACS_INT where either will do.
41 This works better on 32-bit hosts configured --with-wide-int.
42 (bidi_cache_ensure_space): Check for size-calculation overflow.
43 Use % rather than repeated addition, for better worst-case speed.
44 Don't set bidi_cache_size until after xrealloc returns, because it
45 might not return.
46 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
47 (bidi_cache_ensure_space): Also check that the bidi cache size
48 does not exceed that of the largest Lisp string or buffer. See Eli
49 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 50
5e927815
PE
51 * alloc.c (__malloc_size_t): Remove.
52 All uses replaced by size_t. See Andreas Schwab's note
53 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
54
ca4aa935
PE
55 * image.c: Improve checking for integer overflow.
56 (check_image_size): Assume that f is nonnull, since
57 it is always nonnull in practice. This is one less thing to
58 worry about when checking for integer overflow later.
59 (x_check_image_size): New function, which checks for integer
60 overflow issues inside X.
61 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
62 This removes the need for a memory_full check.
63 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
64 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
65 (xbm_read_bitmap_data): Change locals back to 'int', since
66 their values must fit in 'int'.
67 (xpm_load_image, png_load, tiff_load):
68 Invoke x_create_x_image_and_pixmap earlier,
69 to avoid much needless work if the image is too large.
70 (tiff_load): Treat overly large images as if
71 x_create_x_image_and_pixmap failed, not as malloc failures.
72 (gs_load): Use x_check_image_size.
73
5f8f9cc2
PE
74 * gtkutil.c: Omit integer casts.
75 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
76 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
77
5adf60bc
PE
78 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
79
c8907a93
PE
80 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
81 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
82 would wrongly return t on a 64-bit host.
83
e3c25c68
PE
84 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
85 The plain *_OVERFLOW macros run afoul of GCC bug 49705
86 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
87 and therefore cause GCC to emit a bogus diagnostic in some cases.
88
3f791afe
PE
89 * image.c: Integer signedness and overflow and related fixes.
90 This is not an exhaustive set of fixes, but it's time to
91 record what I've got.
92 (lookup_pixel_color, check_image_size): Remove redundant decls.
93 (check_image_size): Don't assume that arbitrary EMACS_INT values
94 fit in 'int', or that arbitrary 'double' values fit in 'int'.
95 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
96 (tiff_load, imagemagick_load_image):
97 Check for overflow in size calculations.
98 (x_create_x_image_and_pixmap): Remove unnecessary test for
99 xmalloc returning NULL; that can't happen.
100 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
101 (xpm_color_bucket): Use better integer hashing function.
102 (xpm_cache_color): Don't possibly over-allocate memory.
103 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
104 (gif_memory_source):
105 Use ptrdiff_t, not int or size_t, to record sizes.
106 (png_load): Don't assume values greater than 2**31 fit in 'int'.
107 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
108 either works, as we prefer signed integers.
109 (tiff_read_from_memory, tiff_write_from_memory):
110 Return tsize_t, not size_t, since that's what the TIFF API wants.
111 (tiff_read_from_memory): Don't fail simply because the read would
112 go past EOF; instead, return a short read.
113 (tiff_load): Omit no-longer-needed casts.
114 (Fimagemagick_types): Don't assume size fits into 'int'.
115
3cc5a532
PE
116 Improve hashing quality when configured --with-wide-int.
117 * fns.c (hash_string): New function, taken from sxhash_string.
118 Do not discard information about ASCII character case; this
119 discarding is no longer needed.
120 (sxhash-string): Use it. Change sig to match it. Caller changed.
121 * lisp.h: Declare it.
122 * lread.c (hash_string): Remove, since we now use fns.c's version.
123 The fns.c version returns a wider integer if --with-wide-int is
124 specified, so this should help the quality of the hashing a bit.
125
b312a492
PE
126 * emacs.c: Integer overflow minor fix.
127 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
128 Define only if GNU_LINUX.
129 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
130
dfd153ae
PE
131 * dispnew.c: Integer signedness and overflow fixes.
132 Remove unnecessary forward decls, that were a maintenance hassle.
133 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
134 All uses changed.
135 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
136 (scrolling_window): Use ptrdiff_t, not int, for byte count.
137 (prepare_desired_row, line_draw_cost):
138 Use int, not unsigned, where either works.
139 (save_current_matrix, restore_current_matrix):
140 Use ptrdiff_t, not size_t, where either works.
141 (init_display): Check for overflow more accurately, and without
142 relying on undefined behavior.
143
a81d11a3
PE
144 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
145 Remove, replacing with the new symbols in lisp.h. All uses changed.
146 * fileio.c (make_temp_name):
147 * filelock.c (lock_file_1, lock_file):
148 * xdisp.c (message_dolog):
149 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
150 Use pMd etc. instead.
151 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
152 replacing the pWIDE etc. symbols removed from editfns.c.
153
3300e6fd
PE
154 * keyboard.h (num_input_events): Now uintmax_t.
155 This is (very slightly) less likely to mess up due to wraparound.
156 All uses changed.
157
fd05c7e9
PE
158 * buffer.c: Integer signedness fixes.
159 (alloc_buffer_text, enlarge_buffer_text):
160 Use ptrdiff_t rather than size_t when either will do, as we prefer
161 signed integers.
162
903fe15d
PE
163 * alloc.c: Integer signedness and overflow fixes.
164 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
165 (__malloc_size_t): Default to size_t, not to int.
166 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
167 (Fgarbage_collect, mark_object_loop_halt, mark_object):
168 Prefer ptrdiff_t to size_t when either would do, as we prefer
169 signed integers.
170 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
171 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
172 Now const. Initialize with values that are in range even if char
173 is signed.
174 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
175 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
176 These functions do the right thing with sizes > 2**32.
177 (check_depth): Now ptrdiff_t, not int.
178 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
179 Adjust to new way of storing sizes. Check for size overflow bugs
180 in rest of code.
181 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
182 slightly wrong anyway, as it missed one instance of
183 XMALLOC_OVERRUN_CHECK_OVERHEAD.
184 (refill_memory_reserve): Omit needless cast to size_t.
185 (mark_object_loop_halt): Mark as externally visible.
186
ac82cc6a
PE
187 * xselect.c: Integer signedness and overflow fixes.
188 (Fx_register_dnd_atom, x_handle_dnd_message):
189 Use ptrdiff_t, not size_t, since we prefer signed.
190 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
191 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
192 x_dnd_atoms_size and x_dnd_atoms_length.
193
c2d1e36d
PE
194 * doprnt.c: Prefer signed to unsigned when either works.
195 * eval.c (verror):
196 * doprnt.c (doprnt):
197 * lisp.h (doprnt):
198 * xdisp.c (vmessage):
199 Use ptrdiff_t, not size_t, when using or implementing doprnt,
200 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
201 prefer signed arithmetic to avoid comparison confusion.
202 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
203 but is a bit tricky.
204
0e926e56
PE
205 Assume freestanding C89 headers, string.h, stdlib.h.
206 * data.c, doprnt.c, floatfns.c, print.c:
207 Include float.h unconditionally.
208 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
209 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
210 * regex.c: Likewise for stddef.h, string.h.
211 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
212 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
213 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
214 (STDC_HEADERS): Remove obsolete defines.
215 * sysdep.c: Include limits.h unconditionally.
216
9cfdb3ec
PE
217 Assume support for memcmp, memcpy, memmove, memset.
218 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
219 * regex.c (memcmp, memcpy):
220 Remove; we assume C89 now.
221
222 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
223 (__malloc_safe_bcopy): Remove; no longer needed.
224
cf950e6b 225 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
226 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
227 well either way, and we prefer signed to unsigned.
228
dbf38e02
LMI
2292011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
230
231 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
232 closes the connection while we're reading (bug#9182).
233
d6f0886c
JD
2342011-07-25 Jan Djärv <jan.h.d@swipnet.se>
235
236 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
237 are specified (Bug#9168).
238
2eb1f9e6
PE
2392011-07-25 Paul Eggert <eggert@cs.ucla.edu>
240
241 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
242 Found by GCC static checking and --with-wide-int on a 32-bit host.
243
22381272 2442011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
245
246 * xdisp.c (compute_display_string_pos): Fix logic of caching
247 previous display string position. Initialize cached_prev_pos to
248 -1. Fixes slow-down at the beginning of a buffer.
249
f25e39b4
EZ
2502011-07-24 Eli Zaretskii <eliz@gnu.org>
251
252 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
253 for attrs[LFACE_FONTSET_INDEX].
254
04c4b52e
PE
2552011-07-23 Paul Eggert <eggert@cs.ucla.edu>
256
257 * xml.c (parse_region): Remove unused local
258 that was recently introduced.
259
c1734fbd
EZ
2602011-07-23 Eli Zaretskii <eliz@gnu.org>
261
be18c5a5
EZ
262 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
263 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
264
c1734fbd
EZ
265 * xdisp.c (move_it_in_display_line_to): Record the best matching
266 position for TO_CHARPOS while scanning the line, and restore it on
267 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
268 vertical-motion and pos-visible-in-window-p under bidi redisplay
269 when exact match is impossible due to invisible text, and the
270 lines are truncated.
271
a258d627
JD
2722011-07-23 Jan Djärv <jan.h.d@swipnet.se>
273
274 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
275 for OSX >= 10.7.
276
b6d5a689
EZ
2772011-07-22 Eli Zaretskii <eliz@gnu.org>
278
0f74f785
EZ
279 Fix a significant slow-down of cursor motion with C-n, C-p,
280 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
281 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 282 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
283 (next_element_from_buffer): Call compute_stop_pos_backwards to
284 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
285 base_level_stop.
286 (reseat): Don't look for prev_stop, as that could mean a very long
287 run.
288 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
289 <cached_disp_overlay_modiff>: Cache for last found display string
290 position.
551918c1 291 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
292 about the same buffer in the same area of character positions, and
293 the buffer wasn't changed since the time the display string
294 position was cached.
551918c1 295
b2d0c91a
EZ
2962011-07-22 Eli Zaretskii <eliz@gnu.org>
297
298 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
299 is an integer, which is important for empty lines. (Bug#9149)
300
043604ee
CY
3012011-07-22 Chong Yidong <cyd@stupidchicken.com>
302
303 * frame.c (Fmodify_frame_parameters): In tty case, update the
304 default face if necessary (Bug#4238).
305
da4adb04
CY
3062011-07-21 Chong Yidong <cyd@stupidchicken.com>
307
308 * editfns.c (Fstring_to_char): No need to explain what a character
309 is in the docstring (Bug#6576).
310
9abd0532
LMI
3112011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
312
313 * xml.c (parse_region): Make sure we always return a tree.
314
36881d16
HK
3152011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
316
317 * xml.c (parse_region): If a document contains only comments,
318 return that, too.
319
1e98674d
LMI
3202011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
321
322 * xml.c (make_dom): Return comments, too.
323
590bd467
PE
3242011-07-19 Paul Eggert <eggert@cs.ucla.edu>
325
326 Port to OpenBSD.
327 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
328 and the surrounding thread.
329 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
330 rather than fgets, and retry after EINTR. Otherwise, 'emacs
331 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
332 timer goes off.
333 * s/openbsd.h (BROKEN_SIGIO): Define.
334 * unexelf.c (unexec) [__OpenBSD__]:
335 Don't update the .mdebug section of the Alpha COFF symbol table.
336
f41628b2
LMI
3372011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
338
339 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
340 (bug#8460).
341
b59b67c5
PE
3422011-07-18 Paul Eggert <eggert@cs.ucla.edu>
343
15e3a074
PE
344 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
345 This fixes some race conditions on the permissions of any newly
346 created file.
347
41bed37d
PE
348 * alloc.c (valid_pointer_p): Use pipe, not open.
349 This fixes some permissions issues when debugging.
350
b59b67c5
PE
351 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
352 If fchown fails to set both uid and gid, try to set just gid,
353 as that is sometimes allowed. Adjust the file's mode to eliminate
354 setuid or setgid bits that are inappropriate if fchown fails.
355
925a6be7
SM
3562011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
357
358 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
359 to compare Lisp_Objects.
360 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
361 global_gnutls_log_level, don't mistake it for a Lisp_Object.
362 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
363
52968808
AS
3642011-07-17 Andreas Schwab <schwab@linux-m68k.org>
365
0a6a104b
AS
366 * lread.c (read_integer): Unread even EOF character.
367 (read1): Likewise. Properly record start position of symbol.
368
52968808
AS
369 * lread.c (read1): Read `#:' as empty uninterned symbol if no
370 symbol character follows.
371
9e381cdd
PE
3722011-07-17 Paul Eggert <eggert@cs.ucla.edu>
373
374 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
375 This works around a problem with the previous change to Fcopy_file.
376 Recent glibc declares fchown with __attribute__((warn_unused_result)),
377 and without this change, GCC might complain about discarding
378 fchown's return value.
379
b5641435
JB
3802011-07-16 Juanma Barranquero <lekktu@gmail.com>
381
382 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
383
a8031457
PE
3842011-07-16 Paul Eggert <eggert@cs.ucla.edu>
385
386 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
387
dd889327
LMI
3882011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
389
750c33f7
LMI
390 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
391 it's used from the C level.
392
dd889327
LMI
393 * process.c: Use the same condition for POLL_FOR_INPUT in both
394 keyboard.c and process.c (bug#1858).
395
87e86684
LM
3962011-07-09 Lawrence Mitchell <wence@gmx.li>
397
398 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
399 (Fgnutls_boot): Use it.
400
64348f40
AS
4012011-07-15 Andreas Schwab <schwab@linux-m68k.org>
402
403 * doc.c (Fsubstitute_command_keys): Revert last change.
404
1d698799
LMI
4052011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
406
f863868c
LMI
407 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
408 quotes the next character, and doesn't affect other longer
409 sequences (bug#8935).
410
1d698799
LMI
411 * lread.c (syms_of_lread): Clarify that is isn't only
412 `eval-buffer' and `eval-defun' that's affected by
413 `lexical-binding' (bug#8460).
414
aa4b6df6
EZ
4152011-07-15 Eli Zaretskii <eliz@gnu.org>
416
417 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
418 bidi redisplay when a line includes both an image and is
419 truncated.
420
5d856da6
PE
4212011-07-14 Paul Eggert <eggert@cs.ucla.edu>
422
ad6042bb
PE
423 Fix minor problems found by static checking.
424 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
425 (elsz): Now a signed constant, not a size_t var. We prefer signed
426 types to unsigned, to avoid integer comparison confusion. Without
427 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
428 "cannot optimize loop, the loop counter may overflow", a symptom
429 of the confusion.
f00bbb22 430 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
431 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
432
6468f31c
LMI
4332011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
434
49080b10
LMI
435 * search.c (Fre_search_backward): Mention `case-fold-search' in
436 all the re_search_* functions (bug#8138).
437
6468f31c
LMI
438 * keyboard.c (Fopen_dribble_file): Document when the file is
439 closed (bug#8056).
440
c965adc5
EZ
4412011-07-14 Eli Zaretskii <eliz@gnu.org>
442
df9733bf
EZ
443 * bidi.c (bidi_dump_cached_states): Fix format of displaying
444 bidi_cache_idx.
445
0bb23927
EZ
446 Support bidi reordering of display and overlay strings.
447 * xdisp.c (compute_display_string_pos)
448 (compute_display_string_end): Accept additional argument STRING.
449 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
450 (reseat_to_string): Initialize bidi_it->string.s and
451 bidi_it->string.schars.
452 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
453 NULL (avoids a crash in bidi_paragraph_init). Initialize
454 itb.string.lstring.
455 (init_iterator): Call bidi_init_it only of a valid
456 buffer position was specified. Initialize paragraph_embedding to
457 L2R.
458 (reseat_to_string): Initialize the bidi iterator.
459 (display_string): If we need to ignore text properties of
460 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
461 original value of -1 will not work with bidi.)
462 (compute_display_string_pos): First arg is now struct
463 `text_pos *'; all callers changed. Support display properties on
464 Lisp strings.
465 (compute_display_string_end): Support display properties on Lisp
466 strings.
467 (init_iterator, reseat_1, reseat_to_string): Initialize the
468 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
469 when iterating on a string not from display properties).
470 (compute_display_string_pos, compute_display_string_end): Fix
471 calculation of the object to scan. Fixes an error when using
472 arrow keys.
473 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
474 base_level_stop; instead, set base_level_stop to BEGV. Fixes
475 crashes in vertical-motion.
476 (next_element_from_buffer): Improve commentary for when
477 the iterator is before prev_stop.
478 (init_iterator): Initialize bidi_p from the default value of
479 bidi-display-reordering, not from buffer-local value. Use the
480 buffer-local value only if initializing for buffer iteration.
481 (handle_invisible_prop): Support invisible properties on strings
482 that are being bidi-reordered.
483 (set_iterator_to_next): Support bidi reordering of C strings and
484 Lisp strings.
485 (next_element_from_string): Support bidi reordering of Lisp
486 strings.
487 (handle_stop_backwards): Support Lisp strings as well.
488 (display_string): Support display of R2L glyph rows. Use
489 IT_STRING_CHARPOS when displaying from a Lisp string.
490 (init_iterator): Don't initialize it->bidi_p for strings
491 here.
492 (reseat_to_string): Initialize it->bidi_p for strings here.
493 (next_element_from_string, next_element_from_c_string)
494 (next_element_from_buffer): Add xassert's for correspondence
495 between IT's object being iterated and it->bidi_it.string
496 structure.
497 (face_before_or_after_it_pos): Support bidi iteration.
498 (next_element_from_c_string): Handle the case of the first string
499 character that is not the first one in the visual order.
500 (get_visually_first_element): New function, refactored from common
501 parts of next_element_from_buffer, next_element_from_string, and
502 next_element_from_c_string.
503 (tool_bar_lines_needed, redisplay_tool_bar)
504 (display_menu_bar): Force left-to-right direction. Add a FIXME
505 comment for making that be controlled by a user option.
506 (push_it, pop_it): Save and restore the state of the
507 bidi iterator. Save and restore the bidi_p flag.
508 (pop_it): Iterate out of display property for string iteration as
509 well.
510 (iterate_out_of_display_property): Support iteration over strings.
511 (handle_single_display_spec): Set up it->bidi_it for iteration
512 over a display string, and call bidi_init_it.
513 (handle_single_display_spec, next_overlay_string)
514 (get_overlay_strings_1, push_display_prop): Set up the bidi
515 iterator for displaying display or overlay strings.
516 (forward_to_next_line_start): Don't use the shortcut if
517 bidi-iterating.
518 (back_to_previous_visible_line_start): If handle_display_prop
519 pushed the iterator stack, restore the internal state of the bidi
520 iterator by calling bidi_pop_it same number of times.
521 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
522 and we are bidi-iterating, don't decrement the iterator position;
523 instead, set the first_elt flag in the bidi iterator, to produce
524 the same effect.
525 (reseat_1): Remove redundant setting of string_from_display_prop_p.
526 (push_display_prop): xassert that we are iterating a buffer.
527 (push_it, pop_it): Save and restore paragraph_embedding member.
528 (handle_single_display_spec, next_overlay_string)
529 (get_overlay_strings_1, reseat_1, reseat_to_string)
530 (push_display_prop): Set up the `unibyte' member of bidi_it.string
531 correctly. Don't assume unibyte strings are not bidi-reordered.
532 (compute_display_string_pos)
533 (compute_display_string_end): Fix handling the case of C string.
534 (push_it, pop_it): Save and restore from_disp_prop_p.
535 (handle_single_display_spec, push_display_prop): Set the
536 from_disp_prop_p flag.
537 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
538 (pop_it): Call iterate_out_of_display_property only if we are
539 popping after iteration over a string that came from a display
540 property. Fix a typo in popping stretch info. Add an assertion
541 for verifying that the iterator position is in sync with the bidi
542 iterator.
543 (handle_single_display_spec, get_overlay_strings_1)
544 (push_display_prop): Fix initialization of paragraph direction for
545 string when that of the parent object is not yet determined.
546 (reseat_1): Call bidi_init_it to resync the bidi
547 iterator with IT's position. (Bug#7616)
548 (find_row_edges): If ROW->start.pos gives position
549 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
550 (handle_stop, back_to_previous_visible_line_start, reseat_1):
551 Reset the from_disp_prop_p flag.
552 (SAVE_IT, RESTORE_IT): New macros.
553 (pos_visible_p, face_before_or_after_it_pos)
554 (back_to_previous_visible_line_start)
555 (move_it_in_display_line_to, move_it_in_display_line)
556 (move_it_to, move_it_vertically_backward, move_it_by_lines)
557 (try_scrolling, redisplay_window, display_line): Use them when
558 saving a temporary copy of the iterator and restoring it back.
559 (back_to_previous_visible_line_start, reseat_1)
560 (init_iterator): Empty the bidi cache "stack".
561 (move_it_in_display_line_to): If iterator ended up at
562 EOL, but we never saw any buffer positions smaller than
563 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
564 motion in bidi-reordered lines.
565 (move_it_in_display_line_to): Record prev_method and prev_pos
566 immediately before the call to set_iterator_to_next. Fixes cursor
567 motion in bidi-reordered lines with stretch glyphs and strings
568 displayed in margins. (Bug#8133) (Bug#8867)
569 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
570 TO_CHARPOS.
571 (pos_visible_p): Support positions in bidi-reordered lines. Save
572 and restore bidi cache.
573
574 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
575 (bidi_paragraph_info): Delete unused struct.
576 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
577 (bidi_cache_start): New variable.
578 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
579 to zero.
580 (bidi_cache_fetch_state, bidi_cache_search)
581 (bidi_cache_find_level_change, bidi_cache_iterator_state)
582 (bidi_cache_find, bidi_peek_at_next_level)
583 (bidi_level_of_next_char, bidi_find_other_level_edge)
584 (bidi_move_to_visually_next): Compare cache index with
585 bidi_cache_start rather than with zero.
586 (bidi_fetch_char): Accept new argument STRING; all callers
587 changed. Support iteration over a string. Support strings with
588 display properties. Support unibyte strings. Fix the type of
589 `len' according to what STRING_CHAR_AND_LENGTH expects.
590 (bidi_paragraph_init, bidi_resolve_explicit_1)
591 (bidi_resolve_explicit, bidi_resolve_weak)
592 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
593 iteration over a string.
594 (bidi_set_sor_type, bidi_resolve_explicit_1)
595 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
596 can now be zero (for strings); special values 0 and -1 were
597 changed to -1 and -2, respectively.
598 (bidi_char_at_pos): New function.
599 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
600 Call it instead of FETCH_MULTIBYTE_CHAR.
601 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
602 initialized to valid values.
603 (bidi_init_it): Don't initialize charpos and bytepos with invalid
604 values.
605 (bidi_level_of_next_char): Allow the sentinel "position" to pass
606 the test for valid cached positions. Fix the logic for looking up
607 the sentinel state in the cache. GCPRO the Lisp string we are
608 iterating.
609 (bidi_push_it, bidi_pop_it): New functions.
610 (bidi_initialize): Initialize the bidi cache start stack pointer.
611 (bidi_cache_ensure_space): New function, refactored from part of
612 bidi_cache_iterator_state. Don't assume the required size is just
613 one BIDI_CACHE_CHUNK away.
614 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
615 (bidi_count_bytes, bidi_char_at_pos): New functions.
616 (bidi_cache_search): Don't assume bidi_cache_last_idx is
617 always valid if bidi_cache_idx is valid.
618 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
619 is valid if it's going to be used.
620 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
621 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
622 (bidi_cache_find_level_change, bidi_cache_ensure_space)
623 (bidi_cache_iterator_state, bidi_cache_find)
624 (bidi_find_other_level_edge, bidi_cache_start_stack): All
625 variables related to cache indices are now EMACS_INT.
626
0bb23927
EZ
627 * dispextern.h (struct bidi_string_data): New structure.
628 (struct bidi_it): New member `string'. Make flag members be 1-bit
629 fields, and put them last in the struct.
630 (compute_display_string_pos, compute_display_string_end): Update
631 prototypes.
632 (bidi_push_it, bidi_pop_it): Add prototypes.
633 (struct iterator_stack_entry): New members bidi_p,
634 paragraph_embedding, and from_disp_prop_p.
635 (struct it): Member bidi_p is now a bit field 1 bit wide.
636 (bidi_shelve_cache, bidi_unshelve_cache): Declare
637 prototypes.
638
639 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
640 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
641 and vector-like objects.
642
643 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
644 cache around display iteration.
645
646 * window.c (Fwindow_end, window_scroll_pixel_based)
647 (displayed_window_lines, Frecenter): Save and restore the bidi
648 cache around display iteration.
649
3bbd2265
LMI
6502011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
651
652 * editfns.c (Fdelete_region): Clarify the use of the named
653 parameters (bug#6788).
654
adc47434
MR
6552011-07-14 Martin Rudalics <rudalics@gmx.at>
656
657 * indent.c (Fvertical_motion): Set and restore w->pointm when
658 saving and restoring the window's buffer (Bug#9006).
659
837c31f8
LMI
6602011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
661
662 * editfns.c (Fstring_to_char): Clarify just what is returned
663 (bug#6576). Text by Eli Zaretskii.
664
ac389d0c
JB
6652011-07-13 Juanma Barranquero <lekktu@gmail.com>
666
667 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
668
0be0ce47
EZ
6692011-07-13 Eli Zaretskii <eliz@gnu.org>
670
671 * buffer.c (mmap_find): Fix a typo.
672
cd18e7e3
JB
6732011-07-13 Johan Bockgård <bojohan@gnu.org>
674
675 Fix execution of x selection hooks.
676 * xselect.c (Qx_lost_selection_functions)
677 (Qx_sent_selection_functions): New vars.
678 (syms_of_xselect): DEFSYM them.
679 (x_handle_selection_request): Pass Qx_sent_selection_functions
680 rather than Vx_sent_selection_functions to Frun_hook_with_args.
681 (x_handle_selection_clear,x_clear_frame_selections):
682 Pass Qx_lost_selection_functions rather than
683 Vx_lost_selection_functions to Frun_hook_with_args.
684
47ea7f44
PE
6852011-07-13 Paul Eggert <eggert@cs.ucla.edu>
686
ac389d0c 687 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
688 The old code sometimes used this field without initializing it.
689
47ea7f44
PE
690 * alloc.c (gc_sweep): Don't read past end of array.
691 In theory, the old code could also have corrupted Emacs internals,
692 though it'd be very unlikely.
693
bc985c87
AS
6942011-07-12 Andreas Schwab <schwab@linux-m68k.org>
695
696 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 697 argument. (Bug#4026)
bc985c87 698
0cf34688
LMI
6992011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
700
b3dadd76
LMI
701 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
702 key" (bug#4257).
703
0cf34688
LMI
704 * window.c (Fset_window_start): Doc fix (bug#4199).
705 (Fset_window_hscroll): Ditto.
706
270768cd
PE
7072011-07-12 Paul Eggert <eggert@cs.ucla.edu>
708
077e3dda 709 Fix minor new problems caught by GCC 4.6.1.
270768cd 710 * term.c (init_tty): Remove unused local.
490011a6 711 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 712 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 713 not used otherwise.
270768cd 714
b1f58454
CY
7152011-07-12 Chong Yidong <cyd@stupidchicken.com>
716
717 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
718
22b9578d
LMI
7192011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
720
6e70ab07
LMI
721 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
722 are the mini-buffer and the echo area (bug#3320).
723
22b9578d
LMI
724 * term.c (init_tty): Remove support for supdup, c10 and perq
725 terminals, which are no longer supported (bug#1482).
726
8974cc9f
JB
7272011-07-10 Johan Bockgård <bojohan@gnu.org>
728
729 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
730
a560d974
JD
7312011-07-10 Jan Djärv <jan.h.d@swipnet.se>
732
733 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
734 for non-popups (Bug#3642).
735
1dae0f0a
AS
7362011-07-10 Andreas Schwab <schwab@linux-m68k.org>
737
268c2c36 738 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 739 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
740 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
741 * cm.c (losecursor): Likewise.
1dae0f0a
AS
742 * data.c (fmod): Likewise.
743 * dispnew.c (swap_glyphs_in_rows): Likewise.
744 * emacs.c (memory_warning_signal): Likewise.
745 * floatfns.c (float_error): Likewise.
746 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
747 (otf_open, font_otf_capability, generate_otf_features)
748 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
749 Likewise.
750 * image.c (pbm_read_file): Likewise.
751 * indent.c (string_display_width): Likewise.
752 * intervals.c (check_for_interval, search_for_interval)
753 (inc_interval_count, count_intervals, root_interval)
754 (adjust_intervals_for_insertion, make_new_interval): Likewise.
755 * lread.c (defalias): Likewise.
268c2c36 756 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
757 * regex.c (set_image_of_range_1, set_image_of_range)
758 (regex_grow_registers): Likewise.
759 * sysdep.c (strerror): Likewise.
760 * termcap.c (valid_filename_p, tprint, main): Likewise.
761 * tparam.c (main): Likewise.
762 * unexhp9k800.c (run_time_remap, save_data_space)
763 (update_file_ptrs, read_header, write_header, calculate_checksum)
764 (copy_file, copy_rest, display_header): Likewise.
765 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
766 Likewise.
767 * xdisp.c (check_it): Likewise.
768 * xfaces.c (register_color, unregister_color, unregister_colors):
769 Likewise.
770 * xfns.c (print_fontset_result): Likewise.
771 * xrdb.c (member, fatal, main): Likewise.
772
99033785
PE
7732011-07-10 Paul Eggert <eggert@cs.ucla.edu>
774
775 Fix minor problems found by static checking (Bug#9031).
776 * chartab.c (char_table_set_range, map_sub_char_table):
777 Remove unused locals.
778 (uniprop_table): Now static.
779 * composite.c (_work_char): Remove unused static var.
780
9cb2ac56
JB
7812011-07-09 Juanma Barranquero <lekktu@gmail.com>
782
783 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
784
f25661f0
JD
7852011-07-09 Jan Djärv <jan.h.d@swipnet.se>
786
787 * gtkutil.c (qttip_cb): Remove code without function.
788
8278c4fe
EZ
7892011-07-09 Eli Zaretskii <eliz@gnu.org>
790
791 * w32.c (pthread_sigmask): New stub.
792
1692ae2d 7932011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 794
8a6ebd58 795 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
796 sigprocmask is portable only for single-threaded applications, and
797 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
798 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
799 (LIBES): Use it.
800 * callproc.c (Fcall_process):
801 * process.c (create_process):
802 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
803 Use pthread_sigmask, not sigprocmask.
123403e4 804
1b854618
JD
8052011-07-08 Jan Djärv <jan.h.d@swipnet.se>
806
807 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
808 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
809 wrong (Bug#8591).
810
3fe4b549
JD
8112011-07-08 Jan Djärv <jan.h.d@swipnet.se>
812
0ce7e563
JD
813 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
814 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
815 (xg_hide_tooltip): Fix comment.
816
3fe4b549
JD
817 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
818 in registerServicesMenuSendTypes.
819 (validRequestorForSendType): Don't check ns_return_types.
820
821 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
822 ns_return_type.
823
5df75e47
JR
8242011-07-08 Jason Rumney <jasonr@gnu.org>
825
826 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
827 frame struct members of non-existent frames (Bug#6284).
828
699c10bd
JD
8292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
830
4393663b
JD
831 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
832 variable firstTime not needed on OSX >= 10.6.
833 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
834 >= 10.5. Use setKnobProportion, setDoubleValue.
835
836 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
837 (MAC_OS_X_VERSION_10_5): Define if not defined.
838 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
839 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
840 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
841
842 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
843 cString and lossyCString on OSX >= 10.4
844
845 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
846 sizeToFit on OSX >= 10.2.
847
848 * nsimage.m (allocInitFromFile): Don't use deprecated method
849 bestRepresentationForDevice on OSX >= 10.6.
850
851 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
852 to avoid warning.
853
854 * emacs.c: Declare unexec_init_emacs_zone.
855
a63e0781
JD
856 * nsgui.h: Fix compiler warning about gnulib redefining verify.
857
699c10bd
JD
858 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
859
860 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
861 on svcsMenu (Bug#8842).
862
863 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
864 ns_return_types.
865 (Fns_list_services): Just return Qnil on 10.6, code not working there.
866
867 * nsterm.m (QUTF8_STRING): Declare.
868 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
869 (validRequestorForSendType): Return type is (id).
870 Change indexOfObjectIdenticalTo to indexOfObject.
871 Check if we have local selection before returning self (Bug#8842).
872 (writeSelectionToPasteboard): Put local selection into paste board
873 if we have a local selection (Bug#8842).
874 (syms_of_nsterm): DEFSYM QUTF8_STRING.
875
876 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
877 (ns_get_local_selection): Declare.
878
54e10184
LMI
8792011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
880
9888ff71
LMI
881 * keymap.c (describe_map_tree): Don't insert a double newline at
882 the end of the buffer (bug#1169) and return whether we inserted
883 something.
884
54e10184
LMI
885 * callint.c (Fcall_interactively): Change "reading args" to
886 "providing args" to try to clarify what it does (bug#1010).
887
15fa4783
KH
8882011-07-07 Kenichi Handa <handa@m17n.org>
889
890 * composite.c (composition_compute_stop_pos): Ignore a static
891 composition starting before CHARPOS (Bug#8915).
892
893 * xdisp.c (handle_composition_prop): Likewise.
894
a8815b00
EZ
8952011-07-07 Eli Zaretskii <eliz@gnu.org>
896
897 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
898 (Bug#9015)
899
ef7b981d 9002011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
901
902 * character.h (unicode_category_t): New enum type.
903
904 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
905 (Qchar_code_property_table): New variable.
906 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
907 (UNIPROP_COMPRESSED_FORM_P): New macros.
908 (char_table_ascii): Uncompress the compressed values.
909 (sub_char_table_ref): New arg is_uniprop. Callers changed.
910 Uncompress the compressed values.
ac389d0c 911 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
912 (char_table_ref_and_range): Uncompress the compressed values.
913 (sub_char_table_set): New arg is_uniprop. Callers changed.
914 Uncompress the compressed values.
915 (sub_char_table_set_range): Args changed. Callers changed.
916 (char_table_set_range): Adjuted for the above change.
917 (map_sub_char_table): Delete args default_val and parent. Add arg
918 top. Give decoded values to a Lisp function.
919 (map_char_table): Adjusted for the above change. Give decoded
920 values to a Lisp function. Gcpro more variables.
921 (uniprop_table_uncompress)
922 (uniprop_decode_value_run_length): New functions.
923 (uniprop_decoder, uniprop_decoder_count): New variables.
924 (uniprop_get_decoder, uniprop_encode_value_character)
925 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
926 New functions.
927 (uniprop_encoder, uniprop_encoder_count): New variables.
928 (uniprop_get_encoder, uniprop_table)
929 (Funicode_property_table_internal, Fget_unicode_property_internal)
930 (Fput_unicode_property_internal): New functions.
931 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
932 Sunicode_property_table_internal, Sget_unicode_property_internal,
933 and Sput_unicode_property_internal. Defvar_lisp
934 char-code-property-alist.
935
936 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
937 Vunicode_category_table.
938
939 * font.c (font_range): Adjusted for the change of
940 Vunicode_category_table.
941
76b397fb
DN
9422011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
943
944 * m/iris4d.h: Remove file, move contents ...
945 * s/irix6-5.h: ... here.
946
22b4128e
PE
9472011-07-06 Paul Eggert <eggert@cs.ucla.edu>
948
949 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
950 * alloc.c (mark_buffer):
951 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
952 (clone_per_buffer_values): Don't assume that
22b4128e
PE
953 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
954 This isn't true in general, and it's particularly not true
955 if Emacs is configured with --with-wide-int.
956 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
957 New macros, used in the buffer.c change.
958
869795d6
JD
9592011-07-05 Jan Djärv <jan.h.d@swipnet.se>
960
961 * xsettings.c: Use both GConf and GSettings if both are available.
962 (store_config_changed_event): Add comment.
963 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
964 (store_tool_bar_style_changed): New functions.
965 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
966 (struct xsettings): Move font inside HAVE_XFT.
967 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
968 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
969 Move inside HAVE_XFT.
970 (something_changed_gsettingsCB): Renamed from something_changedCB.
971 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
972 also.
973 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
974 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
975 (something_changed_gconfCB): Renamed from something_changedCB.
976 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
977 (parse_settings): Move check for font inside HAVE_XFT.
978 (read_settings, apply_xft_settings): Add comment.
979 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
980 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
981 call store_font_name_changed.
982 (xft_settings_event): Add comment.
983 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
984 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
985 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
986 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
987 (xsettings_initialize): Call init_gsettings last.
988 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
989 comment.
990
d8ed26bd
PE
9912011-07-05 Paul Eggert <eggert@cs.ucla.edu>
992
993 Random fixes. E.g., (random) never returned negative values.
994 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
995 subseconds part to the entropy, as that's a bit more random.
996 Prefer signed to unsigned, since the signedness doesn't matter and
997 in general we prefer signed. When given a limit, use a
998 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
999 latter isn't right if USE_2_TAGS_FOR_INTS.
1000 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1001 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1002
cabf1cac
SM
10032011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1004
1005 * textprop.c (text_property_stickiness):
1006 Obey Vtext_property_default_nonsticky.
1007 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1008 * w32fns.c (syms_of_w32fns):
1009 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1010
6e9b2be9
PE
10112011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1012
1013 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1014 This is more efficient than Ffile_directory_p and avoids a minor race.
1015
90186c68
LMI
10162011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1017
7c301272
LMI
1018 * buffer.c (Foverlay_put): Say what the return value is
1019 (bug#7835).
1020
c4f2d8d4
LMI
1021 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1022 is a directory before asking whether to use the file name
1023 (bug#7564).
ad637907
LMI
1024 (barf_or_query_if_file_exists): Make the "File is a directory"
1025 error be more correct.
c4f2d8d4 1026
90186c68
LMI
1027 * fns.c (Frequire): Remove the mention of the .gz files, since
1028 that's installation-specific, but keep the mention of
1029 `get-load-suffixes'.
1030
da64016e
PE
10312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1032
1033 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1034 Report string overflow if the output is too long.
1035
7d47b580
JB
10362011-07-04 Juanma Barranquero <lekktu@gmail.com>
1037
a555cb87
JB
1038 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1039 (syms_of_gnutls): Remove duplicate DEFSYM for
1040 Qgnutls_bootprop_verify_hostname_error, an error for
1041 Qgnutls_bootprop_verify_error (which is no longer used).
1042
7d47b580
JB
1043 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1044 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1045 Also (re)move comments that are misplaced or no longer relevant.
1046
1e49bfab
LMI
10472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1048
1049 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1050
1485f4c0
CY
10512011-07-03 Chong Yidong <cyd@stupidchicken.com>
1052
1053 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1054 and background color parameters if they have been changed.
1055
a9ab721e
LMI
10562011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1057
1058 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1059
cf7cff57
PE
10602011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1061
2e13213d
PE
1062 * xsettings.c (SYSTEM_FONT): Define only when used.
1063 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1064
cf7cff57
PE
1065 * keymap.c (access_keymap_1): Now static.
1066
7a8e04f7
CY
10672011-07-02 Chong Yidong <cyd@stupidchicken.com>
1068
1069 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1070 leave any prefix arg for the up event (Bug#1586).
1071
61352f62
LMI
10722011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1073
69bb1ef7
LMI
1074 * lread.c (syms_of_lread): Mention single symbols defined by
1075 `defvar' or `defconst' (bug#7154).
1076
61352f62 1077 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1078 (Frequire): Mention get-load-suffixes.
61352f62 1079
28545e04
MR
10802011-07-02 Martin Rudalics <rudalics@gmx.at>
1081
1082 * window.h (window): Remove clone_number slot.
1083 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1084 Remove.
1085 (make_parent_window, make_window, saved_window)
1086 (Fset_window_configuration, save_window_save): Don't deal with
1087 clone numbers.
1088 * buffer.c (Qclone_number): Remove declaration.
1089 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1090
3349e122
SM
10912011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1092
1093 Add multiple inheritance to keymaps.
1094 * keymap.c (Fmake_composed_keymap): New function.
1095 (Fset_keymap_parent): Simplify.
1096 (fix_submap_inheritance): Remove.
1097 (access_keymap_1): New function extracted from access_keymap to handle
1098 embedded parents and handle lists of maps.
1099 (access_keymap): Use it.
1100 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1101 (Fcopy_keymap): Handle embedded parents.
1102 (Fcommand_remapping, define_as_prefix): Simplify.
1103 (Fkey_binding): Simplify.
1104 (syms_of_keymap): Move minibuffer-local-completion-map,
1105 minibuffer-local-filename-completion-map,
1106 minibuffer-local-must-match-map, and
1107 minibuffer-local-filename-must-match-map to Elisp.
1108 (syms_of_keymap): Defsubr make-composed-keymap.
1109 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1110 (parse_menu_item): Trivial simplification.
1111
3279eb87
GM
11122011-07-01 Glenn Morris <rgm@gnu.org>
1113
1114 * Makefile.in (SETTINGS_LIBS): Fix typo.
1115
4550efdf
KI
11162011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1117
1118 * coding.c (Fencode_coding_string): Record the last coding system
1119 used, as the function doc string says (bug#8738).
1120
0949d2b6
JD
11212011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1122
1123 * xsettings.c (store_monospaced_changed): Take new font as arg and
1124 check for change against current_mono_font.
1125 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1126 (emacs_settings_constructor, emacs_settings_get_property)
1127 (emacs_settings_set_property, emacs_settings_class_init)
1128 (emacs_settings_init, gsettings_obj): Remove.
1129 (something_changedCB): New function for HAVE_GSETTINGS.
1130 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1131 with value as argument.
1132 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1133 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1134 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1135 "changed".
1136
1137 * xgselect.c: Add defined (HAVE_GSETTINGS).
1138 (xgselect_initialize): Ditto.
1139
1140 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1141 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1142 xg_select.
1143
bbc6b304
PE
11442011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1145
1146 * eval.c (struct backtrace): Simplify and port the data structure.
1147 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1148 signed bit field, as this assumption is not portable and it makes
1149 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1150 "char debug_on_exit : 1" as this is not portable either; instead,
1151 use the portable "unsigned int debug_on_exit : 1". Remove unused
1152 member evalargs. Remove obsolete comments about cc bombing out.
1153
9851bfc5
JD
11542011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1155
51bb811f 1156 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1157 Let HAVE_GSETTINGS override HAVE_GCONF.
1158 (store_monospaced_changed): New function.
1159 (EMACS_SETTINGS): A new type derived from GObject to handle
1160 GSettings notifications.
1161 (emacs_settings_constructor, emacs_settings_get_property)
1162 (emacs_settings_set_property, emacs_settings_class_init):
1163 New functions.
1164 (gsettings_client, gsettings_obj): New variables.
1165 (GSETTINGS_SCHEMA): New define.
1166 (something_changedCB): Call store_monospaced_changed.
1167 (init_gsettings): New function.
1168 (xsettings_initialize): Call init_gsettings.
1169 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1170 to NULL.
1171
1172 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1173 GCONF_CFLAGS/LIBS.
1174
5386012d
MR
11752011-06-29 Martin Rudalics <rudalics@gmx.at>
1176
1177 * window.c (resize_root_window, grow_mini_window)
1178 (shrink_mini_window): Rename Qresize_root_window to
1179 Qwindow_resize_root_window and Qresize_root_window_vertically to
1180 Qwindow_resize_root_window_vertically.
1181
f13e0b08
PE
11822011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1183
1184 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1185
94515237
JB
11862011-06-27 Juanma Barranquero <lekktu@gmail.com>
1187
1188 * makefile.w32-in: Redesign dependencies so they reflect more
1189 clearly which files are directly included by each source file,
1190 and not through other includes.
1191
e43b6e43
MR
11922011-06-27 Martin Rudalics <rudalics@gmx.at>
1193
1194 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1195 (sort_overlays, overlay_strings): When an overlay's clone number
1196 matches the window's clone number process the overlay even if
1197 the overlay's window property doesn't match the current window.
1198
d68443dc
MR
1199 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1200 (Fwindow_hchild): Rename to Fwindow_left_child.
1201 (Fwindow_next): Rename to Fwindow_next_sibling.
1202 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1203 (resize_window_check): Rename to window_resize_check.
1204 (resize_window_apply): Rename to window_resize_apply.
1205 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1206 (Fdelete_other_windows_internal, resize_frame_windows)
1207 (Fsplit_window_internal, Fdelete_window_internal)
1208 (grow_mini_window, shrink_mini_window)
1209 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1210
c7e73be5
JD
12112011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1212
1213 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1214 (emacs_fixed_set_min_size): Remove.
1215 (emacs_fixed_new): Take frame as argument.
1216
1217 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1218 (_EmacsFixedPrivate): Remove minwidth/height.
1219 Add struct frame *f.
1220 (emacs_fixed_init): Initialize priv->f.
1221 (get_parent_class, emacs_fixed_set_min_size): Remove.
1222 (emacs_fixed_new): Set priv->f to argument.
1223 (emacs_fixed_get_preferred_width)
1224 (emacs_fixed_get_preferred_height): Use min_width/height from
1225 frames size_hint to set minimum and natural (Bug#8919).
1226 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1227 and use min_width/height from frames size_hint to set
1228 min_width/height (Bug#8919).
1229
1230 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1231 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1232 Fix indentation.
c7e73be5 1233
cf99dcf8
EZ
12342011-06-26 Eli Zaretskii <eliz@gnu.org>
1235
1236 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1237 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1238 called at ZV.
1239
029529ac
CY
12402011-06-26 Chong Yidong <cyd@stupidchicken.com>
1241
1242 * process.c (wait_reading_process_output): Bypass select if
1243 waiting for a cell while ignoring keyboard input, and input is
1244 pending. Suggested by Jan Djärv (Bug#8869).
1245
7a7ef429
PE
12462011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1247
1248 Use gnulib's dup2 module instead of rolling our own.
1249 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1250
11fdef7d 12512011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1252
1253 * dispnew.c (scrolling_window): Before scrolling, turn off a
1254 mouse-highlight in the window being scrolled.
1255
cd3520a4
JB
12562011-06-24 Juanma Barranquero <lekktu@gmail.com>
1257
1258 Move DEFSYM to lisp.h and use everywhere.
1259
1260 * character.h (DEFSYM): Move declaration...
1261 * lisp.h (DEFSYM): ...here.
1262
1263 * gnutls.c:
1264 * minibuf.c:
1265 * w32menu.c:
1266 * w32proc.c:
1267 * w32select.c: Don't include character.h.
1268
1269 * alloc.c (syms_of_alloc):
1270 * buffer.c (syms_of_buffer):
1271 * bytecode.c (syms_of_bytecode):
1272 * callint.c (syms_of_callint):
1273 * casefiddle.c (syms_of_casefiddle):
1274 * casetab.c (init_casetab_once):
1275 * category.c (init_category_once, syms_of_category):
1276 * ccl.c (syms_of_ccl):
1277 * cmds.c (syms_of_cmds):
1278 * composite.c (syms_of_composite):
1279 * dbusbind.c (syms_of_dbusbind):
1280 * dired.c (syms_of_dired):
1281 * dispnew.c (syms_of_display):
1282 * doc.c (syms_of_doc):
1283 * editfns.c (syms_of_editfns):
1284 * emacs.c (syms_of_emacs):
1285 * eval.c (syms_of_eval):
1286 * fileio.c (syms_of_fileio):
1287 * fns.c (syms_of_fns):
1288 * frame.c (syms_of_frame):
1289 * fringe.c (syms_of_fringe):
1290 * insdel.c (syms_of_insdel):
1291 * keymap.c (syms_of_keymap):
1292 * lread.c (init_obarray, syms_of_lread):
1293 * macros.c (syms_of_macros):
1294 * msdos.c (syms_of_msdos):
1295 * print.c (syms_of_print):
1296 * process.c (syms_of_process):
1297 * search.c (syms_of_search):
1298 * sound.c (syms_of_sound):
1299 * syntax.c (init_syntax_once, syms_of_syntax):
1300 * terminal.c (syms_of_terminal):
1301 * textprop.c (syms_of_textprop):
1302 * undo.c (syms_of_undo):
1303 * w32.c (globals_of_w32):
1304 * window.c (syms_of_window):
1305 * xdisp.c (syms_of_xdisp):
1306 * xfaces.c (syms_of_xfaces):
1307 * xfns.c (syms_of_xfns):
1308 * xmenu.c (syms_of_xmenu):
1309 * xsettings.c (syms_of_xsettings):
1310 * xterm.c (syms_of_xterm): Use DEFSYM.
1311
4228cf16
TZ
13122011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1313
cd3520a4 1314 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1315
7fcccf1e
PE
13162011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1317
7efb4e0e
PE
1318 Integer and buffer overflow fixes (Bug#8873).
1319
ff5844ad
PE
1320 * print.c (printchar, strout): Check for string overflow.
1321 (PRINTPREPARE, printchar, strout):
1322 Don't set size unless allocation succeeds.
1323
90532f02
PE
1324 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1325 for sizes. Check for string overflow more accurately.
1326 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1327
6d84508d
PE
1328 * macros.c: Integer and buffer overflow fixes.
1329 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1330 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1331 Use ptrdiff_t, not int, for sizes.
1332 Don't increment bufsize until after realloc succeeds.
1333 Check for size-calculation overflow.
1334 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1335
437b2cb4
PE
1336 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1337
8b9ac8b4
PE
1338 * lread.c: Integer overflow fixes.
1339 (read_integer): Radix is now EMACS_INT, not int,
1340 to improve quality of diagnostics for out-of-range radices.
1341 Calculate buffer size correctly for out-of-range radices.
1342 (read1): Check for integer overflow in radices, and in
1343 read-circle numbers.
82cb60d3
PE
1344 (read_escape): Avoid int overflow.
1345 (Fload, openp, read_buffer_size, read1)
1346 (substitute_object_recurse, read_vector, read_list, map_obarray):
1347 Use ptrdiff_t, not int, for sizes.
1348 (read1): Use EMACS_INT, not int, for sizes.
20270765 1349 Check for size overflow.
8b9ac8b4 1350
7fcccf1e
PE
1351 * image.c (cache_image): Check for size arithmetic overflow.
1352
bfbbd7e7
PE
1353 * lread.c: Integer overflow issues.
1354 (saved_doc_string_size, saved_doc_string_length)
1355 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1356 Now ptrdiff_t, not int.
1357 (read1): Don't assume doc string length fits in int. Check for
1358 out-of-range doc string lengths.
1359 (read_list): Don't assume file position fits in int.
39019e54 1360 (read_escape): Check for hex character overflow.
bfbbd7e7 1361
4e323265
LL
13622011-06-22 Leo Liu <sdl.web@gmail.com>
1363
1364 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1365 Move to minibuffer.el.
1366
85fece3e
PE
13672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1368
20b84ce9 1369 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1370 The following patches are for when GLYPH_DEBUG && !XASSERT.
1371 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1372 * dispnew.c (flush_stdout):
1373 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1374 Mark as externally visible.
1375 * dispnew.c (check_window_matrix_pointers): Now static.
1376 * dispnew.c (window_to_frame_vpos):
1377 * xfns.c (unwind_create_frame):
1378 * xterm.c (x_check_font): Remove unused local.
1379 * scroll.c (CHECK_BOUNDS):
1380 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1381 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1382 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1383 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1384 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1385 Now static.
1386 (debug_method_add): Use va_list and vsprintf rather than relying
1387 on undefined behavior with wrong number of arguments.
1388 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1389 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1390 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1391 since we're not interested in debugging glyphs with old libraries.
1392 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1393 GCC 4.6.0's static checking.
1394
0766b489
PE
13952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1396
31fd4b32
PE
1397 Integer overflow and signedness fixes (Bug#8873).
1398 A few related buffer overrun fixes, too.
1399
b79e8648
PE
1400 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1401
0766b489
PE
1402 * dispextern.h (struct face.stipple):
1403 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1404 (x_bitmap_mask, x_allocate_bitmap_record)
1405 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1406 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1407 (x_create_bitmap_from_xpm_data):
1408 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1409 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1410 (.bitmaps_last):
1411 * xfaces.c (load_pixmap):
1412 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1413 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1414 (.bitmaps_last, struct x_output.icon_bitmap):
1415 Use ptrdiff_t, not int, for bitmap indexes.
1416 (x_allocate_bitmap_record): Check for size overflow.
1417 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1418
b081724f
PE
1419 Use ptrdiff_t, not int, for overlay counts.
1420 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1421 * editfns.c (overlays_around, get_pos_property):
1422 * textprop.c (get_char_property_and_overlay):
1423 * xdisp.c (next_overlay_change, note_mouse_highlight):
1424 * xfaces.c (face_at_buffer_position):
21514da7
PE
1425 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1426 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1427 (Fnext_overlay_change, Fprevious_overlay_change)
1428 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1429 Use ptrdiff_t, not int, for sizes.
21514da7 1430 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1431
3de73e5e
PE
1432 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1433
2606c57b
PE
1434 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1435 (x_session_initialize): Do not assume string length fits in int.
1436
aaafe47a
PE
1437 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1438 This is unlikely, but can occur if DPI is outlandish.
1439
2674ddc8 1440 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1441 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1442
28154962
PE
1443 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1444 * xrdb.c (magic_file_p, search_magic_path):
1445 Omit last arg SUFFIX; it was always 0. All callers changed.
1446 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1447
7de51af5
PE
1448 * xfont.c (xfont_match): Avoid need for strlen.
1449
25ed6cc3
PE
1450 * xfns.c: Don't assume strlen fits in int.
1451 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1452
4eab31dd
PE
1453 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1454 not unsigned long, as we prefer signed integers. All callers changed.
1455 Detect integer overflow in repeat count.
1456 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1457 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1458
171e2a58
PE
1459 * termcap.c: Don't assume sizes fit in int and never overflow.
1460 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1461 (gobble_line): Check for size-calculation overflow.
1462
ad39faca 1463 * minibuf.c (Fread_buffer):
6e5bb2dc 1464 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1465 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1466 Don't assume string length fits in int.
1467
52c61c22 1468 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1469 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1470
b5b8c9e5
PE
1471 * font.c: Don't assume string length fits in int.
1472 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1473 Use ptrdiff_t, not int.
ccd6111c
PE
1474 (font_intern_prop): Don't assume string length fits in int.
1475 Don't assume integer property fits in fixnum.
1476 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1477
882f0d81 1478 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1479 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1480 Reformulate so as not to need the command string.
1481 Invoke gzip -cd rather than gunzip, as it's more portable.
1482 (lock_info_type, lock_file_1, lock_file):
1483 Don't assume pid_t and time_t fit in unsigned long.
1484 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1485 (current_lock_owner): Prefer signed type for sizes.
1486 Use memcpy, not strncpy, where memcpy is what is really wanted.
1487 Don't assume (via atoi) that time_t and pid_t fit in int.
1488 Check for time_t and/or pid_t out of range, e.g., via a network share.
1489 Don't alloca where an auto var works fine.
1490
93f4cf88
PE
1491 * fileio.c: Fix some integer overflow issues.
1492 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1493 Don't assume string length fits in int.
1494 (directory_file_name): Don't assume string length fits in long.
1495 (make_temp_name): Don't assume pid fits in int, or that its print
1496 length is less than 20.
1497
f3e92b69
PE
1498 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1499
1bfdaf10
PE
1500 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1501
35016e9a
PE
1502 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1503
3d1e65a1
PE
1504 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1505 We prefer signed integers, even for size calculations.
1506
0b963a93
PE
1507 * emacs.c: Don't assume string length fits in 'int'.
1508 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1509 (main): Don't invoke strlen when not needed.
1510
573f4b54
PE
1511 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1512 (XD_DEBUG_MESSAGE): Don't waste a byte.
1513
989f33ba
PE
1514 * callproc.c (getenv_internal_1, getenv_internal)
1515 (Fgetenv_internal):
965d34eb
PE
1516 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1517
e4d29b33
PE
1518 * lread.c (invalid_syntax): Omit length argument.
1519 All uses changed. This doesn't fix a bug, but it simplifies the
1520 code away from its former Hollerith-constant appearance, and it's
1521 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1522 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1523
eb49b136
PE
1524 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1525 This didn't break anything, but it didn't help either.
1526 It's confusing to put a bogus integer in a place where the actual
1527 value does not matter.
9f62aeb1 1528 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1529 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1530
15375a22
PE
1531 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1532 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1533 implementation.
b61cc01c
PE
1534 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1535 We prefer signed types, and the value cannot exceed the EMACS_INT
1536 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1537 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1538 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1539 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1540
53b2623d
PE
1541 * indent.c (sane_tab_width): New function.
1542 (current_column, scan_for_column, Findent_to, position_indentation)
1543 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1544 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1545
51cab52b 1546 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1547
f2ed8a70
PE
1548 * lisp.h (lint_assume): New macro.
1549 * composite.c (composition_gstring_put_cache):
1550 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1551
abe80cc6
PE
1552 * editfns.c, insdel.c:
1553 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1554
b02c740e
PE
1555 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1556
ebc96716
PE
1557 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1558
b4e50fa0 1559 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1560 Use much-faster test for byte-length change.
311d5d7c 1561 Don't assume string byte-length fits in 'int'.
a4cf38e4 1562 Check that character arg fits in 'int'.
85461888 1563 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1564
c0c1ee9f
PE
1565 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1566
a498d7f4
PE
1567 * fns.c (concat): Catch string overflow earlier.
1568 Do not rely on integer wraparound.
1569
51cab52b
PE
1570 * dispextern.h (struct it.overlay_strings_charpos)
1571 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1572 * xdisp.c (forward_to_next_line_start)
1573 (back_to_previous_visible_line_start)
1574 (reseat_at_next_visible_line_start, next_element_from_buffer):
1575 Don't arbitrarily truncate the value of 'selective' to int.
1576
76031fad
PE
1577 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1578
5eb55db9
PE
1579 * composite.c: Don't truncate sizes to 'int'.
1580 (composition_gstring_p, composition_reseat_it)
1581 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1582 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1583 not EMACS_UINT, for indexes.
5eb55db9 1584
0703a717
PE
1585 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1586
d6202519
PE
1587 * buffer.c: Include <verify.h>.
1588 (struct sortvec.priority, struct sortstr.priority):
8961a454 1589 Now EMACS_INT, not int.
c20998a7 1590 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1591 (struct sortstr.size, record_overlay_string)
1592 (struct sortstrlist.size, struct sortlist.used):
1593 Don't truncate size to int.
1594 (record_overlay_string): Check for size-calculation overflow.
d6202519 1595 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1596
d5a19415
JM
15972011-06-22 Jim Meyering <meyering@redhat.com>
1598
029529ac 1599 Don't leak an XBM-image-sized buffer
d5a19415
JM
1600 * image.c (xbm_load): Free the image buffer after using it.
1601
a9041e6c
PE
16022011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1603
1604 Port to Sun C.
1605 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1606 that Sun C diagnosed.
1607 * fns.c (secure_hash): Fix pointer signedness issue.
1608 * intervals.c (static_offset_intervals): New function.
1609 (offset_intervals): Use it.
1610
7f3f739f
LL
16112011-06-21 Leo Liu <sdl.web@gmail.com>
1612
1613 * deps.mk (fns.o):
1614 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1615 sha512.h.
1616
1617 * fns.c (secure_hash): Rename from crypto_hash_function and change
1618 the first arg to accept symbols.
5b66d427 1619 (Fsecure_hash): New primitive.
7f3f739f
LL
1620 (syms_of_fns): New symbols.
1621
76147d94
DD
16222011-06-20 Deniz Dogan <deniz@dogan.se>
1623
1624 * process.c (Fset_process_buffer): Clarify return value in
1625 docstring.
1626
7d7d0045
CY
16272011-06-18 Chong Yidong <cyd@stupidchicken.com>
1628
1629 * dispnew.c (add_window_display_history): Use BVAR.
1630
1631 * xdisp.c (debug_method_add): Use BVAR.
1632 (check_window_end, dump_glyph_matrix, dump_glyph)
1633 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1634
1635 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1636 Likewise.
1637
1638 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1639 check till after the cache is created in init_frame_faces.
1640
ff2bc410
SM
16412011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1642
1643 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1644
28177add
PE
16452011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1646
dd3482fe
PE
1647 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1648 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1649 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1650
393d71f3 1651 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1652 * fileio.c (Finsert_file_contents):
1653 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1654 Remove the old (too-loose) buffer overflow checks.
1655 They weren't needed, since make_gap checks for buffer overflow.
1656 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1657 The old code merely checked for Emacs fixnum overflow, and relied
1658 on undefined (wraparound) behavior. The new code avoids undefined
1659 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1660
2e6813b0 1661 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1662 Tune. Don't use wider integers than needed. Don't use alloca.
1663 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1664
599a9e4f
PE
1665 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1666
99561444
PE
1667 * insdel.c, lisp.h (buffer_overflow): New function.
1668 (insert_from_buffer_1, replace_range, replace_range_2):
1669 * insdel.c (make_gap_larger):
1670 * editfns.c (Finsert_char):
1671 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1672
28177add
PE
1673 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1674
e69dafad
PE
16752011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1676
a7af7fde 1677 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1678
b1c46f02
PE
1679 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1680 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1681
e69dafad
PE
1682 * fileio.c: Don't assume EMACS_INT fits in off_t.
1683 (emacs_lseek): New static function.
1684 (Finsert_file_contents, Fwrite_region): Use it.
1685 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1686
566684ea
PE
1687 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1688
e6966cd6
PE
1689 * fns.c: Don't overflow int when computing a list length.
1690 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1691 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1692 truncation on 64-bit hosts. Check for QUIT every
1693 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1694 faster and is responsive enough.
1695 (Flength): Report an error instead of overflowing an integer.
1696 (Fsafe_length): Return a float if the value is not representable
1697 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1698 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1699 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1700
dd0b0efb
PE
1701 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1702 (header_size, word_size): New constants.
1703 (allocate_vectorlike): Don't check size overflow here.
1704 (allocate_vector): Check it here instead, since this is the only
1705 caller of allocate_vectorlike that could cause overflow.
1706 Check that the new vector's length is representable as a fixnum.
1707
86fe5cfe
PE
1708 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1709 The previous code was bogus. For example, next_almost_prime (32)
1710 returned 39, which is undesirable as it is a multiple of 3; and
1711 next_almost_prime (24) returned 25, which is a multiple of 5 so
1712 why was the code bothering to check for multiples of 7?
1713
80e88859
PE
1714 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1715
4a2f0ad6
PE
1716 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1717
f66c7cf8
PE
1718 Variadic C functions now count arguments with ptrdiff_t.
1719 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1720 Back then I didn't know that the Emacs coding style prefers signed int.
1721 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1722 were being counted with int, which may truncate counts on 64-bit
1723 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1724 * lisp.h (struct Lisp_Subr.function.aMANY)
1725 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1726 Arg counts are now ptrdiff_t, not size_t.
1727 All variadic functions and their callers changed accordingly.
1728 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1729 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1730 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1731 * callint.c (Fcall_interactively): Check arg count for overflow,
1732 to avoid potential buffer overrun. Use signed char, not 'int',
1733 for 'varies' array, so that we needn't bother to check its size
1734 calculation for overflow.
1735 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1736 * eval.c (apply_lambda):
1737 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1738 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1739 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1740
a1759b76
PE
1741 * callint.c (Fcall_interactively): Don't use index var as event count.
1742
d96be9fc
PE
1743 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1744 * mem-limits.h (SIZE): Remove; no longer used.
1745
a690a978 1746 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1747
578c21e6
PE
1748 Remove unnecessary casts.
1749 * xterm.c (x_term_init):
1750 * xfns.c (x_set_border_pixel):
1751 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1752 These aren't needed now that we assume ANSI C.
1753
96f53c6c
PE
1754 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1755 It's more likely to cause problems (due to unsigned overflow)
1756 than to cure them.
1757
83c77d31
PE
1758 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1759
ee2079f1
PE
1760 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1761
6da65536
PE
1762 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1763
7147c4a4
PE
1764 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1765
193e32d9
PE
1766 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1767
e5533da6
PE
1768 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1769
9910e595
PE
1770 GLYPH_CODE_FACE returns EMACS_INT, not int.
1771 * dispextern.h (merge_faces):
1772 * xfaces.c (merge_faces):
01103c44
PE
1773 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1774 Don't assume EMACS_INT fits in int.
9910e595 1775
2638320e
PE
1776 * character.h (CHAR_VALID_P): Remove unused parameter.
1777 * fontset.c, lisp.h, xdisp.c: All uses changed.
1778
045eb8d9
PE
1779 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1780
c1f134b5
PE
1781 * fns.c (concat): Minor tuning based on overflow analysis.
1782 This doesn't fix any bugs. Use int to hold character, instead
1783 of constantly refetching from Emacs object. Use XFASTINT, not
1784 XINT, for value known to be a character. Don't bother comparing
1785 a single byte to 0400, as it's always less.
1786
395fcb93 1787 * floatfns.c (Fexpt):
327eeec8
PE
1788 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1789
abbd3d23
PE
1790 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1791 for characters.
1792
684a03ef
PE
1793 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1794
0fed43f3
PE
1795 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1796 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1797 incorrectly succeed when S was a string, because 4294967386 was
1798 truncated before it was used.
1799
8fd02eb7
PE
1800 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1801 Otherwise, an out-of-range integer could cause undefined behavior
1802 on a 64-bit host.
1803
f8c86b69
PE
1804 * composite.c: Use int, not EMACS_INT, for characters.
1805 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1806 EMACS_INT, for values that are known to be in character range.
1807 This doesn't fix any bugs but is the usual style inside Emacs and
1808 may generate better code on 32-bit machines.
1809
34206dd2
PE
1810 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1811 This is for reasons similar to the recent CHAR_STRING fix.
1812 * charset.c (Fencode_char): Check that character arg is actually
1813 a character. Pass an int to ENCODE_CHAR.
1814 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1815 wider than 'int', as a compile-time check to prevent future regressions
1816 in this area.
1817
c5958d4c 1818 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1819
1820 Make sure a 64-bit char is never passed to CHAR_STRING.
1821 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1822 by silently ignoring the top 32 bits, allowing some values
1823 that were far too large to be valid characters.
1824 * character.h: Include <verify.h>.
1825 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1826 arguments are no wider than unsigned, as a compile-time check
1827 to prevent future regressions in this area.
1828 * data.c (Faset):
01103c44 1829 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1830 (Fsubst_char_in_region):
1831 * fns.c (concat):
1832 * xdisp.c (decode_mode_spec_coding):
1833 Adjust to CHAR_STRING's new requirement.
1834 * editfns.c (Finsert_char, Fsubst_char_in_region):
1835 * fns.c (concat): Check that character args are actually
1836 characters. Without this test, these functions did the wrong
1837 thing with wildly out-of-range values on 64-bit hosts.
1838
d37ca623
PE
1839 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1840 These casts should not be needed on 32-bit hosts, either.
1841 * keyboard.c (read_char):
1842 * lread.c (Fload): Remove casts to unsigned.
1843
ea204efb
PE
1844 * lisp.h (UNSIGNED_CMP): New macro.
1845 This fixes comparison bugs on 64-bit hosts.
1846 (ASCII_CHAR_P): Use it.
1847 * casefiddle.c (casify_object):
01103c44 1848 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1849 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1850 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1851 * dispextern.h (FACE_FROM_ID):
1852 * keyboard.c (read_char): Use UNSIGNED_CMP.
1853
41cb286c
PE
1854 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1855 not to EMACS_INT, to avoid GCC warning.
1856
4a1b9832
PE
1857 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1858
55daad71
PE
1859 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1860 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1861 isn't needed on 32-bit machines.
8f95c75c 1862
01103c44
PE
1863 * buffer.c (Fgenerate_new_buffer_name):
1864 Use EMACS_INT for count, not int.
0ceccced 1865 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1866
1867 * data.c (Qcompiled_function): Now static.
1868
c6f072e7
PE
1869 * window.c (window_body_lines): Now static.
1870
20ce5912
PE
1871 * image.c (gif_load): Rename local to avoid shadowing.
1872
9c4c5f81
PE
1873 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1874 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1875 * alloc.c (make_save_value): Integer argument is now of type
1876 ptrdiff_t, not int.
1877 (mark_object): Use ptrdiff_t, not int.
1878 * lisp.h (pD): New macro.
1879 * print.c (print_object): Use it.
1880
c0c5c8ae
PE
1881 * alloc.c: Use EMACS_INT, not int, to count objects.
1882 (total_conses, total_markers, total_symbols, total_vector_size)
1883 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1884 (total_free_floats, total_floats, total_free_intervals)
1885 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1886 Now EMACS_INT, not int. All uses changed.
1887 (Fgarbage_collect): Compute overall total using a double, so that
1888 integer overflow is less likely to be a problem. Check for overflow
1889 when converting back to an integer.
5a25e253
PE
1890 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1891 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1892 These were 'int' variables that could overflow on 64-bit hosts;
1893 they were never used, so remove them instead of repairing them.
211a0b2a 1894 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1895 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1896 Previously, this ceilinged at INT_MAX, but that doesn't work on
1897 64-bit machines.
e46bb31a 1898 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1899
c78baabf 1900 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1901 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1902 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1903 when a (possibly-narrower) signed value would do just as well.
1904 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1905
c9d624c6
PE
1906 * alloc.c: Catch some string size overflows that we were missing.
1907 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1908 for convenience in STRING_BYTES_MAX.
1909 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1910 The definition here is exact; the one in lisp.h was approximate.
1911 (allocate_string_data): Check for string overflow. This catches
1912 some instances we weren't catching before. Also, it catches
1913 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1914 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1915 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1916
c9d624c6
PE
1917 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1918 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1919 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1920
353032ce
PE
1921 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1922
2bccce07
PE
1923 * alloc.c (Fmake_string): Check for out-of-range init.
1924
0ac30604
SM
19252011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1926
1927 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1928
c195f2de
JD
19292011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1930
1931 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1932 xg_get_default_scrollbar_width.
1933
1934 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1935 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1936 (style_changed_cb): Call update_theme_scrollbar_width and call
1937 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1938 all frames (Bug#8505).
1939 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1940 Call gtk_window_set_resizable if HAVE_GTK3.
1941 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1942 and height if HAVE_GTK3 (Bug#8505).
1943 (scroll_bar_width_for_theme): New variable.
1944 (update_theme_scrollbar_width): New function.
1945 (xg_get_default_scrollbar_width): Move code to
1946 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1947 (xg_initialize): Call update_theme_scrollbar_width.
1948
1949 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1950
1951 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1952
e10ac9f1
MR
19532011-06-12 Martin Rudalics <rudalics@gmx.at>
1954
1955 * frame.c (make_frame): Call other_buffer_safely instead of
1956 other_buffer.
1957
1958 * window.c (temp_output_buffer_show): Call display_buffer with
1959 second argument Vtemp_buffer_show_specifiers and reset latter
1960 immediately after the call.
1961 (Vtemp_buffer_show_specifiers): New variable.
1962 (auto_window_vscroll_p, next_screen_context_lines)
1963 (Vscroll_preserve_screen_position): Remove leading asterisks from
1964 doc-strings.
1965
2d3c217e 19662011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1967
7b7f97e8 1968 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1969 * buffer.c (Qclone_number): Remove for now, as it's unused.
1970 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1971 (record_buffer): Remove unused local.
1972 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1973 (set_frame_buffer_list): Remove; unused.
1974 * frame.h (other_visible_frames): Remove decl.
1975 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1976 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1977 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1978 if HAVE_GPM.
1979 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1980 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1981 Define only if HAVE_GPM.
1982 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1983 (update_hints_inhibit): Remove; never set. All uses removed.
1984 * widgetprv.h (emacsFrameClassRec): Remove decl.
1985 * window.c (delete_deletable_window): Now returns void, since it
1986 wasn't returning anything.
1987 (compare_window_configurations): Remove unused locals.
1988 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1989 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1990 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1991 the same widths as pointers. This follows up on the 2011-05-06 patch.
1992 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1993 * xterm.h: Likewise.
1994 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1995
1384b89e
JB
19962011-06-12 Juanma Barranquero <lekktu@gmail.com>
1997
1998 * makefile.w32-in: Update dependencies.
1999 (LISP_H): Add lib/intprops.h.
2000
1100a63c
CY
20012011-06-11 Chong Yidong <cyd@stupidchicken.com>
2002
2003 * image.c (gif_load): Add animation frame delay to the metadata.
2004 (syms_of_image): Use DEFSYM. New symbol `delay'.
2005
6198ccd0
MR
20062011-06-11 Martin Rudalics <rudalics@gmx.at>
2007
2008 * window.c (delete_deletable_window): Re-add.
2009 (Fset_window_configuration): Rewrite to handle dead buffers and
2010 consequently deletable windows.
2011 (window_tree, Fwindow_tree): Remove. Supply functionality in
2012 window.el.
2013 (compare_window_configurations): Simplify code.
2014
b6e3633c
AS
20152011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2016
1ab0dee5
AS
2017 * image.c (imagemagick_load_image): Fix type mismatch.
2018 (Fimagemagick_types): Likewise.
2019
b6e3633c
AS
2020 * window.h (replace_buffer_in_windows): Declare.
2021
9397e56f
MR
20222011-06-11 Martin Rudalics <rudalics@gmx.at>
2023
2024 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2025 Qclone_number. Remove external declaration of Qdelete_window.
2026 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2027 code.
2028 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2029 Qbuffer_list_update_hook if allowed.
2030 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2031 buffer list implementation.
2032 (other_buffer_safely): New function.
2033 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2034 calls to replace_buffer_in_windows and
2035 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2036 if allowed.
2037 (record_buffer): Inhibit quitting and rewrite using quittable
2038 functions. Run Qbuffer_list_update_hook if allowed.
2039 (Frecord_buffer, Funrecord_buffer): New functions.
2040 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2041 switch-to-buffer to window.el.
2042 (bury-buffer): Move to window.el.
2043 (Vbuffer_list_update_hook): New variable.
2044
2045 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2046 section.
2047
2048 * window.h (resize_frame_windows): Move up in code.
2049 (Fwindow_frame): Remove EXFUN.
2050 (replace_buffer_in_all_windows): Remove prototype.
2051 (replace_buffer_in_windows_safely): Add prototype.
2052
2053 * window.c: Declare Qdelete_window static again. Move down
2054 declaration of select_count.
2055 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2056 (Fother_window): Move to window.el.
2057 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2058 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2059 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2060 window.el.
2061 (replace_buffer_in_windows): Implement by calling
2062 Qreplace_buffer_in_windows.
2063 (replace_buffer_in_all_windows): Remove with some functionality
2064 moved into replace_buffer_in_windows_safely.
2065 (replace_buffer_in_windows_safely): New function.
2066 (select_window_norecord, select_frame_norecord): Move in front
2067 of run_window_configuration_change_hook. Remove now obsolete
2068 declarations.
2069 (Fset_window_buffer): Rewrite doc-string. Call
2070 Qrecord_window_buffer.
2071 (keys_of_window): Move binding for other-window to window.el.
2072
b50691aa
CY
20732011-06-11 Chong Yidong <cyd@stupidchicken.com>
2074
2075 * dispextern.h (struct image): Replace data member, whose int_val
2076 and ptr_val fields were not used by anything, with a single
2077 lisp_val object.
2078
2079 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2080 (gif_clear_image, gif_load, imagemagick_load_image)
2081 (gs_clear_image, gs_load): Callers changed.
2082
3f754b86
PE
20832011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2084
cca69397
PE
2085 * buffer.h: Include <time.h>, for time_t.
2086 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2087
109e28d0
PE
2088 Fix minor problems found by static checking.
2089
60737f02
PE
2090 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2091
4b66faf3
PE
2092 Make identifiers static if they are not used in other modules.
2093 * data.c (Qcompiled_function, Qframe, Qvector):
2094 * image.c (QimageMagick, Qsvg):
2095 * minibuf.c (Qmetadata):
2096 * window.c (resize_window_check, resize_root_window): Now static.
2097 * window.h (resize_window_check, resize_root_window): Remove decls.
2098
109e28d0
PE
2099 * window.c (window_deletion_count, delete_deletable_window):
2100 Remove; unused.
46a4ce9e
PE
2101 (window_body_lines): Now static.
2102 (Fdelete_other_windows_internal): Mark vars as initialized.
2103 Make sure 'resize_failed' is initialized.
2104 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2105 (resize_window_apply): Remove unused local.
2106 * window.h (delete_deletable_window): Remove decl.
2107
109e28d0 2108 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2109 (imagemagick_load_image): Fix pointer signedness problem by changing
2110 last arg from unsigned char * to char *. All uses changed.
2111 Also, fix a local for similar reasons.
2112 Remove unused locals. Remove locals to avoid shadowing.
2113 (fn_rsvg_handle_free): Remove; unused.
2114 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2115 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2116
3f754b86
PE
2117 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2118
2547adb1
CY
21192011-06-10 Chong Yidong <cyd@stupidchicken.com>
2120
2121 * image.c (gif_load): Fix omitted cast error introduced by
2122 2011-06-06 change.
2123
2c8e37d4
MR
21242011-06-10 Martin Rudalics <rudalics@gmx.at>
2125
2126 * window.h (resize_proportionally, orig_total_lines)
2127 (orig_top_line): Remove from window structure.
2128 (set_window_height, set_window_width, change_window_heights)
2129 (Fdelete_window): Remove prototypes.
2130 (resize_frame_windows): Remove duplicate declaration.
2131
440a42e3
EZ
21322011-06-10 Eli Zaretskii <eliz@gnu.org>
2133
2134 * window.h (resize_frame_windows, resize_window_check)
2135 (delete_deletable_window, resize_root_window)
2136 (resize_frame_windows): Declare prototypes.
2137
2138 * window.c (resize_window_apply): Make definition be "static" to
2139 match the prototype.
2140
562dd5e9
MR
21412011-06-10 Martin Rudalics <rudalics@gmx.at>
2142
2143 * window.c: Remove declarations of Qwindow_size_fixed,
2144 window_min_size_1, window_min_size_2, window_min_size,
2145 size_window, window_fixed_size_p, enlarge_window, delete_window.
2146 Remove static from declaration of Qdelete_window, it's
2147 temporarily needed by Fbury_buffer.
2148 (replace_window): Don't assign orig_top_line and
2149 orig_total_lines.
2150 (Fdelete_window, delete_window): Remove. Window deletion is
2151 handled by window.el.
2152 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2153 Fdelete_window calls with calls to Qdelete_window.
2154 (Fdelete_other_windows): Remove. Deleting other windows is
2155 handled by window.el.
2156 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2157 handled in window.el.
2158 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2159 Window minimum sizes are handled in window.el.
2160 (shrink_windows, size_window, set_window_height)
2161 (set_window_width, change_window_heights, window_height)
2162 (window_width, CURBEG, CURSIZE, enlarge_window)
2163 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2164 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2165 handled in window.el.
2166 (make_dummy_parent): Rename to make_parent_window and give it a
2167 second argument horflag.
2168 (make_window): Don't set resize_proportionally any more.
2169 (Fsplit_window): Remove. Windows are split in window.el.
2170 (save_restore_action, save_restore_orig_size)
2171 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2172 Resize mini windows in window.el.
2173 (grow_mini_window, shrink_mini_window): Implement by calling
2174 Qresize_root_window_vertically, resize_window_check and
2175 resize_window_apply.
2176 (saved_window, Fset_window_configuration, save_window_save): Do
2177 not handle orig_top_line, orig_total_lines, and
2178 resize_proportionally.
2179 (window_min_height, window_min_width): Move to window.el.
2180 (keys_of_window): Move bindings for delete-other-windows,
2181 split-window, delete-window and enlarge-window to window.el.
2182
2183 * buffer.c: Temporarily extern Qdelete_window.
2184 (Fbury_buffer): Temporarily call Qdelete_window instead of
2185 Fdelete_window (Fbury_buffer will move to window.el soon).
2186
2187 * frame.c (set_menu_bar_lines_1): Remove code handling
2188 orig_top_line and orig_total_lines.
2189
2190 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2191 set_window_height but set heights directly.
2192 (change_frame_size_1): Use resize_frame_windows.
2193
2194 * xdisp.c (init_xdisp): Don't use set_window_height but set
2195 heights directly.
2196
2197 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2198 resize_frame_windows instead of change_window_heights and run
2199 run_window_configuration_change_hook.
2200
2201 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2202 instead of change_window_heights and run
2203 run_window_configuration_change_hook.
2204
1a13852e
MR
22052011-06-09 Martin Rudalics <rudalics@gmx.at>
2206
2207 * window.c (replace_window): Rename second argument REPLACEMENT to
2208 NEW. New third argument SETFLAG. Rewrite.
2209 (delete_window, make_dummy_parent): Call replace_window with
2210 third argument 1.
2211 (window_list_1): Move down in code.
2212 (run_window_configuration_change_hook): Move set_buffer part
2213 before select_frame_norecord part in order to unwind correctly.
2214 Rename count1 to count.
2215 (recombine_windows, delete_deletable_window, resize_root_window)
2216 (Fdelete_other_windows_internal)
2217 (Frun_window_configuration_change_hook, make_parent_window)
2218 (resize_window_check, resize_window_apply, Fresize_window_apply)
2219 (resize_frame_windows, Fsplit_window_internal)
2220 (Fdelete_window_internal, Fresize_mini_window_internal): New
2221 functions.
2222 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2223
f3d1777e
MR
22242011-06-08 Martin Rudalics <rudalics@gmx.at>
2225
496e208e
MR
2226 * window.h (window): Add some new members to window structure -
2227 normal_lines, normal_cols, new_total, new_normal, clone_number,
2228 splits, nest, prev_buffers, next_buffers.
2229 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2230 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2231
f3d1777e
MR
2232 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2233 Remove.
496e208e
MR
2234 (make_dummy_parent): Set new members of windows structure.
2235 (make_window): Move down in code. Handle new members of window
2236 structure.
2237 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2238 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2239 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2240 (Fset_window_prev_buffers, Fwindow_next_buffers)
2241 (Fset_window_next_buffers, Fset_window_clone_number): New
2242 functions.
2243 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2244 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2245 Doc-string fixes.
2246 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2247 Argument WINDOW can be now internal window too.
2248 (Fwindow_use_time): Move up in code.
2249 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2250 Rewrite doc-string.
2251 (Fset_window_configuration, saved_window)
2252 (Fcurrent_window_configuration, save_window_save): Handle new
2253 members of window structure.
b9e809c2
MR
2254 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2255 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2256 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2257 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2258 Qget_mru_window, Qresize_root_window,
2259 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2260 Qauto_buffer_name; staticpro them.
f3d1777e 2261
abde8f8c
MR
22622011-06-07 Martin Rudalics <rudalics@gmx.at>
2263
2264 * window.c (Fwindow_total_size, Fwindow_left_column)
2265 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2266 (Fwindow_list_1): New functions.
2267 (window_box_text_cols): Replace with window_body_cols.
2268 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2269 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2270 (delete_window, Fset_window_configuration): Call
2271 delete_all_subwindows with window as argument.
2272 (delete_all_subwindows): Take a window as argument and not a
2273 structure. Rewrite.
190b47e6
MR
2274 (window_loop): Remove handling of GET_LRU_WINDOW and
2275 GET_LARGEST_WINDOW.
2276 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2277
2278 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2279 window_box_text_cols. delete_all_subwindows now takes a
2280 Lisp_Object as argument.
abde8f8c
MR
2281
2282 * indent.c (compute_motion, Fcompute_motion): Use
2283 window_body_cols instead of window_box_text_cols.
2284
fa8a67e6
MR
2285 * frame.c (delete_frame): Call delete_all_subwindows with root
2286 window as argument.
2287
a54e3482
DC
22882011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2289
2290 * fns.c (Fputhash): Document return value.
2291
60002bf5
CY
22922011-06-06 Chong Yidong <cyd@stupidchicken.com>
2293
2294 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2295
0c671da6 22962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2297
b862a52a 2298 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2299
be44ca6c
PE
2300 Check for overflow when converting integer to cons and back.
2301 * charset.c (Fdefine_charset_internal, Fdecode_char):
2302 Use cons_to_unsigned to catch overflow.
2303 (Fencode_char): Use INTEGER_TO_CONS.
2304 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2305 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2306 * data.c (long_to_cons, cons_to_long): Remove.
2307 (cons_to_unsigned, cons_to_signed): New functions.
2308 These signal an error for invalid or out-of-range values.
2309 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2310 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2311 * font.c (Ffont_variation_glyphs):
2312 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2313 * lisp.h: Include <intprops.h>.
2314 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2315 (cons_to_signed, cons_to_unsigned): New decls.
2316 (long_to_cons, cons_to_long): Remove decls.
2317 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2318 (Fprimitive_undo): Use CONS_TO_INTEGER.
2319 * xfns.c (Fx_window_property): Likewise.
2320 * xselect.c: Include <limits.h>.
2321 (x_own_selection, selection_data_to_lisp_data):
2322 Use INTEGER_TO_CONS.
2323 (x_handle_selection_request, x_handle_selection_clear)
2324 (x_get_foreign_selection, Fx_disown_selection_internal)
2325 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2326 (lisp_data_to_selection_data): Use cons_to_unsigned.
2327 (x_fill_property_data): Use cons_to_signed.
2328 Report values out of range.
2329
d1f3d2af
PE
2330 Check for buffer and string overflow more precisely.
2331 * buffer.h (BUF_BYTES_MAX): New macro.
2332 * lisp.h (STRING_BYTES_MAX): New macro.
2333 * alloc.c (Fmake_string):
2334 * character.c (string_escape_byte8):
2335 * coding.c (coding_alloc_by_realloc):
2336 * doprnt.c (doprnt):
2337 * editfns.c (Fformat):
2338 * eval.c (verror):
2339 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2340 since they may not be the same number.
2341 * editfns.c (Finsert_char):
2342 * fileio.c (Finsert_file_contents):
2343 Likewise for BUF_BYTES_MAX.
2344
dd52fcea
PE
2345 * image.c: Use ptrdiff_t, not int, for sizes.
2346 (slurp_file): Switch from int to ptrdiff_t.
2347 All uses changed.
2348 (slurp_file): Check that file size fits in both size_t (for
2349 malloc) and ptrdiff_t (for sanity and safety).
2350
7f9bbdbb
PE
2351 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2352 if b->modtime has its maximal value.
2353
dfe18f82
PE
2354 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2355
84acfcf0
PE
2356 Don't assume time_t can fit into int.
2357 * buffer.h (struct buffer.modtime): Now time_t, not int.
2358 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2359 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2360
ccd9a01a
PE
2361 Minor fixes for signed vs unsigned integers.
2362 * character.h (MAYBE_UNIFY_CHAR):
2363 * charset.c (maybe_unify_char):
2364 * keyboard.c (read_char, reorder_modifiers):
2365 XINT -> XFASTINT, since the integer must be nonnegative.
2366 * ftfont.c (ftfont_spec_pattern):
2367 * keymap.c (access_keymap, silly_event_symbol_error):
2368 XUINT -> XFASTINT, since the integer must be nonnegative.
2369 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2370 since it makes no difference and we prefer signed.
2371 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2372 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2373 nonnegative.
2374
d6d100dd
SM
23752011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2376
2377 * window.h (Fwindow_frame): Declare.
2378
2b6148e4
PE
23792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2380
2381 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2382 (SPARE_MEMORY): Always define.
2383 (LARGE_REQUEST): Remove.
2384 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2385
f230ecc9
MR
23862011-06-06 Martin Rudalics <rudalics@gmx.at>
2387
727e958e
MR
2388 * lisp.h: Move EXFUNS for Fframe_root_window,
2389 Fframe_first_window and Fset_frame_selected_window to window.h.
2390
2391 * window.h: Move EXFUNS for Fframe_root_window,
2392 Fframe_first_window and Fset_frame_selected_window here from
2393 lisp.h.
2394
2395 * frame.c (Fwindow_frame, Fframe_first_window)
2396 (Fframe_root_window, Fframe_selected_window)
2397 (Fset_frame_selected_window): Move to window.c.
2398 (Factive_minibuffer_window): Move to minibuf.c.
2399 (Fother_visible_frames_p): New function.
2400
2401 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2402
f230ecc9
MR
2403 * window.c (decode_window, decode_any_window): Move up in code.
2404 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2405 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2406 (Fwindow_buffer): Move up and rewrite doc-string.
2407 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2408 (Fwindow_prev): New functions.
727e958e
MR
2409 (Fwindow_frame): Move here from frame.c. Accept any window as
2410 argument.
2411 (Fframe_root_window, Fframe_first_window)
2412 (Fframe_selected_window): Move here from frame.c. Accept frame
2413 or arbitrary window as argument. Update doc-strings.
2414 (Fminibuffer_window): Move up in code.
2415 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2416 (Fset_frame_selected_window): Move here from frame.c.
2417 Marginal rewrite.
727e958e
MR
2418 (Fselected_window, select_window, Fselect_window): Move up in
2419 code. Minor doc-string fixes.
f230ecc9 2420
4d09bcf6
PE
24212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2424 Do not assume that spare memory exists; that assumption is valid
2425 only if SYSTEM_MALLOC.
2426 (LARGE_REQUEST): New macro, so that the issue of large requests
2427 is separated from the issue of spare memory.
2428
810928a2
AS
24292011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2430
172418ad
AS
2431 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2432 format. (Bug#8806)
2433
43f862f7
AS
2434 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2435
810928a2
AS
2436 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2437 before statements.
2438
a059fe24
JD
24392011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2440
2441 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2442
2443 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2444
2445 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2446 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2447
989bf368
JB
24482011-06-05 Juanma Barranquero <lekktu@gmail.com>
2449
2450 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2451
4b80f674
CY
24522011-06-04 Chong Yidong <cyd@stupidchicken.com>
2453
2454 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2455 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2456 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2457 New error handlers.
4b80f674
CY
2458 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2459 Obey Vx_select_enable_clipboard_manager. Catch errors in
2460 x_clipboard_manager_save (Bug#8779).
2461 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2462 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2463
99a33b77 24642011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2465
2466 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2467
99a33b77 24682011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2469
2470 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2471 in the current matrix if keep_current_p is non-zero.
2472
8264569d
EZ
24732011-06-04 Eli Zaretskii <eliz@gnu.org>
2474
2475 * bidi.c (bidi_level_of_next_char): Fix last change.
2476
57f97249
EZ
24772011-06-03 Eli Zaretskii <eliz@gnu.org>
2478
fec2107c 2479 Support bidi reordering of text covered by display properties.
57f97249 2480
fec2107c
EZ
2481 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2482 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2483 (bidi_cache_search, bidi_cache_iterator_state)
2484 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2485 (bidi_level_of_next_char, bidi_move_to_visually_next):
2486 Support character positions inside a run of characters covered by a
fec2107c
EZ
2487 display string.
2488 (bidi_paragraph_init, bidi_resolve_explicit_1)
2489 (bidi_level_of_next_char): Call bidi_fetch_char and
2490 bidi_fetch_char_advance instead of FETCH_CHAR and
2491 FETCH_CHAR_ADVANCE.
2492 (bidi_init_it): Initialize new members.
2493 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2494 definitions.
2495 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2496 instead of using explicit *_CHAR codes.
d6d100dd
SM
2497 (bidi_resolve_explicit, bidi_resolve_weak):
2498 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2499 bidirectional text is supported only in multibyte buffers.
2500 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2501 it to initialize the frame_window_p member of struct bidi_it.
2502 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2503 (bidi_resolve_explicit, bidi_resolve_weak)
2504 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2505 bidi_it->nchars is non-positive.
2506 (bidi_level_of_next_char): Don't try to lookup the cache for the
2507 next/previous character if nothing is cached there yet, or if we
2508 were just reseat()'ed to a new position.
c40e2fb2 2509
0e14fe90
EZ
2510 * xdisp.c (set_cursor_from_row): Set start and stop points
2511 according to the row's direction when priming the loop that looks
2512 for the glyph on which to display cursor.
2513 (single_display_spec_intangible_p): Function deleted.
2514 (display_prop_intangible_p): Reimplement to call
2515 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2516 Accept 3 additional arguments needed by handle_display_spec.
2517 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2518 values: lists, `(when COND...)' forms, etc.
2519 (single_display_spec_string_p): Support property values that are
2520 lists with the argument STRING its top-level element.
2521 (display_prop_string_p): Fix the condition for processing a
2522 property that is a list to be consistent with handle_display_spec.
fec2107c 2523 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2524 last portion of handle_display_prop.
2525 (compute_display_string_pos): Accept additional argument
2526 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2527 value of a `display' property is a "replacing spec".
2528 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2529 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2530 the display property, but just return a value indicating whether
2531 the display property will replace the characters it covers.
2532 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2533 frame_window_p members of struct bidi_it.
d6d100dd
SM
2534 (compute_display_string_pos, compute_display_string_end):
2535 New functions.
fec2107c
EZ
2536 (push_it): Accept second argument POSITION, where pop_it should
2537 jump to continue iteration.
2538 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2539
fec2107c
EZ
2540 * keyboard.c (adjust_point_for_property): Adjust the call to
2541 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2542
2543 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2544 (bidi_init_it): Update prototypes.
2545 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2546 (compute_display_string_pos, compute_display_string_end):
2547 Declare prototypes.
fec2107c
EZ
2548 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2549 EMACS_INT.
fc6f18ce 2550
40087514 25512011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2552
57f53182
PE
2553 Malloc failure behavior now depends on size of allocation.
2554 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2555 * lisp.h: Change signatures accordingly.
2556 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2557 All callers changed. (Bug#8762)
2558
2559 * gnutls.c: Use Emacs's memory allocators.
2560 Without this change, the gnutls library would invoke malloc etc.
2561 directly, which causes problems on non-SYNC_INPUT hosts, and which
2562 runs afoul of improving memory_full behavior. (Bug#8761)
2563 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2564 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2565 xfree instead of the default malloc, realloc, free.
2566 (Fgnutls_boot): No need to check for memory allocation failure,
2567 since xmalloc does that for us.
2568
ac32cd99 2569 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2570 * category.c (hash_get_category_set):
2571 * ccl.c (ccl_driver):
2572 * charset.c (Fdefine_charset_internal):
2573 * charset.h (struct charset.hash_index):
2574 * composite.c (get_composition_id, gstring_lookup_cache)
2575 (composition_gstring_put_cache):
2576 * composite.h (struct composition.hash_index):
2577 * dispextern.h (struct image.hash):
2578 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2579 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2580 (hashfn_equal, hashfn_user_defined, make_hash_table)
2581 (maybe_resize_hash_table, hash_lookup, hash_put)
2582 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2583 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2584 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2585 * image.c (make_image, search_image_cache, lookup_image)
2586 (xpm_put_color_table_h):
2587 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2588 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2589 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2590 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2591 * alloc.c (allocate_vectorlike):
2592 Check for overflow in vector size calculations.
2593 * ccl.c (ccl_driver):
2594 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2595 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2596 need to be updated by these changes.
40087514
PE
2597 * fns.c (make_hash_table, maybe_resize_hash_table):
2598 Check for integer overflow with large hash tables.
0de4bb68
PE
2599 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2600 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2601 (SXHASH_REDUCE): New macro.
2602 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2603 Use it instead of discarding useful hash info with large hash values.
2604 (sxhash_float): New function.
2605 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2606 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2607 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2608 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2609 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2610 Adjust signatures to match updated version of code.
2611 (consing_since_gc): Now EMACS_INT, since a single hash table can
2612 use more than INT_MAX bytes.
2613
698d32e2
DN
26142011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2615
2616 Make it possible to build with GCC-4.6+ -O2 -flto.
2617
2618 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2619
fd6fa53f
SM
26202011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2621
2622 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2623 Call minibuffer-inactive-mode.
2624
864db017
JB
26252011-05-31 Juanma Barranquero <lekktu@gmail.com>
2626
2627 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2628 Update dependencies.
2629
2ad0baf4
DN
26302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2631
2632 * data.c (init_data): Remove code for UTS, this system is not
2633 supported anymore.
2634
4fcc2638
DN
26352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2636
2637 Don't force ./temacs to start in terminal mode.
2638
2639 * frame.c (make_initial_frame): Initialize faces in all cases, not
2640 only when CANNOT_DUMP is defined.
2641 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2642
c56e0fd5
DN
26432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2644
2645 * dispnew.c (add_window_display_history): Use const for the string
2646 pointer. Remove declaration, not needed.
2647
333d54da 26482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2649
55d4c1b2 2650 Use 'inline', not 'INLINE'.
333d54da 2651 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2652 * alloc.c, fontset.c (INLINE): Remove.
2653 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2654 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2655 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2656 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2657 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2658
738db178
DN
26592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2660
2661 Make it possible to run ./temacs.
2662
2663 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2664 syms_of_callproc does the same thing. Remove test for
2665 "initialized", do it in the caller.
2666 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2667
620c53a6
SM
26682011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2669
2670 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2671 (read_minibuf): Use get_minibuffer.
2672 (syms_of_minibuf): Use DEFSYM.
2673 (Qmetadata): New var.
2674 * data.c (Qbuffer): Don't make it static.
2675 (syms_of_data): Use DEFSYM.
2676
e003a292
PE
26772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2678
2679 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2680 (CCL_CODE_MIN): New macro.
2681
ed008a6d
PE
26822011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2683
3687c2ef
PE
2684 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2685
ed008a6d
PE
2686 * eval.c (Qdebug): Now static.
2687 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2688 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2689 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2690
d66c4c7c
CY
26912011-05-29 Chong Yidong <cyd@stupidchicken.com>
2692
2693 * image.c: Various fixes to ImageMagick code comments.
2694 (Fimagemagick_types): Doc fix.
2695
5fbc2025
PE
26962011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2697
0196f88a
PE
2698 Minor fixes prompted by GCC 4.6.0 warnings.
2699
2700 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2701
5fbc2025
PE
2702 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2703 (x_clipboard_manager_save_all): Move extern decl to ...
2704 * xterm.h: ... here, so that it can be checked for consistency.
2705
1dd3c2d9
CY
27062011-05-29 Chong Yidong <cyd@stupidchicken.com>
2707
2708 * xselect.c (x_clipboard_manager_save_frame)
2709 (x_clipboard_manager_save_all): New functions.
2710 (Fx_clipboard_manager_save): Lisp function deleted.
2711
2712 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2713 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2714
2715 * xterm.h: Update prototype.
2716
5ba6571d
WX
27172011-05-28 William Xu <william.xwl@gmail.com>
2718
2719 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2720 exiting (Bug#8239).
2721
3eaff834
JM
27222011-05-28 Jim Meyering <meyering@redhat.com>
2723
e1900994 2724 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2725 * fns.c (to_uchar): Define.
2726 (crypto_hash_function): Use it to convert some newly-signed
2727 variables to unsigned, to avoid sign-extension bugs. For example,
2728 without this change, (md5 "truc") would evaluate to
2729 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2730 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2731 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2732
0f6990a7
PE
27332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2734
2735 Integer overflow fixes.
c8a9ca5a 2736
08686060
PE
2737 * dbusbind.c: Serial number integer overflow fixes.
2738 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2739 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2740 to hold a serial number that is too large for a fixnum.
2741 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2742 Check for serial numbers out of range. Decode any serial number
59568bf0 2743 that was so large that it became a float. (Bug#8722)
08686060 2744
2d1fc3c7
PE
2745 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2746 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2747 Use XFASTINT rather than XUINT when numbers are nonnegative.
2748 (xd_append_arg, Fdbus_method_return_internal):
2749 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2750 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2751 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2752 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2753 (Bug#8722)
2d1fc3c7 2754
c8a9ca5a
PE
2755 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2756
519e1d69
PE
2757 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2758
30569699
PE
2759 ccl: add integer overflow checks
2760 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2761 (IN_INT_RANGE): New macros.
2762 (ccl_driver): Use them to check for integer overflow when
2763 decoding a CCL program. Many of the new checks are whether XINT (x)
2764 fits in int; it doesn't always, on 64-bit hosts. The new version
2765 doesn't catch all possible integer overflows, but it's an
847044ea 2766 improvement. (Bug#8719)
30569699 2767
c11285dc
PE
2768 * alloc.c (make_event_array): Use XINT, not XUINT.
2769 There's no need for unsigned here.
2770
fdccd48e
PE
2771 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2772 This follows up to the 2011-05-06 change that substituted uintptr_t
2773 for EMACS_INT. This case wasn't caught back then.
2774
37910ab2
PE
2775 Rework Fformat to avoid integer overflow issues.
2776 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2777 now (part of C89). Include <verify.h>.
2778 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2779 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2780 (Fformat): Avoid the prepass trying to compute sizes; it was only
2781 approximate and thus did not catch overflow reliably. Instead, walk
2782 through the format just once, formatting and computing sizes as we go,
2783 checking for integer overflow at every step, and allocating a larger
2784 buffer as needed. Keep track separately whether the format is
2785 multibyte. Keep only the most-recently calculated precision, rather
2786 than them all. Record whether each argument has been converted to
2787 string. Use EMACS_INT, not int, for byte and char and arg counts.
2788 Support field widths and precisions larger than INT_MAX. Avoid
2789 sprintf's undefined behavior with conversion specifications such as %#d
2790 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2791 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2792 formatting out-of-range floating point numbers with int
9173deec 2793 formats. (Bug#8668)
37910ab2 2794
2e6578fb
PE
2795 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2796
0ae6bdee
PE
2797 * data.c: Avoid integer truncation in expressions involving floats.
2798 * data.c: Include <intprops.h>.
2799 (arith_driver): When there's an integer overflow in an expression
2800 involving floating point, convert the integers to floating point
2801 so that the resulting value does not suffer from catastrophic
2802 integer truncation. For example, on a 64-bit host (* 4
2803 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2804 Do not rely on undefined behavior after integer overflow.
2805
de883a70
PE
2806 merge count_size_as_multibyte, parse_str_to_multibyte
2807 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2808 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2809 Check for integer overflow.
2810 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2811 since it's now a duplicate of the other. This is more of
2812 a character than a buffer op, so better that it's in character.c.
2813 * fns.c, print.c: Adjust to above changes.
2814
2ff916cb
PE
28152011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2816
2817 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2818
f1b54466
PE
28192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2820
fb1ac845
PE
2821 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2822 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2823 (x_clipboard_manager_save): Now static.
2824 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2825
f1b54466
PE
2826 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2827 (crypto_hash_function): Now static.
2828 Fix pointer signedness problems. Avoid unnecessary initializations.
2829
a9f737ee
CY
28302011-05-27 Chong Yidong <cyd@stupidchicken.com>
2831
2832 * termhooks.h (Vselection_alist): Make it terminal-local.
2833
2834 * terminal.c (create_terminal): Initialize it.
2835
2836 * xselect.c: Support for clipboard managers.
2837 (Vselection_alist): Move to termhooks.h as terminal-local var.
2838 (LOCAL_SELECTION): New macro.
2839 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2840 (symbol_to_x_atom): Remove gratuitous arg.
2841 (x_handle_selection_request, lisp_data_to_selection_data)
2842 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2843 (x_own_selection, x_get_local_selection, x_convert_selection):
2844 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2845 (some_frame_on_display): Delete unused function.
2846 (Fx_own_selection_internal, Fx_get_selection_internal)
2847 (Fx_disown_selection_internal, Fx_selection_owner_p)
2848 (Fx_selection_exists_p): New optional frame arg.
2849 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2850 (x_handle_selection_clear): Don't treat other terminals with the
2851 same keyboard specially. Use the terminal-local Vselection_alist.
2852 (x_clear_frame_selections): Use Frun_hook_with_args.
2853
2854 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2855
2856 * xterm.h: Add support for those atoms.
2857
e067f0c1
CY
28582011-05-26 Chong Yidong <cyd@stupidchicken.com>
2859
2860 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2861 (converted_selections, conversion_fail_tag): New global variables.
2862 (x_selection_request_lisp_error): Free the above.
2863 (x_get_local_selection): Remove unnecessary code.
2864 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2865 of converted selections stored in converted_selections.
2866 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2867 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2868 (x_convert_selection): New function.
2869 (x_handle_selection_event): Simplify.
2870 (x_get_foreign_selection): Don't ignore incoming requests while
2871 waiting for an answer; this will fail when we implement
2872 SAVE_TARGETS, and seems unnecessary anyway.
2873 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2874 (Vx_sent_selection_functions): Doc fix.
2875
0f4aebc0
LL
28762011-05-26 Leo Liu <sdl.web@gmail.com>
2877
2878 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2879
e61124cd
YM
28802011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2881
2882 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2883
2884 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2885 for fringe update if it has periodic bitmap.
ac389d0c 2886 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2887 and fringe_bitmap_periodic_p.
2888
2889 * fringe.c (get_fringe_bitmap_data): New function.
2890 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2891 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2892 row. Mark glyph row for fringe update if periodicity changed.
2893
2894 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2895 for fringe update unless it has periodic bitmap.
2896
f16d9837
KH
28972011-05-25 Kenichi Handa <handa@m17n.org>
2898
2899 * xdisp.c (get_next_display_element): Set correct it->face_id for
2900 a static composition.
2901
e1b90ef6
LL
29022011-05-24 Leo Liu <sdl.web@gmail.com>
2903
2904 * deps.mk (fns.o):
2905 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2906
2907 * fns.c (crypto_hash_function, Fsha1): New function.
2908 (Fmd5): Use crypto_hash_function.
2909 (syms_of_fns): Add Ssha1.
2910
7400048f
PE
29112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2912
2913 * gnutls.c: Remove unused macros.
2914 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2915 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2916 Remove macros that are defined and never used.
2917 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2918
abb71cf4
CY
29192011-05-22 Chong Yidong <cyd@stupidchicken.com>
2920
2921 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2922 (Fx_get_selection_internal): Minor cleanup.
2923 (Fx_own_selection_internal): Rename arguments for consistency with
2924 select.el.
2925
6307db39
PE
29262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2927
2928 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2929
f3d4e0a4
CY
29302011-05-22 Chong Yidong <cyd@stupidchicken.com>
2931
2932 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2933
4d8ade89
YM
29342011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2935
2936 * dispnew.c (scrolling_window): Don't exclude the case that the
2937 last enabled row in the desired matrix touches the bottom boundary.
2938
32078c8d
GM
29392011-05-21 Glenn Morris <rgm@gnu.org>
2940
2941 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2942 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2943 and add some more files.
32078c8d 2944
7285dc67
EZ
29452011-05-20 Eli Zaretskii <eliz@gnu.org>
2946
2947 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2948 report_file_error introduced by the change from 2011-05-07.
2949
89d1bd22
PE
29502011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 * systime.h (Time): Define only if emacs is defined.
2953 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2954 where the include path doesn't have X11/X.h by default. See
2955 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2956
e23640bb 29572011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2958
2959 * composite.c (find_automatic_composition): Fix previous change.
2960
b9704ad9
GM
29612011-05-20 Glenn Morris <rgm@gnu.org>
2962
2963 * lisp.mk: New file, split from Makefile.in.
2964 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2965 (shortlisp): Remove.
2966 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2967
4a720484
GM
29682011-05-19 Glenn Morris <rgm@gnu.org>
2969
2970 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2971 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2972 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2973 (lisp): Set the order to that of loadup.el.
2974 (shortlisp): Make it a copy of $lisp.
2975 (SOME_MACHINE_LISP): Remove.
2976 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2977 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2978
a28d4396
KH
29792011-05-18 Kenichi Handa <handa@m17n.org>
2980
2981 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2982 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2983 (find_automatic_composition): Mostly rewrite for efficiency.
2984
a2b1fa8e
JB
29852011-05-18 Juanma Barranquero <lekktu@gmail.com>
2986
2987 * makefile.w32-in: Update dependencies.
2988
8e1f5610
CS
29892011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2990
2991 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2992 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2993
7025ee00 29942011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2995
cdfa6eab
PE
2996 Fix some integer overflow issues, such as string length overflow.
2997
06d6db33
PE
2998 * insdel.c (count_size_as_multibyte): Check for string overflow.
2999
2b4560a8
PE
3000 * character.c (lisp_string_width): Check for string overflow.
3001 Use EMACS_INT, not int, for string indexes and lengths; in
3002 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3003 the resulting string length overflows an EMACS_INT; instead,
3004 report a string overflow if no precision given. When checking for
3005 precision exhaustion, use a check that cannot possibly have
3006 integer overflow. (Bug#8675)
3007 * character.h (lisp_string_width): Adjust to new signature.
3008
cb93f9be
PE
3009 * alloc.c (string_overflow): New function.
3010 (Fmake_string): Use it. This doesn't change behavior, but saves
3011 a few bytes and will simplify future changes.
3012 * character.c (string_escape_byte8): Likewise.
3013 * lisp.h (string_overflow): New decl.
3014
1a1f3366
PE
3015 Fixups, following up to the user-interface timestamp change.
3016 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3017 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3018 * msdos.c (mouse_get_pos): Likewise.
3019 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3020 * w32gui.h (Time): Define by including "systime.h" rather than by
3021 declaring it ourselves. (Bug#8664)
3022
d4e3e4d3
PE
3023 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3024 * image.c (clear_image_cache): Likewise.
3025
f6a24d19
PE
3026 * term.c (term_mouse_position): Don't assume time_t wraparound.
3027
08dc5ae6
PE
3028 Be more systematic about user-interface timestamps.
3029 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3030 and sometimes 'EMACS_UINT', to represent these timestamps.
3031 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3032 This makes the code easier to follow, and makes it easier to catch
3033 integer overflow bugs such as Bug#8664.
3034 * frame.c (Fmouse_position, Fmouse_pixel_position):
3035 Use Time, not unsigned long, for user-interface timestamps.
3036 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3037 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3038 * keyboard.h (last_event_timestamp): Likewise.
3039 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3040 * menu.h (xmenu_show): Likewise.
3041 * term.c (term_mouse_position): Likewise.
3042 * termhooks.h (struct input_event.timestamp): Likewise.
3043 (struct terminal.mouse_position_hook): Likewise.
3044 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3045 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3046 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3047 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3048 what it was before.
3049 * menu.h, termhooks.h: Include "systime.h", for Time.
3050
8e55734a
PE
3051 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3052 Don't assume that the difference between two unsigned long values
3053 can fit into an integer. At this point, we know button_down_time
3054 <= event->timestamp, so the difference must be nonnegative, so
3055 there's no need to cast the result if double-click-time is
3056 nonnegative, as it should be; check that it's nonnegative, just in
3057 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3058 apart (about 25 days). (Bug#8664)
8e55734a 3059
841f1b75 3060 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3061 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3062
3e26f69c
PE
3063 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3064 that always fit in int. Use a sentinel instead of a counter, to
3065 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3066 * frame.h (struct frame): Use int for menu_bar_items_used
3067 instead of EMACS_INT, since it always fits in int.
3e26f69c 3068
5cc152c0
PE
3069 * menu.c (grow_menu_items): Check for int overflow.
3070
d89eb65e
PE
3071 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3072
5235bd3e
PE
3073 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3074 Before, the code was not consistent. These values cannot exceed
3075 2**31 - 1 so there's no need to make them unsigned.
3076 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3077 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3078 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3079 as modifiers.
3080 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3081
bc827e23
PE
3082 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3083 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3084 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3085 presumably because the widths might not match.
3086
78eb494e
PE
3087 * window.c (size_window): Avoid needless test at loop start.
3088
04f2d78b
CB
30892011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3090
3091 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3092
d2fc7e3d 30932011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3094
3095 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3096
d2fc7e3d 30972011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3098
3099 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3100 `width' to `bar_area_x' and `bar_area_width', respectively.
3101 (x_scroll_run): Take account of fringe background extension.
3102
04f2d78b
CB
3103 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3104 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3105 `bar_area_width', respectively.
3106 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3107 background extension.
3108
79b70037
GM
31092011-05-10 Jim Meyering <meyering@redhat.com>
3110
3111 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3112
2f142cc5
JB
31132011-05-10 Juanma Barranquero <lekktu@gmail.com>
3114
3115 * image.c (Finit_image_library): Return t for built-in image types,
3116 like pbm and xbm. (Bug#8640)
3117
57679c86
AS
31182011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3119
3120 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3121
888c9e86
EZ
31222011-05-07 Eli Zaretskii <eliz@gnu.org>
3123
b0512a1d
EZ
3124 * w32console.c (Fset_screen_color): Doc fix.
3125 (Fget_screen_color): New function.
3126 (syms_of_ntterm): Defsubr it.
3127
7285dc67
EZ
3128 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3129 unlink the temporary file if Fcall_process didn't create it in the
3130 first place.
3131 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3132 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3133 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3134 cue to call_process_cleanup not to close that handle.
3135
4d3fcc8e
BK
31362011-05-07 Ben Key <bkey76@gmail.com>
3137
3138 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3139 one of two shell specific rules, either bootstrap-temacs-CMD or
3140 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3141 to the previous implementation of the bootstrap-temacs rule.
3142 The bootstrap-temacs-CMD rule is similar to the previous
3143 implementation of the bootstrap-temacs rule except that it
3144 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3145 variable.
3146
3147 These changes, along with some changes to nt/configure.bat,
3148 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3149 earlier fix to add support for --cflags and --ldflags options
3150 that include quotes so that it works whether make uses cmd or
3151 sh as the shell.
3152
b4289b64
MA
31532011-05-06 Michael Albinus <michael.albinus@gmx.de>
3154
3155 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3156 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3157 is a constant.
3158 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3159 a string. Handle both cases.
3160 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3161 (Fdbus_register_method): Use Qinvalid_function.
3162
af4c0e28
JB
31632011-05-06 Juanma Barranquero <lekktu@gmail.com>
3164
3165 * makefile.w32-in: Update dependencies.
3166 (LISP_H): Add inttypes.h and stdin.h.
3167 (PROCESS_H): Add unistd.h.
3168
c51453d9
EZ
31692011-05-06 Eli Zaretskii <eliz@gnu.org>
3170
3171 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3172 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3173
8ff0ac3c 31742011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3175
4c4b566b
PE
3176 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3177
aab2b9b5
PE
3178 * term.c (vfatal): Remove stray call to va_end.
3179 It's not needed and the C Standard doesn't allow it here anyway.
3180
c378da0b
PE
3181 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3182 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3183
288b08c7
PE
3184 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3185 bytes.
3186
e3601888
PE
3187 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3188
db6c0e74
PE
3189 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3190
dd5963ea
PE
3191 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3192
88c9450f
PE
3193 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3194
2f9442b8
PE
3195 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3196
c032b5f8
PE
3197 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3198 * charset.c (Fdefine_charset_internal): Don't initialize
3199 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3200 32-bit int (Bug#8600).
a108c10b
PE
3201
3202 * lread.c (read_integer): Be more consistent with string-to-number.
3203 Use string_to_number to do the actual conversion; this avoids
3204 rounding errors and fixes some other screwups. Without this fix,
3205 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3206 (digit_to_number): Move earlier, for benefit of read_integer.
3207 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3208 not a digit in any supported base. (Bug#8602)
a108c10b 3209
ad5f9eea
PE
3210 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3211
aec1708a
PE
3212 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3213 to match comment at start of function. This also removes a
3214 GCC warning about overflow in a 32+64-bit port.
3215
47be4ab5
PE
3216 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3217
371cac43
PE
3218 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3219 Reported by Stefan Monnier in
3220 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3221 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3222 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3223
d01a7826
PE
3224 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3225 (EMACS_UINTPTR): Likewise, with uintptr_t.
3226
7fd47d5c
PE
3227 * lisp.h: Prefer 64-bit EMACS_INT if available.
3228 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3229 on 32-bit hosts that have 64-bit int, so that they can access
3230 large files.
122b0c86
PE
3231 However, temporarily disable this change unless the temporary
3232 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3233
8727937b
PE
3234 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3235
8ac068ac
PE
3236 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3237 This removes an assumption that EMACS_INT and long are the same
3238 width as pointers. The assumption is true for Emacs porting targets
3239 now, but we want to make other targets possible.
3240 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3241 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3242 In the rest of the code, change types of integers that hold casted
3243 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3244 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3245 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3246 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3247 No need to cast type when ORing.
3248 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3249 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3250 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3251 assume EMACS_INT is the same width as char *.
3252 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3253 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3254 Remove no-longer-needed casts.
3255 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3256 (xg_tool_bar_help_callback, xg_make_tool_item):
3257 Use EMACS_INTPTR to hold an integer
3258 that will be cast to void *; this can avoid a GCC warning
3259 if EMACS_INT is not the same width as void *.
3260 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3261 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3262 (current_message_1, set_message_1):
3263 Use a local to convert to proper width without a cast.
3264 * xmenu.c (dialog_selection_callback): Likewise.
3265
ede49d71
PE
3266 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3267 Also, don't assume VALBITS / RAND_BITS is less than 5,
3268 and don't rely on undefined behavior when shifting a 1 left into
3269 the sign bit.
3270 * lisp.h (get_random): Change signature to match.
3271
2f30ecd0
PE
3272 * lread.c (hash_string): Use size_t, not int, for hash computation.
3273 Normally we prefer signed values; but hashing is special, because
3274 it's better to use unsigned division on hash table sizes so that
3275 the remainder is nonnegative. Also, size_t is the natural width
3276 for hashing into memory. The previous code used 'int', which doesn't
3277 retain enough info to hash well into very large tables.
3278 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3279
2a866e7b
PE
3280 * dbusbind.c: Don't possibly lose pointer info when converting.
3281 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3282 Use XPNTR rather than XHASH, so that the high-order bits of
3283 the pointer aren't lost when converting through void *.
3284
51639eac
PE
3285 * eval.c (Fautoload): Don't double-shift a pointer.
3286
92394119
PE
3287 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3288
dbdb9a7c
JB
32892011-05-06 Juanma Barranquero <lekktu@gmail.com>
3290
3291 * gnutls.c (DEF_GNUTLS_FN):
3292 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3293
db7a0b4f
AS
32942011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3295
3296 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3297 marker. (Bug#8610)
3298
f7ff1b0f 32992011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3300
3301 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3302 New version that can reserve upto 2GB of heap space.
3303
f7ff1b0f 33042011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3305
3306 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3307
639c109b
TZ
33082011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3309
3310 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3311 `gnutls_certificate_set_x509_key_file'.
3312
d2127135
JB
33132011-05-05 Juanma Barranquero <lekktu@gmail.com>
3314
3315 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3316 Update dependencies.
3317
e968f4f3
JB
33182011-05-04 Juanma Barranquero <lekktu@gmail.com>
3319
3320 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3321 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3322 Remove unused parameter `fildes'.
3323 * process.c (read_process_output, send_process): Don't pass it.
3324
84d358f0
JB
33252011-05-04 Juanma Barranquero <lekktu@gmail.com>
3326
3327 Fix previous change: the library cache is defined in w32.c.
3328 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3329 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3330
0898ca10
JB
33312011-05-04 Juanma Barranquero <lekktu@gmail.com>
3332
3333 Implement dynamic loading of GnuTLS on Windows.
3334
3335 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3336 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3337 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3338 Declare.
3339
3340 * gnutls.c (Qgnutls_dll): Define.
3341 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3342 (gnutls_*): Declare function pointers.
3343 (init_gnutls_functions): New function to initialize function pointers.
3344 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3345 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3346 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3347 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3348 (emacs_gnutls_write, emacs_gnutls_read)
3349 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3350 (Fgnutls_available_p): New function.
3351 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3352 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3353 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3354
3355 * image.c: Include w32.h.
3356 (Vimage_type_cache): Delete.
3357 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3358 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3359 (w32_delayed_load): Move to w32.c.
3360
3361 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3362
3363 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3364 (w32_delayed_load): Move from image.c. When loading a library, record
3365 its filename in the :loaded-from property of the library id.
3366 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3367 Initialize and staticpro them.
3368 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3369
3370 * process.c: Include lisp.h before w32.h, not after.
3371 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3372 instead of gnutls_record_check_pending.
3373
3374 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3375
ff4de4aa
TZ
33762011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3377
3378 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3379 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3380 as passed in.
3381
abe95abb
JD
33822011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3383
3384 * xterm.c (x_set_frame_alpha): Do not set property on anything
3385 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3386
e16e55d4
JB
33872011-05-02 Juanma Barranquero <lekktu@gmail.com>
3388
3389 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3390
bafcf6a5
JB
33912011-05-02 Juanma Barranquero <lekktu@gmail.com>
3392
3393 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3394 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3395 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3396 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3397 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3398 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3399 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3400 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3401 (Qgnutls_bootprop_callbacks_verify): Make static.
3402
e7a6747f
AS
34032011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3404
19ed11ba
AS
3405 * callproc.c: Indentation fixup.
3406
e7a6747f 3407 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3408 (wait_for_termination, interruptible_wait_for_termination):
3409 Move after wait_for_termination_1.
e7a6747f 3410
1ef14cb4
LMI
34112011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3412
3413 * sysdep.c (interruptible_wait_for_termination): New function
3414 which is like wait_for_termination, but allows keyboard
3415 interruptions.
3416
3417 * callproc.c (Fcall_process): Add (:file "file") as an option for
3418 the STDOUT buffer.
3419 (Fcall_process_region): Ditto.
3420
330d880c
EZ
34212011-04-30 Eli Zaretskii <eliz@gnu.org>
3422
8db90b73
EZ
3423 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3424 rather than `XVECTOR (FOO)->size'.
3425
330d880c
EZ
3426 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3427 inttypes.h, as a gnulib replacement is used if it not available in
3428 system headers.
3429
15cbd324
EZ
34302011-04-21 Eli Zaretskii <eliz@gnu.org>
3431
3432 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3433 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3434 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3435
3436 * coding.c (coding_alloc_by_realloc): Error out if destination
3437 will grow beyond MOST_POSITIVE_FIXNUM.
3438 (decode_coding_emacs_mule): Abort if there isn't enough place in
3439 charbuf for the composition carryover bytes. Reserve an extra
3440 space for up to 2 characters produced in a loop.
3441 (decode_coding_iso_2022): Abort if there isn't enough place in
3442 charbuf for the composition carryover bytes.
3443
34442011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3445
ae940cca
EZ
3446 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3447 aborting when %lld or %lll format is passed.
3448 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3449 %llo or %llx format is passed. (Bug#8545)
3450
03ab8921
EZ
3451 * window.c (window_scroll_line_based): Use a marker instead of
3452 simple variables to record original value of point. (Bug#7952)
3453
afda1437
EZ
3454 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3455 produced by %s or %c overflows available buffer space. (Bug#8545)
3456
f76dee0c
PE
34572011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3458
3459 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3460 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3461
fdc5744d
JB
34622011-04-28 Juanma Barranquero <lekktu@gmail.com>
3463
3464 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3465
638f053a
JB
34662011-04-28 Juanma Barranquero <lekktu@gmail.com>
3467
3468 * keyboard.c (Qdelayed_warnings_hook): Define.
3469 (command_loop_1): Run `delayed-warnings-hook'
3470 if Vdelayed_warnings_list is non-nil.
3471 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3472 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3473
d178f871
EZ
34742011-04-28 Eli Zaretskii <eliz@gnu.org>
3475
3476 * doprnt.c (doprnt): Don't return value smaller than the buffer
3477 size if the message was truncated. (Bug#8545).
3478
b124fd93
JB
34792011-04-28 Juanma Barranquero <lekktu@gmail.com>
3480
3481 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3482 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3483
e810457d
PE
34842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3485
3486 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3487
ea51cceb
JB
34882011-04-27 Juanma Barranquero <lekktu@gmail.com>
3489
3490 * makefile.w32-in: Update dependencies.
3491
94dcfacf
EZ
34922011-04-27 Eli Zaretskii <eliz@gnu.org>
3493
3494 Improve `doprnt' and its usage. (Bug#8545)
3495 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3496 `format_end'. Remove support for %l as a conversion specifier.
3497 Don't use xrealloc. Improve diagnostics when the %l size modifier
3498 is used. Update the commentary.
3499
3500 * eval.c (verror): Simplify calculation of size_t.
3501
3502 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3503 messages.
3504
f61f41d7
PE
35052011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3506
3507 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3508 change.
3509
96fb4434
PE
35102011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3511
3512 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3513 This makes this file independent of the recent pseudovector change.
3514
671875da 35152011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3516
69e9b5a3
PE
3517 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3518
b5f869a7 3519 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3520 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3521 Remove unused local.
c8926152 3522 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3523
841a1577 3524 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3525 GCC 4.6.0 optimizes based on type-based alias analysis.
3526 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3527 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3528 != &v->size, and therefore "v->size = 1; b->size = 2; return
3529 v->size;" must therefore return 1. This assumption is incorrect
3530 for Emacs, since it type-puns struct Lisp_Vector * with many other
3531 types. To fix this problem, this patch adds a new type struct
f904488f 3532 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3533 and pseudovectors, and helps optimizing compilers not get fooled
3534 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3535 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3536 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3537 the size member.
eab3844f
PE
3538 (XSETPVECTYPE): Rewrite in terms of new macro.
3539 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3540 This is a bit clearer, and further avoids the possibility of
3541 undesirable aliasing.
3542 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3543 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3544 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3545 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3546 (ASIZE): Now uses header.size rather than size.
3547 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3548 to avoid the hassle of writing XVECTOR (foo)->header.size.
3549 (struct vectorlike_header): New type.
eab3844f
PE
3550 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3551 object, to help avoid aliasing.
3552 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3553 (SUBRP): Likewise, since Lisp_Subr is a special case.
3554 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3555 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3556 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3557 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3558 changed to be "header.size" and "header.next".
3559 * buffer.h (struct buffer): Likewise.
3560 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3561 * frame.h (struct frame): Likewise.
3562 * process.h (struct Lisp_Process): Likewise.
3563 * termhooks.h (struct terminal): Likewise.
3564 * window.c (struct save_window_data, struct saved_window): Likewise.
3565 * window.h (struct window): Likewise.
3566 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3567 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3568 * buffer.c (init_buffer_once): Likewise.
3569 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3570 special case.
3571 * process.c (Fformat_network_address): Use local var for size,
3572 for brevity.
3573
0df1eac5
PE
3574 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3575
847ab9d1 3576 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3577 * data.c (atof): Remove decl; no longer used or needed.
3578 (digit_to_number): Move to lread.c.
3579 (Fstring_to_number): Use new string_to_number function, to be
3580 consistent with how the Lisp reader treats infinities and NaNs.
3581 Do not assume that floating-point numbers represent EMACS_INT
3582 without losing information; this is not true on most 64-bit hosts.
3583 Avoid double-rounding errors, by insisting on integers when
3584 parsing non-base-10 numbers, as the documentation specifies.
3585 * lisp.h (string_to_number): New decl, replacing ...
3586 (isfloat_string): Remove.
bc0a5c13 3587 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3588 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3589 appears to have been a coding error. Similarly, do not accept
3590 strings like +-1e0 as floating point numbers. Do not report
3591 overflow for integer overflows unless the base is not 10 which
3592 means we have no simple and reliable way to continue.
3593 Break out the floating-point parsing into a new
3594 function string_to_number, so that Fstring_to_number parses
3595 floating point numbers consistently with the Lisp reader.
04f2d78b 3596 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3597 (E_CHAR, EXP_INT): Remove, replacing with ...
3598 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3599 (string_to_number): New function, replacing isfloat_string.
3600 This function checks for valid syntax and produces the resulting
3601 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3602 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3603 so that overflow for non-base-10 numbers is reported only when
3604 there's no portable and simple way to convert to floating point.
452f4150 3605
67769ffc
PE
3606 * textprop.c (set_text_properties_1): Rewrite for clarity,
3607 and to avoid GCC warning about integer overflow.
3608
c20db43f
PE
3609 * intervals.h (struct interval): Use EMACS_INT for members
3610 where EMACS_UINT might cause problems. See
3611 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3612 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3613 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3614 All uses changed.
37aa2f85
PE
3615 (offset_intervals): Tell GCC not to worry about length overflow
3616 when negating a negative length.
c20db43f 3617
2538aa2f
PE
3618 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3619 (overrun_check_free): Likewise.
3620
f2d3008d
PE
3621 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3622 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3623 word size.
3624
ec8df744
PE
3625 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3626 (gnutls_make_error): Rename local to avoid shadowing.
3627 (gnutls_emacs_global_deinit): ifdef out; not used.
3628 (Fgnutls_boot): Use const for pointer to readonly storage.
3629 Comment out unused local. Fix pointer signedness problems.
3630
640ee02d
PE
3631 * lread.c (openp): Don't stuff size_t into an 'int'.
3632 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3633 about possible signed overflow.
3634
6048fb2a
PE
3635 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3636 (GDK_KEY_g): Don't define if already defined.
3637 (xg_prepare_tooltip): Avoid pointer signedness problem.
3638 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3639
fa3c87e1
PE
3640 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3641 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3642
2172544b
PE
3643 * xfns.c (Fx_window_property): Simplify a bit,
3644 to make a bit faster and to avoid GCC 4.6.0 warning.
3645 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3646
9b821a21
PE
3647 * fns.c (internal_equal): Don't assume size_t fits in int.
3648
3c616cfa
PE
3649 * alloc.c (compact_small_strings): Tighten assertion a little.
3650
c2982e87
PE
3651 Replace pEd with more-general pI, and fix some printf arg casts.
3652 * lisp.h (pI): New macro, generalizing old pEd macro to other
3653 conversion specifiers. For example, use "...%"pI"d..." rather
3654 than "...%"pEd"...".
3655 (pEd): Remove. All uses replaced with similar uses of pI.
3656 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3657 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3658 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3659 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3660 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3661 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3662 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3663 64-bit hosts.
3664 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3665 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3666 * print.c (safe_debug_print, print_object): Likewise.
3667 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3668 to int.
6f04d126
PE
3669 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3670 avoiding the 0 flag, which is not portable.
c2982e87
PE
3671 * process.c (Fmake_network_process): Use pI to avoid cast.
3672 * region-cache.c (pp_cache): Likewise.
3673 * xdisp.c (decode_mode_spec): Likewise.
3674 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3675 behavior on 64-bit hosts with printf arg.
6f04d126 3676 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3677 (x_stop_queuing_selection_requests): Likewise.
3678 (x_get_window_property): Don't truncate byte count to an 'int'
3679 when tracing.
0b432f21 3680
5e073ec7
PE
3681 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3682 here, since it parses constructs like leading '-' and spaces,
3683 which are not wanted; and it overflows with large numbers.
3684 Instead, simply match F[0-9]+, which is what is wanted anyway.
3685
36372bf9
PE
3686 * alloc.c: Remove unportable assumptions about struct layout.
3687 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3688 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3689 (allocate_vectorlike, make_pure_vector): Use the new macros,
3690 plus offsetof, to remove unportable assumptions about struct layout.
3691 These assumptions hold on all porting targets that I know of, but
3692 they are not guaranteed, they're easy to remove, and removing them
3693 makes further changes easier.
3694
0b432f21
PE
3695 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3696 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3697 (string_overrun_cookie): Now const. Use initializers that
3698 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3699 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3700 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3701 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3702 multiple of sizeof (EMACS_INT); it need not be, if
3703 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3704 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3705
895009e1
JB
37062011-04-26 Juanma Barranquero <lekktu@gmail.com>
3707
3708 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3709
6a7a1b0b
TZ
37102011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3711
3712 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3713 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3714 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3715
841a1577 37162011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3717
3718 * lisp.h (Qdebug): List symbol.
895009e1 3719 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3720 * keyboard.c (debug-on-event): New variable.
3721 (handle_user_signal): Break into debugger when debug-on-event
3722 matches the current signal symbol.
3723
f2d3ba6f
DN
37242011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3725
3726 * alloc.c (check_sblock, check_string_bytes)
3727 (check_string_free_list): Convert to standard C.
3728
42ce4c63
TZ
37292011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3730
3731 * w32.c (emacs_gnutls_push): Fix typo.
3732
825cd63c
EZ
37332011-04-25 Eli Zaretskii <eliz@gnu.org>
3734
fb11d64d
EZ
3735 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3736 "cast to pointer from integer of different size".
3737
825cd63c
EZ
3738 Improve doprnt and its use in verror. (Bug#8545)
3739 * doprnt.c (doprnt): Document the set of format control sequences
3740 supported by the function. Use SAFE_ALLOCA instead of always
3741 using `alloca'.
3742
3743 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3744 is one byte too soon. Don't use xrealloc; instead xfree and
3745 xmalloc anew.
3746
e061a11b
TZ
37472011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3748
3749 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3750 callbacks stage.
3751
3752 * gnutls.c: Renamed global_initialized to
3753 gnutls_global_initialized. Added internals for the
3754 :verify-hostname-error, :verify-error, and :verify-flags
3755 parameters of `gnutls-boot' and documented those parameters in the
3756 docstring. Start callback support.
9173deec
JB
3757 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3758 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3759 on error. Return error code.
e061a11b
TZ
3760 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3761 (emacs_gnutls_read): Likewise.
3762 (Fgnutls_boot): Return handshake error code.
3763 (emacs_gnutls_handle_error): New function.
3764 (wsaerror_to_errno): Likewise.
3765
3766 * w32.h (emacs_gnutls_pull): Add prototype.
3767 (emacs_gnutls_push): Likewise.
3768
3769 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3770 (emacs_gnutls_push): Likewise.
3771
37722011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3773
3774 * process.c (wait_reading_process_output): Check if GnuTLS
3775 buffered some data internally if no FDs are set for TLS
3776 connections.
3777
3778 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3779 (LIBS): Link to USER_LIBS.
3780 ($(BLD)/gnutls.$(0)): New target.
3781
fa6996bc
EZ
37822011-04-24 Eli Zaretskii <eliz@gnu.org>
3783
eb35682e
EZ
3784 * xdisp.c (handle_single_display_spec): Rename the
3785 display_replaced_before_p argument into display_replaced_p, to
3786 make it consistent with the commentary. Fix typos in the
3787 commentary.
3788
e2ad650c
EZ
3789 * textprop.c (syms_of_textprop): Remove dead code.
3790 (copy_text_properties): Delete obsolete commentary about an
3791 interface that was deleted long ago. Fix typos in the description
3792 of arguments.
3793
1b2de274
EZ
3794 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3795 to changes in oldXMenu/XMenu.h from 2011-04-16.
3796 <menu_help_message, prev_menu_help_message>: Constify.
3797 (IT_menu_make_room): menu->help_text is now `const char **';
3798 adjust.
3799
3800 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3801 to changes in oldXMenu/XMenu.h from 2011-04-16.
3802 (struct XMenu): Declare `help_text' `const char **'.
3803
3804 * xfaces.c <Qunspecified>: Make extern again.
3805
3806 * syntax.c: Include sys/types.h before including regex.h, as
3807 required by Posix.
3808
762b15be
EZ
3809 * doc.c (get_doc_string): Improve the format passed to `error'.
3810
3811 * doprnt.c (doprnt): Improve commentary.
3812
3813 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3814
3815 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3816 them with etags.
3817
f1052e5d
EZ
3818 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3819 changes in globals.h immediately force recompilation.
762b15be
EZ
3820 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3821 $(CURDIR)/s/ms-w32.h.
3822 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3823
fa6996bc
EZ
3824 * character.c (Fchar_direction): Function deleted.
3825 (syms_of_character): Don't defsubr it.
3826 <char-direction-table>: Deleted.
3827
e6c3da20
EZ
38282011-04-23 Eli Zaretskii <eliz@gnu.org>
3829
3830 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3831 * doprnt.c: Include limits.h.
3832 (SIZE_MAX): New macro.
04f2d78b
CB
3833 (doprnt): Return a size_t value. 2nd arg is now size_t.
3834 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3835 Improve overflow protection. Support `l' modifier for integer
3836 conversions. Support %l conversion. Don't assume an EMACS_INT
3837 argument for integer conversions and for %c.
3838
3839 * lisp.h (doprnt): Restore prototype.
3840
3841 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3842 $(SRC)/character.h.
3843
3844 * Makefile.in (base_obj): Add back doprnt.o.
3845
3846 * deps.mk (doprnt.o): Add back prerequisites.
3847 (callint.o): Depend on character.h.
3848
3849 * eval.c (internal_lisp_condition_case): Include the handler
3850 representation in the error message.
3851 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3852 when breaking from the loop.
3853
3854 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3855
3856 * callint.c (Fcall_interactively): When displaying error message
3857 about invalid control letter, pass the character's codepoint, not
3858 a pointer to its multibyte form. Improve display of the character
3859 in octal and display also its hex code.
3860
3861 * character.c (char_string): Use %x to display the (unsigned)
3862 codepoint of an invalid character, to avoid displaying a bogus
3863 negative value.
3864
3865 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3866 `error', not SYMBOL_NAME itself.
3867
3868 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3869 character arguments to `error'.
3870
3871 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3872 to `error' in error message about FINAL_CHAR argument. Make sure
3873 FINAL_CHAR is a character, and use %c when it is passed as
3874 argument to `error'.
3875
4ffd0d6b 38762011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3877
3878 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3879
3880 * w32.c: Include <time.h>.
3881 (sys_localtime): New function.
3882
4ffd0d6b 38832011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3884
3885 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3886
4ffd0d6b 3887 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3888
4ffd0d6b 38892011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3890
4ffd0d6b
GM
3891 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3892 zombies (Bug#8467).
aac0c6e3 3893
04c56954
EZ
38942011-04-19 Eli Zaretskii <eliz@gnu.org>
3895
3896 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3897 gl_state.e_property when gl_state.object is Qt.
3898
3899 * insdel.c (make_gap_larger): Remove limitation of buffer size
3900 to <= INT_MAX.
3901
16a43933
CY
39022011-04-18 Chong Yidong <cyd@stupidchicken.com>
3903
3904 * xdisp.c (lookup_glyphless_char_display)
3905 (produce_glyphless_glyph): Handle cons cell entry in
3906 glyphless-char-display.
3907 (Vglyphless_char_display): Document it.
3908
3909 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3910 glyphless-char-display.
3911
4581706e
CY
39122011-04-17 Chong Yidong <cyd@stupidchicken.com>
3913
3914 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3915
3916 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3917
3918 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3919 definition for no-X builds.
3920
4887c6e2 39212011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3922
fd35b6f9
PE
3923 Static checks with GCC 4.6.0 and non-default toolkits.
3924
5c1ccb01
PE
3925 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3926
006c5daa
PE
3927 * process.c (keyboard_bit_set): Define only if SIGIO.
3928 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3929 (send_process): Repair possible setjmp clobbering.
3930
efc736d3
PE
3931 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3932
4e2fe2e6
PE
3933 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3934
f97334a2
PE
3935 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3936
4e75f29d
PE
3937 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3938 Define only if needed.
3939
90efadd1
PE
3940 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3941 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3942 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3943
3c647824
PE
3944 * dispextern.h (struct redisplay_interface): Rename param
3945 to avoid shadowing.
e264f262 3946 * termhooks.h (struct terminal): Likewise.
761383f4 3947 * xterm.c (xembed_send_message): Likewise.
3c647824 3948
b58c5c4a
PE
3949 * insdel.c (make_gap_smaller): Define only if
3950 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3951
cad59032
PE
3952 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3953 it.
3954
c339dc2e
PE
3955 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3956 so that we aren't warned about unused symbols.
3957
91a3e27b
PE
3958 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3959
399c71d3 3960 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3961
8ffc96f5
PE
3962 * xfns.c (x_real_positions): Mark locals as initialized.
3963
eef9bc79
PE
3964 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3965
098db9dd
PE
3966 * xterm.c: Fix problems found by static analysis with other toolkits.
3967 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3968 (x_dispatch_event): Declare static if USE_GTK, and
3969 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3970 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3971 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3972 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3973 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3974
eb18f6cc
PE
3975 * xmenu.c (menu_help_callback): Pointer type fixes.
3976 Use const pointers when pointing at readonly data. Avoid pointer
3977 signedness clashes.
3978 (FALSE): Remove unused macro.
3979 (update_frame_menubar): Remove unused decl.
3980
1fe72bf8
PE
3981 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3982
60d9e1db
PE
3983 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3984 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3985 (single_menu_item): Rename local to avoid shadowing.
3986
39261c26
PE
3987 * keyboard.c (make_lispy_event): Remove unused local var.
3988
018c5e19
PE
3989 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3990 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3991
63d2b86e
PE
3992 * bitmaps: Change bitmaps from unsigned char back to the X11
3993 compatible char. Avoid the old compiler warnings about
3994 out-of-range initializers by using, for example, '\xab' rather
3995 than 0xab.
3996
aefd87e1
PE
3997 * xgselect.c (xgselect_initialize): Check vs interface
3998 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3999
bf501fb9
PE
4000 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4001
e9829fdf
PE
4002 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4003 to read-only memory.
4004
1086c095
PE
4005 * fns.c (vector): Remove; this old hack is no longer needed.
4006
2baccd04 4007 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4008 Remove unused var.
dde42981 4009 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4010
72391843 4011 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4012
436c16df 4013 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4014 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4015 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4016
92bb796d 4017 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4018 (x_term_init): Remove local to avoid shadowing.
92bb796d 4019
764430a3 4020 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4021
4022 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4023 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4024
d1dfb56c
EZ
40252011-04-16 Eli Zaretskii <eliz@gnu.org>
4026
c4354cb4
EZ
4027 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4028
d1dfb56c
EZ
4029 Fix regex.c, syntax.c and friends for buffers > 2GB.
4030 * syntax.h (struct gl_state_s): Declare character position members
4031 EMACS_INT.
4032
4033 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4034
04f2d78b
CB
4035 * textprop.c (verify_interval_modification, interval_of):
4036 Declare arguments EMACS_INT.
d1dfb56c
EZ
4037
4038 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4039 EMACS_INT.
4040
4041 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4042
4043 * indent.c (Fvertical_motion): Local variable it_start is now
4044 EMACS_INT.
4045
4046 * regex.c (re_match, re_match_2, re_match_2_internal)
4047 (bcmp_translate, regcomp, regexec, print_double_string)
4048 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4049 (re_compile_pattern, re_exec): Declare arguments and local
4050 variables `size_t' and `ssize_t' and return values `regoff_t', as
4051 appropriate.
4052 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4053 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4054 <compile_stack_type>: `size' and `avail' are now `size_t'.
4055
4056 * regex.h <regoff_t>: Use ssize_t, not int.
4057 (re_search, re_search_2, re_match, re_match_2): Arguments that
4058 specify buffer/string position and length are now ssize_t and
4059 size_t. Return type is regoff_t.
4060
613052cd
BK
40612011-04-16 Ben Key <bkey76@gmail.com>
4062
4063 * nsfont.m: Fixed bugs in ns_get_family and
4064 ns_descriptor_to_entity that were caused by using free to
4065 deallocate memory blocks that were allocated by xmalloc (via
4066 xstrdup). This caused Emacs to crash when compiled with
4067 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4068 --enable-checking=xmallocoverrun). xfree is now used to
4069 deallocate these memory blocks.
4070
4170f62f 40712011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4072
71b41406
PE
4073 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4074
9587a89d
PE
4075 emacs_write: Accept and return EMACS_INT for sizes.
4076 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4077 et seq.
4078 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4079 Accept and return EMACS_INT.
4080 (emacs_gnutls_write): Return the number of bytes written on
4081 partial writes.
4082 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4083 (emacs_read, emacs_write): Remove check for negative size, as the
4084 Emacs source code has been audited now.
9587a89d
PE
4085 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4086 (emacs_read, emacs_write): Use it.
273a5f82
PE
4087 * process.c (send_process): Adjust to the new signatures of
4088 emacs_write and emacs_gnutls_write. Do not attempt to store
4089 a byte offset into an 'int'; it might overflow.
9587a89d 4090 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4091
3e047f51
PE
4092 * sound.c: Don't assume sizes fit in 'int'.
4093 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4094 Return EMACS_INT, not int.
3e047f51 4095 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4096 Accept EMACS_INT, not int.
4097 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4098 record read return values.
4099
cc39a9db
BK
41002011-04-15 Ben Key <bkey76@gmail.com>
4101
c9d0ec6d
JB
4102 * keyboard.c (Qundefined): Don't declare static since it is used
4103 in nsfns.m.
4104 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4105 static since they are used in nsfont.m.
cc39a9db 4106
6c60eb9f
SM
41072011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4108
4109 * process.c (Qprocessp): Don't declare static.
4110 * lisp.h (Qprocessp): Declare again.
4111
7990b61a
JB
41122011-04-15 Juanma Barranquero <lekktu@gmail.com>
4113
4114 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4115
5d4cb038
PE
41162011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4117
8bd7b830 4118 Improve C-level modularity by making more things 'static'.
cd64ea1d 4119
e3b27b31
PE
4120 Don't publish debugger-only interfaces to other modules.
4121 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4122 (verify_bytepos, count_markers): Move decls to the only modules
4123 that need them.
4124 * region-cache.h (pp_cache): Likewise.
4125 * window.h (check_all_windows): Likewise.
4126 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4127
5d4cb038
PE
4128 * sysdep.c (croak): Now static, if
4129 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4130 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4131
4132 * alloc.c (refill_memory_reserve): Now static if
4133 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4134 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4135
e87b6180
PE
4136 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4137 Define only if USE_LUCID.
4138
ac64929e
PE
4139 * xrdb.c (x_customization_string, x_rm_string): Now static.
4140
6f37259d
PE
4141 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4142 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4143
1683e3ab
PE
4144 * xdisp.c (draw_row_with_mouse_face): Now static.
4145 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4146
de9c2632
PE
4147 * window.h (check_all_windows): Mark externally visible.
4148
2b96acb7
PE
4149 * window.c (window_deletion_count): Now static.
4150
4151 * undo.c: Make symbols static if they're not exported.
4152 (last_undo_buffer, last_boundary_position, pending_boundary):
4153 Now static.
4154
50436f33
PE
4155 * textprop.c (interval_insert_behind_hooks): Now static.
4156 (interval_insert_in_front_hooks): Likewise.
4157
64520e5c
PE
4158 * term.c: Make symbols static if they're not exported.
4159 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4160 (max_frame_lines, tty_set_terminal_modes):
4161 (tty_reset_terminal_modes, tty_turn_off_highlight):
4162 (get_tty_terminal): Now static.
4163 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4164 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4165 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4166 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4167 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4168
1fa53021
PE
4169 * sysdep.c: Make symbols static if they're not exported.
4170 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4171 Now static.
4172 (sigprocmask_set, full_mask): Remove; unused.
4173 (wait_debugging): Mark as visible.
4174 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4175 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4176
d4b43b22
PE
4177 * syntax.c (syntax_temp): Define only if !__GNUC__.
4178
b7c513d0
PE
4179 * sound.c (current_sound_device, current_sound): Now static.
4180
989b29ad
PE
4181 * search.c (searchbufs, searchbuf_head): Now static.
4182
13a55a78
PE
4183 * scroll.c (scroll_cost): Remove; unused.
4184 * dispextern.h (scroll_cost): Remove decl.
4185
de68a1fc
PE
4186 * region-cache.h (pp_cache): Mark as externally visible.
4187
40ccffa6
PE
4188 * process.c: Make symbols static if they're not exported.
4189 (process_tick, update_tick, create_process, chan_process):
4190 (Vprocess_alist, proc_buffered_char, datagram_access):
4191 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4192 (deactivate_process): Mark defn as static, as well as decl.
4193 * lisp.h (create_process): Remove decl.
4194 * process.h (chan_process, Vprocess_alist): Remove decls.
4195
ad64fc97
PE
4196 * print.c: Make symbols static if they're not exported.
4197 (print_depth, new_backquote_output, being_printed, print_buffer):
4198 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4199 (print_interval, print_number_index, initial_stderr_stream):
4200 Now static.
4201 * lisp.h (Fprinc): Remove decl.
4202 (debug_output_compilation_hack): Mark as externally visible.
4203
adddb265
PE
4204 * sysdep.c (croak): Move decl from here to syssignal.h.
4205 * syssignal.h (croak): Put it here, so the API can be checked when
4206 'croak' is called from dissociate_if_controlling_tty.
4207
1717ede2
PE
4208 * minibuf.c: Make symbols static if they're not exported.
4209 (minibuf_save_list, choose_minibuf_frame): Now static.
4210 * lisp.h (choose_minibuf_frame): Remove decl.
4211
fa5fb2bc
PE
4212 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4213
1e3890d1
PE
4214 * lread.c: Make symbols static if they're not exported.
4215 (read_objects, initial_obarray, oblookup_last_bucket_number):
4216 Now static.
4217 (make_symbol): Remove; unused.
4218 * lisp.h (initial_obarray, make_symbol): Remove decls.
4219
8a1414fa
PE
4220 * keyboard.c: Make symbols static if they're not exported.
4221 (single_kboard, recent_keys_index, total_keys, recent_keys):
4222 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4223 (this_single_command_key_start, echoing, last_auto_save):
4224 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4225 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4226 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4227 (Vlispy_mouse_stem, double_click_count):
4228 Now static.
4229 (force_auto_save_soon): Define only if SIGDANGER.
4230 (ignore_mouse_drag_p): Now static if
4231 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4232 (print_help): Remove; unused.
4233 (stop_character, last_timer_event): Mark as externally visible.
4234 * keyboard.h (ignore_mouse_drag_p): Declare only if
4235 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4236 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4237 * lisp.h (echoing): Remove decl.
4238 (force_auto_save_soon): Declare only if SIGDANGER.
4239 * xdisp.c (redisplay_window): Simplify code, to make it more
4240 obvious that ignore_mouse_drag_p is not accessed if !defined
4241 USE_GTK && !defined HAVE_NS.
4242
93ea6e8f
PE
4243 * intervals.c: Make symbols static if they're not exported.
4244 (merge_properties_sticky, merge_interval_right, delete_interval):
4245 Now static.
4246 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4247
77382fcc
PE
4248 * insdel.c: Make symbols static if they're not exported.
4249 However, leave prepare_to_modify_buffer alone. It's never
4250 called from outside this function, but that appears to be a bug.
4251 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4252 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4253 (adjust_after_replace_noundo): Remove; unused.
4254 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4255 (signal_before_change): Remove decls.
77382fcc 4256
9306c32e
PE
4257 * indent.c (val_compute_motion, val_vmotion): Now static.
4258
cd44d2eb
PE
4259 * image.c: Make symbols static if they're not exported.
4260 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4261 if USE_GTK.
4262 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4263 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4264
ad9a7a06
PE
4265 * fringe.c (standard_bitmaps): Now static.
4266 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4267
81626931
PE
4268 * frame.c: Make symbols static if they're not exported.
4269 (x_report_frame_params, make_terminal_frame): Now static.
4270 (get_frame_param): Now static, unless HAVE_NS.
4271 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4272 (x_get_resource_string): Remove; not used.
4273 * frame.h (make_terminal_frame, x_report_frame_params):
4274 (x_get_resource_string); Remove decls.
4275 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4276 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4277
239f9db9
PE
4278 * font.c, fontset.c: Make symbols static if they're not exported.
4279 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4280 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4281 * font.c (font_close_object): Now static.
4282 * font.h (font_close_object): Remove.
4283 * fontset.c (FONTSET_OBJLIST): Remove.
4284 (free_realized_fontset) #if-0 the body, which does nothing.
4285 (face_suitable_for_char_p): #if-0, as it's never called.
4286 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4287 * xfaces.c (face_at_string_position):
4288 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4289 since 0 is always ASCII.
4290
dfcf3579
PE
4291 * fns.c (weak_hash_tables): Now static.
4292
5045092b
PE
4293 * fileio.c: Make symbols static if they're not exported.
4294 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4295 (Vwrite_region_annotation_buffers): Now static.
4296
57a96f5c
PE
4297 * eval.c: Make symbols static if they're not exported.
4298 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4299 * lisp.h (backtrace_list): Remove decl.
4300
35f08c38
PE
4301 * emacs.c: Make symbols static if they're not exported.
4302 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4303 (fatal_error_code, fatal_error_signal_hook, standard_args):
4304 Now static.
4305 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4306 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4307 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4308 * lisp.h (fatal_error_signal_hook): Remove decl.
4309 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4310
f44bd759
PE
4311 * editfns.c: Move a (normally-unused) function to its only use.
4312 * editfns.c, lisp.h (get_operating_system_release): Remove.
4313 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4314 worth the hassle of breaking this out.
4315
b532497d
PE
4316 * xterm.c: Make symbols static if they're not exported.
4317 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4318 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4319 (x_destroy_window, x_delete_display):
4320 Now static.
4321 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4322 (x_mouse_leave): Remove; unused.
4323 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4324 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4325 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4326 Remove decls.
4327 (x_mouse_leave): Declare only if WINDOWSNT.
4328 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4329 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4330 USE_X_TOOLKIT.
4331
1675728f
PE
4332 * ftxfont.c: Make symbols static if they're not exported.
4333 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4334 HAVE_FREETYPE.
4335 * font.h (ftxfont_driver): Likewise.
4336
e4cebfca
PE
4337 * xfns.c: Make symbols static if they're not exported.
4338 (x_last_font_name, x_display_info_for_name):
4339 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4340 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4341 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4342 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4343 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4344 (last_show_tip_args): Now static.
4345 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4346 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4347 (x_screen_planes): Remove; unused.
4348 * dispextern.h (x_screen_planes): Remove decl.
4349
5bf46f05
PE
4350 * dispnew.c: Make symbols static if they're not exported.
4351 * dispextern.h (redraw_garbaged_frames, scrolling):
4352 (increment_row_positions): Remove.
4353 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4354 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4355 Now static.
4356 (redraw_garbaged_frames): Remove; unused.
4357
435f4c28
PE
4358 * xfaces.c: Make symbols static if they're not exported.
4359 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4360 Remove decls.
4361 * xterm.h (defined_color): Remove decls.
4362 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4363 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4364 (menu_face_changed_default, defined_color, free_realized_face):
4365 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4366 (ascii_face_of_lisp_face): Remove; unused.
4367
8524aef3
PE
4368 * xdisp.c: Make symbols static if they're not exported.
4369 * dispextern.h (scratch_glyph_row, window_box_edges):
4370 (glyph_to_pixel_coords, set_cursor_from_row):
4371 (get_next_display_element, set_iterator_to_next):
4372 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4373 (show_mouse_face): Remove decls
4374 * frame.h (message_buf_print): Likewise.
4375 * lisp.h (pop_message, set_message, check_point_in_composition):
4376 Likewise.
4377 * xterm.h (set_vertical_scroll_bar): Likewise.
4378 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4379 (message_buf_print, scratch_glyph_row, displayed_buffer):
4380 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4381 (get_next_display_element, show_mouse_face, window_box_edges):
4382 (frame_to_window_pixel_xy, check_point_in_composition):
4383 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4384 (glyph_to_pixel_coords): Remove; unused.
4385
16390cd2
PE
4386 * dired.c (file_name_completion): Now static.
4387
4388 * dbusbind.c (xd_in_read_queued_messages): Now static.
4389
a25f4dfa
PE
4390 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4391 * data.c (circular_list_error): Remove.
4392
14a9c8df
PE
4393 * commands.h (last_point_position, last_point_position_buffer):
4394 (last_point_position_window): Remove decls.
4395 * keyboard.c: Make these variables static.
4396
04f2d78b
CB
4397 * coding.h (coding, code_convert_region, encode_coding_gap):
4398 Remove decls.
74ab6df5
PE
4399 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4400 (iso_code_class, detect_coding, code_convert_region): Now static.
4401 (encode_coding_gap): Remove; unused.
4402
38dfbee1
PE
4403 * chartab.c (chartab_chars, chartab_bits): Now static.
4404
a2cb4e63
PE
4405 * charset.h (charset_iso_8859_1): Remove decl.
4406 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4407 Now static.
4408
127198fd
PE
4409 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4410 * ccl.c (Vccl_program_table): Now static.
4411 (check_ccl_update): Remove; unused.
4412
d85b608f
PE
4413 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4414 * category.h: ... from here.
4415 * category.c (check_category_table, set_category_set): Now static.
4416
31cd66f3
PE
4417 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4418 * lisp.h: Remove these decls.
4419
c358e587
PE
4420 * buffer.c (buffer_count): Remove unused var.
4421
e78aecca
PE
4422 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4423 so that it's not optimized away.
4424 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4425 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4426 exported only to the debugger.
4427
e192d7d3 4428 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4429 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4430
92470028
PE
4431 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4432 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4433 was inaccessible from Lisp.
4434 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4435 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4436
244ed907
PE
4437 alloc.c: Import and export fewer symbols, and remove unused items.
4438 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4439 is defined.
4440 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4441 it's not optimized away by whole-program optimization.
4442 (message_enable_multibyte, free_misc): Remove.
4443 (catchlist, handlerlist, mark_backtrace):
4444 Declare only if BYTE_MARK_STACK.
4445 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4446 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4447 (message_enable_multibyte): Remove decl.
4448 (free_misc, interval_free_list, float_block, float_block_index):
4449 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4450 (cons_free_list, last_marked_index):
4451 Now static.
4452 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4453 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4454 (mark_backtrace): Define only if BYTE_MARK_STACK.
4455 * xdisp.c (message_enable_multibyte): Now static.
4456
61c2b50e 4457 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4458 This makes it easier for human readers (and static analyzers)
4459 to see whether these variables are used from other modules.
4460 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4461 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4462 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4463 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4464 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4465 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4466 * xmenu.c, xselect.c:
4467 Declare Q* vars static if they are not used in other modules.
4468 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4469 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4470 Remove decls of unexported vars.
4471 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4472
95c82688
PE
4473 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4474
16a97296
PE
4475 Make Emacs functions such as Fatom 'static' by default.
4476 This makes it easier for human readers (and static analyzers)
4477 to see whether these functions can be called from other modules.
4478 DEFUN now defines a static function. To make the function external
4479 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4480 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4481 (Finit_image_library):
16a97296
PE
4482 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4483 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4484 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4485 Remove decls, since these functions are now static.
4486 (Funintern, Fget_internal_run_time): New decls, since these functions
4487 were already external.
95c82688 4488
16a97296
PE
4489 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4490 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4491 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4492 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4493 * keyboard.c, keymap.c, lread.c:
4494 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4495 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4496 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4497 Mark functions with DEFUE instead of DEFUN,
4498 if they are used in other modules.
4499 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4500 decls for now-static functions.
4501 * buffer.h (Fdelete_overlay): Remove decl.
4502 * callproc.c (Fgetenv_internal): Mark as internal.
4503 * composite.c (Fremove_list_of_text_properties): Remove decl.
4504 (Fcomposition_get_gstring): New forward static decl.
4505 * composite.h (Fcomposite_get_gstring): Remove decl.
4506 * dired.c (Ffile_attributes): New forward static decl.
4507 * doc.c (Fdocumntation_property): New forward static decl.
4508 * eval.c (Ffetch_bytecode): New forward static decl.
4509 (Funintern): Remove extern decl; now in .h file where it belongs.
4510 * fileio.c (Fmake_symbolic_link): New forward static decl.
4511 * image.c (Finit_image_library): New forward static decl.
4512 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4513 * intervals.h (Fprevious_property_change):
4514 (Fremove_list_of_text_properties): Remove decls.
4515 * keyboard.c (Fthis_command_keys): Remove decl.
4516 (Fcommand_execute): New forward static decl.
4517 * keymap.c (Flookup_key): New forward static decl.
4518 (Fcopy_keymap): Now static.
4519 * keymap.h (Flookup_key): Remove decl.
4520 * process.c (Fget_process): New forward static decl.
4521 (Fprocess_datagram_address): Mark as internal.
4522 * syntax.c (Fsyntax_table_p): New forward static decl.
4523 (skip_chars): Remove duplicate decl.
4524 * textprop.c (Fprevious_property_change): New forward static decl.
4525 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4526 Now internal.
4527 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4528 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4529
785bbd42
PE
4530 * editfns.c (Fformat): Remove unreachable code.
4531
8b913b57
AS
45322011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4533
4534 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4535 change. (Bug#8496)
4536
a6744a35
EZ
45372011-04-13 Eli Zaretskii <eliz@gnu.org>
4538
4539 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4540 when at ZV. (Bug#8487)
4541
e7974947
AS
45422011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4543
baad03f0
AS
4544 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4545 (Bug#8437)
4546 * keyboard.c (parse_tool_bar_item): Likewise.
4547 * sound.c (sound_cleanup, alsa_close): Likewise.
4548 * termcap.c (tgetent): Likewise.
4549 * xfns.c (x_default_font_parameter): Likewise.
4550 * xsettings.c (read_and_apply_settings): Likewise.
4551
e7974947
AS
4552 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4553 (overrun_check_free): Protoize.
4554
28272684
PE
45552011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4556
4557 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4558 since callers should never pass a negative size.
4559 Change the signature to match that of plain 'read' and 'write'; see
4560 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4561 * lisp.h: Update prototypes of emacs_write and emacs_read.
4562
11997c76
EZ
45632011-04-11 Eli Zaretskii <eliz@gnu.org>
4564
4565 * xdisp.c (redisplay_window): Don't try to determine the character
4566 position of the scroll margin if the window start point w->startp
e896f03c 4567 is outside the buffer's accessible region. (Bug#8468)
11997c76 4568
8a2cbd72
EZ
45692011-04-10 Eli Zaretskii <eliz@gnu.org>
4570
4571 Fix write-region and its subroutines for buffers > 2GB.
4572 * fileio.c (a_write, e_write): Modify declaration of arguments and
4573 local variables to support buffers larger than 2GB.
4574 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4575
4576 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4577 argument, local variables, and return value.
4578
4579 * lisp.h: Update prototypes of emacs_write and emacs_read.
4580
4581 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4582
4073e537 45832011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4584
1ebfdcb6
PE
4585 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4586
b2ded58d
PE
4587 Fix more problems found by GCC 4.6.0's static checks.
4588
7d66342c
PE
4589 * xdisp.c (vmessage): Use a better test for character truncation.
4590
bbf47d44
PE
4591 * charset.c (load_charset_map): <, not <=, for optimization,
4592 and to avoid potential problems with integer overflow.
9248994d 4593 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4594 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4595 * editfns.c (Fformat): Likewise.
1e69125e 4596 * syntax.c (skip_chars): Likewise.
3befa583 4597
e3019616
PE
4598 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4599 This also lets GCC 4.6.0 generate slightly better loop code.
4600
becfa255
PE
4601 * callint.c (Fcall_interactively): <, not <=, for optimization.
4602 (Fcall_interactively): Count the number of arguments produced,
4603 not the number of arguments given. This is simpler and lets GCC
4604 4.6.0 generate slightly better code.
4605
dae0cd48
PE
4606 * ftfont.c: Distingish more carefully between FcChar8 and char.
4607 The previous code passed unsigned char * to a functions like
4608 strlen and xstrcasecmp that expect char *, which does not
4609 conform to the C standard.
4610 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4611 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4612 char * when the C standard requires it.
4613
76032d70
PE
4614 * keyboard.c (read_char): Remove unused var.
4615
eb3f1cc8
PE
4616 * eval.c: Port to Windows vsnprintf (Bug#8435).
4617 Include <limits.h>.
4618 (SIZE_MAX): Define if the headers do not.
4619 (verror): Do not give up if vsnprintf returns a negative count.
4620 Instead, grow the buffer. This ports to Windows vsnprintf, which
4621 does not conform to C99. Problem reported by Eli Zaretskii.
4622 Also, simplify the allocation scheme, by avoiding the need for
4623 calling realloc, and removing the ALLOCATED variable.
4624
70476b54
PE
4625 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4626
12020a9e
PE
4627 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4628 But keep the doprint source code for now, as we might revamp it
4629 and use it again (Bug#8435).
ea6c7ae6
PE
4630 * lisp.h (doprnt): Remove.
4631 * Makefile.in (base_obj): Remove doprnt.o.
4632 * deps.mk (doprnt.o): Remove.
4633
5fdb398c
PE
4634 error: Print 32- and 64-bit integers portably (Bug#8435).
4635 Without this change, on typical 64-bit hosts error ("...%d...", N)
4636 was used to print both 32- and 64-bit integers N, which relied on
4637 undefined behavior.
4638 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4639 New macro.
4640 * lisp.h (error, verror): Mark as printf-like functions.
4641 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4642 Report overflow in size calculations when allocating printf buffer.
4643 Do not truncate output string at its first null byte.
4644 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4645 Truncate the output at a character boundary, since vsnprintf does not
4646 do that.
4647 * charset.c (check_iso_charset_parameter): Convert internal
4648 character to string before calling 'error', since %c now has the
4649 printf meaning.
4650 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4651 overflow when computing char to be passed to 'error'. Do not
4652 pass Lisp_Object to 'error'; pass the integer instead.
4653 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4654 formatted with plain %d.
4655
b189fa66
PE
4656 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4657
bff87ef0
PE
4658 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4659
7e2cac20
PE
4660 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4661
ce4d90b5
PE
4662 * xterm.c (x_catch_errors): Remove duplicate declaration.
4663
266c9547
PE
4664 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4665
79c49ad2
PE
4666 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4667
368f4090
JM
46682011-04-10 Jim Meyering <meyering@redhat.com>
4669
4670 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4671 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4672 return ssize_t not "int", and use size_t as the buffer length.
4673 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4674 * gnutls.h: Update declarations.
4675 * process.c (read_process_output): Use ssize_t, to match.
4676 (send_process): Likewise.
4677
a32d4040
CY
46782011-04-09 Chong Yidong <cyd@stupidchicken.com>
4679
4680 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4681
8546720e 46822011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4683
04f2d78b
CB
4684 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4685 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4686
8546720e
GM
4687 * xterm.c (handle_one_xevent):
4688 * xmenu.c (create_and_show_popup_menu):
4689 * xselect.c (x_decline_selection_request)
4690 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4691
0a2f5c1a 46922011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4693
4694 Fix some uses of `int' instead of EMACS_INT.
4695 * search.c (string_match_1, fast_string_match)
4696 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4697 (scan_buffer, find_next_newline_no_quit)
4698 (find_before_next_newline, search_command, Freplace_match)
4699 (Fmatch_data): Make some `int' variables be EMACS_INT.
4700
4701 * xdisp.c (display_count_lines): 3rd argument and return value now
4702 EMACS_INT. All callers changed.
4703 (pint2hrstr): Last argument is now EMACS_INT.
4704
4705 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4706 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4707 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4708 (decode_coding_utf_16, decode_coding_emacs_mule)
4709 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4710 (decode_coding_ccl, decode_coding_charset)
4711 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4712 (decode_coding_iso_2022, decode_coding_emacs_mule)
4713 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4714 <char_offset, last_offset>: Declare EMACS_INT.
4715 (encode_coding_utf_8, encode_coding_utf_16)
4716 (encode_coding_emacs_mule, encode_invocation_designation)
4717 (encode_designation_at_bol, encode_coding_iso_2022)
4718 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4719 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4720 Declare EMACS_INT.
4721 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4722 (encode_invocation_designation): Last argument P_NCHARS is now
4723 EMACS_INT.
4724 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4725 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4726
4727 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4728 All users changed.
4729
4730 * ccl.c (Fccl_execute_on_string): Declare some variables
4731 EMACS_INT.
4732
8546720e 47332011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4734
4735 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4736
4e19a977
CS
47372011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4738
4739 * process.c (Fformat_network_address): Doc fix.
4740
87302331
R
47412011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4742
4743 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4744
cbb59342
CY
47452011-04-08 Chong Yidong <cyd@stupidchicken.com>
4746
4747 * keyboard.c (read_char): Call Lisp function help-form-show,
4748 instead of using internal_with_output_to_temp_buffer.
4749 (Qhelp_form_show): New var.
e0d38eeb 4750 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4751
4752 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4753
4754 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4755
e67a13ab
CY
47562011-04-06 Chong Yidong <cyd@stupidchicken.com>
4757
04f2d78b
CB
4758 * process.c (Flist_processes): Remove to Lisp.
4759 (list_processes_1): Delete.
e67a13ab 4760
973f782d
EZ
47612011-04-06 Eli Zaretskii <eliz@gnu.org>
4762
7c106b1e
EZ
4763 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4764
973f782d
EZ
4765 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4766
41cf7d1a 47672011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4768
ca23cc88
PE
4769 Fix more problems found by GCC 4.6.0's static checks.
4770
f390e2d5
PE
4771 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4772
42eea0d0
PE
4773 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4774
b69769da 4775 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4776
f9541e84
PE
4777 * xdisp.c (vmessage): Mark as a printf-like function.
4778
13841b55
PE
4779 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4780
c136c10f
PE
4781 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4782
5e2d4a30
PE
4783 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4784 printf-like functions.
4785 (tiff_load): Add casts to remove these marks before passing them
4786 to system-supplied API.
4787
583f48b9
PE
4788 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4789
b25d760e
PE
4790 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4791 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4792 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4793 directly, rather than having caller test rule sign. This avoids
4794 some unnecessary tests.
4795 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4796 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4797 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4798
bc7b6697 4799 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4800 (xfont_open): Avoid unnecessary tests.
bc7b6697 4801
27ccc379
PE
4802 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4803
dcd5c89a
PE
4804 * composite.h, composite.c (composition_gstring_put_cache):
4805 Use EMACS_INT, not int, for length.
4806
b13a45c6
PE
4807 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4808 breaking out part of COMPOSITION_DECODE_RULE.
4809 (COMPOSITION_DECODE_RULE): Use it.
4810 * composite.c (get_composition_id): Remove unused local vars,
4811 by using the new macro.
4812
1e792e4d
PE
4813 * textprop.c (set_text_properties_1): Change while to do-while,
4814 since the condition is always true at first.
4815
dc6c6455 4816 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4817 (interval_deletion_adjustment): Return unsigned value.
4818 All uses changed.
dc6c6455 4819
aba7731a
PE
4820 * process.c (list_processes_1, create_pty, read_process_output):
4821 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4822 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4823 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4824 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4825 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4826
fdfc4bf3
PE
4827 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4828
fca8fe46 4829 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4830 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4831
06a0259a 4832 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4833 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4834 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4835
e7b9e80f
PE
4836 * print.c (print_error_message): Avoid int overflow.
4837
56201685
PE
4838 * font.c (font_list_entities): Redo for clarity,
4839 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4840
78834453 4841 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4842 (font_score): Avoid potential overflow in diff calculation.
78834453 4843
0bc0b309 4844 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4845 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4846
e610eaca
PE
4847 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4848
b895abce
PE
4849 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4850 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4851 can always succeed if overflow has undefined behavior.
4852
1f1d9321 4853 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4854 (wordify): Omit three unnecessary tests.
1f1d9321 4855
c59478bc
PE
4856 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4857 All callers changed. This avoids the need for an unused var.
4858
79b73827
PE
4859 * casefiddle.c (casify_region): Remove var that is set but not used.
4860
a4db5dfe
PE
4861 * dired.c (file_name_completion): Remove var that is set but not used.
4862
43aae36e
PE
4863 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4864
2a47c44d 4865 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4866 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4867
a37c69bf
PE
4868 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4869 Check for integer overflow on size calculations.
4870
328ab8e7
PE
4871 * buffer.c (Fprevious_overlay_change): Remove var that is set
4872 but not used.
4873
e5a2a5cb
PE
4874 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4875 Remove vars that are set but not used.
8d84a6eb 4876 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4877 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4878
a60e5f68
PE
4879 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4880
f661cb61 4881 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4882 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4883
f0397f5a
PE
4884 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4885 that are set but not used.
4886
8664db06 4887 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4888 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4889
6abdaa4a
PE
4890 * xselect.c (x_get_local_selection, x_handle_property_notify):
4891 Remove vars that are set but not used.
4892
0ce7538d 4893 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4894 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4895
9ae848fc
PE
4896 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4897 Remove var that is set but not used.
0b918413
PE
4898 (scroll_bar_windows_size): Now size_t, not int.
4899 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4900 Check for overflow.
9ae848fc 4901
a5a62657
PE
4902 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4903 (map_tty_color) [!defined MSDOS]: Likewise.
4904
5c5cdd39
PE
4905 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4906
66ebf983
PE
4907 * coding.c: Remove vars that are set but not used.
4908 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4909 All callers changed.
4910 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4911 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4912 (decode_coding_charset): Remove vars that are set but not used.
4913
1be4d761
PE
4914 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4915 that is set but not used.
4916
47553fa8
PE
4917 * print.c (print_object): Remove var that is set but not used.
4918
1f7196bf 4919 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4920 The gnulib version avoids calling malloc in the usual case,
4921 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4922 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4923 * filelock.c (current_lock_owner): Likewise.
4924 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4925 * sysdep.c: Include allocator.h, careadlinkat.h.
4926 (emacs_no_realloc_allocator): New static constant.
4927 (emacs_readlink): New function.
fdb61804
PE
4928 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4929 ../lib/careadlinkat.h.
d1fdcab7 4930
f84c17c7
SM
49312011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4932
4933 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4934 first non-nil return value).
4935
ef3862ad
JD
49362011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4937
4938 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4939 if not defined (Bug#8403).
4940
376a7006
JB
49412011-04-02 Juanma Barranquero <lekktu@gmail.com>
4942
4943 * xdisp.c (display_count_lines): Remove parameter `start',
4944 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4945 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4946 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4947 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4948 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4949 and thereabouts. All callers changed.
4950 (get_per_char_metric): Remove parameter `f', unused since
4951 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4952
6ca3801d
JM
49532011-04-02 Jim Meyering <meyering@redhat.com>
4954
4955 do not dereference NULL upon failed strdup
4956 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4957 (ns_get_family): Likewise.
4958
d8e2b5ba
JB
49592011-04-02 Juanma Barranquero <lekktu@gmail.com>
4960
4961 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4962
8c74fcbd
JD
49632011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4964
4965 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4966 later (Bug#8403).
4967
7200d79c
SM
49682011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4969
03408648 4970 Add lexical binding.
7200d79c 4971
03408648
SM
4972 * window.c (Ftemp_output_buffer_show): New fun.
4973 (Fsave_window_excursion):
4974 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4975
4976 * lread.c (lisp_file_lexically_bound_p): New function.
4977 (Fload): Bind Qlexical_binding.
4978 (readevalloop): Remove `evalfun' arg.
4979 Bind Qinternal_interpreter_environment.
4980 (Feval_buffer): Bind Qlexical_binding.
4981 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4982 Mark as dynamic.
4983 (syms_of_lread): Declare `lexical-binding'.
4984
4985 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4986
4987 * keyboard.c (eval_dyn): New fun.
4988 (menu_item_eval_property): Use it.
ca105506
SM
4989
4990 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4991
03408648
SM
4992 * fns.c (concat, mapcar1): Accept byte-code-functions.
4993
4994 * eval.c (Fsetq): Handle lexical vars.
4995 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4996 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4997 (FletX, Flet): Obey lexical binding.
4998 (Fcommandp): Handle closures.
4999 (Feval): New `lexical' arg.
5000 (eval_sub): New function extracted from Feval. Use it almost
5001 everywhere where Feval was used. Look up vars in lexical env.
5002 Handle closures.
5003 (Ffunctionp): Move from subr.el.
5004 (Ffuncall): Handle closures.
5005 (apply_lambda): Remove `eval_flags'.
5006 (funcall_lambda): Handle closures and new byte-code-functions.
5007 (Fspecial_variable_p): New function.
5008 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5009 but without exporting it to Lisp.
23aba0ea 5010
23aba0ea 5011 * doc.c (Fdocumentation, store_function_docstring):
03408648 5012 * data.c (Finteractive_form): Handle closures.
23aba0ea 5013
03408648
SM
5014 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5015 interactive spec.
ba83908c 5016
04f2d78b
CB
5017 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5018 New byte-codes.
03408648
SM
5019 (exec_byte_code): New function extracted from Fbyte_code to handle new
5020 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5021
03408648 5022 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5023
03408648 5024 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5025
e2abce01
JB
50262011-03-31 Juanma Barranquero <lekktu@gmail.com>
5027
5028 * xdisp.c (redisplay_internal): Fix prototype.
5029
63696a73 50302011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5031
63696a73 5032 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5033 (try_scrolling): Use it when setting scroll_limit.
5034 Limit scrolling to 100 screen lines.
63696a73
EZ
5035 (redisplay_window): Even when falling back on "recentering",
5036 position point in the window according to scroll-conservatively,
5037 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5038
5039 (try_scrolling): When point is above the window, allow searching
5040 as far as scroll_max, or one screenful, to compute vertical
5041 distance from PT to the scroll margin position. This prevents
5042 try_scrolling from unnecessarily failing when
5043 scroll-conservatively is set to a value slightly larger than the
5044 window height. Clean up the case of PT below the margin at bottom
5045 of window: scroll_max can no longer be INT_MAX. When aggressive
5046 scrolling is in use, don't let point enter the opposite scroll
5047 margin as result of the scroll.
5048 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5049 threshold of 100 lines for never-recentering scrolling.
5050
e4cc2dfc
JB
50512011-03-31 Juanma Barranquero <lekktu@gmail.com>
5052
5053 * dispextern.h (move_it_by_lines):
5054 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5055 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5056 (message_log_check_duplicate): Remove parameters `prev_bol' and
5057 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5058 (redisplay_internal): Remove parameter `preserve_echo_area',
5059 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5060
5061 * indent.c (Fvertical_motion):
5062 * window.c (window_scroll_pixel_based, Frecenter):
5063 Don't pass `need_y_p' to `move_it_by_lines'.
5064
1c470562
SM
50652011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5066
44f230aa
SM
5067 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5068 steal a few bits to be more compact.
5069 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5070 Remove unneeded casts.
5071
1c470562
SM
5072 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5073
888adce9
ZK
50742011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5075
5076 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5077 binding" message (bug#7967).
5078
f838ed7b
PE
50792011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5080
77861b95
PE
5081 Fix more problems found by GCC 4.6.0's static checks.
5082
de6dbc14
PE
5083 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5084 Remove unused local var.
5085
f838ed7b
PE
5086 * editfns.c (Fmessage_box): Remove unused local var.
5087
792c7b2b
PE
5088 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5089 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5090 Omit unused local vars.
c499e557 5091 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5092 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5093 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5094 Omit unused local var.
5095
ba0165e1
PE
5096 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5097 Don't assume string length fits in int.
32ad8845 5098 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5099 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5100
3c59b4c9
PE
5101 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5102 instead of alloca (Bug#8344).
5103
a3eed478 5104 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5105 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5106
eb4d412d
PE
5107 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5108
1658b401
PE
5109 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5110 concerns.
5111
5112 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5113
5114 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5115
9a2c6e05
PE
5116 * keyboard.c (syms_of_keyboard): Use the same style as later
5117 in this function when indexing through an array. This also
5118 works around GCC bug 48267.
5119
03d0a109
PE
5120 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5121
44f730c8
PE
5122 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5123
fe75f926
PE
5124 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5125 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5126
ffa8c828
PE
5127 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5128 This avoids undefined behavior on integer overflow, and is a bit
5129 more convenient anyway since it is compared to a size_t variable.
5130
c5101a77
PE
5131 Variadic C functions now count arguments with size_t, not int.
5132 This avoids an unnecessary limitation on 64-bit machines, which
5133 caused (substring ...) to crash on large vectors (Bug#8344).
5134 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5135 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5136 All variadic functions and their callers changed accordingly.
c5101a77
PE
5137 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5138 * data.c (arith_driver, float_arith_driver): Likewise.
5139 * editfns.c (general_insert_function): Likewise.
5140 * eval.c (struct backtrace.nargs, interactive_p)
5141 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5142 (funcall_lambda, mark_backtrace): Likewise.
5143 * fns.c (concat): Likewise.
5144 * frame.c (x_set_frame_parameters): Likewise.
5145 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5146 0 if not found, not -1. All callers changed.
5147
dd3f25f7
PE
5148 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5149 (stack_copy_size): Now size_t, not int.
5150 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5151
461c2ab9
JB
51522011-03-28 Juanma Barranquero <lekktu@gmail.com>
5153
5154 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5155 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5156 All callers changed.
5157
5158 * lisp.h (multibyte_char_to_unibyte):
5159 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5160 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5161 * character.h (CHAR_TO_BYTE8):
5162 * cmds.c (internal_self_insert):
5163 * editfns.c (general_insert_function):
5164 * keymap.c (push_key_description):
5165 * search.c (Freplace_match):
5166 * xdisp.c (message_dolog, set_message_1): All callers changed.
5167
f6d62986
SM
51682011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5169
5170 * keyboard.c (safe_run_hook_funcall): New function.
5171 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5172 don't set the hook to nil, but remove the offending function instead.
5173 (Qcommand_hook_internal): Remove, unused.
5174 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5175 Vcommand_hook_internal.
5176
5177 * eval.c (enum run_hooks_condition): Remove.
5178 (funcall_nil, funcall_not): New functions.
5179 (run_hook_with_args): Call each function through a `funcall' argument.
5180 Remove `cond' argument, now redundant.
5181 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5182 (Frun_hook_with_args_until_failure): Adjust accordingly.
5183 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5184
1db5b1ad
JB
51852011-03-28 Juanma Barranquero <lekktu@gmail.com>
5186
5187 * dispextern.h (string_buffer_position): Remove declaration.
5188
5189 * print.c (strout): Remove parameter `multibyte', unused since
5190 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5191
5192 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5193 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5194 All callers changed.
5195
5196 * w32.c (_wsa_errlist): Use braces for struct initializers.
5197
5198 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5199 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5200 All callers changed.
5201 (string_buffer_position): Likewise. Also, make static (it's never
5202 used outside xdisp.c).
5203 (cursor_row_p): Remove parameter `w', unused since
5204 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5205 (decode_mode_spec): Remove parameter `precision', introduced during
5206 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5207 All callers changed.
5208
5ffb62aa
JD
52092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5210
5211 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5212
461c2ab9 52132011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5214
5215 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5216 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5217 (ns_update_auto_hide_menu_bar): New functions.
5218 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5219 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5220 ns_constrain_all_frames.
5221 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5222 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5223
5c380ffb
JD
52242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5225
5226 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5227
9af30bdf
GM
52282011-03-27 Glenn Morris <rgm@gnu.org>
5229
5230 * syssignal.h: Replace RETSIGTYPE with void.
5231 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5232 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5233 Replace SIGTYPE with void everywhere.
5234 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5235 * s/template.h (SIGTYPE): Remove commented out definition.
5236
e2abce01
JB
52372011-03-26 Eli Zaretskii <eliz@gnu.org>
5238
5239 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5240 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5241
f868cd8a
JB
52422011-03-26 Juanma Barranquero <lekktu@gmail.com>
5243
59eb0929
JB
5244 * w32.c (read_unc_volume): Use parameter `henum', instead of
5245 global variable `wget_enum_handle'.
5246
5247 * keymap.c (describe_vector): Remove parameters `indices' and
5248 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5249 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5250
f868cd8a
JB
5251 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5252
5253 * keyboard.c (timer_check): Remove parameter `do_it_now',
5254 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5255 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5256 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5257
5258 * keyboard.c (read_char):
5259 * w32menu.c (w32_menu_display_help):
5260 * xmenu.c (show_help_event, menu_help_callback):
5261 Adjust calls to `show_help_echo'.
5262
5263 * gtkutil.c (xg_maybe_add_timer):
5264 * keyboard.c (readable_events):
5265 * process.c (wait_reading_process_output):
5266 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5267
5268 * insdel.c (adjust_markers_gap_motion):
5269 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5270 (gap_left, gap_right): Don't call it.
5271
2ecf6fdb
CY
52722011-03-25 Chong Yidong <cyd@stupidchicken.com>
5273
5274 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5275 incurred during fontification.
5276
6b1f9ba4
JB
52772011-03-25 Juanma Barranquero <lekktu@gmail.com>
5278
5279 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5280 (DEFVAR_PER_BUFFER): Don't pass it.
5281
5282 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5283 (scrolling_window): Don't pass it.
5284
0f4a96b5
JB
52852011-03-25 Juanma Barranquero <lekktu@gmail.com>
5286
5287 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5288
5289 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5290 and `suffix'.
5291 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5292 of variables specific to SELinux and computation of `encoded_absname'.
5293
5294 * image.c (XPutPixel): Remove unused variable `height'.
5295
5296 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5297
5298 * unexw32.c (get_section_info): Remove unused variable `section'.
5299
5300 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5301 (system_process_attributes): Remove unused variable `sess'.
5302 (sys_read): Remove unused variable `err'.
5303
5304 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5305 (w32_wnd_proc): Remove unused variable `isdead'.
5306 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5307 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5308 (x_create_tip_frame): Remove unused variable `tem'.
5309
5310 * w32inevt.c (w32_console_read_socket):
5311 Remove unused variable `no_events'.
5312
5313 * w32term.c (x_draw_composite_glyph_string_foreground):
5314 Remove unused variable `width'.
5315
1149507c
JB
53162011-03-24 Juanma Barranquero <lekktu@gmail.com>
5317
5318 * w32term.c (x_set_glyph_string_clipping):
5319 Don't pass uninitialized region to CombineRgn.
5320
9c88f339
JB
53212011-03-23 Juanma Barranquero <lekktu@gmail.com>
5322
5323 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5324 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5325 (Fx_close_connection): Remove unused variable `i'.
5326
5327 * w32font.c (w32font_draw): Return number of glyphs.
5328 (w32font_open_internal): Remove unused variable `i'.
5329 (w32font_driver): Add missing initializer.
5330
5331 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5332 (fill_in_menu): Remove unused variable `items_added'.
5333
5334 * w32term.c (last_mouse_press_frame): Remove static global variable.
5335 (w32_clip_to_row): Remove unused variable `f'.
5336 (x_delete_terminal): Remove unused variable `i'.
5337
5338 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5339 (NOTHING): Remove unused static global variable.
5340 (uniscribe_check_otf): Remove unused variable `table'.
5341 (uniscribe_font_driver): Add missing initializers.
5342
dee091a3
JD
53432011-03-23 Julien Danjou <julien@danjou.info>
5344
5345 * term.c (Fsuspend_tty, Fresume_tty):
5346 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5347 * window.c (temp_output_buffer_show):
5348 * insdel.c (signal_before_change):
5349 * frame.c (Fhandle_switch_frame):
5350 * fileio.c (Fdo_auto_save):
5351 * emacs.c (Fkill_emacs):
5352 * editfns.c (save_excursion_restore):
5353 * cmds.c (internal_self_insert):
5354 * callint.c (Fcall_interactively):
5355 * buffer.c (Fkill_all_local_variables):
5356 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5357 Use Frun_hooks.
0f4a96b5 5358 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5359 unconditionnaly since it does the check itself.
5360
2c520ab5 53612011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5362
c9c49752
PE
5363 Fix more problems found by GCC 4.5.2's static checks.
5364
8abc3f12
PE
5365 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5366 the first time through the loop, since we know p0 < p1 then.
5367 This also avoids a gcc -Wstrict-overflow warning.
5368
a2d26660
PE
5369 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5370 leading to a memory leak, possible in functions like
5371 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5372 of objects (Bug#8318).
a2d26660 5373
916c72e9
PE
5374 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5375 that could (at least in theory) be that large.
5376
19ab8a18
PE
5377 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5378 This is less likely to overflow, and avoids undefined behavior if
5379 overflow does occur. All callers changed. Use strtoul to scan
5380 for the unsigned long integer.
b7cbbd6f
PE
5381 (pint2hrstr): Simplify and tune code slightly.
5382 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5383
f0641eff
PE
5384 * scroll.c (do_scrolling): Work around GCC bug 48228.
5385 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5386
7f650bb9
PE
5387 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5388 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5389 (validate_x_resource_name): Simplify count usage.
5390 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5391
37dd57d1
PE
5392 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5393 fail (Bug#8306).
81e56e61 5394
699979fc 5395 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5396
401bf9b4
PE
5397 * process.c (Fmake_network_process): Use socklen_t, not int,
5398 where POSIX says socklen_t is required in portable programs.
5399 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5400 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5401 (Fmake_network_process, server_accept_connection):
5402 (wait_reading_process_output, read_process_output):
5403 Likewise.
5404
b93aacde
PE
5405 * process.c: Rename or move locals to avoid shadowing.
5406 (list_processes_1, Fmake_network_process):
5407 (read_process_output_error_handler, exec_sentinel_error_handler):
5408 Rename or move locals.
4dc343ee 5409 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5410 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5411 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5412 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5413 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5414
af8a867c 5415 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5416 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5417 Include tparam.h instead, since it declares them.
af8a867c
PE
5418 * cm.h (PC): Remove extern decl; tparam.h now does this.
5419 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5420 * terminfo.c: Include tparam.h, to check interfaces.
5421 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5422 (tparam): Adjust signature to match interface in tparam.h;
5423 this removes some undefined behavior. Check that outstring and len
5424 are zero, which they always are with Emacs.
5425 * tparam.h (PC, BC, UP): New extern decls.
5426
0248044d 5427 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5428 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5429
8ff096c1 5430 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5431 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5432 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5433 (ftfont_list): Remove unused local.
49eaafba
PE
5434 (get_adstyle_property, ftfont_pattern_entity):
5435 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5436 Rename locals to avoid shadowing.
8ff096c1 5437
e2be39f6
PE
5438 * xfont.c (xfont_list_family): Mark var as initialized.
5439
c9735e30
PE
5440 * xml.c (make_dom): Now static.
5441
8f5201ae
PE
5442 * composite.c (composition_compute_stop_pos): Rename local to
5443 avoid shadowing.
b246f932
PE
5444 (composition_reseat_it): Remove unused locals.
5445 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5446 (composition_update_it): Mark var as initialized.
11b61122
PE
5447 (find_automatic_composition): Mark vars as initialized,
5448 with a FIXME (Bug#8290).
8f5201ae 5449
760fbc2c
PE
5450 character.h: Rename locals to avoid shadowing.
5451 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5452 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5453 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5454 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5455 to avoid shadowing.
5456
ff08eb85
PE
5457 * textprop.c (property_change_between_p): Remove; unused.
5458
fc7bf025
PE
5459 * intervals.c (interval_start_pos): Now static.
5460
235d7abc
PE
5461 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5462
44f230aa
SM
5463 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5464 Rename locals to avoid shadowing.
3e7d6594 5465
50060332
PE
5466 * sound.c (wav_play, au_play, Fplay_sound_internal):
5467 Fix pointer signedness.
d01f234b 5468 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5469 (wav_play): Initialize a variable to 0, to prevent undefined
5470 behavior (Bug#8278).
50060332 5471
c4fc4e30
PE
5472 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5473
918436ed
PE
5474 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5475
c939f91b
PE
5476 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5477 clobbering (Bug#8298).
b9c7f648
PE
5478 * sysdep.c (sys_subshell): Likewise.
5479 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5480
6bd8c144
PE
5481 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5482 This should get cleaned up, so that child_setup has the
5483 same signature on all platforms.
5484
7710357c 5485 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5486 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5487
c59da222
CY
54882011-03-22 Chong Yidong <cyd@stupidchicken.com>
5489
5490 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5491 not to be necessary, and produces flickering.
5492
66b87493
GM
54932011-03-20 Glenn Morris <rgm@gnu.org>
5494
5495 * config.in: Remove file.
5496
45b6f6d5
JB
54972011-03-20 Juanma Barranquero <lekktu@gmail.com>
5498
5499 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5500 are now in src/globals.h.
5501 (syms_of_minibuf): Remove spurious & from previous change.
5502
3ec03f7e
LL
55032011-03-20 Leo <sdl.web@gmail.com>
5504
5505 * minibuf.c (completing-read-function): New variable.
5506 (completing-read-default): Rename from completing-read.
5507 (completing-read): Call completing-read-function.
5508
b14e3e21
CY
55092011-03-19 Juanma Barranquero <lekktu@gmail.com>
5510
5511 * xfaces.c (Fx_load_color_file):
5512 Read color file from absolute filename (bug#8250).
5513
f2b726e6
JB
55142011-03-19 Juanma Barranquero <lekktu@gmail.com>
5515
5516 * makefile.w32-in: Update dependencies.
5517
09f6ff02
EZ
55182011-03-17 Eli Zaretskii <eliz@gnu.org>
5519
5520 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5521
29a6015a
PE
55222011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5523
a3a6c54e
PE
5524 Fix more problems found by GCC 4.5.2's static checks.
5525
b766f867
PE
5526 * process.c (make_serial_process_unwind, send_process_trap):
5527 (sigchld_handler): Now static.
5528
be02381c
PE
5529 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5530 That way, the code declares only the vars that it needs.
5531 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5532 * s/cygwin.h (PTY_ITERATION): Likewise.
5533 * s/darwin.h (PTY_ITERATION): Likewise.
5534 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5535
57048744
PE
5536 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5537 * process.c (allocate_pty): Don't declare stb unless it's needed.
5538
7914961c 5539 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5540 (CONSTANTLIM): Remove; unused.
5541 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5542 Define only if needed.
7914961c 5543
b3967b18
PE
5544 * unexelf.c (unexec): Name an expression,
5545 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5546 Use a different way to cause a compilation error if anyone uses
5547 n rather than nn, a way that does not involve shadowing.
73366a00 5548 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5549
29a6015a
PE
5550 * deps.mk (unexalpha.o): Remove; unused.
5551
43cfc33e 5552 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5553 * unexec.h: New file.
ce701a33
PE
5554 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5555 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5556 Depend on unexec.h.
5557 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5558 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5559 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5560 Change as necessary to match prototype in unexec.h.
ce701a33 5561
01f44d5a
PE
5562 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5563 shadowing.
4f63c6bb 5564 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5565
a6670b0b
PE
5566 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5567 Rename locals to avoid shadowing.
5568
cef2010d 5569 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5570 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5571
d4d7173a
PE
5572 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5573
f08b802a
PE
5574 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5575 warning when compiling print.c.
5576
3ddb0639
PE
5577 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5578 instead of using an uninitialized var.
5ad03b97 5579 (font_sort_entities): Mark var as initialized.
3ddb0639 5580
170a2692
PE
5581 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5582
e663c700
PE
5583 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5584 pointers to constants.
89bc529a 5585 (font_parse_fcname): Remove unused vars.
7b81e2d0 5586 (font_delete_unmatched): Now static.
ea838e10 5587 (font_get_spec): Remove; unused.
13a547c6
PE
5588 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5589 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5590 Rename or move locals to avoid shadowing.
e663c700 5591
2a80c887 5592 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5593 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5594
1384fa33 5595 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5596 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5597
8b2c52e9
PE
5598 * alloc.c (mark_backtrace): Move decl from here ...
5599 * lisp.h: ... to here, so that it can be checked.
5600
475545b5 5601 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5602 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5603 (lisp_indirect_variable): Name an expression,
5604 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5605 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5606
b1349114 5607 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5608 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5609 Use const pointer when appropriate.
b1349114 5610
a2928364
PE
5611 * lisp.h (get_system_name, get_operating_system_release):
5612 Move decls here, to check interfaces.
5613 * process.c (get_operating_system_release): Move decl to lisp.h.
5614 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5615 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5616 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5617 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5618 (Fformat_time_string, Fencode_time, Finsert_char):
5619 (Ftranslate_region_internal, Fformat):
5620 Rename or remove local vars to avoid shadowing.
9710023e 5621 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5622
a415e694
PE
5623 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5624 avoid shadowing.
5625
8ef4622d
PE
5626 * lisp.h (eassert): Check that the argument compiles, even if
5627 ENABLE_CHECKING is not defined.
5628
946f9a5b
PE
5629 * data.c (Findirect_variable): Name an expression, to avoid
5630 gcc -Wbad-function-cast warning.
112396d6 5631 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5632 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5633 (Fmake_variable_buffer_local, Fmake_local_variable):
5634 Mark variables as initialized.
52746918 5635 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5636
e5aab7e7 5637 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5638 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5639 Rename locals to avoid shadowing.
dff45157
PE
5640 (mark_stack): Move local variables into the #ifdef region where
5641 they're used.
7bc26fdb
PE
5642 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5643 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5644 needed otherwise.
5645 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5646 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5647 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5648
e5aab7e7
PE
5649 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5650 avoids undefined behavior in theory.
5651
4da60324
PE
5652 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5653
88043301
PE
5654 Use functions, not macros, for up- and down-casing (Bug#8254).
5655 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5656 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5657 to use the following functions instead of these macros.
5658 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5659 EMACS_INT, since callers assume the returned value fits in int.
5660 (upcase1): Likewise, for UPCASE_TABLE.
5661 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5662 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5663 the race-condition problem in the old DOWNCASE.
88043301 5664
19ed5445
PE
5665 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5666 Rename locals to avoid shadowing.
5667 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5668 (regex_compile, re_search_2, re_match_2_internal):
5669 Remove unused local vars.
952db0d7
PE
5670 (FREE_VAR): Rewrite so as not to use empty "else",
5671 which gcc can warn about.
da053e48 5672 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5673 (RETALLOC_IF): Define only if needed.
5674 (WORDCHAR_P): Likewise. This one is never needed, but is used
5675 only in a comment talking about a compiler bug, so put inside
5676 the #if 0 of that comment.
5677 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5678 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5679 Remove; unused.
19ed5445 5680
1f3561e4 5681 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5682 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5683 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5684
ded6f8f7
PE
5685 * search.c (simple_search): Remove unused var.
5686
dbd37a95
PE
5687 * dired.c (compile_pattern): Move decl from here ...
5688 * lisp.h: ... to here, so that it can be checked.
5689 (struct re_registers): New forward decl.
5690
7e47afad
PE
5691 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5692
85f24f61
PE
5693 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5694 All uses changed.
5695 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5696 Rename locals to avoid shadowing.
5671df8f 5697 (Fvertical_motion): Mark locals as initialized.
85f24f61 5698
181aa2be 5699 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5700 (casify_region): Mark local as initialized.
181aa2be 5701
930d429c
PE
5702 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5703
7082eac6
PE
5704 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5705 New macros, so that the caller can use some names other than
5706 gcpro1, gcpro2, etc.
5707 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5708 of the new macros.
5709 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5710 argument, for consistency with GCPRO2_VAR, etc: it is now the
5711 prefix of the variable, not the variable itself. All uses
5712 changed.
38b2c076
PE
5713 * dired.c (directory_files_internal, file_name_completion):
5714 Rename locals to avoid shadowing.
5715
15206ed9
PE
5716 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5717 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5718 dired.c's scmp function, had undefined behavior.
5719 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5720 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5721 * buffer.h: ... to here, because these macros use current_buffer,
5722 and the new implementation with inline functions needs to have
5723 current_buffer in scope now, rather than later when the macros
5724 are used.
5725 (downcase, upcase1): New static inline functions.
5726 (DOWNCASE, UPCASE1): Reimplement using these functions.
5727 This avoids undefined behavior in expressions like
5728 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5729 from race conditions in accessing the global variables
5730 case_temp1 and case_temp2.
5731 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5732 * lisp.h (case_temp1, case_temp2): Remove their decls.
5733 * character.h (ASCII_CHAR_P): Move from here ...
5734 * lisp.h: ... to here, so that the inline functions mentioned
5735 above can use them.
5736
4a6bea26
PE
5737 * dired.c (directory_files_internal_unwind): Now static.
5738
f14b7e14
PE
5739 * fileio.c (file_name_as_directory, directory_file_name):
5740 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5741 Now static.
2893f146
PE
5742 (file_name_as_directory): Use const pointers when appropriate.
5743 (Fexpand_file_name): Likewise. In particular, newdir might
5744 point at constant storage, so make it a const pointer.
fd4ead52 5745 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5746 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5747 signedness issues.
f839df0c
PE
5748 (Fset_file_times, Finsert_file_contents, auto_save_error):
5749 Rename locals to avoid shadowing.
f14b7e14 5750
5716756e 5751 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5752 (Ftry_completion, Fall_completions): Rename or remove locals
5753 to avoid shadowing.
5716756e 5754
b4c3046a
PE
5755 * marker.c (bytepos_to_charpos): Remove; unused.
5756
b45db522
PE
5757 * lisp.h (verify_bytepos, count_markers): New decls,
5758 so that gcc does not warn that these functions aren't declared.
5759
85876d07
PE
5760 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5761 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5762 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5763 (copy_text): Remove unused local var.
85876d07 5764
03d78a21 5765 * filelock.c (within_one_second): Now static.
b3dd38ab 5766 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5767
5df8f01b
PE
5768 * buffer.c (fix_overlays_before): Mark locals as initialized.
5769 (fix_start_end_in_overlays): Likewise. This function should be
5770 simplified by using pointers-to-pointers, but that's a different
5771 matter.
b1d876f1 5772 (switch_to_buffer_1): Now static.
8f54f30a
PE
5773 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5774 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5775
a70072c9 5776 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5777 Fix pointer signedness issue.
edced198
PE
5778 (sys_subshell): Mark local as volatile if checking for lint,
5779 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5780 (MAXPATHLEN): Define only if needed.
a70072c9 5781
a0977c44
PE
5782 * process.c (serial_open, serial_configure): Move decls from here ...
5783 * systty.h: ... to here, so that they can be checked.
5784
a884fdcc
PE
5785 * fns.c (get_random, seed_random): Move extern decls from here ...
5786 * lisp.h: ... to here, so that they can be checked.
5787
604efe86 5788 * sysdep.c (reset_io): Now static.
b8950c94 5789 (wait_for_termination_signal): Remove; unused.
604efe86 5790
38fc62d9
PE
5791 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5792 (copy_keymap_item, append_key, push_text_char_description):
5793 Now static.
1004a21a 5794 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5795 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5796 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5797 (describe_map_tree):
5798 Rename locals to avoid shadowing.
38fc62d9 5799
2f2650da
PE
5800 * keyboard.c: Declare functions static if they are not used elsewhere.
5801 (echo_char, echo_dash, cmd_error, top_level_2):
5802 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5803 (read_char, kbd_buffer_get_event, make_lispy_position):
5804 (make_lispy_event, make_lispy_movement, apply_modifiers):
5805 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5806 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5807 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5808 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5809 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5810
a053e86c 5811 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5812 (mark_kboards): Move decl here ...
5813 * alloc.c (mark_kboards): ... from here.
a053e86c 5814
4752793e
PE
5815 * lisp.h (force_auto_save_soon): New decl.
5816
74f10ca7 5817 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5818 (DEFINE_DUMMY_FUNCTION): New macro.
5819 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5820 Use it.
c03cd23f
PE
5821 (main): Add casts to avoid warnings
5822 if GCC considers string literals to be constants.
74f10ca7 5823
022e70d4
PE
5824 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5825
59d6fe83
PE
5826 * dbusbind.c: Pointer signedness fixes.
5827 (xd_signature, xd_append_arg, xd_initialize):
5828 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5829 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5830 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5831 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5832
78320123
PE
5833 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5834 if GCC considers string literals to be constants.
49cebcca 5835 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5836
35ac2a97
SM
58372011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5838
fb103ca9
SM
5839 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5840 (print_preprocess, print_object): New macro to fix last change.
5841
35ac2a97
SM
5842 * print.c (print_preprocess): Don't forget font objects.
5843
62973b41
JB
58442011-03-16 Juanma Barranquero <lekktu@gmail.com>
5845
5846 * emacs.c (USAGE3): Doc fixes.
5847
0e48bb22
AS
58482011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5849
5850 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5851 structure.
5852
7684e57b
JB
58532011-03-14 Juanma Barranquero <lekktu@gmail.com>
5854
5855 * lisp.h (VWindow_system, Qfile_name_history):
5856 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5857 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5858 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5859
5860 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5861 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5862
5863 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5864 * w32console.c (detect_input_pending, read_input_pending)
5865 (encode_terminal_code):
5866 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5867 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5868 (w32_system_caret_y, Qfile_name_history):
5869 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5870 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5871 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5872 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5873 * w32proc.c (Qlocal, report_file_error):
5874 * w32term.c (Vwindow_system, updating_frame):
5875 * w32uniscribe.c (initialized, uniscribe_font_driver):
5876 Remove unneeded extern declarations.
5877
2aa46d6c
CY
58782011-03-14 Chong Yidong <cyd@stupidchicken.com>
5879
c96bbc66 5880 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5881
cffc6f3b
CY
58822011-03-13 Chong Yidong <cyd@stupidchicken.com>
5883
5884 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5885 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5886 These macros can no longer be used for assignment.
5887
44f230aa
SM
5888 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5889 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5890 (record_buffer_markers, fetch_buffer_markers): New functions for
5891 recording and fetching special buffer markers.
5892 (set_buffer_internal_1, set_buffer_temp): Use them.
5893
5894 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5895
5896 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5897
5898 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5899 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5900
5901 * xdisp.c (hscroll_window_tree):
5902 (reconsider_clip_changes): Use PT instead of BUF_PT.
5903
d251f04b
EZ
59042011-03-13 Eli Zaretskii <eliz@gnu.org>
5905
5906 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5907 $(EMACS_ROOT)/lib/intprops.h.
5908
f0c77cd1
PE
59092011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5910
3eca4629
PE
5911 Fix more problems found by GCC 4.5.2's static checks.
5912
7c86ee98
PE
5913 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5914 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5915 (xg_free_frame_widgets): Make it clear that a local variable is
5916 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5917 (gdk_window_get_screen): Make it clear that this macro is needed
5918 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5919 (int_gtk_range_get_value): New function, which avoids a diagnostic
5920 from gcc -Wbad-function-cast.
5921 (xg_set_toolkit_scroll_bar_thumb): Use it.
5922 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5923 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5924 (get_utf8_string, xg_get_file_with_chooser):
5925 Rename locals to avoid shadowing.
5926 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5927
41729b81
PE
5928 * xgselect.c (xg_select): Remove unused var.
5929
f0c77cd1
PE
5930 * image.c (four_corners_best): Mark locals as initialized.
5931 (gif_load): Initialize transparent_p to zero (Bug#8238).
5932 Mark another local as initialized.
ec6cf4c6 5933 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5934
ce0ad53d 5935 * image.c (clear_image_cache): Now static.
d5d5a617 5936 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5937 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5938 (x_edge_detection): Remove unnecessary cast that
5939 gcc -Wbad-function-cast diagnoses.
2037898d 5940 (gif_load): Fix pointer signedness.
6ae141d6
PE
5941 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5942 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5943
33383987 59442011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5945
d32df629
PE
5946 Improve quality of tests for time stamp overflow.
5947 For example, without this patch (encode-time 0 0 0 1 1
5948 1152921504606846976) returns the obviously-bogus value (-948597
5949 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5950 reports time overflow. See
5951 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5952 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5953 * editfns.c: Include limits.h and intprops.h.
5954 (TIME_T_MIN, TIME_T_MAX): New macros.
5955 (time_overflow): Move earlier, to before first use.
5956 (hi_time, lo_time): New functions, for an accurate test for
5957 out-of-range times.
5958 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5959 (Fget_internal_run_time): Don't assume time_t fits in int.
5960 (make_time): Use list2 instead of Fcons twice.
5961 (Fdecode_time): More accurate test for out-of-range times.
5962 (check_tm_member): New function.
5963 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5964 (lisp_time_argument): Don't rely on undefined left-shift and
5965 right-shift behavior when checking for time stamp overflow.
8be6f318 5966
fe31d94c
PE
5967 * editfns.c (time_overflow): New function, refactoring common code.
5968 (Fformat_time_string, Fdecode_time, Fencode_time):
5969 (Fcurrent_time_string): Use it.
5970
8be6f318
PE
5971 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5972 * dired.c (make_time): Move to ...
5973 * editfns.c (make_time): ... here.
5974 * systime.h: Note the move.
5975
09d9db2c 59762011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5977
126bc0dc
YM
5978 * fringe.c (update_window_fringes): Remove unused variables.
5979
c47cbdfd
YM
5980 * unexmacosx.c (copy_data_segment): Also copy __got section.
5981 (Bug#8223)
5982
7ac80be9
EZ
59832011-03-12 Eli Zaretskii <eliz@gnu.org>
5984
c96bbc66 5985 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5986 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5987 Constify `char *' arguments and their references according to
5988 prototypes in tparam.h.
5989
ecb0f94d 5990 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5991
7ac80be9
EZ
5992 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5993 Adapt all references accordingly.
5994
5995 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5996
ef1fd07e
TT
59972011-03-11 Tom Tromey <tromey@redhat.com>
5998
5999 * buffer.c (syms_of_buffer): Remove obsolete comment.
6000
7ef4b50c
EZ
60012011-03-11 Eli Zaretskii <eliz@gnu.org>
6002
6003 * termhooks.h (encode_terminal_code): Declare prototype.
6004
6005 * msdos.c (encode_terminal_code): Don't declare prototype.
6006
6007 * term.c (encode_terminal_code): Now external again, used by
6008 w32console.c and msdos.c.
6009
44f230aa
SM
6010 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6011 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6012
4b1ec863 60132011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6014
1714f52b 6015 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6016
4b1ec863
PE
6017 * fringe.c (update_window_fringes): Mark locals as initialized
6018 (Bug#8227).
6019 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6020
524c7aa6
PE
6021 * alloc.c (mark_fringe_data): Move decl from here ...
6022 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6023 to check its interface.
6024 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6025
a5c0af81 6026 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6027 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6028 (fontset_font): Mark local as initialized.
a9a06e0b 6029 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6030
b4716021
PE
6031 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6032
811e9bac 6033 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6034 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6035 (x_own_selection, Fx_disown_selection_internal): Rename locals
6036 to avoid shadowing.
6037 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6038
7e3ab302
PE
6039 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6040 so that the caller can use some name other than gcpro1.
6041 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6042 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6043 (Fx_backspace_delete_keys_p):
6044 Use them to avoid shadowing, and rename vars to avoid shadowing.
6045 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6046 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6047 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6048 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6049 Remove unused locals.
7e3ab302
PE
6050 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6051 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6052 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6053 macros.
f78faa98 6054
e2b13473
PE
6055 * xterm.h (x_mouse_leave): New decl.
6056
77f23912
PE
6057 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6058 Remove unused functions.
cdf4ba58
PE
6059 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6060 (x_calc_absolute_position): Now static.
7411c686 6061 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6062 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6063 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6064 unless they are used.
38d0b34a
PE
6065 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6066 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6067 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6068 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6069 (x_error_catcher, x_connection_closed, x_error_handler):
6070 (x_error_quitter, xembed_send_message, x_iconify_frame):
6071 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6072 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6073 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6074
44f230aa
SM
6075 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6076 Rename or move locals to avoid shadowing.
6b463e58 6077 (tty_defined_color, merge_face_heights): Now static.
5967d051 6078 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6079 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6080 does not deduce is never used uninitialized.
73719eba
PE
6081 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6082 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6083
426994c3 6084 * terminal.c (store_terminal_param): Now static.
5489860b 6085
032f1620 6086 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6087 (set_frame_menubar): Remove unused local.
d4323972 6088 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6089 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6090 since they might point to immutable storage.
281585b0
PE
6091 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6092 since it's unused otherwise.
032f1620 6093
367c19e5 6094 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6095 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6096 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6097 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6098 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6099 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6100 does not deduce are never used uninitialized.
70739cbe 6101
07b48fa9
PE
6102 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6103
8868a238 6104 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6105 * window.c (window_loop, size_window):
6106 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6107
7e5cf297 6108 * window.c (display_buffer): Now static.
d6550a9f
PE
6109 (size_window): Mark variables that gcc -Wuninitialized
6110 does not deduce are never used uninitialized.
a586633d
PE
6111 * window.h (check_all_windows): New decl, to forestall
6112 gcc -Wmissing-prototypes diagnostic.
5b555da1 6113 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6114
f6095868
PE
6115 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6116 shadowing.
6117 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6118 Include <limits.h>.
6119 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6120 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6121 (load_charset_map): Mark variables that gcc -Wuninitialized
6122 does not deduce are never used uninitialized.
53df7c11 6123 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6124
f38b440c
PE
6125 * coding.c (coding_set_source, coding_set_destination):
6126 Use "else { /* comment */ }" rather than "else /* comment */;"
6127 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6128 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6129 a block, when the outer 'i' will do.
6130 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6131 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6132 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6133 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6134 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6135 Rename locals to avoid shadowing.
6136 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6137 * coding.c (emacs_mule_char, encode_invocation_designation):
6138 Now static, since they're not used elsewhere.
413bb2db 6139 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6140 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6141 (decode_coding_emacs_mule): Mark variables that gcc
6142 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6143 (detect_coding_iso_2022): Initialize a local variable that might
6144 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6145 this initialization is needed. (Bug#8211)
5f58e762
PE
6146 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6147 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6148 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6149 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6150 Remove unused macros.
f38b440c 6151
232b38b9 6152 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6153 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6154 * character.c (string_count_byte8): Likewise.
232b38b9 6155
fb90da1b
PE
6156 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6157 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6158
fb93dbc2
PE
6159 * chartab.c (copy_sub_char_table): Now static, since it's not used
6160 elsewhere.
5c156ace
PE
6161 (sub_char_table_ref_and_range, char_table_ref_and_range):
6162 Rename locals to avoid shadowing.
bbcd0949 6163 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6164
7d3b3862 6165 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6166 (BIDI_BOB): Remove unused macro.
7d3b3862 6167
6be7d3da
PE
6168 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6169 deduce are never used uninitialized.
c2ed9c8b 6170 * term.c (encode_terminal_code): Likewise.
6be7d3da 6171
75f8807f 6172 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6173
50938595
PE
6174 * tparam.h: New file.
6175 * term.c, tparam.h: Include it.
6176 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6177 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6178 Move these decls to tparam.h, and make them agree with what
6179 is actually in tparam.c. The previous trick of using incompatible
6180 decls in different modules does not conform to the C standard.
6181 All callers of tparam changed to use tparam's actual API.
6182 * tparam.c (tparam1, tparam, tgoto):
6183 Use const pointers where appropriate.
6184
fbceeba2
PE
6185 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6186 * cm.h (struct cm): Likewise.
6187 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6188 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6189 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6190 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6191 (turn_on_face, init_tty): Likewise.
6192 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6193
7f3f1250
PE
6194 * term.c (term_mouse_position): Rename local to avoid shadowing.
6195
e6ca6543
PE
6196 * alloc.c (mark_ttys): Move decl from here ...
6197 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6198
c40f8d15
AS
61992011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6200
6201 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6202
cfe0661d
JB
62032011-03-09 Juanma Barranquero <lekktu@gmail.com>
6204
6205 * search.c (compile_pattern_1): Remove argument regp, unused since
6206 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6207 (compile_pattern): Don't pass it.
6208
0afb4571
J
62092011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6210
6211 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6212 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6213 for ! HAVE_GTK3.
6214 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6215
6216 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6217
6218 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6219 gdk_window_get_screen, gdk_window_get_geometry,
6220 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6221 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6222 (xg_get_pixbuf_from_pixmap): New function.
6223 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6224 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6225 Call xg_get_pixbuf_from_pixmap instead of
6226 gdk_pixbuf_get_from_drawable.
6227 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6228 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6229 (xg_check_special_colors): Use GtkStyleContext and its functions
6230 for HAVE_GTK3.
6231 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6232 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6233 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6234 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6235 Call gtk_widget_get_preferred_size.
0afb4571
J
6236 (xg_frame_resized): gdk_window_get_geometry only takes 5
6237 parameters.
44f230aa
SM
6238 (xg_win_to_widget, xg_event_is_for_menubar):
6239 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6240 (xg_set_widget_bg): New function.
6241 (delete_cb): New function.
895009e1 6242 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6243 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6244 (xg_set_background_color): Call xg_set_widget_bg.
6245 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6246 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6247 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6248 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6249 if ! HAVE_GTK3.
6250 (update_frame_tool_bar): Call gtk_widget_hide.
6251 (xg_initialize): Use GDK_KEY_g.
6252
6253 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6254 if ! HAVE_GTK3
6255 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6256
6257 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6258 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6259 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6260
1c2cc4ef
JB
62612011-03-08 Juanma Barranquero <lekktu@gmail.com>
6262
6263 * w32xfns.c (select_palette): Check success of RealizePalette against
6264 GDI_ERROR, not zero.
6265
33383987 6266See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6267
6268;; Local Variables:
6269;; coding: utf-8
aac0c6e3
MR
6270;; End:
6271
33383987 6272 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6273
6274 This file is part of GNU Emacs.
6275
6276 GNU Emacs is free software: you can redistribute it and/or modify
6277 it under the terms of the GNU General Public License as published by
6278 the Free Software Foundation, either version 3 of the License, or
6279 (at your option) any later version.
6280
6281 GNU Emacs is distributed in the hope that it will be useful,
6282 but WITHOUT ANY WARRANTY; without even the implied warranty of
6283 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6284 GNU General Public License for more details.
6285
6286 You should have received a copy of the GNU General Public License
6287 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.