Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c8815644 12011-08-15 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2
70c60eb2 3 Integer and memory overflow issues (Bug#9196).
726e0ab1 4
fe5c5d37
PE
5 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6 since either will do and ptrdiff_t is convenient with xpalloc.
7
0065d054
PE
8 * charset.c (charset_table_size)
9 (struct charset_sort_data.priority): Now ptrdiff_t.
10 (charset_compare): Don't overflow if priorities differ greatly.
11 (Fsort_charsets): Don't assume list length fits in int.
12 Check for size-calculation overflow when allocating sort data.
13 (syms_of_charset): Allocate an initial charset table that is
14 just under 64 KiB, to avoid problems with glibc malloc and mmap.
15
16 * cmds.c (internal_self_insert): Check for size-calculation overflow.
17
18 * composite.h (struct composition.glyph_len): Now int, not unsigned.
19 The actual value is always <= INT_MAX, and leaving it unsigned made
20 overflow checking harder.
21
22 * dispextern.h (struct glyph_matrix.rows_allocated)
23 (struct face_cache.size): Now ptrdiff_t, for convenience in use
24 with xpalloc. The values are still always <= INT_MAX.
25
26 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
27
28 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
29 (SAFE_NALLOCA): New macro.
30
31 * region-cache.c (struct boundary.pos, find_cache_boundary)
32 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
33 (set_cache_region, invalidate_region_cache)
34 (revalidate_region_cache, know_region_cache, region_cache_forward)
35 (region_cache_backward, pp_cache):
36 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
37 so that ptrdiff_t * can be passed to xpalloc.
38 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
39 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
40 (pp_cache): Don't assume cache_len fits in int.
41 * region-cache.h: Adjust extern decls to match.
42
43 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
44 EMACS_INT, since either will do, for xpalloc.
45
46 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
47 (xnmalloc, xnrealloc, xpalloc): New functions.
48
726e0ab1
PE
49 * bidi.c (bidi_shelve_header_size): New constant.
50 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
51 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
52
53 * buffer.c (overlays_at, overlays_in, record_overlay_string)
54 (overlay_strings):
55 Don't update size of array until after memory allocation succeeds,
56 because xmalloc/xrealloc may not return.
0065d054
PE
57 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
58 now that we have proper integer overflow checking.
59 (record_overlay_string, overlay_strings): Catch overflows when
60 calculating size of overlay_str_buf.
726e0ab1 61
0065d054
PE
62 * callproc.c (Fcall_process): Check for size overflow when
63 calculating size of args2.
64 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
65 Normally we prefer signed values, but sticking with ptrdiff_t would
66 require adding more-complicated checks.
726e0ab1
PE
67
68 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
69 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
70 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 71 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
72
73 * character.c (Fstring): Check for size-calculation overflow.
74
75 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
76 unnecessary integer overflow. Check for size overflow.
77 (encode_coding_object): Don't update size until xmalloc succeeds.
78
79 * composite.c (get_composition_id): Check for overflow in glyph
80 length calculations.
81
82 Integer and memory overflow fixes for display code.
83 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
84 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
85 (scrolling_window): Check for overflow in size calculations.
86 (line_draw_cost, realloc_glyph_pool, add_row_entry):
87 Don't assume glyph table len fits in int.
88 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
89 (row_table_size): Now ptrdiff_t, not int.
90 (scrolling_window): Avoid overflow in size calculations.
91 Don't update size until allocation succeeds.
92 * fns.c (concat): Check for overflow in size calculations.
93 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
94 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
95 (NEXT_ALMOST_PRIME_LIMIT): New constant.
96
97 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
98 (get_doc_string): Check for size calculation overflow.
99 Don't update size until allocation succeeds.
100 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
101 EMACS_INT, where ptrdiff_t will do.
102 (Fsubstitute_command_keys): Check for string overflow.
103
104 * editfns.c (set_time_zone_rule): Don't assume environment length
105 fits in int.
106 (message_length): Now ptrdiff_t, not int.
107 (Fmessage_box): Don't update size until allocation succeeds.
108 Don't assume message length fits in int.
109 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
110
0065d054
PE
111 * emacs.c (main): Do not reallocate argv, since there is a null at
112 the end that can be overwritten, and this way there's no need to
113 worry about size-calculation overflow.
114 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
115
116 * eval.c (init_eval_once, grow_specpdl): Don't update size until
117 alloc succeeds.
118 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
119
120 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
121 (x_set_scroll_bar_width, x_figure_window_size):
122 Check for integer overflow.
123 (x_set_alpha): Do not assume XINT fits in int.
124
125 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
126 This is for the members text_lines, text_cols, total_lines, total_cols,
127 where the system imposes an 'int' limit.
128
129 * fringe.c (Fdefine_fringe_bitmap):
130 Don't update size until alloc works.
131
132 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
133 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
134
135 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
136 Check for size-calculation overflow.
137 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
138 do, as we prefer signed integers.
139 (id_to_widget.max_size, id_to_widget.used)
140 (xg_store_widget_in_map, xg_remove_widget_from_map)
141 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
142 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
143 Use and return ptrdiff_t, not int.
144 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
145 * gtkutil.h: Change prototypes to match the above.
146
147 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
148 are duplicate now that they've been promoted to lisp.h.
149 (x_allocate_bitmap_record, x_alloc_image_color)
150 (make_image_cache, cache_image, xpm_load):
151 Don't update size until alloc is done.
152 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
153 (x_detect_edges):
3256efce 154 Check for size calculation overflow.
726e0ab1
PE
155 (ct_colors_allocated_max): New constant.
156 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
157 overflow.
3256efce 158
726e0ab1
PE
159 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
160 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
161 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
162 Use ptrdiff_t, not int, to count maps.
163 (read_char_minibuf_menu_prompt): Check for overflow in size
164 calculations. Don't update size until allocation succeeds. Redo
165 calculations to avoid overflow.
166 * keyboard.h: Change prototypes to match the above.
167
168 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
169 to count maps.
170 (current_minor_maps): Check for size calculation overflow.
171 * keymap.h: Change prototypes to match the above.
172
173 * lread.c (read1, init_obarray): Don't update size until alloc done.
174
175 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
176 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
177
726e0ab1
PE
178 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
179 Now ptrdiff_t, not int.
180 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
181 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
182
183 * process.c (Fnetwork_interface_list): Check for overflow
184 in size calculation.
185
186 * region-cache.c (move_cache_gap): Check for size calculation overflow.
187
188 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
189 overflow. Don't bother calling xmalloc when xrealloc will do.
190
191 * search.c (Freplace_match): Check for size calculation overflow.
192 (Fset_match_data): Don't assume list lengths fit in 'int'.
193
194 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
195 for command line length. Do not attempt to address one before the
196 beginning of an array, as that's not portable.
197
198 * term.c (max_frame_lines): Remove; unused.
199 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
200 not int.
201 (encode_terminal_code, calculate_costs): Check for size
202 calculation overflow.
203 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
204 table lengths and related sizes. Don't update size until alloc
205 done. Redo calculations to avoid overflow.
206 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
207
208 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
209 subtracting pointers.
210 (gobble_line): Check for overflow more carefully. Don't update size
211 until alloc done.
212
213 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
214 Don't update size until alloc done.
215 Redo size calculations to avoid overflow.
216 Check for size calculation overflow.
0065d054 217 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
218
219 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
220 Use ptrdiff_t, not int, for sizes.
221 (store_mode_line_noprop_char): Don't update size until alloc done.
222
0065d054
PE
223 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
224 Use ptrdiff_t, not int, for sizes.
225 (Finternal_make_lisp_face, cache_face):
226 Check for size calculation overflow.
227 (cache_face): Treat size calculation overflows as if they were
228 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
229
230 * xfns.c (x_encode_text, x_set_name_internal)
231 (Fx_change_window_property): Use ptrdiff_t, not int, to count
232 sizes, since they can exceed INT_MAX in size. Check for size
233 calculation overflow.
234
0065d054
PE
235 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
236 (xg_select): Check for size calculation overflow.
726e0ab1
PE
237 Don't update size until alloc done.
238
0065d054 239 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 240 as sprintf is limited to int lengths.
1d526e2f 241
252c5ee1
PE
242 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
243 (X_LONG_MIN): New macros.
864d7ce7
PE
244 Use them to make the following changes clearer.
245 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
246 This change doesn't affect the value now, but it may help remind
247 future maintainers not to raise the value too much later.
248 (SELECTION_QUANTUM): Remove, replacing with ...
249 (selection_quantum): ... new function, which avoids overflow.
250 All uses changed.
251 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
252 assumption that selection length fits in 'int'.
253 (x_reply_selection_request, x_handle_selection_request)
254 (x_get_window_property, receive_incremental_selection)
255 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
256 (lisp_data_to_selection_data, clean_local_selection_data):
257 Use ptrdiff_t, not int, to record length of selection.
258 (x_reply_selection_request, x_get_window_property)
259 (receive_incremental_selection, x_property_data_to_lisp):
260 Redo calculations to avoid overflow.
261 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 262 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
263 something.
264 (x_get_window_property, receive_incremental_selection)
265 (lisp_data_to_selection_data, x_property_data_to_lisp):
266 Check for size-calculation overflow.
267 (x_get_window_property, receive_incremental_selection)
268 (lisp_data_to_selection_data, Fx_register_dnd_atom):
269 Don't store size until memory allocation succeeds.
270 (x_get_window_property): Plug memory leak on memory exhaustion.
271 Don't double-block input; malloc is safe here. Don't assume 2**34
272 - 4 fits in unsigned long. Add an xassert to check
273 XGetWindowProperty overflow. Be more careful about overflow
274 calculations, and distinguish size from memory overflow better.
275 (receive_incremental_selection): When tracing, don't assume
276 unsigned int is less than INT_MAX.
277 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
278 harmful) conversions of unsigned short to int.
279 (lisp_data_to_selection_data): Don't assume that integers
280 in the range -65535 through -1 fit in an X unsigned short.
281 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
282 result parameters unless successful. Rely on cons_to_unsigned
283 to report problems with elements; the old code wasn't right anyway.
284 (x_check_property_data): Check for int overflow; we cannot use
285 a wider type due to X limits.
286 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
287
726e0ab1 288 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 289
0065d054
PE
290 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
291 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
292 (x_color_cells): Don't store size until memory allocation succeeds.
293 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 294 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
295 (x_term_init): Don't assume length fits in int (sprintf is limited
296 to int size).
bc18e09d 297
ebfa62c0
PE
298 Use ptrdiff_t for composition IDs.
299 * character.c (lisp_string_width):
300 * composite.c (composition_table_size, n_compositions)
301 (get_composition_id, composition_gstring_from_id):
302 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
303 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
304 * window.c (Frecenter):
305 Use ptrdiff_t, not int, for composition IDs.
306 * composite.c (get_composition_id): Check for integer overflow.
307 * composite.h: Adjust prototypes to match the above changes.
308
d3411f89
PE
309 Use ptrdiff_t for hash table indexes.
310 * category.c (hash_get_category_set):
311 * ccl.c (ccl_driver):
312 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
313 * coding.c (coding_system_charset_list, detect_coding_system):
314 * coding.h (struct coding_system.id):
315 * composite.c (get_composition_id, gstring_lookup_cache):
316 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
317 * image.c (xpm_get_color_table_h):
318 * lisp.h (hash_lookup, hash_put):
319 * minibuf.c (Ftest_completion):
320 Use ptrdiff_t for hash table indexes, not int (which is too
321 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
322 32-bit --with-wide-int hosts).
323
e097a6fa
PE
324 * charset.c (Fdefine_charset_internal): Check for integer overflow.
325 Add a FIXME comment about memory leaks.
326 (syms_of_charset): Don't assume xmalloc returns.
327
5637687f
PE
328 Don't assume that stated character widths fit in int.
329 * character.c (Fchar_width, c_string_width, lisp_string_width):
330 * character.h (CHAR_WIDTH):
331 * indent.c (MULTIBYTE_BYTES_WIDTH):
332 Use sanitize_char_width to avoid undefined and/or bad behavior
333 with outlandish widths.
334 * character.h (sanitize_tab_width): Renamed from sanitize_width,
335 now that we have two such functions. All uses changed.
336 (sanitize_char_width): New inline function.
337
a2271ba2
PE
338 Don't assume that tab-width fits in int.
339 * character.h (sanitize_width): New inline function.
340 (SANE_TAB_WIDTH): New macro.
341 (ASCII_CHAR_WIDTH): Use it.
342 * indent.c (sane_tab_width): Remove. All uses replaced by
343 SANE_TAB_WIDTH (current_buffer).
344 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
345
18c52557
PE
346 * fileio.c: Integer overflow issues with file modes.
347 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
348
caeeedc1
PE
349 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
350 Remove unreachable code.
351 (read_hex, load_charset_map_from_file): Check for integer overflow.
352
50849c52
PE
353 * xterm.c: don't go over XClientMessageEvent limit
354 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
355 (x_send_scroll_bar_event): Likewise. Check that the size does not
356 exceed limits imposed by XClientMessageEvent, as well as the usual
357 ptrdiff_t and size_t limits.
358
b13995db
PE
359 * keyboard.c: Overflow, signedness and related fixes.
360 (make_lispy_movement): Use same integer type in forward decl
361 that is used in the definition.
362 (read_key_sequence, keyremap_step):
363 Change bufsize argument back to int, undoing my 2011-03-30 change.
364 We prefer signed types, and int is wide enough here.
365 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
366 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
367 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
368 length, not size_t. Use ptrdiff_t for index, not int.
369 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
370 possibility of integer overflow.
371
13464394
PE
372 Overflow, signedness and related fixes for images.
373
374 * dispextern.h (struct it.stack[0].u.image.image_id)
375 (struct_it.image_id, struct image.id, struct image_cache.size)
376 (struct image_cache.used, struct image_cache.ref_count):
377 * gtkutil.c (update_frame_tool_bar):
378 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
379 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
380 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
381 * nsmenu.m (update_frame_tool_bar):
382 * xdisp.c (calc_pixel_width_or_height):
383 * xfns.c (image_cache_refcount):
384 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
385 on typical 64-bit hosts.
386
387 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
388 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
389 Omit unnecessary casts to int.
390 (parse_image_spec): Check that integers fall into 'int' range
391 when the callers expect that.
392 (image_ascent): Redo ascent calculation to avoid int overflow.
393 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
394 (lookup_image): Remove unnecessary tests.
395 (xbm_image_p): Locals are now of int, not EMACS_INT,
396 since parse_image_check makes sure they fit into int.
397 (png_load, gif_load, svg_load_image):
398 Prefer int to unsigned where either will do.
399 (tiff_handler): New function, combining the cores of the
400 old tiff_error_handler and tiff_warning_handler. This
401 function is rewritten to use vsnprintf and thereby avoid
402 stack buffer overflows. It uses only the features of vsnprintf
403 that are common to both POSIX and native Microsoft.
404 (tiff_error_handler, tiff_warning_handler): Use it.
405 (tiff_load, gif_load, imagemagick_load_image):
406 Don't assume :index value fits in 'int'.
407 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
408 (imagemagick_load_image): Check that crop parameters fit into
409 the integer types that MagickCropImage accepts. Don't assume
410 Vimagemagick_render_type has a nonnegative value. Don't assume
411 size_t fits in 'long'.
412 (gs_load): Use printmax_t to print the widest integers possible.
413 Check for integer overflow when computing image height and width.
414
3ebec551
PE
4152011-08-15 Paul Eggert <eggert@cs.ucla.edu>
416
417 * bidi.c (bidi_initialize): Remove unused local.
418
9fd8be00
EZ
4192011-08-15 Eli Zaretskii <eliz@gnu.org>
420
474a8465
EZ
421 * biditype.h: File removed.
422
423 * bidimirror.h: File removed.
424
425 * deps.mk (bidi.o): Remove biditype.h and
426 bidimirror.h.
427
428 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
429 bidimirror.h.
430
431 * dispextern.h: Fix a typo in the comment to bidi_type_t.
432
433 * chartab.c: Improve commentary for the uniprop_table API.
434
32413314
EZ
435 * bidi.c (bidi_paragraph_init): Support zero value of
436 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
437 (bidi_initialize): Use uniprop_table instead of including
438 biditype.h and bidimirror.h.
32413314 439
9fd8be00
EZ
440 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
441 coordinates of the iterator when restoring from ppos_it.
442 (Bug#9296)
443
5cf2b69b
KH
4442011-08-14 Kenichi Handa <handa@m17n.org>
445
446 * process.c (create_process): Call setup_process_coding_systems
447 after the pid of the process is set to -1.
448
daf17d00
EZ
4492011-08-14 Eli Zaretskii <eliz@gnu.org>
450
451 * xdisp.c (move_it_in_display_line_to): Don't invoke
452 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
453 ppos_it. Fixes vertical cursor motion when line beginning is
454 covered by an image. (Bug#9296)
455
08e3161a
JD
4562011-08-14 Jan Djärv <jan.h.d@swipnet.se>
457
458 * nsterm.h (ns_run_ascript): Declare.
459 (NSAPP_DATA2_RUNASSCRIPT): Define.
460
461 * nsfns.m (as_script, as_result, as_status): New static variables.
462 (ns_run_ascript): New function.
463 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
464 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
465 the event loop. Get status from as_status (Bug#7276).
466
467 * nsterm.m (sendEvent): If event is NSApplicationDefined and
468 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
469 the event loop (Bug#7276).
470
a3720aa2
AS
4712011-08-14 Andreas Schwab <schwab@linux-m68k.org>
472
473 * gnutls.c (QCgnutls_bootprop_priority)
474 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
475 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
476 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
477 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
478 (QCgnutls_bootprop_verify_hostname_error)
479 (QCgnutls_bootprop_callbacks_verify): Rename from
480 Qgnutls_bootprop_..., all uses changed.
481
482 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
483 uses changed.
484
0a0d27fb
PE
4852011-08-14 Paul Eggert <eggert@cs.ucla.edu>
486
19d5c50c
PE
487 * xfaces.c (Qframe_set_background_mode): Now static.
488 * dispextern.h (Qframe_set_background_mode): Remove decl.
489
0a0d27fb
PE
490 * process.c (Fnetwork_interface_info): Declare local only if needed.
491
377538cb
JD
4922011-08-13 Jan Djärv <jan.h.d@swipnet.se>
493
494 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
495 (Fnetwork_interface_list): Allocate in increments of bytes instead
496 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
497 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
498 sockaddr.
499 (struct ifflag_def): notrailers is smart on OSX.
500 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
501 Get hardware address with getifaddrs if available.
502
08fff70c
EZ
5032011-08-12 Eli Zaretskii <eliz@gnu.org>
504
505 * xdisp.c (iterate_out_of_display_property): xassert that
506 IT->position is set to within IT->object's boundaries. Break from
507 the loop as soon as EOB is reached; avoids infloops in redisplay
508 when IT->position is set up wrongly due to some bug. Set
509 IT->current to match the bidi iterator unconditionally.
510 (push_display_prop): Allow GET_FROM_STRING as IT->method on
511 entry. Force push_it to save on the stack the current
512 buffer/string position, to be restored by pop_it. Fix flags in
513 the iterator structure wrt the object coming from a display
514 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
515 properties. (Bug#9284)
516
7be1c708 5172011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 518
7be1c708
CY
519 * fontset.c (fontset_get_font_group): Add proper type checks.
520 (Bug#9172)
aac0c6e3 521
7be1c708 5222011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 523
7be1c708
CY
524 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
525 and LC_VERSION_MIN_MACOSX.
526 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
527 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 528
97bb72a6
EZ
5292011-08-08 Eli Zaretskii <eliz@gnu.org>
530
531 * xdisp.c (forward_to_next_line_start): Allow to use the
757664a4
EZ
532 no-display-properties-and-no-overlays under bidi display. Set
533 disp_pos in the bidi iterator to avoid searches for display
534 properties and overlays.
97bb72a6 535
d5617611
CY
5362011-08-08 Chong Yidong <cyd@stupidchicken.com>
537
37e11a63
CY
538 * editfns.c (Fset_time_zone_rule): Document relationship with the
539 setenv function.
540
d5617611
CY
541 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
542 the font entity extracted from the cache (Bug#8109).
543
58872834
CY
5442011-08-07 Chong Yidong <cyd@stupidchicken.com>
545
546 * composite.c (autocmp_chars): Don't reset point. That is done by
547 restore_point_unwind (Bug#5984).
548
75bfc667
JL
5492011-08-07 Juri Linkov <juri@jurta.org>
550
551 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
552 to show the arg `TIME' instead of `TIMEVAL'.
553
d1410150
EZ
5542011-08-06 Eli Zaretskii <eliz@gnu.org>
555
556 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
557 display property strides EOL and includes a newline, as in
558 longlines-mode. (Bug#9254)
75b771e4
EZ
559 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
560 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
561
562 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
563 is non-zero, even if the data buffer is NULL. Fixes a crash in
564 vertical-motion with longlines-mode. (Bug#9254)
565
35928349
EZ
5662011-08-05 Eli Zaretskii <eliz@gnu.org>
567
ec7cc85b
EZ
568 * bidi.c <bidi_cache_total_alloc>: Now static.
569 (bidi_initialize): Initialize bidi_cache_total_alloc.
570
35928349
EZ
571 *xdisp.c (display_line): Release buffer allocated for shelved bidi
572 cache. (Bug#9221)
573
574 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
575 amount allocated this far in `bidi_cache_total_alloc'.
576 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
577 non-zero, only free the data buffer without restoring the cache
578 contents. All callers changed.
579
580 * dispextern.h (bidi_unshelve_cache): Update prototype.
581
582 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
583 (move_it_in_display_line, move_it_to)
584 (move_it_vertically_backward, move_it_by_lines): Replace the call
585 to xfree to an equivalent call to bidi_unshelve_cache.
586 (move_it_in_display_line_to): Fix logic of returning
412b6358 587 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 588
e2e2423b
EZ
5892011-08-05 Eli Zaretskii <eliz@gnu.org>
590
591 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
592 came from a string character with a `cursor' property. (Bug#9229)
593
ae9e757a
JD
5942011-08-04 Jan Djärv <jan.h.d@swipnet.se>
595
596 * Makefile.in (LIB_PTHREAD): New variable.
597 (LIBES): Add LIB_PTHREAD (Bug#9216).
598
599 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
600 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
601
213bd7f2
AS
6022011-08-04 Andreas Schwab <schwab@linux-m68k.org>
603
604 * regex.c (re_iswctype): Remove some redundant boolean
605 conversions.
606
99aaf75f
JD
6072011-08-04 Jan Djärv <jan.h.d@swipnet.se>
608
609 * xterm.c (x_find_topmost_parent): New function.
610 (x_set_frame_alpha): Find topmost parent window with
611 x_find_topmost_parent and set the property there also (bug#9181).
612 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
613
c74e9d86
PE
6142011-08-04 Paul Eggert <eggert@cs.ucla.edu>
615
616 * callproc.c (Fcall_process): Avoid vfork clobbering
617 the local vars buffer, coding_systems, current_dir.
618
640c8776
SM
6192011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
620
621 * keymap.c (Fmake_composed_keymap): Move to subr.el.
622
f26d0e4c
PE
6232011-08-03 Paul Eggert <eggert@cs.ucla.edu>
624
8a10d76c
PE
625 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
626 so that it is not optimized away.
627
f26d0e4c
PE
628 * xdisp.c (compute_display_string_pos): Remove unused local.
629
55439c61
EZ
6302011-08-02 Eli Zaretskii <eliz@gnu.org>
631
632 Fix slow cursor motion and scrolling in large buffers with
633 selective display, like Org Mode buffers. (Bug#9218)
634
635 * dispextern.h (struct bidi_it): New member disp_prop_p.
636
637 * xdisp.c: Remove one-slot cache of display string positions.
638 (compute_display_string_pos): Accept an additional argument
639 DISP_PROP_P; callers changed. Scan at most 5K characters forward
640 for a display string or property. If found, set DISP_PROP_P
641 non-zero.
642
643 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
644 DISP_PROP_P, and pass it to compute_display_string_pos.
645 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
646 non-zero. All callers of bidi_fetch_char changed.
647
fb33fa43
SM
6482011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
649
650 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
651
b099e063
DM
6522010-12-03 Don March <don@ohspite.net>
653
654 * keymap.c (Fdefine_key): Fix non-prefix key error message when
655 last character M-[char] is translated to ESC [char] (bug#7541).
656
5cc7f7af
KH
6572011-08-02 Kenichi Handa <handa@m17n.org>
658
d0fffa3f 659 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
660
661 * chartab.c (uniprop_table): Make it non-static.
662
525d5e6e
EZ
6632011-08-01 Eli Zaretskii <eliz@gnu.org>
664
665 * xdisp.c (forward_to_next_line_start): Accept additional argument
666 BIDI_IT_PREV, and store into it the state of the bidi iterator had
667 on the newline.
668 (reseat_at_next_visible_line_start): Use the bidi iterator state
669 returned by forward_to_next_line_start to restore the state of
670 it->bidi_it after backing up to previous newline. (Bug#9212)
671
31011111
AS
6722011-07-30 Andreas Schwab <schwab@linux-m68k.org>
673
674 * regex.c (re_comp): Protoize.
675 (re_exec): Fix return type.
676 (regexec): Fix type of `ret'. (Bug#9203)
677
e5d76069
PE
6782011-07-29 Paul Eggert <eggert@cs.ucla.edu>
679
680 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
681 This is needed if max-image-size is a floating-point number.
682
9a79b20c
AS
6832011-07-28 Andreas Schwab <schwab@linux-m68k.org>
684
685 * print.c (print_object): Print empty symbol as ##.
686
687 * lread.c (read1): Read ## as empty symbol.
688
d8c2fa78
AA
6892011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
690
691 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
692 setting frame foreground color (Bug#9175).
693 (x_set_background_color): Likewise.
694
ffe57a7a
AA
695 * nsmenu.m (-setText): Size tooltip dimensions precisely to
696 contents (Bug#9176).
697 (EmacsTooltip -init): Remove bezels and add shadows to
698 tooltip windows.
699
bf3492a5
AA
700 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
701 or scroll bar (Bug#8470).
702
d55e9c53
AA
703 * nsfont.m (nsfont_open): Remove assignment to voffset and
704 unnecessary vars hshink, expand, hd, full_height, min_height.
705 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
706
707 * nsterm.h (nsfont_info): Remove voffset field.
708
d8c2fa78 7092011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
710
711 Implement strike-through and overline on NextStep (Bug#8863).
712
713 * nsfont.m (nsfont_open): Use underline position provided by font,
714 instead of hard-coded value of 2.
715 (nsfont_draw): Call ns_draw_text_decoration instead.
716
717 * nsterm.h: Add declaration for ns_draw_text_decoration.
718
719 * nsterm.m (ns_draw_text_decoration): New function for drawing
720 underline, overline, and strike-through.
721 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
722 ns_draw_text_decoration. Change treatment of cursor drawing to
723 accomodate underlining, etc.
724
4cc60b9b
EZ
7252011-07-28 Eli Zaretskii <eliz@gnu.org>
726
bc7ece87
EZ
727 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
728 default.
4cc60b9b 729
476371c4
PE
7302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
731
66606eea
PE
732 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
733 Without this fix, if a signal arrives just after memory fills up,
734 'malloc' might be invoked reentrantly.
735
476371c4
PE
736 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
737 In other words, assume that every image size is allowed, on non-X
738 hosts. This assumption is probably wrong, but it lets Emacs compile.
739
f3fcc40d
AS
7402011-07-28 Andreas Schwab <schwab@linux-m68k.org>
741
742 * regex.c (re_iswctype): Convert return values to boolean.
743
350c992f
EZ
7442011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
745
746 * xdisp.c (compute_display_string_pos): Don't use cached display
747 string position if the buffer had its restriction changed.
748 (Bug#9184)
749
5266b4bb
PE
7502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
751
752 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
753
2573a837 7542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 755
41f55ccd 756 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 757
39e378da
PE
758 * bidi.c: Integer size and overflow fixes.
759 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
760 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
761 (bidi_cache_find_level_change, bidi_cache_ensure_space)
762 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
763 (bidi_find_other_level_edge):
764 Use ptrdiff_t instead of EMACS_INT where either will do.
765 This works better on 32-bit hosts configured --with-wide-int.
766 (bidi_cache_ensure_space): Check for size-calculation overflow.
767 Use % rather than repeated addition, for better worst-case speed.
768 Don't set bidi_cache_size until after xrealloc returns, because it
769 might not return.
770 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
771 (bidi_cache_ensure_space): Also check that the bidi cache size
772 does not exceed that of the largest Lisp string or buffer. See Eli
773 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 774
5e927815
PE
775 * alloc.c (__malloc_size_t): Remove.
776 All uses replaced by size_t. See Andreas Schwab's note
777 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
778
ca4aa935
PE
779 * image.c: Improve checking for integer overflow.
780 (check_image_size): Assume that f is nonnull, since
781 it is always nonnull in practice. This is one less thing to
782 worry about when checking for integer overflow later.
783 (x_check_image_size): New function, which checks for integer
784 overflow issues inside X.
785 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
786 This removes the need for a memory_full check.
787 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
788 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
789 (xbm_read_bitmap_data): Change locals back to 'int', since
790 their values must fit in 'int'.
791 (xpm_load_image, png_load, tiff_load):
792 Invoke x_create_x_image_and_pixmap earlier,
793 to avoid much needless work if the image is too large.
794 (tiff_load): Treat overly large images as if
795 x_create_x_image_and_pixmap failed, not as malloc failures.
796 (gs_load): Use x_check_image_size.
797
5f8f9cc2
PE
798 * gtkutil.c: Omit integer casts.
799 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
800 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
801
5adf60bc
PE
802 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
803
c8907a93
PE
804 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
805 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
806 would wrongly return t on a 64-bit host.
807
e3c25c68
PE
808 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
809 The plain *_OVERFLOW macros run afoul of GCC bug 49705
810 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
811 and therefore cause GCC to emit a bogus diagnostic in some cases.
812
3f791afe
PE
813 * image.c: Integer signedness and overflow and related fixes.
814 This is not an exhaustive set of fixes, but it's time to
815 record what I've got.
816 (lookup_pixel_color, check_image_size): Remove redundant decls.
817 (check_image_size): Don't assume that arbitrary EMACS_INT values
818 fit in 'int', or that arbitrary 'double' values fit in 'int'.
819 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
820 (tiff_load, imagemagick_load_image):
821 Check for overflow in size calculations.
822 (x_create_x_image_and_pixmap): Remove unnecessary test for
823 xmalloc returning NULL; that can't happen.
824 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
825 (xpm_color_bucket): Use better integer hashing function.
826 (xpm_cache_color): Don't possibly over-allocate memory.
827 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
828 (gif_memory_source):
829 Use ptrdiff_t, not int or size_t, to record sizes.
830 (png_load): Don't assume values greater than 2**31 fit in 'int'.
831 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
832 either works, as we prefer signed integers.
833 (tiff_read_from_memory, tiff_write_from_memory):
834 Return tsize_t, not size_t, since that's what the TIFF API wants.
835 (tiff_read_from_memory): Don't fail simply because the read would
836 go past EOF; instead, return a short read.
837 (tiff_load): Omit no-longer-needed casts.
838 (Fimagemagick_types): Don't assume size fits into 'int'.
839
3cc5a532
PE
840 Improve hashing quality when configured --with-wide-int.
841 * fns.c (hash_string): New function, taken from sxhash_string.
842 Do not discard information about ASCII character case; this
843 discarding is no longer needed.
844 (sxhash-string): Use it. Change sig to match it. Caller changed.
845 * lisp.h: Declare it.
846 * lread.c (hash_string): Remove, since we now use fns.c's version.
847 The fns.c version returns a wider integer if --with-wide-int is
848 specified, so this should help the quality of the hashing a bit.
849
b312a492
PE
850 * emacs.c: Integer overflow minor fix.
851 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
852 Define only if GNU_LINUX.
853 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
854
dfd153ae
PE
855 * dispnew.c: Integer signedness and overflow fixes.
856 Remove unnecessary forward decls, that were a maintenance hassle.
857 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
858 All uses changed.
859 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
860 (scrolling_window): Use ptrdiff_t, not int, for byte count.
861 (prepare_desired_row, line_draw_cost):
862 Use int, not unsigned, where either works.
863 (save_current_matrix, restore_current_matrix):
864 Use ptrdiff_t, not size_t, where either works.
865 (init_display): Check for overflow more accurately, and without
866 relying on undefined behavior.
867
a81d11a3
PE
868 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
869 Remove, replacing with the new symbols in lisp.h. All uses changed.
870 * fileio.c (make_temp_name):
871 * filelock.c (lock_file_1, lock_file):
872 * xdisp.c (message_dolog):
873 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
874 Use pMd etc. instead.
875 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
876 replacing the pWIDE etc. symbols removed from editfns.c.
877
3300e6fd
PE
878 * keyboard.h (num_input_events): Now uintmax_t.
879 This is (very slightly) less likely to mess up due to wraparound.
880 All uses changed.
881
fd05c7e9
PE
882 * buffer.c: Integer signedness fixes.
883 (alloc_buffer_text, enlarge_buffer_text):
884 Use ptrdiff_t rather than size_t when either will do, as we prefer
885 signed integers.
886
903fe15d
PE
887 * alloc.c: Integer signedness and overflow fixes.
888 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
889 (__malloc_size_t): Default to size_t, not to int.
890 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
891 (Fgarbage_collect, mark_object_loop_halt, mark_object):
892 Prefer ptrdiff_t to size_t when either would do, as we prefer
893 signed integers.
894 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
895 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
896 Now const. Initialize with values that are in range even if char
897 is signed.
898 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
899 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
900 These functions do the right thing with sizes > 2**32.
901 (check_depth): Now ptrdiff_t, not int.
902 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
903 Adjust to new way of storing sizes. Check for size overflow bugs
904 in rest of code.
905 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
906 slightly wrong anyway, as it missed one instance of
907 XMALLOC_OVERRUN_CHECK_OVERHEAD.
908 (refill_memory_reserve): Omit needless cast to size_t.
909 (mark_object_loop_halt): Mark as externally visible.
910
ac82cc6a
PE
911 * xselect.c: Integer signedness and overflow fixes.
912 (Fx_register_dnd_atom, x_handle_dnd_message):
913 Use ptrdiff_t, not size_t, since we prefer signed.
914 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
915 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
916 x_dnd_atoms_size and x_dnd_atoms_length.
917
c2d1e36d
PE
918 * doprnt.c: Prefer signed to unsigned when either works.
919 * eval.c (verror):
920 * doprnt.c (doprnt):
921 * lisp.h (doprnt):
922 * xdisp.c (vmessage):
923 Use ptrdiff_t, not size_t, when using or implementing doprnt,
924 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
925 prefer signed arithmetic to avoid comparison confusion.
926 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
927 but is a bit tricky.
928
0e926e56
PE
929 Assume freestanding C89 headers, string.h, stdlib.h.
930 * data.c, doprnt.c, floatfns.c, print.c:
931 Include float.h unconditionally.
932 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
933 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
934 * regex.c: Likewise for stddef.h, string.h.
935 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
936 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
937 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
938 (STDC_HEADERS): Remove obsolete defines.
939 * sysdep.c: Include limits.h unconditionally.
940
9cfdb3ec
PE
941 Assume support for memcmp, memcpy, memmove, memset.
942 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
943 * regex.c (memcmp, memcpy):
944 Remove; we assume C89 now.
945
946 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
947 (__malloc_safe_bcopy): Remove; no longer needed.
948
cf950e6b 949 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
950 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
951 well either way, and we prefer signed to unsigned.
952
dbf38e02
LMI
9532011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
954
955 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
956 closes the connection while we're reading (bug#9182).
957
d6f0886c
JD
9582011-07-25 Jan Djärv <jan.h.d@swipnet.se>
959
960 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
961 are specified (Bug#9168).
962
2eb1f9e6
PE
9632011-07-25 Paul Eggert <eggert@cs.ucla.edu>
964
965 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
966 Found by GCC static checking and --with-wide-int on a 32-bit host.
967
22381272 9682011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
969
970 * xdisp.c (compute_display_string_pos): Fix logic of caching
971 previous display string position. Initialize cached_prev_pos to
972 -1. Fixes slow-down at the beginning of a buffer.
973
f25e39b4
EZ
9742011-07-24 Eli Zaretskii <eliz@gnu.org>
975
976 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
977 for attrs[LFACE_FONTSET_INDEX].
978
04c4b52e
PE
9792011-07-23 Paul Eggert <eggert@cs.ucla.edu>
980
981 * xml.c (parse_region): Remove unused local
982 that was recently introduced.
983
c1734fbd
EZ
9842011-07-23 Eli Zaretskii <eliz@gnu.org>
985
be18c5a5
EZ
986 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
987 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
988
c1734fbd
EZ
989 * xdisp.c (move_it_in_display_line_to): Record the best matching
990 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
991 exit if none of the characters scanned was an exact match.
992 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
993 when exact match is impossible due to invisible text, and the
994 lines are truncated.
995
a258d627
JD
9962011-07-23 Jan Djärv <jan.h.d@swipnet.se>
997
998 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
999 for OSX >= 10.7.
1000
b6d5a689
EZ
10012011-07-22 Eli Zaretskii <eliz@gnu.org>
1002
0f74f785
EZ
1003 Fix a significant slow-down of cursor motion with C-n, C-p,
1004 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1005 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1006 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1007 (next_element_from_buffer): Call compute_stop_pos_backwards to
1008 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1009 base_level_stop.
1010 (reseat): Don't look for prev_stop, as that could mean a very long
1011 run.
1012 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1013 <cached_disp_overlay_modiff>: Cache for last found display string
1014 position.
551918c1 1015 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1016 about the same buffer in the same area of character positions, and
1017 the buffer wasn't changed since the time the display string
1018 position was cached.
551918c1 1019
b2d0c91a
EZ
10202011-07-22 Eli Zaretskii <eliz@gnu.org>
1021
1022 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1023 is an integer, which is important for empty lines. (Bug#9149)
1024
043604ee
CY
10252011-07-22 Chong Yidong <cyd@stupidchicken.com>
1026
1027 * frame.c (Fmodify_frame_parameters): In tty case, update the
1028 default face if necessary (Bug#4238).
1029
da4adb04
CY
10302011-07-21 Chong Yidong <cyd@stupidchicken.com>
1031
1032 * editfns.c (Fstring_to_char): No need to explain what a character
1033 is in the docstring (Bug#6576).
1034
9abd0532
LMI
10352011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1036
1037 * xml.c (parse_region): Make sure we always return a tree.
1038
36881d16
HK
10392011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1040
1041 * xml.c (parse_region): If a document contains only comments,
1042 return that, too.
1043
1e98674d
LMI
10442011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1045
1046 * xml.c (make_dom): Return comments, too.
1047
590bd467
PE
10482011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1049
1050 Port to OpenBSD.
1051 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1052 and the surrounding thread.
1053 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1054 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1055 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1056 timer goes off.
1057 * s/openbsd.h (BROKEN_SIGIO): Define.
1058 * unexelf.c (unexec) [__OpenBSD__]:
1059 Don't update the .mdebug section of the Alpha COFF symbol table.
1060
f41628b2
LMI
10612011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1062
1063 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1064 (bug#8460).
1065
b59b67c5
PE
10662011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1067
15e3a074
PE
1068 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1069 This fixes some race conditions on the permissions of any newly
1070 created file.
1071
41bed37d
PE
1072 * alloc.c (valid_pointer_p): Use pipe, not open.
1073 This fixes some permissions issues when debugging.
1074
b59b67c5
PE
1075 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1076 If fchown fails to set both uid and gid, try to set just gid,
1077 as that is sometimes allowed. Adjust the file's mode to eliminate
1078 setuid or setgid bits that are inappropriate if fchown fails.
1079
925a6be7
SM
10802011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1081
1082 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1083 to compare Lisp_Objects.
1084 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1085 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1086 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1087
52968808
AS
10882011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1089
0a6a104b
AS
1090 * lread.c (read_integer): Unread even EOF character.
1091 (read1): Likewise. Properly record start position of symbol.
1092
52968808
AS
1093 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1094 symbol character follows.
1095
9e381cdd
PE
10962011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1097
1098 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1099 This works around a problem with the previous change to Fcopy_file.
1100 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1101 and without this change, GCC might complain about discarding
1102 fchown's return value.
1103
b5641435
JB
11042011-07-16 Juanma Barranquero <lekktu@gmail.com>
1105
1106 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1107
a8031457
PE
11082011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1111
dd889327
LMI
11122011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1113
750c33f7
LMI
1114 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1115 it's used from the C level.
1116
dd889327
LMI
1117 * process.c: Use the same condition for POLL_FOR_INPUT in both
1118 keyboard.c and process.c (bug#1858).
1119
87e86684
LM
11202011-07-09 Lawrence Mitchell <wence@gmx.li>
1121
1122 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1123 (Fgnutls_boot): Use it.
1124
64348f40
AS
11252011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1126
1127 * doc.c (Fsubstitute_command_keys): Revert last change.
1128
1d698799
LMI
11292011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1130
f863868c
LMI
1131 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1132 quotes the next character, and doesn't affect other longer
1133 sequences (bug#8935).
1134
1d698799
LMI
1135 * lread.c (syms_of_lread): Clarify that is isn't only
1136 `eval-buffer' and `eval-defun' that's affected by
1137 `lexical-binding' (bug#8460).
1138
aa4b6df6
EZ
11392011-07-15 Eli Zaretskii <eliz@gnu.org>
1140
1141 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1142 bidi redisplay when a line includes both an image and is
1143 truncated.
1144
5d856da6
PE
11452011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1146
ad6042bb
PE
1147 Fix minor problems found by static checking.
1148 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1149 (elsz): Now a signed constant, not a size_t var. We prefer signed
1150 types to unsigned, to avoid integer comparison confusion. Without
1151 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1152 "cannot optimize loop, the loop counter may overflow", a symptom
1153 of the confusion.
f00bbb22 1154 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1155 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1156
6468f31c
LMI
11572011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1158
49080b10
LMI
1159 * search.c (Fre_search_backward): Mention `case-fold-search' in
1160 all the re_search_* functions (bug#8138).
1161
6468f31c
LMI
1162 * keyboard.c (Fopen_dribble_file): Document when the file is
1163 closed (bug#8056).
1164
c965adc5
EZ
11652011-07-14 Eli Zaretskii <eliz@gnu.org>
1166
df9733bf
EZ
1167 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1168 bidi_cache_idx.
1169
0bb23927
EZ
1170 Support bidi reordering of display and overlay strings.
1171 * xdisp.c (compute_display_string_pos)
1172 (compute_display_string_end): Accept additional argument STRING.
1173 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1174 (reseat_to_string): Initialize bidi_it->string.s and
1175 bidi_it->string.schars.
1176 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1177 NULL (avoids a crash in bidi_paragraph_init).
1178 Initialize itb.string.lstring.
0bb23927
EZ
1179 (init_iterator): Call bidi_init_it only of a valid
1180 buffer position was specified. Initialize paragraph_embedding to
1181 L2R.
1182 (reseat_to_string): Initialize the bidi iterator.
1183 (display_string): If we need to ignore text properties of
1184 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1185 original value of -1 will not work with bidi.)
1186 (compute_display_string_pos): First arg is now struct
1187 `text_pos *'; all callers changed. Support display properties on
1188 Lisp strings.
1189 (compute_display_string_end): Support display properties on Lisp
1190 strings.
1191 (init_iterator, reseat_1, reseat_to_string): Initialize the
1192 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1193 when iterating on a string not from display properties).
640c8776
SM
1194 (compute_display_string_pos, compute_display_string_end):
1195 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1196 arrow keys.
1197 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1198 base_level_stop; instead, set base_level_stop to BEGV.
1199 Fixes crashes in vertical-motion.
0bb23927
EZ
1200 (next_element_from_buffer): Improve commentary for when
1201 the iterator is before prev_stop.
1202 (init_iterator): Initialize bidi_p from the default value of
1203 bidi-display-reordering, not from buffer-local value. Use the
1204 buffer-local value only if initializing for buffer iteration.
1205 (handle_invisible_prop): Support invisible properties on strings
1206 that are being bidi-reordered.
1207 (set_iterator_to_next): Support bidi reordering of C strings and
1208 Lisp strings.
1209 (next_element_from_string): Support bidi reordering of Lisp
1210 strings.
1211 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1212 (display_string): Support display of R2L glyph rows.
1213 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1214 (init_iterator): Don't initialize it->bidi_p for strings
1215 here.
1216 (reseat_to_string): Initialize it->bidi_p for strings here.
1217 (next_element_from_string, next_element_from_c_string)
1218 (next_element_from_buffer): Add xassert's for correspondence
1219 between IT's object being iterated and it->bidi_it.string
1220 structure.
1221 (face_before_or_after_it_pos): Support bidi iteration.
1222 (next_element_from_c_string): Handle the case of the first string
1223 character that is not the first one in the visual order.
1224 (get_visually_first_element): New function, refactored from common
1225 parts of next_element_from_buffer, next_element_from_string, and
1226 next_element_from_c_string.
1227 (tool_bar_lines_needed, redisplay_tool_bar)
1228 (display_menu_bar): Force left-to-right direction. Add a FIXME
1229 comment for making that be controlled by a user option.
1230 (push_it, pop_it): Save and restore the state of the
1231 bidi iterator. Save and restore the bidi_p flag.
1232 (pop_it): Iterate out of display property for string iteration as
1233 well.
1234 (iterate_out_of_display_property): Support iteration over strings.
1235 (handle_single_display_spec): Set up it->bidi_it for iteration
1236 over a display string, and call bidi_init_it.
1237 (handle_single_display_spec, next_overlay_string)
1238 (get_overlay_strings_1, push_display_prop): Set up the bidi
1239 iterator for displaying display or overlay strings.
1240 (forward_to_next_line_start): Don't use the shortcut if
1241 bidi-iterating.
1242 (back_to_previous_visible_line_start): If handle_display_prop
1243 pushed the iterator stack, restore the internal state of the bidi
1244 iterator by calling bidi_pop_it same number of times.
1245 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1246 and we are bidi-iterating, don't decrement the iterator position;
1247 instead, set the first_elt flag in the bidi iterator, to produce
1248 the same effect.
1249 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1250 (push_display_prop): xassert that we are iterating a buffer.
1251 (push_it, pop_it): Save and restore paragraph_embedding member.
1252 (handle_single_display_spec, next_overlay_string)
1253 (get_overlay_strings_1, reseat_1, reseat_to_string)
1254 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1255 correctly. Don't assume unibyte strings are not bidi-reordered.
1256 (compute_display_string_pos)
1257 (compute_display_string_end): Fix handling the case of C string.
1258 (push_it, pop_it): Save and restore from_disp_prop_p.
1259 (handle_single_display_spec, push_display_prop): Set the
1260 from_disp_prop_p flag.
1261 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1262 (pop_it): Call iterate_out_of_display_property only if we are
1263 popping after iteration over a string that came from a display
1264 property. Fix a typo in popping stretch info. Add an assertion
1265 for verifying that the iterator position is in sync with the bidi
1266 iterator.
1267 (handle_single_display_spec, get_overlay_strings_1)
1268 (push_display_prop): Fix initialization of paragraph direction for
1269 string when that of the parent object is not yet determined.
1270 (reseat_1): Call bidi_init_it to resync the bidi
1271 iterator with IT's position. (Bug#7616)
1272 (find_row_edges): If ROW->start.pos gives position
1273 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1274 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1275 Reset the from_disp_prop_p flag.
1276 (SAVE_IT, RESTORE_IT): New macros.
1277 (pos_visible_p, face_before_or_after_it_pos)
1278 (back_to_previous_visible_line_start)
1279 (move_it_in_display_line_to, move_it_in_display_line)
1280 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1281 (try_scrolling, redisplay_window, display_line): Use them when
1282 saving a temporary copy of the iterator and restoring it back.
1283 (back_to_previous_visible_line_start, reseat_1)
1284 (init_iterator): Empty the bidi cache "stack".
1285 (move_it_in_display_line_to): If iterator ended up at
1286 EOL, but we never saw any buffer positions smaller than
1287 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1288 motion in bidi-reordered lines.
1289 (move_it_in_display_line_to): Record prev_method and prev_pos
1290 immediately before the call to set_iterator_to_next. Fixes cursor
1291 motion in bidi-reordered lines with stretch glyphs and strings
1292 displayed in margins. (Bug#8133) (Bug#8867)
1293 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1294 TO_CHARPOS.
640c8776
SM
1295 (pos_visible_p): Support positions in bidi-reordered lines.
1296 Save and restore bidi cache.
0bb23927
EZ
1297
1298 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1299 (bidi_paragraph_info): Delete unused struct.
1300 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1301 (bidi_cache_start): New variable.
1302 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1303 to zero.
1304 (bidi_cache_fetch_state, bidi_cache_search)
1305 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1306 (bidi_cache_find, bidi_peek_at_next_level)
1307 (bidi_level_of_next_char, bidi_find_other_level_edge)
1308 (bidi_move_to_visually_next): Compare cache index with
1309 bidi_cache_start rather than with zero.
1310 (bidi_fetch_char): Accept new argument STRING; all callers
1311 changed. Support iteration over a string. Support strings with
1312 display properties. Support unibyte strings. Fix the type of
1313 `len' according to what STRING_CHAR_AND_LENGTH expects.
1314 (bidi_paragraph_init, bidi_resolve_explicit_1)
1315 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1316 (bidi_level_of_next_char, bidi_move_to_visually_next):
1317 Support iteration over a string.
0bb23927
EZ
1318 (bidi_set_sor_type, bidi_resolve_explicit_1)
1319 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1320 can now be zero (for strings); special values 0 and -1 were
1321 changed to -1 and -2, respectively.
1322 (bidi_char_at_pos): New function.
1323 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1324 Call it instead of FETCH_MULTIBYTE_CHAR.
1325 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1326 initialized to valid values.
1327 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1328 values.
1329 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1330 the test for valid cached positions. Fix the logic for looking up
1331 the sentinel state in the cache. GCPRO the Lisp string we are
1332 iterating.
1333 (bidi_push_it, bidi_pop_it): New functions.
1334 (bidi_initialize): Initialize the bidi cache start stack pointer.
1335 (bidi_cache_ensure_space): New function, refactored from part of
1336 bidi_cache_iterator_state. Don't assume the required size is just
1337 one BIDI_CACHE_CHUNK away.
1338 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1339 (bidi_count_bytes, bidi_char_at_pos): New functions.
1340 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1341 always valid if bidi_cache_idx is valid.
1342 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1343 is valid if it's going to be used.
1344 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1345 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1346 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1347 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1348 (bidi_find_other_level_edge, bidi_cache_start_stack):
1349 All variables related to cache indices are now EMACS_INT.
c965adc5 1350
0bb23927
EZ
1351 * dispextern.h (struct bidi_string_data): New structure.
1352 (struct bidi_it): New member `string'. Make flag members be 1-bit
1353 fields, and put them last in the struct.
640c8776
SM
1354 (compute_display_string_pos, compute_display_string_end):
1355 Update prototypes.
0bb23927
EZ
1356 (bidi_push_it, bidi_pop_it): Add prototypes.
1357 (struct iterator_stack_entry): New members bidi_p,
1358 paragraph_embedding, and from_disp_prop_p.
1359 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1360 (bidi_shelve_cache, bidi_unshelve_cache):
1361 Declare prototypes.
0bb23927
EZ
1362
1363 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1364 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1365 and vector-like objects.
1366
1367 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1368 cache around display iteration.
1369
1370 * window.c (Fwindow_end, window_scroll_pixel_based)
1371 (displayed_window_lines, Frecenter): Save and restore the bidi
1372 cache around display iteration.
1373
3bbd2265
LMI
13742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1375
1376 * editfns.c (Fdelete_region): Clarify the use of the named
1377 parameters (bug#6788).
1378
adc47434
MR
13792011-07-14 Martin Rudalics <rudalics@gmx.at>
1380
1381 * indent.c (Fvertical_motion): Set and restore w->pointm when
1382 saving and restoring the window's buffer (Bug#9006).
1383
837c31f8
LMI
13842011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1385
1386 * editfns.c (Fstring_to_char): Clarify just what is returned
1387 (bug#6576). Text by Eli Zaretskii.
1388
ac389d0c
JB
13892011-07-13 Juanma Barranquero <lekktu@gmail.com>
1390
1391 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1392
0be0ce47
EZ
13932011-07-13 Eli Zaretskii <eliz@gnu.org>
1394
1395 * buffer.c (mmap_find): Fix a typo.
1396
cd18e7e3
JB
13972011-07-13 Johan Bockgård <bojohan@gnu.org>
1398
1399 Fix execution of x selection hooks.
1400 * xselect.c (Qx_lost_selection_functions)
1401 (Qx_sent_selection_functions): New vars.
1402 (syms_of_xselect): DEFSYM them.
1403 (x_handle_selection_request): Pass Qx_sent_selection_functions
1404 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1405 (x_handle_selection_clear,x_clear_frame_selections):
1406 Pass Qx_lost_selection_functions rather than
1407 Vx_lost_selection_functions to Frun_hook_with_args.
1408
47ea7f44
PE
14092011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1410
ac389d0c 1411 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1412 The old code sometimes used this field without initializing it.
1413
47ea7f44
PE
1414 * alloc.c (gc_sweep): Don't read past end of array.
1415 In theory, the old code could also have corrupted Emacs internals,
1416 though it'd be very unlikely.
1417
bc985c87
AS
14182011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1419
1420 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1421 argument. (Bug#4026)
bc985c87 1422
0cf34688
LMI
14232011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1424
b3dadd76
LMI
1425 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1426 key" (bug#4257).
1427
0cf34688
LMI
1428 * window.c (Fset_window_start): Doc fix (bug#4199).
1429 (Fset_window_hscroll): Ditto.
1430
270768cd
PE
14312011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1432
077e3dda 1433 Fix minor new problems caught by GCC 4.6.1.
270768cd 1434 * term.c (init_tty): Remove unused local.
490011a6 1435 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1436 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1437 not used otherwise.
270768cd 1438
b1f58454
CY
14392011-07-12 Chong Yidong <cyd@stupidchicken.com>
1440
1441 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1442
22b9578d
LMI
14432011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1444
6e70ab07
LMI
1445 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1446 are the mini-buffer and the echo area (bug#3320).
1447
22b9578d
LMI
1448 * term.c (init_tty): Remove support for supdup, c10 and perq
1449 terminals, which are no longer supported (bug#1482).
1450
8974cc9f
JB
14512011-07-10 Johan Bockgård <bojohan@gnu.org>
1452
1453 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1454
a560d974
JD
14552011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1456
1457 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1458 for non-popups (Bug#3642).
1459
1dae0f0a
AS
14602011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1461
268c2c36 1462 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1463 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1464 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1465 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1466 * data.c (fmod): Likewise.
1467 * dispnew.c (swap_glyphs_in_rows): Likewise.
1468 * emacs.c (memory_warning_signal): Likewise.
1469 * floatfns.c (float_error): Likewise.
1470 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1471 (otf_open, font_otf_capability, generate_otf_features)
1472 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1473 Likewise.
1474 * image.c (pbm_read_file): Likewise.
1475 * indent.c (string_display_width): Likewise.
1476 * intervals.c (check_for_interval, search_for_interval)
1477 (inc_interval_count, count_intervals, root_interval)
1478 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1479 * lread.c (defalias): Likewise.
268c2c36 1480 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1481 * regex.c (set_image_of_range_1, set_image_of_range)
1482 (regex_grow_registers): Likewise.
1483 * sysdep.c (strerror): Likewise.
1484 * termcap.c (valid_filename_p, tprint, main): Likewise.
1485 * tparam.c (main): Likewise.
1486 * unexhp9k800.c (run_time_remap, save_data_space)
1487 (update_file_ptrs, read_header, write_header, calculate_checksum)
1488 (copy_file, copy_rest, display_header): Likewise.
1489 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1490 Likewise.
1491 * xdisp.c (check_it): Likewise.
1492 * xfaces.c (register_color, unregister_color, unregister_colors):
1493 Likewise.
1494 * xfns.c (print_fontset_result): Likewise.
1495 * xrdb.c (member, fatal, main): Likewise.
1496
99033785
PE
14972011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1498
1499 Fix minor problems found by static checking (Bug#9031).
1500 * chartab.c (char_table_set_range, map_sub_char_table):
1501 Remove unused locals.
1502 (uniprop_table): Now static.
1503 * composite.c (_work_char): Remove unused static var.
1504
9cb2ac56
JB
15052011-07-09 Juanma Barranquero <lekktu@gmail.com>
1506
1507 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1508
f25661f0
JD
15092011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1510
1511 * gtkutil.c (qttip_cb): Remove code without function.
1512
8278c4fe
EZ
15132011-07-09 Eli Zaretskii <eliz@gnu.org>
1514
1515 * w32.c (pthread_sigmask): New stub.
1516
1692ae2d 15172011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1518
8a6ebd58 1519 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1520 sigprocmask is portable only for single-threaded applications, and
1521 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1522 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1523 (LIBES): Use it.
1524 * callproc.c (Fcall_process):
1525 * process.c (create_process):
1526 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1527 Use pthread_sigmask, not sigprocmask.
123403e4 1528
1b854618
JD
15292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1530
1531 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1532 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1533 wrong (Bug#8591).
1534
3fe4b549
JD
15352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1536
0ce7e563
JD
1537 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1538 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1539 (xg_hide_tooltip): Fix comment.
1540
3fe4b549
JD
1541 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1542 in registerServicesMenuSendTypes.
1543 (validRequestorForSendType): Don't check ns_return_types.
1544
1545 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1546 ns_return_type.
1547
5df75e47
JR
15482011-07-08 Jason Rumney <jasonr@gnu.org>
1549
1550 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1551 frame struct members of non-existent frames (Bug#6284).
1552
699c10bd
JD
15532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1554
4393663b
JD
1555 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1556 variable firstTime not needed on OSX >= 10.6.
1557 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1558 >= 10.5. Use setKnobProportion, setDoubleValue.
1559
1560 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1561 (MAC_OS_X_VERSION_10_5): Define if not defined.
1562 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1563 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1564 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1565
1566 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1567 cString and lossyCString on OSX >= 10.4
1568
1569 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1570 sizeToFit on OSX >= 10.2.
1571
1572 * nsimage.m (allocInitFromFile): Don't use deprecated method
1573 bestRepresentationForDevice on OSX >= 10.6.
1574
1575 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1576 to avoid warning.
1577
1578 * emacs.c: Declare unexec_init_emacs_zone.
1579
a63e0781
JD
1580 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1581
699c10bd
JD
1582 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1583
1584 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1585 on svcsMenu (Bug#8842).
1586
1587 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1588 ns_return_types.
1589 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1590
1591 * nsterm.m (QUTF8_STRING): Declare.
1592 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1593 (validRequestorForSendType): Return type is (id).
1594 Change indexOfObjectIdenticalTo to indexOfObject.
1595 Check if we have local selection before returning self (Bug#8842).
1596 (writeSelectionToPasteboard): Put local selection into paste board
1597 if we have a local selection (Bug#8842).
1598 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1599
1600 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1601 (ns_get_local_selection): Declare.
1602
54e10184
LMI
16032011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1604
9888ff71
LMI
1605 * keymap.c (describe_map_tree): Don't insert a double newline at
1606 the end of the buffer (bug#1169) and return whether we inserted
1607 something.
1608
54e10184
LMI
1609 * callint.c (Fcall_interactively): Change "reading args" to
1610 "providing args" to try to clarify what it does (bug#1010).
1611
15fa4783
KH
16122011-07-07 Kenichi Handa <handa@m17n.org>
1613
1614 * composite.c (composition_compute_stop_pos): Ignore a static
1615 composition starting before CHARPOS (Bug#8915).
1616
1617 * xdisp.c (handle_composition_prop): Likewise.
1618
a8815b00
EZ
16192011-07-07 Eli Zaretskii <eliz@gnu.org>
1620
1621 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1622 (Bug#9015)
1623
ef7b981d 16242011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1625
1626 * character.h (unicode_category_t): New enum type.
1627
1628 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1629 (Qchar_code_property_table): New variable.
1630 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1631 (UNIPROP_COMPRESSED_FORM_P): New macros.
1632 (char_table_ascii): Uncompress the compressed values.
1633 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1634 Uncompress the compressed values.
ac389d0c 1635 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1636 (char_table_ref_and_range): Uncompress the compressed values.
1637 (sub_char_table_set): New arg is_uniprop. Callers changed.
1638 Uncompress the compressed values.
1639 (sub_char_table_set_range): Args changed. Callers changed.
1640 (char_table_set_range): Adjuted for the above change.
1641 (map_sub_char_table): Delete args default_val and parent. Add arg
1642 top. Give decoded values to a Lisp function.
640c8776 1643 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1644 values to a Lisp function. Gcpro more variables.
1645 (uniprop_table_uncompress)
1646 (uniprop_decode_value_run_length): New functions.
1647 (uniprop_decoder, uniprop_decoder_count): New variables.
1648 (uniprop_get_decoder, uniprop_encode_value_character)
1649 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1650 New functions.
1651 (uniprop_encoder, uniprop_encoder_count): New variables.
1652 (uniprop_get_encoder, uniprop_table)
1653 (Funicode_property_table_internal, Fget_unicode_property_internal)
1654 (Fput_unicode_property_internal): New functions.
1655 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1656 Sunicode_property_table_internal, Sget_unicode_property_internal,
1657 and Sput_unicode_property_internal. Defvar_lisp
1658 char-code-property-alist.
1659
640c8776 1660 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1661 Vunicode_category_table.
1662
640c8776 1663 * font.c (font_range): Adjust for the change of
c805dec0
KH
1664 Vunicode_category_table.
1665
76b397fb
DN
16662011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1667
1668 * m/iris4d.h: Remove file, move contents ...
1669 * s/irix6-5.h: ... here.
1670
22b4128e
PE
16712011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1672
1673 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1674 * alloc.c (mark_buffer):
1675 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1676 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1677 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1678 This isn't true in general, and it's particularly not true
1679 if Emacs is configured with --with-wide-int.
1680 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1681 New macros, used in the buffer.c change.
1682
869795d6
JD
16832011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1684
1685 * xsettings.c: Use both GConf and GSettings if both are available.
1686 (store_config_changed_event): Add comment.
1687 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1688 (store_tool_bar_style_changed): New functions.
1689 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1690 (struct xsettings): Move font inside HAVE_XFT.
1691 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1692 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1693 Move inside HAVE_XFT.
640c8776 1694 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1695 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1696 also.
1697 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1698 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1699 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1700 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1701 (parse_settings): Move check for font inside HAVE_XFT.
1702 (read_settings, apply_xft_settings): Add comment.
1703 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1704 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1705 call store_font_name_changed.
1706 (xft_settings_event): Add comment.
1707 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1708 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1709 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1710 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1711 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1712 (xsettings_get_system_font, xsettings_get_system_normal_font):
1713 Add comment.
869795d6 1714
d8ed26bd
PE
17152011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1716
1717 Random fixes. E.g., (random) never returned negative values.
1718 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1719 subseconds part to the entropy, as that's a bit more random.
1720 Prefer signed to unsigned, since the signedness doesn't matter and
1721 in general we prefer signed. When given a limit, use a
1722 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1723 latter isn't right if USE_2_TAGS_FOR_INTS.
1724 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1725 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1726
cabf1cac
SM
17272011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1728
1729 * textprop.c (text_property_stickiness):
1730 Obey Vtext_property_default_nonsticky.
1731 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1732 * w32fns.c (syms_of_w32fns):
1733 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1734
6e9b2be9
PE
17352011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1736
1737 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1738 This is more efficient than Ffile_directory_p and avoids a minor race.
1739
90186c68
LMI
17402011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1741
7c301272
LMI
1742 * buffer.c (Foverlay_put): Say what the return value is
1743 (bug#7835).
1744
c4f2d8d4
LMI
1745 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1746 is a directory before asking whether to use the file name
1747 (bug#7564).
ad637907
LMI
1748 (barf_or_query_if_file_exists): Make the "File is a directory"
1749 error be more correct.
c4f2d8d4 1750
90186c68
LMI
1751 * fns.c (Frequire): Remove the mention of the .gz files, since
1752 that's installation-specific, but keep the mention of
1753 `get-load-suffixes'.
1754
da64016e
PE
17552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1756
1757 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1758 Report string overflow if the output is too long.
1759
7d47b580
JB
17602011-07-04 Juanma Barranquero <lekktu@gmail.com>
1761
a555cb87
JB
1762 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1763 (syms_of_gnutls): Remove duplicate DEFSYM for
1764 Qgnutls_bootprop_verify_hostname_error, an error for
1765 Qgnutls_bootprop_verify_error (which is no longer used).
1766
7d47b580
JB
1767 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1768 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1769 Also (re)move comments that are misplaced or no longer relevant.
1770
1e49bfab
LMI
17712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1772
1773 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1774
1485f4c0
CY
17752011-07-03 Chong Yidong <cyd@stupidchicken.com>
1776
1777 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1778 and background color parameters if they have been changed.
1779
a9ab721e
LMI
17802011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1781
1782 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1783
cf7cff57
PE
17842011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1785
2e13213d
PE
1786 * xsettings.c (SYSTEM_FONT): Define only when used.
1787 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1788
cf7cff57
PE
1789 * keymap.c (access_keymap_1): Now static.
1790
7a8e04f7
CY
17912011-07-02 Chong Yidong <cyd@stupidchicken.com>
1792
1793 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1794 leave any prefix arg for the up event (Bug#1586).
1795
61352f62
LMI
17962011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1797
69bb1ef7
LMI
1798 * lread.c (syms_of_lread): Mention single symbols defined by
1799 `defvar' or `defconst' (bug#7154).
1800
61352f62 1801 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1802 (Frequire): Mention get-load-suffixes.
61352f62 1803
28545e04
MR
18042011-07-02 Martin Rudalics <rudalics@gmx.at>
1805
1806 * window.h (window): Remove clone_number slot.
1807 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1808 Remove.
1809 (make_parent_window, make_window, saved_window)
1810 (Fset_window_configuration, save_window_save): Don't deal with
1811 clone numbers.
1812 * buffer.c (Qclone_number): Remove declaration.
1813 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1814
3349e122
SM
18152011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1816
1817 Add multiple inheritance to keymaps.
1818 * keymap.c (Fmake_composed_keymap): New function.
1819 (Fset_keymap_parent): Simplify.
1820 (fix_submap_inheritance): Remove.
1821 (access_keymap_1): New function extracted from access_keymap to handle
1822 embedded parents and handle lists of maps.
1823 (access_keymap): Use it.
1824 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1825 (Fcopy_keymap): Handle embedded parents.
1826 (Fcommand_remapping, define_as_prefix): Simplify.
1827 (Fkey_binding): Simplify.
1828 (syms_of_keymap): Move minibuffer-local-completion-map,
1829 minibuffer-local-filename-completion-map,
1830 minibuffer-local-must-match-map, and
1831 minibuffer-local-filename-must-match-map to Elisp.
1832 (syms_of_keymap): Defsubr make-composed-keymap.
1833 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1834 (parse_menu_item): Trivial simplification.
1835
3279eb87
GM
18362011-07-01 Glenn Morris <rgm@gnu.org>
1837
1838 * Makefile.in (SETTINGS_LIBS): Fix typo.
1839
4550efdf
KI
18402011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1841
1842 * coding.c (Fencode_coding_string): Record the last coding system
1843 used, as the function doc string says (bug#8738).
1844
0949d2b6
JD
18452011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1846
1847 * xsettings.c (store_monospaced_changed): Take new font as arg and
1848 check for change against current_mono_font.
1849 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1850 (emacs_settings_constructor, emacs_settings_get_property)
1851 (emacs_settings_set_property, emacs_settings_class_init)
1852 (emacs_settings_init, gsettings_obj): Remove.
1853 (something_changedCB): New function for HAVE_GSETTINGS.
1854 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1855 with value as argument.
1856 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1857 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1858 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1859 "changed".
1860
1861 * xgselect.c: Add defined (HAVE_GSETTINGS).
1862 (xgselect_initialize): Ditto.
1863
1864 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1865 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1866 xg_select.
1867
bbc6b304
PE
18682011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 * eval.c (struct backtrace): Simplify and port the data structure.
1871 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1872 signed bit field, as this assumption is not portable and it makes
1873 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1874 "char debug_on_exit : 1" as this is not portable either; instead,
1875 use the portable "unsigned int debug_on_exit : 1". Remove unused
1876 member evalargs. Remove obsolete comments about cc bombing out.
1877
9851bfc5
JD
18782011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1879
51bb811f 1880 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1881 Let HAVE_GSETTINGS override HAVE_GCONF.
1882 (store_monospaced_changed): New function.
1883 (EMACS_SETTINGS): A new type derived from GObject to handle
1884 GSettings notifications.
1885 (emacs_settings_constructor, emacs_settings_get_property)
1886 (emacs_settings_set_property, emacs_settings_class_init):
1887 New functions.
1888 (gsettings_client, gsettings_obj): New variables.
1889 (GSETTINGS_SCHEMA): New define.
1890 (something_changedCB): Call store_monospaced_changed.
1891 (init_gsettings): New function.
1892 (xsettings_initialize): Call init_gsettings.
1893 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1894 to NULL.
1895
640c8776 1896 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1897 GCONF_CFLAGS/LIBS.
1898
5386012d
MR
18992011-06-29 Martin Rudalics <rudalics@gmx.at>
1900
1901 * window.c (resize_root_window, grow_mini_window)
1902 (shrink_mini_window): Rename Qresize_root_window to
1903 Qwindow_resize_root_window and Qresize_root_window_vertically to
1904 Qwindow_resize_root_window_vertically.
1905
f13e0b08
PE
19062011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1907
1908 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1909
94515237
JB
19102011-06-27 Juanma Barranquero <lekktu@gmail.com>
1911
1912 * makefile.w32-in: Redesign dependencies so they reflect more
1913 clearly which files are directly included by each source file,
1914 and not through other includes.
1915
e43b6e43
MR
19162011-06-27 Martin Rudalics <rudalics@gmx.at>
1917
1918 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1919 (sort_overlays, overlay_strings): When an overlay's clone number
1920 matches the window's clone number process the overlay even if
1921 the overlay's window property doesn't match the current window.
1922
d68443dc
MR
1923 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1924 (Fwindow_hchild): Rename to Fwindow_left_child.
1925 (Fwindow_next): Rename to Fwindow_next_sibling.
1926 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1927 (resize_window_check): Rename to window_resize_check.
1928 (resize_window_apply): Rename to window_resize_apply.
1929 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1930 (Fdelete_other_windows_internal, resize_frame_windows)
1931 (Fsplit_window_internal, Fdelete_window_internal)
1932 (grow_mini_window, shrink_mini_window)
1933 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1934
c7e73be5
JD
19352011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1936
1937 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1938 (emacs_fixed_set_min_size): Remove.
1939 (emacs_fixed_new): Take frame as argument.
1940
1941 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1942 (_EmacsFixedPrivate): Remove minwidth/height.
1943 Add struct frame *f.
1944 (emacs_fixed_init): Initialize priv->f.
1945 (get_parent_class, emacs_fixed_set_min_size): Remove.
1946 (emacs_fixed_new): Set priv->f to argument.
1947 (emacs_fixed_get_preferred_width)
1948 (emacs_fixed_get_preferred_height): Use min_width/height from
1949 frames size_hint to set minimum and natural (Bug#8919).
1950 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1951 and use min_width/height from frames size_hint to set
1952 min_width/height (Bug#8919).
1953
1954 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1955 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1956 Fix indentation.
c7e73be5 1957
cf99dcf8
EZ
19582011-06-26 Eli Zaretskii <eliz@gnu.org>
1959
1960 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1961 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1962 called at ZV.
1963
029529ac
CY
19642011-06-26 Chong Yidong <cyd@stupidchicken.com>
1965
1966 * process.c (wait_reading_process_output): Bypass select if
1967 waiting for a cell while ignoring keyboard input, and input is
1968 pending. Suggested by Jan Djärv (Bug#8869).
1969
7a7ef429
PE
19702011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 Use gnulib's dup2 module instead of rolling our own.
1973 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1974
11fdef7d 19752011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1976
1977 * dispnew.c (scrolling_window): Before scrolling, turn off a
1978 mouse-highlight in the window being scrolled.
1979
cd3520a4
JB
19802011-06-24 Juanma Barranquero <lekktu@gmail.com>
1981
1982 Move DEFSYM to lisp.h and use everywhere.
1983
1984 * character.h (DEFSYM): Move declaration...
1985 * lisp.h (DEFSYM): ...here.
1986
1987 * gnutls.c:
1988 * minibuf.c:
1989 * w32menu.c:
1990 * w32proc.c:
1991 * w32select.c: Don't include character.h.
1992
1993 * alloc.c (syms_of_alloc):
1994 * buffer.c (syms_of_buffer):
1995 * bytecode.c (syms_of_bytecode):
1996 * callint.c (syms_of_callint):
1997 * casefiddle.c (syms_of_casefiddle):
1998 * casetab.c (init_casetab_once):
1999 * category.c (init_category_once, syms_of_category):
2000 * ccl.c (syms_of_ccl):
2001 * cmds.c (syms_of_cmds):
2002 * composite.c (syms_of_composite):
2003 * dbusbind.c (syms_of_dbusbind):
2004 * dired.c (syms_of_dired):
2005 * dispnew.c (syms_of_display):
2006 * doc.c (syms_of_doc):
2007 * editfns.c (syms_of_editfns):
2008 * emacs.c (syms_of_emacs):
2009 * eval.c (syms_of_eval):
2010 * fileio.c (syms_of_fileio):
2011 * fns.c (syms_of_fns):
2012 * frame.c (syms_of_frame):
2013 * fringe.c (syms_of_fringe):
2014 * insdel.c (syms_of_insdel):
2015 * keymap.c (syms_of_keymap):
2016 * lread.c (init_obarray, syms_of_lread):
2017 * macros.c (syms_of_macros):
2018 * msdos.c (syms_of_msdos):
2019 * print.c (syms_of_print):
2020 * process.c (syms_of_process):
2021 * search.c (syms_of_search):
2022 * sound.c (syms_of_sound):
2023 * syntax.c (init_syntax_once, syms_of_syntax):
2024 * terminal.c (syms_of_terminal):
2025 * textprop.c (syms_of_textprop):
2026 * undo.c (syms_of_undo):
2027 * w32.c (globals_of_w32):
2028 * window.c (syms_of_window):
2029 * xdisp.c (syms_of_xdisp):
2030 * xfaces.c (syms_of_xfaces):
2031 * xfns.c (syms_of_xfns):
2032 * xmenu.c (syms_of_xmenu):
2033 * xsettings.c (syms_of_xsettings):
2034 * xterm.c (syms_of_xterm): Use DEFSYM.
2035
4228cf16
TZ
20362011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2037
cd3520a4 2038 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2039
7fcccf1e
PE
20402011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2041
7efb4e0e
PE
2042 Integer and buffer overflow fixes (Bug#8873).
2043
ff5844ad
PE
2044 * print.c (printchar, strout): Check for string overflow.
2045 (PRINTPREPARE, printchar, strout):
2046 Don't set size unless allocation succeeds.
2047
90532f02
PE
2048 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2049 for sizes. Check for string overflow more accurately.
2050 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2051
6d84508d
PE
2052 * macros.c: Integer and buffer overflow fixes.
2053 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2054 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2055 Use ptrdiff_t, not int, for sizes.
2056 Don't increment bufsize until after realloc succeeds.
2057 Check for size-calculation overflow.
2058 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2059
437b2cb4
PE
2060 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2061
8b9ac8b4
PE
2062 * lread.c: Integer overflow fixes.
2063 (read_integer): Radix is now EMACS_INT, not int,
2064 to improve quality of diagnostics for out-of-range radices.
2065 Calculate buffer size correctly for out-of-range radices.
2066 (read1): Check for integer overflow in radices, and in
2067 read-circle numbers.
82cb60d3
PE
2068 (read_escape): Avoid int overflow.
2069 (Fload, openp, read_buffer_size, read1)
2070 (substitute_object_recurse, read_vector, read_list, map_obarray):
2071 Use ptrdiff_t, not int, for sizes.
2072 (read1): Use EMACS_INT, not int, for sizes.
20270765 2073 Check for size overflow.
8b9ac8b4 2074
7fcccf1e
PE
2075 * image.c (cache_image): Check for size arithmetic overflow.
2076
bfbbd7e7
PE
2077 * lread.c: Integer overflow issues.
2078 (saved_doc_string_size, saved_doc_string_length)
2079 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2080 Now ptrdiff_t, not int.
2081 (read1): Don't assume doc string length fits in int. Check for
2082 out-of-range doc string lengths.
2083 (read_list): Don't assume file position fits in int.
39019e54 2084 (read_escape): Check for hex character overflow.
bfbbd7e7 2085
4e323265
LL
20862011-06-22 Leo Liu <sdl.web@gmail.com>
2087
2088 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2089 Move to minibuffer.el.
2090
85fece3e
PE
20912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2092
20b84ce9 2093 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2094 The following patches are for when GLYPH_DEBUG && !XASSERT.
2095 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2096 * dispnew.c (flush_stdout):
2097 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2098 Mark as externally visible.
2099 * dispnew.c (check_window_matrix_pointers): Now static.
2100 * dispnew.c (window_to_frame_vpos):
2101 * xfns.c (unwind_create_frame):
2102 * xterm.c (x_check_font): Remove unused local.
2103 * scroll.c (CHECK_BOUNDS):
2104 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2105 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2106 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2107 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2108 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2109 Now static.
2110 (debug_method_add): Use va_list and vsprintf rather than relying
2111 on undefined behavior with wrong number of arguments.
2112 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2113 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2114 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2115 since we're not interested in debugging glyphs with old libraries.
2116 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2117 GCC 4.6.0's static checking.
2118
0766b489
PE
21192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2120
31fd4b32
PE
2121 Integer overflow and signedness fixes (Bug#8873).
2122 A few related buffer overrun fixes, too.
2123
b79e8648
PE
2124 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2125
0766b489
PE
2126 * dispextern.h (struct face.stipple):
2127 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2128 (x_bitmap_mask, x_allocate_bitmap_record)
2129 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2130 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2131 (x_create_bitmap_from_xpm_data):
2132 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2133 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2134 (.bitmaps_last):
2135 * xfaces.c (load_pixmap):
2136 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2137 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2138 (.bitmaps_last, struct x_output.icon_bitmap):
2139 Use ptrdiff_t, not int, for bitmap indexes.
2140 (x_allocate_bitmap_record): Check for size overflow.
2141 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2142
b081724f
PE
2143 Use ptrdiff_t, not int, for overlay counts.
2144 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2145 * editfns.c (overlays_around, get_pos_property):
2146 * textprop.c (get_char_property_and_overlay):
2147 * xdisp.c (next_overlay_change, note_mouse_highlight):
2148 * xfaces.c (face_at_buffer_position):
21514da7
PE
2149 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2150 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2151 (Fnext_overlay_change, Fprevious_overlay_change)
2152 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2153 Use ptrdiff_t, not int, for sizes.
21514da7 2154 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2155
3de73e5e
PE
2156 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2157
2606c57b
PE
2158 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2159 (x_session_initialize): Do not assume string length fits in int.
2160
aaafe47a
PE
2161 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2162 This is unlikely, but can occur if DPI is outlandish.
2163
2674ddc8 2164 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2165 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2166
28154962
PE
2167 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2168 * xrdb.c (magic_file_p, search_magic_path):
2169 Omit last arg SUFFIX; it was always 0. All callers changed.
2170 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2171
7de51af5
PE
2172 * xfont.c (xfont_match): Avoid need for strlen.
2173
25ed6cc3
PE
2174 * xfns.c: Don't assume strlen fits in int.
2175 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2176
4eab31dd
PE
2177 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2178 not unsigned long, as we prefer signed integers. All callers changed.
2179 Detect integer overflow in repeat count.
2180 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2181 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2182
171e2a58
PE
2183 * termcap.c: Don't assume sizes fit in int and never overflow.
2184 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2185 (gobble_line): Check for size-calculation overflow.
2186
ad39faca 2187 * minibuf.c (Fread_buffer):
6e5bb2dc 2188 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2189 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2190 Don't assume string length fits in int.
2191
52c61c22 2192 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2193 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2194
b5b8c9e5
PE
2195 * font.c: Don't assume string length fits in int.
2196 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2197 Use ptrdiff_t, not int.
ccd6111c
PE
2198 (font_intern_prop): Don't assume string length fits in int.
2199 Don't assume integer property fits in fixnum.
2200 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2201
882f0d81 2202 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2203 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2204 Reformulate so as not to need the command string.
2205 Invoke gzip -cd rather than gunzip, as it's more portable.
2206 (lock_info_type, lock_file_1, lock_file):
2207 Don't assume pid_t and time_t fit in unsigned long.
2208 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2209 (current_lock_owner): Prefer signed type for sizes.
2210 Use memcpy, not strncpy, where memcpy is what is really wanted.
2211 Don't assume (via atoi) that time_t and pid_t fit in int.
2212 Check for time_t and/or pid_t out of range, e.g., via a network share.
2213 Don't alloca where an auto var works fine.
2214
93f4cf88
PE
2215 * fileio.c: Fix some integer overflow issues.
2216 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2217 Don't assume string length fits in int.
2218 (directory_file_name): Don't assume string length fits in long.
2219 (make_temp_name): Don't assume pid fits in int, or that its print
2220 length is less than 20.
2221
f3e92b69
PE
2222 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2223
1bfdaf10
PE
2224 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2225
35016e9a
PE
2226 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2227
3d1e65a1
PE
2228 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2229 We prefer signed integers, even for size calculations.
2230
0b963a93
PE
2231 * emacs.c: Don't assume string length fits in 'int'.
2232 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2233 (main): Don't invoke strlen when not needed.
2234
573f4b54
PE
2235 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2236 (XD_DEBUG_MESSAGE): Don't waste a byte.
2237
989f33ba
PE
2238 * callproc.c (getenv_internal_1, getenv_internal)
2239 (Fgetenv_internal):
965d34eb
PE
2240 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2241
e4d29b33
PE
2242 * lread.c (invalid_syntax): Omit length argument.
2243 All uses changed. This doesn't fix a bug, but it simplifies the
2244 code away from its former Hollerith-constant appearance, and it's
2245 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2246 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2247
eb49b136
PE
2248 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2249 This didn't break anything, but it didn't help either.
2250 It's confusing to put a bogus integer in a place where the actual
2251 value does not matter.
9f62aeb1 2252 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2253 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2254
15375a22
PE
2255 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2256 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2257 implementation.
b61cc01c
PE
2258 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2259 We prefer signed types, and the value cannot exceed the EMACS_INT
2260 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2261 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2262 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2263 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2264
53b2623d
PE
2265 * indent.c (sane_tab_width): New function.
2266 (current_column, scan_for_column, Findent_to, position_indentation)
2267 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2268 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2269
51cab52b 2270 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2271
f2ed8a70
PE
2272 * lisp.h (lint_assume): New macro.
2273 * composite.c (composition_gstring_put_cache):
2274 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2275
abe80cc6
PE
2276 * editfns.c, insdel.c:
2277 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2278
b02c740e
PE
2279 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2280
ebc96716
PE
2281 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2282
b4e50fa0 2283 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2284 Use much-faster test for byte-length change.
311d5d7c 2285 Don't assume string byte-length fits in 'int'.
a4cf38e4 2286 Check that character arg fits in 'int'.
85461888 2287 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2288
c0c1ee9f
PE
2289 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2290
a498d7f4
PE
2291 * fns.c (concat): Catch string overflow earlier.
2292 Do not rely on integer wraparound.
2293
51cab52b
PE
2294 * dispextern.h (struct it.overlay_strings_charpos)
2295 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2296 * xdisp.c (forward_to_next_line_start)
2297 (back_to_previous_visible_line_start)
2298 (reseat_at_next_visible_line_start, next_element_from_buffer):
2299 Don't arbitrarily truncate the value of 'selective' to int.
2300
76031fad
PE
2301 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2302
5eb55db9
PE
2303 * composite.c: Don't truncate sizes to 'int'.
2304 (composition_gstring_p, composition_reseat_it)
2305 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2306 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2307 not EMACS_UINT, for indexes.
5eb55db9 2308
0703a717
PE
2309 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2310
d6202519
PE
2311 * buffer.c: Include <verify.h>.
2312 (struct sortvec.priority, struct sortstr.priority):
8961a454 2313 Now EMACS_INT, not int.
c20998a7 2314 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2315 (struct sortstr.size, record_overlay_string)
2316 (struct sortstrlist.size, struct sortlist.used):
2317 Don't truncate size to int.
2318 (record_overlay_string): Check for size-calculation overflow.
d6202519 2319 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2320
d5a19415
JM
23212011-06-22 Jim Meyering <meyering@redhat.com>
2322
029529ac 2323 Don't leak an XBM-image-sized buffer
d5a19415
JM
2324 * image.c (xbm_load): Free the image buffer after using it.
2325
a9041e6c
PE
23262011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2327
2328 Port to Sun C.
2329 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2330 that Sun C diagnosed.
2331 * fns.c (secure_hash): Fix pointer signedness issue.
2332 * intervals.c (static_offset_intervals): New function.
2333 (offset_intervals): Use it.
2334
7f3f739f
LL
23352011-06-21 Leo Liu <sdl.web@gmail.com>
2336
2337 * deps.mk (fns.o):
2338 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2339 sha512.h.
2340
2341 * fns.c (secure_hash): Rename from crypto_hash_function and change
2342 the first arg to accept symbols.
5b66d427 2343 (Fsecure_hash): New primitive.
7f3f739f
LL
2344 (syms_of_fns): New symbols.
2345
76147d94
DD
23462011-06-20 Deniz Dogan <deniz@dogan.se>
2347
2348 * process.c (Fset_process_buffer): Clarify return value in
2349 docstring.
2350
7d7d0045
CY
23512011-06-18 Chong Yidong <cyd@stupidchicken.com>
2352
2353 * dispnew.c (add_window_display_history): Use BVAR.
2354
2355 * xdisp.c (debug_method_add): Use BVAR.
2356 (check_window_end, dump_glyph_matrix, dump_glyph)
2357 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2358
2359 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2360 Likewise.
2361
2362 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2363 check till after the cache is created in init_frame_faces.
2364
ff2bc410
SM
23652011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2366
2367 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2368
28177add
PE
23692011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2370
dd3482fe
PE
2371 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2372 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2373 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2374
393d71f3 2375 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2376 * fileio.c (Finsert_file_contents):
2377 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2378 Remove the old (too-loose) buffer overflow checks.
2379 They weren't needed, since make_gap checks for buffer overflow.
2380 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2381 The old code merely checked for Emacs fixnum overflow, and relied
2382 on undefined (wraparound) behavior. The new code avoids undefined
2383 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2384
2e6813b0 2385 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2386 Tune. Don't use wider integers than needed. Don't use alloca.
2387 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2388
599a9e4f
PE
2389 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2390
99561444
PE
2391 * insdel.c, lisp.h (buffer_overflow): New function.
2392 (insert_from_buffer_1, replace_range, replace_range_2):
2393 * insdel.c (make_gap_larger):
2394 * editfns.c (Finsert_char):
2395 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2396
28177add
PE
2397 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2398
e69dafad
PE
23992011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2400
a7af7fde 2401 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2402
b1c46f02
PE
2403 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2404 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2405
e69dafad
PE
2406 * fileio.c: Don't assume EMACS_INT fits in off_t.
2407 (emacs_lseek): New static function.
2408 (Finsert_file_contents, Fwrite_region): Use it.
2409 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2410
566684ea
PE
2411 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2412
e6966cd6
PE
2413 * fns.c: Don't overflow int when computing a list length.
2414 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2415 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2416 truncation on 64-bit hosts. Check for QUIT every
2417 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2418 faster and is responsive enough.
2419 (Flength): Report an error instead of overflowing an integer.
2420 (Fsafe_length): Return a float if the value is not representable
2421 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2422 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2423 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2424
dd0b0efb
PE
2425 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2426 (header_size, word_size): New constants.
2427 (allocate_vectorlike): Don't check size overflow here.
2428 (allocate_vector): Check it here instead, since this is the only
2429 caller of allocate_vectorlike that could cause overflow.
2430 Check that the new vector's length is representable as a fixnum.
2431
86fe5cfe
PE
2432 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2433 The previous code was bogus. For example, next_almost_prime (32)
2434 returned 39, which is undesirable as it is a multiple of 3; and
2435 next_almost_prime (24) returned 25, which is a multiple of 5 so
2436 why was the code bothering to check for multiples of 7?
2437
80e88859
PE
2438 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2439
4a2f0ad6
PE
2440 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2441
f66c7cf8
PE
2442 Variadic C functions now count arguments with ptrdiff_t.
2443 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2444 Back then I didn't know that the Emacs coding style prefers signed int.
2445 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2446 were being counted with int, which may truncate counts on 64-bit
2447 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2448 * lisp.h (struct Lisp_Subr.function.aMANY)
2449 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2450 Arg counts are now ptrdiff_t, not size_t.
2451 All variadic functions and their callers changed accordingly.
2452 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2453 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2454 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2455 * callint.c (Fcall_interactively): Check arg count for overflow,
2456 to avoid potential buffer overrun. Use signed char, not 'int',
2457 for 'varies' array, so that we needn't bother to check its size
2458 calculation for overflow.
2459 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2460 * eval.c (apply_lambda):
2461 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2462 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2463 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2464
a1759b76
PE
2465 * callint.c (Fcall_interactively): Don't use index var as event count.
2466
d96be9fc
PE
2467 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2468 * mem-limits.h (SIZE): Remove; no longer used.
2469
a690a978 2470 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2471
578c21e6
PE
2472 Remove unnecessary casts.
2473 * xterm.c (x_term_init):
2474 * xfns.c (x_set_border_pixel):
2475 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2476 These aren't needed now that we assume ANSI C.
2477
96f53c6c
PE
2478 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2479 It's more likely to cause problems (due to unsigned overflow)
2480 than to cure them.
2481
83c77d31
PE
2482 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2483
ee2079f1
PE
2484 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2485
6da65536
PE
2486 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2487
7147c4a4
PE
2488 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2489
193e32d9
PE
2490 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2491
e5533da6
PE
2492 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2493
9910e595
PE
2494 GLYPH_CODE_FACE returns EMACS_INT, not int.
2495 * dispextern.h (merge_faces):
2496 * xfaces.c (merge_faces):
01103c44
PE
2497 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2498 Don't assume EMACS_INT fits in int.
9910e595 2499
2638320e
PE
2500 * character.h (CHAR_VALID_P): Remove unused parameter.
2501 * fontset.c, lisp.h, xdisp.c: All uses changed.
2502
045eb8d9
PE
2503 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2504
c1f134b5
PE
2505 * fns.c (concat): Minor tuning based on overflow analysis.
2506 This doesn't fix any bugs. Use int to hold character, instead
2507 of constantly refetching from Emacs object. Use XFASTINT, not
2508 XINT, for value known to be a character. Don't bother comparing
2509 a single byte to 0400, as it's always less.
2510
395fcb93 2511 * floatfns.c (Fexpt):
327eeec8
PE
2512 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2513
abbd3d23
PE
2514 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2515 for characters.
2516
684a03ef
PE
2517 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2518
0fed43f3
PE
2519 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2520 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2521 incorrectly succeed when S was a string, because 4294967386 was
2522 truncated before it was used.
2523
8fd02eb7
PE
2524 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2525 Otherwise, an out-of-range integer could cause undefined behavior
2526 on a 64-bit host.
2527
f8c86b69
PE
2528 * composite.c: Use int, not EMACS_INT, for characters.
2529 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2530 EMACS_INT, for values that are known to be in character range.
2531 This doesn't fix any bugs but is the usual style inside Emacs and
2532 may generate better code on 32-bit machines.
2533
34206dd2
PE
2534 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2535 This is for reasons similar to the recent CHAR_STRING fix.
2536 * charset.c (Fencode_char): Check that character arg is actually
2537 a character. Pass an int to ENCODE_CHAR.
2538 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2539 wider than 'int', as a compile-time check to prevent future regressions
2540 in this area.
2541
c5958d4c 2542 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2543
2544 Make sure a 64-bit char is never passed to CHAR_STRING.
2545 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2546 by silently ignoring the top 32 bits, allowing some values
2547 that were far too large to be valid characters.
2548 * character.h: Include <verify.h>.
2549 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2550 arguments are no wider than unsigned, as a compile-time check
2551 to prevent future regressions in this area.
2552 * data.c (Faset):
01103c44 2553 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2554 (Fsubst_char_in_region):
2555 * fns.c (concat):
2556 * xdisp.c (decode_mode_spec_coding):
2557 Adjust to CHAR_STRING's new requirement.
2558 * editfns.c (Finsert_char, Fsubst_char_in_region):
2559 * fns.c (concat): Check that character args are actually
2560 characters. Without this test, these functions did the wrong
2561 thing with wildly out-of-range values on 64-bit hosts.
2562
d37ca623
PE
2563 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2564 These casts should not be needed on 32-bit hosts, either.
2565 * keyboard.c (read_char):
2566 * lread.c (Fload): Remove casts to unsigned.
2567
ea204efb
PE
2568 * lisp.h (UNSIGNED_CMP): New macro.
2569 This fixes comparison bugs on 64-bit hosts.
2570 (ASCII_CHAR_P): Use it.
2571 * casefiddle.c (casify_object):
01103c44 2572 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2573 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2574 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2575 * dispextern.h (FACE_FROM_ID):
2576 * keyboard.c (read_char): Use UNSIGNED_CMP.
2577
41cb286c
PE
2578 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2579 not to EMACS_INT, to avoid GCC warning.
2580
4a1b9832
PE
2581 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2582
55daad71
PE
2583 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2584 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2585 isn't needed on 32-bit machines.
8f95c75c 2586
01103c44
PE
2587 * buffer.c (Fgenerate_new_buffer_name):
2588 Use EMACS_INT for count, not int.
0ceccced 2589 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2590
2591 * data.c (Qcompiled_function): Now static.
2592
c6f072e7
PE
2593 * window.c (window_body_lines): Now static.
2594
20ce5912
PE
2595 * image.c (gif_load): Rename local to avoid shadowing.
2596
9c4c5f81
PE
2597 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2598 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2599 * alloc.c (make_save_value): Integer argument is now of type
2600 ptrdiff_t, not int.
2601 (mark_object): Use ptrdiff_t, not int.
2602 * lisp.h (pD): New macro.
2603 * print.c (print_object): Use it.
2604
c0c5c8ae
PE
2605 * alloc.c: Use EMACS_INT, not int, to count objects.
2606 (total_conses, total_markers, total_symbols, total_vector_size)
2607 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2608 (total_free_floats, total_floats, total_free_intervals)
2609 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2610 Now EMACS_INT, not int. All uses changed.
2611 (Fgarbage_collect): Compute overall total using a double, so that
2612 integer overflow is less likely to be a problem. Check for overflow
2613 when converting back to an integer.
5a25e253
PE
2614 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2615 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2616 These were 'int' variables that could overflow on 64-bit hosts;
2617 they were never used, so remove them instead of repairing them.
211a0b2a 2618 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2619 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2620 Previously, this ceilinged at INT_MAX, but that doesn't work on
2621 64-bit machines.
e46bb31a 2622 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2623
c78baabf 2624 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2625 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2626 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2627 when a (possibly-narrower) signed value would do just as well.
2628 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2629
c9d624c6
PE
2630 * alloc.c: Catch some string size overflows that we were missing.
2631 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2632 for convenience in STRING_BYTES_MAX.
2633 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2634 The definition here is exact; the one in lisp.h was approximate.
2635 (allocate_string_data): Check for string overflow. This catches
2636 some instances we weren't catching before. Also, it catches
2637 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2638 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2639 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2640
c9d624c6
PE
2641 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2642 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2643 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2644
353032ce
PE
2645 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2646
2bccce07
PE
2647 * alloc.c (Fmake_string): Check for out-of-range init.
2648
0ac30604
SM
26492011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2650
2651 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2652
c195f2de
JD
26532011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2654
2655 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2656 xg_get_default_scrollbar_width.
2657
2658 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2659 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2660 (style_changed_cb): Call update_theme_scrollbar_width and call
2661 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2662 all frames (Bug#8505).
2663 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2664 Call gtk_window_set_resizable if HAVE_GTK3.
2665 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2666 and height if HAVE_GTK3 (Bug#8505).
2667 (scroll_bar_width_for_theme): New variable.
2668 (update_theme_scrollbar_width): New function.
2669 (xg_get_default_scrollbar_width): Move code to
2670 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2671 (xg_initialize): Call update_theme_scrollbar_width.
2672
2673 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2674
2675 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2676
e10ac9f1
MR
26772011-06-12 Martin Rudalics <rudalics@gmx.at>
2678
2679 * frame.c (make_frame): Call other_buffer_safely instead of
2680 other_buffer.
2681
2682 * window.c (temp_output_buffer_show): Call display_buffer with
2683 second argument Vtemp_buffer_show_specifiers and reset latter
2684 immediately after the call.
2685 (Vtemp_buffer_show_specifiers): New variable.
2686 (auto_window_vscroll_p, next_screen_context_lines)
2687 (Vscroll_preserve_screen_position): Remove leading asterisks from
2688 doc-strings.
2689
2d3c217e 26902011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2691
7b7f97e8 2692 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2693 * buffer.c (Qclone_number): Remove for now, as it's unused.
2694 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2695 (record_buffer): Remove unused local.
2696 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2697 (set_frame_buffer_list): Remove; unused.
2698 * frame.h (other_visible_frames): Remove decl.
2699 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2700 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2701 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2702 if HAVE_GPM.
2703 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2704 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2705 Define only if HAVE_GPM.
2706 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2707 (update_hints_inhibit): Remove; never set. All uses removed.
2708 * widgetprv.h (emacsFrameClassRec): Remove decl.
2709 * window.c (delete_deletable_window): Now returns void, since it
2710 wasn't returning anything.
2711 (compare_window_configurations): Remove unused locals.
2712 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2713 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2714 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2715 the same widths as pointers. This follows up on the 2011-05-06 patch.
2716 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2717 * xterm.h: Likewise.
2718 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2719
1384b89e
JB
27202011-06-12 Juanma Barranquero <lekktu@gmail.com>
2721
2722 * makefile.w32-in: Update dependencies.
2723 (LISP_H): Add lib/intprops.h.
2724
1100a63c
CY
27252011-06-11 Chong Yidong <cyd@stupidchicken.com>
2726
2727 * image.c (gif_load): Add animation frame delay to the metadata.
2728 (syms_of_image): Use DEFSYM. New symbol `delay'.
2729
6198ccd0
MR
27302011-06-11 Martin Rudalics <rudalics@gmx.at>
2731
2732 * window.c (delete_deletable_window): Re-add.
2733 (Fset_window_configuration): Rewrite to handle dead buffers and
2734 consequently deletable windows.
2735 (window_tree, Fwindow_tree): Remove. Supply functionality in
2736 window.el.
2737 (compare_window_configurations): Simplify code.
2738
b6e3633c
AS
27392011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2740
1ab0dee5
AS
2741 * image.c (imagemagick_load_image): Fix type mismatch.
2742 (Fimagemagick_types): Likewise.
2743
b6e3633c
AS
2744 * window.h (replace_buffer_in_windows): Declare.
2745
9397e56f
MR
27462011-06-11 Martin Rudalics <rudalics@gmx.at>
2747
2748 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2749 Qclone_number. Remove external declaration of Qdelete_window.
2750 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2751 code.
640c8776
SM
2752 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2753 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2754 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2755 buffer list implementation.
2756 (other_buffer_safely): New function.
2757 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2758 calls to replace_buffer_in_windows and
2759 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2760 if allowed.
2761 (record_buffer): Inhibit quitting and rewrite using quittable
2762 functions. Run Qbuffer_list_update_hook if allowed.
2763 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2764 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2765 Move switch-to-buffer to window.el.
9397e56f
MR
2766 (bury-buffer): Move to window.el.
2767 (Vbuffer_list_update_hook): New variable.
2768
2769 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2770 section.
2771
2772 * window.h (resize_frame_windows): Move up in code.
2773 (Fwindow_frame): Remove EXFUN.
2774 (replace_buffer_in_all_windows): Remove prototype.
2775 (replace_buffer_in_windows_safely): Add prototype.
2776
2777 * window.c: Declare Qdelete_window static again. Move down
2778 declaration of select_count.
2779 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2780 (Fother_window): Move to window.el.
2781 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2782 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2783 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2784 window.el.
2785 (replace_buffer_in_windows): Implement by calling
2786 Qreplace_buffer_in_windows.
2787 (replace_buffer_in_all_windows): Remove with some functionality
2788 moved into replace_buffer_in_windows_safely.
2789 (replace_buffer_in_windows_safely): New function.
2790 (select_window_norecord, select_frame_norecord): Move in front
2791 of run_window_configuration_change_hook. Remove now obsolete
2792 declarations.
640c8776
SM
2793 (Fset_window_buffer): Rewrite doc-string.
2794 Call Qrecord_window_buffer.
9397e56f
MR
2795 (keys_of_window): Move binding for other-window to window.el.
2796
b50691aa
CY
27972011-06-11 Chong Yidong <cyd@stupidchicken.com>
2798
2799 * dispextern.h (struct image): Replace data member, whose int_val
2800 and ptr_val fields were not used by anything, with a single
2801 lisp_val object.
2802
2803 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2804 (gif_clear_image, gif_load, imagemagick_load_image)
2805 (gs_clear_image, gs_load): Callers changed.
2806
3f754b86
PE
28072011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2808
cca69397
PE
2809 * buffer.h: Include <time.h>, for time_t.
2810 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2811
109e28d0
PE
2812 Fix minor problems found by static checking.
2813
60737f02
PE
2814 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2815
4b66faf3
PE
2816 Make identifiers static if they are not used in other modules.
2817 * data.c (Qcompiled_function, Qframe, Qvector):
2818 * image.c (QimageMagick, Qsvg):
2819 * minibuf.c (Qmetadata):
2820 * window.c (resize_window_check, resize_root_window): Now static.
2821 * window.h (resize_window_check, resize_root_window): Remove decls.
2822
109e28d0
PE
2823 * window.c (window_deletion_count, delete_deletable_window):
2824 Remove; unused.
46a4ce9e
PE
2825 (window_body_lines): Now static.
2826 (Fdelete_other_windows_internal): Mark vars as initialized.
2827 Make sure 'resize_failed' is initialized.
2828 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2829 (resize_window_apply): Remove unused local.
2830 * window.h (delete_deletable_window): Remove decl.
2831
109e28d0 2832 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2833 (imagemagick_load_image): Fix pointer signedness problem by changing
2834 last arg from unsigned char * to char *. All uses changed.
2835 Also, fix a local for similar reasons.
2836 Remove unused locals. Remove locals to avoid shadowing.
2837 (fn_rsvg_handle_free): Remove; unused.
2838 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2839 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2840
3f754b86
PE
2841 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2842
2547adb1
CY
28432011-06-10 Chong Yidong <cyd@stupidchicken.com>
2844
2845 * image.c (gif_load): Fix omitted cast error introduced by
2846 2011-06-06 change.
2847
2c8e37d4
MR
28482011-06-10 Martin Rudalics <rudalics@gmx.at>
2849
2850 * window.h (resize_proportionally, orig_total_lines)
2851 (orig_top_line): Remove from window structure.
2852 (set_window_height, set_window_width, change_window_heights)
2853 (Fdelete_window): Remove prototypes.
2854 (resize_frame_windows): Remove duplicate declaration.
2855
440a42e3
EZ
28562011-06-10 Eli Zaretskii <eliz@gnu.org>
2857
2858 * window.h (resize_frame_windows, resize_window_check)
2859 (delete_deletable_window, resize_root_window)
2860 (resize_frame_windows): Declare prototypes.
2861
2862 * window.c (resize_window_apply): Make definition be "static" to
2863 match the prototype.
2864
562dd5e9
MR
28652011-06-10 Martin Rudalics <rudalics@gmx.at>
2866
2867 * window.c: Remove declarations of Qwindow_size_fixed,
2868 window_min_size_1, window_min_size_2, window_min_size,
2869 size_window, window_fixed_size_p, enlarge_window, delete_window.
2870 Remove static from declaration of Qdelete_window, it's
2871 temporarily needed by Fbury_buffer.
2872 (replace_window): Don't assign orig_top_line and
2873 orig_total_lines.
2874 (Fdelete_window, delete_window): Remove. Window deletion is
2875 handled by window.el.
640c8776
SM
2876 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2877 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2878 (Fdelete_other_windows): Remove. Deleting other windows is
2879 handled by window.el.
2880 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2881 handled in window.el.
2882 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2883 Window minimum sizes are handled in window.el.
2884 (shrink_windows, size_window, set_window_height)
2885 (set_window_width, change_window_heights, window_height)
2886 (window_width, CURBEG, CURSIZE, enlarge_window)
2887 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2888 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2889 handled in window.el.
2890 (make_dummy_parent): Rename to make_parent_window and give it a
2891 second argument horflag.
2892 (make_window): Don't set resize_proportionally any more.
2893 (Fsplit_window): Remove. Windows are split in window.el.
2894 (save_restore_action, save_restore_orig_size)
2895 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2896 Resize mini windows in window.el.
2897 (grow_mini_window, shrink_mini_window): Implement by calling
2898 Qresize_root_window_vertically, resize_window_check and
2899 resize_window_apply.
640c8776
SM
2900 (saved_window, Fset_window_configuration, save_window_save):
2901 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2902 resize_proportionally.
2903 (window_min_height, window_min_width): Move to window.el.
2904 (keys_of_window): Move bindings for delete-other-windows,
2905 split-window, delete-window and enlarge-window to window.el.
2906
2907 * buffer.c: Temporarily extern Qdelete_window.
2908 (Fbury_buffer): Temporarily call Qdelete_window instead of
2909 Fdelete_window (Fbury_buffer will move to window.el soon).
2910
2911 * frame.c (set_menu_bar_lines_1): Remove code handling
2912 orig_top_line and orig_total_lines.
2913
2914 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2915 set_window_height but set heights directly.
2916 (change_frame_size_1): Use resize_frame_windows.
2917
2918 * xdisp.c (init_xdisp): Don't use set_window_height but set
2919 heights directly.
2920
640c8776
SM
2921 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2922 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2923 run_window_configuration_change_hook.
2924
2925 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2926 instead of change_window_heights and run
2927 run_window_configuration_change_hook.
2928
1a13852e
MR
29292011-06-09 Martin Rudalics <rudalics@gmx.at>
2930
2931 * window.c (replace_window): Rename second argument REPLACEMENT to
2932 NEW. New third argument SETFLAG. Rewrite.
2933 (delete_window, make_dummy_parent): Call replace_window with
2934 third argument 1.
2935 (window_list_1): Move down in code.
2936 (run_window_configuration_change_hook): Move set_buffer part
2937 before select_frame_norecord part in order to unwind correctly.
2938 Rename count1 to count.
2939 (recombine_windows, delete_deletable_window, resize_root_window)
2940 (Fdelete_other_windows_internal)
2941 (Frun_window_configuration_change_hook, make_parent_window)
2942 (resize_window_check, resize_window_apply, Fresize_window_apply)
2943 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2944 (Fdelete_window_internal, Fresize_mini_window_internal):
2945 New functions.
1a13852e
MR
2946 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2947
f3d1777e
MR
29482011-06-08 Martin Rudalics <rudalics@gmx.at>
2949
496e208e
MR
2950 * window.h (window): Add some new members to window structure -
2951 normal_lines, normal_cols, new_total, new_normal, clone_number,
2952 splits, nest, prev_buffers, next_buffers.
2953 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2954 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2955
f3d1777e
MR
2956 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2957 Remove.
496e208e
MR
2958 (make_dummy_parent): Set new members of windows structure.
2959 (make_window): Move down in code. Handle new members of window
2960 structure.
2961 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2962 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2963 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2964 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2965 (Fset_window_next_buffers, Fset_window_clone_number):
2966 New functions.
496e208e
MR
2967 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2968 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2969 Doc-string fixes.
2970 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2971 Argument WINDOW can be now internal window too.
2972 (Fwindow_use_time): Move up in code.
2973 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2974 Rewrite doc-string.
2975 (Fset_window_configuration, saved_window)
2976 (Fcurrent_window_configuration, save_window_save): Handle new
2977 members of window structure.
b9e809c2
MR
2978 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2979 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2980 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2981 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2982 Qget_mru_window, Qresize_root_window,
2983 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2984 Qauto_buffer_name; staticpro them.
f3d1777e 2985
abde8f8c
MR
29862011-06-07 Martin Rudalics <rudalics@gmx.at>
2987
2988 * window.c (Fwindow_total_size, Fwindow_left_column)
2989 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2990 (Fwindow_list_1): New functions.
2991 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2992 (Fwindow_width, Fscroll_left, Fscroll_right):
2993 Use window_body_cols instead of window_box_text_cols.
2994 (delete_window, Fset_window_configuration):
2995 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2996 (delete_all_subwindows): Take a window as argument and not a
2997 structure. Rewrite.
190b47e6
MR
2998 (window_loop): Remove handling of GET_LRU_WINDOW and
2999 GET_LARGEST_WINDOW.
3000 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3001
3002 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3003 window_box_text_cols. delete_all_subwindows now takes a
3004 Lisp_Object as argument.
abde8f8c 3005
640c8776
SM
3006 * indent.c (compute_motion, Fcompute_motion):
3007 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3008
fa8a67e6
MR
3009 * frame.c (delete_frame): Call delete_all_subwindows with root
3010 window as argument.
3011
a54e3482
DC
30122011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3013
3014 * fns.c (Fputhash): Document return value.
3015
60002bf5
CY
30162011-06-06 Chong Yidong <cyd@stupidchicken.com>
3017
3018 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3019
0c671da6 30202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3021
b862a52a 3022 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3023
be44ca6c
PE
3024 Check for overflow when converting integer to cons and back.
3025 * charset.c (Fdefine_charset_internal, Fdecode_char):
3026 Use cons_to_unsigned to catch overflow.
3027 (Fencode_char): Use INTEGER_TO_CONS.
3028 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3029 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3030 * data.c (long_to_cons, cons_to_long): Remove.
3031 (cons_to_unsigned, cons_to_signed): New functions.
3032 These signal an error for invalid or out-of-range values.
3033 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3034 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3035 * font.c (Ffont_variation_glyphs):
3036 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3037 * lisp.h: Include <intprops.h>.
3038 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3039 (cons_to_signed, cons_to_unsigned): New decls.
3040 (long_to_cons, cons_to_long): Remove decls.
3041 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3042 (Fprimitive_undo): Use CONS_TO_INTEGER.
3043 * xfns.c (Fx_window_property): Likewise.
3044 * xselect.c: Include <limits.h>.
3045 (x_own_selection, selection_data_to_lisp_data):
3046 Use INTEGER_TO_CONS.
3047 (x_handle_selection_request, x_handle_selection_clear)
3048 (x_get_foreign_selection, Fx_disown_selection_internal)
3049 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3050 (lisp_data_to_selection_data): Use cons_to_unsigned.
3051 (x_fill_property_data): Use cons_to_signed.
3052 Report values out of range.
3053
d1f3d2af
PE
3054 Check for buffer and string overflow more precisely.
3055 * buffer.h (BUF_BYTES_MAX): New macro.
3056 * lisp.h (STRING_BYTES_MAX): New macro.
3057 * alloc.c (Fmake_string):
3058 * character.c (string_escape_byte8):
3059 * coding.c (coding_alloc_by_realloc):
3060 * doprnt.c (doprnt):
3061 * editfns.c (Fformat):
3062 * eval.c (verror):
3063 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3064 since they may not be the same number.
3065 * editfns.c (Finsert_char):
3066 * fileio.c (Finsert_file_contents):
3067 Likewise for BUF_BYTES_MAX.
3068
dd52fcea
PE
3069 * image.c: Use ptrdiff_t, not int, for sizes.
3070 (slurp_file): Switch from int to ptrdiff_t.
3071 All uses changed.
3072 (slurp_file): Check that file size fits in both size_t (for
3073 malloc) and ptrdiff_t (for sanity and safety).
3074
7f9bbdbb
PE
3075 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3076 if b->modtime has its maximal value.
3077
dfe18f82
PE
3078 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3079
84acfcf0
PE
3080 Don't assume time_t can fit into int.
3081 * buffer.h (struct buffer.modtime): Now time_t, not int.
3082 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3083 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3084
ccd9a01a
PE
3085 Minor fixes for signed vs unsigned integers.
3086 * character.h (MAYBE_UNIFY_CHAR):
3087 * charset.c (maybe_unify_char):
3088 * keyboard.c (read_char, reorder_modifiers):
3089 XINT -> XFASTINT, since the integer must be nonnegative.
3090 * ftfont.c (ftfont_spec_pattern):
3091 * keymap.c (access_keymap, silly_event_symbol_error):
3092 XUINT -> XFASTINT, since the integer must be nonnegative.
3093 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3094 since it makes no difference and we prefer signed.
3095 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3096 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3097 nonnegative.
3098
d6d100dd
SM
30992011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3100
3101 * window.h (Fwindow_frame): Declare.
3102
2b6148e4
PE
31032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3104
3105 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3106 (SPARE_MEMORY): Always define.
3107 (LARGE_REQUEST): Remove.
3108 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3109
f230ecc9
MR
31102011-06-06 Martin Rudalics <rudalics@gmx.at>
3111
727e958e
MR
3112 * lisp.h: Move EXFUNS for Fframe_root_window,
3113 Fframe_first_window and Fset_frame_selected_window to window.h.
3114
3115 * window.h: Move EXFUNS for Fframe_root_window,
3116 Fframe_first_window and Fset_frame_selected_window here from
3117 lisp.h.
3118
3119 * frame.c (Fwindow_frame, Fframe_first_window)
3120 (Fframe_root_window, Fframe_selected_window)
3121 (Fset_frame_selected_window): Move to window.c.
3122 (Factive_minibuffer_window): Move to minibuf.c.
3123 (Fother_visible_frames_p): New function.
3124
3125 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3126
f230ecc9
MR
3127 * window.c (decode_window, decode_any_window): Move up in code.
3128 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3129 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3130 (Fwindow_buffer): Move up and rewrite doc-string.
3131 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3132 (Fwindow_prev): New functions.
727e958e
MR
3133 (Fwindow_frame): Move here from frame.c. Accept any window as
3134 argument.
3135 (Fframe_root_window, Fframe_first_window)
3136 (Fframe_selected_window): Move here from frame.c. Accept frame
3137 or arbitrary window as argument. Update doc-strings.
3138 (Fminibuffer_window): Move up in code.
3139 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3140 (Fset_frame_selected_window): Move here from frame.c.
3141 Marginal rewrite.
727e958e
MR
3142 (Fselected_window, select_window, Fselect_window): Move up in
3143 code. Minor doc-string fixes.
f230ecc9 3144
4d09bcf6
PE
31452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3146
3147 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3148 Do not assume that spare memory exists; that assumption is valid
3149 only if SYSTEM_MALLOC.
3150 (LARGE_REQUEST): New macro, so that the issue of large requests
3151 is separated from the issue of spare memory.
3152
810928a2
AS
31532011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3154
172418ad
AS
3155 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3156 format. (Bug#8806)
3157
43f862f7
AS
3158 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3159
810928a2
AS
3160 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3161 before statements.
3162
a059fe24
JD
31632011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3164
3165 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3166
3167 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3168
3169 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3170 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3171
989bf368
JB
31722011-06-05 Juanma Barranquero <lekktu@gmail.com>
3173
3174 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3175
4b80f674
CY
31762011-06-04 Chong Yidong <cyd@stupidchicken.com>
3177
3178 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3179 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3180 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3181 New error handlers.
4b80f674
CY
3182 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3183 Obey Vx_select_enable_clipboard_manager. Catch errors in
3184 x_clipboard_manager_save (Bug#8779).
3185 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3186 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3187
99a33b77 31882011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3189
3190 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3191
99a33b77 31922011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3193
3194 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3195 in the current matrix if keep_current_p is non-zero.
3196
8264569d
EZ
31972011-06-04 Eli Zaretskii <eliz@gnu.org>
3198
3199 * bidi.c (bidi_level_of_next_char): Fix last change.
3200
57f97249
EZ
32012011-06-03 Eli Zaretskii <eliz@gnu.org>
3202
fec2107c 3203 Support bidi reordering of text covered by display properties.
57f97249 3204
fec2107c
EZ
3205 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3206 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3207 (bidi_cache_search, bidi_cache_iterator_state)
3208 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3209 (bidi_level_of_next_char, bidi_move_to_visually_next):
3210 Support character positions inside a run of characters covered by a
fec2107c
EZ
3211 display string.
3212 (bidi_paragraph_init, bidi_resolve_explicit_1)
3213 (bidi_level_of_next_char): Call bidi_fetch_char and
3214 bidi_fetch_char_advance instead of FETCH_CHAR and
3215 FETCH_CHAR_ADVANCE.
3216 (bidi_init_it): Initialize new members.
3217 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3218 definitions.
3219 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3220 instead of using explicit *_CHAR codes.
d6d100dd
SM
3221 (bidi_resolve_explicit, bidi_resolve_weak):
3222 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3223 bidirectional text is supported only in multibyte buffers.
3224 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3225 it to initialize the frame_window_p member of struct bidi_it.
3226 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3227 (bidi_resolve_explicit, bidi_resolve_weak)
3228 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3229 bidi_it->nchars is non-positive.
3230 (bidi_level_of_next_char): Don't try to lookup the cache for the
3231 next/previous character if nothing is cached there yet, or if we
3232 were just reseat()'ed to a new position.
c40e2fb2 3233
0e14fe90
EZ
3234 * xdisp.c (set_cursor_from_row): Set start and stop points
3235 according to the row's direction when priming the loop that looks
3236 for the glyph on which to display cursor.
3237 (single_display_spec_intangible_p): Function deleted.
3238 (display_prop_intangible_p): Reimplement to call
3239 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3240 Accept 3 additional arguments needed by handle_display_spec.
3241 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3242 values: lists, `(when COND...)' forms, etc.
3243 (single_display_spec_string_p): Support property values that are
3244 lists with the argument STRING its top-level element.
3245 (display_prop_string_p): Fix the condition for processing a
3246 property that is a list to be consistent with handle_display_spec.
fec2107c 3247 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3248 last portion of handle_display_prop.
3249 (compute_display_string_pos): Accept additional argument
3250 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3251 value of a `display' property is a "replacing spec".
3252 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3253 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3254 the display property, but just return a value indicating whether
3255 the display property will replace the characters it covers.
3256 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3257 frame_window_p members of struct bidi_it.
d6d100dd
SM
3258 (compute_display_string_pos, compute_display_string_end):
3259 New functions.
fec2107c
EZ
3260 (push_it): Accept second argument POSITION, where pop_it should
3261 jump to continue iteration.
3262 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3263
fec2107c
EZ
3264 * keyboard.c (adjust_point_for_property): Adjust the call to
3265 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3266
3267 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3268 (bidi_init_it): Update prototypes.
3269 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3270 (compute_display_string_pos, compute_display_string_end):
3271 Declare prototypes.
fec2107c
EZ
3272 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3273 EMACS_INT.
fc6f18ce 3274
40087514 32752011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3276
57f53182
PE
3277 Malloc failure behavior now depends on size of allocation.
3278 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3279 * lisp.h: Change signatures accordingly.
3280 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3281 All callers changed. (Bug#8762)
3282
3283 * gnutls.c: Use Emacs's memory allocators.
3284 Without this change, the gnutls library would invoke malloc etc.
3285 directly, which causes problems on non-SYNC_INPUT hosts, and which
3286 runs afoul of improving memory_full behavior. (Bug#8761)
3287 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3288 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3289 xfree instead of the default malloc, realloc, free.
3290 (Fgnutls_boot): No need to check for memory allocation failure,
3291 since xmalloc does that for us.
3292
ac32cd99 3293 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3294 * category.c (hash_get_category_set):
3295 * ccl.c (ccl_driver):
3296 * charset.c (Fdefine_charset_internal):
3297 * charset.h (struct charset.hash_index):
3298 * composite.c (get_composition_id, gstring_lookup_cache)
3299 (composition_gstring_put_cache):
3300 * composite.h (struct composition.hash_index):
3301 * dispextern.h (struct image.hash):
3302 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3303 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3304 (hashfn_equal, hashfn_user_defined, make_hash_table)
3305 (maybe_resize_hash_table, hash_lookup, hash_put)
3306 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3307 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3308 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3309 * image.c (make_image, search_image_cache, lookup_image)
3310 (xpm_put_color_table_h):
3311 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3312 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3313 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3314 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3315 * alloc.c (allocate_vectorlike):
3316 Check for overflow in vector size calculations.
3317 * ccl.c (ccl_driver):
3318 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3319 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3320 need to be updated by these changes.
40087514
PE
3321 * fns.c (make_hash_table, maybe_resize_hash_table):
3322 Check for integer overflow with large hash tables.
0de4bb68
PE
3323 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3324 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3325 (SXHASH_REDUCE): New macro.
3326 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3327 Use it instead of discarding useful hash info with large hash values.
3328 (sxhash_float): New function.
3329 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3330 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3331 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3332 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3333 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3334 Adjust signatures to match updated version of code.
3335 (consing_since_gc): Now EMACS_INT, since a single hash table can
3336 use more than INT_MAX bytes.
3337
698d32e2
DN
33382011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3339
3340 Make it possible to build with GCC-4.6+ -O2 -flto.
3341
3342 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3343
fd6fa53f
SM
33442011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3345
3346 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3347 Call minibuffer-inactive-mode.
3348
864db017
JB
33492011-05-31 Juanma Barranquero <lekktu@gmail.com>
3350
3351 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3352 Update dependencies.
3353
2ad0baf4
DN
33542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3355
3356 * data.c (init_data): Remove code for UTS, this system is not
3357 supported anymore.
3358
4fcc2638
DN
33592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3360
3361 Don't force ./temacs to start in terminal mode.
3362
3363 * frame.c (make_initial_frame): Initialize faces in all cases, not
3364 only when CANNOT_DUMP is defined.
3365 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3366
c56e0fd5
DN
33672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3368
3369 * dispnew.c (add_window_display_history): Use const for the string
3370 pointer. Remove declaration, not needed.
3371
333d54da 33722011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3373
55d4c1b2 3374 Use 'inline', not 'INLINE'.
333d54da 3375 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3376 * alloc.c, fontset.c (INLINE): Remove.
3377 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3378 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3379 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3380 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3381 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3382
738db178
DN
33832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3384
3385 Make it possible to run ./temacs.
3386
3387 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3388 syms_of_callproc does the same thing. Remove test for
3389 "initialized", do it in the caller.
3390 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3391
620c53a6
SM
33922011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3393
3394 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3395 (read_minibuf): Use get_minibuffer.
3396 (syms_of_minibuf): Use DEFSYM.
3397 (Qmetadata): New var.
3398 * data.c (Qbuffer): Don't make it static.
3399 (syms_of_data): Use DEFSYM.
3400
e003a292
PE
34012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3404 (CCL_CODE_MIN): New macro.
3405
ed008a6d
PE
34062011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3407
3687c2ef
PE
3408 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3409
ed008a6d
PE
3410 * eval.c (Qdebug): Now static.
3411 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3412 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3413 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3414
d66c4c7c
CY
34152011-05-29 Chong Yidong <cyd@stupidchicken.com>
3416
3417 * image.c: Various fixes to ImageMagick code comments.
3418 (Fimagemagick_types): Doc fix.
3419
5fbc2025
PE
34202011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3421
0196f88a
PE
3422 Minor fixes prompted by GCC 4.6.0 warnings.
3423
3424 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3425
5fbc2025
PE
3426 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3427 (x_clipboard_manager_save_all): Move extern decl to ...
3428 * xterm.h: ... here, so that it can be checked for consistency.
3429
1dd3c2d9
CY
34302011-05-29 Chong Yidong <cyd@stupidchicken.com>
3431
3432 * xselect.c (x_clipboard_manager_save_frame)
3433 (x_clipboard_manager_save_all): New functions.
3434 (Fx_clipboard_manager_save): Lisp function deleted.
3435
3436 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3437 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3438
3439 * xterm.h: Update prototype.
3440
5ba6571d
WX
34412011-05-28 William Xu <william.xwl@gmail.com>
3442
3443 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3444 exiting (Bug#8239).
3445
3eaff834
JM
34462011-05-28 Jim Meyering <meyering@redhat.com>
3447
e1900994 3448 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3449 * fns.c (to_uchar): Define.
3450 (crypto_hash_function): Use it to convert some newly-signed
3451 variables to unsigned, to avoid sign-extension bugs. For example,
3452 without this change, (md5 "truc") would evaluate to
3453 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3454 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3455 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3456
0f6990a7
PE
34572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3458
3459 Integer overflow fixes.
c8a9ca5a 3460
08686060
PE
3461 * dbusbind.c: Serial number integer overflow fixes.
3462 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3463 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3464 to hold a serial number that is too large for a fixnum.
3465 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3466 Check for serial numbers out of range. Decode any serial number
59568bf0 3467 that was so large that it became a float. (Bug#8722)
08686060 3468
2d1fc3c7
PE
3469 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3470 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3471 Use XFASTINT rather than XUINT when numbers are nonnegative.
3472 (xd_append_arg, Fdbus_method_return_internal):
3473 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3474 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3475 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3476 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3477 (Bug#8722)
2d1fc3c7 3478
c8a9ca5a
PE
3479 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3480
519e1d69
PE
3481 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3482
30569699
PE
3483 ccl: add integer overflow checks
3484 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3485 (IN_INT_RANGE): New macros.
3486 (ccl_driver): Use them to check for integer overflow when
3487 decoding a CCL program. Many of the new checks are whether XINT (x)
3488 fits in int; it doesn't always, on 64-bit hosts. The new version
3489 doesn't catch all possible integer overflows, but it's an
847044ea 3490 improvement. (Bug#8719)
30569699 3491
c11285dc
PE
3492 * alloc.c (make_event_array): Use XINT, not XUINT.
3493 There's no need for unsigned here.
3494
fdccd48e
PE
3495 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3496 This follows up to the 2011-05-06 change that substituted uintptr_t
3497 for EMACS_INT. This case wasn't caught back then.
3498
37910ab2
PE
3499 Rework Fformat to avoid integer overflow issues.
3500 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3501 now (part of C89). Include <verify.h>.
3502 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3503 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3504 (Fformat): Avoid the prepass trying to compute sizes; it was only
3505 approximate and thus did not catch overflow reliably. Instead, walk
3506 through the format just once, formatting and computing sizes as we go,
3507 checking for integer overflow at every step, and allocating a larger
3508 buffer as needed. Keep track separately whether the format is
3509 multibyte. Keep only the most-recently calculated precision, rather
3510 than them all. Record whether each argument has been converted to
3511 string. Use EMACS_INT, not int, for byte and char and arg counts.
3512 Support field widths and precisions larger than INT_MAX. Avoid
3513 sprintf's undefined behavior with conversion specifications such as %#d
3514 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3515 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3516 formatting out-of-range floating point numbers with int
9173deec 3517 formats. (Bug#8668)
37910ab2 3518
2e6578fb
PE
3519 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3520
0ae6bdee
PE
3521 * data.c: Avoid integer truncation in expressions involving floats.
3522 * data.c: Include <intprops.h>.
3523 (arith_driver): When there's an integer overflow in an expression
3524 involving floating point, convert the integers to floating point
3525 so that the resulting value does not suffer from catastrophic
3526 integer truncation. For example, on a 64-bit host (* 4
3527 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3528 Do not rely on undefined behavior after integer overflow.
3529
de883a70
PE
3530 merge count_size_as_multibyte, parse_str_to_multibyte
3531 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3532 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3533 Check for integer overflow.
3534 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3535 since it's now a duplicate of the other. This is more of
3536 a character than a buffer op, so better that it's in character.c.
3537 * fns.c, print.c: Adjust to above changes.
3538
2ff916cb
PE
35392011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3540
3541 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3542
f1b54466
PE
35432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3544
fb1ac845
PE
3545 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3546 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3547 (x_clipboard_manager_save): Now static.
3548 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3549
f1b54466
PE
3550 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3551 (crypto_hash_function): Now static.
3552 Fix pointer signedness problems. Avoid unnecessary initializations.
3553
a9f737ee
CY
35542011-05-27 Chong Yidong <cyd@stupidchicken.com>
3555
3556 * termhooks.h (Vselection_alist): Make it terminal-local.
3557
3558 * terminal.c (create_terminal): Initialize it.
3559
3560 * xselect.c: Support for clipboard managers.
3561 (Vselection_alist): Move to termhooks.h as terminal-local var.
3562 (LOCAL_SELECTION): New macro.
3563 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3564 (symbol_to_x_atom): Remove gratuitous arg.
3565 (x_handle_selection_request, lisp_data_to_selection_data)
3566 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3567 (x_own_selection, x_get_local_selection, x_convert_selection):
3568 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3569 (some_frame_on_display): Delete unused function.
3570 (Fx_own_selection_internal, Fx_get_selection_internal)
3571 (Fx_disown_selection_internal, Fx_selection_owner_p)
3572 (Fx_selection_exists_p): New optional frame arg.
3573 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3574 (x_handle_selection_clear): Don't treat other terminals with the
3575 same keyboard specially. Use the terminal-local Vselection_alist.
3576 (x_clear_frame_selections): Use Frun_hook_with_args.
3577
3578 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3579
3580 * xterm.h: Add support for those atoms.
3581
e067f0c1
CY
35822011-05-26 Chong Yidong <cyd@stupidchicken.com>
3583
3584 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3585 (converted_selections, conversion_fail_tag): New global variables.
3586 (x_selection_request_lisp_error): Free the above.
3587 (x_get_local_selection): Remove unnecessary code.
3588 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3589 of converted selections stored in converted_selections.
3590 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3591 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3592 (x_convert_selection): New function.
3593 (x_handle_selection_event): Simplify.
3594 (x_get_foreign_selection): Don't ignore incoming requests while
3595 waiting for an answer; this will fail when we implement
3596 SAVE_TARGETS, and seems unnecessary anyway.
3597 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3598 (Vx_sent_selection_functions): Doc fix.
3599
0f4aebc0
LL
36002011-05-26 Leo Liu <sdl.web@gmail.com>
3601
3602 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3603
e61124cd
YM
36042011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3605
3606 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3607
3608 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3609 for fringe update if it has periodic bitmap.
ac389d0c 3610 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3611 and fringe_bitmap_periodic_p.
3612
3613 * fringe.c (get_fringe_bitmap_data): New function.
3614 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3615 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3616 row. Mark glyph row for fringe update if periodicity changed.
3617
3618 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3619 for fringe update unless it has periodic bitmap.
3620
f16d9837
KH
36212011-05-25 Kenichi Handa <handa@m17n.org>
3622
3623 * xdisp.c (get_next_display_element): Set correct it->face_id for
3624 a static composition.
3625
e1b90ef6
LL
36262011-05-24 Leo Liu <sdl.web@gmail.com>
3627
3628 * deps.mk (fns.o):
3629 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3630
3631 * fns.c (crypto_hash_function, Fsha1): New function.
3632 (Fmd5): Use crypto_hash_function.
3633 (syms_of_fns): Add Ssha1.
3634
7400048f
PE
36352011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3636
3637 * gnutls.c: Remove unused macros.
3638 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3639 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3640 Remove macros that are defined and never used.
3641 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3642
abb71cf4
CY
36432011-05-22 Chong Yidong <cyd@stupidchicken.com>
3644
3645 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3646 (Fx_get_selection_internal): Minor cleanup.
3647 (Fx_own_selection_internal): Rename arguments for consistency with
3648 select.el.
3649
6307db39
PE
36502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3651
3652 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3653
f3d4e0a4
CY
36542011-05-22 Chong Yidong <cyd@stupidchicken.com>
3655
3656 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3657
4d8ade89
YM
36582011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3659
3660 * dispnew.c (scrolling_window): Don't exclude the case that the
3661 last enabled row in the desired matrix touches the bottom boundary.
3662
32078c8d
GM
36632011-05-21 Glenn Morris <rgm@gnu.org>
3664
3665 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3666 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3667 and add some more files.
32078c8d 3668
7285dc67
EZ
36692011-05-20 Eli Zaretskii <eliz@gnu.org>
3670
3671 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3672 report_file_error introduced by the change from 2011-05-07.
3673
89d1bd22
PE
36742011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3675
3676 * systime.h (Time): Define only if emacs is defined.
3677 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3678 where the include path doesn't have X11/X.h by default. See
3679 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3680
e23640bb 36812011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3682
3683 * composite.c (find_automatic_composition): Fix previous change.
3684
b9704ad9
GM
36852011-05-20 Glenn Morris <rgm@gnu.org>
3686
3687 * lisp.mk: New file, split from Makefile.in.
3688 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3689 (shortlisp): Remove.
3690 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3691
4a720484
GM
36922011-05-19 Glenn Morris <rgm@gnu.org>
3693
3694 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3695 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3696 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3697 (lisp): Set the order to that of loadup.el.
3698 (shortlisp): Make it a copy of $lisp.
3699 (SOME_MACHINE_LISP): Remove.
3700 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3701 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3702
a28d4396
KH
37032011-05-18 Kenichi Handa <handa@m17n.org>
3704
3705 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3706 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3707 (find_automatic_composition): Mostly rewrite for efficiency.
3708
a2b1fa8e
JB
37092011-05-18 Juanma Barranquero <lekktu@gmail.com>
3710
3711 * makefile.w32-in: Update dependencies.
3712
8e1f5610
CS
37132011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3714
3715 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3716 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3717
7025ee00 37182011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3719
cdfa6eab
PE
3720 Fix some integer overflow issues, such as string length overflow.
3721
06d6db33
PE
3722 * insdel.c (count_size_as_multibyte): Check for string overflow.
3723
2b4560a8
PE
3724 * character.c (lisp_string_width): Check for string overflow.
3725 Use EMACS_INT, not int, for string indexes and lengths; in
3726 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3727 the resulting string length overflows an EMACS_INT; instead,
3728 report a string overflow if no precision given. When checking for
3729 precision exhaustion, use a check that cannot possibly have
3730 integer overflow. (Bug#8675)
3731 * character.h (lisp_string_width): Adjust to new signature.
3732
cb93f9be
PE
3733 * alloc.c (string_overflow): New function.
3734 (Fmake_string): Use it. This doesn't change behavior, but saves
3735 a few bytes and will simplify future changes.
3736 * character.c (string_escape_byte8): Likewise.
3737 * lisp.h (string_overflow): New decl.
3738
1a1f3366
PE
3739 Fixups, following up to the user-interface timestamp change.
3740 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3741 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3742 * msdos.c (mouse_get_pos): Likewise.
3743 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3744 * w32gui.h (Time): Define by including "systime.h" rather than by
3745 declaring it ourselves. (Bug#8664)
3746
d4e3e4d3
PE
3747 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3748 * image.c (clear_image_cache): Likewise.
3749
f6a24d19
PE
3750 * term.c (term_mouse_position): Don't assume time_t wraparound.
3751
08dc5ae6
PE
3752 Be more systematic about user-interface timestamps.
3753 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3754 and sometimes 'EMACS_UINT', to represent these timestamps.
3755 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3756 This makes the code easier to follow, and makes it easier to catch
3757 integer overflow bugs such as Bug#8664.
3758 * frame.c (Fmouse_position, Fmouse_pixel_position):
3759 Use Time, not unsigned long, for user-interface timestamps.
3760 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3761 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3762 * keyboard.h (last_event_timestamp): Likewise.
3763 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3764 * menu.h (xmenu_show): Likewise.
3765 * term.c (term_mouse_position): Likewise.
3766 * termhooks.h (struct input_event.timestamp): Likewise.
3767 (struct terminal.mouse_position_hook): Likewise.
3768 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3769 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3770 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3771 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3772 what it was before.
3773 * menu.h, termhooks.h: Include "systime.h", for Time.
3774
8e55734a
PE
3775 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3776 Don't assume that the difference between two unsigned long values
3777 can fit into an integer. At this point, we know button_down_time
3778 <= event->timestamp, so the difference must be nonnegative, so
3779 there's no need to cast the result if double-click-time is
3780 nonnegative, as it should be; check that it's nonnegative, just in
3781 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3782 apart (about 25 days). (Bug#8664)
8e55734a 3783
841f1b75 3784 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3785 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3786
3e26f69c
PE
3787 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3788 that always fit in int. Use a sentinel instead of a counter, to
3789 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3790 * frame.h (struct frame): Use int for menu_bar_items_used
3791 instead of EMACS_INT, since it always fits in int.
3e26f69c 3792
5cc152c0
PE
3793 * menu.c (grow_menu_items): Check for int overflow.
3794
d89eb65e
PE
3795 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3796
5235bd3e
PE
3797 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3798 Before, the code was not consistent. These values cannot exceed
3799 2**31 - 1 so there's no need to make them unsigned.
3800 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3801 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3802 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3803 as modifiers.
3804 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3805
bc827e23
PE
3806 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3807 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3808 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3809 presumably because the widths might not match.
3810
78eb494e
PE
3811 * window.c (size_window): Avoid needless test at loop start.
3812
04f2d78b
CB
38132011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3814
3815 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3816
d2fc7e3d 38172011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3818
3819 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3820
d2fc7e3d 38212011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3822
3823 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3824 `width' to `bar_area_x' and `bar_area_width', respectively.
3825 (x_scroll_run): Take account of fringe background extension.
3826
04f2d78b
CB
3827 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3828 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3829 `bar_area_width', respectively.
3830 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3831 background extension.
3832
79b70037
GM
38332011-05-10 Jim Meyering <meyering@redhat.com>
3834
3835 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3836
2f142cc5
JB
38372011-05-10 Juanma Barranquero <lekktu@gmail.com>
3838
3839 * image.c (Finit_image_library): Return t for built-in image types,
3840 like pbm and xbm. (Bug#8640)
3841
57679c86
AS
38422011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3843
3844 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3845
888c9e86
EZ
38462011-05-07 Eli Zaretskii <eliz@gnu.org>
3847
b0512a1d
EZ
3848 * w32console.c (Fset_screen_color): Doc fix.
3849 (Fget_screen_color): New function.
3850 (syms_of_ntterm): Defsubr it.
3851
7285dc67
EZ
3852 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3853 unlink the temporary file if Fcall_process didn't create it in the
3854 first place.
3855 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3856 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3857 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3858 cue to call_process_cleanup not to close that handle.
3859
4d3fcc8e
BK
38602011-05-07 Ben Key <bkey76@gmail.com>
3861
3862 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3863 one of two shell specific rules, either bootstrap-temacs-CMD or
3864 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3865 to the previous implementation of the bootstrap-temacs rule.
3866 The bootstrap-temacs-CMD rule is similar to the previous
3867 implementation of the bootstrap-temacs rule except that it
3868 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3869 variable.
3870
3871 These changes, along with some changes to nt/configure.bat,
3872 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3873 earlier fix to add support for --cflags and --ldflags options
3874 that include quotes so that it works whether make uses cmd or
3875 sh as the shell.
3876
b4289b64
MA
38772011-05-06 Michael Albinus <michael.albinus@gmx.de>
3878
3879 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3880 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3881 is a constant.
3882 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3883 a string. Handle both cases.
3884 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3885 (Fdbus_register_method): Use Qinvalid_function.
3886
af4c0e28
JB
38872011-05-06 Juanma Barranquero <lekktu@gmail.com>
3888
3889 * makefile.w32-in: Update dependencies.
3890 (LISP_H): Add inttypes.h and stdin.h.
3891 (PROCESS_H): Add unistd.h.
3892
c51453d9
EZ
38932011-05-06 Eli Zaretskii <eliz@gnu.org>
3894
3895 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3896 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3897
8ff0ac3c 38982011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3899
4c4b566b
PE
3900 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3901
aab2b9b5
PE
3902 * term.c (vfatal): Remove stray call to va_end.
3903 It's not needed and the C Standard doesn't allow it here anyway.
3904
c378da0b
PE
3905 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3906 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3907
288b08c7
PE
3908 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3909 bytes.
3910
e3601888
PE
3911 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3912
db6c0e74
PE
3913 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3914
dd5963ea
PE
3915 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3916
88c9450f
PE
3917 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3918
2f9442b8
PE
3919 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3920
c032b5f8
PE
3921 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3922 * charset.c (Fdefine_charset_internal): Don't initialize
3923 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3924 32-bit int (Bug#8600).
a108c10b
PE
3925
3926 * lread.c (read_integer): Be more consistent with string-to-number.
3927 Use string_to_number to do the actual conversion; this avoids
3928 rounding errors and fixes some other screwups. Without this fix,
3929 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3930 (digit_to_number): Move earlier, for benefit of read_integer.
3931 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3932 not a digit in any supported base. (Bug#8602)
a108c10b 3933
ad5f9eea
PE
3934 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3935
aec1708a
PE
3936 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3937 to match comment at start of function. This also removes a
3938 GCC warning about overflow in a 32+64-bit port.
3939
47be4ab5
PE
3940 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3941
371cac43
PE
3942 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3943 Reported by Stefan Monnier in
3944 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3945 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3946 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3947
d01a7826
PE
3948 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3949 (EMACS_UINTPTR): Likewise, with uintptr_t.
3950
7fd47d5c
PE
3951 * lisp.h: Prefer 64-bit EMACS_INT if available.
3952 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3953 on 32-bit hosts that have 64-bit int, so that they can access
3954 large files.
122b0c86
PE
3955 However, temporarily disable this change unless the temporary
3956 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3957
8727937b
PE
3958 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3959
8ac068ac
PE
3960 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3961 This removes an assumption that EMACS_INT and long are the same
3962 width as pointers. The assumption is true for Emacs porting targets
3963 now, but we want to make other targets possible.
3964 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3965 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3966 In the rest of the code, change types of integers that hold casted
3967 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3968 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3969 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3970 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3971 No need to cast type when ORing.
3972 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3973 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3974 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3975 assume EMACS_INT is the same width as char *.
3976 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3977 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3978 Remove no-longer-needed casts.
3979 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3980 (xg_tool_bar_help_callback, xg_make_tool_item):
3981 Use EMACS_INTPTR to hold an integer
3982 that will be cast to void *; this can avoid a GCC warning
3983 if EMACS_INT is not the same width as void *.
3984 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3985 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3986 (current_message_1, set_message_1):
3987 Use a local to convert to proper width without a cast.
3988 * xmenu.c (dialog_selection_callback): Likewise.
3989
ede49d71
PE
3990 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3991 Also, don't assume VALBITS / RAND_BITS is less than 5,
3992 and don't rely on undefined behavior when shifting a 1 left into
3993 the sign bit.
3994 * lisp.h (get_random): Change signature to match.
3995
2f30ecd0
PE
3996 * lread.c (hash_string): Use size_t, not int, for hash computation.
3997 Normally we prefer signed values; but hashing is special, because
3998 it's better to use unsigned division on hash table sizes so that
3999 the remainder is nonnegative. Also, size_t is the natural width
4000 for hashing into memory. The previous code used 'int', which doesn't
4001 retain enough info to hash well into very large tables.
4002 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4003
2a866e7b
PE
4004 * dbusbind.c: Don't possibly lose pointer info when converting.
4005 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4006 Use XPNTR rather than XHASH, so that the high-order bits of
4007 the pointer aren't lost when converting through void *.
4008
51639eac
PE
4009 * eval.c (Fautoload): Don't double-shift a pointer.
4010
92394119
PE
4011 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4012
dbdb9a7c
JB
40132011-05-06 Juanma Barranquero <lekktu@gmail.com>
4014
4015 * gnutls.c (DEF_GNUTLS_FN):
4016 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4017
db7a0b4f
AS
40182011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4019
4020 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4021 marker. (Bug#8610)
4022
f7ff1b0f 40232011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4024
4025 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4026 New version that can reserve upto 2GB of heap space.
4027
f7ff1b0f 40282011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4029
4030 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4031
639c109b
TZ
40322011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4033
4034 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4035 `gnutls_certificate_set_x509_key_file'.
4036
d2127135
JB
40372011-05-05 Juanma Barranquero <lekktu@gmail.com>
4038
4039 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4040 Update dependencies.
4041
e968f4f3
JB
40422011-05-04 Juanma Barranquero <lekktu@gmail.com>
4043
4044 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4045 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4046 Remove unused parameter `fildes'.
4047 * process.c (read_process_output, send_process): Don't pass it.
4048
84d358f0
JB
40492011-05-04 Juanma Barranquero <lekktu@gmail.com>
4050
4051 Fix previous change: the library cache is defined in w32.c.
4052 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4053 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4054
0898ca10
JB
40552011-05-04 Juanma Barranquero <lekktu@gmail.com>
4056
4057 Implement dynamic loading of GnuTLS on Windows.
4058
4059 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4060 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4061 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4062 Declare.
4063
4064 * gnutls.c (Qgnutls_dll): Define.
4065 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4066 (gnutls_*): Declare function pointers.
4067 (init_gnutls_functions): New function to initialize function pointers.
4068 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4069 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4070 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4071 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4072 (emacs_gnutls_write, emacs_gnutls_read)
4073 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4074 (Fgnutls_available_p): New function.
4075 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4076 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4077 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4078
4079 * image.c: Include w32.h.
4080 (Vimage_type_cache): Delete.
4081 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4082 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4083 (w32_delayed_load): Move to w32.c.
4084
4085 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4086
4087 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4088 (w32_delayed_load): Move from image.c. When loading a library, record
4089 its filename in the :loaded-from property of the library id.
4090 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4091 Initialize and staticpro them.
4092 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4093
4094 * process.c: Include lisp.h before w32.h, not after.
4095 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4096 instead of gnutls_record_check_pending.
4097
4098 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4099
ff4de4aa
TZ
41002011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4101
4102 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4103 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4104 as passed in.
4105
abe95abb
JD
41062011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4107
4108 * xterm.c (x_set_frame_alpha): Do not set property on anything
4109 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4110
e16e55d4
JB
41112011-05-02 Juanma Barranquero <lekktu@gmail.com>
4112
4113 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4114
bafcf6a5
JB
41152011-05-02 Juanma Barranquero <lekktu@gmail.com>
4116
4117 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4118 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4119 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4120 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4121 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4122 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4123 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4124 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4125 (Qgnutls_bootprop_callbacks_verify): Make static.
4126
e7a6747f
AS
41272011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4128
19ed11ba
AS
4129 * callproc.c: Indentation fixup.
4130
e7a6747f 4131 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4132 (wait_for_termination, interruptible_wait_for_termination):
4133 Move after wait_for_termination_1.
e7a6747f 4134
1ef14cb4
LMI
41352011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4136
4137 * sysdep.c (interruptible_wait_for_termination): New function
4138 which is like wait_for_termination, but allows keyboard
4139 interruptions.
4140
4141 * callproc.c (Fcall_process): Add (:file "file") as an option for
4142 the STDOUT buffer.
4143 (Fcall_process_region): Ditto.
4144
330d880c
EZ
41452011-04-30 Eli Zaretskii <eliz@gnu.org>
4146
8db90b73
EZ
4147 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4148 rather than `XVECTOR (FOO)->size'.
4149
330d880c
EZ
4150 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4151 inttypes.h, as a gnulib replacement is used if it not available in
4152 system headers.
4153
15cbd324
EZ
41542011-04-21 Eli Zaretskii <eliz@gnu.org>
4155
4156 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4157 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4158 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4159
4160 * coding.c (coding_alloc_by_realloc): Error out if destination
4161 will grow beyond MOST_POSITIVE_FIXNUM.
4162 (decode_coding_emacs_mule): Abort if there isn't enough place in
4163 charbuf for the composition carryover bytes. Reserve an extra
4164 space for up to 2 characters produced in a loop.
4165 (decode_coding_iso_2022): Abort if there isn't enough place in
4166 charbuf for the composition carryover bytes.
4167
41682011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4169
ae940cca
EZ
4170 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4171 aborting when %lld or %lll format is passed.
4172 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4173 %llo or %llx format is passed. (Bug#8545)
4174
03ab8921
EZ
4175 * window.c (window_scroll_line_based): Use a marker instead of
4176 simple variables to record original value of point. (Bug#7952)
4177
afda1437
EZ
4178 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4179 produced by %s or %c overflows available buffer space. (Bug#8545)
4180
f76dee0c
PE
41812011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4182
4183 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4184 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4185
fdc5744d
JB
41862011-04-28 Juanma Barranquero <lekktu@gmail.com>
4187
4188 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4189
638f053a
JB
41902011-04-28 Juanma Barranquero <lekktu@gmail.com>
4191
4192 * keyboard.c (Qdelayed_warnings_hook): Define.
4193 (command_loop_1): Run `delayed-warnings-hook'
4194 if Vdelayed_warnings_list is non-nil.
4195 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4196 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4197
d178f871
EZ
41982011-04-28 Eli Zaretskii <eliz@gnu.org>
4199
4200 * doprnt.c (doprnt): Don't return value smaller than the buffer
4201 size if the message was truncated. (Bug#8545).
4202
b124fd93
JB
42032011-04-28 Juanma Barranquero <lekktu@gmail.com>
4204
4205 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4206 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4207
e810457d
PE
42082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4209
4210 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4211
ea51cceb
JB
42122011-04-27 Juanma Barranquero <lekktu@gmail.com>
4213
4214 * makefile.w32-in: Update dependencies.
4215
94dcfacf
EZ
42162011-04-27 Eli Zaretskii <eliz@gnu.org>
4217
4218 Improve `doprnt' and its usage. (Bug#8545)
4219 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4220 `format_end'. Remove support for %l as a conversion specifier.
4221 Don't use xrealloc. Improve diagnostics when the %l size modifier
4222 is used. Update the commentary.
4223
4224 * eval.c (verror): Simplify calculation of size_t.
4225
4226 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4227 messages.
4228
f61f41d7
PE
42292011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4230
4231 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4232 change.
4233
96fb4434
PE
42342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4235
4236 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4237 This makes this file independent of the recent pseudovector change.
4238
671875da 42392011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4240
69e9b5a3
PE
4241 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4242
b5f869a7 4243 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4244 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4245 Remove unused local.
c8926152 4246 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4247
841a1577 4248 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4249 GCC 4.6.0 optimizes based on type-based alias analysis.
4250 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4251 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4252 != &v->size, and therefore "v->size = 1; b->size = 2; return
4253 v->size;" must therefore return 1. This assumption is incorrect
4254 for Emacs, since it type-puns struct Lisp_Vector * with many other
4255 types. To fix this problem, this patch adds a new type struct
f904488f 4256 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4257 and pseudovectors, and helps optimizing compilers not get fooled
4258 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4259 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4260 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4261 the size member.
eab3844f
PE
4262 (XSETPVECTYPE): Rewrite in terms of new macro.
4263 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4264 This is a bit clearer, and further avoids the possibility of
4265 undesirable aliasing.
4266 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4267 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4268 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4269 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4270 (ASIZE): Now uses header.size rather than size.
4271 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4272 to avoid the hassle of writing XVECTOR (foo)->header.size.
4273 (struct vectorlike_header): New type.
eab3844f
PE
4274 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4275 object, to help avoid aliasing.
4276 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4277 (SUBRP): Likewise, since Lisp_Subr is a special case.
4278 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4279 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4280 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4281 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4282 changed to be "header.size" and "header.next".
4283 * buffer.h (struct buffer): Likewise.
4284 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4285 * frame.h (struct frame): Likewise.
4286 * process.h (struct Lisp_Process): Likewise.
4287 * termhooks.h (struct terminal): Likewise.
4288 * window.c (struct save_window_data, struct saved_window): Likewise.
4289 * window.h (struct window): Likewise.
4290 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4291 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4292 * buffer.c (init_buffer_once): Likewise.
4293 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4294 special case.
4295 * process.c (Fformat_network_address): Use local var for size,
4296 for brevity.
4297
0df1eac5
PE
4298 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4299
847ab9d1 4300 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4301 * data.c (atof): Remove decl; no longer used or needed.
4302 (digit_to_number): Move to lread.c.
4303 (Fstring_to_number): Use new string_to_number function, to be
4304 consistent with how the Lisp reader treats infinities and NaNs.
4305 Do not assume that floating-point numbers represent EMACS_INT
4306 without losing information; this is not true on most 64-bit hosts.
4307 Avoid double-rounding errors, by insisting on integers when
4308 parsing non-base-10 numbers, as the documentation specifies.
4309 * lisp.h (string_to_number): New decl, replacing ...
4310 (isfloat_string): Remove.
bc0a5c13 4311 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4312 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4313 appears to have been a coding error. Similarly, do not accept
4314 strings like +-1e0 as floating point numbers. Do not report
4315 overflow for integer overflows unless the base is not 10 which
4316 means we have no simple and reliable way to continue.
4317 Break out the floating-point parsing into a new
4318 function string_to_number, so that Fstring_to_number parses
4319 floating point numbers consistently with the Lisp reader.
04f2d78b 4320 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4321 (E_CHAR, EXP_INT): Remove, replacing with ...
4322 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4323 (string_to_number): New function, replacing isfloat_string.
4324 This function checks for valid syntax and produces the resulting
4325 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4326 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4327 so that overflow for non-base-10 numbers is reported only when
4328 there's no portable and simple way to convert to floating point.
452f4150 4329
67769ffc
PE
4330 * textprop.c (set_text_properties_1): Rewrite for clarity,
4331 and to avoid GCC warning about integer overflow.
4332
c20db43f
PE
4333 * intervals.h (struct interval): Use EMACS_INT for members
4334 where EMACS_UINT might cause problems. See
4335 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4336 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4337 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4338 All uses changed.
37aa2f85
PE
4339 (offset_intervals): Tell GCC not to worry about length overflow
4340 when negating a negative length.
c20db43f 4341
2538aa2f
PE
4342 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4343 (overrun_check_free): Likewise.
4344
f2d3008d
PE
4345 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4346 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4347 word size.
4348
ec8df744
PE
4349 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4350 (gnutls_make_error): Rename local to avoid shadowing.
4351 (gnutls_emacs_global_deinit): ifdef out; not used.
4352 (Fgnutls_boot): Use const for pointer to readonly storage.
4353 Comment out unused local. Fix pointer signedness problems.
4354
640ee02d
PE
4355 * lread.c (openp): Don't stuff size_t into an 'int'.
4356 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4357 about possible signed overflow.
4358
6048fb2a
PE
4359 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4360 (GDK_KEY_g): Don't define if already defined.
4361 (xg_prepare_tooltip): Avoid pointer signedness problem.
4362 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4363
fa3c87e1
PE
4364 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4365 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4366
2172544b
PE
4367 * xfns.c (Fx_window_property): Simplify a bit,
4368 to make a bit faster and to avoid GCC 4.6.0 warning.
4369 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4370
9b821a21
PE
4371 * fns.c (internal_equal): Don't assume size_t fits in int.
4372
3c616cfa
PE
4373 * alloc.c (compact_small_strings): Tighten assertion a little.
4374
c2982e87
PE
4375 Replace pEd with more-general pI, and fix some printf arg casts.
4376 * lisp.h (pI): New macro, generalizing old pEd macro to other
4377 conversion specifiers. For example, use "...%"pI"d..." rather
4378 than "...%"pEd"...".
4379 (pEd): Remove. All uses replaced with similar uses of pI.
4380 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4381 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4382 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4383 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4384 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4385 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4386 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4387 64-bit hosts.
4388 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4389 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4390 * print.c (safe_debug_print, print_object): Likewise.
4391 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4392 to int.
6f04d126
PE
4393 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4394 avoiding the 0 flag, which is not portable.
c2982e87
PE
4395 * process.c (Fmake_network_process): Use pI to avoid cast.
4396 * region-cache.c (pp_cache): Likewise.
4397 * xdisp.c (decode_mode_spec): Likewise.
4398 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4399 behavior on 64-bit hosts with printf arg.
6f04d126 4400 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4401 (x_stop_queuing_selection_requests): Likewise.
4402 (x_get_window_property): Don't truncate byte count to an 'int'
4403 when tracing.
0b432f21 4404
5e073ec7
PE
4405 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4406 here, since it parses constructs like leading '-' and spaces,
4407 which are not wanted; and it overflows with large numbers.
4408 Instead, simply match F[0-9]+, which is what is wanted anyway.
4409
36372bf9
PE
4410 * alloc.c: Remove unportable assumptions about struct layout.
4411 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4412 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4413 (allocate_vectorlike, make_pure_vector): Use the new macros,
4414 plus offsetof, to remove unportable assumptions about struct layout.
4415 These assumptions hold on all porting targets that I know of, but
4416 they are not guaranteed, they're easy to remove, and removing them
4417 makes further changes easier.
4418
0b432f21
PE
4419 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4420 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4421 (string_overrun_cookie): Now const. Use initializers that
4422 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4423 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4424 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4425 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4426 multiple of sizeof (EMACS_INT); it need not be, if
4427 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4428 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4429
895009e1
JB
44302011-04-26 Juanma Barranquero <lekktu@gmail.com>
4431
4432 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4433
6a7a1b0b
TZ
44342011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4435
4436 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4437 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4438 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4439
841a1577 44402011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4441
4442 * lisp.h (Qdebug): List symbol.
895009e1 4443 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4444 * keyboard.c (debug-on-event): New variable.
4445 (handle_user_signal): Break into debugger when debug-on-event
4446 matches the current signal symbol.
4447
f2d3ba6f
DN
44482011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4449
4450 * alloc.c (check_sblock, check_string_bytes)
4451 (check_string_free_list): Convert to standard C.
4452
42ce4c63
TZ
44532011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4454
4455 * w32.c (emacs_gnutls_push): Fix typo.
4456
825cd63c
EZ
44572011-04-25 Eli Zaretskii <eliz@gnu.org>
4458
fb11d64d
EZ
4459 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4460 "cast to pointer from integer of different size".
4461
825cd63c
EZ
4462 Improve doprnt and its use in verror. (Bug#8545)
4463 * doprnt.c (doprnt): Document the set of format control sequences
4464 supported by the function. Use SAFE_ALLOCA instead of always
4465 using `alloca'.
4466
4467 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4468 is one byte too soon. Don't use xrealloc; instead xfree and
4469 xmalloc anew.
4470
e061a11b
TZ
44712011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4472
4473 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4474 callbacks stage.
4475
4476 * gnutls.c: Renamed global_initialized to
4477 gnutls_global_initialized. Added internals for the
4478 :verify-hostname-error, :verify-error, and :verify-flags
4479 parameters of `gnutls-boot' and documented those parameters in the
4480 docstring. Start callback support.
9173deec
JB
4481 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4482 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4483 on error. Return error code.
e061a11b
TZ
4484 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4485 (emacs_gnutls_read): Likewise.
4486 (Fgnutls_boot): Return handshake error code.
4487 (emacs_gnutls_handle_error): New function.
4488 (wsaerror_to_errno): Likewise.
4489
4490 * w32.h (emacs_gnutls_pull): Add prototype.
4491 (emacs_gnutls_push): Likewise.
4492
4493 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4494 (emacs_gnutls_push): Likewise.
4495
44962011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4497
4498 * process.c (wait_reading_process_output): Check if GnuTLS
4499 buffered some data internally if no FDs are set for TLS
4500 connections.
4501
4502 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4503 (LIBS): Link to USER_LIBS.
4504 ($(BLD)/gnutls.$(0)): New target.
4505
fa6996bc
EZ
45062011-04-24 Eli Zaretskii <eliz@gnu.org>
4507
eb35682e
EZ
4508 * xdisp.c (handle_single_display_spec): Rename the
4509 display_replaced_before_p argument into display_replaced_p, to
4510 make it consistent with the commentary. Fix typos in the
4511 commentary.
4512
e2ad650c
EZ
4513 * textprop.c (syms_of_textprop): Remove dead code.
4514 (copy_text_properties): Delete obsolete commentary about an
4515 interface that was deleted long ago. Fix typos in the description
4516 of arguments.
4517
1b2de274
EZ
4518 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4519 to changes in oldXMenu/XMenu.h from 2011-04-16.
4520 <menu_help_message, prev_menu_help_message>: Constify.
4521 (IT_menu_make_room): menu->help_text is now `const char **';
4522 adjust.
4523
4524 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4525 to changes in oldXMenu/XMenu.h from 2011-04-16.
4526 (struct XMenu): Declare `help_text' `const char **'.
4527
4528 * xfaces.c <Qunspecified>: Make extern again.
4529
4530 * syntax.c: Include sys/types.h before including regex.h, as
4531 required by Posix.
4532
762b15be
EZ
4533 * doc.c (get_doc_string): Improve the format passed to `error'.
4534
4535 * doprnt.c (doprnt): Improve commentary.
4536
4537 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4538
4539 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4540 them with etags.
4541
f1052e5d
EZ
4542 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4543 changes in globals.h immediately force recompilation.
762b15be
EZ
4544 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4545 $(CURDIR)/s/ms-w32.h.
4546 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4547
fa6996bc
EZ
4548 * character.c (Fchar_direction): Function deleted.
4549 (syms_of_character): Don't defsubr it.
4550 <char-direction-table>: Deleted.
4551
e6c3da20
EZ
45522011-04-23 Eli Zaretskii <eliz@gnu.org>
4553
4554 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4555 * doprnt.c: Include limits.h.
4556 (SIZE_MAX): New macro.
04f2d78b
CB
4557 (doprnt): Return a size_t value. 2nd arg is now size_t.
4558 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4559 Improve overflow protection. Support `l' modifier for integer
4560 conversions. Support %l conversion. Don't assume an EMACS_INT
4561 argument for integer conversions and for %c.
4562
4563 * lisp.h (doprnt): Restore prototype.
4564
4565 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4566 $(SRC)/character.h.
4567
4568 * Makefile.in (base_obj): Add back doprnt.o.
4569
4570 * deps.mk (doprnt.o): Add back prerequisites.
4571 (callint.o): Depend on character.h.
4572
4573 * eval.c (internal_lisp_condition_case): Include the handler
4574 representation in the error message.
4575 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4576 when breaking from the loop.
4577
4578 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4579
4580 * callint.c (Fcall_interactively): When displaying error message
4581 about invalid control letter, pass the character's codepoint, not
4582 a pointer to its multibyte form. Improve display of the character
4583 in octal and display also its hex code.
4584
4585 * character.c (char_string): Use %x to display the (unsigned)
4586 codepoint of an invalid character, to avoid displaying a bogus
4587 negative value.
4588
4589 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4590 `error', not SYMBOL_NAME itself.
4591
4592 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4593 character arguments to `error'.
4594
4595 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4596 to `error' in error message about FINAL_CHAR argument. Make sure
4597 FINAL_CHAR is a character, and use %c when it is passed as
4598 argument to `error'.
4599
4ffd0d6b 46002011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4601
4602 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4603
4604 * w32.c: Include <time.h>.
4605 (sys_localtime): New function.
4606
4ffd0d6b 46072011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4608
4609 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4610
4ffd0d6b 4611 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4612
4ffd0d6b 46132011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4614
4ffd0d6b
GM
4615 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4616 zombies (Bug#8467).
aac0c6e3 4617
04c56954
EZ
46182011-04-19 Eli Zaretskii <eliz@gnu.org>
4619
4620 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4621 gl_state.e_property when gl_state.object is Qt.
4622
4623 * insdel.c (make_gap_larger): Remove limitation of buffer size
4624 to <= INT_MAX.
4625
16a43933
CY
46262011-04-18 Chong Yidong <cyd@stupidchicken.com>
4627
4628 * xdisp.c (lookup_glyphless_char_display)
4629 (produce_glyphless_glyph): Handle cons cell entry in
4630 glyphless-char-display.
4631 (Vglyphless_char_display): Document it.
4632
4633 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4634 glyphless-char-display.
4635
4581706e
CY
46362011-04-17 Chong Yidong <cyd@stupidchicken.com>
4637
4638 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4639
4640 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4641
4642 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4643 definition for no-X builds.
4644
4887c6e2 46452011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4646
fd35b6f9
PE
4647 Static checks with GCC 4.6.0 and non-default toolkits.
4648
5c1ccb01
PE
4649 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4650
006c5daa
PE
4651 * process.c (keyboard_bit_set): Define only if SIGIO.
4652 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4653 (send_process): Repair possible setjmp clobbering.
4654
efc736d3
PE
4655 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4656
4e2fe2e6
PE
4657 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4658
f97334a2
PE
4659 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4660
4e75f29d
PE
4661 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4662 Define only if needed.
4663
90efadd1
PE
4664 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4665 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4666 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4667
3c647824
PE
4668 * dispextern.h (struct redisplay_interface): Rename param
4669 to avoid shadowing.
e264f262 4670 * termhooks.h (struct terminal): Likewise.
761383f4 4671 * xterm.c (xembed_send_message): Likewise.
3c647824 4672
b58c5c4a
PE
4673 * insdel.c (make_gap_smaller): Define only if
4674 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4675
cad59032
PE
4676 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4677 it.
4678
c339dc2e
PE
4679 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4680 so that we aren't warned about unused symbols.
4681
91a3e27b
PE
4682 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4683
399c71d3 4684 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4685
8ffc96f5
PE
4686 * xfns.c (x_real_positions): Mark locals as initialized.
4687
eef9bc79
PE
4688 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4689
098db9dd
PE
4690 * xterm.c: Fix problems found by static analysis with other toolkits.
4691 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4692 (x_dispatch_event): Declare static if USE_GTK, and
4693 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4694 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4695 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4696 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4697 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4698
eb18f6cc
PE
4699 * xmenu.c (menu_help_callback): Pointer type fixes.
4700 Use const pointers when pointing at readonly data. Avoid pointer
4701 signedness clashes.
4702 (FALSE): Remove unused macro.
4703 (update_frame_menubar): Remove unused decl.
4704
1fe72bf8
PE
4705 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4706
60d9e1db
PE
4707 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4708 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4709 (single_menu_item): Rename local to avoid shadowing.
4710
39261c26
PE
4711 * keyboard.c (make_lispy_event): Remove unused local var.
4712
018c5e19
PE
4713 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4714 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4715
63d2b86e
PE
4716 * bitmaps: Change bitmaps from unsigned char back to the X11
4717 compatible char. Avoid the old compiler warnings about
4718 out-of-range initializers by using, for example, '\xab' rather
4719 than 0xab.
4720
aefd87e1
PE
4721 * xgselect.c (xgselect_initialize): Check vs interface
4722 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4723
bf501fb9
PE
4724 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4725
e9829fdf
PE
4726 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4727 to read-only memory.
4728
1086c095
PE
4729 * fns.c (vector): Remove; this old hack is no longer needed.
4730
2baccd04 4731 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4732 Remove unused var.
dde42981 4733 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4734
72391843 4735 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4736
436c16df 4737 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4738 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4739 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4740
92bb796d 4741 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4742 (x_term_init): Remove local to avoid shadowing.
92bb796d 4743
764430a3 4744 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4745
4746 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4747 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4748
d1dfb56c
EZ
47492011-04-16 Eli Zaretskii <eliz@gnu.org>
4750
c4354cb4
EZ
4751 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4752
d1dfb56c
EZ
4753 Fix regex.c, syntax.c and friends for buffers > 2GB.
4754 * syntax.h (struct gl_state_s): Declare character position members
4755 EMACS_INT.
4756
4757 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4758
04f2d78b
CB
4759 * textprop.c (verify_interval_modification, interval_of):
4760 Declare arguments EMACS_INT.
d1dfb56c
EZ
4761
4762 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4763 EMACS_INT.
4764
4765 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4766
4767 * indent.c (Fvertical_motion): Local variable it_start is now
4768 EMACS_INT.
4769
4770 * regex.c (re_match, re_match_2, re_match_2_internal)
4771 (bcmp_translate, regcomp, regexec, print_double_string)
4772 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4773 (re_compile_pattern, re_exec): Declare arguments and local
4774 variables `size_t' and `ssize_t' and return values `regoff_t', as
4775 appropriate.
4776 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4777 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4778 <compile_stack_type>: `size' and `avail' are now `size_t'.
4779
4780 * regex.h <regoff_t>: Use ssize_t, not int.
4781 (re_search, re_search_2, re_match, re_match_2): Arguments that
4782 specify buffer/string position and length are now ssize_t and
4783 size_t. Return type is regoff_t.
4784
613052cd
BK
47852011-04-16 Ben Key <bkey76@gmail.com>
4786
4787 * nsfont.m: Fixed bugs in ns_get_family and
4788 ns_descriptor_to_entity that were caused by using free to
4789 deallocate memory blocks that were allocated by xmalloc (via
4790 xstrdup). This caused Emacs to crash when compiled with
4791 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4792 --enable-checking=xmallocoverrun). xfree is now used to
4793 deallocate these memory blocks.
4794
4170f62f 47952011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4796
71b41406
PE
4797 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4798
9587a89d
PE
4799 emacs_write: Accept and return EMACS_INT for sizes.
4800 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4801 et seq.
4802 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4803 Accept and return EMACS_INT.
4804 (emacs_gnutls_write): Return the number of bytes written on
4805 partial writes.
4806 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4807 (emacs_read, emacs_write): Remove check for negative size, as the
4808 Emacs source code has been audited now.
9587a89d
PE
4809 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4810 (emacs_read, emacs_write): Use it.
273a5f82
PE
4811 * process.c (send_process): Adjust to the new signatures of
4812 emacs_write and emacs_gnutls_write. Do not attempt to store
4813 a byte offset into an 'int'; it might overflow.
9587a89d 4814 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4815
3e047f51
PE
4816 * sound.c: Don't assume sizes fit in 'int'.
4817 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4818 Return EMACS_INT, not int.
3e047f51 4819 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4820 Accept EMACS_INT, not int.
4821 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4822 record read return values.
4823
cc39a9db
BK
48242011-04-15 Ben Key <bkey76@gmail.com>
4825
c9d0ec6d
JB
4826 * keyboard.c (Qundefined): Don't declare static since it is used
4827 in nsfns.m.
4828 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4829 static since they are used in nsfont.m.
cc39a9db 4830
6c60eb9f
SM
48312011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4832
4833 * process.c (Qprocessp): Don't declare static.
4834 * lisp.h (Qprocessp): Declare again.
4835
7990b61a
JB
48362011-04-15 Juanma Barranquero <lekktu@gmail.com>
4837
4838 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4839
5d4cb038
PE
48402011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4841
8bd7b830 4842 Improve C-level modularity by making more things 'static'.
cd64ea1d 4843
e3b27b31
PE
4844 Don't publish debugger-only interfaces to other modules.
4845 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4846 (verify_bytepos, count_markers): Move decls to the only modules
4847 that need them.
4848 * region-cache.h (pp_cache): Likewise.
4849 * window.h (check_all_windows): Likewise.
4850 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4851
5d4cb038
PE
4852 * sysdep.c (croak): Now static, if
4853 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4854 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4855
4856 * alloc.c (refill_memory_reserve): Now static if
4857 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4858 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4859
e87b6180
PE
4860 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4861 Define only if USE_LUCID.
4862
ac64929e
PE
4863 * xrdb.c (x_customization_string, x_rm_string): Now static.
4864
6f37259d
PE
4865 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4866 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4867
1683e3ab
PE
4868 * xdisp.c (draw_row_with_mouse_face): Now static.
4869 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4870
de9c2632
PE
4871 * window.h (check_all_windows): Mark externally visible.
4872
2b96acb7
PE
4873 * window.c (window_deletion_count): Now static.
4874
4875 * undo.c: Make symbols static if they're not exported.
4876 (last_undo_buffer, last_boundary_position, pending_boundary):
4877 Now static.
4878
50436f33
PE
4879 * textprop.c (interval_insert_behind_hooks): Now static.
4880 (interval_insert_in_front_hooks): Likewise.
4881
64520e5c
PE
4882 * term.c: Make symbols static if they're not exported.
4883 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4884 (max_frame_lines, tty_set_terminal_modes):
4885 (tty_reset_terminal_modes, tty_turn_off_highlight):
4886 (get_tty_terminal): Now static.
4887 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4888 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4889 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4890 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4891 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4892
1fa53021
PE
4893 * sysdep.c: Make symbols static if they're not exported.
4894 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4895 Now static.
4896 (sigprocmask_set, full_mask): Remove; unused.
4897 (wait_debugging): Mark as visible.
4898 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4899 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4900
d4b43b22
PE
4901 * syntax.c (syntax_temp): Define only if !__GNUC__.
4902
b7c513d0
PE
4903 * sound.c (current_sound_device, current_sound): Now static.
4904
989b29ad
PE
4905 * search.c (searchbufs, searchbuf_head): Now static.
4906
13a55a78
PE
4907 * scroll.c (scroll_cost): Remove; unused.
4908 * dispextern.h (scroll_cost): Remove decl.
4909
de68a1fc
PE
4910 * region-cache.h (pp_cache): Mark as externally visible.
4911
40ccffa6
PE
4912 * process.c: Make symbols static if they're not exported.
4913 (process_tick, update_tick, create_process, chan_process):
4914 (Vprocess_alist, proc_buffered_char, datagram_access):
4915 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4916 (deactivate_process): Mark defn as static, as well as decl.
4917 * lisp.h (create_process): Remove decl.
4918 * process.h (chan_process, Vprocess_alist): Remove decls.
4919
ad64fc97
PE
4920 * print.c: Make symbols static if they're not exported.
4921 (print_depth, new_backquote_output, being_printed, print_buffer):
4922 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4923 (print_interval, print_number_index, initial_stderr_stream):
4924 Now static.
4925 * lisp.h (Fprinc): Remove decl.
4926 (debug_output_compilation_hack): Mark as externally visible.
4927
adddb265
PE
4928 * sysdep.c (croak): Move decl from here to syssignal.h.
4929 * syssignal.h (croak): Put it here, so the API can be checked when
4930 'croak' is called from dissociate_if_controlling_tty.
4931
1717ede2
PE
4932 * minibuf.c: Make symbols static if they're not exported.
4933 (minibuf_save_list, choose_minibuf_frame): Now static.
4934 * lisp.h (choose_minibuf_frame): Remove decl.
4935
fa5fb2bc
PE
4936 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4937
1e3890d1
PE
4938 * lread.c: Make symbols static if they're not exported.
4939 (read_objects, initial_obarray, oblookup_last_bucket_number):
4940 Now static.
4941 (make_symbol): Remove; unused.
4942 * lisp.h (initial_obarray, make_symbol): Remove decls.
4943
8a1414fa
PE
4944 * keyboard.c: Make symbols static if they're not exported.
4945 (single_kboard, recent_keys_index, total_keys, recent_keys):
4946 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4947 (this_single_command_key_start, echoing, last_auto_save):
4948 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4949 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4950 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4951 (Vlispy_mouse_stem, double_click_count):
4952 Now static.
4953 (force_auto_save_soon): Define only if SIGDANGER.
4954 (ignore_mouse_drag_p): Now static if
4955 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4956 (print_help): Remove; unused.
4957 (stop_character, last_timer_event): Mark as externally visible.
4958 * keyboard.h (ignore_mouse_drag_p): Declare only if
4959 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4960 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4961 * lisp.h (echoing): Remove decl.
4962 (force_auto_save_soon): Declare only if SIGDANGER.
4963 * xdisp.c (redisplay_window): Simplify code, to make it more
4964 obvious that ignore_mouse_drag_p is not accessed if !defined
4965 USE_GTK && !defined HAVE_NS.
4966
93ea6e8f
PE
4967 * intervals.c: Make symbols static if they're not exported.
4968 (merge_properties_sticky, merge_interval_right, delete_interval):
4969 Now static.
4970 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4971
77382fcc
PE
4972 * insdel.c: Make symbols static if they're not exported.
4973 However, leave prepare_to_modify_buffer alone. It's never
4974 called from outside this function, but that appears to be a bug.
4975 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4976 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4977 (adjust_after_replace_noundo): Remove; unused.
4978 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4979 (signal_before_change): Remove decls.
77382fcc 4980
9306c32e
PE
4981 * indent.c (val_compute_motion, val_vmotion): Now static.
4982
cd44d2eb
PE
4983 * image.c: Make symbols static if they're not exported.
4984 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4985 if USE_GTK.
4986 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4987 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4988
ad9a7a06
PE
4989 * fringe.c (standard_bitmaps): Now static.
4990 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4991
81626931
PE
4992 * frame.c: Make symbols static if they're not exported.
4993 (x_report_frame_params, make_terminal_frame): Now static.
4994 (get_frame_param): Now static, unless HAVE_NS.
4995 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4996 (x_get_resource_string): Remove; not used.
4997 * frame.h (make_terminal_frame, x_report_frame_params):
4998 (x_get_resource_string); Remove decls.
4999 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5000 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5001
239f9db9
PE
5002 * font.c, fontset.c: Make symbols static if they're not exported.
5003 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5004 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5005 * font.c (font_close_object): Now static.
5006 * font.h (font_close_object): Remove.
5007 * fontset.c (FONTSET_OBJLIST): Remove.
5008 (free_realized_fontset) #if-0 the body, which does nothing.
5009 (face_suitable_for_char_p): #if-0, as it's never called.
5010 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5011 * xfaces.c (face_at_string_position):
5012 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5013 since 0 is always ASCII.
5014
dfcf3579
PE
5015 * fns.c (weak_hash_tables): Now static.
5016
5045092b
PE
5017 * fileio.c: Make symbols static if they're not exported.
5018 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5019 (Vwrite_region_annotation_buffers): Now static.
5020
57a96f5c
PE
5021 * eval.c: Make symbols static if they're not exported.
5022 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5023 * lisp.h (backtrace_list): Remove decl.
5024
35f08c38
PE
5025 * emacs.c: Make symbols static if they're not exported.
5026 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5027 (fatal_error_code, fatal_error_signal_hook, standard_args):
5028 Now static.
5029 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5030 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5031 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5032 * lisp.h (fatal_error_signal_hook): Remove decl.
5033 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5034
f44bd759
PE
5035 * editfns.c: Move a (normally-unused) function to its only use.
5036 * editfns.c, lisp.h (get_operating_system_release): Remove.
5037 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5038 worth the hassle of breaking this out.
5039
b532497d
PE
5040 * xterm.c: Make symbols static if they're not exported.
5041 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5042 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5043 (x_destroy_window, x_delete_display):
5044 Now static.
5045 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5046 (x_mouse_leave): Remove; unused.
5047 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5048 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5049 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5050 Remove decls.
5051 (x_mouse_leave): Declare only if WINDOWSNT.
5052 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5053 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5054 USE_X_TOOLKIT.
5055
1675728f
PE
5056 * ftxfont.c: Make symbols static if they're not exported.
5057 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5058 HAVE_FREETYPE.
5059 * font.h (ftxfont_driver): Likewise.
5060
e4cebfca
PE
5061 * xfns.c: Make symbols static if they're not exported.
5062 (x_last_font_name, x_display_info_for_name):
5063 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5064 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5065 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5066 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5067 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5068 (last_show_tip_args): Now static.
5069 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5070 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5071 (x_screen_planes): Remove; unused.
5072 * dispextern.h (x_screen_planes): Remove decl.
5073
5bf46f05
PE
5074 * dispnew.c: Make symbols static if they're not exported.
5075 * dispextern.h (redraw_garbaged_frames, scrolling):
5076 (increment_row_positions): Remove.
5077 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5078 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5079 Now static.
5080 (redraw_garbaged_frames): Remove; unused.
5081
435f4c28
PE
5082 * xfaces.c: Make symbols static if they're not exported.
5083 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5084 Remove decls.
5085 * xterm.h (defined_color): Remove decls.
5086 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5087 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5088 (menu_face_changed_default, defined_color, free_realized_face):
5089 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5090 (ascii_face_of_lisp_face): Remove; unused.
5091
8524aef3
PE
5092 * xdisp.c: Make symbols static if they're not exported.
5093 * dispextern.h (scratch_glyph_row, window_box_edges):
5094 (glyph_to_pixel_coords, set_cursor_from_row):
5095 (get_next_display_element, set_iterator_to_next):
5096 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5097 (show_mouse_face): Remove decls
5098 * frame.h (message_buf_print): Likewise.
5099 * lisp.h (pop_message, set_message, check_point_in_composition):
5100 Likewise.
5101 * xterm.h (set_vertical_scroll_bar): Likewise.
5102 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5103 (message_buf_print, scratch_glyph_row, displayed_buffer):
5104 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5105 (get_next_display_element, show_mouse_face, window_box_edges):
5106 (frame_to_window_pixel_xy, check_point_in_composition):
5107 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5108 (glyph_to_pixel_coords): Remove; unused.
5109
16390cd2
PE
5110 * dired.c (file_name_completion): Now static.
5111
5112 * dbusbind.c (xd_in_read_queued_messages): Now static.
5113
a25f4dfa
PE
5114 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5115 * data.c (circular_list_error): Remove.
5116
14a9c8df
PE
5117 * commands.h (last_point_position, last_point_position_buffer):
5118 (last_point_position_window): Remove decls.
5119 * keyboard.c: Make these variables static.
5120
04f2d78b
CB
5121 * coding.h (coding, code_convert_region, encode_coding_gap):
5122 Remove decls.
74ab6df5
PE
5123 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5124 (iso_code_class, detect_coding, code_convert_region): Now static.
5125 (encode_coding_gap): Remove; unused.
5126
38dfbee1
PE
5127 * chartab.c (chartab_chars, chartab_bits): Now static.
5128
a2cb4e63
PE
5129 * charset.h (charset_iso_8859_1): Remove decl.
5130 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5131 Now static.
5132
127198fd
PE
5133 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5134 * ccl.c (Vccl_program_table): Now static.
5135 (check_ccl_update): Remove; unused.
5136
d85b608f
PE
5137 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5138 * category.h: ... from here.
5139 * category.c (check_category_table, set_category_set): Now static.
5140
31cd66f3
PE
5141 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5142 * lisp.h: Remove these decls.
5143
c358e587
PE
5144 * buffer.c (buffer_count): Remove unused var.
5145
e78aecca
PE
5146 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5147 so that it's not optimized away.
5148 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5149 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5150 exported only to the debugger.
5151
e192d7d3 5152 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5153 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5154
92470028
PE
5155 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5156 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5157 was inaccessible from Lisp.
5158 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5159 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5160
244ed907
PE
5161 alloc.c: Import and export fewer symbols, and remove unused items.
5162 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5163 is defined.
5164 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5165 it's not optimized away by whole-program optimization.
5166 (message_enable_multibyte, free_misc): Remove.
5167 (catchlist, handlerlist, mark_backtrace):
5168 Declare only if BYTE_MARK_STACK.
5169 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5170 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5171 (message_enable_multibyte): Remove decl.
5172 (free_misc, interval_free_list, float_block, float_block_index):
5173 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5174 (cons_free_list, last_marked_index):
5175 Now static.
5176 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5177 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5178 (mark_backtrace): Define only if BYTE_MARK_STACK.
5179 * xdisp.c (message_enable_multibyte): Now static.
5180
61c2b50e 5181 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5182 This makes it easier for human readers (and static analyzers)
5183 to see whether these variables are used from other modules.
5184 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5185 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5186 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5187 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5188 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5189 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5190 * xmenu.c, xselect.c:
5191 Declare Q* vars static if they are not used in other modules.
5192 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5193 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5194 Remove decls of unexported vars.
5195 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5196
95c82688
PE
5197 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5198
16a97296
PE
5199 Make Emacs functions such as Fatom 'static' by default.
5200 This makes it easier for human readers (and static analyzers)
5201 to see whether these functions can be called from other modules.
5202 DEFUN now defines a static function. To make the function external
5203 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5204 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5205 (Finit_image_library):
16a97296
PE
5206 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5207 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5208 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5209 Remove decls, since these functions are now static.
5210 (Funintern, Fget_internal_run_time): New decls, since these functions
5211 were already external.
95c82688 5212
16a97296
PE
5213 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5214 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5215 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5216 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5217 * keyboard.c, keymap.c, lread.c:
5218 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5219 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5220 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5221 Mark functions with DEFUE instead of DEFUN,
5222 if they are used in other modules.
5223 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5224 decls for now-static functions.
5225 * buffer.h (Fdelete_overlay): Remove decl.
5226 * callproc.c (Fgetenv_internal): Mark as internal.
5227 * composite.c (Fremove_list_of_text_properties): Remove decl.
5228 (Fcomposition_get_gstring): New forward static decl.
5229 * composite.h (Fcomposite_get_gstring): Remove decl.
5230 * dired.c (Ffile_attributes): New forward static decl.
5231 * doc.c (Fdocumntation_property): New forward static decl.
5232 * eval.c (Ffetch_bytecode): New forward static decl.
5233 (Funintern): Remove extern decl; now in .h file where it belongs.
5234 * fileio.c (Fmake_symbolic_link): New forward static decl.
5235 * image.c (Finit_image_library): New forward static decl.
5236 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5237 * intervals.h (Fprevious_property_change):
5238 (Fremove_list_of_text_properties): Remove decls.
5239 * keyboard.c (Fthis_command_keys): Remove decl.
5240 (Fcommand_execute): New forward static decl.
5241 * keymap.c (Flookup_key): New forward static decl.
5242 (Fcopy_keymap): Now static.
5243 * keymap.h (Flookup_key): Remove decl.
5244 * process.c (Fget_process): New forward static decl.
5245 (Fprocess_datagram_address): Mark as internal.
5246 * syntax.c (Fsyntax_table_p): New forward static decl.
5247 (skip_chars): Remove duplicate decl.
5248 * textprop.c (Fprevious_property_change): New forward static decl.
5249 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5250 Now internal.
5251 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5252 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5253
785bbd42
PE
5254 * editfns.c (Fformat): Remove unreachable code.
5255
8b913b57
AS
52562011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5257
5258 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5259 change. (Bug#8496)
5260
a6744a35
EZ
52612011-04-13 Eli Zaretskii <eliz@gnu.org>
5262
5263 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5264 when at ZV. (Bug#8487)
5265
e7974947
AS
52662011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5267
baad03f0
AS
5268 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5269 (Bug#8437)
5270 * keyboard.c (parse_tool_bar_item): Likewise.
5271 * sound.c (sound_cleanup, alsa_close): Likewise.
5272 * termcap.c (tgetent): Likewise.
5273 * xfns.c (x_default_font_parameter): Likewise.
5274 * xsettings.c (read_and_apply_settings): Likewise.
5275
e7974947
AS
5276 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5277 (overrun_check_free): Protoize.
5278
28272684
PE
52792011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5280
5281 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5282 since callers should never pass a negative size.
5283 Change the signature to match that of plain 'read' and 'write'; see
5284 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5285 * lisp.h: Update prototypes of emacs_write and emacs_read.
5286
11997c76
EZ
52872011-04-11 Eli Zaretskii <eliz@gnu.org>
5288
5289 * xdisp.c (redisplay_window): Don't try to determine the character
5290 position of the scroll margin if the window start point w->startp
e896f03c 5291 is outside the buffer's accessible region. (Bug#8468)
11997c76 5292
8a2cbd72
EZ
52932011-04-10 Eli Zaretskii <eliz@gnu.org>
5294
5295 Fix write-region and its subroutines for buffers > 2GB.
5296 * fileio.c (a_write, e_write): Modify declaration of arguments and
5297 local variables to support buffers larger than 2GB.
5298 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5299
5300 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5301 argument, local variables, and return value.
5302
5303 * lisp.h: Update prototypes of emacs_write and emacs_read.
5304
5305 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5306
4073e537 53072011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5308
1ebfdcb6
PE
5309 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5310
b2ded58d
PE
5311 Fix more problems found by GCC 4.6.0's static checks.
5312
7d66342c
PE
5313 * xdisp.c (vmessage): Use a better test for character truncation.
5314
bbf47d44
PE
5315 * charset.c (load_charset_map): <, not <=, for optimization,
5316 and to avoid potential problems with integer overflow.
9248994d 5317 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5318 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5319 * editfns.c (Fformat): Likewise.
1e69125e 5320 * syntax.c (skip_chars): Likewise.
3befa583 5321
e3019616
PE
5322 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5323 This also lets GCC 4.6.0 generate slightly better loop code.
5324
becfa255
PE
5325 * callint.c (Fcall_interactively): <, not <=, for optimization.
5326 (Fcall_interactively): Count the number of arguments produced,
5327 not the number of arguments given. This is simpler and lets GCC
5328 4.6.0 generate slightly better code.
5329
dae0cd48
PE
5330 * ftfont.c: Distingish more carefully between FcChar8 and char.
5331 The previous code passed unsigned char * to a functions like
5332 strlen and xstrcasecmp that expect char *, which does not
5333 conform to the C standard.
5334 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5335 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5336 char * when the C standard requires it.
5337
76032d70
PE
5338 * keyboard.c (read_char): Remove unused var.
5339
eb3f1cc8
PE
5340 * eval.c: Port to Windows vsnprintf (Bug#8435).
5341 Include <limits.h>.
5342 (SIZE_MAX): Define if the headers do not.
5343 (verror): Do not give up if vsnprintf returns a negative count.
5344 Instead, grow the buffer. This ports to Windows vsnprintf, which
5345 does not conform to C99. Problem reported by Eli Zaretskii.
5346 Also, simplify the allocation scheme, by avoiding the need for
5347 calling realloc, and removing the ALLOCATED variable.
5348
70476b54
PE
5349 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5350
12020a9e
PE
5351 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5352 But keep the doprint source code for now, as we might revamp it
5353 and use it again (Bug#8435).
ea6c7ae6
PE
5354 * lisp.h (doprnt): Remove.
5355 * Makefile.in (base_obj): Remove doprnt.o.
5356 * deps.mk (doprnt.o): Remove.
5357
5fdb398c
PE
5358 error: Print 32- and 64-bit integers portably (Bug#8435).
5359 Without this change, on typical 64-bit hosts error ("...%d...", N)
5360 was used to print both 32- and 64-bit integers N, which relied on
5361 undefined behavior.
5362 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5363 New macro.
5364 * lisp.h (error, verror): Mark as printf-like functions.
5365 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5366 Report overflow in size calculations when allocating printf buffer.
5367 Do not truncate output string at its first null byte.
5368 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5369 Truncate the output at a character boundary, since vsnprintf does not
5370 do that.
5371 * charset.c (check_iso_charset_parameter): Convert internal
5372 character to string before calling 'error', since %c now has the
5373 printf meaning.
5374 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5375 overflow when computing char to be passed to 'error'. Do not
5376 pass Lisp_Object to 'error'; pass the integer instead.
5377 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5378 formatted with plain %d.
5379
b189fa66
PE
5380 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5381
bff87ef0
PE
5382 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5383
7e2cac20
PE
5384 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5385
ce4d90b5
PE
5386 * xterm.c (x_catch_errors): Remove duplicate declaration.
5387
266c9547
PE
5388 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5389
79c49ad2
PE
5390 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5391
368f4090
JM
53922011-04-10 Jim Meyering <meyering@redhat.com>
5393
5394 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5395 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5396 return ssize_t not "int", and use size_t as the buffer length.
5397 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5398 * gnutls.h: Update declarations.
5399 * process.c (read_process_output): Use ssize_t, to match.
5400 (send_process): Likewise.
5401
a32d4040
CY
54022011-04-09 Chong Yidong <cyd@stupidchicken.com>
5403
5404 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5405
8546720e 54062011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5407
04f2d78b
CB
5408 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5409 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5410
8546720e
GM
5411 * xterm.c (handle_one_xevent):
5412 * xmenu.c (create_and_show_popup_menu):
5413 * xselect.c (x_decline_selection_request)
5414 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5415
0a2f5c1a 54162011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5417
5418 Fix some uses of `int' instead of EMACS_INT.
5419 * search.c (string_match_1, fast_string_match)
5420 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5421 (scan_buffer, find_next_newline_no_quit)
5422 (find_before_next_newline, search_command, Freplace_match)
5423 (Fmatch_data): Make some `int' variables be EMACS_INT.
5424
5425 * xdisp.c (display_count_lines): 3rd argument and return value now
5426 EMACS_INT. All callers changed.
5427 (pint2hrstr): Last argument is now EMACS_INT.
5428
5429 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5430 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5431 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5432 (decode_coding_utf_16, decode_coding_emacs_mule)
5433 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5434 (decode_coding_ccl, decode_coding_charset)
5435 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5436 (decode_coding_iso_2022, decode_coding_emacs_mule)
5437 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5438 <char_offset, last_offset>: Declare EMACS_INT.
5439 (encode_coding_utf_8, encode_coding_utf_16)
5440 (encode_coding_emacs_mule, encode_invocation_designation)
5441 (encode_designation_at_bol, encode_coding_iso_2022)
5442 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5443 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5444 Declare EMACS_INT.
5445 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5446 (encode_invocation_designation): Last argument P_NCHARS is now
5447 EMACS_INT.
5448 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5449 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5450
5451 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5452 All users changed.
5453
5454 * ccl.c (Fccl_execute_on_string): Declare some variables
5455 EMACS_INT.
5456
8546720e 54572011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5458
5459 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5460
4e19a977
CS
54612011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5462
5463 * process.c (Fformat_network_address): Doc fix.
5464
87302331
R
54652011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5466
5467 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5468
cbb59342
CY
54692011-04-08 Chong Yidong <cyd@stupidchicken.com>
5470
5471 * keyboard.c (read_char): Call Lisp function help-form-show,
5472 instead of using internal_with_output_to_temp_buffer.
5473 (Qhelp_form_show): New var.
e0d38eeb 5474 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5475
5476 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5477
5478 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5479
e67a13ab
CY
54802011-04-06 Chong Yidong <cyd@stupidchicken.com>
5481
04f2d78b
CB
5482 * process.c (Flist_processes): Remove to Lisp.
5483 (list_processes_1): Delete.
e67a13ab 5484
973f782d
EZ
54852011-04-06 Eli Zaretskii <eliz@gnu.org>
5486
7c106b1e
EZ
5487 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5488
973f782d
EZ
5489 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5490
41cf7d1a 54912011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5492
ca23cc88
PE
5493 Fix more problems found by GCC 4.6.0's static checks.
5494
f390e2d5
PE
5495 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5496
42eea0d0
PE
5497 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5498
b69769da 5499 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5500
f9541e84
PE
5501 * xdisp.c (vmessage): Mark as a printf-like function.
5502
13841b55
PE
5503 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5504
c136c10f
PE
5505 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5506
5e2d4a30
PE
5507 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5508 printf-like functions.
5509 (tiff_load): Add casts to remove these marks before passing them
5510 to system-supplied API.
5511
583f48b9
PE
5512 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5513
b25d760e
PE
5514 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5515 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5516 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5517 directly, rather than having caller test rule sign. This avoids
5518 some unnecessary tests.
5519 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5520 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5521 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5522
bc7b6697 5523 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5524 (xfont_open): Avoid unnecessary tests.
bc7b6697 5525
27ccc379
PE
5526 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5527
dcd5c89a
PE
5528 * composite.h, composite.c (composition_gstring_put_cache):
5529 Use EMACS_INT, not int, for length.
5530
b13a45c6
PE
5531 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5532 breaking out part of COMPOSITION_DECODE_RULE.
5533 (COMPOSITION_DECODE_RULE): Use it.
5534 * composite.c (get_composition_id): Remove unused local vars,
5535 by using the new macro.
5536
1e792e4d
PE
5537 * textprop.c (set_text_properties_1): Change while to do-while,
5538 since the condition is always true at first.
5539
dc6c6455 5540 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5541 (interval_deletion_adjustment): Return unsigned value.
5542 All uses changed.
dc6c6455 5543
aba7731a
PE
5544 * process.c (list_processes_1, create_pty, read_process_output):
5545 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5546 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5547 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5548 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5549 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5550
fdfc4bf3
PE
5551 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5552
fca8fe46 5553 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5554 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5555
06a0259a 5556 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5557 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5558 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5559
e7b9e80f
PE
5560 * print.c (print_error_message): Avoid int overflow.
5561
56201685
PE
5562 * font.c (font_list_entities): Redo for clarity,
5563 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5564
78834453 5565 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5566 (font_score): Avoid potential overflow in diff calculation.
78834453 5567
0bc0b309 5568 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5569 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5570
e610eaca
PE
5571 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5572
b895abce
PE
5573 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5574 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5575 can always succeed if overflow has undefined behavior.
5576
1f1d9321 5577 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5578 (wordify): Omit three unnecessary tests.
1f1d9321 5579
c59478bc
PE
5580 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5581 All callers changed. This avoids the need for an unused var.
5582
79b73827
PE
5583 * casefiddle.c (casify_region): Remove var that is set but not used.
5584
a4db5dfe
PE
5585 * dired.c (file_name_completion): Remove var that is set but not used.
5586
43aae36e
PE
5587 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5588
2a47c44d 5589 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5590 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5591
a37c69bf
PE
5592 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5593 Check for integer overflow on size calculations.
5594
328ab8e7
PE
5595 * buffer.c (Fprevious_overlay_change): Remove var that is set
5596 but not used.
5597
e5a2a5cb
PE
5598 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5599 Remove vars that are set but not used.
8d84a6eb 5600 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5601 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5602
a60e5f68
PE
5603 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5604
f661cb61 5605 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5606 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5607
f0397f5a
PE
5608 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5609 that are set but not used.
5610
8664db06 5611 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5612 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5613
6abdaa4a
PE
5614 * xselect.c (x_get_local_selection, x_handle_property_notify):
5615 Remove vars that are set but not used.
5616
0ce7538d 5617 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5618 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5619
9ae848fc
PE
5620 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5621 Remove var that is set but not used.
0b918413
PE
5622 (scroll_bar_windows_size): Now size_t, not int.
5623 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5624 Check for overflow.
9ae848fc 5625
a5a62657
PE
5626 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5627 (map_tty_color) [!defined MSDOS]: Likewise.
5628
5c5cdd39
PE
5629 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5630
66ebf983
PE
5631 * coding.c: Remove vars that are set but not used.
5632 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5633 All callers changed.
5634 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5635 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5636 (decode_coding_charset): Remove vars that are set but not used.
5637
1be4d761
PE
5638 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5639 that is set but not used.
5640
47553fa8
PE
5641 * print.c (print_object): Remove var that is set but not used.
5642
1f7196bf 5643 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5644 The gnulib version avoids calling malloc in the usual case,
5645 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5646 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5647 * filelock.c (current_lock_owner): Likewise.
5648 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5649 * sysdep.c: Include allocator.h, careadlinkat.h.
5650 (emacs_no_realloc_allocator): New static constant.
5651 (emacs_readlink): New function.
fdb61804
PE
5652 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5653 ../lib/careadlinkat.h.
d1fdcab7 5654
f84c17c7
SM
56552011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5656
5657 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5658 first non-nil return value).
5659
ef3862ad
JD
56602011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5661
5662 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5663 if not defined (Bug#8403).
5664
376a7006
JB
56652011-04-02 Juanma Barranquero <lekktu@gmail.com>
5666
5667 * xdisp.c (display_count_lines): Remove parameter `start',
5668 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5669 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5670 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5671 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5672 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5673 and thereabouts. All callers changed.
5674 (get_per_char_metric): Remove parameter `f', unused since
5675 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5676
6ca3801d
JM
56772011-04-02 Jim Meyering <meyering@redhat.com>
5678
5679 do not dereference NULL upon failed strdup
5680 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5681 (ns_get_family): Likewise.
5682
d8e2b5ba
JB
56832011-04-02 Juanma Barranquero <lekktu@gmail.com>
5684
5685 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5686
8c74fcbd
JD
56872011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5688
5689 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5690 later (Bug#8403).
5691
7200d79c
SM
56922011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5693
03408648 5694 Add lexical binding.
7200d79c 5695
03408648
SM
5696 * window.c (Ftemp_output_buffer_show): New fun.
5697 (Fsave_window_excursion):
5698 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5699
5700 * lread.c (lisp_file_lexically_bound_p): New function.
5701 (Fload): Bind Qlexical_binding.
5702 (readevalloop): Remove `evalfun' arg.
5703 Bind Qinternal_interpreter_environment.
5704 (Feval_buffer): Bind Qlexical_binding.
5705 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5706 Mark as dynamic.
5707 (syms_of_lread): Declare `lexical-binding'.
5708
5709 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5710
5711 * keyboard.c (eval_dyn): New fun.
5712 (menu_item_eval_property): Use it.
ca105506
SM
5713
5714 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5715
03408648
SM
5716 * fns.c (concat, mapcar1): Accept byte-code-functions.
5717
5718 * eval.c (Fsetq): Handle lexical vars.
5719 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5720 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5721 (FletX, Flet): Obey lexical binding.
5722 (Fcommandp): Handle closures.
5723 (Feval): New `lexical' arg.
5724 (eval_sub): New function extracted from Feval. Use it almost
5725 everywhere where Feval was used. Look up vars in lexical env.
5726 Handle closures.
5727 (Ffunctionp): Move from subr.el.
5728 (Ffuncall): Handle closures.
5729 (apply_lambda): Remove `eval_flags'.
5730 (funcall_lambda): Handle closures and new byte-code-functions.
5731 (Fspecial_variable_p): New function.
5732 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5733 but without exporting it to Lisp.
23aba0ea 5734
23aba0ea 5735 * doc.c (Fdocumentation, store_function_docstring):
03408648 5736 * data.c (Finteractive_form): Handle closures.
23aba0ea 5737
03408648
SM
5738 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5739 interactive spec.
ba83908c 5740
04f2d78b
CB
5741 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5742 New byte-codes.
03408648
SM
5743 (exec_byte_code): New function extracted from Fbyte_code to handle new
5744 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5745
03408648 5746 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5747
03408648 5748 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5749
e2abce01
JB
57502011-03-31 Juanma Barranquero <lekktu@gmail.com>
5751
5752 * xdisp.c (redisplay_internal): Fix prototype.
5753
63696a73 57542011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5755
63696a73 5756 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5757 (try_scrolling): Use it when setting scroll_limit.
5758 Limit scrolling to 100 screen lines.
63696a73
EZ
5759 (redisplay_window): Even when falling back on "recentering",
5760 position point in the window according to scroll-conservatively,
5761 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5762
5763 (try_scrolling): When point is above the window, allow searching
5764 as far as scroll_max, or one screenful, to compute vertical
5765 distance from PT to the scroll margin position. This prevents
5766 try_scrolling from unnecessarily failing when
5767 scroll-conservatively is set to a value slightly larger than the
5768 window height. Clean up the case of PT below the margin at bottom
5769 of window: scroll_max can no longer be INT_MAX. When aggressive
5770 scrolling is in use, don't let point enter the opposite scroll
5771 margin as result of the scroll.
5772 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5773 threshold of 100 lines for never-recentering scrolling.
5774
e4cc2dfc
JB
57752011-03-31 Juanma Barranquero <lekktu@gmail.com>
5776
5777 * dispextern.h (move_it_by_lines):
5778 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5779 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5780 (message_log_check_duplicate): Remove parameters `prev_bol' and
5781 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5782 (redisplay_internal): Remove parameter `preserve_echo_area',
5783 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5784
5785 * indent.c (Fvertical_motion):
5786 * window.c (window_scroll_pixel_based, Frecenter):
5787 Don't pass `need_y_p' to `move_it_by_lines'.
5788
1c470562
SM
57892011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5790
44f230aa
SM
5791 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5792 steal a few bits to be more compact.
5793 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5794 Remove unneeded casts.
5795
1c470562
SM
5796 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5797
888adce9
ZK
57982011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5799
5800 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5801 binding" message (bug#7967).
5802
f838ed7b
PE
58032011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5804
77861b95
PE
5805 Fix more problems found by GCC 4.6.0's static checks.
5806
de6dbc14
PE
5807 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5808 Remove unused local var.
5809
f838ed7b
PE
5810 * editfns.c (Fmessage_box): Remove unused local var.
5811
792c7b2b
PE
5812 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5813 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5814 Omit unused local vars.
c499e557 5815 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5816 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5817 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5818 Omit unused local var.
5819
ba0165e1
PE
5820 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5821 Don't assume string length fits in int.
32ad8845 5822 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5823 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5824
3c59b4c9
PE
5825 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5826 instead of alloca (Bug#8344).
5827
a3eed478 5828 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5829 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5830
eb4d412d
PE
5831 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5832
1658b401
PE
5833 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5834 concerns.
5835
5836 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5837
5838 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5839
9a2c6e05
PE
5840 * keyboard.c (syms_of_keyboard): Use the same style as later
5841 in this function when indexing through an array. This also
5842 works around GCC bug 48267.
5843
03d0a109
PE
5844 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5845
44f730c8
PE
5846 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5847
fe75f926
PE
5848 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5849 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5850
ffa8c828
PE
5851 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5852 This avoids undefined behavior on integer overflow, and is a bit
5853 more convenient anyway since it is compared to a size_t variable.
5854
c5101a77
PE
5855 Variadic C functions now count arguments with size_t, not int.
5856 This avoids an unnecessary limitation on 64-bit machines, which
5857 caused (substring ...) to crash on large vectors (Bug#8344).
5858 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5859 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5860 All variadic functions and their callers changed accordingly.
c5101a77
PE
5861 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5862 * data.c (arith_driver, float_arith_driver): Likewise.
5863 * editfns.c (general_insert_function): Likewise.
5864 * eval.c (struct backtrace.nargs, interactive_p)
5865 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5866 (funcall_lambda, mark_backtrace): Likewise.
5867 * fns.c (concat): Likewise.
5868 * frame.c (x_set_frame_parameters): Likewise.
5869 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5870 0 if not found, not -1. All callers changed.
5871
dd3f25f7
PE
5872 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5873 (stack_copy_size): Now size_t, not int.
5874 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5875
461c2ab9
JB
58762011-03-28 Juanma Barranquero <lekktu@gmail.com>
5877
5878 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5879 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5880 All callers changed.
5881
5882 * lisp.h (multibyte_char_to_unibyte):
5883 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5884 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5885 * character.h (CHAR_TO_BYTE8):
5886 * cmds.c (internal_self_insert):
5887 * editfns.c (general_insert_function):
5888 * keymap.c (push_key_description):
5889 * search.c (Freplace_match):
5890 * xdisp.c (message_dolog, set_message_1): All callers changed.
5891
f6d62986
SM
58922011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5893
5894 * keyboard.c (safe_run_hook_funcall): New function.
5895 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5896 don't set the hook to nil, but remove the offending function instead.
5897 (Qcommand_hook_internal): Remove, unused.
5898 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5899 Vcommand_hook_internal.
5900
5901 * eval.c (enum run_hooks_condition): Remove.
5902 (funcall_nil, funcall_not): New functions.
5903 (run_hook_with_args): Call each function through a `funcall' argument.
5904 Remove `cond' argument, now redundant.
5905 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5906 (Frun_hook_with_args_until_failure): Adjust accordingly.
5907 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5908
1db5b1ad
JB
59092011-03-28 Juanma Barranquero <lekktu@gmail.com>
5910
5911 * dispextern.h (string_buffer_position): Remove declaration.
5912
5913 * print.c (strout): Remove parameter `multibyte', unused since
5914 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5915
5916 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5917 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5918 All callers changed.
5919
5920 * w32.c (_wsa_errlist): Use braces for struct initializers.
5921
5922 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5923 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5924 All callers changed.
5925 (string_buffer_position): Likewise. Also, make static (it's never
5926 used outside xdisp.c).
5927 (cursor_row_p): Remove parameter `w', unused since
5928 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5929 (decode_mode_spec): Remove parameter `precision', introduced during
5930 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5931 All callers changed.
5932
5ffb62aa
JD
59332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5934
5935 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5936
461c2ab9 59372011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5938
5939 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5940 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5941 (ns_update_auto_hide_menu_bar): New functions.
5942 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5943 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5944 ns_constrain_all_frames.
5945 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5946 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5947
5c380ffb
JD
59482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5949
5950 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5951
9af30bdf
GM
59522011-03-27 Glenn Morris <rgm@gnu.org>
5953
5954 * syssignal.h: Replace RETSIGTYPE with void.
5955 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5956 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5957 Replace SIGTYPE with void everywhere.
5958 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5959 * s/template.h (SIGTYPE): Remove commented out definition.
5960
e2abce01
JB
59612011-03-26 Eli Zaretskii <eliz@gnu.org>
5962
5963 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5964 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5965
f868cd8a
JB
59662011-03-26 Juanma Barranquero <lekktu@gmail.com>
5967
59eb0929
JB
5968 * w32.c (read_unc_volume): Use parameter `henum', instead of
5969 global variable `wget_enum_handle'.
5970
5971 * keymap.c (describe_vector): Remove parameters `indices' and
5972 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5973 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5974
f868cd8a
JB
5975 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5976
5977 * keyboard.c (timer_check): Remove parameter `do_it_now',
5978 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5979 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5980 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5981
5982 * keyboard.c (read_char):
5983 * w32menu.c (w32_menu_display_help):
5984 * xmenu.c (show_help_event, menu_help_callback):
5985 Adjust calls to `show_help_echo'.
5986
5987 * gtkutil.c (xg_maybe_add_timer):
5988 * keyboard.c (readable_events):
5989 * process.c (wait_reading_process_output):
5990 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5991
5992 * insdel.c (adjust_markers_gap_motion):
5993 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5994 (gap_left, gap_right): Don't call it.
5995
2ecf6fdb
CY
59962011-03-25 Chong Yidong <cyd@stupidchicken.com>
5997
5998 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5999 incurred during fontification.
6000
6b1f9ba4
JB
60012011-03-25 Juanma Barranquero <lekktu@gmail.com>
6002
6003 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6004 (DEFVAR_PER_BUFFER): Don't pass it.
6005
6006 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6007 (scrolling_window): Don't pass it.
6008
0f4a96b5
JB
60092011-03-25 Juanma Barranquero <lekktu@gmail.com>
6010
6011 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6012
6013 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6014 and `suffix'.
6015 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6016 of variables specific to SELinux and computation of `encoded_absname'.
6017
6018 * image.c (XPutPixel): Remove unused variable `height'.
6019
6020 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6021
6022 * unexw32.c (get_section_info): Remove unused variable `section'.
6023
6024 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6025 (system_process_attributes): Remove unused variable `sess'.
6026 (sys_read): Remove unused variable `err'.
6027
6028 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6029 (w32_wnd_proc): Remove unused variable `isdead'.
6030 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6031 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6032 (x_create_tip_frame): Remove unused variable `tem'.
6033
6034 * w32inevt.c (w32_console_read_socket):
6035 Remove unused variable `no_events'.
6036
6037 * w32term.c (x_draw_composite_glyph_string_foreground):
6038 Remove unused variable `width'.
6039
1149507c
JB
60402011-03-24 Juanma Barranquero <lekktu@gmail.com>
6041
6042 * w32term.c (x_set_glyph_string_clipping):
6043 Don't pass uninitialized region to CombineRgn.
6044
9c88f339
JB
60452011-03-23 Juanma Barranquero <lekktu@gmail.com>
6046
6047 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6048 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6049 (Fx_close_connection): Remove unused variable `i'.
6050
6051 * w32font.c (w32font_draw): Return number of glyphs.
6052 (w32font_open_internal): Remove unused variable `i'.
6053 (w32font_driver): Add missing initializer.
6054
6055 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6056 (fill_in_menu): Remove unused variable `items_added'.
6057
6058 * w32term.c (last_mouse_press_frame): Remove static global variable.
6059 (w32_clip_to_row): Remove unused variable `f'.
6060 (x_delete_terminal): Remove unused variable `i'.
6061
6062 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6063 (NOTHING): Remove unused static global variable.
6064 (uniscribe_check_otf): Remove unused variable `table'.
6065 (uniscribe_font_driver): Add missing initializers.
6066
dee091a3
JD
60672011-03-23 Julien Danjou <julien@danjou.info>
6068
6069 * term.c (Fsuspend_tty, Fresume_tty):
6070 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6071 * window.c (temp_output_buffer_show):
6072 * insdel.c (signal_before_change):
6073 * frame.c (Fhandle_switch_frame):
6074 * fileio.c (Fdo_auto_save):
6075 * emacs.c (Fkill_emacs):
6076 * editfns.c (save_excursion_restore):
6077 * cmds.c (internal_self_insert):
6078 * callint.c (Fcall_interactively):
6079 * buffer.c (Fkill_all_local_variables):
6080 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6081 Use Frun_hooks.
0f4a96b5 6082 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6083 unconditionnaly since it does the check itself.
6084
2c520ab5 60852011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6086
c9c49752
PE
6087 Fix more problems found by GCC 4.5.2's static checks.
6088
8abc3f12
PE
6089 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6090 the first time through the loop, since we know p0 < p1 then.
6091 This also avoids a gcc -Wstrict-overflow warning.
6092
a2d26660
PE
6093 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6094 leading to a memory leak, possible in functions like
6095 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6096 of objects (Bug#8318).
a2d26660 6097
916c72e9
PE
6098 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6099 that could (at least in theory) be that large.
6100
19ab8a18
PE
6101 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6102 This is less likely to overflow, and avoids undefined behavior if
6103 overflow does occur. All callers changed. Use strtoul to scan
6104 for the unsigned long integer.
b7cbbd6f
PE
6105 (pint2hrstr): Simplify and tune code slightly.
6106 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6107
f0641eff
PE
6108 * scroll.c (do_scrolling): Work around GCC bug 48228.
6109 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6110
7f650bb9
PE
6111 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6112 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6113 (validate_x_resource_name): Simplify count usage.
6114 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6115
37dd57d1
PE
6116 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6117 fail (Bug#8306).
81e56e61 6118
699979fc 6119 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6120
401bf9b4
PE
6121 * process.c (Fmake_network_process): Use socklen_t, not int,
6122 where POSIX says socklen_t is required in portable programs.
6123 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6124 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6125 (Fmake_network_process, server_accept_connection):
6126 (wait_reading_process_output, read_process_output):
6127 Likewise.
6128
b93aacde
PE
6129 * process.c: Rename or move locals to avoid shadowing.
6130 (list_processes_1, Fmake_network_process):
6131 (read_process_output_error_handler, exec_sentinel_error_handler):
6132 Rename or move locals.
4dc343ee 6133 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6134 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6135 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6136 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6137 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6138
af8a867c 6139 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6140 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6141 Include tparam.h instead, since it declares them.
af8a867c
PE
6142 * cm.h (PC): Remove extern decl; tparam.h now does this.
6143 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6144 * terminfo.c: Include tparam.h, to check interfaces.
6145 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6146 (tparam): Adjust signature to match interface in tparam.h;
6147 this removes some undefined behavior. Check that outstring and len
6148 are zero, which they always are with Emacs.
6149 * tparam.h (PC, BC, UP): New extern decls.
6150
0248044d 6151 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6152 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6153
8ff096c1 6154 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6155 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6156 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6157 (ftfont_list): Remove unused local.
49eaafba
PE
6158 (get_adstyle_property, ftfont_pattern_entity):
6159 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6160 Rename locals to avoid shadowing.
8ff096c1 6161
e2be39f6
PE
6162 * xfont.c (xfont_list_family): Mark var as initialized.
6163
c9735e30
PE
6164 * xml.c (make_dom): Now static.
6165
8f5201ae
PE
6166 * composite.c (composition_compute_stop_pos): Rename local to
6167 avoid shadowing.
b246f932
PE
6168 (composition_reseat_it): Remove unused locals.
6169 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6170 (composition_update_it): Mark var as initialized.
11b61122
PE
6171 (find_automatic_composition): Mark vars as initialized,
6172 with a FIXME (Bug#8290).
8f5201ae 6173
760fbc2c
PE
6174 character.h: Rename locals to avoid shadowing.
6175 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6176 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6177 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6178 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6179 to avoid shadowing.
6180
ff08eb85
PE
6181 * textprop.c (property_change_between_p): Remove; unused.
6182
fc7bf025
PE
6183 * intervals.c (interval_start_pos): Now static.
6184
235d7abc
PE
6185 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6186
44f230aa
SM
6187 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6188 Rename locals to avoid shadowing.
3e7d6594 6189
50060332
PE
6190 * sound.c (wav_play, au_play, Fplay_sound_internal):
6191 Fix pointer signedness.
d01f234b 6192 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6193 (wav_play): Initialize a variable to 0, to prevent undefined
6194 behavior (Bug#8278).
50060332 6195
c4fc4e30
PE
6196 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6197
918436ed
PE
6198 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6199
c939f91b
PE
6200 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6201 clobbering (Bug#8298).
b9c7f648
PE
6202 * sysdep.c (sys_subshell): Likewise.
6203 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6204
6bd8c144
PE
6205 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6206 This should get cleaned up, so that child_setup has the
6207 same signature on all platforms.
6208
7710357c 6209 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6210 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6211
c59da222
CY
62122011-03-22 Chong Yidong <cyd@stupidchicken.com>
6213
6214 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6215 not to be necessary, and produces flickering.
6216
66b87493
GM
62172011-03-20 Glenn Morris <rgm@gnu.org>
6218
6219 * config.in: Remove file.
6220
45b6f6d5
JB
62212011-03-20 Juanma Barranquero <lekktu@gmail.com>
6222
6223 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6224 are now in src/globals.h.
6225 (syms_of_minibuf): Remove spurious & from previous change.
6226
3ec03f7e
LL
62272011-03-20 Leo <sdl.web@gmail.com>
6228
6229 * minibuf.c (completing-read-function): New variable.
6230 (completing-read-default): Rename from completing-read.
6231 (completing-read): Call completing-read-function.
6232
b14e3e21
CY
62332011-03-19 Juanma Barranquero <lekktu@gmail.com>
6234
6235 * xfaces.c (Fx_load_color_file):
6236 Read color file from absolute filename (bug#8250).
6237
f2b726e6
JB
62382011-03-19 Juanma Barranquero <lekktu@gmail.com>
6239
6240 * makefile.w32-in: Update dependencies.
6241
09f6ff02
EZ
62422011-03-17 Eli Zaretskii <eliz@gnu.org>
6243
6244 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6245
29a6015a
PE
62462011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6247
a3a6c54e
PE
6248 Fix more problems found by GCC 4.5.2's static checks.
6249
b766f867
PE
6250 * process.c (make_serial_process_unwind, send_process_trap):
6251 (sigchld_handler): Now static.
6252
be02381c
PE
6253 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6254 That way, the code declares only the vars that it needs.
6255 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6256 * s/cygwin.h (PTY_ITERATION): Likewise.
6257 * s/darwin.h (PTY_ITERATION): Likewise.
6258 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6259
57048744
PE
6260 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6261 * process.c (allocate_pty): Don't declare stb unless it's needed.
6262
7914961c 6263 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6264 (CONSTANTLIM): Remove; unused.
6265 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6266 Define only if needed.
7914961c 6267
b3967b18
PE
6268 * unexelf.c (unexec): Name an expression,
6269 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6270 Use a different way to cause a compilation error if anyone uses
6271 n rather than nn, a way that does not involve shadowing.
73366a00 6272 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6273
29a6015a
PE
6274 * deps.mk (unexalpha.o): Remove; unused.
6275
43cfc33e 6276 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6277 * unexec.h: New file.
ce701a33
PE
6278 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6279 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6280 Depend on unexec.h.
6281 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6282 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6283 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6284 Change as necessary to match prototype in unexec.h.
ce701a33 6285
01f44d5a
PE
6286 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6287 shadowing.
4f63c6bb 6288 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6289
a6670b0b
PE
6290 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6291 Rename locals to avoid shadowing.
6292
cef2010d 6293 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6294 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6295
d4d7173a
PE
6296 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6297
f08b802a
PE
6298 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6299 warning when compiling print.c.
6300
3ddb0639
PE
6301 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6302 instead of using an uninitialized var.
5ad03b97 6303 (font_sort_entities): Mark var as initialized.
3ddb0639 6304
170a2692
PE
6305 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6306
e663c700
PE
6307 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6308 pointers to constants.
89bc529a 6309 (font_parse_fcname): Remove unused vars.
7b81e2d0 6310 (font_delete_unmatched): Now static.
ea838e10 6311 (font_get_spec): Remove; unused.
13a547c6
PE
6312 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6313 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6314 Rename or move locals to avoid shadowing.
e663c700 6315
2a80c887 6316 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6317 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6318
1384fa33 6319 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6320 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6321
8b2c52e9
PE
6322 * alloc.c (mark_backtrace): Move decl from here ...
6323 * lisp.h: ... to here, so that it can be checked.
6324
475545b5 6325 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6326 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6327 (lisp_indirect_variable): Name an expression,
6328 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6329 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6330
b1349114 6331 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6332 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6333 Use const pointer when appropriate.
b1349114 6334
a2928364
PE
6335 * lisp.h (get_system_name, get_operating_system_release):
6336 Move decls here, to check interfaces.
6337 * process.c (get_operating_system_release): Move decl to lisp.h.
6338 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6339 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6340 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6341 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6342 (Fformat_time_string, Fencode_time, Finsert_char):
6343 (Ftranslate_region_internal, Fformat):
6344 Rename or remove local vars to avoid shadowing.
9710023e 6345 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6346
a415e694
PE
6347 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6348 avoid shadowing.
6349
8ef4622d
PE
6350 * lisp.h (eassert): Check that the argument compiles, even if
6351 ENABLE_CHECKING is not defined.
6352
946f9a5b
PE
6353 * data.c (Findirect_variable): Name an expression, to avoid
6354 gcc -Wbad-function-cast warning.
112396d6 6355 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6356 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6357 (Fmake_variable_buffer_local, Fmake_local_variable):
6358 Mark variables as initialized.
52746918 6359 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6360
e5aab7e7 6361 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6362 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6363 Rename locals to avoid shadowing.
dff45157
PE
6364 (mark_stack): Move local variables into the #ifdef region where
6365 they're used.
7bc26fdb
PE
6366 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6367 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6368 needed otherwise.
6369 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6370 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6371 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6372
e5aab7e7
PE
6373 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6374 avoids undefined behavior in theory.
6375
4da60324
PE
6376 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6377
88043301
PE
6378 Use functions, not macros, for up- and down-casing (Bug#8254).
6379 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6380 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6381 to use the following functions instead of these macros.
6382 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6383 EMACS_INT, since callers assume the returned value fits in int.
6384 (upcase1): Likewise, for UPCASE_TABLE.
6385 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6386 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6387 the race-condition problem in the old DOWNCASE.
88043301 6388
19ed5445
PE
6389 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6390 Rename locals to avoid shadowing.
6391 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6392 (regex_compile, re_search_2, re_match_2_internal):
6393 Remove unused local vars.
952db0d7
PE
6394 (FREE_VAR): Rewrite so as not to use empty "else",
6395 which gcc can warn about.
da053e48 6396 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6397 (RETALLOC_IF): Define only if needed.
6398 (WORDCHAR_P): Likewise. This one is never needed, but is used
6399 only in a comment talking about a compiler bug, so put inside
6400 the #if 0 of that comment.
6401 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6402 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6403 Remove; unused.
19ed5445 6404
1f3561e4 6405 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6406 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6407 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6408
ded6f8f7
PE
6409 * search.c (simple_search): Remove unused var.
6410
dbd37a95
PE
6411 * dired.c (compile_pattern): Move decl from here ...
6412 * lisp.h: ... to here, so that it can be checked.
6413 (struct re_registers): New forward decl.
6414
7e47afad
PE
6415 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6416
85f24f61
PE
6417 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6418 All uses changed.
6419 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6420 Rename locals to avoid shadowing.
5671df8f 6421 (Fvertical_motion): Mark locals as initialized.
85f24f61 6422
181aa2be 6423 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6424 (casify_region): Mark local as initialized.
181aa2be 6425
930d429c
PE
6426 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6427
7082eac6
PE
6428 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6429 New macros, so that the caller can use some names other than
6430 gcpro1, gcpro2, etc.
6431 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6432 of the new macros.
6433 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6434 argument, for consistency with GCPRO2_VAR, etc: it is now the
6435 prefix of the variable, not the variable itself. All uses
6436 changed.
38b2c076
PE
6437 * dired.c (directory_files_internal, file_name_completion):
6438 Rename locals to avoid shadowing.
6439
15206ed9
PE
6440 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6441 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6442 dired.c's scmp function, had undefined behavior.
6443 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6444 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6445 * buffer.h: ... to here, because these macros use current_buffer,
6446 and the new implementation with inline functions needs to have
6447 current_buffer in scope now, rather than later when the macros
6448 are used.
6449 (downcase, upcase1): New static inline functions.
6450 (DOWNCASE, UPCASE1): Reimplement using these functions.
6451 This avoids undefined behavior in expressions like
6452 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6453 from race conditions in accessing the global variables
6454 case_temp1 and case_temp2.
6455 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6456 * lisp.h (case_temp1, case_temp2): Remove their decls.
6457 * character.h (ASCII_CHAR_P): Move from here ...
6458 * lisp.h: ... to here, so that the inline functions mentioned
6459 above can use them.
6460
4a6bea26
PE
6461 * dired.c (directory_files_internal_unwind): Now static.
6462
f14b7e14
PE
6463 * fileio.c (file_name_as_directory, directory_file_name):
6464 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6465 Now static.
2893f146
PE
6466 (file_name_as_directory): Use const pointers when appropriate.
6467 (Fexpand_file_name): Likewise. In particular, newdir might
6468 point at constant storage, so make it a const pointer.
fd4ead52 6469 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6470 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6471 signedness issues.
f839df0c
PE
6472 (Fset_file_times, Finsert_file_contents, auto_save_error):
6473 Rename locals to avoid shadowing.
f14b7e14 6474
5716756e 6475 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6476 (Ftry_completion, Fall_completions): Rename or remove locals
6477 to avoid shadowing.
5716756e 6478
b4c3046a
PE
6479 * marker.c (bytepos_to_charpos): Remove; unused.
6480
b45db522
PE
6481 * lisp.h (verify_bytepos, count_markers): New decls,
6482 so that gcc does not warn that these functions aren't declared.
6483
85876d07
PE
6484 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6485 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6486 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6487 (copy_text): Remove unused local var.
85876d07 6488
03d78a21 6489 * filelock.c (within_one_second): Now static.
b3dd38ab 6490 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6491
5df8f01b
PE
6492 * buffer.c (fix_overlays_before): Mark locals as initialized.
6493 (fix_start_end_in_overlays): Likewise. This function should be
6494 simplified by using pointers-to-pointers, but that's a different
6495 matter.
b1d876f1 6496 (switch_to_buffer_1): Now static.
8f54f30a
PE
6497 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6498 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6499
a70072c9 6500 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6501 Fix pointer signedness issue.
edced198
PE
6502 (sys_subshell): Mark local as volatile if checking for lint,
6503 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6504 (MAXPATHLEN): Define only if needed.
a70072c9 6505
a0977c44
PE
6506 * process.c (serial_open, serial_configure): Move decls from here ...
6507 * systty.h: ... to here, so that they can be checked.
6508
a884fdcc
PE
6509 * fns.c (get_random, seed_random): Move extern decls from here ...
6510 * lisp.h: ... to here, so that they can be checked.
6511
604efe86 6512 * sysdep.c (reset_io): Now static.
b8950c94 6513 (wait_for_termination_signal): Remove; unused.
604efe86 6514
38fc62d9
PE
6515 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6516 (copy_keymap_item, append_key, push_text_char_description):
6517 Now static.
1004a21a 6518 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6519 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6520 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6521 (describe_map_tree):
6522 Rename locals to avoid shadowing.
38fc62d9 6523
2f2650da
PE
6524 * keyboard.c: Declare functions static if they are not used elsewhere.
6525 (echo_char, echo_dash, cmd_error, top_level_2):
6526 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6527 (read_char, kbd_buffer_get_event, make_lispy_position):
6528 (make_lispy_event, make_lispy_movement, apply_modifiers):
6529 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6530 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6531 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6532 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6533 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6534
a053e86c 6535 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6536 (mark_kboards): Move decl here ...
6537 * alloc.c (mark_kboards): ... from here.
a053e86c 6538
4752793e
PE
6539 * lisp.h (force_auto_save_soon): New decl.
6540
74f10ca7 6541 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6542 (DEFINE_DUMMY_FUNCTION): New macro.
6543 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6544 Use it.
c03cd23f
PE
6545 (main): Add casts to avoid warnings
6546 if GCC considers string literals to be constants.
74f10ca7 6547
022e70d4
PE
6548 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6549
59d6fe83
PE
6550 * dbusbind.c: Pointer signedness fixes.
6551 (xd_signature, xd_append_arg, xd_initialize):
6552 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6553 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6554 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6555 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6556
78320123
PE
6557 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6558 if GCC considers string literals to be constants.
49cebcca 6559 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6560
35ac2a97
SM
65612011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6562
fb103ca9
SM
6563 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6564 (print_preprocess, print_object): New macro to fix last change.
6565
35ac2a97
SM
6566 * print.c (print_preprocess): Don't forget font objects.
6567
62973b41
JB
65682011-03-16 Juanma Barranquero <lekktu@gmail.com>
6569
6570 * emacs.c (USAGE3): Doc fixes.
6571
0e48bb22
AS
65722011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6573
6574 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6575 structure.
6576
7684e57b
JB
65772011-03-14 Juanma Barranquero <lekktu@gmail.com>
6578
6579 * lisp.h (VWindow_system, Qfile_name_history):
6580 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6581 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6582 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6583
6584 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6585 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6586
6587 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6588 * w32console.c (detect_input_pending, read_input_pending)
6589 (encode_terminal_code):
6590 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6591 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6592 (w32_system_caret_y, Qfile_name_history):
6593 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6594 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6595 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6596 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6597 * w32proc.c (Qlocal, report_file_error):
6598 * w32term.c (Vwindow_system, updating_frame):
6599 * w32uniscribe.c (initialized, uniscribe_font_driver):
6600 Remove unneeded extern declarations.
6601
2aa46d6c
CY
66022011-03-14 Chong Yidong <cyd@stupidchicken.com>
6603
c96bbc66 6604 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6605
cffc6f3b
CY
66062011-03-13 Chong Yidong <cyd@stupidchicken.com>
6607
6608 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6609 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6610 These macros can no longer be used for assignment.
6611
44f230aa
SM
6612 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6613 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6614 (record_buffer_markers, fetch_buffer_markers): New functions for
6615 recording and fetching special buffer markers.
6616 (set_buffer_internal_1, set_buffer_temp): Use them.
6617
6618 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6619
6620 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6621
6622 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6623 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6624
6625 * xdisp.c (hscroll_window_tree):
6626 (reconsider_clip_changes): Use PT instead of BUF_PT.
6627
d251f04b
EZ
66282011-03-13 Eli Zaretskii <eliz@gnu.org>
6629
6630 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6631 $(EMACS_ROOT)/lib/intprops.h.
6632
f0c77cd1
PE
66332011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6634
3eca4629
PE
6635 Fix more problems found by GCC 4.5.2's static checks.
6636
7c86ee98
PE
6637 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6638 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6639 (xg_free_frame_widgets): Make it clear that a local variable is
6640 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6641 (gdk_window_get_screen): Make it clear that this macro is needed
6642 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6643 (int_gtk_range_get_value): New function, which avoids a diagnostic
6644 from gcc -Wbad-function-cast.
6645 (xg_set_toolkit_scroll_bar_thumb): Use it.
6646 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6647 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6648 (get_utf8_string, xg_get_file_with_chooser):
6649 Rename locals to avoid shadowing.
6650 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6651
41729b81
PE
6652 * xgselect.c (xg_select): Remove unused var.
6653
f0c77cd1
PE
6654 * image.c (four_corners_best): Mark locals as initialized.
6655 (gif_load): Initialize transparent_p to zero (Bug#8238).
6656 Mark another local as initialized.
ec6cf4c6 6657 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6658
ce0ad53d 6659 * image.c (clear_image_cache): Now static.
d5d5a617 6660 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6661 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6662 (x_edge_detection): Remove unnecessary cast that
6663 gcc -Wbad-function-cast diagnoses.
2037898d 6664 (gif_load): Fix pointer signedness.
6ae141d6
PE
6665 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6666 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6667
33383987 66682011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6669
d32df629
PE
6670 Improve quality of tests for time stamp overflow.
6671 For example, without this patch (encode-time 0 0 0 1 1
6672 1152921504606846976) returns the obviously-bogus value (-948597
6673 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6674 reports time overflow. See
6675 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6676 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6677 * editfns.c: Include limits.h and intprops.h.
6678 (TIME_T_MIN, TIME_T_MAX): New macros.
6679 (time_overflow): Move earlier, to before first use.
6680 (hi_time, lo_time): New functions, for an accurate test for
6681 out-of-range times.
6682 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6683 (Fget_internal_run_time): Don't assume time_t fits in int.
6684 (make_time): Use list2 instead of Fcons twice.
6685 (Fdecode_time): More accurate test for out-of-range times.
6686 (check_tm_member): New function.
6687 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6688 (lisp_time_argument): Don't rely on undefined left-shift and
6689 right-shift behavior when checking for time stamp overflow.
8be6f318 6690
fe31d94c
PE
6691 * editfns.c (time_overflow): New function, refactoring common code.
6692 (Fformat_time_string, Fdecode_time, Fencode_time):
6693 (Fcurrent_time_string): Use it.
6694
8be6f318
PE
6695 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6696 * dired.c (make_time): Move to ...
6697 * editfns.c (make_time): ... here.
6698 * systime.h: Note the move.
6699
09d9db2c 67002011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6701
126bc0dc
YM
6702 * fringe.c (update_window_fringes): Remove unused variables.
6703
c47cbdfd
YM
6704 * unexmacosx.c (copy_data_segment): Also copy __got section.
6705 (Bug#8223)
6706
7ac80be9
EZ
67072011-03-12 Eli Zaretskii <eliz@gnu.org>
6708
c96bbc66 6709 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6710 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6711 Constify `char *' arguments and their references according to
6712 prototypes in tparam.h.
6713
ecb0f94d 6714 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6715
7ac80be9
EZ
6716 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6717 Adapt all references accordingly.
6718
6719 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6720
ef1fd07e
TT
67212011-03-11 Tom Tromey <tromey@redhat.com>
6722
6723 * buffer.c (syms_of_buffer): Remove obsolete comment.
6724
7ef4b50c
EZ
67252011-03-11 Eli Zaretskii <eliz@gnu.org>
6726
6727 * termhooks.h (encode_terminal_code): Declare prototype.
6728
6729 * msdos.c (encode_terminal_code): Don't declare prototype.
6730
6731 * term.c (encode_terminal_code): Now external again, used by
6732 w32console.c and msdos.c.
6733
44f230aa
SM
6734 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6735 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6736
4b1ec863 67372011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6738
1714f52b 6739 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6740
4b1ec863
PE
6741 * fringe.c (update_window_fringes): Mark locals as initialized
6742 (Bug#8227).
6743 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6744
524c7aa6
PE
6745 * alloc.c (mark_fringe_data): Move decl from here ...
6746 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6747 to check its interface.
6748 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6749
a5c0af81 6750 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6751 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6752 (fontset_font): Mark local as initialized.
a9a06e0b 6753 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6754
b4716021
PE
6755 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6756
811e9bac 6757 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6758 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6759 (x_own_selection, Fx_disown_selection_internal): Rename locals
6760 to avoid shadowing.
6761 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6762
7e3ab302
PE
6763 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6764 so that the caller can use some name other than gcpro1.
6765 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6766 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6767 (Fx_backspace_delete_keys_p):
6768 Use them to avoid shadowing, and rename vars to avoid shadowing.
6769 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6770 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6771 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6772 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6773 Remove unused locals.
7e3ab302
PE
6774 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6775 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6776 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6777 macros.
f78faa98 6778
e2b13473
PE
6779 * xterm.h (x_mouse_leave): New decl.
6780
77f23912
PE
6781 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6782 Remove unused functions.
cdf4ba58
PE
6783 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6784 (x_calc_absolute_position): Now static.
7411c686 6785 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6786 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6787 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6788 unless they are used.
38d0b34a
PE
6789 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6790 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6791 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6792 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6793 (x_error_catcher, x_connection_closed, x_error_handler):
6794 (x_error_quitter, xembed_send_message, x_iconify_frame):
6795 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6796 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6797 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6798
44f230aa
SM
6799 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6800 Rename or move locals to avoid shadowing.
6b463e58 6801 (tty_defined_color, merge_face_heights): Now static.
5967d051 6802 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6803 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6804 does not deduce is never used uninitialized.
73719eba
PE
6805 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6806 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6807
426994c3 6808 * terminal.c (store_terminal_param): Now static.
5489860b 6809
032f1620 6810 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6811 (set_frame_menubar): Remove unused local.
d4323972 6812 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6813 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6814 since they might point to immutable storage.
281585b0
PE
6815 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6816 since it's unused otherwise.
032f1620 6817
367c19e5 6818 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6819 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6820 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6821 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6822 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6823 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6824 does not deduce are never used uninitialized.
70739cbe 6825
07b48fa9
PE
6826 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6827
8868a238 6828 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6829 * window.c (window_loop, size_window):
6830 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6831
7e5cf297 6832 * window.c (display_buffer): Now static.
d6550a9f
PE
6833 (size_window): Mark variables that gcc -Wuninitialized
6834 does not deduce are never used uninitialized.
a586633d
PE
6835 * window.h (check_all_windows): New decl, to forestall
6836 gcc -Wmissing-prototypes diagnostic.
5b555da1 6837 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6838
f6095868
PE
6839 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6840 shadowing.
6841 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6842 Include <limits.h>.
6843 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6844 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6845 (load_charset_map): Mark variables that gcc -Wuninitialized
6846 does not deduce are never used uninitialized.
53df7c11 6847 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6848
f38b440c
PE
6849 * coding.c (coding_set_source, coding_set_destination):
6850 Use "else { /* comment */ }" rather than "else /* comment */;"
6851 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6852 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6853 a block, when the outer 'i' will do.
6854 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6855 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6856 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6857 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6858 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6859 Rename locals to avoid shadowing.
6860 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6861 * coding.c (emacs_mule_char, encode_invocation_designation):
6862 Now static, since they're not used elsewhere.
413bb2db 6863 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6864 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6865 (decode_coding_emacs_mule): Mark variables that gcc
6866 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6867 (detect_coding_iso_2022): Initialize a local variable that might
6868 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6869 this initialization is needed. (Bug#8211)
5f58e762
PE
6870 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6871 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6872 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6873 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6874 Remove unused macros.
f38b440c 6875
232b38b9 6876 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6877 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6878 * character.c (string_count_byte8): Likewise.
232b38b9 6879
fb90da1b
PE
6880 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6881 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6882
fb93dbc2
PE
6883 * chartab.c (copy_sub_char_table): Now static, since it's not used
6884 elsewhere.
5c156ace
PE
6885 (sub_char_table_ref_and_range, char_table_ref_and_range):
6886 Rename locals to avoid shadowing.
bbcd0949 6887 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6888
7d3b3862 6889 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6890 (BIDI_BOB): Remove unused macro.
7d3b3862 6891
6be7d3da
PE
6892 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6893 deduce are never used uninitialized.
c2ed9c8b 6894 * term.c (encode_terminal_code): Likewise.
6be7d3da 6895
75f8807f 6896 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6897
50938595
PE
6898 * tparam.h: New file.
6899 * term.c, tparam.h: Include it.
6900 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6901 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6902 Move these decls to tparam.h, and make them agree with what
6903 is actually in tparam.c. The previous trick of using incompatible
6904 decls in different modules does not conform to the C standard.
6905 All callers of tparam changed to use tparam's actual API.
6906 * tparam.c (tparam1, tparam, tgoto):
6907 Use const pointers where appropriate.
6908
fbceeba2
PE
6909 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6910 * cm.h (struct cm): Likewise.
6911 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6912 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6913 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6914 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6915 (turn_on_face, init_tty): Likewise.
6916 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6917
7f3f1250
PE
6918 * term.c (term_mouse_position): Rename local to avoid shadowing.
6919
e6ca6543
PE
6920 * alloc.c (mark_ttys): Move decl from here ...
6921 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6922
c40f8d15
AS
69232011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6924
6925 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6926
cfe0661d
JB
69272011-03-09 Juanma Barranquero <lekktu@gmail.com>
6928
6929 * search.c (compile_pattern_1): Remove argument regp, unused since
6930 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6931 (compile_pattern): Don't pass it.
6932
0afb4571
J
69332011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6934
6935 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6936 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6937 for ! HAVE_GTK3.
6938 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6939
6940 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6941
6942 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6943 gdk_window_get_screen, gdk_window_get_geometry,
6944 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6945 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6946 (xg_get_pixbuf_from_pixmap): New function.
6947 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6948 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6949 Call xg_get_pixbuf_from_pixmap instead of
6950 gdk_pixbuf_get_from_drawable.
6951 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6952 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6953 (xg_check_special_colors): Use GtkStyleContext and its functions
6954 for HAVE_GTK3.
6955 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6956 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6957 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6958 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6959 Call gtk_widget_get_preferred_size.
0afb4571
J
6960 (xg_frame_resized): gdk_window_get_geometry only takes 5
6961 parameters.
44f230aa
SM
6962 (xg_win_to_widget, xg_event_is_for_menubar):
6963 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6964 (xg_set_widget_bg): New function.
6965 (delete_cb): New function.
895009e1 6966 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6967 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6968 (xg_set_background_color): Call xg_set_widget_bg.
6969 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6970 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6971 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6972 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6973 if ! HAVE_GTK3.
6974 (update_frame_tool_bar): Call gtk_widget_hide.
6975 (xg_initialize): Use GDK_KEY_g.
6976
6977 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6978 if ! HAVE_GTK3
6979 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6980
6981 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6982 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6983 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6984
1c2cc4ef
JB
69852011-03-08 Juanma Barranquero <lekktu@gmail.com>
6986
6987 * w32xfns.c (select_palette): Check success of RealizePalette against
6988 GDI_ERROR, not zero.
6989
33383987 6990See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6991
6992;; Local Variables:
6993;; coding: utf-8
aac0c6e3
MR
6994;; End:
6995
33383987 6996 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6997
6998 This file is part of GNU Emacs.
6999
7000 GNU Emacs is free software: you can redistribute it and/or modify
7001 it under the terms of the GNU General Public License as published by
7002 the Free Software Foundation, either version 3 of the License, or
7003 (at your option) any later version.
7004
7005 GNU Emacs is distributed in the hope that it will be useful,
7006 but WITHOUT ANY WARRANTY; without even the implied warranty of
7007 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7008 GNU General Public License for more details.
7009
7010 You should have received a copy of the GNU General Public License
7011 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.