Fix data type casting when setting up menus on Windows.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2d5c5f7d
EZ
12012-07-21 Eli Zaretskii <eliz@gnu.org>
2
3 * w32menu.c (add_menu_item): Cast to UINT_PTR when assigning
4 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
5 Fabrice Popineau <fabrice.popineau@supelec.fr>.
6
c4328746
JD
72012-07-21 Jan Djärv <jan.h.d@swipnet.se>
8
9 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 10 (conversationIdentifier): Return value is NSInteger.
784051c4 11 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 12
6e5d1c12
CY
132012-07-21 Chong Yidong <cyd@gnu.org>
14
15 * window.c (decode_any_window): Signal an error if the window is
16 on a dead frame (Bug#11984).
17
9928463d
DA
182012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
19
20 Add indirection counting to speed up Fkill_buffer.
21 * buffer.h (struct buffer): New member.
22 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
23 (Fmake_indirect_buffer): Set indirection counter to -1, increment
24 base buffer indirection counter.
25 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
26 (Fkill_buffer): Adjust indirection counters as needed, don't walk
27 through buffer list if indirection counter is 0.
28
f8643a6b
DA
292012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
30
31 Extend the value returned by Fgarbage_collect with heap statistics.
32 * alloc.c (Qheap): New symbol.
33 (syms_of_alloc): DEFSYM it.
34 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
35 (Fmemory_free): Remove.
36 (syms_of_alloc): Don't defsubr it.
37 * buffer.c (Fcompact_buffer): Remove.
38 (syms_of_buffer): Don't defsubr it.
39
dac616ff
DA
402012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
41
42 Make maybe_gc inline.
43 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
44 * lisp.h (consing_since_gc, gc_relative_threshold)
45 (memory_full_cons_threshold): Revert declaration.
46 (maybe_gc): Remove prototype, define as inline.
47 * alloc.c: Remove old commented-out code.
48 (consing_since_gc, gc_relative_threshold)
49 (memory_full_cons_threshold): Revert to global.
50 (maybe_gc): Remove.
51
d7ea76b4
DA
522012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
53
54 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
55 * lisp.h (build_unibyte_string): New function.
56 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
57 * sysdep.c, w32fns.c, xfns.c: Use it.
58 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
59 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
60 Adjust users accordingly.
61 * font.h (font_open_by_name): Adjust prototype.
62
765e61e3
DA
632012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
64
65 Cleanup calls to Fgarbage_collect.
66 * lisp.h (maybe_gc): New prototype.
67 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
68 Remove declarations.
69 * alloc.c (maybe_gc): New function.
70 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
71 Make them static.
72 * bytecode.c (MAYBE_GC): Use maybe_gc.
73 * eval.c (eval_sub, Ffuncall): Likewise.
74 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
75 to avoid dependency from auto-save feature.
76
52b852c7
PE
772012-07-19 Paul Eggert <eggert@cs.ucla.edu>
78
79 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
80 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
81 'for_each_per_buffer_object_at'.
82 All uses changed. It's better to use upper-case for macros that
83 cannot be implemented as functions, to give the reader a clue
84 that they're special.
85
5db81e33
SM
862012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
87
88 * alloc.c (Fgarbage_collect): Tweak docstring.
89
5b835e1d
DA
902012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
91
92 Tweak the value returned from Fgarbage_collect again.
93 * alloc.c (Fgarbage_collect): New return value, as confirmed in
94 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
95 Adjust documentation.
96 (total_vector_bytes): Rename to total_vector_slots, adjust
97 accounting.
98 (total_free_vector_bytes): Rename to total_free_vector_slots,
99 adjust accounting.
100 (Qstring_bytes, Qvector_slots): New symbols.
101 (syms_of_alloc): DEFSYM them.
102
9cd47b72
DA
1032012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
104
105 Buffer compaction primitive which may be used from Lisp.
106 * buffer.c (compact_buffer, Fcompact_buffer): New function.
107 (syms_of_buffer): Register Fcompact_buffer.
108 * alloc.c (Fgarbage_collect): Use compact_buffer.
109 * buffer.h (compact_buffer): New prototype.
110 (struct buffer_text): New member.
111
d17337e5
DA
1122012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
113
114 New macro to iterate over all buffers, miscellaneous cleanups.
115 * lisp.h (all_buffers): Remove declaration.
116 * buffer.h (all_buffers): Add declaration, with comment.
117 (for_each_buffer): New macro.
118 * alloc.c (Fgarbage_collect, mark_object): Use it.
119 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
120 (init_buffer): Likewise.
121 * data.c (Fset_default): Likewise.
122 * coding.c (code_conversion_restore): Remove redundant check
123 for dead buffer.
124 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
125
60cfd278
AS
1262012-07-18 Andreas Schwab <schwab@linux-m68k.org>
127
128 Fix bug that created negative-length intervals.
129 * intervals.c (merge_interval_right, merge_interval_left):
130 Do not zero out this interval if it is absorbed by its children,
131 as this interval's total length doesn't change in that case. See
132 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
133
d06714cb
PE
1342012-07-18 Paul Eggert <eggert@cs.ucla.edu>
135
83713154
PE
136 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
137 when invoking (make-bool-vector N t) and N is a positive
138 multiple of 8 -- the last 8 bits were mistakenly cleared.
139
d06714cb
PE
140 Remove some struct layout assumptions in bool vectors.
141 * alloc.c (bool_header_size): New constant.
142 (header_size, word_size): Move earlier, as they're now used earlier.
143 Use 'word_size' in a few more places, where it's appropriate.
144 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
145 padding before the data member of a bool vector.
146 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
147 than doing the check by hand with an abort ().
148
464d5a5e
SM
1492012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
150
5fbc0409
SM
151 * eval.c (Fdefvar): Don't check constants since we only set the var if
152 it's not yet defined anyway (bug#11904).
153
464d5a5e
SM
154 * lisp.h (last_undo_boundary): Declare new var.
155 * keyboard.c (command_loop_1): Set it.
156 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
157 were auto-added by the command loop (bug#11774).
158
8dc2e44a
AS
1592012-07-18 Andreas Schwab <schwab@linux-m68k.org>
160
161 * w32font.c (Qsymbol): Remove local definition.
162 (syms_of_w32font): Don't DEFSYM it.
163
169925ec
DA
1642012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
165
166 Fix sweep_vectors to handle large bool vectors correctly.
167 * alloc.c (sweep_vectors): Account total_vector_bytes for
168 bool vectors larger than VBLOCK_BYTES_MAX.
169
5fbfb018
CY
1702012-07-18 Chong Yidong <cyd@gnu.org>
171
172 * frame.c (x_set_frame_parameters): Revert bogus change introduced
173 in 2012-05-25 commit by Paul Eggert (Bug#11738).
174
3ab6e069
DA
1752012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
176
177 Return more descriptive data from Fgarbage_collect.
178 Suggested by Stefan Monnier in
179 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
180 * alloc.c (bounded_number): New function.
181 (total_buffers, total_vectors): New variable.
182 (total_string_size): Rename to total_string_bytes, adjust users.
183 (total_vector_size): Rename to total_vector_bytes, adjust users.
184 (sweep_vectors): Account total_vectors and total_vector_bytes.
185 (Fgarbage_collect): New return value. Adjust documentation.
186 (gc_sweep): Account total_buffers.
187 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
188 (VECTOR_SIZE): Remove.
189 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
190 (Qinterval, Qmisc): New symbols.
191 (syms_of_data): Initialize them.
192 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
193 (Qcons, Qbuffer): New declarations.
194
6d02fe5b
PE
1952012-07-17 Paul Eggert <eggert@cs.ucla.edu>
196
197 * alloc.c (Fmemory_free): Account for memory-free's own storage.
198 Round up, not down. Improve doc.
199
b7ffe040
DA
2002012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
201
202 Restore old code in allocate_string_data to avoid Faset breakage.
203 Reported by Julien Danjou <julien@danjou.info> in
204 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
205 * alloc.c (allocate_string_data): Restore old code with minor
206 adjustments, fix comment to explain this subtle issue.
207
4dc7c8d5
SM
2082012-07-17 Eli Zaretskii <eliz@gnu.org>
209
210 Remove FILE_SYSTEM_CASE.
211 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
212
213 * fileio.c (FILE_SYSTEM_CASE): Don't define.
214 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
215 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
216 call-process-region passes it through expand-file-name.
217
218 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
219
2202012-07-17 Andreas Schwab <schwab@linux-m68k.org>
221
222 Fix crash when creating indirect buffer (Bug#11917)
223 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
224 Don't handle unbound variables specially if non-zero.
225 (Fbuffer_local_variables): Pass zero.
226 (clone_per_buffer_values): Pass non-zero.
227
2282012-07-17 Andreas Schwab <schwab@linux-m68k.org>
229
230 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
231 to make the loop interruptible.
232
2332012-07-17 Andreas Schwab <schwab@linux-m68k.org>
234
235 * gnutls.c (emacs_gnutls_handshake): Only retry if
236 GNUTLS_E_INTERRUPTED.
237
cce7fefc
DA
2382012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
239
240 Cleanup and convert miscellaneous checks to eassert.
241 * alloc.c (mark_interval): Fix comment, partially rephrase
242 old comment from intervals.h (see below).
243 * intervals.c (find_interval, adjust_intervals_for_insertion)
244 (delete_interval, adjust_intervals_for_deletion)
245 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
246 Convert to eassert.
247 (adjust_intervals_for_insertion, make_new_interval):
248 Remove obsolete and unused code.
249 * intervals.h (struct interval): Remove obsolete comment.
250 * textprotp.c (erase_properties): Remove unused code.
251 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
252 (Fremove_list_of_text_properties): Convert to eassert.
253
9ea10cc3
CY
2542012-07-17 Chong Yidong <cyd@gnu.org>
255
256 * editfns.c (Finsert_char): Doc fix.
257
3900d5de
DA
2582012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
259
260 Fix previous change to make Fmemory_free always accurate.
261 * alloc.c (make_interval): Update total_free_intervals.
262 (make_float): Likewise for total_free_floats.
263 (free_cons, Fcons): Likewise for total_free_conses.
264 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
265 Likewise for total_free_vector_bytes.
266 (Fmake_symbol): Likewise for total_free_symbols.
267 (bytes_free): Remove.
268
7098646f
DA
2692012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
270
271 Simple free memory accounting feature.
272 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
273 (sweep_vectors): Accumulate size of free vectors.
274 (Fgarbage_collect): Setup bytes_free.
275 (Fmemory_free): New function.
276 (syms_of_alloc): Register it.
277
22657b40
DA
2782012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
279
280 Cleanup overlays checking.
281 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
282 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
283 eassert and OVERLAYP.
284 (sort_overlays): Change to use OVERLAYP.
285
ddfc8813
RK
2862012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
287
288 * editfns.c (Finsert_char): Make it interactive, and make the
289 second arg optional. Copy interactive spec and docstring from
290 ucs-insert.
291
7c26cf3c
PE
2922012-07-17 Paul Eggert <eggert@cs.ucla.edu>
293
294 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
295 Unlike the other wrapped functions, fabs has an unspecified
296 effect on errno.
297
5d127af9
JD
2982012-07-16 Jan Djärv <jan.h.d@swipnet.se>
299
300 * nsterm.m (keyDown): Interpret flags without left/right bits
301 as the left key (Bug#11670).
302
6a0dd1d7
DA
3032012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
304
305 Remove empty and useless init functions.
306 * lisp.h (init_character_once, init_fns, init_image)
307 (init_filelock, init_sound): Remove prototype.
308 * character.c (init_character_once): Remove.
309 * filelock.c (init_filelock): Likewise.
310 * fns.c (init_fns): Likewise.
311 * image.c (init_image): Likewise.
312 * sound.c (init_sound): Likewise.
313 * emacs.c (main): Adjust accordingly.
314
7a6136fd
DA
3152012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
316
317 * gtkutil.h: Tiny cleanups.
318 (use_old_gtk_file_dialog): Remove useless declaration.
319 (xg_uses_old_file_dialog): Add suggested const attribute.
320
ce811ad9
EZ
3212012-07-15 Eli Zaretskii <eliz@gnu.org>
322
323 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
324 (bidi_paragraph_init): Use it to limit search forward for a strong
325 directional character in abnormally large paragraphs full of
326 neutral or weak characters. (Bug#11943)
327
c9adfeaa
SF
3282012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
329
330 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
331 the toolbar (Bug#9451).
332 (xg_make_tool_item): Give the widget event box a transparent
333 background.
334
fff62aa9
DA
3352012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
336
337 Cleanup basic allocation variables and functions.
338 * alloc.c (ignore_warnings, init_intervals, init_float)
339 (init_cons, init_symbol, init_marker): Remove.
340 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
341 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
342 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
343 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
344 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
345 (staticidx, init_alloc_once, init_strings, free_ablock):
346 Remove redundant initialization.
347 * fns.c (init_weak_hash_tables): Remove.
348 * lisp.h (init_weak_hash_tables): Remove prototype.
349
9730daca
DA
3502012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
351
352 Use zero_vector where appropriate.
353 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
354 accordingly.
355 * lisp.h (zero_vector): New declaration.
356 * font.c (null_vector): Remove.
357 (syms_of_font): Remove initialization and staticpro.
358 (font_list_entities, font_find_for_lface): Change to use zero_vector.
359 * keymap.c (Faccessible_keymaps): Likewise.
360
2e2d2a13
LL
3612012-07-15 Leo Liu <sdl.web@gmail.com>
362
363 * fringe.c: Fix typo in comments.
364
cd276f6e
LL
3652012-07-14 Leo Liu <sdl.web@gmail.com>
366
367 * fringe.c: Add a new bitmap exclamation-mark.
368
5a1131d9
EZ
3692012-07-14 Eli Zaretskii <eliz@gnu.org>
370
371 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
372
373 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
374 (HAVE_MENUS): Don't define, defined by editing config.in with
375 msdos/sed2v2.inp.
376 (GMALLOC_INHIBIT_VALLOC): Don't define.
377 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
378
22e983b7
JB
3792012-07-14 Juanma Barranquero <lekktu@gmail.com>
380
381 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
382
5b3f250f
GM
3832012-07-14 Glenn Morris <rgm@gnu.org>
384
385 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
386 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
387 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
388
33d63ff4
GM
3892012-07-13 Glenn Morris <rgm@gnu.org>
390
5b633342
GM
391 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
392
33d63ff4
GM
393 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
394 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
395
b55b9f85
JD
3962012-07-13 Jan Djärv <jan.h.d@swipnet.se>
397
0dc8cf50
JD
398 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
399 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
400 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
401 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
402 where appropriate.
403 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
404 as boolean expression.
405 (x_set_window_size): Remove unused variable toolbar.
406 (ns_get_color_default, ns_mod_to_lisp): Remove.
407 (ns_mouse_position): Remove unused variables xchar and ychar.
408 (ns_compute_glyph_string_overhangs): Remove unused variable face.
409 (ns_set_vertical_scroll_bar): Remove unused variable count.
410 (ns_delete_terminal): Remove unused variable i.
411 (ns_term_init): Remove unused variables r, g and b.
412 (mouseDown): Remove unused variable window.
413 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
414 (initFrameFromEmacs): Remove unused variable vbextra.
415 (mouseEntered): Remove unused variables p and dpyinfo.
416 (mouseExited): Remove unused variables p and r.
417 (ns_define_frame_cursor, ns_clear_frame_area)
418 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
419 (menuDown): Assign [sender tag] to variable and cast the variable.
420
421 * nsterm.h (menuDown): Add id as type to argument sender.
422 (ns_display_info_for_name): Add Lisp_Object argument.
423 (ns_term_init): Add Lisp_Object argument.
424 (ns_map_event_to_object): Add void argument.
425 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
426 prototype with arguments and only declare if __OBJC__.
427 (nxatoms_of_nsselect): Add void argument.
428 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
429 (ns_alloc_autorelease_pool): Add void argument.
430 (ns_release_autorelease_pool): Add void* argument.
431 (ns_get_defaults_value): Add const char* argument.
432
433 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
434 (initFromContents): Use SSDATA where appropriate.
435 (ns_update_menubar): Add braces to ambigous if-else.
436 (initWithTitle): Put () around assignment in if statement.
437 (ns_menu_show): Remove unused variables window and keymap.
438 (update_frame_tool_bar): Remove unused variable selected_p.
439 (initWithContentRect): Remove unused variable this_cmd_name.
440
441 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
442 appropriate.
443 (setXBMColor): Remove unused variable len.
444 (setPixmapData): Put () around assignment in loop statement.
445
446 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
447 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
448 where appropriate.
449 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
450 around assignment in loop statement.
451 (nsfont_open): Remove unused variable i.
452 (nsfont_open): Remove unused variable len.
453 (nsfont_draw): Remove unused variable cs.
454
455 * nsfns.m (x_set_icon_name, ns_set_name_internal)
456 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
457 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
458 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
459 (Fns_font_name, Fns_perform_service)
460 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
461 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
462 (ns_set_name): Remove unused variable view.
463 (x_set_menu_bar_lines): Remove unused variable olines.
464 (x_set_tool_bar_lines): Remove unused variable root_window.
465 (Fns_list_colors): Put () around assignment in while statement.
466 (Fns_perform_service): Remove unused variable len.
467 (Fns_display_usable_bounds): Remove unused variable top.
468 (syms_of_nsfns): Remove unused variable i.
469
b55b9f85
JD
470 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
471 memcpy (Bug#11907).
472
ed9265fc 4732012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
474
475 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
476 and free it with DestroyExceptionInfo (Bug#11558).
477
ef099b57
JB
4782012-07-13 Juanma Barranquero <lekktu@gmail.com>
479
480 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
481 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
482 Set here, not in nt/config.nt.
483
ea814a5d
EZ
4842012-07-13 Eli Zaretskii <eliz@gnu.org>
485
486 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
487 cursor overflow into the last glyph on display line when the right
488 fringe is off. (Bug#11832)
489
1a952767
PE
4902012-07-13 Paul Eggert <eggert@cs.ucla.edu>
491
492 * xdisp.c (produce_special_glyphs): Now static.
493 * dispextern.h (produce_special_glyphs): Remove decl.
494
983188fd
GM
4952012-07-13 Glenn Morris <rgm@gnu.org>
496
32fb4bb6
GM
497 * s/bsd-common, s/cygwin.h: Remove empty files.
498 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
499
983188fd
GM
500 * s/usg5-4-common.h (USG, USG5):
501 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
502 * s/sol2-6.h (SOLARIS2):
503 * s/irix6-5.h (IRIX6_5):
504 * s/hpux10-20.h (USG, USG5, HPUX):
505 * s/gnu-linux.h (USG, GNU_LINUX):
506 * s/freebsd.h (BSD_SYSTEM):
507 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
508 * s/cygwin.h (CYGWIN):
509 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
510 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
511
d1e68667 5122012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
513
514 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 515
6de0e799
GM
5162012-07-13 Glenn Morris <rgm@gnu.org>
517
739ae010
GM
518 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
519
dbee5793
GM
520 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
521
6de0e799
GM
522 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
523 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
524
b82da769
GM
5252012-07-12 Glenn Morris <rgm@gnu.org>
526
4fae5a7a 527 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
528
529 * process.c (init_process_emacs): Rename from init_process.
530 The old name is also the name of a Mach system call.
531 * lisp.h, emacs.c: Update for this name change.
532 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
533 longer needed.
534
5a979817
EZ
5352012-07-12 Eli Zaretskii <eliz@gnu.org>
536
537 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
538 memmove call that removes glyphs covered by the left truncation
539 glyph. Improve commentary.
540 (display_line): Fix display of continuation glyphs on GUI frames
541 when the right fringe is turned off and variable-size fonts are
542 used in the window. Move the code that appends a stretch glyph to
543 produce_special_glyphs, so that it could be used for truncation
544 and continuation glyphs alike.
545 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
546 glyph of a suitably computed width, to align the special glyphs at
547 the window margin. Code moved from display_line. (Bug#11832)
548
3e91a053
GM
5492012-07-12 Glenn Morris <rgm@gnu.org>
550
ba9e4b84
GM
551 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
552
553 * s/gnu-linux.h, s/hpux10-20.h:
554 Do not unconditionally define HAVE_XRMSETDATABASE.
555
3e91a053
GM
556 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
557
b300b1f4
PE
5582012-07-12 Paul Eggert <eggert@cs.ucla.edu>
559
560 Fix typos that broke OS X build.
561 Reported by Randal L. Schwartz in
562 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
563 * nsterm.m (ns_timeout): Add missing local decl.
564 (ns_get_color): snprintf -> sprintf, to fix typo.
565
6e777848
GM
5662012-07-12 Glenn Morris <rgm@gnu.org>
567
3f922c37
GM
568 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
569 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
570 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
571 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
572
0ab7b23a
GM
573 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
574 Move PTY_OPEN to configure.
575
6e777848
GM
576 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
577 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
578 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
579
4a7edc24
DA
5802012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
581
582 Use empty_unibyte_string where applicable.
583 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
584 * lread.c (read1): Likewise.
585 * xsettings.c (syms_of_xsettings): Likewise.
586
308aab79
GM
5872012-07-12 Glenn Morris <rgm@gnu.org>
588
42bd1719
GM
589 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
590 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
591 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
592 * s/hpux10-20.h (RUN_TIME_REMAP):
593 * s/bsd-common.h (TABDLY): Move to configure.
594
595 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
596
597 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
598
ea0bbd17 599 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 600 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
601
602 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 603
308aab79
GM
604 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
605 * s/template.h: Move NARROWPROTO to configure.
606
ee1cf5cf
GM
6072012-07-11 Glenn Morris <rgm@gnu.org>
608
30fe9bf4
GM
609 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
610 unused since 2011-01-17 change to systty.h.
611
ee1cf5cf
GM
612 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
613 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
614 Move HAVE_PTYS and HAVE_SOCKETS to configure.
615
63e47e07
PE
6162012-07-11 Paul Eggert <eggert@cs.ucla.edu>
617
618 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
619
c43fb4c3
GM
6202012-07-11 Glenn Morris <rgm@gnu.org>
621
622 * s/darwin.h, s/gnu-linux.h, s/template.h:
623 Move INTERRUPT_INPUT to configure.
624
e8df9267
DA
6252012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
626
627 Minor adjustments to interning code.
628 * lisp.h (intern, intern_c_string): Redefine as static inline
629 wrappers for intern_1 and intern_c_string_1, respectively.
630 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
631 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
632 Vobarray checking.
e8df9267
DA
633 * font.c (font_intern_prop): Likewise. Adjust comment.
634 * w32font.c (intern_font_name): Likewise.
635
34348bd4
AS
6362012-07-11 Andreas Schwab <schwab@linux-m68k.org>
637
d96a1e0c
AS
638 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
639
34348bd4
AS
640 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
641 of Fcar/Fcdr if possible.
642 * font.c (check_otf_features): Likewise.
643 * fontset.c (Fnew_fontset): Likewise.
644 * gnutls.c (Fgnutls_boot): Likewise.
645 * minibuf.c (read_minibuf): Likewise.
646 * msdos.c (IT_set_frame_parameters): Likewise.
647 * xmenu.c (Fx_popup_dialog): Likewise.
648 * w32menu.c (Fx_popup_dialog): Likewise.
649
c8add24e
GM
6502012-07-11 Glenn Morris <rgm@gnu.org>
651
4b575b3c
GM
652 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
653 since nothing has defined it on these platforms.
654
09f4e3b0
GM
655 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
656 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
657
172bedef
GM
658 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
659 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
660 Move CLASH_DETECTION to configure.
661
249685df
GM
662 * s/gnu.h: Remove file, which is now empty.
663
c8add24e
GM
664 * s/gnu.h, s/gnu-linux.h:
665 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
666
b41253a3
JW
6672012-07-11 John Wiegley <johnw@newartisans.com>
668
669 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
670 function attribute, so we only use it if it exists in the
671 compiler.
672
d923b542
DA
6732012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
674
675 Avoid call to strlen in fast_c_string_match_ignore_case.
676 * search.c (fast_c_string_match_ignore_case): Change to use
677 length argument. Adjust users accordingly.
678 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
679
5ebbef1d
PE
6802012-07-11 Paul Eggert <eggert@cs.ucla.edu>
681
bb352260
PE
682 Assume mkdir, rmdir.
683 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
684 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
685
57054ddd
PE
686 Assume rename.
687 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
688
b747d3f7
PE
689 Assume perror.
690 * s/hpux10-20.h (HAVE_PERROR): Remove.
691 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
692 Remove dummy definition, as this problem was obsolete long ago.
693
5ebbef1d
PE
694 Assume strerror.
695 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
696
984e7f30
DA
6972012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
698
699 Avoid calls to strlen in font processing functions.
700 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 701 (font_open_by_name): Change to use length argument. Adjust
984e7f30 702 users accordingly.
d923b542
DA
703 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
704 Adjust prototypes.
705 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
706 Change to return ptrdiff_t.
984e7f30
DA
707 (xfont_list_pattern, xfont_match): Use length returned by
708 xfont_decode_coding_xlfd.
709 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
710
20e94fdd
GM
7112012-07-11 Glenn Morris <rgm@gnu.org>
712
9d596af3
GM
713 * s/darwin.h, s/freebsd.h, s/netbsd.h:
714 Move DONT_REOPEN_PTY to configure.
715
20e94fdd
GM
716 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
717 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
718
e99a530f
PE
7192012-07-10 Paul Eggert <eggert@cs.ucla.edu>
720
22ffb973
PE
721 Remove "#define unix" that is no longer needed (Bug#11905).
722 * s/aix4-2.h (unix): Remove; no longer needed.
723
e9a9ae03
PE
724 EMACS_TIME simplification (Bug#11875).
725 This replaces macros (which typically do not work in GDB)
726 with functions, typedefs and enums, making the code easier to debug.
727 The functional style also makes code easier to read and maintain.
728 * systime.h: Include <sys/time.h> on all hosts, not just if
729 WINDOWSNT, since 'struct timeval' is needed in general.
730 (EMACS_TIME): Now a typedef, not a macro.
731 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
732 not macros.
733 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
734 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
735 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
736 (EMACS_TIME_LE): Now functions, not macros.
737 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
738 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
739 which are not functions. All uses rewritten to use:
740 (make_emacs_time): New function.
741 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
742 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
743 not functions. All uses rewritten to use the following, respectively:
744 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
745 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 746 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
747 * fileio.c (Fcopy_file):
748 * xterm.c (XTflash): Get the current time closer to when it's used.
749 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
750
ffacb126
PE
751 * bytecode.c (targets): Suppress -Woverride-init warnings.
752
e99a530f
PE
753 Simplify by avoiding confusing use of strncpy etc.
754 * doc.c (Fsnarf_documentation):
755 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
756 * frame.c (Fmake_terminal_frame):
757 * gtkutil.c (get_utf8_string):
758 * lread.c (openp):
759 * nsmenu.m (ns_update_menubar):
760 * regex.c (regerror):
761 Prefer memcpy to strncpy and strncat when either will do.
762 * fileio.c (Fsubstitute_in_file_name):
763 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
764 (menu_separator_name_p):
765 * nsmenu.m (ns_update_menubar):
766 Prefer memcmp to strncmp when either will do.
767 * nsterm.m: Include <ftoastr.h>.
768 (ns_get_color):
769 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
770 Prefer snprintf to strncpy.
771 * nsterm.m (ns_term_init):
772 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
773 * nsterm.m (ns_term_init):
774 Avoid the need for strncpy, by using build_string or
775 make_unibyte_string directly. Use dtoastr, not snprintf.
776 * process.c (Fmake_network_process): Diagnose service names that
777 are too long, rather than silently truncating them or creating
778 non-null-terminated names.
779 (Fnetwork_interface_info): Likewise, for interface names.
780 * sysdep.c (system_process_attributes) [GNU_LINUX]:
781 Prefer sprintf to strncat.
782 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
783 Prefer vsnprintf to vsprintf + strncpy.
784
c59592b3
GM
7852012-07-10 Glenn Morris <rgm@gnu.org>
786
787 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
788 Clarify fallback case.
789
7d7bbefd
DA
7902012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
791
792 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
793 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
794 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 795 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
796 where argument type is known to be a Lisp_Cons.
797
3a4c8000
TT
7982012-07-10 Tom Tromey <tromey@redhat.com>
799
800 * bytecode.c (BYTE_CODE_THREADED): New macro.
801 (BYTE_CODES): New macro. Replaces all old byte-code defines.
802 (enum byte_code_op): New type.
803 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
804 (exec_byte_code): Use them. Use token threading when applicable.
805
2a0213a6
DA
8062012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
807
808 Optimize pure C strings initialization.
809 * lisp.h (make_pure_string): Fix prototype.
810 (build_pure_c_string): New function, defined as static inline. This
811 provides a better opportunity to optimize away calls to strlen when
812 the function is called with compile-time constant argument.
813 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
814 argument, adjust users accordingly. Use build_pure_c_string where
815 appropriate.
816 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
817 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
818 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
819
cb1caeaf
DA
8202012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
821
822 Avoid calls to strlen in miscellaneous functions.
823 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
824 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
825 * lread.c (openp): Likewise.
826
c293e30c
DA
8272012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
828
829 Avoid calls to strlen in path processing functions.
830 * fileio.c (file_name_as_directory): Add comment. Change to add
831 srclen argument and return the length of result. Adjust users
832 accordingly.
833 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 834 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
835 users accordingly.
836 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
837
9e059e3f
GM
8382012-07-10 Glenn Morris <rgm@gnu.org>
839
d02eb359
GM
840 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
841 Move PENDING_OUTPUT_COUNT definition to configure.
842
882cf227
GM
843 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
844 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
845 * s/gnu.h (DATA_START): Move definitions to configure.
846
af6e839f
GM
847 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
848 We include usg5-4-common.h, which defines them both.
849
40289a12
GM
850 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
851 O_RDONLY already includes it).
852
9e059e3f
GM
853 Stop ns builds setting the EMACSLOADPATH environment variable.
854 * nsterm.m (ns_load_path): Rename from ns_init_paths.
855 Now it does not set EMACSLOADPATH, just returns the load-path string.
856 * nsterm.h: Update accordingly.
857 * lread.c [HAVE_NS]: Include nsterm.h.
858 (init_lread) [HAVE_NS]: Use ns_load_path.
859 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
860
7c4e8ec0
GM
8612012-07-09 Glenn Morris <rgm@gnu.org>
862
d4f600ff
GM
863 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
864 since the included bsd-common.h does so.
865
cbb31951
GM
866 Stop ns builds setting the EMACSPATH environment variable.
867 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
868 (ns_init_paths): Do not set EMACSPATH.
869 * nsterm.h (ns_exec_path): Add it.
870 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
871 Use ns_exec_path.
872
7c4e8ec0
GM
873 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
874
26bccfae
PE
8752012-07-09 Paul Eggert <eggert@cs.ucla.edu>
876
a0bee46f
PE
877 * process.c (wait_reading_process_output): 'waitchannels' was unset
878 when read_kbd || !NILP (wait_for_cell); fix this.
879
5994c183
PE
880 Add GCC-style 'const' attribute to functions that can use it.
881 * character.h (char_resolve_modifier_mask):
882 * keyboard.h (make_ctrl_char):
883 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
884 (init_character_once, next_almost_prime, init_fns, init_image)
885 (flush_pending_output, init_sound):
886 * mem-limits.h (start_of_data):
887 * menu.h (finish_menu_items):
888 Add ATTRIBUTE_CONST.
889 * emacs.c (DEFINE_DUMMY_FUNCTION):
890 Declare the dummy function with ATTRIBUTE_CONST.
891 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
892 Add decls with ATTRIBUTE_CONST.
893
26bccfae
PE
894 Minor improvements to make_formatted_string.
895 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
896 where int is good enough, as vsprintf returns an int.
897 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
898
a8290ec3
DA
8992012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
900
901 Use make_formatted_string to avoid double length calculation.
902 * lisp.h (make_formatted_string): New prototype.
903 * alloc.c (make_formatted_string): New function.
904 * buffer.c (Fgenerate_new_buffer_name): Use it.
905 * dbus.c (syms_of_dbusbind): Likewise.
906 * editfns.c (Fcurrent_time_zone): Likewise.
907 * filelock.c (get_boot_time): Likewise.
908 * frame.c (make_terminal_frame, set_term_frame_name)
909 (x_report_frame_params): Likewise.
910 * image.c (gs_load): Likewise.
911 * minibuf.c (get_minibuffer): Likewise.
912 * msdos.c (dos_set_window_size): Likewise.
913 * process.c (make_process): Likewise.
914 * xdisp.c (ensure_echo_area_buffers): Likewise.
915 * xsettings.c (apply_xft_settings): Likewise.
916
d01ba2f1
GM
9172012-07-09 Glenn Morris <rgm@gnu.org>
918
919 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
920 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
921 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
922 * nsterm.h (ns_etc_directory): Add it.
923 * callproc.c [HAVE_NS]: Include nsterm.h.
924 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
925
f1f924b6
DA
9262012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
927
928 Move marker debugging code under MARKER_DEBUG.
929 * marker.c (MARKER_DEBUG): Move marker debugging code under
930 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
931 for bootstrap with --enable-checking (~3x slowdown reported
932 by Juanma Barranquero <lekktu@gmail.com>).
933 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
934
ab531b66
PE
9352012-07-08 Paul Eggert <eggert@cs.ucla.edu>
936
937 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
938 See <http://bugs.gnu.org/11825#29>.
939
c4b3bc8a
EZ
9402012-07-08 Eli Zaretskii <eliz@gnu.org>
941
942 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
943 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
944 (display_line): Add commentary about displaying truncation glyphs
945 on GUI frames.
946 (produce_special_glyphs): Move here from term.c.
947
948 * term.c (produce_special_glyphs): Move to xdisp.c.
949
950 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
951 section.
c4b3bc8a 952
b676b881
AS
9532012-07-07 Andreas Schwab <schwab@linux-m68k.org>
954
f17c5273
AS
955 * xdisp.c (display_line): Avoid warning about implicit declaration
956 of FRAME_FONT.
957
298819b9
AS
958 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
959
b676b881
AS
960 * lisp.h: Remove empty conditional.
961
6045c4fd
PE
9622012-07-07 Paul Eggert <eggert@cs.ucla.edu>
963
b3350bf9
PE
964 * lread.c (load_path_check): Now static.
965
6045c4fd
PE
966 Fix some minor --with-ns problems found by static checking.
967 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
968 (x_set_font) [!HAVE_X_WINDOWS]:
969 * image.c (xpm_load_image) [HAVE_NS]:
970 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
971 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
972 Remove unused local.
973 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
974 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
975 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
976 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
977 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
978 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
979 Fix pointer signedness problem.
980 * xfaces.c (FRAME_X_FONT_TABLE):
981 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
982
929e7845
GM
9832012-07-07 Glenn Morris <rgm@gnu.org>
984
985 * lread.c (load_path_check): New function, split from init_lread.
986 (init_lread): Reorganize. Motivation:
987 If EMACSLOADPATH is set, check/warn about that rather than the
988 defaults, which we are not going to use. Hence we can remove
989 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
990 Don't warn if site-lisp directories are missing.
991 If not installed, start from a blank load-path, since
992 PATH_LOADSEARCH refers to the eventual installation directories.
993
58dd0aa4
EZ
9942012-07-07 Eli Zaretskii <eliz@gnu.org>
995
996 Support truncation and continuation glyphs on GUI frames, when
997 fringes are disabled. (Bug#11832)
998 * xdisp.c (init_iterator): Get dimensions of truncation and
999 continuation glyphs even if on GUI frames. Adjust
1000 it->last_visible_x on GUI frames when the left or right fringes,
1001 or both, are absent.
1002 (start_display, move_it_in_display_line_to): Handle the case of a
1003 GUI frame without a fringe to display continuation or truncation
1004 glyphs.
1005 (insert_left_trunc_glyphs): Support GUI frames: make sure
1006 truncation glyphs overwrite enough glyphs from the current line to
1007 have sufficient space in pixels.
1008 (display_line): Support truncation and continuation glyphs on GUI
1009 frames. If some spare pixels are left on the line after inserting
1010 the truncation glyphs, fill that space with a stretch glyph of a
1011 suitably computed width.
1012
1013 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1014 produce_glyphs, to support GUI sessions.
1015
31571fd7
PE
10162012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1017
5a16b9bc
PE
1018 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1019
f3047c75
PE
1020 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1021
31571fd7
PE
1022 Do not require float-time's arg to fit in time_t (Bug#11825).
1023 This works better on hosts where time_t is unsigned, and where
1024 float-time is applied to the (negative) difference between two times.
1025 * editfns.c (decode_time_components): Last arg is now double *,
1026 not int *, and means to store all the result as a double, without
1027 worrying about whether the seconds part fits in time_t.
1028 All callers changed.
1029 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1030 All callers changed.
1031 (Ffloat_time): Do not fail merely because the specified time falls
1032 outside of time_t range.
1033
4516fbef
GM
10342012-07-07 Glenn Morris <rgm@gnu.org>
1035
1036 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1037 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1038 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1039
07adc2c6
JB
10402012-07-07 Juanma Barranquero <lekktu@gmail.com>
1041
1042 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1043 Update dependencies.
1044
1045 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1046
fd573f31
PE
10472012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1048
fee5959d
PE
1049 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1050 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1051 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1052 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1053 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1054 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1055
fd573f31
PE
1056 * xfont.c (compare_font_names): Redo to omit the need for casts.
1057
ddadbc0e
AS
10582012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1059
fca8d6b6
AS
1060 * xfns.c (Fx_change_window_property): Doc fix.
1061 * w32fns.c (Fx_change_window_property): Doc fix.
1062
ddadbc0e
AS
1063 * w32fns.c (Fx_window_property): Accept the same arguments as the
1064 X Windows version. Doc fix.
1065 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1066
ed9265fc 10672012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1068 Eli Zaretskii <eliz@gnu.org>
1069
1070 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1071 Windows-specific code from nt/config.nt moved here.
1072 Obsolete settings removed.
1073
216ee680
PE
10742012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1075
1076 * process.c: Avoid unnecessary calls to gettime.
1077 (wait_reading_process_output): Don't get the time of day
1078 when gobbling data immediately and not waiting, as there's no need
1079 for it in that case. This removes a FIXME.
1080
bdd091e4
JD
10812012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1082
1083 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1084 is defined (Bug#11768).
1085
9d44f8ce
DA
10862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1087
1088 Fix marker debugging code.
1089 * marker.c (byte_char_debug_check): Do not perform the check
1090 if buffer is not multibyte.
090bd7cb
JB
1091 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1092 Call byte_char_debug_check with correct arguments.
9d44f8ce 1093
90fc4786
DA
10942012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1095
1096 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1097 * marker.c (byte_char_debug_check, count_markers):
1098 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1099 (byte_debug_flag): Remove.
1100 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1101 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1102
7b7ae965
DA
11032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1104
4e57b342
DA
1105 Avoid code repetition in marker-related functions.
1106 * marker.c (attach_marker): New function.
1107 (Fset_marker, set_marker_restricted, set_marker_both)
1108 (set_marker_restricted_both): Use it.
1109 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1110 Consistently rename charno to charpos.
1111 (marker_position): Add eassert.
1112 (marker_byte_position): Convert to eassert.
1113
11142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1115
1116 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1117 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1118 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1119
657924ff
DA
11202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1121
1122 Introduce fast path for the widely used marker operation.
1123 * alloc.c (build_marker): New function.
1124 * lisp.h (build_marker): New prototype.
1125 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1126 * composite.c (autocmp_chars): Likewise.
1127 * editfns.c (buildmark): Remove.
1128 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1129 (save_restriction_save): Use build_marker.
1130 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1131 * window.c (save_window_save): Likewise.
1132
041a49a6
DA
11332012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1134
1135 Do not use Fdelete_overlay in delete_all_overlays
1136 to avoid redundant calls to unchain_overlay.
1137 * buffer.c (drop_overlay): New function.
1138 (delete_all_overlays, Fdelete_overlay): Use it.
1139 * minibuf.c (get_minibuffer): Fix comment.
1140
7dca65a4
PE
11412012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1142
1143 Port to OpenBSD 5.1 amd64.
1144 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1145 This is needed for OpenBSD, and should be harmless on all BSD systems.
1146 Also, include <sys/sysctl.h>, as it should be available on all
1147 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1148 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1149 use p_pid member, not kp_proc.pid.
1150
8eb876e2
GM
11512012-07-06 Glenn Morris <rgm@gnu.org>
1152
1153 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1154
38182d90
PE
11552012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1156
1157 More xmalloc and related cleanup.
1158 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1159 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1160 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1161 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1162 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1163 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1164 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1165 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1166 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1167 * xterm.c:
1168 Omit needless casts involving void * pointers and allocation.
1169 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1170 as the former is more robust if P's type is changed.
1171 Prefer xzalloc to xmalloc + memset 0.
1172 Simplify malloc-or-realloc to realloc.
1173 Don't worry about xmalloc returning a null pointer.
1174 Prefer xstrdup to xmalloc + strcpy.
1175 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1176 growing it.
1177 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1178 alloca of a constant.
1179
6dd5a677
EZ
11802012-07-05 Eli Zaretskii <eliz@gnu.org>
1181
1182 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1183 hscroll is larger than the line width. Fixes long and futile
1184 looping inside extend_face_to_end_of_line (on a TTY) producing
1185 glyphs that are not needed and thrown away.
1186
6b312f0f
DA
11872012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1188
1189 * marker.c (set_marker_restricted_both): Simplify by using
1190 clip_to_bounds.
1191
f520ef9b
PE
11922012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1193
1194 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1195
383b7c95
JD
11962012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1197
1198 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1199 not defined (Bug#11768).
1200 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1201 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1202 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1203 followed by gtk_box_set_homogeneous (Bug#11768).
1204 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1205 (update_theme_scrollbar_width, xg_create_scroll_bar):
1206 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1207 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1208 (is_box_type): New function (Bug#11768).
1209 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1210 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1211 with default display (Bug#11768).
1212
d6e7bf45
EZ
12132012-07-05 Eli Zaretskii <eliz@gnu.org>
1214
1215 * xdisp.c (window_hscroll_limited): New function.
1216 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1217 coordinates when window's hscroll is set to insanely large
1218 values. (Bug#11857)
1219
431391ec
JB
12202012-07-05 Juanma Barranquero <lekktu@gmail.com>
1221
1222 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1223 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1224
23f86fce
DA
12252012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1226
1227 Cleanup xmalloc.
1228 * lisp.h (xzalloc): New prototype. Omit needless casts.
1229 * alloc.c (xzalloc): New function. Omit needless casts.
1230 * charset.c: Omit needless casts. Convert all calls to
1231 xmalloc with following memset to xzalloc.
1232 * dispnew.c: Likewise.
1233 * fringe.c: Likewise.
1234 * image.c: Likewise.
1235 * sound.c: Likewise.
1236 * term.c: Likewise.
1237 * w32fns.c: Likewise.
1238 * w32font.c: Likewise.
1239 * w32term.c: Likewise.
1240 * xfaces.c: Likewise.
1241 * xfns.c: Likewise.
1242 * xterm.c: Likewise.
1243 * atimer.c: Omit needless casts.
1244 * buffer.c: Likewise.
1245 * callproc.c: Likewise.
1246 * ccl.c: Likewise.
1247 * coding.c: Likewise.
1248 * composite.c: Likewise.
1249 * doc.c: Likewise.
1250 * doprnt.c: Likewise.
1251 * editfns.c: Likewise.
1252 * emacs.c: Likewise.
1253 * eval.c: Likewise.
1254 * filelock.c: Likewise.
1255 * fns.c: Likewise.
1256 * gtkutil.c: Likewise.
1257 * keyboard.c: Likewise.
1258 * lisp.h: Likewise.
1259 * lread.c: Likewise.
1260 * minibuf.c: Likewise.
1261 * msdos.c: Likewise.
1262 * print.c: Likewise.
1263 * process.c: Likewise.
1264 * region-cache.c: Likewise.
1265 * search.c: Likewise.
1266 * sysdep.c: Likewise.
1267 * termcap.c: Likewise.
1268 * terminal.c: Likewise.
1269 * tparam.c: Likewise.
1270 * w16select.c: Likewise.
1271 * w32.c: Likewise.
1272 * w32reg.c: Likewise.
1273 * w32select.c: Likewise.
1274 * w32uniscribe.c: Likewise.
1275 * widget.c: Likewise.
1276 * xdisp.c: Likewise.
1277 * xmenu.c: Likewise.
1278 * xrdb.c: Likewise.
1279 * xselect.c: Likewise.
1280
0497dc44
PE
12812012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1282
1283 * fileio.c (time_error_value): Check the right error number.
1284 Problem reported by Troels Nielsen in
1285 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1286
356e7178
PE
12872012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1288
4e71fd89
PE
1289 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1290 This should be fixed in a better way; see Eli Zaretskii in
1291 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1292 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1293
f0941253
PE
1294 * fileio.c (time_error_value): Rename from special_mtime.
1295 The old name's problems were noted by Eli Zaretskii in
1296 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1297
065c9eb4
PE
1298 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1299 This variable's comment says Emacs needs at least one GDB-visible
1300 symbol of type enum pvec_type, to work around GDB problems.
1301 The symbol's value doesn't matter.
1302
356e7178
PE
1303 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1304 that causes compilation to fail on pre-C99 compilers.
1305
ed9265fc 13062012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1307
1308 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1309 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1310
3884d954
DA
13112012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1312
d209e2fb 1313 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1314 headers for buffer_defaults and buffer_local_symbols.
1315 Reported by Juanma Barranquero <lekktu@gmail.com>.
1316
ee28be33
SM
13172012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1318
1319 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1320 * lisp.h (enum pvec_type): Use fewer bits.
1321 (PSEUDOVECTOR_SIZE_BITS): New constant.
1322 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1323 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1324 change in pvec_type.
1325 (PSEUDOVECTOR_TYPEP): New macro.
1326 (TYPED_PSEUDOVECTORP): Use it.
1327 * fns.c (internal_equal): Adapt code to extract pvectype.
1328 * emacs.c (gdb_pvec_type): Update type.
1329 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1330 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1331 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1332 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1333 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1334 abusing vector->header.next.nbytes.
1335 (live_vector_p): Use PVEC_TYPE.
1336 (mark_object): Adapt code to extract pvectype. Use switch.
1337
c7f2cd7f
PE
13382012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1341 Tighten new eassert a bit.
1342
8ce70ed2
DA
13432012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1344
1345 Fix compilation with --enable-gcc-warnings and -O1
1346 optimization level.
1347 * doprnt.c (doprnt): Change type of tem to int, initialize
1348 to avoid compiler warning. Add eassert.
1349 * search.c (simple_search): Initialize match_byte to avoid
1350 compiler warning. Add eassert.
1351
dea7f1e5
PE
13522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1353
24a212eb
PE
1354 Avoid weird behavior with large horizontal scrolls.
1355 Without this change, for example, large hscroll values would
1356 mess up Emacs's display on Fedora 15 x86, presumably due to
1357 overflows in int calculations in the display code.
1358 Also, if buffers had long lines, Emacs would freeze.
1359 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1360 (set_window_hscroll): New function, containing the old guts of
1361 Fset_window_hscroll. Return the clipped value.
1362 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1363 This avoids the need to check against PTRDIFF_MAX.
1364
dea7f1e5
PE
1365 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1366
76046526
DA
13672012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1368
1369 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1370
39adff0d
PE
13712012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1372
63807d47
PE
1373 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1374 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1375 since GCC 4.4.6 issues a bogus warning for them.
1376
39adff0d
PE
1377 Fix bugs in file timestamp newness comparisons.
1378 * fileio.c (Ffile_newer_than_file_p):
1379 * lread.c (Fload): Use full timestamp resolution of files,
1380 not just the 1-second resolution, so that files that are only
1381 slightly newer still count as newer.
1382 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1383 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1384
dbeed9a6
PE
13852012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1386
1387 * fileio.c: Improve handling of file time marker. (Bug#11852)
1388 (special_mtime): New function.
1389 (Finsert_file_contents, Fverify_visited_file_modtime):
1390 Use it to set special mtime values consistently.
1391
636334d6
AS
13922012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1393
1394 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1395 marker for non-existing file. (Bug#11852)
1396
e2017fe2
GM
13972012-07-03 Glenn Morris <rgm@gnu.org>
1398
1399 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1400 and did not make it into globals.h).
1401
404dbd37
TT
14022012-07-03 Tom Tromey <tromey@redhat.com>
1403
1404 * window.c (Fset_window_margins, Fset_window_fringes)
1405 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1406 * textprop.c (Fprevious_property_change): No longer static.
1407 * syntax.c (Fsyntax_table_p): No longer static.
1408 * process.c (Fget_process, Fprocess_datagram_address): No longer
1409 static.
1410 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1411 * keyboard.c (Fcommand_execute): No longer static.
1412 Remove EXFUN.
1413 * insdel.c (Fcombine_after_change_execute): No longer static.
1414 * image.c (Finit_image_library): No longer static.
1415 * fileio.c (Fmake_symbolic_link): No longer static.
1416 * eval.c (Ffetch_bytecode): No longer static.
1417 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1418 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1419 No longer static.
404dbd37
TT
1420 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1421 static.
1422 * dired.c (Ffile_attributes): No longer static.
1423 * composite.c (Fcomposition_get_gstring): No longer static.
1424 * callproc.c (Fgetenv_internal): No longer static.
1425
1426 * ccl.h: Remove EXFUNs.
1427 * buffer.h: Remove EXFUNs.
1428 * dispextern.h: Remove EXFUNs.
1429 * intervals.h: Remove EXFUNs.
1430 * fontset.h: Remove EXFUN.
1431 * font.h: Remove EXFUNs.
1432 * dosfns.c (system_process_attributes): Remove EXFUN.
1433 * keymap.h: Remove EXFUNs.
1434 * lisp.h: Remove EXFUNs.
1435 * w32term.h: Remove EXFUNs.
1436 * window.h: Remove EXFUNs.
1437 * xsettings.h: Remove EXFUN.
1438 * xterm.h: Remove EXFUN.
1439
8e4fd1e1
GM
14402012-07-03 Glenn Morris <rgm@gnu.org>
1441
1442 * lisp.h (Frandom): Make it visible to C.
1443 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1444 buffer for invisible buffers. (Bug#1229)
1445
ca95b3eb
DA
14462012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1447
1448 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1449 values which aren't power of 2.
1450 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1451 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1452 accordingly.
1453
7555c33f
SM
14542012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1455
1456 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1457
1458 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1459
d12e8f5a
DA
14602012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1461
1462 * alloc.c (allocate_vector_block): Remove redundant
1463 calls to mallopt if DOUG_LEA_MALLOC is defined.
1464 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1465 avoid calls to mallopt if zero_vector is returned.
1466
296094c3
DA
14672012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1468
1469 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1470 is enabled, avoid dereferencing NULL current_sblock if
1471 running undumped.
1472
36429c89
DA
14732012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1474
1475 Cleanup basic buffer management.
1476 * buffer.h (struct buffer): Change layout to use generic vector
1477 marking code. Fix some comments. Change type of 'clip_changed'
1478 to bitfield. Remove unused #ifndef old.
1479 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1480 (GET_OVERLAYS_AT): Fix indentation.
1481 (for_each_per_buffer_object_at): New macro.
1482 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1483 (Fbuffer_local_variables): Use it.
1484 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1485 * alloc.c (allocate_buffer): Adjust to match new layout of
1486 struct buffer. Fix comment.
1487 (mark_overlay): New function.
1488 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1489 Lisp area of struct buffer.
1490 (mark_object): Use it. Adjust marking of misc objects
1491 and related comments.
1492
3b3e4cac
PE
14932012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1494
1495 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1496 wrapper that is not needed because the wrapped code is a no-op (zero
1497 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1498 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1499
cf5c0175
DA
15002012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1501
1502 * alloc.c (mark_buffer): Simplify. Remove prototype.
1503 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1504 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1505 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1506 redundant calls to mark_vectorlike for bool vectors.
1507
ca26824c
GM
15082012-06-30 Glenn Morris <rgm@gnu.org>
1509
2e4c5312
GM
1510 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1511
ca26824c
GM
1512 * epaths.in (PATH_SITELOADSEARCH): New.
1513 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1514 This is rather than relying on --enable-locallisppath elements
1515 having "site-lisp" in their names. (Bug#10208#25, 11658)
1516
0d23c240
EZ
15172012-06-30 Eli Zaretskii <eliz@gnu.org>
1518
c9240d7a
EZ
1519 * w32proc.c (sys_select): Accept and ignore one more argument.
1520
1521 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1522
0d23c240 1523 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1524 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1525
1526 * sysdep.c: Don't include dos.h and dosfns.h.
1527
1528 * process.c (sys_select):
1529 * msdos.c (sys_select): Accept one more argument and ignore it.
1530
1531 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1532 adapt data types and code to that.
1533
1534 * dosfns.c:
1535 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1536 which clashes with the gnulib function of the same name.
1537
af5a5a98
AS
15382012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1539
c5e4379c
AS
1540 * font.c (font_style_to_value, font_style_symbolic)
1541 (font_prop_validate_style): Add type checks for values in
1542 font_style_table.
1543
af5a5a98
AS
1544 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1545 argument.
1546 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1547 uses.
1548
8d38f461
EZ
15492012-06-29 Eli Zaretskii <eliz@gnu.org>
1550
2e5a6631
EZ
1551 * xdisp.c (try_window_id): Undo last change.
1552
8d38f461
EZ
1553 * w32.c (getwd): Adjust commentary about startup_dir.
1554 (init_environment): Always call sys_access, even in non-MSVC
1555 builds. Don't chdir to the directory of the Emacs executable.
1556 This undoes code from 1997 which was justified by the need to
1557 "avoid conflicts when removing and renaming directories". But its
1558 downside was that every relative file name was being interpreted
1559 relative to the directory of the Emacs executable, which can never
1560 be TRT. In particular, it broke sys_access when called with
1561 relative file names.
1562 (sys_access): Map GetLastError to errno.
1563
2af3565e
DA
15642012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1565
1566 * window.h (struct window): Change type of 'fringes_outside_margins'
1567 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1568 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1569 Adjust comment.
1570 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1571 to ptrdiff_t.
1572
c8d3a25c 15732012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1574
c8d3a25c
GM
1575 * gnutls.c (emacs_gnutls_handshake):
1576 Add QUIT to make the loop interruptible.
57570cd3 1577
c8d3a25c 15782012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1579
c8d3a25c
GM
1580 * charset.c (init_charset): Make lack of etc/charsets fatal.
1581
3e984ee8
DA
15822012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1583
1584 * editfns.c (region_limit): Fix type mismatch.
1585
ef884f23
DA
15862012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1587
1588 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1589 undefined. Convert from xassert to eassert.
1590 * nsmenu.m: Convert from xassert to eassert.
1591 * nsterm.m: Likewise.
1592
7d7e0027
SM
15932012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1594
1595 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1596
aa754e6a
PE
15972012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1598
1599 Avoid integer overflow on scroll-left and scroll-right.
1600 * window.c (HSCROLL_MAX): New macro.
1601 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1602 overflow when requested scroll falls outside ptrdiff_t range.
1603
80b00b08
DA
16042012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1605
1606 * window.h (struct window): Change type of 'hscroll',
1607 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1608 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1609 Adjust users accordingly.
1610 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1611 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1612 from EMACS_INT to ptrdiff_t.
1613 (make_window): Omit redundant initialization.
1614
62b2bcf6
JB
16152012-06-28 Juanma Barranquero <lekktu@gmail.com>
1616
1617 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1618
45942c7d
DA
16192012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1620
1621 * window.h (struct window): Change type of 'use_time' and
1622 'sequence_number' from Lisp_Object to int.
1623 * frame.c (make_frame): Adjust users accordingly.
1624 * print.c (print_object): Likewise.
1625 * window.c (select_window, Fwindow_use_time, make_parent_window)
1626 (make_window): Likewise.
1627
e509cfa6
DA
16282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1629
1630 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1631 enabled with --enable-checking=[all,glyphs] configure option.
1632 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1633 adjust comments accordingly.
1634 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1635 undefined, adjust comments accordingly.
1636 * image.c: Likewise.
1637 * scroll.c: Likewise.
1638 * w32fns.c: Likewise.
1639 * w32term.c: Likewise.
1640 * xdisp.c: Likewise.
1641 * xfaces.c: Likewise.
1642 * xfns.c: Likewise.
1643 * xterm.c: Likewise.
1644
a54e2c05
DA
16452012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1646
1647 Generalize run-time debugging checks.
1648 * dispextern.h (XASSERTS): Remove.
1649 * fontset.c (xassert): Remove.
1650 Convert from xassert to eassert.
1651 * alloc.c: Convert from xassert to eassert.
1652 * bidi.c: Likewise.
1653 * dispnew.c: Likewise.
1654 * fns.c: Likewise.
1655 * fringe.c: Likewise.
1656 * ftfont.c: Likewise.
1657 * gtkutil.c: Likewise.
1658 * image.c: Likewise.
1659 * keyboard.c: Likewise.
1660 * menu.c: Likewise.
1661 * process.c: Likewise.
1662 * scroll.c: Likewise.
1663 * sound.c: Likewise.
1664 * term.c: Likewise.
1665 * w32console.c: Likewise.
1666 * w32fns.c: Likewise.
1667 * w32term.c: Likewise.
1668 * window.c: Likewise.
1669 * xdisp.c: Likewise.
1670 * xfaces.c: Likewise.
1671 * xfns.c: Likewise.
1672 * xselect.c: Likewise.
1673 * xterm.c: Likewise.
1674
1ec4b7b2
SM
16752012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1676
1677 * fns.c (maybe_resize_hash_table): Output message when growing the
1678 purify-hashtable.
1679
2014308a
DA
16802012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1681
1682 * alloc.c (allocate_string_data): Remove dead code.
1683 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1684 avoid GCC warning about unused macro.
1685
246155eb
DA
16862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1687
1688 * alloc.c (allocate_string): Omit intervals initialization.
1689 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1690 as in make_pure_string and make_pure_c_string.
1691
43184b7b
DA
16922012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1693
d209e2fb 1694 * alloc.c (allocate_string): Fix last change.
43184b7b 1695
3fe6dd74
DA
16962012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1697
d209e2fb 1698 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1699 to memset, add explicit initialization where appropriate.
1700
1ba6038a
GM
17012012-06-27 Glenn Morris <rgm@gnu.org>
1702
1703 * lisp.mk (lisp): Remove paths.elc.
1704
c89926a5
CY
17052012-06-27 Chong Yidong <cyd@gnu.org>
1706
1707 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1708
ed6b3510
JW
17092012-06-26 John Wiegley <johnw@newartisans.com>
1710
1ec4b7b2 1711 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1712 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1713
ed6b3510
JW
1714 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1715 when building with Clang.
1716
8edd4a2b
SM
17172012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1718
1719 * eval.c (Fapply): Allow calling it with a single argument.
1720
f6f62d1b
EZ
17212012-06-26 Eli Zaretskii <eliz@gnu.org>
1722
1723 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1724 _stricmp and _strnicmp.
1725 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1726
62efea5e
DA
17272012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1728
1729 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1730 allocated window.
1731 (allocate_process): Likewise for new process.
8edd4a2b 1732 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1733 (allocate_frame): Likewise.
1734 * frame.c (make_frame): Omit redundant initialization.
1735 * window.c (make_parent_window): Use memset.
1736 (make_window): Omit redundant initialization.
1737 * process.c (make_process): Omit redundant initialization.
1738 * terminal.c (create_terminal): Likewise.
1739
42997f4d
DA
17402012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1741
1742 * term.c (delete_tty): Remove redundant call to memset.
1743
1130ecfc
DA
17442012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1745
1746 * alloc.c: Remove build_string.
1747 * lisp.h: Define build_string as static inline. This provides
1748 a better opportunity to optimize away calls to strlen when the
1749 function is called with compile-time constant argument.
1750 * image.c (imagemagick_error): Convert to build_string.
1751 * w32proc.c (sys_spawnve): Likewise.
1752 * xterm.c (x_term_init): Likewise.
1753
cf38a720
PE
17542012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1755
99027bdd
PE
1756 Use sprintf return value instead of invoking strlen on result.
1757 In the old days this wasn't portable, since some sprintf
1758 implementations returned char *. But they died out years ago and
1759 Emacs already assumes sprintf returns int.
1760 Similarly for float_to_string.
1761 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1762 * ccl.c (ccl_driver):
1763 * character.c (string_escape_byte8):
1764 * data.c (Fnumber_to_string):
1765 * doprnt.c (doprnt):
1766 * print.c (print_object):
1767 * xdisp.c (message_dolog):
1768 * xfns.c (syms_of_xfns):
1769 Use sprintf or float_to_string result to avoid need to call strlen.
1770 * data.c (Fnumber_to_string):
1771 Use make_unibyte_string, since the string must be ASCII.
1772 * lisp.h, print.c (float_to_string): Now returns int length.
1773 * term.c (produce_glyphless_glyph):
1774 Use sprintf result rather than recomputing it.
1775
cf38a720
PE
1776 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1777 * Makefile.in (ALL_CFLAGS):
1778 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1779 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1780
3511c784
DA
17812012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1782
0a08eb21 1783 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1784 strcasecmp if available.
1785 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1786
fb7da12e
AS
17872012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1788
1789 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1790 Avoid comma operator.
1791 * menu.c (push_submenu_start, push_submenu_end)
1792 (push_left_right_boundary, push_menu_pane): Likewise.
1793 * msdos.c (dos_rawgetc): Likewise.
1794
afa2ffd8
DA
17952012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1796
1797 * xfns.c (xic_create_fontsetname): Remove redundant calls
1798 to memset.
1799
b3b4476b
PE
18002012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1801
4495ff38
PE
1802 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1803 sprintf already null-terminates its output.
1804
b3b4476b
PE
1805 * xfns.c (x_window): Remove redundant cast.
1806
b00876c9
DA
18072012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1808
1809 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1810 `const char *' to `char *' to avoid compiler warning.
1811
d188e26b
PE
18122012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1813
885d1d74
PE
1814 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1815 instead of truncating it to 63 (admittedly a generous limit).
1816
d188e26b
PE
1817 * process.c: Fix spelling and caps in comments.
1818
e2f560b1
DN
18192012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1820
e86db54b 1821 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1822 * sysdep.c (setpgrp): Remove definition, not used in this file.
1823
7583a3a1
JB
18242012-06-24 Juanma Barranquero <lekktu@gmail.com>
1825
1826 * makefile.w32-in: Update dependencies.
1827
696056c2
EZ
18282012-06-24 Eli Zaretskii <eliz@gnu.org>
1829
1830 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1831 (SYSTIME_H): Add nt/inc/sys/time.h.
1832
1833 * systime.h [WINDOWSNT]: Include sys/time.h.
1834
1835 * s/ms-w32.h (struct timespec): Definition moved from
1836 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1837
845ca893
PE
18382012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1839
1840 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1841 * buffer.h (buffer_slot_type_mismatch):
1842 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1843 * eval.c (unwind_to_catch):
1844 * image.c (my_png_error, my_error_exit):
1845 * keyboard.c (quit_throw_to_read_char, user_error)
1846 (Fexit_recursive_edit, Fabort_recursive_edit):
1847 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1848 (wrong_type_argument, buffer_overflow, __executable_start)
1849 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1850 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1851 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1852 (fatal):
1853 (child_setup) [!DOS_NT]:
1854 * lread.c (end_of_file_error, invalid_syntax):
1855 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1856 * puresize.h (pure_write_error):
1857 * search.c (matcher_overflow):
1858 * sound.c (sound_perror, alsa_sound_perror):
1859 * sysdep.c, syssignal.h (croak):
1860 * term.c (maybe_fatal, vfatal):
1861 * textprop.c (text_read_only):
1862 * undo.c (user_error):
1863 * unexmacosx.c (unexec_error):
1864 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1865 Use _Noreturn rather than NO_RETURN.
1866 No need for separate decl merely because of _Noreturn.
1867 * sound.c (sound_warning, parse_sound):
1868 Remove unnecessary forward decls.
1869
f1dd8073
PE
18702012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1871
1872 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1873 * lisp.h (WAIT_READING_MAX): New macro.
1874 * dispnew.c (Fsleep_for, sit_for):
1875 * keyboard.c (kbd_buffer_get_event):
1876 * process.c (Faccept_process_output):
1877 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1878 This improves on the previous patch, which introduced a bug
1879 when time_t is unsigned and as wide as intmax_t.
1880 See <http://bugs.gnu.org/9000#51>.
1881
b82c1755
EZ
18822012-06-23 Eli Zaretskii <eliz@gnu.org>
1883
1884 * dispnew.c (sit_for, Fsleep_for):
1885 * keyboard.c (kbd_buffer_get_event):
1886 * process.c (Faccept_process_output): Avoid compiler warnings when
1887 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1888
ca300656
JB
18892012-06-23 Juanma Barranquero <lekktu@gmail.com>
1890
049ec95b
JB
1891 * makefile.w32-in: Update dependencies.
1892
ca300656
JB
1893 * w32.c (ltime): Add return type and declare static.
1894 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1895
db7b8d06
PE
18962012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1897
1898 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1899 Privately reported by Herbert J. Skuhra.
1900 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1901 All uses changed.
1902 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1903 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1904
0bd8297f
EZ
19052012-06-23 Eli Zaretskii <eliz@gnu.org>
1906
96512555
EZ
1907 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1908 last argument of make_unibyte_string.
1909
0bd8297f
EZ
1910 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1911 language ID in the event parameters.
1912
1913 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1914 event.code, not the obscure "character set ID".
1915
63def6b6
CY
19162012-06-23 Chong Yidong <cyd@gnu.org>
1917
1918 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1919
e8a02204
EZ
19202012-06-23 Eli Zaretskii <eliz@gnu.org>
1921
388cdec0
EZ
1922 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1923 * w32.c (fdutimens): New function.
1924
1925 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1926
1927 * s/ms-w32.h (pselect): Redirect to sys_select.
1928
1929 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1930
e8a02204
EZ
1931 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1932 in the logic of incrementing and decrementing the value of
1933 use_relocatable_buffers.
1934
d054f3fb
PE
19352012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1936
1937 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1938 Privately reported by Herbert J. Skuhra.
1939 [__FreeBSD__]: Remove "*/" typo after "#include".
1940 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1941 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1942 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1943 Don't assume EMACS_TIME and struct timeval are the same type.
1944
d35af63c
PE
19452012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 Support higher-resolution time stamps (Bug#9000).
1948 The time stamps are only nanosecond-resolution at the C level,
1949 since that's the best that any real-world system supports now.
1950 But they are picosecond-resolution at the Lisp level, as that's
1951 easy, and leaves room for future OS improvements.
1952
1953 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1954 (LIBES): Use it.
1955
1956 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1957 Don't get current time unless it's needed.
1958
1959 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1960 now provides it if it's absent.
1961 (start_atimer): Port to higher-res time stamps.
1962 Check for time stamp overflow. Don't get current time more
1963 often than is needed.
1964
1965 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1966 Include systime.h, not time.h.
1967 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1968
1969 * dired.c: Include stat-time.h.
1970 (Ffile-attributes): File times now have higher resolution.
1971
1972 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1973 (struct image): Timestamp now has higher resolution.
1974
1975 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1976 has at least microseconds now. All uses removed.
1977 (update_frame, update_single_window, update_window, update_frame_1)
1978 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1979
1980 * editfns.c (time_overflow): Now extern.
1981 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1982 (float-time, Fformat_time_string, Fcurrent_time_string)
1983 (Fcurrent_time_zone): Accept and generate higher-resolution
1984 time stamps.
1985 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1986 (decode_time_components, lisp_seconds_argument): New functions.
1987 (make_time): Now static.
1988 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1989 Report an error if the time is invalid, rather than having the caller
1990 do that.
1991
1992 * fileio.c: Include <stat-time.h>
1993 (Fcopy_file): Copy higher-resolution time stamps.
1994 Prefer to set the time stamp via a file descriptor if that works.
1995 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1996 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1997 (Fvisited_file_modtime, Fset_visited_file_modtime):
1998 Support higher-resolution time stamps.
1999
2000 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2001
2002 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2003
2004 * image.c (prepare_image_for_display, clear_image_cache)
2005 (lookup_image): Port to higer-resolution time stamps.
2006
2007 * keyboard.c (start_polling, bind_polling_period):
2008 Check for time stamp overflow.
2009 (read_char, kbd_buffer_get_event, timer_start_idle)
2010 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2011 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2012 Port to higher-resolution time stamps. Do not assume time_t is signed.
2013 (decode_timer): New function. Timers are now vectors of length 9,
2014 not 8, to accommodate the picosecond component.
2015 (timer_check_2): Use it.
2016
2017 * nsterm.m (select_timeout, timeval_subtract): Remove.
2018 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2019 as they're a bit more accurate and handle overflow better.
2020 (ns_select): Change prototype to be compatible with pselect.
2021 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2022 * nsterm.h (ns_select): Adjust prototype.
2023
2024 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2025 us-resolution time stamps.
2026 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2027
2028 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2029
2030 * lisp.h (time_overflow): New decl.
2031 (wait_reading_process_output): First arg is now intmax_t, not int,
2032 to accommodate larger waits.
2033
2034 * process.h (struct Lisp_Process.read_output_delay):
2035 Now counts nanoseconds, not microseconds.
2036 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2037 EMACS_HAS_USECS.
2038 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2039 (wait_reading_process_output):
2040 Port to ns-resolution time stamps.
2041 (Faccept_process_output, wait_reading_process_output):
2042 Check for time stamp overflow. Do not assume time_t is signed.
2043 (select_wrapper): Remove; we now use pselect.
2044 (Fprocess_attributes): Now generates ns-resolution time stamps.
2045
2046 * sysdep.c: Include utimens.h. Don't include utime.h
2047 or worry about struct utimbuf; gnulib does that for us now.
2048 (gettimeofday): Remove; gnulib provides a substitute.
2049 (make_timeval): New function.
2050 (set_file_times): Now sets ns-resolution time stamps.
2051 New arg FD; all uses changed.
2052 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2053 (system_process_attributes):
2054 Now returns ns-resolution time stamp. All uses changed.
2055 Check for time stamp overflow.
2056
2057 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2058 provides a substitute now.
2059
2060 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2061 since it guarantees struct timespec.
2062 (EMACS_TIME): Now struct timespec, so that we can support
2063 ns-resolution time stamps.
2064 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2065 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2066 (EMACS_USECS): Remove.
2067 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2068 so multiply the arg by 1000 before storing it.
2069 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2070 New macros.
2071 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2072 Port to ns-resolution time stamps.
2073 (EMACS_TIME_NEG_P): Remove; replaced by....
2074 (EMACS_TIME_SIGN): New macro.
2075 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2076 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2077 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2078 (make_timeval, make_lisp_time, decode_time_components): New decls.
2079 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2080 that it mishandled time_t overflow. You can't compare by subtracting!
2081 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2082 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2083
2084 * term.c: Include <sys/time.h>.
2085 (timeval_to_Time): New function, for proper overflow wraparound.
2086 (term_mouse_position, term_mouse_click): Use it.
2087
2088 * undo.c (record_first_change): Support higher-resolution time stamps
2089 in the undo buffer.
2090 (Fprimitive_undo): Use them when restoring time stamps.
2091
2092 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2093 (w32_get_internal_run_time):
2094 Port to higher-resolution Emacs time stamps.
2095 (ltime): Now accepts single 64-bit integer, as that's more convenient
2096 for callers.
2097
2098 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2099
2100 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2101 for compatibility with pselect. Support ns-resolution time stamps.
2102
2103 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2104
2105 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2106 Check for time stamp overflow, and support ns-resolution time stamps.
2107
2108 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2109 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2110 (timeval_subtract): Remove; no longer needed.
2111 (XTflash, XTring_bell, x_wait_for_event):
2112 Port to ns-resolution time stamps. Don't assume time_t is signed.
2113
b6a92dfe
CY
21142012-06-22 Chong Yidong <cyd@gnu.org>
2115
2116 * xdisp.c (x_consider_frame_title): Revert last change.
2117
d251c37c
EZ
21182012-06-22 Eli Zaretskii <eliz@gnu.org>
2119
2120 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2121 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2122 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2123 staticidx goes up to 1597 out of 1600 = 0x640.)
2124
f10deafb
PE
21252012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2126
2127 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2128 Otherwise, the umask might be mistakenly 0 while handling input signals.
2129
ec6de1e2
SM
21302012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2131
2132 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2133
28be1ada
DA
21342012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2135
2136 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2137 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2138 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2139 access to `contents' member of Lisp_Vector objects with AREF and ASET
2140 where appropriate.
2141
c6bf3022
CY
21422012-06-19 Chong Yidong <cyd@gnu.org>
2143
2144 * frame.c (delete_frame): When selecting a frame on a different
2145 text terminal, do not alter the terminal's top-frame.
2146
2147 * xdisp.c (format_mode_line_unwind_data): Record the target
2148 frame's selected window and its terminal's top-frame.
2149 (unwind_format_mode_line): Restore them.
2150 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2151 Callers changed.
2152 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2153 since tty frames can be explicitly named.
2154 (prepare_menu_bars): Likewise.
2155
2156 * term.c (Ftty_top_frame): New function.
2157
defd4196
PE
21582012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2159
2160 Port byte-code-meter to modern targets.
2161 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2162 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2163 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2164 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2165 (METER_1, METER_2): Simplify.
2166
1053a871
SM
21672012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2168
2169 * data.c (Fdefalias): Return `symbol' (bug#11686).
2170
b7e8d081
MR
21712012-06-18 Martin Rudalics <rudalics@gmx.at>
2172
2173 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2174 gets killed during executing of this function (Bug#11665).
2175 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2176 (Vkill_buffer_query_functions): In doc-string say that functions
2177 run by this hook should not change the current buffer.
2178
7ea2b339
PE
21792012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2180
2181 Fix recently-introduced process.c problems found by static checking.
2182 * process.c (write_queue_push, write_queue_pop, send_process):
2183 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2184 (write_queue_pop): Fix pointer signedness problem.
2185 (send_process): Remove unused local.
2186
96a313a1
CY
21872012-06-17 Chong Yidong <cyd@gnu.org>
2188
2189 * xdisp.c (redisplay_internal): No need to redisplay terminal
2190 frames that are not on top.
2191
20ca2e94
TN
21922012-06-17 Troels Nielsen <bn.troels@gmail.com>
2193
2194 * process.c (make_process): Initialize write_queue.
2195 (write_queue_push, write_queue_pop): New functions.
2196 (send_process): Use them to maintain correct ordering of process
2197 writes (Bug#10815).
2198
9a900ca9
PE
21992012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2200
310fbfa8
PE
2201 * lisp.h (eassert): Assume C89 or later.
2202 This removes the need for CHECK.
2203 (CHECK): Remove. Its comments about always evaluating its
2204 argument were confusing, as 'eassert' typically does not evaluate
2205 its argument.
2206
27bb1ca4
PE
2207 * coding.c (produce_chars): Use ptrdiff_t, not int.
2208
9a900ca9
PE
2209 * xterm.c (x_draw_underwave): Check for integer overflow.
2210 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2211
41b7f8bc 22122012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2213
2214 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2215 referenced (Bug#11583).
2216
9b0e3eba
AA
22172012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2218
2219 Implement wave-style variant of underlining.
2220 * dispextern.h (face_underline_type): New enum.
2221 (face): Add field for underline type.
2222 * nsterm.m (ns_draw_underwave): New function.
2223 (ns_draw_text_decoration): Use it.
2224 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2225 New functions.
2226 (x_draw_glyph_string): Use them.
2227 * xfaces.c (Qline, Qwave): New Lisp objects.
2228 (check_lface_attrs, merge_face_ref)
1053a871
SM
2229 (Finternal_set_lisp_face_attribute, realize_x_face):
2230 Handle wave-style underline face attributes.
9b0e3eba
AA
2231 * xterm.c (x_draw_underwave): New function.
2232 (x_draw_glyph_string): Use it.
2233
0fb52f11
JB
22342012-06-16 Juanma Barranquero <lekktu@gmail.com>
2235
2236 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2237 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2238 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2239 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2240 ($(BLD)/w32select.$(O)): Update dependencies.
2241
e5560ff7
AS
22422012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2243
2244 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2245 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2246 * character.c (_fetch_multibyte_char_p): Remove.
2247 * alloc.c: Include "character.h" before "buffer.h".
2248 * bidi.c: Likewise.
2249 * buffer.c: Likewise.
2250 * bytecode.c: Likewise.
2251 * callint.c: Likewise.
2252 * callproc.c: Likewise.
2253 * casefiddle.c: Likewise.
2254 * casetab.c: Likewise.
2255 * category.c: Likewise.
2256 * cmds.c: Likewise.
2257 * coding.c: Likewise.
2258 * composite.c: Likewise.
2259 * dired.c: Likewise.
2260 * dispnew.c: Likewise.
2261 * doc.c: Likewise.
2262 * dosfns.c: Likewise.
2263 * editfns.c: Likewise.
2264 * emacs.c: Likewise.
2265 * fileio.c: Likewise.
2266 * filelock.c: Likewise.
2267 * font.c: Likewise.
2268 * fontset.c: Likewise.
2269 * fringe.c: Likewise.
2270 * indent.c: Likewise.
2271 * insdel.c: Likewise.
2272 * intervals.c: Likewise.
2273 * keyboard.c: Likewise.
2274 * keymap.c: Likewise.
2275 * lread.c: Likewise.
2276 * macros.c: Likewise.
2277 * marker.c: Likewise.
2278 * minibuf.c: Likewise.
2279 * nsfns.m: Likewise.
2280 * nsmenu.m: Likewise.
2281 * print.c: Likewise.
2282 * process.c: Likewise.
2283 * regex.c: Likewise.
2284 * region-cache.c: Likewise.
2285 * search.c: Likewise.
2286 * syntax.c: Likewise.
2287 * term.c: Likewise.
2288 * textprop.c: Likewise.
2289 * undo.c: Likewise.
2290 * unexsol.c: Likewise.
2291 * w16select.c: Likewise.
2292 * w32fns.c: Likewise.
2293 * w32menu.c: Likewise.
2294 * window.c: Likewise.
2295 * xdisp.c: Likewise.
2296 * xfns.c: Likewise.
2297 * xmenu.c: Likewise.
2298 * xml.c: Likewise.
2299 * xselect.c: Likewise.
2300
2f07e6af
EZ
23012012-06-16 Eli Zaretskii <eliz@gnu.org>
2302
1053a871
SM
2303 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2304 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2305 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2306 row.
2307 (handle_face_prop): Use chunk-relative overlay string index when
2308 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2309 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2310 the rightmost. (Bug#11720)
2f07e6af 2311
29b83cec
AS
23122012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2313
2314 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2315 (CATEGORY_MEMBER): Enforce 1/0 value.
2316 * category.c (_temp_category_set): Remove.
2317
4c5501e9
EZ
23182012-06-16 Eli Zaretskii <eliz@gnu.org>
2319
2320 * window.c (Fdelete_other_windows_internal)
2321 (Fdelete_window_internal): Don't access frame's mouse highlight
2322 info of the initial frame. (Bug#11677)
2323
2b570124
PE
23242012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2325
e93864f9
PE
2326 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2327 Assume USE_2_TAGS_FOR_INTS.
2328 (xreload): Adjust $tagmask width to match recent lisp.h change.
2329
2b570124
PE
2330 Simplify lisp.h in minor ways that should not affect code.
2331 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2332 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2333 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2334 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2335 (INTTYPEBITS): New macro, for clarity.
2336 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2337 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2338 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2339 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2340 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2341
81755f69
JB
23422012-06-13 Juanma Barranquero <lekktu@gmail.com>
2343
2344 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2345
16192a57
GM
23462012-06-13 Glenn Morris <rgm@gnu.org>
2347
2348 * s/bsd-common.h (BSD4_3):
2349 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2350
646b5f55
AS
23512012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2352
2353 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2354 instead of union.
2355 (XLI, XIL): Define.
1053a871
SM
2356 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2357 Use them.
2358 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2359 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2360 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2361 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2362 * frame.c (delete_frame): Remove outdated comment.
2363 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2364 USE_LISP_UNION_TYPE.
2365 (Fw32_unregister_hot_key): Likewise.
2366 (Fw32_toggle_lock_key): Likewise.
2367 * w32menu.c (add_menu_item): Likewise.
2368 (w32_menu_display_help): Use XIL instead of checking
2369 USE_LISP_UNION_TYPE.
2370 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2371 (init_heap): Likewise.
2372 * w32term.c (w32_read_socket): Update comment.
2373
1d3823c9
GM
23742012-06-13 Glenn Morris <rgm@gnu.org>
2375
c62ff706
GM
2376 * s/usg5-4-common.h, src/s/unixware.h:
2377 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2378
1d3823c9
GM
2379 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2380
bfe3e0a2
PE
23812012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2382
2383 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2384 * alloc.c (make_number) [!defined make_number]:
2385 Remove, as lisp.h always defines this now.
2386 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2387 (roundup_size): Verify that it is a power of 2.
2388 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2389 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2390 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2391 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2392 USE_LSB_TAG now is always defined to be either 0 or 1.
2393 All uses changed.
2394 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2395 code works fine either way, and efficiency is not a concern here,
2396 as the union type is for debugging, not for production.
2397 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2398 Use an inline function on all platforms when using the union type,
2399 since this is simpler and 'static inline' can be used portably
2400 within Emacs now.
2401 (LISP_INITIALLY_ZERO): New macro.
2402 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2403 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2404
45fa9c0f
GM
24052012-06-12 Glenn Morris <rgm@gnu.org>
2406
b4492cba
GM
2407 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2408
2409 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2410
45fa9c0f
GM
2411 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2412 Move BROKEN_SIGIO to configure.
2413
2414 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2415 Move NO_TERMIO to configure.
2416
0e25d334
CY
24172012-06-12 Chong Yidong <cyd@gnu.org>
2418
2419 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2420 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2421 MagickExportImagePixels is undefined.
2422
43682bb6
PE
24232012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2424
2425 * image.c (imagemagick_load_image): Remove unused label.
2426
a9be7d2b
GM
24272012-06-11 Glenn Morris <rgm@gnu.org>
2428
2429 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2430 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2431 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2432 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2433
3017f87f
SM
24342012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2435
2436 * alloc.c (make_byte_code): New function.
2437 (Fmake_byte_code): Use it. Don't purify here.
2438 * lread.c (read1): Use it as well to avoid extra allocation.
2439
1b9b4cf4
CY
24402012-06-11 Chong Yidong <cyd@gnu.org>
2441
2442 * image.c (imagemagick_load_image): Implement transparency.
2443
95988fcf
AS
24442012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2445
2446 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2447 account for preceding backslashes. (Bug#11663)
2448
cd4eb164
CY
24492012-06-09 Chong Yidong <cyd@gnu.org>
2450
2451 * term.c: Support italics in capable terminals (Bug#9652).
2452 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2453 (turn_on_face): Output using TS_enter_italic_mode if available.
2454 Don't handle unused blinking and alt-charset cases.
2455 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2456 and tty_alt_charset_p cases.
2457 (tty_capable_p, init_tty): Support italics.
2458
2459 * termchar.h (struct tty_display_info): Add field for italics.
2460 Remove unused blink field.
2461
2462 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2463 Handle slant.
2464
2465 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2466 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2467 tty_alt_charset_p. Add tty_italic_p.
2468
ff88beb8
MA
24692012-06-09 Michael Albinus <michael.albinus@gmx.de>
2470
2471 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2472 dbus_type_is_basic if available.
2473 (xd_extract_signed, xd_extract_unsigned): Rename from
2474 extract_signed and extract_unsigned, respectively. Adapt callers.
2475
44286096
CY
24762012-06-09 Chong Yidong <cyd@gnu.org>
2477
1682701f
CY
2478 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2479
44286096
CY
2480 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2481 case (Bug#9752).
2482
d86feb17
PE
24832012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 * xdisp.c (vmessage): Treat frame message as multibyte.
2486 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2487 would generate the diagnostic "Making \302\247 buffer-local while
2488 let-bound!".
2489
d5c20fe8
EZ
24902012-06-08 Eli Zaretskii <eliz@gnu.org>
2491
2492 * dispnew.c (showing_window_margins_p): Undo last change, which
2493 was done due to an inadvertent commit.
2494 (adjust_frame_glyphs_for_frame_redisplay): Do call
2495 showing_window_margins_p.
2496
513749ee
SM
24972012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2498
2499 * eval.c (Fmake_var_non_special): New primitive.
2500 (syms_of_eval): Defsubr it.
2501 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2502
d4a8f5c1
JB
25032012-06-08 Juanma Barranquero <lekktu@gmail.com>
2504
2505 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2506 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2507
8bbbc977
EZ
25082012-06-08 Eli Zaretskii <eliz@gnu.org>
2509
2510 * alloc.c (allocate_vectorlike): Fix last change.
2511
f3372c87
DA
25122012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2513
2514 Block-based vector allocation of small vectors.
2515 * lisp.h (struct vectorlike_header): New field `nbytes',
2516 adjust comment accordingly.
2517 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2518 to denote vector blocks. Adjust users (live_vector_p,
2519 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2520 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2521 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2522 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2523 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2524 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2525 (roundup_size): New constant.
2526 (struct vector_block): New data type.
2527 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2528 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2529 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2530 (sweep_vectors): New functions.
2531 (allocate_vectorlike): Return `zero_vector' as the only vector of
2532 0 items. Allocate new vector from block if vector size is less than
2533 or equal to VBLOCK_BYTES_MAX.
2534 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2535 (init_alloc_once): Add call to init_vectors.
2536
4f18a4ed
SM
25372012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2538
2539 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2540
86f158bc
PE
25412012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2542
2543 * doprnt.c (doprnt): Truncate multibyte char correctly.
2544 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2545 would mishandle a string argument "Xc" if X was a multibyte
2546 character of length 2: it would truncate after X's first byte
2547 rather than including all of X.
2548
c5cfcbe0
CY
25492012-06-06 Chong Yidong <cyd@gnu.org>
2550
2551 * buffer.c (word_wrap): Doc fix.
2552
c05cf390
PE
25532012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2554
2555 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2556
0c3461de
GM
25572012-06-03 Glenn Morris <rgm@gnu.org>
2558
2559 * xdisp.c (tool-bar-style): Doc fix.
2560
c71232db
UM
25612012-06-03 Ulrich Müller <ulm@gentoo.org>
2562
2563 * Makefile.in (PAXCTL): Define.
2564 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2565 binary via PaX flags if the paxctl utility is available.
2566 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2567 Restore PaX flags to their default. (Bug#11398)
2568
383f7350
CY
25692012-06-03 Chong Yidong <cyd@gnu.org>
2570
2571 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2572 buffer (Bug#11226).
2573
5f2c76c6
CY
25742012-06-03 Chong Yidong <cyd@gnu.org>
2575
2576 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2577 (note_mode_line_or_margin_highlight): If there is no help echo,
2578 use mode-line-default-help-echo. Handle the case where the mouse
2579 position is past the end of the mode line string.
2580
2581 * buffer.c (buffer_local_value_1): New function, split from
2582 Fbuffer_local_value; can return Qunbound.
2583 (Fbuffer_local_value): Use it.
2584 (Vmode_line_format): Docstring tweaks.
2585
773d47f6
PE
25862012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2587
2588 * sysdep.c (system_process_attributes): Improve comment.
2589
f2d6a3df
SM
25902012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2591
2592 * keyboard.c: Export real-this-command to Elisp.
2593 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2594 and DEFVAR it. Update all users.
2595
63810350
PE
25962012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2597
7bd5c1f4
PE
2598 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2599
63810350
PE
2600 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2601 Convert pctcpu and pctmem to Lisp float properly.
2602 Let the compiler fold better, as 100.0/0x8000 is exact.
2603
a2821611
AS
26042012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2605
2606 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2607 cons_block.
2608
5fceba1d
PE
26092012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2610
2611 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2612
c98ff5dd
DA
26132012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2614
2615 For a 'struct window', replace some Lisp_Object fields to
2616 bitfields where appropriate, remove unused fields.
2617 * window.h (struct window): Remove unused 'last_mark_x' and
2618 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2619 change it's type from Lisp_Object to bitfield.
2620 Change type of 'force_start', 'optional_new_start',
2621 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2622 fields from Lisp_Object to bitfield. Adjust users accordingly.
2623
ca34e0be
PE
26242012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2625
2626 Pacify gcc -Wdouble-precision when using Xaw.
2627 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2628 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2629 Use 'float' consistently, rather than 'float' in most places
2630 and 'double' in a couple of places.
2631
efc00ab1 26322012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2633
2634 * xdisp.c (handle_stop): Detect whether we have overlay strings
2635 loaded by testing it->current.overlay_string_index to be
2636 non-negative, instead of checking whether n_overlay_strings is
2637 positive. (Bug#11587)
2638
efc00ab1 26392012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2640
2641 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2642
2643 * doc.c (Fsubstitute_command_keys): Doc fix.
2644
efc00ab1 26452012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2646
2647 * search.c (search_buffer): Remove calls to
2648 r_alloc_inhibit_buffer_relocation, as it is now called by
2649 maybe_unify_char, which was the cause of relocation of buffer text
2650 in bug#11519.
2651
efc00ab1 26522012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2653
2654 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2655 for the duration of call to load_charset, to avoid problems with
2656 callers of maybe_unify_char that access buffer text through C
2657 pointers.
2658
2659 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2660 decrement the inhibition flag, instead of just setting or
2661 resetting it.
2662
ba93a187
PE
26632012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2664
2665 Remove obsolete '#define static' cruft.
2666 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2667 This #undef was "temporary" in 2000; it is no longer needed
2668 now that '#define static' has gone away.
2669 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2670 (gray_bitmap_bits): Remove; no longer needed.
2671 All uses replaced with definiens.
2672 * xterm.c: Include "bitmaps/gray.xbm".
2673
9e4bf381
PE
26742012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2675
2676 Clean up __executable_start, monstartup when --enable-profiling.
2677 The following changes affect the code only when profiling.
2678 * dispnew.c (__executable_start): Rename from safe_bcopy.
2679 Define only on platforms that need it.
2680 * emacs.c: Include <sys/gmon.h> when profiling.
2681 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2682 (__executable_start): Remove decl, since lisp.h does it now.
2683 (safe_bcopy): Remove decl; no longer has that name.
2684 (main): Coalesce #if into single bit of code, for simplicity.
2685 Cast pointers to uintptr_t, since standard libraries want integers
2686 and not pointers.
2687 * lisp.h (__executable_start): New decl.
2688
32d72c2f
GM
26892012-05-31 Glenn Morris <rgm@gnu.org>
2690
2691 * image.c (Fimagemagick_types): Doc fix.
2692
baac5bc7
JM
26932012-05-30 Jim Meyering <meyering@redhat.com>
2694
2695 * callproc.c (Fcall_process_region): Include directory component
2696 in mkstemp error message (Bug#11586).
2697
72cb32cf
PE
26982012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2699
2700 * alloc.c, lisp.h (make_pure_vector): Now static.
2701
61b108cc
SM
27022012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2703
2704 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2705 Move to byte-run.el.
2706 (Fautoload): Do the hash-doc more carefully.
2707 * data.c (Fdefalias): Purify definition, except for keymaps.
2708 (Qdefun): Move from eval.c.
2709 * lisp.h (Qdefun): Remove.
2710 * lread.c (read1): Tiny simplification.
2711
471fe23d
TN
27122012-05-29 Troels Nielsen <bn.troels@gmail.com>
2713
934f3f58 2714 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2715 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2716 Bug#9642, but explicitly check that the buffer the overlay would
2717 be moved to is live and rearrange lines to make sure that errors
2718 will not put the overlay in an inconsistent state.
2719 (Fdelete_overlay): Cosmetics.
2720
85d0efd1
EZ
27212012-05-28 Eli Zaretskii <eliz@gnu.org>
2722
2723 * w32term.c (my_bring_window_to_top): New function.
2724 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2725 could be different from the original one.
2726 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2727 (Bug#11513)
2728
2729 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2730 by calling BringWindowToTop.
2731
2732 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2733 (WM_EMACS_END): Increase by one.
2734
da92a98c
PE
27352012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2736
2737 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2738 This avoids undefined behavior that might cause the eassert
2739 to not catch an out-of-range value.
2740
74d1f848
JB
27412012-05-28 Juanma Barranquero <lekktu@gmail.com>
2742
2743 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2744 Update dependencies.
2745
9e1a06fc
EZ
27462012-05-27 Eli Zaretskii <eliz@gnu.org>
2747
2748 * bidi.c (bidi_mirror_char): Fix last change.
2749
f3dd7312
AS
27502012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2751
2752 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2753 when referring to sectname field in printf format.
2754
81899c91
PE
27552012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2756
57b81a9f
PE
2757 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2758 Only r_alloc_inhibit_buffer_relocation needed to be added;
2759 the others were already declared.
2760
81899c91
PE
2761 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2762 before checking whether it's out of range. Put the check inside
2763 eassert. See
2764 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2765
33017faf 27662012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2767
2768 * callproc.c (Fcall_process): Restore a line that was accidentally
2769 commented out in the 2011-02-13 change (bug#11547).
2770
33017faf 27712012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2772
2773 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2774 defined on ralloc.c.
2775
2776 * buffer.c [REL_ALLOC]: Remove prototypes of
2777 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2778 they are now on lisp.h.
2779
2780 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2781
2782 * search.c (search_buffer): Use it to inhibit relocation of buffer
2783 text while re_search_2 is doing its job, because re_search_2 is
2784 passed C pointers to buffer text. (Bug#11519)
2785
23415acf
EZ
2786 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2787 Update value to 24.
2788
44e27368
EZ
2789 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2790 state after an additional call to move_it_in_display_line_to, keep
2791 the values of it->max_ascent and it->max_descent found for the
2792 entire line.
2793 (pos_visible_p): Revert the comparison against bottom_y to what it
2794 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2795 (Bug#11464)
2796
c1892f11
PE
27972012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2798
2799 Fix coding-related core dumps with gcc -ftrapv.
2800 The code was computing A - B, where A and B are pointers, and B is
2801 random garbage. This can lead to core dumps on platforms that
2802 have special pointer registers, and it also leads to core dumps on
2803 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2804 A - B only when B is initialized properly.
2805 * coding.c (coding_set_source, coding_set_destination): Return void.
2806 (coding_change_source, coding_change_destinations): New functions,
2807 with the old behaviors of coding_set_source and coding_set_destination.
2808 All callers that need an offset changed to use these new functions.
2809
eb7afdad
GM
28102012-05-26 Glenn Morris <rgm@gnu.org>
2811
2812 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2813
f12fdf02
EZ
28142012-05-26 Eli Zaretskii <eliz@gnu.org>
2815
53a63be6 2816 Extend mouse support on W32 text-mode console.
61b108cc
SM
2817 * xdisp.c (draw_row_with_mouse_face):
2818 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2819
eb3f6f01 2820 * w32console.c: Include window.h.
61b108cc
SM
2821 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2822 New functions.
eb3f6f01
EZ
2823 (initialize_w32_display): Initialize mouse-highlight data.
2824
53a63be6
EZ
2825 * w32inevt.c: Include termchar.h and window.h.
2826 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2827 moves, call note_mouse_highlight. If help_echo changed, call
2828 gen_help_event to produce help-echo message in the echo area.
2829 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2830 highlight info.
2831
4cfd81f6
PE
28322012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2833
2834 * lread.c (read1): Simplify slightly to avoid an overflow warning
2835 with GCC 4.7.0 on x86-64.
2836
4446092a
EZ
28372012-05-26 Eli Zaretskii <eliz@gnu.org>
2838
2839 * bidi.c (bidi_mirror_char): Revert last change: an int is
2840 definitely wide enough here.
2841
42b2a986 28422012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2843
42b2a986 2844 Fix integer width and related bugs (Bug#9874).
eb106a49 2845 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2846 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2847 (string_bytes, check_sblock, allocate_string_data):
2848 (compact_small_strings, Fmake_bool_vector, make_string)
2849 (make_unibyte_string, make_multibyte_string)
2850 (make_string_from_bytes, make_specified_string)
2851 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2852 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2853 (mark_vectorlike):
2854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2855 (allocate_pseudovector):
2856 Use int, not EMACS_INT, where int is wide enough.
2857 (inhibit_garbage_collection, Fgarbage_collect):
2858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2859 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2860 int might not be wide enough.
2861 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2862 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2863 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2864 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2865 (bidi_level_of_next_char, bidi_move_to_visually_next):
2866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2867 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2868 (Fkill_buffer, Fset_buffer_major_mode)
2869 (advance_to_char_boundary, Fbuffer_swap_text)
2870 (Fset_buffer_multibyte, overlays_at, overlays_in)
2871 (overlay_touches_p, struct sortvec, record_overlay_string)
2872 (overlay_strings, recenter_overlay_lists)
2873 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2874 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2875 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2876 (Foverlay_recenter, last_overlay_modification_hooks_used)
2877 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2879 (validate_region): Omit unnecessary test for b <= e,
2880 since that's guaranteed by the previous test.
d311d28c
PE
2881 (adjust_overlays_for_delete): Avoid pos + length overflow.
2882 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2883 (report_overlay_modification):
2884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2885 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2886 Omit pointer cast, which isn't needed anyway, and doesn't work
2887 after the EMACS_INT -> ptrdiff_t change.
02481186 2888 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2889 * buffer.h: Adjust decls to match defn changes elsewhere.
2890 (struct buffer_text, struct buffer):
2891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2892 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2893 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2894 not int, to avoid needless 32-bit limit on 64-bit hosts.
2895 (exec_byte_code): Use tighter memory-full test, one that checks
2896 for alloca overflow. Don't compute the address of the object just
2897 before an array, as that's not portable. Use EMACS_INT, not
2898 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2899 * callint.c (Fcall_interactively):
2900 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2901 * callproc.c (call_process_kill, Fcall_process):
2902 Don't assume pid_t fits into an Emacs fixnum.
2903 (call_process_cleanup, Fcall_process, child_setup):
2904 Don't assume pid_t fits into int.
2905 (call_process_cleanup, Fcall_process, delete_temp_file)
2906 (Fcall_process_region):
2907 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2908 (Fcall_process): Simplify handling of volatile integers.
2909 Use int, not EMACS_INT, where int will do.
2910 * casefiddle.c (casify_object, casify_region, operate_on_word)
2911 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2912 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2913 (casify_object): Avoid integer overflow when overallocating buffer.
2914 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2915 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2916 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2917 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2918 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2919 integers are now checked earlier. All uses replaced with XINT.
2920 (ccl_driver):
2921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2922 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2923 (ccl_driver, Fregister_code_conversion_map):
2924 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2925 (resolve_symbol_ccl_program): Check that vector header is in range.
2926 Always copy the vector, so that we can check its contents reliably
2927 now rather than having to recheck each instruction as it's being
2928 executed. Check that vector words fit in 'int'.
2929 (ccl_get_compiled_code, Fregister_ccl_program)
2930 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2931 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2932 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2933 contents are in range.
2934 (Fccl_execute_on_string): Check that status is in range.
2935 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2936 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2937 Accept and return EMACS_INT, not int, because callers can pass values
2938 out of 'int' range.
2939 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2940 (multibyte_chars_in_text, parse_str_as_multibyte)
2941 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2942 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2943 (string_escape_byte8, Fget_byte):
2944 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2945 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2946 avoid mishandling large integers.
2947 * character.h: Adjust decls to match defn changes elsewhere.
2948 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2949 (Ffind_charset_region):
2950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2951 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2952 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2953 Don't assume fixnum fits in int.
d311d28c
PE
2954 (load_charset_map_from_vector, Fmap_charset_chars):
2955 Remove now-unnecessary CHECK_NATNUMs.
2956 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2957 Don't rely on undefined behavior with signed left shift overflow.
2958 Don't assume unsigned int fits into fixnum, or that fixnum fits
2959 into unsigned int. Don't require max_code to be a valid fixnum;
2960 that's not true for gb10830 4-byte on a 32-bit host. Allow
2961 invalid_code to be a cons, for the same reason. Require code_offset
2962 to be a character. Avoid int overflow if max_char is close
2963 to INT_MAX.
2964 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2965 this is intended anyway and avoids some undefined behavior.
2966 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2967 INDEX_TO_CODE_POINT, as that's what it expects.
2968 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2969 * charset.h (DECODE_CHAR): Return int, not unsigned;
2970 this is what was intended anyway, and it avoids undefined behavior.
2971 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2972 integer-overflow issues.
2973 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2974 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2975 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2976 * chartab.c (Fmake_char_table, Fset_char_table_range)
2977 (uniprop_get_decoder, uniprop_get_encoder):
2978 Don't assume fixnum fits in int.
2979 * cmds.c (move_point): New function, that does the gist of
2980 Fforward_char and Fbackward_char, but does so while checking
2981 for integer overflow more accurately.
c96e5d6a 2982 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2983 (Fforward_line, Fend_of_line, internal_self_insert)
2984 (internal_self_insert):
2985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2986 Fix a FIXME, by checking for integer overflow when calculating
2987 target_clm and actual_clm.
2988 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2989 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2990 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2991 (coding_alloc_by_making_gap, alloc_destination)
2992 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2993 (encode_coding_utf_16, detect_coding_emacs_mule)
2994 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2995 (detect_coding_iso_2022, decode_coding_iso_2022)
2996 (encode_invocation_designation, encode_designation_at_bol)
2997 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2998 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2999 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3000 (encode_coding_ccl, encode_coding_raw_text)
3001 (detect_coding_charset, decode_coding_charset)
3002 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3003 (produce_composition, produce_charset, produce_annotation)
3004 (decode_coding, handle_composition_annotation)
3005 (handle_charset_annotation, consume_chars, decode_coding_gap)
3006 (decode_coding_object, encode_coding_object, detect_coding_system)
3007 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3008 (code_convert_region, code_convert_string)
8f50130c
PE
3009 (Fdefine_coding_system_internal)
3010 (coding_set_source, coding_set_destination):
d311d28c
PE
3011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3012 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3013 (Fdefine_coding_system_internal):
3014 Don't assume fixnums fit in int.
3015 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3016 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3017 (Funencodable_char_position, Fcheck_coding_systems_region)
3018 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3019 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3020 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3021 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3022 Don't access memory outside of the args array.
d311d28c 3023 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3024 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3025 result of ENCODE_CHAR.
d311d28c
PE
3026 * coding.h: Adjust decls to match defn changes elsewhere.
3027 (struct coding_system):
3028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3029 * composite.c (get_composition_id, find_composition)
3030 (run_composition_function, update_compositions)
3031 (compose_text, composition_gstring_put_cache)
3032 (composition_gstring_p, composition_gstring_width)
3033 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3034 (composition_compute_stop_pos, composition_reseat_it)
3035 (composition_update_it, struct position_record)
3036 (find_automatic_composition, composition_adjust_point)
3037 (Fcomposition_get_gstring, Ffind_composition_internal):
3038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3039 (update_compositions):
3040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3041 * composite.h: Adjust decls to match defn changes elsewhere.
3042 (struct composition):
3043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3044 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3045 Do not attempt to compute the address of the object just before a
3046 buffer; this is not portable.
3047 (Faref, Faset):
3048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3049 (Faset): Use int, not EMACS_INT, where int is wide enough.
3050 (Fstring_to_number): Don't assume fixnums fit in int.
3051 (Frem): Don't assume arg is nonnegative.
3052 * dbusbind.c (xd_append_arg): Check for integers out of range.
3053 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3054 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3055 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3056 (xd_get_connection_references): Return ptrdiff_t, not int.
3057 All uses changed.
3058 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3059 (xd_read_message_1):
3060 Use int, not unsigned, where the dbus API uses int.
3061 (Fdbus_message_internal): Don't overflow mtype.
3062 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3063 * dired.c (directory_files_internal, file_name_completion, scmp)
3064 (file_name_completion_stat):
3065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3066 (file_name_completion): Don't overflow matchcount.
3067 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3068 * dispextern.h: Adjust decls to match defn changes elsewhere.
3069 (struct text_pos, struct glyph, struct bidi_saved_info)
3070 (struct bidi_string_data, struct bidi_it, struct composition_it)
3071 (struct it):
3072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3073 (struct display_pos, struct composition_it, struct it):
3074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3075 * dispnew.c (increment_matrix_positions)
3076 (increment_row_positions, mode_line_string)
3077 (marginal_area_string):
3078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3079 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3081 (duration_to_sec_usec): New function, to check for overflow better.
3082 (Fsleep_for, sit_for): Use it.
3083 * doc.c (get_doc_string, store_function_docstring):
3084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3085 (get_doc_string, Fsnarf_documentation):
3086 Use int, not EMACS_INT, where int is wide enough.
3087 (get_doc_string):
3088 Use SAFE_ALLOCA, not alloca.
3089 Check for overflow when converting EMACS_INT to off_t.
3090 * doprnt.c (doprnt):
3091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3092 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3093 Don't assume uid_t fits into fixnum.
3094 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3095 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3096 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3097 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3098 (general_insert_function)
3099 (Finsert_char, make_buffer_string, make_buffer_string_both)
3100 (update_buffer_properties, Fbuffer_substring)
3101 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3102 (Fsubst_char_in_region, check_translation)
3103 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3104 (transpose_markers, Ftranspose_regions):
3105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3106 (clip_to_bounds): Move to lisp.h as an inline function).
3107 (Fconstrain_to_field): Don't assume integers are nonnegative.
3108 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3109 (Fsubst_char_in_region, Fsave_restriction):
3110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3111 (Femacs_pid): Don't assume pid_t fits into fixnum.
3112 (lo_time): Use int, not EMACS_INT, when int suffices.
3113 (lisp_time_argument): Check for usec out of range.
3114 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3115 (Fuser_login_name, Fuser_full_name): Signal an error
3116 if a uid argument is out of range, rather than relying on
3117 undefined behavior.
c8d5c857
PE
3118 (Fformat_time_string): Remove now-unnecessary check.
3119 lisp_time_argument checks for out-of-range usec now.
243e0530 3120 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3121 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3122 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3123 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3124 (init_cmdargs, Fdump_emacs):
3125 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3126 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3127 the bottom (typically) 32 bits of the fixnum.
3128 * eval.c (specpdl_size, call_debugger):
3129 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3130 (when_entered_debugger, Fbacktrace_debug):
3131 Don't assume fixnum can fit in int.
3132 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3133 the object just before a buffer; this is not portable.
3134 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3135 (grow_specpdl, unbind_to):
3136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3137 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3138 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3139 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3140 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3141 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3143 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3144 (a_write, e_write):
3145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3146 (Fcopy_file, non_regular_nbytes, read_non_regular)
3147 (Finsert_file_contents):
3148 Use int, not EMACS_INT, where int is wide enough.
3149 (READ_BUF_SIZE): Verify that it fits in int.
3150 (Finsert_file_contents): Check that counts are in proper range,
3151 rather than assuming fixnums fit into ptrdiff_t etc.
3152 Don't assume fixnums fit into int.
125b3835 3153 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3154 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3155 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3156 (string_char_to_byte, string_byte_to_char)
3157 (string_make_multibyte, string_to_multibyte)
3158 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3159 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3160 (substring_both, Fdelete, internal_equal, Ffillarray)
3161 (Fclear_string, mapcar1)
3162 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3163 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3164 (larger_vector, make_hash_table, maybe_resize_hash_table)
3165 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3166 (Fmaphash, secure_hash):
3167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3168 (concat): Check for string index and length overflow.
3169 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3170 (Frequire):
3171 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3172 (larger_vector): New API (vec, incr_min, size_max) replaces old
3173 one (vec, new_size, init). This catches size overflow.
3174 INIT was removed because it was always Qnil.
3175 All callers changed.
3176 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3177 the upper bound on a hash table index size.
3178 (make_hash_table, maybe_resize_hash_table): Use it.
3179 (secure_hash): Computer start_byte and end_byte only after
3180 they're known to be in ptrdiff_t range.
3181 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3182 (Ffont_get_glyphs, Ffont_at):
3183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3184 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3185 (Flist_fonts, Fopen_font):
3186 Don't assume fixnum can fit in int.
3187 (check_gstring): Don't assume index can fit in int.
3188 (font_match_p): Check that fixnum is a character, not a nonnegative
3189 fixnum, since the later code needs to stuff it into an int.
3190 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3191 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3192 conversion overflow issues.
3193 (Fopen_font): Check for integer out of range.
3194 (Ffont_get_glyphs): Don't assume index can fit in int.
3195 * font.h: Adjust decls to match defn changes elsewhere.
3196 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3197 integer overflow.
3198 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3199 printmax_t, where ptrdiff_t is wide enough.
3200 (Finternal_char_font):
3201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3202 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3203 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3204 (Fset_frame_position, x_set_frame_parameters)
3205 (x_set_line_spacing, x_set_border_width)
3206 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3207 Check that fixnums are in proper range for system types.
3208 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3209 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3210 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3211 Use SAFE_ALLOCA_LISP, not alloca.
3212 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3213 intptr_t is wide enough.
3214 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3215 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3216 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3217 Check for fixnum out of range.
3218 * ftfont.c (ftfont_list): Don't assume index fits in int.
3219 Check that fixnums are in proper range for system types.
3220 (ftfont_shape_by_flt):
3221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3222 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3223 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3224 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3225 Check that fixnums are in proper range for system types.
3226 * gnutls.h: Adjust decls to match defn changes elsewhere.
3227 * gtkutil.c (xg_dialog_run):
3228 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3229 (update_frame_tool_bar):
3230 Check that fixnums are in proper range for system types.
3231 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3232 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3233 * indent.c (last_known_column, last_known_column_point):
3234 (current_column_bol_cache):
3235 (skip_invisible, current_column, check_display_width):
3236 (check_display_width, scan_for_column, current_column_1)
3237 (Findent_to, Fcurrent_indentation, position_indentation)
3238 (indented_beyond_p, Fmove_to_column, compute_motion):
3239 (Fcompute_motion, Fvertical_motion):
3240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3241 (last_known_column_modified): Use EMACS_INT, not int.
3242 (check_display_width):
3243 (Fcompute_motion):
3244 Check that fixnums and floats are in proper range for system types.
3245 (compute_motion): Don't assume index or fixnum fits in int.
3246 (compute_motion, Fcompute_motion):
3247 Use int, not EMACS_INT, when it is wide enough.
3248 (vmotion): Omit local var start_hpos that is always 0; that way
3249 we don't need to worry about overflow in expressions involving it.
3250 * indent.h: Adjust decls to match defn changes elsewhere.
3251 (struct position):
3252 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3253 Use int, not EMACS_INT, where int is wide enough.
3254 Remove unused members ovstring_chars_done and tab_offset;
3255 all uses removed.
3256 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3257 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3258 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3259 (make_gap, copy_text, insert, insert_and_inherit)
3260 (insert_before_markers, insert_before_markers_and_inherit)
3261 (insert_1, count_combining_before, count_combining_after)
3262 (insert_1_both, insert_from_string)
3263 (insert_from_string_before_markers, insert_from_string_1)
3264 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3265 (adjust_after_replace, adjust_after_insert, replace_range)
3266 (replace_range_2, del_range, del_range_1, del_range_byte)
3267 (del_range_both, del_range_2, modify_region)
3268 (prepare_to_modify_buffer, signal_before_change)
3269 (signal_after_change, Fcombine_after_change_execute):
3270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3271 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3272 (balance_an_interval, split_interval_right, split_interval_left)
3273 (find_interval, next_interval, update_interval)
3274 (adjust_intervals_for_insertion, delete_node, delete_interval)
3275 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3276 (static_offset_intervals, offset_intervals)
3277 (merge_interval_right, merge_interval_left, make_new_interval)
3278 (graft_intervals_into_buffer, temp_set_point_both)
3279 (temp_set_point, set_point, adjust_for_invis_intang)
3280 (set_point_both, move_if_not_intangible, get_property_and_range)
3281 (get_local_map, copy_intervals, copy_intervals_to_string)
3282 (compare_string_intervals, set_intervals_multibyte_1):
3283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3284 * intervals.h: Adjust decls to match defn changes elsewhere.
3285 (struct interval):
3286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3287 * keyboard.c (this_command_key_count, this_single_command_key_start)
3288 (before_command_key_count, before_command_echo_length, echo_now)
3289 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3290 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3291 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3292 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3293 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3294 (last_non_minibuf_size, last_point_position, echo_truncate)
3295 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3296 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3297 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3298 (stuff_buffered_input):
3299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3300 (last_auto_save, command_loop_1, read_char):
3301 Use EMACS_INT, not int, to avoid integer overflow.
3302 (record_char): Avoid overflow in total_keys computation.
3303 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3304 * keyboard.h: Adjust decls to match defn changes elsewhere.
3305 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3306 (Fkey_description, Fdescribe_vector, Flookup_key):
3307 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3308 (click_position): New function, to check that positions are in range.
3309 (Fcurrent_active_maps):
3310 (describe_command):
3311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3312 (Faccessible_keymaps, Fkey_description):
3313 (preferred_sequence_p):
3314 Don't assume fixnum can fit into int.
3315 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3316 Check for integer overflow in size calculations.
3317 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3318 avoid mishandling large integers.
3319 * lisp.h: Adjust decls to match defn changes elsewhere.
3320 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3321 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3322 (struct Lisp_Marker):
3323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3324 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3325 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3326 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3327 All callers changed.
3328 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3329 Assume the arg has valid form, since it always does.
3330 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3331 unsigned integer system type.
3332 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3333 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3335 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3336 (duration_to_sec_usec): New decl.
3337 * lread.c (read_from_string_index, read_from_string_index_byte)
3338 (read_from_string_limit, readchar, unreadchar, openp)
3339 (read_internal_start, read1, oblookup):
3340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3341 (Fload, readevalloop, Feval_buffer, Feval_region):
3342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3343 (openp): Check for out-of-range argument to 'access'.
3344 (read1): Use int, not EMACS_INT, where int is wide enough.
3345 Don't assume fixnum fits into int.
6efdadfd 3346 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3347 (read_filtered_event): Use duration_to_sec_usec
3348 to do proper overflow checking on durations.
d311d28c
PE
3349 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3350 in size calculation.
3351 (Fexecute_kbd_macro):
3352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3353 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3354 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3355 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3356 (set_marker_both, set_marker_restricted_both, marker_position)
3357 (marker_byte_position, Fbuffer_has_markers_at):
3358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3359 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3360 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3361 It now merely ensures that the menu is large enough, without
3362 necessarily growing it, as this avoids some integer overflow issues.
3363 All callers changed.
3364 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3366 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3367 Use SAFE_ALLOCA_LISP, not alloca.
3368 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3369 to EMACS_INT. Check that fixnums are in proper range for system types.
3370 * minibuf.c (minibuf_prompt_width, string_to_object)
3371 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3372 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3374 (get_minibuffer, read_minibuf_unwind):
3375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3376 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3377 this simplifies overflow checking. All callers changed.
3378 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3379 (Ftest_completion):
3380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3381 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3382 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3383 Check that fixnums are in proper range for system types.
3384 (Fx_create_frame, Fx_show_tip):
3385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3386 * nsfont.m (ns_findfonts, nsfont_list_family):
3387 Don't assume fixnum fits in long.
3388 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3389 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3390 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3391 wide enough.
17fdb222 3392 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3393 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3394 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3395 (PRINTDECLARE, PRINTPREPARE):
3396 (strout, print_string):
3397 (print, print_preprocess, print_check_string_charset_prop)
3398 (print_object):
3399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3400 (PRINTDECLARE):
3401 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3403 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3404 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3405 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3406 (print_error_message): Use SAFE_ALLOCA, not alloca.
3407 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3408 (print_depth, new_backquote_output, print_number_index):
3409 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3410 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3411 (Fset_process_window_size, Fformat_network_address)
3412 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3413 (sigchld_handler):
d311d28c 3414 Check that fixnums are in proper range for system types.
d44287d4 3415 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3416 Check for process-ids out of pid_t range rather than relying on
3417 undefined behavior.
e4d81efc 3418 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3419 (Fformat_network_address, read_process_output, send_process)
3420 (Fprocess_send_region, status_notify):
3421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3422 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3423 (wait_reading_process_output, read_process_output, exec_sentinel):
3424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3425 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3426 (Faccept_process_output): Use duration_to_sec_usec to do proper
3427 overflow checking on durations.
dde14581
PE
3428 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3429 Don't assume pid_t fits in int.
02481186
PE
3430 * process.h (struct Lisp_Process): Members tick and update_tick
3431 are now of type EMACS_INT, not int.
b62b53e8
PE
3432 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3433 configured --with-wide-int.
d311d28c
PE
3434 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3435 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3436 * search.c (looking_at_1, string_match_1):
3437 (fast_string_match, fast_c_string_match_ignore_case)
3438 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3439 (scan_newline, find_before_next_newline, search_command)
3440 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3441 (set_search_regs, wordify):
3442 (Freplace_match):
3443 (Fmatch_data):
3444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3445 (string_match_1, search_buffer, set_search_regs):
3446 (Fmatch_data):
3447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3448 (wordify): Check for overflow in size calculation.
3449 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3450 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3451 Check that fixnums are in proper range for system types.
3452 * sound.c (struct sound_device)
3453 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3455 (Fplay_sound_internal):
3456 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3457 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3458 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3459 (Fparse_partial_sexp):
3460 Don't assume fixnums can fit in int.
3461 (struct lisp_parse_state, find_start_pos, find_start_value)
3462 (find_start_value_byte, find_start_begv)
3463 (update_syntax_table, char_quoted, dec_bytepos)
3464 (find_defun_start, prev_char_comend_first, back_comment):
3465 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3466 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3468 (Finternal_describe_syntax_value): Check that match_lisp is a
3469 character, not an integer, since the code stuffs it into int.
3470 (scan_words, scan_sexps_forward):
3471 Check that fixnums are in proper range for system types.
3472 (Fforward_word):
3473 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3474 (scan_sexps_forward):
3475 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3476 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3477 * syntax.h: Adjust decls to match defn changes elsewhere.
3478 (struct gl_state_s):
3479 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3480 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3481 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3482 * sysdep.c (wait_for_termination_1, wait_for_termination)
3483 (interruptible_wait_for_termination, mkdir):
3484 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3485 (emacs_read, emacs_write):
3486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3487 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3488 and double all fit in int.
d311d28c
PE
3489 * term.c (set_tty_color_mode):
3490 Check that fixnums are in proper range for system types.
3491 * termhooks.h (struct input_event):
3492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3493 * textprop.c (validate_interval_range, interval_of)
3494 (Fadd_text_properties, set_text_properties_1)
3495 (Fremove_text_properties, Fremove_list_of_text_properties)
3496 (Ftext_property_any, Ftext_property_not_all)
3497 (copy_text_properties, text_property_list, extend_property_ranges)
3498 (verify_interval_modification):
3499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3500 (Fnext_single_char_property_change)
3501 (Fprevious_single_char_property_change):
3502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3503 (copy_text_properties):
3504 Check for integer overflow in index calculation.
d311d28c
PE
3505 * undo.c (last_boundary_position, record_point, record_insert)
3506 (record_delete, record_marker_adjustment, record_change)
3507 (record_property_change):
3508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3509 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3510 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3511 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3512 (Fx_hide_tip, Fx_file_dialog):
3513 * w32menu.c (set_frame_menubar):
3514 Use ptrdiff_t, not int, for consistency with rest of code.
3515 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3516 (select_window, Fdelete_other_windows_internal)
3517 (window_scroll_pixel_based, window_scroll_line_based)
3518 (Frecenter, Fset_window_configuration):
3519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3520 (Fset_window_hscroll, run_window_configuration_change_hook)
3521 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3522 (Fscroll_other_window, Frecenter):
d311d28c
PE
3523 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3524 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3525 Don't assume fixnum fits in int.
3526 (Fset_window_scroll_bars):
3527 Check that fixnums are in proper range for system types.
3528 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3529 (string_pos, c_string_pos, number_of_chars, init_iterator)
3530 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3531 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3532 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3533 (face_before_or_after_it_pos, handle_invisible_prop)
3534 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3535 (display_prop_intangible_p, string_buffer_position_lim)
3536 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3537 (get_overlay_strings_1, get_overlay_strings)
3538 (iterate_out_of_display_property, forward_to_next_line_start)
3539 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3540 (get_next_display_element, set_iterator_to_next)
3541 (get_visually_first_element, compute_stop_pos_backwards)
3542 (handle_stop_backwards, next_element_from_buffer)
3543 (move_it_in_display_line_to, move_it_in_display_line)
3544 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3545 (add_to_log, message_dolog, message_log_check_duplicate)
3546 (message2, message2_nolog, message3, message3_nolog
3547 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3548 (current_message_1, truncate_echo_area, truncate_message_1)
3549 (set_message, set_message_1, store_mode_line_noprop)
3550 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3551 (text_outside_line_unchanged_p, check_point_in_composition)
3552 (reconsider_clip_changes)
3553 (redisplay_internal, set_cursor_from_row, try_scrolling)
3554 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3555 (redisplay_window, find_last_unchanged_at_beg_row)
3556 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3557 (trailing_whitespace_p, find_row_edges, display_line)
3558 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3559 (display_mode_element, store_mode_line_string)
3560 (pint2str, pint2hrstr, decode_mode_spec)
3561 (display_count_lines, display_string, draw_glyphs)
3562 (x_produce_glyphs, x_insert_glyphs)
3563 (rows_from_pos_range, mouse_face_from_buffer_pos)
3564 (fast_find_string_pos, mouse_face_from_string_pos)
3565 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3567 (safe_call, init_from_display_pos, handle_fontified_prop)
3568 (handle_single_display_spec, load_overlay_strings)
3569 (with_echo_area_buffer, setup_echo_area_for_printing)
3570 (display_echo_area, echo_area_display)
3571 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3572 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3573 (redisplay_window, dump_glyph_row, display_mode_line)
3574 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3575 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3577 (handle_single_display_spec, build_desired_tool_bar_string)
3578 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3579 (get_specified_cursor_type):
3580 Check that fixnums are in proper range for system types.
3581 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3582 (Flookup_image_map):
3583 Don't assume fixnums fit in int.
3584 (compare_overlay_entries):
3585 Avoid mishandling comparisons due to subtraction overflow.
3586 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3587 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3588 (handle_tool_bar_click):
3589 Use int, not unsigned, since we prefer signed and the signedness
3590 doesn't matter here.
3591 (get_next_display_element, next_element_from_display_vector):
3592 Use int, not EMACS_INT, when int is wide enough.
3593 (start_hourglass): Use duration_to_sec_usec to do proper
3594 overflow checking on durations.
3595 * xfaces.c (Fbitmap_spec_p):
3596 Check that fixnums are in proper range for system types.
3597 (compare_fonts_by_sort_order):
3598 Avoid mishandling comparisons due to subtraction overflow.
3599 (Fx_family_fonts, realize_basic_faces):
3600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3601 (Fx_family_fonts):
3602 Don't assume fixnum fits in int.
3603 Use SAFE_ALLOCA_LISP, not alloca.
3604 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3605 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3606 (face_at_buffer_position, face_for_overlay_string)
3607 (face_at_string_position):
3608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3609 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3610 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3611 (Fx_show_tip):
3612 Check that fixnums are in proper range for system types.
3613 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3614 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3616 (Fx_change_window_property): Don't assume fixnums fit in int.
3617 * xfont.c (xfont_chars_supported):
3618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3619 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3620 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3622 * xml.c (parse_region):
3623 * xrdb.c (magic_file_p):
3624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3625 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3626 (x_get_local_selection, x_reply_selection_request)
3627 (x_handle_selection_request, wait_for_property_change):
3628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3629 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3630 short is wide enough.
3631 (x_send_client_event): Don't assume fixnum fits in int.
3632 * xterm.c (x_x_to_emacs_modifiers):
3633 Don't assume EMACS_INT overflows nicely into int.
3634 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3635 may come from Lisp.
3636 (handle_one_xevent): NATNUMP can eval its arg twice.
3637 (x_connection_closed):
3638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3639 * xterm.h: Adjust decls to match defn changes elsewhere.
3640 (struct scroll_bar): Use struct vectorlike_header
3641 rather than rolling our own approximation.
3642 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3643
c6574eb5
GM
36442012-05-25 Glenn Morris <rgm@gnu.org>
3645
3646 * lisp.mk (lisp): Update for more files being compiled now.
3647
e8d32c7e
SM
36482012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3649
48def666
SM
3650 * lread.c: Remove `read_pure' which makes no difference.
3651 (read_pure): Remove var.
3652 (unreadpure): Remove function.
3653 (readevalloop): Don't call read_list with -1 flag.
3654 (read1, read_vector): Don't test read_pure any more.
3655 (read_list): Simplify.
3656
e8d32c7e
SM
3657 * fileio.c, character.h: Minor style tweaks.
3658
4b2addb7
DA
36592012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3660
3661 * window.h (clip_changed): Remove useless declaration.
3662
584461b2
JB
36632012-05-22 Juanma Barranquero <lekktu@gmail.com>
3664
3665 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3666 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3667
34374650
PE
36682012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3669
3670 Remove src/m/*.
3671 This directory predates autoconf and is no longer needed nowadays.
3672 Move its few remaining bits of functionality to where they're needed.
3673 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3674 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3675 * m/template.h: Remove.
3676 * Makefile.in (M_FILE): Remove. All uses removed.
3677 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3678 * lisp.h (USE_LSB_TAG):
3679 * mem-limits.h (EXCEEDS_LISP_PTR):
3680 Use VAL_MAX, not VALBITS, in #if.
3681 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3682 (EMACS_UINT): Define unconditionally now.
3683 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3684 (BITS_PER_EMACS_INT): New constants, replacing
3685 what used to be in config.h, but not useful in #if.
3686 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3687 define them any more.
3688 (VAL_MAX): New macro.
3689 (VALMASK): Use it.
3690 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3691 BITS_PER_EMACS_INT, in #if.
3692 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3693 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3694 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3695 * s/ms-w32.h (DATA_START):
3696 Move here from removed file m/intel386.h.
3697 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3698 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3699
261cb4bb
PE
37002012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3701
3702 Assume C89 or later.
3703 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3704 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3705 (xrealloc):
3706 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3707 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3708 * textprop.c, tparam.c (NULL): Remove.
3709 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3710 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3711 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3712 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3713 * xterm.c (input_signal_count): Assume volatile works.
3714
ff23cd9f
KB
37152012-05-21 Ken Brown <kbrown@cornell.edu>
3716
3717 * xgselect.c (xg_select): Fix first argument in call to 'select'
3718 (bug#11508).
3719
1b170bc6
KB
37202012-05-20 Ken Brown <kbrown@cornell.edu>
3721
3722 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3723 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3724
b2f4d39f
KB
37252012-05-19 Ken Brown <kbrown@cornell.edu>
3726
3727 * xfns.c (x_in_use): Remove `static' qualifier.
3728 * xterm.h (x_in_use): Declare.
3729 * xgselect.c: Include xterm.h.
3730 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3731 and `display_arg' (bug#9754).
3732
003fdae2
PE
37332012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3734
9232a6d9
PE
3735 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3736
003fdae2
PE
3737 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3738 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3739
784b56e2
EZ
37402012-05-18 Eli Zaretskii <eliz@gnu.org>
3741
3742 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3743
3744 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3745 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3746
3747 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3748 reference to image_cache->refcount.
3749 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3750
a0a79cde
JL
37512012-05-17 Juri Linkov <juri@jurta.org>
3752
3753 * search.c (Fword_search_regexp, Fword_search_backward)
3754 (Fword_search_forward, Fword_search_backward_lax)
3755 (Fword_search_forward_lax): Move functions to isearch.el
3756 (bug#10145, bug#11381).
3757
b0572523
PE
37582012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3759
3760 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3761
9660f5fc
SM
37622012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3763
3764 * lread.c (init_obarray): Declare Qt and Qnil as special.
3765
4374de83
GM
37662012-05-14 Glenn Morris <rgm@gnu.org>
3767
3768 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3769 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3770
dc44c39a
PE
37712012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3772
078c97cb
PE
3773 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3774
dc44c39a
PE
3775 * unexaix.c: Port to more-recent AIX compilers.
3776 (report_error, report_error_1, make_hdr, copy_sym)
3777 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3778 Make arguments const char *, not char *, to avoid violations of C
3779 standard and to fix some AIX warnings reported by Gilles Pion.
3780
e18afed7 37812012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3782
3783 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3784 already have overlays loaded.
3785 (handle_single_display_spec): Before returning without displaying
3786 fringe bitmap, synchronize the bidi iterator with the main display
3787 iterator, by calling iterate_out_of_display_property.
3788 (iterate_out_of_display_property): Detect buffer iteration by
3789 testing that it->string is a Lisp string.
3790 (get_next_display_element): When the current object is exhausted,
3791 and there's something on it->stack, call set_iterator_to_next to
3792 proceed with what's on the stack, instead of returning zero.
3793 (set_iterator_to_next): If called at the end of a Lisp string,
3794 proceed to consider_string_end without incrementing string
3795 position. Don't increment display vector index past the end of
3796 the display vector. (Bug#11417)
c8fb9dc6
EZ
3797 (pos_visible_p): Don't report a position visible when move_it_to
3798 stopped at the last line of window, which happens to be scanned
3799 backwards by the bidi iteration. (Bug#11464)
ac268e67 3800
e18afed7 38012012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3802
3803 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3804 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3805 are on a TTY, and thus unable to display on the fringes.
3806 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3807 so we need to signal to the caller that this is a "replacing"
3808 display spec. This fixes display when the spec is invalid or we
3809 are on a TTY.
3810
e18afed7 38112012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3812
3813 * unexaix.c (make_hdr): Fix typo in prototype.
3814 This bug broke the build on AIX. Problem reported by Gilles Pion.
3815
9d0a235a
MA
38162012-05-14 Michael Albinus <michael.albinus@gmx.de>
3817
3818 * keyboard.c (kbd_buffer_get_event): Read special events also in
3819 batch mode. (Bug#11415)
3820
9e6b06ed
GM
38212012-05-12 Glenn Morris <rgm@gnu.org>
3822
3823 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3824
c1a1d7a3
EZ
38252012-05-12 Eli Zaretskii <eliz@gnu.org>
3826
3827 * lisp.mk (lisp): Add newcomment.elc.
3828
3fe7cdc8
GM
38292012-05-12 Glenn Morris <rgm@gnu.org>
3830
3831 * Makefile.in (MKDIR_P): New, set by configure.
3832 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3833
53f7d2c0
PE
38342012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3835
3836 Remove unused function hourglass_started.
3837 * dispextern.h (hourglass_started):
3838 * w32fns.c (hourglass_started):
3839 * xdisp.c (hourglass_started): Remove.
3840
75aafb17
JB
38412012-05-10 Juanma Barranquero <lekktu@gmail.com>
3842
3843 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3844 Update dependencies.
3845
12959e8e
PE
38462012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3847
97107e2e
PE
3848 * xgselect.c (xg_select): Put maxfds+1 into a var.
3849 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3850
12959e8e
PE
3851 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3852
836d29b3
DA
38532012-05-10 Dave Abrahams <dave@boostpro.com>
3854
3855 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3856 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3857
5cb67954
MA
38582012-05-09 Michael Albinus <michael.albinus@gmx.de>
3859
3860 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3861 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3862 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3863 Initialize xd_registered_buses.
3864
3478ec45
PE
38652012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3866
b263a6b0
PE
3867 Untag more efficiently if USE_LSB_TAG.
3868 This is based on a proposal by YAMAMOTO Mitsuharu in
3869 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3870 For an admittedly artificial (nth 8000 longlist) benchmark on
3871 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3872 Emacs's overall text size by 1%.
3873 * lisp.h (XUNTAG): New macro.
3874 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3875 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3876 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3877 * eval.c (Fautoload):
3878 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3879 * frame.h (XFRAME): Use XUNTAG.
3880
3478ec45
PE
3881 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3882 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3883 Remove unportable assumptions about print widths of types like
3884 dbus_uint32_t.
3885 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3886 intptr_t when converting between pointer and integer, to avoid GCC
3887 warnings about wrong width.
3888
666b903b 38892012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3890
3891 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3892 stack for each reader_thread, instead of defaulting to 8MB
3893 determined by the linker. This avoids failures in creating
3894 subprocesses on Windows 7, see the discussion in this thread:
3895 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3896
b120cc17
JC
38972012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3898
3899 Fix up display of the *Minibuf-0* buffer in the mini window.
3900 * keyboard.c (read_char): Don't clear the echo area if there's no
3901 message to clear.
3902 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3903 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3904
9a4b36f8
MA
39052012-05-07 Michael Albinus <michael.albinus@gmx.de>
3906
3907 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3908 batch mode.
3909
e5f9458f
CY
39102012-05-06 Chong Yidong <cyd@gnu.org>
3911
3912 * lisp.mk (lisp): Update.
3913
eceeb5fc 39142012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3915
3916 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3917
71873e2b
SM
39182012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3919
3920 * data.c (PUT_ERROR): New macro.
3921 (syms_of_data): Use it. Add new error type `user-error'.
3922 * undo.c (user_error): New function.
3923 (Fprimitive_undo): Use it.
3924 * print.c (print_error_message): Adjust print style for `user-error'.
3925 * keyboard.c (user_error): New function.
3926 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3927
ab0fa4e4
PE
39282012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3929
3930 Do not limit current-time-string to years 1000..9999.
3931 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3932 (Fcurrent_time_string): Support any year that is supported by the
3933 underlying localtime representation. Don't use asctime, as it
3934 has undefined behavior for years outside the range -999..9999.
3935
7ed806a7
PE
39362012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3937
3938 Fix race conditions involving setenv, gmtime, localtime, asctime.
3939 Without this fix, interrupts could mess up code that uses these
3940 nonreentrant functions, since setting TZ invalidates existing
3941 tm_zone or tzname values, and since most of these functions return
3942 pointers to static storage.
3943 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3944 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3945 Grow the critical sections to include not just invoking
3946 localtime/gmtime, but also accessing these functions' results
3947 including their tm_zone values if any, and any related TZ setting.
3948 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3949 so that the struct tm is saved in the critical section.
3950 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3951 motivated by the fact that memory allocation needs to be outside
3952 the critical section.
3953
0c16dfed
DA
39542012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3955
3956 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3957 with RESET_INTERVAL.
3958
3959 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3960 Remove duplicated buffer name initialization.
3961
3f83ace8
JM
39622012-05-02 Jim Meyering <jim@meyering.net>
3963
3964 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3965
c7b8541e
JM
3966 * xfns.c (x_window): Use xstrdup (Bug#11375).
3967
90207a15 39682012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3969
3970 * xdisp.c (pos_visible_p): If already at a newline from the
3971 display string before the 'while' loop, don't walk back the glyphs
3972 from it3.glyph_row. Solves assertion violation when the display
3973 string begins with a newline (egg.el). (Bug#11367)
3974
b593d6a9
AH
39752012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3976
3977 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3978 Move to simple.el.
3979
4737362e
GM
39802012-05-01 Glenn Morris <rgm@gnu.org>
3981
99cf43f9
GM
3982 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3983 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3984 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3985 All were removed before 23.1.
3986
9311dcff
GM
3987 * dispnew.c: Remove HAVE_LIBNCURSES test;
3988 it is always true on relevant platforms.
3989
4d5c6349
GM
3990 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3991 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3992
4737362e
GM
3993 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3994
74dd3a6b
AS
39952012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3996
3997 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3998 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3999 Remove.
4000
13c379ee
PE
40012012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4002
4003 Do not avoid creating empty evaporating overlays (Bug#9642).
4004 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4005 That is, do not delete an evaporating overlay if it becomes
4006 empty after its bounds are adjusted to fit within its buffer.
4007 This fix caused other problems, and I'm reverting it until we get
4008 to the bottom of them.
4009
a8e7d6d7 40102012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4011
4012 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4013
a8e7d6d7 40142012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4015
4016 * xdisp.c (pos_visible_p): If the window start position is beyond
4017 ZV, start the display from buffer beginning. Prevents assertion
4018 violation in init_iterator when the minibuffer window is scrolled
4019 via the scroll bar.
4020
4021 * window.c (window_scroll_pixel_based): Likewise.
4022
a8e7d6d7 40232012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4024
4025 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4026
a8e7d6d7 40272012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4028
4029 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4030 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4031
a8e7d6d7 40322012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4033
b593d6a9
AH
4034 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4035 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4036
1c6900d9
EZ
40372012-04-26 Eli Zaretskii <eliz@gnu.org>
4038
4c3fa1d9
EZ
4039 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4040 display element, check also the underlying string or buffer
4041 character. (Bug#11341)
4042
1c6900d9
EZ
4043 * w32menu.c: Include w32heap.h.
4044 (add_menu_item): If the call to AppendMenuW (via
4045 unicode_append_menu) fails, disable Unicode menus only if we are
4046 running on Windows 9X/Me.
4047
42bf8205
AS
40482012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4049
4050 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4051 (xgetint): Add missing shift for LSB tags.
4052
b1bac16e
MR
40532012-04-24 Martin Rudalics <rudalics@gmx.at>
4054
4055 * keyboard.c (read_char): Don't wipe echo area for select window
4056 events: These might get delayed via `mouse-autoselect-window'
4057 (Bug#11304).
4058
d69621cc
JB
40592012-04-24 Juanma Barranquero <lekktu@gmail.com>
4060
4061 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4062 manipulation of :loaded-from data.
4063
02fd101b
JB
40642012-04-23 Juanma Barranquero <lekktu@gmail.com>
4065
4066 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4067 now a cons (bug#11311).
4068
888bec30
PE
40692012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4070
89a438bd
PE
4071 Do not create empty overlays with the evaporate property (Bug#9642).
4072 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4073 if it becomes empty after its bounds are adjusted to fit within
4074 its buffer. Without this fix, in a nonempty buffer (let ((o
4075 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4076 yields an empty overlay that has the evaporate property, which is
4077 not supposed to happen.
4078
1068fe4d
PE
4079 Fix minor GTK3 problems found by static checking.
4080 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4081 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4082 (struct _EmacsFixedClass, emacs_fixed_get_type):
4083 Move decls here from emacsgtkfixed.h, since they needn't be public.
4084 (emacs_fixed_get_type): Now static.
4085 (emacs_fixed_class_init): Omit unused local.
4086 (emacs_fixed_child_type): Remove; unused.
4087 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4088 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4089 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4090 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4091 (EMACS_FIXED_GET_CLASS): Remove; unused.
4092 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4093
888bec30
PE
4094 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4095 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4096
de85e130
PE
40972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4098
d0baac98 4099 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4100 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4101 (__malloc_size_t, __malloc_ptrdiff_t):
4102 Remove. All uses removed, replaced by the definiens if needed,
4103 since we can assume C89 or better now.
4104 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4105 (protect_malloc_state, align, get_contiguous_space)
4106 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4107 (malloc_atfork_handler_child, malloc_enable_thread)
4108 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4109 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4110 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4111 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4112 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4113 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4114 Define using prototypes, not old style.
4115 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4116 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4117 (align): Don't assume that signed integer overflow wraps around.
4118 Omit unused local var.
4119 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4120 (_free_internal_nolock, memalign, mallochook, reallochook):
4121 Omit no-longer-needed casts.
4122 (valloc): Use getpagesize, not __getpagesize.
4123 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4124 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4125
de85e130
PE
4126 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4127
dcbf5805
MA
41282012-04-22 Michael Albinus <michael.albinus@gmx.de>
4129
4130 Move functions from C to Lisp. Make non-blocking method calls
4131 the default. Implement further D-Bus standard interfaces.
4132
4133 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4134 (QCdbus_request_name_allow_replacement)
4135 (QCdbus_request_name_replace_existing)
4136 (QCdbus_request_name_do_not_queue)
4137 (QCdbus_request_name_reply_primary_owner)
4138 (QCdbus_request_name_reply_in_queue)
4139 (QCdbus_request_name_reply_exists)
4140 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4141 (QCdbus_registered_serial, QCdbus_registered_method)
4142 (QCdbus_registered_signal): New Lisp objects.
4143 (XD_DEBUG_MESSAGE): Use sizeof.
4144 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4145 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4146 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4147 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4148 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4149 (xd_signature, xd_append_arg): Allow float for integer types.
4150 (xd_get_connection_references): New function.
b593d6a9
AH
4151 (xd_get_connection_address): Rename from xd_initialize.
4152 Return cached address.
dcbf5805
MA
4153 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4154 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4155 level.
4156 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4157 Return number of refcounts.
dcbf5805
MA
4158 (Fdbus_get_unique_name): Make stronger parameter check.
4159 (Fdbus_message_internal): New defun.
4160 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4161 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4162 (Fdbus_send_signal, Fdbus_register_service)
4163 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4164 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4165 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4166 (Vdbus_compiled_version, Vdbus_runtime_version)
4167 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4168 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4169 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4170 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4171 Adapt docstring.
dcbf5805 4172
52828e02
PE
41732012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4174
da05bc4c
PE
4175 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4176 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4177 Do not assume ptrdiff_t is the same width as 'int'.
4178
52828e02
PE
4179 * alloc.c: Handle unusual debugging option combinations.
4180 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4181 since the two debugging options are incompatible.
4182 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4183 is defined.
4184 (mem_init, mem_insert, mem_insert_fixup):
4185 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4186 (NEED_MEM_INSERT): Remove; no longer needed.
4187
f01769f9
LL
41882012-04-22 Leo Liu <sdl.web@gmail.com>
4189
4190 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4191
5790543d
PE
41922012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4193
4194 * sysdep.c [__FreeBSD__]: Minor cleanups.
4195 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4196 Use Emacs indenting style more consistently. Avoid some casts.
4197 Use 'double' consistently rather than mixing 'float' and 'double'.
4198
b91b7e4d
EW
41992012-04-21 Eduard Wiebe <usenet@pusto.de>
4200
b593d6a9
AH
4201 * sysdep.c (list_system_processes, system_process_attributes):
4202 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4203
6114eb15
AS
42042012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4205
4206 * lisp.mk (lisp): Update.
4207
2f38dff7
PE
42082012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4209
4210 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4211 It is never used otherwise.
4212
4ae29f89
SM
42132012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4214
4215 * print.c (print_preprocess): Only check print_depth if print-circle
4216 is nil.
4217 (print_object): Check for cycles even when print-circle is nil and
4218 print-gensym is t, but only check print_depth if print-circle is nil.
4219
f30d612a
CY
42202012-04-20 Chong Yidong <cyd@gnu.org>
4221
4222 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4223 set the status to "failed" and ensure that sentinel is run.
4224
c07a4c0b 42252012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4226
4227 * process.c (Fset_process_inherit_coding_system_flag)
4228 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4229 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4230
c07a4c0b 42312012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4232
4233 * xdisp.c (string_buffer_position_lim): Limit starting position to
4234 BEGV.
4235 (set_cursor_from_row): If called for a mode-line or header-line
4236 row, return zero immediately.
4237 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4238 farther than the first row after the header line, if any.
4239 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4240 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4241
c07a4c0b 42422012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4243
4ae29f89
SM
4244 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4245 (bug#11238).
ad3a2b41 4246
c07a4c0b 42472012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 42482012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4249
4250 configure: new option --enable-gcc-warnings (Bug#11207)
4251 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4252 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4253 (ALL_CFLAGS): Use new macros rather than old.
4254 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4255 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4256 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4257 -Wunused-result, -Wunused-variable. This should go away once
4258 the Emacs and Gnulib regex code is merged.
4259 (xmalloc, xrealloc): Now static.
4260
aba027e8
PE
42612012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4262
4263 * dired.c (Fsystem_groups): Remove unused local.
4264
e5a36063
GM
42652012-04-17 Glenn Morris <rgm@gnu.org>
4266
4267 * dired.c (Fsystem_users): Doc fix.
4268
316411f0
DA
42692012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4270
4271 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4272 (syms_of_dired): Add them.
4273
9426aba4
PE
42742012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4275
b62a57be
PE
4276 Fix minor alloc.c problems found by static checking.
4277 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4278 New extern decls, to avoid calling undeclared functions.
4279 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4280 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4281 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4282 (NEED_MEM_INSERT): New macro.
4283 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4284 Remove one incorrect comment and fix another.
b62a57be 4285
3539f31f
PE
4286 Fix minor ralloc.c problems found by static checking.
4287 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4288 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4289 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4290 (r_alloc_sbrk): Now static.
4291
a041960a
PE
4292 Improve ralloc.c interface checking.
4293 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4294 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4295 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4296 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4297 [REL_ALLOC]: ... to here, to check interface.
4298 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4299 Remove decls. This fixes an "It stinks!".
4300
9426aba4
PE
4301 * alloc.c (which_symbols): Fix alignment issue / type clash.
4302
d55c12ed
AS
43032012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4304
4305 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4306 (struct Lisp_Misc_Any): Likewise.
4307 (struct Lisp_Free): Likewise.
4308 * alloc.c (union aligned_Lisp_Symbol): Define.
4309 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4310 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4311 (union aligned_Lisp_Misc): Define.
4312 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4313 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4314 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4315
b948ce8b
PE
43162012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4317
4318 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4319 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4320 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4321 * s/netbsd.h, s/sol2-6.h:
4322 Remove definition of GC_MARK_STACK, since the default now works.
4323 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4324 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4325 no longer the default.
4326 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4327
35dc09a1 43282012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4329
35dc09a1
GM
4330 * lread.c (lisp_file_lexically_bound_p):
4331 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4332
35dc09a1
GM
43332012-04-14 Eli Zaretskii <eliz@gnu.org>
4334
4335 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4336 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4337
43382012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4339
4340 * nsterm.m (constrainFrameRect): Always constrain when there is only
4341 one screen (Bug#10962).
4342
bcd86815
KB
43432012-04-13 Ken Brown <kbrown@cornell.edu>
4344
4345 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4346
c25df26e
RT
43472012-04-13 Reuben Thomas <rrt@sc3d.org>
4348
4349 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4350
0fc59f1e
DC
43512012-04-11 Daniel Colascione <dancol@dancol.org>
4352
4353 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4354 against is gone. It's better to use vfork now so that when Cygwin
4355 gains a new, working vfork, we use it automatically (bug#10398).
4356
de8c03dc
SM
43572012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4358
4359 * window.c (save_window_save): Obey window-point-insertion-type.
4360
2f097256
GM
43612012-04-11 Glenn Morris <rgm@gnu.org>
4362
4363 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4364
453b951e
SM
43652012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4366
4367 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4368
75f1671a 43692012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4370
4371 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4372 (force_quit_count): New var.
4373 (handle_interrupt): Use it.
4374
2a8ce227
JB
43752012-04-10 Juanma Barranquero <lekktu@gmail.com>
4376
4377 * w32.c (w32_delayed_load): Record the full path of the library
4378 being loaded (bug#10424).
4379
935396c0
GM
43802012-04-09 Glenn Morris <rgm@gnu.org>
4381
05920a43
GM
4382 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4383 not just in the obarray, before snarfing them. (Bug#11036)
4384
935396c0
GM
4385 * Makefile.in ($(leimdir)/leim-list.el):
4386 Pass EMACS rather than BUILT_EMACS.
4387
a18ecafa
TZ
43882012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4389
4390 * process.c (make_process):
4391 * process.h: Add integer `gnutls_handshakes_tried' member to
4392 process struct.
4393
6bbef4e5
JC
4394 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4395 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4396
4397 * gnutls.c (gnutls_log_function2i): Convenience log function.
4398 (emacs_gnutls_read): Use new log functions,
4399 `gnutls_handshakes_tried' process member, and
4400 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4401 attempts per process (connection).
4402
b4d3bc10
CY
44032012-04-09 Chong Yidong <cyd@gnu.org>
4404
4405 * eval.c (Fuser_variable_p, user_variable_p_eh)
4406 (lisp_indirect_variable): Functions deleted.
4407 (Fdefvar): Caller changed.
4408
4409 * callint.c (Finteractive, Fcall_interactively):
4410 * minibuf.c (Fread_variable): Callers changed.
4411
70f4d973
EZ
44122012-04-09 Eli Zaretskii <eliz@gnu.org>
4413
4414 * xdisp.c (set_cursor_from_row): If the display string appears in
4415 the buffer at position that is closer to point than the position
4416 after the display string, display the cursor on the first glyph of
4417 the display string. Fixes cursor display when a 'display' text
4418 property immediately follows invisible text. (Bug#11094)
4419
cb3c2e3e
PE
44202012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4421
4422 composite.c: use 'double' consistently
4423 * composite.c (get_composition_id): Use 'double' consistently
4424 instead of converting 'float' to 'double' and vice versa; this is
4425 easier to understand and avoids a GCC warning.
4426
fd06db5d
GM
44272012-04-09 Glenn Morris <rgm@gnu.org>
4428
50fe702a
GM
4429 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4430 preparation for dumping it with emacs. (Bug#4789)
4431 (leimdir): New variable.
4432 ($(leimdir)/leim-list.el): New rule.
4433 (emacs$(EXEEXT)): Depend on leim-list.el.
4434
fd06db5d
GM
4435 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4436 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4437 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4438
55c131ee
AS
44392012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4440
4441 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4442 proper alignment.
4443
9209588f
JB
44442012-04-07 Juanma Barranquero <lekktu@gmail.com>
4445
4446 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4447 Remove unused local variable.
4448
e3fb2efb
PE
44492012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4450
4451 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4452 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4453 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4454 objects, as mark_maybe_pointer will catch them otherwise.
4455 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4456 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4457
b5385551
PE
44582012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4459
4460 Fix typo that broke non-Windows builds.
4461 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4462
9078ead6
EZ
44632012-04-07 Eli Zaretskii <eliz@gnu.org>
4464
4465 Support building on MS-Windows with libxml2.
4466
4467 * makefile.w32-in (OBJ2): Add xml.$(O).
4468 (GLOBAL_SOURCES): Add xml.c.
4469 ($(BLD)/xml.$(O)): New dependency list.
4470
4471 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4472 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4473 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4474 [!WINDOWSNT]: New macros.
4475 (init_libxml2_functions, libxml2_loaded_p): New functions.
4476 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4477 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4478 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4479 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4480 linked in).
6bbef4e5
JC
4481 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4482 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4483 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4484
4485 * emacs.c: Don't include libxml/parser.h.
4486 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4487 xmlCleanupParser directly.
4488
4489 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4490
3811fdf3
EZ
44912012-04-07 Eli Zaretskii <eliz@gnu.org>
4492
4493 * indent.c (Fvertical_motion): If there is a display string at
4494 point, use it.vpos to compute how many lines to backtrack after
4495 move_it_to point. (Bug#11133)
4496
2f8e16b2
EZ
44972012-04-06 Eli Zaretskii <eliz@gnu.org>
4498
4499 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4500 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4501 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4502 macros related to unification of CJK characters. For the details,
4503 see the discussion following the message here:
4504 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4505
3d439cd1
CY
45062012-04-04 Chong Yidong <cyd@gnu.org>
4507
4508 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4509
8bc53d00
EZ
45102012-04-01 Eli Zaretskii <eliz@gnu.org>
4511
4512 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4513 instead of alloca. (Bug#11138)
4514
3b0512a3
AS
45152012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4516
4517 * w32menu.c (is_simple_dialog): Properly check lisp types.
4518 (Bug#11141)
4519
8427ddd2
EZ
45202012-03-31 Eli Zaretskii <eliz@gnu.org>
4521
979022ef
EZ
4522 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4523 position we get to after a call to move_it_to fails the
4524 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4525 only if we wind up in a string from display property. (Bug#11063)
4526
a6b1c7cc
EZ
4527 * window.c (Fdelete_other_windows_internal): Invalidate the row
4528 and column information about mouse highlight, so that redisplay
4529 restores it after reallocating the glyph matrices. (Bug#7464)
4530
8427ddd2
EZ
4531 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4532 string comes from a `display' text property, use the buffer
4533 position of that property as if we actually saw that position in
4534 the row's glyphs.
697ba24b
EZ
4535 (move_it_by_lines): Remove the assertion that
4536 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4537 violated when there's a before-string at the beginning of a line.
4538 (Bug#11063)
8427ddd2 4539
65a0a738
EZ
45402012-03-30 Eli Zaretskii <eliz@gnu.org>
4541
4542 * xdisp.c (append_space_for_newline): If the default face was
4543 remapped, use the remapped face for the appended newline.
4544 (extend_face_to_end_of_line): Use the remapped default face for
4545 extending the face to the end of the line.
4546 (display_line): Call extend_face_to_end_of_line when the default
4547 face was remapped. (Bug#11068)
4548
581355cc
EZ
45492012-03-29 Eli Zaretskii <eliz@gnu.org>
4550
4551 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4552
e8fc049f
SM
45532012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4554
4555 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4556
4fb9a543
GM
45572012-03-27 Glenn Morris <rgm@gnu.org>
4558
4559 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4560 Doc fixes.
4561
679910f1
KH
45622012-03-26 Kenichi Handa <handa@m17n.org>
4563
4564 * dispextern.h (struct glyph): Fix previous change. Change the
4565 bit length of glyphless.ch to 25 (Bug#11082).
4566
90d49b7f
CY
45672012-03-26 Chong Yidong <cyd@gnu.org>
4568
4569 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4570 (command_loop_1): Use it; inhibit selection update for
4571 handle-select-window too (Bug#8996).
4572
f514f6f0
FP
45732012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4574
e8fc049f 4575 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4576
bf43fa51
KH
45772012-03-25 Kenichi Handa <handa@m17n.org>
4578
4579 * dispextern.h (struct glyph): Change the bit length of
4580 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4581
8a0c01dd
EZ
45822012-03-24 Eli Zaretskii <eliz@gnu.org>
4583
4584 * s/ms-w32.h (tzname): Include time.h before redirecting to
4585 _tzname. Fixes the MSVC build. (Bug#9960)
4586
7d1c3a76
AS
45872012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4588
8ed79523
AS
4589 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4590 characters.
4591
7d1c3a76
AS
4592 * xterm.c (XTread_socket): Only modify handling_signal if
4593 !SYNC_INPUT. (Bug#11080)
4594
e99a9b8b
EZ
45952012-03-23 Eli Zaretskii <eliz@gnu.org>
4596
4597 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4598 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4599 when fetching a multibyte character consumes more bytes than
4600 CHAR_BYTES returns, due to unification of CJK characters in
4601 string_char. (Bug#11073)
4602
5063c0e1
TN
46032012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4604
4605 * process.c (wait_reading_process_output): Handle pty disconnect
4606 by refraining from sending oneself a SIGCHLD (bug#10933).
4607
9f851fbd
CY
46082012-03-22 Chong Yidong <cyd@gnu.org>
4609
4610 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4611
5063c0e1 4612 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4613 Mark string as coming from a prefix property.
4614 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4615 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4616
fb5b8aca
CY
46172012-03-21 Chong Yidong <cyd@gnu.org>
4618
4619 * xfaces.c (Vface_remapping_alist): Doc fix.
4620
62356a1b
EZ
46212012-03-20 Eli Zaretskii <eliz@gnu.org>
4622
4623 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4624 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4625 Doc fixes.
62356a1b 4626
025de85b
CY
46272012-03-20 Chong Yidong <cyd@gnu.org>
4628
4629 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4630 to reflect default non-nil value of redisplay-dont-pause.
4631
4827f94e
KH
46322012-03-19 Kenichi Handa <handa@m17n.org>
4633
4634 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4635 it fit in a valid range (Bug#11003).
4636
e50a24a2
EZ
46372012-03-18 Eli Zaretskii <eliz@gnu.org>
4638
4639 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4640 that is not from display property, accept the row as a "cursor
4641 row" if one of the string's character has a non-nil `cursor'
4642 property. Fixes cursor positioning when there are newlines in
4643 overlay strings, e.g. in icomplete.el. (Bug#11035)
4644
9af5ed87
PE
46452012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4646
4647 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4648
d1f55f16
CY
46492012-03-12 Chong Yidong <cyd@gnu.org>
4650
4651 * eval.c (inhibit_lisp_code): Rename from
4652 inhibit_window_configuration_change_hook; move from window.c.
4653
4654 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4655 * window.c (run_window_configuration_change_hook)
4656 (syms_of_window): Callers changed.
4657
66c5eebd
CY
46582012-03-11 Chong Yidong <cyd@gnu.org>
4659
413df973
CY
4660 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4661
66c5eebd
CY
4662 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4663
1de11f56
CY
46642012-03-10 Chong Yidong <cyd@gnu.org>
4665
4666 * frame.c (other_visible_frames): Don't assume the selected frame
4667 is visible (Bug#10955).
4668
cae07000
SM
46692012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4670
4671 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4672
89c94350
JD
46732012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4674
4675 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4676 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4677 zero (Bug#10954).
4678
999dd333
GM
46792012-03-03 Glenn Morris <rgm@gnu.org>
4680
01a6dcc8 4681 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4682
de0100f2
EZ
46832012-03-02 Eli Zaretskii <eliz@gnu.org>
4684
4685 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4686 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4687 (redisplay_window, next_element_from_string): Fix typos in
4688 comments.
3e441275
EZ
4689 (redisplay_window): Pass to move_it_vertically the margin in
4690 pixels, not in screen lines.
de0100f2 4691
96a72ee9
GM
46922012-03-02 Glenn Morris <rgm@gnu.org>
4693
4694 * buffer.c (buffer-list-update-hook): Doc fix.
4695
312508d7
EZ
46962012-02-29 Eli Zaretskii <eliz@gnu.org>
4697
4698 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4699 push_it before setting up the iterator for the first overlay
4700 string, even if we have an empty string loaded.
4701 (next_overlay_string): If there's an empty string on the iterator
4702 stack, pop the stack. (Bug#10903)
4703
27f3c637
PE
47042012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4705
4706 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4707 Suggested by Stefan Monnier in
4708 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4709 * alloc.c (widen_to_Lisp_Object): New static function.
4710 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4711 and widening them to Lisp_Objects. This would work even if
4712 USE_LSB_TAG is defined and wide integers are used, which might
4713 happen in a future version of Emacs.
4714
3c9dfce6
CY
47152012-02-25 Chong Yidong <cyd@gnu.org>
4716
fa74b241
CY
4717 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4718 Doc fix.
4719
3c9dfce6
CY
4720 * xselect.c (Fx_selection_exists_p): Doc fix.
4721 (x_clipboard_manager_save_all): Print an informative message
4722 before saving to clipboard manager.
4723
9486df08
CY
47242012-02-24 Chong Yidong <cyd@gnu.org>
4725
4726 * keyboard.c (process_special_events): Handle all X selection
4727 requests in kbd_buffer, not just the next one (Bug#8869).
4728
f01d3321
CY
47292012-02-23 Chong Yidong <cyd@gnu.org>
4730
4731 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4732 call when setting menu-bar-lines and tool-bar-lines parameters.
4733 (unwind_create_frame_1): New helper function.
4734
4735 * window.c (inhibit_window_configuration_change_hook): New var.
4736 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4737 (syms_of_window): Initialize it.
f01d3321 4738
86b847b6
CY
47392012-02-22 Chong Yidong <cyd@gnu.org>
4740
4741 * xterm.c (x_draw_image_relief): Add missing type check for
4742 Vtool_bar_button_margin (Bug#10743).
4743
a59225b1
CY
47442012-02-21 Chong Yidong <cyd@gnu.org>
4745
4746 * fileio.c (Vfile_name_handler_alist): Doc fix.
4747
4748 * buffer.c (Fget_file_buffer): Protect against invalid file
4749 handler return value.
4750
310f5bd4
PE
47512012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4752
cb3a28cc
PE
4753 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4754 when computing $valmask.
4755
310f5bd4
PE
4756 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4757 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4758 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4759 It's useless in that case, and it can cause problems on hosts
4760 that allocate halves of EMACS_INT values separately.
4761 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4762 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4763 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4764 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4765 it avoids undefined behavior on hosts where shifting right by more
4766 than the word width has undefined behavior.
4767
2375c96a
CY
47682012-02-19 Chong Yidong <cyd@gnu.org>
4769
4770 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4771 (Funhandled_file_name_directory, Ffile_name_as_directory)
4772 (Fdirectory_file_name, Fexpand_file_name)
4773 (Fsubstitute_in_file_name): Protect against invalid file handler
4774 return values (Bug#10845).
4775
3eb49e71
EZ
47762012-02-18 Eli Zaretskii <eliz@gnu.org>
4777
4778 * .gdbinit (pitx): Fix incorrect references to fields of the
4779 iterator stack.
4780
7b926f3f
CY
47812012-02-17 Chong Yidong <cyd@gnu.org>
4782
4783 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4784
11273115
PE
47852012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4786
4787 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4788 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4789
c3a70e2b
CY
47902012-02-15 Chong Yidong <cyd@gnu.org>
4791
4792 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4793 marked as special. Also, starting docstrings with * is obsolete.
4794
0ca43699
AS
47952012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4796
4797 * gnutls.c (emacs_gnutls_write): Fix last change.
4798
2e8f3c56
LI
47992012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4800
4801 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4802 send_process.
4803
af70074f
SM
48042012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4805
4806 * keymap.c (Fsingle_key_description): Handle char ranges.
4807
95986d52
CY
48082012-02-12 Chong Yidong <cyd@gnu.org>
4809
afd83bd1
CY
4810 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4811 as that creates a dangerous corner case.
4812
95986d52
CY
4813 * window.c (Fdelete_window_internal): Invalidate the mouse
4814 highlight (Bug#9904).
4815
bd7da63e
GM
48162012-02-12 Glenn Morris <rgm@gnu.org>
4817
4818 * xselect.c (Fx_own_selection_internal)
4819 (Fx_get_selection_internal, Fx_disown_selection_internal)
4820 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4821 * nsselect.m (Fx_own_selection_internal)
4822 (Fx_disown_selection_internal, Fx_selection_exists_p)
4823 (Fx_selection_owner_p, Fx_get_selection_internal):
4824 Sync docs and argument specs with the xselect.c versions.
4825
77abcbc2
LI
48262012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4827
4828 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4829
90b671e2
EZ
48302012-02-11 Eli Zaretskii <eliz@gnu.org>
4831
1c0ca0b7
EZ
4832 * w32select.c (Fx_selection_exists_p): Sync doc string and
4833 argument list with xselect.c. (Bug#10783)
4834
4835 * w16select.c (Fx_selection_exists_p): Sync doc string and
4836 argument list with xselect.c. (Bug#10783)
90b671e2 4837
49241268
GM
48382012-02-10 Glenn Morris <rgm@gnu.org>
4839
4840 * fns.c (Fsecure_hash): Doc fix.
4841
f998bbe7 48422012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4843
4844 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4845
0992bd9c
CY
48462012-02-07 Chong Yidong <cyd@gnu.org>
4847
4848 * buffer.c (Fbuffer_local_variables)
4849 (buffer_lisp_local_variables): Handle unbound vars correctly;
4850 don't let Qunbound leak into Lisp.
4851
af008560
GM
48522012-02-07 Glenn Morris <rgm@gnu.org>
4853
dd605cc4
GM
4854 * image.c (Fimagemagick_types): Doc fix.
4855
af008560
GM
4856 * image.c (imagemagick-render-type): Change it from a lisp object
4857 to an integer. Move the doc here from the lisp manual.
4858 Treat all values not equal to 0 the same.
4859
1449fa1d
CY
48602012-02-06 Chong Yidong <cyd@gnu.org>
4861
4862 * doc.c (store_function_docstring): Avoid applying docstring of
4863 alias to base function (Bug#2603).
4864
3723ec07
AS
48652012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4866
4867 * .gdbinit (pp1, pv1): Remove redundant defines.
4868 (pr): Use pp.
4869
79c1cc1e
CY
48702012-02-04 Chong Yidong <cyd@gnu.org>
4871
4872 * nsterm.m: Declare a global (Bug#10694).
4873
d7f29f8e
EZ
48742012-02-04 Eli Zaretskii <eliz@gnu.org>
4875
cae07000
SM
4876 * w32.c (get_emacs_configuration_options):
4877 Include --enable-checking, if specified, in the return value.
d7f29f8e 4878
3b95a6f9
MR
48792012-02-04 Martin Rudalics <rudalics@gmx.at>
4880
4881 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4882 after rounding frame sizes. (Bug#9723)
4883
d6fa96a6
EZ
48842012-02-04 Eli Zaretskii <eliz@gnu.org>
4885
4886 * keyboard.c (adjust_point_for_property): Don't position point
4887 before BEGV. (Bug#10696)
4888
df0b2940
PE
48892012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4890
4891 Handle overflow when computing char display width (Bug#9496).
4892 * character.c (char_width): Return EMACS_INT, not int.
4893 (char_width, c_string_width): Check for overflow when
4894 computing the width; this is possible now that individual
4895 characters can have unbounded width. Problem introduced
4896 by merge from Emacs 23 on 2012-01-19.
4897
6bee44d6
MA
48982012-02-02 Michael Albinus <michael.albinus@gmx.de>
4899
4900 * dbusbind.c (Fdbus_register_method): Mention the return value
4901 :ignore in the docstring.
4902
44f92739
GM
49032012-02-02 Glenn Morris <rgm@gnu.org>
4904
1b9f60cc
GM
4905 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4906
44f92739
GM
4907 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4908 Unconditionally set to t. (Bug#10673)
4909 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4910 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4911 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4912
c5d3843c
KH
49132012-02-02 Kenichi Handa <handa@m17n.org>
4914
4915 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4916 0, do not call append_composite_glyph.
4917
159462d4 49182012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4919
4920 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4921 NULL (Bug#6988).
4922 (x_produce_glyphs): If the component of a composition is a null
4923 string, set it->pixel_width to 1 to avoid zero-width glyph.
4924
78cef877
EZ
49252012-02-01 Eli Zaretskii <eliz@gnu.org>
4926
4927 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4928 first 2 arguments are identical. This makes inserting large
4929 output from a subprocess an order of magnitude faster on
4930 MS-Windows, where all sbrk'ed memory is always contiguous.
4931
97897668
GM
49322012-01-31 Glenn Morris <rgm@gnu.org>
4933
4934 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4935 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4936 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4937
31fd3586
GM
49382012-01-29 Glenn Morris <rgm@gnu.org>
4939
4940 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4941
0e24a8b2
CY
49422012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4943
4944 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4945
cc0adcb0
CY
49462012-01-28 Chong Yidong <cyd@gnu.org>
4947
4948 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4949
acc28cb9
CY
49502012-01-26 Chong Yidong <cyd@gnu.org>
4951
9c69cfb7
CY
4952 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4953
acc28cb9
CY
4954 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4955 repeat counts (Bug#10507).
4956
48da7392
GM
49572012-01-26 Glenn Morris <rgm@gnu.org>
4958
4959 * lread.c (syms_of_lread): Doc fix.
4960
14af5f7f
CY
49612012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4962
4963 * coding.c (encode_designation_at_bol): Change return value to
4964 EMACS_INT.
4965
0b21c100
CY
49662012-01-25 Chong Yidong <cyd@gnu.org>
4967
4968 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4969
3c2907f7
CY
49702012-01-21 Chong Yidong <cyd@gnu.org>
4971
4972 * floatfns.c (Fcopysign): Make the second argument non-optional,
4973 since nil is not allowed anyway.
4974
959ad23f
AS
49752012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4976
4977 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4978 (send_process): Likewise.
4979
34a02f46
MR
49802012-01-19 Martin Rudalics <rudalics@gmx.at>
4981
4982 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4983 (Vwindow_persistent_parameters): Do not use Qstate.
4984 Rewrite doc-strings.
34a02f46 4985
1259009a 49862012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4987
4988 * character.c (char_width): New function.
70d4fdf6
GM
4989 (Fchar_width, c_string_width, lisp_string_width):
4990 Use char_width (Bug#9496).
25ed9e61 4991
6a6ee00d
MR
49922012-01-16 Martin Rudalics <rudalics@gmx.at>
4993
4994 * window.c (Vwindow_persistent_parameters): New variable.
4995 (Fset_window_configuration, save_window_save): Handle persistent
4996 window parameters.
4997
c85efaf7
EZ
49982012-01-14 Eli Zaretskii <eliz@gnu.org>
4999
5000 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5001 thrashing the stack of the thread. (Bug#9087)
5002
5944709e
PE
50032012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5004
5005 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5006
e71f5d99
EZ
50072012-01-11 Eli Zaretskii <eliz@gnu.org>
5008
5009 * xdisp.c (rows_from_pos_range): Handle the case where the
5010 highlight ends on a newline. (Bug#10464)
5011 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5012 he end column for display of highlight that ends on a newline
5013 before a R2L line.
5014
ce316182
GM
50152012-01-11 Glenn Morris <rgm@gnu.org>
5016
5017 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5018 from load-path also when installation-directory is nil. (Bug#10208)
5019
5b43da69
GM
50202012-01-10 Glenn Morris <rgm@gnu.org>
5021
74cc8ff9
GM
5022 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5023
7d8d6e4e
GM
5024 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5025 Update template values to be closer to their typical values these days.
5b43da69 5026
a0db8d43
EZ
50272012-01-09 Eli Zaretskii <eliz@gnu.org>
5028
5029 * xdisp.c (rows_from_pos_range): Accept additional argument
5030 DISP_STRING, and accept any glyph in a row whose object is that
5031 string as eligible for mouse highlight. Fixes mouse highlight of
5032 display strings from overlays. (Bug#10464)
5033
9a0115ab 50342012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5035
b9110d6a 5036 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5037 * fileio.c (auto_saving_dir_umask): New static var.
5038 (Fmake_directory_internal): Use it.
5039 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5040 creating the directory. The old code temporarily assigns
5041 too-generous permissions to the directory.
5042 (do_auto_save_eh): Clear it.
b9110d6a 5043 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5044 that the var is always cleared.
5045
6c1bd3f3
EZ
50462012-01-07 Eli Zaretskii <eliz@gnu.org>
5047
5048 * search.c (scan_buffer): Pass character positions to
5049 know_region_cache, not byte positions. (Bug#6540)
5050
069d2b50
L
50512012-01-07 LynX <_LynX@bk.ru> (tiny change)
5052
5053 * w32.c (sys_rename): Report EXDEV when rename of a directory
5054 fails because the target is on another logical disk. (Bug#10284)
5055
75bf0d33
DB
50562012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5057
5058 * xterm.c (x_embed_request_focus): New function.
5059
5060 * xterm.h: Add prototype.
5061
5062 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5063
1c6e5a32
GM
50642012-01-05 Glenn Morris <rgm@gnu.org>
5065
5066 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5067
651e947e
EZ
50682012-01-01 Eli Zaretskii <eliz@gnu.org>
5069
5070 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5071 Load gnutls_transport_set_lowat only if GnuTLS version is below
5072 2.11.1.
5073 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5074 GnuTLS versions below 2.11.1.
5075
3778cdd8
AL
50762011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5077
5078 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5079 to the doc string advising against its use for altering the way
5080 windows are scrolled.
5081
0e5317f7
KH
50822011-12-28 Kenichi Handa <handa@m17n.org>
5083
5084 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5085 coding-system ASCII compatible only when it does not produce BOM
5086 on encoding (Bug#10383).
5087
93d5ca1f
JD
50882011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5089
5090 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5091 can scroll.
5092 (create_and_show_popup_menu): Always use menu_position_func for
5093 Gtk3 (Bug#10361).
5094
ca22b785
AS
50952011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5096
5097 * callint.c (Fcall_interactively): Don't truncate prompt string.
5098
d048e1e6
EZ
50992011-12-23 Eli Zaretskii <eliz@gnu.org>
5100
5101 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5102 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5103 resumed from there (after widening). (Bug#10360)
d048e1e6 5104
5ccaba1f
JD
51052011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5106
5107 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5108
204ee57f
JD
51092011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5110
b81d40f0
JB
5111 * nsterm.m (x_free_frame_resources):
5112 Release f->output_data.ns->miniimage.
204ee57f
JD
5113 (ns_index_color): Fix indentation. Do not retain
5114 color_table->colors[i].
5115
5116 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5117 before returning.
5118
5119 * nsfns.m (x_set_background_color): Assign return value from
5120 ns_index_color to face-background instead of NSColor*.
5121 (ns_implicitly_set_icon_type): Fix indentation.
5122 Change assignment in for loop to comparison.
5123
5124 * emacs.c (ns_pool): New variable.
5125 (main): Assign ns_pool.
5126 (Fkill_emacs): Call ns_release_autorelease_pool.
5127
5128 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5129 autorelease fdesc, release fdAttrs and tdict.
5130 (ns_get_covering_families): Release charset.
5131 (ns_findfonts): Release NSFontDescriptor created with new.
5132 (ns_uni_to_glyphs): Fix indentation.
5133 (setString): Release attrStr before assigning new value.
5134
c803b2b7
JD
51352011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5136
678f4426
JD
5137 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5138 and NS_IMPL_COCOA.
5139 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5140 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5141
cd394be1 51422011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5143
5fecd5fc
JD
5144 * nsterm.m (ns_term_init): Subscribe for notifications
5145 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5146 to method trackingNotification in EmacsMenu.
5147
5148 * nsmenu.m (trackingMenu): New variable.
3771cb17 5149 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5150 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5151 from Aquamacs (Bug#7030).
678f4426
JD
5152
51532011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5154
c803b2b7
JD
5155 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5156 (symbol_to_nsstring): Fix indentation.
5157 (ns_symbol_to_pb): New function.
cae07000
SM
5158 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5159 (Fns_rotate_cut_buffers_internal): Remove.
5160 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5161 Fns_store_cut_buffer_internal.
5162 (ns_get_foreign_selection, Fx_own_selection_internal)
5163 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5164 (Fns_get_selection_internal, Fns_store_selection_internal):
5165 Use ns_symbol_to_pb and check if return value is nil.
5166 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5167 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5168 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5169 renamed to Sns_store_selection_internal.
5170 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5171 and remove this function.
5172 (ns_handle_selection_clear): Remove, never used.
5173 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5174 here.
5175
e1b01a3a
KB
51762011-12-17 Ken Brown <kbrown@cornell.edu>
5177
5178 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5179 GID is unknown (Bug#10257).
5180
2adb6e85
PE
51812011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5182
5183 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5184 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5185 which caused a build failure on GNU/Linux IA-64. This problem was
5186 introduced by my 2011-10-07 patch.
5187
d1d7b339
JL
51882011-12-15 Juri Linkov <juri@jurta.org>
5189
5190 * image.c (imagemagick_error): New function. (Bug#10112)
5191 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5192 Use `imagemagick_error' where ImageMagick functions return
5193 `MagickFalse'.
5194 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5195 proper order.
5196
100d5755
KH
51972011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5198
5199 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5200 fill background (Bug#8992).
5201
454592a6
MR
52022011-12-13 Martin Rudalics <rudalics@gmx.at>
5203
5204 * window.c (Vwindow_combination_resize)
5205 (Vwindow_combination_limit): Use t instead of non-nil in
5206 doc-strings.
61d4b438
MR
5207 (Vrecenter_redisplay): Add first sentence of doc-string on
5208 separate line.
53524d93 5209 (Frecenter): Fix doc-string typo.
454592a6 5210
3633e3aa
KH
52112011-12-11 Kenichi Handa <handa@m17n.org>
5212
5213 * coding.c (Funencodable_char_position): Pay attention to the
5214 buffer text relocation (Bug#9389).
5215
7b9d523a 52162011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5217
7b9d523a
JD
5218 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5219 gtk_init (Bug#10100).
5220
b73189c6
EZ
52212011-12-10 Eli Zaretskii <eliz@gnu.org>
5222
5223 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5224 IT->string is nil. (Bug#10263)
5225
f7dfe5d6
JD
52262011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5227
83faebb4
JD
5228 * nsterm.h (x_free_frame_resources): Declare.
5229
f7dfe5d6
JD
5230 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5231 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5232
5233 * nsterm.h (ns_get_defaults_value): Declare.
5234
5235 * nsterm.m (ns_default): Call ns_get_defaults_value.
5236
7cd4e72c
EZ
52372011-12-09 Eli Zaretskii <eliz@gnu.org>
5238
5239 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5240 (Bug#10170)
5241
b34d7317
YM
52422011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5243
5244 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5245 that where the value of an _OBJC_* symbol points to is in the .bss
5246 section (Bug#10240).
5247
76470ad1
KH
52482011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5249
5250 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5251 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5252
745fff94
KH
52532011-12-08 Kenichi Handa <handa@m17n.org>
5254
5255 * ftfont.c (get_adstyle_property): Fix previous change
5256 (Bug#10233).
5257
6e44397c
JB
52582011-12-07 Juanma Barranquero <lekktu@gmail.com>
5259
5260 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5261 dirs from the default value of EMACSLOADPATH (bug#10208).
5262
7efa6272
GM
52632011-12-07 Glenn Morris <rgm@gnu.org>
5264
5265 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5266 installation and source directories as well. (Bug#10208)
5267
f6fc4d87
CY
52682011-12-06 Chong Yidong <cyd@gnu.org>
5269
5270 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5271
2bf26180
GM
52722011-12-06 Glenn Morris <rgm@gnu.org>
5273
5274 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5275 as an error, not just -1. (Bug#10217)
5276
3a6ad4f0
CY
52772011-12-05 Chong Yidong <cyd@gnu.org>
5278
5279 * keyboard.c (process_special_events): New function.
5280 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5281
75a3b399
PE
52822011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5283
5284 * coding.c (encode_designation_at_bol): Don't use uninitialized
5285 local variable (Bug#9318).
5286
c3c9e25e
KH
52872011-12-05 Kenichi Handa <handa@m17n.org>
5288
5289 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5290 return Qnil (Bug#8046, Bug#10193).
5291
5eb05ea3
KH
52922011-12-05 Kenichi Handa <handa@m17n.org>
5293
5294 * coding.c (encode_designation_at_bol): New args charbuf_end and
5295 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5296 (coding_set_source): Return how many bytes coding->source was
5297 relocated.
5298 (coding_set_destination): Return how many bytes
5299 coding->destination was relocated.
5300 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5301 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5302
53032011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5304
5305 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5306 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5307 macro (Bug#9318).
5308
53092011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5310
5311 The following changes are to fix Bug#9318.
5312
a79703f5 5313 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5314 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5315 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5316 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5317
7dbda6df
JB
53182011-12-05 Juanma Barranquero <lekktu@gmail.com>
5319
5320 * lisp.h (process_quit_flag): Fix external declaration.
5321
6d5eb5b0
SM
53222011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5323
5324 Don't macro-inline non-performance-critical code.
5325 * eval.c (process_quit_flag): New function.
5326 * lisp.h (QUIT): Use it.
5327
a0c3fad0
JD
53282011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5329
5330 * nsfns.m (get_geometry_from_preferences): New function.
5331 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5332
6c07aac2
AS
53332011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5334
5335 * emacs.c (Qkill_emacs): Define.
5336 (syms_of_emacs): Initialize it.
5337 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5338 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5339 (quit_throw_to_read_char): Add parameter `from_signal'.
5340 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5341 * lisp.h (QUIT): Call Fkill_emacs if requested.
5342
c052ead4
JD
53432011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5344
5345 * widget.c (update_wm_hints): Return if wmshell is null.
5346 (widget_update_wm_size_hints): New function.
5347
5348 * widget.h (widget_update_wm_size_hints): Declare.
5349
5350 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5351 widget_update_wm_size_hints (Bug#10104).
5352
9e49252b
EZ
53532011-12-03 Eli Zaretskii <eliz@gnu.org>
5354
5355 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5356 before a newline, prepare the bidi iterator for consuming the
5357 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5358 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5359
02b16839
JL
53602011-12-02 Juri Linkov <juri@jurta.org>
5361
5362 * search.c (Fword_search_regexp): New Lisp function created from
5363 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5364 (Fword_search_backward, Fword_search_forward)
5365 (Fword_search_backward_lax, Fword_search_forward_lax):
5366 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5367 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5368
0068070e
SM
53692011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5370
5371 * fileio.c (Finsert_file_contents): Move after-change-function call
5372 to before the "handled:" label, since all "goto handled" appear in
5373 cases where the *-change-functions have already been properly called
5374 (bug#10117).
5375
3360a3fc
AS
53762011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5377
5378 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5379 waiting for input. (Bug#10169)
5380
73d6c093
EZ
53812011-11-30 Eli Zaretskii <eliz@gnu.org>
5382
5383 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5384 verifies glyph row's hash code--we have just reallocated the
5385 glyphs, so their contents can be complete garbage. (Bug#10164)
5386
febe6bea
JB
53872011-11-30 Juanma Barranquero <lekktu@gmail.com>
5388
5389 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5390
801a4313
EZ
53912011-11-30 Eli Zaretskii <eliz@gnu.org>
5392
5393 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5394 attributes are tested _before_ calling verify_row_hash, to protect
5395 against GCC re-ordering of the tests. (Bug#10164)
5396
2b56b87e
JD
53972011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5398
5399 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5400
5401 * xterm.c (handle_one_xevent): Only set async_visible and friends
5402 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5403 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5404 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5405
dbf31225
PE
54062011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5407
5408 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5409 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5410 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5411 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5412 All uses changed to use GCPRO1 etc.
5413 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5414 Revert to old implementation (i.e., before 2011-03-11).
5415
1305621b
YM
54162011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5417
5418 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5419 of scroll runs so as to avoid assigning disabled bogus rows and
5420 unnecessary graphics copy operations.
5421
8c9afb46
EZ
54222011-11-27 Eli Zaretskii <eliz@gnu.org>
5423
5424 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5425 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5426 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5427 (malloc, free, realloc, calloc): Redirect to e_* only when
5428 compiling Emacs.
5429
5430 * lisp.h (GCTYPEBITS): Move before first use.
5431 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5432 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5433 this macro definition.
5434
5435 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5436 _MSC_VER.
5437
54e9e3bf
JD
54382011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5439
6d5eb5b0
SM
5440 * gtkutil.c (xg_create_frame_widgets):
5441 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5442 present with Gtk+ 2.0.
5443
83aca1cb
PE
54442011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5445
5446 * fileio.c (Finsert_file_contents): Undo previous change; see
5447 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5448
5b76caa4
PE
54492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5450
5451 Rename locals to avoid shadowing.
5452 * fileio.c (Finsert_file_contents):
5453 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5454 * process.c (wait_reading_process_output):
5455 Rename inner 'proc' to 'p' to avoid shadowing.
5456 Indent for consistency with usual Emacs style.
5457
8c535114
EZ
54582011-11-25 Eli Zaretskii <eliz@gnu.org>
5459
5460 * xdisp.c (redisplay_window): If cursor row is not fully visible
5461 after recentering, and scroll-conservatively is set to a large
5462 number, scroll window by a few more lines to make the cursor fully
5463 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5464 (start_display): Don't move to the next line if the display should
5465 start at a newline that is part of a display vector or an overlay
5466 string. (Bug#10119)
8c535114 5467
fa4fdb5c
JL
54682011-11-24 Juri Linkov <juri@jurta.org>
5469
5470 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5471 after the `MagickPingImage' call. (Bug#10112)
5472
90ec88df
CY
54732011-11-23 Chong Yidong <cyd@gnu.org>
5474
5475 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5476
56e2e794
MR
54772011-11-23 Martin Rudalics <rudalics@gmx.at>
5478
5479 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5480 making another buffer current. (Bug#10114)
5481
b6e64c41
GM
54822011-11-23 Glenn Morris <rgm@gnu.org>
5483
5484 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5485
6b21de18
CY
54862011-11-23 Chong Yidong <cyd@gnu.org>
5487
5488 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5489 using it (Bug#5984).
5490
b12cd789
EZ
54912011-11-22 Eli Zaretskii <eliz@gnu.org>
5492
5493 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5494 and header-lines, as they don't have one computed for them.
5495 (Bug#10098)
5496
5497 * .gdbinit (prow): Make displayed values more self-explaining.
5498 Add row's hash code.
5499
261b6fd4
LMI
55002011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5501
5502 * process.c (wait_reading_process_output): Fix asynchrounous
5503 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5504 (wait_reading_process_output): Add comment and URL.
261b6fd4 5505
e7cfd277
JD
55062011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5507
5508 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5509
a9b9b7f5
CY
55102011-11-21 Chong Yidong <cyd@gnu.org>
5511
5512 * window.c (Fnext_window, Fprevious_window): Doc fix.
5513
b0d15b4f
SM
55142011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5515
5516 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5517
fe7a3057
JB
55182011-11-20 Juanma Barranquero <lekktu@gmail.com>
5519
5520 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5521
d2999b1a
MR
55222011-11-20 Martin Rudalics <rudalics@gmx.at>
5523
5524 * window.c (Fset_window_combination_limit): Rename argument
5525 STATUS to LIMIT.
5526 (Vwindow_combination_limit): Remove "status" from doc-string.
5527
d5ff9cd0
AS
55282011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5529
5530 * m/ibms390.h: Remove.
5531 * m/ibms390x.h: Don't include "ibms390.h".
5532
a5bb9bd3
SM
55332011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5534
5535 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5536 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5537
cd1181db
JB
55382011-11-20 Juanma Barranquero <lekktu@gmail.com>
5539
5540 * casetab.c (Fset_case_table):
5541 * charset.c (Fcharset_after): Fix typos.
5542
615a3b8d 55432011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5544
17e845af
PE
5545 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5546 Otherwise, valgrind does not work on some platforms.
5547 Problem reported by Andreas Schwab in
6a0bf43d
PE
5548 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5549 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5550 is set, removing the need for VIRT_ADDRESS_VARIES.
5551 (PURE_P): Use a more-efficient implementation that needs just one
5552 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5553 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5554 to 4 (xorl, subq, cmpq, setbe).
5555 * alloc.c (pure): Always extern now, since that's the
5556 VIRT_ADDR_VARIES behavior.
5557 (PURE_POINTER_P): Use a single comparison, not two, for
5558 consistency with the new puresize.h.
5559 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5560 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5561 Remove VIRT_ADDR_VARIES no longer needed.
5562
f8fe6f96
EZ
55632011-11-19 Eli Zaretskii <eliz@gnu.org>
5564
5565 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5566 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5567 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5568 behave as if the cursor position were at the window margin.
5569
5570 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5571 and the cursor position is out of bounds, behave as if the cursor
5572 position were at the window margin. (Bug#10075)
5573
df05a53c
CY
55742011-11-18 Chong Yidong <cyd@gnu.org>
5575
5576 * window.c (Fwindow_combination_limit): Make first argument
5577 non-optional, since it is meaningless for live windows like the
5578 selected window.
61ccba97 5579
2071918e
DA
55802011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5581
5582 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5583
b50a28de
SM
55842011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5585
5586 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5587 (graft_intervals_into_buffer): Simplify.
5588
015137db
EZ
55892011-11-18 Eli Zaretskii <eliz@gnu.org>
5590
5591 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5592 hash values of the two rows.
5593 (copy_row_except_pointers): Preserve the used[] arrays and the
5594 hash values of the two rows. (Bug#10035)
68c95424 5595 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5596
5597 * xdisp.c (row_hash): New function, body extracted from
5598 compute_line_metrics.
5599 (compute_line_metrics): Call row_hash, instead of computing the
5600 hash code inline.
5601
5602 * dispnew.c (verify_row_hash): Call row_hash for computing the
5603 hash code of a row, instead of duplicating code from xdisp.c.
5604
5605 * dispextern.h (row_hash): Add prototype.
5606
a2addb04
TH
56072011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5608
5609 * frame.c (delete_frame): Don't delete the terminal when the last
5610 X frame is closed if emacs is built with GTK toolkit.
5611
df85d315
JB
56122011-11-17 Juanma Barranquero <lekktu@gmail.com>
5613
5614 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5615
a0c2d0ae
MR
56162011-11-17 Martin Rudalics <rudalics@gmx.at>
5617
5618 * window.c (Vwindow_splits): Rename to
5619 Vwindow_combination_resize. Suggested by Juri Linkov.
5620 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5621 of Vwindow_splits.
5622
58179cce
JB
56232011-11-16 Juanma Barranquero <lekktu@gmail.com>
5624
7877f373
JB
5625 * nsfns.m (Fns_font_name):
5626 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5627
b6f67890
MR
56282011-11-16 Martin Rudalics <rudalics@gmx.at>
5629
5630 * window.h (window): Rename slot "nest" to "combination_limit".
5631 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5632 (Fset_window_nest): Rename to Fset_window_combination_limit.
5633 (Vwindow_nest): Rename to Vwindow_combination_limit.
5634 (recombine_windows, make_parent_window, make_window)
5635 (Fsplit_window_internal, saved_window)
5636 (Fset_window_configuration, save_window_save): Rename all
5637 occurrences of window_nest to window_combination_limit.
5638
c7015153
JB
56392011-11-15 Juanma Barranquero <lekktu@gmail.com>
5640
5641 * image.c (imagemagick_load_image): Fix typo.
5642
322ad6ec
EZ
56432011-11-14 Eli Zaretskii <eliz@gnu.org>
5644
5645 * xdisp.c (display_line): Move the call to
5646 highlight_trailing_whitespace before the call to
5647 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5648 faces of all the glyphs to compute ROW's hash value.
5649 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5650
f067b8ec
JB
56512011-11-14 Juanma Barranquero <lekktu@gmail.com>
5652
5653 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5654 just return (bug#10044).
5655
1e5b2111
EZ
56562011-11-12 Eli Zaretskii <eliz@gnu.org>
5657
7ef3cbd5
EZ
5658 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5659 with user-defined heap size. Bump the default size of the temacs
5660 heap to 27MB, to avoid memory warning when running temacs.
5661 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5662
1e5b2111
EZ
5663 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5664 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5665 (verify_row_hash) [XASSERTS]: New function.
5666 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5667 that the hash value of glyph rows is correct.
1e5b2111 5668
89d61221
MR
56692011-11-12 Martin Rudalics <rudalics@gmx.at>
5670
5671 * window.h (window): Remove splits slot.
5672 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5673 (Fdelete_other_windows_internal, make_parent_window)
5674 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5675 (Fset_window_configuration, save_window_save): Don't deal with
5676 split status of windows.
5677 (saved_window): Remove splits slot.
5678 (Vwindow_splits): Rewrite doc-string.
5679
97f18cc8
JD
56802011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5681
5682 * xfns.c (unwind_create_frame):
5683 * nsfns.m (unwind_create_frame):
5684 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5685 Vframe_list (Bug#9999).
5686
22a648b4
DA
56872011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5688
0b381c7e 5689 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5690
659afede
KH
56912011-11-11 Kenichi Handa <handa@m17n.org>
5692
5693 * callproc.c (Fcall_process): Set the member dst_multibyte of
5694 process_coding.
5695
9ac0394b
KH
56962011-11-11 Johan Bockgård <bojohan@gnu.org>
5697
5698 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5699 avoid a crash (bug#9496).
5700
2fbdc249
CY
57012011-11-09 Chong Yidong <cyd@gnu.org>
5702
5703 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5704 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5705
ac6b1f81
PE
57062011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5707
5708 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5709
09db192c
PE
57102011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5711
5712 Avoid some portability problems by eschewing 'extern inline' functions.
5713 The trivial performance wins aren't worth the portability hassles; see
5714 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5715 et seq.
5716 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5717 (window_box_width, window_box_left, window_box_left_offset)
5718 (window_box_right, window_box_right_offset): Undo previous change,
5719 by removing the "extern"s.
5720 * intervals.c (adjust_intervals_for_insertion)
5721 (adjust_intervals_for_deletion): Undo previous change,
5722 making these static again.
5723 (offset_intervals, temp_set_point_both, temp_set_point)
5724 (copy_intervals_to_string): No longer inline.
5725 * xdisp.c (window_text_bottom_y, window_box_width)
5726 (window_box_height, window_box_left_offset)
5727 (window_box_right_offset, window_box_left, window_box_right)
5728 (window_box): No longer inline.
5729
105216ed
CY
57302011-11-08 Chong Yidong <cyd@gnu.org>
5731
5732 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5733 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5734 Signal an error if not a live window.
105216ed
CY
5735 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5736 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5737
ae9e237f
JB
57382011-11-07 Juanma Barranquero <lekktu@gmail.com>
5739
5740 * lisp.h (syms_of_abbrev): Remove declaration.
5741 Reported by CHENG Gao <chenggao@royau.me>.
5742
c7aa8333
EZ
57432011-11-07 Eli Zaretskii <eliz@gnu.org>
5744
5745 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5746 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5747 of temacs in GUI mode.
5748
be7f5545
MR
57492011-11-07 Martin Rudalics <rudalics@gmx.at>
5750
5751 * window.h: Declare delete_all_child_windows instead of
5752 delete_all_subwindows.
5753 * window.c (Fwindow_nest, Fset_window_nest)
5754 (Fset_window_new_total, Fset_window_new_normal)
5755 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5756 (delete_all_subwindows): Rename to delete_all_child_windows.
5757 (Fdelete_other_windows_internal, Fset_window_configuration):
5758 Call delete_all_child_windows instead of delete_all_subwindows.
5759 * frame.c (delete_frame): Call delete_all_child_windows instead
5760 of delete_all_subwindows.
5761
ca78dc43
PE
57622011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5763
5764 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5765 This is also needed for porting to any host where GC_MARK_STACK is
5766 not GC_MAKE_GCPROS_NOOPS.
5767 (which_symbols): Use it.
5768
a0241d01
KH
57692011-11-07 Kenichi Handa <handa@m17n.org>
5770
5771 * coding.c (coding_set_destination): Check coding->src_pos only
5772 when coding->src_object is a buffer (bug#9910).
5773
5774 * process.c (send_process): Set the member src_multibyte of coding
5775 to 0 (bug#9911) when sending a unibyte text.
5776
5777 * callproc.c (Fcall_process): Set the member src_multibyte of
5778 process_coding to 0 (bug#9912).
5779
a64bfdfa 57802011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5781
5782 * xmenu.c (cleanup_widget_value_tree): New function.
5783 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5784 calling free_menubar_widget_value_tree directly (Bug#9830).
5785
cb41b32a
PE
57862011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5787
5788 Fix some portability problems with 'inline'.
5789 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5790 (window_box_width, window_box_left, window_box_left_offset)
5791 (window_box_right, window_box_right_offset): Declare extern.
5792 Otherwise, these inline functions do not conform to C99 and
5793 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5794 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5795 * intervals.c (adjust_intervals_for_insertion)
5796 (adjust_intervals_for_deletion): Now extern, because otherwise the
5797 extern inline functions 'offset_intervals' couldn't refer to it.
5798 (static_offset_intervals): Remove.
5799 (offset_intervals): Rewrite using the old contents of
5800 static_offset_intervals. The old version didn't conform to C99
5801 because an extern inline function contained a reference to an
5802 identifier with static linkage.
5803
b7041366
AS
58042011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5805
5806 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5807 GC.
5808
88a37c4d
EZ
58092011-11-06 Eli Zaretskii <eliz@gnu.org>
5810
5811 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5812 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5813 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5814 return Qleft_to_right.
5815
49745b39
CY
58162011-11-06 Chong Yidong <cyd@gnu.org>
5817
5818 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5819 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5820 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5821 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5822 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5823 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5824 (Fwindow_vscroll): Doc fix.
5825 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5826 argument, since it makes no sense to pass a live window and for
5827 consistency with window-child.
5828
1f05cd82
CS
58292011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5830
5831 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5832 support MSVC.
5833
22610910
JR
58342011-11-05 Jason Rumney <jasonr@gnu.org>
5835
5836 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5837 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5838 fonts (Bug#6029).
5839 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5840 bitwise arithmetic preventing use of unicode-sip and non-truetype
5841 opentype fonts.
5842
a06776b2
EZ
58432011-11-05 Eli Zaretskii <eliz@gnu.org>
5844
3ad924ba
EZ
5845 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5846 "emacs"-only part.
5847
a06776b2
EZ
5848 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5849 initialization code to keep similarity to xfns.c after changes
5850 from 2011-11-05.
5851
c9e7db78
JD
58522011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5853
a97f8f3f
JD
5854 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5855 (unwind_create_frame): New function (Bug#9943).
5856 (Fx_create_frame): Restructure code to be more similar to the one in
5857 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5858 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5859 Move terminal->reference_count++ just before making the frame official
5860 (Bug#9943).
5861
5862 * nsterm.m (x_free_frame_resources): New function.
5863 (x_destroy_window): Move code to x_free_frame_resources.
5864
c9e7db78 5865 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5866 (Fx_create_frame, x_create_tip_frame):
5867 Move terminal->reference_count++ just before making the frame
75f1671a 5868 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5869 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5870
a6fc3b5c
EZ
58712011-11-05 Eli Zaretskii <eliz@gnu.org>
5872
5873 Support MSVC build with newer versions of Visual Studio.
5874 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5875 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5876 nt/gmake.defs.
5877
5878 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5879 which are not supported by MSVC.
5880 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5881 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5882 bitfields.
5883 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5884 types in bitfields.
5885 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5886
5887 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5888
58179cce 58892011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5890
5891 Support MSVC build with newer versions of Visual Studio.
5892 * w32.c: Don't include w32api.h for MSVC.
5893 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5894
5895 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5896 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5897 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5898 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5899 e_* cousins.
5900 (alloca) [_MSC_VER]: Define to _alloca.
5901
5902 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5903
5904 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5905
a58c13ed
EZ
59062011-11-04 Eli Zaretskii <eliz@gnu.org>
5907
5908 * xdisp.c (note_mouse_highlight): If either of
5909 previous/next-single-property-change returns nil, treat that as
5910 the beginning or the end of the buffer. (Bug#9955)
5911
fe0b6370
JD
59122011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5913
a58c13ed 5914 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5915 label is not null (Bug#9951).
5916 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5917 may be NULL.
5918
89bd5ee1
EZ
59192011-11-04 Eli Zaretskii <eliz@gnu.org>
5920
5921 * window.c (Fwindow_body_size): Mention in the doc string that the
5922 return value is in frame's canonical units. (Bug#9949)
5923
84c3edb9
EZ
59242011-11-03 Eli Zaretskii <eliz@gnu.org>
5925
4e2fb5c7
EZ
5926 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5927
84c3edb9 5928 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5929 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5930 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5931
bc17a887
EZ
59322011-11-01 Eli Zaretskii <eliz@gnu.org>
5933
5934 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5935 Don't stop backward scan on the continuation glyph, even though
5936 its CHARPOS is positive.
6d5eb5b0
SM
5937 (mouse_face_from_buffer_pos, note_mouse_highlight):
5938 Rename cover_string to disp_string.
bc17a887 5939
4ee88440
MR
59402011-11-01 Martin Rudalics <rudalics@gmx.at>
5941
5942 * window.c (temp_output_buffer_show): Don't use
5943 Vtemp_buffer_show_specifiers.
5944 (Vtemp_buffer_show_specifiers): Remove unused variable.
5945
c2ff3c02
EZ
59462011-10-30 Eli Zaretskii <eliz@gnu.org>
5947
5948 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5949 past the beginning of the current glyph matrix.
5950
58179cce 59512011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5952
5953 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5954 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5955 HAVE_GTK3 (Bug#9869).
b77a6a7f 5956
3b574623
JD
5957 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5958 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5959
b77a6a7f
JD
5960 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5961
5962 * xterm.c: Declare x_handle_net_wm_state to return int.
5963 (handle_one_xevent): Check if we are iconified but don't have
5964 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5965 (get_current_wm_state): Return non-zero if not hidden,
5966 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5967 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5968 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5969 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5970
196e41e4
PE
59712011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5972
5973 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5974 so that this new function doesn't get optimized away by a
5975 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5976
021f2e1a
AS
59772011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5978
5979 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5980
8b058d44
EZ
59812011-10-29 Eli Zaretskii <eliz@gnu.org>
5982
5983 Fix the `xbytecode' command.
5984 * .gdbinit (xprintbytestr): New command.
b50a28de 5985 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5986 (xbytecode): Print the byte-code string as well.
5987
4452fb80
EZ
59882011-10-29 Kim Storm <storm@cua.dk>
5989
8b058d44
EZ
5990 * alloc.c (which_symbols): New function.
5991
21b72067
AS
59922011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5993
5994 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5995 line. (Bug#9903)
5996
83ed7b5c
GM
59972011-10-29 Glenn Morris <rgm@gnu.org>
5998
5999 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6000 Not clear what it was for, and it causes various bugs. (Bug#9839)
6001
5a7a728b
EZ
60022011-10-28 Eli Zaretskii <eliz@gnu.org>
6003
6004 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6005 possible random value that matches one of those tested as
6006 condition to clear the mouse face.
6007
d3d0842f
CY
60082011-10-28 Chong Yidong <cyd@gnu.org>
6009
6010 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6011
31b39d13
DN
60122011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6013
6014 * window.c (make_window): Initialize phys_cursor_on_p.
6015
9aba6043
SM
60162011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6017
6018 * lisp.h (struct Lisp_Symbol): Update comments.
6019
c20992f4
JB
60202011-10-28 Juanma Barranquero <lekktu@gmail.com>
6021
6022 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6023
db4f02f2
EZ
60242011-10-28 Eli Zaretskii <eliz@gnu.org>
6025
6026 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6027 <oslsachem@gmail.com> for helping to debug this.
6028
6029 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6030 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6031 (g_b_init_get_glyph_outline_w): New static variables.
6032 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6033 (GetGlyphOutlineW_Proc): New typedefs.
6034 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6035 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6036 New functions.
6037 (w32font_open_internal, compute_metrics):
6038 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6039 instead of calling the "wide" APIs directly.
6040
6041 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6042
6043 * w32.h (syms_of_w32font): Add prototype.
6044
87e68db4
JB
60452011-10-27 Juanma Barranquero <lekktu@gmail.com>
6046
6047 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6048 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6049 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6050 (Fmove_to_window_line): Doc fix.
6051
435c1d67
CY
60522011-10-27 Chong Yidong <cyd@gnu.org>
6053
6054 * process.c (make_process): Set gnutls_state to NULL.
6055
6056 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6057 non-NULL, regardless of GNUTLS_INITSTAGE.
6058 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6059 an error. Set process slots as soon as we allocate them.
6060
6061 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6062
9c6c6f49
CY
60632011-10-27 Chong Yidong <cyd@gnu.org>
6064
9aba6043
SM
6065 * gnutls.c (emacs_gnutls_deinit): New function.
6066 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6067 (Fgnutls_deinit, Fgnutls_boot): Use it.
6068
6069 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6070 (deactivate_process): Call emacs_gnutls_deinit.
6071
657d08d3
JB
60722011-10-27 Juanma Barranquero <lekktu@gmail.com>
6073
6074 * image.c (x_create_x_image_and_pixmap):
6075 * w32.c (sys_rename, w32_delayed_load):
6076 * w32font.c (fill_in_logfont):
6077 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6078
5430d399
JB
60792011-10-26 Juanma Barranquero <lekktu@gmail.com>
6080
6081 * w32fns.c (w32_default_color_map): New function,
6082 extracted from Fw32_default_color_map.
a7ef684b 6083 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6084
fe0055fa
PE
60852011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6086
6087 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6088
e6346438
SM
60892011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6090
6091 * keyboard.c (test_undefined): New function (bug#9751).
6092 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6093
e112cc37
ET
60942011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6095
6096 * sysdep.c (init_sys_modes): Fix the check for the controlling
6097 terminal (Bug#6649).
6098
7b5d6677
EZ
60992011-10-20 Eli Zaretskii <eliz@gnu.org>
6100
6101 * dispextern.h (struct bidi_it): New member next_en_type.
6102
6103 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6104 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6105 current character, check also for next_en_type being WEAK_EN.
6106 (bidi_resolve_weak): Don't enter the expensive loop if the current
6107 position is before next_en_pos. Record the bidi type of the first
6108 non-ET, non-BN character we find, in addition to its position.
6109 (bidi_level_of_next_char): Invalidate next_en_type when
6110 next_en_pos is over-stepped.
6111
7da0b018
PE
61122011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6113
6114 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6115 * editfns.c: Rewrite current-time-zone so that it invokes
6116 the equivalent of (format-time-string "%Z") to get the time zone name.
6117 This fixes a bug when the time zone name contains characters that
6118 need converting from the system time locale to Emacs internal format.
6119 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6120 that patch fixed format-time-string to do the conversion, but
6121 I forgot to fix current-time-zone.
6122 (format_time_string): New function, containing most of
6123 what Fformat_time_string used to contain.
6124 (Fformat_time_string): Rewrite in terms of format_time_string.
6125 This doesn't change this function's behavior.
6126 (current-time-zone): Rewrite to use format_time_string.
6127 This fixes the bug reported by Michael Schierl in
6128 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6129 Jason Rumney's 2007-06-07 change worked around this bug, but
6130 didn't fix it.
6131 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6132
8547b010
EZ
61332011-10-19 Eli Zaretskii <eliz@gnu.org>
6134
6135 * xdisp.c (start_display): If the character at POS is displayed
6136 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6137 (try_window_reusing_current_matrix): If a line ends in a display
6138 vector or the next line starts in a display vector, continue
6139 redrawing the window even though the character position of
6140 start_row was reached.
8547b010
EZ
6141 (Bug#9771, part 2)
6142
4e948d15
CY
61432011-10-18 Chong Yidong <cyd@gnu.org>
6144
6145 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6146 with nobreak-char-display too.
6147
4787455f
EZ
61482011-10-18 Eli Zaretskii <eliz@gnu.org>
6149
6150 Fix part 3 of bug#9771.
6151 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6152 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6153 non-neutral characters if the current character is a paragraph
6154 separator (a.k.a. Newline). This avoids running the same
6155 expensive loop twice, once when we consume the preceding newline
6156 and the other time when the line actually needs to be displayed.
6157 Avoid the loop when we see neutrals on the base embedding level
6158 following a character whose directionality is the same as the
6159 paragraph's. This avoids running the expensive loop when a line
6160 ends in a long sequence of neutrals, like control characters.
6161 Add assertion against STRONG_AL type. Slightly rearrange code
6162 that determines the type of a neutral given the first non-neutral
6163 that follows it.
6164 (bidi_level_of_next_char): Set next_en_pos to zero when
6165 invalidating its info.
6166
2c91f553
EZ
61672011-10-17 Eli Zaretskii <eliz@gnu.org>
6168
6169 * xdisp.c (push_display_prop): Determine whether to record string
6170 or buffer position by IT->string, not by IT->method. Allow
6171 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6172 (move_it_vertically_backward): Don't look for character position
6173 immediately after the newline when in a continuation line.
6174 (Bug#9771, part 1)
2c91f553 6175
c7b08b0d
MR
61762011-10-15 Martin Rudalics <rudalics@gmx.at>
6177
6178 * window.c (coordinates_in_window): Rewrite and delabelize
6179 vertical border check. (Bug#5357) (Bug#9618)
6180
6b02f655
SM
61812011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6182
6183 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6184 errors in XSetWindowBorder (bug#9310).
6185
81d40c92
DA
61862011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6187
6188 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6189 avoid crash when xmalloc overrun checking is enabled.
6190
d4172c3b
EZ
61912011-10-13 Eli Zaretskii <eliz@gnu.org>
6192
6193 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6194 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6195 cursor motion with <left> and <right> arrow keys.
6196
6197 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6198 some callers set that themselves.
6199
b00eea75
EZ
62002011-10-12 Eli Zaretskii <eliz@gnu.org>
6201
6202 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6203 display string and the previous row comes from the same string and
6204 is empty. (Bug#9739) (Bug#9738)
6205
8fe012c4
SM
62062011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6207
6208 * doc.c (get_doc_string): Encode file name (bug#9735).
6209
0074aef2
EZ
62102011-10-12 Eli Zaretskii <eliz@gnu.org>
6211
79beb178
EZ
6212 * bidi.c (bidi_level_of_next_char):
6213 * xdisp.c (get_visually_first_element): Remove old incorrect
6214 comments regarding the Unicode Line Separator character.
6215
0074aef2
EZ
6216 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6217
6e4b3fbe
DA
62182011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6219
6220 * alloc.c (Fgc_status): Do not access beyond zombies array
6221 boundary if nzombies > MAX_ZOMBIES.
6222 * alloc.c (dump_zombies): Add missing format specifier.
6223
0324f3af
PE
62242011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6225
b5525cac
PE
6226 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6227 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6228
0324f3af
PE
6229 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6230 Some packages use them to denote characters with modifiers.
6231
e9b5f888
AS
62322011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6233
6234 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6235 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6236 matching a pp-number. Rename parameter var to var1.
6237
127827c0
SM
62382011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6239
6240 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6241
c8fd3bd0
GM
62422011-10-08 Glenn Morris <rgm@gnu.org>
6243
6244 * callint.c (Fcall_interactively): Give a more explicit error for the
6245 'c' case with a non-character input. (Bug#8479)
6246
352ec8ff
EZ
62472011-10-08 Eli Zaretskii <eliz@gnu.org>
6248
03669ccb
EZ
6249 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6250 lines.
7061c986
EZ
6251 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6252 lines that are hscrolled on the left.
03669ccb 6253
352ec8ff
EZ
6254 * dispnew.c (buffer_posn_from_coords): Account for a possible
6255 presence of header-line. (Bug#4426)
6256
a66cfb1c
SM
62572011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6258
6b02f655
SM
6259 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6260 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6261
7c5ee88e
PE
62622011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6263
6264 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6265 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6266 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6267 this makes Emacs dump core during garbage collection on rare
6268 occasions. sizeof is obviously inferior to offsetof here, so
6269 stick with offsetof.
6270 (GC_POINTER_ALIGNMENT): New macro.
6271 (mark_memory): Omit 3rd (offset) arg; caller changed.
6272 Don't assume EMACS_INT alignment is the same as pointer alignment.
6273
df1bbe5b
SM
62742011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6275
6276 * keyboard.c (read_key_sequence_remapped): New var.
6277 (read_key_sequence): Compute remapping in the right buffer.
6278 (command_loop_1): Use read_key_sequence's remapping directly.
6279
51553db6
SM
62802011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6281
32c1fffd
SM
6282 * dired.c (file_name_completion): Don't expand file name.
6283 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6284 before checking file name handler.
6285
51553db6
SM
6286 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6287 they've been requested explicitly (bug#9591).
6288
b6bd1599 62892011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6290
6291 * keymap.c (Fsingle_key_description): Use make_specified_string
6292 instead of build_string to build string from push_key_description.
6293 (Bug#5193)
6294
f701dc2a
PE
62952011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6296
4222c55d
PE
6297 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6298 This fixes a Y2038 bug on 64-bit hosts.
6299 * buffer.c (reset_buffer):
6300 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6301 (Fclear_buffer_auto_save_failure):
6302 Use 0, not -1, to represent an unset failure time, since time_t
6303 might not be signed.
6304
f701dc2a
PE
6305 Remove dependency on glibc malloc internals.
6306 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6307 Move back here from lisp.h, but with their new implementations.
6308 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6309 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6310 * charset.c (charset_table_init): New static var.
6311 (syms_of_charset): Use it instead of xmalloc. This removes a
6312 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6313 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6314 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6315 Move back to alloc.c.
6316 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6317 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6318
9ceebf39
JD
63192011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6320
6321 * nsterm.m (windowDidResize): Call x_set_window_size only when
6322 ns_in_resize is true. Otherwise set pixelwidth/height and
6323 call change_frame_size (Bug#9628).
6324
cb993c58
PE
63252011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6326
3930c88b
PE
6327 Port --enable-checking=all to Fedora 14 x86-64.
6328 * charset.c (syms_of_charset): Also account for glibc malloc's
6329 internal overhead when calculating the initial malloc maximum.
6330
cb993c58
PE
6331 Port --enable-checking=all to Fedora 14 x86.
6332 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6333 Move to lisp.h.
6334 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6335 (overrun_check_realloc, overrun_check_free):
6336 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6337 That way, xmalloc returns a properly-aligned pointer even if
6338 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6339 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6340 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6341 into account when calculating the initial malloc maximum.
6342 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6343 Move here from alloc.c, so that charset.c can use it too.
6344 Properly align; the old code wasn't right for common 32-bit hosts
6345 when configured with --enable-checking=all.
6346 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6347 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6348
31bed486
EZ
63492011-09-29 Eli Zaretskii <eliz@gnu.org>
6350
04c70788 6351 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6352 use EDOM.
6353
fbcaa2f3
EZ
63542011-09-28 Eli Zaretskii <eliz@gnu.org>
6355
6356 * xdisp.c (compute_display_string_end): If there's no display
6357 string at CHARPOS, return -1.
6358
6359 * bidi.c (bidi_fetch_char): When compute_display_string_end
6360 returns a negative value, treat the character as a normal
6361 character not covered by a display string. (Bug#9624)
6362
a239d4e9
JB
63632011-09-28 Juanma Barranquero <lekktu@gmail.com>
6364
6365 * lread.c (Fread_from_string): Fix typo in docstring.
6366
88652fd5
EZ
63672011-09-27 Eli Zaretskii <eliz@gnu.org>
6368
6369 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6370 newline, reseat the iterator instead of bidi-iterating there one
6371 character at a time. (Bug#9610)
32c1fffd
SM
6372 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6373 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6374
ed497dd4
AS
63752011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6376
6377 * lread.c (readevalloop): Use correct code for NBSP.
6378 (read1): Likewise. (Bug#9608)
6379
b2bf61aa
MA
63802011-09-25 Michael Albinus <michael.albinus@gmx.de>
6381
6382 * dbusbind.c (Fdbus_register_signal): When service is not
6383 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6384
32bbb17c
GM
63852011-09-25 Glenn Morris <rgm@gnu.org>
6386
6387 * buffer.c (truncate-lines): Doc fix.
6388
94e0933e
CY
63892011-09-24 Chong Yidong <cyd@stupidchicken.com>
6390
6391 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6392 (Fset_window_next_buffers): Doc fix.
6393
cddde921
GM
63942011-09-24 Glenn Morris <rgm@gnu.org>
6395
6396 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6397
1260aef1
PE
63982011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6399
25b4bfa0
PE
6400 Fix minor problems found by static checking.
6401 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6402 * indent.c (Fvertical_motion): Fix == vs = typo.
6403
e3cbd34b
EZ
64042011-09-24 Eli Zaretskii <eliz@gnu.org>
6405
a66cfb1c
SM
6406 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6407 Default value is now t. Doc fix.
6bf7006f 6408
e3cbd34b 6409 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6410 logic when moving up, not only when moving down. Fix the
e3cbd34b 6411 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6412 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6413
6414 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6415 CHARPOS is covered by a display string which includes newlines.
6416 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6417 is covered by a display string with embedded newlines.
6418
a3de0cbd
MA
64192011-09-24 Michael Albinus <michael.albinus@gmx.de>
6420
6421 * dbusbind.c (Fdbus_register_signal): Add match rule to
6422 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6423 (Fdbus_register_method, Vdbus_registered_objects_table):
6424 Fix docstring.
a3de0cbd 6425
b260039d
JM
64262011-09-24 Jim Meyering <meyering@redhat.com>
6427
32c1fffd 6428 do not ignore write error for any output size
b260039d
JM
6429 The previous change was incomplete.
6430 While it makes emacs --batch detect the vast majority of stdout
6431 write failures, errors were still ignored whenever the output size is
6432 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6433 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6434 && echo FAIL: ignored write error
6435 FAIL: ignored write error
6436 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6437 && echo FAIL: ignored write error
6438 FAIL: ignored write error
6439 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6440
8eca8a7c
AS
64412011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6442
6443 * emacs.c (Fkill_emacs): In noninteractive mode exit
6444 non-successfully if a write error occurred on stdout. (Bug#9574)
6445
3341db62
EZ
64462011-09-21 Eli Zaretskii <eliz@gnu.org>
6447
6448 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6449 the xassert test.
6450
6451 * dispextern.h (struct it): Update the comment documenting what
6452 can it->OBJECT be.
6453
8c203dbf
EZ
64542011-09-20 Eli Zaretskii <eliz@gnu.org>
6455
6456 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6457 a display string, extend search for cursor position to end of row.
6458 (find_row_edges): If the row ends in a newline from a display
6459 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6460 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6461 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6462 non-empty line. Fixes confusing cursor motion with arrow keys at
6463 the beginning of a line that starts with whitespace.
8c203dbf 6464
a4824228
LMI
64652011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6466
6467 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6468 (bug#9493).
6469
33ed493b
CY
64702011-09-18 Chong Yidong <cyd@stupidchicken.com>
6471
6472 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6473 boolean (Bug#9154).
6474
56cd55c8
EZ
64752011-09-18 Eli Zaretskii <eliz@gnu.org>
6476
6477 * xdisp.c (display_line): Record maximum and minimum buffer
6478 positions even if no glyphs were produced (e.g., by a zero-width
6479 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6480 buffer positions that will be removed from the glyph row because
6481 they don't fit.
c02dcedf
EZ
6482 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6483 column is beyond frame width: don't subtract 1 "pixel" when
6484 computing width of the stretch.
3e62b7e0
EZ
6485 (reseat_at_next_visible_line_start): Undo the change made on
6486 2011-09-17 that saved paragraph information and restored it after
6487 the call to `reseat'. (Bug#9545)
56cd55c8 6488
5ed99d36 64892011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6490
6491 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6492 and turn window cursor on if cleared (Bug#9415).
6493
5ed99d36 64942011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6495
6496 * search.c (boyer_moore): Take unibyte characters from pattern
6497 literally. (Bug#9458)
6498
9bade7b2
EZ
64992011-09-18 Eli Zaretskii <eliz@gnu.org>
6500
6501 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6502
e5e9d610
PE
65032011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6504
87e4427a
PE
6505 Fix minor problem found by static checking.
6506 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6507 initialized, to pacify gcc -Wuninitialized.
6508
e5e9d610
PE
6509 * fileio.c: Report proper errno when syscall falls.
6510 (Finsert_file_contents): Save and restore errno,
6511 so that report_file_error outputs the correct diagnostic.
6512 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6513
a1674f0b
EZ
65142011-09-18 Eli Zaretskii <eliz@gnu.org>
6515
6516 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6517
fbfb6dd4
EZ
65182011-09-17 Eli Zaretskii <eliz@gnu.org>
6519
6520 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6521 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6522
bb187662
EZ
65232011-09-17 Eli Zaretskii <eliz@gnu.org>
6524
1137e8b8 6525 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6526 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6527
6528 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6529 (bidi_find_paragraph_start): Search back for paragraph beginning
6530 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6531 (bidi_move_to_visually_next): Only trigger paragraph-related
6532 computations when the last character is a newline or at EOB, not
6533 just any NEUTRAL_B. (Bug#9470)
6534
bb187662
EZ
6535 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6536 truncated lines if point is covered by a display string. (Bug#9524)
6537
2e621251
PE
65382011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6539
6540 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6541 (cons_to_x_long): New function.
6542 (lisp_data_to_selection_data): Use it. Correct the test for
6543 short-versus-long data; it was negated. Break out of vector
6544 loop, for efficiency, when a long datum is discovered.
6545
91a15bc6
SM
65462011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6547
6548 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6549
b41c3a35
EZ
65502011-09-16 Eli Zaretskii <eliz@gnu.org>
6551
6552 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6553 GCC PR/17406) by declaring this function with external scope.
6554
7812ba2d
PE
65552011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6556
6557 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6558 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6559
cf7edc2a
AS
65602011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6561
6562 * editfns.c (Fformat): Correctly handle text properties on "%%".
6563
bd01620e
EZ
65642011-09-15 Eli Zaretskii <eliz@gnu.org>
6565
6566 * xterm.c (x_draw_composite_glyph_string_foreground):
6567 * w32term.c (x_draw_composite_glyph_string_foreground):
6568 * term.c (encode_terminal_code):
6569 * composite.c (composition_update_it, get_composition_id):
6570 * xdisp.c (get_next_display_element)
6571 (fill_composite_glyph_string): Add comments about special meaning
6572 of TAB characters in a composition.
6573
a02719a3
PE
65742011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6575
6576 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6577 This occurs when processing a multibyte format.
6578 Problem reported by Wolfgang Jenker.
a02719a3 6579
72589a3c
JB
65802011-09-15 Johan Bockgård <bojohan@gnu.org>
6581
6582 * xdisp.c (try_cursor_movement): Only check for exact match if
6583 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6584
1c14176c
PE
65852011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6586
6587 Remove unused external symbols.
6588 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6589 * xdisp.c (calc_pixel_width_or_height): Now static.
6590 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6591 * indent.c (check_display_width):
6592 * w32term.c: Fix comment to match code.
6593 * xterm.c, xterm.h (x_catching_errors): Remove.
6594
d2eea5b5
PE
65952011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6596
6597 * xselect.c: Use signed conversions more consistently (Bug#9498).
6598 (selection_data_to_lisp_data): Assume incoming selection data are
6599 signed integers, not unsigned. This is to be consistent with
6600 outgoing selection data, which was modified to use signed integers
6601 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6602 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6603 expects long, not unsigned long.
6604
46888499
EZ
66052011-09-14 Eli Zaretskii <eliz@gnu.org>
6606
6607 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6608 computation of loop end. Reported by Johan Bockgård
6609 <bojohan@gnu.org>.
6610
ef8ef9fb
CY
66112011-09-13 Chong Yidong <cyd@stupidchicken.com>
6612
6613 * frame.c (Fother_visible_frames_p): Function deleted.
6614
fa819fed
EZ
66152011-09-12 Eli Zaretskii <eliz@gnu.org>
6616
6617 * indent.c (compute_motion): Process display vector front to back
6618 rather than the other way around. (Bug#2496)
6619
2ba8e008
SM
66202011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6621
6622 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6623
20f53c69
CY
66242011-09-11 Chong Yidong <cyd@stupidchicken.com>
6625
6626 * minibuf.c (Fread_from_minibuffer): Doc fix.
6627
d562d7a4
EZ
66282011-09-11 Eli Zaretskii <eliz@gnu.org>
6629
6630 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6631 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6632
1c4d7f3d
LMI
66332011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6634
6635 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6636 value for non-existent files.
6637
b885bf36
EZ
66382011-09-11 Eli Zaretskii <eliz@gnu.org>
6639
6640 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6641 set its "size" to -1. This will set the modtime_size field of
6642 the corresponding buffer to -1, which is what
6643 verify-visited-file-modtime expects for files that do not exist.
6644 (Bug#9139)
6645
6612f0bf
PE
66462011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6647
6648 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6649 here ...
6650 * lisp.h: ... from here. push_key_description is no longer
6651 defined in keyboard.c, so its declaration should not be in
6652 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6653 logically belongs with push_key_description.
6654
dfb3f755
PE
66552011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6656
6657 * buffer.h: Include <sys/types.h> instead of <time.h>.
6658 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6659 Problem reported by Herbert J. Skuhra.
6660
3134906c
LMI
66612011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6662
6663 * xml.c (parse_region): Make the parsing work for
6664 non-comment-starting XML files again (bug#9144).
6665
8d903f4e
AS
66662011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6667
6668 * image.c (gif_load): Fix calculation of bottom and right corner.
6669 (Bug#9468)
6670
80ad64f4
EZ
66712011-09-10 Eli Zaretskii <eliz@gnu.org>
6672
6673 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6674 redisplay in small windows.
6675
208a048d
EZ
66762011-09-09 Eli Zaretskii <eliz@gnu.org>
6677
6678 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6679
9b1c252e
MR
66802011-09-08 Martin Rudalics <rudalics@gmx.at>
6681
6682 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6683 Operate on live windows only.
6684
2949f33b
JB
66852011-09-08 Juanma Barranquero <lekktu@gmail.com>
6686
6687 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6688
e08dcafd
EZ
66892011-09-07 Eli Zaretskii <eliz@gnu.org>
6690
6691 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6692 only under bidi iteration.
6693
115b96bd
JD
66942011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6695
6696 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6697
c8199d0f
PE
66982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6699
6700 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6701 Without this fix, the command to link temacs failed due to an
6702 undefined symbol __builtin_isnan. This is because
6703 /usr/include/iso/math_c99.h #defines isnan(x) to
6704 __builtin_isnan(x), but the bundled gcc, which identifies itself
6705 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6706 a __builtin_isnan.
6707 * floatfns.c (isnan): #undef, and then #define to a clone of
6708 what's in data.c.
6709 (Fisnan): Always define, since it's always available now.
6710 (syms_of_floatfns): Always define isnan at the Lisp level.
6711
e39b275c 67122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6713
6714 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6715
b2db44d9 67162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6717
f4af5137 6718 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6719 The previous code assumed that file offsets (off_t values) fit in
6720 EMACS_INT variables, which is not true on typical 32-bit hosts.
6721 The code messed up by falsely reporting buffer overflow in cases
6722 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6723 when "big" contains more than 2**29 bytes, even though this
6724 inserts just one byte and does not overflow the buffer.
6725 (Finsert_file_contents): Store file offsets as off_t
6726 values, not as EMACS_INT values. Check for overflow when
6727 converting between EMACS_INT and off_t. When checking for
6728 buffer overflow or for overlap, take the offsets into account.
6729 Don't use EMACS_INT for small values where int suffices.
6730 When checking for overlap, fix a typo: ZV was used where
6731 ZV_BYTE was intended.
6732 (Fwrite_region): Don't assume off_t fits into 'long'.
6733 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6734
ecfc0a49
MA
67352011-09-05 Michael Albinus <michael.albinus@gmx.de>
6736
6737 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6738
6511acf2 67392011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6740
0999621a 6741 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6742
6743 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6744 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6745 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6746 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6747 (modify_event_symbol): Do not assume that the length of
6748 name_alist_or_stem is safe to alloca and fits in int.
6749 (Fexecute_extended_command): Likewise for function name and binding.
6750 (Frecursion_depth): Wrap around reliably on integer overflow.
6751 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6752 since some callers pass EMACS_INT values.
6753 (Fsingle_key_description): Don't crash if symbol name contains more
6754 than MAX_ALLOCA bytes.
6755 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6756 (get_minibuffer): Arg is now EMACS_INT, not int.
6757 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6758 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6759 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6760
2be7d702
PE
6761 * dbusbind.c (signature_cat): New function.
6762 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6763 Do not overrun buffer; instead, report string overflow.
6764
9d1df220
PE
6765 * dispnew.c (add_window_display_history): Don't overrun buffer.
6766 Truncate instead; this is OK since it's just a log.
6767
33ef5c64
PE
6768 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6769 even if the time zone offset is outlandishly large.
6770 Don't mishandle offset == INT_MIN.
6771
66c6fdd5
PE
6772 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6773 when creating daemon; the previous buffer-overflow check was incorrect.
6774
d749b01b
PE
6775 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6776 which has the guts of the old verror function.
6777
b5cd1905
PE
6778 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6779 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6780
6e1a67fb
PE
6781 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6782 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6783 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6784 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6785 length of string rather than counting it via multiple sprintfs;
6786 that's simpler and more reliable.
c21721cc
PE
6787 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6788 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6789 sprintf, in case result does not fit in int.
6790
c57b67fc
PE
6791 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6792 (fontset_from_font): Print it.
6793
8a401434
PE
6794 * frame.c (tty_frame_count): Now printmax_t, not int.
6795 (make_terminal_frame, set_term_frame_name): Print it.
6796 (x_report_frame_params): In X, window IDs are unsigned long,
6797 not signed long, so print them as unsigned.
6798 (validate_x_resource_name): Check for implausibly long names,
6799 and don't assume name length fits in 'int'.
6800 (x_get_resource_string): Don't blindly alloca invocation name;
6801 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6802 not fit in int.
6803
6e1a67fb
PE
6804 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6805 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6806 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6807
0df02bf3
PE
6808 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6809 Use esprintf, not sprintf, in case result does not fit in int.
6810
48e30793
PE
6811 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6812 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6813 it as a large positive number.
6814 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6815 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6816
a66ff6d8
PE
6817 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6818 in case result does not fit in int.
6819
aca216ff
PE
6820 * print.c (float_to_string): Detect width overflow more reliably.
6821 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6822 buffer overrun. Don't assume list length fits in 'int'. Treat
6823 print length of 0 as 0, not as infinity; to be consistent with other
6824 uses of print length in this function. Don't overflow print length
6825 index. Don't assume hash table size fits in 'long', or that
6826 vectorlike size fits in 'unsigned long'.
6827
31c286f7
PE
6828 * process.c (make_process): Use printmax_t, not int, to format
6829 process-name gensyms.
6830
55e5faa1
PE
6831 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6832
80f2e268
PE
6833 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6834 to avoid potential buffer overrun.
6835
670741ab
PE
6836 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6837 if X resource line is longer than 512 bytes.
6838
b7163a50
PE
6839 * xfns.c (x_window): Make sprintf buffer a bit bigger
6840 to avoid potential buffer overrun.
6841
ae58ff1f
PE
6842 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6843
c43c8a6a
PE
6844 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6845
3f8236f4
PE
68462011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6847
53e9fe90 6848 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6849 Without these, Emacs silently mishandles large integers sometimes.
6850 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6851 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6852
6511acf2
PE
6853 * xdisp.c (try_window_id): Check Emacs fixnum range before
6854 converting to 'int'.
806add1d 6855
6511acf2 6856 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6857 Check that an Emacs fixnum is in range before assigning it to 'int'.
6858 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6859 values converted from Emacs fixnums.
6860 (Frecenter): Don't wrap around a line count if it is out of 'int'
6861 range; instead, treat it as an extreme value.
6862 (Fset_window_configuration, compare_window_configurations):
6863 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6864
6511acf2
PE
6865 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6866 that can exceed INT_MAX. Check that EMACS_INT value is in range
6867 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6868 (match_limit): Don't assume that a fixnum can fit in 'int'.
6869
6511acf2 6870 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6871 exceed INT_MAX.
6872
6511acf2 6873 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6874 (Fvertical_motion): Don't wrap around LINES values that don't fit
6875 in 'int'. Instead, treat them as extreme values. This is good
6876 enough for windows, which can't have more than INT_MAX lines anyway.
6877
fcb901a7
LMI
68782011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6879
0f2f6b6d
LMI
6880 * Require libxml/parser.h to avoid compilation warning.
6881
fcb901a7
LMI
6882 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6883
6884 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6885 since this reportedly can destroy thread storage.
6886
6e20a0d4
CY
68872011-08-30 Chong Yidong <cyd@stupidchicken.com>
6888
6889 * syntax.c (find_defun_start): Update all cache variables if
6890 exiting early (Bug#9401).
6891
148ae00e
EZ
68922011-08-30 Eli Zaretskii <eliz@gnu.org>
6893
f6cfbd8f
EZ
6894 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6895
148ae00e
EZ
6896 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6897 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6898 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6899
6900 * term.c (tty_append_glyph): New function.
6901 (produce_stretch_glyph): Static function and its prototype deleted.
6902
a66cfb1c
SM
6903 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6904 Add prototypes.
148ae00e 6905
c4a07a4c
PE
69062011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6907
6908 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6909 when checking :margin (Bug#9390).
6910 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6911 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6912 so that the name doesn't mislead. All uses changed.
6913
6bc8cd65
JB
69142011-08-28 Johan Bockgård <bojohan@gnu.org>
6915
6916 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6917 set_tty_hooks.
6918
dca4927e
EZ
69192011-08-27 Eli Zaretskii <eliz@gnu.org>
6920
6921 * xdisp.c (move_it_to): Don't bail out early when reaching
6922 position beyond to_charpos, if we are scanning backwards.
6923 (move_it_vertically_backward): When DY == 0, make sure we get to
6924 the first character in the line after the newline.
6925
f2cad773
PE
69262011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6927
6928 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6929 (ccl_driver): Do not generate an out-of-range pointer.
6930 (Fccl_execute_on_string): Remove unnecessary check for
6931 integer overflow, noted by Stefan Monnier in
6932 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6933 Remove a FIXME that didn't need fixing.
6934 Simplify the newly-introduced buffer reallocation code.
6935
0cae2cdb
JB
69362011-08-27 Juanma Barranquero <lekktu@gmail.com>
6937
6938 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6939
5fc295a4 69402011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6941
70c60eb2 6942 Integer and memory overflow issues (Bug#9196).
726e0ab1 6943
d31850da
PE
6944 * doc.c (get_doc_string): Rework so that
6945 get_doc_string_buffer_size is the actual buffer size, rather than
6946 being 1 less than the actual buffer size; this makes xpalloc more
6947 convenient.
6948
a69fbedb
PE
6949 * image.c (x_allocate_bitmap_record, cache_image):
6950 * xselect.c (Fx_register_dnd_atom):
6951 Simplify previous changes by using xpalloc.
6952
fe5c5d37
PE
6953 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6954 since either will do and ptrdiff_t is convenient with xpalloc.
6955
0065d054
PE
6956 * charset.c (charset_table_size)
6957 (struct charset_sort_data.priority): Now ptrdiff_t.
6958 (charset_compare): Don't overflow if priorities differ greatly.
6959 (Fsort_charsets): Don't assume list length fits in int.
6960 Check for size-calculation overflow when allocating sort data.
6961 (syms_of_charset): Allocate an initial charset table that is
6962 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6963
6964 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6965
6966 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6967 The actual value is always <= INT_MAX, and leaving it unsigned made
6968 overflow checking harder.
6969
6970 * dispextern.h (struct glyph_matrix.rows_allocated)
6971 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6972 with xpalloc. The values are still always <= INT_MAX.
6973
6974 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6975
6976 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6977 (SAFE_NALLOCA): New macro.
6978
6979 * region-cache.c (struct boundary.pos, find_cache_boundary)
6980 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6981 (set_cache_region, invalidate_region_cache)
6982 (revalidate_region_cache, know_region_cache, region_cache_forward)
6983 (region_cache_backward, pp_cache):
6984 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6985 so that ptrdiff_t * can be passed to xpalloc.
6986 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6987 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6988 (pp_cache): Don't assume cache_len fits in int.
6989 * region-cache.h: Adjust extern decls to match.
6990
6991 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6992 EMACS_INT, since either will do, for xpalloc.
6993
6994 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6995 (xnmalloc, xnrealloc, xpalloc): New functions.
6996
726e0ab1
PE
6997 * bidi.c (bidi_shelve_header_size): New constant.
6998 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6999 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7000
51f30bc5 7001 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7002 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7003 (overlay_strings):
7004 Don't update size of array until after memory allocation succeeds,
7005 because xmalloc/xrealloc may not return.
0065d054
PE
7006 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7007 now that we have proper integer overflow checking.
7008 (record_overlay_string, overlay_strings): Catch overflows when
7009 calculating size of overlay_str_buf.
726e0ab1 7010
0065d054
PE
7011 * callproc.c (Fcall_process): Check for size overflow when
7012 calculating size of args2.
7013 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7014 Normally we prefer signed values, but sticking with ptrdiff_t would
7015 require adding more-complicated checks.
726e0ab1
PE
7016
7017 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7018 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7019 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7020 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7021
7022 * character.c (Fstring): Check for size-calculation overflow.
7023
7024 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7025 unnecessary integer overflow. Check for size overflow.
7026 (encode_coding_object): Don't update size until xmalloc succeeds.
7027
7028 * composite.c (get_composition_id): Check for overflow in glyph
7029 length calculations.
7030
7031 Integer and memory overflow fixes for display code.
7032 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7033 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7034 (scrolling_window): Check for overflow in size calculations.
7035 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7036 Don't assume glyph table len fits in int.
7037 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7038 (row_table_size): Now ptrdiff_t, not int.
7039 (scrolling_window): Avoid overflow in size calculations.
7040 Don't update size until allocation succeeds.
7041 * fns.c (concat): Check for overflow in size calculations.
7042 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7043 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7044 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7045
7046 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7047 (get_doc_string): Check for size calculation overflow.
7048 Don't update size until allocation succeeds.
7049 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7050 EMACS_INT, where ptrdiff_t will do.
7051 (Fsubstitute_command_keys): Check for string overflow.
7052
7053 * editfns.c (set_time_zone_rule): Don't assume environment length
7054 fits in int.
7055 (message_length): Now ptrdiff_t, not int.
7056 (Fmessage_box): Don't update size until allocation succeeds.
7057 Don't assume message length fits in int.
7058 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7059
0065d054
PE
7060 * emacs.c (main): Do not reallocate argv, since there is a null at
7061 the end that can be overwritten, and this way there's no need to
7062 worry about size-calculation overflow.
7063 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7064
7065 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7066 alloc succeeds.
7067 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7068
7069 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7070 (x_set_scroll_bar_width, x_figure_window_size):
7071 Check for integer overflow.
7072 (x_set_alpha): Do not assume XINT fits in int.
7073
7074 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7075 This is for the members text_lines, text_cols, total_lines, total_cols,
7076 where the system imposes an 'int' limit.
7077
7078 * fringe.c (Fdefine_fringe_bitmap):
7079 Don't update size until alloc works.
7080
7081 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7082 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7083
7084 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7085 Check for size-calculation overflow.
7086 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7087 do, as we prefer signed integers.
7088 (id_to_widget.max_size, id_to_widget.used)
7089 (xg_store_widget_in_map, xg_remove_widget_from_map)
7090 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7091 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7092 Use and return ptrdiff_t, not int.
7093 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7094 * gtkutil.h: Change prototypes to match the above.
7095
7096 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7097 are duplicate now that they've been promoted to lisp.h.
7098 (x_allocate_bitmap_record, x_alloc_image_color)
7099 (make_image_cache, cache_image, xpm_load):
7100 Don't update size until alloc is done.
7101 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7102 (x_detect_edges):
3256efce 7103 Check for size calculation overflow.
726e0ab1
PE
7104 (ct_colors_allocated_max): New constant.
7105 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7106 overflow.
3256efce 7107
726e0ab1
PE
7108 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7109 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7110 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7111 Use ptrdiff_t, not int, to count maps.
7112 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7113 calculations. Don't update size until allocation succeeds.
7114 Redo calculations to avoid overflow.
726e0ab1
PE
7115 * keyboard.h: Change prototypes to match the above.
7116
7117 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7118 to count maps.
7119 (current_minor_maps): Check for size calculation overflow.
7120 * keymap.h: Change prototypes to match the above.
7121
7122 * lread.c (read1, init_obarray): Don't update size until alloc done.
7123
7124 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7125 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7126
726e0ab1
PE
7127 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7128 Now ptrdiff_t, not int.
7129 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7130 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7131
7132 * process.c (Fnetwork_interface_list): Check for overflow
7133 in size calculation.
7134
7135 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7136
7137 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7138 overflow. Don't bother calling xmalloc when xrealloc will do.
7139
7140 * search.c (Freplace_match): Check for size calculation overflow.
7141 (Fset_match_data): Don't assume list lengths fit in 'int'.
7142
7143 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7144 for command line length. Do not attempt to address one before the
7145 beginning of an array, as that's not portable.
7146
7147 * term.c (max_frame_lines): Remove; unused.
7148 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7149 not int.
7150 (encode_terminal_code, calculate_costs): Check for size
7151 calculation overflow.
7152 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7153 table lengths and related sizes. Don't update size until alloc
7154 done. Redo calculations to avoid overflow.
7155 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7156
7157 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7158 subtracting pointers.
7159 (gobble_line): Check for overflow more carefully. Don't update size
7160 until alloc done.
7161
7162 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7163 Don't update size until alloc done.
7164 Redo size calculations to avoid overflow.
7165 Check for size calculation overflow.
0065d054 7166 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7167
7168 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7169 Use ptrdiff_t, not int, for sizes.
7170 (store_mode_line_noprop_char): Don't update size until alloc done.
7171
0065d054
PE
7172 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7173 Use ptrdiff_t, not int, for sizes.
7174 (Finternal_make_lisp_face, cache_face):
7175 Check for size calculation overflow.
7176 (cache_face): Treat size calculation overflows as if they were
7177 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7178
7179 * xfns.c (x_encode_text, x_set_name_internal)
7180 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7181 sizes, since they can exceed INT_MAX in size. Check for size
7182 calculation overflow.
7183
0065d054
PE
7184 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7185 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7186 Don't update size until alloc done.
7187
0065d054 7188 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7189 as sprintf is limited to int lengths.
1d526e2f 7190
252c5ee1
PE
7191 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7192 (X_LONG_MIN): New macros.
864d7ce7
PE
7193 Use them to make the following changes clearer.
7194 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7195 This change doesn't affect the value now, but it may help remind
7196 future maintainers not to raise the value too much later.
7197 (SELECTION_QUANTUM): Remove, replacing with ...
7198 (selection_quantum): ... new function, which avoids overflow.
7199 All uses changed.
7200 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7201 assumption that selection length fits in 'int'.
7202 (x_reply_selection_request, x_handle_selection_request)
7203 (x_get_window_property, receive_incremental_selection)
7204 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7205 (lisp_data_to_selection_data, clean_local_selection_data):
7206 Use ptrdiff_t, not int, to record length of selection.
7207 (x_reply_selection_request, x_get_window_property)
7208 (receive_incremental_selection, x_property_data_to_lisp):
7209 Redo calculations to avoid overflow.
7210 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7211 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7212 something.
7213 (x_get_window_property, receive_incremental_selection)
7214 (lisp_data_to_selection_data, x_property_data_to_lisp):
7215 Check for size-calculation overflow.
7216 (x_get_window_property, receive_incremental_selection)
7217 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7218 Don't store size until memory allocation succeeds.
7219 (x_get_window_property): Plug memory leak on memory exhaustion.
7220 Don't double-block input; malloc is safe here. Don't assume 2**34
7221 - 4 fits in unsigned long. Add an xassert to check
7222 XGetWindowProperty overflow. Be more careful about overflow
7223 calculations, and distinguish size from memory overflow better.
7224 (receive_incremental_selection): When tracing, don't assume
7225 unsigned int is less than INT_MAX.
7226 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7227 harmful) conversions of unsigned short to int.
7228 (lisp_data_to_selection_data): Don't assume that integers
7229 in the range -65535 through -1 fit in an X unsigned short.
7230 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7231 result parameters unless successful. Rely on cons_to_unsigned
7232 to report problems with elements; the old code wasn't right anyway.
7233 (x_check_property_data): Check for int overflow; we cannot use
7234 a wider type due to X limits.
7235 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7236
726e0ab1 7237 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7238
0065d054
PE
7239 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7240 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7241 (x_color_cells): Don't store size until memory allocation succeeds.
7242 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7243 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7244 (x_term_init): Don't assume length fits in int (sprintf is limited
7245 to int size).
bc18e09d 7246
ebfa62c0
PE
7247 Use ptrdiff_t for composition IDs.
7248 * character.c (lisp_string_width):
7249 * composite.c (composition_table_size, n_compositions)
7250 (get_composition_id, composition_gstring_from_id):
7251 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7252 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7253 * window.c (Frecenter):
7254 Use ptrdiff_t, not int, for composition IDs.
7255 * composite.c (get_composition_id): Check for integer overflow.
7256 * composite.h: Adjust prototypes to match the above changes.
7257
d3411f89
PE
7258 Use ptrdiff_t for hash table indexes.
7259 * category.c (hash_get_category_set):
7260 * ccl.c (ccl_driver):
7261 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7262 * coding.c (coding_system_charset_list, detect_coding_system):
7263 * coding.h (struct coding_system.id):
7264 * composite.c (get_composition_id, gstring_lookup_cache):
7265 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7266 * image.c (xpm_get_color_table_h):
7267 * lisp.h (hash_lookup, hash_put):
7268 * minibuf.c (Ftest_completion):
7269 Use ptrdiff_t for hash table indexes, not int (which is too
7270 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7271 32-bit --with-wide-int hosts).
7272
e097a6fa
PE
7273 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7274 Add a FIXME comment about memory leaks.
7275 (syms_of_charset): Don't assume xmalloc returns.
7276
5637687f
PE
7277 Don't assume that stated character widths fit in int.
7278 * character.c (Fchar_width, c_string_width, lisp_string_width):
7279 * character.h (CHAR_WIDTH):
7280 * indent.c (MULTIBYTE_BYTES_WIDTH):
7281 Use sanitize_char_width to avoid undefined and/or bad behavior
7282 with outlandish widths.
a66cfb1c 7283 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7284 now that we have two such functions. All uses changed.
7285 (sanitize_char_width): New inline function.
7286
a2271ba2
PE
7287 Don't assume that tab-width fits in int.
7288 * character.h (sanitize_width): New inline function.
7289 (SANE_TAB_WIDTH): New macro.
7290 (ASCII_CHAR_WIDTH): Use it.
7291 * indent.c (sane_tab_width): Remove. All uses replaced by
7292 SANE_TAB_WIDTH (current_buffer).
7293 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7294
18c52557
PE
7295 * fileio.c: Integer overflow issues with file modes.
7296 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7297
caeeedc1
PE
7298 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7299 Remove unreachable code.
7300 (read_hex, load_charset_map_from_file): Check for integer overflow.
7301
6df6ae42 7302 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7303 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7304 (x_send_scroll_bar_event): Likewise. Check that the size does not
7305 exceed limits imposed by XClientMessageEvent, as well as the usual
7306 ptrdiff_t and size_t limits.
7307
b13995db
PE
7308 * keyboard.c: Overflow, signedness and related fixes.
7309 (make_lispy_movement): Use same integer type in forward decl
7310 that is used in the definition.
7311 (read_key_sequence, keyremap_step):
7312 Change bufsize argument back to int, undoing my 2011-03-30 change.
7313 We prefer signed types, and int is wide enough here.
7314 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7315 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7316 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7317 length, not size_t. Use ptrdiff_t for index, not int.
7318 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7319 possibility of integer overflow.
7320
13464394
PE
7321 Overflow, signedness and related fixes for images.
7322
7323 * dispextern.h (struct it.stack[0].u.image.image_id)
7324 (struct_it.image_id, struct image.id, struct image_cache.size)
7325 (struct image_cache.used, struct image_cache.ref_count):
7326 * gtkutil.c (update_frame_tool_bar):
7327 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7328 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7329 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7330 * nsmenu.m (update_frame_tool_bar):
7331 * xdisp.c (calc_pixel_width_or_height):
7332 * xfns.c (image_cache_refcount):
7333 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7334 on typical 64-bit hosts.
7335
7336 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7337 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7338 Omit unnecessary casts to int.
7339 (parse_image_spec): Check that integers fall into 'int' range
7340 when the callers expect that.
7341 (image_ascent): Redo ascent calculation to avoid int overflow.
7342 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7343 (lookup_image): Remove unnecessary tests.
7344 (xbm_image_p): Locals are now of int, not EMACS_INT,
7345 since parse_image_check makes sure they fit into int.
7346 (png_load, gif_load, svg_load_image):
7347 Prefer int to unsigned where either will do.
7348 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7349 old tiff_error_handler and tiff_warning_handler.
7350 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7351 stack buffer overflows. It uses only the features of vsnprintf
7352 that are common to both POSIX and native Microsoft.
7353 (tiff_error_handler, tiff_warning_handler): Use it.
7354 (tiff_load, gif_load, imagemagick_load_image):
7355 Don't assume :index value fits in 'int'.
7356 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7357 (imagemagick_load_image): Check that crop parameters fit into
7358 the integer types that MagickCropImage accepts. Don't assume
7359 Vimagemagick_render_type has a nonnegative value. Don't assume
7360 size_t fits in 'long'.
7361 (gs_load): Use printmax_t to print the widest integers possible.
7362 Check for integer overflow when computing image height and width.
7363
c11821d4
EZ
73642011-08-26 Eli Zaretskii <eliz@gnu.org>
7365
7366 * xdisp.c (redisplay_window): Don't force window start if point
7367 will be invisible in the resulting window. (Bug#9324)
7368
0c95fcf7
EZ
73692011-08-25 Eli Zaretskii <eliz@gnu.org>
7370
7371 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7372 the display spec is of the form `(space ...)'.
7373 (handle_display_spec): Return the value returned by
7374 handle_single_display_spec, not just 1 or zero.
7375 (handle_single_display_spec): If the display spec is of the form
7376 `(space ...)', and specifies display in the text area, return 2
7377 rather than 1.
fee65a97 7378 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7379 accurately, and prefer exact match for point under bidi.
7380 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7381
7382 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7383 into disp_prop; all users changed.
7384
7385 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7386 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7387 for the text covered by the display property.
7388
e4ed06f1
CY
73892011-08-25 Chong Yidong <cyd@stupidchicken.com>
7390
7391 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7392 Change return value to nil.
7393 (Frecord_buffer): Delete unused function.
7394
f67cdd7f
EZ
73952011-08-24 Eli Zaretskii <eliz@gnu.org>
7396
5980d4c6
EZ
7397 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7398 buffers, return left-to-right.
8610fe8b
EZ
7399 (set_cursor_from_row): Consider candidate row a win if its glyph
7400 represents a newline and point is on that newline. Fixes cursor
7401 positioning on the newline at EOL of R2L text within L2R
7402 paragraph, and vice versa.
7403 (try_cursor_movement): Check continued rows, in addition to
7404 continuation rows. Fixes unwarranted scroll when point enters a
7405 continued line of R2L text within an L2R paragraph, or vice versa.
7406 (cursor_row_p): Consider the case of point being equal to
7407 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7408 from the end of a short line to the beginning of a continued line
7409 of R2L text within L2R paragraph.
7410 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7411 composed characters.
5980d4c6 7412
f67cdd7f
EZ
7413 * bidi.c (bidi_check_type): Use xassert.
7414 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7415 members.
7416
bca633fb
EZ
74172011-08-23 Eli Zaretskii <eliz@gnu.org>
7418
7419 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7420 a character.
7421
4a5885a7
CY
74222011-08-23 Chong Yidong <cyd@stupidchicken.com>
7423
7424 * nsfont.m (ns_otf_to_script): Fix typo.
7425
0902a04e
KH
74262011-08-22 Kenichi Handa <handa@m17n.org>
7427
7428 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7429 extra slot even if the purpose is char-code-property-table.
7430
1a2e6670
EZ
74312011-08-23 Eli Zaretskii <eliz@gnu.org>
7432
8ddde651
EZ
7433 * xdisp.c (redisplay_window): When computing centering_position,
7434 account for the height of the header line. (Bug#8874)
7435
425cc014
EZ
7436 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7437 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7438 candidate is selected by the mouse, and that candidate has a
7439 composed character under the mouse.
7440
1a2e6670
EZ
7441 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7442 coordinates reported by pos-visible-in-window-p for a composed
7443 character in column zero.
7444
8b76d6f8
SM
74452011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7446
7447 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7448
dac347dd
EZ
74492011-08-22 Eli Zaretskii <eliz@gnu.org>
7450
7451 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7452 consider it a hit if to_charpos is anywhere in the range of the
7453 composed buffer positions.
7454
e013fb34
CY
74552011-08-22 Chong Yidong <cyd@stupidchicken.com>
7456
7457 * image.c (gif_load): Don't assume that each subimage has the same
7458 dimensions as the base image. Handle disposal method that is
7459 "undefined" by the gif spec (Bug#9335).
7460
bd1ba3e8
CY
74612011-08-20 Chong Yidong <cyd@stupidchicken.com>
7462
7463 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7464 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7465
54a1215b
EZ
74662011-08-19 Eli Zaretskii <eliz@gnu.org>
7467
823564e5
EZ
7468 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7469 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7470 from an Org mode buffer to a Speedbar frame.
7471
54a1215b
EZ
7472 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7473 a composition, take its buffer position from IT->cmp_it.charpos.
7474 Fixes cursor positioning at the beginning of a line that begins
7475 with a composed character.
7476
9778ebcc
EZ
74772011-08-18 Eli Zaretskii <eliz@gnu.org>
7478
0be6ee06
EZ
7479 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7480 character bidirectional type, use STRONG_L instead. Fixes crashes
7481 in a buffer produced by `describe-categories'.
7482
9778ebcc
EZ
7483 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7484 members before the level stack, so they would be saved and
7485 restored when copying iterator state. Fixes incorrect reordering
7486 around TABs covered by display properties.
7487
156bffbe
AS
74882011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7489
6b02f655 7490 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7491
72ad093b
CY
74922011-08-17 Chong Yidong <cyd@stupidchicken.com>
7493
7494 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7495 (internal_condition_case_2, internal_condition_case_n):
7496 Remove unnecessary aborts (Bug#9081).
72ad093b 7497
35774242
EZ
74982011-08-17 Eli Zaretskii <eliz@gnu.org>
7499
7500 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7501 has no `load' handler, try opening the file locally. (Bug#9311)
7502
db76dd85
KB
75032011-08-16 Ken Brown <kbrown@cornell.edu>
7504
7505 * gmalloc.c: Expand comment.
7506
b215eee5
EZ
75072011-08-16 Eli Zaretskii <eliz@gnu.org>
7508
7509 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7510 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7511
a4579d33
KB
75122011-08-16 Ken Brown <kbrown@cornell.edu>
7513
7514 Fix memory allocation problems in Cygwin build (Bug#9273).
7515
7516 * unexcw.c ( __malloc_initialized): Declare external variable.
7517 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7518
8b76d6f8
SM
7519 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7520 New variables.
a4579d33
KB
7521 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7522 dumped emacs.
7523 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7524 in the static heap.
7525 [CYGWIN] (special_realloc): New function.
7526 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7527 requests to realloc storage in the static heap.
7528
3ebec551
PE
75292011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7530
7531 * bidi.c (bidi_initialize): Remove unused local.
7532
9fd8be00
EZ
75332011-08-15 Eli Zaretskii <eliz@gnu.org>
7534
6b02f655
SM
7535 * bidimirror.h:
7536 * biditype.h: Remove file.
7537 * makefile.w32-in ($(BLD)/bidi.$(O)):
7538 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7539
7540 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7541
7542 * chartab.c: Improve commentary for the uniprop_table API.
7543
32413314
EZ
7544 * bidi.c (bidi_paragraph_init): Support zero value of
7545 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7546 (bidi_initialize): Use uniprop_table instead of including
7547 biditype.h and bidimirror.h.
32413314 7548
9fd8be00
EZ
7549 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7550 coordinates of the iterator when restoring from ppos_it.
7551 (Bug#9296)
7552
5cf2b69b
KH
75532011-08-14 Kenichi Handa <handa@m17n.org>
7554
7555 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7556 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7557
daf17d00
EZ
75582011-08-14 Eli Zaretskii <eliz@gnu.org>
7559
7560 * xdisp.c (move_it_in_display_line_to): Don't invoke
7561 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7562 ppos_it. Fixes vertical cursor motion when line beginning is
7563 covered by an image. (Bug#9296)
7564
08e3161a
JD
75652011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7566
7567 * nsterm.h (ns_run_ascript): Declare.
7568 (NSAPP_DATA2_RUNASSCRIPT): Define.
7569
7570 * nsfns.m (as_script, as_result, as_status): New static variables.
7571 (ns_run_ascript): New function.
5e617bc2 7572 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7573 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7574 the event loop. Get status from as_status (Bug#7276).
7575
7576 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7577 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7578 the event loop (Bug#7276).
7579
a3720aa2
AS
75802011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7581
7582 * gnutls.c (QCgnutls_bootprop_priority)
7583 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7584 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7585 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7586 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7587 (QCgnutls_bootprop_verify_hostname_error)
7588 (QCgnutls_bootprop_callbacks_verify): Rename from
7589 Qgnutls_bootprop_..., all uses changed.
7590
7591 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7592 uses changed.
7593
0a0d27fb
PE
75942011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7595
19d5c50c
PE
7596 * xfaces.c (Qframe_set_background_mode): Now static.
7597 * dispextern.h (Qframe_set_background_mode): Remove decl.
7598
0a0d27fb
PE
7599 * process.c (Fnetwork_interface_info): Declare local only if needed.
7600
377538cb
JD
76012011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7602
7603 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7604 (Fnetwork_interface_list): Allocate in increments of bytes instead
7605 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7606 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7607 sockaddr.
7608 (struct ifflag_def): notrailers is smart on OSX.
7609 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7610 Get hardware address with getifaddrs if available.
7611
08fff70c
EZ
76122011-08-12 Eli Zaretskii <eliz@gnu.org>
7613
7614 * xdisp.c (iterate_out_of_display_property): xassert that
7615 IT->position is set to within IT->object's boundaries. Break from
7616 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7617 when IT->position is set up wrongly due to some bug.
7618 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7619 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7620 entry. Force push_it to save on the stack the current
7621 buffer/string position, to be restored by pop_it. Fix flags in
7622 the iterator structure wrt the object coming from a display
7623 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7624 properties. (Bug#9284)
7625
7be1c708 76262011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7627
7be1c708
CY
7628 * fontset.c (fontset_get_font_group): Add proper type checks.
7629 (Bug#9172)
aac0c6e3 7630
7be1c708 76312011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7632
7be1c708
CY
7633 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7634 and LC_VERSION_MIN_MACOSX.
7635 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7636 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7637
97bb72a6
EZ
76382011-08-08 Eli Zaretskii <eliz@gnu.org>
7639
7640 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7641 no-display-properties-and-no-overlays under bidi display.
7642 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7643 properties and overlays.
97bb72a6 7644
d5617611
CY
76452011-08-08 Chong Yidong <cyd@stupidchicken.com>
7646
37e11a63
CY
7647 * editfns.c (Fset_time_zone_rule): Document relationship with the
7648 setenv function.
7649
d5617611
CY
7650 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7651 the font entity extracted from the cache (Bug#8109).
7652
58872834
CY
76532011-08-07 Chong Yidong <cyd@stupidchicken.com>
7654
7655 * composite.c (autocmp_chars): Don't reset point. That is done by
7656 restore_point_unwind (Bug#5984).
7657
75bfc667
JL
76582011-08-07 Juri Linkov <juri@jurta.org>
7659
7660 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7661 to show the arg `TIME' instead of `TIMEVAL'.
7662
d1410150
EZ
76632011-08-06 Eli Zaretskii <eliz@gnu.org>
7664
7665 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7666 display property strides EOL and includes a newline, as in
7667 longlines-mode. (Bug#9254)
75b771e4
EZ
7668 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7669 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7670
7671 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7672 is non-zero, even if the data buffer is NULL. Fixes a crash in
7673 vertical-motion with longlines-mode. (Bug#9254)
7674
35928349
EZ
76752011-08-05 Eli Zaretskii <eliz@gnu.org>
7676
ec7cc85b
EZ
7677 * bidi.c <bidi_cache_total_alloc>: Now static.
7678 (bidi_initialize): Initialize bidi_cache_total_alloc.
7679
8b76d6f8 7680 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7681 cache. (Bug#9221)
7682
7683 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7684 amount allocated this far in `bidi_cache_total_alloc'.
7685 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7686 non-zero, only free the data buffer without restoring the cache
7687 contents. All callers changed.
7688
7689 * dispextern.h (bidi_unshelve_cache): Update prototype.
7690
7691 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7692 (move_it_in_display_line, move_it_to)
7693 (move_it_vertically_backward, move_it_by_lines): Replace the call
7694 to xfree to an equivalent call to bidi_unshelve_cache.
7695 (move_it_in_display_line_to): Fix logic of returning
412b6358 7696 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7697
e2e2423b
EZ
76982011-08-05 Eli Zaretskii <eliz@gnu.org>
7699
7700 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7701 came from a string character with a `cursor' property. (Bug#9229)
7702
ae9e757a
JD
77032011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7704
7705 * Makefile.in (LIB_PTHREAD): New variable.
7706 (LIBES): Add LIB_PTHREAD (Bug#9216).
7707
7708 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7709 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7710
213bd7f2
AS
77112011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7712
6b02f655 7713 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7714
99aaf75f
JD
77152011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7716
7717 * xterm.c (x_find_topmost_parent): New function.
7718 (x_set_frame_alpha): Find topmost parent window with
7719 x_find_topmost_parent and set the property there also (bug#9181).
7720 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7721
c74e9d86
PE
77222011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7723
7724 * callproc.c (Fcall_process): Avoid vfork clobbering
7725 the local vars buffer, coding_systems, current_dir.
7726
640c8776
SM
77272011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7728
7729 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7730
f26d0e4c
PE
77312011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7732
8a10d76c
PE
7733 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7734 so that it is not optimized away.
7735
f26d0e4c
PE
7736 * xdisp.c (compute_display_string_pos): Remove unused local.
7737
55439c61
EZ
77382011-08-02 Eli Zaretskii <eliz@gnu.org>
7739
7740 Fix slow cursor motion and scrolling in large buffers with
7741 selective display, like Org Mode buffers. (Bug#9218)
7742
7743 * dispextern.h (struct bidi_it): New member disp_prop_p.
7744
7745 * xdisp.c: Remove one-slot cache of display string positions.
7746 (compute_display_string_pos): Accept an additional argument
5e617bc2 7747 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7748 for a display string or property. If found, set DISP_PROP_P
7749 non-zero.
7750
7751 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7752 DISP_PROP_P, and pass it to compute_display_string_pos.
7753 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7754 non-zero. All callers of bidi_fetch_char changed.
7755
fb33fa43
SM
77562011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7757
7758 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7759
b099e063
DM
77602010-12-03 Don March <don@ohspite.net>
7761
7762 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7763 last character M-[char] is translated to ESC [char] (bug#7541).
7764
5cc7f7af
KH
77652011-08-02 Kenichi Handa <handa@m17n.org>
7766
d0fffa3f 7767 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7768
7769 * chartab.c (uniprop_table): Make it non-static.
7770
525d5e6e
EZ
77712011-08-01 Eli Zaretskii <eliz@gnu.org>
7772
7773 * xdisp.c (forward_to_next_line_start): Accept additional argument
7774 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7775 on the newline.
7776 (reseat_at_next_visible_line_start): Use the bidi iterator state
7777 returned by forward_to_next_line_start to restore the state of
7778 it->bidi_it after backing up to previous newline. (Bug#9212)
7779
31011111
AS
77802011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7781
7782 * regex.c (re_comp): Protoize.
7783 (re_exec): Fix return type.
7784 (regexec): Fix type of `ret'. (Bug#9203)
7785
476371c4
PE
77862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7787
e5d76069
PE
7788 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7789 This is needed if max-image-size is a floating-point number.
7790
9a79b20c
AS
77912011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7792
7793 * print.c (print_object): Print empty symbol as ##.
7794
7795 * lread.c (read1): Read ## as empty symbol.
7796
d8c2fa78
AA
77972011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7798
7799 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7800 setting frame foreground color (Bug#9175).
7801 (x_set_background_color): Likewise.
7802
ffe57a7a
AA
7803 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7804 contents (Bug#9176).
7805 (EmacsTooltip -init): Remove bezels and add shadows to
7806 tooltip windows.
7807
bf3492a5
AA
7808 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7809 or scroll bar (Bug#8470).
7810
d55e9c53
AA
7811 * nsfont.m (nsfont_open): Remove assignment to voffset and
7812 unnecessary vars hshink, expand, hd, full_height, min_height.
7813 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7814
7815 * nsterm.h (nsfont_info): Remove voffset field.
7816
d8c2fa78 78172011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7818
7819 Implement strike-through and overline on NextStep (Bug#8863).
7820
7821 * nsfont.m (nsfont_open): Use underline position provided by font,
7822 instead of hard-coded value of 2.
7823 (nsfont_draw): Call ns_draw_text_decoration instead.
7824
7825 * nsterm.h: Add declaration for ns_draw_text_decoration.
7826
7827 * nsterm.m (ns_draw_text_decoration): New function for drawing
7828 underline, overline, and strike-through.
7829 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7830 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7831 accommodate underlining, etc.
4843aac3 7832
4cc60b9b
EZ
78332011-07-28 Eli Zaretskii <eliz@gnu.org>
7834
bc7ece87
EZ
7835 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7836 default.
4cc60b9b 7837
476371c4
PE
78382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7839
66606eea
PE
7840 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7841 Without this fix, if a signal arrives just after memory fills up,
7842 'malloc' might be invoked reentrantly.
7843
476371c4
PE
7844 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7845 In other words, assume that every image size is allowed, on non-X
7846 hosts. This assumption is probably wrong, but it lets Emacs compile.
7847
f3fcc40d
AS
78482011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7849
7850 * regex.c (re_iswctype): Convert return values to boolean.
7851
350c992f
EZ
78522011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7853
7854 * xdisp.c (compute_display_string_pos): Don't use cached display
7855 string position if the buffer had its restriction changed.
7856 (Bug#9184)
7857
5266b4bb
PE
78582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7859
7860 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7861
2573a837 78622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7863
41f55ccd 7864 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7865
39e378da
PE
7866 * bidi.c: Integer size and overflow fixes.
7867 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7868 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7869 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7870 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7871 (bidi_find_other_level_edge):
7872 Use ptrdiff_t instead of EMACS_INT where either will do.
7873 This works better on 32-bit hosts configured --with-wide-int.
7874 (bidi_cache_ensure_space): Check for size-calculation overflow.
7875 Use % rather than repeated addition, for better worst-case speed.
7876 Don't set bidi_cache_size until after xrealloc returns, because it
7877 might not return.
7878 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7879 (bidi_cache_ensure_space): Also check that the bidi cache size
7880 does not exceed that of the largest Lisp string or buffer. See Eli
7881 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7882
5e927815
PE
7883 * alloc.c (__malloc_size_t): Remove.
7884 All uses replaced by size_t. See Andreas Schwab's note
7885 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7886
ca4aa935
PE
7887 * image.c: Improve checking for integer overflow.
7888 (check_image_size): Assume that f is nonnull, since
7889 it is always nonnull in practice. This is one less thing to
7890 worry about when checking for integer overflow later.
7891 (x_check_image_size): New function, which checks for integer
7892 overflow issues inside X.
7893 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7894 This removes the need for a memory_full check.
7895 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7896 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7897 (xbm_read_bitmap_data): Change locals back to 'int', since
7898 their values must fit in 'int'.
7899 (xpm_load_image, png_load, tiff_load):
7900 Invoke x_create_x_image_and_pixmap earlier,
7901 to avoid much needless work if the image is too large.
7902 (tiff_load): Treat overly large images as if
7903 x_create_x_image_and_pixmap failed, not as malloc failures.
7904 (gs_load): Use x_check_image_size.
7905
5f8f9cc2
PE
7906 * gtkutil.c: Omit integer casts.
7907 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7908 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7909
5adf60bc
PE
7910 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7911
c8907a93
PE
7912 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7913 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7914 would wrongly return t on a 64-bit host.
7915
e3c25c68
PE
7916 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7917 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7918 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7919 and therefore cause GCC to emit a bogus diagnostic in some cases.
7920
3f791afe
PE
7921 * image.c: Integer signedness and overflow and related fixes.
7922 This is not an exhaustive set of fixes, but it's time to
7923 record what I've got.
7924 (lookup_pixel_color, check_image_size): Remove redundant decls.
7925 (check_image_size): Don't assume that arbitrary EMACS_INT values
7926 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7927 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7928 (tiff_load, imagemagick_load_image):
7929 Check for overflow in size calculations.
7930 (x_create_x_image_and_pixmap): Remove unnecessary test for
7931 xmalloc returning NULL; that can't happen.
7932 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7933 (xpm_color_bucket): Use better integer hashing function.
7934 (xpm_cache_color): Don't possibly over-allocate memory.
7935 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7936 (gif_memory_source):
7937 Use ptrdiff_t, not int or size_t, to record sizes.
7938 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7939 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7940 either works, as we prefer signed integers.
7941 (tiff_read_from_memory, tiff_write_from_memory):
7942 Return tsize_t, not size_t, since that's what the TIFF API wants.
7943 (tiff_read_from_memory): Don't fail simply because the read would
7944 go past EOF; instead, return a short read.
7945 (tiff_load): Omit no-longer-needed casts.
7946 (Fimagemagick_types): Don't assume size fits into 'int'.
7947
3cc5a532
PE
7948 Improve hashing quality when configured --with-wide-int.
7949 * fns.c (hash_string): New function, taken from sxhash_string.
7950 Do not discard information about ASCII character case; this
7951 discarding is no longer needed.
7952 (sxhash-string): Use it. Change sig to match it. Caller changed.
7953 * lisp.h: Declare it.
7954 * lread.c (hash_string): Remove, since we now use fns.c's version.
7955 The fns.c version returns a wider integer if --with-wide-int is
7956 specified, so this should help the quality of the hashing a bit.
7957
b312a492
PE
7958 * emacs.c: Integer overflow minor fix.
7959 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7960 Define only if GNU_LINUX.
7961 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7962
dfd153ae
PE
7963 * dispnew.c: Integer signedness and overflow fixes.
7964 Remove unnecessary forward decls, that were a maintenance hassle.
7965 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7966 All uses changed.
7967 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7968 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7969 (prepare_desired_row, line_draw_cost):
7970 Use int, not unsigned, where either works.
7971 (save_current_matrix, restore_current_matrix):
7972 Use ptrdiff_t, not size_t, where either works.
7973 (init_display): Check for overflow more accurately, and without
7974 relying on undefined behavior.
7975
a81d11a3
PE
7976 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7977 Remove, replacing with the new symbols in lisp.h. All uses changed.
7978 * fileio.c (make_temp_name):
7979 * filelock.c (lock_file_1, lock_file):
7980 * xdisp.c (message_dolog):
7981 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7982 Use pMd etc. instead.
7983 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7984 replacing the pWIDE etc. symbols removed from editfns.c.
7985
3300e6fd
PE
7986 * keyboard.h (num_input_events): Now uintmax_t.
7987 This is (very slightly) less likely to mess up due to wraparound.
7988 All uses changed.
7989
fd05c7e9
PE
7990 * buffer.c: Integer signedness fixes.
7991 (alloc_buffer_text, enlarge_buffer_text):
7992 Use ptrdiff_t rather than size_t when either will do, as we prefer
7993 signed integers.
7994
903fe15d
PE
7995 * alloc.c: Integer signedness and overflow fixes.
7996 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7997 (__malloc_size_t): Default to size_t, not to int.
7998 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7999 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8000 Prefer ptrdiff_t to size_t when either would do, as we prefer
8001 signed integers.
8002 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8003 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8004 Now const. Initialize with values that are in range even if char
8005 is signed.
8006 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8007 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8008 These functions do the right thing with sizes > 2**32.
8009 (check_depth): Now ptrdiff_t, not int.
8010 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8011 Adjust to new way of storing sizes. Check for size overflow bugs
8012 in rest of code.
8013 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8014 slightly wrong anyway, as it missed one instance of
8015 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8016 (refill_memory_reserve): Omit needless cast to size_t.
8017 (mark_object_loop_halt): Mark as externally visible.
8018
ac82cc6a
PE
8019 * xselect.c: Integer signedness and overflow fixes.
8020 (Fx_register_dnd_atom, x_handle_dnd_message):
8021 Use ptrdiff_t, not size_t, since we prefer signed.
8022 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8023 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8024 x_dnd_atoms_size and x_dnd_atoms_length.
8025
c2d1e36d
PE
8026 * doprnt.c: Prefer signed to unsigned when either works.
8027 * eval.c (verror):
8028 * doprnt.c (doprnt):
8029 * lisp.h (doprnt):
8030 * xdisp.c (vmessage):
8031 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8032 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8033 prefer signed arithmetic to avoid comparison confusion.
8034 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8035 but is a bit tricky.
8036
0e926e56
PE
8037 Assume freestanding C89 headers, string.h, stdlib.h.
8038 * data.c, doprnt.c, floatfns.c, print.c:
8039 Include float.h unconditionally.
8040 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8041 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8042 * regex.c: Likewise for stddef.h, string.h.
8043 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8044 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8045 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8046 (STDC_HEADERS): Remove obsolete defines.
8047 * sysdep.c: Include limits.h unconditionally.
8048
9cfdb3ec
PE
8049 Assume support for memcmp, memcpy, memmove, memset.
8050 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8051 * regex.c (memcmp, memcpy):
8052 Remove; we assume C89 now.
8053
8054 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8055 (__malloc_safe_bcopy): Remove; no longer needed.
8056
cf950e6b 8057 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8058 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8059 well either way, and we prefer signed to unsigned.
8060
dbf38e02
LMI
80612011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8062
8063 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8064 closes the connection while we're reading (bug#9182).
8065
d6f0886c 80662011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8067
d6f0886c
JD
8068 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8069 are specified (Bug#9168).
24e0f6b1 8070
2eb1f9e6
PE
80712011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8072
8073 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8074 Found by GCC static checking and --with-wide-int on a 32-bit host.
8075
22381272 80762011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8077
8078 * xdisp.c (compute_display_string_pos): Fix logic of caching
8079 previous display string position. Initialize cached_prev_pos to
8080 -1. Fixes slow-down at the beginning of a buffer.
8081
f25e39b4
EZ
80822011-07-24 Eli Zaretskii <eliz@gnu.org>
8083
8084 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8085 for attrs[LFACE_FONTSET_INDEX].
8086
04c4b52e
PE
80872011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8088
8089 * xml.c (parse_region): Remove unused local
8090 that was recently introduced.
8091
c1734fbd
EZ
80922011-07-23 Eli Zaretskii <eliz@gnu.org>
8093
be18c5a5
EZ
8094 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8095 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8096
c1734fbd
EZ
8097 * xdisp.c (move_it_in_display_line_to): Record the best matching
8098 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8099 exit if none of the characters scanned was an exact match.
8100 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8101 when exact match is impossible due to invisible text, and the
8102 lines are truncated.
8103
a258d627
JD
81042011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8105
8106 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8107 for OSX >= 10.7.
8108
b6d5a689
EZ
81092011-07-22 Eli Zaretskii <eliz@gnu.org>
8110
0f74f785
EZ
8111 Fix a significant slow-down of cursor motion with C-n, C-p,
8112 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8113 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8114 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8115 (next_element_from_buffer): Call compute_stop_pos_backwards to
8116 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8117 base_level_stop.
8118 (reseat): Don't look for prev_stop, as that could mean a very long
8119 run.
8120 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8121 <cached_disp_overlay_modiff>: Cache for last found display string
8122 position.
551918c1 8123 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8124 about the same buffer in the same area of character positions, and
8125 the buffer wasn't changed since the time the display string
8126 position was cached.
551918c1 8127
b2d0c91a
EZ
81282011-07-22 Eli Zaretskii <eliz@gnu.org>
8129
8130 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8131 is an integer, which is important for empty lines. (Bug#9149)
8132
043604ee
CY
81332011-07-22 Chong Yidong <cyd@stupidchicken.com>
8134
8135 * frame.c (Fmodify_frame_parameters): In tty case, update the
8136 default face if necessary (Bug#4238).
8137
da4adb04
CY
81382011-07-21 Chong Yidong <cyd@stupidchicken.com>
8139
8140 * editfns.c (Fstring_to_char): No need to explain what a character
8141 is in the docstring (Bug#6576).
8142
9abd0532
LMI
81432011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8144
8145 * xml.c (parse_region): Make sure we always return a tree.
8146
36881d16
HK
81472011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8148
8149 * xml.c (parse_region): If a document contains only comments,
8150 return that, too.
8151
1e98674d
LMI
81522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8153
8154 * xml.c (make_dom): Return comments, too.
8155
590bd467
PE
81562011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8157
8158 Port to OpenBSD.
8159 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8160 and the surrounding thread.
8161 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8162 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8163 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8164 timer goes off.
8165 * s/openbsd.h (BROKEN_SIGIO): Define.
8166 * unexelf.c (unexec) [__OpenBSD__]:
8167 Don't update the .mdebug section of the Alpha COFF symbol table.
8168
f41628b2
LMI
81692011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8170
8171 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8172 (bug#8460).
8173
b59b67c5
PE
81742011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8175
15e3a074
PE
8176 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8177 This fixes some race conditions on the permissions of any newly
8178 created file.
8179
41bed37d
PE
8180 * alloc.c (valid_pointer_p): Use pipe, not open.
8181 This fixes some permissions issues when debugging.
8182
b59b67c5
PE
8183 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8184 If fchown fails to set both uid and gid, try to set just gid,
8185 as that is sometimes allowed. Adjust the file's mode to eliminate
8186 setuid or setgid bits that are inappropriate if fchown fails.
8187
925a6be7
SM
81882011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8189
8190 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8191 to compare Lisp_Objects.
8192 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8193 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8194 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8195
52968808
AS
81962011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8197
0a6a104b
AS
8198 * lread.c (read_integer): Unread even EOF character.
8199 (read1): Likewise. Properly record start position of symbol.
8200
52968808
AS
8201 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8202 symbol character follows.
8203
9e381cdd
PE
82042011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8205
8206 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8207 This works around a problem with the previous change to Fcopy_file.
8208 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8209 and without this change, GCC might complain about discarding
8210 fchown's return value.
8211
b5641435
JB
82122011-07-16 Juanma Barranquero <lekktu@gmail.com>
8213
8214 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8215
a8031457
PE
82162011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8217
8218 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8219
dd889327
LMI
82202011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8221
750c33f7
LMI
8222 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8223 it's used from the C level.
8224
dd889327
LMI
8225 * process.c: Use the same condition for POLL_FOR_INPUT in both
8226 keyboard.c and process.c (bug#1858).
8227
87e86684
LM
82282011-07-09 Lawrence Mitchell <wence@gmx.li>
8229
8230 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8231 (Fgnutls_boot): Use it.
8232
64348f40
AS
82332011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8234
8235 * doc.c (Fsubstitute_command_keys): Revert last change.
8236
1d698799
LMI
82372011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8238
f863868c
LMI
8239 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8240 quotes the next character, and doesn't affect other longer
8241 sequences (bug#8935).
8242
1d698799
LMI
8243 * lread.c (syms_of_lread): Clarify that is isn't only
8244 `eval-buffer' and `eval-defun' that's affected by
8245 `lexical-binding' (bug#8460).
8246
aa4b6df6
EZ
82472011-07-15 Eli Zaretskii <eliz@gnu.org>
8248
8249 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8250 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8251
5d856da6
PE
82522011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8253
ad6042bb
PE
8254 Fix minor problems found by static checking.
8255 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8256 (elsz): Now a signed constant, not a size_t var. We prefer signed
8257 types to unsigned, to avoid integer comparison confusion. Without
8258 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8259 "cannot optimize loop, the loop counter may overflow", a symptom
8260 of the confusion.
f00bbb22 8261 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8262 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8263
6468f31c
LMI
82642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8265
49080b10
LMI
8266 * search.c (Fre_search_backward): Mention `case-fold-search' in
8267 all the re_search_* functions (bug#8138).
8268
6468f31c
LMI
8269 * keyboard.c (Fopen_dribble_file): Document when the file is
8270 closed (bug#8056).
8271
c965adc5
EZ
82722011-07-14 Eli Zaretskii <eliz@gnu.org>
8273
df9733bf
EZ
8274 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8275 bidi_cache_idx.
8276
0bb23927
EZ
8277 Support bidi reordering of display and overlay strings.
8278 * xdisp.c (compute_display_string_pos)
8279 (compute_display_string_end): Accept additional argument STRING.
8280 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8281 (reseat_to_string): Initialize bidi_it->string.s and
8282 bidi_it->string.schars.
8283 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8284 NULL (avoids a crash in bidi_paragraph_init).
8285 Initialize itb.string.lstring.
0bb23927
EZ
8286 (init_iterator): Call bidi_init_it only of a valid
8287 buffer position was specified. Initialize paragraph_embedding to
8288 L2R.
8289 (reseat_to_string): Initialize the bidi iterator.
8290 (display_string): If we need to ignore text properties of
8291 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8292 original value of -1 will not work with bidi.)
8293 (compute_display_string_pos): First arg is now struct
8294 `text_pos *'; all callers changed. Support display properties on
8295 Lisp strings.
8296 (compute_display_string_end): Support display properties on Lisp
8297 strings.
8298 (init_iterator, reseat_1, reseat_to_string): Initialize the
8299 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8300 when iterating on a string not from display properties).
640c8776
SM
8301 (compute_display_string_pos, compute_display_string_end):
8302 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8303 arrow keys.
8304 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8305 base_level_stop; instead, set base_level_stop to BEGV.
8306 Fixes crashes in vertical-motion.
0bb23927
EZ
8307 (next_element_from_buffer): Improve commentary for when
8308 the iterator is before prev_stop.
8309 (init_iterator): Initialize bidi_p from the default value of
8310 bidi-display-reordering, not from buffer-local value. Use the
8311 buffer-local value only if initializing for buffer iteration.
8312 (handle_invisible_prop): Support invisible properties on strings
8313 that are being bidi-reordered.
8314 (set_iterator_to_next): Support bidi reordering of C strings and
8315 Lisp strings.
8316 (next_element_from_string): Support bidi reordering of Lisp
8317 strings.
8318 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8319 (display_string): Support display of R2L glyph rows.
8320 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8321 (init_iterator): Don't initialize it->bidi_p for strings
8322 here.
8323 (reseat_to_string): Initialize it->bidi_p for strings here.
8324 (next_element_from_string, next_element_from_c_string)
8325 (next_element_from_buffer): Add xassert's for correspondence
8326 between IT's object being iterated and it->bidi_it.string
8327 structure.
8328 (face_before_or_after_it_pos): Support bidi iteration.
8329 (next_element_from_c_string): Handle the case of the first string
8330 character that is not the first one in the visual order.
8331 (get_visually_first_element): New function, refactored from common
8332 parts of next_element_from_buffer, next_element_from_string, and
8333 next_element_from_c_string.
8334 (tool_bar_lines_needed, redisplay_tool_bar)
8335 (display_menu_bar): Force left-to-right direction. Add a FIXME
8336 comment for making that be controlled by a user option.
8337 (push_it, pop_it): Save and restore the state of the
8338 bidi iterator. Save and restore the bidi_p flag.
8339 (pop_it): Iterate out of display property for string iteration as
8340 well.
8341 (iterate_out_of_display_property): Support iteration over strings.
8342 (handle_single_display_spec): Set up it->bidi_it for iteration
8343 over a display string, and call bidi_init_it.
8344 (handle_single_display_spec, next_overlay_string)
8345 (get_overlay_strings_1, push_display_prop): Set up the bidi
8346 iterator for displaying display or overlay strings.
8347 (forward_to_next_line_start): Don't use the shortcut if
8348 bidi-iterating.
8349 (back_to_previous_visible_line_start): If handle_display_prop
8350 pushed the iterator stack, restore the internal state of the bidi
8351 iterator by calling bidi_pop_it same number of times.
8352 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8353 and we are bidi-iterating, don't decrement the iterator position;
8354 instead, set the first_elt flag in the bidi iterator, to produce
8355 the same effect.
8356 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8357 (push_display_prop): xassert that we are iterating a buffer.
8358 (push_it, pop_it): Save and restore paragraph_embedding member.
8359 (handle_single_display_spec, next_overlay_string)
8360 (get_overlay_strings_1, reseat_1, reseat_to_string)
8361 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8362 correctly. Don't assume unibyte strings are not bidi-reordered.
8363 (compute_display_string_pos)
8364 (compute_display_string_end): Fix handling the case of C string.
8365 (push_it, pop_it): Save and restore from_disp_prop_p.
8366 (handle_single_display_spec, push_display_prop): Set the
8367 from_disp_prop_p flag.
8368 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8369 (pop_it): Call iterate_out_of_display_property only if we are
8370 popping after iteration over a string that came from a display
8371 property. Fix a typo in popping stretch info. Add an assertion
8372 for verifying that the iterator position is in sync with the bidi
8373 iterator.
8374 (handle_single_display_spec, get_overlay_strings_1)
8375 (push_display_prop): Fix initialization of paragraph direction for
8376 string when that of the parent object is not yet determined.
8377 (reseat_1): Call bidi_init_it to resync the bidi
8378 iterator with IT's position. (Bug#7616)
8379 (find_row_edges): If ROW->start.pos gives position
8380 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8381 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8382 Reset the from_disp_prop_p flag.
8383 (SAVE_IT, RESTORE_IT): New macros.
8384 (pos_visible_p, face_before_or_after_it_pos)
8385 (back_to_previous_visible_line_start)
8386 (move_it_in_display_line_to, move_it_in_display_line)
8387 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8388 (try_scrolling, redisplay_window, display_line): Use them when
8389 saving a temporary copy of the iterator and restoring it back.
8390 (back_to_previous_visible_line_start, reseat_1)
8391 (init_iterator): Empty the bidi cache "stack".
8392 (move_it_in_display_line_to): If iterator ended up at
8393 EOL, but we never saw any buffer positions smaller than
8394 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8395 motion in bidi-reordered lines.
8396 (move_it_in_display_line_to): Record prev_method and prev_pos
8397 immediately before the call to set_iterator_to_next. Fixes cursor
8398 motion in bidi-reordered lines with stretch glyphs and strings
8399 displayed in margins. (Bug#8133) (Bug#8867)
8400 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8401 TO_CHARPOS.
640c8776
SM
8402 (pos_visible_p): Support positions in bidi-reordered lines.
8403 Save and restore bidi cache.
0bb23927
EZ
8404
8405 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8406 (bidi_paragraph_info): Delete unused struct.
8407 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8408 (bidi_cache_start): New variable.
8409 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8410 to zero.
8411 (bidi_cache_fetch_state, bidi_cache_search)
8412 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8413 (bidi_cache_find, bidi_peek_at_next_level)
8414 (bidi_level_of_next_char, bidi_find_other_level_edge)
8415 (bidi_move_to_visually_next): Compare cache index with
8416 bidi_cache_start rather than with zero.
8417 (bidi_fetch_char): Accept new argument STRING; all callers
8418 changed. Support iteration over a string. Support strings with
8419 display properties. Support unibyte strings. Fix the type of
8420 `len' according to what STRING_CHAR_AND_LENGTH expects.
8421 (bidi_paragraph_init, bidi_resolve_explicit_1)
8422 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8423 (bidi_level_of_next_char, bidi_move_to_visually_next):
8424 Support iteration over a string.
0bb23927
EZ
8425 (bidi_set_sor_type, bidi_resolve_explicit_1)
8426 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8427 can now be zero (for strings); special values 0 and -1 were
8428 changed to -1 and -2, respectively.
8429 (bidi_char_at_pos): New function.
8430 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8431 Call it instead of FETCH_MULTIBYTE_CHAR.
8432 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8433 initialized to valid values.
8434 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8435 values.
8436 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8437 the test for valid cached positions. Fix the logic for looking up
8438 the sentinel state in the cache. GCPRO the Lisp string we are
8439 iterating.
8440 (bidi_push_it, bidi_pop_it): New functions.
8441 (bidi_initialize): Initialize the bidi cache start stack pointer.
8442 (bidi_cache_ensure_space): New function, refactored from part of
8443 bidi_cache_iterator_state. Don't assume the required size is just
8444 one BIDI_CACHE_CHUNK away.
8445 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8446 (bidi_count_bytes, bidi_char_at_pos): New functions.
8447 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8448 always valid if bidi_cache_idx is valid.
8449 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8450 is valid if it's going to be used.
8451 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8452 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8453 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8454 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8455 (bidi_find_other_level_edge, bidi_cache_start_stack):
8456 All variables related to cache indices are now EMACS_INT.
c965adc5 8457
0bb23927
EZ
8458 * dispextern.h (struct bidi_string_data): New structure.
8459 (struct bidi_it): New member `string'. Make flag members be 1-bit
8460 fields, and put them last in the struct.
640c8776
SM
8461 (compute_display_string_pos, compute_display_string_end):
8462 Update prototypes.
0bb23927
EZ
8463 (bidi_push_it, bidi_pop_it): Add prototypes.
8464 (struct iterator_stack_entry): New members bidi_p,
8465 paragraph_embedding, and from_disp_prop_p.
8466 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8467 (bidi_shelve_cache, bidi_unshelve_cache):
8468 Declare prototypes.
0bb23927
EZ
8469
8470 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8471 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8472 and vector-like objects.
8473
8474 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8475 cache around display iteration.
8476
8477 * window.c (Fwindow_end, window_scroll_pixel_based)
8478 (displayed_window_lines, Frecenter): Save and restore the bidi
8479 cache around display iteration.
8480
3bbd2265
LMI
84812011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8482
8483 * editfns.c (Fdelete_region): Clarify the use of the named
8484 parameters (bug#6788).
8485
adc47434
MR
84862011-07-14 Martin Rudalics <rudalics@gmx.at>
8487
8488 * indent.c (Fvertical_motion): Set and restore w->pointm when
8489 saving and restoring the window's buffer (Bug#9006).
8490
837c31f8
LMI
84912011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8492
8493 * editfns.c (Fstring_to_char): Clarify just what is returned
8494 (bug#6576). Text by Eli Zaretskii.
8495
ac389d0c
JB
84962011-07-13 Juanma Barranquero <lekktu@gmail.com>
8497
8498 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8499
0be0ce47
EZ
85002011-07-13 Eli Zaretskii <eliz@gnu.org>
8501
8502 * buffer.c (mmap_find): Fix a typo.
8503
cd18e7e3
JB
85042011-07-13 Johan Bockgård <bojohan@gnu.org>
8505
8506 Fix execution of x selection hooks.
8507 * xselect.c (Qx_lost_selection_functions)
8508 (Qx_sent_selection_functions): New vars.
8509 (syms_of_xselect): DEFSYM them.
8510 (x_handle_selection_request): Pass Qx_sent_selection_functions
8511 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8512 (x_handle_selection_clear,x_clear_frame_selections):
8513 Pass Qx_lost_selection_functions rather than
8514 Vx_lost_selection_functions to Frun_hook_with_args.
8515
47ea7f44
PE
85162011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8517
ac389d0c 8518 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8519 The old code sometimes used this field without initializing it.
8520
47ea7f44
PE
8521 * alloc.c (gc_sweep): Don't read past end of array.
8522 In theory, the old code could also have corrupted Emacs internals,
8523 though it'd be very unlikely.
8524
bc985c87
AS
85252011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8526
8527 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8528 argument. (Bug#4026)
bc985c87 8529
0cf34688
LMI
85302011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8531
b3dadd76
LMI
8532 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8533 key" (bug#4257).
8534
0cf34688
LMI
8535 * window.c (Fset_window_start): Doc fix (bug#4199).
8536 (Fset_window_hscroll): Ditto.
8537
270768cd
PE
85382011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8539
077e3dda 8540 Fix minor new problems caught by GCC 4.6.1.
270768cd 8541 * term.c (init_tty): Remove unused local.
490011a6 8542 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8543 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8544 not used otherwise.
270768cd 8545
b1f58454
CY
85462011-07-12 Chong Yidong <cyd@stupidchicken.com>
8547
8548 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8549
22b9578d
LMI
85502011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8551
6e70ab07
LMI
8552 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8553 are the mini-buffer and the echo area (bug#3320).
8554
22b9578d
LMI
8555 * term.c (init_tty): Remove support for supdup, c10 and perq
8556 terminals, which are no longer supported (bug#1482).
8557
8974cc9f
JB
85582011-07-10 Johan Bockgård <bojohan@gnu.org>
8559
8560 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8561
a560d974
JD
85622011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8563
8564 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8565 for non-popups (Bug#3642).
8566
1dae0f0a
AS
85672011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8568
268c2c36 8569 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8570 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8571 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8572 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8573 * data.c (fmod): Likewise.
8574 * dispnew.c (swap_glyphs_in_rows): Likewise.
8575 * emacs.c (memory_warning_signal): Likewise.
8576 * floatfns.c (float_error): Likewise.
8577 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8578 (otf_open, font_otf_capability, generate_otf_features)
8579 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8580 Likewise.
8581 * image.c (pbm_read_file): Likewise.
8582 * indent.c (string_display_width): Likewise.
8583 * intervals.c (check_for_interval, search_for_interval)
8584 (inc_interval_count, count_intervals, root_interval)
8585 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8586 * lread.c (defalias): Likewise.
268c2c36 8587 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8588 * regex.c (set_image_of_range_1, set_image_of_range)
8589 (regex_grow_registers): Likewise.
8590 * sysdep.c (strerror): Likewise.
8591 * termcap.c (valid_filename_p, tprint, main): Likewise.
8592 * tparam.c (main): Likewise.
8593 * unexhp9k800.c (run_time_remap, save_data_space)
8594 (update_file_ptrs, read_header, write_header, calculate_checksum)
8595 (copy_file, copy_rest, display_header): Likewise.
8596 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8597 Likewise.
8598 * xdisp.c (check_it): Likewise.
8599 * xfaces.c (register_color, unregister_color, unregister_colors):
8600 Likewise.
8601 * xfns.c (print_fontset_result): Likewise.
8602 * xrdb.c (member, fatal, main): Likewise.
8603
99033785
PE
86042011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8605
8606 Fix minor problems found by static checking (Bug#9031).
8607 * chartab.c (char_table_set_range, map_sub_char_table):
8608 Remove unused locals.
8609 (uniprop_table): Now static.
8610 * composite.c (_work_char): Remove unused static var.
8611
9cb2ac56
JB
86122011-07-09 Juanma Barranquero <lekktu@gmail.com>
8613
8614 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8615
f25661f0
JD
86162011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8617
8618 * gtkutil.c (qttip_cb): Remove code without function.
8619
8278c4fe
EZ
86202011-07-09 Eli Zaretskii <eliz@gnu.org>
8621
8622 * w32.c (pthread_sigmask): New stub.
8623
1692ae2d 86242011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8625
8a6ebd58 8626 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8627 sigprocmask is portable only for single-threaded applications, and
8628 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8629 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8630 (LIBES): Use it.
8631 * callproc.c (Fcall_process):
8632 * process.c (create_process):
8633 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8634 Use pthread_sigmask, not sigprocmask.
123403e4 8635
1b854618
JD
86362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8637
8638 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8639 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8640 wrong (Bug#8591).
8641
3fe4b549
JD
86422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8643
0ce7e563
JD
8644 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8645 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8646 (xg_hide_tooltip): Fix comment.
8647
3fe4b549
JD
8648 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8649 in registerServicesMenuSendTypes.
8650 (validRequestorForSendType): Don't check ns_return_types.
8651
8652 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8653 ns_return_type.
8654
5df75e47
JR
86552011-07-08 Jason Rumney <jasonr@gnu.org>
8656
22610910
JR
8657 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8658 SH_SHOW for hidden windows (Bug#5482).
8659
5df75e47
JR
8660 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8661 frame struct members of non-existent frames (Bug#6284).
8662
699c10bd
JD
86632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8664
4393663b
JD
8665 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8666 variable firstTime not needed on OSX >= 10.6.
8667 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8668 >= 10.5. Use setKnobProportion, setDoubleValue.
8669
8670 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8671 (MAC_OS_X_VERSION_10_5): Define if not defined.
8672 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8673 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8674 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8675
8676 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8677 cString and lossyCString on OSX >= 10.4.
4393663b 8678
58179cce 8679 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8680 sizeToFit on OSX >= 10.2.
8681
8682 * nsimage.m (allocInitFromFile): Don't use deprecated method
8683 bestRepresentationForDevice on OSX >= 10.6.
8684
8685 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8686 to avoid warning.
8687
8688 * emacs.c: Declare unexec_init_emacs_zone.
8689
a63e0781
JD
8690 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8691
699c10bd
JD
8692 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8693
8694 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8695 on svcsMenu (Bug#8842).
8696
8697 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8698 ns_return_types.
8699 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8700
8701 * nsterm.m (QUTF8_STRING): Declare.
8702 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8703 (validRequestorForSendType): Return type is (id).
8704 Change indexOfObjectIdenticalTo to indexOfObject.
8705 Check if we have local selection before returning self (Bug#8842).
8706 (writeSelectionToPasteboard): Put local selection into paste board
8707 if we have a local selection (Bug#8842).
8708 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8709
8710 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8711 (ns_get_local_selection): Declare.
8712
54e10184
LMI
87132011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8714
9888ff71
LMI
8715 * keymap.c (describe_map_tree): Don't insert a double newline at
8716 the end of the buffer (bug#1169) and return whether we inserted
8717 something.
8718
54e10184
LMI
8719 * callint.c (Fcall_interactively): Change "reading args" to
8720 "providing args" to try to clarify what it does (bug#1010).
8721
15fa4783
KH
87222011-07-07 Kenichi Handa <handa@m17n.org>
8723
8724 * composite.c (composition_compute_stop_pos): Ignore a static
8725 composition starting before CHARPOS (Bug#8915).
8726
8727 * xdisp.c (handle_composition_prop): Likewise.
8728
a8815b00
EZ
87292011-07-07 Eli Zaretskii <eliz@gnu.org>
8730
8731 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8732 (Bug#9015)
8733
ef7b981d 87342011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8735
8736 * character.h (unicode_category_t): New enum type.
8737
8738 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8739 (Qchar_code_property_table): New variable.
8740 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8741 (UNIPROP_COMPRESSED_FORM_P): New macros.
8742 (char_table_ascii): Uncompress the compressed values.
8743 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8744 Uncompress the compressed values.
ac389d0c 8745 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8746 (char_table_ref_and_range): Uncompress the compressed values.
8747 (sub_char_table_set): New arg is_uniprop. Callers changed.
8748 Uncompress the compressed values.
8749 (sub_char_table_set_range): Args changed. Callers changed.
8750 (char_table_set_range): Adjuted for the above change.
8751 (map_sub_char_table): Delete args default_val and parent. Add arg
8752 top. Give decoded values to a Lisp function.
640c8776 8753 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8754 values to a Lisp function. Gcpro more variables.
8755 (uniprop_table_uncompress)
8756 (uniprop_decode_value_run_length): New functions.
8757 (uniprop_decoder, uniprop_decoder_count): New variables.
8758 (uniprop_get_decoder, uniprop_encode_value_character)
8759 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8760 New functions.
8761 (uniprop_encoder, uniprop_encoder_count): New variables.
8762 (uniprop_get_encoder, uniprop_table)
8763 (Funicode_property_table_internal, Fget_unicode_property_internal)
8764 (Fput_unicode_property_internal): New functions.
8765 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8766 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8767 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8768 char-code-property-alist.
8769
640c8776 8770 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8771 Vunicode_category_table.
8772
640c8776 8773 * font.c (font_range): Adjust for the change of
c805dec0
KH
8774 Vunicode_category_table.
8775
76b397fb
DN
87762011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8777
8778 * m/iris4d.h: Remove file, move contents ...
8779 * s/irix6-5.h: ... here.
8780
22b4128e
PE
87812011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8782
8783 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8784 * alloc.c (mark_buffer):
8785 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8786 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8787 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8788 This isn't true in general, and it's particularly not true
8789 if Emacs is configured with --with-wide-int.
8790 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8791 New macros, used in the buffer.c change.
8792
869795d6
JD
87932011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8794
8795 * xsettings.c: Use both GConf and GSettings if both are available.
8796 (store_config_changed_event): Add comment.
8797 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8798 (store_tool_bar_style_changed): New functions.
5e617bc2 8799 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8800 (struct xsettings): Move font inside HAVE_XFT.
8801 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8802 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8803 Move inside HAVE_XFT.
640c8776 8804 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8805 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8806 also.
8807 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8808 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8809 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8810 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8811 (parse_settings): Move check for font inside HAVE_XFT.
8812 (read_settings, apply_xft_settings): Add comment.
8813 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8814 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8815 call store_font_name_changed.
8816 (xft_settings_event): Add comment.
8817 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8818 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8819 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8820 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8821 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8822 (xsettings_get_system_font, xsettings_get_system_normal_font):
8823 Add comment.
869795d6 8824
d8ed26bd
PE
88252011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8826
8827 Random fixes. E.g., (random) never returned negative values.
8828 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8829 subseconds part to the entropy, as that's a bit more random.
8830 Prefer signed to unsigned, since the signedness doesn't matter and
8831 in general we prefer signed. When given a limit, use a
8832 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8833 latter isn't right if USE_2_TAGS_FOR_INTS.
8834 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8835 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8836
cabf1cac
SM
88372011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8838
8839 * textprop.c (text_property_stickiness):
8840 Obey Vtext_property_default_nonsticky.
8841 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8842 * w32fns.c (syms_of_w32fns):
8843 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8844
6e9b2be9
PE
88452011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8846
8847 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8848 This is more efficient than Ffile_directory_p and avoids a minor race.
8849
90186c68
LMI
88502011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8851
7c301272
LMI
8852 * buffer.c (Foverlay_put): Say what the return value is
8853 (bug#7835).
8854
c4f2d8d4
LMI
8855 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8856 is a directory before asking whether to use the file name
8857 (bug#7564).
ad637907
LMI
8858 (barf_or_query_if_file_exists): Make the "File is a directory"
8859 error be more correct.
c4f2d8d4 8860
90186c68
LMI
8861 * fns.c (Frequire): Remove the mention of the .gz files, since
8862 that's installation-specific, but keep the mention of
8863 `get-load-suffixes'.
8864
da64016e
PE
88652011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8866
8867 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8868 Report string overflow if the output is too long.
8869
7d47b580
JB
88702011-07-04 Juanma Barranquero <lekktu@gmail.com>
8871
a555cb87
JB
8872 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8873 (syms_of_gnutls): Remove duplicate DEFSYM for
8874 Qgnutls_bootprop_verify_hostname_error, an error for
8875 Qgnutls_bootprop_verify_error (which is no longer used).
8876
7d47b580
JB
8877 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8878 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8879 Also (re)move comments that are misplaced or no longer relevant.
8880
1e49bfab
LMI
88812011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8882
8883 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8884
1485f4c0
CY
88852011-07-03 Chong Yidong <cyd@stupidchicken.com>
8886
8887 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8888 and background color parameters if they have been changed.
8889
a9ab721e
LMI
88902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8891
8892 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8893
cf7cff57
PE
88942011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8895
2e13213d
PE
8896 * xsettings.c (SYSTEM_FONT): Define only when used.
8897 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8898
cf7cff57
PE
8899 * keymap.c (access_keymap_1): Now static.
8900
7a8e04f7
CY
89012011-07-02 Chong Yidong <cyd@stupidchicken.com>
8902
8903 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8904 leave any prefix arg for the up event (Bug#1586).
8905
61352f62
LMI
89062011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8907
69bb1ef7
LMI
8908 * lread.c (syms_of_lread): Mention single symbols defined by
8909 `defvar' or `defconst' (bug#7154).
8910
61352f62 8911 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8912 (Frequire): Mention get-load-suffixes.
61352f62 8913
28545e04
MR
89142011-07-02 Martin Rudalics <rudalics@gmx.at>
8915
8916 * window.h (window): Remove clone_number slot.
8917 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8918 Remove.
8919 (make_parent_window, make_window, saved_window)
8920 (Fset_window_configuration, save_window_save): Don't deal with
8921 clone numbers.
8922 * buffer.c (Qclone_number): Remove declaration.
8923 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8924
3349e122
SM
89252011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8926
8927 Add multiple inheritance to keymaps.
8928 * keymap.c (Fmake_composed_keymap): New function.
8929 (Fset_keymap_parent): Simplify.
8930 (fix_submap_inheritance): Remove.
8931 (access_keymap_1): New function extracted from access_keymap to handle
8932 embedded parents and handle lists of maps.
8933 (access_keymap): Use it.
8934 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8935 (Fcopy_keymap): Handle embedded parents.
8936 (Fcommand_remapping, define_as_prefix): Simplify.
8937 (Fkey_binding): Simplify.
8938 (syms_of_keymap): Move minibuffer-local-completion-map,
8939 minibuffer-local-filename-completion-map,
8940 minibuffer-local-must-match-map, and
8941 minibuffer-local-filename-must-match-map to Elisp.
8942 (syms_of_keymap): Defsubr make-composed-keymap.
8943 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8944 (parse_menu_item): Trivial simplification.
8945
3279eb87
GM
89462011-07-01 Glenn Morris <rgm@gnu.org>
8947
8948 * Makefile.in (SETTINGS_LIBS): Fix typo.
8949
4550efdf
KI
89502011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8951
8952 * coding.c (Fencode_coding_string): Record the last coding system
8953 used, as the function doc string says (bug#8738).
8954
0949d2b6
JD
89552011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8956
8957 * xsettings.c (store_monospaced_changed): Take new font as arg and
8958 check for change against current_mono_font.
8959 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8960 (emacs_settings_constructor, emacs_settings_get_property)
8961 (emacs_settings_set_property, emacs_settings_class_init)
8962 (emacs_settings_init, gsettings_obj): Remove.
8963 (something_changedCB): New function for HAVE_GSETTINGS.
8964 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8965 with value as argument.
8966 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8967 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8968 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8969 "changed".
8970
8971 * xgselect.c: Add defined (HAVE_GSETTINGS).
8972 (xgselect_initialize): Ditto.
8973
8974 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8975 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8976 xg_select.
8977
bbc6b304
PE
89782011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8979
8980 * eval.c (struct backtrace): Simplify and port the data structure.
8981 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8982 signed bit field, as this assumption is not portable and it makes
8983 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8984 "char debug_on_exit : 1" as this is not portable either; instead,
8985 use the portable "unsigned int debug_on_exit : 1". Remove unused
8986 member evalargs. Remove obsolete comments about cc bombing out.
8987
9851bfc5
JD
89882011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8989
51bb811f 8990 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8991 Let HAVE_GSETTINGS override HAVE_GCONF.
8992 (store_monospaced_changed): New function.
8993 (EMACS_SETTINGS): A new type derived from GObject to handle
8994 GSettings notifications.
8995 (emacs_settings_constructor, emacs_settings_get_property)
8996 (emacs_settings_set_property, emacs_settings_class_init):
8997 New functions.
8998 (gsettings_client, gsettings_obj): New variables.
8999 (GSETTINGS_SCHEMA): New define.
9000 (something_changedCB): Call store_monospaced_changed.
9001 (init_gsettings): New function.
9002 (xsettings_initialize): Call init_gsettings.
9003 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9004 to NULL.
9005
640c8776 9006 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9007 GCONF_CFLAGS/LIBS.
9008
5386012d
MR
90092011-06-29 Martin Rudalics <rudalics@gmx.at>
9010
9011 * window.c (resize_root_window, grow_mini_window)
9012 (shrink_mini_window): Rename Qresize_root_window to
9013 Qwindow_resize_root_window and Qresize_root_window_vertically to
9014 Qwindow_resize_root_window_vertically.
9015
f13e0b08
PE
90162011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9017
9018 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9019
94515237
JB
90202011-06-27 Juanma Barranquero <lekktu@gmail.com>
9021
9022 * makefile.w32-in: Redesign dependencies so they reflect more
9023 clearly which files are directly included by each source file,
9024 and not through other includes.
9025
e43b6e43
MR
90262011-06-27 Martin Rudalics <rudalics@gmx.at>
9027
9028 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9029 (sort_overlays, overlay_strings): When an overlay's clone number
9030 matches the window's clone number process the overlay even if
9031 the overlay's window property doesn't match the current window.
9032
d68443dc
MR
9033 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9034 (Fwindow_hchild): Rename to Fwindow_left_child.
9035 (Fwindow_next): Rename to Fwindow_next_sibling.
9036 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9037 (resize_window_check): Rename to window_resize_check.
9038 (resize_window_apply): Rename to window_resize_apply.
9039 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9040 (Fdelete_other_windows_internal, resize_frame_windows)
9041 (Fsplit_window_internal, Fdelete_window_internal)
9042 (grow_mini_window, shrink_mini_window)
9043 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9044
c7e73be5
JD
90452011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9046
9047 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9048 (emacs_fixed_set_min_size): Remove.
9049 (emacs_fixed_new): Take frame as argument.
9050
9051 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9052 (_EmacsFixedPrivate): Remove minwidth/height.
9053 Add struct frame *f.
9054 (emacs_fixed_init): Initialize priv->f.
9055 (get_parent_class, emacs_fixed_set_min_size): Remove.
9056 (emacs_fixed_new): Set priv->f to argument.
9057 (emacs_fixed_get_preferred_width)
9058 (emacs_fixed_get_preferred_height): Use min_width/height from
9059 frames size_hint to set minimum and natural (Bug#8919).
9060 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9061 and use min_width/height from frames size_hint to set
9062 min_width/height (Bug#8919).
9063
9064 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9065 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9066 Fix indentation.
c7e73be5 9067
cf99dcf8
EZ
90682011-06-26 Eli Zaretskii <eliz@gnu.org>
9069
9070 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9071 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9072 called at ZV.
9073
029529ac
CY
90742011-06-26 Chong Yidong <cyd@stupidchicken.com>
9075
9076 * process.c (wait_reading_process_output): Bypass select if
9077 waiting for a cell while ignoring keyboard input, and input is
9078 pending. Suggested by Jan Djärv (Bug#8869).
9079
7a7ef429
PE
90802011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9081
9082 Use gnulib's dup2 module instead of rolling our own.
9083 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9084
11fdef7d 90852011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9086
9087 * dispnew.c (scrolling_window): Before scrolling, turn off a
9088 mouse-highlight in the window being scrolled.
9089
cd3520a4
JB
90902011-06-24 Juanma Barranquero <lekktu@gmail.com>
9091
9092 Move DEFSYM to lisp.h and use everywhere.
9093
9094 * character.h (DEFSYM): Move declaration...
9095 * lisp.h (DEFSYM): ...here.
9096
9097 * gnutls.c:
9098 * minibuf.c:
9099 * w32menu.c:
9100 * w32proc.c:
9101 * w32select.c: Don't include character.h.
9102
9103 * alloc.c (syms_of_alloc):
9104 * buffer.c (syms_of_buffer):
9105 * bytecode.c (syms_of_bytecode):
9106 * callint.c (syms_of_callint):
9107 * casefiddle.c (syms_of_casefiddle):
9108 * casetab.c (init_casetab_once):
9109 * category.c (init_category_once, syms_of_category):
9110 * ccl.c (syms_of_ccl):
9111 * cmds.c (syms_of_cmds):
9112 * composite.c (syms_of_composite):
9113 * dbusbind.c (syms_of_dbusbind):
9114 * dired.c (syms_of_dired):
9115 * dispnew.c (syms_of_display):
9116 * doc.c (syms_of_doc):
9117 * editfns.c (syms_of_editfns):
9118 * emacs.c (syms_of_emacs):
9119 * eval.c (syms_of_eval):
9120 * fileio.c (syms_of_fileio):
9121 * fns.c (syms_of_fns):
9122 * frame.c (syms_of_frame):
9123 * fringe.c (syms_of_fringe):
9124 * insdel.c (syms_of_insdel):
9125 * keymap.c (syms_of_keymap):
9126 * lread.c (init_obarray, syms_of_lread):
9127 * macros.c (syms_of_macros):
9128 * msdos.c (syms_of_msdos):
9129 * print.c (syms_of_print):
9130 * process.c (syms_of_process):
9131 * search.c (syms_of_search):
9132 * sound.c (syms_of_sound):
9133 * syntax.c (init_syntax_once, syms_of_syntax):
9134 * terminal.c (syms_of_terminal):
9135 * textprop.c (syms_of_textprop):
9136 * undo.c (syms_of_undo):
9137 * w32.c (globals_of_w32):
9138 * window.c (syms_of_window):
9139 * xdisp.c (syms_of_xdisp):
9140 * xfaces.c (syms_of_xfaces):
9141 * xfns.c (syms_of_xfns):
9142 * xmenu.c (syms_of_xmenu):
9143 * xsettings.c (syms_of_xsettings):
9144 * xterm.c (syms_of_xterm): Use DEFSYM.
9145
4228cf16
TZ
91462011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9147
cd3520a4 9148 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9149
7fcccf1e
PE
91502011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9151
7efb4e0e
PE
9152 Integer and buffer overflow fixes (Bug#8873).
9153
ff5844ad
PE
9154 * print.c (printchar, strout): Check for string overflow.
9155 (PRINTPREPARE, printchar, strout):
9156 Don't set size unless allocation succeeds.
9157
90532f02
PE
9158 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9159 for sizes. Check for string overflow more accurately.
9160 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9161
6d84508d
PE
9162 * macros.c: Integer and buffer overflow fixes.
9163 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9164 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9165 Use ptrdiff_t, not int, for sizes.
9166 Don't increment bufsize until after realloc succeeds.
9167 Check for size-calculation overflow.
9168 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9169
437b2cb4
PE
9170 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9171
8b9ac8b4
PE
9172 * lread.c: Integer overflow fixes.
9173 (read_integer): Radix is now EMACS_INT, not int,
9174 to improve quality of diagnostics for out-of-range radices.
9175 Calculate buffer size correctly for out-of-range radices.
9176 (read1): Check for integer overflow in radices, and in
9177 read-circle numbers.
82cb60d3
PE
9178 (read_escape): Avoid int overflow.
9179 (Fload, openp, read_buffer_size, read1)
9180 (substitute_object_recurse, read_vector, read_list, map_obarray):
9181 Use ptrdiff_t, not int, for sizes.
9182 (read1): Use EMACS_INT, not int, for sizes.
20270765 9183 Check for size overflow.
8b9ac8b4 9184
7fcccf1e
PE
9185 * image.c (cache_image): Check for size arithmetic overflow.
9186
bfbbd7e7
PE
9187 * lread.c: Integer overflow issues.
9188 (saved_doc_string_size, saved_doc_string_length)
9189 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9190 Now ptrdiff_t, not int.
9191 (read1): Don't assume doc string length fits in int. Check for
9192 out-of-range doc string lengths.
9193 (read_list): Don't assume file position fits in int.
39019e54 9194 (read_escape): Check for hex character overflow.
bfbbd7e7 9195
4e323265
LL
91962011-06-22 Leo Liu <sdl.web@gmail.com>
9197
9198 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9199 Move to minibuffer.el.
9200
85fece3e
PE
92012011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9202
20b84ce9 9203 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9204 The following patches are for when GLYPH_DEBUG && !XASSERT.
9205 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9206 * dispnew.c (flush_stdout):
9207 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9208 Mark as externally visible.
9209 * dispnew.c (check_window_matrix_pointers): Now static.
9210 * dispnew.c (window_to_frame_vpos):
9211 * xfns.c (unwind_create_frame):
9212 * xterm.c (x_check_font): Remove unused local.
9213 * scroll.c (CHECK_BOUNDS):
9214 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9215 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9216 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9217 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9218 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9219 Now static.
9220 (debug_method_add): Use va_list and vsprintf rather than relying
9221 on undefined behavior with wrong number of arguments.
9222 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9223 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9224 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9225 since we're not interested in debugging glyphs with old libraries.
9226 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9227 GCC 4.6.0's static checking.
9228
0766b489
PE
92292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9230
31fd4b32
PE
9231 Integer overflow and signedness fixes (Bug#8873).
9232 A few related buffer overrun fixes, too.
9233
b79e8648
PE
9234 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9235
0766b489
PE
9236 * dispextern.h (struct face.stipple):
9237 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9238 (x_bitmap_mask, x_allocate_bitmap_record)
9239 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9240 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9241 (x_create_bitmap_from_xpm_data):
9242 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9243 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9244 (.bitmaps_last):
9245 * xfaces.c (load_pixmap):
9246 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9247 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9248 (.bitmaps_last, struct x_output.icon_bitmap):
9249 Use ptrdiff_t, not int, for bitmap indexes.
9250 (x_allocate_bitmap_record): Check for size overflow.
9251 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9252
b081724f
PE
9253 Use ptrdiff_t, not int, for overlay counts.
9254 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9255 * editfns.c (overlays_around, get_pos_property):
9256 * textprop.c (get_char_property_and_overlay):
9257 * xdisp.c (next_overlay_change, note_mouse_highlight):
9258 * xfaces.c (face_at_buffer_position):
21514da7
PE
9259 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9260 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9261 (Fnext_overlay_change, Fprevious_overlay_change)
9262 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9263 Use ptrdiff_t, not int, for sizes.
21514da7 9264 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9265
3de73e5e
PE
9266 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9267
2606c57b
PE
9268 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9269 (x_session_initialize): Do not assume string length fits in int.
9270
aaafe47a
PE
9271 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9272 This is unlikely, but can occur if DPI is outlandish.
9273
2674ddc8 9274 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9275 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9276
28154962
PE
9277 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9278 * xrdb.c (magic_file_p, search_magic_path):
9279 Omit last arg SUFFIX; it was always 0. All callers changed.
9280 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9281
7de51af5
PE
9282 * xfont.c (xfont_match): Avoid need for strlen.
9283
25ed6cc3
PE
9284 * xfns.c: Don't assume strlen fits in int.
9285 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9286
4eab31dd
PE
9287 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9288 not unsigned long, as we prefer signed integers. All callers changed.
9289 Detect integer overflow in repeat count.
9290 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9291 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9292
171e2a58
PE
9293 * termcap.c: Don't assume sizes fit in int and never overflow.
9294 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9295 (gobble_line): Check for size-calculation overflow.
9296
ad39faca 9297 * minibuf.c (Fread_buffer):
6e5bb2dc 9298 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9299 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9300 Don't assume string length fits in int.
9301
52c61c22 9302 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9303 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9304
b5b8c9e5
PE
9305 * font.c: Don't assume string length fits in int.
9306 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9307 Use ptrdiff_t, not int.
ccd6111c
PE
9308 (font_intern_prop): Don't assume string length fits in int.
9309 Don't assume integer property fits in fixnum.
9310 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9311
882f0d81 9312 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9313 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9314 Reformulate so as not to need the command string.
9315 Invoke gzip -cd rather than gunzip, as it's more portable.
9316 (lock_info_type, lock_file_1, lock_file):
9317 Don't assume pid_t and time_t fit in unsigned long.
9318 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9319 (current_lock_owner): Prefer signed type for sizes.
9320 Use memcpy, not strncpy, where memcpy is what is really wanted.
9321 Don't assume (via atoi) that time_t and pid_t fit in int.
9322 Check for time_t and/or pid_t out of range, e.g., via a network share.
9323 Don't alloca where an auto var works fine.
9324
93f4cf88
PE
9325 * fileio.c: Fix some integer overflow issues.
9326 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9327 Don't assume string length fits in int.
9328 (directory_file_name): Don't assume string length fits in long.
9329 (make_temp_name): Don't assume pid fits in int, or that its print
9330 length is less than 20.
9331
f3e92b69
PE
9332 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9333
1bfdaf10
PE
9334 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9335
35016e9a
PE
9336 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9337
3d1e65a1
PE
9338 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9339 We prefer signed integers, even for size calculations.
9340
0b963a93
PE
9341 * emacs.c: Don't assume string length fits in 'int'.
9342 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9343 (main): Don't invoke strlen when not needed.
9344
573f4b54
PE
9345 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9346 (XD_DEBUG_MESSAGE): Don't waste a byte.
9347
989f33ba
PE
9348 * callproc.c (getenv_internal_1, getenv_internal)
9349 (Fgetenv_internal):
965d34eb
PE
9350 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9351
e4d29b33
PE
9352 * lread.c (invalid_syntax): Omit length argument.
9353 All uses changed. This doesn't fix a bug, but it simplifies the
9354 code away from its former Hollerith-constant appearance, and it's
9355 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9356 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9357
eb49b136
PE
9358 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9359 This didn't break anything, but it didn't help either.
9360 It's confusing to put a bogus integer in a place where the actual
9361 value does not matter.
9f62aeb1 9362 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9363 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9364
15375a22
PE
9365 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9366 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9367 implementation.
b61cc01c
PE
9368 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9369 We prefer signed types, and the value cannot exceed the EMACS_INT
9370 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9371 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9372 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9373 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9374
53b2623d
PE
9375 * indent.c (sane_tab_width): New function.
9376 (current_column, scan_for_column, Findent_to, position_indentation)
9377 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9378 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9379
51cab52b 9380 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9381
f2ed8a70
PE
9382 * lisp.h (lint_assume): New macro.
9383 * composite.c (composition_gstring_put_cache):
9384 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9385
abe80cc6
PE
9386 * editfns.c, insdel.c:
9387 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9388
b02c740e
PE
9389 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9390
ebc96716
PE
9391 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9392
b4e50fa0 9393 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9394 Use much-faster test for byte-length change.
311d5d7c 9395 Don't assume string byte-length fits in 'int'.
a4cf38e4 9396 Check that character arg fits in 'int'.
85461888 9397 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9398
c0c1ee9f
PE
9399 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9400
a498d7f4
PE
9401 * fns.c (concat): Catch string overflow earlier.
9402 Do not rely on integer wraparound.
9403
51cab52b
PE
9404 * dispextern.h (struct it.overlay_strings_charpos)
9405 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9406 * xdisp.c (forward_to_next_line_start)
9407 (back_to_previous_visible_line_start)
9408 (reseat_at_next_visible_line_start, next_element_from_buffer):
9409 Don't arbitrarily truncate the value of 'selective' to int.
9410
76031fad
PE
9411 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9412
5eb55db9
PE
9413 * composite.c: Don't truncate sizes to 'int'.
9414 (composition_gstring_p, composition_reseat_it)
9415 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9416 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9417 not EMACS_UINT, for indexes.
5eb55db9 9418
0703a717
PE
9419 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9420
d6202519
PE
9421 * buffer.c: Include <verify.h>.
9422 (struct sortvec.priority, struct sortstr.priority):
8961a454 9423 Now EMACS_INT, not int.
c20998a7 9424 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9425 (struct sortstr.size, record_overlay_string)
9426 (struct sortstrlist.size, struct sortlist.used):
9427 Don't truncate size to int.
9428 (record_overlay_string): Check for size-calculation overflow.
d6202519 9429 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9430
d5a19415
JM
94312011-06-22 Jim Meyering <meyering@redhat.com>
9432
029529ac 9433 Don't leak an XBM-image-sized buffer
d5a19415
JM
9434 * image.c (xbm_load): Free the image buffer after using it.
9435
a9041e6c
PE
94362011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9437
9438 Port to Sun C.
9439 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9440 that Sun C diagnosed.
9441 * fns.c (secure_hash): Fix pointer signedness issue.
9442 * intervals.c (static_offset_intervals): New function.
9443 (offset_intervals): Use it.
9444
7f3f739f
LL
94452011-06-21 Leo Liu <sdl.web@gmail.com>
9446
9447 * deps.mk (fns.o):
9448 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9449 sha512.h.
9450
9451 * fns.c (secure_hash): Rename from crypto_hash_function and change
9452 the first arg to accept symbols.
5b66d427 9453 (Fsecure_hash): New primitive.
7f3f739f
LL
9454 (syms_of_fns): New symbols.
9455
76147d94
DD
94562011-06-20 Deniz Dogan <deniz@dogan.se>
9457
9458 * process.c (Fset_process_buffer): Clarify return value in
9459 docstring.
9460
7d7d0045
CY
94612011-06-18 Chong Yidong <cyd@stupidchicken.com>
9462
9463 * dispnew.c (add_window_display_history): Use BVAR.
9464
9465 * xdisp.c (debug_method_add): Use BVAR.
9466 (check_window_end, dump_glyph_matrix, dump_glyph)
9467 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9468
9469 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9470 Likewise.
9471
9472 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9473 check till after the cache is created in init_frame_faces.
9474
ff2bc410
SM
94752011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9476
9477 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9478
28177add
PE
94792011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9480
dd3482fe
PE
9481 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9482 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9483 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9484
393d71f3 9485 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9486 * fileio.c (Finsert_file_contents):
9487 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9488 Remove the old (too-loose) buffer overflow checks.
9489 They weren't needed, since make_gap checks for buffer overflow.
9490 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9491 The old code merely checked for Emacs fixnum overflow, and relied
9492 on undefined (wraparound) behavior. The new code avoids undefined
9493 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9494
2e6813b0 9495 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9496 Tune. Don't use wider integers than needed. Don't use alloca.
9497 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9498
599a9e4f
PE
9499 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9500
99561444
PE
9501 * insdel.c, lisp.h (buffer_overflow): New function.
9502 (insert_from_buffer_1, replace_range, replace_range_2):
9503 * insdel.c (make_gap_larger):
9504 * editfns.c (Finsert_char):
9505 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9506
28177add
PE
9507 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9508
e69dafad
PE
95092011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9510
4baa020d 9511 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9512
b1c46f02
PE
9513 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9514 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9515
e69dafad
PE
9516 * fileio.c: Don't assume EMACS_INT fits in off_t.
9517 (emacs_lseek): New static function.
9518 (Finsert_file_contents, Fwrite_region): Use it.
9519 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9520
566684ea
PE
9521 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9522
e6966cd6
PE
9523 * fns.c: Don't overflow int when computing a list length.
9524 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9525 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9526 truncation on 64-bit hosts. Check for QUIT every
9527 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9528 faster and is responsive enough.
9529 (Flength): Report an error instead of overflowing an integer.
9530 (Fsafe_length): Return a float if the value is not representable
9531 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9532 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9533 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9534
dd0b0efb
PE
9535 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9536 (header_size, word_size): New constants.
9537 (allocate_vectorlike): Don't check size overflow here.
9538 (allocate_vector): Check it here instead, since this is the only
9539 caller of allocate_vectorlike that could cause overflow.
9540 Check that the new vector's length is representable as a fixnum.
9541
86fe5cfe
PE
9542 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9543 The previous code was bogus. For example, next_almost_prime (32)
9544 returned 39, which is undesirable as it is a multiple of 3; and
9545 next_almost_prime (24) returned 25, which is a multiple of 5 so
9546 why was the code bothering to check for multiples of 7?
9547
80e88859
PE
9548 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9549
4a2f0ad6
PE
9550 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9551
f66c7cf8
PE
9552 Variadic C functions now count arguments with ptrdiff_t.
9553 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9554 Back then I didn't know that the Emacs coding style prefers signed int.
9555 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9556 were being counted with int, which may truncate counts on 64-bit
9557 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9558 * lisp.h (struct Lisp_Subr.function.aMANY)
9559 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9560 Arg counts are now ptrdiff_t, not size_t.
9561 All variadic functions and their callers changed accordingly.
9562 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9563 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9564 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9565 * callint.c (Fcall_interactively): Check arg count for overflow,
9566 to avoid potential buffer overrun. Use signed char, not 'int',
9567 for 'varies' array, so that we needn't bother to check its size
9568 calculation for overflow.
9569 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9570 * eval.c (apply_lambda):
9571 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9572 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9573 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9574
a1759b76
PE
9575 * callint.c (Fcall_interactively): Don't use index var as event count.
9576
d96be9fc
PE
9577 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9578 * mem-limits.h (SIZE): Remove; no longer used.
9579
a690a978 9580 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9581
578c21e6
PE
9582 Remove unnecessary casts.
9583 * xterm.c (x_term_init):
9584 * xfns.c (x_set_border_pixel):
9585 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9586 These aren't needed now that we assume ANSI C.
9587
96f53c6c
PE
9588 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9589 It's more likely to cause problems (due to unsigned overflow)
9590 than to cure them.
9591
83c77d31
PE
9592 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9593
ee2079f1
PE
9594 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9595
6da65536
PE
9596 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9597
7147c4a4
PE
9598 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9599
193e32d9
PE
9600 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9601
e5533da6
PE
9602 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9603
9910e595
PE
9604 GLYPH_CODE_FACE returns EMACS_INT, not int.
9605 * dispextern.h (merge_faces):
9606 * xfaces.c (merge_faces):
01103c44
PE
9607 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9608 Don't assume EMACS_INT fits in int.
9910e595 9609
2638320e
PE
9610 * character.h (CHAR_VALID_P): Remove unused parameter.
9611 * fontset.c, lisp.h, xdisp.c: All uses changed.
9612
045eb8d9
PE
9613 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9614
c1f134b5
PE
9615 * fns.c (concat): Minor tuning based on overflow analysis.
9616 This doesn't fix any bugs. Use int to hold character, instead
9617 of constantly refetching from Emacs object. Use XFASTINT, not
9618 XINT, for value known to be a character. Don't bother comparing
9619 a single byte to 0400, as it's always less.
9620
395fcb93 9621 * floatfns.c (Fexpt):
327eeec8
PE
9622 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9623
abbd3d23
PE
9624 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9625 for characters.
9626
684a03ef
PE
9627 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9628
0fed43f3
PE
9629 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9630 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9631 incorrectly succeed when S was a string, because 4294967386 was
9632 truncated before it was used.
9633
8fd02eb7
PE
9634 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9635 Otherwise, an out-of-range integer could cause undefined behavior
9636 on a 64-bit host.
9637
f8c86b69
PE
9638 * composite.c: Use int, not EMACS_INT, for characters.
9639 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9640 EMACS_INT, for values that are known to be in character range.
9641 This doesn't fix any bugs but is the usual style inside Emacs and
9642 may generate better code on 32-bit machines.
9643
34206dd2
PE
9644 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9645 This is for reasons similar to the recent CHAR_STRING fix.
9646 * charset.c (Fencode_char): Check that character arg is actually
9647 a character. Pass an int to ENCODE_CHAR.
9648 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9649 wider than 'int', as a compile-time check to prevent future regressions
9650 in this area.
9651
c5958d4c 9652 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9653
9654 Make sure a 64-bit char is never passed to CHAR_STRING.
9655 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9656 by silently ignoring the top 32 bits, allowing some values
9657 that were far too large to be valid characters.
9658 * character.h: Include <verify.h>.
9659 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9660 arguments are no wider than unsigned, as a compile-time check
9661 to prevent future regressions in this area.
9662 * data.c (Faset):
01103c44 9663 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9664 (Fsubst_char_in_region):
9665 * fns.c (concat):
9666 * xdisp.c (decode_mode_spec_coding):
9667 Adjust to CHAR_STRING's new requirement.
9668 * editfns.c (Finsert_char, Fsubst_char_in_region):
9669 * fns.c (concat): Check that character args are actually
9670 characters. Without this test, these functions did the wrong
9671 thing with wildly out-of-range values on 64-bit hosts.
9672
d37ca623
PE
9673 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9674 These casts should not be needed on 32-bit hosts, either.
9675 * keyboard.c (read_char):
9676 * lread.c (Fload): Remove casts to unsigned.
9677
ea204efb
PE
9678 * lisp.h (UNSIGNED_CMP): New macro.
9679 This fixes comparison bugs on 64-bit hosts.
9680 (ASCII_CHAR_P): Use it.
9681 * casefiddle.c (casify_object):
01103c44 9682 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9683 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9684 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9685 * dispextern.h (FACE_FROM_ID):
9686 * keyboard.c (read_char): Use UNSIGNED_CMP.
9687
41cb286c
PE
9688 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9689 not to EMACS_INT, to avoid GCC warning.
9690
4a1b9832
PE
9691 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9692
55daad71
PE
9693 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9694 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9695 isn't needed on 32-bit machines.
8f95c75c 9696
01103c44
PE
9697 * buffer.c (Fgenerate_new_buffer_name):
9698 Use EMACS_INT for count, not int.
0ceccced 9699 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9700
9701 * data.c (Qcompiled_function): Now static.
9702
c6f072e7
PE
9703 * window.c (window_body_lines): Now static.
9704
20ce5912
PE
9705 * image.c (gif_load): Rename local to avoid shadowing.
9706
9c4c5f81
PE
9707 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9708 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9709 * alloc.c (make_save_value): Integer argument is now of type
9710 ptrdiff_t, not int.
9711 (mark_object): Use ptrdiff_t, not int.
9712 * lisp.h (pD): New macro.
9713 * print.c (print_object): Use it.
9714
c0c5c8ae
PE
9715 * alloc.c: Use EMACS_INT, not int, to count objects.
9716 (total_conses, total_markers, total_symbols, total_vector_size)
9717 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9718 (total_free_floats, total_floats, total_free_intervals)
9719 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9720 Now EMACS_INT, not int. All uses changed.
9721 (Fgarbage_collect): Compute overall total using a double, so that
9722 integer overflow is less likely to be a problem. Check for overflow
9723 when converting back to an integer.
5a25e253
PE
9724 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9725 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9726 These were 'int' variables that could overflow on 64-bit hosts;
9727 they were never used, so remove them instead of repairing them.
211a0b2a 9728 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9729 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9730 Previously, this ceilinged at INT_MAX, but that doesn't work on
9731 64-bit machines.
e46bb31a 9732 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9733
c78baabf 9734 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9735 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9736 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9737 when a (possibly-narrower) signed value would do just as well.
9738 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9739
c9d624c6
PE
9740 * alloc.c: Catch some string size overflows that we were missing.
9741 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9742 for convenience in STRING_BYTES_MAX.
9743 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9744 The definition here is exact; the one in lisp.h was approximate.
9745 (allocate_string_data): Check for string overflow. This catches
9746 some instances we weren't catching before. Also, it catches
9747 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9748 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9749 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9750
c9d624c6
PE
9751 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9752 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9753 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9754
353032ce
PE
9755 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9756
2bccce07
PE
9757 * alloc.c (Fmake_string): Check for out-of-range init.
9758
0ac30604
SM
97592011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9760
9761 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9762
c195f2de
JD
97632011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9764
9765 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9766 xg_get_default_scrollbar_width.
9767
9768 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9769 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9770 (style_changed_cb): Call update_theme_scrollbar_width and call
9771 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9772 all frames (Bug#8505).
9773 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9774 Call gtk_window_set_resizable if HAVE_GTK3.
9775 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9776 and height if HAVE_GTK3 (Bug#8505).
9777 (scroll_bar_width_for_theme): New variable.
9778 (update_theme_scrollbar_width): New function.
9779 (xg_get_default_scrollbar_width): Move code to
9780 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9781 (xg_initialize): Call update_theme_scrollbar_width.
9782
9783 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9784
9785 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9786
e10ac9f1
MR
97872011-06-12 Martin Rudalics <rudalics@gmx.at>
9788
9789 * frame.c (make_frame): Call other_buffer_safely instead of
9790 other_buffer.
9791
9792 * window.c (temp_output_buffer_show): Call display_buffer with
9793 second argument Vtemp_buffer_show_specifiers and reset latter
9794 immediately after the call.
9795 (Vtemp_buffer_show_specifiers): New variable.
9796 (auto_window_vscroll_p, next_screen_context_lines)
9797 (Vscroll_preserve_screen_position): Remove leading asterisks from
9798 doc-strings.
9799
2d3c217e 98002011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9801
7b7f97e8 9802 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9803 * buffer.c (Qclone_number): Remove for now, as it's unused.
9804 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9805 (record_buffer): Remove unused local.
9806 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9807 (set_frame_buffer_list): Remove; unused.
9808 * frame.h (other_visible_frames): Remove decl.
9809 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9810 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9811 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9812 if HAVE_GPM.
9813 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9814 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9815 Define only if HAVE_GPM.
9816 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9817 (update_hints_inhibit): Remove; never set. All uses removed.
9818 * widgetprv.h (emacsFrameClassRec): Remove decl.
9819 * window.c (delete_deletable_window): Now returns void, since it
9820 wasn't returning anything.
9821 (compare_window_configurations): Remove unused locals.
9822 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9823 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9824 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9825 the same widths as pointers. This follows up on the 2011-05-06 patch.
9826 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9827 * xterm.h: Likewise.
9828 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9829
1384b89e
JB
98302011-06-12 Juanma Barranquero <lekktu@gmail.com>
9831
9832 * makefile.w32-in: Update dependencies.
9833 (LISP_H): Add lib/intprops.h.
9834
1100a63c
CY
98352011-06-11 Chong Yidong <cyd@stupidchicken.com>
9836
9837 * image.c (gif_load): Add animation frame delay to the metadata.
9838 (syms_of_image): Use DEFSYM. New symbol `delay'.
9839
6198ccd0
MR
98402011-06-11 Martin Rudalics <rudalics@gmx.at>
9841
9842 * window.c (delete_deletable_window): Re-add.
9843 (Fset_window_configuration): Rewrite to handle dead buffers and
9844 consequently deletable windows.
9845 (window_tree, Fwindow_tree): Remove. Supply functionality in
9846 window.el.
9847 (compare_window_configurations): Simplify code.
9848
b6e3633c
AS
98492011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9850
1ab0dee5
AS
9851 * image.c (imagemagick_load_image): Fix type mismatch.
9852 (Fimagemagick_types): Likewise.
9853
b6e3633c
AS
9854 * window.h (replace_buffer_in_windows): Declare.
9855
9397e56f
MR
98562011-06-11 Martin Rudalics <rudalics@gmx.at>
9857
9858 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9859 Qclone_number. Remove external declaration of Qdelete_window.
9860 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9861 code.
640c8776
SM
9862 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9863 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9864 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9865 buffer list implementation.
9866 (other_buffer_safely): New function.
9867 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9868 calls to replace_buffer_in_windows and
9869 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9870 if allowed.
9871 (record_buffer): Inhibit quitting and rewrite using quittable
9872 functions. Run Qbuffer_list_update_hook if allowed.
9873 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9874 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9875 Move switch-to-buffer to window.el.
9397e56f
MR
9876 (bury-buffer): Move to window.el.
9877 (Vbuffer_list_update_hook): New variable.
9878
9879 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9880 section.
9881
9882 * window.h (resize_frame_windows): Move up in code.
9883 (Fwindow_frame): Remove EXFUN.
9884 (replace_buffer_in_all_windows): Remove prototype.
9885 (replace_buffer_in_windows_safely): Add prototype.
9886
9887 * window.c: Declare Qdelete_window static again. Move down
9888 declaration of select_count.
9889 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9890 (Fother_window): Move to window.el.
9891 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9892 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9893 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9894 window.el.
9895 (replace_buffer_in_windows): Implement by calling
9896 Qreplace_buffer_in_windows.
9897 (replace_buffer_in_all_windows): Remove with some functionality
9898 moved into replace_buffer_in_windows_safely.
9899 (replace_buffer_in_windows_safely): New function.
9900 (select_window_norecord, select_frame_norecord): Move in front
9901 of run_window_configuration_change_hook. Remove now obsolete
9902 declarations.
640c8776
SM
9903 (Fset_window_buffer): Rewrite doc-string.
9904 Call Qrecord_window_buffer.
9397e56f
MR
9905 (keys_of_window): Move binding for other-window to window.el.
9906
b50691aa
CY
99072011-06-11 Chong Yidong <cyd@stupidchicken.com>
9908
9909 * dispextern.h (struct image): Replace data member, whose int_val
9910 and ptr_val fields were not used by anything, with a single
9911 lisp_val object.
9912
9913 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9914 (gif_clear_image, gif_load, imagemagick_load_image)
9915 (gs_clear_image, gs_load): Callers changed.
9916
3f754b86
PE
99172011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9918
cca69397
PE
9919 * buffer.h: Include <time.h>, for time_t.
9920 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9921
109e28d0
PE
9922 Fix minor problems found by static checking.
9923
60737f02
PE
9924 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9925
4b66faf3
PE
9926 Make identifiers static if they are not used in other modules.
9927 * data.c (Qcompiled_function, Qframe, Qvector):
9928 * image.c (QimageMagick, Qsvg):
9929 * minibuf.c (Qmetadata):
9930 * window.c (resize_window_check, resize_root_window): Now static.
9931 * window.h (resize_window_check, resize_root_window): Remove decls.
9932
109e28d0
PE
9933 * window.c (window_deletion_count, delete_deletable_window):
9934 Remove; unused.
46a4ce9e
PE
9935 (window_body_lines): Now static.
9936 (Fdelete_other_windows_internal): Mark vars as initialized.
9937 Make sure 'resize_failed' is initialized.
9938 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9939 (resize_window_apply): Remove unused local.
9940 * window.h (delete_deletable_window): Remove decl.
9941
109e28d0 9942 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9943 (imagemagick_load_image): Fix pointer signedness problem by changing
9944 last arg from unsigned char * to char *. All uses changed.
9945 Also, fix a local for similar reasons.
9946 Remove unused locals. Remove locals to avoid shadowing.
9947 (fn_rsvg_handle_free): Remove; unused.
9948 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9949 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9950
3f754b86
PE
9951 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9952
2547adb1
CY
99532011-06-10 Chong Yidong <cyd@stupidchicken.com>
9954
9955 * image.c (gif_load): Fix omitted cast error introduced by
9956 2011-06-06 change.
9957
2c8e37d4
MR
99582011-06-10 Martin Rudalics <rudalics@gmx.at>
9959
9960 * window.h (resize_proportionally, orig_total_lines)
9961 (orig_top_line): Remove from window structure.
9962 (set_window_height, set_window_width, change_window_heights)
9963 (Fdelete_window): Remove prototypes.
9964 (resize_frame_windows): Remove duplicate declaration.
9965
440a42e3
EZ
99662011-06-10 Eli Zaretskii <eliz@gnu.org>
9967
9968 * window.h (resize_frame_windows, resize_window_check)
9969 (delete_deletable_window, resize_root_window)
9970 (resize_frame_windows): Declare prototypes.
9971
9972 * window.c (resize_window_apply): Make definition be "static" to
9973 match the prototype.
9974
562dd5e9
MR
99752011-06-10 Martin Rudalics <rudalics@gmx.at>
9976
9977 * window.c: Remove declarations of Qwindow_size_fixed,
9978 window_min_size_1, window_min_size_2, window_min_size,
9979 size_window, window_fixed_size_p, enlarge_window, delete_window.
9980 Remove static from declaration of Qdelete_window, it's
9981 temporarily needed by Fbury_buffer.
9982 (replace_window): Don't assign orig_top_line and
9983 orig_total_lines.
9984 (Fdelete_window, delete_window): Remove. Window deletion is
9985 handled by window.el.
640c8776
SM
9986 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9987 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9988 (Fdelete_other_windows): Remove. Deleting other windows is
9989 handled by window.el.
9990 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9991 handled in window.el.
9992 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9993 Window minimum sizes are handled in window.el.
9994 (shrink_windows, size_window, set_window_height)
9995 (set_window_width, change_window_heights, window_height)
9996 (window_width, CURBEG, CURSIZE, enlarge_window)
9997 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9998 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9999 handled in window.el.
10000 (make_dummy_parent): Rename to make_parent_window and give it a
10001 second argument horflag.
10002 (make_window): Don't set resize_proportionally any more.
10003 (Fsplit_window): Remove. Windows are split in window.el.
10004 (save_restore_action, save_restore_orig_size)
10005 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10006 Resize mini windows in window.el.
10007 (grow_mini_window, shrink_mini_window): Implement by calling
10008 Qresize_root_window_vertically, resize_window_check and
10009 resize_window_apply.
640c8776
SM
10010 (saved_window, Fset_window_configuration, save_window_save):
10011 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10012 resize_proportionally.
10013 (window_min_height, window_min_width): Move to window.el.
10014 (keys_of_window): Move bindings for delete-other-windows,
10015 split-window, delete-window and enlarge-window to window.el.
10016
10017 * buffer.c: Temporarily extern Qdelete_window.
10018 (Fbury_buffer): Temporarily call Qdelete_window instead of
10019 Fdelete_window (Fbury_buffer will move to window.el soon).
10020
10021 * frame.c (set_menu_bar_lines_1): Remove code handling
10022 orig_top_line and orig_total_lines.
10023
10024 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10025 set_window_height but set heights directly.
10026 (change_frame_size_1): Use resize_frame_windows.
10027
10028 * xdisp.c (init_xdisp): Don't use set_window_height but set
10029 heights directly.
10030
640c8776
SM
10031 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10032 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10033 run_window_configuration_change_hook.
10034
10035 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10036 instead of change_window_heights and run
10037 run_window_configuration_change_hook.
10038
1a13852e
MR
100392011-06-09 Martin Rudalics <rudalics@gmx.at>
10040
10041 * window.c (replace_window): Rename second argument REPLACEMENT to
10042 NEW. New third argument SETFLAG. Rewrite.
10043 (delete_window, make_dummy_parent): Call replace_window with
10044 third argument 1.
10045 (window_list_1): Move down in code.
10046 (run_window_configuration_change_hook): Move set_buffer part
10047 before select_frame_norecord part in order to unwind correctly.
10048 Rename count1 to count.
10049 (recombine_windows, delete_deletable_window, resize_root_window)
10050 (Fdelete_other_windows_internal)
10051 (Frun_window_configuration_change_hook, make_parent_window)
10052 (resize_window_check, resize_window_apply, Fresize_window_apply)
10053 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10054 (Fdelete_window_internal, Fresize_mini_window_internal):
10055 New functions.
1a13852e
MR
10056 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10057
f3d1777e
MR
100582011-06-08 Martin Rudalics <rudalics@gmx.at>
10059
496e208e
MR
10060 * window.h (window): Add some new members to window structure -
10061 normal_lines, normal_cols, new_total, new_normal, clone_number,
10062 splits, nest, prev_buffers, next_buffers.
10063 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10064 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10065
f3d1777e
MR
10066 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10067 Remove.
496e208e
MR
10068 (make_dummy_parent): Set new members of windows structure.
10069 (make_window): Move down in code. Handle new members of window
10070 structure.
10071 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10072 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10073 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10074 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10075 (Fset_window_next_buffers, Fset_window_clone_number):
10076 New functions.
496e208e
MR
10077 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10078 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10079 Doc-string fixes.
10080 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10081 Argument WINDOW can be now internal window too.
10082 (Fwindow_use_time): Move up in code.
10083 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10084 Rewrite doc-string.
10085 (Fset_window_configuration, saved_window)
10086 (Fcurrent_window_configuration, save_window_save): Handle new
10087 members of window structure.
b9e809c2
MR
10088 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10089 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10090 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10091 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10092 Qget_mru_window, Qresize_root_window,
10093 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10094 Qauto_buffer_name; staticpro them.
f3d1777e 10095
abde8f8c
MR
100962011-06-07 Martin Rudalics <rudalics@gmx.at>
10097
10098 * window.c (Fwindow_total_size, Fwindow_left_column)
10099 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10100 (Fwindow_list_1): New functions.
10101 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10102 (Fwindow_width, Fscroll_left, Fscroll_right):
10103 Use window_body_cols instead of window_box_text_cols.
10104 (delete_window, Fset_window_configuration):
10105 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10106 (delete_all_subwindows): Take a window as argument and not a
10107 structure. Rewrite.
190b47e6
MR
10108 (window_loop): Remove handling of GET_LRU_WINDOW and
10109 GET_LARGEST_WINDOW.
10110 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10111
10112 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10113 window_box_text_cols. delete_all_subwindows now takes a
10114 Lisp_Object as argument.
abde8f8c 10115
640c8776
SM
10116 * indent.c (compute_motion, Fcompute_motion):
10117 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10118
fa8a67e6
MR
10119 * frame.c (delete_frame): Call delete_all_subwindows with root
10120 window as argument.
10121
a54e3482
DC
101222011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10123
10124 * fns.c (Fputhash): Document return value.
10125
60002bf5
CY
101262011-06-06 Chong Yidong <cyd@stupidchicken.com>
10127
10128 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10129
0c671da6 101302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10131
b862a52a 10132 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10133
be44ca6c
PE
10134 Check for overflow when converting integer to cons and back.
10135 * charset.c (Fdefine_charset_internal, Fdecode_char):
10136 Use cons_to_unsigned to catch overflow.
10137 (Fencode_char): Use INTEGER_TO_CONS.
10138 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10139 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10140 * data.c (long_to_cons, cons_to_long): Remove.
10141 (cons_to_unsigned, cons_to_signed): New functions.
10142 These signal an error for invalid or out-of-range values.
10143 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10144 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10145 * font.c (Ffont_variation_glyphs):
10146 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10147 * lisp.h: Include <intprops.h>.
10148 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10149 (cons_to_signed, cons_to_unsigned): New decls.
10150 (long_to_cons, cons_to_long): Remove decls.
10151 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10152 (Fprimitive_undo): Use CONS_TO_INTEGER.
10153 * xfns.c (Fx_window_property): Likewise.
10154 * xselect.c: Include <limits.h>.
10155 (x_own_selection, selection_data_to_lisp_data):
10156 Use INTEGER_TO_CONS.
10157 (x_handle_selection_request, x_handle_selection_clear)
10158 (x_get_foreign_selection, Fx_disown_selection_internal)
10159 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10160 (lisp_data_to_selection_data): Use cons_to_unsigned.
10161 (x_fill_property_data): Use cons_to_signed.
10162 Report values out of range.
10163
d1f3d2af
PE
10164 Check for buffer and string overflow more precisely.
10165 * buffer.h (BUF_BYTES_MAX): New macro.
10166 * lisp.h (STRING_BYTES_MAX): New macro.
10167 * alloc.c (Fmake_string):
10168 * character.c (string_escape_byte8):
10169 * coding.c (coding_alloc_by_realloc):
10170 * doprnt.c (doprnt):
10171 * editfns.c (Fformat):
10172 * eval.c (verror):
10173 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10174 since they may not be the same number.
10175 * editfns.c (Finsert_char):
10176 * fileio.c (Finsert_file_contents):
10177 Likewise for BUF_BYTES_MAX.
10178
dd52fcea
PE
10179 * image.c: Use ptrdiff_t, not int, for sizes.
10180 (slurp_file): Switch from int to ptrdiff_t.
10181 All uses changed.
10182 (slurp_file): Check that file size fits in both size_t (for
10183 malloc) and ptrdiff_t (for sanity and safety).
10184
7f9bbdbb
PE
10185 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10186 if b->modtime has its maximal value.
10187
dfe18f82
PE
10188 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10189
84acfcf0
PE
10190 Don't assume time_t can fit into int.
10191 * buffer.h (struct buffer.modtime): Now time_t, not int.
10192 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10193 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10194
ccd9a01a
PE
10195 Minor fixes for signed vs unsigned integers.
10196 * character.h (MAYBE_UNIFY_CHAR):
10197 * charset.c (maybe_unify_char):
10198 * keyboard.c (read_char, reorder_modifiers):
10199 XINT -> XFASTINT, since the integer must be nonnegative.
10200 * ftfont.c (ftfont_spec_pattern):
10201 * keymap.c (access_keymap, silly_event_symbol_error):
10202 XUINT -> XFASTINT, since the integer must be nonnegative.
10203 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10204 since it makes no difference and we prefer signed.
10205 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10206 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10207 nonnegative.
10208
d6d100dd
SM
102092011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10210
10211 * window.h (Fwindow_frame): Declare.
10212
2b6148e4
PE
102132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10214
10215 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10216 (SPARE_MEMORY): Always define.
10217 (LARGE_REQUEST): Remove.
10218 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10219
f230ecc9
MR
102202011-06-06 Martin Rudalics <rudalics@gmx.at>
10221
727e958e
MR
10222 * lisp.h: Move EXFUNS for Fframe_root_window,
10223 Fframe_first_window and Fset_frame_selected_window to window.h.
10224
10225 * window.h: Move EXFUNS for Fframe_root_window,
10226 Fframe_first_window and Fset_frame_selected_window here from
10227 lisp.h.
10228
10229 * frame.c (Fwindow_frame, Fframe_first_window)
10230 (Fframe_root_window, Fframe_selected_window)
10231 (Fset_frame_selected_window): Move to window.c.
10232 (Factive_minibuffer_window): Move to minibuf.c.
10233 (Fother_visible_frames_p): New function.
10234
10235 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10236
f230ecc9
MR
10237 * window.c (decode_window, decode_any_window): Move up in code.
10238 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10239 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10240 (Fwindow_buffer): Move up and rewrite doc-string.
10241 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10242 (Fwindow_prev): New functions.
727e958e
MR
10243 (Fwindow_frame): Move here from frame.c. Accept any window as
10244 argument.
10245 (Fframe_root_window, Fframe_first_window)
10246 (Fframe_selected_window): Move here from frame.c. Accept frame
10247 or arbitrary window as argument. Update doc-strings.
10248 (Fminibuffer_window): Move up in code.
10249 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10250 (Fset_frame_selected_window): Move here from frame.c.
10251 Marginal rewrite.
727e958e
MR
10252 (Fselected_window, select_window, Fselect_window): Move up in
10253 code. Minor doc-string fixes.
f230ecc9 10254
4d09bcf6
PE
102552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10256
10257 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10258 Do not assume that spare memory exists; that assumption is valid
10259 only if SYSTEM_MALLOC.
10260 (LARGE_REQUEST): New macro, so that the issue of large requests
10261 is separated from the issue of spare memory.
10262
810928a2
AS
102632011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10264
172418ad
AS
10265 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10266 format. (Bug#8806)
10267
43f862f7
AS
10268 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10269
810928a2
AS
10270 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10271 before statements.
10272
a059fe24
JD
102732011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10274
10275 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10276
10277 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10278
10279 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10280 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10281
989bf368
JB
102822011-06-05 Juanma Barranquero <lekktu@gmail.com>
10283
10284 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10285
4b80f674
CY
102862011-06-04 Chong Yidong <cyd@stupidchicken.com>
10287
10288 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10289 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10290 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10291 New error handlers.
4b80f674
CY
10292 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10293 Obey Vx_select_enable_clipboard_manager. Catch errors in
10294 x_clipboard_manager_save (Bug#8779).
10295 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10296 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10297
99a33b77 102982011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10299
10300 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10301
99a33b77 103022011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10303
10304 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10305 in the current matrix if keep_current_p is non-zero.
10306
8264569d
EZ
103072011-06-04 Eli Zaretskii <eliz@gnu.org>
10308
10309 * bidi.c (bidi_level_of_next_char): Fix last change.
10310
57f97249
EZ
103112011-06-03 Eli Zaretskii <eliz@gnu.org>
10312
fec2107c 10313 Support bidi reordering of text covered by display properties.
57f97249 10314
fec2107c
EZ
10315 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10316 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10317 (bidi_cache_search, bidi_cache_iterator_state)
10318 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10319 (bidi_level_of_next_char, bidi_move_to_visually_next):
10320 Support character positions inside a run of characters covered by a
fec2107c
EZ
10321 display string.
10322 (bidi_paragraph_init, bidi_resolve_explicit_1)
10323 (bidi_level_of_next_char): Call bidi_fetch_char and
10324 bidi_fetch_char_advance instead of FETCH_CHAR and
10325 FETCH_CHAR_ADVANCE.
10326 (bidi_init_it): Initialize new members.
10327 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10328 definitions.
10329 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10330 instead of using explicit *_CHAR codes.
d6d100dd
SM
10331 (bidi_resolve_explicit, bidi_resolve_weak):
10332 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10333 bidirectional text is supported only in multibyte buffers.
10334 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10335 it to initialize the frame_window_p member of struct bidi_it.
10336 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10337 (bidi_resolve_explicit, bidi_resolve_weak)
10338 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10339 bidi_it->nchars is non-positive.
10340 (bidi_level_of_next_char): Don't try to lookup the cache for the
10341 next/previous character if nothing is cached there yet, or if we
10342 were just reseat()'ed to a new position.
c40e2fb2 10343
0e14fe90
EZ
10344 * xdisp.c (set_cursor_from_row): Set start and stop points
10345 according to the row's direction when priming the loop that looks
10346 for the glyph on which to display cursor.
10347 (single_display_spec_intangible_p): Function deleted.
10348 (display_prop_intangible_p): Reimplement to call
10349 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10350 Accept 3 additional arguments needed by handle_display_spec.
10351 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10352 values: lists, `(when COND...)' forms, etc.
10353 (single_display_spec_string_p): Support property values that are
10354 lists with the argument STRING its top-level element.
10355 (display_prop_string_p): Fix the condition for processing a
10356 property that is a list to be consistent with handle_display_spec.
fec2107c 10357 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10358 last portion of handle_display_prop.
10359 (compute_display_string_pos): Accept additional argument
10360 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10361 value of a `display' property is a "replacing spec".
10362 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10363 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10364 the display property, but just return a value indicating whether
10365 the display property will replace the characters it covers.
10366 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10367 frame_window_p members of struct bidi_it.
d6d100dd
SM
10368 (compute_display_string_pos, compute_display_string_end):
10369 New functions.
fec2107c
EZ
10370 (push_it): Accept second argument POSITION, where pop_it should
10371 jump to continue iteration.
10372 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10373
fec2107c
EZ
10374 * keyboard.c (adjust_point_for_property): Adjust the call to
10375 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10376
10377 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10378 (bidi_init_it): Update prototypes.
10379 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10380 (compute_display_string_pos, compute_display_string_end):
10381 Declare prototypes.
fec2107c
EZ
10382 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10383 EMACS_INT.
fc6f18ce 10384
40087514 103852011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10386
57f53182
PE
10387 Malloc failure behavior now depends on size of allocation.
10388 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10389 * lisp.h: Change signatures accordingly.
10390 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10391 All callers changed. (Bug#8762)
10392
10393 * gnutls.c: Use Emacs's memory allocators.
10394 Without this change, the gnutls library would invoke malloc etc.
10395 directly, which causes problems on non-SYNC_INPUT hosts, and which
10396 runs afoul of improving memory_full behavior. (Bug#8761)
10397 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10398 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10399 xfree instead of the default malloc, realloc, free.
10400 (Fgnutls_boot): No need to check for memory allocation failure,
10401 since xmalloc does that for us.
10402
ac32cd99 10403 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10404 * category.c (hash_get_category_set):
10405 * ccl.c (ccl_driver):
10406 * charset.c (Fdefine_charset_internal):
10407 * charset.h (struct charset.hash_index):
10408 * composite.c (get_composition_id, gstring_lookup_cache)
10409 (composition_gstring_put_cache):
10410 * composite.h (struct composition.hash_index):
10411 * dispextern.h (struct image.hash):
10412 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10413 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10414 (hashfn_equal, hashfn_user_defined, make_hash_table)
10415 (maybe_resize_hash_table, hash_lookup, hash_put)
10416 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10417 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10418 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10419 * image.c (make_image, search_image_cache, lookup_image)
10420 (xpm_put_color_table_h):
10421 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10422 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10423 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10424 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10425 * alloc.c (allocate_vectorlike):
10426 Check for overflow in vector size calculations.
10427 * ccl.c (ccl_driver):
10428 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10429 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10430 need to be updated by these changes.
40087514
PE
10431 * fns.c (make_hash_table, maybe_resize_hash_table):
10432 Check for integer overflow with large hash tables.
0de4bb68
PE
10433 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10434 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10435 (SXHASH_REDUCE): New macro.
10436 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10437 Use it instead of discarding useful hash info with large hash values.
10438 (sxhash_float): New function.
10439 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10440 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10441 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10442 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10443 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10444 Adjust signatures to match updated version of code.
10445 (consing_since_gc): Now EMACS_INT, since a single hash table can
10446 use more than INT_MAX bytes.
10447
698d32e2
DN
104482011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10449
10450 Make it possible to build with GCC-4.6+ -O2 -flto.
10451
10452 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10453
fd6fa53f
SM
104542011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10455
10456 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10457 Call minibuffer-inactive-mode.
10458
864db017
JB
104592011-05-31 Juanma Barranquero <lekktu@gmail.com>
10460
10461 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10462 Update dependencies.
10463
2ad0baf4
DN
104642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10465
10466 * data.c (init_data): Remove code for UTS, this system is not
10467 supported anymore.
10468
4fcc2638
DN
104692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10470
10471 Don't force ./temacs to start in terminal mode.
10472
10473 * frame.c (make_initial_frame): Initialize faces in all cases, not
10474 only when CANNOT_DUMP is defined.
10475 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10476
c56e0fd5
DN
104772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10478
10479 * dispnew.c (add_window_display_history): Use const for the string
10480 pointer. Remove declaration, not needed.
10481
333d54da 104822011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10483
55d4c1b2 10484 Use 'inline', not 'INLINE'.
333d54da 10485 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10486 * alloc.c, fontset.c (INLINE): Remove.
10487 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10488 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10489 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10490 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10491 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10492
738db178
DN
104932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10494
10495 Make it possible to run ./temacs.
10496
10497 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10498 syms_of_callproc does the same thing. Remove test for
10499 "initialized", do it in the caller.
10500 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10501
620c53a6
SM
105022011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10503
10504 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10505 (read_minibuf): Use get_minibuffer.
10506 (syms_of_minibuf): Use DEFSYM.
10507 (Qmetadata): New var.
10508 * data.c (Qbuffer): Don't make it static.
10509 (syms_of_data): Use DEFSYM.
10510
e003a292
PE
105112011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10512
10513 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10514 (CCL_CODE_MIN): New macro.
10515
ed008a6d
PE
105162011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10517
3687c2ef
PE
10518 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10519
ed008a6d
PE
10520 * eval.c (Qdebug): Now static.
10521 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10522 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10523 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10524
d66c4c7c
CY
105252011-05-29 Chong Yidong <cyd@stupidchicken.com>
10526
10527 * image.c: Various fixes to ImageMagick code comments.
10528 (Fimagemagick_types): Doc fix.
10529
5fbc2025
PE
105302011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10531
0196f88a
PE
10532 Minor fixes prompted by GCC 4.6.0 warnings.
10533
10534 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10535
5fbc2025
PE
10536 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10537 (x_clipboard_manager_save_all): Move extern decl to ...
10538 * xterm.h: ... here, so that it can be checked for consistency.
10539
1dd3c2d9
CY
105402011-05-29 Chong Yidong <cyd@stupidchicken.com>
10541
10542 * xselect.c (x_clipboard_manager_save_frame)
10543 (x_clipboard_manager_save_all): New functions.
10544 (Fx_clipboard_manager_save): Lisp function deleted.
10545
10546 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10547 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10548
10549 * xterm.h: Update prototype.
10550
5ba6571d
WX
105512011-05-28 William Xu <william.xwl@gmail.com>
10552
10553 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10554 exiting (Bug#8239).
10555
3eaff834
JM
105562011-05-28 Jim Meyering <meyering@redhat.com>
10557
e1900994 10558 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10559 * fns.c (to_uchar): Define.
10560 (crypto_hash_function): Use it to convert some newly-signed
10561 variables to unsigned, to avoid sign-extension bugs. For example,
10562 without this change, (md5 "truc") would evaluate to
10563 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10564 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10565 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10566
0f6990a7
PE
105672011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10568
10569 Integer overflow fixes.
c8a9ca5a 10570
08686060
PE
10571 * dbusbind.c: Serial number integer overflow fixes.
10572 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10573 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10574 to hold a serial number that is too large for a fixnum.
10575 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10576 Check for serial numbers out of range. Decode any serial number
59568bf0 10577 that was so large that it became a float. (Bug#8722)
08686060 10578
2d1fc3c7
PE
10579 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10580 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10581 Use XFASTINT rather than XUINT when numbers are nonnegative.
10582 (xd_append_arg, Fdbus_method_return_internal):
10583 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10584 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10585 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10586 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10587 (Bug#8722)
2d1fc3c7 10588
c8a9ca5a
PE
10589 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10590
519e1d69
PE
10591 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10592
6df6ae42 10593 ccl: Add integer overflow checks.
30569699
PE
10594 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10595 (IN_INT_RANGE): New macros.
10596 (ccl_driver): Use them to check for integer overflow when
10597 decoding a CCL program. Many of the new checks are whether XINT (x)
10598 fits in int; it doesn't always, on 64-bit hosts. The new version
10599 doesn't catch all possible integer overflows, but it's an
847044ea 10600 improvement. (Bug#8719)
30569699 10601
c11285dc
PE
10602 * alloc.c (make_event_array): Use XINT, not XUINT.
10603 There's no need for unsigned here.
10604
fdccd48e
PE
10605 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10606 This follows up to the 2011-05-06 change that substituted uintptr_t
10607 for EMACS_INT. This case wasn't caught back then.
10608
37910ab2
PE
10609 Rework Fformat to avoid integer overflow issues.
10610 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10611 now (part of C89). Include <verify.h>.
10612 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10613 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10614 (Fformat): Avoid the prepass trying to compute sizes; it was only
10615 approximate and thus did not catch overflow reliably. Instead, walk
10616 through the format just once, formatting and computing sizes as we go,
10617 checking for integer overflow at every step, and allocating a larger
10618 buffer as needed. Keep track separately whether the format is
10619 multibyte. Keep only the most-recently calculated precision, rather
10620 than them all. Record whether each argument has been converted to
10621 string. Use EMACS_INT, not int, for byte and char and arg counts.
10622 Support field widths and precisions larger than INT_MAX. Avoid
10623 sprintf's undefined behavior with conversion specifications such as %#d
10624 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10625 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10626 formatting out-of-range floating point numbers with int
9173deec 10627 formats. (Bug#8668)
37910ab2 10628
2e6578fb
PE
10629 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10630
0ae6bdee
PE
10631 * data.c: Avoid integer truncation in expressions involving floats.
10632 * data.c: Include <intprops.h>.
10633 (arith_driver): When there's an integer overflow in an expression
10634 involving floating point, convert the integers to floating point
10635 so that the resulting value does not suffer from catastrophic
10636 integer truncation. For example, on a 64-bit host (* 4
10637 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10638 Do not rely on undefined behavior after integer overflow.
10639
de883a70
PE
10640 merge count_size_as_multibyte, parse_str_to_multibyte
10641 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10642 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10643 Check for integer overflow.
10644 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10645 since it's now a duplicate of the other. This is more of
10646 a character than a buffer op, so better that it's in character.c.
10647 * fns.c, print.c: Adjust to above changes.
10648
2ff916cb
PE
106492011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10650
10651 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10652
f1b54466
PE
106532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10654
fb1ac845
PE
10655 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10656 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10657 (x_clipboard_manager_save): Now static.
10658 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10659
f1b54466
PE
10660 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10661 (crypto_hash_function): Now static.
10662 Fix pointer signedness problems. Avoid unnecessary initializations.
10663
a9f737ee
CY
106642011-05-27 Chong Yidong <cyd@stupidchicken.com>
10665
10666 * termhooks.h (Vselection_alist): Make it terminal-local.
10667
10668 * terminal.c (create_terminal): Initialize it.
10669
10670 * xselect.c: Support for clipboard managers.
10671 (Vselection_alist): Move to termhooks.h as terminal-local var.
10672 (LOCAL_SELECTION): New macro.
10673 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10674 (symbol_to_x_atom): Remove gratuitous arg.
10675 (x_handle_selection_request, lisp_data_to_selection_data)
10676 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10677 (x_own_selection, x_get_local_selection, x_convert_selection):
10678 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10679 (some_frame_on_display): Delete unused function.
10680 (Fx_own_selection_internal, Fx_get_selection_internal)
10681 (Fx_disown_selection_internal, Fx_selection_owner_p)
10682 (Fx_selection_exists_p): New optional frame arg.
10683 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10684 (x_handle_selection_clear): Don't treat other terminals with the
10685 same keyboard specially. Use the terminal-local Vselection_alist.
10686 (x_clear_frame_selections): Use Frun_hook_with_args.
10687
10688 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10689
10690 * xterm.h: Add support for those atoms.
10691
e067f0c1
CY
106922011-05-26 Chong Yidong <cyd@stupidchicken.com>
10693
10694 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10695 (converted_selections, conversion_fail_tag): New global variables.
10696 (x_selection_request_lisp_error): Free the above.
10697 (x_get_local_selection): Remove unnecessary code.
10698 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10699 of converted selections stored in converted_selections.
10700 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10701 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10702 (x_convert_selection): New function.
10703 (x_handle_selection_event): Simplify.
10704 (x_get_foreign_selection): Don't ignore incoming requests while
10705 waiting for an answer; this will fail when we implement
10706 SAVE_TARGETS, and seems unnecessary anyway.
10707 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10708 (Vx_sent_selection_functions): Doc fix.
10709
0f4aebc0
LL
107102011-05-26 Leo Liu <sdl.web@gmail.com>
10711
10712 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10713
e61124cd
YM
107142011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10715
10716 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10717
10718 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10719 for fringe update if it has periodic bitmap.
ac389d0c 10720 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10721 and fringe_bitmap_periodic_p.
10722
10723 * fringe.c (get_fringe_bitmap_data): New function.
10724 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10725 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10726 row. Mark glyph row for fringe update if periodicity changed.
10727
10728 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10729 for fringe update unless it has periodic bitmap.
10730
f16d9837
KH
107312011-05-25 Kenichi Handa <handa@m17n.org>
10732
10733 * xdisp.c (get_next_display_element): Set correct it->face_id for
10734 a static composition.
10735
e1b90ef6
LL
107362011-05-24 Leo Liu <sdl.web@gmail.com>
10737
10738 * deps.mk (fns.o):
10739 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10740
10741 * fns.c (crypto_hash_function, Fsha1): New function.
10742 (Fmd5): Use crypto_hash_function.
10743 (syms_of_fns): Add Ssha1.
10744
7400048f
PE
107452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10746
10747 * gnutls.c: Remove unused macros.
10748 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10749 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10750 Remove macros that are defined and never used.
10751 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10752
abb71cf4
CY
107532011-05-22 Chong Yidong <cyd@stupidchicken.com>
10754
10755 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10756 (Fx_get_selection_internal): Minor cleanup.
10757 (Fx_own_selection_internal): Rename arguments for consistency with
10758 select.el.
10759
6307db39
PE
107602011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10761
10762 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10763
f3d4e0a4
CY
107642011-05-22 Chong Yidong <cyd@stupidchicken.com>
10765
10766 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10767
4d8ade89
YM
107682011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10769
10770 * dispnew.c (scrolling_window): Don't exclude the case that the
10771 last enabled row in the desired matrix touches the bottom boundary.
10772
32078c8d
GM
107732011-05-21 Glenn Morris <rgm@gnu.org>
10774
10775 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10776 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10777 and add some more files.
32078c8d 10778
7285dc67
EZ
107792011-05-20 Eli Zaretskii <eliz@gnu.org>
10780
10781 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10782 report_file_error introduced by the change from 2011-05-07.
10783
89d1bd22
PE
107842011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10785
10786 * systime.h (Time): Define only if emacs is defined.
10787 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10788 where the include path doesn't have X11/X.h by default. See
10789 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10790
cd394be1 107912011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10792
10793 * composite.c (find_automatic_composition): Fix previous change.
10794
b9704ad9
GM
107952011-05-20 Glenn Morris <rgm@gnu.org>
10796
10797 * lisp.mk: New file, split from Makefile.in.
10798 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10799 (shortlisp): Remove.
10800 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10801
4a720484
GM
108022011-05-19 Glenn Morris <rgm@gnu.org>
10803
10804 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10805 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10806 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10807 (lisp): Set the order to that of loadup.el.
10808 (shortlisp): Make it a copy of $lisp.
10809 (SOME_MACHINE_LISP): Remove.
10810 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10811 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10812
a28d4396
KH
108132011-05-18 Kenichi Handa <handa@m17n.org>
10814
10815 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10816 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10817 (find_automatic_composition): Mostly rewrite for efficiency.
10818
a2b1fa8e
JB
108192011-05-18 Juanma Barranquero <lekktu@gmail.com>
10820
10821 * makefile.w32-in: Update dependencies.
10822
8e1f5610
CS
108232011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10824
10825 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10826 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10827
7025ee00 108282011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10829
cdfa6eab
PE
10830 Fix some integer overflow issues, such as string length overflow.
10831
06d6db33
PE
10832 * insdel.c (count_size_as_multibyte): Check for string overflow.
10833
2b4560a8
PE
10834 * character.c (lisp_string_width): Check for string overflow.
10835 Use EMACS_INT, not int, for string indexes and lengths; in
10836 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10837 the resulting string length overflows an EMACS_INT; instead,
10838 report a string overflow if no precision given. When checking for
10839 precision exhaustion, use a check that cannot possibly have
10840 integer overflow. (Bug#8675)
10841 * character.h (lisp_string_width): Adjust to new signature.
10842
cb93f9be
PE
10843 * alloc.c (string_overflow): New function.
10844 (Fmake_string): Use it. This doesn't change behavior, but saves
10845 a few bytes and will simplify future changes.
10846 * character.c (string_escape_byte8): Likewise.
10847 * lisp.h (string_overflow): New decl.
10848
1a1f3366
PE
10849 Fixups, following up to the user-interface timestamp change.
10850 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10851 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10852 * msdos.c (mouse_get_pos): Likewise.
10853 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10854 * w32gui.h (Time): Define by including "systime.h" rather than by
10855 declaring it ourselves. (Bug#8664)
10856
d4e3e4d3
PE
10857 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10858 * image.c (clear_image_cache): Likewise.
10859
f6a24d19
PE
10860 * term.c (term_mouse_position): Don't assume time_t wraparound.
10861
08dc5ae6
PE
10862 Be more systematic about user-interface timestamps.
10863 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10864 and sometimes 'EMACS_UINT', to represent these timestamps.
10865 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10866 This makes the code easier to follow, and makes it easier to catch
10867 integer overflow bugs such as Bug#8664.
10868 * frame.c (Fmouse_position, Fmouse_pixel_position):
10869 Use Time, not unsigned long, for user-interface timestamps.
10870 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10871 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10872 * keyboard.h (last_event_timestamp): Likewise.
10873 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10874 * menu.h (xmenu_show): Likewise.
10875 * term.c (term_mouse_position): Likewise.
10876 * termhooks.h (struct input_event.timestamp): Likewise.
10877 (struct terminal.mouse_position_hook): Likewise.
10878 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10879 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10880 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10881 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10882 what it was before.
10883 * menu.h, termhooks.h: Include "systime.h", for Time.
10884
8e55734a
PE
10885 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10886 Don't assume that the difference between two unsigned long values
10887 can fit into an integer. At this point, we know button_down_time
10888 <= event->timestamp, so the difference must be nonnegative, so
10889 there's no need to cast the result if double-click-time is
10890 nonnegative, as it should be; check that it's nonnegative, just in
10891 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10892 apart (about 25 days). (Bug#8664)
8e55734a 10893
841f1b75 10894 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10895 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10896
3e26f69c
PE
10897 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10898 that always fit in int. Use a sentinel instead of a counter, to
10899 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10900 * frame.h (struct frame): Use int for menu_bar_items_used
10901 instead of EMACS_INT, since it always fits in int.
3e26f69c 10902
5cc152c0
PE
10903 * menu.c (grow_menu_items): Check for int overflow.
10904
d89eb65e
PE
10905 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10906
5235bd3e
PE
10907 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10908 Before, the code was not consistent. These values cannot exceed
10909 2**31 - 1 so there's no need to make them unsigned.
10910 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10911 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10912 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10913 as modifiers.
10914 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10915
bc827e23
PE
10916 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10917 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10918 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10919 presumably because the widths might not match.
10920
78eb494e
PE
10921 * window.c (size_window): Avoid needless test at loop start.
10922
04f2d78b
CB
109232011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10924
10925 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10926
d2fc7e3d 109272011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10928
10929 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10930
d2fc7e3d 109312011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10932
10933 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10934 `width' to `bar_area_x' and `bar_area_width', respectively.
10935 (x_scroll_run): Take account of fringe background extension.
10936
04f2d78b
CB
10937 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10938 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10939 `bar_area_width', respectively.
10940 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10941 background extension.
10942
79b70037
GM
109432011-05-10 Jim Meyering <meyering@redhat.com>
10944
10945 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10946
2f142cc5
JB
109472011-05-10 Juanma Barranquero <lekktu@gmail.com>
10948
10949 * image.c (Finit_image_library): Return t for built-in image types,
10950 like pbm and xbm. (Bug#8640)
10951
57679c86
AS
109522011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10953
10954 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10955
888c9e86
EZ
109562011-05-07 Eli Zaretskii <eliz@gnu.org>
10957
b0512a1d
EZ
10958 * w32console.c (Fset_screen_color): Doc fix.
10959 (Fget_screen_color): New function.
10960 (syms_of_ntterm): Defsubr it.
10961
7285dc67
EZ
10962 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10963 unlink the temporary file if Fcall_process didn't create it in the
10964 first place.
10965 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10966 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10967 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10968 cue to call_process_cleanup not to close that handle.
10969
4d3fcc8e
BK
109702011-05-07 Ben Key <bkey76@gmail.com>
10971
10972 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10973 one of two shell specific rules, either bootstrap-temacs-CMD or
10974 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10975 to the previous implementation of the bootstrap-temacs rule.
10976 The bootstrap-temacs-CMD rule is similar to the previous
10977 implementation of the bootstrap-temacs rule except that it
10978 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10979 variable.
10980
10981 These changes, along with some changes to nt/configure.bat,
10982 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10983 earlier fix to add support for --cflags and --ldflags options
10984 that include quotes so that it works whether make uses cmd or
10985 sh as the shell.
10986
b4289b64
MA
109872011-05-06 Michael Albinus <michael.albinus@gmx.de>
10988
10989 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10990 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10991 is a constant.
10992 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10993 a string. Handle both cases.
10994 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10995 (Fdbus_register_method): Use Qinvalid_function.
10996
af4c0e28
JB
109972011-05-06 Juanma Barranquero <lekktu@gmail.com>
10998
10999 * makefile.w32-in: Update dependencies.
11000 (LISP_H): Add inttypes.h and stdin.h.
11001 (PROCESS_H): Add unistd.h.
11002
c51453d9
EZ
110032011-05-06 Eli Zaretskii <eliz@gnu.org>
11004
11005 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11006 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11007
8ff0ac3c 110082011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11009
4c4b566b
PE
11010 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11011
aab2b9b5
PE
11012 * term.c (vfatal): Remove stray call to va_end.
11013 It's not needed and the C Standard doesn't allow it here anyway.
11014
c378da0b
PE
11015 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11016 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11017
288b08c7
PE
11018 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11019 bytes.
11020
e3601888
PE
11021 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11022
db6c0e74
PE
11023 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11024
dd5963ea
PE
11025 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11026
88c9450f
PE
11027 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11028
2f9442b8
PE
11029 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11030
c032b5f8
PE
11031 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11032 * charset.c (Fdefine_charset_internal): Don't initialize
11033 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11034 32-bit int (Bug#8600).
a108c10b
PE
11035
11036 * lread.c (read_integer): Be more consistent with string-to-number.
11037 Use string_to_number to do the actual conversion; this avoids
11038 rounding errors and fixes some other screwups. Without this fix,
11039 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11040 (digit_to_number): Move earlier, for benefit of read_integer.
11041 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11042 not a digit in any supported base. (Bug#8602)
a108c10b 11043
ad5f9eea
PE
11044 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11045
aec1708a
PE
11046 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11047 to match comment at start of function. This also removes a
11048 GCC warning about overflow in a 32+64-bit port.
11049
47be4ab5
PE
11050 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11051
371cac43
PE
11052 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11053 Reported by Stefan Monnier in
11054 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11055 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11056 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11057
d01a7826
PE
11058 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11059 (EMACS_UINTPTR): Likewise, with uintptr_t.
11060
7fd47d5c
PE
11061 * lisp.h: Prefer 64-bit EMACS_INT if available.
11062 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11063 on 32-bit hosts that have 64-bit int, so that they can access
11064 large files.
122b0c86
PE
11065 However, temporarily disable this change unless the temporary
11066 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11067
8727937b
PE
11068 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11069
8ac068ac
PE
11070 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11071 This removes an assumption that EMACS_INT and long are the same
11072 width as pointers. The assumption is true for Emacs porting targets
11073 now, but we want to make other targets possible.
11074 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11075 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11076 In the rest of the code, change types of integers that hold casted
11077 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11078 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11079 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11080 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11081 No need to cast type when ORing.
11082 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11083 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11084 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11085 assume EMACS_INT is the same width as char *.
11086 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11087 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11088 Remove no-longer-needed casts.
11089 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11090 (xg_tool_bar_help_callback, xg_make_tool_item):
11091 Use EMACS_INTPTR to hold an integer
11092 that will be cast to void *; this can avoid a GCC warning
11093 if EMACS_INT is not the same width as void *.
11094 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11095 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11096 (current_message_1, set_message_1):
11097 Use a local to convert to proper width without a cast.
11098 * xmenu.c (dialog_selection_callback): Likewise.
11099
ede49d71
PE
11100 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11101 Also, don't assume VALBITS / RAND_BITS is less than 5,
11102 and don't rely on undefined behavior when shifting a 1 left into
11103 the sign bit.
11104 * lisp.h (get_random): Change signature to match.
11105
2f30ecd0
PE
11106 * lread.c (hash_string): Use size_t, not int, for hash computation.
11107 Normally we prefer signed values; but hashing is special, because
11108 it's better to use unsigned division on hash table sizes so that
11109 the remainder is nonnegative. Also, size_t is the natural width
11110 for hashing into memory. The previous code used 'int', which doesn't
11111 retain enough info to hash well into very large tables.
11112 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11113
2a866e7b
PE
11114 * dbusbind.c: Don't possibly lose pointer info when converting.
11115 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11116 Use XPNTR rather than XHASH, so that the high-order bits of
11117 the pointer aren't lost when converting through void *.
11118
51639eac
PE
11119 * eval.c (Fautoload): Don't double-shift a pointer.
11120
92394119
PE
11121 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11122
dbdb9a7c
JB
111232011-05-06 Juanma Barranquero <lekktu@gmail.com>
11124
11125 * gnutls.c (DEF_GNUTLS_FN):
11126 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11127
db7a0b4f
AS
111282011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11129
11130 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11131 marker. (Bug#8610)
11132
cd394be1 111332011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11134
11135 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11136 New version that can reserve upto 2GB of heap space.
11137
f7ff1b0f 111382011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11139
11140 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11141
639c109b
TZ
111422011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11143
11144 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11145 `gnutls_certificate_set_x509_key_file'.
11146
d2127135
JB
111472011-05-05 Juanma Barranquero <lekktu@gmail.com>
11148
11149 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11150 Update dependencies.
11151
e968f4f3
JB
111522011-05-04 Juanma Barranquero <lekktu@gmail.com>
11153
11154 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11155 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11156 Remove unused parameter `fildes'.
11157 * process.c (read_process_output, send_process): Don't pass it.
11158
84d358f0
JB
111592011-05-04 Juanma Barranquero <lekktu@gmail.com>
11160
11161 Fix previous change: the library cache is defined in w32.c.
11162 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11163 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11164
0898ca10
JB
111652011-05-04 Juanma Barranquero <lekktu@gmail.com>
11166
11167 Implement dynamic loading of GnuTLS on Windows.
11168
11169 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11170 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11171 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11172 Declare.
11173
11174 * gnutls.c (Qgnutls_dll): Define.
11175 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11176 (gnutls_*): Declare function pointers.
11177 (init_gnutls_functions): New function to initialize function pointers.
11178 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11179 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11180 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11181 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11182 (emacs_gnutls_write, emacs_gnutls_read)
11183 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11184 (Fgnutls_available_p): New function.
11185 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11186 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11187 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11188
11189 * image.c: Include w32.h.
11190 (Vimage_type_cache): Delete.
11191 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11192 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11193 (w32_delayed_load): Move to w32.c.
11194
11195 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11196
11197 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11198 (w32_delayed_load): Move from image.c. When loading a library, record
11199 its filename in the :loaded-from property of the library id.
11200 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11201 Initialize and staticpro them.
11202 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11203
11204 * process.c: Include lisp.h before w32.h, not after.
11205 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11206 instead of gnutls_record_check_pending.
11207
11208 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11209
ff4de4aa
TZ
112102011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11211
11212 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11213 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11214 as passed in.
11215
abe95abb
JD
112162011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11217
11218 * xterm.c (x_set_frame_alpha): Do not set property on anything
11219 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11220
e16e55d4
JB
112212011-05-02 Juanma Barranquero <lekktu@gmail.com>
11222
11223 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11224
bafcf6a5
JB
112252011-05-02 Juanma Barranquero <lekktu@gmail.com>
11226
11227 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11228 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11229 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11230 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11231 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11232 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11233 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11234 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11235 (Qgnutls_bootprop_callbacks_verify): Make static.
11236
e7a6747f
AS
112372011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11238
19ed11ba
AS
11239 * callproc.c: Indentation fixup.
11240
e7a6747f 11241 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11242 (wait_for_termination, interruptible_wait_for_termination):
11243 Move after wait_for_termination_1.
e7a6747f 11244
1ef14cb4
LMI
112452011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11246
11247 * sysdep.c (interruptible_wait_for_termination): New function
11248 which is like wait_for_termination, but allows keyboard
11249 interruptions.
11250
11251 * callproc.c (Fcall_process): Add (:file "file") as an option for
11252 the STDOUT buffer.
11253 (Fcall_process_region): Ditto.
11254
330d880c
EZ
112552011-04-30 Eli Zaretskii <eliz@gnu.org>
11256
8db90b73
EZ
11257 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11258 rather than `XVECTOR (FOO)->size'.
11259
330d880c
EZ
11260 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11261 inttypes.h, as a gnulib replacement is used if it not available in
11262 system headers.
11263
15cbd324
EZ
112642011-04-21 Eli Zaretskii <eliz@gnu.org>
11265
11266 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11267 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11268 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11269
11270 * coding.c (coding_alloc_by_realloc): Error out if destination
11271 will grow beyond MOST_POSITIVE_FIXNUM.
11272 (decode_coding_emacs_mule): Abort if there isn't enough place in
11273 charbuf for the composition carryover bytes. Reserve an extra
11274 space for up to 2 characters produced in a loop.
11275 (decode_coding_iso_2022): Abort if there isn't enough place in
11276 charbuf for the composition carryover bytes.
11277
112782011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11279
ae940cca
EZ
11280 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11281 aborting when %lld or %lll format is passed.
11282 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11283 %llo or %llx format is passed. (Bug#8545)
11284
03ab8921
EZ
11285 * window.c (window_scroll_line_based): Use a marker instead of
11286 simple variables to record original value of point. (Bug#7952)
11287
afda1437
EZ
11288 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11289 produced by %s or %c overflows available buffer space. (Bug#8545)
11290
f76dee0c
PE
112912011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11292
11293 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11294 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11295
fdc5744d
JB
112962011-04-28 Juanma Barranquero <lekktu@gmail.com>
11297
11298 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11299
638f053a
JB
113002011-04-28 Juanma Barranquero <lekktu@gmail.com>
11301
11302 * keyboard.c (Qdelayed_warnings_hook): Define.
11303 (command_loop_1): Run `delayed-warnings-hook'
11304 if Vdelayed_warnings_list is non-nil.
11305 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11306 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11307
d178f871
EZ
113082011-04-28 Eli Zaretskii <eliz@gnu.org>
11309
11310 * doprnt.c (doprnt): Don't return value smaller than the buffer
11311 size if the message was truncated. (Bug#8545).
11312
b124fd93
JB
113132011-04-28 Juanma Barranquero <lekktu@gmail.com>
11314
11315 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11316 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11317
e810457d
PE
113182011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11319
11320 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11321
ea51cceb
JB
113222011-04-27 Juanma Barranquero <lekktu@gmail.com>
11323
11324 * makefile.w32-in: Update dependencies.
11325
94dcfacf
EZ
113262011-04-27 Eli Zaretskii <eliz@gnu.org>
11327
11328 Improve `doprnt' and its usage. (Bug#8545)
11329 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11330 `format_end'. Remove support for %l as a conversion specifier.
11331 Don't use xrealloc. Improve diagnostics when the %l size modifier
11332 is used. Update the commentary.
11333
11334 * eval.c (verror): Simplify calculation of size_t.
11335
11336 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11337 messages.
11338
f61f41d7
PE
113392011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11340
11341 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11342 change.
11343
96fb4434
PE
113442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11345
11346 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11347 This makes this file independent of the recent pseudovector change.
11348
671875da 113492011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11350
69e9b5a3
PE
11351 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11352
b5f869a7 11353 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11354 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11355 Remove unused local.
c8926152 11356 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11357
841a1577 11358 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11359 GCC 4.6.0 optimizes based on type-based alias analysis.
11360 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11361 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11362 != &v->size, and therefore "v->size = 1; b->size = 2; return
11363 v->size;" must therefore return 1. This assumption is incorrect
11364 for Emacs, since it type-puns struct Lisp_Vector * with many other
11365 types. To fix this problem, this patch adds a new type struct
f904488f 11366 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11367 and pseudovectors, and helps optimizing compilers not get fooled
11368 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11369 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11370 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11371 the size member.
eab3844f
PE
11372 (XSETPVECTYPE): Rewrite in terms of new macro.
11373 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11374 This is a bit clearer, and further avoids the possibility of
11375 undesirable aliasing.
11376 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11377 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11378 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11379 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11380 (ASIZE): Now uses header.size rather than size.
11381 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11382 to avoid the hassle of writing XVECTOR (foo)->header.size.
11383 (struct vectorlike_header): New type.
eab3844f
PE
11384 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11385 object, to help avoid aliasing.
11386 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11387 (SUBRP): Likewise, since Lisp_Subr is a special case.
11388 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11389 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11390 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11391 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11392 changed to be "header.size" and "header.next".
11393 * buffer.h (struct buffer): Likewise.
11394 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11395 * frame.h (struct frame): Likewise.
11396 * process.h (struct Lisp_Process): Likewise.
11397 * termhooks.h (struct terminal): Likewise.
11398 * window.c (struct save_window_data, struct saved_window): Likewise.
11399 * window.h (struct window): Likewise.
11400 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11401 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11402 * buffer.c (init_buffer_once): Likewise.
11403 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11404 special case.
11405 * process.c (Fformat_network_address): Use local var for size,
11406 for brevity.
11407
0df1eac5
PE
11408 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11409
847ab9d1 11410 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11411 * data.c (atof): Remove decl; no longer used or needed.
11412 (digit_to_number): Move to lread.c.
11413 (Fstring_to_number): Use new string_to_number function, to be
11414 consistent with how the Lisp reader treats infinities and NaNs.
11415 Do not assume that floating-point numbers represent EMACS_INT
11416 without losing information; this is not true on most 64-bit hosts.
11417 Avoid double-rounding errors, by insisting on integers when
11418 parsing non-base-10 numbers, as the documentation specifies.
11419 * lisp.h (string_to_number): New decl, replacing ...
11420 (isfloat_string): Remove.
bc0a5c13 11421 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11422 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11423 appears to have been a coding error. Similarly, do not accept
11424 strings like +-1e0 as floating point numbers. Do not report
11425 overflow for integer overflows unless the base is not 10 which
11426 means we have no simple and reliable way to continue.
11427 Break out the floating-point parsing into a new
11428 function string_to_number, so that Fstring_to_number parses
11429 floating point numbers consistently with the Lisp reader.
04f2d78b 11430 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11431 (E_CHAR, EXP_INT): Remove, replacing with ...
11432 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11433 (string_to_number): New function, replacing isfloat_string.
11434 This function checks for valid syntax and produces the resulting
11435 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11436 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11437 so that overflow for non-base-10 numbers is reported only when
11438 there's no portable and simple way to convert to floating point.
452f4150 11439
67769ffc
PE
11440 * textprop.c (set_text_properties_1): Rewrite for clarity,
11441 and to avoid GCC warning about integer overflow.
11442
c20db43f
PE
11443 * intervals.h (struct interval): Use EMACS_INT for members
11444 where EMACS_UINT might cause problems. See
11445 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11446 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11447 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11448 All uses changed.
37aa2f85
PE
11449 (offset_intervals): Tell GCC not to worry about length overflow
11450 when negating a negative length.
c20db43f 11451
2538aa2f
PE
11452 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11453 (overrun_check_free): Likewise.
11454
f2d3008d
PE
11455 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11456 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11457 word size.
11458
ec8df744
PE
11459 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11460 (gnutls_make_error): Rename local to avoid shadowing.
11461 (gnutls_emacs_global_deinit): ifdef out; not used.
11462 (Fgnutls_boot): Use const for pointer to readonly storage.
11463 Comment out unused local. Fix pointer signedness problems.
11464
640ee02d
PE
11465 * lread.c (openp): Don't stuff size_t into an 'int'.
11466 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11467 about possible signed overflow.
11468
6048fb2a
PE
11469 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11470 (GDK_KEY_g): Don't define if already defined.
11471 (xg_prepare_tooltip): Avoid pointer signedness problem.
11472 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11473
fa3c87e1
PE
11474 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11475 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11476
2172544b
PE
11477 * xfns.c (Fx_window_property): Simplify a bit,
11478 to make a bit faster and to avoid GCC 4.6.0 warning.
11479 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11480
9b821a21
PE
11481 * fns.c (internal_equal): Don't assume size_t fits in int.
11482
3c616cfa
PE
11483 * alloc.c (compact_small_strings): Tighten assertion a little.
11484
c2982e87
PE
11485 Replace pEd with more-general pI, and fix some printf arg casts.
11486 * lisp.h (pI): New macro, generalizing old pEd macro to other
11487 conversion specifiers. For example, use "...%"pI"d..." rather
11488 than "...%"pEd"...".
11489 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11490 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11491 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11492 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11493 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11494 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11495 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11496 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11497 64-bit hosts.
11498 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11499 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11500 * print.c (safe_debug_print, print_object): Likewise.
11501 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11502 to int.
6f04d126
PE
11503 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11504 avoiding the 0 flag, which is not portable.
c2982e87
PE
11505 * process.c (Fmake_network_process): Use pI to avoid cast.
11506 * region-cache.c (pp_cache): Likewise.
11507 * xdisp.c (decode_mode_spec): Likewise.
11508 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11509 behavior on 64-bit hosts with printf arg.
6f04d126 11510 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11511 (x_stop_queuing_selection_requests): Likewise.
11512 (x_get_window_property): Don't truncate byte count to an 'int'
11513 when tracing.
0b432f21 11514
5e073ec7
PE
11515 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11516 here, since it parses constructs like leading '-' and spaces,
11517 which are not wanted; and it overflows with large numbers.
11518 Instead, simply match F[0-9]+, which is what is wanted anyway.
11519
36372bf9
PE
11520 * alloc.c: Remove unportable assumptions about struct layout.
11521 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11522 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11523 (allocate_vectorlike, make_pure_vector): Use the new macros,
11524 plus offsetof, to remove unportable assumptions about struct layout.
11525 These assumptions hold on all porting targets that I know of, but
11526 they are not guaranteed, they're easy to remove, and removing them
11527 makes further changes easier.
11528
0b432f21
PE
11529 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11530 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11531 (string_overrun_cookie): Now const. Use initializers that
11532 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11533 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11534 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11535 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11536 multiple of sizeof (EMACS_INT); it need not be, if
11537 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11538 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11539
895009e1
JB
115402011-04-26 Juanma Barranquero <lekktu@gmail.com>
11541
11542 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11543
6a7a1b0b
TZ
115442011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11545
11546 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11547 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11548 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11549
841a1577 115502011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11551
11552 * lisp.h (Qdebug): List symbol.
895009e1 11553 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11554 * keyboard.c (debug-on-event): New variable.
11555 (handle_user_signal): Break into debugger when debug-on-event
11556 matches the current signal symbol.
11557
f2d3ba6f
DN
115582011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11559
11560 * alloc.c (check_sblock, check_string_bytes)
11561 (check_string_free_list): Convert to standard C.
11562
42ce4c63
TZ
115632011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11564
11565 * w32.c (emacs_gnutls_push): Fix typo.
11566
825cd63c
EZ
115672011-04-25 Eli Zaretskii <eliz@gnu.org>
11568
fb11d64d
EZ
11569 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11570 "cast to pointer from integer of different size".
11571
825cd63c
EZ
11572 Improve doprnt and its use in verror. (Bug#8545)
11573 * doprnt.c (doprnt): Document the set of format control sequences
11574 supported by the function. Use SAFE_ALLOCA instead of always
11575 using `alloca'.
11576
11577 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11578 is one byte too soon. Don't use xrealloc; instead xfree and
11579 xmalloc anew.
11580
e061a11b
TZ
115812011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11582
11583 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11584 callbacks stage.
11585
11586 * gnutls.c: Renamed global_initialized to
11587 gnutls_global_initialized. Added internals for the
11588 :verify-hostname-error, :verify-error, and :verify-flags
11589 parameters of `gnutls-boot' and documented those parameters in the
11590 docstring. Start callback support.
9173deec
JB
11591 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11592 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11593 on error. Return error code.
e061a11b
TZ
11594 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11595 (emacs_gnutls_read): Likewise.
11596 (Fgnutls_boot): Return handshake error code.
11597 (emacs_gnutls_handle_error): New function.
11598 (wsaerror_to_errno): Likewise.
11599
11600 * w32.h (emacs_gnutls_pull): Add prototype.
11601 (emacs_gnutls_push): Likewise.
11602
11603 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11604 (emacs_gnutls_push): Likewise.
11605
116062011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11607
11608 * process.c (wait_reading_process_output): Check if GnuTLS
11609 buffered some data internally if no FDs are set for TLS
11610 connections.
11611
11612 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11613 (LIBS): Link to USER_LIBS.
11614 ($(BLD)/gnutls.$(0)): New target.
11615
fa6996bc
EZ
116162011-04-24 Eli Zaretskii <eliz@gnu.org>
11617
eb35682e
EZ
11618 * xdisp.c (handle_single_display_spec): Rename the
11619 display_replaced_before_p argument into display_replaced_p, to
11620 make it consistent with the commentary. Fix typos in the
11621 commentary.
11622
e2ad650c
EZ
11623 * textprop.c (syms_of_textprop): Remove dead code.
11624 (copy_text_properties): Delete obsolete commentary about an
11625 interface that was deleted long ago. Fix typos in the description
11626 of arguments.
11627
1b2de274
EZ
11628 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11629 to changes in oldXMenu/XMenu.h from 2011-04-16.
11630 <menu_help_message, prev_menu_help_message>: Constify.
11631 (IT_menu_make_room): menu->help_text is now `const char **';
11632 adjust.
11633
11634 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11635 to changes in oldXMenu/XMenu.h from 2011-04-16.
11636 (struct XMenu): Declare `help_text' `const char **'.
11637
11638 * xfaces.c <Qunspecified>: Make extern again.
11639
11640 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11641 required by POSIX.
1b2de274 11642
762b15be
EZ
11643 * doc.c (get_doc_string): Improve the format passed to `error'.
11644
11645 * doprnt.c (doprnt): Improve commentary.
11646
11647 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11648
11649 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11650 them with etags.
11651
f1052e5d
EZ
11652 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11653 changes in globals.h immediately force recompilation.
762b15be
EZ
11654 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11655 $(CURDIR)/s/ms-w32.h.
11656 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11657
fa6996bc
EZ
11658 * character.c (Fchar_direction): Function deleted.
11659 (syms_of_character): Don't defsubr it.
11660 <char-direction-table>: Deleted.
11661
e6c3da20
EZ
116622011-04-23 Eli Zaretskii <eliz@gnu.org>
11663
11664 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11665 * doprnt.c: Include limits.h.
11666 (SIZE_MAX): New macro.
04f2d78b
CB
11667 (doprnt): Return a size_t value. 2nd arg is now size_t.
11668 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11669 Improve overflow protection. Support `l' modifier for integer
11670 conversions. Support %l conversion. Don't assume an EMACS_INT
11671 argument for integer conversions and for %c.
11672
11673 * lisp.h (doprnt): Restore prototype.
11674
11675 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11676 $(SRC)/character.h.
11677
11678 * Makefile.in (base_obj): Add back doprnt.o.
11679
11680 * deps.mk (doprnt.o): Add back prerequisites.
11681 (callint.o): Depend on character.h.
11682
11683 * eval.c (internal_lisp_condition_case): Include the handler
11684 representation in the error message.
11685 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11686 when breaking from the loop.
11687
11688 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11689
11690 * callint.c (Fcall_interactively): When displaying error message
11691 about invalid control letter, pass the character's codepoint, not
11692 a pointer to its multibyte form. Improve display of the character
11693 in octal and display also its hex code.
11694
11695 * character.c (char_string): Use %x to display the (unsigned)
11696 codepoint of an invalid character, to avoid displaying a bogus
11697 negative value.
11698
11699 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11700 `error', not SYMBOL_NAME itself.
11701
11702 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11703 character arguments to `error'.
11704
11705 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11706 to `error' in error message about FINAL_CHAR argument. Make sure
11707 FINAL_CHAR is a character, and use %c when it is passed as
11708 argument to `error'.
11709
4ffd0d6b 117102011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11711
11712 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11713
11714 * w32.c: Include <time.h>.
11715 (sys_localtime): New function.
11716
4ffd0d6b 117172011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11718
11719 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11720
4ffd0d6b 11721 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11722
4ffd0d6b 117232011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11724
4ffd0d6b
GM
11725 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11726 zombies (Bug#8467).
aac0c6e3 11727
04c56954
EZ
117282011-04-19 Eli Zaretskii <eliz@gnu.org>
11729
11730 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11731 gl_state.e_property when gl_state.object is Qt.
11732
11733 * insdel.c (make_gap_larger): Remove limitation of buffer size
11734 to <= INT_MAX.
11735
16a43933
CY
117362011-04-18 Chong Yidong <cyd@stupidchicken.com>
11737
11738 * xdisp.c (lookup_glyphless_char_display)
11739 (produce_glyphless_glyph): Handle cons cell entry in
11740 glyphless-char-display.
11741 (Vglyphless_char_display): Document it.
11742
11743 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11744 glyphless-char-display.
11745
4581706e
CY
117462011-04-17 Chong Yidong <cyd@stupidchicken.com>
11747
11748 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11749
11750 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11751
11752 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11753 definition for no-X builds.
11754
4887c6e2 117552011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11756
fd35b6f9
PE
11757 Static checks with GCC 4.6.0 and non-default toolkits.
11758
5c1ccb01
PE
11759 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11760
006c5daa
PE
11761 * process.c (keyboard_bit_set): Define only if SIGIO.
11762 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11763 (send_process): Repair possible setjmp clobbering.
11764
efc736d3
PE
11765 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11766
4e2fe2e6
PE
11767 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11768
f97334a2
PE
11769 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11770
4e75f29d
PE
11771 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11772 Define only if needed.
11773
90efadd1
PE
11774 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11775 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11776 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11777
3c647824
PE
11778 * dispextern.h (struct redisplay_interface): Rename param
11779 to avoid shadowing.
e264f262 11780 * termhooks.h (struct terminal): Likewise.
761383f4 11781 * xterm.c (xembed_send_message): Likewise.
3c647824 11782
b58c5c4a
PE
11783 * insdel.c (make_gap_smaller): Define only if
11784 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11785
cad59032
PE
11786 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11787 it.
11788
c339dc2e
PE
11789 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11790 so that we aren't warned about unused symbols.
11791
91a3e27b
PE
11792 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11793
399c71d3 11794 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11795
8ffc96f5
PE
11796 * xfns.c (x_real_positions): Mark locals as initialized.
11797
eef9bc79
PE
11798 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11799
098db9dd
PE
11800 * xterm.c: Fix problems found by static analysis with other toolkits.
11801 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11802 (x_dispatch_event): Declare static if USE_GTK, and
11803 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11804 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11805 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11806 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11807 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11808
eb18f6cc
PE
11809 * xmenu.c (menu_help_callback): Pointer type fixes.
11810 Use const pointers when pointing at readonly data. Avoid pointer
11811 signedness clashes.
11812 (FALSE): Remove unused macro.
11813 (update_frame_menubar): Remove unused decl.
11814
1fe72bf8
PE
11815 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11816
60d9e1db
PE
11817 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11818 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11819 (single_menu_item): Rename local to avoid shadowing.
11820
39261c26
PE
11821 * keyboard.c (make_lispy_event): Remove unused local var.
11822
018c5e19
PE
11823 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11824 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11825
63d2b86e
PE
11826 * bitmaps: Change bitmaps from unsigned char back to the X11
11827 compatible char. Avoid the old compiler warnings about
11828 out-of-range initializers by using, for example, '\xab' rather
11829 than 0xab.
11830
aefd87e1
PE
11831 * xgselect.c (xgselect_initialize): Check vs interface
11832 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11833
bf501fb9
PE
11834 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11835
e9829fdf
PE
11836 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11837 to read-only memory.
11838
1086c095
PE
11839 * fns.c (vector): Remove; this old hack is no longer needed.
11840
2baccd04 11841 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11842 Remove unused var.
dde42981 11843 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11844
72391843 11845 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11846
436c16df 11847 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11848 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11849 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11850
92bb796d 11851 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11852 (x_term_init): Remove local to avoid shadowing.
92bb796d 11853
764430a3 11854 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11855
11856 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11857 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11858
d1dfb56c
EZ
118592011-04-16 Eli Zaretskii <eliz@gnu.org>
11860
c4354cb4
EZ
11861 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11862
d1dfb56c
EZ
11863 Fix regex.c, syntax.c and friends for buffers > 2GB.
11864 * syntax.h (struct gl_state_s): Declare character position members
11865 EMACS_INT.
11866
11867 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11868
04f2d78b
CB
11869 * textprop.c (verify_interval_modification, interval_of):
11870 Declare arguments EMACS_INT.
d1dfb56c
EZ
11871
11872 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11873 EMACS_INT.
11874
11875 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11876
11877 * indent.c (Fvertical_motion): Local variable it_start is now
11878 EMACS_INT.
11879
11880 * regex.c (re_match, re_match_2, re_match_2_internal)
11881 (bcmp_translate, regcomp, regexec, print_double_string)
11882 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11883 (re_compile_pattern, re_exec): Declare arguments and local
11884 variables `size_t' and `ssize_t' and return values `regoff_t', as
11885 appropriate.
11886 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11887 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11888 <compile_stack_type>: `size' and `avail' are now `size_t'.
11889
11890 * regex.h <regoff_t>: Use ssize_t, not int.
11891 (re_search, re_search_2, re_match, re_match_2): Arguments that
11892 specify buffer/string position and length are now ssize_t and
11893 size_t. Return type is regoff_t.
11894
613052cd
BK
118952011-04-16 Ben Key <bkey76@gmail.com>
11896
11897 * nsfont.m: Fixed bugs in ns_get_family and
11898 ns_descriptor_to_entity that were caused by using free to
11899 deallocate memory blocks that were allocated by xmalloc (via
11900 xstrdup). This caused Emacs to crash when compiled with
11901 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11902 --enable-checking=xmallocoverrun). xfree is now used to
11903 deallocate these memory blocks.
11904
4170f62f 119052011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11906
71b41406
PE
11907 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11908
9587a89d
PE
11909 emacs_write: Accept and return EMACS_INT for sizes.
11910 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11911 et seq.
11912 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11913 Accept and return EMACS_INT.
11914 (emacs_gnutls_write): Return the number of bytes written on
11915 partial writes.
11916 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11917 (emacs_read, emacs_write): Remove check for negative size, as the
11918 Emacs source code has been audited now.
9587a89d
PE
11919 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11920 (emacs_read, emacs_write): Use it.
273a5f82
PE
11921 * process.c (send_process): Adjust to the new signatures of
11922 emacs_write and emacs_gnutls_write. Do not attempt to store
11923 a byte offset into an 'int'; it might overflow.
9587a89d 11924 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11925
3e047f51
PE
11926 * sound.c: Don't assume sizes fit in 'int'.
11927 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11928 Return EMACS_INT, not int.
3e047f51 11929 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11930 Accept EMACS_INT, not int.
11931 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11932 record read return values.
11933
cc39a9db
BK
119342011-04-15 Ben Key <bkey76@gmail.com>
11935
c9d0ec6d
JB
11936 * keyboard.c (Qundefined): Don't declare static since it is used
11937 in nsfns.m.
11938 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11939 static since they are used in nsfont.m.
cc39a9db 11940
6c60eb9f
SM
119412011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11942
11943 * process.c (Qprocessp): Don't declare static.
11944 * lisp.h (Qprocessp): Declare again.
11945
7990b61a
JB
119462011-04-15 Juanma Barranquero <lekktu@gmail.com>
11947
11948 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11949
5d4cb038
PE
119502011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11951
8bd7b830 11952 Improve C-level modularity by making more things 'static'.
cd64ea1d 11953
e3b27b31
PE
11954 Don't publish debugger-only interfaces to other modules.
11955 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11956 (verify_bytepos, count_markers): Move decls to the only modules
11957 that need them.
11958 * region-cache.h (pp_cache): Likewise.
11959 * window.h (check_all_windows): Likewise.
11960 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11961
5d4cb038
PE
11962 * sysdep.c (croak): Now static, if
11963 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11964 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11965
11966 * alloc.c (refill_memory_reserve): Now static if
11967 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11968 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11969
e87b6180
PE
11970 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11971 Define only if USE_LUCID.
11972
ac64929e
PE
11973 * xrdb.c (x_customization_string, x_rm_string): Now static.
11974
6f37259d
PE
11975 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11976 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11977
1683e3ab
PE
11978 * xdisp.c (draw_row_with_mouse_face): Now static.
11979 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11980
de9c2632
PE
11981 * window.h (check_all_windows): Mark externally visible.
11982
2b96acb7
PE
11983 * window.c (window_deletion_count): Now static.
11984
11985 * undo.c: Make symbols static if they're not exported.
11986 (last_undo_buffer, last_boundary_position, pending_boundary):
11987 Now static.
11988
50436f33
PE
11989 * textprop.c (interval_insert_behind_hooks): Now static.
11990 (interval_insert_in_front_hooks): Likewise.
11991
64520e5c
PE
11992 * term.c: Make symbols static if they're not exported.
11993 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11994 (max_frame_lines, tty_set_terminal_modes):
11995 (tty_reset_terminal_modes, tty_turn_off_highlight):
11996 (get_tty_terminal): Now static.
11997 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11998 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11999 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12000 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12001 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12002
1fa53021
PE
12003 * sysdep.c: Make symbols static if they're not exported.
12004 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12005 Now static.
12006 (sigprocmask_set, full_mask): Remove; unused.
12007 (wait_debugging): Mark as visible.
12008 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12009 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12010
d4b43b22
PE
12011 * syntax.c (syntax_temp): Define only if !__GNUC__.
12012
b7c513d0
PE
12013 * sound.c (current_sound_device, current_sound): Now static.
12014
989b29ad
PE
12015 * search.c (searchbufs, searchbuf_head): Now static.
12016
13a55a78
PE
12017 * scroll.c (scroll_cost): Remove; unused.
12018 * dispextern.h (scroll_cost): Remove decl.
12019
de68a1fc
PE
12020 * region-cache.h (pp_cache): Mark as externally visible.
12021
40ccffa6
PE
12022 * process.c: Make symbols static if they're not exported.
12023 (process_tick, update_tick, create_process, chan_process):
12024 (Vprocess_alist, proc_buffered_char, datagram_access):
12025 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12026 (deactivate_process): Mark defn as static, as well as decl.
12027 * lisp.h (create_process): Remove decl.
12028 * process.h (chan_process, Vprocess_alist): Remove decls.
12029
ad64fc97
PE
12030 * print.c: Make symbols static if they're not exported.
12031 (print_depth, new_backquote_output, being_printed, print_buffer):
12032 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12033 (print_interval, print_number_index, initial_stderr_stream):
12034 Now static.
12035 * lisp.h (Fprinc): Remove decl.
12036 (debug_output_compilation_hack): Mark as externally visible.
12037
adddb265
PE
12038 * sysdep.c (croak): Move decl from here to syssignal.h.
12039 * syssignal.h (croak): Put it here, so the API can be checked when
12040 'croak' is called from dissociate_if_controlling_tty.
12041
1717ede2
PE
12042 * minibuf.c: Make symbols static if they're not exported.
12043 (minibuf_save_list, choose_minibuf_frame): Now static.
12044 * lisp.h (choose_minibuf_frame): Remove decl.
12045
fa5fb2bc
PE
12046 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12047
1e3890d1
PE
12048 * lread.c: Make symbols static if they're not exported.
12049 (read_objects, initial_obarray, oblookup_last_bucket_number):
12050 Now static.
12051 (make_symbol): Remove; unused.
12052 * lisp.h (initial_obarray, make_symbol): Remove decls.
12053
8a1414fa
PE
12054 * keyboard.c: Make symbols static if they're not exported.
12055 (single_kboard, recent_keys_index, total_keys, recent_keys):
12056 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12057 (this_single_command_key_start, echoing, last_auto_save):
12058 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12059 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12060 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12061 (Vlispy_mouse_stem, double_click_count):
12062 Now static.
12063 (force_auto_save_soon): Define only if SIGDANGER.
12064 (ignore_mouse_drag_p): Now static if
12065 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12066 (print_help): Remove; unused.
12067 (stop_character, last_timer_event): Mark as externally visible.
12068 * keyboard.h (ignore_mouse_drag_p): Declare only if
12069 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12070 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12071 * lisp.h (echoing): Remove decl.
12072 (force_auto_save_soon): Declare only if SIGDANGER.
12073 * xdisp.c (redisplay_window): Simplify code, to make it more
12074 obvious that ignore_mouse_drag_p is not accessed if !defined
12075 USE_GTK && !defined HAVE_NS.
12076
93ea6e8f
PE
12077 * intervals.c: Make symbols static if they're not exported.
12078 (merge_properties_sticky, merge_interval_right, delete_interval):
12079 Now static.
12080 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12081
77382fcc
PE
12082 * insdel.c: Make symbols static if they're not exported.
12083 However, leave prepare_to_modify_buffer alone. It's never
12084 called from outside this function, but that appears to be a bug.
12085 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12086 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12087 (adjust_after_replace_noundo): Remove; unused.
12088 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12089 (signal_before_change): Remove decls.
77382fcc 12090
9306c32e
PE
12091 * indent.c (val_compute_motion, val_vmotion): Now static.
12092
cd44d2eb
PE
12093 * image.c: Make symbols static if they're not exported.
12094 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12095 if USE_GTK.
12096 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12097 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12098
ad9a7a06
PE
12099 * fringe.c (standard_bitmaps): Now static.
12100 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12101
81626931
PE
12102 * frame.c: Make symbols static if they're not exported.
12103 (x_report_frame_params, make_terminal_frame): Now static.
12104 (get_frame_param): Now static, unless HAVE_NS.
12105 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12106 (x_get_resource_string): Remove; not used.
12107 * frame.h (make_terminal_frame, x_report_frame_params):
12108 (x_get_resource_string); Remove decls.
12109 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12110 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12111
239f9db9
PE
12112 * font.c, fontset.c: Make symbols static if they're not exported.
12113 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12114 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12115 * font.c (font_close_object): Now static.
12116 * font.h (font_close_object): Remove.
12117 * fontset.c (FONTSET_OBJLIST): Remove.
12118 (free_realized_fontset) #if-0 the body, which does nothing.
12119 (face_suitable_for_char_p): #if-0, as it's never called.
12120 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12121 * xfaces.c (face_at_string_position):
12122 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12123 since 0 is always ASCII.
12124
dfcf3579
PE
12125 * fns.c (weak_hash_tables): Now static.
12126
5045092b
PE
12127 * fileio.c: Make symbols static if they're not exported.
12128 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12129 (Vwrite_region_annotation_buffers): Now static.
12130
57a96f5c
PE
12131 * eval.c: Make symbols static if they're not exported.
12132 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12133 * lisp.h (backtrace_list): Remove decl.
12134
35f08c38
PE
12135 * emacs.c: Make symbols static if they're not exported.
12136 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12137 (fatal_error_code, fatal_error_signal_hook, standard_args):
12138 Now static.
12139 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12140 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12141 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12142 * lisp.h (fatal_error_signal_hook): Remove decl.
12143 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12144
f44bd759
PE
12145 * editfns.c: Move a (normally-unused) function to its only use.
12146 * editfns.c, lisp.h (get_operating_system_release): Remove.
12147 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12148 worth the hassle of breaking this out.
12149
b532497d
PE
12150 * xterm.c: Make symbols static if they're not exported.
12151 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12152 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12153 (x_destroy_window, x_delete_display):
12154 Now static.
12155 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12156 (x_mouse_leave): Remove; unused.
12157 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12158 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12159 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12160 Remove decls.
12161 (x_mouse_leave): Declare only if WINDOWSNT.
12162 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12163 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12164 USE_X_TOOLKIT.
12165
1675728f
PE
12166 * ftxfont.c: Make symbols static if they're not exported.
12167 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12168 HAVE_FREETYPE.
12169 * font.h (ftxfont_driver): Likewise.
12170
e4cebfca
PE
12171 * xfns.c: Make symbols static if they're not exported.
12172 (x_last_font_name, x_display_info_for_name):
12173 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12174 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12175 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12176 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12177 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12178 (last_show_tip_args): Now static.
12179 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12180 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12181 (x_screen_planes): Remove; unused.
12182 * dispextern.h (x_screen_planes): Remove decl.
12183
5bf46f05
PE
12184 * dispnew.c: Make symbols static if they're not exported.
12185 * dispextern.h (redraw_garbaged_frames, scrolling):
12186 (increment_row_positions): Remove.
12187 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12188 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12189 Now static.
12190 (redraw_garbaged_frames): Remove; unused.
12191
435f4c28
PE
12192 * xfaces.c: Make symbols static if they're not exported.
12193 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12194 Remove decls.
12195 * xterm.h (defined_color): Remove decls.
12196 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12197 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12198 (menu_face_changed_default, defined_color, free_realized_face):
12199 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12200 (ascii_face_of_lisp_face): Remove; unused.
12201
8524aef3
PE
12202 * xdisp.c: Make symbols static if they're not exported.
12203 * dispextern.h (scratch_glyph_row, window_box_edges):
12204 (glyph_to_pixel_coords, set_cursor_from_row):
12205 (get_next_display_element, set_iterator_to_next):
12206 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12207 (show_mouse_face): Remove decls
12208 * frame.h (message_buf_print): Likewise.
12209 * lisp.h (pop_message, set_message, check_point_in_composition):
12210 Likewise.
12211 * xterm.h (set_vertical_scroll_bar): Likewise.
12212 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12213 (message_buf_print, scratch_glyph_row, displayed_buffer):
12214 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12215 (get_next_display_element, show_mouse_face, window_box_edges):
12216 (frame_to_window_pixel_xy, check_point_in_composition):
12217 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12218 (glyph_to_pixel_coords): Remove; unused.
12219
16390cd2
PE
12220 * dired.c (file_name_completion): Now static.
12221
12222 * dbusbind.c (xd_in_read_queued_messages): Now static.
12223
a25f4dfa
PE
12224 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12225 * data.c (circular_list_error): Remove.
12226
14a9c8df
PE
12227 * commands.h (last_point_position, last_point_position_buffer):
12228 (last_point_position_window): Remove decls.
12229 * keyboard.c: Make these variables static.
12230
04f2d78b
CB
12231 * coding.h (coding, code_convert_region, encode_coding_gap):
12232 Remove decls.
74ab6df5
PE
12233 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12234 (iso_code_class, detect_coding, code_convert_region): Now static.
12235 (encode_coding_gap): Remove; unused.
12236
38dfbee1
PE
12237 * chartab.c (chartab_chars, chartab_bits): Now static.
12238
a2cb4e63
PE
12239 * charset.h (charset_iso_8859_1): Remove decl.
12240 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12241 Now static.
12242
127198fd
PE
12243 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12244 * ccl.c (Vccl_program_table): Now static.
12245 (check_ccl_update): Remove; unused.
12246
d85b608f
PE
12247 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12248 * category.h: ... from here.
12249 * category.c (check_category_table, set_category_set): Now static.
12250
31cd66f3
PE
12251 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12252 * lisp.h: Remove these decls.
12253
c358e587
PE
12254 * buffer.c (buffer_count): Remove unused var.
12255
e78aecca
PE
12256 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12257 so that it's not optimized away.
12258 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12259 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12260 exported only to the debugger.
12261
e192d7d3 12262 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12263 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12264
92470028
PE
12265 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12266 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12267 was inaccessible from Lisp.
12268 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12269 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12270
244ed907
PE
12271 alloc.c: Import and export fewer symbols, and remove unused items.
12272 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12273 is defined.
12274 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12275 it's not optimized away by whole-program optimization.
12276 (message_enable_multibyte, free_misc): Remove.
12277 (catchlist, handlerlist, mark_backtrace):
12278 Declare only if BYTE_MARK_STACK.
12279 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12280 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12281 (message_enable_multibyte): Remove decl.
12282 (free_misc, interval_free_list, float_block, float_block_index):
12283 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12284 (cons_free_list, last_marked_index):
12285 Now static.
12286 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12287 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12288 (mark_backtrace): Define only if BYTE_MARK_STACK.
12289 * xdisp.c (message_enable_multibyte): Now static.
12290
61c2b50e 12291 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12292 This makes it easier for human readers (and static analyzers)
12293 to see whether these variables are used from other modules.
12294 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12295 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12296 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12297 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12298 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12299 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12300 * xmenu.c, xselect.c:
12301 Declare Q* vars static if they are not used in other modules.
12302 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12303 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12304 Remove decls of unexported vars.
12305 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12306
95c82688
PE
12307 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12308
16a97296
PE
12309 Make Emacs functions such as Fatom 'static' by default.
12310 This makes it easier for human readers (and static analyzers)
12311 to see whether these functions can be called from other modules.
12312 DEFUN now defines a static function. To make the function external
12313 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12314 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12315 (Finit_image_library):
16a97296
PE
12316 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12317 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12318 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12319 Remove decls, since these functions are now static.
12320 (Funintern, Fget_internal_run_time): New decls, since these functions
12321 were already external.
95c82688 12322
16a97296
PE
12323 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12324 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12325 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12326 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12327 * keyboard.c, keymap.c, lread.c:
12328 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12329 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12330 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12331 Mark functions with DEFUE instead of DEFUN,
12332 if they are used in other modules.
12333 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12334 decls for now-static functions.
12335 * buffer.h (Fdelete_overlay): Remove decl.
12336 * callproc.c (Fgetenv_internal): Mark as internal.
12337 * composite.c (Fremove_list_of_text_properties): Remove decl.
12338 (Fcomposition_get_gstring): New forward static decl.
12339 * composite.h (Fcomposite_get_gstring): Remove decl.
12340 * dired.c (Ffile_attributes): New forward static decl.
12341 * doc.c (Fdocumntation_property): New forward static decl.
12342 * eval.c (Ffetch_bytecode): New forward static decl.
12343 (Funintern): Remove extern decl; now in .h file where it belongs.
12344 * fileio.c (Fmake_symbolic_link): New forward static decl.
12345 * image.c (Finit_image_library): New forward static decl.
12346 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12347 * intervals.h (Fprevious_property_change):
12348 (Fremove_list_of_text_properties): Remove decls.
12349 * keyboard.c (Fthis_command_keys): Remove decl.
12350 (Fcommand_execute): New forward static decl.
12351 * keymap.c (Flookup_key): New forward static decl.
12352 (Fcopy_keymap): Now static.
12353 * keymap.h (Flookup_key): Remove decl.
12354 * process.c (Fget_process): New forward static decl.
12355 (Fprocess_datagram_address): Mark as internal.
12356 * syntax.c (Fsyntax_table_p): New forward static decl.
12357 (skip_chars): Remove duplicate decl.
12358 * textprop.c (Fprevious_property_change): New forward static decl.
12359 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12360 Now internal.
12361 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12362 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12363
785bbd42
PE
12364 * editfns.c (Fformat): Remove unreachable code.
12365
8b913b57
AS
123662011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12367
12368 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12369 change. (Bug#8496)
12370
a6744a35
EZ
123712011-04-13 Eli Zaretskii <eliz@gnu.org>
12372
12373 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12374 when at ZV. (Bug#8487)
12375
e7974947
AS
123762011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12377
baad03f0
AS
12378 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12379 (Bug#8437)
12380 * keyboard.c (parse_tool_bar_item): Likewise.
12381 * sound.c (sound_cleanup, alsa_close): Likewise.
12382 * termcap.c (tgetent): Likewise.
12383 * xfns.c (x_default_font_parameter): Likewise.
12384 * xsettings.c (read_and_apply_settings): Likewise.
12385
e7974947
AS
12386 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12387 (overrun_check_free): Protoize.
12388
28272684
PE
123892011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12390
12391 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12392 since callers should never pass a negative size.
12393 Change the signature to match that of plain 'read' and 'write'; see
12394 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12395 * lisp.h: Update prototypes of emacs_write and emacs_read.
12396
11997c76
EZ
123972011-04-11 Eli Zaretskii <eliz@gnu.org>
12398
12399 * xdisp.c (redisplay_window): Don't try to determine the character
12400 position of the scroll margin if the window start point w->startp
e896f03c 12401 is outside the buffer's accessible region. (Bug#8468)
11997c76 12402
8a2cbd72
EZ
124032011-04-10 Eli Zaretskii <eliz@gnu.org>
12404
12405 Fix write-region and its subroutines for buffers > 2GB.
12406 * fileio.c (a_write, e_write): Modify declaration of arguments and
12407 local variables to support buffers larger than 2GB.
12408 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12409
12410 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12411 argument, local variables, and return value.
12412
12413 * lisp.h: Update prototypes of emacs_write and emacs_read.
12414
12415 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12416
4073e537 124172011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12418
1ebfdcb6
PE
12419 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12420
b2ded58d
PE
12421 Fix more problems found by GCC 4.6.0's static checks.
12422
7d66342c
PE
12423 * xdisp.c (vmessage): Use a better test for character truncation.
12424
bbf47d44
PE
12425 * charset.c (load_charset_map): <, not <=, for optimization,
12426 and to avoid potential problems with integer overflow.
9248994d 12427 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12428 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12429 * editfns.c (Fformat): Likewise.
1e69125e 12430 * syntax.c (skip_chars): Likewise.
3befa583 12431
e3019616
PE
12432 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12433 This also lets GCC 4.6.0 generate slightly better loop code.
12434
becfa255
PE
12435 * callint.c (Fcall_interactively): <, not <=, for optimization.
12436 (Fcall_interactively): Count the number of arguments produced,
12437 not the number of arguments given. This is simpler and lets GCC
12438 4.6.0 generate slightly better code.
12439
dae0cd48
PE
12440 * ftfont.c: Distingish more carefully between FcChar8 and char.
12441 The previous code passed unsigned char * to a functions like
12442 strlen and xstrcasecmp that expect char *, which does not
12443 conform to the C standard.
12444 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12445 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12446 char * when the C standard requires it.
12447
76032d70
PE
12448 * keyboard.c (read_char): Remove unused var.
12449
eb3f1cc8
PE
12450 * eval.c: Port to Windows vsnprintf (Bug#8435).
12451 Include <limits.h>.
12452 (SIZE_MAX): Define if the headers do not.
12453 (verror): Do not give up if vsnprintf returns a negative count.
12454 Instead, grow the buffer. This ports to Windows vsnprintf, which
12455 does not conform to C99. Problem reported by Eli Zaretskii.
12456 Also, simplify the allocation scheme, by avoiding the need for
12457 calling realloc, and removing the ALLOCATED variable.
12458
70476b54
PE
12459 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12460
12020a9e
PE
12461 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12462 But keep the doprint source code for now, as we might revamp it
12463 and use it again (Bug#8435).
ea6c7ae6
PE
12464 * lisp.h (doprnt): Remove.
12465 * Makefile.in (base_obj): Remove doprnt.o.
12466 * deps.mk (doprnt.o): Remove.
12467
5fdb398c
PE
12468 error: Print 32- and 64-bit integers portably (Bug#8435).
12469 Without this change, on typical 64-bit hosts error ("...%d...", N)
12470 was used to print both 32- and 64-bit integers N, which relied on
12471 undefined behavior.
61bdb816 12472 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12473 * lisp.h (error, verror): Mark as printf-like functions.
12474 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12475 Report overflow in size calculations when allocating printf buffer.
12476 Do not truncate output string at its first null byte.
12477 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12478 Truncate the output at a character boundary, since vsnprintf does not
12479 do that.
12480 * charset.c (check_iso_charset_parameter): Convert internal
12481 character to string before calling 'error', since %c now has the
12482 printf meaning.
12483 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12484 overflow when computing char to be passed to 'error'. Do not
12485 pass Lisp_Object to 'error'; pass the integer instead.
12486 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12487 formatted with plain %d.
12488
b189fa66
PE
12489 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12490
bff87ef0
PE
12491 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12492
7e2cac20
PE
12493 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12494
ce4d90b5
PE
12495 * xterm.c (x_catch_errors): Remove duplicate declaration.
12496
266c9547
PE
12497 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12498
79c49ad2
PE
12499 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12500
368f4090
JM
125012011-04-10 Jim Meyering <meyering@redhat.com>
12502
12503 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12504 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12505 return ssize_t not "int", and use size_t as the buffer length.
12506 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12507 * gnutls.h: Update declarations.
12508 * process.c (read_process_output): Use ssize_t, to match.
12509 (send_process): Likewise.
12510
a32d4040
CY
125112011-04-09 Chong Yidong <cyd@stupidchicken.com>
12512
12513 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12514
8546720e 125152011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12516
04f2d78b
CB
12517 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12518 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12519
8546720e
GM
12520 * xterm.c (handle_one_xevent):
12521 * xmenu.c (create_and_show_popup_menu):
12522 * xselect.c (x_decline_selection_request)
12523 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12524
0a2f5c1a 125252011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12526
12527 Fix some uses of `int' instead of EMACS_INT.
12528 * search.c (string_match_1, fast_string_match)
12529 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12530 (scan_buffer, find_next_newline_no_quit)
12531 (find_before_next_newline, search_command, Freplace_match)
12532 (Fmatch_data): Make some `int' variables be EMACS_INT.
12533
12534 * xdisp.c (display_count_lines): 3rd argument and return value now
12535 EMACS_INT. All callers changed.
12536 (pint2hrstr): Last argument is now EMACS_INT.
12537
12538 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12539 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12540 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12541 (decode_coding_utf_16, decode_coding_emacs_mule)
12542 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12543 (decode_coding_ccl, decode_coding_charset)
12544 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12545 (decode_coding_iso_2022, decode_coding_emacs_mule)
12546 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12547 <char_offset, last_offset>: Declare EMACS_INT.
12548 (encode_coding_utf_8, encode_coding_utf_16)
12549 (encode_coding_emacs_mule, encode_invocation_designation)
12550 (encode_designation_at_bol, encode_coding_iso_2022)
12551 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12552 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12553 Declare EMACS_INT.
12554 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12555 (encode_invocation_designation): Last argument P_NCHARS is now
12556 EMACS_INT.
12557 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12558 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12559
12560 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12561 All users changed.
12562
12563 * ccl.c (Fccl_execute_on_string): Declare some variables
12564 EMACS_INT.
12565
8546720e 125662011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12567
12568 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12569
4e19a977
CS
125702011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12571
12572 * process.c (Fformat_network_address): Doc fix.
12573
87302331
R
125742011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12575
ee7683eb 12576 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12577
cbb59342
CY
125782011-04-08 Chong Yidong <cyd@stupidchicken.com>
12579
12580 * keyboard.c (read_char): Call Lisp function help-form-show,
12581 instead of using internal_with_output_to_temp_buffer.
12582 (Qhelp_form_show): New var.
e0d38eeb 12583 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12584
12585 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12586
12587 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12588
e67a13ab
CY
125892011-04-06 Chong Yidong <cyd@stupidchicken.com>
12590
04f2d78b
CB
12591 * process.c (Flist_processes): Remove to Lisp.
12592 (list_processes_1): Delete.
e67a13ab 12593
973f782d
EZ
125942011-04-06 Eli Zaretskii <eliz@gnu.org>
12595
7c106b1e
EZ
12596 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12597
973f782d
EZ
12598 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12599
41cf7d1a 126002011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12601
ca23cc88
PE
12602 Fix more problems found by GCC 4.6.0's static checks.
12603
f390e2d5
PE
12604 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12605
42eea0d0
PE
12606 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12607
b69769da 12608 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12609
f9541e84
PE
12610 * xdisp.c (vmessage): Mark as a printf-like function.
12611
13841b55
PE
12612 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12613
c136c10f
PE
12614 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12615
5e2d4a30
PE
12616 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12617 printf-like functions.
12618 (tiff_load): Add casts to remove these marks before passing them
12619 to system-supplied API.
12620
583f48b9
PE
12621 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12622
b25d760e
PE
12623 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12624 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12625 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12626 directly, rather than having caller test rule sign. This avoids
12627 some unnecessary tests.
12628 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12629 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12630 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12631
bc7b6697 12632 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12633 (xfont_open): Avoid unnecessary tests.
bc7b6697 12634
27ccc379
PE
12635 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12636
dcd5c89a
PE
12637 * composite.h, composite.c (composition_gstring_put_cache):
12638 Use EMACS_INT, not int, for length.
12639
b13a45c6
PE
12640 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12641 breaking out part of COMPOSITION_DECODE_RULE.
12642 (COMPOSITION_DECODE_RULE): Use it.
12643 * composite.c (get_composition_id): Remove unused local vars,
12644 by using the new macro.
12645
1e792e4d
PE
12646 * textprop.c (set_text_properties_1): Change while to do-while,
12647 since the condition is always true at first.
12648
dc6c6455 12649 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12650 (interval_deletion_adjustment): Return unsigned value.
12651 All uses changed.
dc6c6455 12652
aba7731a
PE
12653 * process.c (list_processes_1, create_pty, read_process_output):
12654 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12655 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12656 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12657 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12658 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12659
fdfc4bf3
PE
12660 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12661
fca8fe46 12662 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12663 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12664
06a0259a 12665 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12666 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12667 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12668
e7b9e80f
PE
12669 * print.c (print_error_message): Avoid int overflow.
12670
56201685
PE
12671 * font.c (font_list_entities): Redo for clarity,
12672 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12673
78834453 12674 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12675 (font_score): Avoid potential overflow in diff calculation.
78834453 12676
0bc0b309 12677 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12678 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12679
e610eaca
PE
12680 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12681
b895abce
PE
12682 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12683 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12684 can always succeed if overflow has undefined behavior.
12685
1f1d9321 12686 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12687 (wordify): Omit three unnecessary tests.
1f1d9321 12688
c59478bc
PE
12689 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12690 All callers changed. This avoids the need for an unused var.
12691
79b73827
PE
12692 * casefiddle.c (casify_region): Remove var that is set but not used.
12693
a4db5dfe
PE
12694 * dired.c (file_name_completion): Remove var that is set but not used.
12695
43aae36e
PE
12696 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12697
2a47c44d 12698 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12699 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12700
a37c69bf
PE
12701 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12702 Check for integer overflow on size calculations.
12703
328ab8e7
PE
12704 * buffer.c (Fprevious_overlay_change): Remove var that is set
12705 but not used.
12706
e5a2a5cb
PE
12707 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12708 Remove vars that are set but not used.
8d84a6eb 12709 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12710 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12711
a60e5f68
PE
12712 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12713
f661cb61 12714 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12715 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12716
f0397f5a
PE
12717 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12718 that are set but not used.
12719
8664db06 12720 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12721 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12722
6abdaa4a
PE
12723 * xselect.c (x_get_local_selection, x_handle_property_notify):
12724 Remove vars that are set but not used.
12725
0ce7538d 12726 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12727 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12728
9ae848fc
PE
12729 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12730 Remove var that is set but not used.
0b918413
PE
12731 (scroll_bar_windows_size): Now size_t, not int.
12732 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12733 Check for overflow.
9ae848fc 12734
a5a62657
PE
12735 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12736 (map_tty_color) [!defined MSDOS]: Likewise.
12737
5c5cdd39
PE
12738 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12739
66ebf983
PE
12740 * coding.c: Remove vars that are set but not used.
12741 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12742 All callers changed.
12743 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12744 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12745 (decode_coding_charset): Remove vars that are set but not used.
12746
1be4d761
PE
12747 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12748 that is set but not used.
12749
47553fa8
PE
12750 * print.c (print_object): Remove var that is set but not used.
12751
1f7196bf 12752 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12753 The gnulib version avoids calling malloc in the usual case,
12754 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12755 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12756 * filelock.c (current_lock_owner): Likewise.
12757 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12758 * sysdep.c: Include allocator.h, careadlinkat.h.
12759 (emacs_no_realloc_allocator): New static constant.
12760 (emacs_readlink): New function.
fdb61804
PE
12761 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12762 ../lib/careadlinkat.h.
d1fdcab7 12763
f84c17c7
SM
127642011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12765
12766 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12767 first non-nil return value).
12768
ef3862ad
JD
127692011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12770
12771 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12772 if not defined (Bug#8403).
12773
376a7006
JB
127742011-04-02 Juanma Barranquero <lekktu@gmail.com>
12775
12776 * xdisp.c (display_count_lines): Remove parameter `start',
12777 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12778 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12779 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12780 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12781 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12782 and thereabouts. All callers changed.
12783 (get_per_char_metric): Remove parameter `f', unused since
12784 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12785
6ca3801d
JM
127862011-04-02 Jim Meyering <meyering@redhat.com>
12787
12788 do not dereference NULL upon failed strdup
12789 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12790 (ns_get_family): Likewise.
12791
d8e2b5ba
JB
127922011-04-02 Juanma Barranquero <lekktu@gmail.com>
12793
12794 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12795
8c74fcbd
JD
127962011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12797
12798 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12799 later (Bug#8403).
12800
7200d79c
SM
128012011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12802
03408648 12803 Add lexical binding.
7200d79c 12804
03408648
SM
12805 * window.c (Ftemp_output_buffer_show): New fun.
12806 (Fsave_window_excursion):
12807 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12808
12809 * lread.c (lisp_file_lexically_bound_p): New function.
12810 (Fload): Bind Qlexical_binding.
12811 (readevalloop): Remove `evalfun' arg.
12812 Bind Qinternal_interpreter_environment.
12813 (Feval_buffer): Bind Qlexical_binding.
12814 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12815 Mark as dynamic.
12816 (syms_of_lread): Declare `lexical-binding'.
12817
12818 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12819
12820 * keyboard.c (eval_dyn): New fun.
12821 (menu_item_eval_property): Use it.
ca105506
SM
12822
12823 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12824
03408648
SM
12825 * fns.c (concat, mapcar1): Accept byte-code-functions.
12826
12827 * eval.c (Fsetq): Handle lexical vars.
12828 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12829 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12830 (FletX, Flet): Obey lexical binding.
12831 (Fcommandp): Handle closures.
12832 (Feval): New `lexical' arg.
12833 (eval_sub): New function extracted from Feval. Use it almost
12834 everywhere where Feval was used. Look up vars in lexical env.
12835 Handle closures.
12836 (Ffunctionp): Move from subr.el.
12837 (Ffuncall): Handle closures.
12838 (apply_lambda): Remove `eval_flags'.
12839 (funcall_lambda): Handle closures and new byte-code-functions.
12840 (Fspecial_variable_p): New function.
12841 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12842 but without exporting it to Lisp.
23aba0ea 12843
23aba0ea 12844 * doc.c (Fdocumentation, store_function_docstring):
03408648 12845 * data.c (Finteractive_form): Handle closures.
23aba0ea 12846
03408648
SM
12847 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12848 interactive spec.
ba83908c 12849
04f2d78b
CB
12850 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12851 New byte-codes.
03408648
SM
12852 (exec_byte_code): New function extracted from Fbyte_code to handle new
12853 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12854
03408648 12855 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12856
03408648 12857 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12858
e2abce01
JB
128592011-03-31 Juanma Barranquero <lekktu@gmail.com>
12860
12861 * xdisp.c (redisplay_internal): Fix prototype.
12862
63696a73 128632011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12864
63696a73 12865 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12866 (try_scrolling): Use it when setting scroll_limit.
12867 Limit scrolling to 100 screen lines.
63696a73
EZ
12868 (redisplay_window): Even when falling back on "recentering",
12869 position point in the window according to scroll-conservatively,
12870 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12871
12872 (try_scrolling): When point is above the window, allow searching
12873 as far as scroll_max, or one screenful, to compute vertical
12874 distance from PT to the scroll margin position. This prevents
12875 try_scrolling from unnecessarily failing when
12876 scroll-conservatively is set to a value slightly larger than the
12877 window height. Clean up the case of PT below the margin at bottom
12878 of window: scroll_max can no longer be INT_MAX. When aggressive
12879 scrolling is in use, don't let point enter the opposite scroll
12880 margin as result of the scroll.
12881 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12882 threshold of 100 lines for never-recentering scrolling.
12883
e4cc2dfc
JB
128842011-03-31 Juanma Barranquero <lekktu@gmail.com>
12885
12886 * dispextern.h (move_it_by_lines):
12887 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12888 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12889 (message_log_check_duplicate): Remove parameters `prev_bol' and
12890 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12891 (redisplay_internal): Remove parameter `preserve_echo_area',
12892 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12893
12894 * indent.c (Fvertical_motion):
12895 * window.c (window_scroll_pixel_based, Frecenter):
12896 Don't pass `need_y_p' to `move_it_by_lines'.
12897
1c470562
SM
128982011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12899
44f230aa
SM
12900 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12901 steal a few bits to be more compact.
12902 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12903 Remove unneeded casts.
12904
1c470562
SM
12905 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12906
888adce9
ZK
129072011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12908
12909 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12910 binding" message (bug#7967).
12911
f838ed7b
PE
129122011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12913
77861b95
PE
12914 Fix more problems found by GCC 4.6.0's static checks.
12915
de6dbc14
PE
12916 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12917 Remove unused local var.
12918
f838ed7b
PE
12919 * editfns.c (Fmessage_box): Remove unused local var.
12920
792c7b2b
PE
12921 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12922 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12923 Omit unused local vars.
c499e557 12924 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12925 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12926 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12927 Omit unused local var.
12928
ba0165e1
PE
12929 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12930 Don't assume string length fits in int.
32ad8845 12931 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12932 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12933
3c59b4c9
PE
12934 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12935 instead of alloca (Bug#8344).
12936
a3eed478 12937 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12938 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12939
eb4d412d
PE
12940 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12941
1658b401
PE
12942 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12943 concerns.
12944
12945 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12946
12947 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12948
9a2c6e05
PE
12949 * keyboard.c (syms_of_keyboard): Use the same style as later
12950 in this function when indexing through an array. This also
12951 works around GCC bug 48267.
12952
03d0a109
PE
12953 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12954
44f730c8
PE
12955 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12956
fe75f926
PE
12957 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12958 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12959
ffa8c828
PE
12960 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12961 This avoids undefined behavior on integer overflow, and is a bit
12962 more convenient anyway since it is compared to a size_t variable.
12963
c5101a77
PE
12964 Variadic C functions now count arguments with size_t, not int.
12965 This avoids an unnecessary limitation on 64-bit machines, which
12966 caused (substring ...) to crash on large vectors (Bug#8344).
12967 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12968 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12969 All variadic functions and their callers changed accordingly.
c5101a77
PE
12970 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12971 * data.c (arith_driver, float_arith_driver): Likewise.
12972 * editfns.c (general_insert_function): Likewise.
12973 * eval.c (struct backtrace.nargs, interactive_p)
12974 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12975 (funcall_lambda, mark_backtrace): Likewise.
12976 * fns.c (concat): Likewise.
12977 * frame.c (x_set_frame_parameters): Likewise.
12978 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12979 0 if not found, not -1. All callers changed.
12980
dd3f25f7
PE
12981 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12982 (stack_copy_size): Now size_t, not int.
12983 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12984
461c2ab9
JB
129852011-03-28 Juanma Barranquero <lekktu@gmail.com>
12986
12987 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12988 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12989 All callers changed.
12990
12991 * lisp.h (multibyte_char_to_unibyte):
12992 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12993 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12994 * character.h (CHAR_TO_BYTE8):
12995 * cmds.c (internal_self_insert):
12996 * editfns.c (general_insert_function):
12997 * keymap.c (push_key_description):
12998 * search.c (Freplace_match):
12999 * xdisp.c (message_dolog, set_message_1): All callers changed.
13000
f6d62986
SM
130012011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13002
13003 * keyboard.c (safe_run_hook_funcall): New function.
13004 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13005 don't set the hook to nil, but remove the offending function instead.
13006 (Qcommand_hook_internal): Remove, unused.
13007 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13008 Vcommand_hook_internal.
13009
13010 * eval.c (enum run_hooks_condition): Remove.
13011 (funcall_nil, funcall_not): New functions.
13012 (run_hook_with_args): Call each function through a `funcall' argument.
13013 Remove `cond' argument, now redundant.
13014 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13015 (Frun_hook_with_args_until_failure): Adjust accordingly.
13016 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13017
1db5b1ad
JB
130182011-03-28 Juanma Barranquero <lekktu@gmail.com>
13019
13020 * dispextern.h (string_buffer_position): Remove declaration.
13021
13022 * print.c (strout): Remove parameter `multibyte', unused since
13023 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13024
13025 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13026 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13027 All callers changed.
13028
13029 * w32.c (_wsa_errlist): Use braces for struct initializers.
13030
13031 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13032 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13033 All callers changed.
13034 (string_buffer_position): Likewise. Also, make static (it's never
13035 used outside xdisp.c).
13036 (cursor_row_p): Remove parameter `w', unused since
13037 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13038 (decode_mode_spec): Remove parameter `precision', introduced during
13039 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13040 All callers changed.
13041
5ffb62aa
JD
130422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13043
13044 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13045
461c2ab9 130462011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13047
13048 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13049 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13050 (ns_update_auto_hide_menu_bar): New functions.
13051 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13052 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13053 ns_constrain_all_frames.
13054 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13055 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13056
5c380ffb
JD
130572011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13058
13059 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13060
9af30bdf
GM
130612011-03-27 Glenn Morris <rgm@gnu.org>
13062
13063 * syssignal.h: Replace RETSIGTYPE with void.
13064 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13065 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13066 Replace SIGTYPE with void everywhere.
13067 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13068 * s/template.h (SIGTYPE): Remove commented out definition.
13069
e2abce01
JB
130702011-03-26 Eli Zaretskii <eliz@gnu.org>
13071
13072 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13073 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13074
f868cd8a
JB
130752011-03-26 Juanma Barranquero <lekktu@gmail.com>
13076
59eb0929
JB
13077 * w32.c (read_unc_volume): Use parameter `henum', instead of
13078 global variable `wget_enum_handle'.
13079
13080 * keymap.c (describe_vector): Remove parameters `indices' and
13081 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13082 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13083
f868cd8a
JB
13084 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13085
13086 * keyboard.c (timer_check): Remove parameter `do_it_now',
13087 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13088 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13089 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13090
13091 * keyboard.c (read_char):
13092 * w32menu.c (w32_menu_display_help):
13093 * xmenu.c (show_help_event, menu_help_callback):
13094 Adjust calls to `show_help_echo'.
13095
13096 * gtkutil.c (xg_maybe_add_timer):
13097 * keyboard.c (readable_events):
13098 * process.c (wait_reading_process_output):
13099 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13100
13101 * insdel.c (adjust_markers_gap_motion):
13102 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13103 (gap_left, gap_right): Don't call it.
13104
2ecf6fdb
CY
131052011-03-25 Chong Yidong <cyd@stupidchicken.com>
13106
13107 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13108 incurred during fontification.
13109
6b1f9ba4
JB
131102011-03-25 Juanma Barranquero <lekktu@gmail.com>
13111
13112 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13113 (DEFVAR_PER_BUFFER): Don't pass it.
13114
13115 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13116 (scrolling_window): Don't pass it.
13117
0f4a96b5
JB
131182011-03-25 Juanma Barranquero <lekktu@gmail.com>
13119
13120 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13121
13122 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13123 and `suffix'.
13124 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13125 of variables specific to SELinux and computation of `encoded_absname'.
13126
13127 * image.c (XPutPixel): Remove unused variable `height'.
13128
13129 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13130
13131 * unexw32.c (get_section_info): Remove unused variable `section'.
13132
13133 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13134 (system_process_attributes): Remove unused variable `sess'.
13135 (sys_read): Remove unused variable `err'.
13136
13137 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13138 (w32_wnd_proc): Remove unused variable `isdead'.
13139 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13140 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13141 (x_create_tip_frame): Remove unused variable `tem'.
13142
13143 * w32inevt.c (w32_console_read_socket):
13144 Remove unused variable `no_events'.
13145
13146 * w32term.c (x_draw_composite_glyph_string_foreground):
13147 Remove unused variable `width'.
13148
1149507c
JB
131492011-03-24 Juanma Barranquero <lekktu@gmail.com>
13150
13151 * w32term.c (x_set_glyph_string_clipping):
13152 Don't pass uninitialized region to CombineRgn.
13153
9c88f339
JB
131542011-03-23 Juanma Barranquero <lekktu@gmail.com>
13155
13156 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13157 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13158 (Fx_close_connection): Remove unused variable `i'.
13159
13160 * w32font.c (w32font_draw): Return number of glyphs.
13161 (w32font_open_internal): Remove unused variable `i'.
13162 (w32font_driver): Add missing initializer.
13163
13164 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13165 (fill_in_menu): Remove unused variable `items_added'.
13166
13167 * w32term.c (last_mouse_press_frame): Remove static global variable.
13168 (w32_clip_to_row): Remove unused variable `f'.
13169 (x_delete_terminal): Remove unused variable `i'.
13170
13171 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13172 (NOTHING): Remove unused static global variable.
13173 (uniscribe_check_otf): Remove unused variable `table'.
13174 (uniscribe_font_driver): Add missing initializers.
13175
dee091a3
JD
131762011-03-23 Julien Danjou <julien@danjou.info>
13177
13178 * term.c (Fsuspend_tty, Fresume_tty):
13179 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13180 * window.c (temp_output_buffer_show):
13181 * insdel.c (signal_before_change):
13182 * frame.c (Fhandle_switch_frame):
13183 * fileio.c (Fdo_auto_save):
13184 * emacs.c (Fkill_emacs):
13185 * editfns.c (save_excursion_restore):
13186 * cmds.c (internal_self_insert):
13187 * callint.c (Fcall_interactively):
13188 * buffer.c (Fkill_all_local_variables):
13189 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13190 Use Frun_hooks.
0f4a96b5 13191 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13192 unconditionally since it does the check itself.
dee091a3 13193
2c520ab5 131942011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13195
c9c49752
PE
13196 Fix more problems found by GCC 4.5.2's static checks.
13197
8abc3f12
PE
13198 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13199 the first time through the loop, since we know p0 < p1 then.
13200 This also avoids a gcc -Wstrict-overflow warning.
13201
a2d26660
PE
13202 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13203 leading to a memory leak, possible in functions like
13204 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13205 of objects (Bug#8318).
a2d26660 13206
916c72e9
PE
13207 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13208 that could (at least in theory) be that large.
13209
19ab8a18
PE
13210 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13211 This is less likely to overflow, and avoids undefined behavior if
13212 overflow does occur. All callers changed. Use strtoul to scan
13213 for the unsigned long integer.
b7cbbd6f
PE
13214 (pint2hrstr): Simplify and tune code slightly.
13215 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13216
f0641eff
PE
13217 * scroll.c (do_scrolling): Work around GCC bug 48228.
13218 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13219
7f650bb9
PE
13220 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13221 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13222 (validate_x_resource_name): Simplify count usage.
13223 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13224
37dd57d1
PE
13225 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13226 fail (Bug#8306).
81e56e61 13227
699979fc 13228 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13229
401bf9b4
PE
13230 * process.c (Fmake_network_process): Use socklen_t, not int,
13231 where POSIX says socklen_t is required in portable programs.
13232 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13233 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13234 (Fmake_network_process, server_accept_connection):
13235 (wait_reading_process_output, read_process_output):
13236 Likewise.
13237
b93aacde
PE
13238 * process.c: Rename or move locals to avoid shadowing.
13239 (list_processes_1, Fmake_network_process):
13240 (read_process_output_error_handler, exec_sentinel_error_handler):
13241 Rename or move locals.
4dc343ee 13242 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13243 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13244 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13245 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13246 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13247
af8a867c 13248 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13249 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13250 Include tparam.h instead, since it declares them.
af8a867c
PE
13251 * cm.h (PC): Remove extern decl; tparam.h now does this.
13252 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13253 * terminfo.c: Include tparam.h, to check interfaces.
13254 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13255 (tparam): Adjust signature to match interface in tparam.h;
13256 this removes some undefined behavior. Check that outstring and len
13257 are zero, which they always are with Emacs.
13258 * tparam.h (PC, BC, UP): New extern decls.
13259
0248044d 13260 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13261 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13262
8ff096c1 13263 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13264 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13265 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13266 (ftfont_list): Remove unused local.
49eaafba
PE
13267 (get_adstyle_property, ftfont_pattern_entity):
13268 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13269 Rename locals to avoid shadowing.
8ff096c1 13270
e2be39f6
PE
13271 * xfont.c (xfont_list_family): Mark var as initialized.
13272
c9735e30
PE
13273 * xml.c (make_dom): Now static.
13274
8f5201ae
PE
13275 * composite.c (composition_compute_stop_pos): Rename local to
13276 avoid shadowing.
b246f932
PE
13277 (composition_reseat_it): Remove unused locals.
13278 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13279 (composition_update_it): Mark var as initialized.
11b61122
PE
13280 (find_automatic_composition): Mark vars as initialized,
13281 with a FIXME (Bug#8290).
8f5201ae 13282
760fbc2c
PE
13283 character.h: Rename locals to avoid shadowing.
13284 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13285 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13286 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13287 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13288 to avoid shadowing.
13289
ff08eb85
PE
13290 * textprop.c (property_change_between_p): Remove; unused.
13291
fc7bf025
PE
13292 * intervals.c (interval_start_pos): Now static.
13293
235d7abc
PE
13294 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13295
44f230aa
SM
13296 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13297 Rename locals to avoid shadowing.
3e7d6594 13298
50060332
PE
13299 * sound.c (wav_play, au_play, Fplay_sound_internal):
13300 Fix pointer signedness.
d01f234b 13301 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13302 (wav_play): Initialize a variable to 0, to prevent undefined
13303 behavior (Bug#8278).
50060332 13304
c4fc4e30
PE
13305 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13306
918436ed
PE
13307 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13308
c939f91b
PE
13309 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13310 clobbering (Bug#8298).
b9c7f648
PE
13311 * sysdep.c (sys_subshell): Likewise.
13312 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13313
6bd8c144
PE
13314 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13315 This should get cleaned up, so that child_setup has the
13316 same signature on all platforms.
13317
7710357c 13318 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13319 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13320
c59da222
CY
133212011-03-22 Chong Yidong <cyd@stupidchicken.com>
13322
13323 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13324 not to be necessary, and produces flickering.
13325
66b87493
GM
133262011-03-20 Glenn Morris <rgm@gnu.org>
13327
13328 * config.in: Remove file.
13329
45b6f6d5
JB
133302011-03-20 Juanma Barranquero <lekktu@gmail.com>
13331
13332 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13333 are now in src/globals.h.
13334 (syms_of_minibuf): Remove spurious & from previous change.
13335
cd394be1 133362011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13337
13338 * minibuf.c (completing-read-function): New variable.
13339 (completing-read-default): Rename from completing-read.
13340 (completing-read): Call completing-read-function.
13341
b14e3e21
CY
133422011-03-19 Juanma Barranquero <lekktu@gmail.com>
13343
13344 * xfaces.c (Fx_load_color_file):
13345 Read color file from absolute filename (bug#8250).
13346
f2b726e6
JB
133472011-03-19 Juanma Barranquero <lekktu@gmail.com>
13348
13349 * makefile.w32-in: Update dependencies.
13350
09f6ff02
EZ
133512011-03-17 Eli Zaretskii <eliz@gnu.org>
13352
13353 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13354
29a6015a
PE
133552011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13356
a3a6c54e
PE
13357 Fix more problems found by GCC 4.5.2's static checks.
13358
b766f867
PE
13359 * process.c (make_serial_process_unwind, send_process_trap):
13360 (sigchld_handler): Now static.
13361
be02381c
PE
13362 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13363 That way, the code declares only the vars that it needs.
13364 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13365 * s/cygwin.h (PTY_ITERATION): Likewise.
13366 * s/darwin.h (PTY_ITERATION): Likewise.
13367 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13368
57048744
PE
13369 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13370 * process.c (allocate_pty): Don't declare stb unless it's needed.
13371
7914961c 13372 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13373 (CONSTANTLIM): Remove; unused.
13374 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13375 Define only if needed.
7914961c 13376
b3967b18
PE
13377 * unexelf.c (unexec): Name an expression,
13378 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13379 Use a different way to cause a compilation error if anyone uses
13380 n rather than nn, a way that does not involve shadowing.
73366a00 13381 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13382
29a6015a
PE
13383 * deps.mk (unexalpha.o): Remove; unused.
13384
43cfc33e 13385 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13386 * unexec.h: New file.
ce701a33
PE
13387 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13388 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13389 Depend on unexec.h.
13390 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13391 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13392 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13393 Change as necessary to match prototype in unexec.h.
ce701a33 13394
01f44d5a
PE
13395 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13396 shadowing.
4f63c6bb 13397 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13398
a6670b0b
PE
13399 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13400 Rename locals to avoid shadowing.
13401
cef2010d 13402 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13403 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13404
d4d7173a
PE
13405 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13406
f08b802a
PE
13407 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13408 warning when compiling print.c.
13409
3ddb0639
PE
13410 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13411 instead of using an uninitialized var.
5ad03b97 13412 (font_sort_entities): Mark var as initialized.
3ddb0639 13413
170a2692
PE
13414 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13415
e663c700
PE
13416 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13417 pointers to constants.
89bc529a 13418 (font_parse_fcname): Remove unused vars.
7b81e2d0 13419 (font_delete_unmatched): Now static.
ea838e10 13420 (font_get_spec): Remove; unused.
13a547c6
PE
13421 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13422 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13423 Rename or move locals to avoid shadowing.
e663c700 13424
2a80c887 13425 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13426 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13427
1384fa33 13428 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13429 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13430
8b2c52e9
PE
13431 * alloc.c (mark_backtrace): Move decl from here ...
13432 * lisp.h: ... to here, so that it can be checked.
13433
475545b5 13434 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13435 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13436 (lisp_indirect_variable): Name an expression,
13437 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13438 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13439
b1349114 13440 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13441 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13442 Use const pointer when appropriate.
b1349114 13443
a2928364
PE
13444 * lisp.h (get_system_name, get_operating_system_release):
13445 Move decls here, to check interfaces.
13446 * process.c (get_operating_system_release): Move decl to lisp.h.
13447 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13448 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13449 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13450 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13451 (Fformat_time_string, Fencode_time, Finsert_char):
13452 (Ftranslate_region_internal, Fformat):
13453 Rename or remove local vars to avoid shadowing.
9710023e 13454 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13455
a415e694
PE
13456 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13457 avoid shadowing.
13458
8ef4622d
PE
13459 * lisp.h (eassert): Check that the argument compiles, even if
13460 ENABLE_CHECKING is not defined.
13461
946f9a5b
PE
13462 * data.c (Findirect_variable): Name an expression, to avoid
13463 gcc -Wbad-function-cast warning.
112396d6 13464 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13465 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13466 (Fmake_variable_buffer_local, Fmake_local_variable):
13467 Mark variables as initialized.
52746918 13468 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13469
e5aab7e7 13470 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13471 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13472 Rename locals to avoid shadowing.
dff45157
PE
13473 (mark_stack): Move local variables into the #ifdef region where
13474 they're used.
7bc26fdb
PE
13475 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13476 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13477 needed otherwise.
13478 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13479 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13480 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13481
e5aab7e7
PE
13482 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13483 avoids undefined behavior in theory.
13484
4da60324
PE
13485 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13486
88043301
PE
13487 Use functions, not macros, for up- and down-casing (Bug#8254).
13488 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13489 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13490 to use the following functions instead of these macros.
13491 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13492 EMACS_INT, since callers assume the returned value fits in int.
13493 (upcase1): Likewise, for UPCASE_TABLE.
13494 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13495 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13496 the race-condition problem in the old DOWNCASE.
88043301 13497
19ed5445
PE
13498 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13499 Rename locals to avoid shadowing.
13500 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13501 (regex_compile, re_search_2, re_match_2_internal):
13502 Remove unused local vars.
952db0d7
PE
13503 (FREE_VAR): Rewrite so as not to use empty "else",
13504 which gcc can warn about.
da053e48 13505 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13506 (RETALLOC_IF): Define only if needed.
13507 (WORDCHAR_P): Likewise. This one is never needed, but is used
13508 only in a comment talking about a compiler bug, so put inside
13509 the #if 0 of that comment.
13510 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13511 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13512 Remove; unused.
19ed5445 13513
1f3561e4 13514 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13515 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13516 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13517
ded6f8f7
PE
13518 * search.c (simple_search): Remove unused var.
13519
dbd37a95
PE
13520 * dired.c (compile_pattern): Move decl from here ...
13521 * lisp.h: ... to here, so that it can be checked.
13522 (struct re_registers): New forward decl.
13523
7e47afad
PE
13524 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13525
85f24f61
PE
13526 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13527 All uses changed.
13528 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13529 Rename locals to avoid shadowing.
5671df8f 13530 (Fvertical_motion): Mark locals as initialized.
85f24f61 13531
181aa2be 13532 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13533 (casify_region): Mark local as initialized.
181aa2be 13534
930d429c
PE
13535 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13536
7082eac6
PE
13537 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13538 New macros, so that the caller can use some names other than
13539 gcpro1, gcpro2, etc.
13540 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13541 of the new macros.
13542 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13543 argument, for consistency with GCPRO2_VAR, etc: it is now the
13544 prefix of the variable, not the variable itself. All uses
13545 changed.
38b2c076
PE
13546 * dired.c (directory_files_internal, file_name_completion):
13547 Rename locals to avoid shadowing.
13548
15206ed9
PE
13549 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13550 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13551 dired.c's scmp function, had undefined behavior.
13552 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13553 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13554 * buffer.h: ... to here, because these macros use current_buffer,
13555 and the new implementation with inline functions needs to have
13556 current_buffer in scope now, rather than later when the macros
13557 are used.
13558 (downcase, upcase1): New static inline functions.
13559 (DOWNCASE, UPCASE1): Reimplement using these functions.
13560 This avoids undefined behavior in expressions like
13561 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13562 from race conditions in accessing the global variables
13563 case_temp1 and case_temp2.
13564 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13565 * lisp.h (case_temp1, case_temp2): Remove their decls.
13566 * character.h (ASCII_CHAR_P): Move from here ...
13567 * lisp.h: ... to here, so that the inline functions mentioned
13568 above can use them.
13569
4a6bea26
PE
13570 * dired.c (directory_files_internal_unwind): Now static.
13571
f14b7e14
PE
13572 * fileio.c (file_name_as_directory, directory_file_name):
13573 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13574 Now static.
2893f146
PE
13575 (file_name_as_directory): Use const pointers when appropriate.
13576 (Fexpand_file_name): Likewise. In particular, newdir might
13577 point at constant storage, so make it a const pointer.
fd4ead52 13578 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13579 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13580 signedness issues.
f839df0c
PE
13581 (Fset_file_times, Finsert_file_contents, auto_save_error):
13582 Rename locals to avoid shadowing.
f14b7e14 13583
5716756e 13584 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13585 (Ftry_completion, Fall_completions): Rename or remove locals
13586 to avoid shadowing.
5716756e 13587
b4c3046a
PE
13588 * marker.c (bytepos_to_charpos): Remove; unused.
13589
b45db522
PE
13590 * lisp.h (verify_bytepos, count_markers): New decls,
13591 so that gcc does not warn that these functions aren't declared.
13592
85876d07
PE
13593 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13594 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13595 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13596 (copy_text): Remove unused local var.
85876d07 13597
03d78a21 13598 * filelock.c (within_one_second): Now static.
b3dd38ab 13599 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13600
5df8f01b
PE
13601 * buffer.c (fix_overlays_before): Mark locals as initialized.
13602 (fix_start_end_in_overlays): Likewise. This function should be
13603 simplified by using pointers-to-pointers, but that's a different
13604 matter.
b1d876f1 13605 (switch_to_buffer_1): Now static.
8f54f30a
PE
13606 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13607 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13608
a70072c9 13609 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13610 Fix pointer signedness issue.
edced198
PE
13611 (sys_subshell): Mark local as volatile if checking for lint,
13612 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13613 (MAXPATHLEN): Define only if needed.
a70072c9 13614
a0977c44
PE
13615 * process.c (serial_open, serial_configure): Move decls from here ...
13616 * systty.h: ... to here, so that they can be checked.
13617
a884fdcc
PE
13618 * fns.c (get_random, seed_random): Move extern decls from here ...
13619 * lisp.h: ... to here, so that they can be checked.
13620
604efe86 13621 * sysdep.c (reset_io): Now static.
b8950c94 13622 (wait_for_termination_signal): Remove; unused.
604efe86 13623
38fc62d9
PE
13624 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13625 (copy_keymap_item, append_key, push_text_char_description):
13626 Now static.
1004a21a 13627 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13628 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13629 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13630 (describe_map_tree):
13631 Rename locals to avoid shadowing.
38fc62d9 13632
2f2650da
PE
13633 * keyboard.c: Declare functions static if they are not used elsewhere.
13634 (echo_char, echo_dash, cmd_error, top_level_2):
13635 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13636 (read_char, kbd_buffer_get_event, make_lispy_position):
13637 (make_lispy_event, make_lispy_movement, apply_modifiers):
13638 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13639 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13640 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13641 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13642 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13643
a053e86c 13644 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13645 (mark_kboards): Move decl here ...
13646 * alloc.c (mark_kboards): ... from here.
a053e86c 13647
4752793e
PE
13648 * lisp.h (force_auto_save_soon): New decl.
13649
74f10ca7 13650 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13651 (DEFINE_DUMMY_FUNCTION): New macro.
13652 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13653 Use it.
c03cd23f
PE
13654 (main): Add casts to avoid warnings
13655 if GCC considers string literals to be constants.
74f10ca7 13656
022e70d4
PE
13657 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13658
59d6fe83
PE
13659 * dbusbind.c: Pointer signedness fixes.
13660 (xd_signature, xd_append_arg, xd_initialize):
13661 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13662 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13663 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13664 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13665
78320123
PE
13666 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13667 if GCC considers string literals to be constants.
49cebcca 13668 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13669
35ac2a97
SM
136702011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13671
fb103ca9
SM
13672 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13673 (print_preprocess, print_object): New macro to fix last change.
13674
35ac2a97
SM
13675 * print.c (print_preprocess): Don't forget font objects.
13676
62973b41
JB
136772011-03-16 Juanma Barranquero <lekktu@gmail.com>
13678
13679 * emacs.c (USAGE3): Doc fixes.
13680
0e48bb22
AS
136812011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13682
13683 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13684 structure.
13685
7684e57b
JB
136862011-03-14 Juanma Barranquero <lekktu@gmail.com>
13687
13688 * lisp.h (VWindow_system, Qfile_name_history):
13689 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13690 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13691 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13692
13693 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13694 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13695
13696 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13697 * w32console.c (detect_input_pending, read_input_pending)
13698 (encode_terminal_code):
13699 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13700 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13701 (w32_system_caret_y, Qfile_name_history):
13702 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13703 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13704 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13705 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13706 * w32proc.c (Qlocal, report_file_error):
13707 * w32term.c (Vwindow_system, updating_frame):
13708 * w32uniscribe.c (initialized, uniscribe_font_driver):
13709 Remove unneeded extern declarations.
13710
2aa46d6c
CY
137112011-03-14 Chong Yidong <cyd@stupidchicken.com>
13712
c96bbc66 13713 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13714
cffc6f3b
CY
137152011-03-13 Chong Yidong <cyd@stupidchicken.com>
13716
13717 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13718 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13719 These macros can no longer be used for assignment.
13720
44f230aa
SM
13721 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13722 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13723 (record_buffer_markers, fetch_buffer_markers): New functions for
13724 recording and fetching special buffer markers.
13725 (set_buffer_internal_1, set_buffer_temp): Use them.
13726
13727 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13728
13729 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13730
13731 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13732 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13733
13734 * xdisp.c (hscroll_window_tree):
13735 (reconsider_clip_changes): Use PT instead of BUF_PT.
13736
d251f04b
EZ
137372011-03-13 Eli Zaretskii <eliz@gnu.org>
13738
13739 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13740 $(EMACS_ROOT)/lib/intprops.h.
13741
f0c77cd1
PE
137422011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13743
3eca4629
PE
13744 Fix more problems found by GCC 4.5.2's static checks.
13745
7c86ee98
PE
13746 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13747 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13748 (xg_free_frame_widgets): Make it clear that a local variable is
13749 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13750 (gdk_window_get_screen): Make it clear that this macro is needed
13751 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13752 (int_gtk_range_get_value): New function, which avoids a diagnostic
13753 from gcc -Wbad-function-cast.
13754 (xg_set_toolkit_scroll_bar_thumb): Use it.
13755 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13756 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13757 (get_utf8_string, xg_get_file_with_chooser):
13758 Rename locals to avoid shadowing.
13759 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13760
41729b81
PE
13761 * xgselect.c (xg_select): Remove unused var.
13762
f0c77cd1
PE
13763 * image.c (four_corners_best): Mark locals as initialized.
13764 (gif_load): Initialize transparent_p to zero (Bug#8238).
13765 Mark another local as initialized.
ec6cf4c6 13766 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13767
ce0ad53d 13768 * image.c (clear_image_cache): Now static.
d5d5a617 13769 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13770 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13771 (x_edge_detection): Remove unnecessary cast that
13772 gcc -Wbad-function-cast diagnoses.
2037898d 13773 (gif_load): Fix pointer signedness.
6ae141d6
PE
13774 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13775 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13776
33383987 137772011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13778
d32df629
PE
13779 Improve quality of tests for time stamp overflow.
13780 For example, without this patch (encode-time 0 0 0 1 1
13781 1152921504606846976) returns the obviously-bogus value (-948597
13782 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13783 reports time overflow. See
13784 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13785 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13786 * editfns.c: Include limits.h and intprops.h.
13787 (TIME_T_MIN, TIME_T_MAX): New macros.
13788 (time_overflow): Move earlier, to before first use.
13789 (hi_time, lo_time): New functions, for an accurate test for
13790 out-of-range times.
13791 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13792 (Fget_internal_run_time): Don't assume time_t fits in int.
13793 (make_time): Use list2 instead of Fcons twice.
13794 (Fdecode_time): More accurate test for out-of-range times.
13795 (check_tm_member): New function.
13796 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13797 (lisp_time_argument): Don't rely on undefined left-shift and
13798 right-shift behavior when checking for time stamp overflow.
8be6f318 13799
fe31d94c
PE
13800 * editfns.c (time_overflow): New function, refactoring common code.
13801 (Fformat_time_string, Fdecode_time, Fencode_time):
13802 (Fcurrent_time_string): Use it.
13803
8be6f318
PE
13804 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13805 * dired.c (make_time): Move to ...
13806 * editfns.c (make_time): ... here.
13807 * systime.h: Note the move.
13808
09d9db2c 138092011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13810
126bc0dc
YM
13811 * fringe.c (update_window_fringes): Remove unused variables.
13812
c47cbdfd
YM
13813 * unexmacosx.c (copy_data_segment): Also copy __got section.
13814 (Bug#8223)
13815
7ac80be9
EZ
138162011-03-12 Eli Zaretskii <eliz@gnu.org>
13817
c96bbc66 13818 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13819 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13820 Constify `char *' arguments and their references according to
13821 prototypes in tparam.h.
13822
ecb0f94d 13823 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13824
7ac80be9
EZ
13825 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13826 Adapt all references accordingly.
13827
13828 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13829
ef1fd07e
TT
138302011-03-11 Tom Tromey <tromey@redhat.com>
13831
13832 * buffer.c (syms_of_buffer): Remove obsolete comment.
13833
7ef4b50c
EZ
138342011-03-11 Eli Zaretskii <eliz@gnu.org>
13835
13836 * termhooks.h (encode_terminal_code): Declare prototype.
13837
13838 * msdos.c (encode_terminal_code): Don't declare prototype.
13839
13840 * term.c (encode_terminal_code): Now external again, used by
13841 w32console.c and msdos.c.
13842
44f230aa
SM
13843 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13844 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13845
4b1ec863 138462011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13847
1714f52b 13848 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13849
4b1ec863
PE
13850 * fringe.c (update_window_fringes): Mark locals as initialized
13851 (Bug#8227).
13852 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13853
524c7aa6
PE
13854 * alloc.c (mark_fringe_data): Move decl from here ...
13855 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13856 to check its interface.
13857 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13858
a5c0af81 13859 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13860 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13861 (fontset_font): Mark local as initialized.
a9a06e0b 13862 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13863
b4716021
PE
13864 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13865
811e9bac 13866 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13867 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13868 (x_own_selection, Fx_disown_selection_internal): Rename locals
13869 to avoid shadowing.
13870 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13871
7e3ab302
PE
13872 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13873 so that the caller can use some name other than gcpro1.
13874 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13875 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13876 (Fx_backspace_delete_keys_p):
13877 Use them to avoid shadowing, and rename vars to avoid shadowing.
13878 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13879 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13880 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13881 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13882 Remove unused locals.
7e3ab302
PE
13883 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13884 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13885 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13886 macros.
f78faa98 13887
e2b13473
PE
13888 * xterm.h (x_mouse_leave): New decl.
13889
77f23912
PE
13890 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13891 Remove unused functions.
cdf4ba58
PE
13892 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13893 (x_calc_absolute_position): Now static.
7411c686 13894 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13895 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13896 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13897 unless they are used.
38d0b34a
PE
13898 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13899 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13900 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13901 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13902 (x_error_catcher, x_connection_closed, x_error_handler):
13903 (x_error_quitter, xembed_send_message, x_iconify_frame):
13904 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13905 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13906 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13907
44f230aa
SM
13908 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13909 Rename or move locals to avoid shadowing.
6b463e58 13910 (tty_defined_color, merge_face_heights): Now static.
5967d051 13911 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13912 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13913 does not deduce is never used uninitialized.
73719eba
PE
13914 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13915 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13916
426994c3 13917 * terminal.c (store_terminal_param): Now static.
5489860b 13918
032f1620 13919 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13920 (set_frame_menubar): Remove unused local.
d4323972 13921 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13922 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13923 since they might point to immutable storage.
281585b0
PE
13924 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13925 since it's unused otherwise.
032f1620 13926
367c19e5 13927 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13928 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13929 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13930 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13931 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13932 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13933 does not deduce are never used uninitialized.
70739cbe 13934
07b48fa9
PE
13935 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13936
8868a238 13937 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13938 * window.c (window_loop, size_window):
13939 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13940
7e5cf297 13941 * window.c (display_buffer): Now static.
d6550a9f
PE
13942 (size_window): Mark variables that gcc -Wuninitialized
13943 does not deduce are never used uninitialized.
a586633d
PE
13944 * window.h (check_all_windows): New decl, to forestall
13945 gcc -Wmissing-prototypes diagnostic.
5b555da1 13946 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13947
f6095868
PE
13948 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13949 shadowing.
13950 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13951 Include <limits.h>.
13952 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13953 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13954 (load_charset_map): Mark variables that gcc -Wuninitialized
13955 does not deduce are never used uninitialized.
53df7c11 13956 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13957
f38b440c
PE
13958 * coding.c (coding_set_source, coding_set_destination):
13959 Use "else { /* comment */ }" rather than "else /* comment */;"
13960 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13961 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13962 a block, when the outer 'i' will do.
13963 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13964 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13965 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13966 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13967 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13968 Rename locals to avoid shadowing.
13969 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13970 * coding.c (emacs_mule_char, encode_invocation_designation):
13971 Now static, since they're not used elsewhere.
413bb2db 13972 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13973 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13974 (decode_coding_emacs_mule): Mark variables that gcc
13975 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13976 (detect_coding_iso_2022): Initialize a local variable that might
13977 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13978 this initialization is needed. (Bug#8211)
5f58e762
PE
13979 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13980 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13981 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13982 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13983 Remove unused macros.
f38b440c 13984
232b38b9 13985 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13986 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13987 * character.c (string_count_byte8): Likewise.
232b38b9 13988
fb90da1b
PE
13989 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13990 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13991
fb93dbc2
PE
13992 * chartab.c (copy_sub_char_table): Now static, since it's not used
13993 elsewhere.
5c156ace
PE
13994 (sub_char_table_ref_and_range, char_table_ref_and_range):
13995 Rename locals to avoid shadowing.
bbcd0949 13996 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13997
7d3b3862 13998 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13999 (BIDI_BOB): Remove unused macro.
7d3b3862 14000
6be7d3da
PE
14001 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14002 deduce are never used uninitialized.
c2ed9c8b 14003 * term.c (encode_terminal_code): Likewise.
6be7d3da 14004
75f8807f 14005 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14006
50938595
PE
14007 * tparam.h: New file.
14008 * term.c, tparam.h: Include it.
14009 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14010 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14011 Move these decls to tparam.h, and make them agree with what
14012 is actually in tparam.c. The previous trick of using incompatible
14013 decls in different modules does not conform to the C standard.
14014 All callers of tparam changed to use tparam's actual API.
14015 * tparam.c (tparam1, tparam, tgoto):
14016 Use const pointers where appropriate.
14017
fbceeba2
PE
14018 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14019 * cm.h (struct cm): Likewise.
14020 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14021 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14022 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14023 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14024 (turn_on_face, init_tty): Likewise.
14025 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14026
7f3f1250
PE
14027 * term.c (term_mouse_position): Rename local to avoid shadowing.
14028
e6ca6543
PE
14029 * alloc.c (mark_ttys): Move decl from here ...
14030 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14031
c40f8d15
AS
140322011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14033
14034 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14035
cfe0661d
JB
140362011-03-09 Juanma Barranquero <lekktu@gmail.com>
14037
14038 * search.c (compile_pattern_1): Remove argument regp, unused since
14039 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14040 (compile_pattern): Don't pass it.
14041
0afb4571
J
140422011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14043
14044 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14045 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14046 for ! HAVE_GTK3.
14047 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14048
14049 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14050
14051 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14052 gdk_window_get_screen, gdk_window_get_geometry,
14053 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14054 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14055 (xg_get_pixbuf_from_pixmap): New function.
14056 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14057 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14058 Call xg_get_pixbuf_from_pixmap instead of
14059 gdk_pixbuf_get_from_drawable.
14060 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14061 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14062 (xg_check_special_colors): Use GtkStyleContext and its functions
14063 for HAVE_GTK3.
14064 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14065 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14066 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14067 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14068 Call gtk_widget_get_preferred_size.
0afb4571
J
14069 (xg_frame_resized): gdk_window_get_geometry only takes 5
14070 parameters.
44f230aa
SM
14071 (xg_win_to_widget, xg_event_is_for_menubar):
14072 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14073 (xg_set_widget_bg): New function.
14074 (delete_cb): New function.
895009e1 14075 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14076 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14077 (xg_set_background_color): Call xg_set_widget_bg.
14078 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14079 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14080 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14081 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14082 if ! HAVE_GTK3.
14083 (update_frame_tool_bar): Call gtk_widget_hide.
14084 (xg_initialize): Use GDK_KEY_g.
14085
14086 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14087 if ! HAVE_GTK3
14088 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14089
14090 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14091 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14092 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14093
1c2cc4ef
JB
140942011-03-08 Juanma Barranquero <lekktu@gmail.com>
14095
14096 * w32xfns.c (select_palette): Check success of RealizePalette against
14097 GDI_ERROR, not zero.
14098
33383987 14099See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14100
14101;; Local Variables:
14102;; coding: utf-8
aac0c6e3
MR
14103;; End:
14104
2f097256 14105 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14106
14107 This file is part of GNU Emacs.
14108
14109 GNU Emacs is free software: you can redistribute it and/or modify
14110 it under the terms of the GNU General Public License as published by
14111 the Free Software Foundation, either version 3 of the License, or
14112 (at your option) any later version.
14113
14114 GNU Emacs is distributed in the hope that it will be useful,
14115 but WITHOUT ANY WARRANTY; without even the implied warranty of
14116 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14117 GNU General Public License for more details.
14118
14119 You should have received a copy of the GNU General Public License
14120 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.