Fix the current directory of the Emacs process on MS-Windows.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8d38f461
EZ
12012-06-29 Eli Zaretskii <eliz@gnu.org>
2
3 * w32.c (getwd): Adjust commentary about startup_dir.
4 (init_environment): Always call sys_access, even in non-MSVC
5 builds. Don't chdir to the directory of the Emacs executable.
6 This undoes code from 1997 which was justified by the need to
7 "avoid conflicts when removing and renaming directories". But its
8 downside was that every relative file name was being interpreted
9 relative to the directory of the Emacs executable, which can never
10 be TRT. In particular, it broke sys_access when called with
11 relative file names.
12 (sys_access): Map GetLastError to errno.
13
2af3565e
DA
142012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
15
16 * window.h (struct window): Change type of 'fringes_outside_margins'
17 to bitfield. Fix comment. Adjust users accordingly.
18 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
19 Adjust comment.
20 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
21 to ptrdiff_t.
22
c8d3a25c 232012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 24
c8d3a25c
GM
25 * gnutls.c (emacs_gnutls_handshake):
26 Add QUIT to make the loop interruptible.
57570cd3 27
c8d3a25c 282012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 29
c8d3a25c
GM
30 * charset.c (init_charset): Make lack of etc/charsets fatal.
31
3e984ee8
DA
322012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
33
34 * editfns.c (region_limit): Fix type mismatch.
35
ef884f23
DA
362012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
37
38 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
39 undefined. Convert from xassert to eassert.
40 * nsmenu.m: Convert from xassert to eassert.
41 * nsterm.m: Likewise.
42
7d7e0027
SM
432012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
44
45 * editfns.c (region_limit): Clip to narrowing (bug#11770).
46
aa754e6a
PE
472012-06-28 Paul Eggert <eggert@cs.ucla.edu>
48
49 Avoid integer overflow on scroll-left and scroll-right.
50 * window.c (HSCROLL_MAX): New macro.
51 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
52 overflow when requested scroll falls outside ptrdiff_t range.
53
80b00b08
DA
542012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
55
56 * window.h (struct window): Change type of 'hscroll',
57 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
58 'last_modified' and 'last_overlay_modified' to EMACS_INT.
59 Adjust users accordingly.
60 * xdisp.c (try_cursor_movement): Replace type check with eassert.
61 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
62 from EMACS_INT to ptrdiff_t.
63 (make_window): Omit redundant initialization.
64
62b2bcf6
JB
652012-06-28 Juanma Barranquero <lekktu@gmail.com>
66
67 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
68
45942c7d
DA
692012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
70
71 * window.h (struct window): Change type of 'use_time' and
72 'sequence_number' from Lisp_Object to int.
73 * frame.c (make_frame): Adjust users accordingly.
74 * print.c (print_object): Likewise.
75 * window.c (select_window, Fwindow_use_time, make_parent_window)
76 (make_window): Likewise.
77
e509cfa6
DA
782012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
79
80 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
81 enabled with --enable-checking=[all,glyphs] configure option.
82 Fix GLYPH_DEBUG usage assuming that it may be undefined,
83 adjust comments accordingly.
84 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
85 undefined, adjust comments accordingly.
86 * image.c: Likewise.
87 * scroll.c: Likewise.
88 * w32fns.c: Likewise.
89 * w32term.c: Likewise.
90 * xdisp.c: Likewise.
91 * xfaces.c: Likewise.
92 * xfns.c: Likewise.
93 * xterm.c: Likewise.
94
a54e2c05
DA
952012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
96
97 Generalize run-time debugging checks.
98 * dispextern.h (XASSERTS): Remove.
99 * fontset.c (xassert): Remove.
100 Convert from xassert to eassert.
101 * alloc.c: Convert from xassert to eassert.
102 * bidi.c: Likewise.
103 * dispnew.c: Likewise.
104 * fns.c: Likewise.
105 * fringe.c: Likewise.
106 * ftfont.c: Likewise.
107 * gtkutil.c: Likewise.
108 * image.c: Likewise.
109 * keyboard.c: Likewise.
110 * menu.c: Likewise.
111 * process.c: Likewise.
112 * scroll.c: Likewise.
113 * sound.c: Likewise.
114 * term.c: Likewise.
115 * w32console.c: Likewise.
116 * w32fns.c: Likewise.
117 * w32term.c: Likewise.
118 * window.c: Likewise.
119 * xdisp.c: Likewise.
120 * xfaces.c: Likewise.
121 * xfns.c: Likewise.
122 * xselect.c: Likewise.
123 * xterm.c: Likewise.
124
1ec4b7b2
SM
1252012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
126
127 * fns.c (maybe_resize_hash_table): Output message when growing the
128 purify-hashtable.
129
2014308a
DA
1302012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
131
132 * alloc.c (allocate_string_data): Remove dead code.
133 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
134 avoid GCC warning about unused macro.
135
246155eb
DA
1362012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
137
138 * alloc.c (allocate_string): Omit intervals initialization.
139 * alloc.c (make_uninit_multibyte_string): Initialize intervals
140 as in make_pure_string and make_pure_c_string.
141
43184b7b
DA
1422012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
143
144 * alloc.c (allocate_string): Fix last change.
145
3fe6dd74
DA
1462012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
147
148 * alloc.c (allocate_string): Remove two redundant calls
149 to memset, add explicit initialization where appropriate.
150
1ba6038a
GM
1512012-06-27 Glenn Morris <rgm@gnu.org>
152
153 * lisp.mk (lisp): Remove paths.elc.
154
c89926a5
CY
1552012-06-27 Chong Yidong <cyd@gnu.org>
156
157 * doc.c (Fsubstitute_command_keys): Fix punctuation.
158
ed6b3510
JW
1592012-06-26 John Wiegley <johnw@newartisans.com>
160
1ec4b7b2 161 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
162 on Mac OS X Lion: __mod_init_func and __mod_term_func.
163
ed6b3510
JW
164 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
165 when building with Clang.
166
8edd4a2b
SM
1672012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
168
169 * eval.c (Fapply): Allow calling it with a single argument.
170
f6f62d1b
EZ
1712012-06-26 Eli Zaretskii <eliz@gnu.org>
172
173 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
174 _stricmp and _strnicmp.
175 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
176
62efea5e
DA
1772012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
178
179 * alloc.c (allocate_window): Zero out non-Lisp part of newly
180 allocated window.
181 (allocate_process): Likewise for new process.
8edd4a2b 182 (allocate_terminal): Change to use offsetof.
62efea5e
DA
183 (allocate_frame): Likewise.
184 * frame.c (make_frame): Omit redundant initialization.
185 * window.c (make_parent_window): Use memset.
186 (make_window): Omit redundant initialization.
187 * process.c (make_process): Omit redundant initialization.
188 * terminal.c (create_terminal): Likewise.
189
42997f4d
DA
1902012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
191
192 * term.c (delete_tty): Remove redundant call to memset.
193
1130ecfc
DA
1942012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
195
196 * alloc.c: Remove build_string.
197 * lisp.h: Define build_string as static inline. This provides
198 a better opportunity to optimize away calls to strlen when the
199 function is called with compile-time constant argument.
200 * image.c (imagemagick_error): Convert to build_string.
201 * w32proc.c (sys_spawnve): Likewise.
202 * xterm.c (x_term_init): Likewise.
203
cf38a720
PE
2042012-06-26 Paul Eggert <eggert@cs.ucla.edu>
205
99027bdd
PE
206 Use sprintf return value instead of invoking strlen on result.
207 In the old days this wasn't portable, since some sprintf
208 implementations returned char *. But they died out years ago and
209 Emacs already assumes sprintf returns int.
210 Similarly for float_to_string.
211 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
212 * ccl.c (ccl_driver):
213 * character.c (string_escape_byte8):
214 * data.c (Fnumber_to_string):
215 * doprnt.c (doprnt):
216 * print.c (print_object):
217 * xdisp.c (message_dolog):
218 * xfns.c (syms_of_xfns):
219 Use sprintf or float_to_string result to avoid need to call strlen.
220 * data.c (Fnumber_to_string):
221 Use make_unibyte_string, since the string must be ASCII.
222 * lisp.h, print.c (float_to_string): Now returns int length.
223 * term.c (produce_glyphless_glyph):
224 Use sprintf result rather than recomputing it.
225
cf38a720
PE
226 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
227 * Makefile.in (ALL_CFLAGS):
228 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
229 * gmalloc.c, regex.c: Include <config.h> unconditionally.
230
3511c784
DA
2312012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
232
0a08eb21 233 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
234 strcasecmp if available.
235 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
236
fb7da12e
AS
2372012-06-25 Andreas Schwab <schwab@linux-m68k.org>
238
239 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
240 Avoid comma operator.
241 * menu.c (push_submenu_start, push_submenu_end)
242 (push_left_right_boundary, push_menu_pane): Likewise.
243 * msdos.c (dos_rawgetc): Likewise.
244
afa2ffd8
DA
2452012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
246
247 * xfns.c (xic_create_fontsetname): Remove redundant calls
248 to memset.
249
b3b4476b
PE
2502012-06-25 Paul Eggert <eggert@cs.ucla.edu>
251
4495ff38
PE
252 * gtkutil.c (get_utf8_string): Remove redundant assignment.
253 sprintf already null-terminates its output.
254
b3b4476b
PE
255 * xfns.c (x_window): Remove redundant cast.
256
b00876c9
DA
2572012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
258
259 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
260 `const char *' to `char *' to avoid compiler warning.
261
d188e26b
PE
2622012-06-24 Paul Eggert <eggert@cs.ucla.edu>
263
885d1d74
PE
264 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
265 instead of truncating it to 63 (admittedly a generous limit).
266
d188e26b
PE
267 * process.c: Fix spelling and caps in comments.
268
e2f560b1
DN
2692012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
270
e86db54b 271 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
272 * sysdep.c (setpgrp): Remove definition, not used in this file.
273
7583a3a1
JB
2742012-06-24 Juanma Barranquero <lekktu@gmail.com>
275
276 * makefile.w32-in: Update dependencies.
277
696056c2
EZ
2782012-06-24 Eli Zaretskii <eliz@gnu.org>
279
280 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
281 (SYSTIME_H): Add nt/inc/sys/time.h.
282
283 * systime.h [WINDOWSNT]: Include sys/time.h.
284
285 * s/ms-w32.h (struct timespec): Definition moved from
286 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
287
845ca893
PE
2882012-06-24 Paul Eggert <eggert@cs.ucla.edu>
289
290 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
291 * buffer.h (buffer_slot_type_mismatch):
292 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
293 * eval.c (unwind_to_catch):
294 * image.c (my_png_error, my_error_exit):
295 * keyboard.c (quit_throw_to_read_char, user_error)
296 (Fexit_recursive_edit, Fabort_recursive_edit):
297 * lisp.h (die, args_out_of_range, args_out_of_range_3)
298 (wrong_type_argument, buffer_overflow, __executable_start)
299 (memory_full, buffer_memory_full, string_overflow, Fthrow)
300 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
301 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
302 (fatal):
303 (child_setup) [!DOS_NT]:
304 * lread.c (end_of_file_error, invalid_syntax):
305 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
306 * puresize.h (pure_write_error):
307 * search.c (matcher_overflow):
308 * sound.c (sound_perror, alsa_sound_perror):
309 * sysdep.c, syssignal.h (croak):
310 * term.c (maybe_fatal, vfatal):
311 * textprop.c (text_read_only):
312 * undo.c (user_error):
313 * unexmacosx.c (unexec_error):
314 * xterm.c (x_ins_del_lines, x_delete_glyphs):
315 Use _Noreturn rather than NO_RETURN.
316 No need for separate decl merely because of _Noreturn.
317 * sound.c (sound_warning, parse_sound):
318 Remove unnecessary forward decls.
319
f1dd8073
PE
3202012-06-24 Paul Eggert <eggert@cs.ucla.edu>
321
322 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
323 * lisp.h (WAIT_READING_MAX): New macro.
324 * dispnew.c (Fsleep_for, sit_for):
325 * keyboard.c (kbd_buffer_get_event):
326 * process.c (Faccept_process_output):
327 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
328 This improves on the previous patch, which introduced a bug
329 when time_t is unsigned and as wide as intmax_t.
330 See <http://bugs.gnu.org/9000#51>.
331
b82c1755
EZ
3322012-06-23 Eli Zaretskii <eliz@gnu.org>
333
334 * dispnew.c (sit_for, Fsleep_for):
335 * keyboard.c (kbd_buffer_get_event):
336 * process.c (Faccept_process_output): Avoid compiler warnings when
337 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
338
ca300656
JB
3392012-06-23 Juanma Barranquero <lekktu@gmail.com>
340
049ec95b
JB
341 * makefile.w32-in: Update dependencies.
342
ca300656
JB
343 * w32.c (ltime): Add return type and declare static.
344 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
345
db7b8d06
PE
3462012-06-23 Paul Eggert <eggert@cs.ucla.edu>
347
348 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
349 Privately reported by Herbert J. Skuhra.
350 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
351 All uses changed.
352 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
353 not make_lisp_timeval, when the argument is of type EMACS_TIME.
354
0bd8297f
EZ
3552012-06-23 Eli Zaretskii <eliz@gnu.org>
356
96512555
EZ
357 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
358 last argument of make_unibyte_string.
359
0bd8297f
EZ
360 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
361 language ID in the event parameters.
362
363 * w32term.c (w32_read_socket): Put the new keyboard codepage into
364 event.code, not the obscure "character set ID".
365
63def6b6
CY
3662012-06-23 Chong Yidong <cyd@gnu.org>
367
368 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
369
e8a02204
EZ
3702012-06-23 Eli Zaretskii <eliz@gnu.org>
371
388cdec0
EZ
372 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
373 * w32.c (fdutimens): New function.
374
375 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
376
377 * s/ms-w32.h (pselect): Redirect to sys_select.
378
379 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
380
e8a02204
EZ
381 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
382 in the logic of incrementing and decrementing the value of
383 use_relocatable_buffers.
384
d054f3fb
PE
3852012-06-23 Paul Eggert <eggert@cs.ucla.edu>
386
387 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
388 Privately reported by Herbert J. Skuhra.
389 [__FreeBSD__]: Remove "*/" typo after "#include".
390 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
391 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
392 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
393 Don't assume EMACS_TIME and struct timeval are the same type.
394
d35af63c
PE
3952012-06-22 Paul Eggert <eggert@cs.ucla.edu>
396
397 Support higher-resolution time stamps (Bug#9000).
398 The time stamps are only nanosecond-resolution at the C level,
399 since that's the best that any real-world system supports now.
400 But they are picosecond-resolution at the Lisp level, as that's
401 easy, and leaves room for future OS improvements.
402
403 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
404 (LIBES): Use it.
405
406 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
407 Don't get current time unless it's needed.
408
409 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
410 now provides it if it's absent.
411 (start_atimer): Port to higher-res time stamps.
412 Check for time stamp overflow. Don't get current time more
413 often than is needed.
414
415 * buffer.h (struct buffer): Buffer modtime now has high resolution.
416 Include systime.h, not time.h.
417 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
418
419 * dired.c: Include stat-time.h.
420 (Ffile-attributes): File times now have higher resolution.
421
422 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
423 (struct image): Timestamp now has higher resolution.
424
425 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
426 has at least microseconds now. All uses removed.
427 (update_frame, update_single_window, update_window, update_frame_1)
428 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
429
430 * editfns.c (time_overflow): Now extern.
431 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
432 (float-time, Fformat_time_string, Fcurrent_time_string)
433 (Fcurrent_time_zone): Accept and generate higher-resolution
434 time stamps.
435 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
436 (decode_time_components, lisp_seconds_argument): New functions.
437 (make_time): Now static.
438 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
439 Report an error if the time is invalid, rather than having the caller
440 do that.
441
442 * fileio.c: Include <stat-time.h>
443 (Fcopy_file): Copy higher-resolution time stamps.
444 Prefer to set the time stamp via a file descriptor if that works.
445 (Fset_file_times, Finsert_file_contents, Fwrite_region)
446 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
447 (Fvisited_file_modtime, Fset_visited_file_modtime):
448 Support higher-resolution time stamps.
449
450 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
451
452 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
453
454 * image.c (prepare_image_for_display, clear_image_cache)
455 (lookup_image): Port to higer-resolution time stamps.
456
457 * keyboard.c (start_polling, bind_polling_period):
458 Check for time stamp overflow.
459 (read_char, kbd_buffer_get_event, timer_start_idle)
460 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
461 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
462 Port to higher-resolution time stamps. Do not assume time_t is signed.
463 (decode_timer): New function. Timers are now vectors of length 9,
464 not 8, to accommodate the picosecond component.
465 (timer_check_2): Use it.
466
467 * nsterm.m (select_timeout, timeval_subtract): Remove.
468 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
469 as they're a bit more accurate and handle overflow better.
470 (ns_select): Change prototype to be compatible with pselect.
471 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
472 * nsterm.h (ns_select): Adjust prototype.
473
474 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
475 us-resolution time stamps.
476 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
477
478 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
479
480 * lisp.h (time_overflow): New decl.
481 (wait_reading_process_output): First arg is now intmax_t, not int,
482 to accommodate larger waits.
483
484 * process.h (struct Lisp_Process.read_output_delay):
485 Now counts nanoseconds, not microseconds.
486 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
487 EMACS_HAS_USECS.
488 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
489 (wait_reading_process_output):
490 Port to ns-resolution time stamps.
491 (Faccept_process_output, wait_reading_process_output):
492 Check for time stamp overflow. Do not assume time_t is signed.
493 (select_wrapper): Remove; we now use pselect.
494 (Fprocess_attributes): Now generates ns-resolution time stamps.
495
496 * sysdep.c: Include utimens.h. Don't include utime.h
497 or worry about struct utimbuf; gnulib does that for us now.
498 (gettimeofday): Remove; gnulib provides a substitute.
499 (make_timeval): New function.
500 (set_file_times): Now sets ns-resolution time stamps.
501 New arg FD; all uses changed.
502 (time_from_jiffies, ltime_from_jiffies, get_up_time)
503 (system_process_attributes):
504 Now returns ns-resolution time stamp. All uses changed.
505 Check for time stamp overflow.
506
507 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
508 provides a substitute now.
509
510 * systime.h: Include timespec.h rather than sys/time.h and time.h,
511 since it guarantees struct timespec.
512 (EMACS_TIME): Now struct timespec, so that we can support
513 ns-resolution time stamps.
514 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
515 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
516 (EMACS_USECS): Remove.
517 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
518 so multiply the arg by 1000 before storing it.
519 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
520 New macros.
521 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
522 Port to ns-resolution time stamps.
523 (EMACS_TIME_NEG_P): Remove; replaced by....
524 (EMACS_TIME_SIGN): New macro.
525 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
526 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
527 (set_file_times, make_time, lisp_time_argument): Adjust signature.
528 (make_timeval, make_lisp_time, decode_time_components): New decls.
529 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
530 that it mishandled time_t overflow. You can't compare by subtracting!
531 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
532 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
533
534 * term.c: Include <sys/time.h>.
535 (timeval_to_Time): New function, for proper overflow wraparound.
536 (term_mouse_position, term_mouse_click): Use it.
537
538 * undo.c (record_first_change): Support higher-resolution time stamps
539 in the undo buffer.
540 (Fprimitive_undo): Use them when restoring time stamps.
541
542 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
543 (w32_get_internal_run_time):
544 Port to higher-resolution Emacs time stamps.
545 (ltime): Now accepts single 64-bit integer, as that's more convenient
546 for callers.
547
548 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
549
550 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
551 for compatibility with pselect. Support ns-resolution time stamps.
552
553 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
554
555 * xselect.c (wait_for_property_change, x_get_foreign_selection):
556 Check for time stamp overflow, and support ns-resolution time stamps.
557
558 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
559 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
560 (timeval_subtract): Remove; no longer needed.
561 (XTflash, XTring_bell, x_wait_for_event):
562 Port to ns-resolution time stamps. Don't assume time_t is signed.
563
b6a92dfe
CY
5642012-06-22 Chong Yidong <cyd@gnu.org>
565
566 * xdisp.c (x_consider_frame_title): Revert last change.
567
d251c37c
EZ
5682012-06-22 Eli Zaretskii <eliz@gnu.org>
569
570 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
571 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
572 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
573 staticidx goes up to 1597 out of 1600 = 0x640.)
574
f10deafb
PE
5752012-06-20 Paul Eggert <eggert@cs.ucla.edu>
576
577 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
578 Otherwise, the umask might be mistakenly 0 while handling input signals.
579
ec6de1e2
SM
5802012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
581
582 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
583
28be1ada
DA
5842012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
585
586 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
587 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
588 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
589 access to `contents' member of Lisp_Vector objects with AREF and ASET
590 where appropriate.
591
c6bf3022
CY
5922012-06-19 Chong Yidong <cyd@gnu.org>
593
594 * frame.c (delete_frame): When selecting a frame on a different
595 text terminal, do not alter the terminal's top-frame.
596
597 * xdisp.c (format_mode_line_unwind_data): Record the target
598 frame's selected window and its terminal's top-frame.
599 (unwind_format_mode_line): Restore them.
600 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
601 Callers changed.
602 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
603 since tty frames can be explicitly named.
604 (prepare_menu_bars): Likewise.
605
606 * term.c (Ftty_top_frame): New function.
607
defd4196
PE
6082012-06-18 Paul Eggert <eggert@cs.ucla.edu>
609
610 Port byte-code-meter to modern targets.
611 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
612 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 613 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
614 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
615 (METER_1, METER_2): Simplify.
616
1053a871
SM
6172012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
618
619 * data.c (Fdefalias): Return `symbol' (bug#11686).
620
b7e8d081
MR
6212012-06-18 Martin Rudalics <rudalics@gmx.at>
622
623 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
624 gets killed during executing of this function (Bug#11665).
625 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
626 (Vkill_buffer_query_functions): In doc-string say that functions
627 run by this hook should not change the current buffer.
628
7ea2b339
PE
6292012-06-18 Paul Eggert <eggert@cs.ucla.edu>
630
631 Fix recently-introduced process.c problems found by static checking.
632 * process.c (write_queue_push, write_queue_pop, send_process):
633 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
634 (write_queue_pop): Fix pointer signedness problem.
635 (send_process): Remove unused local.
636
96a313a1
CY
6372012-06-17 Chong Yidong <cyd@gnu.org>
638
639 * xdisp.c (redisplay_internal): No need to redisplay terminal
640 frames that are not on top.
641
20ca2e94
TN
6422012-06-17 Troels Nielsen <bn.troels@gmail.com>
643
644 * process.c (make_process): Initialize write_queue.
645 (write_queue_push, write_queue_pop): New functions.
646 (send_process): Use them to maintain correct ordering of process
647 writes (Bug#10815).
648
9a900ca9
PE
6492012-06-17 Paul Eggert <eggert@cs.ucla.edu>
650
310fbfa8
PE
651 * lisp.h (eassert): Assume C89 or later.
652 This removes the need for CHECK.
653 (CHECK): Remove. Its comments about always evaluating its
654 argument were confusing, as 'eassert' typically does not evaluate
655 its argument.
656
27bb1ca4
PE
657 * coding.c (produce_chars): Use ptrdiff_t, not int.
658
9a900ca9
PE
659 * xterm.c (x_draw_underwave): Check for integer overflow.
660 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
661
41b7f8bc 6622012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
663
664 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
665 referenced (Bug#11583).
666
9b0e3eba
AA
6672012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
668
669 Implement wave-style variant of underlining.
670 * dispextern.h (face_underline_type): New enum.
671 (face): Add field for underline type.
672 * nsterm.m (ns_draw_underwave): New function.
673 (ns_draw_text_decoration): Use it.
674 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
675 New functions.
676 (x_draw_glyph_string): Use them.
677 * xfaces.c (Qline, Qwave): New Lisp objects.
678 (check_lface_attrs, merge_face_ref)
1053a871
SM
679 (Finternal_set_lisp_face_attribute, realize_x_face):
680 Handle wave-style underline face attributes.
9b0e3eba
AA
681 * xterm.c (x_draw_underwave): New function.
682 (x_draw_glyph_string): Use it.
683
0fb52f11
JB
6842012-06-16 Juanma Barranquero <lekktu@gmail.com>
685
686 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
687 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
688 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
689 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
690 ($(BLD)/w32select.$(O)): Update dependencies.
691
e5560ff7
AS
6922012-06-16 Andreas Schwab <schwab@linux-m68k.org>
693
694 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
695 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
696 * character.c (_fetch_multibyte_char_p): Remove.
697 * alloc.c: Include "character.h" before "buffer.h".
698 * bidi.c: Likewise.
699 * buffer.c: Likewise.
700 * bytecode.c: Likewise.
701 * callint.c: Likewise.
702 * callproc.c: Likewise.
703 * casefiddle.c: Likewise.
704 * casetab.c: Likewise.
705 * category.c: Likewise.
706 * cmds.c: Likewise.
707 * coding.c: Likewise.
708 * composite.c: Likewise.
709 * dired.c: Likewise.
710 * dispnew.c: Likewise.
711 * doc.c: Likewise.
712 * dosfns.c: Likewise.
713 * editfns.c: Likewise.
714 * emacs.c: Likewise.
715 * fileio.c: Likewise.
716 * filelock.c: Likewise.
717 * font.c: Likewise.
718 * fontset.c: Likewise.
719 * fringe.c: Likewise.
720 * indent.c: Likewise.
721 * insdel.c: Likewise.
722 * intervals.c: Likewise.
723 * keyboard.c: Likewise.
724 * keymap.c: Likewise.
725 * lread.c: Likewise.
726 * macros.c: Likewise.
727 * marker.c: Likewise.
728 * minibuf.c: Likewise.
729 * nsfns.m: Likewise.
730 * nsmenu.m: Likewise.
731 * print.c: Likewise.
732 * process.c: Likewise.
733 * regex.c: Likewise.
734 * region-cache.c: Likewise.
735 * search.c: Likewise.
736 * syntax.c: Likewise.
737 * term.c: Likewise.
738 * textprop.c: Likewise.
739 * undo.c: Likewise.
740 * unexsol.c: Likewise.
741 * w16select.c: Likewise.
742 * w32fns.c: Likewise.
743 * w32menu.c: Likewise.
744 * window.c: Likewise.
745 * xdisp.c: Likewise.
746 * xfns.c: Likewise.
747 * xmenu.c: Likewise.
748 * xml.c: Likewise.
749 * xselect.c: Likewise.
750
2f07e6af
EZ
7512012-06-16 Eli Zaretskii <eliz@gnu.org>
752
1053a871
SM
753 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
754 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 755 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
756 row.
757 (handle_face_prop): Use chunk-relative overlay string index when
758 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
759 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
760 the rightmost. (Bug#11720)
2f07e6af 761
29b83cec
AS
7622012-06-16 Andreas Schwab <schwab@linux-m68k.org>
763
764 * category.h (CHAR_HAS_CATEGORY): Define as inline.
765 (CATEGORY_MEMBER): Enforce 1/0 value.
766 * category.c (_temp_category_set): Remove.
767
4c5501e9
EZ
7682012-06-16 Eli Zaretskii <eliz@gnu.org>
769
770 * window.c (Fdelete_other_windows_internal)
771 (Fdelete_window_internal): Don't access frame's mouse highlight
772 info of the initial frame. (Bug#11677)
773
2b570124
PE
7742012-06-14 Paul Eggert <eggert@cs.ucla.edu>
775
e93864f9
PE
776 * .gdbinit (xgetint): Fix recently-introduced paren typo.
777 Assume USE_2_TAGS_FOR_INTS.
778 (xreload): Adjust $tagmask width to match recent lisp.h change.
779
2b570124
PE
780 Simplify lisp.h in minor ways that should not affect code.
781 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
782 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
783 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
784 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
785 (INTTYPEBITS): New macro, for clarity.
786 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
787 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
788 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
789 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
790 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
791
81755f69
JB
7922012-06-13 Juanma Barranquero <lekktu@gmail.com>
793
794 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
795
16192a57
GM
7962012-06-13 Glenn Morris <rgm@gnu.org>
797
798 * s/bsd-common.h (BSD4_3):
799 * s/usg5-4-common.h (USG5_4): No longer define; unused.
800
646b5f55
AS
8012012-06-13 Andreas Schwab <schwab@linux-m68k.org>
802
803 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
804 instead of union.
805 (XLI, XIL): Define.
1053a871
SM
806 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
807 Use them.
808 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 809 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 810 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
811 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
812 * frame.c (delete_frame): Remove outdated comment.
813 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
814 USE_LISP_UNION_TYPE.
815 (Fw32_unregister_hot_key): Likewise.
816 (Fw32_toggle_lock_key): Likewise.
817 * w32menu.c (add_menu_item): Likewise.
818 (w32_menu_display_help): Use XIL instead of checking
819 USE_LISP_UNION_TYPE.
820 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
821 (init_heap): Likewise.
822 * w32term.c (w32_read_socket): Update comment.
823
1d3823c9
GM
8242012-06-13 Glenn Morris <rgm@gnu.org>
825
c62ff706
GM
826 * s/usg5-4-common.h, src/s/unixware.h:
827 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
828
1d3823c9
GM
829 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
830
bfe3e0a2
PE
8312012-06-13 Paul Eggert <eggert@cs.ucla.edu>
832
833 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
834 * alloc.c (make_number) [!defined make_number]:
835 Remove, as lisp.h always defines this now.
836 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
837 (roundup_size): Verify that it is a power of 2.
838 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
839 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
840 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
841 -DUSE_LSB_TAG=0, to override the automatically-selected default.
842 USE_LSB_TAG now is always defined to be either 0 or 1.
843 All uses changed.
844 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
845 code works fine either way, and efficiency is not a concern here,
846 as the union type is for debugging, not for production.
847 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
848 Use an inline function on all platforms when using the union type,
849 since this is simpler and 'static inline' can be used portably
850 within Emacs now.
851 (LISP_INITIALLY_ZERO): New macro.
852 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
853 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
854
45fa9c0f
GM
8552012-06-12 Glenn Morris <rgm@gnu.org>
856
b4492cba
GM
857 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
858
859 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 860
45fa9c0f
GM
861 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
862 Move BROKEN_SIGIO to configure.
863
864 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
865 Move NO_TERMIO to configure.
866
0e25d334
CY
8672012-06-12 Chong Yidong <cyd@gnu.org>
868
869 * image.c (imagemagick_load_image): Use MagickFlattenImage if
870 MagickMergeImageLayers is undefined. Use pixel pusher loop if
871 MagickExportImagePixels is undefined.
872
43682bb6
PE
8732012-06-12 Paul Eggert <eggert@cs.ucla.edu>
874
875 * image.c (imagemagick_load_image): Remove unused label.
876
a9be7d2b
GM
8772012-06-11 Glenn Morris <rgm@gnu.org>
878
879 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
880 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
881 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
882 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
883
3017f87f
SM
8842012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
885
886 * alloc.c (make_byte_code): New function.
887 (Fmake_byte_code): Use it. Don't purify here.
888 * lread.c (read1): Use it as well to avoid extra allocation.
889
1b9b4cf4
CY
8902012-06-11 Chong Yidong <cyd@gnu.org>
891
892 * image.c (imagemagick_load_image): Implement transparency.
893
95988fcf
AS
8942012-06-10 Andreas Schwab <schwab@linux-m68k.org>
895
896 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
897 account for preceding backslashes. (Bug#11663)
898
cd4eb164
CY
8992012-06-09 Chong Yidong <cyd@gnu.org>
900
901 * term.c: Support italics in capable terminals (Bug#9652).
902 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
903 (turn_on_face): Output using TS_enter_italic_mode if available.
904 Don't handle unused blinking and alt-charset cases.
905 (turn_off_face): Handle italic case; discard unused tty_blinking_p
906 and tty_alt_charset_p cases.
907 (tty_capable_p, init_tty): Support italics.
908
909 * termchar.h (struct tty_display_info): Add field for italics.
910 Remove unused blink field.
911
912 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
913 Handle slant.
914
915 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
916 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
917 tty_alt_charset_p. Add tty_italic_p.
918
ff88beb8
MA
9192012-06-09 Michael Albinus <michael.albinus@gmx.de>
920
921 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
922 dbus_type_is_basic if available.
923 (xd_extract_signed, xd_extract_unsigned): Rename from
924 extract_signed and extract_unsigned, respectively. Adapt callers.
925
44286096
CY
9262012-06-09 Chong Yidong <cyd@gnu.org>
927
1682701f
CY
928 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
929
44286096
CY
930 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
931 case (Bug#9752).
932
d86feb17
PE
9332012-06-08 Paul Eggert <eggert@cs.ucla.edu>
934
935 * xdisp.c (vmessage): Treat frame message as multibyte.
936 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
937 would generate the diagnostic "Making \302\247 buffer-local while
938 let-bound!".
939
d5c20fe8
EZ
9402012-06-08 Eli Zaretskii <eliz@gnu.org>
941
942 * dispnew.c (showing_window_margins_p): Undo last change, which
943 was done due to an inadvertent commit.
944 (adjust_frame_glyphs_for_frame_redisplay): Do call
945 showing_window_margins_p.
946
513749ee
SM
9472012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
948
949 * eval.c (Fmake_var_non_special): New primitive.
950 (syms_of_eval): Defsubr it.
951 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
952
d4a8f5c1
JB
9532012-06-08 Juanma Barranquero <lekktu@gmail.com>
954
955 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
956 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
957
8bbbc977
EZ
9582012-06-08 Eli Zaretskii <eliz@gnu.org>
959
960 * alloc.c (allocate_vectorlike): Fix last change.
961
f3372c87
DA
9622012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
963
964 Block-based vector allocation of small vectors.
965 * lisp.h (struct vectorlike_header): New field `nbytes',
966 adjust comment accordingly.
967 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
968 to denote vector blocks. Adjust users (live_vector_p,
969 mark_maybe_pointer, valid_lisp_object_p) accordingly.
970 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
971 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
972 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
973 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
974 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
975 (roundup_size): New constant.
976 (struct vector_block): New data type.
977 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 978 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
979 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
980 (sweep_vectors): New functions.
981 (allocate_vectorlike): Return `zero_vector' as the only vector of
982 0 items. Allocate new vector from block if vector size is less than
983 or equal to VBLOCK_BYTES_MAX.
984 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
985 (init_alloc_once): Add call to init_vectors.
986
4f18a4ed
SM
9872012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
988
989 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
990
86f158bc
PE
9912012-06-07 Paul Eggert <eggert@cs.ucla.edu>
992
993 * doprnt.c (doprnt): Truncate multibyte char correctly.
994 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
995 would mishandle a string argument "Xc" if X was a multibyte
996 character of length 2: it would truncate after X's first byte
997 rather than including all of X.
998
c5cfcbe0
CY
9992012-06-06 Chong Yidong <cyd@gnu.org>
1000
1001 * buffer.c (word_wrap): Doc fix.
1002
c05cf390
PE
10032012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1006
0c3461de
GM
10072012-06-03 Glenn Morris <rgm@gnu.org>
1008
1009 * xdisp.c (tool-bar-style): Doc fix.
1010
c71232db
UM
10112012-06-03 Ulrich Müller <ulm@gentoo.org>
1012
1013 * Makefile.in (PAXCTL): Define.
1014 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1015 binary via PaX flags if the paxctl utility is available.
1016 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1017 Restore PaX flags to their default. (Bug#11398)
1018
383f7350
CY
10192012-06-03 Chong Yidong <cyd@gnu.org>
1020
1021 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1022 buffer (Bug#11226).
1023
5f2c76c6
CY
10242012-06-03 Chong Yidong <cyd@gnu.org>
1025
1026 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1027 (note_mode_line_or_margin_highlight): If there is no help echo,
1028 use mode-line-default-help-echo. Handle the case where the mouse
1029 position is past the end of the mode line string.
1030
1031 * buffer.c (buffer_local_value_1): New function, split from
1032 Fbuffer_local_value; can return Qunbound.
1033 (Fbuffer_local_value): Use it.
1034 (Vmode_line_format): Docstring tweaks.
1035
773d47f6
PE
10362012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1037
1038 * sysdep.c (system_process_attributes): Improve comment.
1039
f2d6a3df
SM
10402012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1041
1042 * keyboard.c: Export real-this-command to Elisp.
1043 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1044 and DEFVAR it. Update all users.
1045
63810350
PE
10462012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1047
7bd5c1f4
PE
1048 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1049
63810350
PE
1050 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1051 Convert pctcpu and pctmem to Lisp float properly.
1052 Let the compiler fold better, as 100.0/0x8000 is exact.
1053
a2821611
AS
10542012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1055
1056 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1057 cons_block.
1058
5fceba1d
PE
10592012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1060
1061 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1062
c98ff5dd
DA
10632012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1064
1065 For a 'struct window', replace some Lisp_Object fields to
1066 bitfields where appropriate, remove unused fields.
1067 * window.h (struct window): Remove unused 'last_mark_x' and
1068 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1069 change it's type from Lisp_Object to bitfield.
1070 Change type of 'force_start', 'optional_new_start',
1071 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1072 fields from Lisp_Object to bitfield. Adjust users accordingly.
1073
ca34e0be
PE
10742012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1075
1076 Pacify gcc -Wdouble-precision when using Xaw.
1077 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1078 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1079 Use 'float' consistently, rather than 'float' in most places
1080 and 'double' in a couple of places.
1081
efc00ab1 10822012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1083
1084 * xdisp.c (handle_stop): Detect whether we have overlay strings
1085 loaded by testing it->current.overlay_string_index to be
1086 non-negative, instead of checking whether n_overlay_strings is
1087 positive. (Bug#11587)
1088
efc00ab1 10892012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1090
1091 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1092
1093 * doc.c (Fsubstitute_command_keys): Doc fix.
1094
efc00ab1 10952012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1096
1097 * search.c (search_buffer): Remove calls to
1098 r_alloc_inhibit_buffer_relocation, as it is now called by
1099 maybe_unify_char, which was the cause of relocation of buffer text
1100 in bug#11519.
1101
efc00ab1 11022012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1103
1104 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1105 for the duration of call to load_charset, to avoid problems with
1106 callers of maybe_unify_char that access buffer text through C
1107 pointers.
1108
1109 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1110 decrement the inhibition flag, instead of just setting or
1111 resetting it.
1112
ba93a187
PE
11132012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1114
1115 Remove obsolete '#define static' cruft.
1116 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1117 This #undef was "temporary" in 2000; it is no longer needed
1118 now that '#define static' has gone away.
1119 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1120 (gray_bitmap_bits): Remove; no longer needed.
1121 All uses replaced with definiens.
1122 * xterm.c: Include "bitmaps/gray.xbm".
1123
9e4bf381
PE
11242012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1125
1126 Clean up __executable_start, monstartup when --enable-profiling.
1127 The following changes affect the code only when profiling.
1128 * dispnew.c (__executable_start): Rename from safe_bcopy.
1129 Define only on platforms that need it.
1130 * emacs.c: Include <sys/gmon.h> when profiling.
1131 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1132 (__executable_start): Remove decl, since lisp.h does it now.
1133 (safe_bcopy): Remove decl; no longer has that name.
1134 (main): Coalesce #if into single bit of code, for simplicity.
1135 Cast pointers to uintptr_t, since standard libraries want integers
1136 and not pointers.
1137 * lisp.h (__executable_start): New decl.
1138
32d72c2f
GM
11392012-05-31 Glenn Morris <rgm@gnu.org>
1140
1141 * image.c (Fimagemagick_types): Doc fix.
1142
baac5bc7
JM
11432012-05-30 Jim Meyering <meyering@redhat.com>
1144
1145 * callproc.c (Fcall_process_region): Include directory component
1146 in mkstemp error message (Bug#11586).
1147
72cb32cf
PE
11482012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1149
1150 * alloc.c, lisp.h (make_pure_vector): Now static.
1151
61b108cc
SM
11522012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1153
1154 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1155 Move to byte-run.el.
1156 (Fautoload): Do the hash-doc more carefully.
1157 * data.c (Fdefalias): Purify definition, except for keymaps.
1158 (Qdefun): Move from eval.c.
1159 * lisp.h (Qdefun): Remove.
1160 * lread.c (read1): Tiny simplification.
1161
471fe23d
TN
11622012-05-29 Troels Nielsen <bn.troels@gmail.com>
1163
934f3f58 1164 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1165 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1166 Bug#9642, but explicitly check that the buffer the overlay would
1167 be moved to is live and rearrange lines to make sure that errors
1168 will not put the overlay in an inconsistent state.
1169 (Fdelete_overlay): Cosmetics.
1170
85d0efd1
EZ
11712012-05-28 Eli Zaretskii <eliz@gnu.org>
1172
1173 * w32term.c (my_bring_window_to_top): New function.
1174 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1175 could be different from the original one.
1176 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1177 (Bug#11513)
1178
1179 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1180 by calling BringWindowToTop.
1181
1182 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1183 (WM_EMACS_END): Increase by one.
1184
da92a98c
PE
11852012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1186
1187 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1188 This avoids undefined behavior that might cause the eassert
1189 to not catch an out-of-range value.
1190
74d1f848
JB
11912012-05-28 Juanma Barranquero <lekktu@gmail.com>
1192
1193 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1194 Update dependencies.
1195
9e1a06fc
EZ
11962012-05-27 Eli Zaretskii <eliz@gnu.org>
1197
1198 * bidi.c (bidi_mirror_char): Fix last change.
1199
f3dd7312
AS
12002012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1201
1202 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1203 when referring to sectname field in printf format.
1204
81899c91
PE
12052012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1206
57b81a9f
PE
1207 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1208 Only r_alloc_inhibit_buffer_relocation needed to be added;
1209 the others were already declared.
1210
81899c91
PE
1211 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1212 before checking whether it's out of range. Put the check inside
1213 eassert. See
1214 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1215
33017faf 12162012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1217
1218 * callproc.c (Fcall_process): Restore a line that was accidentally
1219 commented out in the 2011-02-13 change (bug#11547).
1220
33017faf 12212012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1222
1223 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1224 defined on ralloc.c.
1225
1226 * buffer.c [REL_ALLOC]: Remove prototypes of
1227 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1228 they are now on lisp.h.
1229
1230 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1231
1232 * search.c (search_buffer): Use it to inhibit relocation of buffer
1233 text while re_search_2 is doing its job, because re_search_2 is
1234 passed C pointers to buffer text. (Bug#11519)
1235
23415acf
EZ
1236 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1237 Update value to 24.
1238
44e27368
EZ
1239 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1240 state after an additional call to move_it_in_display_line_to, keep
1241 the values of it->max_ascent and it->max_descent found for the
1242 entire line.
1243 (pos_visible_p): Revert the comparison against bottom_y to what it
1244 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1245 (Bug#11464)
1246
c1892f11
PE
12472012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 Fix coding-related core dumps with gcc -ftrapv.
1250 The code was computing A - B, where A and B are pointers, and B is
1251 random garbage. This can lead to core dumps on platforms that
1252 have special pointer registers, and it also leads to core dumps on
1253 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1254 A - B only when B is initialized properly.
1255 * coding.c (coding_set_source, coding_set_destination): Return void.
1256 (coding_change_source, coding_change_destinations): New functions,
1257 with the old behaviors of coding_set_source and coding_set_destination.
1258 All callers that need an offset changed to use these new functions.
1259
eb7afdad
GM
12602012-05-26 Glenn Morris <rgm@gnu.org>
1261
1262 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1263
f12fdf02
EZ
12642012-05-26 Eli Zaretskii <eliz@gnu.org>
1265
53a63be6 1266 Extend mouse support on W32 text-mode console.
61b108cc
SM
1267 * xdisp.c (draw_row_with_mouse_face):
1268 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1269
eb3f6f01 1270 * w32console.c: Include window.h.
61b108cc
SM
1271 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1272 New functions.
eb3f6f01
EZ
1273 (initialize_w32_display): Initialize mouse-highlight data.
1274
53a63be6
EZ
1275 * w32inevt.c: Include termchar.h and window.h.
1276 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1277 moves, call note_mouse_highlight. If help_echo changed, call
1278 gen_help_event to produce help-echo message in the echo area.
1279 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1280 highlight info.
1281
4cfd81f6
PE
12822012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 * lread.c (read1): Simplify slightly to avoid an overflow warning
1285 with GCC 4.7.0 on x86-64.
1286
4446092a
EZ
12872012-05-26 Eli Zaretskii <eliz@gnu.org>
1288
1289 * bidi.c (bidi_mirror_char): Revert last change: an int is
1290 definitely wide enough here.
1291
42b2a986 12922012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1293
42b2a986 1294 Fix integer width and related bugs (Bug#9874).
eb106a49 1295 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1296 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1297 (string_bytes, check_sblock, allocate_string_data):
1298 (compact_small_strings, Fmake_bool_vector, make_string)
1299 (make_unibyte_string, make_multibyte_string)
1300 (make_string_from_bytes, make_specified_string)
1301 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1302 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1303 (mark_vectorlike):
1304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1305 (allocate_pseudovector):
1306 Use int, not EMACS_INT, where int is wide enough.
1307 (inhibit_garbage_collection, Fgarbage_collect):
1308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1309 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1310 int might not be wide enough.
1311 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1312 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1313 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1314 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1315 (bidi_level_of_next_char, bidi_move_to_visually_next):
1316 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1317 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1318 (Fkill_buffer, Fset_buffer_major_mode)
1319 (advance_to_char_boundary, Fbuffer_swap_text)
1320 (Fset_buffer_multibyte, overlays_at, overlays_in)
1321 (overlay_touches_p, struct sortvec, record_overlay_string)
1322 (overlay_strings, recenter_overlay_lists)
1323 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1324 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1325 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1326 (Foverlay_recenter, last_overlay_modification_hooks_used)
1327 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1329 (validate_region): Omit unnecessary test for b <= e,
1330 since that's guaranteed by the previous test.
d311d28c
PE
1331 (adjust_overlays_for_delete): Avoid pos + length overflow.
1332 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1333 (report_overlay_modification):
1334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1335 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1336 Omit pointer cast, which isn't needed anyway, and doesn't work
1337 after the EMACS_INT -> ptrdiff_t change.
02481186 1338 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1339 * buffer.h: Adjust decls to match defn changes elsewhere.
1340 (struct buffer_text, struct buffer):
1341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1342 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1343 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1344 not int, to avoid needless 32-bit limit on 64-bit hosts.
1345 (exec_byte_code): Use tighter memory-full test, one that checks
1346 for alloca overflow. Don't compute the address of the object just
1347 before an array, as that's not portable. Use EMACS_INT, not
1348 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1349 * callint.c (Fcall_interactively):
1350 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1351 * callproc.c (call_process_kill, Fcall_process):
1352 Don't assume pid_t fits into an Emacs fixnum.
1353 (call_process_cleanup, Fcall_process, child_setup):
1354 Don't assume pid_t fits into int.
1355 (call_process_cleanup, Fcall_process, delete_temp_file)
1356 (Fcall_process_region):
1357 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1358 (Fcall_process): Simplify handling of volatile integers.
1359 Use int, not EMACS_INT, where int will do.
1360 * casefiddle.c (casify_object, casify_region, operate_on_word)
1361 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1362 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1363 (casify_object): Avoid integer overflow when overallocating buffer.
1364 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1365 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1366 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1367 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1368 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1369 integers are now checked earlier. All uses replaced with XINT.
1370 (ccl_driver):
1371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1372 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1373 (ccl_driver, Fregister_code_conversion_map):
1374 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1375 (resolve_symbol_ccl_program): Check that vector header is in range.
1376 Always copy the vector, so that we can check its contents reliably
1377 now rather than having to recheck each instruction as it's being
1378 executed. Check that vector words fit in 'int'.
1379 (ccl_get_compiled_code, Fregister_ccl_program)
1380 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1381 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1382 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1383 contents are in range.
1384 (Fccl_execute_on_string): Check that status is in range.
1385 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1386 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1387 Accept and return EMACS_INT, not int, because callers can pass values
1388 out of 'int' range.
1389 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1390 (multibyte_chars_in_text, parse_str_as_multibyte)
1391 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1392 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1393 (string_escape_byte8, Fget_byte):
1394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1395 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1396 avoid mishandling large integers.
1397 * character.h: Adjust decls to match defn changes elsewhere.
1398 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1399 (Ffind_charset_region):
1400 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1401 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1402 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1403 Don't assume fixnum fits in int.
d311d28c
PE
1404 (load_charset_map_from_vector, Fmap_charset_chars):
1405 Remove now-unnecessary CHECK_NATNUMs.
1406 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1407 Don't rely on undefined behavior with signed left shift overflow.
1408 Don't assume unsigned int fits into fixnum, or that fixnum fits
1409 into unsigned int. Don't require max_code to be a valid fixnum;
1410 that's not true for gb10830 4-byte on a 32-bit host. Allow
1411 invalid_code to be a cons, for the same reason. Require code_offset
1412 to be a character. Avoid int overflow if max_char is close
1413 to INT_MAX.
1414 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1415 this is intended anyway and avoids some undefined behavior.
1416 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1417 INDEX_TO_CODE_POINT, as that's what it expects.
1418 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1419 * charset.h (DECODE_CHAR): Return int, not unsigned;
1420 this is what was intended anyway, and it avoids undefined behavior.
1421 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1422 integer-overflow issues.
1423 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1424 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1425 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1426 * chartab.c (Fmake_char_table, Fset_char_table_range)
1427 (uniprop_get_decoder, uniprop_get_encoder):
1428 Don't assume fixnum fits in int.
1429 * cmds.c (move_point): New function, that does the gist of
1430 Fforward_char and Fbackward_char, but does so while checking
1431 for integer overflow more accurately.
c96e5d6a 1432 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1433 (Fforward_line, Fend_of_line, internal_self_insert)
1434 (internal_self_insert):
1435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1436 Fix a FIXME, by checking for integer overflow when calculating
1437 target_clm and actual_clm.
1438 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1439 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1440 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1441 (coding_alloc_by_making_gap, alloc_destination)
1442 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1443 (encode_coding_utf_16, detect_coding_emacs_mule)
1444 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1445 (detect_coding_iso_2022, decode_coding_iso_2022)
1446 (encode_invocation_designation, encode_designation_at_bol)
1447 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1448 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1449 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1450 (encode_coding_ccl, encode_coding_raw_text)
1451 (detect_coding_charset, decode_coding_charset)
1452 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1453 (produce_composition, produce_charset, produce_annotation)
1454 (decode_coding, handle_composition_annotation)
1455 (handle_charset_annotation, consume_chars, decode_coding_gap)
1456 (decode_coding_object, encode_coding_object, detect_coding_system)
1457 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1458 (code_convert_region, code_convert_string)
8f50130c
PE
1459 (Fdefine_coding_system_internal)
1460 (coding_set_source, coding_set_destination):
d311d28c
PE
1461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1462 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1463 (Fdefine_coding_system_internal):
1464 Don't assume fixnums fit in int.
1465 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1466 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1467 (Funencodable_char_position, Fcheck_coding_systems_region)
1468 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1469 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1470 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1471 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1472 Don't access memory outside of the args array.
d311d28c 1473 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1474 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1475 result of ENCODE_CHAR.
d311d28c
PE
1476 * coding.h: Adjust decls to match defn changes elsewhere.
1477 (struct coding_system):
1478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1479 * composite.c (get_composition_id, find_composition)
1480 (run_composition_function, update_compositions)
1481 (compose_text, composition_gstring_put_cache)
1482 (composition_gstring_p, composition_gstring_width)
1483 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1484 (composition_compute_stop_pos, composition_reseat_it)
1485 (composition_update_it, struct position_record)
1486 (find_automatic_composition, composition_adjust_point)
1487 (Fcomposition_get_gstring, Ffind_composition_internal):
1488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1489 (update_compositions):
1490 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1491 * composite.h: Adjust decls to match defn changes elsewhere.
1492 (struct composition):
1493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1494 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1495 Do not attempt to compute the address of the object just before a
1496 buffer; this is not portable.
1497 (Faref, Faset):
1498 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1499 (Faset): Use int, not EMACS_INT, where int is wide enough.
1500 (Fstring_to_number): Don't assume fixnums fit in int.
1501 (Frem): Don't assume arg is nonnegative.
1502 * dbusbind.c (xd_append_arg): Check for integers out of range.
1503 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1504 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1505 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1506 (xd_get_connection_references): Return ptrdiff_t, not int.
1507 All uses changed.
1508 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1509 (xd_read_message_1):
1510 Use int, not unsigned, where the dbus API uses int.
1511 (Fdbus_message_internal): Don't overflow mtype.
1512 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1513 * dired.c (directory_files_internal, file_name_completion, scmp)
1514 (file_name_completion_stat):
1515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1516 (file_name_completion): Don't overflow matchcount.
1517 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1518 * dispextern.h: Adjust decls to match defn changes elsewhere.
1519 (struct text_pos, struct glyph, struct bidi_saved_info)
1520 (struct bidi_string_data, struct bidi_it, struct composition_it)
1521 (struct it):
1522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1523 (struct display_pos, struct composition_it, struct it):
1524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1525 * dispnew.c (increment_matrix_positions)
1526 (increment_row_positions, mode_line_string)
1527 (marginal_area_string):
1528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1529 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1531 (duration_to_sec_usec): New function, to check for overflow better.
1532 (Fsleep_for, sit_for): Use it.
1533 * doc.c (get_doc_string, store_function_docstring):
1534 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1535 (get_doc_string, Fsnarf_documentation):
1536 Use int, not EMACS_INT, where int is wide enough.
1537 (get_doc_string):
1538 Use SAFE_ALLOCA, not alloca.
1539 Check for overflow when converting EMACS_INT to off_t.
1540 * doprnt.c (doprnt):
1541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1542 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1543 Don't assume uid_t fits into fixnum.
1544 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1545 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1546 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1547 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1548 (general_insert_function)
1549 (Finsert_char, make_buffer_string, make_buffer_string_both)
1550 (update_buffer_properties, Fbuffer_substring)
1551 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1552 (Fsubst_char_in_region, check_translation)
1553 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1554 (transpose_markers, Ftranspose_regions):
1555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1556 (clip_to_bounds): Move to lisp.h as an inline function).
1557 (Fconstrain_to_field): Don't assume integers are nonnegative.
1558 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1559 (Fsubst_char_in_region, Fsave_restriction):
1560 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1561 (Femacs_pid): Don't assume pid_t fits into fixnum.
1562 (lo_time): Use int, not EMACS_INT, when int suffices.
1563 (lisp_time_argument): Check for usec out of range.
1564 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1565 (Fuser_login_name, Fuser_full_name): Signal an error
1566 if a uid argument is out of range, rather than relying on
1567 undefined behavior.
c8d5c857
PE
1568 (Fformat_time_string): Remove now-unnecessary check.
1569 lisp_time_argument checks for out-of-range usec now.
243e0530 1570 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1571 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1572 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1573 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1574 (init_cmdargs, Fdump_emacs):
1575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1576 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1577 the bottom (typically) 32 bits of the fixnum.
1578 * eval.c (specpdl_size, call_debugger):
1579 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1580 (when_entered_debugger, Fbacktrace_debug):
1581 Don't assume fixnum can fit in int.
1582 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1583 the object just before a buffer; this is not portable.
1584 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1585 (grow_specpdl, unbind_to):
1586 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1587 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1588 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1589 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1590 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1591 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1593 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1594 (a_write, e_write):
1595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1596 (Fcopy_file, non_regular_nbytes, read_non_regular)
1597 (Finsert_file_contents):
1598 Use int, not EMACS_INT, where int is wide enough.
1599 (READ_BUF_SIZE): Verify that it fits in int.
1600 (Finsert_file_contents): Check that counts are in proper range,
1601 rather than assuming fixnums fit into ptrdiff_t etc.
1602 Don't assume fixnums fit into int.
125b3835 1603 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1604 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1605 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1606 (string_char_to_byte, string_byte_to_char)
1607 (string_make_multibyte, string_to_multibyte)
1608 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1609 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1610 (substring_both, Fdelete, internal_equal, Ffillarray)
1611 (Fclear_string, mapcar1)
1612 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1613 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1614 (larger_vector, make_hash_table, maybe_resize_hash_table)
1615 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1616 (Fmaphash, secure_hash):
1617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1618 (concat): Check for string index and length overflow.
1619 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1620 (Frequire):
1621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1622 (larger_vector): New API (vec, incr_min, size_max) replaces old
1623 one (vec, new_size, init). This catches size overflow.
1624 INIT was removed because it was always Qnil.
1625 All callers changed.
1626 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1627 the upper bound on a hash table index size.
1628 (make_hash_table, maybe_resize_hash_table): Use it.
1629 (secure_hash): Computer start_byte and end_byte only after
1630 they're known to be in ptrdiff_t range.
1631 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1632 (Ffont_get_glyphs, Ffont_at):
1633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1634 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1635 (Flist_fonts, Fopen_font):
1636 Don't assume fixnum can fit in int.
1637 (check_gstring): Don't assume index can fit in int.
1638 (font_match_p): Check that fixnum is a character, not a nonnegative
1639 fixnum, since the later code needs to stuff it into an int.
1640 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1641 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1642 conversion overflow issues.
1643 (Fopen_font): Check for integer out of range.
1644 (Ffont_get_glyphs): Don't assume index can fit in int.
1645 * font.h: Adjust decls to match defn changes elsewhere.
1646 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1647 integer overflow.
1648 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1649 printmax_t, where ptrdiff_t is wide enough.
1650 (Finternal_char_font):
1651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1652 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1653 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1654 (Fset_frame_position, x_set_frame_parameters)
1655 (x_set_line_spacing, x_set_border_width)
1656 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1657 Check that fixnums are in proper range for system types.
1658 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1660 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1661 Use SAFE_ALLOCA_LISP, not alloca.
1662 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1663 intptr_t is wide enough.
1664 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1665 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1666 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1667 Check for fixnum out of range.
1668 * ftfont.c (ftfont_list): Don't assume index fits in int.
1669 Check that fixnums are in proper range for system types.
1670 (ftfont_shape_by_flt):
1671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1672 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1674 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1675 Check that fixnums are in proper range for system types.
1676 * gnutls.h: Adjust decls to match defn changes elsewhere.
1677 * gtkutil.c (xg_dialog_run):
1678 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1679 (update_frame_tool_bar):
1680 Check that fixnums are in proper range for system types.
1681 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1682 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1683 * indent.c (last_known_column, last_known_column_point):
1684 (current_column_bol_cache):
1685 (skip_invisible, current_column, check_display_width):
1686 (check_display_width, scan_for_column, current_column_1)
1687 (Findent_to, Fcurrent_indentation, position_indentation)
1688 (indented_beyond_p, Fmove_to_column, compute_motion):
1689 (Fcompute_motion, Fvertical_motion):
1690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1691 (last_known_column_modified): Use EMACS_INT, not int.
1692 (check_display_width):
1693 (Fcompute_motion):
1694 Check that fixnums and floats are in proper range for system types.
1695 (compute_motion): Don't assume index or fixnum fits in int.
1696 (compute_motion, Fcompute_motion):
1697 Use int, not EMACS_INT, when it is wide enough.
1698 (vmotion): Omit local var start_hpos that is always 0; that way
1699 we don't need to worry about overflow in expressions involving it.
1700 * indent.h: Adjust decls to match defn changes elsewhere.
1701 (struct position):
1702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1703 Use int, not EMACS_INT, where int is wide enough.
1704 Remove unused members ovstring_chars_done and tab_offset;
1705 all uses removed.
1706 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1707 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1708 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1709 (make_gap, copy_text, insert, insert_and_inherit)
1710 (insert_before_markers, insert_before_markers_and_inherit)
1711 (insert_1, count_combining_before, count_combining_after)
1712 (insert_1_both, insert_from_string)
1713 (insert_from_string_before_markers, insert_from_string_1)
1714 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1715 (adjust_after_replace, adjust_after_insert, replace_range)
1716 (replace_range_2, del_range, del_range_1, del_range_byte)
1717 (del_range_both, del_range_2, modify_region)
1718 (prepare_to_modify_buffer, signal_before_change)
1719 (signal_after_change, Fcombine_after_change_execute):
1720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1721 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1722 (balance_an_interval, split_interval_right, split_interval_left)
1723 (find_interval, next_interval, update_interval)
1724 (adjust_intervals_for_insertion, delete_node, delete_interval)
1725 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1726 (static_offset_intervals, offset_intervals)
1727 (merge_interval_right, merge_interval_left, make_new_interval)
1728 (graft_intervals_into_buffer, temp_set_point_both)
1729 (temp_set_point, set_point, adjust_for_invis_intang)
1730 (set_point_both, move_if_not_intangible, get_property_and_range)
1731 (get_local_map, copy_intervals, copy_intervals_to_string)
1732 (compare_string_intervals, set_intervals_multibyte_1):
1733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1734 * intervals.h: Adjust decls to match defn changes elsewhere.
1735 (struct interval):
1736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1737 * keyboard.c (this_command_key_count, this_single_command_key_start)
1738 (before_command_key_count, before_command_echo_length, echo_now)
1739 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1740 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1741 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1742 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1744 (last_non_minibuf_size, last_point_position, echo_truncate)
1745 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1746 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1747 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1748 (stuff_buffered_input):
1749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1750 (last_auto_save, command_loop_1, read_char):
1751 Use EMACS_INT, not int, to avoid integer overflow.
1752 (record_char): Avoid overflow in total_keys computation.
1753 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1754 * keyboard.h: Adjust decls to match defn changes elsewhere.
1755 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1756 (Fkey_description, Fdescribe_vector, Flookup_key):
1757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1758 (click_position): New function, to check that positions are in range.
1759 (Fcurrent_active_maps):
1760 (describe_command):
1761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1762 (Faccessible_keymaps, Fkey_description):
1763 (preferred_sequence_p):
1764 Don't assume fixnum can fit into int.
1765 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1766 Check for integer overflow in size calculations.
1767 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1768 avoid mishandling large integers.
1769 * lisp.h: Adjust decls to match defn changes elsewhere.
1770 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1771 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1772 (struct Lisp_Marker):
1773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1774 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1775 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1776 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1777 All callers changed.
1778 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1779 Assume the arg has valid form, since it always does.
1780 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1781 unsigned integer system type.
1782 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1783 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1785 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1786 (duration_to_sec_usec): New decl.
1787 * lread.c (read_from_string_index, read_from_string_index_byte)
1788 (read_from_string_limit, readchar, unreadchar, openp)
1789 (read_internal_start, read1, oblookup):
1790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1791 (Fload, readevalloop, Feval_buffer, Feval_region):
1792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1793 (openp): Check for out-of-range argument to 'access'.
1794 (read1): Use int, not EMACS_INT, where int is wide enough.
1795 Don't assume fixnum fits into int.
6efdadfd 1796 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1797 (read_filtered_event): Use duration_to_sec_usec
1798 to do proper overflow checking on durations.
d311d28c
PE
1799 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1800 in size calculation.
1801 (Fexecute_kbd_macro):
1802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1803 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1804 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1805 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1806 (set_marker_both, set_marker_restricted_both, marker_position)
1807 (marker_byte_position, Fbuffer_has_markers_at):
1808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1809 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1810 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1811 It now merely ensures that the menu is large enough, without
1812 necessarily growing it, as this avoids some integer overflow issues.
1813 All callers changed.
1814 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1816 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1817 Use SAFE_ALLOCA_LISP, not alloca.
1818 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1819 to EMACS_INT. Check that fixnums are in proper range for system types.
1820 * minibuf.c (minibuf_prompt_width, string_to_object)
1821 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1822 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1824 (get_minibuffer, read_minibuf_unwind):
1825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1826 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1827 this simplifies overflow checking. All callers changed.
1828 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1829 (Ftest_completion):
1830 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1831 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1832 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1833 Check that fixnums are in proper range for system types.
1834 (Fx_create_frame, Fx_show_tip):
1835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1836 * nsfont.m (ns_findfonts, nsfont_list_family):
1837 Don't assume fixnum fits in long.
1838 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1840 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1841 wide enough.
17fdb222 1842 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1843 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1844 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1845 (PRINTDECLARE, PRINTPREPARE):
1846 (strout, print_string):
1847 (print, print_preprocess, print_check_string_charset_prop)
1848 (print_object):
1849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1850 (PRINTDECLARE):
1851 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1853 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1854 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1855 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1856 (print_error_message): Use SAFE_ALLOCA, not alloca.
1857 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1858 (print_depth, new_backquote_output, print_number_index):
1859 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1860 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1861 (Fset_process_window_size, Fformat_network_address)
1862 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1863 (sigchld_handler):
d311d28c 1864 Check that fixnums are in proper range for system types.
d44287d4 1865 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1866 Check for process-ids out of pid_t range rather than relying on
1867 undefined behavior.
e4d81efc 1868 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1869 (Fformat_network_address, read_process_output, send_process)
1870 (Fprocess_send_region, status_notify):
1871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1872 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1873 (wait_reading_process_output, read_process_output, exec_sentinel):
1874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1875 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1876 (Faccept_process_output): Use duration_to_sec_usec to do proper
1877 overflow checking on durations.
dde14581
PE
1878 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1879 Don't assume pid_t fits in int.
02481186
PE
1880 * process.h (struct Lisp_Process): Members tick and update_tick
1881 are now of type EMACS_INT, not int.
b62b53e8
PE
1882 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1883 configured --with-wide-int.
d311d28c
PE
1884 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1885 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1886 * search.c (looking_at_1, string_match_1):
1887 (fast_string_match, fast_c_string_match_ignore_case)
1888 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1889 (scan_newline, find_before_next_newline, search_command)
1890 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1891 (set_search_regs, wordify):
1892 (Freplace_match):
1893 (Fmatch_data):
1894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1895 (string_match_1, search_buffer, set_search_regs):
1896 (Fmatch_data):
1897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1898 (wordify): Check for overflow in size calculation.
1899 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1900 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1901 Check that fixnums are in proper range for system types.
1902 * sound.c (struct sound_device)
1903 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1905 (Fplay_sound_internal):
1906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1907 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1908 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1909 (Fparse_partial_sexp):
1910 Don't assume fixnums can fit in int.
1911 (struct lisp_parse_state, find_start_pos, find_start_value)
1912 (find_start_value_byte, find_start_begv)
1913 (update_syntax_table, char_quoted, dec_bytepos)
1914 (find_defun_start, prev_char_comend_first, back_comment):
1915 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1916 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1918 (Finternal_describe_syntax_value): Check that match_lisp is a
1919 character, not an integer, since the code stuffs it into int.
1920 (scan_words, scan_sexps_forward):
1921 Check that fixnums are in proper range for system types.
1922 (Fforward_word):
1923 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1924 (scan_sexps_forward):
1925 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1926 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1927 * syntax.h: Adjust decls to match defn changes elsewhere.
1928 (struct gl_state_s):
1929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1930 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1931 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1932 * sysdep.c (wait_for_termination_1, wait_for_termination)
1933 (interruptible_wait_for_termination, mkdir):
1934 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1935 (emacs_read, emacs_write):
1936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1937 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1938 and double all fit in int.
d311d28c
PE
1939 * term.c (set_tty_color_mode):
1940 Check that fixnums are in proper range for system types.
1941 * termhooks.h (struct input_event):
1942 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1943 * textprop.c (validate_interval_range, interval_of)
1944 (Fadd_text_properties, set_text_properties_1)
1945 (Fremove_text_properties, Fremove_list_of_text_properties)
1946 (Ftext_property_any, Ftext_property_not_all)
1947 (copy_text_properties, text_property_list, extend_property_ranges)
1948 (verify_interval_modification):
1949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1950 (Fnext_single_char_property_change)
1951 (Fprevious_single_char_property_change):
1952 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1953 (copy_text_properties):
1954 Check for integer overflow in index calculation.
d311d28c
PE
1955 * undo.c (last_boundary_position, record_point, record_insert)
1956 (record_delete, record_marker_adjustment, record_change)
1957 (record_property_change):
1958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1959 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1960 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1961 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1962 (Fx_hide_tip, Fx_file_dialog):
1963 * w32menu.c (set_frame_menubar):
1964 Use ptrdiff_t, not int, for consistency with rest of code.
1965 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1966 (select_window, Fdelete_other_windows_internal)
1967 (window_scroll_pixel_based, window_scroll_line_based)
1968 (Frecenter, Fset_window_configuration):
1969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1970 (Fset_window_hscroll, run_window_configuration_change_hook)
1971 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1972 (Fscroll_other_window, Frecenter):
d311d28c
PE
1973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1974 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1975 Don't assume fixnum fits in int.
1976 (Fset_window_scroll_bars):
1977 Check that fixnums are in proper range for system types.
1978 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1979 (string_pos, c_string_pos, number_of_chars, init_iterator)
1980 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1981 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1982 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1983 (face_before_or_after_it_pos, handle_invisible_prop)
1984 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1985 (display_prop_intangible_p, string_buffer_position_lim)
1986 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1987 (get_overlay_strings_1, get_overlay_strings)
1988 (iterate_out_of_display_property, forward_to_next_line_start)
1989 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1990 (get_next_display_element, set_iterator_to_next)
1991 (get_visually_first_element, compute_stop_pos_backwards)
1992 (handle_stop_backwards, next_element_from_buffer)
1993 (move_it_in_display_line_to, move_it_in_display_line)
1994 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1995 (add_to_log, message_dolog, message_log_check_duplicate)
1996 (message2, message2_nolog, message3, message3_nolog
1997 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1998 (current_message_1, truncate_echo_area, truncate_message_1)
1999 (set_message, set_message_1, store_mode_line_noprop)
2000 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2001 (text_outside_line_unchanged_p, check_point_in_composition)
2002 (reconsider_clip_changes)
2003 (redisplay_internal, set_cursor_from_row, try_scrolling)
2004 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2005 (redisplay_window, find_last_unchanged_at_beg_row)
2006 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2007 (trailing_whitespace_p, find_row_edges, display_line)
2008 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2009 (display_mode_element, store_mode_line_string)
2010 (pint2str, pint2hrstr, decode_mode_spec)
2011 (display_count_lines, display_string, draw_glyphs)
2012 (x_produce_glyphs, x_insert_glyphs)
2013 (rows_from_pos_range, mouse_face_from_buffer_pos)
2014 (fast_find_string_pos, mouse_face_from_string_pos)
2015 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2017 (safe_call, init_from_display_pos, handle_fontified_prop)
2018 (handle_single_display_spec, load_overlay_strings)
2019 (with_echo_area_buffer, setup_echo_area_for_printing)
2020 (display_echo_area, echo_area_display)
2021 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2022 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2023 (redisplay_window, dump_glyph_row, display_mode_line)
2024 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2025 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2027 (handle_single_display_spec, build_desired_tool_bar_string)
2028 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2029 (get_specified_cursor_type):
2030 Check that fixnums are in proper range for system types.
2031 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2032 (Flookup_image_map):
2033 Don't assume fixnums fit in int.
2034 (compare_overlay_entries):
2035 Avoid mishandling comparisons due to subtraction overflow.
2036 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2037 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2038 (handle_tool_bar_click):
2039 Use int, not unsigned, since we prefer signed and the signedness
2040 doesn't matter here.
2041 (get_next_display_element, next_element_from_display_vector):
2042 Use int, not EMACS_INT, when int is wide enough.
2043 (start_hourglass): Use duration_to_sec_usec to do proper
2044 overflow checking on durations.
2045 * xfaces.c (Fbitmap_spec_p):
2046 Check that fixnums are in proper range for system types.
2047 (compare_fonts_by_sort_order):
2048 Avoid mishandling comparisons due to subtraction overflow.
2049 (Fx_family_fonts, realize_basic_faces):
2050 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2051 (Fx_family_fonts):
2052 Don't assume fixnum fits in int.
2053 Use SAFE_ALLOCA_LISP, not alloca.
2054 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2055 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2056 (face_at_buffer_position, face_for_overlay_string)
2057 (face_at_string_position):
2058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2059 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2060 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2061 (Fx_show_tip):
2062 Check that fixnums are in proper range for system types.
2063 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2064 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2066 (Fx_change_window_property): Don't assume fixnums fit in int.
2067 * xfont.c (xfont_chars_supported):
2068 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2069 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2070 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2072 * xml.c (parse_region):
2073 * xrdb.c (magic_file_p):
2074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2075 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2076 (x_get_local_selection, x_reply_selection_request)
2077 (x_handle_selection_request, wait_for_property_change):
2078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2079 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2080 short is wide enough.
2081 (x_send_client_event): Don't assume fixnum fits in int.
2082 * xterm.c (x_x_to_emacs_modifiers):
2083 Don't assume EMACS_INT overflows nicely into int.
2084 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2085 may come from Lisp.
2086 (handle_one_xevent): NATNUMP can eval its arg twice.
2087 (x_connection_closed):
2088 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2089 * xterm.h: Adjust decls to match defn changes elsewhere.
2090 (struct scroll_bar): Use struct vectorlike_header
2091 rather than rolling our own approximation.
2092 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2093
c6574eb5
GM
20942012-05-25 Glenn Morris <rgm@gnu.org>
2095
2096 * lisp.mk (lisp): Update for more files being compiled now.
2097
e8d32c7e
SM
20982012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2099
48def666
SM
2100 * lread.c: Remove `read_pure' which makes no difference.
2101 (read_pure): Remove var.
2102 (unreadpure): Remove function.
2103 (readevalloop): Don't call read_list with -1 flag.
2104 (read1, read_vector): Don't test read_pure any more.
2105 (read_list): Simplify.
2106
e8d32c7e
SM
2107 * fileio.c, character.h: Minor style tweaks.
2108
4b2addb7
DA
21092012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2110
2111 * window.h (clip_changed): Remove useless declaration.
2112
584461b2
JB
21132012-05-22 Juanma Barranquero <lekktu@gmail.com>
2114
2115 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2116 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2117
34374650
PE
21182012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2119
2120 Remove src/m/*.
2121 This directory predates autoconf and is no longer needed nowadays.
2122 Move its few remaining bits of functionality to where they're needed.
2123 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2124 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2125 * m/template.h: Remove.
2126 * Makefile.in (M_FILE): Remove. All uses removed.
2127 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2128 * lisp.h (USE_LSB_TAG):
2129 * mem-limits.h (EXCEEDS_LISP_PTR):
2130 Use VAL_MAX, not VALBITS, in #if.
2131 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2132 (EMACS_UINT): Define unconditionally now.
2133 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2134 (BITS_PER_EMACS_INT): New constants, replacing
2135 what used to be in config.h, but not useful in #if.
2136 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2137 define them any more.
2138 (VAL_MAX): New macro.
2139 (VALMASK): Use it.
2140 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2141 BITS_PER_EMACS_INT, in #if.
2142 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2143 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2144 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2145 * s/ms-w32.h (DATA_START):
2146 Move here from removed file m/intel386.h.
2147 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2148 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2149
261cb4bb
PE
21502012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2151
2152 Assume C89 or later.
2153 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2154 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2155 (xrealloc):
2156 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2157 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2158 * textprop.c, tparam.c (NULL): Remove.
2159 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2160 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2161 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2162 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2163 * xterm.c (input_signal_count): Assume volatile works.
2164
ff23cd9f
KB
21652012-05-21 Ken Brown <kbrown@cornell.edu>
2166
2167 * xgselect.c (xg_select): Fix first argument in call to 'select'
2168 (bug#11508).
2169
1b170bc6
KB
21702012-05-20 Ken Brown <kbrown@cornell.edu>
2171
2172 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2173 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2174
b2f4d39f
KB
21752012-05-19 Ken Brown <kbrown@cornell.edu>
2176
2177 * xfns.c (x_in_use): Remove `static' qualifier.
2178 * xterm.h (x_in_use): Declare.
2179 * xgselect.c: Include xterm.h.
2180 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2181 and `display_arg' (bug#9754).
2182
003fdae2
PE
21832012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2184
9232a6d9
PE
2185 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2186
003fdae2
PE
2187 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2188 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2189
784b56e2
EZ
21902012-05-18 Eli Zaretskii <eliz@gnu.org>
2191
2192 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2193
2194 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2195 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2196
2197 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2198 reference to image_cache->refcount.
2199 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2200
a0a79cde
JL
22012012-05-17 Juri Linkov <juri@jurta.org>
2202
2203 * search.c (Fword_search_regexp, Fword_search_backward)
2204 (Fword_search_forward, Fword_search_backward_lax)
2205 (Fword_search_forward_lax): Move functions to isearch.el
2206 (bug#10145, bug#11381).
2207
b0572523
PE
22082012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2209
2210 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2211
9660f5fc
SM
22122012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2213
2214 * lread.c (init_obarray): Declare Qt and Qnil as special.
2215
4374de83
GM
22162012-05-14 Glenn Morris <rgm@gnu.org>
2217
2218 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2219 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2220
dc44c39a
PE
22212012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2222
078c97cb
PE
2223 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2224
dc44c39a
PE
2225 * unexaix.c: Port to more-recent AIX compilers.
2226 (report_error, report_error_1, make_hdr, copy_sym)
2227 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2228 Make arguments const char *, not char *, to avoid violations of C
2229 standard and to fix some AIX warnings reported by Gilles Pion.
2230
e18afed7 22312012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2232
2233 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2234 already have overlays loaded.
2235 (handle_single_display_spec): Before returning without displaying
2236 fringe bitmap, synchronize the bidi iterator with the main display
2237 iterator, by calling iterate_out_of_display_property.
2238 (iterate_out_of_display_property): Detect buffer iteration by
2239 testing that it->string is a Lisp string.
2240 (get_next_display_element): When the current object is exhausted,
2241 and there's something on it->stack, call set_iterator_to_next to
2242 proceed with what's on the stack, instead of returning zero.
2243 (set_iterator_to_next): If called at the end of a Lisp string,
2244 proceed to consider_string_end without incrementing string
2245 position. Don't increment display vector index past the end of
2246 the display vector. (Bug#11417)
c8fb9dc6
EZ
2247 (pos_visible_p): Don't report a position visible when move_it_to
2248 stopped at the last line of window, which happens to be scanned
2249 backwards by the bidi iteration. (Bug#11464)
ac268e67 2250
e18afed7 22512012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2252
2253 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2254 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2255 are on a TTY, and thus unable to display on the fringes.
2256 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2257 so we need to signal to the caller that this is a "replacing"
2258 display spec. This fixes display when the spec is invalid or we
2259 are on a TTY.
2260
e18afed7 22612012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2262
2263 * unexaix.c (make_hdr): Fix typo in prototype.
2264 This bug broke the build on AIX. Problem reported by Gilles Pion.
2265
9d0a235a
MA
22662012-05-14 Michael Albinus <michael.albinus@gmx.de>
2267
2268 * keyboard.c (kbd_buffer_get_event): Read special events also in
2269 batch mode. (Bug#11415)
2270
9e6b06ed
GM
22712012-05-12 Glenn Morris <rgm@gnu.org>
2272
2273 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2274
c1a1d7a3
EZ
22752012-05-12 Eli Zaretskii <eliz@gnu.org>
2276
2277 * lisp.mk (lisp): Add newcomment.elc.
2278
3fe7cdc8
GM
22792012-05-12 Glenn Morris <rgm@gnu.org>
2280
2281 * Makefile.in (MKDIR_P): New, set by configure.
2282 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2283
53f7d2c0
PE
22842012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2285
2286 Remove unused function hourglass_started.
2287 * dispextern.h (hourglass_started):
2288 * w32fns.c (hourglass_started):
2289 * xdisp.c (hourglass_started): Remove.
2290
75aafb17
JB
22912012-05-10 Juanma Barranquero <lekktu@gmail.com>
2292
2293 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2294 Update dependencies.
2295
12959e8e
PE
22962012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2297
97107e2e
PE
2298 * xgselect.c (xg_select): Put maxfds+1 into a var.
2299 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2300
12959e8e
PE
2301 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2302
836d29b3
DA
23032012-05-10 Dave Abrahams <dave@boostpro.com>
2304
2305 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2306 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2307
5cb67954
MA
23082012-05-09 Michael Albinus <michael.albinus@gmx.de>
2309
2310 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2311 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2312 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2313 Initialize xd_registered_buses.
2314
3478ec45
PE
23152012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2316
b263a6b0
PE
2317 Untag more efficiently if USE_LSB_TAG.
2318 This is based on a proposal by YAMAMOTO Mitsuharu in
2319 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2320 For an admittedly artificial (nth 8000 longlist) benchmark on
2321 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2322 Emacs's overall text size by 1%.
2323 * lisp.h (XUNTAG): New macro.
2324 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2325 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2326 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2327 * eval.c (Fautoload):
2328 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2329 * frame.h (XFRAME): Use XUNTAG.
2330
3478ec45
PE
2331 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2332 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2333 Remove unportable assumptions about print widths of types like
2334 dbus_uint32_t.
2335 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2336 intptr_t when converting between pointer and integer, to avoid GCC
2337 warnings about wrong width.
2338
666b903b 23392012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2340
2341 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2342 stack for each reader_thread, instead of defaulting to 8MB
2343 determined by the linker. This avoids failures in creating
2344 subprocesses on Windows 7, see the discussion in this thread:
2345 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2346
b120cc17
JC
23472012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2348
2349 Fix up display of the *Minibuf-0* buffer in the mini window.
2350 * keyboard.c (read_char): Don't clear the echo area if there's no
2351 message to clear.
2352 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2353 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2354
9a4b36f8
MA
23552012-05-07 Michael Albinus <michael.albinus@gmx.de>
2356
2357 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2358 batch mode.
2359
e5f9458f
CY
23602012-05-06 Chong Yidong <cyd@gnu.org>
2361
2362 * lisp.mk (lisp): Update.
2363
eceeb5fc 23642012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2365
2366 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2367
71873e2b
SM
23682012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2369
2370 * data.c (PUT_ERROR): New macro.
2371 (syms_of_data): Use it. Add new error type `user-error'.
2372 * undo.c (user_error): New function.
2373 (Fprimitive_undo): Use it.
2374 * print.c (print_error_message): Adjust print style for `user-error'.
2375 * keyboard.c (user_error): New function.
2376 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2377
ab0fa4e4
PE
23782012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 Do not limit current-time-string to years 1000..9999.
2381 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2382 (Fcurrent_time_string): Support any year that is supported by the
2383 underlying localtime representation. Don't use asctime, as it
2384 has undefined behavior for years outside the range -999..9999.
2385
7ed806a7
PE
23862012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2387
2388 Fix race conditions involving setenv, gmtime, localtime, asctime.
2389 Without this fix, interrupts could mess up code that uses these
2390 nonreentrant functions, since setting TZ invalidates existing
2391 tm_zone or tzname values, and since most of these functions return
2392 pointers to static storage.
2393 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2394 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2395 Grow the critical sections to include not just invoking
2396 localtime/gmtime, but also accessing these functions' results
2397 including their tm_zone values if any, and any related TZ setting.
2398 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2399 so that the struct tm is saved in the critical section.
2400 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2401 motivated by the fact that memory allocation needs to be outside
2402 the critical section.
2403
0c16dfed
DA
24042012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2405
2406 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2407 with RESET_INTERVAL.
2408
2409 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2410 Remove duplicated buffer name initialization.
2411
3f83ace8
JM
24122012-05-02 Jim Meyering <jim@meyering.net>
2413
2414 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2415
c7b8541e
JM
2416 * xfns.c (x_window): Use xstrdup (Bug#11375).
2417
90207a15 24182012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2419
2420 * xdisp.c (pos_visible_p): If already at a newline from the
2421 display string before the 'while' loop, don't walk back the glyphs
2422 from it3.glyph_row. Solves assertion violation when the display
2423 string begins with a newline (egg.el). (Bug#11367)
2424
b593d6a9
AH
24252012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2426
2427 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2428 Move to simple.el.
2429
4737362e
GM
24302012-05-01 Glenn Morris <rgm@gnu.org>
2431
99cf43f9
GM
2432 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2433 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2434 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2435 All were removed before 23.1.
2436
9311dcff
GM
2437 * dispnew.c: Remove HAVE_LIBNCURSES test;
2438 it is always true on relevant platforms.
2439
4d5c6349
GM
2440 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2441 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2442
4737362e
GM
2443 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2444
74dd3a6b
AS
24452012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2446
2447 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2448 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2449 Remove.
2450
13c379ee
PE
24512012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 Do not avoid creating empty evaporating overlays (Bug#9642).
2454 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2455 That is, do not delete an evaporating overlay if it becomes
2456 empty after its bounds are adjusted to fit within its buffer.
2457 This fix caused other problems, and I'm reverting it until we get
2458 to the bottom of them.
2459
a8e7d6d7 24602012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2461
2462 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2463
a8e7d6d7 24642012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2465
2466 * xdisp.c (pos_visible_p): If the window start position is beyond
2467 ZV, start the display from buffer beginning. Prevents assertion
2468 violation in init_iterator when the minibuffer window is scrolled
2469 via the scroll bar.
2470
2471 * window.c (window_scroll_pixel_based): Likewise.
2472
a8e7d6d7 24732012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2474
2475 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2476
a8e7d6d7 24772012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2478
2479 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2480 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2481
a8e7d6d7 24822012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2483
b593d6a9
AH
2484 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2485 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2486
1c6900d9
EZ
24872012-04-26 Eli Zaretskii <eliz@gnu.org>
2488
4c3fa1d9
EZ
2489 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2490 display element, check also the underlying string or buffer
2491 character. (Bug#11341)
2492
1c6900d9
EZ
2493 * w32menu.c: Include w32heap.h.
2494 (add_menu_item): If the call to AppendMenuW (via
2495 unicode_append_menu) fails, disable Unicode menus only if we are
2496 running on Windows 9X/Me.
2497
42bf8205
AS
24982012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2499
2500 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2501 (xgetint): Add missing shift for LSB tags.
2502
b1bac16e
MR
25032012-04-24 Martin Rudalics <rudalics@gmx.at>
2504
2505 * keyboard.c (read_char): Don't wipe echo area for select window
2506 events: These might get delayed via `mouse-autoselect-window'
2507 (Bug#11304).
2508
d69621cc
JB
25092012-04-24 Juanma Barranquero <lekktu@gmail.com>
2510
2511 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2512 manipulation of :loaded-from data.
2513
02fd101b
JB
25142012-04-23 Juanma Barranquero <lekktu@gmail.com>
2515
2516 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2517 now a cons (bug#11311).
2518
888bec30
PE
25192012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2520
89a438bd
PE
2521 Do not create empty overlays with the evaporate property (Bug#9642).
2522 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2523 if it becomes empty after its bounds are adjusted to fit within
2524 its buffer. Without this fix, in a nonempty buffer (let ((o
2525 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2526 yields an empty overlay that has the evaporate property, which is
2527 not supposed to happen.
2528
1068fe4d
PE
2529 Fix minor GTK3 problems found by static checking.
2530 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2531 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2532 (struct _EmacsFixedClass, emacs_fixed_get_type):
2533 Move decls here from emacsgtkfixed.h, since they needn't be public.
2534 (emacs_fixed_get_type): Now static.
2535 (emacs_fixed_class_init): Omit unused local.
2536 (emacs_fixed_child_type): Remove; unused.
2537 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2538 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2539 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2540 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2541 (EMACS_FIXED_GET_CLASS): Remove; unused.
2542 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2543
888bec30
PE
2544 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2545 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2546
de85e130
PE
25472012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2548
d0baac98 2549 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2550 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2551 (__malloc_size_t, __malloc_ptrdiff_t):
2552 Remove. All uses removed, replaced by the definiens if needed,
2553 since we can assume C89 or better now.
2554 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2555 (protect_malloc_state, align, get_contiguous_space)
2556 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2557 (malloc_atfork_handler_child, malloc_enable_thread)
2558 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2559 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2560 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2561 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2562 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2563 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2564 Define using prototypes, not old style.
2565 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2566 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2567 (align): Don't assume that signed integer overflow wraps around.
2568 Omit unused local var.
2569 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2570 (_free_internal_nolock, memalign, mallochook, reallochook):
2571 Omit no-longer-needed casts.
2572 (valloc): Use getpagesize, not __getpagesize.
2573 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2574 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2575
de85e130
PE
2576 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2577
dcbf5805
MA
25782012-04-22 Michael Albinus <michael.albinus@gmx.de>
2579
2580 Move functions from C to Lisp. Make non-blocking method calls
2581 the default. Implement further D-Bus standard interfaces.
2582
2583 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2584 (QCdbus_request_name_allow_replacement)
2585 (QCdbus_request_name_replace_existing)
2586 (QCdbus_request_name_do_not_queue)
2587 (QCdbus_request_name_reply_primary_owner)
2588 (QCdbus_request_name_reply_in_queue)
2589 (QCdbus_request_name_reply_exists)
2590 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2591 (QCdbus_registered_serial, QCdbus_registered_method)
2592 (QCdbus_registered_signal): New Lisp objects.
2593 (XD_DEBUG_MESSAGE): Use sizeof.
2594 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2595 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2596 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2597 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2598 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2599 (xd_signature, xd_append_arg): Allow float for integer types.
2600 (xd_get_connection_references): New function.
b593d6a9
AH
2601 (xd_get_connection_address): Rename from xd_initialize.
2602 Return cached address.
dcbf5805
MA
2603 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2604 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2605 level.
2606 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2607 Return number of refcounts.
dcbf5805
MA
2608 (Fdbus_get_unique_name): Make stronger parameter check.
2609 (Fdbus_message_internal): New defun.
2610 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2611 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2612 (Fdbus_send_signal, Fdbus_register_service)
2613 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2614 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2615 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2616 (Vdbus_compiled_version, Vdbus_runtime_version)
2617 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2618 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2619 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2620 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2621 Adapt docstring.
dcbf5805 2622
52828e02
PE
26232012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2624
da05bc4c
PE
2625 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2626 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2627 Do not assume ptrdiff_t is the same width as 'int'.
2628
52828e02
PE
2629 * alloc.c: Handle unusual debugging option combinations.
2630 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2631 since the two debugging options are incompatible.
2632 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2633 is defined.
2634 (mem_init, mem_insert, mem_insert_fixup):
2635 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2636 (NEED_MEM_INSERT): Remove; no longer needed.
2637
f01769f9
LL
26382012-04-22 Leo Liu <sdl.web@gmail.com>
2639
2640 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2641
5790543d
PE
26422012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2643
2644 * sysdep.c [__FreeBSD__]: Minor cleanups.
2645 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2646 Use Emacs indenting style more consistently. Avoid some casts.
2647 Use 'double' consistently rather than mixing 'float' and 'double'.
2648
b91b7e4d
EW
26492012-04-21 Eduard Wiebe <usenet@pusto.de>
2650
b593d6a9
AH
2651 * sysdep.c (list_system_processes, system_process_attributes):
2652 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2653
6114eb15
AS
26542012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2655
2656 * lisp.mk (lisp): Update.
2657
2f38dff7
PE
26582012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2659
2660 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2661 It is never used otherwise.
2662
4ae29f89
SM
26632012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2664
2665 * print.c (print_preprocess): Only check print_depth if print-circle
2666 is nil.
2667 (print_object): Check for cycles even when print-circle is nil and
2668 print-gensym is t, but only check print_depth if print-circle is nil.
2669
f30d612a
CY
26702012-04-20 Chong Yidong <cyd@gnu.org>
2671
2672 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2673 set the status to "failed" and ensure that sentinel is run.
2674
c07a4c0b 26752012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2676
2677 * process.c (Fset_process_inherit_coding_system_flag)
2678 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2679 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2680
c07a4c0b 26812012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2682
2683 * xdisp.c (string_buffer_position_lim): Limit starting position to
2684 BEGV.
2685 (set_cursor_from_row): If called for a mode-line or header-line
2686 row, return zero immediately.
2687 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2688 farther than the first row after the header line, if any.
2689 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2690 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2691
c07a4c0b 26922012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2693
4ae29f89
SM
2694 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2695 (bug#11238).
ad3a2b41 2696
c07a4c0b 26972012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 26982012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2699
2700 configure: new option --enable-gcc-warnings (Bug#11207)
2701 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2702 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2703 (ALL_CFLAGS): Use new macros rather than old.
2704 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2705 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2706 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2707 -Wunused-result, -Wunused-variable. This should go away once
2708 the Emacs and Gnulib regex code is merged.
2709 (xmalloc, xrealloc): Now static.
2710
aba027e8
PE
27112012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2712
2713 * dired.c (Fsystem_groups): Remove unused local.
2714
e5a36063
GM
27152012-04-17 Glenn Morris <rgm@gnu.org>
2716
2717 * dired.c (Fsystem_users): Doc fix.
2718
316411f0
DA
27192012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2720
2721 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2722 (syms_of_dired): Add them.
2723
9426aba4
PE
27242012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2725
b62a57be
PE
2726 Fix minor alloc.c problems found by static checking.
2727 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2728 New extern decls, to avoid calling undeclared functions.
2729 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2730 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2731 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2732 (NEED_MEM_INSERT): New macro.
2733 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2734 Remove one incorrect comment and fix another.
b62a57be 2735
3539f31f
PE
2736 Fix minor ralloc.c problems found by static checking.
2737 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2738 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2739 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2740 (r_alloc_sbrk): Now static.
2741
a041960a
PE
2742 Improve ralloc.c interface checking.
2743 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2744 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2745 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2746 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2747 [REL_ALLOC]: ... to here, to check interface.
2748 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2749 Remove decls. This fixes an "It stinks!".
2750
9426aba4
PE
2751 * alloc.c (which_symbols): Fix alignment issue / type clash.
2752
d55c12ed
AS
27532012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2754
2755 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2756 (struct Lisp_Misc_Any): Likewise.
2757 (struct Lisp_Free): Likewise.
2758 * alloc.c (union aligned_Lisp_Symbol): Define.
2759 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2760 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2761 (union aligned_Lisp_Misc): Define.
2762 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2763 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2764 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2765
b948ce8b
PE
27662012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2767
2768 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2769 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2770 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2771 * s/netbsd.h, s/sol2-6.h:
2772 Remove definition of GC_MARK_STACK, since the default now works.
2773 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2774 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2775 no longer the default.
2776 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2777
35dc09a1 27782012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2779
35dc09a1
GM
2780 * lread.c (lisp_file_lexically_bound_p):
2781 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2782
35dc09a1
GM
27832012-04-14 Eli Zaretskii <eliz@gnu.org>
2784
2785 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2786 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2787
27882012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2789
2790 * nsterm.m (constrainFrameRect): Always constrain when there is only
2791 one screen (Bug#10962).
2792
bcd86815
KB
27932012-04-13 Ken Brown <kbrown@cornell.edu>
2794
2795 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2796
c25df26e
RT
27972012-04-13 Reuben Thomas <rrt@sc3d.org>
2798
2799 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2800
0fc59f1e
DC
28012012-04-11 Daniel Colascione <dancol@dancol.org>
2802
2803 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2804 against is gone. It's better to use vfork now so that when Cygwin
2805 gains a new, working vfork, we use it automatically (bug#10398).
2806
de8c03dc
SM
28072012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2808
2809 * window.c (save_window_save): Obey window-point-insertion-type.
2810
2f097256
GM
28112012-04-11 Glenn Morris <rgm@gnu.org>
2812
2813 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2814
453b951e
SM
28152012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2816
2817 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2818
75f1671a 28192012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2820
2821 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2822 (force_quit_count): New var.
2823 (handle_interrupt): Use it.
2824
2a8ce227
JB
28252012-04-10 Juanma Barranquero <lekktu@gmail.com>
2826
2827 * w32.c (w32_delayed_load): Record the full path of the library
2828 being loaded (bug#10424).
2829
935396c0
GM
28302012-04-09 Glenn Morris <rgm@gnu.org>
2831
05920a43
GM
2832 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2833 not just in the obarray, before snarfing them. (Bug#11036)
2834
935396c0
GM
2835 * Makefile.in ($(leimdir)/leim-list.el):
2836 Pass EMACS rather than BUILT_EMACS.
2837
a18ecafa
TZ
28382012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2839
2840 * process.c (make_process):
2841 * process.h: Add integer `gnutls_handshakes_tried' member to
2842 process struct.
2843
6bbef4e5
JC
2844 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2845 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2846
2847 * gnutls.c (gnutls_log_function2i): Convenience log function.
2848 (emacs_gnutls_read): Use new log functions,
2849 `gnutls_handshakes_tried' process member, and
2850 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2851 attempts per process (connection).
2852
b4d3bc10
CY
28532012-04-09 Chong Yidong <cyd@gnu.org>
2854
2855 * eval.c (Fuser_variable_p, user_variable_p_eh)
2856 (lisp_indirect_variable): Functions deleted.
2857 (Fdefvar): Caller changed.
2858
2859 * callint.c (Finteractive, Fcall_interactively):
2860 * minibuf.c (Fread_variable): Callers changed.
2861
70f4d973
EZ
28622012-04-09 Eli Zaretskii <eliz@gnu.org>
2863
2864 * xdisp.c (set_cursor_from_row): If the display string appears in
2865 the buffer at position that is closer to point than the position
2866 after the display string, display the cursor on the first glyph of
2867 the display string. Fixes cursor display when a 'display' text
2868 property immediately follows invisible text. (Bug#11094)
2869
cb3c2e3e
PE
28702012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2871
2872 composite.c: use 'double' consistently
2873 * composite.c (get_composition_id): Use 'double' consistently
2874 instead of converting 'float' to 'double' and vice versa; this is
2875 easier to understand and avoids a GCC warning.
2876
fd06db5d
GM
28772012-04-09 Glenn Morris <rgm@gnu.org>
2878
50fe702a
GM
2879 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2880 preparation for dumping it with emacs. (Bug#4789)
2881 (leimdir): New variable.
2882 ($(leimdir)/leim-list.el): New rule.
2883 (emacs$(EXEEXT)): Depend on leim-list.el.
2884
fd06db5d
GM
2885 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2886 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2887 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2888
55c131ee
AS
28892012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2890
2891 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2892 proper alignment.
2893
9209588f
JB
28942012-04-07 Juanma Barranquero <lekktu@gmail.com>
2895
2896 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2897 Remove unused local variable.
2898
e3fb2efb
PE
28992012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2900
2901 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2902 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2903 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2904 objects, as mark_maybe_pointer will catch them otherwise.
2905 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2906 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2907
b5385551
PE
29082012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2909
2910 Fix typo that broke non-Windows builds.
2911 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2912
9078ead6
EZ
29132012-04-07 Eli Zaretskii <eliz@gnu.org>
2914
2915 Support building on MS-Windows with libxml2.
2916
2917 * makefile.w32-in (OBJ2): Add xml.$(O).
2918 (GLOBAL_SOURCES): Add xml.c.
2919 ($(BLD)/xml.$(O)): New dependency list.
2920
2921 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2922 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2923 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2924 [!WINDOWSNT]: New macros.
2925 (init_libxml2_functions, libxml2_loaded_p): New functions.
2926 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2927 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2928 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2929 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2930 linked in).
6bbef4e5
JC
2931 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2932 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2933 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2934
2935 * emacs.c: Don't include libxml/parser.h.
2936 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2937 xmlCleanupParser directly.
2938
2939 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2940
3811fdf3
EZ
29412012-04-07 Eli Zaretskii <eliz@gnu.org>
2942
2943 * indent.c (Fvertical_motion): If there is a display string at
2944 point, use it.vpos to compute how many lines to backtrack after
2945 move_it_to point. (Bug#11133)
2946
2f8e16b2
EZ
29472012-04-06 Eli Zaretskii <eliz@gnu.org>
2948
2949 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2950 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2951 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2952 macros related to unification of CJK characters. For the details,
2953 see the discussion following the message here:
2954 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2955
3d439cd1
CY
29562012-04-04 Chong Yidong <cyd@gnu.org>
2957
2958 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2959
8bc53d00
EZ
29602012-04-01 Eli Zaretskii <eliz@gnu.org>
2961
2962 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2963 instead of alloca. (Bug#11138)
2964
3b0512a3
AS
29652012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2966
2967 * w32menu.c (is_simple_dialog): Properly check lisp types.
2968 (Bug#11141)
2969
8427ddd2
EZ
29702012-03-31 Eli Zaretskii <eliz@gnu.org>
2971
979022ef
EZ
2972 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2973 position we get to after a call to move_it_to fails the
2974 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2975 only if we wind up in a string from display property. (Bug#11063)
2976
a6b1c7cc
EZ
2977 * window.c (Fdelete_other_windows_internal): Invalidate the row
2978 and column information about mouse highlight, so that redisplay
2979 restores it after reallocating the glyph matrices. (Bug#7464)
2980
8427ddd2
EZ
2981 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2982 string comes from a `display' text property, use the buffer
2983 position of that property as if we actually saw that position in
2984 the row's glyphs.
697ba24b
EZ
2985 (move_it_by_lines): Remove the assertion that
2986 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2987 violated when there's a before-string at the beginning of a line.
2988 (Bug#11063)
8427ddd2 2989
65a0a738
EZ
29902012-03-30 Eli Zaretskii <eliz@gnu.org>
2991
2992 * xdisp.c (append_space_for_newline): If the default face was
2993 remapped, use the remapped face for the appended newline.
2994 (extend_face_to_end_of_line): Use the remapped default face for
2995 extending the face to the end of the line.
2996 (display_line): Call extend_face_to_end_of_line when the default
2997 face was remapped. (Bug#11068)
2998
581355cc
EZ
29992012-03-29 Eli Zaretskii <eliz@gnu.org>
3000
3001 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3002
e8fc049f
SM
30032012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3004
3005 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3006
4fb9a543
GM
30072012-03-27 Glenn Morris <rgm@gnu.org>
3008
3009 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3010 Doc fixes.
3011
679910f1
KH
30122012-03-26 Kenichi Handa <handa@m17n.org>
3013
3014 * dispextern.h (struct glyph): Fix previous change. Change the
3015 bit length of glyphless.ch to 25 (Bug#11082).
3016
90d49b7f
CY
30172012-03-26 Chong Yidong <cyd@gnu.org>
3018
3019 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3020 (command_loop_1): Use it; inhibit selection update for
3021 handle-select-window too (Bug#8996).
3022
f514f6f0
FP
30232012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3024
e8fc049f 3025 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3026
bf43fa51
KH
30272012-03-25 Kenichi Handa <handa@m17n.org>
3028
3029 * dispextern.h (struct glyph): Change the bit length of
3030 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3031
8a0c01dd
EZ
30322012-03-24 Eli Zaretskii <eliz@gnu.org>
3033
3034 * s/ms-w32.h (tzname): Include time.h before redirecting to
3035 _tzname. Fixes the MSVC build. (Bug#9960)
3036
7d1c3a76
AS
30372012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3038
8ed79523
AS
3039 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3040 characters.
3041
7d1c3a76
AS
3042 * xterm.c (XTread_socket): Only modify handling_signal if
3043 !SYNC_INPUT. (Bug#11080)
3044
e99a9b8b
EZ
30452012-03-23 Eli Zaretskii <eliz@gnu.org>
3046
3047 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3048 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3049 when fetching a multibyte character consumes more bytes than
3050 CHAR_BYTES returns, due to unification of CJK characters in
3051 string_char. (Bug#11073)
3052
5063c0e1
TN
30532012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3054
3055 * process.c (wait_reading_process_output): Handle pty disconnect
3056 by refraining from sending oneself a SIGCHLD (bug#10933).
3057
9f851fbd
CY
30582012-03-22 Chong Yidong <cyd@gnu.org>
3059
3060 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3061
5063c0e1 3062 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3063 Mark string as coming from a prefix property.
3064 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3065 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3066
fb5b8aca
CY
30672012-03-21 Chong Yidong <cyd@gnu.org>
3068
3069 * xfaces.c (Vface_remapping_alist): Doc fix.
3070
62356a1b
EZ
30712012-03-20 Eli Zaretskii <eliz@gnu.org>
3072
3073 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3074 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3075 Doc fixes.
62356a1b 3076
025de85b
CY
30772012-03-20 Chong Yidong <cyd@gnu.org>
3078
3079 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3080 to reflect default non-nil value of redisplay-dont-pause.
3081
4827f94e
KH
30822012-03-19 Kenichi Handa <handa@m17n.org>
3083
3084 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3085 it fit in a valid range (Bug#11003).
3086
e50a24a2
EZ
30872012-03-18 Eli Zaretskii <eliz@gnu.org>
3088
3089 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3090 that is not from display property, accept the row as a "cursor
3091 row" if one of the string's character has a non-nil `cursor'
3092 property. Fixes cursor positioning when there are newlines in
3093 overlay strings, e.g. in icomplete.el. (Bug#11035)
3094
9af5ed87
PE
30952012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3096
3097 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3098
d1f55f16
CY
30992012-03-12 Chong Yidong <cyd@gnu.org>
3100
3101 * eval.c (inhibit_lisp_code): Rename from
3102 inhibit_window_configuration_change_hook; move from window.c.
3103
3104 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3105 * window.c (run_window_configuration_change_hook)
3106 (syms_of_window): Callers changed.
3107
66c5eebd
CY
31082012-03-11 Chong Yidong <cyd@gnu.org>
3109
413df973
CY
3110 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3111
66c5eebd
CY
3112 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3113
1de11f56
CY
31142012-03-10 Chong Yidong <cyd@gnu.org>
3115
3116 * frame.c (other_visible_frames): Don't assume the selected frame
3117 is visible (Bug#10955).
3118
cae07000
SM
31192012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3120
3121 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3122
89c94350
JD
31232012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3124
3125 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3126 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3127 zero (Bug#10954).
3128
999dd333
GM
31292012-03-03 Glenn Morris <rgm@gnu.org>
3130
01a6dcc8 3131 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3132
de0100f2
EZ
31332012-03-02 Eli Zaretskii <eliz@gnu.org>
3134
3135 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3136 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3137 (redisplay_window, next_element_from_string): Fix typos in
3138 comments.
3e441275
EZ
3139 (redisplay_window): Pass to move_it_vertically the margin in
3140 pixels, not in screen lines.
de0100f2 3141
96a72ee9
GM
31422012-03-02 Glenn Morris <rgm@gnu.org>
3143
3144 * buffer.c (buffer-list-update-hook): Doc fix.
3145
312508d7
EZ
31462012-02-29 Eli Zaretskii <eliz@gnu.org>
3147
3148 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3149 push_it before setting up the iterator for the first overlay
3150 string, even if we have an empty string loaded.
3151 (next_overlay_string): If there's an empty string on the iterator
3152 stack, pop the stack. (Bug#10903)
3153
27f3c637
PE
31542012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3155
3156 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3157 Suggested by Stefan Monnier in
3158 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3159 * alloc.c (widen_to_Lisp_Object): New static function.
3160 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3161 and widening them to Lisp_Objects. This would work even if
3162 USE_LSB_TAG is defined and wide integers are used, which might
3163 happen in a future version of Emacs.
3164
3c9dfce6
CY
31652012-02-25 Chong Yidong <cyd@gnu.org>
3166
fa74b241
CY
3167 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3168 Doc fix.
3169
3c9dfce6
CY
3170 * xselect.c (Fx_selection_exists_p): Doc fix.
3171 (x_clipboard_manager_save_all): Print an informative message
3172 before saving to clipboard manager.
3173
9486df08
CY
31742012-02-24 Chong Yidong <cyd@gnu.org>
3175
3176 * keyboard.c (process_special_events): Handle all X selection
3177 requests in kbd_buffer, not just the next one (Bug#8869).
3178
f01d3321
CY
31792012-02-23 Chong Yidong <cyd@gnu.org>
3180
3181 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3182 call when setting menu-bar-lines and tool-bar-lines parameters.
3183 (unwind_create_frame_1): New helper function.
3184
3185 * window.c (inhibit_window_configuration_change_hook): New var.
3186 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3187 (syms_of_window): Initialize it.
f01d3321 3188
86b847b6
CY
31892012-02-22 Chong Yidong <cyd@gnu.org>
3190
3191 * xterm.c (x_draw_image_relief): Add missing type check for
3192 Vtool_bar_button_margin (Bug#10743).
3193
a59225b1
CY
31942012-02-21 Chong Yidong <cyd@gnu.org>
3195
3196 * fileio.c (Vfile_name_handler_alist): Doc fix.
3197
3198 * buffer.c (Fget_file_buffer): Protect against invalid file
3199 handler return value.
3200
310f5bd4
PE
32012012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3202
cb3a28cc
PE
3203 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3204 when computing $valmask.
3205
310f5bd4
PE
3206 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3207 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3208 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3209 It's useless in that case, and it can cause problems on hosts
3210 that allocate halves of EMACS_INT values separately.
3211 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3212 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3213 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3214 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3215 it avoids undefined behavior on hosts where shifting right by more
3216 than the word width has undefined behavior.
3217
2375c96a
CY
32182012-02-19 Chong Yidong <cyd@gnu.org>
3219
3220 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3221 (Funhandled_file_name_directory, Ffile_name_as_directory)
3222 (Fdirectory_file_name, Fexpand_file_name)
3223 (Fsubstitute_in_file_name): Protect against invalid file handler
3224 return values (Bug#10845).
3225
3eb49e71
EZ
32262012-02-18 Eli Zaretskii <eliz@gnu.org>
3227
3228 * .gdbinit (pitx): Fix incorrect references to fields of the
3229 iterator stack.
3230
7b926f3f
CY
32312012-02-17 Chong Yidong <cyd@gnu.org>
3232
3233 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3234
11273115
PE
32352012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3236
3237 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3238 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3239
c3a70e2b
CY
32402012-02-15 Chong Yidong <cyd@gnu.org>
3241
3242 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3243 marked as special. Also, starting docstrings with * is obsolete.
3244
0ca43699
AS
32452012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3246
3247 * gnutls.c (emacs_gnutls_write): Fix last change.
3248
2e8f3c56
LI
32492012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3250
3251 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3252 send_process.
3253
af70074f
SM
32542012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3255
3256 * keymap.c (Fsingle_key_description): Handle char ranges.
3257
95986d52
CY
32582012-02-12 Chong Yidong <cyd@gnu.org>
3259
afd83bd1
CY
3260 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3261 as that creates a dangerous corner case.
3262
95986d52
CY
3263 * window.c (Fdelete_window_internal): Invalidate the mouse
3264 highlight (Bug#9904).
3265
bd7da63e
GM
32662012-02-12 Glenn Morris <rgm@gnu.org>
3267
3268 * xselect.c (Fx_own_selection_internal)
3269 (Fx_get_selection_internal, Fx_disown_selection_internal)
3270 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3271 * nsselect.m (Fx_own_selection_internal)
3272 (Fx_disown_selection_internal, Fx_selection_exists_p)
3273 (Fx_selection_owner_p, Fx_get_selection_internal):
3274 Sync docs and argument specs with the xselect.c versions.
3275
77abcbc2
LI
32762012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3277
3278 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3279
90b671e2
EZ
32802012-02-11 Eli Zaretskii <eliz@gnu.org>
3281
1c0ca0b7
EZ
3282 * w32select.c (Fx_selection_exists_p): Sync doc string and
3283 argument list with xselect.c. (Bug#10783)
3284
3285 * w16select.c (Fx_selection_exists_p): Sync doc string and
3286 argument list with xselect.c. (Bug#10783)
90b671e2 3287
49241268
GM
32882012-02-10 Glenn Morris <rgm@gnu.org>
3289
3290 * fns.c (Fsecure_hash): Doc fix.
3291
f998bbe7 32922012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3293
3294 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3295
0992bd9c
CY
32962012-02-07 Chong Yidong <cyd@gnu.org>
3297
3298 * buffer.c (Fbuffer_local_variables)
3299 (buffer_lisp_local_variables): Handle unbound vars correctly;
3300 don't let Qunbound leak into Lisp.
3301
af008560
GM
33022012-02-07 Glenn Morris <rgm@gnu.org>
3303
dd605cc4
GM
3304 * image.c (Fimagemagick_types): Doc fix.
3305
af008560
GM
3306 * image.c (imagemagick-render-type): Change it from a lisp object
3307 to an integer. Move the doc here from the lisp manual.
3308 Treat all values not equal to 0 the same.
3309
1449fa1d
CY
33102012-02-06 Chong Yidong <cyd@gnu.org>
3311
3312 * doc.c (store_function_docstring): Avoid applying docstring of
3313 alias to base function (Bug#2603).
3314
3723ec07
AS
33152012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3316
3317 * .gdbinit (pp1, pv1): Remove redundant defines.
3318 (pr): Use pp.
3319
79c1cc1e
CY
33202012-02-04 Chong Yidong <cyd@gnu.org>
3321
3322 * nsterm.m: Declare a global (Bug#10694).
3323
d7f29f8e
EZ
33242012-02-04 Eli Zaretskii <eliz@gnu.org>
3325
cae07000
SM
3326 * w32.c (get_emacs_configuration_options):
3327 Include --enable-checking, if specified, in the return value.
d7f29f8e 3328
3b95a6f9
MR
33292012-02-04 Martin Rudalics <rudalics@gmx.at>
3330
3331 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3332 after rounding frame sizes. (Bug#9723)
3333
d6fa96a6
EZ
33342012-02-04 Eli Zaretskii <eliz@gnu.org>
3335
3336 * keyboard.c (adjust_point_for_property): Don't position point
3337 before BEGV. (Bug#10696)
3338
df0b2940
PE
33392012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3340
3341 Handle overflow when computing char display width (Bug#9496).
3342 * character.c (char_width): Return EMACS_INT, not int.
3343 (char_width, c_string_width): Check for overflow when
3344 computing the width; this is possible now that individual
3345 characters can have unbounded width. Problem introduced
3346 by merge from Emacs 23 on 2012-01-19.
3347
6bee44d6
MA
33482012-02-02 Michael Albinus <michael.albinus@gmx.de>
3349
3350 * dbusbind.c (Fdbus_register_method): Mention the return value
3351 :ignore in the docstring.
3352
44f92739
GM
33532012-02-02 Glenn Morris <rgm@gnu.org>
3354
1b9f60cc
GM
3355 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3356
44f92739
GM
3357 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3358 Unconditionally set to t. (Bug#10673)
3359 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3360 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3361 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3362
c5d3843c
KH
33632012-02-02 Kenichi Handa <handa@m17n.org>
3364
3365 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3366 0, do not call append_composite_glyph.
3367
159462d4 33682012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3369
3370 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3371 NULL (Bug#6988).
3372 (x_produce_glyphs): If the component of a composition is a null
3373 string, set it->pixel_width to 1 to avoid zero-width glyph.
3374
78cef877
EZ
33752012-02-01 Eli Zaretskii <eliz@gnu.org>
3376
3377 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3378 first 2 arguments are identical. This makes inserting large
3379 output from a subprocess an order of magnitude faster on
3380 MS-Windows, where all sbrk'ed memory is always contiguous.
3381
97897668
GM
33822012-01-31 Glenn Morris <rgm@gnu.org>
3383
3384 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3385 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3386 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3387
31fd3586
GM
33882012-01-29 Glenn Morris <rgm@gnu.org>
3389
3390 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3391
0e24a8b2
CY
33922012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3393
3394 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3395
cc0adcb0
CY
33962012-01-28 Chong Yidong <cyd@gnu.org>
3397
3398 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3399
acc28cb9
CY
34002012-01-26 Chong Yidong <cyd@gnu.org>
3401
9c69cfb7
CY
3402 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3403
acc28cb9
CY
3404 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3405 repeat counts (Bug#10507).
3406
48da7392
GM
34072012-01-26 Glenn Morris <rgm@gnu.org>
3408
3409 * lread.c (syms_of_lread): Doc fix.
3410
14af5f7f
CY
34112012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3412
3413 * coding.c (encode_designation_at_bol): Change return value to
3414 EMACS_INT.
3415
0b21c100
CY
34162012-01-25 Chong Yidong <cyd@gnu.org>
3417
3418 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3419
3c2907f7
CY
34202012-01-21 Chong Yidong <cyd@gnu.org>
3421
3422 * floatfns.c (Fcopysign): Make the second argument non-optional,
3423 since nil is not allowed anyway.
3424
959ad23f
AS
34252012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3426
3427 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3428 (send_process): Likewise.
3429
34a02f46
MR
34302012-01-19 Martin Rudalics <rudalics@gmx.at>
3431
3432 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3433 (Vwindow_persistent_parameters): Do not use Qstate.
3434 Rewrite doc-strings.
34a02f46 3435
1259009a 34362012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3437
3438 * character.c (char_width): New function.
70d4fdf6
GM
3439 (Fchar_width, c_string_width, lisp_string_width):
3440 Use char_width (Bug#9496).
25ed9e61 3441
6a6ee00d
MR
34422012-01-16 Martin Rudalics <rudalics@gmx.at>
3443
3444 * window.c (Vwindow_persistent_parameters): New variable.
3445 (Fset_window_configuration, save_window_save): Handle persistent
3446 window parameters.
3447
c85efaf7
EZ
34482012-01-14 Eli Zaretskii <eliz@gnu.org>
3449
3450 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3451 thrashing the stack of the thread. (Bug#9087)
3452
5944709e
PE
34532012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3454
3455 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3456
e71f5d99
EZ
34572012-01-11 Eli Zaretskii <eliz@gnu.org>
3458
3459 * xdisp.c (rows_from_pos_range): Handle the case where the
3460 highlight ends on a newline. (Bug#10464)
3461 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3462 he end column for display of highlight that ends on a newline
3463 before a R2L line.
3464
ce316182
GM
34652012-01-11 Glenn Morris <rgm@gnu.org>
3466
3467 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3468 from load-path also when installation-directory is nil. (Bug#10208)
3469
5b43da69
GM
34702012-01-10 Glenn Morris <rgm@gnu.org>
3471
74cc8ff9
GM
3472 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3473
7d8d6e4e
GM
3474 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3475 Update template values to be closer to their typical values these days.
5b43da69 3476
a0db8d43
EZ
34772012-01-09 Eli Zaretskii <eliz@gnu.org>
3478
3479 * xdisp.c (rows_from_pos_range): Accept additional argument
3480 DISP_STRING, and accept any glyph in a row whose object is that
3481 string as eligible for mouse highlight. Fixes mouse highlight of
3482 display strings from overlays. (Bug#10464)
3483
9a0115ab 34842012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3485
b9110d6a 3486 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3487 * fileio.c (auto_saving_dir_umask): New static var.
3488 (Fmake_directory_internal): Use it.
3489 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3490 creating the directory. The old code temporarily assigns
3491 too-generous permissions to the directory.
3492 (do_auto_save_eh): Clear it.
b9110d6a 3493 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3494 that the var is always cleared.
3495
6c1bd3f3
EZ
34962012-01-07 Eli Zaretskii <eliz@gnu.org>
3497
3498 * search.c (scan_buffer): Pass character positions to
3499 know_region_cache, not byte positions. (Bug#6540)
3500
069d2b50
L
35012012-01-07 LynX <_LynX@bk.ru> (tiny change)
3502
3503 * w32.c (sys_rename): Report EXDEV when rename of a directory
3504 fails because the target is on another logical disk. (Bug#10284)
3505
75bf0d33
DB
35062012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3507
3508 * xterm.c (x_embed_request_focus): New function.
3509
3510 * xterm.h: Add prototype.
3511
3512 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3513
1c6e5a32
GM
35142012-01-05 Glenn Morris <rgm@gnu.org>
3515
3516 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3517
651e947e
EZ
35182012-01-01 Eli Zaretskii <eliz@gnu.org>
3519
3520 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3521 Load gnutls_transport_set_lowat only if GnuTLS version is below
3522 2.11.1.
3523 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3524 GnuTLS versions below 2.11.1.
3525
3778cdd8
AL
35262011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3527
3528 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3529 to the doc string advising against its use for altering the way
3530 windows are scrolled.
3531
0e5317f7
KH
35322011-12-28 Kenichi Handa <handa@m17n.org>
3533
3534 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3535 coding-system ASCII compatible only when it does not produce BOM
3536 on encoding (Bug#10383).
3537
93d5ca1f
JD
35382011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3539
3540 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3541 can scroll.
3542 (create_and_show_popup_menu): Always use menu_position_func for
3543 Gtk3 (Bug#10361).
3544
ca22b785
AS
35452011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3546
3547 * callint.c (Fcall_interactively): Don't truncate prompt string.
3548
d048e1e6
EZ
35492011-12-23 Eli Zaretskii <eliz@gnu.org>
3550
3551 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3552 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3553 resumed from there (after widening). (Bug#10360)
d048e1e6 3554
5ccaba1f
JD
35552011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3556
3557 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3558
204ee57f
JD
35592011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3560
b81d40f0
JB
3561 * nsterm.m (x_free_frame_resources):
3562 Release f->output_data.ns->miniimage.
204ee57f
JD
3563 (ns_index_color): Fix indentation. Do not retain
3564 color_table->colors[i].
3565
3566 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3567 before returning.
3568
3569 * nsfns.m (x_set_background_color): Assign return value from
3570 ns_index_color to face-background instead of NSColor*.
3571 (ns_implicitly_set_icon_type): Fix indentation.
3572 Change assignment in for loop to comparison.
3573
3574 * emacs.c (ns_pool): New variable.
3575 (main): Assign ns_pool.
3576 (Fkill_emacs): Call ns_release_autorelease_pool.
3577
3578 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3579 autorelease fdesc, release fdAttrs and tdict.
3580 (ns_get_covering_families): Release charset.
3581 (ns_findfonts): Release NSFontDescriptor created with new.
3582 (ns_uni_to_glyphs): Fix indentation.
3583 (setString): Release attrStr before assigning new value.
3584
c803b2b7
JD
35852011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3586
678f4426
JD
3587 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3588 and NS_IMPL_COCOA.
3589 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3590 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3591
cd394be1 35922011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3593
5fecd5fc
JD
3594 * nsterm.m (ns_term_init): Subscribe for notifications
3595 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3596 to method trackingNotification in EmacsMenu.
3597
3598 * nsmenu.m (trackingMenu): New variable.
3771cb17 3599 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3600 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3601 from Aquamacs (Bug#7030).
678f4426
JD
3602
36032011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3604
c803b2b7
JD
3605 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3606 (symbol_to_nsstring): Fix indentation.
3607 (ns_symbol_to_pb): New function.
cae07000
SM
3608 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3609 (Fns_rotate_cut_buffers_internal): Remove.
3610 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3611 Fns_store_cut_buffer_internal.
3612 (ns_get_foreign_selection, Fx_own_selection_internal)
3613 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3614 (Fns_get_selection_internal, Fns_store_selection_internal):
3615 Use ns_symbol_to_pb and check if return value is nil.
3616 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3617 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3618 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3619 renamed to Sns_store_selection_internal.
3620 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3621 and remove this function.
3622 (ns_handle_selection_clear): Remove, never used.
3623 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3624 here.
3625
e1b01a3a
KB
36262011-12-17 Ken Brown <kbrown@cornell.edu>
3627
3628 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3629 GID is unknown (Bug#10257).
3630
2adb6e85
PE
36312011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3632
3633 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3634 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3635 which caused a build failure on GNU/Linux IA-64. This problem was
3636 introduced by my 2011-10-07 patch.
3637
d1d7b339
JL
36382011-12-15 Juri Linkov <juri@jurta.org>
3639
3640 * image.c (imagemagick_error): New function. (Bug#10112)
3641 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3642 Use `imagemagick_error' where ImageMagick functions return
3643 `MagickFalse'.
3644 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3645 proper order.
3646
100d5755
KH
36472011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3648
3649 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3650 fill background (Bug#8992).
3651
454592a6
MR
36522011-12-13 Martin Rudalics <rudalics@gmx.at>
3653
3654 * window.c (Vwindow_combination_resize)
3655 (Vwindow_combination_limit): Use t instead of non-nil in
3656 doc-strings.
61d4b438
MR
3657 (Vrecenter_redisplay): Add first sentence of doc-string on
3658 separate line.
53524d93 3659 (Frecenter): Fix doc-string typo.
454592a6 3660
3633e3aa
KH
36612011-12-11 Kenichi Handa <handa@m17n.org>
3662
3663 * coding.c (Funencodable_char_position): Pay attention to the
3664 buffer text relocation (Bug#9389).
3665
7b9d523a 36662011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3667
7b9d523a
JD
3668 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3669 gtk_init (Bug#10100).
3670
b73189c6
EZ
36712011-12-10 Eli Zaretskii <eliz@gnu.org>
3672
3673 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3674 IT->string is nil. (Bug#10263)
3675
f7dfe5d6
JD
36762011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3677
83faebb4
JD
3678 * nsterm.h (x_free_frame_resources): Declare.
3679
f7dfe5d6
JD
3680 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3681 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3682
3683 * nsterm.h (ns_get_defaults_value): Declare.
3684
3685 * nsterm.m (ns_default): Call ns_get_defaults_value.
3686
7cd4e72c
EZ
36872011-12-09 Eli Zaretskii <eliz@gnu.org>
3688
3689 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3690 (Bug#10170)
3691
b34d7317
YM
36922011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3693
3694 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3695 that where the value of an _OBJC_* symbol points to is in the .bss
3696 section (Bug#10240).
3697
76470ad1
KH
36982011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3699
3700 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3701 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3702
745fff94
KH
37032011-12-08 Kenichi Handa <handa@m17n.org>
3704
3705 * ftfont.c (get_adstyle_property): Fix previous change
3706 (Bug#10233).
3707
6e44397c
JB
37082011-12-07 Juanma Barranquero <lekktu@gmail.com>
3709
3710 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3711 dirs from the default value of EMACSLOADPATH (bug#10208).
3712
7efa6272
GM
37132011-12-07 Glenn Morris <rgm@gnu.org>
3714
3715 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3716 installation and source directories as well. (Bug#10208)
3717
f6fc4d87
CY
37182011-12-06 Chong Yidong <cyd@gnu.org>
3719
3720 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3721
2bf26180
GM
37222011-12-06 Glenn Morris <rgm@gnu.org>
3723
3724 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3725 as an error, not just -1. (Bug#10217)
3726
3a6ad4f0
CY
37272011-12-05 Chong Yidong <cyd@gnu.org>
3728
3729 * keyboard.c (process_special_events): New function.
3730 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3731
75a3b399
PE
37322011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3733
3734 * coding.c (encode_designation_at_bol): Don't use uninitialized
3735 local variable (Bug#9318).
3736
c3c9e25e
KH
37372011-12-05 Kenichi Handa <handa@m17n.org>
3738
3739 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3740 return Qnil (Bug#8046, Bug#10193).
3741
5eb05ea3
KH
37422011-12-05 Kenichi Handa <handa@m17n.org>
3743
3744 * coding.c (encode_designation_at_bol): New args charbuf_end and
3745 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3746 (coding_set_source): Return how many bytes coding->source was
3747 relocated.
3748 (coding_set_destination): Return how many bytes
3749 coding->destination was relocated.
3750 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3751 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3752
37532011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3754
3755 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3756 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3757 macro (Bug#9318).
3758
37592011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3760
3761 The following changes are to fix Bug#9318.
3762
a79703f5 3763 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3764 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3765 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3766 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3767
7dbda6df
JB
37682011-12-05 Juanma Barranquero <lekktu@gmail.com>
3769
3770 * lisp.h (process_quit_flag): Fix external declaration.
3771
6d5eb5b0
SM
37722011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3773
3774 Don't macro-inline non-performance-critical code.
3775 * eval.c (process_quit_flag): New function.
3776 * lisp.h (QUIT): Use it.
3777
a0c3fad0
JD
37782011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3779
3780 * nsfns.m (get_geometry_from_preferences): New function.
3781 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3782
6c07aac2
AS
37832011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3784
3785 * emacs.c (Qkill_emacs): Define.
3786 (syms_of_emacs): Initialize it.
3787 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3788 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3789 (quit_throw_to_read_char): Add parameter `from_signal'.
3790 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3791 * lisp.h (QUIT): Call Fkill_emacs if requested.
3792
c052ead4
JD
37932011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3794
3795 * widget.c (update_wm_hints): Return if wmshell is null.
3796 (widget_update_wm_size_hints): New function.
3797
3798 * widget.h (widget_update_wm_size_hints): Declare.
3799
3800 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3801 widget_update_wm_size_hints (Bug#10104).
3802
9e49252b
EZ
38032011-12-03 Eli Zaretskii <eliz@gnu.org>
3804
3805 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3806 before a newline, prepare the bidi iterator for consuming the
3807 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3808 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3809
02b16839
JL
38102011-12-02 Juri Linkov <juri@jurta.org>
3811
3812 * search.c (Fword_search_regexp): New Lisp function created from
3813 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3814 (Fword_search_backward, Fword_search_forward)
3815 (Fword_search_backward_lax, Fword_search_forward_lax):
3816 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3817 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3818
0068070e
SM
38192011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3820
3821 * fileio.c (Finsert_file_contents): Move after-change-function call
3822 to before the "handled:" label, since all "goto handled" appear in
3823 cases where the *-change-functions have already been properly called
3824 (bug#10117).
3825
3360a3fc
AS
38262011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3827
3828 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3829 waiting for input. (Bug#10169)
3830
73d6c093
EZ
38312011-11-30 Eli Zaretskii <eliz@gnu.org>
3832
3833 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3834 verifies glyph row's hash code--we have just reallocated the
3835 glyphs, so their contents can be complete garbage. (Bug#10164)
3836
febe6bea
JB
38372011-11-30 Juanma Barranquero <lekktu@gmail.com>
3838
3839 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3840
801a4313
EZ
38412011-11-30 Eli Zaretskii <eliz@gnu.org>
3842
3843 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3844 attributes are tested _before_ calling verify_row_hash, to protect
3845 against GCC re-ordering of the tests. (Bug#10164)
3846
2b56b87e
JD
38472011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3848
3849 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3850
3851 * xterm.c (handle_one_xevent): Only set async_visible and friends
3852 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3853 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3854 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3855
dbf31225
PE
38562011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3857
3858 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3859 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3860 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3861 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3862 All uses changed to use GCPRO1 etc.
3863 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3864 Revert to old implementation (i.e., before 2011-03-11).
3865
1305621b
YM
38662011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3867
3868 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3869 of scroll runs so as to avoid assigning disabled bogus rows and
3870 unnecessary graphics copy operations.
3871
8c9afb46
EZ
38722011-11-27 Eli Zaretskii <eliz@gnu.org>
3873
3874 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3875 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3876 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3877 (malloc, free, realloc, calloc): Redirect to e_* only when
3878 compiling Emacs.
3879
3880 * lisp.h (GCTYPEBITS): Move before first use.
3881 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3882 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3883 this macro definition.
3884
3885 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3886 _MSC_VER.
3887
54e9e3bf
JD
38882011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3889
6d5eb5b0
SM
3890 * gtkutil.c (xg_create_frame_widgets):
3891 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3892 present with Gtk+ 2.0.
3893
83aca1cb
PE
38942011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3895
3896 * fileio.c (Finsert_file_contents): Undo previous change; see
3897 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3898
5b76caa4
PE
38992011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3900
3901 Rename locals to avoid shadowing.
3902 * fileio.c (Finsert_file_contents):
3903 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3904 * process.c (wait_reading_process_output):
3905 Rename inner 'proc' to 'p' to avoid shadowing.
3906 Indent for consistency with usual Emacs style.
3907
8c535114
EZ
39082011-11-25 Eli Zaretskii <eliz@gnu.org>
3909
3910 * xdisp.c (redisplay_window): If cursor row is not fully visible
3911 after recentering, and scroll-conservatively is set to a large
3912 number, scroll window by a few more lines to make the cursor fully
3913 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3914 (start_display): Don't move to the next line if the display should
3915 start at a newline that is part of a display vector or an overlay
3916 string. (Bug#10119)
8c535114 3917
fa4fdb5c
JL
39182011-11-24 Juri Linkov <juri@jurta.org>
3919
3920 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3921 after the `MagickPingImage' call. (Bug#10112)
3922
90ec88df
CY
39232011-11-23 Chong Yidong <cyd@gnu.org>
3924
3925 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3926
56e2e794
MR
39272011-11-23 Martin Rudalics <rudalics@gmx.at>
3928
3929 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3930 making another buffer current. (Bug#10114)
3931
b6e64c41
GM
39322011-11-23 Glenn Morris <rgm@gnu.org>
3933
3934 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3935
6b21de18
CY
39362011-11-23 Chong Yidong <cyd@gnu.org>
3937
3938 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3939 using it (Bug#5984).
3940
b12cd789
EZ
39412011-11-22 Eli Zaretskii <eliz@gnu.org>
3942
3943 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3944 and header-lines, as they don't have one computed for them.
3945 (Bug#10098)
3946
3947 * .gdbinit (prow): Make displayed values more self-explaining.
3948 Add row's hash code.
3949
261b6fd4
LMI
39502011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3951
3952 * process.c (wait_reading_process_output): Fix asynchrounous
3953 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3954 (wait_reading_process_output): Add comment and URL.
261b6fd4 3955
e7cfd277
JD
39562011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3957
3958 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3959
a9b9b7f5
CY
39602011-11-21 Chong Yidong <cyd@gnu.org>
3961
3962 * window.c (Fnext_window, Fprevious_window): Doc fix.
3963
b0d15b4f
SM
39642011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3965
3966 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3967
fe7a3057
JB
39682011-11-20 Juanma Barranquero <lekktu@gmail.com>
3969
3970 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3971
d2999b1a
MR
39722011-11-20 Martin Rudalics <rudalics@gmx.at>
3973
3974 * window.c (Fset_window_combination_limit): Rename argument
3975 STATUS to LIMIT.
3976 (Vwindow_combination_limit): Remove "status" from doc-string.
3977
d5ff9cd0
AS
39782011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3979
3980 * m/ibms390.h: Remove.
3981 * m/ibms390x.h: Don't include "ibms390.h".
3982
a5bb9bd3
SM
39832011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3984
3985 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3986 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3987
cd1181db
JB
39882011-11-20 Juanma Barranquero <lekktu@gmail.com>
3989
3990 * casetab.c (Fset_case_table):
3991 * charset.c (Fcharset_after): Fix typos.
3992
615a3b8d 39932011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3994
17e845af
PE
3995 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3996 Otherwise, valgrind does not work on some platforms.
3997 Problem reported by Andreas Schwab in
6a0bf43d
PE
3998 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3999 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4000 is set, removing the need for VIRT_ADDRESS_VARIES.
4001 (PURE_P): Use a more-efficient implementation that needs just one
4002 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4003 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4004 to 4 (xorl, subq, cmpq, setbe).
4005 * alloc.c (pure): Always extern now, since that's the
4006 VIRT_ADDR_VARIES behavior.
4007 (PURE_POINTER_P): Use a single comparison, not two, for
4008 consistency with the new puresize.h.
4009 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4010 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4011 Remove VIRT_ADDR_VARIES no longer needed.
4012
f8fe6f96
EZ
40132011-11-19 Eli Zaretskii <eliz@gnu.org>
4014
4015 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4016 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4017 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4018 behave as if the cursor position were at the window margin.
4019
4020 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4021 and the cursor position is out of bounds, behave as if the cursor
4022 position were at the window margin. (Bug#10075)
4023
df05a53c
CY
40242011-11-18 Chong Yidong <cyd@gnu.org>
4025
4026 * window.c (Fwindow_combination_limit): Make first argument
4027 non-optional, since it is meaningless for live windows like the
4028 selected window.
61ccba97 4029
2071918e
DA
40302011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4031
4032 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4033
b50a28de
SM
40342011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4035
4036 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4037 (graft_intervals_into_buffer): Simplify.
4038
015137db
EZ
40392011-11-18 Eli Zaretskii <eliz@gnu.org>
4040
4041 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4042 hash values of the two rows.
4043 (copy_row_except_pointers): Preserve the used[] arrays and the
4044 hash values of the two rows. (Bug#10035)
68c95424 4045 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4046
4047 * xdisp.c (row_hash): New function, body extracted from
4048 compute_line_metrics.
4049 (compute_line_metrics): Call row_hash, instead of computing the
4050 hash code inline.
4051
4052 * dispnew.c (verify_row_hash): Call row_hash for computing the
4053 hash code of a row, instead of duplicating code from xdisp.c.
4054
4055 * dispextern.h (row_hash): Add prototype.
4056
a2addb04
TH
40572011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4058
4059 * frame.c (delete_frame): Don't delete the terminal when the last
4060 X frame is closed if emacs is built with GTK toolkit.
4061
df85d315
JB
40622011-11-17 Juanma Barranquero <lekktu@gmail.com>
4063
4064 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4065
a0c2d0ae
MR
40662011-11-17 Martin Rudalics <rudalics@gmx.at>
4067
4068 * window.c (Vwindow_splits): Rename to
4069 Vwindow_combination_resize. Suggested by Juri Linkov.
4070 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4071 of Vwindow_splits.
4072
58179cce
JB
40732011-11-16 Juanma Barranquero <lekktu@gmail.com>
4074
7877f373
JB
4075 * nsfns.m (Fns_font_name):
4076 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4077
b6f67890
MR
40782011-11-16 Martin Rudalics <rudalics@gmx.at>
4079
4080 * window.h (window): Rename slot "nest" to "combination_limit".
4081 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4082 (Fset_window_nest): Rename to Fset_window_combination_limit.
4083 (Vwindow_nest): Rename to Vwindow_combination_limit.
4084 (recombine_windows, make_parent_window, make_window)
4085 (Fsplit_window_internal, saved_window)
4086 (Fset_window_configuration, save_window_save): Rename all
4087 occurrences of window_nest to window_combination_limit.
4088
c7015153
JB
40892011-11-15 Juanma Barranquero <lekktu@gmail.com>
4090
4091 * image.c (imagemagick_load_image): Fix typo.
4092
322ad6ec
EZ
40932011-11-14 Eli Zaretskii <eliz@gnu.org>
4094
4095 * xdisp.c (display_line): Move the call to
4096 highlight_trailing_whitespace before the call to
4097 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4098 faces of all the glyphs to compute ROW's hash value.
4099 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4100
f067b8ec
JB
41012011-11-14 Juanma Barranquero <lekktu@gmail.com>
4102
4103 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4104 just return (bug#10044).
4105
1e5b2111
EZ
41062011-11-12 Eli Zaretskii <eliz@gnu.org>
4107
7ef3cbd5
EZ
4108 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4109 with user-defined heap size. Bump the default size of the temacs
4110 heap to 27MB, to avoid memory warning when running temacs.
4111 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4112
1e5b2111
EZ
4113 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4114 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4115 (verify_row_hash) [XASSERTS]: New function.
4116 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4117 that the hash value of glyph rows is correct.
1e5b2111 4118
89d61221
MR
41192011-11-12 Martin Rudalics <rudalics@gmx.at>
4120
4121 * window.h (window): Remove splits slot.
4122 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4123 (Fdelete_other_windows_internal, make_parent_window)
4124 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4125 (Fset_window_configuration, save_window_save): Don't deal with
4126 split status of windows.
4127 (saved_window): Remove splits slot.
4128 (Vwindow_splits): Rewrite doc-string.
4129
97f18cc8
JD
41302011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4131
4132 * xfns.c (unwind_create_frame):
4133 * nsfns.m (unwind_create_frame):
4134 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4135 Vframe_list (Bug#9999).
4136
22a648b4
DA
41372011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4138
0b381c7e 4139 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4140
659afede
KH
41412011-11-11 Kenichi Handa <handa@m17n.org>
4142
4143 * callproc.c (Fcall_process): Set the member dst_multibyte of
4144 process_coding.
4145
9ac0394b
KH
41462011-11-11 Johan Bockgård <bojohan@gnu.org>
4147
4148 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4149 avoid a crash (bug#9496).
4150
2fbdc249
CY
41512011-11-09 Chong Yidong <cyd@gnu.org>
4152
4153 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4154 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4155
ac6b1f81
PE
41562011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4157
4158 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4159
09db192c
PE
41602011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4161
4162 Avoid some portability problems by eschewing 'extern inline' functions.
4163 The trivial performance wins aren't worth the portability hassles; see
4164 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4165 et seq.
4166 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4167 (window_box_width, window_box_left, window_box_left_offset)
4168 (window_box_right, window_box_right_offset): Undo previous change,
4169 by removing the "extern"s.
4170 * intervals.c (adjust_intervals_for_insertion)
4171 (adjust_intervals_for_deletion): Undo previous change,
4172 making these static again.
4173 (offset_intervals, temp_set_point_both, temp_set_point)
4174 (copy_intervals_to_string): No longer inline.
4175 * xdisp.c (window_text_bottom_y, window_box_width)
4176 (window_box_height, window_box_left_offset)
4177 (window_box_right_offset, window_box_left, window_box_right)
4178 (window_box): No longer inline.
4179
105216ed
CY
41802011-11-08 Chong Yidong <cyd@gnu.org>
4181
4182 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4183 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4184 Signal an error if not a live window.
105216ed
CY
4185 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4186 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4187
ae9e237f
JB
41882011-11-07 Juanma Barranquero <lekktu@gmail.com>
4189
4190 * lisp.h (syms_of_abbrev): Remove declaration.
4191 Reported by CHENG Gao <chenggao@royau.me>.
4192
c7aa8333
EZ
41932011-11-07 Eli Zaretskii <eliz@gnu.org>
4194
4195 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4196 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4197 of temacs in GUI mode.
4198
be7f5545
MR
41992011-11-07 Martin Rudalics <rudalics@gmx.at>
4200
4201 * window.h: Declare delete_all_child_windows instead of
4202 delete_all_subwindows.
4203 * window.c (Fwindow_nest, Fset_window_nest)
4204 (Fset_window_new_total, Fset_window_new_normal)
4205 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4206 (delete_all_subwindows): Rename to delete_all_child_windows.
4207 (Fdelete_other_windows_internal, Fset_window_configuration):
4208 Call delete_all_child_windows instead of delete_all_subwindows.
4209 * frame.c (delete_frame): Call delete_all_child_windows instead
4210 of delete_all_subwindows.
4211
ca78dc43
PE
42122011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4213
4214 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4215 This is also needed for porting to any host where GC_MARK_STACK is
4216 not GC_MAKE_GCPROS_NOOPS.
4217 (which_symbols): Use it.
4218
a0241d01
KH
42192011-11-07 Kenichi Handa <handa@m17n.org>
4220
4221 * coding.c (coding_set_destination): Check coding->src_pos only
4222 when coding->src_object is a buffer (bug#9910).
4223
4224 * process.c (send_process): Set the member src_multibyte of coding
4225 to 0 (bug#9911) when sending a unibyte text.
4226
4227 * callproc.c (Fcall_process): Set the member src_multibyte of
4228 process_coding to 0 (bug#9912).
4229
a64bfdfa 42302011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4231
4232 * xmenu.c (cleanup_widget_value_tree): New function.
4233 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4234 calling free_menubar_widget_value_tree directly (Bug#9830).
4235
cb41b32a
PE
42362011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4237
4238 Fix some portability problems with 'inline'.
4239 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4240 (window_box_width, window_box_left, window_box_left_offset)
4241 (window_box_right, window_box_right_offset): Declare extern.
4242 Otherwise, these inline functions do not conform to C99 and
4243 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4244 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4245 * intervals.c (adjust_intervals_for_insertion)
4246 (adjust_intervals_for_deletion): Now extern, because otherwise the
4247 extern inline functions 'offset_intervals' couldn't refer to it.
4248 (static_offset_intervals): Remove.
4249 (offset_intervals): Rewrite using the old contents of
4250 static_offset_intervals. The old version didn't conform to C99
4251 because an extern inline function contained a reference to an
4252 identifier with static linkage.
4253
b7041366
AS
42542011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4255
4256 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4257 GC.
4258
88a37c4d
EZ
42592011-11-06 Eli Zaretskii <eliz@gnu.org>
4260
4261 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4262 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4263 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4264 return Qleft_to_right.
4265
49745b39
CY
42662011-11-06 Chong Yidong <cyd@gnu.org>
4267
4268 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4269 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4270 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4271 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4272 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4273 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4274 (Fwindow_vscroll): Doc fix.
4275 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4276 argument, since it makes no sense to pass a live window and for
4277 consistency with window-child.
4278
1f05cd82
CS
42792011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4280
4281 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4282 support MSVC.
4283
22610910
JR
42842011-11-05 Jason Rumney <jasonr@gnu.org>
4285
4286 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4287 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4288 fonts (Bug#6029).
4289 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4290 bitwise arithmetic preventing use of unicode-sip and non-truetype
4291 opentype fonts.
4292
a06776b2
EZ
42932011-11-05 Eli Zaretskii <eliz@gnu.org>
4294
3ad924ba
EZ
4295 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4296 "emacs"-only part.
4297
a06776b2
EZ
4298 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4299 initialization code to keep similarity to xfns.c after changes
4300 from 2011-11-05.
4301
c9e7db78
JD
43022011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4303
a97f8f3f
JD
4304 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4305 (unwind_create_frame): New function (Bug#9943).
4306 (Fx_create_frame): Restructure code to be more similar to the one in
4307 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4308 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4309 Move terminal->reference_count++ just before making the frame official
4310 (Bug#9943).
4311
4312 * nsterm.m (x_free_frame_resources): New function.
4313 (x_destroy_window): Move code to x_free_frame_resources.
4314
c9e7db78 4315 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4316 (Fx_create_frame, x_create_tip_frame):
4317 Move terminal->reference_count++ just before making the frame
75f1671a 4318 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4319 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4320
a6fc3b5c
EZ
43212011-11-05 Eli Zaretskii <eliz@gnu.org>
4322
4323 Support MSVC build with newer versions of Visual Studio.
4324 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4325 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4326 nt/gmake.defs.
4327
4328 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4329 which are not supported by MSVC.
4330 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4331 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4332 bitfields.
4333 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4334 types in bitfields.
4335 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4336
4337 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4338
58179cce 43392011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4340
4341 Support MSVC build with newer versions of Visual Studio.
4342 * w32.c: Don't include w32api.h for MSVC.
4343 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4344
4345 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4346 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4347 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4348 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4349 e_* cousins.
4350 (alloca) [_MSC_VER]: Define to _alloca.
4351
4352 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4353
4354 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4355
a58c13ed
EZ
43562011-11-04 Eli Zaretskii <eliz@gnu.org>
4357
4358 * xdisp.c (note_mouse_highlight): If either of
4359 previous/next-single-property-change returns nil, treat that as
4360 the beginning or the end of the buffer. (Bug#9955)
4361
fe0b6370
JD
43622011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4363
a58c13ed 4364 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4365 label is not null (Bug#9951).
4366 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4367 may be NULL.
4368
89bd5ee1
EZ
43692011-11-04 Eli Zaretskii <eliz@gnu.org>
4370
4371 * window.c (Fwindow_body_size): Mention in the doc string that the
4372 return value is in frame's canonical units. (Bug#9949)
4373
84c3edb9
EZ
43742011-11-03 Eli Zaretskii <eliz@gnu.org>
4375
4e2fb5c7
EZ
4376 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4377
84c3edb9 4378 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4379 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4380 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4381
bc17a887
EZ
43822011-11-01 Eli Zaretskii <eliz@gnu.org>
4383
4384 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4385 Don't stop backward scan on the continuation glyph, even though
4386 its CHARPOS is positive.
6d5eb5b0
SM
4387 (mouse_face_from_buffer_pos, note_mouse_highlight):
4388 Rename cover_string to disp_string.
bc17a887 4389
4ee88440
MR
43902011-11-01 Martin Rudalics <rudalics@gmx.at>
4391
4392 * window.c (temp_output_buffer_show): Don't use
4393 Vtemp_buffer_show_specifiers.
4394 (Vtemp_buffer_show_specifiers): Remove unused variable.
4395
c2ff3c02
EZ
43962011-10-30 Eli Zaretskii <eliz@gnu.org>
4397
4398 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4399 past the beginning of the current glyph matrix.
4400
58179cce 44012011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4402
4403 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4404 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4405 HAVE_GTK3 (Bug#9869).
b77a6a7f 4406
3b574623
JD
4407 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4408 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4409
b77a6a7f
JD
4410 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4411
4412 * xterm.c: Declare x_handle_net_wm_state to return int.
4413 (handle_one_xevent): Check if we are iconified but don't have
4414 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4415 (get_current_wm_state): Return non-zero if not hidden,
4416 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4417 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4418 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4419 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4420
196e41e4
PE
44212011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4422
4423 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4424 so that this new function doesn't get optimized away by a
4425 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4426
021f2e1a
AS
44272011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4428
4429 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4430
8b058d44
EZ
44312011-10-29 Eli Zaretskii <eliz@gnu.org>
4432
4433 Fix the `xbytecode' command.
4434 * .gdbinit (xprintbytestr): New command.
b50a28de 4435 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4436 (xbytecode): Print the byte-code string as well.
4437
4452fb80
EZ
44382011-10-29 Kim Storm <storm@cua.dk>
4439
8b058d44
EZ
4440 * alloc.c (which_symbols): New function.
4441
21b72067
AS
44422011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4443
4444 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4445 line. (Bug#9903)
4446
83ed7b5c
GM
44472011-10-29 Glenn Morris <rgm@gnu.org>
4448
4449 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4450 Not clear what it was for, and it causes various bugs. (Bug#9839)
4451
5a7a728b
EZ
44522011-10-28 Eli Zaretskii <eliz@gnu.org>
4453
4454 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4455 possible random value that matches one of those tested as
4456 condition to clear the mouse face.
4457
d3d0842f
CY
44582011-10-28 Chong Yidong <cyd@gnu.org>
4459
4460 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4461
31b39d13
DN
44622011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4463
4464 * window.c (make_window): Initialize phys_cursor_on_p.
4465
9aba6043
SM
44662011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4467
4468 * lisp.h (struct Lisp_Symbol): Update comments.
4469
c20992f4
JB
44702011-10-28 Juanma Barranquero <lekktu@gmail.com>
4471
4472 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4473
db4f02f2
EZ
44742011-10-28 Eli Zaretskii <eliz@gnu.org>
4475
4476 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4477 <oslsachem@gmail.com> for helping to debug this.
4478
4479 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4480 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4481 (g_b_init_get_glyph_outline_w): New static variables.
4482 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4483 (GetGlyphOutlineW_Proc): New typedefs.
4484 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4485 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4486 New functions.
4487 (w32font_open_internal, compute_metrics):
4488 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4489 instead of calling the "wide" APIs directly.
4490
4491 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4492
4493 * w32.h (syms_of_w32font): Add prototype.
4494
87e68db4
JB
44952011-10-27 Juanma Barranquero <lekktu@gmail.com>
4496
4497 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4498 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4499 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4500 (Fmove_to_window_line): Doc fix.
4501
435c1d67
CY
45022011-10-27 Chong Yidong <cyd@gnu.org>
4503
4504 * process.c (make_process): Set gnutls_state to NULL.
4505
4506 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4507 non-NULL, regardless of GNUTLS_INITSTAGE.
4508 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4509 an error. Set process slots as soon as we allocate them.
4510
4511 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4512
9c6c6f49
CY
45132011-10-27 Chong Yidong <cyd@gnu.org>
4514
9aba6043
SM
4515 * gnutls.c (emacs_gnutls_deinit): New function.
4516 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4517 (Fgnutls_deinit, Fgnutls_boot): Use it.
4518
4519 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4520 (deactivate_process): Call emacs_gnutls_deinit.
4521
657d08d3
JB
45222011-10-27 Juanma Barranquero <lekktu@gmail.com>
4523
4524 * image.c (x_create_x_image_and_pixmap):
4525 * w32.c (sys_rename, w32_delayed_load):
4526 * w32font.c (fill_in_logfont):
4527 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4528
5430d399
JB
45292011-10-26 Juanma Barranquero <lekktu@gmail.com>
4530
4531 * w32fns.c (w32_default_color_map): New function,
4532 extracted from Fw32_default_color_map.
a7ef684b 4533 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4534
fe0055fa
PE
45352011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4536
4537 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4538
e6346438
SM
45392011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4540
4541 * keyboard.c (test_undefined): New function (bug#9751).
4542 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4543
e112cc37
ET
45442011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4545
4546 * sysdep.c (init_sys_modes): Fix the check for the controlling
4547 terminal (Bug#6649).
4548
7b5d6677
EZ
45492011-10-20 Eli Zaretskii <eliz@gnu.org>
4550
4551 * dispextern.h (struct bidi_it): New member next_en_type.
4552
4553 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4554 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4555 current character, check also for next_en_type being WEAK_EN.
4556 (bidi_resolve_weak): Don't enter the expensive loop if the current
4557 position is before next_en_pos. Record the bidi type of the first
4558 non-ET, non-BN character we find, in addition to its position.
4559 (bidi_level_of_next_char): Invalidate next_en_type when
4560 next_en_pos is over-stepped.
4561
7da0b018
PE
45622011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4563
4564 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4565 * editfns.c: Rewrite current-time-zone so that it invokes
4566 the equivalent of (format-time-string "%Z") to get the time zone name.
4567 This fixes a bug when the time zone name contains characters that
4568 need converting from the system time locale to Emacs internal format.
4569 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4570 that patch fixed format-time-string to do the conversion, but
4571 I forgot to fix current-time-zone.
4572 (format_time_string): New function, containing most of
4573 what Fformat_time_string used to contain.
4574 (Fformat_time_string): Rewrite in terms of format_time_string.
4575 This doesn't change this function's behavior.
4576 (current-time-zone): Rewrite to use format_time_string.
4577 This fixes the bug reported by Michael Schierl in
4578 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4579 Jason Rumney's 2007-06-07 change worked around this bug, but
4580 didn't fix it.
4581 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4582
8547b010
EZ
45832011-10-19 Eli Zaretskii <eliz@gnu.org>
4584
4585 * xdisp.c (start_display): If the character at POS is displayed
4586 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4587 (try_window_reusing_current_matrix): If a line ends in a display
4588 vector or the next line starts in a display vector, continue
4589 redrawing the window even though the character position of
4590 start_row was reached.
8547b010
EZ
4591 (Bug#9771, part 2)
4592
4e948d15
CY
45932011-10-18 Chong Yidong <cyd@gnu.org>
4594
4595 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4596 with nobreak-char-display too.
4597
4787455f
EZ
45982011-10-18 Eli Zaretskii <eliz@gnu.org>
4599
4600 Fix part 3 of bug#9771.
4601 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4602 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4603 non-neutral characters if the current character is a paragraph
4604 separator (a.k.a. Newline). This avoids running the same
4605 expensive loop twice, once when we consume the preceding newline
4606 and the other time when the line actually needs to be displayed.
4607 Avoid the loop when we see neutrals on the base embedding level
4608 following a character whose directionality is the same as the
4609 paragraph's. This avoids running the expensive loop when a line
4610 ends in a long sequence of neutrals, like control characters.
4611 Add assertion against STRONG_AL type. Slightly rearrange code
4612 that determines the type of a neutral given the first non-neutral
4613 that follows it.
4614 (bidi_level_of_next_char): Set next_en_pos to zero when
4615 invalidating its info.
4616
2c91f553
EZ
46172011-10-17 Eli Zaretskii <eliz@gnu.org>
4618
4619 * xdisp.c (push_display_prop): Determine whether to record string
4620 or buffer position by IT->string, not by IT->method. Allow
4621 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4622 (move_it_vertically_backward): Don't look for character position
4623 immediately after the newline when in a continuation line.
4624 (Bug#9771, part 1)
2c91f553 4625
c7b08b0d
MR
46262011-10-15 Martin Rudalics <rudalics@gmx.at>
4627
4628 * window.c (coordinates_in_window): Rewrite and delabelize
4629 vertical border check. (Bug#5357) (Bug#9618)
4630
6b02f655
SM
46312011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4632
4633 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4634 errors in XSetWindowBorder (bug#9310).
4635
81d40c92
DA
46362011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4637
4638 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4639 avoid crash when xmalloc overrun checking is enabled.
4640
d4172c3b
EZ
46412011-10-13 Eli Zaretskii <eliz@gnu.org>
4642
4643 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4644 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4645 cursor motion with <left> and <right> arrow keys.
4646
4647 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4648 some callers set that themselves.
4649
b00eea75
EZ
46502011-10-12 Eli Zaretskii <eliz@gnu.org>
4651
4652 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4653 display string and the previous row comes from the same string and
4654 is empty. (Bug#9739) (Bug#9738)
4655
8fe012c4
SM
46562011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4657
4658 * doc.c (get_doc_string): Encode file name (bug#9735).
4659
0074aef2
EZ
46602011-10-12 Eli Zaretskii <eliz@gnu.org>
4661
79beb178
EZ
4662 * bidi.c (bidi_level_of_next_char):
4663 * xdisp.c (get_visually_first_element): Remove old incorrect
4664 comments regarding the Unicode Line Separator character.
4665
0074aef2
EZ
4666 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4667
6e4b3fbe
DA
46682011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4669
4670 * alloc.c (Fgc_status): Do not access beyond zombies array
4671 boundary if nzombies > MAX_ZOMBIES.
4672 * alloc.c (dump_zombies): Add missing format specifier.
4673
0324f3af
PE
46742011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4675
b5525cac
PE
4676 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4677 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4678
0324f3af
PE
4679 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4680 Some packages use them to denote characters with modifiers.
4681
e9b5f888
AS
46822011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4683
4684 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4685 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4686 matching a pp-number. Rename parameter var to var1.
4687
127827c0
SM
46882011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4689
4690 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4691
c8fd3bd0
GM
46922011-10-08 Glenn Morris <rgm@gnu.org>
4693
4694 * callint.c (Fcall_interactively): Give a more explicit error for the
4695 'c' case with a non-character input. (Bug#8479)
4696
352ec8ff
EZ
46972011-10-08 Eli Zaretskii <eliz@gnu.org>
4698
03669ccb
EZ
4699 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4700 lines.
7061c986
EZ
4701 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4702 lines that are hscrolled on the left.
03669ccb 4703
352ec8ff
EZ
4704 * dispnew.c (buffer_posn_from_coords): Account for a possible
4705 presence of header-line. (Bug#4426)
4706
a66cfb1c
SM
47072011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4708
6b02f655
SM
4709 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4710 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4711
7c5ee88e
PE
47122011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4713
4714 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4715 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4716 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4717 this makes Emacs dump core during garbage collection on rare
4718 occasions. sizeof is obviously inferior to offsetof here, so
4719 stick with offsetof.
4720 (GC_POINTER_ALIGNMENT): New macro.
4721 (mark_memory): Omit 3rd (offset) arg; caller changed.
4722 Don't assume EMACS_INT alignment is the same as pointer alignment.
4723
df1bbe5b
SM
47242011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4725
4726 * keyboard.c (read_key_sequence_remapped): New var.
4727 (read_key_sequence): Compute remapping in the right buffer.
4728 (command_loop_1): Use read_key_sequence's remapping directly.
4729
51553db6
SM
47302011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4731
32c1fffd
SM
4732 * dired.c (file_name_completion): Don't expand file name.
4733 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4734 before checking file name handler.
4735
51553db6
SM
4736 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4737 they've been requested explicitly (bug#9591).
4738
b6bd1599 47392011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4740
4741 * keymap.c (Fsingle_key_description): Use make_specified_string
4742 instead of build_string to build string from push_key_description.
4743 (Bug#5193)
4744
f701dc2a
PE
47452011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4746
4222c55d
PE
4747 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4748 This fixes a Y2038 bug on 64-bit hosts.
4749 * buffer.c (reset_buffer):
4750 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4751 (Fclear_buffer_auto_save_failure):
4752 Use 0, not -1, to represent an unset failure time, since time_t
4753 might not be signed.
4754
f701dc2a
PE
4755 Remove dependency on glibc malloc internals.
4756 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4757 Move back here from lisp.h, but with their new implementations.
4758 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4759 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4760 * charset.c (charset_table_init): New static var.
4761 (syms_of_charset): Use it instead of xmalloc. This removes a
4762 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4763 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4764 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4765 Move back to alloc.c.
4766 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4767 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4768
9ceebf39
JD
47692011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4770
4771 * nsterm.m (windowDidResize): Call x_set_window_size only when
4772 ns_in_resize is true. Otherwise set pixelwidth/height and
4773 call change_frame_size (Bug#9628).
4774
cb993c58
PE
47752011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4776
3930c88b
PE
4777 Port --enable-checking=all to Fedora 14 x86-64.
4778 * charset.c (syms_of_charset): Also account for glibc malloc's
4779 internal overhead when calculating the initial malloc maximum.
4780
cb993c58
PE
4781 Port --enable-checking=all to Fedora 14 x86.
4782 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4783 Move to lisp.h.
4784 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4785 (overrun_check_realloc, overrun_check_free):
4786 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4787 That way, xmalloc returns a properly-aligned pointer even if
4788 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4789 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4790 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4791 into account when calculating the initial malloc maximum.
4792 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4793 Move here from alloc.c, so that charset.c can use it too.
4794 Properly align; the old code wasn't right for common 32-bit hosts
4795 when configured with --enable-checking=all.
4796 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4797 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4798
31bed486
EZ
47992011-09-29 Eli Zaretskii <eliz@gnu.org>
4800
04c70788 4801 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4802 use EDOM.
4803
fbcaa2f3
EZ
48042011-09-28 Eli Zaretskii <eliz@gnu.org>
4805
4806 * xdisp.c (compute_display_string_end): If there's no display
4807 string at CHARPOS, return -1.
4808
4809 * bidi.c (bidi_fetch_char): When compute_display_string_end
4810 returns a negative value, treat the character as a normal
4811 character not covered by a display string. (Bug#9624)
4812
a239d4e9
JB
48132011-09-28 Juanma Barranquero <lekktu@gmail.com>
4814
4815 * lread.c (Fread_from_string): Fix typo in docstring.
4816
88652fd5
EZ
48172011-09-27 Eli Zaretskii <eliz@gnu.org>
4818
4819 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4820 newline, reseat the iterator instead of bidi-iterating there one
4821 character at a time. (Bug#9610)
32c1fffd
SM
4822 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4823 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4824
ed497dd4
AS
48252011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4826
4827 * lread.c (readevalloop): Use correct code for NBSP.
4828 (read1): Likewise. (Bug#9608)
4829
b2bf61aa
MA
48302011-09-25 Michael Albinus <michael.albinus@gmx.de>
4831
4832 * dbusbind.c (Fdbus_register_signal): When service is not
4833 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4834
32bbb17c
GM
48352011-09-25 Glenn Morris <rgm@gnu.org>
4836
4837 * buffer.c (truncate-lines): Doc fix.
4838
94e0933e
CY
48392011-09-24 Chong Yidong <cyd@stupidchicken.com>
4840
4841 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4842 (Fset_window_next_buffers): Doc fix.
4843
cddde921
GM
48442011-09-24 Glenn Morris <rgm@gnu.org>
4845
4846 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4847
1260aef1
PE
48482011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4849
25b4bfa0
PE
4850 Fix minor problems found by static checking.
4851 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4852 * indent.c (Fvertical_motion): Fix == vs = typo.
4853
e3cbd34b
EZ
48542011-09-24 Eli Zaretskii <eliz@gnu.org>
4855
a66cfb1c
SM
4856 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4857 Default value is now t. Doc fix.
6bf7006f 4858
e3cbd34b 4859 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4860 logic when moving up, not only when moving down. Fix the
e3cbd34b 4861 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4862 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4863
4864 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4865 CHARPOS is covered by a display string which includes newlines.
4866 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4867 is covered by a display string with embedded newlines.
4868
a3de0cbd
MA
48692011-09-24 Michael Albinus <michael.albinus@gmx.de>
4870
4871 * dbusbind.c (Fdbus_register_signal): Add match rule to
4872 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4873 (Fdbus_register_method, Vdbus_registered_objects_table):
4874 Fix docstring.
a3de0cbd 4875
b260039d
JM
48762011-09-24 Jim Meyering <meyering@redhat.com>
4877
32c1fffd 4878 do not ignore write error for any output size
b260039d
JM
4879 The previous change was incomplete.
4880 While it makes emacs --batch detect the vast majority of stdout
4881 write failures, errors were still ignored whenever the output size is
4882 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4883 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4884 && echo FAIL: ignored write error
4885 FAIL: ignored write error
4886 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4887 && echo FAIL: ignored write error
4888 FAIL: ignored write error
4889 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4890
8eca8a7c
AS
48912011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4892
4893 * emacs.c (Fkill_emacs): In noninteractive mode exit
4894 non-successfully if a write error occurred on stdout. (Bug#9574)
4895
3341db62
EZ
48962011-09-21 Eli Zaretskii <eliz@gnu.org>
4897
4898 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4899 the xassert test.
4900
4901 * dispextern.h (struct it): Update the comment documenting what
4902 can it->OBJECT be.
4903
8c203dbf
EZ
49042011-09-20 Eli Zaretskii <eliz@gnu.org>
4905
4906 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4907 a display string, extend search for cursor position to end of row.
4908 (find_row_edges): If the row ends in a newline from a display
4909 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4910 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4911 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4912 non-empty line. Fixes confusing cursor motion with arrow keys at
4913 the beginning of a line that starts with whitespace.
8c203dbf 4914
a4824228
LMI
49152011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4916
4917 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4918 (bug#9493).
4919
33ed493b
CY
49202011-09-18 Chong Yidong <cyd@stupidchicken.com>
4921
4922 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4923 boolean (Bug#9154).
4924
56cd55c8
EZ
49252011-09-18 Eli Zaretskii <eliz@gnu.org>
4926
4927 * xdisp.c (display_line): Record maximum and minimum buffer
4928 positions even if no glyphs were produced (e.g., by a zero-width
4929 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4930 buffer positions that will be removed from the glyph row because
4931 they don't fit.
c02dcedf
EZ
4932 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4933 column is beyond frame width: don't subtract 1 "pixel" when
4934 computing width of the stretch.
3e62b7e0
EZ
4935 (reseat_at_next_visible_line_start): Undo the change made on
4936 2011-09-17 that saved paragraph information and restored it after
4937 the call to `reseat'. (Bug#9545)
56cd55c8 4938
5ed99d36 49392011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4940
4941 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4942 and turn window cursor on if cleared (Bug#9415).
4943
5ed99d36 49442011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4945
4946 * search.c (boyer_moore): Take unibyte characters from pattern
4947 literally. (Bug#9458)
4948
9bade7b2
EZ
49492011-09-18 Eli Zaretskii <eliz@gnu.org>
4950
4951 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4952
e5e9d610
PE
49532011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4954
87e4427a
PE
4955 Fix minor problem found by static checking.
4956 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4957 initialized, to pacify gcc -Wuninitialized.
4958
e5e9d610
PE
4959 * fileio.c: Report proper errno when syscall falls.
4960 (Finsert_file_contents): Save and restore errno,
4961 so that report_file_error outputs the correct diagnostic.
4962 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4963
a1674f0b
EZ
49642011-09-18 Eli Zaretskii <eliz@gnu.org>
4965
4966 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4967
fbfb6dd4
EZ
49682011-09-17 Eli Zaretskii <eliz@gnu.org>
4969
4970 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4971 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4972
bb187662
EZ
49732011-09-17 Eli Zaretskii <eliz@gnu.org>
4974
1137e8b8 4975 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4976 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4977
4978 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4979 (bidi_find_paragraph_start): Search back for paragraph beginning
4980 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4981 (bidi_move_to_visually_next): Only trigger paragraph-related
4982 computations when the last character is a newline or at EOB, not
4983 just any NEUTRAL_B. (Bug#9470)
4984
bb187662
EZ
4985 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4986 truncated lines if point is covered by a display string. (Bug#9524)
4987
2e621251
PE
49882011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4989
4990 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4991 (cons_to_x_long): New function.
4992 (lisp_data_to_selection_data): Use it. Correct the test for
4993 short-versus-long data; it was negated. Break out of vector
4994 loop, for efficiency, when a long datum is discovered.
4995
91a15bc6
SM
49962011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4997
4998 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4999
b41c3a35
EZ
50002011-09-16 Eli Zaretskii <eliz@gnu.org>
5001
5002 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5003 GCC PR/17406) by declaring this function with external scope.
5004
7812ba2d
PE
50052011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5006
5007 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5008 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5009
cf7edc2a
AS
50102011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5011
5012 * editfns.c (Fformat): Correctly handle text properties on "%%".
5013
bd01620e
EZ
50142011-09-15 Eli Zaretskii <eliz@gnu.org>
5015
5016 * xterm.c (x_draw_composite_glyph_string_foreground):
5017 * w32term.c (x_draw_composite_glyph_string_foreground):
5018 * term.c (encode_terminal_code):
5019 * composite.c (composition_update_it, get_composition_id):
5020 * xdisp.c (get_next_display_element)
5021 (fill_composite_glyph_string): Add comments about special meaning
5022 of TAB characters in a composition.
5023
a02719a3
PE
50242011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5025
5026 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5027 This occurs when processing a multibyte format.
5028 Problem reported by Wolfgang Jenker.
a02719a3 5029
72589a3c
JB
50302011-09-15 Johan Bockgård <bojohan@gnu.org>
5031
5032 * xdisp.c (try_cursor_movement): Only check for exact match if
5033 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5034
1c14176c
PE
50352011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5036
5037 Remove unused external symbols.
5038 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5039 * xdisp.c (calc_pixel_width_or_height): Now static.
5040 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5041 * indent.c (check_display_width):
5042 * w32term.c: Fix comment to match code.
5043 * xterm.c, xterm.h (x_catching_errors): Remove.
5044
d2eea5b5
PE
50452011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5046
5047 * xselect.c: Use signed conversions more consistently (Bug#9498).
5048 (selection_data_to_lisp_data): Assume incoming selection data are
5049 signed integers, not unsigned. This is to be consistent with
5050 outgoing selection data, which was modified to use signed integers
5051 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5052 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5053 expects long, not unsigned long.
5054
46888499
EZ
50552011-09-14 Eli Zaretskii <eliz@gnu.org>
5056
5057 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5058 computation of loop end. Reported by Johan Bockgård
5059 <bojohan@gnu.org>.
5060
ef8ef9fb
CY
50612011-09-13 Chong Yidong <cyd@stupidchicken.com>
5062
5063 * frame.c (Fother_visible_frames_p): Function deleted.
5064
fa819fed
EZ
50652011-09-12 Eli Zaretskii <eliz@gnu.org>
5066
5067 * indent.c (compute_motion): Process display vector front to back
5068 rather than the other way around. (Bug#2496)
5069
2ba8e008
SM
50702011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5071
5072 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5073
20f53c69
CY
50742011-09-11 Chong Yidong <cyd@stupidchicken.com>
5075
5076 * minibuf.c (Fread_from_minibuffer): Doc fix.
5077
d562d7a4
EZ
50782011-09-11 Eli Zaretskii <eliz@gnu.org>
5079
5080 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5081 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5082
1c4d7f3d
LMI
50832011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5084
5085 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5086 value for non-existent files.
5087
b885bf36
EZ
50882011-09-11 Eli Zaretskii <eliz@gnu.org>
5089
5090 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5091 set its "size" to -1. This will set the modtime_size field of
5092 the corresponding buffer to -1, which is what
5093 verify-visited-file-modtime expects for files that do not exist.
5094 (Bug#9139)
5095
6612f0bf
PE
50962011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5097
5098 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5099 here ...
5100 * lisp.h: ... from here. push_key_description is no longer
5101 defined in keyboard.c, so its declaration should not be in
5102 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5103 logically belongs with push_key_description.
5104
dfb3f755
PE
51052011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5106
5107 * buffer.h: Include <sys/types.h> instead of <time.h>.
5108 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5109 Problem reported by Herbert J. Skuhra.
5110
3134906c
LMI
51112011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5112
5113 * xml.c (parse_region): Make the parsing work for
5114 non-comment-starting XML files again (bug#9144).
5115
8d903f4e
AS
51162011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5117
5118 * image.c (gif_load): Fix calculation of bottom and right corner.
5119 (Bug#9468)
5120
80ad64f4
EZ
51212011-09-10 Eli Zaretskii <eliz@gnu.org>
5122
5123 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5124 redisplay in small windows.
5125
208a048d
EZ
51262011-09-09 Eli Zaretskii <eliz@gnu.org>
5127
5128 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5129
9b1c252e
MR
51302011-09-08 Martin Rudalics <rudalics@gmx.at>
5131
5132 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5133 Operate on live windows only.
5134
2949f33b
JB
51352011-09-08 Juanma Barranquero <lekktu@gmail.com>
5136
5137 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5138
e08dcafd
EZ
51392011-09-07 Eli Zaretskii <eliz@gnu.org>
5140
5141 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5142 only under bidi iteration.
5143
115b96bd
JD
51442011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5145
5146 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5147
c8199d0f
PE
51482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5149
5150 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5151 Without this fix, the command to link temacs failed due to an
5152 undefined symbol __builtin_isnan. This is because
5153 /usr/include/iso/math_c99.h #defines isnan(x) to
5154 __builtin_isnan(x), but the bundled gcc, which identifies itself
5155 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5156 a __builtin_isnan.
5157 * floatfns.c (isnan): #undef, and then #define to a clone of
5158 what's in data.c.
5159 (Fisnan): Always define, since it's always available now.
5160 (syms_of_floatfns): Always define isnan at the Lisp level.
5161
e39b275c 51622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5163
5164 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5165
b2db44d9 51662011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5167
f4af5137 5168 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5169 The previous code assumed that file offsets (off_t values) fit in
5170 EMACS_INT variables, which is not true on typical 32-bit hosts.
5171 The code messed up by falsely reporting buffer overflow in cases
5172 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5173 when "big" contains more than 2**29 bytes, even though this
5174 inserts just one byte and does not overflow the buffer.
5175 (Finsert_file_contents): Store file offsets as off_t
5176 values, not as EMACS_INT values. Check for overflow when
5177 converting between EMACS_INT and off_t. When checking for
5178 buffer overflow or for overlap, take the offsets into account.
5179 Don't use EMACS_INT for small values where int suffices.
5180 When checking for overlap, fix a typo: ZV was used where
5181 ZV_BYTE was intended.
5182 (Fwrite_region): Don't assume off_t fits into 'long'.
5183 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5184
ecfc0a49
MA
51852011-09-05 Michael Albinus <michael.albinus@gmx.de>
5186
5187 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5188
6511acf2 51892011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5190
0999621a 5191 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5192
5193 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5194 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5195 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5196 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5197 (modify_event_symbol): Do not assume that the length of
5198 name_alist_or_stem is safe to alloca and fits in int.
5199 (Fexecute_extended_command): Likewise for function name and binding.
5200 (Frecursion_depth): Wrap around reliably on integer overflow.
5201 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5202 since some callers pass EMACS_INT values.
5203 (Fsingle_key_description): Don't crash if symbol name contains more
5204 than MAX_ALLOCA bytes.
5205 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5206 (get_minibuffer): Arg is now EMACS_INT, not int.
5207 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5208 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5209 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5210
2be7d702
PE
5211 * dbusbind.c (signature_cat): New function.
5212 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5213 Do not overrun buffer; instead, report string overflow.
5214
9d1df220
PE
5215 * dispnew.c (add_window_display_history): Don't overrun buffer.
5216 Truncate instead; this is OK since it's just a log.
5217
33ef5c64
PE
5218 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5219 even if the time zone offset is outlandishly large.
5220 Don't mishandle offset == INT_MIN.
5221
66c6fdd5
PE
5222 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5223 when creating daemon; the previous buffer-overflow check was incorrect.
5224
d749b01b
PE
5225 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5226 which has the guts of the old verror function.
5227
b5cd1905
PE
5228 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5229 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5230
6e1a67fb
PE
5231 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5232 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5233 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5234 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5235 length of string rather than counting it via multiple sprintfs;
5236 that's simpler and more reliable.
c21721cc
PE
5237 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5238 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5239 sprintf, in case result does not fit in int.
5240
c57b67fc
PE
5241 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5242 (fontset_from_font): Print it.
5243
8a401434
PE
5244 * frame.c (tty_frame_count): Now printmax_t, not int.
5245 (make_terminal_frame, set_term_frame_name): Print it.
5246 (x_report_frame_params): In X, window IDs are unsigned long,
5247 not signed long, so print them as unsigned.
5248 (validate_x_resource_name): Check for implausibly long names,
5249 and don't assume name length fits in 'int'.
5250 (x_get_resource_string): Don't blindly alloca invocation name;
5251 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5252 not fit in int.
5253
6e1a67fb
PE
5254 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5255 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5256 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5257
0df02bf3
PE
5258 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5259 Use esprintf, not sprintf, in case result does not fit in int.
5260
48e30793
PE
5261 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5262 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5263 it as a large positive number.
5264 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5265 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5266
a66ff6d8
PE
5267 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5268 in case result does not fit in int.
5269
aca216ff
PE
5270 * print.c (float_to_string): Detect width overflow more reliably.
5271 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5272 buffer overrun. Don't assume list length fits in 'int'. Treat
5273 print length of 0 as 0, not as infinity; to be consistent with other
5274 uses of print length in this function. Don't overflow print length
5275 index. Don't assume hash table size fits in 'long', or that
5276 vectorlike size fits in 'unsigned long'.
5277
31c286f7
PE
5278 * process.c (make_process): Use printmax_t, not int, to format
5279 process-name gensyms.
5280
55e5faa1
PE
5281 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5282
80f2e268
PE
5283 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5284 to avoid potential buffer overrun.
5285
670741ab
PE
5286 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5287 if X resource line is longer than 512 bytes.
5288
b7163a50
PE
5289 * xfns.c (x_window): Make sprintf buffer a bit bigger
5290 to avoid potential buffer overrun.
5291
ae58ff1f
PE
5292 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5293
c43c8a6a
PE
5294 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5295
3f8236f4
PE
52962011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5297
53e9fe90 5298 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5299 Without these, Emacs silently mishandles large integers sometimes.
5300 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5301 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5302
6511acf2
PE
5303 * xdisp.c (try_window_id): Check Emacs fixnum range before
5304 converting to 'int'.
806add1d 5305
6511acf2 5306 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5307 Check that an Emacs fixnum is in range before assigning it to 'int'.
5308 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5309 values converted from Emacs fixnums.
5310 (Frecenter): Don't wrap around a line count if it is out of 'int'
5311 range; instead, treat it as an extreme value.
5312 (Fset_window_configuration, compare_window_configurations):
5313 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5314
6511acf2
PE
5315 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5316 that can exceed INT_MAX. Check that EMACS_INT value is in range
5317 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5318 (match_limit): Don't assume that a fixnum can fit in 'int'.
5319
6511acf2 5320 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5321 exceed INT_MAX.
5322
6511acf2 5323 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5324 (Fvertical_motion): Don't wrap around LINES values that don't fit
5325 in 'int'. Instead, treat them as extreme values. This is good
5326 enough for windows, which can't have more than INT_MAX lines anyway.
5327
fcb901a7
LMI
53282011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5329
0f2f6b6d
LMI
5330 * Require libxml/parser.h to avoid compilation warning.
5331
fcb901a7
LMI
5332 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5333
5334 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5335 since this reportedly can destroy thread storage.
5336
6e20a0d4
CY
53372011-08-30 Chong Yidong <cyd@stupidchicken.com>
5338
5339 * syntax.c (find_defun_start): Update all cache variables if
5340 exiting early (Bug#9401).
5341
148ae00e
EZ
53422011-08-30 Eli Zaretskii <eliz@gnu.org>
5343
f6cfbd8f
EZ
5344 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5345
148ae00e
EZ
5346 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5347 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5348 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5349
5350 * term.c (tty_append_glyph): New function.
5351 (produce_stretch_glyph): Static function and its prototype deleted.
5352
a66cfb1c
SM
5353 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5354 Add prototypes.
148ae00e 5355
c4a07a4c
PE
53562011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5357
5358 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5359 when checking :margin (Bug#9390).
5360 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5361 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5362 so that the name doesn't mislead. All uses changed.
5363
6bc8cd65
JB
53642011-08-28 Johan Bockgård <bojohan@gnu.org>
5365
5366 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5367 set_tty_hooks.
5368
dca4927e
EZ
53692011-08-27 Eli Zaretskii <eliz@gnu.org>
5370
5371 * xdisp.c (move_it_to): Don't bail out early when reaching
5372 position beyond to_charpos, if we are scanning backwards.
5373 (move_it_vertically_backward): When DY == 0, make sure we get to
5374 the first character in the line after the newline.
5375
f2cad773
PE
53762011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5377
5378 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5379 (ccl_driver): Do not generate an out-of-range pointer.
5380 (Fccl_execute_on_string): Remove unnecessary check for
5381 integer overflow, noted by Stefan Monnier in
5382 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5383 Remove a FIXME that didn't need fixing.
5384 Simplify the newly-introduced buffer reallocation code.
5385
0cae2cdb
JB
53862011-08-27 Juanma Barranquero <lekktu@gmail.com>
5387
5388 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5389
5fc295a4 53902011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5391
70c60eb2 5392 Integer and memory overflow issues (Bug#9196).
726e0ab1 5393
d31850da
PE
5394 * doc.c (get_doc_string): Rework so that
5395 get_doc_string_buffer_size is the actual buffer size, rather than
5396 being 1 less than the actual buffer size; this makes xpalloc more
5397 convenient.
5398
a69fbedb
PE
5399 * image.c (x_allocate_bitmap_record, cache_image):
5400 * xselect.c (Fx_register_dnd_atom):
5401 Simplify previous changes by using xpalloc.
5402
fe5c5d37
PE
5403 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5404 since either will do and ptrdiff_t is convenient with xpalloc.
5405
0065d054
PE
5406 * charset.c (charset_table_size)
5407 (struct charset_sort_data.priority): Now ptrdiff_t.
5408 (charset_compare): Don't overflow if priorities differ greatly.
5409 (Fsort_charsets): Don't assume list length fits in int.
5410 Check for size-calculation overflow when allocating sort data.
5411 (syms_of_charset): Allocate an initial charset table that is
5412 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5413
5414 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5415
5416 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5417 The actual value is always <= INT_MAX, and leaving it unsigned made
5418 overflow checking harder.
5419
5420 * dispextern.h (struct glyph_matrix.rows_allocated)
5421 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5422 with xpalloc. The values are still always <= INT_MAX.
5423
5424 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5425
5426 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5427 (SAFE_NALLOCA): New macro.
5428
5429 * region-cache.c (struct boundary.pos, find_cache_boundary)
5430 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5431 (set_cache_region, invalidate_region_cache)
5432 (revalidate_region_cache, know_region_cache, region_cache_forward)
5433 (region_cache_backward, pp_cache):
5434 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5435 so that ptrdiff_t * can be passed to xpalloc.
5436 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5437 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5438 (pp_cache): Don't assume cache_len fits in int.
5439 * region-cache.h: Adjust extern decls to match.
5440
5441 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5442 EMACS_INT, since either will do, for xpalloc.
5443
5444 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5445 (xnmalloc, xnrealloc, xpalloc): New functions.
5446
726e0ab1
PE
5447 * bidi.c (bidi_shelve_header_size): New constant.
5448 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5449 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5450
51f30bc5 5451 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5452 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5453 (overlay_strings):
5454 Don't update size of array until after memory allocation succeeds,
5455 because xmalloc/xrealloc may not return.
0065d054
PE
5456 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5457 now that we have proper integer overflow checking.
5458 (record_overlay_string, overlay_strings): Catch overflows when
5459 calculating size of overlay_str_buf.
726e0ab1 5460
0065d054
PE
5461 * callproc.c (Fcall_process): Check for size overflow when
5462 calculating size of args2.
5463 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5464 Normally we prefer signed values, but sticking with ptrdiff_t would
5465 require adding more-complicated checks.
726e0ab1
PE
5466
5467 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5468 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5469 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5470 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5471
5472 * character.c (Fstring): Check for size-calculation overflow.
5473
5474 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5475 unnecessary integer overflow. Check for size overflow.
5476 (encode_coding_object): Don't update size until xmalloc succeeds.
5477
5478 * composite.c (get_composition_id): Check for overflow in glyph
5479 length calculations.
5480
5481 Integer and memory overflow fixes for display code.
5482 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5483 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5484 (scrolling_window): Check for overflow in size calculations.
5485 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5486 Don't assume glyph table len fits in int.
5487 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5488 (row_table_size): Now ptrdiff_t, not int.
5489 (scrolling_window): Avoid overflow in size calculations.
5490 Don't update size until allocation succeeds.
5491 * fns.c (concat): Check for overflow in size calculations.
5492 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5493 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5494 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5495
5496 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5497 (get_doc_string): Check for size calculation overflow.
5498 Don't update size until allocation succeeds.
5499 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5500 EMACS_INT, where ptrdiff_t will do.
5501 (Fsubstitute_command_keys): Check for string overflow.
5502
5503 * editfns.c (set_time_zone_rule): Don't assume environment length
5504 fits in int.
5505 (message_length): Now ptrdiff_t, not int.
5506 (Fmessage_box): Don't update size until allocation succeeds.
5507 Don't assume message length fits in int.
5508 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5509
0065d054
PE
5510 * emacs.c (main): Do not reallocate argv, since there is a null at
5511 the end that can be overwritten, and this way there's no need to
5512 worry about size-calculation overflow.
5513 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5514
5515 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5516 alloc succeeds.
5517 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5518
5519 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5520 (x_set_scroll_bar_width, x_figure_window_size):
5521 Check for integer overflow.
5522 (x_set_alpha): Do not assume XINT fits in int.
5523
5524 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5525 This is for the members text_lines, text_cols, total_lines, total_cols,
5526 where the system imposes an 'int' limit.
5527
5528 * fringe.c (Fdefine_fringe_bitmap):
5529 Don't update size until alloc works.
5530
5531 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5532 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5533
5534 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5535 Check for size-calculation overflow.
5536 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5537 do, as we prefer signed integers.
5538 (id_to_widget.max_size, id_to_widget.used)
5539 (xg_store_widget_in_map, xg_remove_widget_from_map)
5540 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5541 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5542 Use and return ptrdiff_t, not int.
5543 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5544 * gtkutil.h: Change prototypes to match the above.
5545
5546 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5547 are duplicate now that they've been promoted to lisp.h.
5548 (x_allocate_bitmap_record, x_alloc_image_color)
5549 (make_image_cache, cache_image, xpm_load):
5550 Don't update size until alloc is done.
5551 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5552 (x_detect_edges):
3256efce 5553 Check for size calculation overflow.
726e0ab1
PE
5554 (ct_colors_allocated_max): New constant.
5555 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5556 overflow.
3256efce 5557
726e0ab1
PE
5558 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5559 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5560 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5561 Use ptrdiff_t, not int, to count maps.
5562 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5563 calculations. Don't update size until allocation succeeds.
5564 Redo calculations to avoid overflow.
726e0ab1
PE
5565 * keyboard.h: Change prototypes to match the above.
5566
5567 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5568 to count maps.
5569 (current_minor_maps): Check for size calculation overflow.
5570 * keymap.h: Change prototypes to match the above.
5571
5572 * lread.c (read1, init_obarray): Don't update size until alloc done.
5573
5574 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5575 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5576
726e0ab1
PE
5577 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5578 Now ptrdiff_t, not int.
5579 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5580 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5581
5582 * process.c (Fnetwork_interface_list): Check for overflow
5583 in size calculation.
5584
5585 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5586
5587 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5588 overflow. Don't bother calling xmalloc when xrealloc will do.
5589
5590 * search.c (Freplace_match): Check for size calculation overflow.
5591 (Fset_match_data): Don't assume list lengths fit in 'int'.
5592
5593 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5594 for command line length. Do not attempt to address one before the
5595 beginning of an array, as that's not portable.
5596
5597 * term.c (max_frame_lines): Remove; unused.
5598 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5599 not int.
5600 (encode_terminal_code, calculate_costs): Check for size
5601 calculation overflow.
5602 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5603 table lengths and related sizes. Don't update size until alloc
5604 done. Redo calculations to avoid overflow.
5605 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5606
5607 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5608 subtracting pointers.
5609 (gobble_line): Check for overflow more carefully. Don't update size
5610 until alloc done.
5611
5612 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5613 Don't update size until alloc done.
5614 Redo size calculations to avoid overflow.
5615 Check for size calculation overflow.
0065d054 5616 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5617
5618 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5619 Use ptrdiff_t, not int, for sizes.
5620 (store_mode_line_noprop_char): Don't update size until alloc done.
5621
0065d054
PE
5622 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5623 Use ptrdiff_t, not int, for sizes.
5624 (Finternal_make_lisp_face, cache_face):
5625 Check for size calculation overflow.
5626 (cache_face): Treat size calculation overflows as if they were
5627 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5628
5629 * xfns.c (x_encode_text, x_set_name_internal)
5630 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5631 sizes, since they can exceed INT_MAX in size. Check for size
5632 calculation overflow.
5633
0065d054
PE
5634 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5635 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5636 Don't update size until alloc done.
5637
0065d054 5638 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5639 as sprintf is limited to int lengths.
1d526e2f 5640
252c5ee1
PE
5641 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5642 (X_LONG_MIN): New macros.
864d7ce7
PE
5643 Use them to make the following changes clearer.
5644 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5645 This change doesn't affect the value now, but it may help remind
5646 future maintainers not to raise the value too much later.
5647 (SELECTION_QUANTUM): Remove, replacing with ...
5648 (selection_quantum): ... new function, which avoids overflow.
5649 All uses changed.
5650 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5651 assumption that selection length fits in 'int'.
5652 (x_reply_selection_request, x_handle_selection_request)
5653 (x_get_window_property, receive_incremental_selection)
5654 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5655 (lisp_data_to_selection_data, clean_local_selection_data):
5656 Use ptrdiff_t, not int, to record length of selection.
5657 (x_reply_selection_request, x_get_window_property)
5658 (receive_incremental_selection, x_property_data_to_lisp):
5659 Redo calculations to avoid overflow.
5660 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5661 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5662 something.
5663 (x_get_window_property, receive_incremental_selection)
5664 (lisp_data_to_selection_data, x_property_data_to_lisp):
5665 Check for size-calculation overflow.
5666 (x_get_window_property, receive_incremental_selection)
5667 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5668 Don't store size until memory allocation succeeds.
5669 (x_get_window_property): Plug memory leak on memory exhaustion.
5670 Don't double-block input; malloc is safe here. Don't assume 2**34
5671 - 4 fits in unsigned long. Add an xassert to check
5672 XGetWindowProperty overflow. Be more careful about overflow
5673 calculations, and distinguish size from memory overflow better.
5674 (receive_incremental_selection): When tracing, don't assume
5675 unsigned int is less than INT_MAX.
5676 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5677 harmful) conversions of unsigned short to int.
5678 (lisp_data_to_selection_data): Don't assume that integers
5679 in the range -65535 through -1 fit in an X unsigned short.
5680 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5681 result parameters unless successful. Rely on cons_to_unsigned
5682 to report problems with elements; the old code wasn't right anyway.
5683 (x_check_property_data): Check for int overflow; we cannot use
5684 a wider type due to X limits.
5685 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5686
726e0ab1 5687 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5688
0065d054
PE
5689 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5690 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5691 (x_color_cells): Don't store size until memory allocation succeeds.
5692 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5693 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5694 (x_term_init): Don't assume length fits in int (sprintf is limited
5695 to int size).
bc18e09d 5696
ebfa62c0
PE
5697 Use ptrdiff_t for composition IDs.
5698 * character.c (lisp_string_width):
5699 * composite.c (composition_table_size, n_compositions)
5700 (get_composition_id, composition_gstring_from_id):
5701 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5702 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5703 * window.c (Frecenter):
5704 Use ptrdiff_t, not int, for composition IDs.
5705 * composite.c (get_composition_id): Check for integer overflow.
5706 * composite.h: Adjust prototypes to match the above changes.
5707
d3411f89
PE
5708 Use ptrdiff_t for hash table indexes.
5709 * category.c (hash_get_category_set):
5710 * ccl.c (ccl_driver):
5711 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5712 * coding.c (coding_system_charset_list, detect_coding_system):
5713 * coding.h (struct coding_system.id):
5714 * composite.c (get_composition_id, gstring_lookup_cache):
5715 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5716 * image.c (xpm_get_color_table_h):
5717 * lisp.h (hash_lookup, hash_put):
5718 * minibuf.c (Ftest_completion):
5719 Use ptrdiff_t for hash table indexes, not int (which is too
5720 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5721 32-bit --with-wide-int hosts).
5722
e097a6fa
PE
5723 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5724 Add a FIXME comment about memory leaks.
5725 (syms_of_charset): Don't assume xmalloc returns.
5726
5637687f
PE
5727 Don't assume that stated character widths fit in int.
5728 * character.c (Fchar_width, c_string_width, lisp_string_width):
5729 * character.h (CHAR_WIDTH):
5730 * indent.c (MULTIBYTE_BYTES_WIDTH):
5731 Use sanitize_char_width to avoid undefined and/or bad behavior
5732 with outlandish widths.
a66cfb1c 5733 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5734 now that we have two such functions. All uses changed.
5735 (sanitize_char_width): New inline function.
5736
a2271ba2
PE
5737 Don't assume that tab-width fits in int.
5738 * character.h (sanitize_width): New inline function.
5739 (SANE_TAB_WIDTH): New macro.
5740 (ASCII_CHAR_WIDTH): Use it.
5741 * indent.c (sane_tab_width): Remove. All uses replaced by
5742 SANE_TAB_WIDTH (current_buffer).
5743 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5744
18c52557
PE
5745 * fileio.c: Integer overflow issues with file modes.
5746 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5747
caeeedc1
PE
5748 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5749 Remove unreachable code.
5750 (read_hex, load_charset_map_from_file): Check for integer overflow.
5751
6df6ae42 5752 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5753 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5754 (x_send_scroll_bar_event): Likewise. Check that the size does not
5755 exceed limits imposed by XClientMessageEvent, as well as the usual
5756 ptrdiff_t and size_t limits.
5757
b13995db
PE
5758 * keyboard.c: Overflow, signedness and related fixes.
5759 (make_lispy_movement): Use same integer type in forward decl
5760 that is used in the definition.
5761 (read_key_sequence, keyremap_step):
5762 Change bufsize argument back to int, undoing my 2011-03-30 change.
5763 We prefer signed types, and int is wide enough here.
5764 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5765 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5766 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5767 length, not size_t. Use ptrdiff_t for index, not int.
5768 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5769 possibility of integer overflow.
5770
13464394
PE
5771 Overflow, signedness and related fixes for images.
5772
5773 * dispextern.h (struct it.stack[0].u.image.image_id)
5774 (struct_it.image_id, struct image.id, struct image_cache.size)
5775 (struct image_cache.used, struct image_cache.ref_count):
5776 * gtkutil.c (update_frame_tool_bar):
5777 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5778 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5779 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5780 * nsmenu.m (update_frame_tool_bar):
5781 * xdisp.c (calc_pixel_width_or_height):
5782 * xfns.c (image_cache_refcount):
5783 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5784 on typical 64-bit hosts.
5785
5786 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5787 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5788 Omit unnecessary casts to int.
5789 (parse_image_spec): Check that integers fall into 'int' range
5790 when the callers expect that.
5791 (image_ascent): Redo ascent calculation to avoid int overflow.
5792 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5793 (lookup_image): Remove unnecessary tests.
5794 (xbm_image_p): Locals are now of int, not EMACS_INT,
5795 since parse_image_check makes sure they fit into int.
5796 (png_load, gif_load, svg_load_image):
5797 Prefer int to unsigned where either will do.
5798 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5799 old tiff_error_handler and tiff_warning_handler.
5800 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5801 stack buffer overflows. It uses only the features of vsnprintf
5802 that are common to both POSIX and native Microsoft.
5803 (tiff_error_handler, tiff_warning_handler): Use it.
5804 (tiff_load, gif_load, imagemagick_load_image):
5805 Don't assume :index value fits in 'int'.
5806 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5807 (imagemagick_load_image): Check that crop parameters fit into
5808 the integer types that MagickCropImage accepts. Don't assume
5809 Vimagemagick_render_type has a nonnegative value. Don't assume
5810 size_t fits in 'long'.
5811 (gs_load): Use printmax_t to print the widest integers possible.
5812 Check for integer overflow when computing image height and width.
5813
c11821d4
EZ
58142011-08-26 Eli Zaretskii <eliz@gnu.org>
5815
5816 * xdisp.c (redisplay_window): Don't force window start if point
5817 will be invisible in the resulting window. (Bug#9324)
5818
0c95fcf7
EZ
58192011-08-25 Eli Zaretskii <eliz@gnu.org>
5820
5821 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5822 the display spec is of the form `(space ...)'.
5823 (handle_display_spec): Return the value returned by
5824 handle_single_display_spec, not just 1 or zero.
5825 (handle_single_display_spec): If the display spec is of the form
5826 `(space ...)', and specifies display in the text area, return 2
5827 rather than 1.
fee65a97 5828 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5829 accurately, and prefer exact match for point under bidi.
5830 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5831
5832 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5833 into disp_prop; all users changed.
5834
5835 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5836 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5837 for the text covered by the display property.
5838
e4ed06f1
CY
58392011-08-25 Chong Yidong <cyd@stupidchicken.com>
5840
5841 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5842 Change return value to nil.
5843 (Frecord_buffer): Delete unused function.
5844
f67cdd7f
EZ
58452011-08-24 Eli Zaretskii <eliz@gnu.org>
5846
5980d4c6
EZ
5847 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5848 buffers, return left-to-right.
8610fe8b
EZ
5849 (set_cursor_from_row): Consider candidate row a win if its glyph
5850 represents a newline and point is on that newline. Fixes cursor
5851 positioning on the newline at EOL of R2L text within L2R
5852 paragraph, and vice versa.
5853 (try_cursor_movement): Check continued rows, in addition to
5854 continuation rows. Fixes unwarranted scroll when point enters a
5855 continued line of R2L text within an L2R paragraph, or vice versa.
5856 (cursor_row_p): Consider the case of point being equal to
5857 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5858 from the end of a short line to the beginning of a continued line
5859 of R2L text within L2R paragraph.
5860 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5861 composed characters.
5980d4c6 5862
f67cdd7f
EZ
5863 * bidi.c (bidi_check_type): Use xassert.
5864 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5865 members.
5866
bca633fb
EZ
58672011-08-23 Eli Zaretskii <eliz@gnu.org>
5868
5869 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5870 a character.
5871
4a5885a7
CY
58722011-08-23 Chong Yidong <cyd@stupidchicken.com>
5873
5874 * nsfont.m (ns_otf_to_script): Fix typo.
5875
0902a04e
KH
58762011-08-22 Kenichi Handa <handa@m17n.org>
5877
5878 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5879 extra slot even if the purpose is char-code-property-table.
5880
1a2e6670
EZ
58812011-08-23 Eli Zaretskii <eliz@gnu.org>
5882
8ddde651
EZ
5883 * xdisp.c (redisplay_window): When computing centering_position,
5884 account for the height of the header line. (Bug#8874)
5885
425cc014
EZ
5886 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5887 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5888 candidate is selected by the mouse, and that candidate has a
5889 composed character under the mouse.
5890
1a2e6670
EZ
5891 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5892 coordinates reported by pos-visible-in-window-p for a composed
5893 character in column zero.
5894
8b76d6f8
SM
58952011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5896
5897 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5898
dac347dd
EZ
58992011-08-22 Eli Zaretskii <eliz@gnu.org>
5900
5901 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5902 consider it a hit if to_charpos is anywhere in the range of the
5903 composed buffer positions.
5904
e013fb34
CY
59052011-08-22 Chong Yidong <cyd@stupidchicken.com>
5906
5907 * image.c (gif_load): Don't assume that each subimage has the same
5908 dimensions as the base image. Handle disposal method that is
5909 "undefined" by the gif spec (Bug#9335).
5910
bd1ba3e8
CY
59112011-08-20 Chong Yidong <cyd@stupidchicken.com>
5912
5913 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5914 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5915
54a1215b
EZ
59162011-08-19 Eli Zaretskii <eliz@gnu.org>
5917
823564e5
EZ
5918 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5919 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5920 from an Org mode buffer to a Speedbar frame.
5921
54a1215b
EZ
5922 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5923 a composition, take its buffer position from IT->cmp_it.charpos.
5924 Fixes cursor positioning at the beginning of a line that begins
5925 with a composed character.
5926
9778ebcc
EZ
59272011-08-18 Eli Zaretskii <eliz@gnu.org>
5928
0be6ee06
EZ
5929 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5930 character bidirectional type, use STRONG_L instead. Fixes crashes
5931 in a buffer produced by `describe-categories'.
5932
9778ebcc
EZ
5933 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5934 members before the level stack, so they would be saved and
5935 restored when copying iterator state. Fixes incorrect reordering
5936 around TABs covered by display properties.
5937
156bffbe
AS
59382011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5939
6b02f655 5940 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5941
72ad093b
CY
59422011-08-17 Chong Yidong <cyd@stupidchicken.com>
5943
5944 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5945 (internal_condition_case_2, internal_condition_case_n):
5946 Remove unnecessary aborts (Bug#9081).
72ad093b 5947
35774242
EZ
59482011-08-17 Eli Zaretskii <eliz@gnu.org>
5949
5950 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5951 has no `load' handler, try opening the file locally. (Bug#9311)
5952
db76dd85
KB
59532011-08-16 Ken Brown <kbrown@cornell.edu>
5954
5955 * gmalloc.c: Expand comment.
5956
b215eee5
EZ
59572011-08-16 Eli Zaretskii <eliz@gnu.org>
5958
5959 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5960 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5961
a4579d33
KB
59622011-08-16 Ken Brown <kbrown@cornell.edu>
5963
5964 Fix memory allocation problems in Cygwin build (Bug#9273).
5965
5966 * unexcw.c ( __malloc_initialized): Declare external variable.
5967 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5968
8b76d6f8
SM
5969 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5970 New variables.
a4579d33
KB
5971 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5972 dumped emacs.
5973 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5974 in the static heap.
5975 [CYGWIN] (special_realloc): New function.
5976 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5977 requests to realloc storage in the static heap.
5978
3ebec551
PE
59792011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5980
5981 * bidi.c (bidi_initialize): Remove unused local.
5982
9fd8be00
EZ
59832011-08-15 Eli Zaretskii <eliz@gnu.org>
5984
6b02f655
SM
5985 * bidimirror.h:
5986 * biditype.h: Remove file.
5987 * makefile.w32-in ($(BLD)/bidi.$(O)):
5988 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5989
5990 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5991
5992 * chartab.c: Improve commentary for the uniprop_table API.
5993
32413314
EZ
5994 * bidi.c (bidi_paragraph_init): Support zero value of
5995 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5996 (bidi_initialize): Use uniprop_table instead of including
5997 biditype.h and bidimirror.h.
32413314 5998
9fd8be00
EZ
5999 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6000 coordinates of the iterator when restoring from ppos_it.
6001 (Bug#9296)
6002
5cf2b69b
KH
60032011-08-14 Kenichi Handa <handa@m17n.org>
6004
6005 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6006 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6007
daf17d00
EZ
60082011-08-14 Eli Zaretskii <eliz@gnu.org>
6009
6010 * xdisp.c (move_it_in_display_line_to): Don't invoke
6011 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6012 ppos_it. Fixes vertical cursor motion when line beginning is
6013 covered by an image. (Bug#9296)
6014
08e3161a
JD
60152011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6016
6017 * nsterm.h (ns_run_ascript): Declare.
6018 (NSAPP_DATA2_RUNASSCRIPT): Define.
6019
6020 * nsfns.m (as_script, as_result, as_status): New static variables.
6021 (ns_run_ascript): New function.
5e617bc2 6022 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6023 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6024 the event loop. Get status from as_status (Bug#7276).
6025
6026 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6027 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6028 the event loop (Bug#7276).
6029
a3720aa2
AS
60302011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6031
6032 * gnutls.c (QCgnutls_bootprop_priority)
6033 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6034 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6035 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6036 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6037 (QCgnutls_bootprop_verify_hostname_error)
6038 (QCgnutls_bootprop_callbacks_verify): Rename from
6039 Qgnutls_bootprop_..., all uses changed.
6040
6041 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6042 uses changed.
6043
0a0d27fb
PE
60442011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6045
19d5c50c
PE
6046 * xfaces.c (Qframe_set_background_mode): Now static.
6047 * dispextern.h (Qframe_set_background_mode): Remove decl.
6048
0a0d27fb
PE
6049 * process.c (Fnetwork_interface_info): Declare local only if needed.
6050
377538cb
JD
60512011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6052
6053 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6054 (Fnetwork_interface_list): Allocate in increments of bytes instead
6055 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6056 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6057 sockaddr.
6058 (struct ifflag_def): notrailers is smart on OSX.
6059 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6060 Get hardware address with getifaddrs if available.
6061
08fff70c
EZ
60622011-08-12 Eli Zaretskii <eliz@gnu.org>
6063
6064 * xdisp.c (iterate_out_of_display_property): xassert that
6065 IT->position is set to within IT->object's boundaries. Break from
6066 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6067 when IT->position is set up wrongly due to some bug.
6068 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6069 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6070 entry. Force push_it to save on the stack the current
6071 buffer/string position, to be restored by pop_it. Fix flags in
6072 the iterator structure wrt the object coming from a display
6073 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6074 properties. (Bug#9284)
6075
7be1c708 60762011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6077
7be1c708
CY
6078 * fontset.c (fontset_get_font_group): Add proper type checks.
6079 (Bug#9172)
aac0c6e3 6080
7be1c708 60812011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6082
7be1c708
CY
6083 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6084 and LC_VERSION_MIN_MACOSX.
6085 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6086 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6087
97bb72a6
EZ
60882011-08-08 Eli Zaretskii <eliz@gnu.org>
6089
6090 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6091 no-display-properties-and-no-overlays under bidi display.
6092 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6093 properties and overlays.
97bb72a6 6094
d5617611
CY
60952011-08-08 Chong Yidong <cyd@stupidchicken.com>
6096
37e11a63
CY
6097 * editfns.c (Fset_time_zone_rule): Document relationship with the
6098 setenv function.
6099
d5617611
CY
6100 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6101 the font entity extracted from the cache (Bug#8109).
6102
58872834
CY
61032011-08-07 Chong Yidong <cyd@stupidchicken.com>
6104
6105 * composite.c (autocmp_chars): Don't reset point. That is done by
6106 restore_point_unwind (Bug#5984).
6107
75bfc667
JL
61082011-08-07 Juri Linkov <juri@jurta.org>
6109
6110 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6111 to show the arg `TIME' instead of `TIMEVAL'.
6112
d1410150
EZ
61132011-08-06 Eli Zaretskii <eliz@gnu.org>
6114
6115 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6116 display property strides EOL and includes a newline, as in
6117 longlines-mode. (Bug#9254)
75b771e4
EZ
6118 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6119 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6120
6121 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6122 is non-zero, even if the data buffer is NULL. Fixes a crash in
6123 vertical-motion with longlines-mode. (Bug#9254)
6124
35928349
EZ
61252011-08-05 Eli Zaretskii <eliz@gnu.org>
6126
ec7cc85b
EZ
6127 * bidi.c <bidi_cache_total_alloc>: Now static.
6128 (bidi_initialize): Initialize bidi_cache_total_alloc.
6129
8b76d6f8 6130 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6131 cache. (Bug#9221)
6132
6133 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6134 amount allocated this far in `bidi_cache_total_alloc'.
6135 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6136 non-zero, only free the data buffer without restoring the cache
6137 contents. All callers changed.
6138
6139 * dispextern.h (bidi_unshelve_cache): Update prototype.
6140
6141 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6142 (move_it_in_display_line, move_it_to)
6143 (move_it_vertically_backward, move_it_by_lines): Replace the call
6144 to xfree to an equivalent call to bidi_unshelve_cache.
6145 (move_it_in_display_line_to): Fix logic of returning
412b6358 6146 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6147
e2e2423b
EZ
61482011-08-05 Eli Zaretskii <eliz@gnu.org>
6149
6150 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6151 came from a string character with a `cursor' property. (Bug#9229)
6152
ae9e757a
JD
61532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6154
6155 * Makefile.in (LIB_PTHREAD): New variable.
6156 (LIBES): Add LIB_PTHREAD (Bug#9216).
6157
6158 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6159 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6160
213bd7f2
AS
61612011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6162
6b02f655 6163 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6164
99aaf75f
JD
61652011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6166
6167 * xterm.c (x_find_topmost_parent): New function.
6168 (x_set_frame_alpha): Find topmost parent window with
6169 x_find_topmost_parent and set the property there also (bug#9181).
6170 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6171
c74e9d86
PE
61722011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6173
6174 * callproc.c (Fcall_process): Avoid vfork clobbering
6175 the local vars buffer, coding_systems, current_dir.
6176
640c8776
SM
61772011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6178
6179 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6180
f26d0e4c
PE
61812011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6182
8a10d76c
PE
6183 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6184 so that it is not optimized away.
6185
f26d0e4c
PE
6186 * xdisp.c (compute_display_string_pos): Remove unused local.
6187
55439c61
EZ
61882011-08-02 Eli Zaretskii <eliz@gnu.org>
6189
6190 Fix slow cursor motion and scrolling in large buffers with
6191 selective display, like Org Mode buffers. (Bug#9218)
6192
6193 * dispextern.h (struct bidi_it): New member disp_prop_p.
6194
6195 * xdisp.c: Remove one-slot cache of display string positions.
6196 (compute_display_string_pos): Accept an additional argument
5e617bc2 6197 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6198 for a display string or property. If found, set DISP_PROP_P
6199 non-zero.
6200
6201 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6202 DISP_PROP_P, and pass it to compute_display_string_pos.
6203 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6204 non-zero. All callers of bidi_fetch_char changed.
6205
fb33fa43
SM
62062011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6207
6208 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6209
b099e063
DM
62102010-12-03 Don March <don@ohspite.net>
6211
6212 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6213 last character M-[char] is translated to ESC [char] (bug#7541).
6214
5cc7f7af
KH
62152011-08-02 Kenichi Handa <handa@m17n.org>
6216
d0fffa3f 6217 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6218
6219 * chartab.c (uniprop_table): Make it non-static.
6220
525d5e6e
EZ
62212011-08-01 Eli Zaretskii <eliz@gnu.org>
6222
6223 * xdisp.c (forward_to_next_line_start): Accept additional argument
6224 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6225 on the newline.
6226 (reseat_at_next_visible_line_start): Use the bidi iterator state
6227 returned by forward_to_next_line_start to restore the state of
6228 it->bidi_it after backing up to previous newline. (Bug#9212)
6229
31011111
AS
62302011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6231
6232 * regex.c (re_comp): Protoize.
6233 (re_exec): Fix return type.
6234 (regexec): Fix type of `ret'. (Bug#9203)
6235
476371c4
PE
62362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6237
e5d76069
PE
6238 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6239 This is needed if max-image-size is a floating-point number.
6240
9a79b20c
AS
62412011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6242
6243 * print.c (print_object): Print empty symbol as ##.
6244
6245 * lread.c (read1): Read ## as empty symbol.
6246
d8c2fa78
AA
62472011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6248
6249 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6250 setting frame foreground color (Bug#9175).
6251 (x_set_background_color): Likewise.
6252
ffe57a7a
AA
6253 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6254 contents (Bug#9176).
6255 (EmacsTooltip -init): Remove bezels and add shadows to
6256 tooltip windows.
6257
bf3492a5
AA
6258 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6259 or scroll bar (Bug#8470).
6260
d55e9c53
AA
6261 * nsfont.m (nsfont_open): Remove assignment to voffset and
6262 unnecessary vars hshink, expand, hd, full_height, min_height.
6263 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6264
6265 * nsterm.h (nsfont_info): Remove voffset field.
6266
d8c2fa78 62672011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6268
6269 Implement strike-through and overline on NextStep (Bug#8863).
6270
6271 * nsfont.m (nsfont_open): Use underline position provided by font,
6272 instead of hard-coded value of 2.
6273 (nsfont_draw): Call ns_draw_text_decoration instead.
6274
6275 * nsterm.h: Add declaration for ns_draw_text_decoration.
6276
6277 * nsterm.m (ns_draw_text_decoration): New function for drawing
6278 underline, overline, and strike-through.
6279 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6280 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6281 accommodate underlining, etc.
4843aac3 6282
4cc60b9b
EZ
62832011-07-28 Eli Zaretskii <eliz@gnu.org>
6284
bc7ece87
EZ
6285 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6286 default.
4cc60b9b 6287
476371c4
PE
62882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6289
66606eea
PE
6290 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6291 Without this fix, if a signal arrives just after memory fills up,
6292 'malloc' might be invoked reentrantly.
6293
476371c4
PE
6294 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6295 In other words, assume that every image size is allowed, on non-X
6296 hosts. This assumption is probably wrong, but it lets Emacs compile.
6297
f3fcc40d
AS
62982011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6299
6300 * regex.c (re_iswctype): Convert return values to boolean.
6301
350c992f
EZ
63022011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6303
6304 * xdisp.c (compute_display_string_pos): Don't use cached display
6305 string position if the buffer had its restriction changed.
6306 (Bug#9184)
6307
5266b4bb
PE
63082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6309
6310 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6311
2573a837 63122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6313
41f55ccd 6314 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6315
39e378da
PE
6316 * bidi.c: Integer size and overflow fixes.
6317 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6318 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6319 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6320 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6321 (bidi_find_other_level_edge):
6322 Use ptrdiff_t instead of EMACS_INT where either will do.
6323 This works better on 32-bit hosts configured --with-wide-int.
6324 (bidi_cache_ensure_space): Check for size-calculation overflow.
6325 Use % rather than repeated addition, for better worst-case speed.
6326 Don't set bidi_cache_size until after xrealloc returns, because it
6327 might not return.
6328 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6329 (bidi_cache_ensure_space): Also check that the bidi cache size
6330 does not exceed that of the largest Lisp string or buffer. See Eli
6331 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6332
5e927815
PE
6333 * alloc.c (__malloc_size_t): Remove.
6334 All uses replaced by size_t. See Andreas Schwab's note
6335 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6336
ca4aa935
PE
6337 * image.c: Improve checking for integer overflow.
6338 (check_image_size): Assume that f is nonnull, since
6339 it is always nonnull in practice. This is one less thing to
6340 worry about when checking for integer overflow later.
6341 (x_check_image_size): New function, which checks for integer
6342 overflow issues inside X.
6343 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6344 This removes the need for a memory_full check.
6345 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6346 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6347 (xbm_read_bitmap_data): Change locals back to 'int', since
6348 their values must fit in 'int'.
6349 (xpm_load_image, png_load, tiff_load):
6350 Invoke x_create_x_image_and_pixmap earlier,
6351 to avoid much needless work if the image is too large.
6352 (tiff_load): Treat overly large images as if
6353 x_create_x_image_and_pixmap failed, not as malloc failures.
6354 (gs_load): Use x_check_image_size.
6355
5f8f9cc2
PE
6356 * gtkutil.c: Omit integer casts.
6357 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6358 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6359
5adf60bc
PE
6360 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6361
c8907a93
PE
6362 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6363 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6364 would wrongly return t on a 64-bit host.
6365
e3c25c68
PE
6366 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6367 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6368 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6369 and therefore cause GCC to emit a bogus diagnostic in some cases.
6370
3f791afe
PE
6371 * image.c: Integer signedness and overflow and related fixes.
6372 This is not an exhaustive set of fixes, but it's time to
6373 record what I've got.
6374 (lookup_pixel_color, check_image_size): Remove redundant decls.
6375 (check_image_size): Don't assume that arbitrary EMACS_INT values
6376 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6377 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6378 (tiff_load, imagemagick_load_image):
6379 Check for overflow in size calculations.
6380 (x_create_x_image_and_pixmap): Remove unnecessary test for
6381 xmalloc returning NULL; that can't happen.
6382 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6383 (xpm_color_bucket): Use better integer hashing function.
6384 (xpm_cache_color): Don't possibly over-allocate memory.
6385 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6386 (gif_memory_source):
6387 Use ptrdiff_t, not int or size_t, to record sizes.
6388 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6389 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6390 either works, as we prefer signed integers.
6391 (tiff_read_from_memory, tiff_write_from_memory):
6392 Return tsize_t, not size_t, since that's what the TIFF API wants.
6393 (tiff_read_from_memory): Don't fail simply because the read would
6394 go past EOF; instead, return a short read.
6395 (tiff_load): Omit no-longer-needed casts.
6396 (Fimagemagick_types): Don't assume size fits into 'int'.
6397
3cc5a532
PE
6398 Improve hashing quality when configured --with-wide-int.
6399 * fns.c (hash_string): New function, taken from sxhash_string.
6400 Do not discard information about ASCII character case; this
6401 discarding is no longer needed.
6402 (sxhash-string): Use it. Change sig to match it. Caller changed.
6403 * lisp.h: Declare it.
6404 * lread.c (hash_string): Remove, since we now use fns.c's version.
6405 The fns.c version returns a wider integer if --with-wide-int is
6406 specified, so this should help the quality of the hashing a bit.
6407
b312a492
PE
6408 * emacs.c: Integer overflow minor fix.
6409 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6410 Define only if GNU_LINUX.
6411 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6412
dfd153ae
PE
6413 * dispnew.c: Integer signedness and overflow fixes.
6414 Remove unnecessary forward decls, that were a maintenance hassle.
6415 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6416 All uses changed.
6417 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6418 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6419 (prepare_desired_row, line_draw_cost):
6420 Use int, not unsigned, where either works.
6421 (save_current_matrix, restore_current_matrix):
6422 Use ptrdiff_t, not size_t, where either works.
6423 (init_display): Check for overflow more accurately, and without
6424 relying on undefined behavior.
6425
a81d11a3
PE
6426 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6427 Remove, replacing with the new symbols in lisp.h. All uses changed.
6428 * fileio.c (make_temp_name):
6429 * filelock.c (lock_file_1, lock_file):
6430 * xdisp.c (message_dolog):
6431 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6432 Use pMd etc. instead.
6433 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6434 replacing the pWIDE etc. symbols removed from editfns.c.
6435
3300e6fd
PE
6436 * keyboard.h (num_input_events): Now uintmax_t.
6437 This is (very slightly) less likely to mess up due to wraparound.
6438 All uses changed.
6439
fd05c7e9
PE
6440 * buffer.c: Integer signedness fixes.
6441 (alloc_buffer_text, enlarge_buffer_text):
6442 Use ptrdiff_t rather than size_t when either will do, as we prefer
6443 signed integers.
6444
903fe15d
PE
6445 * alloc.c: Integer signedness and overflow fixes.
6446 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6447 (__malloc_size_t): Default to size_t, not to int.
6448 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6449 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6450 Prefer ptrdiff_t to size_t when either would do, as we prefer
6451 signed integers.
6452 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6453 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6454 Now const. Initialize with values that are in range even if char
6455 is signed.
6456 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6457 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6458 These functions do the right thing with sizes > 2**32.
6459 (check_depth): Now ptrdiff_t, not int.
6460 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6461 Adjust to new way of storing sizes. Check for size overflow bugs
6462 in rest of code.
6463 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6464 slightly wrong anyway, as it missed one instance of
6465 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6466 (refill_memory_reserve): Omit needless cast to size_t.
6467 (mark_object_loop_halt): Mark as externally visible.
6468
ac82cc6a
PE
6469 * xselect.c: Integer signedness and overflow fixes.
6470 (Fx_register_dnd_atom, x_handle_dnd_message):
6471 Use ptrdiff_t, not size_t, since we prefer signed.
6472 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6473 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6474 x_dnd_atoms_size and x_dnd_atoms_length.
6475
c2d1e36d
PE
6476 * doprnt.c: Prefer signed to unsigned when either works.
6477 * eval.c (verror):
6478 * doprnt.c (doprnt):
6479 * lisp.h (doprnt):
6480 * xdisp.c (vmessage):
6481 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6482 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6483 prefer signed arithmetic to avoid comparison confusion.
6484 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6485 but is a bit tricky.
6486
0e926e56
PE
6487 Assume freestanding C89 headers, string.h, stdlib.h.
6488 * data.c, doprnt.c, floatfns.c, print.c:
6489 Include float.h unconditionally.
6490 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6491 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6492 * regex.c: Likewise for stddef.h, string.h.
6493 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6494 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6495 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6496 (STDC_HEADERS): Remove obsolete defines.
6497 * sysdep.c: Include limits.h unconditionally.
6498
9cfdb3ec
PE
6499 Assume support for memcmp, memcpy, memmove, memset.
6500 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6501 * regex.c (memcmp, memcpy):
6502 Remove; we assume C89 now.
6503
6504 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6505 (__malloc_safe_bcopy): Remove; no longer needed.
6506
cf950e6b 6507 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6508 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6509 well either way, and we prefer signed to unsigned.
6510
dbf38e02
LMI
65112011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6512
6513 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6514 closes the connection while we're reading (bug#9182).
6515
d6f0886c 65162011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6517
d6f0886c
JD
6518 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6519 are specified (Bug#9168).
24e0f6b1 6520
2eb1f9e6
PE
65212011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6522
6523 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6524 Found by GCC static checking and --with-wide-int on a 32-bit host.
6525
22381272 65262011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6527
6528 * xdisp.c (compute_display_string_pos): Fix logic of caching
6529 previous display string position. Initialize cached_prev_pos to
6530 -1. Fixes slow-down at the beginning of a buffer.
6531
f25e39b4
EZ
65322011-07-24 Eli Zaretskii <eliz@gnu.org>
6533
6534 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6535 for attrs[LFACE_FONTSET_INDEX].
6536
04c4b52e
PE
65372011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6538
6539 * xml.c (parse_region): Remove unused local
6540 that was recently introduced.
6541
c1734fbd
EZ
65422011-07-23 Eli Zaretskii <eliz@gnu.org>
6543
be18c5a5
EZ
6544 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6545 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6546
c1734fbd
EZ
6547 * xdisp.c (move_it_in_display_line_to): Record the best matching
6548 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6549 exit if none of the characters scanned was an exact match.
6550 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6551 when exact match is impossible due to invisible text, and the
6552 lines are truncated.
6553
a258d627
JD
65542011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6555
6556 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6557 for OSX >= 10.7.
6558
b6d5a689
EZ
65592011-07-22 Eli Zaretskii <eliz@gnu.org>
6560
0f74f785
EZ
6561 Fix a significant slow-down of cursor motion with C-n, C-p,
6562 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6563 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6564 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6565 (next_element_from_buffer): Call compute_stop_pos_backwards to
6566 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6567 base_level_stop.
6568 (reseat): Don't look for prev_stop, as that could mean a very long
6569 run.
6570 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6571 <cached_disp_overlay_modiff>: Cache for last found display string
6572 position.
551918c1 6573 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6574 about the same buffer in the same area of character positions, and
6575 the buffer wasn't changed since the time the display string
6576 position was cached.
551918c1 6577
b2d0c91a
EZ
65782011-07-22 Eli Zaretskii <eliz@gnu.org>
6579
6580 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6581 is an integer, which is important for empty lines. (Bug#9149)
6582
043604ee
CY
65832011-07-22 Chong Yidong <cyd@stupidchicken.com>
6584
6585 * frame.c (Fmodify_frame_parameters): In tty case, update the
6586 default face if necessary (Bug#4238).
6587
da4adb04
CY
65882011-07-21 Chong Yidong <cyd@stupidchicken.com>
6589
6590 * editfns.c (Fstring_to_char): No need to explain what a character
6591 is in the docstring (Bug#6576).
6592
9abd0532
LMI
65932011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6594
6595 * xml.c (parse_region): Make sure we always return a tree.
6596
36881d16
HK
65972011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6598
6599 * xml.c (parse_region): If a document contains only comments,
6600 return that, too.
6601
1e98674d
LMI
66022011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6603
6604 * xml.c (make_dom): Return comments, too.
6605
590bd467
PE
66062011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6607
6608 Port to OpenBSD.
6609 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6610 and the surrounding thread.
6611 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6612 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6613 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6614 timer goes off.
6615 * s/openbsd.h (BROKEN_SIGIO): Define.
6616 * unexelf.c (unexec) [__OpenBSD__]:
6617 Don't update the .mdebug section of the Alpha COFF symbol table.
6618
f41628b2
LMI
66192011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6620
6621 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6622 (bug#8460).
6623
b59b67c5
PE
66242011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6625
15e3a074
PE
6626 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6627 This fixes some race conditions on the permissions of any newly
6628 created file.
6629
41bed37d
PE
6630 * alloc.c (valid_pointer_p): Use pipe, not open.
6631 This fixes some permissions issues when debugging.
6632
b59b67c5
PE
6633 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6634 If fchown fails to set both uid and gid, try to set just gid,
6635 as that is sometimes allowed. Adjust the file's mode to eliminate
6636 setuid or setgid bits that are inappropriate if fchown fails.
6637
925a6be7
SM
66382011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6639
6640 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6641 to compare Lisp_Objects.
6642 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6643 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6644 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6645
52968808
AS
66462011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6647
0a6a104b
AS
6648 * lread.c (read_integer): Unread even EOF character.
6649 (read1): Likewise. Properly record start position of symbol.
6650
52968808
AS
6651 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6652 symbol character follows.
6653
9e381cdd
PE
66542011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6655
6656 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6657 This works around a problem with the previous change to Fcopy_file.
6658 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6659 and without this change, GCC might complain about discarding
6660 fchown's return value.
6661
b5641435
JB
66622011-07-16 Juanma Barranquero <lekktu@gmail.com>
6663
6664 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6665
a8031457
PE
66662011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6667
6668 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6669
dd889327
LMI
66702011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6671
750c33f7
LMI
6672 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6673 it's used from the C level.
6674
dd889327
LMI
6675 * process.c: Use the same condition for POLL_FOR_INPUT in both
6676 keyboard.c and process.c (bug#1858).
6677
87e86684
LM
66782011-07-09 Lawrence Mitchell <wence@gmx.li>
6679
6680 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6681 (Fgnutls_boot): Use it.
6682
64348f40
AS
66832011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6684
6685 * doc.c (Fsubstitute_command_keys): Revert last change.
6686
1d698799
LMI
66872011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6688
f863868c
LMI
6689 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6690 quotes the next character, and doesn't affect other longer
6691 sequences (bug#8935).
6692
1d698799
LMI
6693 * lread.c (syms_of_lread): Clarify that is isn't only
6694 `eval-buffer' and `eval-defun' that's affected by
6695 `lexical-binding' (bug#8460).
6696
aa4b6df6
EZ
66972011-07-15 Eli Zaretskii <eliz@gnu.org>
6698
6699 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6700 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6701
5d856da6
PE
67022011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6703
ad6042bb
PE
6704 Fix minor problems found by static checking.
6705 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6706 (elsz): Now a signed constant, not a size_t var. We prefer signed
6707 types to unsigned, to avoid integer comparison confusion. Without
6708 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6709 "cannot optimize loop, the loop counter may overflow", a symptom
6710 of the confusion.
f00bbb22 6711 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6712 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6713
6468f31c
LMI
67142011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6715
49080b10
LMI
6716 * search.c (Fre_search_backward): Mention `case-fold-search' in
6717 all the re_search_* functions (bug#8138).
6718
6468f31c
LMI
6719 * keyboard.c (Fopen_dribble_file): Document when the file is
6720 closed (bug#8056).
6721
c965adc5
EZ
67222011-07-14 Eli Zaretskii <eliz@gnu.org>
6723
df9733bf
EZ
6724 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6725 bidi_cache_idx.
6726
0bb23927
EZ
6727 Support bidi reordering of display and overlay strings.
6728 * xdisp.c (compute_display_string_pos)
6729 (compute_display_string_end): Accept additional argument STRING.
6730 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6731 (reseat_to_string): Initialize bidi_it->string.s and
6732 bidi_it->string.schars.
6733 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6734 NULL (avoids a crash in bidi_paragraph_init).
6735 Initialize itb.string.lstring.
0bb23927
EZ
6736 (init_iterator): Call bidi_init_it only of a valid
6737 buffer position was specified. Initialize paragraph_embedding to
6738 L2R.
6739 (reseat_to_string): Initialize the bidi iterator.
6740 (display_string): If we need to ignore text properties of
6741 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6742 original value of -1 will not work with bidi.)
6743 (compute_display_string_pos): First arg is now struct
6744 `text_pos *'; all callers changed. Support display properties on
6745 Lisp strings.
6746 (compute_display_string_end): Support display properties on Lisp
6747 strings.
6748 (init_iterator, reseat_1, reseat_to_string): Initialize the
6749 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6750 when iterating on a string not from display properties).
640c8776
SM
6751 (compute_display_string_pos, compute_display_string_end):
6752 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6753 arrow keys.
6754 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6755 base_level_stop; instead, set base_level_stop to BEGV.
6756 Fixes crashes in vertical-motion.
0bb23927
EZ
6757 (next_element_from_buffer): Improve commentary for when
6758 the iterator is before prev_stop.
6759 (init_iterator): Initialize bidi_p from the default value of
6760 bidi-display-reordering, not from buffer-local value. Use the
6761 buffer-local value only if initializing for buffer iteration.
6762 (handle_invisible_prop): Support invisible properties on strings
6763 that are being bidi-reordered.
6764 (set_iterator_to_next): Support bidi reordering of C strings and
6765 Lisp strings.
6766 (next_element_from_string): Support bidi reordering of Lisp
6767 strings.
6768 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6769 (display_string): Support display of R2L glyph rows.
6770 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6771 (init_iterator): Don't initialize it->bidi_p for strings
6772 here.
6773 (reseat_to_string): Initialize it->bidi_p for strings here.
6774 (next_element_from_string, next_element_from_c_string)
6775 (next_element_from_buffer): Add xassert's for correspondence
6776 between IT's object being iterated and it->bidi_it.string
6777 structure.
6778 (face_before_or_after_it_pos): Support bidi iteration.
6779 (next_element_from_c_string): Handle the case of the first string
6780 character that is not the first one in the visual order.
6781 (get_visually_first_element): New function, refactored from common
6782 parts of next_element_from_buffer, next_element_from_string, and
6783 next_element_from_c_string.
6784 (tool_bar_lines_needed, redisplay_tool_bar)
6785 (display_menu_bar): Force left-to-right direction. Add a FIXME
6786 comment for making that be controlled by a user option.
6787 (push_it, pop_it): Save and restore the state of the
6788 bidi iterator. Save and restore the bidi_p flag.
6789 (pop_it): Iterate out of display property for string iteration as
6790 well.
6791 (iterate_out_of_display_property): Support iteration over strings.
6792 (handle_single_display_spec): Set up it->bidi_it for iteration
6793 over a display string, and call bidi_init_it.
6794 (handle_single_display_spec, next_overlay_string)
6795 (get_overlay_strings_1, push_display_prop): Set up the bidi
6796 iterator for displaying display or overlay strings.
6797 (forward_to_next_line_start): Don't use the shortcut if
6798 bidi-iterating.
6799 (back_to_previous_visible_line_start): If handle_display_prop
6800 pushed the iterator stack, restore the internal state of the bidi
6801 iterator by calling bidi_pop_it same number of times.
6802 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6803 and we are bidi-iterating, don't decrement the iterator position;
6804 instead, set the first_elt flag in the bidi iterator, to produce
6805 the same effect.
6806 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6807 (push_display_prop): xassert that we are iterating a buffer.
6808 (push_it, pop_it): Save and restore paragraph_embedding member.
6809 (handle_single_display_spec, next_overlay_string)
6810 (get_overlay_strings_1, reseat_1, reseat_to_string)
6811 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6812 correctly. Don't assume unibyte strings are not bidi-reordered.
6813 (compute_display_string_pos)
6814 (compute_display_string_end): Fix handling the case of C string.
6815 (push_it, pop_it): Save and restore from_disp_prop_p.
6816 (handle_single_display_spec, push_display_prop): Set the
6817 from_disp_prop_p flag.
6818 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6819 (pop_it): Call iterate_out_of_display_property only if we are
6820 popping after iteration over a string that came from a display
6821 property. Fix a typo in popping stretch info. Add an assertion
6822 for verifying that the iterator position is in sync with the bidi
6823 iterator.
6824 (handle_single_display_spec, get_overlay_strings_1)
6825 (push_display_prop): Fix initialization of paragraph direction for
6826 string when that of the parent object is not yet determined.
6827 (reseat_1): Call bidi_init_it to resync the bidi
6828 iterator with IT's position. (Bug#7616)
6829 (find_row_edges): If ROW->start.pos gives position
6830 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6831 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6832 Reset the from_disp_prop_p flag.
6833 (SAVE_IT, RESTORE_IT): New macros.
6834 (pos_visible_p, face_before_or_after_it_pos)
6835 (back_to_previous_visible_line_start)
6836 (move_it_in_display_line_to, move_it_in_display_line)
6837 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6838 (try_scrolling, redisplay_window, display_line): Use them when
6839 saving a temporary copy of the iterator and restoring it back.
6840 (back_to_previous_visible_line_start, reseat_1)
6841 (init_iterator): Empty the bidi cache "stack".
6842 (move_it_in_display_line_to): If iterator ended up at
6843 EOL, but we never saw any buffer positions smaller than
6844 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6845 motion in bidi-reordered lines.
6846 (move_it_in_display_line_to): Record prev_method and prev_pos
6847 immediately before the call to set_iterator_to_next. Fixes cursor
6848 motion in bidi-reordered lines with stretch glyphs and strings
6849 displayed in margins. (Bug#8133) (Bug#8867)
6850 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6851 TO_CHARPOS.
640c8776
SM
6852 (pos_visible_p): Support positions in bidi-reordered lines.
6853 Save and restore bidi cache.
0bb23927
EZ
6854
6855 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6856 (bidi_paragraph_info): Delete unused struct.
6857 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6858 (bidi_cache_start): New variable.
6859 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6860 to zero.
6861 (bidi_cache_fetch_state, bidi_cache_search)
6862 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6863 (bidi_cache_find, bidi_peek_at_next_level)
6864 (bidi_level_of_next_char, bidi_find_other_level_edge)
6865 (bidi_move_to_visually_next): Compare cache index with
6866 bidi_cache_start rather than with zero.
6867 (bidi_fetch_char): Accept new argument STRING; all callers
6868 changed. Support iteration over a string. Support strings with
6869 display properties. Support unibyte strings. Fix the type of
6870 `len' according to what STRING_CHAR_AND_LENGTH expects.
6871 (bidi_paragraph_init, bidi_resolve_explicit_1)
6872 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6873 (bidi_level_of_next_char, bidi_move_to_visually_next):
6874 Support iteration over a string.
0bb23927
EZ
6875 (bidi_set_sor_type, bidi_resolve_explicit_1)
6876 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6877 can now be zero (for strings); special values 0 and -1 were
6878 changed to -1 and -2, respectively.
6879 (bidi_char_at_pos): New function.
6880 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6881 Call it instead of FETCH_MULTIBYTE_CHAR.
6882 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6883 initialized to valid values.
6884 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6885 values.
6886 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6887 the test for valid cached positions. Fix the logic for looking up
6888 the sentinel state in the cache. GCPRO the Lisp string we are
6889 iterating.
6890 (bidi_push_it, bidi_pop_it): New functions.
6891 (bidi_initialize): Initialize the bidi cache start stack pointer.
6892 (bidi_cache_ensure_space): New function, refactored from part of
6893 bidi_cache_iterator_state. Don't assume the required size is just
6894 one BIDI_CACHE_CHUNK away.
6895 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6896 (bidi_count_bytes, bidi_char_at_pos): New functions.
6897 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6898 always valid if bidi_cache_idx is valid.
6899 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6900 is valid if it's going to be used.
6901 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6902 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6903 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6904 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6905 (bidi_find_other_level_edge, bidi_cache_start_stack):
6906 All variables related to cache indices are now EMACS_INT.
c965adc5 6907
0bb23927
EZ
6908 * dispextern.h (struct bidi_string_data): New structure.
6909 (struct bidi_it): New member `string'. Make flag members be 1-bit
6910 fields, and put them last in the struct.
640c8776
SM
6911 (compute_display_string_pos, compute_display_string_end):
6912 Update prototypes.
0bb23927
EZ
6913 (bidi_push_it, bidi_pop_it): Add prototypes.
6914 (struct iterator_stack_entry): New members bidi_p,
6915 paragraph_embedding, and from_disp_prop_p.
6916 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6917 (bidi_shelve_cache, bidi_unshelve_cache):
6918 Declare prototypes.
0bb23927
EZ
6919
6920 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6921 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6922 and vector-like objects.
6923
6924 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6925 cache around display iteration.
6926
6927 * window.c (Fwindow_end, window_scroll_pixel_based)
6928 (displayed_window_lines, Frecenter): Save and restore the bidi
6929 cache around display iteration.
6930
3bbd2265
LMI
69312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6932
6933 * editfns.c (Fdelete_region): Clarify the use of the named
6934 parameters (bug#6788).
6935
adc47434
MR
69362011-07-14 Martin Rudalics <rudalics@gmx.at>
6937
6938 * indent.c (Fvertical_motion): Set and restore w->pointm when
6939 saving and restoring the window's buffer (Bug#9006).
6940
837c31f8
LMI
69412011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6942
6943 * editfns.c (Fstring_to_char): Clarify just what is returned
6944 (bug#6576). Text by Eli Zaretskii.
6945
ac389d0c
JB
69462011-07-13 Juanma Barranquero <lekktu@gmail.com>
6947
6948 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6949
0be0ce47
EZ
69502011-07-13 Eli Zaretskii <eliz@gnu.org>
6951
6952 * buffer.c (mmap_find): Fix a typo.
6953
cd18e7e3
JB
69542011-07-13 Johan Bockgård <bojohan@gnu.org>
6955
6956 Fix execution of x selection hooks.
6957 * xselect.c (Qx_lost_selection_functions)
6958 (Qx_sent_selection_functions): New vars.
6959 (syms_of_xselect): DEFSYM them.
6960 (x_handle_selection_request): Pass Qx_sent_selection_functions
6961 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6962 (x_handle_selection_clear,x_clear_frame_selections):
6963 Pass Qx_lost_selection_functions rather than
6964 Vx_lost_selection_functions to Frun_hook_with_args.
6965
47ea7f44
PE
69662011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6967
ac389d0c 6968 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6969 The old code sometimes used this field without initializing it.
6970
47ea7f44
PE
6971 * alloc.c (gc_sweep): Don't read past end of array.
6972 In theory, the old code could also have corrupted Emacs internals,
6973 though it'd be very unlikely.
6974
bc985c87
AS
69752011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6976
6977 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6978 argument. (Bug#4026)
bc985c87 6979
0cf34688
LMI
69802011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6981
b3dadd76
LMI
6982 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6983 key" (bug#4257).
6984
0cf34688
LMI
6985 * window.c (Fset_window_start): Doc fix (bug#4199).
6986 (Fset_window_hscroll): Ditto.
6987
270768cd
PE
69882011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6989
077e3dda 6990 Fix minor new problems caught by GCC 4.6.1.
270768cd 6991 * term.c (init_tty): Remove unused local.
490011a6 6992 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6993 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6994 not used otherwise.
270768cd 6995
b1f58454
CY
69962011-07-12 Chong Yidong <cyd@stupidchicken.com>
6997
6998 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6999
22b9578d
LMI
70002011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7001
6e70ab07
LMI
7002 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7003 are the mini-buffer and the echo area (bug#3320).
7004
22b9578d
LMI
7005 * term.c (init_tty): Remove support for supdup, c10 and perq
7006 terminals, which are no longer supported (bug#1482).
7007
8974cc9f
JB
70082011-07-10 Johan Bockgård <bojohan@gnu.org>
7009
7010 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7011
a560d974
JD
70122011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7013
7014 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7015 for non-popups (Bug#3642).
7016
1dae0f0a
AS
70172011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7018
268c2c36 7019 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7020 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7021 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7022 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7023 * data.c (fmod): Likewise.
7024 * dispnew.c (swap_glyphs_in_rows): Likewise.
7025 * emacs.c (memory_warning_signal): Likewise.
7026 * floatfns.c (float_error): Likewise.
7027 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7028 (otf_open, font_otf_capability, generate_otf_features)
7029 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7030 Likewise.
7031 * image.c (pbm_read_file): Likewise.
7032 * indent.c (string_display_width): Likewise.
7033 * intervals.c (check_for_interval, search_for_interval)
7034 (inc_interval_count, count_intervals, root_interval)
7035 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7036 * lread.c (defalias): Likewise.
268c2c36 7037 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7038 * regex.c (set_image_of_range_1, set_image_of_range)
7039 (regex_grow_registers): Likewise.
7040 * sysdep.c (strerror): Likewise.
7041 * termcap.c (valid_filename_p, tprint, main): Likewise.
7042 * tparam.c (main): Likewise.
7043 * unexhp9k800.c (run_time_remap, save_data_space)
7044 (update_file_ptrs, read_header, write_header, calculate_checksum)
7045 (copy_file, copy_rest, display_header): Likewise.
7046 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7047 Likewise.
7048 * xdisp.c (check_it): Likewise.
7049 * xfaces.c (register_color, unregister_color, unregister_colors):
7050 Likewise.
7051 * xfns.c (print_fontset_result): Likewise.
7052 * xrdb.c (member, fatal, main): Likewise.
7053
99033785
PE
70542011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7055
7056 Fix minor problems found by static checking (Bug#9031).
7057 * chartab.c (char_table_set_range, map_sub_char_table):
7058 Remove unused locals.
7059 (uniprop_table): Now static.
7060 * composite.c (_work_char): Remove unused static var.
7061
9cb2ac56
JB
70622011-07-09 Juanma Barranquero <lekktu@gmail.com>
7063
7064 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7065
f25661f0
JD
70662011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7067
7068 * gtkutil.c (qttip_cb): Remove code without function.
7069
8278c4fe
EZ
70702011-07-09 Eli Zaretskii <eliz@gnu.org>
7071
7072 * w32.c (pthread_sigmask): New stub.
7073
1692ae2d 70742011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7075
8a6ebd58 7076 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7077 sigprocmask is portable only for single-threaded applications, and
7078 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7079 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7080 (LIBES): Use it.
7081 * callproc.c (Fcall_process):
7082 * process.c (create_process):
7083 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7084 Use pthread_sigmask, not sigprocmask.
123403e4 7085
1b854618
JD
70862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7087
7088 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7089 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7090 wrong (Bug#8591).
7091
3fe4b549
JD
70922011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7093
0ce7e563
JD
7094 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7095 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7096 (xg_hide_tooltip): Fix comment.
7097
3fe4b549
JD
7098 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7099 in registerServicesMenuSendTypes.
7100 (validRequestorForSendType): Don't check ns_return_types.
7101
7102 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7103 ns_return_type.
7104
5df75e47
JR
71052011-07-08 Jason Rumney <jasonr@gnu.org>
7106
22610910
JR
7107 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7108 SH_SHOW for hidden windows (Bug#5482).
7109
5df75e47
JR
7110 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7111 frame struct members of non-existent frames (Bug#6284).
7112
699c10bd
JD
71132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7114
4393663b
JD
7115 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7116 variable firstTime not needed on OSX >= 10.6.
7117 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7118 >= 10.5. Use setKnobProportion, setDoubleValue.
7119
7120 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7121 (MAC_OS_X_VERSION_10_5): Define if not defined.
7122 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7123 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7124 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7125
7126 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7127 cString and lossyCString on OSX >= 10.4
7128
58179cce 7129 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7130 sizeToFit on OSX >= 10.2.
7131
7132 * nsimage.m (allocInitFromFile): Don't use deprecated method
7133 bestRepresentationForDevice on OSX >= 10.6.
7134
7135 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7136 to avoid warning.
7137
7138 * emacs.c: Declare unexec_init_emacs_zone.
7139
a63e0781
JD
7140 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7141
699c10bd
JD
7142 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7143
7144 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7145 on svcsMenu (Bug#8842).
7146
7147 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7148 ns_return_types.
7149 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7150
7151 * nsterm.m (QUTF8_STRING): Declare.
7152 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7153 (validRequestorForSendType): Return type is (id).
7154 Change indexOfObjectIdenticalTo to indexOfObject.
7155 Check if we have local selection before returning self (Bug#8842).
7156 (writeSelectionToPasteboard): Put local selection into paste board
7157 if we have a local selection (Bug#8842).
7158 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7159
7160 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7161 (ns_get_local_selection): Declare.
7162
54e10184
LMI
71632011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7164
9888ff71
LMI
7165 * keymap.c (describe_map_tree): Don't insert a double newline at
7166 the end of the buffer (bug#1169) and return whether we inserted
7167 something.
7168
54e10184
LMI
7169 * callint.c (Fcall_interactively): Change "reading args" to
7170 "providing args" to try to clarify what it does (bug#1010).
7171
15fa4783
KH
71722011-07-07 Kenichi Handa <handa@m17n.org>
7173
7174 * composite.c (composition_compute_stop_pos): Ignore a static
7175 composition starting before CHARPOS (Bug#8915).
7176
7177 * xdisp.c (handle_composition_prop): Likewise.
7178
a8815b00
EZ
71792011-07-07 Eli Zaretskii <eliz@gnu.org>
7180
7181 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7182 (Bug#9015)
7183
ef7b981d 71842011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7185
7186 * character.h (unicode_category_t): New enum type.
7187
7188 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7189 (Qchar_code_property_table): New variable.
7190 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7191 (UNIPROP_COMPRESSED_FORM_P): New macros.
7192 (char_table_ascii): Uncompress the compressed values.
7193 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7194 Uncompress the compressed values.
ac389d0c 7195 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7196 (char_table_ref_and_range): Uncompress the compressed values.
7197 (sub_char_table_set): New arg is_uniprop. Callers changed.
7198 Uncompress the compressed values.
7199 (sub_char_table_set_range): Args changed. Callers changed.
7200 (char_table_set_range): Adjuted for the above change.
7201 (map_sub_char_table): Delete args default_val and parent. Add arg
7202 top. Give decoded values to a Lisp function.
640c8776 7203 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7204 values to a Lisp function. Gcpro more variables.
7205 (uniprop_table_uncompress)
7206 (uniprop_decode_value_run_length): New functions.
7207 (uniprop_decoder, uniprop_decoder_count): New variables.
7208 (uniprop_get_decoder, uniprop_encode_value_character)
7209 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7210 New functions.
7211 (uniprop_encoder, uniprop_encoder_count): New variables.
7212 (uniprop_get_encoder, uniprop_table)
7213 (Funicode_property_table_internal, Fget_unicode_property_internal)
7214 (Fput_unicode_property_internal): New functions.
7215 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7216 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7217 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7218 char-code-property-alist.
7219
640c8776 7220 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7221 Vunicode_category_table.
7222
640c8776 7223 * font.c (font_range): Adjust for the change of
c805dec0
KH
7224 Vunicode_category_table.
7225
76b397fb
DN
72262011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7227
7228 * m/iris4d.h: Remove file, move contents ...
7229 * s/irix6-5.h: ... here.
7230
22b4128e
PE
72312011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7232
7233 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7234 * alloc.c (mark_buffer):
7235 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7236 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7237 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7238 This isn't true in general, and it's particularly not true
7239 if Emacs is configured with --with-wide-int.
7240 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7241 New macros, used in the buffer.c change.
7242
869795d6
JD
72432011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7244
7245 * xsettings.c: Use both GConf and GSettings if both are available.
7246 (store_config_changed_event): Add comment.
7247 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7248 (store_tool_bar_style_changed): New functions.
5e617bc2 7249 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7250 (struct xsettings): Move font inside HAVE_XFT.
7251 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7252 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7253 Move inside HAVE_XFT.
640c8776 7254 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7255 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7256 also.
7257 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7258 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7259 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7260 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7261 (parse_settings): Move check for font inside HAVE_XFT.
7262 (read_settings, apply_xft_settings): Add comment.
7263 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7264 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7265 call store_font_name_changed.
7266 (xft_settings_event): Add comment.
7267 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7268 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7269 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7270 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7271 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7272 (xsettings_get_system_font, xsettings_get_system_normal_font):
7273 Add comment.
869795d6 7274
d8ed26bd
PE
72752011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7276
7277 Random fixes. E.g., (random) never returned negative values.
7278 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7279 subseconds part to the entropy, as that's a bit more random.
7280 Prefer signed to unsigned, since the signedness doesn't matter and
7281 in general we prefer signed. When given a limit, use a
7282 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7283 latter isn't right if USE_2_TAGS_FOR_INTS.
7284 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7285 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7286
cabf1cac
SM
72872011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7288
7289 * textprop.c (text_property_stickiness):
7290 Obey Vtext_property_default_nonsticky.
7291 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7292 * w32fns.c (syms_of_w32fns):
7293 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7294
6e9b2be9
PE
72952011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7296
7297 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7298 This is more efficient than Ffile_directory_p and avoids a minor race.
7299
90186c68
LMI
73002011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7301
7c301272
LMI
7302 * buffer.c (Foverlay_put): Say what the return value is
7303 (bug#7835).
7304
c4f2d8d4
LMI
7305 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7306 is a directory before asking whether to use the file name
7307 (bug#7564).
ad637907
LMI
7308 (barf_or_query_if_file_exists): Make the "File is a directory"
7309 error be more correct.
c4f2d8d4 7310
90186c68
LMI
7311 * fns.c (Frequire): Remove the mention of the .gz files, since
7312 that's installation-specific, but keep the mention of
7313 `get-load-suffixes'.
7314
da64016e
PE
73152011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7316
7317 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7318 Report string overflow if the output is too long.
7319
7d47b580
JB
73202011-07-04 Juanma Barranquero <lekktu@gmail.com>
7321
a555cb87
JB
7322 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7323 (syms_of_gnutls): Remove duplicate DEFSYM for
7324 Qgnutls_bootprop_verify_hostname_error, an error for
7325 Qgnutls_bootprop_verify_error (which is no longer used).
7326
7d47b580
JB
7327 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7328 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7329 Also (re)move comments that are misplaced or no longer relevant.
7330
1e49bfab
LMI
73312011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7332
7333 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7334
1485f4c0
CY
73352011-07-03 Chong Yidong <cyd@stupidchicken.com>
7336
7337 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7338 and background color parameters if they have been changed.
7339
a9ab721e
LMI
73402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7341
7342 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7343
cf7cff57
PE
73442011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7345
2e13213d
PE
7346 * xsettings.c (SYSTEM_FONT): Define only when used.
7347 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7348
cf7cff57
PE
7349 * keymap.c (access_keymap_1): Now static.
7350
7a8e04f7
CY
73512011-07-02 Chong Yidong <cyd@stupidchicken.com>
7352
7353 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7354 leave any prefix arg for the up event (Bug#1586).
7355
61352f62
LMI
73562011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7357
69bb1ef7
LMI
7358 * lread.c (syms_of_lread): Mention single symbols defined by
7359 `defvar' or `defconst' (bug#7154).
7360
61352f62 7361 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7362 (Frequire): Mention get-load-suffixes.
61352f62 7363
28545e04
MR
73642011-07-02 Martin Rudalics <rudalics@gmx.at>
7365
7366 * window.h (window): Remove clone_number slot.
7367 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7368 Remove.
7369 (make_parent_window, make_window, saved_window)
7370 (Fset_window_configuration, save_window_save): Don't deal with
7371 clone numbers.
7372 * buffer.c (Qclone_number): Remove declaration.
7373 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7374
3349e122
SM
73752011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7376
7377 Add multiple inheritance to keymaps.
7378 * keymap.c (Fmake_composed_keymap): New function.
7379 (Fset_keymap_parent): Simplify.
7380 (fix_submap_inheritance): Remove.
7381 (access_keymap_1): New function extracted from access_keymap to handle
7382 embedded parents and handle lists of maps.
7383 (access_keymap): Use it.
7384 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7385 (Fcopy_keymap): Handle embedded parents.
7386 (Fcommand_remapping, define_as_prefix): Simplify.
7387 (Fkey_binding): Simplify.
7388 (syms_of_keymap): Move minibuffer-local-completion-map,
7389 minibuffer-local-filename-completion-map,
7390 minibuffer-local-must-match-map, and
7391 minibuffer-local-filename-must-match-map to Elisp.
7392 (syms_of_keymap): Defsubr make-composed-keymap.
7393 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7394 (parse_menu_item): Trivial simplification.
7395
3279eb87
GM
73962011-07-01 Glenn Morris <rgm@gnu.org>
7397
7398 * Makefile.in (SETTINGS_LIBS): Fix typo.
7399
4550efdf
KI
74002011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7401
7402 * coding.c (Fencode_coding_string): Record the last coding system
7403 used, as the function doc string says (bug#8738).
7404
0949d2b6
JD
74052011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7406
7407 * xsettings.c (store_monospaced_changed): Take new font as arg and
7408 check for change against current_mono_font.
7409 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7410 (emacs_settings_constructor, emacs_settings_get_property)
7411 (emacs_settings_set_property, emacs_settings_class_init)
7412 (emacs_settings_init, gsettings_obj): Remove.
7413 (something_changedCB): New function for HAVE_GSETTINGS.
7414 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7415 with value as argument.
7416 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7417 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7418 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7419 "changed".
7420
7421 * xgselect.c: Add defined (HAVE_GSETTINGS).
7422 (xgselect_initialize): Ditto.
7423
7424 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7425 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7426 xg_select.
7427
bbc6b304
PE
74282011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7429
7430 * eval.c (struct backtrace): Simplify and port the data structure.
7431 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7432 signed bit field, as this assumption is not portable and it makes
7433 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7434 "char debug_on_exit : 1" as this is not portable either; instead,
7435 use the portable "unsigned int debug_on_exit : 1". Remove unused
7436 member evalargs. Remove obsolete comments about cc bombing out.
7437
9851bfc5
JD
74382011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7439
51bb811f 7440 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7441 Let HAVE_GSETTINGS override HAVE_GCONF.
7442 (store_monospaced_changed): New function.
7443 (EMACS_SETTINGS): A new type derived from GObject to handle
7444 GSettings notifications.
7445 (emacs_settings_constructor, emacs_settings_get_property)
7446 (emacs_settings_set_property, emacs_settings_class_init):
7447 New functions.
7448 (gsettings_client, gsettings_obj): New variables.
7449 (GSETTINGS_SCHEMA): New define.
7450 (something_changedCB): Call store_monospaced_changed.
7451 (init_gsettings): New function.
7452 (xsettings_initialize): Call init_gsettings.
7453 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7454 to NULL.
7455
640c8776 7456 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7457 GCONF_CFLAGS/LIBS.
7458
5386012d
MR
74592011-06-29 Martin Rudalics <rudalics@gmx.at>
7460
7461 * window.c (resize_root_window, grow_mini_window)
7462 (shrink_mini_window): Rename Qresize_root_window to
7463 Qwindow_resize_root_window and Qresize_root_window_vertically to
7464 Qwindow_resize_root_window_vertically.
7465
f13e0b08
PE
74662011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7467
7468 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7469
94515237
JB
74702011-06-27 Juanma Barranquero <lekktu@gmail.com>
7471
7472 * makefile.w32-in: Redesign dependencies so they reflect more
7473 clearly which files are directly included by each source file,
7474 and not through other includes.
7475
e43b6e43
MR
74762011-06-27 Martin Rudalics <rudalics@gmx.at>
7477
7478 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7479 (sort_overlays, overlay_strings): When an overlay's clone number
7480 matches the window's clone number process the overlay even if
7481 the overlay's window property doesn't match the current window.
7482
d68443dc
MR
7483 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7484 (Fwindow_hchild): Rename to Fwindow_left_child.
7485 (Fwindow_next): Rename to Fwindow_next_sibling.
7486 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7487 (resize_window_check): Rename to window_resize_check.
7488 (resize_window_apply): Rename to window_resize_apply.
7489 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7490 (Fdelete_other_windows_internal, resize_frame_windows)
7491 (Fsplit_window_internal, Fdelete_window_internal)
7492 (grow_mini_window, shrink_mini_window)
7493 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7494
c7e73be5
JD
74952011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7496
7497 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7498 (emacs_fixed_set_min_size): Remove.
7499 (emacs_fixed_new): Take frame as argument.
7500
7501 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7502 (_EmacsFixedPrivate): Remove minwidth/height.
7503 Add struct frame *f.
7504 (emacs_fixed_init): Initialize priv->f.
7505 (get_parent_class, emacs_fixed_set_min_size): Remove.
7506 (emacs_fixed_new): Set priv->f to argument.
7507 (emacs_fixed_get_preferred_width)
7508 (emacs_fixed_get_preferred_height): Use min_width/height from
7509 frames size_hint to set minimum and natural (Bug#8919).
7510 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7511 and use min_width/height from frames size_hint to set
7512 min_width/height (Bug#8919).
7513
7514 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7515 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7516 Fix indentation.
c7e73be5 7517
cf99dcf8
EZ
75182011-06-26 Eli Zaretskii <eliz@gnu.org>
7519
7520 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7521 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7522 called at ZV.
7523
029529ac
CY
75242011-06-26 Chong Yidong <cyd@stupidchicken.com>
7525
7526 * process.c (wait_reading_process_output): Bypass select if
7527 waiting for a cell while ignoring keyboard input, and input is
7528 pending. Suggested by Jan Djärv (Bug#8869).
7529
7a7ef429
PE
75302011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7531
7532 Use gnulib's dup2 module instead of rolling our own.
7533 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7534
11fdef7d 75352011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7536
7537 * dispnew.c (scrolling_window): Before scrolling, turn off a
7538 mouse-highlight in the window being scrolled.
7539
cd3520a4
JB
75402011-06-24 Juanma Barranquero <lekktu@gmail.com>
7541
7542 Move DEFSYM to lisp.h and use everywhere.
7543
7544 * character.h (DEFSYM): Move declaration...
7545 * lisp.h (DEFSYM): ...here.
7546
7547 * gnutls.c:
7548 * minibuf.c:
7549 * w32menu.c:
7550 * w32proc.c:
7551 * w32select.c: Don't include character.h.
7552
7553 * alloc.c (syms_of_alloc):
7554 * buffer.c (syms_of_buffer):
7555 * bytecode.c (syms_of_bytecode):
7556 * callint.c (syms_of_callint):
7557 * casefiddle.c (syms_of_casefiddle):
7558 * casetab.c (init_casetab_once):
7559 * category.c (init_category_once, syms_of_category):
7560 * ccl.c (syms_of_ccl):
7561 * cmds.c (syms_of_cmds):
7562 * composite.c (syms_of_composite):
7563 * dbusbind.c (syms_of_dbusbind):
7564 * dired.c (syms_of_dired):
7565 * dispnew.c (syms_of_display):
7566 * doc.c (syms_of_doc):
7567 * editfns.c (syms_of_editfns):
7568 * emacs.c (syms_of_emacs):
7569 * eval.c (syms_of_eval):
7570 * fileio.c (syms_of_fileio):
7571 * fns.c (syms_of_fns):
7572 * frame.c (syms_of_frame):
7573 * fringe.c (syms_of_fringe):
7574 * insdel.c (syms_of_insdel):
7575 * keymap.c (syms_of_keymap):
7576 * lread.c (init_obarray, syms_of_lread):
7577 * macros.c (syms_of_macros):
7578 * msdos.c (syms_of_msdos):
7579 * print.c (syms_of_print):
7580 * process.c (syms_of_process):
7581 * search.c (syms_of_search):
7582 * sound.c (syms_of_sound):
7583 * syntax.c (init_syntax_once, syms_of_syntax):
7584 * terminal.c (syms_of_terminal):
7585 * textprop.c (syms_of_textprop):
7586 * undo.c (syms_of_undo):
7587 * w32.c (globals_of_w32):
7588 * window.c (syms_of_window):
7589 * xdisp.c (syms_of_xdisp):
7590 * xfaces.c (syms_of_xfaces):
7591 * xfns.c (syms_of_xfns):
7592 * xmenu.c (syms_of_xmenu):
7593 * xsettings.c (syms_of_xsettings):
7594 * xterm.c (syms_of_xterm): Use DEFSYM.
7595
4228cf16
TZ
75962011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7597
cd3520a4 7598 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7599
7fcccf1e
PE
76002011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7601
7efb4e0e
PE
7602 Integer and buffer overflow fixes (Bug#8873).
7603
ff5844ad
PE
7604 * print.c (printchar, strout): Check for string overflow.
7605 (PRINTPREPARE, printchar, strout):
7606 Don't set size unless allocation succeeds.
7607
90532f02
PE
7608 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7609 for sizes. Check for string overflow more accurately.
7610 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7611
6d84508d
PE
7612 * macros.c: Integer and buffer overflow fixes.
7613 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7614 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7615 Use ptrdiff_t, not int, for sizes.
7616 Don't increment bufsize until after realloc succeeds.
7617 Check for size-calculation overflow.
7618 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7619
437b2cb4
PE
7620 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7621
8b9ac8b4
PE
7622 * lread.c: Integer overflow fixes.
7623 (read_integer): Radix is now EMACS_INT, not int,
7624 to improve quality of diagnostics for out-of-range radices.
7625 Calculate buffer size correctly for out-of-range radices.
7626 (read1): Check for integer overflow in radices, and in
7627 read-circle numbers.
82cb60d3
PE
7628 (read_escape): Avoid int overflow.
7629 (Fload, openp, read_buffer_size, read1)
7630 (substitute_object_recurse, read_vector, read_list, map_obarray):
7631 Use ptrdiff_t, not int, for sizes.
7632 (read1): Use EMACS_INT, not int, for sizes.
20270765 7633 Check for size overflow.
8b9ac8b4 7634
7fcccf1e
PE
7635 * image.c (cache_image): Check for size arithmetic overflow.
7636
bfbbd7e7
PE
7637 * lread.c: Integer overflow issues.
7638 (saved_doc_string_size, saved_doc_string_length)
7639 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7640 Now ptrdiff_t, not int.
7641 (read1): Don't assume doc string length fits in int. Check for
7642 out-of-range doc string lengths.
7643 (read_list): Don't assume file position fits in int.
39019e54 7644 (read_escape): Check for hex character overflow.
bfbbd7e7 7645
4e323265
LL
76462011-06-22 Leo Liu <sdl.web@gmail.com>
7647
7648 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7649 Move to minibuffer.el.
7650
85fece3e
PE
76512011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7652
20b84ce9 7653 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7654 The following patches are for when GLYPH_DEBUG && !XASSERT.
7655 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7656 * dispnew.c (flush_stdout):
7657 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7658 Mark as externally visible.
7659 * dispnew.c (check_window_matrix_pointers): Now static.
7660 * dispnew.c (window_to_frame_vpos):
7661 * xfns.c (unwind_create_frame):
7662 * xterm.c (x_check_font): Remove unused local.
7663 * scroll.c (CHECK_BOUNDS):
7664 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7665 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7666 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7667 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7668 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7669 Now static.
7670 (debug_method_add): Use va_list and vsprintf rather than relying
7671 on undefined behavior with wrong number of arguments.
7672 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7673 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7674 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7675 since we're not interested in debugging glyphs with old libraries.
7676 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7677 GCC 4.6.0's static checking.
7678
0766b489
PE
76792011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7680
31fd4b32
PE
7681 Integer overflow and signedness fixes (Bug#8873).
7682 A few related buffer overrun fixes, too.
7683
b79e8648
PE
7684 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7685
0766b489
PE
7686 * dispextern.h (struct face.stipple):
7687 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7688 (x_bitmap_mask, x_allocate_bitmap_record)
7689 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7690 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7691 (x_create_bitmap_from_xpm_data):
7692 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7693 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7694 (.bitmaps_last):
7695 * xfaces.c (load_pixmap):
7696 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7697 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7698 (.bitmaps_last, struct x_output.icon_bitmap):
7699 Use ptrdiff_t, not int, for bitmap indexes.
7700 (x_allocate_bitmap_record): Check for size overflow.
7701 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7702
b081724f
PE
7703 Use ptrdiff_t, not int, for overlay counts.
7704 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7705 * editfns.c (overlays_around, get_pos_property):
7706 * textprop.c (get_char_property_and_overlay):
7707 * xdisp.c (next_overlay_change, note_mouse_highlight):
7708 * xfaces.c (face_at_buffer_position):
21514da7
PE
7709 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7710 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7711 (Fnext_overlay_change, Fprevious_overlay_change)
7712 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7713 Use ptrdiff_t, not int, for sizes.
21514da7 7714 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7715
3de73e5e
PE
7716 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7717
2606c57b
PE
7718 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7719 (x_session_initialize): Do not assume string length fits in int.
7720
aaafe47a
PE
7721 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7722 This is unlikely, but can occur if DPI is outlandish.
7723
2674ddc8 7724 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7725 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7726
28154962
PE
7727 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7728 * xrdb.c (magic_file_p, search_magic_path):
7729 Omit last arg SUFFIX; it was always 0. All callers changed.
7730 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7731
7de51af5
PE
7732 * xfont.c (xfont_match): Avoid need for strlen.
7733
25ed6cc3
PE
7734 * xfns.c: Don't assume strlen fits in int.
7735 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7736
4eab31dd
PE
7737 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7738 not unsigned long, as we prefer signed integers. All callers changed.
7739 Detect integer overflow in repeat count.
7740 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7741 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7742
171e2a58
PE
7743 * termcap.c: Don't assume sizes fit in int and never overflow.
7744 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7745 (gobble_line): Check for size-calculation overflow.
7746
ad39faca 7747 * minibuf.c (Fread_buffer):
6e5bb2dc 7748 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7749 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7750 Don't assume string length fits in int.
7751
52c61c22 7752 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7753 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7754
b5b8c9e5
PE
7755 * font.c: Don't assume string length fits in int.
7756 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7757 Use ptrdiff_t, not int.
ccd6111c
PE
7758 (font_intern_prop): Don't assume string length fits in int.
7759 Don't assume integer property fits in fixnum.
7760 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7761
882f0d81 7762 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7763 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7764 Reformulate so as not to need the command string.
7765 Invoke gzip -cd rather than gunzip, as it's more portable.
7766 (lock_info_type, lock_file_1, lock_file):
7767 Don't assume pid_t and time_t fit in unsigned long.
7768 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7769 (current_lock_owner): Prefer signed type for sizes.
7770 Use memcpy, not strncpy, where memcpy is what is really wanted.
7771 Don't assume (via atoi) that time_t and pid_t fit in int.
7772 Check for time_t and/or pid_t out of range, e.g., via a network share.
7773 Don't alloca where an auto var works fine.
7774
93f4cf88
PE
7775 * fileio.c: Fix some integer overflow issues.
7776 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7777 Don't assume string length fits in int.
7778 (directory_file_name): Don't assume string length fits in long.
7779 (make_temp_name): Don't assume pid fits in int, or that its print
7780 length is less than 20.
7781
f3e92b69
PE
7782 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7783
1bfdaf10
PE
7784 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7785
35016e9a
PE
7786 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7787
3d1e65a1
PE
7788 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7789 We prefer signed integers, even for size calculations.
7790
0b963a93
PE
7791 * emacs.c: Don't assume string length fits in 'int'.
7792 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7793 (main): Don't invoke strlen when not needed.
7794
573f4b54
PE
7795 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7796 (XD_DEBUG_MESSAGE): Don't waste a byte.
7797
989f33ba
PE
7798 * callproc.c (getenv_internal_1, getenv_internal)
7799 (Fgetenv_internal):
965d34eb
PE
7800 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7801
e4d29b33
PE
7802 * lread.c (invalid_syntax): Omit length argument.
7803 All uses changed. This doesn't fix a bug, but it simplifies the
7804 code away from its former Hollerith-constant appearance, and it's
7805 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7806 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7807
eb49b136
PE
7808 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7809 This didn't break anything, but it didn't help either.
7810 It's confusing to put a bogus integer in a place where the actual
7811 value does not matter.
9f62aeb1 7812 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7813 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7814
15375a22
PE
7815 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7816 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7817 implementation.
b61cc01c
PE
7818 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7819 We prefer signed types, and the value cannot exceed the EMACS_INT
7820 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7821 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7822 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7823 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7824
53b2623d
PE
7825 * indent.c (sane_tab_width): New function.
7826 (current_column, scan_for_column, Findent_to, position_indentation)
7827 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7828 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7829
51cab52b 7830 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7831
f2ed8a70
PE
7832 * lisp.h (lint_assume): New macro.
7833 * composite.c (composition_gstring_put_cache):
7834 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7835
abe80cc6
PE
7836 * editfns.c, insdel.c:
7837 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7838
b02c740e
PE
7839 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7840
ebc96716
PE
7841 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7842
b4e50fa0 7843 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7844 Use much-faster test for byte-length change.
311d5d7c 7845 Don't assume string byte-length fits in 'int'.
a4cf38e4 7846 Check that character arg fits in 'int'.
85461888 7847 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7848
c0c1ee9f
PE
7849 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7850
a498d7f4
PE
7851 * fns.c (concat): Catch string overflow earlier.
7852 Do not rely on integer wraparound.
7853
51cab52b
PE
7854 * dispextern.h (struct it.overlay_strings_charpos)
7855 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7856 * xdisp.c (forward_to_next_line_start)
7857 (back_to_previous_visible_line_start)
7858 (reseat_at_next_visible_line_start, next_element_from_buffer):
7859 Don't arbitrarily truncate the value of 'selective' to int.
7860
76031fad
PE
7861 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7862
5eb55db9
PE
7863 * composite.c: Don't truncate sizes to 'int'.
7864 (composition_gstring_p, composition_reseat_it)
7865 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7866 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7867 not EMACS_UINT, for indexes.
5eb55db9 7868
0703a717
PE
7869 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7870
d6202519
PE
7871 * buffer.c: Include <verify.h>.
7872 (struct sortvec.priority, struct sortstr.priority):
8961a454 7873 Now EMACS_INT, not int.
c20998a7 7874 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7875 (struct sortstr.size, record_overlay_string)
7876 (struct sortstrlist.size, struct sortlist.used):
7877 Don't truncate size to int.
7878 (record_overlay_string): Check for size-calculation overflow.
d6202519 7879 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7880
d5a19415
JM
78812011-06-22 Jim Meyering <meyering@redhat.com>
7882
029529ac 7883 Don't leak an XBM-image-sized buffer
d5a19415
JM
7884 * image.c (xbm_load): Free the image buffer after using it.
7885
a9041e6c
PE
78862011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7887
7888 Port to Sun C.
7889 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7890 that Sun C diagnosed.
7891 * fns.c (secure_hash): Fix pointer signedness issue.
7892 * intervals.c (static_offset_intervals): New function.
7893 (offset_intervals): Use it.
7894
7f3f739f
LL
78952011-06-21 Leo Liu <sdl.web@gmail.com>
7896
7897 * deps.mk (fns.o):
7898 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7899 sha512.h.
7900
7901 * fns.c (secure_hash): Rename from crypto_hash_function and change
7902 the first arg to accept symbols.
5b66d427 7903 (Fsecure_hash): New primitive.
7f3f739f
LL
7904 (syms_of_fns): New symbols.
7905
76147d94
DD
79062011-06-20 Deniz Dogan <deniz@dogan.se>
7907
7908 * process.c (Fset_process_buffer): Clarify return value in
7909 docstring.
7910
7d7d0045
CY
79112011-06-18 Chong Yidong <cyd@stupidchicken.com>
7912
7913 * dispnew.c (add_window_display_history): Use BVAR.
7914
7915 * xdisp.c (debug_method_add): Use BVAR.
7916 (check_window_end, dump_glyph_matrix, dump_glyph)
7917 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7918
7919 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7920 Likewise.
7921
7922 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7923 check till after the cache is created in init_frame_faces.
7924
ff2bc410
SM
79252011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7926
7927 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7928
28177add
PE
79292011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7930
dd3482fe
PE
7931 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7932 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7933 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7934
393d71f3 7935 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7936 * fileio.c (Finsert_file_contents):
7937 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7938 Remove the old (too-loose) buffer overflow checks.
7939 They weren't needed, since make_gap checks for buffer overflow.
7940 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7941 The old code merely checked for Emacs fixnum overflow, and relied
7942 on undefined (wraparound) behavior. The new code avoids undefined
7943 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7944
2e6813b0 7945 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7946 Tune. Don't use wider integers than needed. Don't use alloca.
7947 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7948
599a9e4f
PE
7949 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7950
99561444
PE
7951 * insdel.c, lisp.h (buffer_overflow): New function.
7952 (insert_from_buffer_1, replace_range, replace_range_2):
7953 * insdel.c (make_gap_larger):
7954 * editfns.c (Finsert_char):
7955 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7956
28177add
PE
7957 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7958
e69dafad
PE
79592011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7960
4baa020d 7961 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7962
b1c46f02
PE
7963 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7964 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7965
e69dafad
PE
7966 * fileio.c: Don't assume EMACS_INT fits in off_t.
7967 (emacs_lseek): New static function.
7968 (Finsert_file_contents, Fwrite_region): Use it.
7969 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7970
566684ea
PE
7971 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7972
e6966cd6
PE
7973 * fns.c: Don't overflow int when computing a list length.
7974 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7975 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7976 truncation on 64-bit hosts. Check for QUIT every
7977 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7978 faster and is responsive enough.
7979 (Flength): Report an error instead of overflowing an integer.
7980 (Fsafe_length): Return a float if the value is not representable
7981 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7982 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7983 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7984
dd0b0efb
PE
7985 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7986 (header_size, word_size): New constants.
7987 (allocate_vectorlike): Don't check size overflow here.
7988 (allocate_vector): Check it here instead, since this is the only
7989 caller of allocate_vectorlike that could cause overflow.
7990 Check that the new vector's length is representable as a fixnum.
7991
86fe5cfe
PE
7992 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7993 The previous code was bogus. For example, next_almost_prime (32)
7994 returned 39, which is undesirable as it is a multiple of 3; and
7995 next_almost_prime (24) returned 25, which is a multiple of 5 so
7996 why was the code bothering to check for multiples of 7?
7997
80e88859
PE
7998 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7999
4a2f0ad6
PE
8000 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8001
f66c7cf8
PE
8002 Variadic C functions now count arguments with ptrdiff_t.
8003 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8004 Back then I didn't know that the Emacs coding style prefers signed int.
8005 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8006 were being counted with int, which may truncate counts on 64-bit
8007 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8008 * lisp.h (struct Lisp_Subr.function.aMANY)
8009 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8010 Arg counts are now ptrdiff_t, not size_t.
8011 All variadic functions and their callers changed accordingly.
8012 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8013 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8014 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8015 * callint.c (Fcall_interactively): Check arg count for overflow,
8016 to avoid potential buffer overrun. Use signed char, not 'int',
8017 for 'varies' array, so that we needn't bother to check its size
8018 calculation for overflow.
8019 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8020 * eval.c (apply_lambda):
8021 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8022 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8023 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8024
a1759b76
PE
8025 * callint.c (Fcall_interactively): Don't use index var as event count.
8026
d96be9fc
PE
8027 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8028 * mem-limits.h (SIZE): Remove; no longer used.
8029
a690a978 8030 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8031
578c21e6
PE
8032 Remove unnecessary casts.
8033 * xterm.c (x_term_init):
8034 * xfns.c (x_set_border_pixel):
8035 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8036 These aren't needed now that we assume ANSI C.
8037
96f53c6c
PE
8038 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8039 It's more likely to cause problems (due to unsigned overflow)
8040 than to cure them.
8041
83c77d31
PE
8042 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8043
ee2079f1
PE
8044 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8045
6da65536
PE
8046 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8047
7147c4a4
PE
8048 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8049
193e32d9
PE
8050 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8051
e5533da6
PE
8052 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8053
9910e595
PE
8054 GLYPH_CODE_FACE returns EMACS_INT, not int.
8055 * dispextern.h (merge_faces):
8056 * xfaces.c (merge_faces):
01103c44
PE
8057 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8058 Don't assume EMACS_INT fits in int.
9910e595 8059
2638320e
PE
8060 * character.h (CHAR_VALID_P): Remove unused parameter.
8061 * fontset.c, lisp.h, xdisp.c: All uses changed.
8062
045eb8d9
PE
8063 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8064
c1f134b5
PE
8065 * fns.c (concat): Minor tuning based on overflow analysis.
8066 This doesn't fix any bugs. Use int to hold character, instead
8067 of constantly refetching from Emacs object. Use XFASTINT, not
8068 XINT, for value known to be a character. Don't bother comparing
8069 a single byte to 0400, as it's always less.
8070
395fcb93 8071 * floatfns.c (Fexpt):
327eeec8
PE
8072 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8073
abbd3d23
PE
8074 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8075 for characters.
8076
684a03ef
PE
8077 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8078
0fed43f3
PE
8079 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8080 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8081 incorrectly succeed when S was a string, because 4294967386 was
8082 truncated before it was used.
8083
8fd02eb7
PE
8084 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8085 Otherwise, an out-of-range integer could cause undefined behavior
8086 on a 64-bit host.
8087
f8c86b69
PE
8088 * composite.c: Use int, not EMACS_INT, for characters.
8089 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8090 EMACS_INT, for values that are known to be in character range.
8091 This doesn't fix any bugs but is the usual style inside Emacs and
8092 may generate better code on 32-bit machines.
8093
34206dd2
PE
8094 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8095 This is for reasons similar to the recent CHAR_STRING fix.
8096 * charset.c (Fencode_char): Check that character arg is actually
8097 a character. Pass an int to ENCODE_CHAR.
8098 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8099 wider than 'int', as a compile-time check to prevent future regressions
8100 in this area.
8101
c5958d4c 8102 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8103
8104 Make sure a 64-bit char is never passed to CHAR_STRING.
8105 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8106 by silently ignoring the top 32 bits, allowing some values
8107 that were far too large to be valid characters.
8108 * character.h: Include <verify.h>.
8109 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8110 arguments are no wider than unsigned, as a compile-time check
8111 to prevent future regressions in this area.
8112 * data.c (Faset):
01103c44 8113 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8114 (Fsubst_char_in_region):
8115 * fns.c (concat):
8116 * xdisp.c (decode_mode_spec_coding):
8117 Adjust to CHAR_STRING's new requirement.
8118 * editfns.c (Finsert_char, Fsubst_char_in_region):
8119 * fns.c (concat): Check that character args are actually
8120 characters. Without this test, these functions did the wrong
8121 thing with wildly out-of-range values on 64-bit hosts.
8122
d37ca623
PE
8123 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8124 These casts should not be needed on 32-bit hosts, either.
8125 * keyboard.c (read_char):
8126 * lread.c (Fload): Remove casts to unsigned.
8127
ea204efb
PE
8128 * lisp.h (UNSIGNED_CMP): New macro.
8129 This fixes comparison bugs on 64-bit hosts.
8130 (ASCII_CHAR_P): Use it.
8131 * casefiddle.c (casify_object):
01103c44 8132 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8133 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8134 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8135 * dispextern.h (FACE_FROM_ID):
8136 * keyboard.c (read_char): Use UNSIGNED_CMP.
8137
41cb286c
PE
8138 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8139 not to EMACS_INT, to avoid GCC warning.
8140
4a1b9832
PE
8141 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8142
55daad71
PE
8143 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8144 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8145 isn't needed on 32-bit machines.
8f95c75c 8146
01103c44
PE
8147 * buffer.c (Fgenerate_new_buffer_name):
8148 Use EMACS_INT for count, not int.
0ceccced 8149 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8150
8151 * data.c (Qcompiled_function): Now static.
8152
c6f072e7
PE
8153 * window.c (window_body_lines): Now static.
8154
20ce5912
PE
8155 * image.c (gif_load): Rename local to avoid shadowing.
8156
9c4c5f81
PE
8157 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8158 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8159 * alloc.c (make_save_value): Integer argument is now of type
8160 ptrdiff_t, not int.
8161 (mark_object): Use ptrdiff_t, not int.
8162 * lisp.h (pD): New macro.
8163 * print.c (print_object): Use it.
8164
c0c5c8ae
PE
8165 * alloc.c: Use EMACS_INT, not int, to count objects.
8166 (total_conses, total_markers, total_symbols, total_vector_size)
8167 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8168 (total_free_floats, total_floats, total_free_intervals)
8169 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8170 Now EMACS_INT, not int. All uses changed.
8171 (Fgarbage_collect): Compute overall total using a double, so that
8172 integer overflow is less likely to be a problem. Check for overflow
8173 when converting back to an integer.
5a25e253
PE
8174 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8175 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8176 These were 'int' variables that could overflow on 64-bit hosts;
8177 they were never used, so remove them instead of repairing them.
211a0b2a 8178 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8179 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8180 Previously, this ceilinged at INT_MAX, but that doesn't work on
8181 64-bit machines.
e46bb31a 8182 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8183
c78baabf 8184 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8185 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8186 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8187 when a (possibly-narrower) signed value would do just as well.
8188 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8189
c9d624c6
PE
8190 * alloc.c: Catch some string size overflows that we were missing.
8191 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8192 for convenience in STRING_BYTES_MAX.
8193 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8194 The definition here is exact; the one in lisp.h was approximate.
8195 (allocate_string_data): Check for string overflow. This catches
8196 some instances we weren't catching before. Also, it catches
8197 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8198 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8199 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8200
c9d624c6
PE
8201 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8202 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8203 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8204
353032ce
PE
8205 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8206
2bccce07
PE
8207 * alloc.c (Fmake_string): Check for out-of-range init.
8208
0ac30604
SM
82092011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8210
8211 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8212
c195f2de
JD
82132011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8214
8215 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8216 xg_get_default_scrollbar_width.
8217
8218 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8219 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8220 (style_changed_cb): Call update_theme_scrollbar_width and call
8221 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8222 all frames (Bug#8505).
8223 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8224 Call gtk_window_set_resizable if HAVE_GTK3.
8225 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8226 and height if HAVE_GTK3 (Bug#8505).
8227 (scroll_bar_width_for_theme): New variable.
8228 (update_theme_scrollbar_width): New function.
8229 (xg_get_default_scrollbar_width): Move code to
8230 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8231 (xg_initialize): Call update_theme_scrollbar_width.
8232
8233 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8234
8235 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8236
e10ac9f1
MR
82372011-06-12 Martin Rudalics <rudalics@gmx.at>
8238
8239 * frame.c (make_frame): Call other_buffer_safely instead of
8240 other_buffer.
8241
8242 * window.c (temp_output_buffer_show): Call display_buffer with
8243 second argument Vtemp_buffer_show_specifiers and reset latter
8244 immediately after the call.
8245 (Vtemp_buffer_show_specifiers): New variable.
8246 (auto_window_vscroll_p, next_screen_context_lines)
8247 (Vscroll_preserve_screen_position): Remove leading asterisks from
8248 doc-strings.
8249
2d3c217e 82502011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8251
7b7f97e8 8252 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8253 * buffer.c (Qclone_number): Remove for now, as it's unused.
8254 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8255 (record_buffer): Remove unused local.
8256 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8257 (set_frame_buffer_list): Remove; unused.
8258 * frame.h (other_visible_frames): Remove decl.
8259 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8260 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8261 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8262 if HAVE_GPM.
8263 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8264 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8265 Define only if HAVE_GPM.
8266 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8267 (update_hints_inhibit): Remove; never set. All uses removed.
8268 * widgetprv.h (emacsFrameClassRec): Remove decl.
8269 * window.c (delete_deletable_window): Now returns void, since it
8270 wasn't returning anything.
8271 (compare_window_configurations): Remove unused locals.
8272 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8273 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8274 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8275 the same widths as pointers. This follows up on the 2011-05-06 patch.
8276 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8277 * xterm.h: Likewise.
8278 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8279
1384b89e
JB
82802011-06-12 Juanma Barranquero <lekktu@gmail.com>
8281
8282 * makefile.w32-in: Update dependencies.
8283 (LISP_H): Add lib/intprops.h.
8284
1100a63c
CY
82852011-06-11 Chong Yidong <cyd@stupidchicken.com>
8286
8287 * image.c (gif_load): Add animation frame delay to the metadata.
8288 (syms_of_image): Use DEFSYM. New symbol `delay'.
8289
6198ccd0
MR
82902011-06-11 Martin Rudalics <rudalics@gmx.at>
8291
8292 * window.c (delete_deletable_window): Re-add.
8293 (Fset_window_configuration): Rewrite to handle dead buffers and
8294 consequently deletable windows.
8295 (window_tree, Fwindow_tree): Remove. Supply functionality in
8296 window.el.
8297 (compare_window_configurations): Simplify code.
8298
b6e3633c
AS
82992011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8300
1ab0dee5
AS
8301 * image.c (imagemagick_load_image): Fix type mismatch.
8302 (Fimagemagick_types): Likewise.
8303
b6e3633c
AS
8304 * window.h (replace_buffer_in_windows): Declare.
8305
9397e56f
MR
83062011-06-11 Martin Rudalics <rudalics@gmx.at>
8307
8308 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8309 Qclone_number. Remove external declaration of Qdelete_window.
8310 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8311 code.
640c8776
SM
8312 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8313 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8314 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8315 buffer list implementation.
8316 (other_buffer_safely): New function.
8317 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8318 calls to replace_buffer_in_windows and
8319 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8320 if allowed.
8321 (record_buffer): Inhibit quitting and rewrite using quittable
8322 functions. Run Qbuffer_list_update_hook if allowed.
8323 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8324 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8325 Move switch-to-buffer to window.el.
9397e56f
MR
8326 (bury-buffer): Move to window.el.
8327 (Vbuffer_list_update_hook): New variable.
8328
8329 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8330 section.
8331
8332 * window.h (resize_frame_windows): Move up in code.
8333 (Fwindow_frame): Remove EXFUN.
8334 (replace_buffer_in_all_windows): Remove prototype.
8335 (replace_buffer_in_windows_safely): Add prototype.
8336
8337 * window.c: Declare Qdelete_window static again. Move down
8338 declaration of select_count.
8339 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8340 (Fother_window): Move to window.el.
8341 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8342 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8343 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8344 window.el.
8345 (replace_buffer_in_windows): Implement by calling
8346 Qreplace_buffer_in_windows.
8347 (replace_buffer_in_all_windows): Remove with some functionality
8348 moved into replace_buffer_in_windows_safely.
8349 (replace_buffer_in_windows_safely): New function.
8350 (select_window_norecord, select_frame_norecord): Move in front
8351 of run_window_configuration_change_hook. Remove now obsolete
8352 declarations.
640c8776
SM
8353 (Fset_window_buffer): Rewrite doc-string.
8354 Call Qrecord_window_buffer.
9397e56f
MR
8355 (keys_of_window): Move binding for other-window to window.el.
8356
b50691aa
CY
83572011-06-11 Chong Yidong <cyd@stupidchicken.com>
8358
8359 * dispextern.h (struct image): Replace data member, whose int_val
8360 and ptr_val fields were not used by anything, with a single
8361 lisp_val object.
8362
8363 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8364 (gif_clear_image, gif_load, imagemagick_load_image)
8365 (gs_clear_image, gs_load): Callers changed.
8366
3f754b86
PE
83672011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8368
cca69397
PE
8369 * buffer.h: Include <time.h>, for time_t.
8370 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8371
109e28d0
PE
8372 Fix minor problems found by static checking.
8373
60737f02
PE
8374 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8375
4b66faf3
PE
8376 Make identifiers static if they are not used in other modules.
8377 * data.c (Qcompiled_function, Qframe, Qvector):
8378 * image.c (QimageMagick, Qsvg):
8379 * minibuf.c (Qmetadata):
8380 * window.c (resize_window_check, resize_root_window): Now static.
8381 * window.h (resize_window_check, resize_root_window): Remove decls.
8382
109e28d0
PE
8383 * window.c (window_deletion_count, delete_deletable_window):
8384 Remove; unused.
46a4ce9e
PE
8385 (window_body_lines): Now static.
8386 (Fdelete_other_windows_internal): Mark vars as initialized.
8387 Make sure 'resize_failed' is initialized.
8388 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8389 (resize_window_apply): Remove unused local.
8390 * window.h (delete_deletable_window): Remove decl.
8391
109e28d0 8392 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8393 (imagemagick_load_image): Fix pointer signedness problem by changing
8394 last arg from unsigned char * to char *. All uses changed.
8395 Also, fix a local for similar reasons.
8396 Remove unused locals. Remove locals to avoid shadowing.
8397 (fn_rsvg_handle_free): Remove; unused.
8398 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8399 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8400
3f754b86
PE
8401 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8402
2547adb1
CY
84032011-06-10 Chong Yidong <cyd@stupidchicken.com>
8404
8405 * image.c (gif_load): Fix omitted cast error introduced by
8406 2011-06-06 change.
8407
2c8e37d4
MR
84082011-06-10 Martin Rudalics <rudalics@gmx.at>
8409
8410 * window.h (resize_proportionally, orig_total_lines)
8411 (orig_top_line): Remove from window structure.
8412 (set_window_height, set_window_width, change_window_heights)
8413 (Fdelete_window): Remove prototypes.
8414 (resize_frame_windows): Remove duplicate declaration.
8415
440a42e3
EZ
84162011-06-10 Eli Zaretskii <eliz@gnu.org>
8417
8418 * window.h (resize_frame_windows, resize_window_check)
8419 (delete_deletable_window, resize_root_window)
8420 (resize_frame_windows): Declare prototypes.
8421
8422 * window.c (resize_window_apply): Make definition be "static" to
8423 match the prototype.
8424
562dd5e9
MR
84252011-06-10 Martin Rudalics <rudalics@gmx.at>
8426
8427 * window.c: Remove declarations of Qwindow_size_fixed,
8428 window_min_size_1, window_min_size_2, window_min_size,
8429 size_window, window_fixed_size_p, enlarge_window, delete_window.
8430 Remove static from declaration of Qdelete_window, it's
8431 temporarily needed by Fbury_buffer.
8432 (replace_window): Don't assign orig_top_line and
8433 orig_total_lines.
8434 (Fdelete_window, delete_window): Remove. Window deletion is
8435 handled by window.el.
640c8776
SM
8436 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8437 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8438 (Fdelete_other_windows): Remove. Deleting other windows is
8439 handled by window.el.
8440 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8441 handled in window.el.
8442 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8443 Window minimum sizes are handled in window.el.
8444 (shrink_windows, size_window, set_window_height)
8445 (set_window_width, change_window_heights, window_height)
8446 (window_width, CURBEG, CURSIZE, enlarge_window)
8447 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8448 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8449 handled in window.el.
8450 (make_dummy_parent): Rename to make_parent_window and give it a
8451 second argument horflag.
8452 (make_window): Don't set resize_proportionally any more.
8453 (Fsplit_window): Remove. Windows are split in window.el.
8454 (save_restore_action, save_restore_orig_size)
8455 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8456 Resize mini windows in window.el.
8457 (grow_mini_window, shrink_mini_window): Implement by calling
8458 Qresize_root_window_vertically, resize_window_check and
8459 resize_window_apply.
640c8776
SM
8460 (saved_window, Fset_window_configuration, save_window_save):
8461 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8462 resize_proportionally.
8463 (window_min_height, window_min_width): Move to window.el.
8464 (keys_of_window): Move bindings for delete-other-windows,
8465 split-window, delete-window and enlarge-window to window.el.
8466
8467 * buffer.c: Temporarily extern Qdelete_window.
8468 (Fbury_buffer): Temporarily call Qdelete_window instead of
8469 Fdelete_window (Fbury_buffer will move to window.el soon).
8470
8471 * frame.c (set_menu_bar_lines_1): Remove code handling
8472 orig_top_line and orig_total_lines.
8473
8474 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8475 set_window_height but set heights directly.
8476 (change_frame_size_1): Use resize_frame_windows.
8477
8478 * xdisp.c (init_xdisp): Don't use set_window_height but set
8479 heights directly.
8480
640c8776
SM
8481 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8482 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8483 run_window_configuration_change_hook.
8484
8485 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8486 instead of change_window_heights and run
8487 run_window_configuration_change_hook.
8488
1a13852e
MR
84892011-06-09 Martin Rudalics <rudalics@gmx.at>
8490
8491 * window.c (replace_window): Rename second argument REPLACEMENT to
8492 NEW. New third argument SETFLAG. Rewrite.
8493 (delete_window, make_dummy_parent): Call replace_window with
8494 third argument 1.
8495 (window_list_1): Move down in code.
8496 (run_window_configuration_change_hook): Move set_buffer part
8497 before select_frame_norecord part in order to unwind correctly.
8498 Rename count1 to count.
8499 (recombine_windows, delete_deletable_window, resize_root_window)
8500 (Fdelete_other_windows_internal)
8501 (Frun_window_configuration_change_hook, make_parent_window)
8502 (resize_window_check, resize_window_apply, Fresize_window_apply)
8503 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8504 (Fdelete_window_internal, Fresize_mini_window_internal):
8505 New functions.
1a13852e
MR
8506 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8507
f3d1777e
MR
85082011-06-08 Martin Rudalics <rudalics@gmx.at>
8509
496e208e
MR
8510 * window.h (window): Add some new members to window structure -
8511 normal_lines, normal_cols, new_total, new_normal, clone_number,
8512 splits, nest, prev_buffers, next_buffers.
8513 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8514 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8515
f3d1777e
MR
8516 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8517 Remove.
496e208e
MR
8518 (make_dummy_parent): Set new members of windows structure.
8519 (make_window): Move down in code. Handle new members of window
8520 structure.
8521 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8522 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8523 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8524 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8525 (Fset_window_next_buffers, Fset_window_clone_number):
8526 New functions.
496e208e
MR
8527 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8528 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8529 Doc-string fixes.
8530 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8531 Argument WINDOW can be now internal window too.
8532 (Fwindow_use_time): Move up in code.
8533 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8534 Rewrite doc-string.
8535 (Fset_window_configuration, saved_window)
8536 (Fcurrent_window_configuration, save_window_save): Handle new
8537 members of window structure.
b9e809c2
MR
8538 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8539 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8540 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8541 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8542 Qget_mru_window, Qresize_root_window,
8543 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8544 Qauto_buffer_name; staticpro them.
f3d1777e 8545
abde8f8c
MR
85462011-06-07 Martin Rudalics <rudalics@gmx.at>
8547
8548 * window.c (Fwindow_total_size, Fwindow_left_column)
8549 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8550 (Fwindow_list_1): New functions.
8551 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8552 (Fwindow_width, Fscroll_left, Fscroll_right):
8553 Use window_body_cols instead of window_box_text_cols.
8554 (delete_window, Fset_window_configuration):
8555 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8556 (delete_all_subwindows): Take a window as argument and not a
8557 structure. Rewrite.
190b47e6
MR
8558 (window_loop): Remove handling of GET_LRU_WINDOW and
8559 GET_LARGEST_WINDOW.
8560 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8561
8562 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8563 window_box_text_cols. delete_all_subwindows now takes a
8564 Lisp_Object as argument.
abde8f8c 8565
640c8776
SM
8566 * indent.c (compute_motion, Fcompute_motion):
8567 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8568
fa8a67e6
MR
8569 * frame.c (delete_frame): Call delete_all_subwindows with root
8570 window as argument.
8571
a54e3482
DC
85722011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8573
8574 * fns.c (Fputhash): Document return value.
8575
60002bf5
CY
85762011-06-06 Chong Yidong <cyd@stupidchicken.com>
8577
8578 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8579
0c671da6 85802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8581
b862a52a 8582 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8583
be44ca6c
PE
8584 Check for overflow when converting integer to cons and back.
8585 * charset.c (Fdefine_charset_internal, Fdecode_char):
8586 Use cons_to_unsigned to catch overflow.
8587 (Fencode_char): Use INTEGER_TO_CONS.
8588 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8589 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8590 * data.c (long_to_cons, cons_to_long): Remove.
8591 (cons_to_unsigned, cons_to_signed): New functions.
8592 These signal an error for invalid or out-of-range values.
8593 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8594 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8595 * font.c (Ffont_variation_glyphs):
8596 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8597 * lisp.h: Include <intprops.h>.
8598 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8599 (cons_to_signed, cons_to_unsigned): New decls.
8600 (long_to_cons, cons_to_long): Remove decls.
8601 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8602 (Fprimitive_undo): Use CONS_TO_INTEGER.
8603 * xfns.c (Fx_window_property): Likewise.
8604 * xselect.c: Include <limits.h>.
8605 (x_own_selection, selection_data_to_lisp_data):
8606 Use INTEGER_TO_CONS.
8607 (x_handle_selection_request, x_handle_selection_clear)
8608 (x_get_foreign_selection, Fx_disown_selection_internal)
8609 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8610 (lisp_data_to_selection_data): Use cons_to_unsigned.
8611 (x_fill_property_data): Use cons_to_signed.
8612 Report values out of range.
8613
d1f3d2af
PE
8614 Check for buffer and string overflow more precisely.
8615 * buffer.h (BUF_BYTES_MAX): New macro.
8616 * lisp.h (STRING_BYTES_MAX): New macro.
8617 * alloc.c (Fmake_string):
8618 * character.c (string_escape_byte8):
8619 * coding.c (coding_alloc_by_realloc):
8620 * doprnt.c (doprnt):
8621 * editfns.c (Fformat):
8622 * eval.c (verror):
8623 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8624 since they may not be the same number.
8625 * editfns.c (Finsert_char):
8626 * fileio.c (Finsert_file_contents):
8627 Likewise for BUF_BYTES_MAX.
8628
dd52fcea
PE
8629 * image.c: Use ptrdiff_t, not int, for sizes.
8630 (slurp_file): Switch from int to ptrdiff_t.
8631 All uses changed.
8632 (slurp_file): Check that file size fits in both size_t (for
8633 malloc) and ptrdiff_t (for sanity and safety).
8634
7f9bbdbb
PE
8635 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8636 if b->modtime has its maximal value.
8637
dfe18f82
PE
8638 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8639
84acfcf0
PE
8640 Don't assume time_t can fit into int.
8641 * buffer.h (struct buffer.modtime): Now time_t, not int.
8642 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8643 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8644
ccd9a01a
PE
8645 Minor fixes for signed vs unsigned integers.
8646 * character.h (MAYBE_UNIFY_CHAR):
8647 * charset.c (maybe_unify_char):
8648 * keyboard.c (read_char, reorder_modifiers):
8649 XINT -> XFASTINT, since the integer must be nonnegative.
8650 * ftfont.c (ftfont_spec_pattern):
8651 * keymap.c (access_keymap, silly_event_symbol_error):
8652 XUINT -> XFASTINT, since the integer must be nonnegative.
8653 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8654 since it makes no difference and we prefer signed.
8655 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8656 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8657 nonnegative.
8658
d6d100dd
SM
86592011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8660
8661 * window.h (Fwindow_frame): Declare.
8662
2b6148e4
PE
86632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8664
8665 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8666 (SPARE_MEMORY): Always define.
8667 (LARGE_REQUEST): Remove.
8668 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8669
f230ecc9
MR
86702011-06-06 Martin Rudalics <rudalics@gmx.at>
8671
727e958e
MR
8672 * lisp.h: Move EXFUNS for Fframe_root_window,
8673 Fframe_first_window and Fset_frame_selected_window to window.h.
8674
8675 * window.h: Move EXFUNS for Fframe_root_window,
8676 Fframe_first_window and Fset_frame_selected_window here from
8677 lisp.h.
8678
8679 * frame.c (Fwindow_frame, Fframe_first_window)
8680 (Fframe_root_window, Fframe_selected_window)
8681 (Fset_frame_selected_window): Move to window.c.
8682 (Factive_minibuffer_window): Move to minibuf.c.
8683 (Fother_visible_frames_p): New function.
8684
8685 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8686
f230ecc9
MR
8687 * window.c (decode_window, decode_any_window): Move up in code.
8688 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8689 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8690 (Fwindow_buffer): Move up and rewrite doc-string.
8691 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8692 (Fwindow_prev): New functions.
727e958e
MR
8693 (Fwindow_frame): Move here from frame.c. Accept any window as
8694 argument.
8695 (Fframe_root_window, Fframe_first_window)
8696 (Fframe_selected_window): Move here from frame.c. Accept frame
8697 or arbitrary window as argument. Update doc-strings.
8698 (Fminibuffer_window): Move up in code.
8699 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8700 (Fset_frame_selected_window): Move here from frame.c.
8701 Marginal rewrite.
727e958e
MR
8702 (Fselected_window, select_window, Fselect_window): Move up in
8703 code. Minor doc-string fixes.
f230ecc9 8704
4d09bcf6
PE
87052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8706
8707 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8708 Do not assume that spare memory exists; that assumption is valid
8709 only if SYSTEM_MALLOC.
8710 (LARGE_REQUEST): New macro, so that the issue of large requests
8711 is separated from the issue of spare memory.
8712
810928a2
AS
87132011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8714
172418ad
AS
8715 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8716 format. (Bug#8806)
8717
43f862f7
AS
8718 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8719
810928a2
AS
8720 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8721 before statements.
8722
a059fe24
JD
87232011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8724
8725 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8726
8727 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8728
8729 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8730 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8731
989bf368
JB
87322011-06-05 Juanma Barranquero <lekktu@gmail.com>
8733
8734 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8735
4b80f674
CY
87362011-06-04 Chong Yidong <cyd@stupidchicken.com>
8737
8738 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8739 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8740 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8741 New error handlers.
4b80f674
CY
8742 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8743 Obey Vx_select_enable_clipboard_manager. Catch errors in
8744 x_clipboard_manager_save (Bug#8779).
8745 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8746 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8747
99a33b77 87482011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8749
8750 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8751
99a33b77 87522011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8753
8754 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8755 in the current matrix if keep_current_p is non-zero.
8756
8264569d
EZ
87572011-06-04 Eli Zaretskii <eliz@gnu.org>
8758
8759 * bidi.c (bidi_level_of_next_char): Fix last change.
8760
57f97249
EZ
87612011-06-03 Eli Zaretskii <eliz@gnu.org>
8762
fec2107c 8763 Support bidi reordering of text covered by display properties.
57f97249 8764
fec2107c
EZ
8765 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8766 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8767 (bidi_cache_search, bidi_cache_iterator_state)
8768 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8769 (bidi_level_of_next_char, bidi_move_to_visually_next):
8770 Support character positions inside a run of characters covered by a
fec2107c
EZ
8771 display string.
8772 (bidi_paragraph_init, bidi_resolve_explicit_1)
8773 (bidi_level_of_next_char): Call bidi_fetch_char and
8774 bidi_fetch_char_advance instead of FETCH_CHAR and
8775 FETCH_CHAR_ADVANCE.
8776 (bidi_init_it): Initialize new members.
8777 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8778 definitions.
8779 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8780 instead of using explicit *_CHAR codes.
d6d100dd
SM
8781 (bidi_resolve_explicit, bidi_resolve_weak):
8782 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8783 bidirectional text is supported only in multibyte buffers.
8784 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8785 it to initialize the frame_window_p member of struct bidi_it.
8786 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8787 (bidi_resolve_explicit, bidi_resolve_weak)
8788 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8789 bidi_it->nchars is non-positive.
8790 (bidi_level_of_next_char): Don't try to lookup the cache for the
8791 next/previous character if nothing is cached there yet, or if we
8792 were just reseat()'ed to a new position.
c40e2fb2 8793
0e14fe90
EZ
8794 * xdisp.c (set_cursor_from_row): Set start and stop points
8795 according to the row's direction when priming the loop that looks
8796 for the glyph on which to display cursor.
8797 (single_display_spec_intangible_p): Function deleted.
8798 (display_prop_intangible_p): Reimplement to call
8799 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8800 Accept 3 additional arguments needed by handle_display_spec.
8801 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8802 values: lists, `(when COND...)' forms, etc.
8803 (single_display_spec_string_p): Support property values that are
8804 lists with the argument STRING its top-level element.
8805 (display_prop_string_p): Fix the condition for processing a
8806 property that is a list to be consistent with handle_display_spec.
fec2107c 8807 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8808 last portion of handle_display_prop.
8809 (compute_display_string_pos): Accept additional argument
8810 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8811 value of a `display' property is a "replacing spec".
8812 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8813 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8814 the display property, but just return a value indicating whether
8815 the display property will replace the characters it covers.
8816 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8817 frame_window_p members of struct bidi_it.
d6d100dd
SM
8818 (compute_display_string_pos, compute_display_string_end):
8819 New functions.
fec2107c
EZ
8820 (push_it): Accept second argument POSITION, where pop_it should
8821 jump to continue iteration.
8822 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8823
fec2107c
EZ
8824 * keyboard.c (adjust_point_for_property): Adjust the call to
8825 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8826
8827 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8828 (bidi_init_it): Update prototypes.
8829 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8830 (compute_display_string_pos, compute_display_string_end):
8831 Declare prototypes.
fec2107c
EZ
8832 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8833 EMACS_INT.
fc6f18ce 8834
40087514 88352011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8836
57f53182
PE
8837 Malloc failure behavior now depends on size of allocation.
8838 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8839 * lisp.h: Change signatures accordingly.
8840 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8841 All callers changed. (Bug#8762)
8842
8843 * gnutls.c: Use Emacs's memory allocators.
8844 Without this change, the gnutls library would invoke malloc etc.
8845 directly, which causes problems on non-SYNC_INPUT hosts, and which
8846 runs afoul of improving memory_full behavior. (Bug#8761)
8847 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8848 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8849 xfree instead of the default malloc, realloc, free.
8850 (Fgnutls_boot): No need to check for memory allocation failure,
8851 since xmalloc does that for us.
8852
ac32cd99 8853 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8854 * category.c (hash_get_category_set):
8855 * ccl.c (ccl_driver):
8856 * charset.c (Fdefine_charset_internal):
8857 * charset.h (struct charset.hash_index):
8858 * composite.c (get_composition_id, gstring_lookup_cache)
8859 (composition_gstring_put_cache):
8860 * composite.h (struct composition.hash_index):
8861 * dispextern.h (struct image.hash):
8862 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8863 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8864 (hashfn_equal, hashfn_user_defined, make_hash_table)
8865 (maybe_resize_hash_table, hash_lookup, hash_put)
8866 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8867 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8868 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8869 * image.c (make_image, search_image_cache, lookup_image)
8870 (xpm_put_color_table_h):
8871 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8872 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8873 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8874 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8875 * alloc.c (allocate_vectorlike):
8876 Check for overflow in vector size calculations.
8877 * ccl.c (ccl_driver):
8878 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8879 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8880 need to be updated by these changes.
40087514
PE
8881 * fns.c (make_hash_table, maybe_resize_hash_table):
8882 Check for integer overflow with large hash tables.
0de4bb68
PE
8883 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8884 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8885 (SXHASH_REDUCE): New macro.
8886 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8887 Use it instead of discarding useful hash info with large hash values.
8888 (sxhash_float): New function.
8889 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8890 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8891 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8892 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8893 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8894 Adjust signatures to match updated version of code.
8895 (consing_since_gc): Now EMACS_INT, since a single hash table can
8896 use more than INT_MAX bytes.
8897
698d32e2
DN
88982011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8899
8900 Make it possible to build with GCC-4.6+ -O2 -flto.
8901
8902 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8903
fd6fa53f
SM
89042011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8905
8906 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8907 Call minibuffer-inactive-mode.
8908
864db017
JB
89092011-05-31 Juanma Barranquero <lekktu@gmail.com>
8910
8911 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8912 Update dependencies.
8913
2ad0baf4
DN
89142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8915
8916 * data.c (init_data): Remove code for UTS, this system is not
8917 supported anymore.
8918
4fcc2638
DN
89192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8920
8921 Don't force ./temacs to start in terminal mode.
8922
8923 * frame.c (make_initial_frame): Initialize faces in all cases, not
8924 only when CANNOT_DUMP is defined.
8925 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8926
c56e0fd5
DN
89272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8928
8929 * dispnew.c (add_window_display_history): Use const for the string
8930 pointer. Remove declaration, not needed.
8931
333d54da 89322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8933
55d4c1b2 8934 Use 'inline', not 'INLINE'.
333d54da 8935 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8936 * alloc.c, fontset.c (INLINE): Remove.
8937 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8938 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8939 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8940 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8941 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8942
738db178
DN
89432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8944
8945 Make it possible to run ./temacs.
8946
8947 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8948 syms_of_callproc does the same thing. Remove test for
8949 "initialized", do it in the caller.
8950 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8951
620c53a6
SM
89522011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8953
8954 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8955 (read_minibuf): Use get_minibuffer.
8956 (syms_of_minibuf): Use DEFSYM.
8957 (Qmetadata): New var.
8958 * data.c (Qbuffer): Don't make it static.
8959 (syms_of_data): Use DEFSYM.
8960
e003a292
PE
89612011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8962
8963 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8964 (CCL_CODE_MIN): New macro.
8965
ed008a6d
PE
89662011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8967
3687c2ef
PE
8968 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8969
ed008a6d
PE
8970 * eval.c (Qdebug): Now static.
8971 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8972 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8973 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8974
d66c4c7c
CY
89752011-05-29 Chong Yidong <cyd@stupidchicken.com>
8976
8977 * image.c: Various fixes to ImageMagick code comments.
8978 (Fimagemagick_types): Doc fix.
8979
5fbc2025
PE
89802011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8981
0196f88a
PE
8982 Minor fixes prompted by GCC 4.6.0 warnings.
8983
8984 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8985
5fbc2025
PE
8986 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8987 (x_clipboard_manager_save_all): Move extern decl to ...
8988 * xterm.h: ... here, so that it can be checked for consistency.
8989
1dd3c2d9
CY
89902011-05-29 Chong Yidong <cyd@stupidchicken.com>
8991
8992 * xselect.c (x_clipboard_manager_save_frame)
8993 (x_clipboard_manager_save_all): New functions.
8994 (Fx_clipboard_manager_save): Lisp function deleted.
8995
8996 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8997 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8998
8999 * xterm.h: Update prototype.
9000
5ba6571d
WX
90012011-05-28 William Xu <william.xwl@gmail.com>
9002
9003 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9004 exiting (Bug#8239).
9005
3eaff834
JM
90062011-05-28 Jim Meyering <meyering@redhat.com>
9007
e1900994 9008 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9009 * fns.c (to_uchar): Define.
9010 (crypto_hash_function): Use it to convert some newly-signed
9011 variables to unsigned, to avoid sign-extension bugs. For example,
9012 without this change, (md5 "truc") would evaluate to
9013 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9014 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9015 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9016
0f6990a7
PE
90172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9018
9019 Integer overflow fixes.
c8a9ca5a 9020
08686060
PE
9021 * dbusbind.c: Serial number integer overflow fixes.
9022 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9023 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9024 to hold a serial number that is too large for a fixnum.
9025 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9026 Check for serial numbers out of range. Decode any serial number
59568bf0 9027 that was so large that it became a float. (Bug#8722)
08686060 9028
2d1fc3c7
PE
9029 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9030 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9031 Use XFASTINT rather than XUINT when numbers are nonnegative.
9032 (xd_append_arg, Fdbus_method_return_internal):
9033 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9034 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9035 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9036 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9037 (Bug#8722)
2d1fc3c7 9038
c8a9ca5a
PE
9039 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9040
519e1d69
PE
9041 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9042
6df6ae42 9043 ccl: Add integer overflow checks.
30569699
PE
9044 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9045 (IN_INT_RANGE): New macros.
9046 (ccl_driver): Use them to check for integer overflow when
9047 decoding a CCL program. Many of the new checks are whether XINT (x)
9048 fits in int; it doesn't always, on 64-bit hosts. The new version
9049 doesn't catch all possible integer overflows, but it's an
847044ea 9050 improvement. (Bug#8719)
30569699 9051
c11285dc
PE
9052 * alloc.c (make_event_array): Use XINT, not XUINT.
9053 There's no need for unsigned here.
9054
fdccd48e
PE
9055 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9056 This follows up to the 2011-05-06 change that substituted uintptr_t
9057 for EMACS_INT. This case wasn't caught back then.
9058
37910ab2
PE
9059 Rework Fformat to avoid integer overflow issues.
9060 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9061 now (part of C89). Include <verify.h>.
9062 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9063 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9064 (Fformat): Avoid the prepass trying to compute sizes; it was only
9065 approximate and thus did not catch overflow reliably. Instead, walk
9066 through the format just once, formatting and computing sizes as we go,
9067 checking for integer overflow at every step, and allocating a larger
9068 buffer as needed. Keep track separately whether the format is
9069 multibyte. Keep only the most-recently calculated precision, rather
9070 than them all. Record whether each argument has been converted to
9071 string. Use EMACS_INT, not int, for byte and char and arg counts.
9072 Support field widths and precisions larger than INT_MAX. Avoid
9073 sprintf's undefined behavior with conversion specifications such as %#d
9074 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9075 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9076 formatting out-of-range floating point numbers with int
9173deec 9077 formats. (Bug#8668)
37910ab2 9078
2e6578fb
PE
9079 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9080
0ae6bdee
PE
9081 * data.c: Avoid integer truncation in expressions involving floats.
9082 * data.c: Include <intprops.h>.
9083 (arith_driver): When there's an integer overflow in an expression
9084 involving floating point, convert the integers to floating point
9085 so that the resulting value does not suffer from catastrophic
9086 integer truncation. For example, on a 64-bit host (* 4
9087 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9088 Do not rely on undefined behavior after integer overflow.
9089
de883a70
PE
9090 merge count_size_as_multibyte, parse_str_to_multibyte
9091 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9092 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9093 Check for integer overflow.
9094 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9095 since it's now a duplicate of the other. This is more of
9096 a character than a buffer op, so better that it's in character.c.
9097 * fns.c, print.c: Adjust to above changes.
9098
2ff916cb
PE
90992011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9100
9101 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9102
f1b54466
PE
91032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9104
fb1ac845
PE
9105 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9106 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9107 (x_clipboard_manager_save): Now static.
9108 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9109
f1b54466
PE
9110 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9111 (crypto_hash_function): Now static.
9112 Fix pointer signedness problems. Avoid unnecessary initializations.
9113
a9f737ee
CY
91142011-05-27 Chong Yidong <cyd@stupidchicken.com>
9115
9116 * termhooks.h (Vselection_alist): Make it terminal-local.
9117
9118 * terminal.c (create_terminal): Initialize it.
9119
9120 * xselect.c: Support for clipboard managers.
9121 (Vselection_alist): Move to termhooks.h as terminal-local var.
9122 (LOCAL_SELECTION): New macro.
9123 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9124 (symbol_to_x_atom): Remove gratuitous arg.
9125 (x_handle_selection_request, lisp_data_to_selection_data)
9126 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9127 (x_own_selection, x_get_local_selection, x_convert_selection):
9128 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9129 (some_frame_on_display): Delete unused function.
9130 (Fx_own_selection_internal, Fx_get_selection_internal)
9131 (Fx_disown_selection_internal, Fx_selection_owner_p)
9132 (Fx_selection_exists_p): New optional frame arg.
9133 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9134 (x_handle_selection_clear): Don't treat other terminals with the
9135 same keyboard specially. Use the terminal-local Vselection_alist.
9136 (x_clear_frame_selections): Use Frun_hook_with_args.
9137
9138 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9139
9140 * xterm.h: Add support for those atoms.
9141
e067f0c1
CY
91422011-05-26 Chong Yidong <cyd@stupidchicken.com>
9143
9144 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9145 (converted_selections, conversion_fail_tag): New global variables.
9146 (x_selection_request_lisp_error): Free the above.
9147 (x_get_local_selection): Remove unnecessary code.
9148 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9149 of converted selections stored in converted_selections.
9150 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9151 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9152 (x_convert_selection): New function.
9153 (x_handle_selection_event): Simplify.
9154 (x_get_foreign_selection): Don't ignore incoming requests while
9155 waiting for an answer; this will fail when we implement
9156 SAVE_TARGETS, and seems unnecessary anyway.
9157 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9158 (Vx_sent_selection_functions): Doc fix.
9159
0f4aebc0
LL
91602011-05-26 Leo Liu <sdl.web@gmail.com>
9161
9162 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9163
e61124cd
YM
91642011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9165
9166 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9167
9168 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9169 for fringe update if it has periodic bitmap.
ac389d0c 9170 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9171 and fringe_bitmap_periodic_p.
9172
9173 * fringe.c (get_fringe_bitmap_data): New function.
9174 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9175 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9176 row. Mark glyph row for fringe update if periodicity changed.
9177
9178 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9179 for fringe update unless it has periodic bitmap.
9180
f16d9837
KH
91812011-05-25 Kenichi Handa <handa@m17n.org>
9182
9183 * xdisp.c (get_next_display_element): Set correct it->face_id for
9184 a static composition.
9185
e1b90ef6
LL
91862011-05-24 Leo Liu <sdl.web@gmail.com>
9187
9188 * deps.mk (fns.o):
9189 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9190
9191 * fns.c (crypto_hash_function, Fsha1): New function.
9192 (Fmd5): Use crypto_hash_function.
9193 (syms_of_fns): Add Ssha1.
9194
7400048f
PE
91952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9196
9197 * gnutls.c: Remove unused macros.
9198 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9199 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9200 Remove macros that are defined and never used.
9201 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9202
abb71cf4
CY
92032011-05-22 Chong Yidong <cyd@stupidchicken.com>
9204
9205 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9206 (Fx_get_selection_internal): Minor cleanup.
9207 (Fx_own_selection_internal): Rename arguments for consistency with
9208 select.el.
9209
6307db39
PE
92102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9211
9212 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9213
f3d4e0a4
CY
92142011-05-22 Chong Yidong <cyd@stupidchicken.com>
9215
9216 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9217
4d8ade89
YM
92182011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9219
9220 * dispnew.c (scrolling_window): Don't exclude the case that the
9221 last enabled row in the desired matrix touches the bottom boundary.
9222
32078c8d
GM
92232011-05-21 Glenn Morris <rgm@gnu.org>
9224
9225 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9226 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9227 and add some more files.
32078c8d 9228
7285dc67
EZ
92292011-05-20 Eli Zaretskii <eliz@gnu.org>
9230
9231 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9232 report_file_error introduced by the change from 2011-05-07.
9233
89d1bd22
PE
92342011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9235
9236 * systime.h (Time): Define only if emacs is defined.
9237 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9238 where the include path doesn't have X11/X.h by default. See
9239 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9240
cd394be1 92412011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9242
9243 * composite.c (find_automatic_composition): Fix previous change.
9244
b9704ad9
GM
92452011-05-20 Glenn Morris <rgm@gnu.org>
9246
9247 * lisp.mk: New file, split from Makefile.in.
9248 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9249 (shortlisp): Remove.
9250 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9251
4a720484
GM
92522011-05-19 Glenn Morris <rgm@gnu.org>
9253
9254 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9255 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9256 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9257 (lisp): Set the order to that of loadup.el.
9258 (shortlisp): Make it a copy of $lisp.
9259 (SOME_MACHINE_LISP): Remove.
9260 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9261 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9262
a28d4396
KH
92632011-05-18 Kenichi Handa <handa@m17n.org>
9264
9265 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9266 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9267 (find_automatic_composition): Mostly rewrite for efficiency.
9268
a2b1fa8e
JB
92692011-05-18 Juanma Barranquero <lekktu@gmail.com>
9270
9271 * makefile.w32-in: Update dependencies.
9272
8e1f5610
CS
92732011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9274
9275 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9276 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9277
7025ee00 92782011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9279
cdfa6eab
PE
9280 Fix some integer overflow issues, such as string length overflow.
9281
06d6db33
PE
9282 * insdel.c (count_size_as_multibyte): Check for string overflow.
9283
2b4560a8
PE
9284 * character.c (lisp_string_width): Check for string overflow.
9285 Use EMACS_INT, not int, for string indexes and lengths; in
9286 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9287 the resulting string length overflows an EMACS_INT; instead,
9288 report a string overflow if no precision given. When checking for
9289 precision exhaustion, use a check that cannot possibly have
9290 integer overflow. (Bug#8675)
9291 * character.h (lisp_string_width): Adjust to new signature.
9292
cb93f9be
PE
9293 * alloc.c (string_overflow): New function.
9294 (Fmake_string): Use it. This doesn't change behavior, but saves
9295 a few bytes and will simplify future changes.
9296 * character.c (string_escape_byte8): Likewise.
9297 * lisp.h (string_overflow): New decl.
9298
1a1f3366
PE
9299 Fixups, following up to the user-interface timestamp change.
9300 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9301 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9302 * msdos.c (mouse_get_pos): Likewise.
9303 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9304 * w32gui.h (Time): Define by including "systime.h" rather than by
9305 declaring it ourselves. (Bug#8664)
9306
d4e3e4d3
PE
9307 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9308 * image.c (clear_image_cache): Likewise.
9309
f6a24d19
PE
9310 * term.c (term_mouse_position): Don't assume time_t wraparound.
9311
08dc5ae6
PE
9312 Be more systematic about user-interface timestamps.
9313 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9314 and sometimes 'EMACS_UINT', to represent these timestamps.
9315 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9316 This makes the code easier to follow, and makes it easier to catch
9317 integer overflow bugs such as Bug#8664.
9318 * frame.c (Fmouse_position, Fmouse_pixel_position):
9319 Use Time, not unsigned long, for user-interface timestamps.
9320 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9321 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9322 * keyboard.h (last_event_timestamp): Likewise.
9323 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9324 * menu.h (xmenu_show): Likewise.
9325 * term.c (term_mouse_position): Likewise.
9326 * termhooks.h (struct input_event.timestamp): Likewise.
9327 (struct terminal.mouse_position_hook): Likewise.
9328 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9329 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9330 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9331 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9332 what it was before.
9333 * menu.h, termhooks.h: Include "systime.h", for Time.
9334
8e55734a
PE
9335 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9336 Don't assume that the difference between two unsigned long values
9337 can fit into an integer. At this point, we know button_down_time
9338 <= event->timestamp, so the difference must be nonnegative, so
9339 there's no need to cast the result if double-click-time is
9340 nonnegative, as it should be; check that it's nonnegative, just in
9341 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9342 apart (about 25 days). (Bug#8664)
8e55734a 9343
841f1b75 9344 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9345 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9346
3e26f69c
PE
9347 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9348 that always fit in int. Use a sentinel instead of a counter, to
9349 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9350 * frame.h (struct frame): Use int for menu_bar_items_used
9351 instead of EMACS_INT, since it always fits in int.
3e26f69c 9352
5cc152c0
PE
9353 * menu.c (grow_menu_items): Check for int overflow.
9354
d89eb65e
PE
9355 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9356
5235bd3e
PE
9357 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9358 Before, the code was not consistent. These values cannot exceed
9359 2**31 - 1 so there's no need to make them unsigned.
9360 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9361 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9362 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9363 as modifiers.
9364 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9365
bc827e23
PE
9366 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9367 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9368 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9369 presumably because the widths might not match.
9370
78eb494e
PE
9371 * window.c (size_window): Avoid needless test at loop start.
9372
04f2d78b
CB
93732011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9374
9375 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9376
d2fc7e3d 93772011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9378
9379 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9380
d2fc7e3d 93812011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9382
9383 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9384 `width' to `bar_area_x' and `bar_area_width', respectively.
9385 (x_scroll_run): Take account of fringe background extension.
9386
04f2d78b
CB
9387 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9388 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9389 `bar_area_width', respectively.
9390 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9391 background extension.
9392
79b70037
GM
93932011-05-10 Jim Meyering <meyering@redhat.com>
9394
9395 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9396
2f142cc5
JB
93972011-05-10 Juanma Barranquero <lekktu@gmail.com>
9398
9399 * image.c (Finit_image_library): Return t for built-in image types,
9400 like pbm and xbm. (Bug#8640)
9401
57679c86
AS
94022011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9403
9404 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9405
888c9e86
EZ
94062011-05-07 Eli Zaretskii <eliz@gnu.org>
9407
b0512a1d
EZ
9408 * w32console.c (Fset_screen_color): Doc fix.
9409 (Fget_screen_color): New function.
9410 (syms_of_ntterm): Defsubr it.
9411
7285dc67
EZ
9412 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9413 unlink the temporary file if Fcall_process didn't create it in the
9414 first place.
9415 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9416 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9417 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9418 cue to call_process_cleanup not to close that handle.
9419
4d3fcc8e
BK
94202011-05-07 Ben Key <bkey76@gmail.com>
9421
9422 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9423 one of two shell specific rules, either bootstrap-temacs-CMD or
9424 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9425 to the previous implementation of the bootstrap-temacs rule.
9426 The bootstrap-temacs-CMD rule is similar to the previous
9427 implementation of the bootstrap-temacs rule except that it
9428 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9429 variable.
9430
9431 These changes, along with some changes to nt/configure.bat,
9432 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9433 earlier fix to add support for --cflags and --ldflags options
9434 that include quotes so that it works whether make uses cmd or
9435 sh as the shell.
9436
b4289b64
MA
94372011-05-06 Michael Albinus <michael.albinus@gmx.de>
9438
9439 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9440 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9441 is a constant.
9442 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9443 a string. Handle both cases.
9444 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9445 (Fdbus_register_method): Use Qinvalid_function.
9446
af4c0e28
JB
94472011-05-06 Juanma Barranquero <lekktu@gmail.com>
9448
9449 * makefile.w32-in: Update dependencies.
9450 (LISP_H): Add inttypes.h and stdin.h.
9451 (PROCESS_H): Add unistd.h.
9452
c51453d9
EZ
94532011-05-06 Eli Zaretskii <eliz@gnu.org>
9454
9455 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9456 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9457
8ff0ac3c 94582011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9459
4c4b566b
PE
9460 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9461
aab2b9b5
PE
9462 * term.c (vfatal): Remove stray call to va_end.
9463 It's not needed and the C Standard doesn't allow it here anyway.
9464
c378da0b
PE
9465 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9466 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9467
288b08c7
PE
9468 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9469 bytes.
9470
e3601888
PE
9471 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9472
db6c0e74
PE
9473 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9474
dd5963ea
PE
9475 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9476
88c9450f
PE
9477 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9478
2f9442b8
PE
9479 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9480
c032b5f8
PE
9481 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9482 * charset.c (Fdefine_charset_internal): Don't initialize
9483 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9484 32-bit int (Bug#8600).
a108c10b
PE
9485
9486 * lread.c (read_integer): Be more consistent with string-to-number.
9487 Use string_to_number to do the actual conversion; this avoids
9488 rounding errors and fixes some other screwups. Without this fix,
9489 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9490 (digit_to_number): Move earlier, for benefit of read_integer.
9491 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9492 not a digit in any supported base. (Bug#8602)
a108c10b 9493
ad5f9eea
PE
9494 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9495
aec1708a
PE
9496 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9497 to match comment at start of function. This also removes a
9498 GCC warning about overflow in a 32+64-bit port.
9499
47be4ab5
PE
9500 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9501
371cac43
PE
9502 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9503 Reported by Stefan Monnier in
9504 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9505 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9506 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9507
d01a7826
PE
9508 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9509 (EMACS_UINTPTR): Likewise, with uintptr_t.
9510
7fd47d5c
PE
9511 * lisp.h: Prefer 64-bit EMACS_INT if available.
9512 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9513 on 32-bit hosts that have 64-bit int, so that they can access
9514 large files.
122b0c86
PE
9515 However, temporarily disable this change unless the temporary
9516 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9517
8727937b
PE
9518 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9519
8ac068ac
PE
9520 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9521 This removes an assumption that EMACS_INT and long are the same
9522 width as pointers. The assumption is true for Emacs porting targets
9523 now, but we want to make other targets possible.
9524 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9525 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9526 In the rest of the code, change types of integers that hold casted
9527 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9528 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9529 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9530 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9531 No need to cast type when ORing.
9532 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9533 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9534 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9535 assume EMACS_INT is the same width as char *.
9536 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9537 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9538 Remove no-longer-needed casts.
9539 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9540 (xg_tool_bar_help_callback, xg_make_tool_item):
9541 Use EMACS_INTPTR to hold an integer
9542 that will be cast to void *; this can avoid a GCC warning
9543 if EMACS_INT is not the same width as void *.
9544 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9545 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9546 (current_message_1, set_message_1):
9547 Use a local to convert to proper width without a cast.
9548 * xmenu.c (dialog_selection_callback): Likewise.
9549
ede49d71
PE
9550 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9551 Also, don't assume VALBITS / RAND_BITS is less than 5,
9552 and don't rely on undefined behavior when shifting a 1 left into
9553 the sign bit.
9554 * lisp.h (get_random): Change signature to match.
9555
2f30ecd0
PE
9556 * lread.c (hash_string): Use size_t, not int, for hash computation.
9557 Normally we prefer signed values; but hashing is special, because
9558 it's better to use unsigned division on hash table sizes so that
9559 the remainder is nonnegative. Also, size_t is the natural width
9560 for hashing into memory. The previous code used 'int', which doesn't
9561 retain enough info to hash well into very large tables.
9562 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9563
2a866e7b
PE
9564 * dbusbind.c: Don't possibly lose pointer info when converting.
9565 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9566 Use XPNTR rather than XHASH, so that the high-order bits of
9567 the pointer aren't lost when converting through void *.
9568
51639eac
PE
9569 * eval.c (Fautoload): Don't double-shift a pointer.
9570
92394119
PE
9571 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9572
dbdb9a7c
JB
95732011-05-06 Juanma Barranquero <lekktu@gmail.com>
9574
9575 * gnutls.c (DEF_GNUTLS_FN):
9576 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9577
db7a0b4f
AS
95782011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9579
9580 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9581 marker. (Bug#8610)
9582
cd394be1 95832011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9584
9585 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9586 New version that can reserve upto 2GB of heap space.
9587
f7ff1b0f 95882011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9589
9590 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9591
639c109b
TZ
95922011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9593
9594 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9595 `gnutls_certificate_set_x509_key_file'.
9596
d2127135
JB
95972011-05-05 Juanma Barranquero <lekktu@gmail.com>
9598
9599 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9600 Update dependencies.
9601
e968f4f3
JB
96022011-05-04 Juanma Barranquero <lekktu@gmail.com>
9603
9604 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9605 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9606 Remove unused parameter `fildes'.
9607 * process.c (read_process_output, send_process): Don't pass it.
9608
84d358f0
JB
96092011-05-04 Juanma Barranquero <lekktu@gmail.com>
9610
9611 Fix previous change: the library cache is defined in w32.c.
9612 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9613 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9614
0898ca10
JB
96152011-05-04 Juanma Barranquero <lekktu@gmail.com>
9616
9617 Implement dynamic loading of GnuTLS on Windows.
9618
9619 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9620 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9621 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9622 Declare.
9623
9624 * gnutls.c (Qgnutls_dll): Define.
9625 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9626 (gnutls_*): Declare function pointers.
9627 (init_gnutls_functions): New function to initialize function pointers.
9628 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9629 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9630 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9631 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9632 (emacs_gnutls_write, emacs_gnutls_read)
9633 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9634 (Fgnutls_available_p): New function.
9635 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9636 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9637 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9638
9639 * image.c: Include w32.h.
9640 (Vimage_type_cache): Delete.
9641 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9642 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9643 (w32_delayed_load): Move to w32.c.
9644
9645 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9646
9647 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9648 (w32_delayed_load): Move from image.c. When loading a library, record
9649 its filename in the :loaded-from property of the library id.
9650 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9651 Initialize and staticpro them.
9652 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9653
9654 * process.c: Include lisp.h before w32.h, not after.
9655 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9656 instead of gnutls_record_check_pending.
9657
9658 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9659
ff4de4aa
TZ
96602011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9661
9662 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9663 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9664 as passed in.
9665
abe95abb
JD
96662011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9667
9668 * xterm.c (x_set_frame_alpha): Do not set property on anything
9669 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9670
e16e55d4
JB
96712011-05-02 Juanma Barranquero <lekktu@gmail.com>
9672
9673 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9674
bafcf6a5
JB
96752011-05-02 Juanma Barranquero <lekktu@gmail.com>
9676
9677 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9678 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9679 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9680 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9681 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9682 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9683 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9684 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9685 (Qgnutls_bootprop_callbacks_verify): Make static.
9686
e7a6747f
AS
96872011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9688
19ed11ba
AS
9689 * callproc.c: Indentation fixup.
9690
e7a6747f 9691 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9692 (wait_for_termination, interruptible_wait_for_termination):
9693 Move after wait_for_termination_1.
e7a6747f 9694
1ef14cb4
LMI
96952011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9696
9697 * sysdep.c (interruptible_wait_for_termination): New function
9698 which is like wait_for_termination, but allows keyboard
9699 interruptions.
9700
9701 * callproc.c (Fcall_process): Add (:file "file") as an option for
9702 the STDOUT buffer.
9703 (Fcall_process_region): Ditto.
9704
330d880c
EZ
97052011-04-30 Eli Zaretskii <eliz@gnu.org>
9706
8db90b73
EZ
9707 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9708 rather than `XVECTOR (FOO)->size'.
9709
330d880c
EZ
9710 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9711 inttypes.h, as a gnulib replacement is used if it not available in
9712 system headers.
9713
15cbd324
EZ
97142011-04-21 Eli Zaretskii <eliz@gnu.org>
9715
9716 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9717 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9718 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9719
9720 * coding.c (coding_alloc_by_realloc): Error out if destination
9721 will grow beyond MOST_POSITIVE_FIXNUM.
9722 (decode_coding_emacs_mule): Abort if there isn't enough place in
9723 charbuf for the composition carryover bytes. Reserve an extra
9724 space for up to 2 characters produced in a loop.
9725 (decode_coding_iso_2022): Abort if there isn't enough place in
9726 charbuf for the composition carryover bytes.
9727
97282011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9729
ae940cca
EZ
9730 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9731 aborting when %lld or %lll format is passed.
9732 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9733 %llo or %llx format is passed. (Bug#8545)
9734
03ab8921
EZ
9735 * window.c (window_scroll_line_based): Use a marker instead of
9736 simple variables to record original value of point. (Bug#7952)
9737
afda1437
EZ
9738 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9739 produced by %s or %c overflows available buffer space. (Bug#8545)
9740
f76dee0c
PE
97412011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9742
9743 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9744 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9745
fdc5744d
JB
97462011-04-28 Juanma Barranquero <lekktu@gmail.com>
9747
9748 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9749
638f053a
JB
97502011-04-28 Juanma Barranquero <lekktu@gmail.com>
9751
9752 * keyboard.c (Qdelayed_warnings_hook): Define.
9753 (command_loop_1): Run `delayed-warnings-hook'
9754 if Vdelayed_warnings_list is non-nil.
9755 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9756 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9757
d178f871
EZ
97582011-04-28 Eli Zaretskii <eliz@gnu.org>
9759
9760 * doprnt.c (doprnt): Don't return value smaller than the buffer
9761 size if the message was truncated. (Bug#8545).
9762
b124fd93
JB
97632011-04-28 Juanma Barranquero <lekktu@gmail.com>
9764
9765 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9766 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9767
e810457d
PE
97682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9769
9770 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9771
ea51cceb
JB
97722011-04-27 Juanma Barranquero <lekktu@gmail.com>
9773
9774 * makefile.w32-in: Update dependencies.
9775
94dcfacf
EZ
97762011-04-27 Eli Zaretskii <eliz@gnu.org>
9777
9778 Improve `doprnt' and its usage. (Bug#8545)
9779 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9780 `format_end'. Remove support for %l as a conversion specifier.
9781 Don't use xrealloc. Improve diagnostics when the %l size modifier
9782 is used. Update the commentary.
9783
9784 * eval.c (verror): Simplify calculation of size_t.
9785
9786 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9787 messages.
9788
f61f41d7
PE
97892011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9790
9791 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9792 change.
9793
96fb4434
PE
97942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9795
9796 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9797 This makes this file independent of the recent pseudovector change.
9798
671875da 97992011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9800
69e9b5a3
PE
9801 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9802
b5f869a7 9803 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9804 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9805 Remove unused local.
c8926152 9806 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9807
841a1577 9808 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9809 GCC 4.6.0 optimizes based on type-based alias analysis.
9810 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9811 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9812 != &v->size, and therefore "v->size = 1; b->size = 2; return
9813 v->size;" must therefore return 1. This assumption is incorrect
9814 for Emacs, since it type-puns struct Lisp_Vector * with many other
9815 types. To fix this problem, this patch adds a new type struct
f904488f 9816 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9817 and pseudovectors, and helps optimizing compilers not get fooled
9818 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9819 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9820 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9821 the size member.
eab3844f
PE
9822 (XSETPVECTYPE): Rewrite in terms of new macro.
9823 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9824 This is a bit clearer, and further avoids the possibility of
9825 undesirable aliasing.
9826 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9827 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9828 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9829 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9830 (ASIZE): Now uses header.size rather than size.
9831 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9832 to avoid the hassle of writing XVECTOR (foo)->header.size.
9833 (struct vectorlike_header): New type.
eab3844f
PE
9834 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9835 object, to help avoid aliasing.
9836 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9837 (SUBRP): Likewise, since Lisp_Subr is a special case.
9838 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9839 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9840 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9841 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9842 changed to be "header.size" and "header.next".
9843 * buffer.h (struct buffer): Likewise.
9844 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9845 * frame.h (struct frame): Likewise.
9846 * process.h (struct Lisp_Process): Likewise.
9847 * termhooks.h (struct terminal): Likewise.
9848 * window.c (struct save_window_data, struct saved_window): Likewise.
9849 * window.h (struct window): Likewise.
9850 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9851 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9852 * buffer.c (init_buffer_once): Likewise.
9853 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9854 special case.
9855 * process.c (Fformat_network_address): Use local var for size,
9856 for brevity.
9857
0df1eac5
PE
9858 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9859
847ab9d1 9860 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9861 * data.c (atof): Remove decl; no longer used or needed.
9862 (digit_to_number): Move to lread.c.
9863 (Fstring_to_number): Use new string_to_number function, to be
9864 consistent with how the Lisp reader treats infinities and NaNs.
9865 Do not assume that floating-point numbers represent EMACS_INT
9866 without losing information; this is not true on most 64-bit hosts.
9867 Avoid double-rounding errors, by insisting on integers when
9868 parsing non-base-10 numbers, as the documentation specifies.
9869 * lisp.h (string_to_number): New decl, replacing ...
9870 (isfloat_string): Remove.
bc0a5c13 9871 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9872 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9873 appears to have been a coding error. Similarly, do not accept
9874 strings like +-1e0 as floating point numbers. Do not report
9875 overflow for integer overflows unless the base is not 10 which
9876 means we have no simple and reliable way to continue.
9877 Break out the floating-point parsing into a new
9878 function string_to_number, so that Fstring_to_number parses
9879 floating point numbers consistently with the Lisp reader.
04f2d78b 9880 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9881 (E_CHAR, EXP_INT): Remove, replacing with ...
9882 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9883 (string_to_number): New function, replacing isfloat_string.
9884 This function checks for valid syntax and produces the resulting
9885 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9886 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9887 so that overflow for non-base-10 numbers is reported only when
9888 there's no portable and simple way to convert to floating point.
452f4150 9889
67769ffc
PE
9890 * textprop.c (set_text_properties_1): Rewrite for clarity,
9891 and to avoid GCC warning about integer overflow.
9892
c20db43f
PE
9893 * intervals.h (struct interval): Use EMACS_INT for members
9894 where EMACS_UINT might cause problems. See
9895 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9896 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9897 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9898 All uses changed.
37aa2f85
PE
9899 (offset_intervals): Tell GCC not to worry about length overflow
9900 when negating a negative length.
c20db43f 9901
2538aa2f
PE
9902 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9903 (overrun_check_free): Likewise.
9904
f2d3008d
PE
9905 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9906 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9907 word size.
9908
ec8df744
PE
9909 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9910 (gnutls_make_error): Rename local to avoid shadowing.
9911 (gnutls_emacs_global_deinit): ifdef out; not used.
9912 (Fgnutls_boot): Use const for pointer to readonly storage.
9913 Comment out unused local. Fix pointer signedness problems.
9914
640ee02d
PE
9915 * lread.c (openp): Don't stuff size_t into an 'int'.
9916 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9917 about possible signed overflow.
9918
6048fb2a
PE
9919 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9920 (GDK_KEY_g): Don't define if already defined.
9921 (xg_prepare_tooltip): Avoid pointer signedness problem.
9922 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9923
fa3c87e1
PE
9924 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9925 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9926
2172544b
PE
9927 * xfns.c (Fx_window_property): Simplify a bit,
9928 to make a bit faster and to avoid GCC 4.6.0 warning.
9929 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9930
9b821a21
PE
9931 * fns.c (internal_equal): Don't assume size_t fits in int.
9932
3c616cfa
PE
9933 * alloc.c (compact_small_strings): Tighten assertion a little.
9934
c2982e87
PE
9935 Replace pEd with more-general pI, and fix some printf arg casts.
9936 * lisp.h (pI): New macro, generalizing old pEd macro to other
9937 conversion specifiers. For example, use "...%"pI"d..." rather
9938 than "...%"pEd"...".
9939 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9940 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9941 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9942 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9943 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9944 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9945 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9946 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9947 64-bit hosts.
9948 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9949 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9950 * print.c (safe_debug_print, print_object): Likewise.
9951 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9952 to int.
6f04d126
PE
9953 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9954 avoiding the 0 flag, which is not portable.
c2982e87
PE
9955 * process.c (Fmake_network_process): Use pI to avoid cast.
9956 * region-cache.c (pp_cache): Likewise.
9957 * xdisp.c (decode_mode_spec): Likewise.
9958 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9959 behavior on 64-bit hosts with printf arg.
6f04d126 9960 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9961 (x_stop_queuing_selection_requests): Likewise.
9962 (x_get_window_property): Don't truncate byte count to an 'int'
9963 when tracing.
0b432f21 9964
5e073ec7
PE
9965 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9966 here, since it parses constructs like leading '-' and spaces,
9967 which are not wanted; and it overflows with large numbers.
9968 Instead, simply match F[0-9]+, which is what is wanted anyway.
9969
36372bf9
PE
9970 * alloc.c: Remove unportable assumptions about struct layout.
9971 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9972 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9973 (allocate_vectorlike, make_pure_vector): Use the new macros,
9974 plus offsetof, to remove unportable assumptions about struct layout.
9975 These assumptions hold on all porting targets that I know of, but
9976 they are not guaranteed, they're easy to remove, and removing them
9977 makes further changes easier.
9978
0b432f21
PE
9979 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9980 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9981 (string_overrun_cookie): Now const. Use initializers that
9982 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9983 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9984 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9985 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9986 multiple of sizeof (EMACS_INT); it need not be, if
9987 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9988 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9989
895009e1
JB
99902011-04-26 Juanma Barranquero <lekktu@gmail.com>
9991
9992 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9993
6a7a1b0b
TZ
99942011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9995
9996 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9997 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9998 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9999
841a1577 100002011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10001
10002 * lisp.h (Qdebug): List symbol.
895009e1 10003 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10004 * keyboard.c (debug-on-event): New variable.
10005 (handle_user_signal): Break into debugger when debug-on-event
10006 matches the current signal symbol.
10007
f2d3ba6f
DN
100082011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10009
10010 * alloc.c (check_sblock, check_string_bytes)
10011 (check_string_free_list): Convert to standard C.
10012
42ce4c63
TZ
100132011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10014
10015 * w32.c (emacs_gnutls_push): Fix typo.
10016
825cd63c
EZ
100172011-04-25 Eli Zaretskii <eliz@gnu.org>
10018
fb11d64d
EZ
10019 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10020 "cast to pointer from integer of different size".
10021
825cd63c
EZ
10022 Improve doprnt and its use in verror. (Bug#8545)
10023 * doprnt.c (doprnt): Document the set of format control sequences
10024 supported by the function. Use SAFE_ALLOCA instead of always
10025 using `alloca'.
10026
10027 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10028 is one byte too soon. Don't use xrealloc; instead xfree and
10029 xmalloc anew.
10030
e061a11b
TZ
100312011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10032
10033 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10034 callbacks stage.
10035
10036 * gnutls.c: Renamed global_initialized to
10037 gnutls_global_initialized. Added internals for the
10038 :verify-hostname-error, :verify-error, and :verify-flags
10039 parameters of `gnutls-boot' and documented those parameters in the
10040 docstring. Start callback support.
9173deec
JB
10041 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10042 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10043 on error. Return error code.
e061a11b
TZ
10044 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10045 (emacs_gnutls_read): Likewise.
10046 (Fgnutls_boot): Return handshake error code.
10047 (emacs_gnutls_handle_error): New function.
10048 (wsaerror_to_errno): Likewise.
10049
10050 * w32.h (emacs_gnutls_pull): Add prototype.
10051 (emacs_gnutls_push): Likewise.
10052
10053 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10054 (emacs_gnutls_push): Likewise.
10055
100562011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10057
10058 * process.c (wait_reading_process_output): Check if GnuTLS
10059 buffered some data internally if no FDs are set for TLS
10060 connections.
10061
10062 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10063 (LIBS): Link to USER_LIBS.
10064 ($(BLD)/gnutls.$(0)): New target.
10065
fa6996bc
EZ
100662011-04-24 Eli Zaretskii <eliz@gnu.org>
10067
eb35682e
EZ
10068 * xdisp.c (handle_single_display_spec): Rename the
10069 display_replaced_before_p argument into display_replaced_p, to
10070 make it consistent with the commentary. Fix typos in the
10071 commentary.
10072
e2ad650c
EZ
10073 * textprop.c (syms_of_textprop): Remove dead code.
10074 (copy_text_properties): Delete obsolete commentary about an
10075 interface that was deleted long ago. Fix typos in the description
10076 of arguments.
10077
1b2de274
EZ
10078 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10079 to changes in oldXMenu/XMenu.h from 2011-04-16.
10080 <menu_help_message, prev_menu_help_message>: Constify.
10081 (IT_menu_make_room): menu->help_text is now `const char **';
10082 adjust.
10083
10084 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10085 to changes in oldXMenu/XMenu.h from 2011-04-16.
10086 (struct XMenu): Declare `help_text' `const char **'.
10087
10088 * xfaces.c <Qunspecified>: Make extern again.
10089
10090 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10091 required by POSIX.
1b2de274 10092
762b15be
EZ
10093 * doc.c (get_doc_string): Improve the format passed to `error'.
10094
10095 * doprnt.c (doprnt): Improve commentary.
10096
10097 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10098
10099 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10100 them with etags.
10101
f1052e5d
EZ
10102 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10103 changes in globals.h immediately force recompilation.
762b15be
EZ
10104 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10105 $(CURDIR)/s/ms-w32.h.
10106 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10107
fa6996bc
EZ
10108 * character.c (Fchar_direction): Function deleted.
10109 (syms_of_character): Don't defsubr it.
10110 <char-direction-table>: Deleted.
10111
e6c3da20
EZ
101122011-04-23 Eli Zaretskii <eliz@gnu.org>
10113
10114 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10115 * doprnt.c: Include limits.h.
10116 (SIZE_MAX): New macro.
04f2d78b
CB
10117 (doprnt): Return a size_t value. 2nd arg is now size_t.
10118 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10119 Improve overflow protection. Support `l' modifier for integer
10120 conversions. Support %l conversion. Don't assume an EMACS_INT
10121 argument for integer conversions and for %c.
10122
10123 * lisp.h (doprnt): Restore prototype.
10124
10125 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10126 $(SRC)/character.h.
10127
10128 * Makefile.in (base_obj): Add back doprnt.o.
10129
10130 * deps.mk (doprnt.o): Add back prerequisites.
10131 (callint.o): Depend on character.h.
10132
10133 * eval.c (internal_lisp_condition_case): Include the handler
10134 representation in the error message.
10135 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10136 when breaking from the loop.
10137
10138 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10139
10140 * callint.c (Fcall_interactively): When displaying error message
10141 about invalid control letter, pass the character's codepoint, not
10142 a pointer to its multibyte form. Improve display of the character
10143 in octal and display also its hex code.
10144
10145 * character.c (char_string): Use %x to display the (unsigned)
10146 codepoint of an invalid character, to avoid displaying a bogus
10147 negative value.
10148
10149 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10150 `error', not SYMBOL_NAME itself.
10151
10152 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10153 character arguments to `error'.
10154
10155 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10156 to `error' in error message about FINAL_CHAR argument. Make sure
10157 FINAL_CHAR is a character, and use %c when it is passed as
10158 argument to `error'.
10159
4ffd0d6b 101602011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10161
10162 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10163
10164 * w32.c: Include <time.h>.
10165 (sys_localtime): New function.
10166
4ffd0d6b 101672011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10168
10169 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10170
4ffd0d6b 10171 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10172
4ffd0d6b 101732011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10174
4ffd0d6b
GM
10175 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10176 zombies (Bug#8467).
aac0c6e3 10177
04c56954
EZ
101782011-04-19 Eli Zaretskii <eliz@gnu.org>
10179
10180 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10181 gl_state.e_property when gl_state.object is Qt.
10182
10183 * insdel.c (make_gap_larger): Remove limitation of buffer size
10184 to <= INT_MAX.
10185
16a43933
CY
101862011-04-18 Chong Yidong <cyd@stupidchicken.com>
10187
10188 * xdisp.c (lookup_glyphless_char_display)
10189 (produce_glyphless_glyph): Handle cons cell entry in
10190 glyphless-char-display.
10191 (Vglyphless_char_display): Document it.
10192
10193 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10194 glyphless-char-display.
10195
4581706e
CY
101962011-04-17 Chong Yidong <cyd@stupidchicken.com>
10197
10198 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10199
10200 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10201
10202 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10203 definition for no-X builds.
10204
4887c6e2 102052011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10206
fd35b6f9
PE
10207 Static checks with GCC 4.6.0 and non-default toolkits.
10208
5c1ccb01
PE
10209 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10210
006c5daa
PE
10211 * process.c (keyboard_bit_set): Define only if SIGIO.
10212 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10213 (send_process): Repair possible setjmp clobbering.
10214
efc736d3
PE
10215 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10216
4e2fe2e6
PE
10217 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10218
f97334a2
PE
10219 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10220
4e75f29d
PE
10221 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10222 Define only if needed.
10223
90efadd1
PE
10224 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10225 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10226 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10227
3c647824
PE
10228 * dispextern.h (struct redisplay_interface): Rename param
10229 to avoid shadowing.
e264f262 10230 * termhooks.h (struct terminal): Likewise.
761383f4 10231 * xterm.c (xembed_send_message): Likewise.
3c647824 10232
b58c5c4a
PE
10233 * insdel.c (make_gap_smaller): Define only if
10234 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10235
cad59032
PE
10236 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10237 it.
10238
c339dc2e
PE
10239 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10240 so that we aren't warned about unused symbols.
10241
91a3e27b
PE
10242 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10243
399c71d3 10244 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10245
8ffc96f5
PE
10246 * xfns.c (x_real_positions): Mark locals as initialized.
10247
eef9bc79
PE
10248 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10249
098db9dd
PE
10250 * xterm.c: Fix problems found by static analysis with other toolkits.
10251 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10252 (x_dispatch_event): Declare static if USE_GTK, and
10253 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10254 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10255 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10256 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10257 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10258
eb18f6cc
PE
10259 * xmenu.c (menu_help_callback): Pointer type fixes.
10260 Use const pointers when pointing at readonly data. Avoid pointer
10261 signedness clashes.
10262 (FALSE): Remove unused macro.
10263 (update_frame_menubar): Remove unused decl.
10264
1fe72bf8
PE
10265 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10266
60d9e1db
PE
10267 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10268 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10269 (single_menu_item): Rename local to avoid shadowing.
10270
39261c26
PE
10271 * keyboard.c (make_lispy_event): Remove unused local var.
10272
018c5e19
PE
10273 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10274 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10275
63d2b86e
PE
10276 * bitmaps: Change bitmaps from unsigned char back to the X11
10277 compatible char. Avoid the old compiler warnings about
10278 out-of-range initializers by using, for example, '\xab' rather
10279 than 0xab.
10280
aefd87e1
PE
10281 * xgselect.c (xgselect_initialize): Check vs interface
10282 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10283
bf501fb9
PE
10284 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10285
e9829fdf
PE
10286 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10287 to read-only memory.
10288
1086c095
PE
10289 * fns.c (vector): Remove; this old hack is no longer needed.
10290
2baccd04 10291 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10292 Remove unused var.
dde42981 10293 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10294
72391843 10295 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10296
436c16df 10297 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10298 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10299 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10300
92bb796d 10301 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10302 (x_term_init): Remove local to avoid shadowing.
92bb796d 10303
764430a3 10304 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10305
10306 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10307 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10308
d1dfb56c
EZ
103092011-04-16 Eli Zaretskii <eliz@gnu.org>
10310
c4354cb4
EZ
10311 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10312
d1dfb56c
EZ
10313 Fix regex.c, syntax.c and friends for buffers > 2GB.
10314 * syntax.h (struct gl_state_s): Declare character position members
10315 EMACS_INT.
10316
10317 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10318
04f2d78b
CB
10319 * textprop.c (verify_interval_modification, interval_of):
10320 Declare arguments EMACS_INT.
d1dfb56c
EZ
10321
10322 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10323 EMACS_INT.
10324
10325 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10326
10327 * indent.c (Fvertical_motion): Local variable it_start is now
10328 EMACS_INT.
10329
10330 * regex.c (re_match, re_match_2, re_match_2_internal)
10331 (bcmp_translate, regcomp, regexec, print_double_string)
10332 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10333 (re_compile_pattern, re_exec): Declare arguments and local
10334 variables `size_t' and `ssize_t' and return values `regoff_t', as
10335 appropriate.
10336 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10337 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10338 <compile_stack_type>: `size' and `avail' are now `size_t'.
10339
10340 * regex.h <regoff_t>: Use ssize_t, not int.
10341 (re_search, re_search_2, re_match, re_match_2): Arguments that
10342 specify buffer/string position and length are now ssize_t and
10343 size_t. Return type is regoff_t.
10344
613052cd
BK
103452011-04-16 Ben Key <bkey76@gmail.com>
10346
10347 * nsfont.m: Fixed bugs in ns_get_family and
10348 ns_descriptor_to_entity that were caused by using free to
10349 deallocate memory blocks that were allocated by xmalloc (via
10350 xstrdup). This caused Emacs to crash when compiled with
10351 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10352 --enable-checking=xmallocoverrun). xfree is now used to
10353 deallocate these memory blocks.
10354
4170f62f 103552011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10356
71b41406
PE
10357 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10358
9587a89d
PE
10359 emacs_write: Accept and return EMACS_INT for sizes.
10360 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10361 et seq.
10362 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10363 Accept and return EMACS_INT.
10364 (emacs_gnutls_write): Return the number of bytes written on
10365 partial writes.
10366 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10367 (emacs_read, emacs_write): Remove check for negative size, as the
10368 Emacs source code has been audited now.
9587a89d
PE
10369 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10370 (emacs_read, emacs_write): Use it.
273a5f82
PE
10371 * process.c (send_process): Adjust to the new signatures of
10372 emacs_write and emacs_gnutls_write. Do not attempt to store
10373 a byte offset into an 'int'; it might overflow.
9587a89d 10374 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10375
3e047f51
PE
10376 * sound.c: Don't assume sizes fit in 'int'.
10377 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10378 Return EMACS_INT, not int.
3e047f51 10379 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10380 Accept EMACS_INT, not int.
10381 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10382 record read return values.
10383
cc39a9db
BK
103842011-04-15 Ben Key <bkey76@gmail.com>
10385
c9d0ec6d
JB
10386 * keyboard.c (Qundefined): Don't declare static since it is used
10387 in nsfns.m.
10388 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10389 static since they are used in nsfont.m.
cc39a9db 10390
6c60eb9f
SM
103912011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10392
10393 * process.c (Qprocessp): Don't declare static.
10394 * lisp.h (Qprocessp): Declare again.
10395
7990b61a
JB
103962011-04-15 Juanma Barranquero <lekktu@gmail.com>
10397
10398 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10399
5d4cb038
PE
104002011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10401
8bd7b830 10402 Improve C-level modularity by making more things 'static'.
cd64ea1d 10403
e3b27b31
PE
10404 Don't publish debugger-only interfaces to other modules.
10405 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10406 (verify_bytepos, count_markers): Move decls to the only modules
10407 that need them.
10408 * region-cache.h (pp_cache): Likewise.
10409 * window.h (check_all_windows): Likewise.
10410 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10411
5d4cb038
PE
10412 * sysdep.c (croak): Now static, if
10413 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10414 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10415
10416 * alloc.c (refill_memory_reserve): Now static if
10417 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10418 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10419
e87b6180
PE
10420 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10421 Define only if USE_LUCID.
10422
ac64929e
PE
10423 * xrdb.c (x_customization_string, x_rm_string): Now static.
10424
6f37259d
PE
10425 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10426 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10427
1683e3ab
PE
10428 * xdisp.c (draw_row_with_mouse_face): Now static.
10429 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10430
de9c2632
PE
10431 * window.h (check_all_windows): Mark externally visible.
10432
2b96acb7
PE
10433 * window.c (window_deletion_count): Now static.
10434
10435 * undo.c: Make symbols static if they're not exported.
10436 (last_undo_buffer, last_boundary_position, pending_boundary):
10437 Now static.
10438
50436f33
PE
10439 * textprop.c (interval_insert_behind_hooks): Now static.
10440 (interval_insert_in_front_hooks): Likewise.
10441
64520e5c
PE
10442 * term.c: Make symbols static if they're not exported.
10443 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10444 (max_frame_lines, tty_set_terminal_modes):
10445 (tty_reset_terminal_modes, tty_turn_off_highlight):
10446 (get_tty_terminal): Now static.
10447 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10448 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10449 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10450 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10451 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10452
1fa53021
PE
10453 * sysdep.c: Make symbols static if they're not exported.
10454 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10455 Now static.
10456 (sigprocmask_set, full_mask): Remove; unused.
10457 (wait_debugging): Mark as visible.
10458 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10459 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10460
d4b43b22
PE
10461 * syntax.c (syntax_temp): Define only if !__GNUC__.
10462
b7c513d0
PE
10463 * sound.c (current_sound_device, current_sound): Now static.
10464
989b29ad
PE
10465 * search.c (searchbufs, searchbuf_head): Now static.
10466
13a55a78
PE
10467 * scroll.c (scroll_cost): Remove; unused.
10468 * dispextern.h (scroll_cost): Remove decl.
10469
de68a1fc
PE
10470 * region-cache.h (pp_cache): Mark as externally visible.
10471
40ccffa6
PE
10472 * process.c: Make symbols static if they're not exported.
10473 (process_tick, update_tick, create_process, chan_process):
10474 (Vprocess_alist, proc_buffered_char, datagram_access):
10475 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10476 (deactivate_process): Mark defn as static, as well as decl.
10477 * lisp.h (create_process): Remove decl.
10478 * process.h (chan_process, Vprocess_alist): Remove decls.
10479
ad64fc97
PE
10480 * print.c: Make symbols static if they're not exported.
10481 (print_depth, new_backquote_output, being_printed, print_buffer):
10482 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10483 (print_interval, print_number_index, initial_stderr_stream):
10484 Now static.
10485 * lisp.h (Fprinc): Remove decl.
10486 (debug_output_compilation_hack): Mark as externally visible.
10487
adddb265
PE
10488 * sysdep.c (croak): Move decl from here to syssignal.h.
10489 * syssignal.h (croak): Put it here, so the API can be checked when
10490 'croak' is called from dissociate_if_controlling_tty.
10491
1717ede2
PE
10492 * minibuf.c: Make symbols static if they're not exported.
10493 (minibuf_save_list, choose_minibuf_frame): Now static.
10494 * lisp.h (choose_minibuf_frame): Remove decl.
10495
fa5fb2bc
PE
10496 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10497
1e3890d1
PE
10498 * lread.c: Make symbols static if they're not exported.
10499 (read_objects, initial_obarray, oblookup_last_bucket_number):
10500 Now static.
10501 (make_symbol): Remove; unused.
10502 * lisp.h (initial_obarray, make_symbol): Remove decls.
10503
8a1414fa
PE
10504 * keyboard.c: Make symbols static if they're not exported.
10505 (single_kboard, recent_keys_index, total_keys, recent_keys):
10506 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10507 (this_single_command_key_start, echoing, last_auto_save):
10508 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10509 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10510 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10511 (Vlispy_mouse_stem, double_click_count):
10512 Now static.
10513 (force_auto_save_soon): Define only if SIGDANGER.
10514 (ignore_mouse_drag_p): Now static if
10515 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10516 (print_help): Remove; unused.
10517 (stop_character, last_timer_event): Mark as externally visible.
10518 * keyboard.h (ignore_mouse_drag_p): Declare only if
10519 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10520 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10521 * lisp.h (echoing): Remove decl.
10522 (force_auto_save_soon): Declare only if SIGDANGER.
10523 * xdisp.c (redisplay_window): Simplify code, to make it more
10524 obvious that ignore_mouse_drag_p is not accessed if !defined
10525 USE_GTK && !defined HAVE_NS.
10526
93ea6e8f
PE
10527 * intervals.c: Make symbols static if they're not exported.
10528 (merge_properties_sticky, merge_interval_right, delete_interval):
10529 Now static.
10530 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10531
77382fcc
PE
10532 * insdel.c: Make symbols static if they're not exported.
10533 However, leave prepare_to_modify_buffer alone. It's never
10534 called from outside this function, but that appears to be a bug.
10535 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10536 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10537 (adjust_after_replace_noundo): Remove; unused.
10538 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10539 (signal_before_change): Remove decls.
77382fcc 10540
9306c32e
PE
10541 * indent.c (val_compute_motion, val_vmotion): Now static.
10542
cd44d2eb
PE
10543 * image.c: Make symbols static if they're not exported.
10544 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10545 if USE_GTK.
10546 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10547 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10548
ad9a7a06
PE
10549 * fringe.c (standard_bitmaps): Now static.
10550 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10551
81626931
PE
10552 * frame.c: Make symbols static if they're not exported.
10553 (x_report_frame_params, make_terminal_frame): Now static.
10554 (get_frame_param): Now static, unless HAVE_NS.
10555 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10556 (x_get_resource_string): Remove; not used.
10557 * frame.h (make_terminal_frame, x_report_frame_params):
10558 (x_get_resource_string); Remove decls.
10559 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10560 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10561
239f9db9
PE
10562 * font.c, fontset.c: Make symbols static if they're not exported.
10563 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10564 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10565 * font.c (font_close_object): Now static.
10566 * font.h (font_close_object): Remove.
10567 * fontset.c (FONTSET_OBJLIST): Remove.
10568 (free_realized_fontset) #if-0 the body, which does nothing.
10569 (face_suitable_for_char_p): #if-0, as it's never called.
10570 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10571 * xfaces.c (face_at_string_position):
10572 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10573 since 0 is always ASCII.
10574
dfcf3579
PE
10575 * fns.c (weak_hash_tables): Now static.
10576
5045092b
PE
10577 * fileio.c: Make symbols static if they're not exported.
10578 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10579 (Vwrite_region_annotation_buffers): Now static.
10580
57a96f5c
PE
10581 * eval.c: Make symbols static if they're not exported.
10582 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10583 * lisp.h (backtrace_list): Remove decl.
10584
35f08c38
PE
10585 * emacs.c: Make symbols static if they're not exported.
10586 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10587 (fatal_error_code, fatal_error_signal_hook, standard_args):
10588 Now static.
10589 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10590 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10591 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10592 * lisp.h (fatal_error_signal_hook): Remove decl.
10593 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10594
f44bd759
PE
10595 * editfns.c: Move a (normally-unused) function to its only use.
10596 * editfns.c, lisp.h (get_operating_system_release): Remove.
10597 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10598 worth the hassle of breaking this out.
10599
b532497d
PE
10600 * xterm.c: Make symbols static if they're not exported.
10601 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10602 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10603 (x_destroy_window, x_delete_display):
10604 Now static.
10605 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10606 (x_mouse_leave): Remove; unused.
10607 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10608 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10609 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10610 Remove decls.
10611 (x_mouse_leave): Declare only if WINDOWSNT.
10612 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10613 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10614 USE_X_TOOLKIT.
10615
1675728f
PE
10616 * ftxfont.c: Make symbols static if they're not exported.
10617 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10618 HAVE_FREETYPE.
10619 * font.h (ftxfont_driver): Likewise.
10620
e4cebfca
PE
10621 * xfns.c: Make symbols static if they're not exported.
10622 (x_last_font_name, x_display_info_for_name):
10623 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10624 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10625 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10626 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10627 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10628 (last_show_tip_args): Now static.
10629 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10630 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10631 (x_screen_planes): Remove; unused.
10632 * dispextern.h (x_screen_planes): Remove decl.
10633
5bf46f05
PE
10634 * dispnew.c: Make symbols static if they're not exported.
10635 * dispextern.h (redraw_garbaged_frames, scrolling):
10636 (increment_row_positions): Remove.
10637 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10638 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10639 Now static.
10640 (redraw_garbaged_frames): Remove; unused.
10641
435f4c28
PE
10642 * xfaces.c: Make symbols static if they're not exported.
10643 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10644 Remove decls.
10645 * xterm.h (defined_color): Remove decls.
10646 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10647 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10648 (menu_face_changed_default, defined_color, free_realized_face):
10649 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10650 (ascii_face_of_lisp_face): Remove; unused.
10651
8524aef3
PE
10652 * xdisp.c: Make symbols static if they're not exported.
10653 * dispextern.h (scratch_glyph_row, window_box_edges):
10654 (glyph_to_pixel_coords, set_cursor_from_row):
10655 (get_next_display_element, set_iterator_to_next):
10656 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10657 (show_mouse_face): Remove decls
10658 * frame.h (message_buf_print): Likewise.
10659 * lisp.h (pop_message, set_message, check_point_in_composition):
10660 Likewise.
10661 * xterm.h (set_vertical_scroll_bar): Likewise.
10662 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10663 (message_buf_print, scratch_glyph_row, displayed_buffer):
10664 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10665 (get_next_display_element, show_mouse_face, window_box_edges):
10666 (frame_to_window_pixel_xy, check_point_in_composition):
10667 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10668 (glyph_to_pixel_coords): Remove; unused.
10669
16390cd2
PE
10670 * dired.c (file_name_completion): Now static.
10671
10672 * dbusbind.c (xd_in_read_queued_messages): Now static.
10673
a25f4dfa
PE
10674 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10675 * data.c (circular_list_error): Remove.
10676
14a9c8df
PE
10677 * commands.h (last_point_position, last_point_position_buffer):
10678 (last_point_position_window): Remove decls.
10679 * keyboard.c: Make these variables static.
10680
04f2d78b
CB
10681 * coding.h (coding, code_convert_region, encode_coding_gap):
10682 Remove decls.
74ab6df5
PE
10683 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10684 (iso_code_class, detect_coding, code_convert_region): Now static.
10685 (encode_coding_gap): Remove; unused.
10686
38dfbee1
PE
10687 * chartab.c (chartab_chars, chartab_bits): Now static.
10688
a2cb4e63
PE
10689 * charset.h (charset_iso_8859_1): Remove decl.
10690 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10691 Now static.
10692
127198fd
PE
10693 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10694 * ccl.c (Vccl_program_table): Now static.
10695 (check_ccl_update): Remove; unused.
10696
d85b608f
PE
10697 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10698 * category.h: ... from here.
10699 * category.c (check_category_table, set_category_set): Now static.
10700
31cd66f3
PE
10701 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10702 * lisp.h: Remove these decls.
10703
c358e587
PE
10704 * buffer.c (buffer_count): Remove unused var.
10705
e78aecca
PE
10706 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10707 so that it's not optimized away.
10708 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10709 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10710 exported only to the debugger.
10711
e192d7d3 10712 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10713 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10714
92470028
PE
10715 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10716 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10717 was inaccessible from Lisp.
10718 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10719 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10720
244ed907
PE
10721 alloc.c: Import and export fewer symbols, and remove unused items.
10722 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10723 is defined.
10724 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10725 it's not optimized away by whole-program optimization.
10726 (message_enable_multibyte, free_misc): Remove.
10727 (catchlist, handlerlist, mark_backtrace):
10728 Declare only if BYTE_MARK_STACK.
10729 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10730 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10731 (message_enable_multibyte): Remove decl.
10732 (free_misc, interval_free_list, float_block, float_block_index):
10733 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10734 (cons_free_list, last_marked_index):
10735 Now static.
10736 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10737 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10738 (mark_backtrace): Define only if BYTE_MARK_STACK.
10739 * xdisp.c (message_enable_multibyte): Now static.
10740
61c2b50e 10741 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10742 This makes it easier for human readers (and static analyzers)
10743 to see whether these variables are used from other modules.
10744 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10745 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10746 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10747 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10748 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10749 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10750 * xmenu.c, xselect.c:
10751 Declare Q* vars static if they are not used in other modules.
10752 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10753 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10754 Remove decls of unexported vars.
10755 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10756
95c82688
PE
10757 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10758
16a97296
PE
10759 Make Emacs functions such as Fatom 'static' by default.
10760 This makes it easier for human readers (and static analyzers)
10761 to see whether these functions can be called from other modules.
10762 DEFUN now defines a static function. To make the function external
10763 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10764 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10765 (Finit_image_library):
16a97296
PE
10766 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10767 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10768 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10769 Remove decls, since these functions are now static.
10770 (Funintern, Fget_internal_run_time): New decls, since these functions
10771 were already external.
95c82688 10772
16a97296
PE
10773 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10774 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10775 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10776 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10777 * keyboard.c, keymap.c, lread.c:
10778 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10779 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10780 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10781 Mark functions with DEFUE instead of DEFUN,
10782 if they are used in other modules.
10783 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10784 decls for now-static functions.
10785 * buffer.h (Fdelete_overlay): Remove decl.
10786 * callproc.c (Fgetenv_internal): Mark as internal.
10787 * composite.c (Fremove_list_of_text_properties): Remove decl.
10788 (Fcomposition_get_gstring): New forward static decl.
10789 * composite.h (Fcomposite_get_gstring): Remove decl.
10790 * dired.c (Ffile_attributes): New forward static decl.
10791 * doc.c (Fdocumntation_property): New forward static decl.
10792 * eval.c (Ffetch_bytecode): New forward static decl.
10793 (Funintern): Remove extern decl; now in .h file where it belongs.
10794 * fileio.c (Fmake_symbolic_link): New forward static decl.
10795 * image.c (Finit_image_library): New forward static decl.
10796 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10797 * intervals.h (Fprevious_property_change):
10798 (Fremove_list_of_text_properties): Remove decls.
10799 * keyboard.c (Fthis_command_keys): Remove decl.
10800 (Fcommand_execute): New forward static decl.
10801 * keymap.c (Flookup_key): New forward static decl.
10802 (Fcopy_keymap): Now static.
10803 * keymap.h (Flookup_key): Remove decl.
10804 * process.c (Fget_process): New forward static decl.
10805 (Fprocess_datagram_address): Mark as internal.
10806 * syntax.c (Fsyntax_table_p): New forward static decl.
10807 (skip_chars): Remove duplicate decl.
10808 * textprop.c (Fprevious_property_change): New forward static decl.
10809 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10810 Now internal.
10811 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10812 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10813
785bbd42
PE
10814 * editfns.c (Fformat): Remove unreachable code.
10815
8b913b57
AS
108162011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10817
10818 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10819 change. (Bug#8496)
10820
a6744a35
EZ
108212011-04-13 Eli Zaretskii <eliz@gnu.org>
10822
10823 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10824 when at ZV. (Bug#8487)
10825
e7974947
AS
108262011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10827
baad03f0
AS
10828 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10829 (Bug#8437)
10830 * keyboard.c (parse_tool_bar_item): Likewise.
10831 * sound.c (sound_cleanup, alsa_close): Likewise.
10832 * termcap.c (tgetent): Likewise.
10833 * xfns.c (x_default_font_parameter): Likewise.
10834 * xsettings.c (read_and_apply_settings): Likewise.
10835
e7974947
AS
10836 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10837 (overrun_check_free): Protoize.
10838
28272684
PE
108392011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10840
10841 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10842 since callers should never pass a negative size.
10843 Change the signature to match that of plain 'read' and 'write'; see
10844 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10845 * lisp.h: Update prototypes of emacs_write and emacs_read.
10846
11997c76
EZ
108472011-04-11 Eli Zaretskii <eliz@gnu.org>
10848
10849 * xdisp.c (redisplay_window): Don't try to determine the character
10850 position of the scroll margin if the window start point w->startp
e896f03c 10851 is outside the buffer's accessible region. (Bug#8468)
11997c76 10852
8a2cbd72
EZ
108532011-04-10 Eli Zaretskii <eliz@gnu.org>
10854
10855 Fix write-region and its subroutines for buffers > 2GB.
10856 * fileio.c (a_write, e_write): Modify declaration of arguments and
10857 local variables to support buffers larger than 2GB.
10858 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10859
10860 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10861 argument, local variables, and return value.
10862
10863 * lisp.h: Update prototypes of emacs_write and emacs_read.
10864
10865 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10866
4073e537 108672011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10868
1ebfdcb6
PE
10869 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10870
b2ded58d
PE
10871 Fix more problems found by GCC 4.6.0's static checks.
10872
7d66342c
PE
10873 * xdisp.c (vmessage): Use a better test for character truncation.
10874
bbf47d44
PE
10875 * charset.c (load_charset_map): <, not <=, for optimization,
10876 and to avoid potential problems with integer overflow.
9248994d 10877 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10878 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10879 * editfns.c (Fformat): Likewise.
1e69125e 10880 * syntax.c (skip_chars): Likewise.
3befa583 10881
e3019616
PE
10882 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10883 This also lets GCC 4.6.0 generate slightly better loop code.
10884
becfa255
PE
10885 * callint.c (Fcall_interactively): <, not <=, for optimization.
10886 (Fcall_interactively): Count the number of arguments produced,
10887 not the number of arguments given. This is simpler and lets GCC
10888 4.6.0 generate slightly better code.
10889
dae0cd48
PE
10890 * ftfont.c: Distingish more carefully between FcChar8 and char.
10891 The previous code passed unsigned char * to a functions like
10892 strlen and xstrcasecmp that expect char *, which does not
10893 conform to the C standard.
10894 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10895 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10896 char * when the C standard requires it.
10897
76032d70
PE
10898 * keyboard.c (read_char): Remove unused var.
10899
eb3f1cc8
PE
10900 * eval.c: Port to Windows vsnprintf (Bug#8435).
10901 Include <limits.h>.
10902 (SIZE_MAX): Define if the headers do not.
10903 (verror): Do not give up if vsnprintf returns a negative count.
10904 Instead, grow the buffer. This ports to Windows vsnprintf, which
10905 does not conform to C99. Problem reported by Eli Zaretskii.
10906 Also, simplify the allocation scheme, by avoiding the need for
10907 calling realloc, and removing the ALLOCATED variable.
10908
70476b54
PE
10909 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10910
12020a9e
PE
10911 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10912 But keep the doprint source code for now, as we might revamp it
10913 and use it again (Bug#8435).
ea6c7ae6
PE
10914 * lisp.h (doprnt): Remove.
10915 * Makefile.in (base_obj): Remove doprnt.o.
10916 * deps.mk (doprnt.o): Remove.
10917
5fdb398c
PE
10918 error: Print 32- and 64-bit integers portably (Bug#8435).
10919 Without this change, on typical 64-bit hosts error ("...%d...", N)
10920 was used to print both 32- and 64-bit integers N, which relied on
10921 undefined behavior.
61bdb816 10922 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10923 * lisp.h (error, verror): Mark as printf-like functions.
10924 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10925 Report overflow in size calculations when allocating printf buffer.
10926 Do not truncate output string at its first null byte.
10927 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10928 Truncate the output at a character boundary, since vsnprintf does not
10929 do that.
10930 * charset.c (check_iso_charset_parameter): Convert internal
10931 character to string before calling 'error', since %c now has the
10932 printf meaning.
10933 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10934 overflow when computing char to be passed to 'error'. Do not
10935 pass Lisp_Object to 'error'; pass the integer instead.
10936 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10937 formatted with plain %d.
10938
b189fa66
PE
10939 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10940
bff87ef0
PE
10941 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10942
7e2cac20
PE
10943 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10944
ce4d90b5
PE
10945 * xterm.c (x_catch_errors): Remove duplicate declaration.
10946
266c9547
PE
10947 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10948
79c49ad2
PE
10949 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10950
368f4090
JM
109512011-04-10 Jim Meyering <meyering@redhat.com>
10952
10953 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10954 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10955 return ssize_t not "int", and use size_t as the buffer length.
10956 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10957 * gnutls.h: Update declarations.
10958 * process.c (read_process_output): Use ssize_t, to match.
10959 (send_process): Likewise.
10960
a32d4040
CY
109612011-04-09 Chong Yidong <cyd@stupidchicken.com>
10962
10963 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10964
8546720e 109652011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10966
04f2d78b
CB
10967 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10968 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10969
8546720e
GM
10970 * xterm.c (handle_one_xevent):
10971 * xmenu.c (create_and_show_popup_menu):
10972 * xselect.c (x_decline_selection_request)
10973 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10974
0a2f5c1a 109752011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10976
10977 Fix some uses of `int' instead of EMACS_INT.
10978 * search.c (string_match_1, fast_string_match)
10979 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10980 (scan_buffer, find_next_newline_no_quit)
10981 (find_before_next_newline, search_command, Freplace_match)
10982 (Fmatch_data): Make some `int' variables be EMACS_INT.
10983
10984 * xdisp.c (display_count_lines): 3rd argument and return value now
10985 EMACS_INT. All callers changed.
10986 (pint2hrstr): Last argument is now EMACS_INT.
10987
10988 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10989 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10990 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10991 (decode_coding_utf_16, decode_coding_emacs_mule)
10992 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10993 (decode_coding_ccl, decode_coding_charset)
10994 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10995 (decode_coding_iso_2022, decode_coding_emacs_mule)
10996 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10997 <char_offset, last_offset>: Declare EMACS_INT.
10998 (encode_coding_utf_8, encode_coding_utf_16)
10999 (encode_coding_emacs_mule, encode_invocation_designation)
11000 (encode_designation_at_bol, encode_coding_iso_2022)
11001 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11002 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11003 Declare EMACS_INT.
11004 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11005 (encode_invocation_designation): Last argument P_NCHARS is now
11006 EMACS_INT.
11007 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11008 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11009
11010 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11011 All users changed.
11012
11013 * ccl.c (Fccl_execute_on_string): Declare some variables
11014 EMACS_INT.
11015
8546720e 110162011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11017
11018 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11019
4e19a977
CS
110202011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11021
11022 * process.c (Fformat_network_address): Doc fix.
11023
87302331
R
110242011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11025
ee7683eb 11026 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11027
cbb59342
CY
110282011-04-08 Chong Yidong <cyd@stupidchicken.com>
11029
11030 * keyboard.c (read_char): Call Lisp function help-form-show,
11031 instead of using internal_with_output_to_temp_buffer.
11032 (Qhelp_form_show): New var.
e0d38eeb 11033 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11034
11035 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11036
11037 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11038
e67a13ab
CY
110392011-04-06 Chong Yidong <cyd@stupidchicken.com>
11040
04f2d78b
CB
11041 * process.c (Flist_processes): Remove to Lisp.
11042 (list_processes_1): Delete.
e67a13ab 11043
973f782d
EZ
110442011-04-06 Eli Zaretskii <eliz@gnu.org>
11045
7c106b1e
EZ
11046 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11047
973f782d
EZ
11048 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11049
41cf7d1a 110502011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11051
ca23cc88
PE
11052 Fix more problems found by GCC 4.6.0's static checks.
11053
f390e2d5
PE
11054 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11055
42eea0d0
PE
11056 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11057
b69769da 11058 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11059
f9541e84
PE
11060 * xdisp.c (vmessage): Mark as a printf-like function.
11061
13841b55
PE
11062 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11063
c136c10f
PE
11064 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11065
5e2d4a30
PE
11066 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11067 printf-like functions.
11068 (tiff_load): Add casts to remove these marks before passing them
11069 to system-supplied API.
11070
583f48b9
PE
11071 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11072
b25d760e
PE
11073 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11074 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11075 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11076 directly, rather than having caller test rule sign. This avoids
11077 some unnecessary tests.
11078 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11079 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11080 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11081
bc7b6697 11082 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11083 (xfont_open): Avoid unnecessary tests.
bc7b6697 11084
27ccc379
PE
11085 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11086
dcd5c89a
PE
11087 * composite.h, composite.c (composition_gstring_put_cache):
11088 Use EMACS_INT, not int, for length.
11089
b13a45c6
PE
11090 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11091 breaking out part of COMPOSITION_DECODE_RULE.
11092 (COMPOSITION_DECODE_RULE): Use it.
11093 * composite.c (get_composition_id): Remove unused local vars,
11094 by using the new macro.
11095
1e792e4d
PE
11096 * textprop.c (set_text_properties_1): Change while to do-while,
11097 since the condition is always true at first.
11098
dc6c6455 11099 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11100 (interval_deletion_adjustment): Return unsigned value.
11101 All uses changed.
dc6c6455 11102
aba7731a
PE
11103 * process.c (list_processes_1, create_pty, read_process_output):
11104 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11105 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11106 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11107 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11108 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11109
fdfc4bf3
PE
11110 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11111
fca8fe46 11112 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11113 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11114
06a0259a 11115 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11116 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11117 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11118
e7b9e80f
PE
11119 * print.c (print_error_message): Avoid int overflow.
11120
56201685
PE
11121 * font.c (font_list_entities): Redo for clarity,
11122 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11123
78834453 11124 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11125 (font_score): Avoid potential overflow in diff calculation.
78834453 11126
0bc0b309 11127 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11128 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11129
e610eaca
PE
11130 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11131
b895abce
PE
11132 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11133 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11134 can always succeed if overflow has undefined behavior.
11135
1f1d9321 11136 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11137 (wordify): Omit three unnecessary tests.
1f1d9321 11138
c59478bc
PE
11139 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11140 All callers changed. This avoids the need for an unused var.
11141
79b73827
PE
11142 * casefiddle.c (casify_region): Remove var that is set but not used.
11143
a4db5dfe
PE
11144 * dired.c (file_name_completion): Remove var that is set but not used.
11145
43aae36e
PE
11146 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11147
2a47c44d 11148 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11149 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11150
a37c69bf
PE
11151 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11152 Check for integer overflow on size calculations.
11153
328ab8e7
PE
11154 * buffer.c (Fprevious_overlay_change): Remove var that is set
11155 but not used.
11156
e5a2a5cb
PE
11157 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11158 Remove vars that are set but not used.
8d84a6eb 11159 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11160 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11161
a60e5f68
PE
11162 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11163
f661cb61 11164 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11165 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11166
f0397f5a
PE
11167 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11168 that are set but not used.
11169
8664db06 11170 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11171 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11172
6abdaa4a
PE
11173 * xselect.c (x_get_local_selection, x_handle_property_notify):
11174 Remove vars that are set but not used.
11175
0ce7538d 11176 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11177 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11178
9ae848fc
PE
11179 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11180 Remove var that is set but not used.
0b918413
PE
11181 (scroll_bar_windows_size): Now size_t, not int.
11182 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11183 Check for overflow.
9ae848fc 11184
a5a62657
PE
11185 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11186 (map_tty_color) [!defined MSDOS]: Likewise.
11187
5c5cdd39
PE
11188 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11189
66ebf983
PE
11190 * coding.c: Remove vars that are set but not used.
11191 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11192 All callers changed.
11193 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11194 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11195 (decode_coding_charset): Remove vars that are set but not used.
11196
1be4d761
PE
11197 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11198 that is set but not used.
11199
47553fa8
PE
11200 * print.c (print_object): Remove var that is set but not used.
11201
1f7196bf 11202 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11203 The gnulib version avoids calling malloc in the usual case,
11204 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11205 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11206 * filelock.c (current_lock_owner): Likewise.
11207 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11208 * sysdep.c: Include allocator.h, careadlinkat.h.
11209 (emacs_no_realloc_allocator): New static constant.
11210 (emacs_readlink): New function.
fdb61804
PE
11211 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11212 ../lib/careadlinkat.h.
d1fdcab7 11213
f84c17c7
SM
112142011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11215
11216 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11217 first non-nil return value).
11218
ef3862ad
JD
112192011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11220
11221 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11222 if not defined (Bug#8403).
11223
376a7006
JB
112242011-04-02 Juanma Barranquero <lekktu@gmail.com>
11225
11226 * xdisp.c (display_count_lines): Remove parameter `start',
11227 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11228 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11229 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11230 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11231 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11232 and thereabouts. All callers changed.
11233 (get_per_char_metric): Remove parameter `f', unused since
11234 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11235
6ca3801d
JM
112362011-04-02 Jim Meyering <meyering@redhat.com>
11237
11238 do not dereference NULL upon failed strdup
11239 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11240 (ns_get_family): Likewise.
11241
d8e2b5ba
JB
112422011-04-02 Juanma Barranquero <lekktu@gmail.com>
11243
11244 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11245
8c74fcbd
JD
112462011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11247
11248 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11249 later (Bug#8403).
11250
7200d79c
SM
112512011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11252
03408648 11253 Add lexical binding.
7200d79c 11254
03408648
SM
11255 * window.c (Ftemp_output_buffer_show): New fun.
11256 (Fsave_window_excursion):
11257 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11258
11259 * lread.c (lisp_file_lexically_bound_p): New function.
11260 (Fload): Bind Qlexical_binding.
11261 (readevalloop): Remove `evalfun' arg.
11262 Bind Qinternal_interpreter_environment.
11263 (Feval_buffer): Bind Qlexical_binding.
11264 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11265 Mark as dynamic.
11266 (syms_of_lread): Declare `lexical-binding'.
11267
11268 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11269
11270 * keyboard.c (eval_dyn): New fun.
11271 (menu_item_eval_property): Use it.
ca105506
SM
11272
11273 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11274
03408648
SM
11275 * fns.c (concat, mapcar1): Accept byte-code-functions.
11276
11277 * eval.c (Fsetq): Handle lexical vars.
11278 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11279 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11280 (FletX, Flet): Obey lexical binding.
11281 (Fcommandp): Handle closures.
11282 (Feval): New `lexical' arg.
11283 (eval_sub): New function extracted from Feval. Use it almost
11284 everywhere where Feval was used. Look up vars in lexical env.
11285 Handle closures.
11286 (Ffunctionp): Move from subr.el.
11287 (Ffuncall): Handle closures.
11288 (apply_lambda): Remove `eval_flags'.
11289 (funcall_lambda): Handle closures and new byte-code-functions.
11290 (Fspecial_variable_p): New function.
11291 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11292 but without exporting it to Lisp.
23aba0ea 11293
23aba0ea 11294 * doc.c (Fdocumentation, store_function_docstring):
03408648 11295 * data.c (Finteractive_form): Handle closures.
23aba0ea 11296
03408648
SM
11297 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11298 interactive spec.
ba83908c 11299
04f2d78b
CB
11300 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11301 New byte-codes.
03408648
SM
11302 (exec_byte_code): New function extracted from Fbyte_code to handle new
11303 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11304
03408648 11305 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11306
03408648 11307 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11308
e2abce01
JB
113092011-03-31 Juanma Barranquero <lekktu@gmail.com>
11310
11311 * xdisp.c (redisplay_internal): Fix prototype.
11312
63696a73 113132011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11314
63696a73 11315 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11316 (try_scrolling): Use it when setting scroll_limit.
11317 Limit scrolling to 100 screen lines.
63696a73
EZ
11318 (redisplay_window): Even when falling back on "recentering",
11319 position point in the window according to scroll-conservatively,
11320 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11321
11322 (try_scrolling): When point is above the window, allow searching
11323 as far as scroll_max, or one screenful, to compute vertical
11324 distance from PT to the scroll margin position. This prevents
11325 try_scrolling from unnecessarily failing when
11326 scroll-conservatively is set to a value slightly larger than the
11327 window height. Clean up the case of PT below the margin at bottom
11328 of window: scroll_max can no longer be INT_MAX. When aggressive
11329 scrolling is in use, don't let point enter the opposite scroll
11330 margin as result of the scroll.
11331 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11332 threshold of 100 lines for never-recentering scrolling.
11333
e4cc2dfc
JB
113342011-03-31 Juanma Barranquero <lekktu@gmail.com>
11335
11336 * dispextern.h (move_it_by_lines):
11337 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11338 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11339 (message_log_check_duplicate): Remove parameters `prev_bol' and
11340 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11341 (redisplay_internal): Remove parameter `preserve_echo_area',
11342 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11343
11344 * indent.c (Fvertical_motion):
11345 * window.c (window_scroll_pixel_based, Frecenter):
11346 Don't pass `need_y_p' to `move_it_by_lines'.
11347
1c470562
SM
113482011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11349
44f230aa
SM
11350 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11351 steal a few bits to be more compact.
11352 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11353 Remove unneeded casts.
11354
1c470562
SM
11355 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11356
888adce9
ZK
113572011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11358
11359 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11360 binding" message (bug#7967).
11361
f838ed7b
PE
113622011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11363
77861b95
PE
11364 Fix more problems found by GCC 4.6.0's static checks.
11365
de6dbc14
PE
11366 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11367 Remove unused local var.
11368
f838ed7b
PE
11369 * editfns.c (Fmessage_box): Remove unused local var.
11370
792c7b2b
PE
11371 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11372 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11373 Omit unused local vars.
c499e557 11374 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11375 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11376 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11377 Omit unused local var.
11378
ba0165e1
PE
11379 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11380 Don't assume string length fits in int.
32ad8845 11381 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11382 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11383
3c59b4c9
PE
11384 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11385 instead of alloca (Bug#8344).
11386
a3eed478 11387 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11388 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11389
eb4d412d
PE
11390 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11391
1658b401
PE
11392 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11393 concerns.
11394
11395 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11396
11397 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11398
9a2c6e05
PE
11399 * keyboard.c (syms_of_keyboard): Use the same style as later
11400 in this function when indexing through an array. This also
11401 works around GCC bug 48267.
11402
03d0a109
PE
11403 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11404
44f730c8
PE
11405 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11406
fe75f926
PE
11407 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11408 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11409
ffa8c828
PE
11410 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11411 This avoids undefined behavior on integer overflow, and is a bit
11412 more convenient anyway since it is compared to a size_t variable.
11413
c5101a77
PE
11414 Variadic C functions now count arguments with size_t, not int.
11415 This avoids an unnecessary limitation on 64-bit machines, which
11416 caused (substring ...) to crash on large vectors (Bug#8344).
11417 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11418 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11419 All variadic functions and their callers changed accordingly.
c5101a77
PE
11420 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11421 * data.c (arith_driver, float_arith_driver): Likewise.
11422 * editfns.c (general_insert_function): Likewise.
11423 * eval.c (struct backtrace.nargs, interactive_p)
11424 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11425 (funcall_lambda, mark_backtrace): Likewise.
11426 * fns.c (concat): Likewise.
11427 * frame.c (x_set_frame_parameters): Likewise.
11428 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11429 0 if not found, not -1. All callers changed.
11430
dd3f25f7
PE
11431 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11432 (stack_copy_size): Now size_t, not int.
11433 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11434
461c2ab9
JB
114352011-03-28 Juanma Barranquero <lekktu@gmail.com>
11436
11437 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11438 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11439 All callers changed.
11440
11441 * lisp.h (multibyte_char_to_unibyte):
11442 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11443 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11444 * character.h (CHAR_TO_BYTE8):
11445 * cmds.c (internal_self_insert):
11446 * editfns.c (general_insert_function):
11447 * keymap.c (push_key_description):
11448 * search.c (Freplace_match):
11449 * xdisp.c (message_dolog, set_message_1): All callers changed.
11450
f6d62986
SM
114512011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11452
11453 * keyboard.c (safe_run_hook_funcall): New function.
11454 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11455 don't set the hook to nil, but remove the offending function instead.
11456 (Qcommand_hook_internal): Remove, unused.
11457 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11458 Vcommand_hook_internal.
11459
11460 * eval.c (enum run_hooks_condition): Remove.
11461 (funcall_nil, funcall_not): New functions.
11462 (run_hook_with_args): Call each function through a `funcall' argument.
11463 Remove `cond' argument, now redundant.
11464 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11465 (Frun_hook_with_args_until_failure): Adjust accordingly.
11466 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11467
1db5b1ad
JB
114682011-03-28 Juanma Barranquero <lekktu@gmail.com>
11469
11470 * dispextern.h (string_buffer_position): Remove declaration.
11471
11472 * print.c (strout): Remove parameter `multibyte', unused since
11473 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11474
11475 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11476 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11477 All callers changed.
11478
11479 * w32.c (_wsa_errlist): Use braces for struct initializers.
11480
11481 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11482 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11483 All callers changed.
11484 (string_buffer_position): Likewise. Also, make static (it's never
11485 used outside xdisp.c).
11486 (cursor_row_p): Remove parameter `w', unused since
11487 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11488 (decode_mode_spec): Remove parameter `precision', introduced during
11489 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11490 All callers changed.
11491
5ffb62aa
JD
114922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11493
11494 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11495
461c2ab9 114962011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11497
11498 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11499 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11500 (ns_update_auto_hide_menu_bar): New functions.
11501 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11502 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11503 ns_constrain_all_frames.
11504 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11505 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11506
5c380ffb
JD
115072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11508
11509 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11510
9af30bdf
GM
115112011-03-27 Glenn Morris <rgm@gnu.org>
11512
11513 * syssignal.h: Replace RETSIGTYPE with void.
11514 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11515 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11516 Replace SIGTYPE with void everywhere.
11517 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11518 * s/template.h (SIGTYPE): Remove commented out definition.
11519
e2abce01
JB
115202011-03-26 Eli Zaretskii <eliz@gnu.org>
11521
11522 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11523 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11524
f868cd8a
JB
115252011-03-26 Juanma Barranquero <lekktu@gmail.com>
11526
59eb0929
JB
11527 * w32.c (read_unc_volume): Use parameter `henum', instead of
11528 global variable `wget_enum_handle'.
11529
11530 * keymap.c (describe_vector): Remove parameters `indices' and
11531 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11532 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11533
f868cd8a
JB
11534 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11535
11536 * keyboard.c (timer_check): Remove parameter `do_it_now',
11537 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11538 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11539 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11540
11541 * keyboard.c (read_char):
11542 * w32menu.c (w32_menu_display_help):
11543 * xmenu.c (show_help_event, menu_help_callback):
11544 Adjust calls to `show_help_echo'.
11545
11546 * gtkutil.c (xg_maybe_add_timer):
11547 * keyboard.c (readable_events):
11548 * process.c (wait_reading_process_output):
11549 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11550
11551 * insdel.c (adjust_markers_gap_motion):
11552 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11553 (gap_left, gap_right): Don't call it.
11554
2ecf6fdb
CY
115552011-03-25 Chong Yidong <cyd@stupidchicken.com>
11556
11557 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11558 incurred during fontification.
11559
6b1f9ba4
JB
115602011-03-25 Juanma Barranquero <lekktu@gmail.com>
11561
11562 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11563 (DEFVAR_PER_BUFFER): Don't pass it.
11564
11565 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11566 (scrolling_window): Don't pass it.
11567
0f4a96b5
JB
115682011-03-25 Juanma Barranquero <lekktu@gmail.com>
11569
11570 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11571
11572 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11573 and `suffix'.
11574 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11575 of variables specific to SELinux and computation of `encoded_absname'.
11576
11577 * image.c (XPutPixel): Remove unused variable `height'.
11578
11579 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11580
11581 * unexw32.c (get_section_info): Remove unused variable `section'.
11582
11583 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11584 (system_process_attributes): Remove unused variable `sess'.
11585 (sys_read): Remove unused variable `err'.
11586
11587 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11588 (w32_wnd_proc): Remove unused variable `isdead'.
11589 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11590 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11591 (x_create_tip_frame): Remove unused variable `tem'.
11592
11593 * w32inevt.c (w32_console_read_socket):
11594 Remove unused variable `no_events'.
11595
11596 * w32term.c (x_draw_composite_glyph_string_foreground):
11597 Remove unused variable `width'.
11598
1149507c
JB
115992011-03-24 Juanma Barranquero <lekktu@gmail.com>
11600
11601 * w32term.c (x_set_glyph_string_clipping):
11602 Don't pass uninitialized region to CombineRgn.
11603
9c88f339
JB
116042011-03-23 Juanma Barranquero <lekktu@gmail.com>
11605
11606 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11607 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11608 (Fx_close_connection): Remove unused variable `i'.
11609
11610 * w32font.c (w32font_draw): Return number of glyphs.
11611 (w32font_open_internal): Remove unused variable `i'.
11612 (w32font_driver): Add missing initializer.
11613
11614 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11615 (fill_in_menu): Remove unused variable `items_added'.
11616
11617 * w32term.c (last_mouse_press_frame): Remove static global variable.
11618 (w32_clip_to_row): Remove unused variable `f'.
11619 (x_delete_terminal): Remove unused variable `i'.
11620
11621 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11622 (NOTHING): Remove unused static global variable.
11623 (uniscribe_check_otf): Remove unused variable `table'.
11624 (uniscribe_font_driver): Add missing initializers.
11625
dee091a3
JD
116262011-03-23 Julien Danjou <julien@danjou.info>
11627
11628 * term.c (Fsuspend_tty, Fresume_tty):
11629 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11630 * window.c (temp_output_buffer_show):
11631 * insdel.c (signal_before_change):
11632 * frame.c (Fhandle_switch_frame):
11633 * fileio.c (Fdo_auto_save):
11634 * emacs.c (Fkill_emacs):
11635 * editfns.c (save_excursion_restore):
11636 * cmds.c (internal_self_insert):
11637 * callint.c (Fcall_interactively):
11638 * buffer.c (Fkill_all_local_variables):
11639 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11640 Use Frun_hooks.
0f4a96b5 11641 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11642 unconditionally since it does the check itself.
dee091a3 11643
2c520ab5 116442011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11645
c9c49752
PE
11646 Fix more problems found by GCC 4.5.2's static checks.
11647
8abc3f12
PE
11648 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11649 the first time through the loop, since we know p0 < p1 then.
11650 This also avoids a gcc -Wstrict-overflow warning.
11651
a2d26660
PE
11652 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11653 leading to a memory leak, possible in functions like
11654 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11655 of objects (Bug#8318).
a2d26660 11656
916c72e9
PE
11657 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11658 that could (at least in theory) be that large.
11659
19ab8a18
PE
11660 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11661 This is less likely to overflow, and avoids undefined behavior if
11662 overflow does occur. All callers changed. Use strtoul to scan
11663 for the unsigned long integer.
b7cbbd6f
PE
11664 (pint2hrstr): Simplify and tune code slightly.
11665 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11666
f0641eff
PE
11667 * scroll.c (do_scrolling): Work around GCC bug 48228.
11668 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11669
7f650bb9
PE
11670 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11671 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11672 (validate_x_resource_name): Simplify count usage.
11673 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11674
37dd57d1
PE
11675 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11676 fail (Bug#8306).
81e56e61 11677
699979fc 11678 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11679
401bf9b4
PE
11680 * process.c (Fmake_network_process): Use socklen_t, not int,
11681 where POSIX says socklen_t is required in portable programs.
11682 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11683 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11684 (Fmake_network_process, server_accept_connection):
11685 (wait_reading_process_output, read_process_output):
11686 Likewise.
11687
b93aacde
PE
11688 * process.c: Rename or move locals to avoid shadowing.
11689 (list_processes_1, Fmake_network_process):
11690 (read_process_output_error_handler, exec_sentinel_error_handler):
11691 Rename or move locals.
4dc343ee 11692 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11693 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11694 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11695 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11696 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11697
af8a867c 11698 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11699 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11700 Include tparam.h instead, since it declares them.
af8a867c
PE
11701 * cm.h (PC): Remove extern decl; tparam.h now does this.
11702 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11703 * terminfo.c: Include tparam.h, to check interfaces.
11704 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11705 (tparam): Adjust signature to match interface in tparam.h;
11706 this removes some undefined behavior. Check that outstring and len
11707 are zero, which they always are with Emacs.
11708 * tparam.h (PC, BC, UP): New extern decls.
11709
0248044d 11710 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11711 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11712
8ff096c1 11713 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11714 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11715 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11716 (ftfont_list): Remove unused local.
49eaafba
PE
11717 (get_adstyle_property, ftfont_pattern_entity):
11718 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11719 Rename locals to avoid shadowing.
8ff096c1 11720
e2be39f6
PE
11721 * xfont.c (xfont_list_family): Mark var as initialized.
11722
c9735e30
PE
11723 * xml.c (make_dom): Now static.
11724
8f5201ae
PE
11725 * composite.c (composition_compute_stop_pos): Rename local to
11726 avoid shadowing.
b246f932
PE
11727 (composition_reseat_it): Remove unused locals.
11728 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11729 (composition_update_it): Mark var as initialized.
11b61122
PE
11730 (find_automatic_composition): Mark vars as initialized,
11731 with a FIXME (Bug#8290).
8f5201ae 11732
760fbc2c
PE
11733 character.h: Rename locals to avoid shadowing.
11734 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11735 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11736 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11737 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11738 to avoid shadowing.
11739
ff08eb85
PE
11740 * textprop.c (property_change_between_p): Remove; unused.
11741
fc7bf025
PE
11742 * intervals.c (interval_start_pos): Now static.
11743
235d7abc
PE
11744 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11745
44f230aa
SM
11746 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11747 Rename locals to avoid shadowing.
3e7d6594 11748
50060332
PE
11749 * sound.c (wav_play, au_play, Fplay_sound_internal):
11750 Fix pointer signedness.
d01f234b 11751 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11752 (wav_play): Initialize a variable to 0, to prevent undefined
11753 behavior (Bug#8278).
50060332 11754
c4fc4e30
PE
11755 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11756
918436ed
PE
11757 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11758
c939f91b
PE
11759 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11760 clobbering (Bug#8298).
b9c7f648
PE
11761 * sysdep.c (sys_subshell): Likewise.
11762 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11763
6bd8c144
PE
11764 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11765 This should get cleaned up, so that child_setup has the
11766 same signature on all platforms.
11767
7710357c 11768 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11769 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11770
c59da222
CY
117712011-03-22 Chong Yidong <cyd@stupidchicken.com>
11772
11773 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11774 not to be necessary, and produces flickering.
11775
66b87493
GM
117762011-03-20 Glenn Morris <rgm@gnu.org>
11777
11778 * config.in: Remove file.
11779
45b6f6d5
JB
117802011-03-20 Juanma Barranquero <lekktu@gmail.com>
11781
11782 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11783 are now in src/globals.h.
11784 (syms_of_minibuf): Remove spurious & from previous change.
11785
cd394be1 117862011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11787
11788 * minibuf.c (completing-read-function): New variable.
11789 (completing-read-default): Rename from completing-read.
11790 (completing-read): Call completing-read-function.
11791
b14e3e21
CY
117922011-03-19 Juanma Barranquero <lekktu@gmail.com>
11793
11794 * xfaces.c (Fx_load_color_file):
11795 Read color file from absolute filename (bug#8250).
11796
f2b726e6
JB
117972011-03-19 Juanma Barranquero <lekktu@gmail.com>
11798
11799 * makefile.w32-in: Update dependencies.
11800
09f6ff02
EZ
118012011-03-17 Eli Zaretskii <eliz@gnu.org>
11802
11803 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11804
29a6015a
PE
118052011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11806
a3a6c54e
PE
11807 Fix more problems found by GCC 4.5.2's static checks.
11808
b766f867
PE
11809 * process.c (make_serial_process_unwind, send_process_trap):
11810 (sigchld_handler): Now static.
11811
be02381c
PE
11812 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11813 That way, the code declares only the vars that it needs.
11814 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11815 * s/cygwin.h (PTY_ITERATION): Likewise.
11816 * s/darwin.h (PTY_ITERATION): Likewise.
11817 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11818
57048744
PE
11819 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11820 * process.c (allocate_pty): Don't declare stb unless it's needed.
11821
7914961c 11822 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11823 (CONSTANTLIM): Remove; unused.
11824 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11825 Define only if needed.
7914961c 11826
b3967b18
PE
11827 * unexelf.c (unexec): Name an expression,
11828 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11829 Use a different way to cause a compilation error if anyone uses
11830 n rather than nn, a way that does not involve shadowing.
73366a00 11831 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11832
29a6015a
PE
11833 * deps.mk (unexalpha.o): Remove; unused.
11834
43cfc33e 11835 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11836 * unexec.h: New file.
ce701a33
PE
11837 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11838 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11839 Depend on unexec.h.
11840 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11841 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11842 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11843 Change as necessary to match prototype in unexec.h.
ce701a33 11844
01f44d5a
PE
11845 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11846 shadowing.
4f63c6bb 11847 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11848
a6670b0b
PE
11849 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11850 Rename locals to avoid shadowing.
11851
cef2010d 11852 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11853 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11854
d4d7173a
PE
11855 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11856
f08b802a
PE
11857 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11858 warning when compiling print.c.
11859
3ddb0639
PE
11860 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11861 instead of using an uninitialized var.
5ad03b97 11862 (font_sort_entities): Mark var as initialized.
3ddb0639 11863
170a2692
PE
11864 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11865
e663c700
PE
11866 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11867 pointers to constants.
89bc529a 11868 (font_parse_fcname): Remove unused vars.
7b81e2d0 11869 (font_delete_unmatched): Now static.
ea838e10 11870 (font_get_spec): Remove; unused.
13a547c6
PE
11871 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11872 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11873 Rename or move locals to avoid shadowing.
e663c700 11874
2a80c887 11875 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11876 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11877
1384fa33 11878 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11879 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11880
8b2c52e9
PE
11881 * alloc.c (mark_backtrace): Move decl from here ...
11882 * lisp.h: ... to here, so that it can be checked.
11883
475545b5 11884 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11885 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11886 (lisp_indirect_variable): Name an expression,
11887 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11888 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11889
b1349114 11890 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11891 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11892 Use const pointer when appropriate.
b1349114 11893
a2928364
PE
11894 * lisp.h (get_system_name, get_operating_system_release):
11895 Move decls here, to check interfaces.
11896 * process.c (get_operating_system_release): Move decl to lisp.h.
11897 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11898 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11899 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11900 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11901 (Fformat_time_string, Fencode_time, Finsert_char):
11902 (Ftranslate_region_internal, Fformat):
11903 Rename or remove local vars to avoid shadowing.
9710023e 11904 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11905
a415e694
PE
11906 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11907 avoid shadowing.
11908
8ef4622d
PE
11909 * lisp.h (eassert): Check that the argument compiles, even if
11910 ENABLE_CHECKING is not defined.
11911
946f9a5b
PE
11912 * data.c (Findirect_variable): Name an expression, to avoid
11913 gcc -Wbad-function-cast warning.
112396d6 11914 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11915 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11916 (Fmake_variable_buffer_local, Fmake_local_variable):
11917 Mark variables as initialized.
52746918 11918 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11919
e5aab7e7 11920 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11921 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11922 Rename locals to avoid shadowing.
dff45157
PE
11923 (mark_stack): Move local variables into the #ifdef region where
11924 they're used.
7bc26fdb
PE
11925 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11926 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11927 needed otherwise.
11928 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11929 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11930 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11931
e5aab7e7
PE
11932 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11933 avoids undefined behavior in theory.
11934
4da60324
PE
11935 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11936
88043301
PE
11937 Use functions, not macros, for up- and down-casing (Bug#8254).
11938 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11939 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11940 to use the following functions instead of these macros.
11941 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11942 EMACS_INT, since callers assume the returned value fits in int.
11943 (upcase1): Likewise, for UPCASE_TABLE.
11944 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11945 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11946 the race-condition problem in the old DOWNCASE.
88043301 11947
19ed5445
PE
11948 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11949 Rename locals to avoid shadowing.
11950 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11951 (regex_compile, re_search_2, re_match_2_internal):
11952 Remove unused local vars.
952db0d7
PE
11953 (FREE_VAR): Rewrite so as not to use empty "else",
11954 which gcc can warn about.
da053e48 11955 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11956 (RETALLOC_IF): Define only if needed.
11957 (WORDCHAR_P): Likewise. This one is never needed, but is used
11958 only in a comment talking about a compiler bug, so put inside
11959 the #if 0 of that comment.
11960 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11961 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11962 Remove; unused.
19ed5445 11963
1f3561e4 11964 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11965 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11966 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11967
ded6f8f7
PE
11968 * search.c (simple_search): Remove unused var.
11969
dbd37a95
PE
11970 * dired.c (compile_pattern): Move decl from here ...
11971 * lisp.h: ... to here, so that it can be checked.
11972 (struct re_registers): New forward decl.
11973
7e47afad
PE
11974 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11975
85f24f61
PE
11976 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11977 All uses changed.
11978 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11979 Rename locals to avoid shadowing.
5671df8f 11980 (Fvertical_motion): Mark locals as initialized.
85f24f61 11981
181aa2be 11982 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11983 (casify_region): Mark local as initialized.
181aa2be 11984
930d429c
PE
11985 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11986
7082eac6
PE
11987 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11988 New macros, so that the caller can use some names other than
11989 gcpro1, gcpro2, etc.
11990 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11991 of the new macros.
11992 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11993 argument, for consistency with GCPRO2_VAR, etc: it is now the
11994 prefix of the variable, not the variable itself. All uses
11995 changed.
38b2c076
PE
11996 * dired.c (directory_files_internal, file_name_completion):
11997 Rename locals to avoid shadowing.
11998
15206ed9
PE
11999 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12000 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12001 dired.c's scmp function, had undefined behavior.
12002 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12003 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12004 * buffer.h: ... to here, because these macros use current_buffer,
12005 and the new implementation with inline functions needs to have
12006 current_buffer in scope now, rather than later when the macros
12007 are used.
12008 (downcase, upcase1): New static inline functions.
12009 (DOWNCASE, UPCASE1): Reimplement using these functions.
12010 This avoids undefined behavior in expressions like
12011 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12012 from race conditions in accessing the global variables
12013 case_temp1 and case_temp2.
12014 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12015 * lisp.h (case_temp1, case_temp2): Remove their decls.
12016 * character.h (ASCII_CHAR_P): Move from here ...
12017 * lisp.h: ... to here, so that the inline functions mentioned
12018 above can use them.
12019
4a6bea26
PE
12020 * dired.c (directory_files_internal_unwind): Now static.
12021
f14b7e14
PE
12022 * fileio.c (file_name_as_directory, directory_file_name):
12023 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12024 Now static.
2893f146
PE
12025 (file_name_as_directory): Use const pointers when appropriate.
12026 (Fexpand_file_name): Likewise. In particular, newdir might
12027 point at constant storage, so make it a const pointer.
fd4ead52 12028 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12029 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12030 signedness issues.
f839df0c
PE
12031 (Fset_file_times, Finsert_file_contents, auto_save_error):
12032 Rename locals to avoid shadowing.
f14b7e14 12033
5716756e 12034 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12035 (Ftry_completion, Fall_completions): Rename or remove locals
12036 to avoid shadowing.
5716756e 12037
b4c3046a
PE
12038 * marker.c (bytepos_to_charpos): Remove; unused.
12039
b45db522
PE
12040 * lisp.h (verify_bytepos, count_markers): New decls,
12041 so that gcc does not warn that these functions aren't declared.
12042
85876d07
PE
12043 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12044 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12045 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12046 (copy_text): Remove unused local var.
85876d07 12047
03d78a21 12048 * filelock.c (within_one_second): Now static.
b3dd38ab 12049 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12050
5df8f01b
PE
12051 * buffer.c (fix_overlays_before): Mark locals as initialized.
12052 (fix_start_end_in_overlays): Likewise. This function should be
12053 simplified by using pointers-to-pointers, but that's a different
12054 matter.
b1d876f1 12055 (switch_to_buffer_1): Now static.
8f54f30a
PE
12056 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12057 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12058
a70072c9 12059 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12060 Fix pointer signedness issue.
edced198
PE
12061 (sys_subshell): Mark local as volatile if checking for lint,
12062 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12063 (MAXPATHLEN): Define only if needed.
a70072c9 12064
a0977c44
PE
12065 * process.c (serial_open, serial_configure): Move decls from here ...
12066 * systty.h: ... to here, so that they can be checked.
12067
a884fdcc
PE
12068 * fns.c (get_random, seed_random): Move extern decls from here ...
12069 * lisp.h: ... to here, so that they can be checked.
12070
604efe86 12071 * sysdep.c (reset_io): Now static.
b8950c94 12072 (wait_for_termination_signal): Remove; unused.
604efe86 12073
38fc62d9
PE
12074 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12075 (copy_keymap_item, append_key, push_text_char_description):
12076 Now static.
1004a21a 12077 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12078 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12079 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12080 (describe_map_tree):
12081 Rename locals to avoid shadowing.
38fc62d9 12082
2f2650da
PE
12083 * keyboard.c: Declare functions static if they are not used elsewhere.
12084 (echo_char, echo_dash, cmd_error, top_level_2):
12085 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12086 (read_char, kbd_buffer_get_event, make_lispy_position):
12087 (make_lispy_event, make_lispy_movement, apply_modifiers):
12088 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12089 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12090 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12091 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12092 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12093
a053e86c 12094 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12095 (mark_kboards): Move decl here ...
12096 * alloc.c (mark_kboards): ... from here.
a053e86c 12097
4752793e
PE
12098 * lisp.h (force_auto_save_soon): New decl.
12099
74f10ca7 12100 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12101 (DEFINE_DUMMY_FUNCTION): New macro.
12102 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12103 Use it.
c03cd23f
PE
12104 (main): Add casts to avoid warnings
12105 if GCC considers string literals to be constants.
74f10ca7 12106
022e70d4
PE
12107 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12108
59d6fe83
PE
12109 * dbusbind.c: Pointer signedness fixes.
12110 (xd_signature, xd_append_arg, xd_initialize):
12111 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12112 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12113 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12114 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12115
78320123
PE
12116 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12117 if GCC considers string literals to be constants.
49cebcca 12118 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12119
35ac2a97
SM
121202011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12121
fb103ca9
SM
12122 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12123 (print_preprocess, print_object): New macro to fix last change.
12124
35ac2a97
SM
12125 * print.c (print_preprocess): Don't forget font objects.
12126
62973b41
JB
121272011-03-16 Juanma Barranquero <lekktu@gmail.com>
12128
12129 * emacs.c (USAGE3): Doc fixes.
12130
0e48bb22
AS
121312011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12132
12133 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12134 structure.
12135
7684e57b
JB
121362011-03-14 Juanma Barranquero <lekktu@gmail.com>
12137
12138 * lisp.h (VWindow_system, Qfile_name_history):
12139 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12140 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12141 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12142
12143 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12144 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12145
12146 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12147 * w32console.c (detect_input_pending, read_input_pending)
12148 (encode_terminal_code):
12149 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12150 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12151 (w32_system_caret_y, Qfile_name_history):
12152 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12153 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12154 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12155 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12156 * w32proc.c (Qlocal, report_file_error):
12157 * w32term.c (Vwindow_system, updating_frame):
12158 * w32uniscribe.c (initialized, uniscribe_font_driver):
12159 Remove unneeded extern declarations.
12160
2aa46d6c
CY
121612011-03-14 Chong Yidong <cyd@stupidchicken.com>
12162
c96bbc66 12163 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12164
cffc6f3b
CY
121652011-03-13 Chong Yidong <cyd@stupidchicken.com>
12166
12167 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12168 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12169 These macros can no longer be used for assignment.
12170
44f230aa
SM
12171 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12172 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12173 (record_buffer_markers, fetch_buffer_markers): New functions for
12174 recording and fetching special buffer markers.
12175 (set_buffer_internal_1, set_buffer_temp): Use them.
12176
12177 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12178
12179 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12180
12181 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12182 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12183
12184 * xdisp.c (hscroll_window_tree):
12185 (reconsider_clip_changes): Use PT instead of BUF_PT.
12186
d251f04b
EZ
121872011-03-13 Eli Zaretskii <eliz@gnu.org>
12188
12189 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12190 $(EMACS_ROOT)/lib/intprops.h.
12191
f0c77cd1
PE
121922011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12193
3eca4629
PE
12194 Fix more problems found by GCC 4.5.2's static checks.
12195
7c86ee98
PE
12196 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12197 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12198 (xg_free_frame_widgets): Make it clear that a local variable is
12199 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12200 (gdk_window_get_screen): Make it clear that this macro is needed
12201 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12202 (int_gtk_range_get_value): New function, which avoids a diagnostic
12203 from gcc -Wbad-function-cast.
12204 (xg_set_toolkit_scroll_bar_thumb): Use it.
12205 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12206 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12207 (get_utf8_string, xg_get_file_with_chooser):
12208 Rename locals to avoid shadowing.
12209 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12210
41729b81
PE
12211 * xgselect.c (xg_select): Remove unused var.
12212
f0c77cd1
PE
12213 * image.c (four_corners_best): Mark locals as initialized.
12214 (gif_load): Initialize transparent_p to zero (Bug#8238).
12215 Mark another local as initialized.
ec6cf4c6 12216 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12217
ce0ad53d 12218 * image.c (clear_image_cache): Now static.
d5d5a617 12219 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12220 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12221 (x_edge_detection): Remove unnecessary cast that
12222 gcc -Wbad-function-cast diagnoses.
2037898d 12223 (gif_load): Fix pointer signedness.
6ae141d6
PE
12224 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12225 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12226
33383987 122272011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12228
d32df629
PE
12229 Improve quality of tests for time stamp overflow.
12230 For example, without this patch (encode-time 0 0 0 1 1
12231 1152921504606846976) returns the obviously-bogus value (-948597
12232 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12233 reports time overflow. See
12234 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12235 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12236 * editfns.c: Include limits.h and intprops.h.
12237 (TIME_T_MIN, TIME_T_MAX): New macros.
12238 (time_overflow): Move earlier, to before first use.
12239 (hi_time, lo_time): New functions, for an accurate test for
12240 out-of-range times.
12241 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12242 (Fget_internal_run_time): Don't assume time_t fits in int.
12243 (make_time): Use list2 instead of Fcons twice.
12244 (Fdecode_time): More accurate test for out-of-range times.
12245 (check_tm_member): New function.
12246 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12247 (lisp_time_argument): Don't rely on undefined left-shift and
12248 right-shift behavior when checking for time stamp overflow.
8be6f318 12249
fe31d94c
PE
12250 * editfns.c (time_overflow): New function, refactoring common code.
12251 (Fformat_time_string, Fdecode_time, Fencode_time):
12252 (Fcurrent_time_string): Use it.
12253
8be6f318
PE
12254 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12255 * dired.c (make_time): Move to ...
12256 * editfns.c (make_time): ... here.
12257 * systime.h: Note the move.
12258
09d9db2c 122592011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12260
126bc0dc
YM
12261 * fringe.c (update_window_fringes): Remove unused variables.
12262
c47cbdfd
YM
12263 * unexmacosx.c (copy_data_segment): Also copy __got section.
12264 (Bug#8223)
12265
7ac80be9
EZ
122662011-03-12 Eli Zaretskii <eliz@gnu.org>
12267
c96bbc66 12268 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12269 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12270 Constify `char *' arguments and their references according to
12271 prototypes in tparam.h.
12272
ecb0f94d 12273 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12274
7ac80be9
EZ
12275 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12276 Adapt all references accordingly.
12277
12278 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12279
ef1fd07e
TT
122802011-03-11 Tom Tromey <tromey@redhat.com>
12281
12282 * buffer.c (syms_of_buffer): Remove obsolete comment.
12283
7ef4b50c
EZ
122842011-03-11 Eli Zaretskii <eliz@gnu.org>
12285
12286 * termhooks.h (encode_terminal_code): Declare prototype.
12287
12288 * msdos.c (encode_terminal_code): Don't declare prototype.
12289
12290 * term.c (encode_terminal_code): Now external again, used by
12291 w32console.c and msdos.c.
12292
44f230aa
SM
12293 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12294 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12295
4b1ec863 122962011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12297
1714f52b 12298 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12299
4b1ec863
PE
12300 * fringe.c (update_window_fringes): Mark locals as initialized
12301 (Bug#8227).
12302 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12303
524c7aa6
PE
12304 * alloc.c (mark_fringe_data): Move decl from here ...
12305 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12306 to check its interface.
12307 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12308
a5c0af81 12309 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12310 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12311 (fontset_font): Mark local as initialized.
a9a06e0b 12312 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12313
b4716021
PE
12314 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12315
811e9bac 12316 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12317 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12318 (x_own_selection, Fx_disown_selection_internal): Rename locals
12319 to avoid shadowing.
12320 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12321
7e3ab302
PE
12322 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12323 so that the caller can use some name other than gcpro1.
12324 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12325 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12326 (Fx_backspace_delete_keys_p):
12327 Use them to avoid shadowing, and rename vars to avoid shadowing.
12328 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12329 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12330 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12331 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12332 Remove unused locals.
7e3ab302
PE
12333 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12334 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12335 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12336 macros.
f78faa98 12337
e2b13473
PE
12338 * xterm.h (x_mouse_leave): New decl.
12339
77f23912
PE
12340 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12341 Remove unused functions.
cdf4ba58
PE
12342 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12343 (x_calc_absolute_position): Now static.
7411c686 12344 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12345 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12346 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12347 unless they are used.
38d0b34a
PE
12348 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12349 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12350 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12351 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12352 (x_error_catcher, x_connection_closed, x_error_handler):
12353 (x_error_quitter, xembed_send_message, x_iconify_frame):
12354 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12355 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12356 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12357
44f230aa
SM
12358 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12359 Rename or move locals to avoid shadowing.
6b463e58 12360 (tty_defined_color, merge_face_heights): Now static.
5967d051 12361 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12362 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12363 does not deduce is never used uninitialized.
73719eba
PE
12364 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12365 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12366
426994c3 12367 * terminal.c (store_terminal_param): Now static.
5489860b 12368
032f1620 12369 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12370 (set_frame_menubar): Remove unused local.
d4323972 12371 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12372 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12373 since they might point to immutable storage.
281585b0
PE
12374 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12375 since it's unused otherwise.
032f1620 12376
367c19e5 12377 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12378 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12379 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12380 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12381 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12382 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12383 does not deduce are never used uninitialized.
70739cbe 12384
07b48fa9
PE
12385 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12386
8868a238 12387 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12388 * window.c (window_loop, size_window):
12389 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12390
7e5cf297 12391 * window.c (display_buffer): Now static.
d6550a9f
PE
12392 (size_window): Mark variables that gcc -Wuninitialized
12393 does not deduce are never used uninitialized.
a586633d
PE
12394 * window.h (check_all_windows): New decl, to forestall
12395 gcc -Wmissing-prototypes diagnostic.
5b555da1 12396 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12397
f6095868
PE
12398 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12399 shadowing.
12400 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12401 Include <limits.h>.
12402 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12403 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12404 (load_charset_map): Mark variables that gcc -Wuninitialized
12405 does not deduce are never used uninitialized.
53df7c11 12406 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12407
f38b440c
PE
12408 * coding.c (coding_set_source, coding_set_destination):
12409 Use "else { /* comment */ }" rather than "else /* comment */;"
12410 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12411 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12412 a block, when the outer 'i' will do.
12413 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12414 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12415 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12416 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12417 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12418 Rename locals to avoid shadowing.
12419 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12420 * coding.c (emacs_mule_char, encode_invocation_designation):
12421 Now static, since they're not used elsewhere.
413bb2db 12422 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12423 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12424 (decode_coding_emacs_mule): Mark variables that gcc
12425 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12426 (detect_coding_iso_2022): Initialize a local variable that might
12427 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12428 this initialization is needed. (Bug#8211)
5f58e762
PE
12429 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12430 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12431 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12432 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12433 Remove unused macros.
f38b440c 12434
232b38b9 12435 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12436 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12437 * character.c (string_count_byte8): Likewise.
232b38b9 12438
fb90da1b
PE
12439 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12440 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12441
fb93dbc2
PE
12442 * chartab.c (copy_sub_char_table): Now static, since it's not used
12443 elsewhere.
5c156ace
PE
12444 (sub_char_table_ref_and_range, char_table_ref_and_range):
12445 Rename locals to avoid shadowing.
bbcd0949 12446 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12447
7d3b3862 12448 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12449 (BIDI_BOB): Remove unused macro.
7d3b3862 12450
6be7d3da
PE
12451 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12452 deduce are never used uninitialized.
c2ed9c8b 12453 * term.c (encode_terminal_code): Likewise.
6be7d3da 12454
75f8807f 12455 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12456
50938595
PE
12457 * tparam.h: New file.
12458 * term.c, tparam.h: Include it.
12459 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12460 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12461 Move these decls to tparam.h, and make them agree with what
12462 is actually in tparam.c. The previous trick of using incompatible
12463 decls in different modules does not conform to the C standard.
12464 All callers of tparam changed to use tparam's actual API.
12465 * tparam.c (tparam1, tparam, tgoto):
12466 Use const pointers where appropriate.
12467
fbceeba2
PE
12468 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12469 * cm.h (struct cm): Likewise.
12470 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12471 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12472 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12473 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12474 (turn_on_face, init_tty): Likewise.
12475 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12476
7f3f1250
PE
12477 * term.c (term_mouse_position): Rename local to avoid shadowing.
12478
e6ca6543
PE
12479 * alloc.c (mark_ttys): Move decl from here ...
12480 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12481
c40f8d15
AS
124822011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12483
12484 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12485
cfe0661d
JB
124862011-03-09 Juanma Barranquero <lekktu@gmail.com>
12487
12488 * search.c (compile_pattern_1): Remove argument regp, unused since
12489 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12490 (compile_pattern): Don't pass it.
12491
0afb4571
J
124922011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12493
12494 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12495 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12496 for ! HAVE_GTK3.
12497 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12498
12499 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12500
12501 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12502 gdk_window_get_screen, gdk_window_get_geometry,
12503 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12504 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12505 (xg_get_pixbuf_from_pixmap): New function.
12506 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12507 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12508 Call xg_get_pixbuf_from_pixmap instead of
12509 gdk_pixbuf_get_from_drawable.
12510 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12511 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12512 (xg_check_special_colors): Use GtkStyleContext and its functions
12513 for HAVE_GTK3.
12514 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12515 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12516 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12517 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12518 Call gtk_widget_get_preferred_size.
0afb4571
J
12519 (xg_frame_resized): gdk_window_get_geometry only takes 5
12520 parameters.
44f230aa
SM
12521 (xg_win_to_widget, xg_event_is_for_menubar):
12522 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12523 (xg_set_widget_bg): New function.
12524 (delete_cb): New function.
895009e1 12525 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12526 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12527 (xg_set_background_color): Call xg_set_widget_bg.
12528 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12529 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12530 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12531 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12532 if ! HAVE_GTK3.
12533 (update_frame_tool_bar): Call gtk_widget_hide.
12534 (xg_initialize): Use GDK_KEY_g.
12535
12536 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12537 if ! HAVE_GTK3
12538 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12539
12540 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12541 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12542 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12543
1c2cc4ef
JB
125442011-03-08 Juanma Barranquero <lekktu@gmail.com>
12545
12546 * w32xfns.c (select_palette): Check success of RealizePalette against
12547 GDI_ERROR, not zero.
12548
33383987 12549See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12550
12551;; Local Variables:
12552;; coding: utf-8
aac0c6e3
MR
12553;; End:
12554
2f097256 12555 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12556
12557 This file is part of GNU Emacs.
12558
12559 GNU Emacs is free software: you can redistribute it and/or modify
12560 it under the terms of the GNU General Public License as published by
12561 the Free Software Foundation, either version 3 of the License, or
12562 (at your option) any later version.
12563
12564 GNU Emacs is distributed in the hope that it will be useful,
12565 but WITHOUT ANY WARRANTY; without even the implied warranty of
12566 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12567 GNU General Public License for more details.
12568
12569 You should have received a copy of the GNU General Public License
12570 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.