chartab.c (sub_char_table_set_range): Fix previous change.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c805dec0
KH
12011-07-06 Kenichi Handa <handa@m17n.org>
2
3 * character.h (unicode_category_t): New enum type.
4
5 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6 (Qchar_code_property_table): New variable.
7 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8 (UNIPROP_COMPRESSED_FORM_P): New macros.
9 (char_table_ascii): Uncompress the compressed values.
10 (sub_char_table_ref): New arg is_uniprop. Callers changed.
11 Uncompress the compressed values.
12 (sub_char_table_ref_and_range): Likewise.
13 (char_table_ref_and_range): Uncompress the compressed values.
14 (sub_char_table_set): New arg is_uniprop. Callers changed.
15 Uncompress the compressed values.
16 (sub_char_table_set_range): Args changed. Callers changed.
17 (char_table_set_range): Adjuted for the above change.
18 (map_sub_char_table): Delete args default_val and parent. Add arg
19 top. Give decoded values to a Lisp function.
20 (map_char_table): Adjusted for the above change. Give decoded
21 values to a Lisp function. Gcpro more variables.
22 (uniprop_table_uncompress)
23 (uniprop_decode_value_run_length): New functions.
24 (uniprop_decoder, uniprop_decoder_count): New variables.
25 (uniprop_get_decoder, uniprop_encode_value_character)
26 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
27 New functions.
28 (uniprop_encoder, uniprop_encoder_count): New variables.
29 (uniprop_get_encoder, uniprop_table)
30 (Funicode_property_table_internal, Fget_unicode_property_internal)
31 (Fput_unicode_property_internal): New functions.
32 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
33 Sunicode_property_table_internal, Sget_unicode_property_internal,
34 and Sput_unicode_property_internal. Defvar_lisp
35 char-code-property-alist.
36
37 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
38 Vunicode_category_table.
39
40 * font.c (font_range): Adjusted for the change of
41 Vunicode_category_table.
42
22b4128e
PE
432011-07-06 Paul Eggert <eggert@cs.ucla.edu>
44
45 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
46 * alloc.c (mark_buffer):
47 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
48 (clone_per_buffer_values): Don't assume that
22b4128e
PE
49 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
50 This isn't true in general, and it's particularly not true
51 if Emacs is configured with --with-wide-int.
52 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
53 New macros, used in the buffer.c change.
54
869795d6
JD
552011-07-05 Jan Djärv <jan.h.d@swipnet.se>
56
57 * xsettings.c: Use both GConf and GSettings if both are available.
58 (store_config_changed_event): Add comment.
59 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
60 (store_tool_bar_style_changed): New functions.
61 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
62 (struct xsettings): Move font inside HAVE_XFT.
63 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
64 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
65 Move inside HAVE_XFT.
66 (something_changed_gsettingsCB): Renamed from something_changedCB.
67 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
68 also.
69 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
70 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
71 (something_changed_gconfCB): Renamed from something_changedCB.
72 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
73 (parse_settings): Move check for font inside HAVE_XFT.
74 (read_settings, apply_xft_settings): Add comment.
75 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
76 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
77 call store_font_name_changed.
78 (xft_settings_event): Add comment.
79 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
80 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
81 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
82 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
83 (xsettings_initialize): Call init_gsettings last.
84 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
85 comment.
86
d8ed26bd
PE
872011-07-05 Paul Eggert <eggert@cs.ucla.edu>
88
89 Random fixes. E.g., (random) never returned negative values.
90 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
91 subseconds part to the entropy, as that's a bit more random.
92 Prefer signed to unsigned, since the signedness doesn't matter and
93 in general we prefer signed. When given a limit, use a
94 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
95 latter isn't right if USE_2_TAGS_FOR_INTS.
96 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
97 not 0..VALMASK. Don't discard "excess" bits that random () returns.
98
cabf1cac
SM
992011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
100
101 * textprop.c (text_property_stickiness):
102 Obey Vtext_property_default_nonsticky.
103 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
104 * w32fns.c (syms_of_w32fns):
105 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
106
6e9b2be9
PE
1072011-07-04 Paul Eggert <eggert@cs.ucla.edu>
108
109 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
110 This is more efficient than Ffile_directory_p and avoids a minor race.
111
90186c68
LMI
1122011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
113
7c301272
LMI
114 * buffer.c (Foverlay_put): Say what the return value is
115 (bug#7835).
116
c4f2d8d4
LMI
117 * fileio.c (barf_or_query_if_file_exists): Check first if the file
118 is a directory before asking whether to use the file name
119 (bug#7564).
ad637907
LMI
120 (barf_or_query_if_file_exists): Make the "File is a directory"
121 error be more correct.
c4f2d8d4 122
90186c68
LMI
123 * fns.c (Frequire): Remove the mention of the .gz files, since
124 that's installation-specific, but keep the mention of
125 `get-load-suffixes'.
126
da64016e
PE
1272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
128
129 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
130 Report string overflow if the output is too long.
131
7d47b580
JB
1322011-07-04 Juanma Barranquero <lekktu@gmail.com>
133
a555cb87
JB
134 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
135 (syms_of_gnutls): Remove duplicate DEFSYM for
136 Qgnutls_bootprop_verify_hostname_error, an error for
137 Qgnutls_bootprop_verify_error (which is no longer used).
138
7d47b580
JB
139 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
140 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
141 Also (re)move comments that are misplaced or no longer relevant.
142
1e49bfab
LMI
1432011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
144
145 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
146
1485f4c0
CY
1472011-07-03 Chong Yidong <cyd@stupidchicken.com>
148
149 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
150 and background color parameters if they have been changed.
151
a9ab721e
LMI
1522011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
153
154 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
155
cf7cff57
PE
1562011-07-03 Paul Eggert <eggert@cs.ucla.edu>
157
2e13213d
PE
158 * xsettings.c (SYSTEM_FONT): Define only when used.
159 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
160
cf7cff57
PE
161 * keymap.c (access_keymap_1): Now static.
162
7a8e04f7
CY
1632011-07-02 Chong Yidong <cyd@stupidchicken.com>
164
165 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
166 leave any prefix arg for the up event (Bug#1586).
167
61352f62
LMI
1682011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
169
69bb1ef7
LMI
170 * lread.c (syms_of_lread): Mention single symbols defined by
171 `defvar' or `defconst' (bug#7154).
172
61352f62 173 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 174 (Frequire): Mention get-load-suffixes.
61352f62 175
28545e04
MR
1762011-07-02 Martin Rudalics <rudalics@gmx.at>
177
178 * window.h (window): Remove clone_number slot.
179 * window.c (Fwindow_clone_number, Fset_window_clone_number):
180 Remove.
181 (make_parent_window, make_window, saved_window)
182 (Fset_window_configuration, save_window_save): Don't deal with
183 clone numbers.
184 * buffer.c (Qclone_number): Remove declaration.
185 (sort_overlays, overlay_strings): Don't deal with clone numbers.
186
3349e122
SM
1872011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
188
189 Add multiple inheritance to keymaps.
190 * keymap.c (Fmake_composed_keymap): New function.
191 (Fset_keymap_parent): Simplify.
192 (fix_submap_inheritance): Remove.
193 (access_keymap_1): New function extracted from access_keymap to handle
194 embedded parents and handle lists of maps.
195 (access_keymap): Use it.
196 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
197 (Fcopy_keymap): Handle embedded parents.
198 (Fcommand_remapping, define_as_prefix): Simplify.
199 (Fkey_binding): Simplify.
200 (syms_of_keymap): Move minibuffer-local-completion-map,
201 minibuffer-local-filename-completion-map,
202 minibuffer-local-must-match-map, and
203 minibuffer-local-filename-must-match-map to Elisp.
204 (syms_of_keymap): Defsubr make-composed-keymap.
205 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
206 (parse_menu_item): Trivial simplification.
207
3279eb87
GM
2082011-07-01 Glenn Morris <rgm@gnu.org>
209
210 * Makefile.in (SETTINGS_LIBS): Fix typo.
211
4550efdf
KI
2122011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
213
214 * coding.c (Fencode_coding_string): Record the last coding system
215 used, as the function doc string says (bug#8738).
216
0949d2b6
JD
2172011-07-01 Jan Djärv <jan.h.d@swipnet.se>
218
219 * xsettings.c (store_monospaced_changed): Take new font as arg and
220 check for change against current_mono_font.
221 (EMACS_TYPE_SETTINGS): Remove this and related defines.
222 (emacs_settings_constructor, emacs_settings_get_property)
223 (emacs_settings_set_property, emacs_settings_class_init)
224 (emacs_settings_init, gsettings_obj): Remove.
225 (something_changedCB): New function for HAVE_GSETTINGS.
226 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
227 with value as argument.
228 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
229 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 230 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
231 "changed".
232
233 * xgselect.c: Add defined (HAVE_GSETTINGS).
234 (xgselect_initialize): Ditto.
235
236 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
237 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
238 xg_select.
239
bbc6b304
PE
2402011-07-01 Paul Eggert <eggert@cs.ucla.edu>
241
242 * eval.c (struct backtrace): Simplify and port the data structure.
243 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
244 signed bit field, as this assumption is not portable and it makes
245 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
246 "char debug_on_exit : 1" as this is not portable either; instead,
247 use the portable "unsigned int debug_on_exit : 1". Remove unused
248 member evalargs. Remove obsolete comments about cc bombing out.
249
9851bfc5
JD
2502011-06-30 Jan Djärv <jan.h.d@swipnet.se>
251
51bb811f 252 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
253 Let HAVE_GSETTINGS override HAVE_GCONF.
254 (store_monospaced_changed): New function.
255 (EMACS_SETTINGS): A new type derived from GObject to handle
256 GSettings notifications.
257 (emacs_settings_constructor, emacs_settings_get_property)
258 (emacs_settings_set_property, emacs_settings_class_init):
259 New functions.
260 (gsettings_client, gsettings_obj): New variables.
261 (GSETTINGS_SCHEMA): New define.
262 (something_changedCB): Call store_monospaced_changed.
263 (init_gsettings): New function.
264 (xsettings_initialize): Call init_gsettings.
265 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
266 to NULL.
267
268 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
269 GCONF_CFLAGS/LIBS.
270
5386012d
MR
2712011-06-29 Martin Rudalics <rudalics@gmx.at>
272
273 * window.c (resize_root_window, grow_mini_window)
274 (shrink_mini_window): Rename Qresize_root_window to
275 Qwindow_resize_root_window and Qresize_root_window_vertically to
276 Qwindow_resize_root_window_vertically.
277
f13e0b08
PE
2782011-06-28 Paul Eggert <eggert@cs.ucla.edu>
279
280 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
281
94515237
JB
2822011-06-27 Juanma Barranquero <lekktu@gmail.com>
283
284 * makefile.w32-in: Redesign dependencies so they reflect more
285 clearly which files are directly included by each source file,
286 and not through other includes.
287
e43b6e43
MR
2882011-06-27 Martin Rudalics <rudalics@gmx.at>
289
290 * buffer.c (Qclone_number): Declare static and DEFSYM it.
291 (sort_overlays, overlay_strings): When an overlay's clone number
292 matches the window's clone number process the overlay even if
293 the overlay's window property doesn't match the current window.
294
d68443dc
MR
295 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
296 (Fwindow_hchild): Rename to Fwindow_left_child.
297 (Fwindow_next): Rename to Fwindow_next_sibling.
298 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
299 (resize_window_check): Rename to window_resize_check.
300 (resize_window_apply): Rename to window_resize_apply.
301 (Fresize_window_apply): Rename to Fwindow_resize_apply.
302 (Fdelete_other_windows_internal, resize_frame_windows)
303 (Fsplit_window_internal, Fdelete_window_internal)
304 (grow_mini_window, shrink_mini_window)
305 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 306
c7e73be5
JD
3072011-06-26 Jan Djärv <jan.h.d@swipnet.se>
308
309 * emacsgtkfixed.h: State that this is only used with Gtk+3.
310 (emacs_fixed_set_min_size): Remove.
311 (emacs_fixed_new): Take frame as argument.
312
313 * emacsgtkfixed.c: State that this is only used with Gtk+3.
314 (_EmacsFixedPrivate): Remove minwidth/height.
315 Add struct frame *f.
316 (emacs_fixed_init): Initialize priv->f.
317 (get_parent_class, emacs_fixed_set_min_size): Remove.
318 (emacs_fixed_new): Set priv->f to argument.
319 (emacs_fixed_get_preferred_width)
320 (emacs_fixed_get_preferred_height): Use min_width/height from
321 frames size_hint to set minimum and natural (Bug#8919).
322 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
323 and use min_width/height from frames size_hint to set
324 min_width/height (Bug#8919).
325
326 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
327 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
328 Fix indentation.
c7e73be5 329
cf99dcf8
EZ
3302011-06-26 Eli Zaretskii <eliz@gnu.org>
331
332 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
333 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
334 called at ZV.
335
029529ac
CY
3362011-06-26 Chong Yidong <cyd@stupidchicken.com>
337
338 * process.c (wait_reading_process_output): Bypass select if
339 waiting for a cell while ignoring keyboard input, and input is
340 pending. Suggested by Jan Djärv (Bug#8869).
341
7a7ef429
PE
3422011-06-25 Paul Eggert <eggert@cs.ucla.edu>
343
344 Use gnulib's dup2 module instead of rolling our own.
345 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
346
11fdef7d 3472011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
348
349 * dispnew.c (scrolling_window): Before scrolling, turn off a
350 mouse-highlight in the window being scrolled.
351
cd3520a4
JB
3522011-06-24 Juanma Barranquero <lekktu@gmail.com>
353
354 Move DEFSYM to lisp.h and use everywhere.
355
356 * character.h (DEFSYM): Move declaration...
357 * lisp.h (DEFSYM): ...here.
358
359 * gnutls.c:
360 * minibuf.c:
361 * w32menu.c:
362 * w32proc.c:
363 * w32select.c: Don't include character.h.
364
365 * alloc.c (syms_of_alloc):
366 * buffer.c (syms_of_buffer):
367 * bytecode.c (syms_of_bytecode):
368 * callint.c (syms_of_callint):
369 * casefiddle.c (syms_of_casefiddle):
370 * casetab.c (init_casetab_once):
371 * category.c (init_category_once, syms_of_category):
372 * ccl.c (syms_of_ccl):
373 * cmds.c (syms_of_cmds):
374 * composite.c (syms_of_composite):
375 * dbusbind.c (syms_of_dbusbind):
376 * dired.c (syms_of_dired):
377 * dispnew.c (syms_of_display):
378 * doc.c (syms_of_doc):
379 * editfns.c (syms_of_editfns):
380 * emacs.c (syms_of_emacs):
381 * eval.c (syms_of_eval):
382 * fileio.c (syms_of_fileio):
383 * fns.c (syms_of_fns):
384 * frame.c (syms_of_frame):
385 * fringe.c (syms_of_fringe):
386 * insdel.c (syms_of_insdel):
387 * keymap.c (syms_of_keymap):
388 * lread.c (init_obarray, syms_of_lread):
389 * macros.c (syms_of_macros):
390 * msdos.c (syms_of_msdos):
391 * print.c (syms_of_print):
392 * process.c (syms_of_process):
393 * search.c (syms_of_search):
394 * sound.c (syms_of_sound):
395 * syntax.c (init_syntax_once, syms_of_syntax):
396 * terminal.c (syms_of_terminal):
397 * textprop.c (syms_of_textprop):
398 * undo.c (syms_of_undo):
399 * w32.c (globals_of_w32):
400 * window.c (syms_of_window):
401 * xdisp.c (syms_of_xdisp):
402 * xfaces.c (syms_of_xfaces):
403 * xfns.c (syms_of_xfns):
404 * xmenu.c (syms_of_xmenu):
405 * xsettings.c (syms_of_xsettings):
406 * xterm.c (syms_of_xterm): Use DEFSYM.
407
4228cf16
TZ
4082011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
409
cd3520a4 410 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 411
7fcccf1e
PE
4122011-06-23 Paul Eggert <eggert@cs.ucla.edu>
413
7efb4e0e
PE
414 Integer and buffer overflow fixes (Bug#8873).
415
ff5844ad
PE
416 * print.c (printchar, strout): Check for string overflow.
417 (PRINTPREPARE, printchar, strout):
418 Don't set size unless allocation succeeds.
419
90532f02
PE
420 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
421 for sizes. Check for string overflow more accurately.
422 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
423
6d84508d
PE
424 * macros.c: Integer and buffer overflow fixes.
425 * keyboard.h (struct keyboard.kbd_macro_bufsize):
426 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
427 Use ptrdiff_t, not int, for sizes.
428 Don't increment bufsize until after realloc succeeds.
429 Check for size-calculation overflow.
430 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
431
437b2cb4
PE
432 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
433
8b9ac8b4
PE
434 * lread.c: Integer overflow fixes.
435 (read_integer): Radix is now EMACS_INT, not int,
436 to improve quality of diagnostics for out-of-range radices.
437 Calculate buffer size correctly for out-of-range radices.
438 (read1): Check for integer overflow in radices, and in
439 read-circle numbers.
82cb60d3
PE
440 (read_escape): Avoid int overflow.
441 (Fload, openp, read_buffer_size, read1)
442 (substitute_object_recurse, read_vector, read_list, map_obarray):
443 Use ptrdiff_t, not int, for sizes.
444 (read1): Use EMACS_INT, not int, for sizes.
20270765 445 Check for size overflow.
8b9ac8b4 446
7fcccf1e
PE
447 * image.c (cache_image): Check for size arithmetic overflow.
448
bfbbd7e7
PE
449 * lread.c: Integer overflow issues.
450 (saved_doc_string_size, saved_doc_string_length)
451 (prev_saved_doc_string_size, prev_saved_doc_string_length):
452 Now ptrdiff_t, not int.
453 (read1): Don't assume doc string length fits in int. Check for
454 out-of-range doc string lengths.
455 (read_list): Don't assume file position fits in int.
39019e54 456 (read_escape): Check for hex character overflow.
bfbbd7e7 457
4e323265
LL
4582011-06-22 Leo Liu <sdl.web@gmail.com>
459
460 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
461 Move to minibuffer.el.
462
85fece3e
PE
4632011-06-22 Paul Eggert <eggert@cs.ucla.edu>
464
20b84ce9 465 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
466 The following patches are for when GLYPH_DEBUG && !XASSERT.
467 * dispextern.h (trace_redisplay_p, dump_glyph_string):
468 * dispnew.c (flush_stdout):
469 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
470 Mark as externally visible.
471 * dispnew.c (check_window_matrix_pointers): Now static.
472 * dispnew.c (window_to_frame_vpos):
473 * xfns.c (unwind_create_frame):
474 * xterm.c (x_check_font): Remove unused local.
475 * scroll.c (CHECK_BOUNDS):
476 * xfaces.c (cache_fache): Rename local to avoid shadowing.
477 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
478 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
479 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
480 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
481 Now static.
482 (debug_method_add): Use va_list and vsprintf rather than relying
483 on undefined behavior with wrong number of arguments.
484 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
485 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
486 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
487 since we're not interested in debugging glyphs with old libraries.
488 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
489 GCC 4.6.0's static checking.
490
0766b489
PE
4912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
492
31fd4b32
PE
493 Integer overflow and signedness fixes (Bug#8873).
494 A few related buffer overrun fixes, too.
495
b79e8648
PE
496 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
497
0766b489
PE
498 * dispextern.h (struct face.stipple):
499 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
500 (x_bitmap_mask, x_allocate_bitmap_record)
501 (x_create_bitmap_from_data, x_create_bitmap_from_file)
502 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
503 (x_create_bitmap_from_xpm_data):
504 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
505 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
506 (.bitmaps_last):
507 * xfaces.c (load_pixmap):
508 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
509 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
510 (.bitmaps_last, struct x_output.icon_bitmap):
511 Use ptrdiff_t, not int, for bitmap indexes.
512 (x_allocate_bitmap_record): Check for size overflow.
513 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
514
b081724f
PE
515 Use ptrdiff_t, not int, for overlay counts.
516 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
517 * editfns.c (overlays_around, get_pos_property):
518 * textprop.c (get_char_property_and_overlay):
519 * xdisp.c (next_overlay_change, note_mouse_highlight):
520 * xfaces.c (face_at_buffer_position):
21514da7
PE
521 * buffer.c (OVERLAY_COUNT_MAX): New macro.
522 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
523 (Fnext_overlay_change, Fprevious_overlay_change)
524 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 525 Use ptrdiff_t, not int, for sizes.
21514da7 526 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 527
3de73e5e
PE
528 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
529
2606c57b
PE
530 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
531 (x_session_initialize): Do not assume string length fits in int.
532
aaafe47a
PE
533 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
534 This is unlikely, but can occur if DPI is outlandish.
535
2674ddc8 536 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
537 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
538
28154962
PE
539 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
540 * xrdb.c (magic_file_p, search_magic_path):
541 Omit last arg SUFFIX; it was always 0. All callers changed.
542 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
543
7de51af5
PE
544 * xfont.c (xfont_match): Avoid need for strlen.
545
25ed6cc3
PE
546 * xfns.c: Don't assume strlen fits in int.
547 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
548
4eab31dd
PE
549 * xdisp.c (message_log_check_duplicate): Return intmax_t,
550 not unsigned long, as we prefer signed integers. All callers changed.
551 Detect integer overflow in repeat count.
552 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 553 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 554
171e2a58
PE
555 * termcap.c: Don't assume sizes fit in int and never overflow.
556 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
557 (gobble_line): Check for size-calculation overflow.
558
ad39faca 559 * minibuf.c (Fread_buffer):
6e5bb2dc 560 * lread.c (intern, intern_c_string):
74ca2eb3
PE
561 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
562 Don't assume string length fits in int.
563
52c61c22 564 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
565 * gtkutil.c (style_changed_cb): Avoid need for strlen.
566
b5b8c9e5
PE
567 * font.c: Don't assume string length fits in int.
568 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
569 Use ptrdiff_t, not int.
ccd6111c
PE
570 (font_intern_prop): Don't assume string length fits in int.
571 Don't assume integer property fits in fixnum.
572 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 573
882f0d81 574 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 575 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
576 Reformulate so as not to need the command string.
577 Invoke gzip -cd rather than gunzip, as it's more portable.
578 (lock_info_type, lock_file_1, lock_file):
579 Don't assume pid_t and time_t fit in unsigned long.
580 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
581 (current_lock_owner): Prefer signed type for sizes.
582 Use memcpy, not strncpy, where memcpy is what is really wanted.
583 Don't assume (via atoi) that time_t and pid_t fit in int.
584 Check for time_t and/or pid_t out of range, e.g., via a network share.
585 Don't alloca where an auto var works fine.
586
93f4cf88
PE
587 * fileio.c: Fix some integer overflow issues.
588 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
589 Don't assume string length fits in int.
590 (directory_file_name): Don't assume string length fits in long.
591 (make_temp_name): Don't assume pid fits in int, or that its print
592 length is less than 20.
593
f3e92b69
PE
594 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
595
1bfdaf10
PE
596 * coding.c (make_subsidiaries): Don't assume string length fits in int.
597
35016e9a
PE
598 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
599
3d1e65a1
PE
600 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
601 We prefer signed integers, even for size calculations.
602
0b963a93
PE
603 * emacs.c: Don't assume string length fits in 'int'.
604 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
605 (main): Don't invoke strlen when not needed.
606
573f4b54
PE
607 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
608 (XD_DEBUG_MESSAGE): Don't waste a byte.
609
989f33ba
PE
610 * callproc.c (getenv_internal_1, getenv_internal)
611 (Fgetenv_internal):
965d34eb
PE
612 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
613
e4d29b33
PE
614 * lread.c (invalid_syntax): Omit length argument.
615 All uses changed. This doesn't fix a bug, but it simplifies the
616 code away from its former Hollerith-constant appearance, and it's
617 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 618 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 619
eb49b136
PE
620 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
621 This didn't break anything, but it didn't help either.
622 It's confusing to put a bogus integer in a place where the actual
623 value does not matter.
9f62aeb1 624 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 625 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 626
15375a22
PE
627 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
628 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
629 implementation.
b61cc01c
PE
630 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
631 We prefer signed types, and the value cannot exceed the EMACS_INT
632 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
633 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
634 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
635 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 636
53b2623d
PE
637 * indent.c (sane_tab_width): New function.
638 (current_column, scan_for_column, Findent_to, position_indentation)
639 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 640 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 641
51cab52b 642 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 643
f2ed8a70
PE
644 * lisp.h (lint_assume): New macro.
645 * composite.c (composition_gstring_put_cache):
646 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
647
abe80cc6
PE
648 * editfns.c, insdel.c:
649 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 650
b02c740e
PE
651 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
652
ebc96716
PE
653 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
654
b4e50fa0 655 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 656 Use much-faster test for byte-length change.
311d5d7c 657 Don't assume string byte-length fits in 'int'.
a4cf38e4 658 Check that character arg fits in 'int'.
85461888 659 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 660
c0c1ee9f
PE
661 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
662
a498d7f4
PE
663 * fns.c (concat): Catch string overflow earlier.
664 Do not rely on integer wraparound.
665
51cab52b
PE
666 * dispextern.h (struct it.overlay_strings_charpos)
667 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
668 * xdisp.c (forward_to_next_line_start)
669 (back_to_previous_visible_line_start)
670 (reseat_at_next_visible_line_start, next_element_from_buffer):
671 Don't arbitrarily truncate the value of 'selective' to int.
672
76031fad
PE
673 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
674
5eb55db9
PE
675 * composite.c: Don't truncate sizes to 'int'.
676 (composition_gstring_p, composition_reseat_it)
677 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
678 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
679 not EMACS_UINT, for indexes.
5eb55db9 680
0703a717
PE
681 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
682
d6202519
PE
683 * buffer.c: Include <verify.h>.
684 (struct sortvec.priority, struct sortstr.priority):
8961a454 685 Now EMACS_INT, not int.
c20998a7 686 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
687 (struct sortstr.size, record_overlay_string)
688 (struct sortstrlist.size, struct sortlist.used):
689 Don't truncate size to int.
690 (record_overlay_string): Check for size-calculation overflow.
d6202519 691 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 692
d5a19415
JM
6932011-06-22 Jim Meyering <meyering@redhat.com>
694
029529ac 695 Don't leak an XBM-image-sized buffer
d5a19415
JM
696 * image.c (xbm_load): Free the image buffer after using it.
697
a9041e6c
PE
6982011-06-21 Paul Eggert <eggert@cs.ucla.edu>
699
700 Port to Sun C.
701 * composite.c (find_automatic_composition): Omit needless 'return 0;'
702 that Sun C diagnosed.
703 * fns.c (secure_hash): Fix pointer signedness issue.
704 * intervals.c (static_offset_intervals): New function.
705 (offset_intervals): Use it.
706
7f3f739f
LL
7072011-06-21 Leo Liu <sdl.web@gmail.com>
708
709 * deps.mk (fns.o):
710 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
711 sha512.h.
712
713 * fns.c (secure_hash): Rename from crypto_hash_function and change
714 the first arg to accept symbols.
5b66d427 715 (Fsecure_hash): New primitive.
7f3f739f
LL
716 (syms_of_fns): New symbols.
717
76147d94
DD
7182011-06-20 Deniz Dogan <deniz@dogan.se>
719
720 * process.c (Fset_process_buffer): Clarify return value in
721 docstring.
722
7d7d0045
CY
7232011-06-18 Chong Yidong <cyd@stupidchicken.com>
724
725 * dispnew.c (add_window_display_history): Use BVAR.
726
727 * xdisp.c (debug_method_add): Use BVAR.
728 (check_window_end, dump_glyph_matrix, dump_glyph)
729 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
730
731 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
732 Likewise.
733
734 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
735 check till after the cache is created in init_frame_faces.
736
ff2bc410
SM
7372011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
738
739 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
740
28177add
PE
7412011-06-16 Paul Eggert <eggert@cs.ucla.edu>
742
dd3482fe
PE
743 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
744 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
745 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
746
393d71f3 747 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
748 * fileio.c (Finsert_file_contents):
749 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
750 Remove the old (too-loose) buffer overflow checks.
751 They weren't needed, since make_gap checks for buffer overflow.
752 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
753 The old code merely checked for Emacs fixnum overflow, and relied
754 on undefined (wraparound) behavior. The new code avoids undefined
755 behavior, and also checks for ptrdiff_t and/or size_t overflow.
756
2e6813b0 757 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
758 Tune. Don't use wider integers than needed. Don't use alloca.
759 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 760
599a9e4f
PE
761 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
762
99561444
PE
763 * insdel.c, lisp.h (buffer_overflow): New function.
764 (insert_from_buffer_1, replace_range, replace_range_2):
765 * insdel.c (make_gap_larger):
766 * editfns.c (Finsert_char):
767 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
768
28177add
PE
769 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
770
e69dafad
PE
7712011-06-15 Paul Eggert <eggert@cs.ucla.edu>
772
a7af7fde 773 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 774
b1c46f02
PE
775 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
776 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
777
e69dafad
PE
778 * fileio.c: Don't assume EMACS_INT fits in off_t.
779 (emacs_lseek): New static function.
780 (Finsert_file_contents, Fwrite_region): Use it.
781 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
782
566684ea
PE
783 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
784
e6966cd6
PE
785 * fns.c: Don't overflow int when computing a list length.
786 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
787 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
788 truncation on 64-bit hosts. Check for QUIT every
789 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
790 faster and is responsive enough.
791 (Flength): Report an error instead of overflowing an integer.
792 (Fsafe_length): Return a float if the value is not representable
793 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 794 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 795 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 796
dd0b0efb
PE
797 * alloc.c: Check that resized vectors' lengths fit in fixnums.
798 (header_size, word_size): New constants.
799 (allocate_vectorlike): Don't check size overflow here.
800 (allocate_vector): Check it here instead, since this is the only
801 caller of allocate_vectorlike that could cause overflow.
802 Check that the new vector's length is representable as a fixnum.
803
86fe5cfe
PE
804 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
805 The previous code was bogus. For example, next_almost_prime (32)
806 returned 39, which is undesirable as it is a multiple of 3; and
807 next_almost_prime (24) returned 25, which is a multiple of 5 so
808 why was the code bothering to check for multiples of 7?
809
80e88859
PE
810 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
811
4a2f0ad6
PE
812 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
813
f66c7cf8
PE
814 Variadic C functions now count arguments with ptrdiff_t.
815 This partly undoes my 2011-03-30 change, which replaced int with size_t.
816 Back then I didn't know that the Emacs coding style prefers signed int.
817 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
818 were being counted with int, which may truncate counts on 64-bit
819 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
820 * lisp.h (struct Lisp_Subr.function.aMANY)
821 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
822 Arg counts are now ptrdiff_t, not size_t.
823 All variadic functions and their callers changed accordingly.
824 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
825 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
826 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
827 * callint.c (Fcall_interactively): Check arg count for overflow,
828 to avoid potential buffer overrun. Use signed char, not 'int',
829 for 'varies' array, so that we needn't bother to check its size
830 calculation for overflow.
831 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
832 * eval.c (apply_lambda):
833 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
834 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
835 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
836
a1759b76
PE
837 * callint.c (Fcall_interactively): Don't use index var as event count.
838
d96be9fc
PE
839 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
840 * mem-limits.h (SIZE): Remove; no longer used.
841
a690a978 842 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 843
578c21e6
PE
844 Remove unnecessary casts.
845 * xterm.c (x_term_init):
846 * xfns.c (x_set_border_pixel):
847 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
848 These aren't needed now that we assume ANSI C.
849
96f53c6c
PE
850 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
851 It's more likely to cause problems (due to unsigned overflow)
852 than to cure them.
853
83c77d31
PE
854 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
855
ee2079f1
PE
856 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
857
6da65536
PE
858 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
859
7147c4a4
PE
860 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
861
193e32d9
PE
862 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
863
e5533da6
PE
864 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
865
9910e595
PE
866 GLYPH_CODE_FACE returns EMACS_INT, not int.
867 * dispextern.h (merge_faces):
868 * xfaces.c (merge_faces):
01103c44
PE
869 * xdisp.c (get_next_display_element, next_element_from_display_vector):
870 Don't assume EMACS_INT fits in int.
9910e595 871
2638320e
PE
872 * character.h (CHAR_VALID_P): Remove unused parameter.
873 * fontset.c, lisp.h, xdisp.c: All uses changed.
874
045eb8d9
PE
875 * editfns.c (Ftranslate_region_internal): Omit redundant test.
876
c1f134b5
PE
877 * fns.c (concat): Minor tuning based on overflow analysis.
878 This doesn't fix any bugs. Use int to hold character, instead
879 of constantly refetching from Emacs object. Use XFASTINT, not
880 XINT, for value known to be a character. Don't bother comparing
881 a single byte to 0400, as it's always less.
882
395fcb93 883 * floatfns.c (Fexpt):
327eeec8
PE
884 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
885
abbd3d23
PE
886 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
887 for characters.
888
684a03ef
PE
889 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
890
0fed43f3
PE
891 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
892 Without this fix, on a 64-bit host (aset S 0 4294967386) would
893 incorrectly succeed when S was a string, because 4294967386 was
894 truncated before it was used.
895
8fd02eb7
PE
896 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
897 Otherwise, an out-of-range integer could cause undefined behavior
898 on a 64-bit host.
899
f8c86b69
PE
900 * composite.c: Use int, not EMACS_INT, for characters.
901 (fill_gstring_body, composition_compute_stop_pos): Use int, not
902 EMACS_INT, for values that are known to be in character range.
903 This doesn't fix any bugs but is the usual style inside Emacs and
904 may generate better code on 32-bit machines.
905
34206dd2
PE
906 Make sure a 64-bit char is never passed to ENCODE_CHAR.
907 This is for reasons similar to the recent CHAR_STRING fix.
908 * charset.c (Fencode_char): Check that character arg is actually
909 a character. Pass an int to ENCODE_CHAR.
910 * charset.h (ENCODE_CHAR): Verify that the character argument is no
911 wider than 'int', as a compile-time check to prevent future regressions
912 in this area.
913
c5958d4c 914 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
915
916 Make sure a 64-bit char is never passed to CHAR_STRING.
917 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
918 by silently ignoring the top 32 bits, allowing some values
919 that were far too large to be valid characters.
920 * character.h: Include <verify.h>.
921 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
922 arguments are no wider than unsigned, as a compile-time check
923 to prevent future regressions in this area.
924 * data.c (Faset):
01103c44 925 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
926 (Fsubst_char_in_region):
927 * fns.c (concat):
928 * xdisp.c (decode_mode_spec_coding):
929 Adjust to CHAR_STRING's new requirement.
930 * editfns.c (Finsert_char, Fsubst_char_in_region):
931 * fns.c (concat): Check that character args are actually
932 characters. Without this test, these functions did the wrong
933 thing with wildly out-of-range values on 64-bit hosts.
934
d37ca623
PE
935 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
936 These casts should not be needed on 32-bit hosts, either.
937 * keyboard.c (read_char):
938 * lread.c (Fload): Remove casts to unsigned.
939
ea204efb
PE
940 * lisp.h (UNSIGNED_CMP): New macro.
941 This fixes comparison bugs on 64-bit hosts.
942 (ASCII_CHAR_P): Use it.
943 * casefiddle.c (casify_object):
01103c44 944 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
945 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
946 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
947 * dispextern.h (FACE_FROM_ID):
948 * keyboard.c (read_char): Use UNSIGNED_CMP.
949
41cb286c
PE
950 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
951 not to EMACS_INT, to avoid GCC warning.
952
4a1b9832
PE
953 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
954
55daad71
PE
955 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
956 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
957 isn't needed on 32-bit machines.
8f95c75c 958
01103c44
PE
959 * buffer.c (Fgenerate_new_buffer_name):
960 Use EMACS_INT for count, not int.
0ceccced 961 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
962
963 * data.c (Qcompiled_function): Now static.
964
c6f072e7
PE
965 * window.c (window_body_lines): Now static.
966
20ce5912
PE
967 * image.c (gif_load): Rename local to avoid shadowing.
968
9c4c5f81
PE
969 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
970 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
971 * alloc.c (make_save_value): Integer argument is now of type
972 ptrdiff_t, not int.
973 (mark_object): Use ptrdiff_t, not int.
974 * lisp.h (pD): New macro.
975 * print.c (print_object): Use it.
976
c0c5c8ae
PE
977 * alloc.c: Use EMACS_INT, not int, to count objects.
978 (total_conses, total_markers, total_symbols, total_vector_size)
979 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
980 (total_free_floats, total_floats, total_free_intervals)
981 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
982 Now EMACS_INT, not int. All uses changed.
983 (Fgarbage_collect): Compute overall total using a double, so that
984 integer overflow is less likely to be a problem. Check for overflow
985 when converting back to an integer.
5a25e253
PE
986 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
987 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
988 These were 'int' variables that could overflow on 64-bit hosts;
989 they were never used, so remove them instead of repairing them.
211a0b2a 990 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
991 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
992 Previously, this ceilinged at INT_MAX, but that doesn't work on
993 64-bit machines.
e46bb31a 994 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 995
c78baabf 996 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 997 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
998 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
999 when a (possibly-narrower) signed value would do just as well.
1000 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1001
c9d624c6
PE
1002 * alloc.c: Catch some string size overflows that we were missing.
1003 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1004 for convenience in STRING_BYTES_MAX.
1005 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1006 The definition here is exact; the one in lisp.h was approximate.
1007 (allocate_string_data): Check for string overflow. This catches
1008 some instances we weren't catching before. Also, it catches
1009 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1010 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1011 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1012
c9d624c6
PE
1013 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1014 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1015 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1016
353032ce
PE
1017 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1018
2bccce07
PE
1019 * alloc.c (Fmake_string): Check for out-of-range init.
1020
0ac30604
SM
10212011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1022
1023 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1024
c195f2de
JD
10252011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1026
1027 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1028 xg_get_default_scrollbar_width.
1029
1030 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1031 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1032 (style_changed_cb): Call update_theme_scrollbar_width and call
1033 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1034 all frames (Bug#8505).
1035 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1036 Call gtk_window_set_resizable if HAVE_GTK3.
1037 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1038 and height if HAVE_GTK3 (Bug#8505).
1039 (scroll_bar_width_for_theme): New variable.
1040 (update_theme_scrollbar_width): New function.
1041 (xg_get_default_scrollbar_width): Move code to
1042 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1043 (xg_initialize): Call update_theme_scrollbar_width.
1044
1045 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1046
1047 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1048
e10ac9f1
MR
10492011-06-12 Martin Rudalics <rudalics@gmx.at>
1050
1051 * frame.c (make_frame): Call other_buffer_safely instead of
1052 other_buffer.
1053
1054 * window.c (temp_output_buffer_show): Call display_buffer with
1055 second argument Vtemp_buffer_show_specifiers and reset latter
1056 immediately after the call.
1057 (Vtemp_buffer_show_specifiers): New variable.
1058 (auto_window_vscroll_p, next_screen_context_lines)
1059 (Vscroll_preserve_screen_position): Remove leading asterisks from
1060 doc-strings.
1061
2d3c217e 10622011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1063
7b7f97e8 1064 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1065 * buffer.c (Qclone_number): Remove for now, as it's unused.
1066 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1067 (record_buffer): Remove unused local.
1068 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1069 (set_frame_buffer_list): Remove; unused.
1070 * frame.h (other_visible_frames): Remove decl.
1071 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1072 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1073 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1074 if HAVE_GPM.
1075 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1076 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1077 Define only if HAVE_GPM.
1078 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1079 (update_hints_inhibit): Remove; never set. All uses removed.
1080 * widgetprv.h (emacsFrameClassRec): Remove decl.
1081 * window.c (delete_deletable_window): Now returns void, since it
1082 wasn't returning anything.
1083 (compare_window_configurations): Remove unused locals.
1084 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1085 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1086 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1087 the same widths as pointers. This follows up on the 2011-05-06 patch.
1088 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1089 * xterm.h: Likewise.
1090 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1091
1384b89e
JB
10922011-06-12 Juanma Barranquero <lekktu@gmail.com>
1093
1094 * makefile.w32-in: Update dependencies.
1095 (LISP_H): Add lib/intprops.h.
1096
1100a63c
CY
10972011-06-11 Chong Yidong <cyd@stupidchicken.com>
1098
1099 * image.c (gif_load): Add animation frame delay to the metadata.
1100 (syms_of_image): Use DEFSYM. New symbol `delay'.
1101
6198ccd0
MR
11022011-06-11 Martin Rudalics <rudalics@gmx.at>
1103
1104 * window.c (delete_deletable_window): Re-add.
1105 (Fset_window_configuration): Rewrite to handle dead buffers and
1106 consequently deletable windows.
1107 (window_tree, Fwindow_tree): Remove. Supply functionality in
1108 window.el.
1109 (compare_window_configurations): Simplify code.
1110
b6e3633c
AS
11112011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1112
1ab0dee5
AS
1113 * image.c (imagemagick_load_image): Fix type mismatch.
1114 (Fimagemagick_types): Likewise.
1115
b6e3633c
AS
1116 * window.h (replace_buffer_in_windows): Declare.
1117
9397e56f
MR
11182011-06-11 Martin Rudalics <rudalics@gmx.at>
1119
1120 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1121 Qclone_number. Remove external declaration of Qdelete_window.
1122 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1123 code.
1124 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1125 Qbuffer_list_update_hook if allowed.
1126 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1127 buffer list implementation.
1128 (other_buffer_safely): New function.
1129 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1130 calls to replace_buffer_in_windows and
1131 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1132 if allowed.
1133 (record_buffer): Inhibit quitting and rewrite using quittable
1134 functions. Run Qbuffer_list_update_hook if allowed.
1135 (Frecord_buffer, Funrecord_buffer): New functions.
1136 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1137 switch-to-buffer to window.el.
1138 (bury-buffer): Move to window.el.
1139 (Vbuffer_list_update_hook): New variable.
1140
1141 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1142 section.
1143
1144 * window.h (resize_frame_windows): Move up in code.
1145 (Fwindow_frame): Remove EXFUN.
1146 (replace_buffer_in_all_windows): Remove prototype.
1147 (replace_buffer_in_windows_safely): Add prototype.
1148
1149 * window.c: Declare Qdelete_window static again. Move down
1150 declaration of select_count.
1151 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1152 (Fother_window): Move to window.el.
1153 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1154 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1155 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1156 window.el.
1157 (replace_buffer_in_windows): Implement by calling
1158 Qreplace_buffer_in_windows.
1159 (replace_buffer_in_all_windows): Remove with some functionality
1160 moved into replace_buffer_in_windows_safely.
1161 (replace_buffer_in_windows_safely): New function.
1162 (select_window_norecord, select_frame_norecord): Move in front
1163 of run_window_configuration_change_hook. Remove now obsolete
1164 declarations.
1165 (Fset_window_buffer): Rewrite doc-string. Call
1166 Qrecord_window_buffer.
1167 (keys_of_window): Move binding for other-window to window.el.
1168
b50691aa
CY
11692011-06-11 Chong Yidong <cyd@stupidchicken.com>
1170
1171 * dispextern.h (struct image): Replace data member, whose int_val
1172 and ptr_val fields were not used by anything, with a single
1173 lisp_val object.
1174
1175 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1176 (gif_clear_image, gif_load, imagemagick_load_image)
1177 (gs_clear_image, gs_load): Callers changed.
1178
3f754b86
PE
11792011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1180
cca69397
PE
1181 * buffer.h: Include <time.h>, for time_t.
1182 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1183
109e28d0
PE
1184 Fix minor problems found by static checking.
1185
60737f02
PE
1186 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1187
4b66faf3
PE
1188 Make identifiers static if they are not used in other modules.
1189 * data.c (Qcompiled_function, Qframe, Qvector):
1190 * image.c (QimageMagick, Qsvg):
1191 * minibuf.c (Qmetadata):
1192 * window.c (resize_window_check, resize_root_window): Now static.
1193 * window.h (resize_window_check, resize_root_window): Remove decls.
1194
109e28d0
PE
1195 * window.c (window_deletion_count, delete_deletable_window):
1196 Remove; unused.
46a4ce9e
PE
1197 (window_body_lines): Now static.
1198 (Fdelete_other_windows_internal): Mark vars as initialized.
1199 Make sure 'resize_failed' is initialized.
1200 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1201 (resize_window_apply): Remove unused local.
1202 * window.h (delete_deletable_window): Remove decl.
1203
109e28d0 1204 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1205 (imagemagick_load_image): Fix pointer signedness problem by changing
1206 last arg from unsigned char * to char *. All uses changed.
1207 Also, fix a local for similar reasons.
1208 Remove unused locals. Remove locals to avoid shadowing.
1209 (fn_rsvg_handle_free): Remove; unused.
1210 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1211 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1212
3f754b86
PE
1213 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1214
2547adb1
CY
12152011-06-10 Chong Yidong <cyd@stupidchicken.com>
1216
1217 * image.c (gif_load): Fix omitted cast error introduced by
1218 2011-06-06 change.
1219
2c8e37d4
MR
12202011-06-10 Martin Rudalics <rudalics@gmx.at>
1221
1222 * window.h (resize_proportionally, orig_total_lines)
1223 (orig_top_line): Remove from window structure.
1224 (set_window_height, set_window_width, change_window_heights)
1225 (Fdelete_window): Remove prototypes.
1226 (resize_frame_windows): Remove duplicate declaration.
1227
440a42e3
EZ
12282011-06-10 Eli Zaretskii <eliz@gnu.org>
1229
1230 * window.h (resize_frame_windows, resize_window_check)
1231 (delete_deletable_window, resize_root_window)
1232 (resize_frame_windows): Declare prototypes.
1233
1234 * window.c (resize_window_apply): Make definition be "static" to
1235 match the prototype.
1236
562dd5e9
MR
12372011-06-10 Martin Rudalics <rudalics@gmx.at>
1238
1239 * window.c: Remove declarations of Qwindow_size_fixed,
1240 window_min_size_1, window_min_size_2, window_min_size,
1241 size_window, window_fixed_size_p, enlarge_window, delete_window.
1242 Remove static from declaration of Qdelete_window, it's
1243 temporarily needed by Fbury_buffer.
1244 (replace_window): Don't assign orig_top_line and
1245 orig_total_lines.
1246 (Fdelete_window, delete_window): Remove. Window deletion is
1247 handled by window.el.
1248 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1249 Fdelete_window calls with calls to Qdelete_window.
1250 (Fdelete_other_windows): Remove. Deleting other windows is
1251 handled by window.el.
1252 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1253 handled in window.el.
1254 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1255 Window minimum sizes are handled in window.el.
1256 (shrink_windows, size_window, set_window_height)
1257 (set_window_width, change_window_heights, window_height)
1258 (window_width, CURBEG, CURSIZE, enlarge_window)
1259 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1260 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1261 handled in window.el.
1262 (make_dummy_parent): Rename to make_parent_window and give it a
1263 second argument horflag.
1264 (make_window): Don't set resize_proportionally any more.
1265 (Fsplit_window): Remove. Windows are split in window.el.
1266 (save_restore_action, save_restore_orig_size)
1267 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1268 Resize mini windows in window.el.
1269 (grow_mini_window, shrink_mini_window): Implement by calling
1270 Qresize_root_window_vertically, resize_window_check and
1271 resize_window_apply.
1272 (saved_window, Fset_window_configuration, save_window_save): Do
1273 not handle orig_top_line, orig_total_lines, and
1274 resize_proportionally.
1275 (window_min_height, window_min_width): Move to window.el.
1276 (keys_of_window): Move bindings for delete-other-windows,
1277 split-window, delete-window and enlarge-window to window.el.
1278
1279 * buffer.c: Temporarily extern Qdelete_window.
1280 (Fbury_buffer): Temporarily call Qdelete_window instead of
1281 Fdelete_window (Fbury_buffer will move to window.el soon).
1282
1283 * frame.c (set_menu_bar_lines_1): Remove code handling
1284 orig_top_line and orig_total_lines.
1285
1286 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1287 set_window_height but set heights directly.
1288 (change_frame_size_1): Use resize_frame_windows.
1289
1290 * xdisp.c (init_xdisp): Don't use set_window_height but set
1291 heights directly.
1292
1293 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1294 resize_frame_windows instead of change_window_heights and run
1295 run_window_configuration_change_hook.
1296
1297 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1298 instead of change_window_heights and run
1299 run_window_configuration_change_hook.
1300
1a13852e
MR
13012011-06-09 Martin Rudalics <rudalics@gmx.at>
1302
1303 * window.c (replace_window): Rename second argument REPLACEMENT to
1304 NEW. New third argument SETFLAG. Rewrite.
1305 (delete_window, make_dummy_parent): Call replace_window with
1306 third argument 1.
1307 (window_list_1): Move down in code.
1308 (run_window_configuration_change_hook): Move set_buffer part
1309 before select_frame_norecord part in order to unwind correctly.
1310 Rename count1 to count.
1311 (recombine_windows, delete_deletable_window, resize_root_window)
1312 (Fdelete_other_windows_internal)
1313 (Frun_window_configuration_change_hook, make_parent_window)
1314 (resize_window_check, resize_window_apply, Fresize_window_apply)
1315 (resize_frame_windows, Fsplit_window_internal)
1316 (Fdelete_window_internal, Fresize_mini_window_internal): New
1317 functions.
1318 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1319
f3d1777e
MR
13202011-06-08 Martin Rudalics <rudalics@gmx.at>
1321
496e208e
MR
1322 * window.h (window): Add some new members to window structure -
1323 normal_lines, normal_cols, new_total, new_normal, clone_number,
1324 splits, nest, prev_buffers, next_buffers.
1325 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1326 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1327
f3d1777e
MR
1328 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1329 Remove.
496e208e
MR
1330 (make_dummy_parent): Set new members of windows structure.
1331 (make_window): Move down in code. Handle new members of window
1332 structure.
1333 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1334 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1335 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1336 (Fset_window_prev_buffers, Fwindow_next_buffers)
1337 (Fset_window_next_buffers, Fset_window_clone_number): New
1338 functions.
1339 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1340 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1341 Doc-string fixes.
1342 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1343 Argument WINDOW can be now internal window too.
1344 (Fwindow_use_time): Move up in code.
1345 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1346 Rewrite doc-string.
1347 (Fset_window_configuration, saved_window)
1348 (Fcurrent_window_configuration, save_window_save): Handle new
1349 members of window structure.
b9e809c2
MR
1350 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1351 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1352 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1353 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1354 Qget_mru_window, Qresize_root_window,
1355 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1356 Qauto_buffer_name; staticpro them.
f3d1777e 1357
abde8f8c
MR
13582011-06-07 Martin Rudalics <rudalics@gmx.at>
1359
1360 * window.c (Fwindow_total_size, Fwindow_left_column)
1361 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1362 (Fwindow_list_1): New functions.
1363 (window_box_text_cols): Replace with window_body_cols.
1364 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1365 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1366 (delete_window, Fset_window_configuration): Call
1367 delete_all_subwindows with window as argument.
1368 (delete_all_subwindows): Take a window as argument and not a
1369 structure. Rewrite.
190b47e6
MR
1370 (window_loop): Remove handling of GET_LRU_WINDOW and
1371 GET_LARGEST_WINDOW.
1372 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1373
1374 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1375 window_box_text_cols. delete_all_subwindows now takes a
1376 Lisp_Object as argument.
abde8f8c
MR
1377
1378 * indent.c (compute_motion, Fcompute_motion): Use
1379 window_body_cols instead of window_box_text_cols.
1380
fa8a67e6
MR
1381 * frame.c (delete_frame): Call delete_all_subwindows with root
1382 window as argument.
1383
a54e3482
DC
13842011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1385
1386 * fns.c (Fputhash): Document return value.
1387
60002bf5
CY
13882011-06-06 Chong Yidong <cyd@stupidchicken.com>
1389
1390 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1391
0c671da6 13922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1393
b862a52a 1394 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1395
be44ca6c
PE
1396 Check for overflow when converting integer to cons and back.
1397 * charset.c (Fdefine_charset_internal, Fdecode_char):
1398 Use cons_to_unsigned to catch overflow.
1399 (Fencode_char): Use INTEGER_TO_CONS.
1400 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1401 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1402 * data.c (long_to_cons, cons_to_long): Remove.
1403 (cons_to_unsigned, cons_to_signed): New functions.
1404 These signal an error for invalid or out-of-range values.
1405 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1406 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1407 * font.c (Ffont_variation_glyphs):
1408 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1409 * lisp.h: Include <intprops.h>.
1410 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1411 (cons_to_signed, cons_to_unsigned): New decls.
1412 (long_to_cons, cons_to_long): Remove decls.
1413 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1414 (Fprimitive_undo): Use CONS_TO_INTEGER.
1415 * xfns.c (Fx_window_property): Likewise.
1416 * xselect.c: Include <limits.h>.
1417 (x_own_selection, selection_data_to_lisp_data):
1418 Use INTEGER_TO_CONS.
1419 (x_handle_selection_request, x_handle_selection_clear)
1420 (x_get_foreign_selection, Fx_disown_selection_internal)
1421 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1422 (lisp_data_to_selection_data): Use cons_to_unsigned.
1423 (x_fill_property_data): Use cons_to_signed.
1424 Report values out of range.
1425
d1f3d2af
PE
1426 Check for buffer and string overflow more precisely.
1427 * buffer.h (BUF_BYTES_MAX): New macro.
1428 * lisp.h (STRING_BYTES_MAX): New macro.
1429 * alloc.c (Fmake_string):
1430 * character.c (string_escape_byte8):
1431 * coding.c (coding_alloc_by_realloc):
1432 * doprnt.c (doprnt):
1433 * editfns.c (Fformat):
1434 * eval.c (verror):
1435 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1436 since they may not be the same number.
1437 * editfns.c (Finsert_char):
1438 * fileio.c (Finsert_file_contents):
1439 Likewise for BUF_BYTES_MAX.
1440
dd52fcea
PE
1441 * image.c: Use ptrdiff_t, not int, for sizes.
1442 (slurp_file): Switch from int to ptrdiff_t.
1443 All uses changed.
1444 (slurp_file): Check that file size fits in both size_t (for
1445 malloc) and ptrdiff_t (for sanity and safety).
1446
7f9bbdbb
PE
1447 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1448 if b->modtime has its maximal value.
1449
dfe18f82
PE
1450 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1451
84acfcf0
PE
1452 Don't assume time_t can fit into int.
1453 * buffer.h (struct buffer.modtime): Now time_t, not int.
1454 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1455 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1456
ccd9a01a
PE
1457 Minor fixes for signed vs unsigned integers.
1458 * character.h (MAYBE_UNIFY_CHAR):
1459 * charset.c (maybe_unify_char):
1460 * keyboard.c (read_char, reorder_modifiers):
1461 XINT -> XFASTINT, since the integer must be nonnegative.
1462 * ftfont.c (ftfont_spec_pattern):
1463 * keymap.c (access_keymap, silly_event_symbol_error):
1464 XUINT -> XFASTINT, since the integer must be nonnegative.
1465 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1466 since it makes no difference and we prefer signed.
1467 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1468 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1469 nonnegative.
1470
d6d100dd
SM
14712011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1472
1473 * window.h (Fwindow_frame): Declare.
1474
2b6148e4
PE
14752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1476
1477 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1478 (SPARE_MEMORY): Always define.
1479 (LARGE_REQUEST): Remove.
1480 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1481
f230ecc9
MR
14822011-06-06 Martin Rudalics <rudalics@gmx.at>
1483
727e958e
MR
1484 * lisp.h: Move EXFUNS for Fframe_root_window,
1485 Fframe_first_window and Fset_frame_selected_window to window.h.
1486
1487 * window.h: Move EXFUNS for Fframe_root_window,
1488 Fframe_first_window and Fset_frame_selected_window here from
1489 lisp.h.
1490
1491 * frame.c (Fwindow_frame, Fframe_first_window)
1492 (Fframe_root_window, Fframe_selected_window)
1493 (Fset_frame_selected_window): Move to window.c.
1494 (Factive_minibuffer_window): Move to minibuf.c.
1495 (Fother_visible_frames_p): New function.
1496
1497 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1498
f230ecc9
MR
1499 * window.c (decode_window, decode_any_window): Move up in code.
1500 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1501 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1502 (Fwindow_buffer): Move up and rewrite doc-string.
1503 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1504 (Fwindow_prev): New functions.
727e958e
MR
1505 (Fwindow_frame): Move here from frame.c. Accept any window as
1506 argument.
1507 (Fframe_root_window, Fframe_first_window)
1508 (Fframe_selected_window): Move here from frame.c. Accept frame
1509 or arbitrary window as argument. Update doc-strings.
1510 (Fminibuffer_window): Move up in code.
1511 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1512 (Fset_frame_selected_window): Move here from frame.c.
1513 Marginal rewrite.
727e958e
MR
1514 (Fselected_window, select_window, Fselect_window): Move up in
1515 code. Minor doc-string fixes.
f230ecc9 1516
4d09bcf6
PE
15172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1518
1519 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1520 Do not assume that spare memory exists; that assumption is valid
1521 only if SYSTEM_MALLOC.
1522 (LARGE_REQUEST): New macro, so that the issue of large requests
1523 is separated from the issue of spare memory.
1524
810928a2
AS
15252011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1526
172418ad
AS
1527 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1528 format. (Bug#8806)
1529
43f862f7
AS
1530 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1531
810928a2
AS
1532 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1533 before statements.
1534
a059fe24
JD
15352011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1536
1537 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1538
1539 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1540
1541 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1542 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1543
989bf368
JB
15442011-06-05 Juanma Barranquero <lekktu@gmail.com>
1545
1546 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1547
4b80f674
CY
15482011-06-04 Chong Yidong <cyd@stupidchicken.com>
1549
1550 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1551 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1552 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1553 New error handlers.
4b80f674
CY
1554 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1555 Obey Vx_select_enable_clipboard_manager. Catch errors in
1556 x_clipboard_manager_save (Bug#8779).
1557 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1558 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1559
99a33b77 15602011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1561
1562 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1563
99a33b77 15642011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1565
1566 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1567 in the current matrix if keep_current_p is non-zero.
1568
8264569d
EZ
15692011-06-04 Eli Zaretskii <eliz@gnu.org>
1570
1571 * bidi.c (bidi_level_of_next_char): Fix last change.
1572
57f97249
EZ
15732011-06-03 Eli Zaretskii <eliz@gnu.org>
1574
fec2107c 1575 Support bidi reordering of text covered by display properties.
57f97249 1576
fec2107c
EZ
1577 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1578 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1579 (bidi_cache_search, bidi_cache_iterator_state)
1580 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1581 (bidi_level_of_next_char, bidi_move_to_visually_next):
1582 Support character positions inside a run of characters covered by a
fec2107c
EZ
1583 display string.
1584 (bidi_paragraph_init, bidi_resolve_explicit_1)
1585 (bidi_level_of_next_char): Call bidi_fetch_char and
1586 bidi_fetch_char_advance instead of FETCH_CHAR and
1587 FETCH_CHAR_ADVANCE.
1588 (bidi_init_it): Initialize new members.
1589 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1590 definitions.
1591 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1592 instead of using explicit *_CHAR codes.
d6d100dd
SM
1593 (bidi_resolve_explicit, bidi_resolve_weak):
1594 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1595 bidirectional text is supported only in multibyte buffers.
1596 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1597 it to initialize the frame_window_p member of struct bidi_it.
1598 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1599 (bidi_resolve_explicit, bidi_resolve_weak)
1600 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1601 bidi_it->nchars is non-positive.
1602 (bidi_level_of_next_char): Don't try to lookup the cache for the
1603 next/previous character if nothing is cached there yet, or if we
1604 were just reseat()'ed to a new position.
c40e2fb2 1605
0e14fe90
EZ
1606 * xdisp.c (set_cursor_from_row): Set start and stop points
1607 according to the row's direction when priming the loop that looks
1608 for the glyph on which to display cursor.
1609 (single_display_spec_intangible_p): Function deleted.
1610 (display_prop_intangible_p): Reimplement to call
1611 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1612 Accept 3 additional arguments needed by handle_display_spec.
1613 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1614 values: lists, `(when COND...)' forms, etc.
1615 (single_display_spec_string_p): Support property values that are
1616 lists with the argument STRING its top-level element.
1617 (display_prop_string_p): Fix the condition for processing a
1618 property that is a list to be consistent with handle_display_spec.
fec2107c 1619 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1620 last portion of handle_display_prop.
1621 (compute_display_string_pos): Accept additional argument
1622 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1623 value of a `display' property is a "replacing spec".
1624 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1625 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1626 the display property, but just return a value indicating whether
1627 the display property will replace the characters it covers.
1628 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1629 frame_window_p members of struct bidi_it.
d6d100dd
SM
1630 (compute_display_string_pos, compute_display_string_end):
1631 New functions.
fec2107c
EZ
1632 (push_it): Accept second argument POSITION, where pop_it should
1633 jump to continue iteration.
1634 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1635
fec2107c
EZ
1636 * keyboard.c (adjust_point_for_property): Adjust the call to
1637 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1638
1639 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1640 (bidi_init_it): Update prototypes.
1641 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1642 (compute_display_string_pos, compute_display_string_end):
1643 Declare prototypes.
fec2107c
EZ
1644 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1645 EMACS_INT.
fc6f18ce 1646
40087514 16472011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1648
57f53182
PE
1649 Malloc failure behavior now depends on size of allocation.
1650 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1651 * lisp.h: Change signatures accordingly.
1652 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1653 All callers changed. (Bug#8762)
1654
1655 * gnutls.c: Use Emacs's memory allocators.
1656 Without this change, the gnutls library would invoke malloc etc.
1657 directly, which causes problems on non-SYNC_INPUT hosts, and which
1658 runs afoul of improving memory_full behavior. (Bug#8761)
1659 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1660 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1661 xfree instead of the default malloc, realloc, free.
1662 (Fgnutls_boot): No need to check for memory allocation failure,
1663 since xmalloc does that for us.
1664
ac32cd99 1665 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1666 * category.c (hash_get_category_set):
1667 * ccl.c (ccl_driver):
1668 * charset.c (Fdefine_charset_internal):
1669 * charset.h (struct charset.hash_index):
1670 * composite.c (get_composition_id, gstring_lookup_cache)
1671 (composition_gstring_put_cache):
1672 * composite.h (struct composition.hash_index):
1673 * dispextern.h (struct image.hash):
1674 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1675 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1676 (hashfn_equal, hashfn_user_defined, make_hash_table)
1677 (maybe_resize_hash_table, hash_lookup, hash_put)
1678 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1679 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1680 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1681 * image.c (make_image, search_image_cache, lookup_image)
1682 (xpm_put_color_table_h):
1683 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1684 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1685 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1686 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1687 * alloc.c (allocate_vectorlike):
1688 Check for overflow in vector size calculations.
1689 * ccl.c (ccl_driver):
1690 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1691 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1692 need to be updated by these changes.
40087514
PE
1693 * fns.c (make_hash_table, maybe_resize_hash_table):
1694 Check for integer overflow with large hash tables.
0de4bb68
PE
1695 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1696 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1697 (SXHASH_REDUCE): New macro.
1698 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1699 Use it instead of discarding useful hash info with large hash values.
1700 (sxhash_float): New function.
1701 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1702 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1703 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1704 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1705 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1706 Adjust signatures to match updated version of code.
1707 (consing_since_gc): Now EMACS_INT, since a single hash table can
1708 use more than INT_MAX bytes.
1709
698d32e2
DN
17102011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1711
1712 Make it possible to build with GCC-4.6+ -O2 -flto.
1713
1714 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1715
fd6fa53f
SM
17162011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1717
1718 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1719 Call minibuffer-inactive-mode.
1720
864db017
JB
17212011-05-31 Juanma Barranquero <lekktu@gmail.com>
1722
1723 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1724 Update dependencies.
1725
2ad0baf4
DN
17262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1727
1728 * data.c (init_data): Remove code for UTS, this system is not
1729 supported anymore.
1730
4fcc2638
DN
17312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1732
1733 Don't force ./temacs to start in terminal mode.
1734
1735 * frame.c (make_initial_frame): Initialize faces in all cases, not
1736 only when CANNOT_DUMP is defined.
1737 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1738
c56e0fd5
DN
17392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1740
1741 * dispnew.c (add_window_display_history): Use const for the string
1742 pointer. Remove declaration, not needed.
1743
333d54da 17442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1745
55d4c1b2 1746 Use 'inline', not 'INLINE'.
333d54da 1747 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1748 * alloc.c, fontset.c (INLINE): Remove.
1749 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1750 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1751 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1752 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1753 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1754
738db178
DN
17552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1756
1757 Make it possible to run ./temacs.
1758
1759 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1760 syms_of_callproc does the same thing. Remove test for
1761 "initialized", do it in the caller.
1762 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1763
620c53a6
SM
17642011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1765
1766 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1767 (read_minibuf): Use get_minibuffer.
1768 (syms_of_minibuf): Use DEFSYM.
1769 (Qmetadata): New var.
1770 * data.c (Qbuffer): Don't make it static.
1771 (syms_of_data): Use DEFSYM.
1772
e003a292
PE
17732011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1774
1775 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1776 (CCL_CODE_MIN): New macro.
1777
ed008a6d
PE
17782011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1779
3687c2ef
PE
1780 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1781
ed008a6d
PE
1782 * eval.c (Qdebug): Now static.
1783 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1784 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1785 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1786
d66c4c7c
CY
17872011-05-29 Chong Yidong <cyd@stupidchicken.com>
1788
1789 * image.c: Various fixes to ImageMagick code comments.
1790 (Fimagemagick_types): Doc fix.
1791
5fbc2025
PE
17922011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1793
0196f88a
PE
1794 Minor fixes prompted by GCC 4.6.0 warnings.
1795
1796 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1797
5fbc2025
PE
1798 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1799 (x_clipboard_manager_save_all): Move extern decl to ...
1800 * xterm.h: ... here, so that it can be checked for consistency.
1801
1dd3c2d9
CY
18022011-05-29 Chong Yidong <cyd@stupidchicken.com>
1803
1804 * xselect.c (x_clipboard_manager_save_frame)
1805 (x_clipboard_manager_save_all): New functions.
1806 (Fx_clipboard_manager_save): Lisp function deleted.
1807
1808 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1809 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1810
1811 * xterm.h: Update prototype.
1812
5ba6571d
WX
18132011-05-28 William Xu <william.xwl@gmail.com>
1814
1815 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1816 exiting (Bug#8239).
1817
3eaff834
JM
18182011-05-28 Jim Meyering <meyering@redhat.com>
1819
e1900994 1820 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1821 * fns.c (to_uchar): Define.
1822 (crypto_hash_function): Use it to convert some newly-signed
1823 variables to unsigned, to avoid sign-extension bugs. For example,
1824 without this change, (md5 "truc") would evaluate to
1825 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1826 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1827 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1828
0f6990a7
PE
18292011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1830
1831 Integer overflow fixes.
c8a9ca5a 1832
08686060
PE
1833 * dbusbind.c: Serial number integer overflow fixes.
1834 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1835 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1836 to hold a serial number that is too large for a fixnum.
1837 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1838 Check for serial numbers out of range. Decode any serial number
59568bf0 1839 that was so large that it became a float. (Bug#8722)
08686060 1840
2d1fc3c7
PE
1841 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1842 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1843 Use XFASTINT rather than XUINT when numbers are nonnegative.
1844 (xd_append_arg, Fdbus_method_return_internal):
1845 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1846 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1847 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1848 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1849 (Bug#8722)
2d1fc3c7 1850
c8a9ca5a
PE
1851 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1852
519e1d69
PE
1853 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1854
30569699
PE
1855 ccl: add integer overflow checks
1856 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1857 (IN_INT_RANGE): New macros.
1858 (ccl_driver): Use them to check for integer overflow when
1859 decoding a CCL program. Many of the new checks are whether XINT (x)
1860 fits in int; it doesn't always, on 64-bit hosts. The new version
1861 doesn't catch all possible integer overflows, but it's an
847044ea 1862 improvement. (Bug#8719)
30569699 1863
c11285dc
PE
1864 * alloc.c (make_event_array): Use XINT, not XUINT.
1865 There's no need for unsigned here.
1866
fdccd48e
PE
1867 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1868 This follows up to the 2011-05-06 change that substituted uintptr_t
1869 for EMACS_INT. This case wasn't caught back then.
1870
37910ab2
PE
1871 Rework Fformat to avoid integer overflow issues.
1872 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1873 now (part of C89). Include <verify.h>.
1874 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1875 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1876 (Fformat): Avoid the prepass trying to compute sizes; it was only
1877 approximate and thus did not catch overflow reliably. Instead, walk
1878 through the format just once, formatting and computing sizes as we go,
1879 checking for integer overflow at every step, and allocating a larger
1880 buffer as needed. Keep track separately whether the format is
1881 multibyte. Keep only the most-recently calculated precision, rather
1882 than them all. Record whether each argument has been converted to
1883 string. Use EMACS_INT, not int, for byte and char and arg counts.
1884 Support field widths and precisions larger than INT_MAX. Avoid
1885 sprintf's undefined behavior with conversion specifications such as %#d
1886 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1887 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1888 formatting out-of-range floating point numbers with int
9173deec 1889 formats. (Bug#8668)
37910ab2 1890
2e6578fb
PE
1891 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1892
0ae6bdee
PE
1893 * data.c: Avoid integer truncation in expressions involving floats.
1894 * data.c: Include <intprops.h>.
1895 (arith_driver): When there's an integer overflow in an expression
1896 involving floating point, convert the integers to floating point
1897 so that the resulting value does not suffer from catastrophic
1898 integer truncation. For example, on a 64-bit host (* 4
1899 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1900 Do not rely on undefined behavior after integer overflow.
1901
de883a70
PE
1902 merge count_size_as_multibyte, parse_str_to_multibyte
1903 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1904 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1905 Check for integer overflow.
1906 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1907 since it's now a duplicate of the other. This is more of
1908 a character than a buffer op, so better that it's in character.c.
1909 * fns.c, print.c: Adjust to above changes.
1910
2ff916cb
PE
19112011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1912
1913 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1914
f1b54466
PE
19152011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1916
fb1ac845
PE
1917 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1918 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1919 (x_clipboard_manager_save): Now static.
1920 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1921
f1b54466
PE
1922 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1923 (crypto_hash_function): Now static.
1924 Fix pointer signedness problems. Avoid unnecessary initializations.
1925
a9f737ee
CY
19262011-05-27 Chong Yidong <cyd@stupidchicken.com>
1927
1928 * termhooks.h (Vselection_alist): Make it terminal-local.
1929
1930 * terminal.c (create_terminal): Initialize it.
1931
1932 * xselect.c: Support for clipboard managers.
1933 (Vselection_alist): Move to termhooks.h as terminal-local var.
1934 (LOCAL_SELECTION): New macro.
1935 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1936 (symbol_to_x_atom): Remove gratuitous arg.
1937 (x_handle_selection_request, lisp_data_to_selection_data)
1938 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1939 (x_own_selection, x_get_local_selection, x_convert_selection):
1940 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1941 (some_frame_on_display): Delete unused function.
1942 (Fx_own_selection_internal, Fx_get_selection_internal)
1943 (Fx_disown_selection_internal, Fx_selection_owner_p)
1944 (Fx_selection_exists_p): New optional frame arg.
1945 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1946 (x_handle_selection_clear): Don't treat other terminals with the
1947 same keyboard specially. Use the terminal-local Vselection_alist.
1948 (x_clear_frame_selections): Use Frun_hook_with_args.
1949
1950 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1951
1952 * xterm.h: Add support for those atoms.
1953
e067f0c1
CY
19542011-05-26 Chong Yidong <cyd@stupidchicken.com>
1955
1956 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1957 (converted_selections, conversion_fail_tag): New global variables.
1958 (x_selection_request_lisp_error): Free the above.
1959 (x_get_local_selection): Remove unnecessary code.
1960 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1961 of converted selections stored in converted_selections.
1962 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1963 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1964 (x_convert_selection): New function.
1965 (x_handle_selection_event): Simplify.
1966 (x_get_foreign_selection): Don't ignore incoming requests while
1967 waiting for an answer; this will fail when we implement
1968 SAVE_TARGETS, and seems unnecessary anyway.
1969 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1970 (Vx_sent_selection_functions): Doc fix.
1971
0f4aebc0
LL
19722011-05-26 Leo Liu <sdl.web@gmail.com>
1973
1974 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1975
e61124cd
YM
19762011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1977
1978 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1979
1980 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1981 for fringe update if it has periodic bitmap.
1982 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1983 and fringe_bitmap_periodic_p.
1984
1985 * fringe.c (get_fringe_bitmap_data): New function.
1986 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1987 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1988 row. Mark glyph row for fringe update if periodicity changed.
1989
1990 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1991 for fringe update unless it has periodic bitmap.
1992
f16d9837
KH
19932011-05-25 Kenichi Handa <handa@m17n.org>
1994
1995 * xdisp.c (get_next_display_element): Set correct it->face_id for
1996 a static composition.
1997
e1b90ef6
LL
19982011-05-24 Leo Liu <sdl.web@gmail.com>
1999
2000 * deps.mk (fns.o):
2001 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2002
2003 * fns.c (crypto_hash_function, Fsha1): New function.
2004 (Fmd5): Use crypto_hash_function.
2005 (syms_of_fns): Add Ssha1.
2006
7400048f
PE
20072011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 * gnutls.c: Remove unused macros.
2010 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2011 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2012 Remove macros that are defined and never used.
2013 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2014
abb71cf4
CY
20152011-05-22 Chong Yidong <cyd@stupidchicken.com>
2016
2017 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2018 (Fx_get_selection_internal): Minor cleanup.
2019 (Fx_own_selection_internal): Rename arguments for consistency with
2020 select.el.
2021
6307db39
PE
20222011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2025
f3d4e0a4
CY
20262011-05-22 Chong Yidong <cyd@stupidchicken.com>
2027
2028 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2029
4d8ade89
YM
20302011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2031
2032 * dispnew.c (scrolling_window): Don't exclude the case that the
2033 last enabled row in the desired matrix touches the bottom boundary.
2034
32078c8d
GM
20352011-05-21 Glenn Morris <rgm@gnu.org>
2036
2037 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2038 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2039 and add some more files.
32078c8d 2040
7285dc67
EZ
20412011-05-20 Eli Zaretskii <eliz@gnu.org>
2042
2043 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2044 report_file_error introduced by the change from 2011-05-07.
2045
89d1bd22
PE
20462011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2047
2048 * systime.h (Time): Define only if emacs is defined.
2049 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2050 where the include path doesn't have X11/X.h by default. See
2051 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2052
e23640bb 20532011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2054
2055 * composite.c (find_automatic_composition): Fix previous change.
2056
b9704ad9
GM
20572011-05-20 Glenn Morris <rgm@gnu.org>
2058
2059 * lisp.mk: New file, split from Makefile.in.
2060 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2061 (shortlisp): Remove.
2062 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2063
4a720484
GM
20642011-05-19 Glenn Morris <rgm@gnu.org>
2065
2066 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2067 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2068 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2069 (lisp): Set the order to that of loadup.el.
2070 (shortlisp): Make it a copy of $lisp.
2071 (SOME_MACHINE_LISP): Remove.
2072 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2073 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2074
a28d4396
KH
20752011-05-18 Kenichi Handa <handa@m17n.org>
2076
2077 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2078 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2079 (find_automatic_composition): Mostly rewrite for efficiency.
2080
a2b1fa8e
JB
20812011-05-18 Juanma Barranquero <lekktu@gmail.com>
2082
2083 * makefile.w32-in: Update dependencies.
2084
8e1f5610
CS
20852011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2086
2087 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2088 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2089
7025ee00 20902011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2091
cdfa6eab
PE
2092 Fix some integer overflow issues, such as string length overflow.
2093
06d6db33
PE
2094 * insdel.c (count_size_as_multibyte): Check for string overflow.
2095
2b4560a8
PE
2096 * character.c (lisp_string_width): Check for string overflow.
2097 Use EMACS_INT, not int, for string indexes and lengths; in
2098 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2099 the resulting string length overflows an EMACS_INT; instead,
2100 report a string overflow if no precision given. When checking for
2101 precision exhaustion, use a check that cannot possibly have
2102 integer overflow. (Bug#8675)
2103 * character.h (lisp_string_width): Adjust to new signature.
2104
cb93f9be
PE
2105 * alloc.c (string_overflow): New function.
2106 (Fmake_string): Use it. This doesn't change behavior, but saves
2107 a few bytes and will simplify future changes.
2108 * character.c (string_escape_byte8): Likewise.
2109 * lisp.h (string_overflow): New decl.
2110
1a1f3366
PE
2111 Fixups, following up to the user-interface timestamp change.
2112 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2113 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2114 * msdos.c (mouse_get_pos): Likewise.
2115 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2116 * w32gui.h (Time): Define by including "systime.h" rather than by
2117 declaring it ourselves. (Bug#8664)
2118
d4e3e4d3
PE
2119 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2120 * image.c (clear_image_cache): Likewise.
2121
f6a24d19
PE
2122 * term.c (term_mouse_position): Don't assume time_t wraparound.
2123
08dc5ae6
PE
2124 Be more systematic about user-interface timestamps.
2125 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2126 and sometimes 'EMACS_UINT', to represent these timestamps.
2127 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2128 This makes the code easier to follow, and makes it easier to catch
2129 integer overflow bugs such as Bug#8664.
2130 * frame.c (Fmouse_position, Fmouse_pixel_position):
2131 Use Time, not unsigned long, for user-interface timestamps.
2132 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2133 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2134 * keyboard.h (last_event_timestamp): Likewise.
2135 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2136 * menu.h (xmenu_show): Likewise.
2137 * term.c (term_mouse_position): Likewise.
2138 * termhooks.h (struct input_event.timestamp): Likewise.
2139 (struct terminal.mouse_position_hook): Likewise.
2140 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2141 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2142 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2143 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2144 what it was before.
2145 * menu.h, termhooks.h: Include "systime.h", for Time.
2146
8e55734a
PE
2147 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2148 Don't assume that the difference between two unsigned long values
2149 can fit into an integer. At this point, we know button_down_time
2150 <= event->timestamp, so the difference must be nonnegative, so
2151 there's no need to cast the result if double-click-time is
2152 nonnegative, as it should be; check that it's nonnegative, just in
2153 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2154 apart (about 25 days). (Bug#8664)
8e55734a 2155
841f1b75 2156 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2157 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2158
3e26f69c
PE
2159 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2160 that always fit in int. Use a sentinel instead of a counter, to
2161 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2162 * frame.h (struct frame): Use int for menu_bar_items_used
2163 instead of EMACS_INT, since it always fits in int.
3e26f69c 2164
5cc152c0
PE
2165 * menu.c (grow_menu_items): Check for int overflow.
2166
d89eb65e
PE
2167 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2168
5235bd3e
PE
2169 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2170 Before, the code was not consistent. These values cannot exceed
2171 2**31 - 1 so there's no need to make them unsigned.
2172 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2173 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2174 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2175 as modifiers.
2176 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2177
bc827e23
PE
2178 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2179 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2180 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2181 presumably because the widths might not match.
2182
78eb494e
PE
2183 * window.c (size_window): Avoid needless test at loop start.
2184
04f2d78b
CB
21852011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2186
2187 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2188
d2fc7e3d 21892011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2190
2191 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2192
d2fc7e3d 21932011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2194
2195 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2196 `width' to `bar_area_x' and `bar_area_width', respectively.
2197 (x_scroll_run): Take account of fringe background extension.
2198
04f2d78b
CB
2199 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2200 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2201 `bar_area_width', respectively.
2202 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2203 background extension.
2204
79b70037
GM
22052011-05-10 Jim Meyering <meyering@redhat.com>
2206
2207 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2208
2f142cc5
JB
22092011-05-10 Juanma Barranquero <lekktu@gmail.com>
2210
2211 * image.c (Finit_image_library): Return t for built-in image types,
2212 like pbm and xbm. (Bug#8640)
2213
57679c86
AS
22142011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2215
2216 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2217
888c9e86
EZ
22182011-05-07 Eli Zaretskii <eliz@gnu.org>
2219
b0512a1d
EZ
2220 * w32console.c (Fset_screen_color): Doc fix.
2221 (Fget_screen_color): New function.
2222 (syms_of_ntterm): Defsubr it.
2223
7285dc67
EZ
2224 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2225 unlink the temporary file if Fcall_process didn't create it in the
2226 first place.
2227 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2228 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2229 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2230 cue to call_process_cleanup not to close that handle.
2231
4d3fcc8e
BK
22322011-05-07 Ben Key <bkey76@gmail.com>
2233
2234 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2235 one of two shell specific rules, either bootstrap-temacs-CMD or
2236 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2237 to the previous implementation of the bootstrap-temacs rule.
2238 The bootstrap-temacs-CMD rule is similar to the previous
2239 implementation of the bootstrap-temacs rule except that it
2240 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2241 variable.
2242
2243 These changes, along with some changes to nt/configure.bat,
2244 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2245 earlier fix to add support for --cflags and --ldflags options
2246 that include quotes so that it works whether make uses cmd or
2247 sh as the shell.
2248
b4289b64
MA
22492011-05-06 Michael Albinus <michael.albinus@gmx.de>
2250
2251 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2252 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2253 is a constant.
2254 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2255 a string. Handle both cases.
2256 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2257 (Fdbus_register_method): Use Qinvalid_function.
2258
af4c0e28
JB
22592011-05-06 Juanma Barranquero <lekktu@gmail.com>
2260
2261 * makefile.w32-in: Update dependencies.
2262 (LISP_H): Add inttypes.h and stdin.h.
2263 (PROCESS_H): Add unistd.h.
2264
c51453d9
EZ
22652011-05-06 Eli Zaretskii <eliz@gnu.org>
2266
2267 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2268 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2269
8ff0ac3c 22702011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2271
4c4b566b
PE
2272 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2273
aab2b9b5
PE
2274 * term.c (vfatal): Remove stray call to va_end.
2275 It's not needed and the C Standard doesn't allow it here anyway.
2276
c378da0b
PE
2277 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2278 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2279
288b08c7
PE
2280 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2281 bytes.
2282
e3601888
PE
2283 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2284
db6c0e74
PE
2285 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2286
dd5963ea
PE
2287 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2288
88c9450f
PE
2289 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2290
2f9442b8
PE
2291 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2292
c032b5f8
PE
2293 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2294 * charset.c (Fdefine_charset_internal): Don't initialize
2295 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2296 32-bit int (Bug#8600).
a108c10b
PE
2297
2298 * lread.c (read_integer): Be more consistent with string-to-number.
2299 Use string_to_number to do the actual conversion; this avoids
2300 rounding errors and fixes some other screwups. Without this fix,
2301 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2302 (digit_to_number): Move earlier, for benefit of read_integer.
2303 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2304 not a digit in any supported base. (Bug#8602)
a108c10b 2305
ad5f9eea
PE
2306 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2307
aec1708a
PE
2308 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2309 to match comment at start of function. This also removes a
2310 GCC warning about overflow in a 32+64-bit port.
2311
47be4ab5
PE
2312 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2313
371cac43
PE
2314 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2315 Reported by Stefan Monnier in
2316 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2317 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2318 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2319
d01a7826
PE
2320 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2321 (EMACS_UINTPTR): Likewise, with uintptr_t.
2322
7fd47d5c
PE
2323 * lisp.h: Prefer 64-bit EMACS_INT if available.
2324 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2325 on 32-bit hosts that have 64-bit int, so that they can access
2326 large files.
122b0c86
PE
2327 However, temporarily disable this change unless the temporary
2328 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2329
8727937b
PE
2330 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2331
8ac068ac
PE
2332 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2333 This removes an assumption that EMACS_INT and long are the same
2334 width as pointers. The assumption is true for Emacs porting targets
2335 now, but we want to make other targets possible.
2336 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2337 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2338 In the rest of the code, change types of integers that hold casted
2339 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2340 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2341 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2342 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2343 No need to cast type when ORing.
2344 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2345 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2346 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2347 assume EMACS_INT is the same width as char *.
2348 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2349 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2350 Remove no-longer-needed casts.
2351 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2352 (xg_tool_bar_help_callback, xg_make_tool_item):
2353 Use EMACS_INTPTR to hold an integer
2354 that will be cast to void *; this can avoid a GCC warning
2355 if EMACS_INT is not the same width as void *.
2356 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2357 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2358 (current_message_1, set_message_1):
2359 Use a local to convert to proper width without a cast.
2360 * xmenu.c (dialog_selection_callback): Likewise.
2361
ede49d71
PE
2362 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2363 Also, don't assume VALBITS / RAND_BITS is less than 5,
2364 and don't rely on undefined behavior when shifting a 1 left into
2365 the sign bit.
2366 * lisp.h (get_random): Change signature to match.
2367
2f30ecd0
PE
2368 * lread.c (hash_string): Use size_t, not int, for hash computation.
2369 Normally we prefer signed values; but hashing is special, because
2370 it's better to use unsigned division on hash table sizes so that
2371 the remainder is nonnegative. Also, size_t is the natural width
2372 for hashing into memory. The previous code used 'int', which doesn't
2373 retain enough info to hash well into very large tables.
2374 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2375
2a866e7b
PE
2376 * dbusbind.c: Don't possibly lose pointer info when converting.
2377 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2378 Use XPNTR rather than XHASH, so that the high-order bits of
2379 the pointer aren't lost when converting through void *.
2380
51639eac
PE
2381 * eval.c (Fautoload): Don't double-shift a pointer.
2382
92394119
PE
2383 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2384
dbdb9a7c
JB
23852011-05-06 Juanma Barranquero <lekktu@gmail.com>
2386
2387 * gnutls.c (DEF_GNUTLS_FN):
2388 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2389
db7a0b4f
AS
23902011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2391
2392 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2393 marker. (Bug#8610)
2394
f7ff1b0f 23952011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2396
2397 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2398 New version that can reserve upto 2GB of heap space.
2399
f7ff1b0f 24002011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2401
2402 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2403
639c109b
TZ
24042011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2405
2406 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2407 `gnutls_certificate_set_x509_key_file'.
2408
d2127135
JB
24092011-05-05 Juanma Barranquero <lekktu@gmail.com>
2410
2411 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2412 Update dependencies.
2413
e968f4f3
JB
24142011-05-04 Juanma Barranquero <lekktu@gmail.com>
2415
2416 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2417 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2418 Remove unused parameter `fildes'.
2419 * process.c (read_process_output, send_process): Don't pass it.
2420
84d358f0
JB
24212011-05-04 Juanma Barranquero <lekktu@gmail.com>
2422
2423 Fix previous change: the library cache is defined in w32.c.
2424 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2425 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2426
0898ca10
JB
24272011-05-04 Juanma Barranquero <lekktu@gmail.com>
2428
2429 Implement dynamic loading of GnuTLS on Windows.
2430
2431 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2432 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2433 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2434 Declare.
2435
2436 * gnutls.c (Qgnutls_dll): Define.
2437 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2438 (gnutls_*): Declare function pointers.
2439 (init_gnutls_functions): New function to initialize function pointers.
2440 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2441 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2442 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2443 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2444 (emacs_gnutls_write, emacs_gnutls_read)
2445 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2446 (Fgnutls_available_p): New function.
2447 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2448 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2449 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2450
2451 * image.c: Include w32.h.
2452 (Vimage_type_cache): Delete.
2453 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2454 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2455 (w32_delayed_load): Move to w32.c.
2456
2457 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2458
2459 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2460 (w32_delayed_load): Move from image.c. When loading a library, record
2461 its filename in the :loaded-from property of the library id.
2462 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2463 Initialize and staticpro them.
2464 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2465
2466 * process.c: Include lisp.h before w32.h, not after.
2467 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2468 instead of gnutls_record_check_pending.
2469
2470 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2471
ff4de4aa
TZ
24722011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2473
2474 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2475 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2476 as passed in.
2477
abe95abb
JD
24782011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2479
2480 * xterm.c (x_set_frame_alpha): Do not set property on anything
2481 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2482
e16e55d4
JB
24832011-05-02 Juanma Barranquero <lekktu@gmail.com>
2484
2485 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2486
bafcf6a5
JB
24872011-05-02 Juanma Barranquero <lekktu@gmail.com>
2488
2489 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2490 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2491 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2492 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2493 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2494 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2495 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2496 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2497 (Qgnutls_bootprop_callbacks_verify): Make static.
2498
e7a6747f
AS
24992011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2500
19ed11ba
AS
2501 * callproc.c: Indentation fixup.
2502
e7a6747f 2503 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2504 (wait_for_termination, interruptible_wait_for_termination):
2505 Move after wait_for_termination_1.
e7a6747f 2506
1ef14cb4
LMI
25072011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2508
2509 * sysdep.c (interruptible_wait_for_termination): New function
2510 which is like wait_for_termination, but allows keyboard
2511 interruptions.
2512
2513 * callproc.c (Fcall_process): Add (:file "file") as an option for
2514 the STDOUT buffer.
2515 (Fcall_process_region): Ditto.
2516
330d880c
EZ
25172011-04-30 Eli Zaretskii <eliz@gnu.org>
2518
8db90b73
EZ
2519 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2520 rather than `XVECTOR (FOO)->size'.
2521
330d880c
EZ
2522 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2523 inttypes.h, as a gnulib replacement is used if it not available in
2524 system headers.
2525
15cbd324
EZ
25262011-04-21 Eli Zaretskii <eliz@gnu.org>
2527
2528 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2529 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2530 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2531
2532 * coding.c (coding_alloc_by_realloc): Error out if destination
2533 will grow beyond MOST_POSITIVE_FIXNUM.
2534 (decode_coding_emacs_mule): Abort if there isn't enough place in
2535 charbuf for the composition carryover bytes. Reserve an extra
2536 space for up to 2 characters produced in a loop.
2537 (decode_coding_iso_2022): Abort if there isn't enough place in
2538 charbuf for the composition carryover bytes.
2539
25402011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2541
ae940cca
EZ
2542 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2543 aborting when %lld or %lll format is passed.
2544 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2545 %llo or %llx format is passed. (Bug#8545)
2546
03ab8921
EZ
2547 * window.c (window_scroll_line_based): Use a marker instead of
2548 simple variables to record original value of point. (Bug#7952)
2549
afda1437
EZ
2550 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2551 produced by %s or %c overflows available buffer space. (Bug#8545)
2552
f76dee0c
PE
25532011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2554
2555 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2556 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2557
fdc5744d
JB
25582011-04-28 Juanma Barranquero <lekktu@gmail.com>
2559
2560 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2561
638f053a
JB
25622011-04-28 Juanma Barranquero <lekktu@gmail.com>
2563
2564 * keyboard.c (Qdelayed_warnings_hook): Define.
2565 (command_loop_1): Run `delayed-warnings-hook'
2566 if Vdelayed_warnings_list is non-nil.
2567 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2568 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2569
d178f871
EZ
25702011-04-28 Eli Zaretskii <eliz@gnu.org>
2571
2572 * doprnt.c (doprnt): Don't return value smaller than the buffer
2573 size if the message was truncated. (Bug#8545).
2574
b124fd93
JB
25752011-04-28 Juanma Barranquero <lekktu@gmail.com>
2576
2577 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2578 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2579
e810457d
PE
25802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2581
2582 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2583
ea51cceb
JB
25842011-04-27 Juanma Barranquero <lekktu@gmail.com>
2585
2586 * makefile.w32-in: Update dependencies.
2587
94dcfacf
EZ
25882011-04-27 Eli Zaretskii <eliz@gnu.org>
2589
2590 Improve `doprnt' and its usage. (Bug#8545)
2591 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2592 `format_end'. Remove support for %l as a conversion specifier.
2593 Don't use xrealloc. Improve diagnostics when the %l size modifier
2594 is used. Update the commentary.
2595
2596 * eval.c (verror): Simplify calculation of size_t.
2597
2598 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2599 messages.
2600
f61f41d7
PE
26012011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2602
2603 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2604 change.
2605
96fb4434
PE
26062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2607
2608 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2609 This makes this file independent of the recent pseudovector change.
2610
671875da 26112011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2612
69e9b5a3
PE
2613 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2614
b5f869a7 2615 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2616 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2617 Remove unused local.
c8926152 2618 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2619
841a1577 2620 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2621 GCC 4.6.0 optimizes based on type-based alias analysis.
2622 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2623 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2624 != &v->size, and therefore "v->size = 1; b->size = 2; return
2625 v->size;" must therefore return 1. This assumption is incorrect
2626 for Emacs, since it type-puns struct Lisp_Vector * with many other
2627 types. To fix this problem, this patch adds a new type struct
f904488f 2628 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2629 and pseudovectors, and helps optimizing compilers not get fooled
2630 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2631 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2632 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2633 the size member.
eab3844f
PE
2634 (XSETPVECTYPE): Rewrite in terms of new macro.
2635 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2636 This is a bit clearer, and further avoids the possibility of
2637 undesirable aliasing.
2638 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2639 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2640 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2641 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2642 (ASIZE): Now uses header.size rather than size.
2643 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2644 to avoid the hassle of writing XVECTOR (foo)->header.size.
2645 (struct vectorlike_header): New type.
eab3844f
PE
2646 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2647 object, to help avoid aliasing.
2648 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2649 (SUBRP): Likewise, since Lisp_Subr is a special case.
2650 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2651 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2652 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2653 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2654 changed to be "header.size" and "header.next".
2655 * buffer.h (struct buffer): Likewise.
2656 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2657 * frame.h (struct frame): Likewise.
2658 * process.h (struct Lisp_Process): Likewise.
2659 * termhooks.h (struct terminal): Likewise.
2660 * window.c (struct save_window_data, struct saved_window): Likewise.
2661 * window.h (struct window): Likewise.
2662 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2663 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2664 * buffer.c (init_buffer_once): Likewise.
2665 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2666 special case.
2667 * process.c (Fformat_network_address): Use local var for size,
2668 for brevity.
2669
0df1eac5
PE
2670 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2671
847ab9d1 2672 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2673 * data.c (atof): Remove decl; no longer used or needed.
2674 (digit_to_number): Move to lread.c.
2675 (Fstring_to_number): Use new string_to_number function, to be
2676 consistent with how the Lisp reader treats infinities and NaNs.
2677 Do not assume that floating-point numbers represent EMACS_INT
2678 without losing information; this is not true on most 64-bit hosts.
2679 Avoid double-rounding errors, by insisting on integers when
2680 parsing non-base-10 numbers, as the documentation specifies.
2681 * lisp.h (string_to_number): New decl, replacing ...
2682 (isfloat_string): Remove.
bc0a5c13 2683 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2684 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2685 appears to have been a coding error. Similarly, do not accept
2686 strings like +-1e0 as floating point numbers. Do not report
2687 overflow for integer overflows unless the base is not 10 which
2688 means we have no simple and reliable way to continue.
2689 Break out the floating-point parsing into a new
2690 function string_to_number, so that Fstring_to_number parses
2691 floating point numbers consistently with the Lisp reader.
04f2d78b 2692 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2693 (E_CHAR, EXP_INT): Remove, replacing with ...
2694 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2695 (string_to_number): New function, replacing isfloat_string.
2696 This function checks for valid syntax and produces the resulting
2697 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2698 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2699 so that overflow for non-base-10 numbers is reported only when
2700 there's no portable and simple way to convert to floating point.
452f4150 2701
67769ffc
PE
2702 * textprop.c (set_text_properties_1): Rewrite for clarity,
2703 and to avoid GCC warning about integer overflow.
2704
c20db43f
PE
2705 * intervals.h (struct interval): Use EMACS_INT for members
2706 where EMACS_UINT might cause problems. See
2707 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2708 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2709 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2710 All uses changed.
37aa2f85
PE
2711 (offset_intervals): Tell GCC not to worry about length overflow
2712 when negating a negative length.
c20db43f 2713
2538aa2f
PE
2714 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2715 (overrun_check_free): Likewise.
2716
f2d3008d
PE
2717 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2718 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2719 word size.
2720
ec8df744
PE
2721 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2722 (gnutls_make_error): Rename local to avoid shadowing.
2723 (gnutls_emacs_global_deinit): ifdef out; not used.
2724 (Fgnutls_boot): Use const for pointer to readonly storage.
2725 Comment out unused local. Fix pointer signedness problems.
2726
640ee02d
PE
2727 * lread.c (openp): Don't stuff size_t into an 'int'.
2728 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2729 about possible signed overflow.
2730
6048fb2a
PE
2731 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2732 (GDK_KEY_g): Don't define if already defined.
2733 (xg_prepare_tooltip): Avoid pointer signedness problem.
2734 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2735
fa3c87e1
PE
2736 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2737 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2738
2172544b
PE
2739 * xfns.c (Fx_window_property): Simplify a bit,
2740 to make a bit faster and to avoid GCC 4.6.0 warning.
2741 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2742
9b821a21
PE
2743 * fns.c (internal_equal): Don't assume size_t fits in int.
2744
3c616cfa
PE
2745 * alloc.c (compact_small_strings): Tighten assertion a little.
2746
c2982e87
PE
2747 Replace pEd with more-general pI, and fix some printf arg casts.
2748 * lisp.h (pI): New macro, generalizing old pEd macro to other
2749 conversion specifiers. For example, use "...%"pI"d..." rather
2750 than "...%"pEd"...".
2751 (pEd): Remove. All uses replaced with similar uses of pI.
2752 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2753 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2754 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2755 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2756 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2757 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2758 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2759 64-bit hosts.
2760 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2761 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2762 * print.c (safe_debug_print, print_object): Likewise.
2763 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2764 to int.
6f04d126
PE
2765 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2766 avoiding the 0 flag, which is not portable.
c2982e87
PE
2767 * process.c (Fmake_network_process): Use pI to avoid cast.
2768 * region-cache.c (pp_cache): Likewise.
2769 * xdisp.c (decode_mode_spec): Likewise.
2770 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2771 behavior on 64-bit hosts with printf arg.
6f04d126 2772 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2773 (x_stop_queuing_selection_requests): Likewise.
2774 (x_get_window_property): Don't truncate byte count to an 'int'
2775 when tracing.
0b432f21 2776
5e073ec7
PE
2777 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2778 here, since it parses constructs like leading '-' and spaces,
2779 which are not wanted; and it overflows with large numbers.
2780 Instead, simply match F[0-9]+, which is what is wanted anyway.
2781
36372bf9
PE
2782 * alloc.c: Remove unportable assumptions about struct layout.
2783 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2784 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2785 (allocate_vectorlike, make_pure_vector): Use the new macros,
2786 plus offsetof, to remove unportable assumptions about struct layout.
2787 These assumptions hold on all porting targets that I know of, but
2788 they are not guaranteed, they're easy to remove, and removing them
2789 makes further changes easier.
2790
0b432f21
PE
2791 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2792 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2793 (string_overrun_cookie): Now const. Use initializers that
2794 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2795 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2796 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2797 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2798 multiple of sizeof (EMACS_INT); it need not be, if
2799 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2800 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2801
895009e1
JB
28022011-04-26 Juanma Barranquero <lekktu@gmail.com>
2803
2804 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2805
6a7a1b0b
TZ
28062011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2807
2808 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2809 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2810 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2811
841a1577 28122011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2813
2814 * lisp.h (Qdebug): List symbol.
895009e1 2815 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2816 * keyboard.c (debug-on-event): New variable.
2817 (handle_user_signal): Break into debugger when debug-on-event
2818 matches the current signal symbol.
2819
f2d3ba6f
DN
28202011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2821
2822 * alloc.c (check_sblock, check_string_bytes)
2823 (check_string_free_list): Convert to standard C.
2824
42ce4c63
TZ
28252011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2826
2827 * w32.c (emacs_gnutls_push): Fix typo.
2828
825cd63c
EZ
28292011-04-25 Eli Zaretskii <eliz@gnu.org>
2830
fb11d64d
EZ
2831 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2832 "cast to pointer from integer of different size".
2833
825cd63c
EZ
2834 Improve doprnt and its use in verror. (Bug#8545)
2835 * doprnt.c (doprnt): Document the set of format control sequences
2836 supported by the function. Use SAFE_ALLOCA instead of always
2837 using `alloca'.
2838
2839 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2840 is one byte too soon. Don't use xrealloc; instead xfree and
2841 xmalloc anew.
2842
e061a11b
TZ
28432011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2844
2845 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2846 callbacks stage.
2847
2848 * gnutls.c: Renamed global_initialized to
2849 gnutls_global_initialized. Added internals for the
2850 :verify-hostname-error, :verify-error, and :verify-flags
2851 parameters of `gnutls-boot' and documented those parameters in the
2852 docstring. Start callback support.
9173deec
JB
2853 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2854 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2855 on error. Return error code.
e061a11b
TZ
2856 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2857 (emacs_gnutls_read): Likewise.
2858 (Fgnutls_boot): Return handshake error code.
2859 (emacs_gnutls_handle_error): New function.
2860 (wsaerror_to_errno): Likewise.
2861
2862 * w32.h (emacs_gnutls_pull): Add prototype.
2863 (emacs_gnutls_push): Likewise.
2864
2865 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2866 (emacs_gnutls_push): Likewise.
2867
28682011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2869
2870 * process.c (wait_reading_process_output): Check if GnuTLS
2871 buffered some data internally if no FDs are set for TLS
2872 connections.
2873
2874 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2875 (LIBS): Link to USER_LIBS.
2876 ($(BLD)/gnutls.$(0)): New target.
2877
fa6996bc
EZ
28782011-04-24 Eli Zaretskii <eliz@gnu.org>
2879
eb35682e
EZ
2880 * xdisp.c (handle_single_display_spec): Rename the
2881 display_replaced_before_p argument into display_replaced_p, to
2882 make it consistent with the commentary. Fix typos in the
2883 commentary.
2884
e2ad650c
EZ
2885 * textprop.c (syms_of_textprop): Remove dead code.
2886 (copy_text_properties): Delete obsolete commentary about an
2887 interface that was deleted long ago. Fix typos in the description
2888 of arguments.
2889
1b2de274
EZ
2890 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2891 to changes in oldXMenu/XMenu.h from 2011-04-16.
2892 <menu_help_message, prev_menu_help_message>: Constify.
2893 (IT_menu_make_room): menu->help_text is now `const char **';
2894 adjust.
2895
2896 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2897 to changes in oldXMenu/XMenu.h from 2011-04-16.
2898 (struct XMenu): Declare `help_text' `const char **'.
2899
2900 * xfaces.c <Qunspecified>: Make extern again.
2901
2902 * syntax.c: Include sys/types.h before including regex.h, as
2903 required by Posix.
2904
762b15be
EZ
2905 * doc.c (get_doc_string): Improve the format passed to `error'.
2906
2907 * doprnt.c (doprnt): Improve commentary.
2908
2909 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2910
2911 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2912 them with etags.
2913
f1052e5d
EZ
2914 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2915 changes in globals.h immediately force recompilation.
762b15be
EZ
2916 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2917 $(CURDIR)/s/ms-w32.h.
2918 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2919
fa6996bc
EZ
2920 * character.c (Fchar_direction): Function deleted.
2921 (syms_of_character): Don't defsubr it.
2922 <char-direction-table>: Deleted.
2923
e6c3da20
EZ
29242011-04-23 Eli Zaretskii <eliz@gnu.org>
2925
2926 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2927 * doprnt.c: Include limits.h.
2928 (SIZE_MAX): New macro.
04f2d78b
CB
2929 (doprnt): Return a size_t value. 2nd arg is now size_t.
2930 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2931 Improve overflow protection. Support `l' modifier for integer
2932 conversions. Support %l conversion. Don't assume an EMACS_INT
2933 argument for integer conversions and for %c.
2934
2935 * lisp.h (doprnt): Restore prototype.
2936
2937 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2938 $(SRC)/character.h.
2939
2940 * Makefile.in (base_obj): Add back doprnt.o.
2941
2942 * deps.mk (doprnt.o): Add back prerequisites.
2943 (callint.o): Depend on character.h.
2944
2945 * eval.c (internal_lisp_condition_case): Include the handler
2946 representation in the error message.
2947 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2948 when breaking from the loop.
2949
2950 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2951
2952 * callint.c (Fcall_interactively): When displaying error message
2953 about invalid control letter, pass the character's codepoint, not
2954 a pointer to its multibyte form. Improve display of the character
2955 in octal and display also its hex code.
2956
2957 * character.c (char_string): Use %x to display the (unsigned)
2958 codepoint of an invalid character, to avoid displaying a bogus
2959 negative value.
2960
2961 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2962 `error', not SYMBOL_NAME itself.
2963
2964 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2965 character arguments to `error'.
2966
2967 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2968 to `error' in error message about FINAL_CHAR argument. Make sure
2969 FINAL_CHAR is a character, and use %c when it is passed as
2970 argument to `error'.
2971
4ffd0d6b 29722011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2973
2974 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2975
2976 * w32.c: Include <time.h>.
2977 (sys_localtime): New function.
2978
4ffd0d6b 29792011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2980
2981 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2982
4ffd0d6b 2983 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2984
4ffd0d6b 29852011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2986
4ffd0d6b
GM
2987 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2988 zombies (Bug#8467).
aac0c6e3 2989
04c56954
EZ
29902011-04-19 Eli Zaretskii <eliz@gnu.org>
2991
2992 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2993 gl_state.e_property when gl_state.object is Qt.
2994
2995 * insdel.c (make_gap_larger): Remove limitation of buffer size
2996 to <= INT_MAX.
2997
16a43933
CY
29982011-04-18 Chong Yidong <cyd@stupidchicken.com>
2999
3000 * xdisp.c (lookup_glyphless_char_display)
3001 (produce_glyphless_glyph): Handle cons cell entry in
3002 glyphless-char-display.
3003 (Vglyphless_char_display): Document it.
3004
3005 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3006 glyphless-char-display.
3007
4581706e
CY
30082011-04-17 Chong Yidong <cyd@stupidchicken.com>
3009
3010 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3011
3012 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3013
3014 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3015 definition for no-X builds.
3016
4887c6e2 30172011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3018
fd35b6f9
PE
3019 Static checks with GCC 4.6.0 and non-default toolkits.
3020
5c1ccb01
PE
3021 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3022
006c5daa
PE
3023 * process.c (keyboard_bit_set): Define only if SIGIO.
3024 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3025 (send_process): Repair possible setjmp clobbering.
3026
efc736d3
PE
3027 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3028
4e2fe2e6
PE
3029 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3030
f97334a2
PE
3031 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3032
4e75f29d
PE
3033 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3034 Define only if needed.
3035
90efadd1
PE
3036 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3037 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3038 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3039
3c647824
PE
3040 * dispextern.h (struct redisplay_interface): Rename param
3041 to avoid shadowing.
e264f262 3042 * termhooks.h (struct terminal): Likewise.
761383f4 3043 * xterm.c (xembed_send_message): Likewise.
3c647824 3044
b58c5c4a
PE
3045 * insdel.c (make_gap_smaller): Define only if
3046 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3047
cad59032
PE
3048 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3049 it.
3050
c339dc2e
PE
3051 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3052 so that we aren't warned about unused symbols.
3053
91a3e27b
PE
3054 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3055
399c71d3 3056 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3057
8ffc96f5
PE
3058 * xfns.c (x_real_positions): Mark locals as initialized.
3059
eef9bc79
PE
3060 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3061
098db9dd
PE
3062 * xterm.c: Fix problems found by static analysis with other toolkits.
3063 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3064 (x_dispatch_event): Declare static if USE_GTK, and
3065 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3066 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3067 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3068 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3069 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3070
eb18f6cc
PE
3071 * xmenu.c (menu_help_callback): Pointer type fixes.
3072 Use const pointers when pointing at readonly data. Avoid pointer
3073 signedness clashes.
3074 (FALSE): Remove unused macro.
3075 (update_frame_menubar): Remove unused decl.
3076
1fe72bf8
PE
3077 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3078
60d9e1db
PE
3079 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3080 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3081 (single_menu_item): Rename local to avoid shadowing.
3082
39261c26
PE
3083 * keyboard.c (make_lispy_event): Remove unused local var.
3084
018c5e19
PE
3085 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3086 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3087
63d2b86e
PE
3088 * bitmaps: Change bitmaps from unsigned char back to the X11
3089 compatible char. Avoid the old compiler warnings about
3090 out-of-range initializers by using, for example, '\xab' rather
3091 than 0xab.
3092
aefd87e1
PE
3093 * xgselect.c (xgselect_initialize): Check vs interface
3094 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3095
bf501fb9
PE
3096 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3097
e9829fdf
PE
3098 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3099 to read-only memory.
3100
1086c095
PE
3101 * fns.c (vector): Remove; this old hack is no longer needed.
3102
2baccd04 3103 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3104 Remove unused var.
dde42981 3105 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3106
72391843 3107 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3108
436c16df 3109 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3110 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3111 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3112
92bb796d 3113 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3114 (x_term_init): Remove local to avoid shadowing.
92bb796d 3115
764430a3 3116 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3117
3118 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3119 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3120
d1dfb56c
EZ
31212011-04-16 Eli Zaretskii <eliz@gnu.org>
3122
c4354cb4
EZ
3123 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3124
d1dfb56c
EZ
3125 Fix regex.c, syntax.c and friends for buffers > 2GB.
3126 * syntax.h (struct gl_state_s): Declare character position members
3127 EMACS_INT.
3128
3129 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3130
04f2d78b
CB
3131 * textprop.c (verify_interval_modification, interval_of):
3132 Declare arguments EMACS_INT.
d1dfb56c
EZ
3133
3134 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3135 EMACS_INT.
3136
3137 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3138
3139 * indent.c (Fvertical_motion): Local variable it_start is now
3140 EMACS_INT.
3141
3142 * regex.c (re_match, re_match_2, re_match_2_internal)
3143 (bcmp_translate, regcomp, regexec, print_double_string)
3144 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3145 (re_compile_pattern, re_exec): Declare arguments and local
3146 variables `size_t' and `ssize_t' and return values `regoff_t', as
3147 appropriate.
3148 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3149 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3150 <compile_stack_type>: `size' and `avail' are now `size_t'.
3151
3152 * regex.h <regoff_t>: Use ssize_t, not int.
3153 (re_search, re_search_2, re_match, re_match_2): Arguments that
3154 specify buffer/string position and length are now ssize_t and
3155 size_t. Return type is regoff_t.
3156
613052cd
BK
31572011-04-16 Ben Key <bkey76@gmail.com>
3158
3159 * nsfont.m: Fixed bugs in ns_get_family and
3160 ns_descriptor_to_entity that were caused by using free to
3161 deallocate memory blocks that were allocated by xmalloc (via
3162 xstrdup). This caused Emacs to crash when compiled with
3163 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3164 --enable-checking=xmallocoverrun). xfree is now used to
3165 deallocate these memory blocks.
3166
4170f62f 31672011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3168
71b41406
PE
3169 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3170
9587a89d
PE
3171 emacs_write: Accept and return EMACS_INT for sizes.
3172 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3173 et seq.
3174 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3175 Accept and return EMACS_INT.
3176 (emacs_gnutls_write): Return the number of bytes written on
3177 partial writes.
3178 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3179 (emacs_read, emacs_write): Remove check for negative size, as the
3180 Emacs source code has been audited now.
9587a89d
PE
3181 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3182 (emacs_read, emacs_write): Use it.
273a5f82
PE
3183 * process.c (send_process): Adjust to the new signatures of
3184 emacs_write and emacs_gnutls_write. Do not attempt to store
3185 a byte offset into an 'int'; it might overflow.
9587a89d 3186 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3187
3e047f51
PE
3188 * sound.c: Don't assume sizes fit in 'int'.
3189 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3190 Return EMACS_INT, not int.
3e047f51 3191 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3192 Accept EMACS_INT, not int.
3193 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3194 record read return values.
3195
cc39a9db
BK
31962011-04-15 Ben Key <bkey76@gmail.com>
3197
c9d0ec6d
JB
3198 * keyboard.c (Qundefined): Don't declare static since it is used
3199 in nsfns.m.
3200 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3201 static since they are used in nsfont.m.
cc39a9db 3202
6c60eb9f
SM
32032011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3204
3205 * process.c (Qprocessp): Don't declare static.
3206 * lisp.h (Qprocessp): Declare again.
3207
7990b61a
JB
32082011-04-15 Juanma Barranquero <lekktu@gmail.com>
3209
3210 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3211
5d4cb038
PE
32122011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3213
8bd7b830 3214 Improve C-level modularity by making more things 'static'.
cd64ea1d 3215
e3b27b31
PE
3216 Don't publish debugger-only interfaces to other modules.
3217 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3218 (verify_bytepos, count_markers): Move decls to the only modules
3219 that need them.
3220 * region-cache.h (pp_cache): Likewise.
3221 * window.h (check_all_windows): Likewise.
3222 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3223
5d4cb038
PE
3224 * sysdep.c (croak): Now static, if
3225 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3226 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3227
3228 * alloc.c (refill_memory_reserve): Now static if
3229 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3230 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3231
e87b6180
PE
3232 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3233 Define only if USE_LUCID.
3234
ac64929e
PE
3235 * xrdb.c (x_customization_string, x_rm_string): Now static.
3236
6f37259d
PE
3237 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3238 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3239
1683e3ab
PE
3240 * xdisp.c (draw_row_with_mouse_face): Now static.
3241 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3242
de9c2632
PE
3243 * window.h (check_all_windows): Mark externally visible.
3244
2b96acb7
PE
3245 * window.c (window_deletion_count): Now static.
3246
3247 * undo.c: Make symbols static if they're not exported.
3248 (last_undo_buffer, last_boundary_position, pending_boundary):
3249 Now static.
3250
50436f33
PE
3251 * textprop.c (interval_insert_behind_hooks): Now static.
3252 (interval_insert_in_front_hooks): Likewise.
3253
64520e5c
PE
3254 * term.c: Make symbols static if they're not exported.
3255 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3256 (max_frame_lines, tty_set_terminal_modes):
3257 (tty_reset_terminal_modes, tty_turn_off_highlight):
3258 (get_tty_terminal): Now static.
3259 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3260 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3261 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3262 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3263 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3264
1fa53021
PE
3265 * sysdep.c: Make symbols static if they're not exported.
3266 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3267 Now static.
3268 (sigprocmask_set, full_mask): Remove; unused.
3269 (wait_debugging): Mark as visible.
3270 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3271 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3272
d4b43b22
PE
3273 * syntax.c (syntax_temp): Define only if !__GNUC__.
3274
b7c513d0
PE
3275 * sound.c (current_sound_device, current_sound): Now static.
3276
989b29ad
PE
3277 * search.c (searchbufs, searchbuf_head): Now static.
3278
13a55a78
PE
3279 * scroll.c (scroll_cost): Remove; unused.
3280 * dispextern.h (scroll_cost): Remove decl.
3281
de68a1fc
PE
3282 * region-cache.h (pp_cache): Mark as externally visible.
3283
40ccffa6
PE
3284 * process.c: Make symbols static if they're not exported.
3285 (process_tick, update_tick, create_process, chan_process):
3286 (Vprocess_alist, proc_buffered_char, datagram_access):
3287 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3288 (deactivate_process): Mark defn as static, as well as decl.
3289 * lisp.h (create_process): Remove decl.
3290 * process.h (chan_process, Vprocess_alist): Remove decls.
3291
ad64fc97
PE
3292 * print.c: Make symbols static if they're not exported.
3293 (print_depth, new_backquote_output, being_printed, print_buffer):
3294 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3295 (print_interval, print_number_index, initial_stderr_stream):
3296 Now static.
3297 * lisp.h (Fprinc): Remove decl.
3298 (debug_output_compilation_hack): Mark as externally visible.
3299
adddb265
PE
3300 * sysdep.c (croak): Move decl from here to syssignal.h.
3301 * syssignal.h (croak): Put it here, so the API can be checked when
3302 'croak' is called from dissociate_if_controlling_tty.
3303
1717ede2
PE
3304 * minibuf.c: Make symbols static if they're not exported.
3305 (minibuf_save_list, choose_minibuf_frame): Now static.
3306 * lisp.h (choose_minibuf_frame): Remove decl.
3307
fa5fb2bc
PE
3308 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3309
1e3890d1
PE
3310 * lread.c: Make symbols static if they're not exported.
3311 (read_objects, initial_obarray, oblookup_last_bucket_number):
3312 Now static.
3313 (make_symbol): Remove; unused.
3314 * lisp.h (initial_obarray, make_symbol): Remove decls.
3315
8a1414fa
PE
3316 * keyboard.c: Make symbols static if they're not exported.
3317 (single_kboard, recent_keys_index, total_keys, recent_keys):
3318 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3319 (this_single_command_key_start, echoing, last_auto_save):
3320 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3321 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3322 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3323 (Vlispy_mouse_stem, double_click_count):
3324 Now static.
3325 (force_auto_save_soon): Define only if SIGDANGER.
3326 (ignore_mouse_drag_p): Now static if
3327 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3328 (print_help): Remove; unused.
3329 (stop_character, last_timer_event): Mark as externally visible.
3330 * keyboard.h (ignore_mouse_drag_p): Declare only if
3331 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3332 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3333 * lisp.h (echoing): Remove decl.
3334 (force_auto_save_soon): Declare only if SIGDANGER.
3335 * xdisp.c (redisplay_window): Simplify code, to make it more
3336 obvious that ignore_mouse_drag_p is not accessed if !defined
3337 USE_GTK && !defined HAVE_NS.
3338
93ea6e8f
PE
3339 * intervals.c: Make symbols static if they're not exported.
3340 (merge_properties_sticky, merge_interval_right, delete_interval):
3341 Now static.
3342 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3343
77382fcc
PE
3344 * insdel.c: Make symbols static if they're not exported.
3345 However, leave prepare_to_modify_buffer alone. It's never
3346 called from outside this function, but that appears to be a bug.
3347 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3348 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3349 (adjust_after_replace_noundo): Remove; unused.
3350 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3351 (signal_before_change): Remove decls.
77382fcc 3352
9306c32e
PE
3353 * indent.c (val_compute_motion, val_vmotion): Now static.
3354
cd44d2eb
PE
3355 * image.c: Make symbols static if they're not exported.
3356 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3357 if USE_GTK.
3358 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3359 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3360
ad9a7a06
PE
3361 * fringe.c (standard_bitmaps): Now static.
3362 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3363
81626931
PE
3364 * frame.c: Make symbols static if they're not exported.
3365 (x_report_frame_params, make_terminal_frame): Now static.
3366 (get_frame_param): Now static, unless HAVE_NS.
3367 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3368 (x_get_resource_string): Remove; not used.
3369 * frame.h (make_terminal_frame, x_report_frame_params):
3370 (x_get_resource_string); Remove decls.
3371 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3372 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3373
239f9db9
PE
3374 * font.c, fontset.c: Make symbols static if they're not exported.
3375 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3376 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3377 * font.c (font_close_object): Now static.
3378 * font.h (font_close_object): Remove.
3379 * fontset.c (FONTSET_OBJLIST): Remove.
3380 (free_realized_fontset) #if-0 the body, which does nothing.
3381 (face_suitable_for_char_p): #if-0, as it's never called.
3382 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3383 * xfaces.c (face_at_string_position):
3384 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3385 since 0 is always ASCII.
3386
dfcf3579
PE
3387 * fns.c (weak_hash_tables): Now static.
3388
5045092b
PE
3389 * fileio.c: Make symbols static if they're not exported.
3390 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3391 (Vwrite_region_annotation_buffers): Now static.
3392
57a96f5c
PE
3393 * eval.c: Make symbols static if they're not exported.
3394 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3395 * lisp.h (backtrace_list): Remove decl.
3396
35f08c38
PE
3397 * emacs.c: Make symbols static if they're not exported.
3398 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3399 (fatal_error_code, fatal_error_signal_hook, standard_args):
3400 Now static.
3401 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3402 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3403 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3404 * lisp.h (fatal_error_signal_hook): Remove decl.
3405 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3406
f44bd759
PE
3407 * editfns.c: Move a (normally-unused) function to its only use.
3408 * editfns.c, lisp.h (get_operating_system_release): Remove.
3409 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3410 worth the hassle of breaking this out.
3411
b532497d
PE
3412 * xterm.c: Make symbols static if they're not exported.
3413 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3414 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3415 (x_destroy_window, x_delete_display):
3416 Now static.
3417 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3418 (x_mouse_leave): Remove; unused.
3419 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3420 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3421 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3422 Remove decls.
3423 (x_mouse_leave): Declare only if WINDOWSNT.
3424 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3425 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3426 USE_X_TOOLKIT.
3427
1675728f
PE
3428 * ftxfont.c: Make symbols static if they're not exported.
3429 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3430 HAVE_FREETYPE.
3431 * font.h (ftxfont_driver): Likewise.
3432
e4cebfca
PE
3433 * xfns.c: Make symbols static if they're not exported.
3434 (x_last_font_name, x_display_info_for_name):
3435 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3436 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3437 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3438 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3439 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3440 (last_show_tip_args): Now static.
3441 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3442 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3443 (x_screen_planes): Remove; unused.
3444 * dispextern.h (x_screen_planes): Remove decl.
3445
5bf46f05
PE
3446 * dispnew.c: Make symbols static if they're not exported.
3447 * dispextern.h (redraw_garbaged_frames, scrolling):
3448 (increment_row_positions): Remove.
3449 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3450 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3451 Now static.
3452 (redraw_garbaged_frames): Remove; unused.
3453
435f4c28
PE
3454 * xfaces.c: Make symbols static if they're not exported.
3455 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3456 Remove decls.
3457 * xterm.h (defined_color): Remove decls.
3458 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3459 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3460 (menu_face_changed_default, defined_color, free_realized_face):
3461 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3462 (ascii_face_of_lisp_face): Remove; unused.
3463
8524aef3
PE
3464 * xdisp.c: Make symbols static if they're not exported.
3465 * dispextern.h (scratch_glyph_row, window_box_edges):
3466 (glyph_to_pixel_coords, set_cursor_from_row):
3467 (get_next_display_element, set_iterator_to_next):
3468 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3469 (show_mouse_face): Remove decls
3470 * frame.h (message_buf_print): Likewise.
3471 * lisp.h (pop_message, set_message, check_point_in_composition):
3472 Likewise.
3473 * xterm.h (set_vertical_scroll_bar): Likewise.
3474 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3475 (message_buf_print, scratch_glyph_row, displayed_buffer):
3476 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3477 (get_next_display_element, show_mouse_face, window_box_edges):
3478 (frame_to_window_pixel_xy, check_point_in_composition):
3479 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3480 (glyph_to_pixel_coords): Remove; unused.
3481
16390cd2
PE
3482 * dired.c (file_name_completion): Now static.
3483
3484 * dbusbind.c (xd_in_read_queued_messages): Now static.
3485
a25f4dfa
PE
3486 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3487 * data.c (circular_list_error): Remove.
3488
14a9c8df
PE
3489 * commands.h (last_point_position, last_point_position_buffer):
3490 (last_point_position_window): Remove decls.
3491 * keyboard.c: Make these variables static.
3492
04f2d78b
CB
3493 * coding.h (coding, code_convert_region, encode_coding_gap):
3494 Remove decls.
74ab6df5
PE
3495 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3496 (iso_code_class, detect_coding, code_convert_region): Now static.
3497 (encode_coding_gap): Remove; unused.
3498
38dfbee1
PE
3499 * chartab.c (chartab_chars, chartab_bits): Now static.
3500
a2cb4e63
PE
3501 * charset.h (charset_iso_8859_1): Remove decl.
3502 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3503 Now static.
3504
127198fd
PE
3505 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3506 * ccl.c (Vccl_program_table): Now static.
3507 (check_ccl_update): Remove; unused.
3508
d85b608f
PE
3509 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3510 * category.h: ... from here.
3511 * category.c (check_category_table, set_category_set): Now static.
3512
31cd66f3
PE
3513 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3514 * lisp.h: Remove these decls.
3515
c358e587
PE
3516 * buffer.c (buffer_count): Remove unused var.
3517
e78aecca
PE
3518 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3519 so that it's not optimized away.
3520 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3521 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3522 exported only to the debugger.
3523
e192d7d3 3524 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3525 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3526
92470028
PE
3527 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3528 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3529 was inaccessible from Lisp.
3530 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3531 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3532
244ed907
PE
3533 alloc.c: Import and export fewer symbols, and remove unused items.
3534 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3535 is defined.
3536 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3537 it's not optimized away by whole-program optimization.
3538 (message_enable_multibyte, free_misc): Remove.
3539 (catchlist, handlerlist, mark_backtrace):
3540 Declare only if BYTE_MARK_STACK.
3541 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3542 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3543 (message_enable_multibyte): Remove decl.
3544 (free_misc, interval_free_list, float_block, float_block_index):
3545 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3546 (cons_free_list, last_marked_index):
3547 Now static.
3548 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3549 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3550 (mark_backtrace): Define only if BYTE_MARK_STACK.
3551 * xdisp.c (message_enable_multibyte): Now static.
3552
61c2b50e 3553 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3554 This makes it easier for human readers (and static analyzers)
3555 to see whether these variables are used from other modules.
3556 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3557 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3558 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3559 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3560 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3561 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3562 * xmenu.c, xselect.c:
3563 Declare Q* vars static if they are not used in other modules.
3564 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3565 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3566 Remove decls of unexported vars.
3567 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3568
95c82688
PE
3569 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3570
16a97296
PE
3571 Make Emacs functions such as Fatom 'static' by default.
3572 This makes it easier for human readers (and static analyzers)
3573 to see whether these functions can be called from other modules.
3574 DEFUN now defines a static function. To make the function external
3575 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3576 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3577 (Finit_image_library):
16a97296
PE
3578 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3579 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3580 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3581 Remove decls, since these functions are now static.
3582 (Funintern, Fget_internal_run_time): New decls, since these functions
3583 were already external.
95c82688 3584
16a97296
PE
3585 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3586 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3587 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3588 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3589 * keyboard.c, keymap.c, lread.c:
3590 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3591 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3592 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3593 Mark functions with DEFUE instead of DEFUN,
3594 if they are used in other modules.
3595 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3596 decls for now-static functions.
3597 * buffer.h (Fdelete_overlay): Remove decl.
3598 * callproc.c (Fgetenv_internal): Mark as internal.
3599 * composite.c (Fremove_list_of_text_properties): Remove decl.
3600 (Fcomposition_get_gstring): New forward static decl.
3601 * composite.h (Fcomposite_get_gstring): Remove decl.
3602 * dired.c (Ffile_attributes): New forward static decl.
3603 * doc.c (Fdocumntation_property): New forward static decl.
3604 * eval.c (Ffetch_bytecode): New forward static decl.
3605 (Funintern): Remove extern decl; now in .h file where it belongs.
3606 * fileio.c (Fmake_symbolic_link): New forward static decl.
3607 * image.c (Finit_image_library): New forward static decl.
3608 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3609 * intervals.h (Fprevious_property_change):
3610 (Fremove_list_of_text_properties): Remove decls.
3611 * keyboard.c (Fthis_command_keys): Remove decl.
3612 (Fcommand_execute): New forward static decl.
3613 * keymap.c (Flookup_key): New forward static decl.
3614 (Fcopy_keymap): Now static.
3615 * keymap.h (Flookup_key): Remove decl.
3616 * process.c (Fget_process): New forward static decl.
3617 (Fprocess_datagram_address): Mark as internal.
3618 * syntax.c (Fsyntax_table_p): New forward static decl.
3619 (skip_chars): Remove duplicate decl.
3620 * textprop.c (Fprevious_property_change): New forward static decl.
3621 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3622 Now internal.
3623 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3624 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3625
785bbd42
PE
3626 * editfns.c (Fformat): Remove unreachable code.
3627
8b913b57
AS
36282011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3629
3630 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3631 change. (Bug#8496)
3632
a6744a35
EZ
36332011-04-13 Eli Zaretskii <eliz@gnu.org>
3634
3635 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3636 when at ZV. (Bug#8487)
3637
e7974947
AS
36382011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3639
baad03f0
AS
3640 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3641 (Bug#8437)
3642 * keyboard.c (parse_tool_bar_item): Likewise.
3643 * sound.c (sound_cleanup, alsa_close): Likewise.
3644 * termcap.c (tgetent): Likewise.
3645 * xfns.c (x_default_font_parameter): Likewise.
3646 * xsettings.c (read_and_apply_settings): Likewise.
3647
e7974947
AS
3648 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3649 (overrun_check_free): Protoize.
3650
28272684
PE
36512011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3652
3653 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3654 since callers should never pass a negative size.
3655 Change the signature to match that of plain 'read' and 'write'; see
3656 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3657 * lisp.h: Update prototypes of emacs_write and emacs_read.
3658
11997c76
EZ
36592011-04-11 Eli Zaretskii <eliz@gnu.org>
3660
3661 * xdisp.c (redisplay_window): Don't try to determine the character
3662 position of the scroll margin if the window start point w->startp
e896f03c 3663 is outside the buffer's accessible region. (Bug#8468)
11997c76 3664
8a2cbd72
EZ
36652011-04-10 Eli Zaretskii <eliz@gnu.org>
3666
3667 Fix write-region and its subroutines for buffers > 2GB.
3668 * fileio.c (a_write, e_write): Modify declaration of arguments and
3669 local variables to support buffers larger than 2GB.
3670 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3671
3672 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3673 argument, local variables, and return value.
3674
3675 * lisp.h: Update prototypes of emacs_write and emacs_read.
3676
3677 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3678
4073e537 36792011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3680
1ebfdcb6
PE
3681 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3682
b2ded58d
PE
3683 Fix more problems found by GCC 4.6.0's static checks.
3684
7d66342c
PE
3685 * xdisp.c (vmessage): Use a better test for character truncation.
3686
bbf47d44
PE
3687 * charset.c (load_charset_map): <, not <=, for optimization,
3688 and to avoid potential problems with integer overflow.
9248994d 3689 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3690 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3691 * editfns.c (Fformat): Likewise.
1e69125e 3692 * syntax.c (skip_chars): Likewise.
3befa583 3693
e3019616
PE
3694 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3695 This also lets GCC 4.6.0 generate slightly better loop code.
3696
becfa255
PE
3697 * callint.c (Fcall_interactively): <, not <=, for optimization.
3698 (Fcall_interactively): Count the number of arguments produced,
3699 not the number of arguments given. This is simpler and lets GCC
3700 4.6.0 generate slightly better code.
3701
dae0cd48
PE
3702 * ftfont.c: Distingish more carefully between FcChar8 and char.
3703 The previous code passed unsigned char * to a functions like
3704 strlen and xstrcasecmp that expect char *, which does not
3705 conform to the C standard.
3706 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3707 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3708 char * when the C standard requires it.
3709
76032d70
PE
3710 * keyboard.c (read_char): Remove unused var.
3711
eb3f1cc8
PE
3712 * eval.c: Port to Windows vsnprintf (Bug#8435).
3713 Include <limits.h>.
3714 (SIZE_MAX): Define if the headers do not.
3715 (verror): Do not give up if vsnprintf returns a negative count.
3716 Instead, grow the buffer. This ports to Windows vsnprintf, which
3717 does not conform to C99. Problem reported by Eli Zaretskii.
3718 Also, simplify the allocation scheme, by avoiding the need for
3719 calling realloc, and removing the ALLOCATED variable.
3720
70476b54
PE
3721 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3722
12020a9e
PE
3723 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3724 But keep the doprint source code for now, as we might revamp it
3725 and use it again (Bug#8435).
ea6c7ae6
PE
3726 * lisp.h (doprnt): Remove.
3727 * Makefile.in (base_obj): Remove doprnt.o.
3728 * deps.mk (doprnt.o): Remove.
3729
5fdb398c
PE
3730 error: Print 32- and 64-bit integers portably (Bug#8435).
3731 Without this change, on typical 64-bit hosts error ("...%d...", N)
3732 was used to print both 32- and 64-bit integers N, which relied on
3733 undefined behavior.
3734 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3735 New macro.
3736 * lisp.h (error, verror): Mark as printf-like functions.
3737 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3738 Report overflow in size calculations when allocating printf buffer.
3739 Do not truncate output string at its first null byte.
3740 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3741 Truncate the output at a character boundary, since vsnprintf does not
3742 do that.
3743 * charset.c (check_iso_charset_parameter): Convert internal
3744 character to string before calling 'error', since %c now has the
3745 printf meaning.
3746 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3747 overflow when computing char to be passed to 'error'. Do not
3748 pass Lisp_Object to 'error'; pass the integer instead.
3749 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3750 formatted with plain %d.
3751
b189fa66
PE
3752 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3753
bff87ef0
PE
3754 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3755
7e2cac20
PE
3756 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3757
ce4d90b5
PE
3758 * xterm.c (x_catch_errors): Remove duplicate declaration.
3759
266c9547
PE
3760 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3761
79c49ad2
PE
3762 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3763
368f4090
JM
37642011-04-10 Jim Meyering <meyering@redhat.com>
3765
3766 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3767 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3768 return ssize_t not "int", and use size_t as the buffer length.
3769 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3770 * gnutls.h: Update declarations.
3771 * process.c (read_process_output): Use ssize_t, to match.
3772 (send_process): Likewise.
3773
a32d4040
CY
37742011-04-09 Chong Yidong <cyd@stupidchicken.com>
3775
3776 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3777
8546720e 37782011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3779
04f2d78b
CB
3780 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3781 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3782
8546720e
GM
3783 * xterm.c (handle_one_xevent):
3784 * xmenu.c (create_and_show_popup_menu):
3785 * xselect.c (x_decline_selection_request)
3786 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3787
0a2f5c1a 37882011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3789
3790 Fix some uses of `int' instead of EMACS_INT.
3791 * search.c (string_match_1, fast_string_match)
3792 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3793 (scan_buffer, find_next_newline_no_quit)
3794 (find_before_next_newline, search_command, Freplace_match)
3795 (Fmatch_data): Make some `int' variables be EMACS_INT.
3796
3797 * xdisp.c (display_count_lines): 3rd argument and return value now
3798 EMACS_INT. All callers changed.
3799 (pint2hrstr): Last argument is now EMACS_INT.
3800
3801 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3802 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3803 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3804 (decode_coding_utf_16, decode_coding_emacs_mule)
3805 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3806 (decode_coding_ccl, decode_coding_charset)
3807 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3808 (decode_coding_iso_2022, decode_coding_emacs_mule)
3809 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3810 <char_offset, last_offset>: Declare EMACS_INT.
3811 (encode_coding_utf_8, encode_coding_utf_16)
3812 (encode_coding_emacs_mule, encode_invocation_designation)
3813 (encode_designation_at_bol, encode_coding_iso_2022)
3814 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3815 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3816 Declare EMACS_INT.
3817 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3818 (encode_invocation_designation): Last argument P_NCHARS is now
3819 EMACS_INT.
3820 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3821 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3822
3823 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3824 All users changed.
3825
3826 * ccl.c (Fccl_execute_on_string): Declare some variables
3827 EMACS_INT.
3828
8546720e 38292011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3830
3831 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3832
4e19a977
CS
38332011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3834
3835 * process.c (Fformat_network_address): Doc fix.
3836
87302331
R
38372011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3838
3839 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3840
cbb59342
CY
38412011-04-08 Chong Yidong <cyd@stupidchicken.com>
3842
3843 * keyboard.c (read_char): Call Lisp function help-form-show,
3844 instead of using internal_with_output_to_temp_buffer.
3845 (Qhelp_form_show): New var.
e0d38eeb 3846 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3847
3848 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3849
3850 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3851
e67a13ab
CY
38522011-04-06 Chong Yidong <cyd@stupidchicken.com>
3853
04f2d78b
CB
3854 * process.c (Flist_processes): Remove to Lisp.
3855 (list_processes_1): Delete.
e67a13ab 3856
973f782d
EZ
38572011-04-06 Eli Zaretskii <eliz@gnu.org>
3858
7c106b1e
EZ
3859 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3860
973f782d
EZ
3861 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3862
41cf7d1a 38632011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3864
ca23cc88
PE
3865 Fix more problems found by GCC 4.6.0's static checks.
3866
f390e2d5
PE
3867 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3868
42eea0d0
PE
3869 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3870
b69769da 3871 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3872
f9541e84
PE
3873 * xdisp.c (vmessage): Mark as a printf-like function.
3874
13841b55
PE
3875 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3876
c136c10f
PE
3877 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3878
5e2d4a30
PE
3879 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3880 printf-like functions.
3881 (tiff_load): Add casts to remove these marks before passing them
3882 to system-supplied API.
3883
583f48b9
PE
3884 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3885
b25d760e
PE
3886 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3887 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3888 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3889 directly, rather than having caller test rule sign. This avoids
3890 some unnecessary tests.
3891 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3892 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3893 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3894
bc7b6697 3895 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3896 (xfont_open): Avoid unnecessary tests.
bc7b6697 3897
27ccc379
PE
3898 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3899
dcd5c89a
PE
3900 * composite.h, composite.c (composition_gstring_put_cache):
3901 Use EMACS_INT, not int, for length.
3902
b13a45c6
PE
3903 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3904 breaking out part of COMPOSITION_DECODE_RULE.
3905 (COMPOSITION_DECODE_RULE): Use it.
3906 * composite.c (get_composition_id): Remove unused local vars,
3907 by using the new macro.
3908
1e792e4d
PE
3909 * textprop.c (set_text_properties_1): Change while to do-while,
3910 since the condition is always true at first.
3911
dc6c6455 3912 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3913 (interval_deletion_adjustment): Return unsigned value.
3914 All uses changed.
dc6c6455 3915
aba7731a
PE
3916 * process.c (list_processes_1, create_pty, read_process_output):
3917 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3918 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3919 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3920 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3921 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3922
fdfc4bf3
PE
3923 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3924
fca8fe46 3925 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3926 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3927
06a0259a 3928 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3929 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3930 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3931
e7b9e80f
PE
3932 * print.c (print_error_message): Avoid int overflow.
3933
56201685
PE
3934 * font.c (font_list_entities): Redo for clarity,
3935 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3936
78834453 3937 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3938 (font_score): Avoid potential overflow in diff calculation.
78834453 3939
0bc0b309 3940 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3941 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3942
e610eaca
PE
3943 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3944
b895abce
PE
3945 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3946 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3947 can always succeed if overflow has undefined behavior.
3948
1f1d9321 3949 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3950 (wordify): Omit three unnecessary tests.
1f1d9321 3951
c59478bc
PE
3952 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3953 All callers changed. This avoids the need for an unused var.
3954
79b73827
PE
3955 * casefiddle.c (casify_region): Remove var that is set but not used.
3956
a4db5dfe
PE
3957 * dired.c (file_name_completion): Remove var that is set but not used.
3958
43aae36e
PE
3959 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3960
2a47c44d 3961 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3962 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3963
a37c69bf
PE
3964 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3965 Check for integer overflow on size calculations.
3966
328ab8e7
PE
3967 * buffer.c (Fprevious_overlay_change): Remove var that is set
3968 but not used.
3969
e5a2a5cb
PE
3970 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3971 Remove vars that are set but not used.
8d84a6eb 3972 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3973 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3974
a60e5f68
PE
3975 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3976
f661cb61 3977 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3978 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3979
f0397f5a
PE
3980 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3981 that are set but not used.
3982
8664db06 3983 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3984 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3985
6abdaa4a
PE
3986 * xselect.c (x_get_local_selection, x_handle_property_notify):
3987 Remove vars that are set but not used.
3988
0ce7538d 3989 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3990 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3991
9ae848fc
PE
3992 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3993 Remove var that is set but not used.
0b918413
PE
3994 (scroll_bar_windows_size): Now size_t, not int.
3995 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3996 Check for overflow.
9ae848fc 3997
a5a62657
PE
3998 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3999 (map_tty_color) [!defined MSDOS]: Likewise.
4000
5c5cdd39
PE
4001 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4002
66ebf983
PE
4003 * coding.c: Remove vars that are set but not used.
4004 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4005 All callers changed.
4006 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4007 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4008 (decode_coding_charset): Remove vars that are set but not used.
4009
1be4d761
PE
4010 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4011 that is set but not used.
4012
47553fa8
PE
4013 * print.c (print_object): Remove var that is set but not used.
4014
1f7196bf 4015 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4016 The gnulib version avoids calling malloc in the usual case,
4017 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4018 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4019 * filelock.c (current_lock_owner): Likewise.
4020 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4021 * sysdep.c: Include allocator.h, careadlinkat.h.
4022 (emacs_no_realloc_allocator): New static constant.
4023 (emacs_readlink): New function.
fdb61804
PE
4024 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4025 ../lib/careadlinkat.h.
d1fdcab7 4026
f84c17c7
SM
40272011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4028
4029 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4030 first non-nil return value).
4031
ef3862ad
JD
40322011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4033
4034 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4035 if not defined (Bug#8403).
4036
376a7006
JB
40372011-04-02 Juanma Barranquero <lekktu@gmail.com>
4038
4039 * xdisp.c (display_count_lines): Remove parameter `start',
4040 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4041 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4042 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4043 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4044 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4045 and thereabouts. All callers changed.
4046 (get_per_char_metric): Remove parameter `f', unused since
4047 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4048
6ca3801d
JM
40492011-04-02 Jim Meyering <meyering@redhat.com>
4050
4051 do not dereference NULL upon failed strdup
4052 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4053 (ns_get_family): Likewise.
4054
d8e2b5ba
JB
40552011-04-02 Juanma Barranquero <lekktu@gmail.com>
4056
4057 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4058
8c74fcbd
JD
40592011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4060
4061 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4062 later (Bug#8403).
4063
7200d79c
SM
40642011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4065
03408648 4066 Add lexical binding.
7200d79c 4067
03408648
SM
4068 * window.c (Ftemp_output_buffer_show): New fun.
4069 (Fsave_window_excursion):
4070 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4071
4072 * lread.c (lisp_file_lexically_bound_p): New function.
4073 (Fload): Bind Qlexical_binding.
4074 (readevalloop): Remove `evalfun' arg.
4075 Bind Qinternal_interpreter_environment.
4076 (Feval_buffer): Bind Qlexical_binding.
4077 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4078 Mark as dynamic.
4079 (syms_of_lread): Declare `lexical-binding'.
4080
4081 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4082
4083 * keyboard.c (eval_dyn): New fun.
4084 (menu_item_eval_property): Use it.
ca105506
SM
4085
4086 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4087
03408648
SM
4088 * fns.c (concat, mapcar1): Accept byte-code-functions.
4089
4090 * eval.c (Fsetq): Handle lexical vars.
4091 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4092 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4093 (FletX, Flet): Obey lexical binding.
4094 (Fcommandp): Handle closures.
4095 (Feval): New `lexical' arg.
4096 (eval_sub): New function extracted from Feval. Use it almost
4097 everywhere where Feval was used. Look up vars in lexical env.
4098 Handle closures.
4099 (Ffunctionp): Move from subr.el.
4100 (Ffuncall): Handle closures.
4101 (apply_lambda): Remove `eval_flags'.
4102 (funcall_lambda): Handle closures and new byte-code-functions.
4103 (Fspecial_variable_p): New function.
4104 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4105 but without exporting it to Lisp.
23aba0ea 4106
23aba0ea 4107 * doc.c (Fdocumentation, store_function_docstring):
03408648 4108 * data.c (Finteractive_form): Handle closures.
23aba0ea 4109
03408648
SM
4110 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4111 interactive spec.
ba83908c 4112
04f2d78b
CB
4113 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4114 New byte-codes.
03408648
SM
4115 (exec_byte_code): New function extracted from Fbyte_code to handle new
4116 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4117
03408648 4118 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4119
03408648 4120 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4121
e2abce01
JB
41222011-03-31 Juanma Barranquero <lekktu@gmail.com>
4123
4124 * xdisp.c (redisplay_internal): Fix prototype.
4125
63696a73 41262011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4127
63696a73 4128 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4129 (try_scrolling): Use it when setting scroll_limit.
4130 Limit scrolling to 100 screen lines.
63696a73
EZ
4131 (redisplay_window): Even when falling back on "recentering",
4132 position point in the window according to scroll-conservatively,
4133 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4134
4135 (try_scrolling): When point is above the window, allow searching
4136 as far as scroll_max, or one screenful, to compute vertical
4137 distance from PT to the scroll margin position. This prevents
4138 try_scrolling from unnecessarily failing when
4139 scroll-conservatively is set to a value slightly larger than the
4140 window height. Clean up the case of PT below the margin at bottom
4141 of window: scroll_max can no longer be INT_MAX. When aggressive
4142 scrolling is in use, don't let point enter the opposite scroll
4143 margin as result of the scroll.
4144 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4145 threshold of 100 lines for never-recentering scrolling.
4146
e4cc2dfc
JB
41472011-03-31 Juanma Barranquero <lekktu@gmail.com>
4148
4149 * dispextern.h (move_it_by_lines):
4150 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4151 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4152 (message_log_check_duplicate): Remove parameters `prev_bol' and
4153 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4154 (redisplay_internal): Remove parameter `preserve_echo_area',
4155 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4156
4157 * indent.c (Fvertical_motion):
4158 * window.c (window_scroll_pixel_based, Frecenter):
4159 Don't pass `need_y_p' to `move_it_by_lines'.
4160
1c470562
SM
41612011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4162
44f230aa
SM
4163 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4164 steal a few bits to be more compact.
4165 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4166 Remove unneeded casts.
4167
1c470562
SM
4168 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4169
888adce9
ZK
41702011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4171
4172 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4173 binding" message (bug#7967).
4174
f838ed7b
PE
41752011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4176
77861b95
PE
4177 Fix more problems found by GCC 4.6.0's static checks.
4178
de6dbc14
PE
4179 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4180 Remove unused local var.
4181
f838ed7b
PE
4182 * editfns.c (Fmessage_box): Remove unused local var.
4183
792c7b2b
PE
4184 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4185 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4186 Omit unused local vars.
c499e557 4187 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4188 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4189 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4190 Omit unused local var.
4191
ba0165e1
PE
4192 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4193 Don't assume string length fits in int.
32ad8845 4194 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4195 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4196
3c59b4c9
PE
4197 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4198 instead of alloca (Bug#8344).
4199
a3eed478 4200 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4201 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4202
eb4d412d
PE
4203 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4204
1658b401
PE
4205 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4206 concerns.
4207
4208 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4209
4210 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4211
9a2c6e05
PE
4212 * keyboard.c (syms_of_keyboard): Use the same style as later
4213 in this function when indexing through an array. This also
4214 works around GCC bug 48267.
4215
03d0a109
PE
4216 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4217
44f730c8
PE
4218 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4219
fe75f926
PE
4220 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4221 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4222
ffa8c828
PE
4223 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4224 This avoids undefined behavior on integer overflow, and is a bit
4225 more convenient anyway since it is compared to a size_t variable.
4226
c5101a77
PE
4227 Variadic C functions now count arguments with size_t, not int.
4228 This avoids an unnecessary limitation on 64-bit machines, which
4229 caused (substring ...) to crash on large vectors (Bug#8344).
4230 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4231 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4232 All variadic functions and their callers changed accordingly.
c5101a77
PE
4233 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4234 * data.c (arith_driver, float_arith_driver): Likewise.
4235 * editfns.c (general_insert_function): Likewise.
4236 * eval.c (struct backtrace.nargs, interactive_p)
4237 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4238 (funcall_lambda, mark_backtrace): Likewise.
4239 * fns.c (concat): Likewise.
4240 * frame.c (x_set_frame_parameters): Likewise.
4241 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4242 0 if not found, not -1. All callers changed.
4243
dd3f25f7
PE
4244 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4245 (stack_copy_size): Now size_t, not int.
4246 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4247
461c2ab9
JB
42482011-03-28 Juanma Barranquero <lekktu@gmail.com>
4249
4250 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4251 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4252 All callers changed.
4253
4254 * lisp.h (multibyte_char_to_unibyte):
4255 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4256 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4257 * character.h (CHAR_TO_BYTE8):
4258 * cmds.c (internal_self_insert):
4259 * editfns.c (general_insert_function):
4260 * keymap.c (push_key_description):
4261 * search.c (Freplace_match):
4262 * xdisp.c (message_dolog, set_message_1): All callers changed.
4263
f6d62986
SM
42642011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4265
4266 * keyboard.c (safe_run_hook_funcall): New function.
4267 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4268 don't set the hook to nil, but remove the offending function instead.
4269 (Qcommand_hook_internal): Remove, unused.
4270 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4271 Vcommand_hook_internal.
4272
4273 * eval.c (enum run_hooks_condition): Remove.
4274 (funcall_nil, funcall_not): New functions.
4275 (run_hook_with_args): Call each function through a `funcall' argument.
4276 Remove `cond' argument, now redundant.
4277 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4278 (Frun_hook_with_args_until_failure): Adjust accordingly.
4279 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4280
1db5b1ad
JB
42812011-03-28 Juanma Barranquero <lekktu@gmail.com>
4282
4283 * dispextern.h (string_buffer_position): Remove declaration.
4284
4285 * print.c (strout): Remove parameter `multibyte', unused since
4286 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4287
4288 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4289 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4290 All callers changed.
4291
4292 * w32.c (_wsa_errlist): Use braces for struct initializers.
4293
4294 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4295 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4296 All callers changed.
4297 (string_buffer_position): Likewise. Also, make static (it's never
4298 used outside xdisp.c).
4299 (cursor_row_p): Remove parameter `w', unused since
4300 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4301 (decode_mode_spec): Remove parameter `precision', introduced during
4302 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4303 All callers changed.
4304
5ffb62aa
JD
43052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4306
4307 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4308
461c2ab9 43092011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4310
4311 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4312 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4313 (ns_update_auto_hide_menu_bar): New functions.
4314 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4315 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4316 ns_constrain_all_frames.
4317 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4318 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4319
5c380ffb
JD
43202011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4321
4322 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4323
9af30bdf
GM
43242011-03-27 Glenn Morris <rgm@gnu.org>
4325
4326 * syssignal.h: Replace RETSIGTYPE with void.
4327 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4328 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4329 Replace SIGTYPE with void everywhere.
4330 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4331 * s/template.h (SIGTYPE): Remove commented out definition.
4332
e2abce01
JB
43332011-03-26 Eli Zaretskii <eliz@gnu.org>
4334
4335 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4336 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4337
f868cd8a
JB
43382011-03-26 Juanma Barranquero <lekktu@gmail.com>
4339
59eb0929
JB
4340 * w32.c (read_unc_volume): Use parameter `henum', instead of
4341 global variable `wget_enum_handle'.
4342
4343 * keymap.c (describe_vector): Remove parameters `indices' and
4344 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4345 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4346
f868cd8a
JB
4347 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4348
4349 * keyboard.c (timer_check): Remove parameter `do_it_now',
4350 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4351 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4352 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4353
4354 * keyboard.c (read_char):
4355 * w32menu.c (w32_menu_display_help):
4356 * xmenu.c (show_help_event, menu_help_callback):
4357 Adjust calls to `show_help_echo'.
4358
4359 * gtkutil.c (xg_maybe_add_timer):
4360 * keyboard.c (readable_events):
4361 * process.c (wait_reading_process_output):
4362 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4363
4364 * insdel.c (adjust_markers_gap_motion):
4365 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4366 (gap_left, gap_right): Don't call it.
4367
2ecf6fdb
CY
43682011-03-25 Chong Yidong <cyd@stupidchicken.com>
4369
4370 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4371 incurred during fontification.
4372
6b1f9ba4
JB
43732011-03-25 Juanma Barranquero <lekktu@gmail.com>
4374
4375 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4376 (DEFVAR_PER_BUFFER): Don't pass it.
4377
4378 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4379 (scrolling_window): Don't pass it.
4380
0f4a96b5
JB
43812011-03-25 Juanma Barranquero <lekktu@gmail.com>
4382
4383 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4384
4385 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4386 and `suffix'.
4387 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4388 of variables specific to SELinux and computation of `encoded_absname'.
4389
4390 * image.c (XPutPixel): Remove unused variable `height'.
4391
4392 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4393
4394 * unexw32.c (get_section_info): Remove unused variable `section'.
4395
4396 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4397 (system_process_attributes): Remove unused variable `sess'.
4398 (sys_read): Remove unused variable `err'.
4399
4400 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4401 (w32_wnd_proc): Remove unused variable `isdead'.
4402 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4403 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4404 (x_create_tip_frame): Remove unused variable `tem'.
4405
4406 * w32inevt.c (w32_console_read_socket):
4407 Remove unused variable `no_events'.
4408
4409 * w32term.c (x_draw_composite_glyph_string_foreground):
4410 Remove unused variable `width'.
4411
1149507c
JB
44122011-03-24 Juanma Barranquero <lekktu@gmail.com>
4413
4414 * w32term.c (x_set_glyph_string_clipping):
4415 Don't pass uninitialized region to CombineRgn.
4416
9c88f339
JB
44172011-03-23 Juanma Barranquero <lekktu@gmail.com>
4418
4419 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4420 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4421 (Fx_close_connection): Remove unused variable `i'.
4422
4423 * w32font.c (w32font_draw): Return number of glyphs.
4424 (w32font_open_internal): Remove unused variable `i'.
4425 (w32font_driver): Add missing initializer.
4426
4427 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4428 (fill_in_menu): Remove unused variable `items_added'.
4429
4430 * w32term.c (last_mouse_press_frame): Remove static global variable.
4431 (w32_clip_to_row): Remove unused variable `f'.
4432 (x_delete_terminal): Remove unused variable `i'.
4433
4434 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4435 (NOTHING): Remove unused static global variable.
4436 (uniscribe_check_otf): Remove unused variable `table'.
4437 (uniscribe_font_driver): Add missing initializers.
4438
dee091a3
JD
44392011-03-23 Julien Danjou <julien@danjou.info>
4440
4441 * term.c (Fsuspend_tty, Fresume_tty):
4442 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4443 * window.c (temp_output_buffer_show):
4444 * insdel.c (signal_before_change):
4445 * frame.c (Fhandle_switch_frame):
4446 * fileio.c (Fdo_auto_save):
4447 * emacs.c (Fkill_emacs):
4448 * editfns.c (save_excursion_restore):
4449 * cmds.c (internal_self_insert):
4450 * callint.c (Fcall_interactively):
4451 * buffer.c (Fkill_all_local_variables):
4452 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4453 Use Frun_hooks.
0f4a96b5 4454 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4455 unconditionnaly since it does the check itself.
4456
2c520ab5 44572011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4458
c9c49752
PE
4459 Fix more problems found by GCC 4.5.2's static checks.
4460
8abc3f12
PE
4461 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4462 the first time through the loop, since we know p0 < p1 then.
4463 This also avoids a gcc -Wstrict-overflow warning.
4464
a2d26660
PE
4465 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4466 leading to a memory leak, possible in functions like
4467 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4468 of objects (Bug#8318).
a2d26660 4469
916c72e9
PE
4470 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4471 that could (at least in theory) be that large.
4472
19ab8a18
PE
4473 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4474 This is less likely to overflow, and avoids undefined behavior if
4475 overflow does occur. All callers changed. Use strtoul to scan
4476 for the unsigned long integer.
b7cbbd6f
PE
4477 (pint2hrstr): Simplify and tune code slightly.
4478 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4479
f0641eff
PE
4480 * scroll.c (do_scrolling): Work around GCC bug 48228.
4481 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4482
7f650bb9
PE
4483 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4484 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4485 (validate_x_resource_name): Simplify count usage.
4486 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4487
37dd57d1
PE
4488 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4489 fail (Bug#8306).
81e56e61 4490
699979fc 4491 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4492
401bf9b4
PE
4493 * process.c (Fmake_network_process): Use socklen_t, not int,
4494 where POSIX says socklen_t is required in portable programs.
4495 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4496 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4497 (Fmake_network_process, server_accept_connection):
4498 (wait_reading_process_output, read_process_output):
4499 Likewise.
4500
b93aacde
PE
4501 * process.c: Rename or move locals to avoid shadowing.
4502 (list_processes_1, Fmake_network_process):
4503 (read_process_output_error_handler, exec_sentinel_error_handler):
4504 Rename or move locals.
4dc343ee 4505 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4506 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4507 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4508 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4509 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4510
af8a867c 4511 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4512 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4513 Include tparam.h instead, since it declares them.
af8a867c
PE
4514 * cm.h (PC): Remove extern decl; tparam.h now does this.
4515 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4516 * terminfo.c: Include tparam.h, to check interfaces.
4517 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4518 (tparam): Adjust signature to match interface in tparam.h;
4519 this removes some undefined behavior. Check that outstring and len
4520 are zero, which they always are with Emacs.
4521 * tparam.h (PC, BC, UP): New extern decls.
4522
0248044d 4523 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4524 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4525
8ff096c1 4526 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4527 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4528 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4529 (ftfont_list): Remove unused local.
49eaafba
PE
4530 (get_adstyle_property, ftfont_pattern_entity):
4531 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4532 Rename locals to avoid shadowing.
8ff096c1 4533
e2be39f6
PE
4534 * xfont.c (xfont_list_family): Mark var as initialized.
4535
c9735e30
PE
4536 * xml.c (make_dom): Now static.
4537
8f5201ae
PE
4538 * composite.c (composition_compute_stop_pos): Rename local to
4539 avoid shadowing.
b246f932
PE
4540 (composition_reseat_it): Remove unused locals.
4541 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4542 (composition_update_it): Mark var as initialized.
11b61122
PE
4543 (find_automatic_composition): Mark vars as initialized,
4544 with a FIXME (Bug#8290).
8f5201ae 4545
760fbc2c
PE
4546 character.h: Rename locals to avoid shadowing.
4547 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4548 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4549 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4550 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4551 to avoid shadowing.
4552
ff08eb85
PE
4553 * textprop.c (property_change_between_p): Remove; unused.
4554
fc7bf025
PE
4555 * intervals.c (interval_start_pos): Now static.
4556
235d7abc
PE
4557 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4558
44f230aa
SM
4559 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4560 Rename locals to avoid shadowing.
3e7d6594 4561
50060332
PE
4562 * sound.c (wav_play, au_play, Fplay_sound_internal):
4563 Fix pointer signedness.
d01f234b 4564 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4565 (wav_play): Initialize a variable to 0, to prevent undefined
4566 behavior (Bug#8278).
50060332 4567
c4fc4e30
PE
4568 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4569
918436ed
PE
4570 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4571
c939f91b
PE
4572 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4573 clobbering (Bug#8298).
b9c7f648
PE
4574 * sysdep.c (sys_subshell): Likewise.
4575 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4576
6bd8c144
PE
4577 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4578 This should get cleaned up, so that child_setup has the
4579 same signature on all platforms.
4580
7710357c 4581 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4582 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4583
c59da222
CY
45842011-03-22 Chong Yidong <cyd@stupidchicken.com>
4585
4586 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4587 not to be necessary, and produces flickering.
4588
66b87493
GM
45892011-03-20 Glenn Morris <rgm@gnu.org>
4590
4591 * config.in: Remove file.
4592
45b6f6d5
JB
45932011-03-20 Juanma Barranquero <lekktu@gmail.com>
4594
4595 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4596 are now in src/globals.h.
4597 (syms_of_minibuf): Remove spurious & from previous change.
4598
3ec03f7e
LL
45992011-03-20 Leo <sdl.web@gmail.com>
4600
4601 * minibuf.c (completing-read-function): New variable.
4602 (completing-read-default): Rename from completing-read.
4603 (completing-read): Call completing-read-function.
4604
b14e3e21
CY
46052011-03-19 Juanma Barranquero <lekktu@gmail.com>
4606
4607 * xfaces.c (Fx_load_color_file):
4608 Read color file from absolute filename (bug#8250).
4609
f2b726e6
JB
46102011-03-19 Juanma Barranquero <lekktu@gmail.com>
4611
4612 * makefile.w32-in: Update dependencies.
4613
09f6ff02
EZ
46142011-03-17 Eli Zaretskii <eliz@gnu.org>
4615
4616 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4617
29a6015a
PE
46182011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4619
a3a6c54e
PE
4620 Fix more problems found by GCC 4.5.2's static checks.
4621
b766f867
PE
4622 * process.c (make_serial_process_unwind, send_process_trap):
4623 (sigchld_handler): Now static.
4624
be02381c
PE
4625 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4626 That way, the code declares only the vars that it needs.
4627 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4628 * s/cygwin.h (PTY_ITERATION): Likewise.
4629 * s/darwin.h (PTY_ITERATION): Likewise.
4630 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4631
57048744
PE
4632 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4633 * process.c (allocate_pty): Don't declare stb unless it's needed.
4634
7914961c 4635 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4636 (CONSTANTLIM): Remove; unused.
4637 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4638 Define only if needed.
7914961c 4639
b3967b18
PE
4640 * unexelf.c (unexec): Name an expression,
4641 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4642 Use a different way to cause a compilation error if anyone uses
4643 n rather than nn, a way that does not involve shadowing.
73366a00 4644 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4645
29a6015a
PE
4646 * deps.mk (unexalpha.o): Remove; unused.
4647
43cfc33e 4648 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4649 * unexec.h: New file.
ce701a33
PE
4650 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4651 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4652 Depend on unexec.h.
4653 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4654 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4655 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4656 Change as necessary to match prototype in unexec.h.
ce701a33 4657
01f44d5a
PE
4658 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4659 shadowing.
4f63c6bb 4660 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4661
a6670b0b
PE
4662 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4663 Rename locals to avoid shadowing.
4664
cef2010d 4665 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4666 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4667
d4d7173a
PE
4668 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4669
f08b802a
PE
4670 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4671 warning when compiling print.c.
4672
3ddb0639
PE
4673 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4674 instead of using an uninitialized var.
5ad03b97 4675 (font_sort_entities): Mark var as initialized.
3ddb0639 4676
170a2692
PE
4677 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4678
e663c700
PE
4679 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4680 pointers to constants.
89bc529a 4681 (font_parse_fcname): Remove unused vars.
7b81e2d0 4682 (font_delete_unmatched): Now static.
ea838e10 4683 (font_get_spec): Remove; unused.
13a547c6
PE
4684 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4685 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4686 Rename or move locals to avoid shadowing.
e663c700 4687
2a80c887 4688 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4689 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4690
1384fa33 4691 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4692 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4693
8b2c52e9
PE
4694 * alloc.c (mark_backtrace): Move decl from here ...
4695 * lisp.h: ... to here, so that it can be checked.
4696
475545b5 4697 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4698 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4699 (lisp_indirect_variable): Name an expression,
4700 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4701 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4702
b1349114 4703 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4704 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4705 Use const pointer when appropriate.
b1349114 4706
a2928364
PE
4707 * lisp.h (get_system_name, get_operating_system_release):
4708 Move decls here, to check interfaces.
4709 * process.c (get_operating_system_release): Move decl to lisp.h.
4710 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4711 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4712 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4713 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4714 (Fformat_time_string, Fencode_time, Finsert_char):
4715 (Ftranslate_region_internal, Fformat):
4716 Rename or remove local vars to avoid shadowing.
9710023e 4717 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4718
a415e694
PE
4719 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4720 avoid shadowing.
4721
8ef4622d
PE
4722 * lisp.h (eassert): Check that the argument compiles, even if
4723 ENABLE_CHECKING is not defined.
4724
946f9a5b
PE
4725 * data.c (Findirect_variable): Name an expression, to avoid
4726 gcc -Wbad-function-cast warning.
112396d6 4727 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4728 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4729 (Fmake_variable_buffer_local, Fmake_local_variable):
4730 Mark variables as initialized.
52746918 4731 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4732
e5aab7e7 4733 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4734 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4735 Rename locals to avoid shadowing.
dff45157
PE
4736 (mark_stack): Move local variables into the #ifdef region where
4737 they're used.
7bc26fdb
PE
4738 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4739 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4740 needed otherwise.
4741 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4742 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4743 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4744
e5aab7e7
PE
4745 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4746 avoids undefined behavior in theory.
4747
4da60324
PE
4748 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4749
88043301
PE
4750 Use functions, not macros, for up- and down-casing (Bug#8254).
4751 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4752 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4753 to use the following functions instead of these macros.
4754 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4755 EMACS_INT, since callers assume the returned value fits in int.
4756 (upcase1): Likewise, for UPCASE_TABLE.
4757 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4758 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4759 the race-condition problem in the old DOWNCASE.
88043301 4760
19ed5445
PE
4761 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4762 Rename locals to avoid shadowing.
4763 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4764 (regex_compile, re_search_2, re_match_2_internal):
4765 Remove unused local vars.
952db0d7
PE
4766 (FREE_VAR): Rewrite so as not to use empty "else",
4767 which gcc can warn about.
da053e48 4768 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4769 (RETALLOC_IF): Define only if needed.
4770 (WORDCHAR_P): Likewise. This one is never needed, but is used
4771 only in a comment talking about a compiler bug, so put inside
4772 the #if 0 of that comment.
4773 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4774 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4775 Remove; unused.
19ed5445 4776
1f3561e4 4777 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4778 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4779 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4780
ded6f8f7
PE
4781 * search.c (simple_search): Remove unused var.
4782
dbd37a95
PE
4783 * dired.c (compile_pattern): Move decl from here ...
4784 * lisp.h: ... to here, so that it can be checked.
4785 (struct re_registers): New forward decl.
4786
7e47afad
PE
4787 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4788
85f24f61
PE
4789 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4790 All uses changed.
4791 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4792 Rename locals to avoid shadowing.
5671df8f 4793 (Fvertical_motion): Mark locals as initialized.
85f24f61 4794
181aa2be 4795 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4796 (casify_region): Mark local as initialized.
181aa2be 4797
930d429c
PE
4798 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4799
7082eac6
PE
4800 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4801 New macros, so that the caller can use some names other than
4802 gcpro1, gcpro2, etc.
4803 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4804 of the new macros.
4805 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4806 argument, for consistency with GCPRO2_VAR, etc: it is now the
4807 prefix of the variable, not the variable itself. All uses
4808 changed.
38b2c076
PE
4809 * dired.c (directory_files_internal, file_name_completion):
4810 Rename locals to avoid shadowing.
4811
15206ed9
PE
4812 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4813 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4814 dired.c's scmp function, had undefined behavior.
4815 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4816 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4817 * buffer.h: ... to here, because these macros use current_buffer,
4818 and the new implementation with inline functions needs to have
4819 current_buffer in scope now, rather than later when the macros
4820 are used.
4821 (downcase, upcase1): New static inline functions.
4822 (DOWNCASE, UPCASE1): Reimplement using these functions.
4823 This avoids undefined behavior in expressions like
4824 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4825 from race conditions in accessing the global variables
4826 case_temp1 and case_temp2.
4827 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4828 * lisp.h (case_temp1, case_temp2): Remove their decls.
4829 * character.h (ASCII_CHAR_P): Move from here ...
4830 * lisp.h: ... to here, so that the inline functions mentioned
4831 above can use them.
4832
4a6bea26
PE
4833 * dired.c (directory_files_internal_unwind): Now static.
4834
f14b7e14
PE
4835 * fileio.c (file_name_as_directory, directory_file_name):
4836 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4837 Now static.
2893f146
PE
4838 (file_name_as_directory): Use const pointers when appropriate.
4839 (Fexpand_file_name): Likewise. In particular, newdir might
4840 point at constant storage, so make it a const pointer.
fd4ead52 4841 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4842 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4843 signedness issues.
f839df0c
PE
4844 (Fset_file_times, Finsert_file_contents, auto_save_error):
4845 Rename locals to avoid shadowing.
f14b7e14 4846
5716756e 4847 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4848 (Ftry_completion, Fall_completions): Rename or remove locals
4849 to avoid shadowing.
5716756e 4850
b4c3046a
PE
4851 * marker.c (bytepos_to_charpos): Remove; unused.
4852
b45db522
PE
4853 * lisp.h (verify_bytepos, count_markers): New decls,
4854 so that gcc does not warn that these functions aren't declared.
4855
85876d07
PE
4856 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4857 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4858 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4859 (copy_text): Remove unused local var.
85876d07 4860
03d78a21 4861 * filelock.c (within_one_second): Now static.
b3dd38ab 4862 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4863
5df8f01b
PE
4864 * buffer.c (fix_overlays_before): Mark locals as initialized.
4865 (fix_start_end_in_overlays): Likewise. This function should be
4866 simplified by using pointers-to-pointers, but that's a different
4867 matter.
b1d876f1 4868 (switch_to_buffer_1): Now static.
8f54f30a
PE
4869 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4870 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4871
a70072c9 4872 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4873 Fix pointer signedness issue.
edced198
PE
4874 (sys_subshell): Mark local as volatile if checking for lint,
4875 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4876 (MAXPATHLEN): Define only if needed.
a70072c9 4877
a0977c44
PE
4878 * process.c (serial_open, serial_configure): Move decls from here ...
4879 * systty.h: ... to here, so that they can be checked.
4880
a884fdcc
PE
4881 * fns.c (get_random, seed_random): Move extern decls from here ...
4882 * lisp.h: ... to here, so that they can be checked.
4883
604efe86 4884 * sysdep.c (reset_io): Now static.
b8950c94 4885 (wait_for_termination_signal): Remove; unused.
604efe86 4886
38fc62d9
PE
4887 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4888 (copy_keymap_item, append_key, push_text_char_description):
4889 Now static.
1004a21a 4890 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4891 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4892 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4893 (describe_map_tree):
4894 Rename locals to avoid shadowing.
38fc62d9 4895
2f2650da
PE
4896 * keyboard.c: Declare functions static if they are not used elsewhere.
4897 (echo_char, echo_dash, cmd_error, top_level_2):
4898 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4899 (read_char, kbd_buffer_get_event, make_lispy_position):
4900 (make_lispy_event, make_lispy_movement, apply_modifiers):
4901 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4902 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4903 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4904 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4905 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4906
a053e86c 4907 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4908 (mark_kboards): Move decl here ...
4909 * alloc.c (mark_kboards): ... from here.
a053e86c 4910
4752793e
PE
4911 * lisp.h (force_auto_save_soon): New decl.
4912
74f10ca7 4913 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4914 (DEFINE_DUMMY_FUNCTION): New macro.
4915 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4916 Use it.
c03cd23f
PE
4917 (main): Add casts to avoid warnings
4918 if GCC considers string literals to be constants.
74f10ca7 4919
022e70d4
PE
4920 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4921
59d6fe83
PE
4922 * dbusbind.c: Pointer signedness fixes.
4923 (xd_signature, xd_append_arg, xd_initialize):
4924 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4925 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4926 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4927 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4928
78320123
PE
4929 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4930 if GCC considers string literals to be constants.
49cebcca 4931 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4932
35ac2a97
SM
49332011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4934
fb103ca9
SM
4935 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4936 (print_preprocess, print_object): New macro to fix last change.
4937
35ac2a97
SM
4938 * print.c (print_preprocess): Don't forget font objects.
4939
62973b41
JB
49402011-03-16 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * emacs.c (USAGE3): Doc fixes.
4943
0e48bb22
AS
49442011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4945
4946 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4947 structure.
4948
7684e57b
JB
49492011-03-14 Juanma Barranquero <lekktu@gmail.com>
4950
4951 * lisp.h (VWindow_system, Qfile_name_history):
4952 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4953 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4954 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4955
4956 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4957 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4958
4959 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4960 * w32console.c (detect_input_pending, read_input_pending)
4961 (encode_terminal_code):
4962 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4963 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4964 (w32_system_caret_y, Qfile_name_history):
4965 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4966 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4967 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4968 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4969 * w32proc.c (Qlocal, report_file_error):
4970 * w32term.c (Vwindow_system, updating_frame):
4971 * w32uniscribe.c (initialized, uniscribe_font_driver):
4972 Remove unneeded extern declarations.
4973
2aa46d6c
CY
49742011-03-14 Chong Yidong <cyd@stupidchicken.com>
4975
c96bbc66 4976 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4977
cffc6f3b
CY
49782011-03-13 Chong Yidong <cyd@stupidchicken.com>
4979
4980 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4981 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4982 These macros can no longer be used for assignment.
4983
44f230aa
SM
4984 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4985 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4986 (record_buffer_markers, fetch_buffer_markers): New functions for
4987 recording and fetching special buffer markers.
4988 (set_buffer_internal_1, set_buffer_temp): Use them.
4989
4990 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4991
4992 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4993
4994 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4995 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4996
4997 * xdisp.c (hscroll_window_tree):
4998 (reconsider_clip_changes): Use PT instead of BUF_PT.
4999
d251f04b
EZ
50002011-03-13 Eli Zaretskii <eliz@gnu.org>
5001
5002 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5003 $(EMACS_ROOT)/lib/intprops.h.
5004
f0c77cd1
PE
50052011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5006
3eca4629
PE
5007 Fix more problems found by GCC 4.5.2's static checks.
5008
7c86ee98
PE
5009 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5010 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5011 (xg_free_frame_widgets): Make it clear that a local variable is
5012 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5013 (gdk_window_get_screen): Make it clear that this macro is needed
5014 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5015 (int_gtk_range_get_value): New function, which avoids a diagnostic
5016 from gcc -Wbad-function-cast.
5017 (xg_set_toolkit_scroll_bar_thumb): Use it.
5018 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5019 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5020 (get_utf8_string, xg_get_file_with_chooser):
5021 Rename locals to avoid shadowing.
5022 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5023
41729b81
PE
5024 * xgselect.c (xg_select): Remove unused var.
5025
f0c77cd1
PE
5026 * image.c (four_corners_best): Mark locals as initialized.
5027 (gif_load): Initialize transparent_p to zero (Bug#8238).
5028 Mark another local as initialized.
ec6cf4c6 5029 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5030
ce0ad53d 5031 * image.c (clear_image_cache): Now static.
d5d5a617 5032 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5033 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5034 (x_edge_detection): Remove unnecessary cast that
5035 gcc -Wbad-function-cast diagnoses.
2037898d 5036 (gif_load): Fix pointer signedness.
6ae141d6
PE
5037 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5038 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5039
33383987 50402011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5041
d32df629
PE
5042 Improve quality of tests for time stamp overflow.
5043 For example, without this patch (encode-time 0 0 0 1 1
5044 1152921504606846976) returns the obviously-bogus value (-948597
5045 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5046 reports time overflow. See
5047 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5048 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5049 * editfns.c: Include limits.h and intprops.h.
5050 (TIME_T_MIN, TIME_T_MAX): New macros.
5051 (time_overflow): Move earlier, to before first use.
5052 (hi_time, lo_time): New functions, for an accurate test for
5053 out-of-range times.
5054 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5055 (Fget_internal_run_time): Don't assume time_t fits in int.
5056 (make_time): Use list2 instead of Fcons twice.
5057 (Fdecode_time): More accurate test for out-of-range times.
5058 (check_tm_member): New function.
5059 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5060 (lisp_time_argument): Don't rely on undefined left-shift and
5061 right-shift behavior when checking for time stamp overflow.
8be6f318 5062
fe31d94c
PE
5063 * editfns.c (time_overflow): New function, refactoring common code.
5064 (Fformat_time_string, Fdecode_time, Fencode_time):
5065 (Fcurrent_time_string): Use it.
5066
8be6f318
PE
5067 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5068 * dired.c (make_time): Move to ...
5069 * editfns.c (make_time): ... here.
5070 * systime.h: Note the move.
5071
09d9db2c 50722011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5073
126bc0dc
YM
5074 * fringe.c (update_window_fringes): Remove unused variables.
5075
c47cbdfd
YM
5076 * unexmacosx.c (copy_data_segment): Also copy __got section.
5077 (Bug#8223)
5078
7ac80be9
EZ
50792011-03-12 Eli Zaretskii <eliz@gnu.org>
5080
c96bbc66 5081 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5082 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5083 Constify `char *' arguments and their references according to
5084 prototypes in tparam.h.
5085
ecb0f94d 5086 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5087
7ac80be9
EZ
5088 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5089 Adapt all references accordingly.
5090
5091 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5092
ef1fd07e
TT
50932011-03-11 Tom Tromey <tromey@redhat.com>
5094
5095 * buffer.c (syms_of_buffer): Remove obsolete comment.
5096
7ef4b50c
EZ
50972011-03-11 Eli Zaretskii <eliz@gnu.org>
5098
5099 * termhooks.h (encode_terminal_code): Declare prototype.
5100
5101 * msdos.c (encode_terminal_code): Don't declare prototype.
5102
5103 * term.c (encode_terminal_code): Now external again, used by
5104 w32console.c and msdos.c.
5105
44f230aa
SM
5106 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5107 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5108
4b1ec863 51092011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5110
1714f52b 5111 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5112
4b1ec863
PE
5113 * fringe.c (update_window_fringes): Mark locals as initialized
5114 (Bug#8227).
5115 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5116
524c7aa6
PE
5117 * alloc.c (mark_fringe_data): Move decl from here ...
5118 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5119 to check its interface.
5120 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5121
a5c0af81 5122 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5123 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5124 (fontset_font): Mark local as initialized.
a9a06e0b 5125 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5126
b4716021
PE
5127 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5128
811e9bac 5129 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5130 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5131 (x_own_selection, Fx_disown_selection_internal): Rename locals
5132 to avoid shadowing.
5133 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5134
7e3ab302
PE
5135 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5136 so that the caller can use some name other than gcpro1.
5137 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5138 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5139 (Fx_backspace_delete_keys_p):
5140 Use them to avoid shadowing, and rename vars to avoid shadowing.
5141 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5142 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5143 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5144 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5145 Remove unused locals.
7e3ab302
PE
5146 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5147 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5148 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5149 macros.
f78faa98 5150
e2b13473
PE
5151 * xterm.h (x_mouse_leave): New decl.
5152
77f23912
PE
5153 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5154 Remove unused functions.
cdf4ba58
PE
5155 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5156 (x_calc_absolute_position): Now static.
7411c686 5157 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5158 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5159 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5160 unless they are used.
38d0b34a
PE
5161 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5162 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5163 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5164 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5165 (x_error_catcher, x_connection_closed, x_error_handler):
5166 (x_error_quitter, xembed_send_message, x_iconify_frame):
5167 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5168 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5169 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5170
44f230aa
SM
5171 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5172 Rename or move locals to avoid shadowing.
6b463e58 5173 (tty_defined_color, merge_face_heights): Now static.
5967d051 5174 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5175 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5176 does not deduce is never used uninitialized.
73719eba
PE
5177 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5178 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5179
426994c3 5180 * terminal.c (store_terminal_param): Now static.
5489860b 5181
032f1620 5182 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5183 (set_frame_menubar): Remove unused local.
d4323972 5184 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5185 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5186 since they might point to immutable storage.
281585b0
PE
5187 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5188 since it's unused otherwise.
032f1620 5189
367c19e5 5190 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5191 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5192 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5193 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5194 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5195 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5196 does not deduce are never used uninitialized.
70739cbe 5197
07b48fa9
PE
5198 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5199
8868a238 5200 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5201 * window.c (window_loop, size_window):
5202 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5203
7e5cf297 5204 * window.c (display_buffer): Now static.
d6550a9f
PE
5205 (size_window): Mark variables that gcc -Wuninitialized
5206 does not deduce are never used uninitialized.
a586633d
PE
5207 * window.h (check_all_windows): New decl, to forestall
5208 gcc -Wmissing-prototypes diagnostic.
5b555da1 5209 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5210
f6095868
PE
5211 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5212 shadowing.
5213 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5214 Include <limits.h>.
5215 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5216 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5217 (load_charset_map): Mark variables that gcc -Wuninitialized
5218 does not deduce are never used uninitialized.
53df7c11 5219 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5220
f38b440c
PE
5221 * coding.c (coding_set_source, coding_set_destination):
5222 Use "else { /* comment */ }" rather than "else /* comment */;"
5223 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5224 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5225 a block, when the outer 'i' will do.
5226 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5227 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5228 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5229 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5230 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5231 Rename locals to avoid shadowing.
5232 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5233 * coding.c (emacs_mule_char, encode_invocation_designation):
5234 Now static, since they're not used elsewhere.
413bb2db 5235 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5236 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5237 (decode_coding_emacs_mule): Mark variables that gcc
5238 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5239 (detect_coding_iso_2022): Initialize a local variable that might
5240 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5241 this initialization is needed. (Bug#8211)
5f58e762
PE
5242 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5243 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5244 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5245 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5246 Remove unused macros.
f38b440c 5247
232b38b9 5248 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5249 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5250 * character.c (string_count_byte8): Likewise.
232b38b9 5251
fb90da1b
PE
5252 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5253 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5254
fb93dbc2
PE
5255 * chartab.c (copy_sub_char_table): Now static, since it's not used
5256 elsewhere.
5c156ace
PE
5257 (sub_char_table_ref_and_range, char_table_ref_and_range):
5258 Rename locals to avoid shadowing.
bbcd0949 5259 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5260
7d3b3862 5261 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5262 (BIDI_BOB): Remove unused macro.
7d3b3862 5263
6be7d3da
PE
5264 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5265 deduce are never used uninitialized.
c2ed9c8b 5266 * term.c (encode_terminal_code): Likewise.
6be7d3da 5267
75f8807f 5268 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5269
50938595
PE
5270 * tparam.h: New file.
5271 * term.c, tparam.h: Include it.
5272 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5273 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5274 Move these decls to tparam.h, and make them agree with what
5275 is actually in tparam.c. The previous trick of using incompatible
5276 decls in different modules does not conform to the C standard.
5277 All callers of tparam changed to use tparam's actual API.
5278 * tparam.c (tparam1, tparam, tgoto):
5279 Use const pointers where appropriate.
5280
fbceeba2
PE
5281 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5282 * cm.h (struct cm): Likewise.
5283 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5284 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5285 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5286 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5287 (turn_on_face, init_tty): Likewise.
5288 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5289
7f3f1250
PE
5290 * term.c (term_mouse_position): Rename local to avoid shadowing.
5291
e6ca6543
PE
5292 * alloc.c (mark_ttys): Move decl from here ...
5293 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5294
c40f8d15
AS
52952011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5296
5297 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5298
cfe0661d
JB
52992011-03-09 Juanma Barranquero <lekktu@gmail.com>
5300
5301 * search.c (compile_pattern_1): Remove argument regp, unused since
5302 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5303 (compile_pattern): Don't pass it.
5304
0afb4571
J
53052011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5306
5307 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5308 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5309 for ! HAVE_GTK3.
5310 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5311
5312 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5313
5314 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5315 gdk_window_get_screen, gdk_window_get_geometry,
5316 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5317 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5318 (xg_get_pixbuf_from_pixmap): New function.
5319 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5320 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5321 Call xg_get_pixbuf_from_pixmap instead of
5322 gdk_pixbuf_get_from_drawable.
5323 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5324 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5325 (xg_check_special_colors): Use GtkStyleContext and its functions
5326 for HAVE_GTK3.
5327 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5328 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5329 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5330 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5331 Call gtk_widget_get_preferred_size.
0afb4571
J
5332 (xg_frame_resized): gdk_window_get_geometry only takes 5
5333 parameters.
44f230aa
SM
5334 (xg_win_to_widget, xg_event_is_for_menubar):
5335 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5336 (xg_set_widget_bg): New function.
5337 (delete_cb): New function.
895009e1 5338 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5339 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5340 (xg_set_background_color): Call xg_set_widget_bg.
5341 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5342 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5343 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5344 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5345 if ! HAVE_GTK3.
5346 (update_frame_tool_bar): Call gtk_widget_hide.
5347 (xg_initialize): Use GDK_KEY_g.
5348
5349 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5350 if ! HAVE_GTK3
5351 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5352
5353 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5354 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5355 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5356
1c2cc4ef
JB
53572011-03-08 Juanma Barranquero <lekktu@gmail.com>
5358
5359 * w32xfns.c (select_palette): Check success of RealizePalette against
5360 GDI_ERROR, not zero.
5361
33383987 5362See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5363
5364;; Local Variables:
5365;; coding: utf-8
aac0c6e3
MR
5366;; End:
5367
33383987 5368 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5369
5370 This file is part of GNU Emacs.
5371
5372 GNU Emacs is free software: you can redistribute it and/or modify
5373 it under the terms of the GNU General Public License as published by
5374 the Free Software Foundation, either version 3 of the License, or
5375 (at your option) any later version.
5376
5377 GNU Emacs is distributed in the hope that it will be useful,
5378 but WITHOUT ANY WARRANTY; without even the implied warranty of
5379 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5380 GNU General Public License for more details.
5381
5382 You should have received a copy of the GNU General Public License
5383 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.