* xterm.c (x_clear_frame): Reinstate the XClearWindow call.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e7cfd277
JD
12011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2
3 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4
a9b9b7f5
CY
52011-11-21 Chong Yidong <cyd@gnu.org>
6
7 * window.c (Fnext_window, Fprevious_window): Doc fix.
8
b0d15b4f
SM
92011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
10
11 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
12
fe7a3057
JB
132011-11-20 Juanma Barranquero <lekktu@gmail.com>
14
15 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
16
d2999b1a
MR
172011-11-20 Martin Rudalics <rudalics@gmx.at>
18
19 * window.c (Fset_window_combination_limit): Rename argument
20 STATUS to LIMIT.
21 (Vwindow_combination_limit): Remove "status" from doc-string.
22
d5ff9cd0
AS
232011-11-20 Andreas Schwab <schwab@linux-m68k.org>
24
25 * m/ibms390.h: Remove.
26 * m/ibms390x.h: Don't include "ibms390.h".
27
a5bb9bd3
SM
282011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
29
30 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
31 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
32
cd1181db
JB
332011-11-20 Juanma Barranquero <lekktu@gmail.com>
34
35 * casetab.c (Fset_case_table):
36 * charset.c (Fcharset_after): Fix typos.
37
615a3b8d 382011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 39
17e845af
PE
40 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
41 Otherwise, valgrind does not work on some platforms.
42 Problem reported by Andreas Schwab in
6a0bf43d
PE
43 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
44 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
45 is set, removing the need for VIRT_ADDRESS_VARIES.
46 (PURE_P): Use a more-efficient implementation that needs just one
47 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
48 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
49 to 4 (xorl, subq, cmpq, setbe).
50 * alloc.c (pure): Always extern now, since that's the
51 VIRT_ADDR_VARIES behavior.
52 (PURE_POINTER_P): Use a single comparison, not two, for
53 consistency with the new puresize.h.
54 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
55 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
56 Remove VIRT_ADDR_VARIES no longer needed.
57
f8fe6f96
EZ
582011-11-19 Eli Zaretskii <eliz@gnu.org>
59
60 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
61 (erase_phys_cursor, update_window_cursor, show_mouse_face)
62 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
63 behave as if the cursor position were at the window margin.
64
65 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
66 and the cursor position is out of bounds, behave as if the cursor
67 position were at the window margin. (Bug#10075)
68
df05a53c
CY
692011-11-18 Chong Yidong <cyd@gnu.org>
70
71 * window.c (Fwindow_combination_limit): Make first argument
72 non-optional, since it is meaningless for live windows like the
73 selected window.
74
2071918e
DA
752011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
76
77 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
78
b50a28de
SM
792011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
80
81 * intervals.c: Fix grafting over the whole buffer (bug#10071).
82 (graft_intervals_into_buffer): Simplify.
83
015137db
EZ
842011-11-18 Eli Zaretskii <eliz@gnu.org>
85
86 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
87 hash values of the two rows.
88 (copy_row_except_pointers): Preserve the used[] arrays and the
89 hash values of the two rows. (Bug#10035)
68c95424 90 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
91
92 * xdisp.c (row_hash): New function, body extracted from
93 compute_line_metrics.
94 (compute_line_metrics): Call row_hash, instead of computing the
95 hash code inline.
96
97 * dispnew.c (verify_row_hash): Call row_hash for computing the
98 hash code of a row, instead of duplicating code from xdisp.c.
99
100 * dispextern.h (row_hash): Add prototype.
101
a2addb04
TH
1022011-11-18 Tassilo Horn <tassilo@member.fsf.org>
103
104 * frame.c (delete_frame): Don't delete the terminal when the last
105 X frame is closed if emacs is built with GTK toolkit.
106
df85d315
JB
1072011-11-17 Juanma Barranquero <lekktu@gmail.com>
108
109 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
110
a0c2d0ae
MR
1112011-11-17 Martin Rudalics <rudalics@gmx.at>
112
113 * window.c (Vwindow_splits): Rename to
114 Vwindow_combination_resize. Suggested by Juri Linkov.
115 (Fsplit_window_internal): Use Vwindow_combination_resize instead
116 of Vwindow_splits.
117
58179cce
JB
1182011-11-16 Juanma Barranquero <lekktu@gmail.com>
119
7877f373
JB
120 * nsfns.m (Fns_font_name):
121 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 122
b6f67890
MR
1232011-11-16 Martin Rudalics <rudalics@gmx.at>
124
125 * window.h (window): Rename slot "nest" to "combination_limit".
126 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
127 (Fset_window_nest): Rename to Fset_window_combination_limit.
128 (Vwindow_nest): Rename to Vwindow_combination_limit.
129 (recombine_windows, make_parent_window, make_window)
130 (Fsplit_window_internal, saved_window)
131 (Fset_window_configuration, save_window_save): Rename all
132 occurrences of window_nest to window_combination_limit.
133
c7015153
JB
1342011-11-15 Juanma Barranquero <lekktu@gmail.com>
135
136 * image.c (imagemagick_load_image): Fix typo.
137
322ad6ec
EZ
1382011-11-14 Eli Zaretskii <eliz@gnu.org>
139
140 * xdisp.c (display_line): Move the call to
141 highlight_trailing_whitespace before the call to
142 compute_line_metrics, since the latter needs to see the final
143 faces of all the glyphs to compute ROW's hash value. Fixes
144 assertion violations in row_equal_p. (Bug#10035)
145
f067b8ec
JB
1462011-11-14 Juanma Barranquero <lekktu@gmail.com>
147
148 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
149 just return (bug#10044).
150
1e5b2111
EZ
1512011-11-12 Eli Zaretskii <eliz@gnu.org>
152
7ef3cbd5
EZ
153 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
154 with user-defined heap size. Bump the default size of the temacs
155 heap to 27MB, to avoid memory warning when running temacs.
156 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
157
1e5b2111
EZ
158 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
159 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
160 (verify_row_hash) [XASSERTS]: New function.
161 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
162 that the hash value of glyph rows is correct.
1e5b2111 163
89d61221
MR
1642011-11-12 Martin Rudalics <rudalics@gmx.at>
165
166 * window.h (window): Remove splits slot.
167 * window.c (Fwindow_splits, Fset_window_splits): Remove.
168 (Fdelete_other_windows_internal, make_parent_window)
169 (make_window, Fsplit_window_internal, Fdelete_window_internal)
170 (Fset_window_configuration, save_window_save): Don't deal with
171 split status of windows.
172 (saved_window): Remove splits slot.
173 (Vwindow_splits): Rewrite doc-string.
174
97f18cc8
JD
1752011-11-11 Jan Djärv <jan.h.d@swipnet.se>
176
177 * xfns.c (unwind_create_frame):
178 * nsfns.m (unwind_create_frame):
179 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
180 Vframe_list (Bug#9999).
181
22a648b4
DA
1822011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
183
0b381c7e 184 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 185
659afede
KH
1862011-11-11 Kenichi Handa <handa@m17n.org>
187
188 * callproc.c (Fcall_process): Set the member dst_multibyte of
189 process_coding.
190
9ac0394b
KH
1912011-11-11 Johan Bockgård <bojohan@gnu.org>
192
193 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
194 avoid a crash (bug#9496).
195
2fbdc249
CY
1962011-11-09 Chong Yidong <cyd@gnu.org>
197
198 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
199 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
200
ac6b1f81
PE
2012011-11-08 Paul Eggert <eggert@cs.ucla.edu>
202
203 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
204
09db192c
PE
2052011-11-08 Paul Eggert <eggert@cs.ucla.edu>
206
207 Avoid some portability problems by eschewing 'extern inline' functions.
208 The trivial performance wins aren't worth the portability hassles; see
209 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
210 et seq.
211 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
212 (window_box_width, window_box_left, window_box_left_offset)
213 (window_box_right, window_box_right_offset): Undo previous change,
214 by removing the "extern"s.
215 * intervals.c (adjust_intervals_for_insertion)
216 (adjust_intervals_for_deletion): Undo previous change,
217 making these static again.
218 (offset_intervals, temp_set_point_both, temp_set_point)
219 (copy_intervals_to_string): No longer inline.
220 * xdisp.c (window_text_bottom_y, window_box_width)
221 (window_box_height, window_box_left_offset)
222 (window_box_right_offset, window_box_left, window_box_right)
223 (window_box): No longer inline.
224
105216ed
CY
2252011-11-08 Chong Yidong <cyd@gnu.org>
226
227 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
228 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
229 an error if not a live window.
230 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
231 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
232
ae9e237f
JB
2332011-11-07 Juanma Barranquero <lekktu@gmail.com>
234
235 * lisp.h (syms_of_abbrev): Remove declaration.
236 Reported by CHENG Gao <chenggao@royau.me>.
237
c7aa8333
EZ
2382011-11-07 Eli Zaretskii <eliz@gnu.org>
239
240 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
241 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
242 of temacs in GUI mode.
243
be7f5545
MR
2442011-11-07 Martin Rudalics <rudalics@gmx.at>
245
246 * window.h: Declare delete_all_child_windows instead of
247 delete_all_subwindows.
248 * window.c (Fwindow_nest, Fset_window_nest)
249 (Fset_window_new_total, Fset_window_new_normal)
250 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
251 (delete_all_subwindows): Rename to delete_all_child_windows.
252 (Fdelete_other_windows_internal, Fset_window_configuration):
253 Call delete_all_child_windows instead of delete_all_subwindows.
254 * frame.c (delete_frame): Call delete_all_child_windows instead
255 of delete_all_subwindows.
256
ca78dc43
PE
2572011-11-07 Paul Eggert <eggert@cs.ucla.edu>
258
259 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
260 This is also needed for porting to any host where GC_MARK_STACK is
261 not GC_MAKE_GCPROS_NOOPS.
262 (which_symbols): Use it.
263
a0241d01
KH
2642011-11-07 Kenichi Handa <handa@m17n.org>
265
266 * coding.c (coding_set_destination): Check coding->src_pos only
267 when coding->src_object is a buffer (bug#9910).
268
269 * process.c (send_process): Set the member src_multibyte of coding
270 to 0 (bug#9911) when sending a unibyte text.
271
272 * callproc.c (Fcall_process): Set the member src_multibyte of
273 process_coding to 0 (bug#9912).
274
a64bfdfa 2752011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
276
277 * xmenu.c (cleanup_widget_value_tree): New function.
278 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
279 calling free_menubar_widget_value_tree directly (Bug#9830).
280
cb41b32a
PE
2812011-11-06 Paul Eggert <eggert@cs.ucla.edu>
282
283 Fix some portability problems with 'inline'.
284 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
285 (window_box_width, window_box_left, window_box_left_offset)
286 (window_box_right, window_box_right_offset): Declare extern.
287 Otherwise, these inline functions do not conform to C99 and
288 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
289 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
290 * intervals.c (adjust_intervals_for_insertion)
291 (adjust_intervals_for_deletion): Now extern, because otherwise the
292 extern inline functions 'offset_intervals' couldn't refer to it.
293 (static_offset_intervals): Remove.
294 (offset_intervals): Rewrite using the old contents of
295 static_offset_intervals. The old version didn't conform to C99
296 because an extern inline function contained a reference to an
297 identifier with static linkage.
298
b7041366
AS
2992011-11-06 Andreas Schwab <schwab@linux-m68k.org>
300
301 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
302 GC.
303
88a37c4d
EZ
3042011-11-06 Eli Zaretskii <eliz@gnu.org>
305
306 * xdisp.c (init_iterator, reseat_to_string): Don't set the
307 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
308 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
309 return Qleft_to_right.
310
49745b39
CY
3112011-11-06 Chong Yidong <cyd@gnu.org>
312
313 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
314 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
315 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
316 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
317 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
318 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
319 (Fwindow_vscroll): Doc fix.
320 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
321 argument, since it makes no sense to pass a live window and for
322 consistency with window-child.
323
1f05cd82
CS
3242011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
325
326 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
327 support MSVC.
328
22610910
JR
3292011-11-05 Jason Rumney <jasonr@gnu.org>
330
331 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
332 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
333 fonts (Bug#6029).
334 (add_font_entity_to_list): Fix logic errors in mixed boolean and
335 bitwise arithmetic preventing use of unicode-sip and non-truetype
336 opentype fonts.
337
a06776b2
EZ
3382011-11-05 Eli Zaretskii <eliz@gnu.org>
339
3ad924ba
EZ
340 * s/ms-w32.h (fstat, stat, utime): Move redirections to
341 "emacs"-only part.
342
a06776b2
EZ
343 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
344 initialization code to keep similarity to xfns.c after changes
345 from 2011-11-05.
346
c9e7db78
JD
3472011-11-05 Jan Djärv <jan.h.d@swipnet.se>
348
a97f8f3f
JD
349 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
350 (unwind_create_frame): New function (Bug#9943).
351 (Fx_create_frame): Restructure code to be more similar to the one in
352 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
353 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
354 Move terminal->reference_count++ just before making the frame official
355 (Bug#9943).
356
357 * nsterm.m (x_free_frame_resources): New function.
358 (x_destroy_window): Move code to x_free_frame_resources.
359
c9e7db78
JD
360 * xfns.c (unwind_create_frame): Fix comment.
361 (Fx_create_frame, x_create_tip_frame): Move
362 terminal->reference_count++ just before making the frame
363 official. Move initialization of image_cache_refcount and
364 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
365
a6fc3b5c
EZ
3662011-11-05 Eli Zaretskii <eliz@gnu.org>
367
368 Support MSVC build with newer versions of Visual Studio.
369 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
370 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
371 nt/gmake.defs.
372
373 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
374 which are not supported by MSVC.
375 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
376 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
377 bitfields.
378 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
379 types in bitfields.
380 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
381
382 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
383
58179cce 3842011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
385
386 Support MSVC build with newer versions of Visual Studio.
387 * w32.c: Don't include w32api.h for MSVC.
388 (init_environment) [_MSC_VER]: Call sys_access, not _access.
389
390 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
391 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
392 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
393 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
394 e_* cousins.
395 (alloca) [_MSC_VER]: Define to _alloca.
396
397 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
398
399 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
400
a58c13ed
EZ
4012011-11-04 Eli Zaretskii <eliz@gnu.org>
402
403 * xdisp.c (note_mouse_highlight): If either of
404 previous/next-single-property-change returns nil, treat that as
405 the beginning or the end of the buffer. (Bug#9955)
406
fe0b6370
JD
4072011-11-04 Jan Djärv <jan.h.d@swipnet.se>
408
a58c13ed 409 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
410 label is not null (Bug#9951).
411 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
412 may be NULL.
413
89bd5ee1
EZ
4142011-11-04 Eli Zaretskii <eliz@gnu.org>
415
416 * window.c (Fwindow_body_size): Mention in the doc string that the
417 return value is in frame's canonical units. (Bug#9949)
418
84c3edb9
EZ
4192011-11-03 Eli Zaretskii <eliz@gnu.org>
420
4e2fb5c7
EZ
421 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
422
84c3edb9 423 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 424 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 425 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 426
bc17a887
EZ
4272011-11-01 Eli Zaretskii <eliz@gnu.org>
428
429 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
430 Don't stop backward scan on the continuation glyph, even though
431 its CHARPOS is positive.
26b46e51
EZ
432 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
433 cover_string to disp_string.
bc17a887 434
4ee88440
MR
4352011-11-01 Martin Rudalics <rudalics@gmx.at>
436
437 * window.c (temp_output_buffer_show): Don't use
438 Vtemp_buffer_show_specifiers.
439 (Vtemp_buffer_show_specifiers): Remove unused variable.
440
c2ff3c02
EZ
4412011-10-30 Eli Zaretskii <eliz@gnu.org>
442
443 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
444 past the beginning of the current glyph matrix.
445
58179cce 4462011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
447
448 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
449 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
450 HAVE_GTK3 (Bug#9869).
b77a6a7f 451
3b574623
JD
452 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
453 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
454
b77a6a7f
JD
455 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
456
457 * xterm.c: Declare x_handle_net_wm_state to return int.
458 (handle_one_xevent): Check if we are iconified but don't have
459 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
460 (get_current_wm_state): Return non-zero if not hidden,
461 check for _NET_WM_STATE_HIDDEN (Bug#9893).
462 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
463 (x_handle_net_wm_state): Return what get_current_wm_state returns.
464 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
465
196e41e4
PE
4662011-10-29 Paul Eggert <eggert@cs.ucla.edu>
467
468 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
469 so that this new function doesn't get optimized away by a
470 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
471
021f2e1a
AS
4722011-10-29 Andreas Schwab <schwab@linux-m68k.org>
473
474 * frame.h (MOUSE_HL_INFO): Remove excess parens.
475
8b058d44
EZ
4762011-10-29 Eli Zaretskii <eliz@gnu.org>
477
478 Fix the `xbytecode' command.
479 * .gdbinit (xprintbytestr): New command.
b50a28de 480 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
481 (xbytecode): Print the byte-code string as well.
482
4452fb80
EZ
4832011-10-29 Kim Storm <storm@cua.dk>
484
8b058d44
EZ
485 * alloc.c (which_symbols): New function.
486
21b72067
AS
4872011-10-29 Andreas Schwab <schwab@linux-m68k.org>
488
489 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
490 line. (Bug#9903)
491
83ed7b5c
GM
4922011-10-29 Glenn Morris <rgm@gnu.org>
493
494 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
495 Not clear what it was for, and it causes various bugs. (Bug#9839)
496
5a7a728b
EZ
4972011-10-28 Eli Zaretskii <eliz@gnu.org>
498
499 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
500 possible random value that matches one of those tested as
501 condition to clear the mouse face.
502
d3d0842f
CY
5032011-10-28 Chong Yidong <cyd@gnu.org>
504
505 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
506
31b39d13
DN
5072011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
508
509 * window.c (make_window): Initialize phys_cursor_on_p.
510
9aba6043
SM
5112011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
512
513 * lisp.h (struct Lisp_Symbol): Update comments.
514
c20992f4
JB
5152011-10-28 Juanma Barranquero <lekktu@gmail.com>
516
517 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
518
db4f02f2
EZ
5192011-10-28 Eli Zaretskii <eliz@gnu.org>
520
521 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
522 <oslsachem@gmail.com> for helping to debug this.
523
524 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
525 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
526 (g_b_init_get_glyph_outline_w): New static variables.
527 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
528 (GetGlyphOutlineW_Proc): New typedefs.
529 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
530 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
531 New functions.
532 (w32font_open_internal, compute_metrics):
533 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
534 instead of calling the "wide" APIs directly.
535
536 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
537
538 * w32.h (syms_of_w32font): Add prototype.
539
87e68db4
JB
5402011-10-27 Juanma Barranquero <lekktu@gmail.com>
541
542 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
543 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
544 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
545 (Fmove_to_window_line): Doc fix.
546
435c1d67
CY
5472011-10-27 Chong Yidong <cyd@gnu.org>
548
549 * process.c (make_process): Set gnutls_state to NULL.
550
551 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
552 non-NULL, regardless of GNUTLS_INITSTAGE.
553 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
554 an error. Set process slots as soon as we allocate them.
555
556 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
557
9c6c6f49
CY
5582011-10-27 Chong Yidong <cyd@gnu.org>
559
9aba6043
SM
560 * gnutls.c (emacs_gnutls_deinit): New function.
561 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
562 (Fgnutls_deinit, Fgnutls_boot): Use it.
563
564 * process.c (make_process): Initialize GnuTLS credentials to NULL.
565 (deactivate_process): Call emacs_gnutls_deinit.
566
657d08d3
JB
5672011-10-27 Juanma Barranquero <lekktu@gmail.com>
568
569 * image.c (x_create_x_image_and_pixmap):
570 * w32.c (sys_rename, w32_delayed_load):
571 * w32font.c (fill_in_logfont):
572 * w32reg.c (x_get_string_resource): Silence compiler warnings.
573
5430d399
JB
5742011-10-26 Juanma Barranquero <lekktu@gmail.com>
575
576 * w32fns.c (w32_default_color_map): New function,
577 extracted from Fw32_default_color_map.
a7ef684b 578 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 579
fe0055fa
PE
5802011-10-25 Paul Eggert <eggert@cs.ucla.edu>
581
582 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
583
e6346438
SM
5842011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
585
586 * keyboard.c (test_undefined): New function (bug#9751).
587 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
588
e112cc37
ET
5892011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
590
591 * sysdep.c (init_sys_modes): Fix the check for the controlling
592 terminal (Bug#6649).
593
7b5d6677
EZ
5942011-10-20 Eli Zaretskii <eliz@gnu.org>
595
596 * dispextern.h (struct bidi_it): New member next_en_type.
597
598 * bidi.c (bidi_line_init): Initialize the next_en_type member.
599 (bidi_resolve_explicit_1): When next_en_pos is valid for the
600 current character, check also for next_en_type being WEAK_EN.
601 (bidi_resolve_weak): Don't enter the expensive loop if the current
602 position is before next_en_pos. Record the bidi type of the first
603 non-ET, non-BN character we find, in addition to its position.
604 (bidi_level_of_next_char): Invalidate next_en_type when
605 next_en_pos is over-stepped.
606
7da0b018
PE
6072011-10-20 Paul Eggert <eggert@cs.ucla.edu>
608
609 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
610 * editfns.c: Rewrite current-time-zone so that it invokes
611 the equivalent of (format-time-string "%Z") to get the time zone name.
612 This fixes a bug when the time zone name contains characters that
613 need converting from the system time locale to Emacs internal format.
614 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
615 that patch fixed format-time-string to do the conversion, but
616 I forgot to fix current-time-zone.
617 (format_time_string): New function, containing most of
618 what Fformat_time_string used to contain.
619 (Fformat_time_string): Rewrite in terms of format_time_string.
620 This doesn't change this function's behavior.
621 (current-time-zone): Rewrite to use format_time_string.
622 This fixes the bug reported by Michael Schierl in
623 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
624 Jason Rumney's 2007-06-07 change worked around this bug, but
625 didn't fix it.
626 * systime.h (tzname, timezone): Remove no-longer-used declarations.
627
8547b010
EZ
6282011-10-19 Eli Zaretskii <eliz@gnu.org>
629
630 * xdisp.c (start_display): If the character at POS is displayed
631 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
632 (try_window_reusing_current_matrix): If a line ends in a display
633 vector or the next line starts in a display vector, continue
634 redrawing the window even though the character position of
635 start_row was reached.
8547b010
EZ
636 (Bug#9771, part 2)
637
4e948d15
CY
6382011-10-18 Chong Yidong <cyd@gnu.org>
639
640 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
641 with nobreak-char-display too.
642
4787455f
EZ
6432011-10-18 Eli Zaretskii <eliz@gnu.org>
644
645 Fix part 3 of bug#9771.
646 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
647 (bidi_resolve_neutral): Don't enter the expensive loop looking for
648 non-neutral characters if the current character is a paragraph
649 separator (a.k.a. Newline). This avoids running the same
650 expensive loop twice, once when we consume the preceding newline
651 and the other time when the line actually needs to be displayed.
652 Avoid the loop when we see neutrals on the base embedding level
653 following a character whose directionality is the same as the
654 paragraph's. This avoids running the expensive loop when a line
655 ends in a long sequence of neutrals, like control characters.
656 Add assertion against STRONG_AL type. Slightly rearrange code
657 that determines the type of a neutral given the first non-neutral
658 that follows it.
659 (bidi_level_of_next_char): Set next_en_pos to zero when
660 invalidating its info.
661
2c91f553
EZ
6622011-10-17 Eli Zaretskii <eliz@gnu.org>
663
664 * xdisp.c (push_display_prop): Determine whether to record string
665 or buffer position by IT->string, not by IT->method. Allow
666 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
667 (move_it_vertically_backward): Don't look for character position
668 immediately after the newline when in a continuation line.
669 (Bug#9771, part 1)
2c91f553 670
c7b08b0d
MR
6712011-10-15 Martin Rudalics <rudalics@gmx.at>
672
673 * window.c (coordinates_in_window): Rewrite and delabelize
674 vertical border check. (Bug#5357) (Bug#9618)
675
6b02f655
SM
6762011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
677
678 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
679 errors in XSetWindowBorder (bug#9310).
680
81d40c92
DA
6812011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
682
683 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
684 avoid crash when xmalloc overrun checking is enabled.
685
d4172c3b
EZ
6862011-10-13 Eli Zaretskii <eliz@gnu.org>
687
688 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
689 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
690 cursor motion with <left> and <right> arrow keys.
691
692 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
693 some callers set that themselves.
694
b00eea75
EZ
6952011-10-12 Eli Zaretskii <eliz@gnu.org>
696
697 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
698 display string and the previous row comes from the same string and
699 is empty. (Bug#9739) (Bug#9738)
700
8fe012c4
SM
7012011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
702
703 * doc.c (get_doc_string): Encode file name (bug#9735).
704
0074aef2
EZ
7052011-10-12 Eli Zaretskii <eliz@gnu.org>
706
79beb178
EZ
707 * bidi.c (bidi_level_of_next_char):
708 * xdisp.c (get_visually_first_element): Remove old incorrect
709 comments regarding the Unicode Line Separator character.
710
0074aef2
EZ
711 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
712
6e4b3fbe
DA
7132011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
714
715 * alloc.c (Fgc_status): Do not access beyond zombies array
716 boundary if nzombies > MAX_ZOMBIES.
717 * alloc.c (dump_zombies): Add missing format specifier.
718
0324f3af
PE
7192011-10-12 Paul Eggert <eggert@cs.ucla.edu>
720
b5525cac
PE
721 * xdisp.c (set_cursor_from_row): Simplify conditionals,
722 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
723
0324f3af
PE
724 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
725 Some packages use them to denote characters with modifiers.
726
e9b5f888
AS
7272011-10-11 Andreas Schwab <schwab@linux-m68k.org>
728
729 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
730 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
731 matching a pp-number. Rename parameter var to var1.
732
127827c0
SM
7332011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
734
735 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
736
c8fd3bd0
GM
7372011-10-08 Glenn Morris <rgm@gnu.org>
738
739 * callint.c (Fcall_interactively): Give a more explicit error for the
740 'c' case with a non-character input. (Bug#8479)
741
352ec8ff
EZ
7422011-10-08 Eli Zaretskii <eliz@gnu.org>
743
03669ccb
EZ
744 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
745 lines.
7061c986
EZ
746 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
747 lines that are hscrolled on the left.
03669ccb 748
352ec8ff
EZ
749 * dispnew.c (buffer_posn_from_coords): Account for a possible
750 presence of header-line. (Bug#4426)
751
a66cfb1c
SM
7522011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
753
6b02f655
SM
754 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
755 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 756
7c5ee88e
PE
7572011-10-07 Paul Eggert <eggert@cs.ucla.edu>
758
759 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
760 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
761 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
762 this makes Emacs dump core during garbage collection on rare
763 occasions. sizeof is obviously inferior to offsetof here, so
764 stick with offsetof.
765 (GC_POINTER_ALIGNMENT): New macro.
766 (mark_memory): Omit 3rd (offset) arg; caller changed.
767 Don't assume EMACS_INT alignment is the same as pointer alignment.
768
df1bbe5b
SM
7692011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
770
771 * keyboard.c (read_key_sequence_remapped): New var.
772 (read_key_sequence): Compute remapping in the right buffer.
773 (command_loop_1): Use read_key_sequence's remapping directly.
774
51553db6
SM
7752011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
776
32c1fffd
SM
777 * dired.c (file_name_completion): Don't expand file name.
778 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
779 before checking file name handler.
780
51553db6
SM
781 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
782 they've been requested explicitly (bug#9591).
783
b6bd1599 7842011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
785
786 * keymap.c (Fsingle_key_description): Use make_specified_string
787 instead of build_string to build string from push_key_description.
788 (Bug#5193)
789
f701dc2a
PE
7902011-09-30 Paul Eggert <eggert@cs.ucla.edu>
791
4222c55d
PE
792 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
793 This fixes a Y2038 bug on 64-bit hosts.
794 * buffer.c (reset_buffer):
795 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
796 (Fclear_buffer_auto_save_failure):
797 Use 0, not -1, to represent an unset failure time, since time_t
798 might not be signed.
799
f701dc2a
PE
800 Remove dependency on glibc malloc internals.
801 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
802 Move back here from lisp.h, but with their new implementations.
803 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
804 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
805 * charset.c (charset_table_init): New static var.
806 (syms_of_charset): Use it instead of xmalloc. This removes a
807 dependency on glibc malloc internals. See Eli Zaretskii's comment in
808 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
809 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
810 Move back to alloc.c.
811 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
812 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
813
9ceebf39
JD
8142011-09-30 Jan Djärv <jan.h.d@swipnet.se>
815
816 * nsterm.m (windowDidResize): Call x_set_window_size only when
817 ns_in_resize is true. Otherwise set pixelwidth/height and
818 call change_frame_size (Bug#9628).
819
cb993c58
PE
8202011-09-30 Paul Eggert <eggert@cs.ucla.edu>
821
3930c88b
PE
822 Port --enable-checking=all to Fedora 14 x86-64.
823 * charset.c (syms_of_charset): Also account for glibc malloc's
824 internal overhead when calculating the initial malloc maximum.
825
cb993c58
PE
826 Port --enable-checking=all to Fedora 14 x86.
827 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
828 Move to lisp.h.
829 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
830 (overrun_check_realloc, overrun_check_free):
831 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
832 That way, xmalloc returns a properly-aligned pointer even if
833 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
834 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
835 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
836 into account when calculating the initial malloc maximum.
837 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
838 Move here from alloc.c, so that charset.c can use it too.
839 Properly align; the old code wasn't right for common 32-bit hosts
840 when configured with --enable-checking=all.
841 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
842 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
843
31bed486
EZ
8442011-09-29 Eli Zaretskii <eliz@gnu.org>
845
04c70788 846 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
847 use EDOM.
848
fbcaa2f3
EZ
8492011-09-28 Eli Zaretskii <eliz@gnu.org>
850
851 * xdisp.c (compute_display_string_end): If there's no display
852 string at CHARPOS, return -1.
853
854 * bidi.c (bidi_fetch_char): When compute_display_string_end
855 returns a negative value, treat the character as a normal
856 character not covered by a display string. (Bug#9624)
857
a239d4e9
JB
8582011-09-28 Juanma Barranquero <lekktu@gmail.com>
859
860 * lread.c (Fread_from_string): Fix typo in docstring.
861
88652fd5
EZ
8622011-09-27 Eli Zaretskii <eliz@gnu.org>
863
864 * xdisp.c (handle_invisible_prop): If invisible text ends on a
865 newline, reseat the iterator instead of bidi-iterating there one
866 character at a time. (Bug#9610)
32c1fffd
SM
867 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
868 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 869
ed497dd4
AS
8702011-09-27 Andreas Schwab <schwab@linux-m68k.org>
871
872 * lread.c (readevalloop): Use correct code for NBSP.
873 (read1): Likewise. (Bug#9608)
874
b2bf61aa
MA
8752011-09-25 Michael Albinus <michael.albinus@gmx.de>
876
877 * dbusbind.c (Fdbus_register_signal): When service is not
878 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
879
32bbb17c
GM
8802011-09-25 Glenn Morris <rgm@gnu.org>
881
882 * buffer.c (truncate-lines): Doc fix.
883
94e0933e
CY
8842011-09-24 Chong Yidong <cyd@stupidchicken.com>
885
886 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
887 (Fset_window_next_buffers): Doc fix.
888
cddde921
GM
8892011-09-24 Glenn Morris <rgm@gnu.org>
890
891 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
892
1260aef1
PE
8932011-09-24 Paul Eggert <eggert@cs.ucla.edu>
894
25b4bfa0
PE
895 Fix minor problems found by static checking.
896 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
897 * indent.c (Fvertical_motion): Fix == vs = typo.
898
e3cbd34b
EZ
8992011-09-24 Eli Zaretskii <eliz@gnu.org>
900
a66cfb1c
SM
901 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
902 Default value is now t. Doc fix.
6bf7006f 903
e3cbd34b 904 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 905 logic when moving up, not only when moving down. Fix the
e3cbd34b 906 confusing name and values of the it_overshoot_expected variable;
32c1fffd 907 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
908
909 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
910 CHARPOS is covered by a display string which includes newlines.
911 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
912 is covered by a display string with embedded newlines.
913
a3de0cbd
MA
9142011-09-24 Michael Albinus <michael.albinus@gmx.de>
915
916 * dbusbind.c (Fdbus_register_signal): Add match rule to
917 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
918 (Fdbus_register_method, Vdbus_registered_objects_table):
919 Fix docstring.
a3de0cbd 920
b260039d
JM
9212011-09-24 Jim Meyering <meyering@redhat.com>
922
32c1fffd 923 do not ignore write error for any output size
b260039d
JM
924 The previous change was incomplete.
925 While it makes emacs --batch detect the vast majority of stdout
926 write failures, errors were still ignored whenever the output size is
927 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
928 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
929 && echo FAIL: ignored write error
930 FAIL: ignored write error
931 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
932 && echo FAIL: ignored write error
933 FAIL: ignored write error
934 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
935
8eca8a7c
AS
9362011-09-23 Andreas Schwab <schwab@linux-m68k.org>
937
938 * emacs.c (Fkill_emacs): In noninteractive mode exit
939 non-successfully if a write error occurred on stdout. (Bug#9574)
940
3341db62
EZ
9412011-09-21 Eli Zaretskii <eliz@gnu.org>
942
943 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
944 the xassert test.
945
946 * dispextern.h (struct it): Update the comment documenting what
947 can it->OBJECT be.
948
8c203dbf
EZ
9492011-09-20 Eli Zaretskii <eliz@gnu.org>
950
951 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
952 a display string, extend search for cursor position to end of row.
953 (find_row_edges): If the row ends in a newline from a display
954 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
955 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
956 (Fcurrent_bidi_paragraph_direction): Fix search for previous
957 non-empty line. Fixes confusing cursor motion with arrow keys at
958 the beginning of a line that starts with whitespace.
8c203dbf 959
a4824228
LMI
9602011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
961
962 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
963 (bug#9493).
964
33ed493b
CY
9652011-09-18 Chong Yidong <cyd@stupidchicken.com>
966
967 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
968 boolean (Bug#9154).
969
56cd55c8
EZ
9702011-09-18 Eli Zaretskii <eliz@gnu.org>
971
972 * xdisp.c (display_line): Record maximum and minimum buffer
973 positions even if no glyphs were produced (e.g., by a zero-width
974 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
975 buffer positions that will be removed from the glyph row because
976 they don't fit.
c02dcedf
EZ
977 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
978 column is beyond frame width: don't subtract 1 "pixel" when
979 computing width of the stretch.
3e62b7e0
EZ
980 (reseat_at_next_visible_line_start): Undo the change made on
981 2011-09-17 that saved paragraph information and restored it after
982 the call to `reseat'. (Bug#9545)
56cd55c8 983
5ed99d36 9842011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
985
986 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
987 and turn window cursor on if cleared (Bug#9415).
988
5ed99d36 9892011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
990
991 * search.c (boyer_moore): Take unibyte characters from pattern
992 literally. (Bug#9458)
993
9bade7b2
EZ
9942011-09-18 Eli Zaretskii <eliz@gnu.org>
995
996 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
997
e5e9d610
PE
9982011-09-18 Paul Eggert <eggert@cs.ucla.edu>
999
87e4427a
PE
1000 Fix minor problem found by static checking.
1001 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1002 initialized, to pacify gcc -Wuninitialized.
1003
e5e9d610
PE
1004 * fileio.c: Report proper errno when syscall falls.
1005 (Finsert_file_contents): Save and restore errno,
1006 so that report_file_error outputs the correct diagnostic.
1007 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1008
a1674f0b
EZ
10092011-09-18 Eli Zaretskii <eliz@gnu.org>
1010
1011 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1012
fbfb6dd4
EZ
10132011-09-17 Eli Zaretskii <eliz@gnu.org>
1014
1015 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1016 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1017
bb187662
EZ
10182011-09-17 Eli Zaretskii <eliz@gnu.org>
1019
1137e8b8 1020 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1021 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1022
1023 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1024 (bidi_find_paragraph_start): Search back for paragraph beginning
1025 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1026 (bidi_move_to_visually_next): Only trigger paragraph-related
1027 computations when the last character is a newline or at EOB, not
1028 just any NEUTRAL_B. (Bug#9470)
1029
bb187662
EZ
1030 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1031 truncated lines if point is covered by a display string. (Bug#9524)
1032
2e621251
PE
10332011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1036 (cons_to_x_long): New function.
1037 (lisp_data_to_selection_data): Use it. Correct the test for
1038 short-versus-long data; it was negated. Break out of vector
1039 loop, for efficiency, when a long datum is discovered.
1040
91a15bc6
SM
10412011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1042
1043 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1044
b41c3a35
EZ
10452011-09-16 Eli Zaretskii <eliz@gnu.org>
1046
1047 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1048 GCC PR/17406) by declaring this function with external scope.
1049
7812ba2d
PE
10502011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1053 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1054
cf7edc2a
AS
10552011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1056
1057 * editfns.c (Fformat): Correctly handle text properties on "%%".
1058
bd01620e
EZ
10592011-09-15 Eli Zaretskii <eliz@gnu.org>
1060
1061 * xterm.c (x_draw_composite_glyph_string_foreground):
1062 * w32term.c (x_draw_composite_glyph_string_foreground):
1063 * term.c (encode_terminal_code):
1064 * composite.c (composition_update_it, get_composition_id):
1065 * xdisp.c (get_next_display_element)
1066 (fill_composite_glyph_string): Add comments about special meaning
1067 of TAB characters in a composition.
1068
a02719a3
PE
10692011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1070
1071 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1072 This occurs when processing a multibyte format.
1073 Problem reported by Wolfgang Jenker.
a02719a3 1074
72589a3c
JB
10752011-09-15 Johan Bockgård <bojohan@gnu.org>
1076
1077 * xdisp.c (try_cursor_movement): Only check for exact match if
1078 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1079
1c14176c
PE
10802011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1081
1082 Remove unused external symbols.
1083 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1084 * xdisp.c (calc_pixel_width_or_height): Now static.
1085 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1086 * indent.c (check_display_width):
1087 * w32term.c: Fix comment to match code.
1088 * xterm.c, xterm.h (x_catching_errors): Remove.
1089
d2eea5b5
PE
10902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1091
1092 * xselect.c: Use signed conversions more consistently (Bug#9498).
1093 (selection_data_to_lisp_data): Assume incoming selection data are
1094 signed integers, not unsigned. This is to be consistent with
1095 outgoing selection data, which was modified to use signed integers
1096 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1097 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1098 expects long, not unsigned long.
1099
46888499
EZ
11002011-09-14 Eli Zaretskii <eliz@gnu.org>
1101
1102 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1103 computation of loop end. Reported by Johan Bockgård
1104 <bojohan@gnu.org>.
1105
ef8ef9fb
CY
11062011-09-13 Chong Yidong <cyd@stupidchicken.com>
1107
1108 * frame.c (Fother_visible_frames_p): Function deleted.
1109
fa819fed
EZ
11102011-09-12 Eli Zaretskii <eliz@gnu.org>
1111
1112 * indent.c (compute_motion): Process display vector front to back
1113 rather than the other way around. (Bug#2496)
1114
2ba8e008
SM
11152011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1116
1117 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1118
20f53c69
CY
11192011-09-11 Chong Yidong <cyd@stupidchicken.com>
1120
1121 * minibuf.c (Fread_from_minibuffer): Doc fix.
1122
d562d7a4
EZ
11232011-09-11 Eli Zaretskii <eliz@gnu.org>
1124
1125 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1126 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1127
1c4d7f3d
LMI
11282011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1129
1130 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1131 value for non-existent files.
1132
b885bf36
EZ
11332011-09-11 Eli Zaretskii <eliz@gnu.org>
1134
1135 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1136 set its "size" to -1. This will set the modtime_size field of
1137 the corresponding buffer to -1, which is what
1138 verify-visited-file-modtime expects for files that do not exist.
1139 (Bug#9139)
1140
6612f0bf
PE
11412011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1142
1143 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1144 here ...
1145 * lisp.h: ... from here. push_key_description is no longer
1146 defined in keyboard.c, so its declaration should not be in
1147 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1148 logically belongs with push_key_description.
1149
dfb3f755
PE
11502011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 * buffer.h: Include <sys/types.h> instead of <time.h>.
1153 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1154 Problem reported by Herbert J. Skuhra.
1155
3134906c
LMI
11562011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1157
1158 * xml.c (parse_region): Make the parsing work for
1159 non-comment-starting XML files again (bug#9144).
1160
8d903f4e
AS
11612011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1162
1163 * image.c (gif_load): Fix calculation of bottom and right corner.
1164 (Bug#9468)
1165
80ad64f4
EZ
11662011-09-10 Eli Zaretskii <eliz@gnu.org>
1167
1168 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1169 redisplay in small windows.
1170
208a048d
EZ
11712011-09-09 Eli Zaretskii <eliz@gnu.org>
1172
1173 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1174
9b1c252e
MR
11752011-09-08 Martin Rudalics <rudalics@gmx.at>
1176
1177 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1178 Operate on live windows only.
1179
2949f33b
JB
11802011-09-08 Juanma Barranquero <lekktu@gmail.com>
1181
1182 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1183
e08dcafd
EZ
11842011-09-07 Eli Zaretskii <eliz@gnu.org>
1185
1186 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1187 only under bidi iteration.
1188
115b96bd
JD
11892011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1190
1191 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1192
c8199d0f
PE
11932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1194
1195 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1196 Without this fix, the command to link temacs failed due to an
1197 undefined symbol __builtin_isnan. This is because
1198 /usr/include/iso/math_c99.h #defines isnan(x) to
1199 __builtin_isnan(x), but the bundled gcc, which identifies itself
1200 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1201 a __builtin_isnan.
1202 * floatfns.c (isnan): #undef, and then #define to a clone of
1203 what's in data.c.
1204 (Fisnan): Always define, since it's always available now.
1205 (syms_of_floatfns): Always define isnan at the Lisp level.
1206
e39b275c 12072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1208
1209 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1210
b2db44d9 12112011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1212
f4af5137 1213 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1214 The previous code assumed that file offsets (off_t values) fit in
1215 EMACS_INT variables, which is not true on typical 32-bit hosts.
1216 The code messed up by falsely reporting buffer overflow in cases
1217 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1218 when "big" contains more than 2**29 bytes, even though this
1219 inserts just one byte and does not overflow the buffer.
1220 (Finsert_file_contents): Store file offsets as off_t
1221 values, not as EMACS_INT values. Check for overflow when
1222 converting between EMACS_INT and off_t. When checking for
1223 buffer overflow or for overlap, take the offsets into account.
1224 Don't use EMACS_INT for small values where int suffices.
1225 When checking for overlap, fix a typo: ZV was used where
1226 ZV_BYTE was intended.
1227 (Fwrite_region): Don't assume off_t fits into 'long'.
1228 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1229
ecfc0a49
MA
12302011-09-05 Michael Albinus <michael.albinus@gmx.de>
1231
1232 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1233
6511acf2 12342011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1235
0999621a 1236 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1237
1238 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1239 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1240 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1241 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1242 (modify_event_symbol): Do not assume that the length of
1243 name_alist_or_stem is safe to alloca and fits in int.
1244 (Fexecute_extended_command): Likewise for function name and binding.
1245 (Frecursion_depth): Wrap around reliably on integer overflow.
1246 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1247 since some callers pass EMACS_INT values.
1248 (Fsingle_key_description): Don't crash if symbol name contains more
1249 than MAX_ALLOCA bytes.
1250 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1251 (get_minibuffer): Arg is now EMACS_INT, not int.
1252 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1253 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1254 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1255
2be7d702
PE
1256 * dbusbind.c (signature_cat): New function.
1257 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1258 Do not overrun buffer; instead, report string overflow.
1259
9d1df220
PE
1260 * dispnew.c (add_window_display_history): Don't overrun buffer.
1261 Truncate instead; this is OK since it's just a log.
1262
33ef5c64
PE
1263 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1264 even if the time zone offset is outlandishly large.
1265 Don't mishandle offset == INT_MIN.
1266
66c6fdd5
PE
1267 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1268 when creating daemon; the previous buffer-overflow check was incorrect.
1269
d749b01b
PE
1270 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1271 which has the guts of the old verror function.
1272
b5cd1905
PE
1273 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1274 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1275
6e1a67fb
PE
1276 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1277 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1278 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1279 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1280 length of string rather than counting it via multiple sprintfs;
1281 that's simpler and more reliable.
c21721cc
PE
1282 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1283 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1284 sprintf, in case result does not fit in int.
1285
c57b67fc
PE
1286 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1287 (fontset_from_font): Print it.
1288
8a401434
PE
1289 * frame.c (tty_frame_count): Now printmax_t, not int.
1290 (make_terminal_frame, set_term_frame_name): Print it.
1291 (x_report_frame_params): In X, window IDs are unsigned long,
1292 not signed long, so print them as unsigned.
1293 (validate_x_resource_name): Check for implausibly long names,
1294 and don't assume name length fits in 'int'.
1295 (x_get_resource_string): Don't blindly alloca invocation name;
1296 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1297 not fit in int.
1298
6e1a67fb
PE
1299 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1300 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1301 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1302
0df02bf3
PE
1303 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1304 Use esprintf, not sprintf, in case result does not fit in int.
1305
48e30793
PE
1306 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1307 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1308 it as a large positive number.
1309 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1310 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1311
a66ff6d8
PE
1312 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1313 in case result does not fit in int.
1314
aca216ff
PE
1315 * print.c (float_to_string): Detect width overflow more reliably.
1316 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1317 buffer overrun. Don't assume list length fits in 'int'. Treat
1318 print length of 0 as 0, not as infinity; to be consistent with other
1319 uses of print length in this function. Don't overflow print length
1320 index. Don't assume hash table size fits in 'long', or that
1321 vectorlike size fits in 'unsigned long'.
1322
31c286f7
PE
1323 * process.c (make_process): Use printmax_t, not int, to format
1324 process-name gensyms.
1325
55e5faa1
PE
1326 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1327
80f2e268
PE
1328 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1329 to avoid potential buffer overrun.
1330
670741ab
PE
1331 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1332 if X resource line is longer than 512 bytes.
1333
b7163a50
PE
1334 * xfns.c (x_window): Make sprintf buffer a bit bigger
1335 to avoid potential buffer overrun.
1336
ae58ff1f
PE
1337 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1338
c43c8a6a
PE
1339 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1340
3f8236f4
PE
13412011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1342
53e9fe90 1343 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1344 Without these, Emacs silently mishandles large integers sometimes.
1345 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1346 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1347
6511acf2
PE
1348 * xdisp.c (try_window_id): Check Emacs fixnum range before
1349 converting to 'int'.
806add1d 1350
6511acf2 1351 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1352 Check that an Emacs fixnum is in range before assigning it to 'int'.
1353 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1354 values converted from Emacs fixnums.
1355 (Frecenter): Don't wrap around a line count if it is out of 'int'
1356 range; instead, treat it as an extreme value.
1357 (Fset_window_configuration, compare_window_configurations):
1358 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1359
6511acf2
PE
1360 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1361 that can exceed INT_MAX. Check that EMACS_INT value is in range
1362 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1363 (match_limit): Don't assume that a fixnum can fit in 'int'.
1364
6511acf2 1365 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1366 exceed INT_MAX.
1367
6511acf2 1368 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1369 (Fvertical_motion): Don't wrap around LINES values that don't fit
1370 in 'int'. Instead, treat them as extreme values. This is good
1371 enough for windows, which can't have more than INT_MAX lines anyway.
1372
fcb901a7
LMI
13732011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1374
0f2f6b6d
LMI
1375 * Require libxml/parser.h to avoid compilation warning.
1376
fcb901a7
LMI
1377 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1378
1379 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1380 since this reportedly can destroy thread storage.
1381
6e20a0d4
CY
13822011-08-30 Chong Yidong <cyd@stupidchicken.com>
1383
1384 * syntax.c (find_defun_start): Update all cache variables if
1385 exiting early (Bug#9401).
1386
148ae00e
EZ
13872011-08-30 Eli Zaretskii <eliz@gnu.org>
1388
f6cfbd8f
EZ
1389 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1390
148ae00e
EZ
1391 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1392 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1393 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1394
1395 * term.c (tty_append_glyph): New function.
1396 (produce_stretch_glyph): Static function and its prototype deleted.
1397
a66cfb1c
SM
1398 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1399 Add prototypes.
148ae00e 1400
c4a07a4c
PE
14012011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1402
1403 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1404 when checking :margin (Bug#9390).
1405 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1406 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1407 so that the name doesn't mislead. All uses changed.
1408
6bc8cd65
JB
14092011-08-28 Johan Bockgård <bojohan@gnu.org>
1410
1411 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1412 set_tty_hooks.
1413
dca4927e
EZ
14142011-08-27 Eli Zaretskii <eliz@gnu.org>
1415
1416 * xdisp.c (move_it_to): Don't bail out early when reaching
1417 position beyond to_charpos, if we are scanning backwards.
1418 (move_it_vertically_backward): When DY == 0, make sure we get to
1419 the first character in the line after the newline.
1420
f2cad773
PE
14212011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1422
1423 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1424 (ccl_driver): Do not generate an out-of-range pointer.
1425 (Fccl_execute_on_string): Remove unnecessary check for
1426 integer overflow, noted by Stefan Monnier in
1427 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1428 Remove a FIXME that didn't need fixing.
1429 Simplify the newly-introduced buffer reallocation code.
1430
0cae2cdb
JB
14312011-08-27 Juanma Barranquero <lekktu@gmail.com>
1432
1433 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1434
5fc295a4 14352011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1436
70c60eb2 1437 Integer and memory overflow issues (Bug#9196).
726e0ab1 1438
d31850da
PE
1439 * doc.c (get_doc_string): Rework so that
1440 get_doc_string_buffer_size is the actual buffer size, rather than
1441 being 1 less than the actual buffer size; this makes xpalloc more
1442 convenient.
1443
a69fbedb
PE
1444 * image.c (x_allocate_bitmap_record, cache_image):
1445 * xselect.c (Fx_register_dnd_atom):
1446 Simplify previous changes by using xpalloc.
1447
fe5c5d37
PE
1448 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1449 since either will do and ptrdiff_t is convenient with xpalloc.
1450
0065d054
PE
1451 * charset.c (charset_table_size)
1452 (struct charset_sort_data.priority): Now ptrdiff_t.
1453 (charset_compare): Don't overflow if priorities differ greatly.
1454 (Fsort_charsets): Don't assume list length fits in int.
1455 Check for size-calculation overflow when allocating sort data.
1456 (syms_of_charset): Allocate an initial charset table that is
1457 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1458
1459 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1460
1461 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1462 The actual value is always <= INT_MAX, and leaving it unsigned made
1463 overflow checking harder.
1464
1465 * dispextern.h (struct glyph_matrix.rows_allocated)
1466 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1467 with xpalloc. The values are still always <= INT_MAX.
1468
1469 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1470
1471 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1472 (SAFE_NALLOCA): New macro.
1473
1474 * region-cache.c (struct boundary.pos, find_cache_boundary)
1475 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1476 (set_cache_region, invalidate_region_cache)
1477 (revalidate_region_cache, know_region_cache, region_cache_forward)
1478 (region_cache_backward, pp_cache):
1479 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1480 so that ptrdiff_t * can be passed to xpalloc.
1481 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1482 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1483 (pp_cache): Don't assume cache_len fits in int.
1484 * region-cache.h: Adjust extern decls to match.
1485
1486 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1487 EMACS_INT, since either will do, for xpalloc.
1488
1489 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1490 (xnmalloc, xnrealloc, xpalloc): New functions.
1491
726e0ab1
PE
1492 * bidi.c (bidi_shelve_header_size): New constant.
1493 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1494 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1495
51f30bc5 1496 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1497 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1498 (overlay_strings):
1499 Don't update size of array until after memory allocation succeeds,
1500 because xmalloc/xrealloc may not return.
0065d054
PE
1501 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1502 now that we have proper integer overflow checking.
1503 (record_overlay_string, overlay_strings): Catch overflows when
1504 calculating size of overlay_str_buf.
726e0ab1 1505
0065d054
PE
1506 * callproc.c (Fcall_process): Check for size overflow when
1507 calculating size of args2.
1508 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1509 Normally we prefer signed values, but sticking with ptrdiff_t would
1510 require adding more-complicated checks.
726e0ab1
PE
1511
1512 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1513 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1514 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1515 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1516
1517 * character.c (Fstring): Check for size-calculation overflow.
1518
1519 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1520 unnecessary integer overflow. Check for size overflow.
1521 (encode_coding_object): Don't update size until xmalloc succeeds.
1522
1523 * composite.c (get_composition_id): Check for overflow in glyph
1524 length calculations.
1525
1526 Integer and memory overflow fixes for display code.
1527 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1528 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1529 (scrolling_window): Check for overflow in size calculations.
1530 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1531 Don't assume glyph table len fits in int.
1532 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1533 (row_table_size): Now ptrdiff_t, not int.
1534 (scrolling_window): Avoid overflow in size calculations.
1535 Don't update size until allocation succeeds.
1536 * fns.c (concat): Check for overflow in size calculations.
1537 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1538 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1539 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1540
1541 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1542 (get_doc_string): Check for size calculation overflow.
1543 Don't update size until allocation succeeds.
1544 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1545 EMACS_INT, where ptrdiff_t will do.
1546 (Fsubstitute_command_keys): Check for string overflow.
1547
1548 * editfns.c (set_time_zone_rule): Don't assume environment length
1549 fits in int.
1550 (message_length): Now ptrdiff_t, not int.
1551 (Fmessage_box): Don't update size until allocation succeeds.
1552 Don't assume message length fits in int.
1553 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1554
0065d054
PE
1555 * emacs.c (main): Do not reallocate argv, since there is a null at
1556 the end that can be overwritten, and this way there's no need to
1557 worry about size-calculation overflow.
1558 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1559
1560 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1561 alloc succeeds.
1562 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1563
1564 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1565 (x_set_scroll_bar_width, x_figure_window_size):
1566 Check for integer overflow.
1567 (x_set_alpha): Do not assume XINT fits in int.
1568
1569 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1570 This is for the members text_lines, text_cols, total_lines, total_cols,
1571 where the system imposes an 'int' limit.
1572
1573 * fringe.c (Fdefine_fringe_bitmap):
1574 Don't update size until alloc works.
1575
1576 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1577 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1578
1579 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1580 Check for size-calculation overflow.
1581 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1582 do, as we prefer signed integers.
1583 (id_to_widget.max_size, id_to_widget.used)
1584 (xg_store_widget_in_map, xg_remove_widget_from_map)
1585 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1586 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1587 Use and return ptrdiff_t, not int.
1588 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1589 * gtkutil.h: Change prototypes to match the above.
1590
1591 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1592 are duplicate now that they've been promoted to lisp.h.
1593 (x_allocate_bitmap_record, x_alloc_image_color)
1594 (make_image_cache, cache_image, xpm_load):
1595 Don't update size until alloc is done.
1596 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1597 (x_detect_edges):
3256efce 1598 Check for size calculation overflow.
726e0ab1
PE
1599 (ct_colors_allocated_max): New constant.
1600 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1601 overflow.
3256efce 1602
726e0ab1
PE
1603 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1604 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1605 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1606 Use ptrdiff_t, not int, to count maps.
1607 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1608 calculations. Don't update size until allocation succeeds.
1609 Redo calculations to avoid overflow.
726e0ab1
PE
1610 * keyboard.h: Change prototypes to match the above.
1611
1612 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1613 to count maps.
1614 (current_minor_maps): Check for size calculation overflow.
1615 * keymap.h: Change prototypes to match the above.
1616
1617 * lread.c (read1, init_obarray): Don't update size until alloc done.
1618
1619 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1620 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1621
726e0ab1
PE
1622 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1623 Now ptrdiff_t, not int.
1624 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1625 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1626
1627 * process.c (Fnetwork_interface_list): Check for overflow
1628 in size calculation.
1629
1630 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1631
1632 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1633 overflow. Don't bother calling xmalloc when xrealloc will do.
1634
1635 * search.c (Freplace_match): Check for size calculation overflow.
1636 (Fset_match_data): Don't assume list lengths fit in 'int'.
1637
1638 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1639 for command line length. Do not attempt to address one before the
1640 beginning of an array, as that's not portable.
1641
1642 * term.c (max_frame_lines): Remove; unused.
1643 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1644 not int.
1645 (encode_terminal_code, calculate_costs): Check for size
1646 calculation overflow.
1647 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1648 table lengths and related sizes. Don't update size until alloc
1649 done. Redo calculations to avoid overflow.
1650 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1651
1652 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1653 subtracting pointers.
1654 (gobble_line): Check for overflow more carefully. Don't update size
1655 until alloc done.
1656
1657 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1658 Don't update size until alloc done.
1659 Redo size calculations to avoid overflow.
1660 Check for size calculation overflow.
0065d054 1661 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1662
1663 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1664 Use ptrdiff_t, not int, for sizes.
1665 (store_mode_line_noprop_char): Don't update size until alloc done.
1666
0065d054
PE
1667 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1668 Use ptrdiff_t, not int, for sizes.
1669 (Finternal_make_lisp_face, cache_face):
1670 Check for size calculation overflow.
1671 (cache_face): Treat size calculation overflows as if they were
1672 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1673
1674 * xfns.c (x_encode_text, x_set_name_internal)
1675 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1676 sizes, since they can exceed INT_MAX in size. Check for size
1677 calculation overflow.
1678
0065d054
PE
1679 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1680 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1681 Don't update size until alloc done.
1682
0065d054 1683 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1684 as sprintf is limited to int lengths.
1d526e2f 1685
252c5ee1
PE
1686 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1687 (X_LONG_MIN): New macros.
864d7ce7
PE
1688 Use them to make the following changes clearer.
1689 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1690 This change doesn't affect the value now, but it may help remind
1691 future maintainers not to raise the value too much later.
1692 (SELECTION_QUANTUM): Remove, replacing with ...
1693 (selection_quantum): ... new function, which avoids overflow.
1694 All uses changed.
1695 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1696 assumption that selection length fits in 'int'.
1697 (x_reply_selection_request, x_handle_selection_request)
1698 (x_get_window_property, receive_incremental_selection)
1699 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1700 (lisp_data_to_selection_data, clean_local_selection_data):
1701 Use ptrdiff_t, not int, to record length of selection.
1702 (x_reply_selection_request, x_get_window_property)
1703 (receive_incremental_selection, x_property_data_to_lisp):
1704 Redo calculations to avoid overflow.
1705 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1706 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1707 something.
1708 (x_get_window_property, receive_incremental_selection)
1709 (lisp_data_to_selection_data, x_property_data_to_lisp):
1710 Check for size-calculation overflow.
1711 (x_get_window_property, receive_incremental_selection)
1712 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1713 Don't store size until memory allocation succeeds.
1714 (x_get_window_property): Plug memory leak on memory exhaustion.
1715 Don't double-block input; malloc is safe here. Don't assume 2**34
1716 - 4 fits in unsigned long. Add an xassert to check
1717 XGetWindowProperty overflow. Be more careful about overflow
1718 calculations, and distinguish size from memory overflow better.
1719 (receive_incremental_selection): When tracing, don't assume
1720 unsigned int is less than INT_MAX.
1721 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1722 harmful) conversions of unsigned short to int.
1723 (lisp_data_to_selection_data): Don't assume that integers
1724 in the range -65535 through -1 fit in an X unsigned short.
1725 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1726 result parameters unless successful. Rely on cons_to_unsigned
1727 to report problems with elements; the old code wasn't right anyway.
1728 (x_check_property_data): Check for int overflow; we cannot use
1729 a wider type due to X limits.
1730 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1731
726e0ab1 1732 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1733
0065d054
PE
1734 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1735 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1736 (x_color_cells): Don't store size until memory allocation succeeds.
1737 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1738 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1739 (x_term_init): Don't assume length fits in int (sprintf is limited
1740 to int size).
bc18e09d 1741
ebfa62c0
PE
1742 Use ptrdiff_t for composition IDs.
1743 * character.c (lisp_string_width):
1744 * composite.c (composition_table_size, n_compositions)
1745 (get_composition_id, composition_gstring_from_id):
1746 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1747 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1748 * window.c (Frecenter):
1749 Use ptrdiff_t, not int, for composition IDs.
1750 * composite.c (get_composition_id): Check for integer overflow.
1751 * composite.h: Adjust prototypes to match the above changes.
1752
d3411f89
PE
1753 Use ptrdiff_t for hash table indexes.
1754 * category.c (hash_get_category_set):
1755 * ccl.c (ccl_driver):
1756 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1757 * coding.c (coding_system_charset_list, detect_coding_system):
1758 * coding.h (struct coding_system.id):
1759 * composite.c (get_composition_id, gstring_lookup_cache):
1760 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1761 * image.c (xpm_get_color_table_h):
1762 * lisp.h (hash_lookup, hash_put):
1763 * minibuf.c (Ftest_completion):
1764 Use ptrdiff_t for hash table indexes, not int (which is too
1765 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1766 32-bit --with-wide-int hosts).
1767
e097a6fa
PE
1768 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1769 Add a FIXME comment about memory leaks.
1770 (syms_of_charset): Don't assume xmalloc returns.
1771
5637687f
PE
1772 Don't assume that stated character widths fit in int.
1773 * character.c (Fchar_width, c_string_width, lisp_string_width):
1774 * character.h (CHAR_WIDTH):
1775 * indent.c (MULTIBYTE_BYTES_WIDTH):
1776 Use sanitize_char_width to avoid undefined and/or bad behavior
1777 with outlandish widths.
a66cfb1c 1778 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1779 now that we have two such functions. All uses changed.
1780 (sanitize_char_width): New inline function.
1781
a2271ba2
PE
1782 Don't assume that tab-width fits in int.
1783 * character.h (sanitize_width): New inline function.
1784 (SANE_TAB_WIDTH): New macro.
1785 (ASCII_CHAR_WIDTH): Use it.
1786 * indent.c (sane_tab_width): Remove. All uses replaced by
1787 SANE_TAB_WIDTH (current_buffer).
1788 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1789
18c52557
PE
1790 * fileio.c: Integer overflow issues with file modes.
1791 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1792
caeeedc1
PE
1793 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1794 Remove unreachable code.
1795 (read_hex, load_charset_map_from_file): Check for integer overflow.
1796
50849c52
PE
1797 * xterm.c: don't go over XClientMessageEvent limit
1798 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1799 (x_send_scroll_bar_event): Likewise. Check that the size does not
1800 exceed limits imposed by XClientMessageEvent, as well as the usual
1801 ptrdiff_t and size_t limits.
1802
b13995db
PE
1803 * keyboard.c: Overflow, signedness and related fixes.
1804 (make_lispy_movement): Use same integer type in forward decl
1805 that is used in the definition.
1806 (read_key_sequence, keyremap_step):
1807 Change bufsize argument back to int, undoing my 2011-03-30 change.
1808 We prefer signed types, and int is wide enough here.
1809 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1810 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1811 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1812 length, not size_t. Use ptrdiff_t for index, not int.
1813 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1814 possibility of integer overflow.
1815
13464394
PE
1816 Overflow, signedness and related fixes for images.
1817
1818 * dispextern.h (struct it.stack[0].u.image.image_id)
1819 (struct_it.image_id, struct image.id, struct image_cache.size)
1820 (struct image_cache.used, struct image_cache.ref_count):
1821 * gtkutil.c (update_frame_tool_bar):
1822 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1823 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1824 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1825 * nsmenu.m (update_frame_tool_bar):
1826 * xdisp.c (calc_pixel_width_or_height):
1827 * xfns.c (image_cache_refcount):
1828 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1829 on typical 64-bit hosts.
1830
1831 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1832 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1833 Omit unnecessary casts to int.
1834 (parse_image_spec): Check that integers fall into 'int' range
1835 when the callers expect that.
1836 (image_ascent): Redo ascent calculation to avoid int overflow.
1837 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1838 (lookup_image): Remove unnecessary tests.
1839 (xbm_image_p): Locals are now of int, not EMACS_INT,
1840 since parse_image_check makes sure they fit into int.
1841 (png_load, gif_load, svg_load_image):
1842 Prefer int to unsigned where either will do.
1843 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1844 old tiff_error_handler and tiff_warning_handler.
1845 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1846 stack buffer overflows. It uses only the features of vsnprintf
1847 that are common to both POSIX and native Microsoft.
1848 (tiff_error_handler, tiff_warning_handler): Use it.
1849 (tiff_load, gif_load, imagemagick_load_image):
1850 Don't assume :index value fits in 'int'.
1851 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1852 (imagemagick_load_image): Check that crop parameters fit into
1853 the integer types that MagickCropImage accepts. Don't assume
1854 Vimagemagick_render_type has a nonnegative value. Don't assume
1855 size_t fits in 'long'.
1856 (gs_load): Use printmax_t to print the widest integers possible.
1857 Check for integer overflow when computing image height and width.
1858
c11821d4
EZ
18592011-08-26 Eli Zaretskii <eliz@gnu.org>
1860
1861 * xdisp.c (redisplay_window): Don't force window start if point
1862 will be invisible in the resulting window. (Bug#9324)
1863
0c95fcf7
EZ
18642011-08-25 Eli Zaretskii <eliz@gnu.org>
1865
1866 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1867 the display spec is of the form `(space ...)'.
1868 (handle_display_spec): Return the value returned by
1869 handle_single_display_spec, not just 1 or zero.
1870 (handle_single_display_spec): If the display spec is of the form
1871 `(space ...)', and specifies display in the text area, return 2
1872 rather than 1.
fee65a97 1873 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1874 accurately, and prefer exact match for point under bidi.
1875 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1876
1877 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1878 into disp_prop; all users changed.
1879
1880 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1881 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1882 for the text covered by the display property.
1883
e4ed06f1
CY
18842011-08-25 Chong Yidong <cyd@stupidchicken.com>
1885
1886 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1887 Change return value to nil.
1888 (Frecord_buffer): Delete unused function.
1889
f67cdd7f
EZ
18902011-08-24 Eli Zaretskii <eliz@gnu.org>
1891
5980d4c6
EZ
1892 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1893 buffers, return left-to-right.
8610fe8b
EZ
1894 (set_cursor_from_row): Consider candidate row a win if its glyph
1895 represents a newline and point is on that newline. Fixes cursor
1896 positioning on the newline at EOL of R2L text within L2R
1897 paragraph, and vice versa.
1898 (try_cursor_movement): Check continued rows, in addition to
1899 continuation rows. Fixes unwarranted scroll when point enters a
1900 continued line of R2L text within an L2R paragraph, or vice versa.
1901 (cursor_row_p): Consider the case of point being equal to
1902 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1903 from the end of a short line to the beginning of a continued line
1904 of R2L text within L2R paragraph.
1905 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1906 composed characters.
5980d4c6 1907
f67cdd7f
EZ
1908 * bidi.c (bidi_check_type): Use xassert.
1909 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1910 members.
1911
bca633fb
EZ
19122011-08-23 Eli Zaretskii <eliz@gnu.org>
1913
1914 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1915 a character.
1916
4a5885a7
CY
19172011-08-23 Chong Yidong <cyd@stupidchicken.com>
1918
1919 * nsfont.m (ns_otf_to_script): Fix typo.
1920
0902a04e
KH
19212011-08-22 Kenichi Handa <handa@m17n.org>
1922
1923 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1924 extra slot even if the purpose is char-code-property-table.
1925
1a2e6670
EZ
19262011-08-23 Eli Zaretskii <eliz@gnu.org>
1927
8ddde651
EZ
1928 * xdisp.c (redisplay_window): When computing centering_position,
1929 account for the height of the header line. (Bug#8874)
1930
425cc014
EZ
1931 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1932 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1933 candidate is selected by the mouse, and that candidate has a
1934 composed character under the mouse.
1935
1a2e6670
EZ
1936 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1937 coordinates reported by pos-visible-in-window-p for a composed
1938 character in column zero.
1939
8b76d6f8
SM
19402011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1941
1942 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1943
dac347dd
EZ
19442011-08-22 Eli Zaretskii <eliz@gnu.org>
1945
1946 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1947 consider it a hit if to_charpos is anywhere in the range of the
1948 composed buffer positions.
1949
e013fb34
CY
19502011-08-22 Chong Yidong <cyd@stupidchicken.com>
1951
1952 * image.c (gif_load): Don't assume that each subimage has the same
1953 dimensions as the base image. Handle disposal method that is
1954 "undefined" by the gif spec (Bug#9335).
1955
bd1ba3e8
CY
19562011-08-20 Chong Yidong <cyd@stupidchicken.com>
1957
1958 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1959 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1960
54a1215b
EZ
19612011-08-19 Eli Zaretskii <eliz@gnu.org>
1962
823564e5
EZ
1963 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1964 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1965 from an Org mode buffer to a Speedbar frame.
1966
54a1215b
EZ
1967 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1968 a composition, take its buffer position from IT->cmp_it.charpos.
1969 Fixes cursor positioning at the beginning of a line that begins
1970 with a composed character.
1971
9778ebcc
EZ
19722011-08-18 Eli Zaretskii <eliz@gnu.org>
1973
0be6ee06
EZ
1974 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1975 character bidirectional type, use STRONG_L instead. Fixes crashes
1976 in a buffer produced by `describe-categories'.
1977
9778ebcc
EZ
1978 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1979 members before the level stack, so they would be saved and
1980 restored when copying iterator state. Fixes incorrect reordering
1981 around TABs covered by display properties.
1982
156bffbe
AS
19832011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1984
6b02f655 1985 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1986
72ad093b
CY
19872011-08-17 Chong Yidong <cyd@stupidchicken.com>
1988
1989 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1990 (internal_condition_case_2, internal_condition_case_n):
1991 Remove unnecessary aborts (Bug#9081).
72ad093b 1992
35774242
EZ
19932011-08-17 Eli Zaretskii <eliz@gnu.org>
1994
1995 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1996 has no `load' handler, try opening the file locally. (Bug#9311)
1997
db76dd85
KB
19982011-08-16 Ken Brown <kbrown@cornell.edu>
1999
2000 * gmalloc.c: Expand comment.
2001
b215eee5
EZ
20022011-08-16 Eli Zaretskii <eliz@gnu.org>
2003
2004 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2005 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2006
a4579d33
KB
20072011-08-16 Ken Brown <kbrown@cornell.edu>
2008
2009 Fix memory allocation problems in Cygwin build (Bug#9273).
2010
2011 * unexcw.c ( __malloc_initialized): Declare external variable.
2012 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2013
8b76d6f8
SM
2014 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2015 New variables.
a4579d33
KB
2016 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2017 dumped emacs.
2018 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2019 in the static heap.
2020 [CYGWIN] (special_realloc): New function.
2021 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2022 requests to realloc storage in the static heap.
2023
3ebec551
PE
20242011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2025
2026 * bidi.c (bidi_initialize): Remove unused local.
2027
9fd8be00
EZ
20282011-08-15 Eli Zaretskii <eliz@gnu.org>
2029
6b02f655
SM
2030 * bidimirror.h:
2031 * biditype.h: Remove file.
2032 * makefile.w32-in ($(BLD)/bidi.$(O)):
2033 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2034
2035 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2036
2037 * chartab.c: Improve commentary for the uniprop_table API.
2038
32413314
EZ
2039 * bidi.c (bidi_paragraph_init): Support zero value of
2040 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2041 (bidi_initialize): Use uniprop_table instead of including
2042 biditype.h and bidimirror.h.
32413314 2043
9fd8be00
EZ
2044 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2045 coordinates of the iterator when restoring from ppos_it.
2046 (Bug#9296)
2047
5cf2b69b
KH
20482011-08-14 Kenichi Handa <handa@m17n.org>
2049
2050 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2051 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2052
daf17d00
EZ
20532011-08-14 Eli Zaretskii <eliz@gnu.org>
2054
2055 * xdisp.c (move_it_in_display_line_to): Don't invoke
2056 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2057 ppos_it. Fixes vertical cursor motion when line beginning is
2058 covered by an image. (Bug#9296)
2059
08e3161a
JD
20602011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2061
2062 * nsterm.h (ns_run_ascript): Declare.
2063 (NSAPP_DATA2_RUNASSCRIPT): Define.
2064
2065 * nsfns.m (as_script, as_result, as_status): New static variables.
2066 (ns_run_ascript): New function.
5e617bc2 2067 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2068 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2069 the event loop. Get status from as_status (Bug#7276).
2070
2071 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2072 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2073 the event loop (Bug#7276).
2074
a3720aa2
AS
20752011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2076
2077 * gnutls.c (QCgnutls_bootprop_priority)
2078 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2079 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2080 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2081 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2082 (QCgnutls_bootprop_verify_hostname_error)
2083 (QCgnutls_bootprop_callbacks_verify): Rename from
2084 Qgnutls_bootprop_..., all uses changed.
2085
2086 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2087 uses changed.
2088
0a0d27fb
PE
20892011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2090
19d5c50c
PE
2091 * xfaces.c (Qframe_set_background_mode): Now static.
2092 * dispextern.h (Qframe_set_background_mode): Remove decl.
2093
0a0d27fb
PE
2094 * process.c (Fnetwork_interface_info): Declare local only if needed.
2095
377538cb
JD
20962011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2097
2098 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2099 (Fnetwork_interface_list): Allocate in increments of bytes instead
2100 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2101 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2102 sockaddr.
2103 (struct ifflag_def): notrailers is smart on OSX.
2104 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2105 Get hardware address with getifaddrs if available.
2106
08fff70c
EZ
21072011-08-12 Eli Zaretskii <eliz@gnu.org>
2108
2109 * xdisp.c (iterate_out_of_display_property): xassert that
2110 IT->position is set to within IT->object's boundaries. Break from
2111 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2112 when IT->position is set up wrongly due to some bug.
2113 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2114 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2115 entry. Force push_it to save on the stack the current
2116 buffer/string position, to be restored by pop_it. Fix flags in
2117 the iterator structure wrt the object coming from a display
2118 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2119 properties. (Bug#9284)
2120
7be1c708 21212011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2122
7be1c708
CY
2123 * fontset.c (fontset_get_font_group): Add proper type checks.
2124 (Bug#9172)
aac0c6e3 2125
7be1c708 21262011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2127
7be1c708
CY
2128 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2129 and LC_VERSION_MIN_MACOSX.
2130 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2131 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2132
97bb72a6
EZ
21332011-08-08 Eli Zaretskii <eliz@gnu.org>
2134
2135 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2136 no-display-properties-and-no-overlays under bidi display.
2137 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2138 properties and overlays.
97bb72a6 2139
d5617611
CY
21402011-08-08 Chong Yidong <cyd@stupidchicken.com>
2141
37e11a63
CY
2142 * editfns.c (Fset_time_zone_rule): Document relationship with the
2143 setenv function.
2144
d5617611
CY
2145 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2146 the font entity extracted from the cache (Bug#8109).
2147
58872834
CY
21482011-08-07 Chong Yidong <cyd@stupidchicken.com>
2149
2150 * composite.c (autocmp_chars): Don't reset point. That is done by
2151 restore_point_unwind (Bug#5984).
2152
75bfc667
JL
21532011-08-07 Juri Linkov <juri@jurta.org>
2154
2155 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2156 to show the arg `TIME' instead of `TIMEVAL'.
2157
d1410150
EZ
21582011-08-06 Eli Zaretskii <eliz@gnu.org>
2159
2160 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2161 display property strides EOL and includes a newline, as in
2162 longlines-mode. (Bug#9254)
75b771e4
EZ
2163 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2164 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2165
2166 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2167 is non-zero, even if the data buffer is NULL. Fixes a crash in
2168 vertical-motion with longlines-mode. (Bug#9254)
2169
35928349
EZ
21702011-08-05 Eli Zaretskii <eliz@gnu.org>
2171
ec7cc85b
EZ
2172 * bidi.c <bidi_cache_total_alloc>: Now static.
2173 (bidi_initialize): Initialize bidi_cache_total_alloc.
2174
8b76d6f8 2175 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2176 cache. (Bug#9221)
2177
2178 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2179 amount allocated this far in `bidi_cache_total_alloc'.
2180 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2181 non-zero, only free the data buffer without restoring the cache
2182 contents. All callers changed.
2183
2184 * dispextern.h (bidi_unshelve_cache): Update prototype.
2185
2186 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2187 (move_it_in_display_line, move_it_to)
2188 (move_it_vertically_backward, move_it_by_lines): Replace the call
2189 to xfree to an equivalent call to bidi_unshelve_cache.
2190 (move_it_in_display_line_to): Fix logic of returning
412b6358 2191 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2192
e2e2423b
EZ
21932011-08-05 Eli Zaretskii <eliz@gnu.org>
2194
2195 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2196 came from a string character with a `cursor' property. (Bug#9229)
2197
ae9e757a
JD
21982011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2199
2200 * Makefile.in (LIB_PTHREAD): New variable.
2201 (LIBES): Add LIB_PTHREAD (Bug#9216).
2202
2203 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2204 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2205
213bd7f2
AS
22062011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2207
6b02f655 2208 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2209
99aaf75f
JD
22102011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2211
2212 * xterm.c (x_find_topmost_parent): New function.
2213 (x_set_frame_alpha): Find topmost parent window with
2214 x_find_topmost_parent and set the property there also (bug#9181).
2215 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2216
c74e9d86
PE
22172011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2218
2219 * callproc.c (Fcall_process): Avoid vfork clobbering
2220 the local vars buffer, coding_systems, current_dir.
2221
640c8776
SM
22222011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2223
2224 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2225
f26d0e4c
PE
22262011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2227
8a10d76c
PE
2228 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2229 so that it is not optimized away.
2230
f26d0e4c
PE
2231 * xdisp.c (compute_display_string_pos): Remove unused local.
2232
55439c61
EZ
22332011-08-02 Eli Zaretskii <eliz@gnu.org>
2234
2235 Fix slow cursor motion and scrolling in large buffers with
2236 selective display, like Org Mode buffers. (Bug#9218)
2237
2238 * dispextern.h (struct bidi_it): New member disp_prop_p.
2239
2240 * xdisp.c: Remove one-slot cache of display string positions.
2241 (compute_display_string_pos): Accept an additional argument
5e617bc2 2242 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2243 for a display string or property. If found, set DISP_PROP_P
2244 non-zero.
2245
2246 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2247 DISP_PROP_P, and pass it to compute_display_string_pos.
2248 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2249 non-zero. All callers of bidi_fetch_char changed.
2250
fb33fa43
SM
22512011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2252
2253 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2254
b099e063
DM
22552010-12-03 Don March <don@ohspite.net>
2256
2257 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2258 last character M-[char] is translated to ESC [char] (bug#7541).
2259
5cc7f7af
KH
22602011-08-02 Kenichi Handa <handa@m17n.org>
2261
d0fffa3f 2262 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2263
2264 * chartab.c (uniprop_table): Make it non-static.
2265
525d5e6e
EZ
22662011-08-01 Eli Zaretskii <eliz@gnu.org>
2267
2268 * xdisp.c (forward_to_next_line_start): Accept additional argument
2269 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2270 on the newline.
2271 (reseat_at_next_visible_line_start): Use the bidi iterator state
2272 returned by forward_to_next_line_start to restore the state of
2273 it->bidi_it after backing up to previous newline. (Bug#9212)
2274
31011111
AS
22752011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2276
2277 * regex.c (re_comp): Protoize.
2278 (re_exec): Fix return type.
2279 (regexec): Fix type of `ret'. (Bug#9203)
2280
476371c4
PE
22812011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2282
e5d76069
PE
2283 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2284 This is needed if max-image-size is a floating-point number.
2285
9a79b20c
AS
22862011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2287
2288 * print.c (print_object): Print empty symbol as ##.
2289
2290 * lread.c (read1): Read ## as empty symbol.
2291
d8c2fa78
AA
22922011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2293
2294 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2295 setting frame foreground color (Bug#9175).
2296 (x_set_background_color): Likewise.
2297
ffe57a7a
AA
2298 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2299 contents (Bug#9176).
2300 (EmacsTooltip -init): Remove bezels and add shadows to
2301 tooltip windows.
2302
bf3492a5
AA
2303 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2304 or scroll bar (Bug#8470).
2305
d55e9c53
AA
2306 * nsfont.m (nsfont_open): Remove assignment to voffset and
2307 unnecessary vars hshink, expand, hd, full_height, min_height.
2308 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2309
2310 * nsterm.h (nsfont_info): Remove voffset field.
2311
d8c2fa78 23122011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2313
2314 Implement strike-through and overline on NextStep (Bug#8863).
2315
2316 * nsfont.m (nsfont_open): Use underline position provided by font,
2317 instead of hard-coded value of 2.
2318 (nsfont_draw): Call ns_draw_text_decoration instead.
2319
2320 * nsterm.h: Add declaration for ns_draw_text_decoration.
2321
2322 * nsterm.m (ns_draw_text_decoration): New function for drawing
2323 underline, overline, and strike-through.
2324 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2325 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2326 accommodate underlining, etc.
4843aac3 2327
4cc60b9b
EZ
23282011-07-28 Eli Zaretskii <eliz@gnu.org>
2329
bc7ece87
EZ
2330 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2331 default.
4cc60b9b 2332
476371c4
PE
23332011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2334
66606eea
PE
2335 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2336 Without this fix, if a signal arrives just after memory fills up,
2337 'malloc' might be invoked reentrantly.
2338
476371c4
PE
2339 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2340 In other words, assume that every image size is allowed, on non-X
2341 hosts. This assumption is probably wrong, but it lets Emacs compile.
2342
f3fcc40d
AS
23432011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2344
2345 * regex.c (re_iswctype): Convert return values to boolean.
2346
350c992f
EZ
23472011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2348
2349 * xdisp.c (compute_display_string_pos): Don't use cached display
2350 string position if the buffer had its restriction changed.
2351 (Bug#9184)
2352
5266b4bb
PE
23532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2354
2355 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2356
2573a837 23572011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2358
41f55ccd 2359 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2360
39e378da
PE
2361 * bidi.c: Integer size and overflow fixes.
2362 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2363 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2364 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2365 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2366 (bidi_find_other_level_edge):
2367 Use ptrdiff_t instead of EMACS_INT where either will do.
2368 This works better on 32-bit hosts configured --with-wide-int.
2369 (bidi_cache_ensure_space): Check for size-calculation overflow.
2370 Use % rather than repeated addition, for better worst-case speed.
2371 Don't set bidi_cache_size until after xrealloc returns, because it
2372 might not return.
2373 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2374 (bidi_cache_ensure_space): Also check that the bidi cache size
2375 does not exceed that of the largest Lisp string or buffer. See Eli
2376 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2377
5e927815
PE
2378 * alloc.c (__malloc_size_t): Remove.
2379 All uses replaced by size_t. See Andreas Schwab's note
2380 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2381
ca4aa935
PE
2382 * image.c: Improve checking for integer overflow.
2383 (check_image_size): Assume that f is nonnull, since
2384 it is always nonnull in practice. This is one less thing to
2385 worry about when checking for integer overflow later.
2386 (x_check_image_size): New function, which checks for integer
2387 overflow issues inside X.
2388 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2389 This removes the need for a memory_full check.
2390 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2391 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2392 (xbm_read_bitmap_data): Change locals back to 'int', since
2393 their values must fit in 'int'.
2394 (xpm_load_image, png_load, tiff_load):
2395 Invoke x_create_x_image_and_pixmap earlier,
2396 to avoid much needless work if the image is too large.
2397 (tiff_load): Treat overly large images as if
2398 x_create_x_image_and_pixmap failed, not as malloc failures.
2399 (gs_load): Use x_check_image_size.
2400
5f8f9cc2
PE
2401 * gtkutil.c: Omit integer casts.
2402 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2403 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2404
5adf60bc
PE
2405 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2406
c8907a93
PE
2407 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2408 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2409 would wrongly return t on a 64-bit host.
2410
e3c25c68
PE
2411 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2412 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2413 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2414 and therefore cause GCC to emit a bogus diagnostic in some cases.
2415
3f791afe
PE
2416 * image.c: Integer signedness and overflow and related fixes.
2417 This is not an exhaustive set of fixes, but it's time to
2418 record what I've got.
2419 (lookup_pixel_color, check_image_size): Remove redundant decls.
2420 (check_image_size): Don't assume that arbitrary EMACS_INT values
2421 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2422 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2423 (tiff_load, imagemagick_load_image):
2424 Check for overflow in size calculations.
2425 (x_create_x_image_and_pixmap): Remove unnecessary test for
2426 xmalloc returning NULL; that can't happen.
2427 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2428 (xpm_color_bucket): Use better integer hashing function.
2429 (xpm_cache_color): Don't possibly over-allocate memory.
2430 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2431 (gif_memory_source):
2432 Use ptrdiff_t, not int or size_t, to record sizes.
2433 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2434 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2435 either works, as we prefer signed integers.
2436 (tiff_read_from_memory, tiff_write_from_memory):
2437 Return tsize_t, not size_t, since that's what the TIFF API wants.
2438 (tiff_read_from_memory): Don't fail simply because the read would
2439 go past EOF; instead, return a short read.
2440 (tiff_load): Omit no-longer-needed casts.
2441 (Fimagemagick_types): Don't assume size fits into 'int'.
2442
3cc5a532
PE
2443 Improve hashing quality when configured --with-wide-int.
2444 * fns.c (hash_string): New function, taken from sxhash_string.
2445 Do not discard information about ASCII character case; this
2446 discarding is no longer needed.
2447 (sxhash-string): Use it. Change sig to match it. Caller changed.
2448 * lisp.h: Declare it.
2449 * lread.c (hash_string): Remove, since we now use fns.c's version.
2450 The fns.c version returns a wider integer if --with-wide-int is
2451 specified, so this should help the quality of the hashing a bit.
2452
b312a492
PE
2453 * emacs.c: Integer overflow minor fix.
2454 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2455 Define only if GNU_LINUX.
2456 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2457
dfd153ae
PE
2458 * dispnew.c: Integer signedness and overflow fixes.
2459 Remove unnecessary forward decls, that were a maintenance hassle.
2460 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2461 All uses changed.
2462 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2463 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2464 (prepare_desired_row, line_draw_cost):
2465 Use int, not unsigned, where either works.
2466 (save_current_matrix, restore_current_matrix):
2467 Use ptrdiff_t, not size_t, where either works.
2468 (init_display): Check for overflow more accurately, and without
2469 relying on undefined behavior.
2470
a81d11a3
PE
2471 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2472 Remove, replacing with the new symbols in lisp.h. All uses changed.
2473 * fileio.c (make_temp_name):
2474 * filelock.c (lock_file_1, lock_file):
2475 * xdisp.c (message_dolog):
2476 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2477 Use pMd etc. instead.
2478 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2479 replacing the pWIDE etc. symbols removed from editfns.c.
2480
3300e6fd
PE
2481 * keyboard.h (num_input_events): Now uintmax_t.
2482 This is (very slightly) less likely to mess up due to wraparound.
2483 All uses changed.
2484
fd05c7e9
PE
2485 * buffer.c: Integer signedness fixes.
2486 (alloc_buffer_text, enlarge_buffer_text):
2487 Use ptrdiff_t rather than size_t when either will do, as we prefer
2488 signed integers.
2489
903fe15d
PE
2490 * alloc.c: Integer signedness and overflow fixes.
2491 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2492 (__malloc_size_t): Default to size_t, not to int.
2493 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2494 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2495 Prefer ptrdiff_t to size_t when either would do, as we prefer
2496 signed integers.
2497 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2498 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2499 Now const. Initialize with values that are in range even if char
2500 is signed.
2501 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2502 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2503 These functions do the right thing with sizes > 2**32.
2504 (check_depth): Now ptrdiff_t, not int.
2505 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2506 Adjust to new way of storing sizes. Check for size overflow bugs
2507 in rest of code.
2508 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2509 slightly wrong anyway, as it missed one instance of
2510 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2511 (refill_memory_reserve): Omit needless cast to size_t.
2512 (mark_object_loop_halt): Mark as externally visible.
2513
ac82cc6a
PE
2514 * xselect.c: Integer signedness and overflow fixes.
2515 (Fx_register_dnd_atom, x_handle_dnd_message):
2516 Use ptrdiff_t, not size_t, since we prefer signed.
2517 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2518 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2519 x_dnd_atoms_size and x_dnd_atoms_length.
2520
c2d1e36d
PE
2521 * doprnt.c: Prefer signed to unsigned when either works.
2522 * eval.c (verror):
2523 * doprnt.c (doprnt):
2524 * lisp.h (doprnt):
2525 * xdisp.c (vmessage):
2526 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2527 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2528 prefer signed arithmetic to avoid comparison confusion.
2529 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2530 but is a bit tricky.
2531
0e926e56
PE
2532 Assume freestanding C89 headers, string.h, stdlib.h.
2533 * data.c, doprnt.c, floatfns.c, print.c:
2534 Include float.h unconditionally.
2535 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2536 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2537 * regex.c: Likewise for stddef.h, string.h.
2538 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2539 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2540 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2541 (STDC_HEADERS): Remove obsolete defines.
2542 * sysdep.c: Include limits.h unconditionally.
2543
9cfdb3ec
PE
2544 Assume support for memcmp, memcpy, memmove, memset.
2545 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2546 * regex.c (memcmp, memcpy):
2547 Remove; we assume C89 now.
2548
2549 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2550 (__malloc_safe_bcopy): Remove; no longer needed.
2551
cf950e6b 2552 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2553 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2554 well either way, and we prefer signed to unsigned.
2555
dbf38e02
LMI
25562011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2557
2558 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2559 closes the connection while we're reading (bug#9182).
2560
d6f0886c 25612011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2562
d6f0886c
JD
2563 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2564 are specified (Bug#9168).
24e0f6b1 2565
2eb1f9e6
PE
25662011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2567
2568 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2569 Found by GCC static checking and --with-wide-int on a 32-bit host.
2570
22381272 25712011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2572
2573 * xdisp.c (compute_display_string_pos): Fix logic of caching
2574 previous display string position. Initialize cached_prev_pos to
2575 -1. Fixes slow-down at the beginning of a buffer.
2576
f25e39b4
EZ
25772011-07-24 Eli Zaretskii <eliz@gnu.org>
2578
2579 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2580 for attrs[LFACE_FONTSET_INDEX].
2581
04c4b52e
PE
25822011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2583
2584 * xml.c (parse_region): Remove unused local
2585 that was recently introduced.
2586
c1734fbd
EZ
25872011-07-23 Eli Zaretskii <eliz@gnu.org>
2588
be18c5a5
EZ
2589 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2590 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2591
c1734fbd
EZ
2592 * xdisp.c (move_it_in_display_line_to): Record the best matching
2593 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2594 exit if none of the characters scanned was an exact match.
2595 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2596 when exact match is impossible due to invisible text, and the
2597 lines are truncated.
2598
a258d627
JD
25992011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2600
2601 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2602 for OSX >= 10.7.
2603
b6d5a689
EZ
26042011-07-22 Eli Zaretskii <eliz@gnu.org>
2605
0f74f785
EZ
2606 Fix a significant slow-down of cursor motion with C-n, C-p,
2607 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2608 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2609 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2610 (next_element_from_buffer): Call compute_stop_pos_backwards to
2611 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2612 base_level_stop.
2613 (reseat): Don't look for prev_stop, as that could mean a very long
2614 run.
2615 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2616 <cached_disp_overlay_modiff>: Cache for last found display string
2617 position.
551918c1 2618 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2619 about the same buffer in the same area of character positions, and
2620 the buffer wasn't changed since the time the display string
2621 position was cached.
551918c1 2622
b2d0c91a
EZ
26232011-07-22 Eli Zaretskii <eliz@gnu.org>
2624
2625 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2626 is an integer, which is important for empty lines. (Bug#9149)
2627
043604ee
CY
26282011-07-22 Chong Yidong <cyd@stupidchicken.com>
2629
2630 * frame.c (Fmodify_frame_parameters): In tty case, update the
2631 default face if necessary (Bug#4238).
2632
da4adb04
CY
26332011-07-21 Chong Yidong <cyd@stupidchicken.com>
2634
2635 * editfns.c (Fstring_to_char): No need to explain what a character
2636 is in the docstring (Bug#6576).
2637
9abd0532
LMI
26382011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2639
2640 * xml.c (parse_region): Make sure we always return a tree.
2641
36881d16
HK
26422011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2643
2644 * xml.c (parse_region): If a document contains only comments,
2645 return that, too.
2646
1e98674d
LMI
26472011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2648
2649 * xml.c (make_dom): Return comments, too.
2650
590bd467
PE
26512011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2652
2653 Port to OpenBSD.
2654 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2655 and the surrounding thread.
2656 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2657 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2658 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2659 timer goes off.
2660 * s/openbsd.h (BROKEN_SIGIO): Define.
2661 * unexelf.c (unexec) [__OpenBSD__]:
2662 Don't update the .mdebug section of the Alpha COFF symbol table.
2663
f41628b2
LMI
26642011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2665
2666 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2667 (bug#8460).
2668
b59b67c5
PE
26692011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2670
15e3a074
PE
2671 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2672 This fixes some race conditions on the permissions of any newly
2673 created file.
2674
41bed37d
PE
2675 * alloc.c (valid_pointer_p): Use pipe, not open.
2676 This fixes some permissions issues when debugging.
2677
b59b67c5
PE
2678 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2679 If fchown fails to set both uid and gid, try to set just gid,
2680 as that is sometimes allowed. Adjust the file's mode to eliminate
2681 setuid or setgid bits that are inappropriate if fchown fails.
2682
925a6be7
SM
26832011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2684
2685 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2686 to compare Lisp_Objects.
2687 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2688 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2689 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2690
52968808
AS
26912011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2692
0a6a104b
AS
2693 * lread.c (read_integer): Unread even EOF character.
2694 (read1): Likewise. Properly record start position of symbol.
2695
52968808
AS
2696 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2697 symbol character follows.
2698
9e381cdd
PE
26992011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2700
2701 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2702 This works around a problem with the previous change to Fcopy_file.
2703 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2704 and without this change, GCC might complain about discarding
2705 fchown's return value.
2706
b5641435
JB
27072011-07-16 Juanma Barranquero <lekktu@gmail.com>
2708
2709 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2710
a8031457
PE
27112011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2712
2713 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2714
dd889327
LMI
27152011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2716
750c33f7
LMI
2717 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2718 it's used from the C level.
2719
dd889327
LMI
2720 * process.c: Use the same condition for POLL_FOR_INPUT in both
2721 keyboard.c and process.c (bug#1858).
2722
87e86684
LM
27232011-07-09 Lawrence Mitchell <wence@gmx.li>
2724
2725 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2726 (Fgnutls_boot): Use it.
2727
64348f40
AS
27282011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2729
2730 * doc.c (Fsubstitute_command_keys): Revert last change.
2731
1d698799
LMI
27322011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2733
f863868c
LMI
2734 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2735 quotes the next character, and doesn't affect other longer
2736 sequences (bug#8935).
2737
1d698799
LMI
2738 * lread.c (syms_of_lread): Clarify that is isn't only
2739 `eval-buffer' and `eval-defun' that's affected by
2740 `lexical-binding' (bug#8460).
2741
aa4b6df6
EZ
27422011-07-15 Eli Zaretskii <eliz@gnu.org>
2743
2744 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2745 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2746
5d856da6
PE
27472011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2748
ad6042bb
PE
2749 Fix minor problems found by static checking.
2750 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2751 (elsz): Now a signed constant, not a size_t var. We prefer signed
2752 types to unsigned, to avoid integer comparison confusion. Without
2753 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2754 "cannot optimize loop, the loop counter may overflow", a symptom
2755 of the confusion.
f00bbb22 2756 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2757 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2758
6468f31c
LMI
27592011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2760
49080b10
LMI
2761 * search.c (Fre_search_backward): Mention `case-fold-search' in
2762 all the re_search_* functions (bug#8138).
2763
6468f31c
LMI
2764 * keyboard.c (Fopen_dribble_file): Document when the file is
2765 closed (bug#8056).
2766
c965adc5
EZ
27672011-07-14 Eli Zaretskii <eliz@gnu.org>
2768
df9733bf
EZ
2769 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2770 bidi_cache_idx.
2771
0bb23927
EZ
2772 Support bidi reordering of display and overlay strings.
2773 * xdisp.c (compute_display_string_pos)
2774 (compute_display_string_end): Accept additional argument STRING.
2775 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2776 (reseat_to_string): Initialize bidi_it->string.s and
2777 bidi_it->string.schars.
2778 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2779 NULL (avoids a crash in bidi_paragraph_init).
2780 Initialize itb.string.lstring.
0bb23927
EZ
2781 (init_iterator): Call bidi_init_it only of a valid
2782 buffer position was specified. Initialize paragraph_embedding to
2783 L2R.
2784 (reseat_to_string): Initialize the bidi iterator.
2785 (display_string): If we need to ignore text properties of
2786 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2787 original value of -1 will not work with bidi.)
2788 (compute_display_string_pos): First arg is now struct
2789 `text_pos *'; all callers changed. Support display properties on
2790 Lisp strings.
2791 (compute_display_string_end): Support display properties on Lisp
2792 strings.
2793 (init_iterator, reseat_1, reseat_to_string): Initialize the
2794 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2795 when iterating on a string not from display properties).
640c8776
SM
2796 (compute_display_string_pos, compute_display_string_end):
2797 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2798 arrow keys.
2799 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2800 base_level_stop; instead, set base_level_stop to BEGV.
2801 Fixes crashes in vertical-motion.
0bb23927
EZ
2802 (next_element_from_buffer): Improve commentary for when
2803 the iterator is before prev_stop.
2804 (init_iterator): Initialize bidi_p from the default value of
2805 bidi-display-reordering, not from buffer-local value. Use the
2806 buffer-local value only if initializing for buffer iteration.
2807 (handle_invisible_prop): Support invisible properties on strings
2808 that are being bidi-reordered.
2809 (set_iterator_to_next): Support bidi reordering of C strings and
2810 Lisp strings.
2811 (next_element_from_string): Support bidi reordering of Lisp
2812 strings.
2813 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2814 (display_string): Support display of R2L glyph rows.
2815 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2816 (init_iterator): Don't initialize it->bidi_p for strings
2817 here.
2818 (reseat_to_string): Initialize it->bidi_p for strings here.
2819 (next_element_from_string, next_element_from_c_string)
2820 (next_element_from_buffer): Add xassert's for correspondence
2821 between IT's object being iterated and it->bidi_it.string
2822 structure.
2823 (face_before_or_after_it_pos): Support bidi iteration.
2824 (next_element_from_c_string): Handle the case of the first string
2825 character that is not the first one in the visual order.
2826 (get_visually_first_element): New function, refactored from common
2827 parts of next_element_from_buffer, next_element_from_string, and
2828 next_element_from_c_string.
2829 (tool_bar_lines_needed, redisplay_tool_bar)
2830 (display_menu_bar): Force left-to-right direction. Add a FIXME
2831 comment for making that be controlled by a user option.
2832 (push_it, pop_it): Save and restore the state of the
2833 bidi iterator. Save and restore the bidi_p flag.
2834 (pop_it): Iterate out of display property for string iteration as
2835 well.
2836 (iterate_out_of_display_property): Support iteration over strings.
2837 (handle_single_display_spec): Set up it->bidi_it for iteration
2838 over a display string, and call bidi_init_it.
2839 (handle_single_display_spec, next_overlay_string)
2840 (get_overlay_strings_1, push_display_prop): Set up the bidi
2841 iterator for displaying display or overlay strings.
2842 (forward_to_next_line_start): Don't use the shortcut if
2843 bidi-iterating.
2844 (back_to_previous_visible_line_start): If handle_display_prop
2845 pushed the iterator stack, restore the internal state of the bidi
2846 iterator by calling bidi_pop_it same number of times.
2847 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2848 and we are bidi-iterating, don't decrement the iterator position;
2849 instead, set the first_elt flag in the bidi iterator, to produce
2850 the same effect.
2851 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2852 (push_display_prop): xassert that we are iterating a buffer.
2853 (push_it, pop_it): Save and restore paragraph_embedding member.
2854 (handle_single_display_spec, next_overlay_string)
2855 (get_overlay_strings_1, reseat_1, reseat_to_string)
2856 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2857 correctly. Don't assume unibyte strings are not bidi-reordered.
2858 (compute_display_string_pos)
2859 (compute_display_string_end): Fix handling the case of C string.
2860 (push_it, pop_it): Save and restore from_disp_prop_p.
2861 (handle_single_display_spec, push_display_prop): Set the
2862 from_disp_prop_p flag.
2863 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2864 (pop_it): Call iterate_out_of_display_property only if we are
2865 popping after iteration over a string that came from a display
2866 property. Fix a typo in popping stretch info. Add an assertion
2867 for verifying that the iterator position is in sync with the bidi
2868 iterator.
2869 (handle_single_display_spec, get_overlay_strings_1)
2870 (push_display_prop): Fix initialization of paragraph direction for
2871 string when that of the parent object is not yet determined.
2872 (reseat_1): Call bidi_init_it to resync the bidi
2873 iterator with IT's position. (Bug#7616)
2874 (find_row_edges): If ROW->start.pos gives position
2875 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2876 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2877 Reset the from_disp_prop_p flag.
2878 (SAVE_IT, RESTORE_IT): New macros.
2879 (pos_visible_p, face_before_or_after_it_pos)
2880 (back_to_previous_visible_line_start)
2881 (move_it_in_display_line_to, move_it_in_display_line)
2882 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2883 (try_scrolling, redisplay_window, display_line): Use them when
2884 saving a temporary copy of the iterator and restoring it back.
2885 (back_to_previous_visible_line_start, reseat_1)
2886 (init_iterator): Empty the bidi cache "stack".
2887 (move_it_in_display_line_to): If iterator ended up at
2888 EOL, but we never saw any buffer positions smaller than
2889 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2890 motion in bidi-reordered lines.
2891 (move_it_in_display_line_to): Record prev_method and prev_pos
2892 immediately before the call to set_iterator_to_next. Fixes cursor
2893 motion in bidi-reordered lines with stretch glyphs and strings
2894 displayed in margins. (Bug#8133) (Bug#8867)
2895 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2896 TO_CHARPOS.
640c8776
SM
2897 (pos_visible_p): Support positions in bidi-reordered lines.
2898 Save and restore bidi cache.
0bb23927
EZ
2899
2900 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2901 (bidi_paragraph_info): Delete unused struct.
2902 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2903 (bidi_cache_start): New variable.
2904 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2905 to zero.
2906 (bidi_cache_fetch_state, bidi_cache_search)
2907 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2908 (bidi_cache_find, bidi_peek_at_next_level)
2909 (bidi_level_of_next_char, bidi_find_other_level_edge)
2910 (bidi_move_to_visually_next): Compare cache index with
2911 bidi_cache_start rather than with zero.
2912 (bidi_fetch_char): Accept new argument STRING; all callers
2913 changed. Support iteration over a string. Support strings with
2914 display properties. Support unibyte strings. Fix the type of
2915 `len' according to what STRING_CHAR_AND_LENGTH expects.
2916 (bidi_paragraph_init, bidi_resolve_explicit_1)
2917 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2918 (bidi_level_of_next_char, bidi_move_to_visually_next):
2919 Support iteration over a string.
0bb23927
EZ
2920 (bidi_set_sor_type, bidi_resolve_explicit_1)
2921 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2922 can now be zero (for strings); special values 0 and -1 were
2923 changed to -1 and -2, respectively.
2924 (bidi_char_at_pos): New function.
2925 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2926 Call it instead of FETCH_MULTIBYTE_CHAR.
2927 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2928 initialized to valid values.
2929 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2930 values.
2931 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2932 the test for valid cached positions. Fix the logic for looking up
2933 the sentinel state in the cache. GCPRO the Lisp string we are
2934 iterating.
2935 (bidi_push_it, bidi_pop_it): New functions.
2936 (bidi_initialize): Initialize the bidi cache start stack pointer.
2937 (bidi_cache_ensure_space): New function, refactored from part of
2938 bidi_cache_iterator_state. Don't assume the required size is just
2939 one BIDI_CACHE_CHUNK away.
2940 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2941 (bidi_count_bytes, bidi_char_at_pos): New functions.
2942 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2943 always valid if bidi_cache_idx is valid.
2944 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2945 is valid if it's going to be used.
2946 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2947 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2948 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2949 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2950 (bidi_find_other_level_edge, bidi_cache_start_stack):
2951 All variables related to cache indices are now EMACS_INT.
c965adc5 2952
0bb23927
EZ
2953 * dispextern.h (struct bidi_string_data): New structure.
2954 (struct bidi_it): New member `string'. Make flag members be 1-bit
2955 fields, and put them last in the struct.
640c8776
SM
2956 (compute_display_string_pos, compute_display_string_end):
2957 Update prototypes.
0bb23927
EZ
2958 (bidi_push_it, bidi_pop_it): Add prototypes.
2959 (struct iterator_stack_entry): New members bidi_p,
2960 paragraph_embedding, and from_disp_prop_p.
2961 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2962 (bidi_shelve_cache, bidi_unshelve_cache):
2963 Declare prototypes.
0bb23927
EZ
2964
2965 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2966 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2967 and vector-like objects.
2968
2969 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2970 cache around display iteration.
2971
2972 * window.c (Fwindow_end, window_scroll_pixel_based)
2973 (displayed_window_lines, Frecenter): Save and restore the bidi
2974 cache around display iteration.
2975
3bbd2265
LMI
29762011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2977
2978 * editfns.c (Fdelete_region): Clarify the use of the named
2979 parameters (bug#6788).
2980
adc47434
MR
29812011-07-14 Martin Rudalics <rudalics@gmx.at>
2982
2983 * indent.c (Fvertical_motion): Set and restore w->pointm when
2984 saving and restoring the window's buffer (Bug#9006).
2985
837c31f8
LMI
29862011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2987
2988 * editfns.c (Fstring_to_char): Clarify just what is returned
2989 (bug#6576). Text by Eli Zaretskii.
2990
ac389d0c
JB
29912011-07-13 Juanma Barranquero <lekktu@gmail.com>
2992
2993 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2994
0be0ce47
EZ
29952011-07-13 Eli Zaretskii <eliz@gnu.org>
2996
2997 * buffer.c (mmap_find): Fix a typo.
2998
cd18e7e3
JB
29992011-07-13 Johan Bockgård <bojohan@gnu.org>
3000
3001 Fix execution of x selection hooks.
3002 * xselect.c (Qx_lost_selection_functions)
3003 (Qx_sent_selection_functions): New vars.
3004 (syms_of_xselect): DEFSYM them.
3005 (x_handle_selection_request): Pass Qx_sent_selection_functions
3006 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3007 (x_handle_selection_clear,x_clear_frame_selections):
3008 Pass Qx_lost_selection_functions rather than
3009 Vx_lost_selection_functions to Frun_hook_with_args.
3010
47ea7f44
PE
30112011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3012
ac389d0c 3013 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3014 The old code sometimes used this field without initializing it.
3015
47ea7f44
PE
3016 * alloc.c (gc_sweep): Don't read past end of array.
3017 In theory, the old code could also have corrupted Emacs internals,
3018 though it'd be very unlikely.
3019
bc985c87
AS
30202011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3021
3022 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3023 argument. (Bug#4026)
bc985c87 3024
0cf34688
LMI
30252011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3026
b3dadd76
LMI
3027 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3028 key" (bug#4257).
3029
0cf34688
LMI
3030 * window.c (Fset_window_start): Doc fix (bug#4199).
3031 (Fset_window_hscroll): Ditto.
3032
270768cd
PE
30332011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3034
077e3dda 3035 Fix minor new problems caught by GCC 4.6.1.
270768cd 3036 * term.c (init_tty): Remove unused local.
490011a6 3037 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3038 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3039 not used otherwise.
270768cd 3040
b1f58454
CY
30412011-07-12 Chong Yidong <cyd@stupidchicken.com>
3042
3043 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3044
22b9578d
LMI
30452011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3046
6e70ab07
LMI
3047 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3048 are the mini-buffer and the echo area (bug#3320).
3049
22b9578d
LMI
3050 * term.c (init_tty): Remove support for supdup, c10 and perq
3051 terminals, which are no longer supported (bug#1482).
3052
8974cc9f
JB
30532011-07-10 Johan Bockgård <bojohan@gnu.org>
3054
3055 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3056
a560d974
JD
30572011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3058
3059 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3060 for non-popups (Bug#3642).
3061
1dae0f0a
AS
30622011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3063
268c2c36 3064 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3065 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3066 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3067 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3068 * data.c (fmod): Likewise.
3069 * dispnew.c (swap_glyphs_in_rows): Likewise.
3070 * emacs.c (memory_warning_signal): Likewise.
3071 * floatfns.c (float_error): Likewise.
3072 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3073 (otf_open, font_otf_capability, generate_otf_features)
3074 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3075 Likewise.
3076 * image.c (pbm_read_file): Likewise.
3077 * indent.c (string_display_width): Likewise.
3078 * intervals.c (check_for_interval, search_for_interval)
3079 (inc_interval_count, count_intervals, root_interval)
3080 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3081 * lread.c (defalias): Likewise.
268c2c36 3082 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3083 * regex.c (set_image_of_range_1, set_image_of_range)
3084 (regex_grow_registers): Likewise.
3085 * sysdep.c (strerror): Likewise.
3086 * termcap.c (valid_filename_p, tprint, main): Likewise.
3087 * tparam.c (main): Likewise.
3088 * unexhp9k800.c (run_time_remap, save_data_space)
3089 (update_file_ptrs, read_header, write_header, calculate_checksum)
3090 (copy_file, copy_rest, display_header): Likewise.
3091 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3092 Likewise.
3093 * xdisp.c (check_it): Likewise.
3094 * xfaces.c (register_color, unregister_color, unregister_colors):
3095 Likewise.
3096 * xfns.c (print_fontset_result): Likewise.
3097 * xrdb.c (member, fatal, main): Likewise.
3098
99033785
PE
30992011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3100
3101 Fix minor problems found by static checking (Bug#9031).
3102 * chartab.c (char_table_set_range, map_sub_char_table):
3103 Remove unused locals.
3104 (uniprop_table): Now static.
3105 * composite.c (_work_char): Remove unused static var.
3106
9cb2ac56
JB
31072011-07-09 Juanma Barranquero <lekktu@gmail.com>
3108
3109 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3110
f25661f0
JD
31112011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3112
3113 * gtkutil.c (qttip_cb): Remove code without function.
3114
8278c4fe
EZ
31152011-07-09 Eli Zaretskii <eliz@gnu.org>
3116
3117 * w32.c (pthread_sigmask): New stub.
3118
1692ae2d 31192011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3120
8a6ebd58 3121 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3122 sigprocmask is portable only for single-threaded applications, and
3123 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3124 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3125 (LIBES): Use it.
3126 * callproc.c (Fcall_process):
3127 * process.c (create_process):
3128 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3129 Use pthread_sigmask, not sigprocmask.
123403e4 3130
1b854618
JD
31312011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3132
3133 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3134 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3135 wrong (Bug#8591).
3136
3fe4b549
JD
31372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3138
0ce7e563
JD
3139 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3140 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3141 (xg_hide_tooltip): Fix comment.
3142
3fe4b549
JD
3143 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3144 in registerServicesMenuSendTypes.
3145 (validRequestorForSendType): Don't check ns_return_types.
3146
3147 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3148 ns_return_type.
3149
5df75e47
JR
31502011-07-08 Jason Rumney <jasonr@gnu.org>
3151
22610910
JR
3152 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3153 SH_SHOW for hidden windows (Bug#5482).
3154
5df75e47
JR
3155 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3156 frame struct members of non-existent frames (Bug#6284).
3157
699c10bd
JD
31582011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3159
4393663b
JD
3160 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3161 variable firstTime not needed on OSX >= 10.6.
3162 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3163 >= 10.5. Use setKnobProportion, setDoubleValue.
3164
3165 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3166 (MAC_OS_X_VERSION_10_5): Define if not defined.
3167 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3168 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3169 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3170
3171 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3172 cString and lossyCString on OSX >= 10.4
3173
58179cce 3174 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3175 sizeToFit on OSX >= 10.2.
3176
3177 * nsimage.m (allocInitFromFile): Don't use deprecated method
3178 bestRepresentationForDevice on OSX >= 10.6.
3179
3180 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3181 to avoid warning.
3182
3183 * emacs.c: Declare unexec_init_emacs_zone.
3184
a63e0781
JD
3185 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3186
699c10bd
JD
3187 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3188
3189 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3190 on svcsMenu (Bug#8842).
3191
3192 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3193 ns_return_types.
3194 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3195
3196 * nsterm.m (QUTF8_STRING): Declare.
3197 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3198 (validRequestorForSendType): Return type is (id).
3199 Change indexOfObjectIdenticalTo to indexOfObject.
3200 Check if we have local selection before returning self (Bug#8842).
3201 (writeSelectionToPasteboard): Put local selection into paste board
3202 if we have a local selection (Bug#8842).
3203 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3204
3205 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3206 (ns_get_local_selection): Declare.
3207
54e10184
LMI
32082011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3209
9888ff71
LMI
3210 * keymap.c (describe_map_tree): Don't insert a double newline at
3211 the end of the buffer (bug#1169) and return whether we inserted
3212 something.
3213
54e10184
LMI
3214 * callint.c (Fcall_interactively): Change "reading args" to
3215 "providing args" to try to clarify what it does (bug#1010).
3216
15fa4783
KH
32172011-07-07 Kenichi Handa <handa@m17n.org>
3218
3219 * composite.c (composition_compute_stop_pos): Ignore a static
3220 composition starting before CHARPOS (Bug#8915).
3221
3222 * xdisp.c (handle_composition_prop): Likewise.
3223
a8815b00
EZ
32242011-07-07 Eli Zaretskii <eliz@gnu.org>
3225
3226 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3227 (Bug#9015)
3228
ef7b981d 32292011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3230
3231 * character.h (unicode_category_t): New enum type.
3232
3233 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3234 (Qchar_code_property_table): New variable.
3235 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3236 (UNIPROP_COMPRESSED_FORM_P): New macros.
3237 (char_table_ascii): Uncompress the compressed values.
3238 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3239 Uncompress the compressed values.
ac389d0c 3240 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3241 (char_table_ref_and_range): Uncompress the compressed values.
3242 (sub_char_table_set): New arg is_uniprop. Callers changed.
3243 Uncompress the compressed values.
3244 (sub_char_table_set_range): Args changed. Callers changed.
3245 (char_table_set_range): Adjuted for the above change.
3246 (map_sub_char_table): Delete args default_val and parent. Add arg
3247 top. Give decoded values to a Lisp function.
640c8776 3248 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3249 values to a Lisp function. Gcpro more variables.
3250 (uniprop_table_uncompress)
3251 (uniprop_decode_value_run_length): New functions.
3252 (uniprop_decoder, uniprop_decoder_count): New variables.
3253 (uniprop_get_decoder, uniprop_encode_value_character)
3254 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3255 New functions.
3256 (uniprop_encoder, uniprop_encoder_count): New variables.
3257 (uniprop_get_encoder, uniprop_table)
3258 (Funicode_property_table_internal, Fget_unicode_property_internal)
3259 (Fput_unicode_property_internal): New functions.
3260 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3261 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3262 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3263 char-code-property-alist.
3264
640c8776 3265 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3266 Vunicode_category_table.
3267
640c8776 3268 * font.c (font_range): Adjust for the change of
c805dec0
KH
3269 Vunicode_category_table.
3270
76b397fb
DN
32712011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3272
3273 * m/iris4d.h: Remove file, move contents ...
3274 * s/irix6-5.h: ... here.
3275
22b4128e
PE
32762011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3277
3278 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3279 * alloc.c (mark_buffer):
3280 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3281 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3282 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3283 This isn't true in general, and it's particularly not true
3284 if Emacs is configured with --with-wide-int.
3285 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3286 New macros, used in the buffer.c change.
3287
869795d6
JD
32882011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3289
3290 * xsettings.c: Use both GConf and GSettings if both are available.
3291 (store_config_changed_event): Add comment.
3292 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3293 (store_tool_bar_style_changed): New functions.
5e617bc2 3294 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3295 (struct xsettings): Move font inside HAVE_XFT.
3296 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3297 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3298 Move inside HAVE_XFT.
640c8776 3299 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3300 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3301 also.
3302 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3303 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3304 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3305 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3306 (parse_settings): Move check for font inside HAVE_XFT.
3307 (read_settings, apply_xft_settings): Add comment.
3308 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3309 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3310 call store_font_name_changed.
3311 (xft_settings_event): Add comment.
3312 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3313 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3314 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3315 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3316 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3317 (xsettings_get_system_font, xsettings_get_system_normal_font):
3318 Add comment.
869795d6 3319
d8ed26bd
PE
33202011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3321
3322 Random fixes. E.g., (random) never returned negative values.
3323 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3324 subseconds part to the entropy, as that's a bit more random.
3325 Prefer signed to unsigned, since the signedness doesn't matter and
3326 in general we prefer signed. When given a limit, use a
3327 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3328 latter isn't right if USE_2_TAGS_FOR_INTS.
3329 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3330 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3331
cabf1cac
SM
33322011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3333
3334 * textprop.c (text_property_stickiness):
3335 Obey Vtext_property_default_nonsticky.
3336 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3337 * w32fns.c (syms_of_w32fns):
3338 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3339
6e9b2be9
PE
33402011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3343 This is more efficient than Ffile_directory_p and avoids a minor race.
3344
90186c68
LMI
33452011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3346
7c301272
LMI
3347 * buffer.c (Foverlay_put): Say what the return value is
3348 (bug#7835).
3349
c4f2d8d4
LMI
3350 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3351 is a directory before asking whether to use the file name
3352 (bug#7564).
ad637907
LMI
3353 (barf_or_query_if_file_exists): Make the "File is a directory"
3354 error be more correct.
c4f2d8d4 3355
90186c68
LMI
3356 * fns.c (Frequire): Remove the mention of the .gz files, since
3357 that's installation-specific, but keep the mention of
3358 `get-load-suffixes'.
3359
da64016e
PE
33602011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3361
3362 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3363 Report string overflow if the output is too long.
3364
7d47b580
JB
33652011-07-04 Juanma Barranquero <lekktu@gmail.com>
3366
a555cb87
JB
3367 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3368 (syms_of_gnutls): Remove duplicate DEFSYM for
3369 Qgnutls_bootprop_verify_hostname_error, an error for
3370 Qgnutls_bootprop_verify_error (which is no longer used).
3371
7d47b580
JB
3372 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3373 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3374 Also (re)move comments that are misplaced or no longer relevant.
3375
1e49bfab
LMI
33762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3377
3378 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3379
1485f4c0
CY
33802011-07-03 Chong Yidong <cyd@stupidchicken.com>
3381
3382 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3383 and background color parameters if they have been changed.
3384
a9ab721e
LMI
33852011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3386
3387 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3388
cf7cff57
PE
33892011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3390
2e13213d
PE
3391 * xsettings.c (SYSTEM_FONT): Define only when used.
3392 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3393
cf7cff57
PE
3394 * keymap.c (access_keymap_1): Now static.
3395
7a8e04f7
CY
33962011-07-02 Chong Yidong <cyd@stupidchicken.com>
3397
3398 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3399 leave any prefix arg for the up event (Bug#1586).
3400
61352f62
LMI
34012011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3402
69bb1ef7
LMI
3403 * lread.c (syms_of_lread): Mention single symbols defined by
3404 `defvar' or `defconst' (bug#7154).
3405
61352f62 3406 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3407 (Frequire): Mention get-load-suffixes.
61352f62 3408
28545e04
MR
34092011-07-02 Martin Rudalics <rudalics@gmx.at>
3410
3411 * window.h (window): Remove clone_number slot.
3412 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3413 Remove.
3414 (make_parent_window, make_window, saved_window)
3415 (Fset_window_configuration, save_window_save): Don't deal with
3416 clone numbers.
3417 * buffer.c (Qclone_number): Remove declaration.
3418 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3419
3349e122
SM
34202011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3421
3422 Add multiple inheritance to keymaps.
3423 * keymap.c (Fmake_composed_keymap): New function.
3424 (Fset_keymap_parent): Simplify.
3425 (fix_submap_inheritance): Remove.
3426 (access_keymap_1): New function extracted from access_keymap to handle
3427 embedded parents and handle lists of maps.
3428 (access_keymap): Use it.
3429 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3430 (Fcopy_keymap): Handle embedded parents.
3431 (Fcommand_remapping, define_as_prefix): Simplify.
3432 (Fkey_binding): Simplify.
3433 (syms_of_keymap): Move minibuffer-local-completion-map,
3434 minibuffer-local-filename-completion-map,
3435 minibuffer-local-must-match-map, and
3436 minibuffer-local-filename-must-match-map to Elisp.
3437 (syms_of_keymap): Defsubr make-composed-keymap.
3438 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3439 (parse_menu_item): Trivial simplification.
3440
3279eb87
GM
34412011-07-01 Glenn Morris <rgm@gnu.org>
3442
3443 * Makefile.in (SETTINGS_LIBS): Fix typo.
3444
4550efdf
KI
34452011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3446
3447 * coding.c (Fencode_coding_string): Record the last coding system
3448 used, as the function doc string says (bug#8738).
3449
0949d2b6
JD
34502011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3451
3452 * xsettings.c (store_monospaced_changed): Take new font as arg and
3453 check for change against current_mono_font.
3454 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3455 (emacs_settings_constructor, emacs_settings_get_property)
3456 (emacs_settings_set_property, emacs_settings_class_init)
3457 (emacs_settings_init, gsettings_obj): Remove.
3458 (something_changedCB): New function for HAVE_GSETTINGS.
3459 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3460 with value as argument.
3461 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3462 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3463 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3464 "changed".
3465
3466 * xgselect.c: Add defined (HAVE_GSETTINGS).
3467 (xgselect_initialize): Ditto.
3468
3469 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3470 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3471 xg_select.
3472
bbc6b304
PE
34732011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3474
3475 * eval.c (struct backtrace): Simplify and port the data structure.
3476 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3477 signed bit field, as this assumption is not portable and it makes
3478 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3479 "char debug_on_exit : 1" as this is not portable either; instead,
3480 use the portable "unsigned int debug_on_exit : 1". Remove unused
3481 member evalargs. Remove obsolete comments about cc bombing out.
3482
9851bfc5
JD
34832011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3484
51bb811f 3485 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3486 Let HAVE_GSETTINGS override HAVE_GCONF.
3487 (store_monospaced_changed): New function.
3488 (EMACS_SETTINGS): A new type derived from GObject to handle
3489 GSettings notifications.
3490 (emacs_settings_constructor, emacs_settings_get_property)
3491 (emacs_settings_set_property, emacs_settings_class_init):
3492 New functions.
3493 (gsettings_client, gsettings_obj): New variables.
3494 (GSETTINGS_SCHEMA): New define.
3495 (something_changedCB): Call store_monospaced_changed.
3496 (init_gsettings): New function.
3497 (xsettings_initialize): Call init_gsettings.
3498 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3499 to NULL.
3500
640c8776 3501 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3502 GCONF_CFLAGS/LIBS.
3503
5386012d
MR
35042011-06-29 Martin Rudalics <rudalics@gmx.at>
3505
3506 * window.c (resize_root_window, grow_mini_window)
3507 (shrink_mini_window): Rename Qresize_root_window to
3508 Qwindow_resize_root_window and Qresize_root_window_vertically to
3509 Qwindow_resize_root_window_vertically.
3510
f13e0b08
PE
35112011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3512
3513 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3514
94515237
JB
35152011-06-27 Juanma Barranquero <lekktu@gmail.com>
3516
3517 * makefile.w32-in: Redesign dependencies so they reflect more
3518 clearly which files are directly included by each source file,
3519 and not through other includes.
3520
e43b6e43
MR
35212011-06-27 Martin Rudalics <rudalics@gmx.at>
3522
3523 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3524 (sort_overlays, overlay_strings): When an overlay's clone number
3525 matches the window's clone number process the overlay even if
3526 the overlay's window property doesn't match the current window.
3527
d68443dc
MR
3528 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3529 (Fwindow_hchild): Rename to Fwindow_left_child.
3530 (Fwindow_next): Rename to Fwindow_next_sibling.
3531 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3532 (resize_window_check): Rename to window_resize_check.
3533 (resize_window_apply): Rename to window_resize_apply.
3534 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3535 (Fdelete_other_windows_internal, resize_frame_windows)
3536 (Fsplit_window_internal, Fdelete_window_internal)
3537 (grow_mini_window, shrink_mini_window)
3538 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3539
c7e73be5
JD
35402011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3541
3542 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3543 (emacs_fixed_set_min_size): Remove.
3544 (emacs_fixed_new): Take frame as argument.
3545
3546 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3547 (_EmacsFixedPrivate): Remove minwidth/height.
3548 Add struct frame *f.
3549 (emacs_fixed_init): Initialize priv->f.
3550 (get_parent_class, emacs_fixed_set_min_size): Remove.
3551 (emacs_fixed_new): Set priv->f to argument.
3552 (emacs_fixed_get_preferred_width)
3553 (emacs_fixed_get_preferred_height): Use min_width/height from
3554 frames size_hint to set minimum and natural (Bug#8919).
3555 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3556 and use min_width/height from frames size_hint to set
3557 min_width/height (Bug#8919).
3558
3559 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3560 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3561 Fix indentation.
c7e73be5 3562
cf99dcf8
EZ
35632011-06-26 Eli Zaretskii <eliz@gnu.org>
3564
3565 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3566 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3567 called at ZV.
3568
029529ac
CY
35692011-06-26 Chong Yidong <cyd@stupidchicken.com>
3570
3571 * process.c (wait_reading_process_output): Bypass select if
3572 waiting for a cell while ignoring keyboard input, and input is
3573 pending. Suggested by Jan Djärv (Bug#8869).
3574
7a7ef429
PE
35752011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3576
3577 Use gnulib's dup2 module instead of rolling our own.
3578 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3579
11fdef7d 35802011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3581
3582 * dispnew.c (scrolling_window): Before scrolling, turn off a
3583 mouse-highlight in the window being scrolled.
3584
cd3520a4
JB
35852011-06-24 Juanma Barranquero <lekktu@gmail.com>
3586
3587 Move DEFSYM to lisp.h and use everywhere.
3588
3589 * character.h (DEFSYM): Move declaration...
3590 * lisp.h (DEFSYM): ...here.
3591
3592 * gnutls.c:
3593 * minibuf.c:
3594 * w32menu.c:
3595 * w32proc.c:
3596 * w32select.c: Don't include character.h.
3597
3598 * alloc.c (syms_of_alloc):
3599 * buffer.c (syms_of_buffer):
3600 * bytecode.c (syms_of_bytecode):
3601 * callint.c (syms_of_callint):
3602 * casefiddle.c (syms_of_casefiddle):
3603 * casetab.c (init_casetab_once):
3604 * category.c (init_category_once, syms_of_category):
3605 * ccl.c (syms_of_ccl):
3606 * cmds.c (syms_of_cmds):
3607 * composite.c (syms_of_composite):
3608 * dbusbind.c (syms_of_dbusbind):
3609 * dired.c (syms_of_dired):
3610 * dispnew.c (syms_of_display):
3611 * doc.c (syms_of_doc):
3612 * editfns.c (syms_of_editfns):
3613 * emacs.c (syms_of_emacs):
3614 * eval.c (syms_of_eval):
3615 * fileio.c (syms_of_fileio):
3616 * fns.c (syms_of_fns):
3617 * frame.c (syms_of_frame):
3618 * fringe.c (syms_of_fringe):
3619 * insdel.c (syms_of_insdel):
3620 * keymap.c (syms_of_keymap):
3621 * lread.c (init_obarray, syms_of_lread):
3622 * macros.c (syms_of_macros):
3623 * msdos.c (syms_of_msdos):
3624 * print.c (syms_of_print):
3625 * process.c (syms_of_process):
3626 * search.c (syms_of_search):
3627 * sound.c (syms_of_sound):
3628 * syntax.c (init_syntax_once, syms_of_syntax):
3629 * terminal.c (syms_of_terminal):
3630 * textprop.c (syms_of_textprop):
3631 * undo.c (syms_of_undo):
3632 * w32.c (globals_of_w32):
3633 * window.c (syms_of_window):
3634 * xdisp.c (syms_of_xdisp):
3635 * xfaces.c (syms_of_xfaces):
3636 * xfns.c (syms_of_xfns):
3637 * xmenu.c (syms_of_xmenu):
3638 * xsettings.c (syms_of_xsettings):
3639 * xterm.c (syms_of_xterm): Use DEFSYM.
3640
4228cf16
TZ
36412011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3642
cd3520a4 3643 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3644
7fcccf1e
PE
36452011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3646
7efb4e0e
PE
3647 Integer and buffer overflow fixes (Bug#8873).
3648
ff5844ad
PE
3649 * print.c (printchar, strout): Check for string overflow.
3650 (PRINTPREPARE, printchar, strout):
3651 Don't set size unless allocation succeeds.
3652
90532f02
PE
3653 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3654 for sizes. Check for string overflow more accurately.
3655 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3656
6d84508d
PE
3657 * macros.c: Integer and buffer overflow fixes.
3658 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3659 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3660 Use ptrdiff_t, not int, for sizes.
3661 Don't increment bufsize until after realloc succeeds.
3662 Check for size-calculation overflow.
3663 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3664
437b2cb4
PE
3665 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3666
8b9ac8b4
PE
3667 * lread.c: Integer overflow fixes.
3668 (read_integer): Radix is now EMACS_INT, not int,
3669 to improve quality of diagnostics for out-of-range radices.
3670 Calculate buffer size correctly for out-of-range radices.
3671 (read1): Check for integer overflow in radices, and in
3672 read-circle numbers.
82cb60d3
PE
3673 (read_escape): Avoid int overflow.
3674 (Fload, openp, read_buffer_size, read1)
3675 (substitute_object_recurse, read_vector, read_list, map_obarray):
3676 Use ptrdiff_t, not int, for sizes.
3677 (read1): Use EMACS_INT, not int, for sizes.
20270765 3678 Check for size overflow.
8b9ac8b4 3679
7fcccf1e
PE
3680 * image.c (cache_image): Check for size arithmetic overflow.
3681
bfbbd7e7
PE
3682 * lread.c: Integer overflow issues.
3683 (saved_doc_string_size, saved_doc_string_length)
3684 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3685 Now ptrdiff_t, not int.
3686 (read1): Don't assume doc string length fits in int. Check for
3687 out-of-range doc string lengths.
3688 (read_list): Don't assume file position fits in int.
39019e54 3689 (read_escape): Check for hex character overflow.
bfbbd7e7 3690
4e323265
LL
36912011-06-22 Leo Liu <sdl.web@gmail.com>
3692
3693 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3694 Move to minibuffer.el.
3695
85fece3e
PE
36962011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3697
20b84ce9 3698 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3699 The following patches are for when GLYPH_DEBUG && !XASSERT.
3700 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3701 * dispnew.c (flush_stdout):
3702 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3703 Mark as externally visible.
3704 * dispnew.c (check_window_matrix_pointers): Now static.
3705 * dispnew.c (window_to_frame_vpos):
3706 * xfns.c (unwind_create_frame):
3707 * xterm.c (x_check_font): Remove unused local.
3708 * scroll.c (CHECK_BOUNDS):
3709 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3710 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3711 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3712 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3713 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3714 Now static.
3715 (debug_method_add): Use va_list and vsprintf rather than relying
3716 on undefined behavior with wrong number of arguments.
3717 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3718 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3719 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3720 since we're not interested in debugging glyphs with old libraries.
3721 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3722 GCC 4.6.0's static checking.
3723
0766b489
PE
37242011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3725
31fd4b32
PE
3726 Integer overflow and signedness fixes (Bug#8873).
3727 A few related buffer overrun fixes, too.
3728
b79e8648
PE
3729 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3730
0766b489
PE
3731 * dispextern.h (struct face.stipple):
3732 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3733 (x_bitmap_mask, x_allocate_bitmap_record)
3734 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3735 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3736 (x_create_bitmap_from_xpm_data):
3737 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3738 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3739 (.bitmaps_last):
3740 * xfaces.c (load_pixmap):
3741 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3742 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3743 (.bitmaps_last, struct x_output.icon_bitmap):
3744 Use ptrdiff_t, not int, for bitmap indexes.
3745 (x_allocate_bitmap_record): Check for size overflow.
3746 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3747
b081724f
PE
3748 Use ptrdiff_t, not int, for overlay counts.
3749 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3750 * editfns.c (overlays_around, get_pos_property):
3751 * textprop.c (get_char_property_and_overlay):
3752 * xdisp.c (next_overlay_change, note_mouse_highlight):
3753 * xfaces.c (face_at_buffer_position):
21514da7
PE
3754 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3755 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3756 (Fnext_overlay_change, Fprevious_overlay_change)
3757 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3758 Use ptrdiff_t, not int, for sizes.
21514da7 3759 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3760
3de73e5e
PE
3761 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3762
2606c57b
PE
3763 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3764 (x_session_initialize): Do not assume string length fits in int.
3765
aaafe47a
PE
3766 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3767 This is unlikely, but can occur if DPI is outlandish.
3768
2674ddc8 3769 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3770 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3771
28154962
PE
3772 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3773 * xrdb.c (magic_file_p, search_magic_path):
3774 Omit last arg SUFFIX; it was always 0. All callers changed.
3775 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3776
7de51af5
PE
3777 * xfont.c (xfont_match): Avoid need for strlen.
3778
25ed6cc3
PE
3779 * xfns.c: Don't assume strlen fits in int.
3780 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3781
4eab31dd
PE
3782 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3783 not unsigned long, as we prefer signed integers. All callers changed.
3784 Detect integer overflow in repeat count.
3785 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3786 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3787
171e2a58
PE
3788 * termcap.c: Don't assume sizes fit in int and never overflow.
3789 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3790 (gobble_line): Check for size-calculation overflow.
3791
ad39faca 3792 * minibuf.c (Fread_buffer):
6e5bb2dc 3793 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3794 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3795 Don't assume string length fits in int.
3796
52c61c22 3797 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3798 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3799
b5b8c9e5
PE
3800 * font.c: Don't assume string length fits in int.
3801 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3802 Use ptrdiff_t, not int.
ccd6111c
PE
3803 (font_intern_prop): Don't assume string length fits in int.
3804 Don't assume integer property fits in fixnum.
3805 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3806
882f0d81 3807 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3808 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3809 Reformulate so as not to need the command string.
3810 Invoke gzip -cd rather than gunzip, as it's more portable.
3811 (lock_info_type, lock_file_1, lock_file):
3812 Don't assume pid_t and time_t fit in unsigned long.
3813 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3814 (current_lock_owner): Prefer signed type for sizes.
3815 Use memcpy, not strncpy, where memcpy is what is really wanted.
3816 Don't assume (via atoi) that time_t and pid_t fit in int.
3817 Check for time_t and/or pid_t out of range, e.g., via a network share.
3818 Don't alloca where an auto var works fine.
3819
93f4cf88
PE
3820 * fileio.c: Fix some integer overflow issues.
3821 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3822 Don't assume string length fits in int.
3823 (directory_file_name): Don't assume string length fits in long.
3824 (make_temp_name): Don't assume pid fits in int, or that its print
3825 length is less than 20.
3826
f3e92b69
PE
3827 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3828
1bfdaf10
PE
3829 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3830
35016e9a
PE
3831 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3832
3d1e65a1
PE
3833 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3834 We prefer signed integers, even for size calculations.
3835
0b963a93
PE
3836 * emacs.c: Don't assume string length fits in 'int'.
3837 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3838 (main): Don't invoke strlen when not needed.
3839
573f4b54
PE
3840 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3841 (XD_DEBUG_MESSAGE): Don't waste a byte.
3842
989f33ba
PE
3843 * callproc.c (getenv_internal_1, getenv_internal)
3844 (Fgetenv_internal):
965d34eb
PE
3845 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3846
e4d29b33
PE
3847 * lread.c (invalid_syntax): Omit length argument.
3848 All uses changed. This doesn't fix a bug, but it simplifies the
3849 code away from its former Hollerith-constant appearance, and it's
3850 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3851 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3852
eb49b136
PE
3853 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3854 This didn't break anything, but it didn't help either.
3855 It's confusing to put a bogus integer in a place where the actual
3856 value does not matter.
9f62aeb1 3857 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3858 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3859
15375a22
PE
3860 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3861 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3862 implementation.
b61cc01c
PE
3863 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3864 We prefer signed types, and the value cannot exceed the EMACS_INT
3865 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3866 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3867 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3868 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3869
53b2623d
PE
3870 * indent.c (sane_tab_width): New function.
3871 (current_column, scan_for_column, Findent_to, position_indentation)
3872 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3873 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3874
51cab52b 3875 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3876
f2ed8a70
PE
3877 * lisp.h (lint_assume): New macro.
3878 * composite.c (composition_gstring_put_cache):
3879 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3880
abe80cc6
PE
3881 * editfns.c, insdel.c:
3882 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3883
b02c740e
PE
3884 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3885
ebc96716
PE
3886 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3887
b4e50fa0 3888 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3889 Use much-faster test for byte-length change.
311d5d7c 3890 Don't assume string byte-length fits in 'int'.
a4cf38e4 3891 Check that character arg fits in 'int'.
85461888 3892 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3893
c0c1ee9f
PE
3894 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3895
a498d7f4
PE
3896 * fns.c (concat): Catch string overflow earlier.
3897 Do not rely on integer wraparound.
3898
51cab52b
PE
3899 * dispextern.h (struct it.overlay_strings_charpos)
3900 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3901 * xdisp.c (forward_to_next_line_start)
3902 (back_to_previous_visible_line_start)
3903 (reseat_at_next_visible_line_start, next_element_from_buffer):
3904 Don't arbitrarily truncate the value of 'selective' to int.
3905
76031fad
PE
3906 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3907
5eb55db9
PE
3908 * composite.c: Don't truncate sizes to 'int'.
3909 (composition_gstring_p, composition_reseat_it)
3910 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3911 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3912 not EMACS_UINT, for indexes.
5eb55db9 3913
0703a717
PE
3914 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3915
d6202519
PE
3916 * buffer.c: Include <verify.h>.
3917 (struct sortvec.priority, struct sortstr.priority):
8961a454 3918 Now EMACS_INT, not int.
c20998a7 3919 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3920 (struct sortstr.size, record_overlay_string)
3921 (struct sortstrlist.size, struct sortlist.used):
3922 Don't truncate size to int.
3923 (record_overlay_string): Check for size-calculation overflow.
d6202519 3924 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3925
d5a19415
JM
39262011-06-22 Jim Meyering <meyering@redhat.com>
3927
029529ac 3928 Don't leak an XBM-image-sized buffer
d5a19415
JM
3929 * image.c (xbm_load): Free the image buffer after using it.
3930
a9041e6c
PE
39312011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3932
3933 Port to Sun C.
3934 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3935 that Sun C diagnosed.
3936 * fns.c (secure_hash): Fix pointer signedness issue.
3937 * intervals.c (static_offset_intervals): New function.
3938 (offset_intervals): Use it.
3939
7f3f739f
LL
39402011-06-21 Leo Liu <sdl.web@gmail.com>
3941
3942 * deps.mk (fns.o):
3943 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3944 sha512.h.
3945
3946 * fns.c (secure_hash): Rename from crypto_hash_function and change
3947 the first arg to accept symbols.
5b66d427 3948 (Fsecure_hash): New primitive.
7f3f739f
LL
3949 (syms_of_fns): New symbols.
3950
76147d94
DD
39512011-06-20 Deniz Dogan <deniz@dogan.se>
3952
3953 * process.c (Fset_process_buffer): Clarify return value in
3954 docstring.
3955
7d7d0045
CY
39562011-06-18 Chong Yidong <cyd@stupidchicken.com>
3957
3958 * dispnew.c (add_window_display_history): Use BVAR.
3959
3960 * xdisp.c (debug_method_add): Use BVAR.
3961 (check_window_end, dump_glyph_matrix, dump_glyph)
3962 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3963
3964 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3965 Likewise.
3966
3967 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3968 check till after the cache is created in init_frame_faces.
3969
ff2bc410
SM
39702011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3971
3972 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3973
28177add
PE
39742011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3975
dd3482fe
PE
3976 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3977 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3978 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3979
393d71f3 3980 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3981 * fileio.c (Finsert_file_contents):
3982 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3983 Remove the old (too-loose) buffer overflow checks.
3984 They weren't needed, since make_gap checks for buffer overflow.
3985 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3986 The old code merely checked for Emacs fixnum overflow, and relied
3987 on undefined (wraparound) behavior. The new code avoids undefined
3988 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3989
2e6813b0 3990 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3991 Tune. Don't use wider integers than needed. Don't use alloca.
3992 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3993
599a9e4f
PE
3994 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3995
99561444
PE
3996 * insdel.c, lisp.h (buffer_overflow): New function.
3997 (insert_from_buffer_1, replace_range, replace_range_2):
3998 * insdel.c (make_gap_larger):
3999 * editfns.c (Finsert_char):
4000 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4001
28177add
PE
4002 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4003
e69dafad
PE
40042011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4005
a7af7fde 4006 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4007
b1c46f02
PE
4008 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4009 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4010
e69dafad
PE
4011 * fileio.c: Don't assume EMACS_INT fits in off_t.
4012 (emacs_lseek): New static function.
4013 (Finsert_file_contents, Fwrite_region): Use it.
4014 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4015
566684ea
PE
4016 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4017
e6966cd6
PE
4018 * fns.c: Don't overflow int when computing a list length.
4019 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4020 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4021 truncation on 64-bit hosts. Check for QUIT every
4022 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4023 faster and is responsive enough.
4024 (Flength): Report an error instead of overflowing an integer.
4025 (Fsafe_length): Return a float if the value is not representable
4026 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4027 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4028 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4029
dd0b0efb
PE
4030 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4031 (header_size, word_size): New constants.
4032 (allocate_vectorlike): Don't check size overflow here.
4033 (allocate_vector): Check it here instead, since this is the only
4034 caller of allocate_vectorlike that could cause overflow.
4035 Check that the new vector's length is representable as a fixnum.
4036
86fe5cfe
PE
4037 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4038 The previous code was bogus. For example, next_almost_prime (32)
4039 returned 39, which is undesirable as it is a multiple of 3; and
4040 next_almost_prime (24) returned 25, which is a multiple of 5 so
4041 why was the code bothering to check for multiples of 7?
4042
80e88859
PE
4043 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4044
4a2f0ad6
PE
4045 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4046
f66c7cf8
PE
4047 Variadic C functions now count arguments with ptrdiff_t.
4048 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4049 Back then I didn't know that the Emacs coding style prefers signed int.
4050 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4051 were being counted with int, which may truncate counts on 64-bit
4052 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4053 * lisp.h (struct Lisp_Subr.function.aMANY)
4054 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4055 Arg counts are now ptrdiff_t, not size_t.
4056 All variadic functions and their callers changed accordingly.
4057 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4058 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4059 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4060 * callint.c (Fcall_interactively): Check arg count for overflow,
4061 to avoid potential buffer overrun. Use signed char, not 'int',
4062 for 'varies' array, so that we needn't bother to check its size
4063 calculation for overflow.
4064 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4065 * eval.c (apply_lambda):
4066 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4067 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4068 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4069
a1759b76
PE
4070 * callint.c (Fcall_interactively): Don't use index var as event count.
4071
d96be9fc
PE
4072 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4073 * mem-limits.h (SIZE): Remove; no longer used.
4074
a690a978 4075 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4076
578c21e6
PE
4077 Remove unnecessary casts.
4078 * xterm.c (x_term_init):
4079 * xfns.c (x_set_border_pixel):
4080 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4081 These aren't needed now that we assume ANSI C.
4082
96f53c6c
PE
4083 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4084 It's more likely to cause problems (due to unsigned overflow)
4085 than to cure them.
4086
83c77d31
PE
4087 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4088
ee2079f1
PE
4089 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4090
6da65536
PE
4091 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4092
7147c4a4
PE
4093 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4094
193e32d9
PE
4095 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4096
e5533da6
PE
4097 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4098
9910e595
PE
4099 GLYPH_CODE_FACE returns EMACS_INT, not int.
4100 * dispextern.h (merge_faces):
4101 * xfaces.c (merge_faces):
01103c44
PE
4102 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4103 Don't assume EMACS_INT fits in int.
9910e595 4104
2638320e
PE
4105 * character.h (CHAR_VALID_P): Remove unused parameter.
4106 * fontset.c, lisp.h, xdisp.c: All uses changed.
4107
045eb8d9
PE
4108 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4109
c1f134b5
PE
4110 * fns.c (concat): Minor tuning based on overflow analysis.
4111 This doesn't fix any bugs. Use int to hold character, instead
4112 of constantly refetching from Emacs object. Use XFASTINT, not
4113 XINT, for value known to be a character. Don't bother comparing
4114 a single byte to 0400, as it's always less.
4115
395fcb93 4116 * floatfns.c (Fexpt):
327eeec8
PE
4117 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4118
abbd3d23
PE
4119 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4120 for characters.
4121
684a03ef
PE
4122 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4123
0fed43f3
PE
4124 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4125 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4126 incorrectly succeed when S was a string, because 4294967386 was
4127 truncated before it was used.
4128
8fd02eb7
PE
4129 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4130 Otherwise, an out-of-range integer could cause undefined behavior
4131 on a 64-bit host.
4132
f8c86b69
PE
4133 * composite.c: Use int, not EMACS_INT, for characters.
4134 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4135 EMACS_INT, for values that are known to be in character range.
4136 This doesn't fix any bugs but is the usual style inside Emacs and
4137 may generate better code on 32-bit machines.
4138
34206dd2
PE
4139 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4140 This is for reasons similar to the recent CHAR_STRING fix.
4141 * charset.c (Fencode_char): Check that character arg is actually
4142 a character. Pass an int to ENCODE_CHAR.
4143 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4144 wider than 'int', as a compile-time check to prevent future regressions
4145 in this area.
4146
c5958d4c 4147 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4148
4149 Make sure a 64-bit char is never passed to CHAR_STRING.
4150 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4151 by silently ignoring the top 32 bits, allowing some values
4152 that were far too large to be valid characters.
4153 * character.h: Include <verify.h>.
4154 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4155 arguments are no wider than unsigned, as a compile-time check
4156 to prevent future regressions in this area.
4157 * data.c (Faset):
01103c44 4158 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4159 (Fsubst_char_in_region):
4160 * fns.c (concat):
4161 * xdisp.c (decode_mode_spec_coding):
4162 Adjust to CHAR_STRING's new requirement.
4163 * editfns.c (Finsert_char, Fsubst_char_in_region):
4164 * fns.c (concat): Check that character args are actually
4165 characters. Without this test, these functions did the wrong
4166 thing with wildly out-of-range values on 64-bit hosts.
4167
d37ca623
PE
4168 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4169 These casts should not be needed on 32-bit hosts, either.
4170 * keyboard.c (read_char):
4171 * lread.c (Fload): Remove casts to unsigned.
4172
ea204efb
PE
4173 * lisp.h (UNSIGNED_CMP): New macro.
4174 This fixes comparison bugs on 64-bit hosts.
4175 (ASCII_CHAR_P): Use it.
4176 * casefiddle.c (casify_object):
01103c44 4177 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4178 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4179 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4180 * dispextern.h (FACE_FROM_ID):
4181 * keyboard.c (read_char): Use UNSIGNED_CMP.
4182
41cb286c
PE
4183 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4184 not to EMACS_INT, to avoid GCC warning.
4185
4a1b9832
PE
4186 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4187
55daad71
PE
4188 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4189 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4190 isn't needed on 32-bit machines.
8f95c75c 4191
01103c44
PE
4192 * buffer.c (Fgenerate_new_buffer_name):
4193 Use EMACS_INT for count, not int.
0ceccced 4194 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4195
4196 * data.c (Qcompiled_function): Now static.
4197
c6f072e7
PE
4198 * window.c (window_body_lines): Now static.
4199
20ce5912
PE
4200 * image.c (gif_load): Rename local to avoid shadowing.
4201
9c4c5f81
PE
4202 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4203 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4204 * alloc.c (make_save_value): Integer argument is now of type
4205 ptrdiff_t, not int.
4206 (mark_object): Use ptrdiff_t, not int.
4207 * lisp.h (pD): New macro.
4208 * print.c (print_object): Use it.
4209
c0c5c8ae
PE
4210 * alloc.c: Use EMACS_INT, not int, to count objects.
4211 (total_conses, total_markers, total_symbols, total_vector_size)
4212 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4213 (total_free_floats, total_floats, total_free_intervals)
4214 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4215 Now EMACS_INT, not int. All uses changed.
4216 (Fgarbage_collect): Compute overall total using a double, so that
4217 integer overflow is less likely to be a problem. Check for overflow
4218 when converting back to an integer.
5a25e253
PE
4219 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4220 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4221 These were 'int' variables that could overflow on 64-bit hosts;
4222 they were never used, so remove them instead of repairing them.
211a0b2a 4223 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4224 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4225 Previously, this ceilinged at INT_MAX, but that doesn't work on
4226 64-bit machines.
e46bb31a 4227 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4228
c78baabf 4229 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4230 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4231 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4232 when a (possibly-narrower) signed value would do just as well.
4233 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4234
c9d624c6
PE
4235 * alloc.c: Catch some string size overflows that we were missing.
4236 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4237 for convenience in STRING_BYTES_MAX.
4238 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4239 The definition here is exact; the one in lisp.h was approximate.
4240 (allocate_string_data): Check for string overflow. This catches
4241 some instances we weren't catching before. Also, it catches
4242 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4243 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4244 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4245
c9d624c6
PE
4246 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4247 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4248 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4249
353032ce
PE
4250 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4251
2bccce07
PE
4252 * alloc.c (Fmake_string): Check for out-of-range init.
4253
0ac30604
SM
42542011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4255
4256 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4257
c195f2de
JD
42582011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4259
4260 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4261 xg_get_default_scrollbar_width.
4262
4263 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4264 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4265 (style_changed_cb): Call update_theme_scrollbar_width and call
4266 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4267 all frames (Bug#8505).
4268 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4269 Call gtk_window_set_resizable if HAVE_GTK3.
4270 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4271 and height if HAVE_GTK3 (Bug#8505).
4272 (scroll_bar_width_for_theme): New variable.
4273 (update_theme_scrollbar_width): New function.
4274 (xg_get_default_scrollbar_width): Move code to
4275 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4276 (xg_initialize): Call update_theme_scrollbar_width.
4277
4278 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4279
4280 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4281
e10ac9f1
MR
42822011-06-12 Martin Rudalics <rudalics@gmx.at>
4283
4284 * frame.c (make_frame): Call other_buffer_safely instead of
4285 other_buffer.
4286
4287 * window.c (temp_output_buffer_show): Call display_buffer with
4288 second argument Vtemp_buffer_show_specifiers and reset latter
4289 immediately after the call.
4290 (Vtemp_buffer_show_specifiers): New variable.
4291 (auto_window_vscroll_p, next_screen_context_lines)
4292 (Vscroll_preserve_screen_position): Remove leading asterisks from
4293 doc-strings.
4294
2d3c217e 42952011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4296
7b7f97e8 4297 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4298 * buffer.c (Qclone_number): Remove for now, as it's unused.
4299 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4300 (record_buffer): Remove unused local.
4301 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4302 (set_frame_buffer_list): Remove; unused.
4303 * frame.h (other_visible_frames): Remove decl.
4304 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4305 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4306 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4307 if HAVE_GPM.
4308 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4309 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4310 Define only if HAVE_GPM.
4311 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4312 (update_hints_inhibit): Remove; never set. All uses removed.
4313 * widgetprv.h (emacsFrameClassRec): Remove decl.
4314 * window.c (delete_deletable_window): Now returns void, since it
4315 wasn't returning anything.
4316 (compare_window_configurations): Remove unused locals.
4317 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4318 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4319 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4320 the same widths as pointers. This follows up on the 2011-05-06 patch.
4321 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4322 * xterm.h: Likewise.
4323 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4324
1384b89e
JB
43252011-06-12 Juanma Barranquero <lekktu@gmail.com>
4326
4327 * makefile.w32-in: Update dependencies.
4328 (LISP_H): Add lib/intprops.h.
4329
1100a63c
CY
43302011-06-11 Chong Yidong <cyd@stupidchicken.com>
4331
4332 * image.c (gif_load): Add animation frame delay to the metadata.
4333 (syms_of_image): Use DEFSYM. New symbol `delay'.
4334
6198ccd0
MR
43352011-06-11 Martin Rudalics <rudalics@gmx.at>
4336
4337 * window.c (delete_deletable_window): Re-add.
4338 (Fset_window_configuration): Rewrite to handle dead buffers and
4339 consequently deletable windows.
4340 (window_tree, Fwindow_tree): Remove. Supply functionality in
4341 window.el.
4342 (compare_window_configurations): Simplify code.
4343
b6e3633c
AS
43442011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4345
1ab0dee5
AS
4346 * image.c (imagemagick_load_image): Fix type mismatch.
4347 (Fimagemagick_types): Likewise.
4348
b6e3633c
AS
4349 * window.h (replace_buffer_in_windows): Declare.
4350
9397e56f
MR
43512011-06-11 Martin Rudalics <rudalics@gmx.at>
4352
4353 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4354 Qclone_number. Remove external declaration of Qdelete_window.
4355 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4356 code.
640c8776
SM
4357 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4358 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4359 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4360 buffer list implementation.
4361 (other_buffer_safely): New function.
4362 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4363 calls to replace_buffer_in_windows and
4364 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4365 if allowed.
4366 (record_buffer): Inhibit quitting and rewrite using quittable
4367 functions. Run Qbuffer_list_update_hook if allowed.
4368 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4369 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4370 Move switch-to-buffer to window.el.
9397e56f
MR
4371 (bury-buffer): Move to window.el.
4372 (Vbuffer_list_update_hook): New variable.
4373
4374 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4375 section.
4376
4377 * window.h (resize_frame_windows): Move up in code.
4378 (Fwindow_frame): Remove EXFUN.
4379 (replace_buffer_in_all_windows): Remove prototype.
4380 (replace_buffer_in_windows_safely): Add prototype.
4381
4382 * window.c: Declare Qdelete_window static again. Move down
4383 declaration of select_count.
4384 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4385 (Fother_window): Move to window.el.
4386 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4387 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4388 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4389 window.el.
4390 (replace_buffer_in_windows): Implement by calling
4391 Qreplace_buffer_in_windows.
4392 (replace_buffer_in_all_windows): Remove with some functionality
4393 moved into replace_buffer_in_windows_safely.
4394 (replace_buffer_in_windows_safely): New function.
4395 (select_window_norecord, select_frame_norecord): Move in front
4396 of run_window_configuration_change_hook. Remove now obsolete
4397 declarations.
640c8776
SM
4398 (Fset_window_buffer): Rewrite doc-string.
4399 Call Qrecord_window_buffer.
9397e56f
MR
4400 (keys_of_window): Move binding for other-window to window.el.
4401
b50691aa
CY
44022011-06-11 Chong Yidong <cyd@stupidchicken.com>
4403
4404 * dispextern.h (struct image): Replace data member, whose int_val
4405 and ptr_val fields were not used by anything, with a single
4406 lisp_val object.
4407
4408 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4409 (gif_clear_image, gif_load, imagemagick_load_image)
4410 (gs_clear_image, gs_load): Callers changed.
4411
3f754b86
PE
44122011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4413
cca69397
PE
4414 * buffer.h: Include <time.h>, for time_t.
4415 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4416
109e28d0
PE
4417 Fix minor problems found by static checking.
4418
60737f02
PE
4419 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4420
4b66faf3
PE
4421 Make identifiers static if they are not used in other modules.
4422 * data.c (Qcompiled_function, Qframe, Qvector):
4423 * image.c (QimageMagick, Qsvg):
4424 * minibuf.c (Qmetadata):
4425 * window.c (resize_window_check, resize_root_window): Now static.
4426 * window.h (resize_window_check, resize_root_window): Remove decls.
4427
109e28d0
PE
4428 * window.c (window_deletion_count, delete_deletable_window):
4429 Remove; unused.
46a4ce9e
PE
4430 (window_body_lines): Now static.
4431 (Fdelete_other_windows_internal): Mark vars as initialized.
4432 Make sure 'resize_failed' is initialized.
4433 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4434 (resize_window_apply): Remove unused local.
4435 * window.h (delete_deletable_window): Remove decl.
4436
109e28d0 4437 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4438 (imagemagick_load_image): Fix pointer signedness problem by changing
4439 last arg from unsigned char * to char *. All uses changed.
4440 Also, fix a local for similar reasons.
4441 Remove unused locals. Remove locals to avoid shadowing.
4442 (fn_rsvg_handle_free): Remove; unused.
4443 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4444 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4445
3f754b86
PE
4446 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4447
2547adb1
CY
44482011-06-10 Chong Yidong <cyd@stupidchicken.com>
4449
4450 * image.c (gif_load): Fix omitted cast error introduced by
4451 2011-06-06 change.
4452
2c8e37d4
MR
44532011-06-10 Martin Rudalics <rudalics@gmx.at>
4454
4455 * window.h (resize_proportionally, orig_total_lines)
4456 (orig_top_line): Remove from window structure.
4457 (set_window_height, set_window_width, change_window_heights)
4458 (Fdelete_window): Remove prototypes.
4459 (resize_frame_windows): Remove duplicate declaration.
4460
440a42e3
EZ
44612011-06-10 Eli Zaretskii <eliz@gnu.org>
4462
4463 * window.h (resize_frame_windows, resize_window_check)
4464 (delete_deletable_window, resize_root_window)
4465 (resize_frame_windows): Declare prototypes.
4466
4467 * window.c (resize_window_apply): Make definition be "static" to
4468 match the prototype.
4469
562dd5e9
MR
44702011-06-10 Martin Rudalics <rudalics@gmx.at>
4471
4472 * window.c: Remove declarations of Qwindow_size_fixed,
4473 window_min_size_1, window_min_size_2, window_min_size,
4474 size_window, window_fixed_size_p, enlarge_window, delete_window.
4475 Remove static from declaration of Qdelete_window, it's
4476 temporarily needed by Fbury_buffer.
4477 (replace_window): Don't assign orig_top_line and
4478 orig_total_lines.
4479 (Fdelete_window, delete_window): Remove. Window deletion is
4480 handled by window.el.
640c8776
SM
4481 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4482 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4483 (Fdelete_other_windows): Remove. Deleting other windows is
4484 handled by window.el.
4485 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4486 handled in window.el.
4487 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4488 Window minimum sizes are handled in window.el.
4489 (shrink_windows, size_window, set_window_height)
4490 (set_window_width, change_window_heights, window_height)
4491 (window_width, CURBEG, CURSIZE, enlarge_window)
4492 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4493 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4494 handled in window.el.
4495 (make_dummy_parent): Rename to make_parent_window and give it a
4496 second argument horflag.
4497 (make_window): Don't set resize_proportionally any more.
4498 (Fsplit_window): Remove. Windows are split in window.el.
4499 (save_restore_action, save_restore_orig_size)
4500 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4501 Resize mini windows in window.el.
4502 (grow_mini_window, shrink_mini_window): Implement by calling
4503 Qresize_root_window_vertically, resize_window_check and
4504 resize_window_apply.
640c8776
SM
4505 (saved_window, Fset_window_configuration, save_window_save):
4506 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4507 resize_proportionally.
4508 (window_min_height, window_min_width): Move to window.el.
4509 (keys_of_window): Move bindings for delete-other-windows,
4510 split-window, delete-window and enlarge-window to window.el.
4511
4512 * buffer.c: Temporarily extern Qdelete_window.
4513 (Fbury_buffer): Temporarily call Qdelete_window instead of
4514 Fdelete_window (Fbury_buffer will move to window.el soon).
4515
4516 * frame.c (set_menu_bar_lines_1): Remove code handling
4517 orig_top_line and orig_total_lines.
4518
4519 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4520 set_window_height but set heights directly.
4521 (change_frame_size_1): Use resize_frame_windows.
4522
4523 * xdisp.c (init_xdisp): Don't use set_window_height but set
4524 heights directly.
4525
640c8776
SM
4526 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4527 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4528 run_window_configuration_change_hook.
4529
4530 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4531 instead of change_window_heights and run
4532 run_window_configuration_change_hook.
4533
1a13852e
MR
45342011-06-09 Martin Rudalics <rudalics@gmx.at>
4535
4536 * window.c (replace_window): Rename second argument REPLACEMENT to
4537 NEW. New third argument SETFLAG. Rewrite.
4538 (delete_window, make_dummy_parent): Call replace_window with
4539 third argument 1.
4540 (window_list_1): Move down in code.
4541 (run_window_configuration_change_hook): Move set_buffer part
4542 before select_frame_norecord part in order to unwind correctly.
4543 Rename count1 to count.
4544 (recombine_windows, delete_deletable_window, resize_root_window)
4545 (Fdelete_other_windows_internal)
4546 (Frun_window_configuration_change_hook, make_parent_window)
4547 (resize_window_check, resize_window_apply, Fresize_window_apply)
4548 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4549 (Fdelete_window_internal, Fresize_mini_window_internal):
4550 New functions.
1a13852e
MR
4551 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4552
f3d1777e
MR
45532011-06-08 Martin Rudalics <rudalics@gmx.at>
4554
496e208e
MR
4555 * window.h (window): Add some new members to window structure -
4556 normal_lines, normal_cols, new_total, new_normal, clone_number,
4557 splits, nest, prev_buffers, next_buffers.
4558 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4559 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4560
f3d1777e
MR
4561 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4562 Remove.
496e208e
MR
4563 (make_dummy_parent): Set new members of windows structure.
4564 (make_window): Move down in code. Handle new members of window
4565 structure.
4566 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4567 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4568 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4569 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4570 (Fset_window_next_buffers, Fset_window_clone_number):
4571 New functions.
496e208e
MR
4572 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4573 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4574 Doc-string fixes.
4575 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4576 Argument WINDOW can be now internal window too.
4577 (Fwindow_use_time): Move up in code.
4578 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4579 Rewrite doc-string.
4580 (Fset_window_configuration, saved_window)
4581 (Fcurrent_window_configuration, save_window_save): Handle new
4582 members of window structure.
b9e809c2
MR
4583 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4584 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4585 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4586 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4587 Qget_mru_window, Qresize_root_window,
4588 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4589 Qauto_buffer_name; staticpro them.
f3d1777e 4590
abde8f8c
MR
45912011-06-07 Martin Rudalics <rudalics@gmx.at>
4592
4593 * window.c (Fwindow_total_size, Fwindow_left_column)
4594 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4595 (Fwindow_list_1): New functions.
4596 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4597 (Fwindow_width, Fscroll_left, Fscroll_right):
4598 Use window_body_cols instead of window_box_text_cols.
4599 (delete_window, Fset_window_configuration):
4600 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4601 (delete_all_subwindows): Take a window as argument and not a
4602 structure. Rewrite.
190b47e6
MR
4603 (window_loop): Remove handling of GET_LRU_WINDOW and
4604 GET_LARGEST_WINDOW.
4605 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4606
4607 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4608 window_box_text_cols. delete_all_subwindows now takes a
4609 Lisp_Object as argument.
abde8f8c 4610
640c8776
SM
4611 * indent.c (compute_motion, Fcompute_motion):
4612 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4613
fa8a67e6
MR
4614 * frame.c (delete_frame): Call delete_all_subwindows with root
4615 window as argument.
4616
a54e3482
DC
46172011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4618
4619 * fns.c (Fputhash): Document return value.
4620
60002bf5
CY
46212011-06-06 Chong Yidong <cyd@stupidchicken.com>
4622
4623 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4624
0c671da6 46252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4626
b862a52a 4627 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4628
be44ca6c
PE
4629 Check for overflow when converting integer to cons and back.
4630 * charset.c (Fdefine_charset_internal, Fdecode_char):
4631 Use cons_to_unsigned to catch overflow.
4632 (Fencode_char): Use INTEGER_TO_CONS.
4633 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4634 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4635 * data.c (long_to_cons, cons_to_long): Remove.
4636 (cons_to_unsigned, cons_to_signed): New functions.
4637 These signal an error for invalid or out-of-range values.
4638 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4639 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4640 * font.c (Ffont_variation_glyphs):
4641 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4642 * lisp.h: Include <intprops.h>.
4643 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4644 (cons_to_signed, cons_to_unsigned): New decls.
4645 (long_to_cons, cons_to_long): Remove decls.
4646 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4647 (Fprimitive_undo): Use CONS_TO_INTEGER.
4648 * xfns.c (Fx_window_property): Likewise.
4649 * xselect.c: Include <limits.h>.
4650 (x_own_selection, selection_data_to_lisp_data):
4651 Use INTEGER_TO_CONS.
4652 (x_handle_selection_request, x_handle_selection_clear)
4653 (x_get_foreign_selection, Fx_disown_selection_internal)
4654 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4655 (lisp_data_to_selection_data): Use cons_to_unsigned.
4656 (x_fill_property_data): Use cons_to_signed.
4657 Report values out of range.
4658
d1f3d2af
PE
4659 Check for buffer and string overflow more precisely.
4660 * buffer.h (BUF_BYTES_MAX): New macro.
4661 * lisp.h (STRING_BYTES_MAX): New macro.
4662 * alloc.c (Fmake_string):
4663 * character.c (string_escape_byte8):
4664 * coding.c (coding_alloc_by_realloc):
4665 * doprnt.c (doprnt):
4666 * editfns.c (Fformat):
4667 * eval.c (verror):
4668 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4669 since they may not be the same number.
4670 * editfns.c (Finsert_char):
4671 * fileio.c (Finsert_file_contents):
4672 Likewise for BUF_BYTES_MAX.
4673
dd52fcea
PE
4674 * image.c: Use ptrdiff_t, not int, for sizes.
4675 (slurp_file): Switch from int to ptrdiff_t.
4676 All uses changed.
4677 (slurp_file): Check that file size fits in both size_t (for
4678 malloc) and ptrdiff_t (for sanity and safety).
4679
7f9bbdbb
PE
4680 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4681 if b->modtime has its maximal value.
4682
dfe18f82
PE
4683 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4684
84acfcf0
PE
4685 Don't assume time_t can fit into int.
4686 * buffer.h (struct buffer.modtime): Now time_t, not int.
4687 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4688 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4689
ccd9a01a
PE
4690 Minor fixes for signed vs unsigned integers.
4691 * character.h (MAYBE_UNIFY_CHAR):
4692 * charset.c (maybe_unify_char):
4693 * keyboard.c (read_char, reorder_modifiers):
4694 XINT -> XFASTINT, since the integer must be nonnegative.
4695 * ftfont.c (ftfont_spec_pattern):
4696 * keymap.c (access_keymap, silly_event_symbol_error):
4697 XUINT -> XFASTINT, since the integer must be nonnegative.
4698 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4699 since it makes no difference and we prefer signed.
4700 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4701 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4702 nonnegative.
4703
d6d100dd
SM
47042011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4705
4706 * window.h (Fwindow_frame): Declare.
4707
2b6148e4
PE
47082011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4709
4710 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4711 (SPARE_MEMORY): Always define.
4712 (LARGE_REQUEST): Remove.
4713 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4714
f230ecc9
MR
47152011-06-06 Martin Rudalics <rudalics@gmx.at>
4716
727e958e
MR
4717 * lisp.h: Move EXFUNS for Fframe_root_window,
4718 Fframe_first_window and Fset_frame_selected_window to window.h.
4719
4720 * window.h: Move EXFUNS for Fframe_root_window,
4721 Fframe_first_window and Fset_frame_selected_window here from
4722 lisp.h.
4723
4724 * frame.c (Fwindow_frame, Fframe_first_window)
4725 (Fframe_root_window, Fframe_selected_window)
4726 (Fset_frame_selected_window): Move to window.c.
4727 (Factive_minibuffer_window): Move to minibuf.c.
4728 (Fother_visible_frames_p): New function.
4729
4730 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4731
f230ecc9
MR
4732 * window.c (decode_window, decode_any_window): Move up in code.
4733 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4734 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4735 (Fwindow_buffer): Move up and rewrite doc-string.
4736 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4737 (Fwindow_prev): New functions.
727e958e
MR
4738 (Fwindow_frame): Move here from frame.c. Accept any window as
4739 argument.
4740 (Fframe_root_window, Fframe_first_window)
4741 (Fframe_selected_window): Move here from frame.c. Accept frame
4742 or arbitrary window as argument. Update doc-strings.
4743 (Fminibuffer_window): Move up in code.
4744 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4745 (Fset_frame_selected_window): Move here from frame.c.
4746 Marginal rewrite.
727e958e
MR
4747 (Fselected_window, select_window, Fselect_window): Move up in
4748 code. Minor doc-string fixes.
f230ecc9 4749
4d09bcf6
PE
47502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4751
4752 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4753 Do not assume that spare memory exists; that assumption is valid
4754 only if SYSTEM_MALLOC.
4755 (LARGE_REQUEST): New macro, so that the issue of large requests
4756 is separated from the issue of spare memory.
4757
810928a2
AS
47582011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4759
172418ad
AS
4760 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4761 format. (Bug#8806)
4762
43f862f7
AS
4763 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4764
810928a2
AS
4765 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4766 before statements.
4767
a059fe24
JD
47682011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4769
4770 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4771
4772 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4773
4774 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4775 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4776
989bf368
JB
47772011-06-05 Juanma Barranquero <lekktu@gmail.com>
4778
4779 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4780
4b80f674
CY
47812011-06-04 Chong Yidong <cyd@stupidchicken.com>
4782
4783 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4784 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4785 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4786 New error handlers.
4b80f674
CY
4787 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4788 Obey Vx_select_enable_clipboard_manager. Catch errors in
4789 x_clipboard_manager_save (Bug#8779).
4790 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4791 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4792
99a33b77 47932011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4794
4795 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4796
99a33b77 47972011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4798
4799 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4800 in the current matrix if keep_current_p is non-zero.
4801
8264569d
EZ
48022011-06-04 Eli Zaretskii <eliz@gnu.org>
4803
4804 * bidi.c (bidi_level_of_next_char): Fix last change.
4805
57f97249
EZ
48062011-06-03 Eli Zaretskii <eliz@gnu.org>
4807
fec2107c 4808 Support bidi reordering of text covered by display properties.
57f97249 4809
fec2107c
EZ
4810 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4811 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4812 (bidi_cache_search, bidi_cache_iterator_state)
4813 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4814 (bidi_level_of_next_char, bidi_move_to_visually_next):
4815 Support character positions inside a run of characters covered by a
fec2107c
EZ
4816 display string.
4817 (bidi_paragraph_init, bidi_resolve_explicit_1)
4818 (bidi_level_of_next_char): Call bidi_fetch_char and
4819 bidi_fetch_char_advance instead of FETCH_CHAR and
4820 FETCH_CHAR_ADVANCE.
4821 (bidi_init_it): Initialize new members.
4822 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4823 definitions.
4824 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4825 instead of using explicit *_CHAR codes.
d6d100dd
SM
4826 (bidi_resolve_explicit, bidi_resolve_weak):
4827 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4828 bidirectional text is supported only in multibyte buffers.
4829 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4830 it to initialize the frame_window_p member of struct bidi_it.
4831 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4832 (bidi_resolve_explicit, bidi_resolve_weak)
4833 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4834 bidi_it->nchars is non-positive.
4835 (bidi_level_of_next_char): Don't try to lookup the cache for the
4836 next/previous character if nothing is cached there yet, or if we
4837 were just reseat()'ed to a new position.
c40e2fb2 4838
0e14fe90
EZ
4839 * xdisp.c (set_cursor_from_row): Set start and stop points
4840 according to the row's direction when priming the loop that looks
4841 for the glyph on which to display cursor.
4842 (single_display_spec_intangible_p): Function deleted.
4843 (display_prop_intangible_p): Reimplement to call
4844 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4845 Accept 3 additional arguments needed by handle_display_spec.
4846 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4847 values: lists, `(when COND...)' forms, etc.
4848 (single_display_spec_string_p): Support property values that are
4849 lists with the argument STRING its top-level element.
4850 (display_prop_string_p): Fix the condition for processing a
4851 property that is a list to be consistent with handle_display_spec.
fec2107c 4852 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4853 last portion of handle_display_prop.
4854 (compute_display_string_pos): Accept additional argument
4855 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4856 value of a `display' property is a "replacing spec".
4857 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4858 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4859 the display property, but just return a value indicating whether
4860 the display property will replace the characters it covers.
4861 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4862 frame_window_p members of struct bidi_it.
d6d100dd
SM
4863 (compute_display_string_pos, compute_display_string_end):
4864 New functions.
fec2107c
EZ
4865 (push_it): Accept second argument POSITION, where pop_it should
4866 jump to continue iteration.
4867 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4868
fec2107c
EZ
4869 * keyboard.c (adjust_point_for_property): Adjust the call to
4870 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4871
4872 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4873 (bidi_init_it): Update prototypes.
4874 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4875 (compute_display_string_pos, compute_display_string_end):
4876 Declare prototypes.
fec2107c
EZ
4877 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4878 EMACS_INT.
fc6f18ce 4879
40087514 48802011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4881
57f53182
PE
4882 Malloc failure behavior now depends on size of allocation.
4883 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4884 * lisp.h: Change signatures accordingly.
4885 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4886 All callers changed. (Bug#8762)
4887
4888 * gnutls.c: Use Emacs's memory allocators.
4889 Without this change, the gnutls library would invoke malloc etc.
4890 directly, which causes problems on non-SYNC_INPUT hosts, and which
4891 runs afoul of improving memory_full behavior. (Bug#8761)
4892 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4893 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4894 xfree instead of the default malloc, realloc, free.
4895 (Fgnutls_boot): No need to check for memory allocation failure,
4896 since xmalloc does that for us.
4897
ac32cd99 4898 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4899 * category.c (hash_get_category_set):
4900 * ccl.c (ccl_driver):
4901 * charset.c (Fdefine_charset_internal):
4902 * charset.h (struct charset.hash_index):
4903 * composite.c (get_composition_id, gstring_lookup_cache)
4904 (composition_gstring_put_cache):
4905 * composite.h (struct composition.hash_index):
4906 * dispextern.h (struct image.hash):
4907 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4908 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4909 (hashfn_equal, hashfn_user_defined, make_hash_table)
4910 (maybe_resize_hash_table, hash_lookup, hash_put)
4911 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4912 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4913 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4914 * image.c (make_image, search_image_cache, lookup_image)
4915 (xpm_put_color_table_h):
4916 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4917 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4918 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4919 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4920 * alloc.c (allocate_vectorlike):
4921 Check for overflow in vector size calculations.
4922 * ccl.c (ccl_driver):
4923 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4924 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4925 need to be updated by these changes.
40087514
PE
4926 * fns.c (make_hash_table, maybe_resize_hash_table):
4927 Check for integer overflow with large hash tables.
0de4bb68
PE
4928 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4929 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4930 (SXHASH_REDUCE): New macro.
4931 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4932 Use it instead of discarding useful hash info with large hash values.
4933 (sxhash_float): New function.
4934 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4935 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4936 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4937 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4938 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4939 Adjust signatures to match updated version of code.
4940 (consing_since_gc): Now EMACS_INT, since a single hash table can
4941 use more than INT_MAX bytes.
4942
698d32e2
DN
49432011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4944
4945 Make it possible to build with GCC-4.6+ -O2 -flto.
4946
4947 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4948
fd6fa53f
SM
49492011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4950
4951 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4952 Call minibuffer-inactive-mode.
4953
864db017
JB
49542011-05-31 Juanma Barranquero <lekktu@gmail.com>
4955
4956 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4957 Update dependencies.
4958
2ad0baf4
DN
49592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4960
4961 * data.c (init_data): Remove code for UTS, this system is not
4962 supported anymore.
4963
4fcc2638
DN
49642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4965
4966 Don't force ./temacs to start in terminal mode.
4967
4968 * frame.c (make_initial_frame): Initialize faces in all cases, not
4969 only when CANNOT_DUMP is defined.
4970 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4971
c56e0fd5
DN
49722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4973
4974 * dispnew.c (add_window_display_history): Use const for the string
4975 pointer. Remove declaration, not needed.
4976
333d54da 49772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4978
55d4c1b2 4979 Use 'inline', not 'INLINE'.
333d54da 4980 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4981 * alloc.c, fontset.c (INLINE): Remove.
4982 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4983 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4984 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4985 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4986 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4987
738db178
DN
49882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4989
4990 Make it possible to run ./temacs.
4991
4992 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4993 syms_of_callproc does the same thing. Remove test for
4994 "initialized", do it in the caller.
4995 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4996
620c53a6
SM
49972011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4998
4999 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5000 (read_minibuf): Use get_minibuffer.
5001 (syms_of_minibuf): Use DEFSYM.
5002 (Qmetadata): New var.
5003 * data.c (Qbuffer): Don't make it static.
5004 (syms_of_data): Use DEFSYM.
5005
e003a292
PE
50062011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5007
5008 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5009 (CCL_CODE_MIN): New macro.
5010
ed008a6d
PE
50112011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5012
3687c2ef
PE
5013 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5014
ed008a6d
PE
5015 * eval.c (Qdebug): Now static.
5016 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5017 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5018 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5019
d66c4c7c
CY
50202011-05-29 Chong Yidong <cyd@stupidchicken.com>
5021
5022 * image.c: Various fixes to ImageMagick code comments.
5023 (Fimagemagick_types): Doc fix.
5024
5fbc2025
PE
50252011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5026
0196f88a
PE
5027 Minor fixes prompted by GCC 4.6.0 warnings.
5028
5029 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5030
5fbc2025
PE
5031 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5032 (x_clipboard_manager_save_all): Move extern decl to ...
5033 * xterm.h: ... here, so that it can be checked for consistency.
5034
1dd3c2d9
CY
50352011-05-29 Chong Yidong <cyd@stupidchicken.com>
5036
5037 * xselect.c (x_clipboard_manager_save_frame)
5038 (x_clipboard_manager_save_all): New functions.
5039 (Fx_clipboard_manager_save): Lisp function deleted.
5040
5041 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5042 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5043
5044 * xterm.h: Update prototype.
5045
5ba6571d
WX
50462011-05-28 William Xu <william.xwl@gmail.com>
5047
5048 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5049 exiting (Bug#8239).
5050
3eaff834
JM
50512011-05-28 Jim Meyering <meyering@redhat.com>
5052
e1900994 5053 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5054 * fns.c (to_uchar): Define.
5055 (crypto_hash_function): Use it to convert some newly-signed
5056 variables to unsigned, to avoid sign-extension bugs. For example,
5057 without this change, (md5 "truc") would evaluate to
5058 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5059 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5060 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5061
0f6990a7
PE
50622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5063
5064 Integer overflow fixes.
c8a9ca5a 5065
08686060
PE
5066 * dbusbind.c: Serial number integer overflow fixes.
5067 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5068 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5069 to hold a serial number that is too large for a fixnum.
5070 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5071 Check for serial numbers out of range. Decode any serial number
59568bf0 5072 that was so large that it became a float. (Bug#8722)
08686060 5073
2d1fc3c7
PE
5074 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5075 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5076 Use XFASTINT rather than XUINT when numbers are nonnegative.
5077 (xd_append_arg, Fdbus_method_return_internal):
5078 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5079 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5080 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5081 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5082 (Bug#8722)
2d1fc3c7 5083
c8a9ca5a
PE
5084 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5085
519e1d69
PE
5086 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5087
30569699
PE
5088 ccl: add integer overflow checks
5089 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5090 (IN_INT_RANGE): New macros.
5091 (ccl_driver): Use them to check for integer overflow when
5092 decoding a CCL program. Many of the new checks are whether XINT (x)
5093 fits in int; it doesn't always, on 64-bit hosts. The new version
5094 doesn't catch all possible integer overflows, but it's an
847044ea 5095 improvement. (Bug#8719)
30569699 5096
c11285dc
PE
5097 * alloc.c (make_event_array): Use XINT, not XUINT.
5098 There's no need for unsigned here.
5099
fdccd48e
PE
5100 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5101 This follows up to the 2011-05-06 change that substituted uintptr_t
5102 for EMACS_INT. This case wasn't caught back then.
5103
37910ab2
PE
5104 Rework Fformat to avoid integer overflow issues.
5105 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5106 now (part of C89). Include <verify.h>.
5107 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5108 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5109 (Fformat): Avoid the prepass trying to compute sizes; it was only
5110 approximate and thus did not catch overflow reliably. Instead, walk
5111 through the format just once, formatting and computing sizes as we go,
5112 checking for integer overflow at every step, and allocating a larger
5113 buffer as needed. Keep track separately whether the format is
5114 multibyte. Keep only the most-recently calculated precision, rather
5115 than them all. Record whether each argument has been converted to
5116 string. Use EMACS_INT, not int, for byte and char and arg counts.
5117 Support field widths and precisions larger than INT_MAX. Avoid
5118 sprintf's undefined behavior with conversion specifications such as %#d
5119 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5120 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5121 formatting out-of-range floating point numbers with int
9173deec 5122 formats. (Bug#8668)
37910ab2 5123
2e6578fb
PE
5124 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5125
0ae6bdee
PE
5126 * data.c: Avoid integer truncation in expressions involving floats.
5127 * data.c: Include <intprops.h>.
5128 (arith_driver): When there's an integer overflow in an expression
5129 involving floating point, convert the integers to floating point
5130 so that the resulting value does not suffer from catastrophic
5131 integer truncation. For example, on a 64-bit host (* 4
5132 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5133 Do not rely on undefined behavior after integer overflow.
5134
de883a70
PE
5135 merge count_size_as_multibyte, parse_str_to_multibyte
5136 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5137 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5138 Check for integer overflow.
5139 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5140 since it's now a duplicate of the other. This is more of
5141 a character than a buffer op, so better that it's in character.c.
5142 * fns.c, print.c: Adjust to above changes.
5143
2ff916cb
PE
51442011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5145
5146 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5147
f1b54466
PE
51482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5149
fb1ac845
PE
5150 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5151 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5152 (x_clipboard_manager_save): Now static.
5153 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5154
f1b54466
PE
5155 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5156 (crypto_hash_function): Now static.
5157 Fix pointer signedness problems. Avoid unnecessary initializations.
5158
a9f737ee
CY
51592011-05-27 Chong Yidong <cyd@stupidchicken.com>
5160
5161 * termhooks.h (Vselection_alist): Make it terminal-local.
5162
5163 * terminal.c (create_terminal): Initialize it.
5164
5165 * xselect.c: Support for clipboard managers.
5166 (Vselection_alist): Move to termhooks.h as terminal-local var.
5167 (LOCAL_SELECTION): New macro.
5168 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5169 (symbol_to_x_atom): Remove gratuitous arg.
5170 (x_handle_selection_request, lisp_data_to_selection_data)
5171 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5172 (x_own_selection, x_get_local_selection, x_convert_selection):
5173 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5174 (some_frame_on_display): Delete unused function.
5175 (Fx_own_selection_internal, Fx_get_selection_internal)
5176 (Fx_disown_selection_internal, Fx_selection_owner_p)
5177 (Fx_selection_exists_p): New optional frame arg.
5178 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5179 (x_handle_selection_clear): Don't treat other terminals with the
5180 same keyboard specially. Use the terminal-local Vselection_alist.
5181 (x_clear_frame_selections): Use Frun_hook_with_args.
5182
5183 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5184
5185 * xterm.h: Add support for those atoms.
5186
e067f0c1
CY
51872011-05-26 Chong Yidong <cyd@stupidchicken.com>
5188
5189 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5190 (converted_selections, conversion_fail_tag): New global variables.
5191 (x_selection_request_lisp_error): Free the above.
5192 (x_get_local_selection): Remove unnecessary code.
5193 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5194 of converted selections stored in converted_selections.
5195 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5196 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5197 (x_convert_selection): New function.
5198 (x_handle_selection_event): Simplify.
5199 (x_get_foreign_selection): Don't ignore incoming requests while
5200 waiting for an answer; this will fail when we implement
5201 SAVE_TARGETS, and seems unnecessary anyway.
5202 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5203 (Vx_sent_selection_functions): Doc fix.
5204
0f4aebc0
LL
52052011-05-26 Leo Liu <sdl.web@gmail.com>
5206
5207 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5208
e61124cd
YM
52092011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5210
5211 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5212
5213 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5214 for fringe update if it has periodic bitmap.
ac389d0c 5215 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5216 and fringe_bitmap_periodic_p.
5217
5218 * fringe.c (get_fringe_bitmap_data): New function.
5219 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5220 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5221 row. Mark glyph row for fringe update if periodicity changed.
5222
5223 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5224 for fringe update unless it has periodic bitmap.
5225
f16d9837
KH
52262011-05-25 Kenichi Handa <handa@m17n.org>
5227
5228 * xdisp.c (get_next_display_element): Set correct it->face_id for
5229 a static composition.
5230
e1b90ef6
LL
52312011-05-24 Leo Liu <sdl.web@gmail.com>
5232
5233 * deps.mk (fns.o):
5234 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5235
5236 * fns.c (crypto_hash_function, Fsha1): New function.
5237 (Fmd5): Use crypto_hash_function.
5238 (syms_of_fns): Add Ssha1.
5239
7400048f
PE
52402011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5241
5242 * gnutls.c: Remove unused macros.
5243 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5244 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5245 Remove macros that are defined and never used.
5246 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5247
abb71cf4
CY
52482011-05-22 Chong Yidong <cyd@stupidchicken.com>
5249
5250 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5251 (Fx_get_selection_internal): Minor cleanup.
5252 (Fx_own_selection_internal): Rename arguments for consistency with
5253 select.el.
5254
6307db39
PE
52552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5256
5257 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5258
f3d4e0a4
CY
52592011-05-22 Chong Yidong <cyd@stupidchicken.com>
5260
5261 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5262
4d8ade89
YM
52632011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5264
5265 * dispnew.c (scrolling_window): Don't exclude the case that the
5266 last enabled row in the desired matrix touches the bottom boundary.
5267
32078c8d
GM
52682011-05-21 Glenn Morris <rgm@gnu.org>
5269
5270 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5271 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5272 and add some more files.
32078c8d 5273
7285dc67
EZ
52742011-05-20 Eli Zaretskii <eliz@gnu.org>
5275
5276 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5277 report_file_error introduced by the change from 2011-05-07.
5278
89d1bd22
PE
52792011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5280
5281 * systime.h (Time): Define only if emacs is defined.
5282 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5283 where the include path doesn't have X11/X.h by default. See
5284 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5285
e23640bb 52862011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5287
5288 * composite.c (find_automatic_composition): Fix previous change.
5289
b9704ad9
GM
52902011-05-20 Glenn Morris <rgm@gnu.org>
5291
5292 * lisp.mk: New file, split from Makefile.in.
5293 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5294 (shortlisp): Remove.
5295 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5296
4a720484
GM
52972011-05-19 Glenn Morris <rgm@gnu.org>
5298
5299 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5300 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5301 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5302 (lisp): Set the order to that of loadup.el.
5303 (shortlisp): Make it a copy of $lisp.
5304 (SOME_MACHINE_LISP): Remove.
5305 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5306 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5307
a28d4396
KH
53082011-05-18 Kenichi Handa <handa@m17n.org>
5309
5310 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5311 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5312 (find_automatic_composition): Mostly rewrite for efficiency.
5313
a2b1fa8e
JB
53142011-05-18 Juanma Barranquero <lekktu@gmail.com>
5315
5316 * makefile.w32-in: Update dependencies.
5317
8e1f5610
CS
53182011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5319
5320 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5321 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5322
7025ee00 53232011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5324
cdfa6eab
PE
5325 Fix some integer overflow issues, such as string length overflow.
5326
06d6db33
PE
5327 * insdel.c (count_size_as_multibyte): Check for string overflow.
5328
2b4560a8
PE
5329 * character.c (lisp_string_width): Check for string overflow.
5330 Use EMACS_INT, not int, for string indexes and lengths; in
5331 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5332 the resulting string length overflows an EMACS_INT; instead,
5333 report a string overflow if no precision given. When checking for
5334 precision exhaustion, use a check that cannot possibly have
5335 integer overflow. (Bug#8675)
5336 * character.h (lisp_string_width): Adjust to new signature.
5337
cb93f9be
PE
5338 * alloc.c (string_overflow): New function.
5339 (Fmake_string): Use it. This doesn't change behavior, but saves
5340 a few bytes and will simplify future changes.
5341 * character.c (string_escape_byte8): Likewise.
5342 * lisp.h (string_overflow): New decl.
5343
1a1f3366
PE
5344 Fixups, following up to the user-interface timestamp change.
5345 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5346 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5347 * msdos.c (mouse_get_pos): Likewise.
5348 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5349 * w32gui.h (Time): Define by including "systime.h" rather than by
5350 declaring it ourselves. (Bug#8664)
5351
d4e3e4d3
PE
5352 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5353 * image.c (clear_image_cache): Likewise.
5354
f6a24d19
PE
5355 * term.c (term_mouse_position): Don't assume time_t wraparound.
5356
08dc5ae6
PE
5357 Be more systematic about user-interface timestamps.
5358 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5359 and sometimes 'EMACS_UINT', to represent these timestamps.
5360 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5361 This makes the code easier to follow, and makes it easier to catch
5362 integer overflow bugs such as Bug#8664.
5363 * frame.c (Fmouse_position, Fmouse_pixel_position):
5364 Use Time, not unsigned long, for user-interface timestamps.
5365 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5366 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5367 * keyboard.h (last_event_timestamp): Likewise.
5368 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5369 * menu.h (xmenu_show): Likewise.
5370 * term.c (term_mouse_position): Likewise.
5371 * termhooks.h (struct input_event.timestamp): Likewise.
5372 (struct terminal.mouse_position_hook): Likewise.
5373 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5374 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5375 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5376 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5377 what it was before.
5378 * menu.h, termhooks.h: Include "systime.h", for Time.
5379
8e55734a
PE
5380 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5381 Don't assume that the difference between two unsigned long values
5382 can fit into an integer. At this point, we know button_down_time
5383 <= event->timestamp, so the difference must be nonnegative, so
5384 there's no need to cast the result if double-click-time is
5385 nonnegative, as it should be; check that it's nonnegative, just in
5386 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5387 apart (about 25 days). (Bug#8664)
8e55734a 5388
841f1b75 5389 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5390 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5391
3e26f69c
PE
5392 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5393 that always fit in int. Use a sentinel instead of a counter, to
5394 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5395 * frame.h (struct frame): Use int for menu_bar_items_used
5396 instead of EMACS_INT, since it always fits in int.
3e26f69c 5397
5cc152c0
PE
5398 * menu.c (grow_menu_items): Check for int overflow.
5399
d89eb65e
PE
5400 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5401
5235bd3e
PE
5402 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5403 Before, the code was not consistent. These values cannot exceed
5404 2**31 - 1 so there's no need to make them unsigned.
5405 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5406 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5407 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5408 as modifiers.
5409 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5410
bc827e23
PE
5411 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5412 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5413 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5414 presumably because the widths might not match.
5415
78eb494e
PE
5416 * window.c (size_window): Avoid needless test at loop start.
5417
04f2d78b
CB
54182011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5419
5420 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5421
d2fc7e3d 54222011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5423
5424 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5425
d2fc7e3d 54262011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5427
5428 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5429 `width' to `bar_area_x' and `bar_area_width', respectively.
5430 (x_scroll_run): Take account of fringe background extension.
5431
04f2d78b
CB
5432 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5433 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5434 `bar_area_width', respectively.
5435 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5436 background extension.
5437
79b70037
GM
54382011-05-10 Jim Meyering <meyering@redhat.com>
5439
5440 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5441
2f142cc5
JB
54422011-05-10 Juanma Barranquero <lekktu@gmail.com>
5443
5444 * image.c (Finit_image_library): Return t for built-in image types,
5445 like pbm and xbm. (Bug#8640)
5446
57679c86
AS
54472011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5448
5449 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5450
888c9e86
EZ
54512011-05-07 Eli Zaretskii <eliz@gnu.org>
5452
b0512a1d
EZ
5453 * w32console.c (Fset_screen_color): Doc fix.
5454 (Fget_screen_color): New function.
5455 (syms_of_ntterm): Defsubr it.
5456
7285dc67
EZ
5457 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5458 unlink the temporary file if Fcall_process didn't create it in the
5459 first place.
5460 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5461 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5462 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5463 cue to call_process_cleanup not to close that handle.
5464
4d3fcc8e
BK
54652011-05-07 Ben Key <bkey76@gmail.com>
5466
5467 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5468 one of two shell specific rules, either bootstrap-temacs-CMD or
5469 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5470 to the previous implementation of the bootstrap-temacs rule.
5471 The bootstrap-temacs-CMD rule is similar to the previous
5472 implementation of the bootstrap-temacs rule except that it
5473 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5474 variable.
5475
5476 These changes, along with some changes to nt/configure.bat,
5477 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5478 earlier fix to add support for --cflags and --ldflags options
5479 that include quotes so that it works whether make uses cmd or
5480 sh as the shell.
5481
b4289b64
MA
54822011-05-06 Michael Albinus <michael.albinus@gmx.de>
5483
5484 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5485 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5486 is a constant.
5487 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5488 a string. Handle both cases.
5489 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5490 (Fdbus_register_method): Use Qinvalid_function.
5491
af4c0e28
JB
54922011-05-06 Juanma Barranquero <lekktu@gmail.com>
5493
5494 * makefile.w32-in: Update dependencies.
5495 (LISP_H): Add inttypes.h and stdin.h.
5496 (PROCESS_H): Add unistd.h.
5497
c51453d9
EZ
54982011-05-06 Eli Zaretskii <eliz@gnu.org>
5499
5500 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5501 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5502
8ff0ac3c 55032011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5504
4c4b566b
PE
5505 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5506
aab2b9b5
PE
5507 * term.c (vfatal): Remove stray call to va_end.
5508 It's not needed and the C Standard doesn't allow it here anyway.
5509
c378da0b
PE
5510 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5511 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5512
288b08c7
PE
5513 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5514 bytes.
5515
e3601888
PE
5516 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5517
db6c0e74
PE
5518 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5519
dd5963ea
PE
5520 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5521
88c9450f
PE
5522 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5523
2f9442b8
PE
5524 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5525
c032b5f8
PE
5526 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5527 * charset.c (Fdefine_charset_internal): Don't initialize
5528 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5529 32-bit int (Bug#8600).
a108c10b
PE
5530
5531 * lread.c (read_integer): Be more consistent with string-to-number.
5532 Use string_to_number to do the actual conversion; this avoids
5533 rounding errors and fixes some other screwups. Without this fix,
5534 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5535 (digit_to_number): Move earlier, for benefit of read_integer.
5536 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5537 not a digit in any supported base. (Bug#8602)
a108c10b 5538
ad5f9eea
PE
5539 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5540
aec1708a
PE
5541 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5542 to match comment at start of function. This also removes a
5543 GCC warning about overflow in a 32+64-bit port.
5544
47be4ab5
PE
5545 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5546
371cac43
PE
5547 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5548 Reported by Stefan Monnier in
5549 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5550 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5551 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5552
d01a7826
PE
5553 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5554 (EMACS_UINTPTR): Likewise, with uintptr_t.
5555
7fd47d5c
PE
5556 * lisp.h: Prefer 64-bit EMACS_INT if available.
5557 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5558 on 32-bit hosts that have 64-bit int, so that they can access
5559 large files.
122b0c86
PE
5560 However, temporarily disable this change unless the temporary
5561 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5562
8727937b
PE
5563 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5564
8ac068ac
PE
5565 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5566 This removes an assumption that EMACS_INT and long are the same
5567 width as pointers. The assumption is true for Emacs porting targets
5568 now, but we want to make other targets possible.
5569 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5570 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5571 In the rest of the code, change types of integers that hold casted
5572 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5573 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5574 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5575 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5576 No need to cast type when ORing.
5577 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5578 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5579 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5580 assume EMACS_INT is the same width as char *.
5581 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5582 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5583 Remove no-longer-needed casts.
5584 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5585 (xg_tool_bar_help_callback, xg_make_tool_item):
5586 Use EMACS_INTPTR to hold an integer
5587 that will be cast to void *; this can avoid a GCC warning
5588 if EMACS_INT is not the same width as void *.
5589 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5590 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5591 (current_message_1, set_message_1):
5592 Use a local to convert to proper width without a cast.
5593 * xmenu.c (dialog_selection_callback): Likewise.
5594
ede49d71
PE
5595 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5596 Also, don't assume VALBITS / RAND_BITS is less than 5,
5597 and don't rely on undefined behavior when shifting a 1 left into
5598 the sign bit.
5599 * lisp.h (get_random): Change signature to match.
5600
2f30ecd0
PE
5601 * lread.c (hash_string): Use size_t, not int, for hash computation.
5602 Normally we prefer signed values; but hashing is special, because
5603 it's better to use unsigned division on hash table sizes so that
5604 the remainder is nonnegative. Also, size_t is the natural width
5605 for hashing into memory. The previous code used 'int', which doesn't
5606 retain enough info to hash well into very large tables.
5607 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5608
2a866e7b
PE
5609 * dbusbind.c: Don't possibly lose pointer info when converting.
5610 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5611 Use XPNTR rather than XHASH, so that the high-order bits of
5612 the pointer aren't lost when converting through void *.
5613
51639eac
PE
5614 * eval.c (Fautoload): Don't double-shift a pointer.
5615
92394119
PE
5616 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5617
dbdb9a7c
JB
56182011-05-06 Juanma Barranquero <lekktu@gmail.com>
5619
5620 * gnutls.c (DEF_GNUTLS_FN):
5621 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5622
db7a0b4f
AS
56232011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5624
5625 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5626 marker. (Bug#8610)
5627
f7ff1b0f 56282011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5629
5630 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5631 New version that can reserve upto 2GB of heap space.
5632
f7ff1b0f 56332011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5634
5635 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5636
639c109b
TZ
56372011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5638
5639 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5640 `gnutls_certificate_set_x509_key_file'.
5641
d2127135
JB
56422011-05-05 Juanma Barranquero <lekktu@gmail.com>
5643
5644 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5645 Update dependencies.
5646
e968f4f3
JB
56472011-05-04 Juanma Barranquero <lekktu@gmail.com>
5648
5649 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5650 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5651 Remove unused parameter `fildes'.
5652 * process.c (read_process_output, send_process): Don't pass it.
5653
84d358f0
JB
56542011-05-04 Juanma Barranquero <lekktu@gmail.com>
5655
5656 Fix previous change: the library cache is defined in w32.c.
5657 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5658 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5659
0898ca10
JB
56602011-05-04 Juanma Barranquero <lekktu@gmail.com>
5661
5662 Implement dynamic loading of GnuTLS on Windows.
5663
5664 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5665 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5666 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5667 Declare.
5668
5669 * gnutls.c (Qgnutls_dll): Define.
5670 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5671 (gnutls_*): Declare function pointers.
5672 (init_gnutls_functions): New function to initialize function pointers.
5673 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5674 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5675 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5676 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5677 (emacs_gnutls_write, emacs_gnutls_read)
5678 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5679 (Fgnutls_available_p): New function.
5680 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5681 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5682 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5683
5684 * image.c: Include w32.h.
5685 (Vimage_type_cache): Delete.
5686 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5687 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5688 (w32_delayed_load): Move to w32.c.
5689
5690 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5691
5692 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5693 (w32_delayed_load): Move from image.c. When loading a library, record
5694 its filename in the :loaded-from property of the library id.
5695 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5696 Initialize and staticpro them.
5697 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5698
5699 * process.c: Include lisp.h before w32.h, not after.
5700 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5701 instead of gnutls_record_check_pending.
5702
5703 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5704
ff4de4aa
TZ
57052011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5706
5707 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5708 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5709 as passed in.
5710
abe95abb
JD
57112011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5712
5713 * xterm.c (x_set_frame_alpha): Do not set property on anything
5714 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5715
e16e55d4
JB
57162011-05-02 Juanma Barranquero <lekktu@gmail.com>
5717
5718 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5719
bafcf6a5
JB
57202011-05-02 Juanma Barranquero <lekktu@gmail.com>
5721
5722 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5723 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5724 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5725 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5726 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5727 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5728 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5729 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5730 (Qgnutls_bootprop_callbacks_verify): Make static.
5731
e7a6747f
AS
57322011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5733
19ed11ba
AS
5734 * callproc.c: Indentation fixup.
5735
e7a6747f 5736 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5737 (wait_for_termination, interruptible_wait_for_termination):
5738 Move after wait_for_termination_1.
e7a6747f 5739
1ef14cb4
LMI
57402011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5741
5742 * sysdep.c (interruptible_wait_for_termination): New function
5743 which is like wait_for_termination, but allows keyboard
5744 interruptions.
5745
5746 * callproc.c (Fcall_process): Add (:file "file") as an option for
5747 the STDOUT buffer.
5748 (Fcall_process_region): Ditto.
5749
330d880c
EZ
57502011-04-30 Eli Zaretskii <eliz@gnu.org>
5751
8db90b73
EZ
5752 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5753 rather than `XVECTOR (FOO)->size'.
5754
330d880c
EZ
5755 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5756 inttypes.h, as a gnulib replacement is used if it not available in
5757 system headers.
5758
15cbd324
EZ
57592011-04-21 Eli Zaretskii <eliz@gnu.org>
5760
5761 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5762 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5763 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5764
5765 * coding.c (coding_alloc_by_realloc): Error out if destination
5766 will grow beyond MOST_POSITIVE_FIXNUM.
5767 (decode_coding_emacs_mule): Abort if there isn't enough place in
5768 charbuf for the composition carryover bytes. Reserve an extra
5769 space for up to 2 characters produced in a loop.
5770 (decode_coding_iso_2022): Abort if there isn't enough place in
5771 charbuf for the composition carryover bytes.
5772
57732011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5774
ae940cca
EZ
5775 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5776 aborting when %lld or %lll format is passed.
5777 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5778 %llo or %llx format is passed. (Bug#8545)
5779
03ab8921
EZ
5780 * window.c (window_scroll_line_based): Use a marker instead of
5781 simple variables to record original value of point. (Bug#7952)
5782
afda1437
EZ
5783 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5784 produced by %s or %c overflows available buffer space. (Bug#8545)
5785
f76dee0c
PE
57862011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5787
5788 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5789 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5790
fdc5744d
JB
57912011-04-28 Juanma Barranquero <lekktu@gmail.com>
5792
5793 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5794
638f053a
JB
57952011-04-28 Juanma Barranquero <lekktu@gmail.com>
5796
5797 * keyboard.c (Qdelayed_warnings_hook): Define.
5798 (command_loop_1): Run `delayed-warnings-hook'
5799 if Vdelayed_warnings_list is non-nil.
5800 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5801 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5802
d178f871
EZ
58032011-04-28 Eli Zaretskii <eliz@gnu.org>
5804
5805 * doprnt.c (doprnt): Don't return value smaller than the buffer
5806 size if the message was truncated. (Bug#8545).
5807
b124fd93
JB
58082011-04-28 Juanma Barranquero <lekktu@gmail.com>
5809
5810 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5811 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5812
e810457d
PE
58132011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5814
5815 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5816
ea51cceb
JB
58172011-04-27 Juanma Barranquero <lekktu@gmail.com>
5818
5819 * makefile.w32-in: Update dependencies.
5820
94dcfacf
EZ
58212011-04-27 Eli Zaretskii <eliz@gnu.org>
5822
5823 Improve `doprnt' and its usage. (Bug#8545)
5824 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5825 `format_end'. Remove support for %l as a conversion specifier.
5826 Don't use xrealloc. Improve diagnostics when the %l size modifier
5827 is used. Update the commentary.
5828
5829 * eval.c (verror): Simplify calculation of size_t.
5830
5831 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5832 messages.
5833
f61f41d7
PE
58342011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5835
5836 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5837 change.
5838
96fb4434
PE
58392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5840
5841 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5842 This makes this file independent of the recent pseudovector change.
5843
671875da 58442011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5845
69e9b5a3
PE
5846 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5847
b5f869a7 5848 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5849 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5850 Remove unused local.
c8926152 5851 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5852
841a1577 5853 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5854 GCC 4.6.0 optimizes based on type-based alias analysis.
5855 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5856 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5857 != &v->size, and therefore "v->size = 1; b->size = 2; return
5858 v->size;" must therefore return 1. This assumption is incorrect
5859 for Emacs, since it type-puns struct Lisp_Vector * with many other
5860 types. To fix this problem, this patch adds a new type struct
f904488f 5861 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5862 and pseudovectors, and helps optimizing compilers not get fooled
5863 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5864 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5865 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5866 the size member.
eab3844f
PE
5867 (XSETPVECTYPE): Rewrite in terms of new macro.
5868 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5869 This is a bit clearer, and further avoids the possibility of
5870 undesirable aliasing.
5871 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5872 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5873 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5874 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5875 (ASIZE): Now uses header.size rather than size.
5876 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5877 to avoid the hassle of writing XVECTOR (foo)->header.size.
5878 (struct vectorlike_header): New type.
eab3844f
PE
5879 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5880 object, to help avoid aliasing.
5881 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5882 (SUBRP): Likewise, since Lisp_Subr is a special case.
5883 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5884 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5885 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5886 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5887 changed to be "header.size" and "header.next".
5888 * buffer.h (struct buffer): Likewise.
5889 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5890 * frame.h (struct frame): Likewise.
5891 * process.h (struct Lisp_Process): Likewise.
5892 * termhooks.h (struct terminal): Likewise.
5893 * window.c (struct save_window_data, struct saved_window): Likewise.
5894 * window.h (struct window): Likewise.
5895 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5896 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5897 * buffer.c (init_buffer_once): Likewise.
5898 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5899 special case.
5900 * process.c (Fformat_network_address): Use local var for size,
5901 for brevity.
5902
0df1eac5
PE
5903 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5904
847ab9d1 5905 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5906 * data.c (atof): Remove decl; no longer used or needed.
5907 (digit_to_number): Move to lread.c.
5908 (Fstring_to_number): Use new string_to_number function, to be
5909 consistent with how the Lisp reader treats infinities and NaNs.
5910 Do not assume that floating-point numbers represent EMACS_INT
5911 without losing information; this is not true on most 64-bit hosts.
5912 Avoid double-rounding errors, by insisting on integers when
5913 parsing non-base-10 numbers, as the documentation specifies.
5914 * lisp.h (string_to_number): New decl, replacing ...
5915 (isfloat_string): Remove.
bc0a5c13 5916 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5917 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5918 appears to have been a coding error. Similarly, do not accept
5919 strings like +-1e0 as floating point numbers. Do not report
5920 overflow for integer overflows unless the base is not 10 which
5921 means we have no simple and reliable way to continue.
5922 Break out the floating-point parsing into a new
5923 function string_to_number, so that Fstring_to_number parses
5924 floating point numbers consistently with the Lisp reader.
04f2d78b 5925 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5926 (E_CHAR, EXP_INT): Remove, replacing with ...
5927 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5928 (string_to_number): New function, replacing isfloat_string.
5929 This function checks for valid syntax and produces the resulting
5930 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5931 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5932 so that overflow for non-base-10 numbers is reported only when
5933 there's no portable and simple way to convert to floating point.
452f4150 5934
67769ffc
PE
5935 * textprop.c (set_text_properties_1): Rewrite for clarity,
5936 and to avoid GCC warning about integer overflow.
5937
c20db43f
PE
5938 * intervals.h (struct interval): Use EMACS_INT for members
5939 where EMACS_UINT might cause problems. See
5940 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5941 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5942 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5943 All uses changed.
37aa2f85
PE
5944 (offset_intervals): Tell GCC not to worry about length overflow
5945 when negating a negative length.
c20db43f 5946
2538aa2f
PE
5947 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5948 (overrun_check_free): Likewise.
5949
f2d3008d
PE
5950 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5951 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5952 word size.
5953
ec8df744
PE
5954 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5955 (gnutls_make_error): Rename local to avoid shadowing.
5956 (gnutls_emacs_global_deinit): ifdef out; not used.
5957 (Fgnutls_boot): Use const for pointer to readonly storage.
5958 Comment out unused local. Fix pointer signedness problems.
5959
640ee02d
PE
5960 * lread.c (openp): Don't stuff size_t into an 'int'.
5961 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5962 about possible signed overflow.
5963
6048fb2a
PE
5964 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5965 (GDK_KEY_g): Don't define if already defined.
5966 (xg_prepare_tooltip): Avoid pointer signedness problem.
5967 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5968
fa3c87e1
PE
5969 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5970 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5971
2172544b
PE
5972 * xfns.c (Fx_window_property): Simplify a bit,
5973 to make a bit faster and to avoid GCC 4.6.0 warning.
5974 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5975
9b821a21
PE
5976 * fns.c (internal_equal): Don't assume size_t fits in int.
5977
3c616cfa
PE
5978 * alloc.c (compact_small_strings): Tighten assertion a little.
5979
c2982e87
PE
5980 Replace pEd with more-general pI, and fix some printf arg casts.
5981 * lisp.h (pI): New macro, generalizing old pEd macro to other
5982 conversion specifiers. For example, use "...%"pI"d..." rather
5983 than "...%"pEd"...".
5984 (pEd): Remove. All uses replaced with similar uses of pI.
5985 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5986 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5987 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5988 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5989 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5990 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5991 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5992 64-bit hosts.
5993 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5994 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5995 * print.c (safe_debug_print, print_object): Likewise.
5996 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5997 to int.
6f04d126
PE
5998 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5999 avoiding the 0 flag, which is not portable.
c2982e87
PE
6000 * process.c (Fmake_network_process): Use pI to avoid cast.
6001 * region-cache.c (pp_cache): Likewise.
6002 * xdisp.c (decode_mode_spec): Likewise.
6003 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6004 behavior on 64-bit hosts with printf arg.
6f04d126 6005 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6006 (x_stop_queuing_selection_requests): Likewise.
6007 (x_get_window_property): Don't truncate byte count to an 'int'
6008 when tracing.
0b432f21 6009
5e073ec7
PE
6010 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6011 here, since it parses constructs like leading '-' and spaces,
6012 which are not wanted; and it overflows with large numbers.
6013 Instead, simply match F[0-9]+, which is what is wanted anyway.
6014
36372bf9
PE
6015 * alloc.c: Remove unportable assumptions about struct layout.
6016 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6017 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6018 (allocate_vectorlike, make_pure_vector): Use the new macros,
6019 plus offsetof, to remove unportable assumptions about struct layout.
6020 These assumptions hold on all porting targets that I know of, but
6021 they are not guaranteed, they're easy to remove, and removing them
6022 makes further changes easier.
6023
0b432f21
PE
6024 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6025 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6026 (string_overrun_cookie): Now const. Use initializers that
6027 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6028 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6029 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6030 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6031 multiple of sizeof (EMACS_INT); it need not be, if
6032 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6033 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6034
895009e1
JB
60352011-04-26 Juanma Barranquero <lekktu@gmail.com>
6036
6037 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6038
6a7a1b0b
TZ
60392011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6040
6041 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6042 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6043 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6044
841a1577 60452011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6046
6047 * lisp.h (Qdebug): List symbol.
895009e1 6048 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6049 * keyboard.c (debug-on-event): New variable.
6050 (handle_user_signal): Break into debugger when debug-on-event
6051 matches the current signal symbol.
6052
f2d3ba6f
DN
60532011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6054
6055 * alloc.c (check_sblock, check_string_bytes)
6056 (check_string_free_list): Convert to standard C.
6057
42ce4c63
TZ
60582011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6059
6060 * w32.c (emacs_gnutls_push): Fix typo.
6061
825cd63c
EZ
60622011-04-25 Eli Zaretskii <eliz@gnu.org>
6063
fb11d64d
EZ
6064 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6065 "cast to pointer from integer of different size".
6066
825cd63c
EZ
6067 Improve doprnt and its use in verror. (Bug#8545)
6068 * doprnt.c (doprnt): Document the set of format control sequences
6069 supported by the function. Use SAFE_ALLOCA instead of always
6070 using `alloca'.
6071
6072 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6073 is one byte too soon. Don't use xrealloc; instead xfree and
6074 xmalloc anew.
6075
e061a11b
TZ
60762011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6077
6078 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6079 callbacks stage.
6080
6081 * gnutls.c: Renamed global_initialized to
6082 gnutls_global_initialized. Added internals for the
6083 :verify-hostname-error, :verify-error, and :verify-flags
6084 parameters of `gnutls-boot' and documented those parameters in the
6085 docstring. Start callback support.
9173deec
JB
6086 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6087 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6088 on error. Return error code.
e061a11b
TZ
6089 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6090 (emacs_gnutls_read): Likewise.
6091 (Fgnutls_boot): Return handshake error code.
6092 (emacs_gnutls_handle_error): New function.
6093 (wsaerror_to_errno): Likewise.
6094
6095 * w32.h (emacs_gnutls_pull): Add prototype.
6096 (emacs_gnutls_push): Likewise.
6097
6098 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6099 (emacs_gnutls_push): Likewise.
6100
61012011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6102
6103 * process.c (wait_reading_process_output): Check if GnuTLS
6104 buffered some data internally if no FDs are set for TLS
6105 connections.
6106
6107 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6108 (LIBS): Link to USER_LIBS.
6109 ($(BLD)/gnutls.$(0)): New target.
6110
fa6996bc
EZ
61112011-04-24 Eli Zaretskii <eliz@gnu.org>
6112
eb35682e
EZ
6113 * xdisp.c (handle_single_display_spec): Rename the
6114 display_replaced_before_p argument into display_replaced_p, to
6115 make it consistent with the commentary. Fix typos in the
6116 commentary.
6117
e2ad650c
EZ
6118 * textprop.c (syms_of_textprop): Remove dead code.
6119 (copy_text_properties): Delete obsolete commentary about an
6120 interface that was deleted long ago. Fix typos in the description
6121 of arguments.
6122
1b2de274
EZ
6123 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6124 to changes in oldXMenu/XMenu.h from 2011-04-16.
6125 <menu_help_message, prev_menu_help_message>: Constify.
6126 (IT_menu_make_room): menu->help_text is now `const char **';
6127 adjust.
6128
6129 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6130 to changes in oldXMenu/XMenu.h from 2011-04-16.
6131 (struct XMenu): Declare `help_text' `const char **'.
6132
6133 * xfaces.c <Qunspecified>: Make extern again.
6134
6135 * syntax.c: Include sys/types.h before including regex.h, as
6136 required by Posix.
6137
762b15be
EZ
6138 * doc.c (get_doc_string): Improve the format passed to `error'.
6139
6140 * doprnt.c (doprnt): Improve commentary.
6141
6142 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6143
6144 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6145 them with etags.
6146
f1052e5d
EZ
6147 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6148 changes in globals.h immediately force recompilation.
762b15be
EZ
6149 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6150 $(CURDIR)/s/ms-w32.h.
6151 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6152
fa6996bc
EZ
6153 * character.c (Fchar_direction): Function deleted.
6154 (syms_of_character): Don't defsubr it.
6155 <char-direction-table>: Deleted.
6156
e6c3da20
EZ
61572011-04-23 Eli Zaretskii <eliz@gnu.org>
6158
6159 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6160 * doprnt.c: Include limits.h.
6161 (SIZE_MAX): New macro.
04f2d78b
CB
6162 (doprnt): Return a size_t value. 2nd arg is now size_t.
6163 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6164 Improve overflow protection. Support `l' modifier for integer
6165 conversions. Support %l conversion. Don't assume an EMACS_INT
6166 argument for integer conversions and for %c.
6167
6168 * lisp.h (doprnt): Restore prototype.
6169
6170 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6171 $(SRC)/character.h.
6172
6173 * Makefile.in (base_obj): Add back doprnt.o.
6174
6175 * deps.mk (doprnt.o): Add back prerequisites.
6176 (callint.o): Depend on character.h.
6177
6178 * eval.c (internal_lisp_condition_case): Include the handler
6179 representation in the error message.
6180 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6181 when breaking from the loop.
6182
6183 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6184
6185 * callint.c (Fcall_interactively): When displaying error message
6186 about invalid control letter, pass the character's codepoint, not
6187 a pointer to its multibyte form. Improve display of the character
6188 in octal and display also its hex code.
6189
6190 * character.c (char_string): Use %x to display the (unsigned)
6191 codepoint of an invalid character, to avoid displaying a bogus
6192 negative value.
6193
6194 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6195 `error', not SYMBOL_NAME itself.
6196
6197 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6198 character arguments to `error'.
6199
6200 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6201 to `error' in error message about FINAL_CHAR argument. Make sure
6202 FINAL_CHAR is a character, and use %c when it is passed as
6203 argument to `error'.
6204
4ffd0d6b 62052011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6206
6207 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6208
6209 * w32.c: Include <time.h>.
6210 (sys_localtime): New function.
6211
4ffd0d6b 62122011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6213
6214 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6215
4ffd0d6b 6216 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6217
4ffd0d6b 62182011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6219
4ffd0d6b
GM
6220 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6221 zombies (Bug#8467).
aac0c6e3 6222
04c56954
EZ
62232011-04-19 Eli Zaretskii <eliz@gnu.org>
6224
6225 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6226 gl_state.e_property when gl_state.object is Qt.
6227
6228 * insdel.c (make_gap_larger): Remove limitation of buffer size
6229 to <= INT_MAX.
6230
16a43933
CY
62312011-04-18 Chong Yidong <cyd@stupidchicken.com>
6232
6233 * xdisp.c (lookup_glyphless_char_display)
6234 (produce_glyphless_glyph): Handle cons cell entry in
6235 glyphless-char-display.
6236 (Vglyphless_char_display): Document it.
6237
6238 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6239 glyphless-char-display.
6240
4581706e
CY
62412011-04-17 Chong Yidong <cyd@stupidchicken.com>
6242
6243 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6244
6245 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6246
6247 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6248 definition for no-X builds.
6249
4887c6e2 62502011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6251
fd35b6f9
PE
6252 Static checks with GCC 4.6.0 and non-default toolkits.
6253
5c1ccb01
PE
6254 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6255
006c5daa
PE
6256 * process.c (keyboard_bit_set): Define only if SIGIO.
6257 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6258 (send_process): Repair possible setjmp clobbering.
6259
efc736d3
PE
6260 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6261
4e2fe2e6
PE
6262 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6263
f97334a2
PE
6264 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6265
4e75f29d
PE
6266 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6267 Define only if needed.
6268
90efadd1
PE
6269 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6270 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6271 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6272
3c647824
PE
6273 * dispextern.h (struct redisplay_interface): Rename param
6274 to avoid shadowing.
e264f262 6275 * termhooks.h (struct terminal): Likewise.
761383f4 6276 * xterm.c (xembed_send_message): Likewise.
3c647824 6277
b58c5c4a
PE
6278 * insdel.c (make_gap_smaller): Define only if
6279 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6280
cad59032
PE
6281 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6282 it.
6283
c339dc2e
PE
6284 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6285 so that we aren't warned about unused symbols.
6286
91a3e27b
PE
6287 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6288
399c71d3 6289 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6290
8ffc96f5
PE
6291 * xfns.c (x_real_positions): Mark locals as initialized.
6292
eef9bc79
PE
6293 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6294
098db9dd
PE
6295 * xterm.c: Fix problems found by static analysis with other toolkits.
6296 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6297 (x_dispatch_event): Declare static if USE_GTK, and
6298 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6299 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6300 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6301 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6302 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6303
eb18f6cc
PE
6304 * xmenu.c (menu_help_callback): Pointer type fixes.
6305 Use const pointers when pointing at readonly data. Avoid pointer
6306 signedness clashes.
6307 (FALSE): Remove unused macro.
6308 (update_frame_menubar): Remove unused decl.
6309
1fe72bf8
PE
6310 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6311
60d9e1db
PE
6312 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6313 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6314 (single_menu_item): Rename local to avoid shadowing.
6315
39261c26
PE
6316 * keyboard.c (make_lispy_event): Remove unused local var.
6317
018c5e19
PE
6318 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6319 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6320
63d2b86e
PE
6321 * bitmaps: Change bitmaps from unsigned char back to the X11
6322 compatible char. Avoid the old compiler warnings about
6323 out-of-range initializers by using, for example, '\xab' rather
6324 than 0xab.
6325
aefd87e1
PE
6326 * xgselect.c (xgselect_initialize): Check vs interface
6327 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6328
bf501fb9
PE
6329 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6330
e9829fdf
PE
6331 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6332 to read-only memory.
6333
1086c095
PE
6334 * fns.c (vector): Remove; this old hack is no longer needed.
6335
2baccd04 6336 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6337 Remove unused var.
dde42981 6338 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6339
72391843 6340 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6341
436c16df 6342 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6343 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6344 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6345
92bb796d 6346 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6347 (x_term_init): Remove local to avoid shadowing.
92bb796d 6348
764430a3 6349 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6350
6351 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6352 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6353
d1dfb56c
EZ
63542011-04-16 Eli Zaretskii <eliz@gnu.org>
6355
c4354cb4
EZ
6356 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6357
d1dfb56c
EZ
6358 Fix regex.c, syntax.c and friends for buffers > 2GB.
6359 * syntax.h (struct gl_state_s): Declare character position members
6360 EMACS_INT.
6361
6362 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6363
04f2d78b
CB
6364 * textprop.c (verify_interval_modification, interval_of):
6365 Declare arguments EMACS_INT.
d1dfb56c
EZ
6366
6367 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6368 EMACS_INT.
6369
6370 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6371
6372 * indent.c (Fvertical_motion): Local variable it_start is now
6373 EMACS_INT.
6374
6375 * regex.c (re_match, re_match_2, re_match_2_internal)
6376 (bcmp_translate, regcomp, regexec, print_double_string)
6377 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6378 (re_compile_pattern, re_exec): Declare arguments and local
6379 variables `size_t' and `ssize_t' and return values `regoff_t', as
6380 appropriate.
6381 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6382 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6383 <compile_stack_type>: `size' and `avail' are now `size_t'.
6384
6385 * regex.h <regoff_t>: Use ssize_t, not int.
6386 (re_search, re_search_2, re_match, re_match_2): Arguments that
6387 specify buffer/string position and length are now ssize_t and
6388 size_t. Return type is regoff_t.
6389
613052cd
BK
63902011-04-16 Ben Key <bkey76@gmail.com>
6391
6392 * nsfont.m: Fixed bugs in ns_get_family and
6393 ns_descriptor_to_entity that were caused by using free to
6394 deallocate memory blocks that were allocated by xmalloc (via
6395 xstrdup). This caused Emacs to crash when compiled with
6396 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6397 --enable-checking=xmallocoverrun). xfree is now used to
6398 deallocate these memory blocks.
6399
4170f62f 64002011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6401
71b41406
PE
6402 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6403
9587a89d
PE
6404 emacs_write: Accept and return EMACS_INT for sizes.
6405 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6406 et seq.
6407 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6408 Accept and return EMACS_INT.
6409 (emacs_gnutls_write): Return the number of bytes written on
6410 partial writes.
6411 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6412 (emacs_read, emacs_write): Remove check for negative size, as the
6413 Emacs source code has been audited now.
9587a89d
PE
6414 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6415 (emacs_read, emacs_write): Use it.
273a5f82
PE
6416 * process.c (send_process): Adjust to the new signatures of
6417 emacs_write and emacs_gnutls_write. Do not attempt to store
6418 a byte offset into an 'int'; it might overflow.
9587a89d 6419 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6420
3e047f51
PE
6421 * sound.c: Don't assume sizes fit in 'int'.
6422 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6423 Return EMACS_INT, not int.
3e047f51 6424 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6425 Accept EMACS_INT, not int.
6426 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6427 record read return values.
6428
cc39a9db
BK
64292011-04-15 Ben Key <bkey76@gmail.com>
6430
c9d0ec6d
JB
6431 * keyboard.c (Qundefined): Don't declare static since it is used
6432 in nsfns.m.
6433 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6434 static since they are used in nsfont.m.
cc39a9db 6435
6c60eb9f
SM
64362011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6437
6438 * process.c (Qprocessp): Don't declare static.
6439 * lisp.h (Qprocessp): Declare again.
6440
7990b61a
JB
64412011-04-15 Juanma Barranquero <lekktu@gmail.com>
6442
6443 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6444
5d4cb038
PE
64452011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6446
8bd7b830 6447 Improve C-level modularity by making more things 'static'.
cd64ea1d 6448
e3b27b31
PE
6449 Don't publish debugger-only interfaces to other modules.
6450 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6451 (verify_bytepos, count_markers): Move decls to the only modules
6452 that need them.
6453 * region-cache.h (pp_cache): Likewise.
6454 * window.h (check_all_windows): Likewise.
6455 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6456
5d4cb038
PE
6457 * sysdep.c (croak): Now static, if
6458 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6459 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6460
6461 * alloc.c (refill_memory_reserve): Now static if
6462 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6463 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6464
e87b6180
PE
6465 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6466 Define only if USE_LUCID.
6467
ac64929e
PE
6468 * xrdb.c (x_customization_string, x_rm_string): Now static.
6469
6f37259d
PE
6470 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6471 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6472
1683e3ab
PE
6473 * xdisp.c (draw_row_with_mouse_face): Now static.
6474 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6475
de9c2632
PE
6476 * window.h (check_all_windows): Mark externally visible.
6477
2b96acb7
PE
6478 * window.c (window_deletion_count): Now static.
6479
6480 * undo.c: Make symbols static if they're not exported.
6481 (last_undo_buffer, last_boundary_position, pending_boundary):
6482 Now static.
6483
50436f33
PE
6484 * textprop.c (interval_insert_behind_hooks): Now static.
6485 (interval_insert_in_front_hooks): Likewise.
6486
64520e5c
PE
6487 * term.c: Make symbols static if they're not exported.
6488 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6489 (max_frame_lines, tty_set_terminal_modes):
6490 (tty_reset_terminal_modes, tty_turn_off_highlight):
6491 (get_tty_terminal): Now static.
6492 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6493 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6494 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6495 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6496 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6497
1fa53021
PE
6498 * sysdep.c: Make symbols static if they're not exported.
6499 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6500 Now static.
6501 (sigprocmask_set, full_mask): Remove; unused.
6502 (wait_debugging): Mark as visible.
6503 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6504 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6505
d4b43b22
PE
6506 * syntax.c (syntax_temp): Define only if !__GNUC__.
6507
b7c513d0
PE
6508 * sound.c (current_sound_device, current_sound): Now static.
6509
989b29ad
PE
6510 * search.c (searchbufs, searchbuf_head): Now static.
6511
13a55a78
PE
6512 * scroll.c (scroll_cost): Remove; unused.
6513 * dispextern.h (scroll_cost): Remove decl.
6514
de68a1fc
PE
6515 * region-cache.h (pp_cache): Mark as externally visible.
6516
40ccffa6
PE
6517 * process.c: Make symbols static if they're not exported.
6518 (process_tick, update_tick, create_process, chan_process):
6519 (Vprocess_alist, proc_buffered_char, datagram_access):
6520 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6521 (deactivate_process): Mark defn as static, as well as decl.
6522 * lisp.h (create_process): Remove decl.
6523 * process.h (chan_process, Vprocess_alist): Remove decls.
6524
ad64fc97
PE
6525 * print.c: Make symbols static if they're not exported.
6526 (print_depth, new_backquote_output, being_printed, print_buffer):
6527 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6528 (print_interval, print_number_index, initial_stderr_stream):
6529 Now static.
6530 * lisp.h (Fprinc): Remove decl.
6531 (debug_output_compilation_hack): Mark as externally visible.
6532
adddb265
PE
6533 * sysdep.c (croak): Move decl from here to syssignal.h.
6534 * syssignal.h (croak): Put it here, so the API can be checked when
6535 'croak' is called from dissociate_if_controlling_tty.
6536
1717ede2
PE
6537 * minibuf.c: Make symbols static if they're not exported.
6538 (minibuf_save_list, choose_minibuf_frame): Now static.
6539 * lisp.h (choose_minibuf_frame): Remove decl.
6540
fa5fb2bc
PE
6541 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6542
1e3890d1
PE
6543 * lread.c: Make symbols static if they're not exported.
6544 (read_objects, initial_obarray, oblookup_last_bucket_number):
6545 Now static.
6546 (make_symbol): Remove; unused.
6547 * lisp.h (initial_obarray, make_symbol): Remove decls.
6548
8a1414fa
PE
6549 * keyboard.c: Make symbols static if they're not exported.
6550 (single_kboard, recent_keys_index, total_keys, recent_keys):
6551 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6552 (this_single_command_key_start, echoing, last_auto_save):
6553 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6554 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6555 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6556 (Vlispy_mouse_stem, double_click_count):
6557 Now static.
6558 (force_auto_save_soon): Define only if SIGDANGER.
6559 (ignore_mouse_drag_p): Now static if
6560 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6561 (print_help): Remove; unused.
6562 (stop_character, last_timer_event): Mark as externally visible.
6563 * keyboard.h (ignore_mouse_drag_p): Declare only if
6564 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6565 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6566 * lisp.h (echoing): Remove decl.
6567 (force_auto_save_soon): Declare only if SIGDANGER.
6568 * xdisp.c (redisplay_window): Simplify code, to make it more
6569 obvious that ignore_mouse_drag_p is not accessed if !defined
6570 USE_GTK && !defined HAVE_NS.
6571
93ea6e8f
PE
6572 * intervals.c: Make symbols static if they're not exported.
6573 (merge_properties_sticky, merge_interval_right, delete_interval):
6574 Now static.
6575 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6576
77382fcc
PE
6577 * insdel.c: Make symbols static if they're not exported.
6578 However, leave prepare_to_modify_buffer alone. It's never
6579 called from outside this function, but that appears to be a bug.
6580 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6581 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6582 (adjust_after_replace_noundo): Remove; unused.
6583 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6584 (signal_before_change): Remove decls.
77382fcc 6585
9306c32e
PE
6586 * indent.c (val_compute_motion, val_vmotion): Now static.
6587
cd44d2eb
PE
6588 * image.c: Make symbols static if they're not exported.
6589 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6590 if USE_GTK.
6591 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6592 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6593
ad9a7a06
PE
6594 * fringe.c (standard_bitmaps): Now static.
6595 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6596
81626931
PE
6597 * frame.c: Make symbols static if they're not exported.
6598 (x_report_frame_params, make_terminal_frame): Now static.
6599 (get_frame_param): Now static, unless HAVE_NS.
6600 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6601 (x_get_resource_string): Remove; not used.
6602 * frame.h (make_terminal_frame, x_report_frame_params):
6603 (x_get_resource_string); Remove decls.
6604 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6605 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6606
239f9db9
PE
6607 * font.c, fontset.c: Make symbols static if they're not exported.
6608 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6609 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6610 * font.c (font_close_object): Now static.
6611 * font.h (font_close_object): Remove.
6612 * fontset.c (FONTSET_OBJLIST): Remove.
6613 (free_realized_fontset) #if-0 the body, which does nothing.
6614 (face_suitable_for_char_p): #if-0, as it's never called.
6615 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6616 * xfaces.c (face_at_string_position):
6617 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6618 since 0 is always ASCII.
6619
dfcf3579
PE
6620 * fns.c (weak_hash_tables): Now static.
6621
5045092b
PE
6622 * fileio.c: Make symbols static if they're not exported.
6623 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6624 (Vwrite_region_annotation_buffers): Now static.
6625
57a96f5c
PE
6626 * eval.c: Make symbols static if they're not exported.
6627 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6628 * lisp.h (backtrace_list): Remove decl.
6629
35f08c38
PE
6630 * emacs.c: Make symbols static if they're not exported.
6631 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6632 (fatal_error_code, fatal_error_signal_hook, standard_args):
6633 Now static.
6634 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6635 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6636 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6637 * lisp.h (fatal_error_signal_hook): Remove decl.
6638 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6639
f44bd759
PE
6640 * editfns.c: Move a (normally-unused) function to its only use.
6641 * editfns.c, lisp.h (get_operating_system_release): Remove.
6642 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6643 worth the hassle of breaking this out.
6644
b532497d
PE
6645 * xterm.c: Make symbols static if they're not exported.
6646 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6647 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6648 (x_destroy_window, x_delete_display):
6649 Now static.
6650 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6651 (x_mouse_leave): Remove; unused.
6652 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6653 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6654 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6655 Remove decls.
6656 (x_mouse_leave): Declare only if WINDOWSNT.
6657 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6658 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6659 USE_X_TOOLKIT.
6660
1675728f
PE
6661 * ftxfont.c: Make symbols static if they're not exported.
6662 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6663 HAVE_FREETYPE.
6664 * font.h (ftxfont_driver): Likewise.
6665
e4cebfca
PE
6666 * xfns.c: Make symbols static if they're not exported.
6667 (x_last_font_name, x_display_info_for_name):
6668 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6669 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6670 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6671 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6672 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6673 (last_show_tip_args): Now static.
6674 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6675 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6676 (x_screen_planes): Remove; unused.
6677 * dispextern.h (x_screen_planes): Remove decl.
6678
5bf46f05
PE
6679 * dispnew.c: Make symbols static if they're not exported.
6680 * dispextern.h (redraw_garbaged_frames, scrolling):
6681 (increment_row_positions): Remove.
6682 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6683 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6684 Now static.
6685 (redraw_garbaged_frames): Remove; unused.
6686
435f4c28
PE
6687 * xfaces.c: Make symbols static if they're not exported.
6688 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6689 Remove decls.
6690 * xterm.h (defined_color): Remove decls.
6691 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6692 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6693 (menu_face_changed_default, defined_color, free_realized_face):
6694 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6695 (ascii_face_of_lisp_face): Remove; unused.
6696
8524aef3
PE
6697 * xdisp.c: Make symbols static if they're not exported.
6698 * dispextern.h (scratch_glyph_row, window_box_edges):
6699 (glyph_to_pixel_coords, set_cursor_from_row):
6700 (get_next_display_element, set_iterator_to_next):
6701 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6702 (show_mouse_face): Remove decls
6703 * frame.h (message_buf_print): Likewise.
6704 * lisp.h (pop_message, set_message, check_point_in_composition):
6705 Likewise.
6706 * xterm.h (set_vertical_scroll_bar): Likewise.
6707 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6708 (message_buf_print, scratch_glyph_row, displayed_buffer):
6709 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6710 (get_next_display_element, show_mouse_face, window_box_edges):
6711 (frame_to_window_pixel_xy, check_point_in_composition):
6712 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6713 (glyph_to_pixel_coords): Remove; unused.
6714
16390cd2
PE
6715 * dired.c (file_name_completion): Now static.
6716
6717 * dbusbind.c (xd_in_read_queued_messages): Now static.
6718
a25f4dfa
PE
6719 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6720 * data.c (circular_list_error): Remove.
6721
14a9c8df
PE
6722 * commands.h (last_point_position, last_point_position_buffer):
6723 (last_point_position_window): Remove decls.
6724 * keyboard.c: Make these variables static.
6725
04f2d78b
CB
6726 * coding.h (coding, code_convert_region, encode_coding_gap):
6727 Remove decls.
74ab6df5
PE
6728 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6729 (iso_code_class, detect_coding, code_convert_region): Now static.
6730 (encode_coding_gap): Remove; unused.
6731
38dfbee1
PE
6732 * chartab.c (chartab_chars, chartab_bits): Now static.
6733
a2cb4e63
PE
6734 * charset.h (charset_iso_8859_1): Remove decl.
6735 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6736 Now static.
6737
127198fd
PE
6738 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6739 * ccl.c (Vccl_program_table): Now static.
6740 (check_ccl_update): Remove; unused.
6741
d85b608f
PE
6742 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6743 * category.h: ... from here.
6744 * category.c (check_category_table, set_category_set): Now static.
6745
31cd66f3
PE
6746 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6747 * lisp.h: Remove these decls.
6748
c358e587
PE
6749 * buffer.c (buffer_count): Remove unused var.
6750
e78aecca
PE
6751 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6752 so that it's not optimized away.
6753 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6754 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6755 exported only to the debugger.
6756
e192d7d3 6757 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6758 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6759
92470028
PE
6760 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6761 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6762 was inaccessible from Lisp.
6763 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6764 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6765
244ed907
PE
6766 alloc.c: Import and export fewer symbols, and remove unused items.
6767 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6768 is defined.
6769 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6770 it's not optimized away by whole-program optimization.
6771 (message_enable_multibyte, free_misc): Remove.
6772 (catchlist, handlerlist, mark_backtrace):
6773 Declare only if BYTE_MARK_STACK.
6774 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6775 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6776 (message_enable_multibyte): Remove decl.
6777 (free_misc, interval_free_list, float_block, float_block_index):
6778 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6779 (cons_free_list, last_marked_index):
6780 Now static.
6781 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6782 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6783 (mark_backtrace): Define only if BYTE_MARK_STACK.
6784 * xdisp.c (message_enable_multibyte): Now static.
6785
61c2b50e 6786 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6787 This makes it easier for human readers (and static analyzers)
6788 to see whether these variables are used from other modules.
6789 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6790 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6791 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6792 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6793 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6794 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6795 * xmenu.c, xselect.c:
6796 Declare Q* vars static if they are not used in other modules.
6797 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6798 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6799 Remove decls of unexported vars.
6800 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6801
95c82688
PE
6802 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6803
16a97296
PE
6804 Make Emacs functions such as Fatom 'static' by default.
6805 This makes it easier for human readers (and static analyzers)
6806 to see whether these functions can be called from other modules.
6807 DEFUN now defines a static function. To make the function external
6808 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6809 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6810 (Finit_image_library):
16a97296
PE
6811 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6812 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6813 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6814 Remove decls, since these functions are now static.
6815 (Funintern, Fget_internal_run_time): New decls, since these functions
6816 were already external.
95c82688 6817
16a97296
PE
6818 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6819 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6820 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6821 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6822 * keyboard.c, keymap.c, lread.c:
6823 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6824 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6825 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6826 Mark functions with DEFUE instead of DEFUN,
6827 if they are used in other modules.
6828 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6829 decls for now-static functions.
6830 * buffer.h (Fdelete_overlay): Remove decl.
6831 * callproc.c (Fgetenv_internal): Mark as internal.
6832 * composite.c (Fremove_list_of_text_properties): Remove decl.
6833 (Fcomposition_get_gstring): New forward static decl.
6834 * composite.h (Fcomposite_get_gstring): Remove decl.
6835 * dired.c (Ffile_attributes): New forward static decl.
6836 * doc.c (Fdocumntation_property): New forward static decl.
6837 * eval.c (Ffetch_bytecode): New forward static decl.
6838 (Funintern): Remove extern decl; now in .h file where it belongs.
6839 * fileio.c (Fmake_symbolic_link): New forward static decl.
6840 * image.c (Finit_image_library): New forward static decl.
6841 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6842 * intervals.h (Fprevious_property_change):
6843 (Fremove_list_of_text_properties): Remove decls.
6844 * keyboard.c (Fthis_command_keys): Remove decl.
6845 (Fcommand_execute): New forward static decl.
6846 * keymap.c (Flookup_key): New forward static decl.
6847 (Fcopy_keymap): Now static.
6848 * keymap.h (Flookup_key): Remove decl.
6849 * process.c (Fget_process): New forward static decl.
6850 (Fprocess_datagram_address): Mark as internal.
6851 * syntax.c (Fsyntax_table_p): New forward static decl.
6852 (skip_chars): Remove duplicate decl.
6853 * textprop.c (Fprevious_property_change): New forward static decl.
6854 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6855 Now internal.
6856 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6857 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6858
785bbd42
PE
6859 * editfns.c (Fformat): Remove unreachable code.
6860
8b913b57
AS
68612011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6862
6863 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6864 change. (Bug#8496)
6865
a6744a35
EZ
68662011-04-13 Eli Zaretskii <eliz@gnu.org>
6867
6868 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6869 when at ZV. (Bug#8487)
6870
e7974947
AS
68712011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6872
baad03f0
AS
6873 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6874 (Bug#8437)
6875 * keyboard.c (parse_tool_bar_item): Likewise.
6876 * sound.c (sound_cleanup, alsa_close): Likewise.
6877 * termcap.c (tgetent): Likewise.
6878 * xfns.c (x_default_font_parameter): Likewise.
6879 * xsettings.c (read_and_apply_settings): Likewise.
6880
e7974947
AS
6881 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6882 (overrun_check_free): Protoize.
6883
28272684
PE
68842011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6885
6886 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6887 since callers should never pass a negative size.
6888 Change the signature to match that of plain 'read' and 'write'; see
6889 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6890 * lisp.h: Update prototypes of emacs_write and emacs_read.
6891
11997c76
EZ
68922011-04-11 Eli Zaretskii <eliz@gnu.org>
6893
6894 * xdisp.c (redisplay_window): Don't try to determine the character
6895 position of the scroll margin if the window start point w->startp
e896f03c 6896 is outside the buffer's accessible region. (Bug#8468)
11997c76 6897
8a2cbd72
EZ
68982011-04-10 Eli Zaretskii <eliz@gnu.org>
6899
6900 Fix write-region and its subroutines for buffers > 2GB.
6901 * fileio.c (a_write, e_write): Modify declaration of arguments and
6902 local variables to support buffers larger than 2GB.
6903 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6904
6905 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6906 argument, local variables, and return value.
6907
6908 * lisp.h: Update prototypes of emacs_write and emacs_read.
6909
6910 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6911
4073e537 69122011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6913
1ebfdcb6
PE
6914 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6915
b2ded58d
PE
6916 Fix more problems found by GCC 4.6.0's static checks.
6917
7d66342c
PE
6918 * xdisp.c (vmessage): Use a better test for character truncation.
6919
bbf47d44
PE
6920 * charset.c (load_charset_map): <, not <=, for optimization,
6921 and to avoid potential problems with integer overflow.
9248994d 6922 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6923 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6924 * editfns.c (Fformat): Likewise.
1e69125e 6925 * syntax.c (skip_chars): Likewise.
3befa583 6926
e3019616
PE
6927 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6928 This also lets GCC 4.6.0 generate slightly better loop code.
6929
becfa255
PE
6930 * callint.c (Fcall_interactively): <, not <=, for optimization.
6931 (Fcall_interactively): Count the number of arguments produced,
6932 not the number of arguments given. This is simpler and lets GCC
6933 4.6.0 generate slightly better code.
6934
dae0cd48
PE
6935 * ftfont.c: Distingish more carefully between FcChar8 and char.
6936 The previous code passed unsigned char * to a functions like
6937 strlen and xstrcasecmp that expect char *, which does not
6938 conform to the C standard.
6939 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6940 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6941 char * when the C standard requires it.
6942
76032d70
PE
6943 * keyboard.c (read_char): Remove unused var.
6944
eb3f1cc8
PE
6945 * eval.c: Port to Windows vsnprintf (Bug#8435).
6946 Include <limits.h>.
6947 (SIZE_MAX): Define if the headers do not.
6948 (verror): Do not give up if vsnprintf returns a negative count.
6949 Instead, grow the buffer. This ports to Windows vsnprintf, which
6950 does not conform to C99. Problem reported by Eli Zaretskii.
6951 Also, simplify the allocation scheme, by avoiding the need for
6952 calling realloc, and removing the ALLOCATED variable.
6953
70476b54
PE
6954 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6955
12020a9e
PE
6956 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6957 But keep the doprint source code for now, as we might revamp it
6958 and use it again (Bug#8435).
ea6c7ae6
PE
6959 * lisp.h (doprnt): Remove.
6960 * Makefile.in (base_obj): Remove doprnt.o.
6961 * deps.mk (doprnt.o): Remove.
6962
5fdb398c
PE
6963 error: Print 32- and 64-bit integers portably (Bug#8435).
6964 Without this change, on typical 64-bit hosts error ("...%d...", N)
6965 was used to print both 32- and 64-bit integers N, which relied on
6966 undefined behavior.
6967 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6968 New macro.
6969 * lisp.h (error, verror): Mark as printf-like functions.
6970 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6971 Report overflow in size calculations when allocating printf buffer.
6972 Do not truncate output string at its first null byte.
6973 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6974 Truncate the output at a character boundary, since vsnprintf does not
6975 do that.
6976 * charset.c (check_iso_charset_parameter): Convert internal
6977 character to string before calling 'error', since %c now has the
6978 printf meaning.
6979 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6980 overflow when computing char to be passed to 'error'. Do not
6981 pass Lisp_Object to 'error'; pass the integer instead.
6982 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6983 formatted with plain %d.
6984
b189fa66
PE
6985 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6986
bff87ef0
PE
6987 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6988
7e2cac20
PE
6989 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6990
ce4d90b5
PE
6991 * xterm.c (x_catch_errors): Remove duplicate declaration.
6992
266c9547
PE
6993 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6994
79c49ad2
PE
6995 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6996
368f4090
JM
69972011-04-10 Jim Meyering <meyering@redhat.com>
6998
6999 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7000 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7001 return ssize_t not "int", and use size_t as the buffer length.
7002 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7003 * gnutls.h: Update declarations.
7004 * process.c (read_process_output): Use ssize_t, to match.
7005 (send_process): Likewise.
7006
a32d4040
CY
70072011-04-09 Chong Yidong <cyd@stupidchicken.com>
7008
7009 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7010
8546720e 70112011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7012
04f2d78b
CB
7013 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7014 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7015
8546720e
GM
7016 * xterm.c (handle_one_xevent):
7017 * xmenu.c (create_and_show_popup_menu):
7018 * xselect.c (x_decline_selection_request)
7019 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7020
0a2f5c1a 70212011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7022
7023 Fix some uses of `int' instead of EMACS_INT.
7024 * search.c (string_match_1, fast_string_match)
7025 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7026 (scan_buffer, find_next_newline_no_quit)
7027 (find_before_next_newline, search_command, Freplace_match)
7028 (Fmatch_data): Make some `int' variables be EMACS_INT.
7029
7030 * xdisp.c (display_count_lines): 3rd argument and return value now
7031 EMACS_INT. All callers changed.
7032 (pint2hrstr): Last argument is now EMACS_INT.
7033
7034 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7035 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7036 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7037 (decode_coding_utf_16, decode_coding_emacs_mule)
7038 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7039 (decode_coding_ccl, decode_coding_charset)
7040 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7041 (decode_coding_iso_2022, decode_coding_emacs_mule)
7042 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7043 <char_offset, last_offset>: Declare EMACS_INT.
7044 (encode_coding_utf_8, encode_coding_utf_16)
7045 (encode_coding_emacs_mule, encode_invocation_designation)
7046 (encode_designation_at_bol, encode_coding_iso_2022)
7047 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7048 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7049 Declare EMACS_INT.
7050 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7051 (encode_invocation_designation): Last argument P_NCHARS is now
7052 EMACS_INT.
7053 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7054 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7055
7056 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7057 All users changed.
7058
7059 * ccl.c (Fccl_execute_on_string): Declare some variables
7060 EMACS_INT.
7061
8546720e 70622011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7063
7064 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7065
4e19a977
CS
70662011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7067
7068 * process.c (Fformat_network_address): Doc fix.
7069
87302331
R
70702011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7071
7072 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7073
cbb59342
CY
70742011-04-08 Chong Yidong <cyd@stupidchicken.com>
7075
7076 * keyboard.c (read_char): Call Lisp function help-form-show,
7077 instead of using internal_with_output_to_temp_buffer.
7078 (Qhelp_form_show): New var.
e0d38eeb 7079 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7080
7081 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7082
7083 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7084
e67a13ab
CY
70852011-04-06 Chong Yidong <cyd@stupidchicken.com>
7086
04f2d78b
CB
7087 * process.c (Flist_processes): Remove to Lisp.
7088 (list_processes_1): Delete.
e67a13ab 7089
973f782d
EZ
70902011-04-06 Eli Zaretskii <eliz@gnu.org>
7091
7c106b1e
EZ
7092 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7093
973f782d
EZ
7094 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7095
41cf7d1a 70962011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7097
ca23cc88
PE
7098 Fix more problems found by GCC 4.6.0's static checks.
7099
f390e2d5
PE
7100 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7101
42eea0d0
PE
7102 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7103
b69769da 7104 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7105
f9541e84
PE
7106 * xdisp.c (vmessage): Mark as a printf-like function.
7107
13841b55
PE
7108 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7109
c136c10f
PE
7110 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7111
5e2d4a30
PE
7112 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7113 printf-like functions.
7114 (tiff_load): Add casts to remove these marks before passing them
7115 to system-supplied API.
7116
583f48b9
PE
7117 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7118
b25d760e
PE
7119 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7120 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7121 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7122 directly, rather than having caller test rule sign. This avoids
7123 some unnecessary tests.
7124 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7125 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7126 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7127
bc7b6697 7128 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7129 (xfont_open): Avoid unnecessary tests.
bc7b6697 7130
27ccc379
PE
7131 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7132
dcd5c89a
PE
7133 * composite.h, composite.c (composition_gstring_put_cache):
7134 Use EMACS_INT, not int, for length.
7135
b13a45c6
PE
7136 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7137 breaking out part of COMPOSITION_DECODE_RULE.
7138 (COMPOSITION_DECODE_RULE): Use it.
7139 * composite.c (get_composition_id): Remove unused local vars,
7140 by using the new macro.
7141
1e792e4d
PE
7142 * textprop.c (set_text_properties_1): Change while to do-while,
7143 since the condition is always true at first.
7144
dc6c6455 7145 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7146 (interval_deletion_adjustment): Return unsigned value.
7147 All uses changed.
dc6c6455 7148
aba7731a
PE
7149 * process.c (list_processes_1, create_pty, read_process_output):
7150 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7151 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7152 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7153 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7154 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7155
fdfc4bf3
PE
7156 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7157
fca8fe46 7158 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7159 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7160
06a0259a 7161 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7162 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7163 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7164
e7b9e80f
PE
7165 * print.c (print_error_message): Avoid int overflow.
7166
56201685
PE
7167 * font.c (font_list_entities): Redo for clarity,
7168 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7169
78834453 7170 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7171 (font_score): Avoid potential overflow in diff calculation.
78834453 7172
0bc0b309 7173 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7174 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7175
e610eaca
PE
7176 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7177
b895abce
PE
7178 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7179 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7180 can always succeed if overflow has undefined behavior.
7181
1f1d9321 7182 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7183 (wordify): Omit three unnecessary tests.
1f1d9321 7184
c59478bc
PE
7185 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7186 All callers changed. This avoids the need for an unused var.
7187
79b73827
PE
7188 * casefiddle.c (casify_region): Remove var that is set but not used.
7189
a4db5dfe
PE
7190 * dired.c (file_name_completion): Remove var that is set but not used.
7191
43aae36e
PE
7192 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7193
2a47c44d 7194 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7195 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7196
a37c69bf
PE
7197 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7198 Check for integer overflow on size calculations.
7199
328ab8e7
PE
7200 * buffer.c (Fprevious_overlay_change): Remove var that is set
7201 but not used.
7202
e5a2a5cb
PE
7203 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7204 Remove vars that are set but not used.
8d84a6eb 7205 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7206 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7207
a60e5f68
PE
7208 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7209
f661cb61 7210 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7211 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7212
f0397f5a
PE
7213 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7214 that are set but not used.
7215
8664db06 7216 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7217 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7218
6abdaa4a
PE
7219 * xselect.c (x_get_local_selection, x_handle_property_notify):
7220 Remove vars that are set but not used.
7221
0ce7538d 7222 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7223 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7224
9ae848fc
PE
7225 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7226 Remove var that is set but not used.
0b918413
PE
7227 (scroll_bar_windows_size): Now size_t, not int.
7228 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7229 Check for overflow.
9ae848fc 7230
a5a62657
PE
7231 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7232 (map_tty_color) [!defined MSDOS]: Likewise.
7233
5c5cdd39
PE
7234 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7235
66ebf983
PE
7236 * coding.c: Remove vars that are set but not used.
7237 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7238 All callers changed.
7239 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7240 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7241 (decode_coding_charset): Remove vars that are set but not used.
7242
1be4d761
PE
7243 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7244 that is set but not used.
7245
47553fa8
PE
7246 * print.c (print_object): Remove var that is set but not used.
7247
1f7196bf 7248 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7249 The gnulib version avoids calling malloc in the usual case,
7250 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7251 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7252 * filelock.c (current_lock_owner): Likewise.
7253 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7254 * sysdep.c: Include allocator.h, careadlinkat.h.
7255 (emacs_no_realloc_allocator): New static constant.
7256 (emacs_readlink): New function.
fdb61804
PE
7257 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7258 ../lib/careadlinkat.h.
d1fdcab7 7259
f84c17c7
SM
72602011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7261
7262 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7263 first non-nil return value).
7264
ef3862ad
JD
72652011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7266
7267 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7268 if not defined (Bug#8403).
7269
376a7006
JB
72702011-04-02 Juanma Barranquero <lekktu@gmail.com>
7271
7272 * xdisp.c (display_count_lines): Remove parameter `start',
7273 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7274 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7275 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7276 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7277 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7278 and thereabouts. All callers changed.
7279 (get_per_char_metric): Remove parameter `f', unused since
7280 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7281
6ca3801d
JM
72822011-04-02 Jim Meyering <meyering@redhat.com>
7283
7284 do not dereference NULL upon failed strdup
7285 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7286 (ns_get_family): Likewise.
7287
d8e2b5ba
JB
72882011-04-02 Juanma Barranquero <lekktu@gmail.com>
7289
7290 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7291
8c74fcbd
JD
72922011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7293
7294 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7295 later (Bug#8403).
7296
7200d79c
SM
72972011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7298
03408648 7299 Add lexical binding.
7200d79c 7300
03408648
SM
7301 * window.c (Ftemp_output_buffer_show): New fun.
7302 (Fsave_window_excursion):
7303 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7304
7305 * lread.c (lisp_file_lexically_bound_p): New function.
7306 (Fload): Bind Qlexical_binding.
7307 (readevalloop): Remove `evalfun' arg.
7308 Bind Qinternal_interpreter_environment.
7309 (Feval_buffer): Bind Qlexical_binding.
7310 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7311 Mark as dynamic.
7312 (syms_of_lread): Declare `lexical-binding'.
7313
7314 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7315
7316 * keyboard.c (eval_dyn): New fun.
7317 (menu_item_eval_property): Use it.
ca105506
SM
7318
7319 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7320
03408648
SM
7321 * fns.c (concat, mapcar1): Accept byte-code-functions.
7322
7323 * eval.c (Fsetq): Handle lexical vars.
7324 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7325 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7326 (FletX, Flet): Obey lexical binding.
7327 (Fcommandp): Handle closures.
7328 (Feval): New `lexical' arg.
7329 (eval_sub): New function extracted from Feval. Use it almost
7330 everywhere where Feval was used. Look up vars in lexical env.
7331 Handle closures.
7332 (Ffunctionp): Move from subr.el.
7333 (Ffuncall): Handle closures.
7334 (apply_lambda): Remove `eval_flags'.
7335 (funcall_lambda): Handle closures and new byte-code-functions.
7336 (Fspecial_variable_p): New function.
7337 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7338 but without exporting it to Lisp.
23aba0ea 7339
23aba0ea 7340 * doc.c (Fdocumentation, store_function_docstring):
03408648 7341 * data.c (Finteractive_form): Handle closures.
23aba0ea 7342
03408648
SM
7343 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7344 interactive spec.
ba83908c 7345
04f2d78b
CB
7346 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7347 New byte-codes.
03408648
SM
7348 (exec_byte_code): New function extracted from Fbyte_code to handle new
7349 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7350
03408648 7351 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7352
03408648 7353 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7354
e2abce01
JB
73552011-03-31 Juanma Barranquero <lekktu@gmail.com>
7356
7357 * xdisp.c (redisplay_internal): Fix prototype.
7358
63696a73 73592011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7360
63696a73 7361 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7362 (try_scrolling): Use it when setting scroll_limit.
7363 Limit scrolling to 100 screen lines.
63696a73
EZ
7364 (redisplay_window): Even when falling back on "recentering",
7365 position point in the window according to scroll-conservatively,
7366 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7367
7368 (try_scrolling): When point is above the window, allow searching
7369 as far as scroll_max, or one screenful, to compute vertical
7370 distance from PT to the scroll margin position. This prevents
7371 try_scrolling from unnecessarily failing when
7372 scroll-conservatively is set to a value slightly larger than the
7373 window height. Clean up the case of PT below the margin at bottom
7374 of window: scroll_max can no longer be INT_MAX. When aggressive
7375 scrolling is in use, don't let point enter the opposite scroll
7376 margin as result of the scroll.
7377 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7378 threshold of 100 lines for never-recentering scrolling.
7379
e4cc2dfc
JB
73802011-03-31 Juanma Barranquero <lekktu@gmail.com>
7381
7382 * dispextern.h (move_it_by_lines):
7383 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7384 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7385 (message_log_check_duplicate): Remove parameters `prev_bol' and
7386 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7387 (redisplay_internal): Remove parameter `preserve_echo_area',
7388 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7389
7390 * indent.c (Fvertical_motion):
7391 * window.c (window_scroll_pixel_based, Frecenter):
7392 Don't pass `need_y_p' to `move_it_by_lines'.
7393
1c470562
SM
73942011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7395
44f230aa
SM
7396 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7397 steal a few bits to be more compact.
7398 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7399 Remove unneeded casts.
7400
1c470562
SM
7401 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7402
888adce9
ZK
74032011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7404
7405 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7406 binding" message (bug#7967).
7407
f838ed7b
PE
74082011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7409
77861b95
PE
7410 Fix more problems found by GCC 4.6.0's static checks.
7411
de6dbc14
PE
7412 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7413 Remove unused local var.
7414
f838ed7b
PE
7415 * editfns.c (Fmessage_box): Remove unused local var.
7416
792c7b2b
PE
7417 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7418 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7419 Omit unused local vars.
c499e557 7420 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7421 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7422 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7423 Omit unused local var.
7424
ba0165e1
PE
7425 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7426 Don't assume string length fits in int.
32ad8845 7427 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7428 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7429
3c59b4c9
PE
7430 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7431 instead of alloca (Bug#8344).
7432
a3eed478 7433 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7434 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7435
eb4d412d
PE
7436 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7437
1658b401
PE
7438 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7439 concerns.
7440
7441 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7442
7443 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7444
9a2c6e05
PE
7445 * keyboard.c (syms_of_keyboard): Use the same style as later
7446 in this function when indexing through an array. This also
7447 works around GCC bug 48267.
7448
03d0a109
PE
7449 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7450
44f730c8
PE
7451 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7452
fe75f926
PE
7453 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7454 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7455
ffa8c828
PE
7456 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7457 This avoids undefined behavior on integer overflow, and is a bit
7458 more convenient anyway since it is compared to a size_t variable.
7459
c5101a77
PE
7460 Variadic C functions now count arguments with size_t, not int.
7461 This avoids an unnecessary limitation on 64-bit machines, which
7462 caused (substring ...) to crash on large vectors (Bug#8344).
7463 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7464 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7465 All variadic functions and their callers changed accordingly.
c5101a77
PE
7466 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7467 * data.c (arith_driver, float_arith_driver): Likewise.
7468 * editfns.c (general_insert_function): Likewise.
7469 * eval.c (struct backtrace.nargs, interactive_p)
7470 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7471 (funcall_lambda, mark_backtrace): Likewise.
7472 * fns.c (concat): Likewise.
7473 * frame.c (x_set_frame_parameters): Likewise.
7474 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7475 0 if not found, not -1. All callers changed.
7476
dd3f25f7
PE
7477 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7478 (stack_copy_size): Now size_t, not int.
7479 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7480
461c2ab9
JB
74812011-03-28 Juanma Barranquero <lekktu@gmail.com>
7482
7483 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7484 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7485 All callers changed.
7486
7487 * lisp.h (multibyte_char_to_unibyte):
7488 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7489 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7490 * character.h (CHAR_TO_BYTE8):
7491 * cmds.c (internal_self_insert):
7492 * editfns.c (general_insert_function):
7493 * keymap.c (push_key_description):
7494 * search.c (Freplace_match):
7495 * xdisp.c (message_dolog, set_message_1): All callers changed.
7496
f6d62986
SM
74972011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7498
7499 * keyboard.c (safe_run_hook_funcall): New function.
7500 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7501 don't set the hook to nil, but remove the offending function instead.
7502 (Qcommand_hook_internal): Remove, unused.
7503 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7504 Vcommand_hook_internal.
7505
7506 * eval.c (enum run_hooks_condition): Remove.
7507 (funcall_nil, funcall_not): New functions.
7508 (run_hook_with_args): Call each function through a `funcall' argument.
7509 Remove `cond' argument, now redundant.
7510 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7511 (Frun_hook_with_args_until_failure): Adjust accordingly.
7512 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7513
1db5b1ad
JB
75142011-03-28 Juanma Barranquero <lekktu@gmail.com>
7515
7516 * dispextern.h (string_buffer_position): Remove declaration.
7517
7518 * print.c (strout): Remove parameter `multibyte', unused since
7519 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7520
7521 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7522 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7523 All callers changed.
7524
7525 * w32.c (_wsa_errlist): Use braces for struct initializers.
7526
7527 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7528 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7529 All callers changed.
7530 (string_buffer_position): Likewise. Also, make static (it's never
7531 used outside xdisp.c).
7532 (cursor_row_p): Remove parameter `w', unused since
7533 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7534 (decode_mode_spec): Remove parameter `precision', introduced during
7535 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7536 All callers changed.
7537
5ffb62aa
JD
75382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7539
7540 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7541
461c2ab9 75422011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7543
7544 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7545 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7546 (ns_update_auto_hide_menu_bar): New functions.
7547 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7548 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7549 ns_constrain_all_frames.
7550 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7551 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7552
5c380ffb
JD
75532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7554
7555 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7556
9af30bdf
GM
75572011-03-27 Glenn Morris <rgm@gnu.org>
7558
7559 * syssignal.h: Replace RETSIGTYPE with void.
7560 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7561 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7562 Replace SIGTYPE with void everywhere.
7563 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7564 * s/template.h (SIGTYPE): Remove commented out definition.
7565
e2abce01
JB
75662011-03-26 Eli Zaretskii <eliz@gnu.org>
7567
7568 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7569 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7570
f868cd8a
JB
75712011-03-26 Juanma Barranquero <lekktu@gmail.com>
7572
59eb0929
JB
7573 * w32.c (read_unc_volume): Use parameter `henum', instead of
7574 global variable `wget_enum_handle'.
7575
7576 * keymap.c (describe_vector): Remove parameters `indices' and
7577 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7578 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7579
f868cd8a
JB
7580 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7581
7582 * keyboard.c (timer_check): Remove parameter `do_it_now',
7583 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7584 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7585 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7586
7587 * keyboard.c (read_char):
7588 * w32menu.c (w32_menu_display_help):
7589 * xmenu.c (show_help_event, menu_help_callback):
7590 Adjust calls to `show_help_echo'.
7591
7592 * gtkutil.c (xg_maybe_add_timer):
7593 * keyboard.c (readable_events):
7594 * process.c (wait_reading_process_output):
7595 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7596
7597 * insdel.c (adjust_markers_gap_motion):
7598 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7599 (gap_left, gap_right): Don't call it.
7600
2ecf6fdb
CY
76012011-03-25 Chong Yidong <cyd@stupidchicken.com>
7602
7603 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7604 incurred during fontification.
7605
6b1f9ba4
JB
76062011-03-25 Juanma Barranquero <lekktu@gmail.com>
7607
7608 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7609 (DEFVAR_PER_BUFFER): Don't pass it.
7610
7611 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7612 (scrolling_window): Don't pass it.
7613
0f4a96b5
JB
76142011-03-25 Juanma Barranquero <lekktu@gmail.com>
7615
7616 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7617
7618 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7619 and `suffix'.
7620 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7621 of variables specific to SELinux and computation of `encoded_absname'.
7622
7623 * image.c (XPutPixel): Remove unused variable `height'.
7624
7625 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7626
7627 * unexw32.c (get_section_info): Remove unused variable `section'.
7628
7629 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7630 (system_process_attributes): Remove unused variable `sess'.
7631 (sys_read): Remove unused variable `err'.
7632
7633 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7634 (w32_wnd_proc): Remove unused variable `isdead'.
7635 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7636 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7637 (x_create_tip_frame): Remove unused variable `tem'.
7638
7639 * w32inevt.c (w32_console_read_socket):
7640 Remove unused variable `no_events'.
7641
7642 * w32term.c (x_draw_composite_glyph_string_foreground):
7643 Remove unused variable `width'.
7644
1149507c
JB
76452011-03-24 Juanma Barranquero <lekktu@gmail.com>
7646
7647 * w32term.c (x_set_glyph_string_clipping):
7648 Don't pass uninitialized region to CombineRgn.
7649
9c88f339
JB
76502011-03-23 Juanma Barranquero <lekktu@gmail.com>
7651
7652 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7653 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7654 (Fx_close_connection): Remove unused variable `i'.
7655
7656 * w32font.c (w32font_draw): Return number of glyphs.
7657 (w32font_open_internal): Remove unused variable `i'.
7658 (w32font_driver): Add missing initializer.
7659
7660 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7661 (fill_in_menu): Remove unused variable `items_added'.
7662
7663 * w32term.c (last_mouse_press_frame): Remove static global variable.
7664 (w32_clip_to_row): Remove unused variable `f'.
7665 (x_delete_terminal): Remove unused variable `i'.
7666
7667 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7668 (NOTHING): Remove unused static global variable.
7669 (uniscribe_check_otf): Remove unused variable `table'.
7670 (uniscribe_font_driver): Add missing initializers.
7671
dee091a3
JD
76722011-03-23 Julien Danjou <julien@danjou.info>
7673
7674 * term.c (Fsuspend_tty, Fresume_tty):
7675 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7676 * window.c (temp_output_buffer_show):
7677 * insdel.c (signal_before_change):
7678 * frame.c (Fhandle_switch_frame):
7679 * fileio.c (Fdo_auto_save):
7680 * emacs.c (Fkill_emacs):
7681 * editfns.c (save_excursion_restore):
7682 * cmds.c (internal_self_insert):
7683 * callint.c (Fcall_interactively):
7684 * buffer.c (Fkill_all_local_variables):
7685 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7686 Use Frun_hooks.
0f4a96b5 7687 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7688 unconditionnaly since it does the check itself.
7689
2c520ab5 76902011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7691
c9c49752
PE
7692 Fix more problems found by GCC 4.5.2's static checks.
7693
8abc3f12
PE
7694 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7695 the first time through the loop, since we know p0 < p1 then.
7696 This also avoids a gcc -Wstrict-overflow warning.
7697
a2d26660
PE
7698 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7699 leading to a memory leak, possible in functions like
7700 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7701 of objects (Bug#8318).
a2d26660 7702
916c72e9
PE
7703 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7704 that could (at least in theory) be that large.
7705
19ab8a18
PE
7706 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7707 This is less likely to overflow, and avoids undefined behavior if
7708 overflow does occur. All callers changed. Use strtoul to scan
7709 for the unsigned long integer.
b7cbbd6f
PE
7710 (pint2hrstr): Simplify and tune code slightly.
7711 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7712
f0641eff
PE
7713 * scroll.c (do_scrolling): Work around GCC bug 48228.
7714 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7715
7f650bb9
PE
7716 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7717 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7718 (validate_x_resource_name): Simplify count usage.
7719 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7720
37dd57d1
PE
7721 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7722 fail (Bug#8306).
81e56e61 7723
699979fc 7724 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7725
401bf9b4
PE
7726 * process.c (Fmake_network_process): Use socklen_t, not int,
7727 where POSIX says socklen_t is required in portable programs.
7728 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7729 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7730 (Fmake_network_process, server_accept_connection):
7731 (wait_reading_process_output, read_process_output):
7732 Likewise.
7733
b93aacde
PE
7734 * process.c: Rename or move locals to avoid shadowing.
7735 (list_processes_1, Fmake_network_process):
7736 (read_process_output_error_handler, exec_sentinel_error_handler):
7737 Rename or move locals.
4dc343ee 7738 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7739 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7740 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7741 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7742 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7743
af8a867c 7744 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7745 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7746 Include tparam.h instead, since it declares them.
af8a867c
PE
7747 * cm.h (PC): Remove extern decl; tparam.h now does this.
7748 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7749 * terminfo.c: Include tparam.h, to check interfaces.
7750 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7751 (tparam): Adjust signature to match interface in tparam.h;
7752 this removes some undefined behavior. Check that outstring and len
7753 are zero, which they always are with Emacs.
7754 * tparam.h (PC, BC, UP): New extern decls.
7755
0248044d 7756 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7757 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7758
8ff096c1 7759 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7760 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7761 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7762 (ftfont_list): Remove unused local.
49eaafba
PE
7763 (get_adstyle_property, ftfont_pattern_entity):
7764 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7765 Rename locals to avoid shadowing.
8ff096c1 7766
e2be39f6
PE
7767 * xfont.c (xfont_list_family): Mark var as initialized.
7768
c9735e30
PE
7769 * xml.c (make_dom): Now static.
7770
8f5201ae
PE
7771 * composite.c (composition_compute_stop_pos): Rename local to
7772 avoid shadowing.
b246f932
PE
7773 (composition_reseat_it): Remove unused locals.
7774 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7775 (composition_update_it): Mark var as initialized.
11b61122
PE
7776 (find_automatic_composition): Mark vars as initialized,
7777 with a FIXME (Bug#8290).
8f5201ae 7778
760fbc2c
PE
7779 character.h: Rename locals to avoid shadowing.
7780 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7781 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7782 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7783 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7784 to avoid shadowing.
7785
ff08eb85
PE
7786 * textprop.c (property_change_between_p): Remove; unused.
7787
fc7bf025
PE
7788 * intervals.c (interval_start_pos): Now static.
7789
235d7abc
PE
7790 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7791
44f230aa
SM
7792 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7793 Rename locals to avoid shadowing.
3e7d6594 7794
50060332
PE
7795 * sound.c (wav_play, au_play, Fplay_sound_internal):
7796 Fix pointer signedness.
d01f234b 7797 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7798 (wav_play): Initialize a variable to 0, to prevent undefined
7799 behavior (Bug#8278).
50060332 7800
c4fc4e30
PE
7801 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7802
918436ed
PE
7803 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7804
c939f91b
PE
7805 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7806 clobbering (Bug#8298).
b9c7f648
PE
7807 * sysdep.c (sys_subshell): Likewise.
7808 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7809
6bd8c144
PE
7810 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7811 This should get cleaned up, so that child_setup has the
7812 same signature on all platforms.
7813
7710357c 7814 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7815 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7816
c59da222
CY
78172011-03-22 Chong Yidong <cyd@stupidchicken.com>
7818
7819 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7820 not to be necessary, and produces flickering.
7821
66b87493
GM
78222011-03-20 Glenn Morris <rgm@gnu.org>
7823
7824 * config.in: Remove file.
7825
45b6f6d5
JB
78262011-03-20 Juanma Barranquero <lekktu@gmail.com>
7827
7828 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7829 are now in src/globals.h.
7830 (syms_of_minibuf): Remove spurious & from previous change.
7831
3ec03f7e
LL
78322011-03-20 Leo <sdl.web@gmail.com>
7833
7834 * minibuf.c (completing-read-function): New variable.
7835 (completing-read-default): Rename from completing-read.
7836 (completing-read): Call completing-read-function.
7837
b14e3e21
CY
78382011-03-19 Juanma Barranquero <lekktu@gmail.com>
7839
7840 * xfaces.c (Fx_load_color_file):
7841 Read color file from absolute filename (bug#8250).
7842
f2b726e6
JB
78432011-03-19 Juanma Barranquero <lekktu@gmail.com>
7844
7845 * makefile.w32-in: Update dependencies.
7846
09f6ff02
EZ
78472011-03-17 Eli Zaretskii <eliz@gnu.org>
7848
7849 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7850
29a6015a
PE
78512011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7852
a3a6c54e
PE
7853 Fix more problems found by GCC 4.5.2's static checks.
7854
b766f867
PE
7855 * process.c (make_serial_process_unwind, send_process_trap):
7856 (sigchld_handler): Now static.
7857
be02381c
PE
7858 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7859 That way, the code declares only the vars that it needs.
7860 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7861 * s/cygwin.h (PTY_ITERATION): Likewise.
7862 * s/darwin.h (PTY_ITERATION): Likewise.
7863 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7864
57048744
PE
7865 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7866 * process.c (allocate_pty): Don't declare stb unless it's needed.
7867
7914961c 7868 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7869 (CONSTANTLIM): Remove; unused.
7870 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7871 Define only if needed.
7914961c 7872
b3967b18
PE
7873 * unexelf.c (unexec): Name an expression,
7874 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7875 Use a different way to cause a compilation error if anyone uses
7876 n rather than nn, a way that does not involve shadowing.
73366a00 7877 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7878
29a6015a
PE
7879 * deps.mk (unexalpha.o): Remove; unused.
7880
43cfc33e 7881 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7882 * unexec.h: New file.
ce701a33
PE
7883 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7884 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7885 Depend on unexec.h.
7886 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7887 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7888 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7889 Change as necessary to match prototype in unexec.h.
ce701a33 7890
01f44d5a
PE
7891 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7892 shadowing.
4f63c6bb 7893 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7894
a6670b0b
PE
7895 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7896 Rename locals to avoid shadowing.
7897
cef2010d 7898 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7899 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7900
d4d7173a
PE
7901 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7902
f08b802a
PE
7903 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7904 warning when compiling print.c.
7905
3ddb0639
PE
7906 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7907 instead of using an uninitialized var.
5ad03b97 7908 (font_sort_entities): Mark var as initialized.
3ddb0639 7909
170a2692
PE
7910 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7911
e663c700
PE
7912 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7913 pointers to constants.
89bc529a 7914 (font_parse_fcname): Remove unused vars.
7b81e2d0 7915 (font_delete_unmatched): Now static.
ea838e10 7916 (font_get_spec): Remove; unused.
13a547c6
PE
7917 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7918 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7919 Rename or move locals to avoid shadowing.
e663c700 7920
2a80c887 7921 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7922 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7923
1384fa33 7924 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7925 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7926
8b2c52e9
PE
7927 * alloc.c (mark_backtrace): Move decl from here ...
7928 * lisp.h: ... to here, so that it can be checked.
7929
475545b5 7930 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7931 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7932 (lisp_indirect_variable): Name an expression,
7933 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7934 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7935
b1349114 7936 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7937 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7938 Use const pointer when appropriate.
b1349114 7939
a2928364
PE
7940 * lisp.h (get_system_name, get_operating_system_release):
7941 Move decls here, to check interfaces.
7942 * process.c (get_operating_system_release): Move decl to lisp.h.
7943 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7944 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7945 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7946 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7947 (Fformat_time_string, Fencode_time, Finsert_char):
7948 (Ftranslate_region_internal, Fformat):
7949 Rename or remove local vars to avoid shadowing.
9710023e 7950 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7951
a415e694
PE
7952 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7953 avoid shadowing.
7954
8ef4622d
PE
7955 * lisp.h (eassert): Check that the argument compiles, even if
7956 ENABLE_CHECKING is not defined.
7957
946f9a5b
PE
7958 * data.c (Findirect_variable): Name an expression, to avoid
7959 gcc -Wbad-function-cast warning.
112396d6 7960 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7961 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7962 (Fmake_variable_buffer_local, Fmake_local_variable):
7963 Mark variables as initialized.
52746918 7964 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7965
e5aab7e7 7966 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7967 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7968 Rename locals to avoid shadowing.
dff45157
PE
7969 (mark_stack): Move local variables into the #ifdef region where
7970 they're used.
7bc26fdb
PE
7971 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7972 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7973 needed otherwise.
7974 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7975 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7976 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7977
e5aab7e7
PE
7978 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7979 avoids undefined behavior in theory.
7980
4da60324
PE
7981 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7982
88043301
PE
7983 Use functions, not macros, for up- and down-casing (Bug#8254).
7984 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7985 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7986 to use the following functions instead of these macros.
7987 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7988 EMACS_INT, since callers assume the returned value fits in int.
7989 (upcase1): Likewise, for UPCASE_TABLE.
7990 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7991 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7992 the race-condition problem in the old DOWNCASE.
88043301 7993
19ed5445
PE
7994 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7995 Rename locals to avoid shadowing.
7996 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7997 (regex_compile, re_search_2, re_match_2_internal):
7998 Remove unused local vars.
952db0d7
PE
7999 (FREE_VAR): Rewrite so as not to use empty "else",
8000 which gcc can warn about.
da053e48 8001 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8002 (RETALLOC_IF): Define only if needed.
8003 (WORDCHAR_P): Likewise. This one is never needed, but is used
8004 only in a comment talking about a compiler bug, so put inside
8005 the #if 0 of that comment.
8006 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8007 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8008 Remove; unused.
19ed5445 8009
1f3561e4 8010 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8011 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8012 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8013
ded6f8f7
PE
8014 * search.c (simple_search): Remove unused var.
8015
dbd37a95
PE
8016 * dired.c (compile_pattern): Move decl from here ...
8017 * lisp.h: ... to here, so that it can be checked.
8018 (struct re_registers): New forward decl.
8019
7e47afad
PE
8020 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8021
85f24f61
PE
8022 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8023 All uses changed.
8024 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8025 Rename locals to avoid shadowing.
5671df8f 8026 (Fvertical_motion): Mark locals as initialized.
85f24f61 8027
181aa2be 8028 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8029 (casify_region): Mark local as initialized.
181aa2be 8030
930d429c
PE
8031 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8032
7082eac6
PE
8033 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8034 New macros, so that the caller can use some names other than
8035 gcpro1, gcpro2, etc.
8036 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8037 of the new macros.
8038 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8039 argument, for consistency with GCPRO2_VAR, etc: it is now the
8040 prefix of the variable, not the variable itself. All uses
8041 changed.
38b2c076
PE
8042 * dired.c (directory_files_internal, file_name_completion):
8043 Rename locals to avoid shadowing.
8044
15206ed9
PE
8045 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8046 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8047 dired.c's scmp function, had undefined behavior.
8048 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8049 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8050 * buffer.h: ... to here, because these macros use current_buffer,
8051 and the new implementation with inline functions needs to have
8052 current_buffer in scope now, rather than later when the macros
8053 are used.
8054 (downcase, upcase1): New static inline functions.
8055 (DOWNCASE, UPCASE1): Reimplement using these functions.
8056 This avoids undefined behavior in expressions like
8057 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8058 from race conditions in accessing the global variables
8059 case_temp1 and case_temp2.
8060 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8061 * lisp.h (case_temp1, case_temp2): Remove their decls.
8062 * character.h (ASCII_CHAR_P): Move from here ...
8063 * lisp.h: ... to here, so that the inline functions mentioned
8064 above can use them.
8065
4a6bea26
PE
8066 * dired.c (directory_files_internal_unwind): Now static.
8067
f14b7e14
PE
8068 * fileio.c (file_name_as_directory, directory_file_name):
8069 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8070 Now static.
2893f146
PE
8071 (file_name_as_directory): Use const pointers when appropriate.
8072 (Fexpand_file_name): Likewise. In particular, newdir might
8073 point at constant storage, so make it a const pointer.
fd4ead52 8074 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8075 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8076 signedness issues.
f839df0c
PE
8077 (Fset_file_times, Finsert_file_contents, auto_save_error):
8078 Rename locals to avoid shadowing.
f14b7e14 8079
5716756e 8080 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8081 (Ftry_completion, Fall_completions): Rename or remove locals
8082 to avoid shadowing.
5716756e 8083
b4c3046a
PE
8084 * marker.c (bytepos_to_charpos): Remove; unused.
8085
b45db522
PE
8086 * lisp.h (verify_bytepos, count_markers): New decls,
8087 so that gcc does not warn that these functions aren't declared.
8088
85876d07
PE
8089 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8090 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8091 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8092 (copy_text): Remove unused local var.
85876d07 8093
03d78a21 8094 * filelock.c (within_one_second): Now static.
b3dd38ab 8095 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8096
5df8f01b
PE
8097 * buffer.c (fix_overlays_before): Mark locals as initialized.
8098 (fix_start_end_in_overlays): Likewise. This function should be
8099 simplified by using pointers-to-pointers, but that's a different
8100 matter.
b1d876f1 8101 (switch_to_buffer_1): Now static.
8f54f30a
PE
8102 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8103 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8104
a70072c9 8105 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8106 Fix pointer signedness issue.
edced198
PE
8107 (sys_subshell): Mark local as volatile if checking for lint,
8108 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8109 (MAXPATHLEN): Define only if needed.
a70072c9 8110
a0977c44
PE
8111 * process.c (serial_open, serial_configure): Move decls from here ...
8112 * systty.h: ... to here, so that they can be checked.
8113
a884fdcc
PE
8114 * fns.c (get_random, seed_random): Move extern decls from here ...
8115 * lisp.h: ... to here, so that they can be checked.
8116
604efe86 8117 * sysdep.c (reset_io): Now static.
b8950c94 8118 (wait_for_termination_signal): Remove; unused.
604efe86 8119
38fc62d9
PE
8120 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8121 (copy_keymap_item, append_key, push_text_char_description):
8122 Now static.
1004a21a 8123 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8124 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8125 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8126 (describe_map_tree):
8127 Rename locals to avoid shadowing.
38fc62d9 8128
2f2650da
PE
8129 * keyboard.c: Declare functions static if they are not used elsewhere.
8130 (echo_char, echo_dash, cmd_error, top_level_2):
8131 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8132 (read_char, kbd_buffer_get_event, make_lispy_position):
8133 (make_lispy_event, make_lispy_movement, apply_modifiers):
8134 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8135 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8136 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8137 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8138 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8139
a053e86c 8140 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8141 (mark_kboards): Move decl here ...
8142 * alloc.c (mark_kboards): ... from here.
a053e86c 8143
4752793e
PE
8144 * lisp.h (force_auto_save_soon): New decl.
8145
74f10ca7 8146 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8147 (DEFINE_DUMMY_FUNCTION): New macro.
8148 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8149 Use it.
c03cd23f
PE
8150 (main): Add casts to avoid warnings
8151 if GCC considers string literals to be constants.
74f10ca7 8152
022e70d4
PE
8153 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8154
59d6fe83
PE
8155 * dbusbind.c: Pointer signedness fixes.
8156 (xd_signature, xd_append_arg, xd_initialize):
8157 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8158 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8159 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8160 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8161
78320123
PE
8162 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8163 if GCC considers string literals to be constants.
49cebcca 8164 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8165
35ac2a97
SM
81662011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8167
fb103ca9
SM
8168 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8169 (print_preprocess, print_object): New macro to fix last change.
8170
35ac2a97
SM
8171 * print.c (print_preprocess): Don't forget font objects.
8172
62973b41
JB
81732011-03-16 Juanma Barranquero <lekktu@gmail.com>
8174
8175 * emacs.c (USAGE3): Doc fixes.
8176
0e48bb22
AS
81772011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8178
8179 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8180 structure.
8181
7684e57b
JB
81822011-03-14 Juanma Barranquero <lekktu@gmail.com>
8183
8184 * lisp.h (VWindow_system, Qfile_name_history):
8185 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8186 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8187 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8188
8189 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8190 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8191
8192 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8193 * w32console.c (detect_input_pending, read_input_pending)
8194 (encode_terminal_code):
8195 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8196 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8197 (w32_system_caret_y, Qfile_name_history):
8198 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8199 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8200 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8201 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8202 * w32proc.c (Qlocal, report_file_error):
8203 * w32term.c (Vwindow_system, updating_frame):
8204 * w32uniscribe.c (initialized, uniscribe_font_driver):
8205 Remove unneeded extern declarations.
8206
2aa46d6c
CY
82072011-03-14 Chong Yidong <cyd@stupidchicken.com>
8208
c96bbc66 8209 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8210
cffc6f3b
CY
82112011-03-13 Chong Yidong <cyd@stupidchicken.com>
8212
8213 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8214 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8215 These macros can no longer be used for assignment.
8216
44f230aa
SM
8217 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8218 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8219 (record_buffer_markers, fetch_buffer_markers): New functions for
8220 recording and fetching special buffer markers.
8221 (set_buffer_internal_1, set_buffer_temp): Use them.
8222
8223 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8224
8225 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8226
8227 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8228 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8229
8230 * xdisp.c (hscroll_window_tree):
8231 (reconsider_clip_changes): Use PT instead of BUF_PT.
8232
d251f04b
EZ
82332011-03-13 Eli Zaretskii <eliz@gnu.org>
8234
8235 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8236 $(EMACS_ROOT)/lib/intprops.h.
8237
f0c77cd1
PE
82382011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8239
3eca4629
PE
8240 Fix more problems found by GCC 4.5.2's static checks.
8241
7c86ee98
PE
8242 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8243 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8244 (xg_free_frame_widgets): Make it clear that a local variable is
8245 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8246 (gdk_window_get_screen): Make it clear that this macro is needed
8247 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8248 (int_gtk_range_get_value): New function, which avoids a diagnostic
8249 from gcc -Wbad-function-cast.
8250 (xg_set_toolkit_scroll_bar_thumb): Use it.
8251 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8252 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8253 (get_utf8_string, xg_get_file_with_chooser):
8254 Rename locals to avoid shadowing.
8255 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8256
41729b81
PE
8257 * xgselect.c (xg_select): Remove unused var.
8258
f0c77cd1
PE
8259 * image.c (four_corners_best): Mark locals as initialized.
8260 (gif_load): Initialize transparent_p to zero (Bug#8238).
8261 Mark another local as initialized.
ec6cf4c6 8262 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8263
ce0ad53d 8264 * image.c (clear_image_cache): Now static.
d5d5a617 8265 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8266 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8267 (x_edge_detection): Remove unnecessary cast that
8268 gcc -Wbad-function-cast diagnoses.
2037898d 8269 (gif_load): Fix pointer signedness.
6ae141d6
PE
8270 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8271 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8272
33383987 82732011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8274
d32df629
PE
8275 Improve quality of tests for time stamp overflow.
8276 For example, without this patch (encode-time 0 0 0 1 1
8277 1152921504606846976) returns the obviously-bogus value (-948597
8278 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8279 reports time overflow. See
8280 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8281 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8282 * editfns.c: Include limits.h and intprops.h.
8283 (TIME_T_MIN, TIME_T_MAX): New macros.
8284 (time_overflow): Move earlier, to before first use.
8285 (hi_time, lo_time): New functions, for an accurate test for
8286 out-of-range times.
8287 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8288 (Fget_internal_run_time): Don't assume time_t fits in int.
8289 (make_time): Use list2 instead of Fcons twice.
8290 (Fdecode_time): More accurate test for out-of-range times.
8291 (check_tm_member): New function.
8292 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8293 (lisp_time_argument): Don't rely on undefined left-shift and
8294 right-shift behavior when checking for time stamp overflow.
8be6f318 8295
fe31d94c
PE
8296 * editfns.c (time_overflow): New function, refactoring common code.
8297 (Fformat_time_string, Fdecode_time, Fencode_time):
8298 (Fcurrent_time_string): Use it.
8299
8be6f318
PE
8300 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8301 * dired.c (make_time): Move to ...
8302 * editfns.c (make_time): ... here.
8303 * systime.h: Note the move.
8304
09d9db2c 83052011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8306
126bc0dc
YM
8307 * fringe.c (update_window_fringes): Remove unused variables.
8308
c47cbdfd
YM
8309 * unexmacosx.c (copy_data_segment): Also copy __got section.
8310 (Bug#8223)
8311
7ac80be9
EZ
83122011-03-12 Eli Zaretskii <eliz@gnu.org>
8313
c96bbc66 8314 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8315 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8316 Constify `char *' arguments and their references according to
8317 prototypes in tparam.h.
8318
ecb0f94d 8319 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8320
7ac80be9
EZ
8321 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8322 Adapt all references accordingly.
8323
8324 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8325
ef1fd07e
TT
83262011-03-11 Tom Tromey <tromey@redhat.com>
8327
8328 * buffer.c (syms_of_buffer): Remove obsolete comment.
8329
7ef4b50c
EZ
83302011-03-11 Eli Zaretskii <eliz@gnu.org>
8331
8332 * termhooks.h (encode_terminal_code): Declare prototype.
8333
8334 * msdos.c (encode_terminal_code): Don't declare prototype.
8335
8336 * term.c (encode_terminal_code): Now external again, used by
8337 w32console.c and msdos.c.
8338
44f230aa
SM
8339 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8340 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8341
4b1ec863 83422011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8343
1714f52b 8344 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8345
4b1ec863
PE
8346 * fringe.c (update_window_fringes): Mark locals as initialized
8347 (Bug#8227).
8348 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8349
524c7aa6
PE
8350 * alloc.c (mark_fringe_data): Move decl from here ...
8351 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8352 to check its interface.
8353 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8354
a5c0af81 8355 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8356 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8357 (fontset_font): Mark local as initialized.
a9a06e0b 8358 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8359
b4716021
PE
8360 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8361
811e9bac 8362 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8363 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8364 (x_own_selection, Fx_disown_selection_internal): Rename locals
8365 to avoid shadowing.
8366 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8367
7e3ab302
PE
8368 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8369 so that the caller can use some name other than gcpro1.
8370 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8371 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8372 (Fx_backspace_delete_keys_p):
8373 Use them to avoid shadowing, and rename vars to avoid shadowing.
8374 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8375 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8376 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8377 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8378 Remove unused locals.
7e3ab302
PE
8379 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8380 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8381 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8382 macros.
f78faa98 8383
e2b13473
PE
8384 * xterm.h (x_mouse_leave): New decl.
8385
77f23912
PE
8386 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8387 Remove unused functions.
cdf4ba58
PE
8388 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8389 (x_calc_absolute_position): Now static.
7411c686 8390 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8391 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8392 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8393 unless they are used.
38d0b34a
PE
8394 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8395 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8396 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8397 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8398 (x_error_catcher, x_connection_closed, x_error_handler):
8399 (x_error_quitter, xembed_send_message, x_iconify_frame):
8400 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8401 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8402 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8403
44f230aa
SM
8404 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8405 Rename or move locals to avoid shadowing.
6b463e58 8406 (tty_defined_color, merge_face_heights): Now static.
5967d051 8407 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8408 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8409 does not deduce is never used uninitialized.
73719eba
PE
8410 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8411 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8412
426994c3 8413 * terminal.c (store_terminal_param): Now static.
5489860b 8414
032f1620 8415 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8416 (set_frame_menubar): Remove unused local.
d4323972 8417 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8418 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8419 since they might point to immutable storage.
281585b0
PE
8420 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8421 since it's unused otherwise.
032f1620 8422
367c19e5 8423 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8424 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8425 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8426 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8427 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8428 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8429 does not deduce are never used uninitialized.
70739cbe 8430
07b48fa9
PE
8431 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8432
8868a238 8433 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8434 * window.c (window_loop, size_window):
8435 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8436
7e5cf297 8437 * window.c (display_buffer): Now static.
d6550a9f
PE
8438 (size_window): Mark variables that gcc -Wuninitialized
8439 does not deduce are never used uninitialized.
a586633d
PE
8440 * window.h (check_all_windows): New decl, to forestall
8441 gcc -Wmissing-prototypes diagnostic.
5b555da1 8442 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8443
f6095868
PE
8444 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8445 shadowing.
8446 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8447 Include <limits.h>.
8448 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8449 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8450 (load_charset_map): Mark variables that gcc -Wuninitialized
8451 does not deduce are never used uninitialized.
53df7c11 8452 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8453
f38b440c
PE
8454 * coding.c (coding_set_source, coding_set_destination):
8455 Use "else { /* comment */ }" rather than "else /* comment */;"
8456 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8457 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8458 a block, when the outer 'i' will do.
8459 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8460 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8461 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8462 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8463 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8464 Rename locals to avoid shadowing.
8465 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8466 * coding.c (emacs_mule_char, encode_invocation_designation):
8467 Now static, since they're not used elsewhere.
413bb2db 8468 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8469 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8470 (decode_coding_emacs_mule): Mark variables that gcc
8471 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8472 (detect_coding_iso_2022): Initialize a local variable that might
8473 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8474 this initialization is needed. (Bug#8211)
5f58e762
PE
8475 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8476 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8477 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8478 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8479 Remove unused macros.
f38b440c 8480
232b38b9 8481 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8482 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8483 * character.c (string_count_byte8): Likewise.
232b38b9 8484
fb90da1b
PE
8485 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8486 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8487
fb93dbc2
PE
8488 * chartab.c (copy_sub_char_table): Now static, since it's not used
8489 elsewhere.
5c156ace
PE
8490 (sub_char_table_ref_and_range, char_table_ref_and_range):
8491 Rename locals to avoid shadowing.
bbcd0949 8492 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8493
7d3b3862 8494 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8495 (BIDI_BOB): Remove unused macro.
7d3b3862 8496
6be7d3da
PE
8497 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8498 deduce are never used uninitialized.
c2ed9c8b 8499 * term.c (encode_terminal_code): Likewise.
6be7d3da 8500
75f8807f 8501 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8502
50938595
PE
8503 * tparam.h: New file.
8504 * term.c, tparam.h: Include it.
8505 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8506 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8507 Move these decls to tparam.h, and make them agree with what
8508 is actually in tparam.c. The previous trick of using incompatible
8509 decls in different modules does not conform to the C standard.
8510 All callers of tparam changed to use tparam's actual API.
8511 * tparam.c (tparam1, tparam, tgoto):
8512 Use const pointers where appropriate.
8513
fbceeba2
PE
8514 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8515 * cm.h (struct cm): Likewise.
8516 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8517 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8518 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8519 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8520 (turn_on_face, init_tty): Likewise.
8521 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8522
7f3f1250
PE
8523 * term.c (term_mouse_position): Rename local to avoid shadowing.
8524
e6ca6543
PE
8525 * alloc.c (mark_ttys): Move decl from here ...
8526 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8527
c40f8d15
AS
85282011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8529
8530 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8531
cfe0661d
JB
85322011-03-09 Juanma Barranquero <lekktu@gmail.com>
8533
8534 * search.c (compile_pattern_1): Remove argument regp, unused since
8535 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8536 (compile_pattern): Don't pass it.
8537
0afb4571
J
85382011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8539
8540 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8541 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8542 for ! HAVE_GTK3.
8543 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8544
8545 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8546
8547 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8548 gdk_window_get_screen, gdk_window_get_geometry,
8549 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8550 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8551 (xg_get_pixbuf_from_pixmap): New function.
8552 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8553 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8554 Call xg_get_pixbuf_from_pixmap instead of
8555 gdk_pixbuf_get_from_drawable.
8556 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8557 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8558 (xg_check_special_colors): Use GtkStyleContext and its functions
8559 for HAVE_GTK3.
8560 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8561 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8562 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8563 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8564 Call gtk_widget_get_preferred_size.
0afb4571
J
8565 (xg_frame_resized): gdk_window_get_geometry only takes 5
8566 parameters.
44f230aa
SM
8567 (xg_win_to_widget, xg_event_is_for_menubar):
8568 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8569 (xg_set_widget_bg): New function.
8570 (delete_cb): New function.
895009e1 8571 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8572 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8573 (xg_set_background_color): Call xg_set_widget_bg.
8574 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8575 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8576 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8577 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8578 if ! HAVE_GTK3.
8579 (update_frame_tool_bar): Call gtk_widget_hide.
8580 (xg_initialize): Use GDK_KEY_g.
8581
8582 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8583 if ! HAVE_GTK3
8584 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8585
8586 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8587 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8588 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8589
1c2cc4ef
JB
85902011-03-08 Juanma Barranquero <lekktu@gmail.com>
8591
8592 * w32xfns.c (select_palette): Check success of RealizePalette against
8593 GDI_ERROR, not zero.
8594
33383987 8595See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8596
8597;; Local Variables:
8598;; coding: utf-8
aac0c6e3
MR
8599;; End:
8600
33383987 8601 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8602
8603 This file is part of GNU Emacs.
8604
8605 GNU Emacs is free software: you can redistribute it and/or modify
8606 it under the terms of the GNU General Public License as published by
8607 the Free Software Foundation, either version 3 of the License, or
8608 (at your option) any later version.
8609
8610 GNU Emacs is distributed in the hope that it will be useful,
8611 but WITHOUT ANY WARRANTY; without even the implied warranty of
8612 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8613 GNU General Public License for more details.
8614
8615 You should have received a copy of the GNU General Public License
8616 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.