Avoid _setjmp/_longjmp problems with local nonvolatile variables.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5779a1dc
PE
12012-09-11 Paul Eggert <eggert@cs.ucla.edu>
2
50f2e553
PE
3 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
4 If a nonvolatile local variable is written before a _longjmp to
5 the frame containing the variable, and is read after the _longjmp,
6 the value read is indeterminate. Some local variables of type
7 'struct handler' and 'struct catchtag' are used in this way, so
8 mark each of their slots as volatile if the slot can be set before
9 _longjmp and read afterwards.
10 * lisp.h (struct handler): var and chosen_clause are now volatile.
11 (struct catchtag): val, next, and pdlcount are now volatile.
12
ae1d87e2
PE
13 * bidi.c (bidi_push_it, bidi_pop_it):
14 * fns.c (copy_hash_table):
15 * image.c (define_image_type):
16 * keyboard.c (kbd_buffer_store_event_hold):
17 * process.c (Fprocess_send_eof):
18 * xfaces.c (x_create_gc) [HAVE_NS]:
19 * xgselect.c (xg_select):
20 Prefer assignment to memcpy when either will do.
21
5779a1dc
PE
22 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
23 Use pointer-to-a-pointer to simplify and avoid a NILP check each
24 time an item is removed. No need to mark this function 'inline';
25 the compiler knows better than we do.
26
c4c9756b
JD
272012-09-11 Jan Djärv <jan.h.d@swipnet.se>
28
29 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
30 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
31 to change_frame_size (Bug#12388).
32 (windowDidResize:): Pass YES to updateFrameSize.
33
34 * nsterm.h: Add delay parameter to updateFrameSize.
35
d73e321c
DA
362012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
37
38 Discard killed buffers from deleted window and frame objects.
39 This reduces an amount of references to killed buffers and
40 helps GC to reclaim them faster.
41 * alloc.c (discard_killed_buffers): New function.
42 (mark_object): Use it for deleted windows and frames.
43 (mark_object): If symbol's value is set up for a killed buffer
44 or deleted frame, restore it's global binding.
45 * data.c (swap_in_global_binding): Add GC notice.
46 (swap_in_symval_forwarding): Use convenient set_blv_where.
47 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
48 * window.h: ... to here.
49
e578f381
DA
502012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
51
52 Convenient macro to check whether the buffer is live.
53 * buffer.h (BUFFER_LIVE_P): New macro.
54 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
55 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
56
3057e615
YM
572012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
58
59 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
60 composition cases (Bug#12364).
61
62 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
63 overhang of succeeding glyphs overlapping box cursor.
64
65 * w32term.c (x_draw_glyph_string): Likewise.
66
6fda35f2
PE
672012-09-11 Paul Eggert <eggert@cs.ucla.edu>
68
c990426a
PE
69 Simplify, document, and port floating-point (Bug#12381).
70 The porting part of this patch fixes bugs on non-IEEE platforms
71 with frexp, ldexp, logb.
72 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
73 Now static.
74 * floatfns.c: Simplify discussion of functions that Emacs doesn't
75 support, by removing commented-out code and briefly listing the
76 C89 functions excluded. The commented-out stuff was confusing
77 maintenance, e.g., we thought we needed cbrt but it was commented out.
78 (logb): Remove decl; no longer needed.
79 (isfinite): New macro, if not already supplied.
80 (isnan): Don't replace any existing macro.
81 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
82 are present on all C89 platforms.
83 (Ffrexp): Do not special-case zero, as frexp does the right thing
84 for that case.
85 (Flogb): Do not use logb, as it doesn't have the desired meaning
86 on hosts that use non-base-2 floating point. Instead, stick with
87 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
88 frexp, to avoid getting an unspecified result.
89
6fda35f2
PE
90 * xdisp.c (Qinhibit_debug_on_message): Now static.
91
16130a58
JD
922012-09-10 Jan Djärv <jan.h.d@swipnet.se>
93
94 * nsterm.m (ns_update_begin): Set clip path to whole view by using
95 NSBezierPath (Bug#12131).
96
d105a573
CY
972012-09-10 Chong Yidong <cyd@gnu.org>
98
99 * fns.c (Fdelq, Fdelete): Doc fix.
100
ff55dfe8
PE
1012012-09-10 Paul Eggert <eggert@cs.ucla.edu>
102
103 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
104 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
105
e7032e7c
SM
1062012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
107
108 * lisp.h (make_lisp_ptr): New macro to replace XSET.
109 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
110 Use it.
111
e9957956
EZ
1122012-09-09 Eli Zaretskii <eliz@gnu.org>
113
aba05ce9
EZ
114 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
115 left fringe if the window has a left margin. This avoids leaving
116 traces of the cursor because its leftmost pixel is not drawn over.
117
e9957956
EZ
118 * dispnew.c (update_window_line): When the left margin area of a
119 screen line is updated, set the redraw_fringe_bitmaps_p flag of
120 that screen line. (Bug#12277)
121
f6196b87
PE
1222012-09-09 Paul Eggert <eggert@cs.ucla.edu>
123
124 Assume C89 or later for math functions (Bug#12381).
125 This simplifies the code, and makes it a bit smaller and faster,
126 and (most important) makes it easier to clean up signal handling
127 since we can stop worring about floating-point exceptions in
128 library code. That was a problem before C89, but the problem
129 went away many years ago on all practical Emacs targets.
130 * data.c, image.c, lread.c, print.c:
131 Don't include <math.h>; no longer needed.
132 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
133 might be autoconfigured, as that never happens.
134 * data.c (fmod):
135 * doprnt.c (DBL_MAX_10_EXP):
136 * print.c (DBL_DIG):
137 Remove. C89 or later always defines these.
138 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
139 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
140 (arith_error, domain_error, domain_error2):
141 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
142 no longer needed -- we simply return what C returns. All uses removed.
143 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
144 the wrapped code.
145 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
146 Remove. All uses expanded, as these macros are no longer used
147 more than once and are now more trouble than they're worth.
148 (Ftan): Use tan, not sin / cos.
149 (Flogb): Assume C89 frexp.
150 (fmod_float): Assume C89 fmod.
151 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
152 (init_floatfns): Remove. All uses removed.
153
9d7f1863
JD
1542012-09-08 Jan Djärv <jan.h.d@swipnet.se>
155
156 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
157 compositeToPoint for OSX < 10.6 (Bug#12390).
158
eabf0404
PE
1592012-09-08 Paul Eggert <eggert@cs.ucla.edu>
160
161 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
162 This produces more-accurate results.
163
0b3b1d23
JD
1642012-09-08 Jan Djärv <jan.h.d@swipnet.se>
165
166 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
167 changes (Bug#12088).
168
6dcef6ec
CY
1692012-09-08 Chong Yidong <cyd@gnu.org>
170
171 * syntax.c (Fstring_to_syntax): Doc fix.
172
aa7d57c5
JD
1732012-09-08 Jan Djärv <jan.h.d@swipnet.se>
174
175 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
176 in the internal border.
177 (x_set_window_size): Remove static variables and their usage.
178 (ns_redraw_scroll_bars): Fix NSTRACE arg.
179 (ns_after_update_window_line, ns_draw_fringe_bitmap): Remove
180 fringe/internal border adjustment (Bug#11052).
181 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
182 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
183 (ns_fix_rect_ibw): Remove.
184 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
185 (ns_dumpglyphs_box_or_relief): Ditto.
186 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
187 adjustment.
188 (ns_dumpglyphs_image): Ditto.
189 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
190 border adjustment.
191 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
192 their usage. Add fringe_extended_p and its use as in other terms.
193 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
194 scroll bar was removed.
195 (updateFrameSize): New function.
196 (windowDidResize): Move code to updateFrameSize and call it.
197
198 * nsterm.h (EmacsView): Add updateFrameSize.
199
1a5432bc
CY
2002012-09-07 Chong Yidong <cyd@gnu.org>
201
b4f5313e
CY
202 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
203
1a5432bc
CY
204 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
205
1a4f1e9b
PE
2062012-09-07 Paul Eggert <eggert@cs.ucla.edu>
207
208 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
209 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
210 Problem introduced when merging patches. Noted by Eli Zaretskii in
211 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
212 * floatfns.c: Comment fix.
213 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
214 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
215 and anyway the declaration is harmless even if SIGDANGER is not defined.
216 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
217 defined BROKEN_FIONREAD). systty.h formerly did this, but other
218 source files not surprisingly expected syssignal.h to define, or
219 not define, SIGIO, and it's cleaner to do it that way, for consistency.
220 Include <sys/ioctl.h>, for FIONREAD.
221 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
222 This eliminates a problem whereby other files mysteriously had
223 to include "syssignal.h" before including "systty.h" if they
224 wanted to use "#ifdef SIGIO".
225
bc8000ff
EZ
2262012-09-07 Eli Zaretskii <eliz@gnu.org>
227
3e6d6928
EZ
228 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
229
230 * w32.c (sigemptyset): Empty the set.
231 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
232
bc8000ff
EZ
233 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
234
b4fa72f2
DA
2352012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
236
237 * alloc.c (mark_buffer): Revert unsafe marking optimization.
238 (mark_object): Likewise for frame objects.
239
30730c93
PE
2402012-09-07 Paul Eggert <eggert@cs.ucla.edu>
241
242 * syssignal.h (handle_on_main_thread): Always declare,
243 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
244 This ports to platforms without HAVE_PTHREAD.
245
2fe28299
PE
2462012-09-06 Paul Eggert <eggert@cs.ucla.edu>
247
248 Signal-handler cleanup (Bug#12327).
249 Emacs's signal handlers were written in the old 4.2BSD style with
250 sigblock and sigmask and so forth, and this led to some
251 inefficiencies and confusion. Rewrite these to use
252 pthread_sigmask etc. without copying signal sets around. Also,
253 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
254 'signal', and instead use functions that do not attempt to take
255 over the system name space. This patch causes Emacs's text
256 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
257 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
258 Do not include <signal.h> or "syssignal.h", as these
259 modules do not use signals.
260 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
261 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
262 Do not include <signal.h>, as "syssignal.h" does that for us now.
263 * atimer.c (sigmask_atimers): New function.
264 (block_atimers, unblock_atimers): New functions,
265 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
266 All uses replaced.
267 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
268 no longer needed here.
269 * emacs.c (main): Inspect existing signal handler with sigaction,
270 so that there's no need to block and unblock SIGHUP.
271 * sysdep.c (struct save_signal): New member 'action', replacing
272 old member 'handler'.
273 (save_signal_handlers, restore_signal_handlers):
274 Use sigaction instead of 'signal' to save and restore.
275 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
276 New function. All users of 'signal' modified to use set_sighandler
277 if they're writeonly, and to use sys_signal if they're read+write.
278 (emacs_sigaction_init, forwarded_signal): New functions.
279 (sys_signal): Remove. All uses replaced by calls to sigaction
280 and emacs_sigaction_init, or by direct calls to 'signal'.
281 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
282 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
283 all uses replaced by pthread_sigmask etc. calls.
284 * syssignal.h: Include <signal.h>.
285 (emacs_sigaction_init, forwarded_signal): New decls.
286 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
287 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
288 (sigmask, sys_sigmask): Remove; no longer needed.
289 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
290 (sigblock, sigunblock, sigfree):
291 (sigsetmask) [!defined sigsetmask]:
292 Remove. All uses replaced by pthread_sigmask.
293 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
294 no longer need to be replaced, and its typical old uses
295 are now done via emacs_sigaction_init and sigaction.
296 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
297 (sys_sigdel): Remove; unused.
298 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
299
0216c128
EZ
3002012-09-06 Eli Zaretskii <eliz@gnu.org>
301
302 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
303 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
304
c752cfa9
DA
3052012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
306
307 Explicitly mark buffer_defaults and buffer_local_symbols.
308 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
309 mark_local_symbols here.
310 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
311 since special buffers aren't marked here any more.
312 (allocate_buffer): Chain new buffer with all_buffers here...
313 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
314 not here.
315 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
316 (syms_of_buffer): Remove staticpro of the above.
317 (init_buffer_once): Set names for buffer_defaults and
318 buffer_local_symbols.
319
a864ef14
PE
3202012-09-06 Paul Eggert <eggert@cs.ucla.edu>
321
322 Use bool for booleans in font-related modules.
323 * font.c (font_intern_prop, font_style_to_value)
324 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
325 (generate_otf_features, font_check_otf_features, font_check_otf)
326 (font_match_p, font_list_entities, font_at):
327 * fontset.c (fontset_id_valid_p, reorder_font_vector
328 (fontset_find_font, Fset_fontset_font)
329 (face_suitable_for_char_p) [0]:
330 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
331 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
332 (m17n_flt_initialized, ftfont_shape_by_flt):
333 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
334 * nsfont.m (nsfont_draw):
335 * w32font.c (w32font_draw):
336 * w32term.c (x_draw_glyphless_glyph_string_foreground):
337 Use bool for booleans.
338 * font.h: Adjust to above API changes.
339 (struct font, struct font_driver, struct font_driver_list):
340 Use bool for booleans.
341 (struct font): Remove useless member encoding_type.
342 All users removed.
343 * fontset.c, xftfont.c: Omit unnecessary static decls.
344
0699fc18
DA
3452012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
346
347 * alloc.c (mark_object): Revert window marking code
348 since it's unsafe for the Fset_window_configuration.
349
20ef56db
PE
3502012-09-05 Paul Eggert <eggert@cs.ucla.edu>
351
2fe28299 352 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
353 Be more systematic about preserving errno whenever a signal
354 handler returns, even if it's not in the main thread. Do this by
355 renaming signal handlers to distinguish between signal delivery
356 and signal handling. All uses changed.
357 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
358 * data.c (deliver_arith_signal): Rename from arith_error.
359 * dispnew.c (deliver_window_change_signal): Rename from
360 window_change_signal.
361 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
362 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
363 * keyboard.c (deliver_input_available_signal): Rename from
364 input_available_signal.
365 (deliver_user_signal): Rename from handle_user_signal.
366 (deliver_interrupt_signal): Rename from interrupt_signal.
367 * process.c (deliver_pipe_signal): Rename from send_process_trap.
368 (deliver_child_signal): Rename from sigchld_handler.
369 * atimer.c (handle_alarm_signal):
370 * data.c (handle_arith_signal):
371 * dispnew.c (handle_window_change_signal):
372 * emacs.c (handle_fatal_signal, handle_danger_signal):
373 * keyboard.c (handle_input_available_signal):
374 * keyboard.c (handle_user_signal, handle_interrupt_signal):
375 * process.c (handle_pipe_signal, handle_child_signal):
376 New functions, with the actual signal-handling code taken from the
377 original respective signal handlers, sans the sporadic attempts to
378 preserve errno, since that's now done by handle_on_main_thread.
379 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
380 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
381 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
382 Move to sysdep.c.
383 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
384 Move initialization of main_thread to sysdep.c's init_signals.
385 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
386 our usage, and simplifies the mainline code.
387 (record_child_status_change): New static function, as a helper
388 for handle_child_signal, and with most of the old child handler's
389 contents.
390 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
391 (handle_child_signal): Use the above.
392 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
393 Moved here from emacs.c.
394 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
395 code moved here from emacs.c's main function.
396 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
397 replacing the old SIGNAL_THREAD_CHECK. All uses changed. This
398 lets callers save and restore errno properly.
399
e3ccf108
DA
4002012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
401
402 Remove redundant or unused things here and there.
403 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
404 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
405 * editfns.c (Fcompare_buffer_substrings): Likewise.
406 * frame.h (struct terminal, struct font_driver_list):
407 Remove redundant declarations.
408 * window.h (Qleft, Qright): Likewise.
409
697e1e39
DA
4102012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
411
412 Do not mark objects from deleted buffers, windows and frames.
413 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
414 (mark_object): Likewise for windows and frames.
415
c1ca42ca
DA
4162012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
417
418 * alloc.c (valid_lisp_object_p): Treat killed buffers,
419 buffer_defaults and buffer_local_symbols as valid objects.
420 Return special value to denote them.
421
014d93be
PE
4222012-09-05 Paul Eggert <eggert@cs.ucla.edu>
423
f75d7a91
PE
424 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
425 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
426 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
427 (file_name_absolute_p, Fsubstitute_in_file_name):
428 (check_executable, check_writable, Ffile_accessible_directory_p)
429 (Fset_file_selinux_context, Fdefault_file_modes)
430 (Finsert_file_contents, choose_write_coding_system)
431 (Fwrite_region, build_annotations, a_write, e_write)
432 (Fdo_auto_save):
433 * filelock.c (boot_time_initialized, get_boot_time)
434 (get_boot_time_1, lock_file_1, within_one_second):
435 * floatfns.c (in_float):
436 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
437 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
438 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
439 * lisp.h (struct Lisp_Hash_Table.cmpfn):
440 * window.c (compare_window_configurations):
441 Use bool for booleans.
442 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
443 (Fdefault_file_modes): Now mode_t, not int, for modes.
444 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
445 (internal_delete_file): Now returns void, not a (boolean) int,
446 since nobody was looking at the return value.
447 * lisp.h, window.h: Adjust to above API changes.
448
014d93be
PE
449 * xdisp.c (set_message): Simplify and reindent last change.
450
776f29e1
JB
4512012-09-05 Juanma Barranquero <lekktu@gmail.com>
452
453 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
454
7f7e0167
LI
4552012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
456
457 * eval.c (call_debugger): Make the function non-static so that we
458 can call it from set_message.
459
460 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
461 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
462
cf29dd84
PE
4632012-09-04 Paul Eggert <eggert@cs.ucla.edu>
464
465 Give more-useful info on a fatal error (Bug#12328).
466 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
467 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
468 of doing the work ourselves.
469 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
470 do most of the work.
471 (fatal_error_backtrace): New function, taken from the guts
472 of the old fatal_error_signal, but with a new option to output
473 a backtrace.
474 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
475 info about the signal than just its number.
476 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
477 * sysdep.c: Include <execinfo.h>
478 (emacs_backtrace): New function, taken partly from the previous
479 code of the 'die' function.
480 (emacs_abort): Call fatal_error_backtrace rather than abort.
481
972debf2
SM
4822012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
483
484 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
485 eager (load-time) macro-expansion.
486 * lisp.mk (lisp): Add macroexp.
487
1088b922
PE
4882012-09-04 Paul Eggert <eggert@cs.ucla.edu>
489
490 Simplify redefinition of 'abort' (Bug#12316).
491 Do not try to redefine the 'abort' function. Instead, redo
492 the code so that it calls 'emacs_abort' rather than 'abort'.
493 This removes the need for the NO_ABORT configure-time macro
494 and makes it easier to change the abort code to do a backtrace.
495 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
496 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
497 Remove; sysdep.c's emacs_abort now takes its place.
498 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
499 'abort' changed to use 'emacs_abort'.
500 * msdos.c (dos_abort) [defined abort]: Remove; not used.
501 (abort) [!defined abort]: Rename to ...
502 (emacs_abort): ... new name.
503 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
504 the place of the old 'abort' in emacs.c.
505 * w32.c, w32fns.c (abort): Do not #undef.
506 * w32.c (emacs_abort): Rename from w32_abort.
507
30934d33
EZ
5082012-09-04 Eli Zaretskii <eliz@gnu.org>
509
510 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
511 offsets[j].dv, since the y axis of the screen coordinates points
512 down, while the y axis of the font definition coordinates points
513 up. This fixes display of Arabic diacritics such as KASRA and
514 KASRATAN. (Bug#11860)
515
af26b72c
PE
5162012-09-04 Paul Eggert <eggert@cs.ucla.edu>
517
518 Be more systematic about _setjmp vs setjmp.
519 * alloc.c (test_setjmp, mark_stack):
520 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
521 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
522 (png_load, my_error_exit, jpeg_load):
523 * process.c (send_process_trap, send_process):
524 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
525 The underscored versions are up to 30x faster on some hosts.
526 Formerly, the code used setjmp+longjmp sometimes and
527 _setjmp+_longjmp at other times, with no particular reason to
528 prefer setjmp+longjmp.
529
26d4541d
PE
5302012-09-03 Paul Eggert <eggert@cs.ucla.edu>
531
d42f4f0f 532 Fix minor problem found by static checking.
26d4541d 533 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 534
c5e28e39
MR
5352012-09-03 Martin Rudalics <rudalics@gmx.at>
536
537 * buffer.c (Fdelete_all_overlays): New function.
538
3eab3ca9
CY
5392012-09-03 Chong Yidong <cyd@gnu.org>
540
541 * gtkutil.c: Add extern decl for Qxft.
542
c04889f8
PE
5432012-09-02 Paul Eggert <eggert@cs.ucla.edu>
544
1882aa38
PE
545 * emacs.c, eval.c: Use bool for boolean.
546 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
547 (malloc_using_checking) [DOUG_LEA_MALLOC]:
548 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
549 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
550 (main, decode_env_path, Fdaemon_initialized):
551 * eval.c (call_debugger, Finteractive_p, interactive_p):
552 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
553 (maybe_call_debugger, Fbacktrace):
554 * process.c (read_process_output, exec_sentinel):
555 Use bool for booleans.
556 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
557 All callers changed.
558 * eval.c (interactive_p): Omit always-true boolean argument
559 EXCLUDE_SUBRS_P. All callers changed.
560 * dispextern.h, lisp.h: Reflect above API changes.
561 * firstfile.c (dummy): Use the address of 'main', whose signature
562 won't change, instead of the address of 'initialize', whose
563 signature just changed from int to bool.
564 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
565 * msdos.c (fatal_error_in_progress): ... from here.
566 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
567 of incrementing it.
568 (redisplay_internal, unwind_redisplay): Simply clear
569 REDISPLAYING_P when unwinding, instead of saving its previous,
570 always-false value and then restoring it.
571
a411ac43
PE
572 Clean up some extern decls.
573 Mostly, this hoists extern decls out of .c files and into .h files.
574 That way, we're more likely to catch errors if the interfaces change.
575 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
576 declare xg_mark_data.
577 * dispextern.h (x_frame_parm_handlers):
578 * font.h (Qxft):
579 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
580 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
581 (Qultra_bold, Qoblique, Qitalic):
582 Move extern decl here from .c file.
583 * alloc.c (xg_mark_data) [USE_GTK]:
584 * doc.c (Qclosure):
585 * eval.c (Qlexical_binding):
586 * fns.c (time) [!HAVE_UNISTD_H]:
587 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
588 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
589 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
590 * lread.c (Qinternal_interpreter_environment):
591 * minibuf.c (Qbuffer):
592 * process.c (QCfamily, QCfilter):
593 * widget.c (free_frame_faces):
594 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
595 * xfont.c (x_clear_errors):
596 * xterm.c (x_frame_parm_handlers):
597 Remove now-redundant extern decls.
598 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
599 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
600 Now static.
601 * xfaces.c: Remove unnecessary static decls.
602 * xterm.c (updating_frame): Remove decl of nonexistent object.
603
c04889f8
PE
604 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
605 when building globals.h, as the objects that are not built on
606 this host are not needed to compile C files on this host.
607
8b339673
JD
6082012-09-02 Jan Djärv <jan.h.d@swipnet.se>
609
610 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
611
612 * frame.h: Add missing prototype for x_wm_set_size_hint.
613
a08d4ba7
PE
6142012-09-02 Paul Eggert <eggert@cs.ucla.edu>
615
616 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
617 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
618 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
619 (Fsubstitute_command_keys):
620 * editfns.c (region_limit, find_field, Fconstrain_to_field)
621 (save_excursion_save, save_excursion_restore)
622 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
623 (format_time_string, general_insert_function)
624 (make_buffer_string, make_buffer_string_both)
625 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
626 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
627 (copy_text, insert_1, insert_1_both, insert_from_string)
628 (insert_from_string_before_markers, insert_from_string_1)
629 (insert_from_buffer, insert_from_buffer_1, replace_range)
630 (replace_range_2, del_range_1, del_range_byte, del_range_both)
631 (del_range_2, modify_region):
632 * intervals.c (intervals_equal, balance_possible_root_interval)
633 (adjust_intervals_for_insertion, merge_properties_sticky)
634 (graft_intervals_into_buffer, lookup_char_property)
635 (adjust_for_invis_intang, set_point_both)
636 (get_property_and_range, compare_string_intervals)
637 (set_intervals_multibyte_1, set_intervals_multibyte):
638 * keyboard.c (decode_timer):
639 Use bool for boolean.
640 * intervals.h, lisp.h, systime.h: Reflect above API changes.
641 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
642
48c948de
CY
6432012-09-02 Chong Yidong <cyd@gnu.org>
644
645 * keymap.c (push_key_description): Print M-TAB as C-M-i
646 (Bug#11758).
647
6c49a40b
JB
6482012-09-02 Juanma Barranquero <lekktu@gmail.com>
649
650 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
651 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
652 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
653 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
654 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
655 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
656 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
657
4dfbd238
EZ
6582012-09-01 Eli Zaretskii <eliz@gnu.org>
659
7e510e28
EZ
660 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
661 more than one grapheme cluster passed to the shaper: compute the
662 offset adjustment values separately for each cluster. (Bug#11860)
663
4dfbd238
EZ
664 * image.c: Restore mistakenly removed inclusion of w32.h. Without
665 it, GCC doesn't see prototypes of w32_delayed_load, and complains
666 about implicit conversions from integer to pointer.
667
86571ae0
DC
6682012-09-01 Daniel Colascione <dancol@dancol.org>
669
670 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
671 system used too early.
672
0e23ef9d
PE
6732012-09-01 Paul Eggert <eggert@cs.ucla.edu>
674
675 Better seed support for (random).
676 * emacs.c (main): Call init_random.
677 * fns.c (Frandom): Set the seed from a string argument, if given.
678 Remove long-obsolete Gentzel cruft.
679 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
680 (init_random): New function.
681
17a2cbbd
DC
6822012-09-01 Daniel Colascione <dancol@dancol.org>
683
684 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
685 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
686 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
687 x_wm_set_size_hint, x_query_colors, x_real_positions,
688 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
689 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
690 all of which have been moved to common code.
691
692 * xfaces.c: Include TERM_HEADER instead of listing all possible
693 window-system headers.
694
695 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
696 to match header.
697
698 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
699 directly accessing frame internals.
700
f18cbb28 701 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
702 globals_of_w32font.
703
704 * process.c: Include TERM_HEADER instead of listing all possible
705 window-system headers.
706
707 * nsterm.h: Remove declarations now in frame.h. Define
708 FRAME_X_SCREEN, FRAME_X_VISUAL.
709
710 * menu.c: Include TERM_HEADER instead of listing all possible
711 window-system headers.
712
713 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
714 window system.
715
716 * keyboard.c: Include TERM_HEADER instead of listing all possible
717 window-system headers.
718
719 * image.c: Include TERM_HEADER instead of listing all possible
720 window-system headers. Declare Vlibrary_cache when compiling for
721 Windows.
722
723 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
724 window system declarations.
725
726 * frame.h: Move common functions here: set_frame_menubar,
727 x_set_window_size, x_sync, x_get_focus_frame,
728 x_set_mouse_position, x_set_mouse_pixel_position,
729 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
730 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
731 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
732 x_activate_menubar, x_real_positions, x_bitmap_icon,
733 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
734 and x_query_colors.
735
736 * frame.c: Include TERM_HEADER instead of listing all possible
737 window-system headers.
738
739 * font.c: Include TERM_HEADER instead of listing all possible
740 window-system headers.
741
742 * emacs.c: Include TERM_HEADER.
743
f18cbb28
EZ
744 * dispnew.c: Include TERM_HEADER instead of listing all possible
745 window-system headers.
17a2cbbd 746
f18cbb28 747 * ccl.h: Include character.h.
17a2cbbd
DC
748
749 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
750 the current window system; include in list of objects to link into
751 Emacs.
752
c650a5de
DA
7532012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
754
755 Remove mark_ttys function and fix tty_display_info initialization.
756 * lisp.h (mark_ttys): Remove prototype.
757 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
758 to mark_ttys because all possible values of 'top_frame' slot are
759 the frames which are reachable from Vframe_list.
760 * term.c (mark_ttys): Remove.
761 (init_tty): Safely initialize 'top_frame' slot with Qnil.
762
4e0f6479
DA
7632012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
764
765 Change struct frame bitfields from unsigned char to unsigned.
766 * frame.h (struct frame): Change type of 'display_preempted',
767 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
768 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
769 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
770 bitfields from unsigned char to unsigned.
771
8b96a52c
DA
7722012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
773
774 Remove unused member of struct x_output and struct w32_output.
775 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
776 * w32term.h (struct w32_output): Likewise.
777
b4444c8a
JD
7782012-08-30 Jan Djärv <jan.h.d@swipnet.se>
779
780 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
781 does not become zero (Bug#12234).
782
b98521db
PE
7832012-08-30 Paul Eggert <eggert@cs.ucla.edu>
784
785 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
786 for GCC 4.7.1 x86-64.
787
31d02438
GM
7882012-08-30 Glenn Morris <rgm@gnu.org>
789
790 * lread.c (init_lread): For out-of-tree builds, only add the
791 source directory's site-lisp dir to the load-path if it exists,
792 consistent with in-tree builds. (Bug#12302)
793
7f8941d8
JD
7942012-08-28 Jan Djärv <jan.h.d@swipnet.se>
795
796 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
797 button_values to NULL. Call setStykeMask so dialogs get a close button.
798 (windowShouldClose:): Set window_closed.
799 (dealloc): New member, free button_values.
800 (process_dialog:): Make member function. Remove window argument,
801 replace window with self. Count buttons and allocate and store values
802 in button_values.
803 (addButton:value:row:): value is int with the name tag. Call setTag
804 with tag. Remove return self, declare return value as void.
805 (addString:row:): Remove return self, declare return value as void.
806 (addSplit): Remove return self, declare return value as void.
807 (clicked:): Remove return self, declare return value as void.
808 Set dialog_return to button_values[seltag]. Code formatting change.
809 (initFromContents:isQuestion:): Adjust call to process_dialog.
810 Code formatting change.
811 (timeout_handler:): Set timer_fired to YES.
812 (runDialogAt:): Set timer_fired to NO.
813 Handle click on close button as quit.
814
815 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
816 Add window_closed and button_values. Add void as return value for
817 add(Button|String|Split). addButton takes int instead of Lisp_Object.
818 Add process_dialog as new member.
819
eada0861 8202012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 821
eada0861
GM
822 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
823 is not one of the heaps we manage. (Bug#12242)
824
8252012-08-28 Glenn Morris <rgm@gnu.org>
826
827 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
828
457294dd
MR
8292012-08-28 Martin Rudalics <rudalics@gmx.at>
830
831 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
832 auto-buffer-name window parameter. Install revision of reverted
833 fix.
457294dd 834
4f2daf31
DA
8352012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
836
837 Do not allow to set major mode for a dead buffer.
838 * buffer.c (Fset_buffer_major_mode): Signal an error
839 if the buffer is dead.
840 (Fother_buffer, other_buffer_safely): Remove redundant
841 nested declaration.
842
66322887
DA
8432012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
844
845 Always use set_buffer_if_live to restore original buffer at unwind.
846 * buffer.h (record_unwind_current_buffer): New function.
847 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
848 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
849 * undo.c, window.c: Adjust users.
850 * buffer.c (set_buffer_if_live): Fix comment.
851
a3d794a1
DA
8522012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
853
854 Fix usage of set_buffer_internal.
855 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
856 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
857 * coding.c (decode_coding): Omit redundant test.
858 * fileio.c (decide_coding_unwind): Likewise.
859 * fns.c (secure_hash): Likewise.
860 * insdel.c (modify_region): Likewise.
861 * keyboard.c (command_loop_1): Likewise.
862 * print.c (PRINTFINISH): Likewise.
863 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
864
59ea14cd
PE
8652012-08-27 Paul Eggert <eggert@cs.ucla.edu>
866
867 * dispnew.c: Use bool for boolean.
868 (frame_garbaged, display_completed, delayed_size_change)
869 (fonts_changed_p, add_window_display_history)
870 (add_frame_display_history, verify_row_hash)
871 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
872 (row_equal_p, realloc_glyph_pool)
873 (allocate_matrices_for_frame_redisplay)
874 (showing_window_margins_p)
875 (adjust_frame_glyphs_for_frame_redisplay)
876 (build_frame_matrix_from_leaf_window, make_current)
877 (mirrored_line_dance, mirror_line_dance, update_frame)
878 (update_window_tree, update_single_window)
879 (check_current_matrix_flags, update_window, update_text_area)
880 (update_window_line, set_window_update_flags, scrolling_window)
881 (update_frame_1, scrolling, buffer_posn_from_coords)
882 (do_pending_window_change, change_frame_size)
883 (change_frame_size_1, sit_for):
884 Use bool for boolean.
885 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
886 and remove last int (actually boolean) argument, which was always 0.
887 All callers changed.
888 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
889 * dispextern.h (struct composition_it): Use bool for boolean.
890 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
891 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
892 * dired.c (file_name_completion):
893 Use bool for boolean. (This was missed in an earlier change.)
894
95072a94
MR
8952012-08-27 Martin Rudalics <rudalics@gmx.at>
896
897 * window.c (Fset_window_configuration): Revert first part of
898 last change.
899
0f19feff
JD
9002012-08-27 Jan Djärv <jan.h.d@swipnet.se>
901
902 * nsterm.h (NSPanel): New class variable dialog_return.
903
904 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
905 dialog_return.
906 (windowShouldClose:): Use stop instead of stopModalWithCode.
907 (clicked:): Ditto, and also set dialog_return (Bug#12258).
908 (timeout_handler:): Use stop instead of abortModal. Send a dummy
909 event.
910 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
911 modal loop returns.
912
f10fe38f
PE
9132012-08-27 Paul Eggert <eggert@cs.ucla.edu>
914
de1339b0
PE
915 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
916 * composite.c (find_composition, composition_gstring_p)
917 (composition_reseat_it, find_automatic_composition):
918 * data.c (let_shadows_buffer_binding_p)
919 (let_shadows_global_binding_p, set_internal, make_blv)
920 (Fmake_variable_buffer_local, Fmake_local_variable)
921 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
922 (cons_to_signed, arith_driver):
923 * dbusbind.c (xd_in_read_queued_messages):
924 * dired.c (directory_files_internal, file_name_completion):
925 Use bool for booleans.
926 * dired.c (file_name_completion):
927 * process.h (fd_callback):
928 Omit int (actually boolean) argument. It wasn't being used.
929 All uses changed.
930 * composite.h, lisp.h: Reflect above API changes.
931
f10fe38f
PE
932 * cmds.c, coding.c: Use bool for booleans.
933 * cmds.c (move_point, Fself_insert_command):
934 * coding.h (struct composition status, struct coding_system):
935 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
936 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
937 (emacs_mule_char, decode_coding_emacs_mule)
938 (encode_coding_emacs_mule, detect_coding_iso_2022)
939 (decode_coding_iso_2022, encode_invocation_designation)
940 (encode_designation_at_bol, encode_coding_iso_2022)
941 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
942 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
943 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
944 (encode_coding_raw_text, detect_coding_charset)
945 (decode_coding_charset, encode_coding_charset, detect_eol)
946 (detect_coding, get_translation_table, produce_chars)
947 (consume_chars, reused_workbuf_in_use)
948 (make_conversion_work_buffer, code_conversion_save)
949 (decode_coding_object, encode_coding_object)
950 (detect_coding_system, char_encodable_p)
951 (Funencodable_char_position, code_convert_region)
952 (code_convert_string, code_convert_string_norecord)
953 (Fset_coding_system_priority):
954 * fileio.c (Finsert_file_contents):
955 Use bool for booleans.
956 * coding.h, lisp.h: Reflect above API changes.
957 * coding.c: Remove unnecessary static function decls.
958 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
959 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
960 not a boolean 'int', since callers never look at the return value.
961 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
962 * coding.h (decoding_buffer_size, encoding_buffer_size)
963 (emacs_mule_string_char): Remove unused extern decls.
964 (struct iso_2022_spec, struct coding_system):
965 Use 'unsigned int : 1' for boolean fields, since there's more than one.
966 (struct emacs_mule_spec): Remove unused field 'full_support'.
967 All initializations removed.
968 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
969
5474c384
DA
9702012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
971
f10fe38f 972 Fix spare memory change (Bug#12286).
5474c384
DA
973 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
974 (valid_lisp_object_p): Likewise.
975
c4b6914d
MR
9762012-08-27 Martin Rudalics <rudalics@gmx.at>
977
978 * window.c (Fset_window_configuration): Record any window's old
979 buffer if it's replaced (see Bug#8789). If the new current
980 buffer doesn't appear in the selected window, go to its old
981 point (Bug#12208).
982
35aaa1ea
DA
9832012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
984
985 Special MEM_TYPE_SPARE to denote reserved memory.
986 * alloc.c (enum mem_type): New memory type.
987 (refill_memory_reserve): Use new type for spare memory.
988 This prevents live_cons_p and live_string_p from incorrect
989 detection of uninitialized objects from spare memory as live.
990
6af64513
PE
9912012-08-26 Paul Eggert <eggert@cs.ucla.edu>
992
8b2e00a3
PE
993 Spelling fixes.
994 * Makefile.in (.PHONY): versioclean -> versionclean.
995
b52d6985
PE
996 Remove unused external symbols.
997 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
998 * window.c (Qwindow_valid_p, decode_valid_window):
999 Now static, not extern.
1000 * data.c (Qinterval): Remove; unused.
1001 (syms_of_data): Do not define 'interval'.
1002 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
1003 * window.h (decode_valid_window):
1004 Remove decls.
1005
d5172d4f
PE
1006 * character.c, charset.c, chartab.c: Use bool for booleans.
1007 * character.c (lisp_string_width, string_count_byte8)
1008 (string_escape_byte8):
1009 * charset.c (charset_map_loaded, load_charset_map, read_hex):
1010 (load_charset_map_from_file, map_charset_chars)
1011 (Fdefine_charset_internal, define_charset_internal)
1012 (Fdeclare_equiv_charset, find_charsets_in_text)
1013 (Ffind_charset_region, char_charset, Fiso_charset):
1014 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
1015 (sub_char_table_set, sub_char_table_set_range)
1016 (char_table_set_range, optimize_sub_char_table)
1017 (map_sub_char_table):
1018 Use bool for boolean.
1019 * character.c (str_to_unibyte): Omit last boolean argument; it was
1020 always 0. All callers changed.
1021 * character.h, charset.h: Adjust to match previous changes.
1022 * character.h (char_printable_p): Remove decl of nonexistent function.
1023 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
1024 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
1025 are all boolean, so make them single-bit bitfields.
1026
6af64513
PE
1027 * lisp.h (ASET): Remove attempt to detect side effects.
1028 It was meant to be temporary and it often doesn't work,
1029 because when IDX has side effects the behavior of IDX==IDX
1030 is undefined. See Stefan Monnier in
1031 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
1032
e1f29348
BR
10332012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1034
1035 * lisp.h (functionp): New function (extracted from Ffunctionp).
1036 (FUNCTIONP): Use it.
1037 * eval.c (Ffunctionp): Use it.
1038
17c05d74
PE
10392012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1040
0f46bc75
PE
1041 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
1042 as that's faster and simpler than static storage. Don't bother
1043 with the g_main_context_query overhead if g_main_context_pending
1044 says no events are pending.
1045 (gfds, gfds_size): Remove these static vars.
1046 (xgselect_initialize): Remove; no longer needed.
1047 All uses and decls removed.
1048
ee4c0f69
PE
1049 * emacs.c (fatal_error_signal_hook): Remove.
1050 All uses removed. This leftover from old code was always 0.
1051
17c05d74
PE
1052 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
1053 * casefiddle.c (casify_object, casify_region):
1054 * casetab.c (set_case_table):
1055 * category.c, category.h (word_boundary_p):
1056 * category.h (CHAR_HAS_CATEGORY):
1057 Use bool for booleans, instead of int.
1058
391ceac5
EZ
10592012-08-25 Eli Zaretskii <eliz@gnu.org>
1060
1061 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
1062
2f221583
PE
10632012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1064
f4a681b0
PE
1065 On assertion failure, print backtrace if available.
1066 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
1067 (die) [ENABLE_CHECKING]: Print a backtrace if available.
1068 * Makefile.in (LIB_EXECINFO): New macro.
1069 (LIBES): Use it.
1070
2f221583
PE
1071 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
1072 * bytecode.c (exec_byte_code):
1073 * callint.c (check_mark, Fcall_interactively):
1074 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
1075 (getenv_internal, sync_process_alive, call_process_exited):
1076 * lisp.h (USE_SAFE_ALLOCA):
1077 Use bool for booleans, instead of int.
1078 * lisp.h, process.h: Adjust prototypes to match above changes.
1079 * callint.c (Fcall_interactively): Don't assume the mark's
1080 offset fits in 'int'.
1081
37ef52bb
PE
10822012-08-24 Paul Eggert <eggert@cs.ucla.edu>
1083
1084 * buffer.c, buffer.h: Use bool for boolean.
1085 * buffer.c (reset_buffer_local_variables)
1086 (buffer_lisp_local_variables, Fset_buffer_modified_p)
1087 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
1088 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
1089 (overlay_touches_p, overlay_strings, Foverlay_put)
1090 (report_overlay_modification, call_overlay_mod_hooks):
1091 (mmap_enlarge, mmap_set_vars):
1092 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
1093 Use bool for booleans, instead of int.
1094 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
1095 since the 1-or-0 return value is always ignored anyway.
1096 (mmap_initialized_p):
1097 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
1098 * buffer.h, lisp.h: Adjust prototypes to match above changes.
1099
2cc21167
PE
11002012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1101
1102 * bidi.c: Use bool for boolean.
1103 This is a bit more readable, and makes the text segment of bidi.o
1104 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
1105 Presumably it's faster too.
1106 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
1107 Now bool.
1108 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1109 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
1110 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
1111 (bidi_explicit_dir_char, bidi_level_of_next_char)
1112 (bidi_find_other_level_edge, bidi_move_to_visually_next):
1113 Use bool for booleans, instead of int.
1114 * dispextern.h (bidi_init_it, bidi_paragraph_init)
1115 (bidi_unshelve_cache): Adjust decls to match code.
1116
7db4ddf4
MR
11172012-08-23 Martin Rudalics <rudalics@gmx.at>
1118
1119 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
1120 argument.
1121
b1bb8011
PE
11222012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1123
1124 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
1125 * atimer.h: Include <stdbool.h>.
1126
ff687885
DN
11272012-08-22 Dan Nicolaescu <dann@gnu.org>
1128
1129 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
1130 compile time tests instead of run time tests on systems that do
1131 not use them.
1132 (FRAME_MAC_P): Remove leftover from deleted code.
1133 * frame.c (syms_of_frame): Remove leftover from deleted code.
1134
4ce7a138
JD
11352012-08-22 Jan Djärv <jan.h.d@swipnet.se>
1136
1137 * nsterm.m (insertText:): Don't clear modifiers if code is space.
1138
d733ec6d
PE
11392012-08-22 Paul Eggert <eggert@cs.ucla.edu>
1140
1141 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
1142 Otherwise, the compiler complains about (A?B:C) where B is void
1143 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
1144 (fontset_add): Return void, for FONTSET_ADD.
1145
d0d2d26f
PE
11462012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1147
fce31d69
PE
1148 * alloc.c: Use bool for booleans.
1149 (gc_in_progress, abort_on_gc)
1150 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1151 (dont_register_blocks) [GC_MALLOC_CHECK]:
1152 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
1153 (check_string_bytes, make_specified_string, memory_full)
1154 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
1155 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
1156 (mark_stack, valid_pointer_p, make_pure_string)
1157 (Fgarbage_collect, survives_gc_p, gc_sweep):
1158 Use bool for booleans, instead of int.
1159 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1160 Remove unused local.
1161 * alloc.c (PURE_POINTER_P):
1162 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
1163 * editfns.c (Fformat):
1164 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
1165 (Fdo_auto_save):
1166 * fns.c (sweep_weak_table):
1167 * lisp.h (suppress_checking, push_message, survives_gc_p)
1168 (make_pure_string, gc_in_progress, abort_on_gc):
1169 * lread.c (readchar, read1):
1170 * print.c (Fprin1_to_string):
1171 * xdisp.c (push_message):
1172 Use bool for booleans affected directly or indirectly by
1173 alloc.c's changes.
1174
d0d2d26f
PE
1175 Make recently-introduced setters macros.
1176 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
1177 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
1178 (set_fontset_default, set_fontset_fallback): Rename from their
1179 upper-case counterparts, and make them functions rather than macros.
1180 This is more consistent with the other recently-introduced setters.
1181 These don't need to be inline, since they're local.
1182
d18e2bb6
JD
11832012-08-21 Jan Djärv <jan.h.d@swipnet.se>
1184
1185 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
1186 the loop (Bug#12247).
1187
1b9d9d16
PE
11882012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1189
1190 * lisp.h (vcopy): Use memcpy rather than our own loop.
1191 This fixes a performance regression introduced by the recent
1192 addition of vcopy. This means 'vcopy' will need to be modified
1193 for a copying collector, but that's OK. Also, tighten the
1194 checking in the assertion.
1195
b2f09701
EZ
11962012-08-21 Eli Zaretskii <eliz@gnu.org>
1197
1198 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
1199 components for RTL text (Bug#11860). Adjust X-OFFSET of each
1200 non-base glyph for the width of the base character, according to
e1f29348
BR
1201 what x_draw_composite_glyph_string_foreground expects.
1202 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
1203 expectations, to produce correct width of the composed character.
1204 Reverse the sign of the DU offset produced by ScriptPlace.
1205
9b994fed
PE
12062012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1207
1208 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
1209
086ca913
DA
12102012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1211
1212 Avoid direct writes to contents member of struct Lisp_Vector.
1213 * lisp.h (vcopy): New function to copy data into vector.
1214 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
1215 * fns.c (Ffillarray): Use ASET.
1216 * keyboard.c (timer_check_2): Use AREF and ASET.
1217 (append_tool_bar_item, Frecent_keys): Use vcopy.
1218 * lread.c (read_vector): Use ASET.
1219 * msdos.c (Frecent_doskeys): Use vcopy.
1220 * xface.c (Finternal_copy_lisp_face): Use vcopy.
1221 (Finternal_merge_in_global_face): Use ASET and vcopy.
1222 * xfont.c (xfont_list_pattern): Likewise.
1223
5481664a
MR
12242012-08-21 Martin Rudalics <rudalics@gmx.at>
1225
1226 * window.c (Fwindow_point): For the selected window always return
1227 the position of its buffer's point.
1228 (Fset_window_point): For the selected window always go in its
1229 buffer to the specified position.
1230
6d470bdd
DA
12312012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1232
1233 Setter macros for fontsets.
1234 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
1235 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
1236 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
1237 Adjust users.
1238
24564fe1
GM
12392012-08-20 Glenn Morris <rgm@gnu.org>
1240
1241 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1242 Don't assume that `ln -f' works.
1243
0a05a035
EZ
12442012-08-20 Eli Zaretskii <eliz@gnu.org>
1245
1246 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
1247 and later about non-assignments with no effect. See discussion at
1248 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
1249 details.
1250
e46f2325
DA
12512012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1252
1253 Inline setter functions for Lisp_Objects slots of struct specbinding.
1254 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
1255 Adjust users.
1256
734fbd86
MR
12572012-08-20 Martin Rudalics <rudalics@gmx.at>
1258
1259 * window.c (select_window): Always make selected window's buffer
1260 current.
1261
f1a95992
DA
12622012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1263
1264 Use AREF and ASET for docstrings of category tables.
1265 * category.h (CATEGORY_DOCSTRING): Use AREF.
1266 (SET_CATEGORY_DOCSTRING): Use ASET.
1267 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
1268
e83064be
DA
12692012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1270
1271 Inline setter functions for hash table members.
1272 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
1273 (set_hash_hash, set_hash_index): Rename with _slot suffix.
1274 (set_hash_key_and_value, set_hash_index, set_hash_next)
1275 (set_hash_hash): New functions.
1276 * charset.c, fns.c: Adjust users.
1277
4ce60d2e
DA
12782012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1279
1280 Inline getter and setter functions for per-buffer values.
1281 * buffer.h (per_buffer_default, set_per_buffer_default)
1282 (per_buffer_value, set_per_buffer_value): New functions.
1283 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
1284 * buffer.c, data.c: Adjust users.
1285
c06c9690
JB
12862012-08-20 Juanma Barranquero <lekktu@gmail.com>
1287
1288 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
1289
32bd4250
PE
12902012-08-19 Paul Eggert <eggert@cs.ucla.edu>
1291
bad03192 1292 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
1293 as gnulib does this if the system doesn't.
1294 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
1295 Remove declaration. MS-Windows declares it on stdlib.h which is
1296 included by conf_post.h.
b69a6d22
PE
1297 * emacs.c (environ) [DOUG_LEA_MALLOC]:
1298 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
1299 * vm-limit.c: Include <unistd.h>, for 'environ'.
1300
22d7feb2
PE
1301 * unexaix.c, unexcoff.c: Include "mem-limits.h".
1302 (start_of_data): Remove decl; mem-limits.h provides it.
1303
32bd4250
PE
1304 * xdisp.c (handle_invisible_prop): Make it a bit faster
1305 and avoid a gcc -Wmaybe-uninitialized diagnostic.
1306
450809af
CY
13072012-08-19 Chong Yidong <cyd@gnu.org>
1308
1309 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
1310 ends (Bug#3874).
1311
9e677988
AS
13122012-08-19 Andreas Schwab <schwab@linux-m68k.org>
1313
6b1319ce
AS
1314 * .gdbinit: Use call instead of set when calling a function in the
1315 inferior.
1316
9e677988
AS
1317 * data.c (set_internal): Don't use set_blv_found.
1318 (Fkill_local_variable): Likewise.
1319
d7191076
AA
13202012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
1321
1322 * nsfont.m (ns_ascii_average_width): Ensure the string
1323 ascii_printable is initialized with a null-terminated character
1324 array. Otherwise, it can contain undesired extra characters.
1325
e757f1c6
PE
13262012-08-18 Paul Eggert <eggert@cs.ucla.edu>
1327
1328 port new setting code to Sun C 5.8 2005/10/13
1329 * chartab.c, lisp.h (char_table_set, char_table_set_range):
1330 Return void, not Lisp_Object. Otherwise, the compiler
1331 complains about (A?B:C) where B is void and C is Lisp_Object
1332 when compiling CHAR_TABLE_SET, due to the recent change to
1333 the API of sub_char_table_set_contents.
1334
a999ce26
CY
13352012-08-18 Chong Yidong <cyd@gnu.org>
1336
1337 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
1338 for the string case (Bug#3874).
1339
3f22b86f
PE
13402012-08-18 Paul Eggert <eggert@cs.ucla.edu>
1341
39eb03f1
PE
1342 * buffer.h (BSET): Remove (Bug#12215).
1343 Replace all uses with calls to new setter functions.
1344 (bset_bidi_paragraph_direction, bset_case_canon_table)
1345 (bset_case_eqv_table, bset_directory, bset_display_count)
1346 (bset_display_time, bset_downcase_table)
1347 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
1348 (bset_last_selected_window, bset_local_var_alist)
1349 (bset_mark_active, bset_point_before_scroll, bset_read_only)
1350 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
1351 (bset_width_table):
1352 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
1353 (bset_auto_fill_function, bset_auto_save_file_format)
1354 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
1355 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
1356 (bset_cache_long_line_scans, bset_case_fold_search)
1357 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
1358 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
1359 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
1360 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
1361 (bset_header_line_format, bset_indicate_buffer_boundaries)
1362 (bset_indicate_empty_lines, bset_invisibility_spec)
1363 (bset_left_fringe_width, bset_major_mode, bset_mark)
1364 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
1365 (bset_name, bset_overwrite_mode, bset_pt_marker)
1366 (bset_right_fringe_width, bset_save_length)
1367 (bset_scroll_bar_width, bset_scroll_down_aggressively)
1368 (bset_scroll_up_aggressively, bset_selective_display)
1369 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
1370 (bset_word_wrap, bset_zv_marker):
1371 * category.c (bset_category_table):
1372 * syntax.c (bset_syntax_table):
1373 New setter functions.
1374
6a09a33b
PE
1375 * process.h (PSET): Remove (Bug#12215).
1376 Replace all uses with calls to new setter functions.
1377 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1378 (PROCESS_INLINE): New macro.
1379 (pset_childp): New setter function.
1380 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
1381 * process.c (PROCESS_INLINE):
1382 Define to EXTERN_INLINE, so that the corresponding functions
1383 are compiled into code.
1384 (pset_buffer, pset_command, pset_decode_coding_system)
1385 (pset_decoding_buf, pset_encode_coding_system)
1386 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
1387 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
1388 (pset_type, pset_write_queue): New setter functions.
1389
e8c17b81
PE
1390 * window.h (WSET): Remove (Bug#12215).
1391 Replace all uses with calls to new setter functions.
1392 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1393 (WINDOW_INLINE): New macro.
1394 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
1395 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
1396 (wset_total_lines, wset_vertical_scroll_bar)
1397 (wset_window_end_pos, wset_window_end_valid)
1398 (wset_window_end_vpos): New setter functions.
1399 * window.c (WINDOW_INLINE):
1400 Define to EXTERN_INLINE, so that the corresponding functions
1401 are compiled into code.
1402 (wset_combination_limit, wset_dedicated, wset_display_table)
1403 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
1404 (wset_new_normal, wset_new_total, wset_next_buffers)
1405 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
1406 (wset_prev_buffers, wset_right_fringe_width)
1407 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
1408 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
1409 (wset_window_parameters):
1410 * xdisp.c (wset_base_line_number, wset_base_line_pos)
1411 (wset_column_number_displayed, wset_region_showing):
1412 New setter functions.
1413
3f22b86f
PE
1414 * termhooks.h (TSET): Remove (Bug#12215).
1415 Replace all uses with calls to new setter functions.
1416 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1417 (TERMHOOKS_INLINE): New macro.
1418 (tset_charset_list, tset_selection_alist): New setter functions.
1419 * terminal.c (TERMHOOKS_INLINE):
1420 Define to EXTERN_INLINE, so that the corresponding functions
1421 are compiled into code.
1422 (tset_param_alist): New setter function.
1423
742af32f
PE
14242012-08-17 Paul Eggert <eggert@cs.ucla.edu>
1425
15dbb4d6
PE
1426 * keyboard.h (KSET): Remove (Bug#12215).
1427 Replace all uses with calls to new setter functions.
1428 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1429 (KEYBOARD_INLINE): New macro.
1430 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
1431 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
1432 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
1433 New setter functions.
1434 * keyboard.c (KEYBOARD_INLINE):
1435 Define to EXTERN_INLINE, so that the corresponding functions
1436 are compiled into code.
1437 (kset_echo_string, kset_kbd_queue)
1438 (kset_keyboard_translate_table, kset_last_prefix_arg)
1439 (kset_last_repeatable_command, kset_local_function_key_map)
1440 (kset_overriding_terminal_local_map, kset_real_last_command)
1441 (kset_system_key_syms): New setter functions.
1442
f00af5b1
PE
1443 * frame.h (FSET): Remove (Bug#12215).
1444 Replace all uses with calls to new setter functions.
1445 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1446 (FRAME_INLINE): New macro.
1447 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
1448 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
1449 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
1450 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
1451 (fset_param_alist, fset_root_window, fset_scroll_bars)
1452 (fset_selected_window, fset_title, fset_tool_bar_items)
1453 (fset_tool_bar_position, fset_tool_bar_window): New functions.
1454 * frame.c (FRAME_INLINE):
1455 Define to EXTERN_INLINE, so that the corresponding functions
1456 are compiled into code.
1457 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
1458
0c94c8d6
PE
1459 A few more naming-convention fixes for getters and setters.
1460 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
1461 and rename from buffer_overlays_set_before.
1462 (set_buffer_overlays_after): Move here from buffer.h, and rename
1463 from buffer_overlays_set_after.
1464 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
1465 All uses changed.
1466 (set_buffer_intervals): Rename from buffer_set_intervals.
1467 * intervals.c (set_interval_object): Move here from intervals.h,
1468 and rename from interval_set_object.
1469 (set_interval_left): Move here from intervals.h, and rename from
1470 interval_set_left.
1471 (set_interval_right): Move here from intervals.h, and rename from
1472 interval_set_right.
1473 (copy_interval_parent): Move here from intervals.h, and rename from
1474 interval_copy_parent.
1475 * intervals.h (set_interval_parent): Rename from interval_set_parent.
1476 (set_interval_plist): Rename from interval_set_plist.
1477 Return void, not Lisp_Object, since no caller uses the result.
1478 * lisp.h (string_intervals): Rename from string_get_intervals.
1479 (set_string_intervals): Rename from string_set_intervals.
1480
34dabdb7
PE
1481 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
1482 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 1483 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
1484 All uses changed. See the end of
1485 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
1486
742af32f
PE
1487 * lisp.h (CSET): Remove (Bug#12215).
1488 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
1489 (set_char_table_purpose): New functions,
1490 replacing CSET. All uses changed. For example, replace
1491 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 1492 "set_char_table_parent (char_table, parent);".
742af32f
PE
1493 The old version was confusing because it used the same name
1494 'parent' for two different things.
1495
a04e2c62
DA
14962012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1497
1498 Functions to get and set Lisp_Object fields of buffer-local variables.
1499 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
1500 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
1501 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
1502 * data.c, eval.c, frame.c: Adjust users.
1503
383dcbf9
CY
15042012-08-17 Chong Yidong <cyd@gnu.org>
1505
1506 * xfaces.c (merge_face_vectors): If the target font specfies a
1507 font spec, make the font's attributes take precedence over
1508 directly-specified attributes.
1509 (merge_face_ref): Recognize :font.
1510
44386687
DA
15112012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1512
1513 Do not use memcpy for copying intervals.
1514 * intervals.c (reproduce_interval): New function.
1515 (reproduce_tree, reproduce_tree_obj): Use it.
1516 (reproduce_tree_obj): Remove prototype.
1517
927c7216
PE
15182012-08-17 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 * lisp.h (duration_to_sec_usec): Remove unused decl.
1521
93044f7b
AA
15222012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
1523
1524 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
1525 to an allocated instance of NSString, not to the class itself.
1526
9851e4a5
JB
15272012-08-17 Juanma Barranquero <lekktu@gmail.com>
1528
1529 * makefile.w32-in (C_CTYPE_H): New macro.
1530 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
1531 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
1532 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
1533
620f13b0
PE
15342012-08-16 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 Use ASCII tests for character types.
1537 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
1538 * xfns.c, xterm.c:
1539 Don't include <ctype.h>; was not needed.
1540 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
1541 * sysdep.c, xfaces.c:
1542 Include <c-ctype.h> instead of <ctype.h>.
1543 * nsterm.m: Include <c-ctype.h>.
1544 * charset.c (read_hex):
1545 * doc.c (Fsnarf_documentation):
1546 * fileio.c (IS_DRIVE) [WINDOWSNT]:
1547 (DRIVE_LETTER) [DOS_NT]:
1548 (Ffile_name_directory, Fexpand_file_name)
1549 (Fsubstitute_in_file_name):
1550 * font.c (font_parse_xlfd, font_parse_fcname):
1551 * frame.c (x_set_font_backend):
1552 * gtkutil.c (xg_get_font):
1553 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
1554 * nsimage.m (hexchar):
1555 * nsterm.m (ns_xlfd_to_fontname):
1556 * sysdep.c (system_process_attributes):
1557 * xfaces.c (hash_string_case_insensitive):
1558 Use C-locale tests instead of locale-specific tests for character
1559 types, since we want the ASCII interpretation here, not the
1560 interpretation suitable for whatever happens to be the current locale.
1561
52162052
MR
15622012-08-16 Martin Rudalics <rudalics@gmx.at>
1563
1564 Consistently check windows for validity/liveness
1565 (Bug#11984, Bug#12025, Bug#12026).
1566 * lisp.h (CHECK_VALID_WINDOW): New macro.
1567 * window.c (decode_window): Rename to decode_live_window.
1568 (decode_valid_window, Fwindow_valid_p): New functions.
1569 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
1570 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
1571 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
1572 (Fwindow_prev_sibling, Fwindow_combination_limit)
1573 (Fset_window_combination_limit, Fwindow_use_time)
1574 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
1575 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
1576 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
1577 (Fwindow_hscroll, Fset_window_hscroll)
1578 (Fwindow_redisplay_end_trigger)
1579 (Fset_window_redisplay_end_trigger, Fwindow_edges)
1580 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
1581 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1582 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
1583 (Fwindow_end, Fset_window_point, Fset_window_start)
1584 (Fpos_visible_in_window_p, Fwindow_line_height)
1585 (Fwindow_dedicated_p, Fset_window_dedicated_p)
1586 (Fwindow_prev_buffers, Fset_window_prev_buffers)
1587 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
1588 (Fset_window_parameter, Fwindow_display_table)
1589 (Fset_window_display_table, Fdelete_other_windows_internal)
1590 (Fset_window_buffer, Fset_window_new_total)
1591 (Fset_window_new_normal, Fdelete_window_internal)
1592 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
1593 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
1594 (Fwindow_scroll_bars): Check whether argument window is a valid or
1595 live window. Update doc-strings.
1596 (syms_of_window): New symbol Qwindow_valid_p.
1597 * keyboard.c (Fposn_at_x_y): Check whether argument
1598 frame_or_window denotes a valid window.
1599
2751c80f
DA
16002012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1601
1602 Fix previous char table change.
1603 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
1604 * chartab.c (optimize_sub_char_table): Likewise.
1605
032a42c8
CY
16062012-08-16 Chong Yidong <cyd@gnu.org>
1607
a2d19368
CY
1608 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
1609
032a42c8
CY
1610 * xfont.c (xfont_open):
1611 * xftfont.c (xftfont_open): Set the font's max_width field.
1612
1613 * nsfont.m (nsfont_open): Similar to the Xft backend, set
1614 min_width to space_width and average_width to the average over
1615 printable ASCII characters.
1616 (ns_char_width): Code cleanup.
1617 (ns_ascii_average_width): New utility function.
1618
1619 * font.h (struct font): Update comments.
1620
a098c930
DA
16212012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1622
032a42c8 1623 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
1624 * lisp.h (CSET): New macro.
1625 (char_table_set_extras, char_table_set_contents)
1626 (sub_char_table_set_contents): New function.
1627 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
1628 * syntax.c: Adjust users.
1629
8be3a09c
SM
16302012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
1631
1632 * eval.c (eval_sub): Bind lexical-binding.
1633 * lread.c (Qlexical_binding): Make non-static.
1634
ac4845a6
JD
16352012-08-15 Jan Djärv <jan.h.d@swipnet.se>
1636
ddee6515
JD
1637 * nsmenu.m (popupSession): Remove.
1638 (pop_down_menu): Remove endModalSession.
1639 (timeout_handler:): New method.
1640 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
1641 Call runModalForWindow. Check timer_fired when it returns.
1642 If not set, cancel timer and break out of loop.
1643 Otherwise loop again, with a new timeout.
1644
1645 * nsterm.m: Include fcntl.h if present.
1646 (fd_entry, t_readfds, inNsSelect): Remove.
1647 (select_writefds, select_valid, select_timeout, selfds)
1648 (select_mutex, apploopnr): Add.
1649 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
1650 Otherwise call kbd_buffer_store_event.
1651 (ns_send_appdefined): Remove release of fd_entry.
1652 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
1653 Increment and decrement apploopnr.
1654 (ns_select): If no file descriptors, just do a NSTimer.
1655 Otherwise copy read/write masks and start select thread (fd_handler).
1656 Start main loop and wait for application defined event.
1657 Inform select thread to stop selecting after main loop is exited.
1658 (ns_term_init): Create selfds pipe and set non-blocking.
1659 Initialize select_mutex. Start the select thread (fd_handler).
1660 (fd_handler:): Loop forever, wait for info from the main thread
1661 to either start or stop selecting. When select returns, send
1662 and appdefined event.
1663 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
1664 If not call kbd_buffer_store_event.
1665
1666 * nsterm.h (EmacsApp): fd_handler takes id argument.
1667 (EmacsDialogPanel): Add timer_fired and timeout_handler.
1668
ac4845a6
JD
1669 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
1670
eb424fe3
EZ
16712012-08-15 Eli Zaretskii <eliz@gnu.org>
1672
1673 * region-cache.c (move_cache_gap): Update gap_len using the actual
1674 growth of the boundaries array. Do not change cache_len.
1675 (Bug#12196)
1676
4e6a86c6
DA
16772012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1678
1679 Generalize and cleanup font subsystem checks.
1680 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
1681 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
1682 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 1683
5bf192ca
DA
16842012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1685
1686 * gtkutil.c (xg_get_font): Use pango_units_to_double.
1687
f2045622
CY
16882012-08-15 Chong Yidong <cyd@gnu.org>
1689
8be3a09c
SM
1690 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
1691 When using the new font chooser, use gtk_font_chooser_get_font_desc to
1692 extract the font descriptor instead of just the font name.
1693 In that case, return a font spec instead of a string.
f2045622
CY
1694 (x_last_font_name): Move to this file from xfns.c.
1695
1696 * xfns.c (Fx_select_font): The return value can also be a font
1697 spec. Move x_last_font_name management to gtkutil.c.
1698
1699 * xfaces.c: Make font weight and style symbols non-static.
1700
7f6feb56
SM
17012012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
1702
1703 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
1704 (bug#12117).
1705
fecbd8ff
SM
17062012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
1707
1708 * alloc.c (Fgarbage_collect): Use plural form consistently.
1709
9b8d5165
EZ
17102012-08-14 Eli Zaretskii <eliz@gnu.org>
1711
1712 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
1713 iteration through the command loop. Fixes a problem whereby mouse
1714 movements are ignored until the first mouse click.
1715
f5d9e83a
PE
17162012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1717
1718 Use bool, not int, for Lisp booleans.
1719 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
1720 makes Emacs a bit smaller and presumably a bit faster.
1721 * lisp.h: Include <stdbool.h>.
1722 (struct Lisp_Boolfwd, defvar_bool):
1723 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
1724 * regex.c [!emacs]: Include <stdbool.h>.
1725 (false, true): Remove; <stdbool.h> does this for us now.
1726
55802e4a
CY
17272012-08-14 Chong Yidong <cyd@gnu.org>
1728
4abcdac8
CY
1729 * character.c (Fcharacterp): Doc fix (Bug#12076).
1730
1731 * data.c (Findirect_variable): Doc fix (Bug#11040).
1732
55802e4a
CY
1733 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
1734
1735 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 1736 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 1737
8e99d072
BR
17382012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1739
1740 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
1741 (bug#12022).
1742
08908aca
MR
17432012-08-14 Martin Rudalics <rudalics@gmx.at>
1744
1745 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
1746 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1747 * minibuf.c (choose_minibuf_frame, read_minibuf):
1748 * w32fns.c (x_create_tip_frame):
1749 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
1750 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
1751
56120d6f
PE
17522012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1753
1754 * intervals.c (offset_intervals): Remove obsolete comment.
1755
67b77c0b
AS
17562012-08-14 Andreas Schwab <schwab@linux-m68k.org>
1757
1758 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
1759
f48b82fd
GR
17602012-08-14 Gergely Risko <gergely@risko.hu>
1761
1762 * coding.c (decode_coding): Record buffer modification before
1763 disabling undo_list (Bug#11773).
1764
fd318b54
DA
17652012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1766
1767 Revert and cleanup some recent overlay changes.
1768 * buffer.h (enum overlay_type): Remove.
1769 (buffer_get_overlays, buffer_set_overlays): Likewise.
1770 (buffer_set_overlays_before, buffer_set_overlays_after):
1771 New function. Adjust users.
1772 (unchain_both): Add eassert.
1773
41a62dd9
DA
17742012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1775
1776 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
1777
5884c324
PE
17782012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1779
1780 * gtkutil.c (xg_mark_data): Don't assume C99.
1781
ca06f160
JD
17822012-08-13 Jan Djärv <jan.h.d@swipnet.se>
1783
1784 * gtkutil.c (xg_frame_tb_info): New struct.
1785 (TB_INFO_KEY): New define.
1786 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
1787 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
1788 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
1789 if not present.
1790 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
1791 is up to date. Otherwise store new data.
1792 (free_frame_tool_bar): Free xg_frame_tb_info if present.
1793
7864a3f7
DA
17942012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1795
1796 Use KSET for write access to Lisp_Object members of struct kboard.
1797 * keyboard.h (KSET): New macro.
1798 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
1799 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
1800 * xterm.c: Adjust users.
1801
4c31be61
DA
18022012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1803
1804 Use BSET for write access to Lisp_Object members of struct buffer.
1805 * buffer.h (BSET): New macro.
1806 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
1807 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
1808 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
1809 * window.c, xdisp.c, xfns.c: Adjust users.
1810
14ae4239
BT
18112012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
1812
1813 * lread.c (syms_of_lread): Initialize Vlexical_binding.
1814
32bcadb4
JD
18152012-08-11 Jan Djärv <jan.h.d@swipnet.se>
1816
3d29b2ce
JD
1817 * nsterm.m (not_in_argv): New function.
1818 (application:openFile, application:openTempFile:):
1819 (application:openFileWithoutUI:, application:openFiles:): Open file
1820 if not_in_argv returns non-zero (bug#12171).
1821
32bcadb4 1822 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
1823 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
1824 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
1825 (xg_get_font_name): Use those functions/macros here.
1826 Reported by Frans Oilinki <moilinki@gmail.com>.
1827
9ff9402d 18282012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
1829
1830 * unexmacosx.c (copy_data_segment): Copy initialized data in
1831 statically linked libraries from input file rather than memory.
1832
db74a5fc
YM
1833 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
1834 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
1835 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
1836
25e65510
GM
18372012-08-10 Glenn Morris <rgm@gnu.org>
1838
1839 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
1840 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
1841
7961135c
DA
18422012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1843
1844 Fix last change to allow compilation with low optimization levels.
1845 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
1846 Reported by Jan Djärv <jan.h.d@swipnet.se>.
1847
42b3a444
DA
18482012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1849
1850 Use common inline syntax in intervals.h.
1851 * intervals.h (INTERVALS_INLINE): New macro.
1852 Change all users from LISP_INLINE.
1853
9fb0c957
DA
18542012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1855
1856 Define Qnone once for all platforms.
1857 * frame.c (Qnone): Define here.
1858 (syms_of_frame): DEFSYM it.
1859 * lisp.h (Qnone): New declaration.
1860 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
1861 * xfns.c: Remove duplication. Adjust users.
1862
65e8ee52
DA
18632012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1864
1865 Remove unused macros from intervals.h.
1866 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
1867 * intervals.c: Adjust comment.
1868
9b855fd6
EZ
18692012-08-10 Eli Zaretskii <eliz@gnu.org>
1870
1871 * w32fns.c <w32_unicode_gui>: New static variable.
1872 (globals_of_w32fns): Initialize it according to os_subtype.
1873 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
1874 testing os_subtype.
1875
39cb9e56 18762012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
1877 Eli Zaretskii <eliz@gnu.org>
1878
1879 Fix bug #10299 with Unicode characters sent by customized
1880 keyboards created by MSKLC.
1881 * w32fns.c (INIT_WINDOW_CLASS): New macro.
1882 (w32_init_class): Use it to initialize the Emacs class with either
1883 ANSI or Unicode API calls.
1884 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
1885 later.
1886 (w32_wnd_proc): If the character code sent by WM_CHAR or
1887 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
1888 original message. Call DefWindowProcW on NT and later.
1889
9374581a
GM
18902012-08-10 Glenn Morris <rgm@gnu.org>
1891
4b94e8cf
GM
1892 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
1893
9374581a
GM
1894 * lisp.h (DIRECTORY_SEP): Let configure set it.
1895
a2752828
DA
18962012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1897
1898 Use TSET for write access to Lisp_Object slots of struct terminal.
1899 * termhooks.h (TSET): New macro.
1900 * coding.c, terminal.c, xselect.c: Adjust users.
1901
cc92c454
SM
19022012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
1903
1904 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
1905 the failing expression, include them in the error message.
1906 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
1907 * lisp.h (internal_condition_case_n): Update declaration.
1908
4cb3e6b3
DA
19092012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1910
1911 Inline functions to examine and change buffer overlays.
1912 * buffer.c (unchain_both): New function.
1913 * buffer.h (buffer_get_overlays, buffer_set_overlays):
1914 (buffer_has_overlays): New function.
1915 (enum overlay_type): New enum.
1916 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
1917 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
1918
8707c1e5
DA
19192012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1920
1921 Inline functions to examine and change buffer intervals.
1922 * alloc.c (mark_interval_tree): Remove.
1923 (MARK_INTERVAL_TREE): Simplify.
1924 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
1925 * intervals.c (buffer_balance_intervals): New function.
1926 (graft_intervals_into_buffer): Adjust indentation.
1927 (set_intervals_multibyte): Simplify.
1928 * buffer.h (BUF_INTERVALS): Remove.
1929 (buffer_get_intervals, buffer_set_intervals): New function.
1930 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
1931 * intervals.c, textprop.c: Adjust users.
1932
ad8c997f
DA
19332012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1934
1935 Inline functions to examine and change string intervals.
1936 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
1937 (string_get_intervals, string_set_intervals): New function.
1938 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1939 * lread.c, print.c, textprop.c: Adjust users.
1940
32ac3a6b
GM
19412012-08-08 Glenn Morris <rgm@gnu.org>
1942
1943 * lisp.mk (lisp): Remove language/persian.elc.
1944
77c7bcb1
DA
19452012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1946
1947 Cleanup intervals.
1948 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
1949 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
1950 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
1951 Adjust comment. Move under #if 0.
77c7bcb1
DA
1952 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1953 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
1954
9c08a8d4
DA
19552012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1956
1957 Check total length of intervals with eassert.
1958 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
1959 * intervals.c: Change all users to eassert.
1960
26d16b35
EZ
19612012-08-07 Eli Zaretskii <eliz@gnu.org>
1962
14ae4239
BT
1963 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
1964 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
1965 INTERNAL_FIELD in Lisp_Cons.
1966
c644523b
DA
19672012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1968
1969 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
1970 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
1971 name since all xname users are fixed long time ago. Do not
1972 use INTERNAL_FIELD.
1973 (set_symbol_name, set_symbol_function, set_symbol_plist):
1974 (set_symbol_next, set_overlay_plist): New function.
1975 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
1976 (struct Lisp_Overlay): Likewise.
1977 (CVAR, MVAR, SVAR): Remove.
1978 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
1979 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
1980 * xterm.c: Adjust users.
1981 * .gdbinit: Change to use name field of struct Lisp_Symbol
1982 where appropriate.
1983
6a3d20cc
DA
19842012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1985
1986 Basic functions to set Lisp_Object and pointer slots of intervals.
1987 * intervals.h (interval_set_parent, interval_set_object):
1988 (interval_set_left, interval_set_right, interval_set_plist):
1989 (interval_copy_parent): New function.
1990 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
1991 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
1992 Adjust indentation.
6a3d20cc
DA
1993 (INTERVAL_SIZE): Remove. Adjust users.
1994 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
1995
4d2b044c
DA
19962012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1997
1998 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
1999 * process.h (PGET): Remove.
2000 (struct Lisp_Process): Do not use INTERNAL_FIELD.
2001 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2002
d3d50620
DA
20032012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2004
2005 Drop WGET and revert read access to Lisp_Objects slots of struct window.
2006 * window.h (WGET): Remove.
2007 (struct window): Do not use INTERNAL_FIELD.
2008 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2009 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2010 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2011 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2012 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2013 Adjust users.
2014
d10a51dc
CY
20152012-08-07 Chong Yidong <cyd@gnu.org>
2016
2017 * window.c (Fwindow_edges, Fwindow_pixel_edges)
2018 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
2019 (Fdelete_window_internal): Signal an error if the window is not on
2020 a live frame (Bug#12025).
2021
e69b0960
DA
20222012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2023
2024 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
2025 * frame.h (FGET): Remove.
2026 (struct frame): Do not use INTERNAL_FIELD.
2027 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2028 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2029 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2030 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2031
25a20a3a
JB
20322012-08-06 Juanma Barranquero <lekktu@gmail.com>
2033
2034 * w32.c: Silence compiler warnings.
2035 (map_w32_filename): Remove unused variable `is_fat'.
2036 (chase_symlinks): Add parentheses around expression.
2037
1c6f11f4
GM
20382012-08-06 Glenn Morris <rgm@gnu.org>
2039
1db4583a
GM
2040 * sysdep.c: Respect BROKEN_GETWD.
2041
1c6f11f4
GM
2042 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
2043 Let configure handle it.
2044 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
2045
2b90362b
DA
20462012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2047
2048 Use GCALIGNMENT where appropriate.
2049 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
2050 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
2051 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
2052
5f50daf2
EZ
20532012-08-06 Eli Zaretskii <eliz@gnu.org>
2054
14ae4239
BT
2055 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
2056 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 2057
cbcc7007
SM
20582012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
2059
2060 * buffer.h (struct buffer): Revert `indirections' to a simple int;
2061 that should be sufficient for everyone.
2062
4d365fa4
JD
20632012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2064
2065 * keyboard.c (timer_check_2): Add break so timer_check returns next
2066 timeout.
2067
dd86bd82
DA
20682012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2069
2070 Fix Windows build errors introduced after converting to WGET and WSET.
2071 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
2072 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2073
054e1668
JD
20742012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2075
2076 * nsterm.m (ns_frame_rehighlight): Use FSET.
2077
2078 * nsmenu.m (ns_update_menubar): Use FSET.
2079
21238f11
DA
20802012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2081
2082 Separate read and write access to Lisp_Object slots of Lisp_Process.
2083 * process.h (PGET, PSET): New macros similar to AREF and ASET.
2084 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2085
077288cf
DA
20862012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2087
2088 Separate read and write access to Lisp_Object slots of struct window.
2089 * window.h (WGET, WSET): New macros similar to AREF and ASET.
2090 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2091 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2092 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2093 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2094 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2095 Adjust users.
2096
71688bd7
DA
20972012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2098
2099 Fix Windows build errors introduced after converting to FGET and FSET.
2100 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
2101 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
2102 (w32_judge_scroll_bars): Change to use FSET.
2103 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2104
f99bac93
DA
21052012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2106
2107 Fix replacement typo.
2108 * window.c (replace_window): Set root_window instead of
2109 selected_window. This fixes a total window subsystem
2110 malfunction reported by Bastien Guerry <bzg@gnu.org>.
2111
8c2a0f2d
GM
21122012-08-06 Glenn Morris <rgm@gnu.org>
2113
2114 * lisp.mk (lisp): Add language/persian.elc.
2115
edd74c35
DA
21162012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2117
2118 Separate read and write access to Lisp_Object slots of struct frame.
2119 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
2120 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2121 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2122 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2123 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2124
8671676c
AS
21252012-08-05 Andreas Schwab <schwab@linux-m68k.org>
2126
2127 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
2128
663e2b3f
DA
21292012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2130
2131 Generalize common compile-time constants.
2132 * lisp.h (header_size, bool_header_size, word_size): Now here.
2133 (struct Lisp_Vector): Add comment.
2134 (struct Lisp_Bool_Vector): Move up to define handy constants.
2135 (VECSIZE, PSEUDOVECSIZE): Simplify.
2136 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
2137 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
2138 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
2139 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
2140 * xfont.c, xmenu.c: Use word_size where appropriate.
2141
d32e47af
LM
21422012-08-05 Lawrence Mitchell <wence@gmx.li>
2143
2144 * search.c (Freplace_match): Treat \? in the replacement text
2145 literally (Bug#8161).
2146
e5d9c0d1
CY
21472012-08-05 Chong Yidong <cyd@gnu.org>
2148
2149 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
2150 * frame.c (Vdelete_frame_functions):
2151 * emacs.c (Vkill_emacs_hook): Doc fix.
2152
8da0576b
EZ
21532012-08-04 Eli Zaretskii <eliz@gnu.org>
2154
2155 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
2156 --with-x-toolkit=no builds.
2157 Reported by Carsten Mattner <carstenmattner@gmail.com>.
2158
02676e5d
CY
21592012-08-04 Chong Yidong <cyd@gnu.org>
2160
2161 * syntax.c (Fmodify_syntax_entry): Doc fix.
2162
97147da9
EZ
21632012-08-04 Eli Zaretskii <eliz@gnu.org>
2164
76151e2c
EZ
2165 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
2166 * w32.c (init_environment): Change the default values of many
2167 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
2168 them into environment when they were not already defined.
2169 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 2170 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
2171 (check_windows_init_file): Now external, not static.
2172 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
2173 called when Vload_path is already set up.
2174
2175 * w32.h (check_windows_init_file): Add prototype.
2176
2177 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
2178 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
2179 compatibility with Posix platforms.
2180 (main): Move the call to check_windows_init_file to here from
2181 w32.c.
2182 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
2183 any, in the DEFALT argument into the root of the Emacs build or
2184 installation tree, as appropriate.
2185
2186 * callproc.c (init_callproc_1): Call decode_env_path instead of
2187 doing its equivalent by hand.
2188 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
2189 the code that sets Vexec_path run on MS-Windows.
2190
2191 * lread.c (init_lread): Add comments to #ifdef's.
2192
97147da9
EZ
2193 * msdos.c (dos_set_window_size, IT_update_begin)
2194 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
2195 instead of direct references.
2196
185ee146
PE
21972012-08-04 Paul Eggert <eggert@cs.ucla.edu>
2198
2199 Export DEFAULT_REHASH_* to GDB.
2200 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
2201 Now constants, not macros.
2202
8834c57a
PE
22032012-08-03 Paul Eggert <eggert@cs.ucla.edu>
2204
98c6f1e3
PE
2205 Remove unnecessary casts involving pointers.
2206 These casts are no longer needed now that we assume C89 or later,
2207 since they involve casting to or from void *.
2208 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
2209 (make_pure_float, make_pure_vector):
2210 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
2211 * macros.c (Fstart_kbd_macro):
2212 * menu.c (find_and_return_menu_selection):
2213 * minibuf.c (read_minibuf_noninteractive):
2214 * sysdep.c (closedir):
2215 * xdisp.c (x_produce_glyphs):
2216 * xfaces.c (compare_fonts_by_sort_order):
2217 * xfns.c (x_real_positions, select_visual):
2218 * xselect.c (x_stop_queuing_selection_requests)
2219 (x_get_window_property, x_get_window_property_as_lisp_data):
2220 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
2221 Remove unnecessary pointer casts.
2222 * alloc.c (record_xmalloc): New function.
2223 * lisp.h (record_xmalloc): New decl.
2224 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
2225 more like a function. This is because the pointer cast is not
2226 needed. All uses changed.
2227 * print.c (print_string, print_error_message): Avoid length recalc.
2228
8834c57a
PE
2229 Improve fix for macroexp crash with debugging (Bug#12118).
2230 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
2231 ARRAY_MARK_FLAG when checking subscripts, because ASET is
2232 not supposed to be invoked from the garbage collector.
2233 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
2234 (gc_aset): New function, which is like ASET but can be
2235 used in the garbage collector.
2236 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
2237 (set_hash_index): Use it instead of ASET.
2238
6dad7178
EZ
22392012-08-03 Eli Zaretskii <eliz@gnu.org>
2240
2241 Support symlinks on latest versions of MS-Windows.
2242 * w32.c: Include winioctl.h and aclapi.h.
2243 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
2244 (revert_to_self): Forward declarations of static functions.
2245 <static BOOL g_b_init_get_security_info>:
2246 <g_b_init_create_symbolic_link>: New static flags.
2247 (globals_of_w32): Initialize them to zero.
2248 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
2249 (map_w32_filename): Improve commentary. Simplify switch.
2250 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
2251 headers (most versions of MinGW w32api don't).
2252 (get_security_info, create_symbolic_link)
2253 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
2254 New functions.
2255 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
2256 in the argument file name.
2257 (sys_access): Call unc_volume_file_attributes only if
2258 GetFileAttributes fails with network-related error codes.
2259 (sys_rename): Diagnose renaming of a symlink when the user doesn't
2260 have the required privileges.
14ae4239 2261 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
2262 get_file_security_desc.
2263 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
2264 with addition of handling of symlinks and support for 'lstat'.
2265 If possible, get file's attributes and security information by
6dad7178
EZ
2266 handle, not by name. Produce S_IFLNK bit for symlinks, when
2267 called from 'lstat'.
2268 (stat, lstat): New functions, call 'stat_worker'.
2269 (symlink, readlink, careadlinkat): Rewritten to create and resolve
2270 symlinks when the underlying filesystem supports them.
2271
f162bcc3
PE
22722012-08-02 Paul Eggert <eggert@cs.ucla.edu>
2273
79ea6c20
PE
2274 Fix macroexp crash on Windows with debugging (Bug#12118).
2275 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
2276 checking subscripts; problem introduced with the recent
2277 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
2278 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
2279 since it's used in non-static inline functions now.
2280
c0ce93fd
PE
2281 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
2282 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 2283
f162bcc3
PE
2284 Use C99-style 'extern inline' if available.
2285 * buffer.h (BUFFER_INLINE):
2286 * category.h (CATEGORY_INLINE):
2287 * character.h (CHARACTER_INLINE):
2288 * charset.h (CHARSET_INLINE):
2289 * composite.h (COMPOSITE_INLINE):
2290 * dispextern.h (DISPEXTERN_INLINE):
2291 * lisp.h (LISP_INLINE):
2292 * systime.h (SYSTIME_INLINE):
2293 New macro, replacing 'static inline' in this header.
2294 * buffer.h, category.h, character.h, charset.h, composite.h:
2295 * dispextern.h, lisp.h, systime.h:
2296 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2297 * alloc.c (LISP_INLINE):
2298 * buffer.c (BUFFER_INLINE):
2299 * category.c (CATEGORY_INLINE):
2300 * character.c (CHARACTER_INLINE):
2301 * charset.c (CHARSET_INLINE):
2302 * composite.c (COMPOSITE_INLINE):
2303 * dispnew.c (DISPEXTERN_INLINE):
2304 * sysdep.c (SYSTIME_INLINE):
2305 Define to EXTERN_INLINE, so that the corresponding functions
2306 are compiled into code.
2307 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
2308 (INLINE_HEADER_END): New macros.
2309 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
2310 since it's used in non-static inline functions now.
a8333d03 2311 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 2312
837b365b
GM
23132012-08-02 Glenn Morris <rgm@gnu.org>
2314
d66b744d
GM
2315 * s/: Remove empty directory.
2316
837b365b
GM
2317 * s/ms-w32.h: Move to ../nt/inc.
2318 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
2319 Update for new ms-w32.h location.
2320
13294f95
PE
23212012-08-02 Paul Eggert <eggert@cs.ucla.edu>
2322
2323 Port to Solaris 8.
2324 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
2325
90df0db3
GM
23262012-08-02 Glenn Morris <rgm@gnu.org>
2327
2328 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
2329 hard-coding the path separator.
2330
4939150c
PE
23312012-08-01 Paul Eggert <eggert@cs.ucla.edu>
2332
2333 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
2334 This how ASET and AREF are supposed to work, and makes
2335 it easier to think about future improvements. See
2336 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
2337 * charset.h (set_charset_attr): New function.
2338 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
2339 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
2340 (aref_addr): New function. All uses of &AREF(...) changed.
2341 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
2342 (set_hash_index): New functions. All lvalue-style uses of
2343 HASH_KEY etc. changed.
2344 * keyboard.c (set_prop): New function. All lvalue-style uses
2345 of PROP changed.
2346
947b2afd
AA
23472012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
2348
2349 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
2350 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
2351 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
2352 * nsfns.m (ns_set_name_as_filename): Likewise.
2353 * nsmenu.m (ns_update_menubar): Likewise.
2354 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
2355
4f5d0325
EZ
23562012-08-01 Eli Zaretskii <eliz@gnu.org>
2357
2008beae
EZ
2358 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
2359 Adapt to latest changes in field names of the corresponding Lisp
288479f6 2360 objects.
2008beae 2361
4f5d0325
EZ
2362 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
2363
fe3cc771
GM
23642012-08-01 Glenn Morris <rgm@gnu.org>
2365
2366 * s/msdos.h: Remove file.
2367 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
2368 * Makefile.in (S_FILE): Remove.
2369 (config_h): Remove S_FILE.
2370
c90acc54
JB
23712012-08-01 Juanma Barranquero <lekktu@gmail.com>
2372
2373 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
2374 Remove; moved to nt/config.nt.
2375
d8a05828
DA
23762012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2377
2378 Use INTERNAL_FIELD for conses and overlays.
2379 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
2380 Remove obsolete comment.
2381 (MVAR): New macro.
2382 (struct Lisp_Overlay): Use INTERNAL_FIELD.
2383 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
2384
8271d590
DA
23852012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2386
2387 Use INTERNAL_FIELD for symbols.
2388 * lisp.h (SVAR): New macro. Adjust users.
2389 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
2390 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
2391
3193acd2
DA
23922012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2393
2394 Use INTERNAL_FIELD for processes.
2395 * process.h (PVAR): New macro. Adjust style.
2396 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
2397 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
2398
3a45383a
DA
23992012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2400
2401 Use INTERNAL_FIELD for windows.
2402 * window.h (WVAR): New macro.
2403 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
2404 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2405 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2406 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
2407 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
2408 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
2409
c1dbc63c
PE
24102012-08-01 Paul Eggert <eggert@cs.ucla.edu>
2411
2412 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
2413
5c0c0e8a
GM
24142012-08-01 Glenn Morris <rgm@gnu.org>
2415
2416 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
2417 Move to configure.ac.
2418
552a99b4
JB
24192012-08-01 Juanma Barranquero <lekktu@gmail.com>
2420
2421 * makefile.w32-in (CONFIG_H): Update dependencies.
2422 (CONF_POST_H): New macro.
2423
2424 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
2425
8d8e2dfe
GM
24262012-07-31 Glenn Morris <rgm@gnu.org>
2427
bc96620a
GM
2428 * Makefile.in (S_FILE): No longer set by configure.
2429
476b1b2d
GM
2430 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
2431 is available.
2432 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
2433
b2c7a106
GM
2434 * process.h (NULL_DEVICE):
2435 * emacs.c (SEPCHAR):
2436 * editfns.c (USER_FULL_NAME): Let configure set them.
2437
d53d062a
GM
2438 * s/README, s/template.h: Remove files.
2439
4515017f
GM
2440 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
2441
8d8e2dfe
GM
2442 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
2443 Move to configure.ac.
2444
5b20b3cc
EZ
24452012-07-31 Eli Zaretskii <eliz@gnu.org>
2446
1e0afd9a
EZ
2447 * .gdbinit (xframe): Adapt to introduction of FVAR and the
2448 resulting renaming of 'struct frame' members.
2449
5b20b3cc
EZ
2450 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
2451
2452 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
2453 after introduction of FVAR.
2454
f1310128
JD
24552012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2456
79e721e0
JD
2457 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
2458
2459 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
2460 instead of compositeToPoint.
2461 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
2462
8d7c7eed 2463 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 2464
e34f7f79
DA
24652012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2466
2467 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
2468 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 2469 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
2470 (BVAR): Change to use INTERNAL_FIELD.
2471 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
2472 (KVAR): Change to use INTERNAL_FIELD.
2473 * frame.h (FVAR): New macro.
2474 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
2475 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
2476 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
2477 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
2478 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
2479
c09bfb2f
DA
24802012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2481
2482 Miscellaneous fixes for non-default X toolkits.
2483 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
2484 * xterm.c (x_frame_of_widget): Remove redundant prototype.
2485 Move under #ifdef USE_LUCID.
2486 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
2487 definition and usage to avoid warnings.
2488
14c114ae
JD
24892012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2490
2491 * nsterm.m (openFiles): Fix previous checkin.
2492
3bd21e82
PE
24932012-07-31 Paul Eggert <eggert@cs.ucla.edu>
2494
2495 * indent.c (compute_motion): Remove unused local.
2496
c1529ded
GM
24972012-07-31 Glenn Morris <rgm@gnu.org>
2498
400d5621
GM
2499 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
2500
268e2432
GM
2501 * conf_post.h [USG5_4]:
2502 Move remaining contents of s/usg5-4-common.h here.
2503 * s/usg5-4-common.h: Remove file.
2504
7552f3ee
GM
2505 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
2506 * s/irix6-5.h: Remove file.
2507
6a381852
GM
2508 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
2509 * s/darwin.h: Remove file.
2510
c1529ded
GM
2511 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
2512 * s/hpux10-20.h: Remove file, which is now empty.
2513
b429a4ee
GM
25142012-07-30 Glenn Morris <rgm@gnu.org>
2515
2516 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
2517 * Makefile.in (config_h): Add conf_post.h.
2518 * makefile.w32-in (CONFIG_H): Add conf_post.h.
2519
adff3182
JD
25202012-07-30 Jan Djärv <jan.h.d@swipnet.se>
2521
2522 * nsterm.m (ns_do_open_file): New variable.
b9031d69 2523 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
2524 (openFile, openTempFile, openFileWithoutUI, openFiles):
2525 Open files only if ns_do_open_file.
adff3182 2526
c32af1e4
PE
25272012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2528
7393bcbb
PE
2529 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
2530 This no-op macro hasn't been needed for many years.
2531 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
2532
c32af1e4
PE
2533 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
2534 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
2535 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
2536 gdb_make_enums_visible.
2537 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
2538 (DIRECTORY_SEP): Now a constant, not a macro.
2539
302fc036
EZ
25402012-07-30 Eli Zaretskii <eliz@gnu.org>
2541
2542 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
2543 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
2544
2545 * w32term.c <w32_keyboard_codepage>: Renamed from
2546 keyboard_codepage and now external. All users changed.
2547
2548 * w32term.h: Add declaration of w32_keyboard_codepage.
2549
2550 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
2551 the codepage to translate keys to Unicode. If this argument is
2552 -1, use the value returned by GetConsoleCP. All callers changed.
2553
88fb40b4
PE
25542012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2555
0aee6912
PE
2556 Update .PHONY listings in makefiles.
2557 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
2558 bootstrap-clean, distclean, maintainer-clean, versioclean,
2559 extraclean, frc.
2560
88fb40b4
PE
2561 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
2562 This is a bit clearer. Fix some commentary typos.
2563
0a763bd1
GM
25642012-07-30 Glenn Morris <rgm@gnu.org>
2565
32bac6d6
GM
2566 * s/netbsd.h: Let configure include signal.h if needed.
2567 Remove file, which is now empty.
2568
b65e7c46
GM
2569 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
2570 Let configure set them.
2571 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
2572 No more need to undefine.
0a763bd1 2573
169304bd
AS
25742012-07-30 Andreas Schwab <schwab@linux-m68k.org>
2575
2576 * keymap.c (Fkey_description): Don't remove 0x80 bit from
2577 non-single-byte char when adding meta modifier. (Bug#12090)
2578
6cd7a139
DA
25792012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2580
2581 Convert safe_call to use variable number of arguments.
2582 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
2583 (safe_call2): Fix comment.
2584 * lisp.h (safe_call): Adjust prototype.
2585 * coding.c (encode_coding_object): Change to use safe_call2.
2586 * xfaces.c (merge_face_heights): Change to use safe_call1.
2587
d34d6ffc
GM
25882012-07-30 Glenn Morris <rgm@gnu.org>
2589
7b8a48e4 2590 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 2591 does that unconditionally. Remove file, which is now empty.
7b8a48e4 2592
d34d6ffc
GM
2593 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
2594 Remove empty files.
2595
03a660a6
PE
25962012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2597
2598 Export to GDB most of lisp.h's remaining object-like macros.
2599 * lisp.h (min, max): Move earlier, because they're used earlier now.
2600 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
2601 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
2602 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
2603 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
2604 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
2605 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
2606 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
2607 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
2608 Now constants, for GDB. They need not be macros.
2609 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
2610 Now constants, for GDB, as well as macros, for static initializers.
2611 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
2612 Move to after the definition of struct Lisp_Char_Table,
2613 since the former now needs that type defined.
2614 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
2615 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
2616 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
2617 New enums, for gdb_make_enums_visible.
2618 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 2619 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
2620 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
2621 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
2622 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
2623 enum maxargs, enum MAX_ALLOCA.
2624 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
2625 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
2626 no longer needed, now that they are done in lisp.h.
2627
e499d0ee
DA
26282012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2629
2630 Cleanup string bytes checking.
2631 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
2632 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
2633 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
2634 (check_sblock, compact_small_strings): Simplify.
2635
d5040d2d
PE
26362012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2637
2638 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
2639 These macros are confusing and no longer need to be defined, as
2640 the enum values now suffice. All uses replaced with definiens.
2641 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
2642
7f259ae6
JB
26432012-07-29 Juanma Barranquero <lekktu@gmail.com>
2644
2645 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
2646 ($(BLD)/w32console.$(O)): Update dependencies.
2647
7e63e0c3
DA
26482012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2649
2650 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
2651 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
2652 time. Adjust users.
2653 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
2654
ffd817eb
JD
26552012-07-29 Jan Djärv <jan.h.d@swipnet.se>
2656
2657 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
2658 setting sitelisp (Bug#12010).
2659
417a7a0e
EZ
26602012-07-29 Eli Zaretskii <eliz@gnu.org>
2661
14ae4239 2662 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
2663
2664 * w32heap.c (cache_system_info):
2665 * w32.c (sys_rename):
2666 * w32proc.c (find_child_console, sys_kill): All users changed.
2667
387d4d92
PE
26682012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2669
2670 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
2671
55a6cca6
EZ
26722012-07-29 Eli Zaretskii <eliz@gnu.org>
2673
2674 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
2675
dbcf001c
DA
26762012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2677
2678 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
2679 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
2680 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 2681
e2688e4a
DA
26822012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2683
2684 Generalize marker debugging code under MARKER_DEBUG and use eassert.
2685 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
2686 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
2687 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
2688 (replace_range, replace_range_2, del_range_2): Change to eassert.
2689 * marker.c (byte_char_debug_check): Adjust style.
2690
b46a6a83
PE
26912012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
2694 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
2695 long-ago-commented-out code that talks about "WIN32".
2696 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
2697 All uses changed.
2698
e32a5799
PE
26992012-07-28 Paul Eggert <eggert@cs.ucla.edu>
2700
2701 Use Gnulib stdalign module (Bug#9772, Bug#9960).
2702 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
2703 Simplify by using alignof.
2704 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
2705 * lisp.h: Include <stdalign.h>.
2706 (GCALIGNMENT): New macro and constant.
2707 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
2708 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
2709 (stdalign): New macro, if not already defined.
2710
df81cd29
EZ
27112012-07-28 Eli Zaretskii <eliz@gnu.org>
2712
01bd1b0d
EZ
2713 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
2714 * w32inevt.c: Include w32inevt.h.
2715 (w32_read_console_input): New inline function, calls either
2716 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
2717 w32_console_unicode_input.
2718 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
2719 (w32_kbd_patch_key, key_event): Use the codepage returned by
2720 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
2721 (key_event): use uChar.UnicodeChar only if
2722 w32_console_unicode_input is non-zero.
2723
2724 * w32console.c: Include w32heap.h.
2725 <w32_console_unicode_input>: New global variable.
2726 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
2727 family of Windows, zero otherwise.
2728
2729 * w32inevt.h: Declare w32_console_unicode_input.
2730
df81cd29
EZ
2731 * xdisp.c (init_iterator): Don't reference tip_frame in a build
2732 --without-x. (Bug#11742)
2733
c20fdd9e
PE
27342012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2735
2736 Adjust GDB to reflect pvec_type changes (Bug#12036).
2737 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
2738 2012-07-04 changes to pseudovector representation.
2739 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 2740
32770973 27412012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
2742
2743 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
2744 bus address.
2745 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
2746
3438fe21
EZ
27472012-07-27 Eli Zaretskii <eliz@gnu.org>
2748
bcfbc9de
EZ
2749 * alloc.c (listn): Fix the order the arguments are consed onto the
2750 list.
2751
3438fe21
EZ
2752 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
2753 enumeration constants, as PURE and HEAP are too general, and clash
2754 with other headers and sources, such as gmalloc.c and the
2755 MS-Windows system headers. All users changed.
2756
eeaea515
DA
27572012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2758
2759 Revert last save_excursion_save and save_excursion_restore changes.
2760 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
2761 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
2762
073c88c2
DA
27632012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2764
2765 Fix recently-introduced typos in Windows port.
2766 Reported by Martin Rudalics <rudalics@gmx.at>.
2767 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 2768 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 2769
4706125e
PE
27702012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2771
2772 Improve GDB symbol export (Bug#12036).
2773 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
2774 arms of an 'if', not using conditional expressions; otherwise GDB
2775 complains about the types in the unevaluated arm when the argument
2776 is an integer literal.
2777 (xgetint): Simplify expression.
2778 * alloc.c (gdb_make_enums_visible): New constant. This ports to
2779 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
2780 Zaretskii in <http://bugs.gnu.org/12036#13>.
2781 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
2782 needed now that we have gdb_make_enums_visible.
2783 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
2784 (enum enum_USE_LSB_TAG):
2785 New enum types, packaging up enums that need to be exported to GDB.
2786
694b6c97
DA
27872012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2788
2789 Utility function to make a list from specified amount of objects.
2790 * lisp.h (enum constype): New datatype.
2791 (listn): New prototype.
2792 * alloc.c (listn): New function.
2793 (Fmemory_use_count, syms_of_alloc): Use it.
2794 * buffer.c (syms_of_buffer): Likewise.
2795 * callint.c (syms_of_callint): Likewise.
2796 * charset.c (define_charset_internal): Likewise.
2797 * coding.c (syms_of_coding): Likewise.
2798 * keymap.c (syms_of_keymap): Likewise.
2799 * search.c (syms_of_search): Likewise.
2800 * syntax.c (syms_of_syntax): Likewise.
2801 * w32.c (init_environment): Likewise.
2802 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
2803 * xdisp.c (syms_of_xdisp): Likewise.
2804 * xfns.c (syms_of_xfns): Likewise.
2805
6195f384
DA
28062012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2807
2808 Fast save_excursion_save and save_excursion_restore.
2809 * lisp.h (struct Lisp_Excursion): New data type.
2810 (PVEC_EXCURSION): New pseudovector type.
2811 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
2812 to deal with it. Adjust comments.
2813 (init_marker, attach_marker): New prototype.
2814 (unchain_marker): Adjust prototype.
2815 * marker.c (attach_marker): Change to global.
2816 (init_marker): New function.
2817 * alloc.c (Fmake_marker, build_marker): Use it.
2818 (build_marker): More easserts.
2819 (mark_object): Handle struct Lisp_Excursion.
2820 * editfns.c (save_excursion_save, save_excursion_restore):
2821 Reimplement to use struct Lisp_Excursion. Add comments.
2822
5eceb8fb
PE
28232012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2824
2825 Fix export of symbols to GDB (Bug#12036).
2826 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
2827 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
2828 emacs.c, as this is a more-suitable home. Had this been done earlier
2829 the fix for 12036 would have avoided some of the problems noted in
2830 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
2831 would have been more obvious.
562157c8
PE
2832 * emacs.c: Do not include <verify.h>; no longer needed.
2833 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
2834 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
2835 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2836 Remove; now done in lisp.h.
2837 * lisp.h (PUBLISH_TO_GDB): New macro.
2838 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
2839 (DATA_SEG_BITS): Use it.
2840 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
2841 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
2842 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
2843 not be usable in #if. This simplifies things.
2844
d6749401
JB
28452012-07-26 Juanma Barranquero <lekktu@gmail.com>
2846
2847 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
2848
1781b9e9
PE
28492012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2850
d89518db 2851 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
2852 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
2853 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
2854 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
2855 Adjust to changes in lisp.h and emacs.c, by using
2856 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
2857 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
2858 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
2859 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
2860 instead of gdb_valbits.
2861 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
2862 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
2863 instead of gdb_array_mark_flag.
2864 (xboolvector): Get size from $->size, not $->header.size.
2865 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
2866 (xreload, hook-run, hookpost-run): Remove.
2867 * emacs.c: Include <verify.h>.
2868 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
2869 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
2870 Remove.
2871 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
2872 (gdb_USE_LSB_TAG): New enum constants.
2873 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2874 Also define these as enum constants, so they're visible to GDB.
2875 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
2876 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
2877 as constants, so they're visible to GDB.
2878 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
2879 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
2880 Now enum constants, not macros, so they're visible to GDB.
2881 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
2882 more convenient now. All uses changed.
2883 (VALMASK) [USE_LSB_TAG]: Also define in this case.
2884 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
2885
3628596a
DA
28862012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
2887
2888 Explicitly free restriction data that are not needed anymore.
2889 * editfns.c (save_restriction_restore): Free restriction data.
2890
7abaf5cc
SM
28912012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2892
2893 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
2894 add argument, tune behavior, and adjust all callers.
2895
71f88e00
PE
28962012-07-25 Paul Eggert <eggert@cs.ucla.edu>
2897
2898 Use typedef for EMACS_INT, EMACS_UINT.
2899 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
2900 than macros. This simplifies debugging in the usual case, since
2901 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
2902 and it allows expressions involving EMACS_INT casts.
2903 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
2904
57ec3034
JD
29052012-07-25 Jan Djärv <jan.h.d@swipnet.se>
2906
2907 * nsterm.m (ns_read_socket): Return early if there is a modal
2908 window (Bug#12043).
2909
8137e7b3
MR
29102012-07-25 Martin Rudalics <rudalics@gmx.at>
2911
2912 * frame.c (Fredirect_frame_focus): In doc-string don't mention
2913 that FOCUS-FRAME can be omitted.
2914
04e9897c
DA
29152012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
2916
2917 Adjust buffer text indirection counters at the end of Fkill_buffer.
2918 * buffer.c (Fkill_buffer): Adjust indirection counters when the
2919 buffer is definitely dead. This should really fix an issue reported
2920 by Christoph Scholtes again. (Bug#12007).
2921 (init_buffer_once): Initialize indirection counters of
2922 buffer_defaults and buffer_local_symbols (for sanity and safety).
2923
8a0484e1
EZ
29242012-07-24 Eli Zaretskii <eliz@gnu.org>
2925
2926 * xdisp.c (init_iterator): Don't compute dimensions of truncation
2927 and continuation glyphs on tooltip frames, leave them at zero.
2928 Avoids continued lines in tooltips. (Bug#11832)
2929
fa691a83
DA
29302012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
2931
2932 Simplify copy_overlay.
04e9897c 2933 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
2934 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
2935
436bc8e0
EZ
29362012-07-23 Eli Zaretskii <eliz@gnu.org>
2937
2938 * print.c (print_object): Don't crash when a frame's name is nil
2939 or invalid. (Bug#12025)
2940
2941 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
2942 it signals an error when a tooltip frame is being created.
2943
d7a7fda3
DA
29442012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
2945
2946 Cleanup miscellaneous objects allocation and initialization.
2947 * alloc.c (allocate_misc): Change to static. Add argument to
2948 specify the subtype. Adjust comment and users.
2949 (build_overlay): New function.
2950 * buffer.c (copy_overlays, Fmake_overlay): Use it.
2951 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
2952 (allocate_misc): Remove prototype.
2953 (build_overlay): Add prototype.
2954
29552012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
2956
2957 Swap buffer text indirection counters in Fbuffer_swap_text.
2958 * buffer.c (Fbuffer_swap_text): Swap indirections too.
2959 This avoids crash reported by Christoph Scholtes at
2960 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
2961
9d7fa573
JD
29622012-07-22 Jan Djärv <jan.h.d@swipnet.se>
2963
2964 * nsmenu.m (Popdown_data): New struct.
2965 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
2966 free Popdown_data.
2967 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
2968 (initWithContentRect): Make imgView and contentView non-static
2969 and autorelease them. Also autorelease img and matrix (Bug#12005).
2970 (dealloc): Remove (Bug#12005).
2971
0dd6d66d
DA
29722012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2973
2974 Adjust consing_since_gc when objects are explicitly freed.
2975 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
2976 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
2977 (free_cons, free_misc): Subtract object size from consing_since_gc.
2978
d36d71df
DA
29792012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2980
2981 Simplify and cleanup markers positioning code.
2982 * marker.c (attach_marker): More useful eassert.
2983 (live_buffer, set_marker_internal): New function.
2984 (Fset_marker, set_marker_restricted): Use set_marker_internal.
2985 (set_marker_both, set_marker_restricted_both): Use live_buffer.
2986
fb9ea40f
PE
29872012-07-22 Paul Eggert <eggert@cs.ucla.edu>
2988
2989 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
2990 as it's limited by the amount of memory, not by INT_MAX.
2991
2d5c5f7d
EZ
29922012-07-21 Eli Zaretskii <eliz@gnu.org>
2993
07fb592e
EZ
2994 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
2995 in special-event-map. See the discussion at
2996 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
2997 for the reasons.
2998
37a9eac8 2999 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
3000 info.dwItemData. Fixes crashes on 64-bit Windows.
3001 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 3002
c4328746
JD
30032012-07-21 Jan Djärv <jan.h.d@swipnet.se>
3004
3005 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 3006 (conversationIdentifier): Return value is NSInteger.
784051c4 3007 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 3008
6e5d1c12
CY
30092012-07-21 Chong Yidong <cyd@gnu.org>
3010
3011 * window.c (decode_any_window): Signal an error if the window is
3012 on a dead frame (Bug#11984).
3013
9928463d
DA
30142012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3015
3016 Add indirection counting to speed up Fkill_buffer.
3017 * buffer.h (struct buffer): New member.
3018 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
3019 (Fmake_indirect_buffer): Set indirection counter to -1, increment
3020 base buffer indirection counter.
3021 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
3022 (Fkill_buffer): Adjust indirection counters as needed, don't walk
3023 through buffer list if indirection counter is 0.
3024
f8643a6b
DA
30252012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3026
3027 Extend the value returned by Fgarbage_collect with heap statistics.
3028 * alloc.c (Qheap): New symbol.
3029 (syms_of_alloc): DEFSYM it.
3030 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
3031 (Fmemory_free): Remove.
3032 (syms_of_alloc): Don't defsubr it.
3033 * buffer.c (Fcompact_buffer): Remove.
3034 (syms_of_buffer): Don't defsubr it.
3035
dac616ff
DA
30362012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3037
3038 Make maybe_gc inline.
3039 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
3040 * lisp.h (consing_since_gc, gc_relative_threshold)
3041 (memory_full_cons_threshold): Revert declaration.
3042 (maybe_gc): Remove prototype, define as inline.
3043 * alloc.c: Remove old commented-out code.
3044 (consing_since_gc, gc_relative_threshold)
3045 (memory_full_cons_threshold): Revert to global.
3046 (maybe_gc): Remove.
3047
d7ea76b4
DA
30482012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3049
3050 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
3051 * lisp.h (build_unibyte_string): New function.
3052 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
3053 * sysdep.c, w32fns.c, xfns.c: Use it.
3054 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
3055 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
3056 Adjust users accordingly.
3057 * font.h (font_open_by_name): Adjust prototype.
3058
765e61e3
DA
30592012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3060
3061 Cleanup calls to Fgarbage_collect.
3062 * lisp.h (maybe_gc): New prototype.
3063 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3064 Remove declarations.
3065 * alloc.c (maybe_gc): New function.
3066 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3067 Make them static.
3068 * bytecode.c (MAYBE_GC): Use maybe_gc.
3069 * eval.c (eval_sub, Ffuncall): Likewise.
3070 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
3071 to avoid dependency from auto-save feature.
3072
52b852c7
PE
30732012-07-19 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
3076 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
3077 'for_each_per_buffer_object_at'.
3078 All uses changed. It's better to use upper-case for macros that
3079 cannot be implemented as functions, to give the reader a clue
3080 that they're special.
3081
5db81e33
SM
30822012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
3083
3084 * alloc.c (Fgarbage_collect): Tweak docstring.
3085
5b835e1d
DA
30862012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3087
3088 Tweak the value returned from Fgarbage_collect again.
3089 * alloc.c (Fgarbage_collect): New return value, as confirmed in
3090 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
3091 Adjust documentation.
3092 (total_vector_bytes): Rename to total_vector_slots, adjust
3093 accounting.
3094 (total_free_vector_bytes): Rename to total_free_vector_slots,
3095 adjust accounting.
3096 (Qstring_bytes, Qvector_slots): New symbols.
3097 (syms_of_alloc): DEFSYM them.
3098
9cd47b72
DA
30992012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3100
3101 Buffer compaction primitive which may be used from Lisp.
3102 * buffer.c (compact_buffer, Fcompact_buffer): New function.
3103 (syms_of_buffer): Register Fcompact_buffer.
3104 * alloc.c (Fgarbage_collect): Use compact_buffer.
3105 * buffer.h (compact_buffer): New prototype.
3106 (struct buffer_text): New member.
3107
d17337e5
DA
31082012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3109
3110 New macro to iterate over all buffers, miscellaneous cleanups.
3111 * lisp.h (all_buffers): Remove declaration.
3112 * buffer.h (all_buffers): Add declaration, with comment.
3113 (for_each_buffer): New macro.
3114 * alloc.c (Fgarbage_collect, mark_object): Use it.
3115 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
3116 (init_buffer): Likewise.
3117 * data.c (Fset_default): Likewise.
3118 * coding.c (code_conversion_restore): Remove redundant check
3119 for dead buffer.
3120 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
3121
60cfd278
AS
31222012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3123
3124 Fix bug that created negative-length intervals.
3125 * intervals.c (merge_interval_right, merge_interval_left):
3126 Do not zero out this interval if it is absorbed by its children,
3127 as this interval's total length doesn't change in that case. See
3128 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
3129
d06714cb
PE
31302012-07-18 Paul Eggert <eggert@cs.ucla.edu>
3131
83713154
PE
3132 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
3133 when invoking (make-bool-vector N t) and N is a positive
3134 multiple of 8 -- the last 8 bits were mistakenly cleared.
3135
d06714cb
PE
3136 Remove some struct layout assumptions in bool vectors.
3137 * alloc.c (bool_header_size): New constant.
3138 (header_size, word_size): Move earlier, as they're now used earlier.
3139 Use 'word_size' in a few more places, where it's appropriate.
3140 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
3141 padding before the data member of a bool vector.
3142 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
3143 than doing the check by hand with an abort ().
3144
464d5a5e
SM
31452012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3146
5fbc0409
SM
3147 * eval.c (Fdefvar): Don't check constants since we only set the var if
3148 it's not yet defined anyway (bug#11904).
3149
464d5a5e
SM
3150 * lisp.h (last_undo_boundary): Declare new var.
3151 * keyboard.c (command_loop_1): Set it.
3152 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
3153 were auto-added by the command loop (bug#11774).
3154
8dc2e44a
AS
31552012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3156
3157 * w32font.c (Qsymbol): Remove local definition.
3158 (syms_of_w32font): Don't DEFSYM it.
3159
169925ec
DA
31602012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3161
3162 Fix sweep_vectors to handle large bool vectors correctly.
3163 * alloc.c (sweep_vectors): Account total_vector_bytes for
3164 bool vectors larger than VBLOCK_BYTES_MAX.
3165
5fbfb018
CY
31662012-07-18 Chong Yidong <cyd@gnu.org>
3167
3168 * frame.c (x_set_frame_parameters): Revert bogus change introduced
3169 in 2012-05-25 commit by Paul Eggert (Bug#11738).
3170
3ab6e069
DA
31712012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3172
3173 Return more descriptive data from Fgarbage_collect.
3174 Suggested by Stefan Monnier in
3175 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
3176 * alloc.c (bounded_number): New function.
3177 (total_buffers, total_vectors): New variable.
3178 (total_string_size): Rename to total_string_bytes, adjust users.
3179 (total_vector_size): Rename to total_vector_bytes, adjust users.
3180 (sweep_vectors): Account total_vectors and total_vector_bytes.
3181 (Fgarbage_collect): New return value. Adjust documentation.
3182 (gc_sweep): Account total_buffers.
3183 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
3184 (VECTOR_SIZE): Remove.
3185 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
3186 (Qinterval, Qmisc): New symbols.
3187 (syms_of_data): Initialize them.
3188 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
3189 (Qcons, Qbuffer): New declarations.
3190
6d02fe5b
PE
31912012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3192
3193 * alloc.c (Fmemory_free): Account for memory-free's own storage.
3194 Round up, not down. Improve doc.
3195
b7ffe040
DA
31962012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3197
3198 Restore old code in allocate_string_data to avoid Faset breakage.
3199 Reported by Julien Danjou <julien@danjou.info> in
3200 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
3201 * alloc.c (allocate_string_data): Restore old code with minor
3202 adjustments, fix comment to explain this subtle issue.
3203
4dc7c8d5
SM
32042012-07-17 Eli Zaretskii <eliz@gnu.org>
3205
3206 Remove FILE_SYSTEM_CASE.
3207 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
3208
3209 * fileio.c (FILE_SYSTEM_CASE): Don't define.
3210 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
3211 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
3212 call-process-region passes it through expand-file-name.
3213
3214 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
3215
32162012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3217
3218 Fix crash when creating indirect buffer (Bug#11917)
3219 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
3220 Don't handle unbound variables specially if non-zero.
3221 (Fbuffer_local_variables): Pass zero.
3222 (clone_per_buffer_values): Pass non-zero.
3223
32242012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3225
3226 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
3227 to make the loop interruptible.
3228
32292012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3230
3231 * gnutls.c (emacs_gnutls_handshake): Only retry if
3232 GNUTLS_E_INTERRUPTED.
3233
cce7fefc
DA
32342012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3235
3236 Cleanup and convert miscellaneous checks to eassert.
3237 * alloc.c (mark_interval): Fix comment, partially rephrase
3238 old comment from intervals.h (see below).
3239 * intervals.c (find_interval, adjust_intervals_for_insertion)
3240 (delete_interval, adjust_intervals_for_deletion)
3241 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
3242 Convert to eassert.
3243 (adjust_intervals_for_insertion, make_new_interval):
3244 Remove obsolete and unused code.
3245 * intervals.h (struct interval): Remove obsolete comment.
3246 * textprotp.c (erase_properties): Remove unused code.
3247 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
3248 (Fremove_list_of_text_properties): Convert to eassert.
3249
9ea10cc3
CY
32502012-07-17 Chong Yidong <cyd@gnu.org>
3251
3252 * editfns.c (Finsert_char): Doc fix.
3253
3900d5de
DA
32542012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3255
3256 Fix previous change to make Fmemory_free always accurate.
3257 * alloc.c (make_interval): Update total_free_intervals.
3258 (make_float): Likewise for total_free_floats.
3259 (free_cons, Fcons): Likewise for total_free_conses.
3260 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
3261 Likewise for total_free_vector_bytes.
3262 (Fmake_symbol): Likewise for total_free_symbols.
3263 (bytes_free): Remove.
3264
7098646f
DA
32652012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3266
3267 Simple free memory accounting feature.
3268 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
3269 (sweep_vectors): Accumulate size of free vectors.
3270 (Fgarbage_collect): Setup bytes_free.
3271 (Fmemory_free): New function.
3272 (syms_of_alloc): Register it.
3273
22657b40
DA
32742012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3275
3276 Cleanup overlays checking.
3277 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
3278 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
3279 eassert and OVERLAYP.
3280 (sort_overlays): Change to use OVERLAYP.
3281
ddfc8813
RK
32822012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
3283
3284 * editfns.c (Finsert_char): Make it interactive, and make the
3285 second arg optional. Copy interactive spec and docstring from
3286 ucs-insert.
3287
7c26cf3c
PE
32882012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3289
3290 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
3291 Unlike the other wrapped functions, fabs has an unspecified
3292 effect on errno.
3293
5d127af9
JD
32942012-07-16 Jan Djärv <jan.h.d@swipnet.se>
3295
3296 * nsterm.m (keyDown): Interpret flags without left/right bits
3297 as the left key (Bug#11670).
3298
6a0dd1d7
DA
32992012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
3300
3301 Remove empty and useless init functions.
3302 * lisp.h (init_character_once, init_fns, init_image)
3303 (init_filelock, init_sound): Remove prototype.
3304 * character.c (init_character_once): Remove.
3305 * filelock.c (init_filelock): Likewise.
3306 * fns.c (init_fns): Likewise.
3307 * image.c (init_image): Likewise.
3308 * sound.c (init_sound): Likewise.
3309 * emacs.c (main): Adjust accordingly.
3310
7a6136fd
DA
33112012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
3312
3313 * gtkutil.h: Tiny cleanups.
3314 (use_old_gtk_file_dialog): Remove useless declaration.
3315 (xg_uses_old_file_dialog): Add suggested const attribute.
3316
ce811ad9
EZ
33172012-07-15 Eli Zaretskii <eliz@gnu.org>
3318
3319 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
3320 (bidi_paragraph_init): Use it to limit search forward for a strong
3321 directional character in abnormally large paragraphs full of
3322 neutral or weak characters. (Bug#11943)
3323
c9adfeaa
SF
33242012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
3325
3326 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
3327 the toolbar (Bug#9451).
3328 (xg_make_tool_item): Give the widget event box a transparent
3329 background.
3330
fff62aa9
DA
33312012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
3332
3333 Cleanup basic allocation variables and functions.
3334 * alloc.c (ignore_warnings, init_intervals, init_float)
3335 (init_cons, init_symbol, init_marker): Remove.
3336 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
3337 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
3338 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
3339 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
3340 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
3341 (staticidx, init_alloc_once, init_strings, free_ablock):
3342 Remove redundant initialization.
3343 * fns.c (init_weak_hash_tables): Remove.
3344 * lisp.h (init_weak_hash_tables): Remove prototype.
3345
9730daca
DA
33462012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
3347
3348 Use zero_vector where appropriate.
3349 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
3350 accordingly.
3351 * lisp.h (zero_vector): New declaration.
3352 * font.c (null_vector): Remove.
3353 (syms_of_font): Remove initialization and staticpro.
3354 (font_list_entities, font_find_for_lface): Change to use zero_vector.
3355 * keymap.c (Faccessible_keymaps): Likewise.
3356
2e2d2a13
LL
33572012-07-15 Leo Liu <sdl.web@gmail.com>
3358
3359 * fringe.c: Fix typo in comments.
3360
cd276f6e
LL
33612012-07-14 Leo Liu <sdl.web@gmail.com>
3362
3363 * fringe.c: Add a new bitmap exclamation-mark.
3364
5a1131d9
EZ
33652012-07-14 Eli Zaretskii <eliz@gnu.org>
3366
3367 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
3368
3369 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
3370 (HAVE_MENUS): Don't define, defined by editing config.in with
3371 msdos/sed2v2.inp.
3372 (GMALLOC_INHIBIT_VALLOC): Don't define.
3373 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
3374
22e983b7
JB
33752012-07-14 Juanma Barranquero <lekktu@gmail.com>
3376
3377 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
3378
5b3f250f
GM
33792012-07-14 Glenn Morris <rgm@gnu.org>
3380
3381 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
3382 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
3383 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
3384
33d63ff4
GM
33852012-07-13 Glenn Morris <rgm@gnu.org>
3386
5b633342
GM
3387 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
3388
33d63ff4
GM
3389 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
3390 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
3391
b55b9f85
JD
33922012-07-13 Jan Djärv <jan.h.d@swipnet.se>
3393
0dc8cf50
JD
3394 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
3395 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
3396 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
3397 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
3398 where appropriate.
3399 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
3400 as boolean expression.
3401 (x_set_window_size): Remove unused variable toolbar.
3402 (ns_get_color_default, ns_mod_to_lisp): Remove.
3403 (ns_mouse_position): Remove unused variables xchar and ychar.
3404 (ns_compute_glyph_string_overhangs): Remove unused variable face.
3405 (ns_set_vertical_scroll_bar): Remove unused variable count.
3406 (ns_delete_terminal): Remove unused variable i.
3407 (ns_term_init): Remove unused variables r, g and b.
3408 (mouseDown): Remove unused variable window.
3409 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
3410 (initFrameFromEmacs): Remove unused variable vbextra.
3411 (mouseEntered): Remove unused variables p and dpyinfo.
3412 (mouseExited): Remove unused variables p and r.
3413 (ns_define_frame_cursor, ns_clear_frame_area)
3414 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
3415 (menuDown): Assign [sender tag] to variable and cast the variable.
3416
3417 * nsterm.h (menuDown): Add id as type to argument sender.
3418 (ns_display_info_for_name): Add Lisp_Object argument.
3419 (ns_term_init): Add Lisp_Object argument.
3420 (ns_map_event_to_object): Add void argument.
3421 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
3422 prototype with arguments and only declare if __OBJC__.
3423 (nxatoms_of_nsselect): Add void argument.
3424 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
3425 (ns_alloc_autorelease_pool): Add void argument.
3426 (ns_release_autorelease_pool): Add void* argument.
3427 (ns_get_defaults_value): Add const char* argument.
3428
3429 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
3430 (initFromContents): Use SSDATA where appropriate.
3431 (ns_update_menubar): Add braces to ambigous if-else.
3432 (initWithTitle): Put () around assignment in if statement.
3433 (ns_menu_show): Remove unused variables window and keymap.
3434 (update_frame_tool_bar): Remove unused variable selected_p.
3435 (initWithContentRect): Remove unused variable this_cmd_name.
3436
3437 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
3438 appropriate.
3439 (setXBMColor): Remove unused variable len.
3440 (setPixmapData): Put () around assignment in loop statement.
3441
3442 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
3443 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
3444 where appropriate.
3445 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
3446 around assignment in loop statement.
3447 (nsfont_open): Remove unused variable i.
3448 (nsfont_open): Remove unused variable len.
3449 (nsfont_draw): Remove unused variable cs.
3450
3451 * nsfns.m (x_set_icon_name, ns_set_name_internal)
3452 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
3453 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
3454 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
3455 (Fns_font_name, Fns_perform_service)
3456 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
3457 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
3458 (ns_set_name): Remove unused variable view.
3459 (x_set_menu_bar_lines): Remove unused variable olines.
3460 (x_set_tool_bar_lines): Remove unused variable root_window.
3461 (Fns_list_colors): Put () around assignment in while statement.
3462 (Fns_perform_service): Remove unused variable len.
3463 (Fns_display_usable_bounds): Remove unused variable top.
3464 (syms_of_nsfns): Remove unused variable i.
3465
b55b9f85
JD
3466 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
3467 memcpy (Bug#11907).
3468
ed9265fc 34692012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
3470
3471 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
3472 and free it with DestroyExceptionInfo (Bug#11558).
3473
ef099b57
JB
34742012-07-13 Juanma Barranquero <lekktu@gmail.com>
3475
3476 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
3477 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
3478 Set here, not in nt/config.nt.
3479
ea814a5d
EZ
34802012-07-13 Eli Zaretskii <eliz@gnu.org>
3481
3482 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
3483 cursor overflow into the last glyph on display line when the right
3484 fringe is off. (Bug#11832)
3485
1a952767
PE
34862012-07-13 Paul Eggert <eggert@cs.ucla.edu>
3487
3488 * xdisp.c (produce_special_glyphs): Now static.
3489 * dispextern.h (produce_special_glyphs): Remove decl.
3490
983188fd
GM
34912012-07-13 Glenn Morris <rgm@gnu.org>
3492
8d7c7eed 3493 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
3494 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
3495
983188fd
GM
3496 * s/usg5-4-common.h (USG, USG5):
3497 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
3498 * s/sol2-6.h (SOLARIS2):
3499 * s/irix6-5.h (IRIX6_5):
3500 * s/hpux10-20.h (USG, USG5, HPUX):
3501 * s/gnu-linux.h (USG, GNU_LINUX):
3502 * s/freebsd.h (BSD_SYSTEM):
3503 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
3504 * s/cygwin.h (CYGWIN):
3505 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
3506 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
3507
d1e68667 35082012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
3509
3510 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 3511
6de0e799
GM
35122012-07-13 Glenn Morris <rgm@gnu.org>
3513
739ae010
GM
3514 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
3515
dbee5793
GM
3516 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
3517
6de0e799
GM
3518 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
3519 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
3520
b82da769
GM
35212012-07-12 Glenn Morris <rgm@gnu.org>
3522
4fae5a7a 3523 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
3524
3525 * process.c (init_process_emacs): Rename from init_process.
3526 The old name is also the name of a Mach system call.
3527 * lisp.h, emacs.c: Update for this name change.
3528 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
3529 longer needed.
3530
5a979817
EZ
35312012-07-12 Eli Zaretskii <eliz@gnu.org>
3532
3533 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
3534 memmove call that removes glyphs covered by the left truncation
3535 glyph. Improve commentary.
3536 (display_line): Fix display of continuation glyphs on GUI frames
3537 when the right fringe is turned off and variable-size fonts are
3538 used in the window. Move the code that appends a stretch glyph to
3539 produce_special_glyphs, so that it could be used for truncation
3540 and continuation glyphs alike.
3541 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
3542 glyph of a suitably computed width, to align the special glyphs at
3543 the window margin. Code moved from display_line. (Bug#11832)
3544
3e91a053
GM
35452012-07-12 Glenn Morris <rgm@gnu.org>
3546
ba9e4b84
GM
3547 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
3548
3549 * s/gnu-linux.h, s/hpux10-20.h:
3550 Do not unconditionally define HAVE_XRMSETDATABASE.
3551
3e91a053
GM
3552 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
3553
b300b1f4
PE
35542012-07-12 Paul Eggert <eggert@cs.ucla.edu>
3555
3556 Fix typos that broke OS X build.
3557 Reported by Randal L. Schwartz in
3558 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
3559 * nsterm.m (ns_timeout): Add missing local decl.
3560 (ns_get_color): snprintf -> sprintf, to fix typo.
3561
6e777848
GM
35622012-07-12 Glenn Morris <rgm@gnu.org>
3563
3f922c37
GM
3564 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
3565 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
3566 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
3567 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
3568
0ab7b23a
GM
3569 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
3570 Move PTY_OPEN to configure.
3571
6e777848
GM
3572 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3573 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
3574 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
3575
4a7edc24
DA
35762012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
3577
3578 Use empty_unibyte_string where applicable.
3579 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
3580 * lread.c (read1): Likewise.
3581 * xsettings.c (syms_of_xsettings): Likewise.
3582
308aab79
GM
35832012-07-12 Glenn Morris <rgm@gnu.org>
3584
42bd1719
GM
3585 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
3586 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
3587 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
3588 * s/hpux10-20.h (RUN_TIME_REMAP):
3589 * s/bsd-common.h (TABDLY): Move to configure.
3590
3591 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
3592
3593 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
3594
ea0bbd17 3595 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 3596 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
3597
3598 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 3599
308aab79
GM
3600 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
3601 * s/template.h: Move NARROWPROTO to configure.
3602
ee1cf5cf
GM
36032012-07-11 Glenn Morris <rgm@gnu.org>
3604
30fe9bf4
GM
3605 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
3606 unused since 2011-01-17 change to systty.h.
3607
ee1cf5cf
GM
3608 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
3609 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3610 Move HAVE_PTYS and HAVE_SOCKETS to configure.
3611
63e47e07
PE
36122012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3613
3614 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
3615
c43fb4c3
GM
36162012-07-11 Glenn Morris <rgm@gnu.org>
3617
3618 * s/darwin.h, s/gnu-linux.h, s/template.h:
3619 Move INTERRUPT_INPUT to configure.
3620
e8df9267
DA
36212012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3622
3623 Minor adjustments to interning code.
3624 * lisp.h (intern, intern_c_string): Redefine as static inline
3625 wrappers for intern_1 and intern_c_string_1, respectively.
3626 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
3627 * lread.c (intern_1, intern_c_string_1, oblookup):
3628 Simplify Vobarray checking.
e8df9267
DA
3629 * font.c (font_intern_prop): Likewise. Adjust comment.
3630 * w32font.c (intern_font_name): Likewise.
3631
34348bd4
AS
36322012-07-11 Andreas Schwab <schwab@linux-m68k.org>
3633
d96a1e0c
AS
3634 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
3635
34348bd4
AS
3636 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
3637 of Fcar/Fcdr if possible.
3638 * font.c (check_otf_features): Likewise.
3639 * fontset.c (Fnew_fontset): Likewise.
3640 * gnutls.c (Fgnutls_boot): Likewise.
3641 * minibuf.c (read_minibuf): Likewise.
3642 * msdos.c (IT_set_frame_parameters): Likewise.
3643 * xmenu.c (Fx_popup_dialog): Likewise.
3644 * w32menu.c (Fx_popup_dialog): Likewise.
3645
c8add24e
GM
36462012-07-11 Glenn Morris <rgm@gnu.org>
3647
4b575b3c
GM
3648 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
3649 since nothing has defined it on these platforms.
3650
09f4e3b0
GM
3651 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
3652 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
3653
172bedef
GM
3654 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3655 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3656 Move CLASH_DETECTION to configure.
3657
249685df
GM
3658 * s/gnu.h: Remove file, which is now empty.
3659
c8add24e
GM
3660 * s/gnu.h, s/gnu-linux.h:
3661 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
3662
b41253a3
JW
36632012-07-11 John Wiegley <johnw@newartisans.com>
3664
3665 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
3666 function attribute, so we only use it if it exists in the
3667 compiler.
3668
d923b542
DA
36692012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3670
3671 Avoid call to strlen in fast_c_string_match_ignore_case.
3672 * search.c (fast_c_string_match_ignore_case): Change to use
3673 length argument. Adjust users accordingly.
3674 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
3675
5ebbef1d
PE
36762012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3677
bb352260
PE
3678 Assume mkdir, rmdir.
3679 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
3680 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
3681
57054ddd
PE
3682 Assume rename.
3683 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
3684
b747d3f7
PE
3685 Assume perror.
3686 * s/hpux10-20.h (HAVE_PERROR): Remove.
3687 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
3688 Remove dummy definition, as this problem was obsolete long ago.
3689
5ebbef1d
PE
3690 Assume strerror.
3691 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
3692
984e7f30
DA
36932012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3694
3695 Avoid calls to strlen in font processing functions.
3696 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
3697 (font_open_by_name): Change to use length argument.
3698 Adjust users accordingly.
d923b542
DA
3699 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
3700 Adjust prototypes.
3701 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
3702 Change to return ptrdiff_t.
984e7f30
DA
3703 (xfont_list_pattern, xfont_match): Use length returned by
3704 xfont_decode_coding_xlfd.
3705 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
3706
20e94fdd
GM
37072012-07-11 Glenn Morris <rgm@gnu.org>
3708
9d596af3
GM
3709 * s/darwin.h, s/freebsd.h, s/netbsd.h:
3710 Move DONT_REOPEN_PTY to configure.
3711
20e94fdd
GM
3712 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
3713 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
3714
e99a530f
PE
37152012-07-10 Paul Eggert <eggert@cs.ucla.edu>
3716
22ffb973
PE
3717 Remove "#define unix" that is no longer needed (Bug#11905).
3718 * s/aix4-2.h (unix): Remove; no longer needed.
3719
e9a9ae03
PE
3720 EMACS_TIME simplification (Bug#11875).
3721 This replaces macros (which typically do not work in GDB)
3722 with functions, typedefs and enums, making the code easier to debug.
3723 The functional style also makes code easier to read and maintain.
3724 * systime.h: Include <sys/time.h> on all hosts, not just if
3725 WINDOWSNT, since 'struct timeval' is needed in general.
3726 (EMACS_TIME): Now a typedef, not a macro.
3727 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
3728 not macros.
3729 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
3730 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
3731 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
3732 (EMACS_TIME_LE): Now functions, not macros.
3733 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
3734 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
3735 which are not functions. All uses rewritten to use:
3736 (make_emacs_time): New function.
3737 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
3738 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
3739 not functions. All uses rewritten to use the following, respectively:
3740 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
3741 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 3742 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
3743 * fileio.c (Fcopy_file):
3744 * xterm.c (XTflash): Get the current time closer to when it's used.
3745 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
3746
ffacb126
PE
3747 * bytecode.c (targets): Suppress -Woverride-init warnings.
3748
e99a530f
PE
3749 Simplify by avoiding confusing use of strncpy etc.
3750 * doc.c (Fsnarf_documentation):
3751 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
3752 * frame.c (Fmake_terminal_frame):
3753 * gtkutil.c (get_utf8_string):
3754 * lread.c (openp):
3755 * nsmenu.m (ns_update_menubar):
3756 * regex.c (regerror):
3757 Prefer memcpy to strncpy and strncat when either will do.
3758 * fileio.c (Fsubstitute_in_file_name):
3759 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
3760 (menu_separator_name_p):
3761 * nsmenu.m (ns_update_menubar):
3762 Prefer memcmp to strncmp when either will do.
3763 * nsterm.m: Include <ftoastr.h>.
3764 (ns_get_color):
3765 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
3766 Prefer snprintf to strncpy.
3767 * nsterm.m (ns_term_init):
3768 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
3769 * nsterm.m (ns_term_init):
3770 Avoid the need for strncpy, by using build_string or
3771 make_unibyte_string directly. Use dtoastr, not snprintf.
3772 * process.c (Fmake_network_process): Diagnose service names that
3773 are too long, rather than silently truncating them or creating
3774 non-null-terminated names.
3775 (Fnetwork_interface_info): Likewise, for interface names.
3776 * sysdep.c (system_process_attributes) [GNU_LINUX]:
3777 Prefer sprintf to strncat.
3778 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
3779 Prefer vsnprintf to vsprintf + strncpy.
3780
c59592b3
GM
37812012-07-10 Glenn Morris <rgm@gnu.org>
3782
3783 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
3784 Clarify fallback case.
3785
7d7bbefd
DA
37862012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3787
3788 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
3789 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
3790 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 3791 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
3792 where argument type is known to be a Lisp_Cons.
3793
3a4c8000
TT
37942012-07-10 Tom Tromey <tromey@redhat.com>
3795
3796 * bytecode.c (BYTE_CODE_THREADED): New macro.
3797 (BYTE_CODES): New macro. Replaces all old byte-code defines.
3798 (enum byte_code_op): New type.
3799 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
3800 (exec_byte_code): Use them. Use token threading when applicable.
3801
2a0213a6
DA
38022012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3803
3804 Optimize pure C strings initialization.
3805 * lisp.h (make_pure_string): Fix prototype.
3806 (build_pure_c_string): New function, defined as static inline. This
3807 provides a better opportunity to optimize away calls to strlen when
3808 the function is called with compile-time constant argument.
3809 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
3810 argument, adjust users accordingly. Use build_pure_c_string where
3811 appropriate.
3812 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
3813 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
3814 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
3815
cb1caeaf
DA
38162012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3817
3818 Avoid calls to strlen in miscellaneous functions.
3819 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
3820 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
3821 * lread.c (openp): Likewise.
3822
c293e30c
DA
38232012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3824
3825 Avoid calls to strlen in path processing functions.
3826 * fileio.c (file_name_as_directory): Add comment. Change to add
3827 srclen argument and return the length of result. Adjust users
3828 accordingly.
3829 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
3830 swap 1st and 2nd arguments to obey the common convention.
3831 Adjust users accordingly.
c293e30c
DA
3832 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
3833
9e059e3f
GM
38342012-07-10 Glenn Morris <rgm@gnu.org>
3835
d02eb359
GM
3836 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
3837 Move PENDING_OUTPUT_COUNT definition to configure.
3838
882cf227
GM
3839 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
3840 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
3841 * s/gnu.h (DATA_START): Move definitions to configure.
3842
af6e839f
GM
3843 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
3844 We include usg5-4-common.h, which defines them both.
3845
40289a12
GM
3846 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
3847 O_RDONLY already includes it).
3848
9e059e3f
GM
3849 Stop ns builds setting the EMACSLOADPATH environment variable.
3850 * nsterm.m (ns_load_path): Rename from ns_init_paths.
3851 Now it does not set EMACSLOADPATH, just returns the load-path string.
3852 * nsterm.h: Update accordingly.
3853 * lread.c [HAVE_NS]: Include nsterm.h.
3854 (init_lread) [HAVE_NS]: Use ns_load_path.
3855 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
3856
7c4e8ec0
GM
38572012-07-09 Glenn Morris <rgm@gnu.org>
3858
d4f600ff
GM
3859 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
3860 since the included bsd-common.h does so.
3861
cbb31951
GM
3862 Stop ns builds setting the EMACSPATH environment variable.
3863 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
3864 (ns_init_paths): Do not set EMACSPATH.
3865 * nsterm.h (ns_exec_path): Add it.
3866 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
3867 Use ns_exec_path.
3868
7c4e8ec0
GM
3869 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
3870
26bccfae
PE
38712012-07-09 Paul Eggert <eggert@cs.ucla.edu>
3872
a0bee46f
PE
3873 * process.c (wait_reading_process_output): 'waitchannels' was unset
3874 when read_kbd || !NILP (wait_for_cell); fix this.
3875
5994c183
PE
3876 Add GCC-style 'const' attribute to functions that can use it.
3877 * character.h (char_resolve_modifier_mask):
3878 * keyboard.h (make_ctrl_char):
3879 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
3880 (init_character_once, next_almost_prime, init_fns, init_image)
3881 (flush_pending_output, init_sound):
3882 * mem-limits.h (start_of_data):
3883 * menu.h (finish_menu_items):
3884 Add ATTRIBUTE_CONST.
3885 * emacs.c (DEFINE_DUMMY_FUNCTION):
3886 Declare the dummy function with ATTRIBUTE_CONST.
3887 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
3888 Add decls with ATTRIBUTE_CONST.
3889
26bccfae
PE
3890 Minor improvements to make_formatted_string.
3891 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
3892 where int is good enough, as vsprintf returns an int.
3893 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
3894
a8290ec3
DA
38952012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3896
3897 Use make_formatted_string to avoid double length calculation.
3898 * lisp.h (make_formatted_string): New prototype.
3899 * alloc.c (make_formatted_string): New function.
3900 * buffer.c (Fgenerate_new_buffer_name): Use it.
3901 * dbus.c (syms_of_dbusbind): Likewise.
3902 * editfns.c (Fcurrent_time_zone): Likewise.
3903 * filelock.c (get_boot_time): Likewise.
3904 * frame.c (make_terminal_frame, set_term_frame_name)
3905 (x_report_frame_params): Likewise.
3906 * image.c (gs_load): Likewise.
3907 * minibuf.c (get_minibuffer): Likewise.
3908 * msdos.c (dos_set_window_size): Likewise.
3909 * process.c (make_process): Likewise.
3910 * xdisp.c (ensure_echo_area_buffers): Likewise.
3911 * xsettings.c (apply_xft_settings): Likewise.
3912
d01ba2f1
GM
39132012-07-09 Glenn Morris <rgm@gnu.org>
3914
3915 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
3916 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
3917 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
3918 * nsterm.h (ns_etc_directory): Add it.
3919 * callproc.c [HAVE_NS]: Include nsterm.h.
3920 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
3921
f1f924b6
DA
39222012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3923
3924 Move marker debugging code under MARKER_DEBUG.
3925 * marker.c (MARKER_DEBUG): Move marker debugging code under
3926 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
3927 for bootstrap with --enable-checking (~3x slowdown reported
3928 by Juanma Barranquero <lekktu@gmail.com>).
3929 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
3930
ab531b66
PE
39312012-07-08 Paul Eggert <eggert@cs.ucla.edu>
3932
3933 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
3934 See <http://bugs.gnu.org/11825#29>.
3935
c4b3bc8a
EZ
39362012-07-08 Eli Zaretskii <eliz@gnu.org>
3937
3938 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
3939 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
3940 (display_line): Add commentary about displaying truncation glyphs
3941 on GUI frames.
3942 (produce_special_glyphs): Move here from term.c.
3943
3944 * term.c (produce_special_glyphs): Move to xdisp.c.
3945
3946 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
3947 section.
c4b3bc8a 3948
b676b881
AS
39492012-07-07 Andreas Schwab <schwab@linux-m68k.org>
3950
f17c5273
AS
3951 * xdisp.c (display_line): Avoid warning about implicit declaration
3952 of FRAME_FONT.
3953
298819b9
AS
3954 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
3955
b676b881
AS
3956 * lisp.h: Remove empty conditional.
3957
6045c4fd
PE
39582012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3959
b3350bf9
PE
3960 * lread.c (load_path_check): Now static.
3961
6045c4fd
PE
3962 Fix some minor --with-ns problems found by static checking.
3963 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
3964 (x_set_font) [!HAVE_X_WINDOWS]:
3965 * image.c (xpm_load_image) [HAVE_NS]:
3966 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
3967 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
3968 Remove unused local.
3969 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
3970 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
3971 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
3972 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
3973 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
3974 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
3975 Fix pointer signedness problem.
3976 * xfaces.c (FRAME_X_FONT_TABLE):
3977 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
3978
929e7845
GM
39792012-07-07 Glenn Morris <rgm@gnu.org>
3980
3981 * lread.c (load_path_check): New function, split from init_lread.
3982 (init_lread): Reorganize. Motivation:
3983 If EMACSLOADPATH is set, check/warn about that rather than the
3984 defaults, which we are not going to use. Hence we can remove
3985 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
3986 Don't warn if site-lisp directories are missing.
3987 If not installed, start from a blank load-path, since
3988 PATH_LOADSEARCH refers to the eventual installation directories.
3989
58dd0aa4
EZ
39902012-07-07 Eli Zaretskii <eliz@gnu.org>
3991
3992 Support truncation and continuation glyphs on GUI frames, when
3993 fringes are disabled. (Bug#11832)
3994 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
3995 continuation glyphs even if on GUI frames.
3996 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
3997 or both, are absent.
3998 (start_display, move_it_in_display_line_to): Handle the case of a
3999 GUI frame without a fringe to display continuation or truncation
4000 glyphs.
4001 (insert_left_trunc_glyphs): Support GUI frames: make sure
4002 truncation glyphs overwrite enough glyphs from the current line to
4003 have sufficient space in pixels.
4004 (display_line): Support truncation and continuation glyphs on GUI
4005 frames. If some spare pixels are left on the line after inserting
4006 the truncation glyphs, fill that space with a stretch glyph of a
4007 suitably computed width.
4008
4009 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
4010 produce_glyphs, to support GUI sessions.
4011
31571fd7
PE
40122012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4013
5a16b9bc
PE
4014 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
4015
f3047c75
PE
4016 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
4017
31571fd7
PE
4018 Do not require float-time's arg to fit in time_t (Bug#11825).
4019 This works better on hosts where time_t is unsigned, and where
4020 float-time is applied to the (negative) difference between two times.
4021 * editfns.c (decode_time_components): Last arg is now double *,
4022 not int *, and means to store all the result as a double, without
4023 worrying about whether the seconds part fits in time_t.
4024 All callers changed.
4025 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
4026 All callers changed.
4027 (Ffloat_time): Do not fail merely because the specified time falls
4028 outside of time_t range.
4029
4516fbef
GM
40302012-07-07 Glenn Morris <rgm@gnu.org>
4031
4032 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
4033 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
4034 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
4035
07adc2c6
JB
40362012-07-07 Juanma Barranquero <lekktu@gmail.com>
4037
4038 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
4039 Update dependencies.
4040
4041 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
4042
fd573f31
PE
40432012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4044
fee5959d
PE
4045 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
4046 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
4047 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
4048 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
4049 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
4050 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
4051
fd573f31
PE
4052 * xfont.c (compare_font_names): Redo to omit the need for casts.
4053
ddadbc0e
AS
40542012-07-06 Andreas Schwab <schwab@linux-m68k.org>
4055
fca8d6b6
AS
4056 * xfns.c (Fx_change_window_property): Doc fix.
4057 * w32fns.c (Fx_change_window_property): Doc fix.
4058
ddadbc0e
AS
4059 * w32fns.c (Fx_window_property): Accept the same arguments as the
4060 X Windows version. Doc fix.
4061 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
4062
ed9265fc 40632012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
4064 Eli Zaretskii <eliz@gnu.org>
4065
4066 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
4067 Windows-specific code from nt/config.nt moved here.
4068 Obsolete settings removed.
4069
216ee680
PE
40702012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4071
4072 * process.c: Avoid unnecessary calls to gettime.
4073 (wait_reading_process_output): Don't get the time of day
4074 when gobbling data immediately and not waiting, as there's no need
4075 for it in that case. This removes a FIXME.
4076
bdd091e4
JD
40772012-07-06 Jan Djärv <jan.h.d@swipnet.se>
4078
4079 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
4080 is defined (Bug#11768).
4081
9d44f8ce
DA
40822012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4083
4084 Fix marker debugging code.
4085 * marker.c (byte_char_debug_check): Do not perform the check
4086 if buffer is not multibyte.
090bd7cb
JB
4087 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4088 Call byte_char_debug_check with correct arguments.
9d44f8ce 4089
90fc4786
DA
40902012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4091
4092 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
4093 * marker.c (byte_char_debug_check, count_markers):
4094 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
4095 (byte_debug_flag): Remove.
4096 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4097 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
4098
7b7ae965
DA
40992012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4100
4e57b342
DA
4101 Avoid code repetition in marker-related functions.
4102 * marker.c (attach_marker): New function.
4103 (Fset_marker, set_marker_restricted, set_marker_both)
4104 (set_marker_restricted_both): Use it.
4105 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
4106 Consistently rename charno to charpos.
4107 (marker_position): Add eassert.
4108 (marker_byte_position): Convert to eassert.
4109
41102012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4111
4112 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 4113 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 4114 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 4115
657924ff
DA
41162012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4117
4118 Introduce fast path for the widely used marker operation.
4119 * alloc.c (build_marker): New function.
4120 * lisp.h (build_marker): New prototype.
4121 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
4122 * composite.c (autocmp_chars): Likewise.
4123 * editfns.c (buildmark): Remove.
4124 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
4125 (save_restriction_save): Use build_marker.
4126 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
4127 * window.c (save_window_save): Likewise.
4128
041a49a6
DA
41292012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4130
4131 Do not use Fdelete_overlay in delete_all_overlays
4132 to avoid redundant calls to unchain_overlay.
4133 * buffer.c (drop_overlay): New function.
4134 (delete_all_overlays, Fdelete_overlay): Use it.
4135 * minibuf.c (get_minibuffer): Fix comment.
4136
7dca65a4
PE
41372012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4138
4139 Port to OpenBSD 5.1 amd64.
4140 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
4141 This is needed for OpenBSD, and should be harmless on all BSD systems.
4142 Also, include <sys/sysctl.h>, as it should be available on all
4143 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
4144 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
4145 use p_pid member, not kp_proc.pid.
4146
8eb876e2
GM
41472012-07-06 Glenn Morris <rgm@gnu.org>
4148
4149 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
4150
38182d90
PE
41512012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4152
4153 More xmalloc and related cleanup.
4154 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
4155 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
4156 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
4157 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
4158 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
4159 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
4160 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
4161 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
4162 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
4163 * xterm.c:
4164 Omit needless casts involving void * pointers and allocation.
4165 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
4166 as the former is more robust if P's type is changed.
4167 Prefer xzalloc to xmalloc + memset 0.
4168 Simplify malloc-or-realloc to realloc.
4169 Don't worry about xmalloc returning a null pointer.
4170 Prefer xstrdup to xmalloc + strcpy.
4171 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
4172 growing it.
4173 * keyboard.c (apply_modifiers_uncached): Prefer local array to
4174 alloca of a constant.
4175
6dd5a677
EZ
41762012-07-05 Eli Zaretskii <eliz@gnu.org>
4177
4178 * xdisp.c (display_line): Fix horizontal pixel coordinates when
4179 hscroll is larger than the line width. Fixes long and futile
4180 looping inside extend_face_to_end_of_line (on a TTY) producing
4181 glyphs that are not needed and thrown away.
4182
6b312f0f
DA
41832012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
4184
4185 * marker.c (set_marker_restricted_both): Simplify by using
4186 clip_to_bounds.
4187
f520ef9b
PE
41882012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4189
4190 * editfns.c (region_limit): Simplify by using clip_to_bounds.
4191
383b7c95
JD
41922012-07-05 Jan Djärv <jan.h.d@swipnet.se>
4193
4194 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
4195 not defined (Bug#11768).
4196 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
4197 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
4198 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
4199 followed by gtk_box_set_homogeneous (Bug#11768).
4200 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
4201 (update_theme_scrollbar_width, xg_create_scroll_bar):
4202 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
4203 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
4204 (is_box_type): New function (Bug#11768).
4205 (xg_tool_item_stale_p): Call is_box_type.
5293d758 4206 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
4207 with default display (Bug#11768).
4208
d6e7bf45
EZ
42092012-07-05 Eli Zaretskii <eliz@gnu.org>
4210
4211 * xdisp.c (window_hscroll_limited): New function.
4212 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
4213 coordinates when window's hscroll is set to insanely large
4214 values. (Bug#11857)
4215
431391ec
JB
42162012-07-05 Juanma Barranquero <lekktu@gmail.com>
4217
4218 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
4219 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
4220
23f86fce
DA
42212012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
4222
4223 Cleanup xmalloc.
4224 * lisp.h (xzalloc): New prototype. Omit needless casts.
4225 * alloc.c (xzalloc): New function. Omit needless casts.
4226 * charset.c: Omit needless casts. Convert all calls to
4227 xmalloc with following memset to xzalloc.
4228 * dispnew.c: Likewise.
4229 * fringe.c: Likewise.
4230 * image.c: Likewise.
4231 * sound.c: Likewise.
4232 * term.c: Likewise.
4233 * w32fns.c: Likewise.
4234 * w32font.c: Likewise.
4235 * w32term.c: Likewise.
4236 * xfaces.c: Likewise.
4237 * xfns.c: Likewise.
4238 * xterm.c: Likewise.
4239 * atimer.c: Omit needless casts.
4240 * buffer.c: Likewise.
4241 * callproc.c: Likewise.
4242 * ccl.c: Likewise.
4243 * coding.c: Likewise.
4244 * composite.c: Likewise.
4245 * doc.c: Likewise.
4246 * doprnt.c: Likewise.
4247 * editfns.c: Likewise.
4248 * emacs.c: Likewise.
4249 * eval.c: Likewise.
4250 * filelock.c: Likewise.
4251 * fns.c: Likewise.
4252 * gtkutil.c: Likewise.
4253 * keyboard.c: Likewise.
4254 * lisp.h: Likewise.
4255 * lread.c: Likewise.
4256 * minibuf.c: Likewise.
4257 * msdos.c: Likewise.
4258 * print.c: Likewise.
4259 * process.c: Likewise.
4260 * region-cache.c: Likewise.
4261 * search.c: Likewise.
4262 * sysdep.c: Likewise.
4263 * termcap.c: Likewise.
4264 * terminal.c: Likewise.
4265 * tparam.c: Likewise.
4266 * w16select.c: Likewise.
4267 * w32.c: Likewise.
4268 * w32reg.c: Likewise.
4269 * w32select.c: Likewise.
4270 * w32uniscribe.c: Likewise.
4271 * widget.c: Likewise.
4272 * xdisp.c: Likewise.
4273 * xmenu.c: Likewise.
4274 * xrdb.c: Likewise.
4275 * xselect.c: Likewise.
4276
0497dc44
PE
42772012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4278
4279 * fileio.c (time_error_value): Check the right error number.
4280 Problem reported by Troels Nielsen in
4281 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
4282
356e7178
PE
42832012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4284
4e71fd89
PE
4285 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
4286 This should be fixed in a better way; see Eli Zaretskii in
4287 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
4288 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
4289
f0941253
PE
4290 * fileio.c (time_error_value): Rename from special_mtime.
4291 The old name's problems were noted by Eli Zaretskii in
4292 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
4293
065c9eb4
PE
4294 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
4295 This variable's comment says Emacs needs at least one GDB-visible
4296 symbol of type enum pvec_type, to work around GDB problems.
4297 The symbol's value doesn't matter.
4298
356e7178
PE
4299 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
4300 that causes compilation to fail on pre-C99 compilers.
4301
ed9265fc 43022012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
4303
4304 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
4305 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
4306
3884d954
DA
43072012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4308
d209e2fb 4309 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
4310 headers for buffer_defaults and buffer_local_symbols.
4311 Reported by Juanma Barranquero <lekktu@gmail.com>.
4312
ee28be33
SM
43132012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4314
4315 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
4316 * lisp.h (enum pvec_type): Use fewer bits.
4317 (PSEUDOVECTOR_SIZE_BITS): New constant.
4318 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
4319 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
4320 change in pvec_type.
4321 (PSEUDOVECTOR_TYPEP): New macro.
4322 (TYPED_PSEUDOVECTORP): Use it.
4323 * fns.c (internal_equal): Adapt code to extract pvectype.
4324 * emacs.c (gdb_pvec_type): Update type.
4325 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
4326 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
4327 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
4328 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
4329 (sweep_vectors): Use it. Use local var `total_bytes' instead of
4330 abusing vector->header.next.nbytes.
4331 (live_vector_p): Use PVEC_TYPE.
4332 (mark_object): Adapt code to extract pvectype. Use switch.
4333
c7f2cd7f
PE
43342012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4335
4336 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
4337 Tighten new eassert a bit.
4338
8ce70ed2
DA
43392012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4340
4341 Fix compilation with --enable-gcc-warnings and -O1
4342 optimization level.
4343 * doprnt.c (doprnt): Change type of tem to int, initialize
4344 to avoid compiler warning. Add eassert.
4345 * search.c (simple_search): Initialize match_byte to avoid
4346 compiler warning. Add eassert.
4347
dea7f1e5
PE
43482012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4349
24a212eb
PE
4350 Avoid weird behavior with large horizontal scrolls.
4351 Without this change, for example, large hscroll values would
4352 mess up Emacs's display on Fedora 15 x86, presumably due to
4353 overflows in int calculations in the display code.
4354 Also, if buffers had long lines, Emacs would freeze.
4355 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
4356 (set_window_hscroll): New function, containing the old guts of
4357 Fset_window_hscroll. Return the clipped value.
4358 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
4359 This avoids the need to check against PTRDIFF_MAX.
4360
dea7f1e5
PE
4361 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
4362
76046526
DA
43632012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4364
4365 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
4366
39adff0d
PE
43672012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4368
63807d47
PE
4369 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
4370 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
4371 since GCC 4.4.6 issues a bogus warning for them.
4372
39adff0d
PE
4373 Fix bugs in file timestamp newness comparisons.
4374 * fileio.c (Ffile_newer_than_file_p):
4375 * lread.c (Fload): Use full timestamp resolution of files,
4376 not just the 1-second resolution, so that files that are only
4377 slightly newer still count as newer.
4378 * fileio.c (Ffile_newer_than_file_p): Don't assume file
4379 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
4380
dbeed9a6
PE
43812012-07-03 Paul Eggert <eggert@cs.ucla.edu>
4382
4383 * fileio.c: Improve handling of file time marker. (Bug#11852)
4384 (special_mtime): New function.
4385 (Finsert_file_contents, Fverify_visited_file_modtime):
4386 Use it to set special mtime values consistently.
4387
636334d6
AS
43882012-07-03 Andreas Schwab <schwab@linux-m68k.org>
4389
4390 * fileio.c (Finsert_file_contents): Properly handle st_mtime
4391 marker for non-existing file. (Bug#11852)
4392
e2017fe2
GM
43932012-07-03 Glenn Morris <rgm@gnu.org>
4394
4395 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
4396 and did not make it into globals.h).
4397
404dbd37
TT
43982012-07-03 Tom Tromey <tromey@redhat.com>
4399
4400 * window.c (Fset_window_margins, Fset_window_fringes)
4401 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
4402 * textprop.c (Fprevious_property_change): No longer static.
4403 * syntax.c (Fsyntax_table_p): No longer static.
4404 * process.c (Fget_process, Fprocess_datagram_address): No longer
4405 static.
4406 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
4407 * keyboard.c (Fcommand_execute): No longer static.
4408 Remove EXFUN.
4409 * insdel.c (Fcombine_after_change_execute): No longer static.
4410 * image.c (Finit_image_library): No longer static.
4411 * fileio.c (Fmake_symbolic_link): No longer static.
4412 * eval.c (Ffetch_bytecode): No longer static.
4413 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
4414 * doc.c (Fdocumentation_property, Fsnarf_documentation):
4415 No longer static.
404dbd37
TT
4416 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
4417 static.
4418 * dired.c (Ffile_attributes): No longer static.
4419 * composite.c (Fcomposition_get_gstring): No longer static.
4420 * callproc.c (Fgetenv_internal): No longer static.
4421
4422 * ccl.h: Remove EXFUNs.
4423 * buffer.h: Remove EXFUNs.
4424 * dispextern.h: Remove EXFUNs.
4425 * intervals.h: Remove EXFUNs.
4426 * fontset.h: Remove EXFUN.
4427 * font.h: Remove EXFUNs.
4428 * dosfns.c (system_process_attributes): Remove EXFUN.
4429 * keymap.h: Remove EXFUNs.
4430 * lisp.h: Remove EXFUNs.
4431 * w32term.h: Remove EXFUNs.
4432 * window.h: Remove EXFUNs.
4433 * xsettings.h: Remove EXFUN.
4434 * xterm.h: Remove EXFUN.
4435
8e4fd1e1
GM
44362012-07-03 Glenn Morris <rgm@gnu.org>
4437
4438 * lisp.h (Frandom): Make it visible to C.
4439 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
4440 buffer for invisible buffers. (Bug#1229)
4441
ca95b3eb
DA
44422012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4443
4444 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
4445 values which aren't power of 2.
14ae4239
BT
4446 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
4447 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
4448 accordingly.
4449
7555c33f
SM
44502012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
4451
4452 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
4453
4454 * alloc.c (mark_object): Revert part of last patch to use `switch'.
4455
d12e8f5a
DA
44562012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4457
4458 * alloc.c (allocate_vector_block): Remove redundant
4459 calls to mallopt if DOUG_LEA_MALLOC is defined.
4460 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
4461 avoid calls to mallopt if zero_vector is returned.
4462
296094c3
DA
44632012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4464
4465 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
4466 is enabled, avoid dereferencing NULL current_sblock if
4467 running undumped.
4468
36429c89
DA
44692012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4470
4471 Cleanup basic buffer management.
4472 * buffer.h (struct buffer): Change layout to use generic vector
4473 marking code. Fix some comments. Change type of 'clip_changed'
4474 to bitfield. Remove unused #ifndef old.
4475 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
4476 (GET_OVERLAYS_AT): Fix indentation.
4477 (for_each_per_buffer_object_at): New macro.
4478 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
4479 (Fbuffer_local_variables): Use it.
4480 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
4481 * alloc.c (allocate_buffer): Adjust to match new layout of
4482 struct buffer. Fix comment.
4483 (mark_overlay): New function.
4484 (mark_buffer): Use it. Use mark_vectorlike to mark normal
4485 Lisp area of struct buffer.
4486 (mark_object): Use it. Adjust marking of misc objects
4487 and related comments.
4488
3b3e4cac
PE
44892012-07-02 Paul Eggert <eggert@cs.ucla.edu>
4490
4491 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
4492 wrapper that is not needed because the wrapped code is a no-op (zero
4493 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
4494 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
4495
cf5c0175
DA
44962012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
4497
4498 * alloc.c (mark_buffer): Simplify. Remove prototype.
4499 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 4500 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
4501 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
4502 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 4503
ca26824c
GM
45042012-06-30 Glenn Morris <rgm@gnu.org>
4505
2e4c5312
GM
4506 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
4507
ca26824c
GM
4508 * epaths.in (PATH_SITELOADSEARCH): New.
4509 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
4510 This is rather than relying on --enable-locallisppath elements
4511 having "site-lisp" in their names. (Bug#10208#25, 11658)
4512
0d23c240
EZ
45132012-06-30 Eli Zaretskii <eliz@gnu.org>
4514
c9240d7a
EZ
4515 * w32proc.c (sys_select): Accept and ignore one more argument.
4516
4517 * w32.c (emacs_gnutls_pull): Call select with one more argument.
4518
0d23c240 4519 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 4520 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
4521
4522 * sysdep.c: Don't include dos.h and dosfns.h.
4523
4524 * process.c (sys_select):
4525 * msdos.c (sys_select): Accept one more argument and ignore it.
4526
4527 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
4528 adapt data types and code to that.
4529
4530 * dosfns.c:
4531 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
4532 which clashes with the gnulib function of the same name.
4533
af5a5a98
AS
45342012-06-30 Andreas Schwab <schwab@linux-m68k.org>
4535
c5e4379c
AS
4536 * font.c (font_style_to_value, font_style_symbolic)
4537 (font_prop_validate_style): Add type checks for values in
4538 font_style_table.
4539
af5a5a98
AS
4540 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
4541 argument.
4542 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
4543 uses.
4544
8d38f461
EZ
45452012-06-29 Eli Zaretskii <eliz@gnu.org>
4546
2e5a6631
EZ
4547 * xdisp.c (try_window_id): Undo last change.
4548
8d38f461
EZ
4549 * w32.c (getwd): Adjust commentary about startup_dir.
4550 (init_environment): Always call sys_access, even in non-MSVC
4551 builds. Don't chdir to the directory of the Emacs executable.
4552 This undoes code from 1997 which was justified by the need to
4553 "avoid conflicts when removing and renaming directories". But its
4554 downside was that every relative file name was being interpreted
4555 relative to the directory of the Emacs executable, which can never
4556 be TRT. In particular, it broke sys_access when called with
4557 relative file names.
4558 (sys_access): Map GetLastError to errno.
4559
2af3565e
DA
45602012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4561
4562 * window.h (struct window): Change type of 'fringes_outside_margins'
4563 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 4564 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
4565 Adjust comment.
4566 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
4567 to ptrdiff_t.
4568
c8d3a25c 45692012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 4570
c8d3a25c
GM
4571 * gnutls.c (emacs_gnutls_handshake):
4572 Add QUIT to make the loop interruptible.
57570cd3 4573
c8d3a25c 45742012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 4575
c8d3a25c
GM
4576 * charset.c (init_charset): Make lack of etc/charsets fatal.
4577
3e984ee8
DA
45782012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4579
4580 * editfns.c (region_limit): Fix type mismatch.
4581
ef884f23
DA
45822012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4583
4584 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
4585 undefined. Convert from xassert to eassert.
4586 * nsmenu.m: Convert from xassert to eassert.
4587 * nsterm.m: Likewise.
4588
7d7e0027
SM
45892012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
4590
4591 * editfns.c (region_limit): Clip to narrowing (bug#11770).
4592
aa754e6a
PE
45932012-06-28 Paul Eggert <eggert@cs.ucla.edu>
4594
4595 Avoid integer overflow on scroll-left and scroll-right.
4596 * window.c (HSCROLL_MAX): New macro.
4597 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
4598 overflow when requested scroll falls outside ptrdiff_t range.
4599
80b00b08
DA
46002012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4601
4602 * window.h (struct window): Change type of 'hscroll',
4603 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
4604 'last_modified' and 'last_overlay_modified' to EMACS_INT.
4605 Adjust users accordingly.
4606 * xdisp.c (try_cursor_movement): Replace type check with eassert.
4607 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
4608 from EMACS_INT to ptrdiff_t.
4609 (make_window): Omit redundant initialization.
4610
62b2bcf6
JB
46112012-06-28 Juanma Barranquero <lekktu@gmail.com>
4612
4613 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
4614
45942c7d
DA
46152012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4616
4617 * window.h (struct window): Change type of 'use_time' and
4618 'sequence_number' from Lisp_Object to int.
4619 * frame.c (make_frame): Adjust users accordingly.
4620 * print.c (print_object): Likewise.
4621 * window.c (select_window, Fwindow_use_time, make_parent_window)
4622 (make_window): Likewise.
4623
e509cfa6
DA
46242012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4625
4626 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
4627 enabled with --enable-checking=[all,glyphs] configure option.
4628 Fix GLYPH_DEBUG usage assuming that it may be undefined,
4629 adjust comments accordingly.
4630 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
4631 undefined, adjust comments accordingly.
4632 * image.c: Likewise.
4633 * scroll.c: Likewise.
4634 * w32fns.c: Likewise.
4635 * w32term.c: Likewise.
4636 * xdisp.c: Likewise.
4637 * xfaces.c: Likewise.
4638 * xfns.c: Likewise.
4639 * xterm.c: Likewise.
4640
a54e2c05
DA
46412012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4642
4643 Generalize run-time debugging checks.
4644 * dispextern.h (XASSERTS): Remove.
4645 * fontset.c (xassert): Remove.
4646 Convert from xassert to eassert.
4647 * alloc.c: Convert from xassert to eassert.
4648 * bidi.c: Likewise.
4649 * dispnew.c: Likewise.
4650 * fns.c: Likewise.
4651 * fringe.c: Likewise.
4652 * ftfont.c: Likewise.
4653 * gtkutil.c: Likewise.
4654 * image.c: Likewise.
4655 * keyboard.c: Likewise.
4656 * menu.c: Likewise.
4657 * process.c: Likewise.
4658 * scroll.c: Likewise.
4659 * sound.c: Likewise.
4660 * term.c: Likewise.
4661 * w32console.c: Likewise.
4662 * w32fns.c: Likewise.
4663 * w32term.c: Likewise.
4664 * window.c: Likewise.
4665 * xdisp.c: Likewise.
4666 * xfaces.c: Likewise.
4667 * xfns.c: Likewise.
4668 * xselect.c: Likewise.
4669 * xterm.c: Likewise.
4670
1ec4b7b2
SM
46712012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
4672
4673 * fns.c (maybe_resize_hash_table): Output message when growing the
4674 purify-hashtable.
4675
2014308a
DA
46762012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4677
4678 * alloc.c (allocate_string_data): Remove dead code.
4679 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
4680 avoid GCC warning about unused macro.
4681
246155eb
DA
46822012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4683
4684 * alloc.c (allocate_string): Omit intervals initialization.
4685 * alloc.c (make_uninit_multibyte_string): Initialize intervals
4686 as in make_pure_string and make_pure_c_string.
4687
43184b7b
DA
46882012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4689
d209e2fb 4690 * alloc.c (allocate_string): Fix last change.
43184b7b 4691
3fe6dd74
DA
46922012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4693
d209e2fb 4694 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
4695 to memset, add explicit initialization where appropriate.
4696
1ba6038a
GM
46972012-06-27 Glenn Morris <rgm@gnu.org>
4698
4699 * lisp.mk (lisp): Remove paths.elc.
4700
c89926a5
CY
47012012-06-27 Chong Yidong <cyd@gnu.org>
4702
4703 * doc.c (Fsubstitute_command_keys): Fix punctuation.
4704
ed6b3510
JW
47052012-06-26 John Wiegley <johnw@newartisans.com>
4706
1ec4b7b2 4707 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
4708 on Mac OS X Lion: __mod_init_func and __mod_term_func.
4709
ed6b3510
JW
4710 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
4711 when building with Clang.
4712
8edd4a2b
SM
47132012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
4714
4715 * eval.c (Fapply): Allow calling it with a single argument.
4716
f6f62d1b
EZ
47172012-06-26 Eli Zaretskii <eliz@gnu.org>
4718
4719 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
4720 _stricmp and _strnicmp.
4721 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
4722
62efea5e
DA
47232012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4724
4725 * alloc.c (allocate_window): Zero out non-Lisp part of newly
4726 allocated window.
4727 (allocate_process): Likewise for new process.
8edd4a2b 4728 (allocate_terminal): Change to use offsetof.
62efea5e
DA
4729 (allocate_frame): Likewise.
4730 * frame.c (make_frame): Omit redundant initialization.
4731 * window.c (make_parent_window): Use memset.
4732 (make_window): Omit redundant initialization.
4733 * process.c (make_process): Omit redundant initialization.
4734 * terminal.c (create_terminal): Likewise.
4735
42997f4d
DA
47362012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4737
4738 * term.c (delete_tty): Remove redundant call to memset.
4739
1130ecfc
DA
47402012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4741
4742 * alloc.c: Remove build_string.
4743 * lisp.h: Define build_string as static inline. This provides
4744 a better opportunity to optimize away calls to strlen when the
4745 function is called with compile-time constant argument.
4746 * image.c (imagemagick_error): Convert to build_string.
4747 * w32proc.c (sys_spawnve): Likewise.
4748 * xterm.c (x_term_init): Likewise.
4749
cf38a720
PE
47502012-06-26 Paul Eggert <eggert@cs.ucla.edu>
4751
99027bdd
PE
4752 Use sprintf return value instead of invoking strlen on result.
4753 In the old days this wasn't portable, since some sprintf
4754 implementations returned char *. But they died out years ago and
4755 Emacs already assumes sprintf returns int.
4756 Similarly for float_to_string.
4757 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
4758 * ccl.c (ccl_driver):
4759 * character.c (string_escape_byte8):
4760 * data.c (Fnumber_to_string):
4761 * doprnt.c (doprnt):
4762 * print.c (print_object):
4763 * xdisp.c (message_dolog):
4764 * xfns.c (syms_of_xfns):
4765 Use sprintf or float_to_string result to avoid need to call strlen.
4766 * data.c (Fnumber_to_string):
4767 Use make_unibyte_string, since the string must be ASCII.
4768 * lisp.h, print.c (float_to_string): Now returns int length.
4769 * term.c (produce_glyphless_glyph):
4770 Use sprintf result rather than recomputing it.
4771
cf38a720
PE
4772 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
4773 * Makefile.in (ALL_CFLAGS):
4774 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
4775 * gmalloc.c, regex.c: Include <config.h> unconditionally.
4776
3511c784
DA
47772012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4778
0a08eb21 4779 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
4780 strcasecmp if available.
4781 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
4782
fb7da12e
AS
47832012-06-25 Andreas Schwab <schwab@linux-m68k.org>
4784
4785 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
4786 Avoid comma operator.
4787 * menu.c (push_submenu_start, push_submenu_end)
4788 (push_left_right_boundary, push_menu_pane): Likewise.
4789 * msdos.c (dos_rawgetc): Likewise.
4790
afa2ffd8
DA
47912012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4792
4793 * xfns.c (xic_create_fontsetname): Remove redundant calls
4794 to memset.
4795
b3b4476b
PE
47962012-06-25 Paul Eggert <eggert@cs.ucla.edu>
4797
4495ff38
PE
4798 * gtkutil.c (get_utf8_string): Remove redundant assignment.
4799 sprintf already null-terminates its output.
4800
b3b4476b
PE
4801 * xfns.c (x_window): Remove redundant cast.
4802
b00876c9
DA
48032012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4804
4805 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
4806 `const char *' to `char *' to avoid compiler warning.
4807
d188e26b
PE
48082012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4809
885d1d74
PE
4810 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
4811 instead of truncating it to 63 (admittedly a generous limit).
4812
d188e26b
PE
4813 * process.c: Fix spelling and caps in comments.
4814
e2f560b1
DN
48152012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
4816
e86db54b 4817 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
4818 * sysdep.c (setpgrp): Remove definition, not used in this file.
4819
7583a3a1
JB
48202012-06-24 Juanma Barranquero <lekktu@gmail.com>
4821
4822 * makefile.w32-in: Update dependencies.
4823
696056c2
EZ
48242012-06-24 Eli Zaretskii <eliz@gnu.org>
4825
4826 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
4827 (SYSTIME_H): Add nt/inc/sys/time.h.
4828
4829 * systime.h [WINDOWSNT]: Include sys/time.h.
4830
4831 * s/ms-w32.h (struct timespec): Definition moved from
4832 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
4833
845ca893
PE
48342012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4835
4836 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
4837 * buffer.h (buffer_slot_type_mismatch):
4838 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4839 * eval.c (unwind_to_catch):
4840 * image.c (my_png_error, my_error_exit):
4841 * keyboard.c (quit_throw_to_read_char, user_error)
4842 (Fexit_recursive_edit, Fabort_recursive_edit):
4843 * lisp.h (die, args_out_of_range, args_out_of_range_3)
4844 (wrong_type_argument, buffer_overflow, __executable_start)
4845 (memory_full, buffer_memory_full, string_overflow, Fthrow)
4846 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
4847 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
4848 (fatal):
4849 (child_setup) [!DOS_NT]:
4850 * lread.c (end_of_file_error, invalid_syntax):
4851 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4852 * puresize.h (pure_write_error):
4853 * search.c (matcher_overflow):
4854 * sound.c (sound_perror, alsa_sound_perror):
4855 * sysdep.c, syssignal.h (croak):
4856 * term.c (maybe_fatal, vfatal):
4857 * textprop.c (text_read_only):
4858 * undo.c (user_error):
4859 * unexmacosx.c (unexec_error):
4860 * xterm.c (x_ins_del_lines, x_delete_glyphs):
4861 Use _Noreturn rather than NO_RETURN.
4862 No need for separate decl merely because of _Noreturn.
4863 * sound.c (sound_warning, parse_sound):
4864 Remove unnecessary forward decls.
4865
f1dd8073
PE
48662012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4867
4868 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
4869 * lisp.h (WAIT_READING_MAX): New macro.
4870 * dispnew.c (Fsleep_for, sit_for):
4871 * keyboard.c (kbd_buffer_get_event):
4872 * process.c (Faccept_process_output):
4873 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
4874 This improves on the previous patch, which introduced a bug
4875 when time_t is unsigned and as wide as intmax_t.
4876 See <http://bugs.gnu.org/9000#51>.
4877
b82c1755
EZ
48782012-06-23 Eli Zaretskii <eliz@gnu.org>
4879
4880 * dispnew.c (sit_for, Fsleep_for):
4881 * keyboard.c (kbd_buffer_get_event):
4882 * process.c (Faccept_process_output): Avoid compiler warnings when
4883 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
4884
ca300656
JB
48852012-06-23 Juanma Barranquero <lekktu@gmail.com>
4886
049ec95b
JB
4887 * makefile.w32-in: Update dependencies.
4888
ca300656
JB
4889 * w32.c (ltime): Add return type and declare static.
4890 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
4891
db7b8d06
PE
48922012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4893
4894 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
4895 Privately reported by Herbert J. Skuhra.
4896 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
4897 All uses changed.
4898 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
4899 not make_lisp_timeval, when the argument is of type EMACS_TIME.
4900
0bd8297f
EZ
49012012-06-23 Eli Zaretskii <eliz@gnu.org>
4902
96512555
EZ
4903 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
4904 last argument of make_unibyte_string.
4905
0bd8297f
EZ
4906 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
4907 language ID in the event parameters.
4908
4909 * w32term.c (w32_read_socket): Put the new keyboard codepage into
4910 event.code, not the obscure "character set ID".
4911
63def6b6
CY
49122012-06-23 Chong Yidong <cyd@gnu.org>
4913
4914 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
4915
e8a02204
EZ
49162012-06-23 Eli Zaretskii <eliz@gnu.org>
4917
388cdec0
EZ
4918 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
4919 * w32.c (fdutimens): New function.
4920
4921 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
4922
4923 * s/ms-w32.h (pselect): Redirect to sys_select.
4924
4925 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
4926
e8a02204
EZ
4927 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
4928 in the logic of incrementing and decrementing the value of
4929 use_relocatable_buffers.
4930
d054f3fb
PE
49312012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4932
4933 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
4934 Privately reported by Herbert J. Skuhra.
4935 [__FreeBSD__]: Remove "*/" typo after "#include".
4936 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
4937 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
4938 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
4939 Don't assume EMACS_TIME and struct timeval are the same type.
4940
d35af63c
PE
49412012-06-22 Paul Eggert <eggert@cs.ucla.edu>
4942
4943 Support higher-resolution time stamps (Bug#9000).
4944 The time stamps are only nanosecond-resolution at the C level,
4945 since that's the best that any real-world system supports now.
4946 But they are picosecond-resolution at the Lisp level, as that's
4947 easy, and leaves room for future OS improvements.
4948
4949 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
4950 (LIBES): Use it.
4951
4952 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
4953 Don't get current time unless it's needed.
4954
4955 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
4956 now provides it if it's absent.
4957 (start_atimer): Port to higher-res time stamps.
4958 Check for time stamp overflow. Don't get current time more
4959 often than is needed.
4960
4961 * buffer.h (struct buffer): Buffer modtime now has high resolution.
4962 Include systime.h, not time.h.
4963 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
4964
4965 * dired.c: Include stat-time.h.
4966 (Ffile-attributes): File times now have higher resolution.
4967
4968 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
4969 (struct image): Timestamp now has higher resolution.
4970
4971 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
4972 has at least microseconds now. All uses removed.
4973 (update_frame, update_single_window, update_window, update_frame_1)
4974 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 4975 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
4976
4977 * editfns.c (time_overflow): Now extern.
4978 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
4979 (float-time, Fformat_time_string, Fcurrent_time_string)
4980 (Fcurrent_time_zone): Accept and generate higher-resolution
4981 time stamps.
4982 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
4983 (decode_time_components, lisp_seconds_argument): New functions.
4984 (make_time): Now static.
4985 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
4986 Report an error if the time is invalid, rather than having the caller
4987 do that.
4988
4989 * fileio.c: Include <stat-time.h>
4990 (Fcopy_file): Copy higher-resolution time stamps.
4991 Prefer to set the time stamp via a file descriptor if that works.
4992 (Fset_file_times, Finsert_file_contents, Fwrite_region)
4993 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
4994 (Fvisited_file_modtime, Fset_visited_file_modtime):
4995 Support higher-resolution time stamps.
4996
4997 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
4998
4999 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
5000
5001 * image.c (prepare_image_for_display, clear_image_cache)
5002 (lookup_image): Port to higer-resolution time stamps.
5003
5004 * keyboard.c (start_polling, bind_polling_period):
5005 Check for time stamp overflow.
5006 (read_char, kbd_buffer_get_event, timer_start_idle)
5007 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
5008 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
5009 Port to higher-resolution time stamps. Do not assume time_t is signed.
5010 (decode_timer): New function. Timers are now vectors of length 9,
5011 not 8, to accommodate the picosecond component.
5012 (timer_check_2): Use it.
5013
5014 * nsterm.m (select_timeout, timeval_subtract): Remove.
5015 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
5016 as they're a bit more accurate and handle overflow better.
5017 (ns_select): Change prototype to be compatible with pselect.
5018 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
5019 * nsterm.h (ns_select): Adjust prototype.
5020
5021 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
5022 us-resolution time stamps.
5023 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
5024
5025 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
5026
5027 * lisp.h (time_overflow): New decl.
5028 (wait_reading_process_output): First arg is now intmax_t, not int,
5029 to accommodate larger waits.
5030
5031 * process.h (struct Lisp_Process.read_output_delay):
5032 Now counts nanoseconds, not microseconds.
5033 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
5034 EMACS_HAS_USECS.
5035 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
5036 (wait_reading_process_output):
5037 Port to ns-resolution time stamps.
5038 (Faccept_process_output, wait_reading_process_output):
5039 Check for time stamp overflow. Do not assume time_t is signed.
5040 (select_wrapper): Remove; we now use pselect.
5041 (Fprocess_attributes): Now generates ns-resolution time stamps.
5042
5043 * sysdep.c: Include utimens.h. Don't include utime.h
5044 or worry about struct utimbuf; gnulib does that for us now.
5045 (gettimeofday): Remove; gnulib provides a substitute.
5046 (make_timeval): New function.
5047 (set_file_times): Now sets ns-resolution time stamps.
5048 New arg FD; all uses changed.
5049 (time_from_jiffies, ltime_from_jiffies, get_up_time)
5050 (system_process_attributes):
5051 Now returns ns-resolution time stamp. All uses changed.
5052 Check for time stamp overflow.
5053
5054 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
5055 provides a substitute now.
5056
5057 * systime.h: Include timespec.h rather than sys/time.h and time.h,
5058 since it guarantees struct timespec.
5059 (EMACS_TIME): Now struct timespec, so that we can support
5060 ns-resolution time stamps.
5061 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
5062 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
5063 (EMACS_USECS): Remove.
5064 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
5065 so multiply the arg by 1000 before storing it.
5066 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
5067 New macros.
5068 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
5069 Port to ns-resolution time stamps.
5070 (EMACS_TIME_NEG_P): Remove; replaced by....
5071 (EMACS_TIME_SIGN): New macro.
5072 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
5073 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
5074 (set_file_times, make_time, lisp_time_argument): Adjust signature.
5075 (make_timeval, make_lisp_time, decode_time_components): New decls.
5076 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
5077 that it mishandled time_t overflow. You can't compare by subtracting!
5078 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
5079 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
5080
5081 * term.c: Include <sys/time.h>.
5082 (timeval_to_Time): New function, for proper overflow wraparound.
5083 (term_mouse_position, term_mouse_click): Use it.
5084
5085 * undo.c (record_first_change): Support higher-resolution time stamps
5086 in the undo buffer.
5087 (Fprimitive_undo): Use them when restoring time stamps.
5088
5089 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
5090 (w32_get_internal_run_time):
5091 Port to higher-resolution Emacs time stamps.
5092 (ltime): Now accepts single 64-bit integer, as that's more convenient
5093 for callers.
5094
5095 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
5096
5097 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
5098 for compatibility with pselect. Support ns-resolution time stamps.
5099
5100 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
5101
5102 * xselect.c (wait_for_property_change, x_get_foreign_selection):
5103 Check for time stamp overflow, and support ns-resolution time stamps.
5104
5105 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
5106 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
5107 (timeval_subtract): Remove; no longer needed.
5108 (XTflash, XTring_bell, x_wait_for_event):
5109 Port to ns-resolution time stamps. Don't assume time_t is signed.
5110
b6a92dfe
CY
51112012-06-22 Chong Yidong <cyd@gnu.org>
5112
5113 * xdisp.c (x_consider_frame_title): Revert last change.
5114
d251c37c
EZ
51152012-06-22 Eli Zaretskii <eliz@gnu.org>
5116
5117 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
5118 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
5119 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
5120 staticidx goes up to 1597 out of 1600 = 0x640.)
5121
f10deafb
PE
51222012-06-20 Paul Eggert <eggert@cs.ucla.edu>
5123
5124 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
5125 Otherwise, the umask might be mistakenly 0 while handling input signals.
5126
ec6de1e2
SM
51272012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
5128
5129 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
5130
28be1ada
DA
51312012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
5132
5133 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
5134 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
5135 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
5136 access to `contents' member of Lisp_Vector objects with AREF and ASET
5137 where appropriate.
5138
c6bf3022
CY
51392012-06-19 Chong Yidong <cyd@gnu.org>
5140
5141 * frame.c (delete_frame): When selecting a frame on a different
5142 text terminal, do not alter the terminal's top-frame.
5143
5144 * xdisp.c (format_mode_line_unwind_data): Record the target
5145 frame's selected window and its terminal's top-frame.
5146 (unwind_format_mode_line): Restore them.
5147 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
5148 Callers changed.
5149 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
5150 since tty frames can be explicitly named.
5151 (prepare_menu_bars): Likewise.
5152
5153 * term.c (Ftty_top_frame): New function.
5154
defd4196
PE
51552012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5156
5157 Port byte-code-meter to modern targets.
5158 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
5159 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 5160 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
5161 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
5162 (METER_1, METER_2): Simplify.
5163
1053a871
SM
51642012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
5165
5166 * data.c (Fdefalias): Return `symbol' (bug#11686).
5167
b7e8d081
MR
51682012-06-18 Martin Rudalics <rudalics@gmx.at>
5169
5170 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
5171 gets killed during executing of this function (Bug#11665).
5172 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
5173 (Vkill_buffer_query_functions): In doc-string say that functions
5174 run by this hook should not change the current buffer.
5175
7ea2b339
PE
51762012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5177
5178 Fix recently-introduced process.c problems found by static checking.
5179 * process.c (write_queue_push, write_queue_pop, send_process):
5180 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
5181 (write_queue_pop): Fix pointer signedness problem.
5182 (send_process): Remove unused local.
5183
96a313a1
CY
51842012-06-17 Chong Yidong <cyd@gnu.org>
5185
5186 * xdisp.c (redisplay_internal): No need to redisplay terminal
5187 frames that are not on top.
5188
20ca2e94
TN
51892012-06-17 Troels Nielsen <bn.troels@gmail.com>
5190
5191 * process.c (make_process): Initialize write_queue.
5192 (write_queue_push, write_queue_pop): New functions.
5193 (send_process): Use them to maintain correct ordering of process
5194 writes (Bug#10815).
5195
9a900ca9
PE
51962012-06-17 Paul Eggert <eggert@cs.ucla.edu>
5197
310fbfa8
PE
5198 * lisp.h (eassert): Assume C89 or later.
5199 This removes the need for CHECK.
5200 (CHECK): Remove. Its comments about always evaluating its
5201 argument were confusing, as 'eassert' typically does not evaluate
5202 its argument.
5203
27bb1ca4
PE
5204 * coding.c (produce_chars): Use ptrdiff_t, not int.
5205
9a900ca9
PE
5206 * xterm.c (x_draw_underwave): Check for integer overflow.
5207 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
5208
41b7f8bc 52092012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
5210
5211 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
5212 referenced (Bug#11583).
5213
9b0e3eba
AA
52142012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
5215
5216 Implement wave-style variant of underlining.
5217 * dispextern.h (face_underline_type): New enum.
5218 (face): Add field for underline type.
5219 * nsterm.m (ns_draw_underwave): New function.
5220 (ns_draw_text_decoration): Use it.
5221 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
5222 New functions.
5223 (x_draw_glyph_string): Use them.
5224 * xfaces.c (Qline, Qwave): New Lisp objects.
5225 (check_lface_attrs, merge_face_ref)
1053a871
SM
5226 (Finternal_set_lisp_face_attribute, realize_x_face):
5227 Handle wave-style underline face attributes.
9b0e3eba
AA
5228 * xterm.c (x_draw_underwave): New function.
5229 (x_draw_glyph_string): Use it.
5230
0fb52f11
JB
52312012-06-16 Juanma Barranquero <lekktu@gmail.com>
5232
5233 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
5234 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
5235 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
5236 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
5237 ($(BLD)/w32select.$(O)): Update dependencies.
5238
e5560ff7
AS
52392012-06-16 Andreas Schwab <schwab@linux-m68k.org>
5240
5241 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
5242 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
5243 * character.c (_fetch_multibyte_char_p): Remove.
5244 * alloc.c: Include "character.h" before "buffer.h".
5245 * bidi.c: Likewise.
5246 * buffer.c: Likewise.
5247 * bytecode.c: Likewise.
5248 * callint.c: Likewise.
5249 * callproc.c: Likewise.
5250 * casefiddle.c: Likewise.
5251 * casetab.c: Likewise.
5252 * category.c: Likewise.
5253 * cmds.c: Likewise.
5254 * coding.c: Likewise.
5255 * composite.c: Likewise.
5256 * dired.c: Likewise.
5257 * dispnew.c: Likewise.
5258 * doc.c: Likewise.
5259 * dosfns.c: Likewise.
5260 * editfns.c: Likewise.
5261 * emacs.c: Likewise.
5262 * fileio.c: Likewise.
5263 * filelock.c: Likewise.
5264 * font.c: Likewise.
5265 * fontset.c: Likewise.
5266 * fringe.c: Likewise.
5267 * indent.c: Likewise.
5268 * insdel.c: Likewise.
5269 * intervals.c: Likewise.
5270 * keyboard.c: Likewise.
5271 * keymap.c: Likewise.
5272 * lread.c: Likewise.
5273 * macros.c: Likewise.
5274 * marker.c: Likewise.
5275 * minibuf.c: Likewise.
5276 * nsfns.m: Likewise.
5277 * nsmenu.m: Likewise.
5278 * print.c: Likewise.
5279 * process.c: Likewise.
5280 * regex.c: Likewise.
5281 * region-cache.c: Likewise.
5282 * search.c: Likewise.
5283 * syntax.c: Likewise.
5284 * term.c: Likewise.
5285 * textprop.c: Likewise.
5286 * undo.c: Likewise.
5287 * unexsol.c: Likewise.
5288 * w16select.c: Likewise.
5289 * w32fns.c: Likewise.
5290 * w32menu.c: Likewise.
5291 * window.c: Likewise.
5292 * xdisp.c: Likewise.
5293 * xfns.c: Likewise.
5294 * xmenu.c: Likewise.
5295 * xml.c: Likewise.
5296 * xselect.c: Likewise.
5297
2f07e6af
EZ
52982012-06-16 Eli Zaretskii <eliz@gnu.org>
5299
1053a871
SM
5300 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
5301 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 5302 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
5303 row.
5304 (handle_face_prop): Use chunk-relative overlay string index when
5305 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
5306 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
5307 the rightmost. (Bug#11720)
2f07e6af 5308
29b83cec
AS
53092012-06-16 Andreas Schwab <schwab@linux-m68k.org>
5310
5311 * category.h (CHAR_HAS_CATEGORY): Define as inline.
5312 (CATEGORY_MEMBER): Enforce 1/0 value.
5313 * category.c (_temp_category_set): Remove.
5314
4c5501e9
EZ
53152012-06-16 Eli Zaretskii <eliz@gnu.org>
5316
5317 * window.c (Fdelete_other_windows_internal)
5318 (Fdelete_window_internal): Don't access frame's mouse highlight
5319 info of the initial frame. (Bug#11677)
5320
2b570124
PE
53212012-06-14 Paul Eggert <eggert@cs.ucla.edu>
5322
e93864f9
PE
5323 * .gdbinit (xgetint): Fix recently-introduced paren typo.
5324 Assume USE_2_TAGS_FOR_INTS.
5325 (xreload): Adjust $tagmask width to match recent lisp.h change.
5326
2b570124
PE
5327 Simplify lisp.h in minor ways that should not affect code.
5328 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
5329 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
5330 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
5331 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
5332 (INTTYPEBITS): New macro, for clarity.
5333 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
5334 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
5335 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
5336 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
5337 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
5338
81755f69
JB
53392012-06-13 Juanma Barranquero <lekktu@gmail.com>
5340
5341 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
5342
16192a57
GM
53432012-06-13 Glenn Morris <rgm@gnu.org>
5344
5345 * s/bsd-common.h (BSD4_3):
5346 * s/usg5-4-common.h (USG5_4): No longer define; unused.
5347
646b5f55
AS
53482012-06-13 Andreas Schwab <schwab@linux-m68k.org>
5349
5350 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
5351 instead of union.
5352 (XLI, XIL): Define.
1053a871
SM
5353 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
5354 Use them.
5355 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 5356 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 5357 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
5358 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
5359 * frame.c (delete_frame): Remove outdated comment.
5360 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
5361 USE_LISP_UNION_TYPE.
5362 (Fw32_unregister_hot_key): Likewise.
5363 (Fw32_toggle_lock_key): Likewise.
5364 * w32menu.c (add_menu_item): Likewise.
5365 (w32_menu_display_help): Use XIL instead of checking
5366 USE_LISP_UNION_TYPE.
5367 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
5368 (init_heap): Likewise.
5369 * w32term.c (w32_read_socket): Update comment.
5370
1d3823c9
GM
53712012-06-13 Glenn Morris <rgm@gnu.org>
5372
c62ff706
GM
5373 * s/usg5-4-common.h, src/s/unixware.h:
5374 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
5375
1d3823c9
GM
5376 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
5377
bfe3e0a2
PE
53782012-06-13 Paul Eggert <eggert@cs.ucla.edu>
5379
5380 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
5381 * alloc.c (make_number) [!defined make_number]:
5382 Remove, as lisp.h always defines this now.
5383 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
5384 (roundup_size): Verify that it is a power of 2.
5385 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
5386 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
5387 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
5388 -DUSE_LSB_TAG=0, to override the automatically-selected default.
5389 USE_LSB_TAG now is always defined to be either 0 or 1.
5390 All uses changed.
5391 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
5392 code works fine either way, and efficiency is not a concern here,
5393 as the union type is for debugging, not for production.
5394 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
5395 Use an inline function on all platforms when using the union type,
5396 since this is simpler and 'static inline' can be used portably
5397 within Emacs now.
5398 (LISP_INITIALLY_ZERO): New macro.
5399 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
5400 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
5401
45fa9c0f
GM
54022012-06-12 Glenn Morris <rgm@gnu.org>
5403
b4492cba
GM
5404 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
5405
5406 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 5407
45fa9c0f
GM
5408 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
5409 Move BROKEN_SIGIO to configure.
5410
5411 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
5412 Move NO_TERMIO to configure.
5413
0e25d334
CY
54142012-06-12 Chong Yidong <cyd@gnu.org>
5415
5416 * image.c (imagemagick_load_image): Use MagickFlattenImage if
5417 MagickMergeImageLayers is undefined. Use pixel pusher loop if
5418 MagickExportImagePixels is undefined.
5419
43682bb6
PE
54202012-06-12 Paul Eggert <eggert@cs.ucla.edu>
5421
5422 * image.c (imagemagick_load_image): Remove unused label.
5423
a9be7d2b
GM
54242012-06-11 Glenn Morris <rgm@gnu.org>
5425
5426 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5427 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
5428 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
5429 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
5430
3017f87f
SM
54312012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
5432
5433 * alloc.c (make_byte_code): New function.
5434 (Fmake_byte_code): Use it. Don't purify here.
5435 * lread.c (read1): Use it as well to avoid extra allocation.
5436
1b9b4cf4
CY
54372012-06-11 Chong Yidong <cyd@gnu.org>
5438
5439 * image.c (imagemagick_load_image): Implement transparency.
5440
95988fcf
AS
54412012-06-10 Andreas Schwab <schwab@linux-m68k.org>
5442
5443 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
5444 account for preceding backslashes. (Bug#11663)
5445
cd4eb164
CY
54462012-06-09 Chong Yidong <cyd@gnu.org>
5447
5448 * term.c: Support italics in capable terminals (Bug#9652).
5449 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
5450 (turn_on_face): Output using TS_enter_italic_mode if available.
5451 Don't handle unused blinking and alt-charset cases.
5452 (turn_off_face): Handle italic case; discard unused tty_blinking_p
5453 and tty_alt_charset_p cases.
5454 (tty_capable_p, init_tty): Support italics.
5455
5456 * termchar.h (struct tty_display_info): Add field for italics.
5457 Remove unused blink field.
5458
5459 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
5460 Handle slant.
5461
5462 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
5463 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
5464 tty_alt_charset_p. Add tty_italic_p.
5465
ff88beb8
MA
54662012-06-09 Michael Albinus <michael.albinus@gmx.de>
5467
5468 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
5469 dbus_type_is_basic if available.
5470 (xd_extract_signed, xd_extract_unsigned): Rename from
5471 extract_signed and extract_unsigned, respectively. Adapt callers.
5472
44286096
CY
54732012-06-09 Chong Yidong <cyd@gnu.org>
5474
1682701f
CY
5475 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
5476
44286096
CY
5477 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
5478 case (Bug#9752).
5479
d86feb17
PE
54802012-06-08 Paul Eggert <eggert@cs.ucla.edu>
5481
5482 * xdisp.c (vmessage): Treat frame message as multibyte.
5483 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
5484 would generate the diagnostic "Making \302\247 buffer-local while
5485 let-bound!".
5486
d5c20fe8
EZ
54872012-06-08 Eli Zaretskii <eliz@gnu.org>
5488
5489 * dispnew.c (showing_window_margins_p): Undo last change, which
5490 was done due to an inadvertent commit.
5491 (adjust_frame_glyphs_for_frame_redisplay): Do call
5492 showing_window_margins_p.
5493
513749ee
SM
54942012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5495
5496 * eval.c (Fmake_var_non_special): New primitive.
5497 (syms_of_eval): Defsubr it.
5498 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
5499
d4a8f5c1
JB
55002012-06-08 Juanma Barranquero <lekktu@gmail.com>
5501
5502 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
5503 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
5504
8bbbc977
EZ
55052012-06-08 Eli Zaretskii <eliz@gnu.org>
5506
5507 * alloc.c (allocate_vectorlike): Fix last change.
5508
f3372c87
DA
55092012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
5510
5511 Block-based vector allocation of small vectors.
5512 * lisp.h (struct vectorlike_header): New field `nbytes',
5513 adjust comment accordingly.
5514 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
5515 to denote vector blocks. Adjust users (live_vector_p,
5516 mark_maybe_pointer, valid_lisp_object_p) accordingly.
5517 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
5518 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
5519 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
5520 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
5521 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
5522 (roundup_size): New constant.
5523 (struct vector_block): New data type.
5524 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 5525 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
5526 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
5527 (sweep_vectors): New functions.
5528 (allocate_vectorlike): Return `zero_vector' as the only vector of
5529 0 items. Allocate new vector from block if vector size is less than
5530 or equal to VBLOCK_BYTES_MAX.
5531 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
5532 (init_alloc_once): Add call to init_vectors.
5533
4f18a4ed
SM
55342012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5535
5536 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
5537
86f158bc
PE
55382012-06-07 Paul Eggert <eggert@cs.ucla.edu>
5539
5540 * doprnt.c (doprnt): Truncate multibyte char correctly.
5541 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
5542 would mishandle a string argument "Xc" if X was a multibyte
5543 character of length 2: it would truncate after X's first byte
5544 rather than including all of X.
5545
c5cfcbe0
CY
55462012-06-06 Chong Yidong <cyd@gnu.org>
5547
5548 * buffer.c (word_wrap): Doc fix.
5549
c05cf390
PE
55502012-06-04 Paul Eggert <eggert@cs.ucla.edu>
5551
5552 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
5553
0c3461de
GM
55542012-06-03 Glenn Morris <rgm@gnu.org>
5555
5556 * xdisp.c (tool-bar-style): Doc fix.
5557
c71232db
UM
55582012-06-03 Ulrich Müller <ulm@gentoo.org>
5559
5560 * Makefile.in (PAXCTL): Define.
5561 (temacs$(EXEEXT)): Disable memory randomization for the temacs
5562 binary via PaX flags if the paxctl utility is available.
5563 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
5564 Restore PaX flags to their default. (Bug#11398)
5565
383f7350
CY
55662012-06-03 Chong Yidong <cyd@gnu.org>
5567
5568 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
5569 buffer (Bug#11226).
5570
5f2c76c6
CY
55712012-06-03 Chong Yidong <cyd@gnu.org>
5572
5573 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
5574 (note_mode_line_or_margin_highlight): If there is no help echo,
5575 use mode-line-default-help-echo. Handle the case where the mouse
5576 position is past the end of the mode line string.
5577
5578 * buffer.c (buffer_local_value_1): New function, split from
5579 Fbuffer_local_value; can return Qunbound.
5580 (Fbuffer_local_value): Use it.
5581 (Vmode_line_format): Docstring tweaks.
5582
773d47f6
PE
55832012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5584
5585 * sysdep.c (system_process_attributes): Improve comment.
5586
f2d6a3df
SM
55872012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
5588
5589 * keyboard.c: Export real-this-command to Elisp.
5590 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
5591 and DEFVAR it. Update all users.
5592
63810350
PE
55932012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5594
7bd5c1f4
PE
5595 * minibuf.c (Fassoc_string): Remove duplicate declaration.
5596
63810350
PE
5597 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
5598 Convert pctcpu and pctmem to Lisp float properly.
5599 Let the compiler fold better, as 100.0/0x8000 is exact.
5600
a2821611
AS
56012012-06-02 Andreas Schwab <schwab@linux-m68k.org>
5602
5603 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
5604 cons_block.
5605
5fceba1d
PE
56062012-06-01 Paul Eggert <eggert@cs.ucla.edu>
5607
5608 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
5609
c98ff5dd
DA
56102012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
5611
5612 For a 'struct window', replace some Lisp_Object fields to
5613 bitfields where appropriate, remove unused fields.
5614 * window.h (struct window): Remove unused 'last_mark_x' and
5615 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
5616 change it's type from Lisp_Object to bitfield.
5617 Change type of 'force_start', 'optional_new_start',
5618 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
5619 fields from Lisp_Object to bitfield. Adjust users accordingly.
5620
ca34e0be
PE
56212012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5622
5623 Pacify gcc -Wdouble-precision when using Xaw.
5624 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
5625 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
5626 Use 'float' consistently, rather than 'float' in most places
5627 and 'double' in a couple of places.
5628
efc00ab1 56292012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
5630
5631 * xdisp.c (handle_stop): Detect whether we have overlay strings
5632 loaded by testing it->current.overlay_string_index to be
5633 non-negative, instead of checking whether n_overlay_strings is
5634 positive. (Bug#11587)
5635
efc00ab1 56362012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
5637
5638 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
5639
5640 * doc.c (Fsubstitute_command_keys): Doc fix.
5641
efc00ab1 56422012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
5643
5644 * search.c (search_buffer): Remove calls to
5645 r_alloc_inhibit_buffer_relocation, as it is now called by
5646 maybe_unify_char, which was the cause of relocation of buffer text
5647 in bug#11519.
5648
efc00ab1 56492012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
5650
5651 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
5652 for the duration of call to load_charset, to avoid problems with
5653 callers of maybe_unify_char that access buffer text through C
5654 pointers.
5655
5656 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
5657 decrement the inhibition flag, instead of just setting or
5658 resetting it.
5659
ba93a187
PE
56602012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5661
5662 Remove obsolete '#define static' cruft.
5663 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
5664 This #undef was "temporary" in 2000; it is no longer needed
5665 now that '#define static' has gone away.
5666 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
5667 (gray_bitmap_bits): Remove; no longer needed.
5668 All uses replaced with definiens.
5669 * xterm.c: Include "bitmaps/gray.xbm".
5670
9e4bf381
PE
56712012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5672
5673 Clean up __executable_start, monstartup when --enable-profiling.
5674 The following changes affect the code only when profiling.
5675 * dispnew.c (__executable_start): Rename from safe_bcopy.
5676 Define only on platforms that need it.
5677 * emacs.c: Include <sys/gmon.h> when profiling.
5678 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
5679 (__executable_start): Remove decl, since lisp.h does it now.
5680 (safe_bcopy): Remove decl; no longer has that name.
5681 (main): Coalesce #if into single bit of code, for simplicity.
5682 Cast pointers to uintptr_t, since standard libraries want integers
5683 and not pointers.
5684 * lisp.h (__executable_start): New decl.
5685
32d72c2f
GM
56862012-05-31 Glenn Morris <rgm@gnu.org>
5687
5688 * image.c (Fimagemagick_types): Doc fix.
5689
baac5bc7
JM
56902012-05-30 Jim Meyering <meyering@redhat.com>
5691
5692 * callproc.c (Fcall_process_region): Include directory component
5693 in mkstemp error message (Bug#11586).
5694
72cb32cf
PE
56952012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5696
5697 * alloc.c, lisp.h (make_pure_vector): Now static.
5698
61b108cc
SM
56992012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
5700
5701 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
5702 Move to byte-run.el.
5703 (Fautoload): Do the hash-doc more carefully.
5704 * data.c (Fdefalias): Purify definition, except for keymaps.
5705 (Qdefun): Move from eval.c.
5706 * lisp.h (Qdefun): Remove.
5707 * lread.c (read1): Tiny simplification.
5708
471fe23d
TN
57092012-05-29 Troels Nielsen <bn.troels@gmail.com>
5710
934f3f58 5711 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
5712 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
5713 Bug#9642, but explicitly check that the buffer the overlay would
5714 be moved to is live and rearrange lines to make sure that errors
5715 will not put the overlay in an inconsistent state.
5716 (Fdelete_overlay): Cosmetics.
5717
85d0efd1
EZ
57182012-05-28 Eli Zaretskii <eliz@gnu.org>
5719
5720 * w32term.c (my_bring_window_to_top): New function.
5721 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
5722 could be different from the original one.
5723 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
5724 (Bug#11513)
5725
5726 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
5727 by calling BringWindowToTop.
5728
5729 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
5730 (WM_EMACS_END): Increase by one.
5731
da92a98c
PE
57322012-05-28 Paul Eggert <eggert@cs.ucla.edu>
5733
5734 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
5735 This avoids undefined behavior that might cause the eassert
5736 to not catch an out-of-range value.
5737
74d1f848
JB
57382012-05-28 Juanma Barranquero <lekktu@gmail.com>
5739
5740 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
5741 Update dependencies.
5742
9e1a06fc
EZ
57432012-05-27 Eli Zaretskii <eliz@gnu.org>
5744
5745 * bidi.c (bidi_mirror_char): Fix last change.
5746
f3dd7312
AS
57472012-05-27 Andreas Schwab <schwab@linux-m68k.org>
5748
5749 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
5750 when referring to sectname field in printf format.
5751
81899c91
PE
57522012-05-27 Paul Eggert <eggert@cs.ucla.edu>
5753
57b81a9f
PE
5754 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
5755 Only r_alloc_inhibit_buffer_relocation needed to be added;
5756 the others were already declared.
5757
81899c91
PE
5758 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
5759 before checking whether it's out of range. Put the check inside
5760 eassert. See
5761 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
5762
33017faf 57632012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
5764
5765 * callproc.c (Fcall_process): Restore a line that was accidentally
5766 commented out in the 2011-02-13 change (bug#11547).
5767
33017faf 57682012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
5769
5770 * lisp.h [REL_ALLOC]: Add prototypes for external functions
5771 defined on ralloc.c.
5772
5773 * buffer.c [REL_ALLOC]: Remove prototypes of
5774 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
5775 they are now on lisp.h.
5776
5777 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
5778
5779 * search.c (search_buffer): Use it to inhibit relocation of buffer
5780 text while re_search_2 is doing its job, because re_search_2 is
5781 passed C pointers to buffer text. (Bug#11519)
5782
23415acf
EZ
5783 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
5784 Update value to 24.
5785
44e27368
EZ
5786 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
5787 state after an additional call to move_it_in_display_line_to, keep
5788 the values of it->max_ascent and it->max_descent found for the
5789 entire line.
5790 (pos_visible_p): Revert the comparison against bottom_y to what it
5791 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
5792 (Bug#11464)
5793
c1892f11
PE
57942012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5795
5796 Fix coding-related core dumps with gcc -ftrapv.
5797 The code was computing A - B, where A and B are pointers, and B is
5798 random garbage. This can lead to core dumps on platforms that
5799 have special pointer registers, and it also leads to core dumps on
5800 x86-64 when compiled with gcc -ftrapv. The fix is to compute
5801 A - B only when B is initialized properly.
5802 * coding.c (coding_set_source, coding_set_destination): Return void.
5803 (coding_change_source, coding_change_destinations): New functions,
5804 with the old behaviors of coding_set_source and coding_set_destination.
5805 All callers that need an offset changed to use these new functions.
5806
eb7afdad
GM
58072012-05-26 Glenn Morris <rgm@gnu.org>
5808
5809 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
5810
f12fdf02
EZ
58112012-05-26 Eli Zaretskii <eliz@gnu.org>
5812
53a63be6 5813 Extend mouse support on W32 text-mode console.
61b108cc
SM
5814 * xdisp.c (draw_row_with_mouse_face):
5815 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 5816
eb3f6f01 5817 * w32console.c: Include window.h.
61b108cc
SM
5818 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
5819 New functions.
eb3f6f01
EZ
5820 (initialize_w32_display): Initialize mouse-highlight data.
5821
53a63be6
EZ
5822 * w32inevt.c: Include termchar.h and window.h.
5823 (do_mouse_event): Support mouse-autoselect-window. When the mouse
5824 moves, call note_mouse_highlight. If help_echo changed, call
5825 gen_help_event to produce help-echo message in the echo area.
5826 Call clear_mouse_face if mouse_face_hidden is set in the mouse
5827 highlight info.
5828
4cfd81f6
PE
58292012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5830
5831 * lread.c (read1): Simplify slightly to avoid an overflow warning
5832 with GCC 4.7.0 on x86-64.
5833
4446092a
EZ
58342012-05-26 Eli Zaretskii <eliz@gnu.org>
5835
5836 * bidi.c (bidi_mirror_char): Revert last change: an int is
5837 definitely wide enough here.
5838
42b2a986 58392012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 5840
42b2a986 5841 Fix integer width and related bugs (Bug#9874).
eb106a49 5842 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5843 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5844 (string_bytes, check_sblock, allocate_string_data):
5845 (compact_small_strings, Fmake_bool_vector, make_string)
5846 (make_unibyte_string, make_multibyte_string)
5847 (make_string_from_bytes, make_specified_string)
5848 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
5849 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
5850 (mark_vectorlike):
5851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5852 (allocate_pseudovector):
5853 Use int, not EMACS_INT, where int is wide enough.
5854 (inhibit_garbage_collection, Fgarbage_collect):
5855 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5856 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
5857 int might not be wide enough.
5858 (bidi_cache_search, bidi_cache_find, bidi_init_it)
5859 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
5860 (bidi_at_paragraph_end, bidi_find_paragraph_start)
5861 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5862 (bidi_level_of_next_char, bidi_move_to_visually_next):
5863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5864 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
5865 (Fkill_buffer, Fset_buffer_major_mode)
5866 (advance_to_char_boundary, Fbuffer_swap_text)
5867 (Fset_buffer_multibyte, overlays_at, overlays_in)
5868 (overlay_touches_p, struct sortvec, record_overlay_string)
5869 (overlay_strings, recenter_overlay_lists)
5870 (adjust_overlays_for_insert, adjust_overlays_for_delete)
5871 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
5872 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
5873 (Foverlay_recenter, last_overlay_modification_hooks_used)
5874 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
5875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
5876 (validate_region): Omit unnecessary test for b <= e,
5877 since that's guaranteed by the previous test.
d311d28c
PE
5878 (adjust_overlays_for_delete): Avoid pos + length overflow.
5879 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
5880 (report_overlay_modification):
5881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5882 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
5883 Omit pointer cast, which isn't needed anyway, and doesn't work
5884 after the EMACS_INT -> ptrdiff_t change.
02481186 5885 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
5886 * buffer.h: Adjust decls to match defn changes elsewhere.
5887 (struct buffer_text, struct buffer):
5888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5889 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
5890 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
5891 not int, to avoid needless 32-bit limit on 64-bit hosts.
5892 (exec_byte_code): Use tighter memory-full test, one that checks
5893 for alloca overflow. Don't compute the address of the object just
5894 before an array, as that's not portable. Use EMACS_INT, not
5895 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
5896 * callint.c (Fcall_interactively):
5897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5898 * callproc.c (call_process_kill, Fcall_process):
5899 Don't assume pid_t fits into an Emacs fixnum.
5900 (call_process_cleanup, Fcall_process, child_setup):
5901 Don't assume pid_t fits into int.
5902 (call_process_cleanup, Fcall_process, delete_temp_file)
5903 (Fcall_process_region):
5904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5905 (Fcall_process): Simplify handling of volatile integers.
5906 Use int, not EMACS_INT, where int will do.
5907 * casefiddle.c (casify_object, casify_region, operate_on_word)
5908 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
5909 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5910 (casify_object): Avoid integer overflow when overallocating buffer.
5911 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 5912 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
5913 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
5914 * category.h (CATEGORYP): Don't assume arg is nonnegative.
5915 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
5916 integers are now checked earlier. All uses replaced with XINT.
5917 (ccl_driver):
5918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5919 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
5920 (ccl_driver, Fregister_code_conversion_map):
5921 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
5922 (resolve_symbol_ccl_program): Check that vector header is in range.
5923 Always copy the vector, so that we can check its contents reliably
5924 now rather than having to recheck each instruction as it's being
5925 executed. Check that vector words fit in 'int'.
5926 (ccl_get_compiled_code, Fregister_ccl_program)
5927 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
5928 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
5929 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
5930 contents are in range.
5931 (Fccl_execute_on_string): Check that status is in range.
5932 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
5933 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
5934 Accept and return EMACS_INT, not int, because callers can pass values
5935 out of 'int' range.
5936 (c_string_width, strwidth, lisp_string_width, chars_in_text)
5937 (multibyte_chars_in_text, parse_str_as_multibyte)
5938 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
5939 (str_as_unibyte, str_to_unibyte, string_count_byte8)
5940 (string_escape_byte8, Fget_byte):
5941 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 5942 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
5943 avoid mishandling large integers.
5944 * character.h: Adjust decls to match defn changes elsewhere.
5945 * charset.c (load_charset_map_from_file, find_charsets_in_text)
5946 (Ffind_charset_region):
5947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5948 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
5949 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 5950 Don't assume fixnum fits in int.
d311d28c
PE
5951 (load_charset_map_from_vector, Fmap_charset_chars):
5952 Remove now-unnecessary CHECK_NATNUMs.
5953 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
5954 Don't rely on undefined behavior with signed left shift overflow.
5955 Don't assume unsigned int fits into fixnum, or that fixnum fits
5956 into unsigned int. Don't require max_code to be a valid fixnum;
5957 that's not true for gb10830 4-byte on a 32-bit host. Allow
5958 invalid_code to be a cons, for the same reason. Require code_offset
5959 to be a character. Avoid int overflow if max_char is close
5960 to INT_MAX.
5961 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
5962 this is intended anyway and avoids some undefined behavior.
5963 (load_charset_map): Pass unsigned, not int, as 2nd arg of
5964 INDEX_TO_CODE_POINT, as that's what it expects.
5965 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
5966 * charset.h (DECODE_CHAR): Return int, not unsigned;
5967 this is what was intended anyway, and it avoids undefined behavior.
5968 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
5969 integer-overflow issues.
5970 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
5971 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
5972 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
5973 * chartab.c (Fmake_char_table, Fset_char_table_range)
5974 (uniprop_get_decoder, uniprop_get_encoder):
5975 Don't assume fixnum fits in int.
5976 * cmds.c (move_point): New function, that does the gist of
5977 Fforward_char and Fbackward_char, but does so while checking
5978 for integer overflow more accurately.
c96e5d6a 5979 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
5980 (Fforward_line, Fend_of_line, internal_self_insert)
5981 (internal_self_insert):
5982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5983 Fix a FIXME, by checking for integer overflow when calculating
5984 target_clm and actual_clm.
5985 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 5986 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
5987 (ASSURE_DESTINATION, coding_alloc_by_realloc)
5988 (coding_alloc_by_making_gap, alloc_destination)
5989 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
5990 (encode_coding_utf_16, detect_coding_emacs_mule)
5991 (decode_coding_emacs_mule, encode_coding_emacs_mule)
5992 (detect_coding_iso_2022, decode_coding_iso_2022)
5993 (encode_invocation_designation, encode_designation_at_bol)
5994 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5995 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
5996 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
5997 (encode_coding_ccl, encode_coding_raw_text)
5998 (detect_coding_charset, decode_coding_charset)
5999 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
6000 (produce_composition, produce_charset, produce_annotation)
6001 (decode_coding, handle_composition_annotation)
6002 (handle_charset_annotation, consume_chars, decode_coding_gap)
6003 (decode_coding_object, encode_coding_object, detect_coding_system)
6004 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
6005 (code_convert_region, code_convert_string)
8f50130c
PE
6006 (Fdefine_coding_system_internal)
6007 (coding_set_source, coding_set_destination):
d311d28c
PE
6008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6009 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
6010 (Fdefine_coding_system_internal):
6011 Don't assume fixnums fit in int.
6012 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 6013 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
6014 (Funencodable_char_position, Fcheck_coding_systems_region)
6015 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 6016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 6017 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 6018 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 6019 Don't access memory outside of the args array.
d311d28c 6020 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
6021 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
6022 result of ENCODE_CHAR.
d311d28c
PE
6023 * coding.h: Adjust decls to match defn changes elsewhere.
6024 (struct coding_system):
6025 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6026 * composite.c (get_composition_id, find_composition)
6027 (run_composition_function, update_compositions)
6028 (compose_text, composition_gstring_put_cache)
6029 (composition_gstring_p, composition_gstring_width)
6030 (fill_gstring_header, fill_gstring_body, autocmp_chars)
6031 (composition_compute_stop_pos, composition_reseat_it)
6032 (composition_update_it, struct position_record)
6033 (find_automatic_composition, composition_adjust_point)
6034 (Fcomposition_get_gstring, Ffind_composition_internal):
6035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6036 (update_compositions):
6037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6038 * composite.h: Adjust decls to match defn changes elsewhere.
6039 (struct composition):
6040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6041 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
6042 Do not attempt to compute the address of the object just before a
6043 buffer; this is not portable.
6044 (Faref, Faset):
6045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6046 (Faset): Use int, not EMACS_INT, where int is wide enough.
6047 (Fstring_to_number): Don't assume fixnums fit in int.
6048 (Frem): Don't assume arg is nonnegative.
6049 * dbusbind.c (xd_append_arg): Check for integers out of range.
6050 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 6051 (extract_signed, extract_unsigned): New functions.
243e0530
PE
6052 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
6053 (xd_get_connection_references): Return ptrdiff_t, not int.
6054 All uses changed.
6055 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
6056 (xd_read_message_1):
6057 Use int, not unsigned, where the dbus API uses int.
6058 (Fdbus_message_internal): Don't overflow mtype.
6059 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
6060 * dired.c (directory_files_internal, file_name_completion, scmp)
6061 (file_name_completion_stat):
6062 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6063 (file_name_completion): Don't overflow matchcount.
6064 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
6065 * dispextern.h: Adjust decls to match defn changes elsewhere.
6066 (struct text_pos, struct glyph, struct bidi_saved_info)
6067 (struct bidi_string_data, struct bidi_it, struct composition_it)
6068 (struct it):
6069 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6070 (struct display_pos, struct composition_it, struct it):
6071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6072 * dispnew.c (increment_matrix_positions)
6073 (increment_row_positions, mode_line_string)
6074 (marginal_area_string):
6075 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 6076 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
6077 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6078 (duration_to_sec_usec): New function, to check for overflow better.
6079 (Fsleep_for, sit_for): Use it.
6080 * doc.c (get_doc_string, store_function_docstring):
6081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6082 (get_doc_string, Fsnarf_documentation):
6083 Use int, not EMACS_INT, where int is wide enough.
6084 (get_doc_string):
6085 Use SAFE_ALLOCA, not alloca.
6086 Check for overflow when converting EMACS_INT to off_t.
6087 * doprnt.c (doprnt):
6088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6089 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
6090 Don't assume uid_t fits into fixnum.
6091 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
6092 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
6093 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
6094 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
6095 (general_insert_function)
6096 (Finsert_char, make_buffer_string, make_buffer_string_both)
6097 (update_buffer_properties, Fbuffer_substring)
6098 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
6099 (Fsubst_char_in_region, check_translation)
6100 (Ftranslate_region_internal, save_restriction_restore, Fformat)
6101 (transpose_markers, Ftranspose_regions):
6102 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6103 (clip_to_bounds): Move to lisp.h as an inline function).
6104 (Fconstrain_to_field): Don't assume integers are nonnegative.
6105 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
6106 (Fsubst_char_in_region, Fsave_restriction):
6107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6108 (Femacs_pid): Don't assume pid_t fits into fixnum.
6109 (lo_time): Use int, not EMACS_INT, when int suffices.
6110 (lisp_time_argument): Check for usec out of range.
6111 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
6112 (Fuser_login_name, Fuser_full_name): Signal an error
6113 if a uid argument is out of range, rather than relying on
6114 undefined behavior.
c8d5c857
PE
6115 (Fformat_time_string): Remove now-unnecessary check.
6116 lisp_time_argument checks for out-of-range usec now.
243e0530 6117 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
6118 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
6119 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
6120 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
6121 (init_cmdargs, Fdump_emacs):
6122 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6123 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
6124 the bottom (typically) 32 bits of the fixnum.
6125 * eval.c (specpdl_size, call_debugger):
6126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6127 (when_entered_debugger, Fbacktrace_debug):
6128 Don't assume fixnum can fit in int.
6129 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
6130 the object just before a buffer; this is not portable.
6131 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
6132 (grow_specpdl, unbind_to):
6133 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6134 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
6135 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 6136 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
6137 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
6138 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
6139 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6140 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
6141 (a_write, e_write):
6142 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6143 (Fcopy_file, non_regular_nbytes, read_non_regular)
6144 (Finsert_file_contents):
6145 Use int, not EMACS_INT, where int is wide enough.
6146 (READ_BUF_SIZE): Verify that it fits in int.
6147 (Finsert_file_contents): Check that counts are in proper range,
6148 rather than assuming fixnums fit into ptrdiff_t etc.
6149 Don't assume fixnums fit into int.
125b3835 6150 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
6151 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
6152 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
6153 (string_char_to_byte, string_byte_to_char)
6154 (string_make_multibyte, string_to_multibyte)
6155 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
6156 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
6157 (substring_both, Fdelete, internal_equal, Ffillarray)
6158 (Fclear_string, mapcar1)
6159 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
6160 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
6161 (larger_vector, make_hash_table, maybe_resize_hash_table)
6162 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
6163 (Fmaphash, secure_hash):
6164 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6165 (concat): Check for string index and length overflow.
6166 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
6167 (Frequire):
6168 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6169 (larger_vector): New API (vec, incr_min, size_max) replaces old
6170 one (vec, new_size, init). This catches size overflow.
6171 INIT was removed because it was always Qnil.
6172 All callers changed.
6173 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
6174 the upper bound on a hash table index size.
6175 (make_hash_table, maybe_resize_hash_table): Use it.
6176 (secure_hash): Computer start_byte and end_byte only after
6177 they're known to be in ptrdiff_t range.
6178 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
6179 (Ffont_get_glyphs, Ffont_at):
6180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6181 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
6182 (Flist_fonts, Fopen_font):
6183 Don't assume fixnum can fit in int.
6184 (check_gstring): Don't assume index can fit in int.
6185 (font_match_p): Check that fixnum is a character, not a nonnegative
6186 fixnum, since the later code needs to stuff it into an int.
6187 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
6188 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
6189 conversion overflow issues.
6190 (Fopen_font): Check for integer out of range.
6191 (Ffont_get_glyphs): Don't assume index can fit in int.
6192 * font.h: Adjust decls to match defn changes elsewhere.
6193 * fontset.c (reorder_font_vector): Redo score calculation to avoid
6194 integer overflow.
6195 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
6196 printmax_t, where ptrdiff_t is wide enough.
6197 (Finternal_char_font):
6198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6199 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
6200 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
6201 (Fset_frame_position, x_set_frame_parameters)
6202 (x_set_line_spacing, x_set_border_width)
6203 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
6204 Check that fixnums are in proper range for system types.
6205 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
6206 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6207 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
6208 Use SAFE_ALLOCA_LISP, not alloca.
6209 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
6210 intptr_t is wide enough.
6211 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
6212 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
6213 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
6214 Check for fixnum out of range.
6215 * ftfont.c (ftfont_list): Don't assume index fits in int.
6216 Check that fixnums are in proper range for system types.
6217 (ftfont_shape_by_flt):
6218 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
6219 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6220 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6221 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
6222 Check that fixnums are in proper range for system types.
6223 * gnutls.h: Adjust decls to match defn changes elsewhere.
6224 * gtkutil.c (xg_dialog_run):
6225 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6226 (update_frame_tool_bar):
6227 Check that fixnums are in proper range for system types.
6228 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 6229 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
6230 * indent.c (last_known_column, last_known_column_point):
6231 (current_column_bol_cache):
6232 (skip_invisible, current_column, check_display_width):
6233 (check_display_width, scan_for_column, current_column_1)
6234 (Findent_to, Fcurrent_indentation, position_indentation)
6235 (indented_beyond_p, Fmove_to_column, compute_motion):
6236 (Fcompute_motion, Fvertical_motion):
6237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6238 (last_known_column_modified): Use EMACS_INT, not int.
6239 (check_display_width):
6240 (Fcompute_motion):
6241 Check that fixnums and floats are in proper range for system types.
6242 (compute_motion): Don't assume index or fixnum fits in int.
6243 (compute_motion, Fcompute_motion):
6244 Use int, not EMACS_INT, when it is wide enough.
6245 (vmotion): Omit local var start_hpos that is always 0; that way
6246 we don't need to worry about overflow in expressions involving it.
6247 * indent.h: Adjust decls to match defn changes elsewhere.
6248 (struct position):
6249 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6250 Use int, not EMACS_INT, where int is wide enough.
6251 Remove unused members ovstring_chars_done and tab_offset;
6252 all uses removed.
6253 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
6254 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
6255 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
6256 (make_gap, copy_text, insert, insert_and_inherit)
6257 (insert_before_markers, insert_before_markers_and_inherit)
6258 (insert_1, count_combining_before, count_combining_after)
6259 (insert_1_both, insert_from_string)
6260 (insert_from_string_before_markers, insert_from_string_1)
6261 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
6262 (adjust_after_replace, adjust_after_insert, replace_range)
6263 (replace_range_2, del_range, del_range_1, del_range_byte)
6264 (del_range_both, del_range_2, modify_region)
6265 (prepare_to_modify_buffer, signal_before_change)
6266 (signal_after_change, Fcombine_after_change_execute):
6267 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6268 * intervals.c (traverse_intervals, rotate_right, rotate_left)
6269 (balance_an_interval, split_interval_right, split_interval_left)
6270 (find_interval, next_interval, update_interval)
6271 (adjust_intervals_for_insertion, delete_node, delete_interval)
6272 (interval_deletion_adjustment, adjust_intervals_for_deletion)
6273 (static_offset_intervals, offset_intervals)
6274 (merge_interval_right, merge_interval_left, make_new_interval)
6275 (graft_intervals_into_buffer, temp_set_point_both)
6276 (temp_set_point, set_point, adjust_for_invis_intang)
6277 (set_point_both, move_if_not_intangible, get_property_and_range)
6278 (get_local_map, copy_intervals, copy_intervals_to_string)
6279 (compare_string_intervals, set_intervals_multibyte_1):
6280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6281 * intervals.h: Adjust decls to match defn changes elsewhere.
6282 (struct interval):
6283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6284 * keyboard.c (this_command_key_count, this_single_command_key_start)
6285 (before_command_key_count, before_command_echo_length, echo_now)
6286 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
6287 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
6288 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
6289 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
6290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6291 (last_non_minibuf_size, last_point_position, echo_truncate)
6292 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
6293 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
6294 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
6295 (stuff_buffered_input):
6296 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6297 (last_auto_save, command_loop_1, read_char):
6298 Use EMACS_INT, not int, to avoid integer overflow.
6299 (record_char): Avoid overflow in total_keys computation.
6300 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
6301 * keyboard.h: Adjust decls to match defn changes elsewhere.
6302 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
6303 (Fkey_description, Fdescribe_vector, Flookup_key):
6304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6305 (click_position): New function, to check that positions are in range.
6306 (Fcurrent_active_maps):
6307 (describe_command):
6308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6309 (Faccessible_keymaps, Fkey_description):
6310 (preferred_sequence_p):
6311 Don't assume fixnum can fit into int.
6312 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
6313 Check for integer overflow in size calculations.
6314 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
6315 avoid mishandling large integers.
6316 * lisp.h: Adjust decls to match defn changes elsewhere.
6317 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
6318 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
6319 (struct Lisp_Marker):
6320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6321 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
6322 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
6323 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
6324 All callers changed.
6325 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
6326 Assume the arg has valid form, since it always does.
6327 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
6328 unsigned integer system type.
6329 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
6330 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
6331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6332 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
6333 (duration_to_sec_usec): New decl.
6334 * lread.c (read_from_string_index, read_from_string_index_byte)
6335 (read_from_string_limit, readchar, unreadchar, openp)
6336 (read_internal_start, read1, oblookup):
6337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6338 (Fload, readevalloop, Feval_buffer, Feval_region):
6339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6340 (openp): Check for out-of-range argument to 'access'.
6341 (read1): Use int, not EMACS_INT, where int is wide enough.
6342 Don't assume fixnum fits into int.
6efdadfd 6343 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
6344 (read_filtered_event): Use duration_to_sec_usec
6345 to do proper overflow checking on durations.
d311d28c
PE
6346 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
6347 in size calculation.
6348 (Fexecute_kbd_macro):
6349 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6350 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
6351 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
6352 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
6353 (set_marker_both, set_marker_restricted_both, marker_position)
6354 (marker_byte_position, Fbuffer_has_markers_at):
6355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6356 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 6357 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
6358 It now merely ensures that the menu is large enough, without
6359 necessarily growing it, as this avoids some integer overflow issues.
6360 All callers changed.
6361 (keymap_panes, parse_single_submenu, Fx_popup_menu):
6362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6363 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
6364 Use SAFE_ALLOCA_LISP, not alloca.
6365 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
6366 to EMACS_INT. Check that fixnums are in proper range for system types.
6367 * minibuf.c (minibuf_prompt_width, string_to_object)
6368 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
6369 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
6370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6371 (get_minibuffer, read_minibuf_unwind):
6372 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6373 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
6374 this simplifies overflow checking. All callers changed.
6375 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
6376 (Ftest_completion):
6377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6378 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
6379 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
6380 Check that fixnums are in proper range for system types.
6381 (Fx_create_frame, Fx_show_tip):
6382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6383 * nsfont.m (ns_findfonts, nsfont_list_family):
6384 Don't assume fixnum fits in long.
6385 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
6386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6387 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
6388 wide enough.
17fdb222 6389 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
6390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6391 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
6392 (PRINTDECLARE, PRINTPREPARE):
6393 (strout, print_string):
6394 (print, print_preprocess, print_check_string_charset_prop)
6395 (print_object):
6396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6397 (PRINTDECLARE):
6398 (temp_output_buffer_setup, Fprin1_to_string, print_object):
6399 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6400 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 6401 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 6402 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
6403 (print_error_message): Use SAFE_ALLOCA, not alloca.
6404 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
6405 (print_depth, new_backquote_output, print_number_index):
6406 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
6407 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
6408 (Fset_process_window_size, Fformat_network_address)
6409 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 6410 (sigchld_handler):
d311d28c 6411 Check that fixnums are in proper range for system types.
d44287d4 6412 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
6413 Check for process-ids out of pid_t range rather than relying on
6414 undefined behavior.
e4d81efc 6415 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
6416 (Fformat_network_address, read_process_output, send_process)
6417 (Fprocess_send_region, status_notify):
6418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6419 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
6420 (wait_reading_process_output, read_process_output, exec_sentinel):
6421 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6422 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
6423 (Faccept_process_output): Use duration_to_sec_usec to do proper
6424 overflow checking on durations.
dde14581
PE
6425 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
6426 Don't assume pid_t fits in int.
02481186
PE
6427 * process.h (struct Lisp_Process): Members tick and update_tick
6428 are now of type EMACS_INT, not int.
b62b53e8
PE
6429 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
6430 configured --with-wide-int.
d311d28c
PE
6431 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
6432 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
6433 * search.c (looking_at_1, string_match_1):
6434 (fast_string_match, fast_c_string_match_ignore_case)
6435 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
6436 (scan_newline, find_before_next_newline, search_command)
6437 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
6438 (set_search_regs, wordify):
6439 (Freplace_match):
6440 (Fmatch_data):
6441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6442 (string_match_1, search_buffer, set_search_regs):
6443 (Fmatch_data):
6444 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6445 (wordify): Check for overflow in size calculation.
6446 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
6447 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
6448 Check that fixnums are in proper range for system types.
6449 * sound.c (struct sound_device)
6450 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
6451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6452 (Fplay_sound_internal):
6453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 6454 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
6455 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
6456 (Fparse_partial_sexp):
6457 Don't assume fixnums can fit in int.
6458 (struct lisp_parse_state, find_start_pos, find_start_value)
6459 (find_start_value_byte, find_start_begv)
6460 (update_syntax_table, char_quoted, dec_bytepos)
6461 (find_defun_start, prev_char_comend_first, back_comment):
6462 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
6463 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
6464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6465 (Finternal_describe_syntax_value): Check that match_lisp is a
6466 character, not an integer, since the code stuffs it into int.
6467 (scan_words, scan_sexps_forward):
6468 Check that fixnums are in proper range for system types.
6469 (Fforward_word):
6470 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6471 (scan_sexps_forward):
6472 Use CHARACTERP, not INTEGERP, since the value must fit into int.
6473 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
6474 * syntax.h: Adjust decls to match defn changes elsewhere.
6475 (struct gl_state_s):
6476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
6477 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
6478 MOST_POSITIVE_FIXNUM.
d311d28c
PE
6479 * sysdep.c (wait_for_termination_1, wait_for_termination)
6480 (interruptible_wait_for_termination, mkdir):
6481 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
6482 (emacs_read, emacs_write):
6483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
6484 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
6485 and double all fit in int.
d311d28c
PE
6486 * term.c (set_tty_color_mode):
6487 Check that fixnums are in proper range for system types.
6488 * termhooks.h (struct input_event):
6489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6490 * textprop.c (validate_interval_range, interval_of)
6491 (Fadd_text_properties, set_text_properties_1)
6492 (Fremove_text_properties, Fremove_list_of_text_properties)
6493 (Ftext_property_any, Ftext_property_not_all)
6494 (copy_text_properties, text_property_list, extend_property_ranges)
6495 (verify_interval_modification):
6496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6497 (Fnext_single_char_property_change)
6498 (Fprevious_single_char_property_change):
6499 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
6500 (copy_text_properties):
6501 Check for integer overflow in index calculation.
d311d28c
PE
6502 * undo.c (last_boundary_position, record_point, record_insert)
6503 (record_delete, record_marker_adjustment, record_change)
6504 (record_property_change):
6505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6506 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
6507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6508 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6509 (Fx_hide_tip, Fx_file_dialog):
6510 * w32menu.c (set_frame_menubar):
6511 Use ptrdiff_t, not int, for consistency with rest of code.
6512 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
6513 (select_window, Fdelete_other_windows_internal)
6514 (window_scroll_pixel_based, window_scroll_line_based)
6515 (Frecenter, Fset_window_configuration):
6516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6517 (Fset_window_hscroll, run_window_configuration_change_hook)
6518 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 6519 (Fscroll_other_window, Frecenter):
d311d28c
PE
6520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6521 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
6522 Don't assume fixnum fits in int.
6523 (Fset_window_scroll_bars):
6524 Check that fixnums are in proper range for system types.
6525 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
6526 (string_pos, c_string_pos, number_of_chars, init_iterator)
6527 (in_ellipses_for_invisible_text_p, init_from_display_pos)
6528 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
6529 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
6530 (face_before_or_after_it_pos, handle_invisible_prop)
6531 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
6532 (display_prop_intangible_p, string_buffer_position_lim)
6533 (string_buffer_position, handle_composition_prop, load_overlay_strings)
6534 (get_overlay_strings_1, get_overlay_strings)
6535 (iterate_out_of_display_property, forward_to_next_line_start)
6536 (back_to_previous_visible_line_start, reseat, reseat_to_string)
6537 (get_next_display_element, set_iterator_to_next)
6538 (get_visually_first_element, compute_stop_pos_backwards)
6539 (handle_stop_backwards, next_element_from_buffer)
6540 (move_it_in_display_line_to, move_it_in_display_line)
6541 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6542 (add_to_log, message_dolog, message_log_check_duplicate)
6543 (message2, message2_nolog, message3, message3_nolog
6544 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
6545 (current_message_1, truncate_echo_area, truncate_message_1)
6546 (set_message, set_message_1, store_mode_line_noprop)
6547 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
6548 (text_outside_line_unchanged_p, check_point_in_composition)
6549 (reconsider_clip_changes)
6550 (redisplay_internal, set_cursor_from_row, try_scrolling)
6551 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
6552 (redisplay_window, find_last_unchanged_at_beg_row)
6553 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
6554 (trailing_whitespace_p, find_row_edges, display_line)
6555 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
6556 (display_mode_element, store_mode_line_string)
6557 (pint2str, pint2hrstr, decode_mode_spec)
6558 (display_count_lines, display_string, draw_glyphs)
6559 (x_produce_glyphs, x_insert_glyphs)
6560 (rows_from_pos_range, mouse_face_from_buffer_pos)
6561 (fast_find_string_pos, mouse_face_from_string_pos)
6562 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6564 (safe_call, init_from_display_pos, handle_fontified_prop)
6565 (handle_single_display_spec, load_overlay_strings)
6566 (with_echo_area_buffer, setup_echo_area_for_printing)
6567 (display_echo_area, echo_area_display)
6568 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
6569 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
6570 (redisplay_window, dump_glyph_row, display_mode_line)
6571 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 6572 (handle_display_spec, display_prop_string_p):
d311d28c
PE
6573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6574 (handle_single_display_spec, build_desired_tool_bar_string)
6575 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
6576 (get_specified_cursor_type):
6577 Check that fixnums are in proper range for system types.
6578 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
6579 (Flookup_image_map):
6580 Don't assume fixnums fit in int.
6581 (compare_overlay_entries):
6582 Avoid mishandling comparisons due to subtraction overflow.
6583 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
6584 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
6585 (handle_tool_bar_click):
6586 Use int, not unsigned, since we prefer signed and the signedness
6587 doesn't matter here.
6588 (get_next_display_element, next_element_from_display_vector):
6589 Use int, not EMACS_INT, when int is wide enough.
6590 (start_hourglass): Use duration_to_sec_usec to do proper
6591 overflow checking on durations.
6592 * xfaces.c (Fbitmap_spec_p):
6593 Check that fixnums are in proper range for system types.
6594 (compare_fonts_by_sort_order):
6595 Avoid mishandling comparisons due to subtraction overflow.
6596 (Fx_family_fonts, realize_basic_faces):
6597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6598 (Fx_family_fonts):
6599 Don't assume fixnum fits in int.
6600 Use SAFE_ALLOCA_LISP, not alloca.
6601 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
6602 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
6603 (face_at_buffer_position, face_for_overlay_string)
6604 (face_at_string_position):
6605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6606 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
6607 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
6608 (Fx_show_tip):
6609 Check that fixnums are in proper range for system types.
6610 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6611 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
6612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6613 (Fx_change_window_property): Don't assume fixnums fit in int.
6614 * xfont.c (xfont_chars_supported):
6615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6616 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
6617 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
6618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6619 * xml.c (parse_region):
6620 * xrdb.c (magic_file_p):
6621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6622 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
6623 (x_get_local_selection, x_reply_selection_request)
6624 (x_handle_selection_request, wait_for_property_change):
6625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6626 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
6627 short is wide enough.
6628 (x_send_client_event): Don't assume fixnum fits in int.
6629 * xterm.c (x_x_to_emacs_modifiers):
6630 Don't assume EMACS_INT overflows nicely into int.
6631 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
6632 may come from Lisp.
6633 (handle_one_xevent): NATNUMP can eval its arg twice.
6634 (x_connection_closed):
6635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6636 * xterm.h: Adjust decls to match defn changes elsewhere.
6637 (struct scroll_bar): Use struct vectorlike_header
6638 rather than rolling our own approximation.
6639 (SCROLL_BAR_VEC_SIZE): Remove; not used.
6640
c6574eb5
GM
66412012-05-25 Glenn Morris <rgm@gnu.org>
6642
6643 * lisp.mk (lisp): Update for more files being compiled now.
6644
e8d32c7e
SM
66452012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
6646
48def666
SM
6647 * lread.c: Remove `read_pure' which makes no difference.
6648 (read_pure): Remove var.
6649 (unreadpure): Remove function.
6650 (readevalloop): Don't call read_list with -1 flag.
6651 (read1, read_vector): Don't test read_pure any more.
6652 (read_list): Simplify.
6653
e8d32c7e
SM
6654 * fileio.c, character.h: Minor style tweaks.
6655
4b2addb7
DA
66562012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
6657
6658 * window.h (clip_changed): Remove useless declaration.
6659
584461b2
JB
66602012-05-22 Juanma Barranquero <lekktu@gmail.com>
6661
6662 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
6663 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
6664
34374650
PE
66652012-05-22 Paul Eggert <eggert@cs.ucla.edu>
6666
6667 Remove src/m/*.
6668 This directory predates autoconf and is no longer needed nowadays.
6669 Move its few remaining bits of functionality to where they're needed.
6670 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
6671 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
6672 * m/template.h: Remove.
6673 * Makefile.in (M_FILE): Remove. All uses removed.
6674 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
6675 * lisp.h (USE_LSB_TAG):
6676 * mem-limits.h (EXCEEDS_LISP_PTR):
6677 Use VAL_MAX, not VALBITS, in #if.
6678 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
6679 (EMACS_UINT): Define unconditionally now.
6680 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
6681 (BITS_PER_EMACS_INT): New constants, replacing
6682 what used to be in config.h, but not useful in #if.
6683 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
6684 define them any more.
6685 (VAL_MAX): New macro.
6686 (VALMASK): Use it.
6687 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
6688 BITS_PER_EMACS_INT, in #if.
6689 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
6690 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
6691 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
6692 * s/ms-w32.h (DATA_START):
6693 Move here from removed file m/intel386.h.
6694 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
6695 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
6696
261cb4bb
PE
66972012-05-21 Paul Eggert <eggert@cs.ucla.edu>
6698
6699 Assume C89 or later.
6700 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
6701 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
6702 (xrealloc):
6703 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
6704 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
6705 * textprop.c, tparam.c (NULL): Remove.
6706 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
6707 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
6708 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
6709 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
6710 * xterm.c (input_signal_count): Assume volatile works.
6711
ff23cd9f
KB
67122012-05-21 Ken Brown <kbrown@cornell.edu>
6713
6714 * xgselect.c (xg_select): Fix first argument in call to 'select'
6715 (bug#11508).
6716
1b170bc6
KB
67172012-05-20 Ken Brown <kbrown@cornell.edu>
6718
6719 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 6720 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 6721
b2f4d39f
KB
67222012-05-19 Ken Brown <kbrown@cornell.edu>
6723
6724 * xfns.c (x_in_use): Remove `static' qualifier.
6725 * xterm.h (x_in_use): Declare.
6726 * xgselect.c: Include xterm.h.
6727 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
6728 and `display_arg' (bug#9754).
6729
003fdae2
PE
67302012-05-19 Paul Eggert <eggert@cs.ucla.edu>
6731
9232a6d9
PE
6732 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
6733
003fdae2
PE
6734 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
6735 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
6736
784b56e2
EZ
67372012-05-18 Eli Zaretskii <eliz@gnu.org>
6738
6739 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
6740
6741 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 6742 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
6743
6744 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
6745 reference to image_cache->refcount.
6746 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
6747
a0a79cde
JL
67482012-05-17 Juri Linkov <juri@jurta.org>
6749
6750 * search.c (Fword_search_regexp, Fword_search_backward)
6751 (Fword_search_forward, Fword_search_backward_lax)
6752 (Fword_search_forward_lax): Move functions to isearch.el
6753 (bug#10145, bug#11381).
6754
b0572523
PE
67552012-05-16 Paul Eggert <eggert@cs.ucla.edu>
6756
6757 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
6758
9660f5fc
SM
67592012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
6760
6761 * lread.c (init_obarray): Declare Qt and Qnil as special.
6762
4374de83
GM
67632012-05-14 Glenn Morris <rgm@gnu.org>
6764
6765 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 6766 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 6767
dc44c39a
PE
67682012-05-14 Paul Eggert <eggert@cs.ucla.edu>
6769
078c97cb
PE
6770 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
6771
dc44c39a
PE
6772 * unexaix.c: Port to more-recent AIX compilers.
6773 (report_error, report_error_1, make_hdr, copy_sym)
6774 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
6775 Make arguments const char *, not char *, to avoid violations of C
6776 standard and to fix some AIX warnings reported by Gilles Pion.
6777
e18afed7 67782012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
6779
6780 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
6781 already have overlays loaded.
6782 (handle_single_display_spec): Before returning without displaying
6783 fringe bitmap, synchronize the bidi iterator with the main display
6784 iterator, by calling iterate_out_of_display_property.
6785 (iterate_out_of_display_property): Detect buffer iteration by
6786 testing that it->string is a Lisp string.
6787 (get_next_display_element): When the current object is exhausted,
6788 and there's something on it->stack, call set_iterator_to_next to
6789 proceed with what's on the stack, instead of returning zero.
6790 (set_iterator_to_next): If called at the end of a Lisp string,
6791 proceed to consider_string_end without incrementing string
6792 position. Don't increment display vector index past the end of
6793 the display vector. (Bug#11417)
c8fb9dc6
EZ
6794 (pos_visible_p): Don't report a position visible when move_it_to
6795 stopped at the last line of window, which happens to be scanned
6796 backwards by the bidi iteration. (Bug#11464)
ac268e67 6797
e18afed7 67982012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
6799
6800 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
6801 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
6802 are on a TTY, and thus unable to display on the fringes.
6803 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
6804 so we need to signal to the caller that this is a "replacing"
6805 display spec. This fixes display when the spec is invalid or we
6806 are on a TTY.
6807
e18afed7 68082012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
6809
6810 * unexaix.c (make_hdr): Fix typo in prototype.
6811 This bug broke the build on AIX. Problem reported by Gilles Pion.
6812
9d0a235a
MA
68132012-05-14 Michael Albinus <michael.albinus@gmx.de>
6814
6815 * keyboard.c (kbd_buffer_get_event): Read special events also in
6816 batch mode. (Bug#11415)
6817
9e6b06ed
GM
68182012-05-12 Glenn Morris <rgm@gnu.org>
6819
6820 * ns.mk: Update for ns_appbindir no longer having trailing "/".
6821
c1a1d7a3
EZ
68222012-05-12 Eli Zaretskii <eliz@gnu.org>
6823
6824 * lisp.mk (lisp): Add newcomment.elc.
6825
3fe7cdc8
GM
68262012-05-12 Glenn Morris <rgm@gnu.org>
6827
6828 * Makefile.in (MKDIR_P): New, set by configure.
6829 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
6830
53f7d2c0
PE
68312012-05-11 Paul Eggert <eggert@cs.ucla.edu>
6832
6833 Remove unused function hourglass_started.
6834 * dispextern.h (hourglass_started):
6835 * w32fns.c (hourglass_started):
6836 * xdisp.c (hourglass_started): Remove.
6837
75aafb17
JB
68382012-05-10 Juanma Barranquero <lekktu@gmail.com>
6839
6840 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
6841 Update dependencies.
6842
12959e8e
PE
68432012-05-10 Paul Eggert <eggert@cs.ucla.edu>
6844
97107e2e
PE
6845 * xgselect.c (xg_select): Put maxfds+1 into a var.
6846 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
6847
12959e8e
PE
6848 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
6849
836d29b3
DA
68502012-05-10 Dave Abrahams <dave@boostpro.com>
6851
6852 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
6853 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
6854
5cb67954
MA
68552012-05-09 Michael Albinus <michael.albinus@gmx.de>
6856
6857 * dbusbind.c (xd_registered_buses): New internal Lisp object.
6858 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
6859 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
6860 Initialize xd_registered_buses.
6861
3478ec45
PE
68622012-05-09 Paul Eggert <eggert@cs.ucla.edu>
6863
b263a6b0
PE
6864 Untag more efficiently if USE_LSB_TAG.
6865 This is based on a proposal by YAMAMOTO Mitsuharu in
6866 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
6867 For an admittedly artificial (nth 8000 longlist) benchmark on
6868 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
6869 Emacs's overall text size by 1%.
6870 * lisp.h (XUNTAG): New macro.
6871 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
6872 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
6873 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
6874 * eval.c (Fautoload):
6875 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
6876 * frame.h (XFRAME): Use XUNTAG.
6877
3478ec45
PE
6878 Port recent dbusbind.c changes to 32-bit --with-wide-int.
6879 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
6880 Remove unportable assumptions about print widths of types like
6881 dbus_uint32_t.
6882 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
6883 intptr_t when converting between pointer and integer, to avoid GCC
6884 warnings about wrong width.
6885
666b903b 68862012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
6887
6888 * w32proc.c (new_child): Force Windows to reserve only 64KB of
6889 stack for each reader_thread, instead of defaulting to 8MB
6890 determined by the linker. This avoids failures in creating
6891 subprocesses on Windows 7, see the discussion in this thread:
6892 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
6893
b120cc17
JC
68942012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
6895
6896 Fix up display of the *Minibuf-0* buffer in the mini window.
6897 * keyboard.c (read_char): Don't clear the echo area if there's no
6898 message to clear.
6899 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 6900 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 6901
9a4b36f8
MA
69022012-05-07 Michael Albinus <michael.albinus@gmx.de>
6903
6904 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
6905 batch mode.
6906
e5f9458f
CY
69072012-05-06 Chong Yidong <cyd@gnu.org>
6908
6909 * lisp.mk (lisp): Update.
6910
eceeb5fc 69112012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
6912
6913 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
6914
71873e2b
SM
69152012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
6916
6917 * data.c (PUT_ERROR): New macro.
6918 (syms_of_data): Use it. Add new error type `user-error'.
6919 * undo.c (user_error): New function.
6920 (Fprimitive_undo): Use it.
6921 * print.c (print_error_message): Adjust print style for `user-error'.
6922 * keyboard.c (user_error): New function.
6923 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
6924
ab0fa4e4
PE
69252012-05-03 Paul Eggert <eggert@cs.ucla.edu>
6926
6927 Do not limit current-time-string to years 1000..9999.
6928 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
6929 (Fcurrent_time_string): Support any year that is supported by the
6930 underlying localtime representation. Don't use asctime, as it
6931 has undefined behavior for years outside the range -999..9999.
6932
7ed806a7
PE
69332012-05-02 Paul Eggert <eggert@cs.ucla.edu>
6934
6935 Fix race conditions involving setenv, gmtime, localtime, asctime.
6936 Without this fix, interrupts could mess up code that uses these
6937 nonreentrant functions, since setting TZ invalidates existing
6938 tm_zone or tzname values, and since most of these functions return
6939 pointers to static storage.
6940 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
6941 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
6942 Grow the critical sections to include not just invoking
6943 localtime/gmtime, but also accessing these functions' results
6944 including their tm_zone values if any, and any related TZ setting.
6945 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
6946 so that the struct tm is saved in the critical section.
6947 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
6948 motivated by the fact that memory allocation needs to be outside
6949 the critical section.
6950
0c16dfed
DA
69512012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
6952
6953 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
6954 with RESET_INTERVAL.
6955
6956 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6957 Remove duplicated buffer name initialization.
6958
3f83ace8
JM
69592012-05-02 Jim Meyering <jim@meyering.net>
6960
6961 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
6962
c7b8541e
JM
6963 * xfns.c (x_window): Use xstrdup (Bug#11375).
6964
90207a15 69652012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
6966
6967 * xdisp.c (pos_visible_p): If already at a newline from the
6968 display string before the 'while' loop, don't walk back the glyphs
6969 from it3.glyph_row. Solves assertion violation when the display
6970 string begins with a newline (egg.el). (Bug#11367)
6971
b593d6a9
AH
69722012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
6973
6974 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
6975 Move to simple.el.
6976
4737362e
GM
69772012-05-01 Glenn Morris <rgm@gnu.org>
6978
99cf43f9
GM
6979 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
6980 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
6981 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
6982 All were removed before 23.1.
6983
9311dcff
GM
6984 * dispnew.c: Remove HAVE_LIBNCURSES test;
6985 it is always true on relevant platforms.
6986
4d5c6349
GM
6987 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
6988 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
6989
4737362e
GM
6990 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
6991
74dd3a6b
AS
69922012-04-30 Andreas Schwab <schwab@linux-m68k.org>
6993
6994 * .gdbinit (xpr): Remove checks for no longer existing misc types.
6995 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
6996 Remove.
6997
13c379ee
PE
69982012-04-28 Paul Eggert <eggert@cs.ucla.edu>
6999
7000 Do not avoid creating empty evaporating overlays (Bug#9642).
7001 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
7002 That is, do not delete an evaporating overlay if it becomes
7003 empty after its bounds are adjusted to fit within its buffer.
7004 This fix caused other problems, and I'm reverting it until we get
7005 to the bottom of them.
7006
a8e7d6d7 70072012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
7008
7009 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
7010
a8e7d6d7 70112012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
7012
7013 * xdisp.c (pos_visible_p): If the window start position is beyond
7014 ZV, start the display from buffer beginning. Prevents assertion
7015 violation in init_iterator when the minibuffer window is scrolled
7016 via the scroll bar.
7017
7018 * window.c (window_scroll_pixel_based): Likewise.
7019
a8e7d6d7 70202012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
7021
7022 * keymap.c (where_is_internal): Doc fix (Bug#10872).
7023
a8e7d6d7 70242012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
7025
7026 * fileio.c (Fcopy_file, Fset_file_selinux_context):
7027 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
7028
a8e7d6d7 70292012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 7030
b593d6a9
AH
7031 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
7032 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 7033
1c6900d9
EZ
70342012-04-26 Eli Zaretskii <eliz@gnu.org>
7035
4c3fa1d9
EZ
7036 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
7037 display element, check also the underlying string or buffer
7038 character. (Bug#11341)
7039
1c6900d9
EZ
7040 * w32menu.c: Include w32heap.h.
7041 (add_menu_item): If the call to AppendMenuW (via
7042 unicode_append_menu) fails, disable Unicode menus only if we are
7043 running on Windows 9X/Me.
7044
42bf8205
AS
70452012-04-24 Andreas Schwab <schwab@linux-m68k.org>
7046
7047 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
7048 (xgetint): Add missing shift for LSB tags.
7049
b1bac16e
MR
70502012-04-24 Martin Rudalics <rudalics@gmx.at>
7051
7052 * keyboard.c (read_char): Don't wipe echo area for select window
7053 events: These might get delayed via `mouse-autoselect-window'
7054 (Bug#11304).
7055
d69621cc
JB
70562012-04-24 Juanma Barranquero <lekktu@gmail.com>
7057
7058 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
7059 manipulation of :loaded-from data.
7060
02fd101b
JB
70612012-04-23 Juanma Barranquero <lekktu@gmail.com>
7062
7063 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
7064 now a cons (bug#11311).
7065
888bec30
PE
70662012-04-23 Paul Eggert <eggert@cs.ucla.edu>
7067
89a438bd
PE
7068 Do not create empty overlays with the evaporate property (Bug#9642).
7069 * buffer.c (Fmove_overlay): Delete an evaporating overlay
7070 if it becomes empty after its bounds are adjusted to fit within
7071 its buffer. Without this fix, in a nonempty buffer (let ((o
7072 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
7073 yields an empty overlay that has the evaporate property, which is
7074 not supposed to happen.
7075
1068fe4d
PE
7076 Fix minor GTK3 problems found by static checking.
7077 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7078 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7079 (struct _EmacsFixedClass, emacs_fixed_get_type):
7080 Move decls here from emacsgtkfixed.h, since they needn't be public.
7081 (emacs_fixed_get_type): Now static.
7082 (emacs_fixed_class_init): Omit unused local.
7083 (emacs_fixed_child_type): Remove; unused.
7084 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7085 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7086 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
7087 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
7088 (EMACS_FIXED_GET_CLASS): Remove; unused.
7089 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
7090
888bec30
PE
7091 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
7092 Problem reported by Juanma Barranquero for Windows -Wunused-function.
7093
de85e130
PE
70942012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7095
d0baac98 7096 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 7097 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
7098 (__malloc_size_t, __malloc_ptrdiff_t):
7099 Remove. All uses removed, replaced by the definiens if needed,
7100 since we can assume C89 or better now.
7101 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
7102 (protect_malloc_state, align, get_contiguous_space)
7103 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
7104 (malloc_atfork_handler_child, malloc_enable_thread)
7105 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
7106 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
7107 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
7108 (special_realloc, _realloc_internal_nolock, _realloc_internal)
7109 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
7110 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
7111 Define using prototypes, not old style.
7112 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
7113 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
7114 (align): Don't assume that signed integer overflow wraps around.
7115 Omit unused local var.
7116 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
7117 (_free_internal_nolock, memalign, mallochook, reallochook):
7118 Omit no-longer-needed casts.
7119 (valloc): Use getpagesize, not __getpagesize.
7120 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
7121 (struct hdr): The 'magic' member is now size_t, not unsigned long.
7122
de85e130
PE
7123 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
7124
dcbf5805
MA
71252012-04-22 Michael Albinus <michael.albinus@gmx.de>
7126
7127 Move functions from C to Lisp. Make non-blocking method calls
7128 the default. Implement further D-Bus standard interfaces.
7129
7130 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
7131 (QCdbus_request_name_allow_replacement)
7132 (QCdbus_request_name_replace_existing)
7133 (QCdbus_request_name_do_not_queue)
7134 (QCdbus_request_name_reply_primary_owner)
7135 (QCdbus_request_name_reply_in_queue)
7136 (QCdbus_request_name_reply_exists)
7137 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
7138 (QCdbus_registered_serial, QCdbus_registered_method)
7139 (QCdbus_registered_signal): New Lisp objects.
7140 (XD_DEBUG_MESSAGE): Use sizeof.
7141 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
7142 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
7143 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
7144 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
7145 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
7146 (xd_signature, xd_append_arg): Allow float for integer types.
7147 (xd_get_connection_references): New function.
b593d6a9
AH
7148 (xd_get_connection_address): Rename from xd_initialize.
7149 Return cached address.
dcbf5805
MA
7150 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
7151 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
7152 level.
7153 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 7154 Return number of refcounts.
dcbf5805
MA
7155 (Fdbus_get_unique_name): Make stronger parameter check.
7156 (Fdbus_message_internal): New defun.
7157 (Fdbus_call_method, Fdbus_call_method_asynchronously)
7158 (Fdbus_method_return_internal, Fdbus_method_error_internal)
7159 (Fdbus_send_signal, Fdbus_register_service)
7160 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
7161 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
7162 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
7163 (Vdbus_compiled_version, Vdbus_runtime_version)
7164 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
7165 (Vdbus_message_type_method_return, Vdbus_message_type_error)
7166 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
7167 (Vdbus_registered_buses, Vdbus_registered_objects_table):
7168 Adapt docstring.
dcbf5805 7169
52828e02
PE
71702012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7171
da05bc4c
PE
7172 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
7173 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
7174 Do not assume ptrdiff_t is the same width as 'int'.
7175
52828e02
PE
7176 * alloc.c: Handle unusual debugging option combinations.
7177 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
7178 since the two debugging options are incompatible.
7179 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
7180 is defined.
7181 (mem_init, mem_insert, mem_insert_fixup):
7182 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
7183 (NEED_MEM_INSERT): Remove; no longer needed.
7184
f01769f9
LL
71852012-04-22 Leo Liu <sdl.web@gmail.com>
7186
7187 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
7188
5790543d
PE
71892012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7190
7191 * sysdep.c [__FreeBSD__]: Minor cleanups.
7192 (list_system_processes, system_process_attributes) [__FreeBSD__]:
7193 Use Emacs indenting style more consistently. Avoid some casts.
7194 Use 'double' consistently rather than mixing 'float' and 'double'.
7195
b91b7e4d
EW
71962012-04-21 Eduard Wiebe <usenet@pusto.de>
7197
b593d6a9
AH
7198 * sysdep.c (list_system_processes, system_process_attributes):
7199 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 7200
6114eb15
AS
72012012-04-21 Andreas Schwab <schwab@linux-m68k.org>
7202
7203 * lisp.mk (lisp): Update.
7204
2f38dff7
PE
72052012-04-20 Paul Eggert <eggert@cs.ucla.edu>
7206
7207 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
7208 It is never used otherwise.
7209
4ae29f89
SM
72102012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
7211
7212 * print.c (print_preprocess): Only check print_depth if print-circle
7213 is nil.
7214 (print_object): Check for cycles even when print-circle is nil and
7215 print-gensym is t, but only check print_depth if print-circle is nil.
7216
f30d612a
CY
72172012-04-20 Chong Yidong <cyd@gnu.org>
7218
7219 * process.c (wait_reading_process_output): If EIO occurs on a pty,
7220 set the status to "failed" and ensure that sentinel is run.
7221
c07a4c0b 72222012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
7223
7224 * process.c (Fset_process_inherit_coding_system_flag)
7225 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 7226 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 7227
c07a4c0b 72282012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
7229
7230 * xdisp.c (string_buffer_position_lim): Limit starting position to
7231 BEGV.
7232 (set_cursor_from_row): If called for a mode-line or header-line
7233 row, return zero immediately.
7234 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
7235 farther than the first row after the header line, if any.
7236 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
7237 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
7238
c07a4c0b 72392012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 7240
4ae29f89
SM
7241 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
7242 (bug#11238).
ad3a2b41 7243
c07a4c0b 72442012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 72452012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
7246
7247 configure: new option --enable-gcc-warnings (Bug#11207)
7248 * Makefile.in (C_WARNINGS_SWITCH): Remove.
7249 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
7250 (ALL_CFLAGS): Use new macros rather than old.
7251 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
7252 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
7253 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
7254 -Wunused-result, -Wunused-variable. This should go away once
7255 the Emacs and Gnulib regex code is merged.
7256 (xmalloc, xrealloc): Now static.
7257
aba027e8
PE
72582012-04-17 Paul Eggert <eggert@cs.ucla.edu>
7259
7260 * dired.c (Fsystem_groups): Remove unused local.
7261
e5a36063
GM
72622012-04-17 Glenn Morris <rgm@gnu.org>
7263
7264 * dired.c (Fsystem_users): Doc fix.
7265
316411f0
DA
72662012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
7267
7268 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
7269 (syms_of_dired): Add them.
7270
9426aba4
PE
72712012-04-16 Paul Eggert <eggert@cs.ucla.edu>
7272
b62a57be
PE
7273 Fix minor alloc.c problems found by static checking.
7274 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
7275 New extern decls, to avoid calling undeclared functions.
7276 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
7277 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
7278 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
7279 (NEED_MEM_INSERT): New macro.
7280 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 7281 Remove one incorrect comment and fix another.
b62a57be 7282
3539f31f
PE
7283 Fix minor ralloc.c problems found by static checking.
7284 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
7285 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
7286 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
7287 (r_alloc_sbrk): Now static.
7288
a041960a
PE
7289 Improve ralloc.c interface checking.
7290 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
7291 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
7292 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
7293 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
7294 [REL_ALLOC]: ... to here, to check interface.
7295 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
7296 Remove decls. This fixes an "It stinks!".
7297
9426aba4
PE
7298 * alloc.c (which_symbols): Fix alignment issue / type clash.
7299
d55c12ed
AS
73002012-04-15 Andreas Schwab <schwab@linux-m68k.org>
7301
7302 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
7303 (struct Lisp_Misc_Any): Likewise.
7304 (struct Lisp_Free): Likewise.
7305 * alloc.c (union aligned_Lisp_Symbol): Define.
7306 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
7307 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
7308 (union aligned_Lisp_Misc): Define.
7309 (MARKER_BLOCK_SIZE, struct marker_block): Use union
7310 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 7311 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 7312
b948ce8b
PE
73132012-04-14 Paul Eggert <eggert@cs.ucla.edu>
7314
7315 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
7316 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
7317 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
7318 * s/netbsd.h, s/sol2-6.h:
7319 Remove definition of GC_MARK_STACK, since the default now works.
7320 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
7321 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
7322 no longer the default.
7323 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
7324
35dc09a1 73252012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 7326
35dc09a1
GM
7327 * lread.c (lisp_file_lexically_bound_p):
7328 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 7329
35dc09a1
GM
73302012-04-14 Eli Zaretskii <eliz@gnu.org>
7331
7332 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
7333 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
7334
73352012-04-14 Jan Djärv <jan.h.d@swipnet.se>
7336
7337 * nsterm.m (constrainFrameRect): Always constrain when there is only
7338 one screen (Bug#10962).
7339
bcd86815
KB
73402012-04-13 Ken Brown <kbrown@cornell.edu>
7341
7342 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
7343
c25df26e
RT
73442012-04-13 Reuben Thomas <rrt@sc3d.org>
7345
7346 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
7347
0fc59f1e
DC
73482012-04-11 Daniel Colascione <dancol@dancol.org>
7349
7350 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
7351 against is gone. It's better to use vfork now so that when Cygwin
7352 gains a new, working vfork, we use it automatically (bug#10398).
7353
de8c03dc
SM
73542012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
7355
7356 * window.c (save_window_save): Obey window-point-insertion-type.
7357
2f097256
GM
73582012-04-11 Glenn Morris <rgm@gnu.org>
7359
7360 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
7361
453b951e
SM
73622012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
7363
7364 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
7365
75f1671a 73662012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
7367
7368 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
7369 (force_quit_count): New var.
7370 (handle_interrupt): Use it.
7371
2a8ce227
JB
73722012-04-10 Juanma Barranquero <lekktu@gmail.com>
7373
7374 * w32.c (w32_delayed_load): Record the full path of the library
7375 being loaded (bug#10424).
7376
935396c0
GM
73772012-04-09 Glenn Morris <rgm@gnu.org>
7378
05920a43
GM
7379 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
7380 not just in the obarray, before snarfing them. (Bug#11036)
7381
935396c0
GM
7382 * Makefile.in ($(leimdir)/leim-list.el):
7383 Pass EMACS rather than BUILT_EMACS.
7384
a18ecafa
TZ
73852012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
7386
7387 * process.c (make_process):
7388 * process.h: Add integer `gnutls_handshakes_tried' member to
7389 process struct.
7390
6bbef4e5
JC
7391 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
7392 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
7393
7394 * gnutls.c (gnutls_log_function2i): Convenience log function.
7395 (emacs_gnutls_read): Use new log functions,
7396 `gnutls_handshakes_tried' process member, and
7397 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
7398 attempts per process (connection).
7399
b4d3bc10
CY
74002012-04-09 Chong Yidong <cyd@gnu.org>
7401
7402 * eval.c (Fuser_variable_p, user_variable_p_eh)
7403 (lisp_indirect_variable): Functions deleted.
7404 (Fdefvar): Caller changed.
7405
7406 * callint.c (Finteractive, Fcall_interactively):
7407 * minibuf.c (Fread_variable): Callers changed.
7408
70f4d973
EZ
74092012-04-09 Eli Zaretskii <eliz@gnu.org>
7410
7411 * xdisp.c (set_cursor_from_row): If the display string appears in
7412 the buffer at position that is closer to point than the position
7413 after the display string, display the cursor on the first glyph of
7414 the display string. Fixes cursor display when a 'display' text
7415 property immediately follows invisible text. (Bug#11094)
7416
cb3c2e3e
PE
74172012-04-09 Paul Eggert <eggert@cs.ucla.edu>
7418
7419 composite.c: use 'double' consistently
7420 * composite.c (get_composition_id): Use 'double' consistently
7421 instead of converting 'float' to 'double' and vice versa; this is
7422 easier to understand and avoids a GCC warning.
7423
fd06db5d
GM
74242012-04-09 Glenn Morris <rgm@gnu.org>
7425
50fe702a
GM
7426 * Makefile.in: Generate leim-list with bootstrap-emacs, in
7427 preparation for dumping it with emacs. (Bug#4789)
7428 (leimdir): New variable.
7429 ($(leimdir)/leim-list.el): New rule.
7430 (emacs$(EXEEXT)): Depend on leim-list.el.
7431
fd06db5d
GM
7432 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
7433 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
7434 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
7435
55c131ee
AS
74362012-04-08 Andreas Schwab <schwab@linux-m68k.org>
7437
7438 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
7439 proper alignment.
7440
9209588f
JB
74412012-04-07 Juanma Barranquero <lekktu@gmail.com>
7442
7443 * xml.c (init_libxml2_functions) [WINDOWSNT]:
7444 Remove unused local variable.
7445
e3fb2efb
PE
74462012-04-07 Paul Eggert <eggert@cs.ucla.edu>
7447
7448 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
7449 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
7450 (mark_memory): Mark Lisp_Objects only if pointers might hide in
7451 objects, as mark_maybe_pointer will catch them otherwise.
7452 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
7453 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
7454
b5385551
PE
74552012-04-07 Paul Eggert <eggert@cs.ucla.edu>
7456
7457 Fix typo that broke non-Windows builds.
7458 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
7459
9078ead6
EZ
74602012-04-07 Eli Zaretskii <eliz@gnu.org>
7461
7462 Support building on MS-Windows with libxml2.
7463
7464 * makefile.w32-in (OBJ2): Add xml.$(O).
7465 (GLOBAL_SOURCES): Add xml.c.
7466 ($(BLD)/xml.$(O)): New dependency list.
7467
7468 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
7469 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
7470 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
7471 [!WINDOWSNT]: New macros.
7472 (init_libxml2_functions, libxml2_loaded_p): New functions.
7473 (parse_region): Call fn_xmlCheckVersion instead of using the macro
7474 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
7475 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
7476 Calls xmlCleanupParser only if libxml2 was loaded (or statically
7477 linked in).
6bbef4e5
JC
7478 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
7479 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
7480 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
7481
7482 * emacs.c: Don't include libxml/parser.h.
7483 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
7484 xmlCleanupParser directly.
7485
7486 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
7487
3811fdf3
EZ
74882012-04-07 Eli Zaretskii <eliz@gnu.org>
7489
7490 * indent.c (Fvertical_motion): If there is a display string at
7491 point, use it.vpos to compute how many lines to backtrack after
7492 move_it_to point. (Bug#11133)
7493
2f8e16b2
EZ
74942012-04-06 Eli Zaretskii <eliz@gnu.org>
7495
7496 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
7497 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
7498 about subtle differences between FETCH_CHAR* and STRING_CHAR*
7499 macros related to unification of CJK characters. For the details,
7500 see the discussion following the message here:
7501 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
7502
3d439cd1
CY
75032012-04-04 Chong Yidong <cyd@gnu.org>
7504
7505 * keyboard.c (Vdelayed_warnings_list): Doc fix.
7506
8bc53d00
EZ
75072012-04-01 Eli Zaretskii <eliz@gnu.org>
7508
7509 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
7510 instead of alloca. (Bug#11138)
7511
3b0512a3
AS
75122012-04-01 Andreas Schwab <schwab@linux-m68k.org>
7513
7514 * w32menu.c (is_simple_dialog): Properly check lisp types.
7515 (Bug#11141)
7516
8427ddd2
EZ
75172012-03-31 Eli Zaretskii <eliz@gnu.org>
7518
979022ef
EZ
7519 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
7520 position we get to after a call to move_it_to fails the
7521 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
7522 only if we wind up in a string from display property. (Bug#11063)
7523
a6b1c7cc
EZ
7524 * window.c (Fdelete_other_windows_internal): Invalidate the row
7525 and column information about mouse highlight, so that redisplay
7526 restores it after reallocating the glyph matrices. (Bug#7464)
7527
8427ddd2
EZ
7528 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
7529 string comes from a `display' text property, use the buffer
7530 position of that property as if we actually saw that position in
7531 the row's glyphs.
697ba24b
EZ
7532 (move_it_by_lines): Remove the assertion that
7533 "it->current_x == 0 && it->hpos == 0" which can be legitimately
7534 violated when there's a before-string at the beginning of a line.
7535 (Bug#11063)
8427ddd2 7536
65a0a738
EZ
75372012-03-30 Eli Zaretskii <eliz@gnu.org>
7538
7539 * xdisp.c (append_space_for_newline): If the default face was
7540 remapped, use the remapped face for the appended newline.
7541 (extend_face_to_end_of_line): Use the remapped default face for
7542 extending the face to the end of the line.
7543 (display_line): Call extend_face_to_end_of_line when the default
7544 face was remapped. (Bug#11068)
7545
581355cc
EZ
75462012-03-29 Eli Zaretskii <eliz@gnu.org>
7547
7548 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
7549
e8fc049f
SM
75502012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7551
7552 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
7553
4fb9a543
GM
75542012-03-27 Glenn Morris <rgm@gnu.org>
7555
7556 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
7557 Doc fixes.
7558
679910f1
KH
75592012-03-26 Kenichi Handa <handa@m17n.org>
7560
7561 * dispextern.h (struct glyph): Fix previous change. Change the
7562 bit length of glyphless.ch to 25 (Bug#11082).
7563
90d49b7f
CY
75642012-03-26 Chong Yidong <cyd@gnu.org>
7565
7566 * keyboard.c (Vselection_inhibit_update_commands): New variable.
7567 (command_loop_1): Use it; inhibit selection update for
7568 handle-select-window too (Bug#8996).
7569
f514f6f0
FP
75702012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
7571
e8fc049f 7572 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 7573
bf43fa51
KH
75742012-03-25 Kenichi Handa <handa@m17n.org>
7575
7576 * dispextern.h (struct glyph): Change the bit length of
7577 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
7578
8a0c01dd
EZ
75792012-03-24 Eli Zaretskii <eliz@gnu.org>
7580
7581 * s/ms-w32.h (tzname): Include time.h before redirecting to
7582 _tzname. Fixes the MSVC build. (Bug#9960)
7583
7d1c3a76
AS
75842012-03-24 Andreas Schwab <schwab@linux-m68k.org>
7585
8ed79523
AS
7586 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
7587 characters.
7588
7d1c3a76
AS
7589 * xterm.c (XTread_socket): Only modify handling_signal if
7590 !SYNC_INPUT. (Bug#11080)
7591
e99a9b8b
EZ
75922012-03-23 Eli Zaretskii <eliz@gnu.org>
7593
7594 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
7595 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
7596 when fetching a multibyte character consumes more bytes than
7597 CHAR_BYTES returns, due to unification of CJK characters in
7598 string_char. (Bug#11073)
7599
5063c0e1
TN
76002012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
7601
7602 * process.c (wait_reading_process_output): Handle pty disconnect
7603 by refraining from sending oneself a SIGCHLD (bug#10933).
7604
9f851fbd
CY
76052012-03-22 Chong Yidong <cyd@gnu.org>
7606
7607 * dispextern.h (struct it): New member string_from_prefix_prop_p.
7608
5063c0e1 7609 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
7610 Mark string as coming from a prefix property.
7611 (handle_face_prop): Use default face for prefix strings (Bug#4281).
7612 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
7613
fb5b8aca
CY
76142012-03-21 Chong Yidong <cyd@gnu.org>
7615
7616 * xfaces.c (Vface_remapping_alist): Doc fix.
7617
62356a1b
EZ
76182012-03-20 Eli Zaretskii <eliz@gnu.org>
7619
7620 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
7621 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
7622 Doc fixes.
62356a1b 7623
025de85b
CY
76242012-03-20 Chong Yidong <cyd@gnu.org>
7625
7626 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
7627 to reflect default non-nil value of redisplay-dont-pause.
7628
4827f94e
KH
76292012-03-19 Kenichi Handa <handa@m17n.org>
7630
7631 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
7632 it fit in a valid range (Bug#11003).
7633
e50a24a2
EZ
76342012-03-18 Eli Zaretskii <eliz@gnu.org>
7635
7636 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
7637 that is not from display property, accept the row as a "cursor
7638 row" if one of the string's character has a non-nil `cursor'
7639 property. Fixes cursor positioning when there are newlines in
7640 overlay strings, e.g. in icomplete.el. (Bug#11035)
7641
9af5ed87
PE
76422012-03-12 Paul Eggert <eggert@cs.ucla.edu>
7643
7644 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
7645
d1f55f16
CY
76462012-03-12 Chong Yidong <cyd@gnu.org>
7647
7648 * eval.c (inhibit_lisp_code): Rename from
7649 inhibit_window_configuration_change_hook; move from window.c.
7650
7651 * xfns.c (unwind_create_frame_1, Fx_create_frame):
7652 * window.c (run_window_configuration_change_hook)
7653 (syms_of_window): Callers changed.
7654
66c5eebd
CY
76552012-03-11 Chong Yidong <cyd@gnu.org>
7656
413df973
CY
7657 * keymap.c (Fkey_description): Doc fix (Bug#9700).
7658
66c5eebd
CY
7659 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
7660
1de11f56
CY
76612012-03-10 Chong Yidong <cyd@gnu.org>
7662
7663 * frame.c (other_visible_frames): Don't assume the selected frame
7664 is visible (Bug#10955).
7665
cae07000
SM
76662012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
7667
7668 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
7669
89c94350
JD
76702012-03-08 Jan Djärv <jan.h.d@swipnet.se>
7671
7672 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
7673 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
7674 zero (Bug#10954).
7675
999dd333
GM
76762012-03-03 Glenn Morris <rgm@gnu.org>
7677
01a6dcc8 7678 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 7679
de0100f2
EZ
76802012-03-02 Eli Zaretskii <eliz@gnu.org>
7681
7682 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
7683 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
7684 (redisplay_window, next_element_from_string): Fix typos in
7685 comments.
3e441275
EZ
7686 (redisplay_window): Pass to move_it_vertically the margin in
7687 pixels, not in screen lines.
de0100f2 7688
96a72ee9
GM
76892012-03-02 Glenn Morris <rgm@gnu.org>
7690
7691 * buffer.c (buffer-list-update-hook): Doc fix.
7692
312508d7
EZ
76932012-02-29 Eli Zaretskii <eliz@gnu.org>
7694
7695 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
7696 push_it before setting up the iterator for the first overlay
7697 string, even if we have an empty string loaded.
7698 (next_overlay_string): If there's an empty string on the iterator
7699 stack, pop the stack. (Bug#10903)
7700
27f3c637
PE
77012012-02-25 Paul Eggert <eggert@cs.ucla.edu>
7702
7703 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
7704 Suggested by Stefan Monnier in
7705 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
7706 * alloc.c (widen_to_Lisp_Object): New static function.
7707 (mark_memory): Also mark Lisp_Objects by fetching pointer words
7708 and widening them to Lisp_Objects. This would work even if
7709 USE_LSB_TAG is defined and wide integers are used, which might
7710 happen in a future version of Emacs.
7711
3c9dfce6
CY
77122012-02-25 Chong Yidong <cyd@gnu.org>
7713
fa74b241
CY
7714 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
7715 Doc fix.
7716
3c9dfce6
CY
7717 * xselect.c (Fx_selection_exists_p): Doc fix.
7718 (x_clipboard_manager_save_all): Print an informative message
7719 before saving to clipboard manager.
7720
9486df08
CY
77212012-02-24 Chong Yidong <cyd@gnu.org>
7722
7723 * keyboard.c (process_special_events): Handle all X selection
7724 requests in kbd_buffer, not just the next one (Bug#8869).
7725
f01d3321
CY
77262012-02-23 Chong Yidong <cyd@gnu.org>
7727
7728 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
7729 call when setting menu-bar-lines and tool-bar-lines parameters.
7730 (unwind_create_frame_1): New helper function.
7731
7732 * window.c (inhibit_window_configuration_change_hook): New var.
7733 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 7734 (syms_of_window): Initialize it.
f01d3321 7735
86b847b6
CY
77362012-02-22 Chong Yidong <cyd@gnu.org>
7737
7738 * xterm.c (x_draw_image_relief): Add missing type check for
7739 Vtool_bar_button_margin (Bug#10743).
7740
a59225b1
CY
77412012-02-21 Chong Yidong <cyd@gnu.org>
7742
7743 * fileio.c (Vfile_name_handler_alist): Doc fix.
7744
7745 * buffer.c (Fget_file_buffer): Protect against invalid file
7746 handler return value.
7747
310f5bd4
PE
77482012-02-20 Paul Eggert <eggert@cs.ucla.edu>
7749
cb3a28cc
PE
7750 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
7751 when computing $valmask.
7752
310f5bd4
PE
7753 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
7754 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
7755 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
7756 It's useless in that case, and it can cause problems on hosts
7757 that allocate halves of EMACS_INT values separately.
7758 Reported by Dan Horák. Diagnosed by Andreas Schwab in
7759 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
7760 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
7761 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
7762 it avoids undefined behavior on hosts where shifting right by more
7763 than the word width has undefined behavior.
7764
2375c96a
CY
77652012-02-19 Chong Yidong <cyd@gnu.org>
7766
7767 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
7768 (Funhandled_file_name_directory, Ffile_name_as_directory)
7769 (Fdirectory_file_name, Fexpand_file_name)
7770 (Fsubstitute_in_file_name): Protect against invalid file handler
7771 return values (Bug#10845).
7772
3eb49e71
EZ
77732012-02-18 Eli Zaretskii <eliz@gnu.org>
7774
7775 * .gdbinit (pitx): Fix incorrect references to fields of the
7776 iterator stack.
7777
7b926f3f
CY
77782012-02-17 Chong Yidong <cyd@gnu.org>
7779
7780 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
7781
11273115
PE
77822012-02-15 Paul Eggert <eggert@cs.ucla.edu>
7783
7784 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
7785 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
7786
c3a70e2b
CY
77872012-02-15 Chong Yidong <cyd@gnu.org>
7788
7789 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
7790 marked as special. Also, starting docstrings with * is obsolete.
7791
0ca43699
AS
77922012-02-13 Andreas Schwab <schwab@linux-m68k.org>
7793
7794 * gnutls.c (emacs_gnutls_write): Fix last change.
7795
2e8f3c56
LI
77962012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
7797
7798 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
7799 send_process.
7800
af70074f
SM
78012012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
7802
7803 * keymap.c (Fsingle_key_description): Handle char ranges.
7804
95986d52
CY
78052012-02-12 Chong Yidong <cyd@gnu.org>
7806
afd83bd1
CY
7807 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
7808 as that creates a dangerous corner case.
7809
95986d52
CY
7810 * window.c (Fdelete_window_internal): Invalidate the mouse
7811 highlight (Bug#9904).
7812
bd7da63e
GM
78132012-02-12 Glenn Morris <rgm@gnu.org>
7814
7815 * xselect.c (Fx_own_selection_internal)
7816 (Fx_get_selection_internal, Fx_disown_selection_internal)
7817 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
7818 * nsselect.m (Fx_own_selection_internal)
7819 (Fx_disown_selection_internal, Fx_selection_exists_p)
7820 (Fx_selection_owner_p, Fx_get_selection_internal):
7821 Sync docs and argument specs with the xselect.c versions.
7822
77abcbc2
LI
78232012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
7824
7825 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
7826
90b671e2
EZ
78272012-02-11 Eli Zaretskii <eliz@gnu.org>
7828
1c0ca0b7
EZ
7829 * w32select.c (Fx_selection_exists_p): Sync doc string and
7830 argument list with xselect.c. (Bug#10783)
7831
7832 * w16select.c (Fx_selection_exists_p): Sync doc string and
7833 argument list with xselect.c. (Bug#10783)
90b671e2 7834
49241268
GM
78352012-02-10 Glenn Morris <rgm@gnu.org>
7836
7837 * fns.c (Fsecure_hash): Doc fix.
7838
f998bbe7 78392012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
7840
7841 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
7842
0992bd9c
CY
78432012-02-07 Chong Yidong <cyd@gnu.org>
7844
7845 * buffer.c (Fbuffer_local_variables)
7846 (buffer_lisp_local_variables): Handle unbound vars correctly;
7847 don't let Qunbound leak into Lisp.
7848
af008560
GM
78492012-02-07 Glenn Morris <rgm@gnu.org>
7850
dd605cc4
GM
7851 * image.c (Fimagemagick_types): Doc fix.
7852
af008560
GM
7853 * image.c (imagemagick-render-type): Change it from a lisp object
7854 to an integer. Move the doc here from the lisp manual.
7855 Treat all values not equal to 0 the same.
7856
1449fa1d
CY
78572012-02-06 Chong Yidong <cyd@gnu.org>
7858
7859 * doc.c (store_function_docstring): Avoid applying docstring of
7860 alias to base function (Bug#2603).
7861
3723ec07
AS
78622012-02-04 Andreas Schwab <schwab@linux-m68k.org>
7863
7864 * .gdbinit (pp1, pv1): Remove redundant defines.
7865 (pr): Use pp.
7866
79c1cc1e
CY
78672012-02-04 Chong Yidong <cyd@gnu.org>
7868
7869 * nsterm.m: Declare a global (Bug#10694).
7870
d7f29f8e
EZ
78712012-02-04 Eli Zaretskii <eliz@gnu.org>
7872
cae07000
SM
7873 * w32.c (get_emacs_configuration_options):
7874 Include --enable-checking, if specified, in the return value.
d7f29f8e 7875
3b95a6f9
MR
78762012-02-04 Martin Rudalics <rudalics@gmx.at>
7877
7878 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
7879 after rounding frame sizes. (Bug#9723)
7880
d6fa96a6
EZ
78812012-02-04 Eli Zaretskii <eliz@gnu.org>
7882
7883 * keyboard.c (adjust_point_for_property): Don't position point
7884 before BEGV. (Bug#10696)
7885
df0b2940
PE
78862012-02-03 Paul Eggert <eggert@cs.ucla.edu>
7887
7888 Handle overflow when computing char display width (Bug#9496).
7889 * character.c (char_width): Return EMACS_INT, not int.
7890 (char_width, c_string_width): Check for overflow when
7891 computing the width; this is possible now that individual
7892 characters can have unbounded width. Problem introduced
7893 by merge from Emacs 23 on 2012-01-19.
7894
6bee44d6
MA
78952012-02-02 Michael Albinus <michael.albinus@gmx.de>
7896
7897 * dbusbind.c (Fdbus_register_method): Mention the return value
7898 :ignore in the docstring.
7899
44f92739
GM
79002012-02-02 Glenn Morris <rgm@gnu.org>
7901
1b9f60cc
GM
7902 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
7903
44f92739
GM
7904 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7905 Unconditionally set to t. (Bug#10673)
7906 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7907 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
7908 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
7909
c5d3843c
KH
79102012-02-02 Kenichi Handa <handa@m17n.org>
7911
7912 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
7913 0, do not call append_composite_glyph.
7914
159462d4 79152012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
7916
7917 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
7918 NULL (Bug#6988).
7919 (x_produce_glyphs): If the component of a composition is a null
7920 string, set it->pixel_width to 1 to avoid zero-width glyph.
7921
78cef877
EZ
79222012-02-01 Eli Zaretskii <eliz@gnu.org>
7923
7924 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
7925 first 2 arguments are identical. This makes inserting large
7926 output from a subprocess an order of magnitude faster on
7927 MS-Windows, where all sbrk'ed memory is always contiguous.
7928
97897668
GM
79292012-01-31 Glenn Morris <rgm@gnu.org>
7930
7931 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 7932 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
7933 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
7934
31fd3586
GM
79352012-01-29 Glenn Morris <rgm@gnu.org>
7936
7937 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
7938
0e24a8b2
CY
79392012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
7940
7941 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
7942
cc0adcb0
CY
79432012-01-28 Chong Yidong <cyd@gnu.org>
7944
7945 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
7946
acc28cb9
CY
79472012-01-26 Chong Yidong <cyd@gnu.org>
7948
9c69cfb7
CY
7949 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
7950
acc28cb9
CY
7951 * search.c (Fsearch_forward, Fsearch_backward): Document negative
7952 repeat counts (Bug#10507).
7953
48da7392
GM
79542012-01-26 Glenn Morris <rgm@gnu.org>
7955
7956 * lread.c (syms_of_lread): Doc fix.
7957
14af5f7f
CY
79582012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
7959
7960 * coding.c (encode_designation_at_bol): Change return value to
7961 EMACS_INT.
7962
0b21c100
CY
79632012-01-25 Chong Yidong <cyd@gnu.org>
7964
7965 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
7966
3c2907f7
CY
79672012-01-21 Chong Yidong <cyd@gnu.org>
7968
7969 * floatfns.c (Fcopysign): Make the second argument non-optional,
7970 since nil is not allowed anyway.
7971
959ad23f
AS
79722012-01-21 Andreas Schwab <schwab@linux-m68k.org>
7973
7974 * process.c (read_process_output): Use p instead of XPROCESS (proc).
7975 (send_process): Likewise.
7976
34a02f46
MR
79772012-01-19 Martin Rudalics <rudalics@gmx.at>
7978
7979 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
7980 (Vwindow_persistent_parameters): Do not use Qstate.
7981 Rewrite doc-strings.
34a02f46 7982
1259009a 79832012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
7984
7985 * character.c (char_width): New function.
70d4fdf6
GM
7986 (Fchar_width, c_string_width, lisp_string_width):
7987 Use char_width (Bug#9496).
25ed9e61 7988
6a6ee00d
MR
79892012-01-16 Martin Rudalics <rudalics@gmx.at>
7990
7991 * window.c (Vwindow_persistent_parameters): New variable.
7992 (Fset_window_configuration, save_window_save): Handle persistent
7993 window parameters.
7994
c85efaf7
EZ
79952012-01-14 Eli Zaretskii <eliz@gnu.org>
7996
7997 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
7998 thrashing the stack of the thread. (Bug#9087)
7999
5944709e
PE
80002012-01-12 Paul Eggert <eggert@cs.ucla.edu>
8001
8002 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
8003
e71f5d99
EZ
80042012-01-11 Eli Zaretskii <eliz@gnu.org>
8005
8006 * xdisp.c (rows_from_pos_range): Handle the case where the
8007 highlight ends on a newline. (Bug#10464)
8008 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
8009 he end column for display of highlight that ends on a newline
8010 before a R2L line.
8011
ce316182
GM
80122012-01-11 Glenn Morris <rgm@gnu.org>
8013
8014 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
8015 from load-path also when installation-directory is nil. (Bug#10208)
8016
5b43da69
GM
80172012-01-10 Glenn Morris <rgm@gnu.org>
8018
74cc8ff9
GM
8019 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
8020
7d8d6e4e
GM
8021 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
8022 Update template values to be closer to their typical values these days.
5b43da69 8023
a0db8d43
EZ
80242012-01-09 Eli Zaretskii <eliz@gnu.org>
8025
8026 * xdisp.c (rows_from_pos_range): Accept additional argument
8027 DISP_STRING, and accept any glyph in a row whose object is that
8028 string as eligible for mouse highlight. Fixes mouse highlight of
8029 display strings from overlays. (Bug#10464)
8030
9a0115ab 80312012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 8032
b9110d6a 8033 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
8034 * fileio.c (auto_saving_dir_umask): New static var.
8035 (Fmake_directory_internal): Use it.
8036 (do_auto_save_make_dir): Set it, instead of invoking chmod after
8037 creating the directory. The old code temporarily assigns
8038 too-generous permissions to the directory.
8039 (do_auto_save_eh): Clear it.
b9110d6a 8040 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
8041 that the var is always cleared.
8042
6c1bd3f3
EZ
80432012-01-07 Eli Zaretskii <eliz@gnu.org>
8044
8045 * search.c (scan_buffer): Pass character positions to
8046 know_region_cache, not byte positions. (Bug#6540)
8047
069d2b50
L
80482012-01-07 LynX <_LynX@bk.ru> (tiny change)
8049
8050 * w32.c (sys_rename): Report EXDEV when rename of a directory
8051 fails because the target is on another logical disk. (Bug#10284)
8052
75bf0d33
DB
80532012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
8054
8055 * xterm.c (x_embed_request_focus): New function.
8056
8057 * xterm.h: Add prototype.
8058
8059 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
8060
1c6e5a32
GM
80612012-01-05 Glenn Morris <rgm@gnu.org>
8062
8063 * emacs.c (emacs_copyright): Update short copyright year to 2012.
8064
651e947e
EZ
80652012-01-01 Eli Zaretskii <eliz@gnu.org>
8066
8067 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
8068 Load gnutls_transport_set_lowat only if GnuTLS version is below
8069 2.11.1.
8070 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
8071 GnuTLS versions below 2.11.1.
8072
3778cdd8
AL
80732011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
8074
8075 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
8076 to the doc string advising against its use for altering the way
8077 windows are scrolled.
8078
0e5317f7
KH
80792011-12-28 Kenichi Handa <handa@m17n.org>
8080
8081 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
8082 coding-system ASCII compatible only when it does not produce BOM
8083 on encoding (Bug#10383).
8084
93d5ca1f
JD
80852011-12-26 Jan Djärv <jan.h.d@swipnet.se>
8086
8087 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
8088 can scroll.
8089 (create_and_show_popup_menu): Always use menu_position_func for
8090 Gtk3 (Bug#10361).
8091
ca22b785
AS
80922011-12-24 Andreas Schwab <schwab@linux-m68k.org>
8093
8094 * callint.c (Fcall_interactively): Don't truncate prompt string.
8095
d048e1e6
EZ
80962011-12-23 Eli Zaretskii <eliz@gnu.org>
8097
8098 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
8099 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 8100 resumed from there (after widening). (Bug#10360)
d048e1e6 8101
5ccaba1f
JD
81022011-12-22 Jan Djärv <jan.h.d@swipnet.se>
8103
8104 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
8105
204ee57f
JD
81062011-12-21 Jan Djärv <jan.h.d@swipnet.se>
8107
b81d40f0
JB
8108 * nsterm.m (x_free_frame_resources):
8109 Release f->output_data.ns->miniimage.
204ee57f
JD
8110 (ns_index_color): Fix indentation. Do not retain
8111 color_table->colors[i].
8112
8113 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
8114 before returning.
8115
8116 * nsfns.m (x_set_background_color): Assign return value from
8117 ns_index_color to face-background instead of NSColor*.
8118 (ns_implicitly_set_icon_type): Fix indentation.
8119 Change assignment in for loop to comparison.
8120
8121 * emacs.c (ns_pool): New variable.
8122 (main): Assign ns_pool.
8123 (Fkill_emacs): Call ns_release_autorelease_pool.
8124
8125 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
8126 autorelease fdesc, release fdAttrs and tdict.
8127 (ns_get_covering_families): Release charset.
8128 (ns_findfonts): Release NSFontDescriptor created with new.
8129 (ns_uni_to_glyphs): Fix indentation.
8130 (setString): Release attrStr before assigning new value.
8131
c803b2b7
JD
81322011-12-18 Jan Djärv <jan.h.d@swipnet.se>
8133
678f4426
JD
8134 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
8135 and NS_IMPL_COCOA.
8136 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
8137 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
8138
cd394be1 81392011-12-18 David Reitter <reitter@cmu.edu>
678f4426 8140
5fecd5fc
JD
8141 * nsterm.m (ns_term_init): Subscribe for notifications
8142 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
8143 to method trackingNotification in EmacsMenu.
8144
8145 * nsmenu.m (trackingMenu): New variable.
3771cb17 8146 (trackingNotification): New method (from Aquamacs).
5fecd5fc 8147 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 8148 from Aquamacs (Bug#7030).
678f4426
JD
8149
81502011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 8151
c803b2b7
JD
8152 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
8153 (symbol_to_nsstring): Fix indentation.
8154 (ns_symbol_to_pb): New function.
cae07000
SM
8155 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
8156 (Fns_rotate_cut_buffers_internal): Remove.
8157 (Fns_store_selection_internal): Rename from
c803b2b7
JD
8158 Fns_store_cut_buffer_internal.
8159 (ns_get_foreign_selection, Fx_own_selection_internal)
8160 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
8161 (Fns_get_selection_internal, Fns_store_selection_internal):
8162 Use ns_symbol_to_pb and check if return value is nil.
8163 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
8164 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
8165 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
8166 renamed to Sns_store_selection_internal.
8167 (ns_handle_selection_request): Move code to Fx_own_selection_internal
8168 and remove this function.
8169 (ns_handle_selection_clear): Remove, never used.
8170 (Fx_own_selection_internal): Move code from ns_handle_selection_request
8171 here.
8172
e1b01a3a
KB
81732011-12-17 Ken Brown <kbrown@cornell.edu>
8174
8175 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
8176 GID is unknown (Bug#10257).
8177
2adb6e85
PE
81782011-12-17 Paul Eggert <eggert@cs.ucla.edu>
8179
8180 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
8181 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
8182 which caused a build failure on GNU/Linux IA-64. This problem was
8183 introduced by my 2011-10-07 patch.
8184
d1d7b339
JL
81852011-12-15 Juri Linkov <juri@jurta.org>
8186
8187 * image.c (imagemagick_error): New function. (Bug#10112)
8188 (imagemagick_load_image): Comment out `MagickSetResolution' call.
8189 Use `imagemagick_error' where ImageMagick functions return
8190 `MagickFalse'.
8191 (Fimagemagick_types): Add `Fnreverse' to return the list in the
8192 proper order.
8193
100d5755
KH
81942011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8195
8196 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
8197 fill background (Bug#8992).
8198
454592a6
MR
81992011-12-13 Martin Rudalics <rudalics@gmx.at>
8200
8201 * window.c (Vwindow_combination_resize)
8202 (Vwindow_combination_limit): Use t instead of non-nil in
8203 doc-strings.
61d4b438
MR
8204 (Vrecenter_redisplay): Add first sentence of doc-string on
8205 separate line.
53524d93 8206 (Frecenter): Fix doc-string typo.
454592a6 8207
3633e3aa
KH
82082011-12-11 Kenichi Handa <handa@m17n.org>
8209
8210 * coding.c (Funencodable_char_position): Pay attention to the
8211 buffer text relocation (Bug#9389).
8212
7b9d523a 82132011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 8214
7b9d523a
JD
8215 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
8216 gtk_init (Bug#10100).
8217
b73189c6
EZ
82182011-12-10 Eli Zaretskii <eliz@gnu.org>
8219
8220 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
8221 IT->string is nil. (Bug#10263)
8222
f7dfe5d6
JD
82232011-12-10 Jan Djärv <jan.h.d@swipnet.se>
8224
83faebb4
JD
8225 * nsterm.h (x_free_frame_resources): Declare.
8226
f7dfe5d6
JD
8227 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
8228 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
8229
8230 * nsterm.h (ns_get_defaults_value): Declare.
8231
8232 * nsterm.m (ns_default): Call ns_get_defaults_value.
8233
7cd4e72c
EZ
82342011-12-09 Eli Zaretskii <eliz@gnu.org>
8235
8236 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
8237 (Bug#10170)
8238
b34d7317
YM
82392011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8240
8241 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
8242 that where the value of an _OBJC_* symbol points to is in the .bss
8243 section (Bug#10240).
8244
76470ad1
KH
82452011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
8246
8247 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 8248 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 8249
745fff94
KH
82502011-12-08 Kenichi Handa <handa@m17n.org>
8251
8252 * ftfont.c (get_adstyle_property): Fix previous change
8253 (Bug#10233).
8254
6e44397c
JB
82552011-12-07 Juanma Barranquero <lekktu@gmail.com>
8256
8257 * w32.c (init_environment): If no_site_lisp, remove site-lisp
8258 dirs from the default value of EMACSLOADPATH (bug#10208).
8259
7efa6272
GM
82602011-12-07 Glenn Morris <rgm@gnu.org>
8261
8262 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
8263 installation and source directories as well. (Bug#10208)
8264
f6fc4d87
CY
82652011-12-06 Chong Yidong <cyd@gnu.org>
8266
8267 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
8268
2bf26180
GM
82692011-12-06 Glenn Morris <rgm@gnu.org>
8270
8271 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
8272 as an error, not just -1. (Bug#10217)
8273
3a6ad4f0
CY
82742011-12-05 Chong Yidong <cyd@gnu.org>
8275
8276 * keyboard.c (process_special_events): New function.
8277 (swallow_events, Finput_pending_p): Use it (Bug#10195).
8278
75a3b399
PE
82792011-12-05 Paul Eggert <eggert@cs.ucla.edu>
8280
8281 * coding.c (encode_designation_at_bol): Don't use uninitialized
8282 local variable (Bug#9318).
8283
c3c9e25e
KH
82842011-12-05 Kenichi Handa <handa@m17n.org>
8285
8286 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
8287 return Qnil (Bug#8046, Bug#10193).
8288
5eb05ea3
KH
82892011-12-05 Kenichi Handa <handa@m17n.org>
8290
8291 * coding.c (encode_designation_at_bol): New args charbuf_end and
8292 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
8293 (coding_set_source): Return how many bytes coding->source was
8294 relocated.
8295 (coding_set_destination): Return how many bytes
8296 coding->destination was relocated.
8297 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 8298 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
8299
83002011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
8301
8302 * coding.c (CODING_CHAR_CHARSET_P): New macro.
8303 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
8304 macro (Bug#9318).
8305
83062011-12-05 Andreas Schwab <schwab@linux-m68k.org>
8307
8308 The following changes are to fix Bug#9318.
8309
a79703f5 8310 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
8311 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
8312 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 8313 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 8314
7dbda6df
JB
83152011-12-05 Juanma Barranquero <lekktu@gmail.com>
8316
8317 * lisp.h (process_quit_flag): Fix external declaration.
8318
6d5eb5b0
SM
83192011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
8320
8321 Don't macro-inline non-performance-critical code.
8322 * eval.c (process_quit_flag): New function.
8323 * lisp.h (QUIT): Use it.
8324
a0c3fad0
JD
83252011-12-04 Jan Djärv <jan.h.d@swipnet.se>
8326
8327 * nsfns.m (get_geometry_from_preferences): New function.
8328 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
8329
6c07aac2
AS
83302011-12-04 Andreas Schwab <schwab@linux-m68k.org>
8331
8332 * emacs.c (Qkill_emacs): Define.
8333 (syms_of_emacs): Initialize it.
8334 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
8335 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
8336 (quit_throw_to_read_char): Add parameter `from_signal'.
8337 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
8338 * lisp.h (QUIT): Call Fkill_emacs if requested.
8339
c052ead4
JD
83402011-12-03 Jan Djärv <jan.h.d@swipnet.se>
8341
8342 * widget.c (update_wm_hints): Return if wmshell is null.
8343 (widget_update_wm_size_hints): New function.
8344
8345 * widget.h (widget_update_wm_size_hints): Declare.
8346
8347 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
8348 widget_update_wm_size_hints (Bug#10104).
8349
9e49252b
EZ
83502011-12-03 Eli Zaretskii <eliz@gnu.org>
8351
8352 * xdisp.c (handle_invisible_prop): If the invisible text ends just
8353 before a newline, prepare the bidi iterator for consuming the
8354 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 8355 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 8356
02b16839
JL
83572011-12-02 Juri Linkov <juri@jurta.org>
8358
8359 * search.c (Fword_search_regexp): New Lisp function created from
8360 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
8361 (Fword_search_backward, Fword_search_forward)
8362 (Fword_search_backward_lax, Fword_search_forward_lax):
8363 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
8364 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
8365
0068070e
SM
83662011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
8367
8368 * fileio.c (Finsert_file_contents): Move after-change-function call
8369 to before the "handled:" label, since all "goto handled" appear in
8370 cases where the *-change-functions have already been properly called
8371 (bug#10117).
8372
3360a3fc
AS
83732011-12-01 Andreas Schwab <schwab@linux-m68k.org>
8374
8375 * keyboard.c (interrupt_signal): Don't call kill-emacs when
8376 waiting for input. (Bug#10169)
8377
73d6c093
EZ
83782011-11-30 Eli Zaretskii <eliz@gnu.org>
8379
8380 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
8381 verifies glyph row's hash code--we have just reallocated the
8382 glyphs, so their contents can be complete garbage. (Bug#10164)
8383
febe6bea
JB
83842011-11-30 Juanma Barranquero <lekktu@gmail.com>
8385
8386 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
8387
801a4313
EZ
83882011-11-30 Eli Zaretskii <eliz@gnu.org>
8389
8390 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
8391 attributes are tested _before_ calling verify_row_hash, to protect
8392 against GCC re-ordering of the tests. (Bug#10164)
8393
2b56b87e
JD
83942011-11-29 Jan Djärv <jan.h.d@swipnet.se>
8395
8396 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
8397
8398 * xterm.c (handle_one_xevent): Only set async_visible and friends
8399 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 8400 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
8401 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
8402
dbf31225
PE
84032011-11-28 Paul Eggert <eggert@cs.ucla.edu>
8404
8405 Remove GCPRO-related macros that exist only to avoid shadowing locals.
8406 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
8407 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
8408 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
8409 All uses changed to use GCPRO1 etc.
8410 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
8411 Revert to old implementation (i.e., before 2011-03-11).
8412
1305621b
YM
84132011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8414
8415 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
8416 of scroll runs so as to avoid assigning disabled bogus rows and
8417 unnecessary graphics copy operations.
8418
8c9afb46
EZ
84192011-11-27 Eli Zaretskii <eliz@gnu.org>
8420
8421 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
8422 (snprintf) [_MSC_VER]: Redirect to _snprintf.
8423 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
8424 (malloc, free, realloc, calloc): Redirect to e_* only when
8425 compiling Emacs.
8426
8427 * lisp.h (GCTYPEBITS): Move before first use.
8428 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
8429 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
8430 this macro definition.
8431
8432 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
8433 _MSC_VER.
8434
54e9e3bf
JD
84352011-11-27 Jan Djärv <jan.h.d@swipnet.se>
8436
6d5eb5b0
SM
8437 * gtkutil.c (xg_create_frame_widgets):
8438 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
8439 present with Gtk+ 2.0.
8440
83aca1cb
PE
84412011-11-26 Paul Eggert <eggert@cs.ucla.edu>
8442
8443 * fileio.c (Finsert_file_contents): Undo previous change; see
8444 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
8445
5b76caa4
PE
84462011-11-26 Paul Eggert <eggert@cs.ucla.edu>
8447
8448 Rename locals to avoid shadowing.
8449 * fileio.c (Finsert_file_contents):
8450 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
8451 * process.c (wait_reading_process_output):
8452 Rename inner 'proc' to 'p' to avoid shadowing.
8453 Indent for consistency with usual Emacs style.
8454
8c535114
EZ
84552011-11-25 Eli Zaretskii <eliz@gnu.org>
8456
8457 * xdisp.c (redisplay_window): If cursor row is not fully visible
8458 after recentering, and scroll-conservatively is set to a large
8459 number, scroll window by a few more lines to make the cursor fully
8460 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
8461 (start_display): Don't move to the next line if the display should
8462 start at a newline that is part of a display vector or an overlay
8463 string. (Bug#10119)
8c535114 8464
fa4fdb5c
JL
84652011-11-24 Juri Linkov <juri@jurta.org>
8466
8467 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
8468 after the `MagickPingImage' call. (Bug#10112)
8469
90ec88df
CY
84702011-11-23 Chong Yidong <cyd@gnu.org>
8471
8472 * window.c (Fcoordinates_in_window_p): Accept only live windows.
8473
56e2e794
MR
84742011-11-23 Martin Rudalics <rudalics@gmx.at>
8475
8476 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
8477 making another buffer current. (Bug#10114)
8478
b6e64c41
GM
84792011-11-23 Glenn Morris <rgm@gnu.org>
8480
8481 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
8482
6b21de18
CY
84832011-11-23 Chong Yidong <cyd@gnu.org>
8484
8485 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
8486 using it (Bug#5984).
8487
b12cd789
EZ
84882011-11-22 Eli Zaretskii <eliz@gnu.org>
8489
8490 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
8491 and header-lines, as they don't have one computed for them.
8492 (Bug#10098)
8493
8494 * .gdbinit (prow): Make displayed values more self-explaining.
8495 Add row's hash code.
8496
261b6fd4
LMI
84972011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
8498
8499 * process.c (wait_reading_process_output): Fix asynchrounous
8500 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 8501 (wait_reading_process_output): Add comment and URL.
261b6fd4 8502
e7cfd277
JD
85032011-11-21 Jan Djärv <jan.h.d@swipnet.se>
8504
8505 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
8506
a9b9b7f5
CY
85072011-11-21 Chong Yidong <cyd@gnu.org>
8508
8509 * window.c (Fnext_window, Fprevious_window): Doc fix.
8510
b0d15b4f
SM
85112011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8512
8513 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
8514
fe7a3057
JB
85152011-11-20 Juanma Barranquero <lekktu@gmail.com>
8516
8517 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
8518
d2999b1a
MR
85192011-11-20 Martin Rudalics <rudalics@gmx.at>
8520
8521 * window.c (Fset_window_combination_limit): Rename argument
8522 STATUS to LIMIT.
8523 (Vwindow_combination_limit): Remove "status" from doc-string.
8524
d5ff9cd0
AS
85252011-11-20 Andreas Schwab <schwab@linux-m68k.org>
8526
8527 * m/ibms390.h: Remove.
8528 * m/ibms390x.h: Don't include "ibms390.h".
8529
a5bb9bd3
SM
85302011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8531
8532 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
8533 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
8534
cd1181db
JB
85352011-11-20 Juanma Barranquero <lekktu@gmail.com>
8536
8537 * casetab.c (Fset_case_table):
8538 * charset.c (Fcharset_after): Fix typos.
8539
615a3b8d 85402011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 8541
17e845af
PE
8542 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
8543 Otherwise, valgrind does not work on some platforms.
8544 Problem reported by Andreas Schwab in
6a0bf43d
PE
8545 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
8546 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
8547 is set, removing the need for VIRT_ADDRESS_VARIES.
8548 (PURE_P): Use a more-efficient implementation that needs just one
8549 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
8550 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
8551 to 4 (xorl, subq, cmpq, setbe).
8552 * alloc.c (pure): Always extern now, since that's the
8553 VIRT_ADDR_VARIES behavior.
8554 (PURE_POINTER_P): Use a single comparison, not two, for
8555 consistency with the new puresize.h.
8556 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
8557 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
8558 Remove VIRT_ADDR_VARIES no longer needed.
8559
f8fe6f96
EZ
85602011-11-19 Eli Zaretskii <eliz@gnu.org>
8561
8562 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
8563 (erase_phys_cursor, update_window_cursor, show_mouse_face)
8564 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
8565 behave as if the cursor position were at the window margin.
8566
8567 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
8568 and the cursor position is out of bounds, behave as if the cursor
8569 position were at the window margin. (Bug#10075)
8570
df05a53c
CY
85712011-11-18 Chong Yidong <cyd@gnu.org>
8572
8573 * window.c (Fwindow_combination_limit): Make first argument
8574 non-optional, since it is meaningless for live windows like the
8575 selected window.
61ccba97 8576
2071918e
DA
85772011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
8578
8579 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
8580
b50a28de
SM
85812011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
8582
8583 * intervals.c: Fix grafting over the whole buffer (bug#10071).
8584 (graft_intervals_into_buffer): Simplify.
8585
015137db
EZ
85862011-11-18 Eli Zaretskii <eliz@gnu.org>
8587
8588 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
8589 hash values of the two rows.
8590 (copy_row_except_pointers): Preserve the used[] arrays and the
8591 hash values of the two rows. (Bug#10035)
68c95424 8592 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
8593
8594 * xdisp.c (row_hash): New function, body extracted from
8595 compute_line_metrics.
8596 (compute_line_metrics): Call row_hash, instead of computing the
8597 hash code inline.
8598
8599 * dispnew.c (verify_row_hash): Call row_hash for computing the
8600 hash code of a row, instead of duplicating code from xdisp.c.
8601
8602 * dispextern.h (row_hash): Add prototype.
8603
a2addb04
TH
86042011-11-18 Tassilo Horn <tassilo@member.fsf.org>
8605
8606 * frame.c (delete_frame): Don't delete the terminal when the last
8607 X frame is closed if emacs is built with GTK toolkit.
8608
df85d315
JB
86092011-11-17 Juanma Barranquero <lekktu@gmail.com>
8610
8611 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
8612
a0c2d0ae
MR
86132011-11-17 Martin Rudalics <rudalics@gmx.at>
8614
8615 * window.c (Vwindow_splits): Rename to
8616 Vwindow_combination_resize. Suggested by Juri Linkov.
8617 (Fsplit_window_internal): Use Vwindow_combination_resize instead
8618 of Vwindow_splits.
8619
58179cce
JB
86202011-11-16 Juanma Barranquero <lekktu@gmail.com>
8621
7877f373
JB
8622 * nsfns.m (Fns_font_name):
8623 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 8624
b6f67890
MR
86252011-11-16 Martin Rudalics <rudalics@gmx.at>
8626
8627 * window.h (window): Rename slot "nest" to "combination_limit".
8628 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
8629 (Fset_window_nest): Rename to Fset_window_combination_limit.
8630 (Vwindow_nest): Rename to Vwindow_combination_limit.
8631 (recombine_windows, make_parent_window, make_window)
8632 (Fsplit_window_internal, saved_window)
8633 (Fset_window_configuration, save_window_save): Rename all
8634 occurrences of window_nest to window_combination_limit.
8635
c7015153
JB
86362011-11-15 Juanma Barranquero <lekktu@gmail.com>
8637
8638 * image.c (imagemagick_load_image): Fix typo.
8639
322ad6ec
EZ
86402011-11-14 Eli Zaretskii <eliz@gnu.org>
8641
8642 * xdisp.c (display_line): Move the call to
8643 highlight_trailing_whitespace before the call to
8644 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
8645 faces of all the glyphs to compute ROW's hash value.
8646 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 8647
f067b8ec
JB
86482011-11-14 Juanma Barranquero <lekktu@gmail.com>
8649
8650 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
8651 just return (bug#10044).
8652
1e5b2111
EZ
86532011-11-12 Eli Zaretskii <eliz@gnu.org>
8654
7ef3cbd5
EZ
8655 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
8656 with user-defined heap size. Bump the default size of the temacs
8657 heap to 27MB, to avoid memory warning when running temacs.
8658 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
8659
1e5b2111
EZ
8660 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
8661 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
8662 (verify_row_hash) [XASSERTS]: New function.
8663 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
8664 that the hash value of glyph rows is correct.
1e5b2111 8665
89d61221
MR
86662011-11-12 Martin Rudalics <rudalics@gmx.at>
8667
8668 * window.h (window): Remove splits slot.
8669 * window.c (Fwindow_splits, Fset_window_splits): Remove.
8670 (Fdelete_other_windows_internal, make_parent_window)
8671 (make_window, Fsplit_window_internal, Fdelete_window_internal)
8672 (Fset_window_configuration, save_window_save): Don't deal with
8673 split status of windows.
8674 (saved_window): Remove splits slot.
8675 (Vwindow_splits): Rewrite doc-string.
8676
97f18cc8
JD
86772011-11-11 Jan Djärv <jan.h.d@swipnet.se>
8678
8679 * xfns.c (unwind_create_frame):
8680 * nsfns.m (unwind_create_frame):
8681 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
8682 Vframe_list (Bug#9999).
8683
22a648b4
DA
86842011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
8685
0b381c7e 8686 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 8687
659afede
KH
86882011-11-11 Kenichi Handa <handa@m17n.org>
8689
8690 * callproc.c (Fcall_process): Set the member dst_multibyte of
8691 process_coding.
8692
9ac0394b
KH
86932011-11-11 Johan Bockgård <bojohan@gnu.org>
8694
8695 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
8696 avoid a crash (bug#9496).
8697
2fbdc249
CY
86982011-11-09 Chong Yidong <cyd@gnu.org>
8699
8700 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
8701 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
8702
ac6b1f81
PE
87032011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8704
8705 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
8706
09db192c
PE
87072011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8708
8709 Avoid some portability problems by eschewing 'extern inline' functions.
8710 The trivial performance wins aren't worth the portability hassles; see
8711 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
8712 et seq.
8713 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8714 (window_box_width, window_box_left, window_box_left_offset)
8715 (window_box_right, window_box_right_offset): Undo previous change,
8716 by removing the "extern"s.
8717 * intervals.c (adjust_intervals_for_insertion)
8718 (adjust_intervals_for_deletion): Undo previous change,
8719 making these static again.
8720 (offset_intervals, temp_set_point_both, temp_set_point)
8721 (copy_intervals_to_string): No longer inline.
8722 * xdisp.c (window_text_bottom_y, window_box_width)
8723 (window_box_height, window_box_left_offset)
8724 (window_box_right_offset, window_box_left, window_box_right)
8725 (window_box): No longer inline.
8726
105216ed
CY
87272011-11-08 Chong Yidong <cyd@gnu.org>
8728
8729 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
8730 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
8731 Signal an error if not a live window.
105216ed
CY
8732 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
8733 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
8734
ae9e237f
JB
87352011-11-07 Juanma Barranquero <lekktu@gmail.com>
8736
8737 * lisp.h (syms_of_abbrev): Remove declaration.
8738 Reported by CHENG Gao <chenggao@royau.me>.
8739
c7aa8333
EZ
87402011-11-07 Eli Zaretskii <eliz@gnu.org>
8741
8742 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
8743 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
8744 of temacs in GUI mode.
8745
be7f5545
MR
87462011-11-07 Martin Rudalics <rudalics@gmx.at>
8747
8748 * window.h: Declare delete_all_child_windows instead of
8749 delete_all_subwindows.
8750 * window.c (Fwindow_nest, Fset_window_nest)
8751 (Fset_window_new_total, Fset_window_new_normal)
8752 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
8753 (delete_all_subwindows): Rename to delete_all_child_windows.
8754 (Fdelete_other_windows_internal, Fset_window_configuration):
8755 Call delete_all_child_windows instead of delete_all_subwindows.
8756 * frame.c (delete_frame): Call delete_all_child_windows instead
8757 of delete_all_subwindows.
8758
ca78dc43
PE
87592011-11-07 Paul Eggert <eggert@cs.ucla.edu>
8760
8761 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
8762 This is also needed for porting to any host where GC_MARK_STACK is
8763 not GC_MAKE_GCPROS_NOOPS.
8764 (which_symbols): Use it.
8765
a0241d01
KH
87662011-11-07 Kenichi Handa <handa@m17n.org>
8767
8768 * coding.c (coding_set_destination): Check coding->src_pos only
8769 when coding->src_object is a buffer (bug#9910).
8770
8771 * process.c (send_process): Set the member src_multibyte of coding
8772 to 0 (bug#9911) when sending a unibyte text.
8773
8774 * callproc.c (Fcall_process): Set the member src_multibyte of
8775 process_coding to 0 (bug#9912).
8776
a64bfdfa 87772011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
8778
8779 * xmenu.c (cleanup_widget_value_tree): New function.
8780 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
8781 calling free_menubar_widget_value_tree directly (Bug#9830).
8782
cb41b32a
PE
87832011-11-06 Paul Eggert <eggert@cs.ucla.edu>
8784
8785 Fix some portability problems with 'inline'.
8786 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8787 (window_box_width, window_box_left, window_box_left_offset)
8788 (window_box_right, window_box_right_offset): Declare extern.
8789 Otherwise, these inline functions do not conform to C99 and
8790 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
8791 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
8792 * intervals.c (adjust_intervals_for_insertion)
8793 (adjust_intervals_for_deletion): Now extern, because otherwise the
8794 extern inline functions 'offset_intervals' couldn't refer to it.
8795 (static_offset_intervals): Remove.
8796 (offset_intervals): Rewrite using the old contents of
8797 static_offset_intervals. The old version didn't conform to C99
8798 because an extern inline function contained a reference to an
8799 identifier with static linkage.
8800
b7041366
AS
88012011-11-06 Andreas Schwab <schwab@linux-m68k.org>
8802
8803 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
8804 GC.
8805
88a37c4d
EZ
88062011-11-06 Eli Zaretskii <eliz@gnu.org>
8807
8808 * xdisp.c (init_iterator, reseat_to_string): Don't set the
8809 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
8810 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
8811 return Qleft_to_right.
8812
49745b39
CY
88132011-11-06 Chong Yidong <cyd@gnu.org>
8814
8815 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
8816 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
8817 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
8818 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
8819 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
8820 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
8821 (Fwindow_vscroll): Doc fix.
8822 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
8823 argument, since it makes no sense to pass a live window and for
8824 consistency with window-child.
8825
1f05cd82
CS
88262011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
8827
8828 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
8829 support MSVC.
8830
22610910
JR
88312011-11-05 Jason Rumney <jasonr@gnu.org>
8832
8833 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
8834 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
8835 fonts (Bug#6029).
8836 (add_font_entity_to_list): Fix logic errors in mixed boolean and
8837 bitwise arithmetic preventing use of unicode-sip and non-truetype
8838 opentype fonts.
8839
a06776b2
EZ
88402011-11-05 Eli Zaretskii <eliz@gnu.org>
8841
3ad924ba
EZ
8842 * s/ms-w32.h (fstat, stat, utime): Move redirections to
8843 "emacs"-only part.
8844
a06776b2
EZ
8845 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
8846 initialization code to keep similarity to xfns.c after changes
8847 from 2011-11-05.
8848
c9e7db78
JD
88492011-11-05 Jan Djärv <jan.h.d@swipnet.se>
8850
a97f8f3f
JD
8851 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
8852 (unwind_create_frame): New function (Bug#9943).
8853 (Fx_create_frame): Restructure code to be more similar to the one in
8854 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
8855 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
8856 Move terminal->reference_count++ just before making the frame official
8857 (Bug#9943).
8858
8859 * nsterm.m (x_free_frame_resources): New function.
8860 (x_destroy_window): Move code to x_free_frame_resources.
8861
c9e7db78 8862 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
8863 (Fx_create_frame, x_create_tip_frame):
8864 Move terminal->reference_count++ just before making the frame
75f1671a 8865 official. Move initialization of image_cache_refcount and
c9e7db78
JD
8866 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
8867
a6fc3b5c
EZ
88682011-11-05 Eli Zaretskii <eliz@gnu.org>
8869
8870 Support MSVC build with newer versions of Visual Studio.
8871 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
8872 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
8873 nt/gmake.defs.
8874
8875 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
8876 which are not supported by MSVC.
8877 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
8878 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
8879 bitfields.
8880 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
8881 types in bitfields.
8882 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
8883
8884 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
8885
58179cce 88862011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
8887
8888 Support MSVC build with newer versions of Visual Studio.
8889 * w32.c: Don't include w32api.h for MSVC.
8890 (init_environment) [_MSC_VER]: Call sys_access, not _access.
8891
8892 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
8893 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
8894 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
8895 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
8896 e_* cousins.
8897 (alloca) [_MSC_VER]: Define to _alloca.
8898
8899 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
8900
8901 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
8902
a58c13ed
EZ
89032011-11-04 Eli Zaretskii <eliz@gnu.org>
8904
8905 * xdisp.c (note_mouse_highlight): If either of
8906 previous/next-single-property-change returns nil, treat that as
8907 the beginning or the end of the buffer. (Bug#9955)
8908
fe0b6370
JD
89092011-11-04 Jan Djärv <jan.h.d@swipnet.se>
8910
a58c13ed 8911 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
8912 label is not null (Bug#9951).
8913 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
8914 may be NULL.
8915
89bd5ee1
EZ
89162011-11-04 Eli Zaretskii <eliz@gnu.org>
8917
8918 * window.c (Fwindow_body_size): Mention in the doc string that the
8919 return value is in frame's canonical units. (Bug#9949)
8920
84c3edb9
EZ
89212011-11-03 Eli Zaretskii <eliz@gnu.org>
8922
4e2fb5c7
EZ
8923 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
8924
84c3edb9 8925 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 8926 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 8927 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 8928
bc17a887
EZ
89292011-11-01 Eli Zaretskii <eliz@gnu.org>
8930
8931 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
8932 Don't stop backward scan on the continuation glyph, even though
8933 its CHARPOS is positive.
6d5eb5b0
SM
8934 (mouse_face_from_buffer_pos, note_mouse_highlight):
8935 Rename cover_string to disp_string.
bc17a887 8936
4ee88440
MR
89372011-11-01 Martin Rudalics <rudalics@gmx.at>
8938
8939 * window.c (temp_output_buffer_show): Don't use
8940 Vtemp_buffer_show_specifiers.
8941 (Vtemp_buffer_show_specifiers): Remove unused variable.
8942
c2ff3c02
EZ
89432011-10-30 Eli Zaretskii <eliz@gnu.org>
8944
8945 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
8946 past the beginning of the current glyph matrix.
8947
58179cce 89482011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
8949
8950 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
8951 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
8952 HAVE_GTK3 (Bug#9869).
b77a6a7f 8953
3b574623
JD
8954 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
8955 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
8956
b77a6a7f
JD
8957 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
8958
8959 * xterm.c: Declare x_handle_net_wm_state to return int.
8960 (handle_one_xevent): Check if we are iconified but don't have
8961 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
8962 (get_current_wm_state): Return non-zero if not hidden,
8963 check for _NET_WM_STATE_HIDDEN (Bug#9893).
8964 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
8965 (x_handle_net_wm_state): Return what get_current_wm_state returns.
8966 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
8967
196e41e4
PE
89682011-10-29 Paul Eggert <eggert@cs.ucla.edu>
8969
8970 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
8971 so that this new function doesn't get optimized away by a
8972 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
8973
021f2e1a
AS
89742011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8975
8976 * frame.h (MOUSE_HL_INFO): Remove excess parens.
8977
8b058d44
EZ
89782011-10-29 Eli Zaretskii <eliz@gnu.org>
8979
8980 Fix the `xbytecode' command.
8981 * .gdbinit (xprintbytestr): New command.
b50a28de 8982 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
8983 (xbytecode): Print the byte-code string as well.
8984
4452fb80
EZ
89852011-10-29 Kim Storm <storm@cua.dk>
8986
8b058d44
EZ
8987 * alloc.c (which_symbols): New function.
8988
21b72067
AS
89892011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8990
8991 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
8992 line. (Bug#9903)
8993
83ed7b5c
GM
89942011-10-29 Glenn Morris <rgm@gnu.org>
8995
8996 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
8997 Not clear what it was for, and it causes various bugs. (Bug#9839)
8998
5a7a728b
EZ
89992011-10-28 Eli Zaretskii <eliz@gnu.org>
9000
9001 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
9002 possible random value that matches one of those tested as
9003 condition to clear the mouse face.
9004
d3d0842f
CY
90052011-10-28 Chong Yidong <cyd@gnu.org>
9006
9007 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
9008
31b39d13
DN
90092011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
9010
9011 * window.c (make_window): Initialize phys_cursor_on_p.
9012
9aba6043
SM
90132011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
9014
9015 * lisp.h (struct Lisp_Symbol): Update comments.
9016
c20992f4
JB
90172011-10-28 Juanma Barranquero <lekktu@gmail.com>
9018
9019 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
9020
db4f02f2
EZ
90212011-10-28 Eli Zaretskii <eliz@gnu.org>
9022
9023 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
9024 <oslsachem@gmail.com> for helping to debug this.
9025
9026 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
9027 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
9028 (g_b_init_get_glyph_outline_w): New static variables.
9029 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
9030 (GetGlyphOutlineW_Proc): New typedefs.
9031 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
9032 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
9033 New functions.
9034 (w32font_open_internal, compute_metrics):
9035 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
9036 instead of calling the "wide" APIs directly.
9037
9038 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
9039
9040 * w32.h (syms_of_w32font): Add prototype.
9041
87e68db4
JB
90422011-10-27 Juanma Barranquero <lekktu@gmail.com>
9043
9044 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
9045 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
9046 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
9047 (Fmove_to_window_line): Doc fix.
9048
435c1d67
CY
90492011-10-27 Chong Yidong <cyd@gnu.org>
9050
9051 * process.c (make_process): Set gnutls_state to NULL.
9052
9053 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
9054 non-NULL, regardless of GNUTLS_INITSTAGE.
9055 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
9056 an error. Set process slots as soon as we allocate them.
9057
9058 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
9059
9c6c6f49
CY
90602011-10-27 Chong Yidong <cyd@gnu.org>
9061
9aba6043
SM
9062 * gnutls.c (emacs_gnutls_deinit): New function.
9063 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
9064 (Fgnutls_deinit, Fgnutls_boot): Use it.
9065
9066 * process.c (make_process): Initialize GnuTLS credentials to NULL.
9067 (deactivate_process): Call emacs_gnutls_deinit.
9068
657d08d3
JB
90692011-10-27 Juanma Barranquero <lekktu@gmail.com>
9070
9071 * image.c (x_create_x_image_and_pixmap):
9072 * w32.c (sys_rename, w32_delayed_load):
9073 * w32font.c (fill_in_logfont):
9074 * w32reg.c (x_get_string_resource): Silence compiler warnings.
9075
5430d399
JB
90762011-10-26 Juanma Barranquero <lekktu@gmail.com>
9077
9078 * w32fns.c (w32_default_color_map): New function,
9079 extracted from Fw32_default_color_map.
a7ef684b 9080 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 9081
fe0055fa
PE
90822011-10-25 Paul Eggert <eggert@cs.ucla.edu>
9083
9084 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
9085
e6346438
SM
90862011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
9087
9088 * keyboard.c (test_undefined): New function (bug#9751).
9089 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
9090
e112cc37
ET
90912011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
9092
9093 * sysdep.c (init_sys_modes): Fix the check for the controlling
9094 terminal (Bug#6649).
9095
7b5d6677
EZ
90962011-10-20 Eli Zaretskii <eliz@gnu.org>
9097
9098 * dispextern.h (struct bidi_it): New member next_en_type.
9099
9100 * bidi.c (bidi_line_init): Initialize the next_en_type member.
9101 (bidi_resolve_explicit_1): When next_en_pos is valid for the
9102 current character, check also for next_en_type being WEAK_EN.
9103 (bidi_resolve_weak): Don't enter the expensive loop if the current
9104 position is before next_en_pos. Record the bidi type of the first
9105 non-ET, non-BN character we find, in addition to its position.
9106 (bidi_level_of_next_char): Invalidate next_en_type when
9107 next_en_pos is over-stepped.
9108
7da0b018
PE
91092011-10-20 Paul Eggert <eggert@cs.ucla.edu>
9110
9111 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
9112 * editfns.c: Rewrite current-time-zone so that it invokes
9113 the equivalent of (format-time-string "%Z") to get the time zone name.
9114 This fixes a bug when the time zone name contains characters that
9115 need converting from the system time locale to Emacs internal format.
9116 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
9117 that patch fixed format-time-string to do the conversion, but
9118 I forgot to fix current-time-zone.
9119 (format_time_string): New function, containing most of
9120 what Fformat_time_string used to contain.
9121 (Fformat_time_string): Rewrite in terms of format_time_string.
9122 This doesn't change this function's behavior.
9123 (current-time-zone): Rewrite to use format_time_string.
9124 This fixes the bug reported by Michael Schierl in
9125 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
9126 Jason Rumney's 2007-06-07 change worked around this bug, but
9127 didn't fix it.
9128 * systime.h (tzname, timezone): Remove no-longer-used declarations.
9129
8547b010
EZ
91302011-10-19 Eli Zaretskii <eliz@gnu.org>
9131
9132 * xdisp.c (start_display): If the character at POS is displayed
9133 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
9134 (try_window_reusing_current_matrix): If a line ends in a display
9135 vector or the next line starts in a display vector, continue
9136 redrawing the window even though the character position of
9137 start_row was reached.
8547b010
EZ
9138 (Bug#9771, part 2)
9139
4e948d15
CY
91402011-10-18 Chong Yidong <cyd@gnu.org>
9141
9142 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
9143 with nobreak-char-display too.
9144
4787455f
EZ
91452011-10-18 Eli Zaretskii <eliz@gnu.org>
9146
9147 Fix part 3 of bug#9771.
9148 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
9149 (bidi_resolve_neutral): Don't enter the expensive loop looking for
9150 non-neutral characters if the current character is a paragraph
9151 separator (a.k.a. Newline). This avoids running the same
9152 expensive loop twice, once when we consume the preceding newline
9153 and the other time when the line actually needs to be displayed.
9154 Avoid the loop when we see neutrals on the base embedding level
9155 following a character whose directionality is the same as the
9156 paragraph's. This avoids running the expensive loop when a line
9157 ends in a long sequence of neutrals, like control characters.
9158 Add assertion against STRONG_AL type. Slightly rearrange code
9159 that determines the type of a neutral given the first non-neutral
9160 that follows it.
9161 (bidi_level_of_next_char): Set next_en_pos to zero when
9162 invalidating its info.
9163
2c91f553
EZ
91642011-10-17 Eli Zaretskii <eliz@gnu.org>
9165
9166 * xdisp.c (push_display_prop): Determine whether to record string
9167 or buffer position by IT->string, not by IT->method. Allow
9168 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
9169 (move_it_vertically_backward): Don't look for character position
9170 immediately after the newline when in a continuation line.
9171 (Bug#9771, part 1)
2c91f553 9172
c7b08b0d
MR
91732011-10-15 Martin Rudalics <rudalics@gmx.at>
9174
9175 * window.c (coordinates_in_window): Rewrite and delabelize
9176 vertical border check. (Bug#5357) (Bug#9618)
9177
6b02f655
SM
91782011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
9179
9180 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
9181 errors in XSetWindowBorder (bug#9310).
9182
81d40c92
DA
91832011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
9184
9185 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
9186 avoid crash when xmalloc overrun checking is enabled.
9187
d4172c3b
EZ
91882011-10-13 Eli Zaretskii <eliz@gnu.org>
9189
9190 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
9191 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
9192 cursor motion with <left> and <right> arrow keys.
9193
9194 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
9195 some callers set that themselves.
9196
b00eea75
EZ
91972011-10-12 Eli Zaretskii <eliz@gnu.org>
9198
9199 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
9200 display string and the previous row comes from the same string and
9201 is empty. (Bug#9739) (Bug#9738)
9202
8fe012c4
SM
92032011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
9204
9205 * doc.c (get_doc_string): Encode file name (bug#9735).
9206
0074aef2
EZ
92072011-10-12 Eli Zaretskii <eliz@gnu.org>
9208
79beb178
EZ
9209 * bidi.c (bidi_level_of_next_char):
9210 * xdisp.c (get_visually_first_element): Remove old incorrect
9211 comments regarding the Unicode Line Separator character.
9212
0074aef2
EZ
9213 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
9214
6e4b3fbe
DA
92152011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
9216
9217 * alloc.c (Fgc_status): Do not access beyond zombies array
9218 boundary if nzombies > MAX_ZOMBIES.
9219 * alloc.c (dump_zombies): Add missing format specifier.
9220
0324f3af
PE
92212011-10-12 Paul Eggert <eggert@cs.ucla.edu>
9222
b5525cac
PE
9223 * xdisp.c (set_cursor_from_row): Simplify conditionals,
9224 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
9225
0324f3af
PE
9226 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
9227 Some packages use them to denote characters with modifiers.
9228
e9b5f888
AS
92292011-10-11 Andreas Schwab <schwab@linux-m68k.org>
9230
9231 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
9232 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
9233 matching a pp-number. Rename parameter var to var1.
9234
127827c0
SM
92352011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
9236
9237 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
9238
c8fd3bd0
GM
92392011-10-08 Glenn Morris <rgm@gnu.org>
9240
9241 * callint.c (Fcall_interactively): Give a more explicit error for the
9242 'c' case with a non-character input. (Bug#8479)
9243
352ec8ff
EZ
92442011-10-08 Eli Zaretskii <eliz@gnu.org>
9245
03669ccb
EZ
9246 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
9247 lines.
7061c986
EZ
9248 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
9249 lines that are hscrolled on the left.
03669ccb 9250
352ec8ff
EZ
9251 * dispnew.c (buffer_posn_from_coords): Account for a possible
9252 presence of header-line. (Bug#4426)
9253
a66cfb1c
SM
92542011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
9255
6b02f655
SM
9256 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
9257 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 9258
7c5ee88e
PE
92592011-10-07 Paul Eggert <eggert@cs.ucla.edu>
9260
9261 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
9262 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
9263 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
9264 this makes Emacs dump core during garbage collection on rare
9265 occasions. sizeof is obviously inferior to offsetof here, so
9266 stick with offsetof.
9267 (GC_POINTER_ALIGNMENT): New macro.
9268 (mark_memory): Omit 3rd (offset) arg; caller changed.
9269 Don't assume EMACS_INT alignment is the same as pointer alignment.
9270
df1bbe5b
SM
92712011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
9272
9273 * keyboard.c (read_key_sequence_remapped): New var.
9274 (read_key_sequence): Compute remapping in the right buffer.
9275 (command_loop_1): Use read_key_sequence's remapping directly.
9276
51553db6
SM
92772011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
9278
32c1fffd
SM
9279 * dired.c (file_name_completion): Don't expand file name.
9280 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
9281 before checking file name handler.
9282
51553db6
SM
9283 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
9284 they've been requested explicitly (bug#9591).
9285
b6bd1599 92862011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
9287
9288 * keymap.c (Fsingle_key_description): Use make_specified_string
9289 instead of build_string to build string from push_key_description.
9290 (Bug#5193)
9291
f701dc2a
PE
92922011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9293
4222c55d
PE
9294 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
9295 This fixes a Y2038 bug on 64-bit hosts.
9296 * buffer.c (reset_buffer):
9297 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
9298 (Fclear_buffer_auto_save_failure):
9299 Use 0, not -1, to represent an unset failure time, since time_t
9300 might not be signed.
9301
f701dc2a
PE
9302 Remove dependency on glibc malloc internals.
9303 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9304 Move back here from lisp.h, but with their new implementations.
9305 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9306 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
9307 * charset.c (charset_table_init): New static var.
9308 (syms_of_charset): Use it instead of xmalloc. This removes a
9309 dependency on glibc malloc internals. See Eli Zaretskii's comment in
9310 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
9311 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9312 Move back to alloc.c.
9313 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9314 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
9315
9ceebf39
JD
93162011-09-30 Jan Djärv <jan.h.d@swipnet.se>
9317
9318 * nsterm.m (windowDidResize): Call x_set_window_size only when
9319 ns_in_resize is true. Otherwise set pixelwidth/height and
9320 call change_frame_size (Bug#9628).
9321
cb993c58
PE
93222011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9323
3930c88b
PE
9324 Port --enable-checking=all to Fedora 14 x86-64.
9325 * charset.c (syms_of_charset): Also account for glibc malloc's
9326 internal overhead when calculating the initial malloc maximum.
9327
cb993c58
PE
9328 Port --enable-checking=all to Fedora 14 x86.
9329 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9330 Move to lisp.h.
9331 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
9332 (overrun_check_realloc, overrun_check_free):
9333 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
9334 That way, xmalloc returns a properly-aligned pointer even if
9335 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
9336 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
9337 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
9338 into account when calculating the initial malloc maximum.
9339 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9340 Move here from alloc.c, so that charset.c can use it too.
9341 Properly align; the old code wasn't right for common 32-bit hosts
9342 when configured with --enable-checking=all.
9343 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9344 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
9345
31bed486
EZ
93462011-09-29 Eli Zaretskii <eliz@gnu.org>
9347
04c70788 9348 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
9349 use EDOM.
9350
fbcaa2f3
EZ
93512011-09-28 Eli Zaretskii <eliz@gnu.org>
9352
9353 * xdisp.c (compute_display_string_end): If there's no display
9354 string at CHARPOS, return -1.
9355
9356 * bidi.c (bidi_fetch_char): When compute_display_string_end
9357 returns a negative value, treat the character as a normal
9358 character not covered by a display string. (Bug#9624)
9359
a239d4e9
JB
93602011-09-28 Juanma Barranquero <lekktu@gmail.com>
9361
9362 * lread.c (Fread_from_string): Fix typo in docstring.
9363
88652fd5
EZ
93642011-09-27 Eli Zaretskii <eliz@gnu.org>
9365
9366 * xdisp.c (handle_invisible_prop): If invisible text ends on a
9367 newline, reseat the iterator instead of bidi-iterating there one
9368 character at a time. (Bug#9610)
32c1fffd
SM
9369 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
9370 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 9371
ed497dd4
AS
93722011-09-27 Andreas Schwab <schwab@linux-m68k.org>
9373
9374 * lread.c (readevalloop): Use correct code for NBSP.
9375 (read1): Likewise. (Bug#9608)
9376
b2bf61aa
MA
93772011-09-25 Michael Albinus <michael.albinus@gmx.de>
9378
9379 * dbusbind.c (Fdbus_register_signal): When service is not
9380 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
9381
32bbb17c
GM
93822011-09-25 Glenn Morris <rgm@gnu.org>
9383
9384 * buffer.c (truncate-lines): Doc fix.
9385
94e0933e
CY
93862011-09-24 Chong Yidong <cyd@stupidchicken.com>
9387
9388 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
9389 (Fset_window_next_buffers): Doc fix.
9390
cddde921
GM
93912011-09-24 Glenn Morris <rgm@gnu.org>
9392
9393 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
9394
1260aef1
PE
93952011-09-24 Paul Eggert <eggert@cs.ucla.edu>
9396
25b4bfa0
PE
9397 Fix minor problems found by static checking.
9398 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
9399 * indent.c (Fvertical_motion): Fix == vs = typo.
9400
e3cbd34b
EZ
94012011-09-24 Eli Zaretskii <eliz@gnu.org>
9402
a66cfb1c
SM
9403 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
9404 Default value is now t. Doc fix.
6bf7006f 9405
e3cbd34b 9406 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 9407 logic when moving up, not only when moving down. Fix the
e3cbd34b 9408 confusing name and values of the it_overshoot_expected variable;
32c1fffd 9409 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
9410
9411 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
9412 CHARPOS is covered by a display string which includes newlines.
9413 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
9414 is covered by a display string with embedded newlines.
9415
a3de0cbd
MA
94162011-09-24 Michael Albinus <michael.albinus@gmx.de>
9417
9418 * dbusbind.c (Fdbus_register_signal): Add match rule to
9419 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
9420 (Fdbus_register_method, Vdbus_registered_objects_table):
9421 Fix docstring.
a3de0cbd 9422
b260039d
JM
94232011-09-24 Jim Meyering <meyering@redhat.com>
9424
32c1fffd 9425 do not ignore write error for any output size
b260039d
JM
9426 The previous change was incomplete.
9427 While it makes emacs --batch detect the vast majority of stdout
9428 write failures, errors were still ignored whenever the output size is
9429 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
9430 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
9431 && echo FAIL: ignored write error
9432 FAIL: ignored write error
9433 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
9434 && echo FAIL: ignored write error
9435 FAIL: ignored write error
9436 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
9437
8eca8a7c
AS
94382011-09-23 Andreas Schwab <schwab@linux-m68k.org>
9439
9440 * emacs.c (Fkill_emacs): In noninteractive mode exit
9441 non-successfully if a write error occurred on stdout. (Bug#9574)
9442
3341db62
EZ
94432011-09-21 Eli Zaretskii <eliz@gnu.org>
9444
9445 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
9446 the xassert test.
9447
9448 * dispextern.h (struct it): Update the comment documenting what
9449 can it->OBJECT be.
9450
8c203dbf
EZ
94512011-09-20 Eli Zaretskii <eliz@gnu.org>
9452
9453 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
9454 a display string, extend search for cursor position to end of row.
9455 (find_row_edges): If the row ends in a newline from a display
9456 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
9457 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
9458 (Fcurrent_bidi_paragraph_direction): Fix search for previous
9459 non-empty line. Fixes confusing cursor motion with arrow keys at
9460 the beginning of a line that starts with whitespace.
8c203dbf 9461
a4824228
LMI
94622011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9463
9464 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
9465 (bug#9493).
9466
33ed493b
CY
94672011-09-18 Chong Yidong <cyd@stupidchicken.com>
9468
9469 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
9470 boolean (Bug#9154).
9471
56cd55c8
EZ
94722011-09-18 Eli Zaretskii <eliz@gnu.org>
9473
9474 * xdisp.c (display_line): Record maximum and minimum buffer
9475 positions even if no glyphs were produced (e.g., by a zero-width
9476 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
9477 buffer positions that will be removed from the glyph row because
9478 they don't fit.
c02dcedf
EZ
9479 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
9480 column is beyond frame width: don't subtract 1 "pixel" when
9481 computing width of the stretch.
3e62b7e0
EZ
9482 (reseat_at_next_visible_line_start): Undo the change made on
9483 2011-09-17 that saved paragraph information and restored it after
9484 the call to `reseat'. (Bug#9545)
56cd55c8 9485
5ed99d36 94862011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
9487
9488 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
9489 and turn window cursor on if cleared (Bug#9415).
9490
5ed99d36 94912011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
9492
9493 * search.c (boyer_moore): Take unibyte characters from pattern
9494 literally. (Bug#9458)
9495
9bade7b2
EZ
94962011-09-18 Eli Zaretskii <eliz@gnu.org>
9497
9498 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
9499
e5e9d610
PE
95002011-09-18 Paul Eggert <eggert@cs.ucla.edu>
9501
87e4427a
PE
9502 Fix minor problem found by static checking.
9503 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
9504 initialized, to pacify gcc -Wuninitialized.
9505
e5e9d610
PE
9506 * fileio.c: Report proper errno when syscall falls.
9507 (Finsert_file_contents): Save and restore errno,
9508 so that report_file_error outputs the correct diagnostic.
9509 (Fwrite_region) [CLASH_DETECTION]: Likewise.
9510
a1674f0b
EZ
95112011-09-18 Eli Zaretskii <eliz@gnu.org>
9512
9513 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
9514
fbfb6dd4
EZ
95152011-09-17 Eli Zaretskii <eliz@gnu.org>
9516
9517 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
9518 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
9519
bb187662
EZ
95202011-09-17 Eli Zaretskii <eliz@gnu.org>
9521
1137e8b8 9522 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 9523 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
9524
9525 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
9526 (bidi_find_paragraph_start): Search back for paragraph beginning
9527 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
9528 (bidi_move_to_visually_next): Only trigger paragraph-related
9529 computations when the last character is a newline or at EOB, not
9530 just any NEUTRAL_B. (Bug#9470)
9531
bb187662
EZ
9532 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
9533 truncated lines if point is covered by a display string. (Bug#9524)
9534
2e621251
PE
95352011-09-16 Paul Eggert <eggert@cs.ucla.edu>
9536
9537 * xselect.c: Relax test for outgoing X longs (Bug#9498).
9538 (cons_to_x_long): New function.
9539 (lisp_data_to_selection_data): Use it. Correct the test for
9540 short-versus-long data; it was negated. Break out of vector
9541 loop, for efficiency, when a long datum is discovered.
9542
91a15bc6
SM
95432011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
9544
9545 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
9546
b41c3a35
EZ
95472011-09-16 Eli Zaretskii <eliz@gnu.org>
9548
9549 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
9550 GCC PR/17406) by declaring this function with external scope.
9551
7812ba2d
PE
95522011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9553
9554 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
9555 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
9556
cf7edc2a
AS
95572011-09-15 Andreas Schwab <schwab@linux-m68k.org>
9558
9559 * editfns.c (Fformat): Correctly handle text properties on "%%".
9560
bd01620e
EZ
95612011-09-15 Eli Zaretskii <eliz@gnu.org>
9562
9563 * xterm.c (x_draw_composite_glyph_string_foreground):
9564 * w32term.c (x_draw_composite_glyph_string_foreground):
9565 * term.c (encode_terminal_code):
9566 * composite.c (composition_update_it, get_composition_id):
9567 * xdisp.c (get_next_display_element)
9568 (fill_composite_glyph_string): Add comments about special meaning
9569 of TAB characters in a composition.
9570
a02719a3
PE
95712011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9572
9573 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
9574 This occurs when processing a multibyte format.
9575 Problem reported by Wolfgang Jenker.
a02719a3 9576
72589a3c
JB
95772011-09-15 Johan Bockgård <bojohan@gnu.org>
9578
9579 * xdisp.c (try_cursor_movement): Only check for exact match if
9580 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
9581
1c14176c
PE
95822011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9583
9584 Remove unused external symbols.
9585 * dispextern.h (calc_pixel_width_or_height): Remove decl.
9586 * xdisp.c (calc_pixel_width_or_height): Now static.
9587 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
9588 * indent.c (check_display_width):
9589 * w32term.c: Fix comment to match code.
9590 * xterm.c, xterm.h (x_catching_errors): Remove.
9591
d2eea5b5
PE
95922011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9593
9594 * xselect.c: Use signed conversions more consistently (Bug#9498).
9595 (selection_data_to_lisp_data): Assume incoming selection data are
9596 signed integers, not unsigned. This is to be consistent with
9597 outgoing selection data, which was modified to use signed integers
9598 in as part of the fix to Bug#9196 in response to Jan D.'s comment
9599 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
9600 expects long, not unsigned long.
9601
46888499
EZ
96022011-09-14 Eli Zaretskii <eliz@gnu.org>
9603
9604 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
9605 computation of loop end. Reported by Johan Bockgård
9606 <bojohan@gnu.org>.
9607
ef8ef9fb
CY
96082011-09-13 Chong Yidong <cyd@stupidchicken.com>
9609
9610 * frame.c (Fother_visible_frames_p): Function deleted.
9611
fa819fed
EZ
96122011-09-12 Eli Zaretskii <eliz@gnu.org>
9613
9614 * indent.c (compute_motion): Process display vector front to back
9615 rather than the other way around. (Bug#2496)
9616
2ba8e008
SM
96172011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
9618
9619 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
9620
20f53c69
CY
96212011-09-11 Chong Yidong <cyd@stupidchicken.com>
9622
9623 * minibuf.c (Fread_from_minibuffer): Doc fix.
9624
d562d7a4
EZ
96252011-09-11 Eli Zaretskii <eliz@gnu.org>
9626
9627 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
9628 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
9629
1c4d7f3d
LMI
96302011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9631
9632 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
9633 value for non-existent files.
9634
b885bf36
EZ
96352011-09-11 Eli Zaretskii <eliz@gnu.org>
9636
9637 * fileio.c (Finsert_file_contents): If the file cannot be opened,
9638 set its "size" to -1. This will set the modtime_size field of
9639 the corresponding buffer to -1, which is what
9640 verify-visited-file-modtime expects for files that do not exist.
9641 (Bug#9139)
9642
6612f0bf
PE
96432011-09-11 Paul Eggert <eggert@cs.ucla.edu>
9644
9645 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
9646 here ...
9647 * lisp.h: ... from here. push_key_description is no longer
9648 defined in keyboard.c, so its declaration should not be in
9649 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
9650 logically belongs with push_key_description.
9651
dfb3f755
PE
96522011-09-10 Paul Eggert <eggert@cs.ucla.edu>
9653
9654 * buffer.h: Include <sys/types.h> instead of <time.h>.
9655 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
9656 Problem reported by Herbert J. Skuhra.
9657
3134906c
LMI
96582011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
9659
9660 * xml.c (parse_region): Make the parsing work for
9661 non-comment-starting XML files again (bug#9144).
9662
8d903f4e
AS
96632011-09-10 Andreas Schwab <schwab@linux-m68k.org>
9664
9665 * image.c (gif_load): Fix calculation of bottom and right corner.
9666 (Bug#9468)
9667
80ad64f4
EZ
96682011-09-10 Eli Zaretskii <eliz@gnu.org>
9669
9670 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
9671 redisplay in small windows.
9672
208a048d
EZ
96732011-09-09 Eli Zaretskii <eliz@gnu.org>
9674
9675 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
9676
9b1c252e
MR
96772011-09-08 Martin Rudalics <rudalics@gmx.at>
9678
9679 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
9680 Operate on live windows only.
9681
2949f33b
JB
96822011-09-08 Juanma Barranquero <lekktu@gmail.com>
9683
9684 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
9685
e08dcafd
EZ
96862011-09-07 Eli Zaretskii <eliz@gnu.org>
9687
9688 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
9689 only under bidi iteration.
9690
115b96bd
JD
96912011-09-07 Jan Djärv <jan.h.d@swipnet.se>
9692
9693 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
9694
c8199d0f
PE
96952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
9696
9697 isnan: Fix porting problem to Solaris 10 with bundled gcc.
9698 Without this fix, the command to link temacs failed due to an
9699 undefined symbol __builtin_isnan. This is because
9700 /usr/include/iso/math_c99.h #defines isnan(x) to
9701 __builtin_isnan(x), but the bundled gcc, which identifies itself
9702 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
9703 a __builtin_isnan.
9704 * floatfns.c (isnan): #undef, and then #define to a clone of
9705 what's in data.c.
9706 (Fisnan): Always define, since it's always available now.
9707 (syms_of_floatfns): Always define isnan at the Lisp level.
9708
e39b275c 97092011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
9710
9711 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
9712
b2db44d9 97132011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 9714
f4af5137 9715 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
9716 The previous code assumed that file offsets (off_t values) fit in
9717 EMACS_INT variables, which is not true on typical 32-bit hosts.
9718 The code messed up by falsely reporting buffer overflow in cases
9719 such as (insert-file-contents "big" nil 1 2) into an empty buffer
9720 when "big" contains more than 2**29 bytes, even though this
9721 inserts just one byte and does not overflow the buffer.
9722 (Finsert_file_contents): Store file offsets as off_t
9723 values, not as EMACS_INT values. Check for overflow when
9724 converting between EMACS_INT and off_t. When checking for
9725 buffer overflow or for overlap, take the offsets into account.
9726 Don't use EMACS_INT for small values where int suffices.
9727 When checking for overlap, fix a typo: ZV was used where
9728 ZV_BYTE was intended.
9729 (Fwrite_region): Don't assume off_t fits into 'long'.
9730 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
9731
ecfc0a49
MA
97322011-09-05 Michael Albinus <michael.albinus@gmx.de>
9733
9734 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
9735
6511acf2 97362011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 9737
0999621a 9738 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
9739
9740 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 9741 (esprintf, exprintf, evxprintf): New functions.
62f19c19 9742 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 9743 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
9744 (modify_event_symbol): Do not assume that the length of
9745 name_alist_or_stem is safe to alloca and fits in int.
9746 (Fexecute_extended_command): Likewise for function name and binding.
9747 (Frecursion_depth): Wrap around reliably on integer overflow.
9748 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
9749 since some callers pass EMACS_INT values.
9750 (Fsingle_key_description): Don't crash if symbol name contains more
9751 than MAX_ALLOCA bytes.
9752 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
9753 (get_minibuffer): Arg is now EMACS_INT, not int.
9754 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 9755 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
9756 * window.h (command_loop_level, minibuf_level): Reflect API changes.
9757
2be7d702
PE
9758 * dbusbind.c (signature_cat): New function.
9759 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
9760 Do not overrun buffer; instead, report string overflow.
9761
9d1df220
PE
9762 * dispnew.c (add_window_display_history): Don't overrun buffer.
9763 Truncate instead; this is OK since it's just a log.
9764
33ef5c64
PE
9765 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
9766 even if the time zone offset is outlandishly large.
9767 Don't mishandle offset == INT_MIN.
9768
66c6fdd5
PE
9769 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
9770 when creating daemon; the previous buffer-overflow check was incorrect.
9771
d749b01b
PE
9772 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
9773 which has the guts of the old verror function.
9774
b5cd1905
PE
9775 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
9776 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
9777
6e1a67fb
PE
9778 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
9779 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 9780 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 9781 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
9782 length of string rather than counting it via multiple sprintfs;
9783 that's simpler and more reliable.
c21721cc
PE
9784 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
9785 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
9786 sprintf, in case result does not fit in int.
9787
c57b67fc
PE
9788 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
9789 (fontset_from_font): Print it.
9790
8a401434
PE
9791 * frame.c (tty_frame_count): Now printmax_t, not int.
9792 (make_terminal_frame, set_term_frame_name): Print it.
9793 (x_report_frame_params): In X, window IDs are unsigned long,
9794 not signed long, so print them as unsigned.
9795 (validate_x_resource_name): Check for implausibly long names,
9796 and don't assume name length fits in 'int'.
9797 (x_get_resource_string): Don't blindly alloca invocation name;
9798 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
9799 not fit in int.
9800
6e1a67fb
PE
9801 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
9802 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
9803 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
9804
0df02bf3
PE
9805 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
9806 Use esprintf, not sprintf, in case result does not fit in int.
9807
48e30793
PE
9808 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9809 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
9810 it as a large positive number.
9811 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
9812 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9813
a66ff6d8
PE
9814 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
9815 in case result does not fit in int.
9816
aca216ff
PE
9817 * print.c (float_to_string): Detect width overflow more reliably.
9818 (print_object): Make sprintf buffer a bit bigger, to avoid potential
9819 buffer overrun. Don't assume list length fits in 'int'. Treat
9820 print length of 0 as 0, not as infinity; to be consistent with other
9821 uses of print length in this function. Don't overflow print length
9822 index. Don't assume hash table size fits in 'long', or that
9823 vectorlike size fits in 'unsigned long'.
9824
31c286f7
PE
9825 * process.c (make_process): Use printmax_t, not int, to format
9826 process-name gensyms.
9827
55e5faa1
PE
9828 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
9829
80f2e268
PE
9830 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
9831 to avoid potential buffer overrun.
9832
670741ab
PE
9833 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
9834 if X resource line is longer than 512 bytes.
9835
b7163a50
PE
9836 * xfns.c (x_window): Make sprintf buffer a bit bigger
9837 to avoid potential buffer overrun.
9838
ae58ff1f
PE
9839 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
9840
c43c8a6a
PE
9841 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
9842
3f8236f4
PE
98432011-09-04 Paul Eggert <eggert@cs.ucla.edu>
9844
53e9fe90 9845 Integer overflow fixes for scrolling, etc.
6511acf2
PE
9846 Without these, Emacs silently mishandles large integers sometimes.
9847 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
9848 it were "C-u 1 M-x recenter" on a typical 64-bit host.
9849
6511acf2
PE
9850 * xdisp.c (try_window_id): Check Emacs fixnum range before
9851 converting to 'int'.
806add1d 9852
6511acf2 9853 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
9854 Check that an Emacs fixnum is in range before assigning it to 'int'.
9855 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
9856 values converted from Emacs fixnums.
9857 (Frecenter): Don't wrap around a line count if it is out of 'int'
9858 range; instead, treat it as an extreme value.
9859 (Fset_window_configuration, compare_window_configurations):
9860 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
9861
6511acf2
PE
9862 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
9863 that can exceed INT_MAX. Check that EMACS_INT value is in range
9864 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
9865 (match_limit): Don't assume that a fixnum can fit in 'int'.
9866
6511acf2 9867 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
9868 exceed INT_MAX.
9869
6511acf2 9870 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
9871 (Fvertical_motion): Don't wrap around LINES values that don't fit
9872 in 'int'. Instead, treat them as extreme values. This is good
9873 enough for windows, which can't have more than INT_MAX lines anyway.
9874
fcb901a7
LMI
98752011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9876
0f2f6b6d
LMI
9877 * Require libxml/parser.h to avoid compilation warning.
9878
fcb901a7
LMI
9879 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
9880
9881 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
9882 since this reportedly can destroy thread storage.
9883
6e20a0d4
CY
98842011-08-30 Chong Yidong <cyd@stupidchicken.com>
9885
9886 * syntax.c (find_defun_start): Update all cache variables if
9887 exiting early (Bug#9401).
9888
148ae00e
EZ
98892011-08-30 Eli Zaretskii <eliz@gnu.org>
9890
f6cfbd8f
EZ
9891 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
9892
148ae00e
EZ
9893 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
9894 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
9895 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
9896
9897 * term.c (tty_append_glyph): New function.
9898 (produce_stretch_glyph): Static function and its prototype deleted.
9899
a66cfb1c
SM
9900 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
9901 Add prototypes.
148ae00e 9902
c4a07a4c
PE
99032011-08-29 Paul Eggert <eggert@cs.ucla.edu>
9904
9905 * image.c (parse_image_spec): Check for nonnegative, not for positive,
9906 when checking :margin (Bug#9390).
9907 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 9908 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
9909 so that the name doesn't mislead. All uses changed.
9910
6bc8cd65
JB
99112011-08-28 Johan Bockgård <bojohan@gnu.org>
9912
9913 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
9914 set_tty_hooks.
9915
dca4927e
EZ
99162011-08-27 Eli Zaretskii <eliz@gnu.org>
9917
9918 * xdisp.c (move_it_to): Don't bail out early when reaching
9919 position beyond to_charpos, if we are scanning backwards.
9920 (move_it_vertically_backward): When DY == 0, make sure we get to
9921 the first character in the line after the newline.
9922
f2cad773
PE
99232011-08-27 Paul Eggert <eggert@cs.ucla.edu>
9924
9925 * ccl.c: Improve and simplify overflow checking (Bug#9196).
9926 (ccl_driver): Do not generate an out-of-range pointer.
9927 (Fccl_execute_on_string): Remove unnecessary check for
9928 integer overflow, noted by Stefan Monnier in
9929 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
9930 Remove a FIXME that didn't need fixing.
9931 Simplify the newly-introduced buffer reallocation code.
9932
0cae2cdb
JB
99332011-08-27 Juanma Barranquero <lekktu@gmail.com>
9934
9935 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
9936
5fc295a4 99372011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 9938
70c60eb2 9939 Integer and memory overflow issues (Bug#9196).
726e0ab1 9940
d31850da
PE
9941 * doc.c (get_doc_string): Rework so that
9942 get_doc_string_buffer_size is the actual buffer size, rather than
9943 being 1 less than the actual buffer size; this makes xpalloc more
9944 convenient.
9945
a69fbedb
PE
9946 * image.c (x_allocate_bitmap_record, cache_image):
9947 * xselect.c (Fx_register_dnd_atom):
9948 Simplify previous changes by using xpalloc.
9949
fe5c5d37
PE
9950 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
9951 since either will do and ptrdiff_t is convenient with xpalloc.
9952
0065d054
PE
9953 * charset.c (charset_table_size)
9954 (struct charset_sort_data.priority): Now ptrdiff_t.
9955 (charset_compare): Don't overflow if priorities differ greatly.
9956 (Fsort_charsets): Don't assume list length fits in int.
9957 Check for size-calculation overflow when allocating sort data.
9958 (syms_of_charset): Allocate an initial charset table that is
9959 just under 64 KiB, to avoid problems with glibc malloc and mmap.
9960
9961 * cmds.c (internal_self_insert): Check for size-calculation overflow.
9962
9963 * composite.h (struct composition.glyph_len): Now int, not unsigned.
9964 The actual value is always <= INT_MAX, and leaving it unsigned made
9965 overflow checking harder.
9966
9967 * dispextern.h (struct glyph_matrix.rows_allocated)
9968 (struct face_cache.size): Now ptrdiff_t, for convenience in use
9969 with xpalloc. The values are still always <= INT_MAX.
9970
9971 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
9972
9973 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
9974 (SAFE_NALLOCA): New macro.
9975
9976 * region-cache.c (struct boundary.pos, find_cache_boundary)
9977 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
9978 (set_cache_region, invalidate_region_cache)
9979 (revalidate_region_cache, know_region_cache, region_cache_forward)
9980 (region_cache_backward, pp_cache):
9981 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
9982 so that ptrdiff_t * can be passed to xpalloc.
9983 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
9984 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
9985 (pp_cache): Don't assume cache_len fits in int.
9986 * region-cache.h: Adjust extern decls to match.
9987
9988 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
9989 EMACS_INT, since either will do, for xpalloc.
9990
9991 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
9992 (xnmalloc, xnrealloc, xpalloc): New functions.
9993
726e0ab1
PE
9994 * bidi.c (bidi_shelve_header_size): New constant.
9995 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
9996 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
9997
51f30bc5 9998 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
9999 * buffer.c (overlays_at, overlays_in, record_overlay_string)
10000 (overlay_strings):
10001 Don't update size of array until after memory allocation succeeds,
10002 because xmalloc/xrealloc may not return.
0065d054
PE
10003 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
10004 now that we have proper integer overflow checking.
10005 (record_overlay_string, overlay_strings): Catch overflows when
10006 calculating size of overlay_str_buf.
726e0ab1 10007
0065d054
PE
10008 * callproc.c (Fcall_process): Check for size overflow when
10009 calculating size of args2.
10010 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
10011 Normally we prefer signed values, but sticking with ptrdiff_t would
10012 require adding more-complicated checks.
726e0ab1
PE
10013
10014 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
10015 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
10016 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 10017 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
10018
10019 * character.c (Fstring): Check for size-calculation overflow.
10020
10021 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
10022 unnecessary integer overflow. Check for size overflow.
10023 (encode_coding_object): Don't update size until xmalloc succeeds.
10024
10025 * composite.c (get_composition_id): Check for overflow in glyph
10026 length calculations.
10027
10028 Integer and memory overflow fixes for display code.
10029 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
10030 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
10031 (scrolling_window): Check for overflow in size calculations.
10032 (line_draw_cost, realloc_glyph_pool, add_row_entry):
10033 Don't assume glyph table len fits in int.
10034 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
10035 (row_table_size): Now ptrdiff_t, not int.
10036 (scrolling_window): Avoid overflow in size calculations.
10037 Don't update size until allocation succeeds.
10038 * fns.c (concat): Check for overflow in size calculations.
10039 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
10040 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10041 (NEXT_ALMOST_PRIME_LIMIT): New constant.
10042
10043 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
10044 (get_doc_string): Check for size calculation overflow.
10045 Don't update size until allocation succeeds.
10046 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
10047 EMACS_INT, where ptrdiff_t will do.
10048 (Fsubstitute_command_keys): Check for string overflow.
10049
10050 * editfns.c (set_time_zone_rule): Don't assume environment length
10051 fits in int.
10052 (message_length): Now ptrdiff_t, not int.
10053 (Fmessage_box): Don't update size until allocation succeeds.
10054 Don't assume message length fits in int.
10055 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
10056
0065d054
PE
10057 * emacs.c (main): Do not reallocate argv, since there is a null at
10058 the end that can be overwritten, and this way there's no need to
10059 worry about size-calculation overflow.
10060 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
10061
10062 * eval.c (init_eval_once, grow_specpdl): Don't update size until
10063 alloc succeeds.
10064 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
10065
10066 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
10067 (x_set_scroll_bar_width, x_figure_window_size):
10068 Check for integer overflow.
10069 (x_set_alpha): Do not assume XINT fits in int.
10070
10071 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
10072 This is for the members text_lines, text_cols, total_lines, total_cols,
10073 where the system imposes an 'int' limit.
10074
10075 * fringe.c (Fdefine_fringe_bitmap):
10076 Don't update size until alloc works.
10077
10078 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
10079 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
10080
10081 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
10082 Check for size-calculation overflow.
10083 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
10084 do, as we prefer signed integers.
10085 (id_to_widget.max_size, id_to_widget.used)
10086 (xg_store_widget_in_map, xg_remove_widget_from_map)
10087 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
10088 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
10089 Use and return ptrdiff_t, not int.
10090 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
10091 * gtkutil.h: Change prototypes to match the above.
10092
10093 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
10094 are duplicate now that they've been promoted to lisp.h.
10095 (x_allocate_bitmap_record, x_alloc_image_color)
10096 (make_image_cache, cache_image, xpm_load):
10097 Don't update size until alloc is done.
10098 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
10099 (x_detect_edges):
3256efce 10100 Check for size calculation overflow.
726e0ab1
PE
10101 (ct_colors_allocated_max): New constant.
10102 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
10103 overflow.
3256efce 10104
726e0ab1
PE
10105 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
10106 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
10107 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
10108 Use ptrdiff_t, not int, to count maps.
10109 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
10110 calculations. Don't update size until allocation succeeds.
10111 Redo calculations to avoid overflow.
726e0ab1
PE
10112 * keyboard.h: Change prototypes to match the above.
10113
10114 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
10115 to count maps.
10116 (current_minor_maps): Check for size calculation overflow.
10117 * keymap.h: Change prototypes to match the above.
10118
10119 * lread.c (read1, init_obarray): Don't update size until alloc done.
10120
10121 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
10122 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
10123
726e0ab1
PE
10124 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
10125 Now ptrdiff_t, not int.
10126 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
10127 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
10128
10129 * process.c (Fnetwork_interface_list): Check for overflow
10130 in size calculation.
10131
10132 * region-cache.c (move_cache_gap): Check for size calculation overflow.
10133
10134 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
10135 overflow. Don't bother calling xmalloc when xrealloc will do.
10136
10137 * search.c (Freplace_match): Check for size calculation overflow.
10138 (Fset_match_data): Don't assume list lengths fit in 'int'.
10139
10140 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
10141 for command line length. Do not attempt to address one before the
10142 beginning of an array, as that's not portable.
10143
10144 * term.c (max_frame_lines): Remove; unused.
10145 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
10146 not int.
10147 (encode_terminal_code, calculate_costs): Check for size
10148 calculation overflow.
10149 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
10150 table lengths and related sizes. Don't update size until alloc
10151 done. Redo calculations to avoid overflow.
10152 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
10153
10154 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
10155 subtracting pointers.
10156 (gobble_line): Check for overflow more carefully. Don't update size
10157 until alloc done.
10158
10159 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
10160 Don't update size until alloc done.
10161 Redo size calculations to avoid overflow.
10162 Check for size calculation overflow.
0065d054 10163 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
10164
10165 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
10166 Use ptrdiff_t, not int, for sizes.
10167 (store_mode_line_noprop_char): Don't update size until alloc done.
10168
0065d054
PE
10169 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
10170 Use ptrdiff_t, not int, for sizes.
10171 (Finternal_make_lisp_face, cache_face):
10172 Check for size calculation overflow.
10173 (cache_face): Treat size calculation overflows as if they were
10174 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
10175
10176 * xfns.c (x_encode_text, x_set_name_internal)
10177 (Fx_change_window_property): Use ptrdiff_t, not int, to count
10178 sizes, since they can exceed INT_MAX in size. Check for size
10179 calculation overflow.
10180
0065d054
PE
10181 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
10182 (xg_select): Check for size calculation overflow.
726e0ab1
PE
10183 Don't update size until alloc done.
10184
0065d054 10185 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 10186 as sprintf is limited to int lengths.
1d526e2f 10187
252c5ee1
PE
10188 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
10189 (X_LONG_MIN): New macros.
864d7ce7
PE
10190 Use them to make the following changes clearer.
10191 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
10192 This change doesn't affect the value now, but it may help remind
10193 future maintainers not to raise the value too much later.
10194 (SELECTION_QUANTUM): Remove, replacing with ...
10195 (selection_quantum): ... new function, which avoids overflow.
10196 All uses changed.
10197 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
10198 assumption that selection length fits in 'int'.
10199 (x_reply_selection_request, x_handle_selection_request)
10200 (x_get_window_property, receive_incremental_selection)
10201 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
10202 (lisp_data_to_selection_data, clean_local_selection_data):
10203 Use ptrdiff_t, not int, to record length of selection.
10204 (x_reply_selection_request, x_get_window_property)
10205 (receive_incremental_selection, x_property_data_to_lisp):
10206 Redo calculations to avoid overflow.
10207 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 10208 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
10209 something.
10210 (x_get_window_property, receive_incremental_selection)
10211 (lisp_data_to_selection_data, x_property_data_to_lisp):
10212 Check for size-calculation overflow.
10213 (x_get_window_property, receive_incremental_selection)
10214 (lisp_data_to_selection_data, Fx_register_dnd_atom):
10215 Don't store size until memory allocation succeeds.
10216 (x_get_window_property): Plug memory leak on memory exhaustion.
10217 Don't double-block input; malloc is safe here. Don't assume 2**34
10218 - 4 fits in unsigned long. Add an xassert to check
10219 XGetWindowProperty overflow. Be more careful about overflow
10220 calculations, and distinguish size from memory overflow better.
10221 (receive_incremental_selection): When tracing, don't assume
10222 unsigned int is less than INT_MAX.
10223 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
10224 harmful) conversions of unsigned short to int.
10225 (lisp_data_to_selection_data): Don't assume that integers
10226 in the range -65535 through -1 fit in an X unsigned short.
10227 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
10228 result parameters unless successful. Rely on cons_to_unsigned
10229 to report problems with elements; the old code wasn't right anyway.
10230 (x_check_property_data): Check for int overflow; we cannot use
10231 a wider type due to X limits.
10232 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
10233
726e0ab1 10234 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 10235
0065d054
PE
10236 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
10237 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
10238 (x_color_cells): Don't store size until memory allocation succeeds.
10239 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 10240 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
10241 (x_term_init): Don't assume length fits in int (sprintf is limited
10242 to int size).
bc18e09d 10243
ebfa62c0
PE
10244 Use ptrdiff_t for composition IDs.
10245 * character.c (lisp_string_width):
10246 * composite.c (composition_table_size, n_compositions)
10247 (get_composition_id, composition_gstring_from_id):
10248 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
10249 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
10250 * window.c (Frecenter):
10251 Use ptrdiff_t, not int, for composition IDs.
10252 * composite.c (get_composition_id): Check for integer overflow.
10253 * composite.h: Adjust prototypes to match the above changes.
10254
d3411f89
PE
10255 Use ptrdiff_t for hash table indexes.
10256 * category.c (hash_get_category_set):
10257 * ccl.c (ccl_driver):
10258 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
10259 * coding.c (coding_system_charset_list, detect_coding_system):
10260 * coding.h (struct coding_system.id):
10261 * composite.c (get_composition_id, gstring_lookup_cache):
10262 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
10263 * image.c (xpm_get_color_table_h):
10264 * lisp.h (hash_lookup, hash_put):
10265 * minibuf.c (Ftest_completion):
10266 Use ptrdiff_t for hash table indexes, not int (which is too
10267 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
10268 32-bit --with-wide-int hosts).
10269
e097a6fa
PE
10270 * charset.c (Fdefine_charset_internal): Check for integer overflow.
10271 Add a FIXME comment about memory leaks.
10272 (syms_of_charset): Don't assume xmalloc returns.
10273
5637687f
PE
10274 Don't assume that stated character widths fit in int.
10275 * character.c (Fchar_width, c_string_width, lisp_string_width):
10276 * character.h (CHAR_WIDTH):
10277 * indent.c (MULTIBYTE_BYTES_WIDTH):
10278 Use sanitize_char_width to avoid undefined and/or bad behavior
10279 with outlandish widths.
a66cfb1c 10280 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
10281 now that we have two such functions. All uses changed.
10282 (sanitize_char_width): New inline function.
10283
a2271ba2
PE
10284 Don't assume that tab-width fits in int.
10285 * character.h (sanitize_width): New inline function.
10286 (SANE_TAB_WIDTH): New macro.
10287 (ASCII_CHAR_WIDTH): Use it.
10288 * indent.c (sane_tab_width): Remove. All uses replaced by
10289 SANE_TAB_WIDTH (current_buffer).
10290 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
10291
18c52557
PE
10292 * fileio.c: Integer overflow issues with file modes.
10293 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
10294
caeeedc1
PE
10295 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
10296 Remove unreachable code.
10297 (read_hex, load_charset_map_from_file): Check for integer overflow.
10298
6df6ae42 10299 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
10300 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
10301 (x_send_scroll_bar_event): Likewise. Check that the size does not
10302 exceed limits imposed by XClientMessageEvent, as well as the usual
10303 ptrdiff_t and size_t limits.
10304
b13995db
PE
10305 * keyboard.c: Overflow, signedness and related fixes.
10306 (make_lispy_movement): Use same integer type in forward decl
10307 that is used in the definition.
10308 (read_key_sequence, keyremap_step):
10309 Change bufsize argument back to int, undoing my 2011-03-30 change.
10310 We prefer signed types, and int is wide enough here.
10311 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
10312 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
10313 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
10314 length, not size_t. Use ptrdiff_t for index, not int.
10315 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
10316 possibility of integer overflow.
10317
13464394
PE
10318 Overflow, signedness and related fixes for images.
10319
10320 * dispextern.h (struct it.stack[0].u.image.image_id)
10321 (struct_it.image_id, struct image.id, struct image_cache.size)
10322 (struct image_cache.used, struct image_cache.ref_count):
10323 * gtkutil.c (update_frame_tool_bar):
10324 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
10325 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
10326 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
10327 * nsmenu.m (update_frame_tool_bar):
10328 * xdisp.c (calc_pixel_width_or_height):
10329 * xfns.c (image_cache_refcount):
10330 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
10331 on typical 64-bit hosts.
10332
10333 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10334 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
10335 Omit unnecessary casts to int.
10336 (parse_image_spec): Check that integers fall into 'int' range
10337 when the callers expect that.
10338 (image_ascent): Redo ascent calculation to avoid int overflow.
10339 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
10340 (lookup_image): Remove unnecessary tests.
10341 (xbm_image_p): Locals are now of int, not EMACS_INT,
10342 since parse_image_check makes sure they fit into int.
10343 (png_load, gif_load, svg_load_image):
10344 Prefer int to unsigned where either will do.
10345 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
10346 old tiff_error_handler and tiff_warning_handler.
10347 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
10348 stack buffer overflows. It uses only the features of vsnprintf
10349 that are common to both POSIX and native Microsoft.
10350 (tiff_error_handler, tiff_warning_handler): Use it.
10351 (tiff_load, gif_load, imagemagick_load_image):
10352 Don't assume :index value fits in 'int'.
10353 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
10354 (imagemagick_load_image): Check that crop parameters fit into
10355 the integer types that MagickCropImage accepts. Don't assume
10356 Vimagemagick_render_type has a nonnegative value. Don't assume
10357 size_t fits in 'long'.
10358 (gs_load): Use printmax_t to print the widest integers possible.
10359 Check for integer overflow when computing image height and width.
10360
c11821d4
EZ
103612011-08-26 Eli Zaretskii <eliz@gnu.org>
10362
10363 * xdisp.c (redisplay_window): Don't force window start if point
10364 will be invisible in the resulting window. (Bug#9324)
10365
0c95fcf7
EZ
103662011-08-25 Eli Zaretskii <eliz@gnu.org>
10367
10368 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
10369 the display spec is of the form `(space ...)'.
10370 (handle_display_spec): Return the value returned by
10371 handle_single_display_spec, not just 1 or zero.
10372 (handle_single_display_spec): If the display spec is of the form
10373 `(space ...)', and specifies display in the text area, return 2
10374 rather than 1.
fee65a97 10375 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
10376 accurately, and prefer exact match for point under bidi.
10377 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
10378
10379 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
10380 into disp_prop; all users changed.
10381
10382 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
10383 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
10384 for the text covered by the display property.
10385
e4ed06f1
CY
103862011-08-25 Chong Yidong <cyd@stupidchicken.com>
10387
10388 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
10389 Change return value to nil.
10390 (Frecord_buffer): Delete unused function.
10391
f67cdd7f
EZ
103922011-08-24 Eli Zaretskii <eliz@gnu.org>
10393
5980d4c6
EZ
10394 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
10395 buffers, return left-to-right.
8610fe8b
EZ
10396 (set_cursor_from_row): Consider candidate row a win if its glyph
10397 represents a newline and point is on that newline. Fixes cursor
10398 positioning on the newline at EOL of R2L text within L2R
10399 paragraph, and vice versa.
10400 (try_cursor_movement): Check continued rows, in addition to
10401 continuation rows. Fixes unwarranted scroll when point enters a
10402 continued line of R2L text within an L2R paragraph, or vice versa.
10403 (cursor_row_p): Consider the case of point being equal to
10404 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
10405 from the end of a short line to the beginning of a continued line
10406 of R2L text within L2R paragraph.
10407 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
10408 composed characters.
5980d4c6 10409
f67cdd7f
EZ
10410 * bidi.c (bidi_check_type): Use xassert.
10411 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
10412 members.
10413
bca633fb
EZ
104142011-08-23 Eli Zaretskii <eliz@gnu.org>
10415
10416 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
10417 a character.
10418
4a5885a7
CY
104192011-08-23 Chong Yidong <cyd@stupidchicken.com>
10420
10421 * nsfont.m (ns_otf_to_script): Fix typo.
10422
0902a04e
KH
104232011-08-22 Kenichi Handa <handa@m17n.org>
10424
10425 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
10426 extra slot even if the purpose is char-code-property-table.
10427
1a2e6670
EZ
104282011-08-23 Eli Zaretskii <eliz@gnu.org>
10429
8ddde651
EZ
10430 * xdisp.c (redisplay_window): When computing centering_position,
10431 account for the height of the header line. (Bug#8874)
10432
425cc014
EZ
10433 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
10434 instead of CHAR_TO_BYTE. Fixes a crash when a completion
10435 candidate is selected by the mouse, and that candidate has a
10436 composed character under the mouse.
10437
1a2e6670
EZ
10438 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
10439 coordinates reported by pos-visible-in-window-p for a composed
10440 character in column zero.
10441
8b76d6f8
SM
104422011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
10443
10444 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
10445
dac347dd
EZ
104462011-08-22 Eli Zaretskii <eliz@gnu.org>
10447
10448 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
10449 consider it a hit if to_charpos is anywhere in the range of the
10450 composed buffer positions.
10451
e013fb34
CY
104522011-08-22 Chong Yidong <cyd@stupidchicken.com>
10453
10454 * image.c (gif_load): Don't assume that each subimage has the same
10455 dimensions as the base image. Handle disposal method that is
10456 "undefined" by the gif spec (Bug#9335).
10457
bd1ba3e8
CY
104582011-08-20 Chong Yidong <cyd@stupidchicken.com>
10459
10460 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 10461 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 10462
54a1215b
EZ
104632011-08-19 Eli Zaretskii <eliz@gnu.org>
10464
823564e5
EZ
10465 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
10466 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
10467 from an Org mode buffer to a Speedbar frame.
10468
54a1215b
EZ
10469 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
10470 a composition, take its buffer position from IT->cmp_it.charpos.
10471 Fixes cursor positioning at the beginning of a line that begins
10472 with a composed character.
10473
9778ebcc
EZ
104742011-08-18 Eli Zaretskii <eliz@gnu.org>
10475
0be6ee06
EZ
10476 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
10477 character bidirectional type, use STRONG_L instead. Fixes crashes
10478 in a buffer produced by `describe-categories'.
10479
9778ebcc
EZ
10480 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
10481 members before the level stack, so they would be saved and
10482 restored when copying iterator state. Fixes incorrect reordering
10483 around TABs covered by display properties.
10484
156bffbe
AS
104852011-08-18 Andreas Schwab <schwab@linux-m68k.org>
10486
6b02f655 10487 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 10488
72ad093b
CY
104892011-08-17 Chong Yidong <cyd@stupidchicken.com>
10490
10491 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
10492 (internal_condition_case_2, internal_condition_case_n):
10493 Remove unnecessary aborts (Bug#9081).
72ad093b 10494
35774242
EZ
104952011-08-17 Eli Zaretskii <eliz@gnu.org>
10496
10497 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
10498 has no `load' handler, try opening the file locally. (Bug#9311)
10499
db76dd85
KB
105002011-08-16 Ken Brown <kbrown@cornell.edu>
10501
10502 * gmalloc.c: Expand comment.
10503
b215eee5
EZ
105042011-08-16 Eli Zaretskii <eliz@gnu.org>
10505
10506 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
10507 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
10508
a4579d33
KB
105092011-08-16 Ken Brown <kbrown@cornell.edu>
10510
10511 Fix memory allocation problems in Cygwin build (Bug#9273).
10512
10513 * unexcw.c ( __malloc_initialized): Declare external variable.
10514 (fixup_executable): Force the dumped emacs to reinitialize malloc.
10515
8b76d6f8
SM
10516 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
10517 New variables.
a4579d33
KB
10518 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
10519 dumped emacs.
10520 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
10521 in the static heap.
10522 [CYGWIN] (special_realloc): New function.
10523 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
10524 requests to realloc storage in the static heap.
10525
3ebec551
PE
105262011-08-15 Paul Eggert <eggert@cs.ucla.edu>
10527
10528 * bidi.c (bidi_initialize): Remove unused local.
10529
9fd8be00
EZ
105302011-08-15 Eli Zaretskii <eliz@gnu.org>
10531
6b02f655
SM
10532 * bidimirror.h:
10533 * biditype.h: Remove file.
10534 * makefile.w32-in ($(BLD)/bidi.$(O)):
10535 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
10536
10537 * dispextern.h: Fix a typo in the comment to bidi_type_t.
10538
10539 * chartab.c: Improve commentary for the uniprop_table API.
10540
32413314
EZ
10541 * bidi.c (bidi_paragraph_init): Support zero value of
10542 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
10543 (bidi_initialize): Use uniprop_table instead of including
10544 biditype.h and bidimirror.h.
32413314 10545
9fd8be00
EZ
10546 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
10547 coordinates of the iterator when restoring from ppos_it.
10548 (Bug#9296)
10549
5cf2b69b
KH
105502011-08-14 Kenichi Handa <handa@m17n.org>
10551
10552 * process.c (create_process): Call setup_process_coding_systems
72ad093b 10553 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 10554
daf17d00
EZ
105552011-08-14 Eli Zaretskii <eliz@gnu.org>
10556
10557 * xdisp.c (move_it_in_display_line_to): Don't invoke
10558 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
10559 ppos_it. Fixes vertical cursor motion when line beginning is
10560 covered by an image. (Bug#9296)
10561
08e3161a
JD
105622011-08-14 Jan Djärv <jan.h.d@swipnet.se>
10563
10564 * nsterm.h (ns_run_ascript): Declare.
10565 (NSAPP_DATA2_RUNASSCRIPT): Define.
10566
10567 * nsfns.m (as_script, as_result, as_status): New static variables.
10568 (ns_run_ascript): New function.
5e617bc2 10569 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
10570 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
10571 the event loop. Get status from as_status (Bug#7276).
10572
10573 * nsterm.m (sendEvent): If event is NSApplicationDefined and
10574 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
10575 the event loop (Bug#7276).
10576
a3720aa2
AS
105772011-08-14 Andreas Schwab <schwab@linux-m68k.org>
10578
10579 * gnutls.c (QCgnutls_bootprop_priority)
10580 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
10581 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
10582 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
10583 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
10584 (QCgnutls_bootprop_verify_hostname_error)
10585 (QCgnutls_bootprop_callbacks_verify): Rename from
10586 Qgnutls_bootprop_..., all uses changed.
10587
10588 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
10589 uses changed.
10590
0a0d27fb
PE
105912011-08-14 Paul Eggert <eggert@cs.ucla.edu>
10592
19d5c50c
PE
10593 * xfaces.c (Qframe_set_background_mode): Now static.
10594 * dispextern.h (Qframe_set_background_mode): Remove decl.
10595
0a0d27fb
PE
10596 * process.c (Fnetwork_interface_info): Declare local only if needed.
10597
377538cb
JD
105982011-08-13 Jan Djärv <jan.h.d@swipnet.se>
10599
10600 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
10601 (Fnetwork_interface_list): Allocate in increments of bytes instead
10602 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
10603 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
10604 sockaddr.
10605 (struct ifflag_def): notrailers is smart on OSX.
10606 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
10607 Get hardware address with getifaddrs if available.
10608
08fff70c
EZ
106092011-08-12 Eli Zaretskii <eliz@gnu.org>
10610
10611 * xdisp.c (iterate_out_of_display_property): xassert that
10612 IT->position is set to within IT->object's boundaries. Break from
10613 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
10614 when IT->position is set up wrongly due to some bug.
10615 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
10616 (push_display_prop): Allow GET_FROM_STRING as IT->method on
10617 entry. Force push_it to save on the stack the current
10618 buffer/string position, to be restored by pop_it. Fix flags in
10619 the iterator structure wrt the object coming from a display
10620 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
10621 properties. (Bug#9284)
10622
7be1c708 106232011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 10624
7be1c708
CY
10625 * fontset.c (fontset_get_font_group): Add proper type checks.
10626 (Bug#9172)
aac0c6e3 10627
7be1c708 106282011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 10629
7be1c708
CY
10630 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
10631 and LC_VERSION_MIN_MACOSX.
10632 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
10633 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 10634
97bb72a6
EZ
106352011-08-08 Eli Zaretskii <eliz@gnu.org>
10636
10637 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
10638 no-display-properties-and-no-overlays under bidi display.
10639 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 10640 properties and overlays.
97bb72a6 10641
d5617611
CY
106422011-08-08 Chong Yidong <cyd@stupidchicken.com>
10643
37e11a63
CY
10644 * editfns.c (Fset_time_zone_rule): Document relationship with the
10645 setenv function.
10646
d5617611
CY
10647 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
10648 the font entity extracted from the cache (Bug#8109).
10649
58872834
CY
106502011-08-07 Chong Yidong <cyd@stupidchicken.com>
10651
10652 * composite.c (autocmp_chars): Don't reset point. That is done by
10653 restore_point_unwind (Bug#5984).
10654
75bfc667
JL
106552011-08-07 Juri Linkov <juri@jurta.org>
10656
10657 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
10658 to show the arg `TIME' instead of `TIMEVAL'.
10659
d1410150
EZ
106602011-08-06 Eli Zaretskii <eliz@gnu.org>
10661
10662 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
10663 display property strides EOL and includes a newline, as in
10664 longlines-mode. (Bug#9254)
75b771e4
EZ
10665 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
10666 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
10667
10668 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
10669 is non-zero, even if the data buffer is NULL. Fixes a crash in
10670 vertical-motion with longlines-mode. (Bug#9254)
10671
35928349
EZ
106722011-08-05 Eli Zaretskii <eliz@gnu.org>
10673
ec7cc85b
EZ
10674 * bidi.c <bidi_cache_total_alloc>: Now static.
10675 (bidi_initialize): Initialize bidi_cache_total_alloc.
10676
8b76d6f8 10677 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
10678 cache. (Bug#9221)
10679
10680 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
10681 amount allocated this far in `bidi_cache_total_alloc'.
10682 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
10683 non-zero, only free the data buffer without restoring the cache
10684 contents. All callers changed.
10685
10686 * dispextern.h (bidi_unshelve_cache): Update prototype.
10687
10688 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
10689 (move_it_in_display_line, move_it_to)
10690 (move_it_vertically_backward, move_it_by_lines): Replace the call
10691 to xfree to an equivalent call to bidi_unshelve_cache.
10692 (move_it_in_display_line_to): Fix logic of returning
412b6358 10693 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 10694
e2e2423b
EZ
106952011-08-05 Eli Zaretskii <eliz@gnu.org>
10696
10697 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
10698 came from a string character with a `cursor' property. (Bug#9229)
10699
ae9e757a
JD
107002011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10701
10702 * Makefile.in (LIB_PTHREAD): New variable.
10703 (LIBES): Add LIB_PTHREAD (Bug#9216).
10704
10705 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
10706 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
10707
213bd7f2
AS
107082011-08-04 Andreas Schwab <schwab@linux-m68k.org>
10709
6b02f655 10710 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 10711
99aaf75f
JD
107122011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10713
10714 * xterm.c (x_find_topmost_parent): New function.
10715 (x_set_frame_alpha): Find topmost parent window with
10716 x_find_topmost_parent and set the property there also (bug#9181).
10717 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
10718
c74e9d86
PE
107192011-08-04 Paul Eggert <eggert@cs.ucla.edu>
10720
10721 * callproc.c (Fcall_process): Avoid vfork clobbering
10722 the local vars buffer, coding_systems, current_dir.
10723
640c8776
SM
107242011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
10725
10726 * keymap.c (Fmake_composed_keymap): Move to subr.el.
10727
f26d0e4c
PE
107282011-08-03 Paul Eggert <eggert@cs.ucla.edu>
10729
8a10d76c
PE
10730 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
10731 so that it is not optimized away.
10732
f26d0e4c
PE
10733 * xdisp.c (compute_display_string_pos): Remove unused local.
10734
55439c61
EZ
107352011-08-02 Eli Zaretskii <eliz@gnu.org>
10736
10737 Fix slow cursor motion and scrolling in large buffers with
10738 selective display, like Org Mode buffers. (Bug#9218)
10739
10740 * dispextern.h (struct bidi_it): New member disp_prop_p.
10741
10742 * xdisp.c: Remove one-slot cache of display string positions.
10743 (compute_display_string_pos): Accept an additional argument
5e617bc2 10744 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
10745 for a display string or property. If found, set DISP_PROP_P
10746 non-zero.
10747
10748 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
10749 DISP_PROP_P, and pass it to compute_display_string_pos.
10750 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
10751 non-zero. All callers of bidi_fetch_char changed.
10752
fb33fa43
SM
107532011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
10754
10755 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
10756
b099e063
DM
107572010-12-03 Don March <don@ohspite.net>
10758
10759 * keymap.c (Fdefine_key): Fix non-prefix key error message when
10760 last character M-[char] is translated to ESC [char] (bug#7541).
10761
5cc7f7af
KH
107622011-08-02 Kenichi Handa <handa@m17n.org>
10763
d0fffa3f 10764 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
10765
10766 * chartab.c (uniprop_table): Make it non-static.
10767
525d5e6e
EZ
107682011-08-01 Eli Zaretskii <eliz@gnu.org>
10769
10770 * xdisp.c (forward_to_next_line_start): Accept additional argument
10771 BIDI_IT_PREV, and store into it the state of the bidi iterator had
10772 on the newline.
10773 (reseat_at_next_visible_line_start): Use the bidi iterator state
10774 returned by forward_to_next_line_start to restore the state of
10775 it->bidi_it after backing up to previous newline. (Bug#9212)
10776
31011111
AS
107772011-07-30 Andreas Schwab <schwab@linux-m68k.org>
10778
10779 * regex.c (re_comp): Protoize.
10780 (re_exec): Fix return type.
10781 (regexec): Fix type of `ret'. (Bug#9203)
10782
476371c4
PE
107832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10784
e5d76069
PE
10785 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
10786 This is needed if max-image-size is a floating-point number.
10787
9a79b20c
AS
107882011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10789
10790 * print.c (print_object): Print empty symbol as ##.
10791
10792 * lread.c (read1): Read ## as empty symbol.
10793
d8c2fa78
AA
107942011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
10795
10796 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
10797 setting frame foreground color (Bug#9175).
10798 (x_set_background_color): Likewise.
10799
ffe57a7a
AA
10800 * nsmenu.m (-setText): Size tooltip dimensions precisely to
10801 contents (Bug#9176).
10802 (EmacsTooltip -init): Remove bezels and add shadows to
10803 tooltip windows.
10804
bf3492a5
AA
10805 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
10806 or scroll bar (Bug#8470).
10807
d55e9c53
AA
10808 * nsfont.m (nsfont_open): Remove assignment to voffset and
10809 unnecessary vars hshink, expand, hd, full_height, min_height.
10810 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
10811
10812 * nsterm.h (nsfont_info): Remove voffset field.
10813
d8c2fa78 108142011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
10815
10816 Implement strike-through and overline on NextStep (Bug#8863).
10817
10818 * nsfont.m (nsfont_open): Use underline position provided by font,
10819 instead of hard-coded value of 2.
10820 (nsfont_draw): Call ns_draw_text_decoration instead.
10821
10822 * nsterm.h: Add declaration for ns_draw_text_decoration.
10823
10824 * nsterm.m (ns_draw_text_decoration): New function for drawing
10825 underline, overline, and strike-through.
10826 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
10827 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 10828 accommodate underlining, etc.
4843aac3 10829
4cc60b9b
EZ
108302011-07-28 Eli Zaretskii <eliz@gnu.org>
10831
bc7ece87
EZ
10832 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
10833 default.
4cc60b9b 10834
476371c4
PE
108352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10836
66606eea
PE
10837 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
10838 Without this fix, if a signal arrives just after memory fills up,
10839 'malloc' might be invoked reentrantly.
10840
476371c4
PE
10841 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
10842 In other words, assume that every image size is allowed, on non-X
10843 hosts. This assumption is probably wrong, but it lets Emacs compile.
10844
f3fcc40d
AS
108452011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10846
10847 * regex.c (re_iswctype): Convert return values to boolean.
10848
350c992f
EZ
108492011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
10850
10851 * xdisp.c (compute_display_string_pos): Don't use cached display
10852 string position if the buffer had its restriction changed.
10853 (Bug#9184)
10854
5266b4bb
PE
108552011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10856
10857 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10858
2573a837 108592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 10860
41f55ccd 10861 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 10862
39e378da
PE
10863 * bidi.c: Integer size and overflow fixes.
10864 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
10865 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
10866 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10867 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
10868 (bidi_find_other_level_edge):
10869 Use ptrdiff_t instead of EMACS_INT where either will do.
10870 This works better on 32-bit hosts configured --with-wide-int.
10871 (bidi_cache_ensure_space): Check for size-calculation overflow.
10872 Use % rather than repeated addition, for better worst-case speed.
10873 Don't set bidi_cache_size until after xrealloc returns, because it
10874 might not return.
10875 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
10876 (bidi_cache_ensure_space): Also check that the bidi cache size
10877 does not exceed that of the largest Lisp string or buffer. See Eli
10878 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 10879
5e927815
PE
10880 * alloc.c (__malloc_size_t): Remove.
10881 All uses replaced by size_t. See Andreas Schwab's note
10882 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
10883
ca4aa935
PE
10884 * image.c: Improve checking for integer overflow.
10885 (check_image_size): Assume that f is nonnull, since
10886 it is always nonnull in practice. This is one less thing to
10887 worry about when checking for integer overflow later.
10888 (x_check_image_size): New function, which checks for integer
10889 overflow issues inside X.
10890 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
10891 This removes the need for a memory_full check.
10892 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
10893 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
10894 (xbm_read_bitmap_data): Change locals back to 'int', since
10895 their values must fit in 'int'.
10896 (xpm_load_image, png_load, tiff_load):
10897 Invoke x_create_x_image_and_pixmap earlier,
10898 to avoid much needless work if the image is too large.
10899 (tiff_load): Treat overly large images as if
10900 x_create_x_image_and_pixmap failed, not as malloc failures.
10901 (gs_load): Use x_check_image_size.
10902
5f8f9cc2
PE
10903 * gtkutil.c: Omit integer casts.
10904 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
10905 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
10906
5adf60bc
PE
10907 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
10908
c8907a93
PE
10909 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
10910 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
10911 would wrongly return t on a 64-bit host.
10912
e3c25c68
PE
10913 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
10914 The plain *_OVERFLOW macros run afoul of GCC bug 49705
10915 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
10916 and therefore cause GCC to emit a bogus diagnostic in some cases.
10917
3f791afe
PE
10918 * image.c: Integer signedness and overflow and related fixes.
10919 This is not an exhaustive set of fixes, but it's time to
10920 record what I've got.
10921 (lookup_pixel_color, check_image_size): Remove redundant decls.
10922 (check_image_size): Don't assume that arbitrary EMACS_INT values
10923 fit in 'int', or that arbitrary 'double' values fit in 'int'.
10924 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
10925 (tiff_load, imagemagick_load_image):
10926 Check for overflow in size calculations.
10927 (x_create_x_image_and_pixmap): Remove unnecessary test for
10928 xmalloc returning NULL; that can't happen.
10929 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
10930 (xpm_color_bucket): Use better integer hashing function.
10931 (xpm_cache_color): Don't possibly over-allocate memory.
10932 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
10933 (gif_memory_source):
10934 Use ptrdiff_t, not int or size_t, to record sizes.
10935 (png_load): Don't assume values greater than 2**31 fit in 'int'.
10936 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
10937 either works, as we prefer signed integers.
10938 (tiff_read_from_memory, tiff_write_from_memory):
10939 Return tsize_t, not size_t, since that's what the TIFF API wants.
10940 (tiff_read_from_memory): Don't fail simply because the read would
10941 go past EOF; instead, return a short read.
10942 (tiff_load): Omit no-longer-needed casts.
10943 (Fimagemagick_types): Don't assume size fits into 'int'.
10944
3cc5a532
PE
10945 Improve hashing quality when configured --with-wide-int.
10946 * fns.c (hash_string): New function, taken from sxhash_string.
10947 Do not discard information about ASCII character case; this
10948 discarding is no longer needed.
10949 (sxhash-string): Use it. Change sig to match it. Caller changed.
10950 * lisp.h: Declare it.
10951 * lread.c (hash_string): Remove, since we now use fns.c's version.
10952 The fns.c version returns a wider integer if --with-wide-int is
10953 specified, so this should help the quality of the hashing a bit.
10954
b312a492
PE
10955 * emacs.c: Integer overflow minor fix.
10956 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
10957 Define only if GNU_LINUX.
10958 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
10959
dfd153ae
PE
10960 * dispnew.c: Integer signedness and overflow fixes.
10961 Remove unnecessary forward decls, that were a maintenance hassle.
10962 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
10963 All uses changed.
10964 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
10965 (scrolling_window): Use ptrdiff_t, not int, for byte count.
10966 (prepare_desired_row, line_draw_cost):
10967 Use int, not unsigned, where either works.
10968 (save_current_matrix, restore_current_matrix):
10969 Use ptrdiff_t, not size_t, where either works.
10970 (init_display): Check for overflow more accurately, and without
10971 relying on undefined behavior.
10972
a81d11a3
PE
10973 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
10974 Remove, replacing with the new symbols in lisp.h. All uses changed.
10975 * fileio.c (make_temp_name):
10976 * filelock.c (lock_file_1, lock_file):
10977 * xdisp.c (message_dolog):
10978 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
10979 Use pMd etc. instead.
10980 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
10981 replacing the pWIDE etc. symbols removed from editfns.c.
10982
3300e6fd
PE
10983 * keyboard.h (num_input_events): Now uintmax_t.
10984 This is (very slightly) less likely to mess up due to wraparound.
10985 All uses changed.
10986
fd05c7e9
PE
10987 * buffer.c: Integer signedness fixes.
10988 (alloc_buffer_text, enlarge_buffer_text):
10989 Use ptrdiff_t rather than size_t when either will do, as we prefer
10990 signed integers.
10991
903fe15d
PE
10992 * alloc.c: Integer signedness and overflow fixes.
10993 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
10994 (__malloc_size_t): Default to size_t, not to int.
10995 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
10996 (Fgarbage_collect, mark_object_loop_halt, mark_object):
10997 Prefer ptrdiff_t to size_t when either would do, as we prefer
10998 signed integers.
10999 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
11000 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
11001 Now const. Initialize with values that are in range even if char
11002 is signed.
11003 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
11004 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
11005 These functions do the right thing with sizes > 2**32.
11006 (check_depth): Now ptrdiff_t, not int.
11007 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
11008 Adjust to new way of storing sizes. Check for size overflow bugs
11009 in rest of code.
11010 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
11011 slightly wrong anyway, as it missed one instance of
11012 XMALLOC_OVERRUN_CHECK_OVERHEAD.
11013 (refill_memory_reserve): Omit needless cast to size_t.
11014 (mark_object_loop_halt): Mark as externally visible.
11015
ac82cc6a
PE
11016 * xselect.c: Integer signedness and overflow fixes.
11017 (Fx_register_dnd_atom, x_handle_dnd_message):
11018 Use ptrdiff_t, not size_t, since we prefer signed.
11019 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
11020 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
11021 x_dnd_atoms_size and x_dnd_atoms_length.
11022
c2d1e36d
PE
11023 * doprnt.c: Prefer signed to unsigned when either works.
11024 * eval.c (verror):
11025 * doprnt.c (doprnt):
11026 * lisp.h (doprnt):
11027 * xdisp.c (vmessage):
11028 Use ptrdiff_t, not size_t, when using or implementing doprnt,
11029 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
11030 prefer signed arithmetic to avoid comparison confusion.
11031 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
11032 but is a bit tricky.
11033
0e926e56
PE
11034 Assume freestanding C89 headers, string.h, stdlib.h.
11035 * data.c, doprnt.c, floatfns.c, print.c:
11036 Include float.h unconditionally.
11037 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
11038 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
11039 * regex.c: Likewise for stddef.h, string.h.
11040 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
11041 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
11042 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
11043 (STDC_HEADERS): Remove obsolete defines.
11044 * sysdep.c: Include limits.h unconditionally.
11045
9cfdb3ec
PE
11046 Assume support for memcmp, memcpy, memmove, memset.
11047 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
11048 * regex.c (memcmp, memcpy):
11049 Remove; we assume C89 now.
11050
11051 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
11052 (__malloc_safe_bcopy): Remove; no longer needed.
11053
cf950e6b 11054 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
11055 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
11056 well either way, and we prefer signed to unsigned.
11057
dbf38e02
LMI
110582011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
11059
11060 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
11061 closes the connection while we're reading (bug#9182).
11062
d6f0886c 110632011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 11064
d6f0886c
JD
11065 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
11066 are specified (Bug#9168).
24e0f6b1 11067
2eb1f9e6
PE
110682011-07-25 Paul Eggert <eggert@cs.ucla.edu>
11069
11070 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
11071 Found by GCC static checking and --with-wide-int on a 32-bit host.
11072
22381272 110732011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
11074
11075 * xdisp.c (compute_display_string_pos): Fix logic of caching
11076 previous display string position. Initialize cached_prev_pos to
11077 -1. Fixes slow-down at the beginning of a buffer.
11078
f25e39b4
EZ
110792011-07-24 Eli Zaretskii <eliz@gnu.org>
11080
11081 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
11082 for attrs[LFACE_FONTSET_INDEX].
11083
04c4b52e
PE
110842011-07-23 Paul Eggert <eggert@cs.ucla.edu>
11085
11086 * xml.c (parse_region): Remove unused local
11087 that was recently introduced.
11088
c1734fbd
EZ
110892011-07-23 Eli Zaretskii <eliz@gnu.org>
11090
be18c5a5
EZ
11091 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
11092 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
11093
c1734fbd
EZ
11094 * xdisp.c (move_it_in_display_line_to): Record the best matching
11095 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
11096 exit if none of the characters scanned was an exact match.
11097 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
11098 when exact match is impossible due to invisible text, and the
11099 lines are truncated.
11100
a258d627
JD
111012011-07-23 Jan Djärv <jan.h.d@swipnet.se>
11102
11103 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
11104 for OSX >= 10.7.
11105
b6d5a689
EZ
111062011-07-22 Eli Zaretskii <eliz@gnu.org>
11107
0f74f785
EZ
11108 Fix a significant slow-down of cursor motion with C-n, C-p,
11109 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
11110 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 11111 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
11112 (next_element_from_buffer): Call compute_stop_pos_backwards to
11113 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
11114 base_level_stop.
11115 (reseat): Don't look for prev_stop, as that could mean a very long
11116 run.
11117 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
11118 <cached_disp_overlay_modiff>: Cache for last found display string
11119 position.
551918c1 11120 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
11121 about the same buffer in the same area of character positions, and
11122 the buffer wasn't changed since the time the display string
11123 position was cached.
551918c1 11124
b2d0c91a
EZ
111252011-07-22 Eli Zaretskii <eliz@gnu.org>
11126
11127 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
11128 is an integer, which is important for empty lines. (Bug#9149)
11129
043604ee
CY
111302011-07-22 Chong Yidong <cyd@stupidchicken.com>
11131
11132 * frame.c (Fmodify_frame_parameters): In tty case, update the
11133 default face if necessary (Bug#4238).
11134
da4adb04
CY
111352011-07-21 Chong Yidong <cyd@stupidchicken.com>
11136
11137 * editfns.c (Fstring_to_char): No need to explain what a character
11138 is in the docstring (Bug#6576).
11139
9abd0532
LMI
111402011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11141
11142 * xml.c (parse_region): Make sure we always return a tree.
11143
36881d16
HK
111442011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
11145
11146 * xml.c (parse_region): If a document contains only comments,
11147 return that, too.
11148
1e98674d
LMI
111492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11150
11151 * xml.c (make_dom): Return comments, too.
11152
590bd467
PE
111532011-07-19 Paul Eggert <eggert@cs.ucla.edu>
11154
11155 Port to OpenBSD.
11156 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
11157 and the surrounding thread.
11158 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
11159 rather than fgets, and retry after EINTR. Otherwise, 'emacs
11160 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
11161 timer goes off.
11162 * s/openbsd.h (BROKEN_SIGIO): Define.
11163 * unexelf.c (unexec) [__OpenBSD__]:
11164 Don't update the .mdebug section of the Alpha COFF symbol table.
11165
f41628b2
LMI
111662011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
11167
11168 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
11169 (bug#8460).
11170
b59b67c5
PE
111712011-07-18 Paul Eggert <eggert@cs.ucla.edu>
11172
15e3a074
PE
11173 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
11174 This fixes some race conditions on the permissions of any newly
11175 created file.
11176
41bed37d
PE
11177 * alloc.c (valid_pointer_p): Use pipe, not open.
11178 This fixes some permissions issues when debugging.
11179
b59b67c5
PE
11180 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
11181 If fchown fails to set both uid and gid, try to set just gid,
11182 as that is sometimes allowed. Adjust the file's mode to eliminate
11183 setuid or setgid bits that are inappropriate if fchown fails.
11184
925a6be7
SM
111852011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
11186
11187 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
11188 to compare Lisp_Objects.
11189 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
11190 global_gnutls_log_level, don't mistake it for a Lisp_Object.
11191 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
11192
52968808
AS
111932011-07-17 Andreas Schwab <schwab@linux-m68k.org>
11194
0a6a104b
AS
11195 * lread.c (read_integer): Unread even EOF character.
11196 (read1): Likewise. Properly record start position of symbol.
11197
52968808
AS
11198 * lread.c (read1): Read `#:' as empty uninterned symbol if no
11199 symbol character follows.
11200
9e381cdd
PE
112012011-07-17 Paul Eggert <eggert@cs.ucla.edu>
11202
11203 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
11204 This works around a problem with the previous change to Fcopy_file.
11205 Recent glibc declares fchown with __attribute__((warn_unused_result)),
11206 and without this change, GCC might complain about discarding
11207 fchown's return value.
11208
b5641435
JB
112092011-07-16 Juanma Barranquero <lekktu@gmail.com>
11210
11211 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
11212
a8031457
PE
112132011-07-16 Paul Eggert <eggert@cs.ucla.edu>
11214
11215 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
11216
dd889327
LMI
112172011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
11218
750c33f7
LMI
11219 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
11220 it's used from the C level.
11221
dd889327
LMI
11222 * process.c: Use the same condition for POLL_FOR_INPUT in both
11223 keyboard.c and process.c (bug#1858).
11224
87e86684
LM
112252011-07-09 Lawrence Mitchell <wence@gmx.li>
11226
11227 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
11228 (Fgnutls_boot): Use it.
11229
64348f40
AS
112302011-07-15 Andreas Schwab <schwab@linux-m68k.org>
11231
11232 * doc.c (Fsubstitute_command_keys): Revert last change.
11233
1d698799
LMI
112342011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
11235
f863868c
LMI
11236 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
11237 quotes the next character, and doesn't affect other longer
11238 sequences (bug#8935).
11239
1d698799
LMI
11240 * lread.c (syms_of_lread): Clarify that is isn't only
11241 `eval-buffer' and `eval-defun' that's affected by
11242 `lexical-binding' (bug#8460).
11243
aa4b6df6
EZ
112442011-07-15 Eli Zaretskii <eliz@gnu.org>
11245
11246 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 11247 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 11248
5d856da6
PE
112492011-07-14 Paul Eggert <eggert@cs.ucla.edu>
11250
ad6042bb
PE
11251 Fix minor problems found by static checking.
11252 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
11253 (elsz): Now a signed constant, not a size_t var. We prefer signed
11254 types to unsigned, to avoid integer comparison confusion. Without
11255 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
11256 "cannot optimize loop, the loop counter may overflow", a symptom
11257 of the confusion.
f00bbb22 11258 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
11259 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
11260
6468f31c
LMI
112612011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
11262
49080b10
LMI
11263 * search.c (Fre_search_backward): Mention `case-fold-search' in
11264 all the re_search_* functions (bug#8138).
11265
6468f31c
LMI
11266 * keyboard.c (Fopen_dribble_file): Document when the file is
11267 closed (bug#8056).
11268
c965adc5
EZ
112692011-07-14 Eli Zaretskii <eliz@gnu.org>
11270
df9733bf
EZ
11271 * bidi.c (bidi_dump_cached_states): Fix format of displaying
11272 bidi_cache_idx.
11273
0bb23927
EZ
11274 Support bidi reordering of display and overlay strings.
11275 * xdisp.c (compute_display_string_pos)
11276 (compute_display_string_end): Accept additional argument STRING.
11277 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
11278 (reseat_to_string): Initialize bidi_it->string.s and
11279 bidi_it->string.schars.
11280 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
11281 NULL (avoids a crash in bidi_paragraph_init).
11282 Initialize itb.string.lstring.
0bb23927
EZ
11283 (init_iterator): Call bidi_init_it only of a valid
11284 buffer position was specified. Initialize paragraph_embedding to
11285 L2R.
11286 (reseat_to_string): Initialize the bidi iterator.
11287 (display_string): If we need to ignore text properties of
11288 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
11289 original value of -1 will not work with bidi.)
11290 (compute_display_string_pos): First arg is now struct
11291 `text_pos *'; all callers changed. Support display properties on
11292 Lisp strings.
11293 (compute_display_string_end): Support display properties on Lisp
11294 strings.
11295 (init_iterator, reseat_1, reseat_to_string): Initialize the
11296 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
11297 when iterating on a string not from display properties).
640c8776
SM
11298 (compute_display_string_pos, compute_display_string_end):
11299 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
11300 arrow keys.
11301 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
11302 base_level_stop; instead, set base_level_stop to BEGV.
11303 Fixes crashes in vertical-motion.
0bb23927
EZ
11304 (next_element_from_buffer): Improve commentary for when
11305 the iterator is before prev_stop.
11306 (init_iterator): Initialize bidi_p from the default value of
11307 bidi-display-reordering, not from buffer-local value. Use the
11308 buffer-local value only if initializing for buffer iteration.
11309 (handle_invisible_prop): Support invisible properties on strings
11310 that are being bidi-reordered.
11311 (set_iterator_to_next): Support bidi reordering of C strings and
11312 Lisp strings.
11313 (next_element_from_string): Support bidi reordering of Lisp
11314 strings.
11315 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
11316 (display_string): Support display of R2L glyph rows.
11317 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
11318 (init_iterator): Don't initialize it->bidi_p for strings
11319 here.
11320 (reseat_to_string): Initialize it->bidi_p for strings here.
11321 (next_element_from_string, next_element_from_c_string)
11322 (next_element_from_buffer): Add xassert's for correspondence
11323 between IT's object being iterated and it->bidi_it.string
11324 structure.
11325 (face_before_or_after_it_pos): Support bidi iteration.
11326 (next_element_from_c_string): Handle the case of the first string
11327 character that is not the first one in the visual order.
11328 (get_visually_first_element): New function, refactored from common
11329 parts of next_element_from_buffer, next_element_from_string, and
11330 next_element_from_c_string.
11331 (tool_bar_lines_needed, redisplay_tool_bar)
11332 (display_menu_bar): Force left-to-right direction. Add a FIXME
11333 comment for making that be controlled by a user option.
11334 (push_it, pop_it): Save and restore the state of the
11335 bidi iterator. Save and restore the bidi_p flag.
11336 (pop_it): Iterate out of display property for string iteration as
11337 well.
11338 (iterate_out_of_display_property): Support iteration over strings.
11339 (handle_single_display_spec): Set up it->bidi_it for iteration
11340 over a display string, and call bidi_init_it.
11341 (handle_single_display_spec, next_overlay_string)
11342 (get_overlay_strings_1, push_display_prop): Set up the bidi
11343 iterator for displaying display or overlay strings.
11344 (forward_to_next_line_start): Don't use the shortcut if
11345 bidi-iterating.
11346 (back_to_previous_visible_line_start): If handle_display_prop
11347 pushed the iterator stack, restore the internal state of the bidi
11348 iterator by calling bidi_pop_it same number of times.
11349 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
11350 and we are bidi-iterating, don't decrement the iterator position;
11351 instead, set the first_elt flag in the bidi iterator, to produce
11352 the same effect.
11353 (reseat_1): Remove redundant setting of string_from_display_prop_p.
11354 (push_display_prop): xassert that we are iterating a buffer.
11355 (push_it, pop_it): Save and restore paragraph_embedding member.
11356 (handle_single_display_spec, next_overlay_string)
11357 (get_overlay_strings_1, reseat_1, reseat_to_string)
11358 (push_display_prop): Set up the `unibyte' member of bidi_it.string
11359 correctly. Don't assume unibyte strings are not bidi-reordered.
11360 (compute_display_string_pos)
11361 (compute_display_string_end): Fix handling the case of C string.
11362 (push_it, pop_it): Save and restore from_disp_prop_p.
11363 (handle_single_display_spec, push_display_prop): Set the
11364 from_disp_prop_p flag.
11365 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
11366 (pop_it): Call iterate_out_of_display_property only if we are
11367 popping after iteration over a string that came from a display
11368 property. Fix a typo in popping stretch info. Add an assertion
11369 for verifying that the iterator position is in sync with the bidi
11370 iterator.
11371 (handle_single_display_spec, get_overlay_strings_1)
11372 (push_display_prop): Fix initialization of paragraph direction for
11373 string when that of the parent object is not yet determined.
11374 (reseat_1): Call bidi_init_it to resync the bidi
11375 iterator with IT's position. (Bug#7616)
11376 (find_row_edges): If ROW->start.pos gives position
11377 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
11378 (handle_stop, back_to_previous_visible_line_start, reseat_1):
11379 Reset the from_disp_prop_p flag.
11380 (SAVE_IT, RESTORE_IT): New macros.
11381 (pos_visible_p, face_before_or_after_it_pos)
11382 (back_to_previous_visible_line_start)
11383 (move_it_in_display_line_to, move_it_in_display_line)
11384 (move_it_to, move_it_vertically_backward, move_it_by_lines)
11385 (try_scrolling, redisplay_window, display_line): Use them when
11386 saving a temporary copy of the iterator and restoring it back.
11387 (back_to_previous_visible_line_start, reseat_1)
11388 (init_iterator): Empty the bidi cache "stack".
11389 (move_it_in_display_line_to): If iterator ended up at
11390 EOL, but we never saw any buffer positions smaller than
11391 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
11392 motion in bidi-reordered lines.
11393 (move_it_in_display_line_to): Record prev_method and prev_pos
11394 immediately before the call to set_iterator_to_next. Fixes cursor
11395 motion in bidi-reordered lines with stretch glyphs and strings
11396 displayed in margins. (Bug#8133) (Bug#8867)
11397 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
11398 TO_CHARPOS.
640c8776
SM
11399 (pos_visible_p): Support positions in bidi-reordered lines.
11400 Save and restore bidi cache.
0bb23927
EZ
11401
11402 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
11403 (bidi_paragraph_info): Delete unused struct.
11404 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
11405 (bidi_cache_start): New variable.
11406 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
11407 to zero.
11408 (bidi_cache_fetch_state, bidi_cache_search)
11409 (bidi_cache_find_level_change, bidi_cache_iterator_state)
11410 (bidi_cache_find, bidi_peek_at_next_level)
11411 (bidi_level_of_next_char, bidi_find_other_level_edge)
11412 (bidi_move_to_visually_next): Compare cache index with
11413 bidi_cache_start rather than with zero.
11414 (bidi_fetch_char): Accept new argument STRING; all callers
11415 changed. Support iteration over a string. Support strings with
11416 display properties. Support unibyte strings. Fix the type of
11417 `len' according to what STRING_CHAR_AND_LENGTH expects.
11418 (bidi_paragraph_init, bidi_resolve_explicit_1)
11419 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
11420 (bidi_level_of_next_char, bidi_move_to_visually_next):
11421 Support iteration over a string.
0bb23927
EZ
11422 (bidi_set_sor_type, bidi_resolve_explicit_1)
11423 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
11424 can now be zero (for strings); special values 0 and -1 were
11425 changed to -1 and -2, respectively.
11426 (bidi_char_at_pos): New function.
11427 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
11428 Call it instead of FETCH_MULTIBYTE_CHAR.
11429 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
11430 initialized to valid values.
11431 (bidi_init_it): Don't initialize charpos and bytepos with invalid
11432 values.
11433 (bidi_level_of_next_char): Allow the sentinel "position" to pass
11434 the test for valid cached positions. Fix the logic for looking up
11435 the sentinel state in the cache. GCPRO the Lisp string we are
11436 iterating.
11437 (bidi_push_it, bidi_pop_it): New functions.
11438 (bidi_initialize): Initialize the bidi cache start stack pointer.
11439 (bidi_cache_ensure_space): New function, refactored from part of
11440 bidi_cache_iterator_state. Don't assume the required size is just
11441 one BIDI_CACHE_CHUNK away.
11442 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
11443 (bidi_count_bytes, bidi_char_at_pos): New functions.
11444 (bidi_cache_search): Don't assume bidi_cache_last_idx is
11445 always valid if bidi_cache_idx is valid.
11446 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
11447 is valid if it's going to be used.
11448 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
11449 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
11450 (bidi_cache_find_level_change, bidi_cache_ensure_space)
11451 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
11452 (bidi_find_other_level_edge, bidi_cache_start_stack):
11453 All variables related to cache indices are now EMACS_INT.
c965adc5 11454
0bb23927
EZ
11455 * dispextern.h (struct bidi_string_data): New structure.
11456 (struct bidi_it): New member `string'. Make flag members be 1-bit
11457 fields, and put them last in the struct.
640c8776
SM
11458 (compute_display_string_pos, compute_display_string_end):
11459 Update prototypes.
0bb23927
EZ
11460 (bidi_push_it, bidi_pop_it): Add prototypes.
11461 (struct iterator_stack_entry): New members bidi_p,
11462 paragraph_embedding, and from_disp_prop_p.
11463 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
11464 (bidi_shelve_cache, bidi_unshelve_cache):
11465 Declare prototypes.
0bb23927
EZ
11466
11467 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
11468 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
11469 and vector-like objects.
11470
11471 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
11472 cache around display iteration.
11473
11474 * window.c (Fwindow_end, window_scroll_pixel_based)
11475 (displayed_window_lines, Frecenter): Save and restore the bidi
11476 cache around display iteration.
11477
3bbd2265
LMI
114782011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
11479
11480 * editfns.c (Fdelete_region): Clarify the use of the named
11481 parameters (bug#6788).
11482
adc47434
MR
114832011-07-14 Martin Rudalics <rudalics@gmx.at>
11484
11485 * indent.c (Fvertical_motion): Set and restore w->pointm when
11486 saving and restoring the window's buffer (Bug#9006).
11487
837c31f8
LMI
114882011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
11489
11490 * editfns.c (Fstring_to_char): Clarify just what is returned
11491 (bug#6576). Text by Eli Zaretskii.
11492
ac389d0c
JB
114932011-07-13 Juanma Barranquero <lekktu@gmail.com>
11494
11495 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
11496
0be0ce47
EZ
114972011-07-13 Eli Zaretskii <eliz@gnu.org>
11498
11499 * buffer.c (mmap_find): Fix a typo.
11500
cd18e7e3
JB
115012011-07-13 Johan Bockgård <bojohan@gnu.org>
11502
11503 Fix execution of x selection hooks.
11504 * xselect.c (Qx_lost_selection_functions)
11505 (Qx_sent_selection_functions): New vars.
11506 (syms_of_xselect): DEFSYM them.
11507 (x_handle_selection_request): Pass Qx_sent_selection_functions
11508 rather than Vx_sent_selection_functions to Frun_hook_with_args.
11509 (x_handle_selection_clear,x_clear_frame_selections):
11510 Pass Qx_lost_selection_functions rather than
11511 Vx_lost_selection_functions to Frun_hook_with_args.
11512
47ea7f44
PE
115132011-07-13 Paul Eggert <eggert@cs.ucla.edu>
11514
ac389d0c 11515 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
11516 The old code sometimes used this field without initializing it.
11517
47ea7f44
PE
11518 * alloc.c (gc_sweep): Don't read past end of array.
11519 In theory, the old code could also have corrupted Emacs internals,
11520 though it'd be very unlikely.
11521
bc985c87
AS
115222011-07-12 Andreas Schwab <schwab@linux-m68k.org>
11523
11524 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 11525 argument. (Bug#4026)
bc985c87 11526
0cf34688
LMI
115272011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
11528
b3dadd76
LMI
11529 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
11530 key" (bug#4257).
11531
0cf34688
LMI
11532 * window.c (Fset_window_start): Doc fix (bug#4199).
11533 (Fset_window_hscroll): Ditto.
11534
270768cd
PE
115352011-07-12 Paul Eggert <eggert@cs.ucla.edu>
11536
077e3dda 11537 Fix minor new problems caught by GCC 4.6.1.
270768cd 11538 * term.c (init_tty): Remove unused local.
490011a6 11539 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 11540 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 11541 not used otherwise.
270768cd 11542
b1f58454
CY
115432011-07-12 Chong Yidong <cyd@stupidchicken.com>
11544
11545 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
11546
22b9578d
LMI
115472011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
11548
6e70ab07
LMI
11549 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
11550 are the mini-buffer and the echo area (bug#3320).
11551
22b9578d
LMI
11552 * term.c (init_tty): Remove support for supdup, c10 and perq
11553 terminals, which are no longer supported (bug#1482).
11554
8974cc9f
JB
115552011-07-10 Johan Bockgård <bojohan@gnu.org>
11556
11557 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
11558
a560d974
JD
115592011-07-10 Jan Djärv <jan.h.d@swipnet.se>
11560
11561 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
11562 for non-popups (Bug#3642).
11563
1dae0f0a
AS
115642011-07-10 Andreas Schwab <schwab@linux-m68k.org>
11565
268c2c36 11566 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 11567 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
11568 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
11569 * cm.c (losecursor): Likewise.
1dae0f0a
AS
11570 * data.c (fmod): Likewise.
11571 * dispnew.c (swap_glyphs_in_rows): Likewise.
11572 * emacs.c (memory_warning_signal): Likewise.
11573 * floatfns.c (float_error): Likewise.
11574 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
11575 (otf_open, font_otf_capability, generate_otf_features)
11576 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
11577 Likewise.
11578 * image.c (pbm_read_file): Likewise.
11579 * indent.c (string_display_width): Likewise.
11580 * intervals.c (check_for_interval, search_for_interval)
11581 (inc_interval_count, count_intervals, root_interval)
11582 (adjust_intervals_for_insertion, make_new_interval): Likewise.
11583 * lread.c (defalias): Likewise.
268c2c36 11584 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
11585 * regex.c (set_image_of_range_1, set_image_of_range)
11586 (regex_grow_registers): Likewise.
11587 * sysdep.c (strerror): Likewise.
11588 * termcap.c (valid_filename_p, tprint, main): Likewise.
11589 * tparam.c (main): Likewise.
11590 * unexhp9k800.c (run_time_remap, save_data_space)
11591 (update_file_ptrs, read_header, write_header, calculate_checksum)
11592 (copy_file, copy_rest, display_header): Likewise.
11593 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
11594 Likewise.
11595 * xdisp.c (check_it): Likewise.
11596 * xfaces.c (register_color, unregister_color, unregister_colors):
11597 Likewise.
11598 * xfns.c (print_fontset_result): Likewise.
11599 * xrdb.c (member, fatal, main): Likewise.
11600
99033785
PE
116012011-07-10 Paul Eggert <eggert@cs.ucla.edu>
11602
11603 Fix minor problems found by static checking (Bug#9031).
11604 * chartab.c (char_table_set_range, map_sub_char_table):
11605 Remove unused locals.
11606 (uniprop_table): Now static.
11607 * composite.c (_work_char): Remove unused static var.
11608
9cb2ac56
JB
116092011-07-09 Juanma Barranquero <lekktu@gmail.com>
11610
11611 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
11612
f25661f0
JD
116132011-07-09 Jan Djärv <jan.h.d@swipnet.se>
11614
11615 * gtkutil.c (qttip_cb): Remove code without function.
11616
8278c4fe
EZ
116172011-07-09 Eli Zaretskii <eliz@gnu.org>
11618
11619 * w32.c (pthread_sigmask): New stub.
11620
1692ae2d 116212011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 11622
8a6ebd58 11623 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
11624 sigprocmask is portable only for single-threaded applications, and
11625 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
11626 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
11627 (LIBES): Use it.
11628 * callproc.c (Fcall_process):
11629 * process.c (create_process):
11630 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
11631 Use pthread_sigmask, not sigprocmask.
123403e4 11632
1b854618
JD
116332011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11634
11635 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
11636 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
11637 wrong (Bug#8591).
11638
3fe4b549
JD
116392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11640
0ce7e563
JD
11641 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
11642 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
11643 (xg_hide_tooltip): Fix comment.
11644
3fe4b549
JD
11645 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
11646 in registerServicesMenuSendTypes.
11647 (validRequestorForSendType): Don't check ns_return_types.
11648
11649 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
11650 ns_return_type.
11651
5df75e47
JR
116522011-07-08 Jason Rumney <jasonr@gnu.org>
11653
22610910
JR
11654 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
11655 SH_SHOW for hidden windows (Bug#5482).
11656
5df75e47
JR
11657 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
11658 frame struct members of non-existent frames (Bug#6284).
11659
699c10bd
JD
116602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11661
4393663b
JD
11662 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
11663 variable firstTime not needed on OSX >= 10.6.
11664 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
11665 >= 10.5. Use setKnobProportion, setDoubleValue.
11666
11667 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
11668 (MAC_OS_X_VERSION_10_5): Define if not defined.
11669 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
11670 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
11671 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
11672
11673 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 11674 cString and lossyCString on OSX >= 10.4.
4393663b 11675
58179cce 11676 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
11677 sizeToFit on OSX >= 10.2.
11678
11679 * nsimage.m (allocInitFromFile): Don't use deprecated method
11680 bestRepresentationForDevice on OSX >= 10.6.
11681
11682 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
11683 to avoid warning.
11684
11685 * emacs.c: Declare unexec_init_emacs_zone.
11686
a63e0781
JD
11687 * nsgui.h: Fix compiler warning about gnulib redefining verify.
11688
699c10bd
JD
11689 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
11690
11691 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
11692 on svcsMenu (Bug#8842).
11693
11694 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
11695 ns_return_types.
11696 (Fns_list_services): Just return Qnil on 10.6, code not working there.
11697
11698 * nsterm.m (QUTF8_STRING): Declare.
11699 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
11700 (validRequestorForSendType): Return type is (id).
11701 Change indexOfObjectIdenticalTo to indexOfObject.
11702 Check if we have local selection before returning self (Bug#8842).
11703 (writeSelectionToPasteboard): Put local selection into paste board
11704 if we have a local selection (Bug#8842).
11705 (syms_of_nsterm): DEFSYM QUTF8_STRING.
11706
11707 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
11708 (ns_get_local_selection): Declare.
11709
54e10184
LMI
117102011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
11711
9888ff71
LMI
11712 * keymap.c (describe_map_tree): Don't insert a double newline at
11713 the end of the buffer (bug#1169) and return whether we inserted
11714 something.
11715
54e10184
LMI
11716 * callint.c (Fcall_interactively): Change "reading args" to
11717 "providing args" to try to clarify what it does (bug#1010).
11718
15fa4783
KH
117192011-07-07 Kenichi Handa <handa@m17n.org>
11720
11721 * composite.c (composition_compute_stop_pos): Ignore a static
11722 composition starting before CHARPOS (Bug#8915).
11723
11724 * xdisp.c (handle_composition_prop): Likewise.
11725
a8815b00
EZ
117262011-07-07 Eli Zaretskii <eliz@gnu.org>
11727
11728 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
11729 (Bug#9015)
11730
ef7b981d 117312011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
11732
11733 * character.h (unicode_category_t): New enum type.
11734
11735 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
11736 (Qchar_code_property_table): New variable.
11737 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
11738 (UNIPROP_COMPRESSED_FORM_P): New macros.
11739 (char_table_ascii): Uncompress the compressed values.
11740 (sub_char_table_ref): New arg is_uniprop. Callers changed.
11741 Uncompress the compressed values.
ac389d0c 11742 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
11743 (char_table_ref_and_range): Uncompress the compressed values.
11744 (sub_char_table_set): New arg is_uniprop. Callers changed.
11745 Uncompress the compressed values.
11746 (sub_char_table_set_range): Args changed. Callers changed.
11747 (char_table_set_range): Adjuted for the above change.
11748 (map_sub_char_table): Delete args default_val and parent. Add arg
11749 top. Give decoded values to a Lisp function.
640c8776 11750 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
11751 values to a Lisp function. Gcpro more variables.
11752 (uniprop_table_uncompress)
11753 (uniprop_decode_value_run_length): New functions.
11754 (uniprop_decoder, uniprop_decoder_count): New variables.
11755 (uniprop_get_decoder, uniprop_encode_value_character)
11756 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
11757 New functions.
11758 (uniprop_encoder, uniprop_encoder_count): New variables.
11759 (uniprop_get_encoder, uniprop_table)
11760 (Funicode_property_table_internal, Fget_unicode_property_internal)
11761 (Fput_unicode_property_internal): New functions.
11762 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
11763 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 11764 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
11765 char-code-property-alist.
11766
640c8776 11767 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
11768 Vunicode_category_table.
11769
640c8776 11770 * font.c (font_range): Adjust for the change of
c805dec0
KH
11771 Vunicode_category_table.
11772
76b397fb
DN
117732011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
11774
11775 * m/iris4d.h: Remove file, move contents ...
11776 * s/irix6-5.h: ... here.
11777
22b4128e
PE
117782011-07-06 Paul Eggert <eggert@cs.ucla.edu>
11779
11780 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
11781 * alloc.c (mark_buffer):
11782 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
11783 (clone_per_buffer_values): Don't assume that
22b4128e
PE
11784 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
11785 This isn't true in general, and it's particularly not true
11786 if Emacs is configured with --with-wide-int.
11787 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
11788 New macros, used in the buffer.c change.
11789
869795d6
JD
117902011-07-05 Jan Djärv <jan.h.d@swipnet.se>
11791
11792 * xsettings.c: Use both GConf and GSettings if both are available.
11793 (store_config_changed_event): Add comment.
11794 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
11795 (store_tool_bar_style_changed): New functions.
5e617bc2 11796 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
11797 (struct xsettings): Move font inside HAVE_XFT.
11798 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 11799 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 11800 Move inside HAVE_XFT.
640c8776 11801 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
11802 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
11803 also.
11804 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 11805 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 11806 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
11807 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
11808 (parse_settings): Move check for font inside HAVE_XFT.
11809 (read_settings, apply_xft_settings): Add comment.
11810 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
11811 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
11812 call store_font_name_changed.
11813 (xft_settings_event): Add comment.
11814 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
11815 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
11816 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
11817 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
11818 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
11819 (xsettings_get_system_font, xsettings_get_system_normal_font):
11820 Add comment.
869795d6 11821
d8ed26bd
PE
118222011-07-05 Paul Eggert <eggert@cs.ucla.edu>
11823
11824 Random fixes. E.g., (random) never returned negative values.
11825 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
11826 subseconds part to the entropy, as that's a bit more random.
11827 Prefer signed to unsigned, since the signedness doesn't matter and
11828 in general we prefer signed. When given a limit, use a
11829 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
11830 latter isn't right if USE_2_TAGS_FOR_INTS.
11831 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
11832 not 0..VALMASK. Don't discard "excess" bits that random () returns.
11833
cabf1cac
SM
118342011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
11835
11836 * textprop.c (text_property_stickiness):
11837 Obey Vtext_property_default_nonsticky.
11838 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
11839 * w32fns.c (syms_of_w32fns):
11840 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
11841
6e9b2be9
PE
118422011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11843
11844 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
11845 This is more efficient than Ffile_directory_p and avoids a minor race.
11846
90186c68
LMI
118472011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
11848
7c301272
LMI
11849 * buffer.c (Foverlay_put): Say what the return value is
11850 (bug#7835).
11851
c4f2d8d4
LMI
11852 * fileio.c (barf_or_query_if_file_exists): Check first if the file
11853 is a directory before asking whether to use the file name
11854 (bug#7564).
ad637907
LMI
11855 (barf_or_query_if_file_exists): Make the "File is a directory"
11856 error be more correct.
c4f2d8d4 11857
90186c68
LMI
11858 * fns.c (Frequire): Remove the mention of the .gz files, since
11859 that's installation-specific, but keep the mention of
11860 `get-load-suffixes'.
11861
da64016e
PE
118622011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11863
11864 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
11865 Report string overflow if the output is too long.
11866
7d47b580
JB
118672011-07-04 Juanma Barranquero <lekktu@gmail.com>
11868
a555cb87
JB
11869 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
11870 (syms_of_gnutls): Remove duplicate DEFSYM for
11871 Qgnutls_bootprop_verify_hostname_error, an error for
11872 Qgnutls_bootprop_verify_error (which is no longer used).
11873
7d47b580
JB
11874 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
11875 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
11876 Also (re)move comments that are misplaced or no longer relevant.
11877
1e49bfab
LMI
118782011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11879
11880 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
11881
1485f4c0
CY
118822011-07-03 Chong Yidong <cyd@stupidchicken.com>
11883
11884 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
11885 and background color parameters if they have been changed.
11886
a9ab721e
LMI
118872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11888
11889 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
11890
cf7cff57
PE
118912011-07-03 Paul Eggert <eggert@cs.ucla.edu>
11892
2e13213d
PE
11893 * xsettings.c (SYSTEM_FONT): Define only when used.
11894 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
11895
cf7cff57
PE
11896 * keymap.c (access_keymap_1): Now static.
11897
7a8e04f7
CY
118982011-07-02 Chong Yidong <cyd@stupidchicken.com>
11899
11900 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
11901 leave any prefix arg for the up event (Bug#1586).
11902
61352f62
LMI
119032011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
11904
69bb1ef7
LMI
11905 * lread.c (syms_of_lread): Mention single symbols defined by
11906 `defvar' or `defconst' (bug#7154).
11907
61352f62 11908 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 11909 (Frequire): Mention get-load-suffixes.
61352f62 11910
28545e04
MR
119112011-07-02 Martin Rudalics <rudalics@gmx.at>
11912
11913 * window.h (window): Remove clone_number slot.
11914 * window.c (Fwindow_clone_number, Fset_window_clone_number):
11915 Remove.
11916 (make_parent_window, make_window, saved_window)
11917 (Fset_window_configuration, save_window_save): Don't deal with
11918 clone numbers.
11919 * buffer.c (Qclone_number): Remove declaration.
11920 (sort_overlays, overlay_strings): Don't deal with clone numbers.
11921
3349e122
SM
119222011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
11923
11924 Add multiple inheritance to keymaps.
11925 * keymap.c (Fmake_composed_keymap): New function.
11926 (Fset_keymap_parent): Simplify.
11927 (fix_submap_inheritance): Remove.
11928 (access_keymap_1): New function extracted from access_keymap to handle
11929 embedded parents and handle lists of maps.
11930 (access_keymap): Use it.
11931 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
11932 (Fcopy_keymap): Handle embedded parents.
11933 (Fcommand_remapping, define_as_prefix): Simplify.
11934 (Fkey_binding): Simplify.
11935 (syms_of_keymap): Move minibuffer-local-completion-map,
11936 minibuffer-local-filename-completion-map,
11937 minibuffer-local-must-match-map, and
11938 minibuffer-local-filename-must-match-map to Elisp.
11939 (syms_of_keymap): Defsubr make-composed-keymap.
11940 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
11941 (parse_menu_item): Trivial simplification.
11942
3279eb87
GM
119432011-07-01 Glenn Morris <rgm@gnu.org>
11944
11945 * Makefile.in (SETTINGS_LIBS): Fix typo.
11946
39cb9e56 119472011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
11948
11949 * coding.c (Fencode_coding_string): Record the last coding system
11950 used, as the function doc string says (bug#8738).
11951
0949d2b6
JD
119522011-07-01 Jan Djärv <jan.h.d@swipnet.se>
11953
11954 * xsettings.c (store_monospaced_changed): Take new font as arg and
11955 check for change against current_mono_font.
11956 (EMACS_TYPE_SETTINGS): Remove this and related defines.
11957 (emacs_settings_constructor, emacs_settings_get_property)
11958 (emacs_settings_set_property, emacs_settings_class_init)
11959 (emacs_settings_init, gsettings_obj): Remove.
11960 (something_changedCB): New function for HAVE_GSETTINGS.
11961 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
11962 with value as argument.
11963 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
11964 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 11965 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
11966 "changed".
11967
11968 * xgselect.c: Add defined (HAVE_GSETTINGS).
11969 (xgselect_initialize): Ditto.
11970
11971 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
11972 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
11973 xg_select.
11974
bbc6b304
PE
119752011-07-01 Paul Eggert <eggert@cs.ucla.edu>
11976
11977 * eval.c (struct backtrace): Simplify and port the data structure.
11978 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
11979 signed bit field, as this assumption is not portable and it makes
11980 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
11981 "char debug_on_exit : 1" as this is not portable either; instead,
11982 use the portable "unsigned int debug_on_exit : 1". Remove unused
11983 member evalargs. Remove obsolete comments about cc bombing out.
11984
9851bfc5
JD
119852011-06-30 Jan Djärv <jan.h.d@swipnet.se>
11986
51bb811f 11987 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
11988 Let HAVE_GSETTINGS override HAVE_GCONF.
11989 (store_monospaced_changed): New function.
11990 (EMACS_SETTINGS): A new type derived from GObject to handle
11991 GSettings notifications.
11992 (emacs_settings_constructor, emacs_settings_get_property)
11993 (emacs_settings_set_property, emacs_settings_class_init):
11994 New functions.
11995 (gsettings_client, gsettings_obj): New variables.
11996 (GSETTINGS_SCHEMA): New define.
11997 (something_changedCB): Call store_monospaced_changed.
11998 (init_gsettings): New function.
11999 (xsettings_initialize): Call init_gsettings.
12000 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
12001 to NULL.
12002
640c8776 12003 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
12004 GCONF_CFLAGS/LIBS.
12005
5386012d
MR
120062011-06-29 Martin Rudalics <rudalics@gmx.at>
12007
12008 * window.c (resize_root_window, grow_mini_window)
12009 (shrink_mini_window): Rename Qresize_root_window to
12010 Qwindow_resize_root_window and Qresize_root_window_vertically to
12011 Qwindow_resize_root_window_vertically.
12012
f13e0b08
PE
120132011-06-28 Paul Eggert <eggert@cs.ucla.edu>
12014
12015 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
12016
94515237
JB
120172011-06-27 Juanma Barranquero <lekktu@gmail.com>
12018
12019 * makefile.w32-in: Redesign dependencies so they reflect more
12020 clearly which files are directly included by each source file,
12021 and not through other includes.
12022
e43b6e43
MR
120232011-06-27 Martin Rudalics <rudalics@gmx.at>
12024
12025 * buffer.c (Qclone_number): Declare static and DEFSYM it.
12026 (sort_overlays, overlay_strings): When an overlay's clone number
12027 matches the window's clone number process the overlay even if
12028 the overlay's window property doesn't match the current window.
12029
d68443dc
MR
12030 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
12031 (Fwindow_hchild): Rename to Fwindow_left_child.
12032 (Fwindow_next): Rename to Fwindow_next_sibling.
12033 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
12034 (resize_window_check): Rename to window_resize_check.
12035 (resize_window_apply): Rename to window_resize_apply.
12036 (Fresize_window_apply): Rename to Fwindow_resize_apply.
12037 (Fdelete_other_windows_internal, resize_frame_windows)
12038 (Fsplit_window_internal, Fdelete_window_internal)
12039 (grow_mini_window, shrink_mini_window)
12040 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 12041
c7e73be5
JD
120422011-06-26 Jan Djärv <jan.h.d@swipnet.se>
12043
12044 * emacsgtkfixed.h: State that this is only used with Gtk+3.
12045 (emacs_fixed_set_min_size): Remove.
12046 (emacs_fixed_new): Take frame as argument.
12047
12048 * emacsgtkfixed.c: State that this is only used with Gtk+3.
12049 (_EmacsFixedPrivate): Remove minwidth/height.
12050 Add struct frame *f.
12051 (emacs_fixed_init): Initialize priv->f.
12052 (get_parent_class, emacs_fixed_set_min_size): Remove.
12053 (emacs_fixed_new): Set priv->f to argument.
12054 (emacs_fixed_get_preferred_width)
12055 (emacs_fixed_get_preferred_height): Use min_width/height from
12056 frames size_hint to set minimum and natural (Bug#8919).
12057 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
12058 and use min_width/height from frames size_hint to set
12059 min_width/height (Bug#8919).
12060
12061 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
12062 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
12063 Fix indentation.
c7e73be5 12064
cf99dcf8
EZ
120652011-06-26 Eli Zaretskii <eliz@gnu.org>
12066
12067 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
12068 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
12069 called at ZV.
12070
029529ac
CY
120712011-06-26 Chong Yidong <cyd@stupidchicken.com>
12072
12073 * process.c (wait_reading_process_output): Bypass select if
12074 waiting for a cell while ignoring keyboard input, and input is
12075 pending. Suggested by Jan Djärv (Bug#8869).
12076
7a7ef429
PE
120772011-06-25 Paul Eggert <eggert@cs.ucla.edu>
12078
12079 Use gnulib's dup2 module instead of rolling our own.
12080 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
12081
11fdef7d 120822011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
12083
12084 * dispnew.c (scrolling_window): Before scrolling, turn off a
12085 mouse-highlight in the window being scrolled.
12086
cd3520a4
JB
120872011-06-24 Juanma Barranquero <lekktu@gmail.com>
12088
12089 Move DEFSYM to lisp.h and use everywhere.
12090
12091 * character.h (DEFSYM): Move declaration...
12092 * lisp.h (DEFSYM): ...here.
12093
12094 * gnutls.c:
12095 * minibuf.c:
12096 * w32menu.c:
12097 * w32proc.c:
12098 * w32select.c: Don't include character.h.
12099
12100 * alloc.c (syms_of_alloc):
12101 * buffer.c (syms_of_buffer):
12102 * bytecode.c (syms_of_bytecode):
12103 * callint.c (syms_of_callint):
12104 * casefiddle.c (syms_of_casefiddle):
12105 * casetab.c (init_casetab_once):
12106 * category.c (init_category_once, syms_of_category):
12107 * ccl.c (syms_of_ccl):
12108 * cmds.c (syms_of_cmds):
12109 * composite.c (syms_of_composite):
12110 * dbusbind.c (syms_of_dbusbind):
12111 * dired.c (syms_of_dired):
12112 * dispnew.c (syms_of_display):
12113 * doc.c (syms_of_doc):
12114 * editfns.c (syms_of_editfns):
12115 * emacs.c (syms_of_emacs):
12116 * eval.c (syms_of_eval):
12117 * fileio.c (syms_of_fileio):
12118 * fns.c (syms_of_fns):
12119 * frame.c (syms_of_frame):
12120 * fringe.c (syms_of_fringe):
12121 * insdel.c (syms_of_insdel):
12122 * keymap.c (syms_of_keymap):
12123 * lread.c (init_obarray, syms_of_lread):
12124 * macros.c (syms_of_macros):
12125 * msdos.c (syms_of_msdos):
12126 * print.c (syms_of_print):
12127 * process.c (syms_of_process):
12128 * search.c (syms_of_search):
12129 * sound.c (syms_of_sound):
12130 * syntax.c (init_syntax_once, syms_of_syntax):
12131 * terminal.c (syms_of_terminal):
12132 * textprop.c (syms_of_textprop):
12133 * undo.c (syms_of_undo):
12134 * w32.c (globals_of_w32):
12135 * window.c (syms_of_window):
12136 * xdisp.c (syms_of_xdisp):
12137 * xfaces.c (syms_of_xfaces):
12138 * xfns.c (syms_of_xfns):
12139 * xmenu.c (syms_of_xmenu):
12140 * xsettings.c (syms_of_xsettings):
12141 * xterm.c (syms_of_xterm): Use DEFSYM.
12142
4228cf16
TZ
121432011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
12144
cd3520a4 12145 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 12146
7fcccf1e
PE
121472011-06-23 Paul Eggert <eggert@cs.ucla.edu>
12148
7efb4e0e
PE
12149 Integer and buffer overflow fixes (Bug#8873).
12150
ff5844ad
PE
12151 * print.c (printchar, strout): Check for string overflow.
12152 (PRINTPREPARE, printchar, strout):
12153 Don't set size unless allocation succeeds.
12154
90532f02
PE
12155 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
12156 for sizes. Check for string overflow more accurately.
12157 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
12158
6d84508d
PE
12159 * macros.c: Integer and buffer overflow fixes.
12160 * keyboard.h (struct keyboard.kbd_macro_bufsize):
12161 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
12162 Use ptrdiff_t, not int, for sizes.
12163 Don't increment bufsize until after realloc succeeds.
12164 Check for size-calculation overflow.
12165 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
12166
437b2cb4
PE
12167 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
12168
8b9ac8b4
PE
12169 * lread.c: Integer overflow fixes.
12170 (read_integer): Radix is now EMACS_INT, not int,
12171 to improve quality of diagnostics for out-of-range radices.
12172 Calculate buffer size correctly for out-of-range radices.
12173 (read1): Check for integer overflow in radices, and in
12174 read-circle numbers.
82cb60d3
PE
12175 (read_escape): Avoid int overflow.
12176 (Fload, openp, read_buffer_size, read1)
12177 (substitute_object_recurse, read_vector, read_list, map_obarray):
12178 Use ptrdiff_t, not int, for sizes.
12179 (read1): Use EMACS_INT, not int, for sizes.
20270765 12180 Check for size overflow.
8b9ac8b4 12181
7fcccf1e
PE
12182 * image.c (cache_image): Check for size arithmetic overflow.
12183
bfbbd7e7
PE
12184 * lread.c: Integer overflow issues.
12185 (saved_doc_string_size, saved_doc_string_length)
12186 (prev_saved_doc_string_size, prev_saved_doc_string_length):
12187 Now ptrdiff_t, not int.
12188 (read1): Don't assume doc string length fits in int. Check for
12189 out-of-range doc string lengths.
12190 (read_list): Don't assume file position fits in int.
39019e54 12191 (read_escape): Check for hex character overflow.
bfbbd7e7 12192
4e323265
LL
121932011-06-22 Leo Liu <sdl.web@gmail.com>
12194
12195 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
12196 Move to minibuffer.el.
12197
85fece3e
PE
121982011-06-22 Paul Eggert <eggert@cs.ucla.edu>
12199
20b84ce9 12200 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
12201 The following patches are for when GLYPH_DEBUG && !XASSERT.
12202 * dispextern.h (trace_redisplay_p, dump_glyph_string):
12203 * dispnew.c (flush_stdout):
12204 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
12205 Mark as externally visible.
12206 * dispnew.c (check_window_matrix_pointers): Now static.
12207 * dispnew.c (window_to_frame_vpos):
12208 * xfns.c (unwind_create_frame):
12209 * xterm.c (x_check_font): Remove unused local.
12210 * scroll.c (CHECK_BOUNDS):
12211 * xfaces.c (cache_fache): Rename local to avoid shadowing.
12212 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
12213 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
12214 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
12215 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
12216 Now static.
12217 (debug_method_add): Use va_list and vsprintf rather than relying
12218 on undefined behavior with wrong number of arguments.
12219 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
12220 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
12221 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
12222 since we're not interested in debugging glyphs with old libraries.
12223 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
12224 GCC 4.6.0's static checking.
12225
0766b489
PE
122262011-06-22 Paul Eggert <eggert@cs.ucla.edu>
12227
31fd4b32
PE
12228 Integer overflow and signedness fixes (Bug#8873).
12229 A few related buffer overrun fixes, too.
12230
b79e8648
PE
12231 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
12232
0766b489
PE
12233 * dispextern.h (struct face.stipple):
12234 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
12235 (x_bitmap_mask, x_allocate_bitmap_record)
12236 (x_create_bitmap_from_data, x_create_bitmap_from_file)
12237 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
12238 (x_create_bitmap_from_xpm_data):
12239 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
12240 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
12241 (.bitmaps_last):
12242 * xfaces.c (load_pixmap):
12243 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
12244 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
12245 (.bitmaps_last, struct x_output.icon_bitmap):
12246 Use ptrdiff_t, not int, for bitmap indexes.
12247 (x_allocate_bitmap_record): Check for size overflow.
12248 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
12249
b081724f
PE
12250 Use ptrdiff_t, not int, for overlay counts.
12251 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
12252 * editfns.c (overlays_around, get_pos_property):
12253 * textprop.c (get_char_property_and_overlay):
12254 * xdisp.c (next_overlay_change, note_mouse_highlight):
12255 * xfaces.c (face_at_buffer_position):
21514da7
PE
12256 * buffer.c (OVERLAY_COUNT_MAX): New macro.
12257 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
12258 (Fnext_overlay_change, Fprevious_overlay_change)
12259 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 12260 Use ptrdiff_t, not int, for sizes.
21514da7 12261 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 12262
3de73e5e
PE
12263 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
12264
2606c57b
PE
12265 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
12266 (x_session_initialize): Do not assume string length fits in int.
12267
aaafe47a
PE
12268 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
12269 This is unlikely, but can occur if DPI is outlandish.
12270
2674ddc8 12271 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
12272 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
12273
28154962
PE
12274 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
12275 * xrdb.c (magic_file_p, search_magic_path):
12276 Omit last arg SUFFIX; it was always 0. All callers changed.
12277 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
12278
7de51af5
PE
12279 * xfont.c (xfont_match): Avoid need for strlen.
12280
25ed6cc3
PE
12281 * xfns.c: Don't assume strlen fits in int.
12282 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
12283
4eab31dd
PE
12284 * xdisp.c (message_log_check_duplicate): Return intmax_t,
12285 not unsigned long, as we prefer signed integers. All callers changed.
12286 Detect integer overflow in repeat count.
12287 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 12288 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 12289
171e2a58
PE
12290 * termcap.c: Don't assume sizes fit in int and never overflow.
12291 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
12292 (gobble_line): Check for size-calculation overflow.
12293
ad39faca 12294 * minibuf.c (Fread_buffer):
6e5bb2dc 12295 * lread.c (intern, intern_c_string):
74ca2eb3
PE
12296 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
12297 Don't assume string length fits in int.
12298
52c61c22 12299 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
12300 * gtkutil.c (style_changed_cb): Avoid need for strlen.
12301
b5b8c9e5
PE
12302 * font.c: Don't assume string length fits in int.
12303 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
12304 Use ptrdiff_t, not int.
ccd6111c
PE
12305 (font_intern_prop): Don't assume string length fits in int.
12306 Don't assume integer property fits in fixnum.
12307 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 12308
882f0d81 12309 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 12310 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
12311 Reformulate so as not to need the command string.
12312 Invoke gzip -cd rather than gunzip, as it's more portable.
12313 (lock_info_type, lock_file_1, lock_file):
12314 Don't assume pid_t and time_t fit in unsigned long.
12315 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
12316 (current_lock_owner): Prefer signed type for sizes.
12317 Use memcpy, not strncpy, where memcpy is what is really wanted.
12318 Don't assume (via atoi) that time_t and pid_t fit in int.
12319 Check for time_t and/or pid_t out of range, e.g., via a network share.
12320 Don't alloca where an auto var works fine.
12321
93f4cf88
PE
12322 * fileio.c: Fix some integer overflow issues.
12323 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
12324 Don't assume string length fits in int.
12325 (directory_file_name): Don't assume string length fits in long.
12326 (make_temp_name): Don't assume pid fits in int, or that its print
12327 length is less than 20.
12328
f3e92b69
PE
12329 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
12330
1bfdaf10
PE
12331 * coding.c (make_subsidiaries): Don't assume string length fits in int.
12332
35016e9a
PE
12333 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
12334
3d1e65a1
PE
12335 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
12336 We prefer signed integers, even for size calculations.
12337
0b963a93
PE
12338 * emacs.c: Don't assume string length fits in 'int'.
12339 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
12340 (main): Don't invoke strlen when not needed.
12341
573f4b54
PE
12342 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
12343 (XD_DEBUG_MESSAGE): Don't waste a byte.
12344
989f33ba
PE
12345 * callproc.c (getenv_internal_1, getenv_internal)
12346 (Fgetenv_internal):
965d34eb
PE
12347 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
12348
e4d29b33
PE
12349 * lread.c (invalid_syntax): Omit length argument.
12350 All uses changed. This doesn't fix a bug, but it simplifies the
12351 code away from its former Hollerith-constant appearance, and it's
12352 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 12353 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 12354
eb49b136
PE
12355 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
12356 This didn't break anything, but it didn't help either.
12357 It's confusing to put a bogus integer in a place where the actual
12358 value does not matter.
9f62aeb1 12359 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 12360 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 12361
15375a22
PE
12362 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
12363 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
12364 implementation.
b61cc01c
PE
12365 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
12366 We prefer signed types, and the value cannot exceed the EMACS_INT
12367 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
12368 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
12369 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
12370 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 12371
53b2623d
PE
12372 * indent.c (sane_tab_width): New function.
12373 (current_column, scan_for_column, Findent_to, position_indentation)
12374 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 12375 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 12376
51cab52b 12377 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 12378
f2ed8a70
PE
12379 * lisp.h (lint_assume): New macro.
12380 * composite.c (composition_gstring_put_cache):
12381 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
12382
abe80cc6
PE
12383 * editfns.c, insdel.c:
12384 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 12385
b02c740e
PE
12386 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
12387
ebc96716
PE
12388 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
12389
b4e50fa0 12390 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 12391 Use much-faster test for byte-length change.
311d5d7c 12392 Don't assume string byte-length fits in 'int'.
a4cf38e4 12393 Check that character arg fits in 'int'.
85461888 12394 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 12395
c0c1ee9f
PE
12396 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
12397
a498d7f4
PE
12398 * fns.c (concat): Catch string overflow earlier.
12399 Do not rely on integer wraparound.
12400
51cab52b
PE
12401 * dispextern.h (struct it.overlay_strings_charpos)
12402 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
12403 * xdisp.c (forward_to_next_line_start)
12404 (back_to_previous_visible_line_start)
12405 (reseat_at_next_visible_line_start, next_element_from_buffer):
12406 Don't arbitrarily truncate the value of 'selective' to int.
12407
76031fad
PE
12408 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
12409
5eb55db9
PE
12410 * composite.c: Don't truncate sizes to 'int'.
12411 (composition_gstring_p, composition_reseat_it)
12412 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
12413 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
12414 not EMACS_UINT, for indexes.
5eb55db9 12415
0703a717
PE
12416 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
12417
d6202519
PE
12418 * buffer.c: Include <verify.h>.
12419 (struct sortvec.priority, struct sortstr.priority):
8961a454 12420 Now EMACS_INT, not int.
c20998a7 12421 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
12422 (struct sortstr.size, record_overlay_string)
12423 (struct sortstrlist.size, struct sortlist.used):
12424 Don't truncate size to int.
12425 (record_overlay_string): Check for size-calculation overflow.
d6202519 12426 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 12427
d5a19415
JM
124282011-06-22 Jim Meyering <meyering@redhat.com>
12429
029529ac 12430 Don't leak an XBM-image-sized buffer
d5a19415
JM
12431 * image.c (xbm_load): Free the image buffer after using it.
12432
a9041e6c
PE
124332011-06-21 Paul Eggert <eggert@cs.ucla.edu>
12434
12435 Port to Sun C.
12436 * composite.c (find_automatic_composition): Omit needless 'return 0;'
12437 that Sun C diagnosed.
12438 * fns.c (secure_hash): Fix pointer signedness issue.
12439 * intervals.c (static_offset_intervals): New function.
12440 (offset_intervals): Use it.
12441
7f3f739f
LL
124422011-06-21 Leo Liu <sdl.web@gmail.com>
12443
12444 * deps.mk (fns.o):
12445 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
12446 sha512.h.
12447
12448 * fns.c (secure_hash): Rename from crypto_hash_function and change
12449 the first arg to accept symbols.
5b66d427 12450 (Fsecure_hash): New primitive.
7f3f739f
LL
12451 (syms_of_fns): New symbols.
12452
76147d94
DD
124532011-06-20 Deniz Dogan <deniz@dogan.se>
12454
12455 * process.c (Fset_process_buffer): Clarify return value in
12456 docstring.
12457
7d7d0045
CY
124582011-06-18 Chong Yidong <cyd@stupidchicken.com>
12459
12460 * dispnew.c (add_window_display_history): Use BVAR.
12461
12462 * xdisp.c (debug_method_add): Use BVAR.
12463 (check_window_end, dump_glyph_matrix, dump_glyph)
12464 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
12465
12466 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
12467 Likewise.
12468
12469 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
12470 check till after the cache is created in init_frame_faces.
12471
ff2bc410
SM
124722011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
12473
12474 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
12475
28177add
PE
124762011-06-16 Paul Eggert <eggert@cs.ucla.edu>
12477
dd3482fe
PE
12478 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
12479 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
12480 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
12481
393d71f3 12482 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
12483 * fileio.c (Finsert_file_contents):
12484 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
12485 Remove the old (too-loose) buffer overflow checks.
12486 They weren't needed, since make_gap checks for buffer overflow.
12487 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
12488 The old code merely checked for Emacs fixnum overflow, and relied
12489 on undefined (wraparound) behavior. The new code avoids undefined
12490 behavior, and also checks for ptrdiff_t and/or size_t overflow.
12491
2e6813b0 12492 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
12493 Tune. Don't use wider integers than needed. Don't use alloca.
12494 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 12495
599a9e4f
PE
12496 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
12497
99561444
PE
12498 * insdel.c, lisp.h (buffer_overflow): New function.
12499 (insert_from_buffer_1, replace_range, replace_range_2):
12500 * insdel.c (make_gap_larger):
12501 * editfns.c (Finsert_char):
12502 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
12503
28177add
PE
12504 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
12505
e69dafad
PE
125062011-06-15 Paul Eggert <eggert@cs.ucla.edu>
12507
4baa020d 12508 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 12509
b1c46f02
PE
12510 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
12511 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
12512
e69dafad
PE
12513 * fileio.c: Don't assume EMACS_INT fits in off_t.
12514 (emacs_lseek): New static function.
12515 (Finsert_file_contents, Fwrite_region): Use it.
12516 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
12517
566684ea
PE
12518 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
12519
e6966cd6
PE
12520 * fns.c: Don't overflow int when computing a list length.
12521 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
12522 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
12523 truncation on 64-bit hosts. Check for QUIT every
12524 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
12525 faster and is responsive enough.
12526 (Flength): Report an error instead of overflowing an integer.
12527 (Fsafe_length): Return a float if the value is not representable
12528 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 12529 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 12530 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 12531
dd0b0efb
PE
12532 * alloc.c: Check that resized vectors' lengths fit in fixnums.
12533 (header_size, word_size): New constants.
12534 (allocate_vectorlike): Don't check size overflow here.
12535 (allocate_vector): Check it here instead, since this is the only
12536 caller of allocate_vectorlike that could cause overflow.
12537 Check that the new vector's length is representable as a fixnum.
12538
86fe5cfe
PE
12539 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
12540 The previous code was bogus. For example, next_almost_prime (32)
12541 returned 39, which is undesirable as it is a multiple of 3; and
12542 next_almost_prime (24) returned 25, which is a multiple of 5 so
12543 why was the code bothering to check for multiples of 7?
12544
80e88859
PE
12545 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
12546
4a2f0ad6
PE
12547 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
12548
f66c7cf8
PE
12549 Variadic C functions now count arguments with ptrdiff_t.
12550 This partly undoes my 2011-03-30 change, which replaced int with size_t.
12551 Back then I didn't know that the Emacs coding style prefers signed int.
12552 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
12553 were being counted with int, which may truncate counts on 64-bit
12554 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
12555 * lisp.h (struct Lisp_Subr.function.aMANY)
12556 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
12557 Arg counts are now ptrdiff_t, not size_t.
12558 All variadic functions and their callers changed accordingly.
12559 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
12560 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
12561 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
12562 * callint.c (Fcall_interactively): Check arg count for overflow,
12563 to avoid potential buffer overrun. Use signed char, not 'int',
12564 for 'varies' array, so that we needn't bother to check its size
12565 calculation for overflow.
12566 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
12567 * eval.c (apply_lambda):
12568 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
12569 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
12570 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
12571
a1759b76
PE
12572 * callint.c (Fcall_interactively): Don't use index var as event count.
12573
d96be9fc
PE
12574 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
12575 * mem-limits.h (SIZE): Remove; no longer used.
12576
a690a978 12577 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 12578
578c21e6
PE
12579 Remove unnecessary casts.
12580 * xterm.c (x_term_init):
12581 * xfns.c (x_set_border_pixel):
12582 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
12583 These aren't needed now that we assume ANSI C.
12584
96f53c6c
PE
12585 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
12586 It's more likely to cause problems (due to unsigned overflow)
12587 than to cure them.
12588
83c77d31
PE
12589 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
12590
ee2079f1
PE
12591 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
12592
6da65536
PE
12593 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
12594
7147c4a4
PE
12595 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
12596
193e32d9
PE
12597 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
12598
e5533da6
PE
12599 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
12600
9910e595
PE
12601 GLYPH_CODE_FACE returns EMACS_INT, not int.
12602 * dispextern.h (merge_faces):
12603 * xfaces.c (merge_faces):
01103c44
PE
12604 * xdisp.c (get_next_display_element, next_element_from_display_vector):
12605 Don't assume EMACS_INT fits in int.
9910e595 12606
2638320e
PE
12607 * character.h (CHAR_VALID_P): Remove unused parameter.
12608 * fontset.c, lisp.h, xdisp.c: All uses changed.
12609
045eb8d9
PE
12610 * editfns.c (Ftranslate_region_internal): Omit redundant test.
12611
c1f134b5
PE
12612 * fns.c (concat): Minor tuning based on overflow analysis.
12613 This doesn't fix any bugs. Use int to hold character, instead
12614 of constantly refetching from Emacs object. Use XFASTINT, not
12615 XINT, for value known to be a character. Don't bother comparing
12616 a single byte to 0400, as it's always less.
12617
395fcb93 12618 * floatfns.c (Fexpt):
327eeec8
PE
12619 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
12620
abbd3d23
PE
12621 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
12622 for characters.
12623
684a03ef
PE
12624 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
12625
0fed43f3
PE
12626 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
12627 Without this fix, on a 64-bit host (aset S 0 4294967386) would
12628 incorrectly succeed when S was a string, because 4294967386 was
12629 truncated before it was used.
12630
8fd02eb7
PE
12631 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
12632 Otherwise, an out-of-range integer could cause undefined behavior
12633 on a 64-bit host.
12634
f8c86b69
PE
12635 * composite.c: Use int, not EMACS_INT, for characters.
12636 (fill_gstring_body, composition_compute_stop_pos): Use int, not
12637 EMACS_INT, for values that are known to be in character range.
12638 This doesn't fix any bugs but is the usual style inside Emacs and
12639 may generate better code on 32-bit machines.
12640
34206dd2
PE
12641 Make sure a 64-bit char is never passed to ENCODE_CHAR.
12642 This is for reasons similar to the recent CHAR_STRING fix.
12643 * charset.c (Fencode_char): Check that character arg is actually
12644 a character. Pass an int to ENCODE_CHAR.
12645 * charset.h (ENCODE_CHAR): Verify that the character argument is no
12646 wider than 'int', as a compile-time check to prevent future regressions
12647 in this area.
12648
c5958d4c 12649 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
12650
12651 Make sure a 64-bit char is never passed to CHAR_STRING.
12652 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
12653 by silently ignoring the top 32 bits, allowing some values
12654 that were far too large to be valid characters.
12655 * character.h: Include <verify.h>.
12656 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
12657 arguments are no wider than unsigned, as a compile-time check
12658 to prevent future regressions in this area.
12659 * data.c (Faset):
01103c44 12660 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
12661 (Fsubst_char_in_region):
12662 * fns.c (concat):
12663 * xdisp.c (decode_mode_spec_coding):
12664 Adjust to CHAR_STRING's new requirement.
12665 * editfns.c (Finsert_char, Fsubst_char_in_region):
12666 * fns.c (concat): Check that character args are actually
12667 characters. Without this test, these functions did the wrong
12668 thing with wildly out-of-range values on 64-bit hosts.
12669
d37ca623
PE
12670 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
12671 These casts should not be needed on 32-bit hosts, either.
12672 * keyboard.c (read_char):
12673 * lread.c (Fload): Remove casts to unsigned.
12674
ea204efb
PE
12675 * lisp.h (UNSIGNED_CMP): New macro.
12676 This fixes comparison bugs on 64-bit hosts.
12677 (ASCII_CHAR_P): Use it.
12678 * casefiddle.c (casify_object):
01103c44 12679 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
12680 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
12681 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
12682 * dispextern.h (FACE_FROM_ID):
12683 * keyboard.c (read_char): Use UNSIGNED_CMP.
12684
41cb286c
PE
12685 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
12686 not to EMACS_INT, to avoid GCC warning.
12687
4a1b9832
PE
12688 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
12689
55daad71
PE
12690 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
12691 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
12692 isn't needed on 32-bit machines.
8f95c75c 12693
01103c44
PE
12694 * buffer.c (Fgenerate_new_buffer_name):
12695 Use EMACS_INT for count, not int.
0ceccced 12696 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
12697
12698 * data.c (Qcompiled_function): Now static.
12699
c6f072e7
PE
12700 * window.c (window_body_lines): Now static.
12701
20ce5912
PE
12702 * image.c (gif_load): Rename local to avoid shadowing.
12703
9c4c5f81
PE
12704 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
12705 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
12706 * alloc.c (make_save_value): Integer argument is now of type
12707 ptrdiff_t, not int.
12708 (mark_object): Use ptrdiff_t, not int.
12709 * lisp.h (pD): New macro.
12710 * print.c (print_object): Use it.
12711
c0c5c8ae
PE
12712 * alloc.c: Use EMACS_INT, not int, to count objects.
12713 (total_conses, total_markers, total_symbols, total_vector_size)
12714 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
12715 (total_free_floats, total_floats, total_free_intervals)
12716 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
12717 Now EMACS_INT, not int. All uses changed.
12718 (Fgarbage_collect): Compute overall total using a double, so that
12719 integer overflow is less likely to be a problem. Check for overflow
12720 when converting back to an integer.
5a25e253
PE
12721 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
12722 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
12723 These were 'int' variables that could overflow on 64-bit hosts;
12724 they were never used, so remove them instead of repairing them.
211a0b2a 12725 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
12726 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
12727 Previously, this ceilinged at INT_MAX, but that doesn't work on
12728 64-bit machines.
e46bb31a 12729 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 12730
c78baabf 12731 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 12732 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
12733 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
12734 when a (possibly-narrower) signed value would do just as well.
12735 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 12736
c9d624c6
PE
12737 * alloc.c: Catch some string size overflows that we were missing.
12738 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
12739 for convenience in STRING_BYTES_MAX.
12740 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
12741 The definition here is exact; the one in lisp.h was approximate.
12742 (allocate_string_data): Check for string overflow. This catches
12743 some instances we weren't catching before. Also, it catches
12744 size_t overflow on (unusual) hosts where SIZE_MAX <= min
12745 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
12746 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 12747
c9d624c6
PE
12748 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
12749 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 12750 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 12751
353032ce
PE
12752 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
12753
2bccce07
PE
12754 * alloc.c (Fmake_string): Check for out-of-range init.
12755
0ac30604
SM
127562011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
12757
12758 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
12759
c195f2de
JD
127602011-06-14 Jan Djärv <jan.h.d@swipnet.se>
12761
12762 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
12763 xg_get_default_scrollbar_width.
12764
12765 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
12766 (int_gtk_range_get_value): Move to the scroll bar part of the file.
12767 (style_changed_cb): Call update_theme_scrollbar_width and call
12768 x_set_scroll_bar_default_width and xg_frame_set_char_size for
12769 all frames (Bug#8505).
12770 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
12771 Call gtk_window_set_resizable if HAVE_GTK3.
12772 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
12773 and height if HAVE_GTK3 (Bug#8505).
12774 (scroll_bar_width_for_theme): New variable.
12775 (update_theme_scrollbar_width): New function.
12776 (xg_get_default_scrollbar_width): Move code to
12777 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
12778 (xg_initialize): Call update_theme_scrollbar_width.
12779
12780 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
12781
12782 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
12783
e10ac9f1
MR
127842011-06-12 Martin Rudalics <rudalics@gmx.at>
12785
12786 * frame.c (make_frame): Call other_buffer_safely instead of
12787 other_buffer.
12788
12789 * window.c (temp_output_buffer_show): Call display_buffer with
12790 second argument Vtemp_buffer_show_specifiers and reset latter
12791 immediately after the call.
12792 (Vtemp_buffer_show_specifiers): New variable.
12793 (auto_window_vscroll_p, next_screen_context_lines)
12794 (Vscroll_preserve_screen_position): Remove leading asterisks from
12795 doc-strings.
12796
2d3c217e 127972011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 12798
7b7f97e8 12799 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
12800 * buffer.c (Qclone_number): Remove for now, as it's unused.
12801 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
12802 (record_buffer): Remove unused local.
12803 * frame.c (other_visible_frames, frame_buffer_list): Now static.
12804 (set_frame_buffer_list): Remove; unused.
12805 * frame.h (other_visible_frames): Remove decl.
12806 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
12807 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
12808 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
12809 if HAVE_GPM.
12810 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
12811 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
12812 Define only if HAVE_GPM.
12813 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
12814 (update_hints_inhibit): Remove; never set. All uses removed.
12815 * widgetprv.h (emacsFrameClassRec): Remove decl.
12816 * window.c (delete_deletable_window): Now returns void, since it
12817 wasn't returning anything.
12818 (compare_window_configurations): Remove unused locals.
12819 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
12820 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
12821 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
12822 the same widths as pointers. This follows up on the 2011-05-06 patch.
12823 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
12824 * xterm.h: Likewise.
12825 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
12826
1384b89e
JB
128272011-06-12 Juanma Barranquero <lekktu@gmail.com>
12828
12829 * makefile.w32-in: Update dependencies.
12830 (LISP_H): Add lib/intprops.h.
12831
1100a63c
CY
128322011-06-11 Chong Yidong <cyd@stupidchicken.com>
12833
12834 * image.c (gif_load): Add animation frame delay to the metadata.
12835 (syms_of_image): Use DEFSYM. New symbol `delay'.
12836
6198ccd0
MR
128372011-06-11 Martin Rudalics <rudalics@gmx.at>
12838
12839 * window.c (delete_deletable_window): Re-add.
12840 (Fset_window_configuration): Rewrite to handle dead buffers and
12841 consequently deletable windows.
12842 (window_tree, Fwindow_tree): Remove. Supply functionality in
12843 window.el.
12844 (compare_window_configurations): Simplify code.
12845
b6e3633c
AS
128462011-06-11 Andreas Schwab <schwab@linux-m68k.org>
12847
1ab0dee5
AS
12848 * image.c (imagemagick_load_image): Fix type mismatch.
12849 (Fimagemagick_types): Likewise.
12850
b6e3633c
AS
12851 * window.h (replace_buffer_in_windows): Declare.
12852
9397e56f
MR
128532011-06-11 Martin Rudalics <rudalics@gmx.at>
12854
12855 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
12856 Qclone_number. Remove external declaration of Qdelete_window.
12857 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
12858 code.
640c8776
SM
12859 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
12860 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
12861 (Fother_buffer): Rewrite doc-string. Major rewrite for new
12862 buffer list implementation.
12863 (other_buffer_safely): New function.
12864 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
12865 calls to replace_buffer_in_windows and
12866 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
12867 if allowed.
12868 (record_buffer): Inhibit quitting and rewrite using quittable
12869 functions. Run Qbuffer_list_update_hook if allowed.
12870 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
12871 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
12872 Move switch-to-buffer to window.el.
9397e56f
MR
12873 (bury-buffer): Move to window.el.
12874 (Vbuffer_list_update_hook): New variable.
12875
12876 * lisp.h (other_buffer_safely): Add prototype in buffer.c
12877 section.
12878
12879 * window.h (resize_frame_windows): Move up in code.
12880 (Fwindow_frame): Remove EXFUN.
12881 (replace_buffer_in_all_windows): Remove prototype.
12882 (replace_buffer_in_windows_safely): Add prototype.
12883
12884 * window.c: Declare Qdelete_window static again. Move down
12885 declaration of select_count.
12886 (Fnext_window, Fprevious_window): Rewrite doc-strings.
12887 (Fother_window): Move to window.el.
12888 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
12889 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
12890 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
12891 window.el.
12892 (replace_buffer_in_windows): Implement by calling
12893 Qreplace_buffer_in_windows.
12894 (replace_buffer_in_all_windows): Remove with some functionality
12895 moved into replace_buffer_in_windows_safely.
12896 (replace_buffer_in_windows_safely): New function.
12897 (select_window_norecord, select_frame_norecord): Move in front
12898 of run_window_configuration_change_hook. Remove now obsolete
12899 declarations.
640c8776
SM
12900 (Fset_window_buffer): Rewrite doc-string.
12901 Call Qrecord_window_buffer.
9397e56f
MR
12902 (keys_of_window): Move binding for other-window to window.el.
12903
b50691aa
CY
129042011-06-11 Chong Yidong <cyd@stupidchicken.com>
12905
12906 * dispextern.h (struct image): Replace data member, whose int_val
12907 and ptr_val fields were not used by anything, with a single
12908 lisp_val object.
12909
12910 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
12911 (gif_clear_image, gif_load, imagemagick_load_image)
12912 (gs_clear_image, gs_load): Callers changed.
12913
3f754b86
PE
129142011-06-10 Paul Eggert <eggert@cs.ucla.edu>
12915
cca69397
PE
12916 * buffer.h: Include <time.h>, for time_t.
12917 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
12918
109e28d0
PE
12919 Fix minor problems found by static checking.
12920
60737f02
PE
12921 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
12922
4b66faf3
PE
12923 Make identifiers static if they are not used in other modules.
12924 * data.c (Qcompiled_function, Qframe, Qvector):
12925 * image.c (QimageMagick, Qsvg):
12926 * minibuf.c (Qmetadata):
12927 * window.c (resize_window_check, resize_root_window): Now static.
12928 * window.h (resize_window_check, resize_root_window): Remove decls.
12929
109e28d0
PE
12930 * window.c (window_deletion_count, delete_deletable_window):
12931 Remove; unused.
46a4ce9e
PE
12932 (window_body_lines): Now static.
12933 (Fdelete_other_windows_internal): Mark vars as initialized.
12934 Make sure 'resize_failed' is initialized.
12935 (run_window_configuration_change_hook): Rename local to avoid shadowing.
12936 (resize_window_apply): Remove unused local.
12937 * window.h (delete_deletable_window): Remove decl.
12938
109e28d0 12939 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
12940 (imagemagick_load_image): Fix pointer signedness problem by changing
12941 last arg from unsigned char * to char *. All uses changed.
12942 Also, fix a local for similar reasons.
12943 Remove unused locals. Remove locals to avoid shadowing.
12944 (fn_rsvg_handle_free): Remove; unused.
12945 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 12946 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 12947
3f754b86
PE
12948 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
12949
2547adb1
CY
129502011-06-10 Chong Yidong <cyd@stupidchicken.com>
12951
12952 * image.c (gif_load): Fix omitted cast error introduced by
12953 2011-06-06 change.
12954
2c8e37d4
MR
129552011-06-10 Martin Rudalics <rudalics@gmx.at>
12956
12957 * window.h (resize_proportionally, orig_total_lines)
12958 (orig_top_line): Remove from window structure.
12959 (set_window_height, set_window_width, change_window_heights)
12960 (Fdelete_window): Remove prototypes.
12961 (resize_frame_windows): Remove duplicate declaration.
12962
440a42e3
EZ
129632011-06-10 Eli Zaretskii <eliz@gnu.org>
12964
12965 * window.h (resize_frame_windows, resize_window_check)
12966 (delete_deletable_window, resize_root_window)
12967 (resize_frame_windows): Declare prototypes.
12968
12969 * window.c (resize_window_apply): Make definition be "static" to
12970 match the prototype.
12971
562dd5e9
MR
129722011-06-10 Martin Rudalics <rudalics@gmx.at>
12973
12974 * window.c: Remove declarations of Qwindow_size_fixed,
12975 window_min_size_1, window_min_size_2, window_min_size,
12976 size_window, window_fixed_size_p, enlarge_window, delete_window.
12977 Remove static from declaration of Qdelete_window, it's
12978 temporarily needed by Fbury_buffer.
12979 (replace_window): Don't assign orig_top_line and
12980 orig_total_lines.
12981 (Fdelete_window, delete_window): Remove. Window deletion is
12982 handled by window.el.
640c8776
SM
12983 (window_loop): Remove DELETE_OTHER_WINDOWS case.
12984 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
12985 (Fdelete_other_windows): Remove. Deleting other windows is
12986 handled by window.el.
12987 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
12988 handled in window.el.
12989 (window_min_size_2, window_min_size_1, window_min_size): Remove.
12990 Window minimum sizes are handled in window.el.
12991 (shrink_windows, size_window, set_window_height)
12992 (set_window_width, change_window_heights, window_height)
12993 (window_width, CURBEG, CURSIZE, enlarge_window)
12994 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
12995 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
12996 handled in window.el.
12997 (make_dummy_parent): Rename to make_parent_window and give it a
12998 second argument horflag.
12999 (make_window): Don't set resize_proportionally any more.
13000 (Fsplit_window): Remove. Windows are split in window.el.
13001 (save_restore_action, save_restore_orig_size)
13002 (shrink_window_lowest_first, save_restore_orig_size): Remove.
13003 Resize mini windows in window.el.
13004 (grow_mini_window, shrink_mini_window): Implement by calling
13005 Qresize_root_window_vertically, resize_window_check and
13006 resize_window_apply.
640c8776
SM
13007 (saved_window, Fset_window_configuration, save_window_save):
13008 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
13009 resize_proportionally.
13010 (window_min_height, window_min_width): Move to window.el.
13011 (keys_of_window): Move bindings for delete-other-windows,
13012 split-window, delete-window and enlarge-window to window.el.
13013
13014 * buffer.c: Temporarily extern Qdelete_window.
13015 (Fbury_buffer): Temporarily call Qdelete_window instead of
13016 Fdelete_window (Fbury_buffer will move to window.el soon).
13017
13018 * frame.c (set_menu_bar_lines_1): Remove code handling
13019 orig_top_line and orig_total_lines.
13020
13021 * dispnew.c (adjust_frame_glyphs_initially): Don't use
13022 set_window_height but set heights directly.
13023 (change_frame_size_1): Use resize_frame_windows.
13024
13025 * xdisp.c (init_xdisp): Don't use set_window_height but set
13026 heights directly.
13027
640c8776
SM
13028 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
13029 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
13030 run_window_configuration_change_hook.
13031
13032 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
13033 instead of change_window_heights and run
13034 run_window_configuration_change_hook.
13035
1a13852e
MR
130362011-06-09 Martin Rudalics <rudalics@gmx.at>
13037
13038 * window.c (replace_window): Rename second argument REPLACEMENT to
13039 NEW. New third argument SETFLAG. Rewrite.
13040 (delete_window, make_dummy_parent): Call replace_window with
13041 third argument 1.
13042 (window_list_1): Move down in code.
13043 (run_window_configuration_change_hook): Move set_buffer part
13044 before select_frame_norecord part in order to unwind correctly.
13045 Rename count1 to count.
13046 (recombine_windows, delete_deletable_window, resize_root_window)
13047 (Fdelete_other_windows_internal)
13048 (Frun_window_configuration_change_hook, make_parent_window)
13049 (resize_window_check, resize_window_apply, Fresize_window_apply)
13050 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
13051 (Fdelete_window_internal, Fresize_mini_window_internal):
13052 New functions.
1a13852e
MR
13053 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
13054
f3d1777e
MR
130552011-06-08 Martin Rudalics <rudalics@gmx.at>
13056
496e208e
MR
13057 * window.h (window): Add some new members to window structure -
13058 normal_lines, normal_cols, new_total, new_normal, clone_number,
13059 splits, nest, prev_buffers, next_buffers.
13060 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 13061 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 13062
f3d1777e
MR
13063 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
13064 Remove.
496e208e
MR
13065 (make_dummy_parent): Set new members of windows structure.
13066 (make_window): Move down in code. Handle new members of window
13067 structure.
13068 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
13069 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
13070 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
13071 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
13072 (Fset_window_next_buffers, Fset_window_clone_number):
13073 New functions.
496e208e
MR
13074 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
13075 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
13076 Doc-string fixes.
13077 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
13078 Argument WINDOW can be now internal window too.
13079 (Fwindow_use_time): Move up in code.
13080 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
13081 Rewrite doc-string.
13082 (Fset_window_configuration, saved_window)
13083 (Fcurrent_window_configuration, save_window_save): Handle new
13084 members of window structure.
b9e809c2
MR
13085 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
13086 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
13087 (syms_of_window): New Lisp objects Qrecord_window_buffer,
13088 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
13089 Qget_mru_window, Qresize_root_window,
13090 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
13091 Qauto_buffer_name; staticpro them.
f3d1777e 13092
abde8f8c
MR
130932011-06-07 Martin Rudalics <rudalics@gmx.at>
13094
13095 * window.c (Fwindow_total_size, Fwindow_left_column)
13096 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
13097 (Fwindow_list_1): New functions.
13098 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
13099 (Fwindow_width, Fscroll_left, Fscroll_right):
13100 Use window_body_cols instead of window_box_text_cols.
13101 (delete_window, Fset_window_configuration):
13102 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
13103 (delete_all_subwindows): Take a window as argument and not a
13104 structure. Rewrite.
190b47e6
MR
13105 (window_loop): Remove handling of GET_LRU_WINDOW and
13106 GET_LARGEST_WINDOW.
13107 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
13108
13109 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
13110 window_box_text_cols. delete_all_subwindows now takes a
13111 Lisp_Object as argument.
abde8f8c 13112
640c8776
SM
13113 * indent.c (compute_motion, Fcompute_motion):
13114 Use window_body_cols instead of window_box_text_cols.
abde8f8c 13115
fa8a67e6
MR
13116 * frame.c (delete_frame): Call delete_all_subwindows with root
13117 window as argument.
13118
a54e3482
DC
131192011-06-07 Daniel Colascione <dan.colascione@gmail.com>
13120
13121 * fns.c (Fputhash): Document return value.
13122
60002bf5
CY
131232011-06-06 Chong Yidong <cyd@stupidchicken.com>
13124
13125 * image.c (gif_load): Implement gif89a spec "no disposal" method.
13126
0c671da6 131272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 13128
b862a52a 13129 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 13130
be44ca6c
PE
13131 Check for overflow when converting integer to cons and back.
13132 * charset.c (Fdefine_charset_internal, Fdecode_char):
13133 Use cons_to_unsigned to catch overflow.
13134 (Fencode_char): Use INTEGER_TO_CONS.
13135 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
13136 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
13137 * data.c (long_to_cons, cons_to_long): Remove.
13138 (cons_to_unsigned, cons_to_signed): New functions.
13139 These signal an error for invalid or out-of-range values.
13140 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
13141 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
13142 * font.c (Ffont_variation_glyphs):
13143 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
13144 * lisp.h: Include <intprops.h>.
13145 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
13146 (cons_to_signed, cons_to_unsigned): New decls.
13147 (long_to_cons, cons_to_long): Remove decls.
13148 * undo.c (record_first_change): Use INTEGER_TO_CONS.
13149 (Fprimitive_undo): Use CONS_TO_INTEGER.
13150 * xfns.c (Fx_window_property): Likewise.
13151 * xselect.c: Include <limits.h>.
13152 (x_own_selection, selection_data_to_lisp_data):
13153 Use INTEGER_TO_CONS.
13154 (x_handle_selection_request, x_handle_selection_clear)
13155 (x_get_foreign_selection, Fx_disown_selection_internal)
13156 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
13157 (lisp_data_to_selection_data): Use cons_to_unsigned.
13158 (x_fill_property_data): Use cons_to_signed.
13159 Report values out of range.
13160
d1f3d2af
PE
13161 Check for buffer and string overflow more precisely.
13162 * buffer.h (BUF_BYTES_MAX): New macro.
13163 * lisp.h (STRING_BYTES_MAX): New macro.
13164 * alloc.c (Fmake_string):
13165 * character.c (string_escape_byte8):
13166 * coding.c (coding_alloc_by_realloc):
13167 * doprnt.c (doprnt):
13168 * editfns.c (Fformat):
13169 * eval.c (verror):
13170 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
13171 since they may not be the same number.
13172 * editfns.c (Finsert_char):
13173 * fileio.c (Finsert_file_contents):
13174 Likewise for BUF_BYTES_MAX.
13175
dd52fcea
PE
13176 * image.c: Use ptrdiff_t, not int, for sizes.
13177 (slurp_file): Switch from int to ptrdiff_t.
13178 All uses changed.
13179 (slurp_file): Check that file size fits in both size_t (for
13180 malloc) and ptrdiff_t (for sanity and safety).
13181
7f9bbdbb
PE
13182 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
13183 if b->modtime has its maximal value.
13184
dfe18f82
PE
13185 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
13186
84acfcf0
PE
13187 Don't assume time_t can fit into int.
13188 * buffer.h (struct buffer.modtime): Now time_t, not int.
13189 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
13190 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
13191
ccd9a01a
PE
13192 Minor fixes for signed vs unsigned integers.
13193 * character.h (MAYBE_UNIFY_CHAR):
13194 * charset.c (maybe_unify_char):
13195 * keyboard.c (read_char, reorder_modifiers):
13196 XINT -> XFASTINT, since the integer must be nonnegative.
13197 * ftfont.c (ftfont_spec_pattern):
13198 * keymap.c (access_keymap, silly_event_symbol_error):
13199 XUINT -> XFASTINT, since the integer must be nonnegative.
13200 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
13201 since it makes no difference and we prefer signed.
13202 * keyboard.c (record_char): Use XUINT when all the neighbors do.
13203 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
13204 nonnegative.
13205
d6d100dd
SM
132062011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
13207
13208 * window.h (Fwindow_frame): Declare.
13209
2b6148e4
PE
132102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
13211
13212 * alloc.c: Simplify handling of large-request failures (Bug#8800).
13213 (SPARE_MEMORY): Always define.
13214 (LARGE_REQUEST): Remove.
13215 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
13216
f230ecc9
MR
132172011-06-06 Martin Rudalics <rudalics@gmx.at>
13218
727e958e
MR
13219 * lisp.h: Move EXFUNS for Fframe_root_window,
13220 Fframe_first_window and Fset_frame_selected_window to window.h.
13221
13222 * window.h: Move EXFUNS for Fframe_root_window,
13223 Fframe_first_window and Fset_frame_selected_window here from
13224 lisp.h.
13225
13226 * frame.c (Fwindow_frame, Fframe_first_window)
13227 (Fframe_root_window, Fframe_selected_window)
13228 (Fset_frame_selected_window): Move to window.c.
13229 (Factive_minibuffer_window): Move to minibuf.c.
13230 (Fother_visible_frames_p): New function.
13231
13232 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
13233
f230ecc9
MR
13234 * window.c (decode_window, decode_any_window): Move up in code.
13235 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
13236 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
13237 (Fwindow_buffer): Move up and rewrite doc-string.
13238 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
13239 (Fwindow_prev): New functions.
727e958e
MR
13240 (Fwindow_frame): Move here from frame.c. Accept any window as
13241 argument.
13242 (Fframe_root_window, Fframe_first_window)
13243 (Fframe_selected_window): Move here from frame.c. Accept frame
13244 or arbitrary window as argument. Update doc-strings.
13245 (Fminibuffer_window): Move up in code.
13246 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
13247 (Fset_frame_selected_window): Move here from frame.c.
13248 Marginal rewrite.
727e958e
MR
13249 (Fselected_window, select_window, Fselect_window): Move up in
13250 code. Minor doc-string fixes.
f230ecc9 13251
4d09bcf6
PE
132522011-06-06 Paul Eggert <eggert@cs.ucla.edu>
13253
13254 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
13255 Do not assume that spare memory exists; that assumption is valid
13256 only if SYSTEM_MALLOC.
13257 (LARGE_REQUEST): New macro, so that the issue of large requests
13258 is separated from the issue of spare memory.
13259
810928a2
AS
132602011-06-05 Andreas Schwab <schwab@linux-m68k.org>
13261
172418ad
AS
13262 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
13263 format. (Bug#8806)
13264
43f862f7
AS
13265 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
13266
810928a2
AS
13267 * xfns.c (x_set_scroll_bar_default_width): Move declarations
13268 before statements.
13269
a059fe24
JD
132702011-06-05 Jan Djärv <jan.h.d@swipnet.se>
13271
13272 * gtkutil.c (xg_get_default_scrollbar_width): New function.
13273
13274 * gtkutil.h: Declare xg_get_default_scrollbar_width.
13275
13276 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
13277 min width by calling x_set_scroll_bar_default_width (Bug#8505).
13278
989bf368
JB
132792011-06-05 Juanma Barranquero <lekktu@gmail.com>
13280
13281 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
13282
4b80f674
CY
132832011-06-04 Chong Yidong <cyd@stupidchicken.com>
13284
13285 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
13286 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
13287 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
13288 New error handlers.
4b80f674
CY
13289 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
13290 Obey Vx_select_enable_clipboard_manager. Catch errors in
13291 x_clipboard_manager_save (Bug#8779).
13292 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 13293 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 13294
99a33b77 132952011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
13296
13297 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
13298
99a33b77 132992011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
13300
13301 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
13302 in the current matrix if keep_current_p is non-zero.
13303
8264569d
EZ
133042011-06-04 Eli Zaretskii <eliz@gnu.org>
13305
13306 * bidi.c (bidi_level_of_next_char): Fix last change.
13307
57f97249
EZ
133082011-06-03 Eli Zaretskii <eliz@gnu.org>
13309
fec2107c 13310 Support bidi reordering of text covered by display properties.
57f97249 13311
fec2107c
EZ
13312 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
13313 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
13314 (bidi_cache_search, bidi_cache_iterator_state)
13315 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
13316 (bidi_level_of_next_char, bidi_move_to_visually_next):
13317 Support character positions inside a run of characters covered by a
fec2107c
EZ
13318 display string.
13319 (bidi_paragraph_init, bidi_resolve_explicit_1)
13320 (bidi_level_of_next_char): Call bidi_fetch_char and
13321 bidi_fetch_char_advance instead of FETCH_CHAR and
13322 FETCH_CHAR_ADVANCE.
13323 (bidi_init_it): Initialize new members.
13324 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
13325 definitions.
13326 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
13327 instead of using explicit *_CHAR codes.
d6d100dd
SM
13328 (bidi_resolve_explicit, bidi_resolve_weak):
13329 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
13330 bidirectional text is supported only in multibyte buffers.
13331 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
13332 it to initialize the frame_window_p member of struct bidi_it.
13333 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
13334 (bidi_resolve_explicit, bidi_resolve_weak)
13335 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
13336 bidi_it->nchars is non-positive.
13337 (bidi_level_of_next_char): Don't try to lookup the cache for the
13338 next/previous character if nothing is cached there yet, or if we
13339 were just reseat()'ed to a new position.
c40e2fb2 13340
0e14fe90
EZ
13341 * xdisp.c (set_cursor_from_row): Set start and stop points
13342 according to the row's direction when priming the loop that looks
13343 for the glyph on which to display cursor.
13344 (single_display_spec_intangible_p): Function deleted.
13345 (display_prop_intangible_p): Reimplement to call
13346 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
13347 Accept 3 additional arguments needed by handle_display_spec.
13348 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
13349 values: lists, `(when COND...)' forms, etc.
13350 (single_display_spec_string_p): Support property values that are
13351 lists with the argument STRING its top-level element.
13352 (display_prop_string_p): Fix the condition for processing a
13353 property that is a list to be consistent with handle_display_spec.
fec2107c 13354 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
13355 last portion of handle_display_prop.
13356 (compute_display_string_pos): Accept additional argument
13357 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
13358 value of a `display' property is a "replacing spec".
13359 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
13360 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
13361 the display property, but just return a value indicating whether
13362 the display property will replace the characters it covers.
13363 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
13364 frame_window_p members of struct bidi_it.
d6d100dd
SM
13365 (compute_display_string_pos, compute_display_string_end):
13366 New functions.
fec2107c
EZ
13367 (push_it): Accept second argument POSITION, where pop_it should
13368 jump to continue iteration.
13369 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 13370
fec2107c
EZ
13371 * keyboard.c (adjust_point_for_property): Adjust the call to
13372 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
13373
13374 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
13375 (bidi_init_it): Update prototypes.
13376 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
13377 (compute_display_string_pos, compute_display_string_end):
13378 Declare prototypes.
fec2107c
EZ
13379 (struct bidi_it): New members nchars and disp_pos. ch_len is now
13380 EMACS_INT.
fc6f18ce 13381
40087514 133822011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 13383
57f53182
PE
13384 Malloc failure behavior now depends on size of allocation.
13385 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
13386 * lisp.h: Change signatures accordingly.
13387 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
13388 All callers changed. (Bug#8762)
13389
13390 * gnutls.c: Use Emacs's memory allocators.
13391 Without this change, the gnutls library would invoke malloc etc.
13392 directly, which causes problems on non-SYNC_INPUT hosts, and which
13393 runs afoul of improving memory_full behavior. (Bug#8761)
13394 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
13395 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
13396 xfree instead of the default malloc, realloc, free.
13397 (Fgnutls_boot): No need to check for memory allocation failure,
13398 since xmalloc does that for us.
13399
ac32cd99 13400 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
13401 * category.c (hash_get_category_set):
13402 * ccl.c (ccl_driver):
13403 * charset.c (Fdefine_charset_internal):
13404 * charset.h (struct charset.hash_index):
13405 * composite.c (get_composition_id, gstring_lookup_cache)
13406 (composition_gstring_put_cache):
13407 * composite.h (struct composition.hash_index):
13408 * dispextern.h (struct image.hash):
13409 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
13410 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
13411 (hashfn_equal, hashfn_user_defined, make_hash_table)
13412 (maybe_resize_hash_table, hash_lookup, hash_put)
13413 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
13414 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
13415 (Fsxhash, Fgethash, Fputhash, Fmaphash):
13416 * image.c (make_image, search_image_cache, lookup_image)
13417 (xpm_put_color_table_h):
13418 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 13419 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 13420 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 13421 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
13422 * alloc.c (allocate_vectorlike):
13423 Check for overflow in vector size calculations.
13424 * ccl.c (ccl_driver):
13425 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
13426 * fns.c, image.c: Remove unnecessary static decls that would otherwise
13427 need to be updated by these changes.
40087514
PE
13428 * fns.c (make_hash_table, maybe_resize_hash_table):
13429 Check for integer overflow with large hash tables.
0de4bb68
PE
13430 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
13431 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
13432 (SXHASH_REDUCE): New macro.
13433 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
13434 Use it instead of discarding useful hash info with large hash values.
13435 (sxhash_float): New function.
13436 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
13437 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
13438 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
13439 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
13440 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
13441 Adjust signatures to match updated version of code.
13442 (consing_since_gc): Now EMACS_INT, since a single hash table can
13443 use more than INT_MAX bytes.
13444
698d32e2
DN
134452011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
13446
13447 Make it possible to build with GCC-4.6+ -O2 -flto.
13448
13449 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
13450
fd6fa53f
SM
134512011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
13452
13453 * minibuf.c (get_minibuffer, read_minibuf_unwind):
13454 Call minibuffer-inactive-mode.
13455
864db017
JB
134562011-05-31 Juanma Barranquero <lekktu@gmail.com>
13457
13458 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
13459 Update dependencies.
13460
2ad0baf4
DN
134612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13462
13463 * data.c (init_data): Remove code for UTS, this system is not
13464 supported anymore.
13465
4fcc2638
DN
134662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13467
13468 Don't force ./temacs to start in terminal mode.
13469
13470 * frame.c (make_initial_frame): Initialize faces in all cases, not
13471 only when CANNOT_DUMP is defined.
13472 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
13473
c56e0fd5
DN
134742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13475
13476 * dispnew.c (add_window_display_history): Use const for the string
13477 pointer. Remove declaration, not needed.
13478
333d54da 134792011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 13480
55d4c1b2 13481 Use 'inline', not 'INLINE'.
333d54da 13482 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
13483 * alloc.c, fontset.c (INLINE): Remove.
13484 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
13485 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
13486 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
13487 * gmalloc.c (register_heapinfo): Use inline unconditionally.
13488 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
13489
738db178
DN
134902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13491
13492 Make it possible to run ./temacs.
13493
13494 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
13495 syms_of_callproc does the same thing. Remove test for
13496 "initialized", do it in the caller.
13497 * emacs.c (main): Avoid calling set_initial_environment when dumping.
13498
620c53a6
SM
134992011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
13500
13501 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
13502 (read_minibuf): Use get_minibuffer.
13503 (syms_of_minibuf): Use DEFSYM.
13504 (Qmetadata): New var.
13505 * data.c (Qbuffer): Don't make it static.
13506 (syms_of_data): Use DEFSYM.
13507
e003a292
PE
135082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
13509
13510 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
13511 (CCL_CODE_MIN): New macro.
13512
ed008a6d
PE
135132011-05-30 Paul Eggert <eggert@cs.ucla.edu>
13514
3687c2ef
PE
13515 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
13516
ed008a6d
PE
13517 * eval.c (Qdebug): Now static.
13518 * lisp.h (Qdebug): Remove decl. This reverts a part of the
13519 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
13520 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
13521
d66c4c7c
CY
135222011-05-29 Chong Yidong <cyd@stupidchicken.com>
13523
13524 * image.c: Various fixes to ImageMagick code comments.
13525 (Fimagemagick_types): Doc fix.
13526
5fbc2025
PE
135272011-05-29 Paul Eggert <eggert@cs.ucla.edu>
13528
0196f88a
PE
13529 Minor fixes prompted by GCC 4.6.0 warnings.
13530
13531 * xselect.c (converted_selections, conversion_fail_tag): Now static.
13532
5fbc2025
PE
13533 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
13534 (x_clipboard_manager_save_all): Move extern decl to ...
13535 * xterm.h: ... here, so that it can be checked for consistency.
13536
1dd3c2d9
CY
135372011-05-29 Chong Yidong <cyd@stupidchicken.com>
13538
13539 * xselect.c (x_clipboard_manager_save_frame)
13540 (x_clipboard_manager_save_all): New functions.
13541 (Fx_clipboard_manager_save): Lisp function deleted.
13542
13543 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
13544 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
13545
13546 * xterm.h: Update prototype.
13547
5ba6571d
WX
135482011-05-28 William Xu <william.xwl@gmail.com>
13549
13550 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
13551 exiting (Bug#8239).
13552
3eaff834
JM
135532011-05-28 Jim Meyering <meyering@redhat.com>
13554
e1900994 13555 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
13556 * fns.c (to_uchar): Define.
13557 (crypto_hash_function): Use it to convert some newly-signed
13558 variables to unsigned, to avoid sign-extension bugs. For example,
13559 without this change, (md5 "truc") would evaluate to
13560 45723a2aff78ff4fff7fff1114760e62 rather than the expected
13561 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 13562 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 13563
0f6990a7
PE
135642011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13565
13566 Integer overflow fixes.
c8a9ca5a 13567
08686060
PE
13568 * dbusbind.c: Serial number integer overflow fixes.
13569 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
13570 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
13571 to hold a serial number that is too large for a fixnum.
13572 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13573 Check for serial numbers out of range. Decode any serial number
59568bf0 13574 that was so large that it became a float. (Bug#8722)
08686060 13575
2d1fc3c7
PE
13576 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
13577 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13578 Use XFASTINT rather than XUINT when numbers are nonnegative.
13579 (xd_append_arg, Fdbus_method_return_internal):
13580 (Fdbus_method_error_internal): Likewise. Also, for unsigned
13581 arguments, check that Lisp number is nonnegative, rather than
59568bf0 13582 silently wrapping negative numbers around. (Bug#8722)
30217ff0 13583 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 13584 (Bug#8722)
2d1fc3c7 13585
c8a9ca5a
PE
13586 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
13587
519e1d69
PE
13588 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
13589
6df6ae42 13590 ccl: Add integer overflow checks.
30569699
PE
13591 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
13592 (IN_INT_RANGE): New macros.
13593 (ccl_driver): Use them to check for integer overflow when
13594 decoding a CCL program. Many of the new checks are whether XINT (x)
13595 fits in int; it doesn't always, on 64-bit hosts. The new version
13596 doesn't catch all possible integer overflows, but it's an
847044ea 13597 improvement. (Bug#8719)
30569699 13598
c11285dc
PE
13599 * alloc.c (make_event_array): Use XINT, not XUINT.
13600 There's no need for unsigned here.
13601
fdccd48e
PE
13602 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
13603 This follows up to the 2011-05-06 change that substituted uintptr_t
13604 for EMACS_INT. This case wasn't caught back then.
13605
37910ab2
PE
13606 Rework Fformat to avoid integer overflow issues.
13607 * editfns.c: Include <float.h> unconditionally, as it's everywhere
13608 now (part of C89). Include <verify.h>.
13609 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
13610 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
13611 (Fformat): Avoid the prepass trying to compute sizes; it was only
13612 approximate and thus did not catch overflow reliably. Instead, walk
13613 through the format just once, formatting and computing sizes as we go,
13614 checking for integer overflow at every step, and allocating a larger
13615 buffer as needed. Keep track separately whether the format is
13616 multibyte. Keep only the most-recently calculated precision, rather
13617 than them all. Record whether each argument has been converted to
13618 string. Use EMACS_INT, not int, for byte and char and arg counts.
13619 Support field widths and precisions larger than INT_MAX. Avoid
13620 sprintf's undefined behavior with conversion specifications such as %#d
13621 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
13622 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
13623 formatting out-of-range floating point numbers with int
9173deec 13624 formats. (Bug#8668)
37910ab2 13625
2e6578fb
PE
13626 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
13627
0ae6bdee
PE
13628 * data.c: Avoid integer truncation in expressions involving floats.
13629 * data.c: Include <intprops.h>.
13630 (arith_driver): When there's an integer overflow in an expression
13631 involving floating point, convert the integers to floating point
13632 so that the resulting value does not suffer from catastrophic
13633 integer truncation. For example, on a 64-bit host (* 4
13634 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
13635 Do not rely on undefined behavior after integer overflow.
13636
de883a70
PE
13637 merge count_size_as_multibyte, parse_str_to_multibyte
13638 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 13639 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
13640 Check for integer overflow.
13641 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
13642 since it's now a duplicate of the other. This is more of
13643 a character than a buffer op, so better that it's in character.c.
13644 * fns.c, print.c: Adjust to above changes.
13645
2ff916cb
PE
136462011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
13647
13648 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
13649
f1b54466
PE
136502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13651
fb1ac845
PE
13652 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13653 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
13654 (x_clipboard_manager_save): Now static.
13655 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
13656
f1b54466
PE
13657 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13658 (crypto_hash_function): Now static.
13659 Fix pointer signedness problems. Avoid unnecessary initializations.
13660
a9f737ee
CY
136612011-05-27 Chong Yidong <cyd@stupidchicken.com>
13662
13663 * termhooks.h (Vselection_alist): Make it terminal-local.
13664
13665 * terminal.c (create_terminal): Initialize it.
13666
13667 * xselect.c: Support for clipboard managers.
13668 (Vselection_alist): Move to termhooks.h as terminal-local var.
13669 (LOCAL_SELECTION): New macro.
13670 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
13671 (symbol_to_x_atom): Remove gratuitous arg.
13672 (x_handle_selection_request, lisp_data_to_selection_data)
13673 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
13674 (x_own_selection, x_get_local_selection, x_convert_selection):
13675 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
13676 (some_frame_on_display): Delete unused function.
13677 (Fx_own_selection_internal, Fx_get_selection_internal)
13678 (Fx_disown_selection_internal, Fx_selection_owner_p)
13679 (Fx_selection_exists_p): New optional frame arg.
13680 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
13681 (x_handle_selection_clear): Don't treat other terminals with the
13682 same keyboard specially. Use the terminal-local Vselection_alist.
13683 (x_clear_frame_selections): Use Frun_hook_with_args.
13684
13685 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
13686
13687 * xterm.h: Add support for those atoms.
13688
e067f0c1
CY
136892011-05-26 Chong Yidong <cyd@stupidchicken.com>
13690
13691 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
13692 (converted_selections, conversion_fail_tag): New global variables.
13693 (x_selection_request_lisp_error): Free the above.
13694 (x_get_local_selection): Remove unnecessary code.
13695 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
13696 of converted selections stored in converted_selections.
13697 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
13698 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
13699 (x_convert_selection): New function.
13700 (x_handle_selection_event): Simplify.
13701 (x_get_foreign_selection): Don't ignore incoming requests while
13702 waiting for an answer; this will fail when we implement
13703 SAVE_TARGETS, and seems unnecessary anyway.
13704 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
13705 (Vx_sent_selection_functions): Doc fix.
13706
0f4aebc0
LL
137072011-05-26 Leo Liu <sdl.web@gmail.com>
13708
13709 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
13710
e61124cd
YM
137112011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13712
13713 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
13714
13715 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
13716 for fringe update if it has periodic bitmap.
ac389d0c 13717 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
13718 and fringe_bitmap_periodic_p.
13719
13720 * fringe.c (get_fringe_bitmap_data): New function.
13721 (draw_fringe_bitmap_1, update_window_fringes): Use it.
13722 (update_window_fringes): Record periodicity of fringe bitmap in glyph
13723 row. Mark glyph row for fringe update if periodicity changed.
13724
13725 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
13726 for fringe update unless it has periodic bitmap.
13727
f16d9837
KH
137282011-05-25 Kenichi Handa <handa@m17n.org>
13729
13730 * xdisp.c (get_next_display_element): Set correct it->face_id for
13731 a static composition.
13732
e1b90ef6
LL
137332011-05-24 Leo Liu <sdl.web@gmail.com>
13734
13735 * deps.mk (fns.o):
13736 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
13737
13738 * fns.c (crypto_hash_function, Fsha1): New function.
13739 (Fmd5): Use crypto_hash_function.
13740 (syms_of_fns): Add Ssha1.
13741
7400048f
PE
137422011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13743
13744 * gnutls.c: Remove unused macros.
13745 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
13746 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
13747 Remove macros that are defined and never used.
13748 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
13749
abb71cf4
CY
137502011-05-22 Chong Yidong <cyd@stupidchicken.com>
13751
13752 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
13753 (Fx_get_selection_internal): Minor cleanup.
13754 (Fx_own_selection_internal): Rename arguments for consistency with
13755 select.el.
13756
6307db39
PE
137572011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13758
13759 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
13760
f3d4e0a4
CY
137612011-05-22 Chong Yidong <cyd@stupidchicken.com>
13762
13763 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
13764
4d8ade89
YM
137652011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13766
13767 * dispnew.c (scrolling_window): Don't exclude the case that the
13768 last enabled row in the desired matrix touches the bottom boundary.
13769
32078c8d
GM
137702011-05-21 Glenn Morris <rgm@gnu.org>
13771
13772 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
13773 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
13774 and add some more files.
32078c8d 13775
7285dc67
EZ
137762011-05-20 Eli Zaretskii <eliz@gnu.org>
13777
13778 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
13779 report_file_error introduced by the change from 2011-05-07.
13780
89d1bd22
PE
137812011-05-20 Paul Eggert <eggert@cs.ucla.edu>
13782
13783 * systime.h (Time): Define only if emacs is defined.
13784 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
13785 where the include path doesn't have X11/X.h by default. See
13786 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
13787
cd394be1 137882011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
13789
13790 * composite.c (find_automatic_composition): Fix previous change.
13791
b9704ad9
GM
137922011-05-20 Glenn Morris <rgm@gnu.org>
13793
13794 * lisp.mk: New file, split from Makefile.in.
13795 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
13796 (shortlisp): Remove.
13797 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
13798
4a720484
GM
137992011-05-19 Glenn Morris <rgm@gnu.org>
13800
13801 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
13802 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
13803 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
13804 (lisp): Set the order to that of loadup.el.
13805 (shortlisp): Make it a copy of $lisp.
13806 (SOME_MACHINE_LISP): Remove.
13807 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
13808 Use just $shortlisp, not $SOME_MACHINE_LISP too.
13809
a28d4396
KH
138102011-05-18 Kenichi Handa <handa@m17n.org>
13811
13812 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
13813 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
13814 (find_automatic_composition): Mostly rewrite for efficiency.
13815
a2b1fa8e
JB
138162011-05-18 Juanma Barranquero <lekktu@gmail.com>
13817
13818 * makefile.w32-in: Update dependencies.
13819
8e1f5610
CS
138202011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
13821
13822 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 13823 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 13824
7025ee00 138252011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 13826
cdfa6eab
PE
13827 Fix some integer overflow issues, such as string length overflow.
13828
06d6db33
PE
13829 * insdel.c (count_size_as_multibyte): Check for string overflow.
13830
2b4560a8
PE
13831 * character.c (lisp_string_width): Check for string overflow.
13832 Use EMACS_INT, not int, for string indexes and lengths; in
13833 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
13834 the resulting string length overflows an EMACS_INT; instead,
13835 report a string overflow if no precision given. When checking for
13836 precision exhaustion, use a check that cannot possibly have
13837 integer overflow. (Bug#8675)
13838 * character.h (lisp_string_width): Adjust to new signature.
13839
cb93f9be
PE
13840 * alloc.c (string_overflow): New function.
13841 (Fmake_string): Use it. This doesn't change behavior, but saves
13842 a few bytes and will simplify future changes.
13843 * character.c (string_escape_byte8): Likewise.
13844 * lisp.h (string_overflow): New decl.
13845
1a1f3366
PE
13846 Fixups, following up to the user-interface timestamp change.
13847 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
13848 for UI timestamps, instead of unsigned long.
9fbd6841
PE
13849 * msdos.c (mouse_get_pos): Likewise.
13850 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
13851 * w32gui.h (Time): Define by including "systime.h" rather than by
13852 declaring it ourselves. (Bug#8664)
13853
d4e3e4d3
PE
13854 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
13855 * image.c (clear_image_cache): Likewise.
13856
f6a24d19
PE
13857 * term.c (term_mouse_position): Don't assume time_t wraparound.
13858
08dc5ae6
PE
13859 Be more systematic about user-interface timestamps.
13860 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
13861 and sometimes 'EMACS_UINT', to represent these timestamps.
13862 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
13863 This makes the code easier to follow, and makes it easier to catch
13864 integer overflow bugs such as Bug#8664.
13865 * frame.c (Fmouse_position, Fmouse_pixel_position):
13866 Use Time, not unsigned long, for user-interface timestamps.
13867 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
13868 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
13869 * keyboard.h (last_event_timestamp): Likewise.
13870 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
13871 * menu.h (xmenu_show): Likewise.
13872 * term.c (term_mouse_position): Likewise.
13873 * termhooks.h (struct input_event.timestamp): Likewise.
13874 (struct terminal.mouse_position_hook): Likewise.
13875 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
13876 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
13877 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
13878 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
13879 what it was before.
13880 * menu.h, termhooks.h: Include "systime.h", for Time.
13881
8e55734a
PE
13882 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
13883 Don't assume that the difference between two unsigned long values
13884 can fit into an integer. At this point, we know button_down_time
13885 <= event->timestamp, so the difference must be nonnegative, so
13886 there's no need to cast the result if double-click-time is
13887 nonnegative, as it should be; check that it's nonnegative, just in
13888 case. This bug is triggered when events are more than 2**31 ms
86db42d2 13889 apart (about 25 days). (Bug#8664)
8e55734a 13890
841f1b75 13891 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 13892 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 13893
3e26f69c
PE
13894 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
13895 that always fit in int. Use a sentinel instead of a counter, to
13896 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
13897 * frame.h (struct frame): Use int for menu_bar_items_used
13898 instead of EMACS_INT, since it always fits in int.
3e26f69c 13899
5cc152c0
PE
13900 * menu.c (grow_menu_items): Check for int overflow.
13901
d89eb65e
PE
13902 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
13903
5235bd3e
PE
13904 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
13905 Before, the code was not consistent. These values cannot exceed
13906 2**31 - 1 so there's no need to make them unsigned.
13907 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
13908 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
13909 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
13910 as modifiers.
13911 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
13912
bc827e23
PE
13913 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
13914 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
13915 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
13916 presumably because the widths might not match.
13917
78eb494e
PE
13918 * window.c (size_window): Avoid needless test at loop start.
13919
04f2d78b
CB
139202011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
13921
13922 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
13923
d2fc7e3d 139242011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
13925
13926 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
13927
d2fc7e3d 139282011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
13929
13930 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
13931 `width' to `bar_area_x' and `bar_area_width', respectively.
13932 (x_scroll_run): Take account of fringe background extension.
13933
04f2d78b
CB
13934 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
13935 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
13936 `bar_area_width', respectively.
13937 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
13938 background extension.
13939
79b70037
GM
139402011-05-10 Jim Meyering <meyering@redhat.com>
13941
13942 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
13943
2f142cc5
JB
139442011-05-10 Juanma Barranquero <lekktu@gmail.com>
13945
13946 * image.c (Finit_image_library): Return t for built-in image types,
13947 like pbm and xbm. (Bug#8640)
13948
57679c86
AS
139492011-05-09 Andreas Schwab <schwab@linux-m68k.org>
13950
13951 * w32menu.c (set_frame_menubar): Fix submenu allocation.
13952
888c9e86
EZ
139532011-05-07 Eli Zaretskii <eliz@gnu.org>
13954
b0512a1d
EZ
13955 * w32console.c (Fset_screen_color): Doc fix.
13956 (Fget_screen_color): New function.
13957 (syms_of_ntterm): Defsubr it.
13958
7285dc67
EZ
13959 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
13960 unlink the temporary file if Fcall_process didn't create it in the
13961 first place.
13962 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
13963 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
13964 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
13965 cue to call_process_cleanup not to close that handle.
13966
4d3fcc8e
BK
139672011-05-07 Ben Key <bkey76@gmail.com>
13968
13969 * makefile.w32-in: The bootstrap-temacs rule now makes use of
13970 one of two shell specific rules, either bootstrap-temacs-CMD or
13971 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
13972 to the previous implementation of the bootstrap-temacs rule.
13973 The bootstrap-temacs-CMD rule is similar to the previous
13974 implementation of the bootstrap-temacs rule except that it
13975 makes use of the ESC_CFLAGS variable instead of the CFLAGS
13976 variable.
13977
13978 These changes, along with some changes to nt/configure.bat,
13979 nt/gmake.defs, and nt/nmake.defs, are required to extend my
13980 earlier fix to add support for --cflags and --ldflags options
13981 that include quotes so that it works whether make uses cmd or
13982 sh as the shell.
13983
b4289b64
MA
139842011-05-06 Michael Albinus <michael.albinus@gmx.de>
13985
13986 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
13987 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
13988 is a constant.
13989 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
13990 a string. Handle both cases.
13991 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
13992 (Fdbus_register_method): Use Qinvalid_function.
13993
af4c0e28
JB
139942011-05-06 Juanma Barranquero <lekktu@gmail.com>
13995
13996 * makefile.w32-in: Update dependencies.
13997 (LISP_H): Add inttypes.h and stdin.h.
13998 (PROCESS_H): Add unistd.h.
13999
c51453d9
EZ
140002011-05-06 Eli Zaretskii <eliz@gnu.org>
14001
14002 * lread.c: Include limits.h (fixes the MS-Windows build broken by
14003 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
14004
8ff0ac3c 140052011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 14006
4c4b566b
PE
14007 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
14008
aab2b9b5
PE
14009 * term.c (vfatal): Remove stray call to va_end.
14010 It's not needed and the C Standard doesn't allow it here anyway.
14011
c378da0b
PE
14012 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
14013 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
14014
288b08c7
PE
14015 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
14016 bytes.
14017
e3601888
PE
14018 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
14019
db6c0e74
PE
14020 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
14021
dd5963ea
PE
14022 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
14023
88c9450f
PE
14024 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
14025
2f9442b8
PE
14026 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
14027
c032b5f8
PE
14028 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
14029 * charset.c (Fdefine_charset_internal): Don't initialize
14030 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 14031 32-bit int (Bug#8600).
a108c10b
PE
14032
14033 * lread.c (read_integer): Be more consistent with string-to-number.
14034 Use string_to_number to do the actual conversion; this avoids
14035 rounding errors and fixes some other screwups. Without this fix,
14036 for example, #x1fffffffffffffff was misread as -2305843009213693952.
14037 (digit_to_number): Move earlier, for benefit of read_integer.
14038 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 14039 not a digit in any supported base. (Bug#8602)
a108c10b 14040
ad5f9eea
PE
14041 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
14042
aec1708a
PE
14043 * dispnew.c (scrolling_window): Return 1 if we scrolled,
14044 to match comment at start of function. This also removes a
14045 GCC warning about overflow in a 32+64-bit port.
14046
47be4ab5
PE
14047 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
14048
371cac43
PE
14049 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
14050 Reported by Stefan Monnier in
14051 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
14052 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14053 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 14054
d01a7826
PE
14055 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
14056 (EMACS_UINTPTR): Likewise, with uintptr_t.
14057
7fd47d5c
PE
14058 * lisp.h: Prefer 64-bit EMACS_INT if available.
14059 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
14060 on 32-bit hosts that have 64-bit int, so that they can access
14061 large files.
122b0c86
PE
14062 However, temporarily disable this change unless the temporary
14063 symbol WIDE_EMACS_INT is defined.
7fd47d5c 14064
8727937b
PE
14065 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
14066
8ac068ac
PE
14067 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
14068 This removes an assumption that EMACS_INT and long are the same
14069 width as pointers. The assumption is true for Emacs porting targets
14070 now, but we want to make other targets possible.
14071 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
14072 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
14073 In the rest of the code, change types of integers that hold casted
14074 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
14075 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
14076 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
14077 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
14078 No need to cast type when ORing.
14079 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
14080 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
14081 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
14082 assume EMACS_INT is the same width as char *.
14083 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
14084 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
14085 Remove no-longer-needed casts.
14086 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
14087 (xg_tool_bar_help_callback, xg_make_tool_item):
14088 Use EMACS_INTPTR to hold an integer
14089 that will be cast to void *; this can avoid a GCC warning
14090 if EMACS_INT is not the same width as void *.
14091 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
14092 * xdisp.c (display_echo_area_1, resize_mini_window_1):
14093 (current_message_1, set_message_1):
14094 Use a local to convert to proper width without a cast.
14095 * xmenu.c (dialog_selection_callback): Likewise.
14096
ede49d71
PE
14097 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
14098 Also, don't assume VALBITS / RAND_BITS is less than 5,
14099 and don't rely on undefined behavior when shifting a 1 left into
14100 the sign bit.
14101 * lisp.h (get_random): Change signature to match.
14102
2f30ecd0
PE
14103 * lread.c (hash_string): Use size_t, not int, for hash computation.
14104 Normally we prefer signed values; but hashing is special, because
14105 it's better to use unsigned division on hash table sizes so that
14106 the remainder is nonnegative. Also, size_t is the natural width
14107 for hashing into memory. The previous code used 'int', which doesn't
14108 retain enough info to hash well into very large tables.
14109 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
14110
2a866e7b
PE
14111 * dbusbind.c: Don't possibly lose pointer info when converting.
14112 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14113 Use XPNTR rather than XHASH, so that the high-order bits of
14114 the pointer aren't lost when converting through void *.
14115
51639eac
PE
14116 * eval.c (Fautoload): Don't double-shift a pointer.
14117
92394119
PE
14118 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
14119
dbdb9a7c
JB
141202011-05-06 Juanma Barranquero <lekktu@gmail.com>
14121
14122 * gnutls.c (DEF_GNUTLS_FN):
14123 * image.c (DEF_IMGLIB_FN): Make function pointers static.
14124
db7a0b4f
AS
141252011-05-05 Andreas Schwab <schwab@linux-m68k.org>
14126
14127 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
14128 marker. (Bug#8610)
14129
cd394be1 141302011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
14131
14132 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
14133 New version that can reserve upto 2GB of heap space.
14134
f7ff1b0f 141352011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
14136
14137 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
14138
639c109b
TZ
141392011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
14140
14141 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
14142 `gnutls_certificate_set_x509_key_file'.
14143
d2127135
JB
141442011-05-05 Juanma Barranquero <lekktu@gmail.com>
14145
14146 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
14147 Update dependencies.
14148
e968f4f3
JB
141492011-05-04 Juanma Barranquero <lekktu@gmail.com>
14150
14151 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
14152 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
14153 Remove unused parameter `fildes'.
14154 * process.c (read_process_output, send_process): Don't pass it.
14155
84d358f0
JB
141562011-05-04 Juanma Barranquero <lekktu@gmail.com>
14157
14158 Fix previous change: the library cache is defined in w32.c.
14159 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
14160 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
14161
0898ca10
JB
141622011-05-04 Juanma Barranquero <lekktu@gmail.com>
14163
14164 Implement dynamic loading of GnuTLS on Windows.
14165
14166 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
14167 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
14168 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14169 Declare.
14170
14171 * gnutls.c (Qgnutls_dll): Define.
14172 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
14173 (gnutls_*): Declare function pointers.
14174 (init_gnutls_functions): New function to initialize function pointers.
14175 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
14176 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
14177 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14178 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
14179 (emacs_gnutls_write, emacs_gnutls_read)
14180 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
14181 (Fgnutls_available_p): New function.
14182 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
14183 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
14184 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
14185
14186 * image.c: Include w32.h.
14187 (Vimage_type_cache): Delete.
14188 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
14189 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
14190 (w32_delayed_load): Move to w32.c.
14191
14192 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
14193
14194 * w32.c (QCloaded_from, Vlibrary_cache): Define.
14195 (w32_delayed_load): Move from image.c. When loading a library, record
14196 its filename in the :loaded-from property of the library id.
14197 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
14198 Initialize and staticpro them.
14199 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
14200
14201 * process.c: Include lisp.h before w32.h, not after.
14202 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
14203 instead of gnutls_record_check_pending.
14204
14205 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
14206
ff4de4aa
TZ
142072011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
14208
14209 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
14210 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
14211 as passed in.
14212
abe95abb
JD
142132011-05-03 Jan Djärv <jan.h.d@swipnet.se>
14214
14215 * xterm.c (x_set_frame_alpha): Do not set property on anything
14216 else than FRAME_X_OUTER_WINDOW (Bug#8608).
14217
e16e55d4
JB
142182011-05-02 Juanma Barranquero <lekktu@gmail.com>
14219
14220 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
14221
bafcf6a5
JB
142222011-05-02 Juanma Barranquero <lekktu@gmail.com>
14223
14224 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
14225 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
14226 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
14227 (gnutls_global_initialized, Qgnutls_bootprop_priority)
14228 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
14229 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
14230 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
14231 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
14232 (Qgnutls_bootprop_callbacks_verify): Make static.
14233
e7a6747f
AS
142342011-05-01 Andreas Schwab <schwab@linux-m68k.org>
14235
19ed11ba
AS
14236 * callproc.c: Indentation fixup.
14237
e7a6747f 14238 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
14239 (wait_for_termination, interruptible_wait_for_termination):
14240 Move after wait_for_termination_1.
e7a6747f 14241
1ef14cb4
LMI
142422011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
14243
14244 * sysdep.c (interruptible_wait_for_termination): New function
14245 which is like wait_for_termination, but allows keyboard
14246 interruptions.
14247
14248 * callproc.c (Fcall_process): Add (:file "file") as an option for
14249 the STDOUT buffer.
14250 (Fcall_process_region): Ditto.
14251
330d880c
EZ
142522011-04-30 Eli Zaretskii <eliz@gnu.org>
14253
8db90b73
EZ
14254 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
14255 rather than `XVECTOR (FOO)->size'.
14256
330d880c
EZ
14257 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
14258 inttypes.h, as a gnulib replacement is used if it not available in
14259 system headers.
14260
15cbd324
EZ
142612011-04-21 Eli Zaretskii <eliz@gnu.org>
14262
14263 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
14264 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
14265 of MOST_POSITIVE_FIXNUM. (Bug#8528)
14266
14267 * coding.c (coding_alloc_by_realloc): Error out if destination
14268 will grow beyond MOST_POSITIVE_FIXNUM.
14269 (decode_coding_emacs_mule): Abort if there isn't enough place in
14270 charbuf for the composition carryover bytes. Reserve an extra
14271 space for up to 2 characters produced in a loop.
14272 (decode_coding_iso_2022): Abort if there isn't enough place in
14273 charbuf for the composition carryover bytes.
14274
142752011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 14276
ae940cca
EZ
14277 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
14278 aborting when %lld or %lll format is passed.
14279 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
14280 %llo or %llx format is passed. (Bug#8545)
14281
03ab8921
EZ
14282 * window.c (window_scroll_line_based): Use a marker instead of
14283 simple variables to record original value of point. (Bug#7952)
14284
afda1437
EZ
14285 * doprnt.c (doprnt): Fix the case where a multibyte sequence
14286 produced by %s or %c overflows available buffer space. (Bug#8545)
14287
f76dee0c
PE
142882011-04-28 Paul Eggert <eggert@cs.ucla.edu>
14289
14290 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 14291 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 14292
fdc5744d
JB
142932011-04-28 Juanma Barranquero <lekktu@gmail.com>
14294
14295 * w32.c (init_environment): Warn about defaulting HOME to C:\.
14296
638f053a
JB
142972011-04-28 Juanma Barranquero <lekktu@gmail.com>
14298
14299 * keyboard.c (Qdelayed_warnings_hook): Define.
14300 (command_loop_1): Run `delayed-warnings-hook'
14301 if Vdelayed_warnings_list is non-nil.
14302 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
14303 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
14304
d178f871
EZ
143052011-04-28 Eli Zaretskii <eliz@gnu.org>
14306
14307 * doprnt.c (doprnt): Don't return value smaller than the buffer
14308 size if the message was truncated. (Bug#8545).
14309
b124fd93
JB
143102011-04-28 Juanma Barranquero <lekktu@gmail.com>
14311
14312 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
14313 (Fx_window_property): #if-0 the whole functions, not just the bodies.
14314
e810457d
PE
143152011-04-27 Paul Eggert <eggert@cs.ucla.edu>
14316
14317 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
14318
ea51cceb
JB
143192011-04-27 Juanma Barranquero <lekktu@gmail.com>
14320
14321 * makefile.w32-in: Update dependencies.
14322
94dcfacf
EZ
143232011-04-27 Eli Zaretskii <eliz@gnu.org>
14324
14325 Improve `doprnt' and its usage. (Bug#8545)
14326 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
14327 `format_end'. Remove support for %l as a conversion specifier.
14328 Don't use xrealloc. Improve diagnostics when the %l size modifier
14329 is used. Update the commentary.
14330
14331 * eval.c (verror): Simplify calculation of size_t.
14332
14333 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
14334 messages.
14335
f61f41d7
PE
143362011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
14337
14338 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
14339 change.
14340
96fb4434
PE
143412011-04-27 Paul Eggert <eggert@cs.ucla.edu>
14342
14343 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
14344 This makes this file independent of the recent pseudovector change.
14345
671875da 143462011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 14347
69e9b5a3
PE
14348 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
14349
b5f869a7 14350 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 14351 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 14352 Remove unused local.
c8926152 14353 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 14354
841a1577 14355 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
14356 GCC 4.6.0 optimizes based on type-based alias analysis.
14357 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
14358 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
14359 != &v->size, and therefore "v->size = 1; b->size = 2; return
14360 v->size;" must therefore return 1. This assumption is incorrect
14361 for Emacs, since it type-puns struct Lisp_Vector * with many other
14362 types. To fix this problem, this patch adds a new type struct
f904488f 14363 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
14364 and pseudovectors, and helps optimizing compilers not get fooled
14365 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
14366 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
14367 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
14368 the size member.
eab3844f
PE
14369 (XSETPVECTYPE): Rewrite in terms of new macro.
14370 (XSETPVECTYPESIZE): New macro, specifying both type and size.
14371 This is a bit clearer, and further avoids the possibility of
14372 undesirable aliasing.
14373 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 14374 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
14375 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
14376 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
14377 (ASIZE): Now uses header.size rather than size.
14378 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
14379 to avoid the hassle of writing XVECTOR (foo)->header.size.
14380 (struct vectorlike_header): New type.
eab3844f
PE
14381 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
14382 object, to help avoid aliasing.
14383 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
14384 (SUBRP): Likewise, since Lisp_Subr is a special case.
14385 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
14386 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
14387 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 14388 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
14389 changed to be "header.size" and "header.next".
14390 * buffer.h (struct buffer): Likewise.
14391 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
14392 * frame.h (struct frame): Likewise.
14393 * process.h (struct Lisp_Process): Likewise.
14394 * termhooks.h (struct terminal): Likewise.
14395 * window.c (struct save_window_data, struct saved_window): Likewise.
14396 * window.h (struct window): Likewise.
14397 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
14398 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
14399 * buffer.c (init_buffer_once): Likewise.
14400 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
14401 special case.
14402 * process.c (Fformat_network_address): Use local var for size,
14403 for brevity.
14404
0df1eac5
PE
14405 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
14406
847ab9d1 14407 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
14408 * data.c (atof): Remove decl; no longer used or needed.
14409 (digit_to_number): Move to lread.c.
14410 (Fstring_to_number): Use new string_to_number function, to be
14411 consistent with how the Lisp reader treats infinities and NaNs.
14412 Do not assume that floating-point numbers represent EMACS_INT
14413 without losing information; this is not true on most 64-bit hosts.
14414 Avoid double-rounding errors, by insisting on integers when
14415 parsing non-base-10 numbers, as the documentation specifies.
14416 * lisp.h (string_to_number): New decl, replacing ...
14417 (isfloat_string): Remove.
bc0a5c13 14418 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 14419 (read1): Do not accept +. and -. as integers; this
452f4150
PE
14420 appears to have been a coding error. Similarly, do not accept
14421 strings like +-1e0 as floating point numbers. Do not report
14422 overflow for integer overflows unless the base is not 10 which
14423 means we have no simple and reliable way to continue.
14424 Break out the floating-point parsing into a new
14425 function string_to_number, so that Fstring_to_number parses
14426 floating point numbers consistently with the Lisp reader.
04f2d78b 14427 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
14428 (E_CHAR, EXP_INT): Remove, replacing with ...
14429 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
14430 (string_to_number): New function, replacing isfloat_string.
14431 This function checks for valid syntax and produces the resulting
14432 Lisp float number too. Rework it so that string-to-number
bc0a5c13 14433 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
14434 so that overflow for non-base-10 numbers is reported only when
14435 there's no portable and simple way to convert to floating point.
452f4150 14436
67769ffc
PE
14437 * textprop.c (set_text_properties_1): Rewrite for clarity,
14438 and to avoid GCC warning about integer overflow.
14439
c20db43f
PE
14440 * intervals.h (struct interval): Use EMACS_INT for members
14441 where EMACS_UINT might cause problems. See
14442 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
14443 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
14444 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
14445 All uses changed.
37aa2f85
PE
14446 (offset_intervals): Tell GCC not to worry about length overflow
14447 when negating a negative length.
c20db43f 14448
2538aa2f
PE
14449 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
14450 (overrun_check_free): Likewise.
14451
f2d3008d
PE
14452 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
14453 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
14454 word size.
14455
ec8df744
PE
14456 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
14457 (gnutls_make_error): Rename local to avoid shadowing.
14458 (gnutls_emacs_global_deinit): ifdef out; not used.
14459 (Fgnutls_boot): Use const for pointer to readonly storage.
14460 Comment out unused local. Fix pointer signedness problems.
14461
640ee02d
PE
14462 * lread.c (openp): Don't stuff size_t into an 'int'.
14463 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
14464 about possible signed overflow.
14465
6048fb2a
PE
14466 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
14467 (GDK_KEY_g): Don't define if already defined.
14468 (xg_prepare_tooltip): Avoid pointer signedness problem.
14469 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
14470
fa3c87e1
PE
14471 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
14472 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
14473
2172544b
PE
14474 * xfns.c (Fx_window_property): Simplify a bit,
14475 to make a bit faster and to avoid GCC 4.6.0 warning.
14476 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
14477
9b821a21
PE
14478 * fns.c (internal_equal): Don't assume size_t fits in int.
14479
3c616cfa
PE
14480 * alloc.c (compact_small_strings): Tighten assertion a little.
14481
c2982e87
PE
14482 Replace pEd with more-general pI, and fix some printf arg casts.
14483 * lisp.h (pI): New macro, generalizing old pEd macro to other
14484 conversion specifiers. For example, use "...%"pI"d..." rather
14485 than "...%"pEd"...".
14486 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 14487 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
14488 * alloc.c (check_pure_size): Don't overflow by converting size to int.
14489 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
14490 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
14491 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
14492 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
14493 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
14494 64-bit hosts.
14495 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
14496 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
14497 * print.c (safe_debug_print, print_object): Likewise.
14498 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
14499 to int.
6f04d126
PE
14500 Use pI instead of if-then-else-abort. Use %p to avoid casts,
14501 avoiding the 0 flag, which is not portable.
c2982e87
PE
14502 * process.c (Fmake_network_process): Use pI to avoid cast.
14503 * region-cache.c (pp_cache): Likewise.
14504 * xdisp.c (decode_mode_spec): Likewise.
14505 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
14506 behavior on 64-bit hosts with printf arg.
6f04d126 14507 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
14508 (x_stop_queuing_selection_requests): Likewise.
14509 (x_get_window_property): Don't truncate byte count to an 'int'
14510 when tracing.
0b432f21 14511
5e073ec7
PE
14512 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
14513 here, since it parses constructs like leading '-' and spaces,
14514 which are not wanted; and it overflows with large numbers.
14515 Instead, simply match F[0-9]+, which is what is wanted anyway.
14516
36372bf9
PE
14517 * alloc.c: Remove unportable assumptions about struct layout.
14518 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
14519 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
14520 (allocate_vectorlike, make_pure_vector): Use the new macros,
14521 plus offsetof, to remove unportable assumptions about struct layout.
14522 These assumptions hold on all porting targets that I know of, but
14523 they are not guaranteed, they're easy to remove, and removing them
14524 makes further changes easier.
14525
0b432f21
PE
14526 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
14527 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
14528 (string_overrun_cookie): Now const. Use initializers that
14529 don't formally overflow signed char, to avoid warnings.
000098c1
PE
14530 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
14531 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
14532 (allocate_buffer): Don't assume sizeof (struct buffer) is a
14533 multiple of sizeof (EMACS_INT); it need not be, if
14534 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 14535 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 14536
895009e1
JB
145372011-04-26 Juanma Barranquero <lekktu@gmail.com>
14538
14539 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
14540
6a7a1b0b
TZ
145412011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
14542
14543 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 14544 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
14545 Reported by Paul Eggert <eggert@cs.ucla.edu>.
14546
841a1577 145472011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
14548
14549 * lisp.h (Qdebug): List symbol.
895009e1 14550 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
14551 * keyboard.c (debug-on-event): New variable.
14552 (handle_user_signal): Break into debugger when debug-on-event
14553 matches the current signal symbol.
14554
f2d3ba6f
DN
145552011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
14556
14557 * alloc.c (check_sblock, check_string_bytes)
14558 (check_string_free_list): Convert to standard C.
14559
42ce4c63
TZ
145602011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
14561
14562 * w32.c (emacs_gnutls_push): Fix typo.
14563
825cd63c
EZ
145642011-04-25 Eli Zaretskii <eliz@gnu.org>
14565
fb11d64d
EZ
14566 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
14567 "cast to pointer from integer of different size".
14568
825cd63c
EZ
14569 Improve doprnt and its use in verror. (Bug#8545)
14570 * doprnt.c (doprnt): Document the set of format control sequences
14571 supported by the function. Use SAFE_ALLOCA instead of always
14572 using `alloca'.
14573
14574 * eval.c (verror): Don't limit the buffer size at size_max-1, that
14575 is one byte too soon. Don't use xrealloc; instead xfree and
14576 xmalloc anew.
14577
e061a11b
TZ
145782011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
14579
14580 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
14581 callbacks stage.
14582
14583 * gnutls.c: Renamed global_initialized to
14584 gnutls_global_initialized. Added internals for the
14585 :verify-hostname-error, :verify-error, and :verify-flags
14586 parameters of `gnutls-boot' and documented those parameters in the
14587 docstring. Start callback support.
9173deec
JB
14588 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
14589 unless a fatal error occurred. Call gnutls_alert_send_appropriate
14590 on error. Return error code.
e061a11b
TZ
14591 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
14592 (emacs_gnutls_read): Likewise.
14593 (Fgnutls_boot): Return handshake error code.
14594 (emacs_gnutls_handle_error): New function.
14595 (wsaerror_to_errno): Likewise.
14596
14597 * w32.h (emacs_gnutls_pull): Add prototype.
14598 (emacs_gnutls_push): Likewise.
14599
14600 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
14601 (emacs_gnutls_push): Likewise.
14602
146032011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
14604
14605 * process.c (wait_reading_process_output): Check if GnuTLS
14606 buffered some data internally if no FDs are set for TLS
14607 connections.
14608
14609 * makefile.w32-in (OBJ2): Add gnutls.$(O).
14610 (LIBS): Link to USER_LIBS.
14611 ($(BLD)/gnutls.$(0)): New target.
14612
fa6996bc
EZ
146132011-04-24 Eli Zaretskii <eliz@gnu.org>
14614
eb35682e
EZ
14615 * xdisp.c (handle_single_display_spec): Rename the
14616 display_replaced_before_p argument into display_replaced_p, to
14617 make it consistent with the commentary. Fix typos in the
14618 commentary.
14619
e2ad650c
EZ
14620 * textprop.c (syms_of_textprop): Remove dead code.
14621 (copy_text_properties): Delete obsolete commentary about an
14622 interface that was deleted long ago. Fix typos in the description
14623 of arguments.
14624
1b2de274
EZ
14625 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
14626 to changes in oldXMenu/XMenu.h from 2011-04-16.
14627 <menu_help_message, prev_menu_help_message>: Constify.
14628 (IT_menu_make_room): menu->help_text is now `const char **';
14629 adjust.
14630
14631 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
14632 to changes in oldXMenu/XMenu.h from 2011-04-16.
14633 (struct XMenu): Declare `help_text' `const char **'.
14634
14635 * xfaces.c <Qunspecified>: Make extern again.
14636
14637 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 14638 required by POSIX.
1b2de274 14639
762b15be
EZ
14640 * doc.c (get_doc_string): Improve the format passed to `error'.
14641
14642 * doprnt.c (doprnt): Improve commentary.
14643
14644 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
14645
14646 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
14647 them with etags.
14648
f1052e5d
EZ
14649 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
14650 changes in globals.h immediately force recompilation.
762b15be
EZ
14651 (TAGS): Depend on $(CURDIR)/m/intel386.h and
14652 $(CURDIR)/s/ms-w32.h.
14653 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 14654
fa6996bc
EZ
14655 * character.c (Fchar_direction): Function deleted.
14656 (syms_of_character): Don't defsubr it.
14657 <char-direction-table>: Deleted.
14658
e6c3da20
EZ
146592011-04-23 Eli Zaretskii <eliz@gnu.org>
14660
14661 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
14662 * doprnt.c: Include limits.h.
14663 (SIZE_MAX): New macro.
04f2d78b
CB
14664 (doprnt): Return a size_t value. 2nd arg is now size_t.
14665 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
14666 Improve overflow protection. Support `l' modifier for integer
14667 conversions. Support %l conversion. Don't assume an EMACS_INT
14668 argument for integer conversions and for %c.
14669
14670 * lisp.h (doprnt): Restore prototype.
14671
14672 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
14673 $(SRC)/character.h.
14674
14675 * Makefile.in (base_obj): Add back doprnt.o.
14676
14677 * deps.mk (doprnt.o): Add back prerequisites.
14678 (callint.o): Depend on character.h.
14679
14680 * eval.c (internal_lisp_condition_case): Include the handler
14681 representation in the error message.
14682 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
14683 when breaking from the loop.
14684
14685 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
14686
14687 * callint.c (Fcall_interactively): When displaying error message
14688 about invalid control letter, pass the character's codepoint, not
14689 a pointer to its multibyte form. Improve display of the character
14690 in octal and display also its hex code.
14691
14692 * character.c (char_string): Use %x to display the (unsigned)
14693 codepoint of an invalid character, to avoid displaying a bogus
14694 negative value.
14695
14696 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
14697 `error', not SYMBOL_NAME itself.
14698
14699 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
14700 character arguments to `error'.
14701
14702 * charset.c (check_iso_charset_parameter): Fix incorrect argument
14703 to `error' in error message about FINAL_CHAR argument. Make sure
14704 FINAL_CHAR is a character, and use %c when it is passed as
14705 argument to `error'.
14706
4ffd0d6b 147072011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
14708
14709 * s/ms-w32.h (localtime): Redirect to sys_localtime.
14710
14711 * w32.c: Include <time.h>.
14712 (sys_localtime): New function.
14713
4ffd0d6b 147142011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
14715
14716 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
14717
4ffd0d6b 14718 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 14719
4ffd0d6b 147202011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 14721
4ffd0d6b
GM
14722 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
14723 zombies (Bug#8467).
aac0c6e3 14724
04c56954
EZ
147252011-04-19 Eli Zaretskii <eliz@gnu.org>
14726
14727 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
14728 gl_state.e_property when gl_state.object is Qt.
14729
14730 * insdel.c (make_gap_larger): Remove limitation of buffer size
14731 to <= INT_MAX.
14732
16a43933
CY
147332011-04-18 Chong Yidong <cyd@stupidchicken.com>
14734
14735 * xdisp.c (lookup_glyphless_char_display)
14736 (produce_glyphless_glyph): Handle cons cell entry in
14737 glyphless-char-display.
14738 (Vglyphless_char_display): Document it.
14739
14740 * term.c (produce_glyphless_glyph): Handle cons cell entry in
14741 glyphless-char-display.
14742
4581706e
CY
147432011-04-17 Chong Yidong <cyd@stupidchicken.com>
14744
14745 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
14746
14747 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
14748
14749 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
14750 definition for no-X builds.
14751
4887c6e2 147522011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 14753
fd35b6f9
PE
14754 Static checks with GCC 4.6.0 and non-default toolkits.
14755
5c1ccb01
PE
14756 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
14757
006c5daa
PE
14758 * process.c (keyboard_bit_set): Define only if SIGIO.
14759 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
14760 (send_process): Repair possible setjmp clobbering.
14761
efc736d3
PE
14762 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
14763
4e2fe2e6
PE
14764 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
14765
f97334a2
PE
14766 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
14767
4e75f29d
PE
14768 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
14769 Define only if needed.
14770
90efadd1
PE
14771 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
14772 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 14773 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 14774
3c647824
PE
14775 * dispextern.h (struct redisplay_interface): Rename param
14776 to avoid shadowing.
e264f262 14777 * termhooks.h (struct terminal): Likewise.
761383f4 14778 * xterm.c (xembed_send_message): Likewise.
3c647824 14779
b58c5c4a
PE
14780 * insdel.c (make_gap_smaller): Define only if
14781 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
14782
cad59032
PE
14783 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
14784 it.
14785
c339dc2e
PE
14786 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
14787 so that we aren't warned about unused symbols.
14788
91a3e27b
PE
14789 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
14790
399c71d3 14791 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 14792
8ffc96f5
PE
14793 * xfns.c (x_real_positions): Mark locals as initialized.
14794
eef9bc79
PE
14795 * xmenu.c (xmenu_show): Don't use uninitialized vars.
14796
098db9dd
PE
14797 * xterm.c: Fix problems found by static analysis with other toolkits.
14798 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
14799 (x_dispatch_event): Declare static if USE_GTK, and
14800 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 14801 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 14802 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
14803 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
14804 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 14805
eb18f6cc
PE
14806 * xmenu.c (menu_help_callback): Pointer type fixes.
14807 Use const pointers when pointing at readonly data. Avoid pointer
14808 signedness clashes.
14809 (FALSE): Remove unused macro.
14810 (update_frame_menubar): Remove unused decl.
14811
1fe72bf8
PE
14812 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
14813
60d9e1db
PE
14814 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
14815 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
14816 (single_menu_item): Rename local to avoid shadowing.
14817
39261c26
PE
14818 * keyboard.c (make_lispy_event): Remove unused local var.
14819
018c5e19
PE
14820 * frame.c, frame.h (x_get_resource_string): Bring this back, but
14821 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
14822
63d2b86e
PE
14823 * bitmaps: Change bitmaps from unsigned char back to the X11
14824 compatible char. Avoid the old compiler warnings about
14825 out-of-range initializers by using, for example, '\xab' rather
14826 than 0xab.
14827
aefd87e1
PE
14828 * xgselect.c (xgselect_initialize): Check vs interface
14829 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
14830
bf501fb9
PE
14831 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
14832
e9829fdf
PE
14833 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
14834 to read-only memory.
14835
1086c095
PE
14836 * fns.c (vector): Remove; this old hack is no longer needed.
14837
2baccd04 14838 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 14839 Remove unused var.
dde42981 14840 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 14841
72391843 14842 * xrdb.c (x_load_resources): Omit unused local.
3565b346 14843
436c16df 14844 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 14845 (x_window): Rename locals to avoid shadowing.
dc5ddd85 14846 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 14847
92bb796d 14848 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 14849 (x_term_init): Remove local to avoid shadowing.
92bb796d 14850
764430a3 14851 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
14852
14853 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
14854 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
14855
d1dfb56c
EZ
148562011-04-16 Eli Zaretskii <eliz@gnu.org>
14857
c4354cb4
EZ
14858 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
14859
d1dfb56c
EZ
14860 Fix regex.c, syntax.c and friends for buffers > 2GB.
14861 * syntax.h (struct gl_state_s): Declare character position members
14862 EMACS_INT.
14863
14864 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
14865
04f2d78b
CB
14866 * textprop.c (verify_interval_modification, interval_of):
14867 Declare arguments EMACS_INT.
d1dfb56c
EZ
14868
14869 * intervals.c (adjust_intervals_for_insertion): Declare arguments
14870 EMACS_INT.
14871
14872 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
14873
14874 * indent.c (Fvertical_motion): Local variable it_start is now
14875 EMACS_INT.
14876
14877 * regex.c (re_match, re_match_2, re_match_2_internal)
14878 (bcmp_translate, regcomp, regexec, print_double_string)
14879 (group_in_compile_stack, re_search, re_search_2, regex_compile)
14880 (re_compile_pattern, re_exec): Declare arguments and local
14881 variables `size_t' and `ssize_t' and return values `regoff_t', as
14882 appropriate.
14883 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
14884 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
14885 <compile_stack_type>: `size' and `avail' are now `size_t'.
14886
14887 * regex.h <regoff_t>: Use ssize_t, not int.
14888 (re_search, re_search_2, re_match, re_match_2): Arguments that
14889 specify buffer/string position and length are now ssize_t and
14890 size_t. Return type is regoff_t.
14891
613052cd
BK
148922011-04-16 Ben Key <bkey76@gmail.com>
14893
14894 * nsfont.m: Fixed bugs in ns_get_family and
14895 ns_descriptor_to_entity that were caused by using free to
14896 deallocate memory blocks that were allocated by xmalloc (via
14897 xstrdup). This caused Emacs to crash when compiled with
14898 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
14899 --enable-checking=xmallocoverrun). xfree is now used to
14900 deallocate these memory blocks.
14901
4170f62f 149022011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 14903
71b41406
PE
14904 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
14905
9587a89d
PE
14906 emacs_write: Accept and return EMACS_INT for sizes.
14907 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
14908 et seq.
14909 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
14910 Accept and return EMACS_INT.
14911 (emacs_gnutls_write): Return the number of bytes written on
14912 partial writes.
14913 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
14914 (emacs_read, emacs_write): Remove check for negative size, as the
14915 Emacs source code has been audited now.
9587a89d
PE
14916 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
14917 (emacs_read, emacs_write): Use it.
273a5f82
PE
14918 * process.c (send_process): Adjust to the new signatures of
14919 emacs_write and emacs_gnutls_write. Do not attempt to store
14920 a byte offset into an 'int'; it might overflow.
9587a89d 14921 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 14922
3e047f51
PE
14923 * sound.c: Don't assume sizes fit in 'int'.
14924 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 14925 Return EMACS_INT, not int.
3e047f51 14926 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
14927 Accept EMACS_INT, not int.
14928 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
14929 record read return values.
14930
cc39a9db
BK
149312011-04-15 Ben Key <bkey76@gmail.com>
14932
c9d0ec6d
JB
14933 * keyboard.c (Qundefined): Don't declare static since it is used
14934 in nsfns.m.
14935 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
14936 static since they are used in nsfont.m.
cc39a9db 14937
6c60eb9f
SM
149382011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
14939
14940 * process.c (Qprocessp): Don't declare static.
14941 * lisp.h (Qprocessp): Declare again.
14942
7990b61a
JB
149432011-04-15 Juanma Barranquero <lekktu@gmail.com>
14944
14945 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
14946
5d4cb038
PE
149472011-04-14 Paul Eggert <eggert@cs.ucla.edu>
14948
8bd7b830 14949 Improve C-level modularity by making more things 'static'.
cd64ea1d 14950
e3b27b31
PE
14951 Don't publish debugger-only interfaces to other modules.
14952 * lisp.h (safe_debug_print, debug_output_compilation_hack):
14953 (verify_bytepos, count_markers): Move decls to the only modules
14954 that need them.
14955 * region-cache.h (pp_cache): Likewise.
14956 * window.h (check_all_windows): Likewise.
14957 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
14958
5d4cb038
PE
14959 * sysdep.c (croak): Now static, if
14960 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
14961 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
14962
14963 * alloc.c (refill_memory_reserve): Now static if
14964 !defined REL_ALLOC || defined SYSTEM_MALLOC.
14965 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 14966
e87b6180
PE
14967 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
14968 Define only if USE_LUCID.
14969
ac64929e
PE
14970 * xrdb.c (x_customization_string, x_rm_string): Now static.
14971
6f37259d
PE
14972 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
14973 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
14974
1683e3ab
PE
14975 * xdisp.c (draw_row_with_mouse_face): Now static.
14976 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
14977
de9c2632
PE
14978 * window.h (check_all_windows): Mark externally visible.
14979
2b96acb7
PE
14980 * window.c (window_deletion_count): Now static.
14981
14982 * undo.c: Make symbols static if they're not exported.
14983 (last_undo_buffer, last_boundary_position, pending_boundary):
14984 Now static.
14985
50436f33
PE
14986 * textprop.c (interval_insert_behind_hooks): Now static.
14987 (interval_insert_in_front_hooks): Likewise.
14988
64520e5c
PE
14989 * term.c: Make symbols static if they're not exported.
14990 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
14991 (max_frame_lines, tty_set_terminal_modes):
14992 (tty_reset_terminal_modes, tty_turn_off_highlight):
14993 (get_tty_terminal): Now static.
14994 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
14995 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 14996 HAVE_WINDOW_SYSTEM.
64520e5c
PE
14997 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
14998 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
14999
1fa53021
PE
15000 * sysdep.c: Make symbols static if they're not exported.
15001 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
15002 Now static.
15003 (sigprocmask_set, full_mask): Remove; unused.
15004 (wait_debugging): Mark as visible.
15005 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
15006 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
15007
d4b43b22
PE
15008 * syntax.c (syntax_temp): Define only if !__GNUC__.
15009
b7c513d0
PE
15010 * sound.c (current_sound_device, current_sound): Now static.
15011
989b29ad
PE
15012 * search.c (searchbufs, searchbuf_head): Now static.
15013
13a55a78
PE
15014 * scroll.c (scroll_cost): Remove; unused.
15015 * dispextern.h (scroll_cost): Remove decl.
15016
de68a1fc
PE
15017 * region-cache.h (pp_cache): Mark as externally visible.
15018
40ccffa6
PE
15019 * process.c: Make symbols static if they're not exported.
15020 (process_tick, update_tick, create_process, chan_process):
15021 (Vprocess_alist, proc_buffered_char, datagram_access):
15022 (fd_callback_data, send_process_frame, process_sent_to): Now static.
15023 (deactivate_process): Mark defn as static, as well as decl.
15024 * lisp.h (create_process): Remove decl.
15025 * process.h (chan_process, Vprocess_alist): Remove decls.
15026
ad64fc97
PE
15027 * print.c: Make symbols static if they're not exported.
15028 (print_depth, new_backquote_output, being_printed, print_buffer):
15029 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
15030 (print_interval, print_number_index, initial_stderr_stream):
15031 Now static.
15032 * lisp.h (Fprinc): Remove decl.
15033 (debug_output_compilation_hack): Mark as externally visible.
15034
adddb265
PE
15035 * sysdep.c (croak): Move decl from here to syssignal.h.
15036 * syssignal.h (croak): Put it here, so the API can be checked when
15037 'croak' is called from dissociate_if_controlling_tty.
15038
1717ede2
PE
15039 * minibuf.c: Make symbols static if they're not exported.
15040 (minibuf_save_list, choose_minibuf_frame): Now static.
15041 * lisp.h (choose_minibuf_frame): Remove decl.
15042
fa5fb2bc
PE
15043 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
15044
1e3890d1
PE
15045 * lread.c: Make symbols static if they're not exported.
15046 (read_objects, initial_obarray, oblookup_last_bucket_number):
15047 Now static.
15048 (make_symbol): Remove; unused.
15049 * lisp.h (initial_obarray, make_symbol): Remove decls.
15050
8a1414fa
PE
15051 * keyboard.c: Make symbols static if they're not exported.
15052 (single_kboard, recent_keys_index, total_keys, recent_keys):
15053 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
15054 (this_single_command_key_start, echoing, last_auto_save):
15055 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
15056 (command_loop, echo_now, keyboard_init_hook, help_char_p):
15057 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
15058 (Vlispy_mouse_stem, double_click_count):
15059 Now static.
15060 (force_auto_save_soon): Define only if SIGDANGER.
15061 (ignore_mouse_drag_p): Now static if
15062 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
15063 (print_help): Remove; unused.
15064 (stop_character, last_timer_event): Mark as externally visible.
15065 * keyboard.h (ignore_mouse_drag_p): Declare only if
15066 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
15067 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
15068 * lisp.h (echoing): Remove decl.
15069 (force_auto_save_soon): Declare only if SIGDANGER.
15070 * xdisp.c (redisplay_window): Simplify code, to make it more
15071 obvious that ignore_mouse_drag_p is not accessed if !defined
15072 USE_GTK && !defined HAVE_NS.
15073
93ea6e8f
PE
15074 * intervals.c: Make symbols static if they're not exported.
15075 (merge_properties_sticky, merge_interval_right, delete_interval):
15076 Now static.
15077 * intervals.h (merge_interval_right, delete_interval): Remove decls.
15078
77382fcc
PE
15079 * insdel.c: Make symbols static if they're not exported.
15080 However, leave prepare_to_modify_buffer alone. It's never
15081 called from outside this function, but that appears to be a bug.
15082 (combine_after_change_list, combine_after_change_buffer):
4889fc82 15083 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
15084 (adjust_after_replace_noundo): Remove; unused.
15085 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 15086 (signal_before_change): Remove decls.
77382fcc 15087
9306c32e
PE
15088 * indent.c (val_compute_motion, val_vmotion): Now static.
15089
cd44d2eb
PE
15090 * image.c: Make symbols static if they're not exported.
15091 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
15092 if USE_GTK.
15093 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
15094 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
15095
ad9a7a06
PE
15096 * fringe.c (standard_bitmaps): Now static.
15097 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
15098
81626931
PE
15099 * frame.c: Make symbols static if they're not exported.
15100 (x_report_frame_params, make_terminal_frame): Now static.
15101 (get_frame_param): Now static, unless HAVE_NS.
15102 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
15103 (x_get_resource_string): Remove; not used.
15104 * frame.h (make_terminal_frame, x_report_frame_params):
15105 (x_get_resource_string); Remove decls.
15106 (x_fullscreen_adjust): Declare only if WINDOWSNT.
15107 * lisp.h (get_frame_param): Declare only if HAVE_NS.
15108
239f9db9
PE
15109 * font.c, fontset.c: Make symbols static if they're not exported.
15110 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
15111 (FACE_SUITABLE_FOR_CHAR_P): Use it.
15112 * font.c (font_close_object): Now static.
15113 * font.h (font_close_object): Remove.
15114 * fontset.c (FONTSET_OBJLIST): Remove.
15115 (free_realized_fontset) #if-0 the body, which does nothing.
15116 (face_suitable_for_char_p): #if-0, as it's never called.
15117 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
15118 * xfaces.c (face_at_string_position):
15119 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
15120 since 0 is always ASCII.
15121
dfcf3579
PE
15122 * fns.c (weak_hash_tables): Now static.
15123
5045092b
PE
15124 * fileio.c: Make symbols static if they're not exported.
15125 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
15126 (Vwrite_region_annotation_buffers): Now static.
15127
57a96f5c
PE
15128 * eval.c: Make symbols static if they're not exported.
15129 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
15130 * lisp.h (backtrace_list): Remove decl.
15131
35f08c38
PE
15132 * emacs.c: Make symbols static if they're not exported.
15133 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
15134 (fatal_error_code, fatal_error_signal_hook, standard_args):
15135 Now static.
15136 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
15137 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
15138 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
15139 * lisp.h (fatal_error_signal_hook): Remove decl.
15140 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
15141
f44bd759
PE
15142 * editfns.c: Move a (normally-unused) function to its only use.
15143 * editfns.c, lisp.h (get_operating_system_release): Remove.
15144 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
15145 worth the hassle of breaking this out.
15146
b532497d
PE
15147 * xterm.c: Make symbols static if they're not exported.
15148 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
15149 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
15150 (x_destroy_window, x_delete_display):
15151 Now static.
15152 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
15153 (x_mouse_leave): Remove; unused.
15154 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
15155 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
15156 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
15157 Remove decls.
15158 (x_mouse_leave): Declare only if WINDOWSNT.
15159 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
15160 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
15161 USE_X_TOOLKIT.
15162
1675728f
PE
15163 * ftxfont.c: Make symbols static if they're not exported.
15164 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
15165 HAVE_FREETYPE.
15166 * font.h (ftxfont_driver): Likewise.
15167
e4cebfca
PE
15168 * xfns.c: Make symbols static if they're not exported.
15169 (x_last_font_name, x_display_info_for_name):
15170 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
15171 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
15172 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
15173 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
15174 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
15175 (last_show_tip_args): Now static.
15176 (xic_defaut_fontset, xic_create_fontsetname): Define only if
15177 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
15178 (x_screen_planes): Remove; unused.
15179 * dispextern.h (x_screen_planes): Remove decl.
15180
5bf46f05
PE
15181 * dispnew.c: Make symbols static if they're not exported.
15182 * dispextern.h (redraw_garbaged_frames, scrolling):
15183 (increment_row_positions): Remove.
15184 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
15185 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
15186 Now static.
15187 (redraw_garbaged_frames): Remove; unused.
15188
435f4c28
PE
15189 * xfaces.c: Make symbols static if they're not exported.
15190 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
15191 Remove decls.
15192 * xterm.h (defined_color): Remove decls.
15193 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
15194 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
15195 (menu_face_changed_default, defined_color, free_realized_face):
15196 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
15197 (ascii_face_of_lisp_face): Remove; unused.
15198
8524aef3
PE
15199 * xdisp.c: Make symbols static if they're not exported.
15200 * dispextern.h (scratch_glyph_row, window_box_edges):
15201 (glyph_to_pixel_coords, set_cursor_from_row):
15202 (get_next_display_element, set_iterator_to_next):
15203 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
15204 (show_mouse_face): Remove decls
15205 * frame.h (message_buf_print): Likewise.
15206 * lisp.h (pop_message, set_message, check_point_in_composition):
15207 Likewise.
15208 * xterm.h (set_vertical_scroll_bar): Likewise.
15209 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
15210 (message_buf_print, scratch_glyph_row, displayed_buffer):
15211 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
15212 (get_next_display_element, show_mouse_face, window_box_edges):
15213 (frame_to_window_pixel_xy, check_point_in_composition):
15214 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
15215 (glyph_to_pixel_coords): Remove; unused.
15216
16390cd2
PE
15217 * dired.c (file_name_completion): Now static.
15218
15219 * dbusbind.c (xd_in_read_queued_messages): Now static.
15220
a25f4dfa
PE
15221 * lisp.h (circular_list_error, FOREACH): Remove; unused.
15222 * data.c (circular_list_error): Remove.
15223
14a9c8df
PE
15224 * commands.h (last_point_position, last_point_position_buffer):
15225 (last_point_position_window): Remove decls.
15226 * keyboard.c: Make these variables static.
15227
04f2d78b
CB
15228 * coding.h (coding, code_convert_region, encode_coding_gap):
15229 Remove decls.
74ab6df5
PE
15230 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
15231 (iso_code_class, detect_coding, code_convert_region): Now static.
15232 (encode_coding_gap): Remove; unused.
15233
38dfbee1
PE
15234 * chartab.c (chartab_chars, chartab_bits): Now static.
15235
a2cb4e63
PE
15236 * charset.h (charset_iso_8859_1): Remove decl.
15237 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
15238 Now static.
15239
127198fd
PE
15240 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
15241 * ccl.c (Vccl_program_table): Now static.
15242 (check_ccl_update): Remove; unused.
15243
d85b608f
PE
15244 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
15245 * category.h: ... from here.
15246 * category.c (check_category_table, set_category_set): Now static.
15247
31cd66f3
PE
15248 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
15249 * lisp.h: Remove these decls.
15250
c358e587
PE
15251 * buffer.c (buffer_count): Remove unused var.
15252
e78aecca
PE
15253 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
15254 so that it's not optimized away.
15255 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
15256 * dispextern.h (bidi_dump_cached_states): Remove, since it's
15257 exported only to the debugger.
15258
e192d7d3 15259 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 15260 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 15261
92470028
PE
15262 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
15263 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
15264 was inaccessible from Lisp.
15265 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
15266 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
15267
244ed907
PE
15268 alloc.c: Import and export fewer symbols, and remove unused items.
15269 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
15270 is defined.
15271 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
15272 it's not optimized away by whole-program optimization.
15273 (message_enable_multibyte, free_misc): Remove.
15274 (catchlist, handlerlist, mark_backtrace):
15275 Declare only if BYTE_MARK_STACK.
15276 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
15277 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
15278 (message_enable_multibyte): Remove decl.
15279 (free_misc, interval_free_list, float_block, float_block_index):
15280 (n_float_blocks, float_free_list, cons_block, cons_block_index):
15281 (cons_free_list, last_marked_index):
15282 Now static.
15283 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
15284 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
15285 (mark_backtrace): Define only if BYTE_MARK_STACK.
15286 * xdisp.c (message_enable_multibyte): Now static.
15287
61c2b50e 15288 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
15289 This makes it easier for human readers (and static analyzers)
15290 to see whether these variables are used from other modules.
15291 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
15292 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
15293 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
15294 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
15295 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
15296 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
15297 * xmenu.c, xselect.c:
15298 Declare Q* vars static if they are not used in other modules.
15299 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
15300 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
15301 Remove decls of unexported vars.
15302 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
15303
95c82688
PE
15304 * lisp.h (DEFINE_FUNC): Make sname 'static'.
15305
16a97296
PE
15306 Make Emacs functions such as Fatom 'static' by default.
15307 This makes it easier for human readers (and static analyzers)
15308 to see whether these functions can be called from other modules.
15309 DEFUN now defines a static function. To make the function external
15310 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
15311 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
15312 (Finit_image_library):
16a97296
PE
15313 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
15314 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
15315 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
15316 Remove decls, since these functions are now static.
15317 (Funintern, Fget_internal_run_time): New decls, since these functions
15318 were already external.
95c82688 15319
16a97296
PE
15320 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
15321 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
15322 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
15323 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
15324 * keyboard.c, keymap.c, lread.c:
15325 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
15326 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
15327 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
15328 Mark functions with DEFUE instead of DEFUN,
15329 if they are used in other modules.
15330 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
15331 decls for now-static functions.
15332 * buffer.h (Fdelete_overlay): Remove decl.
15333 * callproc.c (Fgetenv_internal): Mark as internal.
15334 * composite.c (Fremove_list_of_text_properties): Remove decl.
15335 (Fcomposition_get_gstring): New forward static decl.
15336 * composite.h (Fcomposite_get_gstring): Remove decl.
15337 * dired.c (Ffile_attributes): New forward static decl.
15338 * doc.c (Fdocumntation_property): New forward static decl.
15339 * eval.c (Ffetch_bytecode): New forward static decl.
15340 (Funintern): Remove extern decl; now in .h file where it belongs.
15341 * fileio.c (Fmake_symbolic_link): New forward static decl.
15342 * image.c (Finit_image_library): New forward static decl.
15343 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
15344 * intervals.h (Fprevious_property_change):
15345 (Fremove_list_of_text_properties): Remove decls.
15346 * keyboard.c (Fthis_command_keys): Remove decl.
15347 (Fcommand_execute): New forward static decl.
15348 * keymap.c (Flookup_key): New forward static decl.
15349 (Fcopy_keymap): Now static.
15350 * keymap.h (Flookup_key): Remove decl.
15351 * process.c (Fget_process): New forward static decl.
15352 (Fprocess_datagram_address): Mark as internal.
15353 * syntax.c (Fsyntax_table_p): New forward static decl.
15354 (skip_chars): Remove duplicate decl.
15355 * textprop.c (Fprevious_property_change): New forward static decl.
15356 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
15357 Now internal.
15358 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
15359 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
15360
785bbd42
PE
15361 * editfns.c (Fformat): Remove unreachable code.
15362
8b913b57
AS
153632011-04-14 Andreas Schwab <schwab@linux-m68k.org>
15364
15365 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
15366 change. (Bug#8496)
15367
a6744a35
EZ
153682011-04-13 Eli Zaretskii <eliz@gnu.org>
15369
15370 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
15371 when at ZV. (Bug#8487)
15372
e7974947
AS
153732011-04-12 Andreas Schwab <schwab@linux-m68k.org>
15374
baad03f0
AS
15375 * charset.c (Fclear_charset_maps): Use xfree instead of free.
15376 (Bug#8437)
15377 * keyboard.c (parse_tool_bar_item): Likewise.
15378 * sound.c (sound_cleanup, alsa_close): Likewise.
15379 * termcap.c (tgetent): Likewise.
15380 * xfns.c (x_default_font_parameter): Likewise.
15381 * xsettings.c (read_and_apply_settings): Likewise.
15382
e7974947
AS
15383 * alloc.c (overrun_check_malloc, overrun_check_realloc)
15384 (overrun_check_free): Protoize.
15385
28272684
PE
153862011-04-12 Paul Eggert <eggert@cs.ucla.edu>
15387
15388 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
15389 since callers should never pass a negative size.
15390 Change the signature to match that of plain 'read' and 'write'; see
15391 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
15392 * lisp.h: Update prototypes of emacs_write and emacs_read.
15393
11997c76
EZ
153942011-04-11 Eli Zaretskii <eliz@gnu.org>
15395
15396 * xdisp.c (redisplay_window): Don't try to determine the character
15397 position of the scroll margin if the window start point w->startp
e896f03c 15398 is outside the buffer's accessible region. (Bug#8468)
11997c76 15399
8a2cbd72
EZ
154002011-04-10 Eli Zaretskii <eliz@gnu.org>
15401
15402 Fix write-region and its subroutines for buffers > 2GB.
15403 * fileio.c (a_write, e_write): Modify declaration of arguments and
15404 local variables to support buffers larger than 2GB.
15405 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
15406
15407 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
15408 argument, local variables, and return value.
15409
15410 * lisp.h: Update prototypes of emacs_write and emacs_read.
15411
15412 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
15413
4073e537 154142011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 15415
1ebfdcb6
PE
15416 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
15417
b2ded58d
PE
15418 Fix more problems found by GCC 4.6.0's static checks.
15419
7d66342c
PE
15420 * xdisp.c (vmessage): Use a better test for character truncation.
15421
bbf47d44
PE
15422 * charset.c (load_charset_map): <, not <=, for optimization,
15423 and to avoid potential problems with integer overflow.
9248994d 15424 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 15425 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 15426 * editfns.c (Fformat): Likewise.
1e69125e 15427 * syntax.c (skip_chars): Likewise.
3befa583 15428
e3019616
PE
15429 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
15430 This also lets GCC 4.6.0 generate slightly better loop code.
15431
becfa255
PE
15432 * callint.c (Fcall_interactively): <, not <=, for optimization.
15433 (Fcall_interactively): Count the number of arguments produced,
15434 not the number of arguments given. This is simpler and lets GCC
15435 4.6.0 generate slightly better code.
15436
dae0cd48
PE
15437 * ftfont.c: Distingish more carefully between FcChar8 and char.
15438 The previous code passed unsigned char * to a functions like
15439 strlen and xstrcasecmp that expect char *, which does not
15440 conform to the C standard.
15441 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
15442 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
15443 char * when the C standard requires it.
15444
76032d70
PE
15445 * keyboard.c (read_char): Remove unused var.
15446
eb3f1cc8
PE
15447 * eval.c: Port to Windows vsnprintf (Bug#8435).
15448 Include <limits.h>.
15449 (SIZE_MAX): Define if the headers do not.
15450 (verror): Do not give up if vsnprintf returns a negative count.
15451 Instead, grow the buffer. This ports to Windows vsnprintf, which
15452 does not conform to C99. Problem reported by Eli Zaretskii.
15453 Also, simplify the allocation scheme, by avoiding the need for
15454 calling realloc, and removing the ALLOCATED variable.
15455
70476b54
PE
15456 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
15457
12020a9e
PE
15458 Remove invocations of doprnt, as Emacs now uses vsnprintf.
15459 But keep the doprint source code for now, as we might revamp it
15460 and use it again (Bug#8435).
ea6c7ae6
PE
15461 * lisp.h (doprnt): Remove.
15462 * Makefile.in (base_obj): Remove doprnt.o.
15463 * deps.mk (doprnt.o): Remove.
15464
5fdb398c
PE
15465 error: Print 32- and 64-bit integers portably (Bug#8435).
15466 Without this change, on typical 64-bit hosts error ("...%d...", N)
15467 was used to print both 32- and 64-bit integers N, which relied on
15468 undefined behavior.
61bdb816 15469 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
15470 * lisp.h (error, verror): Mark as printf-like functions.
15471 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
15472 Report overflow in size calculations when allocating printf buffer.
15473 Do not truncate output string at its first null byte.
15474 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
15475 Truncate the output at a character boundary, since vsnprintf does not
15476 do that.
15477 * charset.c (check_iso_charset_parameter): Convert internal
15478 character to string before calling 'error', since %c now has the
15479 printf meaning.
15480 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
15481 overflow when computing char to be passed to 'error'. Do not
15482 pass Lisp_Object to 'error'; pass the integer instead.
15483 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
15484 formatted with plain %d.
15485
b189fa66
PE
15486 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
15487
bff87ef0
PE
15488 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
15489
7e2cac20
PE
15490 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
15491
ce4d90b5
PE
15492 * xterm.c (x_catch_errors): Remove duplicate declaration.
15493
266c9547
PE
15494 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
15495
79c49ad2
PE
15496 * xdisp.c, lisp.h (message_nolog): Remove; unused.
15497
368f4090
JM
154982011-04-10 Jim Meyering <meyering@redhat.com>
15499
15500 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
15501 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
15502 return ssize_t not "int", and use size_t as the buffer length.
15503 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
15504 * gnutls.h: Update declarations.
15505 * process.c (read_process_output): Use ssize_t, to match.
15506 (send_process): Likewise.
15507
a32d4040
CY
155082011-04-09 Chong Yidong <cyd@stupidchicken.com>
15509
15510 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
15511
8546720e 155122011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 15513
04f2d78b
CB
15514 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
15515 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 15516
8546720e
GM
15517 * xterm.c (handle_one_xevent):
15518 * xmenu.c (create_and_show_popup_menu):
15519 * xselect.c (x_decline_selection_request)
15520 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 15521
0a2f5c1a 155222011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
15523
15524 Fix some uses of `int' instead of EMACS_INT.
15525 * search.c (string_match_1, fast_string_match)
15526 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
15527 (scan_buffer, find_next_newline_no_quit)
15528 (find_before_next_newline, search_command, Freplace_match)
15529 (Fmatch_data): Make some `int' variables be EMACS_INT.
15530
15531 * xdisp.c (display_count_lines): 3rd argument and return value now
15532 EMACS_INT. All callers changed.
15533 (pint2hrstr): Last argument is now EMACS_INT.
15534
15535 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
15536 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
15537 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
15538 (decode_coding_utf_16, decode_coding_emacs_mule)
15539 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
15540 (decode_coding_ccl, decode_coding_charset)
15541 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
15542 (decode_coding_iso_2022, decode_coding_emacs_mule)
15543 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
15544 <char_offset, last_offset>: Declare EMACS_INT.
15545 (encode_coding_utf_8, encode_coding_utf_16)
15546 (encode_coding_emacs_mule, encode_invocation_designation)
15547 (encode_designation_at_bol, encode_coding_iso_2022)
15548 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
15549 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
15550 Declare EMACS_INT.
15551 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
15552 (encode_invocation_designation): Last argument P_NCHARS is now
15553 EMACS_INT.
15554 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
15555 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
15556
15557 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
15558 All users changed.
15559
15560 * ccl.c (Fccl_execute_on_string): Declare some variables
15561 EMACS_INT.
15562
8546720e 155632011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
15564
15565 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
15566
4e19a977
CS
155672011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
15568
15569 * process.c (Fformat_network_address): Doc fix.
15570
87302331
R
155712011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
15572
ee7683eb 15573 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 15574
cbb59342
CY
155752011-04-08 Chong Yidong <cyd@stupidchicken.com>
15576
15577 * keyboard.c (read_char): Call Lisp function help-form-show,
15578 instead of using internal_with_output_to_temp_buffer.
15579 (Qhelp_form_show): New var.
e0d38eeb 15580 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
15581
15582 * print.c (internal_with_output_to_temp_buffer): Function deleted.
15583
15584 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
15585
e67a13ab
CY
155862011-04-06 Chong Yidong <cyd@stupidchicken.com>
15587
04f2d78b
CB
15588 * process.c (Flist_processes): Remove to Lisp.
15589 (list_processes_1): Delete.
e67a13ab 15590
973f782d
EZ
155912011-04-06 Eli Zaretskii <eliz@gnu.org>
15592
7c106b1e
EZ
15593 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
15594
973f782d
EZ
15595 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
15596
41cf7d1a 155972011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 15598
ca23cc88
PE
15599 Fix more problems found by GCC 4.6.0's static checks.
15600
f390e2d5
PE
15601 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
15602
42eea0d0
PE
15603 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
15604
b69769da 15605 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 15606
f9541e84
PE
15607 * xdisp.c (vmessage): Mark as a printf-like function.
15608
13841b55
PE
15609 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
15610
c136c10f
PE
15611 * sound.c (sound_warning): Don't crash if arg contains a printf format.
15612
5e2d4a30
PE
15613 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
15614 printf-like functions.
15615 (tiff_load): Add casts to remove these marks before passing them
15616 to system-supplied API.
15617
583f48b9
PE
15618 * eval.c (Fsignal): Remove excess argument to 'fatal'.
15619
b25d760e
PE
15620 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
15621 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
15622 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
15623 directly, rather than having caller test rule sign. This avoids
15624 some unnecessary tests.
15625 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
15626 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
15627 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 15628
bc7b6697 15629 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 15630 (xfont_open): Avoid unnecessary tests.
bc7b6697 15631
27ccc379
PE
15632 * composite.c (composition_gstring_put_cache): Use unsigned integer.
15633
dcd5c89a
PE
15634 * composite.h, composite.c (composition_gstring_put_cache):
15635 Use EMACS_INT, not int, for length.
15636
b13a45c6
PE
15637 * composite.h (COMPOSITION_DECODE_REFS): New macro,
15638 breaking out part of COMPOSITION_DECODE_RULE.
15639 (COMPOSITION_DECODE_RULE): Use it.
15640 * composite.c (get_composition_id): Remove unused local vars,
15641 by using the new macro.
15642
1e792e4d
PE
15643 * textprop.c (set_text_properties_1): Change while to do-while,
15644 since the condition is always true at first.
15645
dc6c6455 15646 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
15647 (interval_deletion_adjustment): Return unsigned value.
15648 All uses changed.
dc6c6455 15649
aba7731a
PE
15650 * process.c (list_processes_1, create_pty, read_process_output):
15651 (exec_sentinel): Remove vars that were set but not used.
afd4052b 15652 (create_pty): Remove unnecessary "volatile"s.
bc57d757 15653 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 15654 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 15655 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 15656
fdfc4bf3
PE
15657 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
15658
fca8fe46 15659 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 15660 (update_syntax_table): Use unsigned instead of int.
fca8fe46 15661
06a0259a 15662 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 15663 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 15664 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 15665
e7b9e80f
PE
15666 * print.c (print_error_message): Avoid int overflow.
15667
56201685
PE
15668 * font.c (font_list_entities): Redo for clarity,
15669 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
15670
78834453 15671 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 15672 (font_score): Avoid potential overflow in diff calculation.
78834453 15673
0bc0b309 15674 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 15675 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 15676
e610eaca
PE
15677 * eval.c (funcall_lambda): Rename local to avoid shadowing.
15678
b895abce
PE
15679 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
15680 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
15681 can always succeed if overflow has undefined behavior.
15682
1f1d9321 15683 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 15684 (wordify): Omit three unnecessary tests.
1f1d9321 15685
c59478bc
PE
15686 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
15687 All callers changed. This avoids the need for an unused var.
15688
79b73827
PE
15689 * casefiddle.c (casify_region): Remove var that is set but not used.
15690
a4db5dfe
PE
15691 * dired.c (file_name_completion): Remove var that is set but not used.
15692
43aae36e
PE
15693 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
15694
2a47c44d 15695 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 15696 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 15697
a37c69bf
PE
15698 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
15699 Check for integer overflow on size calculations.
15700
328ab8e7
PE
15701 * buffer.c (Fprevious_overlay_change): Remove var that is set
15702 but not used.
15703
e5a2a5cb
PE
15704 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
15705 Remove vars that are set but not used.
8d84a6eb 15706 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 15707 (timer_check_2): Mark vars as initialized.
e5a2a5cb 15708
a60e5f68
PE
15709 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
15710
f661cb61 15711 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 15712 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 15713
f0397f5a
PE
15714 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
15715 that are set but not used.
15716
8664db06 15717 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 15718 if XCreateBitmapFromData fails (Bug#8410).
8664db06 15719
6abdaa4a
PE
15720 * xselect.c (x_get_local_selection, x_handle_property_notify):
15721 Remove vars that are set but not used.
15722
0ce7538d 15723 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 15724 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 15725
9ae848fc
PE
15726 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
15727 Remove var that is set but not used.
0b918413
PE
15728 (scroll_bar_windows_size): Now size_t, not int.
15729 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
15730 Check for overflow.
9ae848fc 15731
a5a62657
PE
15732 * xfaces.c (realize_named_face): Remove vars that are set but not used.
15733 (map_tty_color) [!defined MSDOS]: Likewise.
15734
5c5cdd39
PE
15735 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
15736
66ebf983
PE
15737 * coding.c: Remove vars that are set but not used.
15738 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
15739 All callers changed.
15740 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
15741 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
15742 (decode_coding_charset): Remove vars that are set but not used.
15743
1be4d761
PE
15744 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
15745 that is set but not used.
15746
47553fa8
PE
15747 * print.c (print_object): Remove var that is set but not used.
15748
1f7196bf 15749 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
15750 The gnulib version avoids calling malloc in the usual case,
15751 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
15752 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
15753 * filelock.c (current_lock_owner): Likewise.
15754 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
15755 * sysdep.c: Include allocator.h, careadlinkat.h.
15756 (emacs_no_realloc_allocator): New static constant.
15757 (emacs_readlink): New function.
fdb61804
PE
15758 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
15759 ../lib/careadlinkat.h.
d1fdcab7 15760
f84c17c7
SM
157612011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
15762
15763 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
15764 first non-nil return value).
15765
ef3862ad
JD
157662011-04-03 Jan Djärv <jan.h.d@swipnet.se>
15767
15768 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
15769 if not defined (Bug#8403).
15770
376a7006
JB
157712011-04-02 Juanma Barranquero <lekktu@gmail.com>
15772
15773 * xdisp.c (display_count_lines): Remove parameter `start',
15774 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15775 (get_char_face_and_encoding): Remove parameter `multibyte_p',
15776 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15777 (fill_stretch_glyph_string): Remove parameters `row' and `area',
15778 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
15779 and thereabouts. All callers changed.
15780 (get_per_char_metric): Remove parameter `f', unused since
15781 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15782
6ca3801d
JM
157832011-04-02 Jim Meyering <meyering@redhat.com>
15784
15785 do not dereference NULL upon failed strdup
15786 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
15787 (ns_get_family): Likewise.
15788
d8e2b5ba
JB
157892011-04-02 Juanma Barranquero <lekktu@gmail.com>
15790
15791 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
15792
8c74fcbd
JD
157932011-04-02 Jan Djärv <jan.h.d@swipnet.se>
15794
15795 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
15796 later (Bug#8403).
15797
7200d79c
SM
157982011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
15799
03408648 15800 Add lexical binding.
7200d79c 15801
03408648
SM
15802 * window.c (Ftemp_output_buffer_show): New fun.
15803 (Fsave_window_excursion):
15804 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
15805
15806 * lread.c (lisp_file_lexically_bound_p): New function.
15807 (Fload): Bind Qlexical_binding.
15808 (readevalloop): Remove `evalfun' arg.
15809 Bind Qinternal_interpreter_environment.
15810 (Feval_buffer): Bind Qlexical_binding.
15811 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
15812 Mark as dynamic.
15813 (syms_of_lread): Declare `lexical-binding'.
15814
15815 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
15816
15817 * keyboard.c (eval_dyn): New fun.
15818 (menu_item_eval_property): Use it.
ca105506
SM
15819
15820 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 15821
03408648
SM
15822 * fns.c (concat, mapcar1): Accept byte-code-functions.
15823
15824 * eval.c (Fsetq): Handle lexical vars.
15825 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
15826 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
15827 (FletX, Flet): Obey lexical binding.
15828 (Fcommandp): Handle closures.
15829 (Feval): New `lexical' arg.
15830 (eval_sub): New function extracted from Feval. Use it almost
15831 everywhere where Feval was used. Look up vars in lexical env.
15832 Handle closures.
15833 (Ffunctionp): Move from subr.el.
15834 (Ffuncall): Handle closures.
15835 (apply_lambda): Remove `eval_flags'.
15836 (funcall_lambda): Handle closures and new byte-code-functions.
15837 (Fspecial_variable_p): New function.
15838 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
15839 but without exporting it to Lisp.
23aba0ea 15840
23aba0ea 15841 * doc.c (Fdocumentation, store_function_docstring):
03408648 15842 * data.c (Finteractive_form): Handle closures.
23aba0ea 15843
03408648
SM
15844 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
15845 interactive spec.
ba83908c 15846
04f2d78b
CB
15847 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
15848 New byte-codes.
03408648
SM
15849 (exec_byte_code): New function extracted from Fbyte_code to handle new
15850 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 15851
03408648 15852 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 15853
03408648 15854 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 15855
e2abce01
JB
158562011-03-31 Juanma Barranquero <lekktu@gmail.com>
15857
15858 * xdisp.c (redisplay_internal): Fix prototype.
15859
63696a73 158602011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 15861
63696a73 15862 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
15863 (try_scrolling): Use it when setting scroll_limit.
15864 Limit scrolling to 100 screen lines.
63696a73
EZ
15865 (redisplay_window): Even when falling back on "recentering",
15866 position point in the window according to scroll-conservatively,
15867 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
15868
15869 (try_scrolling): When point is above the window, allow searching
15870 as far as scroll_max, or one screenful, to compute vertical
15871 distance from PT to the scroll margin position. This prevents
15872 try_scrolling from unnecessarily failing when
15873 scroll-conservatively is set to a value slightly larger than the
15874 window height. Clean up the case of PT below the margin at bottom
15875 of window: scroll_max can no longer be INT_MAX. When aggressive
15876 scrolling is in use, don't let point enter the opposite scroll
15877 margin as result of the scroll.
15878 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
15879 threshold of 100 lines for never-recentering scrolling.
15880
e4cc2dfc
JB
158812011-03-31 Juanma Barranquero <lekktu@gmail.com>
15882
15883 * dispextern.h (move_it_by_lines):
15884 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
15885 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
15886 (message_log_check_duplicate): Remove parameters `prev_bol' and
15887 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15888 (redisplay_internal): Remove parameter `preserve_echo_area',
15889 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
15890
15891 * indent.c (Fvertical_motion):
15892 * window.c (window_scroll_pixel_based, Frecenter):
15893 Don't pass `need_y_p' to `move_it_by_lines'.
15894
1c470562
SM
158952011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
15896
44f230aa
SM
15897 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
15898 steal a few bits to be more compact.
15899 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
15900 Remove unneeded casts.
15901
1c470562
SM
15902 * bytecode.c (Fbyte_code): CAR and CDR can GC.
15903
888adce9
ZK
159042011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
15905
15906 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
15907 binding" message (bug#7967).
15908
f838ed7b
PE
159092011-03-30 Paul Eggert <eggert@cs.ucla.edu>
15910
77861b95
PE
15911 Fix more problems found by GCC 4.6.0's static checks.
15912
de6dbc14
PE
15913 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
15914 Remove unused local var.
15915
f838ed7b
PE
15916 * editfns.c (Fmessage_box): Remove unused local var.
15917
792c7b2b
PE
15918 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
15919 (note_mode_line_or_margin_highlight, note_mouse_highlight):
15920 Omit unused local vars.
c499e557 15921 * window.c (shrink_windows): Omit unused local var.
b01a1c29 15922 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
15923 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
15924 Omit unused local var.
15925
ba0165e1
PE
15926 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
15927 Don't assume string length fits in int.
32ad8845 15928 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 15929 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 15930
3c59b4c9
PE
15931 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
15932 instead of alloca (Bug#8344).
15933
a3eed478 15934 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 15935 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 15936
eb4d412d
PE
15937 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
15938
1658b401
PE
15939 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
15940 concerns.
15941
15942 * term.c (produce_glyphless_glyph): Remove unnecessary test.
15943
15944 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 15945
9a2c6e05
PE
15946 * keyboard.c (syms_of_keyboard): Use the same style as later
15947 in this function when indexing through an array. This also
15948 works around GCC bug 48267.
15949
03d0a109
PE
15950 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
15951
44f730c8
PE
15952 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
15953
fe75f926
PE
15954 * chartab.c (sub_char_table_ref_and_range): Redo for slight
15955 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
15956
ffa8c828
PE
15957 * keyboard.c, keyboard.h (num_input_events): Now size_t.
15958 This avoids undefined behavior on integer overflow, and is a bit
15959 more convenient anyway since it is compared to a size_t variable.
15960
c5101a77
PE
15961 Variadic C functions now count arguments with size_t, not int.
15962 This avoids an unnecessary limitation on 64-bit machines, which
15963 caused (substring ...) to crash on large vectors (Bug#8344).
15964 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
15965 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 15966 All variadic functions and their callers changed accordingly.
c5101a77
PE
15967 (struct gcpro.nvars): Now size_t, not int. All uses changed.
15968 * data.c (arith_driver, float_arith_driver): Likewise.
15969 * editfns.c (general_insert_function): Likewise.
15970 * eval.c (struct backtrace.nargs, interactive_p)
15971 (internal_condition_case_n, run_hook_with_args, apply_lambda)
15972 (funcall_lambda, mark_backtrace): Likewise.
15973 * fns.c (concat): Likewise.
15974 * frame.c (x_set_frame_parameters): Likewise.
15975 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
15976 0 if not found, not -1. All callers changed.
15977
dd3f25f7
PE
15978 * alloc.c (garbage_collect): Don't assume stack size fits in int.
15979 (stack_copy_size): Now size_t, not int.
15980 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
15981
461c2ab9
JB
159822011-03-28 Juanma Barranquero <lekktu@gmail.com>
15983
15984 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
15985 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15986 All callers changed.
15987
15988 * lisp.h (multibyte_char_to_unibyte):
15989 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
15990 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15991 * character.h (CHAR_TO_BYTE8):
15992 * cmds.c (internal_self_insert):
15993 * editfns.c (general_insert_function):
15994 * keymap.c (push_key_description):
15995 * search.c (Freplace_match):
15996 * xdisp.c (message_dolog, set_message_1): All callers changed.
15997
f6d62986
SM
159982011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
15999
16000 * keyboard.c (safe_run_hook_funcall): New function.
16001 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
16002 don't set the hook to nil, but remove the offending function instead.
16003 (Qcommand_hook_internal): Remove, unused.
16004 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
16005 Vcommand_hook_internal.
16006
16007 * eval.c (enum run_hooks_condition): Remove.
16008 (funcall_nil, funcall_not): New functions.
16009 (run_hook_with_args): Call each function through a `funcall' argument.
16010 Remove `cond' argument, now redundant.
16011 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
16012 (Frun_hook_with_args_until_failure): Adjust accordingly.
16013 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
16014
1db5b1ad
JB
160152011-03-28 Juanma Barranquero <lekktu@gmail.com>
16016
16017 * dispextern.h (string_buffer_position): Remove declaration.
16018
16019 * print.c (strout): Remove parameter `multibyte', unused since
16020 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
16021
16022 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
16023 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
16024 All callers changed.
16025
16026 * w32.c (_wsa_errlist): Use braces for struct initializers.
16027
16028 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
16029 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
16030 All callers changed.
16031 (string_buffer_position): Likewise. Also, make static (it's never
16032 used outside xdisp.c).
16033 (cursor_row_p): Remove parameter `w', unused since
16034 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
16035 (decode_mode_spec): Remove parameter `precision', introduced during
16036 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
16037 All callers changed.
16038
5ffb62aa
JD
160392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16040
16041 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
16042
461c2ab9 160432011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
16044
16045 * nsterm.m (ns_menu_bar_is_hidden): New variable.
16046 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
16047 (ns_update_auto_hide_menu_bar): New functions.
16048 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
16049 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
16050 ns_constrain_all_frames.
16051 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
16052 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
16053
5c380ffb
JD
160542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16055
16056 * nsmenu.m (runDialogAt): Remove argument to timer_check.
16057
9af30bdf
GM
160582011-03-27 Glenn Morris <rgm@gnu.org>
16059
16060 * syssignal.h: Replace RETSIGTYPE with void.
16061 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
16062 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
16063 Replace SIGTYPE with void everywhere.
16064 * s/usg5-4-common.h (SIGTYPE): Remove definition.
16065 * s/template.h (SIGTYPE): Remove commented out definition.
16066
e2abce01
JB
160672011-03-26 Eli Zaretskii <eliz@gnu.org>
16068
16069 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
16070 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
16071
f868cd8a
JB
160722011-03-26 Juanma Barranquero <lekktu@gmail.com>
16073
59eb0929
JB
16074 * w32.c (read_unc_volume): Use parameter `henum', instead of
16075 global variable `wget_enum_handle'.
16076
16077 * keymap.c (describe_vector): Remove parameters `indices' and
16078 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
16079 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
16080
f868cd8a
JB
16081 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
16082
16083 * keyboard.c (timer_check): Remove parameter `do_it_now',
16084 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
16085 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
16086 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
16087
16088 * keyboard.c (read_char):
16089 * w32menu.c (w32_menu_display_help):
16090 * xmenu.c (show_help_event, menu_help_callback):
16091 Adjust calls to `show_help_echo'.
16092
16093 * gtkutil.c (xg_maybe_add_timer):
16094 * keyboard.c (readable_events):
16095 * process.c (wait_reading_process_output):
16096 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
16097
16098 * insdel.c (adjust_markers_gap_motion):
16099 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
16100 (gap_left, gap_right): Don't call it.
16101
2ecf6fdb
CY
161022011-03-25 Chong Yidong <cyd@stupidchicken.com>
16103
16104 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
16105 incurred during fontification.
16106
6b1f9ba4
JB
161072011-03-25 Juanma Barranquero <lekktu@gmail.com>
16108
16109 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
16110 (DEFVAR_PER_BUFFER): Don't pass it.
16111
16112 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
16113 (scrolling_window): Don't pass it.
16114
0f4a96b5
JB
161152011-03-25 Juanma Barranquero <lekktu@gmail.com>
16116
16117 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
16118
16119 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
16120 and `suffix'.
16121 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
16122 of variables specific to SELinux and computation of `encoded_absname'.
16123
16124 * image.c (XPutPixel): Remove unused variable `height'.
16125
16126 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
16127
16128 * unexw32.c (get_section_info): Remove unused variable `section'.
16129
16130 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
16131 (system_process_attributes): Remove unused variable `sess'.
16132 (sys_read): Remove unused variable `err'.
16133
16134 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
16135 (w32_wnd_proc): Remove unused variable `isdead'.
16136 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
16137 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
16138 (x_create_tip_frame): Remove unused variable `tem'.
16139
16140 * w32inevt.c (w32_console_read_socket):
16141 Remove unused variable `no_events'.
16142
16143 * w32term.c (x_draw_composite_glyph_string_foreground):
16144 Remove unused variable `width'.
16145
1149507c
JB
161462011-03-24 Juanma Barranquero <lekktu@gmail.com>
16147
16148 * w32term.c (x_set_glyph_string_clipping):
16149 Don't pass uninitialized region to CombineRgn.
16150
9c88f339
JB
161512011-03-23 Juanma Barranquero <lekktu@gmail.com>
16152
16153 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
16154 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
16155 (Fx_close_connection): Remove unused variable `i'.
16156
16157 * w32font.c (w32font_draw): Return number of glyphs.
16158 (w32font_open_internal): Remove unused variable `i'.
16159 (w32font_driver): Add missing initializer.
16160
16161 * w32menu.c (utf8to16): Remove unused variable `utf16'.
16162 (fill_in_menu): Remove unused variable `items_added'.
16163
16164 * w32term.c (last_mouse_press_frame): Remove static global variable.
16165 (w32_clip_to_row): Remove unused variable `f'.
16166 (x_delete_terminal): Remove unused variable `i'.
16167
16168 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
16169 (NOTHING): Remove unused static global variable.
16170 (uniscribe_check_otf): Remove unused variable `table'.
16171 (uniscribe_font_driver): Add missing initializers.
16172
dee091a3
JD
161732011-03-23 Julien Danjou <julien@danjou.info>
16174
16175 * term.c (Fsuspend_tty, Fresume_tty):
16176 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
16177 * window.c (temp_output_buffer_show):
16178 * insdel.c (signal_before_change):
16179 * frame.c (Fhandle_switch_frame):
16180 * fileio.c (Fdo_auto_save):
16181 * emacs.c (Fkill_emacs):
16182 * editfns.c (save_excursion_restore):
16183 * cmds.c (internal_self_insert):
16184 * callint.c (Fcall_interactively):
16185 * buffer.c (Fkill_all_local_variables):
16186 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
16187 Use Frun_hooks.
0f4a96b5 16188 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 16189 unconditionally since it does the check itself.
dee091a3 16190
2c520ab5 161912011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 16192
c9c49752
PE
16193 Fix more problems found by GCC 4.5.2's static checks.
16194
8abc3f12
PE
16195 * coding.c (encode_coding_raw_text): Avoid unnecessary test
16196 the first time through the loop, since we know p0 < p1 then.
16197 This also avoids a gcc -Wstrict-overflow warning.
16198
a2d26660
PE
16199 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
16200 leading to a memory leak, possible in functions like
16201 load_charset_map_from_file that can allocate an unbounded number
b12ef411 16202 of objects (Bug#8318).
a2d26660 16203
916c72e9
PE
16204 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
16205 that could (at least in theory) be that large.
16206
19ab8a18
PE
16207 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
16208 This is less likely to overflow, and avoids undefined behavior if
16209 overflow does occur. All callers changed. Use strtoul to scan
16210 for the unsigned long integer.
b7cbbd6f
PE
16211 (pint2hrstr): Simplify and tune code slightly.
16212 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 16213
f0641eff
PE
16214 * scroll.c (do_scrolling): Work around GCC bug 48228.
16215 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
16216
7f650bb9
PE
16217 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
16218 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
16219 (validate_x_resource_name): Simplify count usage.
16220 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 16221
37dd57d1
PE
16222 * fileio.c (Fcopy_file): Report error if fchown or fchmod
16223 fail (Bug#8306).
81e56e61 16224
699979fc 16225 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 16226
401bf9b4
PE
16227 * process.c (Fmake_network_process): Use socklen_t, not int,
16228 where POSIX says socklen_t is required in portable programs.
16229 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 16230 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
16231 (Fmake_network_process, server_accept_connection):
16232 (wait_reading_process_output, read_process_output):
16233 Likewise.
16234
b93aacde
PE
16235 * process.c: Rename or move locals to avoid shadowing.
16236 (list_processes_1, Fmake_network_process):
16237 (read_process_output_error_handler, exec_sentinel_error_handler):
16238 Rename or move locals.
4dc343ee 16239 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 16240 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 16241 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 16242 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 16243 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 16244
af8a867c 16245 Make tparam.h and terminfo.c consistent.
44f230aa
SM
16246 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
16247 Include tparam.h instead, since it declares them.
af8a867c
PE
16248 * cm.h (PC): Remove extern decl; tparam.h now does this.
16249 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
16250 * terminfo.c: Include tparam.h, to check interfaces.
16251 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
16252 (tparam): Adjust signature to match interface in tparam.h;
16253 this removes some undefined behavior. Check that outstring and len
16254 are zero, which they always are with Emacs.
16255 * tparam.h (PC, BC, UP): New extern decls.
16256
0248044d 16257 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 16258 (xftfont_open): Rename locals to avoid shadowing.
0248044d 16259
8ff096c1 16260 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
16261 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
16262 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 16263 (ftfont_list): Remove unused local.
49eaafba
PE
16264 (get_adstyle_property, ftfont_pattern_entity):
16265 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
16266 Rename locals to avoid shadowing.
8ff096c1 16267
e2be39f6
PE
16268 * xfont.c (xfont_list_family): Mark var as initialized.
16269
c9735e30
PE
16270 * xml.c (make_dom): Now static.
16271
8f5201ae
PE
16272 * composite.c (composition_compute_stop_pos): Rename local to
16273 avoid shadowing.
b246f932
PE
16274 (composition_reseat_it): Remove unused locals.
16275 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 16276 (composition_update_it): Mark var as initialized.
11b61122
PE
16277 (find_automatic_composition): Mark vars as initialized,
16278 with a FIXME (Bug#8290).
8f5201ae 16279
760fbc2c
PE
16280 character.h: Rename locals to avoid shadowing.
16281 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
16282 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
16283 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
16284 (BUF_DEC_POS): Be more systematic about renaming local temporaries
16285 to avoid shadowing.
16286
ff08eb85
PE
16287 * textprop.c (property_change_between_p): Remove; unused.
16288
fc7bf025
PE
16289 * intervals.c (interval_start_pos): Now static.
16290
235d7abc
PE
16291 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
16292
44f230aa
SM
16293 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
16294 Rename locals to avoid shadowing.
3e7d6594 16295
50060332
PE
16296 * sound.c (wav_play, au_play, Fplay_sound_internal):
16297 Fix pointer signedness.
d01f234b 16298 (alsa_choose_format): Remove unused local var.
c83b8872
PE
16299 (wav_play): Initialize a variable to 0, to prevent undefined
16300 behavior (Bug#8278).
50060332 16301
c4fc4e30
PE
16302 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
16303
918436ed
PE
16304 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
16305
c939f91b
PE
16306 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
16307 clobbering (Bug#8298).
b9c7f648
PE
16308 * sysdep.c (sys_subshell): Likewise.
16309 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 16310
6bd8c144
PE
16311 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
16312 This should get cleaned up, so that child_setup has the
16313 same signature on all platforms.
16314
7710357c 16315 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 16316 (relocate_fd): Rename locals to avoid shadowing.
7710357c 16317
c59da222
CY
163182011-03-22 Chong Yidong <cyd@stupidchicken.com>
16319
16320 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
16321 not to be necessary, and produces flickering.
16322
66b87493
GM
163232011-03-20 Glenn Morris <rgm@gnu.org>
16324
16325 * config.in: Remove file.
16326
45b6f6d5
JB
163272011-03-20 Juanma Barranquero <lekktu@gmail.com>
16328
16329 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
16330 are now in src/globals.h.
16331 (syms_of_minibuf): Remove spurious & from previous change.
16332
cd394be1 163332011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
16334
16335 * minibuf.c (completing-read-function): New variable.
16336 (completing-read-default): Rename from completing-read.
16337 (completing-read): Call completing-read-function.
16338
b14e3e21
CY
163392011-03-19 Juanma Barranquero <lekktu@gmail.com>
16340
16341 * xfaces.c (Fx_load_color_file):
16342 Read color file from absolute filename (bug#8250).
16343
f2b726e6
JB
163442011-03-19 Juanma Barranquero <lekktu@gmail.com>
16345
16346 * makefile.w32-in: Update dependencies.
16347
09f6ff02
EZ
163482011-03-17 Eli Zaretskii <eliz@gnu.org>
16349
16350 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
16351
29a6015a
PE
163522011-03-17 Paul Eggert <eggert@cs.ucla.edu>
16353
a3a6c54e
PE
16354 Fix more problems found by GCC 4.5.2's static checks.
16355
b766f867
PE
16356 * process.c (make_serial_process_unwind, send_process_trap):
16357 (sigchld_handler): Now static.
16358
be02381c
PE
16359 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
16360 That way, the code declares only the vars that it needs.
16361 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
16362 * s/cygwin.h (PTY_ITERATION): Likewise.
16363 * s/darwin.h (PTY_ITERATION): Likewise.
16364 * s/gnu-linux.h (PTY_ITERATION): Likewise.
16365
57048744
PE
16366 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
16367 * process.c (allocate_pty): Don't declare stb unless it's needed.
16368
7914961c 16369 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
16370 (CONSTANTLIM): Remove; unused.
16371 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
16372 Define only if needed.
7914961c 16373
b3967b18
PE
16374 * unexelf.c (unexec): Name an expression,
16375 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
16376 Use a different way to cause a compilation error if anyone uses
16377 n rather than nn, a way that does not involve shadowing.
73366a00 16378 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 16379
29a6015a
PE
16380 * deps.mk (unexalpha.o): Remove; unused.
16381
43cfc33e 16382 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 16383 * unexec.h: New file.
ce701a33
PE
16384 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
16385 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
16386 Depend on unexec.h.
16387 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
16388 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
16389 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 16390 Change as necessary to match prototype in unexec.h.
ce701a33 16391
01f44d5a
PE
16392 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
16393 shadowing.
4f63c6bb 16394 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 16395
a6670b0b
PE
16396 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
16397 Rename locals to avoid shadowing.
16398
cef2010d 16399 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 16400 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 16401
d4d7173a
PE
16402 * print.c (Fredirect_debugging_output): Fix pointer signedess.
16403
f08b802a
PE
16404 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
16405 warning when compiling print.c.
16406
3ddb0639
PE
16407 * font.c (font_unparse_fcname): Abort in an "impossible" situation
16408 instead of using an uninitialized var.
5ad03b97 16409 (font_sort_entities): Mark var as initialized.
3ddb0639 16410
170a2692
PE
16411 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
16412
e663c700
PE
16413 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
16414 pointers to constants.
89bc529a 16415 (font_parse_fcname): Remove unused vars.
7b81e2d0 16416 (font_delete_unmatched): Now static.
ea838e10 16417 (font_get_spec): Remove; unused.
13a547c6
PE
16418 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
16419 (font_update_drivers, Ffont_get_glyphs, font_add_log):
16420 Rename or move locals to avoid shadowing.
e663c700 16421
2a80c887 16422 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 16423 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 16424
1384fa33 16425 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 16426 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 16427
8b2c52e9
PE
16428 * alloc.c (mark_backtrace): Move decl from here ...
16429 * lisp.h: ... to here, so that it can be checked.
16430
475545b5 16431 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 16432 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
16433 (lisp_indirect_variable): Name an expression,
16434 to avoid gcc -Wbad-function-cast warning.
1faed8ae 16435 (Fdefvar): Rename locals to avoid shadowing.
475545b5 16436
b1349114 16437 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 16438 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 16439 Use const pointer when appropriate.
b1349114 16440
a2928364
PE
16441 * lisp.h (get_system_name, get_operating_system_release):
16442 Move decls here, to check interfaces.
16443 * process.c (get_operating_system_release): Move decl to lisp.h.
16444 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
16445 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
16446 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
16447 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
16448 (Fformat_time_string, Fencode_time, Finsert_char):
16449 (Ftranslate_region_internal, Fformat):
16450 Rename or remove local vars to avoid shadowing.
9710023e 16451 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 16452
a415e694
PE
16453 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
16454 avoid shadowing.
16455
8ef4622d
PE
16456 * lisp.h (eassert): Check that the argument compiles, even if
16457 ENABLE_CHECKING is not defined.
16458
946f9a5b
PE
16459 * data.c (Findirect_variable): Name an expression, to avoid
16460 gcc -Wbad-function-cast warning.
112396d6 16461 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 16462 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
16463 (Fmake_variable_buffer_local, Fmake_local_variable):
16464 Mark variables as initialized.
52746918 16465 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 16466
e5aab7e7 16467 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
16468 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
16469 Rename locals to avoid shadowing.
dff45157
PE
16470 (mark_stack): Move local variables into the #ifdef region where
16471 they're used.
7bc26fdb
PE
16472 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
16473 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
16474 needed otherwise.
16475 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
16476 (GC_STRING_CHARS): Remove; not used.
d40d4be1 16477 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 16478
e5aab7e7
PE
16479 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
16480 avoids undefined behavior in theory.
16481
4da60324
PE
16482 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
16483
88043301
PE
16484 Use functions, not macros, for up- and down-casing (Bug#8254).
16485 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16486 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
16487 to use the following functions instead of these macros.
16488 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
16489 EMACS_INT, since callers assume the returned value fits in int.
16490 (upcase1): Likewise, for UPCASE_TABLE.
16491 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 16492 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 16493 the race-condition problem in the old DOWNCASE.
88043301 16494
19ed5445
PE
16495 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
16496 Rename locals to avoid shadowing.
16497 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
16498 (regex_compile, re_search_2, re_match_2_internal):
16499 Remove unused local vars.
952db0d7
PE
16500 (FREE_VAR): Rewrite so as not to use empty "else",
16501 which gcc can warn about.
da053e48 16502 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
16503 (RETALLOC_IF): Define only if needed.
16504 (WORDCHAR_P): Likewise. This one is never needed, but is used
16505 only in a comment talking about a compiler bug, so put inside
16506 the #if 0 of that comment.
16507 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
16508 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
16509 Remove; unused.
19ed5445 16510
1f3561e4 16511 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
16512 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
16513 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 16514
ded6f8f7
PE
16515 * search.c (simple_search): Remove unused var.
16516
dbd37a95
PE
16517 * dired.c (compile_pattern): Move decl from here ...
16518 * lisp.h: ... to here, so that it can be checked.
16519 (struct re_registers): New forward decl.
16520
7e47afad
PE
16521 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
16522
85f24f61
PE
16523 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
16524 All uses changed.
16525 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
16526 Rename locals to avoid shadowing.
5671df8f 16527 (Fvertical_motion): Mark locals as initialized.
85f24f61 16528
181aa2be 16529 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 16530 (casify_region): Mark local as initialized.
181aa2be 16531
930d429c
PE
16532 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
16533
7082eac6
PE
16534 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
16535 New macros, so that the caller can use some names other than
16536 gcpro1, gcpro2, etc.
16537 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
16538 of the new macros.
16539 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
16540 argument, for consistency with GCPRO2_VAR, etc: it is now the
16541 prefix of the variable, not the variable itself. All uses
16542 changed.
38b2c076
PE
16543 * dired.c (directory_files_internal, file_name_completion):
16544 Rename locals to avoid shadowing.
16545
15206ed9
PE
16546 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
16547 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
16548 dired.c's scmp function, had undefined behavior.
16549 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16550 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
16551 * buffer.h: ... to here, because these macros use current_buffer,
16552 and the new implementation with inline functions needs to have
16553 current_buffer in scope now, rather than later when the macros
16554 are used.
16555 (downcase, upcase1): New static inline functions.
16556 (DOWNCASE, UPCASE1): Reimplement using these functions.
16557 This avoids undefined behavior in expressions like
16558 DOWNCASE (x) == DOWNCASE (y), which previously suffered
16559 from race conditions in accessing the global variables
16560 case_temp1 and case_temp2.
16561 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
16562 * lisp.h (case_temp1, case_temp2): Remove their decls.
16563 * character.h (ASCII_CHAR_P): Move from here ...
16564 * lisp.h: ... to here, so that the inline functions mentioned
16565 above can use them.
16566
4a6bea26
PE
16567 * dired.c (directory_files_internal_unwind): Now static.
16568
f14b7e14
PE
16569 * fileio.c (file_name_as_directory, directory_file_name):
16570 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
16571 Now static.
2893f146
PE
16572 (file_name_as_directory): Use const pointers when appropriate.
16573 (Fexpand_file_name): Likewise. In particular, newdir might
16574 point at constant storage, so make it a const pointer.
fd4ead52 16575 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
16576 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
16577 signedness issues.
f839df0c
PE
16578 (Fset_file_times, Finsert_file_contents, auto_save_error):
16579 Rename locals to avoid shadowing.
f14b7e14 16580
5716756e 16581 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
16582 (Ftry_completion, Fall_completions): Rename or remove locals
16583 to avoid shadowing.
5716756e 16584
b4c3046a
PE
16585 * marker.c (bytepos_to_charpos): Remove; unused.
16586
b45db522
PE
16587 * lisp.h (verify_bytepos, count_markers): New decls,
16588 so that gcc does not warn that these functions aren't declared.
16589
85876d07
PE
16590 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
16591 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 16592 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 16593 (copy_text): Remove unused local var.
85876d07 16594
03d78a21 16595 * filelock.c (within_one_second): Now static.
b3dd38ab 16596 (lock_file_1): Rename local to avoid shadowing.
03d78a21 16597
5df8f01b
PE
16598 * buffer.c (fix_overlays_before): Mark locals as initialized.
16599 (fix_start_end_in_overlays): Likewise. This function should be
16600 simplified by using pointers-to-pointers, but that's a different
16601 matter.
b1d876f1 16602 (switch_to_buffer_1): Now static.
8f54f30a
PE
16603 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
16604 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 16605
a70072c9 16606 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 16607 Fix pointer signedness issue.
edced198
PE
16608 (sys_subshell): Mark local as volatile if checking for lint,
16609 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 16610 (MAXPATHLEN): Define only if needed.
a70072c9 16611
a0977c44
PE
16612 * process.c (serial_open, serial_configure): Move decls from here ...
16613 * systty.h: ... to here, so that they can be checked.
16614
a884fdcc
PE
16615 * fns.c (get_random, seed_random): Move extern decls from here ...
16616 * lisp.h: ... to here, so that they can be checked.
16617
604efe86 16618 * sysdep.c (reset_io): Now static.
b8950c94 16619 (wait_for_termination_signal): Remove; unused.
604efe86 16620
38fc62d9
PE
16621 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
16622 (copy_keymap_item, append_key, push_text_char_description):
16623 Now static.
1004a21a 16624 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 16625 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
16626 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
16627 (describe_map_tree):
16628 Rename locals to avoid shadowing.
38fc62d9 16629
2f2650da
PE
16630 * keyboard.c: Declare functions static if they are not used elsewhere.
16631 (echo_char, echo_dash, cmd_error, top_level_2):
16632 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
16633 (read_char, kbd_buffer_get_event, make_lispy_position):
16634 (make_lispy_event, make_lispy_movement, apply_modifiers):
16635 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
16636 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
16637 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 16638 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 16639 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 16640
a053e86c 16641 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
16642 (mark_kboards): Move decl here ...
16643 * alloc.c (mark_kboards): ... from here.
a053e86c 16644
4752793e
PE
16645 * lisp.h (force_auto_save_soon): New decl.
16646
74f10ca7 16647 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
16648 (DEFINE_DUMMY_FUNCTION): New macro.
16649 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
16650 Use it.
c03cd23f
PE
16651 (main): Add casts to avoid warnings
16652 if GCC considers string literals to be constants.
74f10ca7 16653
022e70d4
PE
16654 * lisp.h (fatal_error_signal): Add decl, since it's exported.
16655
59d6fe83
PE
16656 * dbusbind.c: Pointer signedness fixes.
16657 (xd_signature, xd_append_arg, xd_initialize):
16658 (Fdbus_call_method, Fdbus_call_method_asynchronously):
16659 (Fdbus_method_return_internal, Fdbus_method_error_internal):
16660 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
16661 (Fdbus_register_signal): Use SSDATA when the context wants char *.
16662
78320123
PE
16663 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
16664 if GCC considers string literals to be constants.
49cebcca 16665 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 16666
35ac2a97
SM
166672011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
16668
fb103ca9
SM
16669 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
16670 (print_preprocess, print_object): New macro to fix last change.
16671
35ac2a97
SM
16672 * print.c (print_preprocess): Don't forget font objects.
16673
62973b41
JB
166742011-03-16 Juanma Barranquero <lekktu@gmail.com>
16675
16676 * emacs.c (USAGE3): Doc fixes.
16677
0e48bb22
AS
166782011-03-15 Andreas Schwab <schwab@linux-m68k.org>
16679
16680 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
16681 structure.
16682
7684e57b
JB
166832011-03-14 Juanma Barranquero <lekktu@gmail.com>
16684
16685 * lisp.h (VWindow_system, Qfile_name_history):
16686 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
16687 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
16688 (w32_system_caret_x, w32_system_caret_y): Declare extern.
16689
16690 * w32select.c: Don't #include "keyboard.h".
c96bbc66 16691 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
16692
16693 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
16694 * w32console.c (detect_input_pending, read_input_pending)
16695 (encode_terminal_code):
16696 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
16697 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
16698 (w32_system_caret_y, Qfile_name_history):
16699 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
16700 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
16701 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
16702 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
16703 * w32proc.c (Qlocal, report_file_error):
16704 * w32term.c (Vwindow_system, updating_frame):
16705 * w32uniscribe.c (initialized, uniscribe_font_driver):
16706 Remove unneeded extern declarations.
16707
2aa46d6c
CY
167082011-03-14 Chong Yidong <cyd@stupidchicken.com>
16709
c96bbc66 16710 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 16711
cffc6f3b
CY
167122011-03-13 Chong Yidong <cyd@stupidchicken.com>
16713
16714 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
16715 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
16716 These macros can no longer be used for assignment.
16717
44f230aa
SM
16718 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
16719 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
16720 (record_buffer_markers, fetch_buffer_markers): New functions for
16721 recording and fetching special buffer markers.
16722 (set_buffer_internal_1, set_buffer_temp): Use them.
16723
16724 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
16725
16726 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
16727
16728 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
16729 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
16730
16731 * xdisp.c (hscroll_window_tree):
16732 (reconsider_clip_changes): Use PT instead of BUF_PT.
16733
d251f04b
EZ
167342011-03-13 Eli Zaretskii <eliz@gnu.org>
16735
16736 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
16737 $(EMACS_ROOT)/lib/intprops.h.
16738
f0c77cd1
PE
167392011-03-13 Paul Eggert <eggert@cs.ucla.edu>
16740
3eca4629
PE
16741 Fix more problems found by GCC 4.5.2's static checks.
16742
7c86ee98
PE
16743 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
16744 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
16745 (xg_free_frame_widgets): Make it clear that a local variable is
16746 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
16747 (gdk_window_get_screen): Make it clear that this macro is needed
16748 only if USE_GTK_TOOLTIP.
1e5524e7
PE
16749 (int_gtk_range_get_value): New function, which avoids a diagnostic
16750 from gcc -Wbad-function-cast.
16751 (xg_set_toolkit_scroll_bar_thumb): Use it.
16752 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
16753 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
16754 (get_utf8_string, xg_get_file_with_chooser):
16755 Rename locals to avoid shadowing.
16756 (create_dialog): Move locals to avoid shadowing.
7c86ee98 16757
41729b81
PE
16758 * xgselect.c (xg_select): Remove unused var.
16759
f0c77cd1
PE
16760 * image.c (four_corners_best): Mark locals as initialized.
16761 (gif_load): Initialize transparent_p to zero (Bug#8238).
16762 Mark another local as initialized.
ec6cf4c6 16763 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 16764
ce0ad53d 16765 * image.c (clear_image_cache): Now static.
d5d5a617 16766 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 16767 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
16768 (x_edge_detection): Remove unnecessary cast that
16769 gcc -Wbad-function-cast diagnoses.
2037898d 16770 (gif_load): Fix pointer signedness.
6ae141d6
PE
16771 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
16772 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 16773
33383987 167742011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 16775
d32df629
PE
16776 Improve quality of tests for time stamp overflow.
16777 For example, without this patch (encode-time 0 0 0 1 1
16778 1152921504606846976) returns the obviously-bogus value (-948597
16779 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
16780 reports time overflow. See
16781 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
16782 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
16783 * editfns.c: Include limits.h and intprops.h.
16784 (TIME_T_MIN, TIME_T_MAX): New macros.
16785 (time_overflow): Move earlier, to before first use.
16786 (hi_time, lo_time): New functions, for an accurate test for
16787 out-of-range times.
16788 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
16789 (Fget_internal_run_time): Don't assume time_t fits in int.
16790 (make_time): Use list2 instead of Fcons twice.
16791 (Fdecode_time): More accurate test for out-of-range times.
16792 (check_tm_member): New function.
16793 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
16794 (lisp_time_argument): Don't rely on undefined left-shift and
16795 right-shift behavior when checking for time stamp overflow.
8be6f318 16796
fe31d94c
PE
16797 * editfns.c (time_overflow): New function, refactoring common code.
16798 (Fformat_time_string, Fdecode_time, Fencode_time):
16799 (Fcurrent_time_string): Use it.
16800
8be6f318
PE
16801 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
16802 * dired.c (make_time): Move to ...
16803 * editfns.c (make_time): ... here.
16804 * systime.h: Note the move.
16805
09d9db2c 168062011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 16807
126bc0dc
YM
16808 * fringe.c (update_window_fringes): Remove unused variables.
16809
c47cbdfd
YM
16810 * unexmacosx.c (copy_data_segment): Also copy __got section.
16811 (Bug#8223)
16812
7ac80be9
EZ
168132011-03-12 Eli Zaretskii <eliz@gnu.org>
16814
c96bbc66 16815 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
16816 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
16817 Constify `char *' arguments and their references according to
16818 prototypes in tparam.h.
16819
ecb0f94d 16820 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 16821
7ac80be9
EZ
16822 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
16823 Adapt all references accordingly.
16824
16825 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
16826
ef1fd07e
TT
168272011-03-11 Tom Tromey <tromey@redhat.com>
16828
16829 * buffer.c (syms_of_buffer): Remove obsolete comment.
16830
7ef4b50c
EZ
168312011-03-11 Eli Zaretskii <eliz@gnu.org>
16832
16833 * termhooks.h (encode_terminal_code): Declare prototype.
16834
16835 * msdos.c (encode_terminal_code): Don't declare prototype.
16836
16837 * term.c (encode_terminal_code): Now external again, used by
16838 w32console.c and msdos.c.
16839
44f230aa
SM
16840 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
16841 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 16842
4b1ec863 168432011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 16844
1714f52b 16845 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 16846
4b1ec863
PE
16847 * fringe.c (update_window_fringes): Mark locals as initialized
16848 (Bug#8227).
16849 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 16850
524c7aa6
PE
16851 * alloc.c (mark_fringe_data): Move decl from here ...
16852 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
16853 to check its interface.
16854 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
16855
a5c0af81 16856 * fontset.c (free_realized_fontset): Now static.
7519b8cd 16857 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 16858 (fontset_font): Mark local as initialized.
a9a06e0b 16859 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 16860
b4716021
PE
16861 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
16862
811e9bac 16863 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 16864 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
16865 (x_own_selection, Fx_disown_selection_internal): Rename locals
16866 to avoid shadowing.
16867 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 16868
7e3ab302
PE
16869 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
16870 so that the caller can use some name other than gcpro1.
16871 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
16872 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16873 (Fx_backspace_delete_keys_p):
16874 Use them to avoid shadowing, and rename vars to avoid shadowing.
16875 (x_decode_color, x_set_name, x_window): Now static.
6b437900 16876 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 16877 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
16878 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
16879 Remove unused locals.
7e3ab302
PE
16880 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16881 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
16882 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
16883 macros.
f78faa98 16884
e2b13473
PE
16885 * xterm.h (x_mouse_leave): New decl.
16886
77f23912
PE
16887 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
16888 Remove unused functions.
cdf4ba58
PE
16889 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
16890 (x_calc_absolute_position): Now static.
7411c686 16891 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 16892 Don't declare local "event" unless it's used.
ed7bf3a5
PE
16893 (x_iconify_frame, x_free_frame_resources): Don't declare locals
16894 unless they are used.
38d0b34a
PE
16895 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
16896 (x_fatal_error_signal): Remove; not used.
a6067996
PE
16897 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
16898 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
16899 (x_error_catcher, x_connection_closed, x_error_handler):
16900 (x_error_quitter, xembed_send_message, x_iconify_frame):
16901 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 16902 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 16903 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 16904
44f230aa
SM
16905 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
16906 Rename or move locals to avoid shadowing.
6b463e58 16907 (tty_defined_color, merge_face_heights): Now static.
5967d051 16908 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
16909 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
16910 does not deduce is never used uninitialized.
73719eba
PE
16911 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
16912 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 16913
426994c3 16914 * terminal.c (store_terminal_param): Now static.
5489860b 16915
032f1620 16916 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 16917 (set_frame_menubar): Remove unused local.
d4323972 16918 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
16919 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
16920 since they might point to immutable storage.
281585b0
PE
16921 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
16922 since it's unused otherwise.
032f1620 16923
367c19e5 16924 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 16925 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
16926 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
16927 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 16928 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
16929 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
16930 does not deduce are never used uninitialized.
70739cbe 16931
07b48fa9
PE
16932 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
16933
8868a238 16934 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
16935 * window.c (window_loop, size_window):
16936 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 16937
7e5cf297 16938 * window.c (display_buffer): Now static.
d6550a9f
PE
16939 (size_window): Mark variables that gcc -Wuninitialized
16940 does not deduce are never used uninitialized.
a586633d
PE
16941 * window.h (check_all_windows): New decl, to forestall
16942 gcc -Wmissing-prototypes diagnostic.
5b555da1 16943 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 16944
f6095868
PE
16945 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
16946 shadowing.
16947 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
16948 Include <limits.h>.
16949 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
16950 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
16951 (load_charset_map): Mark variables that gcc -Wuninitialized
16952 does not deduce are never used uninitialized.
53df7c11 16953 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 16954
f38b440c
PE
16955 * coding.c (coding_set_source, coding_set_destination):
16956 Use "else { /* comment */ }" rather than "else /* comment */;"
16957 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
16958 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
16959 a block, when the outer 'i' will do.
16960 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
16961 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
16962 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
16963 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
16964 (Fdecode_sjis_char, Fdefine_coding_system_internal):
16965 Rename locals to avoid shadowing.
16966 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
16967 * coding.c (emacs_mule_char, encode_invocation_designation):
16968 Now static, since they're not used elsewhere.
413bb2db 16969 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 16970 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
16971 (decode_coding_emacs_mule): Mark variables that gcc
16972 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
16973 (detect_coding_iso_2022): Initialize a local variable that might
16974 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 16975 this initialization is needed. (Bug#8211)
5f58e762
PE
16976 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
16977 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
16978 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
16979 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
16980 Remove unused macros.
f38b440c 16981
232b38b9 16982 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 16983 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 16984 * character.c (string_count_byte8): Likewise.
232b38b9 16985
fb90da1b
PE
16986 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
16987 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
16988
fb93dbc2
PE
16989 * chartab.c (copy_sub_char_table): Now static, since it's not used
16990 elsewhere.
5c156ace
PE
16991 (sub_char_table_ref_and_range, char_table_ref_and_range):
16992 Rename locals to avoid shadowing.
bbcd0949 16993 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 16994
7d3b3862 16995 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 16996 (BIDI_BOB): Remove unused macro.
7d3b3862 16997
6be7d3da
PE
16998 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
16999 deduce are never used uninitialized.
c2ed9c8b 17000 * term.c (encode_terminal_code): Likewise.
6be7d3da 17001
75f8807f 17002 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 17003
50938595
PE
17004 * tparam.h: New file.
17005 * term.c, tparam.h: Include it.
17006 * deps.mk (term.o, tparam.o): Depend on tparam.h.
17007 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
17008 Move these decls to tparam.h, and make them agree with what
17009 is actually in tparam.c. The previous trick of using incompatible
17010 decls in different modules does not conform to the C standard.
17011 All callers of tparam changed to use tparam's actual API.
17012 * tparam.c (tparam1, tparam, tgoto):
17013 Use const pointers where appropriate.
17014
fbceeba2
PE
17015 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
17016 * cm.h (struct cm): Likewise.
17017 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
17018 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
17019 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
17020 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
17021 (turn_on_face, init_tty): Likewise.
17022 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 17023
7f3f1250
PE
17024 * term.c (term_mouse_position): Rename local to avoid shadowing.
17025
e6ca6543
PE
17026 * alloc.c (mark_ttys): Move decl from here ...
17027 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
17028
c40f8d15
AS
170292011-03-11 Andreas Schwab <schwab@linux-m68k.org>
17030
17031 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
17032
cfe0661d
JB
170332011-03-09 Juanma Barranquero <lekktu@gmail.com>
17034
17035 * search.c (compile_pattern_1): Remove argument regp, unused since
17036 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
17037 (compile_pattern): Don't pass it.
17038
0afb4571
J
170392011-03-08 Jan Djärv <jan.h.d@swipnet.se>
17040
17041 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
17042 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
17043 for ! HAVE_GTK3.
17044 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
17045
17046 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
17047
17048 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
17049 gdk_window_get_screen, gdk_window_get_geometry,
17050 gdk_x11_window_lookup_for_display and GDK_KEY_g.
17051 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
17052 (xg_get_pixbuf_from_pixmap): New function.
17053 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
17054 to Pixmap, take frame as parameter, remove GdkColormap parameter.
17055 Call xg_get_pixbuf_from_pixmap instead of
17056 gdk_pixbuf_get_from_drawable.
17057 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
17058 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
17059 (xg_check_special_colors): Use GtkStyleContext and its functions
17060 for HAVE_GTK3.
17061 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
17062 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
17063 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
17064 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
17065 Call gtk_widget_get_preferred_size.
0afb4571
J
17066 (xg_frame_resized): gdk_window_get_geometry only takes 5
17067 parameters.
44f230aa
SM
17068 (xg_win_to_widget, xg_event_is_for_menubar):
17069 Call gdk_x11_window_lookup_for_display.
0afb4571
J
17070 (xg_set_widget_bg): New function.
17071 (delete_cb): New function.
895009e1 17072 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 17073 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
17074 (xg_set_background_color): Call xg_set_widget_bg.
17075 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
17076 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
17077 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
17078 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
17079 if ! HAVE_GTK3.
17080 (update_frame_tool_bar): Call gtk_widget_hide.
17081 (xg_initialize): Use GDK_KEY_g.
17082
17083 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
17084 if ! HAVE_GTK3
17085 (x_session_initialize): Call gdk_x11_set_sm_client_id.
17086
17087 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
17088 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
17089 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
17090
1c2cc4ef
JB
170912011-03-08 Juanma Barranquero <lekktu@gmail.com>
17092
17093 * w32xfns.c (select_palette): Check success of RealizePalette against
17094 GDI_ERROR, not zero.
17095
33383987 17096See ChangeLog.11 for earlier changes.
aac0c6e3
MR
17097
17098;; Local Variables:
17099;; coding: utf-8
aac0c6e3
MR
17100;; End:
17101
2f097256 17102 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
17103
17104 This file is part of GNU Emacs.
17105
17106 GNU Emacs is free software: you can redistribute it and/or modify
17107 it under the terms of the GNU General Public License as published by
17108 the Free Software Foundation, either version 3 of the License, or
17109 (at your option) any later version.
17110
17111 GNU Emacs is distributed in the hope that it will be useful,
17112 but WITHOUT ANY WARRANTY; without even the implied warranty of
17113 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17114 GNU General Public License for more details.
17115
17116 You should have received a copy of the GNU General Public License
17117 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.