* calc/calc-prog.el (math-do-defmath): Use backquote forms. Fix
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c644523b
DA
12012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
4 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
5 name since all xname users are fixed long time ago. Do not
6 use INTERNAL_FIELD.
7 (set_symbol_name, set_symbol_function, set_symbol_plist):
8 (set_symbol_next, set_overlay_plist): New function.
9 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
10 (struct Lisp_Overlay): Likewise.
11 (CVAR, MVAR, SVAR): Remove.
12 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
13 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
14 * xterm.c: Adjust users.
15 * .gdbinit: Change to use name field of struct Lisp_Symbol
16 where appropriate.
17
6a3d20cc
DA
182012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
19
20 Basic functions to set Lisp_Object and pointer slots of intervals.
21 * intervals.h (interval_set_parent, interval_set_object):
22 (interval_set_left, interval_set_right, interval_set_plist):
23 (interval_copy_parent): New function.
24 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
25 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE): Adjust
26 indentation.
27 (INTERVAL_SIZE): Remove. Adjust users.
28 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
29
4d2b044c
DA
302012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
31
32 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
33 * process.h (PGET): Remove.
34 (struct Lisp_Process): Do not use INTERNAL_FIELD.
35 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
36
d3d50620
DA
372012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
38
39 Drop WGET and revert read access to Lisp_Objects slots of struct window.
40 * window.h (WGET): Remove.
41 (struct window): Do not use INTERNAL_FIELD.
42 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
43 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
44 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
45 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
46 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
47 Adjust users.
48
d10a51dc
CY
492012-08-07 Chong Yidong <cyd@gnu.org>
50
51 * window.c (Fwindow_edges, Fwindow_pixel_edges)
52 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
53 (Fdelete_window_internal): Signal an error if the window is not on
54 a live frame (Bug#12025).
55
e69b0960
DA
562012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
57
58 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
59 * frame.h (FGET): Remove.
60 (struct frame): Do not use INTERNAL_FIELD.
61 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
62 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
63 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
64 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
65
25a20a3a
JB
662012-08-06 Juanma Barranquero <lekktu@gmail.com>
67
68 * w32.c: Silence compiler warnings.
69 (map_w32_filename): Remove unused variable `is_fat'.
70 (chase_symlinks): Add parentheses around expression.
71
1c6f11f4
GM
722012-08-06 Glenn Morris <rgm@gnu.org>
73
1db4583a
GM
74 * sysdep.c: Respect BROKEN_GETWD.
75
1c6f11f4
GM
76 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
77 Let configure handle it.
78 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
79
2b90362b
DA
802012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
81
82 Use GCALIGNMENT where appropriate.
83 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
84 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
85 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
86
5f50daf2
EZ
872012-08-06 Eli Zaretskii <eliz@gnu.org>
88
89 * w32menu.c (set_frame_menubar, initialize_frame_menubar): Don't
90 use FRAME_MENU_BAR_ITEMS as an lvalue.
91
cbcc7007
SM
922012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
93
94 * buffer.h (struct buffer): Revert `indirections' to a simple int;
95 that should be sufficient for everyone.
96
4d365fa4
JD
972012-08-06 Jan Djärv <jan.h.d@swipnet.se>
98
99 * keyboard.c (timer_check_2): Add break so timer_check returns next
100 timeout.
101
dd86bd82
DA
1022012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
103
104 Fix Windows build errors introduced after converting to WGET and WSET.
105 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
106 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
107
054e1668
JD
1082012-08-06 Jan Djärv <jan.h.d@swipnet.se>
109
110 * nsterm.m (ns_frame_rehighlight): Use FSET.
111
112 * nsmenu.m (ns_update_menubar): Use FSET.
113
21238f11
DA
1142012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
115
116 Separate read and write access to Lisp_Object slots of Lisp_Process.
117 * process.h (PGET, PSET): New macros similar to AREF and ASET.
118 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
119
077288cf
DA
1202012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
121
122 Separate read and write access to Lisp_Object slots of struct window.
123 * window.h (WGET, WSET): New macros similar to AREF and ASET.
124 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
125 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
126 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
127 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
128 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
129 Adjust users.
130
71688bd7
DA
1312012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
132
133 Fix Windows build errors introduced after converting to FGET and FSET.
134 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
135 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
136 (w32_judge_scroll_bars): Change to use FSET.
137 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
138
f99bac93
DA
1392012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
140
141 Fix replacement typo.
142 * window.c (replace_window): Set root_window instead of
143 selected_window. This fixes a total window subsystem
144 malfunction reported by Bastien Guerry <bzg@gnu.org>.
145
8c2a0f2d
GM
1462012-08-06 Glenn Morris <rgm@gnu.org>
147
148 * lisp.mk (lisp): Add language/persian.elc.
149
edd74c35
DA
1502012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
151
152 Separate read and write access to Lisp_Object slots of struct frame.
153 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
154 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
155 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
156 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
157 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
158
8671676c
AS
1592012-08-05 Andreas Schwab <schwab@linux-m68k.org>
160
161 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
162
663e2b3f
DA
1632012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
164
165 Generalize common compile-time constants.
166 * lisp.h (header_size, bool_header_size, word_size): Now here.
167 (struct Lisp_Vector): Add comment.
168 (struct Lisp_Bool_Vector): Move up to define handy constants.
169 (VECSIZE, PSEUDOVECSIZE): Simplify.
170 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
171 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
172 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
173 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
174 * xfont.c, xmenu.c: Use word_size where appropriate.
175
d32e47af
LM
1762012-08-05 Lawrence Mitchell <wence@gmx.li>
177
178 * search.c (Freplace_match): Treat \? in the replacement text
179 literally (Bug#8161).
180
e5d9c0d1
CY
1812012-08-05 Chong Yidong <cyd@gnu.org>
182
183 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
184 * frame.c (Vdelete_frame_functions):
185 * emacs.c (Vkill_emacs_hook): Doc fix.
186
8da0576b
EZ
1872012-08-04 Eli Zaretskii <eliz@gnu.org>
188
189 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
190 --with-x-toolkit=no builds.
191 Reported by Carsten Mattner <carstenmattner@gmail.com>.
192
02676e5d
CY
1932012-08-04 Chong Yidong <cyd@gnu.org>
194
195 * syntax.c (Fmodify_syntax_entry): Doc fix.
196
97147da9
EZ
1972012-08-04 Eli Zaretskii <eliz@gnu.org>
198
76151e2c
EZ
199 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
200 * w32.c (init_environment): Change the default values of many
201 environment variables in dflt_envvars[] to NULL, to avoid pushing
202 them into environment when they were not already defined. Remove
203 the code that deletes site-lisp subdirectories from the default
204 value of EMACSLOADPATH, as it is no longer needed.
205 (check_windows_init_file): Now external, not static. Use
206 Vload_path as is, without adding anything, as this function is now
207 called when Vload_path is already set up.
208
209 * w32.h (check_windows_init_file): Add prototype.
210
211 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
212 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
213 compatibility with Posix platforms.
214 (main): Move the call to check_windows_init_file to here from
215 w32.c.
216 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
217 any, in the DEFALT argument into the root of the Emacs build or
218 installation tree, as appropriate.
219
220 * callproc.c (init_callproc_1): Call decode_env_path instead of
221 doing its equivalent by hand.
222 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
223 the code that sets Vexec_path run on MS-Windows.
224
225 * lread.c (init_lread): Add comments to #ifdef's.
226
97147da9
EZ
227 * msdos.c (dos_set_window_size, IT_update_begin)
228 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
229 instead of direct references.
230
185ee146
PE
2312012-08-04 Paul Eggert <eggert@cs.ucla.edu>
232
233 Export DEFAULT_REHASH_* to GDB.
234 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
235 Now constants, not macros.
236
8834c57a
PE
2372012-08-03 Paul Eggert <eggert@cs.ucla.edu>
238
98c6f1e3
PE
239 Remove unnecessary casts involving pointers.
240 These casts are no longer needed now that we assume C89 or later,
241 since they involve casting to or from void *.
242 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
243 (make_pure_float, make_pure_vector):
244 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
245 * macros.c (Fstart_kbd_macro):
246 * menu.c (find_and_return_menu_selection):
247 * minibuf.c (read_minibuf_noninteractive):
248 * sysdep.c (closedir):
249 * xdisp.c (x_produce_glyphs):
250 * xfaces.c (compare_fonts_by_sort_order):
251 * xfns.c (x_real_positions, select_visual):
252 * xselect.c (x_stop_queuing_selection_requests)
253 (x_get_window_property, x_get_window_property_as_lisp_data):
254 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
255 Remove unnecessary pointer casts.
256 * alloc.c (record_xmalloc): New function.
257 * lisp.h (record_xmalloc): New decl.
258 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
259 more like a function. This is because the pointer cast is not
260 needed. All uses changed.
261 * print.c (print_string, print_error_message): Avoid length recalc.
262
8834c57a
PE
263 Improve fix for macroexp crash with debugging (Bug#12118).
264 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
265 ARRAY_MARK_FLAG when checking subscripts, because ASET is
266 not supposed to be invoked from the garbage collector.
267 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
268 (gc_aset): New function, which is like ASET but can be
269 used in the garbage collector.
270 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
271 (set_hash_index): Use it instead of ASET.
272
6dad7178
EZ
2732012-08-03 Eli Zaretskii <eliz@gnu.org>
274
275 Support symlinks on latest versions of MS-Windows.
276 * w32.c: Include winioctl.h and aclapi.h.
277 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
278 (revert_to_self): Forward declarations of static functions.
279 <static BOOL g_b_init_get_security_info>:
280 <g_b_init_create_symbolic_link>: New static flags.
281 (globals_of_w32): Initialize them to zero.
282 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
283 (map_w32_filename): Improve commentary. Simplify switch.
284 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
285 headers (most versions of MinGW w32api don't).
286 (get_security_info, create_symbolic_link)
287 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
288 New functions.
289 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
290 in the argument file name.
291 (sys_access): Call unc_volume_file_attributes only if
292 GetFileAttributes fails with network-related error codes.
293 (sys_rename): Diagnose renaming of a symlink when the user doesn't
294 have the required privileges.
295 (get_file_security_desc_by_name): Renamed from
296 get_file_security_desc.
297 (stat_worker): New function, with most of the guts of 'stat', and
298 with addition of handling of symlinks and support for 'lstat'. If
299 possible, get file's attributes and security information by
300 handle, not by name. Produce S_IFLNK bit for symlinks, when
301 called from 'lstat'.
302 (stat, lstat): New functions, call 'stat_worker'.
303 (symlink, readlink, careadlinkat): Rewritten to create and resolve
304 symlinks when the underlying filesystem supports them.
305
f162bcc3
PE
3062012-08-02 Paul Eggert <eggert@cs.ucla.edu>
307
79ea6c20
PE
308 Fix macroexp crash on Windows with debugging (Bug#12118).
309 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
310 checking subscripts; problem introduced with the recent
311 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
312 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
313 since it's used in non-static inline functions now.
314
c0ce93fd
PE
315 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
316 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 317
f162bcc3
PE
318 Use C99-style 'extern inline' if available.
319 * buffer.h (BUFFER_INLINE):
320 * category.h (CATEGORY_INLINE):
321 * character.h (CHARACTER_INLINE):
322 * charset.h (CHARSET_INLINE):
323 * composite.h (COMPOSITE_INLINE):
324 * dispextern.h (DISPEXTERN_INLINE):
325 * lisp.h (LISP_INLINE):
326 * systime.h (SYSTIME_INLINE):
327 New macro, replacing 'static inline' in this header.
328 * buffer.h, category.h, character.h, charset.h, composite.h:
329 * dispextern.h, lisp.h, systime.h:
330 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
331 * alloc.c (LISP_INLINE):
332 * buffer.c (BUFFER_INLINE):
333 * category.c (CATEGORY_INLINE):
334 * character.c (CHARACTER_INLINE):
335 * charset.c (CHARSET_INLINE):
336 * composite.c (COMPOSITE_INLINE):
337 * dispnew.c (DISPEXTERN_INLINE):
338 * sysdep.c (SYSTIME_INLINE):
339 Define to EXTERN_INLINE, so that the corresponding functions
340 are compiled into code.
341 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
342 (INLINE_HEADER_END): New macros.
343 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
344 since it's used in non-static inline functions now.
a8333d03 345 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 346
837b365b
GM
3472012-08-02 Glenn Morris <rgm@gnu.org>
348
d66b744d
GM
349 * s/: Remove empty directory.
350
837b365b
GM
351 * s/ms-w32.h: Move to ../nt/inc.
352 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
353 Update for new ms-w32.h location.
354
13294f95
PE
3552012-08-02 Paul Eggert <eggert@cs.ucla.edu>
356
357 Port to Solaris 8.
358 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
359
90df0db3
GM
3602012-08-02 Glenn Morris <rgm@gnu.org>
361
362 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
363 hard-coding the path separator.
364
4939150c
PE
3652012-08-01 Paul Eggert <eggert@cs.ucla.edu>
366
367 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
368 This how ASET and AREF are supposed to work, and makes
369 it easier to think about future improvements. See
370 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
371 * charset.h (set_charset_attr): New function.
372 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
373 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
374 (aref_addr): New function. All uses of &AREF(...) changed.
375 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
376 (set_hash_index): New functions. All lvalue-style uses of
377 HASH_KEY etc. changed.
378 * keyboard.c (set_prop): New function. All lvalue-style uses
379 of PROP changed.
380
947b2afd
AA
3812012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
382
383 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
384 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
385 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
386 * nsfns.m (ns_set_name_as_filename): Likewise.
387 * nsmenu.m (ns_update_menubar): Likewise.
388 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
389
4f5d0325
EZ
3902012-08-01 Eli Zaretskii <eliz@gnu.org>
391
2008beae
EZ
392 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
393 Adapt to latest changes in field names of the corresponding Lisp
288479f6 394 objects.
2008beae 395
4f5d0325
EZ
396 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
397
fe3cc771
GM
3982012-08-01 Glenn Morris <rgm@gnu.org>
399
400 * s/msdos.h: Remove file.
401 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
402 * Makefile.in (S_FILE): Remove.
403 (config_h): Remove S_FILE.
404
c90acc54
JB
4052012-08-01 Juanma Barranquero <lekktu@gmail.com>
406
407 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
408 Remove; moved to nt/config.nt.
409
d8a05828
DA
4102012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
411
412 Use INTERNAL_FIELD for conses and overlays.
413 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
414 Remove obsolete comment.
415 (MVAR): New macro.
416 (struct Lisp_Overlay): Use INTERNAL_FIELD.
417 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
418
8271d590
DA
4192012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
420
421 Use INTERNAL_FIELD for symbols.
422 * lisp.h (SVAR): New macro. Adjust users.
423 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
424 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
425
3193acd2
DA
4262012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
427
428 Use INTERNAL_FIELD for processes.
429 * process.h (PVAR): New macro. Adjust style.
430 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
431 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
432
3a45383a
DA
4332012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
434
435 Use INTERNAL_FIELD for windows.
436 * window.h (WVAR): New macro.
437 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
438 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
439 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
440 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
441 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
442 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
443
c1dbc63c
PE
4442012-08-01 Paul Eggert <eggert@cs.ucla.edu>
445
446 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
447
5c0c0e8a
GM
4482012-08-01 Glenn Morris <rgm@gnu.org>
449
450 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
451 Move to configure.ac.
452
552a99b4
JB
4532012-08-01 Juanma Barranquero <lekktu@gmail.com>
454
455 * makefile.w32-in (CONFIG_H): Update dependencies.
456 (CONF_POST_H): New macro.
457
458 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
459
8d8e2dfe
GM
4602012-07-31 Glenn Morris <rgm@gnu.org>
461
bc96620a
GM
462 * Makefile.in (S_FILE): No longer set by configure.
463
476b1b2d
GM
464 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
465 is available.
466 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
467
b2c7a106
GM
468 * process.h (NULL_DEVICE):
469 * emacs.c (SEPCHAR):
470 * editfns.c (USER_FULL_NAME): Let configure set them.
471
d53d062a
GM
472 * s/README, s/template.h: Remove files.
473
4515017f
GM
474 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
475
8d8e2dfe
GM
476 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
477 Move to configure.ac.
478
5b20b3cc
EZ
4792012-07-31 Eli Zaretskii <eliz@gnu.org>
480
1e0afd9a
EZ
481 * .gdbinit (xframe): Adapt to introduction of FVAR and the
482 resulting renaming of 'struct frame' members.
483
5b20b3cc
EZ
484 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
485
486 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
487 after introduction of FVAR.
488
f1310128
JD
4892012-07-31 Jan Djärv <jan.h.d@swipnet.se>
490
79e721e0
JD
491 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
492
493 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
494 instead of compositeToPoint.
495 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
496
8d7c7eed 497 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 498
e34f7f79
DA
4992012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
500
501 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
502 * lisp.h (INTERNAL_FIELD): New macro.
503 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
504 (BVAR): Change to use INTERNAL_FIELD.
505 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
506 (KVAR): Change to use INTERNAL_FIELD.
507 * frame.h (FVAR): New macro.
508 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
509 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
510 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
511 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
512 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
513
c09bfb2f
DA
5142012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
515
516 Miscellaneous fixes for non-default X toolkits.
517 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
518 * xterm.c (x_frame_of_widget): Remove redundant prototype.
519 Move under #ifdef USE_LUCID.
520 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
521 definition and usage to avoid warnings.
522
14c114ae
JD
5232012-07-31 Jan Djärv <jan.h.d@swipnet.se>
524
525 * nsterm.m (openFiles): Fix previous checkin.
526
3bd21e82
PE
5272012-07-31 Paul Eggert <eggert@cs.ucla.edu>
528
529 * indent.c (compute_motion): Remove unused local.
530
c1529ded
GM
5312012-07-31 Glenn Morris <rgm@gnu.org>
532
400d5621
GM
533 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
534
268e2432
GM
535 * conf_post.h [USG5_4]:
536 Move remaining contents of s/usg5-4-common.h here.
537 * s/usg5-4-common.h: Remove file.
538
7552f3ee
GM
539 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
540 * s/irix6-5.h: Remove file.
541
6a381852
GM
542 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
543 * s/darwin.h: Remove file.
544
c1529ded
GM
545 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
546 * s/hpux10-20.h: Remove file, which is now empty.
547
b429a4ee
GM
5482012-07-30 Glenn Morris <rgm@gnu.org>
549
550 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
551 * Makefile.in (config_h): Add conf_post.h.
552 * makefile.w32-in (CONFIG_H): Add conf_post.h.
553
adff3182
JD
5542012-07-30 Jan Djärv <jan.h.d@swipnet.se>
555
556 * nsterm.m (ns_do_open_file): New variable.
b9031d69 557 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
558 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
559 files only if ns_do_open_file.
560
c32af1e4
PE
5612012-07-30 Paul Eggert <eggert@cs.ucla.edu>
562
7393bcbb
PE
563 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
564 This no-op macro hasn't been needed for many years.
565 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
566
c32af1e4
PE
567 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
568 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
569 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
570 gdb_make_enums_visible.
571 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
572 (DIRECTORY_SEP): Now a constant, not a macro.
573
302fc036
EZ
5742012-07-30 Eli Zaretskii <eliz@gnu.org>
575
576 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
577 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
578
579 * w32term.c <w32_keyboard_codepage>: Renamed from
580 keyboard_codepage and now external. All users changed.
581
582 * w32term.h: Add declaration of w32_keyboard_codepage.
583
584 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
585 the codepage to translate keys to Unicode. If this argument is
586 -1, use the value returned by GetConsoleCP. All callers changed.
587
88fb40b4
PE
5882012-07-30 Paul Eggert <eggert@cs.ucla.edu>
589
0aee6912
PE
590 Update .PHONY listings in makefiles.
591 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
592 bootstrap-clean, distclean, maintainer-clean, versioclean,
593 extraclean, frc.
594
88fb40b4
PE
595 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
596 This is a bit clearer. Fix some commentary typos.
597
0a763bd1
GM
5982012-07-30 Glenn Morris <rgm@gnu.org>
599
32bac6d6
GM
600 * s/netbsd.h: Let configure include signal.h if needed.
601 Remove file, which is now empty.
602
b65e7c46
GM
603 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
604 Let configure set them.
605 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
606 No more need to undefine.
0a763bd1 607
169304bd
AS
6082012-07-30 Andreas Schwab <schwab@linux-m68k.org>
609
610 * keymap.c (Fkey_description): Don't remove 0x80 bit from
611 non-single-byte char when adding meta modifier. (Bug#12090)
612
6cd7a139
DA
6132012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
614
615 Convert safe_call to use variable number of arguments.
616 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
617 (safe_call2): Fix comment.
618 * lisp.h (safe_call): Adjust prototype.
619 * coding.c (encode_coding_object): Change to use safe_call2.
620 * xfaces.c (merge_face_heights): Change to use safe_call1.
621
d34d6ffc
GM
6222012-07-30 Glenn Morris <rgm@gnu.org>
623
7b8a48e4 624 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 625 does that unconditionally. Remove file, which is now empty.
7b8a48e4 626
d34d6ffc
GM
627 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
628 Remove empty files.
629
03a660a6
PE
6302012-07-30 Paul Eggert <eggert@cs.ucla.edu>
631
632 Export to GDB most of lisp.h's remaining object-like macros.
633 * lisp.h (min, max): Move earlier, because they're used earlier now.
634 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
635 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
636 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
637 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
638 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
639 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
640 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
641 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
642 Now constants, for GDB. They need not be macros.
643 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
644 Now constants, for GDB, as well as macros, for static initializers.
645 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
646 Move to after the definition of struct Lisp_Char_Table,
647 since the former now needs that type defined.
648 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
649 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
650 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
651 New enums, for gdb_make_enums_visible.
652 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 653 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
654 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
655 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
656 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
657 enum maxargs, enum MAX_ALLOCA.
658 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
659 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
660 no longer needed, now that they are done in lisp.h.
661
e499d0ee
DA
6622012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
663
664 Cleanup string bytes checking.
665 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
666 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
667 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
668 (check_sblock, compact_small_strings): Simplify.
669
d5040d2d
PE
6702012-07-29 Paul Eggert <eggert@cs.ucla.edu>
671
672 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
673 These macros are confusing and no longer need to be defined, as
674 the enum values now suffice. All uses replaced with definiens.
675 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
676
7f259ae6
JB
6772012-07-29 Juanma Barranquero <lekktu@gmail.com>
678
679 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
680 ($(BLD)/w32console.$(O)): Update dependencies.
681
7e63e0c3
DA
6822012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
683
684 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
685 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
686 time. Adjust users.
687 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
688
ffd817eb
JD
6892012-07-29 Jan Djärv <jan.h.d@swipnet.se>
690
691 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
692 setting sitelisp (Bug#12010).
693
417a7a0e
EZ
6942012-07-29 Eli Zaretskii <eliz@gnu.org>
695
696 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
697
698 * w32heap.c (cache_system_info):
699 * w32.c (sys_rename):
700 * w32proc.c (find_child_console, sys_kill): All users changed.
701
387d4d92
PE
7022012-07-29 Paul Eggert <eggert@cs.ucla.edu>
703
704 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
705
55a6cca6
EZ
7062012-07-29 Eli Zaretskii <eliz@gnu.org>
707
708 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
709
dbcf001c
DA
7102012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
711
712 Cleanup statistics calculation in Fgarbage_collect.
713 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
714 zombies percentage calculation. Simplify elapsed time calculation.
715
e2688e4a
DA
7162012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
717
718 Generalize marker debugging code under MARKER_DEBUG and use eassert.
719 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
720 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
721 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
722 (replace_range, replace_range_2, del_range_2): Change to eassert.
723 * marker.c (byte_char_debug_check): Adjust style.
724
b46a6a83
PE
7252012-07-29 Paul Eggert <eggert@cs.ucla.edu>
726
727 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
728 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
729 long-ago-commented-out code that talks about "WIN32".
730 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
731 All uses changed.
732
e32a5799
PE
7332012-07-28 Paul Eggert <eggert@cs.ucla.edu>
734
735 Use Gnulib stdalign module (Bug#9772, Bug#9960).
736 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
737 Simplify by using alignof.
738 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
739 * lisp.h: Include <stdalign.h>.
740 (GCALIGNMENT): New macro and constant.
741 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
742 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
743 (stdalign): New macro, if not already defined.
744
df81cd29
EZ
7452012-07-28 Eli Zaretskii <eliz@gnu.org>
746
01bd1b0d
EZ
747 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
748 * w32inevt.c: Include w32inevt.h.
749 (w32_read_console_input): New inline function, calls either
750 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
751 w32_console_unicode_input.
752 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
753 (w32_kbd_patch_key, key_event): Use the codepage returned by
754 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
755 (key_event): use uChar.UnicodeChar only if
756 w32_console_unicode_input is non-zero.
757
758 * w32console.c: Include w32heap.h.
759 <w32_console_unicode_input>: New global variable.
760 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
761 family of Windows, zero otherwise.
762
763 * w32inevt.h: Declare w32_console_unicode_input.
764
df81cd29
EZ
765 * xdisp.c (init_iterator): Don't reference tip_frame in a build
766 --without-x. (Bug#11742)
767
c20fdd9e
PE
7682012-07-27 Paul Eggert <eggert@cs.ucla.edu>
769
770 Adjust GDB to reflect pvec_type changes (Bug#12036).
771 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
772 2012-07-04 changes to pseudovector representation. Problem
773 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
774
32770973 7752012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
776
777 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
778 bus address.
779 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
780
3438fe21
EZ
7812012-07-27 Eli Zaretskii <eliz@gnu.org>
782
bcfbc9de
EZ
783 * alloc.c (listn): Fix the order the arguments are consed onto the
784 list.
785
3438fe21
EZ
786 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
787 enumeration constants, as PURE and HEAP are too general, and clash
788 with other headers and sources, such as gmalloc.c and the
789 MS-Windows system headers. All users changed.
790
eeaea515
DA
7912012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
792
793 Revert last save_excursion_save and save_excursion_restore changes.
794 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
795 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
796
073c88c2
DA
7972012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
798
799 Fix recently-introduced typos in Windows port.
800 Reported by Martin Rudalics <rudalics@gmx.at>.
801 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 802 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 803
4706125e
PE
8042012-07-27 Paul Eggert <eggert@cs.ucla.edu>
805
806 Improve GDB symbol export (Bug#12036).
807 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
808 arms of an 'if', not using conditional expressions; otherwise GDB
809 complains about the types in the unevaluated arm when the argument
810 is an integer literal.
811 (xgetint): Simplify expression.
812 * alloc.c (gdb_make_enums_visible): New constant. This ports to
813 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
814 Zaretskii in <http://bugs.gnu.org/12036#13>.
815 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
816 needed now that we have gdb_make_enums_visible.
817 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
818 (enum enum_USE_LSB_TAG):
819 New enum types, packaging up enums that need to be exported to GDB.
820
694b6c97
DA
8212012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
822
823 Utility function to make a list from specified amount of objects.
824 * lisp.h (enum constype): New datatype.
825 (listn): New prototype.
826 * alloc.c (listn): New function.
827 (Fmemory_use_count, syms_of_alloc): Use it.
828 * buffer.c (syms_of_buffer): Likewise.
829 * callint.c (syms_of_callint): Likewise.
830 * charset.c (define_charset_internal): Likewise.
831 * coding.c (syms_of_coding): Likewise.
832 * keymap.c (syms_of_keymap): Likewise.
833 * search.c (syms_of_search): Likewise.
834 * syntax.c (syms_of_syntax): Likewise.
835 * w32.c (init_environment): Likewise.
836 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
837 * xdisp.c (syms_of_xdisp): Likewise.
838 * xfns.c (syms_of_xfns): Likewise.
839
6195f384
DA
8402012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
841
842 Fast save_excursion_save and save_excursion_restore.
843 * lisp.h (struct Lisp_Excursion): New data type.
844 (PVEC_EXCURSION): New pseudovector type.
845 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
846 to deal with it. Adjust comments.
847 (init_marker, attach_marker): New prototype.
848 (unchain_marker): Adjust prototype.
849 * marker.c (attach_marker): Change to global.
850 (init_marker): New function.
851 * alloc.c (Fmake_marker, build_marker): Use it.
852 (build_marker): More easserts.
853 (mark_object): Handle struct Lisp_Excursion.
854 * editfns.c (save_excursion_save, save_excursion_restore):
855 Reimplement to use struct Lisp_Excursion. Add comments.
856
5eceb8fb
PE
8572012-07-26 Paul Eggert <eggert@cs.ucla.edu>
858
859 Fix export of symbols to GDB (Bug#12036).
860 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
861 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
862 emacs.c, as this is a more-suitable home. Had this been done earlier
863 the fix for 12036 would have avoided some of the problems noted in
864 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
865 would have been more obvious.
562157c8
PE
866 * emacs.c: Do not include <verify.h>; no longer needed.
867 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
868 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
869 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
870 Remove; now done in lisp.h.
871 * lisp.h (PUBLISH_TO_GDB): New macro.
872 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
873 (DATA_SEG_BITS): Use it.
874 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
875 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
876 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
877 not be usable in #if. This simplifies things.
878
d6749401
JB
8792012-07-26 Juanma Barranquero <lekktu@gmail.com>
880
881 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
882
1781b9e9
PE
8832012-07-26 Paul Eggert <eggert@cs.ucla.edu>
884
d89518db 885 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
886 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
887 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
888 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
889 Adjust to changes in lisp.h and emacs.c, by using
890 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
891 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
892 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
893 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
894 instead of gdb_valbits.
895 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
896 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
897 instead of gdb_array_mark_flag.
898 (xboolvector): Get size from $->size, not $->header.size.
899 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
900 (xreload, hook-run, hookpost-run): Remove.
901 * emacs.c: Include <verify.h>.
902 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
903 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
904 Remove.
905 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
906 (gdb_USE_LSB_TAG): New enum constants.
907 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
908 Also define these as enum constants, so they're visible to GDB.
909 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
910 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
911 as constants, so they're visible to GDB.
912 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
913 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
914 Now enum constants, not macros, so they're visible to GDB.
915 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
916 more convenient now. All uses changed.
917 (VALMASK) [USE_LSB_TAG]: Also define in this case.
918 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
919
3628596a
DA
9202012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
921
922 Explicitly free restriction data that are not needed anymore.
923 * editfns.c (save_restriction_restore): Free restriction data.
924
7abaf5cc
SM
9252012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
926
927 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
928 add argument, tune behavior, and adjust all callers.
929
71f88e00
PE
9302012-07-25 Paul Eggert <eggert@cs.ucla.edu>
931
932 Use typedef for EMACS_INT, EMACS_UINT.
933 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
934 than macros. This simplifies debugging in the usual case, since
935 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
936 and it allows expressions involving EMACS_INT casts.
937 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
938
57ec3034
JD
9392012-07-25 Jan Djärv <jan.h.d@swipnet.se>
940
941 * nsterm.m (ns_read_socket): Return early if there is a modal
942 window (Bug#12043).
943
8137e7b3
MR
9442012-07-25 Martin Rudalics <rudalics@gmx.at>
945
946 * frame.c (Fredirect_frame_focus): In doc-string don't mention
947 that FOCUS-FRAME can be omitted.
948
04e9897c
DA
9492012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
950
951 Adjust buffer text indirection counters at the end of Fkill_buffer.
952 * buffer.c (Fkill_buffer): Adjust indirection counters when the
953 buffer is definitely dead. This should really fix an issue reported
954 by Christoph Scholtes again. (Bug#12007).
955 (init_buffer_once): Initialize indirection counters of
956 buffer_defaults and buffer_local_symbols (for sanity and safety).
957
8a0484e1
EZ
9582012-07-24 Eli Zaretskii <eliz@gnu.org>
959
960 * xdisp.c (init_iterator): Don't compute dimensions of truncation
961 and continuation glyphs on tooltip frames, leave them at zero.
962 Avoids continued lines in tooltips. (Bug#11832)
963
fa691a83
DA
9642012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
965
966 Simplify copy_overlay.
04e9897c 967 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
968 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
969
436bc8e0
EZ
9702012-07-23 Eli Zaretskii <eliz@gnu.org>
971
972 * print.c (print_object): Don't crash when a frame's name is nil
973 or invalid. (Bug#12025)
974
975 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
976 it signals an error when a tooltip frame is being created.
977
d7a7fda3
DA
9782012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
979
980 Cleanup miscellaneous objects allocation and initialization.
981 * alloc.c (allocate_misc): Change to static. Add argument to
982 specify the subtype. Adjust comment and users.
983 (build_overlay): New function.
984 * buffer.c (copy_overlays, Fmake_overlay): Use it.
985 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
986 (allocate_misc): Remove prototype.
987 (build_overlay): Add prototype.
988
9892012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
990
991 Swap buffer text indirection counters in Fbuffer_swap_text.
992 * buffer.c (Fbuffer_swap_text): Swap indirections too.
993 This avoids crash reported by Christoph Scholtes at
994 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
995
9d7fa573
JD
9962012-07-22 Jan Djärv <jan.h.d@swipnet.se>
997
998 * nsmenu.m (Popdown_data): New struct.
999 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1000 free Popdown_data.
1001 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1002 (initWithContentRect): Make imgView and contentView non-static
1003 and autorelease them. Also autorelease img and matrix (Bug#12005).
1004 (dealloc): Remove (Bug#12005).
1005
0dd6d66d
DA
10062012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1007
1008 Adjust consing_since_gc when objects are explicitly freed.
1009 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1010 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1011 (free_cons, free_misc): Subtract object size from consing_since_gc.
1012
d36d71df
DA
10132012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1014
1015 Simplify and cleanup markers positioning code.
1016 * marker.c (attach_marker): More useful eassert.
1017 (live_buffer, set_marker_internal): New function.
1018 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1019 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1020
fb9ea40f
PE
10212012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1024 as it's limited by the amount of memory, not by INT_MAX.
1025
2d5c5f7d
EZ
10262012-07-21 Eli Zaretskii <eliz@gnu.org>
1027
07fb592e
EZ
1028 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1029 in special-event-map. See the discussion at
1030 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1031 for the reasons.
1032
37a9eac8 1033 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
1034 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
1035 Fabrice Popineau <fabrice.popineau@supelec.fr>.
1036
c4328746
JD
10372012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1038
1039 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1040 (conversationIdentifier): Return value is NSInteger.
784051c4 1041 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1042
6e5d1c12
CY
10432012-07-21 Chong Yidong <cyd@gnu.org>
1044
1045 * window.c (decode_any_window): Signal an error if the window is
1046 on a dead frame (Bug#11984).
1047
9928463d
DA
10482012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1049
1050 Add indirection counting to speed up Fkill_buffer.
1051 * buffer.h (struct buffer): New member.
1052 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1053 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1054 base buffer indirection counter.
1055 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1056 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1057 through buffer list if indirection counter is 0.
1058
f8643a6b
DA
10592012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1060
1061 Extend the value returned by Fgarbage_collect with heap statistics.
1062 * alloc.c (Qheap): New symbol.
1063 (syms_of_alloc): DEFSYM it.
1064 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1065 (Fmemory_free): Remove.
1066 (syms_of_alloc): Don't defsubr it.
1067 * buffer.c (Fcompact_buffer): Remove.
1068 (syms_of_buffer): Don't defsubr it.
1069
dac616ff
DA
10702012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1071
1072 Make maybe_gc inline.
1073 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1074 * lisp.h (consing_since_gc, gc_relative_threshold)
1075 (memory_full_cons_threshold): Revert declaration.
1076 (maybe_gc): Remove prototype, define as inline.
1077 * alloc.c: Remove old commented-out code.
1078 (consing_since_gc, gc_relative_threshold)
1079 (memory_full_cons_threshold): Revert to global.
1080 (maybe_gc): Remove.
1081
d7ea76b4
DA
10822012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1083
1084 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1085 * lisp.h (build_unibyte_string): New function.
1086 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1087 * sysdep.c, w32fns.c, xfns.c: Use it.
1088 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1089 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1090 Adjust users accordingly.
1091 * font.h (font_open_by_name): Adjust prototype.
1092
765e61e3
DA
10932012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1094
1095 Cleanup calls to Fgarbage_collect.
1096 * lisp.h (maybe_gc): New prototype.
1097 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1098 Remove declarations.
1099 * alloc.c (maybe_gc): New function.
1100 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1101 Make them static.
1102 * bytecode.c (MAYBE_GC): Use maybe_gc.
1103 * eval.c (eval_sub, Ffuncall): Likewise.
1104 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1105 to avoid dependency from auto-save feature.
1106
52b852c7
PE
11072012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1108
1109 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1110 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1111 'for_each_per_buffer_object_at'.
1112 All uses changed. It's better to use upper-case for macros that
1113 cannot be implemented as functions, to give the reader a clue
1114 that they're special.
1115
5db81e33
SM
11162012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1117
1118 * alloc.c (Fgarbage_collect): Tweak docstring.
1119
5b835e1d
DA
11202012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1121
1122 Tweak the value returned from Fgarbage_collect again.
1123 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1124 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1125 Adjust documentation.
1126 (total_vector_bytes): Rename to total_vector_slots, adjust
1127 accounting.
1128 (total_free_vector_bytes): Rename to total_free_vector_slots,
1129 adjust accounting.
1130 (Qstring_bytes, Qvector_slots): New symbols.
1131 (syms_of_alloc): DEFSYM them.
1132
9cd47b72
DA
11332012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1134
1135 Buffer compaction primitive which may be used from Lisp.
1136 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1137 (syms_of_buffer): Register Fcompact_buffer.
1138 * alloc.c (Fgarbage_collect): Use compact_buffer.
1139 * buffer.h (compact_buffer): New prototype.
1140 (struct buffer_text): New member.
1141
d17337e5
DA
11422012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1143
1144 New macro to iterate over all buffers, miscellaneous cleanups.
1145 * lisp.h (all_buffers): Remove declaration.
1146 * buffer.h (all_buffers): Add declaration, with comment.
1147 (for_each_buffer): New macro.
1148 * alloc.c (Fgarbage_collect, mark_object): Use it.
1149 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1150 (init_buffer): Likewise.
1151 * data.c (Fset_default): Likewise.
1152 * coding.c (code_conversion_restore): Remove redundant check
1153 for dead buffer.
1154 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1155
60cfd278
AS
11562012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1157
1158 Fix bug that created negative-length intervals.
1159 * intervals.c (merge_interval_right, merge_interval_left):
1160 Do not zero out this interval if it is absorbed by its children,
1161 as this interval's total length doesn't change in that case. See
1162 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1163
d06714cb
PE
11642012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1165
83713154
PE
1166 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1167 when invoking (make-bool-vector N t) and N is a positive
1168 multiple of 8 -- the last 8 bits were mistakenly cleared.
1169
d06714cb
PE
1170 Remove some struct layout assumptions in bool vectors.
1171 * alloc.c (bool_header_size): New constant.
1172 (header_size, word_size): Move earlier, as they're now used earlier.
1173 Use 'word_size' in a few more places, where it's appropriate.
1174 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1175 padding before the data member of a bool vector.
1176 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1177 than doing the check by hand with an abort ().
1178
464d5a5e
SM
11792012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1180
5fbc0409
SM
1181 * eval.c (Fdefvar): Don't check constants since we only set the var if
1182 it's not yet defined anyway (bug#11904).
1183
464d5a5e
SM
1184 * lisp.h (last_undo_boundary): Declare new var.
1185 * keyboard.c (command_loop_1): Set it.
1186 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1187 were auto-added by the command loop (bug#11774).
1188
8dc2e44a
AS
11892012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1190
1191 * w32font.c (Qsymbol): Remove local definition.
1192 (syms_of_w32font): Don't DEFSYM it.
1193
169925ec
DA
11942012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1195
1196 Fix sweep_vectors to handle large bool vectors correctly.
1197 * alloc.c (sweep_vectors): Account total_vector_bytes for
1198 bool vectors larger than VBLOCK_BYTES_MAX.
1199
5fbfb018
CY
12002012-07-18 Chong Yidong <cyd@gnu.org>
1201
1202 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1203 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1204
3ab6e069
DA
12052012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1206
1207 Return more descriptive data from Fgarbage_collect.
1208 Suggested by Stefan Monnier in
1209 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1210 * alloc.c (bounded_number): New function.
1211 (total_buffers, total_vectors): New variable.
1212 (total_string_size): Rename to total_string_bytes, adjust users.
1213 (total_vector_size): Rename to total_vector_bytes, adjust users.
1214 (sweep_vectors): Account total_vectors and total_vector_bytes.
1215 (Fgarbage_collect): New return value. Adjust documentation.
1216 (gc_sweep): Account total_buffers.
1217 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1218 (VECTOR_SIZE): Remove.
1219 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1220 (Qinterval, Qmisc): New symbols.
1221 (syms_of_data): Initialize them.
1222 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1223 (Qcons, Qbuffer): New declarations.
1224
6d02fe5b
PE
12252012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1226
1227 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1228 Round up, not down. Improve doc.
1229
b7ffe040
DA
12302012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1231
1232 Restore old code in allocate_string_data to avoid Faset breakage.
1233 Reported by Julien Danjou <julien@danjou.info> in
1234 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1235 * alloc.c (allocate_string_data): Restore old code with minor
1236 adjustments, fix comment to explain this subtle issue.
1237
4dc7c8d5
SM
12382012-07-17 Eli Zaretskii <eliz@gnu.org>
1239
1240 Remove FILE_SYSTEM_CASE.
1241 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1242
1243 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1244 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1245 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1246 call-process-region passes it through expand-file-name.
1247
1248 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1249
12502012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1251
1252 Fix crash when creating indirect buffer (Bug#11917)
1253 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1254 Don't handle unbound variables specially if non-zero.
1255 (Fbuffer_local_variables): Pass zero.
1256 (clone_per_buffer_values): Pass non-zero.
1257
12582012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1259
1260 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1261 to make the loop interruptible.
1262
12632012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1264
1265 * gnutls.c (emacs_gnutls_handshake): Only retry if
1266 GNUTLS_E_INTERRUPTED.
1267
cce7fefc
DA
12682012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1269
1270 Cleanup and convert miscellaneous checks to eassert.
1271 * alloc.c (mark_interval): Fix comment, partially rephrase
1272 old comment from intervals.h (see below).
1273 * intervals.c (find_interval, adjust_intervals_for_insertion)
1274 (delete_interval, adjust_intervals_for_deletion)
1275 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1276 Convert to eassert.
1277 (adjust_intervals_for_insertion, make_new_interval):
1278 Remove obsolete and unused code.
1279 * intervals.h (struct interval): Remove obsolete comment.
1280 * textprotp.c (erase_properties): Remove unused code.
1281 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1282 (Fremove_list_of_text_properties): Convert to eassert.
1283
9ea10cc3
CY
12842012-07-17 Chong Yidong <cyd@gnu.org>
1285
1286 * editfns.c (Finsert_char): Doc fix.
1287
3900d5de
DA
12882012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1289
1290 Fix previous change to make Fmemory_free always accurate.
1291 * alloc.c (make_interval): Update total_free_intervals.
1292 (make_float): Likewise for total_free_floats.
1293 (free_cons, Fcons): Likewise for total_free_conses.
1294 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1295 Likewise for total_free_vector_bytes.
1296 (Fmake_symbol): Likewise for total_free_symbols.
1297 (bytes_free): Remove.
1298
7098646f
DA
12992012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1300
1301 Simple free memory accounting feature.
1302 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1303 (sweep_vectors): Accumulate size of free vectors.
1304 (Fgarbage_collect): Setup bytes_free.
1305 (Fmemory_free): New function.
1306 (syms_of_alloc): Register it.
1307
22657b40
DA
13082012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1309
1310 Cleanup overlays checking.
1311 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1312 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1313 eassert and OVERLAYP.
1314 (sort_overlays): Change to use OVERLAYP.
1315
ddfc8813
RK
13162012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1317
1318 * editfns.c (Finsert_char): Make it interactive, and make the
1319 second arg optional. Copy interactive spec and docstring from
1320 ucs-insert.
1321
7c26cf3c
PE
13222012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1323
1324 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1325 Unlike the other wrapped functions, fabs has an unspecified
1326 effect on errno.
1327
5d127af9
JD
13282012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1329
1330 * nsterm.m (keyDown): Interpret flags without left/right bits
1331 as the left key (Bug#11670).
1332
6a0dd1d7
DA
13332012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1334
1335 Remove empty and useless init functions.
1336 * lisp.h (init_character_once, init_fns, init_image)
1337 (init_filelock, init_sound): Remove prototype.
1338 * character.c (init_character_once): Remove.
1339 * filelock.c (init_filelock): Likewise.
1340 * fns.c (init_fns): Likewise.
1341 * image.c (init_image): Likewise.
1342 * sound.c (init_sound): Likewise.
1343 * emacs.c (main): Adjust accordingly.
1344
7a6136fd
DA
13452012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1346
1347 * gtkutil.h: Tiny cleanups.
1348 (use_old_gtk_file_dialog): Remove useless declaration.
1349 (xg_uses_old_file_dialog): Add suggested const attribute.
1350
ce811ad9
EZ
13512012-07-15 Eli Zaretskii <eliz@gnu.org>
1352
1353 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1354 (bidi_paragraph_init): Use it to limit search forward for a strong
1355 directional character in abnormally large paragraphs full of
1356 neutral or weak characters. (Bug#11943)
1357
c9adfeaa
SF
13582012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1359
1360 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1361 the toolbar (Bug#9451).
1362 (xg_make_tool_item): Give the widget event box a transparent
1363 background.
1364
fff62aa9
DA
13652012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1366
1367 Cleanup basic allocation variables and functions.
1368 * alloc.c (ignore_warnings, init_intervals, init_float)
1369 (init_cons, init_symbol, init_marker): Remove.
1370 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1371 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1372 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1373 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1374 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1375 (staticidx, init_alloc_once, init_strings, free_ablock):
1376 Remove redundant initialization.
1377 * fns.c (init_weak_hash_tables): Remove.
1378 * lisp.h (init_weak_hash_tables): Remove prototype.
1379
9730daca
DA
13802012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1381
1382 Use zero_vector where appropriate.
1383 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1384 accordingly.
1385 * lisp.h (zero_vector): New declaration.
1386 * font.c (null_vector): Remove.
1387 (syms_of_font): Remove initialization and staticpro.
1388 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1389 * keymap.c (Faccessible_keymaps): Likewise.
1390
2e2d2a13
LL
13912012-07-15 Leo Liu <sdl.web@gmail.com>
1392
1393 * fringe.c: Fix typo in comments.
1394
cd276f6e
LL
13952012-07-14 Leo Liu <sdl.web@gmail.com>
1396
1397 * fringe.c: Add a new bitmap exclamation-mark.
1398
5a1131d9
EZ
13992012-07-14 Eli Zaretskii <eliz@gnu.org>
1400
1401 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1402
1403 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1404 (HAVE_MENUS): Don't define, defined by editing config.in with
1405 msdos/sed2v2.inp.
1406 (GMALLOC_INHIBIT_VALLOC): Don't define.
1407 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1408
22e983b7
JB
14092012-07-14 Juanma Barranquero <lekktu@gmail.com>
1410
1411 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1412
5b3f250f
GM
14132012-07-14 Glenn Morris <rgm@gnu.org>
1414
1415 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1416 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1417 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1418
33d63ff4
GM
14192012-07-13 Glenn Morris <rgm@gnu.org>
1420
5b633342
GM
1421 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1422
33d63ff4
GM
1423 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1424 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1425
b55b9f85
JD
14262012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1427
0dc8cf50
JD
1428 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1429 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1430 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1431 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1432 where appropriate.
1433 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1434 as boolean expression.
1435 (x_set_window_size): Remove unused variable toolbar.
1436 (ns_get_color_default, ns_mod_to_lisp): Remove.
1437 (ns_mouse_position): Remove unused variables xchar and ychar.
1438 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1439 (ns_set_vertical_scroll_bar): Remove unused variable count.
1440 (ns_delete_terminal): Remove unused variable i.
1441 (ns_term_init): Remove unused variables r, g and b.
1442 (mouseDown): Remove unused variable window.
1443 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1444 (initFrameFromEmacs): Remove unused variable vbextra.
1445 (mouseEntered): Remove unused variables p and dpyinfo.
1446 (mouseExited): Remove unused variables p and r.
1447 (ns_define_frame_cursor, ns_clear_frame_area)
1448 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1449 (menuDown): Assign [sender tag] to variable and cast the variable.
1450
1451 * nsterm.h (menuDown): Add id as type to argument sender.
1452 (ns_display_info_for_name): Add Lisp_Object argument.
1453 (ns_term_init): Add Lisp_Object argument.
1454 (ns_map_event_to_object): Add void argument.
1455 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1456 prototype with arguments and only declare if __OBJC__.
1457 (nxatoms_of_nsselect): Add void argument.
1458 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1459 (ns_alloc_autorelease_pool): Add void argument.
1460 (ns_release_autorelease_pool): Add void* argument.
1461 (ns_get_defaults_value): Add const char* argument.
1462
1463 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1464 (initFromContents): Use SSDATA where appropriate.
1465 (ns_update_menubar): Add braces to ambigous if-else.
1466 (initWithTitle): Put () around assignment in if statement.
1467 (ns_menu_show): Remove unused variables window and keymap.
1468 (update_frame_tool_bar): Remove unused variable selected_p.
1469 (initWithContentRect): Remove unused variable this_cmd_name.
1470
1471 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1472 appropriate.
1473 (setXBMColor): Remove unused variable len.
1474 (setPixmapData): Put () around assignment in loop statement.
1475
1476 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1477 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1478 where appropriate.
1479 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1480 around assignment in loop statement.
1481 (nsfont_open): Remove unused variable i.
1482 (nsfont_open): Remove unused variable len.
1483 (nsfont_draw): Remove unused variable cs.
1484
1485 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1486 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1487 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1488 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1489 (Fns_font_name, Fns_perform_service)
1490 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1491 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1492 (ns_set_name): Remove unused variable view.
1493 (x_set_menu_bar_lines): Remove unused variable olines.
1494 (x_set_tool_bar_lines): Remove unused variable root_window.
1495 (Fns_list_colors): Put () around assignment in while statement.
1496 (Fns_perform_service): Remove unused variable len.
1497 (Fns_display_usable_bounds): Remove unused variable top.
1498 (syms_of_nsfns): Remove unused variable i.
1499
b55b9f85
JD
1500 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1501 memcpy (Bug#11907).
1502
ed9265fc 15032012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1504
1505 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1506 and free it with DestroyExceptionInfo (Bug#11558).
1507
ef099b57
JB
15082012-07-13 Juanma Barranquero <lekktu@gmail.com>
1509
1510 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1511 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1512 Set here, not in nt/config.nt.
1513
ea814a5d
EZ
15142012-07-13 Eli Zaretskii <eliz@gnu.org>
1515
1516 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1517 cursor overflow into the last glyph on display line when the right
1518 fringe is off. (Bug#11832)
1519
1a952767
PE
15202012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1521
1522 * xdisp.c (produce_special_glyphs): Now static.
1523 * dispextern.h (produce_special_glyphs): Remove decl.
1524
983188fd
GM
15252012-07-13 Glenn Morris <rgm@gnu.org>
1526
8d7c7eed 1527 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1528 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1529
983188fd
GM
1530 * s/usg5-4-common.h (USG, USG5):
1531 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1532 * s/sol2-6.h (SOLARIS2):
1533 * s/irix6-5.h (IRIX6_5):
1534 * s/hpux10-20.h (USG, USG5, HPUX):
1535 * s/gnu-linux.h (USG, GNU_LINUX):
1536 * s/freebsd.h (BSD_SYSTEM):
1537 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1538 * s/cygwin.h (CYGWIN):
1539 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1540 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1541
d1e68667 15422012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1543
1544 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1545
6de0e799
GM
15462012-07-13 Glenn Morris <rgm@gnu.org>
1547
739ae010
GM
1548 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1549
dbee5793
GM
1550 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1551
6de0e799
GM
1552 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1553 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1554
b82da769
GM
15552012-07-12 Glenn Morris <rgm@gnu.org>
1556
4fae5a7a 1557 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1558
1559 * process.c (init_process_emacs): Rename from init_process.
1560 The old name is also the name of a Mach system call.
1561 * lisp.h, emacs.c: Update for this name change.
1562 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1563 longer needed.
1564
5a979817
EZ
15652012-07-12 Eli Zaretskii <eliz@gnu.org>
1566
1567 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1568 memmove call that removes glyphs covered by the left truncation
1569 glyph. Improve commentary.
1570 (display_line): Fix display of continuation glyphs on GUI frames
1571 when the right fringe is turned off and variable-size fonts are
1572 used in the window. Move the code that appends a stretch glyph to
1573 produce_special_glyphs, so that it could be used for truncation
1574 and continuation glyphs alike.
1575 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1576 glyph of a suitably computed width, to align the special glyphs at
1577 the window margin. Code moved from display_line. (Bug#11832)
1578
3e91a053
GM
15792012-07-12 Glenn Morris <rgm@gnu.org>
1580
ba9e4b84
GM
1581 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1582
1583 * s/gnu-linux.h, s/hpux10-20.h:
1584 Do not unconditionally define HAVE_XRMSETDATABASE.
1585
3e91a053
GM
1586 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1587
b300b1f4
PE
15882012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1589
1590 Fix typos that broke OS X build.
1591 Reported by Randal L. Schwartz in
1592 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1593 * nsterm.m (ns_timeout): Add missing local decl.
1594 (ns_get_color): snprintf -> sprintf, to fix typo.
1595
6e777848
GM
15962012-07-12 Glenn Morris <rgm@gnu.org>
1597
3f922c37
GM
1598 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1599 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1600 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1601 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1602
0ab7b23a
GM
1603 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1604 Move PTY_OPEN to configure.
1605
6e777848
GM
1606 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1607 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1608 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1609
4a7edc24
DA
16102012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1611
1612 Use empty_unibyte_string where applicable.
1613 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1614 * lread.c (read1): Likewise.
1615 * xsettings.c (syms_of_xsettings): Likewise.
1616
308aab79
GM
16172012-07-12 Glenn Morris <rgm@gnu.org>
1618
42bd1719
GM
1619 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1620 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1621 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1622 * s/hpux10-20.h (RUN_TIME_REMAP):
1623 * s/bsd-common.h (TABDLY): Move to configure.
1624
1625 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1626
1627 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1628
ea0bbd17 1629 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1630 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1631
1632 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1633
308aab79
GM
1634 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1635 * s/template.h: Move NARROWPROTO to configure.
1636
ee1cf5cf
GM
16372012-07-11 Glenn Morris <rgm@gnu.org>
1638
30fe9bf4
GM
1639 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1640 unused since 2011-01-17 change to systty.h.
1641
ee1cf5cf
GM
1642 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1643 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1644 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1645
63e47e07
PE
16462012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1647
1648 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1649
c43fb4c3
GM
16502012-07-11 Glenn Morris <rgm@gnu.org>
1651
1652 * s/darwin.h, s/gnu-linux.h, s/template.h:
1653 Move INTERRUPT_INPUT to configure.
1654
e8df9267
DA
16552012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1656
1657 Minor adjustments to interning code.
1658 * lisp.h (intern, intern_c_string): Redefine as static inline
1659 wrappers for intern_1 and intern_c_string_1, respectively.
1660 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1661 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1662 Vobarray checking.
e8df9267
DA
1663 * font.c (font_intern_prop): Likewise. Adjust comment.
1664 * w32font.c (intern_font_name): Likewise.
1665
34348bd4
AS
16662012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1667
d96a1e0c
AS
1668 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1669
34348bd4
AS
1670 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1671 of Fcar/Fcdr if possible.
1672 * font.c (check_otf_features): Likewise.
1673 * fontset.c (Fnew_fontset): Likewise.
1674 * gnutls.c (Fgnutls_boot): Likewise.
1675 * minibuf.c (read_minibuf): Likewise.
1676 * msdos.c (IT_set_frame_parameters): Likewise.
1677 * xmenu.c (Fx_popup_dialog): Likewise.
1678 * w32menu.c (Fx_popup_dialog): Likewise.
1679
c8add24e
GM
16802012-07-11 Glenn Morris <rgm@gnu.org>
1681
4b575b3c
GM
1682 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1683 since nothing has defined it on these platforms.
1684
09f4e3b0
GM
1685 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1686 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1687
172bedef
GM
1688 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1689 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1690 Move CLASH_DETECTION to configure.
1691
249685df
GM
1692 * s/gnu.h: Remove file, which is now empty.
1693
c8add24e
GM
1694 * s/gnu.h, s/gnu-linux.h:
1695 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1696
b41253a3
JW
16972012-07-11 John Wiegley <johnw@newartisans.com>
1698
1699 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1700 function attribute, so we only use it if it exists in the
1701 compiler.
1702
d923b542
DA
17032012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1704
1705 Avoid call to strlen in fast_c_string_match_ignore_case.
1706 * search.c (fast_c_string_match_ignore_case): Change to use
1707 length argument. Adjust users accordingly.
1708 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1709
5ebbef1d
PE
17102012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1711
bb352260
PE
1712 Assume mkdir, rmdir.
1713 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1714 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1715
57054ddd
PE
1716 Assume rename.
1717 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1718
b747d3f7
PE
1719 Assume perror.
1720 * s/hpux10-20.h (HAVE_PERROR): Remove.
1721 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1722 Remove dummy definition, as this problem was obsolete long ago.
1723
5ebbef1d
PE
1724 Assume strerror.
1725 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1726
984e7f30
DA
17272012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1728
1729 Avoid calls to strlen in font processing functions.
1730 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1731 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1732 users accordingly.
d923b542
DA
1733 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1734 Adjust prototypes.
1735 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1736 Change to return ptrdiff_t.
984e7f30
DA
1737 (xfont_list_pattern, xfont_match): Use length returned by
1738 xfont_decode_coding_xlfd.
1739 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1740
20e94fdd
GM
17412012-07-11 Glenn Morris <rgm@gnu.org>
1742
9d596af3
GM
1743 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1744 Move DONT_REOPEN_PTY to configure.
1745
20e94fdd
GM
1746 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1747 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1748
e99a530f
PE
17492012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1750
22ffb973
PE
1751 Remove "#define unix" that is no longer needed (Bug#11905).
1752 * s/aix4-2.h (unix): Remove; no longer needed.
1753
e9a9ae03
PE
1754 EMACS_TIME simplification (Bug#11875).
1755 This replaces macros (which typically do not work in GDB)
1756 with functions, typedefs and enums, making the code easier to debug.
1757 The functional style also makes code easier to read and maintain.
1758 * systime.h: Include <sys/time.h> on all hosts, not just if
1759 WINDOWSNT, since 'struct timeval' is needed in general.
1760 (EMACS_TIME): Now a typedef, not a macro.
1761 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1762 not macros.
1763 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1764 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1765 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1766 (EMACS_TIME_LE): Now functions, not macros.
1767 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1768 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1769 which are not functions. All uses rewritten to use:
1770 (make_emacs_time): New function.
1771 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1772 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1773 not functions. All uses rewritten to use the following, respectively:
1774 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1775 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1776 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1777 * fileio.c (Fcopy_file):
1778 * xterm.c (XTflash): Get the current time closer to when it's used.
1779 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1780
ffacb126
PE
1781 * bytecode.c (targets): Suppress -Woverride-init warnings.
1782
e99a530f
PE
1783 Simplify by avoiding confusing use of strncpy etc.
1784 * doc.c (Fsnarf_documentation):
1785 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1786 * frame.c (Fmake_terminal_frame):
1787 * gtkutil.c (get_utf8_string):
1788 * lread.c (openp):
1789 * nsmenu.m (ns_update_menubar):
1790 * regex.c (regerror):
1791 Prefer memcpy to strncpy and strncat when either will do.
1792 * fileio.c (Fsubstitute_in_file_name):
1793 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1794 (menu_separator_name_p):
1795 * nsmenu.m (ns_update_menubar):
1796 Prefer memcmp to strncmp when either will do.
1797 * nsterm.m: Include <ftoastr.h>.
1798 (ns_get_color):
1799 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1800 Prefer snprintf to strncpy.
1801 * nsterm.m (ns_term_init):
1802 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1803 * nsterm.m (ns_term_init):
1804 Avoid the need for strncpy, by using build_string or
1805 make_unibyte_string directly. Use dtoastr, not snprintf.
1806 * process.c (Fmake_network_process): Diagnose service names that
1807 are too long, rather than silently truncating them or creating
1808 non-null-terminated names.
1809 (Fnetwork_interface_info): Likewise, for interface names.
1810 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1811 Prefer sprintf to strncat.
1812 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1813 Prefer vsnprintf to vsprintf + strncpy.
1814
c59592b3
GM
18152012-07-10 Glenn Morris <rgm@gnu.org>
1816
1817 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1818 Clarify fallback case.
1819
7d7bbefd
DA
18202012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1821
1822 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1823 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1824 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1825 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1826 where argument type is known to be a Lisp_Cons.
1827
3a4c8000
TT
18282012-07-10 Tom Tromey <tromey@redhat.com>
1829
1830 * bytecode.c (BYTE_CODE_THREADED): New macro.
1831 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1832 (enum byte_code_op): New type.
1833 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1834 (exec_byte_code): Use them. Use token threading when applicable.
1835
2a0213a6
DA
18362012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1837
1838 Optimize pure C strings initialization.
1839 * lisp.h (make_pure_string): Fix prototype.
1840 (build_pure_c_string): New function, defined as static inline. This
1841 provides a better opportunity to optimize away calls to strlen when
1842 the function is called with compile-time constant argument.
1843 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1844 argument, adjust users accordingly. Use build_pure_c_string where
1845 appropriate.
1846 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1847 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1848 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1849
cb1caeaf
DA
18502012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1851
1852 Avoid calls to strlen in miscellaneous functions.
1853 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1854 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1855 * lread.c (openp): Likewise.
1856
c293e30c
DA
18572012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1858
1859 Avoid calls to strlen in path processing functions.
1860 * fileio.c (file_name_as_directory): Add comment. Change to add
1861 srclen argument and return the length of result. Adjust users
1862 accordingly.
1863 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1864 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1865 users accordingly.
1866 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1867
9e059e3f
GM
18682012-07-10 Glenn Morris <rgm@gnu.org>
1869
d02eb359
GM
1870 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1871 Move PENDING_OUTPUT_COUNT definition to configure.
1872
882cf227
GM
1873 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1874 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1875 * s/gnu.h (DATA_START): Move definitions to configure.
1876
af6e839f
GM
1877 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1878 We include usg5-4-common.h, which defines them both.
1879
40289a12
GM
1880 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1881 O_RDONLY already includes it).
1882
9e059e3f
GM
1883 Stop ns builds setting the EMACSLOADPATH environment variable.
1884 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1885 Now it does not set EMACSLOADPATH, just returns the load-path string.
1886 * nsterm.h: Update accordingly.
1887 * lread.c [HAVE_NS]: Include nsterm.h.
1888 (init_lread) [HAVE_NS]: Use ns_load_path.
1889 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1890
7c4e8ec0
GM
18912012-07-09 Glenn Morris <rgm@gnu.org>
1892
d4f600ff
GM
1893 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1894 since the included bsd-common.h does so.
1895
cbb31951
GM
1896 Stop ns builds setting the EMACSPATH environment variable.
1897 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1898 (ns_init_paths): Do not set EMACSPATH.
1899 * nsterm.h (ns_exec_path): Add it.
1900 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1901 Use ns_exec_path.
1902
7c4e8ec0
GM
1903 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1904
26bccfae
PE
19052012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1906
a0bee46f
PE
1907 * process.c (wait_reading_process_output): 'waitchannels' was unset
1908 when read_kbd || !NILP (wait_for_cell); fix this.
1909
5994c183
PE
1910 Add GCC-style 'const' attribute to functions that can use it.
1911 * character.h (char_resolve_modifier_mask):
1912 * keyboard.h (make_ctrl_char):
1913 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1914 (init_character_once, next_almost_prime, init_fns, init_image)
1915 (flush_pending_output, init_sound):
1916 * mem-limits.h (start_of_data):
1917 * menu.h (finish_menu_items):
1918 Add ATTRIBUTE_CONST.
1919 * emacs.c (DEFINE_DUMMY_FUNCTION):
1920 Declare the dummy function with ATTRIBUTE_CONST.
1921 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1922 Add decls with ATTRIBUTE_CONST.
1923
26bccfae
PE
1924 Minor improvements to make_formatted_string.
1925 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1926 where int is good enough, as vsprintf returns an int.
1927 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1928
a8290ec3
DA
19292012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1930
1931 Use make_formatted_string to avoid double length calculation.
1932 * lisp.h (make_formatted_string): New prototype.
1933 * alloc.c (make_formatted_string): New function.
1934 * buffer.c (Fgenerate_new_buffer_name): Use it.
1935 * dbus.c (syms_of_dbusbind): Likewise.
1936 * editfns.c (Fcurrent_time_zone): Likewise.
1937 * filelock.c (get_boot_time): Likewise.
1938 * frame.c (make_terminal_frame, set_term_frame_name)
1939 (x_report_frame_params): Likewise.
1940 * image.c (gs_load): Likewise.
1941 * minibuf.c (get_minibuffer): Likewise.
1942 * msdos.c (dos_set_window_size): Likewise.
1943 * process.c (make_process): Likewise.
1944 * xdisp.c (ensure_echo_area_buffers): Likewise.
1945 * xsettings.c (apply_xft_settings): Likewise.
1946
d01ba2f1
GM
19472012-07-09 Glenn Morris <rgm@gnu.org>
1948
1949 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1950 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1951 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1952 * nsterm.h (ns_etc_directory): Add it.
1953 * callproc.c [HAVE_NS]: Include nsterm.h.
1954 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1955
f1f924b6
DA
19562012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1957
1958 Move marker debugging code under MARKER_DEBUG.
1959 * marker.c (MARKER_DEBUG): Move marker debugging code under
1960 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1961 for bootstrap with --enable-checking (~3x slowdown reported
1962 by Juanma Barranquero <lekktu@gmail.com>).
1963 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1964
ab531b66
PE
19652012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1966
1967 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1968 See <http://bugs.gnu.org/11825#29>.
1969
c4b3bc8a
EZ
19702012-07-08 Eli Zaretskii <eliz@gnu.org>
1971
1972 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1973 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1974 (display_line): Add commentary about displaying truncation glyphs
1975 on GUI frames.
1976 (produce_special_glyphs): Move here from term.c.
1977
1978 * term.c (produce_special_glyphs): Move to xdisp.c.
1979
1980 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1981 section.
c4b3bc8a 1982
b676b881
AS
19832012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1984
f17c5273
AS
1985 * xdisp.c (display_line): Avoid warning about implicit declaration
1986 of FRAME_FONT.
1987
298819b9
AS
1988 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1989
b676b881
AS
1990 * lisp.h: Remove empty conditional.
1991
6045c4fd
PE
19922012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1993
b3350bf9
PE
1994 * lread.c (load_path_check): Now static.
1995
6045c4fd
PE
1996 Fix some minor --with-ns problems found by static checking.
1997 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1998 (x_set_font) [!HAVE_X_WINDOWS]:
1999 * image.c (xpm_load_image) [HAVE_NS]:
2000 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2001 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2002 Remove unused local.
2003 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2004 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2005 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2006 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2007 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2008 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2009 Fix pointer signedness problem.
2010 * xfaces.c (FRAME_X_FONT_TABLE):
2011 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2012
929e7845
GM
20132012-07-07 Glenn Morris <rgm@gnu.org>
2014
2015 * lread.c (load_path_check): New function, split from init_lread.
2016 (init_lread): Reorganize. Motivation:
2017 If EMACSLOADPATH is set, check/warn about that rather than the
2018 defaults, which we are not going to use. Hence we can remove
2019 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2020 Don't warn if site-lisp directories are missing.
2021 If not installed, start from a blank load-path, since
2022 PATH_LOADSEARCH refers to the eventual installation directories.
2023
58dd0aa4
EZ
20242012-07-07 Eli Zaretskii <eliz@gnu.org>
2025
2026 Support truncation and continuation glyphs on GUI frames, when
2027 fringes are disabled. (Bug#11832)
2028 * xdisp.c (init_iterator): Get dimensions of truncation and
2029 continuation glyphs even if on GUI frames. Adjust
2030 it->last_visible_x on GUI frames when the left or right fringes,
2031 or both, are absent.
2032 (start_display, move_it_in_display_line_to): Handle the case of a
2033 GUI frame without a fringe to display continuation or truncation
2034 glyphs.
2035 (insert_left_trunc_glyphs): Support GUI frames: make sure
2036 truncation glyphs overwrite enough glyphs from the current line to
2037 have sufficient space in pixels.
2038 (display_line): Support truncation and continuation glyphs on GUI
2039 frames. If some spare pixels are left on the line after inserting
2040 the truncation glyphs, fill that space with a stretch glyph of a
2041 suitably computed width.
2042
2043 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2044 produce_glyphs, to support GUI sessions.
2045
31571fd7
PE
20462012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2047
5a16b9bc
PE
2048 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2049
f3047c75
PE
2050 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2051
31571fd7
PE
2052 Do not require float-time's arg to fit in time_t (Bug#11825).
2053 This works better on hosts where time_t is unsigned, and where
2054 float-time is applied to the (negative) difference between two times.
2055 * editfns.c (decode_time_components): Last arg is now double *,
2056 not int *, and means to store all the result as a double, without
2057 worrying about whether the seconds part fits in time_t.
2058 All callers changed.
2059 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2060 All callers changed.
2061 (Ffloat_time): Do not fail merely because the specified time falls
2062 outside of time_t range.
2063
4516fbef
GM
20642012-07-07 Glenn Morris <rgm@gnu.org>
2065
2066 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2067 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2068 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2069
07adc2c6
JB
20702012-07-07 Juanma Barranquero <lekktu@gmail.com>
2071
2072 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2073 Update dependencies.
2074
2075 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2076
fd573f31
PE
20772012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2078
fee5959d
PE
2079 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2080 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2081 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2082 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2083 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2084 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2085
fd573f31
PE
2086 * xfont.c (compare_font_names): Redo to omit the need for casts.
2087
ddadbc0e
AS
20882012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2089
fca8d6b6
AS
2090 * xfns.c (Fx_change_window_property): Doc fix.
2091 * w32fns.c (Fx_change_window_property): Doc fix.
2092
ddadbc0e
AS
2093 * w32fns.c (Fx_window_property): Accept the same arguments as the
2094 X Windows version. Doc fix.
2095 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2096
ed9265fc 20972012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2098 Eli Zaretskii <eliz@gnu.org>
2099
2100 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2101 Windows-specific code from nt/config.nt moved here.
2102 Obsolete settings removed.
2103
216ee680
PE
21042012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2105
2106 * process.c: Avoid unnecessary calls to gettime.
2107 (wait_reading_process_output): Don't get the time of day
2108 when gobbling data immediately and not waiting, as there's no need
2109 for it in that case. This removes a FIXME.
2110
bdd091e4
JD
21112012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2112
2113 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2114 is defined (Bug#11768).
2115
9d44f8ce
DA
21162012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2117
2118 Fix marker debugging code.
2119 * marker.c (byte_char_debug_check): Do not perform the check
2120 if buffer is not multibyte.
090bd7cb
JB
2121 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2122 Call byte_char_debug_check with correct arguments.
9d44f8ce 2123
90fc4786
DA
21242012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2125
2126 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2127 * marker.c (byte_char_debug_check, count_markers):
2128 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2129 (byte_debug_flag): Remove.
2130 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2131 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2132
7b7ae965
DA
21332012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2134
4e57b342
DA
2135 Avoid code repetition in marker-related functions.
2136 * marker.c (attach_marker): New function.
2137 (Fset_marker, set_marker_restricted, set_marker_both)
2138 (set_marker_restricted_both): Use it.
2139 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2140 Consistently rename charno to charpos.
2141 (marker_position): Add eassert.
2142 (marker_byte_position): Convert to eassert.
2143
21442012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2145
2146 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2147 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2148 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2149
657924ff
DA
21502012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2151
2152 Introduce fast path for the widely used marker operation.
2153 * alloc.c (build_marker): New function.
2154 * lisp.h (build_marker): New prototype.
2155 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2156 * composite.c (autocmp_chars): Likewise.
2157 * editfns.c (buildmark): Remove.
2158 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2159 (save_restriction_save): Use build_marker.
2160 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2161 * window.c (save_window_save): Likewise.
2162
041a49a6
DA
21632012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2164
2165 Do not use Fdelete_overlay in delete_all_overlays
2166 to avoid redundant calls to unchain_overlay.
2167 * buffer.c (drop_overlay): New function.
2168 (delete_all_overlays, Fdelete_overlay): Use it.
2169 * minibuf.c (get_minibuffer): Fix comment.
2170
7dca65a4
PE
21712012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2172
2173 Port to OpenBSD 5.1 amd64.
2174 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2175 This is needed for OpenBSD, and should be harmless on all BSD systems.
2176 Also, include <sys/sysctl.h>, as it should be available on all
2177 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2178 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2179 use p_pid member, not kp_proc.pid.
2180
8eb876e2
GM
21812012-07-06 Glenn Morris <rgm@gnu.org>
2182
2183 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2184
38182d90
PE
21852012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2186
2187 More xmalloc and related cleanup.
2188 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2189 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2190 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2191 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2192 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2193 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2194 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2195 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2196 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2197 * xterm.c:
2198 Omit needless casts involving void * pointers and allocation.
2199 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2200 as the former is more robust if P's type is changed.
2201 Prefer xzalloc to xmalloc + memset 0.
2202 Simplify malloc-or-realloc to realloc.
2203 Don't worry about xmalloc returning a null pointer.
2204 Prefer xstrdup to xmalloc + strcpy.
2205 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2206 growing it.
2207 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2208 alloca of a constant.
2209
6dd5a677
EZ
22102012-07-05 Eli Zaretskii <eliz@gnu.org>
2211
2212 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2213 hscroll is larger than the line width. Fixes long and futile
2214 looping inside extend_face_to_end_of_line (on a TTY) producing
2215 glyphs that are not needed and thrown away.
2216
6b312f0f
DA
22172012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2218
2219 * marker.c (set_marker_restricted_both): Simplify by using
2220 clip_to_bounds.
2221
f520ef9b
PE
22222012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2223
2224 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2225
383b7c95
JD
22262012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2227
2228 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2229 not defined (Bug#11768).
2230 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2231 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2232 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2233 followed by gtk_box_set_homogeneous (Bug#11768).
2234 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2235 (update_theme_scrollbar_width, xg_create_scroll_bar):
2236 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2237 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2238 (is_box_type): New function (Bug#11768).
2239 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2240 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2241 with default display (Bug#11768).
2242
d6e7bf45
EZ
22432012-07-05 Eli Zaretskii <eliz@gnu.org>
2244
2245 * xdisp.c (window_hscroll_limited): New function.
2246 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2247 coordinates when window's hscroll is set to insanely large
2248 values. (Bug#11857)
2249
431391ec
JB
22502012-07-05 Juanma Barranquero <lekktu@gmail.com>
2251
2252 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2253 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2254
23f86fce
DA
22552012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2256
2257 Cleanup xmalloc.
2258 * lisp.h (xzalloc): New prototype. Omit needless casts.
2259 * alloc.c (xzalloc): New function. Omit needless casts.
2260 * charset.c: Omit needless casts. Convert all calls to
2261 xmalloc with following memset to xzalloc.
2262 * dispnew.c: Likewise.
2263 * fringe.c: Likewise.
2264 * image.c: Likewise.
2265 * sound.c: Likewise.
2266 * term.c: Likewise.
2267 * w32fns.c: Likewise.
2268 * w32font.c: Likewise.
2269 * w32term.c: Likewise.
2270 * xfaces.c: Likewise.
2271 * xfns.c: Likewise.
2272 * xterm.c: Likewise.
2273 * atimer.c: Omit needless casts.
2274 * buffer.c: Likewise.
2275 * callproc.c: Likewise.
2276 * ccl.c: Likewise.
2277 * coding.c: Likewise.
2278 * composite.c: Likewise.
2279 * doc.c: Likewise.
2280 * doprnt.c: Likewise.
2281 * editfns.c: Likewise.
2282 * emacs.c: Likewise.
2283 * eval.c: Likewise.
2284 * filelock.c: Likewise.
2285 * fns.c: Likewise.
2286 * gtkutil.c: Likewise.
2287 * keyboard.c: Likewise.
2288 * lisp.h: Likewise.
2289 * lread.c: Likewise.
2290 * minibuf.c: Likewise.
2291 * msdos.c: Likewise.
2292 * print.c: Likewise.
2293 * process.c: Likewise.
2294 * region-cache.c: Likewise.
2295 * search.c: Likewise.
2296 * sysdep.c: Likewise.
2297 * termcap.c: Likewise.
2298 * terminal.c: Likewise.
2299 * tparam.c: Likewise.
2300 * w16select.c: Likewise.
2301 * w32.c: Likewise.
2302 * w32reg.c: Likewise.
2303 * w32select.c: Likewise.
2304 * w32uniscribe.c: Likewise.
2305 * widget.c: Likewise.
2306 * xdisp.c: Likewise.
2307 * xmenu.c: Likewise.
2308 * xrdb.c: Likewise.
2309 * xselect.c: Likewise.
2310
0497dc44
PE
23112012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2312
2313 * fileio.c (time_error_value): Check the right error number.
2314 Problem reported by Troels Nielsen in
2315 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2316
356e7178
PE
23172012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2318
4e71fd89
PE
2319 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2320 This should be fixed in a better way; see Eli Zaretskii in
2321 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2322 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2323
f0941253
PE
2324 * fileio.c (time_error_value): Rename from special_mtime.
2325 The old name's problems were noted by Eli Zaretskii in
2326 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2327
065c9eb4
PE
2328 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2329 This variable's comment says Emacs needs at least one GDB-visible
2330 symbol of type enum pvec_type, to work around GDB problems.
2331 The symbol's value doesn't matter.
2332
356e7178
PE
2333 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2334 that causes compilation to fail on pre-C99 compilers.
2335
ed9265fc 23362012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2337
2338 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2339 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2340
3884d954
DA
23412012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2342
d209e2fb 2343 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2344 headers for buffer_defaults and buffer_local_symbols.
2345 Reported by Juanma Barranquero <lekktu@gmail.com>.
2346
ee28be33
SM
23472012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2348
2349 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2350 * lisp.h (enum pvec_type): Use fewer bits.
2351 (PSEUDOVECTOR_SIZE_BITS): New constant.
2352 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2353 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2354 change in pvec_type.
2355 (PSEUDOVECTOR_TYPEP): New macro.
2356 (TYPED_PSEUDOVECTORP): Use it.
2357 * fns.c (internal_equal): Adapt code to extract pvectype.
2358 * emacs.c (gdb_pvec_type): Update type.
2359 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2360 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2361 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2362 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2363 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2364 abusing vector->header.next.nbytes.
2365 (live_vector_p): Use PVEC_TYPE.
2366 (mark_object): Adapt code to extract pvectype. Use switch.
2367
c7f2cd7f
PE
23682012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2369
2370 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2371 Tighten new eassert a bit.
2372
8ce70ed2
DA
23732012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2374
2375 Fix compilation with --enable-gcc-warnings and -O1
2376 optimization level.
2377 * doprnt.c (doprnt): Change type of tem to int, initialize
2378 to avoid compiler warning. Add eassert.
2379 * search.c (simple_search): Initialize match_byte to avoid
2380 compiler warning. Add eassert.
2381
dea7f1e5
PE
23822012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2383
24a212eb
PE
2384 Avoid weird behavior with large horizontal scrolls.
2385 Without this change, for example, large hscroll values would
2386 mess up Emacs's display on Fedora 15 x86, presumably due to
2387 overflows in int calculations in the display code.
2388 Also, if buffers had long lines, Emacs would freeze.
2389 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2390 (set_window_hscroll): New function, containing the old guts of
2391 Fset_window_hscroll. Return the clipped value.
2392 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2393 This avoids the need to check against PTRDIFF_MAX.
2394
dea7f1e5
PE
2395 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2396
76046526
DA
23972012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2398
2399 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2400
39adff0d
PE
24012012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2402
63807d47
PE
2403 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2404 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2405 since GCC 4.4.6 issues a bogus warning for them.
2406
39adff0d
PE
2407 Fix bugs in file timestamp newness comparisons.
2408 * fileio.c (Ffile_newer_than_file_p):
2409 * lread.c (Fload): Use full timestamp resolution of files,
2410 not just the 1-second resolution, so that files that are only
2411 slightly newer still count as newer.
2412 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2413 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2414
dbeed9a6
PE
24152012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 * fileio.c: Improve handling of file time marker. (Bug#11852)
2418 (special_mtime): New function.
2419 (Finsert_file_contents, Fverify_visited_file_modtime):
2420 Use it to set special mtime values consistently.
2421
636334d6
AS
24222012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2423
2424 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2425 marker for non-existing file. (Bug#11852)
2426
e2017fe2
GM
24272012-07-03 Glenn Morris <rgm@gnu.org>
2428
2429 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2430 and did not make it into globals.h).
2431
404dbd37
TT
24322012-07-03 Tom Tromey <tromey@redhat.com>
2433
2434 * window.c (Fset_window_margins, Fset_window_fringes)
2435 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2436 * textprop.c (Fprevious_property_change): No longer static.
2437 * syntax.c (Fsyntax_table_p): No longer static.
2438 * process.c (Fget_process, Fprocess_datagram_address): No longer
2439 static.
2440 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2441 * keyboard.c (Fcommand_execute): No longer static.
2442 Remove EXFUN.
2443 * insdel.c (Fcombine_after_change_execute): No longer static.
2444 * image.c (Finit_image_library): No longer static.
2445 * fileio.c (Fmake_symbolic_link): No longer static.
2446 * eval.c (Ffetch_bytecode): No longer static.
2447 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2448 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2449 No longer static.
404dbd37
TT
2450 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2451 static.
2452 * dired.c (Ffile_attributes): No longer static.
2453 * composite.c (Fcomposition_get_gstring): No longer static.
2454 * callproc.c (Fgetenv_internal): No longer static.
2455
2456 * ccl.h: Remove EXFUNs.
2457 * buffer.h: Remove EXFUNs.
2458 * dispextern.h: Remove EXFUNs.
2459 * intervals.h: Remove EXFUNs.
2460 * fontset.h: Remove EXFUN.
2461 * font.h: Remove EXFUNs.
2462 * dosfns.c (system_process_attributes): Remove EXFUN.
2463 * keymap.h: Remove EXFUNs.
2464 * lisp.h: Remove EXFUNs.
2465 * w32term.h: Remove EXFUNs.
2466 * window.h: Remove EXFUNs.
2467 * xsettings.h: Remove EXFUN.
2468 * xterm.h: Remove EXFUN.
2469
8e4fd1e1
GM
24702012-07-03 Glenn Morris <rgm@gnu.org>
2471
2472 * lisp.h (Frandom): Make it visible to C.
2473 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2474 buffer for invisible buffers. (Bug#1229)
2475
ca95b3eb
DA
24762012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2477
2478 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2479 values which aren't power of 2.
2480 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2481 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2482 accordingly.
2483
7555c33f
SM
24842012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2485
2486 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2487
2488 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2489
d12e8f5a
DA
24902012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2491
2492 * alloc.c (allocate_vector_block): Remove redundant
2493 calls to mallopt if DOUG_LEA_MALLOC is defined.
2494 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2495 avoid calls to mallopt if zero_vector is returned.
2496
296094c3
DA
24972012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2498
2499 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2500 is enabled, avoid dereferencing NULL current_sblock if
2501 running undumped.
2502
36429c89
DA
25032012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2504
2505 Cleanup basic buffer management.
2506 * buffer.h (struct buffer): Change layout to use generic vector
2507 marking code. Fix some comments. Change type of 'clip_changed'
2508 to bitfield. Remove unused #ifndef old.
2509 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2510 (GET_OVERLAYS_AT): Fix indentation.
2511 (for_each_per_buffer_object_at): New macro.
2512 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2513 (Fbuffer_local_variables): Use it.
2514 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2515 * alloc.c (allocate_buffer): Adjust to match new layout of
2516 struct buffer. Fix comment.
2517 (mark_overlay): New function.
2518 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2519 Lisp area of struct buffer.
2520 (mark_object): Use it. Adjust marking of misc objects
2521 and related comments.
2522
3b3e4cac
PE
25232012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2524
2525 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2526 wrapper that is not needed because the wrapped code is a no-op (zero
2527 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2528 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2529
cf5c0175
DA
25302012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2531
2532 * alloc.c (mark_buffer): Simplify. Remove prototype.
2533 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2534 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2535 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2536 redundant calls to mark_vectorlike for bool vectors.
2537
ca26824c
GM
25382012-06-30 Glenn Morris <rgm@gnu.org>
2539
2e4c5312
GM
2540 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2541
ca26824c
GM
2542 * epaths.in (PATH_SITELOADSEARCH): New.
2543 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2544 This is rather than relying on --enable-locallisppath elements
2545 having "site-lisp" in their names. (Bug#10208#25, 11658)
2546
0d23c240
EZ
25472012-06-30 Eli Zaretskii <eliz@gnu.org>
2548
c9240d7a
EZ
2549 * w32proc.c (sys_select): Accept and ignore one more argument.
2550
2551 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2552
0d23c240 2553 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2554 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2555
2556 * sysdep.c: Don't include dos.h and dosfns.h.
2557
2558 * process.c (sys_select):
2559 * msdos.c (sys_select): Accept one more argument and ignore it.
2560
2561 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2562 adapt data types and code to that.
2563
2564 * dosfns.c:
2565 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2566 which clashes with the gnulib function of the same name.
2567
af5a5a98
AS
25682012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2569
c5e4379c
AS
2570 * font.c (font_style_to_value, font_style_symbolic)
2571 (font_prop_validate_style): Add type checks for values in
2572 font_style_table.
2573
af5a5a98
AS
2574 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2575 argument.
2576 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2577 uses.
2578
8d38f461
EZ
25792012-06-29 Eli Zaretskii <eliz@gnu.org>
2580
2e5a6631
EZ
2581 * xdisp.c (try_window_id): Undo last change.
2582
8d38f461
EZ
2583 * w32.c (getwd): Adjust commentary about startup_dir.
2584 (init_environment): Always call sys_access, even in non-MSVC
2585 builds. Don't chdir to the directory of the Emacs executable.
2586 This undoes code from 1997 which was justified by the need to
2587 "avoid conflicts when removing and renaming directories". But its
2588 downside was that every relative file name was being interpreted
2589 relative to the directory of the Emacs executable, which can never
2590 be TRT. In particular, it broke sys_access when called with
2591 relative file names.
2592 (sys_access): Map GetLastError to errno.
2593
2af3565e
DA
25942012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2595
2596 * window.h (struct window): Change type of 'fringes_outside_margins'
2597 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2598 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2599 Adjust comment.
2600 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2601 to ptrdiff_t.
2602
c8d3a25c 26032012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2604
c8d3a25c
GM
2605 * gnutls.c (emacs_gnutls_handshake):
2606 Add QUIT to make the loop interruptible.
57570cd3 2607
c8d3a25c 26082012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2609
c8d3a25c
GM
2610 * charset.c (init_charset): Make lack of etc/charsets fatal.
2611
3e984ee8
DA
26122012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2613
2614 * editfns.c (region_limit): Fix type mismatch.
2615
ef884f23
DA
26162012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2617
2618 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2619 undefined. Convert from xassert to eassert.
2620 * nsmenu.m: Convert from xassert to eassert.
2621 * nsterm.m: Likewise.
2622
7d7e0027
SM
26232012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2624
2625 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2626
aa754e6a
PE
26272012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2628
2629 Avoid integer overflow on scroll-left and scroll-right.
2630 * window.c (HSCROLL_MAX): New macro.
2631 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2632 overflow when requested scroll falls outside ptrdiff_t range.
2633
80b00b08
DA
26342012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2635
2636 * window.h (struct window): Change type of 'hscroll',
2637 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2638 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2639 Adjust users accordingly.
2640 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2641 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2642 from EMACS_INT to ptrdiff_t.
2643 (make_window): Omit redundant initialization.
2644
62b2bcf6
JB
26452012-06-28 Juanma Barranquero <lekktu@gmail.com>
2646
2647 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2648
45942c7d
DA
26492012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2650
2651 * window.h (struct window): Change type of 'use_time' and
2652 'sequence_number' from Lisp_Object to int.
2653 * frame.c (make_frame): Adjust users accordingly.
2654 * print.c (print_object): Likewise.
2655 * window.c (select_window, Fwindow_use_time, make_parent_window)
2656 (make_window): Likewise.
2657
e509cfa6
DA
26582012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2659
2660 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2661 enabled with --enable-checking=[all,glyphs] configure option.
2662 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2663 adjust comments accordingly.
2664 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2665 undefined, adjust comments accordingly.
2666 * image.c: Likewise.
2667 * scroll.c: Likewise.
2668 * w32fns.c: Likewise.
2669 * w32term.c: Likewise.
2670 * xdisp.c: Likewise.
2671 * xfaces.c: Likewise.
2672 * xfns.c: Likewise.
2673 * xterm.c: Likewise.
2674
a54e2c05
DA
26752012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2676
2677 Generalize run-time debugging checks.
2678 * dispextern.h (XASSERTS): Remove.
2679 * fontset.c (xassert): Remove.
2680 Convert from xassert to eassert.
2681 * alloc.c: Convert from xassert to eassert.
2682 * bidi.c: Likewise.
2683 * dispnew.c: Likewise.
2684 * fns.c: Likewise.
2685 * fringe.c: Likewise.
2686 * ftfont.c: Likewise.
2687 * gtkutil.c: Likewise.
2688 * image.c: Likewise.
2689 * keyboard.c: Likewise.
2690 * menu.c: Likewise.
2691 * process.c: Likewise.
2692 * scroll.c: Likewise.
2693 * sound.c: Likewise.
2694 * term.c: Likewise.
2695 * w32console.c: Likewise.
2696 * w32fns.c: Likewise.
2697 * w32term.c: Likewise.
2698 * window.c: Likewise.
2699 * xdisp.c: Likewise.
2700 * xfaces.c: Likewise.
2701 * xfns.c: Likewise.
2702 * xselect.c: Likewise.
2703 * xterm.c: Likewise.
2704
1ec4b7b2
SM
27052012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2706
2707 * fns.c (maybe_resize_hash_table): Output message when growing the
2708 purify-hashtable.
2709
2014308a
DA
27102012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2711
2712 * alloc.c (allocate_string_data): Remove dead code.
2713 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2714 avoid GCC warning about unused macro.
2715
246155eb
DA
27162012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2717
2718 * alloc.c (allocate_string): Omit intervals initialization.
2719 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2720 as in make_pure_string and make_pure_c_string.
2721
43184b7b
DA
27222012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2723
d209e2fb 2724 * alloc.c (allocate_string): Fix last change.
43184b7b 2725
3fe6dd74
DA
27262012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2727
d209e2fb 2728 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2729 to memset, add explicit initialization where appropriate.
2730
1ba6038a
GM
27312012-06-27 Glenn Morris <rgm@gnu.org>
2732
2733 * lisp.mk (lisp): Remove paths.elc.
2734
c89926a5
CY
27352012-06-27 Chong Yidong <cyd@gnu.org>
2736
2737 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2738
ed6b3510
JW
27392012-06-26 John Wiegley <johnw@newartisans.com>
2740
1ec4b7b2 2741 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2742 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2743
ed6b3510
JW
2744 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2745 when building with Clang.
2746
8edd4a2b
SM
27472012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2748
2749 * eval.c (Fapply): Allow calling it with a single argument.
2750
f6f62d1b
EZ
27512012-06-26 Eli Zaretskii <eliz@gnu.org>
2752
2753 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2754 _stricmp and _strnicmp.
2755 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2756
62efea5e
DA
27572012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2758
2759 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2760 allocated window.
2761 (allocate_process): Likewise for new process.
8edd4a2b 2762 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2763 (allocate_frame): Likewise.
2764 * frame.c (make_frame): Omit redundant initialization.
2765 * window.c (make_parent_window): Use memset.
2766 (make_window): Omit redundant initialization.
2767 * process.c (make_process): Omit redundant initialization.
2768 * terminal.c (create_terminal): Likewise.
2769
42997f4d
DA
27702012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2771
2772 * term.c (delete_tty): Remove redundant call to memset.
2773
1130ecfc
DA
27742012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2775
2776 * alloc.c: Remove build_string.
2777 * lisp.h: Define build_string as static inline. This provides
2778 a better opportunity to optimize away calls to strlen when the
2779 function is called with compile-time constant argument.
2780 * image.c (imagemagick_error): Convert to build_string.
2781 * w32proc.c (sys_spawnve): Likewise.
2782 * xterm.c (x_term_init): Likewise.
2783
cf38a720
PE
27842012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2785
99027bdd
PE
2786 Use sprintf return value instead of invoking strlen on result.
2787 In the old days this wasn't portable, since some sprintf
2788 implementations returned char *. But they died out years ago and
2789 Emacs already assumes sprintf returns int.
2790 Similarly for float_to_string.
2791 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2792 * ccl.c (ccl_driver):
2793 * character.c (string_escape_byte8):
2794 * data.c (Fnumber_to_string):
2795 * doprnt.c (doprnt):
2796 * print.c (print_object):
2797 * xdisp.c (message_dolog):
2798 * xfns.c (syms_of_xfns):
2799 Use sprintf or float_to_string result to avoid need to call strlen.
2800 * data.c (Fnumber_to_string):
2801 Use make_unibyte_string, since the string must be ASCII.
2802 * lisp.h, print.c (float_to_string): Now returns int length.
2803 * term.c (produce_glyphless_glyph):
2804 Use sprintf result rather than recomputing it.
2805
cf38a720
PE
2806 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2807 * Makefile.in (ALL_CFLAGS):
2808 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2809 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2810
3511c784
DA
28112012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2812
0a08eb21 2813 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2814 strcasecmp if available.
2815 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2816
fb7da12e
AS
28172012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2818
2819 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2820 Avoid comma operator.
2821 * menu.c (push_submenu_start, push_submenu_end)
2822 (push_left_right_boundary, push_menu_pane): Likewise.
2823 * msdos.c (dos_rawgetc): Likewise.
2824
afa2ffd8
DA
28252012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2826
2827 * xfns.c (xic_create_fontsetname): Remove redundant calls
2828 to memset.
2829
b3b4476b
PE
28302012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2831
4495ff38
PE
2832 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2833 sprintf already null-terminates its output.
2834
b3b4476b
PE
2835 * xfns.c (x_window): Remove redundant cast.
2836
b00876c9
DA
28372012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2838
2839 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2840 `const char *' to `char *' to avoid compiler warning.
2841
d188e26b
PE
28422012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2843
885d1d74
PE
2844 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2845 instead of truncating it to 63 (admittedly a generous limit).
2846
d188e26b
PE
2847 * process.c: Fix spelling and caps in comments.
2848
e2f560b1
DN
28492012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2850
e86db54b 2851 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2852 * sysdep.c (setpgrp): Remove definition, not used in this file.
2853
7583a3a1
JB
28542012-06-24 Juanma Barranquero <lekktu@gmail.com>
2855
2856 * makefile.w32-in: Update dependencies.
2857
696056c2
EZ
28582012-06-24 Eli Zaretskii <eliz@gnu.org>
2859
2860 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2861 (SYSTIME_H): Add nt/inc/sys/time.h.
2862
2863 * systime.h [WINDOWSNT]: Include sys/time.h.
2864
2865 * s/ms-w32.h (struct timespec): Definition moved from
2866 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2867
845ca893
PE
28682012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2869
2870 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2871 * buffer.h (buffer_slot_type_mismatch):
2872 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2873 * eval.c (unwind_to_catch):
2874 * image.c (my_png_error, my_error_exit):
2875 * keyboard.c (quit_throw_to_read_char, user_error)
2876 (Fexit_recursive_edit, Fabort_recursive_edit):
2877 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2878 (wrong_type_argument, buffer_overflow, __executable_start)
2879 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2880 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2881 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2882 (fatal):
2883 (child_setup) [!DOS_NT]:
2884 * lread.c (end_of_file_error, invalid_syntax):
2885 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2886 * puresize.h (pure_write_error):
2887 * search.c (matcher_overflow):
2888 * sound.c (sound_perror, alsa_sound_perror):
2889 * sysdep.c, syssignal.h (croak):
2890 * term.c (maybe_fatal, vfatal):
2891 * textprop.c (text_read_only):
2892 * undo.c (user_error):
2893 * unexmacosx.c (unexec_error):
2894 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2895 Use _Noreturn rather than NO_RETURN.
2896 No need for separate decl merely because of _Noreturn.
2897 * sound.c (sound_warning, parse_sound):
2898 Remove unnecessary forward decls.
2899
f1dd8073
PE
29002012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2901
2902 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2903 * lisp.h (WAIT_READING_MAX): New macro.
2904 * dispnew.c (Fsleep_for, sit_for):
2905 * keyboard.c (kbd_buffer_get_event):
2906 * process.c (Faccept_process_output):
2907 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2908 This improves on the previous patch, which introduced a bug
2909 when time_t is unsigned and as wide as intmax_t.
2910 See <http://bugs.gnu.org/9000#51>.
2911
b82c1755
EZ
29122012-06-23 Eli Zaretskii <eliz@gnu.org>
2913
2914 * dispnew.c (sit_for, Fsleep_for):
2915 * keyboard.c (kbd_buffer_get_event):
2916 * process.c (Faccept_process_output): Avoid compiler warnings when
2917 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2918
ca300656
JB
29192012-06-23 Juanma Barranquero <lekktu@gmail.com>
2920
049ec95b
JB
2921 * makefile.w32-in: Update dependencies.
2922
ca300656
JB
2923 * w32.c (ltime): Add return type and declare static.
2924 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2925
db7b8d06
PE
29262012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2927
2928 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2929 Privately reported by Herbert J. Skuhra.
2930 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2931 All uses changed.
2932 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2933 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2934
0bd8297f
EZ
29352012-06-23 Eli Zaretskii <eliz@gnu.org>
2936
96512555
EZ
2937 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2938 last argument of make_unibyte_string.
2939
0bd8297f
EZ
2940 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2941 language ID in the event parameters.
2942
2943 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2944 event.code, not the obscure "character set ID".
2945
63def6b6
CY
29462012-06-23 Chong Yidong <cyd@gnu.org>
2947
2948 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2949
e8a02204
EZ
29502012-06-23 Eli Zaretskii <eliz@gnu.org>
2951
388cdec0
EZ
2952 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2953 * w32.c (fdutimens): New function.
2954
2955 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2956
2957 * s/ms-w32.h (pselect): Redirect to sys_select.
2958
2959 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2960
e8a02204
EZ
2961 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2962 in the logic of incrementing and decrementing the value of
2963 use_relocatable_buffers.
2964
d054f3fb
PE
29652012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2966
2967 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2968 Privately reported by Herbert J. Skuhra.
2969 [__FreeBSD__]: Remove "*/" typo after "#include".
2970 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2971 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2972 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2973 Don't assume EMACS_TIME and struct timeval are the same type.
2974
d35af63c
PE
29752012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2976
2977 Support higher-resolution time stamps (Bug#9000).
2978 The time stamps are only nanosecond-resolution at the C level,
2979 since that's the best that any real-world system supports now.
2980 But they are picosecond-resolution at the Lisp level, as that's
2981 easy, and leaves room for future OS improvements.
2982
2983 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2984 (LIBES): Use it.
2985
2986 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2987 Don't get current time unless it's needed.
2988
2989 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2990 now provides it if it's absent.
2991 (start_atimer): Port to higher-res time stamps.
2992 Check for time stamp overflow. Don't get current time more
2993 often than is needed.
2994
2995 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2996 Include systime.h, not time.h.
2997 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2998
2999 * dired.c: Include stat-time.h.
3000 (Ffile-attributes): File times now have higher resolution.
3001
3002 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3003 (struct image): Timestamp now has higher resolution.
3004
3005 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3006 has at least microseconds now. All uses removed.
3007 (update_frame, update_single_window, update_window, update_frame_1)
3008 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3009
3010 * editfns.c (time_overflow): Now extern.
3011 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3012 (float-time, Fformat_time_string, Fcurrent_time_string)
3013 (Fcurrent_time_zone): Accept and generate higher-resolution
3014 time stamps.
3015 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3016 (decode_time_components, lisp_seconds_argument): New functions.
3017 (make_time): Now static.
3018 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3019 Report an error if the time is invalid, rather than having the caller
3020 do that.
3021
3022 * fileio.c: Include <stat-time.h>
3023 (Fcopy_file): Copy higher-resolution time stamps.
3024 Prefer to set the time stamp via a file descriptor if that works.
3025 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3026 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3027 (Fvisited_file_modtime, Fset_visited_file_modtime):
3028 Support higher-resolution time stamps.
3029
3030 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3031
3032 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3033
3034 * image.c (prepare_image_for_display, clear_image_cache)
3035 (lookup_image): Port to higer-resolution time stamps.
3036
3037 * keyboard.c (start_polling, bind_polling_period):
3038 Check for time stamp overflow.
3039 (read_char, kbd_buffer_get_event, timer_start_idle)
3040 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3041 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3042 Port to higher-resolution time stamps. Do not assume time_t is signed.
3043 (decode_timer): New function. Timers are now vectors of length 9,
3044 not 8, to accommodate the picosecond component.
3045 (timer_check_2): Use it.
3046
3047 * nsterm.m (select_timeout, timeval_subtract): Remove.
3048 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3049 as they're a bit more accurate and handle overflow better.
3050 (ns_select): Change prototype to be compatible with pselect.
3051 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3052 * nsterm.h (ns_select): Adjust prototype.
3053
3054 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3055 us-resolution time stamps.
3056 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3057
3058 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3059
3060 * lisp.h (time_overflow): New decl.
3061 (wait_reading_process_output): First arg is now intmax_t, not int,
3062 to accommodate larger waits.
3063
3064 * process.h (struct Lisp_Process.read_output_delay):
3065 Now counts nanoseconds, not microseconds.
3066 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3067 EMACS_HAS_USECS.
3068 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3069 (wait_reading_process_output):
3070 Port to ns-resolution time stamps.
3071 (Faccept_process_output, wait_reading_process_output):
3072 Check for time stamp overflow. Do not assume time_t is signed.
3073 (select_wrapper): Remove; we now use pselect.
3074 (Fprocess_attributes): Now generates ns-resolution time stamps.
3075
3076 * sysdep.c: Include utimens.h. Don't include utime.h
3077 or worry about struct utimbuf; gnulib does that for us now.
3078 (gettimeofday): Remove; gnulib provides a substitute.
3079 (make_timeval): New function.
3080 (set_file_times): Now sets ns-resolution time stamps.
3081 New arg FD; all uses changed.
3082 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3083 (system_process_attributes):
3084 Now returns ns-resolution time stamp. All uses changed.
3085 Check for time stamp overflow.
3086
3087 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3088 provides a substitute now.
3089
3090 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3091 since it guarantees struct timespec.
3092 (EMACS_TIME): Now struct timespec, so that we can support
3093 ns-resolution time stamps.
3094 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3095 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3096 (EMACS_USECS): Remove.
3097 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3098 so multiply the arg by 1000 before storing it.
3099 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3100 New macros.
3101 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3102 Port to ns-resolution time stamps.
3103 (EMACS_TIME_NEG_P): Remove; replaced by....
3104 (EMACS_TIME_SIGN): New macro.
3105 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3106 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3107 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3108 (make_timeval, make_lisp_time, decode_time_components): New decls.
3109 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3110 that it mishandled time_t overflow. You can't compare by subtracting!
3111 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3112 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3113
3114 * term.c: Include <sys/time.h>.
3115 (timeval_to_Time): New function, for proper overflow wraparound.
3116 (term_mouse_position, term_mouse_click): Use it.
3117
3118 * undo.c (record_first_change): Support higher-resolution time stamps
3119 in the undo buffer.
3120 (Fprimitive_undo): Use them when restoring time stamps.
3121
3122 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3123 (w32_get_internal_run_time):
3124 Port to higher-resolution Emacs time stamps.
3125 (ltime): Now accepts single 64-bit integer, as that's more convenient
3126 for callers.
3127
3128 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3129
3130 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3131 for compatibility with pselect. Support ns-resolution time stamps.
3132
3133 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3134
3135 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3136 Check for time stamp overflow, and support ns-resolution time stamps.
3137
3138 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3139 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3140 (timeval_subtract): Remove; no longer needed.
3141 (XTflash, XTring_bell, x_wait_for_event):
3142 Port to ns-resolution time stamps. Don't assume time_t is signed.
3143
b6a92dfe
CY
31442012-06-22 Chong Yidong <cyd@gnu.org>
3145
3146 * xdisp.c (x_consider_frame_title): Revert last change.
3147
d251c37c
EZ
31482012-06-22 Eli Zaretskii <eliz@gnu.org>
3149
3150 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3151 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3152 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3153 staticidx goes up to 1597 out of 1600 = 0x640.)
3154
f10deafb
PE
31552012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3156
3157 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3158 Otherwise, the umask might be mistakenly 0 while handling input signals.
3159
ec6de1e2
SM
31602012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3161
3162 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3163
28be1ada
DA
31642012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3165
3166 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3167 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3168 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3169 access to `contents' member of Lisp_Vector objects with AREF and ASET
3170 where appropriate.
3171
c6bf3022
CY
31722012-06-19 Chong Yidong <cyd@gnu.org>
3173
3174 * frame.c (delete_frame): When selecting a frame on a different
3175 text terminal, do not alter the terminal's top-frame.
3176
3177 * xdisp.c (format_mode_line_unwind_data): Record the target
3178 frame's selected window and its terminal's top-frame.
3179 (unwind_format_mode_line): Restore them.
3180 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3181 Callers changed.
3182 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3183 since tty frames can be explicitly named.
3184 (prepare_menu_bars): Likewise.
3185
3186 * term.c (Ftty_top_frame): New function.
3187
defd4196
PE
31882012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3189
3190 Port byte-code-meter to modern targets.
3191 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3192 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3193 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3194 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3195 (METER_1, METER_2): Simplify.
3196
1053a871
SM
31972012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3198
3199 * data.c (Fdefalias): Return `symbol' (bug#11686).
3200
b7e8d081
MR
32012012-06-18 Martin Rudalics <rudalics@gmx.at>
3202
3203 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3204 gets killed during executing of this function (Bug#11665).
3205 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3206 (Vkill_buffer_query_functions): In doc-string say that functions
3207 run by this hook should not change the current buffer.
3208
7ea2b339
PE
32092012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3210
3211 Fix recently-introduced process.c problems found by static checking.
3212 * process.c (write_queue_push, write_queue_pop, send_process):
3213 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3214 (write_queue_pop): Fix pointer signedness problem.
3215 (send_process): Remove unused local.
3216
96a313a1
CY
32172012-06-17 Chong Yidong <cyd@gnu.org>
3218
3219 * xdisp.c (redisplay_internal): No need to redisplay terminal
3220 frames that are not on top.
3221
20ca2e94
TN
32222012-06-17 Troels Nielsen <bn.troels@gmail.com>
3223
3224 * process.c (make_process): Initialize write_queue.
3225 (write_queue_push, write_queue_pop): New functions.
3226 (send_process): Use them to maintain correct ordering of process
3227 writes (Bug#10815).
3228
9a900ca9
PE
32292012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3230
310fbfa8
PE
3231 * lisp.h (eassert): Assume C89 or later.
3232 This removes the need for CHECK.
3233 (CHECK): Remove. Its comments about always evaluating its
3234 argument were confusing, as 'eassert' typically does not evaluate
3235 its argument.
3236
27bb1ca4
PE
3237 * coding.c (produce_chars): Use ptrdiff_t, not int.
3238
9a900ca9
PE
3239 * xterm.c (x_draw_underwave): Check for integer overflow.
3240 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3241
41b7f8bc 32422012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3243
3244 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3245 referenced (Bug#11583).
3246
9b0e3eba
AA
32472012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3248
3249 Implement wave-style variant of underlining.
3250 * dispextern.h (face_underline_type): New enum.
3251 (face): Add field for underline type.
3252 * nsterm.m (ns_draw_underwave): New function.
3253 (ns_draw_text_decoration): Use it.
3254 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3255 New functions.
3256 (x_draw_glyph_string): Use them.
3257 * xfaces.c (Qline, Qwave): New Lisp objects.
3258 (check_lface_attrs, merge_face_ref)
1053a871
SM
3259 (Finternal_set_lisp_face_attribute, realize_x_face):
3260 Handle wave-style underline face attributes.
9b0e3eba
AA
3261 * xterm.c (x_draw_underwave): New function.
3262 (x_draw_glyph_string): Use it.
3263
0fb52f11
JB
32642012-06-16 Juanma Barranquero <lekktu@gmail.com>
3265
3266 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3267 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3268 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3269 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3270 ($(BLD)/w32select.$(O)): Update dependencies.
3271
e5560ff7
AS
32722012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3273
3274 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3275 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3276 * character.c (_fetch_multibyte_char_p): Remove.
3277 * alloc.c: Include "character.h" before "buffer.h".
3278 * bidi.c: Likewise.
3279 * buffer.c: Likewise.
3280 * bytecode.c: Likewise.
3281 * callint.c: Likewise.
3282 * callproc.c: Likewise.
3283 * casefiddle.c: Likewise.
3284 * casetab.c: Likewise.
3285 * category.c: Likewise.
3286 * cmds.c: Likewise.
3287 * coding.c: Likewise.
3288 * composite.c: Likewise.
3289 * dired.c: Likewise.
3290 * dispnew.c: Likewise.
3291 * doc.c: Likewise.
3292 * dosfns.c: Likewise.
3293 * editfns.c: Likewise.
3294 * emacs.c: Likewise.
3295 * fileio.c: Likewise.
3296 * filelock.c: Likewise.
3297 * font.c: Likewise.
3298 * fontset.c: Likewise.
3299 * fringe.c: Likewise.
3300 * indent.c: Likewise.
3301 * insdel.c: Likewise.
3302 * intervals.c: Likewise.
3303 * keyboard.c: Likewise.
3304 * keymap.c: Likewise.
3305 * lread.c: Likewise.
3306 * macros.c: Likewise.
3307 * marker.c: Likewise.
3308 * minibuf.c: Likewise.
3309 * nsfns.m: Likewise.
3310 * nsmenu.m: Likewise.
3311 * print.c: Likewise.
3312 * process.c: Likewise.
3313 * regex.c: Likewise.
3314 * region-cache.c: Likewise.
3315 * search.c: Likewise.
3316 * syntax.c: Likewise.
3317 * term.c: Likewise.
3318 * textprop.c: Likewise.
3319 * undo.c: Likewise.
3320 * unexsol.c: Likewise.
3321 * w16select.c: Likewise.
3322 * w32fns.c: Likewise.
3323 * w32menu.c: Likewise.
3324 * window.c: Likewise.
3325 * xdisp.c: Likewise.
3326 * xfns.c: Likewise.
3327 * xmenu.c: Likewise.
3328 * xml.c: Likewise.
3329 * xselect.c: Likewise.
3330
2f07e6af
EZ
33312012-06-16 Eli Zaretskii <eliz@gnu.org>
3332
1053a871
SM
3333 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3334 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3335 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3336 row.
3337 (handle_face_prop): Use chunk-relative overlay string index when
3338 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3339 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3340 the rightmost. (Bug#11720)
2f07e6af 3341
29b83cec
AS
33422012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3343
3344 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3345 (CATEGORY_MEMBER): Enforce 1/0 value.
3346 * category.c (_temp_category_set): Remove.
3347
4c5501e9
EZ
33482012-06-16 Eli Zaretskii <eliz@gnu.org>
3349
3350 * window.c (Fdelete_other_windows_internal)
3351 (Fdelete_window_internal): Don't access frame's mouse highlight
3352 info of the initial frame. (Bug#11677)
3353
2b570124
PE
33542012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3355
e93864f9
PE
3356 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3357 Assume USE_2_TAGS_FOR_INTS.
3358 (xreload): Adjust $tagmask width to match recent lisp.h change.
3359
2b570124
PE
3360 Simplify lisp.h in minor ways that should not affect code.
3361 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3362 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3363 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3364 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3365 (INTTYPEBITS): New macro, for clarity.
3366 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3367 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3368 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3369 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3370 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3371
81755f69
JB
33722012-06-13 Juanma Barranquero <lekktu@gmail.com>
3373
3374 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3375
16192a57
GM
33762012-06-13 Glenn Morris <rgm@gnu.org>
3377
3378 * s/bsd-common.h (BSD4_3):
3379 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3380
646b5f55
AS
33812012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3382
3383 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3384 instead of union.
3385 (XLI, XIL): Define.
1053a871
SM
3386 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3387 Use them.
3388 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3389 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3390 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3391 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3392 * frame.c (delete_frame): Remove outdated comment.
3393 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3394 USE_LISP_UNION_TYPE.
3395 (Fw32_unregister_hot_key): Likewise.
3396 (Fw32_toggle_lock_key): Likewise.
3397 * w32menu.c (add_menu_item): Likewise.
3398 (w32_menu_display_help): Use XIL instead of checking
3399 USE_LISP_UNION_TYPE.
3400 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3401 (init_heap): Likewise.
3402 * w32term.c (w32_read_socket): Update comment.
3403
1d3823c9
GM
34042012-06-13 Glenn Morris <rgm@gnu.org>
3405
c62ff706
GM
3406 * s/usg5-4-common.h, src/s/unixware.h:
3407 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3408
1d3823c9
GM
3409 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3410
bfe3e0a2
PE
34112012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3412
3413 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3414 * alloc.c (make_number) [!defined make_number]:
3415 Remove, as lisp.h always defines this now.
3416 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3417 (roundup_size): Verify that it is a power of 2.
3418 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3419 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3420 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3421 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3422 USE_LSB_TAG now is always defined to be either 0 or 1.
3423 All uses changed.
3424 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3425 code works fine either way, and efficiency is not a concern here,
3426 as the union type is for debugging, not for production.
3427 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3428 Use an inline function on all platforms when using the union type,
3429 since this is simpler and 'static inline' can be used portably
3430 within Emacs now.
3431 (LISP_INITIALLY_ZERO): New macro.
3432 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3433 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3434
45fa9c0f
GM
34352012-06-12 Glenn Morris <rgm@gnu.org>
3436
b4492cba
GM
3437 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3438
3439 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3440
45fa9c0f
GM
3441 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3442 Move BROKEN_SIGIO to configure.
3443
3444 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3445 Move NO_TERMIO to configure.
3446
0e25d334
CY
34472012-06-12 Chong Yidong <cyd@gnu.org>
3448
3449 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3450 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3451 MagickExportImagePixels is undefined.
3452
43682bb6
PE
34532012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3454
3455 * image.c (imagemagick_load_image): Remove unused label.
3456
a9be7d2b
GM
34572012-06-11 Glenn Morris <rgm@gnu.org>
3458
3459 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3460 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3461 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3462 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3463
3017f87f
SM
34642012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3465
3466 * alloc.c (make_byte_code): New function.
3467 (Fmake_byte_code): Use it. Don't purify here.
3468 * lread.c (read1): Use it as well to avoid extra allocation.
3469
1b9b4cf4
CY
34702012-06-11 Chong Yidong <cyd@gnu.org>
3471
3472 * image.c (imagemagick_load_image): Implement transparency.
3473
95988fcf
AS
34742012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3475
3476 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3477 account for preceding backslashes. (Bug#11663)
3478
cd4eb164
CY
34792012-06-09 Chong Yidong <cyd@gnu.org>
3480
3481 * term.c: Support italics in capable terminals (Bug#9652).
3482 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3483 (turn_on_face): Output using TS_enter_italic_mode if available.
3484 Don't handle unused blinking and alt-charset cases.
3485 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3486 and tty_alt_charset_p cases.
3487 (tty_capable_p, init_tty): Support italics.
3488
3489 * termchar.h (struct tty_display_info): Add field for italics.
3490 Remove unused blink field.
3491
3492 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3493 Handle slant.
3494
3495 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3496 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3497 tty_alt_charset_p. Add tty_italic_p.
3498
ff88beb8
MA
34992012-06-09 Michael Albinus <michael.albinus@gmx.de>
3500
3501 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3502 dbus_type_is_basic if available.
3503 (xd_extract_signed, xd_extract_unsigned): Rename from
3504 extract_signed and extract_unsigned, respectively. Adapt callers.
3505
44286096
CY
35062012-06-09 Chong Yidong <cyd@gnu.org>
3507
1682701f
CY
3508 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3509
44286096
CY
3510 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3511 case (Bug#9752).
3512
d86feb17
PE
35132012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 * xdisp.c (vmessage): Treat frame message as multibyte.
3516 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3517 would generate the diagnostic "Making \302\247 buffer-local while
3518 let-bound!".
3519
d5c20fe8
EZ
35202012-06-08 Eli Zaretskii <eliz@gnu.org>
3521
3522 * dispnew.c (showing_window_margins_p): Undo last change, which
3523 was done due to an inadvertent commit.
3524 (adjust_frame_glyphs_for_frame_redisplay): Do call
3525 showing_window_margins_p.
3526
513749ee
SM
35272012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3528
3529 * eval.c (Fmake_var_non_special): New primitive.
3530 (syms_of_eval): Defsubr it.
3531 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3532
d4a8f5c1
JB
35332012-06-08 Juanma Barranquero <lekktu@gmail.com>
3534
3535 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3536 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3537
8bbbc977
EZ
35382012-06-08 Eli Zaretskii <eliz@gnu.org>
3539
3540 * alloc.c (allocate_vectorlike): Fix last change.
3541
f3372c87
DA
35422012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3543
3544 Block-based vector allocation of small vectors.
3545 * lisp.h (struct vectorlike_header): New field `nbytes',
3546 adjust comment accordingly.
3547 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3548 to denote vector blocks. Adjust users (live_vector_p,
3549 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3550 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3551 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3552 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3553 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3554 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3555 (roundup_size): New constant.
3556 (struct vector_block): New data type.
3557 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3558 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3559 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3560 (sweep_vectors): New functions.
3561 (allocate_vectorlike): Return `zero_vector' as the only vector of
3562 0 items. Allocate new vector from block if vector size is less than
3563 or equal to VBLOCK_BYTES_MAX.
3564 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3565 (init_alloc_once): Add call to init_vectors.
3566
4f18a4ed
SM
35672012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3568
3569 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3570
86f158bc
PE
35712012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3572
3573 * doprnt.c (doprnt): Truncate multibyte char correctly.
3574 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3575 would mishandle a string argument "Xc" if X was a multibyte
3576 character of length 2: it would truncate after X's first byte
3577 rather than including all of X.
3578
c5cfcbe0
CY
35792012-06-06 Chong Yidong <cyd@gnu.org>
3580
3581 * buffer.c (word_wrap): Doc fix.
3582
c05cf390
PE
35832012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3584
3585 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3586
0c3461de
GM
35872012-06-03 Glenn Morris <rgm@gnu.org>
3588
3589 * xdisp.c (tool-bar-style): Doc fix.
3590
c71232db
UM
35912012-06-03 Ulrich Müller <ulm@gentoo.org>
3592
3593 * Makefile.in (PAXCTL): Define.
3594 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3595 binary via PaX flags if the paxctl utility is available.
3596 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3597 Restore PaX flags to their default. (Bug#11398)
3598
383f7350
CY
35992012-06-03 Chong Yidong <cyd@gnu.org>
3600
3601 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3602 buffer (Bug#11226).
3603
5f2c76c6
CY
36042012-06-03 Chong Yidong <cyd@gnu.org>
3605
3606 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3607 (note_mode_line_or_margin_highlight): If there is no help echo,
3608 use mode-line-default-help-echo. Handle the case where the mouse
3609 position is past the end of the mode line string.
3610
3611 * buffer.c (buffer_local_value_1): New function, split from
3612 Fbuffer_local_value; can return Qunbound.
3613 (Fbuffer_local_value): Use it.
3614 (Vmode_line_format): Docstring tweaks.
3615
773d47f6
PE
36162012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3617
3618 * sysdep.c (system_process_attributes): Improve comment.
3619
f2d6a3df
SM
36202012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3621
3622 * keyboard.c: Export real-this-command to Elisp.
3623 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3624 and DEFVAR it. Update all users.
3625
63810350
PE
36262012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3627
7bd5c1f4
PE
3628 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3629
63810350
PE
3630 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3631 Convert pctcpu and pctmem to Lisp float properly.
3632 Let the compiler fold better, as 100.0/0x8000 is exact.
3633
a2821611
AS
36342012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3635
3636 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3637 cons_block.
3638
5fceba1d
PE
36392012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3640
3641 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3642
c98ff5dd
DA
36432012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3644
3645 For a 'struct window', replace some Lisp_Object fields to
3646 bitfields where appropriate, remove unused fields.
3647 * window.h (struct window): Remove unused 'last_mark_x' and
3648 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3649 change it's type from Lisp_Object to bitfield.
3650 Change type of 'force_start', 'optional_new_start',
3651 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3652 fields from Lisp_Object to bitfield. Adjust users accordingly.
3653
ca34e0be
PE
36542012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3655
3656 Pacify gcc -Wdouble-precision when using Xaw.
3657 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3658 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3659 Use 'float' consistently, rather than 'float' in most places
3660 and 'double' in a couple of places.
3661
efc00ab1 36622012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3663
3664 * xdisp.c (handle_stop): Detect whether we have overlay strings
3665 loaded by testing it->current.overlay_string_index to be
3666 non-negative, instead of checking whether n_overlay_strings is
3667 positive. (Bug#11587)
3668
efc00ab1 36692012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3670
3671 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3672
3673 * doc.c (Fsubstitute_command_keys): Doc fix.
3674
efc00ab1 36752012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3676
3677 * search.c (search_buffer): Remove calls to
3678 r_alloc_inhibit_buffer_relocation, as it is now called by
3679 maybe_unify_char, which was the cause of relocation of buffer text
3680 in bug#11519.
3681
efc00ab1 36822012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3683
3684 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3685 for the duration of call to load_charset, to avoid problems with
3686 callers of maybe_unify_char that access buffer text through C
3687 pointers.
3688
3689 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3690 decrement the inhibition flag, instead of just setting or
3691 resetting it.
3692
ba93a187
PE
36932012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3694
3695 Remove obsolete '#define static' cruft.
3696 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3697 This #undef was "temporary" in 2000; it is no longer needed
3698 now that '#define static' has gone away.
3699 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3700 (gray_bitmap_bits): Remove; no longer needed.
3701 All uses replaced with definiens.
3702 * xterm.c: Include "bitmaps/gray.xbm".
3703
9e4bf381
PE
37042012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3705
3706 Clean up __executable_start, monstartup when --enable-profiling.
3707 The following changes affect the code only when profiling.
3708 * dispnew.c (__executable_start): Rename from safe_bcopy.
3709 Define only on platforms that need it.
3710 * emacs.c: Include <sys/gmon.h> when profiling.
3711 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3712 (__executable_start): Remove decl, since lisp.h does it now.
3713 (safe_bcopy): Remove decl; no longer has that name.
3714 (main): Coalesce #if into single bit of code, for simplicity.
3715 Cast pointers to uintptr_t, since standard libraries want integers
3716 and not pointers.
3717 * lisp.h (__executable_start): New decl.
3718
32d72c2f
GM
37192012-05-31 Glenn Morris <rgm@gnu.org>
3720
3721 * image.c (Fimagemagick_types): Doc fix.
3722
baac5bc7
JM
37232012-05-30 Jim Meyering <meyering@redhat.com>
3724
3725 * callproc.c (Fcall_process_region): Include directory component
3726 in mkstemp error message (Bug#11586).
3727
72cb32cf
PE
37282012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3729
3730 * alloc.c, lisp.h (make_pure_vector): Now static.
3731
61b108cc
SM
37322012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3733
3734 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3735 Move to byte-run.el.
3736 (Fautoload): Do the hash-doc more carefully.
3737 * data.c (Fdefalias): Purify definition, except for keymaps.
3738 (Qdefun): Move from eval.c.
3739 * lisp.h (Qdefun): Remove.
3740 * lread.c (read1): Tiny simplification.
3741
471fe23d
TN
37422012-05-29 Troels Nielsen <bn.troels@gmail.com>
3743
934f3f58 3744 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3745 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3746 Bug#9642, but explicitly check that the buffer the overlay would
3747 be moved to is live and rearrange lines to make sure that errors
3748 will not put the overlay in an inconsistent state.
3749 (Fdelete_overlay): Cosmetics.
3750
85d0efd1
EZ
37512012-05-28 Eli Zaretskii <eliz@gnu.org>
3752
3753 * w32term.c (my_bring_window_to_top): New function.
3754 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3755 could be different from the original one.
3756 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3757 (Bug#11513)
3758
3759 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3760 by calling BringWindowToTop.
3761
3762 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3763 (WM_EMACS_END): Increase by one.
3764
da92a98c
PE
37652012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3766
3767 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3768 This avoids undefined behavior that might cause the eassert
3769 to not catch an out-of-range value.
3770
74d1f848
JB
37712012-05-28 Juanma Barranquero <lekktu@gmail.com>
3772
3773 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3774 Update dependencies.
3775
9e1a06fc
EZ
37762012-05-27 Eli Zaretskii <eliz@gnu.org>
3777
3778 * bidi.c (bidi_mirror_char): Fix last change.
3779
f3dd7312
AS
37802012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3781
3782 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3783 when referring to sectname field in printf format.
3784
81899c91
PE
37852012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3786
57b81a9f
PE
3787 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3788 Only r_alloc_inhibit_buffer_relocation needed to be added;
3789 the others were already declared.
3790
81899c91
PE
3791 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3792 before checking whether it's out of range. Put the check inside
3793 eassert. See
3794 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3795
33017faf 37962012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3797
3798 * callproc.c (Fcall_process): Restore a line that was accidentally
3799 commented out in the 2011-02-13 change (bug#11547).
3800
33017faf 38012012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3802
3803 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3804 defined on ralloc.c.
3805
3806 * buffer.c [REL_ALLOC]: Remove prototypes of
3807 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3808 they are now on lisp.h.
3809
3810 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3811
3812 * search.c (search_buffer): Use it to inhibit relocation of buffer
3813 text while re_search_2 is doing its job, because re_search_2 is
3814 passed C pointers to buffer text. (Bug#11519)
3815
23415acf
EZ
3816 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3817 Update value to 24.
3818
44e27368
EZ
3819 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3820 state after an additional call to move_it_in_display_line_to, keep
3821 the values of it->max_ascent and it->max_descent found for the
3822 entire line.
3823 (pos_visible_p): Revert the comparison against bottom_y to what it
3824 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3825 (Bug#11464)
3826
c1892f11
PE
38272012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3828
3829 Fix coding-related core dumps with gcc -ftrapv.
3830 The code was computing A - B, where A and B are pointers, and B is
3831 random garbage. This can lead to core dumps on platforms that
3832 have special pointer registers, and it also leads to core dumps on
3833 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3834 A - B only when B is initialized properly.
3835 * coding.c (coding_set_source, coding_set_destination): Return void.
3836 (coding_change_source, coding_change_destinations): New functions,
3837 with the old behaviors of coding_set_source and coding_set_destination.
3838 All callers that need an offset changed to use these new functions.
3839
eb7afdad
GM
38402012-05-26 Glenn Morris <rgm@gnu.org>
3841
3842 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3843
f12fdf02
EZ
38442012-05-26 Eli Zaretskii <eliz@gnu.org>
3845
53a63be6 3846 Extend mouse support on W32 text-mode console.
61b108cc
SM
3847 * xdisp.c (draw_row_with_mouse_face):
3848 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3849
eb3f6f01 3850 * w32console.c: Include window.h.
61b108cc
SM
3851 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3852 New functions.
eb3f6f01
EZ
3853 (initialize_w32_display): Initialize mouse-highlight data.
3854
53a63be6
EZ
3855 * w32inevt.c: Include termchar.h and window.h.
3856 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3857 moves, call note_mouse_highlight. If help_echo changed, call
3858 gen_help_event to produce help-echo message in the echo area.
3859 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3860 highlight info.
3861
4cfd81f6
PE
38622012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3863
3864 * lread.c (read1): Simplify slightly to avoid an overflow warning
3865 with GCC 4.7.0 on x86-64.
3866
4446092a
EZ
38672012-05-26 Eli Zaretskii <eliz@gnu.org>
3868
3869 * bidi.c (bidi_mirror_char): Revert last change: an int is
3870 definitely wide enough here.
3871
42b2a986 38722012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3873
42b2a986 3874 Fix integer width and related bugs (Bug#9874).
eb106a49 3875 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3876 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3877 (string_bytes, check_sblock, allocate_string_data):
3878 (compact_small_strings, Fmake_bool_vector, make_string)
3879 (make_unibyte_string, make_multibyte_string)
3880 (make_string_from_bytes, make_specified_string)
3881 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3882 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3883 (mark_vectorlike):
3884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3885 (allocate_pseudovector):
3886 Use int, not EMACS_INT, where int is wide enough.
3887 (inhibit_garbage_collection, Fgarbage_collect):
3888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3889 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3890 int might not be wide enough.
3891 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3892 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3893 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3894 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3895 (bidi_level_of_next_char, bidi_move_to_visually_next):
3896 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3897 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3898 (Fkill_buffer, Fset_buffer_major_mode)
3899 (advance_to_char_boundary, Fbuffer_swap_text)
3900 (Fset_buffer_multibyte, overlays_at, overlays_in)
3901 (overlay_touches_p, struct sortvec, record_overlay_string)
3902 (overlay_strings, recenter_overlay_lists)
3903 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3904 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3905 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3906 (Foverlay_recenter, last_overlay_modification_hooks_used)
3907 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3908 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3909 (validate_region): Omit unnecessary test for b <= e,
3910 since that's guaranteed by the previous test.
d311d28c
PE
3911 (adjust_overlays_for_delete): Avoid pos + length overflow.
3912 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3913 (report_overlay_modification):
3914 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3915 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3916 Omit pointer cast, which isn't needed anyway, and doesn't work
3917 after the EMACS_INT -> ptrdiff_t change.
02481186 3918 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3919 * buffer.h: Adjust decls to match defn changes elsewhere.
3920 (struct buffer_text, struct buffer):
3921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3922 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3923 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3924 not int, to avoid needless 32-bit limit on 64-bit hosts.
3925 (exec_byte_code): Use tighter memory-full test, one that checks
3926 for alloca overflow. Don't compute the address of the object just
3927 before an array, as that's not portable. Use EMACS_INT, not
3928 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3929 * callint.c (Fcall_interactively):
3930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3931 * callproc.c (call_process_kill, Fcall_process):
3932 Don't assume pid_t fits into an Emacs fixnum.
3933 (call_process_cleanup, Fcall_process, child_setup):
3934 Don't assume pid_t fits into int.
3935 (call_process_cleanup, Fcall_process, delete_temp_file)
3936 (Fcall_process_region):
3937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3938 (Fcall_process): Simplify handling of volatile integers.
3939 Use int, not EMACS_INT, where int will do.
3940 * casefiddle.c (casify_object, casify_region, operate_on_word)
3941 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3942 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3943 (casify_object): Avoid integer overflow when overallocating buffer.
3944 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3945 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3946 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3947 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3948 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3949 integers are now checked earlier. All uses replaced with XINT.
3950 (ccl_driver):
3951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3952 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3953 (ccl_driver, Fregister_code_conversion_map):
3954 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3955 (resolve_symbol_ccl_program): Check that vector header is in range.
3956 Always copy the vector, so that we can check its contents reliably
3957 now rather than having to recheck each instruction as it's being
3958 executed. Check that vector words fit in 'int'.
3959 (ccl_get_compiled_code, Fregister_ccl_program)
3960 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3961 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3962 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3963 contents are in range.
3964 (Fccl_execute_on_string): Check that status is in range.
3965 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3966 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3967 Accept and return EMACS_INT, not int, because callers can pass values
3968 out of 'int' range.
3969 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3970 (multibyte_chars_in_text, parse_str_as_multibyte)
3971 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3972 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3973 (string_escape_byte8, Fget_byte):
3974 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3975 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3976 avoid mishandling large integers.
3977 * character.h: Adjust decls to match defn changes elsewhere.
3978 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3979 (Ffind_charset_region):
3980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3981 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3982 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3983 Don't assume fixnum fits in int.
d311d28c
PE
3984 (load_charset_map_from_vector, Fmap_charset_chars):
3985 Remove now-unnecessary CHECK_NATNUMs.
3986 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3987 Don't rely on undefined behavior with signed left shift overflow.
3988 Don't assume unsigned int fits into fixnum, or that fixnum fits
3989 into unsigned int. Don't require max_code to be a valid fixnum;
3990 that's not true for gb10830 4-byte on a 32-bit host. Allow
3991 invalid_code to be a cons, for the same reason. Require code_offset
3992 to be a character. Avoid int overflow if max_char is close
3993 to INT_MAX.
3994 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3995 this is intended anyway and avoids some undefined behavior.
3996 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3997 INDEX_TO_CODE_POINT, as that's what it expects.
3998 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3999 * charset.h (DECODE_CHAR): Return int, not unsigned;
4000 this is what was intended anyway, and it avoids undefined behavior.
4001 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4002 integer-overflow issues.
4003 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4004 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4005 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4006 * chartab.c (Fmake_char_table, Fset_char_table_range)
4007 (uniprop_get_decoder, uniprop_get_encoder):
4008 Don't assume fixnum fits in int.
4009 * cmds.c (move_point): New function, that does the gist of
4010 Fforward_char and Fbackward_char, but does so while checking
4011 for integer overflow more accurately.
c96e5d6a 4012 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4013 (Fforward_line, Fend_of_line, internal_self_insert)
4014 (internal_self_insert):
4015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4016 Fix a FIXME, by checking for integer overflow when calculating
4017 target_clm and actual_clm.
4018 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4019 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4020 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4021 (coding_alloc_by_making_gap, alloc_destination)
4022 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4023 (encode_coding_utf_16, detect_coding_emacs_mule)
4024 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4025 (detect_coding_iso_2022, decode_coding_iso_2022)
4026 (encode_invocation_designation, encode_designation_at_bol)
4027 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4028 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4029 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4030 (encode_coding_ccl, encode_coding_raw_text)
4031 (detect_coding_charset, decode_coding_charset)
4032 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4033 (produce_composition, produce_charset, produce_annotation)
4034 (decode_coding, handle_composition_annotation)
4035 (handle_charset_annotation, consume_chars, decode_coding_gap)
4036 (decode_coding_object, encode_coding_object, detect_coding_system)
4037 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4038 (code_convert_region, code_convert_string)
8f50130c
PE
4039 (Fdefine_coding_system_internal)
4040 (coding_set_source, coding_set_destination):
d311d28c
PE
4041 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4042 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4043 (Fdefine_coding_system_internal):
4044 Don't assume fixnums fit in int.
4045 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4046 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4047 (Funencodable_char_position, Fcheck_coding_systems_region)
4048 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4049 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4050 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4051 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4052 Don't access memory outside of the args array.
d311d28c 4053 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4054 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4055 result of ENCODE_CHAR.
d311d28c
PE
4056 * coding.h: Adjust decls to match defn changes elsewhere.
4057 (struct coding_system):
4058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4059 * composite.c (get_composition_id, find_composition)
4060 (run_composition_function, update_compositions)
4061 (compose_text, composition_gstring_put_cache)
4062 (composition_gstring_p, composition_gstring_width)
4063 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4064 (composition_compute_stop_pos, composition_reseat_it)
4065 (composition_update_it, struct position_record)
4066 (find_automatic_composition, composition_adjust_point)
4067 (Fcomposition_get_gstring, Ffind_composition_internal):
4068 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4069 (update_compositions):
4070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4071 * composite.h: Adjust decls to match defn changes elsewhere.
4072 (struct composition):
4073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4074 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4075 Do not attempt to compute the address of the object just before a
4076 buffer; this is not portable.
4077 (Faref, Faset):
4078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4079 (Faset): Use int, not EMACS_INT, where int is wide enough.
4080 (Fstring_to_number): Don't assume fixnums fit in int.
4081 (Frem): Don't assume arg is nonnegative.
4082 * dbusbind.c (xd_append_arg): Check for integers out of range.
4083 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4084 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4085 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4086 (xd_get_connection_references): Return ptrdiff_t, not int.
4087 All uses changed.
4088 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4089 (xd_read_message_1):
4090 Use int, not unsigned, where the dbus API uses int.
4091 (Fdbus_message_internal): Don't overflow mtype.
4092 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4093 * dired.c (directory_files_internal, file_name_completion, scmp)
4094 (file_name_completion_stat):
4095 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4096 (file_name_completion): Don't overflow matchcount.
4097 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4098 * dispextern.h: Adjust decls to match defn changes elsewhere.
4099 (struct text_pos, struct glyph, struct bidi_saved_info)
4100 (struct bidi_string_data, struct bidi_it, struct composition_it)
4101 (struct it):
4102 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4103 (struct display_pos, struct composition_it, struct it):
4104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4105 * dispnew.c (increment_matrix_positions)
4106 (increment_row_positions, mode_line_string)
4107 (marginal_area_string):
4108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4109 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4111 (duration_to_sec_usec): New function, to check for overflow better.
4112 (Fsleep_for, sit_for): Use it.
4113 * doc.c (get_doc_string, store_function_docstring):
4114 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4115 (get_doc_string, Fsnarf_documentation):
4116 Use int, not EMACS_INT, where int is wide enough.
4117 (get_doc_string):
4118 Use SAFE_ALLOCA, not alloca.
4119 Check for overflow when converting EMACS_INT to off_t.
4120 * doprnt.c (doprnt):
4121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4122 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4123 Don't assume uid_t fits into fixnum.
4124 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4125 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4126 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4127 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4128 (general_insert_function)
4129 (Finsert_char, make_buffer_string, make_buffer_string_both)
4130 (update_buffer_properties, Fbuffer_substring)
4131 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4132 (Fsubst_char_in_region, check_translation)
4133 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4134 (transpose_markers, Ftranspose_regions):
4135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4136 (clip_to_bounds): Move to lisp.h as an inline function).
4137 (Fconstrain_to_field): Don't assume integers are nonnegative.
4138 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4139 (Fsubst_char_in_region, Fsave_restriction):
4140 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4141 (Femacs_pid): Don't assume pid_t fits into fixnum.
4142 (lo_time): Use int, not EMACS_INT, when int suffices.
4143 (lisp_time_argument): Check for usec out of range.
4144 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4145 (Fuser_login_name, Fuser_full_name): Signal an error
4146 if a uid argument is out of range, rather than relying on
4147 undefined behavior.
c8d5c857
PE
4148 (Fformat_time_string): Remove now-unnecessary check.
4149 lisp_time_argument checks for out-of-range usec now.
243e0530 4150 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4151 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4152 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4153 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4154 (init_cmdargs, Fdump_emacs):
4155 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4156 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4157 the bottom (typically) 32 bits of the fixnum.
4158 * eval.c (specpdl_size, call_debugger):
4159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4160 (when_entered_debugger, Fbacktrace_debug):
4161 Don't assume fixnum can fit in int.
4162 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4163 the object just before a buffer; this is not portable.
4164 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4165 (grow_specpdl, unbind_to):
4166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4167 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4168 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4169 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4170 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4171 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4173 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4174 (a_write, e_write):
4175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4176 (Fcopy_file, non_regular_nbytes, read_non_regular)
4177 (Finsert_file_contents):
4178 Use int, not EMACS_INT, where int is wide enough.
4179 (READ_BUF_SIZE): Verify that it fits in int.
4180 (Finsert_file_contents): Check that counts are in proper range,
4181 rather than assuming fixnums fit into ptrdiff_t etc.
4182 Don't assume fixnums fit into int.
125b3835 4183 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4184 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4185 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4186 (string_char_to_byte, string_byte_to_char)
4187 (string_make_multibyte, string_to_multibyte)
4188 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4189 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4190 (substring_both, Fdelete, internal_equal, Ffillarray)
4191 (Fclear_string, mapcar1)
4192 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4193 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4194 (larger_vector, make_hash_table, maybe_resize_hash_table)
4195 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4196 (Fmaphash, secure_hash):
4197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4198 (concat): Check for string index and length overflow.
4199 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4200 (Frequire):
4201 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4202 (larger_vector): New API (vec, incr_min, size_max) replaces old
4203 one (vec, new_size, init). This catches size overflow.
4204 INIT was removed because it was always Qnil.
4205 All callers changed.
4206 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4207 the upper bound on a hash table index size.
4208 (make_hash_table, maybe_resize_hash_table): Use it.
4209 (secure_hash): Computer start_byte and end_byte only after
4210 they're known to be in ptrdiff_t range.
4211 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4212 (Ffont_get_glyphs, Ffont_at):
4213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4214 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4215 (Flist_fonts, Fopen_font):
4216 Don't assume fixnum can fit in int.
4217 (check_gstring): Don't assume index can fit in int.
4218 (font_match_p): Check that fixnum is a character, not a nonnegative
4219 fixnum, since the later code needs to stuff it into an int.
4220 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4221 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4222 conversion overflow issues.
4223 (Fopen_font): Check for integer out of range.
4224 (Ffont_get_glyphs): Don't assume index can fit in int.
4225 * font.h: Adjust decls to match defn changes elsewhere.
4226 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4227 integer overflow.
4228 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4229 printmax_t, where ptrdiff_t is wide enough.
4230 (Finternal_char_font):
4231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4232 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4233 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4234 (Fset_frame_position, x_set_frame_parameters)
4235 (x_set_line_spacing, x_set_border_width)
4236 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4237 Check that fixnums are in proper range for system types.
4238 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4240 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4241 Use SAFE_ALLOCA_LISP, not alloca.
4242 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4243 intptr_t is wide enough.
4244 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4245 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4246 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4247 Check for fixnum out of range.
4248 * ftfont.c (ftfont_list): Don't assume index fits in int.
4249 Check that fixnums are in proper range for system types.
4250 (ftfont_shape_by_flt):
4251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4252 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4254 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4255 Check that fixnums are in proper range for system types.
4256 * gnutls.h: Adjust decls to match defn changes elsewhere.
4257 * gtkutil.c (xg_dialog_run):
4258 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4259 (update_frame_tool_bar):
4260 Check that fixnums are in proper range for system types.
4261 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4262 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4263 * indent.c (last_known_column, last_known_column_point):
4264 (current_column_bol_cache):
4265 (skip_invisible, current_column, check_display_width):
4266 (check_display_width, scan_for_column, current_column_1)
4267 (Findent_to, Fcurrent_indentation, position_indentation)
4268 (indented_beyond_p, Fmove_to_column, compute_motion):
4269 (Fcompute_motion, Fvertical_motion):
4270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4271 (last_known_column_modified): Use EMACS_INT, not int.
4272 (check_display_width):
4273 (Fcompute_motion):
4274 Check that fixnums and floats are in proper range for system types.
4275 (compute_motion): Don't assume index or fixnum fits in int.
4276 (compute_motion, Fcompute_motion):
4277 Use int, not EMACS_INT, when it is wide enough.
4278 (vmotion): Omit local var start_hpos that is always 0; that way
4279 we don't need to worry about overflow in expressions involving it.
4280 * indent.h: Adjust decls to match defn changes elsewhere.
4281 (struct position):
4282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4283 Use int, not EMACS_INT, where int is wide enough.
4284 Remove unused members ovstring_chars_done and tab_offset;
4285 all uses removed.
4286 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4287 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4288 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4289 (make_gap, copy_text, insert, insert_and_inherit)
4290 (insert_before_markers, insert_before_markers_and_inherit)
4291 (insert_1, count_combining_before, count_combining_after)
4292 (insert_1_both, insert_from_string)
4293 (insert_from_string_before_markers, insert_from_string_1)
4294 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4295 (adjust_after_replace, adjust_after_insert, replace_range)
4296 (replace_range_2, del_range, del_range_1, del_range_byte)
4297 (del_range_both, del_range_2, modify_region)
4298 (prepare_to_modify_buffer, signal_before_change)
4299 (signal_after_change, Fcombine_after_change_execute):
4300 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4301 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4302 (balance_an_interval, split_interval_right, split_interval_left)
4303 (find_interval, next_interval, update_interval)
4304 (adjust_intervals_for_insertion, delete_node, delete_interval)
4305 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4306 (static_offset_intervals, offset_intervals)
4307 (merge_interval_right, merge_interval_left, make_new_interval)
4308 (graft_intervals_into_buffer, temp_set_point_both)
4309 (temp_set_point, set_point, adjust_for_invis_intang)
4310 (set_point_both, move_if_not_intangible, get_property_and_range)
4311 (get_local_map, copy_intervals, copy_intervals_to_string)
4312 (compare_string_intervals, set_intervals_multibyte_1):
4313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4314 * intervals.h: Adjust decls to match defn changes elsewhere.
4315 (struct interval):
4316 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4317 * keyboard.c (this_command_key_count, this_single_command_key_start)
4318 (before_command_key_count, before_command_echo_length, echo_now)
4319 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4320 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4321 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4322 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4324 (last_non_minibuf_size, last_point_position, echo_truncate)
4325 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4326 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4327 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4328 (stuff_buffered_input):
4329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4330 (last_auto_save, command_loop_1, read_char):
4331 Use EMACS_INT, not int, to avoid integer overflow.
4332 (record_char): Avoid overflow in total_keys computation.
4333 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4334 * keyboard.h: Adjust decls to match defn changes elsewhere.
4335 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4336 (Fkey_description, Fdescribe_vector, Flookup_key):
4337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4338 (click_position): New function, to check that positions are in range.
4339 (Fcurrent_active_maps):
4340 (describe_command):
4341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4342 (Faccessible_keymaps, Fkey_description):
4343 (preferred_sequence_p):
4344 Don't assume fixnum can fit into int.
4345 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4346 Check for integer overflow in size calculations.
4347 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4348 avoid mishandling large integers.
4349 * lisp.h: Adjust decls to match defn changes elsewhere.
4350 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4351 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4352 (struct Lisp_Marker):
4353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4354 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4355 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4356 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4357 All callers changed.
4358 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4359 Assume the arg has valid form, since it always does.
4360 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4361 unsigned integer system type.
4362 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4363 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4364 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4365 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4366 (duration_to_sec_usec): New decl.
4367 * lread.c (read_from_string_index, read_from_string_index_byte)
4368 (read_from_string_limit, readchar, unreadchar, openp)
4369 (read_internal_start, read1, oblookup):
4370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4371 (Fload, readevalloop, Feval_buffer, Feval_region):
4372 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4373 (openp): Check for out-of-range argument to 'access'.
4374 (read1): Use int, not EMACS_INT, where int is wide enough.
4375 Don't assume fixnum fits into int.
6efdadfd 4376 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4377 (read_filtered_event): Use duration_to_sec_usec
4378 to do proper overflow checking on durations.
d311d28c
PE
4379 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4380 in size calculation.
4381 (Fexecute_kbd_macro):
4382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4383 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4384 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4385 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4386 (set_marker_both, set_marker_restricted_both, marker_position)
4387 (marker_byte_position, Fbuffer_has_markers_at):
4388 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4389 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4390 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4391 It now merely ensures that the menu is large enough, without
4392 necessarily growing it, as this avoids some integer overflow issues.
4393 All callers changed.
4394 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4395 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4396 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4397 Use SAFE_ALLOCA_LISP, not alloca.
4398 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4399 to EMACS_INT. Check that fixnums are in proper range for system types.
4400 * minibuf.c (minibuf_prompt_width, string_to_object)
4401 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4402 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4404 (get_minibuffer, read_minibuf_unwind):
4405 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4406 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4407 this simplifies overflow checking. All callers changed.
4408 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4409 (Ftest_completion):
4410 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4411 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4412 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4413 Check that fixnums are in proper range for system types.
4414 (Fx_create_frame, Fx_show_tip):
4415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4416 * nsfont.m (ns_findfonts, nsfont_list_family):
4417 Don't assume fixnum fits in long.
4418 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4419 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4420 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4421 wide enough.
17fdb222 4422 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4424 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4425 (PRINTDECLARE, PRINTPREPARE):
4426 (strout, print_string):
4427 (print, print_preprocess, print_check_string_charset_prop)
4428 (print_object):
4429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4430 (PRINTDECLARE):
4431 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4433 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4434 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4435 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4436 (print_error_message): Use SAFE_ALLOCA, not alloca.
4437 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4438 (print_depth, new_backquote_output, print_number_index):
4439 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4440 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4441 (Fset_process_window_size, Fformat_network_address)
4442 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4443 (sigchld_handler):
d311d28c 4444 Check that fixnums are in proper range for system types.
d44287d4 4445 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4446 Check for process-ids out of pid_t range rather than relying on
4447 undefined behavior.
e4d81efc 4448 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4449 (Fformat_network_address, read_process_output, send_process)
4450 (Fprocess_send_region, status_notify):
4451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4452 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4453 (wait_reading_process_output, read_process_output, exec_sentinel):
4454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4455 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4456 (Faccept_process_output): Use duration_to_sec_usec to do proper
4457 overflow checking on durations.
dde14581
PE
4458 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4459 Don't assume pid_t fits in int.
02481186
PE
4460 * process.h (struct Lisp_Process): Members tick and update_tick
4461 are now of type EMACS_INT, not int.
b62b53e8
PE
4462 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4463 configured --with-wide-int.
d311d28c
PE
4464 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4465 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4466 * search.c (looking_at_1, string_match_1):
4467 (fast_string_match, fast_c_string_match_ignore_case)
4468 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4469 (scan_newline, find_before_next_newline, search_command)
4470 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4471 (set_search_regs, wordify):
4472 (Freplace_match):
4473 (Fmatch_data):
4474 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4475 (string_match_1, search_buffer, set_search_regs):
4476 (Fmatch_data):
4477 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4478 (wordify): Check for overflow in size calculation.
4479 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4480 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4481 Check that fixnums are in proper range for system types.
4482 * sound.c (struct sound_device)
4483 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4485 (Fplay_sound_internal):
4486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4487 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4488 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4489 (Fparse_partial_sexp):
4490 Don't assume fixnums can fit in int.
4491 (struct lisp_parse_state, find_start_pos, find_start_value)
4492 (find_start_value_byte, find_start_begv)
4493 (update_syntax_table, char_quoted, dec_bytepos)
4494 (find_defun_start, prev_char_comend_first, back_comment):
4495 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4496 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4498 (Finternal_describe_syntax_value): Check that match_lisp is a
4499 character, not an integer, since the code stuffs it into int.
4500 (scan_words, scan_sexps_forward):
4501 Check that fixnums are in proper range for system types.
4502 (Fforward_word):
4503 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4504 (scan_sexps_forward):
4505 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4506 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4507 * syntax.h: Adjust decls to match defn changes elsewhere.
4508 (struct gl_state_s):
4509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4510 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4511 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4512 * sysdep.c (wait_for_termination_1, wait_for_termination)
4513 (interruptible_wait_for_termination, mkdir):
4514 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4515 (emacs_read, emacs_write):
4516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4517 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4518 and double all fit in int.
d311d28c
PE
4519 * term.c (set_tty_color_mode):
4520 Check that fixnums are in proper range for system types.
4521 * termhooks.h (struct input_event):
4522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4523 * textprop.c (validate_interval_range, interval_of)
4524 (Fadd_text_properties, set_text_properties_1)
4525 (Fremove_text_properties, Fremove_list_of_text_properties)
4526 (Ftext_property_any, Ftext_property_not_all)
4527 (copy_text_properties, text_property_list, extend_property_ranges)
4528 (verify_interval_modification):
4529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4530 (Fnext_single_char_property_change)
4531 (Fprevious_single_char_property_change):
4532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4533 (copy_text_properties):
4534 Check for integer overflow in index calculation.
d311d28c
PE
4535 * undo.c (last_boundary_position, record_point, record_insert)
4536 (record_delete, record_marker_adjustment, record_change)
4537 (record_property_change):
4538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4539 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4541 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4542 (Fx_hide_tip, Fx_file_dialog):
4543 * w32menu.c (set_frame_menubar):
4544 Use ptrdiff_t, not int, for consistency with rest of code.
4545 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4546 (select_window, Fdelete_other_windows_internal)
4547 (window_scroll_pixel_based, window_scroll_line_based)
4548 (Frecenter, Fset_window_configuration):
4549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4550 (Fset_window_hscroll, run_window_configuration_change_hook)
4551 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4552 (Fscroll_other_window, Frecenter):
d311d28c
PE
4553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4554 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4555 Don't assume fixnum fits in int.
4556 (Fset_window_scroll_bars):
4557 Check that fixnums are in proper range for system types.
4558 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4559 (string_pos, c_string_pos, number_of_chars, init_iterator)
4560 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4561 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4562 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4563 (face_before_or_after_it_pos, handle_invisible_prop)
4564 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4565 (display_prop_intangible_p, string_buffer_position_lim)
4566 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4567 (get_overlay_strings_1, get_overlay_strings)
4568 (iterate_out_of_display_property, forward_to_next_line_start)
4569 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4570 (get_next_display_element, set_iterator_to_next)
4571 (get_visually_first_element, compute_stop_pos_backwards)
4572 (handle_stop_backwards, next_element_from_buffer)
4573 (move_it_in_display_line_to, move_it_in_display_line)
4574 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4575 (add_to_log, message_dolog, message_log_check_duplicate)
4576 (message2, message2_nolog, message3, message3_nolog
4577 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4578 (current_message_1, truncate_echo_area, truncate_message_1)
4579 (set_message, set_message_1, store_mode_line_noprop)
4580 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4581 (text_outside_line_unchanged_p, check_point_in_composition)
4582 (reconsider_clip_changes)
4583 (redisplay_internal, set_cursor_from_row, try_scrolling)
4584 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4585 (redisplay_window, find_last_unchanged_at_beg_row)
4586 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4587 (trailing_whitespace_p, find_row_edges, display_line)
4588 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4589 (display_mode_element, store_mode_line_string)
4590 (pint2str, pint2hrstr, decode_mode_spec)
4591 (display_count_lines, display_string, draw_glyphs)
4592 (x_produce_glyphs, x_insert_glyphs)
4593 (rows_from_pos_range, mouse_face_from_buffer_pos)
4594 (fast_find_string_pos, mouse_face_from_string_pos)
4595 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4596 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4597 (safe_call, init_from_display_pos, handle_fontified_prop)
4598 (handle_single_display_spec, load_overlay_strings)
4599 (with_echo_area_buffer, setup_echo_area_for_printing)
4600 (display_echo_area, echo_area_display)
4601 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4602 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4603 (redisplay_window, dump_glyph_row, display_mode_line)
4604 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4605 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4607 (handle_single_display_spec, build_desired_tool_bar_string)
4608 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4609 (get_specified_cursor_type):
4610 Check that fixnums are in proper range for system types.
4611 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4612 (Flookup_image_map):
4613 Don't assume fixnums fit in int.
4614 (compare_overlay_entries):
4615 Avoid mishandling comparisons due to subtraction overflow.
4616 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4617 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4618 (handle_tool_bar_click):
4619 Use int, not unsigned, since we prefer signed and the signedness
4620 doesn't matter here.
4621 (get_next_display_element, next_element_from_display_vector):
4622 Use int, not EMACS_INT, when int is wide enough.
4623 (start_hourglass): Use duration_to_sec_usec to do proper
4624 overflow checking on durations.
4625 * xfaces.c (Fbitmap_spec_p):
4626 Check that fixnums are in proper range for system types.
4627 (compare_fonts_by_sort_order):
4628 Avoid mishandling comparisons due to subtraction overflow.
4629 (Fx_family_fonts, realize_basic_faces):
4630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4631 (Fx_family_fonts):
4632 Don't assume fixnum fits in int.
4633 Use SAFE_ALLOCA_LISP, not alloca.
4634 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4635 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4636 (face_at_buffer_position, face_for_overlay_string)
4637 (face_at_string_position):
4638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4639 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4640 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4641 (Fx_show_tip):
4642 Check that fixnums are in proper range for system types.
4643 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4644 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4646 (Fx_change_window_property): Don't assume fixnums fit in int.
4647 * xfont.c (xfont_chars_supported):
4648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4649 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4650 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4652 * xml.c (parse_region):
4653 * xrdb.c (magic_file_p):
4654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4655 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4656 (x_get_local_selection, x_reply_selection_request)
4657 (x_handle_selection_request, wait_for_property_change):
4658 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4659 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4660 short is wide enough.
4661 (x_send_client_event): Don't assume fixnum fits in int.
4662 * xterm.c (x_x_to_emacs_modifiers):
4663 Don't assume EMACS_INT overflows nicely into int.
4664 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4665 may come from Lisp.
4666 (handle_one_xevent): NATNUMP can eval its arg twice.
4667 (x_connection_closed):
4668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4669 * xterm.h: Adjust decls to match defn changes elsewhere.
4670 (struct scroll_bar): Use struct vectorlike_header
4671 rather than rolling our own approximation.
4672 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4673
c6574eb5
GM
46742012-05-25 Glenn Morris <rgm@gnu.org>
4675
4676 * lisp.mk (lisp): Update for more files being compiled now.
4677
e8d32c7e
SM
46782012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4679
48def666
SM
4680 * lread.c: Remove `read_pure' which makes no difference.
4681 (read_pure): Remove var.
4682 (unreadpure): Remove function.
4683 (readevalloop): Don't call read_list with -1 flag.
4684 (read1, read_vector): Don't test read_pure any more.
4685 (read_list): Simplify.
4686
e8d32c7e
SM
4687 * fileio.c, character.h: Minor style tweaks.
4688
4b2addb7
DA
46892012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4690
4691 * window.h (clip_changed): Remove useless declaration.
4692
584461b2
JB
46932012-05-22 Juanma Barranquero <lekktu@gmail.com>
4694
4695 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4696 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4697
34374650
PE
46982012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4699
4700 Remove src/m/*.
4701 This directory predates autoconf and is no longer needed nowadays.
4702 Move its few remaining bits of functionality to where they're needed.
4703 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4704 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4705 * m/template.h: Remove.
4706 * Makefile.in (M_FILE): Remove. All uses removed.
4707 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4708 * lisp.h (USE_LSB_TAG):
4709 * mem-limits.h (EXCEEDS_LISP_PTR):
4710 Use VAL_MAX, not VALBITS, in #if.
4711 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4712 (EMACS_UINT): Define unconditionally now.
4713 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4714 (BITS_PER_EMACS_INT): New constants, replacing
4715 what used to be in config.h, but not useful in #if.
4716 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4717 define them any more.
4718 (VAL_MAX): New macro.
4719 (VALMASK): Use it.
4720 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4721 BITS_PER_EMACS_INT, in #if.
4722 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4723 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4724 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4725 * s/ms-w32.h (DATA_START):
4726 Move here from removed file m/intel386.h.
4727 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4728 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4729
261cb4bb
PE
47302012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4731
4732 Assume C89 or later.
4733 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4734 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4735 (xrealloc):
4736 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4737 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4738 * textprop.c, tparam.c (NULL): Remove.
4739 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4740 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4741 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4742 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4743 * xterm.c (input_signal_count): Assume volatile works.
4744
ff23cd9f
KB
47452012-05-21 Ken Brown <kbrown@cornell.edu>
4746
4747 * xgselect.c (xg_select): Fix first argument in call to 'select'
4748 (bug#11508).
4749
1b170bc6
KB
47502012-05-20 Ken Brown <kbrown@cornell.edu>
4751
4752 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4753 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4754
b2f4d39f
KB
47552012-05-19 Ken Brown <kbrown@cornell.edu>
4756
4757 * xfns.c (x_in_use): Remove `static' qualifier.
4758 * xterm.h (x_in_use): Declare.
4759 * xgselect.c: Include xterm.h.
4760 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4761 and `display_arg' (bug#9754).
4762
003fdae2
PE
47632012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4764
9232a6d9
PE
4765 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4766
003fdae2
PE
4767 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4768 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4769
784b56e2
EZ
47702012-05-18 Eli Zaretskii <eliz@gnu.org>
4771
4772 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4773
4774 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4775 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4776
4777 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4778 reference to image_cache->refcount.
4779 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4780
a0a79cde
JL
47812012-05-17 Juri Linkov <juri@jurta.org>
4782
4783 * search.c (Fword_search_regexp, Fword_search_backward)
4784 (Fword_search_forward, Fword_search_backward_lax)
4785 (Fword_search_forward_lax): Move functions to isearch.el
4786 (bug#10145, bug#11381).
4787
b0572523
PE
47882012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4789
4790 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4791
9660f5fc
SM
47922012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4793
4794 * lread.c (init_obarray): Declare Qt and Qnil as special.
4795
4374de83
GM
47962012-05-14 Glenn Morris <rgm@gnu.org>
4797
4798 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4799 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4800
dc44c39a
PE
48012012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4802
078c97cb
PE
4803 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4804
dc44c39a
PE
4805 * unexaix.c: Port to more-recent AIX compilers.
4806 (report_error, report_error_1, make_hdr, copy_sym)
4807 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4808 Make arguments const char *, not char *, to avoid violations of C
4809 standard and to fix some AIX warnings reported by Gilles Pion.
4810
e18afed7 48112012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4812
4813 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4814 already have overlays loaded.
4815 (handle_single_display_spec): Before returning without displaying
4816 fringe bitmap, synchronize the bidi iterator with the main display
4817 iterator, by calling iterate_out_of_display_property.
4818 (iterate_out_of_display_property): Detect buffer iteration by
4819 testing that it->string is a Lisp string.
4820 (get_next_display_element): When the current object is exhausted,
4821 and there's something on it->stack, call set_iterator_to_next to
4822 proceed with what's on the stack, instead of returning zero.
4823 (set_iterator_to_next): If called at the end of a Lisp string,
4824 proceed to consider_string_end without incrementing string
4825 position. Don't increment display vector index past the end of
4826 the display vector. (Bug#11417)
c8fb9dc6
EZ
4827 (pos_visible_p): Don't report a position visible when move_it_to
4828 stopped at the last line of window, which happens to be scanned
4829 backwards by the bidi iteration. (Bug#11464)
ac268e67 4830
e18afed7 48312012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4832
4833 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4834 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4835 are on a TTY, and thus unable to display on the fringes.
4836 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4837 so we need to signal to the caller that this is a "replacing"
4838 display spec. This fixes display when the spec is invalid or we
4839 are on a TTY.
4840
e18afed7 48412012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4842
4843 * unexaix.c (make_hdr): Fix typo in prototype.
4844 This bug broke the build on AIX. Problem reported by Gilles Pion.
4845
9d0a235a
MA
48462012-05-14 Michael Albinus <michael.albinus@gmx.de>
4847
4848 * keyboard.c (kbd_buffer_get_event): Read special events also in
4849 batch mode. (Bug#11415)
4850
9e6b06ed
GM
48512012-05-12 Glenn Morris <rgm@gnu.org>
4852
4853 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4854
c1a1d7a3
EZ
48552012-05-12 Eli Zaretskii <eliz@gnu.org>
4856
4857 * lisp.mk (lisp): Add newcomment.elc.
4858
3fe7cdc8
GM
48592012-05-12 Glenn Morris <rgm@gnu.org>
4860
4861 * Makefile.in (MKDIR_P): New, set by configure.
4862 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4863
53f7d2c0
PE
48642012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4865
4866 Remove unused function hourglass_started.
4867 * dispextern.h (hourglass_started):
4868 * w32fns.c (hourglass_started):
4869 * xdisp.c (hourglass_started): Remove.
4870
75aafb17
JB
48712012-05-10 Juanma Barranquero <lekktu@gmail.com>
4872
4873 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4874 Update dependencies.
4875
12959e8e
PE
48762012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4877
97107e2e
PE
4878 * xgselect.c (xg_select): Put maxfds+1 into a var.
4879 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4880
12959e8e
PE
4881 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4882
836d29b3
DA
48832012-05-10 Dave Abrahams <dave@boostpro.com>
4884
4885 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4886 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4887
5cb67954
MA
48882012-05-09 Michael Albinus <michael.albinus@gmx.de>
4889
4890 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4891 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4892 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4893 Initialize xd_registered_buses.
4894
3478ec45
PE
48952012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4896
b263a6b0
PE
4897 Untag more efficiently if USE_LSB_TAG.
4898 This is based on a proposal by YAMAMOTO Mitsuharu in
4899 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4900 For an admittedly artificial (nth 8000 longlist) benchmark on
4901 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4902 Emacs's overall text size by 1%.
4903 * lisp.h (XUNTAG): New macro.
4904 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4905 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4906 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4907 * eval.c (Fautoload):
4908 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4909 * frame.h (XFRAME): Use XUNTAG.
4910
3478ec45
PE
4911 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4912 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4913 Remove unportable assumptions about print widths of types like
4914 dbus_uint32_t.
4915 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4916 intptr_t when converting between pointer and integer, to avoid GCC
4917 warnings about wrong width.
4918
666b903b 49192012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4920
4921 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4922 stack for each reader_thread, instead of defaulting to 8MB
4923 determined by the linker. This avoids failures in creating
4924 subprocesses on Windows 7, see the discussion in this thread:
4925 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4926
b120cc17
JC
49272012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4928
4929 Fix up display of the *Minibuf-0* buffer in the mini window.
4930 * keyboard.c (read_char): Don't clear the echo area if there's no
4931 message to clear.
4932 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4933 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4934
9a4b36f8
MA
49352012-05-07 Michael Albinus <michael.albinus@gmx.de>
4936
4937 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4938 batch mode.
4939
e5f9458f
CY
49402012-05-06 Chong Yidong <cyd@gnu.org>
4941
4942 * lisp.mk (lisp): Update.
4943
eceeb5fc 49442012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4945
4946 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4947
71873e2b
SM
49482012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4949
4950 * data.c (PUT_ERROR): New macro.
4951 (syms_of_data): Use it. Add new error type `user-error'.
4952 * undo.c (user_error): New function.
4953 (Fprimitive_undo): Use it.
4954 * print.c (print_error_message): Adjust print style for `user-error'.
4955 * keyboard.c (user_error): New function.
4956 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4957
ab0fa4e4
PE
49582012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4959
4960 Do not limit current-time-string to years 1000..9999.
4961 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4962 (Fcurrent_time_string): Support any year that is supported by the
4963 underlying localtime representation. Don't use asctime, as it
4964 has undefined behavior for years outside the range -999..9999.
4965
7ed806a7
PE
49662012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4967
4968 Fix race conditions involving setenv, gmtime, localtime, asctime.
4969 Without this fix, interrupts could mess up code that uses these
4970 nonreentrant functions, since setting TZ invalidates existing
4971 tm_zone or tzname values, and since most of these functions return
4972 pointers to static storage.
4973 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4974 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4975 Grow the critical sections to include not just invoking
4976 localtime/gmtime, but also accessing these functions' results
4977 including their tm_zone values if any, and any related TZ setting.
4978 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4979 so that the struct tm is saved in the critical section.
4980 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4981 motivated by the fact that memory allocation needs to be outside
4982 the critical section.
4983
0c16dfed
DA
49842012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4985
4986 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4987 with RESET_INTERVAL.
4988
4989 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4990 Remove duplicated buffer name initialization.
4991
3f83ace8
JM
49922012-05-02 Jim Meyering <jim@meyering.net>
4993
4994 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4995
c7b8541e
JM
4996 * xfns.c (x_window): Use xstrdup (Bug#11375).
4997
90207a15 49982012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4999
5000 * xdisp.c (pos_visible_p): If already at a newline from the
5001 display string before the 'while' loop, don't walk back the glyphs
5002 from it3.glyph_row. Solves assertion violation when the display
5003 string begins with a newline (egg.el). (Bug#11367)
5004
b593d6a9
AH
50052012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5006
5007 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5008 Move to simple.el.
5009
4737362e
GM
50102012-05-01 Glenn Morris <rgm@gnu.org>
5011
99cf43f9
GM
5012 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5013 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5014 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5015 All were removed before 23.1.
5016
9311dcff
GM
5017 * dispnew.c: Remove HAVE_LIBNCURSES test;
5018 it is always true on relevant platforms.
5019
4d5c6349
GM
5020 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5021 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5022
4737362e
GM
5023 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5024
74dd3a6b
AS
50252012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5026
5027 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5028 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5029 Remove.
5030
13c379ee
PE
50312012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5032
5033 Do not avoid creating empty evaporating overlays (Bug#9642).
5034 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5035 That is, do not delete an evaporating overlay if it becomes
5036 empty after its bounds are adjusted to fit within its buffer.
5037 This fix caused other problems, and I'm reverting it until we get
5038 to the bottom of them.
5039
a8e7d6d7 50402012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5041
5042 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5043
a8e7d6d7 50442012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5045
5046 * xdisp.c (pos_visible_p): If the window start position is beyond
5047 ZV, start the display from buffer beginning. Prevents assertion
5048 violation in init_iterator when the minibuffer window is scrolled
5049 via the scroll bar.
5050
5051 * window.c (window_scroll_pixel_based): Likewise.
5052
a8e7d6d7 50532012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5054
5055 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5056
a8e7d6d7 50572012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5058
5059 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5060 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5061
a8e7d6d7 50622012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5063
b593d6a9
AH
5064 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5065 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5066
1c6900d9
EZ
50672012-04-26 Eli Zaretskii <eliz@gnu.org>
5068
4c3fa1d9
EZ
5069 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5070 display element, check also the underlying string or buffer
5071 character. (Bug#11341)
5072
1c6900d9
EZ
5073 * w32menu.c: Include w32heap.h.
5074 (add_menu_item): If the call to AppendMenuW (via
5075 unicode_append_menu) fails, disable Unicode menus only if we are
5076 running on Windows 9X/Me.
5077
42bf8205
AS
50782012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5079
5080 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5081 (xgetint): Add missing shift for LSB tags.
5082
b1bac16e
MR
50832012-04-24 Martin Rudalics <rudalics@gmx.at>
5084
5085 * keyboard.c (read_char): Don't wipe echo area for select window
5086 events: These might get delayed via `mouse-autoselect-window'
5087 (Bug#11304).
5088
d69621cc
JB
50892012-04-24 Juanma Barranquero <lekktu@gmail.com>
5090
5091 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5092 manipulation of :loaded-from data.
5093
02fd101b
JB
50942012-04-23 Juanma Barranquero <lekktu@gmail.com>
5095
5096 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5097 now a cons (bug#11311).
5098
888bec30
PE
50992012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5100
89a438bd
PE
5101 Do not create empty overlays with the evaporate property (Bug#9642).
5102 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5103 if it becomes empty after its bounds are adjusted to fit within
5104 its buffer. Without this fix, in a nonempty buffer (let ((o
5105 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5106 yields an empty overlay that has the evaporate property, which is
5107 not supposed to happen.
5108
1068fe4d
PE
5109 Fix minor GTK3 problems found by static checking.
5110 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5111 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5112 (struct _EmacsFixedClass, emacs_fixed_get_type):
5113 Move decls here from emacsgtkfixed.h, since they needn't be public.
5114 (emacs_fixed_get_type): Now static.
5115 (emacs_fixed_class_init): Omit unused local.
5116 (emacs_fixed_child_type): Remove; unused.
5117 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5118 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5119 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5120 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5121 (EMACS_FIXED_GET_CLASS): Remove; unused.
5122 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5123
888bec30
PE
5124 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5125 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5126
de85e130
PE
51272012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5128
d0baac98 5129 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5130 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5131 (__malloc_size_t, __malloc_ptrdiff_t):
5132 Remove. All uses removed, replaced by the definiens if needed,
5133 since we can assume C89 or better now.
5134 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5135 (protect_malloc_state, align, get_contiguous_space)
5136 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5137 (malloc_atfork_handler_child, malloc_enable_thread)
5138 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5139 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5140 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5141 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5142 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5143 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5144 Define using prototypes, not old style.
5145 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5146 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5147 (align): Don't assume that signed integer overflow wraps around.
5148 Omit unused local var.
5149 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5150 (_free_internal_nolock, memalign, mallochook, reallochook):
5151 Omit no-longer-needed casts.
5152 (valloc): Use getpagesize, not __getpagesize.
5153 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5154 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5155
de85e130
PE
5156 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5157
dcbf5805
MA
51582012-04-22 Michael Albinus <michael.albinus@gmx.de>
5159
5160 Move functions from C to Lisp. Make non-blocking method calls
5161 the default. Implement further D-Bus standard interfaces.
5162
5163 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5164 (QCdbus_request_name_allow_replacement)
5165 (QCdbus_request_name_replace_existing)
5166 (QCdbus_request_name_do_not_queue)
5167 (QCdbus_request_name_reply_primary_owner)
5168 (QCdbus_request_name_reply_in_queue)
5169 (QCdbus_request_name_reply_exists)
5170 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5171 (QCdbus_registered_serial, QCdbus_registered_method)
5172 (QCdbus_registered_signal): New Lisp objects.
5173 (XD_DEBUG_MESSAGE): Use sizeof.
5174 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5175 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5176 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5177 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5178 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5179 (xd_signature, xd_append_arg): Allow float for integer types.
5180 (xd_get_connection_references): New function.
b593d6a9
AH
5181 (xd_get_connection_address): Rename from xd_initialize.
5182 Return cached address.
dcbf5805
MA
5183 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5184 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5185 level.
5186 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5187 Return number of refcounts.
dcbf5805
MA
5188 (Fdbus_get_unique_name): Make stronger parameter check.
5189 (Fdbus_message_internal): New defun.
5190 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5191 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5192 (Fdbus_send_signal, Fdbus_register_service)
5193 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5194 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5195 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5196 (Vdbus_compiled_version, Vdbus_runtime_version)
5197 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5198 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5199 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5200 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5201 Adapt docstring.
dcbf5805 5202
52828e02
PE
52032012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5204
da05bc4c
PE
5205 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5206 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5207 Do not assume ptrdiff_t is the same width as 'int'.
5208
52828e02
PE
5209 * alloc.c: Handle unusual debugging option combinations.
5210 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5211 since the two debugging options are incompatible.
5212 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5213 is defined.
5214 (mem_init, mem_insert, mem_insert_fixup):
5215 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5216 (NEED_MEM_INSERT): Remove; no longer needed.
5217
f01769f9
LL
52182012-04-22 Leo Liu <sdl.web@gmail.com>
5219
5220 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5221
5790543d
PE
52222012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5223
5224 * sysdep.c [__FreeBSD__]: Minor cleanups.
5225 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5226 Use Emacs indenting style more consistently. Avoid some casts.
5227 Use 'double' consistently rather than mixing 'float' and 'double'.
5228
b91b7e4d
EW
52292012-04-21 Eduard Wiebe <usenet@pusto.de>
5230
b593d6a9
AH
5231 * sysdep.c (list_system_processes, system_process_attributes):
5232 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5233
6114eb15
AS
52342012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5235
5236 * lisp.mk (lisp): Update.
5237
2f38dff7
PE
52382012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5239
5240 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5241 It is never used otherwise.
5242
4ae29f89
SM
52432012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5244
5245 * print.c (print_preprocess): Only check print_depth if print-circle
5246 is nil.
5247 (print_object): Check for cycles even when print-circle is nil and
5248 print-gensym is t, but only check print_depth if print-circle is nil.
5249
f30d612a
CY
52502012-04-20 Chong Yidong <cyd@gnu.org>
5251
5252 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5253 set the status to "failed" and ensure that sentinel is run.
5254
c07a4c0b 52552012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5256
5257 * process.c (Fset_process_inherit_coding_system_flag)
5258 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5259 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5260
c07a4c0b 52612012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5262
5263 * xdisp.c (string_buffer_position_lim): Limit starting position to
5264 BEGV.
5265 (set_cursor_from_row): If called for a mode-line or header-line
5266 row, return zero immediately.
5267 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5268 farther than the first row after the header line, if any.
5269 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5270 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5271
c07a4c0b 52722012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5273
4ae29f89
SM
5274 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5275 (bug#11238).
ad3a2b41 5276
c07a4c0b 52772012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 52782012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5279
5280 configure: new option --enable-gcc-warnings (Bug#11207)
5281 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5282 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5283 (ALL_CFLAGS): Use new macros rather than old.
5284 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5285 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5286 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5287 -Wunused-result, -Wunused-variable. This should go away once
5288 the Emacs and Gnulib regex code is merged.
5289 (xmalloc, xrealloc): Now static.
5290
aba027e8
PE
52912012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5292
5293 * dired.c (Fsystem_groups): Remove unused local.
5294
e5a36063
GM
52952012-04-17 Glenn Morris <rgm@gnu.org>
5296
5297 * dired.c (Fsystem_users): Doc fix.
5298
316411f0
DA
52992012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5300
5301 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5302 (syms_of_dired): Add them.
5303
9426aba4
PE
53042012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5305
b62a57be
PE
5306 Fix minor alloc.c problems found by static checking.
5307 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5308 New extern decls, to avoid calling undeclared functions.
5309 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5310 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5311 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5312 (NEED_MEM_INSERT): New macro.
5313 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5314 Remove one incorrect comment and fix another.
b62a57be 5315
3539f31f
PE
5316 Fix minor ralloc.c problems found by static checking.
5317 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5318 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5319 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5320 (r_alloc_sbrk): Now static.
5321
a041960a
PE
5322 Improve ralloc.c interface checking.
5323 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5324 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5325 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5326 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5327 [REL_ALLOC]: ... to here, to check interface.
5328 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5329 Remove decls. This fixes an "It stinks!".
5330
9426aba4
PE
5331 * alloc.c (which_symbols): Fix alignment issue / type clash.
5332
d55c12ed
AS
53332012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5334
5335 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5336 (struct Lisp_Misc_Any): Likewise.
5337 (struct Lisp_Free): Likewise.
5338 * alloc.c (union aligned_Lisp_Symbol): Define.
5339 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5340 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5341 (union aligned_Lisp_Misc): Define.
5342 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5343 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5344 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5345
b948ce8b
PE
53462012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5347
5348 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5349 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5350 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5351 * s/netbsd.h, s/sol2-6.h:
5352 Remove definition of GC_MARK_STACK, since the default now works.
5353 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5354 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5355 no longer the default.
5356 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5357
35dc09a1 53582012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5359
35dc09a1
GM
5360 * lread.c (lisp_file_lexically_bound_p):
5361 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5362
35dc09a1
GM
53632012-04-14 Eli Zaretskii <eliz@gnu.org>
5364
5365 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5366 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5367
53682012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5369
5370 * nsterm.m (constrainFrameRect): Always constrain when there is only
5371 one screen (Bug#10962).
5372
bcd86815
KB
53732012-04-13 Ken Brown <kbrown@cornell.edu>
5374
5375 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5376
c25df26e
RT
53772012-04-13 Reuben Thomas <rrt@sc3d.org>
5378
5379 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5380
0fc59f1e
DC
53812012-04-11 Daniel Colascione <dancol@dancol.org>
5382
5383 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5384 against is gone. It's better to use vfork now so that when Cygwin
5385 gains a new, working vfork, we use it automatically (bug#10398).
5386
de8c03dc
SM
53872012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5388
5389 * window.c (save_window_save): Obey window-point-insertion-type.
5390
2f097256
GM
53912012-04-11 Glenn Morris <rgm@gnu.org>
5392
5393 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5394
453b951e
SM
53952012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5396
5397 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5398
75f1671a 53992012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5400
5401 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5402 (force_quit_count): New var.
5403 (handle_interrupt): Use it.
5404
2a8ce227
JB
54052012-04-10 Juanma Barranquero <lekktu@gmail.com>
5406
5407 * w32.c (w32_delayed_load): Record the full path of the library
5408 being loaded (bug#10424).
5409
935396c0
GM
54102012-04-09 Glenn Morris <rgm@gnu.org>
5411
05920a43
GM
5412 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5413 not just in the obarray, before snarfing them. (Bug#11036)
5414
935396c0
GM
5415 * Makefile.in ($(leimdir)/leim-list.el):
5416 Pass EMACS rather than BUILT_EMACS.
5417
a18ecafa
TZ
54182012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5419
5420 * process.c (make_process):
5421 * process.h: Add integer `gnutls_handshakes_tried' member to
5422 process struct.
5423
6bbef4e5
JC
5424 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5425 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5426
5427 * gnutls.c (gnutls_log_function2i): Convenience log function.
5428 (emacs_gnutls_read): Use new log functions,
5429 `gnutls_handshakes_tried' process member, and
5430 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5431 attempts per process (connection).
5432
b4d3bc10
CY
54332012-04-09 Chong Yidong <cyd@gnu.org>
5434
5435 * eval.c (Fuser_variable_p, user_variable_p_eh)
5436 (lisp_indirect_variable): Functions deleted.
5437 (Fdefvar): Caller changed.
5438
5439 * callint.c (Finteractive, Fcall_interactively):
5440 * minibuf.c (Fread_variable): Callers changed.
5441
70f4d973
EZ
54422012-04-09 Eli Zaretskii <eliz@gnu.org>
5443
5444 * xdisp.c (set_cursor_from_row): If the display string appears in
5445 the buffer at position that is closer to point than the position
5446 after the display string, display the cursor on the first glyph of
5447 the display string. Fixes cursor display when a 'display' text
5448 property immediately follows invisible text. (Bug#11094)
5449
cb3c2e3e
PE
54502012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5451
5452 composite.c: use 'double' consistently
5453 * composite.c (get_composition_id): Use 'double' consistently
5454 instead of converting 'float' to 'double' and vice versa; this is
5455 easier to understand and avoids a GCC warning.
5456
fd06db5d
GM
54572012-04-09 Glenn Morris <rgm@gnu.org>
5458
50fe702a
GM
5459 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5460 preparation for dumping it with emacs. (Bug#4789)
5461 (leimdir): New variable.
5462 ($(leimdir)/leim-list.el): New rule.
5463 (emacs$(EXEEXT)): Depend on leim-list.el.
5464
fd06db5d
GM
5465 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5466 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5467 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5468
55c131ee
AS
54692012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5470
5471 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5472 proper alignment.
5473
9209588f
JB
54742012-04-07 Juanma Barranquero <lekktu@gmail.com>
5475
5476 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5477 Remove unused local variable.
5478
e3fb2efb
PE
54792012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5480
5481 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5482 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5483 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5484 objects, as mark_maybe_pointer will catch them otherwise.
5485 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5486 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5487
b5385551
PE
54882012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5489
5490 Fix typo that broke non-Windows builds.
5491 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5492
9078ead6
EZ
54932012-04-07 Eli Zaretskii <eliz@gnu.org>
5494
5495 Support building on MS-Windows with libxml2.
5496
5497 * makefile.w32-in (OBJ2): Add xml.$(O).
5498 (GLOBAL_SOURCES): Add xml.c.
5499 ($(BLD)/xml.$(O)): New dependency list.
5500
5501 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5502 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5503 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5504 [!WINDOWSNT]: New macros.
5505 (init_libxml2_functions, libxml2_loaded_p): New functions.
5506 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5507 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5508 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5509 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5510 linked in).
6bbef4e5
JC
5511 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5512 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5513 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5514
5515 * emacs.c: Don't include libxml/parser.h.
5516 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5517 xmlCleanupParser directly.
5518
5519 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5520
3811fdf3
EZ
55212012-04-07 Eli Zaretskii <eliz@gnu.org>
5522
5523 * indent.c (Fvertical_motion): If there is a display string at
5524 point, use it.vpos to compute how many lines to backtrack after
5525 move_it_to point. (Bug#11133)
5526
2f8e16b2
EZ
55272012-04-06 Eli Zaretskii <eliz@gnu.org>
5528
5529 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5530 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5531 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5532 macros related to unification of CJK characters. For the details,
5533 see the discussion following the message here:
5534 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5535
3d439cd1
CY
55362012-04-04 Chong Yidong <cyd@gnu.org>
5537
5538 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5539
8bc53d00
EZ
55402012-04-01 Eli Zaretskii <eliz@gnu.org>
5541
5542 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5543 instead of alloca. (Bug#11138)
5544
3b0512a3
AS
55452012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5546
5547 * w32menu.c (is_simple_dialog): Properly check lisp types.
5548 (Bug#11141)
5549
8427ddd2
EZ
55502012-03-31 Eli Zaretskii <eliz@gnu.org>
5551
979022ef
EZ
5552 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5553 position we get to after a call to move_it_to fails the
5554 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5555 only if we wind up in a string from display property. (Bug#11063)
5556
a6b1c7cc
EZ
5557 * window.c (Fdelete_other_windows_internal): Invalidate the row
5558 and column information about mouse highlight, so that redisplay
5559 restores it after reallocating the glyph matrices. (Bug#7464)
5560
8427ddd2
EZ
5561 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5562 string comes from a `display' text property, use the buffer
5563 position of that property as if we actually saw that position in
5564 the row's glyphs.
697ba24b
EZ
5565 (move_it_by_lines): Remove the assertion that
5566 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5567 violated when there's a before-string at the beginning of a line.
5568 (Bug#11063)
8427ddd2 5569
65a0a738
EZ
55702012-03-30 Eli Zaretskii <eliz@gnu.org>
5571
5572 * xdisp.c (append_space_for_newline): If the default face was
5573 remapped, use the remapped face for the appended newline.
5574 (extend_face_to_end_of_line): Use the remapped default face for
5575 extending the face to the end of the line.
5576 (display_line): Call extend_face_to_end_of_line when the default
5577 face was remapped. (Bug#11068)
5578
581355cc
EZ
55792012-03-29 Eli Zaretskii <eliz@gnu.org>
5580
5581 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5582
e8fc049f
SM
55832012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5584
5585 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5586
4fb9a543
GM
55872012-03-27 Glenn Morris <rgm@gnu.org>
5588
5589 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5590 Doc fixes.
5591
679910f1
KH
55922012-03-26 Kenichi Handa <handa@m17n.org>
5593
5594 * dispextern.h (struct glyph): Fix previous change. Change the
5595 bit length of glyphless.ch to 25 (Bug#11082).
5596
90d49b7f
CY
55972012-03-26 Chong Yidong <cyd@gnu.org>
5598
5599 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5600 (command_loop_1): Use it; inhibit selection update for
5601 handle-select-window too (Bug#8996).
5602
f514f6f0
FP
56032012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5604
e8fc049f 5605 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5606
bf43fa51
KH
56072012-03-25 Kenichi Handa <handa@m17n.org>
5608
5609 * dispextern.h (struct glyph): Change the bit length of
5610 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5611
8a0c01dd
EZ
56122012-03-24 Eli Zaretskii <eliz@gnu.org>
5613
5614 * s/ms-w32.h (tzname): Include time.h before redirecting to
5615 _tzname. Fixes the MSVC build. (Bug#9960)
5616
7d1c3a76
AS
56172012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5618
8ed79523
AS
5619 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5620 characters.
5621
7d1c3a76
AS
5622 * xterm.c (XTread_socket): Only modify handling_signal if
5623 !SYNC_INPUT. (Bug#11080)
5624
e99a9b8b
EZ
56252012-03-23 Eli Zaretskii <eliz@gnu.org>
5626
5627 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5628 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5629 when fetching a multibyte character consumes more bytes than
5630 CHAR_BYTES returns, due to unification of CJK characters in
5631 string_char. (Bug#11073)
5632
5063c0e1
TN
56332012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5634
5635 * process.c (wait_reading_process_output): Handle pty disconnect
5636 by refraining from sending oneself a SIGCHLD (bug#10933).
5637
9f851fbd
CY
56382012-03-22 Chong Yidong <cyd@gnu.org>
5639
5640 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5641
5063c0e1 5642 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5643 Mark string as coming from a prefix property.
5644 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5645 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5646
fb5b8aca
CY
56472012-03-21 Chong Yidong <cyd@gnu.org>
5648
5649 * xfaces.c (Vface_remapping_alist): Doc fix.
5650
62356a1b
EZ
56512012-03-20 Eli Zaretskii <eliz@gnu.org>
5652
5653 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5654 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5655 Doc fixes.
62356a1b 5656
025de85b
CY
56572012-03-20 Chong Yidong <cyd@gnu.org>
5658
5659 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5660 to reflect default non-nil value of redisplay-dont-pause.
5661
4827f94e
KH
56622012-03-19 Kenichi Handa <handa@m17n.org>
5663
5664 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5665 it fit in a valid range (Bug#11003).
5666
e50a24a2
EZ
56672012-03-18 Eli Zaretskii <eliz@gnu.org>
5668
5669 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5670 that is not from display property, accept the row as a "cursor
5671 row" if one of the string's character has a non-nil `cursor'
5672 property. Fixes cursor positioning when there are newlines in
5673 overlay strings, e.g. in icomplete.el. (Bug#11035)
5674
9af5ed87
PE
56752012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5676
5677 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5678
d1f55f16
CY
56792012-03-12 Chong Yidong <cyd@gnu.org>
5680
5681 * eval.c (inhibit_lisp_code): Rename from
5682 inhibit_window_configuration_change_hook; move from window.c.
5683
5684 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5685 * window.c (run_window_configuration_change_hook)
5686 (syms_of_window): Callers changed.
5687
66c5eebd
CY
56882012-03-11 Chong Yidong <cyd@gnu.org>
5689
413df973
CY
5690 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5691
66c5eebd
CY
5692 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5693
1de11f56
CY
56942012-03-10 Chong Yidong <cyd@gnu.org>
5695
5696 * frame.c (other_visible_frames): Don't assume the selected frame
5697 is visible (Bug#10955).
5698
cae07000
SM
56992012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5700
5701 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5702
89c94350
JD
57032012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5704
5705 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5706 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5707 zero (Bug#10954).
5708
999dd333
GM
57092012-03-03 Glenn Morris <rgm@gnu.org>
5710
01a6dcc8 5711 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5712
de0100f2
EZ
57132012-03-02 Eli Zaretskii <eliz@gnu.org>
5714
5715 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5716 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5717 (redisplay_window, next_element_from_string): Fix typos in
5718 comments.
3e441275
EZ
5719 (redisplay_window): Pass to move_it_vertically the margin in
5720 pixels, not in screen lines.
de0100f2 5721
96a72ee9
GM
57222012-03-02 Glenn Morris <rgm@gnu.org>
5723
5724 * buffer.c (buffer-list-update-hook): Doc fix.
5725
312508d7
EZ
57262012-02-29 Eli Zaretskii <eliz@gnu.org>
5727
5728 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5729 push_it before setting up the iterator for the first overlay
5730 string, even if we have an empty string loaded.
5731 (next_overlay_string): If there's an empty string on the iterator
5732 stack, pop the stack. (Bug#10903)
5733
27f3c637
PE
57342012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5735
5736 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5737 Suggested by Stefan Monnier in
5738 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5739 * alloc.c (widen_to_Lisp_Object): New static function.
5740 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5741 and widening them to Lisp_Objects. This would work even if
5742 USE_LSB_TAG is defined and wide integers are used, which might
5743 happen in a future version of Emacs.
5744
3c9dfce6
CY
57452012-02-25 Chong Yidong <cyd@gnu.org>
5746
fa74b241
CY
5747 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5748 Doc fix.
5749
3c9dfce6
CY
5750 * xselect.c (Fx_selection_exists_p): Doc fix.
5751 (x_clipboard_manager_save_all): Print an informative message
5752 before saving to clipboard manager.
5753
9486df08
CY
57542012-02-24 Chong Yidong <cyd@gnu.org>
5755
5756 * keyboard.c (process_special_events): Handle all X selection
5757 requests in kbd_buffer, not just the next one (Bug#8869).
5758
f01d3321
CY
57592012-02-23 Chong Yidong <cyd@gnu.org>
5760
5761 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5762 call when setting menu-bar-lines and tool-bar-lines parameters.
5763 (unwind_create_frame_1): New helper function.
5764
5765 * window.c (inhibit_window_configuration_change_hook): New var.
5766 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5767 (syms_of_window): Initialize it.
f01d3321 5768
86b847b6
CY
57692012-02-22 Chong Yidong <cyd@gnu.org>
5770
5771 * xterm.c (x_draw_image_relief): Add missing type check for
5772 Vtool_bar_button_margin (Bug#10743).
5773
a59225b1
CY
57742012-02-21 Chong Yidong <cyd@gnu.org>
5775
5776 * fileio.c (Vfile_name_handler_alist): Doc fix.
5777
5778 * buffer.c (Fget_file_buffer): Protect against invalid file
5779 handler return value.
5780
310f5bd4
PE
57812012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5782
cb3a28cc
PE
5783 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5784 when computing $valmask.
5785
310f5bd4
PE
5786 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5787 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5788 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5789 It's useless in that case, and it can cause problems on hosts
5790 that allocate halves of EMACS_INT values separately.
5791 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5792 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5793 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5794 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5795 it avoids undefined behavior on hosts where shifting right by more
5796 than the word width has undefined behavior.
5797
2375c96a
CY
57982012-02-19 Chong Yidong <cyd@gnu.org>
5799
5800 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5801 (Funhandled_file_name_directory, Ffile_name_as_directory)
5802 (Fdirectory_file_name, Fexpand_file_name)
5803 (Fsubstitute_in_file_name): Protect against invalid file handler
5804 return values (Bug#10845).
5805
3eb49e71
EZ
58062012-02-18 Eli Zaretskii <eliz@gnu.org>
5807
5808 * .gdbinit (pitx): Fix incorrect references to fields of the
5809 iterator stack.
5810
7b926f3f
CY
58112012-02-17 Chong Yidong <cyd@gnu.org>
5812
5813 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5814
11273115
PE
58152012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5816
5817 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5818 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5819
c3a70e2b
CY
58202012-02-15 Chong Yidong <cyd@gnu.org>
5821
5822 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5823 marked as special. Also, starting docstrings with * is obsolete.
5824
0ca43699
AS
58252012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5826
5827 * gnutls.c (emacs_gnutls_write): Fix last change.
5828
2e8f3c56
LI
58292012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5830
5831 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5832 send_process.
5833
af70074f
SM
58342012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5835
5836 * keymap.c (Fsingle_key_description): Handle char ranges.
5837
95986d52
CY
58382012-02-12 Chong Yidong <cyd@gnu.org>
5839
afd83bd1
CY
5840 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5841 as that creates a dangerous corner case.
5842
95986d52
CY
5843 * window.c (Fdelete_window_internal): Invalidate the mouse
5844 highlight (Bug#9904).
5845
bd7da63e
GM
58462012-02-12 Glenn Morris <rgm@gnu.org>
5847
5848 * xselect.c (Fx_own_selection_internal)
5849 (Fx_get_selection_internal, Fx_disown_selection_internal)
5850 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5851 * nsselect.m (Fx_own_selection_internal)
5852 (Fx_disown_selection_internal, Fx_selection_exists_p)
5853 (Fx_selection_owner_p, Fx_get_selection_internal):
5854 Sync docs and argument specs with the xselect.c versions.
5855
77abcbc2
LI
58562012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5857
5858 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5859
90b671e2
EZ
58602012-02-11 Eli Zaretskii <eliz@gnu.org>
5861
1c0ca0b7
EZ
5862 * w32select.c (Fx_selection_exists_p): Sync doc string and
5863 argument list with xselect.c. (Bug#10783)
5864
5865 * w16select.c (Fx_selection_exists_p): Sync doc string and
5866 argument list with xselect.c. (Bug#10783)
90b671e2 5867
49241268
GM
58682012-02-10 Glenn Morris <rgm@gnu.org>
5869
5870 * fns.c (Fsecure_hash): Doc fix.
5871
f998bbe7 58722012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5873
5874 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5875
0992bd9c
CY
58762012-02-07 Chong Yidong <cyd@gnu.org>
5877
5878 * buffer.c (Fbuffer_local_variables)
5879 (buffer_lisp_local_variables): Handle unbound vars correctly;
5880 don't let Qunbound leak into Lisp.
5881
af008560
GM
58822012-02-07 Glenn Morris <rgm@gnu.org>
5883
dd605cc4
GM
5884 * image.c (Fimagemagick_types): Doc fix.
5885
af008560
GM
5886 * image.c (imagemagick-render-type): Change it from a lisp object
5887 to an integer. Move the doc here from the lisp manual.
5888 Treat all values not equal to 0 the same.
5889
1449fa1d
CY
58902012-02-06 Chong Yidong <cyd@gnu.org>
5891
5892 * doc.c (store_function_docstring): Avoid applying docstring of
5893 alias to base function (Bug#2603).
5894
3723ec07
AS
58952012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5896
5897 * .gdbinit (pp1, pv1): Remove redundant defines.
5898 (pr): Use pp.
5899
79c1cc1e
CY
59002012-02-04 Chong Yidong <cyd@gnu.org>
5901
5902 * nsterm.m: Declare a global (Bug#10694).
5903
d7f29f8e
EZ
59042012-02-04 Eli Zaretskii <eliz@gnu.org>
5905
cae07000
SM
5906 * w32.c (get_emacs_configuration_options):
5907 Include --enable-checking, if specified, in the return value.
d7f29f8e 5908
3b95a6f9
MR
59092012-02-04 Martin Rudalics <rudalics@gmx.at>
5910
5911 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5912 after rounding frame sizes. (Bug#9723)
5913
d6fa96a6
EZ
59142012-02-04 Eli Zaretskii <eliz@gnu.org>
5915
5916 * keyboard.c (adjust_point_for_property): Don't position point
5917 before BEGV. (Bug#10696)
5918
df0b2940
PE
59192012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5920
5921 Handle overflow when computing char display width (Bug#9496).
5922 * character.c (char_width): Return EMACS_INT, not int.
5923 (char_width, c_string_width): Check for overflow when
5924 computing the width; this is possible now that individual
5925 characters can have unbounded width. Problem introduced
5926 by merge from Emacs 23 on 2012-01-19.
5927
6bee44d6
MA
59282012-02-02 Michael Albinus <michael.albinus@gmx.de>
5929
5930 * dbusbind.c (Fdbus_register_method): Mention the return value
5931 :ignore in the docstring.
5932
44f92739
GM
59332012-02-02 Glenn Morris <rgm@gnu.org>
5934
1b9f60cc
GM
5935 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5936
44f92739
GM
5937 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5938 Unconditionally set to t. (Bug#10673)
5939 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5940 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5941 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5942
c5d3843c
KH
59432012-02-02 Kenichi Handa <handa@m17n.org>
5944
5945 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5946 0, do not call append_composite_glyph.
5947
159462d4 59482012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5949
5950 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5951 NULL (Bug#6988).
5952 (x_produce_glyphs): If the component of a composition is a null
5953 string, set it->pixel_width to 1 to avoid zero-width glyph.
5954
78cef877
EZ
59552012-02-01 Eli Zaretskii <eliz@gnu.org>
5956
5957 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5958 first 2 arguments are identical. This makes inserting large
5959 output from a subprocess an order of magnitude faster on
5960 MS-Windows, where all sbrk'ed memory is always contiguous.
5961
97897668
GM
59622012-01-31 Glenn Morris <rgm@gnu.org>
5963
5964 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5965 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5966 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5967
31fd3586
GM
59682012-01-29 Glenn Morris <rgm@gnu.org>
5969
5970 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5971
0e24a8b2
CY
59722012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5973
5974 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5975
cc0adcb0
CY
59762012-01-28 Chong Yidong <cyd@gnu.org>
5977
5978 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5979
acc28cb9
CY
59802012-01-26 Chong Yidong <cyd@gnu.org>
5981
9c69cfb7
CY
5982 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5983
acc28cb9
CY
5984 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5985 repeat counts (Bug#10507).
5986
48da7392
GM
59872012-01-26 Glenn Morris <rgm@gnu.org>
5988
5989 * lread.c (syms_of_lread): Doc fix.
5990
14af5f7f
CY
59912012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5992
5993 * coding.c (encode_designation_at_bol): Change return value to
5994 EMACS_INT.
5995
0b21c100
CY
59962012-01-25 Chong Yidong <cyd@gnu.org>
5997
5998 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5999
3c2907f7
CY
60002012-01-21 Chong Yidong <cyd@gnu.org>
6001
6002 * floatfns.c (Fcopysign): Make the second argument non-optional,
6003 since nil is not allowed anyway.
6004
959ad23f
AS
60052012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6006
6007 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6008 (send_process): Likewise.
6009
34a02f46
MR
60102012-01-19 Martin Rudalics <rudalics@gmx.at>
6011
6012 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6013 (Vwindow_persistent_parameters): Do not use Qstate.
6014 Rewrite doc-strings.
34a02f46 6015
1259009a 60162012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6017
6018 * character.c (char_width): New function.
70d4fdf6
GM
6019 (Fchar_width, c_string_width, lisp_string_width):
6020 Use char_width (Bug#9496).
25ed9e61 6021
6a6ee00d
MR
60222012-01-16 Martin Rudalics <rudalics@gmx.at>
6023
6024 * window.c (Vwindow_persistent_parameters): New variable.
6025 (Fset_window_configuration, save_window_save): Handle persistent
6026 window parameters.
6027
c85efaf7
EZ
60282012-01-14 Eli Zaretskii <eliz@gnu.org>
6029
6030 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6031 thrashing the stack of the thread. (Bug#9087)
6032
5944709e
PE
60332012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6034
6035 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6036
e71f5d99
EZ
60372012-01-11 Eli Zaretskii <eliz@gnu.org>
6038
6039 * xdisp.c (rows_from_pos_range): Handle the case where the
6040 highlight ends on a newline. (Bug#10464)
6041 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6042 he end column for display of highlight that ends on a newline
6043 before a R2L line.
6044
ce316182
GM
60452012-01-11 Glenn Morris <rgm@gnu.org>
6046
6047 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6048 from load-path also when installation-directory is nil. (Bug#10208)
6049
5b43da69
GM
60502012-01-10 Glenn Morris <rgm@gnu.org>
6051
74cc8ff9
GM
6052 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6053
7d8d6e4e
GM
6054 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6055 Update template values to be closer to their typical values these days.
5b43da69 6056
a0db8d43
EZ
60572012-01-09 Eli Zaretskii <eliz@gnu.org>
6058
6059 * xdisp.c (rows_from_pos_range): Accept additional argument
6060 DISP_STRING, and accept any glyph in a row whose object is that
6061 string as eligible for mouse highlight. Fixes mouse highlight of
6062 display strings from overlays. (Bug#10464)
6063
9a0115ab 60642012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6065
b9110d6a 6066 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6067 * fileio.c (auto_saving_dir_umask): New static var.
6068 (Fmake_directory_internal): Use it.
6069 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6070 creating the directory. The old code temporarily assigns
6071 too-generous permissions to the directory.
6072 (do_auto_save_eh): Clear it.
b9110d6a 6073 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6074 that the var is always cleared.
6075
6c1bd3f3
EZ
60762012-01-07 Eli Zaretskii <eliz@gnu.org>
6077
6078 * search.c (scan_buffer): Pass character positions to
6079 know_region_cache, not byte positions. (Bug#6540)
6080
069d2b50
L
60812012-01-07 LynX <_LynX@bk.ru> (tiny change)
6082
6083 * w32.c (sys_rename): Report EXDEV when rename of a directory
6084 fails because the target is on another logical disk. (Bug#10284)
6085
75bf0d33
DB
60862012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6087
6088 * xterm.c (x_embed_request_focus): New function.
6089
6090 * xterm.h: Add prototype.
6091
6092 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6093
1c6e5a32
GM
60942012-01-05 Glenn Morris <rgm@gnu.org>
6095
6096 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6097
651e947e
EZ
60982012-01-01 Eli Zaretskii <eliz@gnu.org>
6099
6100 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6101 Load gnutls_transport_set_lowat only if GnuTLS version is below
6102 2.11.1.
6103 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6104 GnuTLS versions below 2.11.1.
6105
3778cdd8
AL
61062011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6107
6108 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6109 to the doc string advising against its use for altering the way
6110 windows are scrolled.
6111
0e5317f7
KH
61122011-12-28 Kenichi Handa <handa@m17n.org>
6113
6114 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6115 coding-system ASCII compatible only when it does not produce BOM
6116 on encoding (Bug#10383).
6117
93d5ca1f
JD
61182011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6119
6120 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6121 can scroll.
6122 (create_and_show_popup_menu): Always use menu_position_func for
6123 Gtk3 (Bug#10361).
6124
ca22b785
AS
61252011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6126
6127 * callint.c (Fcall_interactively): Don't truncate prompt string.
6128
d048e1e6
EZ
61292011-12-23 Eli Zaretskii <eliz@gnu.org>
6130
6131 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6132 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6133 resumed from there (after widening). (Bug#10360)
d048e1e6 6134
5ccaba1f
JD
61352011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6136
6137 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6138
204ee57f
JD
61392011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6140
b81d40f0
JB
6141 * nsterm.m (x_free_frame_resources):
6142 Release f->output_data.ns->miniimage.
204ee57f
JD
6143 (ns_index_color): Fix indentation. Do not retain
6144 color_table->colors[i].
6145
6146 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6147 before returning.
6148
6149 * nsfns.m (x_set_background_color): Assign return value from
6150 ns_index_color to face-background instead of NSColor*.
6151 (ns_implicitly_set_icon_type): Fix indentation.
6152 Change assignment in for loop to comparison.
6153
6154 * emacs.c (ns_pool): New variable.
6155 (main): Assign ns_pool.
6156 (Fkill_emacs): Call ns_release_autorelease_pool.
6157
6158 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6159 autorelease fdesc, release fdAttrs and tdict.
6160 (ns_get_covering_families): Release charset.
6161 (ns_findfonts): Release NSFontDescriptor created with new.
6162 (ns_uni_to_glyphs): Fix indentation.
6163 (setString): Release attrStr before assigning new value.
6164
c803b2b7
JD
61652011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6166
678f4426
JD
6167 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6168 and NS_IMPL_COCOA.
6169 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6170 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6171
cd394be1 61722011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6173
5fecd5fc
JD
6174 * nsterm.m (ns_term_init): Subscribe for notifications
6175 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6176 to method trackingNotification in EmacsMenu.
6177
6178 * nsmenu.m (trackingMenu): New variable.
3771cb17 6179 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6180 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6181 from Aquamacs (Bug#7030).
678f4426
JD
6182
61832011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6184
c803b2b7
JD
6185 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6186 (symbol_to_nsstring): Fix indentation.
6187 (ns_symbol_to_pb): New function.
cae07000
SM
6188 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6189 (Fns_rotate_cut_buffers_internal): Remove.
6190 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6191 Fns_store_cut_buffer_internal.
6192 (ns_get_foreign_selection, Fx_own_selection_internal)
6193 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6194 (Fns_get_selection_internal, Fns_store_selection_internal):
6195 Use ns_symbol_to_pb and check if return value is nil.
6196 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6197 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6198 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6199 renamed to Sns_store_selection_internal.
6200 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6201 and remove this function.
6202 (ns_handle_selection_clear): Remove, never used.
6203 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6204 here.
6205
e1b01a3a
KB
62062011-12-17 Ken Brown <kbrown@cornell.edu>
6207
6208 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6209 GID is unknown (Bug#10257).
6210
2adb6e85
PE
62112011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6212
6213 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6214 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6215 which caused a build failure on GNU/Linux IA-64. This problem was
6216 introduced by my 2011-10-07 patch.
6217
d1d7b339
JL
62182011-12-15 Juri Linkov <juri@jurta.org>
6219
6220 * image.c (imagemagick_error): New function. (Bug#10112)
6221 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6222 Use `imagemagick_error' where ImageMagick functions return
6223 `MagickFalse'.
6224 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6225 proper order.
6226
100d5755
KH
62272011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6228
6229 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6230 fill background (Bug#8992).
6231
454592a6
MR
62322011-12-13 Martin Rudalics <rudalics@gmx.at>
6233
6234 * window.c (Vwindow_combination_resize)
6235 (Vwindow_combination_limit): Use t instead of non-nil in
6236 doc-strings.
61d4b438
MR
6237 (Vrecenter_redisplay): Add first sentence of doc-string on
6238 separate line.
53524d93 6239 (Frecenter): Fix doc-string typo.
454592a6 6240
3633e3aa
KH
62412011-12-11 Kenichi Handa <handa@m17n.org>
6242
6243 * coding.c (Funencodable_char_position): Pay attention to the
6244 buffer text relocation (Bug#9389).
6245
7b9d523a 62462011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6247
7b9d523a
JD
6248 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6249 gtk_init (Bug#10100).
6250
b73189c6
EZ
62512011-12-10 Eli Zaretskii <eliz@gnu.org>
6252
6253 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6254 IT->string is nil. (Bug#10263)
6255
f7dfe5d6
JD
62562011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6257
83faebb4
JD
6258 * nsterm.h (x_free_frame_resources): Declare.
6259
f7dfe5d6
JD
6260 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6261 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6262
6263 * nsterm.h (ns_get_defaults_value): Declare.
6264
6265 * nsterm.m (ns_default): Call ns_get_defaults_value.
6266
7cd4e72c
EZ
62672011-12-09 Eli Zaretskii <eliz@gnu.org>
6268
6269 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6270 (Bug#10170)
6271
b34d7317
YM
62722011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6273
6274 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6275 that where the value of an _OBJC_* symbol points to is in the .bss
6276 section (Bug#10240).
6277
76470ad1
KH
62782011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6279
6280 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6281 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6282
745fff94
KH
62832011-12-08 Kenichi Handa <handa@m17n.org>
6284
6285 * ftfont.c (get_adstyle_property): Fix previous change
6286 (Bug#10233).
6287
6e44397c
JB
62882011-12-07 Juanma Barranquero <lekktu@gmail.com>
6289
6290 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6291 dirs from the default value of EMACSLOADPATH (bug#10208).
6292
7efa6272
GM
62932011-12-07 Glenn Morris <rgm@gnu.org>
6294
6295 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6296 installation and source directories as well. (Bug#10208)
6297
f6fc4d87
CY
62982011-12-06 Chong Yidong <cyd@gnu.org>
6299
6300 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6301
2bf26180
GM
63022011-12-06 Glenn Morris <rgm@gnu.org>
6303
6304 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6305 as an error, not just -1. (Bug#10217)
6306
3a6ad4f0
CY
63072011-12-05 Chong Yidong <cyd@gnu.org>
6308
6309 * keyboard.c (process_special_events): New function.
6310 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6311
75a3b399
PE
63122011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6313
6314 * coding.c (encode_designation_at_bol): Don't use uninitialized
6315 local variable (Bug#9318).
6316
c3c9e25e
KH
63172011-12-05 Kenichi Handa <handa@m17n.org>
6318
6319 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6320 return Qnil (Bug#8046, Bug#10193).
6321
5eb05ea3
KH
63222011-12-05 Kenichi Handa <handa@m17n.org>
6323
6324 * coding.c (encode_designation_at_bol): New args charbuf_end and
6325 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6326 (coding_set_source): Return how many bytes coding->source was
6327 relocated.
6328 (coding_set_destination): Return how many bytes
6329 coding->destination was relocated.
6330 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6331 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6332
63332011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6334
6335 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6336 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6337 macro (Bug#9318).
6338
63392011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6340
6341 The following changes are to fix Bug#9318.
6342
a79703f5 6343 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6344 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6345 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6346 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6347
7dbda6df
JB
63482011-12-05 Juanma Barranquero <lekktu@gmail.com>
6349
6350 * lisp.h (process_quit_flag): Fix external declaration.
6351
6d5eb5b0
SM
63522011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6353
6354 Don't macro-inline non-performance-critical code.
6355 * eval.c (process_quit_flag): New function.
6356 * lisp.h (QUIT): Use it.
6357
a0c3fad0
JD
63582011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6359
6360 * nsfns.m (get_geometry_from_preferences): New function.
6361 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6362
6c07aac2
AS
63632011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6364
6365 * emacs.c (Qkill_emacs): Define.
6366 (syms_of_emacs): Initialize it.
6367 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6368 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6369 (quit_throw_to_read_char): Add parameter `from_signal'.
6370 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6371 * lisp.h (QUIT): Call Fkill_emacs if requested.
6372
c052ead4
JD
63732011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6374
6375 * widget.c (update_wm_hints): Return if wmshell is null.
6376 (widget_update_wm_size_hints): New function.
6377
6378 * widget.h (widget_update_wm_size_hints): Declare.
6379
6380 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6381 widget_update_wm_size_hints (Bug#10104).
6382
9e49252b
EZ
63832011-12-03 Eli Zaretskii <eliz@gnu.org>
6384
6385 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6386 before a newline, prepare the bidi iterator for consuming the
6387 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6388 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6389
02b16839
JL
63902011-12-02 Juri Linkov <juri@jurta.org>
6391
6392 * search.c (Fword_search_regexp): New Lisp function created from
6393 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6394 (Fword_search_backward, Fword_search_forward)
6395 (Fword_search_backward_lax, Fword_search_forward_lax):
6396 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6397 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6398
0068070e
SM
63992011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6400
6401 * fileio.c (Finsert_file_contents): Move after-change-function call
6402 to before the "handled:" label, since all "goto handled" appear in
6403 cases where the *-change-functions have already been properly called
6404 (bug#10117).
6405
3360a3fc
AS
64062011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6407
6408 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6409 waiting for input. (Bug#10169)
6410
73d6c093
EZ
64112011-11-30 Eli Zaretskii <eliz@gnu.org>
6412
6413 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6414 verifies glyph row's hash code--we have just reallocated the
6415 glyphs, so their contents can be complete garbage. (Bug#10164)
6416
febe6bea
JB
64172011-11-30 Juanma Barranquero <lekktu@gmail.com>
6418
6419 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6420
801a4313
EZ
64212011-11-30 Eli Zaretskii <eliz@gnu.org>
6422
6423 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6424 attributes are tested _before_ calling verify_row_hash, to protect
6425 against GCC re-ordering of the tests. (Bug#10164)
6426
2b56b87e
JD
64272011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6428
6429 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6430
6431 * xterm.c (handle_one_xevent): Only set async_visible and friends
6432 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6433 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6434 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6435
dbf31225
PE
64362011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6437
6438 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6439 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6440 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6441 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6442 All uses changed to use GCPRO1 etc.
6443 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6444 Revert to old implementation (i.e., before 2011-03-11).
6445
1305621b
YM
64462011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6447
6448 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6449 of scroll runs so as to avoid assigning disabled bogus rows and
6450 unnecessary graphics copy operations.
6451
8c9afb46
EZ
64522011-11-27 Eli Zaretskii <eliz@gnu.org>
6453
6454 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6455 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6456 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6457 (malloc, free, realloc, calloc): Redirect to e_* only when
6458 compiling Emacs.
6459
6460 * lisp.h (GCTYPEBITS): Move before first use.
6461 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6462 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6463 this macro definition.
6464
6465 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6466 _MSC_VER.
6467
54e9e3bf
JD
64682011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6469
6d5eb5b0
SM
6470 * gtkutil.c (xg_create_frame_widgets):
6471 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6472 present with Gtk+ 2.0.
6473
83aca1cb
PE
64742011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6475
6476 * fileio.c (Finsert_file_contents): Undo previous change; see
6477 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6478
5b76caa4
PE
64792011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6480
6481 Rename locals to avoid shadowing.
6482 * fileio.c (Finsert_file_contents):
6483 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6484 * process.c (wait_reading_process_output):
6485 Rename inner 'proc' to 'p' to avoid shadowing.
6486 Indent for consistency with usual Emacs style.
6487
8c535114
EZ
64882011-11-25 Eli Zaretskii <eliz@gnu.org>
6489
6490 * xdisp.c (redisplay_window): If cursor row is not fully visible
6491 after recentering, and scroll-conservatively is set to a large
6492 number, scroll window by a few more lines to make the cursor fully
6493 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6494 (start_display): Don't move to the next line if the display should
6495 start at a newline that is part of a display vector or an overlay
6496 string. (Bug#10119)
8c535114 6497
fa4fdb5c
JL
64982011-11-24 Juri Linkov <juri@jurta.org>
6499
6500 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6501 after the `MagickPingImage' call. (Bug#10112)
6502
90ec88df
CY
65032011-11-23 Chong Yidong <cyd@gnu.org>
6504
6505 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6506
56e2e794
MR
65072011-11-23 Martin Rudalics <rudalics@gmx.at>
6508
6509 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6510 making another buffer current. (Bug#10114)
6511
b6e64c41
GM
65122011-11-23 Glenn Morris <rgm@gnu.org>
6513
6514 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6515
6b21de18
CY
65162011-11-23 Chong Yidong <cyd@gnu.org>
6517
6518 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6519 using it (Bug#5984).
6520
b12cd789
EZ
65212011-11-22 Eli Zaretskii <eliz@gnu.org>
6522
6523 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6524 and header-lines, as they don't have one computed for them.
6525 (Bug#10098)
6526
6527 * .gdbinit (prow): Make displayed values more self-explaining.
6528 Add row's hash code.
6529
261b6fd4
LMI
65302011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6531
6532 * process.c (wait_reading_process_output): Fix asynchrounous
6533 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6534 (wait_reading_process_output): Add comment and URL.
261b6fd4 6535
e7cfd277
JD
65362011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6537
6538 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6539
a9b9b7f5
CY
65402011-11-21 Chong Yidong <cyd@gnu.org>
6541
6542 * window.c (Fnext_window, Fprevious_window): Doc fix.
6543
b0d15b4f
SM
65442011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6545
6546 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6547
fe7a3057
JB
65482011-11-20 Juanma Barranquero <lekktu@gmail.com>
6549
6550 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6551
d2999b1a
MR
65522011-11-20 Martin Rudalics <rudalics@gmx.at>
6553
6554 * window.c (Fset_window_combination_limit): Rename argument
6555 STATUS to LIMIT.
6556 (Vwindow_combination_limit): Remove "status" from doc-string.
6557
d5ff9cd0
AS
65582011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6559
6560 * m/ibms390.h: Remove.
6561 * m/ibms390x.h: Don't include "ibms390.h".
6562
a5bb9bd3
SM
65632011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6564
6565 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6566 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6567
cd1181db
JB
65682011-11-20 Juanma Barranquero <lekktu@gmail.com>
6569
6570 * casetab.c (Fset_case_table):
6571 * charset.c (Fcharset_after): Fix typos.
6572
615a3b8d 65732011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6574
17e845af
PE
6575 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6576 Otherwise, valgrind does not work on some platforms.
6577 Problem reported by Andreas Schwab in
6a0bf43d
PE
6578 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6579 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6580 is set, removing the need for VIRT_ADDRESS_VARIES.
6581 (PURE_P): Use a more-efficient implementation that needs just one
6582 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6583 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6584 to 4 (xorl, subq, cmpq, setbe).
6585 * alloc.c (pure): Always extern now, since that's the
6586 VIRT_ADDR_VARIES behavior.
6587 (PURE_POINTER_P): Use a single comparison, not two, for
6588 consistency with the new puresize.h.
6589 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6590 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6591 Remove VIRT_ADDR_VARIES no longer needed.
6592
f8fe6f96
EZ
65932011-11-19 Eli Zaretskii <eliz@gnu.org>
6594
6595 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6596 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6597 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6598 behave as if the cursor position were at the window margin.
6599
6600 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6601 and the cursor position is out of bounds, behave as if the cursor
6602 position were at the window margin. (Bug#10075)
6603
df05a53c
CY
66042011-11-18 Chong Yidong <cyd@gnu.org>
6605
6606 * window.c (Fwindow_combination_limit): Make first argument
6607 non-optional, since it is meaningless for live windows like the
6608 selected window.
61ccba97 6609
2071918e
DA
66102011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6611
6612 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6613
b50a28de
SM
66142011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6615
6616 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6617 (graft_intervals_into_buffer): Simplify.
6618
015137db
EZ
66192011-11-18 Eli Zaretskii <eliz@gnu.org>
6620
6621 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6622 hash values of the two rows.
6623 (copy_row_except_pointers): Preserve the used[] arrays and the
6624 hash values of the two rows. (Bug#10035)
68c95424 6625 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6626
6627 * xdisp.c (row_hash): New function, body extracted from
6628 compute_line_metrics.
6629 (compute_line_metrics): Call row_hash, instead of computing the
6630 hash code inline.
6631
6632 * dispnew.c (verify_row_hash): Call row_hash for computing the
6633 hash code of a row, instead of duplicating code from xdisp.c.
6634
6635 * dispextern.h (row_hash): Add prototype.
6636
a2addb04
TH
66372011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6638
6639 * frame.c (delete_frame): Don't delete the terminal when the last
6640 X frame is closed if emacs is built with GTK toolkit.
6641
df85d315
JB
66422011-11-17 Juanma Barranquero <lekktu@gmail.com>
6643
6644 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6645
a0c2d0ae
MR
66462011-11-17 Martin Rudalics <rudalics@gmx.at>
6647
6648 * window.c (Vwindow_splits): Rename to
6649 Vwindow_combination_resize. Suggested by Juri Linkov.
6650 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6651 of Vwindow_splits.
6652
58179cce
JB
66532011-11-16 Juanma Barranquero <lekktu@gmail.com>
6654
7877f373
JB
6655 * nsfns.m (Fns_font_name):
6656 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6657
b6f67890
MR
66582011-11-16 Martin Rudalics <rudalics@gmx.at>
6659
6660 * window.h (window): Rename slot "nest" to "combination_limit".
6661 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6662 (Fset_window_nest): Rename to Fset_window_combination_limit.
6663 (Vwindow_nest): Rename to Vwindow_combination_limit.
6664 (recombine_windows, make_parent_window, make_window)
6665 (Fsplit_window_internal, saved_window)
6666 (Fset_window_configuration, save_window_save): Rename all
6667 occurrences of window_nest to window_combination_limit.
6668
c7015153
JB
66692011-11-15 Juanma Barranquero <lekktu@gmail.com>
6670
6671 * image.c (imagemagick_load_image): Fix typo.
6672
322ad6ec
EZ
66732011-11-14 Eli Zaretskii <eliz@gnu.org>
6674
6675 * xdisp.c (display_line): Move the call to
6676 highlight_trailing_whitespace before the call to
6677 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6678 faces of all the glyphs to compute ROW's hash value.
6679 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6680
f067b8ec
JB
66812011-11-14 Juanma Barranquero <lekktu@gmail.com>
6682
6683 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6684 just return (bug#10044).
6685
1e5b2111
EZ
66862011-11-12 Eli Zaretskii <eliz@gnu.org>
6687
7ef3cbd5
EZ
6688 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6689 with user-defined heap size. Bump the default size of the temacs
6690 heap to 27MB, to avoid memory warning when running temacs.
6691 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6692
1e5b2111
EZ
6693 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6694 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6695 (verify_row_hash) [XASSERTS]: New function.
6696 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6697 that the hash value of glyph rows is correct.
1e5b2111 6698
89d61221
MR
66992011-11-12 Martin Rudalics <rudalics@gmx.at>
6700
6701 * window.h (window): Remove splits slot.
6702 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6703 (Fdelete_other_windows_internal, make_parent_window)
6704 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6705 (Fset_window_configuration, save_window_save): Don't deal with
6706 split status of windows.
6707 (saved_window): Remove splits slot.
6708 (Vwindow_splits): Rewrite doc-string.
6709
97f18cc8
JD
67102011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6711
6712 * xfns.c (unwind_create_frame):
6713 * nsfns.m (unwind_create_frame):
6714 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6715 Vframe_list (Bug#9999).
6716
22a648b4
DA
67172011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6718
0b381c7e 6719 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6720
659afede
KH
67212011-11-11 Kenichi Handa <handa@m17n.org>
6722
6723 * callproc.c (Fcall_process): Set the member dst_multibyte of
6724 process_coding.
6725
9ac0394b
KH
67262011-11-11 Johan Bockgård <bojohan@gnu.org>
6727
6728 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6729 avoid a crash (bug#9496).
6730
2fbdc249
CY
67312011-11-09 Chong Yidong <cyd@gnu.org>
6732
6733 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6734 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6735
ac6b1f81
PE
67362011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6737
6738 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6739
09db192c
PE
67402011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6741
6742 Avoid some portability problems by eschewing 'extern inline' functions.
6743 The trivial performance wins aren't worth the portability hassles; see
6744 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6745 et seq.
6746 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6747 (window_box_width, window_box_left, window_box_left_offset)
6748 (window_box_right, window_box_right_offset): Undo previous change,
6749 by removing the "extern"s.
6750 * intervals.c (adjust_intervals_for_insertion)
6751 (adjust_intervals_for_deletion): Undo previous change,
6752 making these static again.
6753 (offset_intervals, temp_set_point_both, temp_set_point)
6754 (copy_intervals_to_string): No longer inline.
6755 * xdisp.c (window_text_bottom_y, window_box_width)
6756 (window_box_height, window_box_left_offset)
6757 (window_box_right_offset, window_box_left, window_box_right)
6758 (window_box): No longer inline.
6759
105216ed
CY
67602011-11-08 Chong Yidong <cyd@gnu.org>
6761
6762 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6763 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6764 Signal an error if not a live window.
105216ed
CY
6765 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6766 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6767
ae9e237f
JB
67682011-11-07 Juanma Barranquero <lekktu@gmail.com>
6769
6770 * lisp.h (syms_of_abbrev): Remove declaration.
6771 Reported by CHENG Gao <chenggao@royau.me>.
6772
c7aa8333
EZ
67732011-11-07 Eli Zaretskii <eliz@gnu.org>
6774
6775 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6776 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6777 of temacs in GUI mode.
6778
be7f5545
MR
67792011-11-07 Martin Rudalics <rudalics@gmx.at>
6780
6781 * window.h: Declare delete_all_child_windows instead of
6782 delete_all_subwindows.
6783 * window.c (Fwindow_nest, Fset_window_nest)
6784 (Fset_window_new_total, Fset_window_new_normal)
6785 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6786 (delete_all_subwindows): Rename to delete_all_child_windows.
6787 (Fdelete_other_windows_internal, Fset_window_configuration):
6788 Call delete_all_child_windows instead of delete_all_subwindows.
6789 * frame.c (delete_frame): Call delete_all_child_windows instead
6790 of delete_all_subwindows.
6791
ca78dc43
PE
67922011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6793
6794 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6795 This is also needed for porting to any host where GC_MARK_STACK is
6796 not GC_MAKE_GCPROS_NOOPS.
6797 (which_symbols): Use it.
6798
a0241d01
KH
67992011-11-07 Kenichi Handa <handa@m17n.org>
6800
6801 * coding.c (coding_set_destination): Check coding->src_pos only
6802 when coding->src_object is a buffer (bug#9910).
6803
6804 * process.c (send_process): Set the member src_multibyte of coding
6805 to 0 (bug#9911) when sending a unibyte text.
6806
6807 * callproc.c (Fcall_process): Set the member src_multibyte of
6808 process_coding to 0 (bug#9912).
6809
a64bfdfa 68102011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6811
6812 * xmenu.c (cleanup_widget_value_tree): New function.
6813 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6814 calling free_menubar_widget_value_tree directly (Bug#9830).
6815
cb41b32a
PE
68162011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6817
6818 Fix some portability problems with 'inline'.
6819 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6820 (window_box_width, window_box_left, window_box_left_offset)
6821 (window_box_right, window_box_right_offset): Declare extern.
6822 Otherwise, these inline functions do not conform to C99 and
6823 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6824 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6825 * intervals.c (adjust_intervals_for_insertion)
6826 (adjust_intervals_for_deletion): Now extern, because otherwise the
6827 extern inline functions 'offset_intervals' couldn't refer to it.
6828 (static_offset_intervals): Remove.
6829 (offset_intervals): Rewrite using the old contents of
6830 static_offset_intervals. The old version didn't conform to C99
6831 because an extern inline function contained a reference to an
6832 identifier with static linkage.
6833
b7041366
AS
68342011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6835
6836 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6837 GC.
6838
88a37c4d
EZ
68392011-11-06 Eli Zaretskii <eliz@gnu.org>
6840
6841 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6842 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6843 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6844 return Qleft_to_right.
6845
49745b39
CY
68462011-11-06 Chong Yidong <cyd@gnu.org>
6847
6848 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6849 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6850 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6851 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6852 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6853 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6854 (Fwindow_vscroll): Doc fix.
6855 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6856 argument, since it makes no sense to pass a live window and for
6857 consistency with window-child.
6858
1f05cd82
CS
68592011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6860
6861 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6862 support MSVC.
6863
22610910
JR
68642011-11-05 Jason Rumney <jasonr@gnu.org>
6865
6866 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6867 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6868 fonts (Bug#6029).
6869 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6870 bitwise arithmetic preventing use of unicode-sip and non-truetype
6871 opentype fonts.
6872
a06776b2
EZ
68732011-11-05 Eli Zaretskii <eliz@gnu.org>
6874
3ad924ba
EZ
6875 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6876 "emacs"-only part.
6877
a06776b2
EZ
6878 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6879 initialization code to keep similarity to xfns.c after changes
6880 from 2011-11-05.
6881
c9e7db78
JD
68822011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6883
a97f8f3f
JD
6884 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6885 (unwind_create_frame): New function (Bug#9943).
6886 (Fx_create_frame): Restructure code to be more similar to the one in
6887 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6888 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6889 Move terminal->reference_count++ just before making the frame official
6890 (Bug#9943).
6891
6892 * nsterm.m (x_free_frame_resources): New function.
6893 (x_destroy_window): Move code to x_free_frame_resources.
6894
c9e7db78 6895 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6896 (Fx_create_frame, x_create_tip_frame):
6897 Move terminal->reference_count++ just before making the frame
75f1671a 6898 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6899 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6900
a6fc3b5c
EZ
69012011-11-05 Eli Zaretskii <eliz@gnu.org>
6902
6903 Support MSVC build with newer versions of Visual Studio.
6904 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6905 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6906 nt/gmake.defs.
6907
6908 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6909 which are not supported by MSVC.
6910 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6911 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6912 bitfields.
6913 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6914 types in bitfields.
6915 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6916
6917 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6918
58179cce 69192011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6920
6921 Support MSVC build with newer versions of Visual Studio.
6922 * w32.c: Don't include w32api.h for MSVC.
6923 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6924
6925 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6926 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6927 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6928 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6929 e_* cousins.
6930 (alloca) [_MSC_VER]: Define to _alloca.
6931
6932 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6933
6934 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6935
a58c13ed
EZ
69362011-11-04 Eli Zaretskii <eliz@gnu.org>
6937
6938 * xdisp.c (note_mouse_highlight): If either of
6939 previous/next-single-property-change returns nil, treat that as
6940 the beginning or the end of the buffer. (Bug#9955)
6941
fe0b6370
JD
69422011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6943
a58c13ed 6944 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6945 label is not null (Bug#9951).
6946 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6947 may be NULL.
6948
89bd5ee1
EZ
69492011-11-04 Eli Zaretskii <eliz@gnu.org>
6950
6951 * window.c (Fwindow_body_size): Mention in the doc string that the
6952 return value is in frame's canonical units. (Bug#9949)
6953
84c3edb9
EZ
69542011-11-03 Eli Zaretskii <eliz@gnu.org>
6955
4e2fb5c7
EZ
6956 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6957
84c3edb9 6958 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6959 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6960 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6961
bc17a887
EZ
69622011-11-01 Eli Zaretskii <eliz@gnu.org>
6963
6964 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6965 Don't stop backward scan on the continuation glyph, even though
6966 its CHARPOS is positive.
6d5eb5b0
SM
6967 (mouse_face_from_buffer_pos, note_mouse_highlight):
6968 Rename cover_string to disp_string.
bc17a887 6969
4ee88440
MR
69702011-11-01 Martin Rudalics <rudalics@gmx.at>
6971
6972 * window.c (temp_output_buffer_show): Don't use
6973 Vtemp_buffer_show_specifiers.
6974 (Vtemp_buffer_show_specifiers): Remove unused variable.
6975
c2ff3c02
EZ
69762011-10-30 Eli Zaretskii <eliz@gnu.org>
6977
6978 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6979 past the beginning of the current glyph matrix.
6980
58179cce 69812011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6982
6983 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6984 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6985 HAVE_GTK3 (Bug#9869).
b77a6a7f 6986
3b574623
JD
6987 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6988 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6989
b77a6a7f
JD
6990 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6991
6992 * xterm.c: Declare x_handle_net_wm_state to return int.
6993 (handle_one_xevent): Check if we are iconified but don't have
6994 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6995 (get_current_wm_state): Return non-zero if not hidden,
6996 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6997 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6998 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6999 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7000
196e41e4
PE
70012011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7002
7003 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7004 so that this new function doesn't get optimized away by a
7005 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7006
021f2e1a
AS
70072011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7008
7009 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7010
8b058d44
EZ
70112011-10-29 Eli Zaretskii <eliz@gnu.org>
7012
7013 Fix the `xbytecode' command.
7014 * .gdbinit (xprintbytestr): New command.
b50a28de 7015 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7016 (xbytecode): Print the byte-code string as well.
7017
4452fb80
EZ
70182011-10-29 Kim Storm <storm@cua.dk>
7019
8b058d44
EZ
7020 * alloc.c (which_symbols): New function.
7021
21b72067
AS
70222011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7023
7024 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7025 line. (Bug#9903)
7026
83ed7b5c
GM
70272011-10-29 Glenn Morris <rgm@gnu.org>
7028
7029 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7030 Not clear what it was for, and it causes various bugs. (Bug#9839)
7031
5a7a728b
EZ
70322011-10-28 Eli Zaretskii <eliz@gnu.org>
7033
7034 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7035 possible random value that matches one of those tested as
7036 condition to clear the mouse face.
7037
d3d0842f
CY
70382011-10-28 Chong Yidong <cyd@gnu.org>
7039
7040 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7041
31b39d13
DN
70422011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7043
7044 * window.c (make_window): Initialize phys_cursor_on_p.
7045
9aba6043
SM
70462011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7047
7048 * lisp.h (struct Lisp_Symbol): Update comments.
7049
c20992f4
JB
70502011-10-28 Juanma Barranquero <lekktu@gmail.com>
7051
7052 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7053
db4f02f2
EZ
70542011-10-28 Eli Zaretskii <eliz@gnu.org>
7055
7056 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7057 <oslsachem@gmail.com> for helping to debug this.
7058
7059 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7060 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7061 (g_b_init_get_glyph_outline_w): New static variables.
7062 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7063 (GetGlyphOutlineW_Proc): New typedefs.
7064 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7065 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7066 New functions.
7067 (w32font_open_internal, compute_metrics):
7068 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7069 instead of calling the "wide" APIs directly.
7070
7071 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7072
7073 * w32.h (syms_of_w32font): Add prototype.
7074
87e68db4
JB
70752011-10-27 Juanma Barranquero <lekktu@gmail.com>
7076
7077 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7078 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7079 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7080 (Fmove_to_window_line): Doc fix.
7081
435c1d67
CY
70822011-10-27 Chong Yidong <cyd@gnu.org>
7083
7084 * process.c (make_process): Set gnutls_state to NULL.
7085
7086 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7087 non-NULL, regardless of GNUTLS_INITSTAGE.
7088 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7089 an error. Set process slots as soon as we allocate them.
7090
7091 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7092
9c6c6f49
CY
70932011-10-27 Chong Yidong <cyd@gnu.org>
7094
9aba6043
SM
7095 * gnutls.c (emacs_gnutls_deinit): New function.
7096 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7097 (Fgnutls_deinit, Fgnutls_boot): Use it.
7098
7099 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7100 (deactivate_process): Call emacs_gnutls_deinit.
7101
657d08d3
JB
71022011-10-27 Juanma Barranquero <lekktu@gmail.com>
7103
7104 * image.c (x_create_x_image_and_pixmap):
7105 * w32.c (sys_rename, w32_delayed_load):
7106 * w32font.c (fill_in_logfont):
7107 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7108
5430d399
JB
71092011-10-26 Juanma Barranquero <lekktu@gmail.com>
7110
7111 * w32fns.c (w32_default_color_map): New function,
7112 extracted from Fw32_default_color_map.
a7ef684b 7113 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7114
fe0055fa
PE
71152011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7116
7117 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7118
e6346438
SM
71192011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7120
7121 * keyboard.c (test_undefined): New function (bug#9751).
7122 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7123
e112cc37
ET
71242011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7125
7126 * sysdep.c (init_sys_modes): Fix the check for the controlling
7127 terminal (Bug#6649).
7128
7b5d6677
EZ
71292011-10-20 Eli Zaretskii <eliz@gnu.org>
7130
7131 * dispextern.h (struct bidi_it): New member next_en_type.
7132
7133 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7134 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7135 current character, check also for next_en_type being WEAK_EN.
7136 (bidi_resolve_weak): Don't enter the expensive loop if the current
7137 position is before next_en_pos. Record the bidi type of the first
7138 non-ET, non-BN character we find, in addition to its position.
7139 (bidi_level_of_next_char): Invalidate next_en_type when
7140 next_en_pos is over-stepped.
7141
7da0b018
PE
71422011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7143
7144 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7145 * editfns.c: Rewrite current-time-zone so that it invokes
7146 the equivalent of (format-time-string "%Z") to get the time zone name.
7147 This fixes a bug when the time zone name contains characters that
7148 need converting from the system time locale to Emacs internal format.
7149 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7150 that patch fixed format-time-string to do the conversion, but
7151 I forgot to fix current-time-zone.
7152 (format_time_string): New function, containing most of
7153 what Fformat_time_string used to contain.
7154 (Fformat_time_string): Rewrite in terms of format_time_string.
7155 This doesn't change this function's behavior.
7156 (current-time-zone): Rewrite to use format_time_string.
7157 This fixes the bug reported by Michael Schierl in
7158 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7159 Jason Rumney's 2007-06-07 change worked around this bug, but
7160 didn't fix it.
7161 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7162
8547b010
EZ
71632011-10-19 Eli Zaretskii <eliz@gnu.org>
7164
7165 * xdisp.c (start_display): If the character at POS is displayed
7166 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7167 (try_window_reusing_current_matrix): If a line ends in a display
7168 vector or the next line starts in a display vector, continue
7169 redrawing the window even though the character position of
7170 start_row was reached.
8547b010
EZ
7171 (Bug#9771, part 2)
7172
4e948d15
CY
71732011-10-18 Chong Yidong <cyd@gnu.org>
7174
7175 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7176 with nobreak-char-display too.
7177
4787455f
EZ
71782011-10-18 Eli Zaretskii <eliz@gnu.org>
7179
7180 Fix part 3 of bug#9771.
7181 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7182 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7183 non-neutral characters if the current character is a paragraph
7184 separator (a.k.a. Newline). This avoids running the same
7185 expensive loop twice, once when we consume the preceding newline
7186 and the other time when the line actually needs to be displayed.
7187 Avoid the loop when we see neutrals on the base embedding level
7188 following a character whose directionality is the same as the
7189 paragraph's. This avoids running the expensive loop when a line
7190 ends in a long sequence of neutrals, like control characters.
7191 Add assertion against STRONG_AL type. Slightly rearrange code
7192 that determines the type of a neutral given the first non-neutral
7193 that follows it.
7194 (bidi_level_of_next_char): Set next_en_pos to zero when
7195 invalidating its info.
7196
2c91f553
EZ
71972011-10-17 Eli Zaretskii <eliz@gnu.org>
7198
7199 * xdisp.c (push_display_prop): Determine whether to record string
7200 or buffer position by IT->string, not by IT->method. Allow
7201 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7202 (move_it_vertically_backward): Don't look for character position
7203 immediately after the newline when in a continuation line.
7204 (Bug#9771, part 1)
2c91f553 7205
c7b08b0d
MR
72062011-10-15 Martin Rudalics <rudalics@gmx.at>
7207
7208 * window.c (coordinates_in_window): Rewrite and delabelize
7209 vertical border check. (Bug#5357) (Bug#9618)
7210
6b02f655
SM
72112011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7212
7213 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7214 errors in XSetWindowBorder (bug#9310).
7215
81d40c92
DA
72162011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7217
7218 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7219 avoid crash when xmalloc overrun checking is enabled.
7220
d4172c3b
EZ
72212011-10-13 Eli Zaretskii <eliz@gnu.org>
7222
7223 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7224 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7225 cursor motion with <left> and <right> arrow keys.
7226
7227 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7228 some callers set that themselves.
7229
b00eea75
EZ
72302011-10-12 Eli Zaretskii <eliz@gnu.org>
7231
7232 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7233 display string and the previous row comes from the same string and
7234 is empty. (Bug#9739) (Bug#9738)
7235
8fe012c4
SM
72362011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7237
7238 * doc.c (get_doc_string): Encode file name (bug#9735).
7239
0074aef2
EZ
72402011-10-12 Eli Zaretskii <eliz@gnu.org>
7241
79beb178
EZ
7242 * bidi.c (bidi_level_of_next_char):
7243 * xdisp.c (get_visually_first_element): Remove old incorrect
7244 comments regarding the Unicode Line Separator character.
7245
0074aef2
EZ
7246 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7247
6e4b3fbe
DA
72482011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7249
7250 * alloc.c (Fgc_status): Do not access beyond zombies array
7251 boundary if nzombies > MAX_ZOMBIES.
7252 * alloc.c (dump_zombies): Add missing format specifier.
7253
0324f3af
PE
72542011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7255
b5525cac
PE
7256 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7257 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7258
0324f3af
PE
7259 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7260 Some packages use them to denote characters with modifiers.
7261
e9b5f888
AS
72622011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7263
7264 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7265 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7266 matching a pp-number. Rename parameter var to var1.
7267
127827c0
SM
72682011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7269
7270 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7271
c8fd3bd0
GM
72722011-10-08 Glenn Morris <rgm@gnu.org>
7273
7274 * callint.c (Fcall_interactively): Give a more explicit error for the
7275 'c' case with a non-character input. (Bug#8479)
7276
352ec8ff
EZ
72772011-10-08 Eli Zaretskii <eliz@gnu.org>
7278
03669ccb
EZ
7279 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7280 lines.
7061c986
EZ
7281 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7282 lines that are hscrolled on the left.
03669ccb 7283
352ec8ff
EZ
7284 * dispnew.c (buffer_posn_from_coords): Account for a possible
7285 presence of header-line. (Bug#4426)
7286
a66cfb1c
SM
72872011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7288
6b02f655
SM
7289 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7290 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7291
7c5ee88e
PE
72922011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7293
7294 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7295 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7296 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7297 this makes Emacs dump core during garbage collection on rare
7298 occasions. sizeof is obviously inferior to offsetof here, so
7299 stick with offsetof.
7300 (GC_POINTER_ALIGNMENT): New macro.
7301 (mark_memory): Omit 3rd (offset) arg; caller changed.
7302 Don't assume EMACS_INT alignment is the same as pointer alignment.
7303
df1bbe5b
SM
73042011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7305
7306 * keyboard.c (read_key_sequence_remapped): New var.
7307 (read_key_sequence): Compute remapping in the right buffer.
7308 (command_loop_1): Use read_key_sequence's remapping directly.
7309
51553db6
SM
73102011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7311
32c1fffd
SM
7312 * dired.c (file_name_completion): Don't expand file name.
7313 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7314 before checking file name handler.
7315
51553db6
SM
7316 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7317 they've been requested explicitly (bug#9591).
7318
b6bd1599 73192011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7320
7321 * keymap.c (Fsingle_key_description): Use make_specified_string
7322 instead of build_string to build string from push_key_description.
7323 (Bug#5193)
7324
f701dc2a
PE
73252011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7326
4222c55d
PE
7327 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7328 This fixes a Y2038 bug on 64-bit hosts.
7329 * buffer.c (reset_buffer):
7330 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7331 (Fclear_buffer_auto_save_failure):
7332 Use 0, not -1, to represent an unset failure time, since time_t
7333 might not be signed.
7334
f701dc2a
PE
7335 Remove dependency on glibc malloc internals.
7336 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7337 Move back here from lisp.h, but with their new implementations.
7338 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7339 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7340 * charset.c (charset_table_init): New static var.
7341 (syms_of_charset): Use it instead of xmalloc. This removes a
7342 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7343 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7344 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7345 Move back to alloc.c.
7346 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7347 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7348
9ceebf39
JD
73492011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7350
7351 * nsterm.m (windowDidResize): Call x_set_window_size only when
7352 ns_in_resize is true. Otherwise set pixelwidth/height and
7353 call change_frame_size (Bug#9628).
7354
cb993c58
PE
73552011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7356
3930c88b
PE
7357 Port --enable-checking=all to Fedora 14 x86-64.
7358 * charset.c (syms_of_charset): Also account for glibc malloc's
7359 internal overhead when calculating the initial malloc maximum.
7360
cb993c58
PE
7361 Port --enable-checking=all to Fedora 14 x86.
7362 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7363 Move to lisp.h.
7364 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7365 (overrun_check_realloc, overrun_check_free):
7366 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7367 That way, xmalloc returns a properly-aligned pointer even if
7368 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7369 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7370 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7371 into account when calculating the initial malloc maximum.
7372 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7373 Move here from alloc.c, so that charset.c can use it too.
7374 Properly align; the old code wasn't right for common 32-bit hosts
7375 when configured with --enable-checking=all.
7376 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7377 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7378
31bed486
EZ
73792011-09-29 Eli Zaretskii <eliz@gnu.org>
7380
04c70788 7381 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7382 use EDOM.
7383
fbcaa2f3
EZ
73842011-09-28 Eli Zaretskii <eliz@gnu.org>
7385
7386 * xdisp.c (compute_display_string_end): If there's no display
7387 string at CHARPOS, return -1.
7388
7389 * bidi.c (bidi_fetch_char): When compute_display_string_end
7390 returns a negative value, treat the character as a normal
7391 character not covered by a display string. (Bug#9624)
7392
a239d4e9
JB
73932011-09-28 Juanma Barranquero <lekktu@gmail.com>
7394
7395 * lread.c (Fread_from_string): Fix typo in docstring.
7396
88652fd5
EZ
73972011-09-27 Eli Zaretskii <eliz@gnu.org>
7398
7399 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7400 newline, reseat the iterator instead of bidi-iterating there one
7401 character at a time. (Bug#9610)
32c1fffd
SM
7402 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7403 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7404
ed497dd4
AS
74052011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7406
7407 * lread.c (readevalloop): Use correct code for NBSP.
7408 (read1): Likewise. (Bug#9608)
7409
b2bf61aa
MA
74102011-09-25 Michael Albinus <michael.albinus@gmx.de>
7411
7412 * dbusbind.c (Fdbus_register_signal): When service is not
7413 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7414
32bbb17c
GM
74152011-09-25 Glenn Morris <rgm@gnu.org>
7416
7417 * buffer.c (truncate-lines): Doc fix.
7418
94e0933e
CY
74192011-09-24 Chong Yidong <cyd@stupidchicken.com>
7420
7421 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7422 (Fset_window_next_buffers): Doc fix.
7423
cddde921
GM
74242011-09-24 Glenn Morris <rgm@gnu.org>
7425
7426 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7427
1260aef1
PE
74282011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7429
25b4bfa0
PE
7430 Fix minor problems found by static checking.
7431 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7432 * indent.c (Fvertical_motion): Fix == vs = typo.
7433
e3cbd34b
EZ
74342011-09-24 Eli Zaretskii <eliz@gnu.org>
7435
a66cfb1c
SM
7436 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7437 Default value is now t. Doc fix.
6bf7006f 7438
e3cbd34b 7439 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7440 logic when moving up, not only when moving down. Fix the
e3cbd34b 7441 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7442 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7443
7444 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7445 CHARPOS is covered by a display string which includes newlines.
7446 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7447 is covered by a display string with embedded newlines.
7448
a3de0cbd
MA
74492011-09-24 Michael Albinus <michael.albinus@gmx.de>
7450
7451 * dbusbind.c (Fdbus_register_signal): Add match rule to
7452 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7453 (Fdbus_register_method, Vdbus_registered_objects_table):
7454 Fix docstring.
a3de0cbd 7455
b260039d
JM
74562011-09-24 Jim Meyering <meyering@redhat.com>
7457
32c1fffd 7458 do not ignore write error for any output size
b260039d
JM
7459 The previous change was incomplete.
7460 While it makes emacs --batch detect the vast majority of stdout
7461 write failures, errors were still ignored whenever the output size is
7462 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7463 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7464 && echo FAIL: ignored write error
7465 FAIL: ignored write error
7466 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7467 && echo FAIL: ignored write error
7468 FAIL: ignored write error
7469 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7470
8eca8a7c
AS
74712011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7472
7473 * emacs.c (Fkill_emacs): In noninteractive mode exit
7474 non-successfully if a write error occurred on stdout. (Bug#9574)
7475
3341db62
EZ
74762011-09-21 Eli Zaretskii <eliz@gnu.org>
7477
7478 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7479 the xassert test.
7480
7481 * dispextern.h (struct it): Update the comment documenting what
7482 can it->OBJECT be.
7483
8c203dbf
EZ
74842011-09-20 Eli Zaretskii <eliz@gnu.org>
7485
7486 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7487 a display string, extend search for cursor position to end of row.
7488 (find_row_edges): If the row ends in a newline from a display
7489 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7490 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7491 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7492 non-empty line. Fixes confusing cursor motion with arrow keys at
7493 the beginning of a line that starts with whitespace.
8c203dbf 7494
a4824228
LMI
74952011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7496
7497 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7498 (bug#9493).
7499
33ed493b
CY
75002011-09-18 Chong Yidong <cyd@stupidchicken.com>
7501
7502 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7503 boolean (Bug#9154).
7504
56cd55c8
EZ
75052011-09-18 Eli Zaretskii <eliz@gnu.org>
7506
7507 * xdisp.c (display_line): Record maximum and minimum buffer
7508 positions even if no glyphs were produced (e.g., by a zero-width
7509 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7510 buffer positions that will be removed from the glyph row because
7511 they don't fit.
c02dcedf
EZ
7512 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7513 column is beyond frame width: don't subtract 1 "pixel" when
7514 computing width of the stretch.
3e62b7e0
EZ
7515 (reseat_at_next_visible_line_start): Undo the change made on
7516 2011-09-17 that saved paragraph information and restored it after
7517 the call to `reseat'. (Bug#9545)
56cd55c8 7518
5ed99d36 75192011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7520
7521 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7522 and turn window cursor on if cleared (Bug#9415).
7523
5ed99d36 75242011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7525
7526 * search.c (boyer_moore): Take unibyte characters from pattern
7527 literally. (Bug#9458)
7528
9bade7b2
EZ
75292011-09-18 Eli Zaretskii <eliz@gnu.org>
7530
7531 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7532
e5e9d610
PE
75332011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7534
87e4427a
PE
7535 Fix minor problem found by static checking.
7536 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7537 initialized, to pacify gcc -Wuninitialized.
7538
e5e9d610
PE
7539 * fileio.c: Report proper errno when syscall falls.
7540 (Finsert_file_contents): Save and restore errno,
7541 so that report_file_error outputs the correct diagnostic.
7542 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7543
a1674f0b
EZ
75442011-09-18 Eli Zaretskii <eliz@gnu.org>
7545
7546 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7547
fbfb6dd4
EZ
75482011-09-17 Eli Zaretskii <eliz@gnu.org>
7549
7550 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7551 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7552
bb187662
EZ
75532011-09-17 Eli Zaretskii <eliz@gnu.org>
7554
1137e8b8 7555 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7556 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7557
7558 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7559 (bidi_find_paragraph_start): Search back for paragraph beginning
7560 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7561 (bidi_move_to_visually_next): Only trigger paragraph-related
7562 computations when the last character is a newline or at EOB, not
7563 just any NEUTRAL_B. (Bug#9470)
7564
bb187662
EZ
7565 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7566 truncated lines if point is covered by a display string. (Bug#9524)
7567
2e621251
PE
75682011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7569
7570 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7571 (cons_to_x_long): New function.
7572 (lisp_data_to_selection_data): Use it. Correct the test for
7573 short-versus-long data; it was negated. Break out of vector
7574 loop, for efficiency, when a long datum is discovered.
7575
91a15bc6
SM
75762011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7577
7578 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7579
b41c3a35
EZ
75802011-09-16 Eli Zaretskii <eliz@gnu.org>
7581
7582 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7583 GCC PR/17406) by declaring this function with external scope.
7584
7812ba2d
PE
75852011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7586
7587 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7588 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7589
cf7edc2a
AS
75902011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7591
7592 * editfns.c (Fformat): Correctly handle text properties on "%%".
7593
bd01620e
EZ
75942011-09-15 Eli Zaretskii <eliz@gnu.org>
7595
7596 * xterm.c (x_draw_composite_glyph_string_foreground):
7597 * w32term.c (x_draw_composite_glyph_string_foreground):
7598 * term.c (encode_terminal_code):
7599 * composite.c (composition_update_it, get_composition_id):
7600 * xdisp.c (get_next_display_element)
7601 (fill_composite_glyph_string): Add comments about special meaning
7602 of TAB characters in a composition.
7603
a02719a3
PE
76042011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7605
7606 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7607 This occurs when processing a multibyte format.
7608 Problem reported by Wolfgang Jenker.
a02719a3 7609
72589a3c
JB
76102011-09-15 Johan Bockgård <bojohan@gnu.org>
7611
7612 * xdisp.c (try_cursor_movement): Only check for exact match if
7613 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7614
1c14176c
PE
76152011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7616
7617 Remove unused external symbols.
7618 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7619 * xdisp.c (calc_pixel_width_or_height): Now static.
7620 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7621 * indent.c (check_display_width):
7622 * w32term.c: Fix comment to match code.
7623 * xterm.c, xterm.h (x_catching_errors): Remove.
7624
d2eea5b5
PE
76252011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7626
7627 * xselect.c: Use signed conversions more consistently (Bug#9498).
7628 (selection_data_to_lisp_data): Assume incoming selection data are
7629 signed integers, not unsigned. This is to be consistent with
7630 outgoing selection data, which was modified to use signed integers
7631 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7632 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7633 expects long, not unsigned long.
7634
46888499
EZ
76352011-09-14 Eli Zaretskii <eliz@gnu.org>
7636
7637 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7638 computation of loop end. Reported by Johan Bockgård
7639 <bojohan@gnu.org>.
7640
ef8ef9fb
CY
76412011-09-13 Chong Yidong <cyd@stupidchicken.com>
7642
7643 * frame.c (Fother_visible_frames_p): Function deleted.
7644
fa819fed
EZ
76452011-09-12 Eli Zaretskii <eliz@gnu.org>
7646
7647 * indent.c (compute_motion): Process display vector front to back
7648 rather than the other way around. (Bug#2496)
7649
2ba8e008
SM
76502011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7651
7652 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7653
20f53c69
CY
76542011-09-11 Chong Yidong <cyd@stupidchicken.com>
7655
7656 * minibuf.c (Fread_from_minibuffer): Doc fix.
7657
d562d7a4
EZ
76582011-09-11 Eli Zaretskii <eliz@gnu.org>
7659
7660 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7661 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7662
1c4d7f3d
LMI
76632011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7664
7665 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7666 value for non-existent files.
7667
b885bf36
EZ
76682011-09-11 Eli Zaretskii <eliz@gnu.org>
7669
7670 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7671 set its "size" to -1. This will set the modtime_size field of
7672 the corresponding buffer to -1, which is what
7673 verify-visited-file-modtime expects for files that do not exist.
7674 (Bug#9139)
7675
6612f0bf
PE
76762011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7677
7678 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7679 here ...
7680 * lisp.h: ... from here. push_key_description is no longer
7681 defined in keyboard.c, so its declaration should not be in
7682 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7683 logically belongs with push_key_description.
7684
dfb3f755
PE
76852011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7686
7687 * buffer.h: Include <sys/types.h> instead of <time.h>.
7688 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7689 Problem reported by Herbert J. Skuhra.
7690
3134906c
LMI
76912011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7692
7693 * xml.c (parse_region): Make the parsing work for
7694 non-comment-starting XML files again (bug#9144).
7695
8d903f4e
AS
76962011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7697
7698 * image.c (gif_load): Fix calculation of bottom and right corner.
7699 (Bug#9468)
7700
80ad64f4
EZ
77012011-09-10 Eli Zaretskii <eliz@gnu.org>
7702
7703 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7704 redisplay in small windows.
7705
208a048d
EZ
77062011-09-09 Eli Zaretskii <eliz@gnu.org>
7707
7708 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7709
9b1c252e
MR
77102011-09-08 Martin Rudalics <rudalics@gmx.at>
7711
7712 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7713 Operate on live windows only.
7714
2949f33b
JB
77152011-09-08 Juanma Barranquero <lekktu@gmail.com>
7716
7717 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7718
e08dcafd
EZ
77192011-09-07 Eli Zaretskii <eliz@gnu.org>
7720
7721 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7722 only under bidi iteration.
7723
115b96bd
JD
77242011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7725
7726 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7727
c8199d0f
PE
77282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7729
7730 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7731 Without this fix, the command to link temacs failed due to an
7732 undefined symbol __builtin_isnan. This is because
7733 /usr/include/iso/math_c99.h #defines isnan(x) to
7734 __builtin_isnan(x), but the bundled gcc, which identifies itself
7735 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7736 a __builtin_isnan.
7737 * floatfns.c (isnan): #undef, and then #define to a clone of
7738 what's in data.c.
7739 (Fisnan): Always define, since it's always available now.
7740 (syms_of_floatfns): Always define isnan at the Lisp level.
7741
e39b275c 77422011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7743
7744 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7745
b2db44d9 77462011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7747
f4af5137 7748 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7749 The previous code assumed that file offsets (off_t values) fit in
7750 EMACS_INT variables, which is not true on typical 32-bit hosts.
7751 The code messed up by falsely reporting buffer overflow in cases
7752 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7753 when "big" contains more than 2**29 bytes, even though this
7754 inserts just one byte and does not overflow the buffer.
7755 (Finsert_file_contents): Store file offsets as off_t
7756 values, not as EMACS_INT values. Check for overflow when
7757 converting between EMACS_INT and off_t. When checking for
7758 buffer overflow or for overlap, take the offsets into account.
7759 Don't use EMACS_INT for small values where int suffices.
7760 When checking for overlap, fix a typo: ZV was used where
7761 ZV_BYTE was intended.
7762 (Fwrite_region): Don't assume off_t fits into 'long'.
7763 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7764
ecfc0a49
MA
77652011-09-05 Michael Albinus <michael.albinus@gmx.de>
7766
7767 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7768
6511acf2 77692011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7770
0999621a 7771 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7772
7773 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7774 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7775 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7776 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7777 (modify_event_symbol): Do not assume that the length of
7778 name_alist_or_stem is safe to alloca and fits in int.
7779 (Fexecute_extended_command): Likewise for function name and binding.
7780 (Frecursion_depth): Wrap around reliably on integer overflow.
7781 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7782 since some callers pass EMACS_INT values.
7783 (Fsingle_key_description): Don't crash if symbol name contains more
7784 than MAX_ALLOCA bytes.
7785 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7786 (get_minibuffer): Arg is now EMACS_INT, not int.
7787 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7788 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7789 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7790
2be7d702
PE
7791 * dbusbind.c (signature_cat): New function.
7792 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7793 Do not overrun buffer; instead, report string overflow.
7794
9d1df220
PE
7795 * dispnew.c (add_window_display_history): Don't overrun buffer.
7796 Truncate instead; this is OK since it's just a log.
7797
33ef5c64
PE
7798 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7799 even if the time zone offset is outlandishly large.
7800 Don't mishandle offset == INT_MIN.
7801
66c6fdd5
PE
7802 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7803 when creating daemon; the previous buffer-overflow check was incorrect.
7804
d749b01b
PE
7805 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7806 which has the guts of the old verror function.
7807
b5cd1905
PE
7808 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7809 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7810
6e1a67fb
PE
7811 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7812 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7813 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7814 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7815 length of string rather than counting it via multiple sprintfs;
7816 that's simpler and more reliable.
c21721cc
PE
7817 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7818 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7819 sprintf, in case result does not fit in int.
7820
c57b67fc
PE
7821 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7822 (fontset_from_font): Print it.
7823
8a401434
PE
7824 * frame.c (tty_frame_count): Now printmax_t, not int.
7825 (make_terminal_frame, set_term_frame_name): Print it.
7826 (x_report_frame_params): In X, window IDs are unsigned long,
7827 not signed long, so print them as unsigned.
7828 (validate_x_resource_name): Check for implausibly long names,
7829 and don't assume name length fits in 'int'.
7830 (x_get_resource_string): Don't blindly alloca invocation name;
7831 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7832 not fit in int.
7833
6e1a67fb
PE
7834 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7835 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7836 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7837
0df02bf3
PE
7838 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7839 Use esprintf, not sprintf, in case result does not fit in int.
7840
48e30793
PE
7841 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7842 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7843 it as a large positive number.
7844 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7845 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7846
a66ff6d8
PE
7847 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7848 in case result does not fit in int.
7849
aca216ff
PE
7850 * print.c (float_to_string): Detect width overflow more reliably.
7851 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7852 buffer overrun. Don't assume list length fits in 'int'. Treat
7853 print length of 0 as 0, not as infinity; to be consistent with other
7854 uses of print length in this function. Don't overflow print length
7855 index. Don't assume hash table size fits in 'long', or that
7856 vectorlike size fits in 'unsigned long'.
7857
31c286f7
PE
7858 * process.c (make_process): Use printmax_t, not int, to format
7859 process-name gensyms.
7860
55e5faa1
PE
7861 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7862
80f2e268
PE
7863 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7864 to avoid potential buffer overrun.
7865
670741ab
PE
7866 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7867 if X resource line is longer than 512 bytes.
7868
b7163a50
PE
7869 * xfns.c (x_window): Make sprintf buffer a bit bigger
7870 to avoid potential buffer overrun.
7871
ae58ff1f
PE
7872 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7873
c43c8a6a
PE
7874 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7875
3f8236f4
PE
78762011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7877
53e9fe90 7878 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7879 Without these, Emacs silently mishandles large integers sometimes.
7880 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7881 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7882
6511acf2
PE
7883 * xdisp.c (try_window_id): Check Emacs fixnum range before
7884 converting to 'int'.
806add1d 7885
6511acf2 7886 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7887 Check that an Emacs fixnum is in range before assigning it to 'int'.
7888 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7889 values converted from Emacs fixnums.
7890 (Frecenter): Don't wrap around a line count if it is out of 'int'
7891 range; instead, treat it as an extreme value.
7892 (Fset_window_configuration, compare_window_configurations):
7893 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7894
6511acf2
PE
7895 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7896 that can exceed INT_MAX. Check that EMACS_INT value is in range
7897 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7898 (match_limit): Don't assume that a fixnum can fit in 'int'.
7899
6511acf2 7900 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7901 exceed INT_MAX.
7902
6511acf2 7903 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7904 (Fvertical_motion): Don't wrap around LINES values that don't fit
7905 in 'int'. Instead, treat them as extreme values. This is good
7906 enough for windows, which can't have more than INT_MAX lines anyway.
7907
fcb901a7
LMI
79082011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7909
0f2f6b6d
LMI
7910 * Require libxml/parser.h to avoid compilation warning.
7911
fcb901a7
LMI
7912 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7913
7914 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7915 since this reportedly can destroy thread storage.
7916
6e20a0d4
CY
79172011-08-30 Chong Yidong <cyd@stupidchicken.com>
7918
7919 * syntax.c (find_defun_start): Update all cache variables if
7920 exiting early (Bug#9401).
7921
148ae00e
EZ
79222011-08-30 Eli Zaretskii <eliz@gnu.org>
7923
f6cfbd8f
EZ
7924 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7925
148ae00e
EZ
7926 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7927 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7928 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7929
7930 * term.c (tty_append_glyph): New function.
7931 (produce_stretch_glyph): Static function and its prototype deleted.
7932
a66cfb1c
SM
7933 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7934 Add prototypes.
148ae00e 7935
c4a07a4c
PE
79362011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7937
7938 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7939 when checking :margin (Bug#9390).
7940 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7941 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7942 so that the name doesn't mislead. All uses changed.
7943
6bc8cd65
JB
79442011-08-28 Johan Bockgård <bojohan@gnu.org>
7945
7946 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7947 set_tty_hooks.
7948
dca4927e
EZ
79492011-08-27 Eli Zaretskii <eliz@gnu.org>
7950
7951 * xdisp.c (move_it_to): Don't bail out early when reaching
7952 position beyond to_charpos, if we are scanning backwards.
7953 (move_it_vertically_backward): When DY == 0, make sure we get to
7954 the first character in the line after the newline.
7955
f2cad773
PE
79562011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7957
7958 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7959 (ccl_driver): Do not generate an out-of-range pointer.
7960 (Fccl_execute_on_string): Remove unnecessary check for
7961 integer overflow, noted by Stefan Monnier in
7962 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7963 Remove a FIXME that didn't need fixing.
7964 Simplify the newly-introduced buffer reallocation code.
7965
0cae2cdb
JB
79662011-08-27 Juanma Barranquero <lekktu@gmail.com>
7967
7968 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7969
5fc295a4 79702011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7971
70c60eb2 7972 Integer and memory overflow issues (Bug#9196).
726e0ab1 7973
d31850da
PE
7974 * doc.c (get_doc_string): Rework so that
7975 get_doc_string_buffer_size is the actual buffer size, rather than
7976 being 1 less than the actual buffer size; this makes xpalloc more
7977 convenient.
7978
a69fbedb
PE
7979 * image.c (x_allocate_bitmap_record, cache_image):
7980 * xselect.c (Fx_register_dnd_atom):
7981 Simplify previous changes by using xpalloc.
7982
fe5c5d37
PE
7983 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7984 since either will do and ptrdiff_t is convenient with xpalloc.
7985
0065d054
PE
7986 * charset.c (charset_table_size)
7987 (struct charset_sort_data.priority): Now ptrdiff_t.
7988 (charset_compare): Don't overflow if priorities differ greatly.
7989 (Fsort_charsets): Don't assume list length fits in int.
7990 Check for size-calculation overflow when allocating sort data.
7991 (syms_of_charset): Allocate an initial charset table that is
7992 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7993
7994 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7995
7996 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7997 The actual value is always <= INT_MAX, and leaving it unsigned made
7998 overflow checking harder.
7999
8000 * dispextern.h (struct glyph_matrix.rows_allocated)
8001 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8002 with xpalloc. The values are still always <= INT_MAX.
8003
8004 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8005
8006 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8007 (SAFE_NALLOCA): New macro.
8008
8009 * region-cache.c (struct boundary.pos, find_cache_boundary)
8010 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8011 (set_cache_region, invalidate_region_cache)
8012 (revalidate_region_cache, know_region_cache, region_cache_forward)
8013 (region_cache_backward, pp_cache):
8014 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8015 so that ptrdiff_t * can be passed to xpalloc.
8016 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8017 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8018 (pp_cache): Don't assume cache_len fits in int.
8019 * region-cache.h: Adjust extern decls to match.
8020
8021 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8022 EMACS_INT, since either will do, for xpalloc.
8023
8024 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8025 (xnmalloc, xnrealloc, xpalloc): New functions.
8026
726e0ab1
PE
8027 * bidi.c (bidi_shelve_header_size): New constant.
8028 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8029 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8030
51f30bc5 8031 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8032 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8033 (overlay_strings):
8034 Don't update size of array until after memory allocation succeeds,
8035 because xmalloc/xrealloc may not return.
0065d054
PE
8036 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8037 now that we have proper integer overflow checking.
8038 (record_overlay_string, overlay_strings): Catch overflows when
8039 calculating size of overlay_str_buf.
726e0ab1 8040
0065d054
PE
8041 * callproc.c (Fcall_process): Check for size overflow when
8042 calculating size of args2.
8043 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8044 Normally we prefer signed values, but sticking with ptrdiff_t would
8045 require adding more-complicated checks.
726e0ab1
PE
8046
8047 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8048 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8049 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8050 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8051
8052 * character.c (Fstring): Check for size-calculation overflow.
8053
8054 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8055 unnecessary integer overflow. Check for size overflow.
8056 (encode_coding_object): Don't update size until xmalloc succeeds.
8057
8058 * composite.c (get_composition_id): Check for overflow in glyph
8059 length calculations.
8060
8061 Integer and memory overflow fixes for display code.
8062 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8063 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8064 (scrolling_window): Check for overflow in size calculations.
8065 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8066 Don't assume glyph table len fits in int.
8067 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8068 (row_table_size): Now ptrdiff_t, not int.
8069 (scrolling_window): Avoid overflow in size calculations.
8070 Don't update size until allocation succeeds.
8071 * fns.c (concat): Check for overflow in size calculations.
8072 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8073 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8074 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8075
8076 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8077 (get_doc_string): Check for size calculation overflow.
8078 Don't update size until allocation succeeds.
8079 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8080 EMACS_INT, where ptrdiff_t will do.
8081 (Fsubstitute_command_keys): Check for string overflow.
8082
8083 * editfns.c (set_time_zone_rule): Don't assume environment length
8084 fits in int.
8085 (message_length): Now ptrdiff_t, not int.
8086 (Fmessage_box): Don't update size until allocation succeeds.
8087 Don't assume message length fits in int.
8088 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8089
0065d054
PE
8090 * emacs.c (main): Do not reallocate argv, since there is a null at
8091 the end that can be overwritten, and this way there's no need to
8092 worry about size-calculation overflow.
8093 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8094
8095 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8096 alloc succeeds.
8097 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8098
8099 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8100 (x_set_scroll_bar_width, x_figure_window_size):
8101 Check for integer overflow.
8102 (x_set_alpha): Do not assume XINT fits in int.
8103
8104 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8105 This is for the members text_lines, text_cols, total_lines, total_cols,
8106 where the system imposes an 'int' limit.
8107
8108 * fringe.c (Fdefine_fringe_bitmap):
8109 Don't update size until alloc works.
8110
8111 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8112 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8113
8114 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8115 Check for size-calculation overflow.
8116 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8117 do, as we prefer signed integers.
8118 (id_to_widget.max_size, id_to_widget.used)
8119 (xg_store_widget_in_map, xg_remove_widget_from_map)
8120 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8121 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8122 Use and return ptrdiff_t, not int.
8123 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8124 * gtkutil.h: Change prototypes to match the above.
8125
8126 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8127 are duplicate now that they've been promoted to lisp.h.
8128 (x_allocate_bitmap_record, x_alloc_image_color)
8129 (make_image_cache, cache_image, xpm_load):
8130 Don't update size until alloc is done.
8131 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8132 (x_detect_edges):
3256efce 8133 Check for size calculation overflow.
726e0ab1
PE
8134 (ct_colors_allocated_max): New constant.
8135 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8136 overflow.
3256efce 8137
726e0ab1
PE
8138 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8139 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8140 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8141 Use ptrdiff_t, not int, to count maps.
8142 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8143 calculations. Don't update size until allocation succeeds.
8144 Redo calculations to avoid overflow.
726e0ab1
PE
8145 * keyboard.h: Change prototypes to match the above.
8146
8147 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8148 to count maps.
8149 (current_minor_maps): Check for size calculation overflow.
8150 * keymap.h: Change prototypes to match the above.
8151
8152 * lread.c (read1, init_obarray): Don't update size until alloc done.
8153
8154 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8155 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8156
726e0ab1
PE
8157 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8158 Now ptrdiff_t, not int.
8159 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8160 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8161
8162 * process.c (Fnetwork_interface_list): Check for overflow
8163 in size calculation.
8164
8165 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8166
8167 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8168 overflow. Don't bother calling xmalloc when xrealloc will do.
8169
8170 * search.c (Freplace_match): Check for size calculation overflow.
8171 (Fset_match_data): Don't assume list lengths fit in 'int'.
8172
8173 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8174 for command line length. Do not attempt to address one before the
8175 beginning of an array, as that's not portable.
8176
8177 * term.c (max_frame_lines): Remove; unused.
8178 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8179 not int.
8180 (encode_terminal_code, calculate_costs): Check for size
8181 calculation overflow.
8182 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8183 table lengths and related sizes. Don't update size until alloc
8184 done. Redo calculations to avoid overflow.
8185 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8186
8187 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8188 subtracting pointers.
8189 (gobble_line): Check for overflow more carefully. Don't update size
8190 until alloc done.
8191
8192 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8193 Don't update size until alloc done.
8194 Redo size calculations to avoid overflow.
8195 Check for size calculation overflow.
0065d054 8196 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8197
8198 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8199 Use ptrdiff_t, not int, for sizes.
8200 (store_mode_line_noprop_char): Don't update size until alloc done.
8201
0065d054
PE
8202 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8203 Use ptrdiff_t, not int, for sizes.
8204 (Finternal_make_lisp_face, cache_face):
8205 Check for size calculation overflow.
8206 (cache_face): Treat size calculation overflows as if they were
8207 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8208
8209 * xfns.c (x_encode_text, x_set_name_internal)
8210 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8211 sizes, since they can exceed INT_MAX in size. Check for size
8212 calculation overflow.
8213
0065d054
PE
8214 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8215 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8216 Don't update size until alloc done.
8217
0065d054 8218 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8219 as sprintf is limited to int lengths.
1d526e2f 8220
252c5ee1
PE
8221 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8222 (X_LONG_MIN): New macros.
864d7ce7
PE
8223 Use them to make the following changes clearer.
8224 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8225 This change doesn't affect the value now, but it may help remind
8226 future maintainers not to raise the value too much later.
8227 (SELECTION_QUANTUM): Remove, replacing with ...
8228 (selection_quantum): ... new function, which avoids overflow.
8229 All uses changed.
8230 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8231 assumption that selection length fits in 'int'.
8232 (x_reply_selection_request, x_handle_selection_request)
8233 (x_get_window_property, receive_incremental_selection)
8234 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8235 (lisp_data_to_selection_data, clean_local_selection_data):
8236 Use ptrdiff_t, not int, to record length of selection.
8237 (x_reply_selection_request, x_get_window_property)
8238 (receive_incremental_selection, x_property_data_to_lisp):
8239 Redo calculations to avoid overflow.
8240 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8241 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8242 something.
8243 (x_get_window_property, receive_incremental_selection)
8244 (lisp_data_to_selection_data, x_property_data_to_lisp):
8245 Check for size-calculation overflow.
8246 (x_get_window_property, receive_incremental_selection)
8247 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8248 Don't store size until memory allocation succeeds.
8249 (x_get_window_property): Plug memory leak on memory exhaustion.
8250 Don't double-block input; malloc is safe here. Don't assume 2**34
8251 - 4 fits in unsigned long. Add an xassert to check
8252 XGetWindowProperty overflow. Be more careful about overflow
8253 calculations, and distinguish size from memory overflow better.
8254 (receive_incremental_selection): When tracing, don't assume
8255 unsigned int is less than INT_MAX.
8256 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8257 harmful) conversions of unsigned short to int.
8258 (lisp_data_to_selection_data): Don't assume that integers
8259 in the range -65535 through -1 fit in an X unsigned short.
8260 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8261 result parameters unless successful. Rely on cons_to_unsigned
8262 to report problems with elements; the old code wasn't right anyway.
8263 (x_check_property_data): Check for int overflow; we cannot use
8264 a wider type due to X limits.
8265 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8266
726e0ab1 8267 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8268
0065d054
PE
8269 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8270 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8271 (x_color_cells): Don't store size until memory allocation succeeds.
8272 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8273 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8274 (x_term_init): Don't assume length fits in int (sprintf is limited
8275 to int size).
bc18e09d 8276
ebfa62c0
PE
8277 Use ptrdiff_t for composition IDs.
8278 * character.c (lisp_string_width):
8279 * composite.c (composition_table_size, n_compositions)
8280 (get_composition_id, composition_gstring_from_id):
8281 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8282 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8283 * window.c (Frecenter):
8284 Use ptrdiff_t, not int, for composition IDs.
8285 * composite.c (get_composition_id): Check for integer overflow.
8286 * composite.h: Adjust prototypes to match the above changes.
8287
d3411f89
PE
8288 Use ptrdiff_t for hash table indexes.
8289 * category.c (hash_get_category_set):
8290 * ccl.c (ccl_driver):
8291 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8292 * coding.c (coding_system_charset_list, detect_coding_system):
8293 * coding.h (struct coding_system.id):
8294 * composite.c (get_composition_id, gstring_lookup_cache):
8295 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8296 * image.c (xpm_get_color_table_h):
8297 * lisp.h (hash_lookup, hash_put):
8298 * minibuf.c (Ftest_completion):
8299 Use ptrdiff_t for hash table indexes, not int (which is too
8300 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8301 32-bit --with-wide-int hosts).
8302
e097a6fa
PE
8303 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8304 Add a FIXME comment about memory leaks.
8305 (syms_of_charset): Don't assume xmalloc returns.
8306
5637687f
PE
8307 Don't assume that stated character widths fit in int.
8308 * character.c (Fchar_width, c_string_width, lisp_string_width):
8309 * character.h (CHAR_WIDTH):
8310 * indent.c (MULTIBYTE_BYTES_WIDTH):
8311 Use sanitize_char_width to avoid undefined and/or bad behavior
8312 with outlandish widths.
a66cfb1c 8313 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8314 now that we have two such functions. All uses changed.
8315 (sanitize_char_width): New inline function.
8316
a2271ba2
PE
8317 Don't assume that tab-width fits in int.
8318 * character.h (sanitize_width): New inline function.
8319 (SANE_TAB_WIDTH): New macro.
8320 (ASCII_CHAR_WIDTH): Use it.
8321 * indent.c (sane_tab_width): Remove. All uses replaced by
8322 SANE_TAB_WIDTH (current_buffer).
8323 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8324
18c52557
PE
8325 * fileio.c: Integer overflow issues with file modes.
8326 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8327
caeeedc1
PE
8328 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8329 Remove unreachable code.
8330 (read_hex, load_charset_map_from_file): Check for integer overflow.
8331
6df6ae42 8332 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8333 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8334 (x_send_scroll_bar_event): Likewise. Check that the size does not
8335 exceed limits imposed by XClientMessageEvent, as well as the usual
8336 ptrdiff_t and size_t limits.
8337
b13995db
PE
8338 * keyboard.c: Overflow, signedness and related fixes.
8339 (make_lispy_movement): Use same integer type in forward decl
8340 that is used in the definition.
8341 (read_key_sequence, keyremap_step):
8342 Change bufsize argument back to int, undoing my 2011-03-30 change.
8343 We prefer signed types, and int is wide enough here.
8344 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8345 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8346 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8347 length, not size_t. Use ptrdiff_t for index, not int.
8348 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8349 possibility of integer overflow.
8350
13464394
PE
8351 Overflow, signedness and related fixes for images.
8352
8353 * dispextern.h (struct it.stack[0].u.image.image_id)
8354 (struct_it.image_id, struct image.id, struct image_cache.size)
8355 (struct image_cache.used, struct image_cache.ref_count):
8356 * gtkutil.c (update_frame_tool_bar):
8357 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8358 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8359 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8360 * nsmenu.m (update_frame_tool_bar):
8361 * xdisp.c (calc_pixel_width_or_height):
8362 * xfns.c (image_cache_refcount):
8363 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8364 on typical 64-bit hosts.
8365
8366 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8367 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8368 Omit unnecessary casts to int.
8369 (parse_image_spec): Check that integers fall into 'int' range
8370 when the callers expect that.
8371 (image_ascent): Redo ascent calculation to avoid int overflow.
8372 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8373 (lookup_image): Remove unnecessary tests.
8374 (xbm_image_p): Locals are now of int, not EMACS_INT,
8375 since parse_image_check makes sure they fit into int.
8376 (png_load, gif_load, svg_load_image):
8377 Prefer int to unsigned where either will do.
8378 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8379 old tiff_error_handler and tiff_warning_handler.
8380 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8381 stack buffer overflows. It uses only the features of vsnprintf
8382 that are common to both POSIX and native Microsoft.
8383 (tiff_error_handler, tiff_warning_handler): Use it.
8384 (tiff_load, gif_load, imagemagick_load_image):
8385 Don't assume :index value fits in 'int'.
8386 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8387 (imagemagick_load_image): Check that crop parameters fit into
8388 the integer types that MagickCropImage accepts. Don't assume
8389 Vimagemagick_render_type has a nonnegative value. Don't assume
8390 size_t fits in 'long'.
8391 (gs_load): Use printmax_t to print the widest integers possible.
8392 Check for integer overflow when computing image height and width.
8393
c11821d4
EZ
83942011-08-26 Eli Zaretskii <eliz@gnu.org>
8395
8396 * xdisp.c (redisplay_window): Don't force window start if point
8397 will be invisible in the resulting window. (Bug#9324)
8398
0c95fcf7
EZ
83992011-08-25 Eli Zaretskii <eliz@gnu.org>
8400
8401 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8402 the display spec is of the form `(space ...)'.
8403 (handle_display_spec): Return the value returned by
8404 handle_single_display_spec, not just 1 or zero.
8405 (handle_single_display_spec): If the display spec is of the form
8406 `(space ...)', and specifies display in the text area, return 2
8407 rather than 1.
fee65a97 8408 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8409 accurately, and prefer exact match for point under bidi.
8410 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8411
8412 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8413 into disp_prop; all users changed.
8414
8415 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8416 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8417 for the text covered by the display property.
8418
e4ed06f1
CY
84192011-08-25 Chong Yidong <cyd@stupidchicken.com>
8420
8421 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8422 Change return value to nil.
8423 (Frecord_buffer): Delete unused function.
8424
f67cdd7f
EZ
84252011-08-24 Eli Zaretskii <eliz@gnu.org>
8426
5980d4c6
EZ
8427 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8428 buffers, return left-to-right.
8610fe8b
EZ
8429 (set_cursor_from_row): Consider candidate row a win if its glyph
8430 represents a newline and point is on that newline. Fixes cursor
8431 positioning on the newline at EOL of R2L text within L2R
8432 paragraph, and vice versa.
8433 (try_cursor_movement): Check continued rows, in addition to
8434 continuation rows. Fixes unwarranted scroll when point enters a
8435 continued line of R2L text within an L2R paragraph, or vice versa.
8436 (cursor_row_p): Consider the case of point being equal to
8437 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8438 from the end of a short line to the beginning of a continued line
8439 of R2L text within L2R paragraph.
8440 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8441 composed characters.
5980d4c6 8442
f67cdd7f
EZ
8443 * bidi.c (bidi_check_type): Use xassert.
8444 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8445 members.
8446
bca633fb
EZ
84472011-08-23 Eli Zaretskii <eliz@gnu.org>
8448
8449 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8450 a character.
8451
4a5885a7
CY
84522011-08-23 Chong Yidong <cyd@stupidchicken.com>
8453
8454 * nsfont.m (ns_otf_to_script): Fix typo.
8455
0902a04e
KH
84562011-08-22 Kenichi Handa <handa@m17n.org>
8457
8458 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8459 extra slot even if the purpose is char-code-property-table.
8460
1a2e6670
EZ
84612011-08-23 Eli Zaretskii <eliz@gnu.org>
8462
8ddde651
EZ
8463 * xdisp.c (redisplay_window): When computing centering_position,
8464 account for the height of the header line. (Bug#8874)
8465
425cc014
EZ
8466 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8467 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8468 candidate is selected by the mouse, and that candidate has a
8469 composed character under the mouse.
8470
1a2e6670
EZ
8471 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8472 coordinates reported by pos-visible-in-window-p for a composed
8473 character in column zero.
8474
8b76d6f8
SM
84752011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8476
8477 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8478
dac347dd
EZ
84792011-08-22 Eli Zaretskii <eliz@gnu.org>
8480
8481 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8482 consider it a hit if to_charpos is anywhere in the range of the
8483 composed buffer positions.
8484
e013fb34
CY
84852011-08-22 Chong Yidong <cyd@stupidchicken.com>
8486
8487 * image.c (gif_load): Don't assume that each subimage has the same
8488 dimensions as the base image. Handle disposal method that is
8489 "undefined" by the gif spec (Bug#9335).
8490
bd1ba3e8
CY
84912011-08-20 Chong Yidong <cyd@stupidchicken.com>
8492
8493 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8494 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8495
54a1215b
EZ
84962011-08-19 Eli Zaretskii <eliz@gnu.org>
8497
823564e5
EZ
8498 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8499 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8500 from an Org mode buffer to a Speedbar frame.
8501
54a1215b
EZ
8502 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8503 a composition, take its buffer position from IT->cmp_it.charpos.
8504 Fixes cursor positioning at the beginning of a line that begins
8505 with a composed character.
8506
9778ebcc
EZ
85072011-08-18 Eli Zaretskii <eliz@gnu.org>
8508
0be6ee06
EZ
8509 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8510 character bidirectional type, use STRONG_L instead. Fixes crashes
8511 in a buffer produced by `describe-categories'.
8512
9778ebcc
EZ
8513 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8514 members before the level stack, so they would be saved and
8515 restored when copying iterator state. Fixes incorrect reordering
8516 around TABs covered by display properties.
8517
156bffbe
AS
85182011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8519
6b02f655 8520 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8521
72ad093b
CY
85222011-08-17 Chong Yidong <cyd@stupidchicken.com>
8523
8524 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8525 (internal_condition_case_2, internal_condition_case_n):
8526 Remove unnecessary aborts (Bug#9081).
72ad093b 8527
35774242
EZ
85282011-08-17 Eli Zaretskii <eliz@gnu.org>
8529
8530 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8531 has no `load' handler, try opening the file locally. (Bug#9311)
8532
db76dd85
KB
85332011-08-16 Ken Brown <kbrown@cornell.edu>
8534
8535 * gmalloc.c: Expand comment.
8536
b215eee5
EZ
85372011-08-16 Eli Zaretskii <eliz@gnu.org>
8538
8539 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8540 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8541
a4579d33
KB
85422011-08-16 Ken Brown <kbrown@cornell.edu>
8543
8544 Fix memory allocation problems in Cygwin build (Bug#9273).
8545
8546 * unexcw.c ( __malloc_initialized): Declare external variable.
8547 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8548
8b76d6f8
SM
8549 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8550 New variables.
a4579d33
KB
8551 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8552 dumped emacs.
8553 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8554 in the static heap.
8555 [CYGWIN] (special_realloc): New function.
8556 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8557 requests to realloc storage in the static heap.
8558
3ebec551
PE
85592011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8560
8561 * bidi.c (bidi_initialize): Remove unused local.
8562
9fd8be00
EZ
85632011-08-15 Eli Zaretskii <eliz@gnu.org>
8564
6b02f655
SM
8565 * bidimirror.h:
8566 * biditype.h: Remove file.
8567 * makefile.w32-in ($(BLD)/bidi.$(O)):
8568 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8569
8570 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8571
8572 * chartab.c: Improve commentary for the uniprop_table API.
8573
32413314
EZ
8574 * bidi.c (bidi_paragraph_init): Support zero value of
8575 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8576 (bidi_initialize): Use uniprop_table instead of including
8577 biditype.h and bidimirror.h.
32413314 8578
9fd8be00
EZ
8579 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8580 coordinates of the iterator when restoring from ppos_it.
8581 (Bug#9296)
8582
5cf2b69b
KH
85832011-08-14 Kenichi Handa <handa@m17n.org>
8584
8585 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8586 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8587
daf17d00
EZ
85882011-08-14 Eli Zaretskii <eliz@gnu.org>
8589
8590 * xdisp.c (move_it_in_display_line_to): Don't invoke
8591 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8592 ppos_it. Fixes vertical cursor motion when line beginning is
8593 covered by an image. (Bug#9296)
8594
08e3161a
JD
85952011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8596
8597 * nsterm.h (ns_run_ascript): Declare.
8598 (NSAPP_DATA2_RUNASSCRIPT): Define.
8599
8600 * nsfns.m (as_script, as_result, as_status): New static variables.
8601 (ns_run_ascript): New function.
5e617bc2 8602 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8603 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8604 the event loop. Get status from as_status (Bug#7276).
8605
8606 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8607 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8608 the event loop (Bug#7276).
8609
a3720aa2
AS
86102011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8611
8612 * gnutls.c (QCgnutls_bootprop_priority)
8613 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8614 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8615 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8616 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8617 (QCgnutls_bootprop_verify_hostname_error)
8618 (QCgnutls_bootprop_callbacks_verify): Rename from
8619 Qgnutls_bootprop_..., all uses changed.
8620
8621 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8622 uses changed.
8623
0a0d27fb
PE
86242011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8625
19d5c50c
PE
8626 * xfaces.c (Qframe_set_background_mode): Now static.
8627 * dispextern.h (Qframe_set_background_mode): Remove decl.
8628
0a0d27fb
PE
8629 * process.c (Fnetwork_interface_info): Declare local only if needed.
8630
377538cb
JD
86312011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8632
8633 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8634 (Fnetwork_interface_list): Allocate in increments of bytes instead
8635 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8636 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8637 sockaddr.
8638 (struct ifflag_def): notrailers is smart on OSX.
8639 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8640 Get hardware address with getifaddrs if available.
8641
08fff70c
EZ
86422011-08-12 Eli Zaretskii <eliz@gnu.org>
8643
8644 * xdisp.c (iterate_out_of_display_property): xassert that
8645 IT->position is set to within IT->object's boundaries. Break from
8646 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8647 when IT->position is set up wrongly due to some bug.
8648 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8649 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8650 entry. Force push_it to save on the stack the current
8651 buffer/string position, to be restored by pop_it. Fix flags in
8652 the iterator structure wrt the object coming from a display
8653 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8654 properties. (Bug#9284)
8655
7be1c708 86562011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8657
7be1c708
CY
8658 * fontset.c (fontset_get_font_group): Add proper type checks.
8659 (Bug#9172)
aac0c6e3 8660
7be1c708 86612011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8662
7be1c708
CY
8663 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8664 and LC_VERSION_MIN_MACOSX.
8665 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8666 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8667
97bb72a6
EZ
86682011-08-08 Eli Zaretskii <eliz@gnu.org>
8669
8670 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8671 no-display-properties-and-no-overlays under bidi display.
8672 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8673 properties and overlays.
97bb72a6 8674
d5617611
CY
86752011-08-08 Chong Yidong <cyd@stupidchicken.com>
8676
37e11a63
CY
8677 * editfns.c (Fset_time_zone_rule): Document relationship with the
8678 setenv function.
8679
d5617611
CY
8680 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8681 the font entity extracted from the cache (Bug#8109).
8682
58872834
CY
86832011-08-07 Chong Yidong <cyd@stupidchicken.com>
8684
8685 * composite.c (autocmp_chars): Don't reset point. That is done by
8686 restore_point_unwind (Bug#5984).
8687
75bfc667
JL
86882011-08-07 Juri Linkov <juri@jurta.org>
8689
8690 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8691 to show the arg `TIME' instead of `TIMEVAL'.
8692
d1410150
EZ
86932011-08-06 Eli Zaretskii <eliz@gnu.org>
8694
8695 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8696 display property strides EOL and includes a newline, as in
8697 longlines-mode. (Bug#9254)
75b771e4
EZ
8698 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8699 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8700
8701 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8702 is non-zero, even if the data buffer is NULL. Fixes a crash in
8703 vertical-motion with longlines-mode. (Bug#9254)
8704
35928349
EZ
87052011-08-05 Eli Zaretskii <eliz@gnu.org>
8706
ec7cc85b
EZ
8707 * bidi.c <bidi_cache_total_alloc>: Now static.
8708 (bidi_initialize): Initialize bidi_cache_total_alloc.
8709
8b76d6f8 8710 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8711 cache. (Bug#9221)
8712
8713 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8714 amount allocated this far in `bidi_cache_total_alloc'.
8715 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8716 non-zero, only free the data buffer without restoring the cache
8717 contents. All callers changed.
8718
8719 * dispextern.h (bidi_unshelve_cache): Update prototype.
8720
8721 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8722 (move_it_in_display_line, move_it_to)
8723 (move_it_vertically_backward, move_it_by_lines): Replace the call
8724 to xfree to an equivalent call to bidi_unshelve_cache.
8725 (move_it_in_display_line_to): Fix logic of returning
412b6358 8726 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8727
e2e2423b
EZ
87282011-08-05 Eli Zaretskii <eliz@gnu.org>
8729
8730 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8731 came from a string character with a `cursor' property. (Bug#9229)
8732
ae9e757a
JD
87332011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8734
8735 * Makefile.in (LIB_PTHREAD): New variable.
8736 (LIBES): Add LIB_PTHREAD (Bug#9216).
8737
8738 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8739 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8740
213bd7f2
AS
87412011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8742
6b02f655 8743 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8744
99aaf75f
JD
87452011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8746
8747 * xterm.c (x_find_topmost_parent): New function.
8748 (x_set_frame_alpha): Find topmost parent window with
8749 x_find_topmost_parent and set the property there also (bug#9181).
8750 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8751
c74e9d86
PE
87522011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8753
8754 * callproc.c (Fcall_process): Avoid vfork clobbering
8755 the local vars buffer, coding_systems, current_dir.
8756
640c8776
SM
87572011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8758
8759 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8760
f26d0e4c
PE
87612011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8762
8a10d76c
PE
8763 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8764 so that it is not optimized away.
8765
f26d0e4c
PE
8766 * xdisp.c (compute_display_string_pos): Remove unused local.
8767
55439c61
EZ
87682011-08-02 Eli Zaretskii <eliz@gnu.org>
8769
8770 Fix slow cursor motion and scrolling in large buffers with
8771 selective display, like Org Mode buffers. (Bug#9218)
8772
8773 * dispextern.h (struct bidi_it): New member disp_prop_p.
8774
8775 * xdisp.c: Remove one-slot cache of display string positions.
8776 (compute_display_string_pos): Accept an additional argument
5e617bc2 8777 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8778 for a display string or property. If found, set DISP_PROP_P
8779 non-zero.
8780
8781 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8782 DISP_PROP_P, and pass it to compute_display_string_pos.
8783 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8784 non-zero. All callers of bidi_fetch_char changed.
8785
fb33fa43
SM
87862011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8787
8788 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8789
b099e063
DM
87902010-12-03 Don March <don@ohspite.net>
8791
8792 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8793 last character M-[char] is translated to ESC [char] (bug#7541).
8794
5cc7f7af
KH
87952011-08-02 Kenichi Handa <handa@m17n.org>
8796
d0fffa3f 8797 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8798
8799 * chartab.c (uniprop_table): Make it non-static.
8800
525d5e6e
EZ
88012011-08-01 Eli Zaretskii <eliz@gnu.org>
8802
8803 * xdisp.c (forward_to_next_line_start): Accept additional argument
8804 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8805 on the newline.
8806 (reseat_at_next_visible_line_start): Use the bidi iterator state
8807 returned by forward_to_next_line_start to restore the state of
8808 it->bidi_it after backing up to previous newline. (Bug#9212)
8809
31011111
AS
88102011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8811
8812 * regex.c (re_comp): Protoize.
8813 (re_exec): Fix return type.
8814 (regexec): Fix type of `ret'. (Bug#9203)
8815
476371c4
PE
88162011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8817
e5d76069
PE
8818 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8819 This is needed if max-image-size is a floating-point number.
8820
9a79b20c
AS
88212011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8822
8823 * print.c (print_object): Print empty symbol as ##.
8824
8825 * lread.c (read1): Read ## as empty symbol.
8826
d8c2fa78
AA
88272011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8828
8829 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8830 setting frame foreground color (Bug#9175).
8831 (x_set_background_color): Likewise.
8832
ffe57a7a
AA
8833 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8834 contents (Bug#9176).
8835 (EmacsTooltip -init): Remove bezels and add shadows to
8836 tooltip windows.
8837
bf3492a5
AA
8838 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8839 or scroll bar (Bug#8470).
8840
d55e9c53
AA
8841 * nsfont.m (nsfont_open): Remove assignment to voffset and
8842 unnecessary vars hshink, expand, hd, full_height, min_height.
8843 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8844
8845 * nsterm.h (nsfont_info): Remove voffset field.
8846
d8c2fa78 88472011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8848
8849 Implement strike-through and overline on NextStep (Bug#8863).
8850
8851 * nsfont.m (nsfont_open): Use underline position provided by font,
8852 instead of hard-coded value of 2.
8853 (nsfont_draw): Call ns_draw_text_decoration instead.
8854
8855 * nsterm.h: Add declaration for ns_draw_text_decoration.
8856
8857 * nsterm.m (ns_draw_text_decoration): New function for drawing
8858 underline, overline, and strike-through.
8859 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8860 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8861 accommodate underlining, etc.
4843aac3 8862
4cc60b9b
EZ
88632011-07-28 Eli Zaretskii <eliz@gnu.org>
8864
bc7ece87
EZ
8865 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8866 default.
4cc60b9b 8867
476371c4
PE
88682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8869
66606eea
PE
8870 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8871 Without this fix, if a signal arrives just after memory fills up,
8872 'malloc' might be invoked reentrantly.
8873
476371c4
PE
8874 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8875 In other words, assume that every image size is allowed, on non-X
8876 hosts. This assumption is probably wrong, but it lets Emacs compile.
8877
f3fcc40d
AS
88782011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8879
8880 * regex.c (re_iswctype): Convert return values to boolean.
8881
350c992f
EZ
88822011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8883
8884 * xdisp.c (compute_display_string_pos): Don't use cached display
8885 string position if the buffer had its restriction changed.
8886 (Bug#9184)
8887
5266b4bb
PE
88882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8889
8890 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8891
2573a837 88922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8893
41f55ccd 8894 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8895
39e378da
PE
8896 * bidi.c: Integer size and overflow fixes.
8897 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8898 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8899 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8900 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8901 (bidi_find_other_level_edge):
8902 Use ptrdiff_t instead of EMACS_INT where either will do.
8903 This works better on 32-bit hosts configured --with-wide-int.
8904 (bidi_cache_ensure_space): Check for size-calculation overflow.
8905 Use % rather than repeated addition, for better worst-case speed.
8906 Don't set bidi_cache_size until after xrealloc returns, because it
8907 might not return.
8908 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8909 (bidi_cache_ensure_space): Also check that the bidi cache size
8910 does not exceed that of the largest Lisp string or buffer. See Eli
8911 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8912
5e927815
PE
8913 * alloc.c (__malloc_size_t): Remove.
8914 All uses replaced by size_t. See Andreas Schwab's note
8915 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8916
ca4aa935
PE
8917 * image.c: Improve checking for integer overflow.
8918 (check_image_size): Assume that f is nonnull, since
8919 it is always nonnull in practice. This is one less thing to
8920 worry about when checking for integer overflow later.
8921 (x_check_image_size): New function, which checks for integer
8922 overflow issues inside X.
8923 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8924 This removes the need for a memory_full check.
8925 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8926 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8927 (xbm_read_bitmap_data): Change locals back to 'int', since
8928 their values must fit in 'int'.
8929 (xpm_load_image, png_load, tiff_load):
8930 Invoke x_create_x_image_and_pixmap earlier,
8931 to avoid much needless work if the image is too large.
8932 (tiff_load): Treat overly large images as if
8933 x_create_x_image_and_pixmap failed, not as malloc failures.
8934 (gs_load): Use x_check_image_size.
8935
5f8f9cc2
PE
8936 * gtkutil.c: Omit integer casts.
8937 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8938 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8939
5adf60bc
PE
8940 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8941
c8907a93
PE
8942 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8943 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8944 would wrongly return t on a 64-bit host.
8945
e3c25c68
PE
8946 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8947 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8948 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8949 and therefore cause GCC to emit a bogus diagnostic in some cases.
8950
3f791afe
PE
8951 * image.c: Integer signedness and overflow and related fixes.
8952 This is not an exhaustive set of fixes, but it's time to
8953 record what I've got.
8954 (lookup_pixel_color, check_image_size): Remove redundant decls.
8955 (check_image_size): Don't assume that arbitrary EMACS_INT values
8956 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8957 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8958 (tiff_load, imagemagick_load_image):
8959 Check for overflow in size calculations.
8960 (x_create_x_image_and_pixmap): Remove unnecessary test for
8961 xmalloc returning NULL; that can't happen.
8962 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8963 (xpm_color_bucket): Use better integer hashing function.
8964 (xpm_cache_color): Don't possibly over-allocate memory.
8965 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8966 (gif_memory_source):
8967 Use ptrdiff_t, not int or size_t, to record sizes.
8968 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8969 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8970 either works, as we prefer signed integers.
8971 (tiff_read_from_memory, tiff_write_from_memory):
8972 Return tsize_t, not size_t, since that's what the TIFF API wants.
8973 (tiff_read_from_memory): Don't fail simply because the read would
8974 go past EOF; instead, return a short read.
8975 (tiff_load): Omit no-longer-needed casts.
8976 (Fimagemagick_types): Don't assume size fits into 'int'.
8977
3cc5a532
PE
8978 Improve hashing quality when configured --with-wide-int.
8979 * fns.c (hash_string): New function, taken from sxhash_string.
8980 Do not discard information about ASCII character case; this
8981 discarding is no longer needed.
8982 (sxhash-string): Use it. Change sig to match it. Caller changed.
8983 * lisp.h: Declare it.
8984 * lread.c (hash_string): Remove, since we now use fns.c's version.
8985 The fns.c version returns a wider integer if --with-wide-int is
8986 specified, so this should help the quality of the hashing a bit.
8987
b312a492
PE
8988 * emacs.c: Integer overflow minor fix.
8989 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8990 Define only if GNU_LINUX.
8991 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8992
dfd153ae
PE
8993 * dispnew.c: Integer signedness and overflow fixes.
8994 Remove unnecessary forward decls, that were a maintenance hassle.
8995 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8996 All uses changed.
8997 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8998 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8999 (prepare_desired_row, line_draw_cost):
9000 Use int, not unsigned, where either works.
9001 (save_current_matrix, restore_current_matrix):
9002 Use ptrdiff_t, not size_t, where either works.
9003 (init_display): Check for overflow more accurately, and without
9004 relying on undefined behavior.
9005
a81d11a3
PE
9006 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9007 Remove, replacing with the new symbols in lisp.h. All uses changed.
9008 * fileio.c (make_temp_name):
9009 * filelock.c (lock_file_1, lock_file):
9010 * xdisp.c (message_dolog):
9011 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9012 Use pMd etc. instead.
9013 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9014 replacing the pWIDE etc. symbols removed from editfns.c.
9015
3300e6fd
PE
9016 * keyboard.h (num_input_events): Now uintmax_t.
9017 This is (very slightly) less likely to mess up due to wraparound.
9018 All uses changed.
9019
fd05c7e9
PE
9020 * buffer.c: Integer signedness fixes.
9021 (alloc_buffer_text, enlarge_buffer_text):
9022 Use ptrdiff_t rather than size_t when either will do, as we prefer
9023 signed integers.
9024
903fe15d
PE
9025 * alloc.c: Integer signedness and overflow fixes.
9026 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9027 (__malloc_size_t): Default to size_t, not to int.
9028 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9029 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9030 Prefer ptrdiff_t to size_t when either would do, as we prefer
9031 signed integers.
9032 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9033 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9034 Now const. Initialize with values that are in range even if char
9035 is signed.
9036 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9037 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9038 These functions do the right thing with sizes > 2**32.
9039 (check_depth): Now ptrdiff_t, not int.
9040 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9041 Adjust to new way of storing sizes. Check for size overflow bugs
9042 in rest of code.
9043 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9044 slightly wrong anyway, as it missed one instance of
9045 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9046 (refill_memory_reserve): Omit needless cast to size_t.
9047 (mark_object_loop_halt): Mark as externally visible.
9048
ac82cc6a
PE
9049 * xselect.c: Integer signedness and overflow fixes.
9050 (Fx_register_dnd_atom, x_handle_dnd_message):
9051 Use ptrdiff_t, not size_t, since we prefer signed.
9052 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9053 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9054 x_dnd_atoms_size and x_dnd_atoms_length.
9055
c2d1e36d
PE
9056 * doprnt.c: Prefer signed to unsigned when either works.
9057 * eval.c (verror):
9058 * doprnt.c (doprnt):
9059 * lisp.h (doprnt):
9060 * xdisp.c (vmessage):
9061 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9062 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9063 prefer signed arithmetic to avoid comparison confusion.
9064 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9065 but is a bit tricky.
9066
0e926e56
PE
9067 Assume freestanding C89 headers, string.h, stdlib.h.
9068 * data.c, doprnt.c, floatfns.c, print.c:
9069 Include float.h unconditionally.
9070 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9071 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9072 * regex.c: Likewise for stddef.h, string.h.
9073 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9074 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9075 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9076 (STDC_HEADERS): Remove obsolete defines.
9077 * sysdep.c: Include limits.h unconditionally.
9078
9cfdb3ec
PE
9079 Assume support for memcmp, memcpy, memmove, memset.
9080 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9081 * regex.c (memcmp, memcpy):
9082 Remove; we assume C89 now.
9083
9084 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9085 (__malloc_safe_bcopy): Remove; no longer needed.
9086
cf950e6b 9087 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9088 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9089 well either way, and we prefer signed to unsigned.
9090
dbf38e02
LMI
90912011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9092
9093 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9094 closes the connection while we're reading (bug#9182).
9095
d6f0886c 90962011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9097
d6f0886c
JD
9098 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9099 are specified (Bug#9168).
24e0f6b1 9100
2eb1f9e6
PE
91012011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9102
9103 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9104 Found by GCC static checking and --with-wide-int on a 32-bit host.
9105
22381272 91062011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9107
9108 * xdisp.c (compute_display_string_pos): Fix logic of caching
9109 previous display string position. Initialize cached_prev_pos to
9110 -1. Fixes slow-down at the beginning of a buffer.
9111
f25e39b4
EZ
91122011-07-24 Eli Zaretskii <eliz@gnu.org>
9113
9114 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9115 for attrs[LFACE_FONTSET_INDEX].
9116
04c4b52e
PE
91172011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9118
9119 * xml.c (parse_region): Remove unused local
9120 that was recently introduced.
9121
c1734fbd
EZ
91222011-07-23 Eli Zaretskii <eliz@gnu.org>
9123
be18c5a5
EZ
9124 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9125 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9126
c1734fbd
EZ
9127 * xdisp.c (move_it_in_display_line_to): Record the best matching
9128 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9129 exit if none of the characters scanned was an exact match.
9130 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9131 when exact match is impossible due to invisible text, and the
9132 lines are truncated.
9133
a258d627
JD
91342011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9135
9136 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9137 for OSX >= 10.7.
9138
b6d5a689
EZ
91392011-07-22 Eli Zaretskii <eliz@gnu.org>
9140
0f74f785
EZ
9141 Fix a significant slow-down of cursor motion with C-n, C-p,
9142 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9143 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9144 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9145 (next_element_from_buffer): Call compute_stop_pos_backwards to
9146 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9147 base_level_stop.
9148 (reseat): Don't look for prev_stop, as that could mean a very long
9149 run.
9150 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9151 <cached_disp_overlay_modiff>: Cache for last found display string
9152 position.
551918c1 9153 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9154 about the same buffer in the same area of character positions, and
9155 the buffer wasn't changed since the time the display string
9156 position was cached.
551918c1 9157
b2d0c91a
EZ
91582011-07-22 Eli Zaretskii <eliz@gnu.org>
9159
9160 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9161 is an integer, which is important for empty lines. (Bug#9149)
9162
043604ee
CY
91632011-07-22 Chong Yidong <cyd@stupidchicken.com>
9164
9165 * frame.c (Fmodify_frame_parameters): In tty case, update the
9166 default face if necessary (Bug#4238).
9167
da4adb04
CY
91682011-07-21 Chong Yidong <cyd@stupidchicken.com>
9169
9170 * editfns.c (Fstring_to_char): No need to explain what a character
9171 is in the docstring (Bug#6576).
9172
9abd0532
LMI
91732011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9174
9175 * xml.c (parse_region): Make sure we always return a tree.
9176
36881d16
HK
91772011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9178
9179 * xml.c (parse_region): If a document contains only comments,
9180 return that, too.
9181
1e98674d
LMI
91822011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9183
9184 * xml.c (make_dom): Return comments, too.
9185
590bd467
PE
91862011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9187
9188 Port to OpenBSD.
9189 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9190 and the surrounding thread.
9191 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9192 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9193 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9194 timer goes off.
9195 * s/openbsd.h (BROKEN_SIGIO): Define.
9196 * unexelf.c (unexec) [__OpenBSD__]:
9197 Don't update the .mdebug section of the Alpha COFF symbol table.
9198
f41628b2
LMI
91992011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9200
9201 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9202 (bug#8460).
9203
b59b67c5
PE
92042011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9205
15e3a074
PE
9206 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9207 This fixes some race conditions on the permissions of any newly
9208 created file.
9209
41bed37d
PE
9210 * alloc.c (valid_pointer_p): Use pipe, not open.
9211 This fixes some permissions issues when debugging.
9212
b59b67c5
PE
9213 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9214 If fchown fails to set both uid and gid, try to set just gid,
9215 as that is sometimes allowed. Adjust the file's mode to eliminate
9216 setuid or setgid bits that are inappropriate if fchown fails.
9217
925a6be7
SM
92182011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9219
9220 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9221 to compare Lisp_Objects.
9222 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9223 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9224 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9225
52968808
AS
92262011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9227
0a6a104b
AS
9228 * lread.c (read_integer): Unread even EOF character.
9229 (read1): Likewise. Properly record start position of symbol.
9230
52968808
AS
9231 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9232 symbol character follows.
9233
9e381cdd
PE
92342011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9235
9236 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9237 This works around a problem with the previous change to Fcopy_file.
9238 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9239 and without this change, GCC might complain about discarding
9240 fchown's return value.
9241
b5641435
JB
92422011-07-16 Juanma Barranquero <lekktu@gmail.com>
9243
9244 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9245
a8031457
PE
92462011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9247
9248 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9249
dd889327
LMI
92502011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9251
750c33f7
LMI
9252 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9253 it's used from the C level.
9254
dd889327
LMI
9255 * process.c: Use the same condition for POLL_FOR_INPUT in both
9256 keyboard.c and process.c (bug#1858).
9257
87e86684
LM
92582011-07-09 Lawrence Mitchell <wence@gmx.li>
9259
9260 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9261 (Fgnutls_boot): Use it.
9262
64348f40
AS
92632011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9264
9265 * doc.c (Fsubstitute_command_keys): Revert last change.
9266
1d698799
LMI
92672011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9268
f863868c
LMI
9269 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9270 quotes the next character, and doesn't affect other longer
9271 sequences (bug#8935).
9272
1d698799
LMI
9273 * lread.c (syms_of_lread): Clarify that is isn't only
9274 `eval-buffer' and `eval-defun' that's affected by
9275 `lexical-binding' (bug#8460).
9276
aa4b6df6
EZ
92772011-07-15 Eli Zaretskii <eliz@gnu.org>
9278
9279 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9280 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9281
5d856da6
PE
92822011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9283
ad6042bb
PE
9284 Fix minor problems found by static checking.
9285 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9286 (elsz): Now a signed constant, not a size_t var. We prefer signed
9287 types to unsigned, to avoid integer comparison confusion. Without
9288 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9289 "cannot optimize loop, the loop counter may overflow", a symptom
9290 of the confusion.
f00bbb22 9291 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9292 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9293
6468f31c
LMI
92942011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9295
49080b10
LMI
9296 * search.c (Fre_search_backward): Mention `case-fold-search' in
9297 all the re_search_* functions (bug#8138).
9298
6468f31c
LMI
9299 * keyboard.c (Fopen_dribble_file): Document when the file is
9300 closed (bug#8056).
9301
c965adc5
EZ
93022011-07-14 Eli Zaretskii <eliz@gnu.org>
9303
df9733bf
EZ
9304 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9305 bidi_cache_idx.
9306
0bb23927
EZ
9307 Support bidi reordering of display and overlay strings.
9308 * xdisp.c (compute_display_string_pos)
9309 (compute_display_string_end): Accept additional argument STRING.
9310 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9311 (reseat_to_string): Initialize bidi_it->string.s and
9312 bidi_it->string.schars.
9313 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9314 NULL (avoids a crash in bidi_paragraph_init).
9315 Initialize itb.string.lstring.
0bb23927
EZ
9316 (init_iterator): Call bidi_init_it only of a valid
9317 buffer position was specified. Initialize paragraph_embedding to
9318 L2R.
9319 (reseat_to_string): Initialize the bidi iterator.
9320 (display_string): If we need to ignore text properties of
9321 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9322 original value of -1 will not work with bidi.)
9323 (compute_display_string_pos): First arg is now struct
9324 `text_pos *'; all callers changed. Support display properties on
9325 Lisp strings.
9326 (compute_display_string_end): Support display properties on Lisp
9327 strings.
9328 (init_iterator, reseat_1, reseat_to_string): Initialize the
9329 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9330 when iterating on a string not from display properties).
640c8776
SM
9331 (compute_display_string_pos, compute_display_string_end):
9332 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9333 arrow keys.
9334 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9335 base_level_stop; instead, set base_level_stop to BEGV.
9336 Fixes crashes in vertical-motion.
0bb23927
EZ
9337 (next_element_from_buffer): Improve commentary for when
9338 the iterator is before prev_stop.
9339 (init_iterator): Initialize bidi_p from the default value of
9340 bidi-display-reordering, not from buffer-local value. Use the
9341 buffer-local value only if initializing for buffer iteration.
9342 (handle_invisible_prop): Support invisible properties on strings
9343 that are being bidi-reordered.
9344 (set_iterator_to_next): Support bidi reordering of C strings and
9345 Lisp strings.
9346 (next_element_from_string): Support bidi reordering of Lisp
9347 strings.
9348 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9349 (display_string): Support display of R2L glyph rows.
9350 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9351 (init_iterator): Don't initialize it->bidi_p for strings
9352 here.
9353 (reseat_to_string): Initialize it->bidi_p for strings here.
9354 (next_element_from_string, next_element_from_c_string)
9355 (next_element_from_buffer): Add xassert's for correspondence
9356 between IT's object being iterated and it->bidi_it.string
9357 structure.
9358 (face_before_or_after_it_pos): Support bidi iteration.
9359 (next_element_from_c_string): Handle the case of the first string
9360 character that is not the first one in the visual order.
9361 (get_visually_first_element): New function, refactored from common
9362 parts of next_element_from_buffer, next_element_from_string, and
9363 next_element_from_c_string.
9364 (tool_bar_lines_needed, redisplay_tool_bar)
9365 (display_menu_bar): Force left-to-right direction. Add a FIXME
9366 comment for making that be controlled by a user option.
9367 (push_it, pop_it): Save and restore the state of the
9368 bidi iterator. Save and restore the bidi_p flag.
9369 (pop_it): Iterate out of display property for string iteration as
9370 well.
9371 (iterate_out_of_display_property): Support iteration over strings.
9372 (handle_single_display_spec): Set up it->bidi_it for iteration
9373 over a display string, and call bidi_init_it.
9374 (handle_single_display_spec, next_overlay_string)
9375 (get_overlay_strings_1, push_display_prop): Set up the bidi
9376 iterator for displaying display or overlay strings.
9377 (forward_to_next_line_start): Don't use the shortcut if
9378 bidi-iterating.
9379 (back_to_previous_visible_line_start): If handle_display_prop
9380 pushed the iterator stack, restore the internal state of the bidi
9381 iterator by calling bidi_pop_it same number of times.
9382 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9383 and we are bidi-iterating, don't decrement the iterator position;
9384 instead, set the first_elt flag in the bidi iterator, to produce
9385 the same effect.
9386 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9387 (push_display_prop): xassert that we are iterating a buffer.
9388 (push_it, pop_it): Save and restore paragraph_embedding member.
9389 (handle_single_display_spec, next_overlay_string)
9390 (get_overlay_strings_1, reseat_1, reseat_to_string)
9391 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9392 correctly. Don't assume unibyte strings are not bidi-reordered.
9393 (compute_display_string_pos)
9394 (compute_display_string_end): Fix handling the case of C string.
9395 (push_it, pop_it): Save and restore from_disp_prop_p.
9396 (handle_single_display_spec, push_display_prop): Set the
9397 from_disp_prop_p flag.
9398 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9399 (pop_it): Call iterate_out_of_display_property only if we are
9400 popping after iteration over a string that came from a display
9401 property. Fix a typo in popping stretch info. Add an assertion
9402 for verifying that the iterator position is in sync with the bidi
9403 iterator.
9404 (handle_single_display_spec, get_overlay_strings_1)
9405 (push_display_prop): Fix initialization of paragraph direction for
9406 string when that of the parent object is not yet determined.
9407 (reseat_1): Call bidi_init_it to resync the bidi
9408 iterator with IT's position. (Bug#7616)
9409 (find_row_edges): If ROW->start.pos gives position
9410 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9411 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9412 Reset the from_disp_prop_p flag.
9413 (SAVE_IT, RESTORE_IT): New macros.
9414 (pos_visible_p, face_before_or_after_it_pos)
9415 (back_to_previous_visible_line_start)
9416 (move_it_in_display_line_to, move_it_in_display_line)
9417 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9418 (try_scrolling, redisplay_window, display_line): Use them when
9419 saving a temporary copy of the iterator and restoring it back.
9420 (back_to_previous_visible_line_start, reseat_1)
9421 (init_iterator): Empty the bidi cache "stack".
9422 (move_it_in_display_line_to): If iterator ended up at
9423 EOL, but we never saw any buffer positions smaller than
9424 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9425 motion in bidi-reordered lines.
9426 (move_it_in_display_line_to): Record prev_method and prev_pos
9427 immediately before the call to set_iterator_to_next. Fixes cursor
9428 motion in bidi-reordered lines with stretch glyphs and strings
9429 displayed in margins. (Bug#8133) (Bug#8867)
9430 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9431 TO_CHARPOS.
640c8776
SM
9432 (pos_visible_p): Support positions in bidi-reordered lines.
9433 Save and restore bidi cache.
0bb23927
EZ
9434
9435 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9436 (bidi_paragraph_info): Delete unused struct.
9437 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9438 (bidi_cache_start): New variable.
9439 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9440 to zero.
9441 (bidi_cache_fetch_state, bidi_cache_search)
9442 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9443 (bidi_cache_find, bidi_peek_at_next_level)
9444 (bidi_level_of_next_char, bidi_find_other_level_edge)
9445 (bidi_move_to_visually_next): Compare cache index with
9446 bidi_cache_start rather than with zero.
9447 (bidi_fetch_char): Accept new argument STRING; all callers
9448 changed. Support iteration over a string. Support strings with
9449 display properties. Support unibyte strings. Fix the type of
9450 `len' according to what STRING_CHAR_AND_LENGTH expects.
9451 (bidi_paragraph_init, bidi_resolve_explicit_1)
9452 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9453 (bidi_level_of_next_char, bidi_move_to_visually_next):
9454 Support iteration over a string.
0bb23927
EZ
9455 (bidi_set_sor_type, bidi_resolve_explicit_1)
9456 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9457 can now be zero (for strings); special values 0 and -1 were
9458 changed to -1 and -2, respectively.
9459 (bidi_char_at_pos): New function.
9460 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9461 Call it instead of FETCH_MULTIBYTE_CHAR.
9462 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9463 initialized to valid values.
9464 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9465 values.
9466 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9467 the test for valid cached positions. Fix the logic for looking up
9468 the sentinel state in the cache. GCPRO the Lisp string we are
9469 iterating.
9470 (bidi_push_it, bidi_pop_it): New functions.
9471 (bidi_initialize): Initialize the bidi cache start stack pointer.
9472 (bidi_cache_ensure_space): New function, refactored from part of
9473 bidi_cache_iterator_state. Don't assume the required size is just
9474 one BIDI_CACHE_CHUNK away.
9475 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9476 (bidi_count_bytes, bidi_char_at_pos): New functions.
9477 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9478 always valid if bidi_cache_idx is valid.
9479 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9480 is valid if it's going to be used.
9481 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9482 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9483 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9484 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9485 (bidi_find_other_level_edge, bidi_cache_start_stack):
9486 All variables related to cache indices are now EMACS_INT.
c965adc5 9487
0bb23927
EZ
9488 * dispextern.h (struct bidi_string_data): New structure.
9489 (struct bidi_it): New member `string'. Make flag members be 1-bit
9490 fields, and put them last in the struct.
640c8776
SM
9491 (compute_display_string_pos, compute_display_string_end):
9492 Update prototypes.
0bb23927
EZ
9493 (bidi_push_it, bidi_pop_it): Add prototypes.
9494 (struct iterator_stack_entry): New members bidi_p,
9495 paragraph_embedding, and from_disp_prop_p.
9496 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9497 (bidi_shelve_cache, bidi_unshelve_cache):
9498 Declare prototypes.
0bb23927
EZ
9499
9500 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9501 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9502 and vector-like objects.
9503
9504 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9505 cache around display iteration.
9506
9507 * window.c (Fwindow_end, window_scroll_pixel_based)
9508 (displayed_window_lines, Frecenter): Save and restore the bidi
9509 cache around display iteration.
9510
3bbd2265
LMI
95112011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9512
9513 * editfns.c (Fdelete_region): Clarify the use of the named
9514 parameters (bug#6788).
9515
adc47434
MR
95162011-07-14 Martin Rudalics <rudalics@gmx.at>
9517
9518 * indent.c (Fvertical_motion): Set and restore w->pointm when
9519 saving and restoring the window's buffer (Bug#9006).
9520
837c31f8
LMI
95212011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9522
9523 * editfns.c (Fstring_to_char): Clarify just what is returned
9524 (bug#6576). Text by Eli Zaretskii.
9525
ac389d0c
JB
95262011-07-13 Juanma Barranquero <lekktu@gmail.com>
9527
9528 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9529
0be0ce47
EZ
95302011-07-13 Eli Zaretskii <eliz@gnu.org>
9531
9532 * buffer.c (mmap_find): Fix a typo.
9533
cd18e7e3
JB
95342011-07-13 Johan Bockgård <bojohan@gnu.org>
9535
9536 Fix execution of x selection hooks.
9537 * xselect.c (Qx_lost_selection_functions)
9538 (Qx_sent_selection_functions): New vars.
9539 (syms_of_xselect): DEFSYM them.
9540 (x_handle_selection_request): Pass Qx_sent_selection_functions
9541 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9542 (x_handle_selection_clear,x_clear_frame_selections):
9543 Pass Qx_lost_selection_functions rather than
9544 Vx_lost_selection_functions to Frun_hook_with_args.
9545
47ea7f44
PE
95462011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9547
ac389d0c 9548 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9549 The old code sometimes used this field without initializing it.
9550
47ea7f44
PE
9551 * alloc.c (gc_sweep): Don't read past end of array.
9552 In theory, the old code could also have corrupted Emacs internals,
9553 though it'd be very unlikely.
9554
bc985c87
AS
95552011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9556
9557 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9558 argument. (Bug#4026)
bc985c87 9559
0cf34688
LMI
95602011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9561
b3dadd76
LMI
9562 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9563 key" (bug#4257).
9564
0cf34688
LMI
9565 * window.c (Fset_window_start): Doc fix (bug#4199).
9566 (Fset_window_hscroll): Ditto.
9567
270768cd
PE
95682011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9569
077e3dda 9570 Fix minor new problems caught by GCC 4.6.1.
270768cd 9571 * term.c (init_tty): Remove unused local.
490011a6 9572 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9573 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9574 not used otherwise.
270768cd 9575
b1f58454
CY
95762011-07-12 Chong Yidong <cyd@stupidchicken.com>
9577
9578 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9579
22b9578d
LMI
95802011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9581
6e70ab07
LMI
9582 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9583 are the mini-buffer and the echo area (bug#3320).
9584
22b9578d
LMI
9585 * term.c (init_tty): Remove support for supdup, c10 and perq
9586 terminals, which are no longer supported (bug#1482).
9587
8974cc9f
JB
95882011-07-10 Johan Bockgård <bojohan@gnu.org>
9589
9590 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9591
a560d974
JD
95922011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9593
9594 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9595 for non-popups (Bug#3642).
9596
1dae0f0a
AS
95972011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9598
268c2c36 9599 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9600 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9601 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9602 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9603 * data.c (fmod): Likewise.
9604 * dispnew.c (swap_glyphs_in_rows): Likewise.
9605 * emacs.c (memory_warning_signal): Likewise.
9606 * floatfns.c (float_error): Likewise.
9607 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9608 (otf_open, font_otf_capability, generate_otf_features)
9609 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9610 Likewise.
9611 * image.c (pbm_read_file): Likewise.
9612 * indent.c (string_display_width): Likewise.
9613 * intervals.c (check_for_interval, search_for_interval)
9614 (inc_interval_count, count_intervals, root_interval)
9615 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9616 * lread.c (defalias): Likewise.
268c2c36 9617 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9618 * regex.c (set_image_of_range_1, set_image_of_range)
9619 (regex_grow_registers): Likewise.
9620 * sysdep.c (strerror): Likewise.
9621 * termcap.c (valid_filename_p, tprint, main): Likewise.
9622 * tparam.c (main): Likewise.
9623 * unexhp9k800.c (run_time_remap, save_data_space)
9624 (update_file_ptrs, read_header, write_header, calculate_checksum)
9625 (copy_file, copy_rest, display_header): Likewise.
9626 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9627 Likewise.
9628 * xdisp.c (check_it): Likewise.
9629 * xfaces.c (register_color, unregister_color, unregister_colors):
9630 Likewise.
9631 * xfns.c (print_fontset_result): Likewise.
9632 * xrdb.c (member, fatal, main): Likewise.
9633
99033785
PE
96342011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9635
9636 Fix minor problems found by static checking (Bug#9031).
9637 * chartab.c (char_table_set_range, map_sub_char_table):
9638 Remove unused locals.
9639 (uniprop_table): Now static.
9640 * composite.c (_work_char): Remove unused static var.
9641
9cb2ac56
JB
96422011-07-09 Juanma Barranquero <lekktu@gmail.com>
9643
9644 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9645
f25661f0
JD
96462011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9647
9648 * gtkutil.c (qttip_cb): Remove code without function.
9649
8278c4fe
EZ
96502011-07-09 Eli Zaretskii <eliz@gnu.org>
9651
9652 * w32.c (pthread_sigmask): New stub.
9653
1692ae2d 96542011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9655
8a6ebd58 9656 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9657 sigprocmask is portable only for single-threaded applications, and
9658 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9659 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9660 (LIBES): Use it.
9661 * callproc.c (Fcall_process):
9662 * process.c (create_process):
9663 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9664 Use pthread_sigmask, not sigprocmask.
123403e4 9665
1b854618
JD
96662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9667
9668 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9669 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9670 wrong (Bug#8591).
9671
3fe4b549
JD
96722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9673
0ce7e563
JD
9674 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9675 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9676 (xg_hide_tooltip): Fix comment.
9677
3fe4b549
JD
9678 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9679 in registerServicesMenuSendTypes.
9680 (validRequestorForSendType): Don't check ns_return_types.
9681
9682 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9683 ns_return_type.
9684
5df75e47
JR
96852011-07-08 Jason Rumney <jasonr@gnu.org>
9686
22610910
JR
9687 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9688 SH_SHOW for hidden windows (Bug#5482).
9689
5df75e47
JR
9690 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9691 frame struct members of non-existent frames (Bug#6284).
9692
699c10bd
JD
96932011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9694
4393663b
JD
9695 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9696 variable firstTime not needed on OSX >= 10.6.
9697 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9698 >= 10.5. Use setKnobProportion, setDoubleValue.
9699
9700 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9701 (MAC_OS_X_VERSION_10_5): Define if not defined.
9702 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9703 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9704 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9705
9706 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9707 cString and lossyCString on OSX >= 10.4.
4393663b 9708
58179cce 9709 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9710 sizeToFit on OSX >= 10.2.
9711
9712 * nsimage.m (allocInitFromFile): Don't use deprecated method
9713 bestRepresentationForDevice on OSX >= 10.6.
9714
9715 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9716 to avoid warning.
9717
9718 * emacs.c: Declare unexec_init_emacs_zone.
9719
a63e0781
JD
9720 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9721
699c10bd
JD
9722 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9723
9724 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9725 on svcsMenu (Bug#8842).
9726
9727 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9728 ns_return_types.
9729 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9730
9731 * nsterm.m (QUTF8_STRING): Declare.
9732 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9733 (validRequestorForSendType): Return type is (id).
9734 Change indexOfObjectIdenticalTo to indexOfObject.
9735 Check if we have local selection before returning self (Bug#8842).
9736 (writeSelectionToPasteboard): Put local selection into paste board
9737 if we have a local selection (Bug#8842).
9738 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9739
9740 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9741 (ns_get_local_selection): Declare.
9742
54e10184
LMI
97432011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9744
9888ff71
LMI
9745 * keymap.c (describe_map_tree): Don't insert a double newline at
9746 the end of the buffer (bug#1169) and return whether we inserted
9747 something.
9748
54e10184
LMI
9749 * callint.c (Fcall_interactively): Change "reading args" to
9750 "providing args" to try to clarify what it does (bug#1010).
9751
15fa4783
KH
97522011-07-07 Kenichi Handa <handa@m17n.org>
9753
9754 * composite.c (composition_compute_stop_pos): Ignore a static
9755 composition starting before CHARPOS (Bug#8915).
9756
9757 * xdisp.c (handle_composition_prop): Likewise.
9758
a8815b00
EZ
97592011-07-07 Eli Zaretskii <eliz@gnu.org>
9760
9761 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9762 (Bug#9015)
9763
ef7b981d 97642011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9765
9766 * character.h (unicode_category_t): New enum type.
9767
9768 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9769 (Qchar_code_property_table): New variable.
9770 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9771 (UNIPROP_COMPRESSED_FORM_P): New macros.
9772 (char_table_ascii): Uncompress the compressed values.
9773 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9774 Uncompress the compressed values.
ac389d0c 9775 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9776 (char_table_ref_and_range): Uncompress the compressed values.
9777 (sub_char_table_set): New arg is_uniprop. Callers changed.
9778 Uncompress the compressed values.
9779 (sub_char_table_set_range): Args changed. Callers changed.
9780 (char_table_set_range): Adjuted for the above change.
9781 (map_sub_char_table): Delete args default_val and parent. Add arg
9782 top. Give decoded values to a Lisp function.
640c8776 9783 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9784 values to a Lisp function. Gcpro more variables.
9785 (uniprop_table_uncompress)
9786 (uniprop_decode_value_run_length): New functions.
9787 (uniprop_decoder, uniprop_decoder_count): New variables.
9788 (uniprop_get_decoder, uniprop_encode_value_character)
9789 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9790 New functions.
9791 (uniprop_encoder, uniprop_encoder_count): New variables.
9792 (uniprop_get_encoder, uniprop_table)
9793 (Funicode_property_table_internal, Fget_unicode_property_internal)
9794 (Fput_unicode_property_internal): New functions.
9795 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9796 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9797 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9798 char-code-property-alist.
9799
640c8776 9800 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9801 Vunicode_category_table.
9802
640c8776 9803 * font.c (font_range): Adjust for the change of
c805dec0
KH
9804 Vunicode_category_table.
9805
76b397fb
DN
98062011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9807
9808 * m/iris4d.h: Remove file, move contents ...
9809 * s/irix6-5.h: ... here.
9810
22b4128e
PE
98112011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9812
9813 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9814 * alloc.c (mark_buffer):
9815 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9816 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9817 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9818 This isn't true in general, and it's particularly not true
9819 if Emacs is configured with --with-wide-int.
9820 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9821 New macros, used in the buffer.c change.
9822
869795d6
JD
98232011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9824
9825 * xsettings.c: Use both GConf and GSettings if both are available.
9826 (store_config_changed_event): Add comment.
9827 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9828 (store_tool_bar_style_changed): New functions.
5e617bc2 9829 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9830 (struct xsettings): Move font inside HAVE_XFT.
9831 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9832 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9833 Move inside HAVE_XFT.
640c8776 9834 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9835 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9836 also.
9837 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9838 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9839 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9840 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9841 (parse_settings): Move check for font inside HAVE_XFT.
9842 (read_settings, apply_xft_settings): Add comment.
9843 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9844 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9845 call store_font_name_changed.
9846 (xft_settings_event): Add comment.
9847 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9848 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9849 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9850 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9851 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9852 (xsettings_get_system_font, xsettings_get_system_normal_font):
9853 Add comment.
869795d6 9854
d8ed26bd
PE
98552011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9856
9857 Random fixes. E.g., (random) never returned negative values.
9858 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9859 subseconds part to the entropy, as that's a bit more random.
9860 Prefer signed to unsigned, since the signedness doesn't matter and
9861 in general we prefer signed. When given a limit, use a
9862 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9863 latter isn't right if USE_2_TAGS_FOR_INTS.
9864 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9865 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9866
cabf1cac
SM
98672011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9868
9869 * textprop.c (text_property_stickiness):
9870 Obey Vtext_property_default_nonsticky.
9871 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9872 * w32fns.c (syms_of_w32fns):
9873 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9874
6e9b2be9
PE
98752011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9876
9877 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9878 This is more efficient than Ffile_directory_p and avoids a minor race.
9879
90186c68
LMI
98802011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9881
7c301272
LMI
9882 * buffer.c (Foverlay_put): Say what the return value is
9883 (bug#7835).
9884
c4f2d8d4
LMI
9885 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9886 is a directory before asking whether to use the file name
9887 (bug#7564).
ad637907
LMI
9888 (barf_or_query_if_file_exists): Make the "File is a directory"
9889 error be more correct.
c4f2d8d4 9890
90186c68
LMI
9891 * fns.c (Frequire): Remove the mention of the .gz files, since
9892 that's installation-specific, but keep the mention of
9893 `get-load-suffixes'.
9894
da64016e
PE
98952011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9896
9897 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9898 Report string overflow if the output is too long.
9899
7d47b580
JB
99002011-07-04 Juanma Barranquero <lekktu@gmail.com>
9901
a555cb87
JB
9902 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9903 (syms_of_gnutls): Remove duplicate DEFSYM for
9904 Qgnutls_bootprop_verify_hostname_error, an error for
9905 Qgnutls_bootprop_verify_error (which is no longer used).
9906
7d47b580
JB
9907 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9908 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9909 Also (re)move comments that are misplaced or no longer relevant.
9910
1e49bfab
LMI
99112011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9912
9913 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9914
1485f4c0
CY
99152011-07-03 Chong Yidong <cyd@stupidchicken.com>
9916
9917 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9918 and background color parameters if they have been changed.
9919
a9ab721e
LMI
99202011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9921
9922 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9923
cf7cff57
PE
99242011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9925
2e13213d
PE
9926 * xsettings.c (SYSTEM_FONT): Define only when used.
9927 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9928
cf7cff57
PE
9929 * keymap.c (access_keymap_1): Now static.
9930
7a8e04f7
CY
99312011-07-02 Chong Yidong <cyd@stupidchicken.com>
9932
9933 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9934 leave any prefix arg for the up event (Bug#1586).
9935
61352f62
LMI
99362011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9937
69bb1ef7
LMI
9938 * lread.c (syms_of_lread): Mention single symbols defined by
9939 `defvar' or `defconst' (bug#7154).
9940
61352f62 9941 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9942 (Frequire): Mention get-load-suffixes.
61352f62 9943
28545e04
MR
99442011-07-02 Martin Rudalics <rudalics@gmx.at>
9945
9946 * window.h (window): Remove clone_number slot.
9947 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9948 Remove.
9949 (make_parent_window, make_window, saved_window)
9950 (Fset_window_configuration, save_window_save): Don't deal with
9951 clone numbers.
9952 * buffer.c (Qclone_number): Remove declaration.
9953 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9954
3349e122
SM
99552011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9956
9957 Add multiple inheritance to keymaps.
9958 * keymap.c (Fmake_composed_keymap): New function.
9959 (Fset_keymap_parent): Simplify.
9960 (fix_submap_inheritance): Remove.
9961 (access_keymap_1): New function extracted from access_keymap to handle
9962 embedded parents and handle lists of maps.
9963 (access_keymap): Use it.
9964 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9965 (Fcopy_keymap): Handle embedded parents.
9966 (Fcommand_remapping, define_as_prefix): Simplify.
9967 (Fkey_binding): Simplify.
9968 (syms_of_keymap): Move minibuffer-local-completion-map,
9969 minibuffer-local-filename-completion-map,
9970 minibuffer-local-must-match-map, and
9971 minibuffer-local-filename-must-match-map to Elisp.
9972 (syms_of_keymap): Defsubr make-composed-keymap.
9973 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9974 (parse_menu_item): Trivial simplification.
9975
3279eb87
GM
99762011-07-01 Glenn Morris <rgm@gnu.org>
9977
9978 * Makefile.in (SETTINGS_LIBS): Fix typo.
9979
4550efdf
KI
99802011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9981
9982 * coding.c (Fencode_coding_string): Record the last coding system
9983 used, as the function doc string says (bug#8738).
9984
0949d2b6
JD
99852011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9986
9987 * xsettings.c (store_monospaced_changed): Take new font as arg and
9988 check for change against current_mono_font.
9989 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9990 (emacs_settings_constructor, emacs_settings_get_property)
9991 (emacs_settings_set_property, emacs_settings_class_init)
9992 (emacs_settings_init, gsettings_obj): Remove.
9993 (something_changedCB): New function for HAVE_GSETTINGS.
9994 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9995 with value as argument.
9996 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9997 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9998 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9999 "changed".
10000
10001 * xgselect.c: Add defined (HAVE_GSETTINGS).
10002 (xgselect_initialize): Ditto.
10003
10004 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10005 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10006 xg_select.
10007
bbc6b304
PE
100082011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10009
10010 * eval.c (struct backtrace): Simplify and port the data structure.
10011 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10012 signed bit field, as this assumption is not portable and it makes
10013 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10014 "char debug_on_exit : 1" as this is not portable either; instead,
10015 use the portable "unsigned int debug_on_exit : 1". Remove unused
10016 member evalargs. Remove obsolete comments about cc bombing out.
10017
9851bfc5
JD
100182011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10019
51bb811f 10020 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10021 Let HAVE_GSETTINGS override HAVE_GCONF.
10022 (store_monospaced_changed): New function.
10023 (EMACS_SETTINGS): A new type derived from GObject to handle
10024 GSettings notifications.
10025 (emacs_settings_constructor, emacs_settings_get_property)
10026 (emacs_settings_set_property, emacs_settings_class_init):
10027 New functions.
10028 (gsettings_client, gsettings_obj): New variables.
10029 (GSETTINGS_SCHEMA): New define.
10030 (something_changedCB): Call store_monospaced_changed.
10031 (init_gsettings): New function.
10032 (xsettings_initialize): Call init_gsettings.
10033 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10034 to NULL.
10035
640c8776 10036 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10037 GCONF_CFLAGS/LIBS.
10038
5386012d
MR
100392011-06-29 Martin Rudalics <rudalics@gmx.at>
10040
10041 * window.c (resize_root_window, grow_mini_window)
10042 (shrink_mini_window): Rename Qresize_root_window to
10043 Qwindow_resize_root_window and Qresize_root_window_vertically to
10044 Qwindow_resize_root_window_vertically.
10045
f13e0b08
PE
100462011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10047
10048 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10049
94515237
JB
100502011-06-27 Juanma Barranquero <lekktu@gmail.com>
10051
10052 * makefile.w32-in: Redesign dependencies so they reflect more
10053 clearly which files are directly included by each source file,
10054 and not through other includes.
10055
e43b6e43
MR
100562011-06-27 Martin Rudalics <rudalics@gmx.at>
10057
10058 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10059 (sort_overlays, overlay_strings): When an overlay's clone number
10060 matches the window's clone number process the overlay even if
10061 the overlay's window property doesn't match the current window.
10062
d68443dc
MR
10063 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10064 (Fwindow_hchild): Rename to Fwindow_left_child.
10065 (Fwindow_next): Rename to Fwindow_next_sibling.
10066 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10067 (resize_window_check): Rename to window_resize_check.
10068 (resize_window_apply): Rename to window_resize_apply.
10069 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10070 (Fdelete_other_windows_internal, resize_frame_windows)
10071 (Fsplit_window_internal, Fdelete_window_internal)
10072 (grow_mini_window, shrink_mini_window)
10073 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10074
c7e73be5
JD
100752011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10076
10077 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10078 (emacs_fixed_set_min_size): Remove.
10079 (emacs_fixed_new): Take frame as argument.
10080
10081 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10082 (_EmacsFixedPrivate): Remove minwidth/height.
10083 Add struct frame *f.
10084 (emacs_fixed_init): Initialize priv->f.
10085 (get_parent_class, emacs_fixed_set_min_size): Remove.
10086 (emacs_fixed_new): Set priv->f to argument.
10087 (emacs_fixed_get_preferred_width)
10088 (emacs_fixed_get_preferred_height): Use min_width/height from
10089 frames size_hint to set minimum and natural (Bug#8919).
10090 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10091 and use min_width/height from frames size_hint to set
10092 min_width/height (Bug#8919).
10093
10094 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10095 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10096 Fix indentation.
c7e73be5 10097
cf99dcf8
EZ
100982011-06-26 Eli Zaretskii <eliz@gnu.org>
10099
10100 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10101 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10102 called at ZV.
10103
029529ac
CY
101042011-06-26 Chong Yidong <cyd@stupidchicken.com>
10105
10106 * process.c (wait_reading_process_output): Bypass select if
10107 waiting for a cell while ignoring keyboard input, and input is
10108 pending. Suggested by Jan Djärv (Bug#8869).
10109
7a7ef429
PE
101102011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10111
10112 Use gnulib's dup2 module instead of rolling our own.
10113 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10114
11fdef7d 101152011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10116
10117 * dispnew.c (scrolling_window): Before scrolling, turn off a
10118 mouse-highlight in the window being scrolled.
10119
cd3520a4
JB
101202011-06-24 Juanma Barranquero <lekktu@gmail.com>
10121
10122 Move DEFSYM to lisp.h and use everywhere.
10123
10124 * character.h (DEFSYM): Move declaration...
10125 * lisp.h (DEFSYM): ...here.
10126
10127 * gnutls.c:
10128 * minibuf.c:
10129 * w32menu.c:
10130 * w32proc.c:
10131 * w32select.c: Don't include character.h.
10132
10133 * alloc.c (syms_of_alloc):
10134 * buffer.c (syms_of_buffer):
10135 * bytecode.c (syms_of_bytecode):
10136 * callint.c (syms_of_callint):
10137 * casefiddle.c (syms_of_casefiddle):
10138 * casetab.c (init_casetab_once):
10139 * category.c (init_category_once, syms_of_category):
10140 * ccl.c (syms_of_ccl):
10141 * cmds.c (syms_of_cmds):
10142 * composite.c (syms_of_composite):
10143 * dbusbind.c (syms_of_dbusbind):
10144 * dired.c (syms_of_dired):
10145 * dispnew.c (syms_of_display):
10146 * doc.c (syms_of_doc):
10147 * editfns.c (syms_of_editfns):
10148 * emacs.c (syms_of_emacs):
10149 * eval.c (syms_of_eval):
10150 * fileio.c (syms_of_fileio):
10151 * fns.c (syms_of_fns):
10152 * frame.c (syms_of_frame):
10153 * fringe.c (syms_of_fringe):
10154 * insdel.c (syms_of_insdel):
10155 * keymap.c (syms_of_keymap):
10156 * lread.c (init_obarray, syms_of_lread):
10157 * macros.c (syms_of_macros):
10158 * msdos.c (syms_of_msdos):
10159 * print.c (syms_of_print):
10160 * process.c (syms_of_process):
10161 * search.c (syms_of_search):
10162 * sound.c (syms_of_sound):
10163 * syntax.c (init_syntax_once, syms_of_syntax):
10164 * terminal.c (syms_of_terminal):
10165 * textprop.c (syms_of_textprop):
10166 * undo.c (syms_of_undo):
10167 * w32.c (globals_of_w32):
10168 * window.c (syms_of_window):
10169 * xdisp.c (syms_of_xdisp):
10170 * xfaces.c (syms_of_xfaces):
10171 * xfns.c (syms_of_xfns):
10172 * xmenu.c (syms_of_xmenu):
10173 * xsettings.c (syms_of_xsettings):
10174 * xterm.c (syms_of_xterm): Use DEFSYM.
10175
4228cf16
TZ
101762011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10177
cd3520a4 10178 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10179
7fcccf1e
PE
101802011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10181
7efb4e0e
PE
10182 Integer and buffer overflow fixes (Bug#8873).
10183
ff5844ad
PE
10184 * print.c (printchar, strout): Check for string overflow.
10185 (PRINTPREPARE, printchar, strout):
10186 Don't set size unless allocation succeeds.
10187
90532f02
PE
10188 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10189 for sizes. Check for string overflow more accurately.
10190 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10191
6d84508d
PE
10192 * macros.c: Integer and buffer overflow fixes.
10193 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10194 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10195 Use ptrdiff_t, not int, for sizes.
10196 Don't increment bufsize until after realloc succeeds.
10197 Check for size-calculation overflow.
10198 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10199
437b2cb4
PE
10200 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10201
8b9ac8b4
PE
10202 * lread.c: Integer overflow fixes.
10203 (read_integer): Radix is now EMACS_INT, not int,
10204 to improve quality of diagnostics for out-of-range radices.
10205 Calculate buffer size correctly for out-of-range radices.
10206 (read1): Check for integer overflow in radices, and in
10207 read-circle numbers.
82cb60d3
PE
10208 (read_escape): Avoid int overflow.
10209 (Fload, openp, read_buffer_size, read1)
10210 (substitute_object_recurse, read_vector, read_list, map_obarray):
10211 Use ptrdiff_t, not int, for sizes.
10212 (read1): Use EMACS_INT, not int, for sizes.
20270765 10213 Check for size overflow.
8b9ac8b4 10214
7fcccf1e
PE
10215 * image.c (cache_image): Check for size arithmetic overflow.
10216
bfbbd7e7
PE
10217 * lread.c: Integer overflow issues.
10218 (saved_doc_string_size, saved_doc_string_length)
10219 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10220 Now ptrdiff_t, not int.
10221 (read1): Don't assume doc string length fits in int. Check for
10222 out-of-range doc string lengths.
10223 (read_list): Don't assume file position fits in int.
39019e54 10224 (read_escape): Check for hex character overflow.
bfbbd7e7 10225
4e323265
LL
102262011-06-22 Leo Liu <sdl.web@gmail.com>
10227
10228 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10229 Move to minibuffer.el.
10230
85fece3e
PE
102312011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10232
20b84ce9 10233 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10234 The following patches are for when GLYPH_DEBUG && !XASSERT.
10235 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10236 * dispnew.c (flush_stdout):
10237 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10238 Mark as externally visible.
10239 * dispnew.c (check_window_matrix_pointers): Now static.
10240 * dispnew.c (window_to_frame_vpos):
10241 * xfns.c (unwind_create_frame):
10242 * xterm.c (x_check_font): Remove unused local.
10243 * scroll.c (CHECK_BOUNDS):
10244 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10245 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10246 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10247 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10248 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10249 Now static.
10250 (debug_method_add): Use va_list and vsprintf rather than relying
10251 on undefined behavior with wrong number of arguments.
10252 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10253 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10254 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10255 since we're not interested in debugging glyphs with old libraries.
10256 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10257 GCC 4.6.0's static checking.
10258
0766b489
PE
102592011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10260
31fd4b32
PE
10261 Integer overflow and signedness fixes (Bug#8873).
10262 A few related buffer overrun fixes, too.
10263
b79e8648
PE
10264 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10265
0766b489
PE
10266 * dispextern.h (struct face.stipple):
10267 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10268 (x_bitmap_mask, x_allocate_bitmap_record)
10269 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10270 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10271 (x_create_bitmap_from_xpm_data):
10272 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10273 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10274 (.bitmaps_last):
10275 * xfaces.c (load_pixmap):
10276 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10277 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10278 (.bitmaps_last, struct x_output.icon_bitmap):
10279 Use ptrdiff_t, not int, for bitmap indexes.
10280 (x_allocate_bitmap_record): Check for size overflow.
10281 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10282
b081724f
PE
10283 Use ptrdiff_t, not int, for overlay counts.
10284 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10285 * editfns.c (overlays_around, get_pos_property):
10286 * textprop.c (get_char_property_and_overlay):
10287 * xdisp.c (next_overlay_change, note_mouse_highlight):
10288 * xfaces.c (face_at_buffer_position):
21514da7
PE
10289 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10290 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10291 (Fnext_overlay_change, Fprevious_overlay_change)
10292 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10293 Use ptrdiff_t, not int, for sizes.
21514da7 10294 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10295
3de73e5e
PE
10296 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10297
2606c57b
PE
10298 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10299 (x_session_initialize): Do not assume string length fits in int.
10300
aaafe47a
PE
10301 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10302 This is unlikely, but can occur if DPI is outlandish.
10303
2674ddc8 10304 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10305 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10306
28154962
PE
10307 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10308 * xrdb.c (magic_file_p, search_magic_path):
10309 Omit last arg SUFFIX; it was always 0. All callers changed.
10310 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10311
7de51af5
PE
10312 * xfont.c (xfont_match): Avoid need for strlen.
10313
25ed6cc3
PE
10314 * xfns.c: Don't assume strlen fits in int.
10315 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10316
4eab31dd
PE
10317 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10318 not unsigned long, as we prefer signed integers. All callers changed.
10319 Detect integer overflow in repeat count.
10320 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10321 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10322
171e2a58
PE
10323 * termcap.c: Don't assume sizes fit in int and never overflow.
10324 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10325 (gobble_line): Check for size-calculation overflow.
10326
ad39faca 10327 * minibuf.c (Fread_buffer):
6e5bb2dc 10328 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10329 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10330 Don't assume string length fits in int.
10331
52c61c22 10332 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10333 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10334
b5b8c9e5
PE
10335 * font.c: Don't assume string length fits in int.
10336 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10337 Use ptrdiff_t, not int.
ccd6111c
PE
10338 (font_intern_prop): Don't assume string length fits in int.
10339 Don't assume integer property fits in fixnum.
10340 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10341
882f0d81 10342 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10343 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10344 Reformulate so as not to need the command string.
10345 Invoke gzip -cd rather than gunzip, as it's more portable.
10346 (lock_info_type, lock_file_1, lock_file):
10347 Don't assume pid_t and time_t fit in unsigned long.
10348 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10349 (current_lock_owner): Prefer signed type for sizes.
10350 Use memcpy, not strncpy, where memcpy is what is really wanted.
10351 Don't assume (via atoi) that time_t and pid_t fit in int.
10352 Check for time_t and/or pid_t out of range, e.g., via a network share.
10353 Don't alloca where an auto var works fine.
10354
93f4cf88
PE
10355 * fileio.c: Fix some integer overflow issues.
10356 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10357 Don't assume string length fits in int.
10358 (directory_file_name): Don't assume string length fits in long.
10359 (make_temp_name): Don't assume pid fits in int, or that its print
10360 length is less than 20.
10361
f3e92b69
PE
10362 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10363
1bfdaf10
PE
10364 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10365
35016e9a
PE
10366 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10367
3d1e65a1
PE
10368 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10369 We prefer signed integers, even for size calculations.
10370
0b963a93
PE
10371 * emacs.c: Don't assume string length fits in 'int'.
10372 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10373 (main): Don't invoke strlen when not needed.
10374
573f4b54
PE
10375 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10376 (XD_DEBUG_MESSAGE): Don't waste a byte.
10377
989f33ba
PE
10378 * callproc.c (getenv_internal_1, getenv_internal)
10379 (Fgetenv_internal):
965d34eb
PE
10380 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10381
e4d29b33
PE
10382 * lread.c (invalid_syntax): Omit length argument.
10383 All uses changed. This doesn't fix a bug, but it simplifies the
10384 code away from its former Hollerith-constant appearance, and it's
10385 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10386 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10387
eb49b136
PE
10388 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10389 This didn't break anything, but it didn't help either.
10390 It's confusing to put a bogus integer in a place where the actual
10391 value does not matter.
9f62aeb1 10392 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10393 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10394
15375a22
PE
10395 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10396 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10397 implementation.
b61cc01c
PE
10398 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10399 We prefer signed types, and the value cannot exceed the EMACS_INT
10400 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10401 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10402 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10403 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10404
53b2623d
PE
10405 * indent.c (sane_tab_width): New function.
10406 (current_column, scan_for_column, Findent_to, position_indentation)
10407 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10408 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10409
51cab52b 10410 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10411
f2ed8a70
PE
10412 * lisp.h (lint_assume): New macro.
10413 * composite.c (composition_gstring_put_cache):
10414 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10415
abe80cc6
PE
10416 * editfns.c, insdel.c:
10417 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10418
b02c740e
PE
10419 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10420
ebc96716
PE
10421 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10422
b4e50fa0 10423 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10424 Use much-faster test for byte-length change.
311d5d7c 10425 Don't assume string byte-length fits in 'int'.
a4cf38e4 10426 Check that character arg fits in 'int'.
85461888 10427 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10428
c0c1ee9f
PE
10429 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10430
a498d7f4
PE
10431 * fns.c (concat): Catch string overflow earlier.
10432 Do not rely on integer wraparound.
10433
51cab52b
PE
10434 * dispextern.h (struct it.overlay_strings_charpos)
10435 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10436 * xdisp.c (forward_to_next_line_start)
10437 (back_to_previous_visible_line_start)
10438 (reseat_at_next_visible_line_start, next_element_from_buffer):
10439 Don't arbitrarily truncate the value of 'selective' to int.
10440
76031fad
PE
10441 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10442
5eb55db9
PE
10443 * composite.c: Don't truncate sizes to 'int'.
10444 (composition_gstring_p, composition_reseat_it)
10445 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10446 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10447 not EMACS_UINT, for indexes.
5eb55db9 10448
0703a717
PE
10449 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10450
d6202519
PE
10451 * buffer.c: Include <verify.h>.
10452 (struct sortvec.priority, struct sortstr.priority):
8961a454 10453 Now EMACS_INT, not int.
c20998a7 10454 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10455 (struct sortstr.size, record_overlay_string)
10456 (struct sortstrlist.size, struct sortlist.used):
10457 Don't truncate size to int.
10458 (record_overlay_string): Check for size-calculation overflow.
d6202519 10459 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10460
d5a19415
JM
104612011-06-22 Jim Meyering <meyering@redhat.com>
10462
029529ac 10463 Don't leak an XBM-image-sized buffer
d5a19415
JM
10464 * image.c (xbm_load): Free the image buffer after using it.
10465
a9041e6c
PE
104662011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10467
10468 Port to Sun C.
10469 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10470 that Sun C diagnosed.
10471 * fns.c (secure_hash): Fix pointer signedness issue.
10472 * intervals.c (static_offset_intervals): New function.
10473 (offset_intervals): Use it.
10474
7f3f739f
LL
104752011-06-21 Leo Liu <sdl.web@gmail.com>
10476
10477 * deps.mk (fns.o):
10478 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10479 sha512.h.
10480
10481 * fns.c (secure_hash): Rename from crypto_hash_function and change
10482 the first arg to accept symbols.
5b66d427 10483 (Fsecure_hash): New primitive.
7f3f739f
LL
10484 (syms_of_fns): New symbols.
10485
76147d94
DD
104862011-06-20 Deniz Dogan <deniz@dogan.se>
10487
10488 * process.c (Fset_process_buffer): Clarify return value in
10489 docstring.
10490
7d7d0045
CY
104912011-06-18 Chong Yidong <cyd@stupidchicken.com>
10492
10493 * dispnew.c (add_window_display_history): Use BVAR.
10494
10495 * xdisp.c (debug_method_add): Use BVAR.
10496 (check_window_end, dump_glyph_matrix, dump_glyph)
10497 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10498
10499 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10500 Likewise.
10501
10502 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10503 check till after the cache is created in init_frame_faces.
10504
ff2bc410
SM
105052011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10506
10507 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10508
28177add
PE
105092011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10510
dd3482fe
PE
10511 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10512 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10513 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10514
393d71f3 10515 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10516 * fileio.c (Finsert_file_contents):
10517 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10518 Remove the old (too-loose) buffer overflow checks.
10519 They weren't needed, since make_gap checks for buffer overflow.
10520 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10521 The old code merely checked for Emacs fixnum overflow, and relied
10522 on undefined (wraparound) behavior. The new code avoids undefined
10523 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10524
2e6813b0 10525 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10526 Tune. Don't use wider integers than needed. Don't use alloca.
10527 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10528
599a9e4f
PE
10529 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10530
99561444
PE
10531 * insdel.c, lisp.h (buffer_overflow): New function.
10532 (insert_from_buffer_1, replace_range, replace_range_2):
10533 * insdel.c (make_gap_larger):
10534 * editfns.c (Finsert_char):
10535 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10536
28177add
PE
10537 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10538
e69dafad
PE
105392011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10540
4baa020d 10541 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10542
b1c46f02
PE
10543 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10544 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10545
e69dafad
PE
10546 * fileio.c: Don't assume EMACS_INT fits in off_t.
10547 (emacs_lseek): New static function.
10548 (Finsert_file_contents, Fwrite_region): Use it.
10549 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10550
566684ea
PE
10551 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10552
e6966cd6
PE
10553 * fns.c: Don't overflow int when computing a list length.
10554 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10555 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10556 truncation on 64-bit hosts. Check for QUIT every
10557 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10558 faster and is responsive enough.
10559 (Flength): Report an error instead of overflowing an integer.
10560 (Fsafe_length): Return a float if the value is not representable
10561 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10562 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10563 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10564
dd0b0efb
PE
10565 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10566 (header_size, word_size): New constants.
10567 (allocate_vectorlike): Don't check size overflow here.
10568 (allocate_vector): Check it here instead, since this is the only
10569 caller of allocate_vectorlike that could cause overflow.
10570 Check that the new vector's length is representable as a fixnum.
10571
86fe5cfe
PE
10572 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10573 The previous code was bogus. For example, next_almost_prime (32)
10574 returned 39, which is undesirable as it is a multiple of 3; and
10575 next_almost_prime (24) returned 25, which is a multiple of 5 so
10576 why was the code bothering to check for multiples of 7?
10577
80e88859
PE
10578 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10579
4a2f0ad6
PE
10580 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10581
f66c7cf8
PE
10582 Variadic C functions now count arguments with ptrdiff_t.
10583 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10584 Back then I didn't know that the Emacs coding style prefers signed int.
10585 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10586 were being counted with int, which may truncate counts on 64-bit
10587 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10588 * lisp.h (struct Lisp_Subr.function.aMANY)
10589 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10590 Arg counts are now ptrdiff_t, not size_t.
10591 All variadic functions and their callers changed accordingly.
10592 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10593 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10594 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10595 * callint.c (Fcall_interactively): Check arg count for overflow,
10596 to avoid potential buffer overrun. Use signed char, not 'int',
10597 for 'varies' array, so that we needn't bother to check its size
10598 calculation for overflow.
10599 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10600 * eval.c (apply_lambda):
10601 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10602 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10603 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10604
a1759b76
PE
10605 * callint.c (Fcall_interactively): Don't use index var as event count.
10606
d96be9fc
PE
10607 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10608 * mem-limits.h (SIZE): Remove; no longer used.
10609
a690a978 10610 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10611
578c21e6
PE
10612 Remove unnecessary casts.
10613 * xterm.c (x_term_init):
10614 * xfns.c (x_set_border_pixel):
10615 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10616 These aren't needed now that we assume ANSI C.
10617
96f53c6c
PE
10618 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10619 It's more likely to cause problems (due to unsigned overflow)
10620 than to cure them.
10621
83c77d31
PE
10622 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10623
ee2079f1
PE
10624 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10625
6da65536
PE
10626 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10627
7147c4a4
PE
10628 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10629
193e32d9
PE
10630 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10631
e5533da6
PE
10632 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10633
9910e595
PE
10634 GLYPH_CODE_FACE returns EMACS_INT, not int.
10635 * dispextern.h (merge_faces):
10636 * xfaces.c (merge_faces):
01103c44
PE
10637 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10638 Don't assume EMACS_INT fits in int.
9910e595 10639
2638320e
PE
10640 * character.h (CHAR_VALID_P): Remove unused parameter.
10641 * fontset.c, lisp.h, xdisp.c: All uses changed.
10642
045eb8d9
PE
10643 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10644
c1f134b5
PE
10645 * fns.c (concat): Minor tuning based on overflow analysis.
10646 This doesn't fix any bugs. Use int to hold character, instead
10647 of constantly refetching from Emacs object. Use XFASTINT, not
10648 XINT, for value known to be a character. Don't bother comparing
10649 a single byte to 0400, as it's always less.
10650
395fcb93 10651 * floatfns.c (Fexpt):
327eeec8
PE
10652 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10653
abbd3d23
PE
10654 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10655 for characters.
10656
684a03ef
PE
10657 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10658
0fed43f3
PE
10659 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10660 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10661 incorrectly succeed when S was a string, because 4294967386 was
10662 truncated before it was used.
10663
8fd02eb7
PE
10664 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10665 Otherwise, an out-of-range integer could cause undefined behavior
10666 on a 64-bit host.
10667
f8c86b69
PE
10668 * composite.c: Use int, not EMACS_INT, for characters.
10669 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10670 EMACS_INT, for values that are known to be in character range.
10671 This doesn't fix any bugs but is the usual style inside Emacs and
10672 may generate better code on 32-bit machines.
10673
34206dd2
PE
10674 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10675 This is for reasons similar to the recent CHAR_STRING fix.
10676 * charset.c (Fencode_char): Check that character arg is actually
10677 a character. Pass an int to ENCODE_CHAR.
10678 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10679 wider than 'int', as a compile-time check to prevent future regressions
10680 in this area.
10681
c5958d4c 10682 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10683
10684 Make sure a 64-bit char is never passed to CHAR_STRING.
10685 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10686 by silently ignoring the top 32 bits, allowing some values
10687 that were far too large to be valid characters.
10688 * character.h: Include <verify.h>.
10689 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10690 arguments are no wider than unsigned, as a compile-time check
10691 to prevent future regressions in this area.
10692 * data.c (Faset):
01103c44 10693 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10694 (Fsubst_char_in_region):
10695 * fns.c (concat):
10696 * xdisp.c (decode_mode_spec_coding):
10697 Adjust to CHAR_STRING's new requirement.
10698 * editfns.c (Finsert_char, Fsubst_char_in_region):
10699 * fns.c (concat): Check that character args are actually
10700 characters. Without this test, these functions did the wrong
10701 thing with wildly out-of-range values on 64-bit hosts.
10702
d37ca623
PE
10703 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10704 These casts should not be needed on 32-bit hosts, either.
10705 * keyboard.c (read_char):
10706 * lread.c (Fload): Remove casts to unsigned.
10707
ea204efb
PE
10708 * lisp.h (UNSIGNED_CMP): New macro.
10709 This fixes comparison bugs on 64-bit hosts.
10710 (ASCII_CHAR_P): Use it.
10711 * casefiddle.c (casify_object):
01103c44 10712 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10713 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10714 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10715 * dispextern.h (FACE_FROM_ID):
10716 * keyboard.c (read_char): Use UNSIGNED_CMP.
10717
41cb286c
PE
10718 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10719 not to EMACS_INT, to avoid GCC warning.
10720
4a1b9832
PE
10721 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10722
55daad71
PE
10723 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10724 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10725 isn't needed on 32-bit machines.
8f95c75c 10726
01103c44
PE
10727 * buffer.c (Fgenerate_new_buffer_name):
10728 Use EMACS_INT for count, not int.
0ceccced 10729 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10730
10731 * data.c (Qcompiled_function): Now static.
10732
c6f072e7
PE
10733 * window.c (window_body_lines): Now static.
10734
20ce5912
PE
10735 * image.c (gif_load): Rename local to avoid shadowing.
10736
9c4c5f81
PE
10737 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10738 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10739 * alloc.c (make_save_value): Integer argument is now of type
10740 ptrdiff_t, not int.
10741 (mark_object): Use ptrdiff_t, not int.
10742 * lisp.h (pD): New macro.
10743 * print.c (print_object): Use it.
10744
c0c5c8ae
PE
10745 * alloc.c: Use EMACS_INT, not int, to count objects.
10746 (total_conses, total_markers, total_symbols, total_vector_size)
10747 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10748 (total_free_floats, total_floats, total_free_intervals)
10749 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10750 Now EMACS_INT, not int. All uses changed.
10751 (Fgarbage_collect): Compute overall total using a double, so that
10752 integer overflow is less likely to be a problem. Check for overflow
10753 when converting back to an integer.
5a25e253
PE
10754 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10755 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10756 These were 'int' variables that could overflow on 64-bit hosts;
10757 they were never used, so remove them instead of repairing them.
211a0b2a 10758 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10759 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10760 Previously, this ceilinged at INT_MAX, but that doesn't work on
10761 64-bit machines.
e46bb31a 10762 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10763
c78baabf 10764 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10765 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10766 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10767 when a (possibly-narrower) signed value would do just as well.
10768 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10769
c9d624c6
PE
10770 * alloc.c: Catch some string size overflows that we were missing.
10771 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10772 for convenience in STRING_BYTES_MAX.
10773 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10774 The definition here is exact; the one in lisp.h was approximate.
10775 (allocate_string_data): Check for string overflow. This catches
10776 some instances we weren't catching before. Also, it catches
10777 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10778 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10779 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10780
c9d624c6
PE
10781 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10782 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10783 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10784
353032ce
PE
10785 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10786
2bccce07
PE
10787 * alloc.c (Fmake_string): Check for out-of-range init.
10788
0ac30604
SM
107892011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10790
10791 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10792
c195f2de
JD
107932011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10794
10795 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10796 xg_get_default_scrollbar_width.
10797
10798 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10799 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10800 (style_changed_cb): Call update_theme_scrollbar_width and call
10801 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10802 all frames (Bug#8505).
10803 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10804 Call gtk_window_set_resizable if HAVE_GTK3.
10805 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10806 and height if HAVE_GTK3 (Bug#8505).
10807 (scroll_bar_width_for_theme): New variable.
10808 (update_theme_scrollbar_width): New function.
10809 (xg_get_default_scrollbar_width): Move code to
10810 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10811 (xg_initialize): Call update_theme_scrollbar_width.
10812
10813 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10814
10815 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10816
e10ac9f1
MR
108172011-06-12 Martin Rudalics <rudalics@gmx.at>
10818
10819 * frame.c (make_frame): Call other_buffer_safely instead of
10820 other_buffer.
10821
10822 * window.c (temp_output_buffer_show): Call display_buffer with
10823 second argument Vtemp_buffer_show_specifiers and reset latter
10824 immediately after the call.
10825 (Vtemp_buffer_show_specifiers): New variable.
10826 (auto_window_vscroll_p, next_screen_context_lines)
10827 (Vscroll_preserve_screen_position): Remove leading asterisks from
10828 doc-strings.
10829
2d3c217e 108302011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10831
7b7f97e8 10832 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10833 * buffer.c (Qclone_number): Remove for now, as it's unused.
10834 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10835 (record_buffer): Remove unused local.
10836 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10837 (set_frame_buffer_list): Remove; unused.
10838 * frame.h (other_visible_frames): Remove decl.
10839 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10840 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10841 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10842 if HAVE_GPM.
10843 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10844 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10845 Define only if HAVE_GPM.
10846 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10847 (update_hints_inhibit): Remove; never set. All uses removed.
10848 * widgetprv.h (emacsFrameClassRec): Remove decl.
10849 * window.c (delete_deletable_window): Now returns void, since it
10850 wasn't returning anything.
10851 (compare_window_configurations): Remove unused locals.
10852 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10853 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10854 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10855 the same widths as pointers. This follows up on the 2011-05-06 patch.
10856 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10857 * xterm.h: Likewise.
10858 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10859
1384b89e
JB
108602011-06-12 Juanma Barranquero <lekktu@gmail.com>
10861
10862 * makefile.w32-in: Update dependencies.
10863 (LISP_H): Add lib/intprops.h.
10864
1100a63c
CY
108652011-06-11 Chong Yidong <cyd@stupidchicken.com>
10866
10867 * image.c (gif_load): Add animation frame delay to the metadata.
10868 (syms_of_image): Use DEFSYM. New symbol `delay'.
10869
6198ccd0
MR
108702011-06-11 Martin Rudalics <rudalics@gmx.at>
10871
10872 * window.c (delete_deletable_window): Re-add.
10873 (Fset_window_configuration): Rewrite to handle dead buffers and
10874 consequently deletable windows.
10875 (window_tree, Fwindow_tree): Remove. Supply functionality in
10876 window.el.
10877 (compare_window_configurations): Simplify code.
10878
b6e3633c
AS
108792011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10880
1ab0dee5
AS
10881 * image.c (imagemagick_load_image): Fix type mismatch.
10882 (Fimagemagick_types): Likewise.
10883
b6e3633c
AS
10884 * window.h (replace_buffer_in_windows): Declare.
10885
9397e56f
MR
108862011-06-11 Martin Rudalics <rudalics@gmx.at>
10887
10888 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10889 Qclone_number. Remove external declaration of Qdelete_window.
10890 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10891 code.
640c8776
SM
10892 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10893 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10894 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10895 buffer list implementation.
10896 (other_buffer_safely): New function.
10897 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10898 calls to replace_buffer_in_windows and
10899 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10900 if allowed.
10901 (record_buffer): Inhibit quitting and rewrite using quittable
10902 functions. Run Qbuffer_list_update_hook if allowed.
10903 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10904 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10905 Move switch-to-buffer to window.el.
9397e56f
MR
10906 (bury-buffer): Move to window.el.
10907 (Vbuffer_list_update_hook): New variable.
10908
10909 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10910 section.
10911
10912 * window.h (resize_frame_windows): Move up in code.
10913 (Fwindow_frame): Remove EXFUN.
10914 (replace_buffer_in_all_windows): Remove prototype.
10915 (replace_buffer_in_windows_safely): Add prototype.
10916
10917 * window.c: Declare Qdelete_window static again. Move down
10918 declaration of select_count.
10919 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10920 (Fother_window): Move to window.el.
10921 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10922 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10923 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10924 window.el.
10925 (replace_buffer_in_windows): Implement by calling
10926 Qreplace_buffer_in_windows.
10927 (replace_buffer_in_all_windows): Remove with some functionality
10928 moved into replace_buffer_in_windows_safely.
10929 (replace_buffer_in_windows_safely): New function.
10930 (select_window_norecord, select_frame_norecord): Move in front
10931 of run_window_configuration_change_hook. Remove now obsolete
10932 declarations.
640c8776
SM
10933 (Fset_window_buffer): Rewrite doc-string.
10934 Call Qrecord_window_buffer.
9397e56f
MR
10935 (keys_of_window): Move binding for other-window to window.el.
10936
b50691aa
CY
109372011-06-11 Chong Yidong <cyd@stupidchicken.com>
10938
10939 * dispextern.h (struct image): Replace data member, whose int_val
10940 and ptr_val fields were not used by anything, with a single
10941 lisp_val object.
10942
10943 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10944 (gif_clear_image, gif_load, imagemagick_load_image)
10945 (gs_clear_image, gs_load): Callers changed.
10946
3f754b86
PE
109472011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10948
cca69397
PE
10949 * buffer.h: Include <time.h>, for time_t.
10950 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10951
109e28d0
PE
10952 Fix minor problems found by static checking.
10953
60737f02
PE
10954 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10955
4b66faf3
PE
10956 Make identifiers static if they are not used in other modules.
10957 * data.c (Qcompiled_function, Qframe, Qvector):
10958 * image.c (QimageMagick, Qsvg):
10959 * minibuf.c (Qmetadata):
10960 * window.c (resize_window_check, resize_root_window): Now static.
10961 * window.h (resize_window_check, resize_root_window): Remove decls.
10962
109e28d0
PE
10963 * window.c (window_deletion_count, delete_deletable_window):
10964 Remove; unused.
46a4ce9e
PE
10965 (window_body_lines): Now static.
10966 (Fdelete_other_windows_internal): Mark vars as initialized.
10967 Make sure 'resize_failed' is initialized.
10968 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10969 (resize_window_apply): Remove unused local.
10970 * window.h (delete_deletable_window): Remove decl.
10971
109e28d0 10972 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10973 (imagemagick_load_image): Fix pointer signedness problem by changing
10974 last arg from unsigned char * to char *. All uses changed.
10975 Also, fix a local for similar reasons.
10976 Remove unused locals. Remove locals to avoid shadowing.
10977 (fn_rsvg_handle_free): Remove; unused.
10978 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10979 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10980
3f754b86
PE
10981 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10982
2547adb1
CY
109832011-06-10 Chong Yidong <cyd@stupidchicken.com>
10984
10985 * image.c (gif_load): Fix omitted cast error introduced by
10986 2011-06-06 change.
10987
2c8e37d4
MR
109882011-06-10 Martin Rudalics <rudalics@gmx.at>
10989
10990 * window.h (resize_proportionally, orig_total_lines)
10991 (orig_top_line): Remove from window structure.
10992 (set_window_height, set_window_width, change_window_heights)
10993 (Fdelete_window): Remove prototypes.
10994 (resize_frame_windows): Remove duplicate declaration.
10995
440a42e3
EZ
109962011-06-10 Eli Zaretskii <eliz@gnu.org>
10997
10998 * window.h (resize_frame_windows, resize_window_check)
10999 (delete_deletable_window, resize_root_window)
11000 (resize_frame_windows): Declare prototypes.
11001
11002 * window.c (resize_window_apply): Make definition be "static" to
11003 match the prototype.
11004
562dd5e9
MR
110052011-06-10 Martin Rudalics <rudalics@gmx.at>
11006
11007 * window.c: Remove declarations of Qwindow_size_fixed,
11008 window_min_size_1, window_min_size_2, window_min_size,
11009 size_window, window_fixed_size_p, enlarge_window, delete_window.
11010 Remove static from declaration of Qdelete_window, it's
11011 temporarily needed by Fbury_buffer.
11012 (replace_window): Don't assign orig_top_line and
11013 orig_total_lines.
11014 (Fdelete_window, delete_window): Remove. Window deletion is
11015 handled by window.el.
640c8776
SM
11016 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11017 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11018 (Fdelete_other_windows): Remove. Deleting other windows is
11019 handled by window.el.
11020 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11021 handled in window.el.
11022 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11023 Window minimum sizes are handled in window.el.
11024 (shrink_windows, size_window, set_window_height)
11025 (set_window_width, change_window_heights, window_height)
11026 (window_width, CURBEG, CURSIZE, enlarge_window)
11027 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11028 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11029 handled in window.el.
11030 (make_dummy_parent): Rename to make_parent_window and give it a
11031 second argument horflag.
11032 (make_window): Don't set resize_proportionally any more.
11033 (Fsplit_window): Remove. Windows are split in window.el.
11034 (save_restore_action, save_restore_orig_size)
11035 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11036 Resize mini windows in window.el.
11037 (grow_mini_window, shrink_mini_window): Implement by calling
11038 Qresize_root_window_vertically, resize_window_check and
11039 resize_window_apply.
640c8776
SM
11040 (saved_window, Fset_window_configuration, save_window_save):
11041 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11042 resize_proportionally.
11043 (window_min_height, window_min_width): Move to window.el.
11044 (keys_of_window): Move bindings for delete-other-windows,
11045 split-window, delete-window and enlarge-window to window.el.
11046
11047 * buffer.c: Temporarily extern Qdelete_window.
11048 (Fbury_buffer): Temporarily call Qdelete_window instead of
11049 Fdelete_window (Fbury_buffer will move to window.el soon).
11050
11051 * frame.c (set_menu_bar_lines_1): Remove code handling
11052 orig_top_line and orig_total_lines.
11053
11054 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11055 set_window_height but set heights directly.
11056 (change_frame_size_1): Use resize_frame_windows.
11057
11058 * xdisp.c (init_xdisp): Don't use set_window_height but set
11059 heights directly.
11060
640c8776
SM
11061 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11062 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11063 run_window_configuration_change_hook.
11064
11065 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11066 instead of change_window_heights and run
11067 run_window_configuration_change_hook.
11068
1a13852e
MR
110692011-06-09 Martin Rudalics <rudalics@gmx.at>
11070
11071 * window.c (replace_window): Rename second argument REPLACEMENT to
11072 NEW. New third argument SETFLAG. Rewrite.
11073 (delete_window, make_dummy_parent): Call replace_window with
11074 third argument 1.
11075 (window_list_1): Move down in code.
11076 (run_window_configuration_change_hook): Move set_buffer part
11077 before select_frame_norecord part in order to unwind correctly.
11078 Rename count1 to count.
11079 (recombine_windows, delete_deletable_window, resize_root_window)
11080 (Fdelete_other_windows_internal)
11081 (Frun_window_configuration_change_hook, make_parent_window)
11082 (resize_window_check, resize_window_apply, Fresize_window_apply)
11083 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11084 (Fdelete_window_internal, Fresize_mini_window_internal):
11085 New functions.
1a13852e
MR
11086 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11087
f3d1777e
MR
110882011-06-08 Martin Rudalics <rudalics@gmx.at>
11089
496e208e
MR
11090 * window.h (window): Add some new members to window structure -
11091 normal_lines, normal_cols, new_total, new_normal, clone_number,
11092 splits, nest, prev_buffers, next_buffers.
11093 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11094 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11095
f3d1777e
MR
11096 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11097 Remove.
496e208e
MR
11098 (make_dummy_parent): Set new members of windows structure.
11099 (make_window): Move down in code. Handle new members of window
11100 structure.
11101 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11102 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11103 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11104 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11105 (Fset_window_next_buffers, Fset_window_clone_number):
11106 New functions.
496e208e
MR
11107 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11108 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11109 Doc-string fixes.
11110 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11111 Argument WINDOW can be now internal window too.
11112 (Fwindow_use_time): Move up in code.
11113 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11114 Rewrite doc-string.
11115 (Fset_window_configuration, saved_window)
11116 (Fcurrent_window_configuration, save_window_save): Handle new
11117 members of window structure.
b9e809c2
MR
11118 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11119 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11120 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11121 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11122 Qget_mru_window, Qresize_root_window,
11123 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11124 Qauto_buffer_name; staticpro them.
f3d1777e 11125
abde8f8c
MR
111262011-06-07 Martin Rudalics <rudalics@gmx.at>
11127
11128 * window.c (Fwindow_total_size, Fwindow_left_column)
11129 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11130 (Fwindow_list_1): New functions.
11131 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11132 (Fwindow_width, Fscroll_left, Fscroll_right):
11133 Use window_body_cols instead of window_box_text_cols.
11134 (delete_window, Fset_window_configuration):
11135 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11136 (delete_all_subwindows): Take a window as argument and not a
11137 structure. Rewrite.
190b47e6
MR
11138 (window_loop): Remove handling of GET_LRU_WINDOW and
11139 GET_LARGEST_WINDOW.
11140 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11141
11142 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11143 window_box_text_cols. delete_all_subwindows now takes a
11144 Lisp_Object as argument.
abde8f8c 11145
640c8776
SM
11146 * indent.c (compute_motion, Fcompute_motion):
11147 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11148
fa8a67e6
MR
11149 * frame.c (delete_frame): Call delete_all_subwindows with root
11150 window as argument.
11151
a54e3482
DC
111522011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11153
11154 * fns.c (Fputhash): Document return value.
11155
60002bf5
CY
111562011-06-06 Chong Yidong <cyd@stupidchicken.com>
11157
11158 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11159
0c671da6 111602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11161
b862a52a 11162 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11163
be44ca6c
PE
11164 Check for overflow when converting integer to cons and back.
11165 * charset.c (Fdefine_charset_internal, Fdecode_char):
11166 Use cons_to_unsigned to catch overflow.
11167 (Fencode_char): Use INTEGER_TO_CONS.
11168 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11169 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11170 * data.c (long_to_cons, cons_to_long): Remove.
11171 (cons_to_unsigned, cons_to_signed): New functions.
11172 These signal an error for invalid or out-of-range values.
11173 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11174 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11175 * font.c (Ffont_variation_glyphs):
11176 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11177 * lisp.h: Include <intprops.h>.
11178 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11179 (cons_to_signed, cons_to_unsigned): New decls.
11180 (long_to_cons, cons_to_long): Remove decls.
11181 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11182 (Fprimitive_undo): Use CONS_TO_INTEGER.
11183 * xfns.c (Fx_window_property): Likewise.
11184 * xselect.c: Include <limits.h>.
11185 (x_own_selection, selection_data_to_lisp_data):
11186 Use INTEGER_TO_CONS.
11187 (x_handle_selection_request, x_handle_selection_clear)
11188 (x_get_foreign_selection, Fx_disown_selection_internal)
11189 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11190 (lisp_data_to_selection_data): Use cons_to_unsigned.
11191 (x_fill_property_data): Use cons_to_signed.
11192 Report values out of range.
11193
d1f3d2af
PE
11194 Check for buffer and string overflow more precisely.
11195 * buffer.h (BUF_BYTES_MAX): New macro.
11196 * lisp.h (STRING_BYTES_MAX): New macro.
11197 * alloc.c (Fmake_string):
11198 * character.c (string_escape_byte8):
11199 * coding.c (coding_alloc_by_realloc):
11200 * doprnt.c (doprnt):
11201 * editfns.c (Fformat):
11202 * eval.c (verror):
11203 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11204 since they may not be the same number.
11205 * editfns.c (Finsert_char):
11206 * fileio.c (Finsert_file_contents):
11207 Likewise for BUF_BYTES_MAX.
11208
dd52fcea
PE
11209 * image.c: Use ptrdiff_t, not int, for sizes.
11210 (slurp_file): Switch from int to ptrdiff_t.
11211 All uses changed.
11212 (slurp_file): Check that file size fits in both size_t (for
11213 malloc) and ptrdiff_t (for sanity and safety).
11214
7f9bbdbb
PE
11215 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11216 if b->modtime has its maximal value.
11217
dfe18f82
PE
11218 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11219
84acfcf0
PE
11220 Don't assume time_t can fit into int.
11221 * buffer.h (struct buffer.modtime): Now time_t, not int.
11222 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11223 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11224
ccd9a01a
PE
11225 Minor fixes for signed vs unsigned integers.
11226 * character.h (MAYBE_UNIFY_CHAR):
11227 * charset.c (maybe_unify_char):
11228 * keyboard.c (read_char, reorder_modifiers):
11229 XINT -> XFASTINT, since the integer must be nonnegative.
11230 * ftfont.c (ftfont_spec_pattern):
11231 * keymap.c (access_keymap, silly_event_symbol_error):
11232 XUINT -> XFASTINT, since the integer must be nonnegative.
11233 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11234 since it makes no difference and we prefer signed.
11235 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11236 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11237 nonnegative.
11238
d6d100dd
SM
112392011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11240
11241 * window.h (Fwindow_frame): Declare.
11242
2b6148e4
PE
112432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11244
11245 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11246 (SPARE_MEMORY): Always define.
11247 (LARGE_REQUEST): Remove.
11248 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11249
f230ecc9
MR
112502011-06-06 Martin Rudalics <rudalics@gmx.at>
11251
727e958e
MR
11252 * lisp.h: Move EXFUNS for Fframe_root_window,
11253 Fframe_first_window and Fset_frame_selected_window to window.h.
11254
11255 * window.h: Move EXFUNS for Fframe_root_window,
11256 Fframe_first_window and Fset_frame_selected_window here from
11257 lisp.h.
11258
11259 * frame.c (Fwindow_frame, Fframe_first_window)
11260 (Fframe_root_window, Fframe_selected_window)
11261 (Fset_frame_selected_window): Move to window.c.
11262 (Factive_minibuffer_window): Move to minibuf.c.
11263 (Fother_visible_frames_p): New function.
11264
11265 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11266
f230ecc9
MR
11267 * window.c (decode_window, decode_any_window): Move up in code.
11268 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11269 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11270 (Fwindow_buffer): Move up and rewrite doc-string.
11271 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11272 (Fwindow_prev): New functions.
727e958e
MR
11273 (Fwindow_frame): Move here from frame.c. Accept any window as
11274 argument.
11275 (Fframe_root_window, Fframe_first_window)
11276 (Fframe_selected_window): Move here from frame.c. Accept frame
11277 or arbitrary window as argument. Update doc-strings.
11278 (Fminibuffer_window): Move up in code.
11279 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11280 (Fset_frame_selected_window): Move here from frame.c.
11281 Marginal rewrite.
727e958e
MR
11282 (Fselected_window, select_window, Fselect_window): Move up in
11283 code. Minor doc-string fixes.
f230ecc9 11284
4d09bcf6
PE
112852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11286
11287 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11288 Do not assume that spare memory exists; that assumption is valid
11289 only if SYSTEM_MALLOC.
11290 (LARGE_REQUEST): New macro, so that the issue of large requests
11291 is separated from the issue of spare memory.
11292
810928a2
AS
112932011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11294
172418ad
AS
11295 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11296 format. (Bug#8806)
11297
43f862f7
AS
11298 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11299
810928a2
AS
11300 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11301 before statements.
11302
a059fe24
JD
113032011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11304
11305 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11306
11307 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11308
11309 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11310 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11311
989bf368
JB
113122011-06-05 Juanma Barranquero <lekktu@gmail.com>
11313
11314 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11315
4b80f674
CY
113162011-06-04 Chong Yidong <cyd@stupidchicken.com>
11317
11318 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11319 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11320 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11321 New error handlers.
4b80f674
CY
11322 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11323 Obey Vx_select_enable_clipboard_manager. Catch errors in
11324 x_clipboard_manager_save (Bug#8779).
11325 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11326 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11327
99a33b77 113282011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11329
11330 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11331
99a33b77 113322011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11333
11334 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11335 in the current matrix if keep_current_p is non-zero.
11336
8264569d
EZ
113372011-06-04 Eli Zaretskii <eliz@gnu.org>
11338
11339 * bidi.c (bidi_level_of_next_char): Fix last change.
11340
57f97249
EZ
113412011-06-03 Eli Zaretskii <eliz@gnu.org>
11342
fec2107c 11343 Support bidi reordering of text covered by display properties.
57f97249 11344
fec2107c
EZ
11345 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11346 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11347 (bidi_cache_search, bidi_cache_iterator_state)
11348 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11349 (bidi_level_of_next_char, bidi_move_to_visually_next):
11350 Support character positions inside a run of characters covered by a
fec2107c
EZ
11351 display string.
11352 (bidi_paragraph_init, bidi_resolve_explicit_1)
11353 (bidi_level_of_next_char): Call bidi_fetch_char and
11354 bidi_fetch_char_advance instead of FETCH_CHAR and
11355 FETCH_CHAR_ADVANCE.
11356 (bidi_init_it): Initialize new members.
11357 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11358 definitions.
11359 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11360 instead of using explicit *_CHAR codes.
d6d100dd
SM
11361 (bidi_resolve_explicit, bidi_resolve_weak):
11362 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11363 bidirectional text is supported only in multibyte buffers.
11364 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11365 it to initialize the frame_window_p member of struct bidi_it.
11366 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11367 (bidi_resolve_explicit, bidi_resolve_weak)
11368 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11369 bidi_it->nchars is non-positive.
11370 (bidi_level_of_next_char): Don't try to lookup the cache for the
11371 next/previous character if nothing is cached there yet, or if we
11372 were just reseat()'ed to a new position.
c40e2fb2 11373
0e14fe90
EZ
11374 * xdisp.c (set_cursor_from_row): Set start and stop points
11375 according to the row's direction when priming the loop that looks
11376 for the glyph on which to display cursor.
11377 (single_display_spec_intangible_p): Function deleted.
11378 (display_prop_intangible_p): Reimplement to call
11379 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11380 Accept 3 additional arguments needed by handle_display_spec.
11381 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11382 values: lists, `(when COND...)' forms, etc.
11383 (single_display_spec_string_p): Support property values that are
11384 lists with the argument STRING its top-level element.
11385 (display_prop_string_p): Fix the condition for processing a
11386 property that is a list to be consistent with handle_display_spec.
fec2107c 11387 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11388 last portion of handle_display_prop.
11389 (compute_display_string_pos): Accept additional argument
11390 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11391 value of a `display' property is a "replacing spec".
11392 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11393 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11394 the display property, but just return a value indicating whether
11395 the display property will replace the characters it covers.
11396 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11397 frame_window_p members of struct bidi_it.
d6d100dd
SM
11398 (compute_display_string_pos, compute_display_string_end):
11399 New functions.
fec2107c
EZ
11400 (push_it): Accept second argument POSITION, where pop_it should
11401 jump to continue iteration.
11402 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11403
fec2107c
EZ
11404 * keyboard.c (adjust_point_for_property): Adjust the call to
11405 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11406
11407 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11408 (bidi_init_it): Update prototypes.
11409 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11410 (compute_display_string_pos, compute_display_string_end):
11411 Declare prototypes.
fec2107c
EZ
11412 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11413 EMACS_INT.
fc6f18ce 11414
40087514 114152011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11416
57f53182
PE
11417 Malloc failure behavior now depends on size of allocation.
11418 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11419 * lisp.h: Change signatures accordingly.
11420 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11421 All callers changed. (Bug#8762)
11422
11423 * gnutls.c: Use Emacs's memory allocators.
11424 Without this change, the gnutls library would invoke malloc etc.
11425 directly, which causes problems on non-SYNC_INPUT hosts, and which
11426 runs afoul of improving memory_full behavior. (Bug#8761)
11427 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11428 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11429 xfree instead of the default malloc, realloc, free.
11430 (Fgnutls_boot): No need to check for memory allocation failure,
11431 since xmalloc does that for us.
11432
ac32cd99 11433 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11434 * category.c (hash_get_category_set):
11435 * ccl.c (ccl_driver):
11436 * charset.c (Fdefine_charset_internal):
11437 * charset.h (struct charset.hash_index):
11438 * composite.c (get_composition_id, gstring_lookup_cache)
11439 (composition_gstring_put_cache):
11440 * composite.h (struct composition.hash_index):
11441 * dispextern.h (struct image.hash):
11442 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11443 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11444 (hashfn_equal, hashfn_user_defined, make_hash_table)
11445 (maybe_resize_hash_table, hash_lookup, hash_put)
11446 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11447 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11448 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11449 * image.c (make_image, search_image_cache, lookup_image)
11450 (xpm_put_color_table_h):
11451 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11452 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11453 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11454 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11455 * alloc.c (allocate_vectorlike):
11456 Check for overflow in vector size calculations.
11457 * ccl.c (ccl_driver):
11458 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11459 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11460 need to be updated by these changes.
40087514
PE
11461 * fns.c (make_hash_table, maybe_resize_hash_table):
11462 Check for integer overflow with large hash tables.
0de4bb68
PE
11463 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11464 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11465 (SXHASH_REDUCE): New macro.
11466 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11467 Use it instead of discarding useful hash info with large hash values.
11468 (sxhash_float): New function.
11469 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11470 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11471 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11472 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11473 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11474 Adjust signatures to match updated version of code.
11475 (consing_since_gc): Now EMACS_INT, since a single hash table can
11476 use more than INT_MAX bytes.
11477
698d32e2
DN
114782011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11479
11480 Make it possible to build with GCC-4.6+ -O2 -flto.
11481
11482 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11483
fd6fa53f
SM
114842011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11485
11486 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11487 Call minibuffer-inactive-mode.
11488
864db017
JB
114892011-05-31 Juanma Barranquero <lekktu@gmail.com>
11490
11491 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11492 Update dependencies.
11493
2ad0baf4
DN
114942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11495
11496 * data.c (init_data): Remove code for UTS, this system is not
11497 supported anymore.
11498
4fcc2638
DN
114992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11500
11501 Don't force ./temacs to start in terminal mode.
11502
11503 * frame.c (make_initial_frame): Initialize faces in all cases, not
11504 only when CANNOT_DUMP is defined.
11505 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11506
c56e0fd5
DN
115072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11508
11509 * dispnew.c (add_window_display_history): Use const for the string
11510 pointer. Remove declaration, not needed.
11511
333d54da 115122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11513
55d4c1b2 11514 Use 'inline', not 'INLINE'.
333d54da 11515 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11516 * alloc.c, fontset.c (INLINE): Remove.
11517 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11518 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11519 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11520 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11521 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11522
738db178
DN
115232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11524
11525 Make it possible to run ./temacs.
11526
11527 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11528 syms_of_callproc does the same thing. Remove test for
11529 "initialized", do it in the caller.
11530 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11531
620c53a6
SM
115322011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11533
11534 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11535 (read_minibuf): Use get_minibuffer.
11536 (syms_of_minibuf): Use DEFSYM.
11537 (Qmetadata): New var.
11538 * data.c (Qbuffer): Don't make it static.
11539 (syms_of_data): Use DEFSYM.
11540
e003a292
PE
115412011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11542
11543 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11544 (CCL_CODE_MIN): New macro.
11545
ed008a6d
PE
115462011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11547
3687c2ef
PE
11548 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11549
ed008a6d
PE
11550 * eval.c (Qdebug): Now static.
11551 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11552 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11553 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11554
d66c4c7c
CY
115552011-05-29 Chong Yidong <cyd@stupidchicken.com>
11556
11557 * image.c: Various fixes to ImageMagick code comments.
11558 (Fimagemagick_types): Doc fix.
11559
5fbc2025
PE
115602011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11561
0196f88a
PE
11562 Minor fixes prompted by GCC 4.6.0 warnings.
11563
11564 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11565
5fbc2025
PE
11566 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11567 (x_clipboard_manager_save_all): Move extern decl to ...
11568 * xterm.h: ... here, so that it can be checked for consistency.
11569
1dd3c2d9
CY
115702011-05-29 Chong Yidong <cyd@stupidchicken.com>
11571
11572 * xselect.c (x_clipboard_manager_save_frame)
11573 (x_clipboard_manager_save_all): New functions.
11574 (Fx_clipboard_manager_save): Lisp function deleted.
11575
11576 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11577 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11578
11579 * xterm.h: Update prototype.
11580
5ba6571d
WX
115812011-05-28 William Xu <william.xwl@gmail.com>
11582
11583 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11584 exiting (Bug#8239).
11585
3eaff834
JM
115862011-05-28 Jim Meyering <meyering@redhat.com>
11587
e1900994 11588 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11589 * fns.c (to_uchar): Define.
11590 (crypto_hash_function): Use it to convert some newly-signed
11591 variables to unsigned, to avoid sign-extension bugs. For example,
11592 without this change, (md5 "truc") would evaluate to
11593 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11594 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11595 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11596
0f6990a7
PE
115972011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11598
11599 Integer overflow fixes.
c8a9ca5a 11600
08686060
PE
11601 * dbusbind.c: Serial number integer overflow fixes.
11602 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11603 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11604 to hold a serial number that is too large for a fixnum.
11605 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11606 Check for serial numbers out of range. Decode any serial number
59568bf0 11607 that was so large that it became a float. (Bug#8722)
08686060 11608
2d1fc3c7
PE
11609 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11610 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11611 Use XFASTINT rather than XUINT when numbers are nonnegative.
11612 (xd_append_arg, Fdbus_method_return_internal):
11613 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11614 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11615 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11616 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11617 (Bug#8722)
2d1fc3c7 11618
c8a9ca5a
PE
11619 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11620
519e1d69
PE
11621 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11622
6df6ae42 11623 ccl: Add integer overflow checks.
30569699
PE
11624 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11625 (IN_INT_RANGE): New macros.
11626 (ccl_driver): Use them to check for integer overflow when
11627 decoding a CCL program. Many of the new checks are whether XINT (x)
11628 fits in int; it doesn't always, on 64-bit hosts. The new version
11629 doesn't catch all possible integer overflows, but it's an
847044ea 11630 improvement. (Bug#8719)
30569699 11631
c11285dc
PE
11632 * alloc.c (make_event_array): Use XINT, not XUINT.
11633 There's no need for unsigned here.
11634
fdccd48e
PE
11635 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11636 This follows up to the 2011-05-06 change that substituted uintptr_t
11637 for EMACS_INT. This case wasn't caught back then.
11638
37910ab2
PE
11639 Rework Fformat to avoid integer overflow issues.
11640 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11641 now (part of C89). Include <verify.h>.
11642 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11643 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11644 (Fformat): Avoid the prepass trying to compute sizes; it was only
11645 approximate and thus did not catch overflow reliably. Instead, walk
11646 through the format just once, formatting and computing sizes as we go,
11647 checking for integer overflow at every step, and allocating a larger
11648 buffer as needed. Keep track separately whether the format is
11649 multibyte. Keep only the most-recently calculated precision, rather
11650 than them all. Record whether each argument has been converted to
11651 string. Use EMACS_INT, not int, for byte and char and arg counts.
11652 Support field widths and precisions larger than INT_MAX. Avoid
11653 sprintf's undefined behavior with conversion specifications such as %#d
11654 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11655 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11656 formatting out-of-range floating point numbers with int
9173deec 11657 formats. (Bug#8668)
37910ab2 11658
2e6578fb
PE
11659 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11660
0ae6bdee
PE
11661 * data.c: Avoid integer truncation in expressions involving floats.
11662 * data.c: Include <intprops.h>.
11663 (arith_driver): When there's an integer overflow in an expression
11664 involving floating point, convert the integers to floating point
11665 so that the resulting value does not suffer from catastrophic
11666 integer truncation. For example, on a 64-bit host (* 4
11667 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11668 Do not rely on undefined behavior after integer overflow.
11669
de883a70
PE
11670 merge count_size_as_multibyte, parse_str_to_multibyte
11671 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11672 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11673 Check for integer overflow.
11674 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11675 since it's now a duplicate of the other. This is more of
11676 a character than a buffer op, so better that it's in character.c.
11677 * fns.c, print.c: Adjust to above changes.
11678
2ff916cb
PE
116792011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11680
11681 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11682
f1b54466
PE
116832011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11684
fb1ac845
PE
11685 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11686 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11687 (x_clipboard_manager_save): Now static.
11688 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11689
f1b54466
PE
11690 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11691 (crypto_hash_function): Now static.
11692 Fix pointer signedness problems. Avoid unnecessary initializations.
11693
a9f737ee
CY
116942011-05-27 Chong Yidong <cyd@stupidchicken.com>
11695
11696 * termhooks.h (Vselection_alist): Make it terminal-local.
11697
11698 * terminal.c (create_terminal): Initialize it.
11699
11700 * xselect.c: Support for clipboard managers.
11701 (Vselection_alist): Move to termhooks.h as terminal-local var.
11702 (LOCAL_SELECTION): New macro.
11703 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11704 (symbol_to_x_atom): Remove gratuitous arg.
11705 (x_handle_selection_request, lisp_data_to_selection_data)
11706 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11707 (x_own_selection, x_get_local_selection, x_convert_selection):
11708 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11709 (some_frame_on_display): Delete unused function.
11710 (Fx_own_selection_internal, Fx_get_selection_internal)
11711 (Fx_disown_selection_internal, Fx_selection_owner_p)
11712 (Fx_selection_exists_p): New optional frame arg.
11713 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11714 (x_handle_selection_clear): Don't treat other terminals with the
11715 same keyboard specially. Use the terminal-local Vselection_alist.
11716 (x_clear_frame_selections): Use Frun_hook_with_args.
11717
11718 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11719
11720 * xterm.h: Add support for those atoms.
11721
e067f0c1
CY
117222011-05-26 Chong Yidong <cyd@stupidchicken.com>
11723
11724 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11725 (converted_selections, conversion_fail_tag): New global variables.
11726 (x_selection_request_lisp_error): Free the above.
11727 (x_get_local_selection): Remove unnecessary code.
11728 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11729 of converted selections stored in converted_selections.
11730 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11731 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11732 (x_convert_selection): New function.
11733 (x_handle_selection_event): Simplify.
11734 (x_get_foreign_selection): Don't ignore incoming requests while
11735 waiting for an answer; this will fail when we implement
11736 SAVE_TARGETS, and seems unnecessary anyway.
11737 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11738 (Vx_sent_selection_functions): Doc fix.
11739
0f4aebc0
LL
117402011-05-26 Leo Liu <sdl.web@gmail.com>
11741
11742 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11743
e61124cd
YM
117442011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11745
11746 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11747
11748 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11749 for fringe update if it has periodic bitmap.
ac389d0c 11750 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11751 and fringe_bitmap_periodic_p.
11752
11753 * fringe.c (get_fringe_bitmap_data): New function.
11754 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11755 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11756 row. Mark glyph row for fringe update if periodicity changed.
11757
11758 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11759 for fringe update unless it has periodic bitmap.
11760
f16d9837
KH
117612011-05-25 Kenichi Handa <handa@m17n.org>
11762
11763 * xdisp.c (get_next_display_element): Set correct it->face_id for
11764 a static composition.
11765
e1b90ef6
LL
117662011-05-24 Leo Liu <sdl.web@gmail.com>
11767
11768 * deps.mk (fns.o):
11769 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11770
11771 * fns.c (crypto_hash_function, Fsha1): New function.
11772 (Fmd5): Use crypto_hash_function.
11773 (syms_of_fns): Add Ssha1.
11774
7400048f
PE
117752011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11776
11777 * gnutls.c: Remove unused macros.
11778 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11779 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11780 Remove macros that are defined and never used.
11781 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11782
abb71cf4
CY
117832011-05-22 Chong Yidong <cyd@stupidchicken.com>
11784
11785 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11786 (Fx_get_selection_internal): Minor cleanup.
11787 (Fx_own_selection_internal): Rename arguments for consistency with
11788 select.el.
11789
6307db39
PE
117902011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11791
11792 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11793
f3d4e0a4
CY
117942011-05-22 Chong Yidong <cyd@stupidchicken.com>
11795
11796 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11797
4d8ade89
YM
117982011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11799
11800 * dispnew.c (scrolling_window): Don't exclude the case that the
11801 last enabled row in the desired matrix touches the bottom boundary.
11802
32078c8d
GM
118032011-05-21 Glenn Morris <rgm@gnu.org>
11804
11805 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11806 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11807 and add some more files.
32078c8d 11808
7285dc67
EZ
118092011-05-20 Eli Zaretskii <eliz@gnu.org>
11810
11811 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11812 report_file_error introduced by the change from 2011-05-07.
11813
89d1bd22
PE
118142011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11815
11816 * systime.h (Time): Define only if emacs is defined.
11817 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11818 where the include path doesn't have X11/X.h by default. See
11819 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11820
cd394be1 118212011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11822
11823 * composite.c (find_automatic_composition): Fix previous change.
11824
b9704ad9
GM
118252011-05-20 Glenn Morris <rgm@gnu.org>
11826
11827 * lisp.mk: New file, split from Makefile.in.
11828 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11829 (shortlisp): Remove.
11830 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11831
4a720484
GM
118322011-05-19 Glenn Morris <rgm@gnu.org>
11833
11834 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11835 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11836 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11837 (lisp): Set the order to that of loadup.el.
11838 (shortlisp): Make it a copy of $lisp.
11839 (SOME_MACHINE_LISP): Remove.
11840 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11841 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11842
a28d4396
KH
118432011-05-18 Kenichi Handa <handa@m17n.org>
11844
11845 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11846 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11847 (find_automatic_composition): Mostly rewrite for efficiency.
11848
a2b1fa8e
JB
118492011-05-18 Juanma Barranquero <lekktu@gmail.com>
11850
11851 * makefile.w32-in: Update dependencies.
11852
8e1f5610
CS
118532011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11854
11855 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11856 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11857
7025ee00 118582011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11859
cdfa6eab
PE
11860 Fix some integer overflow issues, such as string length overflow.
11861
06d6db33
PE
11862 * insdel.c (count_size_as_multibyte): Check for string overflow.
11863
2b4560a8
PE
11864 * character.c (lisp_string_width): Check for string overflow.
11865 Use EMACS_INT, not int, for string indexes and lengths; in
11866 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11867 the resulting string length overflows an EMACS_INT; instead,
11868 report a string overflow if no precision given. When checking for
11869 precision exhaustion, use a check that cannot possibly have
11870 integer overflow. (Bug#8675)
11871 * character.h (lisp_string_width): Adjust to new signature.
11872
cb93f9be
PE
11873 * alloc.c (string_overflow): New function.
11874 (Fmake_string): Use it. This doesn't change behavior, but saves
11875 a few bytes and will simplify future changes.
11876 * character.c (string_escape_byte8): Likewise.
11877 * lisp.h (string_overflow): New decl.
11878
1a1f3366
PE
11879 Fixups, following up to the user-interface timestamp change.
11880 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11881 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11882 * msdos.c (mouse_get_pos): Likewise.
11883 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11884 * w32gui.h (Time): Define by including "systime.h" rather than by
11885 declaring it ourselves. (Bug#8664)
11886
d4e3e4d3
PE
11887 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11888 * image.c (clear_image_cache): Likewise.
11889
f6a24d19
PE
11890 * term.c (term_mouse_position): Don't assume time_t wraparound.
11891
08dc5ae6
PE
11892 Be more systematic about user-interface timestamps.
11893 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11894 and sometimes 'EMACS_UINT', to represent these timestamps.
11895 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11896 This makes the code easier to follow, and makes it easier to catch
11897 integer overflow bugs such as Bug#8664.
11898 * frame.c (Fmouse_position, Fmouse_pixel_position):
11899 Use Time, not unsigned long, for user-interface timestamps.
11900 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11901 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11902 * keyboard.h (last_event_timestamp): Likewise.
11903 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11904 * menu.h (xmenu_show): Likewise.
11905 * term.c (term_mouse_position): Likewise.
11906 * termhooks.h (struct input_event.timestamp): Likewise.
11907 (struct terminal.mouse_position_hook): Likewise.
11908 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11909 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11910 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11911 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11912 what it was before.
11913 * menu.h, termhooks.h: Include "systime.h", for Time.
11914
8e55734a
PE
11915 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11916 Don't assume that the difference between two unsigned long values
11917 can fit into an integer. At this point, we know button_down_time
11918 <= event->timestamp, so the difference must be nonnegative, so
11919 there's no need to cast the result if double-click-time is
11920 nonnegative, as it should be; check that it's nonnegative, just in
11921 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11922 apart (about 25 days). (Bug#8664)
8e55734a 11923
841f1b75 11924 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11925 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11926
3e26f69c
PE
11927 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11928 that always fit in int. Use a sentinel instead of a counter, to
11929 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11930 * frame.h (struct frame): Use int for menu_bar_items_used
11931 instead of EMACS_INT, since it always fits in int.
3e26f69c 11932
5cc152c0
PE
11933 * menu.c (grow_menu_items): Check for int overflow.
11934
d89eb65e
PE
11935 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11936
5235bd3e
PE
11937 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11938 Before, the code was not consistent. These values cannot exceed
11939 2**31 - 1 so there's no need to make them unsigned.
11940 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11941 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11942 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11943 as modifiers.
11944 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11945
bc827e23
PE
11946 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11947 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11948 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11949 presumably because the widths might not match.
11950
78eb494e
PE
11951 * window.c (size_window): Avoid needless test at loop start.
11952
04f2d78b
CB
119532011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11954
11955 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11956
d2fc7e3d 119572011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11958
11959 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11960
d2fc7e3d 119612011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11962
11963 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11964 `width' to `bar_area_x' and `bar_area_width', respectively.
11965 (x_scroll_run): Take account of fringe background extension.
11966
04f2d78b
CB
11967 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11968 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11969 `bar_area_width', respectively.
11970 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11971 background extension.
11972
79b70037
GM
119732011-05-10 Jim Meyering <meyering@redhat.com>
11974
11975 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11976
2f142cc5
JB
119772011-05-10 Juanma Barranquero <lekktu@gmail.com>
11978
11979 * image.c (Finit_image_library): Return t for built-in image types,
11980 like pbm and xbm. (Bug#8640)
11981
57679c86
AS
119822011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11983
11984 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11985
888c9e86
EZ
119862011-05-07 Eli Zaretskii <eliz@gnu.org>
11987
b0512a1d
EZ
11988 * w32console.c (Fset_screen_color): Doc fix.
11989 (Fget_screen_color): New function.
11990 (syms_of_ntterm): Defsubr it.
11991
7285dc67
EZ
11992 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11993 unlink the temporary file if Fcall_process didn't create it in the
11994 first place.
11995 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11996 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11997 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11998 cue to call_process_cleanup not to close that handle.
11999
4d3fcc8e
BK
120002011-05-07 Ben Key <bkey76@gmail.com>
12001
12002 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12003 one of two shell specific rules, either bootstrap-temacs-CMD or
12004 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12005 to the previous implementation of the bootstrap-temacs rule.
12006 The bootstrap-temacs-CMD rule is similar to the previous
12007 implementation of the bootstrap-temacs rule except that it
12008 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12009 variable.
12010
12011 These changes, along with some changes to nt/configure.bat,
12012 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12013 earlier fix to add support for --cflags and --ldflags options
12014 that include quotes so that it works whether make uses cmd or
12015 sh as the shell.
12016
b4289b64
MA
120172011-05-06 Michael Albinus <michael.albinus@gmx.de>
12018
12019 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12020 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12021 is a constant.
12022 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12023 a string. Handle both cases.
12024 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12025 (Fdbus_register_method): Use Qinvalid_function.
12026
af4c0e28
JB
120272011-05-06 Juanma Barranquero <lekktu@gmail.com>
12028
12029 * makefile.w32-in: Update dependencies.
12030 (LISP_H): Add inttypes.h and stdin.h.
12031 (PROCESS_H): Add unistd.h.
12032
c51453d9
EZ
120332011-05-06 Eli Zaretskii <eliz@gnu.org>
12034
12035 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12036 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12037
8ff0ac3c 120382011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12039
4c4b566b
PE
12040 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12041
aab2b9b5
PE
12042 * term.c (vfatal): Remove stray call to va_end.
12043 It's not needed and the C Standard doesn't allow it here anyway.
12044
c378da0b
PE
12045 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12046 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12047
288b08c7
PE
12048 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12049 bytes.
12050
e3601888
PE
12051 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12052
db6c0e74
PE
12053 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12054
dd5963ea
PE
12055 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12056
88c9450f
PE
12057 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12058
2f9442b8
PE
12059 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12060
c032b5f8
PE
12061 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12062 * charset.c (Fdefine_charset_internal): Don't initialize
12063 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12064 32-bit int (Bug#8600).
a108c10b
PE
12065
12066 * lread.c (read_integer): Be more consistent with string-to-number.
12067 Use string_to_number to do the actual conversion; this avoids
12068 rounding errors and fixes some other screwups. Without this fix,
12069 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12070 (digit_to_number): Move earlier, for benefit of read_integer.
12071 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12072 not a digit in any supported base. (Bug#8602)
a108c10b 12073
ad5f9eea
PE
12074 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12075
aec1708a
PE
12076 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12077 to match comment at start of function. This also removes a
12078 GCC warning about overflow in a 32+64-bit port.
12079
47be4ab5
PE
12080 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12081
371cac43
PE
12082 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12083 Reported by Stefan Monnier in
12084 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12085 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12086 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12087
d01a7826
PE
12088 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12089 (EMACS_UINTPTR): Likewise, with uintptr_t.
12090
7fd47d5c
PE
12091 * lisp.h: Prefer 64-bit EMACS_INT if available.
12092 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12093 on 32-bit hosts that have 64-bit int, so that they can access
12094 large files.
122b0c86
PE
12095 However, temporarily disable this change unless the temporary
12096 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12097
8727937b
PE
12098 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12099
8ac068ac
PE
12100 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12101 This removes an assumption that EMACS_INT and long are the same
12102 width as pointers. The assumption is true for Emacs porting targets
12103 now, but we want to make other targets possible.
12104 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12105 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12106 In the rest of the code, change types of integers that hold casted
12107 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12108 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12109 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12110 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12111 No need to cast type when ORing.
12112 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12113 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12114 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12115 assume EMACS_INT is the same width as char *.
12116 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12117 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12118 Remove no-longer-needed casts.
12119 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12120 (xg_tool_bar_help_callback, xg_make_tool_item):
12121 Use EMACS_INTPTR to hold an integer
12122 that will be cast to void *; this can avoid a GCC warning
12123 if EMACS_INT is not the same width as void *.
12124 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12125 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12126 (current_message_1, set_message_1):
12127 Use a local to convert to proper width without a cast.
12128 * xmenu.c (dialog_selection_callback): Likewise.
12129
ede49d71
PE
12130 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12131 Also, don't assume VALBITS / RAND_BITS is less than 5,
12132 and don't rely on undefined behavior when shifting a 1 left into
12133 the sign bit.
12134 * lisp.h (get_random): Change signature to match.
12135
2f30ecd0
PE
12136 * lread.c (hash_string): Use size_t, not int, for hash computation.
12137 Normally we prefer signed values; but hashing is special, because
12138 it's better to use unsigned division on hash table sizes so that
12139 the remainder is nonnegative. Also, size_t is the natural width
12140 for hashing into memory. The previous code used 'int', which doesn't
12141 retain enough info to hash well into very large tables.
12142 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12143
2a866e7b
PE
12144 * dbusbind.c: Don't possibly lose pointer info when converting.
12145 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12146 Use XPNTR rather than XHASH, so that the high-order bits of
12147 the pointer aren't lost when converting through void *.
12148
51639eac
PE
12149 * eval.c (Fautoload): Don't double-shift a pointer.
12150
92394119
PE
12151 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12152
dbdb9a7c
JB
121532011-05-06 Juanma Barranquero <lekktu@gmail.com>
12154
12155 * gnutls.c (DEF_GNUTLS_FN):
12156 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12157
db7a0b4f
AS
121582011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12159
12160 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12161 marker. (Bug#8610)
12162
cd394be1 121632011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12164
12165 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12166 New version that can reserve upto 2GB of heap space.
12167
f7ff1b0f 121682011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12169
12170 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12171
639c109b
TZ
121722011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12173
12174 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12175 `gnutls_certificate_set_x509_key_file'.
12176
d2127135
JB
121772011-05-05 Juanma Barranquero <lekktu@gmail.com>
12178
12179 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12180 Update dependencies.
12181
e968f4f3
JB
121822011-05-04 Juanma Barranquero <lekktu@gmail.com>
12183
12184 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12185 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12186 Remove unused parameter `fildes'.
12187 * process.c (read_process_output, send_process): Don't pass it.
12188
84d358f0
JB
121892011-05-04 Juanma Barranquero <lekktu@gmail.com>
12190
12191 Fix previous change: the library cache is defined in w32.c.
12192 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12193 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12194
0898ca10
JB
121952011-05-04 Juanma Barranquero <lekktu@gmail.com>
12196
12197 Implement dynamic loading of GnuTLS on Windows.
12198
12199 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12200 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12201 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12202 Declare.
12203
12204 * gnutls.c (Qgnutls_dll): Define.
12205 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12206 (gnutls_*): Declare function pointers.
12207 (init_gnutls_functions): New function to initialize function pointers.
12208 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12209 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12210 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12211 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12212 (emacs_gnutls_write, emacs_gnutls_read)
12213 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12214 (Fgnutls_available_p): New function.
12215 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12216 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12217 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12218
12219 * image.c: Include w32.h.
12220 (Vimage_type_cache): Delete.
12221 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12222 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12223 (w32_delayed_load): Move to w32.c.
12224
12225 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12226
12227 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12228 (w32_delayed_load): Move from image.c. When loading a library, record
12229 its filename in the :loaded-from property of the library id.
12230 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12231 Initialize and staticpro them.
12232 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12233
12234 * process.c: Include lisp.h before w32.h, not after.
12235 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12236 instead of gnutls_record_check_pending.
12237
12238 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12239
ff4de4aa
TZ
122402011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12241
12242 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12243 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12244 as passed in.
12245
abe95abb
JD
122462011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12247
12248 * xterm.c (x_set_frame_alpha): Do not set property on anything
12249 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12250
e16e55d4
JB
122512011-05-02 Juanma Barranquero <lekktu@gmail.com>
12252
12253 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12254
bafcf6a5
JB
122552011-05-02 Juanma Barranquero <lekktu@gmail.com>
12256
12257 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12258 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12259 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12260 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12261 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12262 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12263 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12264 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12265 (Qgnutls_bootprop_callbacks_verify): Make static.
12266
e7a6747f
AS
122672011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12268
19ed11ba
AS
12269 * callproc.c: Indentation fixup.
12270
e7a6747f 12271 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12272 (wait_for_termination, interruptible_wait_for_termination):
12273 Move after wait_for_termination_1.
e7a6747f 12274
1ef14cb4
LMI
122752011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12276
12277 * sysdep.c (interruptible_wait_for_termination): New function
12278 which is like wait_for_termination, but allows keyboard
12279 interruptions.
12280
12281 * callproc.c (Fcall_process): Add (:file "file") as an option for
12282 the STDOUT buffer.
12283 (Fcall_process_region): Ditto.
12284
330d880c
EZ
122852011-04-30 Eli Zaretskii <eliz@gnu.org>
12286
8db90b73
EZ
12287 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12288 rather than `XVECTOR (FOO)->size'.
12289
330d880c
EZ
12290 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12291 inttypes.h, as a gnulib replacement is used if it not available in
12292 system headers.
12293
15cbd324
EZ
122942011-04-21 Eli Zaretskii <eliz@gnu.org>
12295
12296 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12297 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12298 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12299
12300 * coding.c (coding_alloc_by_realloc): Error out if destination
12301 will grow beyond MOST_POSITIVE_FIXNUM.
12302 (decode_coding_emacs_mule): Abort if there isn't enough place in
12303 charbuf for the composition carryover bytes. Reserve an extra
12304 space for up to 2 characters produced in a loop.
12305 (decode_coding_iso_2022): Abort if there isn't enough place in
12306 charbuf for the composition carryover bytes.
12307
123082011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12309
ae940cca
EZ
12310 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12311 aborting when %lld or %lll format is passed.
12312 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12313 %llo or %llx format is passed. (Bug#8545)
12314
03ab8921
EZ
12315 * window.c (window_scroll_line_based): Use a marker instead of
12316 simple variables to record original value of point. (Bug#7952)
12317
afda1437
EZ
12318 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12319 produced by %s or %c overflows available buffer space. (Bug#8545)
12320
f76dee0c
PE
123212011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12322
12323 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12324 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12325
fdc5744d
JB
123262011-04-28 Juanma Barranquero <lekktu@gmail.com>
12327
12328 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12329
638f053a
JB
123302011-04-28 Juanma Barranquero <lekktu@gmail.com>
12331
12332 * keyboard.c (Qdelayed_warnings_hook): Define.
12333 (command_loop_1): Run `delayed-warnings-hook'
12334 if Vdelayed_warnings_list is non-nil.
12335 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12336 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12337
d178f871
EZ
123382011-04-28 Eli Zaretskii <eliz@gnu.org>
12339
12340 * doprnt.c (doprnt): Don't return value smaller than the buffer
12341 size if the message was truncated. (Bug#8545).
12342
b124fd93
JB
123432011-04-28 Juanma Barranquero <lekktu@gmail.com>
12344
12345 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12346 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12347
e810457d
PE
123482011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12349
12350 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12351
ea51cceb
JB
123522011-04-27 Juanma Barranquero <lekktu@gmail.com>
12353
12354 * makefile.w32-in: Update dependencies.
12355
94dcfacf
EZ
123562011-04-27 Eli Zaretskii <eliz@gnu.org>
12357
12358 Improve `doprnt' and its usage. (Bug#8545)
12359 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12360 `format_end'. Remove support for %l as a conversion specifier.
12361 Don't use xrealloc. Improve diagnostics when the %l size modifier
12362 is used. Update the commentary.
12363
12364 * eval.c (verror): Simplify calculation of size_t.
12365
12366 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12367 messages.
12368
f61f41d7
PE
123692011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12370
12371 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12372 change.
12373
96fb4434
PE
123742011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12375
12376 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12377 This makes this file independent of the recent pseudovector change.
12378
671875da 123792011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12380
69e9b5a3
PE
12381 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12382
b5f869a7 12383 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12384 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12385 Remove unused local.
c8926152 12386 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12387
841a1577 12388 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12389 GCC 4.6.0 optimizes based on type-based alias analysis.
12390 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12391 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12392 != &v->size, and therefore "v->size = 1; b->size = 2; return
12393 v->size;" must therefore return 1. This assumption is incorrect
12394 for Emacs, since it type-puns struct Lisp_Vector * with many other
12395 types. To fix this problem, this patch adds a new type struct
f904488f 12396 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12397 and pseudovectors, and helps optimizing compilers not get fooled
12398 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12399 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12400 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12401 the size member.
eab3844f
PE
12402 (XSETPVECTYPE): Rewrite in terms of new macro.
12403 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12404 This is a bit clearer, and further avoids the possibility of
12405 undesirable aliasing.
12406 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12407 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12408 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12409 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12410 (ASIZE): Now uses header.size rather than size.
12411 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12412 to avoid the hassle of writing XVECTOR (foo)->header.size.
12413 (struct vectorlike_header): New type.
eab3844f
PE
12414 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12415 object, to help avoid aliasing.
12416 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12417 (SUBRP): Likewise, since Lisp_Subr is a special case.
12418 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12419 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12420 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12421 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12422 changed to be "header.size" and "header.next".
12423 * buffer.h (struct buffer): Likewise.
12424 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12425 * frame.h (struct frame): Likewise.
12426 * process.h (struct Lisp_Process): Likewise.
12427 * termhooks.h (struct terminal): Likewise.
12428 * window.c (struct save_window_data, struct saved_window): Likewise.
12429 * window.h (struct window): Likewise.
12430 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12431 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12432 * buffer.c (init_buffer_once): Likewise.
12433 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12434 special case.
12435 * process.c (Fformat_network_address): Use local var for size,
12436 for brevity.
12437
0df1eac5
PE
12438 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12439
847ab9d1 12440 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12441 * data.c (atof): Remove decl; no longer used or needed.
12442 (digit_to_number): Move to lread.c.
12443 (Fstring_to_number): Use new string_to_number function, to be
12444 consistent with how the Lisp reader treats infinities and NaNs.
12445 Do not assume that floating-point numbers represent EMACS_INT
12446 without losing information; this is not true on most 64-bit hosts.
12447 Avoid double-rounding errors, by insisting on integers when
12448 parsing non-base-10 numbers, as the documentation specifies.
12449 * lisp.h (string_to_number): New decl, replacing ...
12450 (isfloat_string): Remove.
bc0a5c13 12451 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12452 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12453 appears to have been a coding error. Similarly, do not accept
12454 strings like +-1e0 as floating point numbers. Do not report
12455 overflow for integer overflows unless the base is not 10 which
12456 means we have no simple and reliable way to continue.
12457 Break out the floating-point parsing into a new
12458 function string_to_number, so that Fstring_to_number parses
12459 floating point numbers consistently with the Lisp reader.
04f2d78b 12460 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12461 (E_CHAR, EXP_INT): Remove, replacing with ...
12462 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12463 (string_to_number): New function, replacing isfloat_string.
12464 This function checks for valid syntax and produces the resulting
12465 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12466 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12467 so that overflow for non-base-10 numbers is reported only when
12468 there's no portable and simple way to convert to floating point.
452f4150 12469
67769ffc
PE
12470 * textprop.c (set_text_properties_1): Rewrite for clarity,
12471 and to avoid GCC warning about integer overflow.
12472
c20db43f
PE
12473 * intervals.h (struct interval): Use EMACS_INT for members
12474 where EMACS_UINT might cause problems. See
12475 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12476 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12477 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12478 All uses changed.
37aa2f85
PE
12479 (offset_intervals): Tell GCC not to worry about length overflow
12480 when negating a negative length.
c20db43f 12481
2538aa2f
PE
12482 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12483 (overrun_check_free): Likewise.
12484
f2d3008d
PE
12485 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12486 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12487 word size.
12488
ec8df744
PE
12489 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12490 (gnutls_make_error): Rename local to avoid shadowing.
12491 (gnutls_emacs_global_deinit): ifdef out; not used.
12492 (Fgnutls_boot): Use const for pointer to readonly storage.
12493 Comment out unused local. Fix pointer signedness problems.
12494
640ee02d
PE
12495 * lread.c (openp): Don't stuff size_t into an 'int'.
12496 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12497 about possible signed overflow.
12498
6048fb2a
PE
12499 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12500 (GDK_KEY_g): Don't define if already defined.
12501 (xg_prepare_tooltip): Avoid pointer signedness problem.
12502 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12503
fa3c87e1
PE
12504 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12505 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12506
2172544b
PE
12507 * xfns.c (Fx_window_property): Simplify a bit,
12508 to make a bit faster and to avoid GCC 4.6.0 warning.
12509 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12510
9b821a21
PE
12511 * fns.c (internal_equal): Don't assume size_t fits in int.
12512
3c616cfa
PE
12513 * alloc.c (compact_small_strings): Tighten assertion a little.
12514
c2982e87
PE
12515 Replace pEd with more-general pI, and fix some printf arg casts.
12516 * lisp.h (pI): New macro, generalizing old pEd macro to other
12517 conversion specifiers. For example, use "...%"pI"d..." rather
12518 than "...%"pEd"...".
12519 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12520 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12521 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12522 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12523 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12524 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12525 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12526 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12527 64-bit hosts.
12528 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12529 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12530 * print.c (safe_debug_print, print_object): Likewise.
12531 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12532 to int.
6f04d126
PE
12533 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12534 avoiding the 0 flag, which is not portable.
c2982e87
PE
12535 * process.c (Fmake_network_process): Use pI to avoid cast.
12536 * region-cache.c (pp_cache): Likewise.
12537 * xdisp.c (decode_mode_spec): Likewise.
12538 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12539 behavior on 64-bit hosts with printf arg.
6f04d126 12540 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12541 (x_stop_queuing_selection_requests): Likewise.
12542 (x_get_window_property): Don't truncate byte count to an 'int'
12543 when tracing.
0b432f21 12544
5e073ec7
PE
12545 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12546 here, since it parses constructs like leading '-' and spaces,
12547 which are not wanted; and it overflows with large numbers.
12548 Instead, simply match F[0-9]+, which is what is wanted anyway.
12549
36372bf9
PE
12550 * alloc.c: Remove unportable assumptions about struct layout.
12551 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12552 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12553 (allocate_vectorlike, make_pure_vector): Use the new macros,
12554 plus offsetof, to remove unportable assumptions about struct layout.
12555 These assumptions hold on all porting targets that I know of, but
12556 they are not guaranteed, they're easy to remove, and removing them
12557 makes further changes easier.
12558
0b432f21
PE
12559 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12560 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12561 (string_overrun_cookie): Now const. Use initializers that
12562 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12563 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12564 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12565 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12566 multiple of sizeof (EMACS_INT); it need not be, if
12567 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12568 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12569
895009e1
JB
125702011-04-26 Juanma Barranquero <lekktu@gmail.com>
12571
12572 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12573
6a7a1b0b
TZ
125742011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12575
12576 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12577 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12578 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12579
841a1577 125802011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12581
12582 * lisp.h (Qdebug): List symbol.
895009e1 12583 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12584 * keyboard.c (debug-on-event): New variable.
12585 (handle_user_signal): Break into debugger when debug-on-event
12586 matches the current signal symbol.
12587
f2d3ba6f
DN
125882011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12589
12590 * alloc.c (check_sblock, check_string_bytes)
12591 (check_string_free_list): Convert to standard C.
12592
42ce4c63
TZ
125932011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12594
12595 * w32.c (emacs_gnutls_push): Fix typo.
12596
825cd63c
EZ
125972011-04-25 Eli Zaretskii <eliz@gnu.org>
12598
fb11d64d
EZ
12599 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12600 "cast to pointer from integer of different size".
12601
825cd63c
EZ
12602 Improve doprnt and its use in verror. (Bug#8545)
12603 * doprnt.c (doprnt): Document the set of format control sequences
12604 supported by the function. Use SAFE_ALLOCA instead of always
12605 using `alloca'.
12606
12607 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12608 is one byte too soon. Don't use xrealloc; instead xfree and
12609 xmalloc anew.
12610
e061a11b
TZ
126112011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12612
12613 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12614 callbacks stage.
12615
12616 * gnutls.c: Renamed global_initialized to
12617 gnutls_global_initialized. Added internals for the
12618 :verify-hostname-error, :verify-error, and :verify-flags
12619 parameters of `gnutls-boot' and documented those parameters in the
12620 docstring. Start callback support.
9173deec
JB
12621 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12622 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12623 on error. Return error code.
e061a11b
TZ
12624 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12625 (emacs_gnutls_read): Likewise.
12626 (Fgnutls_boot): Return handshake error code.
12627 (emacs_gnutls_handle_error): New function.
12628 (wsaerror_to_errno): Likewise.
12629
12630 * w32.h (emacs_gnutls_pull): Add prototype.
12631 (emacs_gnutls_push): Likewise.
12632
12633 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12634 (emacs_gnutls_push): Likewise.
12635
126362011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12637
12638 * process.c (wait_reading_process_output): Check if GnuTLS
12639 buffered some data internally if no FDs are set for TLS
12640 connections.
12641
12642 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12643 (LIBS): Link to USER_LIBS.
12644 ($(BLD)/gnutls.$(0)): New target.
12645
fa6996bc
EZ
126462011-04-24 Eli Zaretskii <eliz@gnu.org>
12647
eb35682e
EZ
12648 * xdisp.c (handle_single_display_spec): Rename the
12649 display_replaced_before_p argument into display_replaced_p, to
12650 make it consistent with the commentary. Fix typos in the
12651 commentary.
12652
e2ad650c
EZ
12653 * textprop.c (syms_of_textprop): Remove dead code.
12654 (copy_text_properties): Delete obsolete commentary about an
12655 interface that was deleted long ago. Fix typos in the description
12656 of arguments.
12657
1b2de274
EZ
12658 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12659 to changes in oldXMenu/XMenu.h from 2011-04-16.
12660 <menu_help_message, prev_menu_help_message>: Constify.
12661 (IT_menu_make_room): menu->help_text is now `const char **';
12662 adjust.
12663
12664 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12665 to changes in oldXMenu/XMenu.h from 2011-04-16.
12666 (struct XMenu): Declare `help_text' `const char **'.
12667
12668 * xfaces.c <Qunspecified>: Make extern again.
12669
12670 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12671 required by POSIX.
1b2de274 12672
762b15be
EZ
12673 * doc.c (get_doc_string): Improve the format passed to `error'.
12674
12675 * doprnt.c (doprnt): Improve commentary.
12676
12677 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12678
12679 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12680 them with etags.
12681
f1052e5d
EZ
12682 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12683 changes in globals.h immediately force recompilation.
762b15be
EZ
12684 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12685 $(CURDIR)/s/ms-w32.h.
12686 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12687
fa6996bc
EZ
12688 * character.c (Fchar_direction): Function deleted.
12689 (syms_of_character): Don't defsubr it.
12690 <char-direction-table>: Deleted.
12691
e6c3da20
EZ
126922011-04-23 Eli Zaretskii <eliz@gnu.org>
12693
12694 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12695 * doprnt.c: Include limits.h.
12696 (SIZE_MAX): New macro.
04f2d78b
CB
12697 (doprnt): Return a size_t value. 2nd arg is now size_t.
12698 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12699 Improve overflow protection. Support `l' modifier for integer
12700 conversions. Support %l conversion. Don't assume an EMACS_INT
12701 argument for integer conversions and for %c.
12702
12703 * lisp.h (doprnt): Restore prototype.
12704
12705 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12706 $(SRC)/character.h.
12707
12708 * Makefile.in (base_obj): Add back doprnt.o.
12709
12710 * deps.mk (doprnt.o): Add back prerequisites.
12711 (callint.o): Depend on character.h.
12712
12713 * eval.c (internal_lisp_condition_case): Include the handler
12714 representation in the error message.
12715 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12716 when breaking from the loop.
12717
12718 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12719
12720 * callint.c (Fcall_interactively): When displaying error message
12721 about invalid control letter, pass the character's codepoint, not
12722 a pointer to its multibyte form. Improve display of the character
12723 in octal and display also its hex code.
12724
12725 * character.c (char_string): Use %x to display the (unsigned)
12726 codepoint of an invalid character, to avoid displaying a bogus
12727 negative value.
12728
12729 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12730 `error', not SYMBOL_NAME itself.
12731
12732 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12733 character arguments to `error'.
12734
12735 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12736 to `error' in error message about FINAL_CHAR argument. Make sure
12737 FINAL_CHAR is a character, and use %c when it is passed as
12738 argument to `error'.
12739
4ffd0d6b 127402011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12741
12742 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12743
12744 * w32.c: Include <time.h>.
12745 (sys_localtime): New function.
12746
4ffd0d6b 127472011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12748
12749 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12750
4ffd0d6b 12751 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12752
4ffd0d6b 127532011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12754
4ffd0d6b
GM
12755 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12756 zombies (Bug#8467).
aac0c6e3 12757
04c56954
EZ
127582011-04-19 Eli Zaretskii <eliz@gnu.org>
12759
12760 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12761 gl_state.e_property when gl_state.object is Qt.
12762
12763 * insdel.c (make_gap_larger): Remove limitation of buffer size
12764 to <= INT_MAX.
12765
16a43933
CY
127662011-04-18 Chong Yidong <cyd@stupidchicken.com>
12767
12768 * xdisp.c (lookup_glyphless_char_display)
12769 (produce_glyphless_glyph): Handle cons cell entry in
12770 glyphless-char-display.
12771 (Vglyphless_char_display): Document it.
12772
12773 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12774 glyphless-char-display.
12775
4581706e
CY
127762011-04-17 Chong Yidong <cyd@stupidchicken.com>
12777
12778 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12779
12780 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12781
12782 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12783 definition for no-X builds.
12784
4887c6e2 127852011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12786
fd35b6f9
PE
12787 Static checks with GCC 4.6.0 and non-default toolkits.
12788
5c1ccb01
PE
12789 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12790
006c5daa
PE
12791 * process.c (keyboard_bit_set): Define only if SIGIO.
12792 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12793 (send_process): Repair possible setjmp clobbering.
12794
efc736d3
PE
12795 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12796
4e2fe2e6
PE
12797 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12798
f97334a2
PE
12799 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12800
4e75f29d
PE
12801 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12802 Define only if needed.
12803
90efadd1
PE
12804 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12805 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12806 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12807
3c647824
PE
12808 * dispextern.h (struct redisplay_interface): Rename param
12809 to avoid shadowing.
e264f262 12810 * termhooks.h (struct terminal): Likewise.
761383f4 12811 * xterm.c (xembed_send_message): Likewise.
3c647824 12812
b58c5c4a
PE
12813 * insdel.c (make_gap_smaller): Define only if
12814 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12815
cad59032
PE
12816 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12817 it.
12818
c339dc2e
PE
12819 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12820 so that we aren't warned about unused symbols.
12821
91a3e27b
PE
12822 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12823
399c71d3 12824 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12825
8ffc96f5
PE
12826 * xfns.c (x_real_positions): Mark locals as initialized.
12827
eef9bc79
PE
12828 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12829
098db9dd
PE
12830 * xterm.c: Fix problems found by static analysis with other toolkits.
12831 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12832 (x_dispatch_event): Declare static if USE_GTK, and
12833 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12834 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12835 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12836 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12837 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12838
eb18f6cc
PE
12839 * xmenu.c (menu_help_callback): Pointer type fixes.
12840 Use const pointers when pointing at readonly data. Avoid pointer
12841 signedness clashes.
12842 (FALSE): Remove unused macro.
12843 (update_frame_menubar): Remove unused decl.
12844
1fe72bf8
PE
12845 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12846
60d9e1db
PE
12847 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12848 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12849 (single_menu_item): Rename local to avoid shadowing.
12850
39261c26
PE
12851 * keyboard.c (make_lispy_event): Remove unused local var.
12852
018c5e19
PE
12853 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12854 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12855
63d2b86e
PE
12856 * bitmaps: Change bitmaps from unsigned char back to the X11
12857 compatible char. Avoid the old compiler warnings about
12858 out-of-range initializers by using, for example, '\xab' rather
12859 than 0xab.
12860
aefd87e1
PE
12861 * xgselect.c (xgselect_initialize): Check vs interface
12862 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12863
bf501fb9
PE
12864 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12865
e9829fdf
PE
12866 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12867 to read-only memory.
12868
1086c095
PE
12869 * fns.c (vector): Remove; this old hack is no longer needed.
12870
2baccd04 12871 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12872 Remove unused var.
dde42981 12873 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12874
72391843 12875 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12876
436c16df 12877 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12878 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12879 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12880
92bb796d 12881 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12882 (x_term_init): Remove local to avoid shadowing.
92bb796d 12883
764430a3 12884 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12885
12886 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12887 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12888
d1dfb56c
EZ
128892011-04-16 Eli Zaretskii <eliz@gnu.org>
12890
c4354cb4
EZ
12891 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12892
d1dfb56c
EZ
12893 Fix regex.c, syntax.c and friends for buffers > 2GB.
12894 * syntax.h (struct gl_state_s): Declare character position members
12895 EMACS_INT.
12896
12897 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12898
04f2d78b
CB
12899 * textprop.c (verify_interval_modification, interval_of):
12900 Declare arguments EMACS_INT.
d1dfb56c
EZ
12901
12902 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12903 EMACS_INT.
12904
12905 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12906
12907 * indent.c (Fvertical_motion): Local variable it_start is now
12908 EMACS_INT.
12909
12910 * regex.c (re_match, re_match_2, re_match_2_internal)
12911 (bcmp_translate, regcomp, regexec, print_double_string)
12912 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12913 (re_compile_pattern, re_exec): Declare arguments and local
12914 variables `size_t' and `ssize_t' and return values `regoff_t', as
12915 appropriate.
12916 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12917 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12918 <compile_stack_type>: `size' and `avail' are now `size_t'.
12919
12920 * regex.h <regoff_t>: Use ssize_t, not int.
12921 (re_search, re_search_2, re_match, re_match_2): Arguments that
12922 specify buffer/string position and length are now ssize_t and
12923 size_t. Return type is regoff_t.
12924
613052cd
BK
129252011-04-16 Ben Key <bkey76@gmail.com>
12926
12927 * nsfont.m: Fixed bugs in ns_get_family and
12928 ns_descriptor_to_entity that were caused by using free to
12929 deallocate memory blocks that were allocated by xmalloc (via
12930 xstrdup). This caused Emacs to crash when compiled with
12931 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12932 --enable-checking=xmallocoverrun). xfree is now used to
12933 deallocate these memory blocks.
12934
4170f62f 129352011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12936
71b41406
PE
12937 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12938
9587a89d
PE
12939 emacs_write: Accept and return EMACS_INT for sizes.
12940 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12941 et seq.
12942 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12943 Accept and return EMACS_INT.
12944 (emacs_gnutls_write): Return the number of bytes written on
12945 partial writes.
12946 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12947 (emacs_read, emacs_write): Remove check for negative size, as the
12948 Emacs source code has been audited now.
9587a89d
PE
12949 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12950 (emacs_read, emacs_write): Use it.
273a5f82
PE
12951 * process.c (send_process): Adjust to the new signatures of
12952 emacs_write and emacs_gnutls_write. Do not attempt to store
12953 a byte offset into an 'int'; it might overflow.
9587a89d 12954 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12955
3e047f51
PE
12956 * sound.c: Don't assume sizes fit in 'int'.
12957 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12958 Return EMACS_INT, not int.
3e047f51 12959 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12960 Accept EMACS_INT, not int.
12961 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12962 record read return values.
12963
cc39a9db
BK
129642011-04-15 Ben Key <bkey76@gmail.com>
12965
c9d0ec6d
JB
12966 * keyboard.c (Qundefined): Don't declare static since it is used
12967 in nsfns.m.
12968 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12969 static since they are used in nsfont.m.
cc39a9db 12970
6c60eb9f
SM
129712011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12972
12973 * process.c (Qprocessp): Don't declare static.
12974 * lisp.h (Qprocessp): Declare again.
12975
7990b61a
JB
129762011-04-15 Juanma Barranquero <lekktu@gmail.com>
12977
12978 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12979
5d4cb038
PE
129802011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12981
8bd7b830 12982 Improve C-level modularity by making more things 'static'.
cd64ea1d 12983
e3b27b31
PE
12984 Don't publish debugger-only interfaces to other modules.
12985 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12986 (verify_bytepos, count_markers): Move decls to the only modules
12987 that need them.
12988 * region-cache.h (pp_cache): Likewise.
12989 * window.h (check_all_windows): Likewise.
12990 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12991
5d4cb038
PE
12992 * sysdep.c (croak): Now static, if
12993 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12994 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12995
12996 * alloc.c (refill_memory_reserve): Now static if
12997 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12998 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12999
e87b6180
PE
13000 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13001 Define only if USE_LUCID.
13002
ac64929e
PE
13003 * xrdb.c (x_customization_string, x_rm_string): Now static.
13004
6f37259d
PE
13005 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13006 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13007
1683e3ab
PE
13008 * xdisp.c (draw_row_with_mouse_face): Now static.
13009 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13010
de9c2632
PE
13011 * window.h (check_all_windows): Mark externally visible.
13012
2b96acb7
PE
13013 * window.c (window_deletion_count): Now static.
13014
13015 * undo.c: Make symbols static if they're not exported.
13016 (last_undo_buffer, last_boundary_position, pending_boundary):
13017 Now static.
13018
50436f33
PE
13019 * textprop.c (interval_insert_behind_hooks): Now static.
13020 (interval_insert_in_front_hooks): Likewise.
13021
64520e5c
PE
13022 * term.c: Make symbols static if they're not exported.
13023 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13024 (max_frame_lines, tty_set_terminal_modes):
13025 (tty_reset_terminal_modes, tty_turn_off_highlight):
13026 (get_tty_terminal): Now static.
13027 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13028 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13029 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13030 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13031 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13032
1fa53021
PE
13033 * sysdep.c: Make symbols static if they're not exported.
13034 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13035 Now static.
13036 (sigprocmask_set, full_mask): Remove; unused.
13037 (wait_debugging): Mark as visible.
13038 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13039 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13040
d4b43b22
PE
13041 * syntax.c (syntax_temp): Define only if !__GNUC__.
13042
b7c513d0
PE
13043 * sound.c (current_sound_device, current_sound): Now static.
13044
989b29ad
PE
13045 * search.c (searchbufs, searchbuf_head): Now static.
13046
13a55a78
PE
13047 * scroll.c (scroll_cost): Remove; unused.
13048 * dispextern.h (scroll_cost): Remove decl.
13049
de68a1fc
PE
13050 * region-cache.h (pp_cache): Mark as externally visible.
13051
40ccffa6
PE
13052 * process.c: Make symbols static if they're not exported.
13053 (process_tick, update_tick, create_process, chan_process):
13054 (Vprocess_alist, proc_buffered_char, datagram_access):
13055 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13056 (deactivate_process): Mark defn as static, as well as decl.
13057 * lisp.h (create_process): Remove decl.
13058 * process.h (chan_process, Vprocess_alist): Remove decls.
13059
ad64fc97
PE
13060 * print.c: Make symbols static if they're not exported.
13061 (print_depth, new_backquote_output, being_printed, print_buffer):
13062 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13063 (print_interval, print_number_index, initial_stderr_stream):
13064 Now static.
13065 * lisp.h (Fprinc): Remove decl.
13066 (debug_output_compilation_hack): Mark as externally visible.
13067
adddb265
PE
13068 * sysdep.c (croak): Move decl from here to syssignal.h.
13069 * syssignal.h (croak): Put it here, so the API can be checked when
13070 'croak' is called from dissociate_if_controlling_tty.
13071
1717ede2
PE
13072 * minibuf.c: Make symbols static if they're not exported.
13073 (minibuf_save_list, choose_minibuf_frame): Now static.
13074 * lisp.h (choose_minibuf_frame): Remove decl.
13075
fa5fb2bc
PE
13076 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13077
1e3890d1
PE
13078 * lread.c: Make symbols static if they're not exported.
13079 (read_objects, initial_obarray, oblookup_last_bucket_number):
13080 Now static.
13081 (make_symbol): Remove; unused.
13082 * lisp.h (initial_obarray, make_symbol): Remove decls.
13083
8a1414fa
PE
13084 * keyboard.c: Make symbols static if they're not exported.
13085 (single_kboard, recent_keys_index, total_keys, recent_keys):
13086 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13087 (this_single_command_key_start, echoing, last_auto_save):
13088 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13089 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13090 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13091 (Vlispy_mouse_stem, double_click_count):
13092 Now static.
13093 (force_auto_save_soon): Define only if SIGDANGER.
13094 (ignore_mouse_drag_p): Now static if
13095 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13096 (print_help): Remove; unused.
13097 (stop_character, last_timer_event): Mark as externally visible.
13098 * keyboard.h (ignore_mouse_drag_p): Declare only if
13099 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13100 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13101 * lisp.h (echoing): Remove decl.
13102 (force_auto_save_soon): Declare only if SIGDANGER.
13103 * xdisp.c (redisplay_window): Simplify code, to make it more
13104 obvious that ignore_mouse_drag_p is not accessed if !defined
13105 USE_GTK && !defined HAVE_NS.
13106
93ea6e8f
PE
13107 * intervals.c: Make symbols static if they're not exported.
13108 (merge_properties_sticky, merge_interval_right, delete_interval):
13109 Now static.
13110 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13111
77382fcc
PE
13112 * insdel.c: Make symbols static if they're not exported.
13113 However, leave prepare_to_modify_buffer alone. It's never
13114 called from outside this function, but that appears to be a bug.
13115 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13116 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13117 (adjust_after_replace_noundo): Remove; unused.
13118 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13119 (signal_before_change): Remove decls.
77382fcc 13120
9306c32e
PE
13121 * indent.c (val_compute_motion, val_vmotion): Now static.
13122
cd44d2eb
PE
13123 * image.c: Make symbols static if they're not exported.
13124 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13125 if USE_GTK.
13126 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13127 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13128
ad9a7a06
PE
13129 * fringe.c (standard_bitmaps): Now static.
13130 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13131
81626931
PE
13132 * frame.c: Make symbols static if they're not exported.
13133 (x_report_frame_params, make_terminal_frame): Now static.
13134 (get_frame_param): Now static, unless HAVE_NS.
13135 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13136 (x_get_resource_string): Remove; not used.
13137 * frame.h (make_terminal_frame, x_report_frame_params):
13138 (x_get_resource_string); Remove decls.
13139 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13140 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13141
239f9db9
PE
13142 * font.c, fontset.c: Make symbols static if they're not exported.
13143 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13144 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13145 * font.c (font_close_object): Now static.
13146 * font.h (font_close_object): Remove.
13147 * fontset.c (FONTSET_OBJLIST): Remove.
13148 (free_realized_fontset) #if-0 the body, which does nothing.
13149 (face_suitable_for_char_p): #if-0, as it's never called.
13150 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13151 * xfaces.c (face_at_string_position):
13152 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13153 since 0 is always ASCII.
13154
dfcf3579
PE
13155 * fns.c (weak_hash_tables): Now static.
13156
5045092b
PE
13157 * fileio.c: Make symbols static if they're not exported.
13158 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13159 (Vwrite_region_annotation_buffers): Now static.
13160
57a96f5c
PE
13161 * eval.c: Make symbols static if they're not exported.
13162 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13163 * lisp.h (backtrace_list): Remove decl.
13164
35f08c38
PE
13165 * emacs.c: Make symbols static if they're not exported.
13166 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13167 (fatal_error_code, fatal_error_signal_hook, standard_args):
13168 Now static.
13169 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13170 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13171 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13172 * lisp.h (fatal_error_signal_hook): Remove decl.
13173 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13174
f44bd759
PE
13175 * editfns.c: Move a (normally-unused) function to its only use.
13176 * editfns.c, lisp.h (get_operating_system_release): Remove.
13177 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13178 worth the hassle of breaking this out.
13179
b532497d
PE
13180 * xterm.c: Make symbols static if they're not exported.
13181 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13182 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13183 (x_destroy_window, x_delete_display):
13184 Now static.
13185 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13186 (x_mouse_leave): Remove; unused.
13187 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13188 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13189 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13190 Remove decls.
13191 (x_mouse_leave): Declare only if WINDOWSNT.
13192 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13193 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13194 USE_X_TOOLKIT.
13195
1675728f
PE
13196 * ftxfont.c: Make symbols static if they're not exported.
13197 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13198 HAVE_FREETYPE.
13199 * font.h (ftxfont_driver): Likewise.
13200
e4cebfca
PE
13201 * xfns.c: Make symbols static if they're not exported.
13202 (x_last_font_name, x_display_info_for_name):
13203 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13204 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13205 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13206 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13207 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13208 (last_show_tip_args): Now static.
13209 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13210 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13211 (x_screen_planes): Remove; unused.
13212 * dispextern.h (x_screen_planes): Remove decl.
13213
5bf46f05
PE
13214 * dispnew.c: Make symbols static if they're not exported.
13215 * dispextern.h (redraw_garbaged_frames, scrolling):
13216 (increment_row_positions): Remove.
13217 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13218 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13219 Now static.
13220 (redraw_garbaged_frames): Remove; unused.
13221
435f4c28
PE
13222 * xfaces.c: Make symbols static if they're not exported.
13223 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13224 Remove decls.
13225 * xterm.h (defined_color): Remove decls.
13226 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13227 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13228 (menu_face_changed_default, defined_color, free_realized_face):
13229 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13230 (ascii_face_of_lisp_face): Remove; unused.
13231
8524aef3
PE
13232 * xdisp.c: Make symbols static if they're not exported.
13233 * dispextern.h (scratch_glyph_row, window_box_edges):
13234 (glyph_to_pixel_coords, set_cursor_from_row):
13235 (get_next_display_element, set_iterator_to_next):
13236 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13237 (show_mouse_face): Remove decls
13238 * frame.h (message_buf_print): Likewise.
13239 * lisp.h (pop_message, set_message, check_point_in_composition):
13240 Likewise.
13241 * xterm.h (set_vertical_scroll_bar): Likewise.
13242 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13243 (message_buf_print, scratch_glyph_row, displayed_buffer):
13244 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13245 (get_next_display_element, show_mouse_face, window_box_edges):
13246 (frame_to_window_pixel_xy, check_point_in_composition):
13247 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13248 (glyph_to_pixel_coords): Remove; unused.
13249
16390cd2
PE
13250 * dired.c (file_name_completion): Now static.
13251
13252 * dbusbind.c (xd_in_read_queued_messages): Now static.
13253
a25f4dfa
PE
13254 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13255 * data.c (circular_list_error): Remove.
13256
14a9c8df
PE
13257 * commands.h (last_point_position, last_point_position_buffer):
13258 (last_point_position_window): Remove decls.
13259 * keyboard.c: Make these variables static.
13260
04f2d78b
CB
13261 * coding.h (coding, code_convert_region, encode_coding_gap):
13262 Remove decls.
74ab6df5
PE
13263 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13264 (iso_code_class, detect_coding, code_convert_region): Now static.
13265 (encode_coding_gap): Remove; unused.
13266
38dfbee1
PE
13267 * chartab.c (chartab_chars, chartab_bits): Now static.
13268
a2cb4e63
PE
13269 * charset.h (charset_iso_8859_1): Remove decl.
13270 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13271 Now static.
13272
127198fd
PE
13273 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13274 * ccl.c (Vccl_program_table): Now static.
13275 (check_ccl_update): Remove; unused.
13276
d85b608f
PE
13277 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13278 * category.h: ... from here.
13279 * category.c (check_category_table, set_category_set): Now static.
13280
31cd66f3
PE
13281 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13282 * lisp.h: Remove these decls.
13283
c358e587
PE
13284 * buffer.c (buffer_count): Remove unused var.
13285
e78aecca
PE
13286 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13287 so that it's not optimized away.
13288 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13289 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13290 exported only to the debugger.
13291
e192d7d3 13292 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13293 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13294
92470028
PE
13295 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13296 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13297 was inaccessible from Lisp.
13298 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13299 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13300
244ed907
PE
13301 alloc.c: Import and export fewer symbols, and remove unused items.
13302 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13303 is defined.
13304 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13305 it's not optimized away by whole-program optimization.
13306 (message_enable_multibyte, free_misc): Remove.
13307 (catchlist, handlerlist, mark_backtrace):
13308 Declare only if BYTE_MARK_STACK.
13309 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13310 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13311 (message_enable_multibyte): Remove decl.
13312 (free_misc, interval_free_list, float_block, float_block_index):
13313 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13314 (cons_free_list, last_marked_index):
13315 Now static.
13316 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13317 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13318 (mark_backtrace): Define only if BYTE_MARK_STACK.
13319 * xdisp.c (message_enable_multibyte): Now static.
13320
61c2b50e 13321 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13322 This makes it easier for human readers (and static analyzers)
13323 to see whether these variables are used from other modules.
13324 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13325 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13326 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13327 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13328 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13329 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13330 * xmenu.c, xselect.c:
13331 Declare Q* vars static if they are not used in other modules.
13332 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13333 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13334 Remove decls of unexported vars.
13335 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13336
95c82688
PE
13337 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13338
16a97296
PE
13339 Make Emacs functions such as Fatom 'static' by default.
13340 This makes it easier for human readers (and static analyzers)
13341 to see whether these functions can be called from other modules.
13342 DEFUN now defines a static function. To make the function external
13343 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13344 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13345 (Finit_image_library):
16a97296
PE
13346 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13347 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13348 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13349 Remove decls, since these functions are now static.
13350 (Funintern, Fget_internal_run_time): New decls, since these functions
13351 were already external.
95c82688 13352
16a97296
PE
13353 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13354 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13355 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13356 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13357 * keyboard.c, keymap.c, lread.c:
13358 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13359 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13360 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13361 Mark functions with DEFUE instead of DEFUN,
13362 if they are used in other modules.
13363 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13364 decls for now-static functions.
13365 * buffer.h (Fdelete_overlay): Remove decl.
13366 * callproc.c (Fgetenv_internal): Mark as internal.
13367 * composite.c (Fremove_list_of_text_properties): Remove decl.
13368 (Fcomposition_get_gstring): New forward static decl.
13369 * composite.h (Fcomposite_get_gstring): Remove decl.
13370 * dired.c (Ffile_attributes): New forward static decl.
13371 * doc.c (Fdocumntation_property): New forward static decl.
13372 * eval.c (Ffetch_bytecode): New forward static decl.
13373 (Funintern): Remove extern decl; now in .h file where it belongs.
13374 * fileio.c (Fmake_symbolic_link): New forward static decl.
13375 * image.c (Finit_image_library): New forward static decl.
13376 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13377 * intervals.h (Fprevious_property_change):
13378 (Fremove_list_of_text_properties): Remove decls.
13379 * keyboard.c (Fthis_command_keys): Remove decl.
13380 (Fcommand_execute): New forward static decl.
13381 * keymap.c (Flookup_key): New forward static decl.
13382 (Fcopy_keymap): Now static.
13383 * keymap.h (Flookup_key): Remove decl.
13384 * process.c (Fget_process): New forward static decl.
13385 (Fprocess_datagram_address): Mark as internal.
13386 * syntax.c (Fsyntax_table_p): New forward static decl.
13387 (skip_chars): Remove duplicate decl.
13388 * textprop.c (Fprevious_property_change): New forward static decl.
13389 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13390 Now internal.
13391 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13392 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13393
785bbd42
PE
13394 * editfns.c (Fformat): Remove unreachable code.
13395
8b913b57
AS
133962011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13397
13398 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13399 change. (Bug#8496)
13400
a6744a35
EZ
134012011-04-13 Eli Zaretskii <eliz@gnu.org>
13402
13403 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13404 when at ZV. (Bug#8487)
13405
e7974947
AS
134062011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13407
baad03f0
AS
13408 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13409 (Bug#8437)
13410 * keyboard.c (parse_tool_bar_item): Likewise.
13411 * sound.c (sound_cleanup, alsa_close): Likewise.
13412 * termcap.c (tgetent): Likewise.
13413 * xfns.c (x_default_font_parameter): Likewise.
13414 * xsettings.c (read_and_apply_settings): Likewise.
13415
e7974947
AS
13416 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13417 (overrun_check_free): Protoize.
13418
28272684
PE
134192011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13420
13421 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13422 since callers should never pass a negative size.
13423 Change the signature to match that of plain 'read' and 'write'; see
13424 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13425 * lisp.h: Update prototypes of emacs_write and emacs_read.
13426
11997c76
EZ
134272011-04-11 Eli Zaretskii <eliz@gnu.org>
13428
13429 * xdisp.c (redisplay_window): Don't try to determine the character
13430 position of the scroll margin if the window start point w->startp
e896f03c 13431 is outside the buffer's accessible region. (Bug#8468)
11997c76 13432
8a2cbd72
EZ
134332011-04-10 Eli Zaretskii <eliz@gnu.org>
13434
13435 Fix write-region and its subroutines for buffers > 2GB.
13436 * fileio.c (a_write, e_write): Modify declaration of arguments and
13437 local variables to support buffers larger than 2GB.
13438 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13439
13440 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13441 argument, local variables, and return value.
13442
13443 * lisp.h: Update prototypes of emacs_write and emacs_read.
13444
13445 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13446
4073e537 134472011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13448
1ebfdcb6
PE
13449 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13450
b2ded58d
PE
13451 Fix more problems found by GCC 4.6.0's static checks.
13452
7d66342c
PE
13453 * xdisp.c (vmessage): Use a better test for character truncation.
13454
bbf47d44
PE
13455 * charset.c (load_charset_map): <, not <=, for optimization,
13456 and to avoid potential problems with integer overflow.
9248994d 13457 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13458 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13459 * editfns.c (Fformat): Likewise.
1e69125e 13460 * syntax.c (skip_chars): Likewise.
3befa583 13461
e3019616
PE
13462 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13463 This also lets GCC 4.6.0 generate slightly better loop code.
13464
becfa255
PE
13465 * callint.c (Fcall_interactively): <, not <=, for optimization.
13466 (Fcall_interactively): Count the number of arguments produced,
13467 not the number of arguments given. This is simpler and lets GCC
13468 4.6.0 generate slightly better code.
13469
dae0cd48
PE
13470 * ftfont.c: Distingish more carefully between FcChar8 and char.
13471 The previous code passed unsigned char * to a functions like
13472 strlen and xstrcasecmp that expect char *, which does not
13473 conform to the C standard.
13474 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13475 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13476 char * when the C standard requires it.
13477
76032d70
PE
13478 * keyboard.c (read_char): Remove unused var.
13479
eb3f1cc8
PE
13480 * eval.c: Port to Windows vsnprintf (Bug#8435).
13481 Include <limits.h>.
13482 (SIZE_MAX): Define if the headers do not.
13483 (verror): Do not give up if vsnprintf returns a negative count.
13484 Instead, grow the buffer. This ports to Windows vsnprintf, which
13485 does not conform to C99. Problem reported by Eli Zaretskii.
13486 Also, simplify the allocation scheme, by avoiding the need for
13487 calling realloc, and removing the ALLOCATED variable.
13488
70476b54
PE
13489 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13490
12020a9e
PE
13491 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13492 But keep the doprint source code for now, as we might revamp it
13493 and use it again (Bug#8435).
ea6c7ae6
PE
13494 * lisp.h (doprnt): Remove.
13495 * Makefile.in (base_obj): Remove doprnt.o.
13496 * deps.mk (doprnt.o): Remove.
13497
5fdb398c
PE
13498 error: Print 32- and 64-bit integers portably (Bug#8435).
13499 Without this change, on typical 64-bit hosts error ("...%d...", N)
13500 was used to print both 32- and 64-bit integers N, which relied on
13501 undefined behavior.
61bdb816 13502 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13503 * lisp.h (error, verror): Mark as printf-like functions.
13504 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13505 Report overflow in size calculations when allocating printf buffer.
13506 Do not truncate output string at its first null byte.
13507 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13508 Truncate the output at a character boundary, since vsnprintf does not
13509 do that.
13510 * charset.c (check_iso_charset_parameter): Convert internal
13511 character to string before calling 'error', since %c now has the
13512 printf meaning.
13513 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13514 overflow when computing char to be passed to 'error'. Do not
13515 pass Lisp_Object to 'error'; pass the integer instead.
13516 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13517 formatted with plain %d.
13518
b189fa66
PE
13519 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13520
bff87ef0
PE
13521 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13522
7e2cac20
PE
13523 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13524
ce4d90b5
PE
13525 * xterm.c (x_catch_errors): Remove duplicate declaration.
13526
266c9547
PE
13527 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13528
79c49ad2
PE
13529 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13530
368f4090
JM
135312011-04-10 Jim Meyering <meyering@redhat.com>
13532
13533 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13534 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13535 return ssize_t not "int", and use size_t as the buffer length.
13536 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13537 * gnutls.h: Update declarations.
13538 * process.c (read_process_output): Use ssize_t, to match.
13539 (send_process): Likewise.
13540
a32d4040
CY
135412011-04-09 Chong Yidong <cyd@stupidchicken.com>
13542
13543 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13544
8546720e 135452011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13546
04f2d78b
CB
13547 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13548 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13549
8546720e
GM
13550 * xterm.c (handle_one_xevent):
13551 * xmenu.c (create_and_show_popup_menu):
13552 * xselect.c (x_decline_selection_request)
13553 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13554
0a2f5c1a 135552011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13556
13557 Fix some uses of `int' instead of EMACS_INT.
13558 * search.c (string_match_1, fast_string_match)
13559 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13560 (scan_buffer, find_next_newline_no_quit)
13561 (find_before_next_newline, search_command, Freplace_match)
13562 (Fmatch_data): Make some `int' variables be EMACS_INT.
13563
13564 * xdisp.c (display_count_lines): 3rd argument and return value now
13565 EMACS_INT. All callers changed.
13566 (pint2hrstr): Last argument is now EMACS_INT.
13567
13568 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13569 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13570 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13571 (decode_coding_utf_16, decode_coding_emacs_mule)
13572 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13573 (decode_coding_ccl, decode_coding_charset)
13574 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13575 (decode_coding_iso_2022, decode_coding_emacs_mule)
13576 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13577 <char_offset, last_offset>: Declare EMACS_INT.
13578 (encode_coding_utf_8, encode_coding_utf_16)
13579 (encode_coding_emacs_mule, encode_invocation_designation)
13580 (encode_designation_at_bol, encode_coding_iso_2022)
13581 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13582 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13583 Declare EMACS_INT.
13584 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13585 (encode_invocation_designation): Last argument P_NCHARS is now
13586 EMACS_INT.
13587 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13588 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13589
13590 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13591 All users changed.
13592
13593 * ccl.c (Fccl_execute_on_string): Declare some variables
13594 EMACS_INT.
13595
8546720e 135962011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13597
13598 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13599
4e19a977
CS
136002011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13601
13602 * process.c (Fformat_network_address): Doc fix.
13603
87302331
R
136042011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13605
ee7683eb 13606 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13607
cbb59342
CY
136082011-04-08 Chong Yidong <cyd@stupidchicken.com>
13609
13610 * keyboard.c (read_char): Call Lisp function help-form-show,
13611 instead of using internal_with_output_to_temp_buffer.
13612 (Qhelp_form_show): New var.
e0d38eeb 13613 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13614
13615 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13616
13617 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13618
e67a13ab
CY
136192011-04-06 Chong Yidong <cyd@stupidchicken.com>
13620
04f2d78b
CB
13621 * process.c (Flist_processes): Remove to Lisp.
13622 (list_processes_1): Delete.
e67a13ab 13623
973f782d
EZ
136242011-04-06 Eli Zaretskii <eliz@gnu.org>
13625
7c106b1e
EZ
13626 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13627
973f782d
EZ
13628 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13629
41cf7d1a 136302011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13631
ca23cc88
PE
13632 Fix more problems found by GCC 4.6.0's static checks.
13633
f390e2d5
PE
13634 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13635
42eea0d0
PE
13636 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13637
b69769da 13638 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13639
f9541e84
PE
13640 * xdisp.c (vmessage): Mark as a printf-like function.
13641
13841b55
PE
13642 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13643
c136c10f
PE
13644 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13645
5e2d4a30
PE
13646 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13647 printf-like functions.
13648 (tiff_load): Add casts to remove these marks before passing them
13649 to system-supplied API.
13650
583f48b9
PE
13651 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13652
b25d760e
PE
13653 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13654 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13655 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13656 directly, rather than having caller test rule sign. This avoids
13657 some unnecessary tests.
13658 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13659 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13660 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13661
bc7b6697 13662 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13663 (xfont_open): Avoid unnecessary tests.
bc7b6697 13664
27ccc379
PE
13665 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13666
dcd5c89a
PE
13667 * composite.h, composite.c (composition_gstring_put_cache):
13668 Use EMACS_INT, not int, for length.
13669
b13a45c6
PE
13670 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13671 breaking out part of COMPOSITION_DECODE_RULE.
13672 (COMPOSITION_DECODE_RULE): Use it.
13673 * composite.c (get_composition_id): Remove unused local vars,
13674 by using the new macro.
13675
1e792e4d
PE
13676 * textprop.c (set_text_properties_1): Change while to do-while,
13677 since the condition is always true at first.
13678
dc6c6455 13679 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13680 (interval_deletion_adjustment): Return unsigned value.
13681 All uses changed.
dc6c6455 13682
aba7731a
PE
13683 * process.c (list_processes_1, create_pty, read_process_output):
13684 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13685 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13686 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13687 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13688 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13689
fdfc4bf3
PE
13690 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13691
fca8fe46 13692 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13693 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13694
06a0259a 13695 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13696 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13697 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13698
e7b9e80f
PE
13699 * print.c (print_error_message): Avoid int overflow.
13700
56201685
PE
13701 * font.c (font_list_entities): Redo for clarity,
13702 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13703
78834453 13704 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13705 (font_score): Avoid potential overflow in diff calculation.
78834453 13706
0bc0b309 13707 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13708 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13709
e610eaca
PE
13710 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13711
b895abce
PE
13712 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13713 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13714 can always succeed if overflow has undefined behavior.
13715
1f1d9321 13716 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13717 (wordify): Omit three unnecessary tests.
1f1d9321 13718
c59478bc
PE
13719 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13720 All callers changed. This avoids the need for an unused var.
13721
79b73827
PE
13722 * casefiddle.c (casify_region): Remove var that is set but not used.
13723
a4db5dfe
PE
13724 * dired.c (file_name_completion): Remove var that is set but not used.
13725
43aae36e
PE
13726 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13727
2a47c44d 13728 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13729 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13730
a37c69bf
PE
13731 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13732 Check for integer overflow on size calculations.
13733
328ab8e7
PE
13734 * buffer.c (Fprevious_overlay_change): Remove var that is set
13735 but not used.
13736
e5a2a5cb
PE
13737 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13738 Remove vars that are set but not used.
8d84a6eb 13739 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13740 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13741
a60e5f68
PE
13742 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13743
f661cb61 13744 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13745 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13746
f0397f5a
PE
13747 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13748 that are set but not used.
13749
8664db06 13750 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13751 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13752
6abdaa4a
PE
13753 * xselect.c (x_get_local_selection, x_handle_property_notify):
13754 Remove vars that are set but not used.
13755
0ce7538d 13756 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13757 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13758
9ae848fc
PE
13759 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13760 Remove var that is set but not used.
0b918413
PE
13761 (scroll_bar_windows_size): Now size_t, not int.
13762 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13763 Check for overflow.
9ae848fc 13764
a5a62657
PE
13765 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13766 (map_tty_color) [!defined MSDOS]: Likewise.
13767
5c5cdd39
PE
13768 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13769
66ebf983
PE
13770 * coding.c: Remove vars that are set but not used.
13771 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13772 All callers changed.
13773 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13774 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13775 (decode_coding_charset): Remove vars that are set but not used.
13776
1be4d761
PE
13777 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13778 that is set but not used.
13779
47553fa8
PE
13780 * print.c (print_object): Remove var that is set but not used.
13781
1f7196bf 13782 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13783 The gnulib version avoids calling malloc in the usual case,
13784 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13785 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13786 * filelock.c (current_lock_owner): Likewise.
13787 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13788 * sysdep.c: Include allocator.h, careadlinkat.h.
13789 (emacs_no_realloc_allocator): New static constant.
13790 (emacs_readlink): New function.
fdb61804
PE
13791 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13792 ../lib/careadlinkat.h.
d1fdcab7 13793
f84c17c7
SM
137942011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13795
13796 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13797 first non-nil return value).
13798
ef3862ad
JD
137992011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13800
13801 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13802 if not defined (Bug#8403).
13803
376a7006
JB
138042011-04-02 Juanma Barranquero <lekktu@gmail.com>
13805
13806 * xdisp.c (display_count_lines): Remove parameter `start',
13807 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13808 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13809 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13810 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13811 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13812 and thereabouts. All callers changed.
13813 (get_per_char_metric): Remove parameter `f', unused since
13814 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13815
6ca3801d
JM
138162011-04-02 Jim Meyering <meyering@redhat.com>
13817
13818 do not dereference NULL upon failed strdup
13819 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13820 (ns_get_family): Likewise.
13821
d8e2b5ba
JB
138222011-04-02 Juanma Barranquero <lekktu@gmail.com>
13823
13824 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13825
8c74fcbd
JD
138262011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13827
13828 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13829 later (Bug#8403).
13830
7200d79c
SM
138312011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13832
03408648 13833 Add lexical binding.
7200d79c 13834
03408648
SM
13835 * window.c (Ftemp_output_buffer_show): New fun.
13836 (Fsave_window_excursion):
13837 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13838
13839 * lread.c (lisp_file_lexically_bound_p): New function.
13840 (Fload): Bind Qlexical_binding.
13841 (readevalloop): Remove `evalfun' arg.
13842 Bind Qinternal_interpreter_environment.
13843 (Feval_buffer): Bind Qlexical_binding.
13844 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13845 Mark as dynamic.
13846 (syms_of_lread): Declare `lexical-binding'.
13847
13848 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13849
13850 * keyboard.c (eval_dyn): New fun.
13851 (menu_item_eval_property): Use it.
ca105506
SM
13852
13853 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13854
03408648
SM
13855 * fns.c (concat, mapcar1): Accept byte-code-functions.
13856
13857 * eval.c (Fsetq): Handle lexical vars.
13858 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13859 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13860 (FletX, Flet): Obey lexical binding.
13861 (Fcommandp): Handle closures.
13862 (Feval): New `lexical' arg.
13863 (eval_sub): New function extracted from Feval. Use it almost
13864 everywhere where Feval was used. Look up vars in lexical env.
13865 Handle closures.
13866 (Ffunctionp): Move from subr.el.
13867 (Ffuncall): Handle closures.
13868 (apply_lambda): Remove `eval_flags'.
13869 (funcall_lambda): Handle closures and new byte-code-functions.
13870 (Fspecial_variable_p): New function.
13871 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13872 but without exporting it to Lisp.
23aba0ea 13873
23aba0ea 13874 * doc.c (Fdocumentation, store_function_docstring):
03408648 13875 * data.c (Finteractive_form): Handle closures.
23aba0ea 13876
03408648
SM
13877 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13878 interactive spec.
ba83908c 13879
04f2d78b
CB
13880 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13881 New byte-codes.
03408648
SM
13882 (exec_byte_code): New function extracted from Fbyte_code to handle new
13883 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13884
03408648 13885 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13886
03408648 13887 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13888
e2abce01
JB
138892011-03-31 Juanma Barranquero <lekktu@gmail.com>
13890
13891 * xdisp.c (redisplay_internal): Fix prototype.
13892
63696a73 138932011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13894
63696a73 13895 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13896 (try_scrolling): Use it when setting scroll_limit.
13897 Limit scrolling to 100 screen lines.
63696a73
EZ
13898 (redisplay_window): Even when falling back on "recentering",
13899 position point in the window according to scroll-conservatively,
13900 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13901
13902 (try_scrolling): When point is above the window, allow searching
13903 as far as scroll_max, or one screenful, to compute vertical
13904 distance from PT to the scroll margin position. This prevents
13905 try_scrolling from unnecessarily failing when
13906 scroll-conservatively is set to a value slightly larger than the
13907 window height. Clean up the case of PT below the margin at bottom
13908 of window: scroll_max can no longer be INT_MAX. When aggressive
13909 scrolling is in use, don't let point enter the opposite scroll
13910 margin as result of the scroll.
13911 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13912 threshold of 100 lines for never-recentering scrolling.
13913
e4cc2dfc
JB
139142011-03-31 Juanma Barranquero <lekktu@gmail.com>
13915
13916 * dispextern.h (move_it_by_lines):
13917 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13918 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13919 (message_log_check_duplicate): Remove parameters `prev_bol' and
13920 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13921 (redisplay_internal): Remove parameter `preserve_echo_area',
13922 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13923
13924 * indent.c (Fvertical_motion):
13925 * window.c (window_scroll_pixel_based, Frecenter):
13926 Don't pass `need_y_p' to `move_it_by_lines'.
13927
1c470562
SM
139282011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13929
44f230aa
SM
13930 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13931 steal a few bits to be more compact.
13932 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13933 Remove unneeded casts.
13934
1c470562
SM
13935 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13936
888adce9
ZK
139372011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13938
13939 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13940 binding" message (bug#7967).
13941
f838ed7b
PE
139422011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13943
77861b95
PE
13944 Fix more problems found by GCC 4.6.0's static checks.
13945
de6dbc14
PE
13946 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13947 Remove unused local var.
13948
f838ed7b
PE
13949 * editfns.c (Fmessage_box): Remove unused local var.
13950
792c7b2b
PE
13951 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13952 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13953 Omit unused local vars.
c499e557 13954 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13955 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13956 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13957 Omit unused local var.
13958
ba0165e1
PE
13959 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13960 Don't assume string length fits in int.
32ad8845 13961 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13962 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13963
3c59b4c9
PE
13964 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13965 instead of alloca (Bug#8344).
13966
a3eed478 13967 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13968 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13969
eb4d412d
PE
13970 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13971
1658b401
PE
13972 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13973 concerns.
13974
13975 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13976
13977 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13978
9a2c6e05
PE
13979 * keyboard.c (syms_of_keyboard): Use the same style as later
13980 in this function when indexing through an array. This also
13981 works around GCC bug 48267.
13982
03d0a109
PE
13983 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13984
44f730c8
PE
13985 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13986
fe75f926
PE
13987 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13988 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13989
ffa8c828
PE
13990 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13991 This avoids undefined behavior on integer overflow, and is a bit
13992 more convenient anyway since it is compared to a size_t variable.
13993
c5101a77
PE
13994 Variadic C functions now count arguments with size_t, not int.
13995 This avoids an unnecessary limitation on 64-bit machines, which
13996 caused (substring ...) to crash on large vectors (Bug#8344).
13997 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13998 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13999 All variadic functions and their callers changed accordingly.
c5101a77
PE
14000 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14001 * data.c (arith_driver, float_arith_driver): Likewise.
14002 * editfns.c (general_insert_function): Likewise.
14003 * eval.c (struct backtrace.nargs, interactive_p)
14004 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14005 (funcall_lambda, mark_backtrace): Likewise.
14006 * fns.c (concat): Likewise.
14007 * frame.c (x_set_frame_parameters): Likewise.
14008 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14009 0 if not found, not -1. All callers changed.
14010
dd3f25f7
PE
14011 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14012 (stack_copy_size): Now size_t, not int.
14013 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14014
461c2ab9
JB
140152011-03-28 Juanma Barranquero <lekktu@gmail.com>
14016
14017 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14018 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14019 All callers changed.
14020
14021 * lisp.h (multibyte_char_to_unibyte):
14022 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14023 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14024 * character.h (CHAR_TO_BYTE8):
14025 * cmds.c (internal_self_insert):
14026 * editfns.c (general_insert_function):
14027 * keymap.c (push_key_description):
14028 * search.c (Freplace_match):
14029 * xdisp.c (message_dolog, set_message_1): All callers changed.
14030
f6d62986
SM
140312011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14032
14033 * keyboard.c (safe_run_hook_funcall): New function.
14034 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14035 don't set the hook to nil, but remove the offending function instead.
14036 (Qcommand_hook_internal): Remove, unused.
14037 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14038 Vcommand_hook_internal.
14039
14040 * eval.c (enum run_hooks_condition): Remove.
14041 (funcall_nil, funcall_not): New functions.
14042 (run_hook_with_args): Call each function through a `funcall' argument.
14043 Remove `cond' argument, now redundant.
14044 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14045 (Frun_hook_with_args_until_failure): Adjust accordingly.
14046 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14047
1db5b1ad
JB
140482011-03-28 Juanma Barranquero <lekktu@gmail.com>
14049
14050 * dispextern.h (string_buffer_position): Remove declaration.
14051
14052 * print.c (strout): Remove parameter `multibyte', unused since
14053 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14054
14055 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14056 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14057 All callers changed.
14058
14059 * w32.c (_wsa_errlist): Use braces for struct initializers.
14060
14061 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14062 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14063 All callers changed.
14064 (string_buffer_position): Likewise. Also, make static (it's never
14065 used outside xdisp.c).
14066 (cursor_row_p): Remove parameter `w', unused since
14067 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14068 (decode_mode_spec): Remove parameter `precision', introduced during
14069 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14070 All callers changed.
14071
5ffb62aa
JD
140722011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14073
14074 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14075
461c2ab9 140762011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14077
14078 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14079 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14080 (ns_update_auto_hide_menu_bar): New functions.
14081 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14082 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14083 ns_constrain_all_frames.
14084 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14085 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14086
5c380ffb
JD
140872011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14088
14089 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14090
9af30bdf
GM
140912011-03-27 Glenn Morris <rgm@gnu.org>
14092
14093 * syssignal.h: Replace RETSIGTYPE with void.
14094 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14095 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14096 Replace SIGTYPE with void everywhere.
14097 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14098 * s/template.h (SIGTYPE): Remove commented out definition.
14099
e2abce01
JB
141002011-03-26 Eli Zaretskii <eliz@gnu.org>
14101
14102 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14103 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14104
f868cd8a
JB
141052011-03-26 Juanma Barranquero <lekktu@gmail.com>
14106
59eb0929
JB
14107 * w32.c (read_unc_volume): Use parameter `henum', instead of
14108 global variable `wget_enum_handle'.
14109
14110 * keymap.c (describe_vector): Remove parameters `indices' and
14111 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14112 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14113
f868cd8a
JB
14114 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14115
14116 * keyboard.c (timer_check): Remove parameter `do_it_now',
14117 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14118 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14119 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14120
14121 * keyboard.c (read_char):
14122 * w32menu.c (w32_menu_display_help):
14123 * xmenu.c (show_help_event, menu_help_callback):
14124 Adjust calls to `show_help_echo'.
14125
14126 * gtkutil.c (xg_maybe_add_timer):
14127 * keyboard.c (readable_events):
14128 * process.c (wait_reading_process_output):
14129 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14130
14131 * insdel.c (adjust_markers_gap_motion):
14132 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14133 (gap_left, gap_right): Don't call it.
14134
2ecf6fdb
CY
141352011-03-25 Chong Yidong <cyd@stupidchicken.com>
14136
14137 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14138 incurred during fontification.
14139
6b1f9ba4
JB
141402011-03-25 Juanma Barranquero <lekktu@gmail.com>
14141
14142 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14143 (DEFVAR_PER_BUFFER): Don't pass it.
14144
14145 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14146 (scrolling_window): Don't pass it.
14147
0f4a96b5
JB
141482011-03-25 Juanma Barranquero <lekktu@gmail.com>
14149
14150 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14151
14152 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14153 and `suffix'.
14154 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14155 of variables specific to SELinux and computation of `encoded_absname'.
14156
14157 * image.c (XPutPixel): Remove unused variable `height'.
14158
14159 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14160
14161 * unexw32.c (get_section_info): Remove unused variable `section'.
14162
14163 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14164 (system_process_attributes): Remove unused variable `sess'.
14165 (sys_read): Remove unused variable `err'.
14166
14167 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14168 (w32_wnd_proc): Remove unused variable `isdead'.
14169 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14170 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14171 (x_create_tip_frame): Remove unused variable `tem'.
14172
14173 * w32inevt.c (w32_console_read_socket):
14174 Remove unused variable `no_events'.
14175
14176 * w32term.c (x_draw_composite_glyph_string_foreground):
14177 Remove unused variable `width'.
14178
1149507c
JB
141792011-03-24 Juanma Barranquero <lekktu@gmail.com>
14180
14181 * w32term.c (x_set_glyph_string_clipping):
14182 Don't pass uninitialized region to CombineRgn.
14183
9c88f339
JB
141842011-03-23 Juanma Barranquero <lekktu@gmail.com>
14185
14186 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14187 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14188 (Fx_close_connection): Remove unused variable `i'.
14189
14190 * w32font.c (w32font_draw): Return number of glyphs.
14191 (w32font_open_internal): Remove unused variable `i'.
14192 (w32font_driver): Add missing initializer.
14193
14194 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14195 (fill_in_menu): Remove unused variable `items_added'.
14196
14197 * w32term.c (last_mouse_press_frame): Remove static global variable.
14198 (w32_clip_to_row): Remove unused variable `f'.
14199 (x_delete_terminal): Remove unused variable `i'.
14200
14201 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14202 (NOTHING): Remove unused static global variable.
14203 (uniscribe_check_otf): Remove unused variable `table'.
14204 (uniscribe_font_driver): Add missing initializers.
14205
dee091a3
JD
142062011-03-23 Julien Danjou <julien@danjou.info>
14207
14208 * term.c (Fsuspend_tty, Fresume_tty):
14209 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14210 * window.c (temp_output_buffer_show):
14211 * insdel.c (signal_before_change):
14212 * frame.c (Fhandle_switch_frame):
14213 * fileio.c (Fdo_auto_save):
14214 * emacs.c (Fkill_emacs):
14215 * editfns.c (save_excursion_restore):
14216 * cmds.c (internal_self_insert):
14217 * callint.c (Fcall_interactively):
14218 * buffer.c (Fkill_all_local_variables):
14219 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14220 Use Frun_hooks.
0f4a96b5 14221 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14222 unconditionally since it does the check itself.
dee091a3 14223
2c520ab5 142242011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14225
c9c49752
PE
14226 Fix more problems found by GCC 4.5.2's static checks.
14227
8abc3f12
PE
14228 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14229 the first time through the loop, since we know p0 < p1 then.
14230 This also avoids a gcc -Wstrict-overflow warning.
14231
a2d26660
PE
14232 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14233 leading to a memory leak, possible in functions like
14234 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14235 of objects (Bug#8318).
a2d26660 14236
916c72e9
PE
14237 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14238 that could (at least in theory) be that large.
14239
19ab8a18
PE
14240 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14241 This is less likely to overflow, and avoids undefined behavior if
14242 overflow does occur. All callers changed. Use strtoul to scan
14243 for the unsigned long integer.
b7cbbd6f
PE
14244 (pint2hrstr): Simplify and tune code slightly.
14245 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14246
f0641eff
PE
14247 * scroll.c (do_scrolling): Work around GCC bug 48228.
14248 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14249
7f650bb9
PE
14250 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14251 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14252 (validate_x_resource_name): Simplify count usage.
14253 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14254
37dd57d1
PE
14255 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14256 fail (Bug#8306).
81e56e61 14257
699979fc 14258 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14259
401bf9b4
PE
14260 * process.c (Fmake_network_process): Use socklen_t, not int,
14261 where POSIX says socklen_t is required in portable programs.
14262 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14263 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14264 (Fmake_network_process, server_accept_connection):
14265 (wait_reading_process_output, read_process_output):
14266 Likewise.
14267
b93aacde
PE
14268 * process.c: Rename or move locals to avoid shadowing.
14269 (list_processes_1, Fmake_network_process):
14270 (read_process_output_error_handler, exec_sentinel_error_handler):
14271 Rename or move locals.
4dc343ee 14272 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14273 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14274 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14275 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14276 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14277
af8a867c 14278 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14279 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14280 Include tparam.h instead, since it declares them.
af8a867c
PE
14281 * cm.h (PC): Remove extern decl; tparam.h now does this.
14282 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14283 * terminfo.c: Include tparam.h, to check interfaces.
14284 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14285 (tparam): Adjust signature to match interface in tparam.h;
14286 this removes some undefined behavior. Check that outstring and len
14287 are zero, which they always are with Emacs.
14288 * tparam.h (PC, BC, UP): New extern decls.
14289
0248044d 14290 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14291 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14292
8ff096c1 14293 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14294 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14295 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14296 (ftfont_list): Remove unused local.
49eaafba
PE
14297 (get_adstyle_property, ftfont_pattern_entity):
14298 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14299 Rename locals to avoid shadowing.
8ff096c1 14300
e2be39f6
PE
14301 * xfont.c (xfont_list_family): Mark var as initialized.
14302
c9735e30
PE
14303 * xml.c (make_dom): Now static.
14304
8f5201ae
PE
14305 * composite.c (composition_compute_stop_pos): Rename local to
14306 avoid shadowing.
b246f932
PE
14307 (composition_reseat_it): Remove unused locals.
14308 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14309 (composition_update_it): Mark var as initialized.
11b61122
PE
14310 (find_automatic_composition): Mark vars as initialized,
14311 with a FIXME (Bug#8290).
8f5201ae 14312
760fbc2c
PE
14313 character.h: Rename locals to avoid shadowing.
14314 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14315 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14316 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14317 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14318 to avoid shadowing.
14319
ff08eb85
PE
14320 * textprop.c (property_change_between_p): Remove; unused.
14321
fc7bf025
PE
14322 * intervals.c (interval_start_pos): Now static.
14323
235d7abc
PE
14324 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14325
44f230aa
SM
14326 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14327 Rename locals to avoid shadowing.
3e7d6594 14328
50060332
PE
14329 * sound.c (wav_play, au_play, Fplay_sound_internal):
14330 Fix pointer signedness.
d01f234b 14331 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14332 (wav_play): Initialize a variable to 0, to prevent undefined
14333 behavior (Bug#8278).
50060332 14334
c4fc4e30
PE
14335 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14336
918436ed
PE
14337 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14338
c939f91b
PE
14339 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14340 clobbering (Bug#8298).
b9c7f648
PE
14341 * sysdep.c (sys_subshell): Likewise.
14342 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14343
6bd8c144
PE
14344 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14345 This should get cleaned up, so that child_setup has the
14346 same signature on all platforms.
14347
7710357c 14348 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14349 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14350
c59da222
CY
143512011-03-22 Chong Yidong <cyd@stupidchicken.com>
14352
14353 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14354 not to be necessary, and produces flickering.
14355
66b87493
GM
143562011-03-20 Glenn Morris <rgm@gnu.org>
14357
14358 * config.in: Remove file.
14359
45b6f6d5
JB
143602011-03-20 Juanma Barranquero <lekktu@gmail.com>
14361
14362 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14363 are now in src/globals.h.
14364 (syms_of_minibuf): Remove spurious & from previous change.
14365
cd394be1 143662011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14367
14368 * minibuf.c (completing-read-function): New variable.
14369 (completing-read-default): Rename from completing-read.
14370 (completing-read): Call completing-read-function.
14371
b14e3e21
CY
143722011-03-19 Juanma Barranquero <lekktu@gmail.com>
14373
14374 * xfaces.c (Fx_load_color_file):
14375 Read color file from absolute filename (bug#8250).
14376
f2b726e6
JB
143772011-03-19 Juanma Barranquero <lekktu@gmail.com>
14378
14379 * makefile.w32-in: Update dependencies.
14380
09f6ff02
EZ
143812011-03-17 Eli Zaretskii <eliz@gnu.org>
14382
14383 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14384
29a6015a
PE
143852011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14386
a3a6c54e
PE
14387 Fix more problems found by GCC 4.5.2's static checks.
14388
b766f867
PE
14389 * process.c (make_serial_process_unwind, send_process_trap):
14390 (sigchld_handler): Now static.
14391
be02381c
PE
14392 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14393 That way, the code declares only the vars that it needs.
14394 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14395 * s/cygwin.h (PTY_ITERATION): Likewise.
14396 * s/darwin.h (PTY_ITERATION): Likewise.
14397 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14398
57048744
PE
14399 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14400 * process.c (allocate_pty): Don't declare stb unless it's needed.
14401
7914961c 14402 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14403 (CONSTANTLIM): Remove; unused.
14404 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14405 Define only if needed.
7914961c 14406
b3967b18
PE
14407 * unexelf.c (unexec): Name an expression,
14408 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14409 Use a different way to cause a compilation error if anyone uses
14410 n rather than nn, a way that does not involve shadowing.
73366a00 14411 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14412
29a6015a
PE
14413 * deps.mk (unexalpha.o): Remove; unused.
14414
43cfc33e 14415 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14416 * unexec.h: New file.
ce701a33
PE
14417 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14418 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14419 Depend on unexec.h.
14420 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14421 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14422 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14423 Change as necessary to match prototype in unexec.h.
ce701a33 14424
01f44d5a
PE
14425 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14426 shadowing.
4f63c6bb 14427 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14428
a6670b0b
PE
14429 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14430 Rename locals to avoid shadowing.
14431
cef2010d 14432 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14433 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14434
d4d7173a
PE
14435 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14436
f08b802a
PE
14437 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14438 warning when compiling print.c.
14439
3ddb0639
PE
14440 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14441 instead of using an uninitialized var.
5ad03b97 14442 (font_sort_entities): Mark var as initialized.
3ddb0639 14443
170a2692
PE
14444 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14445
e663c700
PE
14446 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14447 pointers to constants.
89bc529a 14448 (font_parse_fcname): Remove unused vars.
7b81e2d0 14449 (font_delete_unmatched): Now static.
ea838e10 14450 (font_get_spec): Remove; unused.
13a547c6
PE
14451 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14452 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14453 Rename or move locals to avoid shadowing.
e663c700 14454
2a80c887 14455 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14456 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14457
1384fa33 14458 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14459 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14460
8b2c52e9
PE
14461 * alloc.c (mark_backtrace): Move decl from here ...
14462 * lisp.h: ... to here, so that it can be checked.
14463
475545b5 14464 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14465 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14466 (lisp_indirect_variable): Name an expression,
14467 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14468 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14469
b1349114 14470 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14471 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14472 Use const pointer when appropriate.
b1349114 14473
a2928364
PE
14474 * lisp.h (get_system_name, get_operating_system_release):
14475 Move decls here, to check interfaces.
14476 * process.c (get_operating_system_release): Move decl to lisp.h.
14477 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14478 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14479 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14480 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14481 (Fformat_time_string, Fencode_time, Finsert_char):
14482 (Ftranslate_region_internal, Fformat):
14483 Rename or remove local vars to avoid shadowing.
9710023e 14484 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14485
a415e694
PE
14486 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14487 avoid shadowing.
14488
8ef4622d
PE
14489 * lisp.h (eassert): Check that the argument compiles, even if
14490 ENABLE_CHECKING is not defined.
14491
946f9a5b
PE
14492 * data.c (Findirect_variable): Name an expression, to avoid
14493 gcc -Wbad-function-cast warning.
112396d6 14494 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14495 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14496 (Fmake_variable_buffer_local, Fmake_local_variable):
14497 Mark variables as initialized.
52746918 14498 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14499
e5aab7e7 14500 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14501 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14502 Rename locals to avoid shadowing.
dff45157
PE
14503 (mark_stack): Move local variables into the #ifdef region where
14504 they're used.
7bc26fdb
PE
14505 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14506 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14507 needed otherwise.
14508 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14509 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14510 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14511
e5aab7e7
PE
14512 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14513 avoids undefined behavior in theory.
14514
4da60324
PE
14515 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14516
88043301
PE
14517 Use functions, not macros, for up- and down-casing (Bug#8254).
14518 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14519 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14520 to use the following functions instead of these macros.
14521 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14522 EMACS_INT, since callers assume the returned value fits in int.
14523 (upcase1): Likewise, for UPCASE_TABLE.
14524 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14525 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14526 the race-condition problem in the old DOWNCASE.
88043301 14527
19ed5445
PE
14528 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14529 Rename locals to avoid shadowing.
14530 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14531 (regex_compile, re_search_2, re_match_2_internal):
14532 Remove unused local vars.
952db0d7
PE
14533 (FREE_VAR): Rewrite so as not to use empty "else",
14534 which gcc can warn about.
da053e48 14535 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14536 (RETALLOC_IF): Define only if needed.
14537 (WORDCHAR_P): Likewise. This one is never needed, but is used
14538 only in a comment talking about a compiler bug, so put inside
14539 the #if 0 of that comment.
14540 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14541 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14542 Remove; unused.
19ed5445 14543
1f3561e4 14544 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14545 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14546 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14547
ded6f8f7
PE
14548 * search.c (simple_search): Remove unused var.
14549
dbd37a95
PE
14550 * dired.c (compile_pattern): Move decl from here ...
14551 * lisp.h: ... to here, so that it can be checked.
14552 (struct re_registers): New forward decl.
14553
7e47afad
PE
14554 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14555
85f24f61
PE
14556 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14557 All uses changed.
14558 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14559 Rename locals to avoid shadowing.
5671df8f 14560 (Fvertical_motion): Mark locals as initialized.
85f24f61 14561
181aa2be 14562 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14563 (casify_region): Mark local as initialized.
181aa2be 14564
930d429c
PE
14565 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14566
7082eac6
PE
14567 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14568 New macros, so that the caller can use some names other than
14569 gcpro1, gcpro2, etc.
14570 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14571 of the new macros.
14572 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14573 argument, for consistency with GCPRO2_VAR, etc: it is now the
14574 prefix of the variable, not the variable itself. All uses
14575 changed.
38b2c076
PE
14576 * dired.c (directory_files_internal, file_name_completion):
14577 Rename locals to avoid shadowing.
14578
15206ed9
PE
14579 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14580 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14581 dired.c's scmp function, had undefined behavior.
14582 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14583 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14584 * buffer.h: ... to here, because these macros use current_buffer,
14585 and the new implementation with inline functions needs to have
14586 current_buffer in scope now, rather than later when the macros
14587 are used.
14588 (downcase, upcase1): New static inline functions.
14589 (DOWNCASE, UPCASE1): Reimplement using these functions.
14590 This avoids undefined behavior in expressions like
14591 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14592 from race conditions in accessing the global variables
14593 case_temp1 and case_temp2.
14594 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14595 * lisp.h (case_temp1, case_temp2): Remove their decls.
14596 * character.h (ASCII_CHAR_P): Move from here ...
14597 * lisp.h: ... to here, so that the inline functions mentioned
14598 above can use them.
14599
4a6bea26
PE
14600 * dired.c (directory_files_internal_unwind): Now static.
14601
f14b7e14
PE
14602 * fileio.c (file_name_as_directory, directory_file_name):
14603 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14604 Now static.
2893f146
PE
14605 (file_name_as_directory): Use const pointers when appropriate.
14606 (Fexpand_file_name): Likewise. In particular, newdir might
14607 point at constant storage, so make it a const pointer.
fd4ead52 14608 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14609 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14610 signedness issues.
f839df0c
PE
14611 (Fset_file_times, Finsert_file_contents, auto_save_error):
14612 Rename locals to avoid shadowing.
f14b7e14 14613
5716756e 14614 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14615 (Ftry_completion, Fall_completions): Rename or remove locals
14616 to avoid shadowing.
5716756e 14617
b4c3046a
PE
14618 * marker.c (bytepos_to_charpos): Remove; unused.
14619
b45db522
PE
14620 * lisp.h (verify_bytepos, count_markers): New decls,
14621 so that gcc does not warn that these functions aren't declared.
14622
85876d07
PE
14623 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14624 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14625 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14626 (copy_text): Remove unused local var.
85876d07 14627
03d78a21 14628 * filelock.c (within_one_second): Now static.
b3dd38ab 14629 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14630
5df8f01b
PE
14631 * buffer.c (fix_overlays_before): Mark locals as initialized.
14632 (fix_start_end_in_overlays): Likewise. This function should be
14633 simplified by using pointers-to-pointers, but that's a different
14634 matter.
b1d876f1 14635 (switch_to_buffer_1): Now static.
8f54f30a
PE
14636 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14637 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14638
a70072c9 14639 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14640 Fix pointer signedness issue.
edced198
PE
14641 (sys_subshell): Mark local as volatile if checking for lint,
14642 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14643 (MAXPATHLEN): Define only if needed.
a70072c9 14644
a0977c44
PE
14645 * process.c (serial_open, serial_configure): Move decls from here ...
14646 * systty.h: ... to here, so that they can be checked.
14647
a884fdcc
PE
14648 * fns.c (get_random, seed_random): Move extern decls from here ...
14649 * lisp.h: ... to here, so that they can be checked.
14650
604efe86 14651 * sysdep.c (reset_io): Now static.
b8950c94 14652 (wait_for_termination_signal): Remove; unused.
604efe86 14653
38fc62d9
PE
14654 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14655 (copy_keymap_item, append_key, push_text_char_description):
14656 Now static.
1004a21a 14657 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14658 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14659 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14660 (describe_map_tree):
14661 Rename locals to avoid shadowing.
38fc62d9 14662
2f2650da
PE
14663 * keyboard.c: Declare functions static if they are not used elsewhere.
14664 (echo_char, echo_dash, cmd_error, top_level_2):
14665 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14666 (read_char, kbd_buffer_get_event, make_lispy_position):
14667 (make_lispy_event, make_lispy_movement, apply_modifiers):
14668 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14669 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14670 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14671 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14672 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14673
a053e86c 14674 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14675 (mark_kboards): Move decl here ...
14676 * alloc.c (mark_kboards): ... from here.
a053e86c 14677
4752793e
PE
14678 * lisp.h (force_auto_save_soon): New decl.
14679
74f10ca7 14680 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14681 (DEFINE_DUMMY_FUNCTION): New macro.
14682 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14683 Use it.
c03cd23f
PE
14684 (main): Add casts to avoid warnings
14685 if GCC considers string literals to be constants.
74f10ca7 14686
022e70d4
PE
14687 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14688
59d6fe83
PE
14689 * dbusbind.c: Pointer signedness fixes.
14690 (xd_signature, xd_append_arg, xd_initialize):
14691 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14692 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14693 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14694 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14695
78320123
PE
14696 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14697 if GCC considers string literals to be constants.
49cebcca 14698 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14699
35ac2a97
SM
147002011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14701
fb103ca9
SM
14702 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14703 (print_preprocess, print_object): New macro to fix last change.
14704
35ac2a97
SM
14705 * print.c (print_preprocess): Don't forget font objects.
14706
62973b41
JB
147072011-03-16 Juanma Barranquero <lekktu@gmail.com>
14708
14709 * emacs.c (USAGE3): Doc fixes.
14710
0e48bb22
AS
147112011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14712
14713 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14714 structure.
14715
7684e57b
JB
147162011-03-14 Juanma Barranquero <lekktu@gmail.com>
14717
14718 * lisp.h (VWindow_system, Qfile_name_history):
14719 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14720 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14721 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14722
14723 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14724 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14725
14726 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14727 * w32console.c (detect_input_pending, read_input_pending)
14728 (encode_terminal_code):
14729 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14730 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14731 (w32_system_caret_y, Qfile_name_history):
14732 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14733 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14734 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14735 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14736 * w32proc.c (Qlocal, report_file_error):
14737 * w32term.c (Vwindow_system, updating_frame):
14738 * w32uniscribe.c (initialized, uniscribe_font_driver):
14739 Remove unneeded extern declarations.
14740
2aa46d6c
CY
147412011-03-14 Chong Yidong <cyd@stupidchicken.com>
14742
c96bbc66 14743 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14744
cffc6f3b
CY
147452011-03-13 Chong Yidong <cyd@stupidchicken.com>
14746
14747 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14748 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14749 These macros can no longer be used for assignment.
14750
44f230aa
SM
14751 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14752 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14753 (record_buffer_markers, fetch_buffer_markers): New functions for
14754 recording and fetching special buffer markers.
14755 (set_buffer_internal_1, set_buffer_temp): Use them.
14756
14757 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14758
14759 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14760
14761 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14762 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14763
14764 * xdisp.c (hscroll_window_tree):
14765 (reconsider_clip_changes): Use PT instead of BUF_PT.
14766
d251f04b
EZ
147672011-03-13 Eli Zaretskii <eliz@gnu.org>
14768
14769 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14770 $(EMACS_ROOT)/lib/intprops.h.
14771
f0c77cd1
PE
147722011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14773
3eca4629
PE
14774 Fix more problems found by GCC 4.5.2's static checks.
14775
7c86ee98
PE
14776 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14777 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14778 (xg_free_frame_widgets): Make it clear that a local variable is
14779 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14780 (gdk_window_get_screen): Make it clear that this macro is needed
14781 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14782 (int_gtk_range_get_value): New function, which avoids a diagnostic
14783 from gcc -Wbad-function-cast.
14784 (xg_set_toolkit_scroll_bar_thumb): Use it.
14785 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14786 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14787 (get_utf8_string, xg_get_file_with_chooser):
14788 Rename locals to avoid shadowing.
14789 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14790
41729b81
PE
14791 * xgselect.c (xg_select): Remove unused var.
14792
f0c77cd1
PE
14793 * image.c (four_corners_best): Mark locals as initialized.
14794 (gif_load): Initialize transparent_p to zero (Bug#8238).
14795 Mark another local as initialized.
ec6cf4c6 14796 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14797
ce0ad53d 14798 * image.c (clear_image_cache): Now static.
d5d5a617 14799 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14800 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14801 (x_edge_detection): Remove unnecessary cast that
14802 gcc -Wbad-function-cast diagnoses.
2037898d 14803 (gif_load): Fix pointer signedness.
6ae141d6
PE
14804 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14805 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14806
33383987 148072011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14808
d32df629
PE
14809 Improve quality of tests for time stamp overflow.
14810 For example, without this patch (encode-time 0 0 0 1 1
14811 1152921504606846976) returns the obviously-bogus value (-948597
14812 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14813 reports time overflow. See
14814 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14815 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14816 * editfns.c: Include limits.h and intprops.h.
14817 (TIME_T_MIN, TIME_T_MAX): New macros.
14818 (time_overflow): Move earlier, to before first use.
14819 (hi_time, lo_time): New functions, for an accurate test for
14820 out-of-range times.
14821 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14822 (Fget_internal_run_time): Don't assume time_t fits in int.
14823 (make_time): Use list2 instead of Fcons twice.
14824 (Fdecode_time): More accurate test for out-of-range times.
14825 (check_tm_member): New function.
14826 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14827 (lisp_time_argument): Don't rely on undefined left-shift and
14828 right-shift behavior when checking for time stamp overflow.
8be6f318 14829
fe31d94c
PE
14830 * editfns.c (time_overflow): New function, refactoring common code.
14831 (Fformat_time_string, Fdecode_time, Fencode_time):
14832 (Fcurrent_time_string): Use it.
14833
8be6f318
PE
14834 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14835 * dired.c (make_time): Move to ...
14836 * editfns.c (make_time): ... here.
14837 * systime.h: Note the move.
14838
09d9db2c 148392011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14840
126bc0dc
YM
14841 * fringe.c (update_window_fringes): Remove unused variables.
14842
c47cbdfd
YM
14843 * unexmacosx.c (copy_data_segment): Also copy __got section.
14844 (Bug#8223)
14845
7ac80be9
EZ
148462011-03-12 Eli Zaretskii <eliz@gnu.org>
14847
c96bbc66 14848 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14849 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14850 Constify `char *' arguments and their references according to
14851 prototypes in tparam.h.
14852
ecb0f94d 14853 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14854
7ac80be9
EZ
14855 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14856 Adapt all references accordingly.
14857
14858 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14859
ef1fd07e
TT
148602011-03-11 Tom Tromey <tromey@redhat.com>
14861
14862 * buffer.c (syms_of_buffer): Remove obsolete comment.
14863
7ef4b50c
EZ
148642011-03-11 Eli Zaretskii <eliz@gnu.org>
14865
14866 * termhooks.h (encode_terminal_code): Declare prototype.
14867
14868 * msdos.c (encode_terminal_code): Don't declare prototype.
14869
14870 * term.c (encode_terminal_code): Now external again, used by
14871 w32console.c and msdos.c.
14872
44f230aa
SM
14873 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14874 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14875
4b1ec863 148762011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14877
1714f52b 14878 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14879
4b1ec863
PE
14880 * fringe.c (update_window_fringes): Mark locals as initialized
14881 (Bug#8227).
14882 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14883
524c7aa6
PE
14884 * alloc.c (mark_fringe_data): Move decl from here ...
14885 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14886 to check its interface.
14887 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14888
a5c0af81 14889 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14890 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14891 (fontset_font): Mark local as initialized.
a9a06e0b 14892 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14893
b4716021
PE
14894 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14895
811e9bac 14896 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14897 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14898 (x_own_selection, Fx_disown_selection_internal): Rename locals
14899 to avoid shadowing.
14900 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14901
7e3ab302
PE
14902 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14903 so that the caller can use some name other than gcpro1.
14904 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14905 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14906 (Fx_backspace_delete_keys_p):
14907 Use them to avoid shadowing, and rename vars to avoid shadowing.
14908 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14909 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14910 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14911 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14912 Remove unused locals.
7e3ab302
PE
14913 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14914 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14915 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14916 macros.
f78faa98 14917
e2b13473
PE
14918 * xterm.h (x_mouse_leave): New decl.
14919
77f23912
PE
14920 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14921 Remove unused functions.
cdf4ba58
PE
14922 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14923 (x_calc_absolute_position): Now static.
7411c686 14924 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14925 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14926 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14927 unless they are used.
38d0b34a
PE
14928 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14929 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14930 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14931 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14932 (x_error_catcher, x_connection_closed, x_error_handler):
14933 (x_error_quitter, xembed_send_message, x_iconify_frame):
14934 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14935 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14936 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14937
44f230aa
SM
14938 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14939 Rename or move locals to avoid shadowing.
6b463e58 14940 (tty_defined_color, merge_face_heights): Now static.
5967d051 14941 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14942 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14943 does not deduce is never used uninitialized.
73719eba
PE
14944 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14945 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14946
426994c3 14947 * terminal.c (store_terminal_param): Now static.
5489860b 14948
032f1620 14949 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14950 (set_frame_menubar): Remove unused local.
d4323972 14951 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14952 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14953 since they might point to immutable storage.
281585b0
PE
14954 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14955 since it's unused otherwise.
032f1620 14956
367c19e5 14957 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14958 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14959 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14960 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14961 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14962 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14963 does not deduce are never used uninitialized.
70739cbe 14964
07b48fa9
PE
14965 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14966
8868a238 14967 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14968 * window.c (window_loop, size_window):
14969 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14970
7e5cf297 14971 * window.c (display_buffer): Now static.
d6550a9f
PE
14972 (size_window): Mark variables that gcc -Wuninitialized
14973 does not deduce are never used uninitialized.
a586633d
PE
14974 * window.h (check_all_windows): New decl, to forestall
14975 gcc -Wmissing-prototypes diagnostic.
5b555da1 14976 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14977
f6095868
PE
14978 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14979 shadowing.
14980 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14981 Include <limits.h>.
14982 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14983 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14984 (load_charset_map): Mark variables that gcc -Wuninitialized
14985 does not deduce are never used uninitialized.
53df7c11 14986 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14987
f38b440c
PE
14988 * coding.c (coding_set_source, coding_set_destination):
14989 Use "else { /* comment */ }" rather than "else /* comment */;"
14990 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14991 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14992 a block, when the outer 'i' will do.
14993 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14994 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14995 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14996 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14997 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14998 Rename locals to avoid shadowing.
14999 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15000 * coding.c (emacs_mule_char, encode_invocation_designation):
15001 Now static, since they're not used elsewhere.
413bb2db 15002 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15003 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15004 (decode_coding_emacs_mule): Mark variables that gcc
15005 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15006 (detect_coding_iso_2022): Initialize a local variable that might
15007 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15008 this initialization is needed. (Bug#8211)
5f58e762
PE
15009 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15010 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15011 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15012 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15013 Remove unused macros.
f38b440c 15014
232b38b9 15015 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15016 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15017 * character.c (string_count_byte8): Likewise.
232b38b9 15018
fb90da1b
PE
15019 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15020 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15021
fb93dbc2
PE
15022 * chartab.c (copy_sub_char_table): Now static, since it's not used
15023 elsewhere.
5c156ace
PE
15024 (sub_char_table_ref_and_range, char_table_ref_and_range):
15025 Rename locals to avoid shadowing.
bbcd0949 15026 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15027
7d3b3862 15028 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15029 (BIDI_BOB): Remove unused macro.
7d3b3862 15030
6be7d3da
PE
15031 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15032 deduce are never used uninitialized.
c2ed9c8b 15033 * term.c (encode_terminal_code): Likewise.
6be7d3da 15034
75f8807f 15035 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15036
50938595
PE
15037 * tparam.h: New file.
15038 * term.c, tparam.h: Include it.
15039 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15040 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15041 Move these decls to tparam.h, and make them agree with what
15042 is actually in tparam.c. The previous trick of using incompatible
15043 decls in different modules does not conform to the C standard.
15044 All callers of tparam changed to use tparam's actual API.
15045 * tparam.c (tparam1, tparam, tgoto):
15046 Use const pointers where appropriate.
15047
fbceeba2
PE
15048 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15049 * cm.h (struct cm): Likewise.
15050 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15051 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15052 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15053 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15054 (turn_on_face, init_tty): Likewise.
15055 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15056
7f3f1250
PE
15057 * term.c (term_mouse_position): Rename local to avoid shadowing.
15058
e6ca6543
PE
15059 * alloc.c (mark_ttys): Move decl from here ...
15060 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15061
c40f8d15
AS
150622011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15063
15064 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15065
cfe0661d
JB
150662011-03-09 Juanma Barranquero <lekktu@gmail.com>
15067
15068 * search.c (compile_pattern_1): Remove argument regp, unused since
15069 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15070 (compile_pattern): Don't pass it.
15071
0afb4571
J
150722011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15073
15074 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15075 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15076 for ! HAVE_GTK3.
15077 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15078
15079 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15080
15081 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15082 gdk_window_get_screen, gdk_window_get_geometry,
15083 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15084 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15085 (xg_get_pixbuf_from_pixmap): New function.
15086 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15087 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15088 Call xg_get_pixbuf_from_pixmap instead of
15089 gdk_pixbuf_get_from_drawable.
15090 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15091 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15092 (xg_check_special_colors): Use GtkStyleContext and its functions
15093 for HAVE_GTK3.
15094 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15095 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15096 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15097 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15098 Call gtk_widget_get_preferred_size.
0afb4571
J
15099 (xg_frame_resized): gdk_window_get_geometry only takes 5
15100 parameters.
44f230aa
SM
15101 (xg_win_to_widget, xg_event_is_for_menubar):
15102 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15103 (xg_set_widget_bg): New function.
15104 (delete_cb): New function.
895009e1 15105 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15106 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15107 (xg_set_background_color): Call xg_set_widget_bg.
15108 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15109 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15110 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15111 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15112 if ! HAVE_GTK3.
15113 (update_frame_tool_bar): Call gtk_widget_hide.
15114 (xg_initialize): Use GDK_KEY_g.
15115
15116 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15117 if ! HAVE_GTK3
15118 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15119
15120 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15121 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15122 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15123
1c2cc4ef
JB
151242011-03-08 Juanma Barranquero <lekktu@gmail.com>
15125
15126 * w32xfns.c (select_palette): Check success of RealizePalette against
15127 GDI_ERROR, not zero.
15128
33383987 15129See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15130
15131;; Local Variables:
15132;; coding: utf-8
aac0c6e3
MR
15133;; End:
15134
2f097256 15135 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15136
15137 This file is part of GNU Emacs.
15138
15139 GNU Emacs is free software: you can redistribute it and/or modify
15140 it under the terms of the GNU General Public License as published by
15141 the Free Software Foundation, either version 3 of the License, or
15142 (at your option) any later version.
15143
15144 GNU Emacs is distributed in the hope that it will be useful,
15145 but WITHOUT ANY WARRANTY; without even the implied warranty of
15146 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15147 GNU General Public License for more details.
15148
15149 You should have received a copy of the GNU General Public License
15150 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.