GLYPH_CODE_FACE returns EMACS_INT, not int.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
9910e595
PE
3 GLYPH_CODE_FACE returns EMACS_INT, not int.
4 * dispextern.h (merge_faces):
5 * xfaces.c (merge_faces):
6 * xdisp.c (get_next_display_element):
7 (next_element_from_display_vector): Don't assume EMACS_INT fits in int.
8
2638320e
PE
9 * character.h (CHAR_VALID_P): Remove unused parameter.
10 * fontset.c, lisp.h, xdisp.c: All uses changed.
11
045eb8d9
PE
12 * editfns.c (Ftranslate_region_internal): Omit redundant test.
13
c1f134b5
PE
14 * fns.c (concat): Minor tuning based on overflow analysis.
15 This doesn't fix any bugs. Use int to hold character, instead
16 of constantly refetching from Emacs object. Use XFASTINT, not
17 XINT, for value known to be a character. Don't bother comparing
18 a single byte to 0400, as it's always less.
19
395fcb93 20 * floatfns.c (Fexpt):
327eeec8
PE
21 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
22
abbd3d23
PE
23 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
24 for characters.
25
684a03ef
PE
26 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
27
0fed43f3
PE
28 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
29 Without this fix, on a 64-bit host (aset S 0 4294967386) would
30 incorrectly succeed when S was a string, because 4294967386 was
31 truncated before it was used.
32
8fd02eb7
PE
33 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
34 Otherwise, an out-of-range integer could cause undefined behavior
35 on a 64-bit host.
36
f8c86b69
PE
37 * composite.c: Use int, not EMACS_INT, for characters.
38 (fill_gstring_body, composition_compute_stop_pos): Use int, not
39 EMACS_INT, for values that are known to be in character range.
40 This doesn't fix any bugs but is the usual style inside Emacs and
41 may generate better code on 32-bit machines.
42
34206dd2
PE
43 Make sure a 64-bit char is never passed to ENCODE_CHAR.
44 This is for reasons similar to the recent CHAR_STRING fix.
45 * charset.c (Fencode_char): Check that character arg is actually
46 a character. Pass an int to ENCODE_CHAR.
47 * charset.h (ENCODE_CHAR): Verify that the character argument is no
48 wider than 'int', as a compile-time check to prevent future regressions
49 in this area.
50
c5958d4c 51 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
52
53 Make sure a 64-bit char is never passed to CHAR_STRING.
54 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
55 by silently ignoring the top 32 bits, allowing some values
56 that were far too large to be valid characters.
57 * character.h: Include <verify.h>.
58 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
59 arguments are no wider than unsigned, as a compile-time check
60 to prevent future regressions in this area.
61 * data.c (Faset):
62 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char):
63 (Fsubst_char_in_region):
64 * fns.c (concat):
65 * xdisp.c (decode_mode_spec_coding):
66 Adjust to CHAR_STRING's new requirement.
67 * editfns.c (Finsert_char, Fsubst_char_in_region):
68 * fns.c (concat): Check that character args are actually
69 characters. Without this test, these functions did the wrong
70 thing with wildly out-of-range values on 64-bit hosts.
71
ea204efb
PE
722011-06-12 Paul Eggert <eggert@cs.ucla.edu>
73
d37ca623
PE
74 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
75 These casts should not be needed on 32-bit hosts, either.
76 * keyboard.c (read_char):
77 * lread.c (Fload): Remove casts to unsigned.
78
ea204efb
PE
79 * lisp.h (UNSIGNED_CMP): New macro.
80 This fixes comparison bugs on 64-bit hosts.
81 (ASCII_CHAR_P): Use it.
82 * casefiddle.c (casify_object):
83 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
84 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
85 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
86 * dispextern.h (FACE_FROM_ID):
87 * keyboard.c (read_char): Use UNSIGNED_CMP.
88
fc83f7d3 892011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 90
41cb286c
PE
91 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
92 not to EMACS_INT, to avoid GCC warning.
93
4a1b9832
PE
94 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
95
55daad71
PE
96 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
97 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
98 isn't needed on 32-bit machines.
8f95c75c 99
666398f3 100 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 101 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
102
103 * data.c (Qcompiled_function): Now static.
104
c6f072e7
PE
105 * window.c (window_body_lines): Now static.
106
20ce5912
PE
107 * image.c (gif_load): Rename local to avoid shadowing.
108
9c4c5f81
PE
109 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
110 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
111 * alloc.c (make_save_value): Integer argument is now of type
112 ptrdiff_t, not int.
113 (mark_object): Use ptrdiff_t, not int.
114 * lisp.h (pD): New macro.
115 * print.c (print_object): Use it.
116
c0c5c8ae
PE
117 * alloc.c: Use EMACS_INT, not int, to count objects.
118 (total_conses, total_markers, total_symbols, total_vector_size)
119 (total_free_conses, total_free_markers, total_free_symbols)
120 (total_free_floats, total_floats, total_free_intervals, total_intervals)
121 (total_strings, total_free_strings):
122 Now EMACS_INT, not int. All uses changed.
123 (Fgarbage_collect): Compute overall total using a double, so that
124 integer overflow is less likely to be a problem. Check for overflow
125 when converting back to an integer.
5a25e253
PE
126 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
127 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
128 These were 'int' variables that could overflow on 64-bit hosts;
129 they were never used, so remove them instead of repairing them.
211a0b2a 130 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
131 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
132 Previously, this ceilinged at INT_MAX, but that doesn't work on
133 64-bit machines.
e46bb31a 134 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 135
c78baabf 136 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 137 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
138 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
139 when a (possibly-narrower) signed value would do just as well.
140 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 141
c9d624c6
PE
142 * alloc.c: Catch some string size overflows that we were missing.
143 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
144 for convenience in STRING_BYTES_MAX.
145 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
146 The definition here is exact; the one in lisp.h was approximate.
147 (allocate_string_data): Check for string overflow. This catches
148 some instances we weren't catching before. Also, it catches
149 size_t overflow on (unusual) hosts where SIZE_MAX <= min
150 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
151 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 152
c9d624c6
PE
153 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
154 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
155 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
156
353032ce
PE
157 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
158
2bccce07
PE
159 * alloc.c (Fmake_string): Check for out-of-range init.
160
b50691aa
CY
1612011-06-11 Chong Yidong <cyd@stupidchicken.com>
162
163 * dispextern.h (struct image): Replace data member, whose int_val
164 and ptr_val fields were not used by anything, with a single
165 lisp_val object.
166
167 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
168 (gif_clear_image, gif_load, imagemagick_load_image)
169 (gs_clear_image, gs_load): Callers changed.
170
3f754b86
PE
1712011-06-10 Paul Eggert <eggert@cs.ucla.edu>
172
cca69397
PE
173 * buffer.h: Include <time.h>, for time_t.
174 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
175
109e28d0
PE
176 Fix minor problems found by static checking.
177
60737f02
PE
178 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
179
4b66faf3
PE
180 Make identifiers static if they are not used in other modules.
181 * data.c (Qcompiled_function, Qframe, Qvector):
182 * image.c (QimageMagick, Qsvg):
183 * minibuf.c (Qmetadata):
184 * window.c (resize_window_check, resize_root_window): Now static.
185 * window.h (resize_window_check, resize_root_window): Remove decls.
186
109e28d0
PE
187 * window.c (window_deletion_count, delete_deletable_window):
188 Remove; unused.
46a4ce9e
PE
189 (window_body_lines): Now static.
190 (Fdelete_other_windows_internal): Mark vars as initialized.
191 Make sure 'resize_failed' is initialized.
192 (run_window_configuration_change_hook): Rename local to avoid shadowing.
193 (resize_window_apply): Remove unused local.
194 * window.h (delete_deletable_window): Remove decl.
195
109e28d0 196 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
197 (imagemagick_load_image): Fix pointer signedness problem by changing
198 last arg from unsigned char * to char *. All uses changed.
199 Also, fix a local for similar reasons.
200 Remove unused locals. Remove locals to avoid shadowing.
201 (fn_rsvg_handle_free): Remove; unused.
202 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 203 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 204
3f754b86
PE
205 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
206
2547adb1
CY
2072011-06-10 Chong Yidong <cyd@stupidchicken.com>
208
209 * image.c (gif_load): Fix omitted cast error introduced by
210 2011-06-06 change.
211
2c8e37d4
MR
2122011-06-10 Martin Rudalics <rudalics@gmx.at>
213
214 * window.h (resize_proportionally, orig_total_lines)
215 (orig_top_line): Remove from window structure.
216 (set_window_height, set_window_width, change_window_heights)
217 (Fdelete_window): Remove prototypes.
218 (resize_frame_windows): Remove duplicate declaration.
219
440a42e3
EZ
2202011-06-10 Eli Zaretskii <eliz@gnu.org>
221
222 * window.h (resize_frame_windows, resize_window_check)
223 (delete_deletable_window, resize_root_window)
224 (resize_frame_windows): Declare prototypes.
225
226 * window.c (resize_window_apply): Make definition be "static" to
227 match the prototype.
228
562dd5e9
MR
2292011-06-10 Martin Rudalics <rudalics@gmx.at>
230
231 * window.c: Remove declarations of Qwindow_size_fixed,
232 window_min_size_1, window_min_size_2, window_min_size,
233 size_window, window_fixed_size_p, enlarge_window, delete_window.
234 Remove static from declaration of Qdelete_window, it's
235 temporarily needed by Fbury_buffer.
236 (replace_window): Don't assign orig_top_line and
237 orig_total_lines.
238 (Fdelete_window, delete_window): Remove. Window deletion is
239 handled by window.el.
240 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
241 Fdelete_window calls with calls to Qdelete_window.
242 (Fdelete_other_windows): Remove. Deleting other windows is
243 handled by window.el.
244 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
245 handled in window.el.
246 (window_min_size_2, window_min_size_1, window_min_size): Remove.
247 Window minimum sizes are handled in window.el.
248 (shrink_windows, size_window, set_window_height)
249 (set_window_width, change_window_heights, window_height)
250 (window_width, CURBEG, CURSIZE, enlarge_window)
251 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
252 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
253 handled in window.el.
254 (make_dummy_parent): Rename to make_parent_window and give it a
255 second argument horflag.
256 (make_window): Don't set resize_proportionally any more.
257 (Fsplit_window): Remove. Windows are split in window.el.
258 (save_restore_action, save_restore_orig_size)
259 (shrink_window_lowest_first, save_restore_orig_size): Remove.
260 Resize mini windows in window.el.
261 (grow_mini_window, shrink_mini_window): Implement by calling
262 Qresize_root_window_vertically, resize_window_check and
263 resize_window_apply.
264 (saved_window, Fset_window_configuration, save_window_save): Do
265 not handle orig_top_line, orig_total_lines, and
266 resize_proportionally.
267 (window_min_height, window_min_width): Move to window.el.
268 (keys_of_window): Move bindings for delete-other-windows,
269 split-window, delete-window and enlarge-window to window.el.
270
271 * buffer.c: Temporarily extern Qdelete_window.
272 (Fbury_buffer): Temporarily call Qdelete_window instead of
273 Fdelete_window (Fbury_buffer will move to window.el soon).
274
275 * frame.c (set_menu_bar_lines_1): Remove code handling
276 orig_top_line and orig_total_lines.
277
278 * dispnew.c (adjust_frame_glyphs_initially): Don't use
279 set_window_height but set heights directly.
280 (change_frame_size_1): Use resize_frame_windows.
281
282 * xdisp.c (init_xdisp): Don't use set_window_height but set
283 heights directly.
284
285 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
286 resize_frame_windows instead of change_window_heights and run
287 run_window_configuration_change_hook.
288
289 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
290 instead of change_window_heights and run
291 run_window_configuration_change_hook.
292
1a13852e
MR
2932011-06-09 Martin Rudalics <rudalics@gmx.at>
294
295 * window.c (replace_window): Rename second argument REPLACEMENT to
296 NEW. New third argument SETFLAG. Rewrite.
297 (delete_window, make_dummy_parent): Call replace_window with
298 third argument 1.
299 (window_list_1): Move down in code.
300 (run_window_configuration_change_hook): Move set_buffer part
301 before select_frame_norecord part in order to unwind correctly.
302 Rename count1 to count.
303 (recombine_windows, delete_deletable_window, resize_root_window)
304 (Fdelete_other_windows_internal)
305 (Frun_window_configuration_change_hook, make_parent_window)
306 (resize_window_check, resize_window_apply, Fresize_window_apply)
307 (resize_frame_windows, Fsplit_window_internal)
308 (Fdelete_window_internal, Fresize_mini_window_internal): New
309 functions.
310 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
311
f3d1777e
MR
3122011-06-08 Martin Rudalics <rudalics@gmx.at>
313
496e208e
MR
314 * window.h (window): Add some new members to window structure -
315 normal_lines, normal_cols, new_total, new_normal, clone_number,
316 splits, nest, prev_buffers, next_buffers.
317 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 318 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 319
f3d1777e
MR
320 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
321 Remove.
496e208e
MR
322 (make_dummy_parent): Set new members of windows structure.
323 (make_window): Move down in code. Handle new members of window
324 structure.
325 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
326 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
327 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
328 (Fset_window_prev_buffers, Fwindow_next_buffers)
329 (Fset_window_next_buffers, Fset_window_clone_number): New
330 functions.
331 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
332 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
333 Doc-string fixes.
334 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
335 Argument WINDOW can be now internal window too.
336 (Fwindow_use_time): Move up in code.
337 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
338 Rewrite doc-string.
339 (Fset_window_configuration, saved_window)
340 (Fcurrent_window_configuration, save_window_save): Handle new
341 members of window structure.
b9e809c2
MR
342 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
343 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
344 (syms_of_window): New Lisp objects Qrecord_window_buffer,
345 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
346 Qget_mru_window, Qresize_root_window,
347 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
348 Qauto_buffer_name; staticpro them.
f3d1777e 349
abde8f8c
MR
3502011-06-07 Martin Rudalics <rudalics@gmx.at>
351
352 * window.c (Fwindow_total_size, Fwindow_left_column)
353 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
354 (Fwindow_list_1): New functions.
355 (window_box_text_cols): Replace with window_body_cols.
356 (Fwindow_width, Fscroll_left, Fscroll_right): Use
357 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
358 (delete_window, Fset_window_configuration): Call
359 delete_all_subwindows with window as argument.
360 (delete_all_subwindows): Take a window as argument and not a
361 structure. Rewrite.
190b47e6
MR
362 (window_loop): Remove handling of GET_LRU_WINDOW and
363 GET_LARGEST_WINDOW.
364 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
365
366 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
367 window_box_text_cols. delete_all_subwindows now takes a
368 Lisp_Object as argument.
abde8f8c
MR
369
370 * indent.c (compute_motion, Fcompute_motion): Use
371 window_body_cols instead of window_box_text_cols.
372
fa8a67e6
MR
373 * frame.c (delete_frame): Call delete_all_subwindows with root
374 window as argument.
375
a54e3482
DC
3762011-06-07 Daniel Colascione <dan.colascione@gmail.com>
377
378 * fns.c (Fputhash): Document return value.
379
60002bf5
CY
3802011-06-06 Chong Yidong <cyd@stupidchicken.com>
381
382 * image.c (gif_load): Implement gif89a spec "no disposal" method.
383
0c671da6 3842011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 385
b862a52a 386 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 387
be44ca6c
PE
388 Check for overflow when converting integer to cons and back.
389 * charset.c (Fdefine_charset_internal, Fdecode_char):
390 Use cons_to_unsigned to catch overflow.
391 (Fencode_char): Use INTEGER_TO_CONS.
392 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
393 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
394 * data.c (long_to_cons, cons_to_long): Remove.
395 (cons_to_unsigned, cons_to_signed): New functions.
396 These signal an error for invalid or out-of-range values.
397 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
398 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
399 * font.c (Ffont_variation_glyphs):
400 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
401 * lisp.h: Include <intprops.h>.
402 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
403 (cons_to_signed, cons_to_unsigned): New decls.
404 (long_to_cons, cons_to_long): Remove decls.
405 * undo.c (record_first_change): Use INTEGER_TO_CONS.
406 (Fprimitive_undo): Use CONS_TO_INTEGER.
407 * xfns.c (Fx_window_property): Likewise.
408 * xselect.c: Include <limits.h>.
409 (x_own_selection, selection_data_to_lisp_data):
410 Use INTEGER_TO_CONS.
411 (x_handle_selection_request, x_handle_selection_clear)
412 (x_get_foreign_selection, Fx_disown_selection_internal)
413 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
414 (lisp_data_to_selection_data): Use cons_to_unsigned.
415 (x_fill_property_data): Use cons_to_signed.
416 Report values out of range.
417
d1f3d2af
PE
418 Check for buffer and string overflow more precisely.
419 * buffer.h (BUF_BYTES_MAX): New macro.
420 * lisp.h (STRING_BYTES_MAX): New macro.
421 * alloc.c (Fmake_string):
422 * character.c (string_escape_byte8):
423 * coding.c (coding_alloc_by_realloc):
424 * doprnt.c (doprnt):
425 * editfns.c (Fformat):
426 * eval.c (verror):
427 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
428 since they may not be the same number.
429 * editfns.c (Finsert_char):
430 * fileio.c (Finsert_file_contents):
431 Likewise for BUF_BYTES_MAX.
432
dd52fcea
PE
433 * image.c: Use ptrdiff_t, not int, for sizes.
434 (slurp_file): Switch from int to ptrdiff_t.
435 All uses changed.
436 (slurp_file): Check that file size fits in both size_t (for
437 malloc) and ptrdiff_t (for sanity and safety).
438
7f9bbdbb
PE
439 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
440 if b->modtime has its maximal value.
441
dfe18f82
PE
442 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
443
84acfcf0
PE
444 Don't assume time_t can fit into int.
445 * buffer.h (struct buffer.modtime): Now time_t, not int.
446 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
447 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
448
ccd9a01a
PE
449 Minor fixes for signed vs unsigned integers.
450 * character.h (MAYBE_UNIFY_CHAR):
451 * charset.c (maybe_unify_char):
452 * keyboard.c (read_char, reorder_modifiers):
453 XINT -> XFASTINT, since the integer must be nonnegative.
454 * ftfont.c (ftfont_spec_pattern):
455 * keymap.c (access_keymap, silly_event_symbol_error):
456 XUINT -> XFASTINT, since the integer must be nonnegative.
457 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
458 since it makes no difference and we prefer signed.
459 * keyboard.c (record_char): Use XUINT when all the neighbors do.
460 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
461 nonnegative.
462
d6d100dd
SM
4632011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
464
465 * window.h (Fwindow_frame): Declare.
466
2b6148e4
PE
4672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
468
469 * alloc.c: Simplify handling of large-request failures (Bug#8800).
470 (SPARE_MEMORY): Always define.
471 (LARGE_REQUEST): Remove.
472 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
473
f230ecc9
MR
4742011-06-06 Martin Rudalics <rudalics@gmx.at>
475
727e958e
MR
476 * lisp.h: Move EXFUNS for Fframe_root_window,
477 Fframe_first_window and Fset_frame_selected_window to window.h.
478
479 * window.h: Move EXFUNS for Fframe_root_window,
480 Fframe_first_window and Fset_frame_selected_window here from
481 lisp.h.
482
483 * frame.c (Fwindow_frame, Fframe_first_window)
484 (Fframe_root_window, Fframe_selected_window)
485 (Fset_frame_selected_window): Move to window.c.
486 (Factive_minibuffer_window): Move to minibuf.c.
487 (Fother_visible_frames_p): New function.
488
489 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
490
f230ecc9
MR
491 * window.c (decode_window, decode_any_window): Move up in code.
492 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
493 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
494 (Fwindow_buffer): Move up and rewrite doc-string.
495 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
496 (Fwindow_prev): New functions.
727e958e
MR
497 (Fwindow_frame): Move here from frame.c. Accept any window as
498 argument.
499 (Fframe_root_window, Fframe_first_window)
500 (Fframe_selected_window): Move here from frame.c. Accept frame
501 or arbitrary window as argument. Update doc-strings.
502 (Fminibuffer_window): Move up in code.
503 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
504 (Fset_frame_selected_window): Move here from frame.c.
505 Marginal rewrite.
727e958e
MR
506 (Fselected_window, select_window, Fselect_window): Move up in
507 code. Minor doc-string fixes.
f230ecc9 508
4d09bcf6
PE
5092011-06-06 Paul Eggert <eggert@cs.ucla.edu>
510
511 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
512 Do not assume that spare memory exists; that assumption is valid
513 only if SYSTEM_MALLOC.
514 (LARGE_REQUEST): New macro, so that the issue of large requests
515 is separated from the issue of spare memory.
516
810928a2
AS
5172011-06-05 Andreas Schwab <schwab@linux-m68k.org>
518
172418ad
AS
519 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
520 format. (Bug#8806)
521
43f862f7
AS
522 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
523
810928a2
AS
524 * xfns.c (x_set_scroll_bar_default_width): Move declarations
525 before statements.
526
a059fe24
JD
5272011-06-05 Jan Djärv <jan.h.d@swipnet.se>
528
529 * gtkutil.c (xg_get_default_scrollbar_width): New function.
530
531 * gtkutil.h: Declare xg_get_default_scrollbar_width.
532
533 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
534 min width by calling x_set_scroll_bar_default_width (Bug#8505).
535
989bf368
JB
5362011-06-05 Juanma Barranquero <lekktu@gmail.com>
537
538 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
539
4b80f674
CY
5402011-06-04 Chong Yidong <cyd@stupidchicken.com>
541
542 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
543 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
544 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
545 New error handlers.
4b80f674
CY
546 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
547 Obey Vx_select_enable_clipboard_manager. Catch errors in
548 x_clipboard_manager_save (Bug#8779).
549 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 550 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 551
99a33b77 5522011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
553
554 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
555
99a33b77 5562011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
557
558 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
559 in the current matrix if keep_current_p is non-zero.
560
8264569d
EZ
5612011-06-04 Eli Zaretskii <eliz@gnu.org>
562
563 * bidi.c (bidi_level_of_next_char): Fix last change.
564
57f97249
EZ
5652011-06-03 Eli Zaretskii <eliz@gnu.org>
566
fec2107c 567 Support bidi reordering of text covered by display properties.
57f97249 568
fec2107c
EZ
569 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
570 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
571 (bidi_cache_search, bidi_cache_iterator_state)
572 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
573 (bidi_level_of_next_char, bidi_move_to_visually_next):
574 Support character positions inside a run of characters covered by a
fec2107c
EZ
575 display string.
576 (bidi_paragraph_init, bidi_resolve_explicit_1)
577 (bidi_level_of_next_char): Call bidi_fetch_char and
578 bidi_fetch_char_advance instead of FETCH_CHAR and
579 FETCH_CHAR_ADVANCE.
580 (bidi_init_it): Initialize new members.
581 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
582 definitions.
583 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
584 instead of using explicit *_CHAR codes.
d6d100dd
SM
585 (bidi_resolve_explicit, bidi_resolve_weak):
586 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
587 bidirectional text is supported only in multibyte buffers.
588 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
589 it to initialize the frame_window_p member of struct bidi_it.
590 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
591 (bidi_resolve_explicit, bidi_resolve_weak)
592 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
593 bidi_it->nchars is non-positive.
594 (bidi_level_of_next_char): Don't try to lookup the cache for the
595 next/previous character if nothing is cached there yet, or if we
596 were just reseat()'ed to a new position.
c40e2fb2 597
0e14fe90
EZ
598 * xdisp.c (set_cursor_from_row): Set start and stop points
599 according to the row's direction when priming the loop that looks
600 for the glyph on which to display cursor.
601 (single_display_spec_intangible_p): Function deleted.
602 (display_prop_intangible_p): Reimplement to call
603 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
604 Accept 3 additional arguments needed by handle_display_spec.
605 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
606 values: lists, `(when COND...)' forms, etc.
607 (single_display_spec_string_p): Support property values that are
608 lists with the argument STRING its top-level element.
609 (display_prop_string_p): Fix the condition for processing a
610 property that is a list to be consistent with handle_display_spec.
fec2107c 611 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
612 last portion of handle_display_prop.
613 (compute_display_string_pos): Accept additional argument
614 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
615 value of a `display' property is a "replacing spec".
616 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
617 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
618 the display property, but just return a value indicating whether
619 the display property will replace the characters it covers.
620 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
621 frame_window_p members of struct bidi_it.
d6d100dd
SM
622 (compute_display_string_pos, compute_display_string_end):
623 New functions.
fec2107c
EZ
624 (push_it): Accept second argument POSITION, where pop_it should
625 jump to continue iteration.
626 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 627
fec2107c
EZ
628 * keyboard.c (adjust_point_for_property): Adjust the call to
629 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
630
631 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
632 (bidi_init_it): Update prototypes.
633 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
634 (compute_display_string_pos, compute_display_string_end):
635 Declare prototypes.
fec2107c
EZ
636 (struct bidi_it): New members nchars and disp_pos. ch_len is now
637 EMACS_INT.
fc6f18ce 638
40087514 6392011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 640
57f53182
PE
641 Malloc failure behavior now depends on size of allocation.
642 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
643 * lisp.h: Change signatures accordingly.
644 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
645 All callers changed. (Bug#8762)
646
647 * gnutls.c: Use Emacs's memory allocators.
648 Without this change, the gnutls library would invoke malloc etc.
649 directly, which causes problems on non-SYNC_INPUT hosts, and which
650 runs afoul of improving memory_full behavior. (Bug#8761)
651 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
652 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
653 xfree instead of the default malloc, realloc, free.
654 (Fgnutls_boot): No need to check for memory allocation failure,
655 since xmalloc does that for us.
656
ac32cd99 657 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
658 * category.c (hash_get_category_set):
659 * ccl.c (ccl_driver):
660 * charset.c (Fdefine_charset_internal):
661 * charset.h (struct charset.hash_index):
662 * composite.c (get_composition_id, gstring_lookup_cache)
663 (composition_gstring_put_cache):
664 * composite.h (struct composition.hash_index):
665 * dispextern.h (struct image.hash):
666 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
667 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
668 (hashfn_equal, hashfn_user_defined, make_hash_table)
669 (maybe_resize_hash_table, hash_lookup, hash_put)
670 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
671 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
672 (Fsxhash, Fgethash, Fputhash, Fmaphash):
673 * image.c (make_image, search_image_cache, lookup_image)
674 (xpm_put_color_table_h):
675 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 676 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
677 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
678 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
679 * alloc.c (allocate_vectorlike):
680 Check for overflow in vector size calculations.
681 * ccl.c (ccl_driver):
682 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
683 * fns.c, image.c: Remove unnecessary static decls that would otherwise
684 need to be updated by these changes.
40087514
PE
685 * fns.c (make_hash_table, maybe_resize_hash_table):
686 Check for integer overflow with large hash tables.
0de4bb68
PE
687 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
688 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
689 (SXHASH_REDUCE): New macro.
690 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
691 Use it instead of discarding useful hash info with large hash values.
692 (sxhash_float): New function.
693 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
694 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
695 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
696 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
697 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
698 Adjust signatures to match updated version of code.
699 (consing_since_gc): Now EMACS_INT, since a single hash table can
700 use more than INT_MAX bytes.
701
698d32e2
DN
7022011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
703
704 Make it possible to build with GCC-4.6+ -O2 -flto.
705
706 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
707
fd6fa53f
SM
7082011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
709
710 * minibuf.c (get_minibuffer, read_minibuf_unwind):
711 Call minibuffer-inactive-mode.
712
864db017
JB
7132011-05-31 Juanma Barranquero <lekktu@gmail.com>
714
715 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
716 Update dependencies.
717
2ad0baf4
DN
7182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
719
720 * data.c (init_data): Remove code for UTS, this system is not
721 supported anymore.
722
4fcc2638
DN
7232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
724
725 Don't force ./temacs to start in terminal mode.
726
727 * frame.c (make_initial_frame): Initialize faces in all cases, not
728 only when CANNOT_DUMP is defined.
729 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
730
c56e0fd5
DN
7312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
732
733 * dispnew.c (add_window_display_history): Use const for the string
734 pointer. Remove declaration, not needed.
735
333d54da 7362011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 737
55d4c1b2 738 Use 'inline', not 'INLINE'.
333d54da 739 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
740 * alloc.c, fontset.c (INLINE): Remove.
741 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
742 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
743 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
744 * gmalloc.c (register_heapinfo): Use inline unconditionally.
745 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
746
738db178
DN
7472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
748
749 Make it possible to run ./temacs.
750
751 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
752 syms_of_callproc does the same thing. Remove test for
753 "initialized", do it in the caller.
754 * emacs.c (main): Avoid calling set_initial_environment when dumping.
755
620c53a6
SM
7562011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
757
758 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
759 (read_minibuf): Use get_minibuffer.
760 (syms_of_minibuf): Use DEFSYM.
761 (Qmetadata): New var.
762 * data.c (Qbuffer): Don't make it static.
763 (syms_of_data): Use DEFSYM.
764
e003a292
PE
7652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
766
767 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
768 (CCL_CODE_MIN): New macro.
769
ed008a6d
PE
7702011-05-30 Paul Eggert <eggert@cs.ucla.edu>
771
3687c2ef
PE
772 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
773
ed008a6d
PE
774 * eval.c (Qdebug): Now static.
775 * lisp.h (Qdebug): Remove decl. This reverts a part of the
776 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
777 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
778
d66c4c7c
CY
7792011-05-29 Chong Yidong <cyd@stupidchicken.com>
780
781 * image.c: Various fixes to ImageMagick code comments.
782 (Fimagemagick_types): Doc fix.
783
5fbc2025
PE
7842011-05-29 Paul Eggert <eggert@cs.ucla.edu>
785
0196f88a
PE
786 Minor fixes prompted by GCC 4.6.0 warnings.
787
788 * xselect.c (converted_selections, conversion_fail_tag): Now static.
789
5fbc2025
PE
790 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
791 (x_clipboard_manager_save_all): Move extern decl to ...
792 * xterm.h: ... here, so that it can be checked for consistency.
793
1dd3c2d9
CY
7942011-05-29 Chong Yidong <cyd@stupidchicken.com>
795
796 * xselect.c (x_clipboard_manager_save_frame)
797 (x_clipboard_manager_save_all): New functions.
798 (Fx_clipboard_manager_save): Lisp function deleted.
799
800 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
801 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
802
803 * xterm.h: Update prototype.
804
5ba6571d
WX
8052011-05-28 William Xu <william.xwl@gmail.com>
806
807 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
808 exiting (Bug#8239).
809
3eaff834
JM
8102011-05-28 Jim Meyering <meyering@redhat.com>
811
e1900994 812 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
813 * fns.c (to_uchar): Define.
814 (crypto_hash_function): Use it to convert some newly-signed
815 variables to unsigned, to avoid sign-extension bugs. For example,
816 without this change, (md5 "truc") would evaluate to
817 45723a2aff78ff4fff7fff1114760e62 rather than the expected
818 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 819 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 820
0f6990a7
PE
8212011-05-27 Paul Eggert <eggert@cs.ucla.edu>
822
823 Integer overflow fixes.
c8a9ca5a 824
08686060
PE
825 * dbusbind.c: Serial number integer overflow fixes.
826 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
827 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
828 to hold a serial number that is too large for a fixnum.
829 (Fdbus_method_return_internal, Fdbus_method_error_internal):
830 Check for serial numbers out of range. Decode any serial number
59568bf0 831 that was so large that it became a float. (Bug#8722)
08686060 832
2d1fc3c7
PE
833 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
834 (Fdbus_call_method, Fdbus_call_method_asynchronously):
835 Use XFASTINT rather than XUINT when numbers are nonnegative.
836 (xd_append_arg, Fdbus_method_return_internal):
837 (Fdbus_method_error_internal): Likewise. Also, for unsigned
838 arguments, check that Lisp number is nonnegative, rather than
59568bf0 839 silently wrapping negative numbers around. (Bug#8722)
30217ff0 840 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 841 (Bug#8722)
2d1fc3c7 842
c8a9ca5a
PE
843 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
844
519e1d69
PE
845 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
846
30569699
PE
847 ccl: add integer overflow checks
848 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
849 (IN_INT_RANGE): New macros.
850 (ccl_driver): Use them to check for integer overflow when
851 decoding a CCL program. Many of the new checks are whether XINT (x)
852 fits in int; it doesn't always, on 64-bit hosts. The new version
853 doesn't catch all possible integer overflows, but it's an
847044ea 854 improvement. (Bug#8719)
30569699 855
c11285dc
PE
856 * alloc.c (make_event_array): Use XINT, not XUINT.
857 There's no need for unsigned here.
858
fdccd48e
PE
859 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
860 This follows up to the 2011-05-06 change that substituted uintptr_t
861 for EMACS_INT. This case wasn't caught back then.
862
37910ab2
PE
863 Rework Fformat to avoid integer overflow issues.
864 * editfns.c: Include <float.h> unconditionally, as it's everywhere
865 now (part of C89). Include <verify.h>.
866 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
867 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
868 (Fformat): Avoid the prepass trying to compute sizes; it was only
869 approximate and thus did not catch overflow reliably. Instead, walk
870 through the format just once, formatting and computing sizes as we go,
871 checking for integer overflow at every step, and allocating a larger
872 buffer as needed. Keep track separately whether the format is
873 multibyte. Keep only the most-recently calculated precision, rather
874 than them all. Record whether each argument has been converted to
875 string. Use EMACS_INT, not int, for byte and char and arg counts.
876 Support field widths and precisions larger than INT_MAX. Avoid
877 sprintf's undefined behavior with conversion specifications such as %#d
878 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
879 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
880 formatting out-of-range floating point numbers with int
881 formats. (Bug#8668)
882
2e6578fb
PE
883 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
884
0ae6bdee
PE
885 * data.c: Avoid integer truncation in expressions involving floats.
886 * data.c: Include <intprops.h>.
887 (arith_driver): When there's an integer overflow in an expression
888 involving floating point, convert the integers to floating point
889 so that the resulting value does not suffer from catastrophic
890 integer truncation. For example, on a 64-bit host (* 4
891 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
892 Do not rely on undefined behavior after integer overflow.
893
de883a70
PE
894 merge count_size_as_multibyte, parse_str_to_multibyte
895 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 896 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
897 Check for integer overflow.
898 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
899 since it's now a duplicate of the other. This is more of
900 a character than a buffer op, so better that it's in character.c.
901 * fns.c, print.c: Adjust to above changes.
902
2ff916cb
PE
9032011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
904
905 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
906
f1b54466
PE
9072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
908
fb1ac845
PE
909 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
910 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
911 (x_clipboard_manager_save): Now static.
912 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
913
f1b54466
PE
914 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
915 (crypto_hash_function): Now static.
916 Fix pointer signedness problems. Avoid unnecessary initializations.
917
a9f737ee
CY
9182011-05-27 Chong Yidong <cyd@stupidchicken.com>
919
920 * termhooks.h (Vselection_alist): Make it terminal-local.
921
922 * terminal.c (create_terminal): Initialize it.
923
924 * xselect.c: Support for clipboard managers.
925 (Vselection_alist): Move to termhooks.h as terminal-local var.
926 (LOCAL_SELECTION): New macro.
927 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
928 (symbol_to_x_atom): Remove gratuitous arg.
929 (x_handle_selection_request, lisp_data_to_selection_data)
930 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
931 (x_own_selection, x_get_local_selection, x_convert_selection):
932 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
933 (some_frame_on_display): Delete unused function.
934 (Fx_own_selection_internal, Fx_get_selection_internal)
935 (Fx_disown_selection_internal, Fx_selection_owner_p)
936 (Fx_selection_exists_p): New optional frame arg.
937 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
938 (x_handle_selection_clear): Don't treat other terminals with the
939 same keyboard specially. Use the terminal-local Vselection_alist.
940 (x_clear_frame_selections): Use Frun_hook_with_args.
941
942 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
943
944 * xterm.h: Add support for those atoms.
945
e067f0c1
CY
9462011-05-26 Chong Yidong <cyd@stupidchicken.com>
947
948 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
949 (converted_selections, conversion_fail_tag): New global variables.
950 (x_selection_request_lisp_error): Free the above.
951 (x_get_local_selection): Remove unnecessary code.
952 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
953 of converted selections stored in converted_selections.
954 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
955 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
956 (x_convert_selection): New function.
957 (x_handle_selection_event): Simplify.
958 (x_get_foreign_selection): Don't ignore incoming requests while
959 waiting for an answer; this will fail when we implement
960 SAVE_TARGETS, and seems unnecessary anyway.
961 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
962 (Vx_sent_selection_functions): Doc fix.
963
0f4aebc0
LL
9642011-05-26 Leo Liu <sdl.web@gmail.com>
965
966 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
967
e61124cd
YM
9682011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
969
970 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
971
972 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
973 for fringe update if it has periodic bitmap.
974 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
975 and fringe_bitmap_periodic_p.
976
977 * fringe.c (get_fringe_bitmap_data): New function.
978 (draw_fringe_bitmap_1, update_window_fringes): Use it.
979 (update_window_fringes): Record periodicity of fringe bitmap in glyph
980 row. Mark glyph row for fringe update if periodicity changed.
981
982 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
983 for fringe update unless it has periodic bitmap.
984
f16d9837
KH
9852011-05-25 Kenichi Handa <handa@m17n.org>
986
987 * xdisp.c (get_next_display_element): Set correct it->face_id for
988 a static composition.
989
e1b90ef6
LL
9902011-05-24 Leo Liu <sdl.web@gmail.com>
991
992 * deps.mk (fns.o):
993 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
994
995 * fns.c (crypto_hash_function, Fsha1): New function.
996 (Fmd5): Use crypto_hash_function.
997 (syms_of_fns): Add Ssha1.
998
7400048f
PE
9992011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1000
1001 * gnutls.c: Remove unused macros.
1002 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1003 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1004 Remove macros that are defined and never used.
1005 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1006
abb71cf4
CY
10072011-05-22 Chong Yidong <cyd@stupidchicken.com>
1008
1009 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1010 (Fx_get_selection_internal): Minor cleanup.
1011 (Fx_own_selection_internal): Rename arguments for consistency with
1012 select.el.
1013
6307db39
PE
10142011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1015
1016 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1017
f3d4e0a4
CY
10182011-05-22 Chong Yidong <cyd@stupidchicken.com>
1019
1020 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1021
4d8ade89
YM
10222011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1023
1024 * dispnew.c (scrolling_window): Don't exclude the case that the
1025 last enabled row in the desired matrix touches the bottom boundary.
1026
32078c8d
GM
10272011-05-21 Glenn Morris <rgm@gnu.org>
1028
1029 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1030 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1031 and add some more files.
32078c8d 1032
7285dc67
EZ
10332011-05-20 Eli Zaretskii <eliz@gnu.org>
1034
1035 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1036 report_file_error introduced by the change from 2011-05-07.
1037
89d1bd22
PE
10382011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1039
1040 * systime.h (Time): Define only if emacs is defined.
1041 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1042 where the include path doesn't have X11/X.h by default. See
1043 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1044
e23640bb 10452011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1046
1047 * composite.c (find_automatic_composition): Fix previous change.
1048
b9704ad9
GM
10492011-05-20 Glenn Morris <rgm@gnu.org>
1050
1051 * lisp.mk: New file, split from Makefile.in.
1052 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1053 (shortlisp): Remove.
1054 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1055
4a720484
GM
10562011-05-19 Glenn Morris <rgm@gnu.org>
1057
1058 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1059 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1060 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1061 (lisp): Set the order to that of loadup.el.
1062 (shortlisp): Make it a copy of $lisp.
1063 (SOME_MACHINE_LISP): Remove.
1064 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1065 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1066
a28d4396
KH
10672011-05-18 Kenichi Handa <handa@m17n.org>
1068
1069 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1070 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1071 (find_automatic_composition): Mostly rewrite for efficiency.
1072
a2b1fa8e
JB
10732011-05-18 Juanma Barranquero <lekktu@gmail.com>
1074
1075 * makefile.w32-in: Update dependencies.
1076
8e1f5610
CS
10772011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1078
1079 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1080 revision 104625).
1081
7025ee00 10822011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1083
cdfa6eab
PE
1084 Fix some integer overflow issues, such as string length overflow.
1085
06d6db33
PE
1086 * insdel.c (count_size_as_multibyte): Check for string overflow.
1087
2b4560a8
PE
1088 * character.c (lisp_string_width): Check for string overflow.
1089 Use EMACS_INT, not int, for string indexes and lengths; in
1090 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1091 the resulting string length overflows an EMACS_INT; instead,
1092 report a string overflow if no precision given. When checking for
1093 precision exhaustion, use a check that cannot possibly have
1094 integer overflow. (Bug#8675)
1095 * character.h (lisp_string_width): Adjust to new signature.
1096
cb93f9be
PE
1097 * alloc.c (string_overflow): New function.
1098 (Fmake_string): Use it. This doesn't change behavior, but saves
1099 a few bytes and will simplify future changes.
1100 * character.c (string_escape_byte8): Likewise.
1101 * lisp.h (string_overflow): New decl.
1102
1a1f3366
PE
1103 Fixups, following up to the user-interface timestamp change.
1104 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1105 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1106 * msdos.c (mouse_get_pos): Likewise.
1107 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1108 * w32gui.h (Time): Define by including "systime.h" rather than by
1109 declaring it ourselves. (Bug#8664)
1110
d4e3e4d3
PE
1111 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1112 * image.c (clear_image_cache): Likewise.
1113
f6a24d19
PE
1114 * term.c (term_mouse_position): Don't assume time_t wraparound.
1115
08dc5ae6
PE
1116 Be more systematic about user-interface timestamps.
1117 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1118 and sometimes 'EMACS_UINT', to represent these timestamps.
1119 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1120 This makes the code easier to follow, and makes it easier to catch
1121 integer overflow bugs such as Bug#8664.
1122 * frame.c (Fmouse_position, Fmouse_pixel_position):
1123 Use Time, not unsigned long, for user-interface timestamps.
1124 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1125 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1126 * keyboard.h (last_event_timestamp): Likewise.
1127 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1128 * menu.h (xmenu_show): Likewise.
1129 * term.c (term_mouse_position): Likewise.
1130 * termhooks.h (struct input_event.timestamp): Likewise.
1131 (struct terminal.mouse_position_hook): Likewise.
1132 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1133 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1134 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1135 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1136 what it was before.
1137 * menu.h, termhooks.h: Include "systime.h", for Time.
1138
8e55734a
PE
1139 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1140 Don't assume that the difference between two unsigned long values
1141 can fit into an integer. At this point, we know button_down_time
1142 <= event->timestamp, so the difference must be nonnegative, so
1143 there's no need to cast the result if double-click-time is
1144 nonnegative, as it should be; check that it's nonnegative, just in
1145 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1146 apart (about 25 days). (Bug#8664)
8e55734a 1147
841f1b75 1148 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1149 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1150
3e26f69c
PE
1151 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1152 that always fit in int. Use a sentinel instead of a counter, to
1153 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1154 * frame.h (struct frame): Use int for menu_bar_items_used
1155 instead of EMACS_INT, since it always fits in int.
3e26f69c 1156
5cc152c0
PE
1157 * menu.c (grow_menu_items): Check for int overflow.
1158
d89eb65e
PE
1159 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1160
5235bd3e
PE
1161 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1162 Before, the code was not consistent. These values cannot exceed
1163 2**31 - 1 so there's no need to make them unsigned.
1164 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1165 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1166 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1167 as modifiers.
1168 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1169
bc827e23
PE
1170 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1171 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1172 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1173 presumably because the widths might not match.
1174
78eb494e
PE
1175 * window.c (size_window): Avoid needless test at loop start.
1176
04f2d78b
CB
11772011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1178
1179 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1180
d2fc7e3d 11812011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1182
1183 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1184
d2fc7e3d 11852011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1186
1187 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1188 `width' to `bar_area_x' and `bar_area_width', respectively.
1189 (x_scroll_run): Take account of fringe background extension.
1190
04f2d78b
CB
1191 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1192 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1193 `bar_area_width', respectively.
1194 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1195 background extension.
1196
79b70037
GM
11972011-05-10 Jim Meyering <meyering@redhat.com>
1198
1199 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1200
2f142cc5
JB
12012011-05-10 Juanma Barranquero <lekktu@gmail.com>
1202
1203 * image.c (Finit_image_library): Return t for built-in image types,
1204 like pbm and xbm. (Bug#8640)
1205
57679c86
AS
12062011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1207
1208 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1209
888c9e86
EZ
12102011-05-07 Eli Zaretskii <eliz@gnu.org>
1211
b0512a1d
EZ
1212 * w32console.c (Fset_screen_color): Doc fix.
1213 (Fget_screen_color): New function.
1214 (syms_of_ntterm): Defsubr it.
1215
7285dc67
EZ
1216 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1217 unlink the temporary file if Fcall_process didn't create it in the
1218 first place.
1219 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1220 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1221 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1222 cue to call_process_cleanup not to close that handle.
1223
4d3fcc8e
BK
12242011-05-07 Ben Key <bkey76@gmail.com>
1225
1226 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1227 one of two shell specific rules, either bootstrap-temacs-CMD or
1228 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1229 to the previous implementation of the bootstrap-temacs rule.
1230 The bootstrap-temacs-CMD rule is similar to the previous
1231 implementation of the bootstrap-temacs rule except that it
1232 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1233 variable.
1234
1235 These changes, along with some changes to nt/configure.bat,
1236 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1237 earlier fix to add support for --cflags and --ldflags options
1238 that include quotes so that it works whether make uses cmd or
1239 sh as the shell.
1240
b4289b64
MA
12412011-05-06 Michael Albinus <michael.albinus@gmx.de>
1242
1243 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1244 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1245 is a constant.
1246 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1247 a string. Handle both cases.
1248 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1249 (Fdbus_register_method): Use Qinvalid_function.
1250
af4c0e28
JB
12512011-05-06 Juanma Barranquero <lekktu@gmail.com>
1252
1253 * makefile.w32-in: Update dependencies.
1254 (LISP_H): Add inttypes.h and stdin.h.
1255 (PROCESS_H): Add unistd.h.
1256
c51453d9
EZ
12572011-05-06 Eli Zaretskii <eliz@gnu.org>
1258
1259 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1260 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1261
8ff0ac3c 12622011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1263
4c4b566b
PE
1264 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1265
aab2b9b5
PE
1266 * term.c (vfatal): Remove stray call to va_end.
1267 It's not needed and the C Standard doesn't allow it here anyway.
1268
c378da0b
PE
1269 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1270 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1271
288b08c7
PE
1272 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1273 bytes.
1274
e3601888
PE
1275 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1276
db6c0e74
PE
1277 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1278
dd5963ea
PE
1279 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1280
88c9450f
PE
1281 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1282
2f9442b8
PE
1283 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1284
c032b5f8
PE
1285 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1286 * charset.c (Fdefine_charset_internal): Don't initialize
1287 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1288 32-bit int (Bug#8600).
a108c10b
PE
1289
1290 * lread.c (read_integer): Be more consistent with string-to-number.
1291 Use string_to_number to do the actual conversion; this avoids
1292 rounding errors and fixes some other screwups. Without this fix,
1293 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1294 (digit_to_number): Move earlier, for benefit of read_integer.
1295 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1296 not a digit in any supported base. (Bug#8602)
a108c10b 1297
ad5f9eea
PE
1298 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1299
aec1708a
PE
1300 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1301 to match comment at start of function. This also removes a
1302 GCC warning about overflow in a 32+64-bit port.
1303
47be4ab5
PE
1304 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1305
371cac43
PE
1306 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1307 Reported by Stefan Monnier in
1308 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1309 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1310 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1311
d01a7826
PE
1312 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1313 (EMACS_UINTPTR): Likewise, with uintptr_t.
1314
7fd47d5c
PE
1315 * lisp.h: Prefer 64-bit EMACS_INT if available.
1316 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1317 on 32-bit hosts that have 64-bit int, so that they can access
1318 large files.
122b0c86
PE
1319 However, temporarily disable this change unless the temporary
1320 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1321
8727937b
PE
1322 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1323
8ac068ac
PE
1324 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1325 This removes an assumption that EMACS_INT and long are the same
1326 width as pointers. The assumption is true for Emacs porting targets
1327 now, but we want to make other targets possible.
1328 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1329 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1330 In the rest of the code, change types of integers that hold casted
1331 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1332 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1333 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1334 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1335 No need to cast type when ORing.
1336 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1337 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1338 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1339 assume EMACS_INT is the same width as char *.
1340 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1341 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1342 Remove no-longer-needed casts.
1343 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1344 (xg_tool_bar_help_callback, xg_make_tool_item):
1345 Use EMACS_INTPTR to hold an integer
1346 that will be cast to void *; this can avoid a GCC warning
1347 if EMACS_INT is not the same width as void *.
1348 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1349 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1350 (current_message_1, set_message_1):
1351 Use a local to convert to proper width without a cast.
1352 * xmenu.c (dialog_selection_callback): Likewise.
1353
ede49d71
PE
1354 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1355 Also, don't assume VALBITS / RAND_BITS is less than 5,
1356 and don't rely on undefined behavior when shifting a 1 left into
1357 the sign bit.
1358 * lisp.h (get_random): Change signature to match.
1359
2f30ecd0
PE
1360 * lread.c (hash_string): Use size_t, not int, for hash computation.
1361 Normally we prefer signed values; but hashing is special, because
1362 it's better to use unsigned division on hash table sizes so that
1363 the remainder is nonnegative. Also, size_t is the natural width
1364 for hashing into memory. The previous code used 'int', which doesn't
1365 retain enough info to hash well into very large tables.
1366 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1367
2a866e7b
PE
1368 * dbusbind.c: Don't possibly lose pointer info when converting.
1369 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1370 Use XPNTR rather than XHASH, so that the high-order bits of
1371 the pointer aren't lost when converting through void *.
1372
51639eac
PE
1373 * eval.c (Fautoload): Don't double-shift a pointer.
1374
92394119
PE
1375 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1376
dbdb9a7c
JB
13772011-05-06 Juanma Barranquero <lekktu@gmail.com>
1378
1379 * gnutls.c (DEF_GNUTLS_FN):
1380 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1381
db7a0b4f
AS
13822011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1383
1384 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1385 marker. (Bug#8610)
1386
f7ff1b0f 13872011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1388
1389 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1390 New version that can reserve upto 2GB of heap space.
1391
f7ff1b0f 13922011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1393
1394 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1395
639c109b
TZ
13962011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1397
1398 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1399 `gnutls_certificate_set_x509_key_file'.
1400
d2127135
JB
14012011-05-05 Juanma Barranquero <lekktu@gmail.com>
1402
1403 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1404 Update dependencies.
1405
e968f4f3
JB
14062011-05-04 Juanma Barranquero <lekktu@gmail.com>
1407
1408 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1409 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1410 Remove unused parameter `fildes'.
1411 * process.c (read_process_output, send_process): Don't pass it.
1412
84d358f0
JB
14132011-05-04 Juanma Barranquero <lekktu@gmail.com>
1414
1415 Fix previous change: the library cache is defined in w32.c.
1416 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1417 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1418
0898ca10
JB
14192011-05-04 Juanma Barranquero <lekktu@gmail.com>
1420
1421 Implement dynamic loading of GnuTLS on Windows.
1422
1423 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1424 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1425 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1426 Declare.
1427
1428 * gnutls.c (Qgnutls_dll): Define.
1429 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1430 (gnutls_*): Declare function pointers.
1431 (init_gnutls_functions): New function to initialize function pointers.
1432 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1433 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1434 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1435 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1436 (emacs_gnutls_write, emacs_gnutls_read)
1437 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1438 (Fgnutls_available_p): New function.
1439 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1440 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1441 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1442
1443 * image.c: Include w32.h.
1444 (Vimage_type_cache): Delete.
1445 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1446 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1447 (w32_delayed_load): Move to w32.c.
1448
1449 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1450
1451 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1452 (w32_delayed_load): Move from image.c. When loading a library, record
1453 its filename in the :loaded-from property of the library id.
1454 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1455 Initialize and staticpro them.
1456 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1457
1458 * process.c: Include lisp.h before w32.h, not after.
1459 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1460 instead of gnutls_record_check_pending.
1461
1462 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1463
ff4de4aa
TZ
14642011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1465
1466 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1467 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1468 as passed in.
1469
abe95abb
JD
14702011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1471
1472 * xterm.c (x_set_frame_alpha): Do not set property on anything
1473 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1474
e16e55d4
JB
14752011-05-02 Juanma Barranquero <lekktu@gmail.com>
1476
1477 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1478
bafcf6a5
JB
14792011-05-02 Juanma Barranquero <lekktu@gmail.com>
1480
1481 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1482 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1483 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1484 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1485 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1486 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1487 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1488 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1489 (Qgnutls_bootprop_callbacks_verify): Make static.
1490
e7a6747f
AS
14912011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1492
19ed11ba
AS
1493 * callproc.c: Indentation fixup.
1494
e7a6747f 1495 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1496 (wait_for_termination, interruptible_wait_for_termination):
1497 Move after wait_for_termination_1.
e7a6747f 1498
1ef14cb4
LMI
14992011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1500
1501 * sysdep.c (interruptible_wait_for_termination): New function
1502 which is like wait_for_termination, but allows keyboard
1503 interruptions.
1504
1505 * callproc.c (Fcall_process): Add (:file "file") as an option for
1506 the STDOUT buffer.
1507 (Fcall_process_region): Ditto.
1508
330d880c
EZ
15092011-04-30 Eli Zaretskii <eliz@gnu.org>
1510
8db90b73
EZ
1511 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1512 rather than `XVECTOR (FOO)->size'.
1513
330d880c
EZ
1514 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1515 inttypes.h, as a gnulib replacement is used if it not available in
1516 system headers.
1517
15cbd324
EZ
15182011-04-21 Eli Zaretskii <eliz@gnu.org>
1519
1520 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1521 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1522 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1523
1524 * coding.c (coding_alloc_by_realloc): Error out if destination
1525 will grow beyond MOST_POSITIVE_FIXNUM.
1526 (decode_coding_emacs_mule): Abort if there isn't enough place in
1527 charbuf for the composition carryover bytes. Reserve an extra
1528 space for up to 2 characters produced in a loop.
1529 (decode_coding_iso_2022): Abort if there isn't enough place in
1530 charbuf for the composition carryover bytes.
1531
15322011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1533
ae940cca
EZ
1534 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1535 aborting when %lld or %lll format is passed.
1536 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1537 %llo or %llx format is passed. (Bug#8545)
1538
03ab8921
EZ
1539 * window.c (window_scroll_line_based): Use a marker instead of
1540 simple variables to record original value of point. (Bug#7952)
1541
afda1437
EZ
1542 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1543 produced by %s or %c overflows available buffer space. (Bug#8545)
1544
f76dee0c
PE
15452011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1546
1547 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1548 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1549
fdc5744d
JB
15502011-04-28 Juanma Barranquero <lekktu@gmail.com>
1551
1552 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1553
638f053a
JB
15542011-04-28 Juanma Barranquero <lekktu@gmail.com>
1555
1556 * keyboard.c (Qdelayed_warnings_hook): Define.
1557 (command_loop_1): Run `delayed-warnings-hook'
1558 if Vdelayed_warnings_list is non-nil.
1559 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1560 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1561
d178f871
EZ
15622011-04-28 Eli Zaretskii <eliz@gnu.org>
1563
1564 * doprnt.c (doprnt): Don't return value smaller than the buffer
1565 size if the message was truncated. (Bug#8545).
1566
b124fd93
JB
15672011-04-28 Juanma Barranquero <lekktu@gmail.com>
1568
1569 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1570 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1571
e810457d
PE
15722011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1573
1574 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1575
ea51cceb
JB
15762011-04-27 Juanma Barranquero <lekktu@gmail.com>
1577
1578 * makefile.w32-in: Update dependencies.
1579
94dcfacf
EZ
15802011-04-27 Eli Zaretskii <eliz@gnu.org>
1581
1582 Improve `doprnt' and its usage. (Bug#8545)
1583 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1584 `format_end'. Remove support for %l as a conversion specifier.
1585 Don't use xrealloc. Improve diagnostics when the %l size modifier
1586 is used. Update the commentary.
1587
1588 * eval.c (verror): Simplify calculation of size_t.
1589
1590 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1591 messages.
1592
f61f41d7
PE
15932011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1594
1595 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1596 change.
1597
96fb4434
PE
15982011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1599
1600 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1601 This makes this file independent of the recent pseudovector change.
1602
671875da 16032011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1604
69e9b5a3
PE
1605 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1606
b5f869a7 1607 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1608 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1609 Remove unused local.
c8926152 1610 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1611
841a1577 1612 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1613 GCC 4.6.0 optimizes based on type-based alias analysis.
1614 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1615 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1616 != &v->size, and therefore "v->size = 1; b->size = 2; return
1617 v->size;" must therefore return 1. This assumption is incorrect
1618 for Emacs, since it type-puns struct Lisp_Vector * with many other
1619 types. To fix this problem, this patch adds a new type struct
f904488f 1620 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1621 and pseudovectors, and helps optimizing compilers not get fooled
1622 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1623 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1624 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1625 the size member.
eab3844f
PE
1626 (XSETPVECTYPE): Rewrite in terms of new macro.
1627 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1628 This is a bit clearer, and further avoids the possibility of
1629 undesirable aliasing.
1630 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1631 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1632 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1633 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1634 (ASIZE): Now uses header.size rather than size.
1635 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1636 to avoid the hassle of writing XVECTOR (foo)->header.size.
1637 (struct vectorlike_header): New type.
eab3844f
PE
1638 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1639 object, to help avoid aliasing.
1640 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1641 (SUBRP): Likewise, since Lisp_Subr is a special case.
1642 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1643 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1644 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1645 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1646 changed to be "header.size" and "header.next".
1647 * buffer.h (struct buffer): Likewise.
1648 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1649 * frame.h (struct frame): Likewise.
1650 * process.h (struct Lisp_Process): Likewise.
1651 * termhooks.h (struct terminal): Likewise.
1652 * window.c (struct save_window_data, struct saved_window): Likewise.
1653 * window.h (struct window): Likewise.
1654 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1655 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1656 * buffer.c (init_buffer_once): Likewise.
1657 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1658 special case.
1659 * process.c (Fformat_network_address): Use local var for size,
1660 for brevity.
1661
0df1eac5
PE
1662 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1663
847ab9d1 1664 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1665 * data.c (atof): Remove decl; no longer used or needed.
1666 (digit_to_number): Move to lread.c.
1667 (Fstring_to_number): Use new string_to_number function, to be
1668 consistent with how the Lisp reader treats infinities and NaNs.
1669 Do not assume that floating-point numbers represent EMACS_INT
1670 without losing information; this is not true on most 64-bit hosts.
1671 Avoid double-rounding errors, by insisting on integers when
1672 parsing non-base-10 numbers, as the documentation specifies.
1673 * lisp.h (string_to_number): New decl, replacing ...
1674 (isfloat_string): Remove.
bc0a5c13 1675 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1676 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1677 appears to have been a coding error. Similarly, do not accept
1678 strings like +-1e0 as floating point numbers. Do not report
1679 overflow for integer overflows unless the base is not 10 which
1680 means we have no simple and reliable way to continue.
1681 Break out the floating-point parsing into a new
1682 function string_to_number, so that Fstring_to_number parses
1683 floating point numbers consistently with the Lisp reader.
04f2d78b 1684 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1685 (E_CHAR, EXP_INT): Remove, replacing with ...
1686 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1687 (string_to_number): New function, replacing isfloat_string.
1688 This function checks for valid syntax and produces the resulting
1689 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1690 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1691 so that overflow for non-base-10 numbers is reported only when
1692 there's no portable and simple way to convert to floating point.
452f4150 1693
67769ffc
PE
1694 * textprop.c (set_text_properties_1): Rewrite for clarity,
1695 and to avoid GCC warning about integer overflow.
1696
c20db43f
PE
1697 * intervals.h (struct interval): Use EMACS_INT for members
1698 where EMACS_UINT might cause problems. See
1699 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1700 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1701 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1702 All uses changed.
37aa2f85
PE
1703 (offset_intervals): Tell GCC not to worry about length overflow
1704 when negating a negative length.
c20db43f 1705
2538aa2f
PE
1706 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1707 (overrun_check_free): Likewise.
1708
f2d3008d
PE
1709 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1710 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1711 word size.
1712
ec8df744
PE
1713 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1714 (gnutls_make_error): Rename local to avoid shadowing.
1715 (gnutls_emacs_global_deinit): ifdef out; not used.
1716 (Fgnutls_boot): Use const for pointer to readonly storage.
1717 Comment out unused local. Fix pointer signedness problems.
1718
640ee02d
PE
1719 * lread.c (openp): Don't stuff size_t into an 'int'.
1720 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1721 about possible signed overflow.
1722
6048fb2a
PE
1723 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1724 (GDK_KEY_g): Don't define if already defined.
1725 (xg_prepare_tooltip): Avoid pointer signedness problem.
1726 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1727
fa3c87e1
PE
1728 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1729 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1730
2172544b
PE
1731 * xfns.c (Fx_window_property): Simplify a bit,
1732 to make a bit faster and to avoid GCC 4.6.0 warning.
1733 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1734
9b821a21
PE
1735 * fns.c (internal_equal): Don't assume size_t fits in int.
1736
3c616cfa
PE
1737 * alloc.c (compact_small_strings): Tighten assertion a little.
1738
c2982e87
PE
1739 Replace pEd with more-general pI, and fix some printf arg casts.
1740 * lisp.h (pI): New macro, generalizing old pEd macro to other
1741 conversion specifiers. For example, use "...%"pI"d..." rather
1742 than "...%"pEd"...".
1743 (pEd): Remove. All uses replaced with similar uses of pI.
1744 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1745 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1746 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1747 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1748 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1749 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1750 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1751 64-bit hosts.
1752 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1753 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1754 * print.c (safe_debug_print, print_object): Likewise.
1755 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1756 to int.
6f04d126
PE
1757 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1758 avoiding the 0 flag, which is not portable.
c2982e87
PE
1759 * process.c (Fmake_network_process): Use pI to avoid cast.
1760 * region-cache.c (pp_cache): Likewise.
1761 * xdisp.c (decode_mode_spec): Likewise.
1762 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1763 behavior on 64-bit hosts with printf arg.
6f04d126 1764 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1765 (x_stop_queuing_selection_requests): Likewise.
1766 (x_get_window_property): Don't truncate byte count to an 'int'
1767 when tracing.
0b432f21 1768
5e073ec7
PE
1769 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1770 here, since it parses constructs like leading '-' and spaces,
1771 which are not wanted; and it overflows with large numbers.
1772 Instead, simply match F[0-9]+, which is what is wanted anyway.
1773
36372bf9
PE
1774 * alloc.c: Remove unportable assumptions about struct layout.
1775 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1776 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1777 (allocate_vectorlike, make_pure_vector): Use the new macros,
1778 plus offsetof, to remove unportable assumptions about struct layout.
1779 These assumptions hold on all porting targets that I know of, but
1780 they are not guaranteed, they're easy to remove, and removing them
1781 makes further changes easier.
1782
0b432f21
PE
1783 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1784 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1785 (string_overrun_cookie): Now const. Use initializers that
1786 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1787 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1788 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1789 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1790 multiple of sizeof (EMACS_INT); it need not be, if
1791 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1792 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1793
895009e1
JB
17942011-04-26 Juanma Barranquero <lekktu@gmail.com>
1795
1796 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1797
6a7a1b0b
TZ
17982011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1799
1800 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1801 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1802 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1803
841a1577 18042011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1805
1806 * lisp.h (Qdebug): List symbol.
895009e1 1807 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1808 * keyboard.c (debug-on-event): New variable.
1809 (handle_user_signal): Break into debugger when debug-on-event
1810 matches the current signal symbol.
1811
f2d3ba6f
DN
18122011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1813
1814 * alloc.c (check_sblock, check_string_bytes)
1815 (check_string_free_list): Convert to standard C.
1816
42ce4c63
TZ
18172011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1818
1819 * w32.c (emacs_gnutls_push): Fix typo.
1820
825cd63c
EZ
18212011-04-25 Eli Zaretskii <eliz@gnu.org>
1822
fb11d64d
EZ
1823 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1824 "cast to pointer from integer of different size".
1825
825cd63c
EZ
1826 Improve doprnt and its use in verror. (Bug#8545)
1827 * doprnt.c (doprnt): Document the set of format control sequences
1828 supported by the function. Use SAFE_ALLOCA instead of always
1829 using `alloca'.
1830
1831 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1832 is one byte too soon. Don't use xrealloc; instead xfree and
1833 xmalloc anew.
1834
e061a11b
TZ
18352011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1836
1837 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1838 callbacks stage.
1839
1840 * gnutls.c: Renamed global_initialized to
1841 gnutls_global_initialized. Added internals for the
1842 :verify-hostname-error, :verify-error, and :verify-flags
1843 parameters of `gnutls-boot' and documented those parameters in the
1844 docstring. Start callback support.
1845 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1846 unless a fatal error occured. Call gnutls_alert_send_appropriate
1847 on error. Return error code.
1848 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1849 (emacs_gnutls_read): Likewise.
1850 (Fgnutls_boot): Return handshake error code.
1851 (emacs_gnutls_handle_error): New function.
1852 (wsaerror_to_errno): Likewise.
1853
1854 * w32.h (emacs_gnutls_pull): Add prototype.
1855 (emacs_gnutls_push): Likewise.
1856
1857 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1858 (emacs_gnutls_push): Likewise.
1859
18602011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1861
1862 * process.c (wait_reading_process_output): Check if GnuTLS
1863 buffered some data internally if no FDs are set for TLS
1864 connections.
1865
1866 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1867 (LIBS): Link to USER_LIBS.
1868 ($(BLD)/gnutls.$(0)): New target.
1869
fa6996bc
EZ
18702011-04-24 Eli Zaretskii <eliz@gnu.org>
1871
eb35682e
EZ
1872 * xdisp.c (handle_single_display_spec): Rename the
1873 display_replaced_before_p argument into display_replaced_p, to
1874 make it consistent with the commentary. Fix typos in the
1875 commentary.
1876
e2ad650c
EZ
1877 * textprop.c (syms_of_textprop): Remove dead code.
1878 (copy_text_properties): Delete obsolete commentary about an
1879 interface that was deleted long ago. Fix typos in the description
1880 of arguments.
1881
1b2de274
EZ
1882 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1883 to changes in oldXMenu/XMenu.h from 2011-04-16.
1884 <menu_help_message, prev_menu_help_message>: Constify.
1885 (IT_menu_make_room): menu->help_text is now `const char **';
1886 adjust.
1887
1888 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1889 to changes in oldXMenu/XMenu.h from 2011-04-16.
1890 (struct XMenu): Declare `help_text' `const char **'.
1891
1892 * xfaces.c <Qunspecified>: Make extern again.
1893
1894 * syntax.c: Include sys/types.h before including regex.h, as
1895 required by Posix.
1896
762b15be
EZ
1897 * doc.c (get_doc_string): Improve the format passed to `error'.
1898
1899 * doprnt.c (doprnt): Improve commentary.
1900
1901 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1902
1903 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1904 them with etags.
1905
f1052e5d
EZ
1906 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1907 changes in globals.h immediately force recompilation.
762b15be
EZ
1908 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1909 $(CURDIR)/s/ms-w32.h.
1910 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1911
fa6996bc
EZ
1912 * character.c (Fchar_direction): Function deleted.
1913 (syms_of_character): Don't defsubr it.
1914 <char-direction-table>: Deleted.
1915
e6c3da20
EZ
19162011-04-23 Eli Zaretskii <eliz@gnu.org>
1917
1918 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1919 * doprnt.c: Include limits.h.
1920 (SIZE_MAX): New macro.
04f2d78b
CB
1921 (doprnt): Return a size_t value. 2nd arg is now size_t.
1922 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1923 Improve overflow protection. Support `l' modifier for integer
1924 conversions. Support %l conversion. Don't assume an EMACS_INT
1925 argument for integer conversions and for %c.
1926
1927 * lisp.h (doprnt): Restore prototype.
1928
1929 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1930 $(SRC)/character.h.
1931
1932 * Makefile.in (base_obj): Add back doprnt.o.
1933
1934 * deps.mk (doprnt.o): Add back prerequisites.
1935 (callint.o): Depend on character.h.
1936
1937 * eval.c (internal_lisp_condition_case): Include the handler
1938 representation in the error message.
1939 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1940 when breaking from the loop.
1941
1942 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1943
1944 * callint.c (Fcall_interactively): When displaying error message
1945 about invalid control letter, pass the character's codepoint, not
1946 a pointer to its multibyte form. Improve display of the character
1947 in octal and display also its hex code.
1948
1949 * character.c (char_string): Use %x to display the (unsigned)
1950 codepoint of an invalid character, to avoid displaying a bogus
1951 negative value.
1952
1953 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1954 `error', not SYMBOL_NAME itself.
1955
1956 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1957 character arguments to `error'.
1958
1959 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1960 to `error' in error message about FINAL_CHAR argument. Make sure
1961 FINAL_CHAR is a character, and use %c when it is passed as
1962 argument to `error'.
1963
4ffd0d6b 19642011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1965
1966 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1967
1968 * w32.c: Include <time.h>.
1969 (sys_localtime): New function.
1970
4ffd0d6b 19712011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1972
1973 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1974
4ffd0d6b 1975 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1976
4ffd0d6b 19772011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1978
4ffd0d6b
GM
1979 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1980 zombies (Bug#8467).
aac0c6e3 1981
04c56954
EZ
19822011-04-19 Eli Zaretskii <eliz@gnu.org>
1983
1984 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1985 gl_state.e_property when gl_state.object is Qt.
1986
1987 * insdel.c (make_gap_larger): Remove limitation of buffer size
1988 to <= INT_MAX.
1989
16a43933
CY
19902011-04-18 Chong Yidong <cyd@stupidchicken.com>
1991
1992 * xdisp.c (lookup_glyphless_char_display)
1993 (produce_glyphless_glyph): Handle cons cell entry in
1994 glyphless-char-display.
1995 (Vglyphless_char_display): Document it.
1996
1997 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1998 glyphless-char-display.
1999
4581706e
CY
20002011-04-17 Chong Yidong <cyd@stupidchicken.com>
2001
2002 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2003
2004 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2005
2006 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2007 definition for no-X builds.
2008
4887c6e2 20092011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2010
fd35b6f9
PE
2011 Static checks with GCC 4.6.0 and non-default toolkits.
2012
5c1ccb01
PE
2013 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2014
006c5daa
PE
2015 * process.c (keyboard_bit_set): Define only if SIGIO.
2016 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2017 (send_process): Repair possible setjmp clobbering.
2018
efc736d3
PE
2019 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2020
4e2fe2e6
PE
2021 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2022
f97334a2
PE
2023 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2024
4e75f29d
PE
2025 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2026 Define only if needed.
2027
90efadd1
PE
2028 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2029 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2030 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2031
3c647824
PE
2032 * dispextern.h (struct redisplay_interface): Rename param
2033 to avoid shadowing.
e264f262 2034 * termhooks.h (struct terminal): Likewise.
761383f4 2035 * xterm.c (xembed_send_message): Likewise.
3c647824 2036
b58c5c4a
PE
2037 * insdel.c (make_gap_smaller): Define only if
2038 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2039
cad59032
PE
2040 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2041 it.
2042
c339dc2e
PE
2043 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2044 so that we aren't warned about unused symbols.
2045
91a3e27b
PE
2046 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2047
399c71d3 2048 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2049
8ffc96f5
PE
2050 * xfns.c (x_real_positions): Mark locals as initialized.
2051
eef9bc79
PE
2052 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2053
098db9dd
PE
2054 * xterm.c: Fix problems found by static analysis with other toolkits.
2055 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2056 (x_dispatch_event): Declare static if USE_GTK, and
2057 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2058 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2059 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2060 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2061 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2062
eb18f6cc
PE
2063 * xmenu.c (menu_help_callback): Pointer type fixes.
2064 Use const pointers when pointing at readonly data. Avoid pointer
2065 signedness clashes.
2066 (FALSE): Remove unused macro.
2067 (update_frame_menubar): Remove unused decl.
2068
1fe72bf8
PE
2069 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2070
60d9e1db
PE
2071 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2072 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2073 (single_menu_item): Rename local to avoid shadowing.
2074
39261c26
PE
2075 * keyboard.c (make_lispy_event): Remove unused local var.
2076
018c5e19
PE
2077 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2078 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2079
63d2b86e
PE
2080 * bitmaps: Change bitmaps from unsigned char back to the X11
2081 compatible char. Avoid the old compiler warnings about
2082 out-of-range initializers by using, for example, '\xab' rather
2083 than 0xab.
2084
aefd87e1
PE
2085 * xgselect.c (xgselect_initialize): Check vs interface
2086 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2087
bf501fb9
PE
2088 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2089
e9829fdf
PE
2090 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2091 to read-only memory.
2092
1086c095
PE
2093 * fns.c (vector): Remove; this old hack is no longer needed.
2094
2baccd04 2095 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2096 Remove unused var.
dde42981 2097 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2098
72391843 2099 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2100
436c16df 2101 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2102 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2103 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2104
92bb796d 2105 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2106 (x_term_init): Remove local to avoid shadowing.
92bb796d 2107
764430a3 2108 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2109
2110 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2111 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2112
d1dfb56c
EZ
21132011-04-16 Eli Zaretskii <eliz@gnu.org>
2114
c4354cb4
EZ
2115 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2116
d1dfb56c
EZ
2117 Fix regex.c, syntax.c and friends for buffers > 2GB.
2118 * syntax.h (struct gl_state_s): Declare character position members
2119 EMACS_INT.
2120
2121 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2122
04f2d78b
CB
2123 * textprop.c (verify_interval_modification, interval_of):
2124 Declare arguments EMACS_INT.
d1dfb56c
EZ
2125
2126 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2127 EMACS_INT.
2128
2129 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2130
2131 * indent.c (Fvertical_motion): Local variable it_start is now
2132 EMACS_INT.
2133
2134 * regex.c (re_match, re_match_2, re_match_2_internal)
2135 (bcmp_translate, regcomp, regexec, print_double_string)
2136 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2137 (re_compile_pattern, re_exec): Declare arguments and local
2138 variables `size_t' and `ssize_t' and return values `regoff_t', as
2139 appropriate.
2140 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2141 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2142 <compile_stack_type>: `size' and `avail' are now `size_t'.
2143
2144 * regex.h <regoff_t>: Use ssize_t, not int.
2145 (re_search, re_search_2, re_match, re_match_2): Arguments that
2146 specify buffer/string position and length are now ssize_t and
2147 size_t. Return type is regoff_t.
2148
613052cd
BK
21492011-04-16 Ben Key <bkey76@gmail.com>
2150
2151 * nsfont.m: Fixed bugs in ns_get_family and
2152 ns_descriptor_to_entity that were caused by using free to
2153 deallocate memory blocks that were allocated by xmalloc (via
2154 xstrdup). This caused Emacs to crash when compiled with
2155 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2156 --enable-checking=xmallocoverrun). xfree is now used to
2157 deallocate these memory blocks.
2158
4170f62f 21592011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2160
71b41406
PE
2161 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2162
9587a89d
PE
2163 emacs_write: Accept and return EMACS_INT for sizes.
2164 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2165 et seq.
2166 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2167 Accept and return EMACS_INT.
2168 (emacs_gnutls_write): Return the number of bytes written on
2169 partial writes.
2170 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2171 (emacs_read, emacs_write): Remove check for negative size, as the
2172 Emacs source code has been audited now.
9587a89d
PE
2173 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2174 (emacs_read, emacs_write): Use it.
273a5f82
PE
2175 * process.c (send_process): Adjust to the new signatures of
2176 emacs_write and emacs_gnutls_write. Do not attempt to store
2177 a byte offset into an 'int'; it might overflow.
9587a89d 2178 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2179
3e047f51
PE
2180 * sound.c: Don't assume sizes fit in 'int'.
2181 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2182 Return EMACS_INT, not int.
3e047f51 2183 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2184 Accept EMACS_INT, not int.
2185 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2186 record read return values.
2187
cc39a9db
BK
21882011-04-15 Ben Key <bkey76@gmail.com>
2189
c9d0ec6d
JB
2190 * keyboard.c (Qundefined): Don't declare static since it is used
2191 in nsfns.m.
2192 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2193 static since they are used in nsfont.m.
cc39a9db 2194
6c60eb9f
SM
21952011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2196
2197 * process.c (Qprocessp): Don't declare static.
2198 * lisp.h (Qprocessp): Declare again.
2199
7990b61a
JB
22002011-04-15 Juanma Barranquero <lekktu@gmail.com>
2201
2202 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2203
5d4cb038
PE
22042011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2205
8bd7b830 2206 Improve C-level modularity by making more things 'static'.
cd64ea1d 2207
e3b27b31
PE
2208 Don't publish debugger-only interfaces to other modules.
2209 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2210 (verify_bytepos, count_markers): Move decls to the only modules
2211 that need them.
2212 * region-cache.h (pp_cache): Likewise.
2213 * window.h (check_all_windows): Likewise.
2214 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2215
5d4cb038
PE
2216 * sysdep.c (croak): Now static, if
2217 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2218 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2219
2220 * alloc.c (refill_memory_reserve): Now static if
2221 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2222 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2223
e87b6180
PE
2224 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2225 Define only if USE_LUCID.
2226
ac64929e
PE
2227 * xrdb.c (x_customization_string, x_rm_string): Now static.
2228
6f37259d
PE
2229 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2230 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2231
1683e3ab
PE
2232 * xdisp.c (draw_row_with_mouse_face): Now static.
2233 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2234
de9c2632
PE
2235 * window.h (check_all_windows): Mark externally visible.
2236
2b96acb7
PE
2237 * window.c (window_deletion_count): Now static.
2238
2239 * undo.c: Make symbols static if they're not exported.
2240 (last_undo_buffer, last_boundary_position, pending_boundary):
2241 Now static.
2242
50436f33
PE
2243 * textprop.c (interval_insert_behind_hooks): Now static.
2244 (interval_insert_in_front_hooks): Likewise.
2245
64520e5c
PE
2246 * term.c: Make symbols static if they're not exported.
2247 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2248 (max_frame_lines, tty_set_terminal_modes):
2249 (tty_reset_terminal_modes, tty_turn_off_highlight):
2250 (get_tty_terminal): Now static.
2251 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2252 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2253 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2254 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2255 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2256
1fa53021
PE
2257 * sysdep.c: Make symbols static if they're not exported.
2258 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2259 Now static.
2260 (sigprocmask_set, full_mask): Remove; unused.
2261 (wait_debugging): Mark as visible.
2262 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2263 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2264
d4b43b22
PE
2265 * syntax.c (syntax_temp): Define only if !__GNUC__.
2266
b7c513d0
PE
2267 * sound.c (current_sound_device, current_sound): Now static.
2268
989b29ad
PE
2269 * search.c (searchbufs, searchbuf_head): Now static.
2270
13a55a78
PE
2271 * scroll.c (scroll_cost): Remove; unused.
2272 * dispextern.h (scroll_cost): Remove decl.
2273
de68a1fc
PE
2274 * region-cache.h (pp_cache): Mark as externally visible.
2275
40ccffa6
PE
2276 * process.c: Make symbols static if they're not exported.
2277 (process_tick, update_tick, create_process, chan_process):
2278 (Vprocess_alist, proc_buffered_char, datagram_access):
2279 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2280 (deactivate_process): Mark defn as static, as well as decl.
2281 * lisp.h (create_process): Remove decl.
2282 * process.h (chan_process, Vprocess_alist): Remove decls.
2283
ad64fc97
PE
2284 * print.c: Make symbols static if they're not exported.
2285 (print_depth, new_backquote_output, being_printed, print_buffer):
2286 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2287 (print_interval, print_number_index, initial_stderr_stream):
2288 Now static.
2289 * lisp.h (Fprinc): Remove decl.
2290 (debug_output_compilation_hack): Mark as externally visible.
2291
adddb265
PE
2292 * sysdep.c (croak): Move decl from here to syssignal.h.
2293 * syssignal.h (croak): Put it here, so the API can be checked when
2294 'croak' is called from dissociate_if_controlling_tty.
2295
1717ede2
PE
2296 * minibuf.c: Make symbols static if they're not exported.
2297 (minibuf_save_list, choose_minibuf_frame): Now static.
2298 * lisp.h (choose_minibuf_frame): Remove decl.
2299
fa5fb2bc
PE
2300 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2301
1e3890d1
PE
2302 * lread.c: Make symbols static if they're not exported.
2303 (read_objects, initial_obarray, oblookup_last_bucket_number):
2304 Now static.
2305 (make_symbol): Remove; unused.
2306 * lisp.h (initial_obarray, make_symbol): Remove decls.
2307
8a1414fa
PE
2308 * keyboard.c: Make symbols static if they're not exported.
2309 (single_kboard, recent_keys_index, total_keys, recent_keys):
2310 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2311 (this_single_command_key_start, echoing, last_auto_save):
2312 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2313 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2314 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2315 (Vlispy_mouse_stem, double_click_count):
2316 Now static.
2317 (force_auto_save_soon): Define only if SIGDANGER.
2318 (ignore_mouse_drag_p): Now static if
2319 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2320 (print_help): Remove; unused.
2321 (stop_character, last_timer_event): Mark as externally visible.
2322 * keyboard.h (ignore_mouse_drag_p): Declare only if
2323 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2324 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2325 * lisp.h (echoing): Remove decl.
2326 (force_auto_save_soon): Declare only if SIGDANGER.
2327 * xdisp.c (redisplay_window): Simplify code, to make it more
2328 obvious that ignore_mouse_drag_p is not accessed if !defined
2329 USE_GTK && !defined HAVE_NS.
2330
93ea6e8f
PE
2331 * intervals.c: Make symbols static if they're not exported.
2332 (merge_properties_sticky, merge_interval_right, delete_interval):
2333 Now static.
2334 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2335
77382fcc
PE
2336 * insdel.c: Make symbols static if they're not exported.
2337 However, leave prepare_to_modify_buffer alone. It's never
2338 called from outside this function, but that appears to be a bug.
2339 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2340 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2341 (adjust_after_replace_noundo): Remove; unused.
2342 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2343 (signal_before_change): Remove decls.
77382fcc 2344
9306c32e
PE
2345 * indent.c (val_compute_motion, val_vmotion): Now static.
2346
cd44d2eb
PE
2347 * image.c: Make symbols static if they're not exported.
2348 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2349 if USE_GTK.
2350 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2351 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2352
ad9a7a06
PE
2353 * fringe.c (standard_bitmaps): Now static.
2354 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2355
81626931
PE
2356 * frame.c: Make symbols static if they're not exported.
2357 (x_report_frame_params, make_terminal_frame): Now static.
2358 (get_frame_param): Now static, unless HAVE_NS.
2359 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2360 (x_get_resource_string): Remove; not used.
2361 * frame.h (make_terminal_frame, x_report_frame_params):
2362 (x_get_resource_string); Remove decls.
2363 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2364 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2365
239f9db9
PE
2366 * font.c, fontset.c: Make symbols static if they're not exported.
2367 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2368 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2369 * font.c (font_close_object): Now static.
2370 * font.h (font_close_object): Remove.
2371 * fontset.c (FONTSET_OBJLIST): Remove.
2372 (free_realized_fontset) #if-0 the body, which does nothing.
2373 (face_suitable_for_char_p): #if-0, as it's never called.
2374 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2375 * xfaces.c (face_at_string_position):
2376 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2377 since 0 is always ASCII.
2378
dfcf3579
PE
2379 * fns.c (weak_hash_tables): Now static.
2380
5045092b
PE
2381 * fileio.c: Make symbols static if they're not exported.
2382 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2383 (Vwrite_region_annotation_buffers): Now static.
2384
57a96f5c
PE
2385 * eval.c: Make symbols static if they're not exported.
2386 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2387 * lisp.h (backtrace_list): Remove decl.
2388
35f08c38
PE
2389 * emacs.c: Make symbols static if they're not exported.
2390 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2391 (fatal_error_code, fatal_error_signal_hook, standard_args):
2392 Now static.
2393 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2394 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2395 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2396 * lisp.h (fatal_error_signal_hook): Remove decl.
2397 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2398
f44bd759
PE
2399 * editfns.c: Move a (normally-unused) function to its only use.
2400 * editfns.c, lisp.h (get_operating_system_release): Remove.
2401 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2402 worth the hassle of breaking this out.
2403
b532497d
PE
2404 * xterm.c: Make symbols static if they're not exported.
2405 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2406 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2407 (x_destroy_window, x_delete_display):
2408 Now static.
2409 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2410 (x_mouse_leave): Remove; unused.
2411 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2412 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2413 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2414 Remove decls.
2415 (x_mouse_leave): Declare only if WINDOWSNT.
2416 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2417 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2418 USE_X_TOOLKIT.
2419
1675728f
PE
2420 * ftxfont.c: Make symbols static if they're not exported.
2421 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2422 HAVE_FREETYPE.
2423 * font.h (ftxfont_driver): Likewise.
2424
e4cebfca
PE
2425 * xfns.c: Make symbols static if they're not exported.
2426 (x_last_font_name, x_display_info_for_name):
2427 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2428 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2429 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2430 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2431 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2432 (last_show_tip_args): Now static.
2433 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2434 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2435 (x_screen_planes): Remove; unused.
2436 * dispextern.h (x_screen_planes): Remove decl.
2437
5bf46f05
PE
2438 * dispnew.c: Make symbols static if they're not exported.
2439 * dispextern.h (redraw_garbaged_frames, scrolling):
2440 (increment_row_positions): Remove.
2441 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2442 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2443 Now static.
2444 (redraw_garbaged_frames): Remove; unused.
2445
435f4c28
PE
2446 * xfaces.c: Make symbols static if they're not exported.
2447 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2448 Remove decls.
2449 * xterm.h (defined_color): Remove decls.
2450 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2451 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2452 (menu_face_changed_default, defined_color, free_realized_face):
2453 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2454 (ascii_face_of_lisp_face): Remove; unused.
2455
8524aef3
PE
2456 * xdisp.c: Make symbols static if they're not exported.
2457 * dispextern.h (scratch_glyph_row, window_box_edges):
2458 (glyph_to_pixel_coords, set_cursor_from_row):
2459 (get_next_display_element, set_iterator_to_next):
2460 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2461 (show_mouse_face): Remove decls
2462 * frame.h (message_buf_print): Likewise.
2463 * lisp.h (pop_message, set_message, check_point_in_composition):
2464 Likewise.
2465 * xterm.h (set_vertical_scroll_bar): Likewise.
2466 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2467 (message_buf_print, scratch_glyph_row, displayed_buffer):
2468 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2469 (get_next_display_element, show_mouse_face, window_box_edges):
2470 (frame_to_window_pixel_xy, check_point_in_composition):
2471 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2472 (glyph_to_pixel_coords): Remove; unused.
2473
16390cd2
PE
2474 * dired.c (file_name_completion): Now static.
2475
2476 * dbusbind.c (xd_in_read_queued_messages): Now static.
2477
a25f4dfa
PE
2478 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2479 * data.c (circular_list_error): Remove.
2480
14a9c8df
PE
2481 * commands.h (last_point_position, last_point_position_buffer):
2482 (last_point_position_window): Remove decls.
2483 * keyboard.c: Make these variables static.
2484
04f2d78b
CB
2485 * coding.h (coding, code_convert_region, encode_coding_gap):
2486 Remove decls.
74ab6df5
PE
2487 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2488 (iso_code_class, detect_coding, code_convert_region): Now static.
2489 (encode_coding_gap): Remove; unused.
2490
38dfbee1
PE
2491 * chartab.c (chartab_chars, chartab_bits): Now static.
2492
a2cb4e63
PE
2493 * charset.h (charset_iso_8859_1): Remove decl.
2494 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2495 Now static.
2496
127198fd
PE
2497 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2498 * ccl.c (Vccl_program_table): Now static.
2499 (check_ccl_update): Remove; unused.
2500
d85b608f
PE
2501 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2502 * category.h: ... from here.
2503 * category.c (check_category_table, set_category_set): Now static.
2504
31cd66f3
PE
2505 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2506 * lisp.h: Remove these decls.
2507
c358e587
PE
2508 * buffer.c (buffer_count): Remove unused var.
2509
e78aecca
PE
2510 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2511 so that it's not optimized away.
2512 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2513 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2514 exported only to the debugger.
2515
e192d7d3 2516 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2517 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2518
92470028
PE
2519 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2520 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2521 was inaccessible from Lisp.
2522 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2523 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2524
244ed907
PE
2525 alloc.c: Import and export fewer symbols, and remove unused items.
2526 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2527 is defined.
2528 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2529 it's not optimized away by whole-program optimization.
2530 (message_enable_multibyte, free_misc): Remove.
2531 (catchlist, handlerlist, mark_backtrace):
2532 Declare only if BYTE_MARK_STACK.
2533 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2534 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2535 (message_enable_multibyte): Remove decl.
2536 (free_misc, interval_free_list, float_block, float_block_index):
2537 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2538 (cons_free_list, last_marked_index):
2539 Now static.
2540 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2541 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2542 (mark_backtrace): Define only if BYTE_MARK_STACK.
2543 * xdisp.c (message_enable_multibyte): Now static.
2544
61c2b50e 2545 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2546 This makes it easier for human readers (and static analyzers)
2547 to see whether these variables are used from other modules.
2548 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2549 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2550 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2551 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2552 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2553 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2554 * xmenu.c, xselect.c:
2555 Declare Q* vars static if they are not used in other modules.
2556 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2557 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2558 Remove decls of unexported vars.
2559 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2560
95c82688
PE
2561 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2562
16a97296
PE
2563 Make Emacs functions such as Fatom 'static' by default.
2564 This makes it easier for human readers (and static analyzers)
2565 to see whether these functions can be called from other modules.
2566 DEFUN now defines a static function. To make the function external
2567 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2568 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2569 (Finit_image_library):
16a97296
PE
2570 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2571 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2572 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2573 Remove decls, since these functions are now static.
2574 (Funintern, Fget_internal_run_time): New decls, since these functions
2575 were already external.
95c82688 2576
16a97296
PE
2577 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2578 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2579 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2580 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2581 * keyboard.c, keymap.c, lread.c:
2582 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2583 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2584 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2585 Mark functions with DEFUE instead of DEFUN,
2586 if they are used in other modules.
2587 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2588 decls for now-static functions.
2589 * buffer.h (Fdelete_overlay): Remove decl.
2590 * callproc.c (Fgetenv_internal): Mark as internal.
2591 * composite.c (Fremove_list_of_text_properties): Remove decl.
2592 (Fcomposition_get_gstring): New forward static decl.
2593 * composite.h (Fcomposite_get_gstring): Remove decl.
2594 * dired.c (Ffile_attributes): New forward static decl.
2595 * doc.c (Fdocumntation_property): New forward static decl.
2596 * eval.c (Ffetch_bytecode): New forward static decl.
2597 (Funintern): Remove extern decl; now in .h file where it belongs.
2598 * fileio.c (Fmake_symbolic_link): New forward static decl.
2599 * image.c (Finit_image_library): New forward static decl.
2600 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2601 * intervals.h (Fprevious_property_change):
2602 (Fremove_list_of_text_properties): Remove decls.
2603 * keyboard.c (Fthis_command_keys): Remove decl.
2604 (Fcommand_execute): New forward static decl.
2605 * keymap.c (Flookup_key): New forward static decl.
2606 (Fcopy_keymap): Now static.
2607 * keymap.h (Flookup_key): Remove decl.
2608 * process.c (Fget_process): New forward static decl.
2609 (Fprocess_datagram_address): Mark as internal.
2610 * syntax.c (Fsyntax_table_p): New forward static decl.
2611 (skip_chars): Remove duplicate decl.
2612 * textprop.c (Fprevious_property_change): New forward static decl.
2613 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2614 Now internal.
2615 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2616 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2617
785bbd42
PE
2618 * editfns.c (Fformat): Remove unreachable code.
2619
8b913b57
AS
26202011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2621
2622 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2623 change. (Bug#8496)
2624
a6744a35
EZ
26252011-04-13 Eli Zaretskii <eliz@gnu.org>
2626
2627 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2628 when at ZV. (Bug#8487)
2629
e7974947
AS
26302011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2631
baad03f0
AS
2632 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2633 (Bug#8437)
2634 * keyboard.c (parse_tool_bar_item): Likewise.
2635 * sound.c (sound_cleanup, alsa_close): Likewise.
2636 * termcap.c (tgetent): Likewise.
2637 * xfns.c (x_default_font_parameter): Likewise.
2638 * xsettings.c (read_and_apply_settings): Likewise.
2639
e7974947
AS
2640 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2641 (overrun_check_free): Protoize.
2642
28272684
PE
26432011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2646 since callers should never pass a negative size.
2647 Change the signature to match that of plain 'read' and 'write'; see
2648 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2649 * lisp.h: Update prototypes of emacs_write and emacs_read.
2650
11997c76
EZ
26512011-04-11 Eli Zaretskii <eliz@gnu.org>
2652
2653 * xdisp.c (redisplay_window): Don't try to determine the character
2654 position of the scroll margin if the window start point w->startp
e896f03c 2655 is outside the buffer's accessible region. (Bug#8468)
11997c76 2656
8a2cbd72
EZ
26572011-04-10 Eli Zaretskii <eliz@gnu.org>
2658
2659 Fix write-region and its subroutines for buffers > 2GB.
2660 * fileio.c (a_write, e_write): Modify declaration of arguments and
2661 local variables to support buffers larger than 2GB.
2662 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2663
2664 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2665 argument, local variables, and return value.
2666
2667 * lisp.h: Update prototypes of emacs_write and emacs_read.
2668
2669 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2670
4073e537 26712011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2672
1ebfdcb6
PE
2673 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2674
b2ded58d
PE
2675 Fix more problems found by GCC 4.6.0's static checks.
2676
7d66342c
PE
2677 * xdisp.c (vmessage): Use a better test for character truncation.
2678
bbf47d44
PE
2679 * charset.c (load_charset_map): <, not <=, for optimization,
2680 and to avoid potential problems with integer overflow.
9248994d 2681 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2682 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2683 * editfns.c (Fformat): Likewise.
1e69125e 2684 * syntax.c (skip_chars): Likewise.
3befa583 2685
e3019616
PE
2686 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2687 This also lets GCC 4.6.0 generate slightly better loop code.
2688
becfa255
PE
2689 * callint.c (Fcall_interactively): <, not <=, for optimization.
2690 (Fcall_interactively): Count the number of arguments produced,
2691 not the number of arguments given. This is simpler and lets GCC
2692 4.6.0 generate slightly better code.
2693
dae0cd48
PE
2694 * ftfont.c: Distingish more carefully between FcChar8 and char.
2695 The previous code passed unsigned char * to a functions like
2696 strlen and xstrcasecmp that expect char *, which does not
2697 conform to the C standard.
2698 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2699 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2700 char * when the C standard requires it.
2701
76032d70
PE
2702 * keyboard.c (read_char): Remove unused var.
2703
eb3f1cc8
PE
2704 * eval.c: Port to Windows vsnprintf (Bug#8435).
2705 Include <limits.h>.
2706 (SIZE_MAX): Define if the headers do not.
2707 (verror): Do not give up if vsnprintf returns a negative count.
2708 Instead, grow the buffer. This ports to Windows vsnprintf, which
2709 does not conform to C99. Problem reported by Eli Zaretskii.
2710 Also, simplify the allocation scheme, by avoiding the need for
2711 calling realloc, and removing the ALLOCATED variable.
2712
70476b54
PE
2713 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2714
12020a9e
PE
2715 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2716 But keep the doprint source code for now, as we might revamp it
2717 and use it again (Bug#8435).
ea6c7ae6
PE
2718 * lisp.h (doprnt): Remove.
2719 * Makefile.in (base_obj): Remove doprnt.o.
2720 * deps.mk (doprnt.o): Remove.
2721
5fdb398c
PE
2722 error: Print 32- and 64-bit integers portably (Bug#8435).
2723 Without this change, on typical 64-bit hosts error ("...%d...", N)
2724 was used to print both 32- and 64-bit integers N, which relied on
2725 undefined behavior.
2726 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2727 New macro.
2728 * lisp.h (error, verror): Mark as printf-like functions.
2729 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2730 Report overflow in size calculations when allocating printf buffer.
2731 Do not truncate output string at its first null byte.
2732 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2733 Truncate the output at a character boundary, since vsnprintf does not
2734 do that.
2735 * charset.c (check_iso_charset_parameter): Convert internal
2736 character to string before calling 'error', since %c now has the
2737 printf meaning.
2738 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2739 overflow when computing char to be passed to 'error'. Do not
2740 pass Lisp_Object to 'error'; pass the integer instead.
2741 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2742 formatted with plain %d.
2743
b189fa66
PE
2744 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2745
bff87ef0
PE
2746 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2747
7e2cac20
PE
2748 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2749
ce4d90b5
PE
2750 * xterm.c (x_catch_errors): Remove duplicate declaration.
2751
266c9547
PE
2752 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2753
79c49ad2
PE
2754 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2755
368f4090
JM
27562011-04-10 Jim Meyering <meyering@redhat.com>
2757
2758 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2759 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2760 return ssize_t not "int", and use size_t as the buffer length.
2761 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2762 * gnutls.h: Update declarations.
2763 * process.c (read_process_output): Use ssize_t, to match.
2764 (send_process): Likewise.
2765
a32d4040
CY
27662011-04-09 Chong Yidong <cyd@stupidchicken.com>
2767
2768 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2769
8546720e 27702011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2771
04f2d78b
CB
2772 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2773 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2774
8546720e
GM
2775 * xterm.c (handle_one_xevent):
2776 * xmenu.c (create_and_show_popup_menu):
2777 * xselect.c (x_decline_selection_request)
2778 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2779
0a2f5c1a 27802011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2781
2782 Fix some uses of `int' instead of EMACS_INT.
2783 * search.c (string_match_1, fast_string_match)
2784 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2785 (scan_buffer, find_next_newline_no_quit)
2786 (find_before_next_newline, search_command, Freplace_match)
2787 (Fmatch_data): Make some `int' variables be EMACS_INT.
2788
2789 * xdisp.c (display_count_lines): 3rd argument and return value now
2790 EMACS_INT. All callers changed.
2791 (pint2hrstr): Last argument is now EMACS_INT.
2792
2793 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2794 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2795 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2796 (decode_coding_utf_16, decode_coding_emacs_mule)
2797 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2798 (decode_coding_ccl, decode_coding_charset)
2799 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2800 (decode_coding_iso_2022, decode_coding_emacs_mule)
2801 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2802 <char_offset, last_offset>: Declare EMACS_INT.
2803 (encode_coding_utf_8, encode_coding_utf_16)
2804 (encode_coding_emacs_mule, encode_invocation_designation)
2805 (encode_designation_at_bol, encode_coding_iso_2022)
2806 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2807 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2808 Declare EMACS_INT.
2809 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2810 (encode_invocation_designation): Last argument P_NCHARS is now
2811 EMACS_INT.
2812 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2813 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2814
2815 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2816 All users changed.
2817
2818 * ccl.c (Fccl_execute_on_string): Declare some variables
2819 EMACS_INT.
2820
8546720e 28212011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2822
2823 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2824
4e19a977
CS
28252011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2826
2827 * process.c (Fformat_network_address): Doc fix.
2828
87302331
R
28292011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2830
2831 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2832
cbb59342
CY
28332011-04-08 Chong Yidong <cyd@stupidchicken.com>
2834
2835 * keyboard.c (read_char): Call Lisp function help-form-show,
2836 instead of using internal_with_output_to_temp_buffer.
2837 (Qhelp_form_show): New var.
e0d38eeb 2838 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2839
2840 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2841
2842 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2843
e67a13ab
CY
28442011-04-06 Chong Yidong <cyd@stupidchicken.com>
2845
04f2d78b
CB
2846 * process.c (Flist_processes): Remove to Lisp.
2847 (list_processes_1): Delete.
e67a13ab 2848
973f782d
EZ
28492011-04-06 Eli Zaretskii <eliz@gnu.org>
2850
7c106b1e
EZ
2851 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2852
973f782d
EZ
2853 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2854
41cf7d1a 28552011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2856
ca23cc88
PE
2857 Fix more problems found by GCC 4.6.0's static checks.
2858
f390e2d5
PE
2859 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2860
42eea0d0
PE
2861 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2862
b69769da 2863 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2864
f9541e84
PE
2865 * xdisp.c (vmessage): Mark as a printf-like function.
2866
13841b55
PE
2867 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2868
c136c10f
PE
2869 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2870
5e2d4a30
PE
2871 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2872 printf-like functions.
2873 (tiff_load): Add casts to remove these marks before passing them
2874 to system-supplied API.
2875
583f48b9
PE
2876 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2877
b25d760e
PE
2878 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2879 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2880 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2881 directly, rather than having caller test rule sign. This avoids
2882 some unnecessary tests.
2883 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2884 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2885 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2886
bc7b6697 2887 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2888 (xfont_open): Avoid unnecessary tests.
bc7b6697 2889
27ccc379
PE
2890 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2891
dcd5c89a
PE
2892 * composite.h, composite.c (composition_gstring_put_cache):
2893 Use EMACS_INT, not int, for length.
2894
b13a45c6
PE
2895 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2896 breaking out part of COMPOSITION_DECODE_RULE.
2897 (COMPOSITION_DECODE_RULE): Use it.
2898 * composite.c (get_composition_id): Remove unused local vars,
2899 by using the new macro.
2900
1e792e4d
PE
2901 * textprop.c (set_text_properties_1): Change while to do-while,
2902 since the condition is always true at first.
2903
dc6c6455 2904 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2905 (interval_deletion_adjustment): Return unsigned value.
2906 All uses changed.
dc6c6455 2907
aba7731a
PE
2908 * process.c (list_processes_1, create_pty, read_process_output):
2909 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2910 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2911 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2912 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2913 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2914
fdfc4bf3
PE
2915 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2916
fca8fe46 2917 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2918 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2919
06a0259a 2920 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2921 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2922 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2923
e7b9e80f
PE
2924 * print.c (print_error_message): Avoid int overflow.
2925
56201685
PE
2926 * font.c (font_list_entities): Redo for clarity,
2927 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2928
78834453 2929 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2930 (font_score): Avoid potential overflow in diff calculation.
78834453 2931
0bc0b309 2932 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2933 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2934
e610eaca
PE
2935 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2936
b895abce
PE
2937 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2938 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2939 can always succeed if overflow has undefined behavior.
2940
1f1d9321 2941 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2942 (wordify): Omit three unnecessary tests.
1f1d9321 2943
c59478bc
PE
2944 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2945 All callers changed. This avoids the need for an unused var.
2946
79b73827
PE
2947 * casefiddle.c (casify_region): Remove var that is set but not used.
2948
a4db5dfe
PE
2949 * dired.c (file_name_completion): Remove var that is set but not used.
2950
43aae36e
PE
2951 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2952
2a47c44d 2953 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2954 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2955
a37c69bf
PE
2956 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2957 Check for integer overflow on size calculations.
2958
328ab8e7
PE
2959 * buffer.c (Fprevious_overlay_change): Remove var that is set
2960 but not used.
2961
e5a2a5cb
PE
2962 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2963 Remove vars that are set but not used.
8d84a6eb 2964 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2965 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2966
a60e5f68
PE
2967 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2968
f661cb61 2969 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2970 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2971
f0397f5a
PE
2972 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2973 that are set but not used.
2974
8664db06 2975 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2976 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2977
6abdaa4a
PE
2978 * xselect.c (x_get_local_selection, x_handle_property_notify):
2979 Remove vars that are set but not used.
2980
0ce7538d 2981 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2982 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2983
9ae848fc
PE
2984 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2985 Remove var that is set but not used.
0b918413
PE
2986 (scroll_bar_windows_size): Now size_t, not int.
2987 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2988 Check for overflow.
9ae848fc 2989
a5a62657
PE
2990 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2991 (map_tty_color) [!defined MSDOS]: Likewise.
2992
5c5cdd39
PE
2993 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2994
66ebf983
PE
2995 * coding.c: Remove vars that are set but not used.
2996 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2997 All callers changed.
2998 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2999 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3000 (decode_coding_charset): Remove vars that are set but not used.
3001
1be4d761
PE
3002 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3003 that is set but not used.
3004
47553fa8
PE
3005 * print.c (print_object): Remove var that is set but not used.
3006
1f7196bf 3007 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3008 The gnulib version avoids calling malloc in the usual case,
3009 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3010 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3011 * filelock.c (current_lock_owner): Likewise.
3012 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3013 * sysdep.c: Include allocator.h, careadlinkat.h.
3014 (emacs_no_realloc_allocator): New static constant.
3015 (emacs_readlink): New function.
fdb61804
PE
3016 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3017 ../lib/careadlinkat.h.
d1fdcab7 3018
f84c17c7
SM
30192011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3020
3021 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3022 first non-nil return value).
3023
ef3862ad
JD
30242011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3025
3026 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3027 if not defined (Bug#8403).
3028
376a7006
JB
30292011-04-02 Juanma Barranquero <lekktu@gmail.com>
3030
3031 * xdisp.c (display_count_lines): Remove parameter `start',
3032 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3033 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3034 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3035 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3036 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3037 and thereabouts. All callers changed.
3038 (get_per_char_metric): Remove parameter `f', unused since
3039 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3040
6ca3801d
JM
30412011-04-02 Jim Meyering <meyering@redhat.com>
3042
3043 do not dereference NULL upon failed strdup
3044 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3045 (ns_get_family): Likewise.
3046
d8e2b5ba
JB
30472011-04-02 Juanma Barranquero <lekktu@gmail.com>
3048
3049 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3050
8c74fcbd
JD
30512011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3052
3053 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3054 later (Bug#8403).
3055
7200d79c
SM
30562011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3057
03408648 3058 Add lexical binding.
7200d79c 3059
03408648
SM
3060 * window.c (Ftemp_output_buffer_show): New fun.
3061 (Fsave_window_excursion):
3062 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3063
3064 * lread.c (lisp_file_lexically_bound_p): New function.
3065 (Fload): Bind Qlexical_binding.
3066 (readevalloop): Remove `evalfun' arg.
3067 Bind Qinternal_interpreter_environment.
3068 (Feval_buffer): Bind Qlexical_binding.
3069 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3070 Mark as dynamic.
3071 (syms_of_lread): Declare `lexical-binding'.
3072
3073 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3074
3075 * keyboard.c (eval_dyn): New fun.
3076 (menu_item_eval_property): Use it.
ca105506
SM
3077
3078 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3079
03408648
SM
3080 * fns.c (concat, mapcar1): Accept byte-code-functions.
3081
3082 * eval.c (Fsetq): Handle lexical vars.
3083 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3084 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3085 (FletX, Flet): Obey lexical binding.
3086 (Fcommandp): Handle closures.
3087 (Feval): New `lexical' arg.
3088 (eval_sub): New function extracted from Feval. Use it almost
3089 everywhere where Feval was used. Look up vars in lexical env.
3090 Handle closures.
3091 (Ffunctionp): Move from subr.el.
3092 (Ffuncall): Handle closures.
3093 (apply_lambda): Remove `eval_flags'.
3094 (funcall_lambda): Handle closures and new byte-code-functions.
3095 (Fspecial_variable_p): New function.
3096 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3097 but without exporting it to Lisp.
23aba0ea 3098
23aba0ea 3099 * doc.c (Fdocumentation, store_function_docstring):
03408648 3100 * data.c (Finteractive_form): Handle closures.
23aba0ea 3101
03408648
SM
3102 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3103 interactive spec.
ba83908c 3104
04f2d78b
CB
3105 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3106 New byte-codes.
03408648
SM
3107 (exec_byte_code): New function extracted from Fbyte_code to handle new
3108 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3109
03408648 3110 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3111
03408648 3112 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3113
e2abce01
JB
31142011-03-31 Juanma Barranquero <lekktu@gmail.com>
3115
3116 * xdisp.c (redisplay_internal): Fix prototype.
3117
63696a73 31182011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3119
63696a73 3120 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3121 (try_scrolling): Use it when setting scroll_limit.
3122 Limit scrolling to 100 screen lines.
63696a73
EZ
3123 (redisplay_window): Even when falling back on "recentering",
3124 position point in the window according to scroll-conservatively,
3125 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3126
3127 (try_scrolling): When point is above the window, allow searching
3128 as far as scroll_max, or one screenful, to compute vertical
3129 distance from PT to the scroll margin position. This prevents
3130 try_scrolling from unnecessarily failing when
3131 scroll-conservatively is set to a value slightly larger than the
3132 window height. Clean up the case of PT below the margin at bottom
3133 of window: scroll_max can no longer be INT_MAX. When aggressive
3134 scrolling is in use, don't let point enter the opposite scroll
3135 margin as result of the scroll.
3136 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3137 threshold of 100 lines for never-recentering scrolling.
3138
e4cc2dfc
JB
31392011-03-31 Juanma Barranquero <lekktu@gmail.com>
3140
3141 * dispextern.h (move_it_by_lines):
3142 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3143 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3144 (message_log_check_duplicate): Remove parameters `prev_bol' and
3145 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3146 (redisplay_internal): Remove parameter `preserve_echo_area',
3147 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3148
3149 * indent.c (Fvertical_motion):
3150 * window.c (window_scroll_pixel_based, Frecenter):
3151 Don't pass `need_y_p' to `move_it_by_lines'.
3152
1c470562
SM
31532011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3154
44f230aa
SM
3155 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3156 steal a few bits to be more compact.
3157 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3158 Remove unneeded casts.
3159
1c470562
SM
3160 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3161
888adce9
ZK
31622011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3163
3164 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3165 binding" message (bug#7967).
3166
f838ed7b
PE
31672011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3168
77861b95
PE
3169 Fix more problems found by GCC 4.6.0's static checks.
3170
de6dbc14
PE
3171 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3172 Remove unused local var.
3173
f838ed7b
PE
3174 * editfns.c (Fmessage_box): Remove unused local var.
3175
792c7b2b
PE
3176 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3177 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3178 Omit unused local vars.
c499e557 3179 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3180 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3181 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3182 Omit unused local var.
3183
ba0165e1
PE
3184 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3185 Don't assume string length fits in int.
32ad8845 3186 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3187 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3188
3c59b4c9
PE
3189 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3190 instead of alloca (Bug#8344).
3191
a3eed478 3192 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3193 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3194
eb4d412d
PE
3195 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3196
1658b401
PE
3197 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3198 concerns.
3199
3200 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3201
3202 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3203
9a2c6e05
PE
3204 * keyboard.c (syms_of_keyboard): Use the same style as later
3205 in this function when indexing through an array. This also
3206 works around GCC bug 48267.
3207
03d0a109
PE
3208 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3209
44f730c8
PE
3210 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3211
fe75f926
PE
3212 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3213 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3214
ffa8c828
PE
3215 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3216 This avoids undefined behavior on integer overflow, and is a bit
3217 more convenient anyway since it is compared to a size_t variable.
3218
c5101a77
PE
3219 Variadic C functions now count arguments with size_t, not int.
3220 This avoids an unnecessary limitation on 64-bit machines, which
3221 caused (substring ...) to crash on large vectors (Bug#8344).
3222 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3223 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3224 All variadic functions and their callers changed accordingly.
c5101a77
PE
3225 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3226 * data.c (arith_driver, float_arith_driver): Likewise.
3227 * editfns.c (general_insert_function): Likewise.
3228 * eval.c (struct backtrace.nargs, interactive_p)
3229 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3230 (funcall_lambda, mark_backtrace): Likewise.
3231 * fns.c (concat): Likewise.
3232 * frame.c (x_set_frame_parameters): Likewise.
3233 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3234 0 if not found, not -1. All callers changed.
3235
dd3f25f7
PE
3236 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3237 (stack_copy_size): Now size_t, not int.
3238 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3239
461c2ab9
JB
32402011-03-28 Juanma Barranquero <lekktu@gmail.com>
3241
3242 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3243 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3244 All callers changed.
3245
3246 * lisp.h (multibyte_char_to_unibyte):
3247 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3248 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3249 * character.h (CHAR_TO_BYTE8):
3250 * cmds.c (internal_self_insert):
3251 * editfns.c (general_insert_function):
3252 * keymap.c (push_key_description):
3253 * search.c (Freplace_match):
3254 * xdisp.c (message_dolog, set_message_1): All callers changed.
3255
f6d62986
SM
32562011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3257
3258 * keyboard.c (safe_run_hook_funcall): New function.
3259 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3260 don't set the hook to nil, but remove the offending function instead.
3261 (Qcommand_hook_internal): Remove, unused.
3262 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3263 Vcommand_hook_internal.
3264
3265 * eval.c (enum run_hooks_condition): Remove.
3266 (funcall_nil, funcall_not): New functions.
3267 (run_hook_with_args): Call each function through a `funcall' argument.
3268 Remove `cond' argument, now redundant.
3269 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3270 (Frun_hook_with_args_until_failure): Adjust accordingly.
3271 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3272
1db5b1ad
JB
32732011-03-28 Juanma Barranquero <lekktu@gmail.com>
3274
3275 * dispextern.h (string_buffer_position): Remove declaration.
3276
3277 * print.c (strout): Remove parameter `multibyte', unused since
3278 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3279
3280 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3281 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3282 All callers changed.
3283
3284 * w32.c (_wsa_errlist): Use braces for struct initializers.
3285
3286 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3287 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3288 All callers changed.
3289 (string_buffer_position): Likewise. Also, make static (it's never
3290 used outside xdisp.c).
3291 (cursor_row_p): Remove parameter `w', unused since
3292 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3293 (decode_mode_spec): Remove parameter `precision', introduced during
3294 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3295 All callers changed.
3296
5ffb62aa
JD
32972011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3298
3299 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3300
461c2ab9 33012011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3302
3303 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3304 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3305 (ns_update_auto_hide_menu_bar): New functions.
3306 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3307 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3308 ns_constrain_all_frames.
3309 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3310 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3311
5c380ffb
JD
33122011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3313
3314 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3315
9af30bdf
GM
33162011-03-27 Glenn Morris <rgm@gnu.org>
3317
3318 * syssignal.h: Replace RETSIGTYPE with void.
3319 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3320 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3321 Replace SIGTYPE with void everywhere.
3322 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3323 * s/template.h (SIGTYPE): Remove commented out definition.
3324
e2abce01
JB
33252011-03-26 Eli Zaretskii <eliz@gnu.org>
3326
3327 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3328 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3329
f868cd8a
JB
33302011-03-26 Juanma Barranquero <lekktu@gmail.com>
3331
59eb0929
JB
3332 * w32.c (read_unc_volume): Use parameter `henum', instead of
3333 global variable `wget_enum_handle'.
3334
3335 * keymap.c (describe_vector): Remove parameters `indices' and
3336 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3337 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3338
f868cd8a
JB
3339 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3340
3341 * keyboard.c (timer_check): Remove parameter `do_it_now',
3342 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3343 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3344 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3345
3346 * keyboard.c (read_char):
3347 * w32menu.c (w32_menu_display_help):
3348 * xmenu.c (show_help_event, menu_help_callback):
3349 Adjust calls to `show_help_echo'.
3350
3351 * gtkutil.c (xg_maybe_add_timer):
3352 * keyboard.c (readable_events):
3353 * process.c (wait_reading_process_output):
3354 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3355
3356 * insdel.c (adjust_markers_gap_motion):
3357 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3358 (gap_left, gap_right): Don't call it.
3359
2ecf6fdb
CY
33602011-03-25 Chong Yidong <cyd@stupidchicken.com>
3361
3362 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3363 incurred during fontification.
3364
6b1f9ba4
JB
33652011-03-25 Juanma Barranquero <lekktu@gmail.com>
3366
3367 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3368 (DEFVAR_PER_BUFFER): Don't pass it.
3369
3370 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3371 (scrolling_window): Don't pass it.
3372
0f4a96b5
JB
33732011-03-25 Juanma Barranquero <lekktu@gmail.com>
3374
3375 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3376
3377 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3378 and `suffix'.
3379 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3380 of variables specific to SELinux and computation of `encoded_absname'.
3381
3382 * image.c (XPutPixel): Remove unused variable `height'.
3383
3384 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3385
3386 * unexw32.c (get_section_info): Remove unused variable `section'.
3387
3388 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3389 (system_process_attributes): Remove unused variable `sess'.
3390 (sys_read): Remove unused variable `err'.
3391
3392 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3393 (w32_wnd_proc): Remove unused variable `isdead'.
3394 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3395 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3396 (x_create_tip_frame): Remove unused variable `tem'.
3397
3398 * w32inevt.c (w32_console_read_socket):
3399 Remove unused variable `no_events'.
3400
3401 * w32term.c (x_draw_composite_glyph_string_foreground):
3402 Remove unused variable `width'.
3403
1149507c
JB
34042011-03-24 Juanma Barranquero <lekktu@gmail.com>
3405
3406 * w32term.c (x_set_glyph_string_clipping):
3407 Don't pass uninitialized region to CombineRgn.
3408
9c88f339
JB
34092011-03-23 Juanma Barranquero <lekktu@gmail.com>
3410
3411 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3412 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3413 (Fx_close_connection): Remove unused variable `i'.
3414
3415 * w32font.c (w32font_draw): Return number of glyphs.
3416 (w32font_open_internal): Remove unused variable `i'.
3417 (w32font_driver): Add missing initializer.
3418
3419 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3420 (fill_in_menu): Remove unused variable `items_added'.
3421
3422 * w32term.c (last_mouse_press_frame): Remove static global variable.
3423 (w32_clip_to_row): Remove unused variable `f'.
3424 (x_delete_terminal): Remove unused variable `i'.
3425
3426 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3427 (NOTHING): Remove unused static global variable.
3428 (uniscribe_check_otf): Remove unused variable `table'.
3429 (uniscribe_font_driver): Add missing initializers.
3430
dee091a3
JD
34312011-03-23 Julien Danjou <julien@danjou.info>
3432
3433 * term.c (Fsuspend_tty, Fresume_tty):
3434 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3435 * window.c (temp_output_buffer_show):
3436 * insdel.c (signal_before_change):
3437 * frame.c (Fhandle_switch_frame):
3438 * fileio.c (Fdo_auto_save):
3439 * emacs.c (Fkill_emacs):
3440 * editfns.c (save_excursion_restore):
3441 * cmds.c (internal_self_insert):
3442 * callint.c (Fcall_interactively):
3443 * buffer.c (Fkill_all_local_variables):
3444 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3445 Use Frun_hooks.
0f4a96b5 3446 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3447 unconditionnaly since it does the check itself.
3448
2c520ab5 34492011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3450
c9c49752
PE
3451 Fix more problems found by GCC 4.5.2's static checks.
3452
8abc3f12
PE
3453 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3454 the first time through the loop, since we know p0 < p1 then.
3455 This also avoids a gcc -Wstrict-overflow warning.
3456
a2d26660
PE
3457 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3458 leading to a memory leak, possible in functions like
3459 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3460 of objects (Bug#8318).
a2d26660 3461
916c72e9
PE
3462 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3463 that could (at least in theory) be that large.
3464
19ab8a18
PE
3465 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3466 This is less likely to overflow, and avoids undefined behavior if
3467 overflow does occur. All callers changed. Use strtoul to scan
3468 for the unsigned long integer.
b7cbbd6f
PE
3469 (pint2hrstr): Simplify and tune code slightly.
3470 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3471
f0641eff
PE
3472 * scroll.c (do_scrolling): Work around GCC bug 48228.
3473 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3474
7f650bb9
PE
3475 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3476 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3477 (validate_x_resource_name): Simplify count usage.
3478 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3479
37dd57d1
PE
3480 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3481 fail (Bug#8306).
81e56e61 3482
699979fc 3483 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3484
401bf9b4
PE
3485 * process.c (Fmake_network_process): Use socklen_t, not int,
3486 where POSIX says socklen_t is required in portable programs.
3487 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3488 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3489 (Fmake_network_process, server_accept_connection):
3490 (wait_reading_process_output, read_process_output):
3491 Likewise.
3492
b93aacde
PE
3493 * process.c: Rename or move locals to avoid shadowing.
3494 (list_processes_1, Fmake_network_process):
3495 (read_process_output_error_handler, exec_sentinel_error_handler):
3496 Rename or move locals.
4dc343ee 3497 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3498 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3499 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3500 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3501 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3502
af8a867c 3503 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3504 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3505 Include tparam.h instead, since it declares them.
af8a867c
PE
3506 * cm.h (PC): Remove extern decl; tparam.h now does this.
3507 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3508 * terminfo.c: Include tparam.h, to check interfaces.
3509 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3510 (tparam): Adjust signature to match interface in tparam.h;
3511 this removes some undefined behavior. Check that outstring and len
3512 are zero, which they always are with Emacs.
3513 * tparam.h (PC, BC, UP): New extern decls.
3514
0248044d 3515 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3516 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3517
8ff096c1 3518 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3519 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3520 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3521 (ftfont_list): Remove unused local.
49eaafba
PE
3522 (get_adstyle_property, ftfont_pattern_entity):
3523 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3524 Rename locals to avoid shadowing.
8ff096c1 3525
e2be39f6
PE
3526 * xfont.c (xfont_list_family): Mark var as initialized.
3527
c9735e30
PE
3528 * xml.c (make_dom): Now static.
3529
8f5201ae
PE
3530 * composite.c (composition_compute_stop_pos): Rename local to
3531 avoid shadowing.
b246f932
PE
3532 (composition_reseat_it): Remove unused locals.
3533 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3534 (composition_update_it): Mark var as initialized.
11b61122
PE
3535 (find_automatic_composition): Mark vars as initialized,
3536 with a FIXME (Bug#8290).
8f5201ae 3537
760fbc2c
PE
3538 character.h: Rename locals to avoid shadowing.
3539 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3540 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3541 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3542 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3543 to avoid shadowing.
3544
ff08eb85
PE
3545 * textprop.c (property_change_between_p): Remove; unused.
3546
fc7bf025
PE
3547 * intervals.c (interval_start_pos): Now static.
3548
235d7abc
PE
3549 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3550
44f230aa
SM
3551 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3552 Rename locals to avoid shadowing.
3e7d6594 3553
50060332
PE
3554 * sound.c (wav_play, au_play, Fplay_sound_internal):
3555 Fix pointer signedness.
d01f234b 3556 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3557 (wav_play): Initialize a variable to 0, to prevent undefined
3558 behavior (Bug#8278).
50060332 3559
c4fc4e30
PE
3560 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3561
918436ed
PE
3562 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3563
c939f91b
PE
3564 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3565 clobbering (Bug#8298).
b9c7f648
PE
3566 * sysdep.c (sys_subshell): Likewise.
3567 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3568
6bd8c144
PE
3569 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3570 This should get cleaned up, so that child_setup has the
3571 same signature on all platforms.
3572
7710357c 3573 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3574 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3575
c59da222
CY
35762011-03-22 Chong Yidong <cyd@stupidchicken.com>
3577
3578 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3579 not to be necessary, and produces flickering.
3580
66b87493
GM
35812011-03-20 Glenn Morris <rgm@gnu.org>
3582
3583 * config.in: Remove file.
3584
45b6f6d5
JB
35852011-03-20 Juanma Barranquero <lekktu@gmail.com>
3586
3587 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3588 are now in src/globals.h.
3589 (syms_of_minibuf): Remove spurious & from previous change.
3590
3ec03f7e
LL
35912011-03-20 Leo <sdl.web@gmail.com>
3592
3593 * minibuf.c (completing-read-function): New variable.
3594 (completing-read-default): Rename from completing-read.
3595 (completing-read): Call completing-read-function.
3596
b14e3e21
CY
35972011-03-19 Juanma Barranquero <lekktu@gmail.com>
3598
3599 * xfaces.c (Fx_load_color_file):
3600 Read color file from absolute filename (bug#8250).
3601
f2b726e6
JB
36022011-03-19 Juanma Barranquero <lekktu@gmail.com>
3603
3604 * makefile.w32-in: Update dependencies.
3605
09f6ff02
EZ
36062011-03-17 Eli Zaretskii <eliz@gnu.org>
3607
3608 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3609
29a6015a
PE
36102011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3611
a3a6c54e
PE
3612 Fix more problems found by GCC 4.5.2's static checks.
3613
b766f867
PE
3614 * process.c (make_serial_process_unwind, send_process_trap):
3615 (sigchld_handler): Now static.
3616
be02381c
PE
3617 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3618 That way, the code declares only the vars that it needs.
3619 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3620 * s/cygwin.h (PTY_ITERATION): Likewise.
3621 * s/darwin.h (PTY_ITERATION): Likewise.
3622 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3623
57048744
PE
3624 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3625 * process.c (allocate_pty): Don't declare stb unless it's needed.
3626
7914961c 3627 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3628 (CONSTANTLIM): Remove; unused.
3629 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3630 Define only if needed.
7914961c 3631
b3967b18
PE
3632 * unexelf.c (unexec): Name an expression,
3633 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3634 Use a different way to cause a compilation error if anyone uses
3635 n rather than nn, a way that does not involve shadowing.
73366a00 3636 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3637
29a6015a
PE
3638 * deps.mk (unexalpha.o): Remove; unused.
3639
43cfc33e 3640 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3641 * unexec.h: New file.
ce701a33
PE
3642 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3643 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3644 Depend on unexec.h.
3645 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3646 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3647 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3648 Change as necessary to match prototype in unexec.h.
ce701a33 3649
01f44d5a
PE
3650 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3651 shadowing.
4f63c6bb 3652 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3653
a6670b0b
PE
3654 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3655 Rename locals to avoid shadowing.
3656
cef2010d 3657 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3658 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3659
d4d7173a
PE
3660 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3661
f08b802a
PE
3662 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3663 warning when compiling print.c.
3664
3ddb0639
PE
3665 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3666 instead of using an uninitialized var.
5ad03b97 3667 (font_sort_entities): Mark var as initialized.
3ddb0639 3668
170a2692
PE
3669 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3670
e663c700
PE
3671 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3672 pointers to constants.
89bc529a 3673 (font_parse_fcname): Remove unused vars.
7b81e2d0 3674 (font_delete_unmatched): Now static.
ea838e10 3675 (font_get_spec): Remove; unused.
13a547c6
PE
3676 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3677 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3678 Rename or move locals to avoid shadowing.
e663c700 3679
2a80c887 3680 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3681 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3682
1384fa33 3683 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3684 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3685
8b2c52e9
PE
3686 * alloc.c (mark_backtrace): Move decl from here ...
3687 * lisp.h: ... to here, so that it can be checked.
3688
475545b5 3689 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3690 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3691 (lisp_indirect_variable): Name an expression,
3692 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3693 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3694
b1349114 3695 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3696 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3697 Use const pointer when appropriate.
b1349114 3698
a2928364
PE
3699 * lisp.h (get_system_name, get_operating_system_release):
3700 Move decls here, to check interfaces.
3701 * process.c (get_operating_system_release): Move decl to lisp.h.
3702 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3703 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3704 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3705 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3706 (Fformat_time_string, Fencode_time, Finsert_char):
3707 (Ftranslate_region_internal, Fformat):
3708 Rename or remove local vars to avoid shadowing.
9710023e 3709 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3710
a415e694
PE
3711 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3712 avoid shadowing.
3713
8ef4622d
PE
3714 * lisp.h (eassert): Check that the argument compiles, even if
3715 ENABLE_CHECKING is not defined.
3716
946f9a5b
PE
3717 * data.c (Findirect_variable): Name an expression, to avoid
3718 gcc -Wbad-function-cast warning.
112396d6 3719 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3720 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3721 (Fmake_variable_buffer_local, Fmake_local_variable):
3722 Mark variables as initialized.
52746918 3723 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3724
e5aab7e7 3725 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3726 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3727 Rename locals to avoid shadowing.
dff45157
PE
3728 (mark_stack): Move local variables into the #ifdef region where
3729 they're used.
7bc26fdb
PE
3730 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3731 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3732 needed otherwise.
3733 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3734 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3735 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3736
e5aab7e7
PE
3737 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3738 avoids undefined behavior in theory.
3739
4da60324
PE
3740 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3741
88043301
PE
3742 Use functions, not macros, for up- and down-casing (Bug#8254).
3743 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3744 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3745 to use the following functions instead of these macros.
3746 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3747 EMACS_INT, since callers assume the returned value fits in int.
3748 (upcase1): Likewise, for UPCASE_TABLE.
3749 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3750 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3751 the race-condition problem in the old DOWNCASE.
88043301 3752
19ed5445
PE
3753 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3754 Rename locals to avoid shadowing.
3755 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3756 (regex_compile, re_search_2, re_match_2_internal):
3757 Remove unused local vars.
952db0d7
PE
3758 (FREE_VAR): Rewrite so as not to use empty "else",
3759 which gcc can warn about.
da053e48 3760 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3761 (RETALLOC_IF): Define only if needed.
3762 (WORDCHAR_P): Likewise. This one is never needed, but is used
3763 only in a comment talking about a compiler bug, so put inside
3764 the #if 0 of that comment.
3765 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3766 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3767 Remove; unused.
19ed5445 3768
1f3561e4 3769 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3770 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3771 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3772
ded6f8f7
PE
3773 * search.c (simple_search): Remove unused var.
3774
dbd37a95
PE
3775 * dired.c (compile_pattern): Move decl from here ...
3776 * lisp.h: ... to here, so that it can be checked.
3777 (struct re_registers): New forward decl.
3778
7e47afad
PE
3779 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3780
85f24f61
PE
3781 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3782 All uses changed.
3783 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3784 Rename locals to avoid shadowing.
5671df8f 3785 (Fvertical_motion): Mark locals as initialized.
85f24f61 3786
181aa2be 3787 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3788 (casify_region): Mark local as initialized.
181aa2be 3789
930d429c
PE
3790 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3791
7082eac6
PE
3792 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3793 New macros, so that the caller can use some names other than
3794 gcpro1, gcpro2, etc.
3795 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3796 of the new macros.
3797 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3798 argument, for consistency with GCPRO2_VAR, etc: it is now the
3799 prefix of the variable, not the variable itself. All uses
3800 changed.
38b2c076
PE
3801 * dired.c (directory_files_internal, file_name_completion):
3802 Rename locals to avoid shadowing.
3803
15206ed9
PE
3804 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3805 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3806 dired.c's scmp function, had undefined behavior.
3807 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3808 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3809 * buffer.h: ... to here, because these macros use current_buffer,
3810 and the new implementation with inline functions needs to have
3811 current_buffer in scope now, rather than later when the macros
3812 are used.
3813 (downcase, upcase1): New static inline functions.
3814 (DOWNCASE, UPCASE1): Reimplement using these functions.
3815 This avoids undefined behavior in expressions like
3816 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3817 from race conditions in accessing the global variables
3818 case_temp1 and case_temp2.
3819 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3820 * lisp.h (case_temp1, case_temp2): Remove their decls.
3821 * character.h (ASCII_CHAR_P): Move from here ...
3822 * lisp.h: ... to here, so that the inline functions mentioned
3823 above can use them.
3824
4a6bea26
PE
3825 * dired.c (directory_files_internal_unwind): Now static.
3826
f14b7e14
PE
3827 * fileio.c (file_name_as_directory, directory_file_name):
3828 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3829 Now static.
2893f146
PE
3830 (file_name_as_directory): Use const pointers when appropriate.
3831 (Fexpand_file_name): Likewise. In particular, newdir might
3832 point at constant storage, so make it a const pointer.
fd4ead52 3833 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3834 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3835 signedness issues.
f839df0c
PE
3836 (Fset_file_times, Finsert_file_contents, auto_save_error):
3837 Rename locals to avoid shadowing.
f14b7e14 3838
5716756e 3839 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3840 (Ftry_completion, Fall_completions): Rename or remove locals
3841 to avoid shadowing.
5716756e 3842
b4c3046a
PE
3843 * marker.c (bytepos_to_charpos): Remove; unused.
3844
b45db522
PE
3845 * lisp.h (verify_bytepos, count_markers): New decls,
3846 so that gcc does not warn that these functions aren't declared.
3847
85876d07
PE
3848 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3849 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3850 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3851 (copy_text): Remove unused local var.
85876d07 3852
03d78a21 3853 * filelock.c (within_one_second): Now static.
b3dd38ab 3854 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3855
5df8f01b
PE
3856 * buffer.c (fix_overlays_before): Mark locals as initialized.
3857 (fix_start_end_in_overlays): Likewise. This function should be
3858 simplified by using pointers-to-pointers, but that's a different
3859 matter.
b1d876f1 3860 (switch_to_buffer_1): Now static.
8f54f30a
PE
3861 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3862 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3863
a70072c9 3864 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3865 Fix pointer signedness issue.
edced198
PE
3866 (sys_subshell): Mark local as volatile if checking for lint,
3867 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3868 (MAXPATHLEN): Define only if needed.
a70072c9 3869
a0977c44
PE
3870 * process.c (serial_open, serial_configure): Move decls from here ...
3871 * systty.h: ... to here, so that they can be checked.
3872
a884fdcc
PE
3873 * fns.c (get_random, seed_random): Move extern decls from here ...
3874 * lisp.h: ... to here, so that they can be checked.
3875
604efe86 3876 * sysdep.c (reset_io): Now static.
b8950c94 3877 (wait_for_termination_signal): Remove; unused.
604efe86 3878
38fc62d9
PE
3879 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3880 (copy_keymap_item, append_key, push_text_char_description):
3881 Now static.
1004a21a 3882 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3883 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3884 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3885 (describe_map_tree):
3886 Rename locals to avoid shadowing.
38fc62d9 3887
2f2650da
PE
3888 * keyboard.c: Declare functions static if they are not used elsewhere.
3889 (echo_char, echo_dash, cmd_error, top_level_2):
3890 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3891 (read_char, kbd_buffer_get_event, make_lispy_position):
3892 (make_lispy_event, make_lispy_movement, apply_modifiers):
3893 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3894 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3895 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3896 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3897 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3898
a053e86c 3899 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3900 (mark_kboards): Move decl here ...
3901 * alloc.c (mark_kboards): ... from here.
a053e86c 3902
4752793e
PE
3903 * lisp.h (force_auto_save_soon): New decl.
3904
74f10ca7 3905 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3906 (DEFINE_DUMMY_FUNCTION): New macro.
3907 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3908 Use it.
c03cd23f
PE
3909 (main): Add casts to avoid warnings
3910 if GCC considers string literals to be constants.
74f10ca7 3911
022e70d4
PE
3912 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3913
59d6fe83
PE
3914 * dbusbind.c: Pointer signedness fixes.
3915 (xd_signature, xd_append_arg, xd_initialize):
3916 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3917 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3918 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3919 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3920
78320123
PE
3921 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3922 if GCC considers string literals to be constants.
49cebcca 3923 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3924
35ac2a97
SM
39252011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3926
fb103ca9
SM
3927 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3928 (print_preprocess, print_object): New macro to fix last change.
3929
35ac2a97
SM
3930 * print.c (print_preprocess): Don't forget font objects.
3931
62973b41
JB
39322011-03-16 Juanma Barranquero <lekktu@gmail.com>
3933
3934 * emacs.c (USAGE3): Doc fixes.
3935
0e48bb22
AS
39362011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3937
3938 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3939 structure.
3940
7684e57b
JB
39412011-03-14 Juanma Barranquero <lekktu@gmail.com>
3942
3943 * lisp.h (VWindow_system, Qfile_name_history):
3944 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3945 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3946 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3947
3948 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3949 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3950
3951 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3952 * w32console.c (detect_input_pending, read_input_pending)
3953 (encode_terminal_code):
3954 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3955 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3956 (w32_system_caret_y, Qfile_name_history):
3957 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3958 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3959 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3960 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3961 * w32proc.c (Qlocal, report_file_error):
3962 * w32term.c (Vwindow_system, updating_frame):
3963 * w32uniscribe.c (initialized, uniscribe_font_driver):
3964 Remove unneeded extern declarations.
3965
2aa46d6c
CY
39662011-03-14 Chong Yidong <cyd@stupidchicken.com>
3967
c96bbc66 3968 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3969
cffc6f3b
CY
39702011-03-13 Chong Yidong <cyd@stupidchicken.com>
3971
3972 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3973 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3974 These macros can no longer be used for assignment.
3975
44f230aa
SM
3976 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3977 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3978 (record_buffer_markers, fetch_buffer_markers): New functions for
3979 recording and fetching special buffer markers.
3980 (set_buffer_internal_1, set_buffer_temp): Use them.
3981
3982 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3983
3984 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3985
3986 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3987 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3988
3989 * xdisp.c (hscroll_window_tree):
3990 (reconsider_clip_changes): Use PT instead of BUF_PT.
3991
d251f04b
EZ
39922011-03-13 Eli Zaretskii <eliz@gnu.org>
3993
3994 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3995 $(EMACS_ROOT)/lib/intprops.h.
3996
f0c77cd1
PE
39972011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3998
3eca4629
PE
3999 Fix more problems found by GCC 4.5.2's static checks.
4000
7c86ee98
PE
4001 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4002 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4003 (xg_free_frame_widgets): Make it clear that a local variable is
4004 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4005 (gdk_window_get_screen): Make it clear that this macro is needed
4006 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4007 (int_gtk_range_get_value): New function, which avoids a diagnostic
4008 from gcc -Wbad-function-cast.
4009 (xg_set_toolkit_scroll_bar_thumb): Use it.
4010 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4011 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4012 (get_utf8_string, xg_get_file_with_chooser):
4013 Rename locals to avoid shadowing.
4014 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4015
41729b81
PE
4016 * xgselect.c (xg_select): Remove unused var.
4017
f0c77cd1
PE
4018 * image.c (four_corners_best): Mark locals as initialized.
4019 (gif_load): Initialize transparent_p to zero (Bug#8238).
4020 Mark another local as initialized.
ec6cf4c6 4021 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4022
ce0ad53d 4023 * image.c (clear_image_cache): Now static.
d5d5a617 4024 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4025 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4026 (x_edge_detection): Remove unnecessary cast that
4027 gcc -Wbad-function-cast diagnoses.
2037898d 4028 (gif_load): Fix pointer signedness.
6ae141d6
PE
4029 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4030 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4031
33383987 40322011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4033
d32df629
PE
4034 Improve quality of tests for time stamp overflow.
4035 For example, without this patch (encode-time 0 0 0 1 1
4036 1152921504606846976) returns the obviously-bogus value (-948597
4037 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4038 reports time overflow. See
4039 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4040 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4041 * editfns.c: Include limits.h and intprops.h.
4042 (TIME_T_MIN, TIME_T_MAX): New macros.
4043 (time_overflow): Move earlier, to before first use.
4044 (hi_time, lo_time): New functions, for an accurate test for
4045 out-of-range times.
4046 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4047 (Fget_internal_run_time): Don't assume time_t fits in int.
4048 (make_time): Use list2 instead of Fcons twice.
4049 (Fdecode_time): More accurate test for out-of-range times.
4050 (check_tm_member): New function.
4051 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4052 (lisp_time_argument): Don't rely on undefined left-shift and
4053 right-shift behavior when checking for time stamp overflow.
8be6f318 4054
fe31d94c
PE
4055 * editfns.c (time_overflow): New function, refactoring common code.
4056 (Fformat_time_string, Fdecode_time, Fencode_time):
4057 (Fcurrent_time_string): Use it.
4058
8be6f318
PE
4059 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4060 * dired.c (make_time): Move to ...
4061 * editfns.c (make_time): ... here.
4062 * systime.h: Note the move.
4063
09d9db2c 40642011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4065
126bc0dc
YM
4066 * fringe.c (update_window_fringes): Remove unused variables.
4067
c47cbdfd
YM
4068 * unexmacosx.c (copy_data_segment): Also copy __got section.
4069 (Bug#8223)
4070
7ac80be9
EZ
40712011-03-12 Eli Zaretskii <eliz@gnu.org>
4072
c96bbc66 4073 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4074 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4075 Constify `char *' arguments and their references according to
4076 prototypes in tparam.h.
4077
ecb0f94d 4078 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4079
7ac80be9
EZ
4080 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4081 Adapt all references accordingly.
4082
4083 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4084
ef1fd07e
TT
40852011-03-11 Tom Tromey <tromey@redhat.com>
4086
4087 * buffer.c (syms_of_buffer): Remove obsolete comment.
4088
7ef4b50c
EZ
40892011-03-11 Eli Zaretskii <eliz@gnu.org>
4090
4091 * termhooks.h (encode_terminal_code): Declare prototype.
4092
4093 * msdos.c (encode_terminal_code): Don't declare prototype.
4094
4095 * term.c (encode_terminal_code): Now external again, used by
4096 w32console.c and msdos.c.
4097
44f230aa
SM
4098 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4099 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4100
4b1ec863 41012011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4102
1714f52b 4103 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4104
4b1ec863
PE
4105 * fringe.c (update_window_fringes): Mark locals as initialized
4106 (Bug#8227).
4107 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4108
524c7aa6
PE
4109 * alloc.c (mark_fringe_data): Move decl from here ...
4110 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4111 to check its interface.
4112 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4113
a5c0af81 4114 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4115 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4116 (fontset_font): Mark local as initialized.
a9a06e0b 4117 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4118
b4716021
PE
4119 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4120
811e9bac 4121 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4122 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4123 (x_own_selection, Fx_disown_selection_internal): Rename locals
4124 to avoid shadowing.
4125 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4126
7e3ab302
PE
4127 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4128 so that the caller can use some name other than gcpro1.
4129 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4130 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4131 (Fx_backspace_delete_keys_p):
4132 Use them to avoid shadowing, and rename vars to avoid shadowing.
4133 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4134 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4135 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4136 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4137 Remove unused locals.
7e3ab302
PE
4138 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4139 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4140 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4141 macros.
f78faa98 4142
e2b13473
PE
4143 * xterm.h (x_mouse_leave): New decl.
4144
77f23912
PE
4145 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4146 Remove unused functions.
cdf4ba58
PE
4147 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4148 (x_calc_absolute_position): Now static.
7411c686 4149 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4150 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4151 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4152 unless they are used.
38d0b34a
PE
4153 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4154 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4155 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4156 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4157 (x_error_catcher, x_connection_closed, x_error_handler):
4158 (x_error_quitter, xembed_send_message, x_iconify_frame):
4159 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4160 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4161 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4162
44f230aa
SM
4163 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4164 Rename or move locals to avoid shadowing.
6b463e58 4165 (tty_defined_color, merge_face_heights): Now static.
5967d051 4166 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4167 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4168 does not deduce is never used uninitialized.
73719eba
PE
4169 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4170 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4171
426994c3 4172 * terminal.c (store_terminal_param): Now static.
5489860b 4173
032f1620 4174 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4175 (set_frame_menubar): Remove unused local.
d4323972 4176 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4177 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4178 since they might point to immutable storage.
281585b0
PE
4179 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4180 since it's unused otherwise.
032f1620 4181
367c19e5 4182 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4183 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4184 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4185 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4186 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4187 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4188 does not deduce are never used uninitialized.
70739cbe 4189
07b48fa9
PE
4190 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4191
8868a238 4192 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4193 * window.c (window_loop, size_window):
4194 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4195
7e5cf297 4196 * window.c (display_buffer): Now static.
d6550a9f
PE
4197 (size_window): Mark variables that gcc -Wuninitialized
4198 does not deduce are never used uninitialized.
a586633d
PE
4199 * window.h (check_all_windows): New decl, to forestall
4200 gcc -Wmissing-prototypes diagnostic.
5b555da1 4201 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4202
f6095868
PE
4203 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4204 shadowing.
4205 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4206 Include <limits.h>.
4207 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4208 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4209 (load_charset_map): Mark variables that gcc -Wuninitialized
4210 does not deduce are never used uninitialized.
53df7c11 4211 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4212
f38b440c
PE
4213 * coding.c (coding_set_source, coding_set_destination):
4214 Use "else { /* comment */ }" rather than "else /* comment */;"
4215 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4216 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4217 a block, when the outer 'i' will do.
4218 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4219 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4220 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4221 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4222 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4223 Rename locals to avoid shadowing.
4224 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4225 * coding.c (emacs_mule_char, encode_invocation_designation):
4226 Now static, since they're not used elsewhere.
413bb2db 4227 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4228 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4229 (decode_coding_emacs_mule): Mark variables that gcc
4230 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4231 (detect_coding_iso_2022): Initialize a local variable that might
4232 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4233 this initialization is needed. (Bug#8211)
5f58e762
PE
4234 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4235 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4236 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4237 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4238 Remove unused macros.
f38b440c 4239
232b38b9 4240 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4241 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4242 * character.c (string_count_byte8): Likewise.
232b38b9 4243
fb90da1b
PE
4244 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4245 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4246
fb93dbc2
PE
4247 * chartab.c (copy_sub_char_table): Now static, since it's not used
4248 elsewhere.
5c156ace
PE
4249 (sub_char_table_ref_and_range, char_table_ref_and_range):
4250 Rename locals to avoid shadowing.
bbcd0949 4251 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4252
7d3b3862 4253 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4254 (BIDI_BOB): Remove unused macro.
7d3b3862 4255
6be7d3da
PE
4256 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4257 deduce are never used uninitialized.
c2ed9c8b 4258 * term.c (encode_terminal_code): Likewise.
6be7d3da 4259
75f8807f 4260 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4261
50938595
PE
4262 * tparam.h: New file.
4263 * term.c, tparam.h: Include it.
4264 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4265 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4266 Move these decls to tparam.h, and make them agree with what
4267 is actually in tparam.c. The previous trick of using incompatible
4268 decls in different modules does not conform to the C standard.
4269 All callers of tparam changed to use tparam's actual API.
4270 * tparam.c (tparam1, tparam, tgoto):
4271 Use const pointers where appropriate.
4272
fbceeba2
PE
4273 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4274 * cm.h (struct cm): Likewise.
4275 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4276 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4277 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4278 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4279 (turn_on_face, init_tty): Likewise.
4280 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4281
7f3f1250
PE
4282 * term.c (term_mouse_position): Rename local to avoid shadowing.
4283
e6ca6543
PE
4284 * alloc.c (mark_ttys): Move decl from here ...
4285 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4286
c40f8d15
AS
42872011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4288
4289 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4290
cfe0661d
JB
42912011-03-09 Juanma Barranquero <lekktu@gmail.com>
4292
4293 * search.c (compile_pattern_1): Remove argument regp, unused since
4294 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4295 (compile_pattern): Don't pass it.
4296
0afb4571
J
42972011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4298
4299 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4300 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4301 for ! HAVE_GTK3.
4302 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4303
4304 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4305
4306 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4307 gdk_window_get_screen, gdk_window_get_geometry,
4308 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4309 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4310 (xg_get_pixbuf_from_pixmap): New function.
4311 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4312 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4313 Call xg_get_pixbuf_from_pixmap instead of
4314 gdk_pixbuf_get_from_drawable.
4315 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4316 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4317 (xg_check_special_colors): Use GtkStyleContext and its functions
4318 for HAVE_GTK3.
4319 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4320 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4321 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4322 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4323 Call gtk_widget_get_preferred_size.
0afb4571
J
4324 (xg_frame_resized): gdk_window_get_geometry only takes 5
4325 parameters.
44f230aa
SM
4326 (xg_win_to_widget, xg_event_is_for_menubar):
4327 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4328 (xg_set_widget_bg): New function.
4329 (delete_cb): New function.
895009e1 4330 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4331 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4332 (xg_set_background_color): Call xg_set_widget_bg.
4333 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4334 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4335 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4336 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4337 if ! HAVE_GTK3.
4338 (update_frame_tool_bar): Call gtk_widget_hide.
4339 (xg_initialize): Use GDK_KEY_g.
4340
4341 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4342 if ! HAVE_GTK3
4343 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4344
4345 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4346 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4347 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4348
1c2cc4ef
JB
43492011-03-08 Juanma Barranquero <lekktu@gmail.com>
4350
4351 * w32xfns.c (select_palette): Check success of RealizePalette against
4352 GDI_ERROR, not zero.
4353
33383987 4354See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4355
4356;; Local Variables:
4357;; coding: utf-8
aac0c6e3
MR
4358;; End:
4359
33383987 4360 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4361
4362 This file is part of GNU Emacs.
4363
4364 GNU Emacs is free software: you can redistribute it and/or modify
4365 it under the terms of the GNU General Public License as published by
4366 the Free Software Foundation, either version 3 of the License, or
4367 (at your option) any later version.
4368
4369 GNU Emacs is distributed in the hope that it will be useful,
4370 but WITHOUT ANY WARRANTY; without even the implied warranty of
4371 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4372 GNU General Public License for more details.
4373
4374 You should have received a copy of the GNU General Public License
4375 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.