font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
16a97296
PE
12011-04-11 Paul Eggert <eggert@cs.ucla.edu>
2
92470028
PE
3 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5 was inaccessible from Lisp.
6 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8
244ed907
PE
9 alloc.c: Import and export fewer symbols, and remove unused items.
10 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11 is defined.
12 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13 it's not optimized away by whole-program optimization.
14 (message_enable_multibyte, free_misc): Remove.
15 (catchlist, handlerlist, mark_backtrace):
16 Declare only if BYTE_MARK_STACK.
17 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
18 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
19 (message_enable_multibyte): Remove decl.
20 (free_misc, interval_free_list, float_block, float_block_index):
21 (n_float_blocks, float_free_list, cons_block, cons_block_index):
22 (cons_free_list, last_marked_index):
23 Now static.
24 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
25 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
26 (mark_backtrace): Define only if BYTE_MARK_STACK.
27 * xdisp.c (message_enable_multibyte): Now static.
28
955cbe7b
PE
29 Declare Lisp_Object Q* variables to be 'static' if not exproted.
30 This makes it easier for human readers (and static analyzers)
31 to see whether these variables are used from other modules.
32 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
33 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
34 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
35 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
36 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
37 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
38 * xmenu.c, xselect.c:
39 Declare Q* vars static if they are not used in other modules.
40 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
41 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
42 Remove decls of unexported vars.
43 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
44
95c82688
PE
45 * lisp.h (DEFINE_FUNC): Make sname 'static'.
46
16a97296
PE
47 Make Emacs functions such as Fatom 'static' by default.
48 This makes it easier for human readers (and static analyzers)
49 to see whether these functions can be called from other modules.
50 DEFUN now defines a static function. To make the function external
51 so that it can be used in other C modules, use the new macro DEFUE.
52 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
53 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
54 static function definition. Use DEFUE if you want an extern one.
55 (DEFUE, INFUN): New macros.
56 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
57 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
58 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
59 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
60 Remove decls, since these functions are now static.
61 (Funintern, Fget_internal_run_time): New decls, since these functions
62 were already external.
95c82688 63
16a97296
PE
64 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
65 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
66 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
67 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
68 * keyboard.c, keymap.c, lread.c:
69 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
70 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
71 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
72 Mark functions with DEFUE instead of DEFUN,
73 if they are used in other modules.
74 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
75 decls for now-static functions.
76 * buffer.h (Fdelete_overlay): Remove decl.
77 * callproc.c (Fgetenv_internal): Mark as internal.
78 * composite.c (Fremove_list_of_text_properties): Remove decl.
79 (Fcomposition_get_gstring): New forward static decl.
80 * composite.h (Fcomposite_get_gstring): Remove decl.
81 * dired.c (Ffile_attributes): New forward static decl.
82 * doc.c (Fdocumntation_property): New forward static decl.
83 * eval.c (Ffetch_bytecode): New forward static decl.
84 (Funintern): Remove extern decl; now in .h file where it belongs.
85 * fileio.c (Fmake_symbolic_link): New forward static decl.
86 * image.c (Finit_image_library): New forward static decl.
87 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
88 * intervals.h (Fprevious_property_change):
89 (Fremove_list_of_text_properties): Remove decls.
90 * keyboard.c (Fthis_command_keys): Remove decl.
91 (Fcommand_execute): New forward static decl.
92 * keymap.c (Flookup_key): New forward static decl.
93 (Fcopy_keymap): Now static.
94 * keymap.h (Flookup_key): Remove decl.
95 * process.c (Fget_process): New forward static decl.
96 (Fprocess_datagram_address): Mark as internal.
97 * syntax.c (Fsyntax_table_p): New forward static decl.
98 (skip_chars): Remove duplicate decl.
99 * textprop.c (Fprevious_property_change): New forward static decl.
100 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
101 Now internal.
102 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
103 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
104
785bbd42
PE
1052011-04-10 Paul Eggert <eggert@cs.ucla.edu>
106
107 * editfns.c (Fformat): Remove unreachable code.
108
4073e537 1092011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 110
b2ded58d
PE
111 Fix more problems found by GCC 4.6.0's static checks.
112
7d66342c
PE
113 * xdisp.c (vmessage): Use a better test for character truncation.
114
bbf47d44
PE
115 * charset.c (load_charset_map): <, not <=, for optimization,
116 and to avoid potential problems with integer overflow.
9248994d 117 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 118 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 119 * editfns.c (Fformat): Likewise.
1e69125e 120 * syntax.c (skip_chars): Likewise.
3befa583 121
e3019616
PE
122 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
123 This also lets GCC 4.6.0 generate slightly better loop code.
124
becfa255
PE
125 * callint.c (Fcall_interactively): <, not <=, for optimization.
126 (Fcall_interactively): Count the number of arguments produced,
127 not the number of arguments given. This is simpler and lets GCC
128 4.6.0 generate slightly better code.
129
dae0cd48
PE
130 * ftfont.c: Distingish more carefully between FcChar8 and char.
131 The previous code passed unsigned char * to a functions like
132 strlen and xstrcasecmp that expect char *, which does not
133 conform to the C standard.
134 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
135 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
136 char * when the C standard requires it.
137
76032d70
PE
138 * keyboard.c (read_char): Remove unused var.
139
eb3f1cc8
PE
140 * eval.c: Port to Windows vsnprintf (Bug#8435).
141 Include <limits.h>.
142 (SIZE_MAX): Define if the headers do not.
143 (verror): Do not give up if vsnprintf returns a negative count.
144 Instead, grow the buffer. This ports to Windows vsnprintf, which
145 does not conform to C99. Problem reported by Eli Zaretskii.
146 Also, simplify the allocation scheme, by avoiding the need for
147 calling realloc, and removing the ALLOCATED variable.
148
70476b54
PE
149 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
150
12020a9e
PE
151 Remove invocations of doprnt, as Emacs now uses vsnprintf.
152 But keep the doprint source code for now, as we might revamp it
153 and use it again (Bug#8435).
ea6c7ae6
PE
154 * lisp.h (doprnt): Remove.
155 * Makefile.in (base_obj): Remove doprnt.o.
156 * deps.mk (doprnt.o): Remove.
157
5fdb398c
PE
158 error: Print 32- and 64-bit integers portably (Bug#8435).
159 Without this change, on typical 64-bit hosts error ("...%d...", N)
160 was used to print both 32- and 64-bit integers N, which relied on
161 undefined behavior.
162 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
163 New macro.
164 * lisp.h (error, verror): Mark as printf-like functions.
165 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
166 Report overflow in size calculations when allocating printf buffer.
167 Do not truncate output string at its first null byte.
168 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
169 Truncate the output at a character boundary, since vsnprintf does not
170 do that.
171 * charset.c (check_iso_charset_parameter): Convert internal
172 character to string before calling 'error', since %c now has the
173 printf meaning.
174 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
175 overflow when computing char to be passed to 'error'. Do not
176 pass Lisp_Object to 'error'; pass the integer instead.
177 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
178 formatted with plain %d.
179
b189fa66
PE
180 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
181
bff87ef0
PE
182 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
183
7e2cac20
PE
184 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
185
ce4d90b5
PE
186 * xterm.c (x_catch_errors): Remove duplicate declaration.
187
266c9547
PE
188 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
189
79c49ad2
PE
190 * xdisp.c, lisp.h (message_nolog): Remove; unused.
191
368f4090
JM
1922011-04-10 Jim Meyering <meyering@redhat.com>
193
194 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
195 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
196 return ssize_t not "int", and use size_t as the buffer length.
197 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
198 * gnutls.h: Update declarations.
199 * process.c (read_process_output): Use ssize_t, to match.
200 (send_process): Likewise.
201
a32d4040
CY
2022011-04-09 Chong Yidong <cyd@stupidchicken.com>
203
204 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
205
8546720e 2062011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 207
8546720e
GM
208 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
209 unsigned char, to match FcChar8 type definition.
aac0c6e3 210
8546720e
GM
211 * xterm.c (handle_one_xevent):
212 * xmenu.c (create_and_show_popup_menu):
213 * xselect.c (x_decline_selection_request)
214 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 215
a53e2e89
EZ
2162011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
217
218 Fix some uses of `int' instead of EMACS_INT.
219 * search.c (string_match_1, fast_string_match)
220 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
221 (scan_buffer, find_next_newline_no_quit)
222 (find_before_next_newline, search_command, Freplace_match)
223 (Fmatch_data): Make some `int' variables be EMACS_INT.
224
225 * xdisp.c (display_count_lines): 3rd argument and return value now
226 EMACS_INT. All callers changed.
227 (pint2hrstr): Last argument is now EMACS_INT.
228
229 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
230 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
231 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
232 (decode_coding_utf_16, decode_coding_emacs_mule)
233 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
234 (decode_coding_ccl, decode_coding_charset)
235 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
236 (decode_coding_iso_2022, decode_coding_emacs_mule)
237 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
238 <char_offset, last_offset>: Declare EMACS_INT.
239 (encode_coding_utf_8, encode_coding_utf_16)
240 (encode_coding_emacs_mule, encode_invocation_designation)
241 (encode_designation_at_bol, encode_coding_iso_2022)
242 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
243 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
244 Declare EMACS_INT.
245 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
246 (encode_invocation_designation): Last argument P_NCHARS is now
247 EMACS_INT.
248 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
249 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
250
251 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
252 All users changed.
253
254 * ccl.c (Fccl_execute_on_string): Declare some variables
255 EMACS_INT.
256
8546720e 2572011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
258
259 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
260
4e19a977
CS
2612011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
262
263 * process.c (Fformat_network_address): Doc fix.
264
87302331
R
2652011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
266
267 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
268
cbb59342
CY
2692011-04-08 Chong Yidong <cyd@stupidchicken.com>
270
271 * keyboard.c (read_char): Call Lisp function help-form-show,
272 instead of using internal_with_output_to_temp_buffer.
273 (Qhelp_form_show): New var.
e0d38eeb 274 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
275
276 * print.c (internal_with_output_to_temp_buffer): Function deleted.
277
278 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
279
e67a13ab
CY
2802011-04-06 Chong Yidong <cyd@stupidchicken.com>
281
282 * process.c (Flist_processes): Removed to Lisp.
283 (list_processes_1): Deleted.
284
973f782d
EZ
2852011-04-06 Eli Zaretskii <eliz@gnu.org>
286
7c106b1e
EZ
287 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
288
973f782d
EZ
289 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
290
41cf7d1a 2912011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 292
ca23cc88
PE
293 Fix more problems found by GCC 4.6.0's static checks.
294
f390e2d5
PE
295 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
296
42eea0d0
PE
297 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
298
b69769da 299 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 300
f9541e84
PE
301 * xdisp.c (vmessage): Mark as a printf-like function.
302
13841b55
PE
303 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
304
c136c10f
PE
305 * sound.c (sound_warning): Don't crash if arg contains a printf format.
306
5e2d4a30
PE
307 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
308 printf-like functions.
309 (tiff_load): Add casts to remove these marks before passing them
310 to system-supplied API.
311
583f48b9
PE
312 * eval.c (Fsignal): Remove excess argument to 'fatal'.
313
b25d760e
PE
314 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
315 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
316 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
317 directly, rather than having caller test rule sign. This avoids
318 some unnecessary tests.
319 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
320 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
321 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 322
bc7b6697 323 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 324 (xfont_open): Avoid unnecessary tests.
bc7b6697 325
27ccc379
PE
326 * composite.c (composition_gstring_put_cache): Use unsigned integer.
327
dcd5c89a
PE
328 * composite.h, composite.c (composition_gstring_put_cache):
329 Use EMACS_INT, not int, for length.
330
b13a45c6
PE
331 * composite.h (COMPOSITION_DECODE_REFS): New macro,
332 breaking out part of COMPOSITION_DECODE_RULE.
333 (COMPOSITION_DECODE_RULE): Use it.
334 * composite.c (get_composition_id): Remove unused local vars,
335 by using the new macro.
336
1e792e4d
PE
337 * textprop.c (set_text_properties_1): Change while to do-while,
338 since the condition is always true at first.
339
dc6c6455 340 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
341 (interval_deletion_adjustment): Return unsigned value.
342 All uses changed.
dc6c6455 343
aba7731a
PE
344 * process.c (list_processes_1, create_pty, read_process_output):
345 (exec_sentinel): Remove vars that were set but not used.
afd4052b 346 (create_pty): Remove unnecessary "volatile"s.
bc57d757 347 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 348 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 349 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 350
fdfc4bf3
PE
351 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
352
fca8fe46 353 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 354 (update_syntax_table): Use unsigned instead of int.
fca8fe46 355
06a0259a 356 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 357 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 358 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 359
e7b9e80f
PE
360 * print.c (print_error_message): Avoid int overflow.
361
56201685
PE
362 * font.c (font_list_entities): Redo for clarity,
363 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
364
78834453 365 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 366 (font_score): Avoid potential overflow in diff calculation.
78834453 367
0bc0b309 368 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 369 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 370
e610eaca
PE
371 * eval.c (funcall_lambda): Rename local to avoid shadowing.
372
b895abce
PE
373 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
374 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
375 can always succeed if overflow has undefined behavior.
376
1f1d9321 377 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 378 (wordify): Omit three unnecessary tests.
1f1d9321 379
c59478bc
PE
380 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
381 All callers changed. This avoids the need for an unused var.
382
79b73827
PE
383 * casefiddle.c (casify_region): Remove var that is set but not used.
384
a4db5dfe
PE
385 * dired.c (file_name_completion): Remove var that is set but not used.
386
43aae36e
PE
387 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
388
2a47c44d 389 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 390 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 391
a37c69bf
PE
392 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
393 Check for integer overflow on size calculations.
394
328ab8e7
PE
395 * buffer.c (Fprevious_overlay_change): Remove var that is set
396 but not used.
397
e5a2a5cb
PE
398 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
399 Remove vars that are set but not used.
8d84a6eb 400 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 401 (timer_check_2): Mark vars as initialized.
e5a2a5cb 402
a60e5f68
PE
403 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
404
f661cb61 405 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 406 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 407
f0397f5a
PE
408 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
409 that are set but not used.
410
8664db06 411 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 412 if XCreateBitmapFromData fails (Bug#8410).
8664db06 413
6abdaa4a
PE
414 * xselect.c (x_get_local_selection, x_handle_property_notify):
415 Remove vars that are set but not used.
416
0ce7538d 417 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 418 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 419
9ae848fc
PE
420 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
421 Remove var that is set but not used.
0b918413
PE
422 (scroll_bar_windows_size): Now size_t, not int.
423 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
424 Check for overflow.
9ae848fc 425
a5a62657
PE
426 * xfaces.c (realize_named_face): Remove vars that are set but not used.
427 (map_tty_color) [!defined MSDOS]: Likewise.
428
5c5cdd39
PE
429 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
430
66ebf983
PE
431 * coding.c: Remove vars that are set but not used.
432 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
433 All callers changed.
434 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
435 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
436 (decode_coding_charset): Remove vars that are set but not used.
437
1be4d761
PE
438 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
439 that is set but not used.
440
47553fa8
PE
441 * print.c (print_object): Remove var that is set but not used.
442
1f7196bf 443 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
444 The gnulib version avoids calling malloc in the usual case,
445 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
446 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
447 * filelock.c (current_lock_owner): Likewise.
448 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
449 * sysdep.c: Include allocator.h, careadlinkat.h.
450 (emacs_no_realloc_allocator): New static constant.
451 (emacs_readlink): New function.
fdb61804
PE
452 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
453 ../lib/careadlinkat.h.
d1fdcab7 454
f84c17c7
SM
4552011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
456
457 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
458 first non-nil return value).
459
ef3862ad
JD
4602011-04-03 Jan Djärv <jan.h.d@swipnet.se>
461
462 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
463 if not defined (Bug#8403).
464
376a7006
JB
4652011-04-02 Juanma Barranquero <lekktu@gmail.com>
466
467 * xdisp.c (display_count_lines): Remove parameter `start',
468 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
469 (get_char_face_and_encoding): Remove parameter `multibyte_p',
470 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
471 (fill_stretch_glyph_string): Remove parameters `row' and `area',
472 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
473 and thereabouts. All callers changed.
474 (get_per_char_metric): Remove parameter `f', unused since
475 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
476
6ca3801d
JM
4772011-04-02 Jim Meyering <meyering@redhat.com>
478
479 do not dereference NULL upon failed strdup
480 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
481 (ns_get_family): Likewise.
482
d8e2b5ba
JB
4832011-04-02 Juanma Barranquero <lekktu@gmail.com>
484
485 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
486
8c74fcbd
JD
4872011-04-02 Jan Djärv <jan.h.d@swipnet.se>
488
489 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
490 later (Bug#8403).
491
7200d79c
SM
4922011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
493
03408648 494 Add lexical binding.
7200d79c 495
03408648
SM
496 * window.c (Ftemp_output_buffer_show): New fun.
497 (Fsave_window_excursion):
498 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
499
500 * lread.c (lisp_file_lexically_bound_p): New function.
501 (Fload): Bind Qlexical_binding.
502 (readevalloop): Remove `evalfun' arg.
503 Bind Qinternal_interpreter_environment.
504 (Feval_buffer): Bind Qlexical_binding.
505 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
506 Mark as dynamic.
507 (syms_of_lread): Declare `lexical-binding'.
508
509 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
510
511 * keyboard.c (eval_dyn): New fun.
512 (menu_item_eval_property): Use it.
ca105506
SM
513
514 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 515
03408648
SM
516 * fns.c (concat, mapcar1): Accept byte-code-functions.
517
518 * eval.c (Fsetq): Handle lexical vars.
519 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
520 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
521 (FletX, Flet): Obey lexical binding.
522 (Fcommandp): Handle closures.
523 (Feval): New `lexical' arg.
524 (eval_sub): New function extracted from Feval. Use it almost
525 everywhere where Feval was used. Look up vars in lexical env.
526 Handle closures.
527 (Ffunctionp): Move from subr.el.
528 (Ffuncall): Handle closures.
529 (apply_lambda): Remove `eval_flags'.
530 (funcall_lambda): Handle closures and new byte-code-functions.
531 (Fspecial_variable_p): New function.
532 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
533 but without exporting it to Lisp.
23aba0ea 534
23aba0ea 535 * doc.c (Fdocumentation, store_function_docstring):
03408648 536 * data.c (Finteractive_form): Handle closures.
23aba0ea 537
03408648
SM
538 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
539 interactive spec.
ba83908c 540
03408648
SM
541 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
542 byte-codes.
543 (exec_byte_code): New function extracted from Fbyte_code to handle new
544 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 545
03408648 546 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 547
03408648 548 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 549
e2abce01
JB
5502011-03-31 Juanma Barranquero <lekktu@gmail.com>
551
552 * xdisp.c (redisplay_internal): Fix prototype.
553
63696a73 5542011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 555
63696a73
EZ
556 * xdisp.c (SCROLL_LIMIT): New macro.
557 (try_scrolling): Use it when setting scroll_limit. Limit
558 scrolling to 100 screen lines.
559 (redisplay_window): Even when falling back on "recentering",
560 position point in the window according to scroll-conservatively,
561 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
562
563 (try_scrolling): When point is above the window, allow searching
564 as far as scroll_max, or one screenful, to compute vertical
565 distance from PT to the scroll margin position. This prevents
566 try_scrolling from unnecessarily failing when
567 scroll-conservatively is set to a value slightly larger than the
568 window height. Clean up the case of PT below the margin at bottom
569 of window: scroll_max can no longer be INT_MAX. When aggressive
570 scrolling is in use, don't let point enter the opposite scroll
571 margin as result of the scroll.
572 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
573 threshold of 100 lines for never-recentering scrolling.
574
e4cc2dfc
JB
5752011-03-31 Juanma Barranquero <lekktu@gmail.com>
576
577 * dispextern.h (move_it_by_lines):
578 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
579 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
580 (message_log_check_duplicate): Remove parameters `prev_bol' and
581 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
582 (redisplay_internal): Remove parameter `preserve_echo_area',
583 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
584
585 * indent.c (Fvertical_motion):
586 * window.c (window_scroll_pixel_based, Frecenter):
587 Don't pass `need_y_p' to `move_it_by_lines'.
588
1c470562
SM
5892011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
590
44f230aa
SM
591 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
592 steal a few bits to be more compact.
593 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
594 Remove unneeded casts.
595
1c470562
SM
596 * bytecode.c (Fbyte_code): CAR and CDR can GC.
597
888adce9
ZK
5982011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
599
600 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
601 binding" message (bug#7967).
602
f838ed7b
PE
6032011-03-30 Paul Eggert <eggert@cs.ucla.edu>
604
77861b95
PE
605 Fix more problems found by GCC 4.6.0's static checks.
606
de6dbc14
PE
607 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
608 Remove unused local var.
609
f838ed7b
PE
610 * editfns.c (Fmessage_box): Remove unused local var.
611
792c7b2b
PE
612 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
613 (note_mode_line_or_margin_highlight, note_mouse_highlight):
614 Omit unused local vars.
c499e557 615 * window.c (shrink_windows): Omit unused local var.
b01a1c29 616 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
617 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
618 Omit unused local var.
619
ba0165e1
PE
620 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
621 Don't assume string length fits in int.
32ad8845 622 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 623 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 624
3c59b4c9
PE
625 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
626 instead of alloca (Bug#8344).
627
a3eed478 628 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 629 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 630
eb4d412d
PE
631 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
632
1658b401
PE
633 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
634 concerns.
635
636 * term.c (produce_glyphless_glyph): Remove unnecessary test.
637
638 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 639
9a2c6e05
PE
640 * keyboard.c (syms_of_keyboard): Use the same style as later
641 in this function when indexing through an array. This also
642 works around GCC bug 48267.
643
03d0a109
PE
644 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
645
44f730c8
PE
646 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
647
fe75f926
PE
648 * chartab.c (sub_char_table_ref_and_range): Redo for slight
649 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
650
ffa8c828
PE
651 * keyboard.c, keyboard.h (num_input_events): Now size_t.
652 This avoids undefined behavior on integer overflow, and is a bit
653 more convenient anyway since it is compared to a size_t variable.
654
c5101a77
PE
655 Variadic C functions now count arguments with size_t, not int.
656 This avoids an unnecessary limitation on 64-bit machines, which
657 caused (substring ...) to crash on large vectors (Bug#8344).
658 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
659 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 660 All variadic functions and their callers changed accordingly.
c5101a77
PE
661 (struct gcpro.nvars): Now size_t, not int. All uses changed.
662 * data.c (arith_driver, float_arith_driver): Likewise.
663 * editfns.c (general_insert_function): Likewise.
664 * eval.c (struct backtrace.nargs, interactive_p)
665 (internal_condition_case_n, run_hook_with_args, apply_lambda)
666 (funcall_lambda, mark_backtrace): Likewise.
667 * fns.c (concat): Likewise.
668 * frame.c (x_set_frame_parameters): Likewise.
669 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
670 0 if not found, not -1. All callers changed.
671
dd3f25f7
PE
672 * alloc.c (garbage_collect): Don't assume stack size fits in int.
673 (stack_copy_size): Now size_t, not int.
674 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
675
461c2ab9
JB
6762011-03-28 Juanma Barranquero <lekktu@gmail.com>
677
678 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
679 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
680 All callers changed.
681
682 * lisp.h (multibyte_char_to_unibyte):
683 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
684 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
685 * character.h (CHAR_TO_BYTE8):
686 * cmds.c (internal_self_insert):
687 * editfns.c (general_insert_function):
688 * keymap.c (push_key_description):
689 * search.c (Freplace_match):
690 * xdisp.c (message_dolog, set_message_1): All callers changed.
691
f6d62986
SM
6922011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
693
694 * keyboard.c (safe_run_hook_funcall): New function.
695 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
696 don't set the hook to nil, but remove the offending function instead.
697 (Qcommand_hook_internal): Remove, unused.
698 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
699 Vcommand_hook_internal.
700
701 * eval.c (enum run_hooks_condition): Remove.
702 (funcall_nil, funcall_not): New functions.
703 (run_hook_with_args): Call each function through a `funcall' argument.
704 Remove `cond' argument, now redundant.
705 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
706 (Frun_hook_with_args_until_failure): Adjust accordingly.
707 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
708
1db5b1ad
JB
7092011-03-28 Juanma Barranquero <lekktu@gmail.com>
710
711 * dispextern.h (string_buffer_position): Remove declaration.
712
713 * print.c (strout): Remove parameter `multibyte', unused since
714 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
715
716 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
717 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
718 All callers changed.
719
720 * w32.c (_wsa_errlist): Use braces for struct initializers.
721
722 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
723 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
724 All callers changed.
725 (string_buffer_position): Likewise. Also, make static (it's never
726 used outside xdisp.c).
727 (cursor_row_p): Remove parameter `w', unused since
728 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
729 (decode_mode_spec): Remove parameter `precision', introduced during
730 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
731 All callers changed.
732
5ffb62aa
JD
7332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
734
735 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
736
461c2ab9 7372011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
738
739 * nsterm.m (ns_menu_bar_is_hidden): New variable.
740 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
741 (ns_update_auto_hide_menu_bar): New functions.
742 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
743 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
744 ns_constrain_all_frames.
745 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
746 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
747
5c380ffb
JD
7482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
749
750 * nsmenu.m (runDialogAt): Remove argument to timer_check.
751
9af30bdf
GM
7522011-03-27 Glenn Morris <rgm@gnu.org>
753
754 * syssignal.h: Replace RETSIGTYPE with void.
755 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
756 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
757 Replace SIGTYPE with void everywhere.
758 * s/usg5-4-common.h (SIGTYPE): Remove definition.
759 * s/template.h (SIGTYPE): Remove commented out definition.
760
e2abce01
JB
7612011-03-26 Eli Zaretskii <eliz@gnu.org>
762
763 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
764 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
765
f868cd8a
JB
7662011-03-26 Juanma Barranquero <lekktu@gmail.com>
767
59eb0929
JB
768 * w32.c (read_unc_volume): Use parameter `henum', instead of
769 global variable `wget_enum_handle'.
770
771 * keymap.c (describe_vector): Remove parameters `indices' and
772 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
773 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
774
f868cd8a
JB
775 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
776
777 * keyboard.c (timer_check): Remove parameter `do_it_now',
778 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
779 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
780 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
781
782 * keyboard.c (read_char):
783 * w32menu.c (w32_menu_display_help):
784 * xmenu.c (show_help_event, menu_help_callback):
785 Adjust calls to `show_help_echo'.
786
787 * gtkutil.c (xg_maybe_add_timer):
788 * keyboard.c (readable_events):
789 * process.c (wait_reading_process_output):
790 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
791
792 * insdel.c (adjust_markers_gap_motion):
793 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
794 (gap_left, gap_right): Don't call it.
795
2ecf6fdb
CY
7962011-03-25 Chong Yidong <cyd@stupidchicken.com>
797
798 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
799 incurred during fontification.
800
6b1f9ba4
JB
8012011-03-25 Juanma Barranquero <lekktu@gmail.com>
802
803 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
804 (DEFVAR_PER_BUFFER): Don't pass it.
805
806 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
807 (scrolling_window): Don't pass it.
808
0f4a96b5
JB
8092011-03-25 Juanma Barranquero <lekktu@gmail.com>
810
811 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
812
813 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
814 and `suffix'.
815 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
816 of variables specific to SELinux and computation of `encoded_absname'.
817
818 * image.c (XPutPixel): Remove unused variable `height'.
819
820 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
821
822 * unexw32.c (get_section_info): Remove unused variable `section'.
823
824 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
825 (system_process_attributes): Remove unused variable `sess'.
826 (sys_read): Remove unused variable `err'.
827
828 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
829 (w32_wnd_proc): Remove unused variable `isdead'.
830 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
831 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
832 (x_create_tip_frame): Remove unused variable `tem'.
833
834 * w32inevt.c (w32_console_read_socket):
835 Remove unused variable `no_events'.
836
837 * w32term.c (x_draw_composite_glyph_string_foreground):
838 Remove unused variable `width'.
839
1149507c
JB
8402011-03-24 Juanma Barranquero <lekktu@gmail.com>
841
842 * w32term.c (x_set_glyph_string_clipping):
843 Don't pass uninitialized region to CombineRgn.
844
9c88f339
JB
8452011-03-23 Juanma Barranquero <lekktu@gmail.com>
846
847 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
848 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
849 (Fx_close_connection): Remove unused variable `i'.
850
851 * w32font.c (w32font_draw): Return number of glyphs.
852 (w32font_open_internal): Remove unused variable `i'.
853 (w32font_driver): Add missing initializer.
854
855 * w32menu.c (utf8to16): Remove unused variable `utf16'.
856 (fill_in_menu): Remove unused variable `items_added'.
857
858 * w32term.c (last_mouse_press_frame): Remove static global variable.
859 (w32_clip_to_row): Remove unused variable `f'.
860 (x_delete_terminal): Remove unused variable `i'.
861
862 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
863 (NOTHING): Remove unused static global variable.
864 (uniscribe_check_otf): Remove unused variable `table'.
865 (uniscribe_font_driver): Add missing initializers.
866
dee091a3
JD
8672011-03-23 Julien Danjou <julien@danjou.info>
868
869 * term.c (Fsuspend_tty, Fresume_tty):
870 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
871 * window.c (temp_output_buffer_show):
872 * insdel.c (signal_before_change):
873 * frame.c (Fhandle_switch_frame):
874 * fileio.c (Fdo_auto_save):
875 * emacs.c (Fkill_emacs):
876 * editfns.c (save_excursion_restore):
877 * cmds.c (internal_self_insert):
878 * callint.c (Fcall_interactively):
879 * buffer.c (Fkill_all_local_variables):
880 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
881 Use Frun_hooks.
0f4a96b5 882 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
883 unconditionnaly since it does the check itself.
884
2c520ab5 8852011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 886
c9c49752
PE
887 Fix more problems found by GCC 4.5.2's static checks.
888
8abc3f12
PE
889 * coding.c (encode_coding_raw_text): Avoid unnecessary test
890 the first time through the loop, since we know p0 < p1 then.
891 This also avoids a gcc -Wstrict-overflow warning.
892
a2d26660
PE
893 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
894 leading to a memory leak, possible in functions like
895 load_charset_map_from_file that can allocate an unbounded number
b12ef411 896 of objects (Bug#8318).
a2d26660 897
916c72e9
PE
898 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
899 that could (at least in theory) be that large.
900
19ab8a18
PE
901 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
902 This is less likely to overflow, and avoids undefined behavior if
903 overflow does occur. All callers changed. Use strtoul to scan
904 for the unsigned long integer.
b7cbbd6f
PE
905 (pint2hrstr): Simplify and tune code slightly.
906 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 907
f0641eff
PE
908 * scroll.c (do_scrolling): Work around GCC bug 48228.
909 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
910
7f650bb9
PE
911 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
912 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
913 (validate_x_resource_name): Simplify count usage.
914 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 915
37dd57d1
PE
916 * fileio.c (Fcopy_file): Report error if fchown or fchmod
917 fail (Bug#8306).
81e56e61 918
699979fc 919 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 920
401bf9b4
PE
921 * process.c (Fmake_network_process): Use socklen_t, not int,
922 where POSIX says socklen_t is required in portable programs.
923 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 924 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
925 (Fmake_network_process, server_accept_connection):
926 (wait_reading_process_output, read_process_output):
927 Likewise.
928
b93aacde
PE
929 * process.c: Rename or move locals to avoid shadowing.
930 (list_processes_1, Fmake_network_process):
931 (read_process_output_error_handler, exec_sentinel_error_handler):
932 Rename or move locals.
4dc343ee 933 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 934 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 935 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 936 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 937 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 938
af8a867c 939 Make tparam.h and terminfo.c consistent.
44f230aa
SM
940 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
941 Include tparam.h instead, since it declares them.
af8a867c
PE
942 * cm.h (PC): Remove extern decl; tparam.h now does this.
943 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
944 * terminfo.c: Include tparam.h, to check interfaces.
945 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
946 (tparam): Adjust signature to match interface in tparam.h;
947 this removes some undefined behavior. Check that outstring and len
948 are zero, which they always are with Emacs.
949 * tparam.h (PC, BC, UP): New extern decls.
950
0248044d 951 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 952 (xftfont_open): Rename locals to avoid shadowing.
0248044d 953
8ff096c1 954 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
955 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
956 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 957 (ftfont_list): Remove unused local.
49eaafba
PE
958 (get_adstyle_property, ftfont_pattern_entity):
959 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
960 Rename locals to avoid shadowing.
8ff096c1 961
e2be39f6
PE
962 * xfont.c (xfont_list_family): Mark var as initialized.
963
c9735e30
PE
964 * xml.c (make_dom): Now static.
965
8f5201ae
PE
966 * composite.c (composition_compute_stop_pos): Rename local to
967 avoid shadowing.
b246f932
PE
968 (composition_reseat_it): Remove unused locals.
969 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 970 (composition_update_it): Mark var as initialized.
11b61122
PE
971 (find_automatic_composition): Mark vars as initialized,
972 with a FIXME (Bug#8290).
8f5201ae 973
760fbc2c
PE
974 character.h: Rename locals to avoid shadowing.
975 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
976 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
977 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
978 (BUF_DEC_POS): Be more systematic about renaming local temporaries
979 to avoid shadowing.
980
ff08eb85
PE
981 * textprop.c (property_change_between_p): Remove; unused.
982
fc7bf025
PE
983 * intervals.c (interval_start_pos): Now static.
984
235d7abc
PE
985 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
986
44f230aa
SM
987 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
988 Rename locals to avoid shadowing.
3e7d6594 989
50060332
PE
990 * sound.c (wav_play, au_play, Fplay_sound_internal):
991 Fix pointer signedness.
d01f234b 992 (alsa_choose_format): Remove unused local var.
c83b8872
PE
993 (wav_play): Initialize a variable to 0, to prevent undefined
994 behavior (Bug#8278).
50060332 995
c4fc4e30
PE
996 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
997
918436ed
PE
998 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
999
c939f91b
PE
1000 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1001 clobbering (Bug#8298).
b9c7f648
PE
1002 * sysdep.c (sys_subshell): Likewise.
1003 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1004
6bd8c144
PE
1005 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1006 This should get cleaned up, so that child_setup has the
1007 same signature on all platforms.
1008
7710357c 1009 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1010 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1011
c59da222
CY
10122011-03-22 Chong Yidong <cyd@stupidchicken.com>
1013
1014 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1015 not to be necessary, and produces flickering.
1016
66b87493
GM
10172011-03-20 Glenn Morris <rgm@gnu.org>
1018
1019 * config.in: Remove file.
1020
45b6f6d5
JB
10212011-03-20 Juanma Barranquero <lekktu@gmail.com>
1022
1023 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1024 are now in src/globals.h.
1025 (syms_of_minibuf): Remove spurious & from previous change.
1026
3ec03f7e
LL
10272011-03-20 Leo <sdl.web@gmail.com>
1028
1029 * minibuf.c (completing-read-function): New variable.
1030 (completing-read-default): Rename from completing-read.
1031 (completing-read): Call completing-read-function.
1032
b14e3e21
CY
10332011-03-19 Juanma Barranquero <lekktu@gmail.com>
1034
1035 * xfaces.c (Fx_load_color_file):
1036 Read color file from absolute filename (bug#8250).
1037
f2b726e6
JB
10382011-03-19 Juanma Barranquero <lekktu@gmail.com>
1039
1040 * makefile.w32-in: Update dependencies.
1041
09f6ff02
EZ
10422011-03-17 Eli Zaretskii <eliz@gnu.org>
1043
1044 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1045
29a6015a
PE
10462011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1047
a3a6c54e
PE
1048 Fix more problems found by GCC 4.5.2's static checks.
1049
b766f867
PE
1050 * process.c (make_serial_process_unwind, send_process_trap):
1051 (sigchld_handler): Now static.
1052
be02381c
PE
1053 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1054 That way, the code declares only the vars that it needs.
1055 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1056 * s/cygwin.h (PTY_ITERATION): Likewise.
1057 * s/darwin.h (PTY_ITERATION): Likewise.
1058 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1059
57048744
PE
1060 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1061 * process.c (allocate_pty): Don't declare stb unless it's needed.
1062
7914961c 1063 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1064 (CONSTANTLIM): Remove; unused.
1065 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1066 Define only if needed.
7914961c 1067
b3967b18
PE
1068 * unexelf.c (unexec): Name an expression,
1069 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1070 Use a different way to cause a compilation error if anyone uses
1071 n rather than nn, a way that does not involve shadowing.
73366a00 1072 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1073
29a6015a
PE
1074 * deps.mk (unexalpha.o): Remove; unused.
1075
43cfc33e 1076 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1077 * unexec.h: New file.
ce701a33
PE
1078 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1079 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1080 Depend on unexec.h.
1081 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1082 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1083 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1084 Change as necessary to match prototype in unexec.h.
ce701a33 1085
01f44d5a
PE
1086 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1087 shadowing.
4f63c6bb 1088 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1089
a6670b0b
PE
1090 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1091 Rename locals to avoid shadowing.
1092
cef2010d 1093 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1094 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1095
d4d7173a
PE
1096 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1097
f08b802a
PE
1098 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1099 warning when compiling print.c.
1100
3ddb0639
PE
1101 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1102 instead of using an uninitialized var.
5ad03b97 1103 (font_sort_entities): Mark var as initialized.
3ddb0639 1104
170a2692
PE
1105 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1106
e663c700
PE
1107 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1108 pointers to constants.
89bc529a 1109 (font_parse_fcname): Remove unused vars.
7b81e2d0 1110 (font_delete_unmatched): Now static.
ea838e10 1111 (font_get_spec): Remove; unused.
13a547c6
PE
1112 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1113 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1114 Rename or move locals to avoid shadowing.
e663c700 1115
2a80c887 1116 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1117 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1118
1384fa33 1119 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1120 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1121
8b2c52e9
PE
1122 * alloc.c (mark_backtrace): Move decl from here ...
1123 * lisp.h: ... to here, so that it can be checked.
1124
475545b5 1125 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1126 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1127 (lisp_indirect_variable): Name an expression,
1128 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1129 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1130
b1349114 1131 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1132 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1133 Use const pointer when appropriate.
b1349114 1134
a2928364
PE
1135 * lisp.h (get_system_name, get_operating_system_release):
1136 Move decls here, to check interfaces.
1137 * process.c (get_operating_system_release): Move decl to lisp.h.
1138 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1139 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1140 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1141 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1142 (Fformat_time_string, Fencode_time, Finsert_char):
1143 (Ftranslate_region_internal, Fformat):
1144 Rename or remove local vars to avoid shadowing.
9710023e 1145 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1146
a415e694
PE
1147 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1148 avoid shadowing.
1149
8ef4622d
PE
1150 * lisp.h (eassert): Check that the argument compiles, even if
1151 ENABLE_CHECKING is not defined.
1152
946f9a5b
PE
1153 * data.c (Findirect_variable): Name an expression, to avoid
1154 gcc -Wbad-function-cast warning.
112396d6 1155 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1156 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1157 (Fmake_variable_buffer_local, Fmake_local_variable):
1158 Mark variables as initialized.
52746918 1159 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1160
e5aab7e7 1161 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1162 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1163 Rename locals to avoid shadowing.
dff45157
PE
1164 (mark_stack): Move local variables into the #ifdef region where
1165 they're used.
7bc26fdb
PE
1166 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1167 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1168 needed otherwise.
1169 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1170 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1171 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1172
e5aab7e7
PE
1173 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1174 avoids undefined behavior in theory.
1175
4da60324
PE
1176 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1177
88043301
PE
1178 Use functions, not macros, for up- and down-casing (Bug#8254).
1179 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1180 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1181 to use the following functions instead of these macros.
1182 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1183 EMACS_INT, since callers assume the returned value fits in int.
1184 (upcase1): Likewise, for UPCASE_TABLE.
1185 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1186 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1187 the race-condition problem in the old DOWNCASE.
88043301 1188
19ed5445
PE
1189 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1190 Rename locals to avoid shadowing.
1191 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1192 (regex_compile, re_search_2, re_match_2_internal):
1193 Remove unused local vars.
952db0d7
PE
1194 (FREE_VAR): Rewrite so as not to use empty "else",
1195 which gcc can warn about.
da053e48 1196 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1197 (RETALLOC_IF): Define only if needed.
1198 (WORDCHAR_P): Likewise. This one is never needed, but is used
1199 only in a comment talking about a compiler bug, so put inside
1200 the #if 0 of that comment.
1201 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1202 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1203 Remove; unused.
19ed5445 1204
1f3561e4 1205 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1206 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1207 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1208
ded6f8f7
PE
1209 * search.c (simple_search): Remove unused var.
1210
dbd37a95
PE
1211 * dired.c (compile_pattern): Move decl from here ...
1212 * lisp.h: ... to here, so that it can be checked.
1213 (struct re_registers): New forward decl.
1214
7e47afad
PE
1215 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1216
85f24f61
PE
1217 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1218 All uses changed.
1219 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1220 Rename locals to avoid shadowing.
5671df8f 1221 (Fvertical_motion): Mark locals as initialized.
85f24f61 1222
181aa2be 1223 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1224 (casify_region): Mark local as initialized.
181aa2be 1225
930d429c
PE
1226 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1227
7082eac6
PE
1228 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1229 New macros, so that the caller can use some names other than
1230 gcpro1, gcpro2, etc.
1231 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1232 of the new macros.
1233 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1234 argument, for consistency with GCPRO2_VAR, etc: it is now the
1235 prefix of the variable, not the variable itself. All uses
1236 changed.
38b2c076
PE
1237 * dired.c (directory_files_internal, file_name_completion):
1238 Rename locals to avoid shadowing.
1239
15206ed9
PE
1240 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1241 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1242 dired.c's scmp function, had undefined behavior.
1243 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1244 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1245 * buffer.h: ... to here, because these macros use current_buffer,
1246 and the new implementation with inline functions needs to have
1247 current_buffer in scope now, rather than later when the macros
1248 are used.
1249 (downcase, upcase1): New static inline functions.
1250 (DOWNCASE, UPCASE1): Reimplement using these functions.
1251 This avoids undefined behavior in expressions like
1252 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1253 from race conditions in accessing the global variables
1254 case_temp1 and case_temp2.
1255 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1256 * lisp.h (case_temp1, case_temp2): Remove their decls.
1257 * character.h (ASCII_CHAR_P): Move from here ...
1258 * lisp.h: ... to here, so that the inline functions mentioned
1259 above can use them.
1260
4a6bea26
PE
1261 * dired.c (directory_files_internal_unwind): Now static.
1262
f14b7e14
PE
1263 * fileio.c (file_name_as_directory, directory_file_name):
1264 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1265 Now static.
2893f146
PE
1266 (file_name_as_directory): Use const pointers when appropriate.
1267 (Fexpand_file_name): Likewise. In particular, newdir might
1268 point at constant storage, so make it a const pointer.
fd4ead52 1269 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1270 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1271 signedness issues.
f839df0c
PE
1272 (Fset_file_times, Finsert_file_contents, auto_save_error):
1273 Rename locals to avoid shadowing.
f14b7e14 1274
5716756e 1275 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1276 (Ftry_completion, Fall_completions): Rename or remove locals
1277 to avoid shadowing.
5716756e 1278
b4c3046a
PE
1279 * marker.c (bytepos_to_charpos): Remove; unused.
1280
b45db522
PE
1281 * lisp.h (verify_bytepos, count_markers): New decls,
1282 so that gcc does not warn that these functions aren't declared.
1283
85876d07
PE
1284 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1285 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1286 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1287 (copy_text): Remove unused local var.
85876d07 1288
03d78a21 1289 * filelock.c (within_one_second): Now static.
b3dd38ab 1290 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1291
5df8f01b
PE
1292 * buffer.c (fix_overlays_before): Mark locals as initialized.
1293 (fix_start_end_in_overlays): Likewise. This function should be
1294 simplified by using pointers-to-pointers, but that's a different
1295 matter.
b1d876f1 1296 (switch_to_buffer_1): Now static.
8f54f30a
PE
1297 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1298 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1299
a70072c9 1300 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1301 Fix pointer signedness issue.
edced198
PE
1302 (sys_subshell): Mark local as volatile if checking for lint,
1303 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1304 (MAXPATHLEN): Define only if needed.
a70072c9 1305
a0977c44
PE
1306 * process.c (serial_open, serial_configure): Move decls from here ...
1307 * systty.h: ... to here, so that they can be checked.
1308
a884fdcc
PE
1309 * fns.c (get_random, seed_random): Move extern decls from here ...
1310 * lisp.h: ... to here, so that they can be checked.
1311
604efe86 1312 * sysdep.c (reset_io): Now static.
b8950c94 1313 (wait_for_termination_signal): Remove; unused.
604efe86 1314
38fc62d9
PE
1315 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1316 (copy_keymap_item, append_key, push_text_char_description):
1317 Now static.
1004a21a 1318 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1319 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1320 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1321 (describe_map_tree):
1322 Rename locals to avoid shadowing.
38fc62d9 1323
2f2650da
PE
1324 * keyboard.c: Declare functions static if they are not used elsewhere.
1325 (echo_char, echo_dash, cmd_error, top_level_2):
1326 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1327 (read_char, kbd_buffer_get_event, make_lispy_position):
1328 (make_lispy_event, make_lispy_movement, apply_modifiers):
1329 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1330 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1331 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1332 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1333 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1334
a053e86c 1335 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1336 (mark_kboards): Move decl here ...
1337 * alloc.c (mark_kboards): ... from here.
a053e86c 1338
4752793e
PE
1339 * lisp.h (force_auto_save_soon): New decl.
1340
74f10ca7 1341 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1342 (DEFINE_DUMMY_FUNCTION): New macro.
1343 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1344 Use it.
c03cd23f
PE
1345 (main): Add casts to avoid warnings
1346 if GCC considers string literals to be constants.
74f10ca7 1347
022e70d4
PE
1348 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1349
59d6fe83
PE
1350 * dbusbind.c: Pointer signedness fixes.
1351 (xd_signature, xd_append_arg, xd_initialize):
1352 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1353 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1354 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1355 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1356
78320123
PE
1357 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1358 if GCC considers string literals to be constants.
49cebcca 1359 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1360
35ac2a97
SM
13612011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1362
fb103ca9
SM
1363 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1364 (print_preprocess, print_object): New macro to fix last change.
1365
35ac2a97
SM
1366 * print.c (print_preprocess): Don't forget font objects.
1367
62973b41
JB
13682011-03-16 Juanma Barranquero <lekktu@gmail.com>
1369
1370 * emacs.c (USAGE3): Doc fixes.
1371
0e48bb22
AS
13722011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1373
1374 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1375 structure.
1376
7684e57b
JB
13772011-03-14 Juanma Barranquero <lekktu@gmail.com>
1378
1379 * lisp.h (VWindow_system, Qfile_name_history):
1380 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1381 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1382 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1383
1384 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1385 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1386
1387 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1388 * w32console.c (detect_input_pending, read_input_pending)
1389 (encode_terminal_code):
1390 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1391 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1392 (w32_system_caret_y, Qfile_name_history):
1393 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1394 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1395 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1396 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1397 * w32proc.c (Qlocal, report_file_error):
1398 * w32term.c (Vwindow_system, updating_frame):
1399 * w32uniscribe.c (initialized, uniscribe_font_driver):
1400 Remove unneeded extern declarations.
1401
2aa46d6c
CY
14022011-03-14 Chong Yidong <cyd@stupidchicken.com>
1403
c96bbc66 1404 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1405
cffc6f3b
CY
14062011-03-13 Chong Yidong <cyd@stupidchicken.com>
1407
1408 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1409 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1410 These macros can no longer be used for assignment.
1411
44f230aa
SM
1412 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1413 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1414 (record_buffer_markers, fetch_buffer_markers): New functions for
1415 recording and fetching special buffer markers.
1416 (set_buffer_internal_1, set_buffer_temp): Use them.
1417
1418 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1419
1420 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1421
1422 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1423 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1424
1425 * xdisp.c (hscroll_window_tree):
1426 (reconsider_clip_changes): Use PT instead of BUF_PT.
1427
d251f04b
EZ
14282011-03-13 Eli Zaretskii <eliz@gnu.org>
1429
1430 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1431 $(EMACS_ROOT)/lib/intprops.h.
1432
f0c77cd1
PE
14332011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1434
3eca4629
PE
1435 Fix more problems found by GCC 4.5.2's static checks.
1436
7c86ee98
PE
1437 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1438 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1439 (xg_free_frame_widgets): Make it clear that a local variable is
1440 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1441 (gdk_window_get_screen): Make it clear that this macro is needed
1442 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1443 (int_gtk_range_get_value): New function, which avoids a diagnostic
1444 from gcc -Wbad-function-cast.
1445 (xg_set_toolkit_scroll_bar_thumb): Use it.
1446 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1447 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1448 (get_utf8_string, xg_get_file_with_chooser):
1449 Rename locals to avoid shadowing.
1450 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1451
41729b81
PE
1452 * xgselect.c (xg_select): Remove unused var.
1453
f0c77cd1
PE
1454 * image.c (four_corners_best): Mark locals as initialized.
1455 (gif_load): Initialize transparent_p to zero (Bug#8238).
1456 Mark another local as initialized.
ec6cf4c6 1457 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1458
ce0ad53d 1459 * image.c (clear_image_cache): Now static.
d5d5a617 1460 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1461 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1462 (x_edge_detection): Remove unnecessary cast that
1463 gcc -Wbad-function-cast diagnoses.
2037898d 1464 (gif_load): Fix pointer signedness.
6ae141d6
PE
1465 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1466 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1467
33383987 14682011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1469
d32df629
PE
1470 Improve quality of tests for time stamp overflow.
1471 For example, without this patch (encode-time 0 0 0 1 1
1472 1152921504606846976) returns the obviously-bogus value (-948597
1473 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1474 reports time overflow. See
1475 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1476 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1477 * editfns.c: Include limits.h and intprops.h.
1478 (TIME_T_MIN, TIME_T_MAX): New macros.
1479 (time_overflow): Move earlier, to before first use.
1480 (hi_time, lo_time): New functions, for an accurate test for
1481 out-of-range times.
1482 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1483 (Fget_internal_run_time): Don't assume time_t fits in int.
1484 (make_time): Use list2 instead of Fcons twice.
1485 (Fdecode_time): More accurate test for out-of-range times.
1486 (check_tm_member): New function.
1487 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1488 (lisp_time_argument): Don't rely on undefined left-shift and
1489 right-shift behavior when checking for time stamp overflow.
8be6f318 1490
fe31d94c
PE
1491 * editfns.c (time_overflow): New function, refactoring common code.
1492 (Fformat_time_string, Fdecode_time, Fencode_time):
1493 (Fcurrent_time_string): Use it.
1494
8be6f318
PE
1495 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1496 * dired.c (make_time): Move to ...
1497 * editfns.c (make_time): ... here.
1498 * systime.h: Note the move.
1499
09d9db2c 15002011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1501
126bc0dc
YM
1502 * fringe.c (update_window_fringes): Remove unused variables.
1503
c47cbdfd
YM
1504 * unexmacosx.c (copy_data_segment): Also copy __got section.
1505 (Bug#8223)
1506
7ac80be9
EZ
15072011-03-12 Eli Zaretskii <eliz@gnu.org>
1508
c96bbc66 1509 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1510 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1511 Constify `char *' arguments and their references according to
1512 prototypes in tparam.h.
1513
ecb0f94d 1514 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1515
7ac80be9
EZ
1516 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1517 Adapt all references accordingly.
1518
1519 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1520
ef1fd07e
TT
15212011-03-11 Tom Tromey <tromey@redhat.com>
1522
1523 * buffer.c (syms_of_buffer): Remove obsolete comment.
1524
7ef4b50c
EZ
15252011-03-11 Eli Zaretskii <eliz@gnu.org>
1526
1527 * termhooks.h (encode_terminal_code): Declare prototype.
1528
1529 * msdos.c (encode_terminal_code): Don't declare prototype.
1530
1531 * term.c (encode_terminal_code): Now external again, used by
1532 w32console.c and msdos.c.
1533
44f230aa
SM
1534 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1535 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1536
4b1ec863 15372011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1538
1714f52b 1539 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1540
4b1ec863
PE
1541 * fringe.c (update_window_fringes): Mark locals as initialized
1542 (Bug#8227).
1543 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1544
524c7aa6
PE
1545 * alloc.c (mark_fringe_data): Move decl from here ...
1546 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1547 to check its interface.
1548 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1549
a5c0af81 1550 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1551 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1552 (fontset_font): Mark local as initialized.
a9a06e0b 1553 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1554
b4716021
PE
1555 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1556
811e9bac 1557 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1558 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1559 (x_own_selection, Fx_disown_selection_internal): Rename locals
1560 to avoid shadowing.
1561 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1562
7e3ab302
PE
1563 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1564 so that the caller can use some name other than gcpro1.
1565 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1566 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1567 (Fx_backspace_delete_keys_p):
1568 Use them to avoid shadowing, and rename vars to avoid shadowing.
1569 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1570 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1571 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1572 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1573 Remove unused locals.
7e3ab302
PE
1574 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1575 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1576 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1577 macros.
f78faa98 1578
e2b13473
PE
1579 * xterm.h (x_mouse_leave): New decl.
1580
77f23912
PE
1581 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1582 Remove unused functions.
cdf4ba58
PE
1583 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1584 (x_calc_absolute_position): Now static.
7411c686 1585 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1586 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1587 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1588 unless they are used.
38d0b34a
PE
1589 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1590 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1591 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1592 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1593 (x_error_catcher, x_connection_closed, x_error_handler):
1594 (x_error_quitter, xembed_send_message, x_iconify_frame):
1595 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1596 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1597 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1598
44f230aa
SM
1599 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1600 Rename or move locals to avoid shadowing.
6b463e58 1601 (tty_defined_color, merge_face_heights): Now static.
5967d051 1602 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1603 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1604 does not deduce is never used uninitialized.
73719eba
PE
1605 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1606 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1607
426994c3 1608 * terminal.c (store_terminal_param): Now static.
5489860b 1609
032f1620 1610 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1611 (set_frame_menubar): Remove unused local.
d4323972 1612 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1613 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1614 since they might point to immutable storage.
281585b0
PE
1615 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1616 since it's unused otherwise.
032f1620 1617
367c19e5 1618 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1619 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1620 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1621 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1622 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1623 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1624 does not deduce are never used uninitialized.
70739cbe 1625
07b48fa9
PE
1626 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1627
8868a238 1628 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1629 * window.c (window_loop, size_window):
1630 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1631
7e5cf297 1632 * window.c (display_buffer): Now static.
d6550a9f
PE
1633 (size_window): Mark variables that gcc -Wuninitialized
1634 does not deduce are never used uninitialized.
a586633d
PE
1635 * window.h (check_all_windows): New decl, to forestall
1636 gcc -Wmissing-prototypes diagnostic.
5b555da1 1637 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1638
f6095868
PE
1639 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1640 shadowing.
1641 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1642 Include <limits.h>.
1643 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1644 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1645 (load_charset_map): Mark variables that gcc -Wuninitialized
1646 does not deduce are never used uninitialized.
53df7c11 1647 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1648
f38b440c
PE
1649 * coding.c (coding_set_source, coding_set_destination):
1650 Use "else { /* comment */ }" rather than "else /* comment */;"
1651 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1652 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1653 a block, when the outer 'i' will do.
1654 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1655 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1656 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1657 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1658 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1659 Rename locals to avoid shadowing.
1660 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1661 * coding.c (emacs_mule_char, encode_invocation_designation):
1662 Now static, since they're not used elsewhere.
413bb2db 1663 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1664 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1665 (decode_coding_emacs_mule): Mark variables that gcc
1666 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1667 (detect_coding_iso_2022): Initialize a local variable that might
1668 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1669 this initialization is needed. (Bug#8211)
5f58e762
PE
1670 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1671 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1672 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1673 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1674 Remove unused macros.
f38b440c 1675
232b38b9 1676 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1677 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1678 * character.c (string_count_byte8): Likewise.
232b38b9 1679
fb90da1b
PE
1680 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1681 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1682
fb93dbc2
PE
1683 * chartab.c (copy_sub_char_table): Now static, since it's not used
1684 elsewhere.
5c156ace
PE
1685 (sub_char_table_ref_and_range, char_table_ref_and_range):
1686 Rename locals to avoid shadowing.
bbcd0949 1687 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1688
7d3b3862 1689 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1690 (BIDI_BOB): Remove unused macro.
7d3b3862 1691
6be7d3da
PE
1692 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1693 deduce are never used uninitialized.
c2ed9c8b 1694 * term.c (encode_terminal_code): Likewise.
6be7d3da 1695
75f8807f 1696 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1697
50938595
PE
1698 * tparam.h: New file.
1699 * term.c, tparam.h: Include it.
1700 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1701 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1702 Move these decls to tparam.h, and make them agree with what
1703 is actually in tparam.c. The previous trick of using incompatible
1704 decls in different modules does not conform to the C standard.
1705 All callers of tparam changed to use tparam's actual API.
1706 * tparam.c (tparam1, tparam, tgoto):
1707 Use const pointers where appropriate.
1708
fbceeba2
PE
1709 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1710 * cm.h (struct cm): Likewise.
1711 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1712 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1713 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1714 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1715 (turn_on_face, init_tty): Likewise.
1716 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1717
7f3f1250
PE
1718 * term.c (term_mouse_position): Rename local to avoid shadowing.
1719
e6ca6543
PE
1720 * alloc.c (mark_ttys): Move decl from here ...
1721 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1722
c40f8d15
AS
17232011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1724
1725 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1726
cfe0661d
JB
17272011-03-09 Juanma Barranquero <lekktu@gmail.com>
1728
1729 * search.c (compile_pattern_1): Remove argument regp, unused since
1730 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1731 (compile_pattern): Don't pass it.
1732
0afb4571
J
17332011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1734
1735 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1736 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1737 for ! HAVE_GTK3.
1738 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1739
1740 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1741
1742 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1743 gdk_window_get_screen, gdk_window_get_geometry,
1744 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1745 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1746 (xg_get_pixbuf_from_pixmap): New function.
1747 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1748 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1749 Call xg_get_pixbuf_from_pixmap instead of
1750 gdk_pixbuf_get_from_drawable.
1751 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1752 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1753 (xg_check_special_colors): Use GtkStyleContext and its functions
1754 for HAVE_GTK3.
1755 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1756 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1757 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1758 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1759 Call gtk_widget_get_preferred_size.
0afb4571
J
1760 (xg_frame_resized): gdk_window_get_geometry only takes 5
1761 parameters.
44f230aa
SM
1762 (xg_win_to_widget, xg_event_is_for_menubar):
1763 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1764 (xg_set_widget_bg): New function.
1765 (delete_cb): New function.
1766 (xg_create_frame_widgets): connect delete-event to delete_cb.
1767 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1768 (xg_set_background_color): Call xg_set_widget_bg.
1769 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1770 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1771 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1772 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1773 if ! HAVE_GTK3.
1774 (update_frame_tool_bar): Call gtk_widget_hide.
1775 (xg_initialize): Use GDK_KEY_g.
1776
1777 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1778 if ! HAVE_GTK3
1779 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1780
1781 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1782 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1783 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1784
1c2cc4ef
JB
17852011-03-08 Juanma Barranquero <lekktu@gmail.com>
1786
1787 * w32xfns.c (select_palette): Check success of RealizePalette against
1788 GDI_ERROR, not zero.
1789
33383987 1790See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1791
1792;; Local Variables:
1793;; coding: utf-8
aac0c6e3
MR
1794;; End:
1795
33383987 1796 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1797
1798 This file is part of GNU Emacs.
1799
1800 GNU Emacs is free software: you can redistribute it and/or modify
1801 it under the terms of the GNU General Public License as published by
1802 the Free Software Foundation, either version 3 of the License, or
1803 (at your option) any later version.
1804
1805 GNU Emacs is distributed in the hope that it will be useful,
1806 but WITHOUT ANY WARRANTY; without even the implied warranty of
1807 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1808 GNU General Public License for more details.
1809
1810 You should have received a copy of the GNU General Public License
1811 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.