* progmodes/autoconf.el (font-lock-syntactic-keywords): Don't
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4d2b044c
DA
12012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
4 * process.h (PGET): Remove.
5 (struct Lisp_Process): Do not use INTERNAL_FIELD.
6 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
7
d3d50620
DA
82012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
9
10 Drop WGET and revert read access to Lisp_Objects slots of struct window.
11 * window.h (WGET): Remove.
12 (struct window): Do not use INTERNAL_FIELD.
13 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
14 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
15 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
16 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
17 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
18 Adjust users.
19
d10a51dc
CY
202012-08-07 Chong Yidong <cyd@gnu.org>
21
22 * window.c (Fwindow_edges, Fwindow_pixel_edges)
23 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
24 (Fdelete_window_internal): Signal an error if the window is not on
25 a live frame (Bug#12025).
26
e69b0960
DA
272012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
28
29 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
30 * frame.h (FGET): Remove.
31 (struct frame): Do not use INTERNAL_FIELD.
32 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
33 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
34 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
35 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
36
25a20a3a
JB
372012-08-06 Juanma Barranquero <lekktu@gmail.com>
38
39 * w32.c: Silence compiler warnings.
40 (map_w32_filename): Remove unused variable `is_fat'.
41 (chase_symlinks): Add parentheses around expression.
42
1c6f11f4
GM
432012-08-06 Glenn Morris <rgm@gnu.org>
44
1db4583a
GM
45 * sysdep.c: Respect BROKEN_GETWD.
46
1c6f11f4
GM
47 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
48 Let configure handle it.
49 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
50
2b90362b
DA
512012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
52
53 Use GCALIGNMENT where appropriate.
54 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
55 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
56 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
57
5f50daf2
EZ
582012-08-06 Eli Zaretskii <eliz@gnu.org>
59
60 * w32menu.c (set_frame_menubar, initialize_frame_menubar): Don't
61 use FRAME_MENU_BAR_ITEMS as an lvalue.
62
cbcc7007
SM
632012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
64
65 * buffer.h (struct buffer): Revert `indirections' to a simple int;
66 that should be sufficient for everyone.
67
4d365fa4
JD
682012-08-06 Jan Djärv <jan.h.d@swipnet.se>
69
70 * keyboard.c (timer_check_2): Add break so timer_check returns next
71 timeout.
72
dd86bd82
DA
732012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
74
75 Fix Windows build errors introduced after converting to WGET and WSET.
76 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
77 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
78
054e1668
JD
792012-08-06 Jan Djärv <jan.h.d@swipnet.se>
80
81 * nsterm.m (ns_frame_rehighlight): Use FSET.
82
83 * nsmenu.m (ns_update_menubar): Use FSET.
84
21238f11
DA
852012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
86
87 Separate read and write access to Lisp_Object slots of Lisp_Process.
88 * process.h (PGET, PSET): New macros similar to AREF and ASET.
89 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
90
077288cf
DA
912012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
92
93 Separate read and write access to Lisp_Object slots of struct window.
94 * window.h (WGET, WSET): New macros similar to AREF and ASET.
95 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
96 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
97 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
98 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
99 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
100 Adjust users.
101
71688bd7
DA
1022012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
103
104 Fix Windows build errors introduced after converting to FGET and FSET.
105 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
106 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
107 (w32_judge_scroll_bars): Change to use FSET.
108 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
109
f99bac93
DA
1102012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
111
112 Fix replacement typo.
113 * window.c (replace_window): Set root_window instead of
114 selected_window. This fixes a total window subsystem
115 malfunction reported by Bastien Guerry <bzg@gnu.org>.
116
8c2a0f2d
GM
1172012-08-06 Glenn Morris <rgm@gnu.org>
118
119 * lisp.mk (lisp): Add language/persian.elc.
120
edd74c35
DA
1212012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
122
123 Separate read and write access to Lisp_Object slots of struct frame.
124 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
125 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
126 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
127 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
128 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
129
8671676c
AS
1302012-08-05 Andreas Schwab <schwab@linux-m68k.org>
131
132 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
133
663e2b3f
DA
1342012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
135
136 Generalize common compile-time constants.
137 * lisp.h (header_size, bool_header_size, word_size): Now here.
138 (struct Lisp_Vector): Add comment.
139 (struct Lisp_Bool_Vector): Move up to define handy constants.
140 (VECSIZE, PSEUDOVECSIZE): Simplify.
141 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
142 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
143 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
144 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
145 * xfont.c, xmenu.c: Use word_size where appropriate.
146
d32e47af
LM
1472012-08-05 Lawrence Mitchell <wence@gmx.li>
148
149 * search.c (Freplace_match): Treat \? in the replacement text
150 literally (Bug#8161).
151
e5d9c0d1
CY
1522012-08-05 Chong Yidong <cyd@gnu.org>
153
154 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
155 * frame.c (Vdelete_frame_functions):
156 * emacs.c (Vkill_emacs_hook): Doc fix.
157
8da0576b
EZ
1582012-08-04 Eli Zaretskii <eliz@gnu.org>
159
160 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
161 --with-x-toolkit=no builds.
162 Reported by Carsten Mattner <carstenmattner@gmail.com>.
163
02676e5d
CY
1642012-08-04 Chong Yidong <cyd@gnu.org>
165
166 * syntax.c (Fmodify_syntax_entry): Doc fix.
167
97147da9
EZ
1682012-08-04 Eli Zaretskii <eliz@gnu.org>
169
76151e2c
EZ
170 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
171 * w32.c (init_environment): Change the default values of many
172 environment variables in dflt_envvars[] to NULL, to avoid pushing
173 them into environment when they were not already defined. Remove
174 the code that deletes site-lisp subdirectories from the default
175 value of EMACSLOADPATH, as it is no longer needed.
176 (check_windows_init_file): Now external, not static. Use
177 Vload_path as is, without adding anything, as this function is now
178 called when Vload_path is already set up.
179
180 * w32.h (check_windows_init_file): Add prototype.
181
182 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
183 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
184 compatibility with Posix platforms.
185 (main): Move the call to check_windows_init_file to here from
186 w32.c.
187 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
188 any, in the DEFALT argument into the root of the Emacs build or
189 installation tree, as appropriate.
190
191 * callproc.c (init_callproc_1): Call decode_env_path instead of
192 doing its equivalent by hand.
193 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
194 the code that sets Vexec_path run on MS-Windows.
195
196 * lread.c (init_lread): Add comments to #ifdef's.
197
97147da9
EZ
198 * msdos.c (dos_set_window_size, IT_update_begin)
199 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
200 instead of direct references.
201
185ee146
PE
2022012-08-04 Paul Eggert <eggert@cs.ucla.edu>
203
204 Export DEFAULT_REHASH_* to GDB.
205 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
206 Now constants, not macros.
207
8834c57a
PE
2082012-08-03 Paul Eggert <eggert@cs.ucla.edu>
209
98c6f1e3
PE
210 Remove unnecessary casts involving pointers.
211 These casts are no longer needed now that we assume C89 or later,
212 since they involve casting to or from void *.
213 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
214 (make_pure_float, make_pure_vector):
215 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
216 * macros.c (Fstart_kbd_macro):
217 * menu.c (find_and_return_menu_selection):
218 * minibuf.c (read_minibuf_noninteractive):
219 * sysdep.c (closedir):
220 * xdisp.c (x_produce_glyphs):
221 * xfaces.c (compare_fonts_by_sort_order):
222 * xfns.c (x_real_positions, select_visual):
223 * xselect.c (x_stop_queuing_selection_requests)
224 (x_get_window_property, x_get_window_property_as_lisp_data):
225 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
226 Remove unnecessary pointer casts.
227 * alloc.c (record_xmalloc): New function.
228 * lisp.h (record_xmalloc): New decl.
229 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
230 more like a function. This is because the pointer cast is not
231 needed. All uses changed.
232 * print.c (print_string, print_error_message): Avoid length recalc.
233
8834c57a
PE
234 Improve fix for macroexp crash with debugging (Bug#12118).
235 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
236 ARRAY_MARK_FLAG when checking subscripts, because ASET is
237 not supposed to be invoked from the garbage collector.
238 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
239 (gc_aset): New function, which is like ASET but can be
240 used in the garbage collector.
241 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
242 (set_hash_index): Use it instead of ASET.
243
6dad7178
EZ
2442012-08-03 Eli Zaretskii <eliz@gnu.org>
245
246 Support symlinks on latest versions of MS-Windows.
247 * w32.c: Include winioctl.h and aclapi.h.
248 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
249 (revert_to_self): Forward declarations of static functions.
250 <static BOOL g_b_init_get_security_info>:
251 <g_b_init_create_symbolic_link>: New static flags.
252 (globals_of_w32): Initialize them to zero.
253 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
254 (map_w32_filename): Improve commentary. Simplify switch.
255 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
256 headers (most versions of MinGW w32api don't).
257 (get_security_info, create_symbolic_link)
258 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
259 New functions.
260 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
261 in the argument file name.
262 (sys_access): Call unc_volume_file_attributes only if
263 GetFileAttributes fails with network-related error codes.
264 (sys_rename): Diagnose renaming of a symlink when the user doesn't
265 have the required privileges.
266 (get_file_security_desc_by_name): Renamed from
267 get_file_security_desc.
268 (stat_worker): New function, with most of the guts of 'stat', and
269 with addition of handling of symlinks and support for 'lstat'. If
270 possible, get file's attributes and security information by
271 handle, not by name. Produce S_IFLNK bit for symlinks, when
272 called from 'lstat'.
273 (stat, lstat): New functions, call 'stat_worker'.
274 (symlink, readlink, careadlinkat): Rewritten to create and resolve
275 symlinks when the underlying filesystem supports them.
276
f162bcc3
PE
2772012-08-02 Paul Eggert <eggert@cs.ucla.edu>
278
79ea6c20
PE
279 Fix macroexp crash on Windows with debugging (Bug#12118).
280 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
281 checking subscripts; problem introduced with the recent
282 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
283 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
284 since it's used in non-static inline functions now.
285
c0ce93fd
PE
286 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
287 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 288
f162bcc3
PE
289 Use C99-style 'extern inline' if available.
290 * buffer.h (BUFFER_INLINE):
291 * category.h (CATEGORY_INLINE):
292 * character.h (CHARACTER_INLINE):
293 * charset.h (CHARSET_INLINE):
294 * composite.h (COMPOSITE_INLINE):
295 * dispextern.h (DISPEXTERN_INLINE):
296 * lisp.h (LISP_INLINE):
297 * systime.h (SYSTIME_INLINE):
298 New macro, replacing 'static inline' in this header.
299 * buffer.h, category.h, character.h, charset.h, composite.h:
300 * dispextern.h, lisp.h, systime.h:
301 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
302 * alloc.c (LISP_INLINE):
303 * buffer.c (BUFFER_INLINE):
304 * category.c (CATEGORY_INLINE):
305 * character.c (CHARACTER_INLINE):
306 * charset.c (CHARSET_INLINE):
307 * composite.c (COMPOSITE_INLINE):
308 * dispnew.c (DISPEXTERN_INLINE):
309 * sysdep.c (SYSTIME_INLINE):
310 Define to EXTERN_INLINE, so that the corresponding functions
311 are compiled into code.
312 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
313 (INLINE_HEADER_END): New macros.
314 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
315 since it's used in non-static inline functions now.
a8333d03 316 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 317
837b365b
GM
3182012-08-02 Glenn Morris <rgm@gnu.org>
319
d66b744d
GM
320 * s/: Remove empty directory.
321
837b365b
GM
322 * s/ms-w32.h: Move to ../nt/inc.
323 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
324 Update for new ms-w32.h location.
325
13294f95
PE
3262012-08-02 Paul Eggert <eggert@cs.ucla.edu>
327
328 Port to Solaris 8.
329 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
330
90df0db3
GM
3312012-08-02 Glenn Morris <rgm@gnu.org>
332
333 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
334 hard-coding the path separator.
335
4939150c
PE
3362012-08-01 Paul Eggert <eggert@cs.ucla.edu>
337
338 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
339 This how ASET and AREF are supposed to work, and makes
340 it easier to think about future improvements. See
341 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
342 * charset.h (set_charset_attr): New function.
343 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
344 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
345 (aref_addr): New function. All uses of &AREF(...) changed.
346 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
347 (set_hash_index): New functions. All lvalue-style uses of
348 HASH_KEY etc. changed.
349 * keyboard.c (set_prop): New function. All lvalue-style uses
350 of PROP changed.
351
947b2afd
AA
3522012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
353
354 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
355 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
356 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
357 * nsfns.m (ns_set_name_as_filename): Likewise.
358 * nsmenu.m (ns_update_menubar): Likewise.
359 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
360
4f5d0325
EZ
3612012-08-01 Eli Zaretskii <eliz@gnu.org>
362
2008beae
EZ
363 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
364 Adapt to latest changes in field names of the corresponding Lisp
288479f6 365 objects.
2008beae 366
4f5d0325
EZ
367 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
368
fe3cc771
GM
3692012-08-01 Glenn Morris <rgm@gnu.org>
370
371 * s/msdos.h: Remove file.
372 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
373 * Makefile.in (S_FILE): Remove.
374 (config_h): Remove S_FILE.
375
c90acc54
JB
3762012-08-01 Juanma Barranquero <lekktu@gmail.com>
377
378 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
379 Remove; moved to nt/config.nt.
380
d8a05828
DA
3812012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
382
383 Use INTERNAL_FIELD for conses and overlays.
384 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
385 Remove obsolete comment.
386 (MVAR): New macro.
387 (struct Lisp_Overlay): Use INTERNAL_FIELD.
388 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
389
8271d590
DA
3902012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
391
392 Use INTERNAL_FIELD for symbols.
393 * lisp.h (SVAR): New macro. Adjust users.
394 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
395 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
396
3193acd2
DA
3972012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
398
399 Use INTERNAL_FIELD for processes.
400 * process.h (PVAR): New macro. Adjust style.
401 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
402 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
403
3a45383a
DA
4042012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
405
406 Use INTERNAL_FIELD for windows.
407 * window.h (WVAR): New macro.
408 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
409 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
410 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
411 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
412 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
413 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
414
c1dbc63c
PE
4152012-08-01 Paul Eggert <eggert@cs.ucla.edu>
416
417 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
418
5c0c0e8a
GM
4192012-08-01 Glenn Morris <rgm@gnu.org>
420
421 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
422 Move to configure.ac.
423
552a99b4
JB
4242012-08-01 Juanma Barranquero <lekktu@gmail.com>
425
426 * makefile.w32-in (CONFIG_H): Update dependencies.
427 (CONF_POST_H): New macro.
428
429 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
430
8d8e2dfe
GM
4312012-07-31 Glenn Morris <rgm@gnu.org>
432
bc96620a
GM
433 * Makefile.in (S_FILE): No longer set by configure.
434
476b1b2d
GM
435 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
436 is available.
437 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
438
b2c7a106
GM
439 * process.h (NULL_DEVICE):
440 * emacs.c (SEPCHAR):
441 * editfns.c (USER_FULL_NAME): Let configure set them.
442
d53d062a
GM
443 * s/README, s/template.h: Remove files.
444
4515017f
GM
445 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
446
8d8e2dfe
GM
447 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
448 Move to configure.ac.
449
5b20b3cc
EZ
4502012-07-31 Eli Zaretskii <eliz@gnu.org>
451
1e0afd9a
EZ
452 * .gdbinit (xframe): Adapt to introduction of FVAR and the
453 resulting renaming of 'struct frame' members.
454
5b20b3cc
EZ
455 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
456
457 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
458 after introduction of FVAR.
459
f1310128
JD
4602012-07-31 Jan Djärv <jan.h.d@swipnet.se>
461
79e721e0
JD
462 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
463
464 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
465 instead of compositeToPoint.
466 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
467
8d7c7eed 468 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 469
e34f7f79
DA
4702012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
471
472 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
473 * lisp.h (INTERNAL_FIELD): New macro.
474 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
475 (BVAR): Change to use INTERNAL_FIELD.
476 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
477 (KVAR): Change to use INTERNAL_FIELD.
478 * frame.h (FVAR): New macro.
479 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
480 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
481 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
482 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
483 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
484
c09bfb2f
DA
4852012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
486
487 Miscellaneous fixes for non-default X toolkits.
488 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
489 * xterm.c (x_frame_of_widget): Remove redundant prototype.
490 Move under #ifdef USE_LUCID.
491 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
492 definition and usage to avoid warnings.
493
14c114ae
JD
4942012-07-31 Jan Djärv <jan.h.d@swipnet.se>
495
496 * nsterm.m (openFiles): Fix previous checkin.
497
3bd21e82
PE
4982012-07-31 Paul Eggert <eggert@cs.ucla.edu>
499
500 * indent.c (compute_motion): Remove unused local.
501
c1529ded
GM
5022012-07-31 Glenn Morris <rgm@gnu.org>
503
400d5621
GM
504 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
505
268e2432
GM
506 * conf_post.h [USG5_4]:
507 Move remaining contents of s/usg5-4-common.h here.
508 * s/usg5-4-common.h: Remove file.
509
7552f3ee
GM
510 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
511 * s/irix6-5.h: Remove file.
512
6a381852
GM
513 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
514 * s/darwin.h: Remove file.
515
c1529ded
GM
516 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
517 * s/hpux10-20.h: Remove file, which is now empty.
518
b429a4ee
GM
5192012-07-30 Glenn Morris <rgm@gnu.org>
520
521 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
522 * Makefile.in (config_h): Add conf_post.h.
523 * makefile.w32-in (CONFIG_H): Add conf_post.h.
524
adff3182
JD
5252012-07-30 Jan Djärv <jan.h.d@swipnet.se>
526
527 * nsterm.m (ns_do_open_file): New variable.
b9031d69 528 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
529 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
530 files only if ns_do_open_file.
531
c32af1e4
PE
5322012-07-30 Paul Eggert <eggert@cs.ucla.edu>
533
7393bcbb
PE
534 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
535 This no-op macro hasn't been needed for many years.
536 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
537
c32af1e4
PE
538 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
539 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
540 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
541 gdb_make_enums_visible.
542 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
543 (DIRECTORY_SEP): Now a constant, not a macro.
544
302fc036
EZ
5452012-07-30 Eli Zaretskii <eliz@gnu.org>
546
547 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
548 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
549
550 * w32term.c <w32_keyboard_codepage>: Renamed from
551 keyboard_codepage and now external. All users changed.
552
553 * w32term.h: Add declaration of w32_keyboard_codepage.
554
555 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
556 the codepage to translate keys to Unicode. If this argument is
557 -1, use the value returned by GetConsoleCP. All callers changed.
558
88fb40b4
PE
5592012-07-30 Paul Eggert <eggert@cs.ucla.edu>
560
0aee6912
PE
561 Update .PHONY listings in makefiles.
562 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
563 bootstrap-clean, distclean, maintainer-clean, versioclean,
564 extraclean, frc.
565
88fb40b4
PE
566 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
567 This is a bit clearer. Fix some commentary typos.
568
0a763bd1
GM
5692012-07-30 Glenn Morris <rgm@gnu.org>
570
32bac6d6
GM
571 * s/netbsd.h: Let configure include signal.h if needed.
572 Remove file, which is now empty.
573
b65e7c46
GM
574 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
575 Let configure set them.
576 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
577 No more need to undefine.
0a763bd1 578
169304bd
AS
5792012-07-30 Andreas Schwab <schwab@linux-m68k.org>
580
581 * keymap.c (Fkey_description): Don't remove 0x80 bit from
582 non-single-byte char when adding meta modifier. (Bug#12090)
583
6cd7a139
DA
5842012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
585
586 Convert safe_call to use variable number of arguments.
587 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
588 (safe_call2): Fix comment.
589 * lisp.h (safe_call): Adjust prototype.
590 * coding.c (encode_coding_object): Change to use safe_call2.
591 * xfaces.c (merge_face_heights): Change to use safe_call1.
592
d34d6ffc
GM
5932012-07-30 Glenn Morris <rgm@gnu.org>
594
7b8a48e4 595 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 596 does that unconditionally. Remove file, which is now empty.
7b8a48e4 597
d34d6ffc
GM
598 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
599 Remove empty files.
600
03a660a6
PE
6012012-07-30 Paul Eggert <eggert@cs.ucla.edu>
602
603 Export to GDB most of lisp.h's remaining object-like macros.
604 * lisp.h (min, max): Move earlier, because they're used earlier now.
605 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
606 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
607 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
608 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
609 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
610 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
611 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
612 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
613 Now constants, for GDB. They need not be macros.
614 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
615 Now constants, for GDB, as well as macros, for static initializers.
616 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
617 Move to after the definition of struct Lisp_Char_Table,
618 since the former now needs that type defined.
619 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
620 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
621 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
622 New enums, for gdb_make_enums_visible.
623 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 624 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
625 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
626 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
627 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
628 enum maxargs, enum MAX_ALLOCA.
629 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
630 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
631 no longer needed, now that they are done in lisp.h.
632
e499d0ee
DA
6332012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
634
635 Cleanup string bytes checking.
636 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
637 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
638 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
639 (check_sblock, compact_small_strings): Simplify.
640
d5040d2d
PE
6412012-07-29 Paul Eggert <eggert@cs.ucla.edu>
642
643 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
644 These macros are confusing and no longer need to be defined, as
645 the enum values now suffice. All uses replaced with definiens.
646 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
647
7f259ae6
JB
6482012-07-29 Juanma Barranquero <lekktu@gmail.com>
649
650 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
651 ($(BLD)/w32console.$(O)): Update dependencies.
652
7e63e0c3
DA
6532012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
654
655 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
656 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
657 time. Adjust users.
658 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
659
ffd817eb
JD
6602012-07-29 Jan Djärv <jan.h.d@swipnet.se>
661
662 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
663 setting sitelisp (Bug#12010).
664
417a7a0e
EZ
6652012-07-29 Eli Zaretskii <eliz@gnu.org>
666
667 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
668
669 * w32heap.c (cache_system_info):
670 * w32.c (sys_rename):
671 * w32proc.c (find_child_console, sys_kill): All users changed.
672
387d4d92
PE
6732012-07-29 Paul Eggert <eggert@cs.ucla.edu>
674
675 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
676
55a6cca6
EZ
6772012-07-29 Eli Zaretskii <eliz@gnu.org>
678
679 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
680
dbcf001c
DA
6812012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
682
683 Cleanup statistics calculation in Fgarbage_collect.
684 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
685 zombies percentage calculation. Simplify elapsed time calculation.
686
e2688e4a
DA
6872012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
688
689 Generalize marker debugging code under MARKER_DEBUG and use eassert.
690 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
691 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
692 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
693 (replace_range, replace_range_2, del_range_2): Change to eassert.
694 * marker.c (byte_char_debug_check): Adjust style.
695
b46a6a83
PE
6962012-07-29 Paul Eggert <eggert@cs.ucla.edu>
697
698 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
699 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
700 long-ago-commented-out code that talks about "WIN32".
701 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
702 All uses changed.
703
e32a5799
PE
7042012-07-28 Paul Eggert <eggert@cs.ucla.edu>
705
706 Use Gnulib stdalign module (Bug#9772, Bug#9960).
707 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
708 Simplify by using alignof.
709 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
710 * lisp.h: Include <stdalign.h>.
711 (GCALIGNMENT): New macro and constant.
712 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
713 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
714 (stdalign): New macro, if not already defined.
715
df81cd29
EZ
7162012-07-28 Eli Zaretskii <eliz@gnu.org>
717
01bd1b0d
EZ
718 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
719 * w32inevt.c: Include w32inevt.h.
720 (w32_read_console_input): New inline function, calls either
721 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
722 w32_console_unicode_input.
723 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
724 (w32_kbd_patch_key, key_event): Use the codepage returned by
725 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
726 (key_event): use uChar.UnicodeChar only if
727 w32_console_unicode_input is non-zero.
728
729 * w32console.c: Include w32heap.h.
730 <w32_console_unicode_input>: New global variable.
731 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
732 family of Windows, zero otherwise.
733
734 * w32inevt.h: Declare w32_console_unicode_input.
735
df81cd29
EZ
736 * xdisp.c (init_iterator): Don't reference tip_frame in a build
737 --without-x. (Bug#11742)
738
c20fdd9e
PE
7392012-07-27 Paul Eggert <eggert@cs.ucla.edu>
740
741 Adjust GDB to reflect pvec_type changes (Bug#12036).
742 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
743 2012-07-04 changes to pseudovector representation. Problem
744 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
745
32770973 7462012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
747
748 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
749 bus address.
750 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
751
3438fe21
EZ
7522012-07-27 Eli Zaretskii <eliz@gnu.org>
753
bcfbc9de
EZ
754 * alloc.c (listn): Fix the order the arguments are consed onto the
755 list.
756
3438fe21
EZ
757 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
758 enumeration constants, as PURE and HEAP are too general, and clash
759 with other headers and sources, such as gmalloc.c and the
760 MS-Windows system headers. All users changed.
761
eeaea515
DA
7622012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
763
764 Revert last save_excursion_save and save_excursion_restore changes.
765 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
766 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
767
073c88c2
DA
7682012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
769
770 Fix recently-introduced typos in Windows port.
771 Reported by Martin Rudalics <rudalics@gmx.at>.
772 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 773 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 774
4706125e
PE
7752012-07-27 Paul Eggert <eggert@cs.ucla.edu>
776
777 Improve GDB symbol export (Bug#12036).
778 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
779 arms of an 'if', not using conditional expressions; otherwise GDB
780 complains about the types in the unevaluated arm when the argument
781 is an integer literal.
782 (xgetint): Simplify expression.
783 * alloc.c (gdb_make_enums_visible): New constant. This ports to
784 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
785 Zaretskii in <http://bugs.gnu.org/12036#13>.
786 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
787 needed now that we have gdb_make_enums_visible.
788 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
789 (enum enum_USE_LSB_TAG):
790 New enum types, packaging up enums that need to be exported to GDB.
791
694b6c97
DA
7922012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
793
794 Utility function to make a list from specified amount of objects.
795 * lisp.h (enum constype): New datatype.
796 (listn): New prototype.
797 * alloc.c (listn): New function.
798 (Fmemory_use_count, syms_of_alloc): Use it.
799 * buffer.c (syms_of_buffer): Likewise.
800 * callint.c (syms_of_callint): Likewise.
801 * charset.c (define_charset_internal): Likewise.
802 * coding.c (syms_of_coding): Likewise.
803 * keymap.c (syms_of_keymap): Likewise.
804 * search.c (syms_of_search): Likewise.
805 * syntax.c (syms_of_syntax): Likewise.
806 * w32.c (init_environment): Likewise.
807 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
808 * xdisp.c (syms_of_xdisp): Likewise.
809 * xfns.c (syms_of_xfns): Likewise.
810
6195f384
DA
8112012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
812
813 Fast save_excursion_save and save_excursion_restore.
814 * lisp.h (struct Lisp_Excursion): New data type.
815 (PVEC_EXCURSION): New pseudovector type.
816 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
817 to deal with it. Adjust comments.
818 (init_marker, attach_marker): New prototype.
819 (unchain_marker): Adjust prototype.
820 * marker.c (attach_marker): Change to global.
821 (init_marker): New function.
822 * alloc.c (Fmake_marker, build_marker): Use it.
823 (build_marker): More easserts.
824 (mark_object): Handle struct Lisp_Excursion.
825 * editfns.c (save_excursion_save, save_excursion_restore):
826 Reimplement to use struct Lisp_Excursion. Add comments.
827
5eceb8fb
PE
8282012-07-26 Paul Eggert <eggert@cs.ucla.edu>
829
830 Fix export of symbols to GDB (Bug#12036).
831 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
832 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
833 emacs.c, as this is a more-suitable home. Had this been done earlier
834 the fix for 12036 would have avoided some of the problems noted in
835 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
836 would have been more obvious.
562157c8
PE
837 * emacs.c: Do not include <verify.h>; no longer needed.
838 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
839 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
840 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
841 Remove; now done in lisp.h.
842 * lisp.h (PUBLISH_TO_GDB): New macro.
843 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
844 (DATA_SEG_BITS): Use it.
845 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
846 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
847 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
848 not be usable in #if. This simplifies things.
849
d6749401
JB
8502012-07-26 Juanma Barranquero <lekktu@gmail.com>
851
852 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
853
1781b9e9
PE
8542012-07-26 Paul Eggert <eggert@cs.ucla.edu>
855
d89518db 856 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
857 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
858 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
859 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
860 Adjust to changes in lisp.h and emacs.c, by using
861 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
862 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
863 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
864 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
865 instead of gdb_valbits.
866 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
867 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
868 instead of gdb_array_mark_flag.
869 (xboolvector): Get size from $->size, not $->header.size.
870 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
871 (xreload, hook-run, hookpost-run): Remove.
872 * emacs.c: Include <verify.h>.
873 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
874 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
875 Remove.
876 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
877 (gdb_USE_LSB_TAG): New enum constants.
878 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
879 Also define these as enum constants, so they're visible to GDB.
880 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
881 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
882 as constants, so they're visible to GDB.
883 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
884 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
885 Now enum constants, not macros, so they're visible to GDB.
886 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
887 more convenient now. All uses changed.
888 (VALMASK) [USE_LSB_TAG]: Also define in this case.
889 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
890
3628596a
DA
8912012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
892
893 Explicitly free restriction data that are not needed anymore.
894 * editfns.c (save_restriction_restore): Free restriction data.
895
7abaf5cc
SM
8962012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
897
898 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
899 add argument, tune behavior, and adjust all callers.
900
71f88e00
PE
9012012-07-25 Paul Eggert <eggert@cs.ucla.edu>
902
903 Use typedef for EMACS_INT, EMACS_UINT.
904 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
905 than macros. This simplifies debugging in the usual case, since
906 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
907 and it allows expressions involving EMACS_INT casts.
908 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
909
57ec3034
JD
9102012-07-25 Jan Djärv <jan.h.d@swipnet.se>
911
912 * nsterm.m (ns_read_socket): Return early if there is a modal
913 window (Bug#12043).
914
8137e7b3
MR
9152012-07-25 Martin Rudalics <rudalics@gmx.at>
916
917 * frame.c (Fredirect_frame_focus): In doc-string don't mention
918 that FOCUS-FRAME can be omitted.
919
04e9897c
DA
9202012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
921
922 Adjust buffer text indirection counters at the end of Fkill_buffer.
923 * buffer.c (Fkill_buffer): Adjust indirection counters when the
924 buffer is definitely dead. This should really fix an issue reported
925 by Christoph Scholtes again. (Bug#12007).
926 (init_buffer_once): Initialize indirection counters of
927 buffer_defaults and buffer_local_symbols (for sanity and safety).
928
8a0484e1
EZ
9292012-07-24 Eli Zaretskii <eliz@gnu.org>
930
931 * xdisp.c (init_iterator): Don't compute dimensions of truncation
932 and continuation glyphs on tooltip frames, leave them at zero.
933 Avoids continued lines in tooltips. (Bug#11832)
934
fa691a83
DA
9352012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
936
937 Simplify copy_overlay.
04e9897c 938 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
939 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
940
436bc8e0
EZ
9412012-07-23 Eli Zaretskii <eliz@gnu.org>
942
943 * print.c (print_object): Don't crash when a frame's name is nil
944 or invalid. (Bug#12025)
945
946 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
947 it signals an error when a tooltip frame is being created.
948
d7a7fda3
DA
9492012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
950
951 Cleanup miscellaneous objects allocation and initialization.
952 * alloc.c (allocate_misc): Change to static. Add argument to
953 specify the subtype. Adjust comment and users.
954 (build_overlay): New function.
955 * buffer.c (copy_overlays, Fmake_overlay): Use it.
956 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
957 (allocate_misc): Remove prototype.
958 (build_overlay): Add prototype.
959
9602012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
961
962 Swap buffer text indirection counters in Fbuffer_swap_text.
963 * buffer.c (Fbuffer_swap_text): Swap indirections too.
964 This avoids crash reported by Christoph Scholtes at
965 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
966
9d7fa573
JD
9672012-07-22 Jan Djärv <jan.h.d@swipnet.se>
968
969 * nsmenu.m (Popdown_data): New struct.
970 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
971 free Popdown_data.
972 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
973 (initWithContentRect): Make imgView and contentView non-static
974 and autorelease them. Also autorelease img and matrix (Bug#12005).
975 (dealloc): Remove (Bug#12005).
976
0dd6d66d
DA
9772012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
978
979 Adjust consing_since_gc when objects are explicitly freed.
980 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
981 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
982 (free_cons, free_misc): Subtract object size from consing_since_gc.
983
d36d71df
DA
9842012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
985
986 Simplify and cleanup markers positioning code.
987 * marker.c (attach_marker): More useful eassert.
988 (live_buffer, set_marker_internal): New function.
989 (Fset_marker, set_marker_restricted): Use set_marker_internal.
990 (set_marker_both, set_marker_restricted_both): Use live_buffer.
991
fb9ea40f
PE
9922012-07-22 Paul Eggert <eggert@cs.ucla.edu>
993
994 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
995 as it's limited by the amount of memory, not by INT_MAX.
996
2d5c5f7d
EZ
9972012-07-21 Eli Zaretskii <eliz@gnu.org>
998
07fb592e
EZ
999 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1000 in special-event-map. See the discussion at
1001 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1002 for the reasons.
1003
37a9eac8 1004 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
1005 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
1006 Fabrice Popineau <fabrice.popineau@supelec.fr>.
1007
c4328746
JD
10082012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1009
1010 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1011 (conversationIdentifier): Return value is NSInteger.
784051c4 1012 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1013
6e5d1c12
CY
10142012-07-21 Chong Yidong <cyd@gnu.org>
1015
1016 * window.c (decode_any_window): Signal an error if the window is
1017 on a dead frame (Bug#11984).
1018
9928463d
DA
10192012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1020
1021 Add indirection counting to speed up Fkill_buffer.
1022 * buffer.h (struct buffer): New member.
1023 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1024 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1025 base buffer indirection counter.
1026 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1027 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1028 through buffer list if indirection counter is 0.
1029
f8643a6b
DA
10302012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1031
1032 Extend the value returned by Fgarbage_collect with heap statistics.
1033 * alloc.c (Qheap): New symbol.
1034 (syms_of_alloc): DEFSYM it.
1035 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1036 (Fmemory_free): Remove.
1037 (syms_of_alloc): Don't defsubr it.
1038 * buffer.c (Fcompact_buffer): Remove.
1039 (syms_of_buffer): Don't defsubr it.
1040
dac616ff
DA
10412012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1042
1043 Make maybe_gc inline.
1044 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1045 * lisp.h (consing_since_gc, gc_relative_threshold)
1046 (memory_full_cons_threshold): Revert declaration.
1047 (maybe_gc): Remove prototype, define as inline.
1048 * alloc.c: Remove old commented-out code.
1049 (consing_since_gc, gc_relative_threshold)
1050 (memory_full_cons_threshold): Revert to global.
1051 (maybe_gc): Remove.
1052
d7ea76b4
DA
10532012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1054
1055 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1056 * lisp.h (build_unibyte_string): New function.
1057 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1058 * sysdep.c, w32fns.c, xfns.c: Use it.
1059 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1060 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1061 Adjust users accordingly.
1062 * font.h (font_open_by_name): Adjust prototype.
1063
765e61e3
DA
10642012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1065
1066 Cleanup calls to Fgarbage_collect.
1067 * lisp.h (maybe_gc): New prototype.
1068 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1069 Remove declarations.
1070 * alloc.c (maybe_gc): New function.
1071 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1072 Make them static.
1073 * bytecode.c (MAYBE_GC): Use maybe_gc.
1074 * eval.c (eval_sub, Ffuncall): Likewise.
1075 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1076 to avoid dependency from auto-save feature.
1077
52b852c7
PE
10782012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1079
1080 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1081 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1082 'for_each_per_buffer_object_at'.
1083 All uses changed. It's better to use upper-case for macros that
1084 cannot be implemented as functions, to give the reader a clue
1085 that they're special.
1086
5db81e33
SM
10872012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1088
1089 * alloc.c (Fgarbage_collect): Tweak docstring.
1090
5b835e1d
DA
10912012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1092
1093 Tweak the value returned from Fgarbage_collect again.
1094 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1095 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1096 Adjust documentation.
1097 (total_vector_bytes): Rename to total_vector_slots, adjust
1098 accounting.
1099 (total_free_vector_bytes): Rename to total_free_vector_slots,
1100 adjust accounting.
1101 (Qstring_bytes, Qvector_slots): New symbols.
1102 (syms_of_alloc): DEFSYM them.
1103
9cd47b72
DA
11042012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1105
1106 Buffer compaction primitive which may be used from Lisp.
1107 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1108 (syms_of_buffer): Register Fcompact_buffer.
1109 * alloc.c (Fgarbage_collect): Use compact_buffer.
1110 * buffer.h (compact_buffer): New prototype.
1111 (struct buffer_text): New member.
1112
d17337e5
DA
11132012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1114
1115 New macro to iterate over all buffers, miscellaneous cleanups.
1116 * lisp.h (all_buffers): Remove declaration.
1117 * buffer.h (all_buffers): Add declaration, with comment.
1118 (for_each_buffer): New macro.
1119 * alloc.c (Fgarbage_collect, mark_object): Use it.
1120 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1121 (init_buffer): Likewise.
1122 * data.c (Fset_default): Likewise.
1123 * coding.c (code_conversion_restore): Remove redundant check
1124 for dead buffer.
1125 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1126
60cfd278
AS
11272012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1128
1129 Fix bug that created negative-length intervals.
1130 * intervals.c (merge_interval_right, merge_interval_left):
1131 Do not zero out this interval if it is absorbed by its children,
1132 as this interval's total length doesn't change in that case. See
1133 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1134
d06714cb
PE
11352012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1136
83713154
PE
1137 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1138 when invoking (make-bool-vector N t) and N is a positive
1139 multiple of 8 -- the last 8 bits were mistakenly cleared.
1140
d06714cb
PE
1141 Remove some struct layout assumptions in bool vectors.
1142 * alloc.c (bool_header_size): New constant.
1143 (header_size, word_size): Move earlier, as they're now used earlier.
1144 Use 'word_size' in a few more places, where it's appropriate.
1145 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1146 padding before the data member of a bool vector.
1147 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1148 than doing the check by hand with an abort ().
1149
464d5a5e
SM
11502012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1151
5fbc0409
SM
1152 * eval.c (Fdefvar): Don't check constants since we only set the var if
1153 it's not yet defined anyway (bug#11904).
1154
464d5a5e
SM
1155 * lisp.h (last_undo_boundary): Declare new var.
1156 * keyboard.c (command_loop_1): Set it.
1157 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1158 were auto-added by the command loop (bug#11774).
1159
8dc2e44a
AS
11602012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1161
1162 * w32font.c (Qsymbol): Remove local definition.
1163 (syms_of_w32font): Don't DEFSYM it.
1164
169925ec
DA
11652012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1166
1167 Fix sweep_vectors to handle large bool vectors correctly.
1168 * alloc.c (sweep_vectors): Account total_vector_bytes for
1169 bool vectors larger than VBLOCK_BYTES_MAX.
1170
5fbfb018
CY
11712012-07-18 Chong Yidong <cyd@gnu.org>
1172
1173 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1174 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1175
3ab6e069
DA
11762012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1177
1178 Return more descriptive data from Fgarbage_collect.
1179 Suggested by Stefan Monnier in
1180 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1181 * alloc.c (bounded_number): New function.
1182 (total_buffers, total_vectors): New variable.
1183 (total_string_size): Rename to total_string_bytes, adjust users.
1184 (total_vector_size): Rename to total_vector_bytes, adjust users.
1185 (sweep_vectors): Account total_vectors and total_vector_bytes.
1186 (Fgarbage_collect): New return value. Adjust documentation.
1187 (gc_sweep): Account total_buffers.
1188 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1189 (VECTOR_SIZE): Remove.
1190 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1191 (Qinterval, Qmisc): New symbols.
1192 (syms_of_data): Initialize them.
1193 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1194 (Qcons, Qbuffer): New declarations.
1195
6d02fe5b
PE
11962012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1197
1198 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1199 Round up, not down. Improve doc.
1200
b7ffe040
DA
12012012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1202
1203 Restore old code in allocate_string_data to avoid Faset breakage.
1204 Reported by Julien Danjou <julien@danjou.info> in
1205 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1206 * alloc.c (allocate_string_data): Restore old code with minor
1207 adjustments, fix comment to explain this subtle issue.
1208
4dc7c8d5
SM
12092012-07-17 Eli Zaretskii <eliz@gnu.org>
1210
1211 Remove FILE_SYSTEM_CASE.
1212 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1213
1214 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1215 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1216 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1217 call-process-region passes it through expand-file-name.
1218
1219 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1220
12212012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1222
1223 Fix crash when creating indirect buffer (Bug#11917)
1224 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1225 Don't handle unbound variables specially if non-zero.
1226 (Fbuffer_local_variables): Pass zero.
1227 (clone_per_buffer_values): Pass non-zero.
1228
12292012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1230
1231 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1232 to make the loop interruptible.
1233
12342012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1235
1236 * gnutls.c (emacs_gnutls_handshake): Only retry if
1237 GNUTLS_E_INTERRUPTED.
1238
cce7fefc
DA
12392012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1240
1241 Cleanup and convert miscellaneous checks to eassert.
1242 * alloc.c (mark_interval): Fix comment, partially rephrase
1243 old comment from intervals.h (see below).
1244 * intervals.c (find_interval, adjust_intervals_for_insertion)
1245 (delete_interval, adjust_intervals_for_deletion)
1246 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1247 Convert to eassert.
1248 (adjust_intervals_for_insertion, make_new_interval):
1249 Remove obsolete and unused code.
1250 * intervals.h (struct interval): Remove obsolete comment.
1251 * textprotp.c (erase_properties): Remove unused code.
1252 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1253 (Fremove_list_of_text_properties): Convert to eassert.
1254
9ea10cc3
CY
12552012-07-17 Chong Yidong <cyd@gnu.org>
1256
1257 * editfns.c (Finsert_char): Doc fix.
1258
3900d5de
DA
12592012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1260
1261 Fix previous change to make Fmemory_free always accurate.
1262 * alloc.c (make_interval): Update total_free_intervals.
1263 (make_float): Likewise for total_free_floats.
1264 (free_cons, Fcons): Likewise for total_free_conses.
1265 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1266 Likewise for total_free_vector_bytes.
1267 (Fmake_symbol): Likewise for total_free_symbols.
1268 (bytes_free): Remove.
1269
7098646f
DA
12702012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1271
1272 Simple free memory accounting feature.
1273 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1274 (sweep_vectors): Accumulate size of free vectors.
1275 (Fgarbage_collect): Setup bytes_free.
1276 (Fmemory_free): New function.
1277 (syms_of_alloc): Register it.
1278
22657b40
DA
12792012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1280
1281 Cleanup overlays checking.
1282 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1283 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1284 eassert and OVERLAYP.
1285 (sort_overlays): Change to use OVERLAYP.
1286
ddfc8813
RK
12872012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1288
1289 * editfns.c (Finsert_char): Make it interactive, and make the
1290 second arg optional. Copy interactive spec and docstring from
1291 ucs-insert.
1292
7c26cf3c
PE
12932012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1294
1295 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1296 Unlike the other wrapped functions, fabs has an unspecified
1297 effect on errno.
1298
5d127af9
JD
12992012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1300
1301 * nsterm.m (keyDown): Interpret flags without left/right bits
1302 as the left key (Bug#11670).
1303
6a0dd1d7
DA
13042012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1305
1306 Remove empty and useless init functions.
1307 * lisp.h (init_character_once, init_fns, init_image)
1308 (init_filelock, init_sound): Remove prototype.
1309 * character.c (init_character_once): Remove.
1310 * filelock.c (init_filelock): Likewise.
1311 * fns.c (init_fns): Likewise.
1312 * image.c (init_image): Likewise.
1313 * sound.c (init_sound): Likewise.
1314 * emacs.c (main): Adjust accordingly.
1315
7a6136fd
DA
13162012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1317
1318 * gtkutil.h: Tiny cleanups.
1319 (use_old_gtk_file_dialog): Remove useless declaration.
1320 (xg_uses_old_file_dialog): Add suggested const attribute.
1321
ce811ad9
EZ
13222012-07-15 Eli Zaretskii <eliz@gnu.org>
1323
1324 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1325 (bidi_paragraph_init): Use it to limit search forward for a strong
1326 directional character in abnormally large paragraphs full of
1327 neutral or weak characters. (Bug#11943)
1328
c9adfeaa
SF
13292012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1330
1331 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1332 the toolbar (Bug#9451).
1333 (xg_make_tool_item): Give the widget event box a transparent
1334 background.
1335
fff62aa9
DA
13362012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1337
1338 Cleanup basic allocation variables and functions.
1339 * alloc.c (ignore_warnings, init_intervals, init_float)
1340 (init_cons, init_symbol, init_marker): Remove.
1341 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1342 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1343 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1344 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1345 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1346 (staticidx, init_alloc_once, init_strings, free_ablock):
1347 Remove redundant initialization.
1348 * fns.c (init_weak_hash_tables): Remove.
1349 * lisp.h (init_weak_hash_tables): Remove prototype.
1350
9730daca
DA
13512012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1352
1353 Use zero_vector where appropriate.
1354 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1355 accordingly.
1356 * lisp.h (zero_vector): New declaration.
1357 * font.c (null_vector): Remove.
1358 (syms_of_font): Remove initialization and staticpro.
1359 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1360 * keymap.c (Faccessible_keymaps): Likewise.
1361
2e2d2a13
LL
13622012-07-15 Leo Liu <sdl.web@gmail.com>
1363
1364 * fringe.c: Fix typo in comments.
1365
cd276f6e
LL
13662012-07-14 Leo Liu <sdl.web@gmail.com>
1367
1368 * fringe.c: Add a new bitmap exclamation-mark.
1369
5a1131d9
EZ
13702012-07-14 Eli Zaretskii <eliz@gnu.org>
1371
1372 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1373
1374 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1375 (HAVE_MENUS): Don't define, defined by editing config.in with
1376 msdos/sed2v2.inp.
1377 (GMALLOC_INHIBIT_VALLOC): Don't define.
1378 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1379
22e983b7
JB
13802012-07-14 Juanma Barranquero <lekktu@gmail.com>
1381
1382 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1383
5b3f250f
GM
13842012-07-14 Glenn Morris <rgm@gnu.org>
1385
1386 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1387 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1388 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1389
33d63ff4
GM
13902012-07-13 Glenn Morris <rgm@gnu.org>
1391
5b633342
GM
1392 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1393
33d63ff4
GM
1394 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1395 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1396
b55b9f85
JD
13972012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1398
0dc8cf50
JD
1399 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1400 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1401 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1402 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1403 where appropriate.
1404 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1405 as boolean expression.
1406 (x_set_window_size): Remove unused variable toolbar.
1407 (ns_get_color_default, ns_mod_to_lisp): Remove.
1408 (ns_mouse_position): Remove unused variables xchar and ychar.
1409 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1410 (ns_set_vertical_scroll_bar): Remove unused variable count.
1411 (ns_delete_terminal): Remove unused variable i.
1412 (ns_term_init): Remove unused variables r, g and b.
1413 (mouseDown): Remove unused variable window.
1414 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1415 (initFrameFromEmacs): Remove unused variable vbextra.
1416 (mouseEntered): Remove unused variables p and dpyinfo.
1417 (mouseExited): Remove unused variables p and r.
1418 (ns_define_frame_cursor, ns_clear_frame_area)
1419 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1420 (menuDown): Assign [sender tag] to variable and cast the variable.
1421
1422 * nsterm.h (menuDown): Add id as type to argument sender.
1423 (ns_display_info_for_name): Add Lisp_Object argument.
1424 (ns_term_init): Add Lisp_Object argument.
1425 (ns_map_event_to_object): Add void argument.
1426 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1427 prototype with arguments and only declare if __OBJC__.
1428 (nxatoms_of_nsselect): Add void argument.
1429 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1430 (ns_alloc_autorelease_pool): Add void argument.
1431 (ns_release_autorelease_pool): Add void* argument.
1432 (ns_get_defaults_value): Add const char* argument.
1433
1434 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1435 (initFromContents): Use SSDATA where appropriate.
1436 (ns_update_menubar): Add braces to ambigous if-else.
1437 (initWithTitle): Put () around assignment in if statement.
1438 (ns_menu_show): Remove unused variables window and keymap.
1439 (update_frame_tool_bar): Remove unused variable selected_p.
1440 (initWithContentRect): Remove unused variable this_cmd_name.
1441
1442 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1443 appropriate.
1444 (setXBMColor): Remove unused variable len.
1445 (setPixmapData): Put () around assignment in loop statement.
1446
1447 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1448 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1449 where appropriate.
1450 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1451 around assignment in loop statement.
1452 (nsfont_open): Remove unused variable i.
1453 (nsfont_open): Remove unused variable len.
1454 (nsfont_draw): Remove unused variable cs.
1455
1456 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1457 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1458 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1459 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1460 (Fns_font_name, Fns_perform_service)
1461 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1462 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1463 (ns_set_name): Remove unused variable view.
1464 (x_set_menu_bar_lines): Remove unused variable olines.
1465 (x_set_tool_bar_lines): Remove unused variable root_window.
1466 (Fns_list_colors): Put () around assignment in while statement.
1467 (Fns_perform_service): Remove unused variable len.
1468 (Fns_display_usable_bounds): Remove unused variable top.
1469 (syms_of_nsfns): Remove unused variable i.
1470
b55b9f85
JD
1471 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1472 memcpy (Bug#11907).
1473
ed9265fc 14742012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1475
1476 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1477 and free it with DestroyExceptionInfo (Bug#11558).
1478
ef099b57
JB
14792012-07-13 Juanma Barranquero <lekktu@gmail.com>
1480
1481 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1482 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1483 Set here, not in nt/config.nt.
1484
ea814a5d
EZ
14852012-07-13 Eli Zaretskii <eliz@gnu.org>
1486
1487 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1488 cursor overflow into the last glyph on display line when the right
1489 fringe is off. (Bug#11832)
1490
1a952767
PE
14912012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1492
1493 * xdisp.c (produce_special_glyphs): Now static.
1494 * dispextern.h (produce_special_glyphs): Remove decl.
1495
983188fd
GM
14962012-07-13 Glenn Morris <rgm@gnu.org>
1497
8d7c7eed 1498 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1499 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1500
983188fd
GM
1501 * s/usg5-4-common.h (USG, USG5):
1502 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1503 * s/sol2-6.h (SOLARIS2):
1504 * s/irix6-5.h (IRIX6_5):
1505 * s/hpux10-20.h (USG, USG5, HPUX):
1506 * s/gnu-linux.h (USG, GNU_LINUX):
1507 * s/freebsd.h (BSD_SYSTEM):
1508 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1509 * s/cygwin.h (CYGWIN):
1510 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1511 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1512
d1e68667 15132012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1514
1515 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1516
6de0e799
GM
15172012-07-13 Glenn Morris <rgm@gnu.org>
1518
739ae010
GM
1519 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1520
dbee5793
GM
1521 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1522
6de0e799
GM
1523 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1524 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1525
b82da769
GM
15262012-07-12 Glenn Morris <rgm@gnu.org>
1527
4fae5a7a 1528 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1529
1530 * process.c (init_process_emacs): Rename from init_process.
1531 The old name is also the name of a Mach system call.
1532 * lisp.h, emacs.c: Update for this name change.
1533 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1534 longer needed.
1535
5a979817
EZ
15362012-07-12 Eli Zaretskii <eliz@gnu.org>
1537
1538 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1539 memmove call that removes glyphs covered by the left truncation
1540 glyph. Improve commentary.
1541 (display_line): Fix display of continuation glyphs on GUI frames
1542 when the right fringe is turned off and variable-size fonts are
1543 used in the window. Move the code that appends a stretch glyph to
1544 produce_special_glyphs, so that it could be used for truncation
1545 and continuation glyphs alike.
1546 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1547 glyph of a suitably computed width, to align the special glyphs at
1548 the window margin. Code moved from display_line. (Bug#11832)
1549
3e91a053
GM
15502012-07-12 Glenn Morris <rgm@gnu.org>
1551
ba9e4b84
GM
1552 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1553
1554 * s/gnu-linux.h, s/hpux10-20.h:
1555 Do not unconditionally define HAVE_XRMSETDATABASE.
1556
3e91a053
GM
1557 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1558
b300b1f4
PE
15592012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1560
1561 Fix typos that broke OS X build.
1562 Reported by Randal L. Schwartz in
1563 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1564 * nsterm.m (ns_timeout): Add missing local decl.
1565 (ns_get_color): snprintf -> sprintf, to fix typo.
1566
6e777848
GM
15672012-07-12 Glenn Morris <rgm@gnu.org>
1568
3f922c37
GM
1569 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1570 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1571 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1572 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1573
0ab7b23a
GM
1574 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1575 Move PTY_OPEN to configure.
1576
6e777848
GM
1577 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1578 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1579 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1580
4a7edc24
DA
15812012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1582
1583 Use empty_unibyte_string where applicable.
1584 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1585 * lread.c (read1): Likewise.
1586 * xsettings.c (syms_of_xsettings): Likewise.
1587
308aab79
GM
15882012-07-12 Glenn Morris <rgm@gnu.org>
1589
42bd1719
GM
1590 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1591 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1592 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1593 * s/hpux10-20.h (RUN_TIME_REMAP):
1594 * s/bsd-common.h (TABDLY): Move to configure.
1595
1596 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1597
1598 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1599
ea0bbd17 1600 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1601 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1602
1603 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1604
308aab79
GM
1605 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1606 * s/template.h: Move NARROWPROTO to configure.
1607
ee1cf5cf
GM
16082012-07-11 Glenn Morris <rgm@gnu.org>
1609
30fe9bf4
GM
1610 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1611 unused since 2011-01-17 change to systty.h.
1612
ee1cf5cf
GM
1613 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1614 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1615 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1616
63e47e07
PE
16172012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1618
1619 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1620
c43fb4c3
GM
16212012-07-11 Glenn Morris <rgm@gnu.org>
1622
1623 * s/darwin.h, s/gnu-linux.h, s/template.h:
1624 Move INTERRUPT_INPUT to configure.
1625
e8df9267
DA
16262012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1627
1628 Minor adjustments to interning code.
1629 * lisp.h (intern, intern_c_string): Redefine as static inline
1630 wrappers for intern_1 and intern_c_string_1, respectively.
1631 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1632 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1633 Vobarray checking.
e8df9267
DA
1634 * font.c (font_intern_prop): Likewise. Adjust comment.
1635 * w32font.c (intern_font_name): Likewise.
1636
34348bd4
AS
16372012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1638
d96a1e0c
AS
1639 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1640
34348bd4
AS
1641 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1642 of Fcar/Fcdr if possible.
1643 * font.c (check_otf_features): Likewise.
1644 * fontset.c (Fnew_fontset): Likewise.
1645 * gnutls.c (Fgnutls_boot): Likewise.
1646 * minibuf.c (read_minibuf): Likewise.
1647 * msdos.c (IT_set_frame_parameters): Likewise.
1648 * xmenu.c (Fx_popup_dialog): Likewise.
1649 * w32menu.c (Fx_popup_dialog): Likewise.
1650
c8add24e
GM
16512012-07-11 Glenn Morris <rgm@gnu.org>
1652
4b575b3c
GM
1653 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1654 since nothing has defined it on these platforms.
1655
09f4e3b0
GM
1656 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1657 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1658
172bedef
GM
1659 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1660 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1661 Move CLASH_DETECTION to configure.
1662
249685df
GM
1663 * s/gnu.h: Remove file, which is now empty.
1664
c8add24e
GM
1665 * s/gnu.h, s/gnu-linux.h:
1666 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1667
b41253a3
JW
16682012-07-11 John Wiegley <johnw@newartisans.com>
1669
1670 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1671 function attribute, so we only use it if it exists in the
1672 compiler.
1673
d923b542
DA
16742012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1675
1676 Avoid call to strlen in fast_c_string_match_ignore_case.
1677 * search.c (fast_c_string_match_ignore_case): Change to use
1678 length argument. Adjust users accordingly.
1679 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1680
5ebbef1d
PE
16812012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1682
bb352260
PE
1683 Assume mkdir, rmdir.
1684 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1685 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1686
57054ddd
PE
1687 Assume rename.
1688 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1689
b747d3f7
PE
1690 Assume perror.
1691 * s/hpux10-20.h (HAVE_PERROR): Remove.
1692 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1693 Remove dummy definition, as this problem was obsolete long ago.
1694
5ebbef1d
PE
1695 Assume strerror.
1696 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1697
984e7f30
DA
16982012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1699
1700 Avoid calls to strlen in font processing functions.
1701 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1702 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1703 users accordingly.
d923b542
DA
1704 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1705 Adjust prototypes.
1706 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1707 Change to return ptrdiff_t.
984e7f30
DA
1708 (xfont_list_pattern, xfont_match): Use length returned by
1709 xfont_decode_coding_xlfd.
1710 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1711
20e94fdd
GM
17122012-07-11 Glenn Morris <rgm@gnu.org>
1713
9d596af3
GM
1714 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1715 Move DONT_REOPEN_PTY to configure.
1716
20e94fdd
GM
1717 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1718 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1719
e99a530f
PE
17202012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1721
22ffb973
PE
1722 Remove "#define unix" that is no longer needed (Bug#11905).
1723 * s/aix4-2.h (unix): Remove; no longer needed.
1724
e9a9ae03
PE
1725 EMACS_TIME simplification (Bug#11875).
1726 This replaces macros (which typically do not work in GDB)
1727 with functions, typedefs and enums, making the code easier to debug.
1728 The functional style also makes code easier to read and maintain.
1729 * systime.h: Include <sys/time.h> on all hosts, not just if
1730 WINDOWSNT, since 'struct timeval' is needed in general.
1731 (EMACS_TIME): Now a typedef, not a macro.
1732 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1733 not macros.
1734 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1735 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1736 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1737 (EMACS_TIME_LE): Now functions, not macros.
1738 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1739 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1740 which are not functions. All uses rewritten to use:
1741 (make_emacs_time): New function.
1742 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1743 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1744 not functions. All uses rewritten to use the following, respectively:
1745 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1746 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1747 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1748 * fileio.c (Fcopy_file):
1749 * xterm.c (XTflash): Get the current time closer to when it's used.
1750 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1751
ffacb126
PE
1752 * bytecode.c (targets): Suppress -Woverride-init warnings.
1753
e99a530f
PE
1754 Simplify by avoiding confusing use of strncpy etc.
1755 * doc.c (Fsnarf_documentation):
1756 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1757 * frame.c (Fmake_terminal_frame):
1758 * gtkutil.c (get_utf8_string):
1759 * lread.c (openp):
1760 * nsmenu.m (ns_update_menubar):
1761 * regex.c (regerror):
1762 Prefer memcpy to strncpy and strncat when either will do.
1763 * fileio.c (Fsubstitute_in_file_name):
1764 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1765 (menu_separator_name_p):
1766 * nsmenu.m (ns_update_menubar):
1767 Prefer memcmp to strncmp when either will do.
1768 * nsterm.m: Include <ftoastr.h>.
1769 (ns_get_color):
1770 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1771 Prefer snprintf to strncpy.
1772 * nsterm.m (ns_term_init):
1773 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1774 * nsterm.m (ns_term_init):
1775 Avoid the need for strncpy, by using build_string or
1776 make_unibyte_string directly. Use dtoastr, not snprintf.
1777 * process.c (Fmake_network_process): Diagnose service names that
1778 are too long, rather than silently truncating them or creating
1779 non-null-terminated names.
1780 (Fnetwork_interface_info): Likewise, for interface names.
1781 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1782 Prefer sprintf to strncat.
1783 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1784 Prefer vsnprintf to vsprintf + strncpy.
1785
c59592b3
GM
17862012-07-10 Glenn Morris <rgm@gnu.org>
1787
1788 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1789 Clarify fallback case.
1790
7d7bbefd
DA
17912012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1792
1793 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1794 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1795 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1796 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1797 where argument type is known to be a Lisp_Cons.
1798
3a4c8000
TT
17992012-07-10 Tom Tromey <tromey@redhat.com>
1800
1801 * bytecode.c (BYTE_CODE_THREADED): New macro.
1802 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1803 (enum byte_code_op): New type.
1804 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1805 (exec_byte_code): Use them. Use token threading when applicable.
1806
2a0213a6
DA
18072012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1808
1809 Optimize pure C strings initialization.
1810 * lisp.h (make_pure_string): Fix prototype.
1811 (build_pure_c_string): New function, defined as static inline. This
1812 provides a better opportunity to optimize away calls to strlen when
1813 the function is called with compile-time constant argument.
1814 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1815 argument, adjust users accordingly. Use build_pure_c_string where
1816 appropriate.
1817 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1818 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1819 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1820
cb1caeaf
DA
18212012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1822
1823 Avoid calls to strlen in miscellaneous functions.
1824 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1825 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1826 * lread.c (openp): Likewise.
1827
c293e30c
DA
18282012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1829
1830 Avoid calls to strlen in path processing functions.
1831 * fileio.c (file_name_as_directory): Add comment. Change to add
1832 srclen argument and return the length of result. Adjust users
1833 accordingly.
1834 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1835 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1836 users accordingly.
1837 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1838
9e059e3f
GM
18392012-07-10 Glenn Morris <rgm@gnu.org>
1840
d02eb359
GM
1841 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1842 Move PENDING_OUTPUT_COUNT definition to configure.
1843
882cf227
GM
1844 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1845 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1846 * s/gnu.h (DATA_START): Move definitions to configure.
1847
af6e839f
GM
1848 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1849 We include usg5-4-common.h, which defines them both.
1850
40289a12
GM
1851 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1852 O_RDONLY already includes it).
1853
9e059e3f
GM
1854 Stop ns builds setting the EMACSLOADPATH environment variable.
1855 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1856 Now it does not set EMACSLOADPATH, just returns the load-path string.
1857 * nsterm.h: Update accordingly.
1858 * lread.c [HAVE_NS]: Include nsterm.h.
1859 (init_lread) [HAVE_NS]: Use ns_load_path.
1860 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1861
7c4e8ec0
GM
18622012-07-09 Glenn Morris <rgm@gnu.org>
1863
d4f600ff
GM
1864 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1865 since the included bsd-common.h does so.
1866
cbb31951
GM
1867 Stop ns builds setting the EMACSPATH environment variable.
1868 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1869 (ns_init_paths): Do not set EMACSPATH.
1870 * nsterm.h (ns_exec_path): Add it.
1871 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1872 Use ns_exec_path.
1873
7c4e8ec0
GM
1874 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1875
26bccfae
PE
18762012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1877
a0bee46f
PE
1878 * process.c (wait_reading_process_output): 'waitchannels' was unset
1879 when read_kbd || !NILP (wait_for_cell); fix this.
1880
5994c183
PE
1881 Add GCC-style 'const' attribute to functions that can use it.
1882 * character.h (char_resolve_modifier_mask):
1883 * keyboard.h (make_ctrl_char):
1884 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1885 (init_character_once, next_almost_prime, init_fns, init_image)
1886 (flush_pending_output, init_sound):
1887 * mem-limits.h (start_of_data):
1888 * menu.h (finish_menu_items):
1889 Add ATTRIBUTE_CONST.
1890 * emacs.c (DEFINE_DUMMY_FUNCTION):
1891 Declare the dummy function with ATTRIBUTE_CONST.
1892 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1893 Add decls with ATTRIBUTE_CONST.
1894
26bccfae
PE
1895 Minor improvements to make_formatted_string.
1896 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1897 where int is good enough, as vsprintf returns an int.
1898 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1899
a8290ec3
DA
19002012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1901
1902 Use make_formatted_string to avoid double length calculation.
1903 * lisp.h (make_formatted_string): New prototype.
1904 * alloc.c (make_formatted_string): New function.
1905 * buffer.c (Fgenerate_new_buffer_name): Use it.
1906 * dbus.c (syms_of_dbusbind): Likewise.
1907 * editfns.c (Fcurrent_time_zone): Likewise.
1908 * filelock.c (get_boot_time): Likewise.
1909 * frame.c (make_terminal_frame, set_term_frame_name)
1910 (x_report_frame_params): Likewise.
1911 * image.c (gs_load): Likewise.
1912 * minibuf.c (get_minibuffer): Likewise.
1913 * msdos.c (dos_set_window_size): Likewise.
1914 * process.c (make_process): Likewise.
1915 * xdisp.c (ensure_echo_area_buffers): Likewise.
1916 * xsettings.c (apply_xft_settings): Likewise.
1917
d01ba2f1
GM
19182012-07-09 Glenn Morris <rgm@gnu.org>
1919
1920 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1921 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1922 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1923 * nsterm.h (ns_etc_directory): Add it.
1924 * callproc.c [HAVE_NS]: Include nsterm.h.
1925 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1926
f1f924b6
DA
19272012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1928
1929 Move marker debugging code under MARKER_DEBUG.
1930 * marker.c (MARKER_DEBUG): Move marker debugging code under
1931 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1932 for bootstrap with --enable-checking (~3x slowdown reported
1933 by Juanma Barranquero <lekktu@gmail.com>).
1934 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1935
ab531b66
PE
19362012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1937
1938 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1939 See <http://bugs.gnu.org/11825#29>.
1940
c4b3bc8a
EZ
19412012-07-08 Eli Zaretskii <eliz@gnu.org>
1942
1943 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1944 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1945 (display_line): Add commentary about displaying truncation glyphs
1946 on GUI frames.
1947 (produce_special_glyphs): Move here from term.c.
1948
1949 * term.c (produce_special_glyphs): Move to xdisp.c.
1950
1951 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1952 section.
c4b3bc8a 1953
b676b881
AS
19542012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1955
f17c5273
AS
1956 * xdisp.c (display_line): Avoid warning about implicit declaration
1957 of FRAME_FONT.
1958
298819b9
AS
1959 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1960
b676b881
AS
1961 * lisp.h: Remove empty conditional.
1962
6045c4fd
PE
19632012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1964
b3350bf9
PE
1965 * lread.c (load_path_check): Now static.
1966
6045c4fd
PE
1967 Fix some minor --with-ns problems found by static checking.
1968 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1969 (x_set_font) [!HAVE_X_WINDOWS]:
1970 * image.c (xpm_load_image) [HAVE_NS]:
1971 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1972 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1973 Remove unused local.
1974 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1975 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1976 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1977 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1978 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1979 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1980 Fix pointer signedness problem.
1981 * xfaces.c (FRAME_X_FONT_TABLE):
1982 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1983
929e7845
GM
19842012-07-07 Glenn Morris <rgm@gnu.org>
1985
1986 * lread.c (load_path_check): New function, split from init_lread.
1987 (init_lread): Reorganize. Motivation:
1988 If EMACSLOADPATH is set, check/warn about that rather than the
1989 defaults, which we are not going to use. Hence we can remove
1990 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1991 Don't warn if site-lisp directories are missing.
1992 If not installed, start from a blank load-path, since
1993 PATH_LOADSEARCH refers to the eventual installation directories.
1994
58dd0aa4
EZ
19952012-07-07 Eli Zaretskii <eliz@gnu.org>
1996
1997 Support truncation and continuation glyphs on GUI frames, when
1998 fringes are disabled. (Bug#11832)
1999 * xdisp.c (init_iterator): Get dimensions of truncation and
2000 continuation glyphs even if on GUI frames. Adjust
2001 it->last_visible_x on GUI frames when the left or right fringes,
2002 or both, are absent.
2003 (start_display, move_it_in_display_line_to): Handle the case of a
2004 GUI frame without a fringe to display continuation or truncation
2005 glyphs.
2006 (insert_left_trunc_glyphs): Support GUI frames: make sure
2007 truncation glyphs overwrite enough glyphs from the current line to
2008 have sufficient space in pixels.
2009 (display_line): Support truncation and continuation glyphs on GUI
2010 frames. If some spare pixels are left on the line after inserting
2011 the truncation glyphs, fill that space with a stretch glyph of a
2012 suitably computed width.
2013
2014 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2015 produce_glyphs, to support GUI sessions.
2016
31571fd7
PE
20172012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2018
5a16b9bc
PE
2019 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2020
f3047c75
PE
2021 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2022
31571fd7
PE
2023 Do not require float-time's arg to fit in time_t (Bug#11825).
2024 This works better on hosts where time_t is unsigned, and where
2025 float-time is applied to the (negative) difference between two times.
2026 * editfns.c (decode_time_components): Last arg is now double *,
2027 not int *, and means to store all the result as a double, without
2028 worrying about whether the seconds part fits in time_t.
2029 All callers changed.
2030 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2031 All callers changed.
2032 (Ffloat_time): Do not fail merely because the specified time falls
2033 outside of time_t range.
2034
4516fbef
GM
20352012-07-07 Glenn Morris <rgm@gnu.org>
2036
2037 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2038 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2039 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2040
07adc2c6
JB
20412012-07-07 Juanma Barranquero <lekktu@gmail.com>
2042
2043 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2044 Update dependencies.
2045
2046 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2047
fd573f31
PE
20482012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2049
fee5959d
PE
2050 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2051 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2052 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2053 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2054 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2055 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2056
fd573f31
PE
2057 * xfont.c (compare_font_names): Redo to omit the need for casts.
2058
ddadbc0e
AS
20592012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2060
fca8d6b6
AS
2061 * xfns.c (Fx_change_window_property): Doc fix.
2062 * w32fns.c (Fx_change_window_property): Doc fix.
2063
ddadbc0e
AS
2064 * w32fns.c (Fx_window_property): Accept the same arguments as the
2065 X Windows version. Doc fix.
2066 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2067
ed9265fc 20682012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2069 Eli Zaretskii <eliz@gnu.org>
2070
2071 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2072 Windows-specific code from nt/config.nt moved here.
2073 Obsolete settings removed.
2074
216ee680
PE
20752012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 * process.c: Avoid unnecessary calls to gettime.
2078 (wait_reading_process_output): Don't get the time of day
2079 when gobbling data immediately and not waiting, as there's no need
2080 for it in that case. This removes a FIXME.
2081
bdd091e4
JD
20822012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2083
2084 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2085 is defined (Bug#11768).
2086
9d44f8ce
DA
20872012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2088
2089 Fix marker debugging code.
2090 * marker.c (byte_char_debug_check): Do not perform the check
2091 if buffer is not multibyte.
090bd7cb
JB
2092 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2093 Call byte_char_debug_check with correct arguments.
9d44f8ce 2094
90fc4786
DA
20952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2096
2097 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2098 * marker.c (byte_char_debug_check, count_markers):
2099 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2100 (byte_debug_flag): Remove.
2101 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2102 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2103
7b7ae965
DA
21042012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2105
4e57b342
DA
2106 Avoid code repetition in marker-related functions.
2107 * marker.c (attach_marker): New function.
2108 (Fset_marker, set_marker_restricted, set_marker_both)
2109 (set_marker_restricted_both): Use it.
2110 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2111 Consistently rename charno to charpos.
2112 (marker_position): Add eassert.
2113 (marker_byte_position): Convert to eassert.
2114
21152012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2116
2117 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2118 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2119 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2120
657924ff
DA
21212012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2122
2123 Introduce fast path for the widely used marker operation.
2124 * alloc.c (build_marker): New function.
2125 * lisp.h (build_marker): New prototype.
2126 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2127 * composite.c (autocmp_chars): Likewise.
2128 * editfns.c (buildmark): Remove.
2129 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2130 (save_restriction_save): Use build_marker.
2131 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2132 * window.c (save_window_save): Likewise.
2133
041a49a6
DA
21342012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2135
2136 Do not use Fdelete_overlay in delete_all_overlays
2137 to avoid redundant calls to unchain_overlay.
2138 * buffer.c (drop_overlay): New function.
2139 (delete_all_overlays, Fdelete_overlay): Use it.
2140 * minibuf.c (get_minibuffer): Fix comment.
2141
7dca65a4
PE
21422012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2143
2144 Port to OpenBSD 5.1 amd64.
2145 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2146 This is needed for OpenBSD, and should be harmless on all BSD systems.
2147 Also, include <sys/sysctl.h>, as it should be available on all
2148 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2149 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2150 use p_pid member, not kp_proc.pid.
2151
8eb876e2
GM
21522012-07-06 Glenn Morris <rgm@gnu.org>
2153
2154 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2155
38182d90
PE
21562012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 More xmalloc and related cleanup.
2159 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2160 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2161 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2162 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2163 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2164 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2165 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2166 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2167 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2168 * xterm.c:
2169 Omit needless casts involving void * pointers and allocation.
2170 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2171 as the former is more robust if P's type is changed.
2172 Prefer xzalloc to xmalloc + memset 0.
2173 Simplify malloc-or-realloc to realloc.
2174 Don't worry about xmalloc returning a null pointer.
2175 Prefer xstrdup to xmalloc + strcpy.
2176 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2177 growing it.
2178 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2179 alloca of a constant.
2180
6dd5a677
EZ
21812012-07-05 Eli Zaretskii <eliz@gnu.org>
2182
2183 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2184 hscroll is larger than the line width. Fixes long and futile
2185 looping inside extend_face_to_end_of_line (on a TTY) producing
2186 glyphs that are not needed and thrown away.
2187
6b312f0f
DA
21882012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2189
2190 * marker.c (set_marker_restricted_both): Simplify by using
2191 clip_to_bounds.
2192
f520ef9b
PE
21932012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2194
2195 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2196
383b7c95
JD
21972012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2198
2199 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2200 not defined (Bug#11768).
2201 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2202 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2203 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2204 followed by gtk_box_set_homogeneous (Bug#11768).
2205 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2206 (update_theme_scrollbar_width, xg_create_scroll_bar):
2207 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2208 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2209 (is_box_type): New function (Bug#11768).
2210 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2211 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2212 with default display (Bug#11768).
2213
d6e7bf45
EZ
22142012-07-05 Eli Zaretskii <eliz@gnu.org>
2215
2216 * xdisp.c (window_hscroll_limited): New function.
2217 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2218 coordinates when window's hscroll is set to insanely large
2219 values. (Bug#11857)
2220
431391ec
JB
22212012-07-05 Juanma Barranquero <lekktu@gmail.com>
2222
2223 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2224 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2225
23f86fce
DA
22262012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2227
2228 Cleanup xmalloc.
2229 * lisp.h (xzalloc): New prototype. Omit needless casts.
2230 * alloc.c (xzalloc): New function. Omit needless casts.
2231 * charset.c: Omit needless casts. Convert all calls to
2232 xmalloc with following memset to xzalloc.
2233 * dispnew.c: Likewise.
2234 * fringe.c: Likewise.
2235 * image.c: Likewise.
2236 * sound.c: Likewise.
2237 * term.c: Likewise.
2238 * w32fns.c: Likewise.
2239 * w32font.c: Likewise.
2240 * w32term.c: Likewise.
2241 * xfaces.c: Likewise.
2242 * xfns.c: Likewise.
2243 * xterm.c: Likewise.
2244 * atimer.c: Omit needless casts.
2245 * buffer.c: Likewise.
2246 * callproc.c: Likewise.
2247 * ccl.c: Likewise.
2248 * coding.c: Likewise.
2249 * composite.c: Likewise.
2250 * doc.c: Likewise.
2251 * doprnt.c: Likewise.
2252 * editfns.c: Likewise.
2253 * emacs.c: Likewise.
2254 * eval.c: Likewise.
2255 * filelock.c: Likewise.
2256 * fns.c: Likewise.
2257 * gtkutil.c: Likewise.
2258 * keyboard.c: Likewise.
2259 * lisp.h: Likewise.
2260 * lread.c: Likewise.
2261 * minibuf.c: Likewise.
2262 * msdos.c: Likewise.
2263 * print.c: Likewise.
2264 * process.c: Likewise.
2265 * region-cache.c: Likewise.
2266 * search.c: Likewise.
2267 * sysdep.c: Likewise.
2268 * termcap.c: Likewise.
2269 * terminal.c: Likewise.
2270 * tparam.c: Likewise.
2271 * w16select.c: Likewise.
2272 * w32.c: Likewise.
2273 * w32reg.c: Likewise.
2274 * w32select.c: Likewise.
2275 * w32uniscribe.c: Likewise.
2276 * widget.c: Likewise.
2277 * xdisp.c: Likewise.
2278 * xmenu.c: Likewise.
2279 * xrdb.c: Likewise.
2280 * xselect.c: Likewise.
2281
0497dc44
PE
22822012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2283
2284 * fileio.c (time_error_value): Check the right error number.
2285 Problem reported by Troels Nielsen in
2286 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2287
356e7178
PE
22882012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2289
4e71fd89
PE
2290 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2291 This should be fixed in a better way; see Eli Zaretskii in
2292 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2293 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2294
f0941253
PE
2295 * fileio.c (time_error_value): Rename from special_mtime.
2296 The old name's problems were noted by Eli Zaretskii in
2297 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2298
065c9eb4
PE
2299 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2300 This variable's comment says Emacs needs at least one GDB-visible
2301 symbol of type enum pvec_type, to work around GDB problems.
2302 The symbol's value doesn't matter.
2303
356e7178
PE
2304 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2305 that causes compilation to fail on pre-C99 compilers.
2306
ed9265fc 23072012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2308
2309 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2310 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2311
3884d954
DA
23122012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2313
d209e2fb 2314 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2315 headers for buffer_defaults and buffer_local_symbols.
2316 Reported by Juanma Barranquero <lekktu@gmail.com>.
2317
ee28be33
SM
23182012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2319
2320 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2321 * lisp.h (enum pvec_type): Use fewer bits.
2322 (PSEUDOVECTOR_SIZE_BITS): New constant.
2323 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2324 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2325 change in pvec_type.
2326 (PSEUDOVECTOR_TYPEP): New macro.
2327 (TYPED_PSEUDOVECTORP): Use it.
2328 * fns.c (internal_equal): Adapt code to extract pvectype.
2329 * emacs.c (gdb_pvec_type): Update type.
2330 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2331 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2332 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2333 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2334 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2335 abusing vector->header.next.nbytes.
2336 (live_vector_p): Use PVEC_TYPE.
2337 (mark_object): Adapt code to extract pvectype. Use switch.
2338
c7f2cd7f
PE
23392012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2340
2341 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2342 Tighten new eassert a bit.
2343
8ce70ed2
DA
23442012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2345
2346 Fix compilation with --enable-gcc-warnings and -O1
2347 optimization level.
2348 * doprnt.c (doprnt): Change type of tem to int, initialize
2349 to avoid compiler warning. Add eassert.
2350 * search.c (simple_search): Initialize match_byte to avoid
2351 compiler warning. Add eassert.
2352
dea7f1e5
PE
23532012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2354
24a212eb
PE
2355 Avoid weird behavior with large horizontal scrolls.
2356 Without this change, for example, large hscroll values would
2357 mess up Emacs's display on Fedora 15 x86, presumably due to
2358 overflows in int calculations in the display code.
2359 Also, if buffers had long lines, Emacs would freeze.
2360 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2361 (set_window_hscroll): New function, containing the old guts of
2362 Fset_window_hscroll. Return the clipped value.
2363 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2364 This avoids the need to check against PTRDIFF_MAX.
2365
dea7f1e5
PE
2366 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2367
76046526
DA
23682012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2369
2370 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2371
39adff0d
PE
23722012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2373
63807d47
PE
2374 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2375 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2376 since GCC 4.4.6 issues a bogus warning for them.
2377
39adff0d
PE
2378 Fix bugs in file timestamp newness comparisons.
2379 * fileio.c (Ffile_newer_than_file_p):
2380 * lread.c (Fload): Use full timestamp resolution of files,
2381 not just the 1-second resolution, so that files that are only
2382 slightly newer still count as newer.
2383 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2384 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2385
dbeed9a6
PE
23862012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2387
2388 * fileio.c: Improve handling of file time marker. (Bug#11852)
2389 (special_mtime): New function.
2390 (Finsert_file_contents, Fverify_visited_file_modtime):
2391 Use it to set special mtime values consistently.
2392
636334d6
AS
23932012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2394
2395 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2396 marker for non-existing file. (Bug#11852)
2397
e2017fe2
GM
23982012-07-03 Glenn Morris <rgm@gnu.org>
2399
2400 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2401 and did not make it into globals.h).
2402
404dbd37
TT
24032012-07-03 Tom Tromey <tromey@redhat.com>
2404
2405 * window.c (Fset_window_margins, Fset_window_fringes)
2406 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2407 * textprop.c (Fprevious_property_change): No longer static.
2408 * syntax.c (Fsyntax_table_p): No longer static.
2409 * process.c (Fget_process, Fprocess_datagram_address): No longer
2410 static.
2411 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2412 * keyboard.c (Fcommand_execute): No longer static.
2413 Remove EXFUN.
2414 * insdel.c (Fcombine_after_change_execute): No longer static.
2415 * image.c (Finit_image_library): No longer static.
2416 * fileio.c (Fmake_symbolic_link): No longer static.
2417 * eval.c (Ffetch_bytecode): No longer static.
2418 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2419 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2420 No longer static.
404dbd37
TT
2421 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2422 static.
2423 * dired.c (Ffile_attributes): No longer static.
2424 * composite.c (Fcomposition_get_gstring): No longer static.
2425 * callproc.c (Fgetenv_internal): No longer static.
2426
2427 * ccl.h: Remove EXFUNs.
2428 * buffer.h: Remove EXFUNs.
2429 * dispextern.h: Remove EXFUNs.
2430 * intervals.h: Remove EXFUNs.
2431 * fontset.h: Remove EXFUN.
2432 * font.h: Remove EXFUNs.
2433 * dosfns.c (system_process_attributes): Remove EXFUN.
2434 * keymap.h: Remove EXFUNs.
2435 * lisp.h: Remove EXFUNs.
2436 * w32term.h: Remove EXFUNs.
2437 * window.h: Remove EXFUNs.
2438 * xsettings.h: Remove EXFUN.
2439 * xterm.h: Remove EXFUN.
2440
8e4fd1e1
GM
24412012-07-03 Glenn Morris <rgm@gnu.org>
2442
2443 * lisp.h (Frandom): Make it visible to C.
2444 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2445 buffer for invisible buffers. (Bug#1229)
2446
ca95b3eb
DA
24472012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2448
2449 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2450 values which aren't power of 2.
2451 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2452 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2453 accordingly.
2454
7555c33f
SM
24552012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2456
2457 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2458
2459 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2460
d12e8f5a
DA
24612012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2462
2463 * alloc.c (allocate_vector_block): Remove redundant
2464 calls to mallopt if DOUG_LEA_MALLOC is defined.
2465 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2466 avoid calls to mallopt if zero_vector is returned.
2467
296094c3
DA
24682012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2469
2470 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2471 is enabled, avoid dereferencing NULL current_sblock if
2472 running undumped.
2473
36429c89
DA
24742012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2475
2476 Cleanup basic buffer management.
2477 * buffer.h (struct buffer): Change layout to use generic vector
2478 marking code. Fix some comments. Change type of 'clip_changed'
2479 to bitfield. Remove unused #ifndef old.
2480 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2481 (GET_OVERLAYS_AT): Fix indentation.
2482 (for_each_per_buffer_object_at): New macro.
2483 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2484 (Fbuffer_local_variables): Use it.
2485 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2486 * alloc.c (allocate_buffer): Adjust to match new layout of
2487 struct buffer. Fix comment.
2488 (mark_overlay): New function.
2489 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2490 Lisp area of struct buffer.
2491 (mark_object): Use it. Adjust marking of misc objects
2492 and related comments.
2493
3b3e4cac
PE
24942012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2495
2496 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2497 wrapper that is not needed because the wrapped code is a no-op (zero
2498 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2499 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2500
cf5c0175
DA
25012012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2502
2503 * alloc.c (mark_buffer): Simplify. Remove prototype.
2504 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2505 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2506 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2507 redundant calls to mark_vectorlike for bool vectors.
2508
ca26824c
GM
25092012-06-30 Glenn Morris <rgm@gnu.org>
2510
2e4c5312
GM
2511 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2512
ca26824c
GM
2513 * epaths.in (PATH_SITELOADSEARCH): New.
2514 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2515 This is rather than relying on --enable-locallisppath elements
2516 having "site-lisp" in their names. (Bug#10208#25, 11658)
2517
0d23c240
EZ
25182012-06-30 Eli Zaretskii <eliz@gnu.org>
2519
c9240d7a
EZ
2520 * w32proc.c (sys_select): Accept and ignore one more argument.
2521
2522 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2523
0d23c240 2524 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2525 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2526
2527 * sysdep.c: Don't include dos.h and dosfns.h.
2528
2529 * process.c (sys_select):
2530 * msdos.c (sys_select): Accept one more argument and ignore it.
2531
2532 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2533 adapt data types and code to that.
2534
2535 * dosfns.c:
2536 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2537 which clashes with the gnulib function of the same name.
2538
af5a5a98
AS
25392012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2540
c5e4379c
AS
2541 * font.c (font_style_to_value, font_style_symbolic)
2542 (font_prop_validate_style): Add type checks for values in
2543 font_style_table.
2544
af5a5a98
AS
2545 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2546 argument.
2547 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2548 uses.
2549
8d38f461
EZ
25502012-06-29 Eli Zaretskii <eliz@gnu.org>
2551
2e5a6631
EZ
2552 * xdisp.c (try_window_id): Undo last change.
2553
8d38f461
EZ
2554 * w32.c (getwd): Adjust commentary about startup_dir.
2555 (init_environment): Always call sys_access, even in non-MSVC
2556 builds. Don't chdir to the directory of the Emacs executable.
2557 This undoes code from 1997 which was justified by the need to
2558 "avoid conflicts when removing and renaming directories". But its
2559 downside was that every relative file name was being interpreted
2560 relative to the directory of the Emacs executable, which can never
2561 be TRT. In particular, it broke sys_access when called with
2562 relative file names.
2563 (sys_access): Map GetLastError to errno.
2564
2af3565e
DA
25652012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2566
2567 * window.h (struct window): Change type of 'fringes_outside_margins'
2568 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2569 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2570 Adjust comment.
2571 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2572 to ptrdiff_t.
2573
c8d3a25c 25742012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2575
c8d3a25c
GM
2576 * gnutls.c (emacs_gnutls_handshake):
2577 Add QUIT to make the loop interruptible.
57570cd3 2578
c8d3a25c 25792012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2580
c8d3a25c
GM
2581 * charset.c (init_charset): Make lack of etc/charsets fatal.
2582
3e984ee8
DA
25832012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2584
2585 * editfns.c (region_limit): Fix type mismatch.
2586
ef884f23
DA
25872012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2588
2589 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2590 undefined. Convert from xassert to eassert.
2591 * nsmenu.m: Convert from xassert to eassert.
2592 * nsterm.m: Likewise.
2593
7d7e0027
SM
25942012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2595
2596 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2597
aa754e6a
PE
25982012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2599
2600 Avoid integer overflow on scroll-left and scroll-right.
2601 * window.c (HSCROLL_MAX): New macro.
2602 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2603 overflow when requested scroll falls outside ptrdiff_t range.
2604
80b00b08
DA
26052012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2606
2607 * window.h (struct window): Change type of 'hscroll',
2608 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2609 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2610 Adjust users accordingly.
2611 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2612 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2613 from EMACS_INT to ptrdiff_t.
2614 (make_window): Omit redundant initialization.
2615
62b2bcf6
JB
26162012-06-28 Juanma Barranquero <lekktu@gmail.com>
2617
2618 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2619
45942c7d
DA
26202012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2621
2622 * window.h (struct window): Change type of 'use_time' and
2623 'sequence_number' from Lisp_Object to int.
2624 * frame.c (make_frame): Adjust users accordingly.
2625 * print.c (print_object): Likewise.
2626 * window.c (select_window, Fwindow_use_time, make_parent_window)
2627 (make_window): Likewise.
2628
e509cfa6
DA
26292012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2630
2631 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2632 enabled with --enable-checking=[all,glyphs] configure option.
2633 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2634 adjust comments accordingly.
2635 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2636 undefined, adjust comments accordingly.
2637 * image.c: Likewise.
2638 * scroll.c: Likewise.
2639 * w32fns.c: Likewise.
2640 * w32term.c: Likewise.
2641 * xdisp.c: Likewise.
2642 * xfaces.c: Likewise.
2643 * xfns.c: Likewise.
2644 * xterm.c: Likewise.
2645
a54e2c05
DA
26462012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2647
2648 Generalize run-time debugging checks.
2649 * dispextern.h (XASSERTS): Remove.
2650 * fontset.c (xassert): Remove.
2651 Convert from xassert to eassert.
2652 * alloc.c: Convert from xassert to eassert.
2653 * bidi.c: Likewise.
2654 * dispnew.c: Likewise.
2655 * fns.c: Likewise.
2656 * fringe.c: Likewise.
2657 * ftfont.c: Likewise.
2658 * gtkutil.c: Likewise.
2659 * image.c: Likewise.
2660 * keyboard.c: Likewise.
2661 * menu.c: Likewise.
2662 * process.c: Likewise.
2663 * scroll.c: Likewise.
2664 * sound.c: Likewise.
2665 * term.c: Likewise.
2666 * w32console.c: Likewise.
2667 * w32fns.c: Likewise.
2668 * w32term.c: Likewise.
2669 * window.c: Likewise.
2670 * xdisp.c: Likewise.
2671 * xfaces.c: Likewise.
2672 * xfns.c: Likewise.
2673 * xselect.c: Likewise.
2674 * xterm.c: Likewise.
2675
1ec4b7b2
SM
26762012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2677
2678 * fns.c (maybe_resize_hash_table): Output message when growing the
2679 purify-hashtable.
2680
2014308a
DA
26812012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2682
2683 * alloc.c (allocate_string_data): Remove dead code.
2684 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2685 avoid GCC warning about unused macro.
2686
246155eb
DA
26872012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2688
2689 * alloc.c (allocate_string): Omit intervals initialization.
2690 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2691 as in make_pure_string and make_pure_c_string.
2692
43184b7b
DA
26932012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2694
d209e2fb 2695 * alloc.c (allocate_string): Fix last change.
43184b7b 2696
3fe6dd74
DA
26972012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2698
d209e2fb 2699 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2700 to memset, add explicit initialization where appropriate.
2701
1ba6038a
GM
27022012-06-27 Glenn Morris <rgm@gnu.org>
2703
2704 * lisp.mk (lisp): Remove paths.elc.
2705
c89926a5
CY
27062012-06-27 Chong Yidong <cyd@gnu.org>
2707
2708 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2709
ed6b3510
JW
27102012-06-26 John Wiegley <johnw@newartisans.com>
2711
1ec4b7b2 2712 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2713 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2714
ed6b3510
JW
2715 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2716 when building with Clang.
2717
8edd4a2b
SM
27182012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2719
2720 * eval.c (Fapply): Allow calling it with a single argument.
2721
f6f62d1b
EZ
27222012-06-26 Eli Zaretskii <eliz@gnu.org>
2723
2724 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2725 _stricmp and _strnicmp.
2726 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2727
62efea5e
DA
27282012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2729
2730 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2731 allocated window.
2732 (allocate_process): Likewise for new process.
8edd4a2b 2733 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2734 (allocate_frame): Likewise.
2735 * frame.c (make_frame): Omit redundant initialization.
2736 * window.c (make_parent_window): Use memset.
2737 (make_window): Omit redundant initialization.
2738 * process.c (make_process): Omit redundant initialization.
2739 * terminal.c (create_terminal): Likewise.
2740
42997f4d
DA
27412012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2742
2743 * term.c (delete_tty): Remove redundant call to memset.
2744
1130ecfc
DA
27452012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2746
2747 * alloc.c: Remove build_string.
2748 * lisp.h: Define build_string as static inline. This provides
2749 a better opportunity to optimize away calls to strlen when the
2750 function is called with compile-time constant argument.
2751 * image.c (imagemagick_error): Convert to build_string.
2752 * w32proc.c (sys_spawnve): Likewise.
2753 * xterm.c (x_term_init): Likewise.
2754
cf38a720
PE
27552012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2756
99027bdd
PE
2757 Use sprintf return value instead of invoking strlen on result.
2758 In the old days this wasn't portable, since some sprintf
2759 implementations returned char *. But they died out years ago and
2760 Emacs already assumes sprintf returns int.
2761 Similarly for float_to_string.
2762 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2763 * ccl.c (ccl_driver):
2764 * character.c (string_escape_byte8):
2765 * data.c (Fnumber_to_string):
2766 * doprnt.c (doprnt):
2767 * print.c (print_object):
2768 * xdisp.c (message_dolog):
2769 * xfns.c (syms_of_xfns):
2770 Use sprintf or float_to_string result to avoid need to call strlen.
2771 * data.c (Fnumber_to_string):
2772 Use make_unibyte_string, since the string must be ASCII.
2773 * lisp.h, print.c (float_to_string): Now returns int length.
2774 * term.c (produce_glyphless_glyph):
2775 Use sprintf result rather than recomputing it.
2776
cf38a720
PE
2777 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2778 * Makefile.in (ALL_CFLAGS):
2779 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2780 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2781
3511c784
DA
27822012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2783
0a08eb21 2784 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2785 strcasecmp if available.
2786 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2787
fb7da12e
AS
27882012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2789
2790 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2791 Avoid comma operator.
2792 * menu.c (push_submenu_start, push_submenu_end)
2793 (push_left_right_boundary, push_menu_pane): Likewise.
2794 * msdos.c (dos_rawgetc): Likewise.
2795
afa2ffd8
DA
27962012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2797
2798 * xfns.c (xic_create_fontsetname): Remove redundant calls
2799 to memset.
2800
b3b4476b
PE
28012012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2802
4495ff38
PE
2803 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2804 sprintf already null-terminates its output.
2805
b3b4476b
PE
2806 * xfns.c (x_window): Remove redundant cast.
2807
b00876c9
DA
28082012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2809
2810 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2811 `const char *' to `char *' to avoid compiler warning.
2812
d188e26b
PE
28132012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2814
885d1d74
PE
2815 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2816 instead of truncating it to 63 (admittedly a generous limit).
2817
d188e26b
PE
2818 * process.c: Fix spelling and caps in comments.
2819
e2f560b1
DN
28202012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2821
e86db54b 2822 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2823 * sysdep.c (setpgrp): Remove definition, not used in this file.
2824
7583a3a1
JB
28252012-06-24 Juanma Barranquero <lekktu@gmail.com>
2826
2827 * makefile.w32-in: Update dependencies.
2828
696056c2
EZ
28292012-06-24 Eli Zaretskii <eliz@gnu.org>
2830
2831 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2832 (SYSTIME_H): Add nt/inc/sys/time.h.
2833
2834 * systime.h [WINDOWSNT]: Include sys/time.h.
2835
2836 * s/ms-w32.h (struct timespec): Definition moved from
2837 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2838
845ca893
PE
28392012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2840
2841 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2842 * buffer.h (buffer_slot_type_mismatch):
2843 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2844 * eval.c (unwind_to_catch):
2845 * image.c (my_png_error, my_error_exit):
2846 * keyboard.c (quit_throw_to_read_char, user_error)
2847 (Fexit_recursive_edit, Fabort_recursive_edit):
2848 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2849 (wrong_type_argument, buffer_overflow, __executable_start)
2850 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2851 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2852 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2853 (fatal):
2854 (child_setup) [!DOS_NT]:
2855 * lread.c (end_of_file_error, invalid_syntax):
2856 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2857 * puresize.h (pure_write_error):
2858 * search.c (matcher_overflow):
2859 * sound.c (sound_perror, alsa_sound_perror):
2860 * sysdep.c, syssignal.h (croak):
2861 * term.c (maybe_fatal, vfatal):
2862 * textprop.c (text_read_only):
2863 * undo.c (user_error):
2864 * unexmacosx.c (unexec_error):
2865 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2866 Use _Noreturn rather than NO_RETURN.
2867 No need for separate decl merely because of _Noreturn.
2868 * sound.c (sound_warning, parse_sound):
2869 Remove unnecessary forward decls.
2870
f1dd8073
PE
28712012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2874 * lisp.h (WAIT_READING_MAX): New macro.
2875 * dispnew.c (Fsleep_for, sit_for):
2876 * keyboard.c (kbd_buffer_get_event):
2877 * process.c (Faccept_process_output):
2878 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2879 This improves on the previous patch, which introduced a bug
2880 when time_t is unsigned and as wide as intmax_t.
2881 See <http://bugs.gnu.org/9000#51>.
2882
b82c1755
EZ
28832012-06-23 Eli Zaretskii <eliz@gnu.org>
2884
2885 * dispnew.c (sit_for, Fsleep_for):
2886 * keyboard.c (kbd_buffer_get_event):
2887 * process.c (Faccept_process_output): Avoid compiler warnings when
2888 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2889
ca300656
JB
28902012-06-23 Juanma Barranquero <lekktu@gmail.com>
2891
049ec95b
JB
2892 * makefile.w32-in: Update dependencies.
2893
ca300656
JB
2894 * w32.c (ltime): Add return type and declare static.
2895 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2896
db7b8d06
PE
28972012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2900 Privately reported by Herbert J. Skuhra.
2901 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2902 All uses changed.
2903 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2904 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2905
0bd8297f
EZ
29062012-06-23 Eli Zaretskii <eliz@gnu.org>
2907
96512555
EZ
2908 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2909 last argument of make_unibyte_string.
2910
0bd8297f
EZ
2911 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2912 language ID in the event parameters.
2913
2914 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2915 event.code, not the obscure "character set ID".
2916
63def6b6
CY
29172012-06-23 Chong Yidong <cyd@gnu.org>
2918
2919 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2920
e8a02204
EZ
29212012-06-23 Eli Zaretskii <eliz@gnu.org>
2922
388cdec0
EZ
2923 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2924 * w32.c (fdutimens): New function.
2925
2926 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2927
2928 * s/ms-w32.h (pselect): Redirect to sys_select.
2929
2930 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2931
e8a02204
EZ
2932 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2933 in the logic of incrementing and decrementing the value of
2934 use_relocatable_buffers.
2935
d054f3fb
PE
29362012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2937
2938 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2939 Privately reported by Herbert J. Skuhra.
2940 [__FreeBSD__]: Remove "*/" typo after "#include".
2941 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2942 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2943 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2944 Don't assume EMACS_TIME and struct timeval are the same type.
2945
d35af63c
PE
29462012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2947
2948 Support higher-resolution time stamps (Bug#9000).
2949 The time stamps are only nanosecond-resolution at the C level,
2950 since that's the best that any real-world system supports now.
2951 But they are picosecond-resolution at the Lisp level, as that's
2952 easy, and leaves room for future OS improvements.
2953
2954 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2955 (LIBES): Use it.
2956
2957 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2958 Don't get current time unless it's needed.
2959
2960 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2961 now provides it if it's absent.
2962 (start_atimer): Port to higher-res time stamps.
2963 Check for time stamp overflow. Don't get current time more
2964 often than is needed.
2965
2966 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2967 Include systime.h, not time.h.
2968 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2969
2970 * dired.c: Include stat-time.h.
2971 (Ffile-attributes): File times now have higher resolution.
2972
2973 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2974 (struct image): Timestamp now has higher resolution.
2975
2976 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2977 has at least microseconds now. All uses removed.
2978 (update_frame, update_single_window, update_window, update_frame_1)
2979 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2980
2981 * editfns.c (time_overflow): Now extern.
2982 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2983 (float-time, Fformat_time_string, Fcurrent_time_string)
2984 (Fcurrent_time_zone): Accept and generate higher-resolution
2985 time stamps.
2986 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2987 (decode_time_components, lisp_seconds_argument): New functions.
2988 (make_time): Now static.
2989 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2990 Report an error if the time is invalid, rather than having the caller
2991 do that.
2992
2993 * fileio.c: Include <stat-time.h>
2994 (Fcopy_file): Copy higher-resolution time stamps.
2995 Prefer to set the time stamp via a file descriptor if that works.
2996 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2997 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2998 (Fvisited_file_modtime, Fset_visited_file_modtime):
2999 Support higher-resolution time stamps.
3000
3001 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3002
3003 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3004
3005 * image.c (prepare_image_for_display, clear_image_cache)
3006 (lookup_image): Port to higer-resolution time stamps.
3007
3008 * keyboard.c (start_polling, bind_polling_period):
3009 Check for time stamp overflow.
3010 (read_char, kbd_buffer_get_event, timer_start_idle)
3011 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3012 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3013 Port to higher-resolution time stamps. Do not assume time_t is signed.
3014 (decode_timer): New function. Timers are now vectors of length 9,
3015 not 8, to accommodate the picosecond component.
3016 (timer_check_2): Use it.
3017
3018 * nsterm.m (select_timeout, timeval_subtract): Remove.
3019 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3020 as they're a bit more accurate and handle overflow better.
3021 (ns_select): Change prototype to be compatible with pselect.
3022 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3023 * nsterm.h (ns_select): Adjust prototype.
3024
3025 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3026 us-resolution time stamps.
3027 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3028
3029 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3030
3031 * lisp.h (time_overflow): New decl.
3032 (wait_reading_process_output): First arg is now intmax_t, not int,
3033 to accommodate larger waits.
3034
3035 * process.h (struct Lisp_Process.read_output_delay):
3036 Now counts nanoseconds, not microseconds.
3037 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3038 EMACS_HAS_USECS.
3039 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3040 (wait_reading_process_output):
3041 Port to ns-resolution time stamps.
3042 (Faccept_process_output, wait_reading_process_output):
3043 Check for time stamp overflow. Do not assume time_t is signed.
3044 (select_wrapper): Remove; we now use pselect.
3045 (Fprocess_attributes): Now generates ns-resolution time stamps.
3046
3047 * sysdep.c: Include utimens.h. Don't include utime.h
3048 or worry about struct utimbuf; gnulib does that for us now.
3049 (gettimeofday): Remove; gnulib provides a substitute.
3050 (make_timeval): New function.
3051 (set_file_times): Now sets ns-resolution time stamps.
3052 New arg FD; all uses changed.
3053 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3054 (system_process_attributes):
3055 Now returns ns-resolution time stamp. All uses changed.
3056 Check for time stamp overflow.
3057
3058 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3059 provides a substitute now.
3060
3061 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3062 since it guarantees struct timespec.
3063 (EMACS_TIME): Now struct timespec, so that we can support
3064 ns-resolution time stamps.
3065 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3066 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3067 (EMACS_USECS): Remove.
3068 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3069 so multiply the arg by 1000 before storing it.
3070 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3071 New macros.
3072 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3073 Port to ns-resolution time stamps.
3074 (EMACS_TIME_NEG_P): Remove; replaced by....
3075 (EMACS_TIME_SIGN): New macro.
3076 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3077 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3078 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3079 (make_timeval, make_lisp_time, decode_time_components): New decls.
3080 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3081 that it mishandled time_t overflow. You can't compare by subtracting!
3082 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3083 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3084
3085 * term.c: Include <sys/time.h>.
3086 (timeval_to_Time): New function, for proper overflow wraparound.
3087 (term_mouse_position, term_mouse_click): Use it.
3088
3089 * undo.c (record_first_change): Support higher-resolution time stamps
3090 in the undo buffer.
3091 (Fprimitive_undo): Use them when restoring time stamps.
3092
3093 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3094 (w32_get_internal_run_time):
3095 Port to higher-resolution Emacs time stamps.
3096 (ltime): Now accepts single 64-bit integer, as that's more convenient
3097 for callers.
3098
3099 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3100
3101 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3102 for compatibility with pselect. Support ns-resolution time stamps.
3103
3104 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3105
3106 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3107 Check for time stamp overflow, and support ns-resolution time stamps.
3108
3109 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3110 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3111 (timeval_subtract): Remove; no longer needed.
3112 (XTflash, XTring_bell, x_wait_for_event):
3113 Port to ns-resolution time stamps. Don't assume time_t is signed.
3114
b6a92dfe
CY
31152012-06-22 Chong Yidong <cyd@gnu.org>
3116
3117 * xdisp.c (x_consider_frame_title): Revert last change.
3118
d251c37c
EZ
31192012-06-22 Eli Zaretskii <eliz@gnu.org>
3120
3121 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3122 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3123 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3124 staticidx goes up to 1597 out of 1600 = 0x640.)
3125
f10deafb
PE
31262012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3127
3128 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3129 Otherwise, the umask might be mistakenly 0 while handling input signals.
3130
ec6de1e2
SM
31312012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3132
3133 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3134
28be1ada
DA
31352012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3136
3137 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3138 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3139 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3140 access to `contents' member of Lisp_Vector objects with AREF and ASET
3141 where appropriate.
3142
c6bf3022
CY
31432012-06-19 Chong Yidong <cyd@gnu.org>
3144
3145 * frame.c (delete_frame): When selecting a frame on a different
3146 text terminal, do not alter the terminal's top-frame.
3147
3148 * xdisp.c (format_mode_line_unwind_data): Record the target
3149 frame's selected window and its terminal's top-frame.
3150 (unwind_format_mode_line): Restore them.
3151 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3152 Callers changed.
3153 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3154 since tty frames can be explicitly named.
3155 (prepare_menu_bars): Likewise.
3156
3157 * term.c (Ftty_top_frame): New function.
3158
defd4196
PE
31592012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3160
3161 Port byte-code-meter to modern targets.
3162 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3163 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3164 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3165 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3166 (METER_1, METER_2): Simplify.
3167
1053a871
SM
31682012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3169
3170 * data.c (Fdefalias): Return `symbol' (bug#11686).
3171
b7e8d081
MR
31722012-06-18 Martin Rudalics <rudalics@gmx.at>
3173
3174 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3175 gets killed during executing of this function (Bug#11665).
3176 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3177 (Vkill_buffer_query_functions): In doc-string say that functions
3178 run by this hook should not change the current buffer.
3179
7ea2b339
PE
31802012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3181
3182 Fix recently-introduced process.c problems found by static checking.
3183 * process.c (write_queue_push, write_queue_pop, send_process):
3184 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3185 (write_queue_pop): Fix pointer signedness problem.
3186 (send_process): Remove unused local.
3187
96a313a1
CY
31882012-06-17 Chong Yidong <cyd@gnu.org>
3189
3190 * xdisp.c (redisplay_internal): No need to redisplay terminal
3191 frames that are not on top.
3192
20ca2e94
TN
31932012-06-17 Troels Nielsen <bn.troels@gmail.com>
3194
3195 * process.c (make_process): Initialize write_queue.
3196 (write_queue_push, write_queue_pop): New functions.
3197 (send_process): Use them to maintain correct ordering of process
3198 writes (Bug#10815).
3199
9a900ca9
PE
32002012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3201
310fbfa8
PE
3202 * lisp.h (eassert): Assume C89 or later.
3203 This removes the need for CHECK.
3204 (CHECK): Remove. Its comments about always evaluating its
3205 argument were confusing, as 'eassert' typically does not evaluate
3206 its argument.
3207
27bb1ca4
PE
3208 * coding.c (produce_chars): Use ptrdiff_t, not int.
3209
9a900ca9
PE
3210 * xterm.c (x_draw_underwave): Check for integer overflow.
3211 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3212
41b7f8bc 32132012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3214
3215 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3216 referenced (Bug#11583).
3217
9b0e3eba
AA
32182012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3219
3220 Implement wave-style variant of underlining.
3221 * dispextern.h (face_underline_type): New enum.
3222 (face): Add field for underline type.
3223 * nsterm.m (ns_draw_underwave): New function.
3224 (ns_draw_text_decoration): Use it.
3225 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3226 New functions.
3227 (x_draw_glyph_string): Use them.
3228 * xfaces.c (Qline, Qwave): New Lisp objects.
3229 (check_lface_attrs, merge_face_ref)
1053a871
SM
3230 (Finternal_set_lisp_face_attribute, realize_x_face):
3231 Handle wave-style underline face attributes.
9b0e3eba
AA
3232 * xterm.c (x_draw_underwave): New function.
3233 (x_draw_glyph_string): Use it.
3234
0fb52f11
JB
32352012-06-16 Juanma Barranquero <lekktu@gmail.com>
3236
3237 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3238 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3239 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3240 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3241 ($(BLD)/w32select.$(O)): Update dependencies.
3242
e5560ff7
AS
32432012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3244
3245 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3246 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3247 * character.c (_fetch_multibyte_char_p): Remove.
3248 * alloc.c: Include "character.h" before "buffer.h".
3249 * bidi.c: Likewise.
3250 * buffer.c: Likewise.
3251 * bytecode.c: Likewise.
3252 * callint.c: Likewise.
3253 * callproc.c: Likewise.
3254 * casefiddle.c: Likewise.
3255 * casetab.c: Likewise.
3256 * category.c: Likewise.
3257 * cmds.c: Likewise.
3258 * coding.c: Likewise.
3259 * composite.c: Likewise.
3260 * dired.c: Likewise.
3261 * dispnew.c: Likewise.
3262 * doc.c: Likewise.
3263 * dosfns.c: Likewise.
3264 * editfns.c: Likewise.
3265 * emacs.c: Likewise.
3266 * fileio.c: Likewise.
3267 * filelock.c: Likewise.
3268 * font.c: Likewise.
3269 * fontset.c: Likewise.
3270 * fringe.c: Likewise.
3271 * indent.c: Likewise.
3272 * insdel.c: Likewise.
3273 * intervals.c: Likewise.
3274 * keyboard.c: Likewise.
3275 * keymap.c: Likewise.
3276 * lread.c: Likewise.
3277 * macros.c: Likewise.
3278 * marker.c: Likewise.
3279 * minibuf.c: Likewise.
3280 * nsfns.m: Likewise.
3281 * nsmenu.m: Likewise.
3282 * print.c: Likewise.
3283 * process.c: Likewise.
3284 * regex.c: Likewise.
3285 * region-cache.c: Likewise.
3286 * search.c: Likewise.
3287 * syntax.c: Likewise.
3288 * term.c: Likewise.
3289 * textprop.c: Likewise.
3290 * undo.c: Likewise.
3291 * unexsol.c: Likewise.
3292 * w16select.c: Likewise.
3293 * w32fns.c: Likewise.
3294 * w32menu.c: Likewise.
3295 * window.c: Likewise.
3296 * xdisp.c: Likewise.
3297 * xfns.c: Likewise.
3298 * xmenu.c: Likewise.
3299 * xml.c: Likewise.
3300 * xselect.c: Likewise.
3301
2f07e6af
EZ
33022012-06-16 Eli Zaretskii <eliz@gnu.org>
3303
1053a871
SM
3304 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3305 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3306 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3307 row.
3308 (handle_face_prop): Use chunk-relative overlay string index when
3309 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3310 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3311 the rightmost. (Bug#11720)
2f07e6af 3312
29b83cec
AS
33132012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3314
3315 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3316 (CATEGORY_MEMBER): Enforce 1/0 value.
3317 * category.c (_temp_category_set): Remove.
3318
4c5501e9
EZ
33192012-06-16 Eli Zaretskii <eliz@gnu.org>
3320
3321 * window.c (Fdelete_other_windows_internal)
3322 (Fdelete_window_internal): Don't access frame's mouse highlight
3323 info of the initial frame. (Bug#11677)
3324
2b570124
PE
33252012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3326
e93864f9
PE
3327 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3328 Assume USE_2_TAGS_FOR_INTS.
3329 (xreload): Adjust $tagmask width to match recent lisp.h change.
3330
2b570124
PE
3331 Simplify lisp.h in minor ways that should not affect code.
3332 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3333 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3334 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3335 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3336 (INTTYPEBITS): New macro, for clarity.
3337 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3338 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3339 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3340 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3341 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3342
81755f69
JB
33432012-06-13 Juanma Barranquero <lekktu@gmail.com>
3344
3345 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3346
16192a57
GM
33472012-06-13 Glenn Morris <rgm@gnu.org>
3348
3349 * s/bsd-common.h (BSD4_3):
3350 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3351
646b5f55
AS
33522012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3353
3354 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3355 instead of union.
3356 (XLI, XIL): Define.
1053a871
SM
3357 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3358 Use them.
3359 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3360 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3361 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3362 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3363 * frame.c (delete_frame): Remove outdated comment.
3364 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3365 USE_LISP_UNION_TYPE.
3366 (Fw32_unregister_hot_key): Likewise.
3367 (Fw32_toggle_lock_key): Likewise.
3368 * w32menu.c (add_menu_item): Likewise.
3369 (w32_menu_display_help): Use XIL instead of checking
3370 USE_LISP_UNION_TYPE.
3371 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3372 (init_heap): Likewise.
3373 * w32term.c (w32_read_socket): Update comment.
3374
1d3823c9
GM
33752012-06-13 Glenn Morris <rgm@gnu.org>
3376
c62ff706
GM
3377 * s/usg5-4-common.h, src/s/unixware.h:
3378 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3379
1d3823c9
GM
3380 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3381
bfe3e0a2
PE
33822012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3385 * alloc.c (make_number) [!defined make_number]:
3386 Remove, as lisp.h always defines this now.
3387 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3388 (roundup_size): Verify that it is a power of 2.
3389 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3390 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3391 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3392 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3393 USE_LSB_TAG now is always defined to be either 0 or 1.
3394 All uses changed.
3395 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3396 code works fine either way, and efficiency is not a concern here,
3397 as the union type is for debugging, not for production.
3398 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3399 Use an inline function on all platforms when using the union type,
3400 since this is simpler and 'static inline' can be used portably
3401 within Emacs now.
3402 (LISP_INITIALLY_ZERO): New macro.
3403 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3404 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3405
45fa9c0f
GM
34062012-06-12 Glenn Morris <rgm@gnu.org>
3407
b4492cba
GM
3408 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3409
3410 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3411
45fa9c0f
GM
3412 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3413 Move BROKEN_SIGIO to configure.
3414
3415 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3416 Move NO_TERMIO to configure.
3417
0e25d334
CY
34182012-06-12 Chong Yidong <cyd@gnu.org>
3419
3420 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3421 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3422 MagickExportImagePixels is undefined.
3423
43682bb6
PE
34242012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3425
3426 * image.c (imagemagick_load_image): Remove unused label.
3427
a9be7d2b
GM
34282012-06-11 Glenn Morris <rgm@gnu.org>
3429
3430 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3431 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3432 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3433 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3434
3017f87f
SM
34352012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3436
3437 * alloc.c (make_byte_code): New function.
3438 (Fmake_byte_code): Use it. Don't purify here.
3439 * lread.c (read1): Use it as well to avoid extra allocation.
3440
1b9b4cf4
CY
34412012-06-11 Chong Yidong <cyd@gnu.org>
3442
3443 * image.c (imagemagick_load_image): Implement transparency.
3444
95988fcf
AS
34452012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3446
3447 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3448 account for preceding backslashes. (Bug#11663)
3449
cd4eb164
CY
34502012-06-09 Chong Yidong <cyd@gnu.org>
3451
3452 * term.c: Support italics in capable terminals (Bug#9652).
3453 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3454 (turn_on_face): Output using TS_enter_italic_mode if available.
3455 Don't handle unused blinking and alt-charset cases.
3456 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3457 and tty_alt_charset_p cases.
3458 (tty_capable_p, init_tty): Support italics.
3459
3460 * termchar.h (struct tty_display_info): Add field for italics.
3461 Remove unused blink field.
3462
3463 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3464 Handle slant.
3465
3466 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3467 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3468 tty_alt_charset_p. Add tty_italic_p.
3469
ff88beb8
MA
34702012-06-09 Michael Albinus <michael.albinus@gmx.de>
3471
3472 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3473 dbus_type_is_basic if available.
3474 (xd_extract_signed, xd_extract_unsigned): Rename from
3475 extract_signed and extract_unsigned, respectively. Adapt callers.
3476
44286096
CY
34772012-06-09 Chong Yidong <cyd@gnu.org>
3478
1682701f
CY
3479 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3480
44286096
CY
3481 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3482 case (Bug#9752).
3483
d86feb17
PE
34842012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3485
3486 * xdisp.c (vmessage): Treat frame message as multibyte.
3487 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3488 would generate the diagnostic "Making \302\247 buffer-local while
3489 let-bound!".
3490
d5c20fe8
EZ
34912012-06-08 Eli Zaretskii <eliz@gnu.org>
3492
3493 * dispnew.c (showing_window_margins_p): Undo last change, which
3494 was done due to an inadvertent commit.
3495 (adjust_frame_glyphs_for_frame_redisplay): Do call
3496 showing_window_margins_p.
3497
513749ee
SM
34982012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3499
3500 * eval.c (Fmake_var_non_special): New primitive.
3501 (syms_of_eval): Defsubr it.
3502 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3503
d4a8f5c1
JB
35042012-06-08 Juanma Barranquero <lekktu@gmail.com>
3505
3506 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3507 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3508
8bbbc977
EZ
35092012-06-08 Eli Zaretskii <eliz@gnu.org>
3510
3511 * alloc.c (allocate_vectorlike): Fix last change.
3512
f3372c87
DA
35132012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3514
3515 Block-based vector allocation of small vectors.
3516 * lisp.h (struct vectorlike_header): New field `nbytes',
3517 adjust comment accordingly.
3518 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3519 to denote vector blocks. Adjust users (live_vector_p,
3520 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3521 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3522 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3523 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3524 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3525 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3526 (roundup_size): New constant.
3527 (struct vector_block): New data type.
3528 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3529 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3530 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3531 (sweep_vectors): New functions.
3532 (allocate_vectorlike): Return `zero_vector' as the only vector of
3533 0 items. Allocate new vector from block if vector size is less than
3534 or equal to VBLOCK_BYTES_MAX.
3535 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3536 (init_alloc_once): Add call to init_vectors.
3537
4f18a4ed
SM
35382012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3539
3540 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3541
86f158bc
PE
35422012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3543
3544 * doprnt.c (doprnt): Truncate multibyte char correctly.
3545 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3546 would mishandle a string argument "Xc" if X was a multibyte
3547 character of length 2: it would truncate after X's first byte
3548 rather than including all of X.
3549
c5cfcbe0
CY
35502012-06-06 Chong Yidong <cyd@gnu.org>
3551
3552 * buffer.c (word_wrap): Doc fix.
3553
c05cf390
PE
35542012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3555
3556 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3557
0c3461de
GM
35582012-06-03 Glenn Morris <rgm@gnu.org>
3559
3560 * xdisp.c (tool-bar-style): Doc fix.
3561
c71232db
UM
35622012-06-03 Ulrich Müller <ulm@gentoo.org>
3563
3564 * Makefile.in (PAXCTL): Define.
3565 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3566 binary via PaX flags if the paxctl utility is available.
3567 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3568 Restore PaX flags to their default. (Bug#11398)
3569
383f7350
CY
35702012-06-03 Chong Yidong <cyd@gnu.org>
3571
3572 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3573 buffer (Bug#11226).
3574
5f2c76c6
CY
35752012-06-03 Chong Yidong <cyd@gnu.org>
3576
3577 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3578 (note_mode_line_or_margin_highlight): If there is no help echo,
3579 use mode-line-default-help-echo. Handle the case where the mouse
3580 position is past the end of the mode line string.
3581
3582 * buffer.c (buffer_local_value_1): New function, split from
3583 Fbuffer_local_value; can return Qunbound.
3584 (Fbuffer_local_value): Use it.
3585 (Vmode_line_format): Docstring tweaks.
3586
773d47f6
PE
35872012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3588
3589 * sysdep.c (system_process_attributes): Improve comment.
3590
f2d6a3df
SM
35912012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3592
3593 * keyboard.c: Export real-this-command to Elisp.
3594 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3595 and DEFVAR it. Update all users.
3596
63810350
PE
35972012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3598
7bd5c1f4
PE
3599 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3600
63810350
PE
3601 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3602 Convert pctcpu and pctmem to Lisp float properly.
3603 Let the compiler fold better, as 100.0/0x8000 is exact.
3604
a2821611
AS
36052012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3606
3607 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3608 cons_block.
3609
5fceba1d
PE
36102012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3611
3612 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3613
c98ff5dd
DA
36142012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3615
3616 For a 'struct window', replace some Lisp_Object fields to
3617 bitfields where appropriate, remove unused fields.
3618 * window.h (struct window): Remove unused 'last_mark_x' and
3619 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3620 change it's type from Lisp_Object to bitfield.
3621 Change type of 'force_start', 'optional_new_start',
3622 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3623 fields from Lisp_Object to bitfield. Adjust users accordingly.
3624
ca34e0be
PE
36252012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3626
3627 Pacify gcc -Wdouble-precision when using Xaw.
3628 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3629 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3630 Use 'float' consistently, rather than 'float' in most places
3631 and 'double' in a couple of places.
3632
efc00ab1 36332012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3634
3635 * xdisp.c (handle_stop): Detect whether we have overlay strings
3636 loaded by testing it->current.overlay_string_index to be
3637 non-negative, instead of checking whether n_overlay_strings is
3638 positive. (Bug#11587)
3639
efc00ab1 36402012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3641
3642 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3643
3644 * doc.c (Fsubstitute_command_keys): Doc fix.
3645
efc00ab1 36462012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3647
3648 * search.c (search_buffer): Remove calls to
3649 r_alloc_inhibit_buffer_relocation, as it is now called by
3650 maybe_unify_char, which was the cause of relocation of buffer text
3651 in bug#11519.
3652
efc00ab1 36532012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3654
3655 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3656 for the duration of call to load_charset, to avoid problems with
3657 callers of maybe_unify_char that access buffer text through C
3658 pointers.
3659
3660 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3661 decrement the inhibition flag, instead of just setting or
3662 resetting it.
3663
ba93a187
PE
36642012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3665
3666 Remove obsolete '#define static' cruft.
3667 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3668 This #undef was "temporary" in 2000; it is no longer needed
3669 now that '#define static' has gone away.
3670 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3671 (gray_bitmap_bits): Remove; no longer needed.
3672 All uses replaced with definiens.
3673 * xterm.c: Include "bitmaps/gray.xbm".
3674
9e4bf381
PE
36752012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3676
3677 Clean up __executable_start, monstartup when --enable-profiling.
3678 The following changes affect the code only when profiling.
3679 * dispnew.c (__executable_start): Rename from safe_bcopy.
3680 Define only on platforms that need it.
3681 * emacs.c: Include <sys/gmon.h> when profiling.
3682 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3683 (__executable_start): Remove decl, since lisp.h does it now.
3684 (safe_bcopy): Remove decl; no longer has that name.
3685 (main): Coalesce #if into single bit of code, for simplicity.
3686 Cast pointers to uintptr_t, since standard libraries want integers
3687 and not pointers.
3688 * lisp.h (__executable_start): New decl.
3689
32d72c2f
GM
36902012-05-31 Glenn Morris <rgm@gnu.org>
3691
3692 * image.c (Fimagemagick_types): Doc fix.
3693
baac5bc7
JM
36942012-05-30 Jim Meyering <meyering@redhat.com>
3695
3696 * callproc.c (Fcall_process_region): Include directory component
3697 in mkstemp error message (Bug#11586).
3698
72cb32cf
PE
36992012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3700
3701 * alloc.c, lisp.h (make_pure_vector): Now static.
3702
61b108cc
SM
37032012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3704
3705 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3706 Move to byte-run.el.
3707 (Fautoload): Do the hash-doc more carefully.
3708 * data.c (Fdefalias): Purify definition, except for keymaps.
3709 (Qdefun): Move from eval.c.
3710 * lisp.h (Qdefun): Remove.
3711 * lread.c (read1): Tiny simplification.
3712
471fe23d
TN
37132012-05-29 Troels Nielsen <bn.troels@gmail.com>
3714
934f3f58 3715 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3716 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3717 Bug#9642, but explicitly check that the buffer the overlay would
3718 be moved to is live and rearrange lines to make sure that errors
3719 will not put the overlay in an inconsistent state.
3720 (Fdelete_overlay): Cosmetics.
3721
85d0efd1
EZ
37222012-05-28 Eli Zaretskii <eliz@gnu.org>
3723
3724 * w32term.c (my_bring_window_to_top): New function.
3725 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3726 could be different from the original one.
3727 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3728 (Bug#11513)
3729
3730 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3731 by calling BringWindowToTop.
3732
3733 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3734 (WM_EMACS_END): Increase by one.
3735
da92a98c
PE
37362012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3737
3738 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3739 This avoids undefined behavior that might cause the eassert
3740 to not catch an out-of-range value.
3741
74d1f848
JB
37422012-05-28 Juanma Barranquero <lekktu@gmail.com>
3743
3744 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3745 Update dependencies.
3746
9e1a06fc
EZ
37472012-05-27 Eli Zaretskii <eliz@gnu.org>
3748
3749 * bidi.c (bidi_mirror_char): Fix last change.
3750
f3dd7312
AS
37512012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3752
3753 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3754 when referring to sectname field in printf format.
3755
81899c91
PE
37562012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3757
57b81a9f
PE
3758 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3759 Only r_alloc_inhibit_buffer_relocation needed to be added;
3760 the others were already declared.
3761
81899c91
PE
3762 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3763 before checking whether it's out of range. Put the check inside
3764 eassert. See
3765 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3766
33017faf 37672012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3768
3769 * callproc.c (Fcall_process): Restore a line that was accidentally
3770 commented out in the 2011-02-13 change (bug#11547).
3771
33017faf 37722012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3773
3774 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3775 defined on ralloc.c.
3776
3777 * buffer.c [REL_ALLOC]: Remove prototypes of
3778 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3779 they are now on lisp.h.
3780
3781 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3782
3783 * search.c (search_buffer): Use it to inhibit relocation of buffer
3784 text while re_search_2 is doing its job, because re_search_2 is
3785 passed C pointers to buffer text. (Bug#11519)
3786
23415acf
EZ
3787 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3788 Update value to 24.
3789
44e27368
EZ
3790 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3791 state after an additional call to move_it_in_display_line_to, keep
3792 the values of it->max_ascent and it->max_descent found for the
3793 entire line.
3794 (pos_visible_p): Revert the comparison against bottom_y to what it
3795 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3796 (Bug#11464)
3797
c1892f11
PE
37982012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3799
3800 Fix coding-related core dumps with gcc -ftrapv.
3801 The code was computing A - B, where A and B are pointers, and B is
3802 random garbage. This can lead to core dumps on platforms that
3803 have special pointer registers, and it also leads to core dumps on
3804 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3805 A - B only when B is initialized properly.
3806 * coding.c (coding_set_source, coding_set_destination): Return void.
3807 (coding_change_source, coding_change_destinations): New functions,
3808 with the old behaviors of coding_set_source and coding_set_destination.
3809 All callers that need an offset changed to use these new functions.
3810
eb7afdad
GM
38112012-05-26 Glenn Morris <rgm@gnu.org>
3812
3813 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3814
f12fdf02
EZ
38152012-05-26 Eli Zaretskii <eliz@gnu.org>
3816
53a63be6 3817 Extend mouse support on W32 text-mode console.
61b108cc
SM
3818 * xdisp.c (draw_row_with_mouse_face):
3819 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3820
eb3f6f01 3821 * w32console.c: Include window.h.
61b108cc
SM
3822 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3823 New functions.
eb3f6f01
EZ
3824 (initialize_w32_display): Initialize mouse-highlight data.
3825
53a63be6
EZ
3826 * w32inevt.c: Include termchar.h and window.h.
3827 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3828 moves, call note_mouse_highlight. If help_echo changed, call
3829 gen_help_event to produce help-echo message in the echo area.
3830 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3831 highlight info.
3832
4cfd81f6
PE
38332012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3834
3835 * lread.c (read1): Simplify slightly to avoid an overflow warning
3836 with GCC 4.7.0 on x86-64.
3837
4446092a
EZ
38382012-05-26 Eli Zaretskii <eliz@gnu.org>
3839
3840 * bidi.c (bidi_mirror_char): Revert last change: an int is
3841 definitely wide enough here.
3842
42b2a986 38432012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3844
42b2a986 3845 Fix integer width and related bugs (Bug#9874).
eb106a49 3846 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3847 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3848 (string_bytes, check_sblock, allocate_string_data):
3849 (compact_small_strings, Fmake_bool_vector, make_string)
3850 (make_unibyte_string, make_multibyte_string)
3851 (make_string_from_bytes, make_specified_string)
3852 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3853 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3854 (mark_vectorlike):
3855 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3856 (allocate_pseudovector):
3857 Use int, not EMACS_INT, where int is wide enough.
3858 (inhibit_garbage_collection, Fgarbage_collect):
3859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3860 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3861 int might not be wide enough.
3862 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3863 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3864 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3865 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3866 (bidi_level_of_next_char, bidi_move_to_visually_next):
3867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3868 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3869 (Fkill_buffer, Fset_buffer_major_mode)
3870 (advance_to_char_boundary, Fbuffer_swap_text)
3871 (Fset_buffer_multibyte, overlays_at, overlays_in)
3872 (overlay_touches_p, struct sortvec, record_overlay_string)
3873 (overlay_strings, recenter_overlay_lists)
3874 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3875 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3876 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3877 (Foverlay_recenter, last_overlay_modification_hooks_used)
3878 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3879 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3880 (validate_region): Omit unnecessary test for b <= e,
3881 since that's guaranteed by the previous test.
d311d28c
PE
3882 (adjust_overlays_for_delete): Avoid pos + length overflow.
3883 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3884 (report_overlay_modification):
3885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3886 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3887 Omit pointer cast, which isn't needed anyway, and doesn't work
3888 after the EMACS_INT -> ptrdiff_t change.
02481186 3889 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3890 * buffer.h: Adjust decls to match defn changes elsewhere.
3891 (struct buffer_text, struct buffer):
3892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3893 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3894 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3895 not int, to avoid needless 32-bit limit on 64-bit hosts.
3896 (exec_byte_code): Use tighter memory-full test, one that checks
3897 for alloca overflow. Don't compute the address of the object just
3898 before an array, as that's not portable. Use EMACS_INT, not
3899 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3900 * callint.c (Fcall_interactively):
3901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3902 * callproc.c (call_process_kill, Fcall_process):
3903 Don't assume pid_t fits into an Emacs fixnum.
3904 (call_process_cleanup, Fcall_process, child_setup):
3905 Don't assume pid_t fits into int.
3906 (call_process_cleanup, Fcall_process, delete_temp_file)
3907 (Fcall_process_region):
3908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3909 (Fcall_process): Simplify handling of volatile integers.
3910 Use int, not EMACS_INT, where int will do.
3911 * casefiddle.c (casify_object, casify_region, operate_on_word)
3912 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3913 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3914 (casify_object): Avoid integer overflow when overallocating buffer.
3915 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3916 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3917 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3918 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3919 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3920 integers are now checked earlier. All uses replaced with XINT.
3921 (ccl_driver):
3922 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3923 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3924 (ccl_driver, Fregister_code_conversion_map):
3925 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3926 (resolve_symbol_ccl_program): Check that vector header is in range.
3927 Always copy the vector, so that we can check its contents reliably
3928 now rather than having to recheck each instruction as it's being
3929 executed. Check that vector words fit in 'int'.
3930 (ccl_get_compiled_code, Fregister_ccl_program)
3931 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3932 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3933 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3934 contents are in range.
3935 (Fccl_execute_on_string): Check that status is in range.
3936 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3937 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3938 Accept and return EMACS_INT, not int, because callers can pass values
3939 out of 'int' range.
3940 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3941 (multibyte_chars_in_text, parse_str_as_multibyte)
3942 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3943 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3944 (string_escape_byte8, Fget_byte):
3945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3946 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3947 avoid mishandling large integers.
3948 * character.h: Adjust decls to match defn changes elsewhere.
3949 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3950 (Ffind_charset_region):
3951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3952 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3953 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3954 Don't assume fixnum fits in int.
d311d28c
PE
3955 (load_charset_map_from_vector, Fmap_charset_chars):
3956 Remove now-unnecessary CHECK_NATNUMs.
3957 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3958 Don't rely on undefined behavior with signed left shift overflow.
3959 Don't assume unsigned int fits into fixnum, or that fixnum fits
3960 into unsigned int. Don't require max_code to be a valid fixnum;
3961 that's not true for gb10830 4-byte on a 32-bit host. Allow
3962 invalid_code to be a cons, for the same reason. Require code_offset
3963 to be a character. Avoid int overflow if max_char is close
3964 to INT_MAX.
3965 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3966 this is intended anyway and avoids some undefined behavior.
3967 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3968 INDEX_TO_CODE_POINT, as that's what it expects.
3969 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3970 * charset.h (DECODE_CHAR): Return int, not unsigned;
3971 this is what was intended anyway, and it avoids undefined behavior.
3972 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3973 integer-overflow issues.
3974 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3975 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3976 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3977 * chartab.c (Fmake_char_table, Fset_char_table_range)
3978 (uniprop_get_decoder, uniprop_get_encoder):
3979 Don't assume fixnum fits in int.
3980 * cmds.c (move_point): New function, that does the gist of
3981 Fforward_char and Fbackward_char, but does so while checking
3982 for integer overflow more accurately.
c96e5d6a 3983 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3984 (Fforward_line, Fend_of_line, internal_self_insert)
3985 (internal_self_insert):
3986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3987 Fix a FIXME, by checking for integer overflow when calculating
3988 target_clm and actual_clm.
3989 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3990 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3991 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3992 (coding_alloc_by_making_gap, alloc_destination)
3993 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3994 (encode_coding_utf_16, detect_coding_emacs_mule)
3995 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3996 (detect_coding_iso_2022, decode_coding_iso_2022)
3997 (encode_invocation_designation, encode_designation_at_bol)
3998 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3999 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4000 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4001 (encode_coding_ccl, encode_coding_raw_text)
4002 (detect_coding_charset, decode_coding_charset)
4003 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4004 (produce_composition, produce_charset, produce_annotation)
4005 (decode_coding, handle_composition_annotation)
4006 (handle_charset_annotation, consume_chars, decode_coding_gap)
4007 (decode_coding_object, encode_coding_object, detect_coding_system)
4008 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4009 (code_convert_region, code_convert_string)
8f50130c
PE
4010 (Fdefine_coding_system_internal)
4011 (coding_set_source, coding_set_destination):
d311d28c
PE
4012 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4013 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4014 (Fdefine_coding_system_internal):
4015 Don't assume fixnums fit in int.
4016 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4017 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4018 (Funencodable_char_position, Fcheck_coding_systems_region)
4019 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4021 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4022 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4023 Don't access memory outside of the args array.
d311d28c 4024 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4025 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4026 result of ENCODE_CHAR.
d311d28c
PE
4027 * coding.h: Adjust decls to match defn changes elsewhere.
4028 (struct coding_system):
4029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4030 * composite.c (get_composition_id, find_composition)
4031 (run_composition_function, update_compositions)
4032 (compose_text, composition_gstring_put_cache)
4033 (composition_gstring_p, composition_gstring_width)
4034 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4035 (composition_compute_stop_pos, composition_reseat_it)
4036 (composition_update_it, struct position_record)
4037 (find_automatic_composition, composition_adjust_point)
4038 (Fcomposition_get_gstring, Ffind_composition_internal):
4039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4040 (update_compositions):
4041 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4042 * composite.h: Adjust decls to match defn changes elsewhere.
4043 (struct composition):
4044 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4045 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4046 Do not attempt to compute the address of the object just before a
4047 buffer; this is not portable.
4048 (Faref, Faset):
4049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4050 (Faset): Use int, not EMACS_INT, where int is wide enough.
4051 (Fstring_to_number): Don't assume fixnums fit in int.
4052 (Frem): Don't assume arg is nonnegative.
4053 * dbusbind.c (xd_append_arg): Check for integers out of range.
4054 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4055 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4056 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4057 (xd_get_connection_references): Return ptrdiff_t, not int.
4058 All uses changed.
4059 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4060 (xd_read_message_1):
4061 Use int, not unsigned, where the dbus API uses int.
4062 (Fdbus_message_internal): Don't overflow mtype.
4063 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4064 * dired.c (directory_files_internal, file_name_completion, scmp)
4065 (file_name_completion_stat):
4066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4067 (file_name_completion): Don't overflow matchcount.
4068 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4069 * dispextern.h: Adjust decls to match defn changes elsewhere.
4070 (struct text_pos, struct glyph, struct bidi_saved_info)
4071 (struct bidi_string_data, struct bidi_it, struct composition_it)
4072 (struct it):
4073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4074 (struct display_pos, struct composition_it, struct it):
4075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4076 * dispnew.c (increment_matrix_positions)
4077 (increment_row_positions, mode_line_string)
4078 (marginal_area_string):
4079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4080 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4082 (duration_to_sec_usec): New function, to check for overflow better.
4083 (Fsleep_for, sit_for): Use it.
4084 * doc.c (get_doc_string, store_function_docstring):
4085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4086 (get_doc_string, Fsnarf_documentation):
4087 Use int, not EMACS_INT, where int is wide enough.
4088 (get_doc_string):
4089 Use SAFE_ALLOCA, not alloca.
4090 Check for overflow when converting EMACS_INT to off_t.
4091 * doprnt.c (doprnt):
4092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4093 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4094 Don't assume uid_t fits into fixnum.
4095 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4096 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4097 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4098 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4099 (general_insert_function)
4100 (Finsert_char, make_buffer_string, make_buffer_string_both)
4101 (update_buffer_properties, Fbuffer_substring)
4102 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4103 (Fsubst_char_in_region, check_translation)
4104 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4105 (transpose_markers, Ftranspose_regions):
4106 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4107 (clip_to_bounds): Move to lisp.h as an inline function).
4108 (Fconstrain_to_field): Don't assume integers are nonnegative.
4109 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4110 (Fsubst_char_in_region, Fsave_restriction):
4111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4112 (Femacs_pid): Don't assume pid_t fits into fixnum.
4113 (lo_time): Use int, not EMACS_INT, when int suffices.
4114 (lisp_time_argument): Check for usec out of range.
4115 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4116 (Fuser_login_name, Fuser_full_name): Signal an error
4117 if a uid argument is out of range, rather than relying on
4118 undefined behavior.
c8d5c857
PE
4119 (Fformat_time_string): Remove now-unnecessary check.
4120 lisp_time_argument checks for out-of-range usec now.
243e0530 4121 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4122 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4123 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4124 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4125 (init_cmdargs, Fdump_emacs):
4126 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4127 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4128 the bottom (typically) 32 bits of the fixnum.
4129 * eval.c (specpdl_size, call_debugger):
4130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4131 (when_entered_debugger, Fbacktrace_debug):
4132 Don't assume fixnum can fit in int.
4133 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4134 the object just before a buffer; this is not portable.
4135 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4136 (grow_specpdl, unbind_to):
4137 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4138 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4139 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4140 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4141 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4142 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4144 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4145 (a_write, e_write):
4146 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4147 (Fcopy_file, non_regular_nbytes, read_non_regular)
4148 (Finsert_file_contents):
4149 Use int, not EMACS_INT, where int is wide enough.
4150 (READ_BUF_SIZE): Verify that it fits in int.
4151 (Finsert_file_contents): Check that counts are in proper range,
4152 rather than assuming fixnums fit into ptrdiff_t etc.
4153 Don't assume fixnums fit into int.
125b3835 4154 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4155 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4156 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4157 (string_char_to_byte, string_byte_to_char)
4158 (string_make_multibyte, string_to_multibyte)
4159 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4160 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4161 (substring_both, Fdelete, internal_equal, Ffillarray)
4162 (Fclear_string, mapcar1)
4163 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4164 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4165 (larger_vector, make_hash_table, maybe_resize_hash_table)
4166 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4167 (Fmaphash, secure_hash):
4168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4169 (concat): Check for string index and length overflow.
4170 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4171 (Frequire):
4172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4173 (larger_vector): New API (vec, incr_min, size_max) replaces old
4174 one (vec, new_size, init). This catches size overflow.
4175 INIT was removed because it was always Qnil.
4176 All callers changed.
4177 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4178 the upper bound on a hash table index size.
4179 (make_hash_table, maybe_resize_hash_table): Use it.
4180 (secure_hash): Computer start_byte and end_byte only after
4181 they're known to be in ptrdiff_t range.
4182 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4183 (Ffont_get_glyphs, Ffont_at):
4184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4185 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4186 (Flist_fonts, Fopen_font):
4187 Don't assume fixnum can fit in int.
4188 (check_gstring): Don't assume index can fit in int.
4189 (font_match_p): Check that fixnum is a character, not a nonnegative
4190 fixnum, since the later code needs to stuff it into an int.
4191 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4192 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4193 conversion overflow issues.
4194 (Fopen_font): Check for integer out of range.
4195 (Ffont_get_glyphs): Don't assume index can fit in int.
4196 * font.h: Adjust decls to match defn changes elsewhere.
4197 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4198 integer overflow.
4199 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4200 printmax_t, where ptrdiff_t is wide enough.
4201 (Finternal_char_font):
4202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4203 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4204 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4205 (Fset_frame_position, x_set_frame_parameters)
4206 (x_set_line_spacing, x_set_border_width)
4207 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4208 Check that fixnums are in proper range for system types.
4209 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4211 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4212 Use SAFE_ALLOCA_LISP, not alloca.
4213 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4214 intptr_t is wide enough.
4215 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4216 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4217 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4218 Check for fixnum out of range.
4219 * ftfont.c (ftfont_list): Don't assume index fits in int.
4220 Check that fixnums are in proper range for system types.
4221 (ftfont_shape_by_flt):
4222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4223 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4225 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4226 Check that fixnums are in proper range for system types.
4227 * gnutls.h: Adjust decls to match defn changes elsewhere.
4228 * gtkutil.c (xg_dialog_run):
4229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4230 (update_frame_tool_bar):
4231 Check that fixnums are in proper range for system types.
4232 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4233 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4234 * indent.c (last_known_column, last_known_column_point):
4235 (current_column_bol_cache):
4236 (skip_invisible, current_column, check_display_width):
4237 (check_display_width, scan_for_column, current_column_1)
4238 (Findent_to, Fcurrent_indentation, position_indentation)
4239 (indented_beyond_p, Fmove_to_column, compute_motion):
4240 (Fcompute_motion, Fvertical_motion):
4241 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4242 (last_known_column_modified): Use EMACS_INT, not int.
4243 (check_display_width):
4244 (Fcompute_motion):
4245 Check that fixnums and floats are in proper range for system types.
4246 (compute_motion): Don't assume index or fixnum fits in int.
4247 (compute_motion, Fcompute_motion):
4248 Use int, not EMACS_INT, when it is wide enough.
4249 (vmotion): Omit local var start_hpos that is always 0; that way
4250 we don't need to worry about overflow in expressions involving it.
4251 * indent.h: Adjust decls to match defn changes elsewhere.
4252 (struct position):
4253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4254 Use int, not EMACS_INT, where int is wide enough.
4255 Remove unused members ovstring_chars_done and tab_offset;
4256 all uses removed.
4257 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4258 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4259 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4260 (make_gap, copy_text, insert, insert_and_inherit)
4261 (insert_before_markers, insert_before_markers_and_inherit)
4262 (insert_1, count_combining_before, count_combining_after)
4263 (insert_1_both, insert_from_string)
4264 (insert_from_string_before_markers, insert_from_string_1)
4265 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4266 (adjust_after_replace, adjust_after_insert, replace_range)
4267 (replace_range_2, del_range, del_range_1, del_range_byte)
4268 (del_range_both, del_range_2, modify_region)
4269 (prepare_to_modify_buffer, signal_before_change)
4270 (signal_after_change, Fcombine_after_change_execute):
4271 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4272 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4273 (balance_an_interval, split_interval_right, split_interval_left)
4274 (find_interval, next_interval, update_interval)
4275 (adjust_intervals_for_insertion, delete_node, delete_interval)
4276 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4277 (static_offset_intervals, offset_intervals)
4278 (merge_interval_right, merge_interval_left, make_new_interval)
4279 (graft_intervals_into_buffer, temp_set_point_both)
4280 (temp_set_point, set_point, adjust_for_invis_intang)
4281 (set_point_both, move_if_not_intangible, get_property_and_range)
4282 (get_local_map, copy_intervals, copy_intervals_to_string)
4283 (compare_string_intervals, set_intervals_multibyte_1):
4284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4285 * intervals.h: Adjust decls to match defn changes elsewhere.
4286 (struct interval):
4287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4288 * keyboard.c (this_command_key_count, this_single_command_key_start)
4289 (before_command_key_count, before_command_echo_length, echo_now)
4290 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4291 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4292 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4293 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4295 (last_non_minibuf_size, last_point_position, echo_truncate)
4296 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4297 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4298 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4299 (stuff_buffered_input):
4300 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4301 (last_auto_save, command_loop_1, read_char):
4302 Use EMACS_INT, not int, to avoid integer overflow.
4303 (record_char): Avoid overflow in total_keys computation.
4304 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4305 * keyboard.h: Adjust decls to match defn changes elsewhere.
4306 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4307 (Fkey_description, Fdescribe_vector, Flookup_key):
4308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4309 (click_position): New function, to check that positions are in range.
4310 (Fcurrent_active_maps):
4311 (describe_command):
4312 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4313 (Faccessible_keymaps, Fkey_description):
4314 (preferred_sequence_p):
4315 Don't assume fixnum can fit into int.
4316 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4317 Check for integer overflow in size calculations.
4318 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4319 avoid mishandling large integers.
4320 * lisp.h: Adjust decls to match defn changes elsewhere.
4321 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4322 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4323 (struct Lisp_Marker):
4324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4325 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4326 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4327 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4328 All callers changed.
4329 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4330 Assume the arg has valid form, since it always does.
4331 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4332 unsigned integer system type.
4333 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4334 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4336 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4337 (duration_to_sec_usec): New decl.
4338 * lread.c (read_from_string_index, read_from_string_index_byte)
4339 (read_from_string_limit, readchar, unreadchar, openp)
4340 (read_internal_start, read1, oblookup):
4341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4342 (Fload, readevalloop, Feval_buffer, Feval_region):
4343 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4344 (openp): Check for out-of-range argument to 'access'.
4345 (read1): Use int, not EMACS_INT, where int is wide enough.
4346 Don't assume fixnum fits into int.
6efdadfd 4347 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4348 (read_filtered_event): Use duration_to_sec_usec
4349 to do proper overflow checking on durations.
d311d28c
PE
4350 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4351 in size calculation.
4352 (Fexecute_kbd_macro):
4353 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4354 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4355 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4356 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4357 (set_marker_both, set_marker_restricted_both, marker_position)
4358 (marker_byte_position, Fbuffer_has_markers_at):
4359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4360 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4361 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4362 It now merely ensures that the menu is large enough, without
4363 necessarily growing it, as this avoids some integer overflow issues.
4364 All callers changed.
4365 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4366 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4367 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4368 Use SAFE_ALLOCA_LISP, not alloca.
4369 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4370 to EMACS_INT. Check that fixnums are in proper range for system types.
4371 * minibuf.c (minibuf_prompt_width, string_to_object)
4372 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4373 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4375 (get_minibuffer, read_minibuf_unwind):
4376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4377 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4378 this simplifies overflow checking. All callers changed.
4379 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4380 (Ftest_completion):
4381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4382 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4383 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4384 Check that fixnums are in proper range for system types.
4385 (Fx_create_frame, Fx_show_tip):
4386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4387 * nsfont.m (ns_findfonts, nsfont_list_family):
4388 Don't assume fixnum fits in long.
4389 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4391 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4392 wide enough.
17fdb222 4393 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4395 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4396 (PRINTDECLARE, PRINTPREPARE):
4397 (strout, print_string):
4398 (print, print_preprocess, print_check_string_charset_prop)
4399 (print_object):
4400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4401 (PRINTDECLARE):
4402 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4403 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4404 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4405 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4406 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4407 (print_error_message): Use SAFE_ALLOCA, not alloca.
4408 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4409 (print_depth, new_backquote_output, print_number_index):
4410 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4411 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4412 (Fset_process_window_size, Fformat_network_address)
4413 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4414 (sigchld_handler):
d311d28c 4415 Check that fixnums are in proper range for system types.
d44287d4 4416 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4417 Check for process-ids out of pid_t range rather than relying on
4418 undefined behavior.
e4d81efc 4419 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4420 (Fformat_network_address, read_process_output, send_process)
4421 (Fprocess_send_region, status_notify):
4422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4423 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4424 (wait_reading_process_output, read_process_output, exec_sentinel):
4425 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4426 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4427 (Faccept_process_output): Use duration_to_sec_usec to do proper
4428 overflow checking on durations.
dde14581
PE
4429 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4430 Don't assume pid_t fits in int.
02481186
PE
4431 * process.h (struct Lisp_Process): Members tick and update_tick
4432 are now of type EMACS_INT, not int.
b62b53e8
PE
4433 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4434 configured --with-wide-int.
d311d28c
PE
4435 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4436 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4437 * search.c (looking_at_1, string_match_1):
4438 (fast_string_match, fast_c_string_match_ignore_case)
4439 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4440 (scan_newline, find_before_next_newline, search_command)
4441 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4442 (set_search_regs, wordify):
4443 (Freplace_match):
4444 (Fmatch_data):
4445 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4446 (string_match_1, search_buffer, set_search_regs):
4447 (Fmatch_data):
4448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4449 (wordify): Check for overflow in size calculation.
4450 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4451 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4452 Check that fixnums are in proper range for system types.
4453 * sound.c (struct sound_device)
4454 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4455 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4456 (Fplay_sound_internal):
4457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4458 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4459 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4460 (Fparse_partial_sexp):
4461 Don't assume fixnums can fit in int.
4462 (struct lisp_parse_state, find_start_pos, find_start_value)
4463 (find_start_value_byte, find_start_begv)
4464 (update_syntax_table, char_quoted, dec_bytepos)
4465 (find_defun_start, prev_char_comend_first, back_comment):
4466 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4467 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4469 (Finternal_describe_syntax_value): Check that match_lisp is a
4470 character, not an integer, since the code stuffs it into int.
4471 (scan_words, scan_sexps_forward):
4472 Check that fixnums are in proper range for system types.
4473 (Fforward_word):
4474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4475 (scan_sexps_forward):
4476 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4477 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4478 * syntax.h: Adjust decls to match defn changes elsewhere.
4479 (struct gl_state_s):
4480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4481 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4482 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4483 * sysdep.c (wait_for_termination_1, wait_for_termination)
4484 (interruptible_wait_for_termination, mkdir):
4485 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4486 (emacs_read, emacs_write):
4487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4488 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4489 and double all fit in int.
d311d28c
PE
4490 * term.c (set_tty_color_mode):
4491 Check that fixnums are in proper range for system types.
4492 * termhooks.h (struct input_event):
4493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4494 * textprop.c (validate_interval_range, interval_of)
4495 (Fadd_text_properties, set_text_properties_1)
4496 (Fremove_text_properties, Fremove_list_of_text_properties)
4497 (Ftext_property_any, Ftext_property_not_all)
4498 (copy_text_properties, text_property_list, extend_property_ranges)
4499 (verify_interval_modification):
4500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4501 (Fnext_single_char_property_change)
4502 (Fprevious_single_char_property_change):
4503 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4504 (copy_text_properties):
4505 Check for integer overflow in index calculation.
d311d28c
PE
4506 * undo.c (last_boundary_position, record_point, record_insert)
4507 (record_delete, record_marker_adjustment, record_change)
4508 (record_property_change):
4509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4510 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4512 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4513 (Fx_hide_tip, Fx_file_dialog):
4514 * w32menu.c (set_frame_menubar):
4515 Use ptrdiff_t, not int, for consistency with rest of code.
4516 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4517 (select_window, Fdelete_other_windows_internal)
4518 (window_scroll_pixel_based, window_scroll_line_based)
4519 (Frecenter, Fset_window_configuration):
4520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4521 (Fset_window_hscroll, run_window_configuration_change_hook)
4522 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4523 (Fscroll_other_window, Frecenter):
d311d28c
PE
4524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4525 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4526 Don't assume fixnum fits in int.
4527 (Fset_window_scroll_bars):
4528 Check that fixnums are in proper range for system types.
4529 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4530 (string_pos, c_string_pos, number_of_chars, init_iterator)
4531 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4532 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4533 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4534 (face_before_or_after_it_pos, handle_invisible_prop)
4535 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4536 (display_prop_intangible_p, string_buffer_position_lim)
4537 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4538 (get_overlay_strings_1, get_overlay_strings)
4539 (iterate_out_of_display_property, forward_to_next_line_start)
4540 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4541 (get_next_display_element, set_iterator_to_next)
4542 (get_visually_first_element, compute_stop_pos_backwards)
4543 (handle_stop_backwards, next_element_from_buffer)
4544 (move_it_in_display_line_to, move_it_in_display_line)
4545 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4546 (add_to_log, message_dolog, message_log_check_duplicate)
4547 (message2, message2_nolog, message3, message3_nolog
4548 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4549 (current_message_1, truncate_echo_area, truncate_message_1)
4550 (set_message, set_message_1, store_mode_line_noprop)
4551 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4552 (text_outside_line_unchanged_p, check_point_in_composition)
4553 (reconsider_clip_changes)
4554 (redisplay_internal, set_cursor_from_row, try_scrolling)
4555 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4556 (redisplay_window, find_last_unchanged_at_beg_row)
4557 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4558 (trailing_whitespace_p, find_row_edges, display_line)
4559 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4560 (display_mode_element, store_mode_line_string)
4561 (pint2str, pint2hrstr, decode_mode_spec)
4562 (display_count_lines, display_string, draw_glyphs)
4563 (x_produce_glyphs, x_insert_glyphs)
4564 (rows_from_pos_range, mouse_face_from_buffer_pos)
4565 (fast_find_string_pos, mouse_face_from_string_pos)
4566 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4568 (safe_call, init_from_display_pos, handle_fontified_prop)
4569 (handle_single_display_spec, load_overlay_strings)
4570 (with_echo_area_buffer, setup_echo_area_for_printing)
4571 (display_echo_area, echo_area_display)
4572 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4573 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4574 (redisplay_window, dump_glyph_row, display_mode_line)
4575 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4576 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4578 (handle_single_display_spec, build_desired_tool_bar_string)
4579 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4580 (get_specified_cursor_type):
4581 Check that fixnums are in proper range for system types.
4582 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4583 (Flookup_image_map):
4584 Don't assume fixnums fit in int.
4585 (compare_overlay_entries):
4586 Avoid mishandling comparisons due to subtraction overflow.
4587 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4588 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4589 (handle_tool_bar_click):
4590 Use int, not unsigned, since we prefer signed and the signedness
4591 doesn't matter here.
4592 (get_next_display_element, next_element_from_display_vector):
4593 Use int, not EMACS_INT, when int is wide enough.
4594 (start_hourglass): Use duration_to_sec_usec to do proper
4595 overflow checking on durations.
4596 * xfaces.c (Fbitmap_spec_p):
4597 Check that fixnums are in proper range for system types.
4598 (compare_fonts_by_sort_order):
4599 Avoid mishandling comparisons due to subtraction overflow.
4600 (Fx_family_fonts, realize_basic_faces):
4601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4602 (Fx_family_fonts):
4603 Don't assume fixnum fits in int.
4604 Use SAFE_ALLOCA_LISP, not alloca.
4605 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4606 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4607 (face_at_buffer_position, face_for_overlay_string)
4608 (face_at_string_position):
4609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4610 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4611 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4612 (Fx_show_tip):
4613 Check that fixnums are in proper range for system types.
4614 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4615 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4617 (Fx_change_window_property): Don't assume fixnums fit in int.
4618 * xfont.c (xfont_chars_supported):
4619 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4620 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4621 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4623 * xml.c (parse_region):
4624 * xrdb.c (magic_file_p):
4625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4626 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4627 (x_get_local_selection, x_reply_selection_request)
4628 (x_handle_selection_request, wait_for_property_change):
4629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4630 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4631 short is wide enough.
4632 (x_send_client_event): Don't assume fixnum fits in int.
4633 * xterm.c (x_x_to_emacs_modifiers):
4634 Don't assume EMACS_INT overflows nicely into int.
4635 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4636 may come from Lisp.
4637 (handle_one_xevent): NATNUMP can eval its arg twice.
4638 (x_connection_closed):
4639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4640 * xterm.h: Adjust decls to match defn changes elsewhere.
4641 (struct scroll_bar): Use struct vectorlike_header
4642 rather than rolling our own approximation.
4643 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4644
c6574eb5
GM
46452012-05-25 Glenn Morris <rgm@gnu.org>
4646
4647 * lisp.mk (lisp): Update for more files being compiled now.
4648
e8d32c7e
SM
46492012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4650
48def666
SM
4651 * lread.c: Remove `read_pure' which makes no difference.
4652 (read_pure): Remove var.
4653 (unreadpure): Remove function.
4654 (readevalloop): Don't call read_list with -1 flag.
4655 (read1, read_vector): Don't test read_pure any more.
4656 (read_list): Simplify.
4657
e8d32c7e
SM
4658 * fileio.c, character.h: Minor style tweaks.
4659
4b2addb7
DA
46602012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4661
4662 * window.h (clip_changed): Remove useless declaration.
4663
584461b2
JB
46642012-05-22 Juanma Barranquero <lekktu@gmail.com>
4665
4666 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4667 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4668
34374650
PE
46692012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4670
4671 Remove src/m/*.
4672 This directory predates autoconf and is no longer needed nowadays.
4673 Move its few remaining bits of functionality to where they're needed.
4674 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4675 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4676 * m/template.h: Remove.
4677 * Makefile.in (M_FILE): Remove. All uses removed.
4678 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4679 * lisp.h (USE_LSB_TAG):
4680 * mem-limits.h (EXCEEDS_LISP_PTR):
4681 Use VAL_MAX, not VALBITS, in #if.
4682 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4683 (EMACS_UINT): Define unconditionally now.
4684 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4685 (BITS_PER_EMACS_INT): New constants, replacing
4686 what used to be in config.h, but not useful in #if.
4687 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4688 define them any more.
4689 (VAL_MAX): New macro.
4690 (VALMASK): Use it.
4691 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4692 BITS_PER_EMACS_INT, in #if.
4693 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4694 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4695 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4696 * s/ms-w32.h (DATA_START):
4697 Move here from removed file m/intel386.h.
4698 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4699 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4700
261cb4bb
PE
47012012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4702
4703 Assume C89 or later.
4704 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4705 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4706 (xrealloc):
4707 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4708 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4709 * textprop.c, tparam.c (NULL): Remove.
4710 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4711 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4712 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4713 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4714 * xterm.c (input_signal_count): Assume volatile works.
4715
ff23cd9f
KB
47162012-05-21 Ken Brown <kbrown@cornell.edu>
4717
4718 * xgselect.c (xg_select): Fix first argument in call to 'select'
4719 (bug#11508).
4720
1b170bc6
KB
47212012-05-20 Ken Brown <kbrown@cornell.edu>
4722
4723 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4724 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4725
b2f4d39f
KB
47262012-05-19 Ken Brown <kbrown@cornell.edu>
4727
4728 * xfns.c (x_in_use): Remove `static' qualifier.
4729 * xterm.h (x_in_use): Declare.
4730 * xgselect.c: Include xterm.h.
4731 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4732 and `display_arg' (bug#9754).
4733
003fdae2
PE
47342012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4735
9232a6d9
PE
4736 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4737
003fdae2
PE
4738 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4739 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4740
784b56e2
EZ
47412012-05-18 Eli Zaretskii <eliz@gnu.org>
4742
4743 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4744
4745 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4746 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4747
4748 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4749 reference to image_cache->refcount.
4750 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4751
a0a79cde
JL
47522012-05-17 Juri Linkov <juri@jurta.org>
4753
4754 * search.c (Fword_search_regexp, Fword_search_backward)
4755 (Fword_search_forward, Fword_search_backward_lax)
4756 (Fword_search_forward_lax): Move functions to isearch.el
4757 (bug#10145, bug#11381).
4758
b0572523
PE
47592012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4760
4761 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4762
9660f5fc
SM
47632012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4764
4765 * lread.c (init_obarray): Declare Qt and Qnil as special.
4766
4374de83
GM
47672012-05-14 Glenn Morris <rgm@gnu.org>
4768
4769 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4770 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4771
dc44c39a
PE
47722012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4773
078c97cb
PE
4774 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4775
dc44c39a
PE
4776 * unexaix.c: Port to more-recent AIX compilers.
4777 (report_error, report_error_1, make_hdr, copy_sym)
4778 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4779 Make arguments const char *, not char *, to avoid violations of C
4780 standard and to fix some AIX warnings reported by Gilles Pion.
4781
e18afed7 47822012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4783
4784 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4785 already have overlays loaded.
4786 (handle_single_display_spec): Before returning without displaying
4787 fringe bitmap, synchronize the bidi iterator with the main display
4788 iterator, by calling iterate_out_of_display_property.
4789 (iterate_out_of_display_property): Detect buffer iteration by
4790 testing that it->string is a Lisp string.
4791 (get_next_display_element): When the current object is exhausted,
4792 and there's something on it->stack, call set_iterator_to_next to
4793 proceed with what's on the stack, instead of returning zero.
4794 (set_iterator_to_next): If called at the end of a Lisp string,
4795 proceed to consider_string_end without incrementing string
4796 position. Don't increment display vector index past the end of
4797 the display vector. (Bug#11417)
c8fb9dc6
EZ
4798 (pos_visible_p): Don't report a position visible when move_it_to
4799 stopped at the last line of window, which happens to be scanned
4800 backwards by the bidi iteration. (Bug#11464)
ac268e67 4801
e18afed7 48022012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4803
4804 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4805 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4806 are on a TTY, and thus unable to display on the fringes.
4807 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4808 so we need to signal to the caller that this is a "replacing"
4809 display spec. This fixes display when the spec is invalid or we
4810 are on a TTY.
4811
e18afed7 48122012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4813
4814 * unexaix.c (make_hdr): Fix typo in prototype.
4815 This bug broke the build on AIX. Problem reported by Gilles Pion.
4816
9d0a235a
MA
48172012-05-14 Michael Albinus <michael.albinus@gmx.de>
4818
4819 * keyboard.c (kbd_buffer_get_event): Read special events also in
4820 batch mode. (Bug#11415)
4821
9e6b06ed
GM
48222012-05-12 Glenn Morris <rgm@gnu.org>
4823
4824 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4825
c1a1d7a3
EZ
48262012-05-12 Eli Zaretskii <eliz@gnu.org>
4827
4828 * lisp.mk (lisp): Add newcomment.elc.
4829
3fe7cdc8
GM
48302012-05-12 Glenn Morris <rgm@gnu.org>
4831
4832 * Makefile.in (MKDIR_P): New, set by configure.
4833 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4834
53f7d2c0
PE
48352012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4836
4837 Remove unused function hourglass_started.
4838 * dispextern.h (hourglass_started):
4839 * w32fns.c (hourglass_started):
4840 * xdisp.c (hourglass_started): Remove.
4841
75aafb17
JB
48422012-05-10 Juanma Barranquero <lekktu@gmail.com>
4843
4844 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4845 Update dependencies.
4846
12959e8e
PE
48472012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4848
97107e2e
PE
4849 * xgselect.c (xg_select): Put maxfds+1 into a var.
4850 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4851
12959e8e
PE
4852 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4853
836d29b3
DA
48542012-05-10 Dave Abrahams <dave@boostpro.com>
4855
4856 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4857 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4858
5cb67954
MA
48592012-05-09 Michael Albinus <michael.albinus@gmx.de>
4860
4861 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4862 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4863 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4864 Initialize xd_registered_buses.
4865
3478ec45
PE
48662012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4867
b263a6b0
PE
4868 Untag more efficiently if USE_LSB_TAG.
4869 This is based on a proposal by YAMAMOTO Mitsuharu in
4870 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4871 For an admittedly artificial (nth 8000 longlist) benchmark on
4872 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4873 Emacs's overall text size by 1%.
4874 * lisp.h (XUNTAG): New macro.
4875 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4876 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4877 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4878 * eval.c (Fautoload):
4879 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4880 * frame.h (XFRAME): Use XUNTAG.
4881
3478ec45
PE
4882 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4883 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4884 Remove unportable assumptions about print widths of types like
4885 dbus_uint32_t.
4886 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4887 intptr_t when converting between pointer and integer, to avoid GCC
4888 warnings about wrong width.
4889
666b903b 48902012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4891
4892 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4893 stack for each reader_thread, instead of defaulting to 8MB
4894 determined by the linker. This avoids failures in creating
4895 subprocesses on Windows 7, see the discussion in this thread:
4896 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4897
b120cc17
JC
48982012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4899
4900 Fix up display of the *Minibuf-0* buffer in the mini window.
4901 * keyboard.c (read_char): Don't clear the echo area if there's no
4902 message to clear.
4903 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4904 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4905
9a4b36f8
MA
49062012-05-07 Michael Albinus <michael.albinus@gmx.de>
4907
4908 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4909 batch mode.
4910
e5f9458f
CY
49112012-05-06 Chong Yidong <cyd@gnu.org>
4912
4913 * lisp.mk (lisp): Update.
4914
eceeb5fc 49152012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4916
4917 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4918
71873e2b
SM
49192012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4920
4921 * data.c (PUT_ERROR): New macro.
4922 (syms_of_data): Use it. Add new error type `user-error'.
4923 * undo.c (user_error): New function.
4924 (Fprimitive_undo): Use it.
4925 * print.c (print_error_message): Adjust print style for `user-error'.
4926 * keyboard.c (user_error): New function.
4927 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4928
ab0fa4e4
PE
49292012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4930
4931 Do not limit current-time-string to years 1000..9999.
4932 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4933 (Fcurrent_time_string): Support any year that is supported by the
4934 underlying localtime representation. Don't use asctime, as it
4935 has undefined behavior for years outside the range -999..9999.
4936
7ed806a7
PE
49372012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4938
4939 Fix race conditions involving setenv, gmtime, localtime, asctime.
4940 Without this fix, interrupts could mess up code that uses these
4941 nonreentrant functions, since setting TZ invalidates existing
4942 tm_zone or tzname values, and since most of these functions return
4943 pointers to static storage.
4944 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4945 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4946 Grow the critical sections to include not just invoking
4947 localtime/gmtime, but also accessing these functions' results
4948 including their tm_zone values if any, and any related TZ setting.
4949 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4950 so that the struct tm is saved in the critical section.
4951 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4952 motivated by the fact that memory allocation needs to be outside
4953 the critical section.
4954
0c16dfed
DA
49552012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4956
4957 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4958 with RESET_INTERVAL.
4959
4960 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4961 Remove duplicated buffer name initialization.
4962
3f83ace8
JM
49632012-05-02 Jim Meyering <jim@meyering.net>
4964
4965 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4966
c7b8541e
JM
4967 * xfns.c (x_window): Use xstrdup (Bug#11375).
4968
90207a15 49692012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4970
4971 * xdisp.c (pos_visible_p): If already at a newline from the
4972 display string before the 'while' loop, don't walk back the glyphs
4973 from it3.glyph_row. Solves assertion violation when the display
4974 string begins with a newline (egg.el). (Bug#11367)
4975
b593d6a9
AH
49762012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4977
4978 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4979 Move to simple.el.
4980
4737362e
GM
49812012-05-01 Glenn Morris <rgm@gnu.org>
4982
99cf43f9
GM
4983 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4984 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4985 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4986 All were removed before 23.1.
4987
9311dcff
GM
4988 * dispnew.c: Remove HAVE_LIBNCURSES test;
4989 it is always true on relevant platforms.
4990
4d5c6349
GM
4991 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4992 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4993
4737362e
GM
4994 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4995
74dd3a6b
AS
49962012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4997
4998 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4999 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5000 Remove.
5001
13c379ee
PE
50022012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5003
5004 Do not avoid creating empty evaporating overlays (Bug#9642).
5005 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5006 That is, do not delete an evaporating overlay if it becomes
5007 empty after its bounds are adjusted to fit within its buffer.
5008 This fix caused other problems, and I'm reverting it until we get
5009 to the bottom of them.
5010
a8e7d6d7 50112012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5012
5013 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5014
a8e7d6d7 50152012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5016
5017 * xdisp.c (pos_visible_p): If the window start position is beyond
5018 ZV, start the display from buffer beginning. Prevents assertion
5019 violation in init_iterator when the minibuffer window is scrolled
5020 via the scroll bar.
5021
5022 * window.c (window_scroll_pixel_based): Likewise.
5023
a8e7d6d7 50242012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5025
5026 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5027
a8e7d6d7 50282012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5029
5030 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5031 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5032
a8e7d6d7 50332012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5034
b593d6a9
AH
5035 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5036 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5037
1c6900d9
EZ
50382012-04-26 Eli Zaretskii <eliz@gnu.org>
5039
4c3fa1d9
EZ
5040 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5041 display element, check also the underlying string or buffer
5042 character. (Bug#11341)
5043
1c6900d9
EZ
5044 * w32menu.c: Include w32heap.h.
5045 (add_menu_item): If the call to AppendMenuW (via
5046 unicode_append_menu) fails, disable Unicode menus only if we are
5047 running on Windows 9X/Me.
5048
42bf8205
AS
50492012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5050
5051 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5052 (xgetint): Add missing shift for LSB tags.
5053
b1bac16e
MR
50542012-04-24 Martin Rudalics <rudalics@gmx.at>
5055
5056 * keyboard.c (read_char): Don't wipe echo area for select window
5057 events: These might get delayed via `mouse-autoselect-window'
5058 (Bug#11304).
5059
d69621cc
JB
50602012-04-24 Juanma Barranquero <lekktu@gmail.com>
5061
5062 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5063 manipulation of :loaded-from data.
5064
02fd101b
JB
50652012-04-23 Juanma Barranquero <lekktu@gmail.com>
5066
5067 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5068 now a cons (bug#11311).
5069
888bec30
PE
50702012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5071
89a438bd
PE
5072 Do not create empty overlays with the evaporate property (Bug#9642).
5073 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5074 if it becomes empty after its bounds are adjusted to fit within
5075 its buffer. Without this fix, in a nonempty buffer (let ((o
5076 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5077 yields an empty overlay that has the evaporate property, which is
5078 not supposed to happen.
5079
1068fe4d
PE
5080 Fix minor GTK3 problems found by static checking.
5081 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5082 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5083 (struct _EmacsFixedClass, emacs_fixed_get_type):
5084 Move decls here from emacsgtkfixed.h, since they needn't be public.
5085 (emacs_fixed_get_type): Now static.
5086 (emacs_fixed_class_init): Omit unused local.
5087 (emacs_fixed_child_type): Remove; unused.
5088 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5089 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5090 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5091 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5092 (EMACS_FIXED_GET_CLASS): Remove; unused.
5093 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5094
888bec30
PE
5095 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5096 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5097
de85e130
PE
50982012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5099
d0baac98 5100 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5101 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5102 (__malloc_size_t, __malloc_ptrdiff_t):
5103 Remove. All uses removed, replaced by the definiens if needed,
5104 since we can assume C89 or better now.
5105 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5106 (protect_malloc_state, align, get_contiguous_space)
5107 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5108 (malloc_atfork_handler_child, malloc_enable_thread)
5109 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5110 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5111 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5112 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5113 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5114 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5115 Define using prototypes, not old style.
5116 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5117 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5118 (align): Don't assume that signed integer overflow wraps around.
5119 Omit unused local var.
5120 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5121 (_free_internal_nolock, memalign, mallochook, reallochook):
5122 Omit no-longer-needed casts.
5123 (valloc): Use getpagesize, not __getpagesize.
5124 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5125 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5126
de85e130
PE
5127 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5128
dcbf5805
MA
51292012-04-22 Michael Albinus <michael.albinus@gmx.de>
5130
5131 Move functions from C to Lisp. Make non-blocking method calls
5132 the default. Implement further D-Bus standard interfaces.
5133
5134 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5135 (QCdbus_request_name_allow_replacement)
5136 (QCdbus_request_name_replace_existing)
5137 (QCdbus_request_name_do_not_queue)
5138 (QCdbus_request_name_reply_primary_owner)
5139 (QCdbus_request_name_reply_in_queue)
5140 (QCdbus_request_name_reply_exists)
5141 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5142 (QCdbus_registered_serial, QCdbus_registered_method)
5143 (QCdbus_registered_signal): New Lisp objects.
5144 (XD_DEBUG_MESSAGE): Use sizeof.
5145 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5146 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5147 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5148 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5149 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5150 (xd_signature, xd_append_arg): Allow float for integer types.
5151 (xd_get_connection_references): New function.
b593d6a9
AH
5152 (xd_get_connection_address): Rename from xd_initialize.
5153 Return cached address.
dcbf5805
MA
5154 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5155 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5156 level.
5157 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5158 Return number of refcounts.
dcbf5805
MA
5159 (Fdbus_get_unique_name): Make stronger parameter check.
5160 (Fdbus_message_internal): New defun.
5161 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5162 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5163 (Fdbus_send_signal, Fdbus_register_service)
5164 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5165 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5166 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5167 (Vdbus_compiled_version, Vdbus_runtime_version)
5168 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5169 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5170 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5171 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5172 Adapt docstring.
dcbf5805 5173
52828e02
PE
51742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5175
da05bc4c
PE
5176 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5177 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5178 Do not assume ptrdiff_t is the same width as 'int'.
5179
52828e02
PE
5180 * alloc.c: Handle unusual debugging option combinations.
5181 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5182 since the two debugging options are incompatible.
5183 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5184 is defined.
5185 (mem_init, mem_insert, mem_insert_fixup):
5186 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5187 (NEED_MEM_INSERT): Remove; no longer needed.
5188
f01769f9
LL
51892012-04-22 Leo Liu <sdl.web@gmail.com>
5190
5191 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5192
5790543d
PE
51932012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5194
5195 * sysdep.c [__FreeBSD__]: Minor cleanups.
5196 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5197 Use Emacs indenting style more consistently. Avoid some casts.
5198 Use 'double' consistently rather than mixing 'float' and 'double'.
5199
b91b7e4d
EW
52002012-04-21 Eduard Wiebe <usenet@pusto.de>
5201
b593d6a9
AH
5202 * sysdep.c (list_system_processes, system_process_attributes):
5203 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5204
6114eb15
AS
52052012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5206
5207 * lisp.mk (lisp): Update.
5208
2f38dff7
PE
52092012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5210
5211 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5212 It is never used otherwise.
5213
4ae29f89
SM
52142012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5215
5216 * print.c (print_preprocess): Only check print_depth if print-circle
5217 is nil.
5218 (print_object): Check for cycles even when print-circle is nil and
5219 print-gensym is t, but only check print_depth if print-circle is nil.
5220
f30d612a
CY
52212012-04-20 Chong Yidong <cyd@gnu.org>
5222
5223 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5224 set the status to "failed" and ensure that sentinel is run.
5225
c07a4c0b 52262012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5227
5228 * process.c (Fset_process_inherit_coding_system_flag)
5229 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5230 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5231
c07a4c0b 52322012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5233
5234 * xdisp.c (string_buffer_position_lim): Limit starting position to
5235 BEGV.
5236 (set_cursor_from_row): If called for a mode-line or header-line
5237 row, return zero immediately.
5238 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5239 farther than the first row after the header line, if any.
5240 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5241 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5242
c07a4c0b 52432012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5244
4ae29f89
SM
5245 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5246 (bug#11238).
ad3a2b41 5247
c07a4c0b 52482012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 52492012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5250
5251 configure: new option --enable-gcc-warnings (Bug#11207)
5252 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5253 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5254 (ALL_CFLAGS): Use new macros rather than old.
5255 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5256 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5257 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5258 -Wunused-result, -Wunused-variable. This should go away once
5259 the Emacs and Gnulib regex code is merged.
5260 (xmalloc, xrealloc): Now static.
5261
aba027e8
PE
52622012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5263
5264 * dired.c (Fsystem_groups): Remove unused local.
5265
e5a36063
GM
52662012-04-17 Glenn Morris <rgm@gnu.org>
5267
5268 * dired.c (Fsystem_users): Doc fix.
5269
316411f0
DA
52702012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5271
5272 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5273 (syms_of_dired): Add them.
5274
9426aba4
PE
52752012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5276
b62a57be
PE
5277 Fix minor alloc.c problems found by static checking.
5278 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5279 New extern decls, to avoid calling undeclared functions.
5280 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5281 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5282 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5283 (NEED_MEM_INSERT): New macro.
5284 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5285 Remove one incorrect comment and fix another.
b62a57be 5286
3539f31f
PE
5287 Fix minor ralloc.c problems found by static checking.
5288 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5289 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5290 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5291 (r_alloc_sbrk): Now static.
5292
a041960a
PE
5293 Improve ralloc.c interface checking.
5294 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5295 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5296 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5297 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5298 [REL_ALLOC]: ... to here, to check interface.
5299 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5300 Remove decls. This fixes an "It stinks!".
5301
9426aba4
PE
5302 * alloc.c (which_symbols): Fix alignment issue / type clash.
5303
d55c12ed
AS
53042012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5305
5306 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5307 (struct Lisp_Misc_Any): Likewise.
5308 (struct Lisp_Free): Likewise.
5309 * alloc.c (union aligned_Lisp_Symbol): Define.
5310 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5311 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5312 (union aligned_Lisp_Misc): Define.
5313 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5314 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5315 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5316
b948ce8b
PE
53172012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5318
5319 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5320 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5321 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5322 * s/netbsd.h, s/sol2-6.h:
5323 Remove definition of GC_MARK_STACK, since the default now works.
5324 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5325 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5326 no longer the default.
5327 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5328
35dc09a1 53292012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5330
35dc09a1
GM
5331 * lread.c (lisp_file_lexically_bound_p):
5332 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5333
35dc09a1
GM
53342012-04-14 Eli Zaretskii <eliz@gnu.org>
5335
5336 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5337 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5338
53392012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5340
5341 * nsterm.m (constrainFrameRect): Always constrain when there is only
5342 one screen (Bug#10962).
5343
bcd86815
KB
53442012-04-13 Ken Brown <kbrown@cornell.edu>
5345
5346 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5347
c25df26e
RT
53482012-04-13 Reuben Thomas <rrt@sc3d.org>
5349
5350 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5351
0fc59f1e
DC
53522012-04-11 Daniel Colascione <dancol@dancol.org>
5353
5354 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5355 against is gone. It's better to use vfork now so that when Cygwin
5356 gains a new, working vfork, we use it automatically (bug#10398).
5357
de8c03dc
SM
53582012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5359
5360 * window.c (save_window_save): Obey window-point-insertion-type.
5361
2f097256
GM
53622012-04-11 Glenn Morris <rgm@gnu.org>
5363
5364 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5365
453b951e
SM
53662012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5367
5368 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5369
75f1671a 53702012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5371
5372 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5373 (force_quit_count): New var.
5374 (handle_interrupt): Use it.
5375
2a8ce227
JB
53762012-04-10 Juanma Barranquero <lekktu@gmail.com>
5377
5378 * w32.c (w32_delayed_load): Record the full path of the library
5379 being loaded (bug#10424).
5380
935396c0
GM
53812012-04-09 Glenn Morris <rgm@gnu.org>
5382
05920a43
GM
5383 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5384 not just in the obarray, before snarfing them. (Bug#11036)
5385
935396c0
GM
5386 * Makefile.in ($(leimdir)/leim-list.el):
5387 Pass EMACS rather than BUILT_EMACS.
5388
a18ecafa
TZ
53892012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5390
5391 * process.c (make_process):
5392 * process.h: Add integer `gnutls_handshakes_tried' member to
5393 process struct.
5394
6bbef4e5
JC
5395 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5396 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5397
5398 * gnutls.c (gnutls_log_function2i): Convenience log function.
5399 (emacs_gnutls_read): Use new log functions,
5400 `gnutls_handshakes_tried' process member, and
5401 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5402 attempts per process (connection).
5403
b4d3bc10
CY
54042012-04-09 Chong Yidong <cyd@gnu.org>
5405
5406 * eval.c (Fuser_variable_p, user_variable_p_eh)
5407 (lisp_indirect_variable): Functions deleted.
5408 (Fdefvar): Caller changed.
5409
5410 * callint.c (Finteractive, Fcall_interactively):
5411 * minibuf.c (Fread_variable): Callers changed.
5412
70f4d973
EZ
54132012-04-09 Eli Zaretskii <eliz@gnu.org>
5414
5415 * xdisp.c (set_cursor_from_row): If the display string appears in
5416 the buffer at position that is closer to point than the position
5417 after the display string, display the cursor on the first glyph of
5418 the display string. Fixes cursor display when a 'display' text
5419 property immediately follows invisible text. (Bug#11094)
5420
cb3c2e3e
PE
54212012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5422
5423 composite.c: use 'double' consistently
5424 * composite.c (get_composition_id): Use 'double' consistently
5425 instead of converting 'float' to 'double' and vice versa; this is
5426 easier to understand and avoids a GCC warning.
5427
fd06db5d
GM
54282012-04-09 Glenn Morris <rgm@gnu.org>
5429
50fe702a
GM
5430 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5431 preparation for dumping it with emacs. (Bug#4789)
5432 (leimdir): New variable.
5433 ($(leimdir)/leim-list.el): New rule.
5434 (emacs$(EXEEXT)): Depend on leim-list.el.
5435
fd06db5d
GM
5436 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5437 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5438 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5439
55c131ee
AS
54402012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5441
5442 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5443 proper alignment.
5444
9209588f
JB
54452012-04-07 Juanma Barranquero <lekktu@gmail.com>
5446
5447 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5448 Remove unused local variable.
5449
e3fb2efb
PE
54502012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5451
5452 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5453 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5454 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5455 objects, as mark_maybe_pointer will catch them otherwise.
5456 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5457 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5458
b5385551
PE
54592012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5460
5461 Fix typo that broke non-Windows builds.
5462 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5463
9078ead6
EZ
54642012-04-07 Eli Zaretskii <eliz@gnu.org>
5465
5466 Support building on MS-Windows with libxml2.
5467
5468 * makefile.w32-in (OBJ2): Add xml.$(O).
5469 (GLOBAL_SOURCES): Add xml.c.
5470 ($(BLD)/xml.$(O)): New dependency list.
5471
5472 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5473 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5474 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5475 [!WINDOWSNT]: New macros.
5476 (init_libxml2_functions, libxml2_loaded_p): New functions.
5477 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5478 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5479 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5480 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5481 linked in).
6bbef4e5
JC
5482 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5483 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5484 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5485
5486 * emacs.c: Don't include libxml/parser.h.
5487 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5488 xmlCleanupParser directly.
5489
5490 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5491
3811fdf3
EZ
54922012-04-07 Eli Zaretskii <eliz@gnu.org>
5493
5494 * indent.c (Fvertical_motion): If there is a display string at
5495 point, use it.vpos to compute how many lines to backtrack after
5496 move_it_to point. (Bug#11133)
5497
2f8e16b2
EZ
54982012-04-06 Eli Zaretskii <eliz@gnu.org>
5499
5500 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5501 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5502 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5503 macros related to unification of CJK characters. For the details,
5504 see the discussion following the message here:
5505 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5506
3d439cd1
CY
55072012-04-04 Chong Yidong <cyd@gnu.org>
5508
5509 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5510
8bc53d00
EZ
55112012-04-01 Eli Zaretskii <eliz@gnu.org>
5512
5513 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5514 instead of alloca. (Bug#11138)
5515
3b0512a3
AS
55162012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5517
5518 * w32menu.c (is_simple_dialog): Properly check lisp types.
5519 (Bug#11141)
5520
8427ddd2
EZ
55212012-03-31 Eli Zaretskii <eliz@gnu.org>
5522
979022ef
EZ
5523 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5524 position we get to after a call to move_it_to fails the
5525 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5526 only if we wind up in a string from display property. (Bug#11063)
5527
a6b1c7cc
EZ
5528 * window.c (Fdelete_other_windows_internal): Invalidate the row
5529 and column information about mouse highlight, so that redisplay
5530 restores it after reallocating the glyph matrices. (Bug#7464)
5531
8427ddd2
EZ
5532 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5533 string comes from a `display' text property, use the buffer
5534 position of that property as if we actually saw that position in
5535 the row's glyphs.
697ba24b
EZ
5536 (move_it_by_lines): Remove the assertion that
5537 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5538 violated when there's a before-string at the beginning of a line.
5539 (Bug#11063)
8427ddd2 5540
65a0a738
EZ
55412012-03-30 Eli Zaretskii <eliz@gnu.org>
5542
5543 * xdisp.c (append_space_for_newline): If the default face was
5544 remapped, use the remapped face for the appended newline.
5545 (extend_face_to_end_of_line): Use the remapped default face for
5546 extending the face to the end of the line.
5547 (display_line): Call extend_face_to_end_of_line when the default
5548 face was remapped. (Bug#11068)
5549
581355cc
EZ
55502012-03-29 Eli Zaretskii <eliz@gnu.org>
5551
5552 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5553
e8fc049f
SM
55542012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5555
5556 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5557
4fb9a543
GM
55582012-03-27 Glenn Morris <rgm@gnu.org>
5559
5560 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5561 Doc fixes.
5562
679910f1
KH
55632012-03-26 Kenichi Handa <handa@m17n.org>
5564
5565 * dispextern.h (struct glyph): Fix previous change. Change the
5566 bit length of glyphless.ch to 25 (Bug#11082).
5567
90d49b7f
CY
55682012-03-26 Chong Yidong <cyd@gnu.org>
5569
5570 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5571 (command_loop_1): Use it; inhibit selection update for
5572 handle-select-window too (Bug#8996).
5573
f514f6f0
FP
55742012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5575
e8fc049f 5576 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5577
bf43fa51
KH
55782012-03-25 Kenichi Handa <handa@m17n.org>
5579
5580 * dispextern.h (struct glyph): Change the bit length of
5581 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5582
8a0c01dd
EZ
55832012-03-24 Eli Zaretskii <eliz@gnu.org>
5584
5585 * s/ms-w32.h (tzname): Include time.h before redirecting to
5586 _tzname. Fixes the MSVC build. (Bug#9960)
5587
7d1c3a76
AS
55882012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5589
8ed79523
AS
5590 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5591 characters.
5592
7d1c3a76
AS
5593 * xterm.c (XTread_socket): Only modify handling_signal if
5594 !SYNC_INPUT. (Bug#11080)
5595
e99a9b8b
EZ
55962012-03-23 Eli Zaretskii <eliz@gnu.org>
5597
5598 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5599 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5600 when fetching a multibyte character consumes more bytes than
5601 CHAR_BYTES returns, due to unification of CJK characters in
5602 string_char. (Bug#11073)
5603
5063c0e1
TN
56042012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5605
5606 * process.c (wait_reading_process_output): Handle pty disconnect
5607 by refraining from sending oneself a SIGCHLD (bug#10933).
5608
9f851fbd
CY
56092012-03-22 Chong Yidong <cyd@gnu.org>
5610
5611 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5612
5063c0e1 5613 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5614 Mark string as coming from a prefix property.
5615 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5616 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5617
fb5b8aca
CY
56182012-03-21 Chong Yidong <cyd@gnu.org>
5619
5620 * xfaces.c (Vface_remapping_alist): Doc fix.
5621
62356a1b
EZ
56222012-03-20 Eli Zaretskii <eliz@gnu.org>
5623
5624 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5625 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5626 Doc fixes.
62356a1b 5627
025de85b
CY
56282012-03-20 Chong Yidong <cyd@gnu.org>
5629
5630 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5631 to reflect default non-nil value of redisplay-dont-pause.
5632
4827f94e
KH
56332012-03-19 Kenichi Handa <handa@m17n.org>
5634
5635 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5636 it fit in a valid range (Bug#11003).
5637
e50a24a2
EZ
56382012-03-18 Eli Zaretskii <eliz@gnu.org>
5639
5640 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5641 that is not from display property, accept the row as a "cursor
5642 row" if one of the string's character has a non-nil `cursor'
5643 property. Fixes cursor positioning when there are newlines in
5644 overlay strings, e.g. in icomplete.el. (Bug#11035)
5645
9af5ed87
PE
56462012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5647
5648 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5649
d1f55f16
CY
56502012-03-12 Chong Yidong <cyd@gnu.org>
5651
5652 * eval.c (inhibit_lisp_code): Rename from
5653 inhibit_window_configuration_change_hook; move from window.c.
5654
5655 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5656 * window.c (run_window_configuration_change_hook)
5657 (syms_of_window): Callers changed.
5658
66c5eebd
CY
56592012-03-11 Chong Yidong <cyd@gnu.org>
5660
413df973
CY
5661 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5662
66c5eebd
CY
5663 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5664
1de11f56
CY
56652012-03-10 Chong Yidong <cyd@gnu.org>
5666
5667 * frame.c (other_visible_frames): Don't assume the selected frame
5668 is visible (Bug#10955).
5669
cae07000
SM
56702012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5671
5672 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5673
89c94350
JD
56742012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5675
5676 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5677 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5678 zero (Bug#10954).
5679
999dd333
GM
56802012-03-03 Glenn Morris <rgm@gnu.org>
5681
01a6dcc8 5682 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5683
de0100f2
EZ
56842012-03-02 Eli Zaretskii <eliz@gnu.org>
5685
5686 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5687 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5688 (redisplay_window, next_element_from_string): Fix typos in
5689 comments.
3e441275
EZ
5690 (redisplay_window): Pass to move_it_vertically the margin in
5691 pixels, not in screen lines.
de0100f2 5692
96a72ee9
GM
56932012-03-02 Glenn Morris <rgm@gnu.org>
5694
5695 * buffer.c (buffer-list-update-hook): Doc fix.
5696
312508d7
EZ
56972012-02-29 Eli Zaretskii <eliz@gnu.org>
5698
5699 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5700 push_it before setting up the iterator for the first overlay
5701 string, even if we have an empty string loaded.
5702 (next_overlay_string): If there's an empty string on the iterator
5703 stack, pop the stack. (Bug#10903)
5704
27f3c637
PE
57052012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5706
5707 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5708 Suggested by Stefan Monnier in
5709 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5710 * alloc.c (widen_to_Lisp_Object): New static function.
5711 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5712 and widening them to Lisp_Objects. This would work even if
5713 USE_LSB_TAG is defined and wide integers are used, which might
5714 happen in a future version of Emacs.
5715
3c9dfce6
CY
57162012-02-25 Chong Yidong <cyd@gnu.org>
5717
fa74b241
CY
5718 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5719 Doc fix.
5720
3c9dfce6
CY
5721 * xselect.c (Fx_selection_exists_p): Doc fix.
5722 (x_clipboard_manager_save_all): Print an informative message
5723 before saving to clipboard manager.
5724
9486df08
CY
57252012-02-24 Chong Yidong <cyd@gnu.org>
5726
5727 * keyboard.c (process_special_events): Handle all X selection
5728 requests in kbd_buffer, not just the next one (Bug#8869).
5729
f01d3321
CY
57302012-02-23 Chong Yidong <cyd@gnu.org>
5731
5732 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5733 call when setting menu-bar-lines and tool-bar-lines parameters.
5734 (unwind_create_frame_1): New helper function.
5735
5736 * window.c (inhibit_window_configuration_change_hook): New var.
5737 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5738 (syms_of_window): Initialize it.
f01d3321 5739
86b847b6
CY
57402012-02-22 Chong Yidong <cyd@gnu.org>
5741
5742 * xterm.c (x_draw_image_relief): Add missing type check for
5743 Vtool_bar_button_margin (Bug#10743).
5744
a59225b1
CY
57452012-02-21 Chong Yidong <cyd@gnu.org>
5746
5747 * fileio.c (Vfile_name_handler_alist): Doc fix.
5748
5749 * buffer.c (Fget_file_buffer): Protect against invalid file
5750 handler return value.
5751
310f5bd4
PE
57522012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5753
cb3a28cc
PE
5754 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5755 when computing $valmask.
5756
310f5bd4
PE
5757 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5758 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5759 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5760 It's useless in that case, and it can cause problems on hosts
5761 that allocate halves of EMACS_INT values separately.
5762 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5763 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5764 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5765 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5766 it avoids undefined behavior on hosts where shifting right by more
5767 than the word width has undefined behavior.
5768
2375c96a
CY
57692012-02-19 Chong Yidong <cyd@gnu.org>
5770
5771 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5772 (Funhandled_file_name_directory, Ffile_name_as_directory)
5773 (Fdirectory_file_name, Fexpand_file_name)
5774 (Fsubstitute_in_file_name): Protect against invalid file handler
5775 return values (Bug#10845).
5776
3eb49e71
EZ
57772012-02-18 Eli Zaretskii <eliz@gnu.org>
5778
5779 * .gdbinit (pitx): Fix incorrect references to fields of the
5780 iterator stack.
5781
7b926f3f
CY
57822012-02-17 Chong Yidong <cyd@gnu.org>
5783
5784 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5785
11273115
PE
57862012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5787
5788 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5789 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5790
c3a70e2b
CY
57912012-02-15 Chong Yidong <cyd@gnu.org>
5792
5793 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5794 marked as special. Also, starting docstrings with * is obsolete.
5795
0ca43699
AS
57962012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5797
5798 * gnutls.c (emacs_gnutls_write): Fix last change.
5799
2e8f3c56
LI
58002012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5801
5802 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5803 send_process.
5804
af70074f
SM
58052012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5806
5807 * keymap.c (Fsingle_key_description): Handle char ranges.
5808
95986d52
CY
58092012-02-12 Chong Yidong <cyd@gnu.org>
5810
afd83bd1
CY
5811 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5812 as that creates a dangerous corner case.
5813
95986d52
CY
5814 * window.c (Fdelete_window_internal): Invalidate the mouse
5815 highlight (Bug#9904).
5816
bd7da63e
GM
58172012-02-12 Glenn Morris <rgm@gnu.org>
5818
5819 * xselect.c (Fx_own_selection_internal)
5820 (Fx_get_selection_internal, Fx_disown_selection_internal)
5821 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5822 * nsselect.m (Fx_own_selection_internal)
5823 (Fx_disown_selection_internal, Fx_selection_exists_p)
5824 (Fx_selection_owner_p, Fx_get_selection_internal):
5825 Sync docs and argument specs with the xselect.c versions.
5826
77abcbc2
LI
58272012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5828
5829 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5830
90b671e2
EZ
58312012-02-11 Eli Zaretskii <eliz@gnu.org>
5832
1c0ca0b7
EZ
5833 * w32select.c (Fx_selection_exists_p): Sync doc string and
5834 argument list with xselect.c. (Bug#10783)
5835
5836 * w16select.c (Fx_selection_exists_p): Sync doc string and
5837 argument list with xselect.c. (Bug#10783)
90b671e2 5838
49241268
GM
58392012-02-10 Glenn Morris <rgm@gnu.org>
5840
5841 * fns.c (Fsecure_hash): Doc fix.
5842
f998bbe7 58432012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5844
5845 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5846
0992bd9c
CY
58472012-02-07 Chong Yidong <cyd@gnu.org>
5848
5849 * buffer.c (Fbuffer_local_variables)
5850 (buffer_lisp_local_variables): Handle unbound vars correctly;
5851 don't let Qunbound leak into Lisp.
5852
af008560
GM
58532012-02-07 Glenn Morris <rgm@gnu.org>
5854
dd605cc4
GM
5855 * image.c (Fimagemagick_types): Doc fix.
5856
af008560
GM
5857 * image.c (imagemagick-render-type): Change it from a lisp object
5858 to an integer. Move the doc here from the lisp manual.
5859 Treat all values not equal to 0 the same.
5860
1449fa1d
CY
58612012-02-06 Chong Yidong <cyd@gnu.org>
5862
5863 * doc.c (store_function_docstring): Avoid applying docstring of
5864 alias to base function (Bug#2603).
5865
3723ec07
AS
58662012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5867
5868 * .gdbinit (pp1, pv1): Remove redundant defines.
5869 (pr): Use pp.
5870
79c1cc1e
CY
58712012-02-04 Chong Yidong <cyd@gnu.org>
5872
5873 * nsterm.m: Declare a global (Bug#10694).
5874
d7f29f8e
EZ
58752012-02-04 Eli Zaretskii <eliz@gnu.org>
5876
cae07000
SM
5877 * w32.c (get_emacs_configuration_options):
5878 Include --enable-checking, if specified, in the return value.
d7f29f8e 5879
3b95a6f9
MR
58802012-02-04 Martin Rudalics <rudalics@gmx.at>
5881
5882 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5883 after rounding frame sizes. (Bug#9723)
5884
d6fa96a6
EZ
58852012-02-04 Eli Zaretskii <eliz@gnu.org>
5886
5887 * keyboard.c (adjust_point_for_property): Don't position point
5888 before BEGV. (Bug#10696)
5889
df0b2940
PE
58902012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5891
5892 Handle overflow when computing char display width (Bug#9496).
5893 * character.c (char_width): Return EMACS_INT, not int.
5894 (char_width, c_string_width): Check for overflow when
5895 computing the width; this is possible now that individual
5896 characters can have unbounded width. Problem introduced
5897 by merge from Emacs 23 on 2012-01-19.
5898
6bee44d6
MA
58992012-02-02 Michael Albinus <michael.albinus@gmx.de>
5900
5901 * dbusbind.c (Fdbus_register_method): Mention the return value
5902 :ignore in the docstring.
5903
44f92739
GM
59042012-02-02 Glenn Morris <rgm@gnu.org>
5905
1b9f60cc
GM
5906 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5907
44f92739
GM
5908 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5909 Unconditionally set to t. (Bug#10673)
5910 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5911 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5912 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5913
c5d3843c
KH
59142012-02-02 Kenichi Handa <handa@m17n.org>
5915
5916 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5917 0, do not call append_composite_glyph.
5918
159462d4 59192012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5920
5921 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5922 NULL (Bug#6988).
5923 (x_produce_glyphs): If the component of a composition is a null
5924 string, set it->pixel_width to 1 to avoid zero-width glyph.
5925
78cef877
EZ
59262012-02-01 Eli Zaretskii <eliz@gnu.org>
5927
5928 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5929 first 2 arguments are identical. This makes inserting large
5930 output from a subprocess an order of magnitude faster on
5931 MS-Windows, where all sbrk'ed memory is always contiguous.
5932
97897668
GM
59332012-01-31 Glenn Morris <rgm@gnu.org>
5934
5935 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5936 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5937 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5938
31fd3586
GM
59392012-01-29 Glenn Morris <rgm@gnu.org>
5940
5941 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5942
0e24a8b2
CY
59432012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5944
5945 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5946
cc0adcb0
CY
59472012-01-28 Chong Yidong <cyd@gnu.org>
5948
5949 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5950
acc28cb9
CY
59512012-01-26 Chong Yidong <cyd@gnu.org>
5952
9c69cfb7
CY
5953 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5954
acc28cb9
CY
5955 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5956 repeat counts (Bug#10507).
5957
48da7392
GM
59582012-01-26 Glenn Morris <rgm@gnu.org>
5959
5960 * lread.c (syms_of_lread): Doc fix.
5961
14af5f7f
CY
59622012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5963
5964 * coding.c (encode_designation_at_bol): Change return value to
5965 EMACS_INT.
5966
0b21c100
CY
59672012-01-25 Chong Yidong <cyd@gnu.org>
5968
5969 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5970
3c2907f7
CY
59712012-01-21 Chong Yidong <cyd@gnu.org>
5972
5973 * floatfns.c (Fcopysign): Make the second argument non-optional,
5974 since nil is not allowed anyway.
5975
959ad23f
AS
59762012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5977
5978 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5979 (send_process): Likewise.
5980
34a02f46
MR
59812012-01-19 Martin Rudalics <rudalics@gmx.at>
5982
5983 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5984 (Vwindow_persistent_parameters): Do not use Qstate.
5985 Rewrite doc-strings.
34a02f46 5986
1259009a 59872012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5988
5989 * character.c (char_width): New function.
70d4fdf6
GM
5990 (Fchar_width, c_string_width, lisp_string_width):
5991 Use char_width (Bug#9496).
25ed9e61 5992
6a6ee00d
MR
59932012-01-16 Martin Rudalics <rudalics@gmx.at>
5994
5995 * window.c (Vwindow_persistent_parameters): New variable.
5996 (Fset_window_configuration, save_window_save): Handle persistent
5997 window parameters.
5998
c85efaf7
EZ
59992012-01-14 Eli Zaretskii <eliz@gnu.org>
6000
6001 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6002 thrashing the stack of the thread. (Bug#9087)
6003
5944709e
PE
60042012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6005
6006 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6007
e71f5d99
EZ
60082012-01-11 Eli Zaretskii <eliz@gnu.org>
6009
6010 * xdisp.c (rows_from_pos_range): Handle the case where the
6011 highlight ends on a newline. (Bug#10464)
6012 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6013 he end column for display of highlight that ends on a newline
6014 before a R2L line.
6015
ce316182
GM
60162012-01-11 Glenn Morris <rgm@gnu.org>
6017
6018 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6019 from load-path also when installation-directory is nil. (Bug#10208)
6020
5b43da69
GM
60212012-01-10 Glenn Morris <rgm@gnu.org>
6022
74cc8ff9
GM
6023 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6024
7d8d6e4e
GM
6025 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6026 Update template values to be closer to their typical values these days.
5b43da69 6027
a0db8d43
EZ
60282012-01-09 Eli Zaretskii <eliz@gnu.org>
6029
6030 * xdisp.c (rows_from_pos_range): Accept additional argument
6031 DISP_STRING, and accept any glyph in a row whose object is that
6032 string as eligible for mouse highlight. Fixes mouse highlight of
6033 display strings from overlays. (Bug#10464)
6034
9a0115ab 60352012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6036
b9110d6a 6037 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6038 * fileio.c (auto_saving_dir_umask): New static var.
6039 (Fmake_directory_internal): Use it.
6040 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6041 creating the directory. The old code temporarily assigns
6042 too-generous permissions to the directory.
6043 (do_auto_save_eh): Clear it.
b9110d6a 6044 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6045 that the var is always cleared.
6046
6c1bd3f3
EZ
60472012-01-07 Eli Zaretskii <eliz@gnu.org>
6048
6049 * search.c (scan_buffer): Pass character positions to
6050 know_region_cache, not byte positions. (Bug#6540)
6051
069d2b50
L
60522012-01-07 LynX <_LynX@bk.ru> (tiny change)
6053
6054 * w32.c (sys_rename): Report EXDEV when rename of a directory
6055 fails because the target is on another logical disk. (Bug#10284)
6056
75bf0d33
DB
60572012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6058
6059 * xterm.c (x_embed_request_focus): New function.
6060
6061 * xterm.h: Add prototype.
6062
6063 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6064
1c6e5a32
GM
60652012-01-05 Glenn Morris <rgm@gnu.org>
6066
6067 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6068
651e947e
EZ
60692012-01-01 Eli Zaretskii <eliz@gnu.org>
6070
6071 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6072 Load gnutls_transport_set_lowat only if GnuTLS version is below
6073 2.11.1.
6074 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6075 GnuTLS versions below 2.11.1.
6076
3778cdd8
AL
60772011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6078
6079 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6080 to the doc string advising against its use for altering the way
6081 windows are scrolled.
6082
0e5317f7
KH
60832011-12-28 Kenichi Handa <handa@m17n.org>
6084
6085 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6086 coding-system ASCII compatible only when it does not produce BOM
6087 on encoding (Bug#10383).
6088
93d5ca1f
JD
60892011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6090
6091 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6092 can scroll.
6093 (create_and_show_popup_menu): Always use menu_position_func for
6094 Gtk3 (Bug#10361).
6095
ca22b785
AS
60962011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6097
6098 * callint.c (Fcall_interactively): Don't truncate prompt string.
6099
d048e1e6
EZ
61002011-12-23 Eli Zaretskii <eliz@gnu.org>
6101
6102 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6103 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6104 resumed from there (after widening). (Bug#10360)
d048e1e6 6105
5ccaba1f
JD
61062011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6107
6108 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6109
204ee57f
JD
61102011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6111
b81d40f0
JB
6112 * nsterm.m (x_free_frame_resources):
6113 Release f->output_data.ns->miniimage.
204ee57f
JD
6114 (ns_index_color): Fix indentation. Do not retain
6115 color_table->colors[i].
6116
6117 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6118 before returning.
6119
6120 * nsfns.m (x_set_background_color): Assign return value from
6121 ns_index_color to face-background instead of NSColor*.
6122 (ns_implicitly_set_icon_type): Fix indentation.
6123 Change assignment in for loop to comparison.
6124
6125 * emacs.c (ns_pool): New variable.
6126 (main): Assign ns_pool.
6127 (Fkill_emacs): Call ns_release_autorelease_pool.
6128
6129 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6130 autorelease fdesc, release fdAttrs and tdict.
6131 (ns_get_covering_families): Release charset.
6132 (ns_findfonts): Release NSFontDescriptor created with new.
6133 (ns_uni_to_glyphs): Fix indentation.
6134 (setString): Release attrStr before assigning new value.
6135
c803b2b7
JD
61362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6137
678f4426
JD
6138 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6139 and NS_IMPL_COCOA.
6140 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6141 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6142
cd394be1 61432011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6144
5fecd5fc
JD
6145 * nsterm.m (ns_term_init): Subscribe for notifications
6146 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6147 to method trackingNotification in EmacsMenu.
6148
6149 * nsmenu.m (trackingMenu): New variable.
3771cb17 6150 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6151 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6152 from Aquamacs (Bug#7030).
678f4426
JD
6153
61542011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6155
c803b2b7
JD
6156 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6157 (symbol_to_nsstring): Fix indentation.
6158 (ns_symbol_to_pb): New function.
cae07000
SM
6159 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6160 (Fns_rotate_cut_buffers_internal): Remove.
6161 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6162 Fns_store_cut_buffer_internal.
6163 (ns_get_foreign_selection, Fx_own_selection_internal)
6164 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6165 (Fns_get_selection_internal, Fns_store_selection_internal):
6166 Use ns_symbol_to_pb and check if return value is nil.
6167 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6168 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6169 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6170 renamed to Sns_store_selection_internal.
6171 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6172 and remove this function.
6173 (ns_handle_selection_clear): Remove, never used.
6174 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6175 here.
6176
e1b01a3a
KB
61772011-12-17 Ken Brown <kbrown@cornell.edu>
6178
6179 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6180 GID is unknown (Bug#10257).
6181
2adb6e85
PE
61822011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6183
6184 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6185 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6186 which caused a build failure on GNU/Linux IA-64. This problem was
6187 introduced by my 2011-10-07 patch.
6188
d1d7b339
JL
61892011-12-15 Juri Linkov <juri@jurta.org>
6190
6191 * image.c (imagemagick_error): New function. (Bug#10112)
6192 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6193 Use `imagemagick_error' where ImageMagick functions return
6194 `MagickFalse'.
6195 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6196 proper order.
6197
100d5755
KH
61982011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6199
6200 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6201 fill background (Bug#8992).
6202
454592a6
MR
62032011-12-13 Martin Rudalics <rudalics@gmx.at>
6204
6205 * window.c (Vwindow_combination_resize)
6206 (Vwindow_combination_limit): Use t instead of non-nil in
6207 doc-strings.
61d4b438
MR
6208 (Vrecenter_redisplay): Add first sentence of doc-string on
6209 separate line.
53524d93 6210 (Frecenter): Fix doc-string typo.
454592a6 6211
3633e3aa
KH
62122011-12-11 Kenichi Handa <handa@m17n.org>
6213
6214 * coding.c (Funencodable_char_position): Pay attention to the
6215 buffer text relocation (Bug#9389).
6216
7b9d523a 62172011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6218
7b9d523a
JD
6219 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6220 gtk_init (Bug#10100).
6221
b73189c6
EZ
62222011-12-10 Eli Zaretskii <eliz@gnu.org>
6223
6224 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6225 IT->string is nil. (Bug#10263)
6226
f7dfe5d6
JD
62272011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6228
83faebb4
JD
6229 * nsterm.h (x_free_frame_resources): Declare.
6230
f7dfe5d6
JD
6231 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6232 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6233
6234 * nsterm.h (ns_get_defaults_value): Declare.
6235
6236 * nsterm.m (ns_default): Call ns_get_defaults_value.
6237
7cd4e72c
EZ
62382011-12-09 Eli Zaretskii <eliz@gnu.org>
6239
6240 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6241 (Bug#10170)
6242
b34d7317
YM
62432011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6244
6245 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6246 that where the value of an _OBJC_* symbol points to is in the .bss
6247 section (Bug#10240).
6248
76470ad1
KH
62492011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6250
6251 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6252 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6253
745fff94
KH
62542011-12-08 Kenichi Handa <handa@m17n.org>
6255
6256 * ftfont.c (get_adstyle_property): Fix previous change
6257 (Bug#10233).
6258
6e44397c
JB
62592011-12-07 Juanma Barranquero <lekktu@gmail.com>
6260
6261 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6262 dirs from the default value of EMACSLOADPATH (bug#10208).
6263
7efa6272
GM
62642011-12-07 Glenn Morris <rgm@gnu.org>
6265
6266 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6267 installation and source directories as well. (Bug#10208)
6268
f6fc4d87
CY
62692011-12-06 Chong Yidong <cyd@gnu.org>
6270
6271 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6272
2bf26180
GM
62732011-12-06 Glenn Morris <rgm@gnu.org>
6274
6275 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6276 as an error, not just -1. (Bug#10217)
6277
3a6ad4f0
CY
62782011-12-05 Chong Yidong <cyd@gnu.org>
6279
6280 * keyboard.c (process_special_events): New function.
6281 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6282
75a3b399
PE
62832011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6284
6285 * coding.c (encode_designation_at_bol): Don't use uninitialized
6286 local variable (Bug#9318).
6287
c3c9e25e
KH
62882011-12-05 Kenichi Handa <handa@m17n.org>
6289
6290 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6291 return Qnil (Bug#8046, Bug#10193).
6292
5eb05ea3
KH
62932011-12-05 Kenichi Handa <handa@m17n.org>
6294
6295 * coding.c (encode_designation_at_bol): New args charbuf_end and
6296 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6297 (coding_set_source): Return how many bytes coding->source was
6298 relocated.
6299 (coding_set_destination): Return how many bytes
6300 coding->destination was relocated.
6301 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6302 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6303
63042011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6305
6306 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6307 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6308 macro (Bug#9318).
6309
63102011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6311
6312 The following changes are to fix Bug#9318.
6313
a79703f5 6314 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6315 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6316 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6317 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6318
7dbda6df
JB
63192011-12-05 Juanma Barranquero <lekktu@gmail.com>
6320
6321 * lisp.h (process_quit_flag): Fix external declaration.
6322
6d5eb5b0
SM
63232011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6324
6325 Don't macro-inline non-performance-critical code.
6326 * eval.c (process_quit_flag): New function.
6327 * lisp.h (QUIT): Use it.
6328
a0c3fad0
JD
63292011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6330
6331 * nsfns.m (get_geometry_from_preferences): New function.
6332 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6333
6c07aac2
AS
63342011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6335
6336 * emacs.c (Qkill_emacs): Define.
6337 (syms_of_emacs): Initialize it.
6338 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6339 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6340 (quit_throw_to_read_char): Add parameter `from_signal'.
6341 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6342 * lisp.h (QUIT): Call Fkill_emacs if requested.
6343
c052ead4
JD
63442011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6345
6346 * widget.c (update_wm_hints): Return if wmshell is null.
6347 (widget_update_wm_size_hints): New function.
6348
6349 * widget.h (widget_update_wm_size_hints): Declare.
6350
6351 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6352 widget_update_wm_size_hints (Bug#10104).
6353
9e49252b
EZ
63542011-12-03 Eli Zaretskii <eliz@gnu.org>
6355
6356 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6357 before a newline, prepare the bidi iterator for consuming the
6358 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6359 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6360
02b16839
JL
63612011-12-02 Juri Linkov <juri@jurta.org>
6362
6363 * search.c (Fword_search_regexp): New Lisp function created from
6364 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6365 (Fword_search_backward, Fword_search_forward)
6366 (Fword_search_backward_lax, Fword_search_forward_lax):
6367 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6368 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6369
0068070e
SM
63702011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6371
6372 * fileio.c (Finsert_file_contents): Move after-change-function call
6373 to before the "handled:" label, since all "goto handled" appear in
6374 cases where the *-change-functions have already been properly called
6375 (bug#10117).
6376
3360a3fc
AS
63772011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6378
6379 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6380 waiting for input. (Bug#10169)
6381
73d6c093
EZ
63822011-11-30 Eli Zaretskii <eliz@gnu.org>
6383
6384 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6385 verifies glyph row's hash code--we have just reallocated the
6386 glyphs, so their contents can be complete garbage. (Bug#10164)
6387
febe6bea
JB
63882011-11-30 Juanma Barranquero <lekktu@gmail.com>
6389
6390 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6391
801a4313
EZ
63922011-11-30 Eli Zaretskii <eliz@gnu.org>
6393
6394 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6395 attributes are tested _before_ calling verify_row_hash, to protect
6396 against GCC re-ordering of the tests. (Bug#10164)
6397
2b56b87e
JD
63982011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6399
6400 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6401
6402 * xterm.c (handle_one_xevent): Only set async_visible and friends
6403 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6404 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6405 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6406
dbf31225
PE
64072011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6408
6409 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6410 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6411 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6412 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6413 All uses changed to use GCPRO1 etc.
6414 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6415 Revert to old implementation (i.e., before 2011-03-11).
6416
1305621b
YM
64172011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6418
6419 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6420 of scroll runs so as to avoid assigning disabled bogus rows and
6421 unnecessary graphics copy operations.
6422
8c9afb46
EZ
64232011-11-27 Eli Zaretskii <eliz@gnu.org>
6424
6425 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6426 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6427 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6428 (malloc, free, realloc, calloc): Redirect to e_* only when
6429 compiling Emacs.
6430
6431 * lisp.h (GCTYPEBITS): Move before first use.
6432 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6433 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6434 this macro definition.
6435
6436 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6437 _MSC_VER.
6438
54e9e3bf
JD
64392011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6440
6d5eb5b0
SM
6441 * gtkutil.c (xg_create_frame_widgets):
6442 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6443 present with Gtk+ 2.0.
6444
83aca1cb
PE
64452011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6446
6447 * fileio.c (Finsert_file_contents): Undo previous change; see
6448 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6449
5b76caa4
PE
64502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6451
6452 Rename locals to avoid shadowing.
6453 * fileio.c (Finsert_file_contents):
6454 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6455 * process.c (wait_reading_process_output):
6456 Rename inner 'proc' to 'p' to avoid shadowing.
6457 Indent for consistency with usual Emacs style.
6458
8c535114
EZ
64592011-11-25 Eli Zaretskii <eliz@gnu.org>
6460
6461 * xdisp.c (redisplay_window): If cursor row is not fully visible
6462 after recentering, and scroll-conservatively is set to a large
6463 number, scroll window by a few more lines to make the cursor fully
6464 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6465 (start_display): Don't move to the next line if the display should
6466 start at a newline that is part of a display vector or an overlay
6467 string. (Bug#10119)
8c535114 6468
fa4fdb5c
JL
64692011-11-24 Juri Linkov <juri@jurta.org>
6470
6471 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6472 after the `MagickPingImage' call. (Bug#10112)
6473
90ec88df
CY
64742011-11-23 Chong Yidong <cyd@gnu.org>
6475
6476 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6477
56e2e794
MR
64782011-11-23 Martin Rudalics <rudalics@gmx.at>
6479
6480 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6481 making another buffer current. (Bug#10114)
6482
b6e64c41
GM
64832011-11-23 Glenn Morris <rgm@gnu.org>
6484
6485 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6486
6b21de18
CY
64872011-11-23 Chong Yidong <cyd@gnu.org>
6488
6489 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6490 using it (Bug#5984).
6491
b12cd789
EZ
64922011-11-22 Eli Zaretskii <eliz@gnu.org>
6493
6494 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6495 and header-lines, as they don't have one computed for them.
6496 (Bug#10098)
6497
6498 * .gdbinit (prow): Make displayed values more self-explaining.
6499 Add row's hash code.
6500
261b6fd4
LMI
65012011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6502
6503 * process.c (wait_reading_process_output): Fix asynchrounous
6504 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6505 (wait_reading_process_output): Add comment and URL.
261b6fd4 6506
e7cfd277
JD
65072011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6508
6509 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6510
a9b9b7f5
CY
65112011-11-21 Chong Yidong <cyd@gnu.org>
6512
6513 * window.c (Fnext_window, Fprevious_window): Doc fix.
6514
b0d15b4f
SM
65152011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6516
6517 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6518
fe7a3057
JB
65192011-11-20 Juanma Barranquero <lekktu@gmail.com>
6520
6521 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6522
d2999b1a
MR
65232011-11-20 Martin Rudalics <rudalics@gmx.at>
6524
6525 * window.c (Fset_window_combination_limit): Rename argument
6526 STATUS to LIMIT.
6527 (Vwindow_combination_limit): Remove "status" from doc-string.
6528
d5ff9cd0
AS
65292011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6530
6531 * m/ibms390.h: Remove.
6532 * m/ibms390x.h: Don't include "ibms390.h".
6533
a5bb9bd3
SM
65342011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6535
6536 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6537 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6538
cd1181db
JB
65392011-11-20 Juanma Barranquero <lekktu@gmail.com>
6540
6541 * casetab.c (Fset_case_table):
6542 * charset.c (Fcharset_after): Fix typos.
6543
615a3b8d 65442011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6545
17e845af
PE
6546 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6547 Otherwise, valgrind does not work on some platforms.
6548 Problem reported by Andreas Schwab in
6a0bf43d
PE
6549 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6550 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6551 is set, removing the need for VIRT_ADDRESS_VARIES.
6552 (PURE_P): Use a more-efficient implementation that needs just one
6553 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6554 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6555 to 4 (xorl, subq, cmpq, setbe).
6556 * alloc.c (pure): Always extern now, since that's the
6557 VIRT_ADDR_VARIES behavior.
6558 (PURE_POINTER_P): Use a single comparison, not two, for
6559 consistency with the new puresize.h.
6560 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6561 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6562 Remove VIRT_ADDR_VARIES no longer needed.
6563
f8fe6f96
EZ
65642011-11-19 Eli Zaretskii <eliz@gnu.org>
6565
6566 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6567 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6568 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6569 behave as if the cursor position were at the window margin.
6570
6571 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6572 and the cursor position is out of bounds, behave as if the cursor
6573 position were at the window margin. (Bug#10075)
6574
df05a53c
CY
65752011-11-18 Chong Yidong <cyd@gnu.org>
6576
6577 * window.c (Fwindow_combination_limit): Make first argument
6578 non-optional, since it is meaningless for live windows like the
6579 selected window.
61ccba97 6580
2071918e
DA
65812011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6582
6583 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6584
b50a28de
SM
65852011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6586
6587 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6588 (graft_intervals_into_buffer): Simplify.
6589
015137db
EZ
65902011-11-18 Eli Zaretskii <eliz@gnu.org>
6591
6592 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6593 hash values of the two rows.
6594 (copy_row_except_pointers): Preserve the used[] arrays and the
6595 hash values of the two rows. (Bug#10035)
68c95424 6596 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6597
6598 * xdisp.c (row_hash): New function, body extracted from
6599 compute_line_metrics.
6600 (compute_line_metrics): Call row_hash, instead of computing the
6601 hash code inline.
6602
6603 * dispnew.c (verify_row_hash): Call row_hash for computing the
6604 hash code of a row, instead of duplicating code from xdisp.c.
6605
6606 * dispextern.h (row_hash): Add prototype.
6607
a2addb04
TH
66082011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6609
6610 * frame.c (delete_frame): Don't delete the terminal when the last
6611 X frame is closed if emacs is built with GTK toolkit.
6612
df85d315
JB
66132011-11-17 Juanma Barranquero <lekktu@gmail.com>
6614
6615 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6616
a0c2d0ae
MR
66172011-11-17 Martin Rudalics <rudalics@gmx.at>
6618
6619 * window.c (Vwindow_splits): Rename to
6620 Vwindow_combination_resize. Suggested by Juri Linkov.
6621 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6622 of Vwindow_splits.
6623
58179cce
JB
66242011-11-16 Juanma Barranquero <lekktu@gmail.com>
6625
7877f373
JB
6626 * nsfns.m (Fns_font_name):
6627 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6628
b6f67890
MR
66292011-11-16 Martin Rudalics <rudalics@gmx.at>
6630
6631 * window.h (window): Rename slot "nest" to "combination_limit".
6632 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6633 (Fset_window_nest): Rename to Fset_window_combination_limit.
6634 (Vwindow_nest): Rename to Vwindow_combination_limit.
6635 (recombine_windows, make_parent_window, make_window)
6636 (Fsplit_window_internal, saved_window)
6637 (Fset_window_configuration, save_window_save): Rename all
6638 occurrences of window_nest to window_combination_limit.
6639
c7015153
JB
66402011-11-15 Juanma Barranquero <lekktu@gmail.com>
6641
6642 * image.c (imagemagick_load_image): Fix typo.
6643
322ad6ec
EZ
66442011-11-14 Eli Zaretskii <eliz@gnu.org>
6645
6646 * xdisp.c (display_line): Move the call to
6647 highlight_trailing_whitespace before the call to
6648 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6649 faces of all the glyphs to compute ROW's hash value.
6650 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6651
f067b8ec
JB
66522011-11-14 Juanma Barranquero <lekktu@gmail.com>
6653
6654 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6655 just return (bug#10044).
6656
1e5b2111
EZ
66572011-11-12 Eli Zaretskii <eliz@gnu.org>
6658
7ef3cbd5
EZ
6659 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6660 with user-defined heap size. Bump the default size of the temacs
6661 heap to 27MB, to avoid memory warning when running temacs.
6662 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6663
1e5b2111
EZ
6664 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6665 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6666 (verify_row_hash) [XASSERTS]: New function.
6667 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6668 that the hash value of glyph rows is correct.
1e5b2111 6669
89d61221
MR
66702011-11-12 Martin Rudalics <rudalics@gmx.at>
6671
6672 * window.h (window): Remove splits slot.
6673 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6674 (Fdelete_other_windows_internal, make_parent_window)
6675 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6676 (Fset_window_configuration, save_window_save): Don't deal with
6677 split status of windows.
6678 (saved_window): Remove splits slot.
6679 (Vwindow_splits): Rewrite doc-string.
6680
97f18cc8
JD
66812011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6682
6683 * xfns.c (unwind_create_frame):
6684 * nsfns.m (unwind_create_frame):
6685 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6686 Vframe_list (Bug#9999).
6687
22a648b4
DA
66882011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6689
0b381c7e 6690 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6691
659afede
KH
66922011-11-11 Kenichi Handa <handa@m17n.org>
6693
6694 * callproc.c (Fcall_process): Set the member dst_multibyte of
6695 process_coding.
6696
9ac0394b
KH
66972011-11-11 Johan Bockgård <bojohan@gnu.org>
6698
6699 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6700 avoid a crash (bug#9496).
6701
2fbdc249
CY
67022011-11-09 Chong Yidong <cyd@gnu.org>
6703
6704 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6705 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6706
ac6b1f81
PE
67072011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6708
6709 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6710
09db192c
PE
67112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6712
6713 Avoid some portability problems by eschewing 'extern inline' functions.
6714 The trivial performance wins aren't worth the portability hassles; see
6715 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6716 et seq.
6717 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6718 (window_box_width, window_box_left, window_box_left_offset)
6719 (window_box_right, window_box_right_offset): Undo previous change,
6720 by removing the "extern"s.
6721 * intervals.c (adjust_intervals_for_insertion)
6722 (adjust_intervals_for_deletion): Undo previous change,
6723 making these static again.
6724 (offset_intervals, temp_set_point_both, temp_set_point)
6725 (copy_intervals_to_string): No longer inline.
6726 * xdisp.c (window_text_bottom_y, window_box_width)
6727 (window_box_height, window_box_left_offset)
6728 (window_box_right_offset, window_box_left, window_box_right)
6729 (window_box): No longer inline.
6730
105216ed
CY
67312011-11-08 Chong Yidong <cyd@gnu.org>
6732
6733 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6734 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6735 Signal an error if not a live window.
105216ed
CY
6736 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6737 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6738
ae9e237f
JB
67392011-11-07 Juanma Barranquero <lekktu@gmail.com>
6740
6741 * lisp.h (syms_of_abbrev): Remove declaration.
6742 Reported by CHENG Gao <chenggao@royau.me>.
6743
c7aa8333
EZ
67442011-11-07 Eli Zaretskii <eliz@gnu.org>
6745
6746 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6747 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6748 of temacs in GUI mode.
6749
be7f5545
MR
67502011-11-07 Martin Rudalics <rudalics@gmx.at>
6751
6752 * window.h: Declare delete_all_child_windows instead of
6753 delete_all_subwindows.
6754 * window.c (Fwindow_nest, Fset_window_nest)
6755 (Fset_window_new_total, Fset_window_new_normal)
6756 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6757 (delete_all_subwindows): Rename to delete_all_child_windows.
6758 (Fdelete_other_windows_internal, Fset_window_configuration):
6759 Call delete_all_child_windows instead of delete_all_subwindows.
6760 * frame.c (delete_frame): Call delete_all_child_windows instead
6761 of delete_all_subwindows.
6762
ca78dc43
PE
67632011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6764
6765 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6766 This is also needed for porting to any host where GC_MARK_STACK is
6767 not GC_MAKE_GCPROS_NOOPS.
6768 (which_symbols): Use it.
6769
a0241d01
KH
67702011-11-07 Kenichi Handa <handa@m17n.org>
6771
6772 * coding.c (coding_set_destination): Check coding->src_pos only
6773 when coding->src_object is a buffer (bug#9910).
6774
6775 * process.c (send_process): Set the member src_multibyte of coding
6776 to 0 (bug#9911) when sending a unibyte text.
6777
6778 * callproc.c (Fcall_process): Set the member src_multibyte of
6779 process_coding to 0 (bug#9912).
6780
a64bfdfa 67812011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6782
6783 * xmenu.c (cleanup_widget_value_tree): New function.
6784 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6785 calling free_menubar_widget_value_tree directly (Bug#9830).
6786
cb41b32a
PE
67872011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6788
6789 Fix some portability problems with 'inline'.
6790 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6791 (window_box_width, window_box_left, window_box_left_offset)
6792 (window_box_right, window_box_right_offset): Declare extern.
6793 Otherwise, these inline functions do not conform to C99 and
6794 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6795 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6796 * intervals.c (adjust_intervals_for_insertion)
6797 (adjust_intervals_for_deletion): Now extern, because otherwise the
6798 extern inline functions 'offset_intervals' couldn't refer to it.
6799 (static_offset_intervals): Remove.
6800 (offset_intervals): Rewrite using the old contents of
6801 static_offset_intervals. The old version didn't conform to C99
6802 because an extern inline function contained a reference to an
6803 identifier with static linkage.
6804
b7041366
AS
68052011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6806
6807 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6808 GC.
6809
88a37c4d
EZ
68102011-11-06 Eli Zaretskii <eliz@gnu.org>
6811
6812 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6813 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6814 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6815 return Qleft_to_right.
6816
49745b39
CY
68172011-11-06 Chong Yidong <cyd@gnu.org>
6818
6819 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6820 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6821 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6822 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6823 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6824 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6825 (Fwindow_vscroll): Doc fix.
6826 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6827 argument, since it makes no sense to pass a live window and for
6828 consistency with window-child.
6829
1f05cd82
CS
68302011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6831
6832 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6833 support MSVC.
6834
22610910
JR
68352011-11-05 Jason Rumney <jasonr@gnu.org>
6836
6837 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6838 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6839 fonts (Bug#6029).
6840 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6841 bitwise arithmetic preventing use of unicode-sip and non-truetype
6842 opentype fonts.
6843
a06776b2
EZ
68442011-11-05 Eli Zaretskii <eliz@gnu.org>
6845
3ad924ba
EZ
6846 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6847 "emacs"-only part.
6848
a06776b2
EZ
6849 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6850 initialization code to keep similarity to xfns.c after changes
6851 from 2011-11-05.
6852
c9e7db78
JD
68532011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6854
a97f8f3f
JD
6855 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6856 (unwind_create_frame): New function (Bug#9943).
6857 (Fx_create_frame): Restructure code to be more similar to the one in
6858 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6859 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6860 Move terminal->reference_count++ just before making the frame official
6861 (Bug#9943).
6862
6863 * nsterm.m (x_free_frame_resources): New function.
6864 (x_destroy_window): Move code to x_free_frame_resources.
6865
c9e7db78 6866 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6867 (Fx_create_frame, x_create_tip_frame):
6868 Move terminal->reference_count++ just before making the frame
75f1671a 6869 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6870 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6871
a6fc3b5c
EZ
68722011-11-05 Eli Zaretskii <eliz@gnu.org>
6873
6874 Support MSVC build with newer versions of Visual Studio.
6875 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6876 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6877 nt/gmake.defs.
6878
6879 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6880 which are not supported by MSVC.
6881 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6882 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6883 bitfields.
6884 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6885 types in bitfields.
6886 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6887
6888 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6889
58179cce 68902011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6891
6892 Support MSVC build with newer versions of Visual Studio.
6893 * w32.c: Don't include w32api.h for MSVC.
6894 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6895
6896 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6897 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6898 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6899 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6900 e_* cousins.
6901 (alloca) [_MSC_VER]: Define to _alloca.
6902
6903 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6904
6905 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6906
a58c13ed
EZ
69072011-11-04 Eli Zaretskii <eliz@gnu.org>
6908
6909 * xdisp.c (note_mouse_highlight): If either of
6910 previous/next-single-property-change returns nil, treat that as
6911 the beginning or the end of the buffer. (Bug#9955)
6912
fe0b6370
JD
69132011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6914
a58c13ed 6915 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6916 label is not null (Bug#9951).
6917 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6918 may be NULL.
6919
89bd5ee1
EZ
69202011-11-04 Eli Zaretskii <eliz@gnu.org>
6921
6922 * window.c (Fwindow_body_size): Mention in the doc string that the
6923 return value is in frame's canonical units. (Bug#9949)
6924
84c3edb9
EZ
69252011-11-03 Eli Zaretskii <eliz@gnu.org>
6926
4e2fb5c7
EZ
6927 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6928
84c3edb9 6929 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6930 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6931 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6932
bc17a887
EZ
69332011-11-01 Eli Zaretskii <eliz@gnu.org>
6934
6935 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6936 Don't stop backward scan on the continuation glyph, even though
6937 its CHARPOS is positive.
6d5eb5b0
SM
6938 (mouse_face_from_buffer_pos, note_mouse_highlight):
6939 Rename cover_string to disp_string.
bc17a887 6940
4ee88440
MR
69412011-11-01 Martin Rudalics <rudalics@gmx.at>
6942
6943 * window.c (temp_output_buffer_show): Don't use
6944 Vtemp_buffer_show_specifiers.
6945 (Vtemp_buffer_show_specifiers): Remove unused variable.
6946
c2ff3c02
EZ
69472011-10-30 Eli Zaretskii <eliz@gnu.org>
6948
6949 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6950 past the beginning of the current glyph matrix.
6951
58179cce 69522011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6953
6954 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6955 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6956 HAVE_GTK3 (Bug#9869).
b77a6a7f 6957
3b574623
JD
6958 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6959 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6960
b77a6a7f
JD
6961 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6962
6963 * xterm.c: Declare x_handle_net_wm_state to return int.
6964 (handle_one_xevent): Check if we are iconified but don't have
6965 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6966 (get_current_wm_state): Return non-zero if not hidden,
6967 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6968 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6969 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6970 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6971
196e41e4
PE
69722011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6973
6974 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6975 so that this new function doesn't get optimized away by a
6976 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6977
021f2e1a
AS
69782011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6979
6980 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6981
8b058d44
EZ
69822011-10-29 Eli Zaretskii <eliz@gnu.org>
6983
6984 Fix the `xbytecode' command.
6985 * .gdbinit (xprintbytestr): New command.
b50a28de 6986 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6987 (xbytecode): Print the byte-code string as well.
6988
4452fb80
EZ
69892011-10-29 Kim Storm <storm@cua.dk>
6990
8b058d44
EZ
6991 * alloc.c (which_symbols): New function.
6992
21b72067
AS
69932011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6994
6995 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6996 line. (Bug#9903)
6997
83ed7b5c
GM
69982011-10-29 Glenn Morris <rgm@gnu.org>
6999
7000 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7001 Not clear what it was for, and it causes various bugs. (Bug#9839)
7002
5a7a728b
EZ
70032011-10-28 Eli Zaretskii <eliz@gnu.org>
7004
7005 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7006 possible random value that matches one of those tested as
7007 condition to clear the mouse face.
7008
d3d0842f
CY
70092011-10-28 Chong Yidong <cyd@gnu.org>
7010
7011 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7012
31b39d13
DN
70132011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7014
7015 * window.c (make_window): Initialize phys_cursor_on_p.
7016
9aba6043
SM
70172011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7018
7019 * lisp.h (struct Lisp_Symbol): Update comments.
7020
c20992f4
JB
70212011-10-28 Juanma Barranquero <lekktu@gmail.com>
7022
7023 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7024
db4f02f2
EZ
70252011-10-28 Eli Zaretskii <eliz@gnu.org>
7026
7027 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7028 <oslsachem@gmail.com> for helping to debug this.
7029
7030 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7031 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7032 (g_b_init_get_glyph_outline_w): New static variables.
7033 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7034 (GetGlyphOutlineW_Proc): New typedefs.
7035 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7036 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7037 New functions.
7038 (w32font_open_internal, compute_metrics):
7039 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7040 instead of calling the "wide" APIs directly.
7041
7042 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7043
7044 * w32.h (syms_of_w32font): Add prototype.
7045
87e68db4
JB
70462011-10-27 Juanma Barranquero <lekktu@gmail.com>
7047
7048 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7049 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7050 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7051 (Fmove_to_window_line): Doc fix.
7052
435c1d67
CY
70532011-10-27 Chong Yidong <cyd@gnu.org>
7054
7055 * process.c (make_process): Set gnutls_state to NULL.
7056
7057 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7058 non-NULL, regardless of GNUTLS_INITSTAGE.
7059 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7060 an error. Set process slots as soon as we allocate them.
7061
7062 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7063
9c6c6f49
CY
70642011-10-27 Chong Yidong <cyd@gnu.org>
7065
9aba6043
SM
7066 * gnutls.c (emacs_gnutls_deinit): New function.
7067 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7068 (Fgnutls_deinit, Fgnutls_boot): Use it.
7069
7070 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7071 (deactivate_process): Call emacs_gnutls_deinit.
7072
657d08d3
JB
70732011-10-27 Juanma Barranquero <lekktu@gmail.com>
7074
7075 * image.c (x_create_x_image_and_pixmap):
7076 * w32.c (sys_rename, w32_delayed_load):
7077 * w32font.c (fill_in_logfont):
7078 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7079
5430d399
JB
70802011-10-26 Juanma Barranquero <lekktu@gmail.com>
7081
7082 * w32fns.c (w32_default_color_map): New function,
7083 extracted from Fw32_default_color_map.
a7ef684b 7084 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7085
fe0055fa
PE
70862011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7087
7088 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7089
e6346438
SM
70902011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7091
7092 * keyboard.c (test_undefined): New function (bug#9751).
7093 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7094
e112cc37
ET
70952011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7096
7097 * sysdep.c (init_sys_modes): Fix the check for the controlling
7098 terminal (Bug#6649).
7099
7b5d6677
EZ
71002011-10-20 Eli Zaretskii <eliz@gnu.org>
7101
7102 * dispextern.h (struct bidi_it): New member next_en_type.
7103
7104 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7105 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7106 current character, check also for next_en_type being WEAK_EN.
7107 (bidi_resolve_weak): Don't enter the expensive loop if the current
7108 position is before next_en_pos. Record the bidi type of the first
7109 non-ET, non-BN character we find, in addition to its position.
7110 (bidi_level_of_next_char): Invalidate next_en_type when
7111 next_en_pos is over-stepped.
7112
7da0b018
PE
71132011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7114
7115 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7116 * editfns.c: Rewrite current-time-zone so that it invokes
7117 the equivalent of (format-time-string "%Z") to get the time zone name.
7118 This fixes a bug when the time zone name contains characters that
7119 need converting from the system time locale to Emacs internal format.
7120 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7121 that patch fixed format-time-string to do the conversion, but
7122 I forgot to fix current-time-zone.
7123 (format_time_string): New function, containing most of
7124 what Fformat_time_string used to contain.
7125 (Fformat_time_string): Rewrite in terms of format_time_string.
7126 This doesn't change this function's behavior.
7127 (current-time-zone): Rewrite to use format_time_string.
7128 This fixes the bug reported by Michael Schierl in
7129 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7130 Jason Rumney's 2007-06-07 change worked around this bug, but
7131 didn't fix it.
7132 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7133
8547b010
EZ
71342011-10-19 Eli Zaretskii <eliz@gnu.org>
7135
7136 * xdisp.c (start_display): If the character at POS is displayed
7137 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7138 (try_window_reusing_current_matrix): If a line ends in a display
7139 vector or the next line starts in a display vector, continue
7140 redrawing the window even though the character position of
7141 start_row was reached.
8547b010
EZ
7142 (Bug#9771, part 2)
7143
4e948d15
CY
71442011-10-18 Chong Yidong <cyd@gnu.org>
7145
7146 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7147 with nobreak-char-display too.
7148
4787455f
EZ
71492011-10-18 Eli Zaretskii <eliz@gnu.org>
7150
7151 Fix part 3 of bug#9771.
7152 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7153 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7154 non-neutral characters if the current character is a paragraph
7155 separator (a.k.a. Newline). This avoids running the same
7156 expensive loop twice, once when we consume the preceding newline
7157 and the other time when the line actually needs to be displayed.
7158 Avoid the loop when we see neutrals on the base embedding level
7159 following a character whose directionality is the same as the
7160 paragraph's. This avoids running the expensive loop when a line
7161 ends in a long sequence of neutrals, like control characters.
7162 Add assertion against STRONG_AL type. Slightly rearrange code
7163 that determines the type of a neutral given the first non-neutral
7164 that follows it.
7165 (bidi_level_of_next_char): Set next_en_pos to zero when
7166 invalidating its info.
7167
2c91f553
EZ
71682011-10-17 Eli Zaretskii <eliz@gnu.org>
7169
7170 * xdisp.c (push_display_prop): Determine whether to record string
7171 or buffer position by IT->string, not by IT->method. Allow
7172 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7173 (move_it_vertically_backward): Don't look for character position
7174 immediately after the newline when in a continuation line.
7175 (Bug#9771, part 1)
2c91f553 7176
c7b08b0d
MR
71772011-10-15 Martin Rudalics <rudalics@gmx.at>
7178
7179 * window.c (coordinates_in_window): Rewrite and delabelize
7180 vertical border check. (Bug#5357) (Bug#9618)
7181
6b02f655
SM
71822011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7183
7184 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7185 errors in XSetWindowBorder (bug#9310).
7186
81d40c92
DA
71872011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7188
7189 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7190 avoid crash when xmalloc overrun checking is enabled.
7191
d4172c3b
EZ
71922011-10-13 Eli Zaretskii <eliz@gnu.org>
7193
7194 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7195 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7196 cursor motion with <left> and <right> arrow keys.
7197
7198 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7199 some callers set that themselves.
7200
b00eea75
EZ
72012011-10-12 Eli Zaretskii <eliz@gnu.org>
7202
7203 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7204 display string and the previous row comes from the same string and
7205 is empty. (Bug#9739) (Bug#9738)
7206
8fe012c4
SM
72072011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7208
7209 * doc.c (get_doc_string): Encode file name (bug#9735).
7210
0074aef2
EZ
72112011-10-12 Eli Zaretskii <eliz@gnu.org>
7212
79beb178
EZ
7213 * bidi.c (bidi_level_of_next_char):
7214 * xdisp.c (get_visually_first_element): Remove old incorrect
7215 comments regarding the Unicode Line Separator character.
7216
0074aef2
EZ
7217 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7218
6e4b3fbe
DA
72192011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7220
7221 * alloc.c (Fgc_status): Do not access beyond zombies array
7222 boundary if nzombies > MAX_ZOMBIES.
7223 * alloc.c (dump_zombies): Add missing format specifier.
7224
0324f3af
PE
72252011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7226
b5525cac
PE
7227 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7228 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7229
0324f3af
PE
7230 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7231 Some packages use them to denote characters with modifiers.
7232
e9b5f888
AS
72332011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7234
7235 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7236 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7237 matching a pp-number. Rename parameter var to var1.
7238
127827c0
SM
72392011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7240
7241 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7242
c8fd3bd0
GM
72432011-10-08 Glenn Morris <rgm@gnu.org>
7244
7245 * callint.c (Fcall_interactively): Give a more explicit error for the
7246 'c' case with a non-character input. (Bug#8479)
7247
352ec8ff
EZ
72482011-10-08 Eli Zaretskii <eliz@gnu.org>
7249
03669ccb
EZ
7250 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7251 lines.
7061c986
EZ
7252 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7253 lines that are hscrolled on the left.
03669ccb 7254
352ec8ff
EZ
7255 * dispnew.c (buffer_posn_from_coords): Account for a possible
7256 presence of header-line. (Bug#4426)
7257
a66cfb1c
SM
72582011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7259
6b02f655
SM
7260 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7261 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7262
7c5ee88e
PE
72632011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7264
7265 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7266 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7267 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7268 this makes Emacs dump core during garbage collection on rare
7269 occasions. sizeof is obviously inferior to offsetof here, so
7270 stick with offsetof.
7271 (GC_POINTER_ALIGNMENT): New macro.
7272 (mark_memory): Omit 3rd (offset) arg; caller changed.
7273 Don't assume EMACS_INT alignment is the same as pointer alignment.
7274
df1bbe5b
SM
72752011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7276
7277 * keyboard.c (read_key_sequence_remapped): New var.
7278 (read_key_sequence): Compute remapping in the right buffer.
7279 (command_loop_1): Use read_key_sequence's remapping directly.
7280
51553db6
SM
72812011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7282
32c1fffd
SM
7283 * dired.c (file_name_completion): Don't expand file name.
7284 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7285 before checking file name handler.
7286
51553db6
SM
7287 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7288 they've been requested explicitly (bug#9591).
7289
b6bd1599 72902011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7291
7292 * keymap.c (Fsingle_key_description): Use make_specified_string
7293 instead of build_string to build string from push_key_description.
7294 (Bug#5193)
7295
f701dc2a
PE
72962011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7297
4222c55d
PE
7298 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7299 This fixes a Y2038 bug on 64-bit hosts.
7300 * buffer.c (reset_buffer):
7301 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7302 (Fclear_buffer_auto_save_failure):
7303 Use 0, not -1, to represent an unset failure time, since time_t
7304 might not be signed.
7305
f701dc2a
PE
7306 Remove dependency on glibc malloc internals.
7307 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7308 Move back here from lisp.h, but with their new implementations.
7309 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7310 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7311 * charset.c (charset_table_init): New static var.
7312 (syms_of_charset): Use it instead of xmalloc. This removes a
7313 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7314 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7315 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7316 Move back to alloc.c.
7317 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7318 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7319
9ceebf39
JD
73202011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7321
7322 * nsterm.m (windowDidResize): Call x_set_window_size only when
7323 ns_in_resize is true. Otherwise set pixelwidth/height and
7324 call change_frame_size (Bug#9628).
7325
cb993c58
PE
73262011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7327
3930c88b
PE
7328 Port --enable-checking=all to Fedora 14 x86-64.
7329 * charset.c (syms_of_charset): Also account for glibc malloc's
7330 internal overhead when calculating the initial malloc maximum.
7331
cb993c58
PE
7332 Port --enable-checking=all to Fedora 14 x86.
7333 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7334 Move to lisp.h.
7335 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7336 (overrun_check_realloc, overrun_check_free):
7337 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7338 That way, xmalloc returns a properly-aligned pointer even if
7339 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7340 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7341 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7342 into account when calculating the initial malloc maximum.
7343 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7344 Move here from alloc.c, so that charset.c can use it too.
7345 Properly align; the old code wasn't right for common 32-bit hosts
7346 when configured with --enable-checking=all.
7347 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7348 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7349
31bed486
EZ
73502011-09-29 Eli Zaretskii <eliz@gnu.org>
7351
04c70788 7352 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7353 use EDOM.
7354
fbcaa2f3
EZ
73552011-09-28 Eli Zaretskii <eliz@gnu.org>
7356
7357 * xdisp.c (compute_display_string_end): If there's no display
7358 string at CHARPOS, return -1.
7359
7360 * bidi.c (bidi_fetch_char): When compute_display_string_end
7361 returns a negative value, treat the character as a normal
7362 character not covered by a display string. (Bug#9624)
7363
a239d4e9
JB
73642011-09-28 Juanma Barranquero <lekktu@gmail.com>
7365
7366 * lread.c (Fread_from_string): Fix typo in docstring.
7367
88652fd5
EZ
73682011-09-27 Eli Zaretskii <eliz@gnu.org>
7369
7370 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7371 newline, reseat the iterator instead of bidi-iterating there one
7372 character at a time. (Bug#9610)
32c1fffd
SM
7373 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7374 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7375
ed497dd4
AS
73762011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7377
7378 * lread.c (readevalloop): Use correct code for NBSP.
7379 (read1): Likewise. (Bug#9608)
7380
b2bf61aa
MA
73812011-09-25 Michael Albinus <michael.albinus@gmx.de>
7382
7383 * dbusbind.c (Fdbus_register_signal): When service is not
7384 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7385
32bbb17c
GM
73862011-09-25 Glenn Morris <rgm@gnu.org>
7387
7388 * buffer.c (truncate-lines): Doc fix.
7389
94e0933e
CY
73902011-09-24 Chong Yidong <cyd@stupidchicken.com>
7391
7392 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7393 (Fset_window_next_buffers): Doc fix.
7394
cddde921
GM
73952011-09-24 Glenn Morris <rgm@gnu.org>
7396
7397 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7398
1260aef1
PE
73992011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7400
25b4bfa0
PE
7401 Fix minor problems found by static checking.
7402 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7403 * indent.c (Fvertical_motion): Fix == vs = typo.
7404
e3cbd34b
EZ
74052011-09-24 Eli Zaretskii <eliz@gnu.org>
7406
a66cfb1c
SM
7407 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7408 Default value is now t. Doc fix.
6bf7006f 7409
e3cbd34b 7410 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7411 logic when moving up, not only when moving down. Fix the
e3cbd34b 7412 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7413 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7414
7415 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7416 CHARPOS is covered by a display string which includes newlines.
7417 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7418 is covered by a display string with embedded newlines.
7419
a3de0cbd
MA
74202011-09-24 Michael Albinus <michael.albinus@gmx.de>
7421
7422 * dbusbind.c (Fdbus_register_signal): Add match rule to
7423 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7424 (Fdbus_register_method, Vdbus_registered_objects_table):
7425 Fix docstring.
a3de0cbd 7426
b260039d
JM
74272011-09-24 Jim Meyering <meyering@redhat.com>
7428
32c1fffd 7429 do not ignore write error for any output size
b260039d
JM
7430 The previous change was incomplete.
7431 While it makes emacs --batch detect the vast majority of stdout
7432 write failures, errors were still ignored whenever the output size is
7433 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7434 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7435 && echo FAIL: ignored write error
7436 FAIL: ignored write error
7437 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7438 && echo FAIL: ignored write error
7439 FAIL: ignored write error
7440 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7441
8eca8a7c
AS
74422011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7443
7444 * emacs.c (Fkill_emacs): In noninteractive mode exit
7445 non-successfully if a write error occurred on stdout. (Bug#9574)
7446
3341db62
EZ
74472011-09-21 Eli Zaretskii <eliz@gnu.org>
7448
7449 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7450 the xassert test.
7451
7452 * dispextern.h (struct it): Update the comment documenting what
7453 can it->OBJECT be.
7454
8c203dbf
EZ
74552011-09-20 Eli Zaretskii <eliz@gnu.org>
7456
7457 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7458 a display string, extend search for cursor position to end of row.
7459 (find_row_edges): If the row ends in a newline from a display
7460 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7461 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7462 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7463 non-empty line. Fixes confusing cursor motion with arrow keys at
7464 the beginning of a line that starts with whitespace.
8c203dbf 7465
a4824228
LMI
74662011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7467
7468 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7469 (bug#9493).
7470
33ed493b
CY
74712011-09-18 Chong Yidong <cyd@stupidchicken.com>
7472
7473 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7474 boolean (Bug#9154).
7475
56cd55c8
EZ
74762011-09-18 Eli Zaretskii <eliz@gnu.org>
7477
7478 * xdisp.c (display_line): Record maximum and minimum buffer
7479 positions even if no glyphs were produced (e.g., by a zero-width
7480 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7481 buffer positions that will be removed from the glyph row because
7482 they don't fit.
c02dcedf
EZ
7483 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7484 column is beyond frame width: don't subtract 1 "pixel" when
7485 computing width of the stretch.
3e62b7e0
EZ
7486 (reseat_at_next_visible_line_start): Undo the change made on
7487 2011-09-17 that saved paragraph information and restored it after
7488 the call to `reseat'. (Bug#9545)
56cd55c8 7489
5ed99d36 74902011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7491
7492 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7493 and turn window cursor on if cleared (Bug#9415).
7494
5ed99d36 74952011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7496
7497 * search.c (boyer_moore): Take unibyte characters from pattern
7498 literally. (Bug#9458)
7499
9bade7b2
EZ
75002011-09-18 Eli Zaretskii <eliz@gnu.org>
7501
7502 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7503
e5e9d610
PE
75042011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7505
87e4427a
PE
7506 Fix minor problem found by static checking.
7507 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7508 initialized, to pacify gcc -Wuninitialized.
7509
e5e9d610
PE
7510 * fileio.c: Report proper errno when syscall falls.
7511 (Finsert_file_contents): Save and restore errno,
7512 so that report_file_error outputs the correct diagnostic.
7513 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7514
a1674f0b
EZ
75152011-09-18 Eli Zaretskii <eliz@gnu.org>
7516
7517 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7518
fbfb6dd4
EZ
75192011-09-17 Eli Zaretskii <eliz@gnu.org>
7520
7521 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7522 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7523
bb187662
EZ
75242011-09-17 Eli Zaretskii <eliz@gnu.org>
7525
1137e8b8 7526 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7527 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7528
7529 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7530 (bidi_find_paragraph_start): Search back for paragraph beginning
7531 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7532 (bidi_move_to_visually_next): Only trigger paragraph-related
7533 computations when the last character is a newline or at EOB, not
7534 just any NEUTRAL_B. (Bug#9470)
7535
bb187662
EZ
7536 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7537 truncated lines if point is covered by a display string. (Bug#9524)
7538
2e621251
PE
75392011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7540
7541 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7542 (cons_to_x_long): New function.
7543 (lisp_data_to_selection_data): Use it. Correct the test for
7544 short-versus-long data; it was negated. Break out of vector
7545 loop, for efficiency, when a long datum is discovered.
7546
91a15bc6
SM
75472011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7548
7549 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7550
b41c3a35
EZ
75512011-09-16 Eli Zaretskii <eliz@gnu.org>
7552
7553 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7554 GCC PR/17406) by declaring this function with external scope.
7555
7812ba2d
PE
75562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7557
7558 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7559 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7560
cf7edc2a
AS
75612011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7562
7563 * editfns.c (Fformat): Correctly handle text properties on "%%".
7564
bd01620e
EZ
75652011-09-15 Eli Zaretskii <eliz@gnu.org>
7566
7567 * xterm.c (x_draw_composite_glyph_string_foreground):
7568 * w32term.c (x_draw_composite_glyph_string_foreground):
7569 * term.c (encode_terminal_code):
7570 * composite.c (composition_update_it, get_composition_id):
7571 * xdisp.c (get_next_display_element)
7572 (fill_composite_glyph_string): Add comments about special meaning
7573 of TAB characters in a composition.
7574
a02719a3
PE
75752011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7576
7577 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7578 This occurs when processing a multibyte format.
7579 Problem reported by Wolfgang Jenker.
a02719a3 7580
72589a3c
JB
75812011-09-15 Johan Bockgård <bojohan@gnu.org>
7582
7583 * xdisp.c (try_cursor_movement): Only check for exact match if
7584 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7585
1c14176c
PE
75862011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7587
7588 Remove unused external symbols.
7589 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7590 * xdisp.c (calc_pixel_width_or_height): Now static.
7591 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7592 * indent.c (check_display_width):
7593 * w32term.c: Fix comment to match code.
7594 * xterm.c, xterm.h (x_catching_errors): Remove.
7595
d2eea5b5
PE
75962011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7597
7598 * xselect.c: Use signed conversions more consistently (Bug#9498).
7599 (selection_data_to_lisp_data): Assume incoming selection data are
7600 signed integers, not unsigned. This is to be consistent with
7601 outgoing selection data, which was modified to use signed integers
7602 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7603 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7604 expects long, not unsigned long.
7605
46888499
EZ
76062011-09-14 Eli Zaretskii <eliz@gnu.org>
7607
7608 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7609 computation of loop end. Reported by Johan Bockgård
7610 <bojohan@gnu.org>.
7611
ef8ef9fb
CY
76122011-09-13 Chong Yidong <cyd@stupidchicken.com>
7613
7614 * frame.c (Fother_visible_frames_p): Function deleted.
7615
fa819fed
EZ
76162011-09-12 Eli Zaretskii <eliz@gnu.org>
7617
7618 * indent.c (compute_motion): Process display vector front to back
7619 rather than the other way around. (Bug#2496)
7620
2ba8e008
SM
76212011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7622
7623 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7624
20f53c69
CY
76252011-09-11 Chong Yidong <cyd@stupidchicken.com>
7626
7627 * minibuf.c (Fread_from_minibuffer): Doc fix.
7628
d562d7a4
EZ
76292011-09-11 Eli Zaretskii <eliz@gnu.org>
7630
7631 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7632 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7633
1c4d7f3d
LMI
76342011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7635
7636 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7637 value for non-existent files.
7638
b885bf36
EZ
76392011-09-11 Eli Zaretskii <eliz@gnu.org>
7640
7641 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7642 set its "size" to -1. This will set the modtime_size field of
7643 the corresponding buffer to -1, which is what
7644 verify-visited-file-modtime expects for files that do not exist.
7645 (Bug#9139)
7646
6612f0bf
PE
76472011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7648
7649 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7650 here ...
7651 * lisp.h: ... from here. push_key_description is no longer
7652 defined in keyboard.c, so its declaration should not be in
7653 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7654 logically belongs with push_key_description.
7655
dfb3f755
PE
76562011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7657
7658 * buffer.h: Include <sys/types.h> instead of <time.h>.
7659 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7660 Problem reported by Herbert J. Skuhra.
7661
3134906c
LMI
76622011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7663
7664 * xml.c (parse_region): Make the parsing work for
7665 non-comment-starting XML files again (bug#9144).
7666
8d903f4e
AS
76672011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7668
7669 * image.c (gif_load): Fix calculation of bottom and right corner.
7670 (Bug#9468)
7671
80ad64f4
EZ
76722011-09-10 Eli Zaretskii <eliz@gnu.org>
7673
7674 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7675 redisplay in small windows.
7676
208a048d
EZ
76772011-09-09 Eli Zaretskii <eliz@gnu.org>
7678
7679 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7680
9b1c252e
MR
76812011-09-08 Martin Rudalics <rudalics@gmx.at>
7682
7683 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7684 Operate on live windows only.
7685
2949f33b
JB
76862011-09-08 Juanma Barranquero <lekktu@gmail.com>
7687
7688 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7689
e08dcafd
EZ
76902011-09-07 Eli Zaretskii <eliz@gnu.org>
7691
7692 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7693 only under bidi iteration.
7694
115b96bd
JD
76952011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7696
7697 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7698
c8199d0f
PE
76992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7700
7701 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7702 Without this fix, the command to link temacs failed due to an
7703 undefined symbol __builtin_isnan. This is because
7704 /usr/include/iso/math_c99.h #defines isnan(x) to
7705 __builtin_isnan(x), but the bundled gcc, which identifies itself
7706 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7707 a __builtin_isnan.
7708 * floatfns.c (isnan): #undef, and then #define to a clone of
7709 what's in data.c.
7710 (Fisnan): Always define, since it's always available now.
7711 (syms_of_floatfns): Always define isnan at the Lisp level.
7712
e39b275c 77132011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7714
7715 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7716
b2db44d9 77172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7718
f4af5137 7719 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7720 The previous code assumed that file offsets (off_t values) fit in
7721 EMACS_INT variables, which is not true on typical 32-bit hosts.
7722 The code messed up by falsely reporting buffer overflow in cases
7723 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7724 when "big" contains more than 2**29 bytes, even though this
7725 inserts just one byte and does not overflow the buffer.
7726 (Finsert_file_contents): Store file offsets as off_t
7727 values, not as EMACS_INT values. Check for overflow when
7728 converting between EMACS_INT and off_t. When checking for
7729 buffer overflow or for overlap, take the offsets into account.
7730 Don't use EMACS_INT for small values where int suffices.
7731 When checking for overlap, fix a typo: ZV was used where
7732 ZV_BYTE was intended.
7733 (Fwrite_region): Don't assume off_t fits into 'long'.
7734 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7735
ecfc0a49
MA
77362011-09-05 Michael Albinus <michael.albinus@gmx.de>
7737
7738 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7739
6511acf2 77402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7741
0999621a 7742 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7743
7744 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7745 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7746 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7747 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7748 (modify_event_symbol): Do not assume that the length of
7749 name_alist_or_stem is safe to alloca and fits in int.
7750 (Fexecute_extended_command): Likewise for function name and binding.
7751 (Frecursion_depth): Wrap around reliably on integer overflow.
7752 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7753 since some callers pass EMACS_INT values.
7754 (Fsingle_key_description): Don't crash if symbol name contains more
7755 than MAX_ALLOCA bytes.
7756 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7757 (get_minibuffer): Arg is now EMACS_INT, not int.
7758 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7759 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7760 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7761
2be7d702
PE
7762 * dbusbind.c (signature_cat): New function.
7763 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7764 Do not overrun buffer; instead, report string overflow.
7765
9d1df220
PE
7766 * dispnew.c (add_window_display_history): Don't overrun buffer.
7767 Truncate instead; this is OK since it's just a log.
7768
33ef5c64
PE
7769 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7770 even if the time zone offset is outlandishly large.
7771 Don't mishandle offset == INT_MIN.
7772
66c6fdd5
PE
7773 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7774 when creating daemon; the previous buffer-overflow check was incorrect.
7775
d749b01b
PE
7776 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7777 which has the guts of the old verror function.
7778
b5cd1905
PE
7779 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7780 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7781
6e1a67fb
PE
7782 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7783 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7784 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7785 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7786 length of string rather than counting it via multiple sprintfs;
7787 that's simpler and more reliable.
c21721cc
PE
7788 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7789 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7790 sprintf, in case result does not fit in int.
7791
c57b67fc
PE
7792 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7793 (fontset_from_font): Print it.
7794
8a401434
PE
7795 * frame.c (tty_frame_count): Now printmax_t, not int.
7796 (make_terminal_frame, set_term_frame_name): Print it.
7797 (x_report_frame_params): In X, window IDs are unsigned long,
7798 not signed long, so print them as unsigned.
7799 (validate_x_resource_name): Check for implausibly long names,
7800 and don't assume name length fits in 'int'.
7801 (x_get_resource_string): Don't blindly alloca invocation name;
7802 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7803 not fit in int.
7804
6e1a67fb
PE
7805 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7806 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7807 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7808
0df02bf3
PE
7809 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7810 Use esprintf, not sprintf, in case result does not fit in int.
7811
48e30793
PE
7812 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7813 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7814 it as a large positive number.
7815 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7816 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7817
a66ff6d8
PE
7818 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7819 in case result does not fit in int.
7820
aca216ff
PE
7821 * print.c (float_to_string): Detect width overflow more reliably.
7822 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7823 buffer overrun. Don't assume list length fits in 'int'. Treat
7824 print length of 0 as 0, not as infinity; to be consistent with other
7825 uses of print length in this function. Don't overflow print length
7826 index. Don't assume hash table size fits in 'long', or that
7827 vectorlike size fits in 'unsigned long'.
7828
31c286f7
PE
7829 * process.c (make_process): Use printmax_t, not int, to format
7830 process-name gensyms.
7831
55e5faa1
PE
7832 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7833
80f2e268
PE
7834 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7835 to avoid potential buffer overrun.
7836
670741ab
PE
7837 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7838 if X resource line is longer than 512 bytes.
7839
b7163a50
PE
7840 * xfns.c (x_window): Make sprintf buffer a bit bigger
7841 to avoid potential buffer overrun.
7842
ae58ff1f
PE
7843 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7844
c43c8a6a
PE
7845 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7846
3f8236f4
PE
78472011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7848
53e9fe90 7849 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7850 Without these, Emacs silently mishandles large integers sometimes.
7851 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7852 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7853
6511acf2
PE
7854 * xdisp.c (try_window_id): Check Emacs fixnum range before
7855 converting to 'int'.
806add1d 7856
6511acf2 7857 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7858 Check that an Emacs fixnum is in range before assigning it to 'int'.
7859 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7860 values converted from Emacs fixnums.
7861 (Frecenter): Don't wrap around a line count if it is out of 'int'
7862 range; instead, treat it as an extreme value.
7863 (Fset_window_configuration, compare_window_configurations):
7864 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7865
6511acf2
PE
7866 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7867 that can exceed INT_MAX. Check that EMACS_INT value is in range
7868 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7869 (match_limit): Don't assume that a fixnum can fit in 'int'.
7870
6511acf2 7871 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7872 exceed INT_MAX.
7873
6511acf2 7874 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7875 (Fvertical_motion): Don't wrap around LINES values that don't fit
7876 in 'int'. Instead, treat them as extreme values. This is good
7877 enough for windows, which can't have more than INT_MAX lines anyway.
7878
fcb901a7
LMI
78792011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7880
0f2f6b6d
LMI
7881 * Require libxml/parser.h to avoid compilation warning.
7882
fcb901a7
LMI
7883 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7884
7885 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7886 since this reportedly can destroy thread storage.
7887
6e20a0d4
CY
78882011-08-30 Chong Yidong <cyd@stupidchicken.com>
7889
7890 * syntax.c (find_defun_start): Update all cache variables if
7891 exiting early (Bug#9401).
7892
148ae00e
EZ
78932011-08-30 Eli Zaretskii <eliz@gnu.org>
7894
f6cfbd8f
EZ
7895 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7896
148ae00e
EZ
7897 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7898 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7899 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7900
7901 * term.c (tty_append_glyph): New function.
7902 (produce_stretch_glyph): Static function and its prototype deleted.
7903
a66cfb1c
SM
7904 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7905 Add prototypes.
148ae00e 7906
c4a07a4c
PE
79072011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7908
7909 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7910 when checking :margin (Bug#9390).
7911 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7912 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7913 so that the name doesn't mislead. All uses changed.
7914
6bc8cd65
JB
79152011-08-28 Johan Bockgård <bojohan@gnu.org>
7916
7917 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7918 set_tty_hooks.
7919
dca4927e
EZ
79202011-08-27 Eli Zaretskii <eliz@gnu.org>
7921
7922 * xdisp.c (move_it_to): Don't bail out early when reaching
7923 position beyond to_charpos, if we are scanning backwards.
7924 (move_it_vertically_backward): When DY == 0, make sure we get to
7925 the first character in the line after the newline.
7926
f2cad773
PE
79272011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7928
7929 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7930 (ccl_driver): Do not generate an out-of-range pointer.
7931 (Fccl_execute_on_string): Remove unnecessary check for
7932 integer overflow, noted by Stefan Monnier in
7933 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7934 Remove a FIXME that didn't need fixing.
7935 Simplify the newly-introduced buffer reallocation code.
7936
0cae2cdb
JB
79372011-08-27 Juanma Barranquero <lekktu@gmail.com>
7938
7939 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7940
5fc295a4 79412011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7942
70c60eb2 7943 Integer and memory overflow issues (Bug#9196).
726e0ab1 7944
d31850da
PE
7945 * doc.c (get_doc_string): Rework so that
7946 get_doc_string_buffer_size is the actual buffer size, rather than
7947 being 1 less than the actual buffer size; this makes xpalloc more
7948 convenient.
7949
a69fbedb
PE
7950 * image.c (x_allocate_bitmap_record, cache_image):
7951 * xselect.c (Fx_register_dnd_atom):
7952 Simplify previous changes by using xpalloc.
7953
fe5c5d37
PE
7954 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7955 since either will do and ptrdiff_t is convenient with xpalloc.
7956
0065d054
PE
7957 * charset.c (charset_table_size)
7958 (struct charset_sort_data.priority): Now ptrdiff_t.
7959 (charset_compare): Don't overflow if priorities differ greatly.
7960 (Fsort_charsets): Don't assume list length fits in int.
7961 Check for size-calculation overflow when allocating sort data.
7962 (syms_of_charset): Allocate an initial charset table that is
7963 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7964
7965 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7966
7967 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7968 The actual value is always <= INT_MAX, and leaving it unsigned made
7969 overflow checking harder.
7970
7971 * dispextern.h (struct glyph_matrix.rows_allocated)
7972 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7973 with xpalloc. The values are still always <= INT_MAX.
7974
7975 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7976
7977 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7978 (SAFE_NALLOCA): New macro.
7979
7980 * region-cache.c (struct boundary.pos, find_cache_boundary)
7981 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7982 (set_cache_region, invalidate_region_cache)
7983 (revalidate_region_cache, know_region_cache, region_cache_forward)
7984 (region_cache_backward, pp_cache):
7985 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7986 so that ptrdiff_t * can be passed to xpalloc.
7987 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7988 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7989 (pp_cache): Don't assume cache_len fits in int.
7990 * region-cache.h: Adjust extern decls to match.
7991
7992 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7993 EMACS_INT, since either will do, for xpalloc.
7994
7995 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7996 (xnmalloc, xnrealloc, xpalloc): New functions.
7997
726e0ab1
PE
7998 * bidi.c (bidi_shelve_header_size): New constant.
7999 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8000 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8001
51f30bc5 8002 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8003 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8004 (overlay_strings):
8005 Don't update size of array until after memory allocation succeeds,
8006 because xmalloc/xrealloc may not return.
0065d054
PE
8007 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8008 now that we have proper integer overflow checking.
8009 (record_overlay_string, overlay_strings): Catch overflows when
8010 calculating size of overlay_str_buf.
726e0ab1 8011
0065d054
PE
8012 * callproc.c (Fcall_process): Check for size overflow when
8013 calculating size of args2.
8014 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8015 Normally we prefer signed values, but sticking with ptrdiff_t would
8016 require adding more-complicated checks.
726e0ab1
PE
8017
8018 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8019 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8020 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8021 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8022
8023 * character.c (Fstring): Check for size-calculation overflow.
8024
8025 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8026 unnecessary integer overflow. Check for size overflow.
8027 (encode_coding_object): Don't update size until xmalloc succeeds.
8028
8029 * composite.c (get_composition_id): Check for overflow in glyph
8030 length calculations.
8031
8032 Integer and memory overflow fixes for display code.
8033 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8034 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8035 (scrolling_window): Check for overflow in size calculations.
8036 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8037 Don't assume glyph table len fits in int.
8038 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8039 (row_table_size): Now ptrdiff_t, not int.
8040 (scrolling_window): Avoid overflow in size calculations.
8041 Don't update size until allocation succeeds.
8042 * fns.c (concat): Check for overflow in size calculations.
8043 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8044 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8045 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8046
8047 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8048 (get_doc_string): Check for size calculation overflow.
8049 Don't update size until allocation succeeds.
8050 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8051 EMACS_INT, where ptrdiff_t will do.
8052 (Fsubstitute_command_keys): Check for string overflow.
8053
8054 * editfns.c (set_time_zone_rule): Don't assume environment length
8055 fits in int.
8056 (message_length): Now ptrdiff_t, not int.
8057 (Fmessage_box): Don't update size until allocation succeeds.
8058 Don't assume message length fits in int.
8059 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8060
0065d054
PE
8061 * emacs.c (main): Do not reallocate argv, since there is a null at
8062 the end that can be overwritten, and this way there's no need to
8063 worry about size-calculation overflow.
8064 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8065
8066 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8067 alloc succeeds.
8068 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8069
8070 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8071 (x_set_scroll_bar_width, x_figure_window_size):
8072 Check for integer overflow.
8073 (x_set_alpha): Do not assume XINT fits in int.
8074
8075 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8076 This is for the members text_lines, text_cols, total_lines, total_cols,
8077 where the system imposes an 'int' limit.
8078
8079 * fringe.c (Fdefine_fringe_bitmap):
8080 Don't update size until alloc works.
8081
8082 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8083 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8084
8085 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8086 Check for size-calculation overflow.
8087 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8088 do, as we prefer signed integers.
8089 (id_to_widget.max_size, id_to_widget.used)
8090 (xg_store_widget_in_map, xg_remove_widget_from_map)
8091 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8092 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8093 Use and return ptrdiff_t, not int.
8094 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8095 * gtkutil.h: Change prototypes to match the above.
8096
8097 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8098 are duplicate now that they've been promoted to lisp.h.
8099 (x_allocate_bitmap_record, x_alloc_image_color)
8100 (make_image_cache, cache_image, xpm_load):
8101 Don't update size until alloc is done.
8102 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8103 (x_detect_edges):
3256efce 8104 Check for size calculation overflow.
726e0ab1
PE
8105 (ct_colors_allocated_max): New constant.
8106 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8107 overflow.
3256efce 8108
726e0ab1
PE
8109 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8110 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8111 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8112 Use ptrdiff_t, not int, to count maps.
8113 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8114 calculations. Don't update size until allocation succeeds.
8115 Redo calculations to avoid overflow.
726e0ab1
PE
8116 * keyboard.h: Change prototypes to match the above.
8117
8118 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8119 to count maps.
8120 (current_minor_maps): Check for size calculation overflow.
8121 * keymap.h: Change prototypes to match the above.
8122
8123 * lread.c (read1, init_obarray): Don't update size until alloc done.
8124
8125 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8126 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8127
726e0ab1
PE
8128 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8129 Now ptrdiff_t, not int.
8130 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8131 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8132
8133 * process.c (Fnetwork_interface_list): Check for overflow
8134 in size calculation.
8135
8136 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8137
8138 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8139 overflow. Don't bother calling xmalloc when xrealloc will do.
8140
8141 * search.c (Freplace_match): Check for size calculation overflow.
8142 (Fset_match_data): Don't assume list lengths fit in 'int'.
8143
8144 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8145 for command line length. Do not attempt to address one before the
8146 beginning of an array, as that's not portable.
8147
8148 * term.c (max_frame_lines): Remove; unused.
8149 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8150 not int.
8151 (encode_terminal_code, calculate_costs): Check for size
8152 calculation overflow.
8153 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8154 table lengths and related sizes. Don't update size until alloc
8155 done. Redo calculations to avoid overflow.
8156 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8157
8158 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8159 subtracting pointers.
8160 (gobble_line): Check for overflow more carefully. Don't update size
8161 until alloc done.
8162
8163 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8164 Don't update size until alloc done.
8165 Redo size calculations to avoid overflow.
8166 Check for size calculation overflow.
0065d054 8167 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8168
8169 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8170 Use ptrdiff_t, not int, for sizes.
8171 (store_mode_line_noprop_char): Don't update size until alloc done.
8172
0065d054
PE
8173 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8174 Use ptrdiff_t, not int, for sizes.
8175 (Finternal_make_lisp_face, cache_face):
8176 Check for size calculation overflow.
8177 (cache_face): Treat size calculation overflows as if they were
8178 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8179
8180 * xfns.c (x_encode_text, x_set_name_internal)
8181 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8182 sizes, since they can exceed INT_MAX in size. Check for size
8183 calculation overflow.
8184
0065d054
PE
8185 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8186 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8187 Don't update size until alloc done.
8188
0065d054 8189 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8190 as sprintf is limited to int lengths.
1d526e2f 8191
252c5ee1
PE
8192 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8193 (X_LONG_MIN): New macros.
864d7ce7
PE
8194 Use them to make the following changes clearer.
8195 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8196 This change doesn't affect the value now, but it may help remind
8197 future maintainers not to raise the value too much later.
8198 (SELECTION_QUANTUM): Remove, replacing with ...
8199 (selection_quantum): ... new function, which avoids overflow.
8200 All uses changed.
8201 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8202 assumption that selection length fits in 'int'.
8203 (x_reply_selection_request, x_handle_selection_request)
8204 (x_get_window_property, receive_incremental_selection)
8205 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8206 (lisp_data_to_selection_data, clean_local_selection_data):
8207 Use ptrdiff_t, not int, to record length of selection.
8208 (x_reply_selection_request, x_get_window_property)
8209 (receive_incremental_selection, x_property_data_to_lisp):
8210 Redo calculations to avoid overflow.
8211 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8212 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8213 something.
8214 (x_get_window_property, receive_incremental_selection)
8215 (lisp_data_to_selection_data, x_property_data_to_lisp):
8216 Check for size-calculation overflow.
8217 (x_get_window_property, receive_incremental_selection)
8218 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8219 Don't store size until memory allocation succeeds.
8220 (x_get_window_property): Plug memory leak on memory exhaustion.
8221 Don't double-block input; malloc is safe here. Don't assume 2**34
8222 - 4 fits in unsigned long. Add an xassert to check
8223 XGetWindowProperty overflow. Be more careful about overflow
8224 calculations, and distinguish size from memory overflow better.
8225 (receive_incremental_selection): When tracing, don't assume
8226 unsigned int is less than INT_MAX.
8227 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8228 harmful) conversions of unsigned short to int.
8229 (lisp_data_to_selection_data): Don't assume that integers
8230 in the range -65535 through -1 fit in an X unsigned short.
8231 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8232 result parameters unless successful. Rely on cons_to_unsigned
8233 to report problems with elements; the old code wasn't right anyway.
8234 (x_check_property_data): Check for int overflow; we cannot use
8235 a wider type due to X limits.
8236 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8237
726e0ab1 8238 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8239
0065d054
PE
8240 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8241 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8242 (x_color_cells): Don't store size until memory allocation succeeds.
8243 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8244 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8245 (x_term_init): Don't assume length fits in int (sprintf is limited
8246 to int size).
bc18e09d 8247
ebfa62c0
PE
8248 Use ptrdiff_t for composition IDs.
8249 * character.c (lisp_string_width):
8250 * composite.c (composition_table_size, n_compositions)
8251 (get_composition_id, composition_gstring_from_id):
8252 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8253 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8254 * window.c (Frecenter):
8255 Use ptrdiff_t, not int, for composition IDs.
8256 * composite.c (get_composition_id): Check for integer overflow.
8257 * composite.h: Adjust prototypes to match the above changes.
8258
d3411f89
PE
8259 Use ptrdiff_t for hash table indexes.
8260 * category.c (hash_get_category_set):
8261 * ccl.c (ccl_driver):
8262 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8263 * coding.c (coding_system_charset_list, detect_coding_system):
8264 * coding.h (struct coding_system.id):
8265 * composite.c (get_composition_id, gstring_lookup_cache):
8266 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8267 * image.c (xpm_get_color_table_h):
8268 * lisp.h (hash_lookup, hash_put):
8269 * minibuf.c (Ftest_completion):
8270 Use ptrdiff_t for hash table indexes, not int (which is too
8271 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8272 32-bit --with-wide-int hosts).
8273
e097a6fa
PE
8274 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8275 Add a FIXME comment about memory leaks.
8276 (syms_of_charset): Don't assume xmalloc returns.
8277
5637687f
PE
8278 Don't assume that stated character widths fit in int.
8279 * character.c (Fchar_width, c_string_width, lisp_string_width):
8280 * character.h (CHAR_WIDTH):
8281 * indent.c (MULTIBYTE_BYTES_WIDTH):
8282 Use sanitize_char_width to avoid undefined and/or bad behavior
8283 with outlandish widths.
a66cfb1c 8284 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8285 now that we have two such functions. All uses changed.
8286 (sanitize_char_width): New inline function.
8287
a2271ba2
PE
8288 Don't assume that tab-width fits in int.
8289 * character.h (sanitize_width): New inline function.
8290 (SANE_TAB_WIDTH): New macro.
8291 (ASCII_CHAR_WIDTH): Use it.
8292 * indent.c (sane_tab_width): Remove. All uses replaced by
8293 SANE_TAB_WIDTH (current_buffer).
8294 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8295
18c52557
PE
8296 * fileio.c: Integer overflow issues with file modes.
8297 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8298
caeeedc1
PE
8299 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8300 Remove unreachable code.
8301 (read_hex, load_charset_map_from_file): Check for integer overflow.
8302
6df6ae42 8303 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8304 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8305 (x_send_scroll_bar_event): Likewise. Check that the size does not
8306 exceed limits imposed by XClientMessageEvent, as well as the usual
8307 ptrdiff_t and size_t limits.
8308
b13995db
PE
8309 * keyboard.c: Overflow, signedness and related fixes.
8310 (make_lispy_movement): Use same integer type in forward decl
8311 that is used in the definition.
8312 (read_key_sequence, keyremap_step):
8313 Change bufsize argument back to int, undoing my 2011-03-30 change.
8314 We prefer signed types, and int is wide enough here.
8315 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8316 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8317 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8318 length, not size_t. Use ptrdiff_t for index, not int.
8319 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8320 possibility of integer overflow.
8321
13464394
PE
8322 Overflow, signedness and related fixes for images.
8323
8324 * dispextern.h (struct it.stack[0].u.image.image_id)
8325 (struct_it.image_id, struct image.id, struct image_cache.size)
8326 (struct image_cache.used, struct image_cache.ref_count):
8327 * gtkutil.c (update_frame_tool_bar):
8328 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8329 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8330 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8331 * nsmenu.m (update_frame_tool_bar):
8332 * xdisp.c (calc_pixel_width_or_height):
8333 * xfns.c (image_cache_refcount):
8334 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8335 on typical 64-bit hosts.
8336
8337 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8338 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8339 Omit unnecessary casts to int.
8340 (parse_image_spec): Check that integers fall into 'int' range
8341 when the callers expect that.
8342 (image_ascent): Redo ascent calculation to avoid int overflow.
8343 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8344 (lookup_image): Remove unnecessary tests.
8345 (xbm_image_p): Locals are now of int, not EMACS_INT,
8346 since parse_image_check makes sure they fit into int.
8347 (png_load, gif_load, svg_load_image):
8348 Prefer int to unsigned where either will do.
8349 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8350 old tiff_error_handler and tiff_warning_handler.
8351 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8352 stack buffer overflows. It uses only the features of vsnprintf
8353 that are common to both POSIX and native Microsoft.
8354 (tiff_error_handler, tiff_warning_handler): Use it.
8355 (tiff_load, gif_load, imagemagick_load_image):
8356 Don't assume :index value fits in 'int'.
8357 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8358 (imagemagick_load_image): Check that crop parameters fit into
8359 the integer types that MagickCropImage accepts. Don't assume
8360 Vimagemagick_render_type has a nonnegative value. Don't assume
8361 size_t fits in 'long'.
8362 (gs_load): Use printmax_t to print the widest integers possible.
8363 Check for integer overflow when computing image height and width.
8364
c11821d4
EZ
83652011-08-26 Eli Zaretskii <eliz@gnu.org>
8366
8367 * xdisp.c (redisplay_window): Don't force window start if point
8368 will be invisible in the resulting window. (Bug#9324)
8369
0c95fcf7
EZ
83702011-08-25 Eli Zaretskii <eliz@gnu.org>
8371
8372 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8373 the display spec is of the form `(space ...)'.
8374 (handle_display_spec): Return the value returned by
8375 handle_single_display_spec, not just 1 or zero.
8376 (handle_single_display_spec): If the display spec is of the form
8377 `(space ...)', and specifies display in the text area, return 2
8378 rather than 1.
fee65a97 8379 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8380 accurately, and prefer exact match for point under bidi.
8381 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8382
8383 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8384 into disp_prop; all users changed.
8385
8386 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8387 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8388 for the text covered by the display property.
8389
e4ed06f1
CY
83902011-08-25 Chong Yidong <cyd@stupidchicken.com>
8391
8392 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8393 Change return value to nil.
8394 (Frecord_buffer): Delete unused function.
8395
f67cdd7f
EZ
83962011-08-24 Eli Zaretskii <eliz@gnu.org>
8397
5980d4c6
EZ
8398 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8399 buffers, return left-to-right.
8610fe8b
EZ
8400 (set_cursor_from_row): Consider candidate row a win if its glyph
8401 represents a newline and point is on that newline. Fixes cursor
8402 positioning on the newline at EOL of R2L text within L2R
8403 paragraph, and vice versa.
8404 (try_cursor_movement): Check continued rows, in addition to
8405 continuation rows. Fixes unwarranted scroll when point enters a
8406 continued line of R2L text within an L2R paragraph, or vice versa.
8407 (cursor_row_p): Consider the case of point being equal to
8408 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8409 from the end of a short line to the beginning of a continued line
8410 of R2L text within L2R paragraph.
8411 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8412 composed characters.
5980d4c6 8413
f67cdd7f
EZ
8414 * bidi.c (bidi_check_type): Use xassert.
8415 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8416 members.
8417
bca633fb
EZ
84182011-08-23 Eli Zaretskii <eliz@gnu.org>
8419
8420 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8421 a character.
8422
4a5885a7
CY
84232011-08-23 Chong Yidong <cyd@stupidchicken.com>
8424
8425 * nsfont.m (ns_otf_to_script): Fix typo.
8426
0902a04e
KH
84272011-08-22 Kenichi Handa <handa@m17n.org>
8428
8429 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8430 extra slot even if the purpose is char-code-property-table.
8431
1a2e6670
EZ
84322011-08-23 Eli Zaretskii <eliz@gnu.org>
8433
8ddde651
EZ
8434 * xdisp.c (redisplay_window): When computing centering_position,
8435 account for the height of the header line. (Bug#8874)
8436
425cc014
EZ
8437 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8438 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8439 candidate is selected by the mouse, and that candidate has a
8440 composed character under the mouse.
8441
1a2e6670
EZ
8442 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8443 coordinates reported by pos-visible-in-window-p for a composed
8444 character in column zero.
8445
8b76d6f8
SM
84462011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8447
8448 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8449
dac347dd
EZ
84502011-08-22 Eli Zaretskii <eliz@gnu.org>
8451
8452 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8453 consider it a hit if to_charpos is anywhere in the range of the
8454 composed buffer positions.
8455
e013fb34
CY
84562011-08-22 Chong Yidong <cyd@stupidchicken.com>
8457
8458 * image.c (gif_load): Don't assume that each subimage has the same
8459 dimensions as the base image. Handle disposal method that is
8460 "undefined" by the gif spec (Bug#9335).
8461
bd1ba3e8
CY
84622011-08-20 Chong Yidong <cyd@stupidchicken.com>
8463
8464 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8465 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8466
54a1215b
EZ
84672011-08-19 Eli Zaretskii <eliz@gnu.org>
8468
823564e5
EZ
8469 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8470 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8471 from an Org mode buffer to a Speedbar frame.
8472
54a1215b
EZ
8473 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8474 a composition, take its buffer position from IT->cmp_it.charpos.
8475 Fixes cursor positioning at the beginning of a line that begins
8476 with a composed character.
8477
9778ebcc
EZ
84782011-08-18 Eli Zaretskii <eliz@gnu.org>
8479
0be6ee06
EZ
8480 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8481 character bidirectional type, use STRONG_L instead. Fixes crashes
8482 in a buffer produced by `describe-categories'.
8483
9778ebcc
EZ
8484 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8485 members before the level stack, so they would be saved and
8486 restored when copying iterator state. Fixes incorrect reordering
8487 around TABs covered by display properties.
8488
156bffbe
AS
84892011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8490
6b02f655 8491 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8492
72ad093b
CY
84932011-08-17 Chong Yidong <cyd@stupidchicken.com>
8494
8495 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8496 (internal_condition_case_2, internal_condition_case_n):
8497 Remove unnecessary aborts (Bug#9081).
72ad093b 8498
35774242
EZ
84992011-08-17 Eli Zaretskii <eliz@gnu.org>
8500
8501 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8502 has no `load' handler, try opening the file locally. (Bug#9311)
8503
db76dd85
KB
85042011-08-16 Ken Brown <kbrown@cornell.edu>
8505
8506 * gmalloc.c: Expand comment.
8507
b215eee5
EZ
85082011-08-16 Eli Zaretskii <eliz@gnu.org>
8509
8510 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8511 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8512
a4579d33
KB
85132011-08-16 Ken Brown <kbrown@cornell.edu>
8514
8515 Fix memory allocation problems in Cygwin build (Bug#9273).
8516
8517 * unexcw.c ( __malloc_initialized): Declare external variable.
8518 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8519
8b76d6f8
SM
8520 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8521 New variables.
a4579d33
KB
8522 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8523 dumped emacs.
8524 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8525 in the static heap.
8526 [CYGWIN] (special_realloc): New function.
8527 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8528 requests to realloc storage in the static heap.
8529
3ebec551
PE
85302011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8531
8532 * bidi.c (bidi_initialize): Remove unused local.
8533
9fd8be00
EZ
85342011-08-15 Eli Zaretskii <eliz@gnu.org>
8535
6b02f655
SM
8536 * bidimirror.h:
8537 * biditype.h: Remove file.
8538 * makefile.w32-in ($(BLD)/bidi.$(O)):
8539 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8540
8541 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8542
8543 * chartab.c: Improve commentary for the uniprop_table API.
8544
32413314
EZ
8545 * bidi.c (bidi_paragraph_init): Support zero value of
8546 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8547 (bidi_initialize): Use uniprop_table instead of including
8548 biditype.h and bidimirror.h.
32413314 8549
9fd8be00
EZ
8550 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8551 coordinates of the iterator when restoring from ppos_it.
8552 (Bug#9296)
8553
5cf2b69b
KH
85542011-08-14 Kenichi Handa <handa@m17n.org>
8555
8556 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8557 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8558
daf17d00
EZ
85592011-08-14 Eli Zaretskii <eliz@gnu.org>
8560
8561 * xdisp.c (move_it_in_display_line_to): Don't invoke
8562 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8563 ppos_it. Fixes vertical cursor motion when line beginning is
8564 covered by an image. (Bug#9296)
8565
08e3161a
JD
85662011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8567
8568 * nsterm.h (ns_run_ascript): Declare.
8569 (NSAPP_DATA2_RUNASSCRIPT): Define.
8570
8571 * nsfns.m (as_script, as_result, as_status): New static variables.
8572 (ns_run_ascript): New function.
5e617bc2 8573 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8574 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8575 the event loop. Get status from as_status (Bug#7276).
8576
8577 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8578 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8579 the event loop (Bug#7276).
8580
a3720aa2
AS
85812011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8582
8583 * gnutls.c (QCgnutls_bootprop_priority)
8584 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8585 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8586 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8587 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8588 (QCgnutls_bootprop_verify_hostname_error)
8589 (QCgnutls_bootprop_callbacks_verify): Rename from
8590 Qgnutls_bootprop_..., all uses changed.
8591
8592 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8593 uses changed.
8594
0a0d27fb
PE
85952011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8596
19d5c50c
PE
8597 * xfaces.c (Qframe_set_background_mode): Now static.
8598 * dispextern.h (Qframe_set_background_mode): Remove decl.
8599
0a0d27fb
PE
8600 * process.c (Fnetwork_interface_info): Declare local only if needed.
8601
377538cb
JD
86022011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8603
8604 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8605 (Fnetwork_interface_list): Allocate in increments of bytes instead
8606 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8607 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8608 sockaddr.
8609 (struct ifflag_def): notrailers is smart on OSX.
8610 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8611 Get hardware address with getifaddrs if available.
8612
08fff70c
EZ
86132011-08-12 Eli Zaretskii <eliz@gnu.org>
8614
8615 * xdisp.c (iterate_out_of_display_property): xassert that
8616 IT->position is set to within IT->object's boundaries. Break from
8617 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8618 when IT->position is set up wrongly due to some bug.
8619 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8620 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8621 entry. Force push_it to save on the stack the current
8622 buffer/string position, to be restored by pop_it. Fix flags in
8623 the iterator structure wrt the object coming from a display
8624 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8625 properties. (Bug#9284)
8626
7be1c708 86272011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8628
7be1c708
CY
8629 * fontset.c (fontset_get_font_group): Add proper type checks.
8630 (Bug#9172)
aac0c6e3 8631
7be1c708 86322011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8633
7be1c708
CY
8634 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8635 and LC_VERSION_MIN_MACOSX.
8636 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8637 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8638
97bb72a6
EZ
86392011-08-08 Eli Zaretskii <eliz@gnu.org>
8640
8641 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8642 no-display-properties-and-no-overlays under bidi display.
8643 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8644 properties and overlays.
97bb72a6 8645
d5617611
CY
86462011-08-08 Chong Yidong <cyd@stupidchicken.com>
8647
37e11a63
CY
8648 * editfns.c (Fset_time_zone_rule): Document relationship with the
8649 setenv function.
8650
d5617611
CY
8651 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8652 the font entity extracted from the cache (Bug#8109).
8653
58872834
CY
86542011-08-07 Chong Yidong <cyd@stupidchicken.com>
8655
8656 * composite.c (autocmp_chars): Don't reset point. That is done by
8657 restore_point_unwind (Bug#5984).
8658
75bfc667
JL
86592011-08-07 Juri Linkov <juri@jurta.org>
8660
8661 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8662 to show the arg `TIME' instead of `TIMEVAL'.
8663
d1410150
EZ
86642011-08-06 Eli Zaretskii <eliz@gnu.org>
8665
8666 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8667 display property strides EOL and includes a newline, as in
8668 longlines-mode. (Bug#9254)
75b771e4
EZ
8669 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8670 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8671
8672 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8673 is non-zero, even if the data buffer is NULL. Fixes a crash in
8674 vertical-motion with longlines-mode. (Bug#9254)
8675
35928349
EZ
86762011-08-05 Eli Zaretskii <eliz@gnu.org>
8677
ec7cc85b
EZ
8678 * bidi.c <bidi_cache_total_alloc>: Now static.
8679 (bidi_initialize): Initialize bidi_cache_total_alloc.
8680
8b76d6f8 8681 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8682 cache. (Bug#9221)
8683
8684 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8685 amount allocated this far in `bidi_cache_total_alloc'.
8686 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8687 non-zero, only free the data buffer without restoring the cache
8688 contents. All callers changed.
8689
8690 * dispextern.h (bidi_unshelve_cache): Update prototype.
8691
8692 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8693 (move_it_in_display_line, move_it_to)
8694 (move_it_vertically_backward, move_it_by_lines): Replace the call
8695 to xfree to an equivalent call to bidi_unshelve_cache.
8696 (move_it_in_display_line_to): Fix logic of returning
412b6358 8697 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8698
e2e2423b
EZ
86992011-08-05 Eli Zaretskii <eliz@gnu.org>
8700
8701 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8702 came from a string character with a `cursor' property. (Bug#9229)
8703
ae9e757a
JD
87042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8705
8706 * Makefile.in (LIB_PTHREAD): New variable.
8707 (LIBES): Add LIB_PTHREAD (Bug#9216).
8708
8709 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8710 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8711
213bd7f2
AS
87122011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8713
6b02f655 8714 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8715
99aaf75f
JD
87162011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8717
8718 * xterm.c (x_find_topmost_parent): New function.
8719 (x_set_frame_alpha): Find topmost parent window with
8720 x_find_topmost_parent and set the property there also (bug#9181).
8721 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8722
c74e9d86
PE
87232011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8724
8725 * callproc.c (Fcall_process): Avoid vfork clobbering
8726 the local vars buffer, coding_systems, current_dir.
8727
640c8776
SM
87282011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8729
8730 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8731
f26d0e4c
PE
87322011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8733
8a10d76c
PE
8734 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8735 so that it is not optimized away.
8736
f26d0e4c
PE
8737 * xdisp.c (compute_display_string_pos): Remove unused local.
8738
55439c61
EZ
87392011-08-02 Eli Zaretskii <eliz@gnu.org>
8740
8741 Fix slow cursor motion and scrolling in large buffers with
8742 selective display, like Org Mode buffers. (Bug#9218)
8743
8744 * dispextern.h (struct bidi_it): New member disp_prop_p.
8745
8746 * xdisp.c: Remove one-slot cache of display string positions.
8747 (compute_display_string_pos): Accept an additional argument
5e617bc2 8748 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8749 for a display string or property. If found, set DISP_PROP_P
8750 non-zero.
8751
8752 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8753 DISP_PROP_P, and pass it to compute_display_string_pos.
8754 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8755 non-zero. All callers of bidi_fetch_char changed.
8756
fb33fa43
SM
87572011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8758
8759 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8760
b099e063
DM
87612010-12-03 Don March <don@ohspite.net>
8762
8763 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8764 last character M-[char] is translated to ESC [char] (bug#7541).
8765
5cc7f7af
KH
87662011-08-02 Kenichi Handa <handa@m17n.org>
8767
d0fffa3f 8768 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8769
8770 * chartab.c (uniprop_table): Make it non-static.
8771
525d5e6e
EZ
87722011-08-01 Eli Zaretskii <eliz@gnu.org>
8773
8774 * xdisp.c (forward_to_next_line_start): Accept additional argument
8775 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8776 on the newline.
8777 (reseat_at_next_visible_line_start): Use the bidi iterator state
8778 returned by forward_to_next_line_start to restore the state of
8779 it->bidi_it after backing up to previous newline. (Bug#9212)
8780
31011111
AS
87812011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8782
8783 * regex.c (re_comp): Protoize.
8784 (re_exec): Fix return type.
8785 (regexec): Fix type of `ret'. (Bug#9203)
8786
476371c4
PE
87872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8788
e5d76069
PE
8789 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8790 This is needed if max-image-size is a floating-point number.
8791
9a79b20c
AS
87922011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8793
8794 * print.c (print_object): Print empty symbol as ##.
8795
8796 * lread.c (read1): Read ## as empty symbol.
8797
d8c2fa78
AA
87982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8799
8800 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8801 setting frame foreground color (Bug#9175).
8802 (x_set_background_color): Likewise.
8803
ffe57a7a
AA
8804 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8805 contents (Bug#9176).
8806 (EmacsTooltip -init): Remove bezels and add shadows to
8807 tooltip windows.
8808
bf3492a5
AA
8809 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8810 or scroll bar (Bug#8470).
8811
d55e9c53
AA
8812 * nsfont.m (nsfont_open): Remove assignment to voffset and
8813 unnecessary vars hshink, expand, hd, full_height, min_height.
8814 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8815
8816 * nsterm.h (nsfont_info): Remove voffset field.
8817
d8c2fa78 88182011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8819
8820 Implement strike-through and overline on NextStep (Bug#8863).
8821
8822 * nsfont.m (nsfont_open): Use underline position provided by font,
8823 instead of hard-coded value of 2.
8824 (nsfont_draw): Call ns_draw_text_decoration instead.
8825
8826 * nsterm.h: Add declaration for ns_draw_text_decoration.
8827
8828 * nsterm.m (ns_draw_text_decoration): New function for drawing
8829 underline, overline, and strike-through.
8830 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8831 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8832 accommodate underlining, etc.
4843aac3 8833
4cc60b9b
EZ
88342011-07-28 Eli Zaretskii <eliz@gnu.org>
8835
bc7ece87
EZ
8836 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8837 default.
4cc60b9b 8838
476371c4
PE
88392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8840
66606eea
PE
8841 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8842 Without this fix, if a signal arrives just after memory fills up,
8843 'malloc' might be invoked reentrantly.
8844
476371c4
PE
8845 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8846 In other words, assume that every image size is allowed, on non-X
8847 hosts. This assumption is probably wrong, but it lets Emacs compile.
8848
f3fcc40d
AS
88492011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8850
8851 * regex.c (re_iswctype): Convert return values to boolean.
8852
350c992f
EZ
88532011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8854
8855 * xdisp.c (compute_display_string_pos): Don't use cached display
8856 string position if the buffer had its restriction changed.
8857 (Bug#9184)
8858
5266b4bb
PE
88592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8860
8861 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8862
2573a837 88632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8864
41f55ccd 8865 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8866
39e378da
PE
8867 * bidi.c: Integer size and overflow fixes.
8868 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8869 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8870 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8871 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8872 (bidi_find_other_level_edge):
8873 Use ptrdiff_t instead of EMACS_INT where either will do.
8874 This works better on 32-bit hosts configured --with-wide-int.
8875 (bidi_cache_ensure_space): Check for size-calculation overflow.
8876 Use % rather than repeated addition, for better worst-case speed.
8877 Don't set bidi_cache_size until after xrealloc returns, because it
8878 might not return.
8879 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8880 (bidi_cache_ensure_space): Also check that the bidi cache size
8881 does not exceed that of the largest Lisp string or buffer. See Eli
8882 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8883
5e927815
PE
8884 * alloc.c (__malloc_size_t): Remove.
8885 All uses replaced by size_t. See Andreas Schwab's note
8886 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8887
ca4aa935
PE
8888 * image.c: Improve checking for integer overflow.
8889 (check_image_size): Assume that f is nonnull, since
8890 it is always nonnull in practice. This is one less thing to
8891 worry about when checking for integer overflow later.
8892 (x_check_image_size): New function, which checks for integer
8893 overflow issues inside X.
8894 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8895 This removes the need for a memory_full check.
8896 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8897 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8898 (xbm_read_bitmap_data): Change locals back to 'int', since
8899 their values must fit in 'int'.
8900 (xpm_load_image, png_load, tiff_load):
8901 Invoke x_create_x_image_and_pixmap earlier,
8902 to avoid much needless work if the image is too large.
8903 (tiff_load): Treat overly large images as if
8904 x_create_x_image_and_pixmap failed, not as malloc failures.
8905 (gs_load): Use x_check_image_size.
8906
5f8f9cc2
PE
8907 * gtkutil.c: Omit integer casts.
8908 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8909 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8910
5adf60bc
PE
8911 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8912
c8907a93
PE
8913 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8914 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8915 would wrongly return t on a 64-bit host.
8916
e3c25c68
PE
8917 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8918 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8919 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8920 and therefore cause GCC to emit a bogus diagnostic in some cases.
8921
3f791afe
PE
8922 * image.c: Integer signedness and overflow and related fixes.
8923 This is not an exhaustive set of fixes, but it's time to
8924 record what I've got.
8925 (lookup_pixel_color, check_image_size): Remove redundant decls.
8926 (check_image_size): Don't assume that arbitrary EMACS_INT values
8927 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8928 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8929 (tiff_load, imagemagick_load_image):
8930 Check for overflow in size calculations.
8931 (x_create_x_image_and_pixmap): Remove unnecessary test for
8932 xmalloc returning NULL; that can't happen.
8933 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8934 (xpm_color_bucket): Use better integer hashing function.
8935 (xpm_cache_color): Don't possibly over-allocate memory.
8936 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8937 (gif_memory_source):
8938 Use ptrdiff_t, not int or size_t, to record sizes.
8939 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8940 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8941 either works, as we prefer signed integers.
8942 (tiff_read_from_memory, tiff_write_from_memory):
8943 Return tsize_t, not size_t, since that's what the TIFF API wants.
8944 (tiff_read_from_memory): Don't fail simply because the read would
8945 go past EOF; instead, return a short read.
8946 (tiff_load): Omit no-longer-needed casts.
8947 (Fimagemagick_types): Don't assume size fits into 'int'.
8948
3cc5a532
PE
8949 Improve hashing quality when configured --with-wide-int.
8950 * fns.c (hash_string): New function, taken from sxhash_string.
8951 Do not discard information about ASCII character case; this
8952 discarding is no longer needed.
8953 (sxhash-string): Use it. Change sig to match it. Caller changed.
8954 * lisp.h: Declare it.
8955 * lread.c (hash_string): Remove, since we now use fns.c's version.
8956 The fns.c version returns a wider integer if --with-wide-int is
8957 specified, so this should help the quality of the hashing a bit.
8958
b312a492
PE
8959 * emacs.c: Integer overflow minor fix.
8960 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8961 Define only if GNU_LINUX.
8962 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8963
dfd153ae
PE
8964 * dispnew.c: Integer signedness and overflow fixes.
8965 Remove unnecessary forward decls, that were a maintenance hassle.
8966 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8967 All uses changed.
8968 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8969 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8970 (prepare_desired_row, line_draw_cost):
8971 Use int, not unsigned, where either works.
8972 (save_current_matrix, restore_current_matrix):
8973 Use ptrdiff_t, not size_t, where either works.
8974 (init_display): Check for overflow more accurately, and without
8975 relying on undefined behavior.
8976
a81d11a3
PE
8977 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8978 Remove, replacing with the new symbols in lisp.h. All uses changed.
8979 * fileio.c (make_temp_name):
8980 * filelock.c (lock_file_1, lock_file):
8981 * xdisp.c (message_dolog):
8982 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8983 Use pMd etc. instead.
8984 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8985 replacing the pWIDE etc. symbols removed from editfns.c.
8986
3300e6fd
PE
8987 * keyboard.h (num_input_events): Now uintmax_t.
8988 This is (very slightly) less likely to mess up due to wraparound.
8989 All uses changed.
8990
fd05c7e9
PE
8991 * buffer.c: Integer signedness fixes.
8992 (alloc_buffer_text, enlarge_buffer_text):
8993 Use ptrdiff_t rather than size_t when either will do, as we prefer
8994 signed integers.
8995
903fe15d
PE
8996 * alloc.c: Integer signedness and overflow fixes.
8997 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8998 (__malloc_size_t): Default to size_t, not to int.
8999 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9000 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9001 Prefer ptrdiff_t to size_t when either would do, as we prefer
9002 signed integers.
9003 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9004 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9005 Now const. Initialize with values that are in range even if char
9006 is signed.
9007 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9008 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9009 These functions do the right thing with sizes > 2**32.
9010 (check_depth): Now ptrdiff_t, not int.
9011 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9012 Adjust to new way of storing sizes. Check for size overflow bugs
9013 in rest of code.
9014 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9015 slightly wrong anyway, as it missed one instance of
9016 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9017 (refill_memory_reserve): Omit needless cast to size_t.
9018 (mark_object_loop_halt): Mark as externally visible.
9019
ac82cc6a
PE
9020 * xselect.c: Integer signedness and overflow fixes.
9021 (Fx_register_dnd_atom, x_handle_dnd_message):
9022 Use ptrdiff_t, not size_t, since we prefer signed.
9023 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9024 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9025 x_dnd_atoms_size and x_dnd_atoms_length.
9026
c2d1e36d
PE
9027 * doprnt.c: Prefer signed to unsigned when either works.
9028 * eval.c (verror):
9029 * doprnt.c (doprnt):
9030 * lisp.h (doprnt):
9031 * xdisp.c (vmessage):
9032 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9033 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9034 prefer signed arithmetic to avoid comparison confusion.
9035 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9036 but is a bit tricky.
9037
0e926e56
PE
9038 Assume freestanding C89 headers, string.h, stdlib.h.
9039 * data.c, doprnt.c, floatfns.c, print.c:
9040 Include float.h unconditionally.
9041 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9042 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9043 * regex.c: Likewise for stddef.h, string.h.
9044 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9045 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9046 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9047 (STDC_HEADERS): Remove obsolete defines.
9048 * sysdep.c: Include limits.h unconditionally.
9049
9cfdb3ec
PE
9050 Assume support for memcmp, memcpy, memmove, memset.
9051 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9052 * regex.c (memcmp, memcpy):
9053 Remove; we assume C89 now.
9054
9055 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9056 (__malloc_safe_bcopy): Remove; no longer needed.
9057
cf950e6b 9058 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9059 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9060 well either way, and we prefer signed to unsigned.
9061
dbf38e02
LMI
90622011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9063
9064 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9065 closes the connection while we're reading (bug#9182).
9066
d6f0886c 90672011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9068
d6f0886c
JD
9069 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9070 are specified (Bug#9168).
24e0f6b1 9071
2eb1f9e6
PE
90722011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9073
9074 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9075 Found by GCC static checking and --with-wide-int on a 32-bit host.
9076
22381272 90772011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9078
9079 * xdisp.c (compute_display_string_pos): Fix logic of caching
9080 previous display string position. Initialize cached_prev_pos to
9081 -1. Fixes slow-down at the beginning of a buffer.
9082
f25e39b4
EZ
90832011-07-24 Eli Zaretskii <eliz@gnu.org>
9084
9085 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9086 for attrs[LFACE_FONTSET_INDEX].
9087
04c4b52e
PE
90882011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9089
9090 * xml.c (parse_region): Remove unused local
9091 that was recently introduced.
9092
c1734fbd
EZ
90932011-07-23 Eli Zaretskii <eliz@gnu.org>
9094
be18c5a5
EZ
9095 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9096 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9097
c1734fbd
EZ
9098 * xdisp.c (move_it_in_display_line_to): Record the best matching
9099 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9100 exit if none of the characters scanned was an exact match.
9101 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9102 when exact match is impossible due to invisible text, and the
9103 lines are truncated.
9104
a258d627
JD
91052011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9106
9107 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9108 for OSX >= 10.7.
9109
b6d5a689
EZ
91102011-07-22 Eli Zaretskii <eliz@gnu.org>
9111
0f74f785
EZ
9112 Fix a significant slow-down of cursor motion with C-n, C-p,
9113 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9114 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9115 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9116 (next_element_from_buffer): Call compute_stop_pos_backwards to
9117 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9118 base_level_stop.
9119 (reseat): Don't look for prev_stop, as that could mean a very long
9120 run.
9121 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9122 <cached_disp_overlay_modiff>: Cache for last found display string
9123 position.
551918c1 9124 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9125 about the same buffer in the same area of character positions, and
9126 the buffer wasn't changed since the time the display string
9127 position was cached.
551918c1 9128
b2d0c91a
EZ
91292011-07-22 Eli Zaretskii <eliz@gnu.org>
9130
9131 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9132 is an integer, which is important for empty lines. (Bug#9149)
9133
043604ee
CY
91342011-07-22 Chong Yidong <cyd@stupidchicken.com>
9135
9136 * frame.c (Fmodify_frame_parameters): In tty case, update the
9137 default face if necessary (Bug#4238).
9138
da4adb04
CY
91392011-07-21 Chong Yidong <cyd@stupidchicken.com>
9140
9141 * editfns.c (Fstring_to_char): No need to explain what a character
9142 is in the docstring (Bug#6576).
9143
9abd0532
LMI
91442011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9145
9146 * xml.c (parse_region): Make sure we always return a tree.
9147
36881d16
HK
91482011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9149
9150 * xml.c (parse_region): If a document contains only comments,
9151 return that, too.
9152
1e98674d
LMI
91532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9154
9155 * xml.c (make_dom): Return comments, too.
9156
590bd467
PE
91572011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9158
9159 Port to OpenBSD.
9160 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9161 and the surrounding thread.
9162 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9163 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9164 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9165 timer goes off.
9166 * s/openbsd.h (BROKEN_SIGIO): Define.
9167 * unexelf.c (unexec) [__OpenBSD__]:
9168 Don't update the .mdebug section of the Alpha COFF symbol table.
9169
f41628b2
LMI
91702011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9171
9172 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9173 (bug#8460).
9174
b59b67c5
PE
91752011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9176
15e3a074
PE
9177 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9178 This fixes some race conditions on the permissions of any newly
9179 created file.
9180
41bed37d
PE
9181 * alloc.c (valid_pointer_p): Use pipe, not open.
9182 This fixes some permissions issues when debugging.
9183
b59b67c5
PE
9184 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9185 If fchown fails to set both uid and gid, try to set just gid,
9186 as that is sometimes allowed. Adjust the file's mode to eliminate
9187 setuid or setgid bits that are inappropriate if fchown fails.
9188
925a6be7
SM
91892011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9190
9191 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9192 to compare Lisp_Objects.
9193 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9194 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9195 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9196
52968808
AS
91972011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9198
0a6a104b
AS
9199 * lread.c (read_integer): Unread even EOF character.
9200 (read1): Likewise. Properly record start position of symbol.
9201
52968808
AS
9202 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9203 symbol character follows.
9204
9e381cdd
PE
92052011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9206
9207 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9208 This works around a problem with the previous change to Fcopy_file.
9209 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9210 and without this change, GCC might complain about discarding
9211 fchown's return value.
9212
b5641435
JB
92132011-07-16 Juanma Barranquero <lekktu@gmail.com>
9214
9215 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9216
a8031457
PE
92172011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9218
9219 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9220
dd889327
LMI
92212011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9222
750c33f7
LMI
9223 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9224 it's used from the C level.
9225
dd889327
LMI
9226 * process.c: Use the same condition for POLL_FOR_INPUT in both
9227 keyboard.c and process.c (bug#1858).
9228
87e86684
LM
92292011-07-09 Lawrence Mitchell <wence@gmx.li>
9230
9231 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9232 (Fgnutls_boot): Use it.
9233
64348f40
AS
92342011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9235
9236 * doc.c (Fsubstitute_command_keys): Revert last change.
9237
1d698799
LMI
92382011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9239
f863868c
LMI
9240 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9241 quotes the next character, and doesn't affect other longer
9242 sequences (bug#8935).
9243
1d698799
LMI
9244 * lread.c (syms_of_lread): Clarify that is isn't only
9245 `eval-buffer' and `eval-defun' that's affected by
9246 `lexical-binding' (bug#8460).
9247
aa4b6df6
EZ
92482011-07-15 Eli Zaretskii <eliz@gnu.org>
9249
9250 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9251 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9252
5d856da6
PE
92532011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9254
ad6042bb
PE
9255 Fix minor problems found by static checking.
9256 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9257 (elsz): Now a signed constant, not a size_t var. We prefer signed
9258 types to unsigned, to avoid integer comparison confusion. Without
9259 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9260 "cannot optimize loop, the loop counter may overflow", a symptom
9261 of the confusion.
f00bbb22 9262 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9263 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9264
6468f31c
LMI
92652011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9266
49080b10
LMI
9267 * search.c (Fre_search_backward): Mention `case-fold-search' in
9268 all the re_search_* functions (bug#8138).
9269
6468f31c
LMI
9270 * keyboard.c (Fopen_dribble_file): Document when the file is
9271 closed (bug#8056).
9272
c965adc5
EZ
92732011-07-14 Eli Zaretskii <eliz@gnu.org>
9274
df9733bf
EZ
9275 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9276 bidi_cache_idx.
9277
0bb23927
EZ
9278 Support bidi reordering of display and overlay strings.
9279 * xdisp.c (compute_display_string_pos)
9280 (compute_display_string_end): Accept additional argument STRING.
9281 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9282 (reseat_to_string): Initialize bidi_it->string.s and
9283 bidi_it->string.schars.
9284 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9285 NULL (avoids a crash in bidi_paragraph_init).
9286 Initialize itb.string.lstring.
0bb23927
EZ
9287 (init_iterator): Call bidi_init_it only of a valid
9288 buffer position was specified. Initialize paragraph_embedding to
9289 L2R.
9290 (reseat_to_string): Initialize the bidi iterator.
9291 (display_string): If we need to ignore text properties of
9292 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9293 original value of -1 will not work with bidi.)
9294 (compute_display_string_pos): First arg is now struct
9295 `text_pos *'; all callers changed. Support display properties on
9296 Lisp strings.
9297 (compute_display_string_end): Support display properties on Lisp
9298 strings.
9299 (init_iterator, reseat_1, reseat_to_string): Initialize the
9300 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9301 when iterating on a string not from display properties).
640c8776
SM
9302 (compute_display_string_pos, compute_display_string_end):
9303 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9304 arrow keys.
9305 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9306 base_level_stop; instead, set base_level_stop to BEGV.
9307 Fixes crashes in vertical-motion.
0bb23927
EZ
9308 (next_element_from_buffer): Improve commentary for when
9309 the iterator is before prev_stop.
9310 (init_iterator): Initialize bidi_p from the default value of
9311 bidi-display-reordering, not from buffer-local value. Use the
9312 buffer-local value only if initializing for buffer iteration.
9313 (handle_invisible_prop): Support invisible properties on strings
9314 that are being bidi-reordered.
9315 (set_iterator_to_next): Support bidi reordering of C strings and
9316 Lisp strings.
9317 (next_element_from_string): Support bidi reordering of Lisp
9318 strings.
9319 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9320 (display_string): Support display of R2L glyph rows.
9321 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9322 (init_iterator): Don't initialize it->bidi_p for strings
9323 here.
9324 (reseat_to_string): Initialize it->bidi_p for strings here.
9325 (next_element_from_string, next_element_from_c_string)
9326 (next_element_from_buffer): Add xassert's for correspondence
9327 between IT's object being iterated and it->bidi_it.string
9328 structure.
9329 (face_before_or_after_it_pos): Support bidi iteration.
9330 (next_element_from_c_string): Handle the case of the first string
9331 character that is not the first one in the visual order.
9332 (get_visually_first_element): New function, refactored from common
9333 parts of next_element_from_buffer, next_element_from_string, and
9334 next_element_from_c_string.
9335 (tool_bar_lines_needed, redisplay_tool_bar)
9336 (display_menu_bar): Force left-to-right direction. Add a FIXME
9337 comment for making that be controlled by a user option.
9338 (push_it, pop_it): Save and restore the state of the
9339 bidi iterator. Save and restore the bidi_p flag.
9340 (pop_it): Iterate out of display property for string iteration as
9341 well.
9342 (iterate_out_of_display_property): Support iteration over strings.
9343 (handle_single_display_spec): Set up it->bidi_it for iteration
9344 over a display string, and call bidi_init_it.
9345 (handle_single_display_spec, next_overlay_string)
9346 (get_overlay_strings_1, push_display_prop): Set up the bidi
9347 iterator for displaying display or overlay strings.
9348 (forward_to_next_line_start): Don't use the shortcut if
9349 bidi-iterating.
9350 (back_to_previous_visible_line_start): If handle_display_prop
9351 pushed the iterator stack, restore the internal state of the bidi
9352 iterator by calling bidi_pop_it same number of times.
9353 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9354 and we are bidi-iterating, don't decrement the iterator position;
9355 instead, set the first_elt flag in the bidi iterator, to produce
9356 the same effect.
9357 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9358 (push_display_prop): xassert that we are iterating a buffer.
9359 (push_it, pop_it): Save and restore paragraph_embedding member.
9360 (handle_single_display_spec, next_overlay_string)
9361 (get_overlay_strings_1, reseat_1, reseat_to_string)
9362 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9363 correctly. Don't assume unibyte strings are not bidi-reordered.
9364 (compute_display_string_pos)
9365 (compute_display_string_end): Fix handling the case of C string.
9366 (push_it, pop_it): Save and restore from_disp_prop_p.
9367 (handle_single_display_spec, push_display_prop): Set the
9368 from_disp_prop_p flag.
9369 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9370 (pop_it): Call iterate_out_of_display_property only if we are
9371 popping after iteration over a string that came from a display
9372 property. Fix a typo in popping stretch info. Add an assertion
9373 for verifying that the iterator position is in sync with the bidi
9374 iterator.
9375 (handle_single_display_spec, get_overlay_strings_1)
9376 (push_display_prop): Fix initialization of paragraph direction for
9377 string when that of the parent object is not yet determined.
9378 (reseat_1): Call bidi_init_it to resync the bidi
9379 iterator with IT's position. (Bug#7616)
9380 (find_row_edges): If ROW->start.pos gives position
9381 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9382 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9383 Reset the from_disp_prop_p flag.
9384 (SAVE_IT, RESTORE_IT): New macros.
9385 (pos_visible_p, face_before_or_after_it_pos)
9386 (back_to_previous_visible_line_start)
9387 (move_it_in_display_line_to, move_it_in_display_line)
9388 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9389 (try_scrolling, redisplay_window, display_line): Use them when
9390 saving a temporary copy of the iterator and restoring it back.
9391 (back_to_previous_visible_line_start, reseat_1)
9392 (init_iterator): Empty the bidi cache "stack".
9393 (move_it_in_display_line_to): If iterator ended up at
9394 EOL, but we never saw any buffer positions smaller than
9395 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9396 motion in bidi-reordered lines.
9397 (move_it_in_display_line_to): Record prev_method and prev_pos
9398 immediately before the call to set_iterator_to_next. Fixes cursor
9399 motion in bidi-reordered lines with stretch glyphs and strings
9400 displayed in margins. (Bug#8133) (Bug#8867)
9401 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9402 TO_CHARPOS.
640c8776
SM
9403 (pos_visible_p): Support positions in bidi-reordered lines.
9404 Save and restore bidi cache.
0bb23927
EZ
9405
9406 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9407 (bidi_paragraph_info): Delete unused struct.
9408 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9409 (bidi_cache_start): New variable.
9410 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9411 to zero.
9412 (bidi_cache_fetch_state, bidi_cache_search)
9413 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9414 (bidi_cache_find, bidi_peek_at_next_level)
9415 (bidi_level_of_next_char, bidi_find_other_level_edge)
9416 (bidi_move_to_visually_next): Compare cache index with
9417 bidi_cache_start rather than with zero.
9418 (bidi_fetch_char): Accept new argument STRING; all callers
9419 changed. Support iteration over a string. Support strings with
9420 display properties. Support unibyte strings. Fix the type of
9421 `len' according to what STRING_CHAR_AND_LENGTH expects.
9422 (bidi_paragraph_init, bidi_resolve_explicit_1)
9423 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9424 (bidi_level_of_next_char, bidi_move_to_visually_next):
9425 Support iteration over a string.
0bb23927
EZ
9426 (bidi_set_sor_type, bidi_resolve_explicit_1)
9427 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9428 can now be zero (for strings); special values 0 and -1 were
9429 changed to -1 and -2, respectively.
9430 (bidi_char_at_pos): New function.
9431 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9432 Call it instead of FETCH_MULTIBYTE_CHAR.
9433 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9434 initialized to valid values.
9435 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9436 values.
9437 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9438 the test for valid cached positions. Fix the logic for looking up
9439 the sentinel state in the cache. GCPRO the Lisp string we are
9440 iterating.
9441 (bidi_push_it, bidi_pop_it): New functions.
9442 (bidi_initialize): Initialize the bidi cache start stack pointer.
9443 (bidi_cache_ensure_space): New function, refactored from part of
9444 bidi_cache_iterator_state. Don't assume the required size is just
9445 one BIDI_CACHE_CHUNK away.
9446 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9447 (bidi_count_bytes, bidi_char_at_pos): New functions.
9448 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9449 always valid if bidi_cache_idx is valid.
9450 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9451 is valid if it's going to be used.
9452 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9453 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9454 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9455 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9456 (bidi_find_other_level_edge, bidi_cache_start_stack):
9457 All variables related to cache indices are now EMACS_INT.
c965adc5 9458
0bb23927
EZ
9459 * dispextern.h (struct bidi_string_data): New structure.
9460 (struct bidi_it): New member `string'. Make flag members be 1-bit
9461 fields, and put them last in the struct.
640c8776
SM
9462 (compute_display_string_pos, compute_display_string_end):
9463 Update prototypes.
0bb23927
EZ
9464 (bidi_push_it, bidi_pop_it): Add prototypes.
9465 (struct iterator_stack_entry): New members bidi_p,
9466 paragraph_embedding, and from_disp_prop_p.
9467 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9468 (bidi_shelve_cache, bidi_unshelve_cache):
9469 Declare prototypes.
0bb23927
EZ
9470
9471 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9472 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9473 and vector-like objects.
9474
9475 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9476 cache around display iteration.
9477
9478 * window.c (Fwindow_end, window_scroll_pixel_based)
9479 (displayed_window_lines, Frecenter): Save and restore the bidi
9480 cache around display iteration.
9481
3bbd2265
LMI
94822011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9483
9484 * editfns.c (Fdelete_region): Clarify the use of the named
9485 parameters (bug#6788).
9486
adc47434
MR
94872011-07-14 Martin Rudalics <rudalics@gmx.at>
9488
9489 * indent.c (Fvertical_motion): Set and restore w->pointm when
9490 saving and restoring the window's buffer (Bug#9006).
9491
837c31f8
LMI
94922011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9493
9494 * editfns.c (Fstring_to_char): Clarify just what is returned
9495 (bug#6576). Text by Eli Zaretskii.
9496
ac389d0c
JB
94972011-07-13 Juanma Barranquero <lekktu@gmail.com>
9498
9499 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9500
0be0ce47
EZ
95012011-07-13 Eli Zaretskii <eliz@gnu.org>
9502
9503 * buffer.c (mmap_find): Fix a typo.
9504
cd18e7e3
JB
95052011-07-13 Johan Bockgård <bojohan@gnu.org>
9506
9507 Fix execution of x selection hooks.
9508 * xselect.c (Qx_lost_selection_functions)
9509 (Qx_sent_selection_functions): New vars.
9510 (syms_of_xselect): DEFSYM them.
9511 (x_handle_selection_request): Pass Qx_sent_selection_functions
9512 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9513 (x_handle_selection_clear,x_clear_frame_selections):
9514 Pass Qx_lost_selection_functions rather than
9515 Vx_lost_selection_functions to Frun_hook_with_args.
9516
47ea7f44
PE
95172011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9518
ac389d0c 9519 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9520 The old code sometimes used this field without initializing it.
9521
47ea7f44
PE
9522 * alloc.c (gc_sweep): Don't read past end of array.
9523 In theory, the old code could also have corrupted Emacs internals,
9524 though it'd be very unlikely.
9525
bc985c87
AS
95262011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9527
9528 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9529 argument. (Bug#4026)
bc985c87 9530
0cf34688
LMI
95312011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9532
b3dadd76
LMI
9533 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9534 key" (bug#4257).
9535
0cf34688
LMI
9536 * window.c (Fset_window_start): Doc fix (bug#4199).
9537 (Fset_window_hscroll): Ditto.
9538
270768cd
PE
95392011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9540
077e3dda 9541 Fix minor new problems caught by GCC 4.6.1.
270768cd 9542 * term.c (init_tty): Remove unused local.
490011a6 9543 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9544 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9545 not used otherwise.
270768cd 9546
b1f58454
CY
95472011-07-12 Chong Yidong <cyd@stupidchicken.com>
9548
9549 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9550
22b9578d
LMI
95512011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9552
6e70ab07
LMI
9553 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9554 are the mini-buffer and the echo area (bug#3320).
9555
22b9578d
LMI
9556 * term.c (init_tty): Remove support for supdup, c10 and perq
9557 terminals, which are no longer supported (bug#1482).
9558
8974cc9f
JB
95592011-07-10 Johan Bockgård <bojohan@gnu.org>
9560
9561 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9562
a560d974
JD
95632011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9564
9565 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9566 for non-popups (Bug#3642).
9567
1dae0f0a
AS
95682011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9569
268c2c36 9570 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9571 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9572 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9573 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9574 * data.c (fmod): Likewise.
9575 * dispnew.c (swap_glyphs_in_rows): Likewise.
9576 * emacs.c (memory_warning_signal): Likewise.
9577 * floatfns.c (float_error): Likewise.
9578 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9579 (otf_open, font_otf_capability, generate_otf_features)
9580 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9581 Likewise.
9582 * image.c (pbm_read_file): Likewise.
9583 * indent.c (string_display_width): Likewise.
9584 * intervals.c (check_for_interval, search_for_interval)
9585 (inc_interval_count, count_intervals, root_interval)
9586 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9587 * lread.c (defalias): Likewise.
268c2c36 9588 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9589 * regex.c (set_image_of_range_1, set_image_of_range)
9590 (regex_grow_registers): Likewise.
9591 * sysdep.c (strerror): Likewise.
9592 * termcap.c (valid_filename_p, tprint, main): Likewise.
9593 * tparam.c (main): Likewise.
9594 * unexhp9k800.c (run_time_remap, save_data_space)
9595 (update_file_ptrs, read_header, write_header, calculate_checksum)
9596 (copy_file, copy_rest, display_header): Likewise.
9597 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9598 Likewise.
9599 * xdisp.c (check_it): Likewise.
9600 * xfaces.c (register_color, unregister_color, unregister_colors):
9601 Likewise.
9602 * xfns.c (print_fontset_result): Likewise.
9603 * xrdb.c (member, fatal, main): Likewise.
9604
99033785
PE
96052011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9606
9607 Fix minor problems found by static checking (Bug#9031).
9608 * chartab.c (char_table_set_range, map_sub_char_table):
9609 Remove unused locals.
9610 (uniprop_table): Now static.
9611 * composite.c (_work_char): Remove unused static var.
9612
9cb2ac56
JB
96132011-07-09 Juanma Barranquero <lekktu@gmail.com>
9614
9615 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9616
f25661f0
JD
96172011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9618
9619 * gtkutil.c (qttip_cb): Remove code without function.
9620
8278c4fe
EZ
96212011-07-09 Eli Zaretskii <eliz@gnu.org>
9622
9623 * w32.c (pthread_sigmask): New stub.
9624
1692ae2d 96252011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9626
8a6ebd58 9627 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9628 sigprocmask is portable only for single-threaded applications, and
9629 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9630 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9631 (LIBES): Use it.
9632 * callproc.c (Fcall_process):
9633 * process.c (create_process):
9634 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9635 Use pthread_sigmask, not sigprocmask.
123403e4 9636
1b854618
JD
96372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9638
9639 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9640 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9641 wrong (Bug#8591).
9642
3fe4b549
JD
96432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9644
0ce7e563
JD
9645 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9646 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9647 (xg_hide_tooltip): Fix comment.
9648
3fe4b549
JD
9649 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9650 in registerServicesMenuSendTypes.
9651 (validRequestorForSendType): Don't check ns_return_types.
9652
9653 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9654 ns_return_type.
9655
5df75e47
JR
96562011-07-08 Jason Rumney <jasonr@gnu.org>
9657
22610910
JR
9658 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9659 SH_SHOW for hidden windows (Bug#5482).
9660
5df75e47
JR
9661 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9662 frame struct members of non-existent frames (Bug#6284).
9663
699c10bd
JD
96642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9665
4393663b
JD
9666 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9667 variable firstTime not needed on OSX >= 10.6.
9668 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9669 >= 10.5. Use setKnobProportion, setDoubleValue.
9670
9671 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9672 (MAC_OS_X_VERSION_10_5): Define if not defined.
9673 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9674 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9675 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9676
9677 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9678 cString and lossyCString on OSX >= 10.4.
4393663b 9679
58179cce 9680 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9681 sizeToFit on OSX >= 10.2.
9682
9683 * nsimage.m (allocInitFromFile): Don't use deprecated method
9684 bestRepresentationForDevice on OSX >= 10.6.
9685
9686 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9687 to avoid warning.
9688
9689 * emacs.c: Declare unexec_init_emacs_zone.
9690
a63e0781
JD
9691 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9692
699c10bd
JD
9693 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9694
9695 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9696 on svcsMenu (Bug#8842).
9697
9698 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9699 ns_return_types.
9700 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9701
9702 * nsterm.m (QUTF8_STRING): Declare.
9703 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9704 (validRequestorForSendType): Return type is (id).
9705 Change indexOfObjectIdenticalTo to indexOfObject.
9706 Check if we have local selection before returning self (Bug#8842).
9707 (writeSelectionToPasteboard): Put local selection into paste board
9708 if we have a local selection (Bug#8842).
9709 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9710
9711 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9712 (ns_get_local_selection): Declare.
9713
54e10184
LMI
97142011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9715
9888ff71
LMI
9716 * keymap.c (describe_map_tree): Don't insert a double newline at
9717 the end of the buffer (bug#1169) and return whether we inserted
9718 something.
9719
54e10184
LMI
9720 * callint.c (Fcall_interactively): Change "reading args" to
9721 "providing args" to try to clarify what it does (bug#1010).
9722
15fa4783
KH
97232011-07-07 Kenichi Handa <handa@m17n.org>
9724
9725 * composite.c (composition_compute_stop_pos): Ignore a static
9726 composition starting before CHARPOS (Bug#8915).
9727
9728 * xdisp.c (handle_composition_prop): Likewise.
9729
a8815b00
EZ
97302011-07-07 Eli Zaretskii <eliz@gnu.org>
9731
9732 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9733 (Bug#9015)
9734
ef7b981d 97352011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9736
9737 * character.h (unicode_category_t): New enum type.
9738
9739 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9740 (Qchar_code_property_table): New variable.
9741 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9742 (UNIPROP_COMPRESSED_FORM_P): New macros.
9743 (char_table_ascii): Uncompress the compressed values.
9744 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9745 Uncompress the compressed values.
ac389d0c 9746 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9747 (char_table_ref_and_range): Uncompress the compressed values.
9748 (sub_char_table_set): New arg is_uniprop. Callers changed.
9749 Uncompress the compressed values.
9750 (sub_char_table_set_range): Args changed. Callers changed.
9751 (char_table_set_range): Adjuted for the above change.
9752 (map_sub_char_table): Delete args default_val and parent. Add arg
9753 top. Give decoded values to a Lisp function.
640c8776 9754 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9755 values to a Lisp function. Gcpro more variables.
9756 (uniprop_table_uncompress)
9757 (uniprop_decode_value_run_length): New functions.
9758 (uniprop_decoder, uniprop_decoder_count): New variables.
9759 (uniprop_get_decoder, uniprop_encode_value_character)
9760 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9761 New functions.
9762 (uniprop_encoder, uniprop_encoder_count): New variables.
9763 (uniprop_get_encoder, uniprop_table)
9764 (Funicode_property_table_internal, Fget_unicode_property_internal)
9765 (Fput_unicode_property_internal): New functions.
9766 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9767 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9768 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9769 char-code-property-alist.
9770
640c8776 9771 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9772 Vunicode_category_table.
9773
640c8776 9774 * font.c (font_range): Adjust for the change of
c805dec0
KH
9775 Vunicode_category_table.
9776
76b397fb
DN
97772011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9778
9779 * m/iris4d.h: Remove file, move contents ...
9780 * s/irix6-5.h: ... here.
9781
22b4128e
PE
97822011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9783
9784 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9785 * alloc.c (mark_buffer):
9786 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9787 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9788 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9789 This isn't true in general, and it's particularly not true
9790 if Emacs is configured with --with-wide-int.
9791 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9792 New macros, used in the buffer.c change.
9793
869795d6
JD
97942011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9795
9796 * xsettings.c: Use both GConf and GSettings if both are available.
9797 (store_config_changed_event): Add comment.
9798 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9799 (store_tool_bar_style_changed): New functions.
5e617bc2 9800 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9801 (struct xsettings): Move font inside HAVE_XFT.
9802 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9803 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9804 Move inside HAVE_XFT.
640c8776 9805 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9806 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9807 also.
9808 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9809 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9810 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9811 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9812 (parse_settings): Move check for font inside HAVE_XFT.
9813 (read_settings, apply_xft_settings): Add comment.
9814 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9815 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9816 call store_font_name_changed.
9817 (xft_settings_event): Add comment.
9818 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9819 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9820 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9821 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9822 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9823 (xsettings_get_system_font, xsettings_get_system_normal_font):
9824 Add comment.
869795d6 9825
d8ed26bd
PE
98262011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9827
9828 Random fixes. E.g., (random) never returned negative values.
9829 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9830 subseconds part to the entropy, as that's a bit more random.
9831 Prefer signed to unsigned, since the signedness doesn't matter and
9832 in general we prefer signed. When given a limit, use a
9833 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9834 latter isn't right if USE_2_TAGS_FOR_INTS.
9835 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9836 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9837
cabf1cac
SM
98382011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9839
9840 * textprop.c (text_property_stickiness):
9841 Obey Vtext_property_default_nonsticky.
9842 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9843 * w32fns.c (syms_of_w32fns):
9844 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9845
6e9b2be9
PE
98462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9847
9848 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9849 This is more efficient than Ffile_directory_p and avoids a minor race.
9850
90186c68
LMI
98512011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9852
7c301272
LMI
9853 * buffer.c (Foverlay_put): Say what the return value is
9854 (bug#7835).
9855
c4f2d8d4
LMI
9856 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9857 is a directory before asking whether to use the file name
9858 (bug#7564).
ad637907
LMI
9859 (barf_or_query_if_file_exists): Make the "File is a directory"
9860 error be more correct.
c4f2d8d4 9861
90186c68
LMI
9862 * fns.c (Frequire): Remove the mention of the .gz files, since
9863 that's installation-specific, but keep the mention of
9864 `get-load-suffixes'.
9865
da64016e
PE
98662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9867
9868 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9869 Report string overflow if the output is too long.
9870
7d47b580
JB
98712011-07-04 Juanma Barranquero <lekktu@gmail.com>
9872
a555cb87
JB
9873 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9874 (syms_of_gnutls): Remove duplicate DEFSYM for
9875 Qgnutls_bootprop_verify_hostname_error, an error for
9876 Qgnutls_bootprop_verify_error (which is no longer used).
9877
7d47b580
JB
9878 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9879 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9880 Also (re)move comments that are misplaced or no longer relevant.
9881
1e49bfab
LMI
98822011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9883
9884 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9885
1485f4c0
CY
98862011-07-03 Chong Yidong <cyd@stupidchicken.com>
9887
9888 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9889 and background color parameters if they have been changed.
9890
a9ab721e
LMI
98912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9892
9893 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9894
cf7cff57
PE
98952011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9896
2e13213d
PE
9897 * xsettings.c (SYSTEM_FONT): Define only when used.
9898 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9899
cf7cff57
PE
9900 * keymap.c (access_keymap_1): Now static.
9901
7a8e04f7
CY
99022011-07-02 Chong Yidong <cyd@stupidchicken.com>
9903
9904 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9905 leave any prefix arg for the up event (Bug#1586).
9906
61352f62
LMI
99072011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9908
69bb1ef7
LMI
9909 * lread.c (syms_of_lread): Mention single symbols defined by
9910 `defvar' or `defconst' (bug#7154).
9911
61352f62 9912 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9913 (Frequire): Mention get-load-suffixes.
61352f62 9914
28545e04
MR
99152011-07-02 Martin Rudalics <rudalics@gmx.at>
9916
9917 * window.h (window): Remove clone_number slot.
9918 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9919 Remove.
9920 (make_parent_window, make_window, saved_window)
9921 (Fset_window_configuration, save_window_save): Don't deal with
9922 clone numbers.
9923 * buffer.c (Qclone_number): Remove declaration.
9924 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9925
3349e122
SM
99262011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9927
9928 Add multiple inheritance to keymaps.
9929 * keymap.c (Fmake_composed_keymap): New function.
9930 (Fset_keymap_parent): Simplify.
9931 (fix_submap_inheritance): Remove.
9932 (access_keymap_1): New function extracted from access_keymap to handle
9933 embedded parents and handle lists of maps.
9934 (access_keymap): Use it.
9935 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9936 (Fcopy_keymap): Handle embedded parents.
9937 (Fcommand_remapping, define_as_prefix): Simplify.
9938 (Fkey_binding): Simplify.
9939 (syms_of_keymap): Move minibuffer-local-completion-map,
9940 minibuffer-local-filename-completion-map,
9941 minibuffer-local-must-match-map, and
9942 minibuffer-local-filename-must-match-map to Elisp.
9943 (syms_of_keymap): Defsubr make-composed-keymap.
9944 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9945 (parse_menu_item): Trivial simplification.
9946
3279eb87
GM
99472011-07-01 Glenn Morris <rgm@gnu.org>
9948
9949 * Makefile.in (SETTINGS_LIBS): Fix typo.
9950
4550efdf
KI
99512011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9952
9953 * coding.c (Fencode_coding_string): Record the last coding system
9954 used, as the function doc string says (bug#8738).
9955
0949d2b6
JD
99562011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9957
9958 * xsettings.c (store_monospaced_changed): Take new font as arg and
9959 check for change against current_mono_font.
9960 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9961 (emacs_settings_constructor, emacs_settings_get_property)
9962 (emacs_settings_set_property, emacs_settings_class_init)
9963 (emacs_settings_init, gsettings_obj): Remove.
9964 (something_changedCB): New function for HAVE_GSETTINGS.
9965 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9966 with value as argument.
9967 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9968 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9969 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9970 "changed".
9971
9972 * xgselect.c: Add defined (HAVE_GSETTINGS).
9973 (xgselect_initialize): Ditto.
9974
9975 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9976 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9977 xg_select.
9978
bbc6b304
PE
99792011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9980
9981 * eval.c (struct backtrace): Simplify and port the data structure.
9982 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9983 signed bit field, as this assumption is not portable and it makes
9984 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9985 "char debug_on_exit : 1" as this is not portable either; instead,
9986 use the portable "unsigned int debug_on_exit : 1". Remove unused
9987 member evalargs. Remove obsolete comments about cc bombing out.
9988
9851bfc5
JD
99892011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9990
51bb811f 9991 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9992 Let HAVE_GSETTINGS override HAVE_GCONF.
9993 (store_monospaced_changed): New function.
9994 (EMACS_SETTINGS): A new type derived from GObject to handle
9995 GSettings notifications.
9996 (emacs_settings_constructor, emacs_settings_get_property)
9997 (emacs_settings_set_property, emacs_settings_class_init):
9998 New functions.
9999 (gsettings_client, gsettings_obj): New variables.
10000 (GSETTINGS_SCHEMA): New define.
10001 (something_changedCB): Call store_monospaced_changed.
10002 (init_gsettings): New function.
10003 (xsettings_initialize): Call init_gsettings.
10004 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10005 to NULL.
10006
640c8776 10007 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10008 GCONF_CFLAGS/LIBS.
10009
5386012d
MR
100102011-06-29 Martin Rudalics <rudalics@gmx.at>
10011
10012 * window.c (resize_root_window, grow_mini_window)
10013 (shrink_mini_window): Rename Qresize_root_window to
10014 Qwindow_resize_root_window and Qresize_root_window_vertically to
10015 Qwindow_resize_root_window_vertically.
10016
f13e0b08
PE
100172011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10018
10019 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10020
94515237
JB
100212011-06-27 Juanma Barranquero <lekktu@gmail.com>
10022
10023 * makefile.w32-in: Redesign dependencies so they reflect more
10024 clearly which files are directly included by each source file,
10025 and not through other includes.
10026
e43b6e43
MR
100272011-06-27 Martin Rudalics <rudalics@gmx.at>
10028
10029 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10030 (sort_overlays, overlay_strings): When an overlay's clone number
10031 matches the window's clone number process the overlay even if
10032 the overlay's window property doesn't match the current window.
10033
d68443dc
MR
10034 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10035 (Fwindow_hchild): Rename to Fwindow_left_child.
10036 (Fwindow_next): Rename to Fwindow_next_sibling.
10037 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10038 (resize_window_check): Rename to window_resize_check.
10039 (resize_window_apply): Rename to window_resize_apply.
10040 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10041 (Fdelete_other_windows_internal, resize_frame_windows)
10042 (Fsplit_window_internal, Fdelete_window_internal)
10043 (grow_mini_window, shrink_mini_window)
10044 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10045
c7e73be5
JD
100462011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10047
10048 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10049 (emacs_fixed_set_min_size): Remove.
10050 (emacs_fixed_new): Take frame as argument.
10051
10052 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10053 (_EmacsFixedPrivate): Remove minwidth/height.
10054 Add struct frame *f.
10055 (emacs_fixed_init): Initialize priv->f.
10056 (get_parent_class, emacs_fixed_set_min_size): Remove.
10057 (emacs_fixed_new): Set priv->f to argument.
10058 (emacs_fixed_get_preferred_width)
10059 (emacs_fixed_get_preferred_height): Use min_width/height from
10060 frames size_hint to set minimum and natural (Bug#8919).
10061 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10062 and use min_width/height from frames size_hint to set
10063 min_width/height (Bug#8919).
10064
10065 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10066 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10067 Fix indentation.
c7e73be5 10068
cf99dcf8
EZ
100692011-06-26 Eli Zaretskii <eliz@gnu.org>
10070
10071 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10072 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10073 called at ZV.
10074
029529ac
CY
100752011-06-26 Chong Yidong <cyd@stupidchicken.com>
10076
10077 * process.c (wait_reading_process_output): Bypass select if
10078 waiting for a cell while ignoring keyboard input, and input is
10079 pending. Suggested by Jan Djärv (Bug#8869).
10080
7a7ef429
PE
100812011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10082
10083 Use gnulib's dup2 module instead of rolling our own.
10084 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10085
11fdef7d 100862011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10087
10088 * dispnew.c (scrolling_window): Before scrolling, turn off a
10089 mouse-highlight in the window being scrolled.
10090
cd3520a4
JB
100912011-06-24 Juanma Barranquero <lekktu@gmail.com>
10092
10093 Move DEFSYM to lisp.h and use everywhere.
10094
10095 * character.h (DEFSYM): Move declaration...
10096 * lisp.h (DEFSYM): ...here.
10097
10098 * gnutls.c:
10099 * minibuf.c:
10100 * w32menu.c:
10101 * w32proc.c:
10102 * w32select.c: Don't include character.h.
10103
10104 * alloc.c (syms_of_alloc):
10105 * buffer.c (syms_of_buffer):
10106 * bytecode.c (syms_of_bytecode):
10107 * callint.c (syms_of_callint):
10108 * casefiddle.c (syms_of_casefiddle):
10109 * casetab.c (init_casetab_once):
10110 * category.c (init_category_once, syms_of_category):
10111 * ccl.c (syms_of_ccl):
10112 * cmds.c (syms_of_cmds):
10113 * composite.c (syms_of_composite):
10114 * dbusbind.c (syms_of_dbusbind):
10115 * dired.c (syms_of_dired):
10116 * dispnew.c (syms_of_display):
10117 * doc.c (syms_of_doc):
10118 * editfns.c (syms_of_editfns):
10119 * emacs.c (syms_of_emacs):
10120 * eval.c (syms_of_eval):
10121 * fileio.c (syms_of_fileio):
10122 * fns.c (syms_of_fns):
10123 * frame.c (syms_of_frame):
10124 * fringe.c (syms_of_fringe):
10125 * insdel.c (syms_of_insdel):
10126 * keymap.c (syms_of_keymap):
10127 * lread.c (init_obarray, syms_of_lread):
10128 * macros.c (syms_of_macros):
10129 * msdos.c (syms_of_msdos):
10130 * print.c (syms_of_print):
10131 * process.c (syms_of_process):
10132 * search.c (syms_of_search):
10133 * sound.c (syms_of_sound):
10134 * syntax.c (init_syntax_once, syms_of_syntax):
10135 * terminal.c (syms_of_terminal):
10136 * textprop.c (syms_of_textprop):
10137 * undo.c (syms_of_undo):
10138 * w32.c (globals_of_w32):
10139 * window.c (syms_of_window):
10140 * xdisp.c (syms_of_xdisp):
10141 * xfaces.c (syms_of_xfaces):
10142 * xfns.c (syms_of_xfns):
10143 * xmenu.c (syms_of_xmenu):
10144 * xsettings.c (syms_of_xsettings):
10145 * xterm.c (syms_of_xterm): Use DEFSYM.
10146
4228cf16
TZ
101472011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10148
cd3520a4 10149 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10150
7fcccf1e
PE
101512011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10152
7efb4e0e
PE
10153 Integer and buffer overflow fixes (Bug#8873).
10154
ff5844ad
PE
10155 * print.c (printchar, strout): Check for string overflow.
10156 (PRINTPREPARE, printchar, strout):
10157 Don't set size unless allocation succeeds.
10158
90532f02
PE
10159 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10160 for sizes. Check for string overflow more accurately.
10161 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10162
6d84508d
PE
10163 * macros.c: Integer and buffer overflow fixes.
10164 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10165 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10166 Use ptrdiff_t, not int, for sizes.
10167 Don't increment bufsize until after realloc succeeds.
10168 Check for size-calculation overflow.
10169 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10170
437b2cb4
PE
10171 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10172
8b9ac8b4
PE
10173 * lread.c: Integer overflow fixes.
10174 (read_integer): Radix is now EMACS_INT, not int,
10175 to improve quality of diagnostics for out-of-range radices.
10176 Calculate buffer size correctly for out-of-range radices.
10177 (read1): Check for integer overflow in radices, and in
10178 read-circle numbers.
82cb60d3
PE
10179 (read_escape): Avoid int overflow.
10180 (Fload, openp, read_buffer_size, read1)
10181 (substitute_object_recurse, read_vector, read_list, map_obarray):
10182 Use ptrdiff_t, not int, for sizes.
10183 (read1): Use EMACS_INT, not int, for sizes.
20270765 10184 Check for size overflow.
8b9ac8b4 10185
7fcccf1e
PE
10186 * image.c (cache_image): Check for size arithmetic overflow.
10187
bfbbd7e7
PE
10188 * lread.c: Integer overflow issues.
10189 (saved_doc_string_size, saved_doc_string_length)
10190 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10191 Now ptrdiff_t, not int.
10192 (read1): Don't assume doc string length fits in int. Check for
10193 out-of-range doc string lengths.
10194 (read_list): Don't assume file position fits in int.
39019e54 10195 (read_escape): Check for hex character overflow.
bfbbd7e7 10196
4e323265
LL
101972011-06-22 Leo Liu <sdl.web@gmail.com>
10198
10199 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10200 Move to minibuffer.el.
10201
85fece3e
PE
102022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10203
20b84ce9 10204 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10205 The following patches are for when GLYPH_DEBUG && !XASSERT.
10206 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10207 * dispnew.c (flush_stdout):
10208 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10209 Mark as externally visible.
10210 * dispnew.c (check_window_matrix_pointers): Now static.
10211 * dispnew.c (window_to_frame_vpos):
10212 * xfns.c (unwind_create_frame):
10213 * xterm.c (x_check_font): Remove unused local.
10214 * scroll.c (CHECK_BOUNDS):
10215 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10216 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10217 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10218 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10219 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10220 Now static.
10221 (debug_method_add): Use va_list and vsprintf rather than relying
10222 on undefined behavior with wrong number of arguments.
10223 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10224 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10225 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10226 since we're not interested in debugging glyphs with old libraries.
10227 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10228 GCC 4.6.0's static checking.
10229
0766b489
PE
102302011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10231
31fd4b32
PE
10232 Integer overflow and signedness fixes (Bug#8873).
10233 A few related buffer overrun fixes, too.
10234
b79e8648
PE
10235 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10236
0766b489
PE
10237 * dispextern.h (struct face.stipple):
10238 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10239 (x_bitmap_mask, x_allocate_bitmap_record)
10240 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10241 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10242 (x_create_bitmap_from_xpm_data):
10243 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10244 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10245 (.bitmaps_last):
10246 * xfaces.c (load_pixmap):
10247 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10248 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10249 (.bitmaps_last, struct x_output.icon_bitmap):
10250 Use ptrdiff_t, not int, for bitmap indexes.
10251 (x_allocate_bitmap_record): Check for size overflow.
10252 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10253
b081724f
PE
10254 Use ptrdiff_t, not int, for overlay counts.
10255 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10256 * editfns.c (overlays_around, get_pos_property):
10257 * textprop.c (get_char_property_and_overlay):
10258 * xdisp.c (next_overlay_change, note_mouse_highlight):
10259 * xfaces.c (face_at_buffer_position):
21514da7
PE
10260 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10261 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10262 (Fnext_overlay_change, Fprevious_overlay_change)
10263 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10264 Use ptrdiff_t, not int, for sizes.
21514da7 10265 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10266
3de73e5e
PE
10267 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10268
2606c57b
PE
10269 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10270 (x_session_initialize): Do not assume string length fits in int.
10271
aaafe47a
PE
10272 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10273 This is unlikely, but can occur if DPI is outlandish.
10274
2674ddc8 10275 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10276 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10277
28154962
PE
10278 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10279 * xrdb.c (magic_file_p, search_magic_path):
10280 Omit last arg SUFFIX; it was always 0. All callers changed.
10281 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10282
7de51af5
PE
10283 * xfont.c (xfont_match): Avoid need for strlen.
10284
25ed6cc3
PE
10285 * xfns.c: Don't assume strlen fits in int.
10286 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10287
4eab31dd
PE
10288 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10289 not unsigned long, as we prefer signed integers. All callers changed.
10290 Detect integer overflow in repeat count.
10291 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10292 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10293
171e2a58
PE
10294 * termcap.c: Don't assume sizes fit in int and never overflow.
10295 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10296 (gobble_line): Check for size-calculation overflow.
10297
ad39faca 10298 * minibuf.c (Fread_buffer):
6e5bb2dc 10299 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10300 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10301 Don't assume string length fits in int.
10302
52c61c22 10303 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10304 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10305
b5b8c9e5
PE
10306 * font.c: Don't assume string length fits in int.
10307 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10308 Use ptrdiff_t, not int.
ccd6111c
PE
10309 (font_intern_prop): Don't assume string length fits in int.
10310 Don't assume integer property fits in fixnum.
10311 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10312
882f0d81 10313 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10314 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10315 Reformulate so as not to need the command string.
10316 Invoke gzip -cd rather than gunzip, as it's more portable.
10317 (lock_info_type, lock_file_1, lock_file):
10318 Don't assume pid_t and time_t fit in unsigned long.
10319 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10320 (current_lock_owner): Prefer signed type for sizes.
10321 Use memcpy, not strncpy, where memcpy is what is really wanted.
10322 Don't assume (via atoi) that time_t and pid_t fit in int.
10323 Check for time_t and/or pid_t out of range, e.g., via a network share.
10324 Don't alloca where an auto var works fine.
10325
93f4cf88
PE
10326 * fileio.c: Fix some integer overflow issues.
10327 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10328 Don't assume string length fits in int.
10329 (directory_file_name): Don't assume string length fits in long.
10330 (make_temp_name): Don't assume pid fits in int, or that its print
10331 length is less than 20.
10332
f3e92b69
PE
10333 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10334
1bfdaf10
PE
10335 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10336
35016e9a
PE
10337 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10338
3d1e65a1
PE
10339 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10340 We prefer signed integers, even for size calculations.
10341
0b963a93
PE
10342 * emacs.c: Don't assume string length fits in 'int'.
10343 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10344 (main): Don't invoke strlen when not needed.
10345
573f4b54
PE
10346 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10347 (XD_DEBUG_MESSAGE): Don't waste a byte.
10348
989f33ba
PE
10349 * callproc.c (getenv_internal_1, getenv_internal)
10350 (Fgetenv_internal):
965d34eb
PE
10351 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10352
e4d29b33
PE
10353 * lread.c (invalid_syntax): Omit length argument.
10354 All uses changed. This doesn't fix a bug, but it simplifies the
10355 code away from its former Hollerith-constant appearance, and it's
10356 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10357 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10358
eb49b136
PE
10359 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10360 This didn't break anything, but it didn't help either.
10361 It's confusing to put a bogus integer in a place where the actual
10362 value does not matter.
9f62aeb1 10363 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10364 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10365
15375a22
PE
10366 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10367 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10368 implementation.
b61cc01c
PE
10369 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10370 We prefer signed types, and the value cannot exceed the EMACS_INT
10371 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10372 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10373 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10374 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10375
53b2623d
PE
10376 * indent.c (sane_tab_width): New function.
10377 (current_column, scan_for_column, Findent_to, position_indentation)
10378 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10379 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10380
51cab52b 10381 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10382
f2ed8a70
PE
10383 * lisp.h (lint_assume): New macro.
10384 * composite.c (composition_gstring_put_cache):
10385 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10386
abe80cc6
PE
10387 * editfns.c, insdel.c:
10388 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10389
b02c740e
PE
10390 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10391
ebc96716
PE
10392 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10393
b4e50fa0 10394 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10395 Use much-faster test for byte-length change.
311d5d7c 10396 Don't assume string byte-length fits in 'int'.
a4cf38e4 10397 Check that character arg fits in 'int'.
85461888 10398 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10399
c0c1ee9f
PE
10400 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10401
a498d7f4
PE
10402 * fns.c (concat): Catch string overflow earlier.
10403 Do not rely on integer wraparound.
10404
51cab52b
PE
10405 * dispextern.h (struct it.overlay_strings_charpos)
10406 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10407 * xdisp.c (forward_to_next_line_start)
10408 (back_to_previous_visible_line_start)
10409 (reseat_at_next_visible_line_start, next_element_from_buffer):
10410 Don't arbitrarily truncate the value of 'selective' to int.
10411
76031fad
PE
10412 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10413
5eb55db9
PE
10414 * composite.c: Don't truncate sizes to 'int'.
10415 (composition_gstring_p, composition_reseat_it)
10416 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10417 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10418 not EMACS_UINT, for indexes.
5eb55db9 10419
0703a717
PE
10420 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10421
d6202519
PE
10422 * buffer.c: Include <verify.h>.
10423 (struct sortvec.priority, struct sortstr.priority):
8961a454 10424 Now EMACS_INT, not int.
c20998a7 10425 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10426 (struct sortstr.size, record_overlay_string)
10427 (struct sortstrlist.size, struct sortlist.used):
10428 Don't truncate size to int.
10429 (record_overlay_string): Check for size-calculation overflow.
d6202519 10430 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10431
d5a19415
JM
104322011-06-22 Jim Meyering <meyering@redhat.com>
10433
029529ac 10434 Don't leak an XBM-image-sized buffer
d5a19415
JM
10435 * image.c (xbm_load): Free the image buffer after using it.
10436
a9041e6c
PE
104372011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10438
10439 Port to Sun C.
10440 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10441 that Sun C diagnosed.
10442 * fns.c (secure_hash): Fix pointer signedness issue.
10443 * intervals.c (static_offset_intervals): New function.
10444 (offset_intervals): Use it.
10445
7f3f739f
LL
104462011-06-21 Leo Liu <sdl.web@gmail.com>
10447
10448 * deps.mk (fns.o):
10449 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10450 sha512.h.
10451
10452 * fns.c (secure_hash): Rename from crypto_hash_function and change
10453 the first arg to accept symbols.
5b66d427 10454 (Fsecure_hash): New primitive.
7f3f739f
LL
10455 (syms_of_fns): New symbols.
10456
76147d94
DD
104572011-06-20 Deniz Dogan <deniz@dogan.se>
10458
10459 * process.c (Fset_process_buffer): Clarify return value in
10460 docstring.
10461
7d7d0045
CY
104622011-06-18 Chong Yidong <cyd@stupidchicken.com>
10463
10464 * dispnew.c (add_window_display_history): Use BVAR.
10465
10466 * xdisp.c (debug_method_add): Use BVAR.
10467 (check_window_end, dump_glyph_matrix, dump_glyph)
10468 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10469
10470 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10471 Likewise.
10472
10473 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10474 check till after the cache is created in init_frame_faces.
10475
ff2bc410
SM
104762011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10477
10478 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10479
28177add
PE
104802011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10481
dd3482fe
PE
10482 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10483 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10484 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10485
393d71f3 10486 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10487 * fileio.c (Finsert_file_contents):
10488 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10489 Remove the old (too-loose) buffer overflow checks.
10490 They weren't needed, since make_gap checks for buffer overflow.
10491 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10492 The old code merely checked for Emacs fixnum overflow, and relied
10493 on undefined (wraparound) behavior. The new code avoids undefined
10494 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10495
2e6813b0 10496 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10497 Tune. Don't use wider integers than needed. Don't use alloca.
10498 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10499
599a9e4f
PE
10500 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10501
99561444
PE
10502 * insdel.c, lisp.h (buffer_overflow): New function.
10503 (insert_from_buffer_1, replace_range, replace_range_2):
10504 * insdel.c (make_gap_larger):
10505 * editfns.c (Finsert_char):
10506 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10507
28177add
PE
10508 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10509
e69dafad
PE
105102011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10511
4baa020d 10512 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10513
b1c46f02
PE
10514 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10515 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10516
e69dafad
PE
10517 * fileio.c: Don't assume EMACS_INT fits in off_t.
10518 (emacs_lseek): New static function.
10519 (Finsert_file_contents, Fwrite_region): Use it.
10520 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10521
566684ea
PE
10522 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10523
e6966cd6
PE
10524 * fns.c: Don't overflow int when computing a list length.
10525 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10526 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10527 truncation on 64-bit hosts. Check for QUIT every
10528 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10529 faster and is responsive enough.
10530 (Flength): Report an error instead of overflowing an integer.
10531 (Fsafe_length): Return a float if the value is not representable
10532 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10533 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10534 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10535
dd0b0efb
PE
10536 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10537 (header_size, word_size): New constants.
10538 (allocate_vectorlike): Don't check size overflow here.
10539 (allocate_vector): Check it here instead, since this is the only
10540 caller of allocate_vectorlike that could cause overflow.
10541 Check that the new vector's length is representable as a fixnum.
10542
86fe5cfe
PE
10543 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10544 The previous code was bogus. For example, next_almost_prime (32)
10545 returned 39, which is undesirable as it is a multiple of 3; and
10546 next_almost_prime (24) returned 25, which is a multiple of 5 so
10547 why was the code bothering to check for multiples of 7?
10548
80e88859
PE
10549 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10550
4a2f0ad6
PE
10551 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10552
f66c7cf8
PE
10553 Variadic C functions now count arguments with ptrdiff_t.
10554 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10555 Back then I didn't know that the Emacs coding style prefers signed int.
10556 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10557 were being counted with int, which may truncate counts on 64-bit
10558 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10559 * lisp.h (struct Lisp_Subr.function.aMANY)
10560 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10561 Arg counts are now ptrdiff_t, not size_t.
10562 All variadic functions and their callers changed accordingly.
10563 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10564 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10565 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10566 * callint.c (Fcall_interactively): Check arg count for overflow,
10567 to avoid potential buffer overrun. Use signed char, not 'int',
10568 for 'varies' array, so that we needn't bother to check its size
10569 calculation for overflow.
10570 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10571 * eval.c (apply_lambda):
10572 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10573 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10574 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10575
a1759b76
PE
10576 * callint.c (Fcall_interactively): Don't use index var as event count.
10577
d96be9fc
PE
10578 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10579 * mem-limits.h (SIZE): Remove; no longer used.
10580
a690a978 10581 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10582
578c21e6
PE
10583 Remove unnecessary casts.
10584 * xterm.c (x_term_init):
10585 * xfns.c (x_set_border_pixel):
10586 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10587 These aren't needed now that we assume ANSI C.
10588
96f53c6c
PE
10589 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10590 It's more likely to cause problems (due to unsigned overflow)
10591 than to cure them.
10592
83c77d31
PE
10593 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10594
ee2079f1
PE
10595 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10596
6da65536
PE
10597 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10598
7147c4a4
PE
10599 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10600
193e32d9
PE
10601 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10602
e5533da6
PE
10603 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10604
9910e595
PE
10605 GLYPH_CODE_FACE returns EMACS_INT, not int.
10606 * dispextern.h (merge_faces):
10607 * xfaces.c (merge_faces):
01103c44
PE
10608 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10609 Don't assume EMACS_INT fits in int.
9910e595 10610
2638320e
PE
10611 * character.h (CHAR_VALID_P): Remove unused parameter.
10612 * fontset.c, lisp.h, xdisp.c: All uses changed.
10613
045eb8d9
PE
10614 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10615
c1f134b5
PE
10616 * fns.c (concat): Minor tuning based on overflow analysis.
10617 This doesn't fix any bugs. Use int to hold character, instead
10618 of constantly refetching from Emacs object. Use XFASTINT, not
10619 XINT, for value known to be a character. Don't bother comparing
10620 a single byte to 0400, as it's always less.
10621
395fcb93 10622 * floatfns.c (Fexpt):
327eeec8
PE
10623 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10624
abbd3d23
PE
10625 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10626 for characters.
10627
684a03ef
PE
10628 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10629
0fed43f3
PE
10630 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10631 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10632 incorrectly succeed when S was a string, because 4294967386 was
10633 truncated before it was used.
10634
8fd02eb7
PE
10635 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10636 Otherwise, an out-of-range integer could cause undefined behavior
10637 on a 64-bit host.
10638
f8c86b69
PE
10639 * composite.c: Use int, not EMACS_INT, for characters.
10640 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10641 EMACS_INT, for values that are known to be in character range.
10642 This doesn't fix any bugs but is the usual style inside Emacs and
10643 may generate better code on 32-bit machines.
10644
34206dd2
PE
10645 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10646 This is for reasons similar to the recent CHAR_STRING fix.
10647 * charset.c (Fencode_char): Check that character arg is actually
10648 a character. Pass an int to ENCODE_CHAR.
10649 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10650 wider than 'int', as a compile-time check to prevent future regressions
10651 in this area.
10652
c5958d4c 10653 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10654
10655 Make sure a 64-bit char is never passed to CHAR_STRING.
10656 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10657 by silently ignoring the top 32 bits, allowing some values
10658 that were far too large to be valid characters.
10659 * character.h: Include <verify.h>.
10660 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10661 arguments are no wider than unsigned, as a compile-time check
10662 to prevent future regressions in this area.
10663 * data.c (Faset):
01103c44 10664 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10665 (Fsubst_char_in_region):
10666 * fns.c (concat):
10667 * xdisp.c (decode_mode_spec_coding):
10668 Adjust to CHAR_STRING's new requirement.
10669 * editfns.c (Finsert_char, Fsubst_char_in_region):
10670 * fns.c (concat): Check that character args are actually
10671 characters. Without this test, these functions did the wrong
10672 thing with wildly out-of-range values on 64-bit hosts.
10673
d37ca623
PE
10674 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10675 These casts should not be needed on 32-bit hosts, either.
10676 * keyboard.c (read_char):
10677 * lread.c (Fload): Remove casts to unsigned.
10678
ea204efb
PE
10679 * lisp.h (UNSIGNED_CMP): New macro.
10680 This fixes comparison bugs on 64-bit hosts.
10681 (ASCII_CHAR_P): Use it.
10682 * casefiddle.c (casify_object):
01103c44 10683 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10684 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10685 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10686 * dispextern.h (FACE_FROM_ID):
10687 * keyboard.c (read_char): Use UNSIGNED_CMP.
10688
41cb286c
PE
10689 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10690 not to EMACS_INT, to avoid GCC warning.
10691
4a1b9832
PE
10692 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10693
55daad71
PE
10694 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10695 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10696 isn't needed on 32-bit machines.
8f95c75c 10697
01103c44
PE
10698 * buffer.c (Fgenerate_new_buffer_name):
10699 Use EMACS_INT for count, not int.
0ceccced 10700 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10701
10702 * data.c (Qcompiled_function): Now static.
10703
c6f072e7
PE
10704 * window.c (window_body_lines): Now static.
10705
20ce5912
PE
10706 * image.c (gif_load): Rename local to avoid shadowing.
10707
9c4c5f81
PE
10708 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10709 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10710 * alloc.c (make_save_value): Integer argument is now of type
10711 ptrdiff_t, not int.
10712 (mark_object): Use ptrdiff_t, not int.
10713 * lisp.h (pD): New macro.
10714 * print.c (print_object): Use it.
10715
c0c5c8ae
PE
10716 * alloc.c: Use EMACS_INT, not int, to count objects.
10717 (total_conses, total_markers, total_symbols, total_vector_size)
10718 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10719 (total_free_floats, total_floats, total_free_intervals)
10720 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10721 Now EMACS_INT, not int. All uses changed.
10722 (Fgarbage_collect): Compute overall total using a double, so that
10723 integer overflow is less likely to be a problem. Check for overflow
10724 when converting back to an integer.
5a25e253
PE
10725 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10726 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10727 These were 'int' variables that could overflow on 64-bit hosts;
10728 they were never used, so remove them instead of repairing them.
211a0b2a 10729 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10730 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10731 Previously, this ceilinged at INT_MAX, but that doesn't work on
10732 64-bit machines.
e46bb31a 10733 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10734
c78baabf 10735 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10736 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10737 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10738 when a (possibly-narrower) signed value would do just as well.
10739 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10740
c9d624c6
PE
10741 * alloc.c: Catch some string size overflows that we were missing.
10742 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10743 for convenience in STRING_BYTES_MAX.
10744 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10745 The definition here is exact; the one in lisp.h was approximate.
10746 (allocate_string_data): Check for string overflow. This catches
10747 some instances we weren't catching before. Also, it catches
10748 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10749 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10750 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10751
c9d624c6
PE
10752 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10753 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10754 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10755
353032ce
PE
10756 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10757
2bccce07
PE
10758 * alloc.c (Fmake_string): Check for out-of-range init.
10759
0ac30604
SM
107602011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10761
10762 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10763
c195f2de
JD
107642011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10765
10766 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10767 xg_get_default_scrollbar_width.
10768
10769 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10770 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10771 (style_changed_cb): Call update_theme_scrollbar_width and call
10772 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10773 all frames (Bug#8505).
10774 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10775 Call gtk_window_set_resizable if HAVE_GTK3.
10776 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10777 and height if HAVE_GTK3 (Bug#8505).
10778 (scroll_bar_width_for_theme): New variable.
10779 (update_theme_scrollbar_width): New function.
10780 (xg_get_default_scrollbar_width): Move code to
10781 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10782 (xg_initialize): Call update_theme_scrollbar_width.
10783
10784 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10785
10786 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10787
e10ac9f1
MR
107882011-06-12 Martin Rudalics <rudalics@gmx.at>
10789
10790 * frame.c (make_frame): Call other_buffer_safely instead of
10791 other_buffer.
10792
10793 * window.c (temp_output_buffer_show): Call display_buffer with
10794 second argument Vtemp_buffer_show_specifiers and reset latter
10795 immediately after the call.
10796 (Vtemp_buffer_show_specifiers): New variable.
10797 (auto_window_vscroll_p, next_screen_context_lines)
10798 (Vscroll_preserve_screen_position): Remove leading asterisks from
10799 doc-strings.
10800
2d3c217e 108012011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10802
7b7f97e8 10803 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10804 * buffer.c (Qclone_number): Remove for now, as it's unused.
10805 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10806 (record_buffer): Remove unused local.
10807 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10808 (set_frame_buffer_list): Remove; unused.
10809 * frame.h (other_visible_frames): Remove decl.
10810 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10811 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10812 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10813 if HAVE_GPM.
10814 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10815 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10816 Define only if HAVE_GPM.
10817 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10818 (update_hints_inhibit): Remove; never set. All uses removed.
10819 * widgetprv.h (emacsFrameClassRec): Remove decl.
10820 * window.c (delete_deletable_window): Now returns void, since it
10821 wasn't returning anything.
10822 (compare_window_configurations): Remove unused locals.
10823 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10824 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10825 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10826 the same widths as pointers. This follows up on the 2011-05-06 patch.
10827 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10828 * xterm.h: Likewise.
10829 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10830
1384b89e
JB
108312011-06-12 Juanma Barranquero <lekktu@gmail.com>
10832
10833 * makefile.w32-in: Update dependencies.
10834 (LISP_H): Add lib/intprops.h.
10835
1100a63c
CY
108362011-06-11 Chong Yidong <cyd@stupidchicken.com>
10837
10838 * image.c (gif_load): Add animation frame delay to the metadata.
10839 (syms_of_image): Use DEFSYM. New symbol `delay'.
10840
6198ccd0
MR
108412011-06-11 Martin Rudalics <rudalics@gmx.at>
10842
10843 * window.c (delete_deletable_window): Re-add.
10844 (Fset_window_configuration): Rewrite to handle dead buffers and
10845 consequently deletable windows.
10846 (window_tree, Fwindow_tree): Remove. Supply functionality in
10847 window.el.
10848 (compare_window_configurations): Simplify code.
10849
b6e3633c
AS
108502011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10851
1ab0dee5
AS
10852 * image.c (imagemagick_load_image): Fix type mismatch.
10853 (Fimagemagick_types): Likewise.
10854
b6e3633c
AS
10855 * window.h (replace_buffer_in_windows): Declare.
10856
9397e56f
MR
108572011-06-11 Martin Rudalics <rudalics@gmx.at>
10858
10859 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10860 Qclone_number. Remove external declaration of Qdelete_window.
10861 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10862 code.
640c8776
SM
10863 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10864 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10865 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10866 buffer list implementation.
10867 (other_buffer_safely): New function.
10868 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10869 calls to replace_buffer_in_windows and
10870 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10871 if allowed.
10872 (record_buffer): Inhibit quitting and rewrite using quittable
10873 functions. Run Qbuffer_list_update_hook if allowed.
10874 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10875 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10876 Move switch-to-buffer to window.el.
9397e56f
MR
10877 (bury-buffer): Move to window.el.
10878 (Vbuffer_list_update_hook): New variable.
10879
10880 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10881 section.
10882
10883 * window.h (resize_frame_windows): Move up in code.
10884 (Fwindow_frame): Remove EXFUN.
10885 (replace_buffer_in_all_windows): Remove prototype.
10886 (replace_buffer_in_windows_safely): Add prototype.
10887
10888 * window.c: Declare Qdelete_window static again. Move down
10889 declaration of select_count.
10890 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10891 (Fother_window): Move to window.el.
10892 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10893 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10894 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10895 window.el.
10896 (replace_buffer_in_windows): Implement by calling
10897 Qreplace_buffer_in_windows.
10898 (replace_buffer_in_all_windows): Remove with some functionality
10899 moved into replace_buffer_in_windows_safely.
10900 (replace_buffer_in_windows_safely): New function.
10901 (select_window_norecord, select_frame_norecord): Move in front
10902 of run_window_configuration_change_hook. Remove now obsolete
10903 declarations.
640c8776
SM
10904 (Fset_window_buffer): Rewrite doc-string.
10905 Call Qrecord_window_buffer.
9397e56f
MR
10906 (keys_of_window): Move binding for other-window to window.el.
10907
b50691aa
CY
109082011-06-11 Chong Yidong <cyd@stupidchicken.com>
10909
10910 * dispextern.h (struct image): Replace data member, whose int_val
10911 and ptr_val fields were not used by anything, with a single
10912 lisp_val object.
10913
10914 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10915 (gif_clear_image, gif_load, imagemagick_load_image)
10916 (gs_clear_image, gs_load): Callers changed.
10917
3f754b86
PE
109182011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10919
cca69397
PE
10920 * buffer.h: Include <time.h>, for time_t.
10921 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10922
109e28d0
PE
10923 Fix minor problems found by static checking.
10924
60737f02
PE
10925 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10926
4b66faf3
PE
10927 Make identifiers static if they are not used in other modules.
10928 * data.c (Qcompiled_function, Qframe, Qvector):
10929 * image.c (QimageMagick, Qsvg):
10930 * minibuf.c (Qmetadata):
10931 * window.c (resize_window_check, resize_root_window): Now static.
10932 * window.h (resize_window_check, resize_root_window): Remove decls.
10933
109e28d0
PE
10934 * window.c (window_deletion_count, delete_deletable_window):
10935 Remove; unused.
46a4ce9e
PE
10936 (window_body_lines): Now static.
10937 (Fdelete_other_windows_internal): Mark vars as initialized.
10938 Make sure 'resize_failed' is initialized.
10939 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10940 (resize_window_apply): Remove unused local.
10941 * window.h (delete_deletable_window): Remove decl.
10942
109e28d0 10943 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10944 (imagemagick_load_image): Fix pointer signedness problem by changing
10945 last arg from unsigned char * to char *. All uses changed.
10946 Also, fix a local for similar reasons.
10947 Remove unused locals. Remove locals to avoid shadowing.
10948 (fn_rsvg_handle_free): Remove; unused.
10949 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10950 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10951
3f754b86
PE
10952 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10953
2547adb1
CY
109542011-06-10 Chong Yidong <cyd@stupidchicken.com>
10955
10956 * image.c (gif_load): Fix omitted cast error introduced by
10957 2011-06-06 change.
10958
2c8e37d4
MR
109592011-06-10 Martin Rudalics <rudalics@gmx.at>
10960
10961 * window.h (resize_proportionally, orig_total_lines)
10962 (orig_top_line): Remove from window structure.
10963 (set_window_height, set_window_width, change_window_heights)
10964 (Fdelete_window): Remove prototypes.
10965 (resize_frame_windows): Remove duplicate declaration.
10966
440a42e3
EZ
109672011-06-10 Eli Zaretskii <eliz@gnu.org>
10968
10969 * window.h (resize_frame_windows, resize_window_check)
10970 (delete_deletable_window, resize_root_window)
10971 (resize_frame_windows): Declare prototypes.
10972
10973 * window.c (resize_window_apply): Make definition be "static" to
10974 match the prototype.
10975
562dd5e9
MR
109762011-06-10 Martin Rudalics <rudalics@gmx.at>
10977
10978 * window.c: Remove declarations of Qwindow_size_fixed,
10979 window_min_size_1, window_min_size_2, window_min_size,
10980 size_window, window_fixed_size_p, enlarge_window, delete_window.
10981 Remove static from declaration of Qdelete_window, it's
10982 temporarily needed by Fbury_buffer.
10983 (replace_window): Don't assign orig_top_line and
10984 orig_total_lines.
10985 (Fdelete_window, delete_window): Remove. Window deletion is
10986 handled by window.el.
640c8776
SM
10987 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10988 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10989 (Fdelete_other_windows): Remove. Deleting other windows is
10990 handled by window.el.
10991 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10992 handled in window.el.
10993 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10994 Window minimum sizes are handled in window.el.
10995 (shrink_windows, size_window, set_window_height)
10996 (set_window_width, change_window_heights, window_height)
10997 (window_width, CURBEG, CURSIZE, enlarge_window)
10998 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10999 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11000 handled in window.el.
11001 (make_dummy_parent): Rename to make_parent_window and give it a
11002 second argument horflag.
11003 (make_window): Don't set resize_proportionally any more.
11004 (Fsplit_window): Remove. Windows are split in window.el.
11005 (save_restore_action, save_restore_orig_size)
11006 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11007 Resize mini windows in window.el.
11008 (grow_mini_window, shrink_mini_window): Implement by calling
11009 Qresize_root_window_vertically, resize_window_check and
11010 resize_window_apply.
640c8776
SM
11011 (saved_window, Fset_window_configuration, save_window_save):
11012 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11013 resize_proportionally.
11014 (window_min_height, window_min_width): Move to window.el.
11015 (keys_of_window): Move bindings for delete-other-windows,
11016 split-window, delete-window and enlarge-window to window.el.
11017
11018 * buffer.c: Temporarily extern Qdelete_window.
11019 (Fbury_buffer): Temporarily call Qdelete_window instead of
11020 Fdelete_window (Fbury_buffer will move to window.el soon).
11021
11022 * frame.c (set_menu_bar_lines_1): Remove code handling
11023 orig_top_line and orig_total_lines.
11024
11025 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11026 set_window_height but set heights directly.
11027 (change_frame_size_1): Use resize_frame_windows.
11028
11029 * xdisp.c (init_xdisp): Don't use set_window_height but set
11030 heights directly.
11031
640c8776
SM
11032 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11033 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11034 run_window_configuration_change_hook.
11035
11036 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11037 instead of change_window_heights and run
11038 run_window_configuration_change_hook.
11039
1a13852e
MR
110402011-06-09 Martin Rudalics <rudalics@gmx.at>
11041
11042 * window.c (replace_window): Rename second argument REPLACEMENT to
11043 NEW. New third argument SETFLAG. Rewrite.
11044 (delete_window, make_dummy_parent): Call replace_window with
11045 third argument 1.
11046 (window_list_1): Move down in code.
11047 (run_window_configuration_change_hook): Move set_buffer part
11048 before select_frame_norecord part in order to unwind correctly.
11049 Rename count1 to count.
11050 (recombine_windows, delete_deletable_window, resize_root_window)
11051 (Fdelete_other_windows_internal)
11052 (Frun_window_configuration_change_hook, make_parent_window)
11053 (resize_window_check, resize_window_apply, Fresize_window_apply)
11054 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11055 (Fdelete_window_internal, Fresize_mini_window_internal):
11056 New functions.
1a13852e
MR
11057 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11058
f3d1777e
MR
110592011-06-08 Martin Rudalics <rudalics@gmx.at>
11060
496e208e
MR
11061 * window.h (window): Add some new members to window structure -
11062 normal_lines, normal_cols, new_total, new_normal, clone_number,
11063 splits, nest, prev_buffers, next_buffers.
11064 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11065 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11066
f3d1777e
MR
11067 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11068 Remove.
496e208e
MR
11069 (make_dummy_parent): Set new members of windows structure.
11070 (make_window): Move down in code. Handle new members of window
11071 structure.
11072 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11073 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11074 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11075 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11076 (Fset_window_next_buffers, Fset_window_clone_number):
11077 New functions.
496e208e
MR
11078 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11079 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11080 Doc-string fixes.
11081 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11082 Argument WINDOW can be now internal window too.
11083 (Fwindow_use_time): Move up in code.
11084 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11085 Rewrite doc-string.
11086 (Fset_window_configuration, saved_window)
11087 (Fcurrent_window_configuration, save_window_save): Handle new
11088 members of window structure.
b9e809c2
MR
11089 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11090 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11091 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11092 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11093 Qget_mru_window, Qresize_root_window,
11094 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11095 Qauto_buffer_name; staticpro them.
f3d1777e 11096
abde8f8c
MR
110972011-06-07 Martin Rudalics <rudalics@gmx.at>
11098
11099 * window.c (Fwindow_total_size, Fwindow_left_column)
11100 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11101 (Fwindow_list_1): New functions.
11102 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11103 (Fwindow_width, Fscroll_left, Fscroll_right):
11104 Use window_body_cols instead of window_box_text_cols.
11105 (delete_window, Fset_window_configuration):
11106 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11107 (delete_all_subwindows): Take a window as argument and not a
11108 structure. Rewrite.
190b47e6
MR
11109 (window_loop): Remove handling of GET_LRU_WINDOW and
11110 GET_LARGEST_WINDOW.
11111 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11112
11113 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11114 window_box_text_cols. delete_all_subwindows now takes a
11115 Lisp_Object as argument.
abde8f8c 11116
640c8776
SM
11117 * indent.c (compute_motion, Fcompute_motion):
11118 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11119
fa8a67e6
MR
11120 * frame.c (delete_frame): Call delete_all_subwindows with root
11121 window as argument.
11122
a54e3482
DC
111232011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11124
11125 * fns.c (Fputhash): Document return value.
11126
60002bf5
CY
111272011-06-06 Chong Yidong <cyd@stupidchicken.com>
11128
11129 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11130
0c671da6 111312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11132
b862a52a 11133 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11134
be44ca6c
PE
11135 Check for overflow when converting integer to cons and back.
11136 * charset.c (Fdefine_charset_internal, Fdecode_char):
11137 Use cons_to_unsigned to catch overflow.
11138 (Fencode_char): Use INTEGER_TO_CONS.
11139 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11140 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11141 * data.c (long_to_cons, cons_to_long): Remove.
11142 (cons_to_unsigned, cons_to_signed): New functions.
11143 These signal an error for invalid or out-of-range values.
11144 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11145 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11146 * font.c (Ffont_variation_glyphs):
11147 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11148 * lisp.h: Include <intprops.h>.
11149 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11150 (cons_to_signed, cons_to_unsigned): New decls.
11151 (long_to_cons, cons_to_long): Remove decls.
11152 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11153 (Fprimitive_undo): Use CONS_TO_INTEGER.
11154 * xfns.c (Fx_window_property): Likewise.
11155 * xselect.c: Include <limits.h>.
11156 (x_own_selection, selection_data_to_lisp_data):
11157 Use INTEGER_TO_CONS.
11158 (x_handle_selection_request, x_handle_selection_clear)
11159 (x_get_foreign_selection, Fx_disown_selection_internal)
11160 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11161 (lisp_data_to_selection_data): Use cons_to_unsigned.
11162 (x_fill_property_data): Use cons_to_signed.
11163 Report values out of range.
11164
d1f3d2af
PE
11165 Check for buffer and string overflow more precisely.
11166 * buffer.h (BUF_BYTES_MAX): New macro.
11167 * lisp.h (STRING_BYTES_MAX): New macro.
11168 * alloc.c (Fmake_string):
11169 * character.c (string_escape_byte8):
11170 * coding.c (coding_alloc_by_realloc):
11171 * doprnt.c (doprnt):
11172 * editfns.c (Fformat):
11173 * eval.c (verror):
11174 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11175 since they may not be the same number.
11176 * editfns.c (Finsert_char):
11177 * fileio.c (Finsert_file_contents):
11178 Likewise for BUF_BYTES_MAX.
11179
dd52fcea
PE
11180 * image.c: Use ptrdiff_t, not int, for sizes.
11181 (slurp_file): Switch from int to ptrdiff_t.
11182 All uses changed.
11183 (slurp_file): Check that file size fits in both size_t (for
11184 malloc) and ptrdiff_t (for sanity and safety).
11185
7f9bbdbb
PE
11186 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11187 if b->modtime has its maximal value.
11188
dfe18f82
PE
11189 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11190
84acfcf0
PE
11191 Don't assume time_t can fit into int.
11192 * buffer.h (struct buffer.modtime): Now time_t, not int.
11193 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11194 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11195
ccd9a01a
PE
11196 Minor fixes for signed vs unsigned integers.
11197 * character.h (MAYBE_UNIFY_CHAR):
11198 * charset.c (maybe_unify_char):
11199 * keyboard.c (read_char, reorder_modifiers):
11200 XINT -> XFASTINT, since the integer must be nonnegative.
11201 * ftfont.c (ftfont_spec_pattern):
11202 * keymap.c (access_keymap, silly_event_symbol_error):
11203 XUINT -> XFASTINT, since the integer must be nonnegative.
11204 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11205 since it makes no difference and we prefer signed.
11206 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11207 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11208 nonnegative.
11209
d6d100dd
SM
112102011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11211
11212 * window.h (Fwindow_frame): Declare.
11213
2b6148e4
PE
112142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11215
11216 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11217 (SPARE_MEMORY): Always define.
11218 (LARGE_REQUEST): Remove.
11219 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11220
f230ecc9
MR
112212011-06-06 Martin Rudalics <rudalics@gmx.at>
11222
727e958e
MR
11223 * lisp.h: Move EXFUNS for Fframe_root_window,
11224 Fframe_first_window and Fset_frame_selected_window to window.h.
11225
11226 * window.h: Move EXFUNS for Fframe_root_window,
11227 Fframe_first_window and Fset_frame_selected_window here from
11228 lisp.h.
11229
11230 * frame.c (Fwindow_frame, Fframe_first_window)
11231 (Fframe_root_window, Fframe_selected_window)
11232 (Fset_frame_selected_window): Move to window.c.
11233 (Factive_minibuffer_window): Move to minibuf.c.
11234 (Fother_visible_frames_p): New function.
11235
11236 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11237
f230ecc9
MR
11238 * window.c (decode_window, decode_any_window): Move up in code.
11239 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11240 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11241 (Fwindow_buffer): Move up and rewrite doc-string.
11242 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11243 (Fwindow_prev): New functions.
727e958e
MR
11244 (Fwindow_frame): Move here from frame.c. Accept any window as
11245 argument.
11246 (Fframe_root_window, Fframe_first_window)
11247 (Fframe_selected_window): Move here from frame.c. Accept frame
11248 or arbitrary window as argument. Update doc-strings.
11249 (Fminibuffer_window): Move up in code.
11250 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11251 (Fset_frame_selected_window): Move here from frame.c.
11252 Marginal rewrite.
727e958e
MR
11253 (Fselected_window, select_window, Fselect_window): Move up in
11254 code. Minor doc-string fixes.
f230ecc9 11255
4d09bcf6
PE
112562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11257
11258 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11259 Do not assume that spare memory exists; that assumption is valid
11260 only if SYSTEM_MALLOC.
11261 (LARGE_REQUEST): New macro, so that the issue of large requests
11262 is separated from the issue of spare memory.
11263
810928a2
AS
112642011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11265
172418ad
AS
11266 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11267 format. (Bug#8806)
11268
43f862f7
AS
11269 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11270
810928a2
AS
11271 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11272 before statements.
11273
a059fe24
JD
112742011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11275
11276 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11277
11278 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11279
11280 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11281 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11282
989bf368
JB
112832011-06-05 Juanma Barranquero <lekktu@gmail.com>
11284
11285 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11286
4b80f674
CY
112872011-06-04 Chong Yidong <cyd@stupidchicken.com>
11288
11289 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11290 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11291 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11292 New error handlers.
4b80f674
CY
11293 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11294 Obey Vx_select_enable_clipboard_manager. Catch errors in
11295 x_clipboard_manager_save (Bug#8779).
11296 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11297 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11298
99a33b77 112992011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11300
11301 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11302
99a33b77 113032011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11304
11305 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11306 in the current matrix if keep_current_p is non-zero.
11307
8264569d
EZ
113082011-06-04 Eli Zaretskii <eliz@gnu.org>
11309
11310 * bidi.c (bidi_level_of_next_char): Fix last change.
11311
57f97249
EZ
113122011-06-03 Eli Zaretskii <eliz@gnu.org>
11313
fec2107c 11314 Support bidi reordering of text covered by display properties.
57f97249 11315
fec2107c
EZ
11316 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11317 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11318 (bidi_cache_search, bidi_cache_iterator_state)
11319 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11320 (bidi_level_of_next_char, bidi_move_to_visually_next):
11321 Support character positions inside a run of characters covered by a
fec2107c
EZ
11322 display string.
11323 (bidi_paragraph_init, bidi_resolve_explicit_1)
11324 (bidi_level_of_next_char): Call bidi_fetch_char and
11325 bidi_fetch_char_advance instead of FETCH_CHAR and
11326 FETCH_CHAR_ADVANCE.
11327 (bidi_init_it): Initialize new members.
11328 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11329 definitions.
11330 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11331 instead of using explicit *_CHAR codes.
d6d100dd
SM
11332 (bidi_resolve_explicit, bidi_resolve_weak):
11333 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11334 bidirectional text is supported only in multibyte buffers.
11335 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11336 it to initialize the frame_window_p member of struct bidi_it.
11337 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11338 (bidi_resolve_explicit, bidi_resolve_weak)
11339 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11340 bidi_it->nchars is non-positive.
11341 (bidi_level_of_next_char): Don't try to lookup the cache for the
11342 next/previous character if nothing is cached there yet, or if we
11343 were just reseat()'ed to a new position.
c40e2fb2 11344
0e14fe90
EZ
11345 * xdisp.c (set_cursor_from_row): Set start and stop points
11346 according to the row's direction when priming the loop that looks
11347 for the glyph on which to display cursor.
11348 (single_display_spec_intangible_p): Function deleted.
11349 (display_prop_intangible_p): Reimplement to call
11350 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11351 Accept 3 additional arguments needed by handle_display_spec.
11352 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11353 values: lists, `(when COND...)' forms, etc.
11354 (single_display_spec_string_p): Support property values that are
11355 lists with the argument STRING its top-level element.
11356 (display_prop_string_p): Fix the condition for processing a
11357 property that is a list to be consistent with handle_display_spec.
fec2107c 11358 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11359 last portion of handle_display_prop.
11360 (compute_display_string_pos): Accept additional argument
11361 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11362 value of a `display' property is a "replacing spec".
11363 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11364 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11365 the display property, but just return a value indicating whether
11366 the display property will replace the characters it covers.
11367 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11368 frame_window_p members of struct bidi_it.
d6d100dd
SM
11369 (compute_display_string_pos, compute_display_string_end):
11370 New functions.
fec2107c
EZ
11371 (push_it): Accept second argument POSITION, where pop_it should
11372 jump to continue iteration.
11373 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11374
fec2107c
EZ
11375 * keyboard.c (adjust_point_for_property): Adjust the call to
11376 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11377
11378 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11379 (bidi_init_it): Update prototypes.
11380 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11381 (compute_display_string_pos, compute_display_string_end):
11382 Declare prototypes.
fec2107c
EZ
11383 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11384 EMACS_INT.
fc6f18ce 11385
40087514 113862011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11387
57f53182
PE
11388 Malloc failure behavior now depends on size of allocation.
11389 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11390 * lisp.h: Change signatures accordingly.
11391 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11392 All callers changed. (Bug#8762)
11393
11394 * gnutls.c: Use Emacs's memory allocators.
11395 Without this change, the gnutls library would invoke malloc etc.
11396 directly, which causes problems on non-SYNC_INPUT hosts, and which
11397 runs afoul of improving memory_full behavior. (Bug#8761)
11398 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11399 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11400 xfree instead of the default malloc, realloc, free.
11401 (Fgnutls_boot): No need to check for memory allocation failure,
11402 since xmalloc does that for us.
11403
ac32cd99 11404 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11405 * category.c (hash_get_category_set):
11406 * ccl.c (ccl_driver):
11407 * charset.c (Fdefine_charset_internal):
11408 * charset.h (struct charset.hash_index):
11409 * composite.c (get_composition_id, gstring_lookup_cache)
11410 (composition_gstring_put_cache):
11411 * composite.h (struct composition.hash_index):
11412 * dispextern.h (struct image.hash):
11413 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11414 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11415 (hashfn_equal, hashfn_user_defined, make_hash_table)
11416 (maybe_resize_hash_table, hash_lookup, hash_put)
11417 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11418 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11419 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11420 * image.c (make_image, search_image_cache, lookup_image)
11421 (xpm_put_color_table_h):
11422 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11423 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11424 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11425 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11426 * alloc.c (allocate_vectorlike):
11427 Check for overflow in vector size calculations.
11428 * ccl.c (ccl_driver):
11429 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11430 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11431 need to be updated by these changes.
40087514
PE
11432 * fns.c (make_hash_table, maybe_resize_hash_table):
11433 Check for integer overflow with large hash tables.
0de4bb68
PE
11434 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11435 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11436 (SXHASH_REDUCE): New macro.
11437 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11438 Use it instead of discarding useful hash info with large hash values.
11439 (sxhash_float): New function.
11440 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11441 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11442 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11443 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11444 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11445 Adjust signatures to match updated version of code.
11446 (consing_since_gc): Now EMACS_INT, since a single hash table can
11447 use more than INT_MAX bytes.
11448
698d32e2
DN
114492011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11450
11451 Make it possible to build with GCC-4.6+ -O2 -flto.
11452
11453 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11454
fd6fa53f
SM
114552011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11456
11457 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11458 Call minibuffer-inactive-mode.
11459
864db017
JB
114602011-05-31 Juanma Barranquero <lekktu@gmail.com>
11461
11462 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11463 Update dependencies.
11464
2ad0baf4
DN
114652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11466
11467 * data.c (init_data): Remove code for UTS, this system is not
11468 supported anymore.
11469
4fcc2638
DN
114702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11471
11472 Don't force ./temacs to start in terminal mode.
11473
11474 * frame.c (make_initial_frame): Initialize faces in all cases, not
11475 only when CANNOT_DUMP is defined.
11476 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11477
c56e0fd5
DN
114782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11479
11480 * dispnew.c (add_window_display_history): Use const for the string
11481 pointer. Remove declaration, not needed.
11482
333d54da 114832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11484
55d4c1b2 11485 Use 'inline', not 'INLINE'.
333d54da 11486 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11487 * alloc.c, fontset.c (INLINE): Remove.
11488 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11489 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11490 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11491 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11492 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11493
738db178
DN
114942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11495
11496 Make it possible to run ./temacs.
11497
11498 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11499 syms_of_callproc does the same thing. Remove test for
11500 "initialized", do it in the caller.
11501 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11502
620c53a6
SM
115032011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11504
11505 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11506 (read_minibuf): Use get_minibuffer.
11507 (syms_of_minibuf): Use DEFSYM.
11508 (Qmetadata): New var.
11509 * data.c (Qbuffer): Don't make it static.
11510 (syms_of_data): Use DEFSYM.
11511
e003a292
PE
115122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11513
11514 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11515 (CCL_CODE_MIN): New macro.
11516
ed008a6d
PE
115172011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11518
3687c2ef
PE
11519 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11520
ed008a6d
PE
11521 * eval.c (Qdebug): Now static.
11522 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11523 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11524 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11525
d66c4c7c
CY
115262011-05-29 Chong Yidong <cyd@stupidchicken.com>
11527
11528 * image.c: Various fixes to ImageMagick code comments.
11529 (Fimagemagick_types): Doc fix.
11530
5fbc2025
PE
115312011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11532
0196f88a
PE
11533 Minor fixes prompted by GCC 4.6.0 warnings.
11534
11535 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11536
5fbc2025
PE
11537 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11538 (x_clipboard_manager_save_all): Move extern decl to ...
11539 * xterm.h: ... here, so that it can be checked for consistency.
11540
1dd3c2d9
CY
115412011-05-29 Chong Yidong <cyd@stupidchicken.com>
11542
11543 * xselect.c (x_clipboard_manager_save_frame)
11544 (x_clipboard_manager_save_all): New functions.
11545 (Fx_clipboard_manager_save): Lisp function deleted.
11546
11547 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11548 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11549
11550 * xterm.h: Update prototype.
11551
5ba6571d
WX
115522011-05-28 William Xu <william.xwl@gmail.com>
11553
11554 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11555 exiting (Bug#8239).
11556
3eaff834
JM
115572011-05-28 Jim Meyering <meyering@redhat.com>
11558
e1900994 11559 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11560 * fns.c (to_uchar): Define.
11561 (crypto_hash_function): Use it to convert some newly-signed
11562 variables to unsigned, to avoid sign-extension bugs. For example,
11563 without this change, (md5 "truc") would evaluate to
11564 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11565 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11566 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11567
0f6990a7
PE
115682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11569
11570 Integer overflow fixes.
c8a9ca5a 11571
08686060
PE
11572 * dbusbind.c: Serial number integer overflow fixes.
11573 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11574 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11575 to hold a serial number that is too large for a fixnum.
11576 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11577 Check for serial numbers out of range. Decode any serial number
59568bf0 11578 that was so large that it became a float. (Bug#8722)
08686060 11579
2d1fc3c7
PE
11580 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11581 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11582 Use XFASTINT rather than XUINT when numbers are nonnegative.
11583 (xd_append_arg, Fdbus_method_return_internal):
11584 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11585 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11586 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11587 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11588 (Bug#8722)
2d1fc3c7 11589
c8a9ca5a
PE
11590 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11591
519e1d69
PE
11592 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11593
6df6ae42 11594 ccl: Add integer overflow checks.
30569699
PE
11595 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11596 (IN_INT_RANGE): New macros.
11597 (ccl_driver): Use them to check for integer overflow when
11598 decoding a CCL program. Many of the new checks are whether XINT (x)
11599 fits in int; it doesn't always, on 64-bit hosts. The new version
11600 doesn't catch all possible integer overflows, but it's an
847044ea 11601 improvement. (Bug#8719)
30569699 11602
c11285dc
PE
11603 * alloc.c (make_event_array): Use XINT, not XUINT.
11604 There's no need for unsigned here.
11605
fdccd48e
PE
11606 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11607 This follows up to the 2011-05-06 change that substituted uintptr_t
11608 for EMACS_INT. This case wasn't caught back then.
11609
37910ab2
PE
11610 Rework Fformat to avoid integer overflow issues.
11611 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11612 now (part of C89). Include <verify.h>.
11613 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11614 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11615 (Fformat): Avoid the prepass trying to compute sizes; it was only
11616 approximate and thus did not catch overflow reliably. Instead, walk
11617 through the format just once, formatting and computing sizes as we go,
11618 checking for integer overflow at every step, and allocating a larger
11619 buffer as needed. Keep track separately whether the format is
11620 multibyte. Keep only the most-recently calculated precision, rather
11621 than them all. Record whether each argument has been converted to
11622 string. Use EMACS_INT, not int, for byte and char and arg counts.
11623 Support field widths and precisions larger than INT_MAX. Avoid
11624 sprintf's undefined behavior with conversion specifications such as %#d
11625 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11626 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11627 formatting out-of-range floating point numbers with int
9173deec 11628 formats. (Bug#8668)
37910ab2 11629
2e6578fb
PE
11630 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11631
0ae6bdee
PE
11632 * data.c: Avoid integer truncation in expressions involving floats.
11633 * data.c: Include <intprops.h>.
11634 (arith_driver): When there's an integer overflow in an expression
11635 involving floating point, convert the integers to floating point
11636 so that the resulting value does not suffer from catastrophic
11637 integer truncation. For example, on a 64-bit host (* 4
11638 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11639 Do not rely on undefined behavior after integer overflow.
11640
de883a70
PE
11641 merge count_size_as_multibyte, parse_str_to_multibyte
11642 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11643 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11644 Check for integer overflow.
11645 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11646 since it's now a duplicate of the other. This is more of
11647 a character than a buffer op, so better that it's in character.c.
11648 * fns.c, print.c: Adjust to above changes.
11649
2ff916cb
PE
116502011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11651
11652 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11653
f1b54466
PE
116542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11655
fb1ac845
PE
11656 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11657 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11658 (x_clipboard_manager_save): Now static.
11659 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11660
f1b54466
PE
11661 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11662 (crypto_hash_function): Now static.
11663 Fix pointer signedness problems. Avoid unnecessary initializations.
11664
a9f737ee
CY
116652011-05-27 Chong Yidong <cyd@stupidchicken.com>
11666
11667 * termhooks.h (Vselection_alist): Make it terminal-local.
11668
11669 * terminal.c (create_terminal): Initialize it.
11670
11671 * xselect.c: Support for clipboard managers.
11672 (Vselection_alist): Move to termhooks.h as terminal-local var.
11673 (LOCAL_SELECTION): New macro.
11674 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11675 (symbol_to_x_atom): Remove gratuitous arg.
11676 (x_handle_selection_request, lisp_data_to_selection_data)
11677 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11678 (x_own_selection, x_get_local_selection, x_convert_selection):
11679 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11680 (some_frame_on_display): Delete unused function.
11681 (Fx_own_selection_internal, Fx_get_selection_internal)
11682 (Fx_disown_selection_internal, Fx_selection_owner_p)
11683 (Fx_selection_exists_p): New optional frame arg.
11684 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11685 (x_handle_selection_clear): Don't treat other terminals with the
11686 same keyboard specially. Use the terminal-local Vselection_alist.
11687 (x_clear_frame_selections): Use Frun_hook_with_args.
11688
11689 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11690
11691 * xterm.h: Add support for those atoms.
11692
e067f0c1
CY
116932011-05-26 Chong Yidong <cyd@stupidchicken.com>
11694
11695 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11696 (converted_selections, conversion_fail_tag): New global variables.
11697 (x_selection_request_lisp_error): Free the above.
11698 (x_get_local_selection): Remove unnecessary code.
11699 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11700 of converted selections stored in converted_selections.
11701 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11702 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11703 (x_convert_selection): New function.
11704 (x_handle_selection_event): Simplify.
11705 (x_get_foreign_selection): Don't ignore incoming requests while
11706 waiting for an answer; this will fail when we implement
11707 SAVE_TARGETS, and seems unnecessary anyway.
11708 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11709 (Vx_sent_selection_functions): Doc fix.
11710
0f4aebc0
LL
117112011-05-26 Leo Liu <sdl.web@gmail.com>
11712
11713 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11714
e61124cd
YM
117152011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11716
11717 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11718
11719 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11720 for fringe update if it has periodic bitmap.
ac389d0c 11721 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11722 and fringe_bitmap_periodic_p.
11723
11724 * fringe.c (get_fringe_bitmap_data): New function.
11725 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11726 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11727 row. Mark glyph row for fringe update if periodicity changed.
11728
11729 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11730 for fringe update unless it has periodic bitmap.
11731
f16d9837
KH
117322011-05-25 Kenichi Handa <handa@m17n.org>
11733
11734 * xdisp.c (get_next_display_element): Set correct it->face_id for
11735 a static composition.
11736
e1b90ef6
LL
117372011-05-24 Leo Liu <sdl.web@gmail.com>
11738
11739 * deps.mk (fns.o):
11740 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11741
11742 * fns.c (crypto_hash_function, Fsha1): New function.
11743 (Fmd5): Use crypto_hash_function.
11744 (syms_of_fns): Add Ssha1.
11745
7400048f
PE
117462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11747
11748 * gnutls.c: Remove unused macros.
11749 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11750 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11751 Remove macros that are defined and never used.
11752 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11753
abb71cf4
CY
117542011-05-22 Chong Yidong <cyd@stupidchicken.com>
11755
11756 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11757 (Fx_get_selection_internal): Minor cleanup.
11758 (Fx_own_selection_internal): Rename arguments for consistency with
11759 select.el.
11760
6307db39
PE
117612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11762
11763 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11764
f3d4e0a4
CY
117652011-05-22 Chong Yidong <cyd@stupidchicken.com>
11766
11767 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11768
4d8ade89
YM
117692011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11770
11771 * dispnew.c (scrolling_window): Don't exclude the case that the
11772 last enabled row in the desired matrix touches the bottom boundary.
11773
32078c8d
GM
117742011-05-21 Glenn Morris <rgm@gnu.org>
11775
11776 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11777 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11778 and add some more files.
32078c8d 11779
7285dc67
EZ
117802011-05-20 Eli Zaretskii <eliz@gnu.org>
11781
11782 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11783 report_file_error introduced by the change from 2011-05-07.
11784
89d1bd22
PE
117852011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11786
11787 * systime.h (Time): Define only if emacs is defined.
11788 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11789 where the include path doesn't have X11/X.h by default. See
11790 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11791
cd394be1 117922011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11793
11794 * composite.c (find_automatic_composition): Fix previous change.
11795
b9704ad9
GM
117962011-05-20 Glenn Morris <rgm@gnu.org>
11797
11798 * lisp.mk: New file, split from Makefile.in.
11799 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11800 (shortlisp): Remove.
11801 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11802
4a720484
GM
118032011-05-19 Glenn Morris <rgm@gnu.org>
11804
11805 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11806 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11807 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11808 (lisp): Set the order to that of loadup.el.
11809 (shortlisp): Make it a copy of $lisp.
11810 (SOME_MACHINE_LISP): Remove.
11811 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11812 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11813
a28d4396
KH
118142011-05-18 Kenichi Handa <handa@m17n.org>
11815
11816 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11817 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11818 (find_automatic_composition): Mostly rewrite for efficiency.
11819
a2b1fa8e
JB
118202011-05-18 Juanma Barranquero <lekktu@gmail.com>
11821
11822 * makefile.w32-in: Update dependencies.
11823
8e1f5610
CS
118242011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11825
11826 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11827 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11828
7025ee00 118292011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11830
cdfa6eab
PE
11831 Fix some integer overflow issues, such as string length overflow.
11832
06d6db33
PE
11833 * insdel.c (count_size_as_multibyte): Check for string overflow.
11834
2b4560a8
PE
11835 * character.c (lisp_string_width): Check for string overflow.
11836 Use EMACS_INT, not int, for string indexes and lengths; in
11837 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11838 the resulting string length overflows an EMACS_INT; instead,
11839 report a string overflow if no precision given. When checking for
11840 precision exhaustion, use a check that cannot possibly have
11841 integer overflow. (Bug#8675)
11842 * character.h (lisp_string_width): Adjust to new signature.
11843
cb93f9be
PE
11844 * alloc.c (string_overflow): New function.
11845 (Fmake_string): Use it. This doesn't change behavior, but saves
11846 a few bytes and will simplify future changes.
11847 * character.c (string_escape_byte8): Likewise.
11848 * lisp.h (string_overflow): New decl.
11849
1a1f3366
PE
11850 Fixups, following up to the user-interface timestamp change.
11851 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11852 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11853 * msdos.c (mouse_get_pos): Likewise.
11854 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11855 * w32gui.h (Time): Define by including "systime.h" rather than by
11856 declaring it ourselves. (Bug#8664)
11857
d4e3e4d3
PE
11858 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11859 * image.c (clear_image_cache): Likewise.
11860
f6a24d19
PE
11861 * term.c (term_mouse_position): Don't assume time_t wraparound.
11862
08dc5ae6
PE
11863 Be more systematic about user-interface timestamps.
11864 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11865 and sometimes 'EMACS_UINT', to represent these timestamps.
11866 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11867 This makes the code easier to follow, and makes it easier to catch
11868 integer overflow bugs such as Bug#8664.
11869 * frame.c (Fmouse_position, Fmouse_pixel_position):
11870 Use Time, not unsigned long, for user-interface timestamps.
11871 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11872 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11873 * keyboard.h (last_event_timestamp): Likewise.
11874 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11875 * menu.h (xmenu_show): Likewise.
11876 * term.c (term_mouse_position): Likewise.
11877 * termhooks.h (struct input_event.timestamp): Likewise.
11878 (struct terminal.mouse_position_hook): Likewise.
11879 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11880 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11881 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11882 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11883 what it was before.
11884 * menu.h, termhooks.h: Include "systime.h", for Time.
11885
8e55734a
PE
11886 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11887 Don't assume that the difference between two unsigned long values
11888 can fit into an integer. At this point, we know button_down_time
11889 <= event->timestamp, so the difference must be nonnegative, so
11890 there's no need to cast the result if double-click-time is
11891 nonnegative, as it should be; check that it's nonnegative, just in
11892 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11893 apart (about 25 days). (Bug#8664)
8e55734a 11894
841f1b75 11895 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11896 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11897
3e26f69c
PE
11898 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11899 that always fit in int. Use a sentinel instead of a counter, to
11900 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11901 * frame.h (struct frame): Use int for menu_bar_items_used
11902 instead of EMACS_INT, since it always fits in int.
3e26f69c 11903
5cc152c0
PE
11904 * menu.c (grow_menu_items): Check for int overflow.
11905
d89eb65e
PE
11906 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11907
5235bd3e
PE
11908 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11909 Before, the code was not consistent. These values cannot exceed
11910 2**31 - 1 so there's no need to make them unsigned.
11911 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11912 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11913 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11914 as modifiers.
11915 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11916
bc827e23
PE
11917 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11918 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11919 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11920 presumably because the widths might not match.
11921
78eb494e
PE
11922 * window.c (size_window): Avoid needless test at loop start.
11923
04f2d78b
CB
119242011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11925
11926 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11927
d2fc7e3d 119282011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11929
11930 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11931
d2fc7e3d 119322011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11933
11934 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11935 `width' to `bar_area_x' and `bar_area_width', respectively.
11936 (x_scroll_run): Take account of fringe background extension.
11937
04f2d78b
CB
11938 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11939 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11940 `bar_area_width', respectively.
11941 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11942 background extension.
11943
79b70037
GM
119442011-05-10 Jim Meyering <meyering@redhat.com>
11945
11946 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11947
2f142cc5
JB
119482011-05-10 Juanma Barranquero <lekktu@gmail.com>
11949
11950 * image.c (Finit_image_library): Return t for built-in image types,
11951 like pbm and xbm. (Bug#8640)
11952
57679c86
AS
119532011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11954
11955 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11956
888c9e86
EZ
119572011-05-07 Eli Zaretskii <eliz@gnu.org>
11958
b0512a1d
EZ
11959 * w32console.c (Fset_screen_color): Doc fix.
11960 (Fget_screen_color): New function.
11961 (syms_of_ntterm): Defsubr it.
11962
7285dc67
EZ
11963 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11964 unlink the temporary file if Fcall_process didn't create it in the
11965 first place.
11966 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11967 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11968 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11969 cue to call_process_cleanup not to close that handle.
11970
4d3fcc8e
BK
119712011-05-07 Ben Key <bkey76@gmail.com>
11972
11973 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11974 one of two shell specific rules, either bootstrap-temacs-CMD or
11975 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11976 to the previous implementation of the bootstrap-temacs rule.
11977 The bootstrap-temacs-CMD rule is similar to the previous
11978 implementation of the bootstrap-temacs rule except that it
11979 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11980 variable.
11981
11982 These changes, along with some changes to nt/configure.bat,
11983 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11984 earlier fix to add support for --cflags and --ldflags options
11985 that include quotes so that it works whether make uses cmd or
11986 sh as the shell.
11987
b4289b64
MA
119882011-05-06 Michael Albinus <michael.albinus@gmx.de>
11989
11990 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11991 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11992 is a constant.
11993 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11994 a string. Handle both cases.
11995 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11996 (Fdbus_register_method): Use Qinvalid_function.
11997
af4c0e28
JB
119982011-05-06 Juanma Barranquero <lekktu@gmail.com>
11999
12000 * makefile.w32-in: Update dependencies.
12001 (LISP_H): Add inttypes.h and stdin.h.
12002 (PROCESS_H): Add unistd.h.
12003
c51453d9
EZ
120042011-05-06 Eli Zaretskii <eliz@gnu.org>
12005
12006 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12007 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12008
8ff0ac3c 120092011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12010
4c4b566b
PE
12011 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12012
aab2b9b5
PE
12013 * term.c (vfatal): Remove stray call to va_end.
12014 It's not needed and the C Standard doesn't allow it here anyway.
12015
c378da0b
PE
12016 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12017 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12018
288b08c7
PE
12019 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12020 bytes.
12021
e3601888
PE
12022 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12023
db6c0e74
PE
12024 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12025
dd5963ea
PE
12026 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12027
88c9450f
PE
12028 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12029
2f9442b8
PE
12030 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12031
c032b5f8
PE
12032 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12033 * charset.c (Fdefine_charset_internal): Don't initialize
12034 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12035 32-bit int (Bug#8600).
a108c10b
PE
12036
12037 * lread.c (read_integer): Be more consistent with string-to-number.
12038 Use string_to_number to do the actual conversion; this avoids
12039 rounding errors and fixes some other screwups. Without this fix,
12040 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12041 (digit_to_number): Move earlier, for benefit of read_integer.
12042 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12043 not a digit in any supported base. (Bug#8602)
a108c10b 12044
ad5f9eea
PE
12045 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12046
aec1708a
PE
12047 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12048 to match comment at start of function. This also removes a
12049 GCC warning about overflow in a 32+64-bit port.
12050
47be4ab5
PE
12051 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12052
371cac43
PE
12053 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12054 Reported by Stefan Monnier in
12055 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12056 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12057 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12058
d01a7826
PE
12059 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12060 (EMACS_UINTPTR): Likewise, with uintptr_t.
12061
7fd47d5c
PE
12062 * lisp.h: Prefer 64-bit EMACS_INT if available.
12063 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12064 on 32-bit hosts that have 64-bit int, so that they can access
12065 large files.
122b0c86
PE
12066 However, temporarily disable this change unless the temporary
12067 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12068
8727937b
PE
12069 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12070
8ac068ac
PE
12071 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12072 This removes an assumption that EMACS_INT and long are the same
12073 width as pointers. The assumption is true for Emacs porting targets
12074 now, but we want to make other targets possible.
12075 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12076 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12077 In the rest of the code, change types of integers that hold casted
12078 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12079 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12080 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12081 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12082 No need to cast type when ORing.
12083 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12084 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12085 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12086 assume EMACS_INT is the same width as char *.
12087 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12088 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12089 Remove no-longer-needed casts.
12090 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12091 (xg_tool_bar_help_callback, xg_make_tool_item):
12092 Use EMACS_INTPTR to hold an integer
12093 that will be cast to void *; this can avoid a GCC warning
12094 if EMACS_INT is not the same width as void *.
12095 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12096 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12097 (current_message_1, set_message_1):
12098 Use a local to convert to proper width without a cast.
12099 * xmenu.c (dialog_selection_callback): Likewise.
12100
ede49d71
PE
12101 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12102 Also, don't assume VALBITS / RAND_BITS is less than 5,
12103 and don't rely on undefined behavior when shifting a 1 left into
12104 the sign bit.
12105 * lisp.h (get_random): Change signature to match.
12106
2f30ecd0
PE
12107 * lread.c (hash_string): Use size_t, not int, for hash computation.
12108 Normally we prefer signed values; but hashing is special, because
12109 it's better to use unsigned division on hash table sizes so that
12110 the remainder is nonnegative. Also, size_t is the natural width
12111 for hashing into memory. The previous code used 'int', which doesn't
12112 retain enough info to hash well into very large tables.
12113 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12114
2a866e7b
PE
12115 * dbusbind.c: Don't possibly lose pointer info when converting.
12116 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12117 Use XPNTR rather than XHASH, so that the high-order bits of
12118 the pointer aren't lost when converting through void *.
12119
51639eac
PE
12120 * eval.c (Fautoload): Don't double-shift a pointer.
12121
92394119
PE
12122 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12123
dbdb9a7c
JB
121242011-05-06 Juanma Barranquero <lekktu@gmail.com>
12125
12126 * gnutls.c (DEF_GNUTLS_FN):
12127 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12128
db7a0b4f
AS
121292011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12130
12131 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12132 marker. (Bug#8610)
12133
cd394be1 121342011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12135
12136 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12137 New version that can reserve upto 2GB of heap space.
12138
f7ff1b0f 121392011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12140
12141 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12142
639c109b
TZ
121432011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12144
12145 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12146 `gnutls_certificate_set_x509_key_file'.
12147
d2127135
JB
121482011-05-05 Juanma Barranquero <lekktu@gmail.com>
12149
12150 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12151 Update dependencies.
12152
e968f4f3
JB
121532011-05-04 Juanma Barranquero <lekktu@gmail.com>
12154
12155 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12156 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12157 Remove unused parameter `fildes'.
12158 * process.c (read_process_output, send_process): Don't pass it.
12159
84d358f0
JB
121602011-05-04 Juanma Barranquero <lekktu@gmail.com>
12161
12162 Fix previous change: the library cache is defined in w32.c.
12163 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12164 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12165
0898ca10
JB
121662011-05-04 Juanma Barranquero <lekktu@gmail.com>
12167
12168 Implement dynamic loading of GnuTLS on Windows.
12169
12170 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12171 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12172 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12173 Declare.
12174
12175 * gnutls.c (Qgnutls_dll): Define.
12176 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12177 (gnutls_*): Declare function pointers.
12178 (init_gnutls_functions): New function to initialize function pointers.
12179 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12180 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12181 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12182 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12183 (emacs_gnutls_write, emacs_gnutls_read)
12184 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12185 (Fgnutls_available_p): New function.
12186 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12187 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12188 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12189
12190 * image.c: Include w32.h.
12191 (Vimage_type_cache): Delete.
12192 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12193 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12194 (w32_delayed_load): Move to w32.c.
12195
12196 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12197
12198 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12199 (w32_delayed_load): Move from image.c. When loading a library, record
12200 its filename in the :loaded-from property of the library id.
12201 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12202 Initialize and staticpro them.
12203 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12204
12205 * process.c: Include lisp.h before w32.h, not after.
12206 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12207 instead of gnutls_record_check_pending.
12208
12209 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12210
ff4de4aa
TZ
122112011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12212
12213 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12214 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12215 as passed in.
12216
abe95abb
JD
122172011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12218
12219 * xterm.c (x_set_frame_alpha): Do not set property on anything
12220 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12221
e16e55d4
JB
122222011-05-02 Juanma Barranquero <lekktu@gmail.com>
12223
12224 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12225
bafcf6a5
JB
122262011-05-02 Juanma Barranquero <lekktu@gmail.com>
12227
12228 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12229 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12230 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12231 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12232 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12233 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12234 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12235 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12236 (Qgnutls_bootprop_callbacks_verify): Make static.
12237
e7a6747f
AS
122382011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12239
19ed11ba
AS
12240 * callproc.c: Indentation fixup.
12241
e7a6747f 12242 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12243 (wait_for_termination, interruptible_wait_for_termination):
12244 Move after wait_for_termination_1.
e7a6747f 12245
1ef14cb4
LMI
122462011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12247
12248 * sysdep.c (interruptible_wait_for_termination): New function
12249 which is like wait_for_termination, but allows keyboard
12250 interruptions.
12251
12252 * callproc.c (Fcall_process): Add (:file "file") as an option for
12253 the STDOUT buffer.
12254 (Fcall_process_region): Ditto.
12255
330d880c
EZ
122562011-04-30 Eli Zaretskii <eliz@gnu.org>
12257
8db90b73
EZ
12258 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12259 rather than `XVECTOR (FOO)->size'.
12260
330d880c
EZ
12261 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12262 inttypes.h, as a gnulib replacement is used if it not available in
12263 system headers.
12264
15cbd324
EZ
122652011-04-21 Eli Zaretskii <eliz@gnu.org>
12266
12267 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12268 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12269 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12270
12271 * coding.c (coding_alloc_by_realloc): Error out if destination
12272 will grow beyond MOST_POSITIVE_FIXNUM.
12273 (decode_coding_emacs_mule): Abort if there isn't enough place in
12274 charbuf for the composition carryover bytes. Reserve an extra
12275 space for up to 2 characters produced in a loop.
12276 (decode_coding_iso_2022): Abort if there isn't enough place in
12277 charbuf for the composition carryover bytes.
12278
122792011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12280
ae940cca
EZ
12281 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12282 aborting when %lld or %lll format is passed.
12283 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12284 %llo or %llx format is passed. (Bug#8545)
12285
03ab8921
EZ
12286 * window.c (window_scroll_line_based): Use a marker instead of
12287 simple variables to record original value of point. (Bug#7952)
12288
afda1437
EZ
12289 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12290 produced by %s or %c overflows available buffer space. (Bug#8545)
12291
f76dee0c
PE
122922011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12293
12294 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12295 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12296
fdc5744d
JB
122972011-04-28 Juanma Barranquero <lekktu@gmail.com>
12298
12299 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12300
638f053a
JB
123012011-04-28 Juanma Barranquero <lekktu@gmail.com>
12302
12303 * keyboard.c (Qdelayed_warnings_hook): Define.
12304 (command_loop_1): Run `delayed-warnings-hook'
12305 if Vdelayed_warnings_list is non-nil.
12306 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12307 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12308
d178f871
EZ
123092011-04-28 Eli Zaretskii <eliz@gnu.org>
12310
12311 * doprnt.c (doprnt): Don't return value smaller than the buffer
12312 size if the message was truncated. (Bug#8545).
12313
b124fd93
JB
123142011-04-28 Juanma Barranquero <lekktu@gmail.com>
12315
12316 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12317 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12318
e810457d
PE
123192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12320
12321 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12322
ea51cceb
JB
123232011-04-27 Juanma Barranquero <lekktu@gmail.com>
12324
12325 * makefile.w32-in: Update dependencies.
12326
94dcfacf
EZ
123272011-04-27 Eli Zaretskii <eliz@gnu.org>
12328
12329 Improve `doprnt' and its usage. (Bug#8545)
12330 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12331 `format_end'. Remove support for %l as a conversion specifier.
12332 Don't use xrealloc. Improve diagnostics when the %l size modifier
12333 is used. Update the commentary.
12334
12335 * eval.c (verror): Simplify calculation of size_t.
12336
12337 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12338 messages.
12339
f61f41d7
PE
123402011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12341
12342 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12343 change.
12344
96fb4434
PE
123452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12346
12347 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12348 This makes this file independent of the recent pseudovector change.
12349
671875da 123502011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12351
69e9b5a3
PE
12352 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12353
b5f869a7 12354 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12355 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12356 Remove unused local.
c8926152 12357 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12358
841a1577 12359 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12360 GCC 4.6.0 optimizes based on type-based alias analysis.
12361 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12362 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12363 != &v->size, and therefore "v->size = 1; b->size = 2; return
12364 v->size;" must therefore return 1. This assumption is incorrect
12365 for Emacs, since it type-puns struct Lisp_Vector * with many other
12366 types. To fix this problem, this patch adds a new type struct
f904488f 12367 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12368 and pseudovectors, and helps optimizing compilers not get fooled
12369 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12370 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12371 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12372 the size member.
eab3844f
PE
12373 (XSETPVECTYPE): Rewrite in terms of new macro.
12374 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12375 This is a bit clearer, and further avoids the possibility of
12376 undesirable aliasing.
12377 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12378 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12379 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12380 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12381 (ASIZE): Now uses header.size rather than size.
12382 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12383 to avoid the hassle of writing XVECTOR (foo)->header.size.
12384 (struct vectorlike_header): New type.
eab3844f
PE
12385 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12386 object, to help avoid aliasing.
12387 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12388 (SUBRP): Likewise, since Lisp_Subr is a special case.
12389 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12390 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12391 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12392 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12393 changed to be "header.size" and "header.next".
12394 * buffer.h (struct buffer): Likewise.
12395 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12396 * frame.h (struct frame): Likewise.
12397 * process.h (struct Lisp_Process): Likewise.
12398 * termhooks.h (struct terminal): Likewise.
12399 * window.c (struct save_window_data, struct saved_window): Likewise.
12400 * window.h (struct window): Likewise.
12401 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12402 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12403 * buffer.c (init_buffer_once): Likewise.
12404 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12405 special case.
12406 * process.c (Fformat_network_address): Use local var for size,
12407 for brevity.
12408
0df1eac5
PE
12409 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12410
847ab9d1 12411 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12412 * data.c (atof): Remove decl; no longer used or needed.
12413 (digit_to_number): Move to lread.c.
12414 (Fstring_to_number): Use new string_to_number function, to be
12415 consistent with how the Lisp reader treats infinities and NaNs.
12416 Do not assume that floating-point numbers represent EMACS_INT
12417 without losing information; this is not true on most 64-bit hosts.
12418 Avoid double-rounding errors, by insisting on integers when
12419 parsing non-base-10 numbers, as the documentation specifies.
12420 * lisp.h (string_to_number): New decl, replacing ...
12421 (isfloat_string): Remove.
bc0a5c13 12422 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12423 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12424 appears to have been a coding error. Similarly, do not accept
12425 strings like +-1e0 as floating point numbers. Do not report
12426 overflow for integer overflows unless the base is not 10 which
12427 means we have no simple and reliable way to continue.
12428 Break out the floating-point parsing into a new
12429 function string_to_number, so that Fstring_to_number parses
12430 floating point numbers consistently with the Lisp reader.
04f2d78b 12431 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12432 (E_CHAR, EXP_INT): Remove, replacing with ...
12433 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12434 (string_to_number): New function, replacing isfloat_string.
12435 This function checks for valid syntax and produces the resulting
12436 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12437 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12438 so that overflow for non-base-10 numbers is reported only when
12439 there's no portable and simple way to convert to floating point.
452f4150 12440
67769ffc
PE
12441 * textprop.c (set_text_properties_1): Rewrite for clarity,
12442 and to avoid GCC warning about integer overflow.
12443
c20db43f
PE
12444 * intervals.h (struct interval): Use EMACS_INT for members
12445 where EMACS_UINT might cause problems. See
12446 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12447 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12448 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12449 All uses changed.
37aa2f85
PE
12450 (offset_intervals): Tell GCC not to worry about length overflow
12451 when negating a negative length.
c20db43f 12452
2538aa2f
PE
12453 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12454 (overrun_check_free): Likewise.
12455
f2d3008d
PE
12456 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12457 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12458 word size.
12459
ec8df744
PE
12460 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12461 (gnutls_make_error): Rename local to avoid shadowing.
12462 (gnutls_emacs_global_deinit): ifdef out; not used.
12463 (Fgnutls_boot): Use const for pointer to readonly storage.
12464 Comment out unused local. Fix pointer signedness problems.
12465
640ee02d
PE
12466 * lread.c (openp): Don't stuff size_t into an 'int'.
12467 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12468 about possible signed overflow.
12469
6048fb2a
PE
12470 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12471 (GDK_KEY_g): Don't define if already defined.
12472 (xg_prepare_tooltip): Avoid pointer signedness problem.
12473 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12474
fa3c87e1
PE
12475 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12476 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12477
2172544b
PE
12478 * xfns.c (Fx_window_property): Simplify a bit,
12479 to make a bit faster and to avoid GCC 4.6.0 warning.
12480 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12481
9b821a21
PE
12482 * fns.c (internal_equal): Don't assume size_t fits in int.
12483
3c616cfa
PE
12484 * alloc.c (compact_small_strings): Tighten assertion a little.
12485
c2982e87
PE
12486 Replace pEd with more-general pI, and fix some printf arg casts.
12487 * lisp.h (pI): New macro, generalizing old pEd macro to other
12488 conversion specifiers. For example, use "...%"pI"d..." rather
12489 than "...%"pEd"...".
12490 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12491 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12492 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12493 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12494 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12495 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12496 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12497 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12498 64-bit hosts.
12499 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12500 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12501 * print.c (safe_debug_print, print_object): Likewise.
12502 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12503 to int.
6f04d126
PE
12504 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12505 avoiding the 0 flag, which is not portable.
c2982e87
PE
12506 * process.c (Fmake_network_process): Use pI to avoid cast.
12507 * region-cache.c (pp_cache): Likewise.
12508 * xdisp.c (decode_mode_spec): Likewise.
12509 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12510 behavior on 64-bit hosts with printf arg.
6f04d126 12511 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12512 (x_stop_queuing_selection_requests): Likewise.
12513 (x_get_window_property): Don't truncate byte count to an 'int'
12514 when tracing.
0b432f21 12515
5e073ec7
PE
12516 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12517 here, since it parses constructs like leading '-' and spaces,
12518 which are not wanted; and it overflows with large numbers.
12519 Instead, simply match F[0-9]+, which is what is wanted anyway.
12520
36372bf9
PE
12521 * alloc.c: Remove unportable assumptions about struct layout.
12522 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12523 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12524 (allocate_vectorlike, make_pure_vector): Use the new macros,
12525 plus offsetof, to remove unportable assumptions about struct layout.
12526 These assumptions hold on all porting targets that I know of, but
12527 they are not guaranteed, they're easy to remove, and removing them
12528 makes further changes easier.
12529
0b432f21
PE
12530 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12531 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12532 (string_overrun_cookie): Now const. Use initializers that
12533 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12534 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12535 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12536 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12537 multiple of sizeof (EMACS_INT); it need not be, if
12538 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12539 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12540
895009e1
JB
125412011-04-26 Juanma Barranquero <lekktu@gmail.com>
12542
12543 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12544
6a7a1b0b
TZ
125452011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12546
12547 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12548 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12549 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12550
841a1577 125512011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12552
12553 * lisp.h (Qdebug): List symbol.
895009e1 12554 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12555 * keyboard.c (debug-on-event): New variable.
12556 (handle_user_signal): Break into debugger when debug-on-event
12557 matches the current signal symbol.
12558
f2d3ba6f
DN
125592011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12560
12561 * alloc.c (check_sblock, check_string_bytes)
12562 (check_string_free_list): Convert to standard C.
12563
42ce4c63
TZ
125642011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12565
12566 * w32.c (emacs_gnutls_push): Fix typo.
12567
825cd63c
EZ
125682011-04-25 Eli Zaretskii <eliz@gnu.org>
12569
fb11d64d
EZ
12570 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12571 "cast to pointer from integer of different size".
12572
825cd63c
EZ
12573 Improve doprnt and its use in verror. (Bug#8545)
12574 * doprnt.c (doprnt): Document the set of format control sequences
12575 supported by the function. Use SAFE_ALLOCA instead of always
12576 using `alloca'.
12577
12578 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12579 is one byte too soon. Don't use xrealloc; instead xfree and
12580 xmalloc anew.
12581
e061a11b
TZ
125822011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12583
12584 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12585 callbacks stage.
12586
12587 * gnutls.c: Renamed global_initialized to
12588 gnutls_global_initialized. Added internals for the
12589 :verify-hostname-error, :verify-error, and :verify-flags
12590 parameters of `gnutls-boot' and documented those parameters in the
12591 docstring. Start callback support.
9173deec
JB
12592 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12593 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12594 on error. Return error code.
e061a11b
TZ
12595 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12596 (emacs_gnutls_read): Likewise.
12597 (Fgnutls_boot): Return handshake error code.
12598 (emacs_gnutls_handle_error): New function.
12599 (wsaerror_to_errno): Likewise.
12600
12601 * w32.h (emacs_gnutls_pull): Add prototype.
12602 (emacs_gnutls_push): Likewise.
12603
12604 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12605 (emacs_gnutls_push): Likewise.
12606
126072011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12608
12609 * process.c (wait_reading_process_output): Check if GnuTLS
12610 buffered some data internally if no FDs are set for TLS
12611 connections.
12612
12613 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12614 (LIBS): Link to USER_LIBS.
12615 ($(BLD)/gnutls.$(0)): New target.
12616
fa6996bc
EZ
126172011-04-24 Eli Zaretskii <eliz@gnu.org>
12618
eb35682e
EZ
12619 * xdisp.c (handle_single_display_spec): Rename the
12620 display_replaced_before_p argument into display_replaced_p, to
12621 make it consistent with the commentary. Fix typos in the
12622 commentary.
12623
e2ad650c
EZ
12624 * textprop.c (syms_of_textprop): Remove dead code.
12625 (copy_text_properties): Delete obsolete commentary about an
12626 interface that was deleted long ago. Fix typos in the description
12627 of arguments.
12628
1b2de274
EZ
12629 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12630 to changes in oldXMenu/XMenu.h from 2011-04-16.
12631 <menu_help_message, prev_menu_help_message>: Constify.
12632 (IT_menu_make_room): menu->help_text is now `const char **';
12633 adjust.
12634
12635 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12636 to changes in oldXMenu/XMenu.h from 2011-04-16.
12637 (struct XMenu): Declare `help_text' `const char **'.
12638
12639 * xfaces.c <Qunspecified>: Make extern again.
12640
12641 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12642 required by POSIX.
1b2de274 12643
762b15be
EZ
12644 * doc.c (get_doc_string): Improve the format passed to `error'.
12645
12646 * doprnt.c (doprnt): Improve commentary.
12647
12648 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12649
12650 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12651 them with etags.
12652
f1052e5d
EZ
12653 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12654 changes in globals.h immediately force recompilation.
762b15be
EZ
12655 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12656 $(CURDIR)/s/ms-w32.h.
12657 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12658
fa6996bc
EZ
12659 * character.c (Fchar_direction): Function deleted.
12660 (syms_of_character): Don't defsubr it.
12661 <char-direction-table>: Deleted.
12662
e6c3da20
EZ
126632011-04-23 Eli Zaretskii <eliz@gnu.org>
12664
12665 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12666 * doprnt.c: Include limits.h.
12667 (SIZE_MAX): New macro.
04f2d78b
CB
12668 (doprnt): Return a size_t value. 2nd arg is now size_t.
12669 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12670 Improve overflow protection. Support `l' modifier for integer
12671 conversions. Support %l conversion. Don't assume an EMACS_INT
12672 argument for integer conversions and for %c.
12673
12674 * lisp.h (doprnt): Restore prototype.
12675
12676 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12677 $(SRC)/character.h.
12678
12679 * Makefile.in (base_obj): Add back doprnt.o.
12680
12681 * deps.mk (doprnt.o): Add back prerequisites.
12682 (callint.o): Depend on character.h.
12683
12684 * eval.c (internal_lisp_condition_case): Include the handler
12685 representation in the error message.
12686 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12687 when breaking from the loop.
12688
12689 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12690
12691 * callint.c (Fcall_interactively): When displaying error message
12692 about invalid control letter, pass the character's codepoint, not
12693 a pointer to its multibyte form. Improve display of the character
12694 in octal and display also its hex code.
12695
12696 * character.c (char_string): Use %x to display the (unsigned)
12697 codepoint of an invalid character, to avoid displaying a bogus
12698 negative value.
12699
12700 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12701 `error', not SYMBOL_NAME itself.
12702
12703 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12704 character arguments to `error'.
12705
12706 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12707 to `error' in error message about FINAL_CHAR argument. Make sure
12708 FINAL_CHAR is a character, and use %c when it is passed as
12709 argument to `error'.
12710
4ffd0d6b 127112011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12712
12713 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12714
12715 * w32.c: Include <time.h>.
12716 (sys_localtime): New function.
12717
4ffd0d6b 127182011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12719
12720 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12721
4ffd0d6b 12722 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12723
4ffd0d6b 127242011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12725
4ffd0d6b
GM
12726 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12727 zombies (Bug#8467).
aac0c6e3 12728
04c56954
EZ
127292011-04-19 Eli Zaretskii <eliz@gnu.org>
12730
12731 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12732 gl_state.e_property when gl_state.object is Qt.
12733
12734 * insdel.c (make_gap_larger): Remove limitation of buffer size
12735 to <= INT_MAX.
12736
16a43933
CY
127372011-04-18 Chong Yidong <cyd@stupidchicken.com>
12738
12739 * xdisp.c (lookup_glyphless_char_display)
12740 (produce_glyphless_glyph): Handle cons cell entry in
12741 glyphless-char-display.
12742 (Vglyphless_char_display): Document it.
12743
12744 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12745 glyphless-char-display.
12746
4581706e
CY
127472011-04-17 Chong Yidong <cyd@stupidchicken.com>
12748
12749 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12750
12751 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12752
12753 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12754 definition for no-X builds.
12755
4887c6e2 127562011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12757
fd35b6f9
PE
12758 Static checks with GCC 4.6.0 and non-default toolkits.
12759
5c1ccb01
PE
12760 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12761
006c5daa
PE
12762 * process.c (keyboard_bit_set): Define only if SIGIO.
12763 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12764 (send_process): Repair possible setjmp clobbering.
12765
efc736d3
PE
12766 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12767
4e2fe2e6
PE
12768 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12769
f97334a2
PE
12770 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12771
4e75f29d
PE
12772 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12773 Define only if needed.
12774
90efadd1
PE
12775 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12776 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12777 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12778
3c647824
PE
12779 * dispextern.h (struct redisplay_interface): Rename param
12780 to avoid shadowing.
e264f262 12781 * termhooks.h (struct terminal): Likewise.
761383f4 12782 * xterm.c (xembed_send_message): Likewise.
3c647824 12783
b58c5c4a
PE
12784 * insdel.c (make_gap_smaller): Define only if
12785 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12786
cad59032
PE
12787 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12788 it.
12789
c339dc2e
PE
12790 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12791 so that we aren't warned about unused symbols.
12792
91a3e27b
PE
12793 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12794
399c71d3 12795 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12796
8ffc96f5
PE
12797 * xfns.c (x_real_positions): Mark locals as initialized.
12798
eef9bc79
PE
12799 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12800
098db9dd
PE
12801 * xterm.c: Fix problems found by static analysis with other toolkits.
12802 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12803 (x_dispatch_event): Declare static if USE_GTK, and
12804 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12805 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12806 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12807 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12808 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12809
eb18f6cc
PE
12810 * xmenu.c (menu_help_callback): Pointer type fixes.
12811 Use const pointers when pointing at readonly data. Avoid pointer
12812 signedness clashes.
12813 (FALSE): Remove unused macro.
12814 (update_frame_menubar): Remove unused decl.
12815
1fe72bf8
PE
12816 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12817
60d9e1db
PE
12818 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12819 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12820 (single_menu_item): Rename local to avoid shadowing.
12821
39261c26
PE
12822 * keyboard.c (make_lispy_event): Remove unused local var.
12823
018c5e19
PE
12824 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12825 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12826
63d2b86e
PE
12827 * bitmaps: Change bitmaps from unsigned char back to the X11
12828 compatible char. Avoid the old compiler warnings about
12829 out-of-range initializers by using, for example, '\xab' rather
12830 than 0xab.
12831
aefd87e1
PE
12832 * xgselect.c (xgselect_initialize): Check vs interface
12833 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12834
bf501fb9
PE
12835 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12836
e9829fdf
PE
12837 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12838 to read-only memory.
12839
1086c095
PE
12840 * fns.c (vector): Remove; this old hack is no longer needed.
12841
2baccd04 12842 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12843 Remove unused var.
dde42981 12844 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12845
72391843 12846 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12847
436c16df 12848 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12849 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12850 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12851
92bb796d 12852 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12853 (x_term_init): Remove local to avoid shadowing.
92bb796d 12854
764430a3 12855 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12856
12857 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12858 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12859
d1dfb56c
EZ
128602011-04-16 Eli Zaretskii <eliz@gnu.org>
12861
c4354cb4
EZ
12862 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12863
d1dfb56c
EZ
12864 Fix regex.c, syntax.c and friends for buffers > 2GB.
12865 * syntax.h (struct gl_state_s): Declare character position members
12866 EMACS_INT.
12867
12868 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12869
04f2d78b
CB
12870 * textprop.c (verify_interval_modification, interval_of):
12871 Declare arguments EMACS_INT.
d1dfb56c
EZ
12872
12873 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12874 EMACS_INT.
12875
12876 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12877
12878 * indent.c (Fvertical_motion): Local variable it_start is now
12879 EMACS_INT.
12880
12881 * regex.c (re_match, re_match_2, re_match_2_internal)
12882 (bcmp_translate, regcomp, regexec, print_double_string)
12883 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12884 (re_compile_pattern, re_exec): Declare arguments and local
12885 variables `size_t' and `ssize_t' and return values `regoff_t', as
12886 appropriate.
12887 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12888 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12889 <compile_stack_type>: `size' and `avail' are now `size_t'.
12890
12891 * regex.h <regoff_t>: Use ssize_t, not int.
12892 (re_search, re_search_2, re_match, re_match_2): Arguments that
12893 specify buffer/string position and length are now ssize_t and
12894 size_t. Return type is regoff_t.
12895
613052cd
BK
128962011-04-16 Ben Key <bkey76@gmail.com>
12897
12898 * nsfont.m: Fixed bugs in ns_get_family and
12899 ns_descriptor_to_entity that were caused by using free to
12900 deallocate memory blocks that were allocated by xmalloc (via
12901 xstrdup). This caused Emacs to crash when compiled with
12902 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12903 --enable-checking=xmallocoverrun). xfree is now used to
12904 deallocate these memory blocks.
12905
4170f62f 129062011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12907
71b41406
PE
12908 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12909
9587a89d
PE
12910 emacs_write: Accept and return EMACS_INT for sizes.
12911 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12912 et seq.
12913 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12914 Accept and return EMACS_INT.
12915 (emacs_gnutls_write): Return the number of bytes written on
12916 partial writes.
12917 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12918 (emacs_read, emacs_write): Remove check for negative size, as the
12919 Emacs source code has been audited now.
9587a89d
PE
12920 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12921 (emacs_read, emacs_write): Use it.
273a5f82
PE
12922 * process.c (send_process): Adjust to the new signatures of
12923 emacs_write and emacs_gnutls_write. Do not attempt to store
12924 a byte offset into an 'int'; it might overflow.
9587a89d 12925 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12926
3e047f51
PE
12927 * sound.c: Don't assume sizes fit in 'int'.
12928 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12929 Return EMACS_INT, not int.
3e047f51 12930 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12931 Accept EMACS_INT, not int.
12932 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12933 record read return values.
12934
cc39a9db
BK
129352011-04-15 Ben Key <bkey76@gmail.com>
12936
c9d0ec6d
JB
12937 * keyboard.c (Qundefined): Don't declare static since it is used
12938 in nsfns.m.
12939 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12940 static since they are used in nsfont.m.
cc39a9db 12941
6c60eb9f
SM
129422011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12943
12944 * process.c (Qprocessp): Don't declare static.
12945 * lisp.h (Qprocessp): Declare again.
12946
7990b61a
JB
129472011-04-15 Juanma Barranquero <lekktu@gmail.com>
12948
12949 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12950
5d4cb038
PE
129512011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12952
8bd7b830 12953 Improve C-level modularity by making more things 'static'.
cd64ea1d 12954
e3b27b31
PE
12955 Don't publish debugger-only interfaces to other modules.
12956 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12957 (verify_bytepos, count_markers): Move decls to the only modules
12958 that need them.
12959 * region-cache.h (pp_cache): Likewise.
12960 * window.h (check_all_windows): Likewise.
12961 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12962
5d4cb038
PE
12963 * sysdep.c (croak): Now static, if
12964 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12965 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12966
12967 * alloc.c (refill_memory_reserve): Now static if
12968 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12969 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12970
e87b6180
PE
12971 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12972 Define only if USE_LUCID.
12973
ac64929e
PE
12974 * xrdb.c (x_customization_string, x_rm_string): Now static.
12975
6f37259d
PE
12976 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12977 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12978
1683e3ab
PE
12979 * xdisp.c (draw_row_with_mouse_face): Now static.
12980 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12981
de9c2632
PE
12982 * window.h (check_all_windows): Mark externally visible.
12983
2b96acb7
PE
12984 * window.c (window_deletion_count): Now static.
12985
12986 * undo.c: Make symbols static if they're not exported.
12987 (last_undo_buffer, last_boundary_position, pending_boundary):
12988 Now static.
12989
50436f33
PE
12990 * textprop.c (interval_insert_behind_hooks): Now static.
12991 (interval_insert_in_front_hooks): Likewise.
12992
64520e5c
PE
12993 * term.c: Make symbols static if they're not exported.
12994 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12995 (max_frame_lines, tty_set_terminal_modes):
12996 (tty_reset_terminal_modes, tty_turn_off_highlight):
12997 (get_tty_terminal): Now static.
12998 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12999 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13000 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13001 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13002 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13003
1fa53021
PE
13004 * sysdep.c: Make symbols static if they're not exported.
13005 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13006 Now static.
13007 (sigprocmask_set, full_mask): Remove; unused.
13008 (wait_debugging): Mark as visible.
13009 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13010 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13011
d4b43b22
PE
13012 * syntax.c (syntax_temp): Define only if !__GNUC__.
13013
b7c513d0
PE
13014 * sound.c (current_sound_device, current_sound): Now static.
13015
989b29ad
PE
13016 * search.c (searchbufs, searchbuf_head): Now static.
13017
13a55a78
PE
13018 * scroll.c (scroll_cost): Remove; unused.
13019 * dispextern.h (scroll_cost): Remove decl.
13020
de68a1fc
PE
13021 * region-cache.h (pp_cache): Mark as externally visible.
13022
40ccffa6
PE
13023 * process.c: Make symbols static if they're not exported.
13024 (process_tick, update_tick, create_process, chan_process):
13025 (Vprocess_alist, proc_buffered_char, datagram_access):
13026 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13027 (deactivate_process): Mark defn as static, as well as decl.
13028 * lisp.h (create_process): Remove decl.
13029 * process.h (chan_process, Vprocess_alist): Remove decls.
13030
ad64fc97
PE
13031 * print.c: Make symbols static if they're not exported.
13032 (print_depth, new_backquote_output, being_printed, print_buffer):
13033 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13034 (print_interval, print_number_index, initial_stderr_stream):
13035 Now static.
13036 * lisp.h (Fprinc): Remove decl.
13037 (debug_output_compilation_hack): Mark as externally visible.
13038
adddb265
PE
13039 * sysdep.c (croak): Move decl from here to syssignal.h.
13040 * syssignal.h (croak): Put it here, so the API can be checked when
13041 'croak' is called from dissociate_if_controlling_tty.
13042
1717ede2
PE
13043 * minibuf.c: Make symbols static if they're not exported.
13044 (minibuf_save_list, choose_minibuf_frame): Now static.
13045 * lisp.h (choose_minibuf_frame): Remove decl.
13046
fa5fb2bc
PE
13047 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13048
1e3890d1
PE
13049 * lread.c: Make symbols static if they're not exported.
13050 (read_objects, initial_obarray, oblookup_last_bucket_number):
13051 Now static.
13052 (make_symbol): Remove; unused.
13053 * lisp.h (initial_obarray, make_symbol): Remove decls.
13054
8a1414fa
PE
13055 * keyboard.c: Make symbols static if they're not exported.
13056 (single_kboard, recent_keys_index, total_keys, recent_keys):
13057 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13058 (this_single_command_key_start, echoing, last_auto_save):
13059 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13060 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13061 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13062 (Vlispy_mouse_stem, double_click_count):
13063 Now static.
13064 (force_auto_save_soon): Define only if SIGDANGER.
13065 (ignore_mouse_drag_p): Now static if
13066 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13067 (print_help): Remove; unused.
13068 (stop_character, last_timer_event): Mark as externally visible.
13069 * keyboard.h (ignore_mouse_drag_p): Declare only if
13070 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13071 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13072 * lisp.h (echoing): Remove decl.
13073 (force_auto_save_soon): Declare only if SIGDANGER.
13074 * xdisp.c (redisplay_window): Simplify code, to make it more
13075 obvious that ignore_mouse_drag_p is not accessed if !defined
13076 USE_GTK && !defined HAVE_NS.
13077
93ea6e8f
PE
13078 * intervals.c: Make symbols static if they're not exported.
13079 (merge_properties_sticky, merge_interval_right, delete_interval):
13080 Now static.
13081 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13082
77382fcc
PE
13083 * insdel.c: Make symbols static if they're not exported.
13084 However, leave prepare_to_modify_buffer alone. It's never
13085 called from outside this function, but that appears to be a bug.
13086 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13087 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13088 (adjust_after_replace_noundo): Remove; unused.
13089 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13090 (signal_before_change): Remove decls.
77382fcc 13091
9306c32e
PE
13092 * indent.c (val_compute_motion, val_vmotion): Now static.
13093
cd44d2eb
PE
13094 * image.c: Make symbols static if they're not exported.
13095 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13096 if USE_GTK.
13097 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13098 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13099
ad9a7a06
PE
13100 * fringe.c (standard_bitmaps): Now static.
13101 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13102
81626931
PE
13103 * frame.c: Make symbols static if they're not exported.
13104 (x_report_frame_params, make_terminal_frame): Now static.
13105 (get_frame_param): Now static, unless HAVE_NS.
13106 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13107 (x_get_resource_string): Remove; not used.
13108 * frame.h (make_terminal_frame, x_report_frame_params):
13109 (x_get_resource_string); Remove decls.
13110 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13111 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13112
239f9db9
PE
13113 * font.c, fontset.c: Make symbols static if they're not exported.
13114 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13115 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13116 * font.c (font_close_object): Now static.
13117 * font.h (font_close_object): Remove.
13118 * fontset.c (FONTSET_OBJLIST): Remove.
13119 (free_realized_fontset) #if-0 the body, which does nothing.
13120 (face_suitable_for_char_p): #if-0, as it's never called.
13121 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13122 * xfaces.c (face_at_string_position):
13123 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13124 since 0 is always ASCII.
13125
dfcf3579
PE
13126 * fns.c (weak_hash_tables): Now static.
13127
5045092b
PE
13128 * fileio.c: Make symbols static if they're not exported.
13129 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13130 (Vwrite_region_annotation_buffers): Now static.
13131
57a96f5c
PE
13132 * eval.c: Make symbols static if they're not exported.
13133 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13134 * lisp.h (backtrace_list): Remove decl.
13135
35f08c38
PE
13136 * emacs.c: Make symbols static if they're not exported.
13137 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13138 (fatal_error_code, fatal_error_signal_hook, standard_args):
13139 Now static.
13140 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13141 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13142 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13143 * lisp.h (fatal_error_signal_hook): Remove decl.
13144 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13145
f44bd759
PE
13146 * editfns.c: Move a (normally-unused) function to its only use.
13147 * editfns.c, lisp.h (get_operating_system_release): Remove.
13148 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13149 worth the hassle of breaking this out.
13150
b532497d
PE
13151 * xterm.c: Make symbols static if they're not exported.
13152 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13153 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13154 (x_destroy_window, x_delete_display):
13155 Now static.
13156 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13157 (x_mouse_leave): Remove; unused.
13158 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13159 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13160 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13161 Remove decls.
13162 (x_mouse_leave): Declare only if WINDOWSNT.
13163 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13164 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13165 USE_X_TOOLKIT.
13166
1675728f
PE
13167 * ftxfont.c: Make symbols static if they're not exported.
13168 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13169 HAVE_FREETYPE.
13170 * font.h (ftxfont_driver): Likewise.
13171
e4cebfca
PE
13172 * xfns.c: Make symbols static if they're not exported.
13173 (x_last_font_name, x_display_info_for_name):
13174 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13175 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13176 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13177 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13178 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13179 (last_show_tip_args): Now static.
13180 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13181 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13182 (x_screen_planes): Remove; unused.
13183 * dispextern.h (x_screen_planes): Remove decl.
13184
5bf46f05
PE
13185 * dispnew.c: Make symbols static if they're not exported.
13186 * dispextern.h (redraw_garbaged_frames, scrolling):
13187 (increment_row_positions): Remove.
13188 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13189 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13190 Now static.
13191 (redraw_garbaged_frames): Remove; unused.
13192
435f4c28
PE
13193 * xfaces.c: Make symbols static if they're not exported.
13194 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13195 Remove decls.
13196 * xterm.h (defined_color): Remove decls.
13197 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13198 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13199 (menu_face_changed_default, defined_color, free_realized_face):
13200 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13201 (ascii_face_of_lisp_face): Remove; unused.
13202
8524aef3
PE
13203 * xdisp.c: Make symbols static if they're not exported.
13204 * dispextern.h (scratch_glyph_row, window_box_edges):
13205 (glyph_to_pixel_coords, set_cursor_from_row):
13206 (get_next_display_element, set_iterator_to_next):
13207 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13208 (show_mouse_face): Remove decls
13209 * frame.h (message_buf_print): Likewise.
13210 * lisp.h (pop_message, set_message, check_point_in_composition):
13211 Likewise.
13212 * xterm.h (set_vertical_scroll_bar): Likewise.
13213 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13214 (message_buf_print, scratch_glyph_row, displayed_buffer):
13215 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13216 (get_next_display_element, show_mouse_face, window_box_edges):
13217 (frame_to_window_pixel_xy, check_point_in_composition):
13218 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13219 (glyph_to_pixel_coords): Remove; unused.
13220
16390cd2
PE
13221 * dired.c (file_name_completion): Now static.
13222
13223 * dbusbind.c (xd_in_read_queued_messages): Now static.
13224
a25f4dfa
PE
13225 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13226 * data.c (circular_list_error): Remove.
13227
14a9c8df
PE
13228 * commands.h (last_point_position, last_point_position_buffer):
13229 (last_point_position_window): Remove decls.
13230 * keyboard.c: Make these variables static.
13231
04f2d78b
CB
13232 * coding.h (coding, code_convert_region, encode_coding_gap):
13233 Remove decls.
74ab6df5
PE
13234 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13235 (iso_code_class, detect_coding, code_convert_region): Now static.
13236 (encode_coding_gap): Remove; unused.
13237
38dfbee1
PE
13238 * chartab.c (chartab_chars, chartab_bits): Now static.
13239
a2cb4e63
PE
13240 * charset.h (charset_iso_8859_1): Remove decl.
13241 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13242 Now static.
13243
127198fd
PE
13244 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13245 * ccl.c (Vccl_program_table): Now static.
13246 (check_ccl_update): Remove; unused.
13247
d85b608f
PE
13248 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13249 * category.h: ... from here.
13250 * category.c (check_category_table, set_category_set): Now static.
13251
31cd66f3
PE
13252 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13253 * lisp.h: Remove these decls.
13254
c358e587
PE
13255 * buffer.c (buffer_count): Remove unused var.
13256
e78aecca
PE
13257 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13258 so that it's not optimized away.
13259 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13260 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13261 exported only to the debugger.
13262
e192d7d3 13263 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13264 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13265
92470028
PE
13266 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13267 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13268 was inaccessible from Lisp.
13269 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13270 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13271
244ed907
PE
13272 alloc.c: Import and export fewer symbols, and remove unused items.
13273 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13274 is defined.
13275 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13276 it's not optimized away by whole-program optimization.
13277 (message_enable_multibyte, free_misc): Remove.
13278 (catchlist, handlerlist, mark_backtrace):
13279 Declare only if BYTE_MARK_STACK.
13280 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13281 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13282 (message_enable_multibyte): Remove decl.
13283 (free_misc, interval_free_list, float_block, float_block_index):
13284 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13285 (cons_free_list, last_marked_index):
13286 Now static.
13287 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13288 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13289 (mark_backtrace): Define only if BYTE_MARK_STACK.
13290 * xdisp.c (message_enable_multibyte): Now static.
13291
61c2b50e 13292 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13293 This makes it easier for human readers (and static analyzers)
13294 to see whether these variables are used from other modules.
13295 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13296 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13297 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13298 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13299 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13300 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13301 * xmenu.c, xselect.c:
13302 Declare Q* vars static if they are not used in other modules.
13303 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13304 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13305 Remove decls of unexported vars.
13306 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13307
95c82688
PE
13308 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13309
16a97296
PE
13310 Make Emacs functions such as Fatom 'static' by default.
13311 This makes it easier for human readers (and static analyzers)
13312 to see whether these functions can be called from other modules.
13313 DEFUN now defines a static function. To make the function external
13314 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13315 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13316 (Finit_image_library):
16a97296
PE
13317 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13318 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13319 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13320 Remove decls, since these functions are now static.
13321 (Funintern, Fget_internal_run_time): New decls, since these functions
13322 were already external.
95c82688 13323
16a97296
PE
13324 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13325 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13326 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13327 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13328 * keyboard.c, keymap.c, lread.c:
13329 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13330 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13331 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13332 Mark functions with DEFUE instead of DEFUN,
13333 if they are used in other modules.
13334 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13335 decls for now-static functions.
13336 * buffer.h (Fdelete_overlay): Remove decl.
13337 * callproc.c (Fgetenv_internal): Mark as internal.
13338 * composite.c (Fremove_list_of_text_properties): Remove decl.
13339 (Fcomposition_get_gstring): New forward static decl.
13340 * composite.h (Fcomposite_get_gstring): Remove decl.
13341 * dired.c (Ffile_attributes): New forward static decl.
13342 * doc.c (Fdocumntation_property): New forward static decl.
13343 * eval.c (Ffetch_bytecode): New forward static decl.
13344 (Funintern): Remove extern decl; now in .h file where it belongs.
13345 * fileio.c (Fmake_symbolic_link): New forward static decl.
13346 * image.c (Finit_image_library): New forward static decl.
13347 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13348 * intervals.h (Fprevious_property_change):
13349 (Fremove_list_of_text_properties): Remove decls.
13350 * keyboard.c (Fthis_command_keys): Remove decl.
13351 (Fcommand_execute): New forward static decl.
13352 * keymap.c (Flookup_key): New forward static decl.
13353 (Fcopy_keymap): Now static.
13354 * keymap.h (Flookup_key): Remove decl.
13355 * process.c (Fget_process): New forward static decl.
13356 (Fprocess_datagram_address): Mark as internal.
13357 * syntax.c (Fsyntax_table_p): New forward static decl.
13358 (skip_chars): Remove duplicate decl.
13359 * textprop.c (Fprevious_property_change): New forward static decl.
13360 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13361 Now internal.
13362 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13363 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13364
785bbd42
PE
13365 * editfns.c (Fformat): Remove unreachable code.
13366
8b913b57
AS
133672011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13368
13369 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13370 change. (Bug#8496)
13371
a6744a35
EZ
133722011-04-13 Eli Zaretskii <eliz@gnu.org>
13373
13374 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13375 when at ZV. (Bug#8487)
13376
e7974947
AS
133772011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13378
baad03f0
AS
13379 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13380 (Bug#8437)
13381 * keyboard.c (parse_tool_bar_item): Likewise.
13382 * sound.c (sound_cleanup, alsa_close): Likewise.
13383 * termcap.c (tgetent): Likewise.
13384 * xfns.c (x_default_font_parameter): Likewise.
13385 * xsettings.c (read_and_apply_settings): Likewise.
13386
e7974947
AS
13387 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13388 (overrun_check_free): Protoize.
13389
28272684
PE
133902011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13391
13392 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13393 since callers should never pass a negative size.
13394 Change the signature to match that of plain 'read' and 'write'; see
13395 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13396 * lisp.h: Update prototypes of emacs_write and emacs_read.
13397
11997c76
EZ
133982011-04-11 Eli Zaretskii <eliz@gnu.org>
13399
13400 * xdisp.c (redisplay_window): Don't try to determine the character
13401 position of the scroll margin if the window start point w->startp
e896f03c 13402 is outside the buffer's accessible region. (Bug#8468)
11997c76 13403
8a2cbd72
EZ
134042011-04-10 Eli Zaretskii <eliz@gnu.org>
13405
13406 Fix write-region and its subroutines for buffers > 2GB.
13407 * fileio.c (a_write, e_write): Modify declaration of arguments and
13408 local variables to support buffers larger than 2GB.
13409 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13410
13411 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13412 argument, local variables, and return value.
13413
13414 * lisp.h: Update prototypes of emacs_write and emacs_read.
13415
13416 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13417
4073e537 134182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13419
1ebfdcb6
PE
13420 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13421
b2ded58d
PE
13422 Fix more problems found by GCC 4.6.0's static checks.
13423
7d66342c
PE
13424 * xdisp.c (vmessage): Use a better test for character truncation.
13425
bbf47d44
PE
13426 * charset.c (load_charset_map): <, not <=, for optimization,
13427 and to avoid potential problems with integer overflow.
9248994d 13428 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13429 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13430 * editfns.c (Fformat): Likewise.
1e69125e 13431 * syntax.c (skip_chars): Likewise.
3befa583 13432
e3019616
PE
13433 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13434 This also lets GCC 4.6.0 generate slightly better loop code.
13435
becfa255
PE
13436 * callint.c (Fcall_interactively): <, not <=, for optimization.
13437 (Fcall_interactively): Count the number of arguments produced,
13438 not the number of arguments given. This is simpler and lets GCC
13439 4.6.0 generate slightly better code.
13440
dae0cd48
PE
13441 * ftfont.c: Distingish more carefully between FcChar8 and char.
13442 The previous code passed unsigned char * to a functions like
13443 strlen and xstrcasecmp that expect char *, which does not
13444 conform to the C standard.
13445 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13446 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13447 char * when the C standard requires it.
13448
76032d70
PE
13449 * keyboard.c (read_char): Remove unused var.
13450
eb3f1cc8
PE
13451 * eval.c: Port to Windows vsnprintf (Bug#8435).
13452 Include <limits.h>.
13453 (SIZE_MAX): Define if the headers do not.
13454 (verror): Do not give up if vsnprintf returns a negative count.
13455 Instead, grow the buffer. This ports to Windows vsnprintf, which
13456 does not conform to C99. Problem reported by Eli Zaretskii.
13457 Also, simplify the allocation scheme, by avoiding the need for
13458 calling realloc, and removing the ALLOCATED variable.
13459
70476b54
PE
13460 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13461
12020a9e
PE
13462 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13463 But keep the doprint source code for now, as we might revamp it
13464 and use it again (Bug#8435).
ea6c7ae6
PE
13465 * lisp.h (doprnt): Remove.
13466 * Makefile.in (base_obj): Remove doprnt.o.
13467 * deps.mk (doprnt.o): Remove.
13468
5fdb398c
PE
13469 error: Print 32- and 64-bit integers portably (Bug#8435).
13470 Without this change, on typical 64-bit hosts error ("...%d...", N)
13471 was used to print both 32- and 64-bit integers N, which relied on
13472 undefined behavior.
61bdb816 13473 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13474 * lisp.h (error, verror): Mark as printf-like functions.
13475 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13476 Report overflow in size calculations when allocating printf buffer.
13477 Do not truncate output string at its first null byte.
13478 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13479 Truncate the output at a character boundary, since vsnprintf does not
13480 do that.
13481 * charset.c (check_iso_charset_parameter): Convert internal
13482 character to string before calling 'error', since %c now has the
13483 printf meaning.
13484 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13485 overflow when computing char to be passed to 'error'. Do not
13486 pass Lisp_Object to 'error'; pass the integer instead.
13487 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13488 formatted with plain %d.
13489
b189fa66
PE
13490 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13491
bff87ef0
PE
13492 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13493
7e2cac20
PE
13494 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13495
ce4d90b5
PE
13496 * xterm.c (x_catch_errors): Remove duplicate declaration.
13497
266c9547
PE
13498 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13499
79c49ad2
PE
13500 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13501
368f4090
JM
135022011-04-10 Jim Meyering <meyering@redhat.com>
13503
13504 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13505 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13506 return ssize_t not "int", and use size_t as the buffer length.
13507 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13508 * gnutls.h: Update declarations.
13509 * process.c (read_process_output): Use ssize_t, to match.
13510 (send_process): Likewise.
13511
a32d4040
CY
135122011-04-09 Chong Yidong <cyd@stupidchicken.com>
13513
13514 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13515
8546720e 135162011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13517
04f2d78b
CB
13518 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13519 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13520
8546720e
GM
13521 * xterm.c (handle_one_xevent):
13522 * xmenu.c (create_and_show_popup_menu):
13523 * xselect.c (x_decline_selection_request)
13524 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13525
0a2f5c1a 135262011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13527
13528 Fix some uses of `int' instead of EMACS_INT.
13529 * search.c (string_match_1, fast_string_match)
13530 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13531 (scan_buffer, find_next_newline_no_quit)
13532 (find_before_next_newline, search_command, Freplace_match)
13533 (Fmatch_data): Make some `int' variables be EMACS_INT.
13534
13535 * xdisp.c (display_count_lines): 3rd argument and return value now
13536 EMACS_INT. All callers changed.
13537 (pint2hrstr): Last argument is now EMACS_INT.
13538
13539 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13540 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13541 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13542 (decode_coding_utf_16, decode_coding_emacs_mule)
13543 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13544 (decode_coding_ccl, decode_coding_charset)
13545 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13546 (decode_coding_iso_2022, decode_coding_emacs_mule)
13547 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13548 <char_offset, last_offset>: Declare EMACS_INT.
13549 (encode_coding_utf_8, encode_coding_utf_16)
13550 (encode_coding_emacs_mule, encode_invocation_designation)
13551 (encode_designation_at_bol, encode_coding_iso_2022)
13552 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13553 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13554 Declare EMACS_INT.
13555 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13556 (encode_invocation_designation): Last argument P_NCHARS is now
13557 EMACS_INT.
13558 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13559 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13560
13561 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13562 All users changed.
13563
13564 * ccl.c (Fccl_execute_on_string): Declare some variables
13565 EMACS_INT.
13566
8546720e 135672011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13568
13569 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13570
4e19a977
CS
135712011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13572
13573 * process.c (Fformat_network_address): Doc fix.
13574
87302331
R
135752011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13576
ee7683eb 13577 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13578
cbb59342
CY
135792011-04-08 Chong Yidong <cyd@stupidchicken.com>
13580
13581 * keyboard.c (read_char): Call Lisp function help-form-show,
13582 instead of using internal_with_output_to_temp_buffer.
13583 (Qhelp_form_show): New var.
e0d38eeb 13584 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13585
13586 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13587
13588 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13589
e67a13ab
CY
135902011-04-06 Chong Yidong <cyd@stupidchicken.com>
13591
04f2d78b
CB
13592 * process.c (Flist_processes): Remove to Lisp.
13593 (list_processes_1): Delete.
e67a13ab 13594
973f782d
EZ
135952011-04-06 Eli Zaretskii <eliz@gnu.org>
13596
7c106b1e
EZ
13597 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13598
973f782d
EZ
13599 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13600
41cf7d1a 136012011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13602
ca23cc88
PE
13603 Fix more problems found by GCC 4.6.0's static checks.
13604
f390e2d5
PE
13605 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13606
42eea0d0
PE
13607 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13608
b69769da 13609 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13610
f9541e84
PE
13611 * xdisp.c (vmessage): Mark as a printf-like function.
13612
13841b55
PE
13613 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13614
c136c10f
PE
13615 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13616
5e2d4a30
PE
13617 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13618 printf-like functions.
13619 (tiff_load): Add casts to remove these marks before passing them
13620 to system-supplied API.
13621
583f48b9
PE
13622 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13623
b25d760e
PE
13624 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13625 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13626 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13627 directly, rather than having caller test rule sign. This avoids
13628 some unnecessary tests.
13629 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13630 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13631 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13632
bc7b6697 13633 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13634 (xfont_open): Avoid unnecessary tests.
bc7b6697 13635
27ccc379
PE
13636 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13637
dcd5c89a
PE
13638 * composite.h, composite.c (composition_gstring_put_cache):
13639 Use EMACS_INT, not int, for length.
13640
b13a45c6
PE
13641 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13642 breaking out part of COMPOSITION_DECODE_RULE.
13643 (COMPOSITION_DECODE_RULE): Use it.
13644 * composite.c (get_composition_id): Remove unused local vars,
13645 by using the new macro.
13646
1e792e4d
PE
13647 * textprop.c (set_text_properties_1): Change while to do-while,
13648 since the condition is always true at first.
13649
dc6c6455 13650 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13651 (interval_deletion_adjustment): Return unsigned value.
13652 All uses changed.
dc6c6455 13653
aba7731a
PE
13654 * process.c (list_processes_1, create_pty, read_process_output):
13655 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13656 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13657 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13658 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13659 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13660
fdfc4bf3
PE
13661 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13662
fca8fe46 13663 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13664 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13665
06a0259a 13666 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13667 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13668 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13669
e7b9e80f
PE
13670 * print.c (print_error_message): Avoid int overflow.
13671
56201685
PE
13672 * font.c (font_list_entities): Redo for clarity,
13673 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13674
78834453 13675 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13676 (font_score): Avoid potential overflow in diff calculation.
78834453 13677
0bc0b309 13678 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13679 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13680
e610eaca
PE
13681 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13682
b895abce
PE
13683 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13684 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13685 can always succeed if overflow has undefined behavior.
13686
1f1d9321 13687 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13688 (wordify): Omit three unnecessary tests.
1f1d9321 13689
c59478bc
PE
13690 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13691 All callers changed. This avoids the need for an unused var.
13692
79b73827
PE
13693 * casefiddle.c (casify_region): Remove var that is set but not used.
13694
a4db5dfe
PE
13695 * dired.c (file_name_completion): Remove var that is set but not used.
13696
43aae36e
PE
13697 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13698
2a47c44d 13699 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13700 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13701
a37c69bf
PE
13702 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13703 Check for integer overflow on size calculations.
13704
328ab8e7
PE
13705 * buffer.c (Fprevious_overlay_change): Remove var that is set
13706 but not used.
13707
e5a2a5cb
PE
13708 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13709 Remove vars that are set but not used.
8d84a6eb 13710 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13711 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13712
a60e5f68
PE
13713 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13714
f661cb61 13715 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13716 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13717
f0397f5a
PE
13718 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13719 that are set but not used.
13720
8664db06 13721 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13722 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13723
6abdaa4a
PE
13724 * xselect.c (x_get_local_selection, x_handle_property_notify):
13725 Remove vars that are set but not used.
13726
0ce7538d 13727 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13728 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13729
9ae848fc
PE
13730 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13731 Remove var that is set but not used.
0b918413
PE
13732 (scroll_bar_windows_size): Now size_t, not int.
13733 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13734 Check for overflow.
9ae848fc 13735
a5a62657
PE
13736 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13737 (map_tty_color) [!defined MSDOS]: Likewise.
13738
5c5cdd39
PE
13739 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13740
66ebf983
PE
13741 * coding.c: Remove vars that are set but not used.
13742 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13743 All callers changed.
13744 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13745 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13746 (decode_coding_charset): Remove vars that are set but not used.
13747
1be4d761
PE
13748 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13749 that is set but not used.
13750
47553fa8
PE
13751 * print.c (print_object): Remove var that is set but not used.
13752
1f7196bf 13753 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13754 The gnulib version avoids calling malloc in the usual case,
13755 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13756 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13757 * filelock.c (current_lock_owner): Likewise.
13758 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13759 * sysdep.c: Include allocator.h, careadlinkat.h.
13760 (emacs_no_realloc_allocator): New static constant.
13761 (emacs_readlink): New function.
fdb61804
PE
13762 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13763 ../lib/careadlinkat.h.
d1fdcab7 13764
f84c17c7
SM
137652011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13766
13767 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13768 first non-nil return value).
13769
ef3862ad
JD
137702011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13771
13772 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13773 if not defined (Bug#8403).
13774
376a7006
JB
137752011-04-02 Juanma Barranquero <lekktu@gmail.com>
13776
13777 * xdisp.c (display_count_lines): Remove parameter `start',
13778 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13779 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13780 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13781 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13782 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13783 and thereabouts. All callers changed.
13784 (get_per_char_metric): Remove parameter `f', unused since
13785 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13786
6ca3801d
JM
137872011-04-02 Jim Meyering <meyering@redhat.com>
13788
13789 do not dereference NULL upon failed strdup
13790 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13791 (ns_get_family): Likewise.
13792
d8e2b5ba
JB
137932011-04-02 Juanma Barranquero <lekktu@gmail.com>
13794
13795 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13796
8c74fcbd
JD
137972011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13798
13799 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13800 later (Bug#8403).
13801
7200d79c
SM
138022011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13803
03408648 13804 Add lexical binding.
7200d79c 13805
03408648
SM
13806 * window.c (Ftemp_output_buffer_show): New fun.
13807 (Fsave_window_excursion):
13808 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13809
13810 * lread.c (lisp_file_lexically_bound_p): New function.
13811 (Fload): Bind Qlexical_binding.
13812 (readevalloop): Remove `evalfun' arg.
13813 Bind Qinternal_interpreter_environment.
13814 (Feval_buffer): Bind Qlexical_binding.
13815 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13816 Mark as dynamic.
13817 (syms_of_lread): Declare `lexical-binding'.
13818
13819 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13820
13821 * keyboard.c (eval_dyn): New fun.
13822 (menu_item_eval_property): Use it.
ca105506
SM
13823
13824 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13825
03408648
SM
13826 * fns.c (concat, mapcar1): Accept byte-code-functions.
13827
13828 * eval.c (Fsetq): Handle lexical vars.
13829 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13830 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13831 (FletX, Flet): Obey lexical binding.
13832 (Fcommandp): Handle closures.
13833 (Feval): New `lexical' arg.
13834 (eval_sub): New function extracted from Feval. Use it almost
13835 everywhere where Feval was used. Look up vars in lexical env.
13836 Handle closures.
13837 (Ffunctionp): Move from subr.el.
13838 (Ffuncall): Handle closures.
13839 (apply_lambda): Remove `eval_flags'.
13840 (funcall_lambda): Handle closures and new byte-code-functions.
13841 (Fspecial_variable_p): New function.
13842 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13843 but without exporting it to Lisp.
23aba0ea 13844
23aba0ea 13845 * doc.c (Fdocumentation, store_function_docstring):
03408648 13846 * data.c (Finteractive_form): Handle closures.
23aba0ea 13847
03408648
SM
13848 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13849 interactive spec.
ba83908c 13850
04f2d78b
CB
13851 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13852 New byte-codes.
03408648
SM
13853 (exec_byte_code): New function extracted from Fbyte_code to handle new
13854 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13855
03408648 13856 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13857
03408648 13858 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13859
e2abce01
JB
138602011-03-31 Juanma Barranquero <lekktu@gmail.com>
13861
13862 * xdisp.c (redisplay_internal): Fix prototype.
13863
63696a73 138642011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13865
63696a73 13866 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13867 (try_scrolling): Use it when setting scroll_limit.
13868 Limit scrolling to 100 screen lines.
63696a73
EZ
13869 (redisplay_window): Even when falling back on "recentering",
13870 position point in the window according to scroll-conservatively,
13871 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13872
13873 (try_scrolling): When point is above the window, allow searching
13874 as far as scroll_max, or one screenful, to compute vertical
13875 distance from PT to the scroll margin position. This prevents
13876 try_scrolling from unnecessarily failing when
13877 scroll-conservatively is set to a value slightly larger than the
13878 window height. Clean up the case of PT below the margin at bottom
13879 of window: scroll_max can no longer be INT_MAX. When aggressive
13880 scrolling is in use, don't let point enter the opposite scroll
13881 margin as result of the scroll.
13882 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13883 threshold of 100 lines for never-recentering scrolling.
13884
e4cc2dfc
JB
138852011-03-31 Juanma Barranquero <lekktu@gmail.com>
13886
13887 * dispextern.h (move_it_by_lines):
13888 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13889 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13890 (message_log_check_duplicate): Remove parameters `prev_bol' and
13891 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13892 (redisplay_internal): Remove parameter `preserve_echo_area',
13893 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13894
13895 * indent.c (Fvertical_motion):
13896 * window.c (window_scroll_pixel_based, Frecenter):
13897 Don't pass `need_y_p' to `move_it_by_lines'.
13898
1c470562
SM
138992011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13900
44f230aa
SM
13901 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13902 steal a few bits to be more compact.
13903 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13904 Remove unneeded casts.
13905
1c470562
SM
13906 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13907
888adce9
ZK
139082011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13909
13910 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13911 binding" message (bug#7967).
13912
f838ed7b
PE
139132011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13914
77861b95
PE
13915 Fix more problems found by GCC 4.6.0's static checks.
13916
de6dbc14
PE
13917 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13918 Remove unused local var.
13919
f838ed7b
PE
13920 * editfns.c (Fmessage_box): Remove unused local var.
13921
792c7b2b
PE
13922 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13923 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13924 Omit unused local vars.
c499e557 13925 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13926 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13927 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13928 Omit unused local var.
13929
ba0165e1
PE
13930 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13931 Don't assume string length fits in int.
32ad8845 13932 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13933 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13934
3c59b4c9
PE
13935 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13936 instead of alloca (Bug#8344).
13937
a3eed478 13938 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13939 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13940
eb4d412d
PE
13941 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13942
1658b401
PE
13943 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13944 concerns.
13945
13946 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13947
13948 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13949
9a2c6e05
PE
13950 * keyboard.c (syms_of_keyboard): Use the same style as later
13951 in this function when indexing through an array. This also
13952 works around GCC bug 48267.
13953
03d0a109
PE
13954 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13955
44f730c8
PE
13956 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13957
fe75f926
PE
13958 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13959 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13960
ffa8c828
PE
13961 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13962 This avoids undefined behavior on integer overflow, and is a bit
13963 more convenient anyway since it is compared to a size_t variable.
13964
c5101a77
PE
13965 Variadic C functions now count arguments with size_t, not int.
13966 This avoids an unnecessary limitation on 64-bit machines, which
13967 caused (substring ...) to crash on large vectors (Bug#8344).
13968 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13969 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13970 All variadic functions and their callers changed accordingly.
c5101a77
PE
13971 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13972 * data.c (arith_driver, float_arith_driver): Likewise.
13973 * editfns.c (general_insert_function): Likewise.
13974 * eval.c (struct backtrace.nargs, interactive_p)
13975 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13976 (funcall_lambda, mark_backtrace): Likewise.
13977 * fns.c (concat): Likewise.
13978 * frame.c (x_set_frame_parameters): Likewise.
13979 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13980 0 if not found, not -1. All callers changed.
13981
dd3f25f7
PE
13982 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13983 (stack_copy_size): Now size_t, not int.
13984 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13985
461c2ab9
JB
139862011-03-28 Juanma Barranquero <lekktu@gmail.com>
13987
13988 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13989 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13990 All callers changed.
13991
13992 * lisp.h (multibyte_char_to_unibyte):
13993 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13994 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13995 * character.h (CHAR_TO_BYTE8):
13996 * cmds.c (internal_self_insert):
13997 * editfns.c (general_insert_function):
13998 * keymap.c (push_key_description):
13999 * search.c (Freplace_match):
14000 * xdisp.c (message_dolog, set_message_1): All callers changed.
14001
f6d62986
SM
140022011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14003
14004 * keyboard.c (safe_run_hook_funcall): New function.
14005 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14006 don't set the hook to nil, but remove the offending function instead.
14007 (Qcommand_hook_internal): Remove, unused.
14008 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14009 Vcommand_hook_internal.
14010
14011 * eval.c (enum run_hooks_condition): Remove.
14012 (funcall_nil, funcall_not): New functions.
14013 (run_hook_with_args): Call each function through a `funcall' argument.
14014 Remove `cond' argument, now redundant.
14015 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14016 (Frun_hook_with_args_until_failure): Adjust accordingly.
14017 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14018
1db5b1ad
JB
140192011-03-28 Juanma Barranquero <lekktu@gmail.com>
14020
14021 * dispextern.h (string_buffer_position): Remove declaration.
14022
14023 * print.c (strout): Remove parameter `multibyte', unused since
14024 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14025
14026 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14027 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14028 All callers changed.
14029
14030 * w32.c (_wsa_errlist): Use braces for struct initializers.
14031
14032 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14033 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14034 All callers changed.
14035 (string_buffer_position): Likewise. Also, make static (it's never
14036 used outside xdisp.c).
14037 (cursor_row_p): Remove parameter `w', unused since
14038 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14039 (decode_mode_spec): Remove parameter `precision', introduced during
14040 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14041 All callers changed.
14042
5ffb62aa
JD
140432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14044
14045 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14046
461c2ab9 140472011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14048
14049 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14050 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14051 (ns_update_auto_hide_menu_bar): New functions.
14052 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14053 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14054 ns_constrain_all_frames.
14055 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14056 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14057
5c380ffb
JD
140582011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14059
14060 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14061
9af30bdf
GM
140622011-03-27 Glenn Morris <rgm@gnu.org>
14063
14064 * syssignal.h: Replace RETSIGTYPE with void.
14065 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14066 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14067 Replace SIGTYPE with void everywhere.
14068 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14069 * s/template.h (SIGTYPE): Remove commented out definition.
14070
e2abce01
JB
140712011-03-26 Eli Zaretskii <eliz@gnu.org>
14072
14073 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14074 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14075
f868cd8a
JB
140762011-03-26 Juanma Barranquero <lekktu@gmail.com>
14077
59eb0929
JB
14078 * w32.c (read_unc_volume): Use parameter `henum', instead of
14079 global variable `wget_enum_handle'.
14080
14081 * keymap.c (describe_vector): Remove parameters `indices' and
14082 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14083 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14084
f868cd8a
JB
14085 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14086
14087 * keyboard.c (timer_check): Remove parameter `do_it_now',
14088 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14089 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14090 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14091
14092 * keyboard.c (read_char):
14093 * w32menu.c (w32_menu_display_help):
14094 * xmenu.c (show_help_event, menu_help_callback):
14095 Adjust calls to `show_help_echo'.
14096
14097 * gtkutil.c (xg_maybe_add_timer):
14098 * keyboard.c (readable_events):
14099 * process.c (wait_reading_process_output):
14100 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14101
14102 * insdel.c (adjust_markers_gap_motion):
14103 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14104 (gap_left, gap_right): Don't call it.
14105
2ecf6fdb
CY
141062011-03-25 Chong Yidong <cyd@stupidchicken.com>
14107
14108 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14109 incurred during fontification.
14110
6b1f9ba4
JB
141112011-03-25 Juanma Barranquero <lekktu@gmail.com>
14112
14113 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14114 (DEFVAR_PER_BUFFER): Don't pass it.
14115
14116 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14117 (scrolling_window): Don't pass it.
14118
0f4a96b5
JB
141192011-03-25 Juanma Barranquero <lekktu@gmail.com>
14120
14121 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14122
14123 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14124 and `suffix'.
14125 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14126 of variables specific to SELinux and computation of `encoded_absname'.
14127
14128 * image.c (XPutPixel): Remove unused variable `height'.
14129
14130 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14131
14132 * unexw32.c (get_section_info): Remove unused variable `section'.
14133
14134 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14135 (system_process_attributes): Remove unused variable `sess'.
14136 (sys_read): Remove unused variable `err'.
14137
14138 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14139 (w32_wnd_proc): Remove unused variable `isdead'.
14140 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14141 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14142 (x_create_tip_frame): Remove unused variable `tem'.
14143
14144 * w32inevt.c (w32_console_read_socket):
14145 Remove unused variable `no_events'.
14146
14147 * w32term.c (x_draw_composite_glyph_string_foreground):
14148 Remove unused variable `width'.
14149
1149507c
JB
141502011-03-24 Juanma Barranquero <lekktu@gmail.com>
14151
14152 * w32term.c (x_set_glyph_string_clipping):
14153 Don't pass uninitialized region to CombineRgn.
14154
9c88f339
JB
141552011-03-23 Juanma Barranquero <lekktu@gmail.com>
14156
14157 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14158 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14159 (Fx_close_connection): Remove unused variable `i'.
14160
14161 * w32font.c (w32font_draw): Return number of glyphs.
14162 (w32font_open_internal): Remove unused variable `i'.
14163 (w32font_driver): Add missing initializer.
14164
14165 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14166 (fill_in_menu): Remove unused variable `items_added'.
14167
14168 * w32term.c (last_mouse_press_frame): Remove static global variable.
14169 (w32_clip_to_row): Remove unused variable `f'.
14170 (x_delete_terminal): Remove unused variable `i'.
14171
14172 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14173 (NOTHING): Remove unused static global variable.
14174 (uniscribe_check_otf): Remove unused variable `table'.
14175 (uniscribe_font_driver): Add missing initializers.
14176
dee091a3
JD
141772011-03-23 Julien Danjou <julien@danjou.info>
14178
14179 * term.c (Fsuspend_tty, Fresume_tty):
14180 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14181 * window.c (temp_output_buffer_show):
14182 * insdel.c (signal_before_change):
14183 * frame.c (Fhandle_switch_frame):
14184 * fileio.c (Fdo_auto_save):
14185 * emacs.c (Fkill_emacs):
14186 * editfns.c (save_excursion_restore):
14187 * cmds.c (internal_self_insert):
14188 * callint.c (Fcall_interactively):
14189 * buffer.c (Fkill_all_local_variables):
14190 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14191 Use Frun_hooks.
0f4a96b5 14192 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14193 unconditionally since it does the check itself.
dee091a3 14194
2c520ab5 141952011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14196
c9c49752
PE
14197 Fix more problems found by GCC 4.5.2's static checks.
14198
8abc3f12
PE
14199 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14200 the first time through the loop, since we know p0 < p1 then.
14201 This also avoids a gcc -Wstrict-overflow warning.
14202
a2d26660
PE
14203 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14204 leading to a memory leak, possible in functions like
14205 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14206 of objects (Bug#8318).
a2d26660 14207
916c72e9
PE
14208 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14209 that could (at least in theory) be that large.
14210
19ab8a18
PE
14211 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14212 This is less likely to overflow, and avoids undefined behavior if
14213 overflow does occur. All callers changed. Use strtoul to scan
14214 for the unsigned long integer.
b7cbbd6f
PE
14215 (pint2hrstr): Simplify and tune code slightly.
14216 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14217
f0641eff
PE
14218 * scroll.c (do_scrolling): Work around GCC bug 48228.
14219 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14220
7f650bb9
PE
14221 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14222 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14223 (validate_x_resource_name): Simplify count usage.
14224 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14225
37dd57d1
PE
14226 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14227 fail (Bug#8306).
81e56e61 14228
699979fc 14229 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14230
401bf9b4
PE
14231 * process.c (Fmake_network_process): Use socklen_t, not int,
14232 where POSIX says socklen_t is required in portable programs.
14233 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14234 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14235 (Fmake_network_process, server_accept_connection):
14236 (wait_reading_process_output, read_process_output):
14237 Likewise.
14238
b93aacde
PE
14239 * process.c: Rename or move locals to avoid shadowing.
14240 (list_processes_1, Fmake_network_process):
14241 (read_process_output_error_handler, exec_sentinel_error_handler):
14242 Rename or move locals.
4dc343ee 14243 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14244 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14245 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14246 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14247 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14248
af8a867c 14249 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14250 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14251 Include tparam.h instead, since it declares them.
af8a867c
PE
14252 * cm.h (PC): Remove extern decl; tparam.h now does this.
14253 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14254 * terminfo.c: Include tparam.h, to check interfaces.
14255 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14256 (tparam): Adjust signature to match interface in tparam.h;
14257 this removes some undefined behavior. Check that outstring and len
14258 are zero, which they always are with Emacs.
14259 * tparam.h (PC, BC, UP): New extern decls.
14260
0248044d 14261 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14262 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14263
8ff096c1 14264 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14265 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14266 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14267 (ftfont_list): Remove unused local.
49eaafba
PE
14268 (get_adstyle_property, ftfont_pattern_entity):
14269 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14270 Rename locals to avoid shadowing.
8ff096c1 14271
e2be39f6
PE
14272 * xfont.c (xfont_list_family): Mark var as initialized.
14273
c9735e30
PE
14274 * xml.c (make_dom): Now static.
14275
8f5201ae
PE
14276 * composite.c (composition_compute_stop_pos): Rename local to
14277 avoid shadowing.
b246f932
PE
14278 (composition_reseat_it): Remove unused locals.
14279 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14280 (composition_update_it): Mark var as initialized.
11b61122
PE
14281 (find_automatic_composition): Mark vars as initialized,
14282 with a FIXME (Bug#8290).
8f5201ae 14283
760fbc2c
PE
14284 character.h: Rename locals to avoid shadowing.
14285 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14286 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14287 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14288 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14289 to avoid shadowing.
14290
ff08eb85
PE
14291 * textprop.c (property_change_between_p): Remove; unused.
14292
fc7bf025
PE
14293 * intervals.c (interval_start_pos): Now static.
14294
235d7abc
PE
14295 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14296
44f230aa
SM
14297 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14298 Rename locals to avoid shadowing.
3e7d6594 14299
50060332
PE
14300 * sound.c (wav_play, au_play, Fplay_sound_internal):
14301 Fix pointer signedness.
d01f234b 14302 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14303 (wav_play): Initialize a variable to 0, to prevent undefined
14304 behavior (Bug#8278).
50060332 14305
c4fc4e30
PE
14306 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14307
918436ed
PE
14308 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14309
c939f91b
PE
14310 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14311 clobbering (Bug#8298).
b9c7f648
PE
14312 * sysdep.c (sys_subshell): Likewise.
14313 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14314
6bd8c144
PE
14315 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14316 This should get cleaned up, so that child_setup has the
14317 same signature on all platforms.
14318
7710357c 14319 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14320 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14321
c59da222
CY
143222011-03-22 Chong Yidong <cyd@stupidchicken.com>
14323
14324 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14325 not to be necessary, and produces flickering.
14326
66b87493
GM
143272011-03-20 Glenn Morris <rgm@gnu.org>
14328
14329 * config.in: Remove file.
14330
45b6f6d5
JB
143312011-03-20 Juanma Barranquero <lekktu@gmail.com>
14332
14333 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14334 are now in src/globals.h.
14335 (syms_of_minibuf): Remove spurious & from previous change.
14336
cd394be1 143372011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14338
14339 * minibuf.c (completing-read-function): New variable.
14340 (completing-read-default): Rename from completing-read.
14341 (completing-read): Call completing-read-function.
14342
b14e3e21
CY
143432011-03-19 Juanma Barranquero <lekktu@gmail.com>
14344
14345 * xfaces.c (Fx_load_color_file):
14346 Read color file from absolute filename (bug#8250).
14347
f2b726e6
JB
143482011-03-19 Juanma Barranquero <lekktu@gmail.com>
14349
14350 * makefile.w32-in: Update dependencies.
14351
09f6ff02
EZ
143522011-03-17 Eli Zaretskii <eliz@gnu.org>
14353
14354 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14355
29a6015a
PE
143562011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14357
a3a6c54e
PE
14358 Fix more problems found by GCC 4.5.2's static checks.
14359
b766f867
PE
14360 * process.c (make_serial_process_unwind, send_process_trap):
14361 (sigchld_handler): Now static.
14362
be02381c
PE
14363 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14364 That way, the code declares only the vars that it needs.
14365 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14366 * s/cygwin.h (PTY_ITERATION): Likewise.
14367 * s/darwin.h (PTY_ITERATION): Likewise.
14368 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14369
57048744
PE
14370 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14371 * process.c (allocate_pty): Don't declare stb unless it's needed.
14372
7914961c 14373 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14374 (CONSTANTLIM): Remove; unused.
14375 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14376 Define only if needed.
7914961c 14377
b3967b18
PE
14378 * unexelf.c (unexec): Name an expression,
14379 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14380 Use a different way to cause a compilation error if anyone uses
14381 n rather than nn, a way that does not involve shadowing.
73366a00 14382 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14383
29a6015a
PE
14384 * deps.mk (unexalpha.o): Remove; unused.
14385
43cfc33e 14386 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14387 * unexec.h: New file.
ce701a33
PE
14388 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14389 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14390 Depend on unexec.h.
14391 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14392 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14393 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14394 Change as necessary to match prototype in unexec.h.
ce701a33 14395
01f44d5a
PE
14396 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14397 shadowing.
4f63c6bb 14398 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14399
a6670b0b
PE
14400 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14401 Rename locals to avoid shadowing.
14402
cef2010d 14403 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14404 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14405
d4d7173a
PE
14406 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14407
f08b802a
PE
14408 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14409 warning when compiling print.c.
14410
3ddb0639
PE
14411 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14412 instead of using an uninitialized var.
5ad03b97 14413 (font_sort_entities): Mark var as initialized.
3ddb0639 14414
170a2692
PE
14415 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14416
e663c700
PE
14417 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14418 pointers to constants.
89bc529a 14419 (font_parse_fcname): Remove unused vars.
7b81e2d0 14420 (font_delete_unmatched): Now static.
ea838e10 14421 (font_get_spec): Remove; unused.
13a547c6
PE
14422 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14423 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14424 Rename or move locals to avoid shadowing.
e663c700 14425
2a80c887 14426 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14427 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14428
1384fa33 14429 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14430 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14431
8b2c52e9
PE
14432 * alloc.c (mark_backtrace): Move decl from here ...
14433 * lisp.h: ... to here, so that it can be checked.
14434
475545b5 14435 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14436 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14437 (lisp_indirect_variable): Name an expression,
14438 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14439 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14440
b1349114 14441 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14442 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14443 Use const pointer when appropriate.
b1349114 14444
a2928364
PE
14445 * lisp.h (get_system_name, get_operating_system_release):
14446 Move decls here, to check interfaces.
14447 * process.c (get_operating_system_release): Move decl to lisp.h.
14448 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14449 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14450 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14451 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14452 (Fformat_time_string, Fencode_time, Finsert_char):
14453 (Ftranslate_region_internal, Fformat):
14454 Rename or remove local vars to avoid shadowing.
9710023e 14455 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14456
a415e694
PE
14457 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14458 avoid shadowing.
14459
8ef4622d
PE
14460 * lisp.h (eassert): Check that the argument compiles, even if
14461 ENABLE_CHECKING is not defined.
14462
946f9a5b
PE
14463 * data.c (Findirect_variable): Name an expression, to avoid
14464 gcc -Wbad-function-cast warning.
112396d6 14465 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14466 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14467 (Fmake_variable_buffer_local, Fmake_local_variable):
14468 Mark variables as initialized.
52746918 14469 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14470
e5aab7e7 14471 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14472 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14473 Rename locals to avoid shadowing.
dff45157
PE
14474 (mark_stack): Move local variables into the #ifdef region where
14475 they're used.
7bc26fdb
PE
14476 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14477 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14478 needed otherwise.
14479 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14480 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14481 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14482
e5aab7e7
PE
14483 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14484 avoids undefined behavior in theory.
14485
4da60324
PE
14486 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14487
88043301
PE
14488 Use functions, not macros, for up- and down-casing (Bug#8254).
14489 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14490 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14491 to use the following functions instead of these macros.
14492 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14493 EMACS_INT, since callers assume the returned value fits in int.
14494 (upcase1): Likewise, for UPCASE_TABLE.
14495 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14496 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14497 the race-condition problem in the old DOWNCASE.
88043301 14498
19ed5445
PE
14499 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14500 Rename locals to avoid shadowing.
14501 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14502 (regex_compile, re_search_2, re_match_2_internal):
14503 Remove unused local vars.
952db0d7
PE
14504 (FREE_VAR): Rewrite so as not to use empty "else",
14505 which gcc can warn about.
da053e48 14506 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14507 (RETALLOC_IF): Define only if needed.
14508 (WORDCHAR_P): Likewise. This one is never needed, but is used
14509 only in a comment talking about a compiler bug, so put inside
14510 the #if 0 of that comment.
14511 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14512 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14513 Remove; unused.
19ed5445 14514
1f3561e4 14515 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14516 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14517 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14518
ded6f8f7
PE
14519 * search.c (simple_search): Remove unused var.
14520
dbd37a95
PE
14521 * dired.c (compile_pattern): Move decl from here ...
14522 * lisp.h: ... to here, so that it can be checked.
14523 (struct re_registers): New forward decl.
14524
7e47afad
PE
14525 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14526
85f24f61
PE
14527 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14528 All uses changed.
14529 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14530 Rename locals to avoid shadowing.
5671df8f 14531 (Fvertical_motion): Mark locals as initialized.
85f24f61 14532
181aa2be 14533 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14534 (casify_region): Mark local as initialized.
181aa2be 14535
930d429c
PE
14536 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14537
7082eac6
PE
14538 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14539 New macros, so that the caller can use some names other than
14540 gcpro1, gcpro2, etc.
14541 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14542 of the new macros.
14543 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14544 argument, for consistency with GCPRO2_VAR, etc: it is now the
14545 prefix of the variable, not the variable itself. All uses
14546 changed.
38b2c076
PE
14547 * dired.c (directory_files_internal, file_name_completion):
14548 Rename locals to avoid shadowing.
14549
15206ed9
PE
14550 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14551 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14552 dired.c's scmp function, had undefined behavior.
14553 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14554 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14555 * buffer.h: ... to here, because these macros use current_buffer,
14556 and the new implementation with inline functions needs to have
14557 current_buffer in scope now, rather than later when the macros
14558 are used.
14559 (downcase, upcase1): New static inline functions.
14560 (DOWNCASE, UPCASE1): Reimplement using these functions.
14561 This avoids undefined behavior in expressions like
14562 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14563 from race conditions in accessing the global variables
14564 case_temp1 and case_temp2.
14565 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14566 * lisp.h (case_temp1, case_temp2): Remove their decls.
14567 * character.h (ASCII_CHAR_P): Move from here ...
14568 * lisp.h: ... to here, so that the inline functions mentioned
14569 above can use them.
14570
4a6bea26
PE
14571 * dired.c (directory_files_internal_unwind): Now static.
14572
f14b7e14
PE
14573 * fileio.c (file_name_as_directory, directory_file_name):
14574 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14575 Now static.
2893f146
PE
14576 (file_name_as_directory): Use const pointers when appropriate.
14577 (Fexpand_file_name): Likewise. In particular, newdir might
14578 point at constant storage, so make it a const pointer.
fd4ead52 14579 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14580 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14581 signedness issues.
f839df0c
PE
14582 (Fset_file_times, Finsert_file_contents, auto_save_error):
14583 Rename locals to avoid shadowing.
f14b7e14 14584
5716756e 14585 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14586 (Ftry_completion, Fall_completions): Rename or remove locals
14587 to avoid shadowing.
5716756e 14588
b4c3046a
PE
14589 * marker.c (bytepos_to_charpos): Remove; unused.
14590
b45db522
PE
14591 * lisp.h (verify_bytepos, count_markers): New decls,
14592 so that gcc does not warn that these functions aren't declared.
14593
85876d07
PE
14594 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14595 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14596 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14597 (copy_text): Remove unused local var.
85876d07 14598
03d78a21 14599 * filelock.c (within_one_second): Now static.
b3dd38ab 14600 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14601
5df8f01b
PE
14602 * buffer.c (fix_overlays_before): Mark locals as initialized.
14603 (fix_start_end_in_overlays): Likewise. This function should be
14604 simplified by using pointers-to-pointers, but that's a different
14605 matter.
b1d876f1 14606 (switch_to_buffer_1): Now static.
8f54f30a
PE
14607 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14608 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14609
a70072c9 14610 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14611 Fix pointer signedness issue.
edced198
PE
14612 (sys_subshell): Mark local as volatile if checking for lint,
14613 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14614 (MAXPATHLEN): Define only if needed.
a70072c9 14615
a0977c44
PE
14616 * process.c (serial_open, serial_configure): Move decls from here ...
14617 * systty.h: ... to here, so that they can be checked.
14618
a884fdcc
PE
14619 * fns.c (get_random, seed_random): Move extern decls from here ...
14620 * lisp.h: ... to here, so that they can be checked.
14621
604efe86 14622 * sysdep.c (reset_io): Now static.
b8950c94 14623 (wait_for_termination_signal): Remove; unused.
604efe86 14624
38fc62d9
PE
14625 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14626 (copy_keymap_item, append_key, push_text_char_description):
14627 Now static.
1004a21a 14628 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14629 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14630 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14631 (describe_map_tree):
14632 Rename locals to avoid shadowing.
38fc62d9 14633
2f2650da
PE
14634 * keyboard.c: Declare functions static if they are not used elsewhere.
14635 (echo_char, echo_dash, cmd_error, top_level_2):
14636 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14637 (read_char, kbd_buffer_get_event, make_lispy_position):
14638 (make_lispy_event, make_lispy_movement, apply_modifiers):
14639 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14640 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14641 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14642 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14643 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14644
a053e86c 14645 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14646 (mark_kboards): Move decl here ...
14647 * alloc.c (mark_kboards): ... from here.
a053e86c 14648
4752793e
PE
14649 * lisp.h (force_auto_save_soon): New decl.
14650
74f10ca7 14651 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14652 (DEFINE_DUMMY_FUNCTION): New macro.
14653 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14654 Use it.
c03cd23f
PE
14655 (main): Add casts to avoid warnings
14656 if GCC considers string literals to be constants.
74f10ca7 14657
022e70d4
PE
14658 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14659
59d6fe83
PE
14660 * dbusbind.c: Pointer signedness fixes.
14661 (xd_signature, xd_append_arg, xd_initialize):
14662 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14663 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14664 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14665 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14666
78320123
PE
14667 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14668 if GCC considers string literals to be constants.
49cebcca 14669 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14670
35ac2a97
SM
146712011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14672
fb103ca9
SM
14673 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14674 (print_preprocess, print_object): New macro to fix last change.
14675
35ac2a97
SM
14676 * print.c (print_preprocess): Don't forget font objects.
14677
62973b41
JB
146782011-03-16 Juanma Barranquero <lekktu@gmail.com>
14679
14680 * emacs.c (USAGE3): Doc fixes.
14681
0e48bb22
AS
146822011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14683
14684 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14685 structure.
14686
7684e57b
JB
146872011-03-14 Juanma Barranquero <lekktu@gmail.com>
14688
14689 * lisp.h (VWindow_system, Qfile_name_history):
14690 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14691 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14692 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14693
14694 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14695 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14696
14697 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14698 * w32console.c (detect_input_pending, read_input_pending)
14699 (encode_terminal_code):
14700 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14701 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14702 (w32_system_caret_y, Qfile_name_history):
14703 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14704 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14705 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14706 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14707 * w32proc.c (Qlocal, report_file_error):
14708 * w32term.c (Vwindow_system, updating_frame):
14709 * w32uniscribe.c (initialized, uniscribe_font_driver):
14710 Remove unneeded extern declarations.
14711
2aa46d6c
CY
147122011-03-14 Chong Yidong <cyd@stupidchicken.com>
14713
c96bbc66 14714 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14715
cffc6f3b
CY
147162011-03-13 Chong Yidong <cyd@stupidchicken.com>
14717
14718 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14719 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14720 These macros can no longer be used for assignment.
14721
44f230aa
SM
14722 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14723 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14724 (record_buffer_markers, fetch_buffer_markers): New functions for
14725 recording and fetching special buffer markers.
14726 (set_buffer_internal_1, set_buffer_temp): Use them.
14727
14728 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14729
14730 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14731
14732 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14733 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14734
14735 * xdisp.c (hscroll_window_tree):
14736 (reconsider_clip_changes): Use PT instead of BUF_PT.
14737
d251f04b
EZ
147382011-03-13 Eli Zaretskii <eliz@gnu.org>
14739
14740 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14741 $(EMACS_ROOT)/lib/intprops.h.
14742
f0c77cd1
PE
147432011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14744
3eca4629
PE
14745 Fix more problems found by GCC 4.5.2's static checks.
14746
7c86ee98
PE
14747 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14748 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14749 (xg_free_frame_widgets): Make it clear that a local variable is
14750 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14751 (gdk_window_get_screen): Make it clear that this macro is needed
14752 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14753 (int_gtk_range_get_value): New function, which avoids a diagnostic
14754 from gcc -Wbad-function-cast.
14755 (xg_set_toolkit_scroll_bar_thumb): Use it.
14756 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14757 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14758 (get_utf8_string, xg_get_file_with_chooser):
14759 Rename locals to avoid shadowing.
14760 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14761
41729b81
PE
14762 * xgselect.c (xg_select): Remove unused var.
14763
f0c77cd1
PE
14764 * image.c (four_corners_best): Mark locals as initialized.
14765 (gif_load): Initialize transparent_p to zero (Bug#8238).
14766 Mark another local as initialized.
ec6cf4c6 14767 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14768
ce0ad53d 14769 * image.c (clear_image_cache): Now static.
d5d5a617 14770 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14771 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14772 (x_edge_detection): Remove unnecessary cast that
14773 gcc -Wbad-function-cast diagnoses.
2037898d 14774 (gif_load): Fix pointer signedness.
6ae141d6
PE
14775 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14776 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14777
33383987 147782011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14779
d32df629
PE
14780 Improve quality of tests for time stamp overflow.
14781 For example, without this patch (encode-time 0 0 0 1 1
14782 1152921504606846976) returns the obviously-bogus value (-948597
14783 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14784 reports time overflow. See
14785 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14786 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14787 * editfns.c: Include limits.h and intprops.h.
14788 (TIME_T_MIN, TIME_T_MAX): New macros.
14789 (time_overflow): Move earlier, to before first use.
14790 (hi_time, lo_time): New functions, for an accurate test for
14791 out-of-range times.
14792 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14793 (Fget_internal_run_time): Don't assume time_t fits in int.
14794 (make_time): Use list2 instead of Fcons twice.
14795 (Fdecode_time): More accurate test for out-of-range times.
14796 (check_tm_member): New function.
14797 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14798 (lisp_time_argument): Don't rely on undefined left-shift and
14799 right-shift behavior when checking for time stamp overflow.
8be6f318 14800
fe31d94c
PE
14801 * editfns.c (time_overflow): New function, refactoring common code.
14802 (Fformat_time_string, Fdecode_time, Fencode_time):
14803 (Fcurrent_time_string): Use it.
14804
8be6f318
PE
14805 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14806 * dired.c (make_time): Move to ...
14807 * editfns.c (make_time): ... here.
14808 * systime.h: Note the move.
14809
09d9db2c 148102011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14811
126bc0dc
YM
14812 * fringe.c (update_window_fringes): Remove unused variables.
14813
c47cbdfd
YM
14814 * unexmacosx.c (copy_data_segment): Also copy __got section.
14815 (Bug#8223)
14816
7ac80be9
EZ
148172011-03-12 Eli Zaretskii <eliz@gnu.org>
14818
c96bbc66 14819 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14820 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14821 Constify `char *' arguments and their references according to
14822 prototypes in tparam.h.
14823
ecb0f94d 14824 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14825
7ac80be9
EZ
14826 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14827 Adapt all references accordingly.
14828
14829 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14830
ef1fd07e
TT
148312011-03-11 Tom Tromey <tromey@redhat.com>
14832
14833 * buffer.c (syms_of_buffer): Remove obsolete comment.
14834
7ef4b50c
EZ
148352011-03-11 Eli Zaretskii <eliz@gnu.org>
14836
14837 * termhooks.h (encode_terminal_code): Declare prototype.
14838
14839 * msdos.c (encode_terminal_code): Don't declare prototype.
14840
14841 * term.c (encode_terminal_code): Now external again, used by
14842 w32console.c and msdos.c.
14843
44f230aa
SM
14844 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14845 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14846
4b1ec863 148472011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14848
1714f52b 14849 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14850
4b1ec863
PE
14851 * fringe.c (update_window_fringes): Mark locals as initialized
14852 (Bug#8227).
14853 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14854
524c7aa6
PE
14855 * alloc.c (mark_fringe_data): Move decl from here ...
14856 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14857 to check its interface.
14858 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14859
a5c0af81 14860 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14861 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14862 (fontset_font): Mark local as initialized.
a9a06e0b 14863 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14864
b4716021
PE
14865 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14866
811e9bac 14867 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14868 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14869 (x_own_selection, Fx_disown_selection_internal): Rename locals
14870 to avoid shadowing.
14871 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14872
7e3ab302
PE
14873 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14874 so that the caller can use some name other than gcpro1.
14875 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14876 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14877 (Fx_backspace_delete_keys_p):
14878 Use them to avoid shadowing, and rename vars to avoid shadowing.
14879 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14880 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14881 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14882 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14883 Remove unused locals.
7e3ab302
PE
14884 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14885 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14886 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14887 macros.
f78faa98 14888
e2b13473
PE
14889 * xterm.h (x_mouse_leave): New decl.
14890
77f23912
PE
14891 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14892 Remove unused functions.
cdf4ba58
PE
14893 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14894 (x_calc_absolute_position): Now static.
7411c686 14895 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14896 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14897 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14898 unless they are used.
38d0b34a
PE
14899 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14900 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14901 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14902 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14903 (x_error_catcher, x_connection_closed, x_error_handler):
14904 (x_error_quitter, xembed_send_message, x_iconify_frame):
14905 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14906 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14907 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14908
44f230aa
SM
14909 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14910 Rename or move locals to avoid shadowing.
6b463e58 14911 (tty_defined_color, merge_face_heights): Now static.
5967d051 14912 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14913 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14914 does not deduce is never used uninitialized.
73719eba
PE
14915 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14916 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14917
426994c3 14918 * terminal.c (store_terminal_param): Now static.
5489860b 14919
032f1620 14920 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14921 (set_frame_menubar): Remove unused local.
d4323972 14922 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14923 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14924 since they might point to immutable storage.
281585b0
PE
14925 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14926 since it's unused otherwise.
032f1620 14927
367c19e5 14928 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14929 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14930 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14931 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14932 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14933 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14934 does not deduce are never used uninitialized.
70739cbe 14935
07b48fa9
PE
14936 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14937
8868a238 14938 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14939 * window.c (window_loop, size_window):
14940 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14941
7e5cf297 14942 * window.c (display_buffer): Now static.
d6550a9f
PE
14943 (size_window): Mark variables that gcc -Wuninitialized
14944 does not deduce are never used uninitialized.
a586633d
PE
14945 * window.h (check_all_windows): New decl, to forestall
14946 gcc -Wmissing-prototypes diagnostic.
5b555da1 14947 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14948
f6095868
PE
14949 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14950 shadowing.
14951 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14952 Include <limits.h>.
14953 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14954 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14955 (load_charset_map): Mark variables that gcc -Wuninitialized
14956 does not deduce are never used uninitialized.
53df7c11 14957 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14958
f38b440c
PE
14959 * coding.c (coding_set_source, coding_set_destination):
14960 Use "else { /* comment */ }" rather than "else /* comment */;"
14961 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14962 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14963 a block, when the outer 'i' will do.
14964 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14965 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14966 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14967 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14968 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14969 Rename locals to avoid shadowing.
14970 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14971 * coding.c (emacs_mule_char, encode_invocation_designation):
14972 Now static, since they're not used elsewhere.
413bb2db 14973 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14974 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14975 (decode_coding_emacs_mule): Mark variables that gcc
14976 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14977 (detect_coding_iso_2022): Initialize a local variable that might
14978 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14979 this initialization is needed. (Bug#8211)
5f58e762
PE
14980 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14981 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14982 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14983 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14984 Remove unused macros.
f38b440c 14985
232b38b9 14986 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14987 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14988 * character.c (string_count_byte8): Likewise.
232b38b9 14989
fb90da1b
PE
14990 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14991 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14992
fb93dbc2
PE
14993 * chartab.c (copy_sub_char_table): Now static, since it's not used
14994 elsewhere.
5c156ace
PE
14995 (sub_char_table_ref_and_range, char_table_ref_and_range):
14996 Rename locals to avoid shadowing.
bbcd0949 14997 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14998
7d3b3862 14999 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15000 (BIDI_BOB): Remove unused macro.
7d3b3862 15001
6be7d3da
PE
15002 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15003 deduce are never used uninitialized.
c2ed9c8b 15004 * term.c (encode_terminal_code): Likewise.
6be7d3da 15005
75f8807f 15006 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15007
50938595
PE
15008 * tparam.h: New file.
15009 * term.c, tparam.h: Include it.
15010 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15011 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15012 Move these decls to tparam.h, and make them agree with what
15013 is actually in tparam.c. The previous trick of using incompatible
15014 decls in different modules does not conform to the C standard.
15015 All callers of tparam changed to use tparam's actual API.
15016 * tparam.c (tparam1, tparam, tgoto):
15017 Use const pointers where appropriate.
15018
fbceeba2
PE
15019 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15020 * cm.h (struct cm): Likewise.
15021 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15022 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15023 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15024 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15025 (turn_on_face, init_tty): Likewise.
15026 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15027
7f3f1250
PE
15028 * term.c (term_mouse_position): Rename local to avoid shadowing.
15029
e6ca6543
PE
15030 * alloc.c (mark_ttys): Move decl from here ...
15031 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15032
c40f8d15
AS
150332011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15034
15035 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15036
cfe0661d
JB
150372011-03-09 Juanma Barranquero <lekktu@gmail.com>
15038
15039 * search.c (compile_pattern_1): Remove argument regp, unused since
15040 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15041 (compile_pattern): Don't pass it.
15042
0afb4571
J
150432011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15044
15045 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15046 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15047 for ! HAVE_GTK3.
15048 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15049
15050 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15051
15052 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15053 gdk_window_get_screen, gdk_window_get_geometry,
15054 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15055 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15056 (xg_get_pixbuf_from_pixmap): New function.
15057 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15058 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15059 Call xg_get_pixbuf_from_pixmap instead of
15060 gdk_pixbuf_get_from_drawable.
15061 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15062 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15063 (xg_check_special_colors): Use GtkStyleContext and its functions
15064 for HAVE_GTK3.
15065 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15066 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15067 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15068 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15069 Call gtk_widget_get_preferred_size.
0afb4571
J
15070 (xg_frame_resized): gdk_window_get_geometry only takes 5
15071 parameters.
44f230aa
SM
15072 (xg_win_to_widget, xg_event_is_for_menubar):
15073 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15074 (xg_set_widget_bg): New function.
15075 (delete_cb): New function.
895009e1 15076 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15077 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15078 (xg_set_background_color): Call xg_set_widget_bg.
15079 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15080 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15081 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15082 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15083 if ! HAVE_GTK3.
15084 (update_frame_tool_bar): Call gtk_widget_hide.
15085 (xg_initialize): Use GDK_KEY_g.
15086
15087 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15088 if ! HAVE_GTK3
15089 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15090
15091 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15092 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15093 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15094
1c2cc4ef
JB
150952011-03-08 Juanma Barranquero <lekktu@gmail.com>
15096
15097 * w32xfns.c (select_palette): Check success of RealizePalette against
15098 GDI_ERROR, not zero.
15099
33383987 15100See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15101
15102;; Local Variables:
15103;; coding: utf-8
aac0c6e3
MR
15104;; End:
15105
2f097256 15106 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15107
15108 This file is part of GNU Emacs.
15109
15110 GNU Emacs is free software: you can redistribute it and/or modify
15111 it under the terms of the GNU General Public License as published by
15112 the Free Software Foundation, either version 3 of the License, or
15113 (at your option) any later version.
15114
15115 GNU Emacs is distributed in the hope that it will be useful,
15116 but WITHOUT ANY WARRANTY; without even the implied warranty of
15117 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15118 GNU General Public License for more details.
15119
15120 You should have received a copy of the GNU General Public License
15121 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.