Fix bug #11653 with cursor positioning in a row that has only strings.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2f07e6af
EZ
12012-06-16 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end. If
4 all the glyphs of the glyph row came from strings, and we have no
5 cursor positioning clues, put the cursor on the first glyph of the
6 row. (Bug#11653)
7
29b83cec
AS
82012-06-16 Andreas Schwab <schwab@linux-m68k.org>
9
10 * category.h (CHAR_HAS_CATEGORY): Define as inline.
11 (CATEGORY_MEMBER): Enforce 1/0 value.
12 * category.c (_temp_category_set): Remove.
13
4c5501e9
EZ
142012-06-16 Eli Zaretskii <eliz@gnu.org>
15
16 * window.c (Fdelete_other_windows_internal)
17 (Fdelete_window_internal): Don't access frame's mouse highlight
18 info of the initial frame. (Bug#11677)
19
2b570124
PE
202012-06-14 Paul Eggert <eggert@cs.ucla.edu>
21
e93864f9
PE
22 * .gdbinit (xgetint): Fix recently-introduced paren typo.
23 Assume USE_2_TAGS_FOR_INTS.
24 (xreload): Adjust $tagmask width to match recent lisp.h change.
25
2b570124
PE
26 Simplify lisp.h in minor ways that should not affect code.
27 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
28 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
29 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
30 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
31 (INTTYPEBITS): New macro, for clarity.
32 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
33 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
34 now that USE_LSB_TAG is always defined.
35 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
36 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
37
81755f69
JB
382012-06-13 Juanma Barranquero <lekktu@gmail.com>
39
40 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
41
16192a57
GM
422012-06-13 Glenn Morris <rgm@gnu.org>
43
44 * s/bsd-common.h (BSD4_3):
45 * s/usg5-4-common.h (USG5_4): No longer define; unused.
46
646b5f55
AS
472012-06-13 Andreas Schwab <schwab@linux-m68k.org>
48
49 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
50 instead of union.
51 (XLI, XIL): Define.
52 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
53 them.
54 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
55 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
56 * alloc.c (widen_to_Lisp_Object): Removed.
57 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
58 * frame.c (delete_frame): Remove outdated comment.
59 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
60 USE_LISP_UNION_TYPE.
61 (Fw32_unregister_hot_key): Likewise.
62 (Fw32_toggle_lock_key): Likewise.
63 * w32menu.c (add_menu_item): Likewise.
64 (w32_menu_display_help): Use XIL instead of checking
65 USE_LISP_UNION_TYPE.
66 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
67 (init_heap): Likewise.
68 * w32term.c (w32_read_socket): Update comment.
69
1d3823c9
GM
702012-06-13 Glenn Morris <rgm@gnu.org>
71
c62ff706
GM
72 * s/usg5-4-common.h, src/s/unixware.h:
73 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
74
1d3823c9
GM
75 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
76
bfe3e0a2
PE
772012-06-13 Paul Eggert <eggert@cs.ucla.edu>
78
79 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
80 * alloc.c (make_number) [!defined make_number]:
81 Remove, as lisp.h always defines this now.
82 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
83 (roundup_size): Verify that it is a power of 2.
84 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
85 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
86 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
87 -DUSE_LSB_TAG=0, to override the automatically-selected default.
88 USE_LSB_TAG now is always defined to be either 0 or 1.
89 All uses changed.
90 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
91 code works fine either way, and efficiency is not a concern here,
92 as the union type is for debugging, not for production.
93 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
94 Use an inline function on all platforms when using the union type,
95 since this is simpler and 'static inline' can be used portably
96 within Emacs now.
97 (LISP_INITIALLY_ZERO): New macro.
98 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
99 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
100
45fa9c0f
GM
1012012-06-12 Glenn Morris <rgm@gnu.org>
102
b4492cba
GM
103 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
104
105 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 106
45fa9c0f
GM
107 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
108 Move BROKEN_SIGIO to configure.
109
110 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
111 Move NO_TERMIO to configure.
112
0e25d334
CY
1132012-06-12 Chong Yidong <cyd@gnu.org>
114
115 * image.c (imagemagick_load_image): Use MagickFlattenImage if
116 MagickMergeImageLayers is undefined. Use pixel pusher loop if
117 MagickExportImagePixels is undefined.
118
43682bb6
PE
1192012-06-12 Paul Eggert <eggert@cs.ucla.edu>
120
121 * image.c (imagemagick_load_image): Remove unused label.
122
a9be7d2b
GM
1232012-06-11 Glenn Morris <rgm@gnu.org>
124
125 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
126 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
127 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
128 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
129
3017f87f
SM
1302012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
131
132 * alloc.c (make_byte_code): New function.
133 (Fmake_byte_code): Use it. Don't purify here.
134 * lread.c (read1): Use it as well to avoid extra allocation.
135
1b9b4cf4
CY
1362012-06-11 Chong Yidong <cyd@gnu.org>
137
138 * image.c (imagemagick_load_image): Implement transparency.
139
95988fcf
AS
1402012-06-10 Andreas Schwab <schwab@linux-m68k.org>
141
142 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
143 account for preceding backslashes. (Bug#11663)
144
cd4eb164
CY
1452012-06-09 Chong Yidong <cyd@gnu.org>
146
147 * term.c: Support italics in capable terminals (Bug#9652).
148 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
149 (turn_on_face): Output using TS_enter_italic_mode if available.
150 Don't handle unused blinking and alt-charset cases.
151 (turn_off_face): Handle italic case; discard unused tty_blinking_p
152 and tty_alt_charset_p cases.
153 (tty_capable_p, init_tty): Support italics.
154
155 * termchar.h (struct tty_display_info): Add field for italics.
156 Remove unused blink field.
157
158 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
159 Handle slant.
160
161 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
162 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
163 tty_alt_charset_p. Add tty_italic_p.
164
ff88beb8
MA
1652012-06-09 Michael Albinus <michael.albinus@gmx.de>
166
167 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
168 dbus_type_is_basic if available.
169 (xd_extract_signed, xd_extract_unsigned): Rename from
170 extract_signed and extract_unsigned, respectively. Adapt callers.
171
44286096
CY
1722012-06-09 Chong Yidong <cyd@gnu.org>
173
1682701f
CY
174 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
175
44286096
CY
176 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
177 case (Bug#9752).
178
d86feb17
PE
1792012-06-08 Paul Eggert <eggert@cs.ucla.edu>
180
181 * xdisp.c (vmessage): Treat frame message as multibyte.
182 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
183 would generate the diagnostic "Making \302\247 buffer-local while
184 let-bound!".
185
d5c20fe8
EZ
1862012-06-08 Eli Zaretskii <eliz@gnu.org>
187
188 * dispnew.c (showing_window_margins_p): Undo last change, which
189 was done due to an inadvertent commit.
190 (adjust_frame_glyphs_for_frame_redisplay): Do call
191 showing_window_margins_p.
192
513749ee
SM
1932012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
194
195 * eval.c (Fmake_var_non_special): New primitive.
196 (syms_of_eval): Defsubr it.
197 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
198
d4a8f5c1
JB
1992012-06-08 Juanma Barranquero <lekktu@gmail.com>
200
201 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
202 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
203
8bbbc977
EZ
2042012-06-08 Eli Zaretskii <eliz@gnu.org>
205
206 * alloc.c (allocate_vectorlike): Fix last change.
207
f3372c87
DA
2082012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
209
210 Block-based vector allocation of small vectors.
211 * lisp.h (struct vectorlike_header): New field `nbytes',
212 adjust comment accordingly.
213 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
214 to denote vector blocks. Adjust users (live_vector_p,
215 mark_maybe_pointer, valid_lisp_object_p) accordingly.
216 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
217 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
218 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
219 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
220 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
221 (roundup_size): New constant.
222 (struct vector_block): New data type.
223 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 224 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
225 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
226 (sweep_vectors): New functions.
227 (allocate_vectorlike): Return `zero_vector' as the only vector of
228 0 items. Allocate new vector from block if vector size is less than
229 or equal to VBLOCK_BYTES_MAX.
230 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
231 (init_alloc_once): Add call to init_vectors.
232
4f18a4ed
SM
2332012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
234
235 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
236
86f158bc
PE
2372012-06-07 Paul Eggert <eggert@cs.ucla.edu>
238
239 * doprnt.c (doprnt): Truncate multibyte char correctly.
240 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
241 would mishandle a string argument "Xc" if X was a multibyte
242 character of length 2: it would truncate after X's first byte
243 rather than including all of X.
244
c5cfcbe0
CY
2452012-06-06 Chong Yidong <cyd@gnu.org>
246
247 * buffer.c (word_wrap): Doc fix.
248
c05cf390
PE
2492012-06-04 Paul Eggert <eggert@cs.ucla.edu>
250
251 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
252
0c3461de
GM
2532012-06-03 Glenn Morris <rgm@gnu.org>
254
255 * xdisp.c (tool-bar-style): Doc fix.
256
c71232db
UM
2572012-06-03 Ulrich Müller <ulm@gentoo.org>
258
259 * Makefile.in (PAXCTL): Define.
260 (temacs$(EXEEXT)): Disable memory randomization for the temacs
261 binary via PaX flags if the paxctl utility is available.
262 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
263 Restore PaX flags to their default. (Bug#11398)
264
383f7350
CY
2652012-06-03 Chong Yidong <cyd@gnu.org>
266
267 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
268 buffer (Bug#11226).
269
5f2c76c6
CY
2702012-06-03 Chong Yidong <cyd@gnu.org>
271
272 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
273 (note_mode_line_or_margin_highlight): If there is no help echo,
274 use mode-line-default-help-echo. Handle the case where the mouse
275 position is past the end of the mode line string.
276
277 * buffer.c (buffer_local_value_1): New function, split from
278 Fbuffer_local_value; can return Qunbound.
279 (Fbuffer_local_value): Use it.
280 (Vmode_line_format): Docstring tweaks.
281
773d47f6
PE
2822012-06-02 Paul Eggert <eggert@cs.ucla.edu>
283
284 * sysdep.c (system_process_attributes): Improve comment.
285
f2d6a3df
SM
2862012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
287
288 * keyboard.c: Export real-this-command to Elisp.
289 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
290 and DEFVAR it. Update all users.
291
63810350
PE
2922012-06-02 Paul Eggert <eggert@cs.ucla.edu>
293
7bd5c1f4
PE
294 * minibuf.c (Fassoc_string): Remove duplicate declaration.
295
63810350
PE
296 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
297 Convert pctcpu and pctmem to Lisp float properly.
298 Let the compiler fold better, as 100.0/0x8000 is exact.
299
a2821611
AS
3002012-06-02 Andreas Schwab <schwab@linux-m68k.org>
301
302 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
303 cons_block.
304
5fceba1d
PE
3052012-06-01 Paul Eggert <eggert@cs.ucla.edu>
306
307 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
308
c98ff5dd
DA
3092012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
310
311 For a 'struct window', replace some Lisp_Object fields to
312 bitfields where appropriate, remove unused fields.
313 * window.h (struct window): Remove unused 'last_mark_x' and
314 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
315 change it's type from Lisp_Object to bitfield.
316 Change type of 'force_start', 'optional_new_start',
317 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
318 fields from Lisp_Object to bitfield. Adjust users accordingly.
319
ca34e0be
PE
3202012-05-31 Paul Eggert <eggert@cs.ucla.edu>
321
322 Pacify gcc -Wdouble-precision when using Xaw.
323 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
324 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
325 Use 'float' consistently, rather than 'float' in most places
326 and 'double' in a couple of places.
327
efc00ab1 3282012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
329
330 * xdisp.c (handle_stop): Detect whether we have overlay strings
331 loaded by testing it->current.overlay_string_index to be
332 non-negative, instead of checking whether n_overlay_strings is
333 positive. (Bug#11587)
334
efc00ab1 3352012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
336
337 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
338
339 * doc.c (Fsubstitute_command_keys): Doc fix.
340
efc00ab1 3412012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
342
343 * search.c (search_buffer): Remove calls to
344 r_alloc_inhibit_buffer_relocation, as it is now called by
345 maybe_unify_char, which was the cause of relocation of buffer text
346 in bug#11519.
347
efc00ab1 3482012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
349
350 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
351 for the duration of call to load_charset, to avoid problems with
352 callers of maybe_unify_char that access buffer text through C
353 pointers.
354
355 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
356 decrement the inhibition flag, instead of just setting or
357 resetting it.
358
ba93a187
PE
3592012-05-31 Paul Eggert <eggert@cs.ucla.edu>
360
361 Remove obsolete '#define static' cruft.
362 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
363 This #undef was "temporary" in 2000; it is no longer needed
364 now that '#define static' has gone away.
365 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
366 (gray_bitmap_bits): Remove; no longer needed.
367 All uses replaced with definiens.
368 * xterm.c: Include "bitmaps/gray.xbm".
369
9e4bf381
PE
3702012-05-30 Paul Eggert <eggert@cs.ucla.edu>
371
372 Clean up __executable_start, monstartup when --enable-profiling.
373 The following changes affect the code only when profiling.
374 * dispnew.c (__executable_start): Rename from safe_bcopy.
375 Define only on platforms that need it.
376 * emacs.c: Include <sys/gmon.h> when profiling.
377 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
378 (__executable_start): Remove decl, since lisp.h does it now.
379 (safe_bcopy): Remove decl; no longer has that name.
380 (main): Coalesce #if into single bit of code, for simplicity.
381 Cast pointers to uintptr_t, since standard libraries want integers
382 and not pointers.
383 * lisp.h (__executable_start): New decl.
384
32d72c2f
GM
3852012-05-31 Glenn Morris <rgm@gnu.org>
386
387 * image.c (Fimagemagick_types): Doc fix.
388
baac5bc7
JM
3892012-05-30 Jim Meyering <meyering@redhat.com>
390
391 * callproc.c (Fcall_process_region): Include directory component
392 in mkstemp error message (Bug#11586).
393
72cb32cf
PE
3942012-05-30 Paul Eggert <eggert@cs.ucla.edu>
395
396 * alloc.c, lisp.h (make_pure_vector): Now static.
397
61b108cc
SM
3982012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
399
400 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
401 Move to byte-run.el.
402 (Fautoload): Do the hash-doc more carefully.
403 * data.c (Fdefalias): Purify definition, except for keymaps.
404 (Qdefun): Move from eval.c.
405 * lisp.h (Qdefun): Remove.
406 * lread.c (read1): Tiny simplification.
407
471fe23d
TN
4082012-05-29 Troels Nielsen <bn.troels@gmail.com>
409
934f3f58 410 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
411 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
412 Bug#9642, but explicitly check that the buffer the overlay would
413 be moved to is live and rearrange lines to make sure that errors
414 will not put the overlay in an inconsistent state.
415 (Fdelete_overlay): Cosmetics.
416
85d0efd1
EZ
4172012-05-28 Eli Zaretskii <eliz@gnu.org>
418
419 * w32term.c (my_bring_window_to_top): New function.
420 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
421 could be different from the original one.
422 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
423 (Bug#11513)
424
425 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
426 by calling BringWindowToTop.
427
428 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
429 (WM_EMACS_END): Increase by one.
430
da92a98c
PE
4312012-05-28 Paul Eggert <eggert@cs.ucla.edu>
432
433 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
434 This avoids undefined behavior that might cause the eassert
435 to not catch an out-of-range value.
436
74d1f848
JB
4372012-05-28 Juanma Barranquero <lekktu@gmail.com>
438
439 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
440 Update dependencies.
441
9e1a06fc
EZ
4422012-05-27 Eli Zaretskii <eliz@gnu.org>
443
444 * bidi.c (bidi_mirror_char): Fix last change.
445
f3dd7312
AS
4462012-05-27 Andreas Schwab <schwab@linux-m68k.org>
447
448 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
449 when referring to sectname field in printf format.
450
81899c91
PE
4512012-05-27 Paul Eggert <eggert@cs.ucla.edu>
452
57b81a9f
PE
453 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
454 Only r_alloc_inhibit_buffer_relocation needed to be added;
455 the others were already declared.
456
81899c91
PE
457 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
458 before checking whether it's out of range. Put the check inside
459 eassert. See
460 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
461
33017faf 4622012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
463
464 * callproc.c (Fcall_process): Restore a line that was accidentally
465 commented out in the 2011-02-13 change (bug#11547).
466
33017faf 4672012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
468
469 * lisp.h [REL_ALLOC]: Add prototypes for external functions
470 defined on ralloc.c.
471
472 * buffer.c [REL_ALLOC]: Remove prototypes of
473 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
474 they are now on lisp.h.
475
476 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
477
478 * search.c (search_buffer): Use it to inhibit relocation of buffer
479 text while re_search_2 is doing its job, because re_search_2 is
480 passed C pointers to buffer text. (Bug#11519)
481
23415acf
EZ
482 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
483 Update value to 24.
484
44e27368
EZ
485 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
486 state after an additional call to move_it_in_display_line_to, keep
487 the values of it->max_ascent and it->max_descent found for the
488 entire line.
489 (pos_visible_p): Revert the comparison against bottom_y to what it
490 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
491 (Bug#11464)
492
c1892f11
PE
4932012-05-26 Paul Eggert <eggert@cs.ucla.edu>
494
495 Fix coding-related core dumps with gcc -ftrapv.
496 The code was computing A - B, where A and B are pointers, and B is
497 random garbage. This can lead to core dumps on platforms that
498 have special pointer registers, and it also leads to core dumps on
499 x86-64 when compiled with gcc -ftrapv. The fix is to compute
500 A - B only when B is initialized properly.
501 * coding.c (coding_set_source, coding_set_destination): Return void.
502 (coding_change_source, coding_change_destinations): New functions,
503 with the old behaviors of coding_set_source and coding_set_destination.
504 All callers that need an offset changed to use these new functions.
505
eb7afdad
GM
5062012-05-26 Glenn Morris <rgm@gnu.org>
507
508 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
509
f12fdf02
EZ
5102012-05-26 Eli Zaretskii <eliz@gnu.org>
511
53a63be6 512 Extend mouse support on W32 text-mode console.
61b108cc
SM
513 * xdisp.c (draw_row_with_mouse_face):
514 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 515
eb3f6f01 516 * w32console.c: Include window.h.
61b108cc
SM
517 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
518 New functions.
eb3f6f01
EZ
519 (initialize_w32_display): Initialize mouse-highlight data.
520
53a63be6
EZ
521 * w32inevt.c: Include termchar.h and window.h.
522 (do_mouse_event): Support mouse-autoselect-window. When the mouse
523 moves, call note_mouse_highlight. If help_echo changed, call
524 gen_help_event to produce help-echo message in the echo area.
525 Call clear_mouse_face if mouse_face_hidden is set in the mouse
526 highlight info.
527
4cfd81f6
PE
5282012-05-26 Paul Eggert <eggert@cs.ucla.edu>
529
530 * lread.c (read1): Simplify slightly to avoid an overflow warning
531 with GCC 4.7.0 on x86-64.
532
4446092a
EZ
5332012-05-26 Eli Zaretskii <eliz@gnu.org>
534
535 * bidi.c (bidi_mirror_char): Revert last change: an int is
536 definitely wide enough here.
537
42b2a986 5382012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 539
42b2a986 540 Fix integer width and related bugs (Bug#9874).
eb106a49 541 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
542 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
543 (string_bytes, check_sblock, allocate_string_data):
544 (compact_small_strings, Fmake_bool_vector, make_string)
545 (make_unibyte_string, make_multibyte_string)
546 (make_string_from_bytes, make_specified_string)
547 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
548 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
549 (mark_vectorlike):
550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
551 (allocate_pseudovector):
552 Use int, not EMACS_INT, where int is wide enough.
553 (inhibit_garbage_collection, Fgarbage_collect):
554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
555 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
556 int might not be wide enough.
557 (bidi_cache_search, bidi_cache_find, bidi_init_it)
558 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
559 (bidi_at_paragraph_end, bidi_find_paragraph_start)
560 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
561 (bidi_level_of_next_char, bidi_move_to_visually_next):
562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
563 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
564 (Fkill_buffer, Fset_buffer_major_mode)
565 (advance_to_char_boundary, Fbuffer_swap_text)
566 (Fset_buffer_multibyte, overlays_at, overlays_in)
567 (overlay_touches_p, struct sortvec, record_overlay_string)
568 (overlay_strings, recenter_overlay_lists)
569 (adjust_overlays_for_insert, adjust_overlays_for_delete)
570 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
571 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
572 (Foverlay_recenter, last_overlay_modification_hooks_used)
573 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
574 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
575 (validate_region): Omit unnecessary test for b <= e,
576 since that's guaranteed by the previous test.
d311d28c
PE
577 (adjust_overlays_for_delete): Avoid pos + length overflow.
578 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
579 (report_overlay_modification):
580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
581 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
582 Omit pointer cast, which isn't needed anyway, and doesn't work
583 after the EMACS_INT -> ptrdiff_t change.
02481186 584 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
585 * buffer.h: Adjust decls to match defn changes elsewhere.
586 (struct buffer_text, struct buffer):
587 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
588 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
589 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
590 not int, to avoid needless 32-bit limit on 64-bit hosts.
591 (exec_byte_code): Use tighter memory-full test, one that checks
592 for alloca overflow. Don't compute the address of the object just
593 before an array, as that's not portable. Use EMACS_INT, not
594 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
595 * callint.c (Fcall_interactively):
596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
597 * callproc.c (call_process_kill, Fcall_process):
598 Don't assume pid_t fits into an Emacs fixnum.
599 (call_process_cleanup, Fcall_process, child_setup):
600 Don't assume pid_t fits into int.
601 (call_process_cleanup, Fcall_process, delete_temp_file)
602 (Fcall_process_region):
603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
604 (Fcall_process): Simplify handling of volatile integers.
605 Use int, not EMACS_INT, where int will do.
606 * casefiddle.c (casify_object, casify_region, operate_on_word)
607 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
609 (casify_object): Avoid integer overflow when overallocating buffer.
610 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 611 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
612 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
613 * category.h (CATEGORYP): Don't assume arg is nonnegative.
614 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
615 integers are now checked earlier. All uses replaced with XINT.
616 (ccl_driver):
617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
618 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
619 (ccl_driver, Fregister_code_conversion_map):
620 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
621 (resolve_symbol_ccl_program): Check that vector header is in range.
622 Always copy the vector, so that we can check its contents reliably
623 now rather than having to recheck each instruction as it's being
624 executed. Check that vector words fit in 'int'.
625 (ccl_get_compiled_code, Fregister_ccl_program)
626 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
627 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
628 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
629 contents are in range.
630 (Fccl_execute_on_string): Check that status is in range.
631 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
632 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
633 Accept and return EMACS_INT, not int, because callers can pass values
634 out of 'int' range.
635 (c_string_width, strwidth, lisp_string_width, chars_in_text)
636 (multibyte_chars_in_text, parse_str_as_multibyte)
637 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
638 (str_as_unibyte, str_to_unibyte, string_count_byte8)
639 (string_escape_byte8, Fget_byte):
640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 641 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
642 avoid mishandling large integers.
643 * character.h: Adjust decls to match defn changes elsewhere.
644 * charset.c (load_charset_map_from_file, find_charsets_in_text)
645 (Ffind_charset_region):
646 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
647 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
648 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 649 Don't assume fixnum fits in int.
d311d28c
PE
650 (load_charset_map_from_vector, Fmap_charset_chars):
651 Remove now-unnecessary CHECK_NATNUMs.
652 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
653 Don't rely on undefined behavior with signed left shift overflow.
654 Don't assume unsigned int fits into fixnum, or that fixnum fits
655 into unsigned int. Don't require max_code to be a valid fixnum;
656 that's not true for gb10830 4-byte on a 32-bit host. Allow
657 invalid_code to be a cons, for the same reason. Require code_offset
658 to be a character. Avoid int overflow if max_char is close
659 to INT_MAX.
660 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
661 this is intended anyway and avoids some undefined behavior.
662 (load_charset_map): Pass unsigned, not int, as 2nd arg of
663 INDEX_TO_CODE_POINT, as that's what it expects.
664 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
665 * charset.h (DECODE_CHAR): Return int, not unsigned;
666 this is what was intended anyway, and it avoids undefined behavior.
667 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
668 integer-overflow issues.
669 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
670 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
671 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
672 * chartab.c (Fmake_char_table, Fset_char_table_range)
673 (uniprop_get_decoder, uniprop_get_encoder):
674 Don't assume fixnum fits in int.
675 * cmds.c (move_point): New function, that does the gist of
676 Fforward_char and Fbackward_char, but does so while checking
677 for integer overflow more accurately.
c96e5d6a 678 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
679 (Fforward_line, Fend_of_line, internal_self_insert)
680 (internal_self_insert):
681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
682 Fix a FIXME, by checking for integer overflow when calculating
683 target_clm and actual_clm.
684 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 685 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
686 (ASSURE_DESTINATION, coding_alloc_by_realloc)
687 (coding_alloc_by_making_gap, alloc_destination)
688 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
689 (encode_coding_utf_16, detect_coding_emacs_mule)
690 (decode_coding_emacs_mule, encode_coding_emacs_mule)
691 (detect_coding_iso_2022, decode_coding_iso_2022)
692 (encode_invocation_designation, encode_designation_at_bol)
693 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
694 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
695 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
696 (encode_coding_ccl, encode_coding_raw_text)
697 (detect_coding_charset, decode_coding_charset)
698 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
699 (produce_composition, produce_charset, produce_annotation)
700 (decode_coding, handle_composition_annotation)
701 (handle_charset_annotation, consume_chars, decode_coding_gap)
702 (decode_coding_object, encode_coding_object, detect_coding_system)
703 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
704 (code_convert_region, code_convert_string)
8f50130c
PE
705 (Fdefine_coding_system_internal)
706 (coding_set_source, coding_set_destination):
d311d28c
PE
707 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
708 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
709 (Fdefine_coding_system_internal):
710 Don't assume fixnums fit in int.
711 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 712 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
713 (Funencodable_char_position, Fcheck_coding_systems_region)
714 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 716 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 717 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 718 Don't access memory outside of the args array.
d311d28c 719 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
720 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
721 result of ENCODE_CHAR.
d311d28c
PE
722 * coding.h: Adjust decls to match defn changes elsewhere.
723 (struct coding_system):
724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
725 * composite.c (get_composition_id, find_composition)
726 (run_composition_function, update_compositions)
727 (compose_text, composition_gstring_put_cache)
728 (composition_gstring_p, composition_gstring_width)
729 (fill_gstring_header, fill_gstring_body, autocmp_chars)
730 (composition_compute_stop_pos, composition_reseat_it)
731 (composition_update_it, struct position_record)
732 (find_automatic_composition, composition_adjust_point)
733 (Fcomposition_get_gstring, Ffind_composition_internal):
734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
735 (update_compositions):
736 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
737 * composite.h: Adjust decls to match defn changes elsewhere.
738 (struct composition):
739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
740 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
741 Do not attempt to compute the address of the object just before a
742 buffer; this is not portable.
743 (Faref, Faset):
744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
745 (Faset): Use int, not EMACS_INT, where int is wide enough.
746 (Fstring_to_number): Don't assume fixnums fit in int.
747 (Frem): Don't assume arg is nonnegative.
748 * dbusbind.c (xd_append_arg): Check for integers out of range.
749 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 750 (extract_signed, extract_unsigned): New functions.
243e0530
PE
751 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
752 (xd_get_connection_references): Return ptrdiff_t, not int.
753 All uses changed.
754 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
755 (xd_read_message_1):
756 Use int, not unsigned, where the dbus API uses int.
757 (Fdbus_message_internal): Don't overflow mtype.
758 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
759 * dired.c (directory_files_internal, file_name_completion, scmp)
760 (file_name_completion_stat):
761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
762 (file_name_completion): Don't overflow matchcount.
763 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
764 * dispextern.h: Adjust decls to match defn changes elsewhere.
765 (struct text_pos, struct glyph, struct bidi_saved_info)
766 (struct bidi_string_data, struct bidi_it, struct composition_it)
767 (struct it):
768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
769 (struct display_pos, struct composition_it, struct it):
770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
771 * dispnew.c (increment_matrix_positions)
772 (increment_row_positions, mode_line_string)
773 (marginal_area_string):
774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 775 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
777 (duration_to_sec_usec): New function, to check for overflow better.
778 (Fsleep_for, sit_for): Use it.
779 * doc.c (get_doc_string, store_function_docstring):
780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
781 (get_doc_string, Fsnarf_documentation):
782 Use int, not EMACS_INT, where int is wide enough.
783 (get_doc_string):
784 Use SAFE_ALLOCA, not alloca.
785 Check for overflow when converting EMACS_INT to off_t.
786 * doprnt.c (doprnt):
787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
788 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
789 Don't assume uid_t fits into fixnum.
790 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
791 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
792 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
793 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
794 (general_insert_function)
795 (Finsert_char, make_buffer_string, make_buffer_string_both)
796 (update_buffer_properties, Fbuffer_substring)
797 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
798 (Fsubst_char_in_region, check_translation)
799 (Ftranslate_region_internal, save_restriction_restore, Fformat)
800 (transpose_markers, Ftranspose_regions):
801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
802 (clip_to_bounds): Move to lisp.h as an inline function).
803 (Fconstrain_to_field): Don't assume integers are nonnegative.
804 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
805 (Fsubst_char_in_region, Fsave_restriction):
806 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
807 (Femacs_pid): Don't assume pid_t fits into fixnum.
808 (lo_time): Use int, not EMACS_INT, when int suffices.
809 (lisp_time_argument): Check for usec out of range.
810 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
811 (Fuser_login_name, Fuser_full_name): Signal an error
812 if a uid argument is out of range, rather than relying on
813 undefined behavior.
c8d5c857
PE
814 (Fformat_time_string): Remove now-unnecessary check.
815 lisp_time_argument checks for out-of-range usec now.
243e0530 816 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
817 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
818 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
819 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
820 (init_cmdargs, Fdump_emacs):
821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
822 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
823 the bottom (typically) 32 bits of the fixnum.
824 * eval.c (specpdl_size, call_debugger):
825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
826 (when_entered_debugger, Fbacktrace_debug):
827 Don't assume fixnum can fit in int.
828 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
829 the object just before a buffer; this is not portable.
830 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
831 (grow_specpdl, unbind_to):
832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
833 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
834 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 835 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
836 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
837 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
839 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
840 (a_write, e_write):
841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
842 (Fcopy_file, non_regular_nbytes, read_non_regular)
843 (Finsert_file_contents):
844 Use int, not EMACS_INT, where int is wide enough.
845 (READ_BUF_SIZE): Verify that it fits in int.
846 (Finsert_file_contents): Check that counts are in proper range,
847 rather than assuming fixnums fit into ptrdiff_t etc.
848 Don't assume fixnums fit into int.
125b3835 849 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
850 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
851 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
852 (string_char_to_byte, string_byte_to_char)
853 (string_make_multibyte, string_to_multibyte)
854 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
855 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
856 (substring_both, Fdelete, internal_equal, Ffillarray)
857 (Fclear_string, mapcar1)
858 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
859 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
860 (larger_vector, make_hash_table, maybe_resize_hash_table)
861 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
862 (Fmaphash, secure_hash):
863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
864 (concat): Check for string index and length overflow.
865 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
866 (Frequire):
867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
868 (larger_vector): New API (vec, incr_min, size_max) replaces old
869 one (vec, new_size, init). This catches size overflow.
870 INIT was removed because it was always Qnil.
871 All callers changed.
872 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
873 the upper bound on a hash table index size.
874 (make_hash_table, maybe_resize_hash_table): Use it.
875 (secure_hash): Computer start_byte and end_byte only after
876 they're known to be in ptrdiff_t range.
877 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
878 (Ffont_get_glyphs, Ffont_at):
879 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
880 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
881 (Flist_fonts, Fopen_font):
882 Don't assume fixnum can fit in int.
883 (check_gstring): Don't assume index can fit in int.
884 (font_match_p): Check that fixnum is a character, not a nonnegative
885 fixnum, since the later code needs to stuff it into an int.
886 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
887 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
888 conversion overflow issues.
889 (Fopen_font): Check for integer out of range.
890 (Ffont_get_glyphs): Don't assume index can fit in int.
891 * font.h: Adjust decls to match defn changes elsewhere.
892 * fontset.c (reorder_font_vector): Redo score calculation to avoid
893 integer overflow.
894 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
895 printmax_t, where ptrdiff_t is wide enough.
896 (Finternal_char_font):
897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
898 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
899 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
900 (Fset_frame_position, x_set_frame_parameters)
901 (x_set_line_spacing, x_set_border_width)
902 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
903 Check that fixnums are in proper range for system types.
904 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
906 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
907 Use SAFE_ALLOCA_LISP, not alloca.
908 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
909 intptr_t is wide enough.
910 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
911 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
912 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
913 Check for fixnum out of range.
914 * ftfont.c (ftfont_list): Don't assume index fits in int.
915 Check that fixnums are in proper range for system types.
916 (ftfont_shape_by_flt):
917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
918 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
920 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
921 Check that fixnums are in proper range for system types.
922 * gnutls.h: Adjust decls to match defn changes elsewhere.
923 * gtkutil.c (xg_dialog_run):
924 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
925 (update_frame_tool_bar):
926 Check that fixnums are in proper range for system types.
927 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 928 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
929 * indent.c (last_known_column, last_known_column_point):
930 (current_column_bol_cache):
931 (skip_invisible, current_column, check_display_width):
932 (check_display_width, scan_for_column, current_column_1)
933 (Findent_to, Fcurrent_indentation, position_indentation)
934 (indented_beyond_p, Fmove_to_column, compute_motion):
935 (Fcompute_motion, Fvertical_motion):
936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
937 (last_known_column_modified): Use EMACS_INT, not int.
938 (check_display_width):
939 (Fcompute_motion):
940 Check that fixnums and floats are in proper range for system types.
941 (compute_motion): Don't assume index or fixnum fits in int.
942 (compute_motion, Fcompute_motion):
943 Use int, not EMACS_INT, when it is wide enough.
944 (vmotion): Omit local var start_hpos that is always 0; that way
945 we don't need to worry about overflow in expressions involving it.
946 * indent.h: Adjust decls to match defn changes elsewhere.
947 (struct position):
948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
949 Use int, not EMACS_INT, where int is wide enough.
950 Remove unused members ovstring_chars_done and tab_offset;
951 all uses removed.
952 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
953 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
954 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
955 (make_gap, copy_text, insert, insert_and_inherit)
956 (insert_before_markers, insert_before_markers_and_inherit)
957 (insert_1, count_combining_before, count_combining_after)
958 (insert_1_both, insert_from_string)
959 (insert_from_string_before_markers, insert_from_string_1)
960 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
961 (adjust_after_replace, adjust_after_insert, replace_range)
962 (replace_range_2, del_range, del_range_1, del_range_byte)
963 (del_range_both, del_range_2, modify_region)
964 (prepare_to_modify_buffer, signal_before_change)
965 (signal_after_change, Fcombine_after_change_execute):
966 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
967 * intervals.c (traverse_intervals, rotate_right, rotate_left)
968 (balance_an_interval, split_interval_right, split_interval_left)
969 (find_interval, next_interval, update_interval)
970 (adjust_intervals_for_insertion, delete_node, delete_interval)
971 (interval_deletion_adjustment, adjust_intervals_for_deletion)
972 (static_offset_intervals, offset_intervals)
973 (merge_interval_right, merge_interval_left, make_new_interval)
974 (graft_intervals_into_buffer, temp_set_point_both)
975 (temp_set_point, set_point, adjust_for_invis_intang)
976 (set_point_both, move_if_not_intangible, get_property_and_range)
977 (get_local_map, copy_intervals, copy_intervals_to_string)
978 (compare_string_intervals, set_intervals_multibyte_1):
979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
980 * intervals.h: Adjust decls to match defn changes elsewhere.
981 (struct interval):
982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
983 * keyboard.c (this_command_key_count, this_single_command_key_start)
984 (before_command_key_count, before_command_echo_length, echo_now)
985 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
986 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
987 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
988 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
990 (last_non_minibuf_size, last_point_position, echo_truncate)
991 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
992 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
993 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
994 (stuff_buffered_input):
995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
996 (last_auto_save, command_loop_1, read_char):
997 Use EMACS_INT, not int, to avoid integer overflow.
998 (record_char): Avoid overflow in total_keys computation.
999 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1000 * keyboard.h: Adjust decls to match defn changes elsewhere.
1001 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1002 (Fkey_description, Fdescribe_vector, Flookup_key):
1003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1004 (click_position): New function, to check that positions are in range.
1005 (Fcurrent_active_maps):
1006 (describe_command):
1007 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1008 (Faccessible_keymaps, Fkey_description):
1009 (preferred_sequence_p):
1010 Don't assume fixnum can fit into int.
1011 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1012 Check for integer overflow in size calculations.
1013 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1014 avoid mishandling large integers.
1015 * lisp.h: Adjust decls to match defn changes elsewhere.
1016 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1017 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1018 (struct Lisp_Marker):
1019 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1020 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1021 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1022 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1023 All callers changed.
1024 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1025 Assume the arg has valid form, since it always does.
1026 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1027 unsigned integer system type.
1028 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1029 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1031 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1032 (duration_to_sec_usec): New decl.
1033 * lread.c (read_from_string_index, read_from_string_index_byte)
1034 (read_from_string_limit, readchar, unreadchar, openp)
1035 (read_internal_start, read1, oblookup):
1036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1037 (Fload, readevalloop, Feval_buffer, Feval_region):
1038 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1039 (openp): Check for out-of-range argument to 'access'.
1040 (read1): Use int, not EMACS_INT, where int is wide enough.
1041 Don't assume fixnum fits into int.
6efdadfd 1042 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1043 (read_filtered_event): Use duration_to_sec_usec
1044 to do proper overflow checking on durations.
d311d28c
PE
1045 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1046 in size calculation.
1047 (Fexecute_kbd_macro):
1048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1049 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1050 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1051 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1052 (set_marker_both, set_marker_restricted_both, marker_position)
1053 (marker_byte_position, Fbuffer_has_markers_at):
1054 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1055 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1056 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1057 It now merely ensures that the menu is large enough, without
1058 necessarily growing it, as this avoids some integer overflow issues.
1059 All callers changed.
1060 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1062 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1063 Use SAFE_ALLOCA_LISP, not alloca.
1064 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1065 to EMACS_INT. Check that fixnums are in proper range for system types.
1066 * minibuf.c (minibuf_prompt_width, string_to_object)
1067 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1068 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1069 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1070 (get_minibuffer, read_minibuf_unwind):
1071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1072 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1073 this simplifies overflow checking. All callers changed.
1074 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1075 (Ftest_completion):
1076 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1077 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1078 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1079 Check that fixnums are in proper range for system types.
1080 (Fx_create_frame, Fx_show_tip):
1081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1082 * nsfont.m (ns_findfonts, nsfont_list_family):
1083 Don't assume fixnum fits in long.
1084 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1086 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1087 wide enough.
17fdb222 1088 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1090 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1091 (PRINTDECLARE, PRINTPREPARE):
1092 (strout, print_string):
1093 (print, print_preprocess, print_check_string_charset_prop)
1094 (print_object):
1095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1096 (PRINTDECLARE):
1097 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1099 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1100 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1101 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1102 (print_error_message): Use SAFE_ALLOCA, not alloca.
1103 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1104 (print_depth, new_backquote_output, print_number_index):
1105 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1106 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1107 (Fset_process_window_size, Fformat_network_address)
1108 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1109 (sigchld_handler):
d311d28c 1110 Check that fixnums are in proper range for system types.
d44287d4 1111 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1112 Check for process-ids out of pid_t range rather than relying on
1113 undefined behavior.
e4d81efc 1114 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1115 (Fformat_network_address, read_process_output, send_process)
1116 (Fprocess_send_region, status_notify):
1117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1118 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1119 (wait_reading_process_output, read_process_output, exec_sentinel):
1120 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1121 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1122 (Faccept_process_output): Use duration_to_sec_usec to do proper
1123 overflow checking on durations.
dde14581
PE
1124 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1125 Don't assume pid_t fits in int.
02481186
PE
1126 * process.h (struct Lisp_Process): Members tick and update_tick
1127 are now of type EMACS_INT, not int.
b62b53e8
PE
1128 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1129 configured --with-wide-int.
d311d28c
PE
1130 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1131 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1132 * search.c (looking_at_1, string_match_1):
1133 (fast_string_match, fast_c_string_match_ignore_case)
1134 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1135 (scan_newline, find_before_next_newline, search_command)
1136 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1137 (set_search_regs, wordify):
1138 (Freplace_match):
1139 (Fmatch_data):
1140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1141 (string_match_1, search_buffer, set_search_regs):
1142 (Fmatch_data):
1143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1144 (wordify): Check for overflow in size calculation.
1145 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1146 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1147 Check that fixnums are in proper range for system types.
1148 * sound.c (struct sound_device)
1149 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1151 (Fplay_sound_internal):
1152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1153 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1154 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1155 (Fparse_partial_sexp):
1156 Don't assume fixnums can fit in int.
1157 (struct lisp_parse_state, find_start_pos, find_start_value)
1158 (find_start_value_byte, find_start_begv)
1159 (update_syntax_table, char_quoted, dec_bytepos)
1160 (find_defun_start, prev_char_comend_first, back_comment):
1161 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1162 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1164 (Finternal_describe_syntax_value): Check that match_lisp is a
1165 character, not an integer, since the code stuffs it into int.
1166 (scan_words, scan_sexps_forward):
1167 Check that fixnums are in proper range for system types.
1168 (Fforward_word):
1169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1170 (scan_sexps_forward):
1171 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1172 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1173 * syntax.h: Adjust decls to match defn changes elsewhere.
1174 (struct gl_state_s):
1175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1176 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1177 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1178 * sysdep.c (wait_for_termination_1, wait_for_termination)
1179 (interruptible_wait_for_termination, mkdir):
1180 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1181 (emacs_read, emacs_write):
1182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1183 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1184 and double all fit in int.
d311d28c
PE
1185 * term.c (set_tty_color_mode):
1186 Check that fixnums are in proper range for system types.
1187 * termhooks.h (struct input_event):
1188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1189 * textprop.c (validate_interval_range, interval_of)
1190 (Fadd_text_properties, set_text_properties_1)
1191 (Fremove_text_properties, Fremove_list_of_text_properties)
1192 (Ftext_property_any, Ftext_property_not_all)
1193 (copy_text_properties, text_property_list, extend_property_ranges)
1194 (verify_interval_modification):
1195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1196 (Fnext_single_char_property_change)
1197 (Fprevious_single_char_property_change):
1198 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1199 (copy_text_properties):
1200 Check for integer overflow in index calculation.
d311d28c
PE
1201 * undo.c (last_boundary_position, record_point, record_insert)
1202 (record_delete, record_marker_adjustment, record_change)
1203 (record_property_change):
1204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1205 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1207 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1208 (Fx_hide_tip, Fx_file_dialog):
1209 * w32menu.c (set_frame_menubar):
1210 Use ptrdiff_t, not int, for consistency with rest of code.
1211 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1212 (select_window, Fdelete_other_windows_internal)
1213 (window_scroll_pixel_based, window_scroll_line_based)
1214 (Frecenter, Fset_window_configuration):
1215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1216 (Fset_window_hscroll, run_window_configuration_change_hook)
1217 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1218 (Fscroll_other_window, Frecenter):
d311d28c
PE
1219 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1220 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1221 Don't assume fixnum fits in int.
1222 (Fset_window_scroll_bars):
1223 Check that fixnums are in proper range for system types.
1224 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1225 (string_pos, c_string_pos, number_of_chars, init_iterator)
1226 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1227 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1228 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1229 (face_before_or_after_it_pos, handle_invisible_prop)
1230 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1231 (display_prop_intangible_p, string_buffer_position_lim)
1232 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1233 (get_overlay_strings_1, get_overlay_strings)
1234 (iterate_out_of_display_property, forward_to_next_line_start)
1235 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1236 (get_next_display_element, set_iterator_to_next)
1237 (get_visually_first_element, compute_stop_pos_backwards)
1238 (handle_stop_backwards, next_element_from_buffer)
1239 (move_it_in_display_line_to, move_it_in_display_line)
1240 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1241 (add_to_log, message_dolog, message_log_check_duplicate)
1242 (message2, message2_nolog, message3, message3_nolog
1243 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1244 (current_message_1, truncate_echo_area, truncate_message_1)
1245 (set_message, set_message_1, store_mode_line_noprop)
1246 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1247 (text_outside_line_unchanged_p, check_point_in_composition)
1248 (reconsider_clip_changes)
1249 (redisplay_internal, set_cursor_from_row, try_scrolling)
1250 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1251 (redisplay_window, find_last_unchanged_at_beg_row)
1252 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1253 (trailing_whitespace_p, find_row_edges, display_line)
1254 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1255 (display_mode_element, store_mode_line_string)
1256 (pint2str, pint2hrstr, decode_mode_spec)
1257 (display_count_lines, display_string, draw_glyphs)
1258 (x_produce_glyphs, x_insert_glyphs)
1259 (rows_from_pos_range, mouse_face_from_buffer_pos)
1260 (fast_find_string_pos, mouse_face_from_string_pos)
1261 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1263 (safe_call, init_from_display_pos, handle_fontified_prop)
1264 (handle_single_display_spec, load_overlay_strings)
1265 (with_echo_area_buffer, setup_echo_area_for_printing)
1266 (display_echo_area, echo_area_display)
1267 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1268 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1269 (redisplay_window, dump_glyph_row, display_mode_line)
1270 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1271 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1273 (handle_single_display_spec, build_desired_tool_bar_string)
1274 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1275 (get_specified_cursor_type):
1276 Check that fixnums are in proper range for system types.
1277 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1278 (Flookup_image_map):
1279 Don't assume fixnums fit in int.
1280 (compare_overlay_entries):
1281 Avoid mishandling comparisons due to subtraction overflow.
1282 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1283 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1284 (handle_tool_bar_click):
1285 Use int, not unsigned, since we prefer signed and the signedness
1286 doesn't matter here.
1287 (get_next_display_element, next_element_from_display_vector):
1288 Use int, not EMACS_INT, when int is wide enough.
1289 (start_hourglass): Use duration_to_sec_usec to do proper
1290 overflow checking on durations.
1291 * xfaces.c (Fbitmap_spec_p):
1292 Check that fixnums are in proper range for system types.
1293 (compare_fonts_by_sort_order):
1294 Avoid mishandling comparisons due to subtraction overflow.
1295 (Fx_family_fonts, realize_basic_faces):
1296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1297 (Fx_family_fonts):
1298 Don't assume fixnum fits in int.
1299 Use SAFE_ALLOCA_LISP, not alloca.
1300 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1301 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1302 (face_at_buffer_position, face_for_overlay_string)
1303 (face_at_string_position):
1304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1305 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1306 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1307 (Fx_show_tip):
1308 Check that fixnums are in proper range for system types.
1309 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1310 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1312 (Fx_change_window_property): Don't assume fixnums fit in int.
1313 * xfont.c (xfont_chars_supported):
1314 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1315 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1316 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1318 * xml.c (parse_region):
1319 * xrdb.c (magic_file_p):
1320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1321 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1322 (x_get_local_selection, x_reply_selection_request)
1323 (x_handle_selection_request, wait_for_property_change):
1324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1325 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1326 short is wide enough.
1327 (x_send_client_event): Don't assume fixnum fits in int.
1328 * xterm.c (x_x_to_emacs_modifiers):
1329 Don't assume EMACS_INT overflows nicely into int.
1330 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1331 may come from Lisp.
1332 (handle_one_xevent): NATNUMP can eval its arg twice.
1333 (x_connection_closed):
1334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1335 * xterm.h: Adjust decls to match defn changes elsewhere.
1336 (struct scroll_bar): Use struct vectorlike_header
1337 rather than rolling our own approximation.
1338 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1339
c6574eb5
GM
13402012-05-25 Glenn Morris <rgm@gnu.org>
1341
1342 * lisp.mk (lisp): Update for more files being compiled now.
1343
e8d32c7e
SM
13442012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1345
48def666
SM
1346 * lread.c: Remove `read_pure' which makes no difference.
1347 (read_pure): Remove var.
1348 (unreadpure): Remove function.
1349 (readevalloop): Don't call read_list with -1 flag.
1350 (read1, read_vector): Don't test read_pure any more.
1351 (read_list): Simplify.
1352
e8d32c7e
SM
1353 * fileio.c, character.h: Minor style tweaks.
1354
4b2addb7
DA
13552012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1356
1357 * window.h (clip_changed): Remove useless declaration.
1358
584461b2
JB
13592012-05-22 Juanma Barranquero <lekktu@gmail.com>
1360
1361 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1362 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1363
34374650
PE
13642012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 Remove src/m/*.
1367 This directory predates autoconf and is no longer needed nowadays.
1368 Move its few remaining bits of functionality to where they're needed.
1369 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1370 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1371 * m/template.h: Remove.
1372 * Makefile.in (M_FILE): Remove. All uses removed.
1373 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1374 * lisp.h (USE_LSB_TAG):
1375 * mem-limits.h (EXCEEDS_LISP_PTR):
1376 Use VAL_MAX, not VALBITS, in #if.
1377 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1378 (EMACS_UINT): Define unconditionally now.
1379 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1380 (BITS_PER_EMACS_INT): New constants, replacing
1381 what used to be in config.h, but not useful in #if.
1382 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1383 define them any more.
1384 (VAL_MAX): New macro.
1385 (VALMASK): Use it.
1386 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1387 BITS_PER_EMACS_INT, in #if.
1388 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1389 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1390 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1391 * s/ms-w32.h (DATA_START):
1392 Move here from removed file m/intel386.h.
1393 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1394 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1395
261cb4bb
PE
13962012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1397
1398 Assume C89 or later.
1399 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1400 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1401 (xrealloc):
1402 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1403 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1404 * textprop.c, tparam.c (NULL): Remove.
1405 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1406 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1407 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1408 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1409 * xterm.c (input_signal_count): Assume volatile works.
1410
ff23cd9f
KB
14112012-05-21 Ken Brown <kbrown@cornell.edu>
1412
1413 * xgselect.c (xg_select): Fix first argument in call to 'select'
1414 (bug#11508).
1415
1b170bc6
KB
14162012-05-20 Ken Brown <kbrown@cornell.edu>
1417
1418 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1419 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1420
b2f4d39f
KB
14212012-05-19 Ken Brown <kbrown@cornell.edu>
1422
1423 * xfns.c (x_in_use): Remove `static' qualifier.
1424 * xterm.h (x_in_use): Declare.
1425 * xgselect.c: Include xterm.h.
1426 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1427 and `display_arg' (bug#9754).
1428
003fdae2
PE
14292012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1430
9232a6d9
PE
1431 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1432
003fdae2
PE
1433 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1434 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1435
784b56e2
EZ
14362012-05-18 Eli Zaretskii <eliz@gnu.org>
1437
1438 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1439
1440 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1441 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1442
1443 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1444 reference to image_cache->refcount.
1445 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1446
a0a79cde
JL
14472012-05-17 Juri Linkov <juri@jurta.org>
1448
1449 * search.c (Fword_search_regexp, Fword_search_backward)
1450 (Fword_search_forward, Fword_search_backward_lax)
1451 (Fword_search_forward_lax): Move functions to isearch.el
1452 (bug#10145, bug#11381).
1453
b0572523
PE
14542012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1455
1456 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1457
9660f5fc
SM
14582012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1459
1460 * lread.c (init_obarray): Declare Qt and Qnil as special.
1461
4374de83
GM
14622012-05-14 Glenn Morris <rgm@gnu.org>
1463
1464 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1465 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1466
dc44c39a
PE
14672012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1468
078c97cb
PE
1469 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1470
dc44c39a
PE
1471 * unexaix.c: Port to more-recent AIX compilers.
1472 (report_error, report_error_1, make_hdr, copy_sym)
1473 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1474 Make arguments const char *, not char *, to avoid violations of C
1475 standard and to fix some AIX warnings reported by Gilles Pion.
1476
e18afed7 14772012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1478
1479 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1480 already have overlays loaded.
1481 (handle_single_display_spec): Before returning without displaying
1482 fringe bitmap, synchronize the bidi iterator with the main display
1483 iterator, by calling iterate_out_of_display_property.
1484 (iterate_out_of_display_property): Detect buffer iteration by
1485 testing that it->string is a Lisp string.
1486 (get_next_display_element): When the current object is exhausted,
1487 and there's something on it->stack, call set_iterator_to_next to
1488 proceed with what's on the stack, instead of returning zero.
1489 (set_iterator_to_next): If called at the end of a Lisp string,
1490 proceed to consider_string_end without incrementing string
1491 position. Don't increment display vector index past the end of
1492 the display vector. (Bug#11417)
c8fb9dc6
EZ
1493 (pos_visible_p): Don't report a position visible when move_it_to
1494 stopped at the last line of window, which happens to be scanned
1495 backwards by the bidi iteration. (Bug#11464)
ac268e67 1496
e18afed7 14972012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1498
1499 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1500 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1501 are on a TTY, and thus unable to display on the fringes.
1502 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1503 so we need to signal to the caller that this is a "replacing"
1504 display spec. This fixes display when the spec is invalid or we
1505 are on a TTY.
1506
e18afed7 15072012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1508
1509 * unexaix.c (make_hdr): Fix typo in prototype.
1510 This bug broke the build on AIX. Problem reported by Gilles Pion.
1511
9d0a235a
MA
15122012-05-14 Michael Albinus <michael.albinus@gmx.de>
1513
1514 * keyboard.c (kbd_buffer_get_event): Read special events also in
1515 batch mode. (Bug#11415)
1516
9e6b06ed
GM
15172012-05-12 Glenn Morris <rgm@gnu.org>
1518
1519 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1520
c1a1d7a3
EZ
15212012-05-12 Eli Zaretskii <eliz@gnu.org>
1522
1523 * lisp.mk (lisp): Add newcomment.elc.
1524
3fe7cdc8
GM
15252012-05-12 Glenn Morris <rgm@gnu.org>
1526
1527 * Makefile.in (MKDIR_P): New, set by configure.
1528 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1529
53f7d2c0
PE
15302012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1531
1532 Remove unused function hourglass_started.
1533 * dispextern.h (hourglass_started):
1534 * w32fns.c (hourglass_started):
1535 * xdisp.c (hourglass_started): Remove.
1536
75aafb17
JB
15372012-05-10 Juanma Barranquero <lekktu@gmail.com>
1538
1539 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1540 Update dependencies.
1541
12959e8e
PE
15422012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1543
97107e2e
PE
1544 * xgselect.c (xg_select): Put maxfds+1 into a var.
1545 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1546
12959e8e
PE
1547 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1548
836d29b3
DA
15492012-05-10 Dave Abrahams <dave@boostpro.com>
1550
1551 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1552 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1553
5cb67954
MA
15542012-05-09 Michael Albinus <michael.albinus@gmx.de>
1555
1556 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1557 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1558 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1559 Initialize xd_registered_buses.
1560
3478ec45
PE
15612012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1562
b263a6b0
PE
1563 Untag more efficiently if USE_LSB_TAG.
1564 This is based on a proposal by YAMAMOTO Mitsuharu in
1565 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1566 For an admittedly artificial (nth 8000 longlist) benchmark on
1567 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1568 Emacs's overall text size by 1%.
1569 * lisp.h (XUNTAG): New macro.
1570 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1571 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1572 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1573 * eval.c (Fautoload):
1574 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1575 * frame.h (XFRAME): Use XUNTAG.
1576
3478ec45
PE
1577 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1578 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1579 Remove unportable assumptions about print widths of types like
1580 dbus_uint32_t.
1581 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1582 intptr_t when converting between pointer and integer, to avoid GCC
1583 warnings about wrong width.
1584
666b903b 15852012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1586
1587 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1588 stack for each reader_thread, instead of defaulting to 8MB
1589 determined by the linker. This avoids failures in creating
1590 subprocesses on Windows 7, see the discussion in this thread:
1591 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1592
b120cc17
JC
15932012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1594
1595 Fix up display of the *Minibuf-0* buffer in the mini window.
1596 * keyboard.c (read_char): Don't clear the echo area if there's no
1597 message to clear.
1598 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1599 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1600
9a4b36f8
MA
16012012-05-07 Michael Albinus <michael.albinus@gmx.de>
1602
1603 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1604 batch mode.
1605
e5f9458f
CY
16062012-05-06 Chong Yidong <cyd@gnu.org>
1607
1608 * lisp.mk (lisp): Update.
1609
eceeb5fc 16102012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1611
1612 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1613
71873e2b
SM
16142012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1615
1616 * data.c (PUT_ERROR): New macro.
1617 (syms_of_data): Use it. Add new error type `user-error'.
1618 * undo.c (user_error): New function.
1619 (Fprimitive_undo): Use it.
1620 * print.c (print_error_message): Adjust print style for `user-error'.
1621 * keyboard.c (user_error): New function.
1622 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1623
ab0fa4e4
PE
16242012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1625
1626 Do not limit current-time-string to years 1000..9999.
1627 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1628 (Fcurrent_time_string): Support any year that is supported by the
1629 underlying localtime representation. Don't use asctime, as it
1630 has undefined behavior for years outside the range -999..9999.
1631
7ed806a7
PE
16322012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1633
1634 Fix race conditions involving setenv, gmtime, localtime, asctime.
1635 Without this fix, interrupts could mess up code that uses these
1636 nonreentrant functions, since setting TZ invalidates existing
1637 tm_zone or tzname values, and since most of these functions return
1638 pointers to static storage.
1639 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1640 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1641 Grow the critical sections to include not just invoking
1642 localtime/gmtime, but also accessing these functions' results
1643 including their tm_zone values if any, and any related TZ setting.
1644 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1645 so that the struct tm is saved in the critical section.
1646 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1647 motivated by the fact that memory allocation needs to be outside
1648 the critical section.
1649
0c16dfed
DA
16502012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1651
1652 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1653 with RESET_INTERVAL.
1654
1655 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1656 Remove duplicated buffer name initialization.
1657
3f83ace8
JM
16582012-05-02 Jim Meyering <jim@meyering.net>
1659
1660 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1661
c7b8541e
JM
1662 * xfns.c (x_window): Use xstrdup (Bug#11375).
1663
90207a15 16642012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1665
1666 * xdisp.c (pos_visible_p): If already at a newline from the
1667 display string before the 'while' loop, don't walk back the glyphs
1668 from it3.glyph_row. Solves assertion violation when the display
1669 string begins with a newline (egg.el). (Bug#11367)
1670
b593d6a9
AH
16712012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1672
1673 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1674 Move to simple.el.
1675
4737362e
GM
16762012-05-01 Glenn Morris <rgm@gnu.org>
1677
99cf43f9
GM
1678 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1679 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1680 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1681 All were removed before 23.1.
1682
9311dcff
GM
1683 * dispnew.c: Remove HAVE_LIBNCURSES test;
1684 it is always true on relevant platforms.
1685
4d5c6349
GM
1686 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1687 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1688
4737362e
GM
1689 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1690
74dd3a6b
AS
16912012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1692
1693 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1694 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1695 Remove.
1696
13c379ee
PE
16972012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1698
1699 Do not avoid creating empty evaporating overlays (Bug#9642).
1700 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1701 That is, do not delete an evaporating overlay if it becomes
1702 empty after its bounds are adjusted to fit within its buffer.
1703 This fix caused other problems, and I'm reverting it until we get
1704 to the bottom of them.
1705
a8e7d6d7 17062012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1707
1708 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1709
a8e7d6d7 17102012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1711
1712 * xdisp.c (pos_visible_p): If the window start position is beyond
1713 ZV, start the display from buffer beginning. Prevents assertion
1714 violation in init_iterator when the minibuffer window is scrolled
1715 via the scroll bar.
1716
1717 * window.c (window_scroll_pixel_based): Likewise.
1718
a8e7d6d7 17192012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1720
1721 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1722
a8e7d6d7 17232012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1724
1725 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1726 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1727
a8e7d6d7 17282012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1729
b593d6a9
AH
1730 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1731 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1732
1c6900d9
EZ
17332012-04-26 Eli Zaretskii <eliz@gnu.org>
1734
4c3fa1d9
EZ
1735 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1736 display element, check also the underlying string or buffer
1737 character. (Bug#11341)
1738
1c6900d9
EZ
1739 * w32menu.c: Include w32heap.h.
1740 (add_menu_item): If the call to AppendMenuW (via
1741 unicode_append_menu) fails, disable Unicode menus only if we are
1742 running on Windows 9X/Me.
1743
42bf8205
AS
17442012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1745
1746 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1747 (xgetint): Add missing shift for LSB tags.
1748
b1bac16e
MR
17492012-04-24 Martin Rudalics <rudalics@gmx.at>
1750
1751 * keyboard.c (read_char): Don't wipe echo area for select window
1752 events: These might get delayed via `mouse-autoselect-window'
1753 (Bug#11304).
1754
d69621cc
JB
17552012-04-24 Juanma Barranquero <lekktu@gmail.com>
1756
1757 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1758 manipulation of :loaded-from data.
1759
02fd101b
JB
17602012-04-23 Juanma Barranquero <lekktu@gmail.com>
1761
1762 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1763 now a cons (bug#11311).
1764
888bec30
PE
17652012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1766
89a438bd
PE
1767 Do not create empty overlays with the evaporate property (Bug#9642).
1768 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1769 if it becomes empty after its bounds are adjusted to fit within
1770 its buffer. Without this fix, in a nonempty buffer (let ((o
1771 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1772 yields an empty overlay that has the evaporate property, which is
1773 not supposed to happen.
1774
1068fe4d
PE
1775 Fix minor GTK3 problems found by static checking.
1776 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1777 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1778 (struct _EmacsFixedClass, emacs_fixed_get_type):
1779 Move decls here from emacsgtkfixed.h, since they needn't be public.
1780 (emacs_fixed_get_type): Now static.
1781 (emacs_fixed_class_init): Omit unused local.
1782 (emacs_fixed_child_type): Remove; unused.
1783 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1784 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1785 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1786 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1787 (EMACS_FIXED_GET_CLASS): Remove; unused.
1788 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1789
888bec30
PE
1790 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1791 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1792
de85e130
PE
17932012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1794
d0baac98 1795 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1796 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1797 (__malloc_size_t, __malloc_ptrdiff_t):
1798 Remove. All uses removed, replaced by the definiens if needed,
1799 since we can assume C89 or better now.
1800 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1801 (protect_malloc_state, align, get_contiguous_space)
1802 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1803 (malloc_atfork_handler_child, malloc_enable_thread)
1804 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1805 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1806 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1807 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1808 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1809 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1810 Define using prototypes, not old style.
1811 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1812 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1813 (align): Don't assume that signed integer overflow wraps around.
1814 Omit unused local var.
1815 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1816 (_free_internal_nolock, memalign, mallochook, reallochook):
1817 Omit no-longer-needed casts.
1818 (valloc): Use getpagesize, not __getpagesize.
1819 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1820 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1821
de85e130
PE
1822 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1823
dcbf5805
MA
18242012-04-22 Michael Albinus <michael.albinus@gmx.de>
1825
1826 Move functions from C to Lisp. Make non-blocking method calls
1827 the default. Implement further D-Bus standard interfaces.
1828
1829 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1830 (QCdbus_request_name_allow_replacement)
1831 (QCdbus_request_name_replace_existing)
1832 (QCdbus_request_name_do_not_queue)
1833 (QCdbus_request_name_reply_primary_owner)
1834 (QCdbus_request_name_reply_in_queue)
1835 (QCdbus_request_name_reply_exists)
1836 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1837 (QCdbus_registered_serial, QCdbus_registered_method)
1838 (QCdbus_registered_signal): New Lisp objects.
1839 (XD_DEBUG_MESSAGE): Use sizeof.
1840 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1841 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1842 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1843 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1844 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1845 (xd_signature, xd_append_arg): Allow float for integer types.
1846 (xd_get_connection_references): New function.
b593d6a9
AH
1847 (xd_get_connection_address): Rename from xd_initialize.
1848 Return cached address.
dcbf5805
MA
1849 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1850 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1851 level.
1852 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1853 Return number of refcounts.
dcbf5805
MA
1854 (Fdbus_get_unique_name): Make stronger parameter check.
1855 (Fdbus_message_internal): New defun.
1856 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1857 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1858 (Fdbus_send_signal, Fdbus_register_service)
1859 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1860 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1861 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1862 (Vdbus_compiled_version, Vdbus_runtime_version)
1863 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1864 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1865 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1866 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1867 Adapt docstring.
dcbf5805 1868
52828e02
PE
18692012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1870
da05bc4c
PE
1871 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1872 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1873 Do not assume ptrdiff_t is the same width as 'int'.
1874
52828e02
PE
1875 * alloc.c: Handle unusual debugging option combinations.
1876 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1877 since the two debugging options are incompatible.
1878 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1879 is defined.
1880 (mem_init, mem_insert, mem_insert_fixup):
1881 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1882 (NEED_MEM_INSERT): Remove; no longer needed.
1883
f01769f9
LL
18842012-04-22 Leo Liu <sdl.web@gmail.com>
1885
1886 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1887
5790543d
PE
18882012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 * sysdep.c [__FreeBSD__]: Minor cleanups.
1891 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1892 Use Emacs indenting style more consistently. Avoid some casts.
1893 Use 'double' consistently rather than mixing 'float' and 'double'.
1894
b91b7e4d
EW
18952012-04-21 Eduard Wiebe <usenet@pusto.de>
1896
b593d6a9
AH
1897 * sysdep.c (list_system_processes, system_process_attributes):
1898 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1899
6114eb15
AS
19002012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1901
1902 * lisp.mk (lisp): Update.
1903
2f38dff7
PE
19042012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1905
1906 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1907 It is never used otherwise.
1908
4ae29f89
SM
19092012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1910
1911 * print.c (print_preprocess): Only check print_depth if print-circle
1912 is nil.
1913 (print_object): Check for cycles even when print-circle is nil and
1914 print-gensym is t, but only check print_depth if print-circle is nil.
1915
f30d612a
CY
19162012-04-20 Chong Yidong <cyd@gnu.org>
1917
1918 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1919 set the status to "failed" and ensure that sentinel is run.
1920
c07a4c0b 19212012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1922
1923 * process.c (Fset_process_inherit_coding_system_flag)
1924 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1925 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1926
c07a4c0b 19272012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1928
1929 * xdisp.c (string_buffer_position_lim): Limit starting position to
1930 BEGV.
1931 (set_cursor_from_row): If called for a mode-line or header-line
1932 row, return zero immediately.
1933 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1934 farther than the first row after the header line, if any.
1935 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1936 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1937
c07a4c0b 19382012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1939
4ae29f89
SM
1940 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1941 (bug#11238).
ad3a2b41 1942
c07a4c0b 19432012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 19442012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1945
1946 configure: new option --enable-gcc-warnings (Bug#11207)
1947 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1948 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1949 (ALL_CFLAGS): Use new macros rather than old.
1950 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1951 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1952 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1953 -Wunused-result, -Wunused-variable. This should go away once
1954 the Emacs and Gnulib regex code is merged.
1955 (xmalloc, xrealloc): Now static.
1956
aba027e8
PE
19572012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1958
1959 * dired.c (Fsystem_groups): Remove unused local.
1960
e5a36063
GM
19612012-04-17 Glenn Morris <rgm@gnu.org>
1962
1963 * dired.c (Fsystem_users): Doc fix.
1964
316411f0
DA
19652012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1966
1967 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1968 (syms_of_dired): Add them.
1969
9426aba4
PE
19702012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1971
b62a57be
PE
1972 Fix minor alloc.c problems found by static checking.
1973 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1974 New extern decls, to avoid calling undeclared functions.
1975 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1976 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1977 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1978 (NEED_MEM_INSERT): New macro.
1979 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1980 Remove one incorrect comment and fix another.
b62a57be 1981
3539f31f
PE
1982 Fix minor ralloc.c problems found by static checking.
1983 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1984 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1985 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1986 (r_alloc_sbrk): Now static.
1987
a041960a
PE
1988 Improve ralloc.c interface checking.
1989 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1990 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1991 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1992 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1993 [REL_ALLOC]: ... to here, to check interface.
1994 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1995 Remove decls. This fixes an "It stinks!".
1996
9426aba4
PE
1997 * alloc.c (which_symbols): Fix alignment issue / type clash.
1998
d55c12ed
AS
19992012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2000
2001 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2002 (struct Lisp_Misc_Any): Likewise.
2003 (struct Lisp_Free): Likewise.
2004 * alloc.c (union aligned_Lisp_Symbol): Define.
2005 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2006 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2007 (union aligned_Lisp_Misc): Define.
2008 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2009 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2010 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2011
b948ce8b
PE
20122012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2013
2014 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2015 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2016 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2017 * s/netbsd.h, s/sol2-6.h:
2018 Remove definition of GC_MARK_STACK, since the default now works.
2019 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2020 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2021 no longer the default.
2022 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2023
35dc09a1 20242012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2025
35dc09a1
GM
2026 * lread.c (lisp_file_lexically_bound_p):
2027 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2028
35dc09a1
GM
20292012-04-14 Eli Zaretskii <eliz@gnu.org>
2030
2031 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2032 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2033
20342012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2035
2036 * nsterm.m (constrainFrameRect): Always constrain when there is only
2037 one screen (Bug#10962).
2038
bcd86815
KB
20392012-04-13 Ken Brown <kbrown@cornell.edu>
2040
2041 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2042
c25df26e
RT
20432012-04-13 Reuben Thomas <rrt@sc3d.org>
2044
2045 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2046
0fc59f1e
DC
20472012-04-11 Daniel Colascione <dancol@dancol.org>
2048
2049 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2050 against is gone. It's better to use vfork now so that when Cygwin
2051 gains a new, working vfork, we use it automatically (bug#10398).
2052
de8c03dc
SM
20532012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2054
2055 * window.c (save_window_save): Obey window-point-insertion-type.
2056
2f097256
GM
20572012-04-11 Glenn Morris <rgm@gnu.org>
2058
2059 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2060
453b951e
SM
20612012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2062
2063 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2064
75f1671a 20652012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2066
2067 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2068 (force_quit_count): New var.
2069 (handle_interrupt): Use it.
2070
2a8ce227
JB
20712012-04-10 Juanma Barranquero <lekktu@gmail.com>
2072
2073 * w32.c (w32_delayed_load): Record the full path of the library
2074 being loaded (bug#10424).
2075
935396c0
GM
20762012-04-09 Glenn Morris <rgm@gnu.org>
2077
05920a43
GM
2078 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2079 not just in the obarray, before snarfing them. (Bug#11036)
2080
935396c0
GM
2081 * Makefile.in ($(leimdir)/leim-list.el):
2082 Pass EMACS rather than BUILT_EMACS.
2083
a18ecafa
TZ
20842012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2085
2086 * process.c (make_process):
2087 * process.h: Add integer `gnutls_handshakes_tried' member to
2088 process struct.
2089
6bbef4e5
JC
2090 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2091 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2092
2093 * gnutls.c (gnutls_log_function2i): Convenience log function.
2094 (emacs_gnutls_read): Use new log functions,
2095 `gnutls_handshakes_tried' process member, and
2096 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2097 attempts per process (connection).
2098
b4d3bc10
CY
20992012-04-09 Chong Yidong <cyd@gnu.org>
2100
2101 * eval.c (Fuser_variable_p, user_variable_p_eh)
2102 (lisp_indirect_variable): Functions deleted.
2103 (Fdefvar): Caller changed.
2104
2105 * callint.c (Finteractive, Fcall_interactively):
2106 * minibuf.c (Fread_variable): Callers changed.
2107
70f4d973
EZ
21082012-04-09 Eli Zaretskii <eliz@gnu.org>
2109
2110 * xdisp.c (set_cursor_from_row): If the display string appears in
2111 the buffer at position that is closer to point than the position
2112 after the display string, display the cursor on the first glyph of
2113 the display string. Fixes cursor display when a 'display' text
2114 property immediately follows invisible text. (Bug#11094)
2115
cb3c2e3e
PE
21162012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2117
2118 composite.c: use 'double' consistently
2119 * composite.c (get_composition_id): Use 'double' consistently
2120 instead of converting 'float' to 'double' and vice versa; this is
2121 easier to understand and avoids a GCC warning.
2122
fd06db5d
GM
21232012-04-09 Glenn Morris <rgm@gnu.org>
2124
50fe702a
GM
2125 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2126 preparation for dumping it with emacs. (Bug#4789)
2127 (leimdir): New variable.
2128 ($(leimdir)/leim-list.el): New rule.
2129 (emacs$(EXEEXT)): Depend on leim-list.el.
2130
fd06db5d
GM
2131 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2132 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2133 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2134
55c131ee
AS
21352012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2136
2137 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2138 proper alignment.
2139
9209588f
JB
21402012-04-07 Juanma Barranquero <lekktu@gmail.com>
2141
2142 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2143 Remove unused local variable.
2144
e3fb2efb
PE
21452012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2146
2147 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2148 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2149 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2150 objects, as mark_maybe_pointer will catch them otherwise.
2151 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2152 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2153
b5385551
PE
21542012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2155
2156 Fix typo that broke non-Windows builds.
2157 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2158
9078ead6
EZ
21592012-04-07 Eli Zaretskii <eliz@gnu.org>
2160
2161 Support building on MS-Windows with libxml2.
2162
2163 * makefile.w32-in (OBJ2): Add xml.$(O).
2164 (GLOBAL_SOURCES): Add xml.c.
2165 ($(BLD)/xml.$(O)): New dependency list.
2166
2167 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2168 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2169 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2170 [!WINDOWSNT]: New macros.
2171 (init_libxml2_functions, libxml2_loaded_p): New functions.
2172 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2173 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2174 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2175 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2176 linked in).
6bbef4e5
JC
2177 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2178 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2179 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2180
2181 * emacs.c: Don't include libxml/parser.h.
2182 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2183 xmlCleanupParser directly.
2184
2185 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2186
3811fdf3
EZ
21872012-04-07 Eli Zaretskii <eliz@gnu.org>
2188
2189 * indent.c (Fvertical_motion): If there is a display string at
2190 point, use it.vpos to compute how many lines to backtrack after
2191 move_it_to point. (Bug#11133)
2192
2f8e16b2
EZ
21932012-04-06 Eli Zaretskii <eliz@gnu.org>
2194
2195 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2196 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2197 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2198 macros related to unification of CJK characters. For the details,
2199 see the discussion following the message here:
2200 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2201
3d439cd1
CY
22022012-04-04 Chong Yidong <cyd@gnu.org>
2203
2204 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2205
8bc53d00
EZ
22062012-04-01 Eli Zaretskii <eliz@gnu.org>
2207
2208 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2209 instead of alloca. (Bug#11138)
2210
3b0512a3
AS
22112012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2212
2213 * w32menu.c (is_simple_dialog): Properly check lisp types.
2214 (Bug#11141)
2215
8427ddd2
EZ
22162012-03-31 Eli Zaretskii <eliz@gnu.org>
2217
979022ef
EZ
2218 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2219 position we get to after a call to move_it_to fails the
2220 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2221 only if we wind up in a string from display property. (Bug#11063)
2222
a6b1c7cc
EZ
2223 * window.c (Fdelete_other_windows_internal): Invalidate the row
2224 and column information about mouse highlight, so that redisplay
2225 restores it after reallocating the glyph matrices. (Bug#7464)
2226
8427ddd2
EZ
2227 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2228 string comes from a `display' text property, use the buffer
2229 position of that property as if we actually saw that position in
2230 the row's glyphs.
697ba24b
EZ
2231 (move_it_by_lines): Remove the assertion that
2232 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2233 violated when there's a before-string at the beginning of a line.
2234 (Bug#11063)
8427ddd2 2235
65a0a738
EZ
22362012-03-30 Eli Zaretskii <eliz@gnu.org>
2237
2238 * xdisp.c (append_space_for_newline): If the default face was
2239 remapped, use the remapped face for the appended newline.
2240 (extend_face_to_end_of_line): Use the remapped default face for
2241 extending the face to the end of the line.
2242 (display_line): Call extend_face_to_end_of_line when the default
2243 face was remapped. (Bug#11068)
2244
581355cc
EZ
22452012-03-29 Eli Zaretskii <eliz@gnu.org>
2246
2247 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2248
e8fc049f
SM
22492012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2250
2251 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2252
4fb9a543
GM
22532012-03-27 Glenn Morris <rgm@gnu.org>
2254
2255 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2256 Doc fixes.
2257
679910f1
KH
22582012-03-26 Kenichi Handa <handa@m17n.org>
2259
2260 * dispextern.h (struct glyph): Fix previous change. Change the
2261 bit length of glyphless.ch to 25 (Bug#11082).
2262
90d49b7f
CY
22632012-03-26 Chong Yidong <cyd@gnu.org>
2264
2265 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2266 (command_loop_1): Use it; inhibit selection update for
2267 handle-select-window too (Bug#8996).
2268
f514f6f0
FP
22692012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2270
e8fc049f 2271 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2272
bf43fa51
KH
22732012-03-25 Kenichi Handa <handa@m17n.org>
2274
2275 * dispextern.h (struct glyph): Change the bit length of
2276 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2277
8a0c01dd
EZ
22782012-03-24 Eli Zaretskii <eliz@gnu.org>
2279
2280 * s/ms-w32.h (tzname): Include time.h before redirecting to
2281 _tzname. Fixes the MSVC build. (Bug#9960)
2282
7d1c3a76
AS
22832012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2284
8ed79523
AS
2285 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2286 characters.
2287
7d1c3a76
AS
2288 * xterm.c (XTread_socket): Only modify handling_signal if
2289 !SYNC_INPUT. (Bug#11080)
2290
e99a9b8b
EZ
22912012-03-23 Eli Zaretskii <eliz@gnu.org>
2292
2293 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2294 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2295 when fetching a multibyte character consumes more bytes than
2296 CHAR_BYTES returns, due to unification of CJK characters in
2297 string_char. (Bug#11073)
2298
5063c0e1
TN
22992012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2300
2301 * process.c (wait_reading_process_output): Handle pty disconnect
2302 by refraining from sending oneself a SIGCHLD (bug#10933).
2303
9f851fbd
CY
23042012-03-22 Chong Yidong <cyd@gnu.org>
2305
2306 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2307
5063c0e1 2308 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2309 Mark string as coming from a prefix property.
2310 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2311 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2312
fb5b8aca
CY
23132012-03-21 Chong Yidong <cyd@gnu.org>
2314
2315 * xfaces.c (Vface_remapping_alist): Doc fix.
2316
62356a1b
EZ
23172012-03-20 Eli Zaretskii <eliz@gnu.org>
2318
2319 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2320 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2321 Doc fixes.
62356a1b 2322
025de85b
CY
23232012-03-20 Chong Yidong <cyd@gnu.org>
2324
2325 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2326 to reflect default non-nil value of redisplay-dont-pause.
2327
4827f94e
KH
23282012-03-19 Kenichi Handa <handa@m17n.org>
2329
2330 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2331 it fit in a valid range (Bug#11003).
2332
e50a24a2
EZ
23332012-03-18 Eli Zaretskii <eliz@gnu.org>
2334
2335 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2336 that is not from display property, accept the row as a "cursor
2337 row" if one of the string's character has a non-nil `cursor'
2338 property. Fixes cursor positioning when there are newlines in
2339 overlay strings, e.g. in icomplete.el. (Bug#11035)
2340
9af5ed87
PE
23412012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2342
2343 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2344
d1f55f16
CY
23452012-03-12 Chong Yidong <cyd@gnu.org>
2346
2347 * eval.c (inhibit_lisp_code): Rename from
2348 inhibit_window_configuration_change_hook; move from window.c.
2349
2350 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2351 * window.c (run_window_configuration_change_hook)
2352 (syms_of_window): Callers changed.
2353
66c5eebd
CY
23542012-03-11 Chong Yidong <cyd@gnu.org>
2355
413df973
CY
2356 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2357
66c5eebd
CY
2358 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2359
1de11f56
CY
23602012-03-10 Chong Yidong <cyd@gnu.org>
2361
2362 * frame.c (other_visible_frames): Don't assume the selected frame
2363 is visible (Bug#10955).
2364
cae07000
SM
23652012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2366
2367 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2368
89c94350
JD
23692012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2370
2371 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2372 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2373 zero (Bug#10954).
2374
999dd333
GM
23752012-03-03 Glenn Morris <rgm@gnu.org>
2376
01a6dcc8 2377 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2378
de0100f2
EZ
23792012-03-02 Eli Zaretskii <eliz@gnu.org>
2380
2381 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2382 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2383 (redisplay_window, next_element_from_string): Fix typos in
2384 comments.
3e441275
EZ
2385 (redisplay_window): Pass to move_it_vertically the margin in
2386 pixels, not in screen lines.
de0100f2 2387
96a72ee9
GM
23882012-03-02 Glenn Morris <rgm@gnu.org>
2389
2390 * buffer.c (buffer-list-update-hook): Doc fix.
2391
312508d7
EZ
23922012-02-29 Eli Zaretskii <eliz@gnu.org>
2393
2394 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2395 push_it before setting up the iterator for the first overlay
2396 string, even if we have an empty string loaded.
2397 (next_overlay_string): If there's an empty string on the iterator
2398 stack, pop the stack. (Bug#10903)
2399
27f3c637
PE
24002012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2401
2402 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2403 Suggested by Stefan Monnier in
2404 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2405 * alloc.c (widen_to_Lisp_Object): New static function.
2406 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2407 and widening them to Lisp_Objects. This would work even if
2408 USE_LSB_TAG is defined and wide integers are used, which might
2409 happen in a future version of Emacs.
2410
3c9dfce6
CY
24112012-02-25 Chong Yidong <cyd@gnu.org>
2412
fa74b241
CY
2413 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2414 Doc fix.
2415
3c9dfce6
CY
2416 * xselect.c (Fx_selection_exists_p): Doc fix.
2417 (x_clipboard_manager_save_all): Print an informative message
2418 before saving to clipboard manager.
2419
9486df08
CY
24202012-02-24 Chong Yidong <cyd@gnu.org>
2421
2422 * keyboard.c (process_special_events): Handle all X selection
2423 requests in kbd_buffer, not just the next one (Bug#8869).
2424
f01d3321
CY
24252012-02-23 Chong Yidong <cyd@gnu.org>
2426
2427 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2428 call when setting menu-bar-lines and tool-bar-lines parameters.
2429 (unwind_create_frame_1): New helper function.
2430
2431 * window.c (inhibit_window_configuration_change_hook): New var.
2432 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2433 (syms_of_window): Initialize it.
f01d3321 2434
86b847b6
CY
24352012-02-22 Chong Yidong <cyd@gnu.org>
2436
2437 * xterm.c (x_draw_image_relief): Add missing type check for
2438 Vtool_bar_button_margin (Bug#10743).
2439
a59225b1
CY
24402012-02-21 Chong Yidong <cyd@gnu.org>
2441
2442 * fileio.c (Vfile_name_handler_alist): Doc fix.
2443
2444 * buffer.c (Fget_file_buffer): Protect against invalid file
2445 handler return value.
2446
310f5bd4
PE
24472012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2448
cb3a28cc
PE
2449 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2450 when computing $valmask.
2451
310f5bd4
PE
2452 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2453 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2454 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2455 It's useless in that case, and it can cause problems on hosts
2456 that allocate halves of EMACS_INT values separately.
2457 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2458 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2459 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2460 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2461 it avoids undefined behavior on hosts where shifting right by more
2462 than the word width has undefined behavior.
2463
2375c96a
CY
24642012-02-19 Chong Yidong <cyd@gnu.org>
2465
2466 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2467 (Funhandled_file_name_directory, Ffile_name_as_directory)
2468 (Fdirectory_file_name, Fexpand_file_name)
2469 (Fsubstitute_in_file_name): Protect against invalid file handler
2470 return values (Bug#10845).
2471
3eb49e71
EZ
24722012-02-18 Eli Zaretskii <eliz@gnu.org>
2473
2474 * .gdbinit (pitx): Fix incorrect references to fields of the
2475 iterator stack.
2476
7b926f3f
CY
24772012-02-17 Chong Yidong <cyd@gnu.org>
2478
2479 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2480
11273115
PE
24812012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2482
2483 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2484 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2485
c3a70e2b
CY
24862012-02-15 Chong Yidong <cyd@gnu.org>
2487
2488 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2489 marked as special. Also, starting docstrings with * is obsolete.
2490
0ca43699
AS
24912012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2492
2493 * gnutls.c (emacs_gnutls_write): Fix last change.
2494
2e8f3c56
LI
24952012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2496
2497 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2498 send_process.
2499
af70074f
SM
25002012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2501
2502 * keymap.c (Fsingle_key_description): Handle char ranges.
2503
95986d52
CY
25042012-02-12 Chong Yidong <cyd@gnu.org>
2505
afd83bd1
CY
2506 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2507 as that creates a dangerous corner case.
2508
95986d52
CY
2509 * window.c (Fdelete_window_internal): Invalidate the mouse
2510 highlight (Bug#9904).
2511
bd7da63e
GM
25122012-02-12 Glenn Morris <rgm@gnu.org>
2513
2514 * xselect.c (Fx_own_selection_internal)
2515 (Fx_get_selection_internal, Fx_disown_selection_internal)
2516 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2517 * nsselect.m (Fx_own_selection_internal)
2518 (Fx_disown_selection_internal, Fx_selection_exists_p)
2519 (Fx_selection_owner_p, Fx_get_selection_internal):
2520 Sync docs and argument specs with the xselect.c versions.
2521
77abcbc2
LI
25222012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2523
2524 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2525
90b671e2
EZ
25262012-02-11 Eli Zaretskii <eliz@gnu.org>
2527
1c0ca0b7
EZ
2528 * w32select.c (Fx_selection_exists_p): Sync doc string and
2529 argument list with xselect.c. (Bug#10783)
2530
2531 * w16select.c (Fx_selection_exists_p): Sync doc string and
2532 argument list with xselect.c. (Bug#10783)
90b671e2 2533
49241268
GM
25342012-02-10 Glenn Morris <rgm@gnu.org>
2535
2536 * fns.c (Fsecure_hash): Doc fix.
2537
f998bbe7 25382012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2539
2540 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2541
0992bd9c
CY
25422012-02-07 Chong Yidong <cyd@gnu.org>
2543
2544 * buffer.c (Fbuffer_local_variables)
2545 (buffer_lisp_local_variables): Handle unbound vars correctly;
2546 don't let Qunbound leak into Lisp.
2547
af008560
GM
25482012-02-07 Glenn Morris <rgm@gnu.org>
2549
dd605cc4
GM
2550 * image.c (Fimagemagick_types): Doc fix.
2551
af008560
GM
2552 * image.c (imagemagick-render-type): Change it from a lisp object
2553 to an integer. Move the doc here from the lisp manual.
2554 Treat all values not equal to 0 the same.
2555
1449fa1d
CY
25562012-02-06 Chong Yidong <cyd@gnu.org>
2557
2558 * doc.c (store_function_docstring): Avoid applying docstring of
2559 alias to base function (Bug#2603).
2560
3723ec07
AS
25612012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2562
2563 * .gdbinit (pp1, pv1): Remove redundant defines.
2564 (pr): Use pp.
2565
79c1cc1e
CY
25662012-02-04 Chong Yidong <cyd@gnu.org>
2567
2568 * nsterm.m: Declare a global (Bug#10694).
2569
d7f29f8e
EZ
25702012-02-04 Eli Zaretskii <eliz@gnu.org>
2571
cae07000
SM
2572 * w32.c (get_emacs_configuration_options):
2573 Include --enable-checking, if specified, in the return value.
d7f29f8e 2574
3b95a6f9
MR
25752012-02-04 Martin Rudalics <rudalics@gmx.at>
2576
2577 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2578 after rounding frame sizes. (Bug#9723)
2579
d6fa96a6
EZ
25802012-02-04 Eli Zaretskii <eliz@gnu.org>
2581
2582 * keyboard.c (adjust_point_for_property): Don't position point
2583 before BEGV. (Bug#10696)
2584
df0b2940
PE
25852012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2586
2587 Handle overflow when computing char display width (Bug#9496).
2588 * character.c (char_width): Return EMACS_INT, not int.
2589 (char_width, c_string_width): Check for overflow when
2590 computing the width; this is possible now that individual
2591 characters can have unbounded width. Problem introduced
2592 by merge from Emacs 23 on 2012-01-19.
2593
6bee44d6
MA
25942012-02-02 Michael Albinus <michael.albinus@gmx.de>
2595
2596 * dbusbind.c (Fdbus_register_method): Mention the return value
2597 :ignore in the docstring.
2598
44f92739
GM
25992012-02-02 Glenn Morris <rgm@gnu.org>
2600
1b9f60cc
GM
2601 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2602
44f92739
GM
2603 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2604 Unconditionally set to t. (Bug#10673)
2605 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2606 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2607 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2608
c5d3843c
KH
26092012-02-02 Kenichi Handa <handa@m17n.org>
2610
2611 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2612 0, do not call append_composite_glyph.
2613
159462d4 26142012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2615
2616 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2617 NULL (Bug#6988).
2618 (x_produce_glyphs): If the component of a composition is a null
2619 string, set it->pixel_width to 1 to avoid zero-width glyph.
2620
78cef877
EZ
26212012-02-01 Eli Zaretskii <eliz@gnu.org>
2622
2623 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2624 first 2 arguments are identical. This makes inserting large
2625 output from a subprocess an order of magnitude faster on
2626 MS-Windows, where all sbrk'ed memory is always contiguous.
2627
97897668
GM
26282012-01-31 Glenn Morris <rgm@gnu.org>
2629
2630 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2631 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2632 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2633
31fd3586
GM
26342012-01-29 Glenn Morris <rgm@gnu.org>
2635
2636 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2637
0e24a8b2
CY
26382012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2639
2640 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2641
cc0adcb0
CY
26422012-01-28 Chong Yidong <cyd@gnu.org>
2643
2644 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2645
acc28cb9
CY
26462012-01-26 Chong Yidong <cyd@gnu.org>
2647
9c69cfb7
CY
2648 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2649
acc28cb9
CY
2650 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2651 repeat counts (Bug#10507).
2652
48da7392
GM
26532012-01-26 Glenn Morris <rgm@gnu.org>
2654
2655 * lread.c (syms_of_lread): Doc fix.
2656
14af5f7f
CY
26572012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2658
2659 * coding.c (encode_designation_at_bol): Change return value to
2660 EMACS_INT.
2661
0b21c100
CY
26622012-01-25 Chong Yidong <cyd@gnu.org>
2663
2664 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2665
3c2907f7
CY
26662012-01-21 Chong Yidong <cyd@gnu.org>
2667
2668 * floatfns.c (Fcopysign): Make the second argument non-optional,
2669 since nil is not allowed anyway.
2670
959ad23f
AS
26712012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2672
2673 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2674 (send_process): Likewise.
2675
34a02f46
MR
26762012-01-19 Martin Rudalics <rudalics@gmx.at>
2677
2678 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2679 (Vwindow_persistent_parameters): Do not use Qstate.
2680 Rewrite doc-strings.
34a02f46 2681
1259009a 26822012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2683
2684 * character.c (char_width): New function.
70d4fdf6
GM
2685 (Fchar_width, c_string_width, lisp_string_width):
2686 Use char_width (Bug#9496).
25ed9e61 2687
6a6ee00d
MR
26882012-01-16 Martin Rudalics <rudalics@gmx.at>
2689
2690 * window.c (Vwindow_persistent_parameters): New variable.
2691 (Fset_window_configuration, save_window_save): Handle persistent
2692 window parameters.
2693
c85efaf7
EZ
26942012-01-14 Eli Zaretskii <eliz@gnu.org>
2695
2696 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2697 thrashing the stack of the thread. (Bug#9087)
2698
5944709e
PE
26992012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2700
2701 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2702
e71f5d99
EZ
27032012-01-11 Eli Zaretskii <eliz@gnu.org>
2704
2705 * xdisp.c (rows_from_pos_range): Handle the case where the
2706 highlight ends on a newline. (Bug#10464)
2707 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2708 he end column for display of highlight that ends on a newline
2709 before a R2L line.
2710
ce316182
GM
27112012-01-11 Glenn Morris <rgm@gnu.org>
2712
2713 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2714 from load-path also when installation-directory is nil. (Bug#10208)
2715
5b43da69
GM
27162012-01-10 Glenn Morris <rgm@gnu.org>
2717
74cc8ff9
GM
2718 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2719
7d8d6e4e
GM
2720 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2721 Update template values to be closer to their typical values these days.
5b43da69 2722
a0db8d43
EZ
27232012-01-09 Eli Zaretskii <eliz@gnu.org>
2724
2725 * xdisp.c (rows_from_pos_range): Accept additional argument
2726 DISP_STRING, and accept any glyph in a row whose object is that
2727 string as eligible for mouse highlight. Fixes mouse highlight of
2728 display strings from overlays. (Bug#10464)
2729
9a0115ab 27302012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2731
b9110d6a 2732 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2733 * fileio.c (auto_saving_dir_umask): New static var.
2734 (Fmake_directory_internal): Use it.
2735 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2736 creating the directory. The old code temporarily assigns
2737 too-generous permissions to the directory.
2738 (do_auto_save_eh): Clear it.
b9110d6a 2739 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2740 that the var is always cleared.
2741
6c1bd3f3
EZ
27422012-01-07 Eli Zaretskii <eliz@gnu.org>
2743
2744 * search.c (scan_buffer): Pass character positions to
2745 know_region_cache, not byte positions. (Bug#6540)
2746
069d2b50
L
27472012-01-07 LynX <_LynX@bk.ru> (tiny change)
2748
2749 * w32.c (sys_rename): Report EXDEV when rename of a directory
2750 fails because the target is on another logical disk. (Bug#10284)
2751
75bf0d33
DB
27522012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2753
2754 * xterm.c (x_embed_request_focus): New function.
2755
2756 * xterm.h: Add prototype.
2757
2758 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2759
1c6e5a32
GM
27602012-01-05 Glenn Morris <rgm@gnu.org>
2761
2762 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2763
651e947e
EZ
27642012-01-01 Eli Zaretskii <eliz@gnu.org>
2765
2766 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2767 Load gnutls_transport_set_lowat only if GnuTLS version is below
2768 2.11.1.
2769 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2770 GnuTLS versions below 2.11.1.
2771
3778cdd8
AL
27722011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2773
2774 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2775 to the doc string advising against its use for altering the way
2776 windows are scrolled.
2777
0e5317f7
KH
27782011-12-28 Kenichi Handa <handa@m17n.org>
2779
2780 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2781 coding-system ASCII compatible only when it does not produce BOM
2782 on encoding (Bug#10383).
2783
93d5ca1f
JD
27842011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2785
2786 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2787 can scroll.
2788 (create_and_show_popup_menu): Always use menu_position_func for
2789 Gtk3 (Bug#10361).
2790
ca22b785
AS
27912011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2792
2793 * callint.c (Fcall_interactively): Don't truncate prompt string.
2794
d048e1e6
EZ
27952011-12-23 Eli Zaretskii <eliz@gnu.org>
2796
2797 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2798 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2799 resumed from there (after widening). (Bug#10360)
d048e1e6 2800
5ccaba1f
JD
28012011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2802
2803 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2804
204ee57f
JD
28052011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2806
b81d40f0
JB
2807 * nsterm.m (x_free_frame_resources):
2808 Release f->output_data.ns->miniimage.
204ee57f
JD
2809 (ns_index_color): Fix indentation. Do not retain
2810 color_table->colors[i].
2811
2812 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2813 before returning.
2814
2815 * nsfns.m (x_set_background_color): Assign return value from
2816 ns_index_color to face-background instead of NSColor*.
2817 (ns_implicitly_set_icon_type): Fix indentation.
2818 Change assignment in for loop to comparison.
2819
2820 * emacs.c (ns_pool): New variable.
2821 (main): Assign ns_pool.
2822 (Fkill_emacs): Call ns_release_autorelease_pool.
2823
2824 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2825 autorelease fdesc, release fdAttrs and tdict.
2826 (ns_get_covering_families): Release charset.
2827 (ns_findfonts): Release NSFontDescriptor created with new.
2828 (ns_uni_to_glyphs): Fix indentation.
2829 (setString): Release attrStr before assigning new value.
2830
c803b2b7
JD
28312011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2832
678f4426
JD
2833 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2834 and NS_IMPL_COCOA.
2835 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2836 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2837
cd394be1 28382011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2839
5fecd5fc
JD
2840 * nsterm.m (ns_term_init): Subscribe for notifications
2841 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2842 to method trackingNotification in EmacsMenu.
2843
2844 * nsmenu.m (trackingMenu): New variable.
3771cb17 2845 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2846 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2847 from Aquamacs (Bug#7030).
678f4426
JD
2848
28492011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2850
c803b2b7
JD
2851 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2852 (symbol_to_nsstring): Fix indentation.
2853 (ns_symbol_to_pb): New function.
cae07000
SM
2854 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2855 (Fns_rotate_cut_buffers_internal): Remove.
2856 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2857 Fns_store_cut_buffer_internal.
2858 (ns_get_foreign_selection, Fx_own_selection_internal)
2859 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2860 (Fns_get_selection_internal, Fns_store_selection_internal):
2861 Use ns_symbol_to_pb and check if return value is nil.
2862 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2863 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2864 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2865 renamed to Sns_store_selection_internal.
2866 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2867 and remove this function.
2868 (ns_handle_selection_clear): Remove, never used.
2869 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2870 here.
2871
e1b01a3a
KB
28722011-12-17 Ken Brown <kbrown@cornell.edu>
2873
2874 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2875 GID is unknown (Bug#10257).
2876
2adb6e85
PE
28772011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2878
2879 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2880 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2881 which caused a build failure on GNU/Linux IA-64. This problem was
2882 introduced by my 2011-10-07 patch.
2883
d1d7b339
JL
28842011-12-15 Juri Linkov <juri@jurta.org>
2885
2886 * image.c (imagemagick_error): New function. (Bug#10112)
2887 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2888 Use `imagemagick_error' where ImageMagick functions return
2889 `MagickFalse'.
2890 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2891 proper order.
2892
100d5755
KH
28932011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2894
2895 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2896 fill background (Bug#8992).
2897
454592a6
MR
28982011-12-13 Martin Rudalics <rudalics@gmx.at>
2899
2900 * window.c (Vwindow_combination_resize)
2901 (Vwindow_combination_limit): Use t instead of non-nil in
2902 doc-strings.
61d4b438
MR
2903 (Vrecenter_redisplay): Add first sentence of doc-string on
2904 separate line.
53524d93 2905 (Frecenter): Fix doc-string typo.
454592a6 2906
3633e3aa
KH
29072011-12-11 Kenichi Handa <handa@m17n.org>
2908
2909 * coding.c (Funencodable_char_position): Pay attention to the
2910 buffer text relocation (Bug#9389).
2911
7b9d523a 29122011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2913
7b9d523a
JD
2914 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2915 gtk_init (Bug#10100).
2916
b73189c6
EZ
29172011-12-10 Eli Zaretskii <eliz@gnu.org>
2918
2919 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2920 IT->string is nil. (Bug#10263)
2921
f7dfe5d6
JD
29222011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2923
83faebb4
JD
2924 * nsterm.h (x_free_frame_resources): Declare.
2925
f7dfe5d6
JD
2926 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2927 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2928
2929 * nsterm.h (ns_get_defaults_value): Declare.
2930
2931 * nsterm.m (ns_default): Call ns_get_defaults_value.
2932
7cd4e72c
EZ
29332011-12-09 Eli Zaretskii <eliz@gnu.org>
2934
2935 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2936 (Bug#10170)
2937
b34d7317
YM
29382011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2939
2940 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2941 that where the value of an _OBJC_* symbol points to is in the .bss
2942 section (Bug#10240).
2943
76470ad1
KH
29442011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2945
2946 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2947 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2948
745fff94
KH
29492011-12-08 Kenichi Handa <handa@m17n.org>
2950
2951 * ftfont.c (get_adstyle_property): Fix previous change
2952 (Bug#10233).
2953
6e44397c
JB
29542011-12-07 Juanma Barranquero <lekktu@gmail.com>
2955
2956 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2957 dirs from the default value of EMACSLOADPATH (bug#10208).
2958
7efa6272
GM
29592011-12-07 Glenn Morris <rgm@gnu.org>
2960
2961 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2962 installation and source directories as well. (Bug#10208)
2963
f6fc4d87
CY
29642011-12-06 Chong Yidong <cyd@gnu.org>
2965
2966 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2967
2bf26180
GM
29682011-12-06 Glenn Morris <rgm@gnu.org>
2969
2970 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2971 as an error, not just -1. (Bug#10217)
2972
3a6ad4f0
CY
29732011-12-05 Chong Yidong <cyd@gnu.org>
2974
2975 * keyboard.c (process_special_events): New function.
2976 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2977
75a3b399
PE
29782011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2979
2980 * coding.c (encode_designation_at_bol): Don't use uninitialized
2981 local variable (Bug#9318).
2982
c3c9e25e
KH
29832011-12-05 Kenichi Handa <handa@m17n.org>
2984
2985 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2986 return Qnil (Bug#8046, Bug#10193).
2987
5eb05ea3
KH
29882011-12-05 Kenichi Handa <handa@m17n.org>
2989
2990 * coding.c (encode_designation_at_bol): New args charbuf_end and
2991 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2992 (coding_set_source): Return how many bytes coding->source was
2993 relocated.
2994 (coding_set_destination): Return how many bytes
2995 coding->destination was relocated.
2996 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2997 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2998
29992011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3000
3001 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3002 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3003 macro (Bug#9318).
3004
30052011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3006
3007 The following changes are to fix Bug#9318.
3008
a79703f5 3009 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3010 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3011 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3012 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3013
7dbda6df
JB
30142011-12-05 Juanma Barranquero <lekktu@gmail.com>
3015
3016 * lisp.h (process_quit_flag): Fix external declaration.
3017
6d5eb5b0
SM
30182011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3019
3020 Don't macro-inline non-performance-critical code.
3021 * eval.c (process_quit_flag): New function.
3022 * lisp.h (QUIT): Use it.
3023
a0c3fad0
JD
30242011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3025
3026 * nsfns.m (get_geometry_from_preferences): New function.
3027 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3028
6c07aac2
AS
30292011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3030
3031 * emacs.c (Qkill_emacs): Define.
3032 (syms_of_emacs): Initialize it.
3033 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3034 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3035 (quit_throw_to_read_char): Add parameter `from_signal'.
3036 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3037 * lisp.h (QUIT): Call Fkill_emacs if requested.
3038
c052ead4
JD
30392011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3040
3041 * widget.c (update_wm_hints): Return if wmshell is null.
3042 (widget_update_wm_size_hints): New function.
3043
3044 * widget.h (widget_update_wm_size_hints): Declare.
3045
3046 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3047 widget_update_wm_size_hints (Bug#10104).
3048
9e49252b
EZ
30492011-12-03 Eli Zaretskii <eliz@gnu.org>
3050
3051 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3052 before a newline, prepare the bidi iterator for consuming the
3053 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3054 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3055
02b16839
JL
30562011-12-02 Juri Linkov <juri@jurta.org>
3057
3058 * search.c (Fword_search_regexp): New Lisp function created from
3059 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3060 (Fword_search_backward, Fword_search_forward)
3061 (Fword_search_backward_lax, Fword_search_forward_lax):
3062 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3063 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3064
0068070e
SM
30652011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3066
3067 * fileio.c (Finsert_file_contents): Move after-change-function call
3068 to before the "handled:" label, since all "goto handled" appear in
3069 cases where the *-change-functions have already been properly called
3070 (bug#10117).
3071
3360a3fc
AS
30722011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3073
3074 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3075 waiting for input. (Bug#10169)
3076
73d6c093
EZ
30772011-11-30 Eli Zaretskii <eliz@gnu.org>
3078
3079 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3080 verifies glyph row's hash code--we have just reallocated the
3081 glyphs, so their contents can be complete garbage. (Bug#10164)
3082
febe6bea
JB
30832011-11-30 Juanma Barranquero <lekktu@gmail.com>
3084
3085 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3086
801a4313
EZ
30872011-11-30 Eli Zaretskii <eliz@gnu.org>
3088
3089 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3090 attributes are tested _before_ calling verify_row_hash, to protect
3091 against GCC re-ordering of the tests. (Bug#10164)
3092
2b56b87e
JD
30932011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3094
3095 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3096
3097 * xterm.c (handle_one_xevent): Only set async_visible and friends
3098 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3099 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3100 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3101
dbf31225
PE
31022011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3103
3104 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3105 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3106 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3107 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3108 All uses changed to use GCPRO1 etc.
3109 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3110 Revert to old implementation (i.e., before 2011-03-11).
3111
1305621b
YM
31122011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3113
3114 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3115 of scroll runs so as to avoid assigning disabled bogus rows and
3116 unnecessary graphics copy operations.
3117
8c9afb46
EZ
31182011-11-27 Eli Zaretskii <eliz@gnu.org>
3119
3120 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3121 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3122 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3123 (malloc, free, realloc, calloc): Redirect to e_* only when
3124 compiling Emacs.
3125
3126 * lisp.h (GCTYPEBITS): Move before first use.
3127 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3128 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3129 this macro definition.
3130
3131 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3132 _MSC_VER.
3133
54e9e3bf
JD
31342011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3135
6d5eb5b0
SM
3136 * gtkutil.c (xg_create_frame_widgets):
3137 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3138 present with Gtk+ 2.0.
3139
83aca1cb
PE
31402011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3141
3142 * fileio.c (Finsert_file_contents): Undo previous change; see
3143 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3144
5b76caa4
PE
31452011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3146
3147 Rename locals to avoid shadowing.
3148 * fileio.c (Finsert_file_contents):
3149 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3150 * process.c (wait_reading_process_output):
3151 Rename inner 'proc' to 'p' to avoid shadowing.
3152 Indent for consistency with usual Emacs style.
3153
8c535114
EZ
31542011-11-25 Eli Zaretskii <eliz@gnu.org>
3155
3156 * xdisp.c (redisplay_window): If cursor row is not fully visible
3157 after recentering, and scroll-conservatively is set to a large
3158 number, scroll window by a few more lines to make the cursor fully
3159 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3160 (start_display): Don't move to the next line if the display should
3161 start at a newline that is part of a display vector or an overlay
3162 string. (Bug#10119)
8c535114 3163
fa4fdb5c
JL
31642011-11-24 Juri Linkov <juri@jurta.org>
3165
3166 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3167 after the `MagickPingImage' call. (Bug#10112)
3168
90ec88df
CY
31692011-11-23 Chong Yidong <cyd@gnu.org>
3170
3171 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3172
56e2e794
MR
31732011-11-23 Martin Rudalics <rudalics@gmx.at>
3174
3175 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3176 making another buffer current. (Bug#10114)
3177
b6e64c41
GM
31782011-11-23 Glenn Morris <rgm@gnu.org>
3179
3180 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3181
6b21de18
CY
31822011-11-23 Chong Yidong <cyd@gnu.org>
3183
3184 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3185 using it (Bug#5984).
3186
b12cd789
EZ
31872011-11-22 Eli Zaretskii <eliz@gnu.org>
3188
3189 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3190 and header-lines, as they don't have one computed for them.
3191 (Bug#10098)
3192
3193 * .gdbinit (prow): Make displayed values more self-explaining.
3194 Add row's hash code.
3195
261b6fd4
LMI
31962011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3197
3198 * process.c (wait_reading_process_output): Fix asynchrounous
3199 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3200 (wait_reading_process_output): Add comment and URL.
261b6fd4 3201
e7cfd277
JD
32022011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3203
3204 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3205
a9b9b7f5
CY
32062011-11-21 Chong Yidong <cyd@gnu.org>
3207
3208 * window.c (Fnext_window, Fprevious_window): Doc fix.
3209
b0d15b4f
SM
32102011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3211
3212 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3213
fe7a3057
JB
32142011-11-20 Juanma Barranquero <lekktu@gmail.com>
3215
3216 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3217
d2999b1a
MR
32182011-11-20 Martin Rudalics <rudalics@gmx.at>
3219
3220 * window.c (Fset_window_combination_limit): Rename argument
3221 STATUS to LIMIT.
3222 (Vwindow_combination_limit): Remove "status" from doc-string.
3223
d5ff9cd0
AS
32242011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3225
3226 * m/ibms390.h: Remove.
3227 * m/ibms390x.h: Don't include "ibms390.h".
3228
a5bb9bd3
SM
32292011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3230
3231 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3232 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3233
cd1181db
JB
32342011-11-20 Juanma Barranquero <lekktu@gmail.com>
3235
3236 * casetab.c (Fset_case_table):
3237 * charset.c (Fcharset_after): Fix typos.
3238
615a3b8d 32392011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3240
17e845af
PE
3241 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3242 Otherwise, valgrind does not work on some platforms.
3243 Problem reported by Andreas Schwab in
6a0bf43d
PE
3244 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3245 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3246 is set, removing the need for VIRT_ADDRESS_VARIES.
3247 (PURE_P): Use a more-efficient implementation that needs just one
3248 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3249 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3250 to 4 (xorl, subq, cmpq, setbe).
3251 * alloc.c (pure): Always extern now, since that's the
3252 VIRT_ADDR_VARIES behavior.
3253 (PURE_POINTER_P): Use a single comparison, not two, for
3254 consistency with the new puresize.h.
3255 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3256 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3257 Remove VIRT_ADDR_VARIES no longer needed.
3258
f8fe6f96
EZ
32592011-11-19 Eli Zaretskii <eliz@gnu.org>
3260
3261 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3262 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3263 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3264 behave as if the cursor position were at the window margin.
3265
3266 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3267 and the cursor position is out of bounds, behave as if the cursor
3268 position were at the window margin. (Bug#10075)
3269
df05a53c
CY
32702011-11-18 Chong Yidong <cyd@gnu.org>
3271
3272 * window.c (Fwindow_combination_limit): Make first argument
3273 non-optional, since it is meaningless for live windows like the
3274 selected window.
61ccba97 3275
2071918e
DA
32762011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3277
3278 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3279
b50a28de
SM
32802011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3281
3282 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3283 (graft_intervals_into_buffer): Simplify.
3284
015137db
EZ
32852011-11-18 Eli Zaretskii <eliz@gnu.org>
3286
3287 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3288 hash values of the two rows.
3289 (copy_row_except_pointers): Preserve the used[] arrays and the
3290 hash values of the two rows. (Bug#10035)
68c95424 3291 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3292
3293 * xdisp.c (row_hash): New function, body extracted from
3294 compute_line_metrics.
3295 (compute_line_metrics): Call row_hash, instead of computing the
3296 hash code inline.
3297
3298 * dispnew.c (verify_row_hash): Call row_hash for computing the
3299 hash code of a row, instead of duplicating code from xdisp.c.
3300
3301 * dispextern.h (row_hash): Add prototype.
3302
a2addb04
TH
33032011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3304
3305 * frame.c (delete_frame): Don't delete the terminal when the last
3306 X frame is closed if emacs is built with GTK toolkit.
3307
df85d315
JB
33082011-11-17 Juanma Barranquero <lekktu@gmail.com>
3309
3310 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3311
a0c2d0ae
MR
33122011-11-17 Martin Rudalics <rudalics@gmx.at>
3313
3314 * window.c (Vwindow_splits): Rename to
3315 Vwindow_combination_resize. Suggested by Juri Linkov.
3316 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3317 of Vwindow_splits.
3318
58179cce
JB
33192011-11-16 Juanma Barranquero <lekktu@gmail.com>
3320
7877f373
JB
3321 * nsfns.m (Fns_font_name):
3322 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3323
b6f67890
MR
33242011-11-16 Martin Rudalics <rudalics@gmx.at>
3325
3326 * window.h (window): Rename slot "nest" to "combination_limit".
3327 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3328 (Fset_window_nest): Rename to Fset_window_combination_limit.
3329 (Vwindow_nest): Rename to Vwindow_combination_limit.
3330 (recombine_windows, make_parent_window, make_window)
3331 (Fsplit_window_internal, saved_window)
3332 (Fset_window_configuration, save_window_save): Rename all
3333 occurrences of window_nest to window_combination_limit.
3334
c7015153
JB
33352011-11-15 Juanma Barranquero <lekktu@gmail.com>
3336
3337 * image.c (imagemagick_load_image): Fix typo.
3338
322ad6ec
EZ
33392011-11-14 Eli Zaretskii <eliz@gnu.org>
3340
3341 * xdisp.c (display_line): Move the call to
3342 highlight_trailing_whitespace before the call to
3343 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3344 faces of all the glyphs to compute ROW's hash value.
3345 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3346
f067b8ec
JB
33472011-11-14 Juanma Barranquero <lekktu@gmail.com>
3348
3349 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3350 just return (bug#10044).
3351
1e5b2111
EZ
33522011-11-12 Eli Zaretskii <eliz@gnu.org>
3353
7ef3cbd5
EZ
3354 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3355 with user-defined heap size. Bump the default size of the temacs
3356 heap to 27MB, to avoid memory warning when running temacs.
3357 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3358
1e5b2111
EZ
3359 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3360 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3361 (verify_row_hash) [XASSERTS]: New function.
3362 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3363 that the hash value of glyph rows is correct.
1e5b2111 3364
89d61221
MR
33652011-11-12 Martin Rudalics <rudalics@gmx.at>
3366
3367 * window.h (window): Remove splits slot.
3368 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3369 (Fdelete_other_windows_internal, make_parent_window)
3370 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3371 (Fset_window_configuration, save_window_save): Don't deal with
3372 split status of windows.
3373 (saved_window): Remove splits slot.
3374 (Vwindow_splits): Rewrite doc-string.
3375
97f18cc8
JD
33762011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3377
3378 * xfns.c (unwind_create_frame):
3379 * nsfns.m (unwind_create_frame):
3380 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3381 Vframe_list (Bug#9999).
3382
22a648b4
DA
33832011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3384
0b381c7e 3385 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3386
659afede
KH
33872011-11-11 Kenichi Handa <handa@m17n.org>
3388
3389 * callproc.c (Fcall_process): Set the member dst_multibyte of
3390 process_coding.
3391
9ac0394b
KH
33922011-11-11 Johan Bockgård <bojohan@gnu.org>
3393
3394 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3395 avoid a crash (bug#9496).
3396
2fbdc249
CY
33972011-11-09 Chong Yidong <cyd@gnu.org>
3398
3399 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3400 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3401
ac6b1f81
PE
34022011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3403
3404 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3405
09db192c
PE
34062011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3407
3408 Avoid some portability problems by eschewing 'extern inline' functions.
3409 The trivial performance wins aren't worth the portability hassles; see
3410 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3411 et seq.
3412 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3413 (window_box_width, window_box_left, window_box_left_offset)
3414 (window_box_right, window_box_right_offset): Undo previous change,
3415 by removing the "extern"s.
3416 * intervals.c (adjust_intervals_for_insertion)
3417 (adjust_intervals_for_deletion): Undo previous change,
3418 making these static again.
3419 (offset_intervals, temp_set_point_both, temp_set_point)
3420 (copy_intervals_to_string): No longer inline.
3421 * xdisp.c (window_text_bottom_y, window_box_width)
3422 (window_box_height, window_box_left_offset)
3423 (window_box_right_offset, window_box_left, window_box_right)
3424 (window_box): No longer inline.
3425
105216ed
CY
34262011-11-08 Chong Yidong <cyd@gnu.org>
3427
3428 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3429 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3430 Signal an error if not a live window.
105216ed
CY
3431 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3432 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3433
ae9e237f
JB
34342011-11-07 Juanma Barranquero <lekktu@gmail.com>
3435
3436 * lisp.h (syms_of_abbrev): Remove declaration.
3437 Reported by CHENG Gao <chenggao@royau.me>.
3438
c7aa8333
EZ
34392011-11-07 Eli Zaretskii <eliz@gnu.org>
3440
3441 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3442 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3443 of temacs in GUI mode.
3444
be7f5545
MR
34452011-11-07 Martin Rudalics <rudalics@gmx.at>
3446
3447 * window.h: Declare delete_all_child_windows instead of
3448 delete_all_subwindows.
3449 * window.c (Fwindow_nest, Fset_window_nest)
3450 (Fset_window_new_total, Fset_window_new_normal)
3451 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3452 (delete_all_subwindows): Rename to delete_all_child_windows.
3453 (Fdelete_other_windows_internal, Fset_window_configuration):
3454 Call delete_all_child_windows instead of delete_all_subwindows.
3455 * frame.c (delete_frame): Call delete_all_child_windows instead
3456 of delete_all_subwindows.
3457
ca78dc43
PE
34582011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3459
3460 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3461 This is also needed for porting to any host where GC_MARK_STACK is
3462 not GC_MAKE_GCPROS_NOOPS.
3463 (which_symbols): Use it.
3464
a0241d01
KH
34652011-11-07 Kenichi Handa <handa@m17n.org>
3466
3467 * coding.c (coding_set_destination): Check coding->src_pos only
3468 when coding->src_object is a buffer (bug#9910).
3469
3470 * process.c (send_process): Set the member src_multibyte of coding
3471 to 0 (bug#9911) when sending a unibyte text.
3472
3473 * callproc.c (Fcall_process): Set the member src_multibyte of
3474 process_coding to 0 (bug#9912).
3475
a64bfdfa 34762011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3477
3478 * xmenu.c (cleanup_widget_value_tree): New function.
3479 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3480 calling free_menubar_widget_value_tree directly (Bug#9830).
3481
cb41b32a
PE
34822011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3483
3484 Fix some portability problems with 'inline'.
3485 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3486 (window_box_width, window_box_left, window_box_left_offset)
3487 (window_box_right, window_box_right_offset): Declare extern.
3488 Otherwise, these inline functions do not conform to C99 and
3489 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3490 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3491 * intervals.c (adjust_intervals_for_insertion)
3492 (adjust_intervals_for_deletion): Now extern, because otherwise the
3493 extern inline functions 'offset_intervals' couldn't refer to it.
3494 (static_offset_intervals): Remove.
3495 (offset_intervals): Rewrite using the old contents of
3496 static_offset_intervals. The old version didn't conform to C99
3497 because an extern inline function contained a reference to an
3498 identifier with static linkage.
3499
b7041366
AS
35002011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3501
3502 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3503 GC.
3504
88a37c4d
EZ
35052011-11-06 Eli Zaretskii <eliz@gnu.org>
3506
3507 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3508 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3509 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3510 return Qleft_to_right.
3511
49745b39
CY
35122011-11-06 Chong Yidong <cyd@gnu.org>
3513
3514 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3515 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3516 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3517 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3518 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3519 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3520 (Fwindow_vscroll): Doc fix.
3521 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3522 argument, since it makes no sense to pass a live window and for
3523 consistency with window-child.
3524
1f05cd82
CS
35252011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3526
3527 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3528 support MSVC.
3529
22610910
JR
35302011-11-05 Jason Rumney <jasonr@gnu.org>
3531
3532 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3533 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3534 fonts (Bug#6029).
3535 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3536 bitwise arithmetic preventing use of unicode-sip and non-truetype
3537 opentype fonts.
3538
a06776b2
EZ
35392011-11-05 Eli Zaretskii <eliz@gnu.org>
3540
3ad924ba
EZ
3541 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3542 "emacs"-only part.
3543
a06776b2
EZ
3544 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3545 initialization code to keep similarity to xfns.c after changes
3546 from 2011-11-05.
3547
c9e7db78
JD
35482011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3549
a97f8f3f
JD
3550 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3551 (unwind_create_frame): New function (Bug#9943).
3552 (Fx_create_frame): Restructure code to be more similar to the one in
3553 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3554 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3555 Move terminal->reference_count++ just before making the frame official
3556 (Bug#9943).
3557
3558 * nsterm.m (x_free_frame_resources): New function.
3559 (x_destroy_window): Move code to x_free_frame_resources.
3560
c9e7db78 3561 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3562 (Fx_create_frame, x_create_tip_frame):
3563 Move terminal->reference_count++ just before making the frame
75f1671a 3564 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3565 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3566
a6fc3b5c
EZ
35672011-11-05 Eli Zaretskii <eliz@gnu.org>
3568
3569 Support MSVC build with newer versions of Visual Studio.
3570 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3571 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3572 nt/gmake.defs.
3573
3574 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3575 which are not supported by MSVC.
3576 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3577 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3578 bitfields.
3579 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3580 types in bitfields.
3581 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3582
3583 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3584
58179cce 35852011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3586
3587 Support MSVC build with newer versions of Visual Studio.
3588 * w32.c: Don't include w32api.h for MSVC.
3589 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3590
3591 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3592 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3593 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3594 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3595 e_* cousins.
3596 (alloca) [_MSC_VER]: Define to _alloca.
3597
3598 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3599
3600 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3601
a58c13ed
EZ
36022011-11-04 Eli Zaretskii <eliz@gnu.org>
3603
3604 * xdisp.c (note_mouse_highlight): If either of
3605 previous/next-single-property-change returns nil, treat that as
3606 the beginning or the end of the buffer. (Bug#9955)
3607
fe0b6370
JD
36082011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3609
a58c13ed 3610 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3611 label is not null (Bug#9951).
3612 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3613 may be NULL.
3614
89bd5ee1
EZ
36152011-11-04 Eli Zaretskii <eliz@gnu.org>
3616
3617 * window.c (Fwindow_body_size): Mention in the doc string that the
3618 return value is in frame's canonical units. (Bug#9949)
3619
84c3edb9
EZ
36202011-11-03 Eli Zaretskii <eliz@gnu.org>
3621
4e2fb5c7
EZ
3622 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3623
84c3edb9 3624 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3625 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3626 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3627
bc17a887
EZ
36282011-11-01 Eli Zaretskii <eliz@gnu.org>
3629
3630 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3631 Don't stop backward scan on the continuation glyph, even though
3632 its CHARPOS is positive.
6d5eb5b0
SM
3633 (mouse_face_from_buffer_pos, note_mouse_highlight):
3634 Rename cover_string to disp_string.
bc17a887 3635
4ee88440
MR
36362011-11-01 Martin Rudalics <rudalics@gmx.at>
3637
3638 * window.c (temp_output_buffer_show): Don't use
3639 Vtemp_buffer_show_specifiers.
3640 (Vtemp_buffer_show_specifiers): Remove unused variable.
3641
c2ff3c02
EZ
36422011-10-30 Eli Zaretskii <eliz@gnu.org>
3643
3644 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3645 past the beginning of the current glyph matrix.
3646
58179cce 36472011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3648
3649 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3650 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3651 HAVE_GTK3 (Bug#9869).
b77a6a7f 3652
3b574623
JD
3653 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3654 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3655
b77a6a7f
JD
3656 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3657
3658 * xterm.c: Declare x_handle_net_wm_state to return int.
3659 (handle_one_xevent): Check if we are iconified but don't have
3660 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3661 (get_current_wm_state): Return non-zero if not hidden,
3662 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3663 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3664 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3665 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3666
196e41e4
PE
36672011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3668
3669 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3670 so that this new function doesn't get optimized away by a
3671 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3672
021f2e1a
AS
36732011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3674
3675 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3676
8b058d44
EZ
36772011-10-29 Eli Zaretskii <eliz@gnu.org>
3678
3679 Fix the `xbytecode' command.
3680 * .gdbinit (xprintbytestr): New command.
b50a28de 3681 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3682 (xbytecode): Print the byte-code string as well.
3683
4452fb80
EZ
36842011-10-29 Kim Storm <storm@cua.dk>
3685
8b058d44
EZ
3686 * alloc.c (which_symbols): New function.
3687
21b72067
AS
36882011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3689
3690 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3691 line. (Bug#9903)
3692
83ed7b5c
GM
36932011-10-29 Glenn Morris <rgm@gnu.org>
3694
3695 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3696 Not clear what it was for, and it causes various bugs. (Bug#9839)
3697
5a7a728b
EZ
36982011-10-28 Eli Zaretskii <eliz@gnu.org>
3699
3700 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3701 possible random value that matches one of those tested as
3702 condition to clear the mouse face.
3703
d3d0842f
CY
37042011-10-28 Chong Yidong <cyd@gnu.org>
3705
3706 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3707
31b39d13
DN
37082011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3709
3710 * window.c (make_window): Initialize phys_cursor_on_p.
3711
9aba6043
SM
37122011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3713
3714 * lisp.h (struct Lisp_Symbol): Update comments.
3715
c20992f4
JB
37162011-10-28 Juanma Barranquero <lekktu@gmail.com>
3717
3718 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3719
db4f02f2
EZ
37202011-10-28 Eli Zaretskii <eliz@gnu.org>
3721
3722 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3723 <oslsachem@gmail.com> for helping to debug this.
3724
3725 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3726 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3727 (g_b_init_get_glyph_outline_w): New static variables.
3728 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3729 (GetGlyphOutlineW_Proc): New typedefs.
3730 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3731 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3732 New functions.
3733 (w32font_open_internal, compute_metrics):
3734 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3735 instead of calling the "wide" APIs directly.
3736
3737 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3738
3739 * w32.h (syms_of_w32font): Add prototype.
3740
87e68db4
JB
37412011-10-27 Juanma Barranquero <lekktu@gmail.com>
3742
3743 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3744 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3745 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3746 (Fmove_to_window_line): Doc fix.
3747
435c1d67
CY
37482011-10-27 Chong Yidong <cyd@gnu.org>
3749
3750 * process.c (make_process): Set gnutls_state to NULL.
3751
3752 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3753 non-NULL, regardless of GNUTLS_INITSTAGE.
3754 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3755 an error. Set process slots as soon as we allocate them.
3756
3757 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3758
9c6c6f49
CY
37592011-10-27 Chong Yidong <cyd@gnu.org>
3760
9aba6043
SM
3761 * gnutls.c (emacs_gnutls_deinit): New function.
3762 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3763 (Fgnutls_deinit, Fgnutls_boot): Use it.
3764
3765 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3766 (deactivate_process): Call emacs_gnutls_deinit.
3767
657d08d3
JB
37682011-10-27 Juanma Barranquero <lekktu@gmail.com>
3769
3770 * image.c (x_create_x_image_and_pixmap):
3771 * w32.c (sys_rename, w32_delayed_load):
3772 * w32font.c (fill_in_logfont):
3773 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3774
5430d399
JB
37752011-10-26 Juanma Barranquero <lekktu@gmail.com>
3776
3777 * w32fns.c (w32_default_color_map): New function,
3778 extracted from Fw32_default_color_map.
a7ef684b 3779 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3780
fe0055fa
PE
37812011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3782
3783 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3784
e6346438
SM
37852011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3786
3787 * keyboard.c (test_undefined): New function (bug#9751).
3788 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3789
e112cc37
ET
37902011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3791
3792 * sysdep.c (init_sys_modes): Fix the check for the controlling
3793 terminal (Bug#6649).
3794
7b5d6677
EZ
37952011-10-20 Eli Zaretskii <eliz@gnu.org>
3796
3797 * dispextern.h (struct bidi_it): New member next_en_type.
3798
3799 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3800 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3801 current character, check also for next_en_type being WEAK_EN.
3802 (bidi_resolve_weak): Don't enter the expensive loop if the current
3803 position is before next_en_pos. Record the bidi type of the first
3804 non-ET, non-BN character we find, in addition to its position.
3805 (bidi_level_of_next_char): Invalidate next_en_type when
3806 next_en_pos is over-stepped.
3807
7da0b018
PE
38082011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3809
3810 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3811 * editfns.c: Rewrite current-time-zone so that it invokes
3812 the equivalent of (format-time-string "%Z") to get the time zone name.
3813 This fixes a bug when the time zone name contains characters that
3814 need converting from the system time locale to Emacs internal format.
3815 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3816 that patch fixed format-time-string to do the conversion, but
3817 I forgot to fix current-time-zone.
3818 (format_time_string): New function, containing most of
3819 what Fformat_time_string used to contain.
3820 (Fformat_time_string): Rewrite in terms of format_time_string.
3821 This doesn't change this function's behavior.
3822 (current-time-zone): Rewrite to use format_time_string.
3823 This fixes the bug reported by Michael Schierl in
3824 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3825 Jason Rumney's 2007-06-07 change worked around this bug, but
3826 didn't fix it.
3827 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3828
8547b010
EZ
38292011-10-19 Eli Zaretskii <eliz@gnu.org>
3830
3831 * xdisp.c (start_display): If the character at POS is displayed
3832 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3833 (try_window_reusing_current_matrix): If a line ends in a display
3834 vector or the next line starts in a display vector, continue
3835 redrawing the window even though the character position of
3836 start_row was reached.
8547b010
EZ
3837 (Bug#9771, part 2)
3838
4e948d15
CY
38392011-10-18 Chong Yidong <cyd@gnu.org>
3840
3841 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3842 with nobreak-char-display too.
3843
4787455f
EZ
38442011-10-18 Eli Zaretskii <eliz@gnu.org>
3845
3846 Fix part 3 of bug#9771.
3847 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3848 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3849 non-neutral characters if the current character is a paragraph
3850 separator (a.k.a. Newline). This avoids running the same
3851 expensive loop twice, once when we consume the preceding newline
3852 and the other time when the line actually needs to be displayed.
3853 Avoid the loop when we see neutrals on the base embedding level
3854 following a character whose directionality is the same as the
3855 paragraph's. This avoids running the expensive loop when a line
3856 ends in a long sequence of neutrals, like control characters.
3857 Add assertion against STRONG_AL type. Slightly rearrange code
3858 that determines the type of a neutral given the first non-neutral
3859 that follows it.
3860 (bidi_level_of_next_char): Set next_en_pos to zero when
3861 invalidating its info.
3862
2c91f553
EZ
38632011-10-17 Eli Zaretskii <eliz@gnu.org>
3864
3865 * xdisp.c (push_display_prop): Determine whether to record string
3866 or buffer position by IT->string, not by IT->method. Allow
3867 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3868 (move_it_vertically_backward): Don't look for character position
3869 immediately after the newline when in a continuation line.
3870 (Bug#9771, part 1)
2c91f553 3871
c7b08b0d
MR
38722011-10-15 Martin Rudalics <rudalics@gmx.at>
3873
3874 * window.c (coordinates_in_window): Rewrite and delabelize
3875 vertical border check. (Bug#5357) (Bug#9618)
3876
6b02f655
SM
38772011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3878
3879 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3880 errors in XSetWindowBorder (bug#9310).
3881
81d40c92
DA
38822011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3883
3884 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3885 avoid crash when xmalloc overrun checking is enabled.
3886
d4172c3b
EZ
38872011-10-13 Eli Zaretskii <eliz@gnu.org>
3888
3889 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3890 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3891 cursor motion with <left> and <right> arrow keys.
3892
3893 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3894 some callers set that themselves.
3895
b00eea75
EZ
38962011-10-12 Eli Zaretskii <eliz@gnu.org>
3897
3898 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3899 display string and the previous row comes from the same string and
3900 is empty. (Bug#9739) (Bug#9738)
3901
8fe012c4
SM
39022011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3903
3904 * doc.c (get_doc_string): Encode file name (bug#9735).
3905
0074aef2
EZ
39062011-10-12 Eli Zaretskii <eliz@gnu.org>
3907
79beb178
EZ
3908 * bidi.c (bidi_level_of_next_char):
3909 * xdisp.c (get_visually_first_element): Remove old incorrect
3910 comments regarding the Unicode Line Separator character.
3911
0074aef2
EZ
3912 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3913
6e4b3fbe
DA
39142011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3915
3916 * alloc.c (Fgc_status): Do not access beyond zombies array
3917 boundary if nzombies > MAX_ZOMBIES.
3918 * alloc.c (dump_zombies): Add missing format specifier.
3919
0324f3af
PE
39202011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3921
b5525cac
PE
3922 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3923 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3924
0324f3af
PE
3925 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3926 Some packages use them to denote characters with modifiers.
3927
e9b5f888
AS
39282011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3929
3930 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3931 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3932 matching a pp-number. Rename parameter var to var1.
3933
127827c0
SM
39342011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3935
3936 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3937
c8fd3bd0
GM
39382011-10-08 Glenn Morris <rgm@gnu.org>
3939
3940 * callint.c (Fcall_interactively): Give a more explicit error for the
3941 'c' case with a non-character input. (Bug#8479)
3942
352ec8ff
EZ
39432011-10-08 Eli Zaretskii <eliz@gnu.org>
3944
03669ccb
EZ
3945 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3946 lines.
7061c986
EZ
3947 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3948 lines that are hscrolled on the left.
03669ccb 3949
352ec8ff
EZ
3950 * dispnew.c (buffer_posn_from_coords): Account for a possible
3951 presence of header-line. (Bug#4426)
3952
a66cfb1c
SM
39532011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3954
6b02f655
SM
3955 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3956 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3957
7c5ee88e
PE
39582011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3959
3960 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3961 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3962 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3963 this makes Emacs dump core during garbage collection on rare
3964 occasions. sizeof is obviously inferior to offsetof here, so
3965 stick with offsetof.
3966 (GC_POINTER_ALIGNMENT): New macro.
3967 (mark_memory): Omit 3rd (offset) arg; caller changed.
3968 Don't assume EMACS_INT alignment is the same as pointer alignment.
3969
df1bbe5b
SM
39702011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3971
3972 * keyboard.c (read_key_sequence_remapped): New var.
3973 (read_key_sequence): Compute remapping in the right buffer.
3974 (command_loop_1): Use read_key_sequence's remapping directly.
3975
51553db6
SM
39762011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3977
32c1fffd
SM
3978 * dired.c (file_name_completion): Don't expand file name.
3979 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3980 before checking file name handler.
3981
51553db6
SM
3982 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3983 they've been requested explicitly (bug#9591).
3984
b6bd1599 39852011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3986
3987 * keymap.c (Fsingle_key_description): Use make_specified_string
3988 instead of build_string to build string from push_key_description.
3989 (Bug#5193)
3990
f701dc2a
PE
39912011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3992
4222c55d
PE
3993 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3994 This fixes a Y2038 bug on 64-bit hosts.
3995 * buffer.c (reset_buffer):
3996 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3997 (Fclear_buffer_auto_save_failure):
3998 Use 0, not -1, to represent an unset failure time, since time_t
3999 might not be signed.
4000
f701dc2a
PE
4001 Remove dependency on glibc malloc internals.
4002 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4003 Move back here from lisp.h, but with their new implementations.
4004 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4005 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4006 * charset.c (charset_table_init): New static var.
4007 (syms_of_charset): Use it instead of xmalloc. This removes a
4008 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4009 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4010 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4011 Move back to alloc.c.
4012 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4013 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4014
9ceebf39
JD
40152011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4016
4017 * nsterm.m (windowDidResize): Call x_set_window_size only when
4018 ns_in_resize is true. Otherwise set pixelwidth/height and
4019 call change_frame_size (Bug#9628).
4020
cb993c58
PE
40212011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4022
3930c88b
PE
4023 Port --enable-checking=all to Fedora 14 x86-64.
4024 * charset.c (syms_of_charset): Also account for glibc malloc's
4025 internal overhead when calculating the initial malloc maximum.
4026
cb993c58
PE
4027 Port --enable-checking=all to Fedora 14 x86.
4028 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4029 Move to lisp.h.
4030 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4031 (overrun_check_realloc, overrun_check_free):
4032 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4033 That way, xmalloc returns a properly-aligned pointer even if
4034 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4035 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4036 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4037 into account when calculating the initial malloc maximum.
4038 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4039 Move here from alloc.c, so that charset.c can use it too.
4040 Properly align; the old code wasn't right for common 32-bit hosts
4041 when configured with --enable-checking=all.
4042 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4043 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4044
31bed486
EZ
40452011-09-29 Eli Zaretskii <eliz@gnu.org>
4046
04c70788 4047 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4048 use EDOM.
4049
fbcaa2f3
EZ
40502011-09-28 Eli Zaretskii <eliz@gnu.org>
4051
4052 * xdisp.c (compute_display_string_end): If there's no display
4053 string at CHARPOS, return -1.
4054
4055 * bidi.c (bidi_fetch_char): When compute_display_string_end
4056 returns a negative value, treat the character as a normal
4057 character not covered by a display string. (Bug#9624)
4058
a239d4e9
JB
40592011-09-28 Juanma Barranquero <lekktu@gmail.com>
4060
4061 * lread.c (Fread_from_string): Fix typo in docstring.
4062
88652fd5
EZ
40632011-09-27 Eli Zaretskii <eliz@gnu.org>
4064
4065 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4066 newline, reseat the iterator instead of bidi-iterating there one
4067 character at a time. (Bug#9610)
32c1fffd
SM
4068 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4069 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4070
ed497dd4
AS
40712011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4072
4073 * lread.c (readevalloop): Use correct code for NBSP.
4074 (read1): Likewise. (Bug#9608)
4075
b2bf61aa
MA
40762011-09-25 Michael Albinus <michael.albinus@gmx.de>
4077
4078 * dbusbind.c (Fdbus_register_signal): When service is not
4079 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4080
32bbb17c
GM
40812011-09-25 Glenn Morris <rgm@gnu.org>
4082
4083 * buffer.c (truncate-lines): Doc fix.
4084
94e0933e
CY
40852011-09-24 Chong Yidong <cyd@stupidchicken.com>
4086
4087 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4088 (Fset_window_next_buffers): Doc fix.
4089
cddde921
GM
40902011-09-24 Glenn Morris <rgm@gnu.org>
4091
4092 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4093
1260aef1
PE
40942011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4095
25b4bfa0
PE
4096 Fix minor problems found by static checking.
4097 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4098 * indent.c (Fvertical_motion): Fix == vs = typo.
4099
e3cbd34b
EZ
41002011-09-24 Eli Zaretskii <eliz@gnu.org>
4101
a66cfb1c
SM
4102 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4103 Default value is now t. Doc fix.
6bf7006f 4104
e3cbd34b 4105 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4106 logic when moving up, not only when moving down. Fix the
e3cbd34b 4107 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4108 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4109
4110 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4111 CHARPOS is covered by a display string which includes newlines.
4112 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4113 is covered by a display string with embedded newlines.
4114
a3de0cbd
MA
41152011-09-24 Michael Albinus <michael.albinus@gmx.de>
4116
4117 * dbusbind.c (Fdbus_register_signal): Add match rule to
4118 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4119 (Fdbus_register_method, Vdbus_registered_objects_table):
4120 Fix docstring.
a3de0cbd 4121
b260039d
JM
41222011-09-24 Jim Meyering <meyering@redhat.com>
4123
32c1fffd 4124 do not ignore write error for any output size
b260039d
JM
4125 The previous change was incomplete.
4126 While it makes emacs --batch detect the vast majority of stdout
4127 write failures, errors were still ignored whenever the output size is
4128 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4129 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4130 && echo FAIL: ignored write error
4131 FAIL: ignored write error
4132 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4133 && echo FAIL: ignored write error
4134 FAIL: ignored write error
4135 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4136
8eca8a7c
AS
41372011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4138
4139 * emacs.c (Fkill_emacs): In noninteractive mode exit
4140 non-successfully if a write error occurred on stdout. (Bug#9574)
4141
3341db62
EZ
41422011-09-21 Eli Zaretskii <eliz@gnu.org>
4143
4144 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4145 the xassert test.
4146
4147 * dispextern.h (struct it): Update the comment documenting what
4148 can it->OBJECT be.
4149
8c203dbf
EZ
41502011-09-20 Eli Zaretskii <eliz@gnu.org>
4151
4152 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4153 a display string, extend search for cursor position to end of row.
4154 (find_row_edges): If the row ends in a newline from a display
4155 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4156 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4157 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4158 non-empty line. Fixes confusing cursor motion with arrow keys at
4159 the beginning of a line that starts with whitespace.
8c203dbf 4160
a4824228
LMI
41612011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4162
4163 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4164 (bug#9493).
4165
33ed493b
CY
41662011-09-18 Chong Yidong <cyd@stupidchicken.com>
4167
4168 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4169 boolean (Bug#9154).
4170
56cd55c8
EZ
41712011-09-18 Eli Zaretskii <eliz@gnu.org>
4172
4173 * xdisp.c (display_line): Record maximum and minimum buffer
4174 positions even if no glyphs were produced (e.g., by a zero-width
4175 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4176 buffer positions that will be removed from the glyph row because
4177 they don't fit.
c02dcedf
EZ
4178 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4179 column is beyond frame width: don't subtract 1 "pixel" when
4180 computing width of the stretch.
3e62b7e0
EZ
4181 (reseat_at_next_visible_line_start): Undo the change made on
4182 2011-09-17 that saved paragraph information and restored it after
4183 the call to `reseat'. (Bug#9545)
56cd55c8 4184
5ed99d36 41852011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4186
4187 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4188 and turn window cursor on if cleared (Bug#9415).
4189
5ed99d36 41902011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4191
4192 * search.c (boyer_moore): Take unibyte characters from pattern
4193 literally. (Bug#9458)
4194
9bade7b2
EZ
41952011-09-18 Eli Zaretskii <eliz@gnu.org>
4196
4197 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4198
e5e9d610
PE
41992011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4200
87e4427a
PE
4201 Fix minor problem found by static checking.
4202 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4203 initialized, to pacify gcc -Wuninitialized.
4204
e5e9d610
PE
4205 * fileio.c: Report proper errno when syscall falls.
4206 (Finsert_file_contents): Save and restore errno,
4207 so that report_file_error outputs the correct diagnostic.
4208 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4209
a1674f0b
EZ
42102011-09-18 Eli Zaretskii <eliz@gnu.org>
4211
4212 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4213
fbfb6dd4
EZ
42142011-09-17 Eli Zaretskii <eliz@gnu.org>
4215
4216 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4217 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4218
bb187662
EZ
42192011-09-17 Eli Zaretskii <eliz@gnu.org>
4220
1137e8b8 4221 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4222 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4223
4224 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4225 (bidi_find_paragraph_start): Search back for paragraph beginning
4226 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4227 (bidi_move_to_visually_next): Only trigger paragraph-related
4228 computations when the last character is a newline or at EOB, not
4229 just any NEUTRAL_B. (Bug#9470)
4230
bb187662
EZ
4231 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4232 truncated lines if point is covered by a display string. (Bug#9524)
4233
2e621251
PE
42342011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4235
4236 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4237 (cons_to_x_long): New function.
4238 (lisp_data_to_selection_data): Use it. Correct the test for
4239 short-versus-long data; it was negated. Break out of vector
4240 loop, for efficiency, when a long datum is discovered.
4241
91a15bc6
SM
42422011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4243
4244 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4245
b41c3a35
EZ
42462011-09-16 Eli Zaretskii <eliz@gnu.org>
4247
4248 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4249 GCC PR/17406) by declaring this function with external scope.
4250
7812ba2d
PE
42512011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4252
4253 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4254 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4255
cf7edc2a
AS
42562011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4257
4258 * editfns.c (Fformat): Correctly handle text properties on "%%".
4259
bd01620e
EZ
42602011-09-15 Eli Zaretskii <eliz@gnu.org>
4261
4262 * xterm.c (x_draw_composite_glyph_string_foreground):
4263 * w32term.c (x_draw_composite_glyph_string_foreground):
4264 * term.c (encode_terminal_code):
4265 * composite.c (composition_update_it, get_composition_id):
4266 * xdisp.c (get_next_display_element)
4267 (fill_composite_glyph_string): Add comments about special meaning
4268 of TAB characters in a composition.
4269
a02719a3
PE
42702011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4271
4272 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4273 This occurs when processing a multibyte format.
4274 Problem reported by Wolfgang Jenker.
a02719a3 4275
72589a3c
JB
42762011-09-15 Johan Bockgård <bojohan@gnu.org>
4277
4278 * xdisp.c (try_cursor_movement): Only check for exact match if
4279 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4280
1c14176c
PE
42812011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4282
4283 Remove unused external symbols.
4284 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4285 * xdisp.c (calc_pixel_width_or_height): Now static.
4286 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4287 * indent.c (check_display_width):
4288 * w32term.c: Fix comment to match code.
4289 * xterm.c, xterm.h (x_catching_errors): Remove.
4290
d2eea5b5
PE
42912011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4292
4293 * xselect.c: Use signed conversions more consistently (Bug#9498).
4294 (selection_data_to_lisp_data): Assume incoming selection data are
4295 signed integers, not unsigned. This is to be consistent with
4296 outgoing selection data, which was modified to use signed integers
4297 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4298 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4299 expects long, not unsigned long.
4300
46888499
EZ
43012011-09-14 Eli Zaretskii <eliz@gnu.org>
4302
4303 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4304 computation of loop end. Reported by Johan Bockgård
4305 <bojohan@gnu.org>.
4306
ef8ef9fb
CY
43072011-09-13 Chong Yidong <cyd@stupidchicken.com>
4308
4309 * frame.c (Fother_visible_frames_p): Function deleted.
4310
fa819fed
EZ
43112011-09-12 Eli Zaretskii <eliz@gnu.org>
4312
4313 * indent.c (compute_motion): Process display vector front to back
4314 rather than the other way around. (Bug#2496)
4315
2ba8e008
SM
43162011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4317
4318 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4319
20f53c69
CY
43202011-09-11 Chong Yidong <cyd@stupidchicken.com>
4321
4322 * minibuf.c (Fread_from_minibuffer): Doc fix.
4323
d562d7a4
EZ
43242011-09-11 Eli Zaretskii <eliz@gnu.org>
4325
4326 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4327 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4328
1c4d7f3d
LMI
43292011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4330
4331 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4332 value for non-existent files.
4333
b885bf36
EZ
43342011-09-11 Eli Zaretskii <eliz@gnu.org>
4335
4336 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4337 set its "size" to -1. This will set the modtime_size field of
4338 the corresponding buffer to -1, which is what
4339 verify-visited-file-modtime expects for files that do not exist.
4340 (Bug#9139)
4341
6612f0bf
PE
43422011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4343
4344 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4345 here ...
4346 * lisp.h: ... from here. push_key_description is no longer
4347 defined in keyboard.c, so its declaration should not be in
4348 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4349 logically belongs with push_key_description.
4350
dfb3f755
PE
43512011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4352
4353 * buffer.h: Include <sys/types.h> instead of <time.h>.
4354 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4355 Problem reported by Herbert J. Skuhra.
4356
3134906c
LMI
43572011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4358
4359 * xml.c (parse_region): Make the parsing work for
4360 non-comment-starting XML files again (bug#9144).
4361
8d903f4e
AS
43622011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4363
4364 * image.c (gif_load): Fix calculation of bottom and right corner.
4365 (Bug#9468)
4366
80ad64f4
EZ
43672011-09-10 Eli Zaretskii <eliz@gnu.org>
4368
4369 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4370 redisplay in small windows.
4371
208a048d
EZ
43722011-09-09 Eli Zaretskii <eliz@gnu.org>
4373
4374 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4375
9b1c252e
MR
43762011-09-08 Martin Rudalics <rudalics@gmx.at>
4377
4378 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4379 Operate on live windows only.
4380
2949f33b
JB
43812011-09-08 Juanma Barranquero <lekktu@gmail.com>
4382
4383 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4384
e08dcafd
EZ
43852011-09-07 Eli Zaretskii <eliz@gnu.org>
4386
4387 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4388 only under bidi iteration.
4389
115b96bd
JD
43902011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4391
4392 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4393
c8199d0f
PE
43942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4395
4396 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4397 Without this fix, the command to link temacs failed due to an
4398 undefined symbol __builtin_isnan. This is because
4399 /usr/include/iso/math_c99.h #defines isnan(x) to
4400 __builtin_isnan(x), but the bundled gcc, which identifies itself
4401 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4402 a __builtin_isnan.
4403 * floatfns.c (isnan): #undef, and then #define to a clone of
4404 what's in data.c.
4405 (Fisnan): Always define, since it's always available now.
4406 (syms_of_floatfns): Always define isnan at the Lisp level.
4407
e39b275c 44082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4409
4410 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4411
b2db44d9 44122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4413
f4af5137 4414 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4415 The previous code assumed that file offsets (off_t values) fit in
4416 EMACS_INT variables, which is not true on typical 32-bit hosts.
4417 The code messed up by falsely reporting buffer overflow in cases
4418 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4419 when "big" contains more than 2**29 bytes, even though this
4420 inserts just one byte and does not overflow the buffer.
4421 (Finsert_file_contents): Store file offsets as off_t
4422 values, not as EMACS_INT values. Check for overflow when
4423 converting between EMACS_INT and off_t. When checking for
4424 buffer overflow or for overlap, take the offsets into account.
4425 Don't use EMACS_INT for small values where int suffices.
4426 When checking for overlap, fix a typo: ZV was used where
4427 ZV_BYTE was intended.
4428 (Fwrite_region): Don't assume off_t fits into 'long'.
4429 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4430
ecfc0a49
MA
44312011-09-05 Michael Albinus <michael.albinus@gmx.de>
4432
4433 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4434
6511acf2 44352011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4436
0999621a 4437 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4438
4439 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4440 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4441 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4442 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4443 (modify_event_symbol): Do not assume that the length of
4444 name_alist_or_stem is safe to alloca and fits in int.
4445 (Fexecute_extended_command): Likewise for function name and binding.
4446 (Frecursion_depth): Wrap around reliably on integer overflow.
4447 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4448 since some callers pass EMACS_INT values.
4449 (Fsingle_key_description): Don't crash if symbol name contains more
4450 than MAX_ALLOCA bytes.
4451 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4452 (get_minibuffer): Arg is now EMACS_INT, not int.
4453 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4454 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4455 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4456
2be7d702
PE
4457 * dbusbind.c (signature_cat): New function.
4458 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4459 Do not overrun buffer; instead, report string overflow.
4460
9d1df220
PE
4461 * dispnew.c (add_window_display_history): Don't overrun buffer.
4462 Truncate instead; this is OK since it's just a log.
4463
33ef5c64
PE
4464 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4465 even if the time zone offset is outlandishly large.
4466 Don't mishandle offset == INT_MIN.
4467
66c6fdd5
PE
4468 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4469 when creating daemon; the previous buffer-overflow check was incorrect.
4470
d749b01b
PE
4471 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4472 which has the guts of the old verror function.
4473
b5cd1905
PE
4474 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4475 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4476
6e1a67fb
PE
4477 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4478 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4479 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4480 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4481 length of string rather than counting it via multiple sprintfs;
4482 that's simpler and more reliable.
c21721cc
PE
4483 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4484 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4485 sprintf, in case result does not fit in int.
4486
c57b67fc
PE
4487 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4488 (fontset_from_font): Print it.
4489
8a401434
PE
4490 * frame.c (tty_frame_count): Now printmax_t, not int.
4491 (make_terminal_frame, set_term_frame_name): Print it.
4492 (x_report_frame_params): In X, window IDs are unsigned long,
4493 not signed long, so print them as unsigned.
4494 (validate_x_resource_name): Check for implausibly long names,
4495 and don't assume name length fits in 'int'.
4496 (x_get_resource_string): Don't blindly alloca invocation name;
4497 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4498 not fit in int.
4499
6e1a67fb
PE
4500 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4501 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4502 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4503
0df02bf3
PE
4504 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4505 Use esprintf, not sprintf, in case result does not fit in int.
4506
48e30793
PE
4507 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4508 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4509 it as a large positive number.
4510 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4511 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4512
a66ff6d8
PE
4513 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4514 in case result does not fit in int.
4515
aca216ff
PE
4516 * print.c (float_to_string): Detect width overflow more reliably.
4517 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4518 buffer overrun. Don't assume list length fits in 'int'. Treat
4519 print length of 0 as 0, not as infinity; to be consistent with other
4520 uses of print length in this function. Don't overflow print length
4521 index. Don't assume hash table size fits in 'long', or that
4522 vectorlike size fits in 'unsigned long'.
4523
31c286f7
PE
4524 * process.c (make_process): Use printmax_t, not int, to format
4525 process-name gensyms.
4526
55e5faa1
PE
4527 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4528
80f2e268
PE
4529 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4530 to avoid potential buffer overrun.
4531
670741ab
PE
4532 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4533 if X resource line is longer than 512 bytes.
4534
b7163a50
PE
4535 * xfns.c (x_window): Make sprintf buffer a bit bigger
4536 to avoid potential buffer overrun.
4537
ae58ff1f
PE
4538 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4539
c43c8a6a
PE
4540 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4541
3f8236f4
PE
45422011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4543
53e9fe90 4544 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4545 Without these, Emacs silently mishandles large integers sometimes.
4546 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4547 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4548
6511acf2
PE
4549 * xdisp.c (try_window_id): Check Emacs fixnum range before
4550 converting to 'int'.
806add1d 4551
6511acf2 4552 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4553 Check that an Emacs fixnum is in range before assigning it to 'int'.
4554 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4555 values converted from Emacs fixnums.
4556 (Frecenter): Don't wrap around a line count if it is out of 'int'
4557 range; instead, treat it as an extreme value.
4558 (Fset_window_configuration, compare_window_configurations):
4559 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4560
6511acf2
PE
4561 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4562 that can exceed INT_MAX. Check that EMACS_INT value is in range
4563 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4564 (match_limit): Don't assume that a fixnum can fit in 'int'.
4565
6511acf2 4566 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4567 exceed INT_MAX.
4568
6511acf2 4569 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4570 (Fvertical_motion): Don't wrap around LINES values that don't fit
4571 in 'int'. Instead, treat them as extreme values. This is good
4572 enough for windows, which can't have more than INT_MAX lines anyway.
4573
fcb901a7
LMI
45742011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4575
0f2f6b6d
LMI
4576 * Require libxml/parser.h to avoid compilation warning.
4577
fcb901a7
LMI
4578 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4579
4580 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4581 since this reportedly can destroy thread storage.
4582
6e20a0d4
CY
45832011-08-30 Chong Yidong <cyd@stupidchicken.com>
4584
4585 * syntax.c (find_defun_start): Update all cache variables if
4586 exiting early (Bug#9401).
4587
148ae00e
EZ
45882011-08-30 Eli Zaretskii <eliz@gnu.org>
4589
f6cfbd8f
EZ
4590 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4591
148ae00e
EZ
4592 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4593 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4594 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4595
4596 * term.c (tty_append_glyph): New function.
4597 (produce_stretch_glyph): Static function and its prototype deleted.
4598
a66cfb1c
SM
4599 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4600 Add prototypes.
148ae00e 4601
c4a07a4c
PE
46022011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4603
4604 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4605 when checking :margin (Bug#9390).
4606 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4607 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4608 so that the name doesn't mislead. All uses changed.
4609
6bc8cd65
JB
46102011-08-28 Johan Bockgård <bojohan@gnu.org>
4611
4612 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4613 set_tty_hooks.
4614
dca4927e
EZ
46152011-08-27 Eli Zaretskii <eliz@gnu.org>
4616
4617 * xdisp.c (move_it_to): Don't bail out early when reaching
4618 position beyond to_charpos, if we are scanning backwards.
4619 (move_it_vertically_backward): When DY == 0, make sure we get to
4620 the first character in the line after the newline.
4621
f2cad773
PE
46222011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4623
4624 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4625 (ccl_driver): Do not generate an out-of-range pointer.
4626 (Fccl_execute_on_string): Remove unnecessary check for
4627 integer overflow, noted by Stefan Monnier in
4628 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4629 Remove a FIXME that didn't need fixing.
4630 Simplify the newly-introduced buffer reallocation code.
4631
0cae2cdb
JB
46322011-08-27 Juanma Barranquero <lekktu@gmail.com>
4633
4634 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4635
5fc295a4 46362011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4637
70c60eb2 4638 Integer and memory overflow issues (Bug#9196).
726e0ab1 4639
d31850da
PE
4640 * doc.c (get_doc_string): Rework so that
4641 get_doc_string_buffer_size is the actual buffer size, rather than
4642 being 1 less than the actual buffer size; this makes xpalloc more
4643 convenient.
4644
a69fbedb
PE
4645 * image.c (x_allocate_bitmap_record, cache_image):
4646 * xselect.c (Fx_register_dnd_atom):
4647 Simplify previous changes by using xpalloc.
4648
fe5c5d37
PE
4649 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4650 since either will do and ptrdiff_t is convenient with xpalloc.
4651
0065d054
PE
4652 * charset.c (charset_table_size)
4653 (struct charset_sort_data.priority): Now ptrdiff_t.
4654 (charset_compare): Don't overflow if priorities differ greatly.
4655 (Fsort_charsets): Don't assume list length fits in int.
4656 Check for size-calculation overflow when allocating sort data.
4657 (syms_of_charset): Allocate an initial charset table that is
4658 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4659
4660 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4661
4662 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4663 The actual value is always <= INT_MAX, and leaving it unsigned made
4664 overflow checking harder.
4665
4666 * dispextern.h (struct glyph_matrix.rows_allocated)
4667 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4668 with xpalloc. The values are still always <= INT_MAX.
4669
4670 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4671
4672 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4673 (SAFE_NALLOCA): New macro.
4674
4675 * region-cache.c (struct boundary.pos, find_cache_boundary)
4676 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4677 (set_cache_region, invalidate_region_cache)
4678 (revalidate_region_cache, know_region_cache, region_cache_forward)
4679 (region_cache_backward, pp_cache):
4680 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4681 so that ptrdiff_t * can be passed to xpalloc.
4682 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4683 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4684 (pp_cache): Don't assume cache_len fits in int.
4685 * region-cache.h: Adjust extern decls to match.
4686
4687 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4688 EMACS_INT, since either will do, for xpalloc.
4689
4690 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4691 (xnmalloc, xnrealloc, xpalloc): New functions.
4692
726e0ab1
PE
4693 * bidi.c (bidi_shelve_header_size): New constant.
4694 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4695 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4696
51f30bc5 4697 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4698 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4699 (overlay_strings):
4700 Don't update size of array until after memory allocation succeeds,
4701 because xmalloc/xrealloc may not return.
0065d054
PE
4702 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4703 now that we have proper integer overflow checking.
4704 (record_overlay_string, overlay_strings): Catch overflows when
4705 calculating size of overlay_str_buf.
726e0ab1 4706
0065d054
PE
4707 * callproc.c (Fcall_process): Check for size overflow when
4708 calculating size of args2.
4709 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4710 Normally we prefer signed values, but sticking with ptrdiff_t would
4711 require adding more-complicated checks.
726e0ab1
PE
4712
4713 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4714 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4715 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4716 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4717
4718 * character.c (Fstring): Check for size-calculation overflow.
4719
4720 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4721 unnecessary integer overflow. Check for size overflow.
4722 (encode_coding_object): Don't update size until xmalloc succeeds.
4723
4724 * composite.c (get_composition_id): Check for overflow in glyph
4725 length calculations.
4726
4727 Integer and memory overflow fixes for display code.
4728 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4729 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4730 (scrolling_window): Check for overflow in size calculations.
4731 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4732 Don't assume glyph table len fits in int.
4733 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4734 (row_table_size): Now ptrdiff_t, not int.
4735 (scrolling_window): Avoid overflow in size calculations.
4736 Don't update size until allocation succeeds.
4737 * fns.c (concat): Check for overflow in size calculations.
4738 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4739 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4740 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4741
4742 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4743 (get_doc_string): Check for size calculation overflow.
4744 Don't update size until allocation succeeds.
4745 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4746 EMACS_INT, where ptrdiff_t will do.
4747 (Fsubstitute_command_keys): Check for string overflow.
4748
4749 * editfns.c (set_time_zone_rule): Don't assume environment length
4750 fits in int.
4751 (message_length): Now ptrdiff_t, not int.
4752 (Fmessage_box): Don't update size until allocation succeeds.
4753 Don't assume message length fits in int.
4754 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4755
0065d054
PE
4756 * emacs.c (main): Do not reallocate argv, since there is a null at
4757 the end that can be overwritten, and this way there's no need to
4758 worry about size-calculation overflow.
4759 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4760
4761 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4762 alloc succeeds.
4763 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4764
4765 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4766 (x_set_scroll_bar_width, x_figure_window_size):
4767 Check for integer overflow.
4768 (x_set_alpha): Do not assume XINT fits in int.
4769
4770 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4771 This is for the members text_lines, text_cols, total_lines, total_cols,
4772 where the system imposes an 'int' limit.
4773
4774 * fringe.c (Fdefine_fringe_bitmap):
4775 Don't update size until alloc works.
4776
4777 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4778 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4779
4780 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4781 Check for size-calculation overflow.
4782 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4783 do, as we prefer signed integers.
4784 (id_to_widget.max_size, id_to_widget.used)
4785 (xg_store_widget_in_map, xg_remove_widget_from_map)
4786 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4787 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4788 Use and return ptrdiff_t, not int.
4789 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4790 * gtkutil.h: Change prototypes to match the above.
4791
4792 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4793 are duplicate now that they've been promoted to lisp.h.
4794 (x_allocate_bitmap_record, x_alloc_image_color)
4795 (make_image_cache, cache_image, xpm_load):
4796 Don't update size until alloc is done.
4797 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4798 (x_detect_edges):
3256efce 4799 Check for size calculation overflow.
726e0ab1
PE
4800 (ct_colors_allocated_max): New constant.
4801 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4802 overflow.
3256efce 4803
726e0ab1
PE
4804 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4805 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4806 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4807 Use ptrdiff_t, not int, to count maps.
4808 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4809 calculations. Don't update size until allocation succeeds.
4810 Redo calculations to avoid overflow.
726e0ab1
PE
4811 * keyboard.h: Change prototypes to match the above.
4812
4813 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4814 to count maps.
4815 (current_minor_maps): Check for size calculation overflow.
4816 * keymap.h: Change prototypes to match the above.
4817
4818 * lread.c (read1, init_obarray): Don't update size until alloc done.
4819
4820 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4821 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4822
726e0ab1
PE
4823 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4824 Now ptrdiff_t, not int.
4825 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4826 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4827
4828 * process.c (Fnetwork_interface_list): Check for overflow
4829 in size calculation.
4830
4831 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4832
4833 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4834 overflow. Don't bother calling xmalloc when xrealloc will do.
4835
4836 * search.c (Freplace_match): Check for size calculation overflow.
4837 (Fset_match_data): Don't assume list lengths fit in 'int'.
4838
4839 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4840 for command line length. Do not attempt to address one before the
4841 beginning of an array, as that's not portable.
4842
4843 * term.c (max_frame_lines): Remove; unused.
4844 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4845 not int.
4846 (encode_terminal_code, calculate_costs): Check for size
4847 calculation overflow.
4848 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4849 table lengths and related sizes. Don't update size until alloc
4850 done. Redo calculations to avoid overflow.
4851 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4852
4853 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4854 subtracting pointers.
4855 (gobble_line): Check for overflow more carefully. Don't update size
4856 until alloc done.
4857
4858 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4859 Don't update size until alloc done.
4860 Redo size calculations to avoid overflow.
4861 Check for size calculation overflow.
0065d054 4862 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4863
4864 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4865 Use ptrdiff_t, not int, for sizes.
4866 (store_mode_line_noprop_char): Don't update size until alloc done.
4867
0065d054
PE
4868 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4869 Use ptrdiff_t, not int, for sizes.
4870 (Finternal_make_lisp_face, cache_face):
4871 Check for size calculation overflow.
4872 (cache_face): Treat size calculation overflows as if they were
4873 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4874
4875 * xfns.c (x_encode_text, x_set_name_internal)
4876 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4877 sizes, since they can exceed INT_MAX in size. Check for size
4878 calculation overflow.
4879
0065d054
PE
4880 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4881 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4882 Don't update size until alloc done.
4883
0065d054 4884 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4885 as sprintf is limited to int lengths.
1d526e2f 4886
252c5ee1
PE
4887 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4888 (X_LONG_MIN): New macros.
864d7ce7
PE
4889 Use them to make the following changes clearer.
4890 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4891 This change doesn't affect the value now, but it may help remind
4892 future maintainers not to raise the value too much later.
4893 (SELECTION_QUANTUM): Remove, replacing with ...
4894 (selection_quantum): ... new function, which avoids overflow.
4895 All uses changed.
4896 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4897 assumption that selection length fits in 'int'.
4898 (x_reply_selection_request, x_handle_selection_request)
4899 (x_get_window_property, receive_incremental_selection)
4900 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4901 (lisp_data_to_selection_data, clean_local_selection_data):
4902 Use ptrdiff_t, not int, to record length of selection.
4903 (x_reply_selection_request, x_get_window_property)
4904 (receive_incremental_selection, x_property_data_to_lisp):
4905 Redo calculations to avoid overflow.
4906 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4907 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4908 something.
4909 (x_get_window_property, receive_incremental_selection)
4910 (lisp_data_to_selection_data, x_property_data_to_lisp):
4911 Check for size-calculation overflow.
4912 (x_get_window_property, receive_incremental_selection)
4913 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4914 Don't store size until memory allocation succeeds.
4915 (x_get_window_property): Plug memory leak on memory exhaustion.
4916 Don't double-block input; malloc is safe here. Don't assume 2**34
4917 - 4 fits in unsigned long. Add an xassert to check
4918 XGetWindowProperty overflow. Be more careful about overflow
4919 calculations, and distinguish size from memory overflow better.
4920 (receive_incremental_selection): When tracing, don't assume
4921 unsigned int is less than INT_MAX.
4922 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4923 harmful) conversions of unsigned short to int.
4924 (lisp_data_to_selection_data): Don't assume that integers
4925 in the range -65535 through -1 fit in an X unsigned short.
4926 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4927 result parameters unless successful. Rely on cons_to_unsigned
4928 to report problems with elements; the old code wasn't right anyway.
4929 (x_check_property_data): Check for int overflow; we cannot use
4930 a wider type due to X limits.
4931 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4932
726e0ab1 4933 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4934
0065d054
PE
4935 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4936 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4937 (x_color_cells): Don't store size until memory allocation succeeds.
4938 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4939 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4940 (x_term_init): Don't assume length fits in int (sprintf is limited
4941 to int size).
bc18e09d 4942
ebfa62c0
PE
4943 Use ptrdiff_t for composition IDs.
4944 * character.c (lisp_string_width):
4945 * composite.c (composition_table_size, n_compositions)
4946 (get_composition_id, composition_gstring_from_id):
4947 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4948 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4949 * window.c (Frecenter):
4950 Use ptrdiff_t, not int, for composition IDs.
4951 * composite.c (get_composition_id): Check for integer overflow.
4952 * composite.h: Adjust prototypes to match the above changes.
4953
d3411f89
PE
4954 Use ptrdiff_t for hash table indexes.
4955 * category.c (hash_get_category_set):
4956 * ccl.c (ccl_driver):
4957 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4958 * coding.c (coding_system_charset_list, detect_coding_system):
4959 * coding.h (struct coding_system.id):
4960 * composite.c (get_composition_id, gstring_lookup_cache):
4961 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4962 * image.c (xpm_get_color_table_h):
4963 * lisp.h (hash_lookup, hash_put):
4964 * minibuf.c (Ftest_completion):
4965 Use ptrdiff_t for hash table indexes, not int (which is too
4966 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4967 32-bit --with-wide-int hosts).
4968
e097a6fa
PE
4969 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4970 Add a FIXME comment about memory leaks.
4971 (syms_of_charset): Don't assume xmalloc returns.
4972
5637687f
PE
4973 Don't assume that stated character widths fit in int.
4974 * character.c (Fchar_width, c_string_width, lisp_string_width):
4975 * character.h (CHAR_WIDTH):
4976 * indent.c (MULTIBYTE_BYTES_WIDTH):
4977 Use sanitize_char_width to avoid undefined and/or bad behavior
4978 with outlandish widths.
a66cfb1c 4979 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4980 now that we have two such functions. All uses changed.
4981 (sanitize_char_width): New inline function.
4982
a2271ba2
PE
4983 Don't assume that tab-width fits in int.
4984 * character.h (sanitize_width): New inline function.
4985 (SANE_TAB_WIDTH): New macro.
4986 (ASCII_CHAR_WIDTH): Use it.
4987 * indent.c (sane_tab_width): Remove. All uses replaced by
4988 SANE_TAB_WIDTH (current_buffer).
4989 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4990
18c52557
PE
4991 * fileio.c: Integer overflow issues with file modes.
4992 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4993
caeeedc1
PE
4994 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4995 Remove unreachable code.
4996 (read_hex, load_charset_map_from_file): Check for integer overflow.
4997
6df6ae42 4998 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4999 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5000 (x_send_scroll_bar_event): Likewise. Check that the size does not
5001 exceed limits imposed by XClientMessageEvent, as well as the usual
5002 ptrdiff_t and size_t limits.
5003
b13995db
PE
5004 * keyboard.c: Overflow, signedness and related fixes.
5005 (make_lispy_movement): Use same integer type in forward decl
5006 that is used in the definition.
5007 (read_key_sequence, keyremap_step):
5008 Change bufsize argument back to int, undoing my 2011-03-30 change.
5009 We prefer signed types, and int is wide enough here.
5010 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5011 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5012 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5013 length, not size_t. Use ptrdiff_t for index, not int.
5014 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5015 possibility of integer overflow.
5016
13464394
PE
5017 Overflow, signedness and related fixes for images.
5018
5019 * dispextern.h (struct it.stack[0].u.image.image_id)
5020 (struct_it.image_id, struct image.id, struct image_cache.size)
5021 (struct image_cache.used, struct image_cache.ref_count):
5022 * gtkutil.c (update_frame_tool_bar):
5023 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5024 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5025 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5026 * nsmenu.m (update_frame_tool_bar):
5027 * xdisp.c (calc_pixel_width_or_height):
5028 * xfns.c (image_cache_refcount):
5029 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5030 on typical 64-bit hosts.
5031
5032 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5033 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5034 Omit unnecessary casts to int.
5035 (parse_image_spec): Check that integers fall into 'int' range
5036 when the callers expect that.
5037 (image_ascent): Redo ascent calculation to avoid int overflow.
5038 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5039 (lookup_image): Remove unnecessary tests.
5040 (xbm_image_p): Locals are now of int, not EMACS_INT,
5041 since parse_image_check makes sure they fit into int.
5042 (png_load, gif_load, svg_load_image):
5043 Prefer int to unsigned where either will do.
5044 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5045 old tiff_error_handler and tiff_warning_handler.
5046 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5047 stack buffer overflows. It uses only the features of vsnprintf
5048 that are common to both POSIX and native Microsoft.
5049 (tiff_error_handler, tiff_warning_handler): Use it.
5050 (tiff_load, gif_load, imagemagick_load_image):
5051 Don't assume :index value fits in 'int'.
5052 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5053 (imagemagick_load_image): Check that crop parameters fit into
5054 the integer types that MagickCropImage accepts. Don't assume
5055 Vimagemagick_render_type has a nonnegative value. Don't assume
5056 size_t fits in 'long'.
5057 (gs_load): Use printmax_t to print the widest integers possible.
5058 Check for integer overflow when computing image height and width.
5059
c11821d4
EZ
50602011-08-26 Eli Zaretskii <eliz@gnu.org>
5061
5062 * xdisp.c (redisplay_window): Don't force window start if point
5063 will be invisible in the resulting window. (Bug#9324)
5064
0c95fcf7
EZ
50652011-08-25 Eli Zaretskii <eliz@gnu.org>
5066
5067 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5068 the display spec is of the form `(space ...)'.
5069 (handle_display_spec): Return the value returned by
5070 handle_single_display_spec, not just 1 or zero.
5071 (handle_single_display_spec): If the display spec is of the form
5072 `(space ...)', and specifies display in the text area, return 2
5073 rather than 1.
fee65a97 5074 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5075 accurately, and prefer exact match for point under bidi.
5076 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5077
5078 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5079 into disp_prop; all users changed.
5080
5081 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5082 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5083 for the text covered by the display property.
5084
e4ed06f1
CY
50852011-08-25 Chong Yidong <cyd@stupidchicken.com>
5086
5087 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5088 Change return value to nil.
5089 (Frecord_buffer): Delete unused function.
5090
f67cdd7f
EZ
50912011-08-24 Eli Zaretskii <eliz@gnu.org>
5092
5980d4c6
EZ
5093 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5094 buffers, return left-to-right.
8610fe8b
EZ
5095 (set_cursor_from_row): Consider candidate row a win if its glyph
5096 represents a newline and point is on that newline. Fixes cursor
5097 positioning on the newline at EOL of R2L text within L2R
5098 paragraph, and vice versa.
5099 (try_cursor_movement): Check continued rows, in addition to
5100 continuation rows. Fixes unwarranted scroll when point enters a
5101 continued line of R2L text within an L2R paragraph, or vice versa.
5102 (cursor_row_p): Consider the case of point being equal to
5103 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5104 from the end of a short line to the beginning of a continued line
5105 of R2L text within L2R paragraph.
5106 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5107 composed characters.
5980d4c6 5108
f67cdd7f
EZ
5109 * bidi.c (bidi_check_type): Use xassert.
5110 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5111 members.
5112
bca633fb
EZ
51132011-08-23 Eli Zaretskii <eliz@gnu.org>
5114
5115 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5116 a character.
5117
4a5885a7
CY
51182011-08-23 Chong Yidong <cyd@stupidchicken.com>
5119
5120 * nsfont.m (ns_otf_to_script): Fix typo.
5121
0902a04e
KH
51222011-08-22 Kenichi Handa <handa@m17n.org>
5123
5124 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5125 extra slot even if the purpose is char-code-property-table.
5126
1a2e6670
EZ
51272011-08-23 Eli Zaretskii <eliz@gnu.org>
5128
8ddde651
EZ
5129 * xdisp.c (redisplay_window): When computing centering_position,
5130 account for the height of the header line. (Bug#8874)
5131
425cc014
EZ
5132 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5133 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5134 candidate is selected by the mouse, and that candidate has a
5135 composed character under the mouse.
5136
1a2e6670
EZ
5137 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5138 coordinates reported by pos-visible-in-window-p for a composed
5139 character in column zero.
5140
8b76d6f8
SM
51412011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5142
5143 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5144
dac347dd
EZ
51452011-08-22 Eli Zaretskii <eliz@gnu.org>
5146
5147 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5148 consider it a hit if to_charpos is anywhere in the range of the
5149 composed buffer positions.
5150
e013fb34
CY
51512011-08-22 Chong Yidong <cyd@stupidchicken.com>
5152
5153 * image.c (gif_load): Don't assume that each subimage has the same
5154 dimensions as the base image. Handle disposal method that is
5155 "undefined" by the gif spec (Bug#9335).
5156
bd1ba3e8
CY
51572011-08-20 Chong Yidong <cyd@stupidchicken.com>
5158
5159 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5160 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5161
54a1215b
EZ
51622011-08-19 Eli Zaretskii <eliz@gnu.org>
5163
823564e5
EZ
5164 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5165 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5166 from an Org mode buffer to a Speedbar frame.
5167
54a1215b
EZ
5168 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5169 a composition, take its buffer position from IT->cmp_it.charpos.
5170 Fixes cursor positioning at the beginning of a line that begins
5171 with a composed character.
5172
9778ebcc
EZ
51732011-08-18 Eli Zaretskii <eliz@gnu.org>
5174
0be6ee06
EZ
5175 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5176 character bidirectional type, use STRONG_L instead. Fixes crashes
5177 in a buffer produced by `describe-categories'.
5178
9778ebcc
EZ
5179 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5180 members before the level stack, so they would be saved and
5181 restored when copying iterator state. Fixes incorrect reordering
5182 around TABs covered by display properties.
5183
156bffbe
AS
51842011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5185
6b02f655 5186 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5187
72ad093b
CY
51882011-08-17 Chong Yidong <cyd@stupidchicken.com>
5189
5190 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5191 (internal_condition_case_2, internal_condition_case_n):
5192 Remove unnecessary aborts (Bug#9081).
72ad093b 5193
35774242
EZ
51942011-08-17 Eli Zaretskii <eliz@gnu.org>
5195
5196 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5197 has no `load' handler, try opening the file locally. (Bug#9311)
5198
db76dd85
KB
51992011-08-16 Ken Brown <kbrown@cornell.edu>
5200
5201 * gmalloc.c: Expand comment.
5202
b215eee5
EZ
52032011-08-16 Eli Zaretskii <eliz@gnu.org>
5204
5205 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5206 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5207
a4579d33
KB
52082011-08-16 Ken Brown <kbrown@cornell.edu>
5209
5210 Fix memory allocation problems in Cygwin build (Bug#9273).
5211
5212 * unexcw.c ( __malloc_initialized): Declare external variable.
5213 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5214
8b76d6f8
SM
5215 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5216 New variables.
a4579d33
KB
5217 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5218 dumped emacs.
5219 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5220 in the static heap.
5221 [CYGWIN] (special_realloc): New function.
5222 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5223 requests to realloc storage in the static heap.
5224
3ebec551
PE
52252011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5226
5227 * bidi.c (bidi_initialize): Remove unused local.
5228
9fd8be00
EZ
52292011-08-15 Eli Zaretskii <eliz@gnu.org>
5230
6b02f655
SM
5231 * bidimirror.h:
5232 * biditype.h: Remove file.
5233 * makefile.w32-in ($(BLD)/bidi.$(O)):
5234 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5235
5236 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5237
5238 * chartab.c: Improve commentary for the uniprop_table API.
5239
32413314
EZ
5240 * bidi.c (bidi_paragraph_init): Support zero value of
5241 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5242 (bidi_initialize): Use uniprop_table instead of including
5243 biditype.h and bidimirror.h.
32413314 5244
9fd8be00
EZ
5245 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5246 coordinates of the iterator when restoring from ppos_it.
5247 (Bug#9296)
5248
5cf2b69b
KH
52492011-08-14 Kenichi Handa <handa@m17n.org>
5250
5251 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5252 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5253
daf17d00
EZ
52542011-08-14 Eli Zaretskii <eliz@gnu.org>
5255
5256 * xdisp.c (move_it_in_display_line_to): Don't invoke
5257 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5258 ppos_it. Fixes vertical cursor motion when line beginning is
5259 covered by an image. (Bug#9296)
5260
08e3161a
JD
52612011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5262
5263 * nsterm.h (ns_run_ascript): Declare.
5264 (NSAPP_DATA2_RUNASSCRIPT): Define.
5265
5266 * nsfns.m (as_script, as_result, as_status): New static variables.
5267 (ns_run_ascript): New function.
5e617bc2 5268 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5269 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5270 the event loop. Get status from as_status (Bug#7276).
5271
5272 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5273 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5274 the event loop (Bug#7276).
5275
a3720aa2
AS
52762011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5277
5278 * gnutls.c (QCgnutls_bootprop_priority)
5279 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5280 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5281 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5282 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5283 (QCgnutls_bootprop_verify_hostname_error)
5284 (QCgnutls_bootprop_callbacks_verify): Rename from
5285 Qgnutls_bootprop_..., all uses changed.
5286
5287 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5288 uses changed.
5289
0a0d27fb
PE
52902011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5291
19d5c50c
PE
5292 * xfaces.c (Qframe_set_background_mode): Now static.
5293 * dispextern.h (Qframe_set_background_mode): Remove decl.
5294
0a0d27fb
PE
5295 * process.c (Fnetwork_interface_info): Declare local only if needed.
5296
377538cb
JD
52972011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5298
5299 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5300 (Fnetwork_interface_list): Allocate in increments of bytes instead
5301 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5302 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5303 sockaddr.
5304 (struct ifflag_def): notrailers is smart on OSX.
5305 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5306 Get hardware address with getifaddrs if available.
5307
08fff70c
EZ
53082011-08-12 Eli Zaretskii <eliz@gnu.org>
5309
5310 * xdisp.c (iterate_out_of_display_property): xassert that
5311 IT->position is set to within IT->object's boundaries. Break from
5312 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5313 when IT->position is set up wrongly due to some bug.
5314 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5315 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5316 entry. Force push_it to save on the stack the current
5317 buffer/string position, to be restored by pop_it. Fix flags in
5318 the iterator structure wrt the object coming from a display
5319 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5320 properties. (Bug#9284)
5321
7be1c708 53222011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5323
7be1c708
CY
5324 * fontset.c (fontset_get_font_group): Add proper type checks.
5325 (Bug#9172)
aac0c6e3 5326
7be1c708 53272011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5328
7be1c708
CY
5329 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5330 and LC_VERSION_MIN_MACOSX.
5331 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5332 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5333
97bb72a6
EZ
53342011-08-08 Eli Zaretskii <eliz@gnu.org>
5335
5336 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5337 no-display-properties-and-no-overlays under bidi display.
5338 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5339 properties and overlays.
97bb72a6 5340
d5617611
CY
53412011-08-08 Chong Yidong <cyd@stupidchicken.com>
5342
37e11a63
CY
5343 * editfns.c (Fset_time_zone_rule): Document relationship with the
5344 setenv function.
5345
d5617611
CY
5346 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5347 the font entity extracted from the cache (Bug#8109).
5348
58872834
CY
53492011-08-07 Chong Yidong <cyd@stupidchicken.com>
5350
5351 * composite.c (autocmp_chars): Don't reset point. That is done by
5352 restore_point_unwind (Bug#5984).
5353
75bfc667
JL
53542011-08-07 Juri Linkov <juri@jurta.org>
5355
5356 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5357 to show the arg `TIME' instead of `TIMEVAL'.
5358
d1410150
EZ
53592011-08-06 Eli Zaretskii <eliz@gnu.org>
5360
5361 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5362 display property strides EOL and includes a newline, as in
5363 longlines-mode. (Bug#9254)
75b771e4
EZ
5364 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5365 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5366
5367 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5368 is non-zero, even if the data buffer is NULL. Fixes a crash in
5369 vertical-motion with longlines-mode. (Bug#9254)
5370
35928349
EZ
53712011-08-05 Eli Zaretskii <eliz@gnu.org>
5372
ec7cc85b
EZ
5373 * bidi.c <bidi_cache_total_alloc>: Now static.
5374 (bidi_initialize): Initialize bidi_cache_total_alloc.
5375
8b76d6f8 5376 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5377 cache. (Bug#9221)
5378
5379 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5380 amount allocated this far in `bidi_cache_total_alloc'.
5381 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5382 non-zero, only free the data buffer without restoring the cache
5383 contents. All callers changed.
5384
5385 * dispextern.h (bidi_unshelve_cache): Update prototype.
5386
5387 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5388 (move_it_in_display_line, move_it_to)
5389 (move_it_vertically_backward, move_it_by_lines): Replace the call
5390 to xfree to an equivalent call to bidi_unshelve_cache.
5391 (move_it_in_display_line_to): Fix logic of returning
412b6358 5392 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5393
e2e2423b
EZ
53942011-08-05 Eli Zaretskii <eliz@gnu.org>
5395
5396 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5397 came from a string character with a `cursor' property. (Bug#9229)
5398
ae9e757a
JD
53992011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5400
5401 * Makefile.in (LIB_PTHREAD): New variable.
5402 (LIBES): Add LIB_PTHREAD (Bug#9216).
5403
5404 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5405 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5406
213bd7f2
AS
54072011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5408
6b02f655 5409 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5410
99aaf75f
JD
54112011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5412
5413 * xterm.c (x_find_topmost_parent): New function.
5414 (x_set_frame_alpha): Find topmost parent window with
5415 x_find_topmost_parent and set the property there also (bug#9181).
5416 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5417
c74e9d86
PE
54182011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5419
5420 * callproc.c (Fcall_process): Avoid vfork clobbering
5421 the local vars buffer, coding_systems, current_dir.
5422
640c8776
SM
54232011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5424
5425 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5426
f26d0e4c
PE
54272011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5428
8a10d76c
PE
5429 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5430 so that it is not optimized away.
5431
f26d0e4c
PE
5432 * xdisp.c (compute_display_string_pos): Remove unused local.
5433
55439c61
EZ
54342011-08-02 Eli Zaretskii <eliz@gnu.org>
5435
5436 Fix slow cursor motion and scrolling in large buffers with
5437 selective display, like Org Mode buffers. (Bug#9218)
5438
5439 * dispextern.h (struct bidi_it): New member disp_prop_p.
5440
5441 * xdisp.c: Remove one-slot cache of display string positions.
5442 (compute_display_string_pos): Accept an additional argument
5e617bc2 5443 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5444 for a display string or property. If found, set DISP_PROP_P
5445 non-zero.
5446
5447 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5448 DISP_PROP_P, and pass it to compute_display_string_pos.
5449 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5450 non-zero. All callers of bidi_fetch_char changed.
5451
fb33fa43
SM
54522011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5453
5454 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5455
b099e063
DM
54562010-12-03 Don March <don@ohspite.net>
5457
5458 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5459 last character M-[char] is translated to ESC [char] (bug#7541).
5460
5cc7f7af
KH
54612011-08-02 Kenichi Handa <handa@m17n.org>
5462
d0fffa3f 5463 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5464
5465 * chartab.c (uniprop_table): Make it non-static.
5466
525d5e6e
EZ
54672011-08-01 Eli Zaretskii <eliz@gnu.org>
5468
5469 * xdisp.c (forward_to_next_line_start): Accept additional argument
5470 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5471 on the newline.
5472 (reseat_at_next_visible_line_start): Use the bidi iterator state
5473 returned by forward_to_next_line_start to restore the state of
5474 it->bidi_it after backing up to previous newline. (Bug#9212)
5475
31011111
AS
54762011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5477
5478 * regex.c (re_comp): Protoize.
5479 (re_exec): Fix return type.
5480 (regexec): Fix type of `ret'. (Bug#9203)
5481
476371c4
PE
54822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5483
e5d76069
PE
5484 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5485 This is needed if max-image-size is a floating-point number.
5486
9a79b20c
AS
54872011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5488
5489 * print.c (print_object): Print empty symbol as ##.
5490
5491 * lread.c (read1): Read ## as empty symbol.
5492
d8c2fa78
AA
54932011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5494
5495 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5496 setting frame foreground color (Bug#9175).
5497 (x_set_background_color): Likewise.
5498
ffe57a7a
AA
5499 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5500 contents (Bug#9176).
5501 (EmacsTooltip -init): Remove bezels and add shadows to
5502 tooltip windows.
5503
bf3492a5
AA
5504 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5505 or scroll bar (Bug#8470).
5506
d55e9c53
AA
5507 * nsfont.m (nsfont_open): Remove assignment to voffset and
5508 unnecessary vars hshink, expand, hd, full_height, min_height.
5509 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5510
5511 * nsterm.h (nsfont_info): Remove voffset field.
5512
d8c2fa78 55132011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5514
5515 Implement strike-through and overline on NextStep (Bug#8863).
5516
5517 * nsfont.m (nsfont_open): Use underline position provided by font,
5518 instead of hard-coded value of 2.
5519 (nsfont_draw): Call ns_draw_text_decoration instead.
5520
5521 * nsterm.h: Add declaration for ns_draw_text_decoration.
5522
5523 * nsterm.m (ns_draw_text_decoration): New function for drawing
5524 underline, overline, and strike-through.
5525 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5526 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5527 accommodate underlining, etc.
4843aac3 5528
4cc60b9b
EZ
55292011-07-28 Eli Zaretskii <eliz@gnu.org>
5530
bc7ece87
EZ
5531 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5532 default.
4cc60b9b 5533
476371c4
PE
55342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5535
66606eea
PE
5536 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5537 Without this fix, if a signal arrives just after memory fills up,
5538 'malloc' might be invoked reentrantly.
5539
476371c4
PE
5540 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5541 In other words, assume that every image size is allowed, on non-X
5542 hosts. This assumption is probably wrong, but it lets Emacs compile.
5543
f3fcc40d
AS
55442011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5545
5546 * regex.c (re_iswctype): Convert return values to boolean.
5547
350c992f
EZ
55482011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5549
5550 * xdisp.c (compute_display_string_pos): Don't use cached display
5551 string position if the buffer had its restriction changed.
5552 (Bug#9184)
5553
5266b4bb
PE
55542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5555
5556 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5557
2573a837 55582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5559
41f55ccd 5560 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5561
39e378da
PE
5562 * bidi.c: Integer size and overflow fixes.
5563 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5564 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5565 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5566 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5567 (bidi_find_other_level_edge):
5568 Use ptrdiff_t instead of EMACS_INT where either will do.
5569 This works better on 32-bit hosts configured --with-wide-int.
5570 (bidi_cache_ensure_space): Check for size-calculation overflow.
5571 Use % rather than repeated addition, for better worst-case speed.
5572 Don't set bidi_cache_size until after xrealloc returns, because it
5573 might not return.
5574 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5575 (bidi_cache_ensure_space): Also check that the bidi cache size
5576 does not exceed that of the largest Lisp string or buffer. See Eli
5577 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5578
5e927815
PE
5579 * alloc.c (__malloc_size_t): Remove.
5580 All uses replaced by size_t. See Andreas Schwab's note
5581 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5582
ca4aa935
PE
5583 * image.c: Improve checking for integer overflow.
5584 (check_image_size): Assume that f is nonnull, since
5585 it is always nonnull in practice. This is one less thing to
5586 worry about when checking for integer overflow later.
5587 (x_check_image_size): New function, which checks for integer
5588 overflow issues inside X.
5589 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5590 This removes the need for a memory_full check.
5591 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5592 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5593 (xbm_read_bitmap_data): Change locals back to 'int', since
5594 their values must fit in 'int'.
5595 (xpm_load_image, png_load, tiff_load):
5596 Invoke x_create_x_image_and_pixmap earlier,
5597 to avoid much needless work if the image is too large.
5598 (tiff_load): Treat overly large images as if
5599 x_create_x_image_and_pixmap failed, not as malloc failures.
5600 (gs_load): Use x_check_image_size.
5601
5f8f9cc2
PE
5602 * gtkutil.c: Omit integer casts.
5603 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5604 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5605
5adf60bc
PE
5606 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5607
c8907a93
PE
5608 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5609 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5610 would wrongly return t on a 64-bit host.
5611
e3c25c68
PE
5612 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5613 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5614 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5615 and therefore cause GCC to emit a bogus diagnostic in some cases.
5616
3f791afe
PE
5617 * image.c: Integer signedness and overflow and related fixes.
5618 This is not an exhaustive set of fixes, but it's time to
5619 record what I've got.
5620 (lookup_pixel_color, check_image_size): Remove redundant decls.
5621 (check_image_size): Don't assume that arbitrary EMACS_INT values
5622 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5623 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5624 (tiff_load, imagemagick_load_image):
5625 Check for overflow in size calculations.
5626 (x_create_x_image_and_pixmap): Remove unnecessary test for
5627 xmalloc returning NULL; that can't happen.
5628 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5629 (xpm_color_bucket): Use better integer hashing function.
5630 (xpm_cache_color): Don't possibly over-allocate memory.
5631 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5632 (gif_memory_source):
5633 Use ptrdiff_t, not int or size_t, to record sizes.
5634 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5635 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5636 either works, as we prefer signed integers.
5637 (tiff_read_from_memory, tiff_write_from_memory):
5638 Return tsize_t, not size_t, since that's what the TIFF API wants.
5639 (tiff_read_from_memory): Don't fail simply because the read would
5640 go past EOF; instead, return a short read.
5641 (tiff_load): Omit no-longer-needed casts.
5642 (Fimagemagick_types): Don't assume size fits into 'int'.
5643
3cc5a532
PE
5644 Improve hashing quality when configured --with-wide-int.
5645 * fns.c (hash_string): New function, taken from sxhash_string.
5646 Do not discard information about ASCII character case; this
5647 discarding is no longer needed.
5648 (sxhash-string): Use it. Change sig to match it. Caller changed.
5649 * lisp.h: Declare it.
5650 * lread.c (hash_string): Remove, since we now use fns.c's version.
5651 The fns.c version returns a wider integer if --with-wide-int is
5652 specified, so this should help the quality of the hashing a bit.
5653
b312a492
PE
5654 * emacs.c: Integer overflow minor fix.
5655 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5656 Define only if GNU_LINUX.
5657 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5658
dfd153ae
PE
5659 * dispnew.c: Integer signedness and overflow fixes.
5660 Remove unnecessary forward decls, that were a maintenance hassle.
5661 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5662 All uses changed.
5663 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5664 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5665 (prepare_desired_row, line_draw_cost):
5666 Use int, not unsigned, where either works.
5667 (save_current_matrix, restore_current_matrix):
5668 Use ptrdiff_t, not size_t, where either works.
5669 (init_display): Check for overflow more accurately, and without
5670 relying on undefined behavior.
5671
a81d11a3
PE
5672 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5673 Remove, replacing with the new symbols in lisp.h. All uses changed.
5674 * fileio.c (make_temp_name):
5675 * filelock.c (lock_file_1, lock_file):
5676 * xdisp.c (message_dolog):
5677 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5678 Use pMd etc. instead.
5679 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5680 replacing the pWIDE etc. symbols removed from editfns.c.
5681
3300e6fd
PE
5682 * keyboard.h (num_input_events): Now uintmax_t.
5683 This is (very slightly) less likely to mess up due to wraparound.
5684 All uses changed.
5685
fd05c7e9
PE
5686 * buffer.c: Integer signedness fixes.
5687 (alloc_buffer_text, enlarge_buffer_text):
5688 Use ptrdiff_t rather than size_t when either will do, as we prefer
5689 signed integers.
5690
903fe15d
PE
5691 * alloc.c: Integer signedness and overflow fixes.
5692 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5693 (__malloc_size_t): Default to size_t, not to int.
5694 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5695 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5696 Prefer ptrdiff_t to size_t when either would do, as we prefer
5697 signed integers.
5698 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5699 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5700 Now const. Initialize with values that are in range even if char
5701 is signed.
5702 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5703 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5704 These functions do the right thing with sizes > 2**32.
5705 (check_depth): Now ptrdiff_t, not int.
5706 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5707 Adjust to new way of storing sizes. Check for size overflow bugs
5708 in rest of code.
5709 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5710 slightly wrong anyway, as it missed one instance of
5711 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5712 (refill_memory_reserve): Omit needless cast to size_t.
5713 (mark_object_loop_halt): Mark as externally visible.
5714
ac82cc6a
PE
5715 * xselect.c: Integer signedness and overflow fixes.
5716 (Fx_register_dnd_atom, x_handle_dnd_message):
5717 Use ptrdiff_t, not size_t, since we prefer signed.
5718 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5719 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5720 x_dnd_atoms_size and x_dnd_atoms_length.
5721
c2d1e36d
PE
5722 * doprnt.c: Prefer signed to unsigned when either works.
5723 * eval.c (verror):
5724 * doprnt.c (doprnt):
5725 * lisp.h (doprnt):
5726 * xdisp.c (vmessage):
5727 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5728 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5729 prefer signed arithmetic to avoid comparison confusion.
5730 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5731 but is a bit tricky.
5732
0e926e56
PE
5733 Assume freestanding C89 headers, string.h, stdlib.h.
5734 * data.c, doprnt.c, floatfns.c, print.c:
5735 Include float.h unconditionally.
5736 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5737 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5738 * regex.c: Likewise for stddef.h, string.h.
5739 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5740 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5741 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5742 (STDC_HEADERS): Remove obsolete defines.
5743 * sysdep.c: Include limits.h unconditionally.
5744
9cfdb3ec
PE
5745 Assume support for memcmp, memcpy, memmove, memset.
5746 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5747 * regex.c (memcmp, memcpy):
5748 Remove; we assume C89 now.
5749
5750 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5751 (__malloc_safe_bcopy): Remove; no longer needed.
5752
cf950e6b 5753 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5754 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5755 well either way, and we prefer signed to unsigned.
5756
dbf38e02
LMI
57572011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5758
5759 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5760 closes the connection while we're reading (bug#9182).
5761
d6f0886c 57622011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5763
d6f0886c
JD
5764 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5765 are specified (Bug#9168).
24e0f6b1 5766
2eb1f9e6
PE
57672011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5768
5769 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5770 Found by GCC static checking and --with-wide-int on a 32-bit host.
5771
22381272 57722011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5773
5774 * xdisp.c (compute_display_string_pos): Fix logic of caching
5775 previous display string position. Initialize cached_prev_pos to
5776 -1. Fixes slow-down at the beginning of a buffer.
5777
f25e39b4
EZ
57782011-07-24 Eli Zaretskii <eliz@gnu.org>
5779
5780 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5781 for attrs[LFACE_FONTSET_INDEX].
5782
04c4b52e
PE
57832011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5784
5785 * xml.c (parse_region): Remove unused local
5786 that was recently introduced.
5787
c1734fbd
EZ
57882011-07-23 Eli Zaretskii <eliz@gnu.org>
5789
be18c5a5
EZ
5790 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5791 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5792
c1734fbd
EZ
5793 * xdisp.c (move_it_in_display_line_to): Record the best matching
5794 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5795 exit if none of the characters scanned was an exact match.
5796 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5797 when exact match is impossible due to invisible text, and the
5798 lines are truncated.
5799
a258d627
JD
58002011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5801
5802 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5803 for OSX >= 10.7.
5804
b6d5a689
EZ
58052011-07-22 Eli Zaretskii <eliz@gnu.org>
5806
0f74f785
EZ
5807 Fix a significant slow-down of cursor motion with C-n, C-p,
5808 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5809 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5810 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5811 (next_element_from_buffer): Call compute_stop_pos_backwards to
5812 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5813 base_level_stop.
5814 (reseat): Don't look for prev_stop, as that could mean a very long
5815 run.
5816 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5817 <cached_disp_overlay_modiff>: Cache for last found display string
5818 position.
551918c1 5819 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5820 about the same buffer in the same area of character positions, and
5821 the buffer wasn't changed since the time the display string
5822 position was cached.
551918c1 5823
b2d0c91a
EZ
58242011-07-22 Eli Zaretskii <eliz@gnu.org>
5825
5826 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5827 is an integer, which is important for empty lines. (Bug#9149)
5828
043604ee
CY
58292011-07-22 Chong Yidong <cyd@stupidchicken.com>
5830
5831 * frame.c (Fmodify_frame_parameters): In tty case, update the
5832 default face if necessary (Bug#4238).
5833
da4adb04
CY
58342011-07-21 Chong Yidong <cyd@stupidchicken.com>
5835
5836 * editfns.c (Fstring_to_char): No need to explain what a character
5837 is in the docstring (Bug#6576).
5838
9abd0532
LMI
58392011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5840
5841 * xml.c (parse_region): Make sure we always return a tree.
5842
36881d16
HK
58432011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5844
5845 * xml.c (parse_region): If a document contains only comments,
5846 return that, too.
5847
1e98674d
LMI
58482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5849
5850 * xml.c (make_dom): Return comments, too.
5851
590bd467
PE
58522011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5853
5854 Port to OpenBSD.
5855 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5856 and the surrounding thread.
5857 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5858 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5859 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5860 timer goes off.
5861 * s/openbsd.h (BROKEN_SIGIO): Define.
5862 * unexelf.c (unexec) [__OpenBSD__]:
5863 Don't update the .mdebug section of the Alpha COFF symbol table.
5864
f41628b2
LMI
58652011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5866
5867 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5868 (bug#8460).
5869
b59b67c5
PE
58702011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5871
15e3a074
PE
5872 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5873 This fixes some race conditions on the permissions of any newly
5874 created file.
5875
41bed37d
PE
5876 * alloc.c (valid_pointer_p): Use pipe, not open.
5877 This fixes some permissions issues when debugging.
5878
b59b67c5
PE
5879 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5880 If fchown fails to set both uid and gid, try to set just gid,
5881 as that is sometimes allowed. Adjust the file's mode to eliminate
5882 setuid or setgid bits that are inappropriate if fchown fails.
5883
925a6be7
SM
58842011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5885
5886 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5887 to compare Lisp_Objects.
5888 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5889 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5890 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5891
52968808
AS
58922011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5893
0a6a104b
AS
5894 * lread.c (read_integer): Unread even EOF character.
5895 (read1): Likewise. Properly record start position of symbol.
5896
52968808
AS
5897 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5898 symbol character follows.
5899
9e381cdd
PE
59002011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5901
5902 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5903 This works around a problem with the previous change to Fcopy_file.
5904 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5905 and without this change, GCC might complain about discarding
5906 fchown's return value.
5907
b5641435
JB
59082011-07-16 Juanma Barranquero <lekktu@gmail.com>
5909
5910 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5911
a8031457
PE
59122011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5913
5914 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5915
dd889327
LMI
59162011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5917
750c33f7
LMI
5918 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5919 it's used from the C level.
5920
dd889327
LMI
5921 * process.c: Use the same condition for POLL_FOR_INPUT in both
5922 keyboard.c and process.c (bug#1858).
5923
87e86684
LM
59242011-07-09 Lawrence Mitchell <wence@gmx.li>
5925
5926 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5927 (Fgnutls_boot): Use it.
5928
64348f40
AS
59292011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5930
5931 * doc.c (Fsubstitute_command_keys): Revert last change.
5932
1d698799
LMI
59332011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5934
f863868c
LMI
5935 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5936 quotes the next character, and doesn't affect other longer
5937 sequences (bug#8935).
5938
1d698799
LMI
5939 * lread.c (syms_of_lread): Clarify that is isn't only
5940 `eval-buffer' and `eval-defun' that's affected by
5941 `lexical-binding' (bug#8460).
5942
aa4b6df6
EZ
59432011-07-15 Eli Zaretskii <eliz@gnu.org>
5944
5945 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5946 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5947
5d856da6
PE
59482011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5949
ad6042bb
PE
5950 Fix minor problems found by static checking.
5951 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5952 (elsz): Now a signed constant, not a size_t var. We prefer signed
5953 types to unsigned, to avoid integer comparison confusion. Without
5954 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5955 "cannot optimize loop, the loop counter may overflow", a symptom
5956 of the confusion.
f00bbb22 5957 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5958 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5959
6468f31c
LMI
59602011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5961
49080b10
LMI
5962 * search.c (Fre_search_backward): Mention `case-fold-search' in
5963 all the re_search_* functions (bug#8138).
5964
6468f31c
LMI
5965 * keyboard.c (Fopen_dribble_file): Document when the file is
5966 closed (bug#8056).
5967
c965adc5
EZ
59682011-07-14 Eli Zaretskii <eliz@gnu.org>
5969
df9733bf
EZ
5970 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5971 bidi_cache_idx.
5972
0bb23927
EZ
5973 Support bidi reordering of display and overlay strings.
5974 * xdisp.c (compute_display_string_pos)
5975 (compute_display_string_end): Accept additional argument STRING.
5976 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5977 (reseat_to_string): Initialize bidi_it->string.s and
5978 bidi_it->string.schars.
5979 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5980 NULL (avoids a crash in bidi_paragraph_init).
5981 Initialize itb.string.lstring.
0bb23927
EZ
5982 (init_iterator): Call bidi_init_it only of a valid
5983 buffer position was specified. Initialize paragraph_embedding to
5984 L2R.
5985 (reseat_to_string): Initialize the bidi iterator.
5986 (display_string): If we need to ignore text properties of
5987 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5988 original value of -1 will not work with bidi.)
5989 (compute_display_string_pos): First arg is now struct
5990 `text_pos *'; all callers changed. Support display properties on
5991 Lisp strings.
5992 (compute_display_string_end): Support display properties on Lisp
5993 strings.
5994 (init_iterator, reseat_1, reseat_to_string): Initialize the
5995 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5996 when iterating on a string not from display properties).
640c8776
SM
5997 (compute_display_string_pos, compute_display_string_end):
5998 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5999 arrow keys.
6000 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6001 base_level_stop; instead, set base_level_stop to BEGV.
6002 Fixes crashes in vertical-motion.
0bb23927
EZ
6003 (next_element_from_buffer): Improve commentary for when
6004 the iterator is before prev_stop.
6005 (init_iterator): Initialize bidi_p from the default value of
6006 bidi-display-reordering, not from buffer-local value. Use the
6007 buffer-local value only if initializing for buffer iteration.
6008 (handle_invisible_prop): Support invisible properties on strings
6009 that are being bidi-reordered.
6010 (set_iterator_to_next): Support bidi reordering of C strings and
6011 Lisp strings.
6012 (next_element_from_string): Support bidi reordering of Lisp
6013 strings.
6014 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6015 (display_string): Support display of R2L glyph rows.
6016 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6017 (init_iterator): Don't initialize it->bidi_p for strings
6018 here.
6019 (reseat_to_string): Initialize it->bidi_p for strings here.
6020 (next_element_from_string, next_element_from_c_string)
6021 (next_element_from_buffer): Add xassert's for correspondence
6022 between IT's object being iterated and it->bidi_it.string
6023 structure.
6024 (face_before_or_after_it_pos): Support bidi iteration.
6025 (next_element_from_c_string): Handle the case of the first string
6026 character that is not the first one in the visual order.
6027 (get_visually_first_element): New function, refactored from common
6028 parts of next_element_from_buffer, next_element_from_string, and
6029 next_element_from_c_string.
6030 (tool_bar_lines_needed, redisplay_tool_bar)
6031 (display_menu_bar): Force left-to-right direction. Add a FIXME
6032 comment for making that be controlled by a user option.
6033 (push_it, pop_it): Save and restore the state of the
6034 bidi iterator. Save and restore the bidi_p flag.
6035 (pop_it): Iterate out of display property for string iteration as
6036 well.
6037 (iterate_out_of_display_property): Support iteration over strings.
6038 (handle_single_display_spec): Set up it->bidi_it for iteration
6039 over a display string, and call bidi_init_it.
6040 (handle_single_display_spec, next_overlay_string)
6041 (get_overlay_strings_1, push_display_prop): Set up the bidi
6042 iterator for displaying display or overlay strings.
6043 (forward_to_next_line_start): Don't use the shortcut if
6044 bidi-iterating.
6045 (back_to_previous_visible_line_start): If handle_display_prop
6046 pushed the iterator stack, restore the internal state of the bidi
6047 iterator by calling bidi_pop_it same number of times.
6048 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6049 and we are bidi-iterating, don't decrement the iterator position;
6050 instead, set the first_elt flag in the bidi iterator, to produce
6051 the same effect.
6052 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6053 (push_display_prop): xassert that we are iterating a buffer.
6054 (push_it, pop_it): Save and restore paragraph_embedding member.
6055 (handle_single_display_spec, next_overlay_string)
6056 (get_overlay_strings_1, reseat_1, reseat_to_string)
6057 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6058 correctly. Don't assume unibyte strings are not bidi-reordered.
6059 (compute_display_string_pos)
6060 (compute_display_string_end): Fix handling the case of C string.
6061 (push_it, pop_it): Save and restore from_disp_prop_p.
6062 (handle_single_display_spec, push_display_prop): Set the
6063 from_disp_prop_p flag.
6064 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6065 (pop_it): Call iterate_out_of_display_property only if we are
6066 popping after iteration over a string that came from a display
6067 property. Fix a typo in popping stretch info. Add an assertion
6068 for verifying that the iterator position is in sync with the bidi
6069 iterator.
6070 (handle_single_display_spec, get_overlay_strings_1)
6071 (push_display_prop): Fix initialization of paragraph direction for
6072 string when that of the parent object is not yet determined.
6073 (reseat_1): Call bidi_init_it to resync the bidi
6074 iterator with IT's position. (Bug#7616)
6075 (find_row_edges): If ROW->start.pos gives position
6076 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6077 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6078 Reset the from_disp_prop_p flag.
6079 (SAVE_IT, RESTORE_IT): New macros.
6080 (pos_visible_p, face_before_or_after_it_pos)
6081 (back_to_previous_visible_line_start)
6082 (move_it_in_display_line_to, move_it_in_display_line)
6083 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6084 (try_scrolling, redisplay_window, display_line): Use them when
6085 saving a temporary copy of the iterator and restoring it back.
6086 (back_to_previous_visible_line_start, reseat_1)
6087 (init_iterator): Empty the bidi cache "stack".
6088 (move_it_in_display_line_to): If iterator ended up at
6089 EOL, but we never saw any buffer positions smaller than
6090 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6091 motion in bidi-reordered lines.
6092 (move_it_in_display_line_to): Record prev_method and prev_pos
6093 immediately before the call to set_iterator_to_next. Fixes cursor
6094 motion in bidi-reordered lines with stretch glyphs and strings
6095 displayed in margins. (Bug#8133) (Bug#8867)
6096 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6097 TO_CHARPOS.
640c8776
SM
6098 (pos_visible_p): Support positions in bidi-reordered lines.
6099 Save and restore bidi cache.
0bb23927
EZ
6100
6101 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6102 (bidi_paragraph_info): Delete unused struct.
6103 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6104 (bidi_cache_start): New variable.
6105 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6106 to zero.
6107 (bidi_cache_fetch_state, bidi_cache_search)
6108 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6109 (bidi_cache_find, bidi_peek_at_next_level)
6110 (bidi_level_of_next_char, bidi_find_other_level_edge)
6111 (bidi_move_to_visually_next): Compare cache index with
6112 bidi_cache_start rather than with zero.
6113 (bidi_fetch_char): Accept new argument STRING; all callers
6114 changed. Support iteration over a string. Support strings with
6115 display properties. Support unibyte strings. Fix the type of
6116 `len' according to what STRING_CHAR_AND_LENGTH expects.
6117 (bidi_paragraph_init, bidi_resolve_explicit_1)
6118 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6119 (bidi_level_of_next_char, bidi_move_to_visually_next):
6120 Support iteration over a string.
0bb23927
EZ
6121 (bidi_set_sor_type, bidi_resolve_explicit_1)
6122 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6123 can now be zero (for strings); special values 0 and -1 were
6124 changed to -1 and -2, respectively.
6125 (bidi_char_at_pos): New function.
6126 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6127 Call it instead of FETCH_MULTIBYTE_CHAR.
6128 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6129 initialized to valid values.
6130 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6131 values.
6132 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6133 the test for valid cached positions. Fix the logic for looking up
6134 the sentinel state in the cache. GCPRO the Lisp string we are
6135 iterating.
6136 (bidi_push_it, bidi_pop_it): New functions.
6137 (bidi_initialize): Initialize the bidi cache start stack pointer.
6138 (bidi_cache_ensure_space): New function, refactored from part of
6139 bidi_cache_iterator_state. Don't assume the required size is just
6140 one BIDI_CACHE_CHUNK away.
6141 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6142 (bidi_count_bytes, bidi_char_at_pos): New functions.
6143 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6144 always valid if bidi_cache_idx is valid.
6145 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6146 is valid if it's going to be used.
6147 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6148 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6149 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6150 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6151 (bidi_find_other_level_edge, bidi_cache_start_stack):
6152 All variables related to cache indices are now EMACS_INT.
c965adc5 6153
0bb23927
EZ
6154 * dispextern.h (struct bidi_string_data): New structure.
6155 (struct bidi_it): New member `string'. Make flag members be 1-bit
6156 fields, and put them last in the struct.
640c8776
SM
6157 (compute_display_string_pos, compute_display_string_end):
6158 Update prototypes.
0bb23927
EZ
6159 (bidi_push_it, bidi_pop_it): Add prototypes.
6160 (struct iterator_stack_entry): New members bidi_p,
6161 paragraph_embedding, and from_disp_prop_p.
6162 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6163 (bidi_shelve_cache, bidi_unshelve_cache):
6164 Declare prototypes.
0bb23927
EZ
6165
6166 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6167 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6168 and vector-like objects.
6169
6170 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6171 cache around display iteration.
6172
6173 * window.c (Fwindow_end, window_scroll_pixel_based)
6174 (displayed_window_lines, Frecenter): Save and restore the bidi
6175 cache around display iteration.
6176
3bbd2265
LMI
61772011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6178
6179 * editfns.c (Fdelete_region): Clarify the use of the named
6180 parameters (bug#6788).
6181
adc47434
MR
61822011-07-14 Martin Rudalics <rudalics@gmx.at>
6183
6184 * indent.c (Fvertical_motion): Set and restore w->pointm when
6185 saving and restoring the window's buffer (Bug#9006).
6186
837c31f8
LMI
61872011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6188
6189 * editfns.c (Fstring_to_char): Clarify just what is returned
6190 (bug#6576). Text by Eli Zaretskii.
6191
ac389d0c
JB
61922011-07-13 Juanma Barranquero <lekktu@gmail.com>
6193
6194 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6195
0be0ce47
EZ
61962011-07-13 Eli Zaretskii <eliz@gnu.org>
6197
6198 * buffer.c (mmap_find): Fix a typo.
6199
cd18e7e3
JB
62002011-07-13 Johan Bockgård <bojohan@gnu.org>
6201
6202 Fix execution of x selection hooks.
6203 * xselect.c (Qx_lost_selection_functions)
6204 (Qx_sent_selection_functions): New vars.
6205 (syms_of_xselect): DEFSYM them.
6206 (x_handle_selection_request): Pass Qx_sent_selection_functions
6207 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6208 (x_handle_selection_clear,x_clear_frame_selections):
6209 Pass Qx_lost_selection_functions rather than
6210 Vx_lost_selection_functions to Frun_hook_with_args.
6211
47ea7f44
PE
62122011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6213
ac389d0c 6214 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6215 The old code sometimes used this field without initializing it.
6216
47ea7f44
PE
6217 * alloc.c (gc_sweep): Don't read past end of array.
6218 In theory, the old code could also have corrupted Emacs internals,
6219 though it'd be very unlikely.
6220
bc985c87
AS
62212011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6222
6223 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6224 argument. (Bug#4026)
bc985c87 6225
0cf34688
LMI
62262011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6227
b3dadd76
LMI
6228 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6229 key" (bug#4257).
6230
0cf34688
LMI
6231 * window.c (Fset_window_start): Doc fix (bug#4199).
6232 (Fset_window_hscroll): Ditto.
6233
270768cd
PE
62342011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6235
077e3dda 6236 Fix minor new problems caught by GCC 4.6.1.
270768cd 6237 * term.c (init_tty): Remove unused local.
490011a6 6238 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6239 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6240 not used otherwise.
270768cd 6241
b1f58454
CY
62422011-07-12 Chong Yidong <cyd@stupidchicken.com>
6243
6244 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6245
22b9578d
LMI
62462011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6247
6e70ab07
LMI
6248 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6249 are the mini-buffer and the echo area (bug#3320).
6250
22b9578d
LMI
6251 * term.c (init_tty): Remove support for supdup, c10 and perq
6252 terminals, which are no longer supported (bug#1482).
6253
8974cc9f
JB
62542011-07-10 Johan Bockgård <bojohan@gnu.org>
6255
6256 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6257
a560d974
JD
62582011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6259
6260 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6261 for non-popups (Bug#3642).
6262
1dae0f0a
AS
62632011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6264
268c2c36 6265 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6266 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6267 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6268 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6269 * data.c (fmod): Likewise.
6270 * dispnew.c (swap_glyphs_in_rows): Likewise.
6271 * emacs.c (memory_warning_signal): Likewise.
6272 * floatfns.c (float_error): Likewise.
6273 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6274 (otf_open, font_otf_capability, generate_otf_features)
6275 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6276 Likewise.
6277 * image.c (pbm_read_file): Likewise.
6278 * indent.c (string_display_width): Likewise.
6279 * intervals.c (check_for_interval, search_for_interval)
6280 (inc_interval_count, count_intervals, root_interval)
6281 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6282 * lread.c (defalias): Likewise.
268c2c36 6283 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6284 * regex.c (set_image_of_range_1, set_image_of_range)
6285 (regex_grow_registers): Likewise.
6286 * sysdep.c (strerror): Likewise.
6287 * termcap.c (valid_filename_p, tprint, main): Likewise.
6288 * tparam.c (main): Likewise.
6289 * unexhp9k800.c (run_time_remap, save_data_space)
6290 (update_file_ptrs, read_header, write_header, calculate_checksum)
6291 (copy_file, copy_rest, display_header): Likewise.
6292 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6293 Likewise.
6294 * xdisp.c (check_it): Likewise.
6295 * xfaces.c (register_color, unregister_color, unregister_colors):
6296 Likewise.
6297 * xfns.c (print_fontset_result): Likewise.
6298 * xrdb.c (member, fatal, main): Likewise.
6299
99033785
PE
63002011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6301
6302 Fix minor problems found by static checking (Bug#9031).
6303 * chartab.c (char_table_set_range, map_sub_char_table):
6304 Remove unused locals.
6305 (uniprop_table): Now static.
6306 * composite.c (_work_char): Remove unused static var.
6307
9cb2ac56
JB
63082011-07-09 Juanma Barranquero <lekktu@gmail.com>
6309
6310 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6311
f25661f0
JD
63122011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6313
6314 * gtkutil.c (qttip_cb): Remove code without function.
6315
8278c4fe
EZ
63162011-07-09 Eli Zaretskii <eliz@gnu.org>
6317
6318 * w32.c (pthread_sigmask): New stub.
6319
1692ae2d 63202011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6321
8a6ebd58 6322 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6323 sigprocmask is portable only for single-threaded applications, and
6324 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6325 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6326 (LIBES): Use it.
6327 * callproc.c (Fcall_process):
6328 * process.c (create_process):
6329 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6330 Use pthread_sigmask, not sigprocmask.
123403e4 6331
1b854618
JD
63322011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6333
6334 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6335 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6336 wrong (Bug#8591).
6337
3fe4b549
JD
63382011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6339
0ce7e563
JD
6340 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6341 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6342 (xg_hide_tooltip): Fix comment.
6343
3fe4b549
JD
6344 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6345 in registerServicesMenuSendTypes.
6346 (validRequestorForSendType): Don't check ns_return_types.
6347
6348 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6349 ns_return_type.
6350
5df75e47
JR
63512011-07-08 Jason Rumney <jasonr@gnu.org>
6352
22610910
JR
6353 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6354 SH_SHOW for hidden windows (Bug#5482).
6355
5df75e47
JR
6356 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6357 frame struct members of non-existent frames (Bug#6284).
6358
699c10bd
JD
63592011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6360
4393663b
JD
6361 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6362 variable firstTime not needed on OSX >= 10.6.
6363 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6364 >= 10.5. Use setKnobProportion, setDoubleValue.
6365
6366 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6367 (MAC_OS_X_VERSION_10_5): Define if not defined.
6368 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6369 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6370 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6371
6372 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6373 cString and lossyCString on OSX >= 10.4
6374
58179cce 6375 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6376 sizeToFit on OSX >= 10.2.
6377
6378 * nsimage.m (allocInitFromFile): Don't use deprecated method
6379 bestRepresentationForDevice on OSX >= 10.6.
6380
6381 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6382 to avoid warning.
6383
6384 * emacs.c: Declare unexec_init_emacs_zone.
6385
a63e0781
JD
6386 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6387
699c10bd
JD
6388 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6389
6390 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6391 on svcsMenu (Bug#8842).
6392
6393 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6394 ns_return_types.
6395 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6396
6397 * nsterm.m (QUTF8_STRING): Declare.
6398 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6399 (validRequestorForSendType): Return type is (id).
6400 Change indexOfObjectIdenticalTo to indexOfObject.
6401 Check if we have local selection before returning self (Bug#8842).
6402 (writeSelectionToPasteboard): Put local selection into paste board
6403 if we have a local selection (Bug#8842).
6404 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6405
6406 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6407 (ns_get_local_selection): Declare.
6408
54e10184
LMI
64092011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6410
9888ff71
LMI
6411 * keymap.c (describe_map_tree): Don't insert a double newline at
6412 the end of the buffer (bug#1169) and return whether we inserted
6413 something.
6414
54e10184
LMI
6415 * callint.c (Fcall_interactively): Change "reading args" to
6416 "providing args" to try to clarify what it does (bug#1010).
6417
15fa4783
KH
64182011-07-07 Kenichi Handa <handa@m17n.org>
6419
6420 * composite.c (composition_compute_stop_pos): Ignore a static
6421 composition starting before CHARPOS (Bug#8915).
6422
6423 * xdisp.c (handle_composition_prop): Likewise.
6424
a8815b00
EZ
64252011-07-07 Eli Zaretskii <eliz@gnu.org>
6426
6427 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6428 (Bug#9015)
6429
ef7b981d 64302011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6431
6432 * character.h (unicode_category_t): New enum type.
6433
6434 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6435 (Qchar_code_property_table): New variable.
6436 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6437 (UNIPROP_COMPRESSED_FORM_P): New macros.
6438 (char_table_ascii): Uncompress the compressed values.
6439 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6440 Uncompress the compressed values.
ac389d0c 6441 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6442 (char_table_ref_and_range): Uncompress the compressed values.
6443 (sub_char_table_set): New arg is_uniprop. Callers changed.
6444 Uncompress the compressed values.
6445 (sub_char_table_set_range): Args changed. Callers changed.
6446 (char_table_set_range): Adjuted for the above change.
6447 (map_sub_char_table): Delete args default_val and parent. Add arg
6448 top. Give decoded values to a Lisp function.
640c8776 6449 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6450 values to a Lisp function. Gcpro more variables.
6451 (uniprop_table_uncompress)
6452 (uniprop_decode_value_run_length): New functions.
6453 (uniprop_decoder, uniprop_decoder_count): New variables.
6454 (uniprop_get_decoder, uniprop_encode_value_character)
6455 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6456 New functions.
6457 (uniprop_encoder, uniprop_encoder_count): New variables.
6458 (uniprop_get_encoder, uniprop_table)
6459 (Funicode_property_table_internal, Fget_unicode_property_internal)
6460 (Fput_unicode_property_internal): New functions.
6461 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6462 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6463 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6464 char-code-property-alist.
6465
640c8776 6466 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6467 Vunicode_category_table.
6468
640c8776 6469 * font.c (font_range): Adjust for the change of
c805dec0
KH
6470 Vunicode_category_table.
6471
76b397fb
DN
64722011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6473
6474 * m/iris4d.h: Remove file, move contents ...
6475 * s/irix6-5.h: ... here.
6476
22b4128e
PE
64772011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6478
6479 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6480 * alloc.c (mark_buffer):
6481 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6482 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6483 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6484 This isn't true in general, and it's particularly not true
6485 if Emacs is configured with --with-wide-int.
6486 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6487 New macros, used in the buffer.c change.
6488
869795d6
JD
64892011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6490
6491 * xsettings.c: Use both GConf and GSettings if both are available.
6492 (store_config_changed_event): Add comment.
6493 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6494 (store_tool_bar_style_changed): New functions.
5e617bc2 6495 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6496 (struct xsettings): Move font inside HAVE_XFT.
6497 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6498 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6499 Move inside HAVE_XFT.
640c8776 6500 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6501 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6502 also.
6503 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6504 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6505 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6506 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6507 (parse_settings): Move check for font inside HAVE_XFT.
6508 (read_settings, apply_xft_settings): Add comment.
6509 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6510 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6511 call store_font_name_changed.
6512 (xft_settings_event): Add comment.
6513 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6514 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6515 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6516 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6517 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6518 (xsettings_get_system_font, xsettings_get_system_normal_font):
6519 Add comment.
869795d6 6520
d8ed26bd
PE
65212011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6522
6523 Random fixes. E.g., (random) never returned negative values.
6524 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6525 subseconds part to the entropy, as that's a bit more random.
6526 Prefer signed to unsigned, since the signedness doesn't matter and
6527 in general we prefer signed. When given a limit, use a
6528 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6529 latter isn't right if USE_2_TAGS_FOR_INTS.
6530 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6531 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6532
cabf1cac
SM
65332011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6534
6535 * textprop.c (text_property_stickiness):
6536 Obey Vtext_property_default_nonsticky.
6537 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6538 * w32fns.c (syms_of_w32fns):
6539 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6540
6e9b2be9
PE
65412011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6542
6543 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6544 This is more efficient than Ffile_directory_p and avoids a minor race.
6545
90186c68
LMI
65462011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6547
7c301272
LMI
6548 * buffer.c (Foverlay_put): Say what the return value is
6549 (bug#7835).
6550
c4f2d8d4
LMI
6551 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6552 is a directory before asking whether to use the file name
6553 (bug#7564).
ad637907
LMI
6554 (barf_or_query_if_file_exists): Make the "File is a directory"
6555 error be more correct.
c4f2d8d4 6556
90186c68
LMI
6557 * fns.c (Frequire): Remove the mention of the .gz files, since
6558 that's installation-specific, but keep the mention of
6559 `get-load-suffixes'.
6560
da64016e
PE
65612011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6562
6563 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6564 Report string overflow if the output is too long.
6565
7d47b580
JB
65662011-07-04 Juanma Barranquero <lekktu@gmail.com>
6567
a555cb87
JB
6568 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6569 (syms_of_gnutls): Remove duplicate DEFSYM for
6570 Qgnutls_bootprop_verify_hostname_error, an error for
6571 Qgnutls_bootprop_verify_error (which is no longer used).
6572
7d47b580
JB
6573 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6574 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6575 Also (re)move comments that are misplaced or no longer relevant.
6576
1e49bfab
LMI
65772011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6578
6579 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6580
1485f4c0
CY
65812011-07-03 Chong Yidong <cyd@stupidchicken.com>
6582
6583 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6584 and background color parameters if they have been changed.
6585
a9ab721e
LMI
65862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6587
6588 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6589
cf7cff57
PE
65902011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6591
2e13213d
PE
6592 * xsettings.c (SYSTEM_FONT): Define only when used.
6593 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6594
cf7cff57
PE
6595 * keymap.c (access_keymap_1): Now static.
6596
7a8e04f7
CY
65972011-07-02 Chong Yidong <cyd@stupidchicken.com>
6598
6599 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6600 leave any prefix arg for the up event (Bug#1586).
6601
61352f62
LMI
66022011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6603
69bb1ef7
LMI
6604 * lread.c (syms_of_lread): Mention single symbols defined by
6605 `defvar' or `defconst' (bug#7154).
6606
61352f62 6607 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6608 (Frequire): Mention get-load-suffixes.
61352f62 6609
28545e04
MR
66102011-07-02 Martin Rudalics <rudalics@gmx.at>
6611
6612 * window.h (window): Remove clone_number slot.
6613 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6614 Remove.
6615 (make_parent_window, make_window, saved_window)
6616 (Fset_window_configuration, save_window_save): Don't deal with
6617 clone numbers.
6618 * buffer.c (Qclone_number): Remove declaration.
6619 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6620
3349e122
SM
66212011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6622
6623 Add multiple inheritance to keymaps.
6624 * keymap.c (Fmake_composed_keymap): New function.
6625 (Fset_keymap_parent): Simplify.
6626 (fix_submap_inheritance): Remove.
6627 (access_keymap_1): New function extracted from access_keymap to handle
6628 embedded parents and handle lists of maps.
6629 (access_keymap): Use it.
6630 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6631 (Fcopy_keymap): Handle embedded parents.
6632 (Fcommand_remapping, define_as_prefix): Simplify.
6633 (Fkey_binding): Simplify.
6634 (syms_of_keymap): Move minibuffer-local-completion-map,
6635 minibuffer-local-filename-completion-map,
6636 minibuffer-local-must-match-map, and
6637 minibuffer-local-filename-must-match-map to Elisp.
6638 (syms_of_keymap): Defsubr make-composed-keymap.
6639 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6640 (parse_menu_item): Trivial simplification.
6641
3279eb87
GM
66422011-07-01 Glenn Morris <rgm@gnu.org>
6643
6644 * Makefile.in (SETTINGS_LIBS): Fix typo.
6645
4550efdf
KI
66462011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6647
6648 * coding.c (Fencode_coding_string): Record the last coding system
6649 used, as the function doc string says (bug#8738).
6650
0949d2b6
JD
66512011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6652
6653 * xsettings.c (store_monospaced_changed): Take new font as arg and
6654 check for change against current_mono_font.
6655 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6656 (emacs_settings_constructor, emacs_settings_get_property)
6657 (emacs_settings_set_property, emacs_settings_class_init)
6658 (emacs_settings_init, gsettings_obj): Remove.
6659 (something_changedCB): New function for HAVE_GSETTINGS.
6660 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6661 with value as argument.
6662 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6663 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6664 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6665 "changed".
6666
6667 * xgselect.c: Add defined (HAVE_GSETTINGS).
6668 (xgselect_initialize): Ditto.
6669
6670 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6671 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6672 xg_select.
6673
bbc6b304
PE
66742011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6675
6676 * eval.c (struct backtrace): Simplify and port the data structure.
6677 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6678 signed bit field, as this assumption is not portable and it makes
6679 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6680 "char debug_on_exit : 1" as this is not portable either; instead,
6681 use the portable "unsigned int debug_on_exit : 1". Remove unused
6682 member evalargs. Remove obsolete comments about cc bombing out.
6683
9851bfc5
JD
66842011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6685
51bb811f 6686 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6687 Let HAVE_GSETTINGS override HAVE_GCONF.
6688 (store_monospaced_changed): New function.
6689 (EMACS_SETTINGS): A new type derived from GObject to handle
6690 GSettings notifications.
6691 (emacs_settings_constructor, emacs_settings_get_property)
6692 (emacs_settings_set_property, emacs_settings_class_init):
6693 New functions.
6694 (gsettings_client, gsettings_obj): New variables.
6695 (GSETTINGS_SCHEMA): New define.
6696 (something_changedCB): Call store_monospaced_changed.
6697 (init_gsettings): New function.
6698 (xsettings_initialize): Call init_gsettings.
6699 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6700 to NULL.
6701
640c8776 6702 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6703 GCONF_CFLAGS/LIBS.
6704
5386012d
MR
67052011-06-29 Martin Rudalics <rudalics@gmx.at>
6706
6707 * window.c (resize_root_window, grow_mini_window)
6708 (shrink_mini_window): Rename Qresize_root_window to
6709 Qwindow_resize_root_window and Qresize_root_window_vertically to
6710 Qwindow_resize_root_window_vertically.
6711
f13e0b08
PE
67122011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6713
6714 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6715
94515237
JB
67162011-06-27 Juanma Barranquero <lekktu@gmail.com>
6717
6718 * makefile.w32-in: Redesign dependencies so they reflect more
6719 clearly which files are directly included by each source file,
6720 and not through other includes.
6721
e43b6e43
MR
67222011-06-27 Martin Rudalics <rudalics@gmx.at>
6723
6724 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6725 (sort_overlays, overlay_strings): When an overlay's clone number
6726 matches the window's clone number process the overlay even if
6727 the overlay's window property doesn't match the current window.
6728
d68443dc
MR
6729 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6730 (Fwindow_hchild): Rename to Fwindow_left_child.
6731 (Fwindow_next): Rename to Fwindow_next_sibling.
6732 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6733 (resize_window_check): Rename to window_resize_check.
6734 (resize_window_apply): Rename to window_resize_apply.
6735 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6736 (Fdelete_other_windows_internal, resize_frame_windows)
6737 (Fsplit_window_internal, Fdelete_window_internal)
6738 (grow_mini_window, shrink_mini_window)
6739 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6740
c7e73be5
JD
67412011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6742
6743 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6744 (emacs_fixed_set_min_size): Remove.
6745 (emacs_fixed_new): Take frame as argument.
6746
6747 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6748 (_EmacsFixedPrivate): Remove minwidth/height.
6749 Add struct frame *f.
6750 (emacs_fixed_init): Initialize priv->f.
6751 (get_parent_class, emacs_fixed_set_min_size): Remove.
6752 (emacs_fixed_new): Set priv->f to argument.
6753 (emacs_fixed_get_preferred_width)
6754 (emacs_fixed_get_preferred_height): Use min_width/height from
6755 frames size_hint to set minimum and natural (Bug#8919).
6756 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6757 and use min_width/height from frames size_hint to set
6758 min_width/height (Bug#8919).
6759
6760 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6761 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6762 Fix indentation.
c7e73be5 6763
cf99dcf8
EZ
67642011-06-26 Eli Zaretskii <eliz@gnu.org>
6765
6766 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6767 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6768 called at ZV.
6769
029529ac
CY
67702011-06-26 Chong Yidong <cyd@stupidchicken.com>
6771
6772 * process.c (wait_reading_process_output): Bypass select if
6773 waiting for a cell while ignoring keyboard input, and input is
6774 pending. Suggested by Jan Djärv (Bug#8869).
6775
7a7ef429
PE
67762011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6777
6778 Use gnulib's dup2 module instead of rolling our own.
6779 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6780
11fdef7d 67812011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6782
6783 * dispnew.c (scrolling_window): Before scrolling, turn off a
6784 mouse-highlight in the window being scrolled.
6785
cd3520a4
JB
67862011-06-24 Juanma Barranquero <lekktu@gmail.com>
6787
6788 Move DEFSYM to lisp.h and use everywhere.
6789
6790 * character.h (DEFSYM): Move declaration...
6791 * lisp.h (DEFSYM): ...here.
6792
6793 * gnutls.c:
6794 * minibuf.c:
6795 * w32menu.c:
6796 * w32proc.c:
6797 * w32select.c: Don't include character.h.
6798
6799 * alloc.c (syms_of_alloc):
6800 * buffer.c (syms_of_buffer):
6801 * bytecode.c (syms_of_bytecode):
6802 * callint.c (syms_of_callint):
6803 * casefiddle.c (syms_of_casefiddle):
6804 * casetab.c (init_casetab_once):
6805 * category.c (init_category_once, syms_of_category):
6806 * ccl.c (syms_of_ccl):
6807 * cmds.c (syms_of_cmds):
6808 * composite.c (syms_of_composite):
6809 * dbusbind.c (syms_of_dbusbind):
6810 * dired.c (syms_of_dired):
6811 * dispnew.c (syms_of_display):
6812 * doc.c (syms_of_doc):
6813 * editfns.c (syms_of_editfns):
6814 * emacs.c (syms_of_emacs):
6815 * eval.c (syms_of_eval):
6816 * fileio.c (syms_of_fileio):
6817 * fns.c (syms_of_fns):
6818 * frame.c (syms_of_frame):
6819 * fringe.c (syms_of_fringe):
6820 * insdel.c (syms_of_insdel):
6821 * keymap.c (syms_of_keymap):
6822 * lread.c (init_obarray, syms_of_lread):
6823 * macros.c (syms_of_macros):
6824 * msdos.c (syms_of_msdos):
6825 * print.c (syms_of_print):
6826 * process.c (syms_of_process):
6827 * search.c (syms_of_search):
6828 * sound.c (syms_of_sound):
6829 * syntax.c (init_syntax_once, syms_of_syntax):
6830 * terminal.c (syms_of_terminal):
6831 * textprop.c (syms_of_textprop):
6832 * undo.c (syms_of_undo):
6833 * w32.c (globals_of_w32):
6834 * window.c (syms_of_window):
6835 * xdisp.c (syms_of_xdisp):
6836 * xfaces.c (syms_of_xfaces):
6837 * xfns.c (syms_of_xfns):
6838 * xmenu.c (syms_of_xmenu):
6839 * xsettings.c (syms_of_xsettings):
6840 * xterm.c (syms_of_xterm): Use DEFSYM.
6841
4228cf16
TZ
68422011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6843
cd3520a4 6844 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6845
7fcccf1e
PE
68462011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6847
7efb4e0e
PE
6848 Integer and buffer overflow fixes (Bug#8873).
6849
ff5844ad
PE
6850 * print.c (printchar, strout): Check for string overflow.
6851 (PRINTPREPARE, printchar, strout):
6852 Don't set size unless allocation succeeds.
6853
90532f02
PE
6854 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6855 for sizes. Check for string overflow more accurately.
6856 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6857
6d84508d
PE
6858 * macros.c: Integer and buffer overflow fixes.
6859 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6860 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6861 Use ptrdiff_t, not int, for sizes.
6862 Don't increment bufsize until after realloc succeeds.
6863 Check for size-calculation overflow.
6864 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6865
437b2cb4
PE
6866 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6867
8b9ac8b4
PE
6868 * lread.c: Integer overflow fixes.
6869 (read_integer): Radix is now EMACS_INT, not int,
6870 to improve quality of diagnostics for out-of-range radices.
6871 Calculate buffer size correctly for out-of-range radices.
6872 (read1): Check for integer overflow in radices, and in
6873 read-circle numbers.
82cb60d3
PE
6874 (read_escape): Avoid int overflow.
6875 (Fload, openp, read_buffer_size, read1)
6876 (substitute_object_recurse, read_vector, read_list, map_obarray):
6877 Use ptrdiff_t, not int, for sizes.
6878 (read1): Use EMACS_INT, not int, for sizes.
20270765 6879 Check for size overflow.
8b9ac8b4 6880
7fcccf1e
PE
6881 * image.c (cache_image): Check for size arithmetic overflow.
6882
bfbbd7e7
PE
6883 * lread.c: Integer overflow issues.
6884 (saved_doc_string_size, saved_doc_string_length)
6885 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6886 Now ptrdiff_t, not int.
6887 (read1): Don't assume doc string length fits in int. Check for
6888 out-of-range doc string lengths.
6889 (read_list): Don't assume file position fits in int.
39019e54 6890 (read_escape): Check for hex character overflow.
bfbbd7e7 6891
4e323265
LL
68922011-06-22 Leo Liu <sdl.web@gmail.com>
6893
6894 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6895 Move to minibuffer.el.
6896
85fece3e
PE
68972011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6898
20b84ce9 6899 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6900 The following patches are for when GLYPH_DEBUG && !XASSERT.
6901 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6902 * dispnew.c (flush_stdout):
6903 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6904 Mark as externally visible.
6905 * dispnew.c (check_window_matrix_pointers): Now static.
6906 * dispnew.c (window_to_frame_vpos):
6907 * xfns.c (unwind_create_frame):
6908 * xterm.c (x_check_font): Remove unused local.
6909 * scroll.c (CHECK_BOUNDS):
6910 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6911 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6912 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6913 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6914 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6915 Now static.
6916 (debug_method_add): Use va_list and vsprintf rather than relying
6917 on undefined behavior with wrong number of arguments.
6918 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6919 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6920 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6921 since we're not interested in debugging glyphs with old libraries.
6922 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6923 GCC 4.6.0's static checking.
6924
0766b489
PE
69252011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6926
31fd4b32
PE
6927 Integer overflow and signedness fixes (Bug#8873).
6928 A few related buffer overrun fixes, too.
6929
b79e8648
PE
6930 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6931
0766b489
PE
6932 * dispextern.h (struct face.stipple):
6933 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6934 (x_bitmap_mask, x_allocate_bitmap_record)
6935 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6936 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6937 (x_create_bitmap_from_xpm_data):
6938 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6939 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6940 (.bitmaps_last):
6941 * xfaces.c (load_pixmap):
6942 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6943 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6944 (.bitmaps_last, struct x_output.icon_bitmap):
6945 Use ptrdiff_t, not int, for bitmap indexes.
6946 (x_allocate_bitmap_record): Check for size overflow.
6947 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6948
b081724f
PE
6949 Use ptrdiff_t, not int, for overlay counts.
6950 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6951 * editfns.c (overlays_around, get_pos_property):
6952 * textprop.c (get_char_property_and_overlay):
6953 * xdisp.c (next_overlay_change, note_mouse_highlight):
6954 * xfaces.c (face_at_buffer_position):
21514da7
PE
6955 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6956 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6957 (Fnext_overlay_change, Fprevious_overlay_change)
6958 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6959 Use ptrdiff_t, not int, for sizes.
21514da7 6960 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6961
3de73e5e
PE
6962 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6963
2606c57b
PE
6964 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6965 (x_session_initialize): Do not assume string length fits in int.
6966
aaafe47a
PE
6967 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6968 This is unlikely, but can occur if DPI is outlandish.
6969
2674ddc8 6970 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6971 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6972
28154962
PE
6973 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6974 * xrdb.c (magic_file_p, search_magic_path):
6975 Omit last arg SUFFIX; it was always 0. All callers changed.
6976 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6977
7de51af5
PE
6978 * xfont.c (xfont_match): Avoid need for strlen.
6979
25ed6cc3
PE
6980 * xfns.c: Don't assume strlen fits in int.
6981 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6982
4eab31dd
PE
6983 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6984 not unsigned long, as we prefer signed integers. All callers changed.
6985 Detect integer overflow in repeat count.
6986 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6987 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6988
171e2a58
PE
6989 * termcap.c: Don't assume sizes fit in int and never overflow.
6990 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6991 (gobble_line): Check for size-calculation overflow.
6992
ad39faca 6993 * minibuf.c (Fread_buffer):
6e5bb2dc 6994 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6995 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6996 Don't assume string length fits in int.
6997
52c61c22 6998 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6999 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7000
b5b8c9e5
PE
7001 * font.c: Don't assume string length fits in int.
7002 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7003 Use ptrdiff_t, not int.
ccd6111c
PE
7004 (font_intern_prop): Don't assume string length fits in int.
7005 Don't assume integer property fits in fixnum.
7006 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7007
882f0d81 7008 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7009 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7010 Reformulate so as not to need the command string.
7011 Invoke gzip -cd rather than gunzip, as it's more portable.
7012 (lock_info_type, lock_file_1, lock_file):
7013 Don't assume pid_t and time_t fit in unsigned long.
7014 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7015 (current_lock_owner): Prefer signed type for sizes.
7016 Use memcpy, not strncpy, where memcpy is what is really wanted.
7017 Don't assume (via atoi) that time_t and pid_t fit in int.
7018 Check for time_t and/or pid_t out of range, e.g., via a network share.
7019 Don't alloca where an auto var works fine.
7020
93f4cf88
PE
7021 * fileio.c: Fix some integer overflow issues.
7022 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7023 Don't assume string length fits in int.
7024 (directory_file_name): Don't assume string length fits in long.
7025 (make_temp_name): Don't assume pid fits in int, or that its print
7026 length is less than 20.
7027
f3e92b69
PE
7028 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7029
1bfdaf10
PE
7030 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7031
35016e9a
PE
7032 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7033
3d1e65a1
PE
7034 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7035 We prefer signed integers, even for size calculations.
7036
0b963a93
PE
7037 * emacs.c: Don't assume string length fits in 'int'.
7038 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7039 (main): Don't invoke strlen when not needed.
7040
573f4b54
PE
7041 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7042 (XD_DEBUG_MESSAGE): Don't waste a byte.
7043
989f33ba
PE
7044 * callproc.c (getenv_internal_1, getenv_internal)
7045 (Fgetenv_internal):
965d34eb
PE
7046 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7047
e4d29b33
PE
7048 * lread.c (invalid_syntax): Omit length argument.
7049 All uses changed. This doesn't fix a bug, but it simplifies the
7050 code away from its former Hollerith-constant appearance, and it's
7051 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7052 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7053
eb49b136
PE
7054 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7055 This didn't break anything, but it didn't help either.
7056 It's confusing to put a bogus integer in a place where the actual
7057 value does not matter.
9f62aeb1 7058 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7059 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7060
15375a22
PE
7061 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7062 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7063 implementation.
b61cc01c
PE
7064 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7065 We prefer signed types, and the value cannot exceed the EMACS_INT
7066 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7067 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7068 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7069 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7070
53b2623d
PE
7071 * indent.c (sane_tab_width): New function.
7072 (current_column, scan_for_column, Findent_to, position_indentation)
7073 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7074 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7075
51cab52b 7076 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7077
f2ed8a70
PE
7078 * lisp.h (lint_assume): New macro.
7079 * composite.c (composition_gstring_put_cache):
7080 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7081
abe80cc6
PE
7082 * editfns.c, insdel.c:
7083 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7084
b02c740e
PE
7085 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7086
ebc96716
PE
7087 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7088
b4e50fa0 7089 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7090 Use much-faster test for byte-length change.
311d5d7c 7091 Don't assume string byte-length fits in 'int'.
a4cf38e4 7092 Check that character arg fits in 'int'.
85461888 7093 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7094
c0c1ee9f
PE
7095 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7096
a498d7f4
PE
7097 * fns.c (concat): Catch string overflow earlier.
7098 Do not rely on integer wraparound.
7099
51cab52b
PE
7100 * dispextern.h (struct it.overlay_strings_charpos)
7101 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7102 * xdisp.c (forward_to_next_line_start)
7103 (back_to_previous_visible_line_start)
7104 (reseat_at_next_visible_line_start, next_element_from_buffer):
7105 Don't arbitrarily truncate the value of 'selective' to int.
7106
76031fad
PE
7107 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7108
5eb55db9
PE
7109 * composite.c: Don't truncate sizes to 'int'.
7110 (composition_gstring_p, composition_reseat_it)
7111 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7112 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7113 not EMACS_UINT, for indexes.
5eb55db9 7114
0703a717
PE
7115 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7116
d6202519
PE
7117 * buffer.c: Include <verify.h>.
7118 (struct sortvec.priority, struct sortstr.priority):
8961a454 7119 Now EMACS_INT, not int.
c20998a7 7120 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7121 (struct sortstr.size, record_overlay_string)
7122 (struct sortstrlist.size, struct sortlist.used):
7123 Don't truncate size to int.
7124 (record_overlay_string): Check for size-calculation overflow.
d6202519 7125 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7126
d5a19415
JM
71272011-06-22 Jim Meyering <meyering@redhat.com>
7128
029529ac 7129 Don't leak an XBM-image-sized buffer
d5a19415
JM
7130 * image.c (xbm_load): Free the image buffer after using it.
7131
a9041e6c
PE
71322011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7133
7134 Port to Sun C.
7135 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7136 that Sun C diagnosed.
7137 * fns.c (secure_hash): Fix pointer signedness issue.
7138 * intervals.c (static_offset_intervals): New function.
7139 (offset_intervals): Use it.
7140
7f3f739f
LL
71412011-06-21 Leo Liu <sdl.web@gmail.com>
7142
7143 * deps.mk (fns.o):
7144 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7145 sha512.h.
7146
7147 * fns.c (secure_hash): Rename from crypto_hash_function and change
7148 the first arg to accept symbols.
5b66d427 7149 (Fsecure_hash): New primitive.
7f3f739f
LL
7150 (syms_of_fns): New symbols.
7151
76147d94
DD
71522011-06-20 Deniz Dogan <deniz@dogan.se>
7153
7154 * process.c (Fset_process_buffer): Clarify return value in
7155 docstring.
7156
7d7d0045
CY
71572011-06-18 Chong Yidong <cyd@stupidchicken.com>
7158
7159 * dispnew.c (add_window_display_history): Use BVAR.
7160
7161 * xdisp.c (debug_method_add): Use BVAR.
7162 (check_window_end, dump_glyph_matrix, dump_glyph)
7163 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7164
7165 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7166 Likewise.
7167
7168 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7169 check till after the cache is created in init_frame_faces.
7170
ff2bc410
SM
71712011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7172
7173 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7174
28177add
PE
71752011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7176
dd3482fe
PE
7177 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7178 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7179 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7180
393d71f3 7181 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7182 * fileio.c (Finsert_file_contents):
7183 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7184 Remove the old (too-loose) buffer overflow checks.
7185 They weren't needed, since make_gap checks for buffer overflow.
7186 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7187 The old code merely checked for Emacs fixnum overflow, and relied
7188 on undefined (wraparound) behavior. The new code avoids undefined
7189 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7190
2e6813b0 7191 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7192 Tune. Don't use wider integers than needed. Don't use alloca.
7193 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7194
599a9e4f
PE
7195 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7196
99561444
PE
7197 * insdel.c, lisp.h (buffer_overflow): New function.
7198 (insert_from_buffer_1, replace_range, replace_range_2):
7199 * insdel.c (make_gap_larger):
7200 * editfns.c (Finsert_char):
7201 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7202
28177add
PE
7203 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7204
e69dafad
PE
72052011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7206
4baa020d 7207 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7208
b1c46f02
PE
7209 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7210 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7211
e69dafad
PE
7212 * fileio.c: Don't assume EMACS_INT fits in off_t.
7213 (emacs_lseek): New static function.
7214 (Finsert_file_contents, Fwrite_region): Use it.
7215 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7216
566684ea
PE
7217 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7218
e6966cd6
PE
7219 * fns.c: Don't overflow int when computing a list length.
7220 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7221 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7222 truncation on 64-bit hosts. Check for QUIT every
7223 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7224 faster and is responsive enough.
7225 (Flength): Report an error instead of overflowing an integer.
7226 (Fsafe_length): Return a float if the value is not representable
7227 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7228 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7229 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7230
dd0b0efb
PE
7231 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7232 (header_size, word_size): New constants.
7233 (allocate_vectorlike): Don't check size overflow here.
7234 (allocate_vector): Check it here instead, since this is the only
7235 caller of allocate_vectorlike that could cause overflow.
7236 Check that the new vector's length is representable as a fixnum.
7237
86fe5cfe
PE
7238 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7239 The previous code was bogus. For example, next_almost_prime (32)
7240 returned 39, which is undesirable as it is a multiple of 3; and
7241 next_almost_prime (24) returned 25, which is a multiple of 5 so
7242 why was the code bothering to check for multiples of 7?
7243
80e88859
PE
7244 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7245
4a2f0ad6
PE
7246 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7247
f66c7cf8
PE
7248 Variadic C functions now count arguments with ptrdiff_t.
7249 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7250 Back then I didn't know that the Emacs coding style prefers signed int.
7251 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7252 were being counted with int, which may truncate counts on 64-bit
7253 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7254 * lisp.h (struct Lisp_Subr.function.aMANY)
7255 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7256 Arg counts are now ptrdiff_t, not size_t.
7257 All variadic functions and their callers changed accordingly.
7258 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7259 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7260 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7261 * callint.c (Fcall_interactively): Check arg count for overflow,
7262 to avoid potential buffer overrun. Use signed char, not 'int',
7263 for 'varies' array, so that we needn't bother to check its size
7264 calculation for overflow.
7265 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7266 * eval.c (apply_lambda):
7267 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7268 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7269 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7270
a1759b76
PE
7271 * callint.c (Fcall_interactively): Don't use index var as event count.
7272
d96be9fc
PE
7273 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7274 * mem-limits.h (SIZE): Remove; no longer used.
7275
a690a978 7276 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7277
578c21e6
PE
7278 Remove unnecessary casts.
7279 * xterm.c (x_term_init):
7280 * xfns.c (x_set_border_pixel):
7281 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7282 These aren't needed now that we assume ANSI C.
7283
96f53c6c
PE
7284 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7285 It's more likely to cause problems (due to unsigned overflow)
7286 than to cure them.
7287
83c77d31
PE
7288 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7289
ee2079f1
PE
7290 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7291
6da65536
PE
7292 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7293
7147c4a4
PE
7294 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7295
193e32d9
PE
7296 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7297
e5533da6
PE
7298 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7299
9910e595
PE
7300 GLYPH_CODE_FACE returns EMACS_INT, not int.
7301 * dispextern.h (merge_faces):
7302 * xfaces.c (merge_faces):
01103c44
PE
7303 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7304 Don't assume EMACS_INT fits in int.
9910e595 7305
2638320e
PE
7306 * character.h (CHAR_VALID_P): Remove unused parameter.
7307 * fontset.c, lisp.h, xdisp.c: All uses changed.
7308
045eb8d9
PE
7309 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7310
c1f134b5
PE
7311 * fns.c (concat): Minor tuning based on overflow analysis.
7312 This doesn't fix any bugs. Use int to hold character, instead
7313 of constantly refetching from Emacs object. Use XFASTINT, not
7314 XINT, for value known to be a character. Don't bother comparing
7315 a single byte to 0400, as it's always less.
7316
395fcb93 7317 * floatfns.c (Fexpt):
327eeec8
PE
7318 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7319
abbd3d23
PE
7320 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7321 for characters.
7322
684a03ef
PE
7323 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7324
0fed43f3
PE
7325 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7326 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7327 incorrectly succeed when S was a string, because 4294967386 was
7328 truncated before it was used.
7329
8fd02eb7
PE
7330 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7331 Otherwise, an out-of-range integer could cause undefined behavior
7332 on a 64-bit host.
7333
f8c86b69
PE
7334 * composite.c: Use int, not EMACS_INT, for characters.
7335 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7336 EMACS_INT, for values that are known to be in character range.
7337 This doesn't fix any bugs but is the usual style inside Emacs and
7338 may generate better code on 32-bit machines.
7339
34206dd2
PE
7340 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7341 This is for reasons similar to the recent CHAR_STRING fix.
7342 * charset.c (Fencode_char): Check that character arg is actually
7343 a character. Pass an int to ENCODE_CHAR.
7344 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7345 wider than 'int', as a compile-time check to prevent future regressions
7346 in this area.
7347
c5958d4c 7348 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7349
7350 Make sure a 64-bit char is never passed to CHAR_STRING.
7351 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7352 by silently ignoring the top 32 bits, allowing some values
7353 that were far too large to be valid characters.
7354 * character.h: Include <verify.h>.
7355 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7356 arguments are no wider than unsigned, as a compile-time check
7357 to prevent future regressions in this area.
7358 * data.c (Faset):
01103c44 7359 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7360 (Fsubst_char_in_region):
7361 * fns.c (concat):
7362 * xdisp.c (decode_mode_spec_coding):
7363 Adjust to CHAR_STRING's new requirement.
7364 * editfns.c (Finsert_char, Fsubst_char_in_region):
7365 * fns.c (concat): Check that character args are actually
7366 characters. Without this test, these functions did the wrong
7367 thing with wildly out-of-range values on 64-bit hosts.
7368
d37ca623
PE
7369 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7370 These casts should not be needed on 32-bit hosts, either.
7371 * keyboard.c (read_char):
7372 * lread.c (Fload): Remove casts to unsigned.
7373
ea204efb
PE
7374 * lisp.h (UNSIGNED_CMP): New macro.
7375 This fixes comparison bugs on 64-bit hosts.
7376 (ASCII_CHAR_P): Use it.
7377 * casefiddle.c (casify_object):
01103c44 7378 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7379 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7380 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7381 * dispextern.h (FACE_FROM_ID):
7382 * keyboard.c (read_char): Use UNSIGNED_CMP.
7383
41cb286c
PE
7384 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7385 not to EMACS_INT, to avoid GCC warning.
7386
4a1b9832
PE
7387 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7388
55daad71
PE
7389 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7390 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7391 isn't needed on 32-bit machines.
8f95c75c 7392
01103c44
PE
7393 * buffer.c (Fgenerate_new_buffer_name):
7394 Use EMACS_INT for count, not int.
0ceccced 7395 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7396
7397 * data.c (Qcompiled_function): Now static.
7398
c6f072e7
PE
7399 * window.c (window_body_lines): Now static.
7400
20ce5912
PE
7401 * image.c (gif_load): Rename local to avoid shadowing.
7402
9c4c5f81
PE
7403 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7404 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7405 * alloc.c (make_save_value): Integer argument is now of type
7406 ptrdiff_t, not int.
7407 (mark_object): Use ptrdiff_t, not int.
7408 * lisp.h (pD): New macro.
7409 * print.c (print_object): Use it.
7410
c0c5c8ae
PE
7411 * alloc.c: Use EMACS_INT, not int, to count objects.
7412 (total_conses, total_markers, total_symbols, total_vector_size)
7413 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7414 (total_free_floats, total_floats, total_free_intervals)
7415 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7416 Now EMACS_INT, not int. All uses changed.
7417 (Fgarbage_collect): Compute overall total using a double, so that
7418 integer overflow is less likely to be a problem. Check for overflow
7419 when converting back to an integer.
5a25e253
PE
7420 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7421 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7422 These were 'int' variables that could overflow on 64-bit hosts;
7423 they were never used, so remove them instead of repairing them.
211a0b2a 7424 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7425 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7426 Previously, this ceilinged at INT_MAX, but that doesn't work on
7427 64-bit machines.
e46bb31a 7428 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7429
c78baabf 7430 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7431 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7432 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7433 when a (possibly-narrower) signed value would do just as well.
7434 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7435
c9d624c6
PE
7436 * alloc.c: Catch some string size overflows that we were missing.
7437 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7438 for convenience in STRING_BYTES_MAX.
7439 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7440 The definition here is exact; the one in lisp.h was approximate.
7441 (allocate_string_data): Check for string overflow. This catches
7442 some instances we weren't catching before. Also, it catches
7443 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7444 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7445 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7446
c9d624c6
PE
7447 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7448 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7449 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7450
353032ce
PE
7451 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7452
2bccce07
PE
7453 * alloc.c (Fmake_string): Check for out-of-range init.
7454
0ac30604
SM
74552011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7456
7457 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7458
c195f2de
JD
74592011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7460
7461 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7462 xg_get_default_scrollbar_width.
7463
7464 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7465 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7466 (style_changed_cb): Call update_theme_scrollbar_width and call
7467 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7468 all frames (Bug#8505).
7469 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7470 Call gtk_window_set_resizable if HAVE_GTK3.
7471 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7472 and height if HAVE_GTK3 (Bug#8505).
7473 (scroll_bar_width_for_theme): New variable.
7474 (update_theme_scrollbar_width): New function.
7475 (xg_get_default_scrollbar_width): Move code to
7476 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7477 (xg_initialize): Call update_theme_scrollbar_width.
7478
7479 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7480
7481 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7482
e10ac9f1
MR
74832011-06-12 Martin Rudalics <rudalics@gmx.at>
7484
7485 * frame.c (make_frame): Call other_buffer_safely instead of
7486 other_buffer.
7487
7488 * window.c (temp_output_buffer_show): Call display_buffer with
7489 second argument Vtemp_buffer_show_specifiers and reset latter
7490 immediately after the call.
7491 (Vtemp_buffer_show_specifiers): New variable.
7492 (auto_window_vscroll_p, next_screen_context_lines)
7493 (Vscroll_preserve_screen_position): Remove leading asterisks from
7494 doc-strings.
7495
2d3c217e 74962011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7497
7b7f97e8 7498 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7499 * buffer.c (Qclone_number): Remove for now, as it's unused.
7500 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7501 (record_buffer): Remove unused local.
7502 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7503 (set_frame_buffer_list): Remove; unused.
7504 * frame.h (other_visible_frames): Remove decl.
7505 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7506 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7507 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7508 if HAVE_GPM.
7509 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7510 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7511 Define only if HAVE_GPM.
7512 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7513 (update_hints_inhibit): Remove; never set. All uses removed.
7514 * widgetprv.h (emacsFrameClassRec): Remove decl.
7515 * window.c (delete_deletable_window): Now returns void, since it
7516 wasn't returning anything.
7517 (compare_window_configurations): Remove unused locals.
7518 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7519 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7520 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7521 the same widths as pointers. This follows up on the 2011-05-06 patch.
7522 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7523 * xterm.h: Likewise.
7524 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7525
1384b89e
JB
75262011-06-12 Juanma Barranquero <lekktu@gmail.com>
7527
7528 * makefile.w32-in: Update dependencies.
7529 (LISP_H): Add lib/intprops.h.
7530
1100a63c
CY
75312011-06-11 Chong Yidong <cyd@stupidchicken.com>
7532
7533 * image.c (gif_load): Add animation frame delay to the metadata.
7534 (syms_of_image): Use DEFSYM. New symbol `delay'.
7535
6198ccd0
MR
75362011-06-11 Martin Rudalics <rudalics@gmx.at>
7537
7538 * window.c (delete_deletable_window): Re-add.
7539 (Fset_window_configuration): Rewrite to handle dead buffers and
7540 consequently deletable windows.
7541 (window_tree, Fwindow_tree): Remove. Supply functionality in
7542 window.el.
7543 (compare_window_configurations): Simplify code.
7544
b6e3633c
AS
75452011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7546
1ab0dee5
AS
7547 * image.c (imagemagick_load_image): Fix type mismatch.
7548 (Fimagemagick_types): Likewise.
7549
b6e3633c
AS
7550 * window.h (replace_buffer_in_windows): Declare.
7551
9397e56f
MR
75522011-06-11 Martin Rudalics <rudalics@gmx.at>
7553
7554 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7555 Qclone_number. Remove external declaration of Qdelete_window.
7556 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7557 code.
640c8776
SM
7558 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7559 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7560 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7561 buffer list implementation.
7562 (other_buffer_safely): New function.
7563 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7564 calls to replace_buffer_in_windows and
7565 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7566 if allowed.
7567 (record_buffer): Inhibit quitting and rewrite using quittable
7568 functions. Run Qbuffer_list_update_hook if allowed.
7569 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7570 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7571 Move switch-to-buffer to window.el.
9397e56f
MR
7572 (bury-buffer): Move to window.el.
7573 (Vbuffer_list_update_hook): New variable.
7574
7575 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7576 section.
7577
7578 * window.h (resize_frame_windows): Move up in code.
7579 (Fwindow_frame): Remove EXFUN.
7580 (replace_buffer_in_all_windows): Remove prototype.
7581 (replace_buffer_in_windows_safely): Add prototype.
7582
7583 * window.c: Declare Qdelete_window static again. Move down
7584 declaration of select_count.
7585 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7586 (Fother_window): Move to window.el.
7587 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7588 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7589 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7590 window.el.
7591 (replace_buffer_in_windows): Implement by calling
7592 Qreplace_buffer_in_windows.
7593 (replace_buffer_in_all_windows): Remove with some functionality
7594 moved into replace_buffer_in_windows_safely.
7595 (replace_buffer_in_windows_safely): New function.
7596 (select_window_norecord, select_frame_norecord): Move in front
7597 of run_window_configuration_change_hook. Remove now obsolete
7598 declarations.
640c8776
SM
7599 (Fset_window_buffer): Rewrite doc-string.
7600 Call Qrecord_window_buffer.
9397e56f
MR
7601 (keys_of_window): Move binding for other-window to window.el.
7602
b50691aa
CY
76032011-06-11 Chong Yidong <cyd@stupidchicken.com>
7604
7605 * dispextern.h (struct image): Replace data member, whose int_val
7606 and ptr_val fields were not used by anything, with a single
7607 lisp_val object.
7608
7609 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7610 (gif_clear_image, gif_load, imagemagick_load_image)
7611 (gs_clear_image, gs_load): Callers changed.
7612
3f754b86
PE
76132011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7614
cca69397
PE
7615 * buffer.h: Include <time.h>, for time_t.
7616 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7617
109e28d0
PE
7618 Fix minor problems found by static checking.
7619
60737f02
PE
7620 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7621
4b66faf3
PE
7622 Make identifiers static if they are not used in other modules.
7623 * data.c (Qcompiled_function, Qframe, Qvector):
7624 * image.c (QimageMagick, Qsvg):
7625 * minibuf.c (Qmetadata):
7626 * window.c (resize_window_check, resize_root_window): Now static.
7627 * window.h (resize_window_check, resize_root_window): Remove decls.
7628
109e28d0
PE
7629 * window.c (window_deletion_count, delete_deletable_window):
7630 Remove; unused.
46a4ce9e
PE
7631 (window_body_lines): Now static.
7632 (Fdelete_other_windows_internal): Mark vars as initialized.
7633 Make sure 'resize_failed' is initialized.
7634 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7635 (resize_window_apply): Remove unused local.
7636 * window.h (delete_deletable_window): Remove decl.
7637
109e28d0 7638 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7639 (imagemagick_load_image): Fix pointer signedness problem by changing
7640 last arg from unsigned char * to char *. All uses changed.
7641 Also, fix a local for similar reasons.
7642 Remove unused locals. Remove locals to avoid shadowing.
7643 (fn_rsvg_handle_free): Remove; unused.
7644 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7645 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7646
3f754b86
PE
7647 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7648
2547adb1
CY
76492011-06-10 Chong Yidong <cyd@stupidchicken.com>
7650
7651 * image.c (gif_load): Fix omitted cast error introduced by
7652 2011-06-06 change.
7653
2c8e37d4
MR
76542011-06-10 Martin Rudalics <rudalics@gmx.at>
7655
7656 * window.h (resize_proportionally, orig_total_lines)
7657 (orig_top_line): Remove from window structure.
7658 (set_window_height, set_window_width, change_window_heights)
7659 (Fdelete_window): Remove prototypes.
7660 (resize_frame_windows): Remove duplicate declaration.
7661
440a42e3
EZ
76622011-06-10 Eli Zaretskii <eliz@gnu.org>
7663
7664 * window.h (resize_frame_windows, resize_window_check)
7665 (delete_deletable_window, resize_root_window)
7666 (resize_frame_windows): Declare prototypes.
7667
7668 * window.c (resize_window_apply): Make definition be "static" to
7669 match the prototype.
7670
562dd5e9
MR
76712011-06-10 Martin Rudalics <rudalics@gmx.at>
7672
7673 * window.c: Remove declarations of Qwindow_size_fixed,
7674 window_min_size_1, window_min_size_2, window_min_size,
7675 size_window, window_fixed_size_p, enlarge_window, delete_window.
7676 Remove static from declaration of Qdelete_window, it's
7677 temporarily needed by Fbury_buffer.
7678 (replace_window): Don't assign orig_top_line and
7679 orig_total_lines.
7680 (Fdelete_window, delete_window): Remove. Window deletion is
7681 handled by window.el.
640c8776
SM
7682 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7683 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7684 (Fdelete_other_windows): Remove. Deleting other windows is
7685 handled by window.el.
7686 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7687 handled in window.el.
7688 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7689 Window minimum sizes are handled in window.el.
7690 (shrink_windows, size_window, set_window_height)
7691 (set_window_width, change_window_heights, window_height)
7692 (window_width, CURBEG, CURSIZE, enlarge_window)
7693 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7694 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7695 handled in window.el.
7696 (make_dummy_parent): Rename to make_parent_window and give it a
7697 second argument horflag.
7698 (make_window): Don't set resize_proportionally any more.
7699 (Fsplit_window): Remove. Windows are split in window.el.
7700 (save_restore_action, save_restore_orig_size)
7701 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7702 Resize mini windows in window.el.
7703 (grow_mini_window, shrink_mini_window): Implement by calling
7704 Qresize_root_window_vertically, resize_window_check and
7705 resize_window_apply.
640c8776
SM
7706 (saved_window, Fset_window_configuration, save_window_save):
7707 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7708 resize_proportionally.
7709 (window_min_height, window_min_width): Move to window.el.
7710 (keys_of_window): Move bindings for delete-other-windows,
7711 split-window, delete-window and enlarge-window to window.el.
7712
7713 * buffer.c: Temporarily extern Qdelete_window.
7714 (Fbury_buffer): Temporarily call Qdelete_window instead of
7715 Fdelete_window (Fbury_buffer will move to window.el soon).
7716
7717 * frame.c (set_menu_bar_lines_1): Remove code handling
7718 orig_top_line and orig_total_lines.
7719
7720 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7721 set_window_height but set heights directly.
7722 (change_frame_size_1): Use resize_frame_windows.
7723
7724 * xdisp.c (init_xdisp): Don't use set_window_height but set
7725 heights directly.
7726
640c8776
SM
7727 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7728 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7729 run_window_configuration_change_hook.
7730
7731 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7732 instead of change_window_heights and run
7733 run_window_configuration_change_hook.
7734
1a13852e
MR
77352011-06-09 Martin Rudalics <rudalics@gmx.at>
7736
7737 * window.c (replace_window): Rename second argument REPLACEMENT to
7738 NEW. New third argument SETFLAG. Rewrite.
7739 (delete_window, make_dummy_parent): Call replace_window with
7740 third argument 1.
7741 (window_list_1): Move down in code.
7742 (run_window_configuration_change_hook): Move set_buffer part
7743 before select_frame_norecord part in order to unwind correctly.
7744 Rename count1 to count.
7745 (recombine_windows, delete_deletable_window, resize_root_window)
7746 (Fdelete_other_windows_internal)
7747 (Frun_window_configuration_change_hook, make_parent_window)
7748 (resize_window_check, resize_window_apply, Fresize_window_apply)
7749 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7750 (Fdelete_window_internal, Fresize_mini_window_internal):
7751 New functions.
1a13852e
MR
7752 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7753
f3d1777e
MR
77542011-06-08 Martin Rudalics <rudalics@gmx.at>
7755
496e208e
MR
7756 * window.h (window): Add some new members to window structure -
7757 normal_lines, normal_cols, new_total, new_normal, clone_number,
7758 splits, nest, prev_buffers, next_buffers.
7759 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7760 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7761
f3d1777e
MR
7762 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7763 Remove.
496e208e
MR
7764 (make_dummy_parent): Set new members of windows structure.
7765 (make_window): Move down in code. Handle new members of window
7766 structure.
7767 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7768 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7769 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7770 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7771 (Fset_window_next_buffers, Fset_window_clone_number):
7772 New functions.
496e208e
MR
7773 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7774 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7775 Doc-string fixes.
7776 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7777 Argument WINDOW can be now internal window too.
7778 (Fwindow_use_time): Move up in code.
7779 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7780 Rewrite doc-string.
7781 (Fset_window_configuration, saved_window)
7782 (Fcurrent_window_configuration, save_window_save): Handle new
7783 members of window structure.
b9e809c2
MR
7784 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7785 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7786 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7787 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7788 Qget_mru_window, Qresize_root_window,
7789 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7790 Qauto_buffer_name; staticpro them.
f3d1777e 7791
abde8f8c
MR
77922011-06-07 Martin Rudalics <rudalics@gmx.at>
7793
7794 * window.c (Fwindow_total_size, Fwindow_left_column)
7795 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7796 (Fwindow_list_1): New functions.
7797 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7798 (Fwindow_width, Fscroll_left, Fscroll_right):
7799 Use window_body_cols instead of window_box_text_cols.
7800 (delete_window, Fset_window_configuration):
7801 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7802 (delete_all_subwindows): Take a window as argument and not a
7803 structure. Rewrite.
190b47e6
MR
7804 (window_loop): Remove handling of GET_LRU_WINDOW and
7805 GET_LARGEST_WINDOW.
7806 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7807
7808 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7809 window_box_text_cols. delete_all_subwindows now takes a
7810 Lisp_Object as argument.
abde8f8c 7811
640c8776
SM
7812 * indent.c (compute_motion, Fcompute_motion):
7813 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7814
fa8a67e6
MR
7815 * frame.c (delete_frame): Call delete_all_subwindows with root
7816 window as argument.
7817
a54e3482
DC
78182011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7819
7820 * fns.c (Fputhash): Document return value.
7821
60002bf5
CY
78222011-06-06 Chong Yidong <cyd@stupidchicken.com>
7823
7824 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7825
0c671da6 78262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7827
b862a52a 7828 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7829
be44ca6c
PE
7830 Check for overflow when converting integer to cons and back.
7831 * charset.c (Fdefine_charset_internal, Fdecode_char):
7832 Use cons_to_unsigned to catch overflow.
7833 (Fencode_char): Use INTEGER_TO_CONS.
7834 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7835 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7836 * data.c (long_to_cons, cons_to_long): Remove.
7837 (cons_to_unsigned, cons_to_signed): New functions.
7838 These signal an error for invalid or out-of-range values.
7839 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7840 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7841 * font.c (Ffont_variation_glyphs):
7842 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7843 * lisp.h: Include <intprops.h>.
7844 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7845 (cons_to_signed, cons_to_unsigned): New decls.
7846 (long_to_cons, cons_to_long): Remove decls.
7847 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7848 (Fprimitive_undo): Use CONS_TO_INTEGER.
7849 * xfns.c (Fx_window_property): Likewise.
7850 * xselect.c: Include <limits.h>.
7851 (x_own_selection, selection_data_to_lisp_data):
7852 Use INTEGER_TO_CONS.
7853 (x_handle_selection_request, x_handle_selection_clear)
7854 (x_get_foreign_selection, Fx_disown_selection_internal)
7855 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7856 (lisp_data_to_selection_data): Use cons_to_unsigned.
7857 (x_fill_property_data): Use cons_to_signed.
7858 Report values out of range.
7859
d1f3d2af
PE
7860 Check for buffer and string overflow more precisely.
7861 * buffer.h (BUF_BYTES_MAX): New macro.
7862 * lisp.h (STRING_BYTES_MAX): New macro.
7863 * alloc.c (Fmake_string):
7864 * character.c (string_escape_byte8):
7865 * coding.c (coding_alloc_by_realloc):
7866 * doprnt.c (doprnt):
7867 * editfns.c (Fformat):
7868 * eval.c (verror):
7869 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7870 since they may not be the same number.
7871 * editfns.c (Finsert_char):
7872 * fileio.c (Finsert_file_contents):
7873 Likewise for BUF_BYTES_MAX.
7874
dd52fcea
PE
7875 * image.c: Use ptrdiff_t, not int, for sizes.
7876 (slurp_file): Switch from int to ptrdiff_t.
7877 All uses changed.
7878 (slurp_file): Check that file size fits in both size_t (for
7879 malloc) and ptrdiff_t (for sanity and safety).
7880
7f9bbdbb
PE
7881 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7882 if b->modtime has its maximal value.
7883
dfe18f82
PE
7884 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7885
84acfcf0
PE
7886 Don't assume time_t can fit into int.
7887 * buffer.h (struct buffer.modtime): Now time_t, not int.
7888 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7889 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7890
ccd9a01a
PE
7891 Minor fixes for signed vs unsigned integers.
7892 * character.h (MAYBE_UNIFY_CHAR):
7893 * charset.c (maybe_unify_char):
7894 * keyboard.c (read_char, reorder_modifiers):
7895 XINT -> XFASTINT, since the integer must be nonnegative.
7896 * ftfont.c (ftfont_spec_pattern):
7897 * keymap.c (access_keymap, silly_event_symbol_error):
7898 XUINT -> XFASTINT, since the integer must be nonnegative.
7899 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7900 since it makes no difference and we prefer signed.
7901 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7902 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7903 nonnegative.
7904
d6d100dd
SM
79052011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7906
7907 * window.h (Fwindow_frame): Declare.
7908
2b6148e4
PE
79092011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7910
7911 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7912 (SPARE_MEMORY): Always define.
7913 (LARGE_REQUEST): Remove.
7914 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7915
f230ecc9
MR
79162011-06-06 Martin Rudalics <rudalics@gmx.at>
7917
727e958e
MR
7918 * lisp.h: Move EXFUNS for Fframe_root_window,
7919 Fframe_first_window and Fset_frame_selected_window to window.h.
7920
7921 * window.h: Move EXFUNS for Fframe_root_window,
7922 Fframe_first_window and Fset_frame_selected_window here from
7923 lisp.h.
7924
7925 * frame.c (Fwindow_frame, Fframe_first_window)
7926 (Fframe_root_window, Fframe_selected_window)
7927 (Fset_frame_selected_window): Move to window.c.
7928 (Factive_minibuffer_window): Move to minibuf.c.
7929 (Fother_visible_frames_p): New function.
7930
7931 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7932
f230ecc9
MR
7933 * window.c (decode_window, decode_any_window): Move up in code.
7934 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7935 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7936 (Fwindow_buffer): Move up and rewrite doc-string.
7937 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7938 (Fwindow_prev): New functions.
727e958e
MR
7939 (Fwindow_frame): Move here from frame.c. Accept any window as
7940 argument.
7941 (Fframe_root_window, Fframe_first_window)
7942 (Fframe_selected_window): Move here from frame.c. Accept frame
7943 or arbitrary window as argument. Update doc-strings.
7944 (Fminibuffer_window): Move up in code.
7945 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7946 (Fset_frame_selected_window): Move here from frame.c.
7947 Marginal rewrite.
727e958e
MR
7948 (Fselected_window, select_window, Fselect_window): Move up in
7949 code. Minor doc-string fixes.
f230ecc9 7950
4d09bcf6
PE
79512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7952
7953 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7954 Do not assume that spare memory exists; that assumption is valid
7955 only if SYSTEM_MALLOC.
7956 (LARGE_REQUEST): New macro, so that the issue of large requests
7957 is separated from the issue of spare memory.
7958
810928a2
AS
79592011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7960
172418ad
AS
7961 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7962 format. (Bug#8806)
7963
43f862f7
AS
7964 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7965
810928a2
AS
7966 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7967 before statements.
7968
a059fe24
JD
79692011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7970
7971 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7972
7973 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7974
7975 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7976 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7977
989bf368
JB
79782011-06-05 Juanma Barranquero <lekktu@gmail.com>
7979
7980 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7981
4b80f674
CY
79822011-06-04 Chong Yidong <cyd@stupidchicken.com>
7983
7984 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7985 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7986 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7987 New error handlers.
4b80f674
CY
7988 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7989 Obey Vx_select_enable_clipboard_manager. Catch errors in
7990 x_clipboard_manager_save (Bug#8779).
7991 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7992 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7993
99a33b77 79942011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7995
7996 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7997
99a33b77 79982011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7999
8000 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8001 in the current matrix if keep_current_p is non-zero.
8002
8264569d
EZ
80032011-06-04 Eli Zaretskii <eliz@gnu.org>
8004
8005 * bidi.c (bidi_level_of_next_char): Fix last change.
8006
57f97249
EZ
80072011-06-03 Eli Zaretskii <eliz@gnu.org>
8008
fec2107c 8009 Support bidi reordering of text covered by display properties.
57f97249 8010
fec2107c
EZ
8011 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8012 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8013 (bidi_cache_search, bidi_cache_iterator_state)
8014 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8015 (bidi_level_of_next_char, bidi_move_to_visually_next):
8016 Support character positions inside a run of characters covered by a
fec2107c
EZ
8017 display string.
8018 (bidi_paragraph_init, bidi_resolve_explicit_1)
8019 (bidi_level_of_next_char): Call bidi_fetch_char and
8020 bidi_fetch_char_advance instead of FETCH_CHAR and
8021 FETCH_CHAR_ADVANCE.
8022 (bidi_init_it): Initialize new members.
8023 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8024 definitions.
8025 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8026 instead of using explicit *_CHAR codes.
d6d100dd
SM
8027 (bidi_resolve_explicit, bidi_resolve_weak):
8028 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8029 bidirectional text is supported only in multibyte buffers.
8030 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8031 it to initialize the frame_window_p member of struct bidi_it.
8032 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8033 (bidi_resolve_explicit, bidi_resolve_weak)
8034 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8035 bidi_it->nchars is non-positive.
8036 (bidi_level_of_next_char): Don't try to lookup the cache for the
8037 next/previous character if nothing is cached there yet, or if we
8038 were just reseat()'ed to a new position.
c40e2fb2 8039
0e14fe90
EZ
8040 * xdisp.c (set_cursor_from_row): Set start and stop points
8041 according to the row's direction when priming the loop that looks
8042 for the glyph on which to display cursor.
8043 (single_display_spec_intangible_p): Function deleted.
8044 (display_prop_intangible_p): Reimplement to call
8045 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8046 Accept 3 additional arguments needed by handle_display_spec.
8047 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8048 values: lists, `(when COND...)' forms, etc.
8049 (single_display_spec_string_p): Support property values that are
8050 lists with the argument STRING its top-level element.
8051 (display_prop_string_p): Fix the condition for processing a
8052 property that is a list to be consistent with handle_display_spec.
fec2107c 8053 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8054 last portion of handle_display_prop.
8055 (compute_display_string_pos): Accept additional argument
8056 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8057 value of a `display' property is a "replacing spec".
8058 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8059 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8060 the display property, but just return a value indicating whether
8061 the display property will replace the characters it covers.
8062 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8063 frame_window_p members of struct bidi_it.
d6d100dd
SM
8064 (compute_display_string_pos, compute_display_string_end):
8065 New functions.
fec2107c
EZ
8066 (push_it): Accept second argument POSITION, where pop_it should
8067 jump to continue iteration.
8068 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8069
fec2107c
EZ
8070 * keyboard.c (adjust_point_for_property): Adjust the call to
8071 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8072
8073 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8074 (bidi_init_it): Update prototypes.
8075 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8076 (compute_display_string_pos, compute_display_string_end):
8077 Declare prototypes.
fec2107c
EZ
8078 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8079 EMACS_INT.
fc6f18ce 8080
40087514 80812011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8082
57f53182
PE
8083 Malloc failure behavior now depends on size of allocation.
8084 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8085 * lisp.h: Change signatures accordingly.
8086 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8087 All callers changed. (Bug#8762)
8088
8089 * gnutls.c: Use Emacs's memory allocators.
8090 Without this change, the gnutls library would invoke malloc etc.
8091 directly, which causes problems on non-SYNC_INPUT hosts, and which
8092 runs afoul of improving memory_full behavior. (Bug#8761)
8093 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8094 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8095 xfree instead of the default malloc, realloc, free.
8096 (Fgnutls_boot): No need to check for memory allocation failure,
8097 since xmalloc does that for us.
8098
ac32cd99 8099 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8100 * category.c (hash_get_category_set):
8101 * ccl.c (ccl_driver):
8102 * charset.c (Fdefine_charset_internal):
8103 * charset.h (struct charset.hash_index):
8104 * composite.c (get_composition_id, gstring_lookup_cache)
8105 (composition_gstring_put_cache):
8106 * composite.h (struct composition.hash_index):
8107 * dispextern.h (struct image.hash):
8108 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8109 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8110 (hashfn_equal, hashfn_user_defined, make_hash_table)
8111 (maybe_resize_hash_table, hash_lookup, hash_put)
8112 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8113 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8114 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8115 * image.c (make_image, search_image_cache, lookup_image)
8116 (xpm_put_color_table_h):
8117 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8118 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8119 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8120 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8121 * alloc.c (allocate_vectorlike):
8122 Check for overflow in vector size calculations.
8123 * ccl.c (ccl_driver):
8124 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8125 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8126 need to be updated by these changes.
40087514
PE
8127 * fns.c (make_hash_table, maybe_resize_hash_table):
8128 Check for integer overflow with large hash tables.
0de4bb68
PE
8129 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8130 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8131 (SXHASH_REDUCE): New macro.
8132 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8133 Use it instead of discarding useful hash info with large hash values.
8134 (sxhash_float): New function.
8135 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8136 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8137 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8138 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8139 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8140 Adjust signatures to match updated version of code.
8141 (consing_since_gc): Now EMACS_INT, since a single hash table can
8142 use more than INT_MAX bytes.
8143
698d32e2
DN
81442011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8145
8146 Make it possible to build with GCC-4.6+ -O2 -flto.
8147
8148 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8149
fd6fa53f
SM
81502011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8151
8152 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8153 Call minibuffer-inactive-mode.
8154
864db017
JB
81552011-05-31 Juanma Barranquero <lekktu@gmail.com>
8156
8157 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8158 Update dependencies.
8159
2ad0baf4
DN
81602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8161
8162 * data.c (init_data): Remove code for UTS, this system is not
8163 supported anymore.
8164
4fcc2638
DN
81652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8166
8167 Don't force ./temacs to start in terminal mode.
8168
8169 * frame.c (make_initial_frame): Initialize faces in all cases, not
8170 only when CANNOT_DUMP is defined.
8171 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8172
c56e0fd5
DN
81732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8174
8175 * dispnew.c (add_window_display_history): Use const for the string
8176 pointer. Remove declaration, not needed.
8177
333d54da 81782011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8179
55d4c1b2 8180 Use 'inline', not 'INLINE'.
333d54da 8181 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8182 * alloc.c, fontset.c (INLINE): Remove.
8183 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8184 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8185 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8186 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8187 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8188
738db178
DN
81892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8190
8191 Make it possible to run ./temacs.
8192
8193 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8194 syms_of_callproc does the same thing. Remove test for
8195 "initialized", do it in the caller.
8196 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8197
620c53a6
SM
81982011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8199
8200 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8201 (read_minibuf): Use get_minibuffer.
8202 (syms_of_minibuf): Use DEFSYM.
8203 (Qmetadata): New var.
8204 * data.c (Qbuffer): Don't make it static.
8205 (syms_of_data): Use DEFSYM.
8206
e003a292
PE
82072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8208
8209 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8210 (CCL_CODE_MIN): New macro.
8211
ed008a6d
PE
82122011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8213
3687c2ef
PE
8214 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8215
ed008a6d
PE
8216 * eval.c (Qdebug): Now static.
8217 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8218 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8219 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8220
d66c4c7c
CY
82212011-05-29 Chong Yidong <cyd@stupidchicken.com>
8222
8223 * image.c: Various fixes to ImageMagick code comments.
8224 (Fimagemagick_types): Doc fix.
8225
5fbc2025
PE
82262011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8227
0196f88a
PE
8228 Minor fixes prompted by GCC 4.6.0 warnings.
8229
8230 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8231
5fbc2025
PE
8232 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8233 (x_clipboard_manager_save_all): Move extern decl to ...
8234 * xterm.h: ... here, so that it can be checked for consistency.
8235
1dd3c2d9
CY
82362011-05-29 Chong Yidong <cyd@stupidchicken.com>
8237
8238 * xselect.c (x_clipboard_manager_save_frame)
8239 (x_clipboard_manager_save_all): New functions.
8240 (Fx_clipboard_manager_save): Lisp function deleted.
8241
8242 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8243 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8244
8245 * xterm.h: Update prototype.
8246
5ba6571d
WX
82472011-05-28 William Xu <william.xwl@gmail.com>
8248
8249 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8250 exiting (Bug#8239).
8251
3eaff834
JM
82522011-05-28 Jim Meyering <meyering@redhat.com>
8253
e1900994 8254 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8255 * fns.c (to_uchar): Define.
8256 (crypto_hash_function): Use it to convert some newly-signed
8257 variables to unsigned, to avoid sign-extension bugs. For example,
8258 without this change, (md5 "truc") would evaluate to
8259 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8260 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8261 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8262
0f6990a7
PE
82632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8264
8265 Integer overflow fixes.
c8a9ca5a 8266
08686060
PE
8267 * dbusbind.c: Serial number integer overflow fixes.
8268 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8269 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8270 to hold a serial number that is too large for a fixnum.
8271 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8272 Check for serial numbers out of range. Decode any serial number
59568bf0 8273 that was so large that it became a float. (Bug#8722)
08686060 8274
2d1fc3c7
PE
8275 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8276 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8277 Use XFASTINT rather than XUINT when numbers are nonnegative.
8278 (xd_append_arg, Fdbus_method_return_internal):
8279 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8280 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8281 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8282 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8283 (Bug#8722)
2d1fc3c7 8284
c8a9ca5a
PE
8285 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8286
519e1d69
PE
8287 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8288
6df6ae42 8289 ccl: Add integer overflow checks.
30569699
PE
8290 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8291 (IN_INT_RANGE): New macros.
8292 (ccl_driver): Use them to check for integer overflow when
8293 decoding a CCL program. Many of the new checks are whether XINT (x)
8294 fits in int; it doesn't always, on 64-bit hosts. The new version
8295 doesn't catch all possible integer overflows, but it's an
847044ea 8296 improvement. (Bug#8719)
30569699 8297
c11285dc
PE
8298 * alloc.c (make_event_array): Use XINT, not XUINT.
8299 There's no need for unsigned here.
8300
fdccd48e
PE
8301 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8302 This follows up to the 2011-05-06 change that substituted uintptr_t
8303 for EMACS_INT. This case wasn't caught back then.
8304
37910ab2
PE
8305 Rework Fformat to avoid integer overflow issues.
8306 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8307 now (part of C89). Include <verify.h>.
8308 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8309 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8310 (Fformat): Avoid the prepass trying to compute sizes; it was only
8311 approximate and thus did not catch overflow reliably. Instead, walk
8312 through the format just once, formatting and computing sizes as we go,
8313 checking for integer overflow at every step, and allocating a larger
8314 buffer as needed. Keep track separately whether the format is
8315 multibyte. Keep only the most-recently calculated precision, rather
8316 than them all. Record whether each argument has been converted to
8317 string. Use EMACS_INT, not int, for byte and char and arg counts.
8318 Support field widths and precisions larger than INT_MAX. Avoid
8319 sprintf's undefined behavior with conversion specifications such as %#d
8320 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8321 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8322 formatting out-of-range floating point numbers with int
9173deec 8323 formats. (Bug#8668)
37910ab2 8324
2e6578fb
PE
8325 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8326
0ae6bdee
PE
8327 * data.c: Avoid integer truncation in expressions involving floats.
8328 * data.c: Include <intprops.h>.
8329 (arith_driver): When there's an integer overflow in an expression
8330 involving floating point, convert the integers to floating point
8331 so that the resulting value does not suffer from catastrophic
8332 integer truncation. For example, on a 64-bit host (* 4
8333 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8334 Do not rely on undefined behavior after integer overflow.
8335
de883a70
PE
8336 merge count_size_as_multibyte, parse_str_to_multibyte
8337 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8338 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8339 Check for integer overflow.
8340 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8341 since it's now a duplicate of the other. This is more of
8342 a character than a buffer op, so better that it's in character.c.
8343 * fns.c, print.c: Adjust to above changes.
8344
2ff916cb
PE
83452011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8346
8347 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8348
f1b54466
PE
83492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8350
fb1ac845
PE
8351 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8352 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8353 (x_clipboard_manager_save): Now static.
8354 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8355
f1b54466
PE
8356 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8357 (crypto_hash_function): Now static.
8358 Fix pointer signedness problems. Avoid unnecessary initializations.
8359
a9f737ee
CY
83602011-05-27 Chong Yidong <cyd@stupidchicken.com>
8361
8362 * termhooks.h (Vselection_alist): Make it terminal-local.
8363
8364 * terminal.c (create_terminal): Initialize it.
8365
8366 * xselect.c: Support for clipboard managers.
8367 (Vselection_alist): Move to termhooks.h as terminal-local var.
8368 (LOCAL_SELECTION): New macro.
8369 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8370 (symbol_to_x_atom): Remove gratuitous arg.
8371 (x_handle_selection_request, lisp_data_to_selection_data)
8372 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8373 (x_own_selection, x_get_local_selection, x_convert_selection):
8374 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8375 (some_frame_on_display): Delete unused function.
8376 (Fx_own_selection_internal, Fx_get_selection_internal)
8377 (Fx_disown_selection_internal, Fx_selection_owner_p)
8378 (Fx_selection_exists_p): New optional frame arg.
8379 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8380 (x_handle_selection_clear): Don't treat other terminals with the
8381 same keyboard specially. Use the terminal-local Vselection_alist.
8382 (x_clear_frame_selections): Use Frun_hook_with_args.
8383
8384 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8385
8386 * xterm.h: Add support for those atoms.
8387
e067f0c1
CY
83882011-05-26 Chong Yidong <cyd@stupidchicken.com>
8389
8390 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8391 (converted_selections, conversion_fail_tag): New global variables.
8392 (x_selection_request_lisp_error): Free the above.
8393 (x_get_local_selection): Remove unnecessary code.
8394 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8395 of converted selections stored in converted_selections.
8396 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8397 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8398 (x_convert_selection): New function.
8399 (x_handle_selection_event): Simplify.
8400 (x_get_foreign_selection): Don't ignore incoming requests while
8401 waiting for an answer; this will fail when we implement
8402 SAVE_TARGETS, and seems unnecessary anyway.
8403 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8404 (Vx_sent_selection_functions): Doc fix.
8405
0f4aebc0
LL
84062011-05-26 Leo Liu <sdl.web@gmail.com>
8407
8408 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8409
e61124cd
YM
84102011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8411
8412 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8413
8414 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8415 for fringe update if it has periodic bitmap.
ac389d0c 8416 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8417 and fringe_bitmap_periodic_p.
8418
8419 * fringe.c (get_fringe_bitmap_data): New function.
8420 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8421 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8422 row. Mark glyph row for fringe update if periodicity changed.
8423
8424 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8425 for fringe update unless it has periodic bitmap.
8426
f16d9837
KH
84272011-05-25 Kenichi Handa <handa@m17n.org>
8428
8429 * xdisp.c (get_next_display_element): Set correct it->face_id for
8430 a static composition.
8431
e1b90ef6
LL
84322011-05-24 Leo Liu <sdl.web@gmail.com>
8433
8434 * deps.mk (fns.o):
8435 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8436
8437 * fns.c (crypto_hash_function, Fsha1): New function.
8438 (Fmd5): Use crypto_hash_function.
8439 (syms_of_fns): Add Ssha1.
8440
7400048f
PE
84412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8442
8443 * gnutls.c: Remove unused macros.
8444 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8445 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8446 Remove macros that are defined and never used.
8447 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8448
abb71cf4
CY
84492011-05-22 Chong Yidong <cyd@stupidchicken.com>
8450
8451 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8452 (Fx_get_selection_internal): Minor cleanup.
8453 (Fx_own_selection_internal): Rename arguments for consistency with
8454 select.el.
8455
6307db39
PE
84562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8457
8458 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8459
f3d4e0a4
CY
84602011-05-22 Chong Yidong <cyd@stupidchicken.com>
8461
8462 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8463
4d8ade89
YM
84642011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8465
8466 * dispnew.c (scrolling_window): Don't exclude the case that the
8467 last enabled row in the desired matrix touches the bottom boundary.
8468
32078c8d
GM
84692011-05-21 Glenn Morris <rgm@gnu.org>
8470
8471 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8472 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8473 and add some more files.
32078c8d 8474
7285dc67
EZ
84752011-05-20 Eli Zaretskii <eliz@gnu.org>
8476
8477 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8478 report_file_error introduced by the change from 2011-05-07.
8479
89d1bd22
PE
84802011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8481
8482 * systime.h (Time): Define only if emacs is defined.
8483 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8484 where the include path doesn't have X11/X.h by default. See
8485 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8486
cd394be1 84872011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8488
8489 * composite.c (find_automatic_composition): Fix previous change.
8490
b9704ad9
GM
84912011-05-20 Glenn Morris <rgm@gnu.org>
8492
8493 * lisp.mk: New file, split from Makefile.in.
8494 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8495 (shortlisp): Remove.
8496 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8497
4a720484
GM
84982011-05-19 Glenn Morris <rgm@gnu.org>
8499
8500 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8501 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8502 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8503 (lisp): Set the order to that of loadup.el.
8504 (shortlisp): Make it a copy of $lisp.
8505 (SOME_MACHINE_LISP): Remove.
8506 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8507 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8508
a28d4396
KH
85092011-05-18 Kenichi Handa <handa@m17n.org>
8510
8511 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8512 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8513 (find_automatic_composition): Mostly rewrite for efficiency.
8514
a2b1fa8e
JB
85152011-05-18 Juanma Barranquero <lekktu@gmail.com>
8516
8517 * makefile.w32-in: Update dependencies.
8518
8e1f5610
CS
85192011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8520
8521 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8522 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8523
7025ee00 85242011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8525
cdfa6eab
PE
8526 Fix some integer overflow issues, such as string length overflow.
8527
06d6db33
PE
8528 * insdel.c (count_size_as_multibyte): Check for string overflow.
8529
2b4560a8
PE
8530 * character.c (lisp_string_width): Check for string overflow.
8531 Use EMACS_INT, not int, for string indexes and lengths; in
8532 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8533 the resulting string length overflows an EMACS_INT; instead,
8534 report a string overflow if no precision given. When checking for
8535 precision exhaustion, use a check that cannot possibly have
8536 integer overflow. (Bug#8675)
8537 * character.h (lisp_string_width): Adjust to new signature.
8538
cb93f9be
PE
8539 * alloc.c (string_overflow): New function.
8540 (Fmake_string): Use it. This doesn't change behavior, but saves
8541 a few bytes and will simplify future changes.
8542 * character.c (string_escape_byte8): Likewise.
8543 * lisp.h (string_overflow): New decl.
8544
1a1f3366
PE
8545 Fixups, following up to the user-interface timestamp change.
8546 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8547 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8548 * msdos.c (mouse_get_pos): Likewise.
8549 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8550 * w32gui.h (Time): Define by including "systime.h" rather than by
8551 declaring it ourselves. (Bug#8664)
8552
d4e3e4d3
PE
8553 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8554 * image.c (clear_image_cache): Likewise.
8555
f6a24d19
PE
8556 * term.c (term_mouse_position): Don't assume time_t wraparound.
8557
08dc5ae6
PE
8558 Be more systematic about user-interface timestamps.
8559 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8560 and sometimes 'EMACS_UINT', to represent these timestamps.
8561 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8562 This makes the code easier to follow, and makes it easier to catch
8563 integer overflow bugs such as Bug#8664.
8564 * frame.c (Fmouse_position, Fmouse_pixel_position):
8565 Use Time, not unsigned long, for user-interface timestamps.
8566 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8567 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8568 * keyboard.h (last_event_timestamp): Likewise.
8569 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8570 * menu.h (xmenu_show): Likewise.
8571 * term.c (term_mouse_position): Likewise.
8572 * termhooks.h (struct input_event.timestamp): Likewise.
8573 (struct terminal.mouse_position_hook): Likewise.
8574 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8575 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8576 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8577 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8578 what it was before.
8579 * menu.h, termhooks.h: Include "systime.h", for Time.
8580
8e55734a
PE
8581 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8582 Don't assume that the difference between two unsigned long values
8583 can fit into an integer. At this point, we know button_down_time
8584 <= event->timestamp, so the difference must be nonnegative, so
8585 there's no need to cast the result if double-click-time is
8586 nonnegative, as it should be; check that it's nonnegative, just in
8587 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8588 apart (about 25 days). (Bug#8664)
8e55734a 8589
841f1b75 8590 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8591 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8592
3e26f69c
PE
8593 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8594 that always fit in int. Use a sentinel instead of a counter, to
8595 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8596 * frame.h (struct frame): Use int for menu_bar_items_used
8597 instead of EMACS_INT, since it always fits in int.
3e26f69c 8598
5cc152c0
PE
8599 * menu.c (grow_menu_items): Check for int overflow.
8600
d89eb65e
PE
8601 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8602
5235bd3e
PE
8603 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8604 Before, the code was not consistent. These values cannot exceed
8605 2**31 - 1 so there's no need to make them unsigned.
8606 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8607 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8608 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8609 as modifiers.
8610 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8611
bc827e23
PE
8612 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8613 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8614 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8615 presumably because the widths might not match.
8616
78eb494e
PE
8617 * window.c (size_window): Avoid needless test at loop start.
8618
04f2d78b
CB
86192011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8620
8621 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8622
d2fc7e3d 86232011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8624
8625 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8626
d2fc7e3d 86272011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8628
8629 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8630 `width' to `bar_area_x' and `bar_area_width', respectively.
8631 (x_scroll_run): Take account of fringe background extension.
8632
04f2d78b
CB
8633 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8634 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8635 `bar_area_width', respectively.
8636 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8637 background extension.
8638
79b70037
GM
86392011-05-10 Jim Meyering <meyering@redhat.com>
8640
8641 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8642
2f142cc5
JB
86432011-05-10 Juanma Barranquero <lekktu@gmail.com>
8644
8645 * image.c (Finit_image_library): Return t for built-in image types,
8646 like pbm and xbm. (Bug#8640)
8647
57679c86
AS
86482011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8649
8650 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8651
888c9e86
EZ
86522011-05-07 Eli Zaretskii <eliz@gnu.org>
8653
b0512a1d
EZ
8654 * w32console.c (Fset_screen_color): Doc fix.
8655 (Fget_screen_color): New function.
8656 (syms_of_ntterm): Defsubr it.
8657
7285dc67
EZ
8658 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8659 unlink the temporary file if Fcall_process didn't create it in the
8660 first place.
8661 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8662 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8663 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8664 cue to call_process_cleanup not to close that handle.
8665
4d3fcc8e
BK
86662011-05-07 Ben Key <bkey76@gmail.com>
8667
8668 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8669 one of two shell specific rules, either bootstrap-temacs-CMD or
8670 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8671 to the previous implementation of the bootstrap-temacs rule.
8672 The bootstrap-temacs-CMD rule is similar to the previous
8673 implementation of the bootstrap-temacs rule except that it
8674 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8675 variable.
8676
8677 These changes, along with some changes to nt/configure.bat,
8678 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8679 earlier fix to add support for --cflags and --ldflags options
8680 that include quotes so that it works whether make uses cmd or
8681 sh as the shell.
8682
b4289b64
MA
86832011-05-06 Michael Albinus <michael.albinus@gmx.de>
8684
8685 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8686 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8687 is a constant.
8688 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8689 a string. Handle both cases.
8690 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8691 (Fdbus_register_method): Use Qinvalid_function.
8692
af4c0e28
JB
86932011-05-06 Juanma Barranquero <lekktu@gmail.com>
8694
8695 * makefile.w32-in: Update dependencies.
8696 (LISP_H): Add inttypes.h and stdin.h.
8697 (PROCESS_H): Add unistd.h.
8698
c51453d9
EZ
86992011-05-06 Eli Zaretskii <eliz@gnu.org>
8700
8701 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8702 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8703
8ff0ac3c 87042011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8705
4c4b566b
PE
8706 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8707
aab2b9b5
PE
8708 * term.c (vfatal): Remove stray call to va_end.
8709 It's not needed and the C Standard doesn't allow it here anyway.
8710
c378da0b
PE
8711 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8712 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8713
288b08c7
PE
8714 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8715 bytes.
8716
e3601888
PE
8717 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8718
db6c0e74
PE
8719 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8720
dd5963ea
PE
8721 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8722
88c9450f
PE
8723 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8724
2f9442b8
PE
8725 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8726
c032b5f8
PE
8727 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8728 * charset.c (Fdefine_charset_internal): Don't initialize
8729 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8730 32-bit int (Bug#8600).
a108c10b
PE
8731
8732 * lread.c (read_integer): Be more consistent with string-to-number.
8733 Use string_to_number to do the actual conversion; this avoids
8734 rounding errors and fixes some other screwups. Without this fix,
8735 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8736 (digit_to_number): Move earlier, for benefit of read_integer.
8737 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8738 not a digit in any supported base. (Bug#8602)
a108c10b 8739
ad5f9eea
PE
8740 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8741
aec1708a
PE
8742 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8743 to match comment at start of function. This also removes a
8744 GCC warning about overflow in a 32+64-bit port.
8745
47be4ab5
PE
8746 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8747
371cac43
PE
8748 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8749 Reported by Stefan Monnier in
8750 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8751 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8752 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8753
d01a7826
PE
8754 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8755 (EMACS_UINTPTR): Likewise, with uintptr_t.
8756
7fd47d5c
PE
8757 * lisp.h: Prefer 64-bit EMACS_INT if available.
8758 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8759 on 32-bit hosts that have 64-bit int, so that they can access
8760 large files.
122b0c86
PE
8761 However, temporarily disable this change unless the temporary
8762 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8763
8727937b
PE
8764 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8765
8ac068ac
PE
8766 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8767 This removes an assumption that EMACS_INT and long are the same
8768 width as pointers. The assumption is true for Emacs porting targets
8769 now, but we want to make other targets possible.
8770 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8771 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8772 In the rest of the code, change types of integers that hold casted
8773 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8774 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8775 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8776 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8777 No need to cast type when ORing.
8778 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8779 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8780 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8781 assume EMACS_INT is the same width as char *.
8782 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8783 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8784 Remove no-longer-needed casts.
8785 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8786 (xg_tool_bar_help_callback, xg_make_tool_item):
8787 Use EMACS_INTPTR to hold an integer
8788 that will be cast to void *; this can avoid a GCC warning
8789 if EMACS_INT is not the same width as void *.
8790 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8791 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8792 (current_message_1, set_message_1):
8793 Use a local to convert to proper width without a cast.
8794 * xmenu.c (dialog_selection_callback): Likewise.
8795
ede49d71
PE
8796 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8797 Also, don't assume VALBITS / RAND_BITS is less than 5,
8798 and don't rely on undefined behavior when shifting a 1 left into
8799 the sign bit.
8800 * lisp.h (get_random): Change signature to match.
8801
2f30ecd0
PE
8802 * lread.c (hash_string): Use size_t, not int, for hash computation.
8803 Normally we prefer signed values; but hashing is special, because
8804 it's better to use unsigned division on hash table sizes so that
8805 the remainder is nonnegative. Also, size_t is the natural width
8806 for hashing into memory. The previous code used 'int', which doesn't
8807 retain enough info to hash well into very large tables.
8808 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8809
2a866e7b
PE
8810 * dbusbind.c: Don't possibly lose pointer info when converting.
8811 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8812 Use XPNTR rather than XHASH, so that the high-order bits of
8813 the pointer aren't lost when converting through void *.
8814
51639eac
PE
8815 * eval.c (Fautoload): Don't double-shift a pointer.
8816
92394119
PE
8817 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8818
dbdb9a7c
JB
88192011-05-06 Juanma Barranquero <lekktu@gmail.com>
8820
8821 * gnutls.c (DEF_GNUTLS_FN):
8822 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8823
db7a0b4f
AS
88242011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8825
8826 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8827 marker. (Bug#8610)
8828
cd394be1 88292011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8830
8831 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8832 New version that can reserve upto 2GB of heap space.
8833
f7ff1b0f 88342011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8835
8836 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8837
639c109b
TZ
88382011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8839
8840 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8841 `gnutls_certificate_set_x509_key_file'.
8842
d2127135
JB
88432011-05-05 Juanma Barranquero <lekktu@gmail.com>
8844
8845 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8846 Update dependencies.
8847
e968f4f3
JB
88482011-05-04 Juanma Barranquero <lekktu@gmail.com>
8849
8850 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8851 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8852 Remove unused parameter `fildes'.
8853 * process.c (read_process_output, send_process): Don't pass it.
8854
84d358f0
JB
88552011-05-04 Juanma Barranquero <lekktu@gmail.com>
8856
8857 Fix previous change: the library cache is defined in w32.c.
8858 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8859 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8860
0898ca10
JB
88612011-05-04 Juanma Barranquero <lekktu@gmail.com>
8862
8863 Implement dynamic loading of GnuTLS on Windows.
8864
8865 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8866 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8867 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8868 Declare.
8869
8870 * gnutls.c (Qgnutls_dll): Define.
8871 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8872 (gnutls_*): Declare function pointers.
8873 (init_gnutls_functions): New function to initialize function pointers.
8874 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8875 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8876 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8877 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8878 (emacs_gnutls_write, emacs_gnutls_read)
8879 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8880 (Fgnutls_available_p): New function.
8881 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8882 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8883 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8884
8885 * image.c: Include w32.h.
8886 (Vimage_type_cache): Delete.
8887 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8888 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8889 (w32_delayed_load): Move to w32.c.
8890
8891 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8892
8893 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8894 (w32_delayed_load): Move from image.c. When loading a library, record
8895 its filename in the :loaded-from property of the library id.
8896 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8897 Initialize and staticpro them.
8898 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8899
8900 * process.c: Include lisp.h before w32.h, not after.
8901 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8902 instead of gnutls_record_check_pending.
8903
8904 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8905
ff4de4aa
TZ
89062011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8907
8908 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8909 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8910 as passed in.
8911
abe95abb
JD
89122011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8913
8914 * xterm.c (x_set_frame_alpha): Do not set property on anything
8915 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8916
e16e55d4
JB
89172011-05-02 Juanma Barranquero <lekktu@gmail.com>
8918
8919 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8920
bafcf6a5
JB
89212011-05-02 Juanma Barranquero <lekktu@gmail.com>
8922
8923 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8924 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8925 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8926 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8927 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8928 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8929 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8930 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8931 (Qgnutls_bootprop_callbacks_verify): Make static.
8932
e7a6747f
AS
89332011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8934
19ed11ba
AS
8935 * callproc.c: Indentation fixup.
8936
e7a6747f 8937 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8938 (wait_for_termination, interruptible_wait_for_termination):
8939 Move after wait_for_termination_1.
e7a6747f 8940
1ef14cb4
LMI
89412011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8942
8943 * sysdep.c (interruptible_wait_for_termination): New function
8944 which is like wait_for_termination, but allows keyboard
8945 interruptions.
8946
8947 * callproc.c (Fcall_process): Add (:file "file") as an option for
8948 the STDOUT buffer.
8949 (Fcall_process_region): Ditto.
8950
330d880c
EZ
89512011-04-30 Eli Zaretskii <eliz@gnu.org>
8952
8db90b73
EZ
8953 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8954 rather than `XVECTOR (FOO)->size'.
8955
330d880c
EZ
8956 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8957 inttypes.h, as a gnulib replacement is used if it not available in
8958 system headers.
8959
15cbd324
EZ
89602011-04-21 Eli Zaretskii <eliz@gnu.org>
8961
8962 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8963 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8964 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8965
8966 * coding.c (coding_alloc_by_realloc): Error out if destination
8967 will grow beyond MOST_POSITIVE_FIXNUM.
8968 (decode_coding_emacs_mule): Abort if there isn't enough place in
8969 charbuf for the composition carryover bytes. Reserve an extra
8970 space for up to 2 characters produced in a loop.
8971 (decode_coding_iso_2022): Abort if there isn't enough place in
8972 charbuf for the composition carryover bytes.
8973
89742011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8975
ae940cca
EZ
8976 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8977 aborting when %lld or %lll format is passed.
8978 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8979 %llo or %llx format is passed. (Bug#8545)
8980
03ab8921
EZ
8981 * window.c (window_scroll_line_based): Use a marker instead of
8982 simple variables to record original value of point. (Bug#7952)
8983
afda1437
EZ
8984 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8985 produced by %s or %c overflows available buffer space. (Bug#8545)
8986
f76dee0c
PE
89872011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8988
8989 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8990 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8991
fdc5744d
JB
89922011-04-28 Juanma Barranquero <lekktu@gmail.com>
8993
8994 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8995
638f053a
JB
89962011-04-28 Juanma Barranquero <lekktu@gmail.com>
8997
8998 * keyboard.c (Qdelayed_warnings_hook): Define.
8999 (command_loop_1): Run `delayed-warnings-hook'
9000 if Vdelayed_warnings_list is non-nil.
9001 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9002 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9003
d178f871
EZ
90042011-04-28 Eli Zaretskii <eliz@gnu.org>
9005
9006 * doprnt.c (doprnt): Don't return value smaller than the buffer
9007 size if the message was truncated. (Bug#8545).
9008
b124fd93
JB
90092011-04-28 Juanma Barranquero <lekktu@gmail.com>
9010
9011 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9012 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9013
e810457d
PE
90142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9015
9016 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9017
ea51cceb
JB
90182011-04-27 Juanma Barranquero <lekktu@gmail.com>
9019
9020 * makefile.w32-in: Update dependencies.
9021
94dcfacf
EZ
90222011-04-27 Eli Zaretskii <eliz@gnu.org>
9023
9024 Improve `doprnt' and its usage. (Bug#8545)
9025 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9026 `format_end'. Remove support for %l as a conversion specifier.
9027 Don't use xrealloc. Improve diagnostics when the %l size modifier
9028 is used. Update the commentary.
9029
9030 * eval.c (verror): Simplify calculation of size_t.
9031
9032 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9033 messages.
9034
f61f41d7
PE
90352011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9036
9037 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9038 change.
9039
96fb4434
PE
90402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9041
9042 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9043 This makes this file independent of the recent pseudovector change.
9044
671875da 90452011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9046
69e9b5a3
PE
9047 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9048
b5f869a7 9049 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9050 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9051 Remove unused local.
c8926152 9052 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9053
841a1577 9054 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9055 GCC 4.6.0 optimizes based on type-based alias analysis.
9056 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9057 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9058 != &v->size, and therefore "v->size = 1; b->size = 2; return
9059 v->size;" must therefore return 1. This assumption is incorrect
9060 for Emacs, since it type-puns struct Lisp_Vector * with many other
9061 types. To fix this problem, this patch adds a new type struct
f904488f 9062 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9063 and pseudovectors, and helps optimizing compilers not get fooled
9064 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9065 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9066 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9067 the size member.
eab3844f
PE
9068 (XSETPVECTYPE): Rewrite in terms of new macro.
9069 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9070 This is a bit clearer, and further avoids the possibility of
9071 undesirable aliasing.
9072 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9073 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9074 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9075 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9076 (ASIZE): Now uses header.size rather than size.
9077 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9078 to avoid the hassle of writing XVECTOR (foo)->header.size.
9079 (struct vectorlike_header): New type.
eab3844f
PE
9080 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9081 object, to help avoid aliasing.
9082 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9083 (SUBRP): Likewise, since Lisp_Subr is a special case.
9084 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9085 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9086 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9087 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9088 changed to be "header.size" and "header.next".
9089 * buffer.h (struct buffer): Likewise.
9090 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9091 * frame.h (struct frame): Likewise.
9092 * process.h (struct Lisp_Process): Likewise.
9093 * termhooks.h (struct terminal): Likewise.
9094 * window.c (struct save_window_data, struct saved_window): Likewise.
9095 * window.h (struct window): Likewise.
9096 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9097 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9098 * buffer.c (init_buffer_once): Likewise.
9099 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9100 special case.
9101 * process.c (Fformat_network_address): Use local var for size,
9102 for brevity.
9103
0df1eac5
PE
9104 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9105
847ab9d1 9106 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9107 * data.c (atof): Remove decl; no longer used or needed.
9108 (digit_to_number): Move to lread.c.
9109 (Fstring_to_number): Use new string_to_number function, to be
9110 consistent with how the Lisp reader treats infinities and NaNs.
9111 Do not assume that floating-point numbers represent EMACS_INT
9112 without losing information; this is not true on most 64-bit hosts.
9113 Avoid double-rounding errors, by insisting on integers when
9114 parsing non-base-10 numbers, as the documentation specifies.
9115 * lisp.h (string_to_number): New decl, replacing ...
9116 (isfloat_string): Remove.
bc0a5c13 9117 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9118 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9119 appears to have been a coding error. Similarly, do not accept
9120 strings like +-1e0 as floating point numbers. Do not report
9121 overflow for integer overflows unless the base is not 10 which
9122 means we have no simple and reliable way to continue.
9123 Break out the floating-point parsing into a new
9124 function string_to_number, so that Fstring_to_number parses
9125 floating point numbers consistently with the Lisp reader.
04f2d78b 9126 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9127 (E_CHAR, EXP_INT): Remove, replacing with ...
9128 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9129 (string_to_number): New function, replacing isfloat_string.
9130 This function checks for valid syntax and produces the resulting
9131 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9132 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9133 so that overflow for non-base-10 numbers is reported only when
9134 there's no portable and simple way to convert to floating point.
452f4150 9135
67769ffc
PE
9136 * textprop.c (set_text_properties_1): Rewrite for clarity,
9137 and to avoid GCC warning about integer overflow.
9138
c20db43f
PE
9139 * intervals.h (struct interval): Use EMACS_INT for members
9140 where EMACS_UINT might cause problems. See
9141 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9142 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9143 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9144 All uses changed.
37aa2f85
PE
9145 (offset_intervals): Tell GCC not to worry about length overflow
9146 when negating a negative length.
c20db43f 9147
2538aa2f
PE
9148 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9149 (overrun_check_free): Likewise.
9150
f2d3008d
PE
9151 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9152 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9153 word size.
9154
ec8df744
PE
9155 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9156 (gnutls_make_error): Rename local to avoid shadowing.
9157 (gnutls_emacs_global_deinit): ifdef out; not used.
9158 (Fgnutls_boot): Use const for pointer to readonly storage.
9159 Comment out unused local. Fix pointer signedness problems.
9160
640ee02d
PE
9161 * lread.c (openp): Don't stuff size_t into an 'int'.
9162 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9163 about possible signed overflow.
9164
6048fb2a
PE
9165 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9166 (GDK_KEY_g): Don't define if already defined.
9167 (xg_prepare_tooltip): Avoid pointer signedness problem.
9168 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9169
fa3c87e1
PE
9170 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9171 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9172
2172544b
PE
9173 * xfns.c (Fx_window_property): Simplify a bit,
9174 to make a bit faster and to avoid GCC 4.6.0 warning.
9175 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9176
9b821a21
PE
9177 * fns.c (internal_equal): Don't assume size_t fits in int.
9178
3c616cfa
PE
9179 * alloc.c (compact_small_strings): Tighten assertion a little.
9180
c2982e87
PE
9181 Replace pEd with more-general pI, and fix some printf arg casts.
9182 * lisp.h (pI): New macro, generalizing old pEd macro to other
9183 conversion specifiers. For example, use "...%"pI"d..." rather
9184 than "...%"pEd"...".
9185 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9186 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9187 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9188 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9189 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9190 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9191 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9192 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9193 64-bit hosts.
9194 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9195 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9196 * print.c (safe_debug_print, print_object): Likewise.
9197 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9198 to int.
6f04d126
PE
9199 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9200 avoiding the 0 flag, which is not portable.
c2982e87
PE
9201 * process.c (Fmake_network_process): Use pI to avoid cast.
9202 * region-cache.c (pp_cache): Likewise.
9203 * xdisp.c (decode_mode_spec): Likewise.
9204 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9205 behavior on 64-bit hosts with printf arg.
6f04d126 9206 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9207 (x_stop_queuing_selection_requests): Likewise.
9208 (x_get_window_property): Don't truncate byte count to an 'int'
9209 when tracing.
0b432f21 9210
5e073ec7
PE
9211 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9212 here, since it parses constructs like leading '-' and spaces,
9213 which are not wanted; and it overflows with large numbers.
9214 Instead, simply match F[0-9]+, which is what is wanted anyway.
9215
36372bf9
PE
9216 * alloc.c: Remove unportable assumptions about struct layout.
9217 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9218 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9219 (allocate_vectorlike, make_pure_vector): Use the new macros,
9220 plus offsetof, to remove unportable assumptions about struct layout.
9221 These assumptions hold on all porting targets that I know of, but
9222 they are not guaranteed, they're easy to remove, and removing them
9223 makes further changes easier.
9224
0b432f21
PE
9225 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9226 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9227 (string_overrun_cookie): Now const. Use initializers that
9228 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9229 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9230 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9231 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9232 multiple of sizeof (EMACS_INT); it need not be, if
9233 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9234 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9235
895009e1
JB
92362011-04-26 Juanma Barranquero <lekktu@gmail.com>
9237
9238 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9239
6a7a1b0b
TZ
92402011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9241
9242 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9243 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9244 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9245
841a1577 92462011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9247
9248 * lisp.h (Qdebug): List symbol.
895009e1 9249 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9250 * keyboard.c (debug-on-event): New variable.
9251 (handle_user_signal): Break into debugger when debug-on-event
9252 matches the current signal symbol.
9253
f2d3ba6f
DN
92542011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9255
9256 * alloc.c (check_sblock, check_string_bytes)
9257 (check_string_free_list): Convert to standard C.
9258
42ce4c63
TZ
92592011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9260
9261 * w32.c (emacs_gnutls_push): Fix typo.
9262
825cd63c
EZ
92632011-04-25 Eli Zaretskii <eliz@gnu.org>
9264
fb11d64d
EZ
9265 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9266 "cast to pointer from integer of different size".
9267
825cd63c
EZ
9268 Improve doprnt and its use in verror. (Bug#8545)
9269 * doprnt.c (doprnt): Document the set of format control sequences
9270 supported by the function. Use SAFE_ALLOCA instead of always
9271 using `alloca'.
9272
9273 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9274 is one byte too soon. Don't use xrealloc; instead xfree and
9275 xmalloc anew.
9276
e061a11b
TZ
92772011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9278
9279 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9280 callbacks stage.
9281
9282 * gnutls.c: Renamed global_initialized to
9283 gnutls_global_initialized. Added internals for the
9284 :verify-hostname-error, :verify-error, and :verify-flags
9285 parameters of `gnutls-boot' and documented those parameters in the
9286 docstring. Start callback support.
9173deec
JB
9287 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9288 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9289 on error. Return error code.
e061a11b
TZ
9290 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9291 (emacs_gnutls_read): Likewise.
9292 (Fgnutls_boot): Return handshake error code.
9293 (emacs_gnutls_handle_error): New function.
9294 (wsaerror_to_errno): Likewise.
9295
9296 * w32.h (emacs_gnutls_pull): Add prototype.
9297 (emacs_gnutls_push): Likewise.
9298
9299 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9300 (emacs_gnutls_push): Likewise.
9301
93022011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9303
9304 * process.c (wait_reading_process_output): Check if GnuTLS
9305 buffered some data internally if no FDs are set for TLS
9306 connections.
9307
9308 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9309 (LIBS): Link to USER_LIBS.
9310 ($(BLD)/gnutls.$(0)): New target.
9311
fa6996bc
EZ
93122011-04-24 Eli Zaretskii <eliz@gnu.org>
9313
eb35682e
EZ
9314 * xdisp.c (handle_single_display_spec): Rename the
9315 display_replaced_before_p argument into display_replaced_p, to
9316 make it consistent with the commentary. Fix typos in the
9317 commentary.
9318
e2ad650c
EZ
9319 * textprop.c (syms_of_textprop): Remove dead code.
9320 (copy_text_properties): Delete obsolete commentary about an
9321 interface that was deleted long ago. Fix typos in the description
9322 of arguments.
9323
1b2de274
EZ
9324 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9325 to changes in oldXMenu/XMenu.h from 2011-04-16.
9326 <menu_help_message, prev_menu_help_message>: Constify.
9327 (IT_menu_make_room): menu->help_text is now `const char **';
9328 adjust.
9329
9330 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9331 to changes in oldXMenu/XMenu.h from 2011-04-16.
9332 (struct XMenu): Declare `help_text' `const char **'.
9333
9334 * xfaces.c <Qunspecified>: Make extern again.
9335
9336 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9337 required by POSIX.
1b2de274 9338
762b15be
EZ
9339 * doc.c (get_doc_string): Improve the format passed to `error'.
9340
9341 * doprnt.c (doprnt): Improve commentary.
9342
9343 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9344
9345 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9346 them with etags.
9347
f1052e5d
EZ
9348 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9349 changes in globals.h immediately force recompilation.
762b15be
EZ
9350 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9351 $(CURDIR)/s/ms-w32.h.
9352 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9353
fa6996bc
EZ
9354 * character.c (Fchar_direction): Function deleted.
9355 (syms_of_character): Don't defsubr it.
9356 <char-direction-table>: Deleted.
9357
e6c3da20
EZ
93582011-04-23 Eli Zaretskii <eliz@gnu.org>
9359
9360 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9361 * doprnt.c: Include limits.h.
9362 (SIZE_MAX): New macro.
04f2d78b
CB
9363 (doprnt): Return a size_t value. 2nd arg is now size_t.
9364 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9365 Improve overflow protection. Support `l' modifier for integer
9366 conversions. Support %l conversion. Don't assume an EMACS_INT
9367 argument for integer conversions and for %c.
9368
9369 * lisp.h (doprnt): Restore prototype.
9370
9371 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9372 $(SRC)/character.h.
9373
9374 * Makefile.in (base_obj): Add back doprnt.o.
9375
9376 * deps.mk (doprnt.o): Add back prerequisites.
9377 (callint.o): Depend on character.h.
9378
9379 * eval.c (internal_lisp_condition_case): Include the handler
9380 representation in the error message.
9381 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9382 when breaking from the loop.
9383
9384 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9385
9386 * callint.c (Fcall_interactively): When displaying error message
9387 about invalid control letter, pass the character's codepoint, not
9388 a pointer to its multibyte form. Improve display of the character
9389 in octal and display also its hex code.
9390
9391 * character.c (char_string): Use %x to display the (unsigned)
9392 codepoint of an invalid character, to avoid displaying a bogus
9393 negative value.
9394
9395 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9396 `error', not SYMBOL_NAME itself.
9397
9398 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9399 character arguments to `error'.
9400
9401 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9402 to `error' in error message about FINAL_CHAR argument. Make sure
9403 FINAL_CHAR is a character, and use %c when it is passed as
9404 argument to `error'.
9405
4ffd0d6b 94062011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9407
9408 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9409
9410 * w32.c: Include <time.h>.
9411 (sys_localtime): New function.
9412
4ffd0d6b 94132011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9414
9415 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9416
4ffd0d6b 9417 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9418
4ffd0d6b 94192011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9420
4ffd0d6b
GM
9421 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9422 zombies (Bug#8467).
aac0c6e3 9423
04c56954
EZ
94242011-04-19 Eli Zaretskii <eliz@gnu.org>
9425
9426 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9427 gl_state.e_property when gl_state.object is Qt.
9428
9429 * insdel.c (make_gap_larger): Remove limitation of buffer size
9430 to <= INT_MAX.
9431
16a43933
CY
94322011-04-18 Chong Yidong <cyd@stupidchicken.com>
9433
9434 * xdisp.c (lookup_glyphless_char_display)
9435 (produce_glyphless_glyph): Handle cons cell entry in
9436 glyphless-char-display.
9437 (Vglyphless_char_display): Document it.
9438
9439 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9440 glyphless-char-display.
9441
4581706e
CY
94422011-04-17 Chong Yidong <cyd@stupidchicken.com>
9443
9444 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9445
9446 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9447
9448 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9449 definition for no-X builds.
9450
4887c6e2 94512011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9452
fd35b6f9
PE
9453 Static checks with GCC 4.6.0 and non-default toolkits.
9454
5c1ccb01
PE
9455 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9456
006c5daa
PE
9457 * process.c (keyboard_bit_set): Define only if SIGIO.
9458 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9459 (send_process): Repair possible setjmp clobbering.
9460
efc736d3
PE
9461 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9462
4e2fe2e6
PE
9463 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9464
f97334a2
PE
9465 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9466
4e75f29d
PE
9467 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9468 Define only if needed.
9469
90efadd1
PE
9470 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9471 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9472 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9473
3c647824
PE
9474 * dispextern.h (struct redisplay_interface): Rename param
9475 to avoid shadowing.
e264f262 9476 * termhooks.h (struct terminal): Likewise.
761383f4 9477 * xterm.c (xembed_send_message): Likewise.
3c647824 9478
b58c5c4a
PE
9479 * insdel.c (make_gap_smaller): Define only if
9480 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9481
cad59032
PE
9482 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9483 it.
9484
c339dc2e
PE
9485 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9486 so that we aren't warned about unused symbols.
9487
91a3e27b
PE
9488 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9489
399c71d3 9490 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9491
8ffc96f5
PE
9492 * xfns.c (x_real_positions): Mark locals as initialized.
9493
eef9bc79
PE
9494 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9495
098db9dd
PE
9496 * xterm.c: Fix problems found by static analysis with other toolkits.
9497 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9498 (x_dispatch_event): Declare static if USE_GTK, and
9499 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9500 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9501 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9502 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9503 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9504
eb18f6cc
PE
9505 * xmenu.c (menu_help_callback): Pointer type fixes.
9506 Use const pointers when pointing at readonly data. Avoid pointer
9507 signedness clashes.
9508 (FALSE): Remove unused macro.
9509 (update_frame_menubar): Remove unused decl.
9510
1fe72bf8
PE
9511 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9512
60d9e1db
PE
9513 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9514 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9515 (single_menu_item): Rename local to avoid shadowing.
9516
39261c26
PE
9517 * keyboard.c (make_lispy_event): Remove unused local var.
9518
018c5e19
PE
9519 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9520 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9521
63d2b86e
PE
9522 * bitmaps: Change bitmaps from unsigned char back to the X11
9523 compatible char. Avoid the old compiler warnings about
9524 out-of-range initializers by using, for example, '\xab' rather
9525 than 0xab.
9526
aefd87e1
PE
9527 * xgselect.c (xgselect_initialize): Check vs interface
9528 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9529
bf501fb9
PE
9530 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9531
e9829fdf
PE
9532 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9533 to read-only memory.
9534
1086c095
PE
9535 * fns.c (vector): Remove; this old hack is no longer needed.
9536
2baccd04 9537 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9538 Remove unused var.
dde42981 9539 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9540
72391843 9541 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9542
436c16df 9543 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9544 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9545 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9546
92bb796d 9547 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9548 (x_term_init): Remove local to avoid shadowing.
92bb796d 9549
764430a3 9550 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9551
9552 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9553 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9554
d1dfb56c
EZ
95552011-04-16 Eli Zaretskii <eliz@gnu.org>
9556
c4354cb4
EZ
9557 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9558
d1dfb56c
EZ
9559 Fix regex.c, syntax.c and friends for buffers > 2GB.
9560 * syntax.h (struct gl_state_s): Declare character position members
9561 EMACS_INT.
9562
9563 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9564
04f2d78b
CB
9565 * textprop.c (verify_interval_modification, interval_of):
9566 Declare arguments EMACS_INT.
d1dfb56c
EZ
9567
9568 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9569 EMACS_INT.
9570
9571 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9572
9573 * indent.c (Fvertical_motion): Local variable it_start is now
9574 EMACS_INT.
9575
9576 * regex.c (re_match, re_match_2, re_match_2_internal)
9577 (bcmp_translate, regcomp, regexec, print_double_string)
9578 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9579 (re_compile_pattern, re_exec): Declare arguments and local
9580 variables `size_t' and `ssize_t' and return values `regoff_t', as
9581 appropriate.
9582 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9583 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9584 <compile_stack_type>: `size' and `avail' are now `size_t'.
9585
9586 * regex.h <regoff_t>: Use ssize_t, not int.
9587 (re_search, re_search_2, re_match, re_match_2): Arguments that
9588 specify buffer/string position and length are now ssize_t and
9589 size_t. Return type is regoff_t.
9590
613052cd
BK
95912011-04-16 Ben Key <bkey76@gmail.com>
9592
9593 * nsfont.m: Fixed bugs in ns_get_family and
9594 ns_descriptor_to_entity that were caused by using free to
9595 deallocate memory blocks that were allocated by xmalloc (via
9596 xstrdup). This caused Emacs to crash when compiled with
9597 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9598 --enable-checking=xmallocoverrun). xfree is now used to
9599 deallocate these memory blocks.
9600
4170f62f 96012011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9602
71b41406
PE
9603 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9604
9587a89d
PE
9605 emacs_write: Accept and return EMACS_INT for sizes.
9606 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9607 et seq.
9608 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9609 Accept and return EMACS_INT.
9610 (emacs_gnutls_write): Return the number of bytes written on
9611 partial writes.
9612 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9613 (emacs_read, emacs_write): Remove check for negative size, as the
9614 Emacs source code has been audited now.
9587a89d
PE
9615 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9616 (emacs_read, emacs_write): Use it.
273a5f82
PE
9617 * process.c (send_process): Adjust to the new signatures of
9618 emacs_write and emacs_gnutls_write. Do not attempt to store
9619 a byte offset into an 'int'; it might overflow.
9587a89d 9620 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9621
3e047f51
PE
9622 * sound.c: Don't assume sizes fit in 'int'.
9623 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9624 Return EMACS_INT, not int.
3e047f51 9625 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9626 Accept EMACS_INT, not int.
9627 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9628 record read return values.
9629
cc39a9db
BK
96302011-04-15 Ben Key <bkey76@gmail.com>
9631
c9d0ec6d
JB
9632 * keyboard.c (Qundefined): Don't declare static since it is used
9633 in nsfns.m.
9634 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9635 static since they are used in nsfont.m.
cc39a9db 9636
6c60eb9f
SM
96372011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9638
9639 * process.c (Qprocessp): Don't declare static.
9640 * lisp.h (Qprocessp): Declare again.
9641
7990b61a
JB
96422011-04-15 Juanma Barranquero <lekktu@gmail.com>
9643
9644 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9645
5d4cb038
PE
96462011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9647
8bd7b830 9648 Improve C-level modularity by making more things 'static'.
cd64ea1d 9649
e3b27b31
PE
9650 Don't publish debugger-only interfaces to other modules.
9651 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9652 (verify_bytepos, count_markers): Move decls to the only modules
9653 that need them.
9654 * region-cache.h (pp_cache): Likewise.
9655 * window.h (check_all_windows): Likewise.
9656 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9657
5d4cb038
PE
9658 * sysdep.c (croak): Now static, if
9659 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9660 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9661
9662 * alloc.c (refill_memory_reserve): Now static if
9663 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9664 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9665
e87b6180
PE
9666 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9667 Define only if USE_LUCID.
9668
ac64929e
PE
9669 * xrdb.c (x_customization_string, x_rm_string): Now static.
9670
6f37259d
PE
9671 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9672 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9673
1683e3ab
PE
9674 * xdisp.c (draw_row_with_mouse_face): Now static.
9675 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9676
de9c2632
PE
9677 * window.h (check_all_windows): Mark externally visible.
9678
2b96acb7
PE
9679 * window.c (window_deletion_count): Now static.
9680
9681 * undo.c: Make symbols static if they're not exported.
9682 (last_undo_buffer, last_boundary_position, pending_boundary):
9683 Now static.
9684
50436f33
PE
9685 * textprop.c (interval_insert_behind_hooks): Now static.
9686 (interval_insert_in_front_hooks): Likewise.
9687
64520e5c
PE
9688 * term.c: Make symbols static if they're not exported.
9689 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9690 (max_frame_lines, tty_set_terminal_modes):
9691 (tty_reset_terminal_modes, tty_turn_off_highlight):
9692 (get_tty_terminal): Now static.
9693 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9694 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9695 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9696 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9697 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9698
1fa53021
PE
9699 * sysdep.c: Make symbols static if they're not exported.
9700 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9701 Now static.
9702 (sigprocmask_set, full_mask): Remove; unused.
9703 (wait_debugging): Mark as visible.
9704 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9705 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9706
d4b43b22
PE
9707 * syntax.c (syntax_temp): Define only if !__GNUC__.
9708
b7c513d0
PE
9709 * sound.c (current_sound_device, current_sound): Now static.
9710
989b29ad
PE
9711 * search.c (searchbufs, searchbuf_head): Now static.
9712
13a55a78
PE
9713 * scroll.c (scroll_cost): Remove; unused.
9714 * dispextern.h (scroll_cost): Remove decl.
9715
de68a1fc
PE
9716 * region-cache.h (pp_cache): Mark as externally visible.
9717
40ccffa6
PE
9718 * process.c: Make symbols static if they're not exported.
9719 (process_tick, update_tick, create_process, chan_process):
9720 (Vprocess_alist, proc_buffered_char, datagram_access):
9721 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9722 (deactivate_process): Mark defn as static, as well as decl.
9723 * lisp.h (create_process): Remove decl.
9724 * process.h (chan_process, Vprocess_alist): Remove decls.
9725
ad64fc97
PE
9726 * print.c: Make symbols static if they're not exported.
9727 (print_depth, new_backquote_output, being_printed, print_buffer):
9728 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9729 (print_interval, print_number_index, initial_stderr_stream):
9730 Now static.
9731 * lisp.h (Fprinc): Remove decl.
9732 (debug_output_compilation_hack): Mark as externally visible.
9733
adddb265
PE
9734 * sysdep.c (croak): Move decl from here to syssignal.h.
9735 * syssignal.h (croak): Put it here, so the API can be checked when
9736 'croak' is called from dissociate_if_controlling_tty.
9737
1717ede2
PE
9738 * minibuf.c: Make symbols static if they're not exported.
9739 (minibuf_save_list, choose_minibuf_frame): Now static.
9740 * lisp.h (choose_minibuf_frame): Remove decl.
9741
fa5fb2bc
PE
9742 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9743
1e3890d1
PE
9744 * lread.c: Make symbols static if they're not exported.
9745 (read_objects, initial_obarray, oblookup_last_bucket_number):
9746 Now static.
9747 (make_symbol): Remove; unused.
9748 * lisp.h (initial_obarray, make_symbol): Remove decls.
9749
8a1414fa
PE
9750 * keyboard.c: Make symbols static if they're not exported.
9751 (single_kboard, recent_keys_index, total_keys, recent_keys):
9752 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9753 (this_single_command_key_start, echoing, last_auto_save):
9754 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9755 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9756 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9757 (Vlispy_mouse_stem, double_click_count):
9758 Now static.
9759 (force_auto_save_soon): Define only if SIGDANGER.
9760 (ignore_mouse_drag_p): Now static if
9761 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9762 (print_help): Remove; unused.
9763 (stop_character, last_timer_event): Mark as externally visible.
9764 * keyboard.h (ignore_mouse_drag_p): Declare only if
9765 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9766 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9767 * lisp.h (echoing): Remove decl.
9768 (force_auto_save_soon): Declare only if SIGDANGER.
9769 * xdisp.c (redisplay_window): Simplify code, to make it more
9770 obvious that ignore_mouse_drag_p is not accessed if !defined
9771 USE_GTK && !defined HAVE_NS.
9772
93ea6e8f
PE
9773 * intervals.c: Make symbols static if they're not exported.
9774 (merge_properties_sticky, merge_interval_right, delete_interval):
9775 Now static.
9776 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9777
77382fcc
PE
9778 * insdel.c: Make symbols static if they're not exported.
9779 However, leave prepare_to_modify_buffer alone. It's never
9780 called from outside this function, but that appears to be a bug.
9781 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9782 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9783 (adjust_after_replace_noundo): Remove; unused.
9784 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9785 (signal_before_change): Remove decls.
77382fcc 9786
9306c32e
PE
9787 * indent.c (val_compute_motion, val_vmotion): Now static.
9788
cd44d2eb
PE
9789 * image.c: Make symbols static if they're not exported.
9790 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9791 if USE_GTK.
9792 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9793 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9794
ad9a7a06
PE
9795 * fringe.c (standard_bitmaps): Now static.
9796 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9797
81626931
PE
9798 * frame.c: Make symbols static if they're not exported.
9799 (x_report_frame_params, make_terminal_frame): Now static.
9800 (get_frame_param): Now static, unless HAVE_NS.
9801 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9802 (x_get_resource_string): Remove; not used.
9803 * frame.h (make_terminal_frame, x_report_frame_params):
9804 (x_get_resource_string); Remove decls.
9805 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9806 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9807
239f9db9
PE
9808 * font.c, fontset.c: Make symbols static if they're not exported.
9809 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9810 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9811 * font.c (font_close_object): Now static.
9812 * font.h (font_close_object): Remove.
9813 * fontset.c (FONTSET_OBJLIST): Remove.
9814 (free_realized_fontset) #if-0 the body, which does nothing.
9815 (face_suitable_for_char_p): #if-0, as it's never called.
9816 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9817 * xfaces.c (face_at_string_position):
9818 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9819 since 0 is always ASCII.
9820
dfcf3579
PE
9821 * fns.c (weak_hash_tables): Now static.
9822
5045092b
PE
9823 * fileio.c: Make symbols static if they're not exported.
9824 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9825 (Vwrite_region_annotation_buffers): Now static.
9826
57a96f5c
PE
9827 * eval.c: Make symbols static if they're not exported.
9828 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9829 * lisp.h (backtrace_list): Remove decl.
9830
35f08c38
PE
9831 * emacs.c: Make symbols static if they're not exported.
9832 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9833 (fatal_error_code, fatal_error_signal_hook, standard_args):
9834 Now static.
9835 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9836 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9837 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9838 * lisp.h (fatal_error_signal_hook): Remove decl.
9839 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9840
f44bd759
PE
9841 * editfns.c: Move a (normally-unused) function to its only use.
9842 * editfns.c, lisp.h (get_operating_system_release): Remove.
9843 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9844 worth the hassle of breaking this out.
9845
b532497d
PE
9846 * xterm.c: Make symbols static if they're not exported.
9847 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9848 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9849 (x_destroy_window, x_delete_display):
9850 Now static.
9851 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9852 (x_mouse_leave): Remove; unused.
9853 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9854 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9855 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9856 Remove decls.
9857 (x_mouse_leave): Declare only if WINDOWSNT.
9858 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9859 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9860 USE_X_TOOLKIT.
9861
1675728f
PE
9862 * ftxfont.c: Make symbols static if they're not exported.
9863 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9864 HAVE_FREETYPE.
9865 * font.h (ftxfont_driver): Likewise.
9866
e4cebfca
PE
9867 * xfns.c: Make symbols static if they're not exported.
9868 (x_last_font_name, x_display_info_for_name):
9869 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9870 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9871 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9872 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9873 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9874 (last_show_tip_args): Now static.
9875 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9876 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9877 (x_screen_planes): Remove; unused.
9878 * dispextern.h (x_screen_planes): Remove decl.
9879
5bf46f05
PE
9880 * dispnew.c: Make symbols static if they're not exported.
9881 * dispextern.h (redraw_garbaged_frames, scrolling):
9882 (increment_row_positions): Remove.
9883 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9884 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9885 Now static.
9886 (redraw_garbaged_frames): Remove; unused.
9887
435f4c28
PE
9888 * xfaces.c: Make symbols static if they're not exported.
9889 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9890 Remove decls.
9891 * xterm.h (defined_color): Remove decls.
9892 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9893 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9894 (menu_face_changed_default, defined_color, free_realized_face):
9895 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9896 (ascii_face_of_lisp_face): Remove; unused.
9897
8524aef3
PE
9898 * xdisp.c: Make symbols static if they're not exported.
9899 * dispextern.h (scratch_glyph_row, window_box_edges):
9900 (glyph_to_pixel_coords, set_cursor_from_row):
9901 (get_next_display_element, set_iterator_to_next):
9902 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9903 (show_mouse_face): Remove decls
9904 * frame.h (message_buf_print): Likewise.
9905 * lisp.h (pop_message, set_message, check_point_in_composition):
9906 Likewise.
9907 * xterm.h (set_vertical_scroll_bar): Likewise.
9908 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9909 (message_buf_print, scratch_glyph_row, displayed_buffer):
9910 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9911 (get_next_display_element, show_mouse_face, window_box_edges):
9912 (frame_to_window_pixel_xy, check_point_in_composition):
9913 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9914 (glyph_to_pixel_coords): Remove; unused.
9915
16390cd2
PE
9916 * dired.c (file_name_completion): Now static.
9917
9918 * dbusbind.c (xd_in_read_queued_messages): Now static.
9919
a25f4dfa
PE
9920 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9921 * data.c (circular_list_error): Remove.
9922
14a9c8df
PE
9923 * commands.h (last_point_position, last_point_position_buffer):
9924 (last_point_position_window): Remove decls.
9925 * keyboard.c: Make these variables static.
9926
04f2d78b
CB
9927 * coding.h (coding, code_convert_region, encode_coding_gap):
9928 Remove decls.
74ab6df5
PE
9929 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9930 (iso_code_class, detect_coding, code_convert_region): Now static.
9931 (encode_coding_gap): Remove; unused.
9932
38dfbee1
PE
9933 * chartab.c (chartab_chars, chartab_bits): Now static.
9934
a2cb4e63
PE
9935 * charset.h (charset_iso_8859_1): Remove decl.
9936 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9937 Now static.
9938
127198fd
PE
9939 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9940 * ccl.c (Vccl_program_table): Now static.
9941 (check_ccl_update): Remove; unused.
9942
d85b608f
PE
9943 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9944 * category.h: ... from here.
9945 * category.c (check_category_table, set_category_set): Now static.
9946
31cd66f3
PE
9947 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9948 * lisp.h: Remove these decls.
9949
c358e587
PE
9950 * buffer.c (buffer_count): Remove unused var.
9951
e78aecca
PE
9952 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9953 so that it's not optimized away.
9954 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9955 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9956 exported only to the debugger.
9957
e192d7d3 9958 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9959 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9960
92470028
PE
9961 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9962 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9963 was inaccessible from Lisp.
9964 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9965 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9966
244ed907
PE
9967 alloc.c: Import and export fewer symbols, and remove unused items.
9968 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9969 is defined.
9970 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9971 it's not optimized away by whole-program optimization.
9972 (message_enable_multibyte, free_misc): Remove.
9973 (catchlist, handlerlist, mark_backtrace):
9974 Declare only if BYTE_MARK_STACK.
9975 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9976 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9977 (message_enable_multibyte): Remove decl.
9978 (free_misc, interval_free_list, float_block, float_block_index):
9979 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9980 (cons_free_list, last_marked_index):
9981 Now static.
9982 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9983 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9984 (mark_backtrace): Define only if BYTE_MARK_STACK.
9985 * xdisp.c (message_enable_multibyte): Now static.
9986
61c2b50e 9987 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9988 This makes it easier for human readers (and static analyzers)
9989 to see whether these variables are used from other modules.
9990 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9991 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9992 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9993 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9994 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9995 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9996 * xmenu.c, xselect.c:
9997 Declare Q* vars static if they are not used in other modules.
9998 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9999 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10000 Remove decls of unexported vars.
10001 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10002
95c82688
PE
10003 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10004
16a97296
PE
10005 Make Emacs functions such as Fatom 'static' by default.
10006 This makes it easier for human readers (and static analyzers)
10007 to see whether these functions can be called from other modules.
10008 DEFUN now defines a static function. To make the function external
10009 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10010 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10011 (Finit_image_library):
16a97296
PE
10012 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10013 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10014 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10015 Remove decls, since these functions are now static.
10016 (Funintern, Fget_internal_run_time): New decls, since these functions
10017 were already external.
95c82688 10018
16a97296
PE
10019 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10020 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10021 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10022 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10023 * keyboard.c, keymap.c, lread.c:
10024 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10025 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10026 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10027 Mark functions with DEFUE instead of DEFUN,
10028 if they are used in other modules.
10029 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10030 decls for now-static functions.
10031 * buffer.h (Fdelete_overlay): Remove decl.
10032 * callproc.c (Fgetenv_internal): Mark as internal.
10033 * composite.c (Fremove_list_of_text_properties): Remove decl.
10034 (Fcomposition_get_gstring): New forward static decl.
10035 * composite.h (Fcomposite_get_gstring): Remove decl.
10036 * dired.c (Ffile_attributes): New forward static decl.
10037 * doc.c (Fdocumntation_property): New forward static decl.
10038 * eval.c (Ffetch_bytecode): New forward static decl.
10039 (Funintern): Remove extern decl; now in .h file where it belongs.
10040 * fileio.c (Fmake_symbolic_link): New forward static decl.
10041 * image.c (Finit_image_library): New forward static decl.
10042 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10043 * intervals.h (Fprevious_property_change):
10044 (Fremove_list_of_text_properties): Remove decls.
10045 * keyboard.c (Fthis_command_keys): Remove decl.
10046 (Fcommand_execute): New forward static decl.
10047 * keymap.c (Flookup_key): New forward static decl.
10048 (Fcopy_keymap): Now static.
10049 * keymap.h (Flookup_key): Remove decl.
10050 * process.c (Fget_process): New forward static decl.
10051 (Fprocess_datagram_address): Mark as internal.
10052 * syntax.c (Fsyntax_table_p): New forward static decl.
10053 (skip_chars): Remove duplicate decl.
10054 * textprop.c (Fprevious_property_change): New forward static decl.
10055 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10056 Now internal.
10057 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10058 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10059
785bbd42
PE
10060 * editfns.c (Fformat): Remove unreachable code.
10061
8b913b57
AS
100622011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10063
10064 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10065 change. (Bug#8496)
10066
a6744a35
EZ
100672011-04-13 Eli Zaretskii <eliz@gnu.org>
10068
10069 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10070 when at ZV. (Bug#8487)
10071
e7974947
AS
100722011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10073
baad03f0
AS
10074 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10075 (Bug#8437)
10076 * keyboard.c (parse_tool_bar_item): Likewise.
10077 * sound.c (sound_cleanup, alsa_close): Likewise.
10078 * termcap.c (tgetent): Likewise.
10079 * xfns.c (x_default_font_parameter): Likewise.
10080 * xsettings.c (read_and_apply_settings): Likewise.
10081
e7974947
AS
10082 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10083 (overrun_check_free): Protoize.
10084
28272684
PE
100852011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10086
10087 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10088 since callers should never pass a negative size.
10089 Change the signature to match that of plain 'read' and 'write'; see
10090 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10091 * lisp.h: Update prototypes of emacs_write and emacs_read.
10092
11997c76
EZ
100932011-04-11 Eli Zaretskii <eliz@gnu.org>
10094
10095 * xdisp.c (redisplay_window): Don't try to determine the character
10096 position of the scroll margin if the window start point w->startp
e896f03c 10097 is outside the buffer's accessible region. (Bug#8468)
11997c76 10098
8a2cbd72
EZ
100992011-04-10 Eli Zaretskii <eliz@gnu.org>
10100
10101 Fix write-region and its subroutines for buffers > 2GB.
10102 * fileio.c (a_write, e_write): Modify declaration of arguments and
10103 local variables to support buffers larger than 2GB.
10104 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10105
10106 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10107 argument, local variables, and return value.
10108
10109 * lisp.h: Update prototypes of emacs_write and emacs_read.
10110
10111 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10112
4073e537 101132011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10114
1ebfdcb6
PE
10115 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10116
b2ded58d
PE
10117 Fix more problems found by GCC 4.6.0's static checks.
10118
7d66342c
PE
10119 * xdisp.c (vmessage): Use a better test for character truncation.
10120
bbf47d44
PE
10121 * charset.c (load_charset_map): <, not <=, for optimization,
10122 and to avoid potential problems with integer overflow.
9248994d 10123 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10124 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10125 * editfns.c (Fformat): Likewise.
1e69125e 10126 * syntax.c (skip_chars): Likewise.
3befa583 10127
e3019616
PE
10128 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10129 This also lets GCC 4.6.0 generate slightly better loop code.
10130
becfa255
PE
10131 * callint.c (Fcall_interactively): <, not <=, for optimization.
10132 (Fcall_interactively): Count the number of arguments produced,
10133 not the number of arguments given. This is simpler and lets GCC
10134 4.6.0 generate slightly better code.
10135
dae0cd48
PE
10136 * ftfont.c: Distingish more carefully between FcChar8 and char.
10137 The previous code passed unsigned char * to a functions like
10138 strlen and xstrcasecmp that expect char *, which does not
10139 conform to the C standard.
10140 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10141 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10142 char * when the C standard requires it.
10143
76032d70
PE
10144 * keyboard.c (read_char): Remove unused var.
10145
eb3f1cc8
PE
10146 * eval.c: Port to Windows vsnprintf (Bug#8435).
10147 Include <limits.h>.
10148 (SIZE_MAX): Define if the headers do not.
10149 (verror): Do not give up if vsnprintf returns a negative count.
10150 Instead, grow the buffer. This ports to Windows vsnprintf, which
10151 does not conform to C99. Problem reported by Eli Zaretskii.
10152 Also, simplify the allocation scheme, by avoiding the need for
10153 calling realloc, and removing the ALLOCATED variable.
10154
70476b54
PE
10155 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10156
12020a9e
PE
10157 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10158 But keep the doprint source code for now, as we might revamp it
10159 and use it again (Bug#8435).
ea6c7ae6
PE
10160 * lisp.h (doprnt): Remove.
10161 * Makefile.in (base_obj): Remove doprnt.o.
10162 * deps.mk (doprnt.o): Remove.
10163
5fdb398c
PE
10164 error: Print 32- and 64-bit integers portably (Bug#8435).
10165 Without this change, on typical 64-bit hosts error ("...%d...", N)
10166 was used to print both 32- and 64-bit integers N, which relied on
10167 undefined behavior.
61bdb816 10168 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10169 * lisp.h (error, verror): Mark as printf-like functions.
10170 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10171 Report overflow in size calculations when allocating printf buffer.
10172 Do not truncate output string at its first null byte.
10173 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10174 Truncate the output at a character boundary, since vsnprintf does not
10175 do that.
10176 * charset.c (check_iso_charset_parameter): Convert internal
10177 character to string before calling 'error', since %c now has the
10178 printf meaning.
10179 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10180 overflow when computing char to be passed to 'error'. Do not
10181 pass Lisp_Object to 'error'; pass the integer instead.
10182 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10183 formatted with plain %d.
10184
b189fa66
PE
10185 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10186
bff87ef0
PE
10187 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10188
7e2cac20
PE
10189 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10190
ce4d90b5
PE
10191 * xterm.c (x_catch_errors): Remove duplicate declaration.
10192
266c9547
PE
10193 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10194
79c49ad2
PE
10195 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10196
368f4090
JM
101972011-04-10 Jim Meyering <meyering@redhat.com>
10198
10199 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10200 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10201 return ssize_t not "int", and use size_t as the buffer length.
10202 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10203 * gnutls.h: Update declarations.
10204 * process.c (read_process_output): Use ssize_t, to match.
10205 (send_process): Likewise.
10206
a32d4040
CY
102072011-04-09 Chong Yidong <cyd@stupidchicken.com>
10208
10209 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10210
8546720e 102112011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10212
04f2d78b
CB
10213 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10214 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10215
8546720e
GM
10216 * xterm.c (handle_one_xevent):
10217 * xmenu.c (create_and_show_popup_menu):
10218 * xselect.c (x_decline_selection_request)
10219 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10220
0a2f5c1a 102212011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10222
10223 Fix some uses of `int' instead of EMACS_INT.
10224 * search.c (string_match_1, fast_string_match)
10225 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10226 (scan_buffer, find_next_newline_no_quit)
10227 (find_before_next_newline, search_command, Freplace_match)
10228 (Fmatch_data): Make some `int' variables be EMACS_INT.
10229
10230 * xdisp.c (display_count_lines): 3rd argument and return value now
10231 EMACS_INT. All callers changed.
10232 (pint2hrstr): Last argument is now EMACS_INT.
10233
10234 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10235 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10236 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10237 (decode_coding_utf_16, decode_coding_emacs_mule)
10238 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10239 (decode_coding_ccl, decode_coding_charset)
10240 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10241 (decode_coding_iso_2022, decode_coding_emacs_mule)
10242 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10243 <char_offset, last_offset>: Declare EMACS_INT.
10244 (encode_coding_utf_8, encode_coding_utf_16)
10245 (encode_coding_emacs_mule, encode_invocation_designation)
10246 (encode_designation_at_bol, encode_coding_iso_2022)
10247 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10248 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10249 Declare EMACS_INT.
10250 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10251 (encode_invocation_designation): Last argument P_NCHARS is now
10252 EMACS_INT.
10253 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10254 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10255
10256 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10257 All users changed.
10258
10259 * ccl.c (Fccl_execute_on_string): Declare some variables
10260 EMACS_INT.
10261
8546720e 102622011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10263
10264 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10265
4e19a977
CS
102662011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10267
10268 * process.c (Fformat_network_address): Doc fix.
10269
87302331
R
102702011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10271
ee7683eb 10272 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10273
cbb59342
CY
102742011-04-08 Chong Yidong <cyd@stupidchicken.com>
10275
10276 * keyboard.c (read_char): Call Lisp function help-form-show,
10277 instead of using internal_with_output_to_temp_buffer.
10278 (Qhelp_form_show): New var.
e0d38eeb 10279 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10280
10281 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10282
10283 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10284
e67a13ab
CY
102852011-04-06 Chong Yidong <cyd@stupidchicken.com>
10286
04f2d78b
CB
10287 * process.c (Flist_processes): Remove to Lisp.
10288 (list_processes_1): Delete.
e67a13ab 10289
973f782d
EZ
102902011-04-06 Eli Zaretskii <eliz@gnu.org>
10291
7c106b1e
EZ
10292 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10293
973f782d
EZ
10294 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10295
41cf7d1a 102962011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10297
ca23cc88
PE
10298 Fix more problems found by GCC 4.6.0's static checks.
10299
f390e2d5
PE
10300 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10301
42eea0d0
PE
10302 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10303
b69769da 10304 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10305
f9541e84
PE
10306 * xdisp.c (vmessage): Mark as a printf-like function.
10307
13841b55
PE
10308 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10309
c136c10f
PE
10310 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10311
5e2d4a30
PE
10312 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10313 printf-like functions.
10314 (tiff_load): Add casts to remove these marks before passing them
10315 to system-supplied API.
10316
583f48b9
PE
10317 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10318
b25d760e
PE
10319 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10320 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10321 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10322 directly, rather than having caller test rule sign. This avoids
10323 some unnecessary tests.
10324 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10325 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10326 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10327
bc7b6697 10328 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10329 (xfont_open): Avoid unnecessary tests.
bc7b6697 10330
27ccc379
PE
10331 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10332
dcd5c89a
PE
10333 * composite.h, composite.c (composition_gstring_put_cache):
10334 Use EMACS_INT, not int, for length.
10335
b13a45c6
PE
10336 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10337 breaking out part of COMPOSITION_DECODE_RULE.
10338 (COMPOSITION_DECODE_RULE): Use it.
10339 * composite.c (get_composition_id): Remove unused local vars,
10340 by using the new macro.
10341
1e792e4d
PE
10342 * textprop.c (set_text_properties_1): Change while to do-while,
10343 since the condition is always true at first.
10344
dc6c6455 10345 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10346 (interval_deletion_adjustment): Return unsigned value.
10347 All uses changed.
dc6c6455 10348
aba7731a
PE
10349 * process.c (list_processes_1, create_pty, read_process_output):
10350 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10351 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10352 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10353 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10354 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10355
fdfc4bf3
PE
10356 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10357
fca8fe46 10358 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10359 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10360
06a0259a 10361 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10362 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10363 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10364
e7b9e80f
PE
10365 * print.c (print_error_message): Avoid int overflow.
10366
56201685
PE
10367 * font.c (font_list_entities): Redo for clarity,
10368 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10369
78834453 10370 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10371 (font_score): Avoid potential overflow in diff calculation.
78834453 10372
0bc0b309 10373 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10374 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10375
e610eaca
PE
10376 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10377
b895abce
PE
10378 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10379 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10380 can always succeed if overflow has undefined behavior.
10381
1f1d9321 10382 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10383 (wordify): Omit three unnecessary tests.
1f1d9321 10384
c59478bc
PE
10385 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10386 All callers changed. This avoids the need for an unused var.
10387
79b73827
PE
10388 * casefiddle.c (casify_region): Remove var that is set but not used.
10389
a4db5dfe
PE
10390 * dired.c (file_name_completion): Remove var that is set but not used.
10391
43aae36e
PE
10392 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10393
2a47c44d 10394 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10395 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10396
a37c69bf
PE
10397 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10398 Check for integer overflow on size calculations.
10399
328ab8e7
PE
10400 * buffer.c (Fprevious_overlay_change): Remove var that is set
10401 but not used.
10402
e5a2a5cb
PE
10403 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10404 Remove vars that are set but not used.
8d84a6eb 10405 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10406 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10407
a60e5f68
PE
10408 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10409
f661cb61 10410 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10411 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10412
f0397f5a
PE
10413 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10414 that are set but not used.
10415
8664db06 10416 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10417 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10418
6abdaa4a
PE
10419 * xselect.c (x_get_local_selection, x_handle_property_notify):
10420 Remove vars that are set but not used.
10421
0ce7538d 10422 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10423 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10424
9ae848fc
PE
10425 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10426 Remove var that is set but not used.
0b918413
PE
10427 (scroll_bar_windows_size): Now size_t, not int.
10428 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10429 Check for overflow.
9ae848fc 10430
a5a62657
PE
10431 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10432 (map_tty_color) [!defined MSDOS]: Likewise.
10433
5c5cdd39
PE
10434 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10435
66ebf983
PE
10436 * coding.c: Remove vars that are set but not used.
10437 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10438 All callers changed.
10439 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10440 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10441 (decode_coding_charset): Remove vars that are set but not used.
10442
1be4d761
PE
10443 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10444 that is set but not used.
10445
47553fa8
PE
10446 * print.c (print_object): Remove var that is set but not used.
10447
1f7196bf 10448 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10449 The gnulib version avoids calling malloc in the usual case,
10450 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10451 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10452 * filelock.c (current_lock_owner): Likewise.
10453 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10454 * sysdep.c: Include allocator.h, careadlinkat.h.
10455 (emacs_no_realloc_allocator): New static constant.
10456 (emacs_readlink): New function.
fdb61804
PE
10457 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10458 ../lib/careadlinkat.h.
d1fdcab7 10459
f84c17c7
SM
104602011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10461
10462 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10463 first non-nil return value).
10464
ef3862ad
JD
104652011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10466
10467 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10468 if not defined (Bug#8403).
10469
376a7006
JB
104702011-04-02 Juanma Barranquero <lekktu@gmail.com>
10471
10472 * xdisp.c (display_count_lines): Remove parameter `start',
10473 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10474 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10475 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10476 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10477 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10478 and thereabouts. All callers changed.
10479 (get_per_char_metric): Remove parameter `f', unused since
10480 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10481
6ca3801d
JM
104822011-04-02 Jim Meyering <meyering@redhat.com>
10483
10484 do not dereference NULL upon failed strdup
10485 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10486 (ns_get_family): Likewise.
10487
d8e2b5ba
JB
104882011-04-02 Juanma Barranquero <lekktu@gmail.com>
10489
10490 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10491
8c74fcbd
JD
104922011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10493
10494 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10495 later (Bug#8403).
10496
7200d79c
SM
104972011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10498
03408648 10499 Add lexical binding.
7200d79c 10500
03408648
SM
10501 * window.c (Ftemp_output_buffer_show): New fun.
10502 (Fsave_window_excursion):
10503 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10504
10505 * lread.c (lisp_file_lexically_bound_p): New function.
10506 (Fload): Bind Qlexical_binding.
10507 (readevalloop): Remove `evalfun' arg.
10508 Bind Qinternal_interpreter_environment.
10509 (Feval_buffer): Bind Qlexical_binding.
10510 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10511 Mark as dynamic.
10512 (syms_of_lread): Declare `lexical-binding'.
10513
10514 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10515
10516 * keyboard.c (eval_dyn): New fun.
10517 (menu_item_eval_property): Use it.
ca105506
SM
10518
10519 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10520
03408648
SM
10521 * fns.c (concat, mapcar1): Accept byte-code-functions.
10522
10523 * eval.c (Fsetq): Handle lexical vars.
10524 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10525 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10526 (FletX, Flet): Obey lexical binding.
10527 (Fcommandp): Handle closures.
10528 (Feval): New `lexical' arg.
10529 (eval_sub): New function extracted from Feval. Use it almost
10530 everywhere where Feval was used. Look up vars in lexical env.
10531 Handle closures.
10532 (Ffunctionp): Move from subr.el.
10533 (Ffuncall): Handle closures.
10534 (apply_lambda): Remove `eval_flags'.
10535 (funcall_lambda): Handle closures and new byte-code-functions.
10536 (Fspecial_variable_p): New function.
10537 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10538 but without exporting it to Lisp.
23aba0ea 10539
23aba0ea 10540 * doc.c (Fdocumentation, store_function_docstring):
03408648 10541 * data.c (Finteractive_form): Handle closures.
23aba0ea 10542
03408648
SM
10543 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10544 interactive spec.
ba83908c 10545
04f2d78b
CB
10546 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10547 New byte-codes.
03408648
SM
10548 (exec_byte_code): New function extracted from Fbyte_code to handle new
10549 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10550
03408648 10551 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10552
03408648 10553 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10554
e2abce01
JB
105552011-03-31 Juanma Barranquero <lekktu@gmail.com>
10556
10557 * xdisp.c (redisplay_internal): Fix prototype.
10558
63696a73 105592011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10560
63696a73 10561 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10562 (try_scrolling): Use it when setting scroll_limit.
10563 Limit scrolling to 100 screen lines.
63696a73
EZ
10564 (redisplay_window): Even when falling back on "recentering",
10565 position point in the window according to scroll-conservatively,
10566 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10567
10568 (try_scrolling): When point is above the window, allow searching
10569 as far as scroll_max, or one screenful, to compute vertical
10570 distance from PT to the scroll margin position. This prevents
10571 try_scrolling from unnecessarily failing when
10572 scroll-conservatively is set to a value slightly larger than the
10573 window height. Clean up the case of PT below the margin at bottom
10574 of window: scroll_max can no longer be INT_MAX. When aggressive
10575 scrolling is in use, don't let point enter the opposite scroll
10576 margin as result of the scroll.
10577 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10578 threshold of 100 lines for never-recentering scrolling.
10579
e4cc2dfc
JB
105802011-03-31 Juanma Barranquero <lekktu@gmail.com>
10581
10582 * dispextern.h (move_it_by_lines):
10583 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10584 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10585 (message_log_check_duplicate): Remove parameters `prev_bol' and
10586 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10587 (redisplay_internal): Remove parameter `preserve_echo_area',
10588 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10589
10590 * indent.c (Fvertical_motion):
10591 * window.c (window_scroll_pixel_based, Frecenter):
10592 Don't pass `need_y_p' to `move_it_by_lines'.
10593
1c470562
SM
105942011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10595
44f230aa
SM
10596 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10597 steal a few bits to be more compact.
10598 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10599 Remove unneeded casts.
10600
1c470562
SM
10601 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10602
888adce9
ZK
106032011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10604
10605 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10606 binding" message (bug#7967).
10607
f838ed7b
PE
106082011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10609
77861b95
PE
10610 Fix more problems found by GCC 4.6.0's static checks.
10611
de6dbc14
PE
10612 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10613 Remove unused local var.
10614
f838ed7b
PE
10615 * editfns.c (Fmessage_box): Remove unused local var.
10616
792c7b2b
PE
10617 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10618 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10619 Omit unused local vars.
c499e557 10620 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10621 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10622 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10623 Omit unused local var.
10624
ba0165e1
PE
10625 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10626 Don't assume string length fits in int.
32ad8845 10627 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10628 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10629
3c59b4c9
PE
10630 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10631 instead of alloca (Bug#8344).
10632
a3eed478 10633 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10634 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10635
eb4d412d
PE
10636 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10637
1658b401
PE
10638 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10639 concerns.
10640
10641 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10642
10643 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10644
9a2c6e05
PE
10645 * keyboard.c (syms_of_keyboard): Use the same style as later
10646 in this function when indexing through an array. This also
10647 works around GCC bug 48267.
10648
03d0a109
PE
10649 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10650
44f730c8
PE
10651 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10652
fe75f926
PE
10653 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10654 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10655
ffa8c828
PE
10656 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10657 This avoids undefined behavior on integer overflow, and is a bit
10658 more convenient anyway since it is compared to a size_t variable.
10659
c5101a77
PE
10660 Variadic C functions now count arguments with size_t, not int.
10661 This avoids an unnecessary limitation on 64-bit machines, which
10662 caused (substring ...) to crash on large vectors (Bug#8344).
10663 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10664 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10665 All variadic functions and their callers changed accordingly.
c5101a77
PE
10666 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10667 * data.c (arith_driver, float_arith_driver): Likewise.
10668 * editfns.c (general_insert_function): Likewise.
10669 * eval.c (struct backtrace.nargs, interactive_p)
10670 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10671 (funcall_lambda, mark_backtrace): Likewise.
10672 * fns.c (concat): Likewise.
10673 * frame.c (x_set_frame_parameters): Likewise.
10674 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10675 0 if not found, not -1. All callers changed.
10676
dd3f25f7
PE
10677 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10678 (stack_copy_size): Now size_t, not int.
10679 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10680
461c2ab9
JB
106812011-03-28 Juanma Barranquero <lekktu@gmail.com>
10682
10683 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10684 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10685 All callers changed.
10686
10687 * lisp.h (multibyte_char_to_unibyte):
10688 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10689 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10690 * character.h (CHAR_TO_BYTE8):
10691 * cmds.c (internal_self_insert):
10692 * editfns.c (general_insert_function):
10693 * keymap.c (push_key_description):
10694 * search.c (Freplace_match):
10695 * xdisp.c (message_dolog, set_message_1): All callers changed.
10696
f6d62986
SM
106972011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10698
10699 * keyboard.c (safe_run_hook_funcall): New function.
10700 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10701 don't set the hook to nil, but remove the offending function instead.
10702 (Qcommand_hook_internal): Remove, unused.
10703 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10704 Vcommand_hook_internal.
10705
10706 * eval.c (enum run_hooks_condition): Remove.
10707 (funcall_nil, funcall_not): New functions.
10708 (run_hook_with_args): Call each function through a `funcall' argument.
10709 Remove `cond' argument, now redundant.
10710 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10711 (Frun_hook_with_args_until_failure): Adjust accordingly.
10712 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10713
1db5b1ad
JB
107142011-03-28 Juanma Barranquero <lekktu@gmail.com>
10715
10716 * dispextern.h (string_buffer_position): Remove declaration.
10717
10718 * print.c (strout): Remove parameter `multibyte', unused since
10719 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10720
10721 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10722 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10723 All callers changed.
10724
10725 * w32.c (_wsa_errlist): Use braces for struct initializers.
10726
10727 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10728 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10729 All callers changed.
10730 (string_buffer_position): Likewise. Also, make static (it's never
10731 used outside xdisp.c).
10732 (cursor_row_p): Remove parameter `w', unused since
10733 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10734 (decode_mode_spec): Remove parameter `precision', introduced during
10735 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10736 All callers changed.
10737
5ffb62aa
JD
107382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10739
10740 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10741
461c2ab9 107422011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10743
10744 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10745 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10746 (ns_update_auto_hide_menu_bar): New functions.
10747 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10748 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10749 ns_constrain_all_frames.
10750 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10751 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10752
5c380ffb
JD
107532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10754
10755 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10756
9af30bdf
GM
107572011-03-27 Glenn Morris <rgm@gnu.org>
10758
10759 * syssignal.h: Replace RETSIGTYPE with void.
10760 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10761 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10762 Replace SIGTYPE with void everywhere.
10763 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10764 * s/template.h (SIGTYPE): Remove commented out definition.
10765
e2abce01
JB
107662011-03-26 Eli Zaretskii <eliz@gnu.org>
10767
10768 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10769 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10770
f868cd8a
JB
107712011-03-26 Juanma Barranquero <lekktu@gmail.com>
10772
59eb0929
JB
10773 * w32.c (read_unc_volume): Use parameter `henum', instead of
10774 global variable `wget_enum_handle'.
10775
10776 * keymap.c (describe_vector): Remove parameters `indices' and
10777 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10778 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10779
f868cd8a
JB
10780 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10781
10782 * keyboard.c (timer_check): Remove parameter `do_it_now',
10783 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10784 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10785 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10786
10787 * keyboard.c (read_char):
10788 * w32menu.c (w32_menu_display_help):
10789 * xmenu.c (show_help_event, menu_help_callback):
10790 Adjust calls to `show_help_echo'.
10791
10792 * gtkutil.c (xg_maybe_add_timer):
10793 * keyboard.c (readable_events):
10794 * process.c (wait_reading_process_output):
10795 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10796
10797 * insdel.c (adjust_markers_gap_motion):
10798 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10799 (gap_left, gap_right): Don't call it.
10800
2ecf6fdb
CY
108012011-03-25 Chong Yidong <cyd@stupidchicken.com>
10802
10803 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10804 incurred during fontification.
10805
6b1f9ba4
JB
108062011-03-25 Juanma Barranquero <lekktu@gmail.com>
10807
10808 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10809 (DEFVAR_PER_BUFFER): Don't pass it.
10810
10811 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10812 (scrolling_window): Don't pass it.
10813
0f4a96b5
JB
108142011-03-25 Juanma Barranquero <lekktu@gmail.com>
10815
10816 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10817
10818 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10819 and `suffix'.
10820 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10821 of variables specific to SELinux and computation of `encoded_absname'.
10822
10823 * image.c (XPutPixel): Remove unused variable `height'.
10824
10825 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10826
10827 * unexw32.c (get_section_info): Remove unused variable `section'.
10828
10829 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10830 (system_process_attributes): Remove unused variable `sess'.
10831 (sys_read): Remove unused variable `err'.
10832
10833 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10834 (w32_wnd_proc): Remove unused variable `isdead'.
10835 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10836 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10837 (x_create_tip_frame): Remove unused variable `tem'.
10838
10839 * w32inevt.c (w32_console_read_socket):
10840 Remove unused variable `no_events'.
10841
10842 * w32term.c (x_draw_composite_glyph_string_foreground):
10843 Remove unused variable `width'.
10844
1149507c
JB
108452011-03-24 Juanma Barranquero <lekktu@gmail.com>
10846
10847 * w32term.c (x_set_glyph_string_clipping):
10848 Don't pass uninitialized region to CombineRgn.
10849
9c88f339
JB
108502011-03-23 Juanma Barranquero <lekktu@gmail.com>
10851
10852 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10853 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10854 (Fx_close_connection): Remove unused variable `i'.
10855
10856 * w32font.c (w32font_draw): Return number of glyphs.
10857 (w32font_open_internal): Remove unused variable `i'.
10858 (w32font_driver): Add missing initializer.
10859
10860 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10861 (fill_in_menu): Remove unused variable `items_added'.
10862
10863 * w32term.c (last_mouse_press_frame): Remove static global variable.
10864 (w32_clip_to_row): Remove unused variable `f'.
10865 (x_delete_terminal): Remove unused variable `i'.
10866
10867 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10868 (NOTHING): Remove unused static global variable.
10869 (uniscribe_check_otf): Remove unused variable `table'.
10870 (uniscribe_font_driver): Add missing initializers.
10871
dee091a3
JD
108722011-03-23 Julien Danjou <julien@danjou.info>
10873
10874 * term.c (Fsuspend_tty, Fresume_tty):
10875 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10876 * window.c (temp_output_buffer_show):
10877 * insdel.c (signal_before_change):
10878 * frame.c (Fhandle_switch_frame):
10879 * fileio.c (Fdo_auto_save):
10880 * emacs.c (Fkill_emacs):
10881 * editfns.c (save_excursion_restore):
10882 * cmds.c (internal_self_insert):
10883 * callint.c (Fcall_interactively):
10884 * buffer.c (Fkill_all_local_variables):
10885 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10886 Use Frun_hooks.
0f4a96b5 10887 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10888 unconditionally since it does the check itself.
dee091a3 10889
2c520ab5 108902011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10891
c9c49752
PE
10892 Fix more problems found by GCC 4.5.2's static checks.
10893
8abc3f12
PE
10894 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10895 the first time through the loop, since we know p0 < p1 then.
10896 This also avoids a gcc -Wstrict-overflow warning.
10897
a2d26660
PE
10898 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10899 leading to a memory leak, possible in functions like
10900 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10901 of objects (Bug#8318).
a2d26660 10902
916c72e9
PE
10903 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10904 that could (at least in theory) be that large.
10905
19ab8a18
PE
10906 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10907 This is less likely to overflow, and avoids undefined behavior if
10908 overflow does occur. All callers changed. Use strtoul to scan
10909 for the unsigned long integer.
b7cbbd6f
PE
10910 (pint2hrstr): Simplify and tune code slightly.
10911 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10912
f0641eff
PE
10913 * scroll.c (do_scrolling): Work around GCC bug 48228.
10914 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10915
7f650bb9
PE
10916 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10917 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10918 (validate_x_resource_name): Simplify count usage.
10919 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10920
37dd57d1
PE
10921 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10922 fail (Bug#8306).
81e56e61 10923
699979fc 10924 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10925
401bf9b4
PE
10926 * process.c (Fmake_network_process): Use socklen_t, not int,
10927 where POSIX says socklen_t is required in portable programs.
10928 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10929 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10930 (Fmake_network_process, server_accept_connection):
10931 (wait_reading_process_output, read_process_output):
10932 Likewise.
10933
b93aacde
PE
10934 * process.c: Rename or move locals to avoid shadowing.
10935 (list_processes_1, Fmake_network_process):
10936 (read_process_output_error_handler, exec_sentinel_error_handler):
10937 Rename or move locals.
4dc343ee 10938 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10939 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10940 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10941 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10942 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10943
af8a867c 10944 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10945 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10946 Include tparam.h instead, since it declares them.
af8a867c
PE
10947 * cm.h (PC): Remove extern decl; tparam.h now does this.
10948 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10949 * terminfo.c: Include tparam.h, to check interfaces.
10950 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10951 (tparam): Adjust signature to match interface in tparam.h;
10952 this removes some undefined behavior. Check that outstring and len
10953 are zero, which they always are with Emacs.
10954 * tparam.h (PC, BC, UP): New extern decls.
10955
0248044d 10956 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10957 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10958
8ff096c1 10959 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10960 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10961 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10962 (ftfont_list): Remove unused local.
49eaafba
PE
10963 (get_adstyle_property, ftfont_pattern_entity):
10964 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10965 Rename locals to avoid shadowing.
8ff096c1 10966
e2be39f6
PE
10967 * xfont.c (xfont_list_family): Mark var as initialized.
10968
c9735e30
PE
10969 * xml.c (make_dom): Now static.
10970
8f5201ae
PE
10971 * composite.c (composition_compute_stop_pos): Rename local to
10972 avoid shadowing.
b246f932
PE
10973 (composition_reseat_it): Remove unused locals.
10974 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10975 (composition_update_it): Mark var as initialized.
11b61122
PE
10976 (find_automatic_composition): Mark vars as initialized,
10977 with a FIXME (Bug#8290).
8f5201ae 10978
760fbc2c
PE
10979 character.h: Rename locals to avoid shadowing.
10980 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10981 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10982 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10983 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10984 to avoid shadowing.
10985
ff08eb85
PE
10986 * textprop.c (property_change_between_p): Remove; unused.
10987
fc7bf025
PE
10988 * intervals.c (interval_start_pos): Now static.
10989
235d7abc
PE
10990 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10991
44f230aa
SM
10992 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10993 Rename locals to avoid shadowing.
3e7d6594 10994
50060332
PE
10995 * sound.c (wav_play, au_play, Fplay_sound_internal):
10996 Fix pointer signedness.
d01f234b 10997 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10998 (wav_play): Initialize a variable to 0, to prevent undefined
10999 behavior (Bug#8278).
50060332 11000
c4fc4e30
PE
11001 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11002
918436ed
PE
11003 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11004
c939f91b
PE
11005 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11006 clobbering (Bug#8298).
b9c7f648
PE
11007 * sysdep.c (sys_subshell): Likewise.
11008 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11009
6bd8c144
PE
11010 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11011 This should get cleaned up, so that child_setup has the
11012 same signature on all platforms.
11013
7710357c 11014 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11015 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11016
c59da222
CY
110172011-03-22 Chong Yidong <cyd@stupidchicken.com>
11018
11019 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11020 not to be necessary, and produces flickering.
11021
66b87493
GM
110222011-03-20 Glenn Morris <rgm@gnu.org>
11023
11024 * config.in: Remove file.
11025
45b6f6d5
JB
110262011-03-20 Juanma Barranquero <lekktu@gmail.com>
11027
11028 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11029 are now in src/globals.h.
11030 (syms_of_minibuf): Remove spurious & from previous change.
11031
cd394be1 110322011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11033
11034 * minibuf.c (completing-read-function): New variable.
11035 (completing-read-default): Rename from completing-read.
11036 (completing-read): Call completing-read-function.
11037
b14e3e21
CY
110382011-03-19 Juanma Barranquero <lekktu@gmail.com>
11039
11040 * xfaces.c (Fx_load_color_file):
11041 Read color file from absolute filename (bug#8250).
11042
f2b726e6
JB
110432011-03-19 Juanma Barranquero <lekktu@gmail.com>
11044
11045 * makefile.w32-in: Update dependencies.
11046
09f6ff02
EZ
110472011-03-17 Eli Zaretskii <eliz@gnu.org>
11048
11049 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11050
29a6015a
PE
110512011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11052
a3a6c54e
PE
11053 Fix more problems found by GCC 4.5.2's static checks.
11054
b766f867
PE
11055 * process.c (make_serial_process_unwind, send_process_trap):
11056 (sigchld_handler): Now static.
11057
be02381c
PE
11058 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11059 That way, the code declares only the vars that it needs.
11060 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11061 * s/cygwin.h (PTY_ITERATION): Likewise.
11062 * s/darwin.h (PTY_ITERATION): Likewise.
11063 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11064
57048744
PE
11065 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11066 * process.c (allocate_pty): Don't declare stb unless it's needed.
11067
7914961c 11068 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11069 (CONSTANTLIM): Remove; unused.
11070 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11071 Define only if needed.
7914961c 11072
b3967b18
PE
11073 * unexelf.c (unexec): Name an expression,
11074 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11075 Use a different way to cause a compilation error if anyone uses
11076 n rather than nn, a way that does not involve shadowing.
73366a00 11077 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11078
29a6015a
PE
11079 * deps.mk (unexalpha.o): Remove; unused.
11080
43cfc33e 11081 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11082 * unexec.h: New file.
ce701a33
PE
11083 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11084 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11085 Depend on unexec.h.
11086 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11087 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11088 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11089 Change as necessary to match prototype in unexec.h.
ce701a33 11090
01f44d5a
PE
11091 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11092 shadowing.
4f63c6bb 11093 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11094
a6670b0b
PE
11095 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11096 Rename locals to avoid shadowing.
11097
cef2010d 11098 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11099 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11100
d4d7173a
PE
11101 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11102
f08b802a
PE
11103 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11104 warning when compiling print.c.
11105
3ddb0639
PE
11106 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11107 instead of using an uninitialized var.
5ad03b97 11108 (font_sort_entities): Mark var as initialized.
3ddb0639 11109
170a2692
PE
11110 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11111
e663c700
PE
11112 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11113 pointers to constants.
89bc529a 11114 (font_parse_fcname): Remove unused vars.
7b81e2d0 11115 (font_delete_unmatched): Now static.
ea838e10 11116 (font_get_spec): Remove; unused.
13a547c6
PE
11117 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11118 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11119 Rename or move locals to avoid shadowing.
e663c700 11120
2a80c887 11121 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11122 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11123
1384fa33 11124 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11125 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11126
8b2c52e9
PE
11127 * alloc.c (mark_backtrace): Move decl from here ...
11128 * lisp.h: ... to here, so that it can be checked.
11129
475545b5 11130 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11131 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11132 (lisp_indirect_variable): Name an expression,
11133 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11134 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11135
b1349114 11136 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11137 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11138 Use const pointer when appropriate.
b1349114 11139
a2928364
PE
11140 * lisp.h (get_system_name, get_operating_system_release):
11141 Move decls here, to check interfaces.
11142 * process.c (get_operating_system_release): Move decl to lisp.h.
11143 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11144 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11145 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11146 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11147 (Fformat_time_string, Fencode_time, Finsert_char):
11148 (Ftranslate_region_internal, Fformat):
11149 Rename or remove local vars to avoid shadowing.
9710023e 11150 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11151
a415e694
PE
11152 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11153 avoid shadowing.
11154
8ef4622d
PE
11155 * lisp.h (eassert): Check that the argument compiles, even if
11156 ENABLE_CHECKING is not defined.
11157
946f9a5b
PE
11158 * data.c (Findirect_variable): Name an expression, to avoid
11159 gcc -Wbad-function-cast warning.
112396d6 11160 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11161 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11162 (Fmake_variable_buffer_local, Fmake_local_variable):
11163 Mark variables as initialized.
52746918 11164 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11165
e5aab7e7 11166 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11167 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11168 Rename locals to avoid shadowing.
dff45157
PE
11169 (mark_stack): Move local variables into the #ifdef region where
11170 they're used.
7bc26fdb
PE
11171 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11172 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11173 needed otherwise.
11174 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11175 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11176 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11177
e5aab7e7
PE
11178 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11179 avoids undefined behavior in theory.
11180
4da60324
PE
11181 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11182
88043301
PE
11183 Use functions, not macros, for up- and down-casing (Bug#8254).
11184 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11185 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11186 to use the following functions instead of these macros.
11187 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11188 EMACS_INT, since callers assume the returned value fits in int.
11189 (upcase1): Likewise, for UPCASE_TABLE.
11190 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11191 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11192 the race-condition problem in the old DOWNCASE.
88043301 11193
19ed5445
PE
11194 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11195 Rename locals to avoid shadowing.
11196 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11197 (regex_compile, re_search_2, re_match_2_internal):
11198 Remove unused local vars.
952db0d7
PE
11199 (FREE_VAR): Rewrite so as not to use empty "else",
11200 which gcc can warn about.
da053e48 11201 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11202 (RETALLOC_IF): Define only if needed.
11203 (WORDCHAR_P): Likewise. This one is never needed, but is used
11204 only in a comment talking about a compiler bug, so put inside
11205 the #if 0 of that comment.
11206 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11207 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11208 Remove; unused.
19ed5445 11209
1f3561e4 11210 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11211 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11212 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11213
ded6f8f7
PE
11214 * search.c (simple_search): Remove unused var.
11215
dbd37a95
PE
11216 * dired.c (compile_pattern): Move decl from here ...
11217 * lisp.h: ... to here, so that it can be checked.
11218 (struct re_registers): New forward decl.
11219
7e47afad
PE
11220 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11221
85f24f61
PE
11222 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11223 All uses changed.
11224 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11225 Rename locals to avoid shadowing.
5671df8f 11226 (Fvertical_motion): Mark locals as initialized.
85f24f61 11227
181aa2be 11228 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11229 (casify_region): Mark local as initialized.
181aa2be 11230
930d429c
PE
11231 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11232
7082eac6
PE
11233 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11234 New macros, so that the caller can use some names other than
11235 gcpro1, gcpro2, etc.
11236 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11237 of the new macros.
11238 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11239 argument, for consistency with GCPRO2_VAR, etc: it is now the
11240 prefix of the variable, not the variable itself. All uses
11241 changed.
38b2c076
PE
11242 * dired.c (directory_files_internal, file_name_completion):
11243 Rename locals to avoid shadowing.
11244
15206ed9
PE
11245 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11246 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11247 dired.c's scmp function, had undefined behavior.
11248 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11249 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11250 * buffer.h: ... to here, because these macros use current_buffer,
11251 and the new implementation with inline functions needs to have
11252 current_buffer in scope now, rather than later when the macros
11253 are used.
11254 (downcase, upcase1): New static inline functions.
11255 (DOWNCASE, UPCASE1): Reimplement using these functions.
11256 This avoids undefined behavior in expressions like
11257 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11258 from race conditions in accessing the global variables
11259 case_temp1 and case_temp2.
11260 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11261 * lisp.h (case_temp1, case_temp2): Remove their decls.
11262 * character.h (ASCII_CHAR_P): Move from here ...
11263 * lisp.h: ... to here, so that the inline functions mentioned
11264 above can use them.
11265
4a6bea26
PE
11266 * dired.c (directory_files_internal_unwind): Now static.
11267
f14b7e14
PE
11268 * fileio.c (file_name_as_directory, directory_file_name):
11269 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11270 Now static.
2893f146
PE
11271 (file_name_as_directory): Use const pointers when appropriate.
11272 (Fexpand_file_name): Likewise. In particular, newdir might
11273 point at constant storage, so make it a const pointer.
fd4ead52 11274 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11275 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11276 signedness issues.
f839df0c
PE
11277 (Fset_file_times, Finsert_file_contents, auto_save_error):
11278 Rename locals to avoid shadowing.
f14b7e14 11279
5716756e 11280 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11281 (Ftry_completion, Fall_completions): Rename or remove locals
11282 to avoid shadowing.
5716756e 11283
b4c3046a
PE
11284 * marker.c (bytepos_to_charpos): Remove; unused.
11285
b45db522
PE
11286 * lisp.h (verify_bytepos, count_markers): New decls,
11287 so that gcc does not warn that these functions aren't declared.
11288
85876d07
PE
11289 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11290 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11291 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11292 (copy_text): Remove unused local var.
85876d07 11293
03d78a21 11294 * filelock.c (within_one_second): Now static.
b3dd38ab 11295 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11296
5df8f01b
PE
11297 * buffer.c (fix_overlays_before): Mark locals as initialized.
11298 (fix_start_end_in_overlays): Likewise. This function should be
11299 simplified by using pointers-to-pointers, but that's a different
11300 matter.
b1d876f1 11301 (switch_to_buffer_1): Now static.
8f54f30a
PE
11302 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11303 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11304
a70072c9 11305 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11306 Fix pointer signedness issue.
edced198
PE
11307 (sys_subshell): Mark local as volatile if checking for lint,
11308 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11309 (MAXPATHLEN): Define only if needed.
a70072c9 11310
a0977c44
PE
11311 * process.c (serial_open, serial_configure): Move decls from here ...
11312 * systty.h: ... to here, so that they can be checked.
11313
a884fdcc
PE
11314 * fns.c (get_random, seed_random): Move extern decls from here ...
11315 * lisp.h: ... to here, so that they can be checked.
11316
604efe86 11317 * sysdep.c (reset_io): Now static.
b8950c94 11318 (wait_for_termination_signal): Remove; unused.
604efe86 11319
38fc62d9
PE
11320 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11321 (copy_keymap_item, append_key, push_text_char_description):
11322 Now static.
1004a21a 11323 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11324 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11325 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11326 (describe_map_tree):
11327 Rename locals to avoid shadowing.
38fc62d9 11328
2f2650da
PE
11329 * keyboard.c: Declare functions static if they are not used elsewhere.
11330 (echo_char, echo_dash, cmd_error, top_level_2):
11331 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11332 (read_char, kbd_buffer_get_event, make_lispy_position):
11333 (make_lispy_event, make_lispy_movement, apply_modifiers):
11334 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11335 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11336 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11337 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11338 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11339
a053e86c 11340 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11341 (mark_kboards): Move decl here ...
11342 * alloc.c (mark_kboards): ... from here.
a053e86c 11343
4752793e
PE
11344 * lisp.h (force_auto_save_soon): New decl.
11345
74f10ca7 11346 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11347 (DEFINE_DUMMY_FUNCTION): New macro.
11348 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11349 Use it.
c03cd23f
PE
11350 (main): Add casts to avoid warnings
11351 if GCC considers string literals to be constants.
74f10ca7 11352
022e70d4
PE
11353 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11354
59d6fe83
PE
11355 * dbusbind.c: Pointer signedness fixes.
11356 (xd_signature, xd_append_arg, xd_initialize):
11357 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11358 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11359 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11360 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11361
78320123
PE
11362 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11363 if GCC considers string literals to be constants.
49cebcca 11364 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11365
35ac2a97
SM
113662011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11367
fb103ca9
SM
11368 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11369 (print_preprocess, print_object): New macro to fix last change.
11370
35ac2a97
SM
11371 * print.c (print_preprocess): Don't forget font objects.
11372
62973b41
JB
113732011-03-16 Juanma Barranquero <lekktu@gmail.com>
11374
11375 * emacs.c (USAGE3): Doc fixes.
11376
0e48bb22
AS
113772011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11378
11379 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11380 structure.
11381
7684e57b
JB
113822011-03-14 Juanma Barranquero <lekktu@gmail.com>
11383
11384 * lisp.h (VWindow_system, Qfile_name_history):
11385 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11386 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11387 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11388
11389 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11390 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11391
11392 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11393 * w32console.c (detect_input_pending, read_input_pending)
11394 (encode_terminal_code):
11395 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11396 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11397 (w32_system_caret_y, Qfile_name_history):
11398 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11399 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11400 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11401 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11402 * w32proc.c (Qlocal, report_file_error):
11403 * w32term.c (Vwindow_system, updating_frame):
11404 * w32uniscribe.c (initialized, uniscribe_font_driver):
11405 Remove unneeded extern declarations.
11406
2aa46d6c
CY
114072011-03-14 Chong Yidong <cyd@stupidchicken.com>
11408
c96bbc66 11409 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11410
cffc6f3b
CY
114112011-03-13 Chong Yidong <cyd@stupidchicken.com>
11412
11413 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11414 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11415 These macros can no longer be used for assignment.
11416
44f230aa
SM
11417 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11418 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11419 (record_buffer_markers, fetch_buffer_markers): New functions for
11420 recording and fetching special buffer markers.
11421 (set_buffer_internal_1, set_buffer_temp): Use them.
11422
11423 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11424
11425 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11426
11427 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11428 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11429
11430 * xdisp.c (hscroll_window_tree):
11431 (reconsider_clip_changes): Use PT instead of BUF_PT.
11432
d251f04b
EZ
114332011-03-13 Eli Zaretskii <eliz@gnu.org>
11434
11435 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11436 $(EMACS_ROOT)/lib/intprops.h.
11437
f0c77cd1
PE
114382011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11439
3eca4629
PE
11440 Fix more problems found by GCC 4.5.2's static checks.
11441
7c86ee98
PE
11442 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11443 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11444 (xg_free_frame_widgets): Make it clear that a local variable is
11445 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11446 (gdk_window_get_screen): Make it clear that this macro is needed
11447 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11448 (int_gtk_range_get_value): New function, which avoids a diagnostic
11449 from gcc -Wbad-function-cast.
11450 (xg_set_toolkit_scroll_bar_thumb): Use it.
11451 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11452 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11453 (get_utf8_string, xg_get_file_with_chooser):
11454 Rename locals to avoid shadowing.
11455 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11456
41729b81
PE
11457 * xgselect.c (xg_select): Remove unused var.
11458
f0c77cd1
PE
11459 * image.c (four_corners_best): Mark locals as initialized.
11460 (gif_load): Initialize transparent_p to zero (Bug#8238).
11461 Mark another local as initialized.
ec6cf4c6 11462 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11463
ce0ad53d 11464 * image.c (clear_image_cache): Now static.
d5d5a617 11465 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11466 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11467 (x_edge_detection): Remove unnecessary cast that
11468 gcc -Wbad-function-cast diagnoses.
2037898d 11469 (gif_load): Fix pointer signedness.
6ae141d6
PE
11470 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11471 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11472
33383987 114732011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11474
d32df629
PE
11475 Improve quality of tests for time stamp overflow.
11476 For example, without this patch (encode-time 0 0 0 1 1
11477 1152921504606846976) returns the obviously-bogus value (-948597
11478 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11479 reports time overflow. See
11480 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11481 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11482 * editfns.c: Include limits.h and intprops.h.
11483 (TIME_T_MIN, TIME_T_MAX): New macros.
11484 (time_overflow): Move earlier, to before first use.
11485 (hi_time, lo_time): New functions, for an accurate test for
11486 out-of-range times.
11487 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11488 (Fget_internal_run_time): Don't assume time_t fits in int.
11489 (make_time): Use list2 instead of Fcons twice.
11490 (Fdecode_time): More accurate test for out-of-range times.
11491 (check_tm_member): New function.
11492 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11493 (lisp_time_argument): Don't rely on undefined left-shift and
11494 right-shift behavior when checking for time stamp overflow.
8be6f318 11495
fe31d94c
PE
11496 * editfns.c (time_overflow): New function, refactoring common code.
11497 (Fformat_time_string, Fdecode_time, Fencode_time):
11498 (Fcurrent_time_string): Use it.
11499
8be6f318
PE
11500 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11501 * dired.c (make_time): Move to ...
11502 * editfns.c (make_time): ... here.
11503 * systime.h: Note the move.
11504
09d9db2c 115052011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11506
126bc0dc
YM
11507 * fringe.c (update_window_fringes): Remove unused variables.
11508
c47cbdfd
YM
11509 * unexmacosx.c (copy_data_segment): Also copy __got section.
11510 (Bug#8223)
11511
7ac80be9
EZ
115122011-03-12 Eli Zaretskii <eliz@gnu.org>
11513
c96bbc66 11514 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11515 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11516 Constify `char *' arguments and their references according to
11517 prototypes in tparam.h.
11518
ecb0f94d 11519 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11520
7ac80be9
EZ
11521 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11522 Adapt all references accordingly.
11523
11524 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11525
ef1fd07e
TT
115262011-03-11 Tom Tromey <tromey@redhat.com>
11527
11528 * buffer.c (syms_of_buffer): Remove obsolete comment.
11529
7ef4b50c
EZ
115302011-03-11 Eli Zaretskii <eliz@gnu.org>
11531
11532 * termhooks.h (encode_terminal_code): Declare prototype.
11533
11534 * msdos.c (encode_terminal_code): Don't declare prototype.
11535
11536 * term.c (encode_terminal_code): Now external again, used by
11537 w32console.c and msdos.c.
11538
44f230aa
SM
11539 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11540 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11541
4b1ec863 115422011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11543
1714f52b 11544 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11545
4b1ec863
PE
11546 * fringe.c (update_window_fringes): Mark locals as initialized
11547 (Bug#8227).
11548 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11549
524c7aa6
PE
11550 * alloc.c (mark_fringe_data): Move decl from here ...
11551 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11552 to check its interface.
11553 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11554
a5c0af81 11555 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11556 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11557 (fontset_font): Mark local as initialized.
a9a06e0b 11558 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11559
b4716021
PE
11560 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11561
811e9bac 11562 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11563 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11564 (x_own_selection, Fx_disown_selection_internal): Rename locals
11565 to avoid shadowing.
11566 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11567
7e3ab302
PE
11568 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11569 so that the caller can use some name other than gcpro1.
11570 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11571 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11572 (Fx_backspace_delete_keys_p):
11573 Use them to avoid shadowing, and rename vars to avoid shadowing.
11574 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11575 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11576 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11577 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11578 Remove unused locals.
7e3ab302
PE
11579 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11580 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11581 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11582 macros.
f78faa98 11583
e2b13473
PE
11584 * xterm.h (x_mouse_leave): New decl.
11585
77f23912
PE
11586 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11587 Remove unused functions.
cdf4ba58
PE
11588 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11589 (x_calc_absolute_position): Now static.
7411c686 11590 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11591 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11592 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11593 unless they are used.
38d0b34a
PE
11594 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11595 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11596 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11597 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11598 (x_error_catcher, x_connection_closed, x_error_handler):
11599 (x_error_quitter, xembed_send_message, x_iconify_frame):
11600 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11601 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11602 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11603
44f230aa
SM
11604 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11605 Rename or move locals to avoid shadowing.
6b463e58 11606 (tty_defined_color, merge_face_heights): Now static.
5967d051 11607 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11608 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11609 does not deduce is never used uninitialized.
73719eba
PE
11610 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11611 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11612
426994c3 11613 * terminal.c (store_terminal_param): Now static.
5489860b 11614
032f1620 11615 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11616 (set_frame_menubar): Remove unused local.
d4323972 11617 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11618 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11619 since they might point to immutable storage.
281585b0
PE
11620 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11621 since it's unused otherwise.
032f1620 11622
367c19e5 11623 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11624 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11625 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11626 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11627 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11628 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11629 does not deduce are never used uninitialized.
70739cbe 11630
07b48fa9
PE
11631 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11632
8868a238 11633 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11634 * window.c (window_loop, size_window):
11635 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11636
7e5cf297 11637 * window.c (display_buffer): Now static.
d6550a9f
PE
11638 (size_window): Mark variables that gcc -Wuninitialized
11639 does not deduce are never used uninitialized.
a586633d
PE
11640 * window.h (check_all_windows): New decl, to forestall
11641 gcc -Wmissing-prototypes diagnostic.
5b555da1 11642 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11643
f6095868
PE
11644 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11645 shadowing.
11646 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11647 Include <limits.h>.
11648 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11649 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11650 (load_charset_map): Mark variables that gcc -Wuninitialized
11651 does not deduce are never used uninitialized.
53df7c11 11652 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11653
f38b440c
PE
11654 * coding.c (coding_set_source, coding_set_destination):
11655 Use "else { /* comment */ }" rather than "else /* comment */;"
11656 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11657 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11658 a block, when the outer 'i' will do.
11659 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11660 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11661 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11662 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11663 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11664 Rename locals to avoid shadowing.
11665 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11666 * coding.c (emacs_mule_char, encode_invocation_designation):
11667 Now static, since they're not used elsewhere.
413bb2db 11668 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11669 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11670 (decode_coding_emacs_mule): Mark variables that gcc
11671 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11672 (detect_coding_iso_2022): Initialize a local variable that might
11673 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11674 this initialization is needed. (Bug#8211)
5f58e762
PE
11675 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11676 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11677 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11678 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11679 Remove unused macros.
f38b440c 11680
232b38b9 11681 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11682 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11683 * character.c (string_count_byte8): Likewise.
232b38b9 11684
fb90da1b
PE
11685 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11686 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11687
fb93dbc2
PE
11688 * chartab.c (copy_sub_char_table): Now static, since it's not used
11689 elsewhere.
5c156ace
PE
11690 (sub_char_table_ref_and_range, char_table_ref_and_range):
11691 Rename locals to avoid shadowing.
bbcd0949 11692 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11693
7d3b3862 11694 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11695 (BIDI_BOB): Remove unused macro.
7d3b3862 11696
6be7d3da
PE
11697 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11698 deduce are never used uninitialized.
c2ed9c8b 11699 * term.c (encode_terminal_code): Likewise.
6be7d3da 11700
75f8807f 11701 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11702
50938595
PE
11703 * tparam.h: New file.
11704 * term.c, tparam.h: Include it.
11705 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11706 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11707 Move these decls to tparam.h, and make them agree with what
11708 is actually in tparam.c. The previous trick of using incompatible
11709 decls in different modules does not conform to the C standard.
11710 All callers of tparam changed to use tparam's actual API.
11711 * tparam.c (tparam1, tparam, tgoto):
11712 Use const pointers where appropriate.
11713
fbceeba2
PE
11714 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11715 * cm.h (struct cm): Likewise.
11716 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11717 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11718 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11719 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11720 (turn_on_face, init_tty): Likewise.
11721 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11722
7f3f1250
PE
11723 * term.c (term_mouse_position): Rename local to avoid shadowing.
11724
e6ca6543
PE
11725 * alloc.c (mark_ttys): Move decl from here ...
11726 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11727
c40f8d15
AS
117282011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11729
11730 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11731
cfe0661d
JB
117322011-03-09 Juanma Barranquero <lekktu@gmail.com>
11733
11734 * search.c (compile_pattern_1): Remove argument regp, unused since
11735 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11736 (compile_pattern): Don't pass it.
11737
0afb4571
J
117382011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11739
11740 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11741 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11742 for ! HAVE_GTK3.
11743 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11744
11745 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11746
11747 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11748 gdk_window_get_screen, gdk_window_get_geometry,
11749 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11750 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11751 (xg_get_pixbuf_from_pixmap): New function.
11752 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11753 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11754 Call xg_get_pixbuf_from_pixmap instead of
11755 gdk_pixbuf_get_from_drawable.
11756 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11757 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11758 (xg_check_special_colors): Use GtkStyleContext and its functions
11759 for HAVE_GTK3.
11760 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11761 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11762 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11763 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11764 Call gtk_widget_get_preferred_size.
0afb4571
J
11765 (xg_frame_resized): gdk_window_get_geometry only takes 5
11766 parameters.
44f230aa
SM
11767 (xg_win_to_widget, xg_event_is_for_menubar):
11768 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11769 (xg_set_widget_bg): New function.
11770 (delete_cb): New function.
895009e1 11771 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11772 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11773 (xg_set_background_color): Call xg_set_widget_bg.
11774 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11775 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11776 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11777 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11778 if ! HAVE_GTK3.
11779 (update_frame_tool_bar): Call gtk_widget_hide.
11780 (xg_initialize): Use GDK_KEY_g.
11781
11782 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11783 if ! HAVE_GTK3
11784 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11785
11786 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11787 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11788 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11789
1c2cc4ef
JB
117902011-03-08 Juanma Barranquero <lekktu@gmail.com>
11791
11792 * w32xfns.c (select_palette): Check success of RealizePalette against
11793 GDI_ERROR, not zero.
11794
33383987 11795See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11796
11797;; Local Variables:
11798;; coding: utf-8
aac0c6e3
MR
11799;; End:
11800
2f097256 11801 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11802
11803 This file is part of GNU Emacs.
11804
11805 GNU Emacs is free software: you can redistribute it and/or modify
11806 it under the terms of the GNU General Public License as published by
11807 the Free Software Foundation, either version 3 of the License, or
11808 (at your option) any later version.
11809
11810 GNU Emacs is distributed in the hope that it will be useful,
11811 but WITHOUT ANY WARRANTY; without even the implied warranty of
11812 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11813 GNU General Public License for more details.
11814
11815 You should have received a copy of the GNU General Public License
11816 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.