Completely remove stringp check in special-display-p.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
96a313a1
CY
12012-06-17 Chong Yidong <cyd@gnu.org>
2
3 * xdisp.c (redisplay_internal): No need to redisplay terminal
4 frames that are not on top.
5
20ca2e94
TN
62012-06-17 Troels Nielsen <bn.troels@gmail.com>
7
8 * process.c (make_process): Initialize write_queue.
9 (write_queue_push, write_queue_pop): New functions.
10 (send_process): Use them to maintain correct ordering of process
11 writes (Bug#10815).
12
9a900ca9
PE
132012-06-17 Paul Eggert <eggert@cs.ucla.edu>
14
310fbfa8
PE
15 * lisp.h (eassert): Assume C89 or later.
16 This removes the need for CHECK.
17 (CHECK): Remove. Its comments about always evaluating its
18 argument were confusing, as 'eassert' typically does not evaluate
19 its argument.
20
27bb1ca4
PE
21 * coding.c (produce_chars): Use ptrdiff_t, not int.
22
9a900ca9
PE
23 * xterm.c (x_draw_underwave): Check for integer overflow.
24 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
25
41b7f8bc 262012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
27
28 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
29 referenced (Bug#11583).
30
9b0e3eba
AA
312012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
32
33 Implement wave-style variant of underlining.
34 * dispextern.h (face_underline_type): New enum.
35 (face): Add field for underline type.
36 * nsterm.m (ns_draw_underwave): New function.
37 (ns_draw_text_decoration): Use it.
38 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
39 New functions.
40 (x_draw_glyph_string): Use them.
41 * xfaces.c (Qline, Qwave): New Lisp objects.
42 (check_lface_attrs, merge_face_ref)
43 (Finternal_set_lisp_face_attribute, realize_x_face): Handle
44 wave-style underline face attributes.
45 * xterm.c (x_draw_underwave): New function.
46 (x_draw_glyph_string): Use it.
47
0fb52f11
JB
482012-06-16 Juanma Barranquero <lekktu@gmail.com>
49
50 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
51 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
52 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
53 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
54 ($(BLD)/w32select.$(O)): Update dependencies.
55
e5560ff7
AS
562012-06-16 Andreas Schwab <schwab@linux-m68k.org>
57
58 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
59 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
60 * character.c (_fetch_multibyte_char_p): Remove.
61 * alloc.c: Include "character.h" before "buffer.h".
62 * bidi.c: Likewise.
63 * buffer.c: Likewise.
64 * bytecode.c: Likewise.
65 * callint.c: Likewise.
66 * callproc.c: Likewise.
67 * casefiddle.c: Likewise.
68 * casetab.c: Likewise.
69 * category.c: Likewise.
70 * cmds.c: Likewise.
71 * coding.c: Likewise.
72 * composite.c: Likewise.
73 * dired.c: Likewise.
74 * dispnew.c: Likewise.
75 * doc.c: Likewise.
76 * dosfns.c: Likewise.
77 * editfns.c: Likewise.
78 * emacs.c: Likewise.
79 * fileio.c: Likewise.
80 * filelock.c: Likewise.
81 * font.c: Likewise.
82 * fontset.c: Likewise.
83 * fringe.c: Likewise.
84 * indent.c: Likewise.
85 * insdel.c: Likewise.
86 * intervals.c: Likewise.
87 * keyboard.c: Likewise.
88 * keymap.c: Likewise.
89 * lread.c: Likewise.
90 * macros.c: Likewise.
91 * marker.c: Likewise.
92 * minibuf.c: Likewise.
93 * nsfns.m: Likewise.
94 * nsmenu.m: Likewise.
95 * print.c: Likewise.
96 * process.c: Likewise.
97 * regex.c: Likewise.
98 * region-cache.c: Likewise.
99 * search.c: Likewise.
100 * syntax.c: Likewise.
101 * term.c: Likewise.
102 * textprop.c: Likewise.
103 * undo.c: Likewise.
104 * unexsol.c: Likewise.
105 * w16select.c: Likewise.
106 * w32fns.c: Likewise.
107 * w32menu.c: Likewise.
108 * window.c: Likewise.
109 * xdisp.c: Likewise.
110 * xfns.c: Likewise.
111 * xmenu.c: Likewise.
112 * xml.c: Likewise.
113 * xselect.c: Likewise.
114
2f07e6af
EZ
1152012-06-16 Eli Zaretskii <eliz@gnu.org>
116
117 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end. If
118 all the glyphs of the glyph row came from strings, and we have no
119 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
120 row.
121 (handle_face_prop): Use chunk-relative overlay string index when
122 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
123 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
124 the rightmost. (Bug#11720)
2f07e6af 125
29b83cec
AS
1262012-06-16 Andreas Schwab <schwab@linux-m68k.org>
127
128 * category.h (CHAR_HAS_CATEGORY): Define as inline.
129 (CATEGORY_MEMBER): Enforce 1/0 value.
130 * category.c (_temp_category_set): Remove.
131
4c5501e9
EZ
1322012-06-16 Eli Zaretskii <eliz@gnu.org>
133
134 * window.c (Fdelete_other_windows_internal)
135 (Fdelete_window_internal): Don't access frame's mouse highlight
136 info of the initial frame. (Bug#11677)
137
2b570124
PE
1382012-06-14 Paul Eggert <eggert@cs.ucla.edu>
139
e93864f9
PE
140 * .gdbinit (xgetint): Fix recently-introduced paren typo.
141 Assume USE_2_TAGS_FOR_INTS.
142 (xreload): Adjust $tagmask width to match recent lisp.h change.
143
2b570124
PE
144 Simplify lisp.h in minor ways that should not affect code.
145 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
146 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
147 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
148 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
149 (INTTYPEBITS): New macro, for clarity.
150 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
151 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
152 now that USE_LSB_TAG is always defined.
153 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
154 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
155
81755f69
JB
1562012-06-13 Juanma Barranquero <lekktu@gmail.com>
157
158 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
159
16192a57
GM
1602012-06-13 Glenn Morris <rgm@gnu.org>
161
162 * s/bsd-common.h (BSD4_3):
163 * s/usg5-4-common.h (USG5_4): No longer define; unused.
164
646b5f55
AS
1652012-06-13 Andreas Schwab <schwab@linux-m68k.org>
166
167 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
168 instead of union.
169 (XLI, XIL): Define.
170 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
171 them.
172 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
173 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
174 * alloc.c (widen_to_Lisp_Object): Removed.
175 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
176 * frame.c (delete_frame): Remove outdated comment.
177 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
178 USE_LISP_UNION_TYPE.
179 (Fw32_unregister_hot_key): Likewise.
180 (Fw32_toggle_lock_key): Likewise.
181 * w32menu.c (add_menu_item): Likewise.
182 (w32_menu_display_help): Use XIL instead of checking
183 USE_LISP_UNION_TYPE.
184 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
185 (init_heap): Likewise.
186 * w32term.c (w32_read_socket): Update comment.
187
1d3823c9
GM
1882012-06-13 Glenn Morris <rgm@gnu.org>
189
c62ff706
GM
190 * s/usg5-4-common.h, src/s/unixware.h:
191 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
192
1d3823c9
GM
193 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
194
bfe3e0a2
PE
1952012-06-13 Paul Eggert <eggert@cs.ucla.edu>
196
197 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
198 * alloc.c (make_number) [!defined make_number]:
199 Remove, as lisp.h always defines this now.
200 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
201 (roundup_size): Verify that it is a power of 2.
202 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
203 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
204 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
205 -DUSE_LSB_TAG=0, to override the automatically-selected default.
206 USE_LSB_TAG now is always defined to be either 0 or 1.
207 All uses changed.
208 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
209 code works fine either way, and efficiency is not a concern here,
210 as the union type is for debugging, not for production.
211 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
212 Use an inline function on all platforms when using the union type,
213 since this is simpler and 'static inline' can be used portably
214 within Emacs now.
215 (LISP_INITIALLY_ZERO): New macro.
216 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
217 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
218
45fa9c0f
GM
2192012-06-12 Glenn Morris <rgm@gnu.org>
220
b4492cba
GM
221 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
222
223 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 224
45fa9c0f
GM
225 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
226 Move BROKEN_SIGIO to configure.
227
228 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
229 Move NO_TERMIO to configure.
230
0e25d334
CY
2312012-06-12 Chong Yidong <cyd@gnu.org>
232
233 * image.c (imagemagick_load_image): Use MagickFlattenImage if
234 MagickMergeImageLayers is undefined. Use pixel pusher loop if
235 MagickExportImagePixels is undefined.
236
43682bb6
PE
2372012-06-12 Paul Eggert <eggert@cs.ucla.edu>
238
239 * image.c (imagemagick_load_image): Remove unused label.
240
a9be7d2b
GM
2412012-06-11 Glenn Morris <rgm@gnu.org>
242
243 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
244 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
245 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
246 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
247
3017f87f
SM
2482012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
249
250 * alloc.c (make_byte_code): New function.
251 (Fmake_byte_code): Use it. Don't purify here.
252 * lread.c (read1): Use it as well to avoid extra allocation.
253
1b9b4cf4
CY
2542012-06-11 Chong Yidong <cyd@gnu.org>
255
256 * image.c (imagemagick_load_image): Implement transparency.
257
95988fcf
AS
2582012-06-10 Andreas Schwab <schwab@linux-m68k.org>
259
260 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
261 account for preceding backslashes. (Bug#11663)
262
cd4eb164
CY
2632012-06-09 Chong Yidong <cyd@gnu.org>
264
265 * term.c: Support italics in capable terminals (Bug#9652).
266 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
267 (turn_on_face): Output using TS_enter_italic_mode if available.
268 Don't handle unused blinking and alt-charset cases.
269 (turn_off_face): Handle italic case; discard unused tty_blinking_p
270 and tty_alt_charset_p cases.
271 (tty_capable_p, init_tty): Support italics.
272
273 * termchar.h (struct tty_display_info): Add field for italics.
274 Remove unused blink field.
275
276 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
277 Handle slant.
278
279 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
280 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
281 tty_alt_charset_p. Add tty_italic_p.
282
ff88beb8
MA
2832012-06-09 Michael Albinus <michael.albinus@gmx.de>
284
285 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
286 dbus_type_is_basic if available.
287 (xd_extract_signed, xd_extract_unsigned): Rename from
288 extract_signed and extract_unsigned, respectively. Adapt callers.
289
44286096
CY
2902012-06-09 Chong Yidong <cyd@gnu.org>
291
1682701f
CY
292 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
293
44286096
CY
294 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
295 case (Bug#9752).
296
d86feb17
PE
2972012-06-08 Paul Eggert <eggert@cs.ucla.edu>
298
299 * xdisp.c (vmessage): Treat frame message as multibyte.
300 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
301 would generate the diagnostic "Making \302\247 buffer-local while
302 let-bound!".
303
d5c20fe8
EZ
3042012-06-08 Eli Zaretskii <eliz@gnu.org>
305
306 * dispnew.c (showing_window_margins_p): Undo last change, which
307 was done due to an inadvertent commit.
308 (adjust_frame_glyphs_for_frame_redisplay): Do call
309 showing_window_margins_p.
310
513749ee
SM
3112012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
312
313 * eval.c (Fmake_var_non_special): New primitive.
314 (syms_of_eval): Defsubr it.
315 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
316
d4a8f5c1
JB
3172012-06-08 Juanma Barranquero <lekktu@gmail.com>
318
319 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
320 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
321
8bbbc977
EZ
3222012-06-08 Eli Zaretskii <eliz@gnu.org>
323
324 * alloc.c (allocate_vectorlike): Fix last change.
325
f3372c87
DA
3262012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
327
328 Block-based vector allocation of small vectors.
329 * lisp.h (struct vectorlike_header): New field `nbytes',
330 adjust comment accordingly.
331 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
332 to denote vector blocks. Adjust users (live_vector_p,
333 mark_maybe_pointer, valid_lisp_object_p) accordingly.
334 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
335 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
336 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
337 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
338 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
339 (roundup_size): New constant.
340 (struct vector_block): New data type.
341 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 342 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
343 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
344 (sweep_vectors): New functions.
345 (allocate_vectorlike): Return `zero_vector' as the only vector of
346 0 items. Allocate new vector from block if vector size is less than
347 or equal to VBLOCK_BYTES_MAX.
348 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
349 (init_alloc_once): Add call to init_vectors.
350
4f18a4ed
SM
3512012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
352
353 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
354
86f158bc
PE
3552012-06-07 Paul Eggert <eggert@cs.ucla.edu>
356
357 * doprnt.c (doprnt): Truncate multibyte char correctly.
358 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
359 would mishandle a string argument "Xc" if X was a multibyte
360 character of length 2: it would truncate after X's first byte
361 rather than including all of X.
362
c5cfcbe0
CY
3632012-06-06 Chong Yidong <cyd@gnu.org>
364
365 * buffer.c (word_wrap): Doc fix.
366
c05cf390
PE
3672012-06-04 Paul Eggert <eggert@cs.ucla.edu>
368
369 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
370
0c3461de
GM
3712012-06-03 Glenn Morris <rgm@gnu.org>
372
373 * xdisp.c (tool-bar-style): Doc fix.
374
c71232db
UM
3752012-06-03 Ulrich Müller <ulm@gentoo.org>
376
377 * Makefile.in (PAXCTL): Define.
378 (temacs$(EXEEXT)): Disable memory randomization for the temacs
379 binary via PaX flags if the paxctl utility is available.
380 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
381 Restore PaX flags to their default. (Bug#11398)
382
383f7350
CY
3832012-06-03 Chong Yidong <cyd@gnu.org>
384
385 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
386 buffer (Bug#11226).
387
5f2c76c6
CY
3882012-06-03 Chong Yidong <cyd@gnu.org>
389
390 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
391 (note_mode_line_or_margin_highlight): If there is no help echo,
392 use mode-line-default-help-echo. Handle the case where the mouse
393 position is past the end of the mode line string.
394
395 * buffer.c (buffer_local_value_1): New function, split from
396 Fbuffer_local_value; can return Qunbound.
397 (Fbuffer_local_value): Use it.
398 (Vmode_line_format): Docstring tweaks.
399
773d47f6
PE
4002012-06-02 Paul Eggert <eggert@cs.ucla.edu>
401
402 * sysdep.c (system_process_attributes): Improve comment.
403
f2d6a3df
SM
4042012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
405
406 * keyboard.c: Export real-this-command to Elisp.
407 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
408 and DEFVAR it. Update all users.
409
63810350
PE
4102012-06-02 Paul Eggert <eggert@cs.ucla.edu>
411
7bd5c1f4
PE
412 * minibuf.c (Fassoc_string): Remove duplicate declaration.
413
63810350
PE
414 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
415 Convert pctcpu and pctmem to Lisp float properly.
416 Let the compiler fold better, as 100.0/0x8000 is exact.
417
a2821611
AS
4182012-06-02 Andreas Schwab <schwab@linux-m68k.org>
419
420 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
421 cons_block.
422
5fceba1d
PE
4232012-06-01 Paul Eggert <eggert@cs.ucla.edu>
424
425 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
426
c98ff5dd
DA
4272012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
428
429 For a 'struct window', replace some Lisp_Object fields to
430 bitfields where appropriate, remove unused fields.
431 * window.h (struct window): Remove unused 'last_mark_x' and
432 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
433 change it's type from Lisp_Object to bitfield.
434 Change type of 'force_start', 'optional_new_start',
435 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
436 fields from Lisp_Object to bitfield. Adjust users accordingly.
437
ca34e0be
PE
4382012-05-31 Paul Eggert <eggert@cs.ucla.edu>
439
440 Pacify gcc -Wdouble-precision when using Xaw.
441 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
442 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
443 Use 'float' consistently, rather than 'float' in most places
444 and 'double' in a couple of places.
445
efc00ab1 4462012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
447
448 * xdisp.c (handle_stop): Detect whether we have overlay strings
449 loaded by testing it->current.overlay_string_index to be
450 non-negative, instead of checking whether n_overlay_strings is
451 positive. (Bug#11587)
452
efc00ab1 4532012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
454
455 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
456
457 * doc.c (Fsubstitute_command_keys): Doc fix.
458
efc00ab1 4592012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
460
461 * search.c (search_buffer): Remove calls to
462 r_alloc_inhibit_buffer_relocation, as it is now called by
463 maybe_unify_char, which was the cause of relocation of buffer text
464 in bug#11519.
465
efc00ab1 4662012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
467
468 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
469 for the duration of call to load_charset, to avoid problems with
470 callers of maybe_unify_char that access buffer text through C
471 pointers.
472
473 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
474 decrement the inhibition flag, instead of just setting or
475 resetting it.
476
ba93a187
PE
4772012-05-31 Paul Eggert <eggert@cs.ucla.edu>
478
479 Remove obsolete '#define static' cruft.
480 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
481 This #undef was "temporary" in 2000; it is no longer needed
482 now that '#define static' has gone away.
483 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
484 (gray_bitmap_bits): Remove; no longer needed.
485 All uses replaced with definiens.
486 * xterm.c: Include "bitmaps/gray.xbm".
487
9e4bf381
PE
4882012-05-30 Paul Eggert <eggert@cs.ucla.edu>
489
490 Clean up __executable_start, monstartup when --enable-profiling.
491 The following changes affect the code only when profiling.
492 * dispnew.c (__executable_start): Rename from safe_bcopy.
493 Define only on platforms that need it.
494 * emacs.c: Include <sys/gmon.h> when profiling.
495 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
496 (__executable_start): Remove decl, since lisp.h does it now.
497 (safe_bcopy): Remove decl; no longer has that name.
498 (main): Coalesce #if into single bit of code, for simplicity.
499 Cast pointers to uintptr_t, since standard libraries want integers
500 and not pointers.
501 * lisp.h (__executable_start): New decl.
502
32d72c2f
GM
5032012-05-31 Glenn Morris <rgm@gnu.org>
504
505 * image.c (Fimagemagick_types): Doc fix.
506
baac5bc7
JM
5072012-05-30 Jim Meyering <meyering@redhat.com>
508
509 * callproc.c (Fcall_process_region): Include directory component
510 in mkstemp error message (Bug#11586).
511
72cb32cf
PE
5122012-05-30 Paul Eggert <eggert@cs.ucla.edu>
513
514 * alloc.c, lisp.h (make_pure_vector): Now static.
515
61b108cc
SM
5162012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
517
518 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
519 Move to byte-run.el.
520 (Fautoload): Do the hash-doc more carefully.
521 * data.c (Fdefalias): Purify definition, except for keymaps.
522 (Qdefun): Move from eval.c.
523 * lisp.h (Qdefun): Remove.
524 * lread.c (read1): Tiny simplification.
525
471fe23d
TN
5262012-05-29 Troels Nielsen <bn.troels@gmail.com>
527
934f3f58 528 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
529 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
530 Bug#9642, but explicitly check that the buffer the overlay would
531 be moved to is live and rearrange lines to make sure that errors
532 will not put the overlay in an inconsistent state.
533 (Fdelete_overlay): Cosmetics.
534
85d0efd1
EZ
5352012-05-28 Eli Zaretskii <eliz@gnu.org>
536
537 * w32term.c (my_bring_window_to_top): New function.
538 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
539 could be different from the original one.
540 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
541 (Bug#11513)
542
543 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
544 by calling BringWindowToTop.
545
546 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
547 (WM_EMACS_END): Increase by one.
548
da92a98c
PE
5492012-05-28 Paul Eggert <eggert@cs.ucla.edu>
550
551 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
552 This avoids undefined behavior that might cause the eassert
553 to not catch an out-of-range value.
554
74d1f848
JB
5552012-05-28 Juanma Barranquero <lekktu@gmail.com>
556
557 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
558 Update dependencies.
559
9e1a06fc
EZ
5602012-05-27 Eli Zaretskii <eliz@gnu.org>
561
562 * bidi.c (bidi_mirror_char): Fix last change.
563
f3dd7312
AS
5642012-05-27 Andreas Schwab <schwab@linux-m68k.org>
565
566 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
567 when referring to sectname field in printf format.
568
81899c91
PE
5692012-05-27 Paul Eggert <eggert@cs.ucla.edu>
570
57b81a9f
PE
571 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
572 Only r_alloc_inhibit_buffer_relocation needed to be added;
573 the others were already declared.
574
81899c91
PE
575 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
576 before checking whether it's out of range. Put the check inside
577 eassert. See
578 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
579
33017faf 5802012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
581
582 * callproc.c (Fcall_process): Restore a line that was accidentally
583 commented out in the 2011-02-13 change (bug#11547).
584
33017faf 5852012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
586
587 * lisp.h [REL_ALLOC]: Add prototypes for external functions
588 defined on ralloc.c.
589
590 * buffer.c [REL_ALLOC]: Remove prototypes of
591 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
592 they are now on lisp.h.
593
594 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
595
596 * search.c (search_buffer): Use it to inhibit relocation of buffer
597 text while re_search_2 is doing its job, because re_search_2 is
598 passed C pointers to buffer text. (Bug#11519)
599
23415acf
EZ
600 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
601 Update value to 24.
602
44e27368
EZ
603 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
604 state after an additional call to move_it_in_display_line_to, keep
605 the values of it->max_ascent and it->max_descent found for the
606 entire line.
607 (pos_visible_p): Revert the comparison against bottom_y to what it
608 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
609 (Bug#11464)
610
c1892f11
PE
6112012-05-26 Paul Eggert <eggert@cs.ucla.edu>
612
613 Fix coding-related core dumps with gcc -ftrapv.
614 The code was computing A - B, where A and B are pointers, and B is
615 random garbage. This can lead to core dumps on platforms that
616 have special pointer registers, and it also leads to core dumps on
617 x86-64 when compiled with gcc -ftrapv. The fix is to compute
618 A - B only when B is initialized properly.
619 * coding.c (coding_set_source, coding_set_destination): Return void.
620 (coding_change_source, coding_change_destinations): New functions,
621 with the old behaviors of coding_set_source and coding_set_destination.
622 All callers that need an offset changed to use these new functions.
623
eb7afdad
GM
6242012-05-26 Glenn Morris <rgm@gnu.org>
625
626 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
627
f12fdf02
EZ
6282012-05-26 Eli Zaretskii <eliz@gnu.org>
629
53a63be6 630 Extend mouse support on W32 text-mode console.
61b108cc
SM
631 * xdisp.c (draw_row_with_mouse_face):
632 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 633
eb3f6f01 634 * w32console.c: Include window.h.
61b108cc
SM
635 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
636 New functions.
eb3f6f01
EZ
637 (initialize_w32_display): Initialize mouse-highlight data.
638
53a63be6
EZ
639 * w32inevt.c: Include termchar.h and window.h.
640 (do_mouse_event): Support mouse-autoselect-window. When the mouse
641 moves, call note_mouse_highlight. If help_echo changed, call
642 gen_help_event to produce help-echo message in the echo area.
643 Call clear_mouse_face if mouse_face_hidden is set in the mouse
644 highlight info.
645
4cfd81f6
PE
6462012-05-26 Paul Eggert <eggert@cs.ucla.edu>
647
648 * lread.c (read1): Simplify slightly to avoid an overflow warning
649 with GCC 4.7.0 on x86-64.
650
4446092a
EZ
6512012-05-26 Eli Zaretskii <eliz@gnu.org>
652
653 * bidi.c (bidi_mirror_char): Revert last change: an int is
654 definitely wide enough here.
655
42b2a986 6562012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 657
42b2a986 658 Fix integer width and related bugs (Bug#9874).
eb106a49 659 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
660 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
661 (string_bytes, check_sblock, allocate_string_data):
662 (compact_small_strings, Fmake_bool_vector, make_string)
663 (make_unibyte_string, make_multibyte_string)
664 (make_string_from_bytes, make_specified_string)
665 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
666 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
667 (mark_vectorlike):
668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
669 (allocate_pseudovector):
670 Use int, not EMACS_INT, where int is wide enough.
671 (inhibit_garbage_collection, Fgarbage_collect):
672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
673 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
674 int might not be wide enough.
675 (bidi_cache_search, bidi_cache_find, bidi_init_it)
676 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
677 (bidi_at_paragraph_end, bidi_find_paragraph_start)
678 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
679 (bidi_level_of_next_char, bidi_move_to_visually_next):
680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
681 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
682 (Fkill_buffer, Fset_buffer_major_mode)
683 (advance_to_char_boundary, Fbuffer_swap_text)
684 (Fset_buffer_multibyte, overlays_at, overlays_in)
685 (overlay_touches_p, struct sortvec, record_overlay_string)
686 (overlay_strings, recenter_overlay_lists)
687 (adjust_overlays_for_insert, adjust_overlays_for_delete)
688 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
689 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
690 (Foverlay_recenter, last_overlay_modification_hooks_used)
691 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
693 (validate_region): Omit unnecessary test for b <= e,
694 since that's guaranteed by the previous test.
d311d28c
PE
695 (adjust_overlays_for_delete): Avoid pos + length overflow.
696 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
697 (report_overlay_modification):
698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
699 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
700 Omit pointer cast, which isn't needed anyway, and doesn't work
701 after the EMACS_INT -> ptrdiff_t change.
02481186 702 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
703 * buffer.h: Adjust decls to match defn changes elsewhere.
704 (struct buffer_text, struct buffer):
705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
706 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
707 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
708 not int, to avoid needless 32-bit limit on 64-bit hosts.
709 (exec_byte_code): Use tighter memory-full test, one that checks
710 for alloca overflow. Don't compute the address of the object just
711 before an array, as that's not portable. Use EMACS_INT, not
712 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
713 * callint.c (Fcall_interactively):
714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
715 * callproc.c (call_process_kill, Fcall_process):
716 Don't assume pid_t fits into an Emacs fixnum.
717 (call_process_cleanup, Fcall_process, child_setup):
718 Don't assume pid_t fits into int.
719 (call_process_cleanup, Fcall_process, delete_temp_file)
720 (Fcall_process_region):
721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
722 (Fcall_process): Simplify handling of volatile integers.
723 Use int, not EMACS_INT, where int will do.
724 * casefiddle.c (casify_object, casify_region, operate_on_word)
725 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
727 (casify_object): Avoid integer overflow when overallocating buffer.
728 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 729 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
730 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
731 * category.h (CATEGORYP): Don't assume arg is nonnegative.
732 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
733 integers are now checked earlier. All uses replaced with XINT.
734 (ccl_driver):
735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
736 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
737 (ccl_driver, Fregister_code_conversion_map):
738 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
739 (resolve_symbol_ccl_program): Check that vector header is in range.
740 Always copy the vector, so that we can check its contents reliably
741 now rather than having to recheck each instruction as it's being
742 executed. Check that vector words fit in 'int'.
743 (ccl_get_compiled_code, Fregister_ccl_program)
744 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
745 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
746 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
747 contents are in range.
748 (Fccl_execute_on_string): Check that status is in range.
749 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
750 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
751 Accept and return EMACS_INT, not int, because callers can pass values
752 out of 'int' range.
753 (c_string_width, strwidth, lisp_string_width, chars_in_text)
754 (multibyte_chars_in_text, parse_str_as_multibyte)
755 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
756 (str_as_unibyte, str_to_unibyte, string_count_byte8)
757 (string_escape_byte8, Fget_byte):
758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 759 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
760 avoid mishandling large integers.
761 * character.h: Adjust decls to match defn changes elsewhere.
762 * charset.c (load_charset_map_from_file, find_charsets_in_text)
763 (Ffind_charset_region):
764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
765 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
766 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 767 Don't assume fixnum fits in int.
d311d28c
PE
768 (load_charset_map_from_vector, Fmap_charset_chars):
769 Remove now-unnecessary CHECK_NATNUMs.
770 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
771 Don't rely on undefined behavior with signed left shift overflow.
772 Don't assume unsigned int fits into fixnum, or that fixnum fits
773 into unsigned int. Don't require max_code to be a valid fixnum;
774 that's not true for gb10830 4-byte on a 32-bit host. Allow
775 invalid_code to be a cons, for the same reason. Require code_offset
776 to be a character. Avoid int overflow if max_char is close
777 to INT_MAX.
778 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
779 this is intended anyway and avoids some undefined behavior.
780 (load_charset_map): Pass unsigned, not int, as 2nd arg of
781 INDEX_TO_CODE_POINT, as that's what it expects.
782 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
783 * charset.h (DECODE_CHAR): Return int, not unsigned;
784 this is what was intended anyway, and it avoids undefined behavior.
785 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
786 integer-overflow issues.
787 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
788 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
789 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
790 * chartab.c (Fmake_char_table, Fset_char_table_range)
791 (uniprop_get_decoder, uniprop_get_encoder):
792 Don't assume fixnum fits in int.
793 * cmds.c (move_point): New function, that does the gist of
794 Fforward_char and Fbackward_char, but does so while checking
795 for integer overflow more accurately.
c96e5d6a 796 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
797 (Fforward_line, Fend_of_line, internal_self_insert)
798 (internal_self_insert):
799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
800 Fix a FIXME, by checking for integer overflow when calculating
801 target_clm and actual_clm.
802 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 803 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
804 (ASSURE_DESTINATION, coding_alloc_by_realloc)
805 (coding_alloc_by_making_gap, alloc_destination)
806 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
807 (encode_coding_utf_16, detect_coding_emacs_mule)
808 (decode_coding_emacs_mule, encode_coding_emacs_mule)
809 (detect_coding_iso_2022, decode_coding_iso_2022)
810 (encode_invocation_designation, encode_designation_at_bol)
811 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
812 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
813 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
814 (encode_coding_ccl, encode_coding_raw_text)
815 (detect_coding_charset, decode_coding_charset)
816 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
817 (produce_composition, produce_charset, produce_annotation)
818 (decode_coding, handle_composition_annotation)
819 (handle_charset_annotation, consume_chars, decode_coding_gap)
820 (decode_coding_object, encode_coding_object, detect_coding_system)
821 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
822 (code_convert_region, code_convert_string)
8f50130c
PE
823 (Fdefine_coding_system_internal)
824 (coding_set_source, coding_set_destination):
d311d28c
PE
825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
826 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
827 (Fdefine_coding_system_internal):
828 Don't assume fixnums fit in int.
829 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 830 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
831 (Funencodable_char_position, Fcheck_coding_systems_region)
832 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 834 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 835 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 836 Don't access memory outside of the args array.
d311d28c 837 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
838 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
839 result of ENCODE_CHAR.
d311d28c
PE
840 * coding.h: Adjust decls to match defn changes elsewhere.
841 (struct coding_system):
842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
843 * composite.c (get_composition_id, find_composition)
844 (run_composition_function, update_compositions)
845 (compose_text, composition_gstring_put_cache)
846 (composition_gstring_p, composition_gstring_width)
847 (fill_gstring_header, fill_gstring_body, autocmp_chars)
848 (composition_compute_stop_pos, composition_reseat_it)
849 (composition_update_it, struct position_record)
850 (find_automatic_composition, composition_adjust_point)
851 (Fcomposition_get_gstring, Ffind_composition_internal):
852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
853 (update_compositions):
854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
855 * composite.h: Adjust decls to match defn changes elsewhere.
856 (struct composition):
857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
858 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
859 Do not attempt to compute the address of the object just before a
860 buffer; this is not portable.
861 (Faref, Faset):
862 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
863 (Faset): Use int, not EMACS_INT, where int is wide enough.
864 (Fstring_to_number): Don't assume fixnums fit in int.
865 (Frem): Don't assume arg is nonnegative.
866 * dbusbind.c (xd_append_arg): Check for integers out of range.
867 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 868 (extract_signed, extract_unsigned): New functions.
243e0530
PE
869 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
870 (xd_get_connection_references): Return ptrdiff_t, not int.
871 All uses changed.
872 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
873 (xd_read_message_1):
874 Use int, not unsigned, where the dbus API uses int.
875 (Fdbus_message_internal): Don't overflow mtype.
876 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
877 * dired.c (directory_files_internal, file_name_completion, scmp)
878 (file_name_completion_stat):
879 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
880 (file_name_completion): Don't overflow matchcount.
881 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
882 * dispextern.h: Adjust decls to match defn changes elsewhere.
883 (struct text_pos, struct glyph, struct bidi_saved_info)
884 (struct bidi_string_data, struct bidi_it, struct composition_it)
885 (struct it):
886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
887 (struct display_pos, struct composition_it, struct it):
888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
889 * dispnew.c (increment_matrix_positions)
890 (increment_row_positions, mode_line_string)
891 (marginal_area_string):
892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 893 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
895 (duration_to_sec_usec): New function, to check for overflow better.
896 (Fsleep_for, sit_for): Use it.
897 * doc.c (get_doc_string, store_function_docstring):
898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
899 (get_doc_string, Fsnarf_documentation):
900 Use int, not EMACS_INT, where int is wide enough.
901 (get_doc_string):
902 Use SAFE_ALLOCA, not alloca.
903 Check for overflow when converting EMACS_INT to off_t.
904 * doprnt.c (doprnt):
905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
906 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
907 Don't assume uid_t fits into fixnum.
908 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
909 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
910 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
911 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
912 (general_insert_function)
913 (Finsert_char, make_buffer_string, make_buffer_string_both)
914 (update_buffer_properties, Fbuffer_substring)
915 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
916 (Fsubst_char_in_region, check_translation)
917 (Ftranslate_region_internal, save_restriction_restore, Fformat)
918 (transpose_markers, Ftranspose_regions):
919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
920 (clip_to_bounds): Move to lisp.h as an inline function).
921 (Fconstrain_to_field): Don't assume integers are nonnegative.
922 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
923 (Fsubst_char_in_region, Fsave_restriction):
924 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
925 (Femacs_pid): Don't assume pid_t fits into fixnum.
926 (lo_time): Use int, not EMACS_INT, when int suffices.
927 (lisp_time_argument): Check for usec out of range.
928 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
929 (Fuser_login_name, Fuser_full_name): Signal an error
930 if a uid argument is out of range, rather than relying on
931 undefined behavior.
c8d5c857
PE
932 (Fformat_time_string): Remove now-unnecessary check.
933 lisp_time_argument checks for out-of-range usec now.
243e0530 934 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
935 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
936 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
937 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
938 (init_cmdargs, Fdump_emacs):
939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
940 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
941 the bottom (typically) 32 bits of the fixnum.
942 * eval.c (specpdl_size, call_debugger):
943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
944 (when_entered_debugger, Fbacktrace_debug):
945 Don't assume fixnum can fit in int.
946 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
947 the object just before a buffer; this is not portable.
948 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
949 (grow_specpdl, unbind_to):
950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
951 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
952 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 953 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
954 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
955 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
957 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
958 (a_write, e_write):
959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
960 (Fcopy_file, non_regular_nbytes, read_non_regular)
961 (Finsert_file_contents):
962 Use int, not EMACS_INT, where int is wide enough.
963 (READ_BUF_SIZE): Verify that it fits in int.
964 (Finsert_file_contents): Check that counts are in proper range,
965 rather than assuming fixnums fit into ptrdiff_t etc.
966 Don't assume fixnums fit into int.
125b3835 967 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
968 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
969 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
970 (string_char_to_byte, string_byte_to_char)
971 (string_make_multibyte, string_to_multibyte)
972 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
973 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
974 (substring_both, Fdelete, internal_equal, Ffillarray)
975 (Fclear_string, mapcar1)
976 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
977 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
978 (larger_vector, make_hash_table, maybe_resize_hash_table)
979 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
980 (Fmaphash, secure_hash):
981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
982 (concat): Check for string index and length overflow.
983 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
984 (Frequire):
985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
986 (larger_vector): New API (vec, incr_min, size_max) replaces old
987 one (vec, new_size, init). This catches size overflow.
988 INIT was removed because it was always Qnil.
989 All callers changed.
990 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
991 the upper bound on a hash table index size.
992 (make_hash_table, maybe_resize_hash_table): Use it.
993 (secure_hash): Computer start_byte and end_byte only after
994 they're known to be in ptrdiff_t range.
995 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
996 (Ffont_get_glyphs, Ffont_at):
997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
998 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
999 (Flist_fonts, Fopen_font):
1000 Don't assume fixnum can fit in int.
1001 (check_gstring): Don't assume index can fit in int.
1002 (font_match_p): Check that fixnum is a character, not a nonnegative
1003 fixnum, since the later code needs to stuff it into an int.
1004 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1005 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1006 conversion overflow issues.
1007 (Fopen_font): Check for integer out of range.
1008 (Ffont_get_glyphs): Don't assume index can fit in int.
1009 * font.h: Adjust decls to match defn changes elsewhere.
1010 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1011 integer overflow.
1012 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1013 printmax_t, where ptrdiff_t is wide enough.
1014 (Finternal_char_font):
1015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1016 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1017 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1018 (Fset_frame_position, x_set_frame_parameters)
1019 (x_set_line_spacing, x_set_border_width)
1020 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1021 Check that fixnums are in proper range for system types.
1022 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1024 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1025 Use SAFE_ALLOCA_LISP, not alloca.
1026 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1027 intptr_t is wide enough.
1028 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1029 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1030 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1031 Check for fixnum out of range.
1032 * ftfont.c (ftfont_list): Don't assume index fits in int.
1033 Check that fixnums are in proper range for system types.
1034 (ftfont_shape_by_flt):
1035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1036 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1038 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1039 Check that fixnums are in proper range for system types.
1040 * gnutls.h: Adjust decls to match defn changes elsewhere.
1041 * gtkutil.c (xg_dialog_run):
1042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1043 (update_frame_tool_bar):
1044 Check that fixnums are in proper range for system types.
1045 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1046 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1047 * indent.c (last_known_column, last_known_column_point):
1048 (current_column_bol_cache):
1049 (skip_invisible, current_column, check_display_width):
1050 (check_display_width, scan_for_column, current_column_1)
1051 (Findent_to, Fcurrent_indentation, position_indentation)
1052 (indented_beyond_p, Fmove_to_column, compute_motion):
1053 (Fcompute_motion, Fvertical_motion):
1054 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1055 (last_known_column_modified): Use EMACS_INT, not int.
1056 (check_display_width):
1057 (Fcompute_motion):
1058 Check that fixnums and floats are in proper range for system types.
1059 (compute_motion): Don't assume index or fixnum fits in int.
1060 (compute_motion, Fcompute_motion):
1061 Use int, not EMACS_INT, when it is wide enough.
1062 (vmotion): Omit local var start_hpos that is always 0; that way
1063 we don't need to worry about overflow in expressions involving it.
1064 * indent.h: Adjust decls to match defn changes elsewhere.
1065 (struct position):
1066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1067 Use int, not EMACS_INT, where int is wide enough.
1068 Remove unused members ovstring_chars_done and tab_offset;
1069 all uses removed.
1070 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1071 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1072 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1073 (make_gap, copy_text, insert, insert_and_inherit)
1074 (insert_before_markers, insert_before_markers_and_inherit)
1075 (insert_1, count_combining_before, count_combining_after)
1076 (insert_1_both, insert_from_string)
1077 (insert_from_string_before_markers, insert_from_string_1)
1078 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1079 (adjust_after_replace, adjust_after_insert, replace_range)
1080 (replace_range_2, del_range, del_range_1, del_range_byte)
1081 (del_range_both, del_range_2, modify_region)
1082 (prepare_to_modify_buffer, signal_before_change)
1083 (signal_after_change, Fcombine_after_change_execute):
1084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1085 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1086 (balance_an_interval, split_interval_right, split_interval_left)
1087 (find_interval, next_interval, update_interval)
1088 (adjust_intervals_for_insertion, delete_node, delete_interval)
1089 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1090 (static_offset_intervals, offset_intervals)
1091 (merge_interval_right, merge_interval_left, make_new_interval)
1092 (graft_intervals_into_buffer, temp_set_point_both)
1093 (temp_set_point, set_point, adjust_for_invis_intang)
1094 (set_point_both, move_if_not_intangible, get_property_and_range)
1095 (get_local_map, copy_intervals, copy_intervals_to_string)
1096 (compare_string_intervals, set_intervals_multibyte_1):
1097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1098 * intervals.h: Adjust decls to match defn changes elsewhere.
1099 (struct interval):
1100 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1101 * keyboard.c (this_command_key_count, this_single_command_key_start)
1102 (before_command_key_count, before_command_echo_length, echo_now)
1103 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1104 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1105 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1106 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1108 (last_non_minibuf_size, last_point_position, echo_truncate)
1109 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1110 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1111 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1112 (stuff_buffered_input):
1113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1114 (last_auto_save, command_loop_1, read_char):
1115 Use EMACS_INT, not int, to avoid integer overflow.
1116 (record_char): Avoid overflow in total_keys computation.
1117 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1118 * keyboard.h: Adjust decls to match defn changes elsewhere.
1119 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1120 (Fkey_description, Fdescribe_vector, Flookup_key):
1121 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1122 (click_position): New function, to check that positions are in range.
1123 (Fcurrent_active_maps):
1124 (describe_command):
1125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1126 (Faccessible_keymaps, Fkey_description):
1127 (preferred_sequence_p):
1128 Don't assume fixnum can fit into int.
1129 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1130 Check for integer overflow in size calculations.
1131 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1132 avoid mishandling large integers.
1133 * lisp.h: Adjust decls to match defn changes elsewhere.
1134 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1135 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1136 (struct Lisp_Marker):
1137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1138 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1139 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1140 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1141 All callers changed.
1142 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1143 Assume the arg has valid form, since it always does.
1144 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1145 unsigned integer system type.
1146 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1147 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1148 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1149 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1150 (duration_to_sec_usec): New decl.
1151 * lread.c (read_from_string_index, read_from_string_index_byte)
1152 (read_from_string_limit, readchar, unreadchar, openp)
1153 (read_internal_start, read1, oblookup):
1154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1155 (Fload, readevalloop, Feval_buffer, Feval_region):
1156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1157 (openp): Check for out-of-range argument to 'access'.
1158 (read1): Use int, not EMACS_INT, where int is wide enough.
1159 Don't assume fixnum fits into int.
6efdadfd 1160 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1161 (read_filtered_event): Use duration_to_sec_usec
1162 to do proper overflow checking on durations.
d311d28c
PE
1163 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1164 in size calculation.
1165 (Fexecute_kbd_macro):
1166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1167 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1168 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1169 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1170 (set_marker_both, set_marker_restricted_both, marker_position)
1171 (marker_byte_position, Fbuffer_has_markers_at):
1172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1173 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1174 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1175 It now merely ensures that the menu is large enough, without
1176 necessarily growing it, as this avoids some integer overflow issues.
1177 All callers changed.
1178 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1180 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1181 Use SAFE_ALLOCA_LISP, not alloca.
1182 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1183 to EMACS_INT. Check that fixnums are in proper range for system types.
1184 * minibuf.c (minibuf_prompt_width, string_to_object)
1185 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1186 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1187 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1188 (get_minibuffer, read_minibuf_unwind):
1189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1190 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1191 this simplifies overflow checking. All callers changed.
1192 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1193 (Ftest_completion):
1194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1195 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1196 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1197 Check that fixnums are in proper range for system types.
1198 (Fx_create_frame, Fx_show_tip):
1199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1200 * nsfont.m (ns_findfonts, nsfont_list_family):
1201 Don't assume fixnum fits in long.
1202 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1203 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1204 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1205 wide enough.
17fdb222 1206 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1208 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1209 (PRINTDECLARE, PRINTPREPARE):
1210 (strout, print_string):
1211 (print, print_preprocess, print_check_string_charset_prop)
1212 (print_object):
1213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1214 (PRINTDECLARE):
1215 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1217 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1218 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1219 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1220 (print_error_message): Use SAFE_ALLOCA, not alloca.
1221 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1222 (print_depth, new_backquote_output, print_number_index):
1223 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1224 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1225 (Fset_process_window_size, Fformat_network_address)
1226 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1227 (sigchld_handler):
d311d28c 1228 Check that fixnums are in proper range for system types.
d44287d4 1229 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1230 Check for process-ids out of pid_t range rather than relying on
1231 undefined behavior.
e4d81efc 1232 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1233 (Fformat_network_address, read_process_output, send_process)
1234 (Fprocess_send_region, status_notify):
1235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1236 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1237 (wait_reading_process_output, read_process_output, exec_sentinel):
1238 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1239 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1240 (Faccept_process_output): Use duration_to_sec_usec to do proper
1241 overflow checking on durations.
dde14581
PE
1242 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1243 Don't assume pid_t fits in int.
02481186
PE
1244 * process.h (struct Lisp_Process): Members tick and update_tick
1245 are now of type EMACS_INT, not int.
b62b53e8
PE
1246 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1247 configured --with-wide-int.
d311d28c
PE
1248 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1249 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1250 * search.c (looking_at_1, string_match_1):
1251 (fast_string_match, fast_c_string_match_ignore_case)
1252 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1253 (scan_newline, find_before_next_newline, search_command)
1254 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1255 (set_search_regs, wordify):
1256 (Freplace_match):
1257 (Fmatch_data):
1258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1259 (string_match_1, search_buffer, set_search_regs):
1260 (Fmatch_data):
1261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1262 (wordify): Check for overflow in size calculation.
1263 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1264 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1265 Check that fixnums are in proper range for system types.
1266 * sound.c (struct sound_device)
1267 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1268 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1269 (Fplay_sound_internal):
1270 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1271 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1272 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1273 (Fparse_partial_sexp):
1274 Don't assume fixnums can fit in int.
1275 (struct lisp_parse_state, find_start_pos, find_start_value)
1276 (find_start_value_byte, find_start_begv)
1277 (update_syntax_table, char_quoted, dec_bytepos)
1278 (find_defun_start, prev_char_comend_first, back_comment):
1279 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1280 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1282 (Finternal_describe_syntax_value): Check that match_lisp is a
1283 character, not an integer, since the code stuffs it into int.
1284 (scan_words, scan_sexps_forward):
1285 Check that fixnums are in proper range for system types.
1286 (Fforward_word):
1287 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1288 (scan_sexps_forward):
1289 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1290 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1291 * syntax.h: Adjust decls to match defn changes elsewhere.
1292 (struct gl_state_s):
1293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1294 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1295 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1296 * sysdep.c (wait_for_termination_1, wait_for_termination)
1297 (interruptible_wait_for_termination, mkdir):
1298 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1299 (emacs_read, emacs_write):
1300 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1301 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1302 and double all fit in int.
d311d28c
PE
1303 * term.c (set_tty_color_mode):
1304 Check that fixnums are in proper range for system types.
1305 * termhooks.h (struct input_event):
1306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1307 * textprop.c (validate_interval_range, interval_of)
1308 (Fadd_text_properties, set_text_properties_1)
1309 (Fremove_text_properties, Fremove_list_of_text_properties)
1310 (Ftext_property_any, Ftext_property_not_all)
1311 (copy_text_properties, text_property_list, extend_property_ranges)
1312 (verify_interval_modification):
1313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1314 (Fnext_single_char_property_change)
1315 (Fprevious_single_char_property_change):
1316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1317 (copy_text_properties):
1318 Check for integer overflow in index calculation.
d311d28c
PE
1319 * undo.c (last_boundary_position, record_point, record_insert)
1320 (record_delete, record_marker_adjustment, record_change)
1321 (record_property_change):
1322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1323 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1325 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1326 (Fx_hide_tip, Fx_file_dialog):
1327 * w32menu.c (set_frame_menubar):
1328 Use ptrdiff_t, not int, for consistency with rest of code.
1329 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1330 (select_window, Fdelete_other_windows_internal)
1331 (window_scroll_pixel_based, window_scroll_line_based)
1332 (Frecenter, Fset_window_configuration):
1333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1334 (Fset_window_hscroll, run_window_configuration_change_hook)
1335 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1336 (Fscroll_other_window, Frecenter):
d311d28c
PE
1337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1338 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1339 Don't assume fixnum fits in int.
1340 (Fset_window_scroll_bars):
1341 Check that fixnums are in proper range for system types.
1342 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1343 (string_pos, c_string_pos, number_of_chars, init_iterator)
1344 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1345 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1346 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1347 (face_before_or_after_it_pos, handle_invisible_prop)
1348 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1349 (display_prop_intangible_p, string_buffer_position_lim)
1350 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1351 (get_overlay_strings_1, get_overlay_strings)
1352 (iterate_out_of_display_property, forward_to_next_line_start)
1353 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1354 (get_next_display_element, set_iterator_to_next)
1355 (get_visually_first_element, compute_stop_pos_backwards)
1356 (handle_stop_backwards, next_element_from_buffer)
1357 (move_it_in_display_line_to, move_it_in_display_line)
1358 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1359 (add_to_log, message_dolog, message_log_check_duplicate)
1360 (message2, message2_nolog, message3, message3_nolog
1361 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1362 (current_message_1, truncate_echo_area, truncate_message_1)
1363 (set_message, set_message_1, store_mode_line_noprop)
1364 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1365 (text_outside_line_unchanged_p, check_point_in_composition)
1366 (reconsider_clip_changes)
1367 (redisplay_internal, set_cursor_from_row, try_scrolling)
1368 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1369 (redisplay_window, find_last_unchanged_at_beg_row)
1370 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1371 (trailing_whitespace_p, find_row_edges, display_line)
1372 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1373 (display_mode_element, store_mode_line_string)
1374 (pint2str, pint2hrstr, decode_mode_spec)
1375 (display_count_lines, display_string, draw_glyphs)
1376 (x_produce_glyphs, x_insert_glyphs)
1377 (rows_from_pos_range, mouse_face_from_buffer_pos)
1378 (fast_find_string_pos, mouse_face_from_string_pos)
1379 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1381 (safe_call, init_from_display_pos, handle_fontified_prop)
1382 (handle_single_display_spec, load_overlay_strings)
1383 (with_echo_area_buffer, setup_echo_area_for_printing)
1384 (display_echo_area, echo_area_display)
1385 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1386 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1387 (redisplay_window, dump_glyph_row, display_mode_line)
1388 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1389 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1391 (handle_single_display_spec, build_desired_tool_bar_string)
1392 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1393 (get_specified_cursor_type):
1394 Check that fixnums are in proper range for system types.
1395 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1396 (Flookup_image_map):
1397 Don't assume fixnums fit in int.
1398 (compare_overlay_entries):
1399 Avoid mishandling comparisons due to subtraction overflow.
1400 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1401 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1402 (handle_tool_bar_click):
1403 Use int, not unsigned, since we prefer signed and the signedness
1404 doesn't matter here.
1405 (get_next_display_element, next_element_from_display_vector):
1406 Use int, not EMACS_INT, when int is wide enough.
1407 (start_hourglass): Use duration_to_sec_usec to do proper
1408 overflow checking on durations.
1409 * xfaces.c (Fbitmap_spec_p):
1410 Check that fixnums are in proper range for system types.
1411 (compare_fonts_by_sort_order):
1412 Avoid mishandling comparisons due to subtraction overflow.
1413 (Fx_family_fonts, realize_basic_faces):
1414 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1415 (Fx_family_fonts):
1416 Don't assume fixnum fits in int.
1417 Use SAFE_ALLOCA_LISP, not alloca.
1418 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1419 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1420 (face_at_buffer_position, face_for_overlay_string)
1421 (face_at_string_position):
1422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1423 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1424 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1425 (Fx_show_tip):
1426 Check that fixnums are in proper range for system types.
1427 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1428 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1429 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1430 (Fx_change_window_property): Don't assume fixnums fit in int.
1431 * xfont.c (xfont_chars_supported):
1432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1433 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1434 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1435 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1436 * xml.c (parse_region):
1437 * xrdb.c (magic_file_p):
1438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1439 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1440 (x_get_local_selection, x_reply_selection_request)
1441 (x_handle_selection_request, wait_for_property_change):
1442 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1443 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1444 short is wide enough.
1445 (x_send_client_event): Don't assume fixnum fits in int.
1446 * xterm.c (x_x_to_emacs_modifiers):
1447 Don't assume EMACS_INT overflows nicely into int.
1448 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1449 may come from Lisp.
1450 (handle_one_xevent): NATNUMP can eval its arg twice.
1451 (x_connection_closed):
1452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1453 * xterm.h: Adjust decls to match defn changes elsewhere.
1454 (struct scroll_bar): Use struct vectorlike_header
1455 rather than rolling our own approximation.
1456 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1457
c6574eb5
GM
14582012-05-25 Glenn Morris <rgm@gnu.org>
1459
1460 * lisp.mk (lisp): Update for more files being compiled now.
1461
e8d32c7e
SM
14622012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1463
48def666
SM
1464 * lread.c: Remove `read_pure' which makes no difference.
1465 (read_pure): Remove var.
1466 (unreadpure): Remove function.
1467 (readevalloop): Don't call read_list with -1 flag.
1468 (read1, read_vector): Don't test read_pure any more.
1469 (read_list): Simplify.
1470
e8d32c7e
SM
1471 * fileio.c, character.h: Minor style tweaks.
1472
4b2addb7
DA
14732012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1474
1475 * window.h (clip_changed): Remove useless declaration.
1476
584461b2
JB
14772012-05-22 Juanma Barranquero <lekktu@gmail.com>
1478
1479 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1480 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1481
34374650
PE
14822012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1483
1484 Remove src/m/*.
1485 This directory predates autoconf and is no longer needed nowadays.
1486 Move its few remaining bits of functionality to where they're needed.
1487 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1488 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1489 * m/template.h: Remove.
1490 * Makefile.in (M_FILE): Remove. All uses removed.
1491 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1492 * lisp.h (USE_LSB_TAG):
1493 * mem-limits.h (EXCEEDS_LISP_PTR):
1494 Use VAL_MAX, not VALBITS, in #if.
1495 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1496 (EMACS_UINT): Define unconditionally now.
1497 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1498 (BITS_PER_EMACS_INT): New constants, replacing
1499 what used to be in config.h, but not useful in #if.
1500 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1501 define them any more.
1502 (VAL_MAX): New macro.
1503 (VALMASK): Use it.
1504 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1505 BITS_PER_EMACS_INT, in #if.
1506 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1507 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1508 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1509 * s/ms-w32.h (DATA_START):
1510 Move here from removed file m/intel386.h.
1511 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1512 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1513
261cb4bb
PE
15142012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 Assume C89 or later.
1517 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1518 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1519 (xrealloc):
1520 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1521 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1522 * textprop.c, tparam.c (NULL): Remove.
1523 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1524 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1525 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1526 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1527 * xterm.c (input_signal_count): Assume volatile works.
1528
ff23cd9f
KB
15292012-05-21 Ken Brown <kbrown@cornell.edu>
1530
1531 * xgselect.c (xg_select): Fix first argument in call to 'select'
1532 (bug#11508).
1533
1b170bc6
KB
15342012-05-20 Ken Brown <kbrown@cornell.edu>
1535
1536 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1537 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1538
b2f4d39f
KB
15392012-05-19 Ken Brown <kbrown@cornell.edu>
1540
1541 * xfns.c (x_in_use): Remove `static' qualifier.
1542 * xterm.h (x_in_use): Declare.
1543 * xgselect.c: Include xterm.h.
1544 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1545 and `display_arg' (bug#9754).
1546
003fdae2
PE
15472012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1548
9232a6d9
PE
1549 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1550
003fdae2
PE
1551 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1552 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1553
784b56e2
EZ
15542012-05-18 Eli Zaretskii <eliz@gnu.org>
1555
1556 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1557
1558 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1559 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1560
1561 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1562 reference to image_cache->refcount.
1563 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1564
a0a79cde
JL
15652012-05-17 Juri Linkov <juri@jurta.org>
1566
1567 * search.c (Fword_search_regexp, Fword_search_backward)
1568 (Fword_search_forward, Fword_search_backward_lax)
1569 (Fword_search_forward_lax): Move functions to isearch.el
1570 (bug#10145, bug#11381).
1571
b0572523
PE
15722012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1573
1574 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1575
9660f5fc
SM
15762012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1577
1578 * lread.c (init_obarray): Declare Qt and Qnil as special.
1579
4374de83
GM
15802012-05-14 Glenn Morris <rgm@gnu.org>
1581
1582 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1583 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1584
dc44c39a
PE
15852012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1586
078c97cb
PE
1587 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1588
dc44c39a
PE
1589 * unexaix.c: Port to more-recent AIX compilers.
1590 (report_error, report_error_1, make_hdr, copy_sym)
1591 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1592 Make arguments const char *, not char *, to avoid violations of C
1593 standard and to fix some AIX warnings reported by Gilles Pion.
1594
e18afed7 15952012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1596
1597 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1598 already have overlays loaded.
1599 (handle_single_display_spec): Before returning without displaying
1600 fringe bitmap, synchronize the bidi iterator with the main display
1601 iterator, by calling iterate_out_of_display_property.
1602 (iterate_out_of_display_property): Detect buffer iteration by
1603 testing that it->string is a Lisp string.
1604 (get_next_display_element): When the current object is exhausted,
1605 and there's something on it->stack, call set_iterator_to_next to
1606 proceed with what's on the stack, instead of returning zero.
1607 (set_iterator_to_next): If called at the end of a Lisp string,
1608 proceed to consider_string_end without incrementing string
1609 position. Don't increment display vector index past the end of
1610 the display vector. (Bug#11417)
c8fb9dc6
EZ
1611 (pos_visible_p): Don't report a position visible when move_it_to
1612 stopped at the last line of window, which happens to be scanned
1613 backwards by the bidi iteration. (Bug#11464)
ac268e67 1614
e18afed7 16152012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1616
1617 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1618 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1619 are on a TTY, and thus unable to display on the fringes.
1620 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1621 so we need to signal to the caller that this is a "replacing"
1622 display spec. This fixes display when the spec is invalid or we
1623 are on a TTY.
1624
e18afed7 16252012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1626
1627 * unexaix.c (make_hdr): Fix typo in prototype.
1628 This bug broke the build on AIX. Problem reported by Gilles Pion.
1629
9d0a235a
MA
16302012-05-14 Michael Albinus <michael.albinus@gmx.de>
1631
1632 * keyboard.c (kbd_buffer_get_event): Read special events also in
1633 batch mode. (Bug#11415)
1634
9e6b06ed
GM
16352012-05-12 Glenn Morris <rgm@gnu.org>
1636
1637 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1638
c1a1d7a3
EZ
16392012-05-12 Eli Zaretskii <eliz@gnu.org>
1640
1641 * lisp.mk (lisp): Add newcomment.elc.
1642
3fe7cdc8
GM
16432012-05-12 Glenn Morris <rgm@gnu.org>
1644
1645 * Makefile.in (MKDIR_P): New, set by configure.
1646 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1647
53f7d2c0
PE
16482012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1649
1650 Remove unused function hourglass_started.
1651 * dispextern.h (hourglass_started):
1652 * w32fns.c (hourglass_started):
1653 * xdisp.c (hourglass_started): Remove.
1654
75aafb17
JB
16552012-05-10 Juanma Barranquero <lekktu@gmail.com>
1656
1657 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1658 Update dependencies.
1659
12959e8e
PE
16602012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1661
97107e2e
PE
1662 * xgselect.c (xg_select): Put maxfds+1 into a var.
1663 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1664
12959e8e
PE
1665 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1666
836d29b3
DA
16672012-05-10 Dave Abrahams <dave@boostpro.com>
1668
1669 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1670 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1671
5cb67954
MA
16722012-05-09 Michael Albinus <michael.albinus@gmx.de>
1673
1674 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1675 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1676 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1677 Initialize xd_registered_buses.
1678
3478ec45
PE
16792012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1680
b263a6b0
PE
1681 Untag more efficiently if USE_LSB_TAG.
1682 This is based on a proposal by YAMAMOTO Mitsuharu in
1683 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1684 For an admittedly artificial (nth 8000 longlist) benchmark on
1685 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1686 Emacs's overall text size by 1%.
1687 * lisp.h (XUNTAG): New macro.
1688 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1689 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1690 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1691 * eval.c (Fautoload):
1692 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1693 * frame.h (XFRAME): Use XUNTAG.
1694
3478ec45
PE
1695 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1696 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1697 Remove unportable assumptions about print widths of types like
1698 dbus_uint32_t.
1699 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1700 intptr_t when converting between pointer and integer, to avoid GCC
1701 warnings about wrong width.
1702
666b903b 17032012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1704
1705 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1706 stack for each reader_thread, instead of defaulting to 8MB
1707 determined by the linker. This avoids failures in creating
1708 subprocesses on Windows 7, see the discussion in this thread:
1709 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1710
b120cc17
JC
17112012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1712
1713 Fix up display of the *Minibuf-0* buffer in the mini window.
1714 * keyboard.c (read_char): Don't clear the echo area if there's no
1715 message to clear.
1716 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1717 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1718
9a4b36f8
MA
17192012-05-07 Michael Albinus <michael.albinus@gmx.de>
1720
1721 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1722 batch mode.
1723
e5f9458f
CY
17242012-05-06 Chong Yidong <cyd@gnu.org>
1725
1726 * lisp.mk (lisp): Update.
1727
eceeb5fc 17282012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1729
1730 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1731
71873e2b
SM
17322012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1733
1734 * data.c (PUT_ERROR): New macro.
1735 (syms_of_data): Use it. Add new error type `user-error'.
1736 * undo.c (user_error): New function.
1737 (Fprimitive_undo): Use it.
1738 * print.c (print_error_message): Adjust print style for `user-error'.
1739 * keyboard.c (user_error): New function.
1740 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1741
ab0fa4e4
PE
17422012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1743
1744 Do not limit current-time-string to years 1000..9999.
1745 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1746 (Fcurrent_time_string): Support any year that is supported by the
1747 underlying localtime representation. Don't use asctime, as it
1748 has undefined behavior for years outside the range -999..9999.
1749
7ed806a7
PE
17502012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1751
1752 Fix race conditions involving setenv, gmtime, localtime, asctime.
1753 Without this fix, interrupts could mess up code that uses these
1754 nonreentrant functions, since setting TZ invalidates existing
1755 tm_zone or tzname values, and since most of these functions return
1756 pointers to static storage.
1757 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1758 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1759 Grow the critical sections to include not just invoking
1760 localtime/gmtime, but also accessing these functions' results
1761 including their tm_zone values if any, and any related TZ setting.
1762 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1763 so that the struct tm is saved in the critical section.
1764 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1765 motivated by the fact that memory allocation needs to be outside
1766 the critical section.
1767
0c16dfed
DA
17682012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1769
1770 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1771 with RESET_INTERVAL.
1772
1773 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1774 Remove duplicated buffer name initialization.
1775
3f83ace8
JM
17762012-05-02 Jim Meyering <jim@meyering.net>
1777
1778 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1779
c7b8541e
JM
1780 * xfns.c (x_window): Use xstrdup (Bug#11375).
1781
90207a15 17822012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1783
1784 * xdisp.c (pos_visible_p): If already at a newline from the
1785 display string before the 'while' loop, don't walk back the glyphs
1786 from it3.glyph_row. Solves assertion violation when the display
1787 string begins with a newline (egg.el). (Bug#11367)
1788
b593d6a9
AH
17892012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1790
1791 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1792 Move to simple.el.
1793
4737362e
GM
17942012-05-01 Glenn Morris <rgm@gnu.org>
1795
99cf43f9
GM
1796 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1797 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1798 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1799 All were removed before 23.1.
1800
9311dcff
GM
1801 * dispnew.c: Remove HAVE_LIBNCURSES test;
1802 it is always true on relevant platforms.
1803
4d5c6349
GM
1804 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1805 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1806
4737362e
GM
1807 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1808
74dd3a6b
AS
18092012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1810
1811 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1812 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1813 Remove.
1814
13c379ee
PE
18152012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 Do not avoid creating empty evaporating overlays (Bug#9642).
1818 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1819 That is, do not delete an evaporating overlay if it becomes
1820 empty after its bounds are adjusted to fit within its buffer.
1821 This fix caused other problems, and I'm reverting it until we get
1822 to the bottom of them.
1823
a8e7d6d7 18242012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1825
1826 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1827
a8e7d6d7 18282012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1829
1830 * xdisp.c (pos_visible_p): If the window start position is beyond
1831 ZV, start the display from buffer beginning. Prevents assertion
1832 violation in init_iterator when the minibuffer window is scrolled
1833 via the scroll bar.
1834
1835 * window.c (window_scroll_pixel_based): Likewise.
1836
a8e7d6d7 18372012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1838
1839 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1840
a8e7d6d7 18412012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1842
1843 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1844 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1845
a8e7d6d7 18462012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1847
b593d6a9
AH
1848 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1849 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1850
1c6900d9
EZ
18512012-04-26 Eli Zaretskii <eliz@gnu.org>
1852
4c3fa1d9
EZ
1853 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1854 display element, check also the underlying string or buffer
1855 character. (Bug#11341)
1856
1c6900d9
EZ
1857 * w32menu.c: Include w32heap.h.
1858 (add_menu_item): If the call to AppendMenuW (via
1859 unicode_append_menu) fails, disable Unicode menus only if we are
1860 running on Windows 9X/Me.
1861
42bf8205
AS
18622012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1863
1864 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1865 (xgetint): Add missing shift for LSB tags.
1866
b1bac16e
MR
18672012-04-24 Martin Rudalics <rudalics@gmx.at>
1868
1869 * keyboard.c (read_char): Don't wipe echo area for select window
1870 events: These might get delayed via `mouse-autoselect-window'
1871 (Bug#11304).
1872
d69621cc
JB
18732012-04-24 Juanma Barranquero <lekktu@gmail.com>
1874
1875 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1876 manipulation of :loaded-from data.
1877
02fd101b
JB
18782012-04-23 Juanma Barranquero <lekktu@gmail.com>
1879
1880 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1881 now a cons (bug#11311).
1882
888bec30
PE
18832012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1884
89a438bd
PE
1885 Do not create empty overlays with the evaporate property (Bug#9642).
1886 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1887 if it becomes empty after its bounds are adjusted to fit within
1888 its buffer. Without this fix, in a nonempty buffer (let ((o
1889 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1890 yields an empty overlay that has the evaporate property, which is
1891 not supposed to happen.
1892
1068fe4d
PE
1893 Fix minor GTK3 problems found by static checking.
1894 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1895 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1896 (struct _EmacsFixedClass, emacs_fixed_get_type):
1897 Move decls here from emacsgtkfixed.h, since they needn't be public.
1898 (emacs_fixed_get_type): Now static.
1899 (emacs_fixed_class_init): Omit unused local.
1900 (emacs_fixed_child_type): Remove; unused.
1901 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1902 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1903 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1904 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1905 (EMACS_FIXED_GET_CLASS): Remove; unused.
1906 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1907
888bec30
PE
1908 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1909 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1910
de85e130
PE
19112012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1912
d0baac98 1913 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1914 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1915 (__malloc_size_t, __malloc_ptrdiff_t):
1916 Remove. All uses removed, replaced by the definiens if needed,
1917 since we can assume C89 or better now.
1918 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1919 (protect_malloc_state, align, get_contiguous_space)
1920 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1921 (malloc_atfork_handler_child, malloc_enable_thread)
1922 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1923 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1924 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1925 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1926 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1927 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1928 Define using prototypes, not old style.
1929 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1930 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1931 (align): Don't assume that signed integer overflow wraps around.
1932 Omit unused local var.
1933 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1934 (_free_internal_nolock, memalign, mallochook, reallochook):
1935 Omit no-longer-needed casts.
1936 (valloc): Use getpagesize, not __getpagesize.
1937 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1938 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1939
de85e130
PE
1940 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1941
dcbf5805
MA
19422012-04-22 Michael Albinus <michael.albinus@gmx.de>
1943
1944 Move functions from C to Lisp. Make non-blocking method calls
1945 the default. Implement further D-Bus standard interfaces.
1946
1947 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1948 (QCdbus_request_name_allow_replacement)
1949 (QCdbus_request_name_replace_existing)
1950 (QCdbus_request_name_do_not_queue)
1951 (QCdbus_request_name_reply_primary_owner)
1952 (QCdbus_request_name_reply_in_queue)
1953 (QCdbus_request_name_reply_exists)
1954 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1955 (QCdbus_registered_serial, QCdbus_registered_method)
1956 (QCdbus_registered_signal): New Lisp objects.
1957 (XD_DEBUG_MESSAGE): Use sizeof.
1958 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1959 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1960 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1961 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1962 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1963 (xd_signature, xd_append_arg): Allow float for integer types.
1964 (xd_get_connection_references): New function.
b593d6a9
AH
1965 (xd_get_connection_address): Rename from xd_initialize.
1966 Return cached address.
dcbf5805
MA
1967 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1968 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1969 level.
1970 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1971 Return number of refcounts.
dcbf5805
MA
1972 (Fdbus_get_unique_name): Make stronger parameter check.
1973 (Fdbus_message_internal): New defun.
1974 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1975 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1976 (Fdbus_send_signal, Fdbus_register_service)
1977 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1978 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1979 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1980 (Vdbus_compiled_version, Vdbus_runtime_version)
1981 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1982 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1983 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1984 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1985 Adapt docstring.
dcbf5805 1986
52828e02
PE
19872012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1988
da05bc4c
PE
1989 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1990 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1991 Do not assume ptrdiff_t is the same width as 'int'.
1992
52828e02
PE
1993 * alloc.c: Handle unusual debugging option combinations.
1994 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1995 since the two debugging options are incompatible.
1996 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1997 is defined.
1998 (mem_init, mem_insert, mem_insert_fixup):
1999 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2000 (NEED_MEM_INSERT): Remove; no longer needed.
2001
f01769f9
LL
20022012-04-22 Leo Liu <sdl.web@gmail.com>
2003
2004 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2005
5790543d
PE
20062012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2007
2008 * sysdep.c [__FreeBSD__]: Minor cleanups.
2009 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2010 Use Emacs indenting style more consistently. Avoid some casts.
2011 Use 'double' consistently rather than mixing 'float' and 'double'.
2012
b91b7e4d
EW
20132012-04-21 Eduard Wiebe <usenet@pusto.de>
2014
b593d6a9
AH
2015 * sysdep.c (list_system_processes, system_process_attributes):
2016 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2017
6114eb15
AS
20182012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2019
2020 * lisp.mk (lisp): Update.
2021
2f38dff7
PE
20222012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2025 It is never used otherwise.
2026
4ae29f89
SM
20272012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2028
2029 * print.c (print_preprocess): Only check print_depth if print-circle
2030 is nil.
2031 (print_object): Check for cycles even when print-circle is nil and
2032 print-gensym is t, but only check print_depth if print-circle is nil.
2033
f30d612a
CY
20342012-04-20 Chong Yidong <cyd@gnu.org>
2035
2036 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2037 set the status to "failed" and ensure that sentinel is run.
2038
c07a4c0b 20392012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2040
2041 * process.c (Fset_process_inherit_coding_system_flag)
2042 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2043 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2044
c07a4c0b 20452012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2046
2047 * xdisp.c (string_buffer_position_lim): Limit starting position to
2048 BEGV.
2049 (set_cursor_from_row): If called for a mode-line or header-line
2050 row, return zero immediately.
2051 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2052 farther than the first row after the header line, if any.
2053 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2054 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2055
c07a4c0b 20562012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2057
4ae29f89
SM
2058 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2059 (bug#11238).
ad3a2b41 2060
c07a4c0b 20612012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 20622012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2063
2064 configure: new option --enable-gcc-warnings (Bug#11207)
2065 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2066 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2067 (ALL_CFLAGS): Use new macros rather than old.
2068 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2069 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2070 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2071 -Wunused-result, -Wunused-variable. This should go away once
2072 the Emacs and Gnulib regex code is merged.
2073 (xmalloc, xrealloc): Now static.
2074
aba027e8
PE
20752012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 * dired.c (Fsystem_groups): Remove unused local.
2078
e5a36063
GM
20792012-04-17 Glenn Morris <rgm@gnu.org>
2080
2081 * dired.c (Fsystem_users): Doc fix.
2082
316411f0
DA
20832012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2084
2085 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2086 (syms_of_dired): Add them.
2087
9426aba4
PE
20882012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2089
b62a57be
PE
2090 Fix minor alloc.c problems found by static checking.
2091 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2092 New extern decls, to avoid calling undeclared functions.
2093 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2094 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2095 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2096 (NEED_MEM_INSERT): New macro.
2097 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2098 Remove one incorrect comment and fix another.
b62a57be 2099
3539f31f
PE
2100 Fix minor ralloc.c problems found by static checking.
2101 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2102 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2103 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2104 (r_alloc_sbrk): Now static.
2105
a041960a
PE
2106 Improve ralloc.c interface checking.
2107 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2108 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2109 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2110 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2111 [REL_ALLOC]: ... to here, to check interface.
2112 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2113 Remove decls. This fixes an "It stinks!".
2114
9426aba4
PE
2115 * alloc.c (which_symbols): Fix alignment issue / type clash.
2116
d55c12ed
AS
21172012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2118
2119 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2120 (struct Lisp_Misc_Any): Likewise.
2121 (struct Lisp_Free): Likewise.
2122 * alloc.c (union aligned_Lisp_Symbol): Define.
2123 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2124 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2125 (union aligned_Lisp_Misc): Define.
2126 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2127 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2128 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2129
b948ce8b
PE
21302012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2131
2132 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2133 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2134 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2135 * s/netbsd.h, s/sol2-6.h:
2136 Remove definition of GC_MARK_STACK, since the default now works.
2137 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2138 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2139 no longer the default.
2140 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2141
35dc09a1 21422012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2143
35dc09a1
GM
2144 * lread.c (lisp_file_lexically_bound_p):
2145 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2146
35dc09a1
GM
21472012-04-14 Eli Zaretskii <eliz@gnu.org>
2148
2149 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2150 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2151
21522012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2153
2154 * nsterm.m (constrainFrameRect): Always constrain when there is only
2155 one screen (Bug#10962).
2156
bcd86815
KB
21572012-04-13 Ken Brown <kbrown@cornell.edu>
2158
2159 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2160
c25df26e
RT
21612012-04-13 Reuben Thomas <rrt@sc3d.org>
2162
2163 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2164
0fc59f1e
DC
21652012-04-11 Daniel Colascione <dancol@dancol.org>
2166
2167 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2168 against is gone. It's better to use vfork now so that when Cygwin
2169 gains a new, working vfork, we use it automatically (bug#10398).
2170
de8c03dc
SM
21712012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2172
2173 * window.c (save_window_save): Obey window-point-insertion-type.
2174
2f097256
GM
21752012-04-11 Glenn Morris <rgm@gnu.org>
2176
2177 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2178
453b951e
SM
21792012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2180
2181 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2182
75f1671a 21832012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2184
2185 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2186 (force_quit_count): New var.
2187 (handle_interrupt): Use it.
2188
2a8ce227
JB
21892012-04-10 Juanma Barranquero <lekktu@gmail.com>
2190
2191 * w32.c (w32_delayed_load): Record the full path of the library
2192 being loaded (bug#10424).
2193
935396c0
GM
21942012-04-09 Glenn Morris <rgm@gnu.org>
2195
05920a43
GM
2196 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2197 not just in the obarray, before snarfing them. (Bug#11036)
2198
935396c0
GM
2199 * Makefile.in ($(leimdir)/leim-list.el):
2200 Pass EMACS rather than BUILT_EMACS.
2201
a18ecafa
TZ
22022012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2203
2204 * process.c (make_process):
2205 * process.h: Add integer `gnutls_handshakes_tried' member to
2206 process struct.
2207
6bbef4e5
JC
2208 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2209 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2210
2211 * gnutls.c (gnutls_log_function2i): Convenience log function.
2212 (emacs_gnutls_read): Use new log functions,
2213 `gnutls_handshakes_tried' process member, and
2214 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2215 attempts per process (connection).
2216
b4d3bc10
CY
22172012-04-09 Chong Yidong <cyd@gnu.org>
2218
2219 * eval.c (Fuser_variable_p, user_variable_p_eh)
2220 (lisp_indirect_variable): Functions deleted.
2221 (Fdefvar): Caller changed.
2222
2223 * callint.c (Finteractive, Fcall_interactively):
2224 * minibuf.c (Fread_variable): Callers changed.
2225
70f4d973
EZ
22262012-04-09 Eli Zaretskii <eliz@gnu.org>
2227
2228 * xdisp.c (set_cursor_from_row): If the display string appears in
2229 the buffer at position that is closer to point than the position
2230 after the display string, display the cursor on the first glyph of
2231 the display string. Fixes cursor display when a 'display' text
2232 property immediately follows invisible text. (Bug#11094)
2233
cb3c2e3e
PE
22342012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2235
2236 composite.c: use 'double' consistently
2237 * composite.c (get_composition_id): Use 'double' consistently
2238 instead of converting 'float' to 'double' and vice versa; this is
2239 easier to understand and avoids a GCC warning.
2240
fd06db5d
GM
22412012-04-09 Glenn Morris <rgm@gnu.org>
2242
50fe702a
GM
2243 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2244 preparation for dumping it with emacs. (Bug#4789)
2245 (leimdir): New variable.
2246 ($(leimdir)/leim-list.el): New rule.
2247 (emacs$(EXEEXT)): Depend on leim-list.el.
2248
fd06db5d
GM
2249 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2250 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2251 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2252
55c131ee
AS
22532012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2254
2255 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2256 proper alignment.
2257
9209588f
JB
22582012-04-07 Juanma Barranquero <lekktu@gmail.com>
2259
2260 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2261 Remove unused local variable.
2262
e3fb2efb
PE
22632012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2264
2265 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2266 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2267 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2268 objects, as mark_maybe_pointer will catch them otherwise.
2269 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2270 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2271
b5385551
PE
22722012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2273
2274 Fix typo that broke non-Windows builds.
2275 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2276
9078ead6
EZ
22772012-04-07 Eli Zaretskii <eliz@gnu.org>
2278
2279 Support building on MS-Windows with libxml2.
2280
2281 * makefile.w32-in (OBJ2): Add xml.$(O).
2282 (GLOBAL_SOURCES): Add xml.c.
2283 ($(BLD)/xml.$(O)): New dependency list.
2284
2285 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2286 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2287 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2288 [!WINDOWSNT]: New macros.
2289 (init_libxml2_functions, libxml2_loaded_p): New functions.
2290 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2291 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2292 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2293 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2294 linked in).
6bbef4e5
JC
2295 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2296 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2297 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2298
2299 * emacs.c: Don't include libxml/parser.h.
2300 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2301 xmlCleanupParser directly.
2302
2303 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2304
3811fdf3
EZ
23052012-04-07 Eli Zaretskii <eliz@gnu.org>
2306
2307 * indent.c (Fvertical_motion): If there is a display string at
2308 point, use it.vpos to compute how many lines to backtrack after
2309 move_it_to point. (Bug#11133)
2310
2f8e16b2
EZ
23112012-04-06 Eli Zaretskii <eliz@gnu.org>
2312
2313 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2314 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2315 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2316 macros related to unification of CJK characters. For the details,
2317 see the discussion following the message here:
2318 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2319
3d439cd1
CY
23202012-04-04 Chong Yidong <cyd@gnu.org>
2321
2322 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2323
8bc53d00
EZ
23242012-04-01 Eli Zaretskii <eliz@gnu.org>
2325
2326 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2327 instead of alloca. (Bug#11138)
2328
3b0512a3
AS
23292012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2330
2331 * w32menu.c (is_simple_dialog): Properly check lisp types.
2332 (Bug#11141)
2333
8427ddd2
EZ
23342012-03-31 Eli Zaretskii <eliz@gnu.org>
2335
979022ef
EZ
2336 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2337 position we get to after a call to move_it_to fails the
2338 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2339 only if we wind up in a string from display property. (Bug#11063)
2340
a6b1c7cc
EZ
2341 * window.c (Fdelete_other_windows_internal): Invalidate the row
2342 and column information about mouse highlight, so that redisplay
2343 restores it after reallocating the glyph matrices. (Bug#7464)
2344
8427ddd2
EZ
2345 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2346 string comes from a `display' text property, use the buffer
2347 position of that property as if we actually saw that position in
2348 the row's glyphs.
697ba24b
EZ
2349 (move_it_by_lines): Remove the assertion that
2350 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2351 violated when there's a before-string at the beginning of a line.
2352 (Bug#11063)
8427ddd2 2353
65a0a738
EZ
23542012-03-30 Eli Zaretskii <eliz@gnu.org>
2355
2356 * xdisp.c (append_space_for_newline): If the default face was
2357 remapped, use the remapped face for the appended newline.
2358 (extend_face_to_end_of_line): Use the remapped default face for
2359 extending the face to the end of the line.
2360 (display_line): Call extend_face_to_end_of_line when the default
2361 face was remapped. (Bug#11068)
2362
581355cc
EZ
23632012-03-29 Eli Zaretskii <eliz@gnu.org>
2364
2365 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2366
e8fc049f
SM
23672012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2368
2369 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2370
4fb9a543
GM
23712012-03-27 Glenn Morris <rgm@gnu.org>
2372
2373 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2374 Doc fixes.
2375
679910f1
KH
23762012-03-26 Kenichi Handa <handa@m17n.org>
2377
2378 * dispextern.h (struct glyph): Fix previous change. Change the
2379 bit length of glyphless.ch to 25 (Bug#11082).
2380
90d49b7f
CY
23812012-03-26 Chong Yidong <cyd@gnu.org>
2382
2383 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2384 (command_loop_1): Use it; inhibit selection update for
2385 handle-select-window too (Bug#8996).
2386
f514f6f0
FP
23872012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2388
e8fc049f 2389 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2390
bf43fa51
KH
23912012-03-25 Kenichi Handa <handa@m17n.org>
2392
2393 * dispextern.h (struct glyph): Change the bit length of
2394 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2395
8a0c01dd
EZ
23962012-03-24 Eli Zaretskii <eliz@gnu.org>
2397
2398 * s/ms-w32.h (tzname): Include time.h before redirecting to
2399 _tzname. Fixes the MSVC build. (Bug#9960)
2400
7d1c3a76
AS
24012012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2402
8ed79523
AS
2403 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2404 characters.
2405
7d1c3a76
AS
2406 * xterm.c (XTread_socket): Only modify handling_signal if
2407 !SYNC_INPUT. (Bug#11080)
2408
e99a9b8b
EZ
24092012-03-23 Eli Zaretskii <eliz@gnu.org>
2410
2411 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2412 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2413 when fetching a multibyte character consumes more bytes than
2414 CHAR_BYTES returns, due to unification of CJK characters in
2415 string_char. (Bug#11073)
2416
5063c0e1
TN
24172012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2418
2419 * process.c (wait_reading_process_output): Handle pty disconnect
2420 by refraining from sending oneself a SIGCHLD (bug#10933).
2421
9f851fbd
CY
24222012-03-22 Chong Yidong <cyd@gnu.org>
2423
2424 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2425
5063c0e1 2426 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2427 Mark string as coming from a prefix property.
2428 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2429 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2430
fb5b8aca
CY
24312012-03-21 Chong Yidong <cyd@gnu.org>
2432
2433 * xfaces.c (Vface_remapping_alist): Doc fix.
2434
62356a1b
EZ
24352012-03-20 Eli Zaretskii <eliz@gnu.org>
2436
2437 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2438 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2439 Doc fixes.
62356a1b 2440
025de85b
CY
24412012-03-20 Chong Yidong <cyd@gnu.org>
2442
2443 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2444 to reflect default non-nil value of redisplay-dont-pause.
2445
4827f94e
KH
24462012-03-19 Kenichi Handa <handa@m17n.org>
2447
2448 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2449 it fit in a valid range (Bug#11003).
2450
e50a24a2
EZ
24512012-03-18 Eli Zaretskii <eliz@gnu.org>
2452
2453 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2454 that is not from display property, accept the row as a "cursor
2455 row" if one of the string's character has a non-nil `cursor'
2456 property. Fixes cursor positioning when there are newlines in
2457 overlay strings, e.g. in icomplete.el. (Bug#11035)
2458
9af5ed87
PE
24592012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2460
2461 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2462
d1f55f16
CY
24632012-03-12 Chong Yidong <cyd@gnu.org>
2464
2465 * eval.c (inhibit_lisp_code): Rename from
2466 inhibit_window_configuration_change_hook; move from window.c.
2467
2468 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2469 * window.c (run_window_configuration_change_hook)
2470 (syms_of_window): Callers changed.
2471
66c5eebd
CY
24722012-03-11 Chong Yidong <cyd@gnu.org>
2473
413df973
CY
2474 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2475
66c5eebd
CY
2476 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2477
1de11f56
CY
24782012-03-10 Chong Yidong <cyd@gnu.org>
2479
2480 * frame.c (other_visible_frames): Don't assume the selected frame
2481 is visible (Bug#10955).
2482
cae07000
SM
24832012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2484
2485 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2486
89c94350
JD
24872012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2488
2489 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2490 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2491 zero (Bug#10954).
2492
999dd333
GM
24932012-03-03 Glenn Morris <rgm@gnu.org>
2494
01a6dcc8 2495 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2496
de0100f2
EZ
24972012-03-02 Eli Zaretskii <eliz@gnu.org>
2498
2499 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2500 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2501 (redisplay_window, next_element_from_string): Fix typos in
2502 comments.
3e441275
EZ
2503 (redisplay_window): Pass to move_it_vertically the margin in
2504 pixels, not in screen lines.
de0100f2 2505
96a72ee9
GM
25062012-03-02 Glenn Morris <rgm@gnu.org>
2507
2508 * buffer.c (buffer-list-update-hook): Doc fix.
2509
312508d7
EZ
25102012-02-29 Eli Zaretskii <eliz@gnu.org>
2511
2512 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2513 push_it before setting up the iterator for the first overlay
2514 string, even if we have an empty string loaded.
2515 (next_overlay_string): If there's an empty string on the iterator
2516 stack, pop the stack. (Bug#10903)
2517
27f3c637
PE
25182012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2519
2520 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2521 Suggested by Stefan Monnier in
2522 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2523 * alloc.c (widen_to_Lisp_Object): New static function.
2524 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2525 and widening them to Lisp_Objects. This would work even if
2526 USE_LSB_TAG is defined and wide integers are used, which might
2527 happen in a future version of Emacs.
2528
3c9dfce6
CY
25292012-02-25 Chong Yidong <cyd@gnu.org>
2530
fa74b241
CY
2531 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2532 Doc fix.
2533
3c9dfce6
CY
2534 * xselect.c (Fx_selection_exists_p): Doc fix.
2535 (x_clipboard_manager_save_all): Print an informative message
2536 before saving to clipboard manager.
2537
9486df08
CY
25382012-02-24 Chong Yidong <cyd@gnu.org>
2539
2540 * keyboard.c (process_special_events): Handle all X selection
2541 requests in kbd_buffer, not just the next one (Bug#8869).
2542
f01d3321
CY
25432012-02-23 Chong Yidong <cyd@gnu.org>
2544
2545 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2546 call when setting menu-bar-lines and tool-bar-lines parameters.
2547 (unwind_create_frame_1): New helper function.
2548
2549 * window.c (inhibit_window_configuration_change_hook): New var.
2550 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2551 (syms_of_window): Initialize it.
f01d3321 2552
86b847b6
CY
25532012-02-22 Chong Yidong <cyd@gnu.org>
2554
2555 * xterm.c (x_draw_image_relief): Add missing type check for
2556 Vtool_bar_button_margin (Bug#10743).
2557
a59225b1
CY
25582012-02-21 Chong Yidong <cyd@gnu.org>
2559
2560 * fileio.c (Vfile_name_handler_alist): Doc fix.
2561
2562 * buffer.c (Fget_file_buffer): Protect against invalid file
2563 handler return value.
2564
310f5bd4
PE
25652012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2566
cb3a28cc
PE
2567 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2568 when computing $valmask.
2569
310f5bd4
PE
2570 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2571 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2572 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2573 It's useless in that case, and it can cause problems on hosts
2574 that allocate halves of EMACS_INT values separately.
2575 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2576 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2577 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2578 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2579 it avoids undefined behavior on hosts where shifting right by more
2580 than the word width has undefined behavior.
2581
2375c96a
CY
25822012-02-19 Chong Yidong <cyd@gnu.org>
2583
2584 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2585 (Funhandled_file_name_directory, Ffile_name_as_directory)
2586 (Fdirectory_file_name, Fexpand_file_name)
2587 (Fsubstitute_in_file_name): Protect against invalid file handler
2588 return values (Bug#10845).
2589
3eb49e71
EZ
25902012-02-18 Eli Zaretskii <eliz@gnu.org>
2591
2592 * .gdbinit (pitx): Fix incorrect references to fields of the
2593 iterator stack.
2594
7b926f3f
CY
25952012-02-17 Chong Yidong <cyd@gnu.org>
2596
2597 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2598
11273115
PE
25992012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2602 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2603
c3a70e2b
CY
26042012-02-15 Chong Yidong <cyd@gnu.org>
2605
2606 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2607 marked as special. Also, starting docstrings with * is obsolete.
2608
0ca43699
AS
26092012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2610
2611 * gnutls.c (emacs_gnutls_write): Fix last change.
2612
2e8f3c56
LI
26132012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2614
2615 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2616 send_process.
2617
af70074f
SM
26182012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2619
2620 * keymap.c (Fsingle_key_description): Handle char ranges.
2621
95986d52
CY
26222012-02-12 Chong Yidong <cyd@gnu.org>
2623
afd83bd1
CY
2624 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2625 as that creates a dangerous corner case.
2626
95986d52
CY
2627 * window.c (Fdelete_window_internal): Invalidate the mouse
2628 highlight (Bug#9904).
2629
bd7da63e
GM
26302012-02-12 Glenn Morris <rgm@gnu.org>
2631
2632 * xselect.c (Fx_own_selection_internal)
2633 (Fx_get_selection_internal, Fx_disown_selection_internal)
2634 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2635 * nsselect.m (Fx_own_selection_internal)
2636 (Fx_disown_selection_internal, Fx_selection_exists_p)
2637 (Fx_selection_owner_p, Fx_get_selection_internal):
2638 Sync docs and argument specs with the xselect.c versions.
2639
77abcbc2
LI
26402012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2641
2642 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2643
90b671e2
EZ
26442012-02-11 Eli Zaretskii <eliz@gnu.org>
2645
1c0ca0b7
EZ
2646 * w32select.c (Fx_selection_exists_p): Sync doc string and
2647 argument list with xselect.c. (Bug#10783)
2648
2649 * w16select.c (Fx_selection_exists_p): Sync doc string and
2650 argument list with xselect.c. (Bug#10783)
90b671e2 2651
49241268
GM
26522012-02-10 Glenn Morris <rgm@gnu.org>
2653
2654 * fns.c (Fsecure_hash): Doc fix.
2655
f998bbe7 26562012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2657
2658 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2659
0992bd9c
CY
26602012-02-07 Chong Yidong <cyd@gnu.org>
2661
2662 * buffer.c (Fbuffer_local_variables)
2663 (buffer_lisp_local_variables): Handle unbound vars correctly;
2664 don't let Qunbound leak into Lisp.
2665
af008560
GM
26662012-02-07 Glenn Morris <rgm@gnu.org>
2667
dd605cc4
GM
2668 * image.c (Fimagemagick_types): Doc fix.
2669
af008560
GM
2670 * image.c (imagemagick-render-type): Change it from a lisp object
2671 to an integer. Move the doc here from the lisp manual.
2672 Treat all values not equal to 0 the same.
2673
1449fa1d
CY
26742012-02-06 Chong Yidong <cyd@gnu.org>
2675
2676 * doc.c (store_function_docstring): Avoid applying docstring of
2677 alias to base function (Bug#2603).
2678
3723ec07
AS
26792012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2680
2681 * .gdbinit (pp1, pv1): Remove redundant defines.
2682 (pr): Use pp.
2683
79c1cc1e
CY
26842012-02-04 Chong Yidong <cyd@gnu.org>
2685
2686 * nsterm.m: Declare a global (Bug#10694).
2687
d7f29f8e
EZ
26882012-02-04 Eli Zaretskii <eliz@gnu.org>
2689
cae07000
SM
2690 * w32.c (get_emacs_configuration_options):
2691 Include --enable-checking, if specified, in the return value.
d7f29f8e 2692
3b95a6f9
MR
26932012-02-04 Martin Rudalics <rudalics@gmx.at>
2694
2695 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2696 after rounding frame sizes. (Bug#9723)
2697
d6fa96a6
EZ
26982012-02-04 Eli Zaretskii <eliz@gnu.org>
2699
2700 * keyboard.c (adjust_point_for_property): Don't position point
2701 before BEGV. (Bug#10696)
2702
df0b2940
PE
27032012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2704
2705 Handle overflow when computing char display width (Bug#9496).
2706 * character.c (char_width): Return EMACS_INT, not int.
2707 (char_width, c_string_width): Check for overflow when
2708 computing the width; this is possible now that individual
2709 characters can have unbounded width. Problem introduced
2710 by merge from Emacs 23 on 2012-01-19.
2711
6bee44d6
MA
27122012-02-02 Michael Albinus <michael.albinus@gmx.de>
2713
2714 * dbusbind.c (Fdbus_register_method): Mention the return value
2715 :ignore in the docstring.
2716
44f92739
GM
27172012-02-02 Glenn Morris <rgm@gnu.org>
2718
1b9f60cc
GM
2719 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2720
44f92739
GM
2721 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2722 Unconditionally set to t. (Bug#10673)
2723 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2724 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2725 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2726
c5d3843c
KH
27272012-02-02 Kenichi Handa <handa@m17n.org>
2728
2729 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2730 0, do not call append_composite_glyph.
2731
159462d4 27322012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2733
2734 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2735 NULL (Bug#6988).
2736 (x_produce_glyphs): If the component of a composition is a null
2737 string, set it->pixel_width to 1 to avoid zero-width glyph.
2738
78cef877
EZ
27392012-02-01 Eli Zaretskii <eliz@gnu.org>
2740
2741 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2742 first 2 arguments are identical. This makes inserting large
2743 output from a subprocess an order of magnitude faster on
2744 MS-Windows, where all sbrk'ed memory is always contiguous.
2745
97897668
GM
27462012-01-31 Glenn Morris <rgm@gnu.org>
2747
2748 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2749 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2750 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2751
31fd3586
GM
27522012-01-29 Glenn Morris <rgm@gnu.org>
2753
2754 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2755
0e24a8b2
CY
27562012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2757
2758 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2759
cc0adcb0
CY
27602012-01-28 Chong Yidong <cyd@gnu.org>
2761
2762 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2763
acc28cb9
CY
27642012-01-26 Chong Yidong <cyd@gnu.org>
2765
9c69cfb7
CY
2766 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2767
acc28cb9
CY
2768 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2769 repeat counts (Bug#10507).
2770
48da7392
GM
27712012-01-26 Glenn Morris <rgm@gnu.org>
2772
2773 * lread.c (syms_of_lread): Doc fix.
2774
14af5f7f
CY
27752012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2776
2777 * coding.c (encode_designation_at_bol): Change return value to
2778 EMACS_INT.
2779
0b21c100
CY
27802012-01-25 Chong Yidong <cyd@gnu.org>
2781
2782 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2783
3c2907f7
CY
27842012-01-21 Chong Yidong <cyd@gnu.org>
2785
2786 * floatfns.c (Fcopysign): Make the second argument non-optional,
2787 since nil is not allowed anyway.
2788
959ad23f
AS
27892012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2790
2791 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2792 (send_process): Likewise.
2793
34a02f46
MR
27942012-01-19 Martin Rudalics <rudalics@gmx.at>
2795
2796 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2797 (Vwindow_persistent_parameters): Do not use Qstate.
2798 Rewrite doc-strings.
34a02f46 2799
1259009a 28002012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2801
2802 * character.c (char_width): New function.
70d4fdf6
GM
2803 (Fchar_width, c_string_width, lisp_string_width):
2804 Use char_width (Bug#9496).
25ed9e61 2805
6a6ee00d
MR
28062012-01-16 Martin Rudalics <rudalics@gmx.at>
2807
2808 * window.c (Vwindow_persistent_parameters): New variable.
2809 (Fset_window_configuration, save_window_save): Handle persistent
2810 window parameters.
2811
c85efaf7
EZ
28122012-01-14 Eli Zaretskii <eliz@gnu.org>
2813
2814 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2815 thrashing the stack of the thread. (Bug#9087)
2816
5944709e
PE
28172012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2818
2819 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2820
e71f5d99
EZ
28212012-01-11 Eli Zaretskii <eliz@gnu.org>
2822
2823 * xdisp.c (rows_from_pos_range): Handle the case where the
2824 highlight ends on a newline. (Bug#10464)
2825 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2826 he end column for display of highlight that ends on a newline
2827 before a R2L line.
2828
ce316182
GM
28292012-01-11 Glenn Morris <rgm@gnu.org>
2830
2831 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2832 from load-path also when installation-directory is nil. (Bug#10208)
2833
5b43da69
GM
28342012-01-10 Glenn Morris <rgm@gnu.org>
2835
74cc8ff9
GM
2836 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2837
7d8d6e4e
GM
2838 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2839 Update template values to be closer to their typical values these days.
5b43da69 2840
a0db8d43
EZ
28412012-01-09 Eli Zaretskii <eliz@gnu.org>
2842
2843 * xdisp.c (rows_from_pos_range): Accept additional argument
2844 DISP_STRING, and accept any glyph in a row whose object is that
2845 string as eligible for mouse highlight. Fixes mouse highlight of
2846 display strings from overlays. (Bug#10464)
2847
9a0115ab 28482012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2849
b9110d6a 2850 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2851 * fileio.c (auto_saving_dir_umask): New static var.
2852 (Fmake_directory_internal): Use it.
2853 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2854 creating the directory. The old code temporarily assigns
2855 too-generous permissions to the directory.
2856 (do_auto_save_eh): Clear it.
b9110d6a 2857 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2858 that the var is always cleared.
2859
6c1bd3f3
EZ
28602012-01-07 Eli Zaretskii <eliz@gnu.org>
2861
2862 * search.c (scan_buffer): Pass character positions to
2863 know_region_cache, not byte positions. (Bug#6540)
2864
069d2b50
L
28652012-01-07 LynX <_LynX@bk.ru> (tiny change)
2866
2867 * w32.c (sys_rename): Report EXDEV when rename of a directory
2868 fails because the target is on another logical disk. (Bug#10284)
2869
75bf0d33
DB
28702012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2871
2872 * xterm.c (x_embed_request_focus): New function.
2873
2874 * xterm.h: Add prototype.
2875
2876 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2877
1c6e5a32
GM
28782012-01-05 Glenn Morris <rgm@gnu.org>
2879
2880 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2881
651e947e
EZ
28822012-01-01 Eli Zaretskii <eliz@gnu.org>
2883
2884 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2885 Load gnutls_transport_set_lowat only if GnuTLS version is below
2886 2.11.1.
2887 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2888 GnuTLS versions below 2.11.1.
2889
3778cdd8
AL
28902011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2891
2892 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2893 to the doc string advising against its use for altering the way
2894 windows are scrolled.
2895
0e5317f7
KH
28962011-12-28 Kenichi Handa <handa@m17n.org>
2897
2898 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2899 coding-system ASCII compatible only when it does not produce BOM
2900 on encoding (Bug#10383).
2901
93d5ca1f
JD
29022011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2903
2904 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2905 can scroll.
2906 (create_and_show_popup_menu): Always use menu_position_func for
2907 Gtk3 (Bug#10361).
2908
ca22b785
AS
29092011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2910
2911 * callint.c (Fcall_interactively): Don't truncate prompt string.
2912
d048e1e6
EZ
29132011-12-23 Eli Zaretskii <eliz@gnu.org>
2914
2915 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2916 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2917 resumed from there (after widening). (Bug#10360)
d048e1e6 2918
5ccaba1f
JD
29192011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2920
2921 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2922
204ee57f
JD
29232011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2924
b81d40f0
JB
2925 * nsterm.m (x_free_frame_resources):
2926 Release f->output_data.ns->miniimage.
204ee57f
JD
2927 (ns_index_color): Fix indentation. Do not retain
2928 color_table->colors[i].
2929
2930 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2931 before returning.
2932
2933 * nsfns.m (x_set_background_color): Assign return value from
2934 ns_index_color to face-background instead of NSColor*.
2935 (ns_implicitly_set_icon_type): Fix indentation.
2936 Change assignment in for loop to comparison.
2937
2938 * emacs.c (ns_pool): New variable.
2939 (main): Assign ns_pool.
2940 (Fkill_emacs): Call ns_release_autorelease_pool.
2941
2942 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2943 autorelease fdesc, release fdAttrs and tdict.
2944 (ns_get_covering_families): Release charset.
2945 (ns_findfonts): Release NSFontDescriptor created with new.
2946 (ns_uni_to_glyphs): Fix indentation.
2947 (setString): Release attrStr before assigning new value.
2948
c803b2b7
JD
29492011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2950
678f4426
JD
2951 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2952 and NS_IMPL_COCOA.
2953 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2954 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2955
cd394be1 29562011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2957
5fecd5fc
JD
2958 * nsterm.m (ns_term_init): Subscribe for notifications
2959 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2960 to method trackingNotification in EmacsMenu.
2961
2962 * nsmenu.m (trackingMenu): New variable.
3771cb17 2963 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2964 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2965 from Aquamacs (Bug#7030).
678f4426
JD
2966
29672011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2968
c803b2b7
JD
2969 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2970 (symbol_to_nsstring): Fix indentation.
2971 (ns_symbol_to_pb): New function.
cae07000
SM
2972 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2973 (Fns_rotate_cut_buffers_internal): Remove.
2974 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2975 Fns_store_cut_buffer_internal.
2976 (ns_get_foreign_selection, Fx_own_selection_internal)
2977 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2978 (Fns_get_selection_internal, Fns_store_selection_internal):
2979 Use ns_symbol_to_pb and check if return value is nil.
2980 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2981 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2982 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2983 renamed to Sns_store_selection_internal.
2984 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2985 and remove this function.
2986 (ns_handle_selection_clear): Remove, never used.
2987 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2988 here.
2989
e1b01a3a
KB
29902011-12-17 Ken Brown <kbrown@cornell.edu>
2991
2992 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2993 GID is unknown (Bug#10257).
2994
2adb6e85
PE
29952011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2996
2997 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2998 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2999 which caused a build failure on GNU/Linux IA-64. This problem was
3000 introduced by my 2011-10-07 patch.
3001
d1d7b339
JL
30022011-12-15 Juri Linkov <juri@jurta.org>
3003
3004 * image.c (imagemagick_error): New function. (Bug#10112)
3005 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3006 Use `imagemagick_error' where ImageMagick functions return
3007 `MagickFalse'.
3008 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3009 proper order.
3010
100d5755
KH
30112011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3012
3013 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3014 fill background (Bug#8992).
3015
454592a6
MR
30162011-12-13 Martin Rudalics <rudalics@gmx.at>
3017
3018 * window.c (Vwindow_combination_resize)
3019 (Vwindow_combination_limit): Use t instead of non-nil in
3020 doc-strings.
61d4b438
MR
3021 (Vrecenter_redisplay): Add first sentence of doc-string on
3022 separate line.
53524d93 3023 (Frecenter): Fix doc-string typo.
454592a6 3024
3633e3aa
KH
30252011-12-11 Kenichi Handa <handa@m17n.org>
3026
3027 * coding.c (Funencodable_char_position): Pay attention to the
3028 buffer text relocation (Bug#9389).
3029
7b9d523a 30302011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3031
7b9d523a
JD
3032 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3033 gtk_init (Bug#10100).
3034
b73189c6
EZ
30352011-12-10 Eli Zaretskii <eliz@gnu.org>
3036
3037 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3038 IT->string is nil. (Bug#10263)
3039
f7dfe5d6
JD
30402011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3041
83faebb4
JD
3042 * nsterm.h (x_free_frame_resources): Declare.
3043
f7dfe5d6
JD
3044 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3045 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3046
3047 * nsterm.h (ns_get_defaults_value): Declare.
3048
3049 * nsterm.m (ns_default): Call ns_get_defaults_value.
3050
7cd4e72c
EZ
30512011-12-09 Eli Zaretskii <eliz@gnu.org>
3052
3053 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3054 (Bug#10170)
3055
b34d7317
YM
30562011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3057
3058 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3059 that where the value of an _OBJC_* symbol points to is in the .bss
3060 section (Bug#10240).
3061
76470ad1
KH
30622011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3063
3064 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3065 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3066
745fff94
KH
30672011-12-08 Kenichi Handa <handa@m17n.org>
3068
3069 * ftfont.c (get_adstyle_property): Fix previous change
3070 (Bug#10233).
3071
6e44397c
JB
30722011-12-07 Juanma Barranquero <lekktu@gmail.com>
3073
3074 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3075 dirs from the default value of EMACSLOADPATH (bug#10208).
3076
7efa6272
GM
30772011-12-07 Glenn Morris <rgm@gnu.org>
3078
3079 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3080 installation and source directories as well. (Bug#10208)
3081
f6fc4d87
CY
30822011-12-06 Chong Yidong <cyd@gnu.org>
3083
3084 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3085
2bf26180
GM
30862011-12-06 Glenn Morris <rgm@gnu.org>
3087
3088 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3089 as an error, not just -1. (Bug#10217)
3090
3a6ad4f0
CY
30912011-12-05 Chong Yidong <cyd@gnu.org>
3092
3093 * keyboard.c (process_special_events): New function.
3094 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3095
75a3b399
PE
30962011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3097
3098 * coding.c (encode_designation_at_bol): Don't use uninitialized
3099 local variable (Bug#9318).
3100
c3c9e25e
KH
31012011-12-05 Kenichi Handa <handa@m17n.org>
3102
3103 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3104 return Qnil (Bug#8046, Bug#10193).
3105
5eb05ea3
KH
31062011-12-05 Kenichi Handa <handa@m17n.org>
3107
3108 * coding.c (encode_designation_at_bol): New args charbuf_end and
3109 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3110 (coding_set_source): Return how many bytes coding->source was
3111 relocated.
3112 (coding_set_destination): Return how many bytes
3113 coding->destination was relocated.
3114 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3115 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3116
31172011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3118
3119 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3120 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3121 macro (Bug#9318).
3122
31232011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3124
3125 The following changes are to fix Bug#9318.
3126
a79703f5 3127 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3128 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3129 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3130 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3131
7dbda6df
JB
31322011-12-05 Juanma Barranquero <lekktu@gmail.com>
3133
3134 * lisp.h (process_quit_flag): Fix external declaration.
3135
6d5eb5b0
SM
31362011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3137
3138 Don't macro-inline non-performance-critical code.
3139 * eval.c (process_quit_flag): New function.
3140 * lisp.h (QUIT): Use it.
3141
a0c3fad0
JD
31422011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3143
3144 * nsfns.m (get_geometry_from_preferences): New function.
3145 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3146
6c07aac2
AS
31472011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3148
3149 * emacs.c (Qkill_emacs): Define.
3150 (syms_of_emacs): Initialize it.
3151 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3152 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3153 (quit_throw_to_read_char): Add parameter `from_signal'.
3154 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3155 * lisp.h (QUIT): Call Fkill_emacs if requested.
3156
c052ead4
JD
31572011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3158
3159 * widget.c (update_wm_hints): Return if wmshell is null.
3160 (widget_update_wm_size_hints): New function.
3161
3162 * widget.h (widget_update_wm_size_hints): Declare.
3163
3164 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3165 widget_update_wm_size_hints (Bug#10104).
3166
9e49252b
EZ
31672011-12-03 Eli Zaretskii <eliz@gnu.org>
3168
3169 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3170 before a newline, prepare the bidi iterator for consuming the
3171 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3172 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3173
02b16839
JL
31742011-12-02 Juri Linkov <juri@jurta.org>
3175
3176 * search.c (Fword_search_regexp): New Lisp function created from
3177 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3178 (Fword_search_backward, Fword_search_forward)
3179 (Fword_search_backward_lax, Fword_search_forward_lax):
3180 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3181 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3182
0068070e
SM
31832011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3184
3185 * fileio.c (Finsert_file_contents): Move after-change-function call
3186 to before the "handled:" label, since all "goto handled" appear in
3187 cases where the *-change-functions have already been properly called
3188 (bug#10117).
3189
3360a3fc
AS
31902011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3191
3192 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3193 waiting for input. (Bug#10169)
3194
73d6c093
EZ
31952011-11-30 Eli Zaretskii <eliz@gnu.org>
3196
3197 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3198 verifies glyph row's hash code--we have just reallocated the
3199 glyphs, so their contents can be complete garbage. (Bug#10164)
3200
febe6bea
JB
32012011-11-30 Juanma Barranquero <lekktu@gmail.com>
3202
3203 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3204
801a4313
EZ
32052011-11-30 Eli Zaretskii <eliz@gnu.org>
3206
3207 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3208 attributes are tested _before_ calling verify_row_hash, to protect
3209 against GCC re-ordering of the tests. (Bug#10164)
3210
2b56b87e
JD
32112011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3212
3213 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3214
3215 * xterm.c (handle_one_xevent): Only set async_visible and friends
3216 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3217 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3218 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3219
dbf31225
PE
32202011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3221
3222 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3223 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3224 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3225 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3226 All uses changed to use GCPRO1 etc.
3227 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3228 Revert to old implementation (i.e., before 2011-03-11).
3229
1305621b
YM
32302011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3231
3232 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3233 of scroll runs so as to avoid assigning disabled bogus rows and
3234 unnecessary graphics copy operations.
3235
8c9afb46
EZ
32362011-11-27 Eli Zaretskii <eliz@gnu.org>
3237
3238 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3239 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3240 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3241 (malloc, free, realloc, calloc): Redirect to e_* only when
3242 compiling Emacs.
3243
3244 * lisp.h (GCTYPEBITS): Move before first use.
3245 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3246 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3247 this macro definition.
3248
3249 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3250 _MSC_VER.
3251
54e9e3bf
JD
32522011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3253
6d5eb5b0
SM
3254 * gtkutil.c (xg_create_frame_widgets):
3255 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3256 present with Gtk+ 2.0.
3257
83aca1cb
PE
32582011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3259
3260 * fileio.c (Finsert_file_contents): Undo previous change; see
3261 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3262
5b76caa4
PE
32632011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3264
3265 Rename locals to avoid shadowing.
3266 * fileio.c (Finsert_file_contents):
3267 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3268 * process.c (wait_reading_process_output):
3269 Rename inner 'proc' to 'p' to avoid shadowing.
3270 Indent for consistency with usual Emacs style.
3271
8c535114
EZ
32722011-11-25 Eli Zaretskii <eliz@gnu.org>
3273
3274 * xdisp.c (redisplay_window): If cursor row is not fully visible
3275 after recentering, and scroll-conservatively is set to a large
3276 number, scroll window by a few more lines to make the cursor fully
3277 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3278 (start_display): Don't move to the next line if the display should
3279 start at a newline that is part of a display vector or an overlay
3280 string. (Bug#10119)
8c535114 3281
fa4fdb5c
JL
32822011-11-24 Juri Linkov <juri@jurta.org>
3283
3284 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3285 after the `MagickPingImage' call. (Bug#10112)
3286
90ec88df
CY
32872011-11-23 Chong Yidong <cyd@gnu.org>
3288
3289 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3290
56e2e794
MR
32912011-11-23 Martin Rudalics <rudalics@gmx.at>
3292
3293 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3294 making another buffer current. (Bug#10114)
3295
b6e64c41
GM
32962011-11-23 Glenn Morris <rgm@gnu.org>
3297
3298 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3299
6b21de18
CY
33002011-11-23 Chong Yidong <cyd@gnu.org>
3301
3302 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3303 using it (Bug#5984).
3304
b12cd789
EZ
33052011-11-22 Eli Zaretskii <eliz@gnu.org>
3306
3307 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3308 and header-lines, as they don't have one computed for them.
3309 (Bug#10098)
3310
3311 * .gdbinit (prow): Make displayed values more self-explaining.
3312 Add row's hash code.
3313
261b6fd4
LMI
33142011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3315
3316 * process.c (wait_reading_process_output): Fix asynchrounous
3317 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3318 (wait_reading_process_output): Add comment and URL.
261b6fd4 3319
e7cfd277
JD
33202011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3321
3322 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3323
a9b9b7f5
CY
33242011-11-21 Chong Yidong <cyd@gnu.org>
3325
3326 * window.c (Fnext_window, Fprevious_window): Doc fix.
3327
b0d15b4f
SM
33282011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3329
3330 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3331
fe7a3057
JB
33322011-11-20 Juanma Barranquero <lekktu@gmail.com>
3333
3334 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3335
d2999b1a
MR
33362011-11-20 Martin Rudalics <rudalics@gmx.at>
3337
3338 * window.c (Fset_window_combination_limit): Rename argument
3339 STATUS to LIMIT.
3340 (Vwindow_combination_limit): Remove "status" from doc-string.
3341
d5ff9cd0
AS
33422011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3343
3344 * m/ibms390.h: Remove.
3345 * m/ibms390x.h: Don't include "ibms390.h".
3346
a5bb9bd3
SM
33472011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3348
3349 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3350 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3351
cd1181db
JB
33522011-11-20 Juanma Barranquero <lekktu@gmail.com>
3353
3354 * casetab.c (Fset_case_table):
3355 * charset.c (Fcharset_after): Fix typos.
3356
615a3b8d 33572011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3358
17e845af
PE
3359 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3360 Otherwise, valgrind does not work on some platforms.
3361 Problem reported by Andreas Schwab in
6a0bf43d
PE
3362 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3363 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3364 is set, removing the need for VIRT_ADDRESS_VARIES.
3365 (PURE_P): Use a more-efficient implementation that needs just one
3366 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3367 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3368 to 4 (xorl, subq, cmpq, setbe).
3369 * alloc.c (pure): Always extern now, since that's the
3370 VIRT_ADDR_VARIES behavior.
3371 (PURE_POINTER_P): Use a single comparison, not two, for
3372 consistency with the new puresize.h.
3373 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3374 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3375 Remove VIRT_ADDR_VARIES no longer needed.
3376
f8fe6f96
EZ
33772011-11-19 Eli Zaretskii <eliz@gnu.org>
3378
3379 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3380 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3381 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3382 behave as if the cursor position were at the window margin.
3383
3384 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3385 and the cursor position is out of bounds, behave as if the cursor
3386 position were at the window margin. (Bug#10075)
3387
df05a53c
CY
33882011-11-18 Chong Yidong <cyd@gnu.org>
3389
3390 * window.c (Fwindow_combination_limit): Make first argument
3391 non-optional, since it is meaningless for live windows like the
3392 selected window.
61ccba97 3393
2071918e
DA
33942011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3395
3396 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3397
b50a28de
SM
33982011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3399
3400 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3401 (graft_intervals_into_buffer): Simplify.
3402
015137db
EZ
34032011-11-18 Eli Zaretskii <eliz@gnu.org>
3404
3405 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3406 hash values of the two rows.
3407 (copy_row_except_pointers): Preserve the used[] arrays and the
3408 hash values of the two rows. (Bug#10035)
68c95424 3409 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3410
3411 * xdisp.c (row_hash): New function, body extracted from
3412 compute_line_metrics.
3413 (compute_line_metrics): Call row_hash, instead of computing the
3414 hash code inline.
3415
3416 * dispnew.c (verify_row_hash): Call row_hash for computing the
3417 hash code of a row, instead of duplicating code from xdisp.c.
3418
3419 * dispextern.h (row_hash): Add prototype.
3420
a2addb04
TH
34212011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3422
3423 * frame.c (delete_frame): Don't delete the terminal when the last
3424 X frame is closed if emacs is built with GTK toolkit.
3425
df85d315
JB
34262011-11-17 Juanma Barranquero <lekktu@gmail.com>
3427
3428 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3429
a0c2d0ae
MR
34302011-11-17 Martin Rudalics <rudalics@gmx.at>
3431
3432 * window.c (Vwindow_splits): Rename to
3433 Vwindow_combination_resize. Suggested by Juri Linkov.
3434 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3435 of Vwindow_splits.
3436
58179cce
JB
34372011-11-16 Juanma Barranquero <lekktu@gmail.com>
3438
7877f373
JB
3439 * nsfns.m (Fns_font_name):
3440 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3441
b6f67890
MR
34422011-11-16 Martin Rudalics <rudalics@gmx.at>
3443
3444 * window.h (window): Rename slot "nest" to "combination_limit".
3445 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3446 (Fset_window_nest): Rename to Fset_window_combination_limit.
3447 (Vwindow_nest): Rename to Vwindow_combination_limit.
3448 (recombine_windows, make_parent_window, make_window)
3449 (Fsplit_window_internal, saved_window)
3450 (Fset_window_configuration, save_window_save): Rename all
3451 occurrences of window_nest to window_combination_limit.
3452
c7015153
JB
34532011-11-15 Juanma Barranquero <lekktu@gmail.com>
3454
3455 * image.c (imagemagick_load_image): Fix typo.
3456
322ad6ec
EZ
34572011-11-14 Eli Zaretskii <eliz@gnu.org>
3458
3459 * xdisp.c (display_line): Move the call to
3460 highlight_trailing_whitespace before the call to
3461 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3462 faces of all the glyphs to compute ROW's hash value.
3463 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3464
f067b8ec
JB
34652011-11-14 Juanma Barranquero <lekktu@gmail.com>
3466
3467 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3468 just return (bug#10044).
3469
1e5b2111
EZ
34702011-11-12 Eli Zaretskii <eliz@gnu.org>
3471
7ef3cbd5
EZ
3472 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3473 with user-defined heap size. Bump the default size of the temacs
3474 heap to 27MB, to avoid memory warning when running temacs.
3475 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3476
1e5b2111
EZ
3477 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3478 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3479 (verify_row_hash) [XASSERTS]: New function.
3480 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3481 that the hash value of glyph rows is correct.
1e5b2111 3482
89d61221
MR
34832011-11-12 Martin Rudalics <rudalics@gmx.at>
3484
3485 * window.h (window): Remove splits slot.
3486 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3487 (Fdelete_other_windows_internal, make_parent_window)
3488 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3489 (Fset_window_configuration, save_window_save): Don't deal with
3490 split status of windows.
3491 (saved_window): Remove splits slot.
3492 (Vwindow_splits): Rewrite doc-string.
3493
97f18cc8
JD
34942011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3495
3496 * xfns.c (unwind_create_frame):
3497 * nsfns.m (unwind_create_frame):
3498 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3499 Vframe_list (Bug#9999).
3500
22a648b4
DA
35012011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3502
0b381c7e 3503 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3504
659afede
KH
35052011-11-11 Kenichi Handa <handa@m17n.org>
3506
3507 * callproc.c (Fcall_process): Set the member dst_multibyte of
3508 process_coding.
3509
9ac0394b
KH
35102011-11-11 Johan Bockgård <bojohan@gnu.org>
3511
3512 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3513 avoid a crash (bug#9496).
3514
2fbdc249
CY
35152011-11-09 Chong Yidong <cyd@gnu.org>
3516
3517 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3518 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3519
ac6b1f81
PE
35202011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3521
3522 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3523
09db192c
PE
35242011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3525
3526 Avoid some portability problems by eschewing 'extern inline' functions.
3527 The trivial performance wins aren't worth the portability hassles; see
3528 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3529 et seq.
3530 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3531 (window_box_width, window_box_left, window_box_left_offset)
3532 (window_box_right, window_box_right_offset): Undo previous change,
3533 by removing the "extern"s.
3534 * intervals.c (adjust_intervals_for_insertion)
3535 (adjust_intervals_for_deletion): Undo previous change,
3536 making these static again.
3537 (offset_intervals, temp_set_point_both, temp_set_point)
3538 (copy_intervals_to_string): No longer inline.
3539 * xdisp.c (window_text_bottom_y, window_box_width)
3540 (window_box_height, window_box_left_offset)
3541 (window_box_right_offset, window_box_left, window_box_right)
3542 (window_box): No longer inline.
3543
105216ed
CY
35442011-11-08 Chong Yidong <cyd@gnu.org>
3545
3546 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3547 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3548 Signal an error if not a live window.
105216ed
CY
3549 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3550 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3551
ae9e237f
JB
35522011-11-07 Juanma Barranquero <lekktu@gmail.com>
3553
3554 * lisp.h (syms_of_abbrev): Remove declaration.
3555 Reported by CHENG Gao <chenggao@royau.me>.
3556
c7aa8333
EZ
35572011-11-07 Eli Zaretskii <eliz@gnu.org>
3558
3559 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3560 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3561 of temacs in GUI mode.
3562
be7f5545
MR
35632011-11-07 Martin Rudalics <rudalics@gmx.at>
3564
3565 * window.h: Declare delete_all_child_windows instead of
3566 delete_all_subwindows.
3567 * window.c (Fwindow_nest, Fset_window_nest)
3568 (Fset_window_new_total, Fset_window_new_normal)
3569 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3570 (delete_all_subwindows): Rename to delete_all_child_windows.
3571 (Fdelete_other_windows_internal, Fset_window_configuration):
3572 Call delete_all_child_windows instead of delete_all_subwindows.
3573 * frame.c (delete_frame): Call delete_all_child_windows instead
3574 of delete_all_subwindows.
3575
ca78dc43
PE
35762011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3577
3578 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3579 This is also needed for porting to any host where GC_MARK_STACK is
3580 not GC_MAKE_GCPROS_NOOPS.
3581 (which_symbols): Use it.
3582
a0241d01
KH
35832011-11-07 Kenichi Handa <handa@m17n.org>
3584
3585 * coding.c (coding_set_destination): Check coding->src_pos only
3586 when coding->src_object is a buffer (bug#9910).
3587
3588 * process.c (send_process): Set the member src_multibyte of coding
3589 to 0 (bug#9911) when sending a unibyte text.
3590
3591 * callproc.c (Fcall_process): Set the member src_multibyte of
3592 process_coding to 0 (bug#9912).
3593
a64bfdfa 35942011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3595
3596 * xmenu.c (cleanup_widget_value_tree): New function.
3597 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3598 calling free_menubar_widget_value_tree directly (Bug#9830).
3599
cb41b32a
PE
36002011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3601
3602 Fix some portability problems with 'inline'.
3603 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3604 (window_box_width, window_box_left, window_box_left_offset)
3605 (window_box_right, window_box_right_offset): Declare extern.
3606 Otherwise, these inline functions do not conform to C99 and
3607 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3608 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3609 * intervals.c (adjust_intervals_for_insertion)
3610 (adjust_intervals_for_deletion): Now extern, because otherwise the
3611 extern inline functions 'offset_intervals' couldn't refer to it.
3612 (static_offset_intervals): Remove.
3613 (offset_intervals): Rewrite using the old contents of
3614 static_offset_intervals. The old version didn't conform to C99
3615 because an extern inline function contained a reference to an
3616 identifier with static linkage.
3617
b7041366
AS
36182011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3619
3620 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3621 GC.
3622
88a37c4d
EZ
36232011-11-06 Eli Zaretskii <eliz@gnu.org>
3624
3625 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3626 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3627 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3628 return Qleft_to_right.
3629
49745b39
CY
36302011-11-06 Chong Yidong <cyd@gnu.org>
3631
3632 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3633 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3634 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3635 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3636 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3637 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3638 (Fwindow_vscroll): Doc fix.
3639 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3640 argument, since it makes no sense to pass a live window and for
3641 consistency with window-child.
3642
1f05cd82
CS
36432011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3644
3645 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3646 support MSVC.
3647
22610910
JR
36482011-11-05 Jason Rumney <jasonr@gnu.org>
3649
3650 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3651 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3652 fonts (Bug#6029).
3653 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3654 bitwise arithmetic preventing use of unicode-sip and non-truetype
3655 opentype fonts.
3656
a06776b2
EZ
36572011-11-05 Eli Zaretskii <eliz@gnu.org>
3658
3ad924ba
EZ
3659 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3660 "emacs"-only part.
3661
a06776b2
EZ
3662 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3663 initialization code to keep similarity to xfns.c after changes
3664 from 2011-11-05.
3665
c9e7db78
JD
36662011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3667
a97f8f3f
JD
3668 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3669 (unwind_create_frame): New function (Bug#9943).
3670 (Fx_create_frame): Restructure code to be more similar to the one in
3671 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3672 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3673 Move terminal->reference_count++ just before making the frame official
3674 (Bug#9943).
3675
3676 * nsterm.m (x_free_frame_resources): New function.
3677 (x_destroy_window): Move code to x_free_frame_resources.
3678
c9e7db78 3679 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3680 (Fx_create_frame, x_create_tip_frame):
3681 Move terminal->reference_count++ just before making the frame
75f1671a 3682 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3683 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3684
a6fc3b5c
EZ
36852011-11-05 Eli Zaretskii <eliz@gnu.org>
3686
3687 Support MSVC build with newer versions of Visual Studio.
3688 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3689 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3690 nt/gmake.defs.
3691
3692 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3693 which are not supported by MSVC.
3694 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3695 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3696 bitfields.
3697 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3698 types in bitfields.
3699 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3700
3701 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3702
58179cce 37032011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3704
3705 Support MSVC build with newer versions of Visual Studio.
3706 * w32.c: Don't include w32api.h for MSVC.
3707 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3708
3709 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3710 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3711 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3712 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3713 e_* cousins.
3714 (alloca) [_MSC_VER]: Define to _alloca.
3715
3716 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3717
3718 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3719
a58c13ed
EZ
37202011-11-04 Eli Zaretskii <eliz@gnu.org>
3721
3722 * xdisp.c (note_mouse_highlight): If either of
3723 previous/next-single-property-change returns nil, treat that as
3724 the beginning or the end of the buffer. (Bug#9955)
3725
fe0b6370
JD
37262011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3727
a58c13ed 3728 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3729 label is not null (Bug#9951).
3730 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3731 may be NULL.
3732
89bd5ee1
EZ
37332011-11-04 Eli Zaretskii <eliz@gnu.org>
3734
3735 * window.c (Fwindow_body_size): Mention in the doc string that the
3736 return value is in frame's canonical units. (Bug#9949)
3737
84c3edb9
EZ
37382011-11-03 Eli Zaretskii <eliz@gnu.org>
3739
4e2fb5c7
EZ
3740 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3741
84c3edb9 3742 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3743 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3744 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3745
bc17a887
EZ
37462011-11-01 Eli Zaretskii <eliz@gnu.org>
3747
3748 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3749 Don't stop backward scan on the continuation glyph, even though
3750 its CHARPOS is positive.
6d5eb5b0
SM
3751 (mouse_face_from_buffer_pos, note_mouse_highlight):
3752 Rename cover_string to disp_string.
bc17a887 3753
4ee88440
MR
37542011-11-01 Martin Rudalics <rudalics@gmx.at>
3755
3756 * window.c (temp_output_buffer_show): Don't use
3757 Vtemp_buffer_show_specifiers.
3758 (Vtemp_buffer_show_specifiers): Remove unused variable.
3759
c2ff3c02
EZ
37602011-10-30 Eli Zaretskii <eliz@gnu.org>
3761
3762 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3763 past the beginning of the current glyph matrix.
3764
58179cce 37652011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3766
3767 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3768 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3769 HAVE_GTK3 (Bug#9869).
b77a6a7f 3770
3b574623
JD
3771 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3772 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3773
b77a6a7f
JD
3774 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3775
3776 * xterm.c: Declare x_handle_net_wm_state to return int.
3777 (handle_one_xevent): Check if we are iconified but don't have
3778 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3779 (get_current_wm_state): Return non-zero if not hidden,
3780 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3781 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3782 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3783 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3784
196e41e4
PE
37852011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3786
3787 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3788 so that this new function doesn't get optimized away by a
3789 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3790
021f2e1a
AS
37912011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3792
3793 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3794
8b058d44
EZ
37952011-10-29 Eli Zaretskii <eliz@gnu.org>
3796
3797 Fix the `xbytecode' command.
3798 * .gdbinit (xprintbytestr): New command.
b50a28de 3799 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3800 (xbytecode): Print the byte-code string as well.
3801
4452fb80
EZ
38022011-10-29 Kim Storm <storm@cua.dk>
3803
8b058d44
EZ
3804 * alloc.c (which_symbols): New function.
3805
21b72067
AS
38062011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3807
3808 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3809 line. (Bug#9903)
3810
83ed7b5c
GM
38112011-10-29 Glenn Morris <rgm@gnu.org>
3812
3813 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3814 Not clear what it was for, and it causes various bugs. (Bug#9839)
3815
5a7a728b
EZ
38162011-10-28 Eli Zaretskii <eliz@gnu.org>
3817
3818 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3819 possible random value that matches one of those tested as
3820 condition to clear the mouse face.
3821
d3d0842f
CY
38222011-10-28 Chong Yidong <cyd@gnu.org>
3823
3824 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3825
31b39d13
DN
38262011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3827
3828 * window.c (make_window): Initialize phys_cursor_on_p.
3829
9aba6043
SM
38302011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3831
3832 * lisp.h (struct Lisp_Symbol): Update comments.
3833
c20992f4
JB
38342011-10-28 Juanma Barranquero <lekktu@gmail.com>
3835
3836 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3837
db4f02f2
EZ
38382011-10-28 Eli Zaretskii <eliz@gnu.org>
3839
3840 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3841 <oslsachem@gmail.com> for helping to debug this.
3842
3843 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3844 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3845 (g_b_init_get_glyph_outline_w): New static variables.
3846 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3847 (GetGlyphOutlineW_Proc): New typedefs.
3848 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3849 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3850 New functions.
3851 (w32font_open_internal, compute_metrics):
3852 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3853 instead of calling the "wide" APIs directly.
3854
3855 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3856
3857 * w32.h (syms_of_w32font): Add prototype.
3858
87e68db4
JB
38592011-10-27 Juanma Barranquero <lekktu@gmail.com>
3860
3861 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3862 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3863 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3864 (Fmove_to_window_line): Doc fix.
3865
435c1d67
CY
38662011-10-27 Chong Yidong <cyd@gnu.org>
3867
3868 * process.c (make_process): Set gnutls_state to NULL.
3869
3870 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3871 non-NULL, regardless of GNUTLS_INITSTAGE.
3872 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3873 an error. Set process slots as soon as we allocate them.
3874
3875 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3876
9c6c6f49
CY
38772011-10-27 Chong Yidong <cyd@gnu.org>
3878
9aba6043
SM
3879 * gnutls.c (emacs_gnutls_deinit): New function.
3880 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3881 (Fgnutls_deinit, Fgnutls_boot): Use it.
3882
3883 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3884 (deactivate_process): Call emacs_gnutls_deinit.
3885
657d08d3
JB
38862011-10-27 Juanma Barranquero <lekktu@gmail.com>
3887
3888 * image.c (x_create_x_image_and_pixmap):
3889 * w32.c (sys_rename, w32_delayed_load):
3890 * w32font.c (fill_in_logfont):
3891 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3892
5430d399
JB
38932011-10-26 Juanma Barranquero <lekktu@gmail.com>
3894
3895 * w32fns.c (w32_default_color_map): New function,
3896 extracted from Fw32_default_color_map.
a7ef684b 3897 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3898
fe0055fa
PE
38992011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3900
3901 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3902
e6346438
SM
39032011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3904
3905 * keyboard.c (test_undefined): New function (bug#9751).
3906 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3907
e112cc37
ET
39082011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3909
3910 * sysdep.c (init_sys_modes): Fix the check for the controlling
3911 terminal (Bug#6649).
3912
7b5d6677
EZ
39132011-10-20 Eli Zaretskii <eliz@gnu.org>
3914
3915 * dispextern.h (struct bidi_it): New member next_en_type.
3916
3917 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3918 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3919 current character, check also for next_en_type being WEAK_EN.
3920 (bidi_resolve_weak): Don't enter the expensive loop if the current
3921 position is before next_en_pos. Record the bidi type of the first
3922 non-ET, non-BN character we find, in addition to its position.
3923 (bidi_level_of_next_char): Invalidate next_en_type when
3924 next_en_pos is over-stepped.
3925
7da0b018
PE
39262011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3927
3928 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3929 * editfns.c: Rewrite current-time-zone so that it invokes
3930 the equivalent of (format-time-string "%Z") to get the time zone name.
3931 This fixes a bug when the time zone name contains characters that
3932 need converting from the system time locale to Emacs internal format.
3933 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3934 that patch fixed format-time-string to do the conversion, but
3935 I forgot to fix current-time-zone.
3936 (format_time_string): New function, containing most of
3937 what Fformat_time_string used to contain.
3938 (Fformat_time_string): Rewrite in terms of format_time_string.
3939 This doesn't change this function's behavior.
3940 (current-time-zone): Rewrite to use format_time_string.
3941 This fixes the bug reported by Michael Schierl in
3942 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3943 Jason Rumney's 2007-06-07 change worked around this bug, but
3944 didn't fix it.
3945 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3946
8547b010
EZ
39472011-10-19 Eli Zaretskii <eliz@gnu.org>
3948
3949 * xdisp.c (start_display): If the character at POS is displayed
3950 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3951 (try_window_reusing_current_matrix): If a line ends in a display
3952 vector or the next line starts in a display vector, continue
3953 redrawing the window even though the character position of
3954 start_row was reached.
8547b010
EZ
3955 (Bug#9771, part 2)
3956
4e948d15
CY
39572011-10-18 Chong Yidong <cyd@gnu.org>
3958
3959 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3960 with nobreak-char-display too.
3961
4787455f
EZ
39622011-10-18 Eli Zaretskii <eliz@gnu.org>
3963
3964 Fix part 3 of bug#9771.
3965 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3966 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3967 non-neutral characters if the current character is a paragraph
3968 separator (a.k.a. Newline). This avoids running the same
3969 expensive loop twice, once when we consume the preceding newline
3970 and the other time when the line actually needs to be displayed.
3971 Avoid the loop when we see neutrals on the base embedding level
3972 following a character whose directionality is the same as the
3973 paragraph's. This avoids running the expensive loop when a line
3974 ends in a long sequence of neutrals, like control characters.
3975 Add assertion against STRONG_AL type. Slightly rearrange code
3976 that determines the type of a neutral given the first non-neutral
3977 that follows it.
3978 (bidi_level_of_next_char): Set next_en_pos to zero when
3979 invalidating its info.
3980
2c91f553
EZ
39812011-10-17 Eli Zaretskii <eliz@gnu.org>
3982
3983 * xdisp.c (push_display_prop): Determine whether to record string
3984 or buffer position by IT->string, not by IT->method. Allow
3985 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3986 (move_it_vertically_backward): Don't look for character position
3987 immediately after the newline when in a continuation line.
3988 (Bug#9771, part 1)
2c91f553 3989
c7b08b0d
MR
39902011-10-15 Martin Rudalics <rudalics@gmx.at>
3991
3992 * window.c (coordinates_in_window): Rewrite and delabelize
3993 vertical border check. (Bug#5357) (Bug#9618)
3994
6b02f655
SM
39952011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3996
3997 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3998 errors in XSetWindowBorder (bug#9310).
3999
81d40c92
DA
40002011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4001
4002 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4003 avoid crash when xmalloc overrun checking is enabled.
4004
d4172c3b
EZ
40052011-10-13 Eli Zaretskii <eliz@gnu.org>
4006
4007 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4008 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4009 cursor motion with <left> and <right> arrow keys.
4010
4011 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4012 some callers set that themselves.
4013
b00eea75
EZ
40142011-10-12 Eli Zaretskii <eliz@gnu.org>
4015
4016 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4017 display string and the previous row comes from the same string and
4018 is empty. (Bug#9739) (Bug#9738)
4019
8fe012c4
SM
40202011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4021
4022 * doc.c (get_doc_string): Encode file name (bug#9735).
4023
0074aef2
EZ
40242011-10-12 Eli Zaretskii <eliz@gnu.org>
4025
79beb178
EZ
4026 * bidi.c (bidi_level_of_next_char):
4027 * xdisp.c (get_visually_first_element): Remove old incorrect
4028 comments regarding the Unicode Line Separator character.
4029
0074aef2
EZ
4030 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4031
6e4b3fbe
DA
40322011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4033
4034 * alloc.c (Fgc_status): Do not access beyond zombies array
4035 boundary if nzombies > MAX_ZOMBIES.
4036 * alloc.c (dump_zombies): Add missing format specifier.
4037
0324f3af
PE
40382011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4039
b5525cac
PE
4040 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4041 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4042
0324f3af
PE
4043 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4044 Some packages use them to denote characters with modifiers.
4045
e9b5f888
AS
40462011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4047
4048 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4049 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4050 matching a pp-number. Rename parameter var to var1.
4051
127827c0
SM
40522011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4053
4054 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4055
c8fd3bd0
GM
40562011-10-08 Glenn Morris <rgm@gnu.org>
4057
4058 * callint.c (Fcall_interactively): Give a more explicit error for the
4059 'c' case with a non-character input. (Bug#8479)
4060
352ec8ff
EZ
40612011-10-08 Eli Zaretskii <eliz@gnu.org>
4062
03669ccb
EZ
4063 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4064 lines.
7061c986
EZ
4065 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4066 lines that are hscrolled on the left.
03669ccb 4067
352ec8ff
EZ
4068 * dispnew.c (buffer_posn_from_coords): Account for a possible
4069 presence of header-line. (Bug#4426)
4070
a66cfb1c
SM
40712011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4072
6b02f655
SM
4073 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4074 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4075
7c5ee88e
PE
40762011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4077
4078 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4079 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4080 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4081 this makes Emacs dump core during garbage collection on rare
4082 occasions. sizeof is obviously inferior to offsetof here, so
4083 stick with offsetof.
4084 (GC_POINTER_ALIGNMENT): New macro.
4085 (mark_memory): Omit 3rd (offset) arg; caller changed.
4086 Don't assume EMACS_INT alignment is the same as pointer alignment.
4087
df1bbe5b
SM
40882011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4089
4090 * keyboard.c (read_key_sequence_remapped): New var.
4091 (read_key_sequence): Compute remapping in the right buffer.
4092 (command_loop_1): Use read_key_sequence's remapping directly.
4093
51553db6
SM
40942011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4095
32c1fffd
SM
4096 * dired.c (file_name_completion): Don't expand file name.
4097 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4098 before checking file name handler.
4099
51553db6
SM
4100 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4101 they've been requested explicitly (bug#9591).
4102
b6bd1599 41032011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4104
4105 * keymap.c (Fsingle_key_description): Use make_specified_string
4106 instead of build_string to build string from push_key_description.
4107 (Bug#5193)
4108
f701dc2a
PE
41092011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4110
4222c55d
PE
4111 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4112 This fixes a Y2038 bug on 64-bit hosts.
4113 * buffer.c (reset_buffer):
4114 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4115 (Fclear_buffer_auto_save_failure):
4116 Use 0, not -1, to represent an unset failure time, since time_t
4117 might not be signed.
4118
f701dc2a
PE
4119 Remove dependency on glibc malloc internals.
4120 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4121 Move back here from lisp.h, but with their new implementations.
4122 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4123 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4124 * charset.c (charset_table_init): New static var.
4125 (syms_of_charset): Use it instead of xmalloc. This removes a
4126 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4127 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4128 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4129 Move back to alloc.c.
4130 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4131 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4132
9ceebf39
JD
41332011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4134
4135 * nsterm.m (windowDidResize): Call x_set_window_size only when
4136 ns_in_resize is true. Otherwise set pixelwidth/height and
4137 call change_frame_size (Bug#9628).
4138
cb993c58
PE
41392011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4140
3930c88b
PE
4141 Port --enable-checking=all to Fedora 14 x86-64.
4142 * charset.c (syms_of_charset): Also account for glibc malloc's
4143 internal overhead when calculating the initial malloc maximum.
4144
cb993c58
PE
4145 Port --enable-checking=all to Fedora 14 x86.
4146 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4147 Move to lisp.h.
4148 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4149 (overrun_check_realloc, overrun_check_free):
4150 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4151 That way, xmalloc returns a properly-aligned pointer even if
4152 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4153 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4154 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4155 into account when calculating the initial malloc maximum.
4156 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4157 Move here from alloc.c, so that charset.c can use it too.
4158 Properly align; the old code wasn't right for common 32-bit hosts
4159 when configured with --enable-checking=all.
4160 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4161 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4162
31bed486
EZ
41632011-09-29 Eli Zaretskii <eliz@gnu.org>
4164
04c70788 4165 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4166 use EDOM.
4167
fbcaa2f3
EZ
41682011-09-28 Eli Zaretskii <eliz@gnu.org>
4169
4170 * xdisp.c (compute_display_string_end): If there's no display
4171 string at CHARPOS, return -1.
4172
4173 * bidi.c (bidi_fetch_char): When compute_display_string_end
4174 returns a negative value, treat the character as a normal
4175 character not covered by a display string. (Bug#9624)
4176
a239d4e9
JB
41772011-09-28 Juanma Barranquero <lekktu@gmail.com>
4178
4179 * lread.c (Fread_from_string): Fix typo in docstring.
4180
88652fd5
EZ
41812011-09-27 Eli Zaretskii <eliz@gnu.org>
4182
4183 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4184 newline, reseat the iterator instead of bidi-iterating there one
4185 character at a time. (Bug#9610)
32c1fffd
SM
4186 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4187 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4188
ed497dd4
AS
41892011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4190
4191 * lread.c (readevalloop): Use correct code for NBSP.
4192 (read1): Likewise. (Bug#9608)
4193
b2bf61aa
MA
41942011-09-25 Michael Albinus <michael.albinus@gmx.de>
4195
4196 * dbusbind.c (Fdbus_register_signal): When service is not
4197 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4198
32bbb17c
GM
41992011-09-25 Glenn Morris <rgm@gnu.org>
4200
4201 * buffer.c (truncate-lines): Doc fix.
4202
94e0933e
CY
42032011-09-24 Chong Yidong <cyd@stupidchicken.com>
4204
4205 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4206 (Fset_window_next_buffers): Doc fix.
4207
cddde921
GM
42082011-09-24 Glenn Morris <rgm@gnu.org>
4209
4210 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4211
1260aef1
PE
42122011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4213
25b4bfa0
PE
4214 Fix minor problems found by static checking.
4215 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4216 * indent.c (Fvertical_motion): Fix == vs = typo.
4217
e3cbd34b
EZ
42182011-09-24 Eli Zaretskii <eliz@gnu.org>
4219
a66cfb1c
SM
4220 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4221 Default value is now t. Doc fix.
6bf7006f 4222
e3cbd34b 4223 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4224 logic when moving up, not only when moving down. Fix the
e3cbd34b 4225 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4226 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4227
4228 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4229 CHARPOS is covered by a display string which includes newlines.
4230 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4231 is covered by a display string with embedded newlines.
4232
a3de0cbd
MA
42332011-09-24 Michael Albinus <michael.albinus@gmx.de>
4234
4235 * dbusbind.c (Fdbus_register_signal): Add match rule to
4236 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4237 (Fdbus_register_method, Vdbus_registered_objects_table):
4238 Fix docstring.
a3de0cbd 4239
b260039d
JM
42402011-09-24 Jim Meyering <meyering@redhat.com>
4241
32c1fffd 4242 do not ignore write error for any output size
b260039d
JM
4243 The previous change was incomplete.
4244 While it makes emacs --batch detect the vast majority of stdout
4245 write failures, errors were still ignored whenever the output size is
4246 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4247 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4248 && echo FAIL: ignored write error
4249 FAIL: ignored write error
4250 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4251 && echo FAIL: ignored write error
4252 FAIL: ignored write error
4253 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4254
8eca8a7c
AS
42552011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4256
4257 * emacs.c (Fkill_emacs): In noninteractive mode exit
4258 non-successfully if a write error occurred on stdout. (Bug#9574)
4259
3341db62
EZ
42602011-09-21 Eli Zaretskii <eliz@gnu.org>
4261
4262 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4263 the xassert test.
4264
4265 * dispextern.h (struct it): Update the comment documenting what
4266 can it->OBJECT be.
4267
8c203dbf
EZ
42682011-09-20 Eli Zaretskii <eliz@gnu.org>
4269
4270 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4271 a display string, extend search for cursor position to end of row.
4272 (find_row_edges): If the row ends in a newline from a display
4273 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4274 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4275 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4276 non-empty line. Fixes confusing cursor motion with arrow keys at
4277 the beginning of a line that starts with whitespace.
8c203dbf 4278
a4824228
LMI
42792011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4280
4281 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4282 (bug#9493).
4283
33ed493b
CY
42842011-09-18 Chong Yidong <cyd@stupidchicken.com>
4285
4286 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4287 boolean (Bug#9154).
4288
56cd55c8
EZ
42892011-09-18 Eli Zaretskii <eliz@gnu.org>
4290
4291 * xdisp.c (display_line): Record maximum and minimum buffer
4292 positions even if no glyphs were produced (e.g., by a zero-width
4293 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4294 buffer positions that will be removed from the glyph row because
4295 they don't fit.
c02dcedf
EZ
4296 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4297 column is beyond frame width: don't subtract 1 "pixel" when
4298 computing width of the stretch.
3e62b7e0
EZ
4299 (reseat_at_next_visible_line_start): Undo the change made on
4300 2011-09-17 that saved paragraph information and restored it after
4301 the call to `reseat'. (Bug#9545)
56cd55c8 4302
5ed99d36 43032011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4304
4305 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4306 and turn window cursor on if cleared (Bug#9415).
4307
5ed99d36 43082011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4309
4310 * search.c (boyer_moore): Take unibyte characters from pattern
4311 literally. (Bug#9458)
4312
9bade7b2
EZ
43132011-09-18 Eli Zaretskii <eliz@gnu.org>
4314
4315 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4316
e5e9d610
PE
43172011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4318
87e4427a
PE
4319 Fix minor problem found by static checking.
4320 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4321 initialized, to pacify gcc -Wuninitialized.
4322
e5e9d610
PE
4323 * fileio.c: Report proper errno when syscall falls.
4324 (Finsert_file_contents): Save and restore errno,
4325 so that report_file_error outputs the correct diagnostic.
4326 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4327
a1674f0b
EZ
43282011-09-18 Eli Zaretskii <eliz@gnu.org>
4329
4330 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4331
fbfb6dd4
EZ
43322011-09-17 Eli Zaretskii <eliz@gnu.org>
4333
4334 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4335 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4336
bb187662
EZ
43372011-09-17 Eli Zaretskii <eliz@gnu.org>
4338
1137e8b8 4339 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4340 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4341
4342 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4343 (bidi_find_paragraph_start): Search back for paragraph beginning
4344 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4345 (bidi_move_to_visually_next): Only trigger paragraph-related
4346 computations when the last character is a newline or at EOB, not
4347 just any NEUTRAL_B. (Bug#9470)
4348
bb187662
EZ
4349 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4350 truncated lines if point is covered by a display string. (Bug#9524)
4351
2e621251
PE
43522011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4353
4354 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4355 (cons_to_x_long): New function.
4356 (lisp_data_to_selection_data): Use it. Correct the test for
4357 short-versus-long data; it was negated. Break out of vector
4358 loop, for efficiency, when a long datum is discovered.
4359
91a15bc6
SM
43602011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4361
4362 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4363
b41c3a35
EZ
43642011-09-16 Eli Zaretskii <eliz@gnu.org>
4365
4366 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4367 GCC PR/17406) by declaring this function with external scope.
4368
7812ba2d
PE
43692011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4370
4371 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4372 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4373
cf7edc2a
AS
43742011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4375
4376 * editfns.c (Fformat): Correctly handle text properties on "%%".
4377
bd01620e
EZ
43782011-09-15 Eli Zaretskii <eliz@gnu.org>
4379
4380 * xterm.c (x_draw_composite_glyph_string_foreground):
4381 * w32term.c (x_draw_composite_glyph_string_foreground):
4382 * term.c (encode_terminal_code):
4383 * composite.c (composition_update_it, get_composition_id):
4384 * xdisp.c (get_next_display_element)
4385 (fill_composite_glyph_string): Add comments about special meaning
4386 of TAB characters in a composition.
4387
a02719a3
PE
43882011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4389
4390 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4391 This occurs when processing a multibyte format.
4392 Problem reported by Wolfgang Jenker.
a02719a3 4393
72589a3c
JB
43942011-09-15 Johan Bockgård <bojohan@gnu.org>
4395
4396 * xdisp.c (try_cursor_movement): Only check for exact match if
4397 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4398
1c14176c
PE
43992011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4400
4401 Remove unused external symbols.
4402 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4403 * xdisp.c (calc_pixel_width_or_height): Now static.
4404 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4405 * indent.c (check_display_width):
4406 * w32term.c: Fix comment to match code.
4407 * xterm.c, xterm.h (x_catching_errors): Remove.
4408
d2eea5b5
PE
44092011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4410
4411 * xselect.c: Use signed conversions more consistently (Bug#9498).
4412 (selection_data_to_lisp_data): Assume incoming selection data are
4413 signed integers, not unsigned. This is to be consistent with
4414 outgoing selection data, which was modified to use signed integers
4415 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4416 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4417 expects long, not unsigned long.
4418
46888499
EZ
44192011-09-14 Eli Zaretskii <eliz@gnu.org>
4420
4421 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4422 computation of loop end. Reported by Johan Bockgård
4423 <bojohan@gnu.org>.
4424
ef8ef9fb
CY
44252011-09-13 Chong Yidong <cyd@stupidchicken.com>
4426
4427 * frame.c (Fother_visible_frames_p): Function deleted.
4428
fa819fed
EZ
44292011-09-12 Eli Zaretskii <eliz@gnu.org>
4430
4431 * indent.c (compute_motion): Process display vector front to back
4432 rather than the other way around. (Bug#2496)
4433
2ba8e008
SM
44342011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4435
4436 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4437
20f53c69
CY
44382011-09-11 Chong Yidong <cyd@stupidchicken.com>
4439
4440 * minibuf.c (Fread_from_minibuffer): Doc fix.
4441
d562d7a4
EZ
44422011-09-11 Eli Zaretskii <eliz@gnu.org>
4443
4444 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4445 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4446
1c4d7f3d
LMI
44472011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4448
4449 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4450 value for non-existent files.
4451
b885bf36
EZ
44522011-09-11 Eli Zaretskii <eliz@gnu.org>
4453
4454 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4455 set its "size" to -1. This will set the modtime_size field of
4456 the corresponding buffer to -1, which is what
4457 verify-visited-file-modtime expects for files that do not exist.
4458 (Bug#9139)
4459
6612f0bf
PE
44602011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4461
4462 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4463 here ...
4464 * lisp.h: ... from here. push_key_description is no longer
4465 defined in keyboard.c, so its declaration should not be in
4466 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4467 logically belongs with push_key_description.
4468
dfb3f755
PE
44692011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4470
4471 * buffer.h: Include <sys/types.h> instead of <time.h>.
4472 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4473 Problem reported by Herbert J. Skuhra.
4474
3134906c
LMI
44752011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4476
4477 * xml.c (parse_region): Make the parsing work for
4478 non-comment-starting XML files again (bug#9144).
4479
8d903f4e
AS
44802011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4481
4482 * image.c (gif_load): Fix calculation of bottom and right corner.
4483 (Bug#9468)
4484
80ad64f4
EZ
44852011-09-10 Eli Zaretskii <eliz@gnu.org>
4486
4487 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4488 redisplay in small windows.
4489
208a048d
EZ
44902011-09-09 Eli Zaretskii <eliz@gnu.org>
4491
4492 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4493
9b1c252e
MR
44942011-09-08 Martin Rudalics <rudalics@gmx.at>
4495
4496 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4497 Operate on live windows only.
4498
2949f33b
JB
44992011-09-08 Juanma Barranquero <lekktu@gmail.com>
4500
4501 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4502
e08dcafd
EZ
45032011-09-07 Eli Zaretskii <eliz@gnu.org>
4504
4505 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4506 only under bidi iteration.
4507
115b96bd
JD
45082011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4509
4510 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4511
c8199d0f
PE
45122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4513
4514 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4515 Without this fix, the command to link temacs failed due to an
4516 undefined symbol __builtin_isnan. This is because
4517 /usr/include/iso/math_c99.h #defines isnan(x) to
4518 __builtin_isnan(x), but the bundled gcc, which identifies itself
4519 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4520 a __builtin_isnan.
4521 * floatfns.c (isnan): #undef, and then #define to a clone of
4522 what's in data.c.
4523 (Fisnan): Always define, since it's always available now.
4524 (syms_of_floatfns): Always define isnan at the Lisp level.
4525
e39b275c 45262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4527
4528 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4529
b2db44d9 45302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4531
f4af5137 4532 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4533 The previous code assumed that file offsets (off_t values) fit in
4534 EMACS_INT variables, which is not true on typical 32-bit hosts.
4535 The code messed up by falsely reporting buffer overflow in cases
4536 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4537 when "big" contains more than 2**29 bytes, even though this
4538 inserts just one byte and does not overflow the buffer.
4539 (Finsert_file_contents): Store file offsets as off_t
4540 values, not as EMACS_INT values. Check for overflow when
4541 converting between EMACS_INT and off_t. When checking for
4542 buffer overflow or for overlap, take the offsets into account.
4543 Don't use EMACS_INT for small values where int suffices.
4544 When checking for overlap, fix a typo: ZV was used where
4545 ZV_BYTE was intended.
4546 (Fwrite_region): Don't assume off_t fits into 'long'.
4547 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4548
ecfc0a49
MA
45492011-09-05 Michael Albinus <michael.albinus@gmx.de>
4550
4551 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4552
6511acf2 45532011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4554
0999621a 4555 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4556
4557 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4558 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4559 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4560 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4561 (modify_event_symbol): Do not assume that the length of
4562 name_alist_or_stem is safe to alloca and fits in int.
4563 (Fexecute_extended_command): Likewise for function name and binding.
4564 (Frecursion_depth): Wrap around reliably on integer overflow.
4565 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4566 since some callers pass EMACS_INT values.
4567 (Fsingle_key_description): Don't crash if symbol name contains more
4568 than MAX_ALLOCA bytes.
4569 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4570 (get_minibuffer): Arg is now EMACS_INT, not int.
4571 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4572 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4573 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4574
2be7d702
PE
4575 * dbusbind.c (signature_cat): New function.
4576 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4577 Do not overrun buffer; instead, report string overflow.
4578
9d1df220
PE
4579 * dispnew.c (add_window_display_history): Don't overrun buffer.
4580 Truncate instead; this is OK since it's just a log.
4581
33ef5c64
PE
4582 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4583 even if the time zone offset is outlandishly large.
4584 Don't mishandle offset == INT_MIN.
4585
66c6fdd5
PE
4586 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4587 when creating daemon; the previous buffer-overflow check was incorrect.
4588
d749b01b
PE
4589 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4590 which has the guts of the old verror function.
4591
b5cd1905
PE
4592 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4593 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4594
6e1a67fb
PE
4595 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4596 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4597 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4598 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4599 length of string rather than counting it via multiple sprintfs;
4600 that's simpler and more reliable.
c21721cc
PE
4601 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4602 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4603 sprintf, in case result does not fit in int.
4604
c57b67fc
PE
4605 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4606 (fontset_from_font): Print it.
4607
8a401434
PE
4608 * frame.c (tty_frame_count): Now printmax_t, not int.
4609 (make_terminal_frame, set_term_frame_name): Print it.
4610 (x_report_frame_params): In X, window IDs are unsigned long,
4611 not signed long, so print them as unsigned.
4612 (validate_x_resource_name): Check for implausibly long names,
4613 and don't assume name length fits in 'int'.
4614 (x_get_resource_string): Don't blindly alloca invocation name;
4615 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4616 not fit in int.
4617
6e1a67fb
PE
4618 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4619 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4620 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4621
0df02bf3
PE
4622 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4623 Use esprintf, not sprintf, in case result does not fit in int.
4624
48e30793
PE
4625 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4626 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4627 it as a large positive number.
4628 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4629 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4630
a66ff6d8
PE
4631 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4632 in case result does not fit in int.
4633
aca216ff
PE
4634 * print.c (float_to_string): Detect width overflow more reliably.
4635 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4636 buffer overrun. Don't assume list length fits in 'int'. Treat
4637 print length of 0 as 0, not as infinity; to be consistent with other
4638 uses of print length in this function. Don't overflow print length
4639 index. Don't assume hash table size fits in 'long', or that
4640 vectorlike size fits in 'unsigned long'.
4641
31c286f7
PE
4642 * process.c (make_process): Use printmax_t, not int, to format
4643 process-name gensyms.
4644
55e5faa1
PE
4645 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4646
80f2e268
PE
4647 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4648 to avoid potential buffer overrun.
4649
670741ab
PE
4650 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4651 if X resource line is longer than 512 bytes.
4652
b7163a50
PE
4653 * xfns.c (x_window): Make sprintf buffer a bit bigger
4654 to avoid potential buffer overrun.
4655
ae58ff1f
PE
4656 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4657
c43c8a6a
PE
4658 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4659
3f8236f4
PE
46602011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4661
53e9fe90 4662 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4663 Without these, Emacs silently mishandles large integers sometimes.
4664 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4665 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4666
6511acf2
PE
4667 * xdisp.c (try_window_id): Check Emacs fixnum range before
4668 converting to 'int'.
806add1d 4669
6511acf2 4670 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4671 Check that an Emacs fixnum is in range before assigning it to 'int'.
4672 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4673 values converted from Emacs fixnums.
4674 (Frecenter): Don't wrap around a line count if it is out of 'int'
4675 range; instead, treat it as an extreme value.
4676 (Fset_window_configuration, compare_window_configurations):
4677 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4678
6511acf2
PE
4679 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4680 that can exceed INT_MAX. Check that EMACS_INT value is in range
4681 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4682 (match_limit): Don't assume that a fixnum can fit in 'int'.
4683
6511acf2 4684 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4685 exceed INT_MAX.
4686
6511acf2 4687 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4688 (Fvertical_motion): Don't wrap around LINES values that don't fit
4689 in 'int'. Instead, treat them as extreme values. This is good
4690 enough for windows, which can't have more than INT_MAX lines anyway.
4691
fcb901a7
LMI
46922011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4693
0f2f6b6d
LMI
4694 * Require libxml/parser.h to avoid compilation warning.
4695
fcb901a7
LMI
4696 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4697
4698 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4699 since this reportedly can destroy thread storage.
4700
6e20a0d4
CY
47012011-08-30 Chong Yidong <cyd@stupidchicken.com>
4702
4703 * syntax.c (find_defun_start): Update all cache variables if
4704 exiting early (Bug#9401).
4705
148ae00e
EZ
47062011-08-30 Eli Zaretskii <eliz@gnu.org>
4707
f6cfbd8f
EZ
4708 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4709
148ae00e
EZ
4710 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4711 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4712 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4713
4714 * term.c (tty_append_glyph): New function.
4715 (produce_stretch_glyph): Static function and its prototype deleted.
4716
a66cfb1c
SM
4717 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4718 Add prototypes.
148ae00e 4719
c4a07a4c
PE
47202011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4721
4722 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4723 when checking :margin (Bug#9390).
4724 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4725 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4726 so that the name doesn't mislead. All uses changed.
4727
6bc8cd65
JB
47282011-08-28 Johan Bockgård <bojohan@gnu.org>
4729
4730 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4731 set_tty_hooks.
4732
dca4927e
EZ
47332011-08-27 Eli Zaretskii <eliz@gnu.org>
4734
4735 * xdisp.c (move_it_to): Don't bail out early when reaching
4736 position beyond to_charpos, if we are scanning backwards.
4737 (move_it_vertically_backward): When DY == 0, make sure we get to
4738 the first character in the line after the newline.
4739
f2cad773
PE
47402011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4741
4742 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4743 (ccl_driver): Do not generate an out-of-range pointer.
4744 (Fccl_execute_on_string): Remove unnecessary check for
4745 integer overflow, noted by Stefan Monnier in
4746 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4747 Remove a FIXME that didn't need fixing.
4748 Simplify the newly-introduced buffer reallocation code.
4749
0cae2cdb
JB
47502011-08-27 Juanma Barranquero <lekktu@gmail.com>
4751
4752 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4753
5fc295a4 47542011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4755
70c60eb2 4756 Integer and memory overflow issues (Bug#9196).
726e0ab1 4757
d31850da
PE
4758 * doc.c (get_doc_string): Rework so that
4759 get_doc_string_buffer_size is the actual buffer size, rather than
4760 being 1 less than the actual buffer size; this makes xpalloc more
4761 convenient.
4762
a69fbedb
PE
4763 * image.c (x_allocate_bitmap_record, cache_image):
4764 * xselect.c (Fx_register_dnd_atom):
4765 Simplify previous changes by using xpalloc.
4766
fe5c5d37
PE
4767 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4768 since either will do and ptrdiff_t is convenient with xpalloc.
4769
0065d054
PE
4770 * charset.c (charset_table_size)
4771 (struct charset_sort_data.priority): Now ptrdiff_t.
4772 (charset_compare): Don't overflow if priorities differ greatly.
4773 (Fsort_charsets): Don't assume list length fits in int.
4774 Check for size-calculation overflow when allocating sort data.
4775 (syms_of_charset): Allocate an initial charset table that is
4776 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4777
4778 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4779
4780 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4781 The actual value is always <= INT_MAX, and leaving it unsigned made
4782 overflow checking harder.
4783
4784 * dispextern.h (struct glyph_matrix.rows_allocated)
4785 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4786 with xpalloc. The values are still always <= INT_MAX.
4787
4788 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4789
4790 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4791 (SAFE_NALLOCA): New macro.
4792
4793 * region-cache.c (struct boundary.pos, find_cache_boundary)
4794 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4795 (set_cache_region, invalidate_region_cache)
4796 (revalidate_region_cache, know_region_cache, region_cache_forward)
4797 (region_cache_backward, pp_cache):
4798 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4799 so that ptrdiff_t * can be passed to xpalloc.
4800 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4801 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4802 (pp_cache): Don't assume cache_len fits in int.
4803 * region-cache.h: Adjust extern decls to match.
4804
4805 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4806 EMACS_INT, since either will do, for xpalloc.
4807
4808 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4809 (xnmalloc, xnrealloc, xpalloc): New functions.
4810
726e0ab1
PE
4811 * bidi.c (bidi_shelve_header_size): New constant.
4812 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4813 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4814
51f30bc5 4815 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4816 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4817 (overlay_strings):
4818 Don't update size of array until after memory allocation succeeds,
4819 because xmalloc/xrealloc may not return.
0065d054
PE
4820 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4821 now that we have proper integer overflow checking.
4822 (record_overlay_string, overlay_strings): Catch overflows when
4823 calculating size of overlay_str_buf.
726e0ab1 4824
0065d054
PE
4825 * callproc.c (Fcall_process): Check for size overflow when
4826 calculating size of args2.
4827 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4828 Normally we prefer signed values, but sticking with ptrdiff_t would
4829 require adding more-complicated checks.
726e0ab1
PE
4830
4831 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4832 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4833 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4834 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4835
4836 * character.c (Fstring): Check for size-calculation overflow.
4837
4838 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4839 unnecessary integer overflow. Check for size overflow.
4840 (encode_coding_object): Don't update size until xmalloc succeeds.
4841
4842 * composite.c (get_composition_id): Check for overflow in glyph
4843 length calculations.
4844
4845 Integer and memory overflow fixes for display code.
4846 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4847 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4848 (scrolling_window): Check for overflow in size calculations.
4849 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4850 Don't assume glyph table len fits in int.
4851 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4852 (row_table_size): Now ptrdiff_t, not int.
4853 (scrolling_window): Avoid overflow in size calculations.
4854 Don't update size until allocation succeeds.
4855 * fns.c (concat): Check for overflow in size calculations.
4856 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4857 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4858 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4859
4860 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4861 (get_doc_string): Check for size calculation overflow.
4862 Don't update size until allocation succeeds.
4863 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4864 EMACS_INT, where ptrdiff_t will do.
4865 (Fsubstitute_command_keys): Check for string overflow.
4866
4867 * editfns.c (set_time_zone_rule): Don't assume environment length
4868 fits in int.
4869 (message_length): Now ptrdiff_t, not int.
4870 (Fmessage_box): Don't update size until allocation succeeds.
4871 Don't assume message length fits in int.
4872 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4873
0065d054
PE
4874 * emacs.c (main): Do not reallocate argv, since there is a null at
4875 the end that can be overwritten, and this way there's no need to
4876 worry about size-calculation overflow.
4877 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4878
4879 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4880 alloc succeeds.
4881 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4882
4883 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4884 (x_set_scroll_bar_width, x_figure_window_size):
4885 Check for integer overflow.
4886 (x_set_alpha): Do not assume XINT fits in int.
4887
4888 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4889 This is for the members text_lines, text_cols, total_lines, total_cols,
4890 where the system imposes an 'int' limit.
4891
4892 * fringe.c (Fdefine_fringe_bitmap):
4893 Don't update size until alloc works.
4894
4895 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4896 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4897
4898 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4899 Check for size-calculation overflow.
4900 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4901 do, as we prefer signed integers.
4902 (id_to_widget.max_size, id_to_widget.used)
4903 (xg_store_widget_in_map, xg_remove_widget_from_map)
4904 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4905 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4906 Use and return ptrdiff_t, not int.
4907 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4908 * gtkutil.h: Change prototypes to match the above.
4909
4910 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4911 are duplicate now that they've been promoted to lisp.h.
4912 (x_allocate_bitmap_record, x_alloc_image_color)
4913 (make_image_cache, cache_image, xpm_load):
4914 Don't update size until alloc is done.
4915 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4916 (x_detect_edges):
3256efce 4917 Check for size calculation overflow.
726e0ab1
PE
4918 (ct_colors_allocated_max): New constant.
4919 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4920 overflow.
3256efce 4921
726e0ab1
PE
4922 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4923 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4924 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4925 Use ptrdiff_t, not int, to count maps.
4926 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4927 calculations. Don't update size until allocation succeeds.
4928 Redo calculations to avoid overflow.
726e0ab1
PE
4929 * keyboard.h: Change prototypes to match the above.
4930
4931 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4932 to count maps.
4933 (current_minor_maps): Check for size calculation overflow.
4934 * keymap.h: Change prototypes to match the above.
4935
4936 * lread.c (read1, init_obarray): Don't update size until alloc done.
4937
4938 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4939 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4940
726e0ab1
PE
4941 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4942 Now ptrdiff_t, not int.
4943 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4944 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4945
4946 * process.c (Fnetwork_interface_list): Check for overflow
4947 in size calculation.
4948
4949 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4950
4951 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4952 overflow. Don't bother calling xmalloc when xrealloc will do.
4953
4954 * search.c (Freplace_match): Check for size calculation overflow.
4955 (Fset_match_data): Don't assume list lengths fit in 'int'.
4956
4957 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4958 for command line length. Do not attempt to address one before the
4959 beginning of an array, as that's not portable.
4960
4961 * term.c (max_frame_lines): Remove; unused.
4962 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4963 not int.
4964 (encode_terminal_code, calculate_costs): Check for size
4965 calculation overflow.
4966 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4967 table lengths and related sizes. Don't update size until alloc
4968 done. Redo calculations to avoid overflow.
4969 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4970
4971 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4972 subtracting pointers.
4973 (gobble_line): Check for overflow more carefully. Don't update size
4974 until alloc done.
4975
4976 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4977 Don't update size until alloc done.
4978 Redo size calculations to avoid overflow.
4979 Check for size calculation overflow.
0065d054 4980 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4981
4982 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4983 Use ptrdiff_t, not int, for sizes.
4984 (store_mode_line_noprop_char): Don't update size until alloc done.
4985
0065d054
PE
4986 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4987 Use ptrdiff_t, not int, for sizes.
4988 (Finternal_make_lisp_face, cache_face):
4989 Check for size calculation overflow.
4990 (cache_face): Treat size calculation overflows as if they were
4991 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4992
4993 * xfns.c (x_encode_text, x_set_name_internal)
4994 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4995 sizes, since they can exceed INT_MAX in size. Check for size
4996 calculation overflow.
4997
0065d054
PE
4998 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4999 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5000 Don't update size until alloc done.
5001
0065d054 5002 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5003 as sprintf is limited to int lengths.
1d526e2f 5004
252c5ee1
PE
5005 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5006 (X_LONG_MIN): New macros.
864d7ce7
PE
5007 Use them to make the following changes clearer.
5008 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5009 This change doesn't affect the value now, but it may help remind
5010 future maintainers not to raise the value too much later.
5011 (SELECTION_QUANTUM): Remove, replacing with ...
5012 (selection_quantum): ... new function, which avoids overflow.
5013 All uses changed.
5014 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5015 assumption that selection length fits in 'int'.
5016 (x_reply_selection_request, x_handle_selection_request)
5017 (x_get_window_property, receive_incremental_selection)
5018 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5019 (lisp_data_to_selection_data, clean_local_selection_data):
5020 Use ptrdiff_t, not int, to record length of selection.
5021 (x_reply_selection_request, x_get_window_property)
5022 (receive_incremental_selection, x_property_data_to_lisp):
5023 Redo calculations to avoid overflow.
5024 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5025 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5026 something.
5027 (x_get_window_property, receive_incremental_selection)
5028 (lisp_data_to_selection_data, x_property_data_to_lisp):
5029 Check for size-calculation overflow.
5030 (x_get_window_property, receive_incremental_selection)
5031 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5032 Don't store size until memory allocation succeeds.
5033 (x_get_window_property): Plug memory leak on memory exhaustion.
5034 Don't double-block input; malloc is safe here. Don't assume 2**34
5035 - 4 fits in unsigned long. Add an xassert to check
5036 XGetWindowProperty overflow. Be more careful about overflow
5037 calculations, and distinguish size from memory overflow better.
5038 (receive_incremental_selection): When tracing, don't assume
5039 unsigned int is less than INT_MAX.
5040 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5041 harmful) conversions of unsigned short to int.
5042 (lisp_data_to_selection_data): Don't assume that integers
5043 in the range -65535 through -1 fit in an X unsigned short.
5044 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5045 result parameters unless successful. Rely on cons_to_unsigned
5046 to report problems with elements; the old code wasn't right anyway.
5047 (x_check_property_data): Check for int overflow; we cannot use
5048 a wider type due to X limits.
5049 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5050
726e0ab1 5051 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5052
0065d054
PE
5053 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5054 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5055 (x_color_cells): Don't store size until memory allocation succeeds.
5056 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5057 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5058 (x_term_init): Don't assume length fits in int (sprintf is limited
5059 to int size).
bc18e09d 5060
ebfa62c0
PE
5061 Use ptrdiff_t for composition IDs.
5062 * character.c (lisp_string_width):
5063 * composite.c (composition_table_size, n_compositions)
5064 (get_composition_id, composition_gstring_from_id):
5065 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5066 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5067 * window.c (Frecenter):
5068 Use ptrdiff_t, not int, for composition IDs.
5069 * composite.c (get_composition_id): Check for integer overflow.
5070 * composite.h: Adjust prototypes to match the above changes.
5071
d3411f89
PE
5072 Use ptrdiff_t for hash table indexes.
5073 * category.c (hash_get_category_set):
5074 * ccl.c (ccl_driver):
5075 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5076 * coding.c (coding_system_charset_list, detect_coding_system):
5077 * coding.h (struct coding_system.id):
5078 * composite.c (get_composition_id, gstring_lookup_cache):
5079 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5080 * image.c (xpm_get_color_table_h):
5081 * lisp.h (hash_lookup, hash_put):
5082 * minibuf.c (Ftest_completion):
5083 Use ptrdiff_t for hash table indexes, not int (which is too
5084 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5085 32-bit --with-wide-int hosts).
5086
e097a6fa
PE
5087 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5088 Add a FIXME comment about memory leaks.
5089 (syms_of_charset): Don't assume xmalloc returns.
5090
5637687f
PE
5091 Don't assume that stated character widths fit in int.
5092 * character.c (Fchar_width, c_string_width, lisp_string_width):
5093 * character.h (CHAR_WIDTH):
5094 * indent.c (MULTIBYTE_BYTES_WIDTH):
5095 Use sanitize_char_width to avoid undefined and/or bad behavior
5096 with outlandish widths.
a66cfb1c 5097 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5098 now that we have two such functions. All uses changed.
5099 (sanitize_char_width): New inline function.
5100
a2271ba2
PE
5101 Don't assume that tab-width fits in int.
5102 * character.h (sanitize_width): New inline function.
5103 (SANE_TAB_WIDTH): New macro.
5104 (ASCII_CHAR_WIDTH): Use it.
5105 * indent.c (sane_tab_width): Remove. All uses replaced by
5106 SANE_TAB_WIDTH (current_buffer).
5107 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5108
18c52557
PE
5109 * fileio.c: Integer overflow issues with file modes.
5110 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5111
caeeedc1
PE
5112 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5113 Remove unreachable code.
5114 (read_hex, load_charset_map_from_file): Check for integer overflow.
5115
6df6ae42 5116 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5117 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5118 (x_send_scroll_bar_event): Likewise. Check that the size does not
5119 exceed limits imposed by XClientMessageEvent, as well as the usual
5120 ptrdiff_t and size_t limits.
5121
b13995db
PE
5122 * keyboard.c: Overflow, signedness and related fixes.
5123 (make_lispy_movement): Use same integer type in forward decl
5124 that is used in the definition.
5125 (read_key_sequence, keyremap_step):
5126 Change bufsize argument back to int, undoing my 2011-03-30 change.
5127 We prefer signed types, and int is wide enough here.
5128 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5129 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5130 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5131 length, not size_t. Use ptrdiff_t for index, not int.
5132 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5133 possibility of integer overflow.
5134
13464394
PE
5135 Overflow, signedness and related fixes for images.
5136
5137 * dispextern.h (struct it.stack[0].u.image.image_id)
5138 (struct_it.image_id, struct image.id, struct image_cache.size)
5139 (struct image_cache.used, struct image_cache.ref_count):
5140 * gtkutil.c (update_frame_tool_bar):
5141 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5142 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5143 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5144 * nsmenu.m (update_frame_tool_bar):
5145 * xdisp.c (calc_pixel_width_or_height):
5146 * xfns.c (image_cache_refcount):
5147 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5148 on typical 64-bit hosts.
5149
5150 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5151 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5152 Omit unnecessary casts to int.
5153 (parse_image_spec): Check that integers fall into 'int' range
5154 when the callers expect that.
5155 (image_ascent): Redo ascent calculation to avoid int overflow.
5156 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5157 (lookup_image): Remove unnecessary tests.
5158 (xbm_image_p): Locals are now of int, not EMACS_INT,
5159 since parse_image_check makes sure they fit into int.
5160 (png_load, gif_load, svg_load_image):
5161 Prefer int to unsigned where either will do.
5162 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5163 old tiff_error_handler and tiff_warning_handler.
5164 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5165 stack buffer overflows. It uses only the features of vsnprintf
5166 that are common to both POSIX and native Microsoft.
5167 (tiff_error_handler, tiff_warning_handler): Use it.
5168 (tiff_load, gif_load, imagemagick_load_image):
5169 Don't assume :index value fits in 'int'.
5170 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5171 (imagemagick_load_image): Check that crop parameters fit into
5172 the integer types that MagickCropImage accepts. Don't assume
5173 Vimagemagick_render_type has a nonnegative value. Don't assume
5174 size_t fits in 'long'.
5175 (gs_load): Use printmax_t to print the widest integers possible.
5176 Check for integer overflow when computing image height and width.
5177
c11821d4
EZ
51782011-08-26 Eli Zaretskii <eliz@gnu.org>
5179
5180 * xdisp.c (redisplay_window): Don't force window start if point
5181 will be invisible in the resulting window. (Bug#9324)
5182
0c95fcf7
EZ
51832011-08-25 Eli Zaretskii <eliz@gnu.org>
5184
5185 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5186 the display spec is of the form `(space ...)'.
5187 (handle_display_spec): Return the value returned by
5188 handle_single_display_spec, not just 1 or zero.
5189 (handle_single_display_spec): If the display spec is of the form
5190 `(space ...)', and specifies display in the text area, return 2
5191 rather than 1.
fee65a97 5192 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5193 accurately, and prefer exact match for point under bidi.
5194 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5195
5196 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5197 into disp_prop; all users changed.
5198
5199 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5200 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5201 for the text covered by the display property.
5202
e4ed06f1
CY
52032011-08-25 Chong Yidong <cyd@stupidchicken.com>
5204
5205 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5206 Change return value to nil.
5207 (Frecord_buffer): Delete unused function.
5208
f67cdd7f
EZ
52092011-08-24 Eli Zaretskii <eliz@gnu.org>
5210
5980d4c6
EZ
5211 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5212 buffers, return left-to-right.
8610fe8b
EZ
5213 (set_cursor_from_row): Consider candidate row a win if its glyph
5214 represents a newline and point is on that newline. Fixes cursor
5215 positioning on the newline at EOL of R2L text within L2R
5216 paragraph, and vice versa.
5217 (try_cursor_movement): Check continued rows, in addition to
5218 continuation rows. Fixes unwarranted scroll when point enters a
5219 continued line of R2L text within an L2R paragraph, or vice versa.
5220 (cursor_row_p): Consider the case of point being equal to
5221 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5222 from the end of a short line to the beginning of a continued line
5223 of R2L text within L2R paragraph.
5224 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5225 composed characters.
5980d4c6 5226
f67cdd7f
EZ
5227 * bidi.c (bidi_check_type): Use xassert.
5228 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5229 members.
5230
bca633fb
EZ
52312011-08-23 Eli Zaretskii <eliz@gnu.org>
5232
5233 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5234 a character.
5235
4a5885a7
CY
52362011-08-23 Chong Yidong <cyd@stupidchicken.com>
5237
5238 * nsfont.m (ns_otf_to_script): Fix typo.
5239
0902a04e
KH
52402011-08-22 Kenichi Handa <handa@m17n.org>
5241
5242 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5243 extra slot even if the purpose is char-code-property-table.
5244
1a2e6670
EZ
52452011-08-23 Eli Zaretskii <eliz@gnu.org>
5246
8ddde651
EZ
5247 * xdisp.c (redisplay_window): When computing centering_position,
5248 account for the height of the header line. (Bug#8874)
5249
425cc014
EZ
5250 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5251 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5252 candidate is selected by the mouse, and that candidate has a
5253 composed character under the mouse.
5254
1a2e6670
EZ
5255 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5256 coordinates reported by pos-visible-in-window-p for a composed
5257 character in column zero.
5258
8b76d6f8
SM
52592011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5260
5261 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5262
dac347dd
EZ
52632011-08-22 Eli Zaretskii <eliz@gnu.org>
5264
5265 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5266 consider it a hit if to_charpos is anywhere in the range of the
5267 composed buffer positions.
5268
e013fb34
CY
52692011-08-22 Chong Yidong <cyd@stupidchicken.com>
5270
5271 * image.c (gif_load): Don't assume that each subimage has the same
5272 dimensions as the base image. Handle disposal method that is
5273 "undefined" by the gif spec (Bug#9335).
5274
bd1ba3e8
CY
52752011-08-20 Chong Yidong <cyd@stupidchicken.com>
5276
5277 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5278 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5279
54a1215b
EZ
52802011-08-19 Eli Zaretskii <eliz@gnu.org>
5281
823564e5
EZ
5282 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5283 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5284 from an Org mode buffer to a Speedbar frame.
5285
54a1215b
EZ
5286 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5287 a composition, take its buffer position from IT->cmp_it.charpos.
5288 Fixes cursor positioning at the beginning of a line that begins
5289 with a composed character.
5290
9778ebcc
EZ
52912011-08-18 Eli Zaretskii <eliz@gnu.org>
5292
0be6ee06
EZ
5293 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5294 character bidirectional type, use STRONG_L instead. Fixes crashes
5295 in a buffer produced by `describe-categories'.
5296
9778ebcc
EZ
5297 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5298 members before the level stack, so they would be saved and
5299 restored when copying iterator state. Fixes incorrect reordering
5300 around TABs covered by display properties.
5301
156bffbe
AS
53022011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5303
6b02f655 5304 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5305
72ad093b
CY
53062011-08-17 Chong Yidong <cyd@stupidchicken.com>
5307
5308 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5309 (internal_condition_case_2, internal_condition_case_n):
5310 Remove unnecessary aborts (Bug#9081).
72ad093b 5311
35774242
EZ
53122011-08-17 Eli Zaretskii <eliz@gnu.org>
5313
5314 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5315 has no `load' handler, try opening the file locally. (Bug#9311)
5316
db76dd85
KB
53172011-08-16 Ken Brown <kbrown@cornell.edu>
5318
5319 * gmalloc.c: Expand comment.
5320
b215eee5
EZ
53212011-08-16 Eli Zaretskii <eliz@gnu.org>
5322
5323 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5324 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5325
a4579d33
KB
53262011-08-16 Ken Brown <kbrown@cornell.edu>
5327
5328 Fix memory allocation problems in Cygwin build (Bug#9273).
5329
5330 * unexcw.c ( __malloc_initialized): Declare external variable.
5331 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5332
8b76d6f8
SM
5333 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5334 New variables.
a4579d33
KB
5335 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5336 dumped emacs.
5337 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5338 in the static heap.
5339 [CYGWIN] (special_realloc): New function.
5340 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5341 requests to realloc storage in the static heap.
5342
3ebec551
PE
53432011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5344
5345 * bidi.c (bidi_initialize): Remove unused local.
5346
9fd8be00
EZ
53472011-08-15 Eli Zaretskii <eliz@gnu.org>
5348
6b02f655
SM
5349 * bidimirror.h:
5350 * biditype.h: Remove file.
5351 * makefile.w32-in ($(BLD)/bidi.$(O)):
5352 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5353
5354 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5355
5356 * chartab.c: Improve commentary for the uniprop_table API.
5357
32413314
EZ
5358 * bidi.c (bidi_paragraph_init): Support zero value of
5359 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5360 (bidi_initialize): Use uniprop_table instead of including
5361 biditype.h and bidimirror.h.
32413314 5362
9fd8be00
EZ
5363 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5364 coordinates of the iterator when restoring from ppos_it.
5365 (Bug#9296)
5366
5cf2b69b
KH
53672011-08-14 Kenichi Handa <handa@m17n.org>
5368
5369 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5370 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5371
daf17d00
EZ
53722011-08-14 Eli Zaretskii <eliz@gnu.org>
5373
5374 * xdisp.c (move_it_in_display_line_to): Don't invoke
5375 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5376 ppos_it. Fixes vertical cursor motion when line beginning is
5377 covered by an image. (Bug#9296)
5378
08e3161a
JD
53792011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5380
5381 * nsterm.h (ns_run_ascript): Declare.
5382 (NSAPP_DATA2_RUNASSCRIPT): Define.
5383
5384 * nsfns.m (as_script, as_result, as_status): New static variables.
5385 (ns_run_ascript): New function.
5e617bc2 5386 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5387 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5388 the event loop. Get status from as_status (Bug#7276).
5389
5390 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5391 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5392 the event loop (Bug#7276).
5393
a3720aa2
AS
53942011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5395
5396 * gnutls.c (QCgnutls_bootprop_priority)
5397 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5398 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5399 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5400 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5401 (QCgnutls_bootprop_verify_hostname_error)
5402 (QCgnutls_bootprop_callbacks_verify): Rename from
5403 Qgnutls_bootprop_..., all uses changed.
5404
5405 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5406 uses changed.
5407
0a0d27fb
PE
54082011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5409
19d5c50c
PE
5410 * xfaces.c (Qframe_set_background_mode): Now static.
5411 * dispextern.h (Qframe_set_background_mode): Remove decl.
5412
0a0d27fb
PE
5413 * process.c (Fnetwork_interface_info): Declare local only if needed.
5414
377538cb
JD
54152011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5416
5417 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5418 (Fnetwork_interface_list): Allocate in increments of bytes instead
5419 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5420 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5421 sockaddr.
5422 (struct ifflag_def): notrailers is smart on OSX.
5423 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5424 Get hardware address with getifaddrs if available.
5425
08fff70c
EZ
54262011-08-12 Eli Zaretskii <eliz@gnu.org>
5427
5428 * xdisp.c (iterate_out_of_display_property): xassert that
5429 IT->position is set to within IT->object's boundaries. Break from
5430 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5431 when IT->position is set up wrongly due to some bug.
5432 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5433 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5434 entry. Force push_it to save on the stack the current
5435 buffer/string position, to be restored by pop_it. Fix flags in
5436 the iterator structure wrt the object coming from a display
5437 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5438 properties. (Bug#9284)
5439
7be1c708 54402011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5441
7be1c708
CY
5442 * fontset.c (fontset_get_font_group): Add proper type checks.
5443 (Bug#9172)
aac0c6e3 5444
7be1c708 54452011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5446
7be1c708
CY
5447 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5448 and LC_VERSION_MIN_MACOSX.
5449 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5450 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5451
97bb72a6
EZ
54522011-08-08 Eli Zaretskii <eliz@gnu.org>
5453
5454 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5455 no-display-properties-and-no-overlays under bidi display.
5456 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5457 properties and overlays.
97bb72a6 5458
d5617611
CY
54592011-08-08 Chong Yidong <cyd@stupidchicken.com>
5460
37e11a63
CY
5461 * editfns.c (Fset_time_zone_rule): Document relationship with the
5462 setenv function.
5463
d5617611
CY
5464 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5465 the font entity extracted from the cache (Bug#8109).
5466
58872834
CY
54672011-08-07 Chong Yidong <cyd@stupidchicken.com>
5468
5469 * composite.c (autocmp_chars): Don't reset point. That is done by
5470 restore_point_unwind (Bug#5984).
5471
75bfc667
JL
54722011-08-07 Juri Linkov <juri@jurta.org>
5473
5474 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5475 to show the arg `TIME' instead of `TIMEVAL'.
5476
d1410150
EZ
54772011-08-06 Eli Zaretskii <eliz@gnu.org>
5478
5479 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5480 display property strides EOL and includes a newline, as in
5481 longlines-mode. (Bug#9254)
75b771e4
EZ
5482 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5483 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5484
5485 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5486 is non-zero, even if the data buffer is NULL. Fixes a crash in
5487 vertical-motion with longlines-mode. (Bug#9254)
5488
35928349
EZ
54892011-08-05 Eli Zaretskii <eliz@gnu.org>
5490
ec7cc85b
EZ
5491 * bidi.c <bidi_cache_total_alloc>: Now static.
5492 (bidi_initialize): Initialize bidi_cache_total_alloc.
5493
8b76d6f8 5494 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5495 cache. (Bug#9221)
5496
5497 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5498 amount allocated this far in `bidi_cache_total_alloc'.
5499 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5500 non-zero, only free the data buffer without restoring the cache
5501 contents. All callers changed.
5502
5503 * dispextern.h (bidi_unshelve_cache): Update prototype.
5504
5505 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5506 (move_it_in_display_line, move_it_to)
5507 (move_it_vertically_backward, move_it_by_lines): Replace the call
5508 to xfree to an equivalent call to bidi_unshelve_cache.
5509 (move_it_in_display_line_to): Fix logic of returning
412b6358 5510 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5511
e2e2423b
EZ
55122011-08-05 Eli Zaretskii <eliz@gnu.org>
5513
5514 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5515 came from a string character with a `cursor' property. (Bug#9229)
5516
ae9e757a
JD
55172011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5518
5519 * Makefile.in (LIB_PTHREAD): New variable.
5520 (LIBES): Add LIB_PTHREAD (Bug#9216).
5521
5522 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5523 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5524
213bd7f2
AS
55252011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5526
6b02f655 5527 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5528
99aaf75f
JD
55292011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5530
5531 * xterm.c (x_find_topmost_parent): New function.
5532 (x_set_frame_alpha): Find topmost parent window with
5533 x_find_topmost_parent and set the property there also (bug#9181).
5534 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5535
c74e9d86
PE
55362011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5537
5538 * callproc.c (Fcall_process): Avoid vfork clobbering
5539 the local vars buffer, coding_systems, current_dir.
5540
640c8776
SM
55412011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5542
5543 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5544
f26d0e4c
PE
55452011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5546
8a10d76c
PE
5547 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5548 so that it is not optimized away.
5549
f26d0e4c
PE
5550 * xdisp.c (compute_display_string_pos): Remove unused local.
5551
55439c61
EZ
55522011-08-02 Eli Zaretskii <eliz@gnu.org>
5553
5554 Fix slow cursor motion and scrolling in large buffers with
5555 selective display, like Org Mode buffers. (Bug#9218)
5556
5557 * dispextern.h (struct bidi_it): New member disp_prop_p.
5558
5559 * xdisp.c: Remove one-slot cache of display string positions.
5560 (compute_display_string_pos): Accept an additional argument
5e617bc2 5561 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5562 for a display string or property. If found, set DISP_PROP_P
5563 non-zero.
5564
5565 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5566 DISP_PROP_P, and pass it to compute_display_string_pos.
5567 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5568 non-zero. All callers of bidi_fetch_char changed.
5569
fb33fa43
SM
55702011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5571
5572 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5573
b099e063
DM
55742010-12-03 Don March <don@ohspite.net>
5575
5576 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5577 last character M-[char] is translated to ESC [char] (bug#7541).
5578
5cc7f7af
KH
55792011-08-02 Kenichi Handa <handa@m17n.org>
5580
d0fffa3f 5581 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5582
5583 * chartab.c (uniprop_table): Make it non-static.
5584
525d5e6e
EZ
55852011-08-01 Eli Zaretskii <eliz@gnu.org>
5586
5587 * xdisp.c (forward_to_next_line_start): Accept additional argument
5588 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5589 on the newline.
5590 (reseat_at_next_visible_line_start): Use the bidi iterator state
5591 returned by forward_to_next_line_start to restore the state of
5592 it->bidi_it after backing up to previous newline. (Bug#9212)
5593
31011111
AS
55942011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5595
5596 * regex.c (re_comp): Protoize.
5597 (re_exec): Fix return type.
5598 (regexec): Fix type of `ret'. (Bug#9203)
5599
476371c4
PE
56002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5601
e5d76069
PE
5602 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5603 This is needed if max-image-size is a floating-point number.
5604
9a79b20c
AS
56052011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5606
5607 * print.c (print_object): Print empty symbol as ##.
5608
5609 * lread.c (read1): Read ## as empty symbol.
5610
d8c2fa78
AA
56112011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5612
5613 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5614 setting frame foreground color (Bug#9175).
5615 (x_set_background_color): Likewise.
5616
ffe57a7a
AA
5617 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5618 contents (Bug#9176).
5619 (EmacsTooltip -init): Remove bezels and add shadows to
5620 tooltip windows.
5621
bf3492a5
AA
5622 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5623 or scroll bar (Bug#8470).
5624
d55e9c53
AA
5625 * nsfont.m (nsfont_open): Remove assignment to voffset and
5626 unnecessary vars hshink, expand, hd, full_height, min_height.
5627 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5628
5629 * nsterm.h (nsfont_info): Remove voffset field.
5630
d8c2fa78 56312011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5632
5633 Implement strike-through and overline on NextStep (Bug#8863).
5634
5635 * nsfont.m (nsfont_open): Use underline position provided by font,
5636 instead of hard-coded value of 2.
5637 (nsfont_draw): Call ns_draw_text_decoration instead.
5638
5639 * nsterm.h: Add declaration for ns_draw_text_decoration.
5640
5641 * nsterm.m (ns_draw_text_decoration): New function for drawing
5642 underline, overline, and strike-through.
5643 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5644 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5645 accommodate underlining, etc.
4843aac3 5646
4cc60b9b
EZ
56472011-07-28 Eli Zaretskii <eliz@gnu.org>
5648
bc7ece87
EZ
5649 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5650 default.
4cc60b9b 5651
476371c4
PE
56522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5653
66606eea
PE
5654 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5655 Without this fix, if a signal arrives just after memory fills up,
5656 'malloc' might be invoked reentrantly.
5657
476371c4
PE
5658 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5659 In other words, assume that every image size is allowed, on non-X
5660 hosts. This assumption is probably wrong, but it lets Emacs compile.
5661
f3fcc40d
AS
56622011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5663
5664 * regex.c (re_iswctype): Convert return values to boolean.
5665
350c992f
EZ
56662011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5667
5668 * xdisp.c (compute_display_string_pos): Don't use cached display
5669 string position if the buffer had its restriction changed.
5670 (Bug#9184)
5671
5266b4bb
PE
56722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5673
5674 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5675
2573a837 56762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5677
41f55ccd 5678 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5679
39e378da
PE
5680 * bidi.c: Integer size and overflow fixes.
5681 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5682 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5683 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5684 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5685 (bidi_find_other_level_edge):
5686 Use ptrdiff_t instead of EMACS_INT where either will do.
5687 This works better on 32-bit hosts configured --with-wide-int.
5688 (bidi_cache_ensure_space): Check for size-calculation overflow.
5689 Use % rather than repeated addition, for better worst-case speed.
5690 Don't set bidi_cache_size until after xrealloc returns, because it
5691 might not return.
5692 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5693 (bidi_cache_ensure_space): Also check that the bidi cache size
5694 does not exceed that of the largest Lisp string or buffer. See Eli
5695 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5696
5e927815
PE
5697 * alloc.c (__malloc_size_t): Remove.
5698 All uses replaced by size_t. See Andreas Schwab's note
5699 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5700
ca4aa935
PE
5701 * image.c: Improve checking for integer overflow.
5702 (check_image_size): Assume that f is nonnull, since
5703 it is always nonnull in practice. This is one less thing to
5704 worry about when checking for integer overflow later.
5705 (x_check_image_size): New function, which checks for integer
5706 overflow issues inside X.
5707 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5708 This removes the need for a memory_full check.
5709 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5710 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5711 (xbm_read_bitmap_data): Change locals back to 'int', since
5712 their values must fit in 'int'.
5713 (xpm_load_image, png_load, tiff_load):
5714 Invoke x_create_x_image_and_pixmap earlier,
5715 to avoid much needless work if the image is too large.
5716 (tiff_load): Treat overly large images as if
5717 x_create_x_image_and_pixmap failed, not as malloc failures.
5718 (gs_load): Use x_check_image_size.
5719
5f8f9cc2
PE
5720 * gtkutil.c: Omit integer casts.
5721 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5722 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5723
5adf60bc
PE
5724 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5725
c8907a93
PE
5726 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5727 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5728 would wrongly return t on a 64-bit host.
5729
e3c25c68
PE
5730 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5731 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5732 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5733 and therefore cause GCC to emit a bogus diagnostic in some cases.
5734
3f791afe
PE
5735 * image.c: Integer signedness and overflow and related fixes.
5736 This is not an exhaustive set of fixes, but it's time to
5737 record what I've got.
5738 (lookup_pixel_color, check_image_size): Remove redundant decls.
5739 (check_image_size): Don't assume that arbitrary EMACS_INT values
5740 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5741 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5742 (tiff_load, imagemagick_load_image):
5743 Check for overflow in size calculations.
5744 (x_create_x_image_and_pixmap): Remove unnecessary test for
5745 xmalloc returning NULL; that can't happen.
5746 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5747 (xpm_color_bucket): Use better integer hashing function.
5748 (xpm_cache_color): Don't possibly over-allocate memory.
5749 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5750 (gif_memory_source):
5751 Use ptrdiff_t, not int or size_t, to record sizes.
5752 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5753 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5754 either works, as we prefer signed integers.
5755 (tiff_read_from_memory, tiff_write_from_memory):
5756 Return tsize_t, not size_t, since that's what the TIFF API wants.
5757 (tiff_read_from_memory): Don't fail simply because the read would
5758 go past EOF; instead, return a short read.
5759 (tiff_load): Omit no-longer-needed casts.
5760 (Fimagemagick_types): Don't assume size fits into 'int'.
5761
3cc5a532
PE
5762 Improve hashing quality when configured --with-wide-int.
5763 * fns.c (hash_string): New function, taken from sxhash_string.
5764 Do not discard information about ASCII character case; this
5765 discarding is no longer needed.
5766 (sxhash-string): Use it. Change sig to match it. Caller changed.
5767 * lisp.h: Declare it.
5768 * lread.c (hash_string): Remove, since we now use fns.c's version.
5769 The fns.c version returns a wider integer if --with-wide-int is
5770 specified, so this should help the quality of the hashing a bit.
5771
b312a492
PE
5772 * emacs.c: Integer overflow minor fix.
5773 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5774 Define only if GNU_LINUX.
5775 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5776
dfd153ae
PE
5777 * dispnew.c: Integer signedness and overflow fixes.
5778 Remove unnecessary forward decls, that were a maintenance hassle.
5779 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5780 All uses changed.
5781 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5782 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5783 (prepare_desired_row, line_draw_cost):
5784 Use int, not unsigned, where either works.
5785 (save_current_matrix, restore_current_matrix):
5786 Use ptrdiff_t, not size_t, where either works.
5787 (init_display): Check for overflow more accurately, and without
5788 relying on undefined behavior.
5789
a81d11a3
PE
5790 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5791 Remove, replacing with the new symbols in lisp.h. All uses changed.
5792 * fileio.c (make_temp_name):
5793 * filelock.c (lock_file_1, lock_file):
5794 * xdisp.c (message_dolog):
5795 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5796 Use pMd etc. instead.
5797 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5798 replacing the pWIDE etc. symbols removed from editfns.c.
5799
3300e6fd
PE
5800 * keyboard.h (num_input_events): Now uintmax_t.
5801 This is (very slightly) less likely to mess up due to wraparound.
5802 All uses changed.
5803
fd05c7e9
PE
5804 * buffer.c: Integer signedness fixes.
5805 (alloc_buffer_text, enlarge_buffer_text):
5806 Use ptrdiff_t rather than size_t when either will do, as we prefer
5807 signed integers.
5808
903fe15d
PE
5809 * alloc.c: Integer signedness and overflow fixes.
5810 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5811 (__malloc_size_t): Default to size_t, not to int.
5812 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5813 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5814 Prefer ptrdiff_t to size_t when either would do, as we prefer
5815 signed integers.
5816 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5817 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5818 Now const. Initialize with values that are in range even if char
5819 is signed.
5820 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5821 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5822 These functions do the right thing with sizes > 2**32.
5823 (check_depth): Now ptrdiff_t, not int.
5824 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5825 Adjust to new way of storing sizes. Check for size overflow bugs
5826 in rest of code.
5827 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5828 slightly wrong anyway, as it missed one instance of
5829 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5830 (refill_memory_reserve): Omit needless cast to size_t.
5831 (mark_object_loop_halt): Mark as externally visible.
5832
ac82cc6a
PE
5833 * xselect.c: Integer signedness and overflow fixes.
5834 (Fx_register_dnd_atom, x_handle_dnd_message):
5835 Use ptrdiff_t, not size_t, since we prefer signed.
5836 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5837 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5838 x_dnd_atoms_size and x_dnd_atoms_length.
5839
c2d1e36d
PE
5840 * doprnt.c: Prefer signed to unsigned when either works.
5841 * eval.c (verror):
5842 * doprnt.c (doprnt):
5843 * lisp.h (doprnt):
5844 * xdisp.c (vmessage):
5845 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5846 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5847 prefer signed arithmetic to avoid comparison confusion.
5848 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5849 but is a bit tricky.
5850
0e926e56
PE
5851 Assume freestanding C89 headers, string.h, stdlib.h.
5852 * data.c, doprnt.c, floatfns.c, print.c:
5853 Include float.h unconditionally.
5854 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5855 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5856 * regex.c: Likewise for stddef.h, string.h.
5857 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5858 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5859 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5860 (STDC_HEADERS): Remove obsolete defines.
5861 * sysdep.c: Include limits.h unconditionally.
5862
9cfdb3ec
PE
5863 Assume support for memcmp, memcpy, memmove, memset.
5864 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5865 * regex.c (memcmp, memcpy):
5866 Remove; we assume C89 now.
5867
5868 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5869 (__malloc_safe_bcopy): Remove; no longer needed.
5870
cf950e6b 5871 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5872 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5873 well either way, and we prefer signed to unsigned.
5874
dbf38e02
LMI
58752011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5876
5877 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5878 closes the connection while we're reading (bug#9182).
5879
d6f0886c 58802011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5881
d6f0886c
JD
5882 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5883 are specified (Bug#9168).
24e0f6b1 5884
2eb1f9e6
PE
58852011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5886
5887 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5888 Found by GCC static checking and --with-wide-int on a 32-bit host.
5889
22381272 58902011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5891
5892 * xdisp.c (compute_display_string_pos): Fix logic of caching
5893 previous display string position. Initialize cached_prev_pos to
5894 -1. Fixes slow-down at the beginning of a buffer.
5895
f25e39b4
EZ
58962011-07-24 Eli Zaretskii <eliz@gnu.org>
5897
5898 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5899 for attrs[LFACE_FONTSET_INDEX].
5900
04c4b52e
PE
59012011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5902
5903 * xml.c (parse_region): Remove unused local
5904 that was recently introduced.
5905
c1734fbd
EZ
59062011-07-23 Eli Zaretskii <eliz@gnu.org>
5907
be18c5a5
EZ
5908 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5909 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5910
c1734fbd
EZ
5911 * xdisp.c (move_it_in_display_line_to): Record the best matching
5912 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5913 exit if none of the characters scanned was an exact match.
5914 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5915 when exact match is impossible due to invisible text, and the
5916 lines are truncated.
5917
a258d627
JD
59182011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5919
5920 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5921 for OSX >= 10.7.
5922
b6d5a689
EZ
59232011-07-22 Eli Zaretskii <eliz@gnu.org>
5924
0f74f785
EZ
5925 Fix a significant slow-down of cursor motion with C-n, C-p,
5926 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5927 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5928 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5929 (next_element_from_buffer): Call compute_stop_pos_backwards to
5930 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5931 base_level_stop.
5932 (reseat): Don't look for prev_stop, as that could mean a very long
5933 run.
5934 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5935 <cached_disp_overlay_modiff>: Cache for last found display string
5936 position.
551918c1 5937 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5938 about the same buffer in the same area of character positions, and
5939 the buffer wasn't changed since the time the display string
5940 position was cached.
551918c1 5941
b2d0c91a
EZ
59422011-07-22 Eli Zaretskii <eliz@gnu.org>
5943
5944 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5945 is an integer, which is important for empty lines. (Bug#9149)
5946
043604ee
CY
59472011-07-22 Chong Yidong <cyd@stupidchicken.com>
5948
5949 * frame.c (Fmodify_frame_parameters): In tty case, update the
5950 default face if necessary (Bug#4238).
5951
da4adb04
CY
59522011-07-21 Chong Yidong <cyd@stupidchicken.com>
5953
5954 * editfns.c (Fstring_to_char): No need to explain what a character
5955 is in the docstring (Bug#6576).
5956
9abd0532
LMI
59572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5958
5959 * xml.c (parse_region): Make sure we always return a tree.
5960
36881d16
HK
59612011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5962
5963 * xml.c (parse_region): If a document contains only comments,
5964 return that, too.
5965
1e98674d
LMI
59662011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5967
5968 * xml.c (make_dom): Return comments, too.
5969
590bd467
PE
59702011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5971
5972 Port to OpenBSD.
5973 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5974 and the surrounding thread.
5975 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5976 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5977 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5978 timer goes off.
5979 * s/openbsd.h (BROKEN_SIGIO): Define.
5980 * unexelf.c (unexec) [__OpenBSD__]:
5981 Don't update the .mdebug section of the Alpha COFF symbol table.
5982
f41628b2
LMI
59832011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5984
5985 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5986 (bug#8460).
5987
b59b67c5
PE
59882011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5989
15e3a074
PE
5990 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5991 This fixes some race conditions on the permissions of any newly
5992 created file.
5993
41bed37d
PE
5994 * alloc.c (valid_pointer_p): Use pipe, not open.
5995 This fixes some permissions issues when debugging.
5996
b59b67c5
PE
5997 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5998 If fchown fails to set both uid and gid, try to set just gid,
5999 as that is sometimes allowed. Adjust the file's mode to eliminate
6000 setuid or setgid bits that are inappropriate if fchown fails.
6001
925a6be7
SM
60022011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6003
6004 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6005 to compare Lisp_Objects.
6006 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6007 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6008 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6009
52968808
AS
60102011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6011
0a6a104b
AS
6012 * lread.c (read_integer): Unread even EOF character.
6013 (read1): Likewise. Properly record start position of symbol.
6014
52968808
AS
6015 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6016 symbol character follows.
6017
9e381cdd
PE
60182011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6019
6020 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6021 This works around a problem with the previous change to Fcopy_file.
6022 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6023 and without this change, GCC might complain about discarding
6024 fchown's return value.
6025
b5641435
JB
60262011-07-16 Juanma Barranquero <lekktu@gmail.com>
6027
6028 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6029
a8031457
PE
60302011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6031
6032 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6033
dd889327
LMI
60342011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6035
750c33f7
LMI
6036 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6037 it's used from the C level.
6038
dd889327
LMI
6039 * process.c: Use the same condition for POLL_FOR_INPUT in both
6040 keyboard.c and process.c (bug#1858).
6041
87e86684
LM
60422011-07-09 Lawrence Mitchell <wence@gmx.li>
6043
6044 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6045 (Fgnutls_boot): Use it.
6046
64348f40
AS
60472011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6048
6049 * doc.c (Fsubstitute_command_keys): Revert last change.
6050
1d698799
LMI
60512011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6052
f863868c
LMI
6053 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6054 quotes the next character, and doesn't affect other longer
6055 sequences (bug#8935).
6056
1d698799
LMI
6057 * lread.c (syms_of_lread): Clarify that is isn't only
6058 `eval-buffer' and `eval-defun' that's affected by
6059 `lexical-binding' (bug#8460).
6060
aa4b6df6
EZ
60612011-07-15 Eli Zaretskii <eliz@gnu.org>
6062
6063 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6064 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6065
5d856da6
PE
60662011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6067
ad6042bb
PE
6068 Fix minor problems found by static checking.
6069 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6070 (elsz): Now a signed constant, not a size_t var. We prefer signed
6071 types to unsigned, to avoid integer comparison confusion. Without
6072 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6073 "cannot optimize loop, the loop counter may overflow", a symptom
6074 of the confusion.
f00bbb22 6075 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6076 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6077
6468f31c
LMI
60782011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6079
49080b10
LMI
6080 * search.c (Fre_search_backward): Mention `case-fold-search' in
6081 all the re_search_* functions (bug#8138).
6082
6468f31c
LMI
6083 * keyboard.c (Fopen_dribble_file): Document when the file is
6084 closed (bug#8056).
6085
c965adc5
EZ
60862011-07-14 Eli Zaretskii <eliz@gnu.org>
6087
df9733bf
EZ
6088 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6089 bidi_cache_idx.
6090
0bb23927
EZ
6091 Support bidi reordering of display and overlay strings.
6092 * xdisp.c (compute_display_string_pos)
6093 (compute_display_string_end): Accept additional argument STRING.
6094 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6095 (reseat_to_string): Initialize bidi_it->string.s and
6096 bidi_it->string.schars.
6097 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6098 NULL (avoids a crash in bidi_paragraph_init).
6099 Initialize itb.string.lstring.
0bb23927
EZ
6100 (init_iterator): Call bidi_init_it only of a valid
6101 buffer position was specified. Initialize paragraph_embedding to
6102 L2R.
6103 (reseat_to_string): Initialize the bidi iterator.
6104 (display_string): If we need to ignore text properties of
6105 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6106 original value of -1 will not work with bidi.)
6107 (compute_display_string_pos): First arg is now struct
6108 `text_pos *'; all callers changed. Support display properties on
6109 Lisp strings.
6110 (compute_display_string_end): Support display properties on Lisp
6111 strings.
6112 (init_iterator, reseat_1, reseat_to_string): Initialize the
6113 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6114 when iterating on a string not from display properties).
640c8776
SM
6115 (compute_display_string_pos, compute_display_string_end):
6116 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6117 arrow keys.
6118 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6119 base_level_stop; instead, set base_level_stop to BEGV.
6120 Fixes crashes in vertical-motion.
0bb23927
EZ
6121 (next_element_from_buffer): Improve commentary for when
6122 the iterator is before prev_stop.
6123 (init_iterator): Initialize bidi_p from the default value of
6124 bidi-display-reordering, not from buffer-local value. Use the
6125 buffer-local value only if initializing for buffer iteration.
6126 (handle_invisible_prop): Support invisible properties on strings
6127 that are being bidi-reordered.
6128 (set_iterator_to_next): Support bidi reordering of C strings and
6129 Lisp strings.
6130 (next_element_from_string): Support bidi reordering of Lisp
6131 strings.
6132 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6133 (display_string): Support display of R2L glyph rows.
6134 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6135 (init_iterator): Don't initialize it->bidi_p for strings
6136 here.
6137 (reseat_to_string): Initialize it->bidi_p for strings here.
6138 (next_element_from_string, next_element_from_c_string)
6139 (next_element_from_buffer): Add xassert's for correspondence
6140 between IT's object being iterated and it->bidi_it.string
6141 structure.
6142 (face_before_or_after_it_pos): Support bidi iteration.
6143 (next_element_from_c_string): Handle the case of the first string
6144 character that is not the first one in the visual order.
6145 (get_visually_first_element): New function, refactored from common
6146 parts of next_element_from_buffer, next_element_from_string, and
6147 next_element_from_c_string.
6148 (tool_bar_lines_needed, redisplay_tool_bar)
6149 (display_menu_bar): Force left-to-right direction. Add a FIXME
6150 comment for making that be controlled by a user option.
6151 (push_it, pop_it): Save and restore the state of the
6152 bidi iterator. Save and restore the bidi_p flag.
6153 (pop_it): Iterate out of display property for string iteration as
6154 well.
6155 (iterate_out_of_display_property): Support iteration over strings.
6156 (handle_single_display_spec): Set up it->bidi_it for iteration
6157 over a display string, and call bidi_init_it.
6158 (handle_single_display_spec, next_overlay_string)
6159 (get_overlay_strings_1, push_display_prop): Set up the bidi
6160 iterator for displaying display or overlay strings.
6161 (forward_to_next_line_start): Don't use the shortcut if
6162 bidi-iterating.
6163 (back_to_previous_visible_line_start): If handle_display_prop
6164 pushed the iterator stack, restore the internal state of the bidi
6165 iterator by calling bidi_pop_it same number of times.
6166 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6167 and we are bidi-iterating, don't decrement the iterator position;
6168 instead, set the first_elt flag in the bidi iterator, to produce
6169 the same effect.
6170 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6171 (push_display_prop): xassert that we are iterating a buffer.
6172 (push_it, pop_it): Save and restore paragraph_embedding member.
6173 (handle_single_display_spec, next_overlay_string)
6174 (get_overlay_strings_1, reseat_1, reseat_to_string)
6175 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6176 correctly. Don't assume unibyte strings are not bidi-reordered.
6177 (compute_display_string_pos)
6178 (compute_display_string_end): Fix handling the case of C string.
6179 (push_it, pop_it): Save and restore from_disp_prop_p.
6180 (handle_single_display_spec, push_display_prop): Set the
6181 from_disp_prop_p flag.
6182 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6183 (pop_it): Call iterate_out_of_display_property only if we are
6184 popping after iteration over a string that came from a display
6185 property. Fix a typo in popping stretch info. Add an assertion
6186 for verifying that the iterator position is in sync with the bidi
6187 iterator.
6188 (handle_single_display_spec, get_overlay_strings_1)
6189 (push_display_prop): Fix initialization of paragraph direction for
6190 string when that of the parent object is not yet determined.
6191 (reseat_1): Call bidi_init_it to resync the bidi
6192 iterator with IT's position. (Bug#7616)
6193 (find_row_edges): If ROW->start.pos gives position
6194 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6195 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6196 Reset the from_disp_prop_p flag.
6197 (SAVE_IT, RESTORE_IT): New macros.
6198 (pos_visible_p, face_before_or_after_it_pos)
6199 (back_to_previous_visible_line_start)
6200 (move_it_in_display_line_to, move_it_in_display_line)
6201 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6202 (try_scrolling, redisplay_window, display_line): Use them when
6203 saving a temporary copy of the iterator and restoring it back.
6204 (back_to_previous_visible_line_start, reseat_1)
6205 (init_iterator): Empty the bidi cache "stack".
6206 (move_it_in_display_line_to): If iterator ended up at
6207 EOL, but we never saw any buffer positions smaller than
6208 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6209 motion in bidi-reordered lines.
6210 (move_it_in_display_line_to): Record prev_method and prev_pos
6211 immediately before the call to set_iterator_to_next. Fixes cursor
6212 motion in bidi-reordered lines with stretch glyphs and strings
6213 displayed in margins. (Bug#8133) (Bug#8867)
6214 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6215 TO_CHARPOS.
640c8776
SM
6216 (pos_visible_p): Support positions in bidi-reordered lines.
6217 Save and restore bidi cache.
0bb23927
EZ
6218
6219 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6220 (bidi_paragraph_info): Delete unused struct.
6221 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6222 (bidi_cache_start): New variable.
6223 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6224 to zero.
6225 (bidi_cache_fetch_state, bidi_cache_search)
6226 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6227 (bidi_cache_find, bidi_peek_at_next_level)
6228 (bidi_level_of_next_char, bidi_find_other_level_edge)
6229 (bidi_move_to_visually_next): Compare cache index with
6230 bidi_cache_start rather than with zero.
6231 (bidi_fetch_char): Accept new argument STRING; all callers
6232 changed. Support iteration over a string. Support strings with
6233 display properties. Support unibyte strings. Fix the type of
6234 `len' according to what STRING_CHAR_AND_LENGTH expects.
6235 (bidi_paragraph_init, bidi_resolve_explicit_1)
6236 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6237 (bidi_level_of_next_char, bidi_move_to_visually_next):
6238 Support iteration over a string.
0bb23927
EZ
6239 (bidi_set_sor_type, bidi_resolve_explicit_1)
6240 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6241 can now be zero (for strings); special values 0 and -1 were
6242 changed to -1 and -2, respectively.
6243 (bidi_char_at_pos): New function.
6244 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6245 Call it instead of FETCH_MULTIBYTE_CHAR.
6246 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6247 initialized to valid values.
6248 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6249 values.
6250 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6251 the test for valid cached positions. Fix the logic for looking up
6252 the sentinel state in the cache. GCPRO the Lisp string we are
6253 iterating.
6254 (bidi_push_it, bidi_pop_it): New functions.
6255 (bidi_initialize): Initialize the bidi cache start stack pointer.
6256 (bidi_cache_ensure_space): New function, refactored from part of
6257 bidi_cache_iterator_state. Don't assume the required size is just
6258 one BIDI_CACHE_CHUNK away.
6259 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6260 (bidi_count_bytes, bidi_char_at_pos): New functions.
6261 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6262 always valid if bidi_cache_idx is valid.
6263 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6264 is valid if it's going to be used.
6265 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6266 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6267 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6268 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6269 (bidi_find_other_level_edge, bidi_cache_start_stack):
6270 All variables related to cache indices are now EMACS_INT.
c965adc5 6271
0bb23927
EZ
6272 * dispextern.h (struct bidi_string_data): New structure.
6273 (struct bidi_it): New member `string'. Make flag members be 1-bit
6274 fields, and put them last in the struct.
640c8776
SM
6275 (compute_display_string_pos, compute_display_string_end):
6276 Update prototypes.
0bb23927
EZ
6277 (bidi_push_it, bidi_pop_it): Add prototypes.
6278 (struct iterator_stack_entry): New members bidi_p,
6279 paragraph_embedding, and from_disp_prop_p.
6280 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6281 (bidi_shelve_cache, bidi_unshelve_cache):
6282 Declare prototypes.
0bb23927
EZ
6283
6284 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6285 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6286 and vector-like objects.
6287
6288 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6289 cache around display iteration.
6290
6291 * window.c (Fwindow_end, window_scroll_pixel_based)
6292 (displayed_window_lines, Frecenter): Save and restore the bidi
6293 cache around display iteration.
6294
3bbd2265
LMI
62952011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6296
6297 * editfns.c (Fdelete_region): Clarify the use of the named
6298 parameters (bug#6788).
6299
adc47434
MR
63002011-07-14 Martin Rudalics <rudalics@gmx.at>
6301
6302 * indent.c (Fvertical_motion): Set and restore w->pointm when
6303 saving and restoring the window's buffer (Bug#9006).
6304
837c31f8
LMI
63052011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6306
6307 * editfns.c (Fstring_to_char): Clarify just what is returned
6308 (bug#6576). Text by Eli Zaretskii.
6309
ac389d0c
JB
63102011-07-13 Juanma Barranquero <lekktu@gmail.com>
6311
6312 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6313
0be0ce47
EZ
63142011-07-13 Eli Zaretskii <eliz@gnu.org>
6315
6316 * buffer.c (mmap_find): Fix a typo.
6317
cd18e7e3
JB
63182011-07-13 Johan Bockgård <bojohan@gnu.org>
6319
6320 Fix execution of x selection hooks.
6321 * xselect.c (Qx_lost_selection_functions)
6322 (Qx_sent_selection_functions): New vars.
6323 (syms_of_xselect): DEFSYM them.
6324 (x_handle_selection_request): Pass Qx_sent_selection_functions
6325 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6326 (x_handle_selection_clear,x_clear_frame_selections):
6327 Pass Qx_lost_selection_functions rather than
6328 Vx_lost_selection_functions to Frun_hook_with_args.
6329
47ea7f44
PE
63302011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6331
ac389d0c 6332 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6333 The old code sometimes used this field without initializing it.
6334
47ea7f44
PE
6335 * alloc.c (gc_sweep): Don't read past end of array.
6336 In theory, the old code could also have corrupted Emacs internals,
6337 though it'd be very unlikely.
6338
bc985c87
AS
63392011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6340
6341 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6342 argument. (Bug#4026)
bc985c87 6343
0cf34688
LMI
63442011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6345
b3dadd76
LMI
6346 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6347 key" (bug#4257).
6348
0cf34688
LMI
6349 * window.c (Fset_window_start): Doc fix (bug#4199).
6350 (Fset_window_hscroll): Ditto.
6351
270768cd
PE
63522011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6353
077e3dda 6354 Fix minor new problems caught by GCC 4.6.1.
270768cd 6355 * term.c (init_tty): Remove unused local.
490011a6 6356 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6357 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6358 not used otherwise.
270768cd 6359
b1f58454
CY
63602011-07-12 Chong Yidong <cyd@stupidchicken.com>
6361
6362 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6363
22b9578d
LMI
63642011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6365
6e70ab07
LMI
6366 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6367 are the mini-buffer and the echo area (bug#3320).
6368
22b9578d
LMI
6369 * term.c (init_tty): Remove support for supdup, c10 and perq
6370 terminals, which are no longer supported (bug#1482).
6371
8974cc9f
JB
63722011-07-10 Johan Bockgård <bojohan@gnu.org>
6373
6374 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6375
a560d974
JD
63762011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6377
6378 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6379 for non-popups (Bug#3642).
6380
1dae0f0a
AS
63812011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6382
268c2c36 6383 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6384 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6385 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6386 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6387 * data.c (fmod): Likewise.
6388 * dispnew.c (swap_glyphs_in_rows): Likewise.
6389 * emacs.c (memory_warning_signal): Likewise.
6390 * floatfns.c (float_error): Likewise.
6391 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6392 (otf_open, font_otf_capability, generate_otf_features)
6393 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6394 Likewise.
6395 * image.c (pbm_read_file): Likewise.
6396 * indent.c (string_display_width): Likewise.
6397 * intervals.c (check_for_interval, search_for_interval)
6398 (inc_interval_count, count_intervals, root_interval)
6399 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6400 * lread.c (defalias): Likewise.
268c2c36 6401 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6402 * regex.c (set_image_of_range_1, set_image_of_range)
6403 (regex_grow_registers): Likewise.
6404 * sysdep.c (strerror): Likewise.
6405 * termcap.c (valid_filename_p, tprint, main): Likewise.
6406 * tparam.c (main): Likewise.
6407 * unexhp9k800.c (run_time_remap, save_data_space)
6408 (update_file_ptrs, read_header, write_header, calculate_checksum)
6409 (copy_file, copy_rest, display_header): Likewise.
6410 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6411 Likewise.
6412 * xdisp.c (check_it): Likewise.
6413 * xfaces.c (register_color, unregister_color, unregister_colors):
6414 Likewise.
6415 * xfns.c (print_fontset_result): Likewise.
6416 * xrdb.c (member, fatal, main): Likewise.
6417
99033785
PE
64182011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6419
6420 Fix minor problems found by static checking (Bug#9031).
6421 * chartab.c (char_table_set_range, map_sub_char_table):
6422 Remove unused locals.
6423 (uniprop_table): Now static.
6424 * composite.c (_work_char): Remove unused static var.
6425
9cb2ac56
JB
64262011-07-09 Juanma Barranquero <lekktu@gmail.com>
6427
6428 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6429
f25661f0
JD
64302011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6431
6432 * gtkutil.c (qttip_cb): Remove code without function.
6433
8278c4fe
EZ
64342011-07-09 Eli Zaretskii <eliz@gnu.org>
6435
6436 * w32.c (pthread_sigmask): New stub.
6437
1692ae2d 64382011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6439
8a6ebd58 6440 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6441 sigprocmask is portable only for single-threaded applications, and
6442 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6443 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6444 (LIBES): Use it.
6445 * callproc.c (Fcall_process):
6446 * process.c (create_process):
6447 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6448 Use pthread_sigmask, not sigprocmask.
123403e4 6449
1b854618
JD
64502011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6451
6452 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6453 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6454 wrong (Bug#8591).
6455
3fe4b549
JD
64562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6457
0ce7e563
JD
6458 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6459 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6460 (xg_hide_tooltip): Fix comment.
6461
3fe4b549
JD
6462 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6463 in registerServicesMenuSendTypes.
6464 (validRequestorForSendType): Don't check ns_return_types.
6465
6466 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6467 ns_return_type.
6468
5df75e47
JR
64692011-07-08 Jason Rumney <jasonr@gnu.org>
6470
22610910
JR
6471 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6472 SH_SHOW for hidden windows (Bug#5482).
6473
5df75e47
JR
6474 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6475 frame struct members of non-existent frames (Bug#6284).
6476
699c10bd
JD
64772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6478
4393663b
JD
6479 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6480 variable firstTime not needed on OSX >= 10.6.
6481 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6482 >= 10.5. Use setKnobProportion, setDoubleValue.
6483
6484 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6485 (MAC_OS_X_VERSION_10_5): Define if not defined.
6486 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6487 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6488 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6489
6490 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6491 cString and lossyCString on OSX >= 10.4
6492
58179cce 6493 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6494 sizeToFit on OSX >= 10.2.
6495
6496 * nsimage.m (allocInitFromFile): Don't use deprecated method
6497 bestRepresentationForDevice on OSX >= 10.6.
6498
6499 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6500 to avoid warning.
6501
6502 * emacs.c: Declare unexec_init_emacs_zone.
6503
a63e0781
JD
6504 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6505
699c10bd
JD
6506 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6507
6508 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6509 on svcsMenu (Bug#8842).
6510
6511 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6512 ns_return_types.
6513 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6514
6515 * nsterm.m (QUTF8_STRING): Declare.
6516 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6517 (validRequestorForSendType): Return type is (id).
6518 Change indexOfObjectIdenticalTo to indexOfObject.
6519 Check if we have local selection before returning self (Bug#8842).
6520 (writeSelectionToPasteboard): Put local selection into paste board
6521 if we have a local selection (Bug#8842).
6522 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6523
6524 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6525 (ns_get_local_selection): Declare.
6526
54e10184
LMI
65272011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6528
9888ff71
LMI
6529 * keymap.c (describe_map_tree): Don't insert a double newline at
6530 the end of the buffer (bug#1169) and return whether we inserted
6531 something.
6532
54e10184
LMI
6533 * callint.c (Fcall_interactively): Change "reading args" to
6534 "providing args" to try to clarify what it does (bug#1010).
6535
15fa4783
KH
65362011-07-07 Kenichi Handa <handa@m17n.org>
6537
6538 * composite.c (composition_compute_stop_pos): Ignore a static
6539 composition starting before CHARPOS (Bug#8915).
6540
6541 * xdisp.c (handle_composition_prop): Likewise.
6542
a8815b00
EZ
65432011-07-07 Eli Zaretskii <eliz@gnu.org>
6544
6545 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6546 (Bug#9015)
6547
ef7b981d 65482011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6549
6550 * character.h (unicode_category_t): New enum type.
6551
6552 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6553 (Qchar_code_property_table): New variable.
6554 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6555 (UNIPROP_COMPRESSED_FORM_P): New macros.
6556 (char_table_ascii): Uncompress the compressed values.
6557 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6558 Uncompress the compressed values.
ac389d0c 6559 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6560 (char_table_ref_and_range): Uncompress the compressed values.
6561 (sub_char_table_set): New arg is_uniprop. Callers changed.
6562 Uncompress the compressed values.
6563 (sub_char_table_set_range): Args changed. Callers changed.
6564 (char_table_set_range): Adjuted for the above change.
6565 (map_sub_char_table): Delete args default_val and parent. Add arg
6566 top. Give decoded values to a Lisp function.
640c8776 6567 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6568 values to a Lisp function. Gcpro more variables.
6569 (uniprop_table_uncompress)
6570 (uniprop_decode_value_run_length): New functions.
6571 (uniprop_decoder, uniprop_decoder_count): New variables.
6572 (uniprop_get_decoder, uniprop_encode_value_character)
6573 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6574 New functions.
6575 (uniprop_encoder, uniprop_encoder_count): New variables.
6576 (uniprop_get_encoder, uniprop_table)
6577 (Funicode_property_table_internal, Fget_unicode_property_internal)
6578 (Fput_unicode_property_internal): New functions.
6579 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6580 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6581 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6582 char-code-property-alist.
6583
640c8776 6584 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6585 Vunicode_category_table.
6586
640c8776 6587 * font.c (font_range): Adjust for the change of
c805dec0
KH
6588 Vunicode_category_table.
6589
76b397fb
DN
65902011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6591
6592 * m/iris4d.h: Remove file, move contents ...
6593 * s/irix6-5.h: ... here.
6594
22b4128e
PE
65952011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6596
6597 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6598 * alloc.c (mark_buffer):
6599 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6600 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6601 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6602 This isn't true in general, and it's particularly not true
6603 if Emacs is configured with --with-wide-int.
6604 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6605 New macros, used in the buffer.c change.
6606
869795d6
JD
66072011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6608
6609 * xsettings.c: Use both GConf and GSettings if both are available.
6610 (store_config_changed_event): Add comment.
6611 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6612 (store_tool_bar_style_changed): New functions.
5e617bc2 6613 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6614 (struct xsettings): Move font inside HAVE_XFT.
6615 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6616 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6617 Move inside HAVE_XFT.
640c8776 6618 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6619 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6620 also.
6621 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6622 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6623 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6624 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6625 (parse_settings): Move check for font inside HAVE_XFT.
6626 (read_settings, apply_xft_settings): Add comment.
6627 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6628 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6629 call store_font_name_changed.
6630 (xft_settings_event): Add comment.
6631 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6632 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6633 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6634 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6635 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6636 (xsettings_get_system_font, xsettings_get_system_normal_font):
6637 Add comment.
869795d6 6638
d8ed26bd
PE
66392011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6640
6641 Random fixes. E.g., (random) never returned negative values.
6642 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6643 subseconds part to the entropy, as that's a bit more random.
6644 Prefer signed to unsigned, since the signedness doesn't matter and
6645 in general we prefer signed. When given a limit, use a
6646 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6647 latter isn't right if USE_2_TAGS_FOR_INTS.
6648 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6649 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6650
cabf1cac
SM
66512011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6652
6653 * textprop.c (text_property_stickiness):
6654 Obey Vtext_property_default_nonsticky.
6655 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6656 * w32fns.c (syms_of_w32fns):
6657 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6658
6e9b2be9
PE
66592011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6660
6661 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6662 This is more efficient than Ffile_directory_p and avoids a minor race.
6663
90186c68
LMI
66642011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6665
7c301272
LMI
6666 * buffer.c (Foverlay_put): Say what the return value is
6667 (bug#7835).
6668
c4f2d8d4
LMI
6669 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6670 is a directory before asking whether to use the file name
6671 (bug#7564).
ad637907
LMI
6672 (barf_or_query_if_file_exists): Make the "File is a directory"
6673 error be more correct.
c4f2d8d4 6674
90186c68
LMI
6675 * fns.c (Frequire): Remove the mention of the .gz files, since
6676 that's installation-specific, but keep the mention of
6677 `get-load-suffixes'.
6678
da64016e
PE
66792011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6680
6681 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6682 Report string overflow if the output is too long.
6683
7d47b580
JB
66842011-07-04 Juanma Barranquero <lekktu@gmail.com>
6685
a555cb87
JB
6686 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6687 (syms_of_gnutls): Remove duplicate DEFSYM for
6688 Qgnutls_bootprop_verify_hostname_error, an error for
6689 Qgnutls_bootprop_verify_error (which is no longer used).
6690
7d47b580
JB
6691 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6692 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6693 Also (re)move comments that are misplaced or no longer relevant.
6694
1e49bfab
LMI
66952011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6696
6697 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6698
1485f4c0
CY
66992011-07-03 Chong Yidong <cyd@stupidchicken.com>
6700
6701 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6702 and background color parameters if they have been changed.
6703
a9ab721e
LMI
67042011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6705
6706 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6707
cf7cff57
PE
67082011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6709
2e13213d
PE
6710 * xsettings.c (SYSTEM_FONT): Define only when used.
6711 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6712
cf7cff57
PE
6713 * keymap.c (access_keymap_1): Now static.
6714
7a8e04f7
CY
67152011-07-02 Chong Yidong <cyd@stupidchicken.com>
6716
6717 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6718 leave any prefix arg for the up event (Bug#1586).
6719
61352f62
LMI
67202011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6721
69bb1ef7
LMI
6722 * lread.c (syms_of_lread): Mention single symbols defined by
6723 `defvar' or `defconst' (bug#7154).
6724
61352f62 6725 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6726 (Frequire): Mention get-load-suffixes.
61352f62 6727
28545e04
MR
67282011-07-02 Martin Rudalics <rudalics@gmx.at>
6729
6730 * window.h (window): Remove clone_number slot.
6731 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6732 Remove.
6733 (make_parent_window, make_window, saved_window)
6734 (Fset_window_configuration, save_window_save): Don't deal with
6735 clone numbers.
6736 * buffer.c (Qclone_number): Remove declaration.
6737 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6738
3349e122
SM
67392011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6740
6741 Add multiple inheritance to keymaps.
6742 * keymap.c (Fmake_composed_keymap): New function.
6743 (Fset_keymap_parent): Simplify.
6744 (fix_submap_inheritance): Remove.
6745 (access_keymap_1): New function extracted from access_keymap to handle
6746 embedded parents and handle lists of maps.
6747 (access_keymap): Use it.
6748 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6749 (Fcopy_keymap): Handle embedded parents.
6750 (Fcommand_remapping, define_as_prefix): Simplify.
6751 (Fkey_binding): Simplify.
6752 (syms_of_keymap): Move minibuffer-local-completion-map,
6753 minibuffer-local-filename-completion-map,
6754 minibuffer-local-must-match-map, and
6755 minibuffer-local-filename-must-match-map to Elisp.
6756 (syms_of_keymap): Defsubr make-composed-keymap.
6757 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6758 (parse_menu_item): Trivial simplification.
6759
3279eb87
GM
67602011-07-01 Glenn Morris <rgm@gnu.org>
6761
6762 * Makefile.in (SETTINGS_LIBS): Fix typo.
6763
4550efdf
KI
67642011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6765
6766 * coding.c (Fencode_coding_string): Record the last coding system
6767 used, as the function doc string says (bug#8738).
6768
0949d2b6
JD
67692011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6770
6771 * xsettings.c (store_monospaced_changed): Take new font as arg and
6772 check for change against current_mono_font.
6773 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6774 (emacs_settings_constructor, emacs_settings_get_property)
6775 (emacs_settings_set_property, emacs_settings_class_init)
6776 (emacs_settings_init, gsettings_obj): Remove.
6777 (something_changedCB): New function for HAVE_GSETTINGS.
6778 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6779 with value as argument.
6780 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6781 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6782 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6783 "changed".
6784
6785 * xgselect.c: Add defined (HAVE_GSETTINGS).
6786 (xgselect_initialize): Ditto.
6787
6788 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6789 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6790 xg_select.
6791
bbc6b304
PE
67922011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6793
6794 * eval.c (struct backtrace): Simplify and port the data structure.
6795 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6796 signed bit field, as this assumption is not portable and it makes
6797 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6798 "char debug_on_exit : 1" as this is not portable either; instead,
6799 use the portable "unsigned int debug_on_exit : 1". Remove unused
6800 member evalargs. Remove obsolete comments about cc bombing out.
6801
9851bfc5
JD
68022011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6803
51bb811f 6804 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6805 Let HAVE_GSETTINGS override HAVE_GCONF.
6806 (store_monospaced_changed): New function.
6807 (EMACS_SETTINGS): A new type derived from GObject to handle
6808 GSettings notifications.
6809 (emacs_settings_constructor, emacs_settings_get_property)
6810 (emacs_settings_set_property, emacs_settings_class_init):
6811 New functions.
6812 (gsettings_client, gsettings_obj): New variables.
6813 (GSETTINGS_SCHEMA): New define.
6814 (something_changedCB): Call store_monospaced_changed.
6815 (init_gsettings): New function.
6816 (xsettings_initialize): Call init_gsettings.
6817 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6818 to NULL.
6819
640c8776 6820 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6821 GCONF_CFLAGS/LIBS.
6822
5386012d
MR
68232011-06-29 Martin Rudalics <rudalics@gmx.at>
6824
6825 * window.c (resize_root_window, grow_mini_window)
6826 (shrink_mini_window): Rename Qresize_root_window to
6827 Qwindow_resize_root_window and Qresize_root_window_vertically to
6828 Qwindow_resize_root_window_vertically.
6829
f13e0b08
PE
68302011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6831
6832 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6833
94515237
JB
68342011-06-27 Juanma Barranquero <lekktu@gmail.com>
6835
6836 * makefile.w32-in: Redesign dependencies so they reflect more
6837 clearly which files are directly included by each source file,
6838 and not through other includes.
6839
e43b6e43
MR
68402011-06-27 Martin Rudalics <rudalics@gmx.at>
6841
6842 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6843 (sort_overlays, overlay_strings): When an overlay's clone number
6844 matches the window's clone number process the overlay even if
6845 the overlay's window property doesn't match the current window.
6846
d68443dc
MR
6847 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6848 (Fwindow_hchild): Rename to Fwindow_left_child.
6849 (Fwindow_next): Rename to Fwindow_next_sibling.
6850 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6851 (resize_window_check): Rename to window_resize_check.
6852 (resize_window_apply): Rename to window_resize_apply.
6853 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6854 (Fdelete_other_windows_internal, resize_frame_windows)
6855 (Fsplit_window_internal, Fdelete_window_internal)
6856 (grow_mini_window, shrink_mini_window)
6857 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6858
c7e73be5
JD
68592011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6860
6861 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6862 (emacs_fixed_set_min_size): Remove.
6863 (emacs_fixed_new): Take frame as argument.
6864
6865 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6866 (_EmacsFixedPrivate): Remove minwidth/height.
6867 Add struct frame *f.
6868 (emacs_fixed_init): Initialize priv->f.
6869 (get_parent_class, emacs_fixed_set_min_size): Remove.
6870 (emacs_fixed_new): Set priv->f to argument.
6871 (emacs_fixed_get_preferred_width)
6872 (emacs_fixed_get_preferred_height): Use min_width/height from
6873 frames size_hint to set minimum and natural (Bug#8919).
6874 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6875 and use min_width/height from frames size_hint to set
6876 min_width/height (Bug#8919).
6877
6878 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6879 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6880 Fix indentation.
c7e73be5 6881
cf99dcf8
EZ
68822011-06-26 Eli Zaretskii <eliz@gnu.org>
6883
6884 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6885 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6886 called at ZV.
6887
029529ac
CY
68882011-06-26 Chong Yidong <cyd@stupidchicken.com>
6889
6890 * process.c (wait_reading_process_output): Bypass select if
6891 waiting for a cell while ignoring keyboard input, and input is
6892 pending. Suggested by Jan Djärv (Bug#8869).
6893
7a7ef429
PE
68942011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6895
6896 Use gnulib's dup2 module instead of rolling our own.
6897 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6898
11fdef7d 68992011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6900
6901 * dispnew.c (scrolling_window): Before scrolling, turn off a
6902 mouse-highlight in the window being scrolled.
6903
cd3520a4
JB
69042011-06-24 Juanma Barranquero <lekktu@gmail.com>
6905
6906 Move DEFSYM to lisp.h and use everywhere.
6907
6908 * character.h (DEFSYM): Move declaration...
6909 * lisp.h (DEFSYM): ...here.
6910
6911 * gnutls.c:
6912 * minibuf.c:
6913 * w32menu.c:
6914 * w32proc.c:
6915 * w32select.c: Don't include character.h.
6916
6917 * alloc.c (syms_of_alloc):
6918 * buffer.c (syms_of_buffer):
6919 * bytecode.c (syms_of_bytecode):
6920 * callint.c (syms_of_callint):
6921 * casefiddle.c (syms_of_casefiddle):
6922 * casetab.c (init_casetab_once):
6923 * category.c (init_category_once, syms_of_category):
6924 * ccl.c (syms_of_ccl):
6925 * cmds.c (syms_of_cmds):
6926 * composite.c (syms_of_composite):
6927 * dbusbind.c (syms_of_dbusbind):
6928 * dired.c (syms_of_dired):
6929 * dispnew.c (syms_of_display):
6930 * doc.c (syms_of_doc):
6931 * editfns.c (syms_of_editfns):
6932 * emacs.c (syms_of_emacs):
6933 * eval.c (syms_of_eval):
6934 * fileio.c (syms_of_fileio):
6935 * fns.c (syms_of_fns):
6936 * frame.c (syms_of_frame):
6937 * fringe.c (syms_of_fringe):
6938 * insdel.c (syms_of_insdel):
6939 * keymap.c (syms_of_keymap):
6940 * lread.c (init_obarray, syms_of_lread):
6941 * macros.c (syms_of_macros):
6942 * msdos.c (syms_of_msdos):
6943 * print.c (syms_of_print):
6944 * process.c (syms_of_process):
6945 * search.c (syms_of_search):
6946 * sound.c (syms_of_sound):
6947 * syntax.c (init_syntax_once, syms_of_syntax):
6948 * terminal.c (syms_of_terminal):
6949 * textprop.c (syms_of_textprop):
6950 * undo.c (syms_of_undo):
6951 * w32.c (globals_of_w32):
6952 * window.c (syms_of_window):
6953 * xdisp.c (syms_of_xdisp):
6954 * xfaces.c (syms_of_xfaces):
6955 * xfns.c (syms_of_xfns):
6956 * xmenu.c (syms_of_xmenu):
6957 * xsettings.c (syms_of_xsettings):
6958 * xterm.c (syms_of_xterm): Use DEFSYM.
6959
4228cf16
TZ
69602011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6961
cd3520a4 6962 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6963
7fcccf1e
PE
69642011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6965
7efb4e0e
PE
6966 Integer and buffer overflow fixes (Bug#8873).
6967
ff5844ad
PE
6968 * print.c (printchar, strout): Check for string overflow.
6969 (PRINTPREPARE, printchar, strout):
6970 Don't set size unless allocation succeeds.
6971
90532f02
PE
6972 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6973 for sizes. Check for string overflow more accurately.
6974 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6975
6d84508d
PE
6976 * macros.c: Integer and buffer overflow fixes.
6977 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6978 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6979 Use ptrdiff_t, not int, for sizes.
6980 Don't increment bufsize until after realloc succeeds.
6981 Check for size-calculation overflow.
6982 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6983
437b2cb4
PE
6984 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6985
8b9ac8b4
PE
6986 * lread.c: Integer overflow fixes.
6987 (read_integer): Radix is now EMACS_INT, not int,
6988 to improve quality of diagnostics for out-of-range radices.
6989 Calculate buffer size correctly for out-of-range radices.
6990 (read1): Check for integer overflow in radices, and in
6991 read-circle numbers.
82cb60d3
PE
6992 (read_escape): Avoid int overflow.
6993 (Fload, openp, read_buffer_size, read1)
6994 (substitute_object_recurse, read_vector, read_list, map_obarray):
6995 Use ptrdiff_t, not int, for sizes.
6996 (read1): Use EMACS_INT, not int, for sizes.
20270765 6997 Check for size overflow.
8b9ac8b4 6998
7fcccf1e
PE
6999 * image.c (cache_image): Check for size arithmetic overflow.
7000
bfbbd7e7
PE
7001 * lread.c: Integer overflow issues.
7002 (saved_doc_string_size, saved_doc_string_length)
7003 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7004 Now ptrdiff_t, not int.
7005 (read1): Don't assume doc string length fits in int. Check for
7006 out-of-range doc string lengths.
7007 (read_list): Don't assume file position fits in int.
39019e54 7008 (read_escape): Check for hex character overflow.
bfbbd7e7 7009
4e323265
LL
70102011-06-22 Leo Liu <sdl.web@gmail.com>
7011
7012 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7013 Move to minibuffer.el.
7014
85fece3e
PE
70152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7016
20b84ce9 7017 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7018 The following patches are for when GLYPH_DEBUG && !XASSERT.
7019 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7020 * dispnew.c (flush_stdout):
7021 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7022 Mark as externally visible.
7023 * dispnew.c (check_window_matrix_pointers): Now static.
7024 * dispnew.c (window_to_frame_vpos):
7025 * xfns.c (unwind_create_frame):
7026 * xterm.c (x_check_font): Remove unused local.
7027 * scroll.c (CHECK_BOUNDS):
7028 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7029 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7030 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7031 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7032 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7033 Now static.
7034 (debug_method_add): Use va_list and vsprintf rather than relying
7035 on undefined behavior with wrong number of arguments.
7036 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7037 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7038 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7039 since we're not interested in debugging glyphs with old libraries.
7040 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7041 GCC 4.6.0's static checking.
7042
0766b489
PE
70432011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7044
31fd4b32
PE
7045 Integer overflow and signedness fixes (Bug#8873).
7046 A few related buffer overrun fixes, too.
7047
b79e8648
PE
7048 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7049
0766b489
PE
7050 * dispextern.h (struct face.stipple):
7051 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7052 (x_bitmap_mask, x_allocate_bitmap_record)
7053 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7054 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7055 (x_create_bitmap_from_xpm_data):
7056 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7057 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7058 (.bitmaps_last):
7059 * xfaces.c (load_pixmap):
7060 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7061 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7062 (.bitmaps_last, struct x_output.icon_bitmap):
7063 Use ptrdiff_t, not int, for bitmap indexes.
7064 (x_allocate_bitmap_record): Check for size overflow.
7065 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7066
b081724f
PE
7067 Use ptrdiff_t, not int, for overlay counts.
7068 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7069 * editfns.c (overlays_around, get_pos_property):
7070 * textprop.c (get_char_property_and_overlay):
7071 * xdisp.c (next_overlay_change, note_mouse_highlight):
7072 * xfaces.c (face_at_buffer_position):
21514da7
PE
7073 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7074 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7075 (Fnext_overlay_change, Fprevious_overlay_change)
7076 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7077 Use ptrdiff_t, not int, for sizes.
21514da7 7078 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7079
3de73e5e
PE
7080 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7081
2606c57b
PE
7082 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7083 (x_session_initialize): Do not assume string length fits in int.
7084
aaafe47a
PE
7085 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7086 This is unlikely, but can occur if DPI is outlandish.
7087
2674ddc8 7088 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7089 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7090
28154962
PE
7091 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7092 * xrdb.c (magic_file_p, search_magic_path):
7093 Omit last arg SUFFIX; it was always 0. All callers changed.
7094 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7095
7de51af5
PE
7096 * xfont.c (xfont_match): Avoid need for strlen.
7097
25ed6cc3
PE
7098 * xfns.c: Don't assume strlen fits in int.
7099 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7100
4eab31dd
PE
7101 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7102 not unsigned long, as we prefer signed integers. All callers changed.
7103 Detect integer overflow in repeat count.
7104 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7105 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7106
171e2a58
PE
7107 * termcap.c: Don't assume sizes fit in int and never overflow.
7108 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7109 (gobble_line): Check for size-calculation overflow.
7110
ad39faca 7111 * minibuf.c (Fread_buffer):
6e5bb2dc 7112 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7113 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7114 Don't assume string length fits in int.
7115
52c61c22 7116 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7117 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7118
b5b8c9e5
PE
7119 * font.c: Don't assume string length fits in int.
7120 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7121 Use ptrdiff_t, not int.
ccd6111c
PE
7122 (font_intern_prop): Don't assume string length fits in int.
7123 Don't assume integer property fits in fixnum.
7124 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7125
882f0d81 7126 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7127 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7128 Reformulate so as not to need the command string.
7129 Invoke gzip -cd rather than gunzip, as it's more portable.
7130 (lock_info_type, lock_file_1, lock_file):
7131 Don't assume pid_t and time_t fit in unsigned long.
7132 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7133 (current_lock_owner): Prefer signed type for sizes.
7134 Use memcpy, not strncpy, where memcpy is what is really wanted.
7135 Don't assume (via atoi) that time_t and pid_t fit in int.
7136 Check for time_t and/or pid_t out of range, e.g., via a network share.
7137 Don't alloca where an auto var works fine.
7138
93f4cf88
PE
7139 * fileio.c: Fix some integer overflow issues.
7140 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7141 Don't assume string length fits in int.
7142 (directory_file_name): Don't assume string length fits in long.
7143 (make_temp_name): Don't assume pid fits in int, or that its print
7144 length is less than 20.
7145
f3e92b69
PE
7146 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7147
1bfdaf10
PE
7148 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7149
35016e9a
PE
7150 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7151
3d1e65a1
PE
7152 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7153 We prefer signed integers, even for size calculations.
7154
0b963a93
PE
7155 * emacs.c: Don't assume string length fits in 'int'.
7156 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7157 (main): Don't invoke strlen when not needed.
7158
573f4b54
PE
7159 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7160 (XD_DEBUG_MESSAGE): Don't waste a byte.
7161
989f33ba
PE
7162 * callproc.c (getenv_internal_1, getenv_internal)
7163 (Fgetenv_internal):
965d34eb
PE
7164 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7165
e4d29b33
PE
7166 * lread.c (invalid_syntax): Omit length argument.
7167 All uses changed. This doesn't fix a bug, but it simplifies the
7168 code away from its former Hollerith-constant appearance, and it's
7169 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7170 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7171
eb49b136
PE
7172 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7173 This didn't break anything, but it didn't help either.
7174 It's confusing to put a bogus integer in a place where the actual
7175 value does not matter.
9f62aeb1 7176 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7177 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7178
15375a22
PE
7179 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7180 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7181 implementation.
b61cc01c
PE
7182 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7183 We prefer signed types, and the value cannot exceed the EMACS_INT
7184 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7185 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7186 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7187 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7188
53b2623d
PE
7189 * indent.c (sane_tab_width): New function.
7190 (current_column, scan_for_column, Findent_to, position_indentation)
7191 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7192 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7193
51cab52b 7194 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7195
f2ed8a70
PE
7196 * lisp.h (lint_assume): New macro.
7197 * composite.c (composition_gstring_put_cache):
7198 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7199
abe80cc6
PE
7200 * editfns.c, insdel.c:
7201 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7202
b02c740e
PE
7203 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7204
ebc96716
PE
7205 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7206
b4e50fa0 7207 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7208 Use much-faster test for byte-length change.
311d5d7c 7209 Don't assume string byte-length fits in 'int'.
a4cf38e4 7210 Check that character arg fits in 'int'.
85461888 7211 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7212
c0c1ee9f
PE
7213 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7214
a498d7f4
PE
7215 * fns.c (concat): Catch string overflow earlier.
7216 Do not rely on integer wraparound.
7217
51cab52b
PE
7218 * dispextern.h (struct it.overlay_strings_charpos)
7219 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7220 * xdisp.c (forward_to_next_line_start)
7221 (back_to_previous_visible_line_start)
7222 (reseat_at_next_visible_line_start, next_element_from_buffer):
7223 Don't arbitrarily truncate the value of 'selective' to int.
7224
76031fad
PE
7225 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7226
5eb55db9
PE
7227 * composite.c: Don't truncate sizes to 'int'.
7228 (composition_gstring_p, composition_reseat_it)
7229 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7230 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7231 not EMACS_UINT, for indexes.
5eb55db9 7232
0703a717
PE
7233 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7234
d6202519
PE
7235 * buffer.c: Include <verify.h>.
7236 (struct sortvec.priority, struct sortstr.priority):
8961a454 7237 Now EMACS_INT, not int.
c20998a7 7238 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7239 (struct sortstr.size, record_overlay_string)
7240 (struct sortstrlist.size, struct sortlist.used):
7241 Don't truncate size to int.
7242 (record_overlay_string): Check for size-calculation overflow.
d6202519 7243 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7244
d5a19415
JM
72452011-06-22 Jim Meyering <meyering@redhat.com>
7246
029529ac 7247 Don't leak an XBM-image-sized buffer
d5a19415
JM
7248 * image.c (xbm_load): Free the image buffer after using it.
7249
a9041e6c
PE
72502011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7251
7252 Port to Sun C.
7253 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7254 that Sun C diagnosed.
7255 * fns.c (secure_hash): Fix pointer signedness issue.
7256 * intervals.c (static_offset_intervals): New function.
7257 (offset_intervals): Use it.
7258
7f3f739f
LL
72592011-06-21 Leo Liu <sdl.web@gmail.com>
7260
7261 * deps.mk (fns.o):
7262 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7263 sha512.h.
7264
7265 * fns.c (secure_hash): Rename from crypto_hash_function and change
7266 the first arg to accept symbols.
5b66d427 7267 (Fsecure_hash): New primitive.
7f3f739f
LL
7268 (syms_of_fns): New symbols.
7269
76147d94
DD
72702011-06-20 Deniz Dogan <deniz@dogan.se>
7271
7272 * process.c (Fset_process_buffer): Clarify return value in
7273 docstring.
7274
7d7d0045
CY
72752011-06-18 Chong Yidong <cyd@stupidchicken.com>
7276
7277 * dispnew.c (add_window_display_history): Use BVAR.
7278
7279 * xdisp.c (debug_method_add): Use BVAR.
7280 (check_window_end, dump_glyph_matrix, dump_glyph)
7281 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7282
7283 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7284 Likewise.
7285
7286 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7287 check till after the cache is created in init_frame_faces.
7288
ff2bc410
SM
72892011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7290
7291 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7292
28177add
PE
72932011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7294
dd3482fe
PE
7295 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7296 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7297 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7298
393d71f3 7299 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7300 * fileio.c (Finsert_file_contents):
7301 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7302 Remove the old (too-loose) buffer overflow checks.
7303 They weren't needed, since make_gap checks for buffer overflow.
7304 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7305 The old code merely checked for Emacs fixnum overflow, and relied
7306 on undefined (wraparound) behavior. The new code avoids undefined
7307 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7308
2e6813b0 7309 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7310 Tune. Don't use wider integers than needed. Don't use alloca.
7311 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7312
599a9e4f
PE
7313 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7314
99561444
PE
7315 * insdel.c, lisp.h (buffer_overflow): New function.
7316 (insert_from_buffer_1, replace_range, replace_range_2):
7317 * insdel.c (make_gap_larger):
7318 * editfns.c (Finsert_char):
7319 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7320
28177add
PE
7321 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7322
e69dafad
PE
73232011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7324
4baa020d 7325 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7326
b1c46f02
PE
7327 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7328 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7329
e69dafad
PE
7330 * fileio.c: Don't assume EMACS_INT fits in off_t.
7331 (emacs_lseek): New static function.
7332 (Finsert_file_contents, Fwrite_region): Use it.
7333 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7334
566684ea
PE
7335 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7336
e6966cd6
PE
7337 * fns.c: Don't overflow int when computing a list length.
7338 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7339 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7340 truncation on 64-bit hosts. Check for QUIT every
7341 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7342 faster and is responsive enough.
7343 (Flength): Report an error instead of overflowing an integer.
7344 (Fsafe_length): Return a float if the value is not representable
7345 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7346 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7347 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7348
dd0b0efb
PE
7349 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7350 (header_size, word_size): New constants.
7351 (allocate_vectorlike): Don't check size overflow here.
7352 (allocate_vector): Check it here instead, since this is the only
7353 caller of allocate_vectorlike that could cause overflow.
7354 Check that the new vector's length is representable as a fixnum.
7355
86fe5cfe
PE
7356 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7357 The previous code was bogus. For example, next_almost_prime (32)
7358 returned 39, which is undesirable as it is a multiple of 3; and
7359 next_almost_prime (24) returned 25, which is a multiple of 5 so
7360 why was the code bothering to check for multiples of 7?
7361
80e88859
PE
7362 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7363
4a2f0ad6
PE
7364 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7365
f66c7cf8
PE
7366 Variadic C functions now count arguments with ptrdiff_t.
7367 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7368 Back then I didn't know that the Emacs coding style prefers signed int.
7369 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7370 were being counted with int, which may truncate counts on 64-bit
7371 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7372 * lisp.h (struct Lisp_Subr.function.aMANY)
7373 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7374 Arg counts are now ptrdiff_t, not size_t.
7375 All variadic functions and their callers changed accordingly.
7376 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7377 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7378 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7379 * callint.c (Fcall_interactively): Check arg count for overflow,
7380 to avoid potential buffer overrun. Use signed char, not 'int',
7381 for 'varies' array, so that we needn't bother to check its size
7382 calculation for overflow.
7383 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7384 * eval.c (apply_lambda):
7385 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7386 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7387 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7388
a1759b76
PE
7389 * callint.c (Fcall_interactively): Don't use index var as event count.
7390
d96be9fc
PE
7391 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7392 * mem-limits.h (SIZE): Remove; no longer used.
7393
a690a978 7394 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7395
578c21e6
PE
7396 Remove unnecessary casts.
7397 * xterm.c (x_term_init):
7398 * xfns.c (x_set_border_pixel):
7399 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7400 These aren't needed now that we assume ANSI C.
7401
96f53c6c
PE
7402 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7403 It's more likely to cause problems (due to unsigned overflow)
7404 than to cure them.
7405
83c77d31
PE
7406 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7407
ee2079f1
PE
7408 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7409
6da65536
PE
7410 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7411
7147c4a4
PE
7412 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7413
193e32d9
PE
7414 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7415
e5533da6
PE
7416 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7417
9910e595
PE
7418 GLYPH_CODE_FACE returns EMACS_INT, not int.
7419 * dispextern.h (merge_faces):
7420 * xfaces.c (merge_faces):
01103c44
PE
7421 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7422 Don't assume EMACS_INT fits in int.
9910e595 7423
2638320e
PE
7424 * character.h (CHAR_VALID_P): Remove unused parameter.
7425 * fontset.c, lisp.h, xdisp.c: All uses changed.
7426
045eb8d9
PE
7427 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7428
c1f134b5
PE
7429 * fns.c (concat): Minor tuning based on overflow analysis.
7430 This doesn't fix any bugs. Use int to hold character, instead
7431 of constantly refetching from Emacs object. Use XFASTINT, not
7432 XINT, for value known to be a character. Don't bother comparing
7433 a single byte to 0400, as it's always less.
7434
395fcb93 7435 * floatfns.c (Fexpt):
327eeec8
PE
7436 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7437
abbd3d23
PE
7438 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7439 for characters.
7440
684a03ef
PE
7441 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7442
0fed43f3
PE
7443 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7444 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7445 incorrectly succeed when S was a string, because 4294967386 was
7446 truncated before it was used.
7447
8fd02eb7
PE
7448 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7449 Otherwise, an out-of-range integer could cause undefined behavior
7450 on a 64-bit host.
7451
f8c86b69
PE
7452 * composite.c: Use int, not EMACS_INT, for characters.
7453 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7454 EMACS_INT, for values that are known to be in character range.
7455 This doesn't fix any bugs but is the usual style inside Emacs and
7456 may generate better code on 32-bit machines.
7457
34206dd2
PE
7458 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7459 This is for reasons similar to the recent CHAR_STRING fix.
7460 * charset.c (Fencode_char): Check that character arg is actually
7461 a character. Pass an int to ENCODE_CHAR.
7462 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7463 wider than 'int', as a compile-time check to prevent future regressions
7464 in this area.
7465
c5958d4c 7466 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7467
7468 Make sure a 64-bit char is never passed to CHAR_STRING.
7469 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7470 by silently ignoring the top 32 bits, allowing some values
7471 that were far too large to be valid characters.
7472 * character.h: Include <verify.h>.
7473 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7474 arguments are no wider than unsigned, as a compile-time check
7475 to prevent future regressions in this area.
7476 * data.c (Faset):
01103c44 7477 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7478 (Fsubst_char_in_region):
7479 * fns.c (concat):
7480 * xdisp.c (decode_mode_spec_coding):
7481 Adjust to CHAR_STRING's new requirement.
7482 * editfns.c (Finsert_char, Fsubst_char_in_region):
7483 * fns.c (concat): Check that character args are actually
7484 characters. Without this test, these functions did the wrong
7485 thing with wildly out-of-range values on 64-bit hosts.
7486
d37ca623
PE
7487 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7488 These casts should not be needed on 32-bit hosts, either.
7489 * keyboard.c (read_char):
7490 * lread.c (Fload): Remove casts to unsigned.
7491
ea204efb
PE
7492 * lisp.h (UNSIGNED_CMP): New macro.
7493 This fixes comparison bugs on 64-bit hosts.
7494 (ASCII_CHAR_P): Use it.
7495 * casefiddle.c (casify_object):
01103c44 7496 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7497 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7498 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7499 * dispextern.h (FACE_FROM_ID):
7500 * keyboard.c (read_char): Use UNSIGNED_CMP.
7501
41cb286c
PE
7502 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7503 not to EMACS_INT, to avoid GCC warning.
7504
4a1b9832
PE
7505 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7506
55daad71
PE
7507 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7508 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7509 isn't needed on 32-bit machines.
8f95c75c 7510
01103c44
PE
7511 * buffer.c (Fgenerate_new_buffer_name):
7512 Use EMACS_INT for count, not int.
0ceccced 7513 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7514
7515 * data.c (Qcompiled_function): Now static.
7516
c6f072e7
PE
7517 * window.c (window_body_lines): Now static.
7518
20ce5912
PE
7519 * image.c (gif_load): Rename local to avoid shadowing.
7520
9c4c5f81
PE
7521 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7522 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7523 * alloc.c (make_save_value): Integer argument is now of type
7524 ptrdiff_t, not int.
7525 (mark_object): Use ptrdiff_t, not int.
7526 * lisp.h (pD): New macro.
7527 * print.c (print_object): Use it.
7528
c0c5c8ae
PE
7529 * alloc.c: Use EMACS_INT, not int, to count objects.
7530 (total_conses, total_markers, total_symbols, total_vector_size)
7531 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7532 (total_free_floats, total_floats, total_free_intervals)
7533 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7534 Now EMACS_INT, not int. All uses changed.
7535 (Fgarbage_collect): Compute overall total using a double, so that
7536 integer overflow is less likely to be a problem. Check for overflow
7537 when converting back to an integer.
5a25e253
PE
7538 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7539 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7540 These were 'int' variables that could overflow on 64-bit hosts;
7541 they were never used, so remove them instead of repairing them.
211a0b2a 7542 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7543 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7544 Previously, this ceilinged at INT_MAX, but that doesn't work on
7545 64-bit machines.
e46bb31a 7546 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7547
c78baabf 7548 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7549 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7550 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7551 when a (possibly-narrower) signed value would do just as well.
7552 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7553
c9d624c6
PE
7554 * alloc.c: Catch some string size overflows that we were missing.
7555 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7556 for convenience in STRING_BYTES_MAX.
7557 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7558 The definition here is exact; the one in lisp.h was approximate.
7559 (allocate_string_data): Check for string overflow. This catches
7560 some instances we weren't catching before. Also, it catches
7561 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7562 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7563 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7564
c9d624c6
PE
7565 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7566 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7567 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7568
353032ce
PE
7569 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7570
2bccce07
PE
7571 * alloc.c (Fmake_string): Check for out-of-range init.
7572
0ac30604
SM
75732011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7574
7575 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7576
c195f2de
JD
75772011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7578
7579 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7580 xg_get_default_scrollbar_width.
7581
7582 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7583 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7584 (style_changed_cb): Call update_theme_scrollbar_width and call
7585 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7586 all frames (Bug#8505).
7587 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7588 Call gtk_window_set_resizable if HAVE_GTK3.
7589 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7590 and height if HAVE_GTK3 (Bug#8505).
7591 (scroll_bar_width_for_theme): New variable.
7592 (update_theme_scrollbar_width): New function.
7593 (xg_get_default_scrollbar_width): Move code to
7594 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7595 (xg_initialize): Call update_theme_scrollbar_width.
7596
7597 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7598
7599 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7600
e10ac9f1
MR
76012011-06-12 Martin Rudalics <rudalics@gmx.at>
7602
7603 * frame.c (make_frame): Call other_buffer_safely instead of
7604 other_buffer.
7605
7606 * window.c (temp_output_buffer_show): Call display_buffer with
7607 second argument Vtemp_buffer_show_specifiers and reset latter
7608 immediately after the call.
7609 (Vtemp_buffer_show_specifiers): New variable.
7610 (auto_window_vscroll_p, next_screen_context_lines)
7611 (Vscroll_preserve_screen_position): Remove leading asterisks from
7612 doc-strings.
7613
2d3c217e 76142011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7615
7b7f97e8 7616 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7617 * buffer.c (Qclone_number): Remove for now, as it's unused.
7618 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7619 (record_buffer): Remove unused local.
7620 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7621 (set_frame_buffer_list): Remove; unused.
7622 * frame.h (other_visible_frames): Remove decl.
7623 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7624 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7625 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7626 if HAVE_GPM.
7627 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7628 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7629 Define only if HAVE_GPM.
7630 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7631 (update_hints_inhibit): Remove; never set. All uses removed.
7632 * widgetprv.h (emacsFrameClassRec): Remove decl.
7633 * window.c (delete_deletable_window): Now returns void, since it
7634 wasn't returning anything.
7635 (compare_window_configurations): Remove unused locals.
7636 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7637 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7638 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7639 the same widths as pointers. This follows up on the 2011-05-06 patch.
7640 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7641 * xterm.h: Likewise.
7642 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7643
1384b89e
JB
76442011-06-12 Juanma Barranquero <lekktu@gmail.com>
7645
7646 * makefile.w32-in: Update dependencies.
7647 (LISP_H): Add lib/intprops.h.
7648
1100a63c
CY
76492011-06-11 Chong Yidong <cyd@stupidchicken.com>
7650
7651 * image.c (gif_load): Add animation frame delay to the metadata.
7652 (syms_of_image): Use DEFSYM. New symbol `delay'.
7653
6198ccd0
MR
76542011-06-11 Martin Rudalics <rudalics@gmx.at>
7655
7656 * window.c (delete_deletable_window): Re-add.
7657 (Fset_window_configuration): Rewrite to handle dead buffers and
7658 consequently deletable windows.
7659 (window_tree, Fwindow_tree): Remove. Supply functionality in
7660 window.el.
7661 (compare_window_configurations): Simplify code.
7662
b6e3633c
AS
76632011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7664
1ab0dee5
AS
7665 * image.c (imagemagick_load_image): Fix type mismatch.
7666 (Fimagemagick_types): Likewise.
7667
b6e3633c
AS
7668 * window.h (replace_buffer_in_windows): Declare.
7669
9397e56f
MR
76702011-06-11 Martin Rudalics <rudalics@gmx.at>
7671
7672 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7673 Qclone_number. Remove external declaration of Qdelete_window.
7674 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7675 code.
640c8776
SM
7676 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7677 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7678 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7679 buffer list implementation.
7680 (other_buffer_safely): New function.
7681 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7682 calls to replace_buffer_in_windows and
7683 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7684 if allowed.
7685 (record_buffer): Inhibit quitting and rewrite using quittable
7686 functions. Run Qbuffer_list_update_hook if allowed.
7687 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7688 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7689 Move switch-to-buffer to window.el.
9397e56f
MR
7690 (bury-buffer): Move to window.el.
7691 (Vbuffer_list_update_hook): New variable.
7692
7693 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7694 section.
7695
7696 * window.h (resize_frame_windows): Move up in code.
7697 (Fwindow_frame): Remove EXFUN.
7698 (replace_buffer_in_all_windows): Remove prototype.
7699 (replace_buffer_in_windows_safely): Add prototype.
7700
7701 * window.c: Declare Qdelete_window static again. Move down
7702 declaration of select_count.
7703 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7704 (Fother_window): Move to window.el.
7705 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7706 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7707 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7708 window.el.
7709 (replace_buffer_in_windows): Implement by calling
7710 Qreplace_buffer_in_windows.
7711 (replace_buffer_in_all_windows): Remove with some functionality
7712 moved into replace_buffer_in_windows_safely.
7713 (replace_buffer_in_windows_safely): New function.
7714 (select_window_norecord, select_frame_norecord): Move in front
7715 of run_window_configuration_change_hook. Remove now obsolete
7716 declarations.
640c8776
SM
7717 (Fset_window_buffer): Rewrite doc-string.
7718 Call Qrecord_window_buffer.
9397e56f
MR
7719 (keys_of_window): Move binding for other-window to window.el.
7720
b50691aa
CY
77212011-06-11 Chong Yidong <cyd@stupidchicken.com>
7722
7723 * dispextern.h (struct image): Replace data member, whose int_val
7724 and ptr_val fields were not used by anything, with a single
7725 lisp_val object.
7726
7727 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7728 (gif_clear_image, gif_load, imagemagick_load_image)
7729 (gs_clear_image, gs_load): Callers changed.
7730
3f754b86
PE
77312011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7732
cca69397
PE
7733 * buffer.h: Include <time.h>, for time_t.
7734 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7735
109e28d0
PE
7736 Fix minor problems found by static checking.
7737
60737f02
PE
7738 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7739
4b66faf3
PE
7740 Make identifiers static if they are not used in other modules.
7741 * data.c (Qcompiled_function, Qframe, Qvector):
7742 * image.c (QimageMagick, Qsvg):
7743 * minibuf.c (Qmetadata):
7744 * window.c (resize_window_check, resize_root_window): Now static.
7745 * window.h (resize_window_check, resize_root_window): Remove decls.
7746
109e28d0
PE
7747 * window.c (window_deletion_count, delete_deletable_window):
7748 Remove; unused.
46a4ce9e
PE
7749 (window_body_lines): Now static.
7750 (Fdelete_other_windows_internal): Mark vars as initialized.
7751 Make sure 'resize_failed' is initialized.
7752 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7753 (resize_window_apply): Remove unused local.
7754 * window.h (delete_deletable_window): Remove decl.
7755
109e28d0 7756 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7757 (imagemagick_load_image): Fix pointer signedness problem by changing
7758 last arg from unsigned char * to char *. All uses changed.
7759 Also, fix a local for similar reasons.
7760 Remove unused locals. Remove locals to avoid shadowing.
7761 (fn_rsvg_handle_free): Remove; unused.
7762 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7763 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7764
3f754b86
PE
7765 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7766
2547adb1
CY
77672011-06-10 Chong Yidong <cyd@stupidchicken.com>
7768
7769 * image.c (gif_load): Fix omitted cast error introduced by
7770 2011-06-06 change.
7771
2c8e37d4
MR
77722011-06-10 Martin Rudalics <rudalics@gmx.at>
7773
7774 * window.h (resize_proportionally, orig_total_lines)
7775 (orig_top_line): Remove from window structure.
7776 (set_window_height, set_window_width, change_window_heights)
7777 (Fdelete_window): Remove prototypes.
7778 (resize_frame_windows): Remove duplicate declaration.
7779
440a42e3
EZ
77802011-06-10 Eli Zaretskii <eliz@gnu.org>
7781
7782 * window.h (resize_frame_windows, resize_window_check)
7783 (delete_deletable_window, resize_root_window)
7784 (resize_frame_windows): Declare prototypes.
7785
7786 * window.c (resize_window_apply): Make definition be "static" to
7787 match the prototype.
7788
562dd5e9
MR
77892011-06-10 Martin Rudalics <rudalics@gmx.at>
7790
7791 * window.c: Remove declarations of Qwindow_size_fixed,
7792 window_min_size_1, window_min_size_2, window_min_size,
7793 size_window, window_fixed_size_p, enlarge_window, delete_window.
7794 Remove static from declaration of Qdelete_window, it's
7795 temporarily needed by Fbury_buffer.
7796 (replace_window): Don't assign orig_top_line and
7797 orig_total_lines.
7798 (Fdelete_window, delete_window): Remove. Window deletion is
7799 handled by window.el.
640c8776
SM
7800 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7801 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7802 (Fdelete_other_windows): Remove. Deleting other windows is
7803 handled by window.el.
7804 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7805 handled in window.el.
7806 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7807 Window minimum sizes are handled in window.el.
7808 (shrink_windows, size_window, set_window_height)
7809 (set_window_width, change_window_heights, window_height)
7810 (window_width, CURBEG, CURSIZE, enlarge_window)
7811 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7812 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7813 handled in window.el.
7814 (make_dummy_parent): Rename to make_parent_window and give it a
7815 second argument horflag.
7816 (make_window): Don't set resize_proportionally any more.
7817 (Fsplit_window): Remove. Windows are split in window.el.
7818 (save_restore_action, save_restore_orig_size)
7819 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7820 Resize mini windows in window.el.
7821 (grow_mini_window, shrink_mini_window): Implement by calling
7822 Qresize_root_window_vertically, resize_window_check and
7823 resize_window_apply.
640c8776
SM
7824 (saved_window, Fset_window_configuration, save_window_save):
7825 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7826 resize_proportionally.
7827 (window_min_height, window_min_width): Move to window.el.
7828 (keys_of_window): Move bindings for delete-other-windows,
7829 split-window, delete-window and enlarge-window to window.el.
7830
7831 * buffer.c: Temporarily extern Qdelete_window.
7832 (Fbury_buffer): Temporarily call Qdelete_window instead of
7833 Fdelete_window (Fbury_buffer will move to window.el soon).
7834
7835 * frame.c (set_menu_bar_lines_1): Remove code handling
7836 orig_top_line and orig_total_lines.
7837
7838 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7839 set_window_height but set heights directly.
7840 (change_frame_size_1): Use resize_frame_windows.
7841
7842 * xdisp.c (init_xdisp): Don't use set_window_height but set
7843 heights directly.
7844
640c8776
SM
7845 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7846 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7847 run_window_configuration_change_hook.
7848
7849 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7850 instead of change_window_heights and run
7851 run_window_configuration_change_hook.
7852
1a13852e
MR
78532011-06-09 Martin Rudalics <rudalics@gmx.at>
7854
7855 * window.c (replace_window): Rename second argument REPLACEMENT to
7856 NEW. New third argument SETFLAG. Rewrite.
7857 (delete_window, make_dummy_parent): Call replace_window with
7858 third argument 1.
7859 (window_list_1): Move down in code.
7860 (run_window_configuration_change_hook): Move set_buffer part
7861 before select_frame_norecord part in order to unwind correctly.
7862 Rename count1 to count.
7863 (recombine_windows, delete_deletable_window, resize_root_window)
7864 (Fdelete_other_windows_internal)
7865 (Frun_window_configuration_change_hook, make_parent_window)
7866 (resize_window_check, resize_window_apply, Fresize_window_apply)
7867 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7868 (Fdelete_window_internal, Fresize_mini_window_internal):
7869 New functions.
1a13852e
MR
7870 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7871
f3d1777e
MR
78722011-06-08 Martin Rudalics <rudalics@gmx.at>
7873
496e208e
MR
7874 * window.h (window): Add some new members to window structure -
7875 normal_lines, normal_cols, new_total, new_normal, clone_number,
7876 splits, nest, prev_buffers, next_buffers.
7877 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7878 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7879
f3d1777e
MR
7880 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7881 Remove.
496e208e
MR
7882 (make_dummy_parent): Set new members of windows structure.
7883 (make_window): Move down in code. Handle new members of window
7884 structure.
7885 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7886 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7887 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7888 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7889 (Fset_window_next_buffers, Fset_window_clone_number):
7890 New functions.
496e208e
MR
7891 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7892 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7893 Doc-string fixes.
7894 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7895 Argument WINDOW can be now internal window too.
7896 (Fwindow_use_time): Move up in code.
7897 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7898 Rewrite doc-string.
7899 (Fset_window_configuration, saved_window)
7900 (Fcurrent_window_configuration, save_window_save): Handle new
7901 members of window structure.
b9e809c2
MR
7902 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7903 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7904 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7905 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7906 Qget_mru_window, Qresize_root_window,
7907 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7908 Qauto_buffer_name; staticpro them.
f3d1777e 7909
abde8f8c
MR
79102011-06-07 Martin Rudalics <rudalics@gmx.at>
7911
7912 * window.c (Fwindow_total_size, Fwindow_left_column)
7913 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7914 (Fwindow_list_1): New functions.
7915 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7916 (Fwindow_width, Fscroll_left, Fscroll_right):
7917 Use window_body_cols instead of window_box_text_cols.
7918 (delete_window, Fset_window_configuration):
7919 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7920 (delete_all_subwindows): Take a window as argument and not a
7921 structure. Rewrite.
190b47e6
MR
7922 (window_loop): Remove handling of GET_LRU_WINDOW and
7923 GET_LARGEST_WINDOW.
7924 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7925
7926 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7927 window_box_text_cols. delete_all_subwindows now takes a
7928 Lisp_Object as argument.
abde8f8c 7929
640c8776
SM
7930 * indent.c (compute_motion, Fcompute_motion):
7931 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7932
fa8a67e6
MR
7933 * frame.c (delete_frame): Call delete_all_subwindows with root
7934 window as argument.
7935
a54e3482
DC
79362011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7937
7938 * fns.c (Fputhash): Document return value.
7939
60002bf5
CY
79402011-06-06 Chong Yidong <cyd@stupidchicken.com>
7941
7942 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7943
0c671da6 79442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7945
b862a52a 7946 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7947
be44ca6c
PE
7948 Check for overflow when converting integer to cons and back.
7949 * charset.c (Fdefine_charset_internal, Fdecode_char):
7950 Use cons_to_unsigned to catch overflow.
7951 (Fencode_char): Use INTEGER_TO_CONS.
7952 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7953 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7954 * data.c (long_to_cons, cons_to_long): Remove.
7955 (cons_to_unsigned, cons_to_signed): New functions.
7956 These signal an error for invalid or out-of-range values.
7957 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7958 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7959 * font.c (Ffont_variation_glyphs):
7960 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7961 * lisp.h: Include <intprops.h>.
7962 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7963 (cons_to_signed, cons_to_unsigned): New decls.
7964 (long_to_cons, cons_to_long): Remove decls.
7965 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7966 (Fprimitive_undo): Use CONS_TO_INTEGER.
7967 * xfns.c (Fx_window_property): Likewise.
7968 * xselect.c: Include <limits.h>.
7969 (x_own_selection, selection_data_to_lisp_data):
7970 Use INTEGER_TO_CONS.
7971 (x_handle_selection_request, x_handle_selection_clear)
7972 (x_get_foreign_selection, Fx_disown_selection_internal)
7973 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7974 (lisp_data_to_selection_data): Use cons_to_unsigned.
7975 (x_fill_property_data): Use cons_to_signed.
7976 Report values out of range.
7977
d1f3d2af
PE
7978 Check for buffer and string overflow more precisely.
7979 * buffer.h (BUF_BYTES_MAX): New macro.
7980 * lisp.h (STRING_BYTES_MAX): New macro.
7981 * alloc.c (Fmake_string):
7982 * character.c (string_escape_byte8):
7983 * coding.c (coding_alloc_by_realloc):
7984 * doprnt.c (doprnt):
7985 * editfns.c (Fformat):
7986 * eval.c (verror):
7987 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7988 since they may not be the same number.
7989 * editfns.c (Finsert_char):
7990 * fileio.c (Finsert_file_contents):
7991 Likewise for BUF_BYTES_MAX.
7992
dd52fcea
PE
7993 * image.c: Use ptrdiff_t, not int, for sizes.
7994 (slurp_file): Switch from int to ptrdiff_t.
7995 All uses changed.
7996 (slurp_file): Check that file size fits in both size_t (for
7997 malloc) and ptrdiff_t (for sanity and safety).
7998
7f9bbdbb
PE
7999 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8000 if b->modtime has its maximal value.
8001
dfe18f82
PE
8002 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8003
84acfcf0
PE
8004 Don't assume time_t can fit into int.
8005 * buffer.h (struct buffer.modtime): Now time_t, not int.
8006 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8007 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8008
ccd9a01a
PE
8009 Minor fixes for signed vs unsigned integers.
8010 * character.h (MAYBE_UNIFY_CHAR):
8011 * charset.c (maybe_unify_char):
8012 * keyboard.c (read_char, reorder_modifiers):
8013 XINT -> XFASTINT, since the integer must be nonnegative.
8014 * ftfont.c (ftfont_spec_pattern):
8015 * keymap.c (access_keymap, silly_event_symbol_error):
8016 XUINT -> XFASTINT, since the integer must be nonnegative.
8017 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8018 since it makes no difference and we prefer signed.
8019 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8020 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8021 nonnegative.
8022
d6d100dd
SM
80232011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8024
8025 * window.h (Fwindow_frame): Declare.
8026
2b6148e4
PE
80272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8028
8029 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8030 (SPARE_MEMORY): Always define.
8031 (LARGE_REQUEST): Remove.
8032 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8033
f230ecc9
MR
80342011-06-06 Martin Rudalics <rudalics@gmx.at>
8035
727e958e
MR
8036 * lisp.h: Move EXFUNS for Fframe_root_window,
8037 Fframe_first_window and Fset_frame_selected_window to window.h.
8038
8039 * window.h: Move EXFUNS for Fframe_root_window,
8040 Fframe_first_window and Fset_frame_selected_window here from
8041 lisp.h.
8042
8043 * frame.c (Fwindow_frame, Fframe_first_window)
8044 (Fframe_root_window, Fframe_selected_window)
8045 (Fset_frame_selected_window): Move to window.c.
8046 (Factive_minibuffer_window): Move to minibuf.c.
8047 (Fother_visible_frames_p): New function.
8048
8049 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8050
f230ecc9
MR
8051 * window.c (decode_window, decode_any_window): Move up in code.
8052 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8053 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8054 (Fwindow_buffer): Move up and rewrite doc-string.
8055 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8056 (Fwindow_prev): New functions.
727e958e
MR
8057 (Fwindow_frame): Move here from frame.c. Accept any window as
8058 argument.
8059 (Fframe_root_window, Fframe_first_window)
8060 (Fframe_selected_window): Move here from frame.c. Accept frame
8061 or arbitrary window as argument. Update doc-strings.
8062 (Fminibuffer_window): Move up in code.
8063 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8064 (Fset_frame_selected_window): Move here from frame.c.
8065 Marginal rewrite.
727e958e
MR
8066 (Fselected_window, select_window, Fselect_window): Move up in
8067 code. Minor doc-string fixes.
f230ecc9 8068
4d09bcf6
PE
80692011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8070
8071 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8072 Do not assume that spare memory exists; that assumption is valid
8073 only if SYSTEM_MALLOC.
8074 (LARGE_REQUEST): New macro, so that the issue of large requests
8075 is separated from the issue of spare memory.
8076
810928a2
AS
80772011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8078
172418ad
AS
8079 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8080 format. (Bug#8806)
8081
43f862f7
AS
8082 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8083
810928a2
AS
8084 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8085 before statements.
8086
a059fe24
JD
80872011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8088
8089 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8090
8091 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8092
8093 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8094 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8095
989bf368
JB
80962011-06-05 Juanma Barranquero <lekktu@gmail.com>
8097
8098 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8099
4b80f674
CY
81002011-06-04 Chong Yidong <cyd@stupidchicken.com>
8101
8102 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8103 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8104 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8105 New error handlers.
4b80f674
CY
8106 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8107 Obey Vx_select_enable_clipboard_manager. Catch errors in
8108 x_clipboard_manager_save (Bug#8779).
8109 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8110 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8111
99a33b77 81122011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8113
8114 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8115
99a33b77 81162011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8117
8118 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8119 in the current matrix if keep_current_p is non-zero.
8120
8264569d
EZ
81212011-06-04 Eli Zaretskii <eliz@gnu.org>
8122
8123 * bidi.c (bidi_level_of_next_char): Fix last change.
8124
57f97249
EZ
81252011-06-03 Eli Zaretskii <eliz@gnu.org>
8126
fec2107c 8127 Support bidi reordering of text covered by display properties.
57f97249 8128
fec2107c
EZ
8129 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8130 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8131 (bidi_cache_search, bidi_cache_iterator_state)
8132 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8133 (bidi_level_of_next_char, bidi_move_to_visually_next):
8134 Support character positions inside a run of characters covered by a
fec2107c
EZ
8135 display string.
8136 (bidi_paragraph_init, bidi_resolve_explicit_1)
8137 (bidi_level_of_next_char): Call bidi_fetch_char and
8138 bidi_fetch_char_advance instead of FETCH_CHAR and
8139 FETCH_CHAR_ADVANCE.
8140 (bidi_init_it): Initialize new members.
8141 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8142 definitions.
8143 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8144 instead of using explicit *_CHAR codes.
d6d100dd
SM
8145 (bidi_resolve_explicit, bidi_resolve_weak):
8146 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8147 bidirectional text is supported only in multibyte buffers.
8148 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8149 it to initialize the frame_window_p member of struct bidi_it.
8150 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8151 (bidi_resolve_explicit, bidi_resolve_weak)
8152 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8153 bidi_it->nchars is non-positive.
8154 (bidi_level_of_next_char): Don't try to lookup the cache for the
8155 next/previous character if nothing is cached there yet, or if we
8156 were just reseat()'ed to a new position.
c40e2fb2 8157
0e14fe90
EZ
8158 * xdisp.c (set_cursor_from_row): Set start and stop points
8159 according to the row's direction when priming the loop that looks
8160 for the glyph on which to display cursor.
8161 (single_display_spec_intangible_p): Function deleted.
8162 (display_prop_intangible_p): Reimplement to call
8163 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8164 Accept 3 additional arguments needed by handle_display_spec.
8165 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8166 values: lists, `(when COND...)' forms, etc.
8167 (single_display_spec_string_p): Support property values that are
8168 lists with the argument STRING its top-level element.
8169 (display_prop_string_p): Fix the condition for processing a
8170 property that is a list to be consistent with handle_display_spec.
fec2107c 8171 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8172 last portion of handle_display_prop.
8173 (compute_display_string_pos): Accept additional argument
8174 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8175 value of a `display' property is a "replacing spec".
8176 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8177 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8178 the display property, but just return a value indicating whether
8179 the display property will replace the characters it covers.
8180 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8181 frame_window_p members of struct bidi_it.
d6d100dd
SM
8182 (compute_display_string_pos, compute_display_string_end):
8183 New functions.
fec2107c
EZ
8184 (push_it): Accept second argument POSITION, where pop_it should
8185 jump to continue iteration.
8186 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8187
fec2107c
EZ
8188 * keyboard.c (adjust_point_for_property): Adjust the call to
8189 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8190
8191 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8192 (bidi_init_it): Update prototypes.
8193 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8194 (compute_display_string_pos, compute_display_string_end):
8195 Declare prototypes.
fec2107c
EZ
8196 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8197 EMACS_INT.
fc6f18ce 8198
40087514 81992011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8200
57f53182
PE
8201 Malloc failure behavior now depends on size of allocation.
8202 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8203 * lisp.h: Change signatures accordingly.
8204 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8205 All callers changed. (Bug#8762)
8206
8207 * gnutls.c: Use Emacs's memory allocators.
8208 Without this change, the gnutls library would invoke malloc etc.
8209 directly, which causes problems on non-SYNC_INPUT hosts, and which
8210 runs afoul of improving memory_full behavior. (Bug#8761)
8211 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8212 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8213 xfree instead of the default malloc, realloc, free.
8214 (Fgnutls_boot): No need to check for memory allocation failure,
8215 since xmalloc does that for us.
8216
ac32cd99 8217 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8218 * category.c (hash_get_category_set):
8219 * ccl.c (ccl_driver):
8220 * charset.c (Fdefine_charset_internal):
8221 * charset.h (struct charset.hash_index):
8222 * composite.c (get_composition_id, gstring_lookup_cache)
8223 (composition_gstring_put_cache):
8224 * composite.h (struct composition.hash_index):
8225 * dispextern.h (struct image.hash):
8226 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8227 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8228 (hashfn_equal, hashfn_user_defined, make_hash_table)
8229 (maybe_resize_hash_table, hash_lookup, hash_put)
8230 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8231 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8232 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8233 * image.c (make_image, search_image_cache, lookup_image)
8234 (xpm_put_color_table_h):
8235 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8236 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8237 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8238 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8239 * alloc.c (allocate_vectorlike):
8240 Check for overflow in vector size calculations.
8241 * ccl.c (ccl_driver):
8242 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8243 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8244 need to be updated by these changes.
40087514
PE
8245 * fns.c (make_hash_table, maybe_resize_hash_table):
8246 Check for integer overflow with large hash tables.
0de4bb68
PE
8247 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8248 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8249 (SXHASH_REDUCE): New macro.
8250 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8251 Use it instead of discarding useful hash info with large hash values.
8252 (sxhash_float): New function.
8253 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8254 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8255 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8256 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8257 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8258 Adjust signatures to match updated version of code.
8259 (consing_since_gc): Now EMACS_INT, since a single hash table can
8260 use more than INT_MAX bytes.
8261
698d32e2
DN
82622011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8263
8264 Make it possible to build with GCC-4.6+ -O2 -flto.
8265
8266 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8267
fd6fa53f
SM
82682011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8269
8270 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8271 Call minibuffer-inactive-mode.
8272
864db017
JB
82732011-05-31 Juanma Barranquero <lekktu@gmail.com>
8274
8275 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8276 Update dependencies.
8277
2ad0baf4
DN
82782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8279
8280 * data.c (init_data): Remove code for UTS, this system is not
8281 supported anymore.
8282
4fcc2638
DN
82832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8284
8285 Don't force ./temacs to start in terminal mode.
8286
8287 * frame.c (make_initial_frame): Initialize faces in all cases, not
8288 only when CANNOT_DUMP is defined.
8289 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8290
c56e0fd5
DN
82912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8292
8293 * dispnew.c (add_window_display_history): Use const for the string
8294 pointer. Remove declaration, not needed.
8295
333d54da 82962011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8297
55d4c1b2 8298 Use 'inline', not 'INLINE'.
333d54da 8299 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8300 * alloc.c, fontset.c (INLINE): Remove.
8301 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8302 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8303 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8304 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8305 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8306
738db178
DN
83072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8308
8309 Make it possible to run ./temacs.
8310
8311 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8312 syms_of_callproc does the same thing. Remove test for
8313 "initialized", do it in the caller.
8314 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8315
620c53a6
SM
83162011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8317
8318 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8319 (read_minibuf): Use get_minibuffer.
8320 (syms_of_minibuf): Use DEFSYM.
8321 (Qmetadata): New var.
8322 * data.c (Qbuffer): Don't make it static.
8323 (syms_of_data): Use DEFSYM.
8324
e003a292
PE
83252011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8326
8327 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8328 (CCL_CODE_MIN): New macro.
8329
ed008a6d
PE
83302011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8331
3687c2ef
PE
8332 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8333
ed008a6d
PE
8334 * eval.c (Qdebug): Now static.
8335 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8336 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8337 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8338
d66c4c7c
CY
83392011-05-29 Chong Yidong <cyd@stupidchicken.com>
8340
8341 * image.c: Various fixes to ImageMagick code comments.
8342 (Fimagemagick_types): Doc fix.
8343
5fbc2025
PE
83442011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8345
0196f88a
PE
8346 Minor fixes prompted by GCC 4.6.0 warnings.
8347
8348 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8349
5fbc2025
PE
8350 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8351 (x_clipboard_manager_save_all): Move extern decl to ...
8352 * xterm.h: ... here, so that it can be checked for consistency.
8353
1dd3c2d9
CY
83542011-05-29 Chong Yidong <cyd@stupidchicken.com>
8355
8356 * xselect.c (x_clipboard_manager_save_frame)
8357 (x_clipboard_manager_save_all): New functions.
8358 (Fx_clipboard_manager_save): Lisp function deleted.
8359
8360 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8361 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8362
8363 * xterm.h: Update prototype.
8364
5ba6571d
WX
83652011-05-28 William Xu <william.xwl@gmail.com>
8366
8367 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8368 exiting (Bug#8239).
8369
3eaff834
JM
83702011-05-28 Jim Meyering <meyering@redhat.com>
8371
e1900994 8372 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8373 * fns.c (to_uchar): Define.
8374 (crypto_hash_function): Use it to convert some newly-signed
8375 variables to unsigned, to avoid sign-extension bugs. For example,
8376 without this change, (md5 "truc") would evaluate to
8377 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8378 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8379 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8380
0f6990a7
PE
83812011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8382
8383 Integer overflow fixes.
c8a9ca5a 8384
08686060
PE
8385 * dbusbind.c: Serial number integer overflow fixes.
8386 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8387 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8388 to hold a serial number that is too large for a fixnum.
8389 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8390 Check for serial numbers out of range. Decode any serial number
59568bf0 8391 that was so large that it became a float. (Bug#8722)
08686060 8392
2d1fc3c7
PE
8393 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8394 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8395 Use XFASTINT rather than XUINT when numbers are nonnegative.
8396 (xd_append_arg, Fdbus_method_return_internal):
8397 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8398 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8399 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8400 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8401 (Bug#8722)
2d1fc3c7 8402
c8a9ca5a
PE
8403 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8404
519e1d69
PE
8405 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8406
6df6ae42 8407 ccl: Add integer overflow checks.
30569699
PE
8408 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8409 (IN_INT_RANGE): New macros.
8410 (ccl_driver): Use them to check for integer overflow when
8411 decoding a CCL program. Many of the new checks are whether XINT (x)
8412 fits in int; it doesn't always, on 64-bit hosts. The new version
8413 doesn't catch all possible integer overflows, but it's an
847044ea 8414 improvement. (Bug#8719)
30569699 8415
c11285dc
PE
8416 * alloc.c (make_event_array): Use XINT, not XUINT.
8417 There's no need for unsigned here.
8418
fdccd48e
PE
8419 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8420 This follows up to the 2011-05-06 change that substituted uintptr_t
8421 for EMACS_INT. This case wasn't caught back then.
8422
37910ab2
PE
8423 Rework Fformat to avoid integer overflow issues.
8424 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8425 now (part of C89). Include <verify.h>.
8426 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8427 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8428 (Fformat): Avoid the prepass trying to compute sizes; it was only
8429 approximate and thus did not catch overflow reliably. Instead, walk
8430 through the format just once, formatting and computing sizes as we go,
8431 checking for integer overflow at every step, and allocating a larger
8432 buffer as needed. Keep track separately whether the format is
8433 multibyte. Keep only the most-recently calculated precision, rather
8434 than them all. Record whether each argument has been converted to
8435 string. Use EMACS_INT, not int, for byte and char and arg counts.
8436 Support field widths and precisions larger than INT_MAX. Avoid
8437 sprintf's undefined behavior with conversion specifications such as %#d
8438 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8439 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8440 formatting out-of-range floating point numbers with int
9173deec 8441 formats. (Bug#8668)
37910ab2 8442
2e6578fb
PE
8443 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8444
0ae6bdee
PE
8445 * data.c: Avoid integer truncation in expressions involving floats.
8446 * data.c: Include <intprops.h>.
8447 (arith_driver): When there's an integer overflow in an expression
8448 involving floating point, convert the integers to floating point
8449 so that the resulting value does not suffer from catastrophic
8450 integer truncation. For example, on a 64-bit host (* 4
8451 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8452 Do not rely on undefined behavior after integer overflow.
8453
de883a70
PE
8454 merge count_size_as_multibyte, parse_str_to_multibyte
8455 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8456 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8457 Check for integer overflow.
8458 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8459 since it's now a duplicate of the other. This is more of
8460 a character than a buffer op, so better that it's in character.c.
8461 * fns.c, print.c: Adjust to above changes.
8462
2ff916cb
PE
84632011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8464
8465 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8466
f1b54466
PE
84672011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8468
fb1ac845
PE
8469 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8470 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8471 (x_clipboard_manager_save): Now static.
8472 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8473
f1b54466
PE
8474 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8475 (crypto_hash_function): Now static.
8476 Fix pointer signedness problems. Avoid unnecessary initializations.
8477
a9f737ee
CY
84782011-05-27 Chong Yidong <cyd@stupidchicken.com>
8479
8480 * termhooks.h (Vselection_alist): Make it terminal-local.
8481
8482 * terminal.c (create_terminal): Initialize it.
8483
8484 * xselect.c: Support for clipboard managers.
8485 (Vselection_alist): Move to termhooks.h as terminal-local var.
8486 (LOCAL_SELECTION): New macro.
8487 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8488 (symbol_to_x_atom): Remove gratuitous arg.
8489 (x_handle_selection_request, lisp_data_to_selection_data)
8490 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8491 (x_own_selection, x_get_local_selection, x_convert_selection):
8492 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8493 (some_frame_on_display): Delete unused function.
8494 (Fx_own_selection_internal, Fx_get_selection_internal)
8495 (Fx_disown_selection_internal, Fx_selection_owner_p)
8496 (Fx_selection_exists_p): New optional frame arg.
8497 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8498 (x_handle_selection_clear): Don't treat other terminals with the
8499 same keyboard specially. Use the terminal-local Vselection_alist.
8500 (x_clear_frame_selections): Use Frun_hook_with_args.
8501
8502 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8503
8504 * xterm.h: Add support for those atoms.
8505
e067f0c1
CY
85062011-05-26 Chong Yidong <cyd@stupidchicken.com>
8507
8508 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8509 (converted_selections, conversion_fail_tag): New global variables.
8510 (x_selection_request_lisp_error): Free the above.
8511 (x_get_local_selection): Remove unnecessary code.
8512 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8513 of converted selections stored in converted_selections.
8514 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8515 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8516 (x_convert_selection): New function.
8517 (x_handle_selection_event): Simplify.
8518 (x_get_foreign_selection): Don't ignore incoming requests while
8519 waiting for an answer; this will fail when we implement
8520 SAVE_TARGETS, and seems unnecessary anyway.
8521 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8522 (Vx_sent_selection_functions): Doc fix.
8523
0f4aebc0
LL
85242011-05-26 Leo Liu <sdl.web@gmail.com>
8525
8526 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8527
e61124cd
YM
85282011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8529
8530 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8531
8532 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8533 for fringe update if it has periodic bitmap.
ac389d0c 8534 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8535 and fringe_bitmap_periodic_p.
8536
8537 * fringe.c (get_fringe_bitmap_data): New function.
8538 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8539 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8540 row. Mark glyph row for fringe update if periodicity changed.
8541
8542 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8543 for fringe update unless it has periodic bitmap.
8544
f16d9837
KH
85452011-05-25 Kenichi Handa <handa@m17n.org>
8546
8547 * xdisp.c (get_next_display_element): Set correct it->face_id for
8548 a static composition.
8549
e1b90ef6
LL
85502011-05-24 Leo Liu <sdl.web@gmail.com>
8551
8552 * deps.mk (fns.o):
8553 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8554
8555 * fns.c (crypto_hash_function, Fsha1): New function.
8556 (Fmd5): Use crypto_hash_function.
8557 (syms_of_fns): Add Ssha1.
8558
7400048f
PE
85592011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8560
8561 * gnutls.c: Remove unused macros.
8562 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8563 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8564 Remove macros that are defined and never used.
8565 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8566
abb71cf4
CY
85672011-05-22 Chong Yidong <cyd@stupidchicken.com>
8568
8569 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8570 (Fx_get_selection_internal): Minor cleanup.
8571 (Fx_own_selection_internal): Rename arguments for consistency with
8572 select.el.
8573
6307db39
PE
85742011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8575
8576 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8577
f3d4e0a4
CY
85782011-05-22 Chong Yidong <cyd@stupidchicken.com>
8579
8580 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8581
4d8ade89
YM
85822011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8583
8584 * dispnew.c (scrolling_window): Don't exclude the case that the
8585 last enabled row in the desired matrix touches the bottom boundary.
8586
32078c8d
GM
85872011-05-21 Glenn Morris <rgm@gnu.org>
8588
8589 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8590 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8591 and add some more files.
32078c8d 8592
7285dc67
EZ
85932011-05-20 Eli Zaretskii <eliz@gnu.org>
8594
8595 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8596 report_file_error introduced by the change from 2011-05-07.
8597
89d1bd22
PE
85982011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8599
8600 * systime.h (Time): Define only if emacs is defined.
8601 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8602 where the include path doesn't have X11/X.h by default. See
8603 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8604
cd394be1 86052011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8606
8607 * composite.c (find_automatic_composition): Fix previous change.
8608
b9704ad9
GM
86092011-05-20 Glenn Morris <rgm@gnu.org>
8610
8611 * lisp.mk: New file, split from Makefile.in.
8612 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8613 (shortlisp): Remove.
8614 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8615
4a720484
GM
86162011-05-19 Glenn Morris <rgm@gnu.org>
8617
8618 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8619 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8620 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8621 (lisp): Set the order to that of loadup.el.
8622 (shortlisp): Make it a copy of $lisp.
8623 (SOME_MACHINE_LISP): Remove.
8624 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8625 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8626
a28d4396
KH
86272011-05-18 Kenichi Handa <handa@m17n.org>
8628
8629 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8630 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8631 (find_automatic_composition): Mostly rewrite for efficiency.
8632
a2b1fa8e
JB
86332011-05-18 Juanma Barranquero <lekktu@gmail.com>
8634
8635 * makefile.w32-in: Update dependencies.
8636
8e1f5610
CS
86372011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8638
8639 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8640 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8641
7025ee00 86422011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8643
cdfa6eab
PE
8644 Fix some integer overflow issues, such as string length overflow.
8645
06d6db33
PE
8646 * insdel.c (count_size_as_multibyte): Check for string overflow.
8647
2b4560a8
PE
8648 * character.c (lisp_string_width): Check for string overflow.
8649 Use EMACS_INT, not int, for string indexes and lengths; in
8650 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8651 the resulting string length overflows an EMACS_INT; instead,
8652 report a string overflow if no precision given. When checking for
8653 precision exhaustion, use a check that cannot possibly have
8654 integer overflow. (Bug#8675)
8655 * character.h (lisp_string_width): Adjust to new signature.
8656
cb93f9be
PE
8657 * alloc.c (string_overflow): New function.
8658 (Fmake_string): Use it. This doesn't change behavior, but saves
8659 a few bytes and will simplify future changes.
8660 * character.c (string_escape_byte8): Likewise.
8661 * lisp.h (string_overflow): New decl.
8662
1a1f3366
PE
8663 Fixups, following up to the user-interface timestamp change.
8664 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8665 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8666 * msdos.c (mouse_get_pos): Likewise.
8667 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8668 * w32gui.h (Time): Define by including "systime.h" rather than by
8669 declaring it ourselves. (Bug#8664)
8670
d4e3e4d3
PE
8671 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8672 * image.c (clear_image_cache): Likewise.
8673
f6a24d19
PE
8674 * term.c (term_mouse_position): Don't assume time_t wraparound.
8675
08dc5ae6
PE
8676 Be more systematic about user-interface timestamps.
8677 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8678 and sometimes 'EMACS_UINT', to represent these timestamps.
8679 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8680 This makes the code easier to follow, and makes it easier to catch
8681 integer overflow bugs such as Bug#8664.
8682 * frame.c (Fmouse_position, Fmouse_pixel_position):
8683 Use Time, not unsigned long, for user-interface timestamps.
8684 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8685 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8686 * keyboard.h (last_event_timestamp): Likewise.
8687 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8688 * menu.h (xmenu_show): Likewise.
8689 * term.c (term_mouse_position): Likewise.
8690 * termhooks.h (struct input_event.timestamp): Likewise.
8691 (struct terminal.mouse_position_hook): Likewise.
8692 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8693 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8694 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8695 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8696 what it was before.
8697 * menu.h, termhooks.h: Include "systime.h", for Time.
8698
8e55734a
PE
8699 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8700 Don't assume that the difference between two unsigned long values
8701 can fit into an integer. At this point, we know button_down_time
8702 <= event->timestamp, so the difference must be nonnegative, so
8703 there's no need to cast the result if double-click-time is
8704 nonnegative, as it should be; check that it's nonnegative, just in
8705 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8706 apart (about 25 days). (Bug#8664)
8e55734a 8707
841f1b75 8708 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8709 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8710
3e26f69c
PE
8711 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8712 that always fit in int. Use a sentinel instead of a counter, to
8713 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8714 * frame.h (struct frame): Use int for menu_bar_items_used
8715 instead of EMACS_INT, since it always fits in int.
3e26f69c 8716
5cc152c0
PE
8717 * menu.c (grow_menu_items): Check for int overflow.
8718
d89eb65e
PE
8719 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8720
5235bd3e
PE
8721 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8722 Before, the code was not consistent. These values cannot exceed
8723 2**31 - 1 so there's no need to make them unsigned.
8724 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8725 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8726 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8727 as modifiers.
8728 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8729
bc827e23
PE
8730 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8731 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8732 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8733 presumably because the widths might not match.
8734
78eb494e
PE
8735 * window.c (size_window): Avoid needless test at loop start.
8736
04f2d78b
CB
87372011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8738
8739 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8740
d2fc7e3d 87412011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8742
8743 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8744
d2fc7e3d 87452011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8746
8747 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8748 `width' to `bar_area_x' and `bar_area_width', respectively.
8749 (x_scroll_run): Take account of fringe background extension.
8750
04f2d78b
CB
8751 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8752 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8753 `bar_area_width', respectively.
8754 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8755 background extension.
8756
79b70037
GM
87572011-05-10 Jim Meyering <meyering@redhat.com>
8758
8759 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8760
2f142cc5
JB
87612011-05-10 Juanma Barranquero <lekktu@gmail.com>
8762
8763 * image.c (Finit_image_library): Return t for built-in image types,
8764 like pbm and xbm. (Bug#8640)
8765
57679c86
AS
87662011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8767
8768 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8769
888c9e86
EZ
87702011-05-07 Eli Zaretskii <eliz@gnu.org>
8771
b0512a1d
EZ
8772 * w32console.c (Fset_screen_color): Doc fix.
8773 (Fget_screen_color): New function.
8774 (syms_of_ntterm): Defsubr it.
8775
7285dc67
EZ
8776 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8777 unlink the temporary file if Fcall_process didn't create it in the
8778 first place.
8779 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8780 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8781 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8782 cue to call_process_cleanup not to close that handle.
8783
4d3fcc8e
BK
87842011-05-07 Ben Key <bkey76@gmail.com>
8785
8786 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8787 one of two shell specific rules, either bootstrap-temacs-CMD or
8788 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8789 to the previous implementation of the bootstrap-temacs rule.
8790 The bootstrap-temacs-CMD rule is similar to the previous
8791 implementation of the bootstrap-temacs rule except that it
8792 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8793 variable.
8794
8795 These changes, along with some changes to nt/configure.bat,
8796 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8797 earlier fix to add support for --cflags and --ldflags options
8798 that include quotes so that it works whether make uses cmd or
8799 sh as the shell.
8800
b4289b64
MA
88012011-05-06 Michael Albinus <michael.albinus@gmx.de>
8802
8803 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8804 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8805 is a constant.
8806 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8807 a string. Handle both cases.
8808 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8809 (Fdbus_register_method): Use Qinvalid_function.
8810
af4c0e28
JB
88112011-05-06 Juanma Barranquero <lekktu@gmail.com>
8812
8813 * makefile.w32-in: Update dependencies.
8814 (LISP_H): Add inttypes.h and stdin.h.
8815 (PROCESS_H): Add unistd.h.
8816
c51453d9
EZ
88172011-05-06 Eli Zaretskii <eliz@gnu.org>
8818
8819 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8820 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8821
8ff0ac3c 88222011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8823
4c4b566b
PE
8824 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8825
aab2b9b5
PE
8826 * term.c (vfatal): Remove stray call to va_end.
8827 It's not needed and the C Standard doesn't allow it here anyway.
8828
c378da0b
PE
8829 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8830 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8831
288b08c7
PE
8832 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8833 bytes.
8834
e3601888
PE
8835 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8836
db6c0e74
PE
8837 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8838
dd5963ea
PE
8839 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8840
88c9450f
PE
8841 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8842
2f9442b8
PE
8843 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8844
c032b5f8
PE
8845 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8846 * charset.c (Fdefine_charset_internal): Don't initialize
8847 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8848 32-bit int (Bug#8600).
a108c10b
PE
8849
8850 * lread.c (read_integer): Be more consistent with string-to-number.
8851 Use string_to_number to do the actual conversion; this avoids
8852 rounding errors and fixes some other screwups. Without this fix,
8853 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8854 (digit_to_number): Move earlier, for benefit of read_integer.
8855 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8856 not a digit in any supported base. (Bug#8602)
a108c10b 8857
ad5f9eea
PE
8858 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8859
aec1708a
PE
8860 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8861 to match comment at start of function. This also removes a
8862 GCC warning about overflow in a 32+64-bit port.
8863
47be4ab5
PE
8864 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8865
371cac43
PE
8866 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8867 Reported by Stefan Monnier in
8868 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8869 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8870 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8871
d01a7826
PE
8872 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8873 (EMACS_UINTPTR): Likewise, with uintptr_t.
8874
7fd47d5c
PE
8875 * lisp.h: Prefer 64-bit EMACS_INT if available.
8876 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8877 on 32-bit hosts that have 64-bit int, so that they can access
8878 large files.
122b0c86
PE
8879 However, temporarily disable this change unless the temporary
8880 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8881
8727937b
PE
8882 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8883
8ac068ac
PE
8884 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8885 This removes an assumption that EMACS_INT and long are the same
8886 width as pointers. The assumption is true for Emacs porting targets
8887 now, but we want to make other targets possible.
8888 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8889 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8890 In the rest of the code, change types of integers that hold casted
8891 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8892 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8893 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8894 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8895 No need to cast type when ORing.
8896 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8897 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8898 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8899 assume EMACS_INT is the same width as char *.
8900 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8901 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8902 Remove no-longer-needed casts.
8903 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8904 (xg_tool_bar_help_callback, xg_make_tool_item):
8905 Use EMACS_INTPTR to hold an integer
8906 that will be cast to void *; this can avoid a GCC warning
8907 if EMACS_INT is not the same width as void *.
8908 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8909 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8910 (current_message_1, set_message_1):
8911 Use a local to convert to proper width without a cast.
8912 * xmenu.c (dialog_selection_callback): Likewise.
8913
ede49d71
PE
8914 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8915 Also, don't assume VALBITS / RAND_BITS is less than 5,
8916 and don't rely on undefined behavior when shifting a 1 left into
8917 the sign bit.
8918 * lisp.h (get_random): Change signature to match.
8919
2f30ecd0
PE
8920 * lread.c (hash_string): Use size_t, not int, for hash computation.
8921 Normally we prefer signed values; but hashing is special, because
8922 it's better to use unsigned division on hash table sizes so that
8923 the remainder is nonnegative. Also, size_t is the natural width
8924 for hashing into memory. The previous code used 'int', which doesn't
8925 retain enough info to hash well into very large tables.
8926 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8927
2a866e7b
PE
8928 * dbusbind.c: Don't possibly lose pointer info when converting.
8929 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8930 Use XPNTR rather than XHASH, so that the high-order bits of
8931 the pointer aren't lost when converting through void *.
8932
51639eac
PE
8933 * eval.c (Fautoload): Don't double-shift a pointer.
8934
92394119
PE
8935 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8936
dbdb9a7c
JB
89372011-05-06 Juanma Barranquero <lekktu@gmail.com>
8938
8939 * gnutls.c (DEF_GNUTLS_FN):
8940 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8941
db7a0b4f
AS
89422011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8943
8944 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8945 marker. (Bug#8610)
8946
cd394be1 89472011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8948
8949 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8950 New version that can reserve upto 2GB of heap space.
8951
f7ff1b0f 89522011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8953
8954 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8955
639c109b
TZ
89562011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8957
8958 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8959 `gnutls_certificate_set_x509_key_file'.
8960
d2127135
JB
89612011-05-05 Juanma Barranquero <lekktu@gmail.com>
8962
8963 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8964 Update dependencies.
8965
e968f4f3
JB
89662011-05-04 Juanma Barranquero <lekktu@gmail.com>
8967
8968 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8969 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8970 Remove unused parameter `fildes'.
8971 * process.c (read_process_output, send_process): Don't pass it.
8972
84d358f0
JB
89732011-05-04 Juanma Barranquero <lekktu@gmail.com>
8974
8975 Fix previous change: the library cache is defined in w32.c.
8976 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8977 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8978
0898ca10
JB
89792011-05-04 Juanma Barranquero <lekktu@gmail.com>
8980
8981 Implement dynamic loading of GnuTLS on Windows.
8982
8983 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8984 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8985 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8986 Declare.
8987
8988 * gnutls.c (Qgnutls_dll): Define.
8989 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8990 (gnutls_*): Declare function pointers.
8991 (init_gnutls_functions): New function to initialize function pointers.
8992 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8993 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8994 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8995 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8996 (emacs_gnutls_write, emacs_gnutls_read)
8997 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8998 (Fgnutls_available_p): New function.
8999 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9000 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9001 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9002
9003 * image.c: Include w32.h.
9004 (Vimage_type_cache): Delete.
9005 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9006 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9007 (w32_delayed_load): Move to w32.c.
9008
9009 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9010
9011 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9012 (w32_delayed_load): Move from image.c. When loading a library, record
9013 its filename in the :loaded-from property of the library id.
9014 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9015 Initialize and staticpro them.
9016 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9017
9018 * process.c: Include lisp.h before w32.h, not after.
9019 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9020 instead of gnutls_record_check_pending.
9021
9022 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9023
ff4de4aa
TZ
90242011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9025
9026 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9027 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9028 as passed in.
9029
abe95abb
JD
90302011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9031
9032 * xterm.c (x_set_frame_alpha): Do not set property on anything
9033 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9034
e16e55d4
JB
90352011-05-02 Juanma Barranquero <lekktu@gmail.com>
9036
9037 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9038
bafcf6a5
JB
90392011-05-02 Juanma Barranquero <lekktu@gmail.com>
9040
9041 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9042 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9043 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9044 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9045 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9046 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9047 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9048 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9049 (Qgnutls_bootprop_callbacks_verify): Make static.
9050
e7a6747f
AS
90512011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9052
19ed11ba
AS
9053 * callproc.c: Indentation fixup.
9054
e7a6747f 9055 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9056 (wait_for_termination, interruptible_wait_for_termination):
9057 Move after wait_for_termination_1.
e7a6747f 9058
1ef14cb4
LMI
90592011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9060
9061 * sysdep.c (interruptible_wait_for_termination): New function
9062 which is like wait_for_termination, but allows keyboard
9063 interruptions.
9064
9065 * callproc.c (Fcall_process): Add (:file "file") as an option for
9066 the STDOUT buffer.
9067 (Fcall_process_region): Ditto.
9068
330d880c
EZ
90692011-04-30 Eli Zaretskii <eliz@gnu.org>
9070
8db90b73
EZ
9071 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9072 rather than `XVECTOR (FOO)->size'.
9073
330d880c
EZ
9074 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9075 inttypes.h, as a gnulib replacement is used if it not available in
9076 system headers.
9077
15cbd324
EZ
90782011-04-21 Eli Zaretskii <eliz@gnu.org>
9079
9080 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9081 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9082 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9083
9084 * coding.c (coding_alloc_by_realloc): Error out if destination
9085 will grow beyond MOST_POSITIVE_FIXNUM.
9086 (decode_coding_emacs_mule): Abort if there isn't enough place in
9087 charbuf for the composition carryover bytes. Reserve an extra
9088 space for up to 2 characters produced in a loop.
9089 (decode_coding_iso_2022): Abort if there isn't enough place in
9090 charbuf for the composition carryover bytes.
9091
90922011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9093
ae940cca
EZ
9094 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9095 aborting when %lld or %lll format is passed.
9096 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9097 %llo or %llx format is passed. (Bug#8545)
9098
03ab8921
EZ
9099 * window.c (window_scroll_line_based): Use a marker instead of
9100 simple variables to record original value of point. (Bug#7952)
9101
afda1437
EZ
9102 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9103 produced by %s or %c overflows available buffer space. (Bug#8545)
9104
f76dee0c
PE
91052011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9106
9107 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9108 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9109
fdc5744d
JB
91102011-04-28 Juanma Barranquero <lekktu@gmail.com>
9111
9112 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9113
638f053a
JB
91142011-04-28 Juanma Barranquero <lekktu@gmail.com>
9115
9116 * keyboard.c (Qdelayed_warnings_hook): Define.
9117 (command_loop_1): Run `delayed-warnings-hook'
9118 if Vdelayed_warnings_list is non-nil.
9119 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9120 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9121
d178f871
EZ
91222011-04-28 Eli Zaretskii <eliz@gnu.org>
9123
9124 * doprnt.c (doprnt): Don't return value smaller than the buffer
9125 size if the message was truncated. (Bug#8545).
9126
b124fd93
JB
91272011-04-28 Juanma Barranquero <lekktu@gmail.com>
9128
9129 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9130 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9131
e810457d
PE
91322011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9133
9134 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9135
ea51cceb
JB
91362011-04-27 Juanma Barranquero <lekktu@gmail.com>
9137
9138 * makefile.w32-in: Update dependencies.
9139
94dcfacf
EZ
91402011-04-27 Eli Zaretskii <eliz@gnu.org>
9141
9142 Improve `doprnt' and its usage. (Bug#8545)
9143 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9144 `format_end'. Remove support for %l as a conversion specifier.
9145 Don't use xrealloc. Improve diagnostics when the %l size modifier
9146 is used. Update the commentary.
9147
9148 * eval.c (verror): Simplify calculation of size_t.
9149
9150 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9151 messages.
9152
f61f41d7
PE
91532011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9154
9155 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9156 change.
9157
96fb4434
PE
91582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9159
9160 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9161 This makes this file independent of the recent pseudovector change.
9162
671875da 91632011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9164
69e9b5a3
PE
9165 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9166
b5f869a7 9167 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9168 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9169 Remove unused local.
c8926152 9170 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9171
841a1577 9172 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9173 GCC 4.6.0 optimizes based on type-based alias analysis.
9174 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9175 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9176 != &v->size, and therefore "v->size = 1; b->size = 2; return
9177 v->size;" must therefore return 1. This assumption is incorrect
9178 for Emacs, since it type-puns struct Lisp_Vector * with many other
9179 types. To fix this problem, this patch adds a new type struct
f904488f 9180 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9181 and pseudovectors, and helps optimizing compilers not get fooled
9182 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9183 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9184 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9185 the size member.
eab3844f
PE
9186 (XSETPVECTYPE): Rewrite in terms of new macro.
9187 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9188 This is a bit clearer, and further avoids the possibility of
9189 undesirable aliasing.
9190 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9191 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9192 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9193 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9194 (ASIZE): Now uses header.size rather than size.
9195 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9196 to avoid the hassle of writing XVECTOR (foo)->header.size.
9197 (struct vectorlike_header): New type.
eab3844f
PE
9198 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9199 object, to help avoid aliasing.
9200 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9201 (SUBRP): Likewise, since Lisp_Subr is a special case.
9202 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9203 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9204 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9205 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9206 changed to be "header.size" and "header.next".
9207 * buffer.h (struct buffer): Likewise.
9208 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9209 * frame.h (struct frame): Likewise.
9210 * process.h (struct Lisp_Process): Likewise.
9211 * termhooks.h (struct terminal): Likewise.
9212 * window.c (struct save_window_data, struct saved_window): Likewise.
9213 * window.h (struct window): Likewise.
9214 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9215 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9216 * buffer.c (init_buffer_once): Likewise.
9217 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9218 special case.
9219 * process.c (Fformat_network_address): Use local var for size,
9220 for brevity.
9221
0df1eac5
PE
9222 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9223
847ab9d1 9224 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9225 * data.c (atof): Remove decl; no longer used or needed.
9226 (digit_to_number): Move to lread.c.
9227 (Fstring_to_number): Use new string_to_number function, to be
9228 consistent with how the Lisp reader treats infinities and NaNs.
9229 Do not assume that floating-point numbers represent EMACS_INT
9230 without losing information; this is not true on most 64-bit hosts.
9231 Avoid double-rounding errors, by insisting on integers when
9232 parsing non-base-10 numbers, as the documentation specifies.
9233 * lisp.h (string_to_number): New decl, replacing ...
9234 (isfloat_string): Remove.
bc0a5c13 9235 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9236 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9237 appears to have been a coding error. Similarly, do not accept
9238 strings like +-1e0 as floating point numbers. Do not report
9239 overflow for integer overflows unless the base is not 10 which
9240 means we have no simple and reliable way to continue.
9241 Break out the floating-point parsing into a new
9242 function string_to_number, so that Fstring_to_number parses
9243 floating point numbers consistently with the Lisp reader.
04f2d78b 9244 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9245 (E_CHAR, EXP_INT): Remove, replacing with ...
9246 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9247 (string_to_number): New function, replacing isfloat_string.
9248 This function checks for valid syntax and produces the resulting
9249 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9250 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9251 so that overflow for non-base-10 numbers is reported only when
9252 there's no portable and simple way to convert to floating point.
452f4150 9253
67769ffc
PE
9254 * textprop.c (set_text_properties_1): Rewrite for clarity,
9255 and to avoid GCC warning about integer overflow.
9256
c20db43f
PE
9257 * intervals.h (struct interval): Use EMACS_INT for members
9258 where EMACS_UINT might cause problems. See
9259 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9260 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9261 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9262 All uses changed.
37aa2f85
PE
9263 (offset_intervals): Tell GCC not to worry about length overflow
9264 when negating a negative length.
c20db43f 9265
2538aa2f
PE
9266 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9267 (overrun_check_free): Likewise.
9268
f2d3008d
PE
9269 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9270 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9271 word size.
9272
ec8df744
PE
9273 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9274 (gnutls_make_error): Rename local to avoid shadowing.
9275 (gnutls_emacs_global_deinit): ifdef out; not used.
9276 (Fgnutls_boot): Use const for pointer to readonly storage.
9277 Comment out unused local. Fix pointer signedness problems.
9278
640ee02d
PE
9279 * lread.c (openp): Don't stuff size_t into an 'int'.
9280 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9281 about possible signed overflow.
9282
6048fb2a
PE
9283 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9284 (GDK_KEY_g): Don't define if already defined.
9285 (xg_prepare_tooltip): Avoid pointer signedness problem.
9286 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9287
fa3c87e1
PE
9288 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9289 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9290
2172544b
PE
9291 * xfns.c (Fx_window_property): Simplify a bit,
9292 to make a bit faster and to avoid GCC 4.6.0 warning.
9293 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9294
9b821a21
PE
9295 * fns.c (internal_equal): Don't assume size_t fits in int.
9296
3c616cfa
PE
9297 * alloc.c (compact_small_strings): Tighten assertion a little.
9298
c2982e87
PE
9299 Replace pEd with more-general pI, and fix some printf arg casts.
9300 * lisp.h (pI): New macro, generalizing old pEd macro to other
9301 conversion specifiers. For example, use "...%"pI"d..." rather
9302 than "...%"pEd"...".
9303 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9304 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9305 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9306 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9307 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9308 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9309 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9310 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9311 64-bit hosts.
9312 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9313 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9314 * print.c (safe_debug_print, print_object): Likewise.
9315 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9316 to int.
6f04d126
PE
9317 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9318 avoiding the 0 flag, which is not portable.
c2982e87
PE
9319 * process.c (Fmake_network_process): Use pI to avoid cast.
9320 * region-cache.c (pp_cache): Likewise.
9321 * xdisp.c (decode_mode_spec): Likewise.
9322 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9323 behavior on 64-bit hosts with printf arg.
6f04d126 9324 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9325 (x_stop_queuing_selection_requests): Likewise.
9326 (x_get_window_property): Don't truncate byte count to an 'int'
9327 when tracing.
0b432f21 9328
5e073ec7
PE
9329 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9330 here, since it parses constructs like leading '-' and spaces,
9331 which are not wanted; and it overflows with large numbers.
9332 Instead, simply match F[0-9]+, which is what is wanted anyway.
9333
36372bf9
PE
9334 * alloc.c: Remove unportable assumptions about struct layout.
9335 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9336 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9337 (allocate_vectorlike, make_pure_vector): Use the new macros,
9338 plus offsetof, to remove unportable assumptions about struct layout.
9339 These assumptions hold on all porting targets that I know of, but
9340 they are not guaranteed, they're easy to remove, and removing them
9341 makes further changes easier.
9342
0b432f21
PE
9343 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9344 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9345 (string_overrun_cookie): Now const. Use initializers that
9346 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9347 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9348 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9349 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9350 multiple of sizeof (EMACS_INT); it need not be, if
9351 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9352 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9353
895009e1
JB
93542011-04-26 Juanma Barranquero <lekktu@gmail.com>
9355
9356 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9357
6a7a1b0b
TZ
93582011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9359
9360 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9361 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9362 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9363
841a1577 93642011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9365
9366 * lisp.h (Qdebug): List symbol.
895009e1 9367 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9368 * keyboard.c (debug-on-event): New variable.
9369 (handle_user_signal): Break into debugger when debug-on-event
9370 matches the current signal symbol.
9371
f2d3ba6f
DN
93722011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9373
9374 * alloc.c (check_sblock, check_string_bytes)
9375 (check_string_free_list): Convert to standard C.
9376
42ce4c63
TZ
93772011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9378
9379 * w32.c (emacs_gnutls_push): Fix typo.
9380
825cd63c
EZ
93812011-04-25 Eli Zaretskii <eliz@gnu.org>
9382
fb11d64d
EZ
9383 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9384 "cast to pointer from integer of different size".
9385
825cd63c
EZ
9386 Improve doprnt and its use in verror. (Bug#8545)
9387 * doprnt.c (doprnt): Document the set of format control sequences
9388 supported by the function. Use SAFE_ALLOCA instead of always
9389 using `alloca'.
9390
9391 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9392 is one byte too soon. Don't use xrealloc; instead xfree and
9393 xmalloc anew.
9394
e061a11b
TZ
93952011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9396
9397 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9398 callbacks stage.
9399
9400 * gnutls.c: Renamed global_initialized to
9401 gnutls_global_initialized. Added internals for the
9402 :verify-hostname-error, :verify-error, and :verify-flags
9403 parameters of `gnutls-boot' and documented those parameters in the
9404 docstring. Start callback support.
9173deec
JB
9405 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9406 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9407 on error. Return error code.
e061a11b
TZ
9408 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9409 (emacs_gnutls_read): Likewise.
9410 (Fgnutls_boot): Return handshake error code.
9411 (emacs_gnutls_handle_error): New function.
9412 (wsaerror_to_errno): Likewise.
9413
9414 * w32.h (emacs_gnutls_pull): Add prototype.
9415 (emacs_gnutls_push): Likewise.
9416
9417 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9418 (emacs_gnutls_push): Likewise.
9419
94202011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9421
9422 * process.c (wait_reading_process_output): Check if GnuTLS
9423 buffered some data internally if no FDs are set for TLS
9424 connections.
9425
9426 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9427 (LIBS): Link to USER_LIBS.
9428 ($(BLD)/gnutls.$(0)): New target.
9429
fa6996bc
EZ
94302011-04-24 Eli Zaretskii <eliz@gnu.org>
9431
eb35682e
EZ
9432 * xdisp.c (handle_single_display_spec): Rename the
9433 display_replaced_before_p argument into display_replaced_p, to
9434 make it consistent with the commentary. Fix typos in the
9435 commentary.
9436
e2ad650c
EZ
9437 * textprop.c (syms_of_textprop): Remove dead code.
9438 (copy_text_properties): Delete obsolete commentary about an
9439 interface that was deleted long ago. Fix typos in the description
9440 of arguments.
9441
1b2de274
EZ
9442 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9443 to changes in oldXMenu/XMenu.h from 2011-04-16.
9444 <menu_help_message, prev_menu_help_message>: Constify.
9445 (IT_menu_make_room): menu->help_text is now `const char **';
9446 adjust.
9447
9448 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9449 to changes in oldXMenu/XMenu.h from 2011-04-16.
9450 (struct XMenu): Declare `help_text' `const char **'.
9451
9452 * xfaces.c <Qunspecified>: Make extern again.
9453
9454 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9455 required by POSIX.
1b2de274 9456
762b15be
EZ
9457 * doc.c (get_doc_string): Improve the format passed to `error'.
9458
9459 * doprnt.c (doprnt): Improve commentary.
9460
9461 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9462
9463 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9464 them with etags.
9465
f1052e5d
EZ
9466 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9467 changes in globals.h immediately force recompilation.
762b15be
EZ
9468 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9469 $(CURDIR)/s/ms-w32.h.
9470 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9471
fa6996bc
EZ
9472 * character.c (Fchar_direction): Function deleted.
9473 (syms_of_character): Don't defsubr it.
9474 <char-direction-table>: Deleted.
9475
e6c3da20
EZ
94762011-04-23 Eli Zaretskii <eliz@gnu.org>
9477
9478 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9479 * doprnt.c: Include limits.h.
9480 (SIZE_MAX): New macro.
04f2d78b
CB
9481 (doprnt): Return a size_t value. 2nd arg is now size_t.
9482 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9483 Improve overflow protection. Support `l' modifier for integer
9484 conversions. Support %l conversion. Don't assume an EMACS_INT
9485 argument for integer conversions and for %c.
9486
9487 * lisp.h (doprnt): Restore prototype.
9488
9489 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9490 $(SRC)/character.h.
9491
9492 * Makefile.in (base_obj): Add back doprnt.o.
9493
9494 * deps.mk (doprnt.o): Add back prerequisites.
9495 (callint.o): Depend on character.h.
9496
9497 * eval.c (internal_lisp_condition_case): Include the handler
9498 representation in the error message.
9499 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9500 when breaking from the loop.
9501
9502 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9503
9504 * callint.c (Fcall_interactively): When displaying error message
9505 about invalid control letter, pass the character's codepoint, not
9506 a pointer to its multibyte form. Improve display of the character
9507 in octal and display also its hex code.
9508
9509 * character.c (char_string): Use %x to display the (unsigned)
9510 codepoint of an invalid character, to avoid displaying a bogus
9511 negative value.
9512
9513 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9514 `error', not SYMBOL_NAME itself.
9515
9516 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9517 character arguments to `error'.
9518
9519 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9520 to `error' in error message about FINAL_CHAR argument. Make sure
9521 FINAL_CHAR is a character, and use %c when it is passed as
9522 argument to `error'.
9523
4ffd0d6b 95242011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9525
9526 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9527
9528 * w32.c: Include <time.h>.
9529 (sys_localtime): New function.
9530
4ffd0d6b 95312011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9532
9533 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9534
4ffd0d6b 9535 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9536
4ffd0d6b 95372011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9538
4ffd0d6b
GM
9539 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9540 zombies (Bug#8467).
aac0c6e3 9541
04c56954
EZ
95422011-04-19 Eli Zaretskii <eliz@gnu.org>
9543
9544 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9545 gl_state.e_property when gl_state.object is Qt.
9546
9547 * insdel.c (make_gap_larger): Remove limitation of buffer size
9548 to <= INT_MAX.
9549
16a43933
CY
95502011-04-18 Chong Yidong <cyd@stupidchicken.com>
9551
9552 * xdisp.c (lookup_glyphless_char_display)
9553 (produce_glyphless_glyph): Handle cons cell entry in
9554 glyphless-char-display.
9555 (Vglyphless_char_display): Document it.
9556
9557 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9558 glyphless-char-display.
9559
4581706e
CY
95602011-04-17 Chong Yidong <cyd@stupidchicken.com>
9561
9562 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9563
9564 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9565
9566 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9567 definition for no-X builds.
9568
4887c6e2 95692011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9570
fd35b6f9
PE
9571 Static checks with GCC 4.6.0 and non-default toolkits.
9572
5c1ccb01
PE
9573 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9574
006c5daa
PE
9575 * process.c (keyboard_bit_set): Define only if SIGIO.
9576 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9577 (send_process): Repair possible setjmp clobbering.
9578
efc736d3
PE
9579 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9580
4e2fe2e6
PE
9581 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9582
f97334a2
PE
9583 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9584
4e75f29d
PE
9585 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9586 Define only if needed.
9587
90efadd1
PE
9588 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9589 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9590 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9591
3c647824
PE
9592 * dispextern.h (struct redisplay_interface): Rename param
9593 to avoid shadowing.
e264f262 9594 * termhooks.h (struct terminal): Likewise.
761383f4 9595 * xterm.c (xembed_send_message): Likewise.
3c647824 9596
b58c5c4a
PE
9597 * insdel.c (make_gap_smaller): Define only if
9598 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9599
cad59032
PE
9600 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9601 it.
9602
c339dc2e
PE
9603 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9604 so that we aren't warned about unused symbols.
9605
91a3e27b
PE
9606 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9607
399c71d3 9608 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9609
8ffc96f5
PE
9610 * xfns.c (x_real_positions): Mark locals as initialized.
9611
eef9bc79
PE
9612 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9613
098db9dd
PE
9614 * xterm.c: Fix problems found by static analysis with other toolkits.
9615 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9616 (x_dispatch_event): Declare static if USE_GTK, and
9617 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9618 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9619 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9620 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9621 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9622
eb18f6cc
PE
9623 * xmenu.c (menu_help_callback): Pointer type fixes.
9624 Use const pointers when pointing at readonly data. Avoid pointer
9625 signedness clashes.
9626 (FALSE): Remove unused macro.
9627 (update_frame_menubar): Remove unused decl.
9628
1fe72bf8
PE
9629 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9630
60d9e1db
PE
9631 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9632 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9633 (single_menu_item): Rename local to avoid shadowing.
9634
39261c26
PE
9635 * keyboard.c (make_lispy_event): Remove unused local var.
9636
018c5e19
PE
9637 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9638 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9639
63d2b86e
PE
9640 * bitmaps: Change bitmaps from unsigned char back to the X11
9641 compatible char. Avoid the old compiler warnings about
9642 out-of-range initializers by using, for example, '\xab' rather
9643 than 0xab.
9644
aefd87e1
PE
9645 * xgselect.c (xgselect_initialize): Check vs interface
9646 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9647
bf501fb9
PE
9648 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9649
e9829fdf
PE
9650 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9651 to read-only memory.
9652
1086c095
PE
9653 * fns.c (vector): Remove; this old hack is no longer needed.
9654
2baccd04 9655 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9656 Remove unused var.
dde42981 9657 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9658
72391843 9659 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9660
436c16df 9661 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9662 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9663 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9664
92bb796d 9665 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9666 (x_term_init): Remove local to avoid shadowing.
92bb796d 9667
764430a3 9668 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9669
9670 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9671 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9672
d1dfb56c
EZ
96732011-04-16 Eli Zaretskii <eliz@gnu.org>
9674
c4354cb4
EZ
9675 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9676
d1dfb56c
EZ
9677 Fix regex.c, syntax.c and friends for buffers > 2GB.
9678 * syntax.h (struct gl_state_s): Declare character position members
9679 EMACS_INT.
9680
9681 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9682
04f2d78b
CB
9683 * textprop.c (verify_interval_modification, interval_of):
9684 Declare arguments EMACS_INT.
d1dfb56c
EZ
9685
9686 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9687 EMACS_INT.
9688
9689 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9690
9691 * indent.c (Fvertical_motion): Local variable it_start is now
9692 EMACS_INT.
9693
9694 * regex.c (re_match, re_match_2, re_match_2_internal)
9695 (bcmp_translate, regcomp, regexec, print_double_string)
9696 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9697 (re_compile_pattern, re_exec): Declare arguments and local
9698 variables `size_t' and `ssize_t' and return values `regoff_t', as
9699 appropriate.
9700 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9701 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9702 <compile_stack_type>: `size' and `avail' are now `size_t'.
9703
9704 * regex.h <regoff_t>: Use ssize_t, not int.
9705 (re_search, re_search_2, re_match, re_match_2): Arguments that
9706 specify buffer/string position and length are now ssize_t and
9707 size_t. Return type is regoff_t.
9708
613052cd
BK
97092011-04-16 Ben Key <bkey76@gmail.com>
9710
9711 * nsfont.m: Fixed bugs in ns_get_family and
9712 ns_descriptor_to_entity that were caused by using free to
9713 deallocate memory blocks that were allocated by xmalloc (via
9714 xstrdup). This caused Emacs to crash when compiled with
9715 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9716 --enable-checking=xmallocoverrun). xfree is now used to
9717 deallocate these memory blocks.
9718
4170f62f 97192011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9720
71b41406
PE
9721 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9722
9587a89d
PE
9723 emacs_write: Accept and return EMACS_INT for sizes.
9724 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9725 et seq.
9726 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9727 Accept and return EMACS_INT.
9728 (emacs_gnutls_write): Return the number of bytes written on
9729 partial writes.
9730 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9731 (emacs_read, emacs_write): Remove check for negative size, as the
9732 Emacs source code has been audited now.
9587a89d
PE
9733 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9734 (emacs_read, emacs_write): Use it.
273a5f82
PE
9735 * process.c (send_process): Adjust to the new signatures of
9736 emacs_write and emacs_gnutls_write. Do not attempt to store
9737 a byte offset into an 'int'; it might overflow.
9587a89d 9738 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9739
3e047f51
PE
9740 * sound.c: Don't assume sizes fit in 'int'.
9741 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9742 Return EMACS_INT, not int.
3e047f51 9743 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9744 Accept EMACS_INT, not int.
9745 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9746 record read return values.
9747
cc39a9db
BK
97482011-04-15 Ben Key <bkey76@gmail.com>
9749
c9d0ec6d
JB
9750 * keyboard.c (Qundefined): Don't declare static since it is used
9751 in nsfns.m.
9752 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9753 static since they are used in nsfont.m.
cc39a9db 9754
6c60eb9f
SM
97552011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9756
9757 * process.c (Qprocessp): Don't declare static.
9758 * lisp.h (Qprocessp): Declare again.
9759
7990b61a
JB
97602011-04-15 Juanma Barranquero <lekktu@gmail.com>
9761
9762 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9763
5d4cb038
PE
97642011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9765
8bd7b830 9766 Improve C-level modularity by making more things 'static'.
cd64ea1d 9767
e3b27b31
PE
9768 Don't publish debugger-only interfaces to other modules.
9769 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9770 (verify_bytepos, count_markers): Move decls to the only modules
9771 that need them.
9772 * region-cache.h (pp_cache): Likewise.
9773 * window.h (check_all_windows): Likewise.
9774 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9775
5d4cb038
PE
9776 * sysdep.c (croak): Now static, if
9777 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9778 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9779
9780 * alloc.c (refill_memory_reserve): Now static if
9781 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9782 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9783
e87b6180
PE
9784 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9785 Define only if USE_LUCID.
9786
ac64929e
PE
9787 * xrdb.c (x_customization_string, x_rm_string): Now static.
9788
6f37259d
PE
9789 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9790 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9791
1683e3ab
PE
9792 * xdisp.c (draw_row_with_mouse_face): Now static.
9793 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9794
de9c2632
PE
9795 * window.h (check_all_windows): Mark externally visible.
9796
2b96acb7
PE
9797 * window.c (window_deletion_count): Now static.
9798
9799 * undo.c: Make symbols static if they're not exported.
9800 (last_undo_buffer, last_boundary_position, pending_boundary):
9801 Now static.
9802
50436f33
PE
9803 * textprop.c (interval_insert_behind_hooks): Now static.
9804 (interval_insert_in_front_hooks): Likewise.
9805
64520e5c
PE
9806 * term.c: Make symbols static if they're not exported.
9807 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9808 (max_frame_lines, tty_set_terminal_modes):
9809 (tty_reset_terminal_modes, tty_turn_off_highlight):
9810 (get_tty_terminal): Now static.
9811 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9812 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9813 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9814 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9815 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9816
1fa53021
PE
9817 * sysdep.c: Make symbols static if they're not exported.
9818 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9819 Now static.
9820 (sigprocmask_set, full_mask): Remove; unused.
9821 (wait_debugging): Mark as visible.
9822 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9823 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9824
d4b43b22
PE
9825 * syntax.c (syntax_temp): Define only if !__GNUC__.
9826
b7c513d0
PE
9827 * sound.c (current_sound_device, current_sound): Now static.
9828
989b29ad
PE
9829 * search.c (searchbufs, searchbuf_head): Now static.
9830
13a55a78
PE
9831 * scroll.c (scroll_cost): Remove; unused.
9832 * dispextern.h (scroll_cost): Remove decl.
9833
de68a1fc
PE
9834 * region-cache.h (pp_cache): Mark as externally visible.
9835
40ccffa6
PE
9836 * process.c: Make symbols static if they're not exported.
9837 (process_tick, update_tick, create_process, chan_process):
9838 (Vprocess_alist, proc_buffered_char, datagram_access):
9839 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9840 (deactivate_process): Mark defn as static, as well as decl.
9841 * lisp.h (create_process): Remove decl.
9842 * process.h (chan_process, Vprocess_alist): Remove decls.
9843
ad64fc97
PE
9844 * print.c: Make symbols static if they're not exported.
9845 (print_depth, new_backquote_output, being_printed, print_buffer):
9846 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9847 (print_interval, print_number_index, initial_stderr_stream):
9848 Now static.
9849 * lisp.h (Fprinc): Remove decl.
9850 (debug_output_compilation_hack): Mark as externally visible.
9851
adddb265
PE
9852 * sysdep.c (croak): Move decl from here to syssignal.h.
9853 * syssignal.h (croak): Put it here, so the API can be checked when
9854 'croak' is called from dissociate_if_controlling_tty.
9855
1717ede2
PE
9856 * minibuf.c: Make symbols static if they're not exported.
9857 (minibuf_save_list, choose_minibuf_frame): Now static.
9858 * lisp.h (choose_minibuf_frame): Remove decl.
9859
fa5fb2bc
PE
9860 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9861
1e3890d1
PE
9862 * lread.c: Make symbols static if they're not exported.
9863 (read_objects, initial_obarray, oblookup_last_bucket_number):
9864 Now static.
9865 (make_symbol): Remove; unused.
9866 * lisp.h (initial_obarray, make_symbol): Remove decls.
9867
8a1414fa
PE
9868 * keyboard.c: Make symbols static if they're not exported.
9869 (single_kboard, recent_keys_index, total_keys, recent_keys):
9870 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9871 (this_single_command_key_start, echoing, last_auto_save):
9872 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9873 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9874 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9875 (Vlispy_mouse_stem, double_click_count):
9876 Now static.
9877 (force_auto_save_soon): Define only if SIGDANGER.
9878 (ignore_mouse_drag_p): Now static if
9879 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9880 (print_help): Remove; unused.
9881 (stop_character, last_timer_event): Mark as externally visible.
9882 * keyboard.h (ignore_mouse_drag_p): Declare only if
9883 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9884 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9885 * lisp.h (echoing): Remove decl.
9886 (force_auto_save_soon): Declare only if SIGDANGER.
9887 * xdisp.c (redisplay_window): Simplify code, to make it more
9888 obvious that ignore_mouse_drag_p is not accessed if !defined
9889 USE_GTK && !defined HAVE_NS.
9890
93ea6e8f
PE
9891 * intervals.c: Make symbols static if they're not exported.
9892 (merge_properties_sticky, merge_interval_right, delete_interval):
9893 Now static.
9894 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9895
77382fcc
PE
9896 * insdel.c: Make symbols static if they're not exported.
9897 However, leave prepare_to_modify_buffer alone. It's never
9898 called from outside this function, but that appears to be a bug.
9899 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9900 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9901 (adjust_after_replace_noundo): Remove; unused.
9902 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9903 (signal_before_change): Remove decls.
77382fcc 9904
9306c32e
PE
9905 * indent.c (val_compute_motion, val_vmotion): Now static.
9906
cd44d2eb
PE
9907 * image.c: Make symbols static if they're not exported.
9908 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9909 if USE_GTK.
9910 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9911 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9912
ad9a7a06
PE
9913 * fringe.c (standard_bitmaps): Now static.
9914 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9915
81626931
PE
9916 * frame.c: Make symbols static if they're not exported.
9917 (x_report_frame_params, make_terminal_frame): Now static.
9918 (get_frame_param): Now static, unless HAVE_NS.
9919 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9920 (x_get_resource_string): Remove; not used.
9921 * frame.h (make_terminal_frame, x_report_frame_params):
9922 (x_get_resource_string); Remove decls.
9923 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9924 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9925
239f9db9
PE
9926 * font.c, fontset.c: Make symbols static if they're not exported.
9927 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9928 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9929 * font.c (font_close_object): Now static.
9930 * font.h (font_close_object): Remove.
9931 * fontset.c (FONTSET_OBJLIST): Remove.
9932 (free_realized_fontset) #if-0 the body, which does nothing.
9933 (face_suitable_for_char_p): #if-0, as it's never called.
9934 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9935 * xfaces.c (face_at_string_position):
9936 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9937 since 0 is always ASCII.
9938
dfcf3579
PE
9939 * fns.c (weak_hash_tables): Now static.
9940
5045092b
PE
9941 * fileio.c: Make symbols static if they're not exported.
9942 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9943 (Vwrite_region_annotation_buffers): Now static.
9944
57a96f5c
PE
9945 * eval.c: Make symbols static if they're not exported.
9946 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9947 * lisp.h (backtrace_list): Remove decl.
9948
35f08c38
PE
9949 * emacs.c: Make symbols static if they're not exported.
9950 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9951 (fatal_error_code, fatal_error_signal_hook, standard_args):
9952 Now static.
9953 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9954 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9955 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9956 * lisp.h (fatal_error_signal_hook): Remove decl.
9957 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9958
f44bd759
PE
9959 * editfns.c: Move a (normally-unused) function to its only use.
9960 * editfns.c, lisp.h (get_operating_system_release): Remove.
9961 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9962 worth the hassle of breaking this out.
9963
b532497d
PE
9964 * xterm.c: Make symbols static if they're not exported.
9965 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9966 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9967 (x_destroy_window, x_delete_display):
9968 Now static.
9969 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9970 (x_mouse_leave): Remove; unused.
9971 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9972 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9973 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9974 Remove decls.
9975 (x_mouse_leave): Declare only if WINDOWSNT.
9976 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9977 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9978 USE_X_TOOLKIT.
9979
1675728f
PE
9980 * ftxfont.c: Make symbols static if they're not exported.
9981 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9982 HAVE_FREETYPE.
9983 * font.h (ftxfont_driver): Likewise.
9984
e4cebfca
PE
9985 * xfns.c: Make symbols static if they're not exported.
9986 (x_last_font_name, x_display_info_for_name):
9987 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9988 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9989 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9990 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9991 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9992 (last_show_tip_args): Now static.
9993 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9994 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9995 (x_screen_planes): Remove; unused.
9996 * dispextern.h (x_screen_planes): Remove decl.
9997
5bf46f05
PE
9998 * dispnew.c: Make symbols static if they're not exported.
9999 * dispextern.h (redraw_garbaged_frames, scrolling):
10000 (increment_row_positions): Remove.
10001 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10002 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10003 Now static.
10004 (redraw_garbaged_frames): Remove; unused.
10005
435f4c28
PE
10006 * xfaces.c: Make symbols static if they're not exported.
10007 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10008 Remove decls.
10009 * xterm.h (defined_color): Remove decls.
10010 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10011 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10012 (menu_face_changed_default, defined_color, free_realized_face):
10013 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10014 (ascii_face_of_lisp_face): Remove; unused.
10015
8524aef3
PE
10016 * xdisp.c: Make symbols static if they're not exported.
10017 * dispextern.h (scratch_glyph_row, window_box_edges):
10018 (glyph_to_pixel_coords, set_cursor_from_row):
10019 (get_next_display_element, set_iterator_to_next):
10020 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10021 (show_mouse_face): Remove decls
10022 * frame.h (message_buf_print): Likewise.
10023 * lisp.h (pop_message, set_message, check_point_in_composition):
10024 Likewise.
10025 * xterm.h (set_vertical_scroll_bar): Likewise.
10026 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10027 (message_buf_print, scratch_glyph_row, displayed_buffer):
10028 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10029 (get_next_display_element, show_mouse_face, window_box_edges):
10030 (frame_to_window_pixel_xy, check_point_in_composition):
10031 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10032 (glyph_to_pixel_coords): Remove; unused.
10033
16390cd2
PE
10034 * dired.c (file_name_completion): Now static.
10035
10036 * dbusbind.c (xd_in_read_queued_messages): Now static.
10037
a25f4dfa
PE
10038 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10039 * data.c (circular_list_error): Remove.
10040
14a9c8df
PE
10041 * commands.h (last_point_position, last_point_position_buffer):
10042 (last_point_position_window): Remove decls.
10043 * keyboard.c: Make these variables static.
10044
04f2d78b
CB
10045 * coding.h (coding, code_convert_region, encode_coding_gap):
10046 Remove decls.
74ab6df5
PE
10047 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10048 (iso_code_class, detect_coding, code_convert_region): Now static.
10049 (encode_coding_gap): Remove; unused.
10050
38dfbee1
PE
10051 * chartab.c (chartab_chars, chartab_bits): Now static.
10052
a2cb4e63
PE
10053 * charset.h (charset_iso_8859_1): Remove decl.
10054 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10055 Now static.
10056
127198fd
PE
10057 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10058 * ccl.c (Vccl_program_table): Now static.
10059 (check_ccl_update): Remove; unused.
10060
d85b608f
PE
10061 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10062 * category.h: ... from here.
10063 * category.c (check_category_table, set_category_set): Now static.
10064
31cd66f3
PE
10065 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10066 * lisp.h: Remove these decls.
10067
c358e587
PE
10068 * buffer.c (buffer_count): Remove unused var.
10069
e78aecca
PE
10070 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10071 so that it's not optimized away.
10072 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10073 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10074 exported only to the debugger.
10075
e192d7d3 10076 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10077 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10078
92470028
PE
10079 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10080 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10081 was inaccessible from Lisp.
10082 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10083 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10084
244ed907
PE
10085 alloc.c: Import and export fewer symbols, and remove unused items.
10086 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10087 is defined.
10088 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10089 it's not optimized away by whole-program optimization.
10090 (message_enable_multibyte, free_misc): Remove.
10091 (catchlist, handlerlist, mark_backtrace):
10092 Declare only if BYTE_MARK_STACK.
10093 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10094 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10095 (message_enable_multibyte): Remove decl.
10096 (free_misc, interval_free_list, float_block, float_block_index):
10097 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10098 (cons_free_list, last_marked_index):
10099 Now static.
10100 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10101 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10102 (mark_backtrace): Define only if BYTE_MARK_STACK.
10103 * xdisp.c (message_enable_multibyte): Now static.
10104
61c2b50e 10105 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10106 This makes it easier for human readers (and static analyzers)
10107 to see whether these variables are used from other modules.
10108 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10109 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10110 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10111 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10112 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10113 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10114 * xmenu.c, xselect.c:
10115 Declare Q* vars static if they are not used in other modules.
10116 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10117 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10118 Remove decls of unexported vars.
10119 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10120
95c82688
PE
10121 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10122
16a97296
PE
10123 Make Emacs functions such as Fatom 'static' by default.
10124 This makes it easier for human readers (and static analyzers)
10125 to see whether these functions can be called from other modules.
10126 DEFUN now defines a static function. To make the function external
10127 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10128 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10129 (Finit_image_library):
16a97296
PE
10130 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10131 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10132 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10133 Remove decls, since these functions are now static.
10134 (Funintern, Fget_internal_run_time): New decls, since these functions
10135 were already external.
95c82688 10136
16a97296
PE
10137 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10138 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10139 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10140 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10141 * keyboard.c, keymap.c, lread.c:
10142 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10143 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10144 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10145 Mark functions with DEFUE instead of DEFUN,
10146 if they are used in other modules.
10147 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10148 decls for now-static functions.
10149 * buffer.h (Fdelete_overlay): Remove decl.
10150 * callproc.c (Fgetenv_internal): Mark as internal.
10151 * composite.c (Fremove_list_of_text_properties): Remove decl.
10152 (Fcomposition_get_gstring): New forward static decl.
10153 * composite.h (Fcomposite_get_gstring): Remove decl.
10154 * dired.c (Ffile_attributes): New forward static decl.
10155 * doc.c (Fdocumntation_property): New forward static decl.
10156 * eval.c (Ffetch_bytecode): New forward static decl.
10157 (Funintern): Remove extern decl; now in .h file where it belongs.
10158 * fileio.c (Fmake_symbolic_link): New forward static decl.
10159 * image.c (Finit_image_library): New forward static decl.
10160 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10161 * intervals.h (Fprevious_property_change):
10162 (Fremove_list_of_text_properties): Remove decls.
10163 * keyboard.c (Fthis_command_keys): Remove decl.
10164 (Fcommand_execute): New forward static decl.
10165 * keymap.c (Flookup_key): New forward static decl.
10166 (Fcopy_keymap): Now static.
10167 * keymap.h (Flookup_key): Remove decl.
10168 * process.c (Fget_process): New forward static decl.
10169 (Fprocess_datagram_address): Mark as internal.
10170 * syntax.c (Fsyntax_table_p): New forward static decl.
10171 (skip_chars): Remove duplicate decl.
10172 * textprop.c (Fprevious_property_change): New forward static decl.
10173 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10174 Now internal.
10175 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10176 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10177
785bbd42
PE
10178 * editfns.c (Fformat): Remove unreachable code.
10179
8b913b57
AS
101802011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10181
10182 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10183 change. (Bug#8496)
10184
a6744a35
EZ
101852011-04-13 Eli Zaretskii <eliz@gnu.org>
10186
10187 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10188 when at ZV. (Bug#8487)
10189
e7974947
AS
101902011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10191
baad03f0
AS
10192 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10193 (Bug#8437)
10194 * keyboard.c (parse_tool_bar_item): Likewise.
10195 * sound.c (sound_cleanup, alsa_close): Likewise.
10196 * termcap.c (tgetent): Likewise.
10197 * xfns.c (x_default_font_parameter): Likewise.
10198 * xsettings.c (read_and_apply_settings): Likewise.
10199
e7974947
AS
10200 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10201 (overrun_check_free): Protoize.
10202
28272684
PE
102032011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10204
10205 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10206 since callers should never pass a negative size.
10207 Change the signature to match that of plain 'read' and 'write'; see
10208 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10209 * lisp.h: Update prototypes of emacs_write and emacs_read.
10210
11997c76
EZ
102112011-04-11 Eli Zaretskii <eliz@gnu.org>
10212
10213 * xdisp.c (redisplay_window): Don't try to determine the character
10214 position of the scroll margin if the window start point w->startp
e896f03c 10215 is outside the buffer's accessible region. (Bug#8468)
11997c76 10216
8a2cbd72
EZ
102172011-04-10 Eli Zaretskii <eliz@gnu.org>
10218
10219 Fix write-region and its subroutines for buffers > 2GB.
10220 * fileio.c (a_write, e_write): Modify declaration of arguments and
10221 local variables to support buffers larger than 2GB.
10222 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10223
10224 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10225 argument, local variables, and return value.
10226
10227 * lisp.h: Update prototypes of emacs_write and emacs_read.
10228
10229 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10230
4073e537 102312011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10232
1ebfdcb6
PE
10233 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10234
b2ded58d
PE
10235 Fix more problems found by GCC 4.6.0's static checks.
10236
7d66342c
PE
10237 * xdisp.c (vmessage): Use a better test for character truncation.
10238
bbf47d44
PE
10239 * charset.c (load_charset_map): <, not <=, for optimization,
10240 and to avoid potential problems with integer overflow.
9248994d 10241 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10242 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10243 * editfns.c (Fformat): Likewise.
1e69125e 10244 * syntax.c (skip_chars): Likewise.
3befa583 10245
e3019616
PE
10246 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10247 This also lets GCC 4.6.0 generate slightly better loop code.
10248
becfa255
PE
10249 * callint.c (Fcall_interactively): <, not <=, for optimization.
10250 (Fcall_interactively): Count the number of arguments produced,
10251 not the number of arguments given. This is simpler and lets GCC
10252 4.6.0 generate slightly better code.
10253
dae0cd48
PE
10254 * ftfont.c: Distingish more carefully between FcChar8 and char.
10255 The previous code passed unsigned char * to a functions like
10256 strlen and xstrcasecmp that expect char *, which does not
10257 conform to the C standard.
10258 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10259 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10260 char * when the C standard requires it.
10261
76032d70
PE
10262 * keyboard.c (read_char): Remove unused var.
10263
eb3f1cc8
PE
10264 * eval.c: Port to Windows vsnprintf (Bug#8435).
10265 Include <limits.h>.
10266 (SIZE_MAX): Define if the headers do not.
10267 (verror): Do not give up if vsnprintf returns a negative count.
10268 Instead, grow the buffer. This ports to Windows vsnprintf, which
10269 does not conform to C99. Problem reported by Eli Zaretskii.
10270 Also, simplify the allocation scheme, by avoiding the need for
10271 calling realloc, and removing the ALLOCATED variable.
10272
70476b54
PE
10273 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10274
12020a9e
PE
10275 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10276 But keep the doprint source code for now, as we might revamp it
10277 and use it again (Bug#8435).
ea6c7ae6
PE
10278 * lisp.h (doprnt): Remove.
10279 * Makefile.in (base_obj): Remove doprnt.o.
10280 * deps.mk (doprnt.o): Remove.
10281
5fdb398c
PE
10282 error: Print 32- and 64-bit integers portably (Bug#8435).
10283 Without this change, on typical 64-bit hosts error ("...%d...", N)
10284 was used to print both 32- and 64-bit integers N, which relied on
10285 undefined behavior.
61bdb816 10286 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10287 * lisp.h (error, verror): Mark as printf-like functions.
10288 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10289 Report overflow in size calculations when allocating printf buffer.
10290 Do not truncate output string at its first null byte.
10291 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10292 Truncate the output at a character boundary, since vsnprintf does not
10293 do that.
10294 * charset.c (check_iso_charset_parameter): Convert internal
10295 character to string before calling 'error', since %c now has the
10296 printf meaning.
10297 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10298 overflow when computing char to be passed to 'error'. Do not
10299 pass Lisp_Object to 'error'; pass the integer instead.
10300 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10301 formatted with plain %d.
10302
b189fa66
PE
10303 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10304
bff87ef0
PE
10305 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10306
7e2cac20
PE
10307 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10308
ce4d90b5
PE
10309 * xterm.c (x_catch_errors): Remove duplicate declaration.
10310
266c9547
PE
10311 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10312
79c49ad2
PE
10313 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10314
368f4090
JM
103152011-04-10 Jim Meyering <meyering@redhat.com>
10316
10317 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10318 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10319 return ssize_t not "int", and use size_t as the buffer length.
10320 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10321 * gnutls.h: Update declarations.
10322 * process.c (read_process_output): Use ssize_t, to match.
10323 (send_process): Likewise.
10324
a32d4040
CY
103252011-04-09 Chong Yidong <cyd@stupidchicken.com>
10326
10327 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10328
8546720e 103292011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10330
04f2d78b
CB
10331 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10332 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10333
8546720e
GM
10334 * xterm.c (handle_one_xevent):
10335 * xmenu.c (create_and_show_popup_menu):
10336 * xselect.c (x_decline_selection_request)
10337 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10338
0a2f5c1a 103392011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10340
10341 Fix some uses of `int' instead of EMACS_INT.
10342 * search.c (string_match_1, fast_string_match)
10343 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10344 (scan_buffer, find_next_newline_no_quit)
10345 (find_before_next_newline, search_command, Freplace_match)
10346 (Fmatch_data): Make some `int' variables be EMACS_INT.
10347
10348 * xdisp.c (display_count_lines): 3rd argument and return value now
10349 EMACS_INT. All callers changed.
10350 (pint2hrstr): Last argument is now EMACS_INT.
10351
10352 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10353 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10354 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10355 (decode_coding_utf_16, decode_coding_emacs_mule)
10356 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10357 (decode_coding_ccl, decode_coding_charset)
10358 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10359 (decode_coding_iso_2022, decode_coding_emacs_mule)
10360 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10361 <char_offset, last_offset>: Declare EMACS_INT.
10362 (encode_coding_utf_8, encode_coding_utf_16)
10363 (encode_coding_emacs_mule, encode_invocation_designation)
10364 (encode_designation_at_bol, encode_coding_iso_2022)
10365 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10366 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10367 Declare EMACS_INT.
10368 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10369 (encode_invocation_designation): Last argument P_NCHARS is now
10370 EMACS_INT.
10371 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10372 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10373
10374 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10375 All users changed.
10376
10377 * ccl.c (Fccl_execute_on_string): Declare some variables
10378 EMACS_INT.
10379
8546720e 103802011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10381
10382 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10383
4e19a977
CS
103842011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10385
10386 * process.c (Fformat_network_address): Doc fix.
10387
87302331
R
103882011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10389
ee7683eb 10390 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10391
cbb59342
CY
103922011-04-08 Chong Yidong <cyd@stupidchicken.com>
10393
10394 * keyboard.c (read_char): Call Lisp function help-form-show,
10395 instead of using internal_with_output_to_temp_buffer.
10396 (Qhelp_form_show): New var.
e0d38eeb 10397 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10398
10399 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10400
10401 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10402
e67a13ab
CY
104032011-04-06 Chong Yidong <cyd@stupidchicken.com>
10404
04f2d78b
CB
10405 * process.c (Flist_processes): Remove to Lisp.
10406 (list_processes_1): Delete.
e67a13ab 10407
973f782d
EZ
104082011-04-06 Eli Zaretskii <eliz@gnu.org>
10409
7c106b1e
EZ
10410 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10411
973f782d
EZ
10412 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10413
41cf7d1a 104142011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10415
ca23cc88
PE
10416 Fix more problems found by GCC 4.6.0's static checks.
10417
f390e2d5
PE
10418 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10419
42eea0d0
PE
10420 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10421
b69769da 10422 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10423
f9541e84
PE
10424 * xdisp.c (vmessage): Mark as a printf-like function.
10425
13841b55
PE
10426 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10427
c136c10f
PE
10428 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10429
5e2d4a30
PE
10430 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10431 printf-like functions.
10432 (tiff_load): Add casts to remove these marks before passing them
10433 to system-supplied API.
10434
583f48b9
PE
10435 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10436
b25d760e
PE
10437 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10438 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10439 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10440 directly, rather than having caller test rule sign. This avoids
10441 some unnecessary tests.
10442 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10443 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10444 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10445
bc7b6697 10446 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10447 (xfont_open): Avoid unnecessary tests.
bc7b6697 10448
27ccc379
PE
10449 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10450
dcd5c89a
PE
10451 * composite.h, composite.c (composition_gstring_put_cache):
10452 Use EMACS_INT, not int, for length.
10453
b13a45c6
PE
10454 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10455 breaking out part of COMPOSITION_DECODE_RULE.
10456 (COMPOSITION_DECODE_RULE): Use it.
10457 * composite.c (get_composition_id): Remove unused local vars,
10458 by using the new macro.
10459
1e792e4d
PE
10460 * textprop.c (set_text_properties_1): Change while to do-while,
10461 since the condition is always true at first.
10462
dc6c6455 10463 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10464 (interval_deletion_adjustment): Return unsigned value.
10465 All uses changed.
dc6c6455 10466
aba7731a
PE
10467 * process.c (list_processes_1, create_pty, read_process_output):
10468 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10469 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10470 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10471 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10472 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10473
fdfc4bf3
PE
10474 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10475
fca8fe46 10476 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10477 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10478
06a0259a 10479 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10480 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10481 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10482
e7b9e80f
PE
10483 * print.c (print_error_message): Avoid int overflow.
10484
56201685
PE
10485 * font.c (font_list_entities): Redo for clarity,
10486 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10487
78834453 10488 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10489 (font_score): Avoid potential overflow in diff calculation.
78834453 10490
0bc0b309 10491 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10492 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10493
e610eaca
PE
10494 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10495
b895abce
PE
10496 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10497 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10498 can always succeed if overflow has undefined behavior.
10499
1f1d9321 10500 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10501 (wordify): Omit three unnecessary tests.
1f1d9321 10502
c59478bc
PE
10503 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10504 All callers changed. This avoids the need for an unused var.
10505
79b73827
PE
10506 * casefiddle.c (casify_region): Remove var that is set but not used.
10507
a4db5dfe
PE
10508 * dired.c (file_name_completion): Remove var that is set but not used.
10509
43aae36e
PE
10510 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10511
2a47c44d 10512 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10513 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10514
a37c69bf
PE
10515 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10516 Check for integer overflow on size calculations.
10517
328ab8e7
PE
10518 * buffer.c (Fprevious_overlay_change): Remove var that is set
10519 but not used.
10520
e5a2a5cb
PE
10521 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10522 Remove vars that are set but not used.
8d84a6eb 10523 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10524 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10525
a60e5f68
PE
10526 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10527
f661cb61 10528 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10529 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10530
f0397f5a
PE
10531 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10532 that are set but not used.
10533
8664db06 10534 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10535 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10536
6abdaa4a
PE
10537 * xselect.c (x_get_local_selection, x_handle_property_notify):
10538 Remove vars that are set but not used.
10539
0ce7538d 10540 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10541 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10542
9ae848fc
PE
10543 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10544 Remove var that is set but not used.
0b918413
PE
10545 (scroll_bar_windows_size): Now size_t, not int.
10546 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10547 Check for overflow.
9ae848fc 10548
a5a62657
PE
10549 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10550 (map_tty_color) [!defined MSDOS]: Likewise.
10551
5c5cdd39
PE
10552 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10553
66ebf983
PE
10554 * coding.c: Remove vars that are set but not used.
10555 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10556 All callers changed.
10557 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10558 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10559 (decode_coding_charset): Remove vars that are set but not used.
10560
1be4d761
PE
10561 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10562 that is set but not used.
10563
47553fa8
PE
10564 * print.c (print_object): Remove var that is set but not used.
10565
1f7196bf 10566 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10567 The gnulib version avoids calling malloc in the usual case,
10568 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10569 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10570 * filelock.c (current_lock_owner): Likewise.
10571 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10572 * sysdep.c: Include allocator.h, careadlinkat.h.
10573 (emacs_no_realloc_allocator): New static constant.
10574 (emacs_readlink): New function.
fdb61804
PE
10575 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10576 ../lib/careadlinkat.h.
d1fdcab7 10577
f84c17c7
SM
105782011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10579
10580 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10581 first non-nil return value).
10582
ef3862ad
JD
105832011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10584
10585 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10586 if not defined (Bug#8403).
10587
376a7006
JB
105882011-04-02 Juanma Barranquero <lekktu@gmail.com>
10589
10590 * xdisp.c (display_count_lines): Remove parameter `start',
10591 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10592 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10593 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10594 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10595 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10596 and thereabouts. All callers changed.
10597 (get_per_char_metric): Remove parameter `f', unused since
10598 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10599
6ca3801d
JM
106002011-04-02 Jim Meyering <meyering@redhat.com>
10601
10602 do not dereference NULL upon failed strdup
10603 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10604 (ns_get_family): Likewise.
10605
d8e2b5ba
JB
106062011-04-02 Juanma Barranquero <lekktu@gmail.com>
10607
10608 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10609
8c74fcbd
JD
106102011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10611
10612 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10613 later (Bug#8403).
10614
7200d79c
SM
106152011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10616
03408648 10617 Add lexical binding.
7200d79c 10618
03408648
SM
10619 * window.c (Ftemp_output_buffer_show): New fun.
10620 (Fsave_window_excursion):
10621 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10622
10623 * lread.c (lisp_file_lexically_bound_p): New function.
10624 (Fload): Bind Qlexical_binding.
10625 (readevalloop): Remove `evalfun' arg.
10626 Bind Qinternal_interpreter_environment.
10627 (Feval_buffer): Bind Qlexical_binding.
10628 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10629 Mark as dynamic.
10630 (syms_of_lread): Declare `lexical-binding'.
10631
10632 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10633
10634 * keyboard.c (eval_dyn): New fun.
10635 (menu_item_eval_property): Use it.
ca105506
SM
10636
10637 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10638
03408648
SM
10639 * fns.c (concat, mapcar1): Accept byte-code-functions.
10640
10641 * eval.c (Fsetq): Handle lexical vars.
10642 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10643 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10644 (FletX, Flet): Obey lexical binding.
10645 (Fcommandp): Handle closures.
10646 (Feval): New `lexical' arg.
10647 (eval_sub): New function extracted from Feval. Use it almost
10648 everywhere where Feval was used. Look up vars in lexical env.
10649 Handle closures.
10650 (Ffunctionp): Move from subr.el.
10651 (Ffuncall): Handle closures.
10652 (apply_lambda): Remove `eval_flags'.
10653 (funcall_lambda): Handle closures and new byte-code-functions.
10654 (Fspecial_variable_p): New function.
10655 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10656 but without exporting it to Lisp.
23aba0ea 10657
23aba0ea 10658 * doc.c (Fdocumentation, store_function_docstring):
03408648 10659 * data.c (Finteractive_form): Handle closures.
23aba0ea 10660
03408648
SM
10661 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10662 interactive spec.
ba83908c 10663
04f2d78b
CB
10664 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10665 New byte-codes.
03408648
SM
10666 (exec_byte_code): New function extracted from Fbyte_code to handle new
10667 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10668
03408648 10669 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10670
03408648 10671 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10672
e2abce01
JB
106732011-03-31 Juanma Barranquero <lekktu@gmail.com>
10674
10675 * xdisp.c (redisplay_internal): Fix prototype.
10676
63696a73 106772011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10678
63696a73 10679 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10680 (try_scrolling): Use it when setting scroll_limit.
10681 Limit scrolling to 100 screen lines.
63696a73
EZ
10682 (redisplay_window): Even when falling back on "recentering",
10683 position point in the window according to scroll-conservatively,
10684 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10685
10686 (try_scrolling): When point is above the window, allow searching
10687 as far as scroll_max, or one screenful, to compute vertical
10688 distance from PT to the scroll margin position. This prevents
10689 try_scrolling from unnecessarily failing when
10690 scroll-conservatively is set to a value slightly larger than the
10691 window height. Clean up the case of PT below the margin at bottom
10692 of window: scroll_max can no longer be INT_MAX. When aggressive
10693 scrolling is in use, don't let point enter the opposite scroll
10694 margin as result of the scroll.
10695 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10696 threshold of 100 lines for never-recentering scrolling.
10697
e4cc2dfc
JB
106982011-03-31 Juanma Barranquero <lekktu@gmail.com>
10699
10700 * dispextern.h (move_it_by_lines):
10701 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10702 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10703 (message_log_check_duplicate): Remove parameters `prev_bol' and
10704 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10705 (redisplay_internal): Remove parameter `preserve_echo_area',
10706 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10707
10708 * indent.c (Fvertical_motion):
10709 * window.c (window_scroll_pixel_based, Frecenter):
10710 Don't pass `need_y_p' to `move_it_by_lines'.
10711
1c470562
SM
107122011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10713
44f230aa
SM
10714 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10715 steal a few bits to be more compact.
10716 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10717 Remove unneeded casts.
10718
1c470562
SM
10719 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10720
888adce9
ZK
107212011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10722
10723 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10724 binding" message (bug#7967).
10725
f838ed7b
PE
107262011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10727
77861b95
PE
10728 Fix more problems found by GCC 4.6.0's static checks.
10729
de6dbc14
PE
10730 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10731 Remove unused local var.
10732
f838ed7b
PE
10733 * editfns.c (Fmessage_box): Remove unused local var.
10734
792c7b2b
PE
10735 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10736 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10737 Omit unused local vars.
c499e557 10738 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10739 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10740 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10741 Omit unused local var.
10742
ba0165e1
PE
10743 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10744 Don't assume string length fits in int.
32ad8845 10745 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10746 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10747
3c59b4c9
PE
10748 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10749 instead of alloca (Bug#8344).
10750
a3eed478 10751 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10752 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10753
eb4d412d
PE
10754 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10755
1658b401
PE
10756 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10757 concerns.
10758
10759 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10760
10761 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10762
9a2c6e05
PE
10763 * keyboard.c (syms_of_keyboard): Use the same style as later
10764 in this function when indexing through an array. This also
10765 works around GCC bug 48267.
10766
03d0a109
PE
10767 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10768
44f730c8
PE
10769 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10770
fe75f926
PE
10771 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10772 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10773
ffa8c828
PE
10774 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10775 This avoids undefined behavior on integer overflow, and is a bit
10776 more convenient anyway since it is compared to a size_t variable.
10777
c5101a77
PE
10778 Variadic C functions now count arguments with size_t, not int.
10779 This avoids an unnecessary limitation on 64-bit machines, which
10780 caused (substring ...) to crash on large vectors (Bug#8344).
10781 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10782 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10783 All variadic functions and their callers changed accordingly.
c5101a77
PE
10784 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10785 * data.c (arith_driver, float_arith_driver): Likewise.
10786 * editfns.c (general_insert_function): Likewise.
10787 * eval.c (struct backtrace.nargs, interactive_p)
10788 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10789 (funcall_lambda, mark_backtrace): Likewise.
10790 * fns.c (concat): Likewise.
10791 * frame.c (x_set_frame_parameters): Likewise.
10792 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10793 0 if not found, not -1. All callers changed.
10794
dd3f25f7
PE
10795 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10796 (stack_copy_size): Now size_t, not int.
10797 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10798
461c2ab9
JB
107992011-03-28 Juanma Barranquero <lekktu@gmail.com>
10800
10801 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10802 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10803 All callers changed.
10804
10805 * lisp.h (multibyte_char_to_unibyte):
10806 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10807 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10808 * character.h (CHAR_TO_BYTE8):
10809 * cmds.c (internal_self_insert):
10810 * editfns.c (general_insert_function):
10811 * keymap.c (push_key_description):
10812 * search.c (Freplace_match):
10813 * xdisp.c (message_dolog, set_message_1): All callers changed.
10814
f6d62986
SM
108152011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10816
10817 * keyboard.c (safe_run_hook_funcall): New function.
10818 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10819 don't set the hook to nil, but remove the offending function instead.
10820 (Qcommand_hook_internal): Remove, unused.
10821 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10822 Vcommand_hook_internal.
10823
10824 * eval.c (enum run_hooks_condition): Remove.
10825 (funcall_nil, funcall_not): New functions.
10826 (run_hook_with_args): Call each function through a `funcall' argument.
10827 Remove `cond' argument, now redundant.
10828 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10829 (Frun_hook_with_args_until_failure): Adjust accordingly.
10830 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10831
1db5b1ad
JB
108322011-03-28 Juanma Barranquero <lekktu@gmail.com>
10833
10834 * dispextern.h (string_buffer_position): Remove declaration.
10835
10836 * print.c (strout): Remove parameter `multibyte', unused since
10837 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10838
10839 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10840 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10841 All callers changed.
10842
10843 * w32.c (_wsa_errlist): Use braces for struct initializers.
10844
10845 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10846 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10847 All callers changed.
10848 (string_buffer_position): Likewise. Also, make static (it's never
10849 used outside xdisp.c).
10850 (cursor_row_p): Remove parameter `w', unused since
10851 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10852 (decode_mode_spec): Remove parameter `precision', introduced during
10853 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10854 All callers changed.
10855
5ffb62aa
JD
108562011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10857
10858 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10859
461c2ab9 108602011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10861
10862 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10863 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10864 (ns_update_auto_hide_menu_bar): New functions.
10865 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10866 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10867 ns_constrain_all_frames.
10868 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10869 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10870
5c380ffb
JD
108712011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10872
10873 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10874
9af30bdf
GM
108752011-03-27 Glenn Morris <rgm@gnu.org>
10876
10877 * syssignal.h: Replace RETSIGTYPE with void.
10878 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10879 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10880 Replace SIGTYPE with void everywhere.
10881 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10882 * s/template.h (SIGTYPE): Remove commented out definition.
10883
e2abce01
JB
108842011-03-26 Eli Zaretskii <eliz@gnu.org>
10885
10886 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10887 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10888
f868cd8a
JB
108892011-03-26 Juanma Barranquero <lekktu@gmail.com>
10890
59eb0929
JB
10891 * w32.c (read_unc_volume): Use parameter `henum', instead of
10892 global variable `wget_enum_handle'.
10893
10894 * keymap.c (describe_vector): Remove parameters `indices' and
10895 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10896 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10897
f868cd8a
JB
10898 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10899
10900 * keyboard.c (timer_check): Remove parameter `do_it_now',
10901 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10902 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10903 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10904
10905 * keyboard.c (read_char):
10906 * w32menu.c (w32_menu_display_help):
10907 * xmenu.c (show_help_event, menu_help_callback):
10908 Adjust calls to `show_help_echo'.
10909
10910 * gtkutil.c (xg_maybe_add_timer):
10911 * keyboard.c (readable_events):
10912 * process.c (wait_reading_process_output):
10913 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10914
10915 * insdel.c (adjust_markers_gap_motion):
10916 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10917 (gap_left, gap_right): Don't call it.
10918
2ecf6fdb
CY
109192011-03-25 Chong Yidong <cyd@stupidchicken.com>
10920
10921 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10922 incurred during fontification.
10923
6b1f9ba4
JB
109242011-03-25 Juanma Barranquero <lekktu@gmail.com>
10925
10926 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10927 (DEFVAR_PER_BUFFER): Don't pass it.
10928
10929 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10930 (scrolling_window): Don't pass it.
10931
0f4a96b5
JB
109322011-03-25 Juanma Barranquero <lekktu@gmail.com>
10933
10934 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10935
10936 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10937 and `suffix'.
10938 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10939 of variables specific to SELinux and computation of `encoded_absname'.
10940
10941 * image.c (XPutPixel): Remove unused variable `height'.
10942
10943 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10944
10945 * unexw32.c (get_section_info): Remove unused variable `section'.
10946
10947 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10948 (system_process_attributes): Remove unused variable `sess'.
10949 (sys_read): Remove unused variable `err'.
10950
10951 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10952 (w32_wnd_proc): Remove unused variable `isdead'.
10953 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10954 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10955 (x_create_tip_frame): Remove unused variable `tem'.
10956
10957 * w32inevt.c (w32_console_read_socket):
10958 Remove unused variable `no_events'.
10959
10960 * w32term.c (x_draw_composite_glyph_string_foreground):
10961 Remove unused variable `width'.
10962
1149507c
JB
109632011-03-24 Juanma Barranquero <lekktu@gmail.com>
10964
10965 * w32term.c (x_set_glyph_string_clipping):
10966 Don't pass uninitialized region to CombineRgn.
10967
9c88f339
JB
109682011-03-23 Juanma Barranquero <lekktu@gmail.com>
10969
10970 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10971 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10972 (Fx_close_connection): Remove unused variable `i'.
10973
10974 * w32font.c (w32font_draw): Return number of glyphs.
10975 (w32font_open_internal): Remove unused variable `i'.
10976 (w32font_driver): Add missing initializer.
10977
10978 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10979 (fill_in_menu): Remove unused variable `items_added'.
10980
10981 * w32term.c (last_mouse_press_frame): Remove static global variable.
10982 (w32_clip_to_row): Remove unused variable `f'.
10983 (x_delete_terminal): Remove unused variable `i'.
10984
10985 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10986 (NOTHING): Remove unused static global variable.
10987 (uniscribe_check_otf): Remove unused variable `table'.
10988 (uniscribe_font_driver): Add missing initializers.
10989
dee091a3
JD
109902011-03-23 Julien Danjou <julien@danjou.info>
10991
10992 * term.c (Fsuspend_tty, Fresume_tty):
10993 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10994 * window.c (temp_output_buffer_show):
10995 * insdel.c (signal_before_change):
10996 * frame.c (Fhandle_switch_frame):
10997 * fileio.c (Fdo_auto_save):
10998 * emacs.c (Fkill_emacs):
10999 * editfns.c (save_excursion_restore):
11000 * cmds.c (internal_self_insert):
11001 * callint.c (Fcall_interactively):
11002 * buffer.c (Fkill_all_local_variables):
11003 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11004 Use Frun_hooks.
0f4a96b5 11005 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11006 unconditionally since it does the check itself.
dee091a3 11007
2c520ab5 110082011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11009
c9c49752
PE
11010 Fix more problems found by GCC 4.5.2's static checks.
11011
8abc3f12
PE
11012 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11013 the first time through the loop, since we know p0 < p1 then.
11014 This also avoids a gcc -Wstrict-overflow warning.
11015
a2d26660
PE
11016 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11017 leading to a memory leak, possible in functions like
11018 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11019 of objects (Bug#8318).
a2d26660 11020
916c72e9
PE
11021 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11022 that could (at least in theory) be that large.
11023
19ab8a18
PE
11024 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11025 This is less likely to overflow, and avoids undefined behavior if
11026 overflow does occur. All callers changed. Use strtoul to scan
11027 for the unsigned long integer.
b7cbbd6f
PE
11028 (pint2hrstr): Simplify and tune code slightly.
11029 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11030
f0641eff
PE
11031 * scroll.c (do_scrolling): Work around GCC bug 48228.
11032 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11033
7f650bb9
PE
11034 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11035 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11036 (validate_x_resource_name): Simplify count usage.
11037 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11038
37dd57d1
PE
11039 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11040 fail (Bug#8306).
81e56e61 11041
699979fc 11042 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11043
401bf9b4
PE
11044 * process.c (Fmake_network_process): Use socklen_t, not int,
11045 where POSIX says socklen_t is required in portable programs.
11046 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11047 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11048 (Fmake_network_process, server_accept_connection):
11049 (wait_reading_process_output, read_process_output):
11050 Likewise.
11051
b93aacde
PE
11052 * process.c: Rename or move locals to avoid shadowing.
11053 (list_processes_1, Fmake_network_process):
11054 (read_process_output_error_handler, exec_sentinel_error_handler):
11055 Rename or move locals.
4dc343ee 11056 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11057 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11058 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11059 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11060 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11061
af8a867c 11062 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11063 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11064 Include tparam.h instead, since it declares them.
af8a867c
PE
11065 * cm.h (PC): Remove extern decl; tparam.h now does this.
11066 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11067 * terminfo.c: Include tparam.h, to check interfaces.
11068 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11069 (tparam): Adjust signature to match interface in tparam.h;
11070 this removes some undefined behavior. Check that outstring and len
11071 are zero, which they always are with Emacs.
11072 * tparam.h (PC, BC, UP): New extern decls.
11073
0248044d 11074 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11075 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11076
8ff096c1 11077 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11078 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11079 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11080 (ftfont_list): Remove unused local.
49eaafba
PE
11081 (get_adstyle_property, ftfont_pattern_entity):
11082 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11083 Rename locals to avoid shadowing.
8ff096c1 11084
e2be39f6
PE
11085 * xfont.c (xfont_list_family): Mark var as initialized.
11086
c9735e30
PE
11087 * xml.c (make_dom): Now static.
11088
8f5201ae
PE
11089 * composite.c (composition_compute_stop_pos): Rename local to
11090 avoid shadowing.
b246f932
PE
11091 (composition_reseat_it): Remove unused locals.
11092 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11093 (composition_update_it): Mark var as initialized.
11b61122
PE
11094 (find_automatic_composition): Mark vars as initialized,
11095 with a FIXME (Bug#8290).
8f5201ae 11096
760fbc2c
PE
11097 character.h: Rename locals to avoid shadowing.
11098 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11099 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11100 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11101 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11102 to avoid shadowing.
11103
ff08eb85
PE
11104 * textprop.c (property_change_between_p): Remove; unused.
11105
fc7bf025
PE
11106 * intervals.c (interval_start_pos): Now static.
11107
235d7abc
PE
11108 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11109
44f230aa
SM
11110 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11111 Rename locals to avoid shadowing.
3e7d6594 11112
50060332
PE
11113 * sound.c (wav_play, au_play, Fplay_sound_internal):
11114 Fix pointer signedness.
d01f234b 11115 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11116 (wav_play): Initialize a variable to 0, to prevent undefined
11117 behavior (Bug#8278).
50060332 11118
c4fc4e30
PE
11119 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11120
918436ed
PE
11121 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11122
c939f91b
PE
11123 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11124 clobbering (Bug#8298).
b9c7f648
PE
11125 * sysdep.c (sys_subshell): Likewise.
11126 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11127
6bd8c144
PE
11128 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11129 This should get cleaned up, so that child_setup has the
11130 same signature on all platforms.
11131
7710357c 11132 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11133 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11134
c59da222
CY
111352011-03-22 Chong Yidong <cyd@stupidchicken.com>
11136
11137 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11138 not to be necessary, and produces flickering.
11139
66b87493
GM
111402011-03-20 Glenn Morris <rgm@gnu.org>
11141
11142 * config.in: Remove file.
11143
45b6f6d5
JB
111442011-03-20 Juanma Barranquero <lekktu@gmail.com>
11145
11146 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11147 are now in src/globals.h.
11148 (syms_of_minibuf): Remove spurious & from previous change.
11149
cd394be1 111502011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11151
11152 * minibuf.c (completing-read-function): New variable.
11153 (completing-read-default): Rename from completing-read.
11154 (completing-read): Call completing-read-function.
11155
b14e3e21
CY
111562011-03-19 Juanma Barranquero <lekktu@gmail.com>
11157
11158 * xfaces.c (Fx_load_color_file):
11159 Read color file from absolute filename (bug#8250).
11160
f2b726e6
JB
111612011-03-19 Juanma Barranquero <lekktu@gmail.com>
11162
11163 * makefile.w32-in: Update dependencies.
11164
09f6ff02
EZ
111652011-03-17 Eli Zaretskii <eliz@gnu.org>
11166
11167 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11168
29a6015a
PE
111692011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11170
a3a6c54e
PE
11171 Fix more problems found by GCC 4.5.2's static checks.
11172
b766f867
PE
11173 * process.c (make_serial_process_unwind, send_process_trap):
11174 (sigchld_handler): Now static.
11175
be02381c
PE
11176 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11177 That way, the code declares only the vars that it needs.
11178 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11179 * s/cygwin.h (PTY_ITERATION): Likewise.
11180 * s/darwin.h (PTY_ITERATION): Likewise.
11181 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11182
57048744
PE
11183 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11184 * process.c (allocate_pty): Don't declare stb unless it's needed.
11185
7914961c 11186 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11187 (CONSTANTLIM): Remove; unused.
11188 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11189 Define only if needed.
7914961c 11190
b3967b18
PE
11191 * unexelf.c (unexec): Name an expression,
11192 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11193 Use a different way to cause a compilation error if anyone uses
11194 n rather than nn, a way that does not involve shadowing.
73366a00 11195 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11196
29a6015a
PE
11197 * deps.mk (unexalpha.o): Remove; unused.
11198
43cfc33e 11199 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11200 * unexec.h: New file.
ce701a33
PE
11201 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11202 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11203 Depend on unexec.h.
11204 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11205 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11206 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11207 Change as necessary to match prototype in unexec.h.
ce701a33 11208
01f44d5a
PE
11209 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11210 shadowing.
4f63c6bb 11211 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11212
a6670b0b
PE
11213 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11214 Rename locals to avoid shadowing.
11215
cef2010d 11216 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11217 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11218
d4d7173a
PE
11219 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11220
f08b802a
PE
11221 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11222 warning when compiling print.c.
11223
3ddb0639
PE
11224 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11225 instead of using an uninitialized var.
5ad03b97 11226 (font_sort_entities): Mark var as initialized.
3ddb0639 11227
170a2692
PE
11228 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11229
e663c700
PE
11230 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11231 pointers to constants.
89bc529a 11232 (font_parse_fcname): Remove unused vars.
7b81e2d0 11233 (font_delete_unmatched): Now static.
ea838e10 11234 (font_get_spec): Remove; unused.
13a547c6
PE
11235 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11236 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11237 Rename or move locals to avoid shadowing.
e663c700 11238
2a80c887 11239 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11240 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11241
1384fa33 11242 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11243 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11244
8b2c52e9
PE
11245 * alloc.c (mark_backtrace): Move decl from here ...
11246 * lisp.h: ... to here, so that it can be checked.
11247
475545b5 11248 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11249 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11250 (lisp_indirect_variable): Name an expression,
11251 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11252 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11253
b1349114 11254 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11255 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11256 Use const pointer when appropriate.
b1349114 11257
a2928364
PE
11258 * lisp.h (get_system_name, get_operating_system_release):
11259 Move decls here, to check interfaces.
11260 * process.c (get_operating_system_release): Move decl to lisp.h.
11261 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11262 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11263 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11264 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11265 (Fformat_time_string, Fencode_time, Finsert_char):
11266 (Ftranslate_region_internal, Fformat):
11267 Rename or remove local vars to avoid shadowing.
9710023e 11268 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11269
a415e694
PE
11270 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11271 avoid shadowing.
11272
8ef4622d
PE
11273 * lisp.h (eassert): Check that the argument compiles, even if
11274 ENABLE_CHECKING is not defined.
11275
946f9a5b
PE
11276 * data.c (Findirect_variable): Name an expression, to avoid
11277 gcc -Wbad-function-cast warning.
112396d6 11278 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11279 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11280 (Fmake_variable_buffer_local, Fmake_local_variable):
11281 Mark variables as initialized.
52746918 11282 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11283
e5aab7e7 11284 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11285 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11286 Rename locals to avoid shadowing.
dff45157
PE
11287 (mark_stack): Move local variables into the #ifdef region where
11288 they're used.
7bc26fdb
PE
11289 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11290 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11291 needed otherwise.
11292 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11293 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11294 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11295
e5aab7e7
PE
11296 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11297 avoids undefined behavior in theory.
11298
4da60324
PE
11299 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11300
88043301
PE
11301 Use functions, not macros, for up- and down-casing (Bug#8254).
11302 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11303 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11304 to use the following functions instead of these macros.
11305 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11306 EMACS_INT, since callers assume the returned value fits in int.
11307 (upcase1): Likewise, for UPCASE_TABLE.
11308 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11309 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11310 the race-condition problem in the old DOWNCASE.
88043301 11311
19ed5445
PE
11312 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11313 Rename locals to avoid shadowing.
11314 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11315 (regex_compile, re_search_2, re_match_2_internal):
11316 Remove unused local vars.
952db0d7
PE
11317 (FREE_VAR): Rewrite so as not to use empty "else",
11318 which gcc can warn about.
da053e48 11319 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11320 (RETALLOC_IF): Define only if needed.
11321 (WORDCHAR_P): Likewise. This one is never needed, but is used
11322 only in a comment talking about a compiler bug, so put inside
11323 the #if 0 of that comment.
11324 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11325 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11326 Remove; unused.
19ed5445 11327
1f3561e4 11328 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11329 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11330 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11331
ded6f8f7
PE
11332 * search.c (simple_search): Remove unused var.
11333
dbd37a95
PE
11334 * dired.c (compile_pattern): Move decl from here ...
11335 * lisp.h: ... to here, so that it can be checked.
11336 (struct re_registers): New forward decl.
11337
7e47afad
PE
11338 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11339
85f24f61
PE
11340 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11341 All uses changed.
11342 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11343 Rename locals to avoid shadowing.
5671df8f 11344 (Fvertical_motion): Mark locals as initialized.
85f24f61 11345
181aa2be 11346 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11347 (casify_region): Mark local as initialized.
181aa2be 11348
930d429c
PE
11349 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11350
7082eac6
PE
11351 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11352 New macros, so that the caller can use some names other than
11353 gcpro1, gcpro2, etc.
11354 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11355 of the new macros.
11356 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11357 argument, for consistency with GCPRO2_VAR, etc: it is now the
11358 prefix of the variable, not the variable itself. All uses
11359 changed.
38b2c076
PE
11360 * dired.c (directory_files_internal, file_name_completion):
11361 Rename locals to avoid shadowing.
11362
15206ed9
PE
11363 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11364 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11365 dired.c's scmp function, had undefined behavior.
11366 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11367 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11368 * buffer.h: ... to here, because these macros use current_buffer,
11369 and the new implementation with inline functions needs to have
11370 current_buffer in scope now, rather than later when the macros
11371 are used.
11372 (downcase, upcase1): New static inline functions.
11373 (DOWNCASE, UPCASE1): Reimplement using these functions.
11374 This avoids undefined behavior in expressions like
11375 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11376 from race conditions in accessing the global variables
11377 case_temp1 and case_temp2.
11378 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11379 * lisp.h (case_temp1, case_temp2): Remove their decls.
11380 * character.h (ASCII_CHAR_P): Move from here ...
11381 * lisp.h: ... to here, so that the inline functions mentioned
11382 above can use them.
11383
4a6bea26
PE
11384 * dired.c (directory_files_internal_unwind): Now static.
11385
f14b7e14
PE
11386 * fileio.c (file_name_as_directory, directory_file_name):
11387 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11388 Now static.
2893f146
PE
11389 (file_name_as_directory): Use const pointers when appropriate.
11390 (Fexpand_file_name): Likewise. In particular, newdir might
11391 point at constant storage, so make it a const pointer.
fd4ead52 11392 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11393 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11394 signedness issues.
f839df0c
PE
11395 (Fset_file_times, Finsert_file_contents, auto_save_error):
11396 Rename locals to avoid shadowing.
f14b7e14 11397
5716756e 11398 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11399 (Ftry_completion, Fall_completions): Rename or remove locals
11400 to avoid shadowing.
5716756e 11401
b4c3046a
PE
11402 * marker.c (bytepos_to_charpos): Remove; unused.
11403
b45db522
PE
11404 * lisp.h (verify_bytepos, count_markers): New decls,
11405 so that gcc does not warn that these functions aren't declared.
11406
85876d07
PE
11407 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11408 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11409 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11410 (copy_text): Remove unused local var.
85876d07 11411
03d78a21 11412 * filelock.c (within_one_second): Now static.
b3dd38ab 11413 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11414
5df8f01b
PE
11415 * buffer.c (fix_overlays_before): Mark locals as initialized.
11416 (fix_start_end_in_overlays): Likewise. This function should be
11417 simplified by using pointers-to-pointers, but that's a different
11418 matter.
b1d876f1 11419 (switch_to_buffer_1): Now static.
8f54f30a
PE
11420 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11421 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11422
a70072c9 11423 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11424 Fix pointer signedness issue.
edced198
PE
11425 (sys_subshell): Mark local as volatile if checking for lint,
11426 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11427 (MAXPATHLEN): Define only if needed.
a70072c9 11428
a0977c44
PE
11429 * process.c (serial_open, serial_configure): Move decls from here ...
11430 * systty.h: ... to here, so that they can be checked.
11431
a884fdcc
PE
11432 * fns.c (get_random, seed_random): Move extern decls from here ...
11433 * lisp.h: ... to here, so that they can be checked.
11434
604efe86 11435 * sysdep.c (reset_io): Now static.
b8950c94 11436 (wait_for_termination_signal): Remove; unused.
604efe86 11437
38fc62d9
PE
11438 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11439 (copy_keymap_item, append_key, push_text_char_description):
11440 Now static.
1004a21a 11441 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11442 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11443 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11444 (describe_map_tree):
11445 Rename locals to avoid shadowing.
38fc62d9 11446
2f2650da
PE
11447 * keyboard.c: Declare functions static if they are not used elsewhere.
11448 (echo_char, echo_dash, cmd_error, top_level_2):
11449 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11450 (read_char, kbd_buffer_get_event, make_lispy_position):
11451 (make_lispy_event, make_lispy_movement, apply_modifiers):
11452 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11453 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11454 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11455 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11456 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11457
a053e86c 11458 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11459 (mark_kboards): Move decl here ...
11460 * alloc.c (mark_kboards): ... from here.
a053e86c 11461
4752793e
PE
11462 * lisp.h (force_auto_save_soon): New decl.
11463
74f10ca7 11464 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11465 (DEFINE_DUMMY_FUNCTION): New macro.
11466 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11467 Use it.
c03cd23f
PE
11468 (main): Add casts to avoid warnings
11469 if GCC considers string literals to be constants.
74f10ca7 11470
022e70d4
PE
11471 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11472
59d6fe83
PE
11473 * dbusbind.c: Pointer signedness fixes.
11474 (xd_signature, xd_append_arg, xd_initialize):
11475 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11476 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11477 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11478 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11479
78320123
PE
11480 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11481 if GCC considers string literals to be constants.
49cebcca 11482 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11483
35ac2a97
SM
114842011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11485
fb103ca9
SM
11486 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11487 (print_preprocess, print_object): New macro to fix last change.
11488
35ac2a97
SM
11489 * print.c (print_preprocess): Don't forget font objects.
11490
62973b41
JB
114912011-03-16 Juanma Barranquero <lekktu@gmail.com>
11492
11493 * emacs.c (USAGE3): Doc fixes.
11494
0e48bb22
AS
114952011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11496
11497 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11498 structure.
11499
7684e57b
JB
115002011-03-14 Juanma Barranquero <lekktu@gmail.com>
11501
11502 * lisp.h (VWindow_system, Qfile_name_history):
11503 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11504 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11505 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11506
11507 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11508 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11509
11510 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11511 * w32console.c (detect_input_pending, read_input_pending)
11512 (encode_terminal_code):
11513 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11514 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11515 (w32_system_caret_y, Qfile_name_history):
11516 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11517 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11518 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11519 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11520 * w32proc.c (Qlocal, report_file_error):
11521 * w32term.c (Vwindow_system, updating_frame):
11522 * w32uniscribe.c (initialized, uniscribe_font_driver):
11523 Remove unneeded extern declarations.
11524
2aa46d6c
CY
115252011-03-14 Chong Yidong <cyd@stupidchicken.com>
11526
c96bbc66 11527 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11528
cffc6f3b
CY
115292011-03-13 Chong Yidong <cyd@stupidchicken.com>
11530
11531 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11532 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11533 These macros can no longer be used for assignment.
11534
44f230aa
SM
11535 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11536 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11537 (record_buffer_markers, fetch_buffer_markers): New functions for
11538 recording and fetching special buffer markers.
11539 (set_buffer_internal_1, set_buffer_temp): Use them.
11540
11541 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11542
11543 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11544
11545 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11546 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11547
11548 * xdisp.c (hscroll_window_tree):
11549 (reconsider_clip_changes): Use PT instead of BUF_PT.
11550
d251f04b
EZ
115512011-03-13 Eli Zaretskii <eliz@gnu.org>
11552
11553 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11554 $(EMACS_ROOT)/lib/intprops.h.
11555
f0c77cd1
PE
115562011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11557
3eca4629
PE
11558 Fix more problems found by GCC 4.5.2's static checks.
11559
7c86ee98
PE
11560 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11561 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11562 (xg_free_frame_widgets): Make it clear that a local variable is
11563 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11564 (gdk_window_get_screen): Make it clear that this macro is needed
11565 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11566 (int_gtk_range_get_value): New function, which avoids a diagnostic
11567 from gcc -Wbad-function-cast.
11568 (xg_set_toolkit_scroll_bar_thumb): Use it.
11569 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11570 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11571 (get_utf8_string, xg_get_file_with_chooser):
11572 Rename locals to avoid shadowing.
11573 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11574
41729b81
PE
11575 * xgselect.c (xg_select): Remove unused var.
11576
f0c77cd1
PE
11577 * image.c (four_corners_best): Mark locals as initialized.
11578 (gif_load): Initialize transparent_p to zero (Bug#8238).
11579 Mark another local as initialized.
ec6cf4c6 11580 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11581
ce0ad53d 11582 * image.c (clear_image_cache): Now static.
d5d5a617 11583 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11584 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11585 (x_edge_detection): Remove unnecessary cast that
11586 gcc -Wbad-function-cast diagnoses.
2037898d 11587 (gif_load): Fix pointer signedness.
6ae141d6
PE
11588 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11589 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11590
33383987 115912011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11592
d32df629
PE
11593 Improve quality of tests for time stamp overflow.
11594 For example, without this patch (encode-time 0 0 0 1 1
11595 1152921504606846976) returns the obviously-bogus value (-948597
11596 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11597 reports time overflow. See
11598 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11599 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11600 * editfns.c: Include limits.h and intprops.h.
11601 (TIME_T_MIN, TIME_T_MAX): New macros.
11602 (time_overflow): Move earlier, to before first use.
11603 (hi_time, lo_time): New functions, for an accurate test for
11604 out-of-range times.
11605 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11606 (Fget_internal_run_time): Don't assume time_t fits in int.
11607 (make_time): Use list2 instead of Fcons twice.
11608 (Fdecode_time): More accurate test for out-of-range times.
11609 (check_tm_member): New function.
11610 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11611 (lisp_time_argument): Don't rely on undefined left-shift and
11612 right-shift behavior when checking for time stamp overflow.
8be6f318 11613
fe31d94c
PE
11614 * editfns.c (time_overflow): New function, refactoring common code.
11615 (Fformat_time_string, Fdecode_time, Fencode_time):
11616 (Fcurrent_time_string): Use it.
11617
8be6f318
PE
11618 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11619 * dired.c (make_time): Move to ...
11620 * editfns.c (make_time): ... here.
11621 * systime.h: Note the move.
11622
09d9db2c 116232011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11624
126bc0dc
YM
11625 * fringe.c (update_window_fringes): Remove unused variables.
11626
c47cbdfd
YM
11627 * unexmacosx.c (copy_data_segment): Also copy __got section.
11628 (Bug#8223)
11629
7ac80be9
EZ
116302011-03-12 Eli Zaretskii <eliz@gnu.org>
11631
c96bbc66 11632 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11633 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11634 Constify `char *' arguments and their references according to
11635 prototypes in tparam.h.
11636
ecb0f94d 11637 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11638
7ac80be9
EZ
11639 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11640 Adapt all references accordingly.
11641
11642 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11643
ef1fd07e
TT
116442011-03-11 Tom Tromey <tromey@redhat.com>
11645
11646 * buffer.c (syms_of_buffer): Remove obsolete comment.
11647
7ef4b50c
EZ
116482011-03-11 Eli Zaretskii <eliz@gnu.org>
11649
11650 * termhooks.h (encode_terminal_code): Declare prototype.
11651
11652 * msdos.c (encode_terminal_code): Don't declare prototype.
11653
11654 * term.c (encode_terminal_code): Now external again, used by
11655 w32console.c and msdos.c.
11656
44f230aa
SM
11657 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11658 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11659
4b1ec863 116602011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11661
1714f52b 11662 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11663
4b1ec863
PE
11664 * fringe.c (update_window_fringes): Mark locals as initialized
11665 (Bug#8227).
11666 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11667
524c7aa6
PE
11668 * alloc.c (mark_fringe_data): Move decl from here ...
11669 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11670 to check its interface.
11671 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11672
a5c0af81 11673 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11674 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11675 (fontset_font): Mark local as initialized.
a9a06e0b 11676 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11677
b4716021
PE
11678 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11679
811e9bac 11680 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11681 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11682 (x_own_selection, Fx_disown_selection_internal): Rename locals
11683 to avoid shadowing.
11684 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11685
7e3ab302
PE
11686 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11687 so that the caller can use some name other than gcpro1.
11688 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11689 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11690 (Fx_backspace_delete_keys_p):
11691 Use them to avoid shadowing, and rename vars to avoid shadowing.
11692 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11693 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11694 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11695 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11696 Remove unused locals.
7e3ab302
PE
11697 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11698 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11699 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11700 macros.
f78faa98 11701
e2b13473
PE
11702 * xterm.h (x_mouse_leave): New decl.
11703
77f23912
PE
11704 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11705 Remove unused functions.
cdf4ba58
PE
11706 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11707 (x_calc_absolute_position): Now static.
7411c686 11708 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11709 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11710 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11711 unless they are used.
38d0b34a
PE
11712 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11713 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11714 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11715 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11716 (x_error_catcher, x_connection_closed, x_error_handler):
11717 (x_error_quitter, xembed_send_message, x_iconify_frame):
11718 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11719 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11720 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11721
44f230aa
SM
11722 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11723 Rename or move locals to avoid shadowing.
6b463e58 11724 (tty_defined_color, merge_face_heights): Now static.
5967d051 11725 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11726 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11727 does not deduce is never used uninitialized.
73719eba
PE
11728 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11729 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11730
426994c3 11731 * terminal.c (store_terminal_param): Now static.
5489860b 11732
032f1620 11733 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11734 (set_frame_menubar): Remove unused local.
d4323972 11735 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11736 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11737 since they might point to immutable storage.
281585b0
PE
11738 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11739 since it's unused otherwise.
032f1620 11740
367c19e5 11741 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11742 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11743 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11744 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11745 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11746 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11747 does not deduce are never used uninitialized.
70739cbe 11748
07b48fa9
PE
11749 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11750
8868a238 11751 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11752 * window.c (window_loop, size_window):
11753 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11754
7e5cf297 11755 * window.c (display_buffer): Now static.
d6550a9f
PE
11756 (size_window): Mark variables that gcc -Wuninitialized
11757 does not deduce are never used uninitialized.
a586633d
PE
11758 * window.h (check_all_windows): New decl, to forestall
11759 gcc -Wmissing-prototypes diagnostic.
5b555da1 11760 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11761
f6095868
PE
11762 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11763 shadowing.
11764 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11765 Include <limits.h>.
11766 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11767 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11768 (load_charset_map): Mark variables that gcc -Wuninitialized
11769 does not deduce are never used uninitialized.
53df7c11 11770 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11771
f38b440c
PE
11772 * coding.c (coding_set_source, coding_set_destination):
11773 Use "else { /* comment */ }" rather than "else /* comment */;"
11774 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11775 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11776 a block, when the outer 'i' will do.
11777 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11778 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11779 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11780 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11781 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11782 Rename locals to avoid shadowing.
11783 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11784 * coding.c (emacs_mule_char, encode_invocation_designation):
11785 Now static, since they're not used elsewhere.
413bb2db 11786 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11787 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11788 (decode_coding_emacs_mule): Mark variables that gcc
11789 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11790 (detect_coding_iso_2022): Initialize a local variable that might
11791 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11792 this initialization is needed. (Bug#8211)
5f58e762
PE
11793 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11794 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11795 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11796 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11797 Remove unused macros.
f38b440c 11798
232b38b9 11799 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11800 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11801 * character.c (string_count_byte8): Likewise.
232b38b9 11802
fb90da1b
PE
11803 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11804 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11805
fb93dbc2
PE
11806 * chartab.c (copy_sub_char_table): Now static, since it's not used
11807 elsewhere.
5c156ace
PE
11808 (sub_char_table_ref_and_range, char_table_ref_and_range):
11809 Rename locals to avoid shadowing.
bbcd0949 11810 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11811
7d3b3862 11812 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11813 (BIDI_BOB): Remove unused macro.
7d3b3862 11814
6be7d3da
PE
11815 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11816 deduce are never used uninitialized.
c2ed9c8b 11817 * term.c (encode_terminal_code): Likewise.
6be7d3da 11818
75f8807f 11819 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11820
50938595
PE
11821 * tparam.h: New file.
11822 * term.c, tparam.h: Include it.
11823 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11824 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11825 Move these decls to tparam.h, and make them agree with what
11826 is actually in tparam.c. The previous trick of using incompatible
11827 decls in different modules does not conform to the C standard.
11828 All callers of tparam changed to use tparam's actual API.
11829 * tparam.c (tparam1, tparam, tgoto):
11830 Use const pointers where appropriate.
11831
fbceeba2
PE
11832 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11833 * cm.h (struct cm): Likewise.
11834 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11835 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11836 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11837 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11838 (turn_on_face, init_tty): Likewise.
11839 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11840
7f3f1250
PE
11841 * term.c (term_mouse_position): Rename local to avoid shadowing.
11842
e6ca6543
PE
11843 * alloc.c (mark_ttys): Move decl from here ...
11844 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11845
c40f8d15
AS
118462011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11847
11848 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11849
cfe0661d
JB
118502011-03-09 Juanma Barranquero <lekktu@gmail.com>
11851
11852 * search.c (compile_pattern_1): Remove argument regp, unused since
11853 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11854 (compile_pattern): Don't pass it.
11855
0afb4571
J
118562011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11857
11858 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11859 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11860 for ! HAVE_GTK3.
11861 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11862
11863 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11864
11865 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11866 gdk_window_get_screen, gdk_window_get_geometry,
11867 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11868 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11869 (xg_get_pixbuf_from_pixmap): New function.
11870 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11871 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11872 Call xg_get_pixbuf_from_pixmap instead of
11873 gdk_pixbuf_get_from_drawable.
11874 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11875 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11876 (xg_check_special_colors): Use GtkStyleContext and its functions
11877 for HAVE_GTK3.
11878 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11879 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11880 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11881 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11882 Call gtk_widget_get_preferred_size.
0afb4571
J
11883 (xg_frame_resized): gdk_window_get_geometry only takes 5
11884 parameters.
44f230aa
SM
11885 (xg_win_to_widget, xg_event_is_for_menubar):
11886 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11887 (xg_set_widget_bg): New function.
11888 (delete_cb): New function.
895009e1 11889 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11890 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11891 (xg_set_background_color): Call xg_set_widget_bg.
11892 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11893 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11894 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11895 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11896 if ! HAVE_GTK3.
11897 (update_frame_tool_bar): Call gtk_widget_hide.
11898 (xg_initialize): Use GDK_KEY_g.
11899
11900 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11901 if ! HAVE_GTK3
11902 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11903
11904 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11905 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11906 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11907
1c2cc4ef
JB
119082011-03-08 Juanma Barranquero <lekktu@gmail.com>
11909
11910 * w32xfns.c (select_palette): Check success of RealizePalette against
11911 GDI_ERROR, not zero.
11912
33383987 11913See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11914
11915;; Local Variables:
11916;; coding: utf-8
aac0c6e3
MR
11917;; End:
11918
2f097256 11919 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11920
11921 This file is part of GNU Emacs.
11922
11923 GNU Emacs is free software: you can redistribute it and/or modify
11924 it under the terms of the GNU General Public License as published by
11925 the Free Software Foundation, either version 3 of the License, or
11926 (at your option) any later version.
11927
11928 GNU Emacs is distributed in the hope that it will be useful,
11929 but WITHOUT ANY WARRANTY; without even the implied warranty of
11930 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11931 GNU General Public License for more details.
11932
11933 You should have received a copy of the GNU General Public License
11934 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.